Fix usage of FRAME_MENU_BAR_ITEMS in w32menu.c.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5f50daf2
EZ
12012-08-06 Eli Zaretskii <eliz@gnu.org>
2
3 * w32menu.c (set_frame_menubar, initialize_frame_menubar): Don't
4 use FRAME_MENU_BAR_ITEMS as an lvalue.
5
cbcc7007
SM
62012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
7
8 * buffer.h (struct buffer): Revert `indirections' to a simple int;
9 that should be sufficient for everyone.
10
4d365fa4
JD
112012-08-06 Jan Djärv <jan.h.d@swipnet.se>
12
13 * keyboard.c (timer_check_2): Add break so timer_check returns next
14 timeout.
15
dd86bd82
DA
162012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
17
18 Fix Windows build errors introduced after converting to WGET and WSET.
19 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
20 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
21
054e1668
JD
222012-08-06 Jan Djärv <jan.h.d@swipnet.se>
23
24 * nsterm.m (ns_frame_rehighlight): Use FSET.
25
26 * nsmenu.m (ns_update_menubar): Use FSET.
27
21238f11
DA
282012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
29
30 Separate read and write access to Lisp_Object slots of Lisp_Process.
31 * process.h (PGET, PSET): New macros similar to AREF and ASET.
32 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
33
077288cf
DA
342012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
35
36 Separate read and write access to Lisp_Object slots of struct window.
37 * window.h (WGET, WSET): New macros similar to AREF and ASET.
38 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
39 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
40 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
41 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
42 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
43 Adjust users.
44
71688bd7
DA
452012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
46
47 Fix Windows build errors introduced after converting to FGET and FSET.
48 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
49 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
50 (w32_judge_scroll_bars): Change to use FSET.
51 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
52
f99bac93
DA
532012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
54
55 Fix replacement typo.
56 * window.c (replace_window): Set root_window instead of
57 selected_window. This fixes a total window subsystem
58 malfunction reported by Bastien Guerry <bzg@gnu.org>.
59
8c2a0f2d
GM
602012-08-06 Glenn Morris <rgm@gnu.org>
61
62 * lisp.mk (lisp): Add language/persian.elc.
63
edd74c35
DA
642012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
65
66 Separate read and write access to Lisp_Object slots of struct frame.
67 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
68 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
69 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
70 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
71 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
72
8671676c
AS
732012-08-05 Andreas Schwab <schwab@linux-m68k.org>
74
75 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
76
663e2b3f
DA
772012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
78
79 Generalize common compile-time constants.
80 * lisp.h (header_size, bool_header_size, word_size): Now here.
81 (struct Lisp_Vector): Add comment.
82 (struct Lisp_Bool_Vector): Move up to define handy constants.
83 (VECSIZE, PSEUDOVECSIZE): Simplify.
84 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
85 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
86 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
87 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
88 * xfont.c, xmenu.c: Use word_size where appropriate.
89
d32e47af
LM
902012-08-05 Lawrence Mitchell <wence@gmx.li>
91
92 * search.c (Freplace_match): Treat \? in the replacement text
93 literally (Bug#8161).
94
e5d9c0d1
CY
952012-08-05 Chong Yidong <cyd@gnu.org>
96
97 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
98 * frame.c (Vdelete_frame_functions):
99 * emacs.c (Vkill_emacs_hook): Doc fix.
100
8da0576b
EZ
1012012-08-04 Eli Zaretskii <eliz@gnu.org>
102
103 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
104 --with-x-toolkit=no builds.
105 Reported by Carsten Mattner <carstenmattner@gmail.com>.
106
02676e5d
CY
1072012-08-04 Chong Yidong <cyd@gnu.org>
108
109 * syntax.c (Fmodify_syntax_entry): Doc fix.
110
97147da9
EZ
1112012-08-04 Eli Zaretskii <eliz@gnu.org>
112
76151e2c
EZ
113 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
114 * w32.c (init_environment): Change the default values of many
115 environment variables in dflt_envvars[] to NULL, to avoid pushing
116 them into environment when they were not already defined. Remove
117 the code that deletes site-lisp subdirectories from the default
118 value of EMACSLOADPATH, as it is no longer needed.
119 (check_windows_init_file): Now external, not static. Use
120 Vload_path as is, without adding anything, as this function is now
121 called when Vload_path is already set up.
122
123 * w32.h (check_windows_init_file): Add prototype.
124
125 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
126 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
127 compatibility with Posix platforms.
128 (main): Move the call to check_windows_init_file to here from
129 w32.c.
130 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
131 any, in the DEFALT argument into the root of the Emacs build or
132 installation tree, as appropriate.
133
134 * callproc.c (init_callproc_1): Call decode_env_path instead of
135 doing its equivalent by hand.
136 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
137 the code that sets Vexec_path run on MS-Windows.
138
139 * lread.c (init_lread): Add comments to #ifdef's.
140
97147da9
EZ
141 * msdos.c (dos_set_window_size, IT_update_begin)
142 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
143 instead of direct references.
144
185ee146
PE
1452012-08-04 Paul Eggert <eggert@cs.ucla.edu>
146
147 Export DEFAULT_REHASH_* to GDB.
148 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
149 Now constants, not macros.
150
8834c57a
PE
1512012-08-03 Paul Eggert <eggert@cs.ucla.edu>
152
98c6f1e3
PE
153 Remove unnecessary casts involving pointers.
154 These casts are no longer needed now that we assume C89 or later,
155 since they involve casting to or from void *.
156 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
157 (make_pure_float, make_pure_vector):
158 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
159 * macros.c (Fstart_kbd_macro):
160 * menu.c (find_and_return_menu_selection):
161 * minibuf.c (read_minibuf_noninteractive):
162 * sysdep.c (closedir):
163 * xdisp.c (x_produce_glyphs):
164 * xfaces.c (compare_fonts_by_sort_order):
165 * xfns.c (x_real_positions, select_visual):
166 * xselect.c (x_stop_queuing_selection_requests)
167 (x_get_window_property, x_get_window_property_as_lisp_data):
168 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
169 Remove unnecessary pointer casts.
170 * alloc.c (record_xmalloc): New function.
171 * lisp.h (record_xmalloc): New decl.
172 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
173 more like a function. This is because the pointer cast is not
174 needed. All uses changed.
175 * print.c (print_string, print_error_message): Avoid length recalc.
176
8834c57a
PE
177 Improve fix for macroexp crash with debugging (Bug#12118).
178 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
179 ARRAY_MARK_FLAG when checking subscripts, because ASET is
180 not supposed to be invoked from the garbage collector.
181 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
182 (gc_aset): New function, which is like ASET but can be
183 used in the garbage collector.
184 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
185 (set_hash_index): Use it instead of ASET.
186
6dad7178
EZ
1872012-08-03 Eli Zaretskii <eliz@gnu.org>
188
189 Support symlinks on latest versions of MS-Windows.
190 * w32.c: Include winioctl.h and aclapi.h.
191 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
192 (revert_to_self): Forward declarations of static functions.
193 <static BOOL g_b_init_get_security_info>:
194 <g_b_init_create_symbolic_link>: New static flags.
195 (globals_of_w32): Initialize them to zero.
196 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
197 (map_w32_filename): Improve commentary. Simplify switch.
198 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
199 headers (most versions of MinGW w32api don't).
200 (get_security_info, create_symbolic_link)
201 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
202 New functions.
203 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
204 in the argument file name.
205 (sys_access): Call unc_volume_file_attributes only if
206 GetFileAttributes fails with network-related error codes.
207 (sys_rename): Diagnose renaming of a symlink when the user doesn't
208 have the required privileges.
209 (get_file_security_desc_by_name): Renamed from
210 get_file_security_desc.
211 (stat_worker): New function, with most of the guts of 'stat', and
212 with addition of handling of symlinks and support for 'lstat'. If
213 possible, get file's attributes and security information by
214 handle, not by name. Produce S_IFLNK bit for symlinks, when
215 called from 'lstat'.
216 (stat, lstat): New functions, call 'stat_worker'.
217 (symlink, readlink, careadlinkat): Rewritten to create and resolve
218 symlinks when the underlying filesystem supports them.
219
f162bcc3
PE
2202012-08-02 Paul Eggert <eggert@cs.ucla.edu>
221
79ea6c20
PE
222 Fix macroexp crash on Windows with debugging (Bug#12118).
223 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
224 checking subscripts; problem introduced with the recent
225 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
226 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
227 since it's used in non-static inline functions now.
228
c0ce93fd
PE
229 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
230 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 231
f162bcc3
PE
232 Use C99-style 'extern inline' if available.
233 * buffer.h (BUFFER_INLINE):
234 * category.h (CATEGORY_INLINE):
235 * character.h (CHARACTER_INLINE):
236 * charset.h (CHARSET_INLINE):
237 * composite.h (COMPOSITE_INLINE):
238 * dispextern.h (DISPEXTERN_INLINE):
239 * lisp.h (LISP_INLINE):
240 * systime.h (SYSTIME_INLINE):
241 New macro, replacing 'static inline' in this header.
242 * buffer.h, category.h, character.h, charset.h, composite.h:
243 * dispextern.h, lisp.h, systime.h:
244 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
245 * alloc.c (LISP_INLINE):
246 * buffer.c (BUFFER_INLINE):
247 * category.c (CATEGORY_INLINE):
248 * character.c (CHARACTER_INLINE):
249 * charset.c (CHARSET_INLINE):
250 * composite.c (COMPOSITE_INLINE):
251 * dispnew.c (DISPEXTERN_INLINE):
252 * sysdep.c (SYSTIME_INLINE):
253 Define to EXTERN_INLINE, so that the corresponding functions
254 are compiled into code.
255 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
256 (INLINE_HEADER_END): New macros.
257 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
258 since it's used in non-static inline functions now.
a8333d03 259 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 260
837b365b
GM
2612012-08-02 Glenn Morris <rgm@gnu.org>
262
d66b744d
GM
263 * s/: Remove empty directory.
264
837b365b
GM
265 * s/ms-w32.h: Move to ../nt/inc.
266 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
267 Update for new ms-w32.h location.
268
13294f95
PE
2692012-08-02 Paul Eggert <eggert@cs.ucla.edu>
270
271 Port to Solaris 8.
272 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
273
90df0db3
GM
2742012-08-02 Glenn Morris <rgm@gnu.org>
275
276 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
277 hard-coding the path separator.
278
4939150c
PE
2792012-08-01 Paul Eggert <eggert@cs.ucla.edu>
280
281 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
282 This how ASET and AREF are supposed to work, and makes
283 it easier to think about future improvements. See
284 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
285 * charset.h (set_charset_attr): New function.
286 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
287 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
288 (aref_addr): New function. All uses of &AREF(...) changed.
289 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
290 (set_hash_index): New functions. All lvalue-style uses of
291 HASH_KEY etc. changed.
292 * keyboard.c (set_prop): New function. All lvalue-style uses
293 of PROP changed.
294
947b2afd
AA
2952012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
296
297 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
298 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
299 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
300 * nsfns.m (ns_set_name_as_filename): Likewise.
301 * nsmenu.m (ns_update_menubar): Likewise.
302 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
303
4f5d0325
EZ
3042012-08-01 Eli Zaretskii <eliz@gnu.org>
305
2008beae
EZ
306 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
307 Adapt to latest changes in field names of the corresponding Lisp
288479f6 308 objects.
2008beae 309
4f5d0325
EZ
310 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
311
fe3cc771
GM
3122012-08-01 Glenn Morris <rgm@gnu.org>
313
314 * s/msdos.h: Remove file.
315 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
316 * Makefile.in (S_FILE): Remove.
317 (config_h): Remove S_FILE.
318
c90acc54
JB
3192012-08-01 Juanma Barranquero <lekktu@gmail.com>
320
321 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
322 Remove; moved to nt/config.nt.
323
d8a05828
DA
3242012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
325
326 Use INTERNAL_FIELD for conses and overlays.
327 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
328 Remove obsolete comment.
329 (MVAR): New macro.
330 (struct Lisp_Overlay): Use INTERNAL_FIELD.
331 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
332
8271d590
DA
3332012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
334
335 Use INTERNAL_FIELD for symbols.
336 * lisp.h (SVAR): New macro. Adjust users.
337 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
338 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
339
3193acd2
DA
3402012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
341
342 Use INTERNAL_FIELD for processes.
343 * process.h (PVAR): New macro. Adjust style.
344 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
345 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
346
3a45383a
DA
3472012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
348
349 Use INTERNAL_FIELD for windows.
350 * window.h (WVAR): New macro.
351 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
352 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
353 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
354 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
355 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
356 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
357
c1dbc63c
PE
3582012-08-01 Paul Eggert <eggert@cs.ucla.edu>
359
360 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
361
5c0c0e8a
GM
3622012-08-01 Glenn Morris <rgm@gnu.org>
363
364 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
365 Move to configure.ac.
366
552a99b4
JB
3672012-08-01 Juanma Barranquero <lekktu@gmail.com>
368
369 * makefile.w32-in (CONFIG_H): Update dependencies.
370 (CONF_POST_H): New macro.
371
372 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
373
8d8e2dfe
GM
3742012-07-31 Glenn Morris <rgm@gnu.org>
375
bc96620a
GM
376 * Makefile.in (S_FILE): No longer set by configure.
377
476b1b2d
GM
378 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
379 is available.
380 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
381
b2c7a106
GM
382 * process.h (NULL_DEVICE):
383 * emacs.c (SEPCHAR):
384 * editfns.c (USER_FULL_NAME): Let configure set them.
385
d53d062a
GM
386 * s/README, s/template.h: Remove files.
387
4515017f
GM
388 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
389
8d8e2dfe
GM
390 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
391 Move to configure.ac.
392
5b20b3cc
EZ
3932012-07-31 Eli Zaretskii <eliz@gnu.org>
394
1e0afd9a
EZ
395 * .gdbinit (xframe): Adapt to introduction of FVAR and the
396 resulting renaming of 'struct frame' members.
397
5b20b3cc
EZ
398 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
399
400 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
401 after introduction of FVAR.
402
f1310128
JD
4032012-07-31 Jan Djärv <jan.h.d@swipnet.se>
404
79e721e0
JD
405 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
406
407 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
408 instead of compositeToPoint.
409 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
410
8d7c7eed 411 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 412
e34f7f79
DA
4132012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
414
415 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
416 * lisp.h (INTERNAL_FIELD): New macro.
417 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
418 (BVAR): Change to use INTERNAL_FIELD.
419 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
420 (KVAR): Change to use INTERNAL_FIELD.
421 * frame.h (FVAR): New macro.
422 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
423 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
424 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
425 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
426 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
427
c09bfb2f
DA
4282012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
429
430 Miscellaneous fixes for non-default X toolkits.
431 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
432 * xterm.c (x_frame_of_widget): Remove redundant prototype.
433 Move under #ifdef USE_LUCID.
434 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
435 definition and usage to avoid warnings.
436
14c114ae
JD
4372012-07-31 Jan Djärv <jan.h.d@swipnet.se>
438
439 * nsterm.m (openFiles): Fix previous checkin.
440
3bd21e82
PE
4412012-07-31 Paul Eggert <eggert@cs.ucla.edu>
442
443 * indent.c (compute_motion): Remove unused local.
444
c1529ded
GM
4452012-07-31 Glenn Morris <rgm@gnu.org>
446
400d5621
GM
447 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
448
268e2432
GM
449 * conf_post.h [USG5_4]:
450 Move remaining contents of s/usg5-4-common.h here.
451 * s/usg5-4-common.h: Remove file.
452
7552f3ee
GM
453 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
454 * s/irix6-5.h: Remove file.
455
6a381852
GM
456 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
457 * s/darwin.h: Remove file.
458
c1529ded
GM
459 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
460 * s/hpux10-20.h: Remove file, which is now empty.
461
b429a4ee
GM
4622012-07-30 Glenn Morris <rgm@gnu.org>
463
464 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
465 * Makefile.in (config_h): Add conf_post.h.
466 * makefile.w32-in (CONFIG_H): Add conf_post.h.
467
adff3182
JD
4682012-07-30 Jan Djärv <jan.h.d@swipnet.se>
469
470 * nsterm.m (ns_do_open_file): New variable.
b9031d69 471 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
472 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
473 files only if ns_do_open_file.
474
c32af1e4
PE
4752012-07-30 Paul Eggert <eggert@cs.ucla.edu>
476
7393bcbb
PE
477 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
478 This no-op macro hasn't been needed for many years.
479 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
480
c32af1e4
PE
481 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
482 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
483 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
484 gdb_make_enums_visible.
485 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
486 (DIRECTORY_SEP): Now a constant, not a macro.
487
302fc036
EZ
4882012-07-30 Eli Zaretskii <eliz@gnu.org>
489
490 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
491 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
492
493 * w32term.c <w32_keyboard_codepage>: Renamed from
494 keyboard_codepage and now external. All users changed.
495
496 * w32term.h: Add declaration of w32_keyboard_codepage.
497
498 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
499 the codepage to translate keys to Unicode. If this argument is
500 -1, use the value returned by GetConsoleCP. All callers changed.
501
88fb40b4
PE
5022012-07-30 Paul Eggert <eggert@cs.ucla.edu>
503
0aee6912
PE
504 Update .PHONY listings in makefiles.
505 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
506 bootstrap-clean, distclean, maintainer-clean, versioclean,
507 extraclean, frc.
508
88fb40b4
PE
509 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
510 This is a bit clearer. Fix some commentary typos.
511
0a763bd1
GM
5122012-07-30 Glenn Morris <rgm@gnu.org>
513
32bac6d6
GM
514 * s/netbsd.h: Let configure include signal.h if needed.
515 Remove file, which is now empty.
516
b65e7c46
GM
517 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
518 Let configure set them.
519 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
520 No more need to undefine.
0a763bd1 521
169304bd
AS
5222012-07-30 Andreas Schwab <schwab@linux-m68k.org>
523
524 * keymap.c (Fkey_description): Don't remove 0x80 bit from
525 non-single-byte char when adding meta modifier. (Bug#12090)
526
6cd7a139
DA
5272012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
528
529 Convert safe_call to use variable number of arguments.
530 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
531 (safe_call2): Fix comment.
532 * lisp.h (safe_call): Adjust prototype.
533 * coding.c (encode_coding_object): Change to use safe_call2.
534 * xfaces.c (merge_face_heights): Change to use safe_call1.
535
d34d6ffc
GM
5362012-07-30 Glenn Morris <rgm@gnu.org>
537
7b8a48e4 538 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 539 does that unconditionally. Remove file, which is now empty.
7b8a48e4 540
d34d6ffc
GM
541 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
542 Remove empty files.
543
03a660a6
PE
5442012-07-30 Paul Eggert <eggert@cs.ucla.edu>
545
546 Export to GDB most of lisp.h's remaining object-like macros.
547 * lisp.h (min, max): Move earlier, because they're used earlier now.
548 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
549 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
550 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
551 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
552 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
553 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
554 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
555 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
556 Now constants, for GDB. They need not be macros.
557 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
558 Now constants, for GDB, as well as macros, for static initializers.
559 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
560 Move to after the definition of struct Lisp_Char_Table,
561 since the former now needs that type defined.
562 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
563 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
564 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
565 New enums, for gdb_make_enums_visible.
566 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 567 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
568 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
569 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
570 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
571 enum maxargs, enum MAX_ALLOCA.
572 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
573 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
574 no longer needed, now that they are done in lisp.h.
575
e499d0ee
DA
5762012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
577
578 Cleanup string bytes checking.
579 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
580 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
581 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
582 (check_sblock, compact_small_strings): Simplify.
583
d5040d2d
PE
5842012-07-29 Paul Eggert <eggert@cs.ucla.edu>
585
586 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
587 These macros are confusing and no longer need to be defined, as
588 the enum values now suffice. All uses replaced with definiens.
589 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
590
7f259ae6
JB
5912012-07-29 Juanma Barranquero <lekktu@gmail.com>
592
593 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
594 ($(BLD)/w32console.$(O)): Update dependencies.
595
7e63e0c3
DA
5962012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
597
598 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
599 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
600 time. Adjust users.
601 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
602
ffd817eb
JD
6032012-07-29 Jan Djärv <jan.h.d@swipnet.se>
604
605 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
606 setting sitelisp (Bug#12010).
607
417a7a0e
EZ
6082012-07-29 Eli Zaretskii <eliz@gnu.org>
609
610 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
611
612 * w32heap.c (cache_system_info):
613 * w32.c (sys_rename):
614 * w32proc.c (find_child_console, sys_kill): All users changed.
615
387d4d92
PE
6162012-07-29 Paul Eggert <eggert@cs.ucla.edu>
617
618 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
619
55a6cca6
EZ
6202012-07-29 Eli Zaretskii <eliz@gnu.org>
621
622 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
623
dbcf001c
DA
6242012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
625
626 Cleanup statistics calculation in Fgarbage_collect.
627 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
628 zombies percentage calculation. Simplify elapsed time calculation.
629
e2688e4a
DA
6302012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
631
632 Generalize marker debugging code under MARKER_DEBUG and use eassert.
633 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
634 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
635 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
636 (replace_range, replace_range_2, del_range_2): Change to eassert.
637 * marker.c (byte_char_debug_check): Adjust style.
638
b46a6a83
PE
6392012-07-29 Paul Eggert <eggert@cs.ucla.edu>
640
641 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
642 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
643 long-ago-commented-out code that talks about "WIN32".
644 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
645 All uses changed.
646
e32a5799
PE
6472012-07-28 Paul Eggert <eggert@cs.ucla.edu>
648
649 Use Gnulib stdalign module (Bug#9772, Bug#9960).
650 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
651 Simplify by using alignof.
652 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
653 * lisp.h: Include <stdalign.h>.
654 (GCALIGNMENT): New macro and constant.
655 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
656 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
657 (stdalign): New macro, if not already defined.
658
df81cd29
EZ
6592012-07-28 Eli Zaretskii <eliz@gnu.org>
660
01bd1b0d
EZ
661 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
662 * w32inevt.c: Include w32inevt.h.
663 (w32_read_console_input): New inline function, calls either
664 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
665 w32_console_unicode_input.
666 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
667 (w32_kbd_patch_key, key_event): Use the codepage returned by
668 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
669 (key_event): use uChar.UnicodeChar only if
670 w32_console_unicode_input is non-zero.
671
672 * w32console.c: Include w32heap.h.
673 <w32_console_unicode_input>: New global variable.
674 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
675 family of Windows, zero otherwise.
676
677 * w32inevt.h: Declare w32_console_unicode_input.
678
df81cd29
EZ
679 * xdisp.c (init_iterator): Don't reference tip_frame in a build
680 --without-x. (Bug#11742)
681
c20fdd9e
PE
6822012-07-27 Paul Eggert <eggert@cs.ucla.edu>
683
684 Adjust GDB to reflect pvec_type changes (Bug#12036).
685 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
686 2012-07-04 changes to pseudovector representation. Problem
687 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
688
32770973 6892012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
690
691 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
692 bus address.
693 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
694
3438fe21
EZ
6952012-07-27 Eli Zaretskii <eliz@gnu.org>
696
bcfbc9de
EZ
697 * alloc.c (listn): Fix the order the arguments are consed onto the
698 list.
699
3438fe21
EZ
700 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
701 enumeration constants, as PURE and HEAP are too general, and clash
702 with other headers and sources, such as gmalloc.c and the
703 MS-Windows system headers. All users changed.
704
eeaea515
DA
7052012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
706
707 Revert last save_excursion_save and save_excursion_restore changes.
708 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
709 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
710
073c88c2
DA
7112012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
712
713 Fix recently-introduced typos in Windows port.
714 Reported by Martin Rudalics <rudalics@gmx.at>.
715 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 716 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 717
4706125e
PE
7182012-07-27 Paul Eggert <eggert@cs.ucla.edu>
719
720 Improve GDB symbol export (Bug#12036).
721 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
722 arms of an 'if', not using conditional expressions; otherwise GDB
723 complains about the types in the unevaluated arm when the argument
724 is an integer literal.
725 (xgetint): Simplify expression.
726 * alloc.c (gdb_make_enums_visible): New constant. This ports to
727 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
728 Zaretskii in <http://bugs.gnu.org/12036#13>.
729 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
730 needed now that we have gdb_make_enums_visible.
731 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
732 (enum enum_USE_LSB_TAG):
733 New enum types, packaging up enums that need to be exported to GDB.
734
694b6c97
DA
7352012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
736
737 Utility function to make a list from specified amount of objects.
738 * lisp.h (enum constype): New datatype.
739 (listn): New prototype.
740 * alloc.c (listn): New function.
741 (Fmemory_use_count, syms_of_alloc): Use it.
742 * buffer.c (syms_of_buffer): Likewise.
743 * callint.c (syms_of_callint): Likewise.
744 * charset.c (define_charset_internal): Likewise.
745 * coding.c (syms_of_coding): Likewise.
746 * keymap.c (syms_of_keymap): Likewise.
747 * search.c (syms_of_search): Likewise.
748 * syntax.c (syms_of_syntax): Likewise.
749 * w32.c (init_environment): Likewise.
750 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
751 * xdisp.c (syms_of_xdisp): Likewise.
752 * xfns.c (syms_of_xfns): Likewise.
753
6195f384
DA
7542012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
755
756 Fast save_excursion_save and save_excursion_restore.
757 * lisp.h (struct Lisp_Excursion): New data type.
758 (PVEC_EXCURSION): New pseudovector type.
759 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
760 to deal with it. Adjust comments.
761 (init_marker, attach_marker): New prototype.
762 (unchain_marker): Adjust prototype.
763 * marker.c (attach_marker): Change to global.
764 (init_marker): New function.
765 * alloc.c (Fmake_marker, build_marker): Use it.
766 (build_marker): More easserts.
767 (mark_object): Handle struct Lisp_Excursion.
768 * editfns.c (save_excursion_save, save_excursion_restore):
769 Reimplement to use struct Lisp_Excursion. Add comments.
770
5eceb8fb
PE
7712012-07-26 Paul Eggert <eggert@cs.ucla.edu>
772
773 Fix export of symbols to GDB (Bug#12036).
774 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
775 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
776 emacs.c, as this is a more-suitable home. Had this been done earlier
777 the fix for 12036 would have avoided some of the problems noted in
778 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
779 would have been more obvious.
562157c8
PE
780 * emacs.c: Do not include <verify.h>; no longer needed.
781 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
782 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
783 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
784 Remove; now done in lisp.h.
785 * lisp.h (PUBLISH_TO_GDB): New macro.
786 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
787 (DATA_SEG_BITS): Use it.
788 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
789 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
790 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
791 not be usable in #if. This simplifies things.
792
d6749401
JB
7932012-07-26 Juanma Barranquero <lekktu@gmail.com>
794
795 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
796
1781b9e9
PE
7972012-07-26 Paul Eggert <eggert@cs.ucla.edu>
798
d89518db 799 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
800 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
801 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
802 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
803 Adjust to changes in lisp.h and emacs.c, by using
804 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
805 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
806 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
807 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
808 instead of gdb_valbits.
809 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
810 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
811 instead of gdb_array_mark_flag.
812 (xboolvector): Get size from $->size, not $->header.size.
813 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
814 (xreload, hook-run, hookpost-run): Remove.
815 * emacs.c: Include <verify.h>.
816 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
817 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
818 Remove.
819 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
820 (gdb_USE_LSB_TAG): New enum constants.
821 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
822 Also define these as enum constants, so they're visible to GDB.
823 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
824 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
825 as constants, so they're visible to GDB.
826 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
827 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
828 Now enum constants, not macros, so they're visible to GDB.
829 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
830 more convenient now. All uses changed.
831 (VALMASK) [USE_LSB_TAG]: Also define in this case.
832 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
833
3628596a
DA
8342012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
835
836 Explicitly free restriction data that are not needed anymore.
837 * editfns.c (save_restriction_restore): Free restriction data.
838
7abaf5cc
SM
8392012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
840
841 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
842 add argument, tune behavior, and adjust all callers.
843
71f88e00
PE
8442012-07-25 Paul Eggert <eggert@cs.ucla.edu>
845
846 Use typedef for EMACS_INT, EMACS_UINT.
847 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
848 than macros. This simplifies debugging in the usual case, since
849 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
850 and it allows expressions involving EMACS_INT casts.
851 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
852
57ec3034
JD
8532012-07-25 Jan Djärv <jan.h.d@swipnet.se>
854
855 * nsterm.m (ns_read_socket): Return early if there is a modal
856 window (Bug#12043).
857
8137e7b3
MR
8582012-07-25 Martin Rudalics <rudalics@gmx.at>
859
860 * frame.c (Fredirect_frame_focus): In doc-string don't mention
861 that FOCUS-FRAME can be omitted.
862
04e9897c
DA
8632012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
864
865 Adjust buffer text indirection counters at the end of Fkill_buffer.
866 * buffer.c (Fkill_buffer): Adjust indirection counters when the
867 buffer is definitely dead. This should really fix an issue reported
868 by Christoph Scholtes again. (Bug#12007).
869 (init_buffer_once): Initialize indirection counters of
870 buffer_defaults and buffer_local_symbols (for sanity and safety).
871
8a0484e1
EZ
8722012-07-24 Eli Zaretskii <eliz@gnu.org>
873
874 * xdisp.c (init_iterator): Don't compute dimensions of truncation
875 and continuation glyphs on tooltip frames, leave them at zero.
876 Avoids continued lines in tooltips. (Bug#11832)
877
fa691a83
DA
8782012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
879
880 Simplify copy_overlay.
04e9897c 881 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
882 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
883
436bc8e0
EZ
8842012-07-23 Eli Zaretskii <eliz@gnu.org>
885
886 * print.c (print_object): Don't crash when a frame's name is nil
887 or invalid. (Bug#12025)
888
889 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
890 it signals an error when a tooltip frame is being created.
891
d7a7fda3
DA
8922012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
893
894 Cleanup miscellaneous objects allocation and initialization.
895 * alloc.c (allocate_misc): Change to static. Add argument to
896 specify the subtype. Adjust comment and users.
897 (build_overlay): New function.
898 * buffer.c (copy_overlays, Fmake_overlay): Use it.
899 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
900 (allocate_misc): Remove prototype.
901 (build_overlay): Add prototype.
902
9032012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
904
905 Swap buffer text indirection counters in Fbuffer_swap_text.
906 * buffer.c (Fbuffer_swap_text): Swap indirections too.
907 This avoids crash reported by Christoph Scholtes at
908 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
909
9d7fa573
JD
9102012-07-22 Jan Djärv <jan.h.d@swipnet.se>
911
912 * nsmenu.m (Popdown_data): New struct.
913 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
914 free Popdown_data.
915 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
916 (initWithContentRect): Make imgView and contentView non-static
917 and autorelease them. Also autorelease img and matrix (Bug#12005).
918 (dealloc): Remove (Bug#12005).
919
0dd6d66d
DA
9202012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
921
922 Adjust consing_since_gc when objects are explicitly freed.
923 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
924 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
925 (free_cons, free_misc): Subtract object size from consing_since_gc.
926
d36d71df
DA
9272012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
928
929 Simplify and cleanup markers positioning code.
930 * marker.c (attach_marker): More useful eassert.
931 (live_buffer, set_marker_internal): New function.
932 (Fset_marker, set_marker_restricted): Use set_marker_internal.
933 (set_marker_both, set_marker_restricted_both): Use live_buffer.
934
fb9ea40f
PE
9352012-07-22 Paul Eggert <eggert@cs.ucla.edu>
936
937 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
938 as it's limited by the amount of memory, not by INT_MAX.
939
2d5c5f7d
EZ
9402012-07-21 Eli Zaretskii <eliz@gnu.org>
941
07fb592e
EZ
942 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
943 in special-event-map. See the discussion at
944 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
945 for the reasons.
946
37a9eac8 947 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
948 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
949 Fabrice Popineau <fabrice.popineau@supelec.fr>.
950
c4328746
JD
9512012-07-21 Jan Djärv <jan.h.d@swipnet.se>
952
953 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 954 (conversationIdentifier): Return value is NSInteger.
784051c4 955 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 956
6e5d1c12
CY
9572012-07-21 Chong Yidong <cyd@gnu.org>
958
959 * window.c (decode_any_window): Signal an error if the window is
960 on a dead frame (Bug#11984).
961
9928463d
DA
9622012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
963
964 Add indirection counting to speed up Fkill_buffer.
965 * buffer.h (struct buffer): New member.
966 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
967 (Fmake_indirect_buffer): Set indirection counter to -1, increment
968 base buffer indirection counter.
969 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
970 (Fkill_buffer): Adjust indirection counters as needed, don't walk
971 through buffer list if indirection counter is 0.
972
f8643a6b
DA
9732012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
974
975 Extend the value returned by Fgarbage_collect with heap statistics.
976 * alloc.c (Qheap): New symbol.
977 (syms_of_alloc): DEFSYM it.
978 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
979 (Fmemory_free): Remove.
980 (syms_of_alloc): Don't defsubr it.
981 * buffer.c (Fcompact_buffer): Remove.
982 (syms_of_buffer): Don't defsubr it.
983
dac616ff
DA
9842012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
985
986 Make maybe_gc inline.
987 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
988 * lisp.h (consing_since_gc, gc_relative_threshold)
989 (memory_full_cons_threshold): Revert declaration.
990 (maybe_gc): Remove prototype, define as inline.
991 * alloc.c: Remove old commented-out code.
992 (consing_since_gc, gc_relative_threshold)
993 (memory_full_cons_threshold): Revert to global.
994 (maybe_gc): Remove.
995
d7ea76b4
DA
9962012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
997
998 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
999 * lisp.h (build_unibyte_string): New function.
1000 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1001 * sysdep.c, w32fns.c, xfns.c: Use it.
1002 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1003 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1004 Adjust users accordingly.
1005 * font.h (font_open_by_name): Adjust prototype.
1006
765e61e3
DA
10072012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1008
1009 Cleanup calls to Fgarbage_collect.
1010 * lisp.h (maybe_gc): New prototype.
1011 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1012 Remove declarations.
1013 * alloc.c (maybe_gc): New function.
1014 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1015 Make them static.
1016 * bytecode.c (MAYBE_GC): Use maybe_gc.
1017 * eval.c (eval_sub, Ffuncall): Likewise.
1018 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1019 to avoid dependency from auto-save feature.
1020
52b852c7
PE
10212012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1022
1023 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1024 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1025 'for_each_per_buffer_object_at'.
1026 All uses changed. It's better to use upper-case for macros that
1027 cannot be implemented as functions, to give the reader a clue
1028 that they're special.
1029
5db81e33
SM
10302012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1031
1032 * alloc.c (Fgarbage_collect): Tweak docstring.
1033
5b835e1d
DA
10342012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1035
1036 Tweak the value returned from Fgarbage_collect again.
1037 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1038 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1039 Adjust documentation.
1040 (total_vector_bytes): Rename to total_vector_slots, adjust
1041 accounting.
1042 (total_free_vector_bytes): Rename to total_free_vector_slots,
1043 adjust accounting.
1044 (Qstring_bytes, Qvector_slots): New symbols.
1045 (syms_of_alloc): DEFSYM them.
1046
9cd47b72
DA
10472012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1048
1049 Buffer compaction primitive which may be used from Lisp.
1050 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1051 (syms_of_buffer): Register Fcompact_buffer.
1052 * alloc.c (Fgarbage_collect): Use compact_buffer.
1053 * buffer.h (compact_buffer): New prototype.
1054 (struct buffer_text): New member.
1055
d17337e5
DA
10562012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1057
1058 New macro to iterate over all buffers, miscellaneous cleanups.
1059 * lisp.h (all_buffers): Remove declaration.
1060 * buffer.h (all_buffers): Add declaration, with comment.
1061 (for_each_buffer): New macro.
1062 * alloc.c (Fgarbage_collect, mark_object): Use it.
1063 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1064 (init_buffer): Likewise.
1065 * data.c (Fset_default): Likewise.
1066 * coding.c (code_conversion_restore): Remove redundant check
1067 for dead buffer.
1068 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1069
60cfd278
AS
10702012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1071
1072 Fix bug that created negative-length intervals.
1073 * intervals.c (merge_interval_right, merge_interval_left):
1074 Do not zero out this interval if it is absorbed by its children,
1075 as this interval's total length doesn't change in that case. See
1076 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1077
d06714cb
PE
10782012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1079
83713154
PE
1080 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1081 when invoking (make-bool-vector N t) and N is a positive
1082 multiple of 8 -- the last 8 bits were mistakenly cleared.
1083
d06714cb
PE
1084 Remove some struct layout assumptions in bool vectors.
1085 * alloc.c (bool_header_size): New constant.
1086 (header_size, word_size): Move earlier, as they're now used earlier.
1087 Use 'word_size' in a few more places, where it's appropriate.
1088 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1089 padding before the data member of a bool vector.
1090 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1091 than doing the check by hand with an abort ().
1092
464d5a5e
SM
10932012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1094
5fbc0409
SM
1095 * eval.c (Fdefvar): Don't check constants since we only set the var if
1096 it's not yet defined anyway (bug#11904).
1097
464d5a5e
SM
1098 * lisp.h (last_undo_boundary): Declare new var.
1099 * keyboard.c (command_loop_1): Set it.
1100 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1101 were auto-added by the command loop (bug#11774).
1102
8dc2e44a
AS
11032012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1104
1105 * w32font.c (Qsymbol): Remove local definition.
1106 (syms_of_w32font): Don't DEFSYM it.
1107
169925ec
DA
11082012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1109
1110 Fix sweep_vectors to handle large bool vectors correctly.
1111 * alloc.c (sweep_vectors): Account total_vector_bytes for
1112 bool vectors larger than VBLOCK_BYTES_MAX.
1113
5fbfb018
CY
11142012-07-18 Chong Yidong <cyd@gnu.org>
1115
1116 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1117 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1118
3ab6e069
DA
11192012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1120
1121 Return more descriptive data from Fgarbage_collect.
1122 Suggested by Stefan Monnier in
1123 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1124 * alloc.c (bounded_number): New function.
1125 (total_buffers, total_vectors): New variable.
1126 (total_string_size): Rename to total_string_bytes, adjust users.
1127 (total_vector_size): Rename to total_vector_bytes, adjust users.
1128 (sweep_vectors): Account total_vectors and total_vector_bytes.
1129 (Fgarbage_collect): New return value. Adjust documentation.
1130 (gc_sweep): Account total_buffers.
1131 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1132 (VECTOR_SIZE): Remove.
1133 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1134 (Qinterval, Qmisc): New symbols.
1135 (syms_of_data): Initialize them.
1136 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1137 (Qcons, Qbuffer): New declarations.
1138
6d02fe5b
PE
11392012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1140
1141 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1142 Round up, not down. Improve doc.
1143
b7ffe040
DA
11442012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1145
1146 Restore old code in allocate_string_data to avoid Faset breakage.
1147 Reported by Julien Danjou <julien@danjou.info> in
1148 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1149 * alloc.c (allocate_string_data): Restore old code with minor
1150 adjustments, fix comment to explain this subtle issue.
1151
4dc7c8d5
SM
11522012-07-17 Eli Zaretskii <eliz@gnu.org>
1153
1154 Remove FILE_SYSTEM_CASE.
1155 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1156
1157 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1158 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1159 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1160 call-process-region passes it through expand-file-name.
1161
1162 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1163
11642012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1165
1166 Fix crash when creating indirect buffer (Bug#11917)
1167 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1168 Don't handle unbound variables specially if non-zero.
1169 (Fbuffer_local_variables): Pass zero.
1170 (clone_per_buffer_values): Pass non-zero.
1171
11722012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1173
1174 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1175 to make the loop interruptible.
1176
11772012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1178
1179 * gnutls.c (emacs_gnutls_handshake): Only retry if
1180 GNUTLS_E_INTERRUPTED.
1181
cce7fefc
DA
11822012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1183
1184 Cleanup and convert miscellaneous checks to eassert.
1185 * alloc.c (mark_interval): Fix comment, partially rephrase
1186 old comment from intervals.h (see below).
1187 * intervals.c (find_interval, adjust_intervals_for_insertion)
1188 (delete_interval, adjust_intervals_for_deletion)
1189 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1190 Convert to eassert.
1191 (adjust_intervals_for_insertion, make_new_interval):
1192 Remove obsolete and unused code.
1193 * intervals.h (struct interval): Remove obsolete comment.
1194 * textprotp.c (erase_properties): Remove unused code.
1195 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1196 (Fremove_list_of_text_properties): Convert to eassert.
1197
9ea10cc3
CY
11982012-07-17 Chong Yidong <cyd@gnu.org>
1199
1200 * editfns.c (Finsert_char): Doc fix.
1201
3900d5de
DA
12022012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1203
1204 Fix previous change to make Fmemory_free always accurate.
1205 * alloc.c (make_interval): Update total_free_intervals.
1206 (make_float): Likewise for total_free_floats.
1207 (free_cons, Fcons): Likewise for total_free_conses.
1208 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1209 Likewise for total_free_vector_bytes.
1210 (Fmake_symbol): Likewise for total_free_symbols.
1211 (bytes_free): Remove.
1212
7098646f
DA
12132012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1214
1215 Simple free memory accounting feature.
1216 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1217 (sweep_vectors): Accumulate size of free vectors.
1218 (Fgarbage_collect): Setup bytes_free.
1219 (Fmemory_free): New function.
1220 (syms_of_alloc): Register it.
1221
22657b40
DA
12222012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1223
1224 Cleanup overlays checking.
1225 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1226 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1227 eassert and OVERLAYP.
1228 (sort_overlays): Change to use OVERLAYP.
1229
ddfc8813
RK
12302012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1231
1232 * editfns.c (Finsert_char): Make it interactive, and make the
1233 second arg optional. Copy interactive spec and docstring from
1234 ucs-insert.
1235
7c26cf3c
PE
12362012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1237
1238 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1239 Unlike the other wrapped functions, fabs has an unspecified
1240 effect on errno.
1241
5d127af9
JD
12422012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1243
1244 * nsterm.m (keyDown): Interpret flags without left/right bits
1245 as the left key (Bug#11670).
1246
6a0dd1d7
DA
12472012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1248
1249 Remove empty and useless init functions.
1250 * lisp.h (init_character_once, init_fns, init_image)
1251 (init_filelock, init_sound): Remove prototype.
1252 * character.c (init_character_once): Remove.
1253 * filelock.c (init_filelock): Likewise.
1254 * fns.c (init_fns): Likewise.
1255 * image.c (init_image): Likewise.
1256 * sound.c (init_sound): Likewise.
1257 * emacs.c (main): Adjust accordingly.
1258
7a6136fd
DA
12592012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1260
1261 * gtkutil.h: Tiny cleanups.
1262 (use_old_gtk_file_dialog): Remove useless declaration.
1263 (xg_uses_old_file_dialog): Add suggested const attribute.
1264
ce811ad9
EZ
12652012-07-15 Eli Zaretskii <eliz@gnu.org>
1266
1267 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1268 (bidi_paragraph_init): Use it to limit search forward for a strong
1269 directional character in abnormally large paragraphs full of
1270 neutral or weak characters. (Bug#11943)
1271
c9adfeaa
SF
12722012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1273
1274 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1275 the toolbar (Bug#9451).
1276 (xg_make_tool_item): Give the widget event box a transparent
1277 background.
1278
fff62aa9
DA
12792012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1280
1281 Cleanup basic allocation variables and functions.
1282 * alloc.c (ignore_warnings, init_intervals, init_float)
1283 (init_cons, init_symbol, init_marker): Remove.
1284 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1285 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1286 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1287 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1288 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1289 (staticidx, init_alloc_once, init_strings, free_ablock):
1290 Remove redundant initialization.
1291 * fns.c (init_weak_hash_tables): Remove.
1292 * lisp.h (init_weak_hash_tables): Remove prototype.
1293
9730daca
DA
12942012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1295
1296 Use zero_vector where appropriate.
1297 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1298 accordingly.
1299 * lisp.h (zero_vector): New declaration.
1300 * font.c (null_vector): Remove.
1301 (syms_of_font): Remove initialization and staticpro.
1302 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1303 * keymap.c (Faccessible_keymaps): Likewise.
1304
2e2d2a13
LL
13052012-07-15 Leo Liu <sdl.web@gmail.com>
1306
1307 * fringe.c: Fix typo in comments.
1308
cd276f6e
LL
13092012-07-14 Leo Liu <sdl.web@gmail.com>
1310
1311 * fringe.c: Add a new bitmap exclamation-mark.
1312
5a1131d9
EZ
13132012-07-14 Eli Zaretskii <eliz@gnu.org>
1314
1315 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1316
1317 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1318 (HAVE_MENUS): Don't define, defined by editing config.in with
1319 msdos/sed2v2.inp.
1320 (GMALLOC_INHIBIT_VALLOC): Don't define.
1321 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1322
22e983b7
JB
13232012-07-14 Juanma Barranquero <lekktu@gmail.com>
1324
1325 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1326
5b3f250f
GM
13272012-07-14 Glenn Morris <rgm@gnu.org>
1328
1329 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1330 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1331 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1332
33d63ff4
GM
13332012-07-13 Glenn Morris <rgm@gnu.org>
1334
5b633342
GM
1335 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1336
33d63ff4
GM
1337 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1338 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1339
b55b9f85
JD
13402012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1341
0dc8cf50
JD
1342 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1343 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1344 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1345 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1346 where appropriate.
1347 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1348 as boolean expression.
1349 (x_set_window_size): Remove unused variable toolbar.
1350 (ns_get_color_default, ns_mod_to_lisp): Remove.
1351 (ns_mouse_position): Remove unused variables xchar and ychar.
1352 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1353 (ns_set_vertical_scroll_bar): Remove unused variable count.
1354 (ns_delete_terminal): Remove unused variable i.
1355 (ns_term_init): Remove unused variables r, g and b.
1356 (mouseDown): Remove unused variable window.
1357 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1358 (initFrameFromEmacs): Remove unused variable vbextra.
1359 (mouseEntered): Remove unused variables p and dpyinfo.
1360 (mouseExited): Remove unused variables p and r.
1361 (ns_define_frame_cursor, ns_clear_frame_area)
1362 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1363 (menuDown): Assign [sender tag] to variable and cast the variable.
1364
1365 * nsterm.h (menuDown): Add id as type to argument sender.
1366 (ns_display_info_for_name): Add Lisp_Object argument.
1367 (ns_term_init): Add Lisp_Object argument.
1368 (ns_map_event_to_object): Add void argument.
1369 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1370 prototype with arguments and only declare if __OBJC__.
1371 (nxatoms_of_nsselect): Add void argument.
1372 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1373 (ns_alloc_autorelease_pool): Add void argument.
1374 (ns_release_autorelease_pool): Add void* argument.
1375 (ns_get_defaults_value): Add const char* argument.
1376
1377 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1378 (initFromContents): Use SSDATA where appropriate.
1379 (ns_update_menubar): Add braces to ambigous if-else.
1380 (initWithTitle): Put () around assignment in if statement.
1381 (ns_menu_show): Remove unused variables window and keymap.
1382 (update_frame_tool_bar): Remove unused variable selected_p.
1383 (initWithContentRect): Remove unused variable this_cmd_name.
1384
1385 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1386 appropriate.
1387 (setXBMColor): Remove unused variable len.
1388 (setPixmapData): Put () around assignment in loop statement.
1389
1390 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1391 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1392 where appropriate.
1393 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1394 around assignment in loop statement.
1395 (nsfont_open): Remove unused variable i.
1396 (nsfont_open): Remove unused variable len.
1397 (nsfont_draw): Remove unused variable cs.
1398
1399 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1400 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1401 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1402 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1403 (Fns_font_name, Fns_perform_service)
1404 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1405 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1406 (ns_set_name): Remove unused variable view.
1407 (x_set_menu_bar_lines): Remove unused variable olines.
1408 (x_set_tool_bar_lines): Remove unused variable root_window.
1409 (Fns_list_colors): Put () around assignment in while statement.
1410 (Fns_perform_service): Remove unused variable len.
1411 (Fns_display_usable_bounds): Remove unused variable top.
1412 (syms_of_nsfns): Remove unused variable i.
1413
b55b9f85
JD
1414 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1415 memcpy (Bug#11907).
1416
ed9265fc 14172012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1418
1419 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1420 and free it with DestroyExceptionInfo (Bug#11558).
1421
ef099b57
JB
14222012-07-13 Juanma Barranquero <lekktu@gmail.com>
1423
1424 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1425 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1426 Set here, not in nt/config.nt.
1427
ea814a5d
EZ
14282012-07-13 Eli Zaretskii <eliz@gnu.org>
1429
1430 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1431 cursor overflow into the last glyph on display line when the right
1432 fringe is off. (Bug#11832)
1433
1a952767
PE
14342012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1435
1436 * xdisp.c (produce_special_glyphs): Now static.
1437 * dispextern.h (produce_special_glyphs): Remove decl.
1438
983188fd
GM
14392012-07-13 Glenn Morris <rgm@gnu.org>
1440
8d7c7eed 1441 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1442 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1443
983188fd
GM
1444 * s/usg5-4-common.h (USG, USG5):
1445 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1446 * s/sol2-6.h (SOLARIS2):
1447 * s/irix6-5.h (IRIX6_5):
1448 * s/hpux10-20.h (USG, USG5, HPUX):
1449 * s/gnu-linux.h (USG, GNU_LINUX):
1450 * s/freebsd.h (BSD_SYSTEM):
1451 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1452 * s/cygwin.h (CYGWIN):
1453 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1454 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1455
d1e68667 14562012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1457
1458 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1459
6de0e799
GM
14602012-07-13 Glenn Morris <rgm@gnu.org>
1461
739ae010
GM
1462 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1463
dbee5793
GM
1464 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1465
6de0e799
GM
1466 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1467 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1468
b82da769
GM
14692012-07-12 Glenn Morris <rgm@gnu.org>
1470
4fae5a7a 1471 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1472
1473 * process.c (init_process_emacs): Rename from init_process.
1474 The old name is also the name of a Mach system call.
1475 * lisp.h, emacs.c: Update for this name change.
1476 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1477 longer needed.
1478
5a979817
EZ
14792012-07-12 Eli Zaretskii <eliz@gnu.org>
1480
1481 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1482 memmove call that removes glyphs covered by the left truncation
1483 glyph. Improve commentary.
1484 (display_line): Fix display of continuation glyphs on GUI frames
1485 when the right fringe is turned off and variable-size fonts are
1486 used in the window. Move the code that appends a stretch glyph to
1487 produce_special_glyphs, so that it could be used for truncation
1488 and continuation glyphs alike.
1489 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1490 glyph of a suitably computed width, to align the special glyphs at
1491 the window margin. Code moved from display_line. (Bug#11832)
1492
3e91a053
GM
14932012-07-12 Glenn Morris <rgm@gnu.org>
1494
ba9e4b84
GM
1495 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1496
1497 * s/gnu-linux.h, s/hpux10-20.h:
1498 Do not unconditionally define HAVE_XRMSETDATABASE.
1499
3e91a053
GM
1500 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1501
b300b1f4
PE
15022012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1503
1504 Fix typos that broke OS X build.
1505 Reported by Randal L. Schwartz in
1506 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1507 * nsterm.m (ns_timeout): Add missing local decl.
1508 (ns_get_color): snprintf -> sprintf, to fix typo.
1509
6e777848
GM
15102012-07-12 Glenn Morris <rgm@gnu.org>
1511
3f922c37
GM
1512 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1513 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1514 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1515 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1516
0ab7b23a
GM
1517 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1518 Move PTY_OPEN to configure.
1519
6e777848
GM
1520 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1521 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1522 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1523
4a7edc24
DA
15242012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1525
1526 Use empty_unibyte_string where applicable.
1527 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1528 * lread.c (read1): Likewise.
1529 * xsettings.c (syms_of_xsettings): Likewise.
1530
308aab79
GM
15312012-07-12 Glenn Morris <rgm@gnu.org>
1532
42bd1719
GM
1533 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1534 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1535 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1536 * s/hpux10-20.h (RUN_TIME_REMAP):
1537 * s/bsd-common.h (TABDLY): Move to configure.
1538
1539 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1540
1541 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1542
ea0bbd17 1543 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1544 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1545
1546 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1547
308aab79
GM
1548 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1549 * s/template.h: Move NARROWPROTO to configure.
1550
ee1cf5cf
GM
15512012-07-11 Glenn Morris <rgm@gnu.org>
1552
30fe9bf4
GM
1553 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1554 unused since 2011-01-17 change to systty.h.
1555
ee1cf5cf
GM
1556 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1557 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1558 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1559
63e47e07
PE
15602012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1561
1562 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1563
c43fb4c3
GM
15642012-07-11 Glenn Morris <rgm@gnu.org>
1565
1566 * s/darwin.h, s/gnu-linux.h, s/template.h:
1567 Move INTERRUPT_INPUT to configure.
1568
e8df9267
DA
15692012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1570
1571 Minor adjustments to interning code.
1572 * lisp.h (intern, intern_c_string): Redefine as static inline
1573 wrappers for intern_1 and intern_c_string_1, respectively.
1574 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1575 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1576 Vobarray checking.
e8df9267
DA
1577 * font.c (font_intern_prop): Likewise. Adjust comment.
1578 * w32font.c (intern_font_name): Likewise.
1579
34348bd4
AS
15802012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1581
d96a1e0c
AS
1582 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1583
34348bd4
AS
1584 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1585 of Fcar/Fcdr if possible.
1586 * font.c (check_otf_features): Likewise.
1587 * fontset.c (Fnew_fontset): Likewise.
1588 * gnutls.c (Fgnutls_boot): Likewise.
1589 * minibuf.c (read_minibuf): Likewise.
1590 * msdos.c (IT_set_frame_parameters): Likewise.
1591 * xmenu.c (Fx_popup_dialog): Likewise.
1592 * w32menu.c (Fx_popup_dialog): Likewise.
1593
c8add24e
GM
15942012-07-11 Glenn Morris <rgm@gnu.org>
1595
4b575b3c
GM
1596 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1597 since nothing has defined it on these platforms.
1598
09f4e3b0
GM
1599 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1600 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1601
172bedef
GM
1602 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1603 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1604 Move CLASH_DETECTION to configure.
1605
249685df
GM
1606 * s/gnu.h: Remove file, which is now empty.
1607
c8add24e
GM
1608 * s/gnu.h, s/gnu-linux.h:
1609 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1610
b41253a3
JW
16112012-07-11 John Wiegley <johnw@newartisans.com>
1612
1613 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1614 function attribute, so we only use it if it exists in the
1615 compiler.
1616
d923b542
DA
16172012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1618
1619 Avoid call to strlen in fast_c_string_match_ignore_case.
1620 * search.c (fast_c_string_match_ignore_case): Change to use
1621 length argument. Adjust users accordingly.
1622 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1623
5ebbef1d
PE
16242012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1625
bb352260
PE
1626 Assume mkdir, rmdir.
1627 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1628 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1629
57054ddd
PE
1630 Assume rename.
1631 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1632
b747d3f7
PE
1633 Assume perror.
1634 * s/hpux10-20.h (HAVE_PERROR): Remove.
1635 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1636 Remove dummy definition, as this problem was obsolete long ago.
1637
5ebbef1d
PE
1638 Assume strerror.
1639 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1640
984e7f30
DA
16412012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1642
1643 Avoid calls to strlen in font processing functions.
1644 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1645 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1646 users accordingly.
d923b542
DA
1647 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1648 Adjust prototypes.
1649 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1650 Change to return ptrdiff_t.
984e7f30
DA
1651 (xfont_list_pattern, xfont_match): Use length returned by
1652 xfont_decode_coding_xlfd.
1653 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1654
20e94fdd
GM
16552012-07-11 Glenn Morris <rgm@gnu.org>
1656
9d596af3
GM
1657 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1658 Move DONT_REOPEN_PTY to configure.
1659
20e94fdd
GM
1660 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1661 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1662
e99a530f
PE
16632012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1664
22ffb973
PE
1665 Remove "#define unix" that is no longer needed (Bug#11905).
1666 * s/aix4-2.h (unix): Remove; no longer needed.
1667
e9a9ae03
PE
1668 EMACS_TIME simplification (Bug#11875).
1669 This replaces macros (which typically do not work in GDB)
1670 with functions, typedefs and enums, making the code easier to debug.
1671 The functional style also makes code easier to read and maintain.
1672 * systime.h: Include <sys/time.h> on all hosts, not just if
1673 WINDOWSNT, since 'struct timeval' is needed in general.
1674 (EMACS_TIME): Now a typedef, not a macro.
1675 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1676 not macros.
1677 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1678 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1679 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1680 (EMACS_TIME_LE): Now functions, not macros.
1681 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1682 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1683 which are not functions. All uses rewritten to use:
1684 (make_emacs_time): New function.
1685 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1686 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1687 not functions. All uses rewritten to use the following, respectively:
1688 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1689 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1690 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1691 * fileio.c (Fcopy_file):
1692 * xterm.c (XTflash): Get the current time closer to when it's used.
1693 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1694
ffacb126
PE
1695 * bytecode.c (targets): Suppress -Woverride-init warnings.
1696
e99a530f
PE
1697 Simplify by avoiding confusing use of strncpy etc.
1698 * doc.c (Fsnarf_documentation):
1699 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1700 * frame.c (Fmake_terminal_frame):
1701 * gtkutil.c (get_utf8_string):
1702 * lread.c (openp):
1703 * nsmenu.m (ns_update_menubar):
1704 * regex.c (regerror):
1705 Prefer memcpy to strncpy and strncat when either will do.
1706 * fileio.c (Fsubstitute_in_file_name):
1707 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1708 (menu_separator_name_p):
1709 * nsmenu.m (ns_update_menubar):
1710 Prefer memcmp to strncmp when either will do.
1711 * nsterm.m: Include <ftoastr.h>.
1712 (ns_get_color):
1713 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1714 Prefer snprintf to strncpy.
1715 * nsterm.m (ns_term_init):
1716 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1717 * nsterm.m (ns_term_init):
1718 Avoid the need for strncpy, by using build_string or
1719 make_unibyte_string directly. Use dtoastr, not snprintf.
1720 * process.c (Fmake_network_process): Diagnose service names that
1721 are too long, rather than silently truncating them or creating
1722 non-null-terminated names.
1723 (Fnetwork_interface_info): Likewise, for interface names.
1724 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1725 Prefer sprintf to strncat.
1726 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1727 Prefer vsnprintf to vsprintf + strncpy.
1728
c59592b3
GM
17292012-07-10 Glenn Morris <rgm@gnu.org>
1730
1731 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1732 Clarify fallback case.
1733
7d7bbefd
DA
17342012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1735
1736 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1737 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1738 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1739 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1740 where argument type is known to be a Lisp_Cons.
1741
3a4c8000
TT
17422012-07-10 Tom Tromey <tromey@redhat.com>
1743
1744 * bytecode.c (BYTE_CODE_THREADED): New macro.
1745 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1746 (enum byte_code_op): New type.
1747 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1748 (exec_byte_code): Use them. Use token threading when applicable.
1749
2a0213a6
DA
17502012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1751
1752 Optimize pure C strings initialization.
1753 * lisp.h (make_pure_string): Fix prototype.
1754 (build_pure_c_string): New function, defined as static inline. This
1755 provides a better opportunity to optimize away calls to strlen when
1756 the function is called with compile-time constant argument.
1757 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1758 argument, adjust users accordingly. Use build_pure_c_string where
1759 appropriate.
1760 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1761 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1762 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1763
cb1caeaf
DA
17642012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1765
1766 Avoid calls to strlen in miscellaneous functions.
1767 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1768 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1769 * lread.c (openp): Likewise.
1770
c293e30c
DA
17712012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1772
1773 Avoid calls to strlen in path processing functions.
1774 * fileio.c (file_name_as_directory): Add comment. Change to add
1775 srclen argument and return the length of result. Adjust users
1776 accordingly.
1777 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1778 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1779 users accordingly.
1780 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1781
9e059e3f
GM
17822012-07-10 Glenn Morris <rgm@gnu.org>
1783
d02eb359
GM
1784 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1785 Move PENDING_OUTPUT_COUNT definition to configure.
1786
882cf227
GM
1787 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1788 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1789 * s/gnu.h (DATA_START): Move definitions to configure.
1790
af6e839f
GM
1791 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1792 We include usg5-4-common.h, which defines them both.
1793
40289a12
GM
1794 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1795 O_RDONLY already includes it).
1796
9e059e3f
GM
1797 Stop ns builds setting the EMACSLOADPATH environment variable.
1798 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1799 Now it does not set EMACSLOADPATH, just returns the load-path string.
1800 * nsterm.h: Update accordingly.
1801 * lread.c [HAVE_NS]: Include nsterm.h.
1802 (init_lread) [HAVE_NS]: Use ns_load_path.
1803 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1804
7c4e8ec0
GM
18052012-07-09 Glenn Morris <rgm@gnu.org>
1806
d4f600ff
GM
1807 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1808 since the included bsd-common.h does so.
1809
cbb31951
GM
1810 Stop ns builds setting the EMACSPATH environment variable.
1811 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1812 (ns_init_paths): Do not set EMACSPATH.
1813 * nsterm.h (ns_exec_path): Add it.
1814 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1815 Use ns_exec_path.
1816
7c4e8ec0
GM
1817 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1818
26bccfae
PE
18192012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1820
a0bee46f
PE
1821 * process.c (wait_reading_process_output): 'waitchannels' was unset
1822 when read_kbd || !NILP (wait_for_cell); fix this.
1823
5994c183
PE
1824 Add GCC-style 'const' attribute to functions that can use it.
1825 * character.h (char_resolve_modifier_mask):
1826 * keyboard.h (make_ctrl_char):
1827 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1828 (init_character_once, next_almost_prime, init_fns, init_image)
1829 (flush_pending_output, init_sound):
1830 * mem-limits.h (start_of_data):
1831 * menu.h (finish_menu_items):
1832 Add ATTRIBUTE_CONST.
1833 * emacs.c (DEFINE_DUMMY_FUNCTION):
1834 Declare the dummy function with ATTRIBUTE_CONST.
1835 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1836 Add decls with ATTRIBUTE_CONST.
1837
26bccfae
PE
1838 Minor improvements to make_formatted_string.
1839 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1840 where int is good enough, as vsprintf returns an int.
1841 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1842
a8290ec3
DA
18432012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1844
1845 Use make_formatted_string to avoid double length calculation.
1846 * lisp.h (make_formatted_string): New prototype.
1847 * alloc.c (make_formatted_string): New function.
1848 * buffer.c (Fgenerate_new_buffer_name): Use it.
1849 * dbus.c (syms_of_dbusbind): Likewise.
1850 * editfns.c (Fcurrent_time_zone): Likewise.
1851 * filelock.c (get_boot_time): Likewise.
1852 * frame.c (make_terminal_frame, set_term_frame_name)
1853 (x_report_frame_params): Likewise.
1854 * image.c (gs_load): Likewise.
1855 * minibuf.c (get_minibuffer): Likewise.
1856 * msdos.c (dos_set_window_size): Likewise.
1857 * process.c (make_process): Likewise.
1858 * xdisp.c (ensure_echo_area_buffers): Likewise.
1859 * xsettings.c (apply_xft_settings): Likewise.
1860
d01ba2f1
GM
18612012-07-09 Glenn Morris <rgm@gnu.org>
1862
1863 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1864 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1865 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1866 * nsterm.h (ns_etc_directory): Add it.
1867 * callproc.c [HAVE_NS]: Include nsterm.h.
1868 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1869
f1f924b6
DA
18702012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1871
1872 Move marker debugging code under MARKER_DEBUG.
1873 * marker.c (MARKER_DEBUG): Move marker debugging code under
1874 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1875 for bootstrap with --enable-checking (~3x slowdown reported
1876 by Juanma Barranquero <lekktu@gmail.com>).
1877 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1878
ab531b66
PE
18792012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1880
1881 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1882 See <http://bugs.gnu.org/11825#29>.
1883
c4b3bc8a
EZ
18842012-07-08 Eli Zaretskii <eliz@gnu.org>
1885
1886 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1887 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1888 (display_line): Add commentary about displaying truncation glyphs
1889 on GUI frames.
1890 (produce_special_glyphs): Move here from term.c.
1891
1892 * term.c (produce_special_glyphs): Move to xdisp.c.
1893
1894 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1895 section.
c4b3bc8a 1896
b676b881
AS
18972012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1898
f17c5273
AS
1899 * xdisp.c (display_line): Avoid warning about implicit declaration
1900 of FRAME_FONT.
1901
298819b9
AS
1902 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1903
b676b881
AS
1904 * lisp.h: Remove empty conditional.
1905
6045c4fd
PE
19062012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1907
b3350bf9
PE
1908 * lread.c (load_path_check): Now static.
1909
6045c4fd
PE
1910 Fix some minor --with-ns problems found by static checking.
1911 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1912 (x_set_font) [!HAVE_X_WINDOWS]:
1913 * image.c (xpm_load_image) [HAVE_NS]:
1914 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1915 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1916 Remove unused local.
1917 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1918 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1919 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1920 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1921 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1922 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1923 Fix pointer signedness problem.
1924 * xfaces.c (FRAME_X_FONT_TABLE):
1925 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1926
929e7845
GM
19272012-07-07 Glenn Morris <rgm@gnu.org>
1928
1929 * lread.c (load_path_check): New function, split from init_lread.
1930 (init_lread): Reorganize. Motivation:
1931 If EMACSLOADPATH is set, check/warn about that rather than the
1932 defaults, which we are not going to use. Hence we can remove
1933 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1934 Don't warn if site-lisp directories are missing.
1935 If not installed, start from a blank load-path, since
1936 PATH_LOADSEARCH refers to the eventual installation directories.
1937
58dd0aa4
EZ
19382012-07-07 Eli Zaretskii <eliz@gnu.org>
1939
1940 Support truncation and continuation glyphs on GUI frames, when
1941 fringes are disabled. (Bug#11832)
1942 * xdisp.c (init_iterator): Get dimensions of truncation and
1943 continuation glyphs even if on GUI frames. Adjust
1944 it->last_visible_x on GUI frames when the left or right fringes,
1945 or both, are absent.
1946 (start_display, move_it_in_display_line_to): Handle the case of a
1947 GUI frame without a fringe to display continuation or truncation
1948 glyphs.
1949 (insert_left_trunc_glyphs): Support GUI frames: make sure
1950 truncation glyphs overwrite enough glyphs from the current line to
1951 have sufficient space in pixels.
1952 (display_line): Support truncation and continuation glyphs on GUI
1953 frames. If some spare pixels are left on the line after inserting
1954 the truncation glyphs, fill that space with a stretch glyph of a
1955 suitably computed width.
1956
1957 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1958 produce_glyphs, to support GUI sessions.
1959
31571fd7
PE
19602012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1961
5a16b9bc
PE
1962 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1963
f3047c75
PE
1964 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1965
31571fd7
PE
1966 Do not require float-time's arg to fit in time_t (Bug#11825).
1967 This works better on hosts where time_t is unsigned, and where
1968 float-time is applied to the (negative) difference between two times.
1969 * editfns.c (decode_time_components): Last arg is now double *,
1970 not int *, and means to store all the result as a double, without
1971 worrying about whether the seconds part fits in time_t.
1972 All callers changed.
1973 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1974 All callers changed.
1975 (Ffloat_time): Do not fail merely because the specified time falls
1976 outside of time_t range.
1977
4516fbef
GM
19782012-07-07 Glenn Morris <rgm@gnu.org>
1979
1980 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1981 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1982 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1983
07adc2c6
JB
19842012-07-07 Juanma Barranquero <lekktu@gmail.com>
1985
1986 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1987 Update dependencies.
1988
1989 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1990
fd573f31
PE
19912012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1992
fee5959d
PE
1993 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1994 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1995 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1996 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1997 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1998 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1999
fd573f31
PE
2000 * xfont.c (compare_font_names): Redo to omit the need for casts.
2001
ddadbc0e
AS
20022012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2003
fca8d6b6
AS
2004 * xfns.c (Fx_change_window_property): Doc fix.
2005 * w32fns.c (Fx_change_window_property): Doc fix.
2006
ddadbc0e
AS
2007 * w32fns.c (Fx_window_property): Accept the same arguments as the
2008 X Windows version. Doc fix.
2009 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2010
ed9265fc 20112012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2012 Eli Zaretskii <eliz@gnu.org>
2013
2014 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2015 Windows-specific code from nt/config.nt moved here.
2016 Obsolete settings removed.
2017
216ee680
PE
20182012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2019
2020 * process.c: Avoid unnecessary calls to gettime.
2021 (wait_reading_process_output): Don't get the time of day
2022 when gobbling data immediately and not waiting, as there's no need
2023 for it in that case. This removes a FIXME.
2024
bdd091e4
JD
20252012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2026
2027 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2028 is defined (Bug#11768).
2029
9d44f8ce
DA
20302012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2031
2032 Fix marker debugging code.
2033 * marker.c (byte_char_debug_check): Do not perform the check
2034 if buffer is not multibyte.
090bd7cb
JB
2035 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2036 Call byte_char_debug_check with correct arguments.
9d44f8ce 2037
90fc4786
DA
20382012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2039
2040 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2041 * marker.c (byte_char_debug_check, count_markers):
2042 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2043 (byte_debug_flag): Remove.
2044 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2045 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2046
7b7ae965
DA
20472012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2048
4e57b342
DA
2049 Avoid code repetition in marker-related functions.
2050 * marker.c (attach_marker): New function.
2051 (Fset_marker, set_marker_restricted, set_marker_both)
2052 (set_marker_restricted_both): Use it.
2053 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2054 Consistently rename charno to charpos.
2055 (marker_position): Add eassert.
2056 (marker_byte_position): Convert to eassert.
2057
20582012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2059
2060 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2061 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2062 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2063
657924ff
DA
20642012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2065
2066 Introduce fast path for the widely used marker operation.
2067 * alloc.c (build_marker): New function.
2068 * lisp.h (build_marker): New prototype.
2069 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2070 * composite.c (autocmp_chars): Likewise.
2071 * editfns.c (buildmark): Remove.
2072 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2073 (save_restriction_save): Use build_marker.
2074 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2075 * window.c (save_window_save): Likewise.
2076
041a49a6
DA
20772012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2078
2079 Do not use Fdelete_overlay in delete_all_overlays
2080 to avoid redundant calls to unchain_overlay.
2081 * buffer.c (drop_overlay): New function.
2082 (delete_all_overlays, Fdelete_overlay): Use it.
2083 * minibuf.c (get_minibuffer): Fix comment.
2084
7dca65a4
PE
20852012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2086
2087 Port to OpenBSD 5.1 amd64.
2088 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2089 This is needed for OpenBSD, and should be harmless on all BSD systems.
2090 Also, include <sys/sysctl.h>, as it should be available on all
2091 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2092 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2093 use p_pid member, not kp_proc.pid.
2094
8eb876e2
GM
20952012-07-06 Glenn Morris <rgm@gnu.org>
2096
2097 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2098
38182d90
PE
20992012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2100
2101 More xmalloc and related cleanup.
2102 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2103 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2104 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2105 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2106 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2107 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2108 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2109 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2110 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2111 * xterm.c:
2112 Omit needless casts involving void * pointers and allocation.
2113 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2114 as the former is more robust if P's type is changed.
2115 Prefer xzalloc to xmalloc + memset 0.
2116 Simplify malloc-or-realloc to realloc.
2117 Don't worry about xmalloc returning a null pointer.
2118 Prefer xstrdup to xmalloc + strcpy.
2119 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2120 growing it.
2121 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2122 alloca of a constant.
2123
6dd5a677
EZ
21242012-07-05 Eli Zaretskii <eliz@gnu.org>
2125
2126 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2127 hscroll is larger than the line width. Fixes long and futile
2128 looping inside extend_face_to_end_of_line (on a TTY) producing
2129 glyphs that are not needed and thrown away.
2130
6b312f0f
DA
21312012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2132
2133 * marker.c (set_marker_restricted_both): Simplify by using
2134 clip_to_bounds.
2135
f520ef9b
PE
21362012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2137
2138 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2139
383b7c95
JD
21402012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2141
2142 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2143 not defined (Bug#11768).
2144 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2145 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2146 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2147 followed by gtk_box_set_homogeneous (Bug#11768).
2148 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2149 (update_theme_scrollbar_width, xg_create_scroll_bar):
2150 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2151 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2152 (is_box_type): New function (Bug#11768).
2153 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2154 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2155 with default display (Bug#11768).
2156
d6e7bf45
EZ
21572012-07-05 Eli Zaretskii <eliz@gnu.org>
2158
2159 * xdisp.c (window_hscroll_limited): New function.
2160 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2161 coordinates when window's hscroll is set to insanely large
2162 values. (Bug#11857)
2163
431391ec
JB
21642012-07-05 Juanma Barranquero <lekktu@gmail.com>
2165
2166 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2167 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2168
23f86fce
DA
21692012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2170
2171 Cleanup xmalloc.
2172 * lisp.h (xzalloc): New prototype. Omit needless casts.
2173 * alloc.c (xzalloc): New function. Omit needless casts.
2174 * charset.c: Omit needless casts. Convert all calls to
2175 xmalloc with following memset to xzalloc.
2176 * dispnew.c: Likewise.
2177 * fringe.c: Likewise.
2178 * image.c: Likewise.
2179 * sound.c: Likewise.
2180 * term.c: Likewise.
2181 * w32fns.c: Likewise.
2182 * w32font.c: Likewise.
2183 * w32term.c: Likewise.
2184 * xfaces.c: Likewise.
2185 * xfns.c: Likewise.
2186 * xterm.c: Likewise.
2187 * atimer.c: Omit needless casts.
2188 * buffer.c: Likewise.
2189 * callproc.c: Likewise.
2190 * ccl.c: Likewise.
2191 * coding.c: Likewise.
2192 * composite.c: Likewise.
2193 * doc.c: Likewise.
2194 * doprnt.c: Likewise.
2195 * editfns.c: Likewise.
2196 * emacs.c: Likewise.
2197 * eval.c: Likewise.
2198 * filelock.c: Likewise.
2199 * fns.c: Likewise.
2200 * gtkutil.c: Likewise.
2201 * keyboard.c: Likewise.
2202 * lisp.h: Likewise.
2203 * lread.c: Likewise.
2204 * minibuf.c: Likewise.
2205 * msdos.c: Likewise.
2206 * print.c: Likewise.
2207 * process.c: Likewise.
2208 * region-cache.c: Likewise.
2209 * search.c: Likewise.
2210 * sysdep.c: Likewise.
2211 * termcap.c: Likewise.
2212 * terminal.c: Likewise.
2213 * tparam.c: Likewise.
2214 * w16select.c: Likewise.
2215 * w32.c: Likewise.
2216 * w32reg.c: Likewise.
2217 * w32select.c: Likewise.
2218 * w32uniscribe.c: Likewise.
2219 * widget.c: Likewise.
2220 * xdisp.c: Likewise.
2221 * xmenu.c: Likewise.
2222 * xrdb.c: Likewise.
2223 * xselect.c: Likewise.
2224
0497dc44
PE
22252012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2226
2227 * fileio.c (time_error_value): Check the right error number.
2228 Problem reported by Troels Nielsen in
2229 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2230
356e7178
PE
22312012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2232
4e71fd89
PE
2233 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2234 This should be fixed in a better way; see Eli Zaretskii in
2235 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2236 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2237
f0941253
PE
2238 * fileio.c (time_error_value): Rename from special_mtime.
2239 The old name's problems were noted by Eli Zaretskii in
2240 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2241
065c9eb4
PE
2242 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2243 This variable's comment says Emacs needs at least one GDB-visible
2244 symbol of type enum pvec_type, to work around GDB problems.
2245 The symbol's value doesn't matter.
2246
356e7178
PE
2247 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2248 that causes compilation to fail on pre-C99 compilers.
2249
ed9265fc 22502012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2251
2252 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2253 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2254
3884d954
DA
22552012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2256
d209e2fb 2257 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2258 headers for buffer_defaults and buffer_local_symbols.
2259 Reported by Juanma Barranquero <lekktu@gmail.com>.
2260
ee28be33
SM
22612012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2262
2263 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2264 * lisp.h (enum pvec_type): Use fewer bits.
2265 (PSEUDOVECTOR_SIZE_BITS): New constant.
2266 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2267 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2268 change in pvec_type.
2269 (PSEUDOVECTOR_TYPEP): New macro.
2270 (TYPED_PSEUDOVECTORP): Use it.
2271 * fns.c (internal_equal): Adapt code to extract pvectype.
2272 * emacs.c (gdb_pvec_type): Update type.
2273 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2274 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2275 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2276 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2277 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2278 abusing vector->header.next.nbytes.
2279 (live_vector_p): Use PVEC_TYPE.
2280 (mark_object): Adapt code to extract pvectype. Use switch.
2281
c7f2cd7f
PE
22822012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2283
2284 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2285 Tighten new eassert a bit.
2286
8ce70ed2
DA
22872012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2288
2289 Fix compilation with --enable-gcc-warnings and -O1
2290 optimization level.
2291 * doprnt.c (doprnt): Change type of tem to int, initialize
2292 to avoid compiler warning. Add eassert.
2293 * search.c (simple_search): Initialize match_byte to avoid
2294 compiler warning. Add eassert.
2295
dea7f1e5
PE
22962012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2297
24a212eb
PE
2298 Avoid weird behavior with large horizontal scrolls.
2299 Without this change, for example, large hscroll values would
2300 mess up Emacs's display on Fedora 15 x86, presumably due to
2301 overflows in int calculations in the display code.
2302 Also, if buffers had long lines, Emacs would freeze.
2303 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2304 (set_window_hscroll): New function, containing the old guts of
2305 Fset_window_hscroll. Return the clipped value.
2306 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2307 This avoids the need to check against PTRDIFF_MAX.
2308
dea7f1e5
PE
2309 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2310
76046526
DA
23112012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2312
2313 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2314
39adff0d
PE
23152012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2316
63807d47
PE
2317 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2318 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2319 since GCC 4.4.6 issues a bogus warning for them.
2320
39adff0d
PE
2321 Fix bugs in file timestamp newness comparisons.
2322 * fileio.c (Ffile_newer_than_file_p):
2323 * lread.c (Fload): Use full timestamp resolution of files,
2324 not just the 1-second resolution, so that files that are only
2325 slightly newer still count as newer.
2326 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2327 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2328
dbeed9a6
PE
23292012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 * fileio.c: Improve handling of file time marker. (Bug#11852)
2332 (special_mtime): New function.
2333 (Finsert_file_contents, Fverify_visited_file_modtime):
2334 Use it to set special mtime values consistently.
2335
636334d6
AS
23362012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2337
2338 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2339 marker for non-existing file. (Bug#11852)
2340
e2017fe2
GM
23412012-07-03 Glenn Morris <rgm@gnu.org>
2342
2343 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2344 and did not make it into globals.h).
2345
404dbd37
TT
23462012-07-03 Tom Tromey <tromey@redhat.com>
2347
2348 * window.c (Fset_window_margins, Fset_window_fringes)
2349 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2350 * textprop.c (Fprevious_property_change): No longer static.
2351 * syntax.c (Fsyntax_table_p): No longer static.
2352 * process.c (Fget_process, Fprocess_datagram_address): No longer
2353 static.
2354 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2355 * keyboard.c (Fcommand_execute): No longer static.
2356 Remove EXFUN.
2357 * insdel.c (Fcombine_after_change_execute): No longer static.
2358 * image.c (Finit_image_library): No longer static.
2359 * fileio.c (Fmake_symbolic_link): No longer static.
2360 * eval.c (Ffetch_bytecode): No longer static.
2361 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2362 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2363 No longer static.
404dbd37
TT
2364 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2365 static.
2366 * dired.c (Ffile_attributes): No longer static.
2367 * composite.c (Fcomposition_get_gstring): No longer static.
2368 * callproc.c (Fgetenv_internal): No longer static.
2369
2370 * ccl.h: Remove EXFUNs.
2371 * buffer.h: Remove EXFUNs.
2372 * dispextern.h: Remove EXFUNs.
2373 * intervals.h: Remove EXFUNs.
2374 * fontset.h: Remove EXFUN.
2375 * font.h: Remove EXFUNs.
2376 * dosfns.c (system_process_attributes): Remove EXFUN.
2377 * keymap.h: Remove EXFUNs.
2378 * lisp.h: Remove EXFUNs.
2379 * w32term.h: Remove EXFUNs.
2380 * window.h: Remove EXFUNs.
2381 * xsettings.h: Remove EXFUN.
2382 * xterm.h: Remove EXFUN.
2383
8e4fd1e1
GM
23842012-07-03 Glenn Morris <rgm@gnu.org>
2385
2386 * lisp.h (Frandom): Make it visible to C.
2387 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2388 buffer for invisible buffers. (Bug#1229)
2389
ca95b3eb
DA
23902012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2391
2392 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2393 values which aren't power of 2.
2394 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2395 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2396 accordingly.
2397
7555c33f
SM
23982012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2399
2400 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2401
2402 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2403
d12e8f5a
DA
24042012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2405
2406 * alloc.c (allocate_vector_block): Remove redundant
2407 calls to mallopt if DOUG_LEA_MALLOC is defined.
2408 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2409 avoid calls to mallopt if zero_vector is returned.
2410
296094c3
DA
24112012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2412
2413 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2414 is enabled, avoid dereferencing NULL current_sblock if
2415 running undumped.
2416
36429c89
DA
24172012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2418
2419 Cleanup basic buffer management.
2420 * buffer.h (struct buffer): Change layout to use generic vector
2421 marking code. Fix some comments. Change type of 'clip_changed'
2422 to bitfield. Remove unused #ifndef old.
2423 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2424 (GET_OVERLAYS_AT): Fix indentation.
2425 (for_each_per_buffer_object_at): New macro.
2426 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2427 (Fbuffer_local_variables): Use it.
2428 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2429 * alloc.c (allocate_buffer): Adjust to match new layout of
2430 struct buffer. Fix comment.
2431 (mark_overlay): New function.
2432 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2433 Lisp area of struct buffer.
2434 (mark_object): Use it. Adjust marking of misc objects
2435 and related comments.
2436
3b3e4cac
PE
24372012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2440 wrapper that is not needed because the wrapped code is a no-op (zero
2441 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2442 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2443
cf5c0175
DA
24442012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2445
2446 * alloc.c (mark_buffer): Simplify. Remove prototype.
2447 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2448 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2449 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2450 redundant calls to mark_vectorlike for bool vectors.
2451
ca26824c
GM
24522012-06-30 Glenn Morris <rgm@gnu.org>
2453
2e4c5312
GM
2454 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2455
ca26824c
GM
2456 * epaths.in (PATH_SITELOADSEARCH): New.
2457 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2458 This is rather than relying on --enable-locallisppath elements
2459 having "site-lisp" in their names. (Bug#10208#25, 11658)
2460
0d23c240
EZ
24612012-06-30 Eli Zaretskii <eliz@gnu.org>
2462
c9240d7a
EZ
2463 * w32proc.c (sys_select): Accept and ignore one more argument.
2464
2465 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2466
0d23c240 2467 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2468 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2469
2470 * sysdep.c: Don't include dos.h and dosfns.h.
2471
2472 * process.c (sys_select):
2473 * msdos.c (sys_select): Accept one more argument and ignore it.
2474
2475 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2476 adapt data types and code to that.
2477
2478 * dosfns.c:
2479 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2480 which clashes with the gnulib function of the same name.
2481
af5a5a98
AS
24822012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2483
c5e4379c
AS
2484 * font.c (font_style_to_value, font_style_symbolic)
2485 (font_prop_validate_style): Add type checks for values in
2486 font_style_table.
2487
af5a5a98
AS
2488 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2489 argument.
2490 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2491 uses.
2492
8d38f461
EZ
24932012-06-29 Eli Zaretskii <eliz@gnu.org>
2494
2e5a6631
EZ
2495 * xdisp.c (try_window_id): Undo last change.
2496
8d38f461
EZ
2497 * w32.c (getwd): Adjust commentary about startup_dir.
2498 (init_environment): Always call sys_access, even in non-MSVC
2499 builds. Don't chdir to the directory of the Emacs executable.
2500 This undoes code from 1997 which was justified by the need to
2501 "avoid conflicts when removing and renaming directories". But its
2502 downside was that every relative file name was being interpreted
2503 relative to the directory of the Emacs executable, which can never
2504 be TRT. In particular, it broke sys_access when called with
2505 relative file names.
2506 (sys_access): Map GetLastError to errno.
2507
2af3565e
DA
25082012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2509
2510 * window.h (struct window): Change type of 'fringes_outside_margins'
2511 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2512 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2513 Adjust comment.
2514 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2515 to ptrdiff_t.
2516
c8d3a25c 25172012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2518
c8d3a25c
GM
2519 * gnutls.c (emacs_gnutls_handshake):
2520 Add QUIT to make the loop interruptible.
57570cd3 2521
c8d3a25c 25222012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2523
c8d3a25c
GM
2524 * charset.c (init_charset): Make lack of etc/charsets fatal.
2525
3e984ee8
DA
25262012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2527
2528 * editfns.c (region_limit): Fix type mismatch.
2529
ef884f23
DA
25302012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2531
2532 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2533 undefined. Convert from xassert to eassert.
2534 * nsmenu.m: Convert from xassert to eassert.
2535 * nsterm.m: Likewise.
2536
7d7e0027
SM
25372012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2538
2539 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2540
aa754e6a
PE
25412012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2542
2543 Avoid integer overflow on scroll-left and scroll-right.
2544 * window.c (HSCROLL_MAX): New macro.
2545 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2546 overflow when requested scroll falls outside ptrdiff_t range.
2547
80b00b08
DA
25482012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2549
2550 * window.h (struct window): Change type of 'hscroll',
2551 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2552 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2553 Adjust users accordingly.
2554 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2555 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2556 from EMACS_INT to ptrdiff_t.
2557 (make_window): Omit redundant initialization.
2558
62b2bcf6
JB
25592012-06-28 Juanma Barranquero <lekktu@gmail.com>
2560
2561 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2562
45942c7d
DA
25632012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2564
2565 * window.h (struct window): Change type of 'use_time' and
2566 'sequence_number' from Lisp_Object to int.
2567 * frame.c (make_frame): Adjust users accordingly.
2568 * print.c (print_object): Likewise.
2569 * window.c (select_window, Fwindow_use_time, make_parent_window)
2570 (make_window): Likewise.
2571
e509cfa6
DA
25722012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2573
2574 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2575 enabled with --enable-checking=[all,glyphs] configure option.
2576 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2577 adjust comments accordingly.
2578 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2579 undefined, adjust comments accordingly.
2580 * image.c: Likewise.
2581 * scroll.c: Likewise.
2582 * w32fns.c: Likewise.
2583 * w32term.c: Likewise.
2584 * xdisp.c: Likewise.
2585 * xfaces.c: Likewise.
2586 * xfns.c: Likewise.
2587 * xterm.c: Likewise.
2588
a54e2c05
DA
25892012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2590
2591 Generalize run-time debugging checks.
2592 * dispextern.h (XASSERTS): Remove.
2593 * fontset.c (xassert): Remove.
2594 Convert from xassert to eassert.
2595 * alloc.c: Convert from xassert to eassert.
2596 * bidi.c: Likewise.
2597 * dispnew.c: Likewise.
2598 * fns.c: Likewise.
2599 * fringe.c: Likewise.
2600 * ftfont.c: Likewise.
2601 * gtkutil.c: Likewise.
2602 * image.c: Likewise.
2603 * keyboard.c: Likewise.
2604 * menu.c: Likewise.
2605 * process.c: Likewise.
2606 * scroll.c: Likewise.
2607 * sound.c: Likewise.
2608 * term.c: Likewise.
2609 * w32console.c: Likewise.
2610 * w32fns.c: Likewise.
2611 * w32term.c: Likewise.
2612 * window.c: Likewise.
2613 * xdisp.c: Likewise.
2614 * xfaces.c: Likewise.
2615 * xfns.c: Likewise.
2616 * xselect.c: Likewise.
2617 * xterm.c: Likewise.
2618
1ec4b7b2
SM
26192012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2620
2621 * fns.c (maybe_resize_hash_table): Output message when growing the
2622 purify-hashtable.
2623
2014308a
DA
26242012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2625
2626 * alloc.c (allocate_string_data): Remove dead code.
2627 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2628 avoid GCC warning about unused macro.
2629
246155eb
DA
26302012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2631
2632 * alloc.c (allocate_string): Omit intervals initialization.
2633 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2634 as in make_pure_string and make_pure_c_string.
2635
43184b7b
DA
26362012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2637
d209e2fb 2638 * alloc.c (allocate_string): Fix last change.
43184b7b 2639
3fe6dd74
DA
26402012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2641
d209e2fb 2642 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2643 to memset, add explicit initialization where appropriate.
2644
1ba6038a
GM
26452012-06-27 Glenn Morris <rgm@gnu.org>
2646
2647 * lisp.mk (lisp): Remove paths.elc.
2648
c89926a5
CY
26492012-06-27 Chong Yidong <cyd@gnu.org>
2650
2651 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2652
ed6b3510
JW
26532012-06-26 John Wiegley <johnw@newartisans.com>
2654
1ec4b7b2 2655 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2656 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2657
ed6b3510
JW
2658 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2659 when building with Clang.
2660
8edd4a2b
SM
26612012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2662
2663 * eval.c (Fapply): Allow calling it with a single argument.
2664
f6f62d1b
EZ
26652012-06-26 Eli Zaretskii <eliz@gnu.org>
2666
2667 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2668 _stricmp and _strnicmp.
2669 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2670
62efea5e
DA
26712012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2672
2673 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2674 allocated window.
2675 (allocate_process): Likewise for new process.
8edd4a2b 2676 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2677 (allocate_frame): Likewise.
2678 * frame.c (make_frame): Omit redundant initialization.
2679 * window.c (make_parent_window): Use memset.
2680 (make_window): Omit redundant initialization.
2681 * process.c (make_process): Omit redundant initialization.
2682 * terminal.c (create_terminal): Likewise.
2683
42997f4d
DA
26842012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2685
2686 * term.c (delete_tty): Remove redundant call to memset.
2687
1130ecfc
DA
26882012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2689
2690 * alloc.c: Remove build_string.
2691 * lisp.h: Define build_string as static inline. This provides
2692 a better opportunity to optimize away calls to strlen when the
2693 function is called with compile-time constant argument.
2694 * image.c (imagemagick_error): Convert to build_string.
2695 * w32proc.c (sys_spawnve): Likewise.
2696 * xterm.c (x_term_init): Likewise.
2697
cf38a720
PE
26982012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2699
99027bdd
PE
2700 Use sprintf return value instead of invoking strlen on result.
2701 In the old days this wasn't portable, since some sprintf
2702 implementations returned char *. But they died out years ago and
2703 Emacs already assumes sprintf returns int.
2704 Similarly for float_to_string.
2705 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2706 * ccl.c (ccl_driver):
2707 * character.c (string_escape_byte8):
2708 * data.c (Fnumber_to_string):
2709 * doprnt.c (doprnt):
2710 * print.c (print_object):
2711 * xdisp.c (message_dolog):
2712 * xfns.c (syms_of_xfns):
2713 Use sprintf or float_to_string result to avoid need to call strlen.
2714 * data.c (Fnumber_to_string):
2715 Use make_unibyte_string, since the string must be ASCII.
2716 * lisp.h, print.c (float_to_string): Now returns int length.
2717 * term.c (produce_glyphless_glyph):
2718 Use sprintf result rather than recomputing it.
2719
cf38a720
PE
2720 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2721 * Makefile.in (ALL_CFLAGS):
2722 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2723 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2724
3511c784
DA
27252012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2726
0a08eb21 2727 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2728 strcasecmp if available.
2729 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2730
fb7da12e
AS
27312012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2732
2733 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2734 Avoid comma operator.
2735 * menu.c (push_submenu_start, push_submenu_end)
2736 (push_left_right_boundary, push_menu_pane): Likewise.
2737 * msdos.c (dos_rawgetc): Likewise.
2738
afa2ffd8
DA
27392012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2740
2741 * xfns.c (xic_create_fontsetname): Remove redundant calls
2742 to memset.
2743
b3b4476b
PE
27442012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2745
4495ff38
PE
2746 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2747 sprintf already null-terminates its output.
2748
b3b4476b
PE
2749 * xfns.c (x_window): Remove redundant cast.
2750
b00876c9
DA
27512012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2752
2753 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2754 `const char *' to `char *' to avoid compiler warning.
2755
d188e26b
PE
27562012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2757
885d1d74
PE
2758 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2759 instead of truncating it to 63 (admittedly a generous limit).
2760
d188e26b
PE
2761 * process.c: Fix spelling and caps in comments.
2762
e2f560b1
DN
27632012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2764
e86db54b 2765 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2766 * sysdep.c (setpgrp): Remove definition, not used in this file.
2767
7583a3a1
JB
27682012-06-24 Juanma Barranquero <lekktu@gmail.com>
2769
2770 * makefile.w32-in: Update dependencies.
2771
696056c2
EZ
27722012-06-24 Eli Zaretskii <eliz@gnu.org>
2773
2774 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2775 (SYSTIME_H): Add nt/inc/sys/time.h.
2776
2777 * systime.h [WINDOWSNT]: Include sys/time.h.
2778
2779 * s/ms-w32.h (struct timespec): Definition moved from
2780 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2781
845ca893
PE
27822012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2783
2784 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2785 * buffer.h (buffer_slot_type_mismatch):
2786 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2787 * eval.c (unwind_to_catch):
2788 * image.c (my_png_error, my_error_exit):
2789 * keyboard.c (quit_throw_to_read_char, user_error)
2790 (Fexit_recursive_edit, Fabort_recursive_edit):
2791 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2792 (wrong_type_argument, buffer_overflow, __executable_start)
2793 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2794 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2795 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2796 (fatal):
2797 (child_setup) [!DOS_NT]:
2798 * lread.c (end_of_file_error, invalid_syntax):
2799 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2800 * puresize.h (pure_write_error):
2801 * search.c (matcher_overflow):
2802 * sound.c (sound_perror, alsa_sound_perror):
2803 * sysdep.c, syssignal.h (croak):
2804 * term.c (maybe_fatal, vfatal):
2805 * textprop.c (text_read_only):
2806 * undo.c (user_error):
2807 * unexmacosx.c (unexec_error):
2808 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2809 Use _Noreturn rather than NO_RETURN.
2810 No need for separate decl merely because of _Noreturn.
2811 * sound.c (sound_warning, parse_sound):
2812 Remove unnecessary forward decls.
2813
f1dd8073
PE
28142012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2815
2816 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2817 * lisp.h (WAIT_READING_MAX): New macro.
2818 * dispnew.c (Fsleep_for, sit_for):
2819 * keyboard.c (kbd_buffer_get_event):
2820 * process.c (Faccept_process_output):
2821 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2822 This improves on the previous patch, which introduced a bug
2823 when time_t is unsigned and as wide as intmax_t.
2824 See <http://bugs.gnu.org/9000#51>.
2825
b82c1755
EZ
28262012-06-23 Eli Zaretskii <eliz@gnu.org>
2827
2828 * dispnew.c (sit_for, Fsleep_for):
2829 * keyboard.c (kbd_buffer_get_event):
2830 * process.c (Faccept_process_output): Avoid compiler warnings when
2831 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2832
ca300656
JB
28332012-06-23 Juanma Barranquero <lekktu@gmail.com>
2834
049ec95b
JB
2835 * makefile.w32-in: Update dependencies.
2836
ca300656
JB
2837 * w32.c (ltime): Add return type and declare static.
2838 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2839
db7b8d06
PE
28402012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2841
2842 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2843 Privately reported by Herbert J. Skuhra.
2844 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2845 All uses changed.
2846 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2847 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2848
0bd8297f
EZ
28492012-06-23 Eli Zaretskii <eliz@gnu.org>
2850
96512555
EZ
2851 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2852 last argument of make_unibyte_string.
2853
0bd8297f
EZ
2854 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2855 language ID in the event parameters.
2856
2857 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2858 event.code, not the obscure "character set ID".
2859
63def6b6
CY
28602012-06-23 Chong Yidong <cyd@gnu.org>
2861
2862 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2863
e8a02204
EZ
28642012-06-23 Eli Zaretskii <eliz@gnu.org>
2865
388cdec0
EZ
2866 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2867 * w32.c (fdutimens): New function.
2868
2869 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2870
2871 * s/ms-w32.h (pselect): Redirect to sys_select.
2872
2873 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2874
e8a02204
EZ
2875 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2876 in the logic of incrementing and decrementing the value of
2877 use_relocatable_buffers.
2878
d054f3fb
PE
28792012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2880
2881 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2882 Privately reported by Herbert J. Skuhra.
2883 [__FreeBSD__]: Remove "*/" typo after "#include".
2884 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2885 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2886 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2887 Don't assume EMACS_TIME and struct timeval are the same type.
2888
d35af63c
PE
28892012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2890
2891 Support higher-resolution time stamps (Bug#9000).
2892 The time stamps are only nanosecond-resolution at the C level,
2893 since that's the best that any real-world system supports now.
2894 But they are picosecond-resolution at the Lisp level, as that's
2895 easy, and leaves room for future OS improvements.
2896
2897 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2898 (LIBES): Use it.
2899
2900 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2901 Don't get current time unless it's needed.
2902
2903 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2904 now provides it if it's absent.
2905 (start_atimer): Port to higher-res time stamps.
2906 Check for time stamp overflow. Don't get current time more
2907 often than is needed.
2908
2909 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2910 Include systime.h, not time.h.
2911 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2912
2913 * dired.c: Include stat-time.h.
2914 (Ffile-attributes): File times now have higher resolution.
2915
2916 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2917 (struct image): Timestamp now has higher resolution.
2918
2919 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2920 has at least microseconds now. All uses removed.
2921 (update_frame, update_single_window, update_window, update_frame_1)
2922 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2923
2924 * editfns.c (time_overflow): Now extern.
2925 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2926 (float-time, Fformat_time_string, Fcurrent_time_string)
2927 (Fcurrent_time_zone): Accept and generate higher-resolution
2928 time stamps.
2929 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2930 (decode_time_components, lisp_seconds_argument): New functions.
2931 (make_time): Now static.
2932 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2933 Report an error if the time is invalid, rather than having the caller
2934 do that.
2935
2936 * fileio.c: Include <stat-time.h>
2937 (Fcopy_file): Copy higher-resolution time stamps.
2938 Prefer to set the time stamp via a file descriptor if that works.
2939 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2940 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2941 (Fvisited_file_modtime, Fset_visited_file_modtime):
2942 Support higher-resolution time stamps.
2943
2944 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2945
2946 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2947
2948 * image.c (prepare_image_for_display, clear_image_cache)
2949 (lookup_image): Port to higer-resolution time stamps.
2950
2951 * keyboard.c (start_polling, bind_polling_period):
2952 Check for time stamp overflow.
2953 (read_char, kbd_buffer_get_event, timer_start_idle)
2954 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2955 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2956 Port to higher-resolution time stamps. Do not assume time_t is signed.
2957 (decode_timer): New function. Timers are now vectors of length 9,
2958 not 8, to accommodate the picosecond component.
2959 (timer_check_2): Use it.
2960
2961 * nsterm.m (select_timeout, timeval_subtract): Remove.
2962 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2963 as they're a bit more accurate and handle overflow better.
2964 (ns_select): Change prototype to be compatible with pselect.
2965 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2966 * nsterm.h (ns_select): Adjust prototype.
2967
2968 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2969 us-resolution time stamps.
2970 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2971
2972 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2973
2974 * lisp.h (time_overflow): New decl.
2975 (wait_reading_process_output): First arg is now intmax_t, not int,
2976 to accommodate larger waits.
2977
2978 * process.h (struct Lisp_Process.read_output_delay):
2979 Now counts nanoseconds, not microseconds.
2980 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2981 EMACS_HAS_USECS.
2982 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2983 (wait_reading_process_output):
2984 Port to ns-resolution time stamps.
2985 (Faccept_process_output, wait_reading_process_output):
2986 Check for time stamp overflow. Do not assume time_t is signed.
2987 (select_wrapper): Remove; we now use pselect.
2988 (Fprocess_attributes): Now generates ns-resolution time stamps.
2989
2990 * sysdep.c: Include utimens.h. Don't include utime.h
2991 or worry about struct utimbuf; gnulib does that for us now.
2992 (gettimeofday): Remove; gnulib provides a substitute.
2993 (make_timeval): New function.
2994 (set_file_times): Now sets ns-resolution time stamps.
2995 New arg FD; all uses changed.
2996 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2997 (system_process_attributes):
2998 Now returns ns-resolution time stamp. All uses changed.
2999 Check for time stamp overflow.
3000
3001 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3002 provides a substitute now.
3003
3004 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3005 since it guarantees struct timespec.
3006 (EMACS_TIME): Now struct timespec, so that we can support
3007 ns-resolution time stamps.
3008 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3009 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3010 (EMACS_USECS): Remove.
3011 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3012 so multiply the arg by 1000 before storing it.
3013 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3014 New macros.
3015 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3016 Port to ns-resolution time stamps.
3017 (EMACS_TIME_NEG_P): Remove; replaced by....
3018 (EMACS_TIME_SIGN): New macro.
3019 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3020 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3021 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3022 (make_timeval, make_lisp_time, decode_time_components): New decls.
3023 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3024 that it mishandled time_t overflow. You can't compare by subtracting!
3025 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3026 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3027
3028 * term.c: Include <sys/time.h>.
3029 (timeval_to_Time): New function, for proper overflow wraparound.
3030 (term_mouse_position, term_mouse_click): Use it.
3031
3032 * undo.c (record_first_change): Support higher-resolution time stamps
3033 in the undo buffer.
3034 (Fprimitive_undo): Use them when restoring time stamps.
3035
3036 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3037 (w32_get_internal_run_time):
3038 Port to higher-resolution Emacs time stamps.
3039 (ltime): Now accepts single 64-bit integer, as that's more convenient
3040 for callers.
3041
3042 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3043
3044 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3045 for compatibility with pselect. Support ns-resolution time stamps.
3046
3047 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3048
3049 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3050 Check for time stamp overflow, and support ns-resolution time stamps.
3051
3052 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3053 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3054 (timeval_subtract): Remove; no longer needed.
3055 (XTflash, XTring_bell, x_wait_for_event):
3056 Port to ns-resolution time stamps. Don't assume time_t is signed.
3057
b6a92dfe
CY
30582012-06-22 Chong Yidong <cyd@gnu.org>
3059
3060 * xdisp.c (x_consider_frame_title): Revert last change.
3061
d251c37c
EZ
30622012-06-22 Eli Zaretskii <eliz@gnu.org>
3063
3064 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3065 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3066 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3067 staticidx goes up to 1597 out of 1600 = 0x640.)
3068
f10deafb
PE
30692012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3070
3071 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3072 Otherwise, the umask might be mistakenly 0 while handling input signals.
3073
ec6de1e2
SM
30742012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3075
3076 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3077
28be1ada
DA
30782012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3079
3080 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3081 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3082 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3083 access to `contents' member of Lisp_Vector objects with AREF and ASET
3084 where appropriate.
3085
c6bf3022
CY
30862012-06-19 Chong Yidong <cyd@gnu.org>
3087
3088 * frame.c (delete_frame): When selecting a frame on a different
3089 text terminal, do not alter the terminal's top-frame.
3090
3091 * xdisp.c (format_mode_line_unwind_data): Record the target
3092 frame's selected window and its terminal's top-frame.
3093 (unwind_format_mode_line): Restore them.
3094 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3095 Callers changed.
3096 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3097 since tty frames can be explicitly named.
3098 (prepare_menu_bars): Likewise.
3099
3100 * term.c (Ftty_top_frame): New function.
3101
defd4196
PE
31022012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3103
3104 Port byte-code-meter to modern targets.
3105 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3106 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3107 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3108 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3109 (METER_1, METER_2): Simplify.
3110
1053a871
SM
31112012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3112
3113 * data.c (Fdefalias): Return `symbol' (bug#11686).
3114
b7e8d081
MR
31152012-06-18 Martin Rudalics <rudalics@gmx.at>
3116
3117 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3118 gets killed during executing of this function (Bug#11665).
3119 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3120 (Vkill_buffer_query_functions): In doc-string say that functions
3121 run by this hook should not change the current buffer.
3122
7ea2b339
PE
31232012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3124
3125 Fix recently-introduced process.c problems found by static checking.
3126 * process.c (write_queue_push, write_queue_pop, send_process):
3127 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3128 (write_queue_pop): Fix pointer signedness problem.
3129 (send_process): Remove unused local.
3130
96a313a1
CY
31312012-06-17 Chong Yidong <cyd@gnu.org>
3132
3133 * xdisp.c (redisplay_internal): No need to redisplay terminal
3134 frames that are not on top.
3135
20ca2e94
TN
31362012-06-17 Troels Nielsen <bn.troels@gmail.com>
3137
3138 * process.c (make_process): Initialize write_queue.
3139 (write_queue_push, write_queue_pop): New functions.
3140 (send_process): Use them to maintain correct ordering of process
3141 writes (Bug#10815).
3142
9a900ca9
PE
31432012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3144
310fbfa8
PE
3145 * lisp.h (eassert): Assume C89 or later.
3146 This removes the need for CHECK.
3147 (CHECK): Remove. Its comments about always evaluating its
3148 argument were confusing, as 'eassert' typically does not evaluate
3149 its argument.
3150
27bb1ca4
PE
3151 * coding.c (produce_chars): Use ptrdiff_t, not int.
3152
9a900ca9
PE
3153 * xterm.c (x_draw_underwave): Check for integer overflow.
3154 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3155
41b7f8bc 31562012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3157
3158 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3159 referenced (Bug#11583).
3160
9b0e3eba
AA
31612012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3162
3163 Implement wave-style variant of underlining.
3164 * dispextern.h (face_underline_type): New enum.
3165 (face): Add field for underline type.
3166 * nsterm.m (ns_draw_underwave): New function.
3167 (ns_draw_text_decoration): Use it.
3168 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3169 New functions.
3170 (x_draw_glyph_string): Use them.
3171 * xfaces.c (Qline, Qwave): New Lisp objects.
3172 (check_lface_attrs, merge_face_ref)
1053a871
SM
3173 (Finternal_set_lisp_face_attribute, realize_x_face):
3174 Handle wave-style underline face attributes.
9b0e3eba
AA
3175 * xterm.c (x_draw_underwave): New function.
3176 (x_draw_glyph_string): Use it.
3177
0fb52f11
JB
31782012-06-16 Juanma Barranquero <lekktu@gmail.com>
3179
3180 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3181 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3182 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3183 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3184 ($(BLD)/w32select.$(O)): Update dependencies.
3185
e5560ff7
AS
31862012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3187
3188 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3189 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3190 * character.c (_fetch_multibyte_char_p): Remove.
3191 * alloc.c: Include "character.h" before "buffer.h".
3192 * bidi.c: Likewise.
3193 * buffer.c: Likewise.
3194 * bytecode.c: Likewise.
3195 * callint.c: Likewise.
3196 * callproc.c: Likewise.
3197 * casefiddle.c: Likewise.
3198 * casetab.c: Likewise.
3199 * category.c: Likewise.
3200 * cmds.c: Likewise.
3201 * coding.c: Likewise.
3202 * composite.c: Likewise.
3203 * dired.c: Likewise.
3204 * dispnew.c: Likewise.
3205 * doc.c: Likewise.
3206 * dosfns.c: Likewise.
3207 * editfns.c: Likewise.
3208 * emacs.c: Likewise.
3209 * fileio.c: Likewise.
3210 * filelock.c: Likewise.
3211 * font.c: Likewise.
3212 * fontset.c: Likewise.
3213 * fringe.c: Likewise.
3214 * indent.c: Likewise.
3215 * insdel.c: Likewise.
3216 * intervals.c: Likewise.
3217 * keyboard.c: Likewise.
3218 * keymap.c: Likewise.
3219 * lread.c: Likewise.
3220 * macros.c: Likewise.
3221 * marker.c: Likewise.
3222 * minibuf.c: Likewise.
3223 * nsfns.m: Likewise.
3224 * nsmenu.m: Likewise.
3225 * print.c: Likewise.
3226 * process.c: Likewise.
3227 * regex.c: Likewise.
3228 * region-cache.c: Likewise.
3229 * search.c: Likewise.
3230 * syntax.c: Likewise.
3231 * term.c: Likewise.
3232 * textprop.c: Likewise.
3233 * undo.c: Likewise.
3234 * unexsol.c: Likewise.
3235 * w16select.c: Likewise.
3236 * w32fns.c: Likewise.
3237 * w32menu.c: Likewise.
3238 * window.c: Likewise.
3239 * xdisp.c: Likewise.
3240 * xfns.c: Likewise.
3241 * xmenu.c: Likewise.
3242 * xml.c: Likewise.
3243 * xselect.c: Likewise.
3244
2f07e6af
EZ
32452012-06-16 Eli Zaretskii <eliz@gnu.org>
3246
1053a871
SM
3247 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3248 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3249 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3250 row.
3251 (handle_face_prop): Use chunk-relative overlay string index when
3252 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3253 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3254 the rightmost. (Bug#11720)
2f07e6af 3255
29b83cec
AS
32562012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3257
3258 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3259 (CATEGORY_MEMBER): Enforce 1/0 value.
3260 * category.c (_temp_category_set): Remove.
3261
4c5501e9
EZ
32622012-06-16 Eli Zaretskii <eliz@gnu.org>
3263
3264 * window.c (Fdelete_other_windows_internal)
3265 (Fdelete_window_internal): Don't access frame's mouse highlight
3266 info of the initial frame. (Bug#11677)
3267
2b570124
PE
32682012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3269
e93864f9
PE
3270 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3271 Assume USE_2_TAGS_FOR_INTS.
3272 (xreload): Adjust $tagmask width to match recent lisp.h change.
3273
2b570124
PE
3274 Simplify lisp.h in minor ways that should not affect code.
3275 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3276 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3277 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3278 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3279 (INTTYPEBITS): New macro, for clarity.
3280 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3281 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3282 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3283 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3284 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3285
81755f69
JB
32862012-06-13 Juanma Barranquero <lekktu@gmail.com>
3287
3288 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3289
16192a57
GM
32902012-06-13 Glenn Morris <rgm@gnu.org>
3291
3292 * s/bsd-common.h (BSD4_3):
3293 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3294
646b5f55
AS
32952012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3296
3297 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3298 instead of union.
3299 (XLI, XIL): Define.
1053a871
SM
3300 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3301 Use them.
3302 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3303 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3304 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3305 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3306 * frame.c (delete_frame): Remove outdated comment.
3307 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3308 USE_LISP_UNION_TYPE.
3309 (Fw32_unregister_hot_key): Likewise.
3310 (Fw32_toggle_lock_key): Likewise.
3311 * w32menu.c (add_menu_item): Likewise.
3312 (w32_menu_display_help): Use XIL instead of checking
3313 USE_LISP_UNION_TYPE.
3314 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3315 (init_heap): Likewise.
3316 * w32term.c (w32_read_socket): Update comment.
3317
1d3823c9
GM
33182012-06-13 Glenn Morris <rgm@gnu.org>
3319
c62ff706
GM
3320 * s/usg5-4-common.h, src/s/unixware.h:
3321 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3322
1d3823c9
GM
3323 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3324
bfe3e0a2
PE
33252012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3326
3327 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3328 * alloc.c (make_number) [!defined make_number]:
3329 Remove, as lisp.h always defines this now.
3330 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3331 (roundup_size): Verify that it is a power of 2.
3332 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3333 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3334 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3335 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3336 USE_LSB_TAG now is always defined to be either 0 or 1.
3337 All uses changed.
3338 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3339 code works fine either way, and efficiency is not a concern here,
3340 as the union type is for debugging, not for production.
3341 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3342 Use an inline function on all platforms when using the union type,
3343 since this is simpler and 'static inline' can be used portably
3344 within Emacs now.
3345 (LISP_INITIALLY_ZERO): New macro.
3346 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3347 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3348
45fa9c0f
GM
33492012-06-12 Glenn Morris <rgm@gnu.org>
3350
b4492cba
GM
3351 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3352
3353 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3354
45fa9c0f
GM
3355 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3356 Move BROKEN_SIGIO to configure.
3357
3358 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3359 Move NO_TERMIO to configure.
3360
0e25d334
CY
33612012-06-12 Chong Yidong <cyd@gnu.org>
3362
3363 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3364 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3365 MagickExportImagePixels is undefined.
3366
43682bb6
PE
33672012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3368
3369 * image.c (imagemagick_load_image): Remove unused label.
3370
a9be7d2b
GM
33712012-06-11 Glenn Morris <rgm@gnu.org>
3372
3373 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3374 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3375 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3376 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3377
3017f87f
SM
33782012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3379
3380 * alloc.c (make_byte_code): New function.
3381 (Fmake_byte_code): Use it. Don't purify here.
3382 * lread.c (read1): Use it as well to avoid extra allocation.
3383
1b9b4cf4
CY
33842012-06-11 Chong Yidong <cyd@gnu.org>
3385
3386 * image.c (imagemagick_load_image): Implement transparency.
3387
95988fcf
AS
33882012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3389
3390 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3391 account for preceding backslashes. (Bug#11663)
3392
cd4eb164
CY
33932012-06-09 Chong Yidong <cyd@gnu.org>
3394
3395 * term.c: Support italics in capable terminals (Bug#9652).
3396 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3397 (turn_on_face): Output using TS_enter_italic_mode if available.
3398 Don't handle unused blinking and alt-charset cases.
3399 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3400 and tty_alt_charset_p cases.
3401 (tty_capable_p, init_tty): Support italics.
3402
3403 * termchar.h (struct tty_display_info): Add field for italics.
3404 Remove unused blink field.
3405
3406 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3407 Handle slant.
3408
3409 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3410 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3411 tty_alt_charset_p. Add tty_italic_p.
3412
ff88beb8
MA
34132012-06-09 Michael Albinus <michael.albinus@gmx.de>
3414
3415 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3416 dbus_type_is_basic if available.
3417 (xd_extract_signed, xd_extract_unsigned): Rename from
3418 extract_signed and extract_unsigned, respectively. Adapt callers.
3419
44286096
CY
34202012-06-09 Chong Yidong <cyd@gnu.org>
3421
1682701f
CY
3422 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3423
44286096
CY
3424 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3425 case (Bug#9752).
3426
d86feb17
PE
34272012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3428
3429 * xdisp.c (vmessage): Treat frame message as multibyte.
3430 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3431 would generate the diagnostic "Making \302\247 buffer-local while
3432 let-bound!".
3433
d5c20fe8
EZ
34342012-06-08 Eli Zaretskii <eliz@gnu.org>
3435
3436 * dispnew.c (showing_window_margins_p): Undo last change, which
3437 was done due to an inadvertent commit.
3438 (adjust_frame_glyphs_for_frame_redisplay): Do call
3439 showing_window_margins_p.
3440
513749ee
SM
34412012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3442
3443 * eval.c (Fmake_var_non_special): New primitive.
3444 (syms_of_eval): Defsubr it.
3445 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3446
d4a8f5c1
JB
34472012-06-08 Juanma Barranquero <lekktu@gmail.com>
3448
3449 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3450 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3451
8bbbc977
EZ
34522012-06-08 Eli Zaretskii <eliz@gnu.org>
3453
3454 * alloc.c (allocate_vectorlike): Fix last change.
3455
f3372c87
DA
34562012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3457
3458 Block-based vector allocation of small vectors.
3459 * lisp.h (struct vectorlike_header): New field `nbytes',
3460 adjust comment accordingly.
3461 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3462 to denote vector blocks. Adjust users (live_vector_p,
3463 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3464 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3465 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3466 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3467 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3468 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3469 (roundup_size): New constant.
3470 (struct vector_block): New data type.
3471 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3472 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3473 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3474 (sweep_vectors): New functions.
3475 (allocate_vectorlike): Return `zero_vector' as the only vector of
3476 0 items. Allocate new vector from block if vector size is less than
3477 or equal to VBLOCK_BYTES_MAX.
3478 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3479 (init_alloc_once): Add call to init_vectors.
3480
4f18a4ed
SM
34812012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3482
3483 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3484
86f158bc
PE
34852012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3486
3487 * doprnt.c (doprnt): Truncate multibyte char correctly.
3488 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3489 would mishandle a string argument "Xc" if X was a multibyte
3490 character of length 2: it would truncate after X's first byte
3491 rather than including all of X.
3492
c5cfcbe0
CY
34932012-06-06 Chong Yidong <cyd@gnu.org>
3494
3495 * buffer.c (word_wrap): Doc fix.
3496
c05cf390
PE
34972012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3498
3499 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3500
0c3461de
GM
35012012-06-03 Glenn Morris <rgm@gnu.org>
3502
3503 * xdisp.c (tool-bar-style): Doc fix.
3504
c71232db
UM
35052012-06-03 Ulrich Müller <ulm@gentoo.org>
3506
3507 * Makefile.in (PAXCTL): Define.
3508 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3509 binary via PaX flags if the paxctl utility is available.
3510 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3511 Restore PaX flags to their default. (Bug#11398)
3512
383f7350
CY
35132012-06-03 Chong Yidong <cyd@gnu.org>
3514
3515 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3516 buffer (Bug#11226).
3517
5f2c76c6
CY
35182012-06-03 Chong Yidong <cyd@gnu.org>
3519
3520 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3521 (note_mode_line_or_margin_highlight): If there is no help echo,
3522 use mode-line-default-help-echo. Handle the case where the mouse
3523 position is past the end of the mode line string.
3524
3525 * buffer.c (buffer_local_value_1): New function, split from
3526 Fbuffer_local_value; can return Qunbound.
3527 (Fbuffer_local_value): Use it.
3528 (Vmode_line_format): Docstring tweaks.
3529
773d47f6
PE
35302012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3531
3532 * sysdep.c (system_process_attributes): Improve comment.
3533
f2d6a3df
SM
35342012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3535
3536 * keyboard.c: Export real-this-command to Elisp.
3537 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3538 and DEFVAR it. Update all users.
3539
63810350
PE
35402012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3541
7bd5c1f4
PE
3542 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3543
63810350
PE
3544 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3545 Convert pctcpu and pctmem to Lisp float properly.
3546 Let the compiler fold better, as 100.0/0x8000 is exact.
3547
a2821611
AS
35482012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3549
3550 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3551 cons_block.
3552
5fceba1d
PE
35532012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3554
3555 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3556
c98ff5dd
DA
35572012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3558
3559 For a 'struct window', replace some Lisp_Object fields to
3560 bitfields where appropriate, remove unused fields.
3561 * window.h (struct window): Remove unused 'last_mark_x' and
3562 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3563 change it's type from Lisp_Object to bitfield.
3564 Change type of 'force_start', 'optional_new_start',
3565 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3566 fields from Lisp_Object to bitfield. Adjust users accordingly.
3567
ca34e0be
PE
35682012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3569
3570 Pacify gcc -Wdouble-precision when using Xaw.
3571 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3572 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3573 Use 'float' consistently, rather than 'float' in most places
3574 and 'double' in a couple of places.
3575
efc00ab1 35762012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3577
3578 * xdisp.c (handle_stop): Detect whether we have overlay strings
3579 loaded by testing it->current.overlay_string_index to be
3580 non-negative, instead of checking whether n_overlay_strings is
3581 positive. (Bug#11587)
3582
efc00ab1 35832012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3584
3585 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3586
3587 * doc.c (Fsubstitute_command_keys): Doc fix.
3588
efc00ab1 35892012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3590
3591 * search.c (search_buffer): Remove calls to
3592 r_alloc_inhibit_buffer_relocation, as it is now called by
3593 maybe_unify_char, which was the cause of relocation of buffer text
3594 in bug#11519.
3595
efc00ab1 35962012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3597
3598 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3599 for the duration of call to load_charset, to avoid problems with
3600 callers of maybe_unify_char that access buffer text through C
3601 pointers.
3602
3603 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3604 decrement the inhibition flag, instead of just setting or
3605 resetting it.
3606
ba93a187
PE
36072012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3608
3609 Remove obsolete '#define static' cruft.
3610 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3611 This #undef was "temporary" in 2000; it is no longer needed
3612 now that '#define static' has gone away.
3613 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3614 (gray_bitmap_bits): Remove; no longer needed.
3615 All uses replaced with definiens.
3616 * xterm.c: Include "bitmaps/gray.xbm".
3617
9e4bf381
PE
36182012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3619
3620 Clean up __executable_start, monstartup when --enable-profiling.
3621 The following changes affect the code only when profiling.
3622 * dispnew.c (__executable_start): Rename from safe_bcopy.
3623 Define only on platforms that need it.
3624 * emacs.c: Include <sys/gmon.h> when profiling.
3625 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3626 (__executable_start): Remove decl, since lisp.h does it now.
3627 (safe_bcopy): Remove decl; no longer has that name.
3628 (main): Coalesce #if into single bit of code, for simplicity.
3629 Cast pointers to uintptr_t, since standard libraries want integers
3630 and not pointers.
3631 * lisp.h (__executable_start): New decl.
3632
32d72c2f
GM
36332012-05-31 Glenn Morris <rgm@gnu.org>
3634
3635 * image.c (Fimagemagick_types): Doc fix.
3636
baac5bc7
JM
36372012-05-30 Jim Meyering <meyering@redhat.com>
3638
3639 * callproc.c (Fcall_process_region): Include directory component
3640 in mkstemp error message (Bug#11586).
3641
72cb32cf
PE
36422012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3643
3644 * alloc.c, lisp.h (make_pure_vector): Now static.
3645
61b108cc
SM
36462012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3647
3648 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3649 Move to byte-run.el.
3650 (Fautoload): Do the hash-doc more carefully.
3651 * data.c (Fdefalias): Purify definition, except for keymaps.
3652 (Qdefun): Move from eval.c.
3653 * lisp.h (Qdefun): Remove.
3654 * lread.c (read1): Tiny simplification.
3655
471fe23d
TN
36562012-05-29 Troels Nielsen <bn.troels@gmail.com>
3657
934f3f58 3658 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3659 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3660 Bug#9642, but explicitly check that the buffer the overlay would
3661 be moved to is live and rearrange lines to make sure that errors
3662 will not put the overlay in an inconsistent state.
3663 (Fdelete_overlay): Cosmetics.
3664
85d0efd1
EZ
36652012-05-28 Eli Zaretskii <eliz@gnu.org>
3666
3667 * w32term.c (my_bring_window_to_top): New function.
3668 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3669 could be different from the original one.
3670 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3671 (Bug#11513)
3672
3673 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3674 by calling BringWindowToTop.
3675
3676 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3677 (WM_EMACS_END): Increase by one.
3678
da92a98c
PE
36792012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3680
3681 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3682 This avoids undefined behavior that might cause the eassert
3683 to not catch an out-of-range value.
3684
74d1f848
JB
36852012-05-28 Juanma Barranquero <lekktu@gmail.com>
3686
3687 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3688 Update dependencies.
3689
9e1a06fc
EZ
36902012-05-27 Eli Zaretskii <eliz@gnu.org>
3691
3692 * bidi.c (bidi_mirror_char): Fix last change.
3693
f3dd7312
AS
36942012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3695
3696 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3697 when referring to sectname field in printf format.
3698
81899c91
PE
36992012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3700
57b81a9f
PE
3701 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3702 Only r_alloc_inhibit_buffer_relocation needed to be added;
3703 the others were already declared.
3704
81899c91
PE
3705 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3706 before checking whether it's out of range. Put the check inside
3707 eassert. See
3708 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3709
33017faf 37102012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3711
3712 * callproc.c (Fcall_process): Restore a line that was accidentally
3713 commented out in the 2011-02-13 change (bug#11547).
3714
33017faf 37152012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3716
3717 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3718 defined on ralloc.c.
3719
3720 * buffer.c [REL_ALLOC]: Remove prototypes of
3721 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3722 they are now on lisp.h.
3723
3724 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3725
3726 * search.c (search_buffer): Use it to inhibit relocation of buffer
3727 text while re_search_2 is doing its job, because re_search_2 is
3728 passed C pointers to buffer text. (Bug#11519)
3729
23415acf
EZ
3730 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3731 Update value to 24.
3732
44e27368
EZ
3733 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3734 state after an additional call to move_it_in_display_line_to, keep
3735 the values of it->max_ascent and it->max_descent found for the
3736 entire line.
3737 (pos_visible_p): Revert the comparison against bottom_y to what it
3738 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3739 (Bug#11464)
3740
c1892f11
PE
37412012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3742
3743 Fix coding-related core dumps with gcc -ftrapv.
3744 The code was computing A - B, where A and B are pointers, and B is
3745 random garbage. This can lead to core dumps on platforms that
3746 have special pointer registers, and it also leads to core dumps on
3747 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3748 A - B only when B is initialized properly.
3749 * coding.c (coding_set_source, coding_set_destination): Return void.
3750 (coding_change_source, coding_change_destinations): New functions,
3751 with the old behaviors of coding_set_source and coding_set_destination.
3752 All callers that need an offset changed to use these new functions.
3753
eb7afdad
GM
37542012-05-26 Glenn Morris <rgm@gnu.org>
3755
3756 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3757
f12fdf02
EZ
37582012-05-26 Eli Zaretskii <eliz@gnu.org>
3759
53a63be6 3760 Extend mouse support on W32 text-mode console.
61b108cc
SM
3761 * xdisp.c (draw_row_with_mouse_face):
3762 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3763
eb3f6f01 3764 * w32console.c: Include window.h.
61b108cc
SM
3765 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3766 New functions.
eb3f6f01
EZ
3767 (initialize_w32_display): Initialize mouse-highlight data.
3768
53a63be6
EZ
3769 * w32inevt.c: Include termchar.h and window.h.
3770 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3771 moves, call note_mouse_highlight. If help_echo changed, call
3772 gen_help_event to produce help-echo message in the echo area.
3773 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3774 highlight info.
3775
4cfd81f6
PE
37762012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3777
3778 * lread.c (read1): Simplify slightly to avoid an overflow warning
3779 with GCC 4.7.0 on x86-64.
3780
4446092a
EZ
37812012-05-26 Eli Zaretskii <eliz@gnu.org>
3782
3783 * bidi.c (bidi_mirror_char): Revert last change: an int is
3784 definitely wide enough here.
3785
42b2a986 37862012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3787
42b2a986 3788 Fix integer width and related bugs (Bug#9874).
eb106a49 3789 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3790 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3791 (string_bytes, check_sblock, allocate_string_data):
3792 (compact_small_strings, Fmake_bool_vector, make_string)
3793 (make_unibyte_string, make_multibyte_string)
3794 (make_string_from_bytes, make_specified_string)
3795 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3796 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3797 (mark_vectorlike):
3798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3799 (allocate_pseudovector):
3800 Use int, not EMACS_INT, where int is wide enough.
3801 (inhibit_garbage_collection, Fgarbage_collect):
3802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3803 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3804 int might not be wide enough.
3805 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3806 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3807 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3808 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3809 (bidi_level_of_next_char, bidi_move_to_visually_next):
3810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3811 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3812 (Fkill_buffer, Fset_buffer_major_mode)
3813 (advance_to_char_boundary, Fbuffer_swap_text)
3814 (Fset_buffer_multibyte, overlays_at, overlays_in)
3815 (overlay_touches_p, struct sortvec, record_overlay_string)
3816 (overlay_strings, recenter_overlay_lists)
3817 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3818 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3819 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3820 (Foverlay_recenter, last_overlay_modification_hooks_used)
3821 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3823 (validate_region): Omit unnecessary test for b <= e,
3824 since that's guaranteed by the previous test.
d311d28c
PE
3825 (adjust_overlays_for_delete): Avoid pos + length overflow.
3826 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3827 (report_overlay_modification):
3828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3829 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3830 Omit pointer cast, which isn't needed anyway, and doesn't work
3831 after the EMACS_INT -> ptrdiff_t change.
02481186 3832 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3833 * buffer.h: Adjust decls to match defn changes elsewhere.
3834 (struct buffer_text, struct buffer):
3835 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3836 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3837 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3838 not int, to avoid needless 32-bit limit on 64-bit hosts.
3839 (exec_byte_code): Use tighter memory-full test, one that checks
3840 for alloca overflow. Don't compute the address of the object just
3841 before an array, as that's not portable. Use EMACS_INT, not
3842 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3843 * callint.c (Fcall_interactively):
3844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3845 * callproc.c (call_process_kill, Fcall_process):
3846 Don't assume pid_t fits into an Emacs fixnum.
3847 (call_process_cleanup, Fcall_process, child_setup):
3848 Don't assume pid_t fits into int.
3849 (call_process_cleanup, Fcall_process, delete_temp_file)
3850 (Fcall_process_region):
3851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3852 (Fcall_process): Simplify handling of volatile integers.
3853 Use int, not EMACS_INT, where int will do.
3854 * casefiddle.c (casify_object, casify_region, operate_on_word)
3855 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3857 (casify_object): Avoid integer overflow when overallocating buffer.
3858 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3859 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3860 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3861 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3862 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3863 integers are now checked earlier. All uses replaced with XINT.
3864 (ccl_driver):
3865 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3866 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3867 (ccl_driver, Fregister_code_conversion_map):
3868 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3869 (resolve_symbol_ccl_program): Check that vector header is in range.
3870 Always copy the vector, so that we can check its contents reliably
3871 now rather than having to recheck each instruction as it's being
3872 executed. Check that vector words fit in 'int'.
3873 (ccl_get_compiled_code, Fregister_ccl_program)
3874 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3875 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3876 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3877 contents are in range.
3878 (Fccl_execute_on_string): Check that status is in range.
3879 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3880 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3881 Accept and return EMACS_INT, not int, because callers can pass values
3882 out of 'int' range.
3883 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3884 (multibyte_chars_in_text, parse_str_as_multibyte)
3885 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3886 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3887 (string_escape_byte8, Fget_byte):
3888 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3889 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3890 avoid mishandling large integers.
3891 * character.h: Adjust decls to match defn changes elsewhere.
3892 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3893 (Ffind_charset_region):
3894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3895 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3896 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3897 Don't assume fixnum fits in int.
d311d28c
PE
3898 (load_charset_map_from_vector, Fmap_charset_chars):
3899 Remove now-unnecessary CHECK_NATNUMs.
3900 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3901 Don't rely on undefined behavior with signed left shift overflow.
3902 Don't assume unsigned int fits into fixnum, or that fixnum fits
3903 into unsigned int. Don't require max_code to be a valid fixnum;
3904 that's not true for gb10830 4-byte on a 32-bit host. Allow
3905 invalid_code to be a cons, for the same reason. Require code_offset
3906 to be a character. Avoid int overflow if max_char is close
3907 to INT_MAX.
3908 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3909 this is intended anyway and avoids some undefined behavior.
3910 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3911 INDEX_TO_CODE_POINT, as that's what it expects.
3912 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3913 * charset.h (DECODE_CHAR): Return int, not unsigned;
3914 this is what was intended anyway, and it avoids undefined behavior.
3915 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3916 integer-overflow issues.
3917 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3918 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3919 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3920 * chartab.c (Fmake_char_table, Fset_char_table_range)
3921 (uniprop_get_decoder, uniprop_get_encoder):
3922 Don't assume fixnum fits in int.
3923 * cmds.c (move_point): New function, that does the gist of
3924 Fforward_char and Fbackward_char, but does so while checking
3925 for integer overflow more accurately.
c96e5d6a 3926 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3927 (Fforward_line, Fend_of_line, internal_self_insert)
3928 (internal_self_insert):
3929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3930 Fix a FIXME, by checking for integer overflow when calculating
3931 target_clm and actual_clm.
3932 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3933 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3934 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3935 (coding_alloc_by_making_gap, alloc_destination)
3936 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3937 (encode_coding_utf_16, detect_coding_emacs_mule)
3938 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3939 (detect_coding_iso_2022, decode_coding_iso_2022)
3940 (encode_invocation_designation, encode_designation_at_bol)
3941 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3942 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3943 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3944 (encode_coding_ccl, encode_coding_raw_text)
3945 (detect_coding_charset, decode_coding_charset)
3946 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3947 (produce_composition, produce_charset, produce_annotation)
3948 (decode_coding, handle_composition_annotation)
3949 (handle_charset_annotation, consume_chars, decode_coding_gap)
3950 (decode_coding_object, encode_coding_object, detect_coding_system)
3951 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3952 (code_convert_region, code_convert_string)
8f50130c
PE
3953 (Fdefine_coding_system_internal)
3954 (coding_set_source, coding_set_destination):
d311d28c
PE
3955 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3956 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3957 (Fdefine_coding_system_internal):
3958 Don't assume fixnums fit in int.
3959 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3960 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3961 (Funencodable_char_position, Fcheck_coding_systems_region)
3962 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3964 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3965 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3966 Don't access memory outside of the args array.
d311d28c 3967 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3968 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3969 result of ENCODE_CHAR.
d311d28c
PE
3970 * coding.h: Adjust decls to match defn changes elsewhere.
3971 (struct coding_system):
3972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3973 * composite.c (get_composition_id, find_composition)
3974 (run_composition_function, update_compositions)
3975 (compose_text, composition_gstring_put_cache)
3976 (composition_gstring_p, composition_gstring_width)
3977 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3978 (composition_compute_stop_pos, composition_reseat_it)
3979 (composition_update_it, struct position_record)
3980 (find_automatic_composition, composition_adjust_point)
3981 (Fcomposition_get_gstring, Ffind_composition_internal):
3982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3983 (update_compositions):
3984 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3985 * composite.h: Adjust decls to match defn changes elsewhere.
3986 (struct composition):
3987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3988 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3989 Do not attempt to compute the address of the object just before a
3990 buffer; this is not portable.
3991 (Faref, Faset):
3992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3993 (Faset): Use int, not EMACS_INT, where int is wide enough.
3994 (Fstring_to_number): Don't assume fixnums fit in int.
3995 (Frem): Don't assume arg is nonnegative.
3996 * dbusbind.c (xd_append_arg): Check for integers out of range.
3997 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3998 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3999 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4000 (xd_get_connection_references): Return ptrdiff_t, not int.
4001 All uses changed.
4002 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4003 (xd_read_message_1):
4004 Use int, not unsigned, where the dbus API uses int.
4005 (Fdbus_message_internal): Don't overflow mtype.
4006 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4007 * dired.c (directory_files_internal, file_name_completion, scmp)
4008 (file_name_completion_stat):
4009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4010 (file_name_completion): Don't overflow matchcount.
4011 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4012 * dispextern.h: Adjust decls to match defn changes elsewhere.
4013 (struct text_pos, struct glyph, struct bidi_saved_info)
4014 (struct bidi_string_data, struct bidi_it, struct composition_it)
4015 (struct it):
4016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4017 (struct display_pos, struct composition_it, struct it):
4018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4019 * dispnew.c (increment_matrix_positions)
4020 (increment_row_positions, mode_line_string)
4021 (marginal_area_string):
4022 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4023 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4025 (duration_to_sec_usec): New function, to check for overflow better.
4026 (Fsleep_for, sit_for): Use it.
4027 * doc.c (get_doc_string, store_function_docstring):
4028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4029 (get_doc_string, Fsnarf_documentation):
4030 Use int, not EMACS_INT, where int is wide enough.
4031 (get_doc_string):
4032 Use SAFE_ALLOCA, not alloca.
4033 Check for overflow when converting EMACS_INT to off_t.
4034 * doprnt.c (doprnt):
4035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4036 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4037 Don't assume uid_t fits into fixnum.
4038 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4039 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4040 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4041 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4042 (general_insert_function)
4043 (Finsert_char, make_buffer_string, make_buffer_string_both)
4044 (update_buffer_properties, Fbuffer_substring)
4045 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4046 (Fsubst_char_in_region, check_translation)
4047 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4048 (transpose_markers, Ftranspose_regions):
4049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4050 (clip_to_bounds): Move to lisp.h as an inline function).
4051 (Fconstrain_to_field): Don't assume integers are nonnegative.
4052 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4053 (Fsubst_char_in_region, Fsave_restriction):
4054 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4055 (Femacs_pid): Don't assume pid_t fits into fixnum.
4056 (lo_time): Use int, not EMACS_INT, when int suffices.
4057 (lisp_time_argument): Check for usec out of range.
4058 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4059 (Fuser_login_name, Fuser_full_name): Signal an error
4060 if a uid argument is out of range, rather than relying on
4061 undefined behavior.
c8d5c857
PE
4062 (Fformat_time_string): Remove now-unnecessary check.
4063 lisp_time_argument checks for out-of-range usec now.
243e0530 4064 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4065 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4066 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4067 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4068 (init_cmdargs, Fdump_emacs):
4069 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4070 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4071 the bottom (typically) 32 bits of the fixnum.
4072 * eval.c (specpdl_size, call_debugger):
4073 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4074 (when_entered_debugger, Fbacktrace_debug):
4075 Don't assume fixnum can fit in int.
4076 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4077 the object just before a buffer; this is not portable.
4078 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4079 (grow_specpdl, unbind_to):
4080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4081 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4082 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4083 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4084 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4085 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4086 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4087 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4088 (a_write, e_write):
4089 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4090 (Fcopy_file, non_regular_nbytes, read_non_regular)
4091 (Finsert_file_contents):
4092 Use int, not EMACS_INT, where int is wide enough.
4093 (READ_BUF_SIZE): Verify that it fits in int.
4094 (Finsert_file_contents): Check that counts are in proper range,
4095 rather than assuming fixnums fit into ptrdiff_t etc.
4096 Don't assume fixnums fit into int.
125b3835 4097 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4098 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4099 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4100 (string_char_to_byte, string_byte_to_char)
4101 (string_make_multibyte, string_to_multibyte)
4102 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4103 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4104 (substring_both, Fdelete, internal_equal, Ffillarray)
4105 (Fclear_string, mapcar1)
4106 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4107 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4108 (larger_vector, make_hash_table, maybe_resize_hash_table)
4109 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4110 (Fmaphash, secure_hash):
4111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4112 (concat): Check for string index and length overflow.
4113 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4114 (Frequire):
4115 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4116 (larger_vector): New API (vec, incr_min, size_max) replaces old
4117 one (vec, new_size, init). This catches size overflow.
4118 INIT was removed because it was always Qnil.
4119 All callers changed.
4120 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4121 the upper bound on a hash table index size.
4122 (make_hash_table, maybe_resize_hash_table): Use it.
4123 (secure_hash): Computer start_byte and end_byte only after
4124 they're known to be in ptrdiff_t range.
4125 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4126 (Ffont_get_glyphs, Ffont_at):
4127 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4128 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4129 (Flist_fonts, Fopen_font):
4130 Don't assume fixnum can fit in int.
4131 (check_gstring): Don't assume index can fit in int.
4132 (font_match_p): Check that fixnum is a character, not a nonnegative
4133 fixnum, since the later code needs to stuff it into an int.
4134 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4135 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4136 conversion overflow issues.
4137 (Fopen_font): Check for integer out of range.
4138 (Ffont_get_glyphs): Don't assume index can fit in int.
4139 * font.h: Adjust decls to match defn changes elsewhere.
4140 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4141 integer overflow.
4142 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4143 printmax_t, where ptrdiff_t is wide enough.
4144 (Finternal_char_font):
4145 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4146 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4147 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4148 (Fset_frame_position, x_set_frame_parameters)
4149 (x_set_line_spacing, x_set_border_width)
4150 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4151 Check that fixnums are in proper range for system types.
4152 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4153 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4154 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4155 Use SAFE_ALLOCA_LISP, not alloca.
4156 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4157 intptr_t is wide enough.
4158 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4159 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4160 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4161 Check for fixnum out of range.
4162 * ftfont.c (ftfont_list): Don't assume index fits in int.
4163 Check that fixnums are in proper range for system types.
4164 (ftfont_shape_by_flt):
4165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4166 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4168 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4169 Check that fixnums are in proper range for system types.
4170 * gnutls.h: Adjust decls to match defn changes elsewhere.
4171 * gtkutil.c (xg_dialog_run):
4172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4173 (update_frame_tool_bar):
4174 Check that fixnums are in proper range for system types.
4175 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4176 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4177 * indent.c (last_known_column, last_known_column_point):
4178 (current_column_bol_cache):
4179 (skip_invisible, current_column, check_display_width):
4180 (check_display_width, scan_for_column, current_column_1)
4181 (Findent_to, Fcurrent_indentation, position_indentation)
4182 (indented_beyond_p, Fmove_to_column, compute_motion):
4183 (Fcompute_motion, Fvertical_motion):
4184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4185 (last_known_column_modified): Use EMACS_INT, not int.
4186 (check_display_width):
4187 (Fcompute_motion):
4188 Check that fixnums and floats are in proper range for system types.
4189 (compute_motion): Don't assume index or fixnum fits in int.
4190 (compute_motion, Fcompute_motion):
4191 Use int, not EMACS_INT, when it is wide enough.
4192 (vmotion): Omit local var start_hpos that is always 0; that way
4193 we don't need to worry about overflow in expressions involving it.
4194 * indent.h: Adjust decls to match defn changes elsewhere.
4195 (struct position):
4196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4197 Use int, not EMACS_INT, where int is wide enough.
4198 Remove unused members ovstring_chars_done and tab_offset;
4199 all uses removed.
4200 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4201 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4202 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4203 (make_gap, copy_text, insert, insert_and_inherit)
4204 (insert_before_markers, insert_before_markers_and_inherit)
4205 (insert_1, count_combining_before, count_combining_after)
4206 (insert_1_both, insert_from_string)
4207 (insert_from_string_before_markers, insert_from_string_1)
4208 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4209 (adjust_after_replace, adjust_after_insert, replace_range)
4210 (replace_range_2, del_range, del_range_1, del_range_byte)
4211 (del_range_both, del_range_2, modify_region)
4212 (prepare_to_modify_buffer, signal_before_change)
4213 (signal_after_change, Fcombine_after_change_execute):
4214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4215 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4216 (balance_an_interval, split_interval_right, split_interval_left)
4217 (find_interval, next_interval, update_interval)
4218 (adjust_intervals_for_insertion, delete_node, delete_interval)
4219 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4220 (static_offset_intervals, offset_intervals)
4221 (merge_interval_right, merge_interval_left, make_new_interval)
4222 (graft_intervals_into_buffer, temp_set_point_both)
4223 (temp_set_point, set_point, adjust_for_invis_intang)
4224 (set_point_both, move_if_not_intangible, get_property_and_range)
4225 (get_local_map, copy_intervals, copy_intervals_to_string)
4226 (compare_string_intervals, set_intervals_multibyte_1):
4227 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4228 * intervals.h: Adjust decls to match defn changes elsewhere.
4229 (struct interval):
4230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4231 * keyboard.c (this_command_key_count, this_single_command_key_start)
4232 (before_command_key_count, before_command_echo_length, echo_now)
4233 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4234 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4235 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4236 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4237 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4238 (last_non_minibuf_size, last_point_position, echo_truncate)
4239 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4240 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4241 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4242 (stuff_buffered_input):
4243 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4244 (last_auto_save, command_loop_1, read_char):
4245 Use EMACS_INT, not int, to avoid integer overflow.
4246 (record_char): Avoid overflow in total_keys computation.
4247 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4248 * keyboard.h: Adjust decls to match defn changes elsewhere.
4249 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4250 (Fkey_description, Fdescribe_vector, Flookup_key):
4251 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4252 (click_position): New function, to check that positions are in range.
4253 (Fcurrent_active_maps):
4254 (describe_command):
4255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4256 (Faccessible_keymaps, Fkey_description):
4257 (preferred_sequence_p):
4258 Don't assume fixnum can fit into int.
4259 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4260 Check for integer overflow in size calculations.
4261 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4262 avoid mishandling large integers.
4263 * lisp.h: Adjust decls to match defn changes elsewhere.
4264 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4265 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4266 (struct Lisp_Marker):
4267 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4268 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4269 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4270 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4271 All callers changed.
4272 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4273 Assume the arg has valid form, since it always does.
4274 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4275 unsigned integer system type.
4276 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4277 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4278 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4279 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4280 (duration_to_sec_usec): New decl.
4281 * lread.c (read_from_string_index, read_from_string_index_byte)
4282 (read_from_string_limit, readchar, unreadchar, openp)
4283 (read_internal_start, read1, oblookup):
4284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4285 (Fload, readevalloop, Feval_buffer, Feval_region):
4286 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4287 (openp): Check for out-of-range argument to 'access'.
4288 (read1): Use int, not EMACS_INT, where int is wide enough.
4289 Don't assume fixnum fits into int.
6efdadfd 4290 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4291 (read_filtered_event): Use duration_to_sec_usec
4292 to do proper overflow checking on durations.
d311d28c
PE
4293 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4294 in size calculation.
4295 (Fexecute_kbd_macro):
4296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4297 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4298 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4299 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4300 (set_marker_both, set_marker_restricted_both, marker_position)
4301 (marker_byte_position, Fbuffer_has_markers_at):
4302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4303 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4304 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4305 It now merely ensures that the menu is large enough, without
4306 necessarily growing it, as this avoids some integer overflow issues.
4307 All callers changed.
4308 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4309 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4310 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4311 Use SAFE_ALLOCA_LISP, not alloca.
4312 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4313 to EMACS_INT. Check that fixnums are in proper range for system types.
4314 * minibuf.c (minibuf_prompt_width, string_to_object)
4315 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4316 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4318 (get_minibuffer, read_minibuf_unwind):
4319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4320 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4321 this simplifies overflow checking. All callers changed.
4322 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4323 (Ftest_completion):
4324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4325 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4326 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4327 Check that fixnums are in proper range for system types.
4328 (Fx_create_frame, Fx_show_tip):
4329 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4330 * nsfont.m (ns_findfonts, nsfont_list_family):
4331 Don't assume fixnum fits in long.
4332 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4333 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4334 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4335 wide enough.
17fdb222 4336 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4337 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4338 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4339 (PRINTDECLARE, PRINTPREPARE):
4340 (strout, print_string):
4341 (print, print_preprocess, print_check_string_charset_prop)
4342 (print_object):
4343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4344 (PRINTDECLARE):
4345 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4346 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4347 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4348 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4349 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4350 (print_error_message): Use SAFE_ALLOCA, not alloca.
4351 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4352 (print_depth, new_backquote_output, print_number_index):
4353 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4354 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4355 (Fset_process_window_size, Fformat_network_address)
4356 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4357 (sigchld_handler):
d311d28c 4358 Check that fixnums are in proper range for system types.
d44287d4 4359 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4360 Check for process-ids out of pid_t range rather than relying on
4361 undefined behavior.
e4d81efc 4362 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4363 (Fformat_network_address, read_process_output, send_process)
4364 (Fprocess_send_region, status_notify):
4365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4366 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4367 (wait_reading_process_output, read_process_output, exec_sentinel):
4368 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4369 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4370 (Faccept_process_output): Use duration_to_sec_usec to do proper
4371 overflow checking on durations.
dde14581
PE
4372 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4373 Don't assume pid_t fits in int.
02481186
PE
4374 * process.h (struct Lisp_Process): Members tick and update_tick
4375 are now of type EMACS_INT, not int.
b62b53e8
PE
4376 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4377 configured --with-wide-int.
d311d28c
PE
4378 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4379 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4380 * search.c (looking_at_1, string_match_1):
4381 (fast_string_match, fast_c_string_match_ignore_case)
4382 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4383 (scan_newline, find_before_next_newline, search_command)
4384 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4385 (set_search_regs, wordify):
4386 (Freplace_match):
4387 (Fmatch_data):
4388 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4389 (string_match_1, search_buffer, set_search_regs):
4390 (Fmatch_data):
4391 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4392 (wordify): Check for overflow in size calculation.
4393 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4394 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4395 Check that fixnums are in proper range for system types.
4396 * sound.c (struct sound_device)
4397 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4398 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4399 (Fplay_sound_internal):
4400 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4401 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4402 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4403 (Fparse_partial_sexp):
4404 Don't assume fixnums can fit in int.
4405 (struct lisp_parse_state, find_start_pos, find_start_value)
4406 (find_start_value_byte, find_start_begv)
4407 (update_syntax_table, char_quoted, dec_bytepos)
4408 (find_defun_start, prev_char_comend_first, back_comment):
4409 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4410 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4412 (Finternal_describe_syntax_value): Check that match_lisp is a
4413 character, not an integer, since the code stuffs it into int.
4414 (scan_words, scan_sexps_forward):
4415 Check that fixnums are in proper range for system types.
4416 (Fforward_word):
4417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4418 (scan_sexps_forward):
4419 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4420 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4421 * syntax.h: Adjust decls to match defn changes elsewhere.
4422 (struct gl_state_s):
4423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4424 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4425 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4426 * sysdep.c (wait_for_termination_1, wait_for_termination)
4427 (interruptible_wait_for_termination, mkdir):
4428 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4429 (emacs_read, emacs_write):
4430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4431 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4432 and double all fit in int.
d311d28c
PE
4433 * term.c (set_tty_color_mode):
4434 Check that fixnums are in proper range for system types.
4435 * termhooks.h (struct input_event):
4436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4437 * textprop.c (validate_interval_range, interval_of)
4438 (Fadd_text_properties, set_text_properties_1)
4439 (Fremove_text_properties, Fremove_list_of_text_properties)
4440 (Ftext_property_any, Ftext_property_not_all)
4441 (copy_text_properties, text_property_list, extend_property_ranges)
4442 (verify_interval_modification):
4443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4444 (Fnext_single_char_property_change)
4445 (Fprevious_single_char_property_change):
4446 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4447 (copy_text_properties):
4448 Check for integer overflow in index calculation.
d311d28c
PE
4449 * undo.c (last_boundary_position, record_point, record_insert)
4450 (record_delete, record_marker_adjustment, record_change)
4451 (record_property_change):
4452 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4453 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4455 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4456 (Fx_hide_tip, Fx_file_dialog):
4457 * w32menu.c (set_frame_menubar):
4458 Use ptrdiff_t, not int, for consistency with rest of code.
4459 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4460 (select_window, Fdelete_other_windows_internal)
4461 (window_scroll_pixel_based, window_scroll_line_based)
4462 (Frecenter, Fset_window_configuration):
4463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4464 (Fset_window_hscroll, run_window_configuration_change_hook)
4465 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4466 (Fscroll_other_window, Frecenter):
d311d28c
PE
4467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4468 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4469 Don't assume fixnum fits in int.
4470 (Fset_window_scroll_bars):
4471 Check that fixnums are in proper range for system types.
4472 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4473 (string_pos, c_string_pos, number_of_chars, init_iterator)
4474 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4475 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4476 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4477 (face_before_or_after_it_pos, handle_invisible_prop)
4478 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4479 (display_prop_intangible_p, string_buffer_position_lim)
4480 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4481 (get_overlay_strings_1, get_overlay_strings)
4482 (iterate_out_of_display_property, forward_to_next_line_start)
4483 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4484 (get_next_display_element, set_iterator_to_next)
4485 (get_visually_first_element, compute_stop_pos_backwards)
4486 (handle_stop_backwards, next_element_from_buffer)
4487 (move_it_in_display_line_to, move_it_in_display_line)
4488 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4489 (add_to_log, message_dolog, message_log_check_duplicate)
4490 (message2, message2_nolog, message3, message3_nolog
4491 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4492 (current_message_1, truncate_echo_area, truncate_message_1)
4493 (set_message, set_message_1, store_mode_line_noprop)
4494 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4495 (text_outside_line_unchanged_p, check_point_in_composition)
4496 (reconsider_clip_changes)
4497 (redisplay_internal, set_cursor_from_row, try_scrolling)
4498 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4499 (redisplay_window, find_last_unchanged_at_beg_row)
4500 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4501 (trailing_whitespace_p, find_row_edges, display_line)
4502 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4503 (display_mode_element, store_mode_line_string)
4504 (pint2str, pint2hrstr, decode_mode_spec)
4505 (display_count_lines, display_string, draw_glyphs)
4506 (x_produce_glyphs, x_insert_glyphs)
4507 (rows_from_pos_range, mouse_face_from_buffer_pos)
4508 (fast_find_string_pos, mouse_face_from_string_pos)
4509 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4511 (safe_call, init_from_display_pos, handle_fontified_prop)
4512 (handle_single_display_spec, load_overlay_strings)
4513 (with_echo_area_buffer, setup_echo_area_for_printing)
4514 (display_echo_area, echo_area_display)
4515 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4516 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4517 (redisplay_window, dump_glyph_row, display_mode_line)
4518 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4519 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4521 (handle_single_display_spec, build_desired_tool_bar_string)
4522 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4523 (get_specified_cursor_type):
4524 Check that fixnums are in proper range for system types.
4525 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4526 (Flookup_image_map):
4527 Don't assume fixnums fit in int.
4528 (compare_overlay_entries):
4529 Avoid mishandling comparisons due to subtraction overflow.
4530 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4531 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4532 (handle_tool_bar_click):
4533 Use int, not unsigned, since we prefer signed and the signedness
4534 doesn't matter here.
4535 (get_next_display_element, next_element_from_display_vector):
4536 Use int, not EMACS_INT, when int is wide enough.
4537 (start_hourglass): Use duration_to_sec_usec to do proper
4538 overflow checking on durations.
4539 * xfaces.c (Fbitmap_spec_p):
4540 Check that fixnums are in proper range for system types.
4541 (compare_fonts_by_sort_order):
4542 Avoid mishandling comparisons due to subtraction overflow.
4543 (Fx_family_fonts, realize_basic_faces):
4544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4545 (Fx_family_fonts):
4546 Don't assume fixnum fits in int.
4547 Use SAFE_ALLOCA_LISP, not alloca.
4548 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4549 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4550 (face_at_buffer_position, face_for_overlay_string)
4551 (face_at_string_position):
4552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4553 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4554 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4555 (Fx_show_tip):
4556 Check that fixnums are in proper range for system types.
4557 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4558 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4560 (Fx_change_window_property): Don't assume fixnums fit in int.
4561 * xfont.c (xfont_chars_supported):
4562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4563 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4564 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4566 * xml.c (parse_region):
4567 * xrdb.c (magic_file_p):
4568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4569 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4570 (x_get_local_selection, x_reply_selection_request)
4571 (x_handle_selection_request, wait_for_property_change):
4572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4573 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4574 short is wide enough.
4575 (x_send_client_event): Don't assume fixnum fits in int.
4576 * xterm.c (x_x_to_emacs_modifiers):
4577 Don't assume EMACS_INT overflows nicely into int.
4578 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4579 may come from Lisp.
4580 (handle_one_xevent): NATNUMP can eval its arg twice.
4581 (x_connection_closed):
4582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4583 * xterm.h: Adjust decls to match defn changes elsewhere.
4584 (struct scroll_bar): Use struct vectorlike_header
4585 rather than rolling our own approximation.
4586 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4587
c6574eb5
GM
45882012-05-25 Glenn Morris <rgm@gnu.org>
4589
4590 * lisp.mk (lisp): Update for more files being compiled now.
4591
e8d32c7e
SM
45922012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4593
48def666
SM
4594 * lread.c: Remove `read_pure' which makes no difference.
4595 (read_pure): Remove var.
4596 (unreadpure): Remove function.
4597 (readevalloop): Don't call read_list with -1 flag.
4598 (read1, read_vector): Don't test read_pure any more.
4599 (read_list): Simplify.
4600
e8d32c7e
SM
4601 * fileio.c, character.h: Minor style tweaks.
4602
4b2addb7
DA
46032012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4604
4605 * window.h (clip_changed): Remove useless declaration.
4606
584461b2
JB
46072012-05-22 Juanma Barranquero <lekktu@gmail.com>
4608
4609 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4610 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4611
34374650
PE
46122012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4613
4614 Remove src/m/*.
4615 This directory predates autoconf and is no longer needed nowadays.
4616 Move its few remaining bits of functionality to where they're needed.
4617 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4618 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4619 * m/template.h: Remove.
4620 * Makefile.in (M_FILE): Remove. All uses removed.
4621 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4622 * lisp.h (USE_LSB_TAG):
4623 * mem-limits.h (EXCEEDS_LISP_PTR):
4624 Use VAL_MAX, not VALBITS, in #if.
4625 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4626 (EMACS_UINT): Define unconditionally now.
4627 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4628 (BITS_PER_EMACS_INT): New constants, replacing
4629 what used to be in config.h, but not useful in #if.
4630 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4631 define them any more.
4632 (VAL_MAX): New macro.
4633 (VALMASK): Use it.
4634 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4635 BITS_PER_EMACS_INT, in #if.
4636 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4637 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4638 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4639 * s/ms-w32.h (DATA_START):
4640 Move here from removed file m/intel386.h.
4641 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4642 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4643
261cb4bb
PE
46442012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4645
4646 Assume C89 or later.
4647 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4648 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4649 (xrealloc):
4650 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4651 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4652 * textprop.c, tparam.c (NULL): Remove.
4653 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4654 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4655 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4656 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4657 * xterm.c (input_signal_count): Assume volatile works.
4658
ff23cd9f
KB
46592012-05-21 Ken Brown <kbrown@cornell.edu>
4660
4661 * xgselect.c (xg_select): Fix first argument in call to 'select'
4662 (bug#11508).
4663
1b170bc6
KB
46642012-05-20 Ken Brown <kbrown@cornell.edu>
4665
4666 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4667 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4668
b2f4d39f
KB
46692012-05-19 Ken Brown <kbrown@cornell.edu>
4670
4671 * xfns.c (x_in_use): Remove `static' qualifier.
4672 * xterm.h (x_in_use): Declare.
4673 * xgselect.c: Include xterm.h.
4674 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4675 and `display_arg' (bug#9754).
4676
003fdae2
PE
46772012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4678
9232a6d9
PE
4679 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4680
003fdae2
PE
4681 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4682 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4683
784b56e2
EZ
46842012-05-18 Eli Zaretskii <eliz@gnu.org>
4685
4686 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4687
4688 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4689 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4690
4691 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4692 reference to image_cache->refcount.
4693 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4694
a0a79cde
JL
46952012-05-17 Juri Linkov <juri@jurta.org>
4696
4697 * search.c (Fword_search_regexp, Fword_search_backward)
4698 (Fword_search_forward, Fword_search_backward_lax)
4699 (Fword_search_forward_lax): Move functions to isearch.el
4700 (bug#10145, bug#11381).
4701
b0572523
PE
47022012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4703
4704 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4705
9660f5fc
SM
47062012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4707
4708 * lread.c (init_obarray): Declare Qt and Qnil as special.
4709
4374de83
GM
47102012-05-14 Glenn Morris <rgm@gnu.org>
4711
4712 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4713 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4714
dc44c39a
PE
47152012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4716
078c97cb
PE
4717 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4718
dc44c39a
PE
4719 * unexaix.c: Port to more-recent AIX compilers.
4720 (report_error, report_error_1, make_hdr, copy_sym)
4721 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4722 Make arguments const char *, not char *, to avoid violations of C
4723 standard and to fix some AIX warnings reported by Gilles Pion.
4724
e18afed7 47252012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4726
4727 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4728 already have overlays loaded.
4729 (handle_single_display_spec): Before returning without displaying
4730 fringe bitmap, synchronize the bidi iterator with the main display
4731 iterator, by calling iterate_out_of_display_property.
4732 (iterate_out_of_display_property): Detect buffer iteration by
4733 testing that it->string is a Lisp string.
4734 (get_next_display_element): When the current object is exhausted,
4735 and there's something on it->stack, call set_iterator_to_next to
4736 proceed with what's on the stack, instead of returning zero.
4737 (set_iterator_to_next): If called at the end of a Lisp string,
4738 proceed to consider_string_end without incrementing string
4739 position. Don't increment display vector index past the end of
4740 the display vector. (Bug#11417)
c8fb9dc6
EZ
4741 (pos_visible_p): Don't report a position visible when move_it_to
4742 stopped at the last line of window, which happens to be scanned
4743 backwards by the bidi iteration. (Bug#11464)
ac268e67 4744
e18afed7 47452012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4746
4747 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4748 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4749 are on a TTY, and thus unable to display on the fringes.
4750 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4751 so we need to signal to the caller that this is a "replacing"
4752 display spec. This fixes display when the spec is invalid or we
4753 are on a TTY.
4754
e18afed7 47552012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4756
4757 * unexaix.c (make_hdr): Fix typo in prototype.
4758 This bug broke the build on AIX. Problem reported by Gilles Pion.
4759
9d0a235a
MA
47602012-05-14 Michael Albinus <michael.albinus@gmx.de>
4761
4762 * keyboard.c (kbd_buffer_get_event): Read special events also in
4763 batch mode. (Bug#11415)
4764
9e6b06ed
GM
47652012-05-12 Glenn Morris <rgm@gnu.org>
4766
4767 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4768
c1a1d7a3
EZ
47692012-05-12 Eli Zaretskii <eliz@gnu.org>
4770
4771 * lisp.mk (lisp): Add newcomment.elc.
4772
3fe7cdc8
GM
47732012-05-12 Glenn Morris <rgm@gnu.org>
4774
4775 * Makefile.in (MKDIR_P): New, set by configure.
4776 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4777
53f7d2c0
PE
47782012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4779
4780 Remove unused function hourglass_started.
4781 * dispextern.h (hourglass_started):
4782 * w32fns.c (hourglass_started):
4783 * xdisp.c (hourglass_started): Remove.
4784
75aafb17
JB
47852012-05-10 Juanma Barranquero <lekktu@gmail.com>
4786
4787 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4788 Update dependencies.
4789
12959e8e
PE
47902012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4791
97107e2e
PE
4792 * xgselect.c (xg_select): Put maxfds+1 into a var.
4793 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4794
12959e8e
PE
4795 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4796
836d29b3
DA
47972012-05-10 Dave Abrahams <dave@boostpro.com>
4798
4799 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4800 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4801
5cb67954
MA
48022012-05-09 Michael Albinus <michael.albinus@gmx.de>
4803
4804 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4805 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4806 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4807 Initialize xd_registered_buses.
4808
3478ec45
PE
48092012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4810
b263a6b0
PE
4811 Untag more efficiently if USE_LSB_TAG.
4812 This is based on a proposal by YAMAMOTO Mitsuharu in
4813 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4814 For an admittedly artificial (nth 8000 longlist) benchmark on
4815 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4816 Emacs's overall text size by 1%.
4817 * lisp.h (XUNTAG): New macro.
4818 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4819 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4820 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4821 * eval.c (Fautoload):
4822 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4823 * frame.h (XFRAME): Use XUNTAG.
4824
3478ec45
PE
4825 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4826 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4827 Remove unportable assumptions about print widths of types like
4828 dbus_uint32_t.
4829 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4830 intptr_t when converting between pointer and integer, to avoid GCC
4831 warnings about wrong width.
4832
666b903b 48332012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4834
4835 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4836 stack for each reader_thread, instead of defaulting to 8MB
4837 determined by the linker. This avoids failures in creating
4838 subprocesses on Windows 7, see the discussion in this thread:
4839 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4840
b120cc17
JC
48412012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4842
4843 Fix up display of the *Minibuf-0* buffer in the mini window.
4844 * keyboard.c (read_char): Don't clear the echo area if there's no
4845 message to clear.
4846 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4847 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4848
9a4b36f8
MA
48492012-05-07 Michael Albinus <michael.albinus@gmx.de>
4850
4851 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4852 batch mode.
4853
e5f9458f
CY
48542012-05-06 Chong Yidong <cyd@gnu.org>
4855
4856 * lisp.mk (lisp): Update.
4857
eceeb5fc 48582012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4859
4860 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4861
71873e2b
SM
48622012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4863
4864 * data.c (PUT_ERROR): New macro.
4865 (syms_of_data): Use it. Add new error type `user-error'.
4866 * undo.c (user_error): New function.
4867 (Fprimitive_undo): Use it.
4868 * print.c (print_error_message): Adjust print style for `user-error'.
4869 * keyboard.c (user_error): New function.
4870 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4871
ab0fa4e4
PE
48722012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4873
4874 Do not limit current-time-string to years 1000..9999.
4875 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4876 (Fcurrent_time_string): Support any year that is supported by the
4877 underlying localtime representation. Don't use asctime, as it
4878 has undefined behavior for years outside the range -999..9999.
4879
7ed806a7
PE
48802012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4881
4882 Fix race conditions involving setenv, gmtime, localtime, asctime.
4883 Without this fix, interrupts could mess up code that uses these
4884 nonreentrant functions, since setting TZ invalidates existing
4885 tm_zone or tzname values, and since most of these functions return
4886 pointers to static storage.
4887 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4888 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4889 Grow the critical sections to include not just invoking
4890 localtime/gmtime, but also accessing these functions' results
4891 including their tm_zone values if any, and any related TZ setting.
4892 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4893 so that the struct tm is saved in the critical section.
4894 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4895 motivated by the fact that memory allocation needs to be outside
4896 the critical section.
4897
0c16dfed
DA
48982012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4899
4900 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4901 with RESET_INTERVAL.
4902
4903 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4904 Remove duplicated buffer name initialization.
4905
3f83ace8
JM
49062012-05-02 Jim Meyering <jim@meyering.net>
4907
4908 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4909
c7b8541e
JM
4910 * xfns.c (x_window): Use xstrdup (Bug#11375).
4911
90207a15 49122012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4913
4914 * xdisp.c (pos_visible_p): If already at a newline from the
4915 display string before the 'while' loop, don't walk back the glyphs
4916 from it3.glyph_row. Solves assertion violation when the display
4917 string begins with a newline (egg.el). (Bug#11367)
4918
b593d6a9
AH
49192012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4920
4921 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4922 Move to simple.el.
4923
4737362e
GM
49242012-05-01 Glenn Morris <rgm@gnu.org>
4925
99cf43f9
GM
4926 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4927 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4928 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4929 All were removed before 23.1.
4930
9311dcff
GM
4931 * dispnew.c: Remove HAVE_LIBNCURSES test;
4932 it is always true on relevant platforms.
4933
4d5c6349
GM
4934 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4935 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4936
4737362e
GM
4937 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4938
74dd3a6b
AS
49392012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4940
4941 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4942 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4943 Remove.
4944
13c379ee
PE
49452012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4946
4947 Do not avoid creating empty evaporating overlays (Bug#9642).
4948 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4949 That is, do not delete an evaporating overlay if it becomes
4950 empty after its bounds are adjusted to fit within its buffer.
4951 This fix caused other problems, and I'm reverting it until we get
4952 to the bottom of them.
4953
a8e7d6d7 49542012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4955
4956 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4957
a8e7d6d7 49582012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4959
4960 * xdisp.c (pos_visible_p): If the window start position is beyond
4961 ZV, start the display from buffer beginning. Prevents assertion
4962 violation in init_iterator when the minibuffer window is scrolled
4963 via the scroll bar.
4964
4965 * window.c (window_scroll_pixel_based): Likewise.
4966
a8e7d6d7 49672012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4968
4969 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4970
a8e7d6d7 49712012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4972
4973 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4974 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4975
a8e7d6d7 49762012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4977
b593d6a9
AH
4978 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4979 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4980
1c6900d9
EZ
49812012-04-26 Eli Zaretskii <eliz@gnu.org>
4982
4c3fa1d9
EZ
4983 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4984 display element, check also the underlying string or buffer
4985 character. (Bug#11341)
4986
1c6900d9
EZ
4987 * w32menu.c: Include w32heap.h.
4988 (add_menu_item): If the call to AppendMenuW (via
4989 unicode_append_menu) fails, disable Unicode menus only if we are
4990 running on Windows 9X/Me.
4991
42bf8205
AS
49922012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4993
4994 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4995 (xgetint): Add missing shift for LSB tags.
4996
b1bac16e
MR
49972012-04-24 Martin Rudalics <rudalics@gmx.at>
4998
4999 * keyboard.c (read_char): Don't wipe echo area for select window
5000 events: These might get delayed via `mouse-autoselect-window'
5001 (Bug#11304).
5002
d69621cc
JB
50032012-04-24 Juanma Barranquero <lekktu@gmail.com>
5004
5005 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5006 manipulation of :loaded-from data.
5007
02fd101b
JB
50082012-04-23 Juanma Barranquero <lekktu@gmail.com>
5009
5010 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5011 now a cons (bug#11311).
5012
888bec30
PE
50132012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5014
89a438bd
PE
5015 Do not create empty overlays with the evaporate property (Bug#9642).
5016 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5017 if it becomes empty after its bounds are adjusted to fit within
5018 its buffer. Without this fix, in a nonempty buffer (let ((o
5019 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5020 yields an empty overlay that has the evaporate property, which is
5021 not supposed to happen.
5022
1068fe4d
PE
5023 Fix minor GTK3 problems found by static checking.
5024 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5025 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5026 (struct _EmacsFixedClass, emacs_fixed_get_type):
5027 Move decls here from emacsgtkfixed.h, since they needn't be public.
5028 (emacs_fixed_get_type): Now static.
5029 (emacs_fixed_class_init): Omit unused local.
5030 (emacs_fixed_child_type): Remove; unused.
5031 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5032 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5033 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5034 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5035 (EMACS_FIXED_GET_CLASS): Remove; unused.
5036 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5037
888bec30
PE
5038 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5039 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5040
de85e130
PE
50412012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5042
d0baac98 5043 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5044 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5045 (__malloc_size_t, __malloc_ptrdiff_t):
5046 Remove. All uses removed, replaced by the definiens if needed,
5047 since we can assume C89 or better now.
5048 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5049 (protect_malloc_state, align, get_contiguous_space)
5050 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5051 (malloc_atfork_handler_child, malloc_enable_thread)
5052 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5053 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5054 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5055 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5056 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5057 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5058 Define using prototypes, not old style.
5059 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5060 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5061 (align): Don't assume that signed integer overflow wraps around.
5062 Omit unused local var.
5063 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5064 (_free_internal_nolock, memalign, mallochook, reallochook):
5065 Omit no-longer-needed casts.
5066 (valloc): Use getpagesize, not __getpagesize.
5067 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5068 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5069
de85e130
PE
5070 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5071
dcbf5805
MA
50722012-04-22 Michael Albinus <michael.albinus@gmx.de>
5073
5074 Move functions from C to Lisp. Make non-blocking method calls
5075 the default. Implement further D-Bus standard interfaces.
5076
5077 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5078 (QCdbus_request_name_allow_replacement)
5079 (QCdbus_request_name_replace_existing)
5080 (QCdbus_request_name_do_not_queue)
5081 (QCdbus_request_name_reply_primary_owner)
5082 (QCdbus_request_name_reply_in_queue)
5083 (QCdbus_request_name_reply_exists)
5084 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5085 (QCdbus_registered_serial, QCdbus_registered_method)
5086 (QCdbus_registered_signal): New Lisp objects.
5087 (XD_DEBUG_MESSAGE): Use sizeof.
5088 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5089 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5090 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5091 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5092 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5093 (xd_signature, xd_append_arg): Allow float for integer types.
5094 (xd_get_connection_references): New function.
b593d6a9
AH
5095 (xd_get_connection_address): Rename from xd_initialize.
5096 Return cached address.
dcbf5805
MA
5097 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5098 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5099 level.
5100 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5101 Return number of refcounts.
dcbf5805
MA
5102 (Fdbus_get_unique_name): Make stronger parameter check.
5103 (Fdbus_message_internal): New defun.
5104 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5105 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5106 (Fdbus_send_signal, Fdbus_register_service)
5107 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5108 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5109 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5110 (Vdbus_compiled_version, Vdbus_runtime_version)
5111 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5112 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5113 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5114 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5115 Adapt docstring.
dcbf5805 5116
52828e02
PE
51172012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5118
da05bc4c
PE
5119 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5120 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5121 Do not assume ptrdiff_t is the same width as 'int'.
5122
52828e02
PE
5123 * alloc.c: Handle unusual debugging option combinations.
5124 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5125 since the two debugging options are incompatible.
5126 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5127 is defined.
5128 (mem_init, mem_insert, mem_insert_fixup):
5129 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5130 (NEED_MEM_INSERT): Remove; no longer needed.
5131
f01769f9
LL
51322012-04-22 Leo Liu <sdl.web@gmail.com>
5133
5134 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5135
5790543d
PE
51362012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5137
5138 * sysdep.c [__FreeBSD__]: Minor cleanups.
5139 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5140 Use Emacs indenting style more consistently. Avoid some casts.
5141 Use 'double' consistently rather than mixing 'float' and 'double'.
5142
b91b7e4d
EW
51432012-04-21 Eduard Wiebe <usenet@pusto.de>
5144
b593d6a9
AH
5145 * sysdep.c (list_system_processes, system_process_attributes):
5146 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5147
6114eb15
AS
51482012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5149
5150 * lisp.mk (lisp): Update.
5151
2f38dff7
PE
51522012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5153
5154 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5155 It is never used otherwise.
5156
4ae29f89
SM
51572012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5158
5159 * print.c (print_preprocess): Only check print_depth if print-circle
5160 is nil.
5161 (print_object): Check for cycles even when print-circle is nil and
5162 print-gensym is t, but only check print_depth if print-circle is nil.
5163
f30d612a
CY
51642012-04-20 Chong Yidong <cyd@gnu.org>
5165
5166 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5167 set the status to "failed" and ensure that sentinel is run.
5168
c07a4c0b 51692012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5170
5171 * process.c (Fset_process_inherit_coding_system_flag)
5172 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5173 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5174
c07a4c0b 51752012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5176
5177 * xdisp.c (string_buffer_position_lim): Limit starting position to
5178 BEGV.
5179 (set_cursor_from_row): If called for a mode-line or header-line
5180 row, return zero immediately.
5181 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5182 farther than the first row after the header line, if any.
5183 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5184 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5185
c07a4c0b 51862012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5187
4ae29f89
SM
5188 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5189 (bug#11238).
ad3a2b41 5190
c07a4c0b 51912012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 51922012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5193
5194 configure: new option --enable-gcc-warnings (Bug#11207)
5195 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5196 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5197 (ALL_CFLAGS): Use new macros rather than old.
5198 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5199 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5200 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5201 -Wunused-result, -Wunused-variable. This should go away once
5202 the Emacs and Gnulib regex code is merged.
5203 (xmalloc, xrealloc): Now static.
5204
aba027e8
PE
52052012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5206
5207 * dired.c (Fsystem_groups): Remove unused local.
5208
e5a36063
GM
52092012-04-17 Glenn Morris <rgm@gnu.org>
5210
5211 * dired.c (Fsystem_users): Doc fix.
5212
316411f0
DA
52132012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5214
5215 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5216 (syms_of_dired): Add them.
5217
9426aba4
PE
52182012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5219
b62a57be
PE
5220 Fix minor alloc.c problems found by static checking.
5221 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5222 New extern decls, to avoid calling undeclared functions.
5223 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5224 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5225 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5226 (NEED_MEM_INSERT): New macro.
5227 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5228 Remove one incorrect comment and fix another.
b62a57be 5229
3539f31f
PE
5230 Fix minor ralloc.c problems found by static checking.
5231 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5232 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5233 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5234 (r_alloc_sbrk): Now static.
5235
a041960a
PE
5236 Improve ralloc.c interface checking.
5237 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5238 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5239 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5240 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5241 [REL_ALLOC]: ... to here, to check interface.
5242 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5243 Remove decls. This fixes an "It stinks!".
5244
9426aba4
PE
5245 * alloc.c (which_symbols): Fix alignment issue / type clash.
5246
d55c12ed
AS
52472012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5248
5249 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5250 (struct Lisp_Misc_Any): Likewise.
5251 (struct Lisp_Free): Likewise.
5252 * alloc.c (union aligned_Lisp_Symbol): Define.
5253 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5254 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5255 (union aligned_Lisp_Misc): Define.
5256 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5257 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5258 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5259
b948ce8b
PE
52602012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5261
5262 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5263 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5264 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5265 * s/netbsd.h, s/sol2-6.h:
5266 Remove definition of GC_MARK_STACK, since the default now works.
5267 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5268 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5269 no longer the default.
5270 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5271
35dc09a1 52722012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5273
35dc09a1
GM
5274 * lread.c (lisp_file_lexically_bound_p):
5275 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5276
35dc09a1
GM
52772012-04-14 Eli Zaretskii <eliz@gnu.org>
5278
5279 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5280 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5281
52822012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5283
5284 * nsterm.m (constrainFrameRect): Always constrain when there is only
5285 one screen (Bug#10962).
5286
bcd86815
KB
52872012-04-13 Ken Brown <kbrown@cornell.edu>
5288
5289 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5290
c25df26e
RT
52912012-04-13 Reuben Thomas <rrt@sc3d.org>
5292
5293 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5294
0fc59f1e
DC
52952012-04-11 Daniel Colascione <dancol@dancol.org>
5296
5297 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5298 against is gone. It's better to use vfork now so that when Cygwin
5299 gains a new, working vfork, we use it automatically (bug#10398).
5300
de8c03dc
SM
53012012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5302
5303 * window.c (save_window_save): Obey window-point-insertion-type.
5304
2f097256
GM
53052012-04-11 Glenn Morris <rgm@gnu.org>
5306
5307 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5308
453b951e
SM
53092012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5310
5311 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5312
75f1671a 53132012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5314
5315 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5316 (force_quit_count): New var.
5317 (handle_interrupt): Use it.
5318
2a8ce227
JB
53192012-04-10 Juanma Barranquero <lekktu@gmail.com>
5320
5321 * w32.c (w32_delayed_load): Record the full path of the library
5322 being loaded (bug#10424).
5323
935396c0
GM
53242012-04-09 Glenn Morris <rgm@gnu.org>
5325
05920a43
GM
5326 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5327 not just in the obarray, before snarfing them. (Bug#11036)
5328
935396c0
GM
5329 * Makefile.in ($(leimdir)/leim-list.el):
5330 Pass EMACS rather than BUILT_EMACS.
5331
a18ecafa
TZ
53322012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5333
5334 * process.c (make_process):
5335 * process.h: Add integer `gnutls_handshakes_tried' member to
5336 process struct.
5337
6bbef4e5
JC
5338 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5339 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5340
5341 * gnutls.c (gnutls_log_function2i): Convenience log function.
5342 (emacs_gnutls_read): Use new log functions,
5343 `gnutls_handshakes_tried' process member, and
5344 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5345 attempts per process (connection).
5346
b4d3bc10
CY
53472012-04-09 Chong Yidong <cyd@gnu.org>
5348
5349 * eval.c (Fuser_variable_p, user_variable_p_eh)
5350 (lisp_indirect_variable): Functions deleted.
5351 (Fdefvar): Caller changed.
5352
5353 * callint.c (Finteractive, Fcall_interactively):
5354 * minibuf.c (Fread_variable): Callers changed.
5355
70f4d973
EZ
53562012-04-09 Eli Zaretskii <eliz@gnu.org>
5357
5358 * xdisp.c (set_cursor_from_row): If the display string appears in
5359 the buffer at position that is closer to point than the position
5360 after the display string, display the cursor on the first glyph of
5361 the display string. Fixes cursor display when a 'display' text
5362 property immediately follows invisible text. (Bug#11094)
5363
cb3c2e3e
PE
53642012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5365
5366 composite.c: use 'double' consistently
5367 * composite.c (get_composition_id): Use 'double' consistently
5368 instead of converting 'float' to 'double' and vice versa; this is
5369 easier to understand and avoids a GCC warning.
5370
fd06db5d
GM
53712012-04-09 Glenn Morris <rgm@gnu.org>
5372
50fe702a
GM
5373 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5374 preparation for dumping it with emacs. (Bug#4789)
5375 (leimdir): New variable.
5376 ($(leimdir)/leim-list.el): New rule.
5377 (emacs$(EXEEXT)): Depend on leim-list.el.
5378
fd06db5d
GM
5379 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5380 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5381 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5382
55c131ee
AS
53832012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5384
5385 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5386 proper alignment.
5387
9209588f
JB
53882012-04-07 Juanma Barranquero <lekktu@gmail.com>
5389
5390 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5391 Remove unused local variable.
5392
e3fb2efb
PE
53932012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5394
5395 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5396 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5397 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5398 objects, as mark_maybe_pointer will catch them otherwise.
5399 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5400 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5401
b5385551
PE
54022012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5403
5404 Fix typo that broke non-Windows builds.
5405 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5406
9078ead6
EZ
54072012-04-07 Eli Zaretskii <eliz@gnu.org>
5408
5409 Support building on MS-Windows with libxml2.
5410
5411 * makefile.w32-in (OBJ2): Add xml.$(O).
5412 (GLOBAL_SOURCES): Add xml.c.
5413 ($(BLD)/xml.$(O)): New dependency list.
5414
5415 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5416 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5417 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5418 [!WINDOWSNT]: New macros.
5419 (init_libxml2_functions, libxml2_loaded_p): New functions.
5420 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5421 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5422 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5423 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5424 linked in).
6bbef4e5
JC
5425 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5426 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5427 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5428
5429 * emacs.c: Don't include libxml/parser.h.
5430 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5431 xmlCleanupParser directly.
5432
5433 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5434
3811fdf3
EZ
54352012-04-07 Eli Zaretskii <eliz@gnu.org>
5436
5437 * indent.c (Fvertical_motion): If there is a display string at
5438 point, use it.vpos to compute how many lines to backtrack after
5439 move_it_to point. (Bug#11133)
5440
2f8e16b2
EZ
54412012-04-06 Eli Zaretskii <eliz@gnu.org>
5442
5443 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5444 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5445 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5446 macros related to unification of CJK characters. For the details,
5447 see the discussion following the message here:
5448 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5449
3d439cd1
CY
54502012-04-04 Chong Yidong <cyd@gnu.org>
5451
5452 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5453
8bc53d00
EZ
54542012-04-01 Eli Zaretskii <eliz@gnu.org>
5455
5456 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5457 instead of alloca. (Bug#11138)
5458
3b0512a3
AS
54592012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5460
5461 * w32menu.c (is_simple_dialog): Properly check lisp types.
5462 (Bug#11141)
5463
8427ddd2
EZ
54642012-03-31 Eli Zaretskii <eliz@gnu.org>
5465
979022ef
EZ
5466 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5467 position we get to after a call to move_it_to fails the
5468 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5469 only if we wind up in a string from display property. (Bug#11063)
5470
a6b1c7cc
EZ
5471 * window.c (Fdelete_other_windows_internal): Invalidate the row
5472 and column information about mouse highlight, so that redisplay
5473 restores it after reallocating the glyph matrices. (Bug#7464)
5474
8427ddd2
EZ
5475 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5476 string comes from a `display' text property, use the buffer
5477 position of that property as if we actually saw that position in
5478 the row's glyphs.
697ba24b
EZ
5479 (move_it_by_lines): Remove the assertion that
5480 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5481 violated when there's a before-string at the beginning of a line.
5482 (Bug#11063)
8427ddd2 5483
65a0a738
EZ
54842012-03-30 Eli Zaretskii <eliz@gnu.org>
5485
5486 * xdisp.c (append_space_for_newline): If the default face was
5487 remapped, use the remapped face for the appended newline.
5488 (extend_face_to_end_of_line): Use the remapped default face for
5489 extending the face to the end of the line.
5490 (display_line): Call extend_face_to_end_of_line when the default
5491 face was remapped. (Bug#11068)
5492
581355cc
EZ
54932012-03-29 Eli Zaretskii <eliz@gnu.org>
5494
5495 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5496
e8fc049f
SM
54972012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5498
5499 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5500
4fb9a543
GM
55012012-03-27 Glenn Morris <rgm@gnu.org>
5502
5503 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5504 Doc fixes.
5505
679910f1
KH
55062012-03-26 Kenichi Handa <handa@m17n.org>
5507
5508 * dispextern.h (struct glyph): Fix previous change. Change the
5509 bit length of glyphless.ch to 25 (Bug#11082).
5510
90d49b7f
CY
55112012-03-26 Chong Yidong <cyd@gnu.org>
5512
5513 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5514 (command_loop_1): Use it; inhibit selection update for
5515 handle-select-window too (Bug#8996).
5516
f514f6f0
FP
55172012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5518
e8fc049f 5519 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5520
bf43fa51
KH
55212012-03-25 Kenichi Handa <handa@m17n.org>
5522
5523 * dispextern.h (struct glyph): Change the bit length of
5524 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5525
8a0c01dd
EZ
55262012-03-24 Eli Zaretskii <eliz@gnu.org>
5527
5528 * s/ms-w32.h (tzname): Include time.h before redirecting to
5529 _tzname. Fixes the MSVC build. (Bug#9960)
5530
7d1c3a76
AS
55312012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5532
8ed79523
AS
5533 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5534 characters.
5535
7d1c3a76
AS
5536 * xterm.c (XTread_socket): Only modify handling_signal if
5537 !SYNC_INPUT. (Bug#11080)
5538
e99a9b8b
EZ
55392012-03-23 Eli Zaretskii <eliz@gnu.org>
5540
5541 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5542 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5543 when fetching a multibyte character consumes more bytes than
5544 CHAR_BYTES returns, due to unification of CJK characters in
5545 string_char. (Bug#11073)
5546
5063c0e1
TN
55472012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5548
5549 * process.c (wait_reading_process_output): Handle pty disconnect
5550 by refraining from sending oneself a SIGCHLD (bug#10933).
5551
9f851fbd
CY
55522012-03-22 Chong Yidong <cyd@gnu.org>
5553
5554 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5555
5063c0e1 5556 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5557 Mark string as coming from a prefix property.
5558 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5559 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5560
fb5b8aca
CY
55612012-03-21 Chong Yidong <cyd@gnu.org>
5562
5563 * xfaces.c (Vface_remapping_alist): Doc fix.
5564
62356a1b
EZ
55652012-03-20 Eli Zaretskii <eliz@gnu.org>
5566
5567 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5568 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5569 Doc fixes.
62356a1b 5570
025de85b
CY
55712012-03-20 Chong Yidong <cyd@gnu.org>
5572
5573 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5574 to reflect default non-nil value of redisplay-dont-pause.
5575
4827f94e
KH
55762012-03-19 Kenichi Handa <handa@m17n.org>
5577
5578 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5579 it fit in a valid range (Bug#11003).
5580
e50a24a2
EZ
55812012-03-18 Eli Zaretskii <eliz@gnu.org>
5582
5583 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5584 that is not from display property, accept the row as a "cursor
5585 row" if one of the string's character has a non-nil `cursor'
5586 property. Fixes cursor positioning when there are newlines in
5587 overlay strings, e.g. in icomplete.el. (Bug#11035)
5588
9af5ed87
PE
55892012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5590
5591 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5592
d1f55f16
CY
55932012-03-12 Chong Yidong <cyd@gnu.org>
5594
5595 * eval.c (inhibit_lisp_code): Rename from
5596 inhibit_window_configuration_change_hook; move from window.c.
5597
5598 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5599 * window.c (run_window_configuration_change_hook)
5600 (syms_of_window): Callers changed.
5601
66c5eebd
CY
56022012-03-11 Chong Yidong <cyd@gnu.org>
5603
413df973
CY
5604 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5605
66c5eebd
CY
5606 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5607
1de11f56
CY
56082012-03-10 Chong Yidong <cyd@gnu.org>
5609
5610 * frame.c (other_visible_frames): Don't assume the selected frame
5611 is visible (Bug#10955).
5612
cae07000
SM
56132012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5614
5615 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5616
89c94350
JD
56172012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5618
5619 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5620 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5621 zero (Bug#10954).
5622
999dd333
GM
56232012-03-03 Glenn Morris <rgm@gnu.org>
5624
01a6dcc8 5625 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5626
de0100f2
EZ
56272012-03-02 Eli Zaretskii <eliz@gnu.org>
5628
5629 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5630 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5631 (redisplay_window, next_element_from_string): Fix typos in
5632 comments.
3e441275
EZ
5633 (redisplay_window): Pass to move_it_vertically the margin in
5634 pixels, not in screen lines.
de0100f2 5635
96a72ee9
GM
56362012-03-02 Glenn Morris <rgm@gnu.org>
5637
5638 * buffer.c (buffer-list-update-hook): Doc fix.
5639
312508d7
EZ
56402012-02-29 Eli Zaretskii <eliz@gnu.org>
5641
5642 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5643 push_it before setting up the iterator for the first overlay
5644 string, even if we have an empty string loaded.
5645 (next_overlay_string): If there's an empty string on the iterator
5646 stack, pop the stack. (Bug#10903)
5647
27f3c637
PE
56482012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5649
5650 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5651 Suggested by Stefan Monnier in
5652 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5653 * alloc.c (widen_to_Lisp_Object): New static function.
5654 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5655 and widening them to Lisp_Objects. This would work even if
5656 USE_LSB_TAG is defined and wide integers are used, which might
5657 happen in a future version of Emacs.
5658
3c9dfce6
CY
56592012-02-25 Chong Yidong <cyd@gnu.org>
5660
fa74b241
CY
5661 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5662 Doc fix.
5663
3c9dfce6
CY
5664 * xselect.c (Fx_selection_exists_p): Doc fix.
5665 (x_clipboard_manager_save_all): Print an informative message
5666 before saving to clipboard manager.
5667
9486df08
CY
56682012-02-24 Chong Yidong <cyd@gnu.org>
5669
5670 * keyboard.c (process_special_events): Handle all X selection
5671 requests in kbd_buffer, not just the next one (Bug#8869).
5672
f01d3321
CY
56732012-02-23 Chong Yidong <cyd@gnu.org>
5674
5675 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5676 call when setting menu-bar-lines and tool-bar-lines parameters.
5677 (unwind_create_frame_1): New helper function.
5678
5679 * window.c (inhibit_window_configuration_change_hook): New var.
5680 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5681 (syms_of_window): Initialize it.
f01d3321 5682
86b847b6
CY
56832012-02-22 Chong Yidong <cyd@gnu.org>
5684
5685 * xterm.c (x_draw_image_relief): Add missing type check for
5686 Vtool_bar_button_margin (Bug#10743).
5687
a59225b1
CY
56882012-02-21 Chong Yidong <cyd@gnu.org>
5689
5690 * fileio.c (Vfile_name_handler_alist): Doc fix.
5691
5692 * buffer.c (Fget_file_buffer): Protect against invalid file
5693 handler return value.
5694
310f5bd4
PE
56952012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5696
cb3a28cc
PE
5697 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5698 when computing $valmask.
5699
310f5bd4
PE
5700 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5701 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5702 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5703 It's useless in that case, and it can cause problems on hosts
5704 that allocate halves of EMACS_INT values separately.
5705 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5706 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5707 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5708 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5709 it avoids undefined behavior on hosts where shifting right by more
5710 than the word width has undefined behavior.
5711
2375c96a
CY
57122012-02-19 Chong Yidong <cyd@gnu.org>
5713
5714 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5715 (Funhandled_file_name_directory, Ffile_name_as_directory)
5716 (Fdirectory_file_name, Fexpand_file_name)
5717 (Fsubstitute_in_file_name): Protect against invalid file handler
5718 return values (Bug#10845).
5719
3eb49e71
EZ
57202012-02-18 Eli Zaretskii <eliz@gnu.org>
5721
5722 * .gdbinit (pitx): Fix incorrect references to fields of the
5723 iterator stack.
5724
7b926f3f
CY
57252012-02-17 Chong Yidong <cyd@gnu.org>
5726
5727 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5728
11273115
PE
57292012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5730
5731 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5732 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5733
c3a70e2b
CY
57342012-02-15 Chong Yidong <cyd@gnu.org>
5735
5736 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5737 marked as special. Also, starting docstrings with * is obsolete.
5738
0ca43699
AS
57392012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5740
5741 * gnutls.c (emacs_gnutls_write): Fix last change.
5742
2e8f3c56
LI
57432012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5744
5745 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5746 send_process.
5747
af70074f
SM
57482012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5749
5750 * keymap.c (Fsingle_key_description): Handle char ranges.
5751
95986d52
CY
57522012-02-12 Chong Yidong <cyd@gnu.org>
5753
afd83bd1
CY
5754 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5755 as that creates a dangerous corner case.
5756
95986d52
CY
5757 * window.c (Fdelete_window_internal): Invalidate the mouse
5758 highlight (Bug#9904).
5759
bd7da63e
GM
57602012-02-12 Glenn Morris <rgm@gnu.org>
5761
5762 * xselect.c (Fx_own_selection_internal)
5763 (Fx_get_selection_internal, Fx_disown_selection_internal)
5764 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5765 * nsselect.m (Fx_own_selection_internal)
5766 (Fx_disown_selection_internal, Fx_selection_exists_p)
5767 (Fx_selection_owner_p, Fx_get_selection_internal):
5768 Sync docs and argument specs with the xselect.c versions.
5769
77abcbc2
LI
57702012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5771
5772 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5773
90b671e2
EZ
57742012-02-11 Eli Zaretskii <eliz@gnu.org>
5775
1c0ca0b7
EZ
5776 * w32select.c (Fx_selection_exists_p): Sync doc string and
5777 argument list with xselect.c. (Bug#10783)
5778
5779 * w16select.c (Fx_selection_exists_p): Sync doc string and
5780 argument list with xselect.c. (Bug#10783)
90b671e2 5781
49241268
GM
57822012-02-10 Glenn Morris <rgm@gnu.org>
5783
5784 * fns.c (Fsecure_hash): Doc fix.
5785
f998bbe7 57862012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5787
5788 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5789
0992bd9c
CY
57902012-02-07 Chong Yidong <cyd@gnu.org>
5791
5792 * buffer.c (Fbuffer_local_variables)
5793 (buffer_lisp_local_variables): Handle unbound vars correctly;
5794 don't let Qunbound leak into Lisp.
5795
af008560
GM
57962012-02-07 Glenn Morris <rgm@gnu.org>
5797
dd605cc4
GM
5798 * image.c (Fimagemagick_types): Doc fix.
5799
af008560
GM
5800 * image.c (imagemagick-render-type): Change it from a lisp object
5801 to an integer. Move the doc here from the lisp manual.
5802 Treat all values not equal to 0 the same.
5803
1449fa1d
CY
58042012-02-06 Chong Yidong <cyd@gnu.org>
5805
5806 * doc.c (store_function_docstring): Avoid applying docstring of
5807 alias to base function (Bug#2603).
5808
3723ec07
AS
58092012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5810
5811 * .gdbinit (pp1, pv1): Remove redundant defines.
5812 (pr): Use pp.
5813
79c1cc1e
CY
58142012-02-04 Chong Yidong <cyd@gnu.org>
5815
5816 * nsterm.m: Declare a global (Bug#10694).
5817
d7f29f8e
EZ
58182012-02-04 Eli Zaretskii <eliz@gnu.org>
5819
cae07000
SM
5820 * w32.c (get_emacs_configuration_options):
5821 Include --enable-checking, if specified, in the return value.
d7f29f8e 5822
3b95a6f9
MR
58232012-02-04 Martin Rudalics <rudalics@gmx.at>
5824
5825 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5826 after rounding frame sizes. (Bug#9723)
5827
d6fa96a6
EZ
58282012-02-04 Eli Zaretskii <eliz@gnu.org>
5829
5830 * keyboard.c (adjust_point_for_property): Don't position point
5831 before BEGV. (Bug#10696)
5832
df0b2940
PE
58332012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5834
5835 Handle overflow when computing char display width (Bug#9496).
5836 * character.c (char_width): Return EMACS_INT, not int.
5837 (char_width, c_string_width): Check for overflow when
5838 computing the width; this is possible now that individual
5839 characters can have unbounded width. Problem introduced
5840 by merge from Emacs 23 on 2012-01-19.
5841
6bee44d6
MA
58422012-02-02 Michael Albinus <michael.albinus@gmx.de>
5843
5844 * dbusbind.c (Fdbus_register_method): Mention the return value
5845 :ignore in the docstring.
5846
44f92739
GM
58472012-02-02 Glenn Morris <rgm@gnu.org>
5848
1b9f60cc
GM
5849 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5850
44f92739
GM
5851 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5852 Unconditionally set to t. (Bug#10673)
5853 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5854 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5855 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5856
c5d3843c
KH
58572012-02-02 Kenichi Handa <handa@m17n.org>
5858
5859 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5860 0, do not call append_composite_glyph.
5861
159462d4 58622012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5863
5864 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5865 NULL (Bug#6988).
5866 (x_produce_glyphs): If the component of a composition is a null
5867 string, set it->pixel_width to 1 to avoid zero-width glyph.
5868
78cef877
EZ
58692012-02-01 Eli Zaretskii <eliz@gnu.org>
5870
5871 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5872 first 2 arguments are identical. This makes inserting large
5873 output from a subprocess an order of magnitude faster on
5874 MS-Windows, where all sbrk'ed memory is always contiguous.
5875
97897668
GM
58762012-01-31 Glenn Morris <rgm@gnu.org>
5877
5878 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5879 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5880 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5881
31fd3586
GM
58822012-01-29 Glenn Morris <rgm@gnu.org>
5883
5884 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5885
0e24a8b2
CY
58862012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5887
5888 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5889
cc0adcb0
CY
58902012-01-28 Chong Yidong <cyd@gnu.org>
5891
5892 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5893
acc28cb9
CY
58942012-01-26 Chong Yidong <cyd@gnu.org>
5895
9c69cfb7
CY
5896 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5897
acc28cb9
CY
5898 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5899 repeat counts (Bug#10507).
5900
48da7392
GM
59012012-01-26 Glenn Morris <rgm@gnu.org>
5902
5903 * lread.c (syms_of_lread): Doc fix.
5904
14af5f7f
CY
59052012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5906
5907 * coding.c (encode_designation_at_bol): Change return value to
5908 EMACS_INT.
5909
0b21c100
CY
59102012-01-25 Chong Yidong <cyd@gnu.org>
5911
5912 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5913
3c2907f7
CY
59142012-01-21 Chong Yidong <cyd@gnu.org>
5915
5916 * floatfns.c (Fcopysign): Make the second argument non-optional,
5917 since nil is not allowed anyway.
5918
959ad23f
AS
59192012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5920
5921 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5922 (send_process): Likewise.
5923
34a02f46
MR
59242012-01-19 Martin Rudalics <rudalics@gmx.at>
5925
5926 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5927 (Vwindow_persistent_parameters): Do not use Qstate.
5928 Rewrite doc-strings.
34a02f46 5929
1259009a 59302012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5931
5932 * character.c (char_width): New function.
70d4fdf6
GM
5933 (Fchar_width, c_string_width, lisp_string_width):
5934 Use char_width (Bug#9496).
25ed9e61 5935
6a6ee00d
MR
59362012-01-16 Martin Rudalics <rudalics@gmx.at>
5937
5938 * window.c (Vwindow_persistent_parameters): New variable.
5939 (Fset_window_configuration, save_window_save): Handle persistent
5940 window parameters.
5941
c85efaf7
EZ
59422012-01-14 Eli Zaretskii <eliz@gnu.org>
5943
5944 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5945 thrashing the stack of the thread. (Bug#9087)
5946
5944709e
PE
59472012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5948
5949 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5950
e71f5d99
EZ
59512012-01-11 Eli Zaretskii <eliz@gnu.org>
5952
5953 * xdisp.c (rows_from_pos_range): Handle the case where the
5954 highlight ends on a newline. (Bug#10464)
5955 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5956 he end column for display of highlight that ends on a newline
5957 before a R2L line.
5958
ce316182
GM
59592012-01-11 Glenn Morris <rgm@gnu.org>
5960
5961 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5962 from load-path also when installation-directory is nil. (Bug#10208)
5963
5b43da69
GM
59642012-01-10 Glenn Morris <rgm@gnu.org>
5965
74cc8ff9
GM
5966 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5967
7d8d6e4e
GM
5968 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5969 Update template values to be closer to their typical values these days.
5b43da69 5970
a0db8d43
EZ
59712012-01-09 Eli Zaretskii <eliz@gnu.org>
5972
5973 * xdisp.c (rows_from_pos_range): Accept additional argument
5974 DISP_STRING, and accept any glyph in a row whose object is that
5975 string as eligible for mouse highlight. Fixes mouse highlight of
5976 display strings from overlays. (Bug#10464)
5977
9a0115ab 59782012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5979
b9110d6a 5980 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5981 * fileio.c (auto_saving_dir_umask): New static var.
5982 (Fmake_directory_internal): Use it.
5983 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5984 creating the directory. The old code temporarily assigns
5985 too-generous permissions to the directory.
5986 (do_auto_save_eh): Clear it.
b9110d6a 5987 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5988 that the var is always cleared.
5989
6c1bd3f3
EZ
59902012-01-07 Eli Zaretskii <eliz@gnu.org>
5991
5992 * search.c (scan_buffer): Pass character positions to
5993 know_region_cache, not byte positions. (Bug#6540)
5994
069d2b50
L
59952012-01-07 LynX <_LynX@bk.ru> (tiny change)
5996
5997 * w32.c (sys_rename): Report EXDEV when rename of a directory
5998 fails because the target is on another logical disk. (Bug#10284)
5999
75bf0d33
DB
60002012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6001
6002 * xterm.c (x_embed_request_focus): New function.
6003
6004 * xterm.h: Add prototype.
6005
6006 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6007
1c6e5a32
GM
60082012-01-05 Glenn Morris <rgm@gnu.org>
6009
6010 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6011
651e947e
EZ
60122012-01-01 Eli Zaretskii <eliz@gnu.org>
6013
6014 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6015 Load gnutls_transport_set_lowat only if GnuTLS version is below
6016 2.11.1.
6017 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6018 GnuTLS versions below 2.11.1.
6019
3778cdd8
AL
60202011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6021
6022 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6023 to the doc string advising against its use for altering the way
6024 windows are scrolled.
6025
0e5317f7
KH
60262011-12-28 Kenichi Handa <handa@m17n.org>
6027
6028 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6029 coding-system ASCII compatible only when it does not produce BOM
6030 on encoding (Bug#10383).
6031
93d5ca1f
JD
60322011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6033
6034 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6035 can scroll.
6036 (create_and_show_popup_menu): Always use menu_position_func for
6037 Gtk3 (Bug#10361).
6038
ca22b785
AS
60392011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6040
6041 * callint.c (Fcall_interactively): Don't truncate prompt string.
6042
d048e1e6
EZ
60432011-12-23 Eli Zaretskii <eliz@gnu.org>
6044
6045 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6046 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6047 resumed from there (after widening). (Bug#10360)
d048e1e6 6048
5ccaba1f
JD
60492011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6050
6051 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6052
204ee57f
JD
60532011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6054
b81d40f0
JB
6055 * nsterm.m (x_free_frame_resources):
6056 Release f->output_data.ns->miniimage.
204ee57f
JD
6057 (ns_index_color): Fix indentation. Do not retain
6058 color_table->colors[i].
6059
6060 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6061 before returning.
6062
6063 * nsfns.m (x_set_background_color): Assign return value from
6064 ns_index_color to face-background instead of NSColor*.
6065 (ns_implicitly_set_icon_type): Fix indentation.
6066 Change assignment in for loop to comparison.
6067
6068 * emacs.c (ns_pool): New variable.
6069 (main): Assign ns_pool.
6070 (Fkill_emacs): Call ns_release_autorelease_pool.
6071
6072 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6073 autorelease fdesc, release fdAttrs and tdict.
6074 (ns_get_covering_families): Release charset.
6075 (ns_findfonts): Release NSFontDescriptor created with new.
6076 (ns_uni_to_glyphs): Fix indentation.
6077 (setString): Release attrStr before assigning new value.
6078
c803b2b7
JD
60792011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6080
678f4426
JD
6081 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6082 and NS_IMPL_COCOA.
6083 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6084 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6085
cd394be1 60862011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6087
5fecd5fc
JD
6088 * nsterm.m (ns_term_init): Subscribe for notifications
6089 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6090 to method trackingNotification in EmacsMenu.
6091
6092 * nsmenu.m (trackingMenu): New variable.
3771cb17 6093 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6094 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6095 from Aquamacs (Bug#7030).
678f4426
JD
6096
60972011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6098
c803b2b7
JD
6099 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6100 (symbol_to_nsstring): Fix indentation.
6101 (ns_symbol_to_pb): New function.
cae07000
SM
6102 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6103 (Fns_rotate_cut_buffers_internal): Remove.
6104 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6105 Fns_store_cut_buffer_internal.
6106 (ns_get_foreign_selection, Fx_own_selection_internal)
6107 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6108 (Fns_get_selection_internal, Fns_store_selection_internal):
6109 Use ns_symbol_to_pb and check if return value is nil.
6110 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6111 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6112 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6113 renamed to Sns_store_selection_internal.
6114 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6115 and remove this function.
6116 (ns_handle_selection_clear): Remove, never used.
6117 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6118 here.
6119
e1b01a3a
KB
61202011-12-17 Ken Brown <kbrown@cornell.edu>
6121
6122 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6123 GID is unknown (Bug#10257).
6124
2adb6e85
PE
61252011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6126
6127 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6128 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6129 which caused a build failure on GNU/Linux IA-64. This problem was
6130 introduced by my 2011-10-07 patch.
6131
d1d7b339
JL
61322011-12-15 Juri Linkov <juri@jurta.org>
6133
6134 * image.c (imagemagick_error): New function. (Bug#10112)
6135 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6136 Use `imagemagick_error' where ImageMagick functions return
6137 `MagickFalse'.
6138 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6139 proper order.
6140
100d5755
KH
61412011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6142
6143 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6144 fill background (Bug#8992).
6145
454592a6
MR
61462011-12-13 Martin Rudalics <rudalics@gmx.at>
6147
6148 * window.c (Vwindow_combination_resize)
6149 (Vwindow_combination_limit): Use t instead of non-nil in
6150 doc-strings.
61d4b438
MR
6151 (Vrecenter_redisplay): Add first sentence of doc-string on
6152 separate line.
53524d93 6153 (Frecenter): Fix doc-string typo.
454592a6 6154
3633e3aa
KH
61552011-12-11 Kenichi Handa <handa@m17n.org>
6156
6157 * coding.c (Funencodable_char_position): Pay attention to the
6158 buffer text relocation (Bug#9389).
6159
7b9d523a 61602011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6161
7b9d523a
JD
6162 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6163 gtk_init (Bug#10100).
6164
b73189c6
EZ
61652011-12-10 Eli Zaretskii <eliz@gnu.org>
6166
6167 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6168 IT->string is nil. (Bug#10263)
6169
f7dfe5d6
JD
61702011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6171
83faebb4
JD
6172 * nsterm.h (x_free_frame_resources): Declare.
6173
f7dfe5d6
JD
6174 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6175 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6176
6177 * nsterm.h (ns_get_defaults_value): Declare.
6178
6179 * nsterm.m (ns_default): Call ns_get_defaults_value.
6180
7cd4e72c
EZ
61812011-12-09 Eli Zaretskii <eliz@gnu.org>
6182
6183 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6184 (Bug#10170)
6185
b34d7317
YM
61862011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6187
6188 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6189 that where the value of an _OBJC_* symbol points to is in the .bss
6190 section (Bug#10240).
6191
76470ad1
KH
61922011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6193
6194 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6195 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6196
745fff94
KH
61972011-12-08 Kenichi Handa <handa@m17n.org>
6198
6199 * ftfont.c (get_adstyle_property): Fix previous change
6200 (Bug#10233).
6201
6e44397c
JB
62022011-12-07 Juanma Barranquero <lekktu@gmail.com>
6203
6204 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6205 dirs from the default value of EMACSLOADPATH (bug#10208).
6206
7efa6272
GM
62072011-12-07 Glenn Morris <rgm@gnu.org>
6208
6209 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6210 installation and source directories as well. (Bug#10208)
6211
f6fc4d87
CY
62122011-12-06 Chong Yidong <cyd@gnu.org>
6213
6214 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6215
2bf26180
GM
62162011-12-06 Glenn Morris <rgm@gnu.org>
6217
6218 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6219 as an error, not just -1. (Bug#10217)
6220
3a6ad4f0
CY
62212011-12-05 Chong Yidong <cyd@gnu.org>
6222
6223 * keyboard.c (process_special_events): New function.
6224 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6225
75a3b399
PE
62262011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6227
6228 * coding.c (encode_designation_at_bol): Don't use uninitialized
6229 local variable (Bug#9318).
6230
c3c9e25e
KH
62312011-12-05 Kenichi Handa <handa@m17n.org>
6232
6233 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6234 return Qnil (Bug#8046, Bug#10193).
6235
5eb05ea3
KH
62362011-12-05 Kenichi Handa <handa@m17n.org>
6237
6238 * coding.c (encode_designation_at_bol): New args charbuf_end and
6239 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6240 (coding_set_source): Return how many bytes coding->source was
6241 relocated.
6242 (coding_set_destination): Return how many bytes
6243 coding->destination was relocated.
6244 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6245 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6246
62472011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6248
6249 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6250 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6251 macro (Bug#9318).
6252
62532011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6254
6255 The following changes are to fix Bug#9318.
6256
a79703f5 6257 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6258 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6259 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6260 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6261
7dbda6df
JB
62622011-12-05 Juanma Barranquero <lekktu@gmail.com>
6263
6264 * lisp.h (process_quit_flag): Fix external declaration.
6265
6d5eb5b0
SM
62662011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6267
6268 Don't macro-inline non-performance-critical code.
6269 * eval.c (process_quit_flag): New function.
6270 * lisp.h (QUIT): Use it.
6271
a0c3fad0
JD
62722011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6273
6274 * nsfns.m (get_geometry_from_preferences): New function.
6275 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6276
6c07aac2
AS
62772011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6278
6279 * emacs.c (Qkill_emacs): Define.
6280 (syms_of_emacs): Initialize it.
6281 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6282 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6283 (quit_throw_to_read_char): Add parameter `from_signal'.
6284 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6285 * lisp.h (QUIT): Call Fkill_emacs if requested.
6286
c052ead4
JD
62872011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6288
6289 * widget.c (update_wm_hints): Return if wmshell is null.
6290 (widget_update_wm_size_hints): New function.
6291
6292 * widget.h (widget_update_wm_size_hints): Declare.
6293
6294 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6295 widget_update_wm_size_hints (Bug#10104).
6296
9e49252b
EZ
62972011-12-03 Eli Zaretskii <eliz@gnu.org>
6298
6299 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6300 before a newline, prepare the bidi iterator for consuming the
6301 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6302 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6303
02b16839
JL
63042011-12-02 Juri Linkov <juri@jurta.org>
6305
6306 * search.c (Fword_search_regexp): New Lisp function created from
6307 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6308 (Fword_search_backward, Fword_search_forward)
6309 (Fword_search_backward_lax, Fword_search_forward_lax):
6310 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6311 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6312
0068070e
SM
63132011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6314
6315 * fileio.c (Finsert_file_contents): Move after-change-function call
6316 to before the "handled:" label, since all "goto handled" appear in
6317 cases where the *-change-functions have already been properly called
6318 (bug#10117).
6319
3360a3fc
AS
63202011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6321
6322 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6323 waiting for input. (Bug#10169)
6324
73d6c093
EZ
63252011-11-30 Eli Zaretskii <eliz@gnu.org>
6326
6327 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6328 verifies glyph row's hash code--we have just reallocated the
6329 glyphs, so their contents can be complete garbage. (Bug#10164)
6330
febe6bea
JB
63312011-11-30 Juanma Barranquero <lekktu@gmail.com>
6332
6333 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6334
801a4313
EZ
63352011-11-30 Eli Zaretskii <eliz@gnu.org>
6336
6337 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6338 attributes are tested _before_ calling verify_row_hash, to protect
6339 against GCC re-ordering of the tests. (Bug#10164)
6340
2b56b87e
JD
63412011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6342
6343 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6344
6345 * xterm.c (handle_one_xevent): Only set async_visible and friends
6346 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6347 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6348 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6349
dbf31225
PE
63502011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6351
6352 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6353 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6354 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6355 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6356 All uses changed to use GCPRO1 etc.
6357 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6358 Revert to old implementation (i.e., before 2011-03-11).
6359
1305621b
YM
63602011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6361
6362 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6363 of scroll runs so as to avoid assigning disabled bogus rows and
6364 unnecessary graphics copy operations.
6365
8c9afb46
EZ
63662011-11-27 Eli Zaretskii <eliz@gnu.org>
6367
6368 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6369 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6370 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6371 (malloc, free, realloc, calloc): Redirect to e_* only when
6372 compiling Emacs.
6373
6374 * lisp.h (GCTYPEBITS): Move before first use.
6375 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6376 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6377 this macro definition.
6378
6379 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6380 _MSC_VER.
6381
54e9e3bf
JD
63822011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6383
6d5eb5b0
SM
6384 * gtkutil.c (xg_create_frame_widgets):
6385 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6386 present with Gtk+ 2.0.
6387
83aca1cb
PE
63882011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6389
6390 * fileio.c (Finsert_file_contents): Undo previous change; see
6391 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6392
5b76caa4
PE
63932011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6394
6395 Rename locals to avoid shadowing.
6396 * fileio.c (Finsert_file_contents):
6397 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6398 * process.c (wait_reading_process_output):
6399 Rename inner 'proc' to 'p' to avoid shadowing.
6400 Indent for consistency with usual Emacs style.
6401
8c535114
EZ
64022011-11-25 Eli Zaretskii <eliz@gnu.org>
6403
6404 * xdisp.c (redisplay_window): If cursor row is not fully visible
6405 after recentering, and scroll-conservatively is set to a large
6406 number, scroll window by a few more lines to make the cursor fully
6407 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6408 (start_display): Don't move to the next line if the display should
6409 start at a newline that is part of a display vector or an overlay
6410 string. (Bug#10119)
8c535114 6411
fa4fdb5c
JL
64122011-11-24 Juri Linkov <juri@jurta.org>
6413
6414 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6415 after the `MagickPingImage' call. (Bug#10112)
6416
90ec88df
CY
64172011-11-23 Chong Yidong <cyd@gnu.org>
6418
6419 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6420
56e2e794
MR
64212011-11-23 Martin Rudalics <rudalics@gmx.at>
6422
6423 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6424 making another buffer current. (Bug#10114)
6425
b6e64c41
GM
64262011-11-23 Glenn Morris <rgm@gnu.org>
6427
6428 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6429
6b21de18
CY
64302011-11-23 Chong Yidong <cyd@gnu.org>
6431
6432 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6433 using it (Bug#5984).
6434
b12cd789
EZ
64352011-11-22 Eli Zaretskii <eliz@gnu.org>
6436
6437 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6438 and header-lines, as they don't have one computed for them.
6439 (Bug#10098)
6440
6441 * .gdbinit (prow): Make displayed values more self-explaining.
6442 Add row's hash code.
6443
261b6fd4
LMI
64442011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6445
6446 * process.c (wait_reading_process_output): Fix asynchrounous
6447 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6448 (wait_reading_process_output): Add comment and URL.
261b6fd4 6449
e7cfd277
JD
64502011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6451
6452 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6453
a9b9b7f5
CY
64542011-11-21 Chong Yidong <cyd@gnu.org>
6455
6456 * window.c (Fnext_window, Fprevious_window): Doc fix.
6457
b0d15b4f
SM
64582011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6459
6460 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6461
fe7a3057
JB
64622011-11-20 Juanma Barranquero <lekktu@gmail.com>
6463
6464 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6465
d2999b1a
MR
64662011-11-20 Martin Rudalics <rudalics@gmx.at>
6467
6468 * window.c (Fset_window_combination_limit): Rename argument
6469 STATUS to LIMIT.
6470 (Vwindow_combination_limit): Remove "status" from doc-string.
6471
d5ff9cd0
AS
64722011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6473
6474 * m/ibms390.h: Remove.
6475 * m/ibms390x.h: Don't include "ibms390.h".
6476
a5bb9bd3
SM
64772011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6478
6479 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6480 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6481
cd1181db
JB
64822011-11-20 Juanma Barranquero <lekktu@gmail.com>
6483
6484 * casetab.c (Fset_case_table):
6485 * charset.c (Fcharset_after): Fix typos.
6486
615a3b8d 64872011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6488
17e845af
PE
6489 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6490 Otherwise, valgrind does not work on some platforms.
6491 Problem reported by Andreas Schwab in
6a0bf43d
PE
6492 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6493 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6494 is set, removing the need for VIRT_ADDRESS_VARIES.
6495 (PURE_P): Use a more-efficient implementation that needs just one
6496 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6497 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6498 to 4 (xorl, subq, cmpq, setbe).
6499 * alloc.c (pure): Always extern now, since that's the
6500 VIRT_ADDR_VARIES behavior.
6501 (PURE_POINTER_P): Use a single comparison, not two, for
6502 consistency with the new puresize.h.
6503 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6504 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6505 Remove VIRT_ADDR_VARIES no longer needed.
6506
f8fe6f96
EZ
65072011-11-19 Eli Zaretskii <eliz@gnu.org>
6508
6509 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6510 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6511 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6512 behave as if the cursor position were at the window margin.
6513
6514 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6515 and the cursor position is out of bounds, behave as if the cursor
6516 position were at the window margin. (Bug#10075)
6517
df05a53c
CY
65182011-11-18 Chong Yidong <cyd@gnu.org>
6519
6520 * window.c (Fwindow_combination_limit): Make first argument
6521 non-optional, since it is meaningless for live windows like the
6522 selected window.
61ccba97 6523
2071918e
DA
65242011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6525
6526 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6527
b50a28de
SM
65282011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6529
6530 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6531 (graft_intervals_into_buffer): Simplify.
6532
015137db
EZ
65332011-11-18 Eli Zaretskii <eliz@gnu.org>
6534
6535 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6536 hash values of the two rows.
6537 (copy_row_except_pointers): Preserve the used[] arrays and the
6538 hash values of the two rows. (Bug#10035)
68c95424 6539 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6540
6541 * xdisp.c (row_hash): New function, body extracted from
6542 compute_line_metrics.
6543 (compute_line_metrics): Call row_hash, instead of computing the
6544 hash code inline.
6545
6546 * dispnew.c (verify_row_hash): Call row_hash for computing the
6547 hash code of a row, instead of duplicating code from xdisp.c.
6548
6549 * dispextern.h (row_hash): Add prototype.
6550
a2addb04
TH
65512011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6552
6553 * frame.c (delete_frame): Don't delete the terminal when the last
6554 X frame is closed if emacs is built with GTK toolkit.
6555
df85d315
JB
65562011-11-17 Juanma Barranquero <lekktu@gmail.com>
6557
6558 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6559
a0c2d0ae
MR
65602011-11-17 Martin Rudalics <rudalics@gmx.at>
6561
6562 * window.c (Vwindow_splits): Rename to
6563 Vwindow_combination_resize. Suggested by Juri Linkov.
6564 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6565 of Vwindow_splits.
6566
58179cce
JB
65672011-11-16 Juanma Barranquero <lekktu@gmail.com>
6568
7877f373
JB
6569 * nsfns.m (Fns_font_name):
6570 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6571
b6f67890
MR
65722011-11-16 Martin Rudalics <rudalics@gmx.at>
6573
6574 * window.h (window): Rename slot "nest" to "combination_limit".
6575 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6576 (Fset_window_nest): Rename to Fset_window_combination_limit.
6577 (Vwindow_nest): Rename to Vwindow_combination_limit.
6578 (recombine_windows, make_parent_window, make_window)
6579 (Fsplit_window_internal, saved_window)
6580 (Fset_window_configuration, save_window_save): Rename all
6581 occurrences of window_nest to window_combination_limit.
6582
c7015153
JB
65832011-11-15 Juanma Barranquero <lekktu@gmail.com>
6584
6585 * image.c (imagemagick_load_image): Fix typo.
6586
322ad6ec
EZ
65872011-11-14 Eli Zaretskii <eliz@gnu.org>
6588
6589 * xdisp.c (display_line): Move the call to
6590 highlight_trailing_whitespace before the call to
6591 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6592 faces of all the glyphs to compute ROW's hash value.
6593 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6594
f067b8ec
JB
65952011-11-14 Juanma Barranquero <lekktu@gmail.com>
6596
6597 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6598 just return (bug#10044).
6599
1e5b2111
EZ
66002011-11-12 Eli Zaretskii <eliz@gnu.org>
6601
7ef3cbd5
EZ
6602 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6603 with user-defined heap size. Bump the default size of the temacs
6604 heap to 27MB, to avoid memory warning when running temacs.
6605 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6606
1e5b2111
EZ
6607 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6608 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6609 (verify_row_hash) [XASSERTS]: New function.
6610 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6611 that the hash value of glyph rows is correct.
1e5b2111 6612
89d61221
MR
66132011-11-12 Martin Rudalics <rudalics@gmx.at>
6614
6615 * window.h (window): Remove splits slot.
6616 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6617 (Fdelete_other_windows_internal, make_parent_window)
6618 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6619 (Fset_window_configuration, save_window_save): Don't deal with
6620 split status of windows.
6621 (saved_window): Remove splits slot.
6622 (Vwindow_splits): Rewrite doc-string.
6623
97f18cc8
JD
66242011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6625
6626 * xfns.c (unwind_create_frame):
6627 * nsfns.m (unwind_create_frame):
6628 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6629 Vframe_list (Bug#9999).
6630
22a648b4
DA
66312011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6632
0b381c7e 6633 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6634
659afede
KH
66352011-11-11 Kenichi Handa <handa@m17n.org>
6636
6637 * callproc.c (Fcall_process): Set the member dst_multibyte of
6638 process_coding.
6639
9ac0394b
KH
66402011-11-11 Johan Bockgård <bojohan@gnu.org>
6641
6642 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6643 avoid a crash (bug#9496).
6644
2fbdc249
CY
66452011-11-09 Chong Yidong <cyd@gnu.org>
6646
6647 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6648 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6649
ac6b1f81
PE
66502011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6651
6652 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6653
09db192c
PE
66542011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6655
6656 Avoid some portability problems by eschewing 'extern inline' functions.
6657 The trivial performance wins aren't worth the portability hassles; see
6658 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6659 et seq.
6660 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6661 (window_box_width, window_box_left, window_box_left_offset)
6662 (window_box_right, window_box_right_offset): Undo previous change,
6663 by removing the "extern"s.
6664 * intervals.c (adjust_intervals_for_insertion)
6665 (adjust_intervals_for_deletion): Undo previous change,
6666 making these static again.
6667 (offset_intervals, temp_set_point_both, temp_set_point)
6668 (copy_intervals_to_string): No longer inline.
6669 * xdisp.c (window_text_bottom_y, window_box_width)
6670 (window_box_height, window_box_left_offset)
6671 (window_box_right_offset, window_box_left, window_box_right)
6672 (window_box): No longer inline.
6673
105216ed
CY
66742011-11-08 Chong Yidong <cyd@gnu.org>
6675
6676 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6677 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6678 Signal an error if not a live window.
105216ed
CY
6679 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6680 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6681
ae9e237f
JB
66822011-11-07 Juanma Barranquero <lekktu@gmail.com>
6683
6684 * lisp.h (syms_of_abbrev): Remove declaration.
6685 Reported by CHENG Gao <chenggao@royau.me>.
6686
c7aa8333
EZ
66872011-11-07 Eli Zaretskii <eliz@gnu.org>
6688
6689 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6690 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6691 of temacs in GUI mode.
6692
be7f5545
MR
66932011-11-07 Martin Rudalics <rudalics@gmx.at>
6694
6695 * window.h: Declare delete_all_child_windows instead of
6696 delete_all_subwindows.
6697 * window.c (Fwindow_nest, Fset_window_nest)
6698 (Fset_window_new_total, Fset_window_new_normal)
6699 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6700 (delete_all_subwindows): Rename to delete_all_child_windows.
6701 (Fdelete_other_windows_internal, Fset_window_configuration):
6702 Call delete_all_child_windows instead of delete_all_subwindows.
6703 * frame.c (delete_frame): Call delete_all_child_windows instead
6704 of delete_all_subwindows.
6705
ca78dc43
PE
67062011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6707
6708 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6709 This is also needed for porting to any host where GC_MARK_STACK is
6710 not GC_MAKE_GCPROS_NOOPS.
6711 (which_symbols): Use it.
6712
a0241d01
KH
67132011-11-07 Kenichi Handa <handa@m17n.org>
6714
6715 * coding.c (coding_set_destination): Check coding->src_pos only
6716 when coding->src_object is a buffer (bug#9910).
6717
6718 * process.c (send_process): Set the member src_multibyte of coding
6719 to 0 (bug#9911) when sending a unibyte text.
6720
6721 * callproc.c (Fcall_process): Set the member src_multibyte of
6722 process_coding to 0 (bug#9912).
6723
a64bfdfa 67242011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6725
6726 * xmenu.c (cleanup_widget_value_tree): New function.
6727 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6728 calling free_menubar_widget_value_tree directly (Bug#9830).
6729
cb41b32a
PE
67302011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6731
6732 Fix some portability problems with 'inline'.
6733 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6734 (window_box_width, window_box_left, window_box_left_offset)
6735 (window_box_right, window_box_right_offset): Declare extern.
6736 Otherwise, these inline functions do not conform to C99 and
6737 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6738 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6739 * intervals.c (adjust_intervals_for_insertion)
6740 (adjust_intervals_for_deletion): Now extern, because otherwise the
6741 extern inline functions 'offset_intervals' couldn't refer to it.
6742 (static_offset_intervals): Remove.
6743 (offset_intervals): Rewrite using the old contents of
6744 static_offset_intervals. The old version didn't conform to C99
6745 because an extern inline function contained a reference to an
6746 identifier with static linkage.
6747
b7041366
AS
67482011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6749
6750 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6751 GC.
6752
88a37c4d
EZ
67532011-11-06 Eli Zaretskii <eliz@gnu.org>
6754
6755 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6756 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6757 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6758 return Qleft_to_right.
6759
49745b39
CY
67602011-11-06 Chong Yidong <cyd@gnu.org>
6761
6762 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6763 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6764 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6765 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6766 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6767 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6768 (Fwindow_vscroll): Doc fix.
6769 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6770 argument, since it makes no sense to pass a live window and for
6771 consistency with window-child.
6772
1f05cd82
CS
67732011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6774
6775 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6776 support MSVC.
6777
22610910
JR
67782011-11-05 Jason Rumney <jasonr@gnu.org>
6779
6780 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6781 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6782 fonts (Bug#6029).
6783 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6784 bitwise arithmetic preventing use of unicode-sip and non-truetype
6785 opentype fonts.
6786
a06776b2
EZ
67872011-11-05 Eli Zaretskii <eliz@gnu.org>
6788
3ad924ba
EZ
6789 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6790 "emacs"-only part.
6791
a06776b2
EZ
6792 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6793 initialization code to keep similarity to xfns.c after changes
6794 from 2011-11-05.
6795
c9e7db78
JD
67962011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6797
a97f8f3f
JD
6798 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6799 (unwind_create_frame): New function (Bug#9943).
6800 (Fx_create_frame): Restructure code to be more similar to the one in
6801 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6802 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6803 Move terminal->reference_count++ just before making the frame official
6804 (Bug#9943).
6805
6806 * nsterm.m (x_free_frame_resources): New function.
6807 (x_destroy_window): Move code to x_free_frame_resources.
6808
c9e7db78 6809 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6810 (Fx_create_frame, x_create_tip_frame):
6811 Move terminal->reference_count++ just before making the frame
75f1671a 6812 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6813 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6814
a6fc3b5c
EZ
68152011-11-05 Eli Zaretskii <eliz@gnu.org>
6816
6817 Support MSVC build with newer versions of Visual Studio.
6818 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6819 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6820 nt/gmake.defs.
6821
6822 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6823 which are not supported by MSVC.
6824 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6825 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6826 bitfields.
6827 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6828 types in bitfields.
6829 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6830
6831 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6832
58179cce 68332011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6834
6835 Support MSVC build with newer versions of Visual Studio.
6836 * w32.c: Don't include w32api.h for MSVC.
6837 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6838
6839 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6840 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6841 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6842 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6843 e_* cousins.
6844 (alloca) [_MSC_VER]: Define to _alloca.
6845
6846 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6847
6848 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6849
a58c13ed
EZ
68502011-11-04 Eli Zaretskii <eliz@gnu.org>
6851
6852 * xdisp.c (note_mouse_highlight): If either of
6853 previous/next-single-property-change returns nil, treat that as
6854 the beginning or the end of the buffer. (Bug#9955)
6855
fe0b6370
JD
68562011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6857
a58c13ed 6858 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6859 label is not null (Bug#9951).
6860 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6861 may be NULL.
6862
89bd5ee1
EZ
68632011-11-04 Eli Zaretskii <eliz@gnu.org>
6864
6865 * window.c (Fwindow_body_size): Mention in the doc string that the
6866 return value is in frame's canonical units. (Bug#9949)
6867
84c3edb9
EZ
68682011-11-03 Eli Zaretskii <eliz@gnu.org>
6869
4e2fb5c7
EZ
6870 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6871
84c3edb9 6872 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6873 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6874 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6875
bc17a887
EZ
68762011-11-01 Eli Zaretskii <eliz@gnu.org>
6877
6878 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6879 Don't stop backward scan on the continuation glyph, even though
6880 its CHARPOS is positive.
6d5eb5b0
SM
6881 (mouse_face_from_buffer_pos, note_mouse_highlight):
6882 Rename cover_string to disp_string.
bc17a887 6883
4ee88440
MR
68842011-11-01 Martin Rudalics <rudalics@gmx.at>
6885
6886 * window.c (temp_output_buffer_show): Don't use
6887 Vtemp_buffer_show_specifiers.
6888 (Vtemp_buffer_show_specifiers): Remove unused variable.
6889
c2ff3c02
EZ
68902011-10-30 Eli Zaretskii <eliz@gnu.org>
6891
6892 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6893 past the beginning of the current glyph matrix.
6894
58179cce 68952011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6896
6897 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6898 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6899 HAVE_GTK3 (Bug#9869).
b77a6a7f 6900
3b574623
JD
6901 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6902 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6903
b77a6a7f
JD
6904 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6905
6906 * xterm.c: Declare x_handle_net_wm_state to return int.
6907 (handle_one_xevent): Check if we are iconified but don't have
6908 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6909 (get_current_wm_state): Return non-zero if not hidden,
6910 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6911 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6912 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6913 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6914
196e41e4
PE
69152011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6916
6917 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6918 so that this new function doesn't get optimized away by a
6919 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6920
021f2e1a
AS
69212011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6922
6923 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6924
8b058d44
EZ
69252011-10-29 Eli Zaretskii <eliz@gnu.org>
6926
6927 Fix the `xbytecode' command.
6928 * .gdbinit (xprintbytestr): New command.
b50a28de 6929 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6930 (xbytecode): Print the byte-code string as well.
6931
4452fb80
EZ
69322011-10-29 Kim Storm <storm@cua.dk>
6933
8b058d44
EZ
6934 * alloc.c (which_symbols): New function.
6935
21b72067
AS
69362011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6937
6938 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6939 line. (Bug#9903)
6940
83ed7b5c
GM
69412011-10-29 Glenn Morris <rgm@gnu.org>
6942
6943 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6944 Not clear what it was for, and it causes various bugs. (Bug#9839)
6945
5a7a728b
EZ
69462011-10-28 Eli Zaretskii <eliz@gnu.org>
6947
6948 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6949 possible random value that matches one of those tested as
6950 condition to clear the mouse face.
6951
d3d0842f
CY
69522011-10-28 Chong Yidong <cyd@gnu.org>
6953
6954 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6955
31b39d13
DN
69562011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6957
6958 * window.c (make_window): Initialize phys_cursor_on_p.
6959
9aba6043
SM
69602011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6961
6962 * lisp.h (struct Lisp_Symbol): Update comments.
6963
c20992f4
JB
69642011-10-28 Juanma Barranquero <lekktu@gmail.com>
6965
6966 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6967
db4f02f2
EZ
69682011-10-28 Eli Zaretskii <eliz@gnu.org>
6969
6970 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6971 <oslsachem@gmail.com> for helping to debug this.
6972
6973 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6974 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6975 (g_b_init_get_glyph_outline_w): New static variables.
6976 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6977 (GetGlyphOutlineW_Proc): New typedefs.
6978 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6979 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6980 New functions.
6981 (w32font_open_internal, compute_metrics):
6982 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6983 instead of calling the "wide" APIs directly.
6984
6985 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6986
6987 * w32.h (syms_of_w32font): Add prototype.
6988
87e68db4
JB
69892011-10-27 Juanma Barranquero <lekktu@gmail.com>
6990
6991 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6992 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6993 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6994 (Fmove_to_window_line): Doc fix.
6995
435c1d67
CY
69962011-10-27 Chong Yidong <cyd@gnu.org>
6997
6998 * process.c (make_process): Set gnutls_state to NULL.
6999
7000 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7001 non-NULL, regardless of GNUTLS_INITSTAGE.
7002 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7003 an error. Set process slots as soon as we allocate them.
7004
7005 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7006
9c6c6f49
CY
70072011-10-27 Chong Yidong <cyd@gnu.org>
7008
9aba6043
SM
7009 * gnutls.c (emacs_gnutls_deinit): New function.
7010 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7011 (Fgnutls_deinit, Fgnutls_boot): Use it.
7012
7013 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7014 (deactivate_process): Call emacs_gnutls_deinit.
7015
657d08d3
JB
70162011-10-27 Juanma Barranquero <lekktu@gmail.com>
7017
7018 * image.c (x_create_x_image_and_pixmap):
7019 * w32.c (sys_rename, w32_delayed_load):
7020 * w32font.c (fill_in_logfont):
7021 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7022
5430d399
JB
70232011-10-26 Juanma Barranquero <lekktu@gmail.com>
7024
7025 * w32fns.c (w32_default_color_map): New function,
7026 extracted from Fw32_default_color_map.
a7ef684b 7027 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7028
fe0055fa
PE
70292011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7030
7031 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7032
e6346438
SM
70332011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7034
7035 * keyboard.c (test_undefined): New function (bug#9751).
7036 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7037
e112cc37
ET
70382011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7039
7040 * sysdep.c (init_sys_modes): Fix the check for the controlling
7041 terminal (Bug#6649).
7042
7b5d6677
EZ
70432011-10-20 Eli Zaretskii <eliz@gnu.org>
7044
7045 * dispextern.h (struct bidi_it): New member next_en_type.
7046
7047 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7048 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7049 current character, check also for next_en_type being WEAK_EN.
7050 (bidi_resolve_weak): Don't enter the expensive loop if the current
7051 position is before next_en_pos. Record the bidi type of the first
7052 non-ET, non-BN character we find, in addition to its position.
7053 (bidi_level_of_next_char): Invalidate next_en_type when
7054 next_en_pos is over-stepped.
7055
7da0b018
PE
70562011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7057
7058 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7059 * editfns.c: Rewrite current-time-zone so that it invokes
7060 the equivalent of (format-time-string "%Z") to get the time zone name.
7061 This fixes a bug when the time zone name contains characters that
7062 need converting from the system time locale to Emacs internal format.
7063 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7064 that patch fixed format-time-string to do the conversion, but
7065 I forgot to fix current-time-zone.
7066 (format_time_string): New function, containing most of
7067 what Fformat_time_string used to contain.
7068 (Fformat_time_string): Rewrite in terms of format_time_string.
7069 This doesn't change this function's behavior.
7070 (current-time-zone): Rewrite to use format_time_string.
7071 This fixes the bug reported by Michael Schierl in
7072 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7073 Jason Rumney's 2007-06-07 change worked around this bug, but
7074 didn't fix it.
7075 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7076
8547b010
EZ
70772011-10-19 Eli Zaretskii <eliz@gnu.org>
7078
7079 * xdisp.c (start_display): If the character at POS is displayed
7080 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7081 (try_window_reusing_current_matrix): If a line ends in a display
7082 vector or the next line starts in a display vector, continue
7083 redrawing the window even though the character position of
7084 start_row was reached.
8547b010
EZ
7085 (Bug#9771, part 2)
7086
4e948d15
CY
70872011-10-18 Chong Yidong <cyd@gnu.org>
7088
7089 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7090 with nobreak-char-display too.
7091
4787455f
EZ
70922011-10-18 Eli Zaretskii <eliz@gnu.org>
7093
7094 Fix part 3 of bug#9771.
7095 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7096 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7097 non-neutral characters if the current character is a paragraph
7098 separator (a.k.a. Newline). This avoids running the same
7099 expensive loop twice, once when we consume the preceding newline
7100 and the other time when the line actually needs to be displayed.
7101 Avoid the loop when we see neutrals on the base embedding level
7102 following a character whose directionality is the same as the
7103 paragraph's. This avoids running the expensive loop when a line
7104 ends in a long sequence of neutrals, like control characters.
7105 Add assertion against STRONG_AL type. Slightly rearrange code
7106 that determines the type of a neutral given the first non-neutral
7107 that follows it.
7108 (bidi_level_of_next_char): Set next_en_pos to zero when
7109 invalidating its info.
7110
2c91f553
EZ
71112011-10-17 Eli Zaretskii <eliz@gnu.org>
7112
7113 * xdisp.c (push_display_prop): Determine whether to record string
7114 or buffer position by IT->string, not by IT->method. Allow
7115 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7116 (move_it_vertically_backward): Don't look for character position
7117 immediately after the newline when in a continuation line.
7118 (Bug#9771, part 1)
2c91f553 7119
c7b08b0d
MR
71202011-10-15 Martin Rudalics <rudalics@gmx.at>
7121
7122 * window.c (coordinates_in_window): Rewrite and delabelize
7123 vertical border check. (Bug#5357) (Bug#9618)
7124
6b02f655
SM
71252011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7126
7127 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7128 errors in XSetWindowBorder (bug#9310).
7129
81d40c92
DA
71302011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7131
7132 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7133 avoid crash when xmalloc overrun checking is enabled.
7134
d4172c3b
EZ
71352011-10-13 Eli Zaretskii <eliz@gnu.org>
7136
7137 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7138 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7139 cursor motion with <left> and <right> arrow keys.
7140
7141 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7142 some callers set that themselves.
7143
b00eea75
EZ
71442011-10-12 Eli Zaretskii <eliz@gnu.org>
7145
7146 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7147 display string and the previous row comes from the same string and
7148 is empty. (Bug#9739) (Bug#9738)
7149
8fe012c4
SM
71502011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7151
7152 * doc.c (get_doc_string): Encode file name (bug#9735).
7153
0074aef2
EZ
71542011-10-12 Eli Zaretskii <eliz@gnu.org>
7155
79beb178
EZ
7156 * bidi.c (bidi_level_of_next_char):
7157 * xdisp.c (get_visually_first_element): Remove old incorrect
7158 comments regarding the Unicode Line Separator character.
7159
0074aef2
EZ
7160 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7161
6e4b3fbe
DA
71622011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7163
7164 * alloc.c (Fgc_status): Do not access beyond zombies array
7165 boundary if nzombies > MAX_ZOMBIES.
7166 * alloc.c (dump_zombies): Add missing format specifier.
7167
0324f3af
PE
71682011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7169
b5525cac
PE
7170 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7171 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7172
0324f3af
PE
7173 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7174 Some packages use them to denote characters with modifiers.
7175
e9b5f888
AS
71762011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7177
7178 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7179 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7180 matching a pp-number. Rename parameter var to var1.
7181
127827c0
SM
71822011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7183
7184 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7185
c8fd3bd0
GM
71862011-10-08 Glenn Morris <rgm@gnu.org>
7187
7188 * callint.c (Fcall_interactively): Give a more explicit error for the
7189 'c' case with a non-character input. (Bug#8479)
7190
352ec8ff
EZ
71912011-10-08 Eli Zaretskii <eliz@gnu.org>
7192
03669ccb
EZ
7193 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7194 lines.
7061c986
EZ
7195 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7196 lines that are hscrolled on the left.
03669ccb 7197
352ec8ff
EZ
7198 * dispnew.c (buffer_posn_from_coords): Account for a possible
7199 presence of header-line. (Bug#4426)
7200
a66cfb1c
SM
72012011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7202
6b02f655
SM
7203 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7204 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7205
7c5ee88e
PE
72062011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7207
7208 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7209 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7210 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7211 this makes Emacs dump core during garbage collection on rare
7212 occasions. sizeof is obviously inferior to offsetof here, so
7213 stick with offsetof.
7214 (GC_POINTER_ALIGNMENT): New macro.
7215 (mark_memory): Omit 3rd (offset) arg; caller changed.
7216 Don't assume EMACS_INT alignment is the same as pointer alignment.
7217
df1bbe5b
SM
72182011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7219
7220 * keyboard.c (read_key_sequence_remapped): New var.
7221 (read_key_sequence): Compute remapping in the right buffer.
7222 (command_loop_1): Use read_key_sequence's remapping directly.
7223
51553db6
SM
72242011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7225
32c1fffd
SM
7226 * dired.c (file_name_completion): Don't expand file name.
7227 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7228 before checking file name handler.
7229
51553db6
SM
7230 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7231 they've been requested explicitly (bug#9591).
7232
b6bd1599 72332011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7234
7235 * keymap.c (Fsingle_key_description): Use make_specified_string
7236 instead of build_string to build string from push_key_description.
7237 (Bug#5193)
7238
f701dc2a
PE
72392011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7240
4222c55d
PE
7241 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7242 This fixes a Y2038 bug on 64-bit hosts.
7243 * buffer.c (reset_buffer):
7244 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7245 (Fclear_buffer_auto_save_failure):
7246 Use 0, not -1, to represent an unset failure time, since time_t
7247 might not be signed.
7248
f701dc2a
PE
7249 Remove dependency on glibc malloc internals.
7250 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7251 Move back here from lisp.h, but with their new implementations.
7252 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7253 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7254 * charset.c (charset_table_init): New static var.
7255 (syms_of_charset): Use it instead of xmalloc. This removes a
7256 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7257 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7258 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7259 Move back to alloc.c.
7260 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7261 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7262
9ceebf39
JD
72632011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7264
7265 * nsterm.m (windowDidResize): Call x_set_window_size only when
7266 ns_in_resize is true. Otherwise set pixelwidth/height and
7267 call change_frame_size (Bug#9628).
7268
cb993c58
PE
72692011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7270
3930c88b
PE
7271 Port --enable-checking=all to Fedora 14 x86-64.
7272 * charset.c (syms_of_charset): Also account for glibc malloc's
7273 internal overhead when calculating the initial malloc maximum.
7274
cb993c58
PE
7275 Port --enable-checking=all to Fedora 14 x86.
7276 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7277 Move to lisp.h.
7278 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7279 (overrun_check_realloc, overrun_check_free):
7280 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7281 That way, xmalloc returns a properly-aligned pointer even if
7282 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7283 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7284 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7285 into account when calculating the initial malloc maximum.
7286 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7287 Move here from alloc.c, so that charset.c can use it too.
7288 Properly align; the old code wasn't right for common 32-bit hosts
7289 when configured with --enable-checking=all.
7290 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7291 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7292
31bed486
EZ
72932011-09-29 Eli Zaretskii <eliz@gnu.org>
7294
04c70788 7295 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7296 use EDOM.
7297
fbcaa2f3
EZ
72982011-09-28 Eli Zaretskii <eliz@gnu.org>
7299
7300 * xdisp.c (compute_display_string_end): If there's no display
7301 string at CHARPOS, return -1.
7302
7303 * bidi.c (bidi_fetch_char): When compute_display_string_end
7304 returns a negative value, treat the character as a normal
7305 character not covered by a display string. (Bug#9624)
7306
a239d4e9
JB
73072011-09-28 Juanma Barranquero <lekktu@gmail.com>
7308
7309 * lread.c (Fread_from_string): Fix typo in docstring.
7310
88652fd5
EZ
73112011-09-27 Eli Zaretskii <eliz@gnu.org>
7312
7313 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7314 newline, reseat the iterator instead of bidi-iterating there one
7315 character at a time. (Bug#9610)
32c1fffd
SM
7316 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7317 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7318
ed497dd4
AS
73192011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7320
7321 * lread.c (readevalloop): Use correct code for NBSP.
7322 (read1): Likewise. (Bug#9608)
7323
b2bf61aa
MA
73242011-09-25 Michael Albinus <michael.albinus@gmx.de>
7325
7326 * dbusbind.c (Fdbus_register_signal): When service is not
7327 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7328
32bbb17c
GM
73292011-09-25 Glenn Morris <rgm@gnu.org>
7330
7331 * buffer.c (truncate-lines): Doc fix.
7332
94e0933e
CY
73332011-09-24 Chong Yidong <cyd@stupidchicken.com>
7334
7335 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7336 (Fset_window_next_buffers): Doc fix.
7337
cddde921
GM
73382011-09-24 Glenn Morris <rgm@gnu.org>
7339
7340 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7341
1260aef1
PE
73422011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7343
25b4bfa0
PE
7344 Fix minor problems found by static checking.
7345 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7346 * indent.c (Fvertical_motion): Fix == vs = typo.
7347
e3cbd34b
EZ
73482011-09-24 Eli Zaretskii <eliz@gnu.org>
7349
a66cfb1c
SM
7350 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7351 Default value is now t. Doc fix.
6bf7006f 7352
e3cbd34b 7353 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7354 logic when moving up, not only when moving down. Fix the
e3cbd34b 7355 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7356 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7357
7358 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7359 CHARPOS is covered by a display string which includes newlines.
7360 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7361 is covered by a display string with embedded newlines.
7362
a3de0cbd
MA
73632011-09-24 Michael Albinus <michael.albinus@gmx.de>
7364
7365 * dbusbind.c (Fdbus_register_signal): Add match rule to
7366 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7367 (Fdbus_register_method, Vdbus_registered_objects_table):
7368 Fix docstring.
a3de0cbd 7369
b260039d
JM
73702011-09-24 Jim Meyering <meyering@redhat.com>
7371
32c1fffd 7372 do not ignore write error for any output size
b260039d
JM
7373 The previous change was incomplete.
7374 While it makes emacs --batch detect the vast majority of stdout
7375 write failures, errors were still ignored whenever the output size is
7376 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7377 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7378 && echo FAIL: ignored write error
7379 FAIL: ignored write error
7380 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7381 && echo FAIL: ignored write error
7382 FAIL: ignored write error
7383 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7384
8eca8a7c
AS
73852011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7386
7387 * emacs.c (Fkill_emacs): In noninteractive mode exit
7388 non-successfully if a write error occurred on stdout. (Bug#9574)
7389
3341db62
EZ
73902011-09-21 Eli Zaretskii <eliz@gnu.org>
7391
7392 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7393 the xassert test.
7394
7395 * dispextern.h (struct it): Update the comment documenting what
7396 can it->OBJECT be.
7397
8c203dbf
EZ
73982011-09-20 Eli Zaretskii <eliz@gnu.org>
7399
7400 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7401 a display string, extend search for cursor position to end of row.
7402 (find_row_edges): If the row ends in a newline from a display
7403 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7404 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7405 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7406 non-empty line. Fixes confusing cursor motion with arrow keys at
7407 the beginning of a line that starts with whitespace.
8c203dbf 7408
a4824228
LMI
74092011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7410
7411 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7412 (bug#9493).
7413
33ed493b
CY
74142011-09-18 Chong Yidong <cyd@stupidchicken.com>
7415
7416 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7417 boolean (Bug#9154).
7418
56cd55c8
EZ
74192011-09-18 Eli Zaretskii <eliz@gnu.org>
7420
7421 * xdisp.c (display_line): Record maximum and minimum buffer
7422 positions even if no glyphs were produced (e.g., by a zero-width
7423 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7424 buffer positions that will be removed from the glyph row because
7425 they don't fit.
c02dcedf
EZ
7426 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7427 column is beyond frame width: don't subtract 1 "pixel" when
7428 computing width of the stretch.
3e62b7e0
EZ
7429 (reseat_at_next_visible_line_start): Undo the change made on
7430 2011-09-17 that saved paragraph information and restored it after
7431 the call to `reseat'. (Bug#9545)
56cd55c8 7432
5ed99d36 74332011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7434
7435 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7436 and turn window cursor on if cleared (Bug#9415).
7437
5ed99d36 74382011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7439
7440 * search.c (boyer_moore): Take unibyte characters from pattern
7441 literally. (Bug#9458)
7442
9bade7b2
EZ
74432011-09-18 Eli Zaretskii <eliz@gnu.org>
7444
7445 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7446
e5e9d610
PE
74472011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7448
87e4427a
PE
7449 Fix minor problem found by static checking.
7450 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7451 initialized, to pacify gcc -Wuninitialized.
7452
e5e9d610
PE
7453 * fileio.c: Report proper errno when syscall falls.
7454 (Finsert_file_contents): Save and restore errno,
7455 so that report_file_error outputs the correct diagnostic.
7456 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7457
a1674f0b
EZ
74582011-09-18 Eli Zaretskii <eliz@gnu.org>
7459
7460 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7461
fbfb6dd4
EZ
74622011-09-17 Eli Zaretskii <eliz@gnu.org>
7463
7464 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7465 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7466
bb187662
EZ
74672011-09-17 Eli Zaretskii <eliz@gnu.org>
7468
1137e8b8 7469 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7470 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7471
7472 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7473 (bidi_find_paragraph_start): Search back for paragraph beginning
7474 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7475 (bidi_move_to_visually_next): Only trigger paragraph-related
7476 computations when the last character is a newline or at EOB, not
7477 just any NEUTRAL_B. (Bug#9470)
7478
bb187662
EZ
7479 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7480 truncated lines if point is covered by a display string. (Bug#9524)
7481
2e621251
PE
74822011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7483
7484 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7485 (cons_to_x_long): New function.
7486 (lisp_data_to_selection_data): Use it. Correct the test for
7487 short-versus-long data; it was negated. Break out of vector
7488 loop, for efficiency, when a long datum is discovered.
7489
91a15bc6
SM
74902011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7491
7492 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7493
b41c3a35
EZ
74942011-09-16 Eli Zaretskii <eliz@gnu.org>
7495
7496 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7497 GCC PR/17406) by declaring this function with external scope.
7498
7812ba2d
PE
74992011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7500
7501 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7502 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7503
cf7edc2a
AS
75042011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7505
7506 * editfns.c (Fformat): Correctly handle text properties on "%%".
7507
bd01620e
EZ
75082011-09-15 Eli Zaretskii <eliz@gnu.org>
7509
7510 * xterm.c (x_draw_composite_glyph_string_foreground):
7511 * w32term.c (x_draw_composite_glyph_string_foreground):
7512 * term.c (encode_terminal_code):
7513 * composite.c (composition_update_it, get_composition_id):
7514 * xdisp.c (get_next_display_element)
7515 (fill_composite_glyph_string): Add comments about special meaning
7516 of TAB characters in a composition.
7517
a02719a3
PE
75182011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7519
7520 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7521 This occurs when processing a multibyte format.
7522 Problem reported by Wolfgang Jenker.
a02719a3 7523
72589a3c
JB
75242011-09-15 Johan Bockgård <bojohan@gnu.org>
7525
7526 * xdisp.c (try_cursor_movement): Only check for exact match if
7527 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7528
1c14176c
PE
75292011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7530
7531 Remove unused external symbols.
7532 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7533 * xdisp.c (calc_pixel_width_or_height): Now static.
7534 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7535 * indent.c (check_display_width):
7536 * w32term.c: Fix comment to match code.
7537 * xterm.c, xterm.h (x_catching_errors): Remove.
7538
d2eea5b5
PE
75392011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7540
7541 * xselect.c: Use signed conversions more consistently (Bug#9498).
7542 (selection_data_to_lisp_data): Assume incoming selection data are
7543 signed integers, not unsigned. This is to be consistent with
7544 outgoing selection data, which was modified to use signed integers
7545 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7546 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7547 expects long, not unsigned long.
7548
46888499
EZ
75492011-09-14 Eli Zaretskii <eliz@gnu.org>
7550
7551 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7552 computation of loop end. Reported by Johan Bockgård
7553 <bojohan@gnu.org>.
7554
ef8ef9fb
CY
75552011-09-13 Chong Yidong <cyd@stupidchicken.com>
7556
7557 * frame.c (Fother_visible_frames_p): Function deleted.
7558
fa819fed
EZ
75592011-09-12 Eli Zaretskii <eliz@gnu.org>
7560
7561 * indent.c (compute_motion): Process display vector front to back
7562 rather than the other way around. (Bug#2496)
7563
2ba8e008
SM
75642011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7565
7566 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7567
20f53c69
CY
75682011-09-11 Chong Yidong <cyd@stupidchicken.com>
7569
7570 * minibuf.c (Fread_from_minibuffer): Doc fix.
7571
d562d7a4
EZ
75722011-09-11 Eli Zaretskii <eliz@gnu.org>
7573
7574 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7575 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7576
1c4d7f3d
LMI
75772011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7578
7579 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7580 value for non-existent files.
7581
b885bf36
EZ
75822011-09-11 Eli Zaretskii <eliz@gnu.org>
7583
7584 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7585 set its "size" to -1. This will set the modtime_size field of
7586 the corresponding buffer to -1, which is what
7587 verify-visited-file-modtime expects for files that do not exist.
7588 (Bug#9139)
7589
6612f0bf
PE
75902011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7591
7592 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7593 here ...
7594 * lisp.h: ... from here. push_key_description is no longer
7595 defined in keyboard.c, so its declaration should not be in
7596 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7597 logically belongs with push_key_description.
7598
dfb3f755
PE
75992011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7600
7601 * buffer.h: Include <sys/types.h> instead of <time.h>.
7602 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7603 Problem reported by Herbert J. Skuhra.
7604
3134906c
LMI
76052011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7606
7607 * xml.c (parse_region): Make the parsing work for
7608 non-comment-starting XML files again (bug#9144).
7609
8d903f4e
AS
76102011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7611
7612 * image.c (gif_load): Fix calculation of bottom and right corner.
7613 (Bug#9468)
7614
80ad64f4
EZ
76152011-09-10 Eli Zaretskii <eliz@gnu.org>
7616
7617 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7618 redisplay in small windows.
7619
208a048d
EZ
76202011-09-09 Eli Zaretskii <eliz@gnu.org>
7621
7622 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7623
9b1c252e
MR
76242011-09-08 Martin Rudalics <rudalics@gmx.at>
7625
7626 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7627 Operate on live windows only.
7628
2949f33b
JB
76292011-09-08 Juanma Barranquero <lekktu@gmail.com>
7630
7631 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7632
e08dcafd
EZ
76332011-09-07 Eli Zaretskii <eliz@gnu.org>
7634
7635 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7636 only under bidi iteration.
7637
115b96bd
JD
76382011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7639
7640 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7641
c8199d0f
PE
76422011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7643
7644 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7645 Without this fix, the command to link temacs failed due to an
7646 undefined symbol __builtin_isnan. This is because
7647 /usr/include/iso/math_c99.h #defines isnan(x) to
7648 __builtin_isnan(x), but the bundled gcc, which identifies itself
7649 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7650 a __builtin_isnan.
7651 * floatfns.c (isnan): #undef, and then #define to a clone of
7652 what's in data.c.
7653 (Fisnan): Always define, since it's always available now.
7654 (syms_of_floatfns): Always define isnan at the Lisp level.
7655
e39b275c 76562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7657
7658 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7659
b2db44d9 76602011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7661
f4af5137 7662 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7663 The previous code assumed that file offsets (off_t values) fit in
7664 EMACS_INT variables, which is not true on typical 32-bit hosts.
7665 The code messed up by falsely reporting buffer overflow in cases
7666 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7667 when "big" contains more than 2**29 bytes, even though this
7668 inserts just one byte and does not overflow the buffer.
7669 (Finsert_file_contents): Store file offsets as off_t
7670 values, not as EMACS_INT values. Check for overflow when
7671 converting between EMACS_INT and off_t. When checking for
7672 buffer overflow or for overlap, take the offsets into account.
7673 Don't use EMACS_INT for small values where int suffices.
7674 When checking for overlap, fix a typo: ZV was used where
7675 ZV_BYTE was intended.
7676 (Fwrite_region): Don't assume off_t fits into 'long'.
7677 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7678
ecfc0a49
MA
76792011-09-05 Michael Albinus <michael.albinus@gmx.de>
7680
7681 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7682
6511acf2 76832011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7684
0999621a 7685 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7686
7687 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7688 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7689 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7690 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7691 (modify_event_symbol): Do not assume that the length of
7692 name_alist_or_stem is safe to alloca and fits in int.
7693 (Fexecute_extended_command): Likewise for function name and binding.
7694 (Frecursion_depth): Wrap around reliably on integer overflow.
7695 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7696 since some callers pass EMACS_INT values.
7697 (Fsingle_key_description): Don't crash if symbol name contains more
7698 than MAX_ALLOCA bytes.
7699 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7700 (get_minibuffer): Arg is now EMACS_INT, not int.
7701 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7702 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7703 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7704
2be7d702
PE
7705 * dbusbind.c (signature_cat): New function.
7706 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7707 Do not overrun buffer; instead, report string overflow.
7708
9d1df220
PE
7709 * dispnew.c (add_window_display_history): Don't overrun buffer.
7710 Truncate instead; this is OK since it's just a log.
7711
33ef5c64
PE
7712 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7713 even if the time zone offset is outlandishly large.
7714 Don't mishandle offset == INT_MIN.
7715
66c6fdd5
PE
7716 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7717 when creating daemon; the previous buffer-overflow check was incorrect.
7718
d749b01b
PE
7719 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7720 which has the guts of the old verror function.
7721
b5cd1905
PE
7722 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7723 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7724
6e1a67fb
PE
7725 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7726 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7727 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7728 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7729 length of string rather than counting it via multiple sprintfs;
7730 that's simpler and more reliable.
c21721cc
PE
7731 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7732 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7733 sprintf, in case result does not fit in int.
7734
c57b67fc
PE
7735 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7736 (fontset_from_font): Print it.
7737
8a401434
PE
7738 * frame.c (tty_frame_count): Now printmax_t, not int.
7739 (make_terminal_frame, set_term_frame_name): Print it.
7740 (x_report_frame_params): In X, window IDs are unsigned long,
7741 not signed long, so print them as unsigned.
7742 (validate_x_resource_name): Check for implausibly long names,
7743 and don't assume name length fits in 'int'.
7744 (x_get_resource_string): Don't blindly alloca invocation name;
7745 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7746 not fit in int.
7747
6e1a67fb
PE
7748 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7749 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7750 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7751
0df02bf3
PE
7752 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7753 Use esprintf, not sprintf, in case result does not fit in int.
7754
48e30793
PE
7755 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7756 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7757 it as a large positive number.
7758 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7759 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7760
a66ff6d8
PE
7761 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7762 in case result does not fit in int.
7763
aca216ff
PE
7764 * print.c (float_to_string): Detect width overflow more reliably.
7765 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7766 buffer overrun. Don't assume list length fits in 'int'. Treat
7767 print length of 0 as 0, not as infinity; to be consistent with other
7768 uses of print length in this function. Don't overflow print length
7769 index. Don't assume hash table size fits in 'long', or that
7770 vectorlike size fits in 'unsigned long'.
7771
31c286f7
PE
7772 * process.c (make_process): Use printmax_t, not int, to format
7773 process-name gensyms.
7774
55e5faa1
PE
7775 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7776
80f2e268
PE
7777 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7778 to avoid potential buffer overrun.
7779
670741ab
PE
7780 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7781 if X resource line is longer than 512 bytes.
7782
b7163a50
PE
7783 * xfns.c (x_window): Make sprintf buffer a bit bigger
7784 to avoid potential buffer overrun.
7785
ae58ff1f
PE
7786 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7787
c43c8a6a
PE
7788 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7789
3f8236f4
PE
77902011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7791
53e9fe90 7792 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7793 Without these, Emacs silently mishandles large integers sometimes.
7794 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7795 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7796
6511acf2
PE
7797 * xdisp.c (try_window_id): Check Emacs fixnum range before
7798 converting to 'int'.
806add1d 7799
6511acf2 7800 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7801 Check that an Emacs fixnum is in range before assigning it to 'int'.
7802 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7803 values converted from Emacs fixnums.
7804 (Frecenter): Don't wrap around a line count if it is out of 'int'
7805 range; instead, treat it as an extreme value.
7806 (Fset_window_configuration, compare_window_configurations):
7807 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7808
6511acf2
PE
7809 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7810 that can exceed INT_MAX. Check that EMACS_INT value is in range
7811 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7812 (match_limit): Don't assume that a fixnum can fit in 'int'.
7813
6511acf2 7814 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7815 exceed INT_MAX.
7816
6511acf2 7817 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7818 (Fvertical_motion): Don't wrap around LINES values that don't fit
7819 in 'int'. Instead, treat them as extreme values. This is good
7820 enough for windows, which can't have more than INT_MAX lines anyway.
7821
fcb901a7
LMI
78222011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7823
0f2f6b6d
LMI
7824 * Require libxml/parser.h to avoid compilation warning.
7825
fcb901a7
LMI
7826 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7827
7828 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7829 since this reportedly can destroy thread storage.
7830
6e20a0d4
CY
78312011-08-30 Chong Yidong <cyd@stupidchicken.com>
7832
7833 * syntax.c (find_defun_start): Update all cache variables if
7834 exiting early (Bug#9401).
7835
148ae00e
EZ
78362011-08-30 Eli Zaretskii <eliz@gnu.org>
7837
f6cfbd8f
EZ
7838 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7839
148ae00e
EZ
7840 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7841 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7842 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7843
7844 * term.c (tty_append_glyph): New function.
7845 (produce_stretch_glyph): Static function and its prototype deleted.
7846
a66cfb1c
SM
7847 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7848 Add prototypes.
148ae00e 7849
c4a07a4c
PE
78502011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7851
7852 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7853 when checking :margin (Bug#9390).
7854 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7855 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7856 so that the name doesn't mislead. All uses changed.
7857
6bc8cd65
JB
78582011-08-28 Johan Bockgård <bojohan@gnu.org>
7859
7860 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7861 set_tty_hooks.
7862
dca4927e
EZ
78632011-08-27 Eli Zaretskii <eliz@gnu.org>
7864
7865 * xdisp.c (move_it_to): Don't bail out early when reaching
7866 position beyond to_charpos, if we are scanning backwards.
7867 (move_it_vertically_backward): When DY == 0, make sure we get to
7868 the first character in the line after the newline.
7869
f2cad773
PE
78702011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7871
7872 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7873 (ccl_driver): Do not generate an out-of-range pointer.
7874 (Fccl_execute_on_string): Remove unnecessary check for
7875 integer overflow, noted by Stefan Monnier in
7876 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7877 Remove a FIXME that didn't need fixing.
7878 Simplify the newly-introduced buffer reallocation code.
7879
0cae2cdb
JB
78802011-08-27 Juanma Barranquero <lekktu@gmail.com>
7881
7882 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7883
5fc295a4 78842011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7885
70c60eb2 7886 Integer and memory overflow issues (Bug#9196).
726e0ab1 7887
d31850da
PE
7888 * doc.c (get_doc_string): Rework so that
7889 get_doc_string_buffer_size is the actual buffer size, rather than
7890 being 1 less than the actual buffer size; this makes xpalloc more
7891 convenient.
7892
a69fbedb
PE
7893 * image.c (x_allocate_bitmap_record, cache_image):
7894 * xselect.c (Fx_register_dnd_atom):
7895 Simplify previous changes by using xpalloc.
7896
fe5c5d37
PE
7897 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7898 since either will do and ptrdiff_t is convenient with xpalloc.
7899
0065d054
PE
7900 * charset.c (charset_table_size)
7901 (struct charset_sort_data.priority): Now ptrdiff_t.
7902 (charset_compare): Don't overflow if priorities differ greatly.
7903 (Fsort_charsets): Don't assume list length fits in int.
7904 Check for size-calculation overflow when allocating sort data.
7905 (syms_of_charset): Allocate an initial charset table that is
7906 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7907
7908 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7909
7910 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7911 The actual value is always <= INT_MAX, and leaving it unsigned made
7912 overflow checking harder.
7913
7914 * dispextern.h (struct glyph_matrix.rows_allocated)
7915 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7916 with xpalloc. The values are still always <= INT_MAX.
7917
7918 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7919
7920 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7921 (SAFE_NALLOCA): New macro.
7922
7923 * region-cache.c (struct boundary.pos, find_cache_boundary)
7924 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7925 (set_cache_region, invalidate_region_cache)
7926 (revalidate_region_cache, know_region_cache, region_cache_forward)
7927 (region_cache_backward, pp_cache):
7928 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7929 so that ptrdiff_t * can be passed to xpalloc.
7930 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7931 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7932 (pp_cache): Don't assume cache_len fits in int.
7933 * region-cache.h: Adjust extern decls to match.
7934
7935 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7936 EMACS_INT, since either will do, for xpalloc.
7937
7938 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7939 (xnmalloc, xnrealloc, xpalloc): New functions.
7940
726e0ab1
PE
7941 * bidi.c (bidi_shelve_header_size): New constant.
7942 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7943 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7944
51f30bc5 7945 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7946 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7947 (overlay_strings):
7948 Don't update size of array until after memory allocation succeeds,
7949 because xmalloc/xrealloc may not return.
0065d054
PE
7950 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7951 now that we have proper integer overflow checking.
7952 (record_overlay_string, overlay_strings): Catch overflows when
7953 calculating size of overlay_str_buf.
726e0ab1 7954
0065d054
PE
7955 * callproc.c (Fcall_process): Check for size overflow when
7956 calculating size of args2.
7957 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7958 Normally we prefer signed values, but sticking with ptrdiff_t would
7959 require adding more-complicated checks.
726e0ab1
PE
7960
7961 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7962 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7963 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7964 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7965
7966 * character.c (Fstring): Check for size-calculation overflow.
7967
7968 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7969 unnecessary integer overflow. Check for size overflow.
7970 (encode_coding_object): Don't update size until xmalloc succeeds.
7971
7972 * composite.c (get_composition_id): Check for overflow in glyph
7973 length calculations.
7974
7975 Integer and memory overflow fixes for display code.
7976 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7977 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7978 (scrolling_window): Check for overflow in size calculations.
7979 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7980 Don't assume glyph table len fits in int.
7981 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7982 (row_table_size): Now ptrdiff_t, not int.
7983 (scrolling_window): Avoid overflow in size calculations.
7984 Don't update size until allocation succeeds.
7985 * fns.c (concat): Check for overflow in size calculations.
7986 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7987 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7988 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7989
7990 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7991 (get_doc_string): Check for size calculation overflow.
7992 Don't update size until allocation succeeds.
7993 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7994 EMACS_INT, where ptrdiff_t will do.
7995 (Fsubstitute_command_keys): Check for string overflow.
7996
7997 * editfns.c (set_time_zone_rule): Don't assume environment length
7998 fits in int.
7999 (message_length): Now ptrdiff_t, not int.
8000 (Fmessage_box): Don't update size until allocation succeeds.
8001 Don't assume message length fits in int.
8002 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8003
0065d054
PE
8004 * emacs.c (main): Do not reallocate argv, since there is a null at
8005 the end that can be overwritten, and this way there's no need to
8006 worry about size-calculation overflow.
8007 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8008
8009 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8010 alloc succeeds.
8011 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8012
8013 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8014 (x_set_scroll_bar_width, x_figure_window_size):
8015 Check for integer overflow.
8016 (x_set_alpha): Do not assume XINT fits in int.
8017
8018 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8019 This is for the members text_lines, text_cols, total_lines, total_cols,
8020 where the system imposes an 'int' limit.
8021
8022 * fringe.c (Fdefine_fringe_bitmap):
8023 Don't update size until alloc works.
8024
8025 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8026 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8027
8028 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8029 Check for size-calculation overflow.
8030 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8031 do, as we prefer signed integers.
8032 (id_to_widget.max_size, id_to_widget.used)
8033 (xg_store_widget_in_map, xg_remove_widget_from_map)
8034 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8035 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8036 Use and return ptrdiff_t, not int.
8037 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8038 * gtkutil.h: Change prototypes to match the above.
8039
8040 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8041 are duplicate now that they've been promoted to lisp.h.
8042 (x_allocate_bitmap_record, x_alloc_image_color)
8043 (make_image_cache, cache_image, xpm_load):
8044 Don't update size until alloc is done.
8045 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8046 (x_detect_edges):
3256efce 8047 Check for size calculation overflow.
726e0ab1
PE
8048 (ct_colors_allocated_max): New constant.
8049 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8050 overflow.
3256efce 8051
726e0ab1
PE
8052 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8053 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8054 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8055 Use ptrdiff_t, not int, to count maps.
8056 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8057 calculations. Don't update size until allocation succeeds.
8058 Redo calculations to avoid overflow.
726e0ab1
PE
8059 * keyboard.h: Change prototypes to match the above.
8060
8061 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8062 to count maps.
8063 (current_minor_maps): Check for size calculation overflow.
8064 * keymap.h: Change prototypes to match the above.
8065
8066 * lread.c (read1, init_obarray): Don't update size until alloc done.
8067
8068 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8069 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8070
726e0ab1
PE
8071 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8072 Now ptrdiff_t, not int.
8073 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8074 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8075
8076 * process.c (Fnetwork_interface_list): Check for overflow
8077 in size calculation.
8078
8079 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8080
8081 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8082 overflow. Don't bother calling xmalloc when xrealloc will do.
8083
8084 * search.c (Freplace_match): Check for size calculation overflow.
8085 (Fset_match_data): Don't assume list lengths fit in 'int'.
8086
8087 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8088 for command line length. Do not attempt to address one before the
8089 beginning of an array, as that's not portable.
8090
8091 * term.c (max_frame_lines): Remove; unused.
8092 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8093 not int.
8094 (encode_terminal_code, calculate_costs): Check for size
8095 calculation overflow.
8096 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8097 table lengths and related sizes. Don't update size until alloc
8098 done. Redo calculations to avoid overflow.
8099 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8100
8101 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8102 subtracting pointers.
8103 (gobble_line): Check for overflow more carefully. Don't update size
8104 until alloc done.
8105
8106 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8107 Don't update size until alloc done.
8108 Redo size calculations to avoid overflow.
8109 Check for size calculation overflow.
0065d054 8110 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8111
8112 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8113 Use ptrdiff_t, not int, for sizes.
8114 (store_mode_line_noprop_char): Don't update size until alloc done.
8115
0065d054
PE
8116 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8117 Use ptrdiff_t, not int, for sizes.
8118 (Finternal_make_lisp_face, cache_face):
8119 Check for size calculation overflow.
8120 (cache_face): Treat size calculation overflows as if they were
8121 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8122
8123 * xfns.c (x_encode_text, x_set_name_internal)
8124 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8125 sizes, since they can exceed INT_MAX in size. Check for size
8126 calculation overflow.
8127
0065d054
PE
8128 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8129 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8130 Don't update size until alloc done.
8131
0065d054 8132 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8133 as sprintf is limited to int lengths.
1d526e2f 8134
252c5ee1
PE
8135 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8136 (X_LONG_MIN): New macros.
864d7ce7
PE
8137 Use them to make the following changes clearer.
8138 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8139 This change doesn't affect the value now, but it may help remind
8140 future maintainers not to raise the value too much later.
8141 (SELECTION_QUANTUM): Remove, replacing with ...
8142 (selection_quantum): ... new function, which avoids overflow.
8143 All uses changed.
8144 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8145 assumption that selection length fits in 'int'.
8146 (x_reply_selection_request, x_handle_selection_request)
8147 (x_get_window_property, receive_incremental_selection)
8148 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8149 (lisp_data_to_selection_data, clean_local_selection_data):
8150 Use ptrdiff_t, not int, to record length of selection.
8151 (x_reply_selection_request, x_get_window_property)
8152 (receive_incremental_selection, x_property_data_to_lisp):
8153 Redo calculations to avoid overflow.
8154 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8155 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8156 something.
8157 (x_get_window_property, receive_incremental_selection)
8158 (lisp_data_to_selection_data, x_property_data_to_lisp):
8159 Check for size-calculation overflow.
8160 (x_get_window_property, receive_incremental_selection)
8161 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8162 Don't store size until memory allocation succeeds.
8163 (x_get_window_property): Plug memory leak on memory exhaustion.
8164 Don't double-block input; malloc is safe here. Don't assume 2**34
8165 - 4 fits in unsigned long. Add an xassert to check
8166 XGetWindowProperty overflow. Be more careful about overflow
8167 calculations, and distinguish size from memory overflow better.
8168 (receive_incremental_selection): When tracing, don't assume
8169 unsigned int is less than INT_MAX.
8170 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8171 harmful) conversions of unsigned short to int.
8172 (lisp_data_to_selection_data): Don't assume that integers
8173 in the range -65535 through -1 fit in an X unsigned short.
8174 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8175 result parameters unless successful. Rely on cons_to_unsigned
8176 to report problems with elements; the old code wasn't right anyway.
8177 (x_check_property_data): Check for int overflow; we cannot use
8178 a wider type due to X limits.
8179 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8180
726e0ab1 8181 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8182
0065d054
PE
8183 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8184 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8185 (x_color_cells): Don't store size until memory allocation succeeds.
8186 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8187 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8188 (x_term_init): Don't assume length fits in int (sprintf is limited
8189 to int size).
bc18e09d 8190
ebfa62c0
PE
8191 Use ptrdiff_t for composition IDs.
8192 * character.c (lisp_string_width):
8193 * composite.c (composition_table_size, n_compositions)
8194 (get_composition_id, composition_gstring_from_id):
8195 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8196 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8197 * window.c (Frecenter):
8198 Use ptrdiff_t, not int, for composition IDs.
8199 * composite.c (get_composition_id): Check for integer overflow.
8200 * composite.h: Adjust prototypes to match the above changes.
8201
d3411f89
PE
8202 Use ptrdiff_t for hash table indexes.
8203 * category.c (hash_get_category_set):
8204 * ccl.c (ccl_driver):
8205 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8206 * coding.c (coding_system_charset_list, detect_coding_system):
8207 * coding.h (struct coding_system.id):
8208 * composite.c (get_composition_id, gstring_lookup_cache):
8209 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8210 * image.c (xpm_get_color_table_h):
8211 * lisp.h (hash_lookup, hash_put):
8212 * minibuf.c (Ftest_completion):
8213 Use ptrdiff_t for hash table indexes, not int (which is too
8214 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8215 32-bit --with-wide-int hosts).
8216
e097a6fa
PE
8217 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8218 Add a FIXME comment about memory leaks.
8219 (syms_of_charset): Don't assume xmalloc returns.
8220
5637687f
PE
8221 Don't assume that stated character widths fit in int.
8222 * character.c (Fchar_width, c_string_width, lisp_string_width):
8223 * character.h (CHAR_WIDTH):
8224 * indent.c (MULTIBYTE_BYTES_WIDTH):
8225 Use sanitize_char_width to avoid undefined and/or bad behavior
8226 with outlandish widths.
a66cfb1c 8227 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8228 now that we have two such functions. All uses changed.
8229 (sanitize_char_width): New inline function.
8230
a2271ba2
PE
8231 Don't assume that tab-width fits in int.
8232 * character.h (sanitize_width): New inline function.
8233 (SANE_TAB_WIDTH): New macro.
8234 (ASCII_CHAR_WIDTH): Use it.
8235 * indent.c (sane_tab_width): Remove. All uses replaced by
8236 SANE_TAB_WIDTH (current_buffer).
8237 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8238
18c52557
PE
8239 * fileio.c: Integer overflow issues with file modes.
8240 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8241
caeeedc1
PE
8242 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8243 Remove unreachable code.
8244 (read_hex, load_charset_map_from_file): Check for integer overflow.
8245
6df6ae42 8246 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8247 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8248 (x_send_scroll_bar_event): Likewise. Check that the size does not
8249 exceed limits imposed by XClientMessageEvent, as well as the usual
8250 ptrdiff_t and size_t limits.
8251
b13995db
PE
8252 * keyboard.c: Overflow, signedness and related fixes.
8253 (make_lispy_movement): Use same integer type in forward decl
8254 that is used in the definition.
8255 (read_key_sequence, keyremap_step):
8256 Change bufsize argument back to int, undoing my 2011-03-30 change.
8257 We prefer signed types, and int is wide enough here.
8258 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8259 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8260 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8261 length, not size_t. Use ptrdiff_t for index, not int.
8262 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8263 possibility of integer overflow.
8264
13464394
PE
8265 Overflow, signedness and related fixes for images.
8266
8267 * dispextern.h (struct it.stack[0].u.image.image_id)
8268 (struct_it.image_id, struct image.id, struct image_cache.size)
8269 (struct image_cache.used, struct image_cache.ref_count):
8270 * gtkutil.c (update_frame_tool_bar):
8271 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8272 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8273 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8274 * nsmenu.m (update_frame_tool_bar):
8275 * xdisp.c (calc_pixel_width_or_height):
8276 * xfns.c (image_cache_refcount):
8277 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8278 on typical 64-bit hosts.
8279
8280 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8281 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8282 Omit unnecessary casts to int.
8283 (parse_image_spec): Check that integers fall into 'int' range
8284 when the callers expect that.
8285 (image_ascent): Redo ascent calculation to avoid int overflow.
8286 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8287 (lookup_image): Remove unnecessary tests.
8288 (xbm_image_p): Locals are now of int, not EMACS_INT,
8289 since parse_image_check makes sure they fit into int.
8290 (png_load, gif_load, svg_load_image):
8291 Prefer int to unsigned where either will do.
8292 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8293 old tiff_error_handler and tiff_warning_handler.
8294 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8295 stack buffer overflows. It uses only the features of vsnprintf
8296 that are common to both POSIX and native Microsoft.
8297 (tiff_error_handler, tiff_warning_handler): Use it.
8298 (tiff_load, gif_load, imagemagick_load_image):
8299 Don't assume :index value fits in 'int'.
8300 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8301 (imagemagick_load_image): Check that crop parameters fit into
8302 the integer types that MagickCropImage accepts. Don't assume
8303 Vimagemagick_render_type has a nonnegative value. Don't assume
8304 size_t fits in 'long'.
8305 (gs_load): Use printmax_t to print the widest integers possible.
8306 Check for integer overflow when computing image height and width.
8307
c11821d4
EZ
83082011-08-26 Eli Zaretskii <eliz@gnu.org>
8309
8310 * xdisp.c (redisplay_window): Don't force window start if point
8311 will be invisible in the resulting window. (Bug#9324)
8312
0c95fcf7
EZ
83132011-08-25 Eli Zaretskii <eliz@gnu.org>
8314
8315 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8316 the display spec is of the form `(space ...)'.
8317 (handle_display_spec): Return the value returned by
8318 handle_single_display_spec, not just 1 or zero.
8319 (handle_single_display_spec): If the display spec is of the form
8320 `(space ...)', and specifies display in the text area, return 2
8321 rather than 1.
fee65a97 8322 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8323 accurately, and prefer exact match for point under bidi.
8324 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8325
8326 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8327 into disp_prop; all users changed.
8328
8329 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8330 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8331 for the text covered by the display property.
8332
e4ed06f1
CY
83332011-08-25 Chong Yidong <cyd@stupidchicken.com>
8334
8335 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8336 Change return value to nil.
8337 (Frecord_buffer): Delete unused function.
8338
f67cdd7f
EZ
83392011-08-24 Eli Zaretskii <eliz@gnu.org>
8340
5980d4c6
EZ
8341 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8342 buffers, return left-to-right.
8610fe8b
EZ
8343 (set_cursor_from_row): Consider candidate row a win if its glyph
8344 represents a newline and point is on that newline. Fixes cursor
8345 positioning on the newline at EOL of R2L text within L2R
8346 paragraph, and vice versa.
8347 (try_cursor_movement): Check continued rows, in addition to
8348 continuation rows. Fixes unwarranted scroll when point enters a
8349 continued line of R2L text within an L2R paragraph, or vice versa.
8350 (cursor_row_p): Consider the case of point being equal to
8351 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8352 from the end of a short line to the beginning of a continued line
8353 of R2L text within L2R paragraph.
8354 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8355 composed characters.
5980d4c6 8356
f67cdd7f
EZ
8357 * bidi.c (bidi_check_type): Use xassert.
8358 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8359 members.
8360
bca633fb
EZ
83612011-08-23 Eli Zaretskii <eliz@gnu.org>
8362
8363 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8364 a character.
8365
4a5885a7
CY
83662011-08-23 Chong Yidong <cyd@stupidchicken.com>
8367
8368 * nsfont.m (ns_otf_to_script): Fix typo.
8369
0902a04e
KH
83702011-08-22 Kenichi Handa <handa@m17n.org>
8371
8372 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8373 extra slot even if the purpose is char-code-property-table.
8374
1a2e6670
EZ
83752011-08-23 Eli Zaretskii <eliz@gnu.org>
8376
8ddde651
EZ
8377 * xdisp.c (redisplay_window): When computing centering_position,
8378 account for the height of the header line. (Bug#8874)
8379
425cc014
EZ
8380 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8381 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8382 candidate is selected by the mouse, and that candidate has a
8383 composed character under the mouse.
8384
1a2e6670
EZ
8385 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8386 coordinates reported by pos-visible-in-window-p for a composed
8387 character in column zero.
8388
8b76d6f8
SM
83892011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8390
8391 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8392
dac347dd
EZ
83932011-08-22 Eli Zaretskii <eliz@gnu.org>
8394
8395 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8396 consider it a hit if to_charpos is anywhere in the range of the
8397 composed buffer positions.
8398
e013fb34
CY
83992011-08-22 Chong Yidong <cyd@stupidchicken.com>
8400
8401 * image.c (gif_load): Don't assume that each subimage has the same
8402 dimensions as the base image. Handle disposal method that is
8403 "undefined" by the gif spec (Bug#9335).
8404
bd1ba3e8
CY
84052011-08-20 Chong Yidong <cyd@stupidchicken.com>
8406
8407 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8408 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8409
54a1215b
EZ
84102011-08-19 Eli Zaretskii <eliz@gnu.org>
8411
823564e5
EZ
8412 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8413 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8414 from an Org mode buffer to a Speedbar frame.
8415
54a1215b
EZ
8416 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8417 a composition, take its buffer position from IT->cmp_it.charpos.
8418 Fixes cursor positioning at the beginning of a line that begins
8419 with a composed character.
8420
9778ebcc
EZ
84212011-08-18 Eli Zaretskii <eliz@gnu.org>
8422
0be6ee06
EZ
8423 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8424 character bidirectional type, use STRONG_L instead. Fixes crashes
8425 in a buffer produced by `describe-categories'.
8426
9778ebcc
EZ
8427 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8428 members before the level stack, so they would be saved and
8429 restored when copying iterator state. Fixes incorrect reordering
8430 around TABs covered by display properties.
8431
156bffbe
AS
84322011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8433
6b02f655 8434 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8435
72ad093b
CY
84362011-08-17 Chong Yidong <cyd@stupidchicken.com>
8437
8438 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8439 (internal_condition_case_2, internal_condition_case_n):
8440 Remove unnecessary aborts (Bug#9081).
72ad093b 8441
35774242
EZ
84422011-08-17 Eli Zaretskii <eliz@gnu.org>
8443
8444 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8445 has no `load' handler, try opening the file locally. (Bug#9311)
8446
db76dd85
KB
84472011-08-16 Ken Brown <kbrown@cornell.edu>
8448
8449 * gmalloc.c: Expand comment.
8450
b215eee5
EZ
84512011-08-16 Eli Zaretskii <eliz@gnu.org>
8452
8453 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8454 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8455
a4579d33
KB
84562011-08-16 Ken Brown <kbrown@cornell.edu>
8457
8458 Fix memory allocation problems in Cygwin build (Bug#9273).
8459
8460 * unexcw.c ( __malloc_initialized): Declare external variable.
8461 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8462
8b76d6f8
SM
8463 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8464 New variables.
a4579d33
KB
8465 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8466 dumped emacs.
8467 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8468 in the static heap.
8469 [CYGWIN] (special_realloc): New function.
8470 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8471 requests to realloc storage in the static heap.
8472
3ebec551
PE
84732011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8474
8475 * bidi.c (bidi_initialize): Remove unused local.
8476
9fd8be00
EZ
84772011-08-15 Eli Zaretskii <eliz@gnu.org>
8478
6b02f655
SM
8479 * bidimirror.h:
8480 * biditype.h: Remove file.
8481 * makefile.w32-in ($(BLD)/bidi.$(O)):
8482 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8483
8484 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8485
8486 * chartab.c: Improve commentary for the uniprop_table API.
8487
32413314
EZ
8488 * bidi.c (bidi_paragraph_init): Support zero value of
8489 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8490 (bidi_initialize): Use uniprop_table instead of including
8491 biditype.h and bidimirror.h.
32413314 8492
9fd8be00
EZ
8493 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8494 coordinates of the iterator when restoring from ppos_it.
8495 (Bug#9296)
8496
5cf2b69b
KH
84972011-08-14 Kenichi Handa <handa@m17n.org>
8498
8499 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8500 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8501
daf17d00
EZ
85022011-08-14 Eli Zaretskii <eliz@gnu.org>
8503
8504 * xdisp.c (move_it_in_display_line_to): Don't invoke
8505 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8506 ppos_it. Fixes vertical cursor motion when line beginning is
8507 covered by an image. (Bug#9296)
8508
08e3161a
JD
85092011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8510
8511 * nsterm.h (ns_run_ascript): Declare.
8512 (NSAPP_DATA2_RUNASSCRIPT): Define.
8513
8514 * nsfns.m (as_script, as_result, as_status): New static variables.
8515 (ns_run_ascript): New function.
5e617bc2 8516 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8517 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8518 the event loop. Get status from as_status (Bug#7276).
8519
8520 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8521 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8522 the event loop (Bug#7276).
8523
a3720aa2
AS
85242011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8525
8526 * gnutls.c (QCgnutls_bootprop_priority)
8527 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8528 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8529 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8530 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8531 (QCgnutls_bootprop_verify_hostname_error)
8532 (QCgnutls_bootprop_callbacks_verify): Rename from
8533 Qgnutls_bootprop_..., all uses changed.
8534
8535 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8536 uses changed.
8537
0a0d27fb
PE
85382011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8539
19d5c50c
PE
8540 * xfaces.c (Qframe_set_background_mode): Now static.
8541 * dispextern.h (Qframe_set_background_mode): Remove decl.
8542
0a0d27fb
PE
8543 * process.c (Fnetwork_interface_info): Declare local only if needed.
8544
377538cb
JD
85452011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8546
8547 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8548 (Fnetwork_interface_list): Allocate in increments of bytes instead
8549 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8550 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8551 sockaddr.
8552 (struct ifflag_def): notrailers is smart on OSX.
8553 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8554 Get hardware address with getifaddrs if available.
8555
08fff70c
EZ
85562011-08-12 Eli Zaretskii <eliz@gnu.org>
8557
8558 * xdisp.c (iterate_out_of_display_property): xassert that
8559 IT->position is set to within IT->object's boundaries. Break from
8560 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8561 when IT->position is set up wrongly due to some bug.
8562 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8563 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8564 entry. Force push_it to save on the stack the current
8565 buffer/string position, to be restored by pop_it. Fix flags in
8566 the iterator structure wrt the object coming from a display
8567 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8568 properties. (Bug#9284)
8569
7be1c708 85702011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8571
7be1c708
CY
8572 * fontset.c (fontset_get_font_group): Add proper type checks.
8573 (Bug#9172)
aac0c6e3 8574
7be1c708 85752011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8576
7be1c708
CY
8577 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8578 and LC_VERSION_MIN_MACOSX.
8579 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8580 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8581
97bb72a6
EZ
85822011-08-08 Eli Zaretskii <eliz@gnu.org>
8583
8584 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8585 no-display-properties-and-no-overlays under bidi display.
8586 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8587 properties and overlays.
97bb72a6 8588
d5617611
CY
85892011-08-08 Chong Yidong <cyd@stupidchicken.com>
8590
37e11a63
CY
8591 * editfns.c (Fset_time_zone_rule): Document relationship with the
8592 setenv function.
8593
d5617611
CY
8594 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8595 the font entity extracted from the cache (Bug#8109).
8596
58872834
CY
85972011-08-07 Chong Yidong <cyd@stupidchicken.com>
8598
8599 * composite.c (autocmp_chars): Don't reset point. That is done by
8600 restore_point_unwind (Bug#5984).
8601
75bfc667
JL
86022011-08-07 Juri Linkov <juri@jurta.org>
8603
8604 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8605 to show the arg `TIME' instead of `TIMEVAL'.
8606
d1410150
EZ
86072011-08-06 Eli Zaretskii <eliz@gnu.org>
8608
8609 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8610 display property strides EOL and includes a newline, as in
8611 longlines-mode. (Bug#9254)
75b771e4
EZ
8612 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8613 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8614
8615 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8616 is non-zero, even if the data buffer is NULL. Fixes a crash in
8617 vertical-motion with longlines-mode. (Bug#9254)
8618
35928349
EZ
86192011-08-05 Eli Zaretskii <eliz@gnu.org>
8620
ec7cc85b
EZ
8621 * bidi.c <bidi_cache_total_alloc>: Now static.
8622 (bidi_initialize): Initialize bidi_cache_total_alloc.
8623
8b76d6f8 8624 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8625 cache. (Bug#9221)
8626
8627 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8628 amount allocated this far in `bidi_cache_total_alloc'.
8629 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8630 non-zero, only free the data buffer without restoring the cache
8631 contents. All callers changed.
8632
8633 * dispextern.h (bidi_unshelve_cache): Update prototype.
8634
8635 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8636 (move_it_in_display_line, move_it_to)
8637 (move_it_vertically_backward, move_it_by_lines): Replace the call
8638 to xfree to an equivalent call to bidi_unshelve_cache.
8639 (move_it_in_display_line_to): Fix logic of returning
412b6358 8640 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8641
e2e2423b
EZ
86422011-08-05 Eli Zaretskii <eliz@gnu.org>
8643
8644 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8645 came from a string character with a `cursor' property. (Bug#9229)
8646
ae9e757a
JD
86472011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8648
8649 * Makefile.in (LIB_PTHREAD): New variable.
8650 (LIBES): Add LIB_PTHREAD (Bug#9216).
8651
8652 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8653 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8654
213bd7f2
AS
86552011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8656
6b02f655 8657 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8658
99aaf75f
JD
86592011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8660
8661 * xterm.c (x_find_topmost_parent): New function.
8662 (x_set_frame_alpha): Find topmost parent window with
8663 x_find_topmost_parent and set the property there also (bug#9181).
8664 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8665
c74e9d86
PE
86662011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8667
8668 * callproc.c (Fcall_process): Avoid vfork clobbering
8669 the local vars buffer, coding_systems, current_dir.
8670
640c8776
SM
86712011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8672
8673 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8674
f26d0e4c
PE
86752011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8676
8a10d76c
PE
8677 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8678 so that it is not optimized away.
8679
f26d0e4c
PE
8680 * xdisp.c (compute_display_string_pos): Remove unused local.
8681
55439c61
EZ
86822011-08-02 Eli Zaretskii <eliz@gnu.org>
8683
8684 Fix slow cursor motion and scrolling in large buffers with
8685 selective display, like Org Mode buffers. (Bug#9218)
8686
8687 * dispextern.h (struct bidi_it): New member disp_prop_p.
8688
8689 * xdisp.c: Remove one-slot cache of display string positions.
8690 (compute_display_string_pos): Accept an additional argument
5e617bc2 8691 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8692 for a display string or property. If found, set DISP_PROP_P
8693 non-zero.
8694
8695 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8696 DISP_PROP_P, and pass it to compute_display_string_pos.
8697 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8698 non-zero. All callers of bidi_fetch_char changed.
8699
fb33fa43
SM
87002011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8701
8702 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8703
b099e063
DM
87042010-12-03 Don March <don@ohspite.net>
8705
8706 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8707 last character M-[char] is translated to ESC [char] (bug#7541).
8708
5cc7f7af
KH
87092011-08-02 Kenichi Handa <handa@m17n.org>
8710
d0fffa3f 8711 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8712
8713 * chartab.c (uniprop_table): Make it non-static.
8714
525d5e6e
EZ
87152011-08-01 Eli Zaretskii <eliz@gnu.org>
8716
8717 * xdisp.c (forward_to_next_line_start): Accept additional argument
8718 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8719 on the newline.
8720 (reseat_at_next_visible_line_start): Use the bidi iterator state
8721 returned by forward_to_next_line_start to restore the state of
8722 it->bidi_it after backing up to previous newline. (Bug#9212)
8723
31011111
AS
87242011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8725
8726 * regex.c (re_comp): Protoize.
8727 (re_exec): Fix return type.
8728 (regexec): Fix type of `ret'. (Bug#9203)
8729
476371c4
PE
87302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8731
e5d76069
PE
8732 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8733 This is needed if max-image-size is a floating-point number.
8734
9a79b20c
AS
87352011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8736
8737 * print.c (print_object): Print empty symbol as ##.
8738
8739 * lread.c (read1): Read ## as empty symbol.
8740
d8c2fa78
AA
87412011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8742
8743 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8744 setting frame foreground color (Bug#9175).
8745 (x_set_background_color): Likewise.
8746
ffe57a7a
AA
8747 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8748 contents (Bug#9176).
8749 (EmacsTooltip -init): Remove bezels and add shadows to
8750 tooltip windows.
8751
bf3492a5
AA
8752 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8753 or scroll bar (Bug#8470).
8754
d55e9c53
AA
8755 * nsfont.m (nsfont_open): Remove assignment to voffset and
8756 unnecessary vars hshink, expand, hd, full_height, min_height.
8757 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8758
8759 * nsterm.h (nsfont_info): Remove voffset field.
8760
d8c2fa78 87612011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8762
8763 Implement strike-through and overline on NextStep (Bug#8863).
8764
8765 * nsfont.m (nsfont_open): Use underline position provided by font,
8766 instead of hard-coded value of 2.
8767 (nsfont_draw): Call ns_draw_text_decoration instead.
8768
8769 * nsterm.h: Add declaration for ns_draw_text_decoration.
8770
8771 * nsterm.m (ns_draw_text_decoration): New function for drawing
8772 underline, overline, and strike-through.
8773 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8774 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8775 accommodate underlining, etc.
4843aac3 8776
4cc60b9b
EZ
87772011-07-28 Eli Zaretskii <eliz@gnu.org>
8778
bc7ece87
EZ
8779 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8780 default.
4cc60b9b 8781
476371c4
PE
87822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8783
66606eea
PE
8784 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8785 Without this fix, if a signal arrives just after memory fills up,
8786 'malloc' might be invoked reentrantly.
8787
476371c4
PE
8788 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8789 In other words, assume that every image size is allowed, on non-X
8790 hosts. This assumption is probably wrong, but it lets Emacs compile.
8791
f3fcc40d
AS
87922011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8793
8794 * regex.c (re_iswctype): Convert return values to boolean.
8795
350c992f
EZ
87962011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8797
8798 * xdisp.c (compute_display_string_pos): Don't use cached display
8799 string position if the buffer had its restriction changed.
8800 (Bug#9184)
8801
5266b4bb
PE
88022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8803
8804 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8805
2573a837 88062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8807
41f55ccd 8808 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8809
39e378da
PE
8810 * bidi.c: Integer size and overflow fixes.
8811 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8812 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8813 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8814 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8815 (bidi_find_other_level_edge):
8816 Use ptrdiff_t instead of EMACS_INT where either will do.
8817 This works better on 32-bit hosts configured --with-wide-int.
8818 (bidi_cache_ensure_space): Check for size-calculation overflow.
8819 Use % rather than repeated addition, for better worst-case speed.
8820 Don't set bidi_cache_size until after xrealloc returns, because it
8821 might not return.
8822 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8823 (bidi_cache_ensure_space): Also check that the bidi cache size
8824 does not exceed that of the largest Lisp string or buffer. See Eli
8825 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8826
5e927815
PE
8827 * alloc.c (__malloc_size_t): Remove.
8828 All uses replaced by size_t. See Andreas Schwab's note
8829 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8830
ca4aa935
PE
8831 * image.c: Improve checking for integer overflow.
8832 (check_image_size): Assume that f is nonnull, since
8833 it is always nonnull in practice. This is one less thing to
8834 worry about when checking for integer overflow later.
8835 (x_check_image_size): New function, which checks for integer
8836 overflow issues inside X.
8837 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8838 This removes the need for a memory_full check.
8839 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8840 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8841 (xbm_read_bitmap_data): Change locals back to 'int', since
8842 their values must fit in 'int'.
8843 (xpm_load_image, png_load, tiff_load):
8844 Invoke x_create_x_image_and_pixmap earlier,
8845 to avoid much needless work if the image is too large.
8846 (tiff_load): Treat overly large images as if
8847 x_create_x_image_and_pixmap failed, not as malloc failures.
8848 (gs_load): Use x_check_image_size.
8849
5f8f9cc2
PE
8850 * gtkutil.c: Omit integer casts.
8851 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8852 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8853
5adf60bc
PE
8854 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8855
c8907a93
PE
8856 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8857 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8858 would wrongly return t on a 64-bit host.
8859
e3c25c68
PE
8860 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8861 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8862 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8863 and therefore cause GCC to emit a bogus diagnostic in some cases.
8864
3f791afe
PE
8865 * image.c: Integer signedness and overflow and related fixes.
8866 This is not an exhaustive set of fixes, but it's time to
8867 record what I've got.
8868 (lookup_pixel_color, check_image_size): Remove redundant decls.
8869 (check_image_size): Don't assume that arbitrary EMACS_INT values
8870 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8871 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8872 (tiff_load, imagemagick_load_image):
8873 Check for overflow in size calculations.
8874 (x_create_x_image_and_pixmap): Remove unnecessary test for
8875 xmalloc returning NULL; that can't happen.
8876 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8877 (xpm_color_bucket): Use better integer hashing function.
8878 (xpm_cache_color): Don't possibly over-allocate memory.
8879 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8880 (gif_memory_source):
8881 Use ptrdiff_t, not int or size_t, to record sizes.
8882 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8883 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8884 either works, as we prefer signed integers.
8885 (tiff_read_from_memory, tiff_write_from_memory):
8886 Return tsize_t, not size_t, since that's what the TIFF API wants.
8887 (tiff_read_from_memory): Don't fail simply because the read would
8888 go past EOF; instead, return a short read.
8889 (tiff_load): Omit no-longer-needed casts.
8890 (Fimagemagick_types): Don't assume size fits into 'int'.
8891
3cc5a532
PE
8892 Improve hashing quality when configured --with-wide-int.
8893 * fns.c (hash_string): New function, taken from sxhash_string.
8894 Do not discard information about ASCII character case; this
8895 discarding is no longer needed.
8896 (sxhash-string): Use it. Change sig to match it. Caller changed.
8897 * lisp.h: Declare it.
8898 * lread.c (hash_string): Remove, since we now use fns.c's version.
8899 The fns.c version returns a wider integer if --with-wide-int is
8900 specified, so this should help the quality of the hashing a bit.
8901
b312a492
PE
8902 * emacs.c: Integer overflow minor fix.
8903 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8904 Define only if GNU_LINUX.
8905 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8906
dfd153ae
PE
8907 * dispnew.c: Integer signedness and overflow fixes.
8908 Remove unnecessary forward decls, that were a maintenance hassle.
8909 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8910 All uses changed.
8911 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8912 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8913 (prepare_desired_row, line_draw_cost):
8914 Use int, not unsigned, where either works.
8915 (save_current_matrix, restore_current_matrix):
8916 Use ptrdiff_t, not size_t, where either works.
8917 (init_display): Check for overflow more accurately, and without
8918 relying on undefined behavior.
8919
a81d11a3
PE
8920 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8921 Remove, replacing with the new symbols in lisp.h. All uses changed.
8922 * fileio.c (make_temp_name):
8923 * filelock.c (lock_file_1, lock_file):
8924 * xdisp.c (message_dolog):
8925 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8926 Use pMd etc. instead.
8927 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8928 replacing the pWIDE etc. symbols removed from editfns.c.
8929
3300e6fd
PE
8930 * keyboard.h (num_input_events): Now uintmax_t.
8931 This is (very slightly) less likely to mess up due to wraparound.
8932 All uses changed.
8933
fd05c7e9
PE
8934 * buffer.c: Integer signedness fixes.
8935 (alloc_buffer_text, enlarge_buffer_text):
8936 Use ptrdiff_t rather than size_t when either will do, as we prefer
8937 signed integers.
8938
903fe15d
PE
8939 * alloc.c: Integer signedness and overflow fixes.
8940 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8941 (__malloc_size_t): Default to size_t, not to int.
8942 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8943 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8944 Prefer ptrdiff_t to size_t when either would do, as we prefer
8945 signed integers.
8946 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8947 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8948 Now const. Initialize with values that are in range even if char
8949 is signed.
8950 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8951 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8952 These functions do the right thing with sizes > 2**32.
8953 (check_depth): Now ptrdiff_t, not int.
8954 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8955 Adjust to new way of storing sizes. Check for size overflow bugs
8956 in rest of code.
8957 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8958 slightly wrong anyway, as it missed one instance of
8959 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8960 (refill_memory_reserve): Omit needless cast to size_t.
8961 (mark_object_loop_halt): Mark as externally visible.
8962
ac82cc6a
PE
8963 * xselect.c: Integer signedness and overflow fixes.
8964 (Fx_register_dnd_atom, x_handle_dnd_message):
8965 Use ptrdiff_t, not size_t, since we prefer signed.
8966 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8967 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8968 x_dnd_atoms_size and x_dnd_atoms_length.
8969
c2d1e36d
PE
8970 * doprnt.c: Prefer signed to unsigned when either works.
8971 * eval.c (verror):
8972 * doprnt.c (doprnt):
8973 * lisp.h (doprnt):
8974 * xdisp.c (vmessage):
8975 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8976 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8977 prefer signed arithmetic to avoid comparison confusion.
8978 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8979 but is a bit tricky.
8980
0e926e56
PE
8981 Assume freestanding C89 headers, string.h, stdlib.h.
8982 * data.c, doprnt.c, floatfns.c, print.c:
8983 Include float.h unconditionally.
8984 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8985 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8986 * regex.c: Likewise for stddef.h, string.h.
8987 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8988 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8989 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8990 (STDC_HEADERS): Remove obsolete defines.
8991 * sysdep.c: Include limits.h unconditionally.
8992
9cfdb3ec
PE
8993 Assume support for memcmp, memcpy, memmove, memset.
8994 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8995 * regex.c (memcmp, memcpy):
8996 Remove; we assume C89 now.
8997
8998 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8999 (__malloc_safe_bcopy): Remove; no longer needed.
9000
cf950e6b 9001 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9002 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9003 well either way, and we prefer signed to unsigned.
9004
dbf38e02
LMI
90052011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9006
9007 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9008 closes the connection while we're reading (bug#9182).
9009
d6f0886c 90102011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9011
d6f0886c
JD
9012 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9013 are specified (Bug#9168).
24e0f6b1 9014
2eb1f9e6
PE
90152011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9016
9017 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9018 Found by GCC static checking and --with-wide-int on a 32-bit host.
9019
22381272 90202011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9021
9022 * xdisp.c (compute_display_string_pos): Fix logic of caching
9023 previous display string position. Initialize cached_prev_pos to
9024 -1. Fixes slow-down at the beginning of a buffer.
9025
f25e39b4
EZ
90262011-07-24 Eli Zaretskii <eliz@gnu.org>
9027
9028 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9029 for attrs[LFACE_FONTSET_INDEX].
9030
04c4b52e
PE
90312011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9032
9033 * xml.c (parse_region): Remove unused local
9034 that was recently introduced.
9035
c1734fbd
EZ
90362011-07-23 Eli Zaretskii <eliz@gnu.org>
9037
be18c5a5
EZ
9038 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9039 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9040
c1734fbd
EZ
9041 * xdisp.c (move_it_in_display_line_to): Record the best matching
9042 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9043 exit if none of the characters scanned was an exact match.
9044 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9045 when exact match is impossible due to invisible text, and the
9046 lines are truncated.
9047
a258d627
JD
90482011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9049
9050 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9051 for OSX >= 10.7.
9052
b6d5a689
EZ
90532011-07-22 Eli Zaretskii <eliz@gnu.org>
9054
0f74f785
EZ
9055 Fix a significant slow-down of cursor motion with C-n, C-p,
9056 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9057 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9058 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9059 (next_element_from_buffer): Call compute_stop_pos_backwards to
9060 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9061 base_level_stop.
9062 (reseat): Don't look for prev_stop, as that could mean a very long
9063 run.
9064 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9065 <cached_disp_overlay_modiff>: Cache for last found display string
9066 position.
551918c1 9067 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9068 about the same buffer in the same area of character positions, and
9069 the buffer wasn't changed since the time the display string
9070 position was cached.
551918c1 9071
b2d0c91a
EZ
90722011-07-22 Eli Zaretskii <eliz@gnu.org>
9073
9074 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9075 is an integer, which is important for empty lines. (Bug#9149)
9076
043604ee
CY
90772011-07-22 Chong Yidong <cyd@stupidchicken.com>
9078
9079 * frame.c (Fmodify_frame_parameters): In tty case, update the
9080 default face if necessary (Bug#4238).
9081
da4adb04
CY
90822011-07-21 Chong Yidong <cyd@stupidchicken.com>
9083
9084 * editfns.c (Fstring_to_char): No need to explain what a character
9085 is in the docstring (Bug#6576).
9086
9abd0532
LMI
90872011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9088
9089 * xml.c (parse_region): Make sure we always return a tree.
9090
36881d16
HK
90912011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9092
9093 * xml.c (parse_region): If a document contains only comments,
9094 return that, too.
9095
1e98674d
LMI
90962011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9097
9098 * xml.c (make_dom): Return comments, too.
9099
590bd467
PE
91002011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9101
9102 Port to OpenBSD.
9103 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9104 and the surrounding thread.
9105 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9106 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9107 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9108 timer goes off.
9109 * s/openbsd.h (BROKEN_SIGIO): Define.
9110 * unexelf.c (unexec) [__OpenBSD__]:
9111 Don't update the .mdebug section of the Alpha COFF symbol table.
9112
f41628b2
LMI
91132011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9114
9115 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9116 (bug#8460).
9117
b59b67c5
PE
91182011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9119
15e3a074
PE
9120 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9121 This fixes some race conditions on the permissions of any newly
9122 created file.
9123
41bed37d
PE
9124 * alloc.c (valid_pointer_p): Use pipe, not open.
9125 This fixes some permissions issues when debugging.
9126
b59b67c5
PE
9127 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9128 If fchown fails to set both uid and gid, try to set just gid,
9129 as that is sometimes allowed. Adjust the file's mode to eliminate
9130 setuid or setgid bits that are inappropriate if fchown fails.
9131
925a6be7
SM
91322011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9133
9134 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9135 to compare Lisp_Objects.
9136 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9137 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9138 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9139
52968808
AS
91402011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9141
0a6a104b
AS
9142 * lread.c (read_integer): Unread even EOF character.
9143 (read1): Likewise. Properly record start position of symbol.
9144
52968808
AS
9145 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9146 symbol character follows.
9147
9e381cdd
PE
91482011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9149
9150 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9151 This works around a problem with the previous change to Fcopy_file.
9152 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9153 and without this change, GCC might complain about discarding
9154 fchown's return value.
9155
b5641435
JB
91562011-07-16 Juanma Barranquero <lekktu@gmail.com>
9157
9158 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9159
a8031457
PE
91602011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9161
9162 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9163
dd889327
LMI
91642011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9165
750c33f7
LMI
9166 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9167 it's used from the C level.
9168
dd889327
LMI
9169 * process.c: Use the same condition for POLL_FOR_INPUT in both
9170 keyboard.c and process.c (bug#1858).
9171
87e86684
LM
91722011-07-09 Lawrence Mitchell <wence@gmx.li>
9173
9174 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9175 (Fgnutls_boot): Use it.
9176
64348f40
AS
91772011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9178
9179 * doc.c (Fsubstitute_command_keys): Revert last change.
9180
1d698799
LMI
91812011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9182
f863868c
LMI
9183 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9184 quotes the next character, and doesn't affect other longer
9185 sequences (bug#8935).
9186
1d698799
LMI
9187 * lread.c (syms_of_lread): Clarify that is isn't only
9188 `eval-buffer' and `eval-defun' that's affected by
9189 `lexical-binding' (bug#8460).
9190
aa4b6df6
EZ
91912011-07-15 Eli Zaretskii <eliz@gnu.org>
9192
9193 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9194 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9195
5d856da6
PE
91962011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9197
ad6042bb
PE
9198 Fix minor problems found by static checking.
9199 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9200 (elsz): Now a signed constant, not a size_t var. We prefer signed
9201 types to unsigned, to avoid integer comparison confusion. Without
9202 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9203 "cannot optimize loop, the loop counter may overflow", a symptom
9204 of the confusion.
f00bbb22 9205 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9206 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9207
6468f31c
LMI
92082011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9209
49080b10
LMI
9210 * search.c (Fre_search_backward): Mention `case-fold-search' in
9211 all the re_search_* functions (bug#8138).
9212
6468f31c
LMI
9213 * keyboard.c (Fopen_dribble_file): Document when the file is
9214 closed (bug#8056).
9215
c965adc5
EZ
92162011-07-14 Eli Zaretskii <eliz@gnu.org>
9217
df9733bf
EZ
9218 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9219 bidi_cache_idx.
9220
0bb23927
EZ
9221 Support bidi reordering of display and overlay strings.
9222 * xdisp.c (compute_display_string_pos)
9223 (compute_display_string_end): Accept additional argument STRING.
9224 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9225 (reseat_to_string): Initialize bidi_it->string.s and
9226 bidi_it->string.schars.
9227 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9228 NULL (avoids a crash in bidi_paragraph_init).
9229 Initialize itb.string.lstring.
0bb23927
EZ
9230 (init_iterator): Call bidi_init_it only of a valid
9231 buffer position was specified. Initialize paragraph_embedding to
9232 L2R.
9233 (reseat_to_string): Initialize the bidi iterator.
9234 (display_string): If we need to ignore text properties of
9235 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9236 original value of -1 will not work with bidi.)
9237 (compute_display_string_pos): First arg is now struct
9238 `text_pos *'; all callers changed. Support display properties on
9239 Lisp strings.
9240 (compute_display_string_end): Support display properties on Lisp
9241 strings.
9242 (init_iterator, reseat_1, reseat_to_string): Initialize the
9243 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9244 when iterating on a string not from display properties).
640c8776
SM
9245 (compute_display_string_pos, compute_display_string_end):
9246 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9247 arrow keys.
9248 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9249 base_level_stop; instead, set base_level_stop to BEGV.
9250 Fixes crashes in vertical-motion.
0bb23927
EZ
9251 (next_element_from_buffer): Improve commentary for when
9252 the iterator is before prev_stop.
9253 (init_iterator): Initialize bidi_p from the default value of
9254 bidi-display-reordering, not from buffer-local value. Use the
9255 buffer-local value only if initializing for buffer iteration.
9256 (handle_invisible_prop): Support invisible properties on strings
9257 that are being bidi-reordered.
9258 (set_iterator_to_next): Support bidi reordering of C strings and
9259 Lisp strings.
9260 (next_element_from_string): Support bidi reordering of Lisp
9261 strings.
9262 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9263 (display_string): Support display of R2L glyph rows.
9264 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9265 (init_iterator): Don't initialize it->bidi_p for strings
9266 here.
9267 (reseat_to_string): Initialize it->bidi_p for strings here.
9268 (next_element_from_string, next_element_from_c_string)
9269 (next_element_from_buffer): Add xassert's for correspondence
9270 between IT's object being iterated and it->bidi_it.string
9271 structure.
9272 (face_before_or_after_it_pos): Support bidi iteration.
9273 (next_element_from_c_string): Handle the case of the first string
9274 character that is not the first one in the visual order.
9275 (get_visually_first_element): New function, refactored from common
9276 parts of next_element_from_buffer, next_element_from_string, and
9277 next_element_from_c_string.
9278 (tool_bar_lines_needed, redisplay_tool_bar)
9279 (display_menu_bar): Force left-to-right direction. Add a FIXME
9280 comment for making that be controlled by a user option.
9281 (push_it, pop_it): Save and restore the state of the
9282 bidi iterator. Save and restore the bidi_p flag.
9283 (pop_it): Iterate out of display property for string iteration as
9284 well.
9285 (iterate_out_of_display_property): Support iteration over strings.
9286 (handle_single_display_spec): Set up it->bidi_it for iteration
9287 over a display string, and call bidi_init_it.
9288 (handle_single_display_spec, next_overlay_string)
9289 (get_overlay_strings_1, push_display_prop): Set up the bidi
9290 iterator for displaying display or overlay strings.
9291 (forward_to_next_line_start): Don't use the shortcut if
9292 bidi-iterating.
9293 (back_to_previous_visible_line_start): If handle_display_prop
9294 pushed the iterator stack, restore the internal state of the bidi
9295 iterator by calling bidi_pop_it same number of times.
9296 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9297 and we are bidi-iterating, don't decrement the iterator position;
9298 instead, set the first_elt flag in the bidi iterator, to produce
9299 the same effect.
9300 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9301 (push_display_prop): xassert that we are iterating a buffer.
9302 (push_it, pop_it): Save and restore paragraph_embedding member.
9303 (handle_single_display_spec, next_overlay_string)
9304 (get_overlay_strings_1, reseat_1, reseat_to_string)
9305 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9306 correctly. Don't assume unibyte strings are not bidi-reordered.
9307 (compute_display_string_pos)
9308 (compute_display_string_end): Fix handling the case of C string.
9309 (push_it, pop_it): Save and restore from_disp_prop_p.
9310 (handle_single_display_spec, push_display_prop): Set the
9311 from_disp_prop_p flag.
9312 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9313 (pop_it): Call iterate_out_of_display_property only if we are
9314 popping after iteration over a string that came from a display
9315 property. Fix a typo in popping stretch info. Add an assertion
9316 for verifying that the iterator position is in sync with the bidi
9317 iterator.
9318 (handle_single_display_spec, get_overlay_strings_1)
9319 (push_display_prop): Fix initialization of paragraph direction for
9320 string when that of the parent object is not yet determined.
9321 (reseat_1): Call bidi_init_it to resync the bidi
9322 iterator with IT's position. (Bug#7616)
9323 (find_row_edges): If ROW->start.pos gives position
9324 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9325 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9326 Reset the from_disp_prop_p flag.
9327 (SAVE_IT, RESTORE_IT): New macros.
9328 (pos_visible_p, face_before_or_after_it_pos)
9329 (back_to_previous_visible_line_start)
9330 (move_it_in_display_line_to, move_it_in_display_line)
9331 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9332 (try_scrolling, redisplay_window, display_line): Use them when
9333 saving a temporary copy of the iterator and restoring it back.
9334 (back_to_previous_visible_line_start, reseat_1)
9335 (init_iterator): Empty the bidi cache "stack".
9336 (move_it_in_display_line_to): If iterator ended up at
9337 EOL, but we never saw any buffer positions smaller than
9338 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9339 motion in bidi-reordered lines.
9340 (move_it_in_display_line_to): Record prev_method and prev_pos
9341 immediately before the call to set_iterator_to_next. Fixes cursor
9342 motion in bidi-reordered lines with stretch glyphs and strings
9343 displayed in margins. (Bug#8133) (Bug#8867)
9344 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9345 TO_CHARPOS.
640c8776
SM
9346 (pos_visible_p): Support positions in bidi-reordered lines.
9347 Save and restore bidi cache.
0bb23927
EZ
9348
9349 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9350 (bidi_paragraph_info): Delete unused struct.
9351 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9352 (bidi_cache_start): New variable.
9353 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9354 to zero.
9355 (bidi_cache_fetch_state, bidi_cache_search)
9356 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9357 (bidi_cache_find, bidi_peek_at_next_level)
9358 (bidi_level_of_next_char, bidi_find_other_level_edge)
9359 (bidi_move_to_visually_next): Compare cache index with
9360 bidi_cache_start rather than with zero.
9361 (bidi_fetch_char): Accept new argument STRING; all callers
9362 changed. Support iteration over a string. Support strings with
9363 display properties. Support unibyte strings. Fix the type of
9364 `len' according to what STRING_CHAR_AND_LENGTH expects.
9365 (bidi_paragraph_init, bidi_resolve_explicit_1)
9366 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9367 (bidi_level_of_next_char, bidi_move_to_visually_next):
9368 Support iteration over a string.
0bb23927
EZ
9369 (bidi_set_sor_type, bidi_resolve_explicit_1)
9370 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9371 can now be zero (for strings); special values 0 and -1 were
9372 changed to -1 and -2, respectively.
9373 (bidi_char_at_pos): New function.
9374 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9375 Call it instead of FETCH_MULTIBYTE_CHAR.
9376 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9377 initialized to valid values.
9378 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9379 values.
9380 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9381 the test for valid cached positions. Fix the logic for looking up
9382 the sentinel state in the cache. GCPRO the Lisp string we are
9383 iterating.
9384 (bidi_push_it, bidi_pop_it): New functions.
9385 (bidi_initialize): Initialize the bidi cache start stack pointer.
9386 (bidi_cache_ensure_space): New function, refactored from part of
9387 bidi_cache_iterator_state. Don't assume the required size is just
9388 one BIDI_CACHE_CHUNK away.
9389 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9390 (bidi_count_bytes, bidi_char_at_pos): New functions.
9391 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9392 always valid if bidi_cache_idx is valid.
9393 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9394 is valid if it's going to be used.
9395 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9396 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9397 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9398 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9399 (bidi_find_other_level_edge, bidi_cache_start_stack):
9400 All variables related to cache indices are now EMACS_INT.
c965adc5 9401
0bb23927
EZ
9402 * dispextern.h (struct bidi_string_data): New structure.
9403 (struct bidi_it): New member `string'. Make flag members be 1-bit
9404 fields, and put them last in the struct.
640c8776
SM
9405 (compute_display_string_pos, compute_display_string_end):
9406 Update prototypes.
0bb23927
EZ
9407 (bidi_push_it, bidi_pop_it): Add prototypes.
9408 (struct iterator_stack_entry): New members bidi_p,
9409 paragraph_embedding, and from_disp_prop_p.
9410 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9411 (bidi_shelve_cache, bidi_unshelve_cache):
9412 Declare prototypes.
0bb23927
EZ
9413
9414 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9415 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9416 and vector-like objects.
9417
9418 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9419 cache around display iteration.
9420
9421 * window.c (Fwindow_end, window_scroll_pixel_based)
9422 (displayed_window_lines, Frecenter): Save and restore the bidi
9423 cache around display iteration.
9424
3bbd2265
LMI
94252011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9426
9427 * editfns.c (Fdelete_region): Clarify the use of the named
9428 parameters (bug#6788).
9429
adc47434
MR
94302011-07-14 Martin Rudalics <rudalics@gmx.at>
9431
9432 * indent.c (Fvertical_motion): Set and restore w->pointm when
9433 saving and restoring the window's buffer (Bug#9006).
9434
837c31f8
LMI
94352011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9436
9437 * editfns.c (Fstring_to_char): Clarify just what is returned
9438 (bug#6576). Text by Eli Zaretskii.
9439
ac389d0c
JB
94402011-07-13 Juanma Barranquero <lekktu@gmail.com>
9441
9442 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9443
0be0ce47
EZ
94442011-07-13 Eli Zaretskii <eliz@gnu.org>
9445
9446 * buffer.c (mmap_find): Fix a typo.
9447
cd18e7e3
JB
94482011-07-13 Johan Bockgård <bojohan@gnu.org>
9449
9450 Fix execution of x selection hooks.
9451 * xselect.c (Qx_lost_selection_functions)
9452 (Qx_sent_selection_functions): New vars.
9453 (syms_of_xselect): DEFSYM them.
9454 (x_handle_selection_request): Pass Qx_sent_selection_functions
9455 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9456 (x_handle_selection_clear,x_clear_frame_selections):
9457 Pass Qx_lost_selection_functions rather than
9458 Vx_lost_selection_functions to Frun_hook_with_args.
9459
47ea7f44
PE
94602011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9461
ac389d0c 9462 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9463 The old code sometimes used this field without initializing it.
9464
47ea7f44
PE
9465 * alloc.c (gc_sweep): Don't read past end of array.
9466 In theory, the old code could also have corrupted Emacs internals,
9467 though it'd be very unlikely.
9468
bc985c87
AS
94692011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9470
9471 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9472 argument. (Bug#4026)
bc985c87 9473
0cf34688
LMI
94742011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9475
b3dadd76
LMI
9476 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9477 key" (bug#4257).
9478
0cf34688
LMI
9479 * window.c (Fset_window_start): Doc fix (bug#4199).
9480 (Fset_window_hscroll): Ditto.
9481
270768cd
PE
94822011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9483
077e3dda 9484 Fix minor new problems caught by GCC 4.6.1.
270768cd 9485 * term.c (init_tty): Remove unused local.
490011a6 9486 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9487 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9488 not used otherwise.
270768cd 9489
b1f58454
CY
94902011-07-12 Chong Yidong <cyd@stupidchicken.com>
9491
9492 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9493
22b9578d
LMI
94942011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9495
6e70ab07
LMI
9496 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9497 are the mini-buffer and the echo area (bug#3320).
9498
22b9578d
LMI
9499 * term.c (init_tty): Remove support for supdup, c10 and perq
9500 terminals, which are no longer supported (bug#1482).
9501
8974cc9f
JB
95022011-07-10 Johan Bockgård <bojohan@gnu.org>
9503
9504 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9505
a560d974
JD
95062011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9507
9508 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9509 for non-popups (Bug#3642).
9510
1dae0f0a
AS
95112011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9512
268c2c36 9513 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9514 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9515 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9516 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9517 * data.c (fmod): Likewise.
9518 * dispnew.c (swap_glyphs_in_rows): Likewise.
9519 * emacs.c (memory_warning_signal): Likewise.
9520 * floatfns.c (float_error): Likewise.
9521 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9522 (otf_open, font_otf_capability, generate_otf_features)
9523 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9524 Likewise.
9525 * image.c (pbm_read_file): Likewise.
9526 * indent.c (string_display_width): Likewise.
9527 * intervals.c (check_for_interval, search_for_interval)
9528 (inc_interval_count, count_intervals, root_interval)
9529 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9530 * lread.c (defalias): Likewise.
268c2c36 9531 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9532 * regex.c (set_image_of_range_1, set_image_of_range)
9533 (regex_grow_registers): Likewise.
9534 * sysdep.c (strerror): Likewise.
9535 * termcap.c (valid_filename_p, tprint, main): Likewise.
9536 * tparam.c (main): Likewise.
9537 * unexhp9k800.c (run_time_remap, save_data_space)
9538 (update_file_ptrs, read_header, write_header, calculate_checksum)
9539 (copy_file, copy_rest, display_header): Likewise.
9540 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9541 Likewise.
9542 * xdisp.c (check_it): Likewise.
9543 * xfaces.c (register_color, unregister_color, unregister_colors):
9544 Likewise.
9545 * xfns.c (print_fontset_result): Likewise.
9546 * xrdb.c (member, fatal, main): Likewise.
9547
99033785
PE
95482011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9549
9550 Fix minor problems found by static checking (Bug#9031).
9551 * chartab.c (char_table_set_range, map_sub_char_table):
9552 Remove unused locals.
9553 (uniprop_table): Now static.
9554 * composite.c (_work_char): Remove unused static var.
9555
9cb2ac56
JB
95562011-07-09 Juanma Barranquero <lekktu@gmail.com>
9557
9558 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9559
f25661f0
JD
95602011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9561
9562 * gtkutil.c (qttip_cb): Remove code without function.
9563
8278c4fe
EZ
95642011-07-09 Eli Zaretskii <eliz@gnu.org>
9565
9566 * w32.c (pthread_sigmask): New stub.
9567
1692ae2d 95682011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9569
8a6ebd58 9570 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9571 sigprocmask is portable only for single-threaded applications, and
9572 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9573 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9574 (LIBES): Use it.
9575 * callproc.c (Fcall_process):
9576 * process.c (create_process):
9577 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9578 Use pthread_sigmask, not sigprocmask.
123403e4 9579
1b854618
JD
95802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9581
9582 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9583 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9584 wrong (Bug#8591).
9585
3fe4b549
JD
95862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9587
0ce7e563
JD
9588 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9589 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9590 (xg_hide_tooltip): Fix comment.
9591
3fe4b549
JD
9592 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9593 in registerServicesMenuSendTypes.
9594 (validRequestorForSendType): Don't check ns_return_types.
9595
9596 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9597 ns_return_type.
9598
5df75e47
JR
95992011-07-08 Jason Rumney <jasonr@gnu.org>
9600
22610910
JR
9601 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9602 SH_SHOW for hidden windows (Bug#5482).
9603
5df75e47
JR
9604 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9605 frame struct members of non-existent frames (Bug#6284).
9606
699c10bd
JD
96072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9608
4393663b
JD
9609 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9610 variable firstTime not needed on OSX >= 10.6.
9611 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9612 >= 10.5. Use setKnobProportion, setDoubleValue.
9613
9614 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9615 (MAC_OS_X_VERSION_10_5): Define if not defined.
9616 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9617 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9618 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9619
9620 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9621 cString and lossyCString on OSX >= 10.4.
4393663b 9622
58179cce 9623 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9624 sizeToFit on OSX >= 10.2.
9625
9626 * nsimage.m (allocInitFromFile): Don't use deprecated method
9627 bestRepresentationForDevice on OSX >= 10.6.
9628
9629 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9630 to avoid warning.
9631
9632 * emacs.c: Declare unexec_init_emacs_zone.
9633
a63e0781
JD
9634 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9635
699c10bd
JD
9636 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9637
9638 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9639 on svcsMenu (Bug#8842).
9640
9641 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9642 ns_return_types.
9643 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9644
9645 * nsterm.m (QUTF8_STRING): Declare.
9646 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9647 (validRequestorForSendType): Return type is (id).
9648 Change indexOfObjectIdenticalTo to indexOfObject.
9649 Check if we have local selection before returning self (Bug#8842).
9650 (writeSelectionToPasteboard): Put local selection into paste board
9651 if we have a local selection (Bug#8842).
9652 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9653
9654 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9655 (ns_get_local_selection): Declare.
9656
54e10184
LMI
96572011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9658
9888ff71
LMI
9659 * keymap.c (describe_map_tree): Don't insert a double newline at
9660 the end of the buffer (bug#1169) and return whether we inserted
9661 something.
9662
54e10184
LMI
9663 * callint.c (Fcall_interactively): Change "reading args" to
9664 "providing args" to try to clarify what it does (bug#1010).
9665
15fa4783
KH
96662011-07-07 Kenichi Handa <handa@m17n.org>
9667
9668 * composite.c (composition_compute_stop_pos): Ignore a static
9669 composition starting before CHARPOS (Bug#8915).
9670
9671 * xdisp.c (handle_composition_prop): Likewise.
9672
a8815b00
EZ
96732011-07-07 Eli Zaretskii <eliz@gnu.org>
9674
9675 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9676 (Bug#9015)
9677
ef7b981d 96782011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9679
9680 * character.h (unicode_category_t): New enum type.
9681
9682 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9683 (Qchar_code_property_table): New variable.
9684 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9685 (UNIPROP_COMPRESSED_FORM_P): New macros.
9686 (char_table_ascii): Uncompress the compressed values.
9687 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9688 Uncompress the compressed values.
ac389d0c 9689 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9690 (char_table_ref_and_range): Uncompress the compressed values.
9691 (sub_char_table_set): New arg is_uniprop. Callers changed.
9692 Uncompress the compressed values.
9693 (sub_char_table_set_range): Args changed. Callers changed.
9694 (char_table_set_range): Adjuted for the above change.
9695 (map_sub_char_table): Delete args default_val and parent. Add arg
9696 top. Give decoded values to a Lisp function.
640c8776 9697 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9698 values to a Lisp function. Gcpro more variables.
9699 (uniprop_table_uncompress)
9700 (uniprop_decode_value_run_length): New functions.
9701 (uniprop_decoder, uniprop_decoder_count): New variables.
9702 (uniprop_get_decoder, uniprop_encode_value_character)
9703 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9704 New functions.
9705 (uniprop_encoder, uniprop_encoder_count): New variables.
9706 (uniprop_get_encoder, uniprop_table)
9707 (Funicode_property_table_internal, Fget_unicode_property_internal)
9708 (Fput_unicode_property_internal): New functions.
9709 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9710 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9711 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9712 char-code-property-alist.
9713
640c8776 9714 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9715 Vunicode_category_table.
9716
640c8776 9717 * font.c (font_range): Adjust for the change of
c805dec0
KH
9718 Vunicode_category_table.
9719
76b397fb
DN
97202011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9721
9722 * m/iris4d.h: Remove file, move contents ...
9723 * s/irix6-5.h: ... here.
9724
22b4128e
PE
97252011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9726
9727 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9728 * alloc.c (mark_buffer):
9729 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9730 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9731 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9732 This isn't true in general, and it's particularly not true
9733 if Emacs is configured with --with-wide-int.
9734 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9735 New macros, used in the buffer.c change.
9736
869795d6
JD
97372011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9738
9739 * xsettings.c: Use both GConf and GSettings if both are available.
9740 (store_config_changed_event): Add comment.
9741 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9742 (store_tool_bar_style_changed): New functions.
5e617bc2 9743 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9744 (struct xsettings): Move font inside HAVE_XFT.
9745 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9746 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9747 Move inside HAVE_XFT.
640c8776 9748 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9749 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9750 also.
9751 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9752 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9753 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9754 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9755 (parse_settings): Move check for font inside HAVE_XFT.
9756 (read_settings, apply_xft_settings): Add comment.
9757 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9758 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9759 call store_font_name_changed.
9760 (xft_settings_event): Add comment.
9761 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9762 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9763 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9764 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9765 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9766 (xsettings_get_system_font, xsettings_get_system_normal_font):
9767 Add comment.
869795d6 9768
d8ed26bd
PE
97692011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9770
9771 Random fixes. E.g., (random) never returned negative values.
9772 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9773 subseconds part to the entropy, as that's a bit more random.
9774 Prefer signed to unsigned, since the signedness doesn't matter and
9775 in general we prefer signed. When given a limit, use a
9776 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9777 latter isn't right if USE_2_TAGS_FOR_INTS.
9778 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9779 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9780
cabf1cac
SM
97812011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9782
9783 * textprop.c (text_property_stickiness):
9784 Obey Vtext_property_default_nonsticky.
9785 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9786 * w32fns.c (syms_of_w32fns):
9787 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9788
6e9b2be9
PE
97892011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9790
9791 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9792 This is more efficient than Ffile_directory_p and avoids a minor race.
9793
90186c68
LMI
97942011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9795
7c301272
LMI
9796 * buffer.c (Foverlay_put): Say what the return value is
9797 (bug#7835).
9798
c4f2d8d4
LMI
9799 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9800 is a directory before asking whether to use the file name
9801 (bug#7564).
ad637907
LMI
9802 (barf_or_query_if_file_exists): Make the "File is a directory"
9803 error be more correct.
c4f2d8d4 9804
90186c68
LMI
9805 * fns.c (Frequire): Remove the mention of the .gz files, since
9806 that's installation-specific, but keep the mention of
9807 `get-load-suffixes'.
9808
da64016e
PE
98092011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9810
9811 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9812 Report string overflow if the output is too long.
9813
7d47b580
JB
98142011-07-04 Juanma Barranquero <lekktu@gmail.com>
9815
a555cb87
JB
9816 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9817 (syms_of_gnutls): Remove duplicate DEFSYM for
9818 Qgnutls_bootprop_verify_hostname_error, an error for
9819 Qgnutls_bootprop_verify_error (which is no longer used).
9820
7d47b580
JB
9821 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9822 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9823 Also (re)move comments that are misplaced or no longer relevant.
9824
1e49bfab
LMI
98252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9826
9827 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9828
1485f4c0
CY
98292011-07-03 Chong Yidong <cyd@stupidchicken.com>
9830
9831 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9832 and background color parameters if they have been changed.
9833
a9ab721e
LMI
98342011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9835
9836 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9837
cf7cff57
PE
98382011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9839
2e13213d
PE
9840 * xsettings.c (SYSTEM_FONT): Define only when used.
9841 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9842
cf7cff57
PE
9843 * keymap.c (access_keymap_1): Now static.
9844
7a8e04f7
CY
98452011-07-02 Chong Yidong <cyd@stupidchicken.com>
9846
9847 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9848 leave any prefix arg for the up event (Bug#1586).
9849
61352f62
LMI
98502011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9851
69bb1ef7
LMI
9852 * lread.c (syms_of_lread): Mention single symbols defined by
9853 `defvar' or `defconst' (bug#7154).
9854
61352f62 9855 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9856 (Frequire): Mention get-load-suffixes.
61352f62 9857
28545e04
MR
98582011-07-02 Martin Rudalics <rudalics@gmx.at>
9859
9860 * window.h (window): Remove clone_number slot.
9861 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9862 Remove.
9863 (make_parent_window, make_window, saved_window)
9864 (Fset_window_configuration, save_window_save): Don't deal with
9865 clone numbers.
9866 * buffer.c (Qclone_number): Remove declaration.
9867 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9868
3349e122
SM
98692011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9870
9871 Add multiple inheritance to keymaps.
9872 * keymap.c (Fmake_composed_keymap): New function.
9873 (Fset_keymap_parent): Simplify.
9874 (fix_submap_inheritance): Remove.
9875 (access_keymap_1): New function extracted from access_keymap to handle
9876 embedded parents and handle lists of maps.
9877 (access_keymap): Use it.
9878 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9879 (Fcopy_keymap): Handle embedded parents.
9880 (Fcommand_remapping, define_as_prefix): Simplify.
9881 (Fkey_binding): Simplify.
9882 (syms_of_keymap): Move minibuffer-local-completion-map,
9883 minibuffer-local-filename-completion-map,
9884 minibuffer-local-must-match-map, and
9885 minibuffer-local-filename-must-match-map to Elisp.
9886 (syms_of_keymap): Defsubr make-composed-keymap.
9887 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9888 (parse_menu_item): Trivial simplification.
9889
3279eb87
GM
98902011-07-01 Glenn Morris <rgm@gnu.org>
9891
9892 * Makefile.in (SETTINGS_LIBS): Fix typo.
9893
4550efdf
KI
98942011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9895
9896 * coding.c (Fencode_coding_string): Record the last coding system
9897 used, as the function doc string says (bug#8738).
9898
0949d2b6
JD
98992011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9900
9901 * xsettings.c (store_monospaced_changed): Take new font as arg and
9902 check for change against current_mono_font.
9903 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9904 (emacs_settings_constructor, emacs_settings_get_property)
9905 (emacs_settings_set_property, emacs_settings_class_init)
9906 (emacs_settings_init, gsettings_obj): Remove.
9907 (something_changedCB): New function for HAVE_GSETTINGS.
9908 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9909 with value as argument.
9910 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9911 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9912 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9913 "changed".
9914
9915 * xgselect.c: Add defined (HAVE_GSETTINGS).
9916 (xgselect_initialize): Ditto.
9917
9918 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9919 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9920 xg_select.
9921
bbc6b304
PE
99222011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9923
9924 * eval.c (struct backtrace): Simplify and port the data structure.
9925 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9926 signed bit field, as this assumption is not portable and it makes
9927 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9928 "char debug_on_exit : 1" as this is not portable either; instead,
9929 use the portable "unsigned int debug_on_exit : 1". Remove unused
9930 member evalargs. Remove obsolete comments about cc bombing out.
9931
9851bfc5
JD
99322011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9933
51bb811f 9934 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9935 Let HAVE_GSETTINGS override HAVE_GCONF.
9936 (store_monospaced_changed): New function.
9937 (EMACS_SETTINGS): A new type derived from GObject to handle
9938 GSettings notifications.
9939 (emacs_settings_constructor, emacs_settings_get_property)
9940 (emacs_settings_set_property, emacs_settings_class_init):
9941 New functions.
9942 (gsettings_client, gsettings_obj): New variables.
9943 (GSETTINGS_SCHEMA): New define.
9944 (something_changedCB): Call store_monospaced_changed.
9945 (init_gsettings): New function.
9946 (xsettings_initialize): Call init_gsettings.
9947 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9948 to NULL.
9949
640c8776 9950 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9951 GCONF_CFLAGS/LIBS.
9952
5386012d
MR
99532011-06-29 Martin Rudalics <rudalics@gmx.at>
9954
9955 * window.c (resize_root_window, grow_mini_window)
9956 (shrink_mini_window): Rename Qresize_root_window to
9957 Qwindow_resize_root_window and Qresize_root_window_vertically to
9958 Qwindow_resize_root_window_vertically.
9959
f13e0b08
PE
99602011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9961
9962 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9963
94515237
JB
99642011-06-27 Juanma Barranquero <lekktu@gmail.com>
9965
9966 * makefile.w32-in: Redesign dependencies so they reflect more
9967 clearly which files are directly included by each source file,
9968 and not through other includes.
9969
e43b6e43
MR
99702011-06-27 Martin Rudalics <rudalics@gmx.at>
9971
9972 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9973 (sort_overlays, overlay_strings): When an overlay's clone number
9974 matches the window's clone number process the overlay even if
9975 the overlay's window property doesn't match the current window.
9976
d68443dc
MR
9977 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9978 (Fwindow_hchild): Rename to Fwindow_left_child.
9979 (Fwindow_next): Rename to Fwindow_next_sibling.
9980 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9981 (resize_window_check): Rename to window_resize_check.
9982 (resize_window_apply): Rename to window_resize_apply.
9983 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9984 (Fdelete_other_windows_internal, resize_frame_windows)
9985 (Fsplit_window_internal, Fdelete_window_internal)
9986 (grow_mini_window, shrink_mini_window)
9987 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9988
c7e73be5
JD
99892011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9990
9991 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9992 (emacs_fixed_set_min_size): Remove.
9993 (emacs_fixed_new): Take frame as argument.
9994
9995 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9996 (_EmacsFixedPrivate): Remove minwidth/height.
9997 Add struct frame *f.
9998 (emacs_fixed_init): Initialize priv->f.
9999 (get_parent_class, emacs_fixed_set_min_size): Remove.
10000 (emacs_fixed_new): Set priv->f to argument.
10001 (emacs_fixed_get_preferred_width)
10002 (emacs_fixed_get_preferred_height): Use min_width/height from
10003 frames size_hint to set minimum and natural (Bug#8919).
10004 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10005 and use min_width/height from frames size_hint to set
10006 min_width/height (Bug#8919).
10007
10008 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10009 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10010 Fix indentation.
c7e73be5 10011
cf99dcf8
EZ
100122011-06-26 Eli Zaretskii <eliz@gnu.org>
10013
10014 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10015 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10016 called at ZV.
10017
029529ac
CY
100182011-06-26 Chong Yidong <cyd@stupidchicken.com>
10019
10020 * process.c (wait_reading_process_output): Bypass select if
10021 waiting for a cell while ignoring keyboard input, and input is
10022 pending. Suggested by Jan Djärv (Bug#8869).
10023
7a7ef429
PE
100242011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10025
10026 Use gnulib's dup2 module instead of rolling our own.
10027 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10028
11fdef7d 100292011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10030
10031 * dispnew.c (scrolling_window): Before scrolling, turn off a
10032 mouse-highlight in the window being scrolled.
10033
cd3520a4
JB
100342011-06-24 Juanma Barranquero <lekktu@gmail.com>
10035
10036 Move DEFSYM to lisp.h and use everywhere.
10037
10038 * character.h (DEFSYM): Move declaration...
10039 * lisp.h (DEFSYM): ...here.
10040
10041 * gnutls.c:
10042 * minibuf.c:
10043 * w32menu.c:
10044 * w32proc.c:
10045 * w32select.c: Don't include character.h.
10046
10047 * alloc.c (syms_of_alloc):
10048 * buffer.c (syms_of_buffer):
10049 * bytecode.c (syms_of_bytecode):
10050 * callint.c (syms_of_callint):
10051 * casefiddle.c (syms_of_casefiddle):
10052 * casetab.c (init_casetab_once):
10053 * category.c (init_category_once, syms_of_category):
10054 * ccl.c (syms_of_ccl):
10055 * cmds.c (syms_of_cmds):
10056 * composite.c (syms_of_composite):
10057 * dbusbind.c (syms_of_dbusbind):
10058 * dired.c (syms_of_dired):
10059 * dispnew.c (syms_of_display):
10060 * doc.c (syms_of_doc):
10061 * editfns.c (syms_of_editfns):
10062 * emacs.c (syms_of_emacs):
10063 * eval.c (syms_of_eval):
10064 * fileio.c (syms_of_fileio):
10065 * fns.c (syms_of_fns):
10066 * frame.c (syms_of_frame):
10067 * fringe.c (syms_of_fringe):
10068 * insdel.c (syms_of_insdel):
10069 * keymap.c (syms_of_keymap):
10070 * lread.c (init_obarray, syms_of_lread):
10071 * macros.c (syms_of_macros):
10072 * msdos.c (syms_of_msdos):
10073 * print.c (syms_of_print):
10074 * process.c (syms_of_process):
10075 * search.c (syms_of_search):
10076 * sound.c (syms_of_sound):
10077 * syntax.c (init_syntax_once, syms_of_syntax):
10078 * terminal.c (syms_of_terminal):
10079 * textprop.c (syms_of_textprop):
10080 * undo.c (syms_of_undo):
10081 * w32.c (globals_of_w32):
10082 * window.c (syms_of_window):
10083 * xdisp.c (syms_of_xdisp):
10084 * xfaces.c (syms_of_xfaces):
10085 * xfns.c (syms_of_xfns):
10086 * xmenu.c (syms_of_xmenu):
10087 * xsettings.c (syms_of_xsettings):
10088 * xterm.c (syms_of_xterm): Use DEFSYM.
10089
4228cf16
TZ
100902011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10091
cd3520a4 10092 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10093
7fcccf1e
PE
100942011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10095
7efb4e0e
PE
10096 Integer and buffer overflow fixes (Bug#8873).
10097
ff5844ad
PE
10098 * print.c (printchar, strout): Check for string overflow.
10099 (PRINTPREPARE, printchar, strout):
10100 Don't set size unless allocation succeeds.
10101
90532f02
PE
10102 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10103 for sizes. Check for string overflow more accurately.
10104 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10105
6d84508d
PE
10106 * macros.c: Integer and buffer overflow fixes.
10107 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10108 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10109 Use ptrdiff_t, not int, for sizes.
10110 Don't increment bufsize until after realloc succeeds.
10111 Check for size-calculation overflow.
10112 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10113
437b2cb4
PE
10114 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10115
8b9ac8b4
PE
10116 * lread.c: Integer overflow fixes.
10117 (read_integer): Radix is now EMACS_INT, not int,
10118 to improve quality of diagnostics for out-of-range radices.
10119 Calculate buffer size correctly for out-of-range radices.
10120 (read1): Check for integer overflow in radices, and in
10121 read-circle numbers.
82cb60d3
PE
10122 (read_escape): Avoid int overflow.
10123 (Fload, openp, read_buffer_size, read1)
10124 (substitute_object_recurse, read_vector, read_list, map_obarray):
10125 Use ptrdiff_t, not int, for sizes.
10126 (read1): Use EMACS_INT, not int, for sizes.
20270765 10127 Check for size overflow.
8b9ac8b4 10128
7fcccf1e
PE
10129 * image.c (cache_image): Check for size arithmetic overflow.
10130
bfbbd7e7
PE
10131 * lread.c: Integer overflow issues.
10132 (saved_doc_string_size, saved_doc_string_length)
10133 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10134 Now ptrdiff_t, not int.
10135 (read1): Don't assume doc string length fits in int. Check for
10136 out-of-range doc string lengths.
10137 (read_list): Don't assume file position fits in int.
39019e54 10138 (read_escape): Check for hex character overflow.
bfbbd7e7 10139
4e323265
LL
101402011-06-22 Leo Liu <sdl.web@gmail.com>
10141
10142 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10143 Move to minibuffer.el.
10144
85fece3e
PE
101452011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10146
20b84ce9 10147 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10148 The following patches are for when GLYPH_DEBUG && !XASSERT.
10149 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10150 * dispnew.c (flush_stdout):
10151 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10152 Mark as externally visible.
10153 * dispnew.c (check_window_matrix_pointers): Now static.
10154 * dispnew.c (window_to_frame_vpos):
10155 * xfns.c (unwind_create_frame):
10156 * xterm.c (x_check_font): Remove unused local.
10157 * scroll.c (CHECK_BOUNDS):
10158 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10159 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10160 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10161 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10162 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10163 Now static.
10164 (debug_method_add): Use va_list and vsprintf rather than relying
10165 on undefined behavior with wrong number of arguments.
10166 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10167 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10168 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10169 since we're not interested in debugging glyphs with old libraries.
10170 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10171 GCC 4.6.0's static checking.
10172
0766b489
PE
101732011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10174
31fd4b32
PE
10175 Integer overflow and signedness fixes (Bug#8873).
10176 A few related buffer overrun fixes, too.
10177
b79e8648
PE
10178 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10179
0766b489
PE
10180 * dispextern.h (struct face.stipple):
10181 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10182 (x_bitmap_mask, x_allocate_bitmap_record)
10183 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10184 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10185 (x_create_bitmap_from_xpm_data):
10186 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10187 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10188 (.bitmaps_last):
10189 * xfaces.c (load_pixmap):
10190 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10191 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10192 (.bitmaps_last, struct x_output.icon_bitmap):
10193 Use ptrdiff_t, not int, for bitmap indexes.
10194 (x_allocate_bitmap_record): Check for size overflow.
10195 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10196
b081724f
PE
10197 Use ptrdiff_t, not int, for overlay counts.
10198 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10199 * editfns.c (overlays_around, get_pos_property):
10200 * textprop.c (get_char_property_and_overlay):
10201 * xdisp.c (next_overlay_change, note_mouse_highlight):
10202 * xfaces.c (face_at_buffer_position):
21514da7
PE
10203 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10204 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10205 (Fnext_overlay_change, Fprevious_overlay_change)
10206 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10207 Use ptrdiff_t, not int, for sizes.
21514da7 10208 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10209
3de73e5e
PE
10210 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10211
2606c57b
PE
10212 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10213 (x_session_initialize): Do not assume string length fits in int.
10214
aaafe47a
PE
10215 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10216 This is unlikely, but can occur if DPI is outlandish.
10217
2674ddc8 10218 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10219 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10220
28154962
PE
10221 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10222 * xrdb.c (magic_file_p, search_magic_path):
10223 Omit last arg SUFFIX; it was always 0. All callers changed.
10224 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10225
7de51af5
PE
10226 * xfont.c (xfont_match): Avoid need for strlen.
10227
25ed6cc3
PE
10228 * xfns.c: Don't assume strlen fits in int.
10229 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10230
4eab31dd
PE
10231 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10232 not unsigned long, as we prefer signed integers. All callers changed.
10233 Detect integer overflow in repeat count.
10234 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10235 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10236
171e2a58
PE
10237 * termcap.c: Don't assume sizes fit in int and never overflow.
10238 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10239 (gobble_line): Check for size-calculation overflow.
10240
ad39faca 10241 * minibuf.c (Fread_buffer):
6e5bb2dc 10242 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10243 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10244 Don't assume string length fits in int.
10245
52c61c22 10246 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10247 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10248
b5b8c9e5
PE
10249 * font.c: Don't assume string length fits in int.
10250 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10251 Use ptrdiff_t, not int.
ccd6111c
PE
10252 (font_intern_prop): Don't assume string length fits in int.
10253 Don't assume integer property fits in fixnum.
10254 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10255
882f0d81 10256 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10257 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10258 Reformulate so as not to need the command string.
10259 Invoke gzip -cd rather than gunzip, as it's more portable.
10260 (lock_info_type, lock_file_1, lock_file):
10261 Don't assume pid_t and time_t fit in unsigned long.
10262 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10263 (current_lock_owner): Prefer signed type for sizes.
10264 Use memcpy, not strncpy, where memcpy is what is really wanted.
10265 Don't assume (via atoi) that time_t and pid_t fit in int.
10266 Check for time_t and/or pid_t out of range, e.g., via a network share.
10267 Don't alloca where an auto var works fine.
10268
93f4cf88
PE
10269 * fileio.c: Fix some integer overflow issues.
10270 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10271 Don't assume string length fits in int.
10272 (directory_file_name): Don't assume string length fits in long.
10273 (make_temp_name): Don't assume pid fits in int, or that its print
10274 length is less than 20.
10275
f3e92b69
PE
10276 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10277
1bfdaf10
PE
10278 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10279
35016e9a
PE
10280 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10281
3d1e65a1
PE
10282 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10283 We prefer signed integers, even for size calculations.
10284
0b963a93
PE
10285 * emacs.c: Don't assume string length fits in 'int'.
10286 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10287 (main): Don't invoke strlen when not needed.
10288
573f4b54
PE
10289 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10290 (XD_DEBUG_MESSAGE): Don't waste a byte.
10291
989f33ba
PE
10292 * callproc.c (getenv_internal_1, getenv_internal)
10293 (Fgetenv_internal):
965d34eb
PE
10294 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10295
e4d29b33
PE
10296 * lread.c (invalid_syntax): Omit length argument.
10297 All uses changed. This doesn't fix a bug, but it simplifies the
10298 code away from its former Hollerith-constant appearance, and it's
10299 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10300 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10301
eb49b136
PE
10302 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10303 This didn't break anything, but it didn't help either.
10304 It's confusing to put a bogus integer in a place where the actual
10305 value does not matter.
9f62aeb1 10306 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10307 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10308
15375a22
PE
10309 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10310 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10311 implementation.
b61cc01c
PE
10312 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10313 We prefer signed types, and the value cannot exceed the EMACS_INT
10314 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10315 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10316 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10317 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10318
53b2623d
PE
10319 * indent.c (sane_tab_width): New function.
10320 (current_column, scan_for_column, Findent_to, position_indentation)
10321 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10322 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10323
51cab52b 10324 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10325
f2ed8a70
PE
10326 * lisp.h (lint_assume): New macro.
10327 * composite.c (composition_gstring_put_cache):
10328 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10329
abe80cc6
PE
10330 * editfns.c, insdel.c:
10331 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10332
b02c740e
PE
10333 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10334
ebc96716
PE
10335 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10336
b4e50fa0 10337 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10338 Use much-faster test for byte-length change.
311d5d7c 10339 Don't assume string byte-length fits in 'int'.
a4cf38e4 10340 Check that character arg fits in 'int'.
85461888 10341 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10342
c0c1ee9f
PE
10343 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10344
a498d7f4
PE
10345 * fns.c (concat): Catch string overflow earlier.
10346 Do not rely on integer wraparound.
10347
51cab52b
PE
10348 * dispextern.h (struct it.overlay_strings_charpos)
10349 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10350 * xdisp.c (forward_to_next_line_start)
10351 (back_to_previous_visible_line_start)
10352 (reseat_at_next_visible_line_start, next_element_from_buffer):
10353 Don't arbitrarily truncate the value of 'selective' to int.
10354
76031fad
PE
10355 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10356
5eb55db9
PE
10357 * composite.c: Don't truncate sizes to 'int'.
10358 (composition_gstring_p, composition_reseat_it)
10359 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10360 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10361 not EMACS_UINT, for indexes.
5eb55db9 10362
0703a717
PE
10363 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10364
d6202519
PE
10365 * buffer.c: Include <verify.h>.
10366 (struct sortvec.priority, struct sortstr.priority):
8961a454 10367 Now EMACS_INT, not int.
c20998a7 10368 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10369 (struct sortstr.size, record_overlay_string)
10370 (struct sortstrlist.size, struct sortlist.used):
10371 Don't truncate size to int.
10372 (record_overlay_string): Check for size-calculation overflow.
d6202519 10373 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10374
d5a19415
JM
103752011-06-22 Jim Meyering <meyering@redhat.com>
10376
029529ac 10377 Don't leak an XBM-image-sized buffer
d5a19415
JM
10378 * image.c (xbm_load): Free the image buffer after using it.
10379
a9041e6c
PE
103802011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10381
10382 Port to Sun C.
10383 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10384 that Sun C diagnosed.
10385 * fns.c (secure_hash): Fix pointer signedness issue.
10386 * intervals.c (static_offset_intervals): New function.
10387 (offset_intervals): Use it.
10388
7f3f739f
LL
103892011-06-21 Leo Liu <sdl.web@gmail.com>
10390
10391 * deps.mk (fns.o):
10392 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10393 sha512.h.
10394
10395 * fns.c (secure_hash): Rename from crypto_hash_function and change
10396 the first arg to accept symbols.
5b66d427 10397 (Fsecure_hash): New primitive.
7f3f739f
LL
10398 (syms_of_fns): New symbols.
10399
76147d94
DD
104002011-06-20 Deniz Dogan <deniz@dogan.se>
10401
10402 * process.c (Fset_process_buffer): Clarify return value in
10403 docstring.
10404
7d7d0045
CY
104052011-06-18 Chong Yidong <cyd@stupidchicken.com>
10406
10407 * dispnew.c (add_window_display_history): Use BVAR.
10408
10409 * xdisp.c (debug_method_add): Use BVAR.
10410 (check_window_end, dump_glyph_matrix, dump_glyph)
10411 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10412
10413 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10414 Likewise.
10415
10416 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10417 check till after the cache is created in init_frame_faces.
10418
ff2bc410
SM
104192011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10420
10421 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10422
28177add
PE
104232011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10424
dd3482fe
PE
10425 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10426 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10427 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10428
393d71f3 10429 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10430 * fileio.c (Finsert_file_contents):
10431 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10432 Remove the old (too-loose) buffer overflow checks.
10433 They weren't needed, since make_gap checks for buffer overflow.
10434 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10435 The old code merely checked for Emacs fixnum overflow, and relied
10436 on undefined (wraparound) behavior. The new code avoids undefined
10437 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10438
2e6813b0 10439 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10440 Tune. Don't use wider integers than needed. Don't use alloca.
10441 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10442
599a9e4f
PE
10443 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10444
99561444
PE
10445 * insdel.c, lisp.h (buffer_overflow): New function.
10446 (insert_from_buffer_1, replace_range, replace_range_2):
10447 * insdel.c (make_gap_larger):
10448 * editfns.c (Finsert_char):
10449 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10450
28177add
PE
10451 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10452
e69dafad
PE
104532011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10454
4baa020d 10455 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10456
b1c46f02
PE
10457 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10458 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10459
e69dafad
PE
10460 * fileio.c: Don't assume EMACS_INT fits in off_t.
10461 (emacs_lseek): New static function.
10462 (Finsert_file_contents, Fwrite_region): Use it.
10463 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10464
566684ea
PE
10465 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10466
e6966cd6
PE
10467 * fns.c: Don't overflow int when computing a list length.
10468 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10469 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10470 truncation on 64-bit hosts. Check for QUIT every
10471 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10472 faster and is responsive enough.
10473 (Flength): Report an error instead of overflowing an integer.
10474 (Fsafe_length): Return a float if the value is not representable
10475 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10476 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10477 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10478
dd0b0efb
PE
10479 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10480 (header_size, word_size): New constants.
10481 (allocate_vectorlike): Don't check size overflow here.
10482 (allocate_vector): Check it here instead, since this is the only
10483 caller of allocate_vectorlike that could cause overflow.
10484 Check that the new vector's length is representable as a fixnum.
10485
86fe5cfe
PE
10486 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10487 The previous code was bogus. For example, next_almost_prime (32)
10488 returned 39, which is undesirable as it is a multiple of 3; and
10489 next_almost_prime (24) returned 25, which is a multiple of 5 so
10490 why was the code bothering to check for multiples of 7?
10491
80e88859
PE
10492 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10493
4a2f0ad6
PE
10494 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10495
f66c7cf8
PE
10496 Variadic C functions now count arguments with ptrdiff_t.
10497 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10498 Back then I didn't know that the Emacs coding style prefers signed int.
10499 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10500 were being counted with int, which may truncate counts on 64-bit
10501 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10502 * lisp.h (struct Lisp_Subr.function.aMANY)
10503 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10504 Arg counts are now ptrdiff_t, not size_t.
10505 All variadic functions and their callers changed accordingly.
10506 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10507 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10508 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10509 * callint.c (Fcall_interactively): Check arg count for overflow,
10510 to avoid potential buffer overrun. Use signed char, not 'int',
10511 for 'varies' array, so that we needn't bother to check its size
10512 calculation for overflow.
10513 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10514 * eval.c (apply_lambda):
10515 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10516 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10517 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10518
a1759b76
PE
10519 * callint.c (Fcall_interactively): Don't use index var as event count.
10520
d96be9fc
PE
10521 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10522 * mem-limits.h (SIZE): Remove; no longer used.
10523
a690a978 10524 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10525
578c21e6
PE
10526 Remove unnecessary casts.
10527 * xterm.c (x_term_init):
10528 * xfns.c (x_set_border_pixel):
10529 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10530 These aren't needed now that we assume ANSI C.
10531
96f53c6c
PE
10532 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10533 It's more likely to cause problems (due to unsigned overflow)
10534 than to cure them.
10535
83c77d31
PE
10536 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10537
ee2079f1
PE
10538 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10539
6da65536
PE
10540 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10541
7147c4a4
PE
10542 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10543
193e32d9
PE
10544 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10545
e5533da6
PE
10546 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10547
9910e595
PE
10548 GLYPH_CODE_FACE returns EMACS_INT, not int.
10549 * dispextern.h (merge_faces):
10550 * xfaces.c (merge_faces):
01103c44
PE
10551 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10552 Don't assume EMACS_INT fits in int.
9910e595 10553
2638320e
PE
10554 * character.h (CHAR_VALID_P): Remove unused parameter.
10555 * fontset.c, lisp.h, xdisp.c: All uses changed.
10556
045eb8d9
PE
10557 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10558
c1f134b5
PE
10559 * fns.c (concat): Minor tuning based on overflow analysis.
10560 This doesn't fix any bugs. Use int to hold character, instead
10561 of constantly refetching from Emacs object. Use XFASTINT, not
10562 XINT, for value known to be a character. Don't bother comparing
10563 a single byte to 0400, as it's always less.
10564
395fcb93 10565 * floatfns.c (Fexpt):
327eeec8
PE
10566 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10567
abbd3d23
PE
10568 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10569 for characters.
10570
684a03ef
PE
10571 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10572
0fed43f3
PE
10573 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10574 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10575 incorrectly succeed when S was a string, because 4294967386 was
10576 truncated before it was used.
10577
8fd02eb7
PE
10578 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10579 Otherwise, an out-of-range integer could cause undefined behavior
10580 on a 64-bit host.
10581
f8c86b69
PE
10582 * composite.c: Use int, not EMACS_INT, for characters.
10583 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10584 EMACS_INT, for values that are known to be in character range.
10585 This doesn't fix any bugs but is the usual style inside Emacs and
10586 may generate better code on 32-bit machines.
10587
34206dd2
PE
10588 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10589 This is for reasons similar to the recent CHAR_STRING fix.
10590 * charset.c (Fencode_char): Check that character arg is actually
10591 a character. Pass an int to ENCODE_CHAR.
10592 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10593 wider than 'int', as a compile-time check to prevent future regressions
10594 in this area.
10595
c5958d4c 10596 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10597
10598 Make sure a 64-bit char is never passed to CHAR_STRING.
10599 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10600 by silently ignoring the top 32 bits, allowing some values
10601 that were far too large to be valid characters.
10602 * character.h: Include <verify.h>.
10603 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10604 arguments are no wider than unsigned, as a compile-time check
10605 to prevent future regressions in this area.
10606 * data.c (Faset):
01103c44 10607 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10608 (Fsubst_char_in_region):
10609 * fns.c (concat):
10610 * xdisp.c (decode_mode_spec_coding):
10611 Adjust to CHAR_STRING's new requirement.
10612 * editfns.c (Finsert_char, Fsubst_char_in_region):
10613 * fns.c (concat): Check that character args are actually
10614 characters. Without this test, these functions did the wrong
10615 thing with wildly out-of-range values on 64-bit hosts.
10616
d37ca623
PE
10617 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10618 These casts should not be needed on 32-bit hosts, either.
10619 * keyboard.c (read_char):
10620 * lread.c (Fload): Remove casts to unsigned.
10621
ea204efb
PE
10622 * lisp.h (UNSIGNED_CMP): New macro.
10623 This fixes comparison bugs on 64-bit hosts.
10624 (ASCII_CHAR_P): Use it.
10625 * casefiddle.c (casify_object):
01103c44 10626 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10627 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10628 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10629 * dispextern.h (FACE_FROM_ID):
10630 * keyboard.c (read_char): Use UNSIGNED_CMP.
10631
41cb286c
PE
10632 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10633 not to EMACS_INT, to avoid GCC warning.
10634
4a1b9832
PE
10635 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10636
55daad71
PE
10637 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10638 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10639 isn't needed on 32-bit machines.
8f95c75c 10640
01103c44
PE
10641 * buffer.c (Fgenerate_new_buffer_name):
10642 Use EMACS_INT for count, not int.
0ceccced 10643 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10644
10645 * data.c (Qcompiled_function): Now static.
10646
c6f072e7
PE
10647 * window.c (window_body_lines): Now static.
10648
20ce5912
PE
10649 * image.c (gif_load): Rename local to avoid shadowing.
10650
9c4c5f81
PE
10651 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10652 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10653 * alloc.c (make_save_value): Integer argument is now of type
10654 ptrdiff_t, not int.
10655 (mark_object): Use ptrdiff_t, not int.
10656 * lisp.h (pD): New macro.
10657 * print.c (print_object): Use it.
10658
c0c5c8ae
PE
10659 * alloc.c: Use EMACS_INT, not int, to count objects.
10660 (total_conses, total_markers, total_symbols, total_vector_size)
10661 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10662 (total_free_floats, total_floats, total_free_intervals)
10663 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10664 Now EMACS_INT, not int. All uses changed.
10665 (Fgarbage_collect): Compute overall total using a double, so that
10666 integer overflow is less likely to be a problem. Check for overflow
10667 when converting back to an integer.
5a25e253
PE
10668 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10669 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10670 These were 'int' variables that could overflow on 64-bit hosts;
10671 they were never used, so remove them instead of repairing them.
211a0b2a 10672 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10673 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10674 Previously, this ceilinged at INT_MAX, but that doesn't work on
10675 64-bit machines.
e46bb31a 10676 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10677
c78baabf 10678 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10679 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10680 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10681 when a (possibly-narrower) signed value would do just as well.
10682 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10683
c9d624c6
PE
10684 * alloc.c: Catch some string size overflows that we were missing.
10685 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10686 for convenience in STRING_BYTES_MAX.
10687 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10688 The definition here is exact; the one in lisp.h was approximate.
10689 (allocate_string_data): Check for string overflow. This catches
10690 some instances we weren't catching before. Also, it catches
10691 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10692 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10693 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10694
c9d624c6
PE
10695 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10696 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10697 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10698
353032ce
PE
10699 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10700
2bccce07
PE
10701 * alloc.c (Fmake_string): Check for out-of-range init.
10702
0ac30604
SM
107032011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10704
10705 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10706
c195f2de
JD
107072011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10708
10709 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10710 xg_get_default_scrollbar_width.
10711
10712 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10713 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10714 (style_changed_cb): Call update_theme_scrollbar_width and call
10715 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10716 all frames (Bug#8505).
10717 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10718 Call gtk_window_set_resizable if HAVE_GTK3.
10719 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10720 and height if HAVE_GTK3 (Bug#8505).
10721 (scroll_bar_width_for_theme): New variable.
10722 (update_theme_scrollbar_width): New function.
10723 (xg_get_default_scrollbar_width): Move code to
10724 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10725 (xg_initialize): Call update_theme_scrollbar_width.
10726
10727 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10728
10729 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10730
e10ac9f1
MR
107312011-06-12 Martin Rudalics <rudalics@gmx.at>
10732
10733 * frame.c (make_frame): Call other_buffer_safely instead of
10734 other_buffer.
10735
10736 * window.c (temp_output_buffer_show): Call display_buffer with
10737 second argument Vtemp_buffer_show_specifiers and reset latter
10738 immediately after the call.
10739 (Vtemp_buffer_show_specifiers): New variable.
10740 (auto_window_vscroll_p, next_screen_context_lines)
10741 (Vscroll_preserve_screen_position): Remove leading asterisks from
10742 doc-strings.
10743
2d3c217e 107442011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10745
7b7f97e8 10746 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10747 * buffer.c (Qclone_number): Remove for now, as it's unused.
10748 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10749 (record_buffer): Remove unused local.
10750 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10751 (set_frame_buffer_list): Remove; unused.
10752 * frame.h (other_visible_frames): Remove decl.
10753 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10754 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10755 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10756 if HAVE_GPM.
10757 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10758 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10759 Define only if HAVE_GPM.
10760 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10761 (update_hints_inhibit): Remove; never set. All uses removed.
10762 * widgetprv.h (emacsFrameClassRec): Remove decl.
10763 * window.c (delete_deletable_window): Now returns void, since it
10764 wasn't returning anything.
10765 (compare_window_configurations): Remove unused locals.
10766 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10767 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10768 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10769 the same widths as pointers. This follows up on the 2011-05-06 patch.
10770 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10771 * xterm.h: Likewise.
10772 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10773
1384b89e
JB
107742011-06-12 Juanma Barranquero <lekktu@gmail.com>
10775
10776 * makefile.w32-in: Update dependencies.
10777 (LISP_H): Add lib/intprops.h.
10778
1100a63c
CY
107792011-06-11 Chong Yidong <cyd@stupidchicken.com>
10780
10781 * image.c (gif_load): Add animation frame delay to the metadata.
10782 (syms_of_image): Use DEFSYM. New symbol `delay'.
10783
6198ccd0
MR
107842011-06-11 Martin Rudalics <rudalics@gmx.at>
10785
10786 * window.c (delete_deletable_window): Re-add.
10787 (Fset_window_configuration): Rewrite to handle dead buffers and
10788 consequently deletable windows.
10789 (window_tree, Fwindow_tree): Remove. Supply functionality in
10790 window.el.
10791 (compare_window_configurations): Simplify code.
10792
b6e3633c
AS
107932011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10794
1ab0dee5
AS
10795 * image.c (imagemagick_load_image): Fix type mismatch.
10796 (Fimagemagick_types): Likewise.
10797
b6e3633c
AS
10798 * window.h (replace_buffer_in_windows): Declare.
10799
9397e56f
MR
108002011-06-11 Martin Rudalics <rudalics@gmx.at>
10801
10802 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10803 Qclone_number. Remove external declaration of Qdelete_window.
10804 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10805 code.
640c8776
SM
10806 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10807 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10808 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10809 buffer list implementation.
10810 (other_buffer_safely): New function.
10811 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10812 calls to replace_buffer_in_windows and
10813 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10814 if allowed.
10815 (record_buffer): Inhibit quitting and rewrite using quittable
10816 functions. Run Qbuffer_list_update_hook if allowed.
10817 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10818 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10819 Move switch-to-buffer to window.el.
9397e56f
MR
10820 (bury-buffer): Move to window.el.
10821 (Vbuffer_list_update_hook): New variable.
10822
10823 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10824 section.
10825
10826 * window.h (resize_frame_windows): Move up in code.
10827 (Fwindow_frame): Remove EXFUN.
10828 (replace_buffer_in_all_windows): Remove prototype.
10829 (replace_buffer_in_windows_safely): Add prototype.
10830
10831 * window.c: Declare Qdelete_window static again. Move down
10832 declaration of select_count.
10833 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10834 (Fother_window): Move to window.el.
10835 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10836 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10837 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10838 window.el.
10839 (replace_buffer_in_windows): Implement by calling
10840 Qreplace_buffer_in_windows.
10841 (replace_buffer_in_all_windows): Remove with some functionality
10842 moved into replace_buffer_in_windows_safely.
10843 (replace_buffer_in_windows_safely): New function.
10844 (select_window_norecord, select_frame_norecord): Move in front
10845 of run_window_configuration_change_hook. Remove now obsolete
10846 declarations.
640c8776
SM
10847 (Fset_window_buffer): Rewrite doc-string.
10848 Call Qrecord_window_buffer.
9397e56f
MR
10849 (keys_of_window): Move binding for other-window to window.el.
10850
b50691aa
CY
108512011-06-11 Chong Yidong <cyd@stupidchicken.com>
10852
10853 * dispextern.h (struct image): Replace data member, whose int_val
10854 and ptr_val fields were not used by anything, with a single
10855 lisp_val object.
10856
10857 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10858 (gif_clear_image, gif_load, imagemagick_load_image)
10859 (gs_clear_image, gs_load): Callers changed.
10860
3f754b86
PE
108612011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10862
cca69397
PE
10863 * buffer.h: Include <time.h>, for time_t.
10864 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10865
109e28d0
PE
10866 Fix minor problems found by static checking.
10867
60737f02
PE
10868 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10869
4b66faf3
PE
10870 Make identifiers static if they are not used in other modules.
10871 * data.c (Qcompiled_function, Qframe, Qvector):
10872 * image.c (QimageMagick, Qsvg):
10873 * minibuf.c (Qmetadata):
10874 * window.c (resize_window_check, resize_root_window): Now static.
10875 * window.h (resize_window_check, resize_root_window): Remove decls.
10876
109e28d0
PE
10877 * window.c (window_deletion_count, delete_deletable_window):
10878 Remove; unused.
46a4ce9e
PE
10879 (window_body_lines): Now static.
10880 (Fdelete_other_windows_internal): Mark vars as initialized.
10881 Make sure 'resize_failed' is initialized.
10882 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10883 (resize_window_apply): Remove unused local.
10884 * window.h (delete_deletable_window): Remove decl.
10885
109e28d0 10886 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10887 (imagemagick_load_image): Fix pointer signedness problem by changing
10888 last arg from unsigned char * to char *. All uses changed.
10889 Also, fix a local for similar reasons.
10890 Remove unused locals. Remove locals to avoid shadowing.
10891 (fn_rsvg_handle_free): Remove; unused.
10892 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10893 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10894
3f754b86
PE
10895 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10896
2547adb1
CY
108972011-06-10 Chong Yidong <cyd@stupidchicken.com>
10898
10899 * image.c (gif_load): Fix omitted cast error introduced by
10900 2011-06-06 change.
10901
2c8e37d4
MR
109022011-06-10 Martin Rudalics <rudalics@gmx.at>
10903
10904 * window.h (resize_proportionally, orig_total_lines)
10905 (orig_top_line): Remove from window structure.
10906 (set_window_height, set_window_width, change_window_heights)
10907 (Fdelete_window): Remove prototypes.
10908 (resize_frame_windows): Remove duplicate declaration.
10909
440a42e3
EZ
109102011-06-10 Eli Zaretskii <eliz@gnu.org>
10911
10912 * window.h (resize_frame_windows, resize_window_check)
10913 (delete_deletable_window, resize_root_window)
10914 (resize_frame_windows): Declare prototypes.
10915
10916 * window.c (resize_window_apply): Make definition be "static" to
10917 match the prototype.
10918
562dd5e9
MR
109192011-06-10 Martin Rudalics <rudalics@gmx.at>
10920
10921 * window.c: Remove declarations of Qwindow_size_fixed,
10922 window_min_size_1, window_min_size_2, window_min_size,
10923 size_window, window_fixed_size_p, enlarge_window, delete_window.
10924 Remove static from declaration of Qdelete_window, it's
10925 temporarily needed by Fbury_buffer.
10926 (replace_window): Don't assign orig_top_line and
10927 orig_total_lines.
10928 (Fdelete_window, delete_window): Remove. Window deletion is
10929 handled by window.el.
640c8776
SM
10930 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10931 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10932 (Fdelete_other_windows): Remove. Deleting other windows is
10933 handled by window.el.
10934 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10935 handled in window.el.
10936 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10937 Window minimum sizes are handled in window.el.
10938 (shrink_windows, size_window, set_window_height)
10939 (set_window_width, change_window_heights, window_height)
10940 (window_width, CURBEG, CURSIZE, enlarge_window)
10941 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10942 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10943 handled in window.el.
10944 (make_dummy_parent): Rename to make_parent_window and give it a
10945 second argument horflag.
10946 (make_window): Don't set resize_proportionally any more.
10947 (Fsplit_window): Remove. Windows are split in window.el.
10948 (save_restore_action, save_restore_orig_size)
10949 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10950 Resize mini windows in window.el.
10951 (grow_mini_window, shrink_mini_window): Implement by calling
10952 Qresize_root_window_vertically, resize_window_check and
10953 resize_window_apply.
640c8776
SM
10954 (saved_window, Fset_window_configuration, save_window_save):
10955 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10956 resize_proportionally.
10957 (window_min_height, window_min_width): Move to window.el.
10958 (keys_of_window): Move bindings for delete-other-windows,
10959 split-window, delete-window and enlarge-window to window.el.
10960
10961 * buffer.c: Temporarily extern Qdelete_window.
10962 (Fbury_buffer): Temporarily call Qdelete_window instead of
10963 Fdelete_window (Fbury_buffer will move to window.el soon).
10964
10965 * frame.c (set_menu_bar_lines_1): Remove code handling
10966 orig_top_line and orig_total_lines.
10967
10968 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10969 set_window_height but set heights directly.
10970 (change_frame_size_1): Use resize_frame_windows.
10971
10972 * xdisp.c (init_xdisp): Don't use set_window_height but set
10973 heights directly.
10974
640c8776
SM
10975 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10976 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10977 run_window_configuration_change_hook.
10978
10979 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10980 instead of change_window_heights and run
10981 run_window_configuration_change_hook.
10982
1a13852e
MR
109832011-06-09 Martin Rudalics <rudalics@gmx.at>
10984
10985 * window.c (replace_window): Rename second argument REPLACEMENT to
10986 NEW. New third argument SETFLAG. Rewrite.
10987 (delete_window, make_dummy_parent): Call replace_window with
10988 third argument 1.
10989 (window_list_1): Move down in code.
10990 (run_window_configuration_change_hook): Move set_buffer part
10991 before select_frame_norecord part in order to unwind correctly.
10992 Rename count1 to count.
10993 (recombine_windows, delete_deletable_window, resize_root_window)
10994 (Fdelete_other_windows_internal)
10995 (Frun_window_configuration_change_hook, make_parent_window)
10996 (resize_window_check, resize_window_apply, Fresize_window_apply)
10997 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10998 (Fdelete_window_internal, Fresize_mini_window_internal):
10999 New functions.
1a13852e
MR
11000 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11001
f3d1777e
MR
110022011-06-08 Martin Rudalics <rudalics@gmx.at>
11003
496e208e
MR
11004 * window.h (window): Add some new members to window structure -
11005 normal_lines, normal_cols, new_total, new_normal, clone_number,
11006 splits, nest, prev_buffers, next_buffers.
11007 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11008 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11009
f3d1777e
MR
11010 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11011 Remove.
496e208e
MR
11012 (make_dummy_parent): Set new members of windows structure.
11013 (make_window): Move down in code. Handle new members of window
11014 structure.
11015 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11016 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11017 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11018 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11019 (Fset_window_next_buffers, Fset_window_clone_number):
11020 New functions.
496e208e
MR
11021 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11022 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11023 Doc-string fixes.
11024 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11025 Argument WINDOW can be now internal window too.
11026 (Fwindow_use_time): Move up in code.
11027 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11028 Rewrite doc-string.
11029 (Fset_window_configuration, saved_window)
11030 (Fcurrent_window_configuration, save_window_save): Handle new
11031 members of window structure.
b9e809c2
MR
11032 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11033 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11034 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11035 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11036 Qget_mru_window, Qresize_root_window,
11037 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11038 Qauto_buffer_name; staticpro them.
f3d1777e 11039
abde8f8c
MR
110402011-06-07 Martin Rudalics <rudalics@gmx.at>
11041
11042 * window.c (Fwindow_total_size, Fwindow_left_column)
11043 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11044 (Fwindow_list_1): New functions.
11045 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11046 (Fwindow_width, Fscroll_left, Fscroll_right):
11047 Use window_body_cols instead of window_box_text_cols.
11048 (delete_window, Fset_window_configuration):
11049 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11050 (delete_all_subwindows): Take a window as argument and not a
11051 structure. Rewrite.
190b47e6
MR
11052 (window_loop): Remove handling of GET_LRU_WINDOW and
11053 GET_LARGEST_WINDOW.
11054 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11055
11056 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11057 window_box_text_cols. delete_all_subwindows now takes a
11058 Lisp_Object as argument.
abde8f8c 11059
640c8776
SM
11060 * indent.c (compute_motion, Fcompute_motion):
11061 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11062
fa8a67e6
MR
11063 * frame.c (delete_frame): Call delete_all_subwindows with root
11064 window as argument.
11065
a54e3482
DC
110662011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11067
11068 * fns.c (Fputhash): Document return value.
11069
60002bf5
CY
110702011-06-06 Chong Yidong <cyd@stupidchicken.com>
11071
11072 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11073
0c671da6 110742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11075
b862a52a 11076 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11077
be44ca6c
PE
11078 Check for overflow when converting integer to cons and back.
11079 * charset.c (Fdefine_charset_internal, Fdecode_char):
11080 Use cons_to_unsigned to catch overflow.
11081 (Fencode_char): Use INTEGER_TO_CONS.
11082 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11083 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11084 * data.c (long_to_cons, cons_to_long): Remove.
11085 (cons_to_unsigned, cons_to_signed): New functions.
11086 These signal an error for invalid or out-of-range values.
11087 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11088 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11089 * font.c (Ffont_variation_glyphs):
11090 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11091 * lisp.h: Include <intprops.h>.
11092 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11093 (cons_to_signed, cons_to_unsigned): New decls.
11094 (long_to_cons, cons_to_long): Remove decls.
11095 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11096 (Fprimitive_undo): Use CONS_TO_INTEGER.
11097 * xfns.c (Fx_window_property): Likewise.
11098 * xselect.c: Include <limits.h>.
11099 (x_own_selection, selection_data_to_lisp_data):
11100 Use INTEGER_TO_CONS.
11101 (x_handle_selection_request, x_handle_selection_clear)
11102 (x_get_foreign_selection, Fx_disown_selection_internal)
11103 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11104 (lisp_data_to_selection_data): Use cons_to_unsigned.
11105 (x_fill_property_data): Use cons_to_signed.
11106 Report values out of range.
11107
d1f3d2af
PE
11108 Check for buffer and string overflow more precisely.
11109 * buffer.h (BUF_BYTES_MAX): New macro.
11110 * lisp.h (STRING_BYTES_MAX): New macro.
11111 * alloc.c (Fmake_string):
11112 * character.c (string_escape_byte8):
11113 * coding.c (coding_alloc_by_realloc):
11114 * doprnt.c (doprnt):
11115 * editfns.c (Fformat):
11116 * eval.c (verror):
11117 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11118 since they may not be the same number.
11119 * editfns.c (Finsert_char):
11120 * fileio.c (Finsert_file_contents):
11121 Likewise for BUF_BYTES_MAX.
11122
dd52fcea
PE
11123 * image.c: Use ptrdiff_t, not int, for sizes.
11124 (slurp_file): Switch from int to ptrdiff_t.
11125 All uses changed.
11126 (slurp_file): Check that file size fits in both size_t (for
11127 malloc) and ptrdiff_t (for sanity and safety).
11128
7f9bbdbb
PE
11129 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11130 if b->modtime has its maximal value.
11131
dfe18f82
PE
11132 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11133
84acfcf0
PE
11134 Don't assume time_t can fit into int.
11135 * buffer.h (struct buffer.modtime): Now time_t, not int.
11136 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11137 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11138
ccd9a01a
PE
11139 Minor fixes for signed vs unsigned integers.
11140 * character.h (MAYBE_UNIFY_CHAR):
11141 * charset.c (maybe_unify_char):
11142 * keyboard.c (read_char, reorder_modifiers):
11143 XINT -> XFASTINT, since the integer must be nonnegative.
11144 * ftfont.c (ftfont_spec_pattern):
11145 * keymap.c (access_keymap, silly_event_symbol_error):
11146 XUINT -> XFASTINT, since the integer must be nonnegative.
11147 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11148 since it makes no difference and we prefer signed.
11149 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11150 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11151 nonnegative.
11152
d6d100dd
SM
111532011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11154
11155 * window.h (Fwindow_frame): Declare.
11156
2b6148e4
PE
111572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11158
11159 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11160 (SPARE_MEMORY): Always define.
11161 (LARGE_REQUEST): Remove.
11162 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11163
f230ecc9
MR
111642011-06-06 Martin Rudalics <rudalics@gmx.at>
11165
727e958e
MR
11166 * lisp.h: Move EXFUNS for Fframe_root_window,
11167 Fframe_first_window and Fset_frame_selected_window to window.h.
11168
11169 * window.h: Move EXFUNS for Fframe_root_window,
11170 Fframe_first_window and Fset_frame_selected_window here from
11171 lisp.h.
11172
11173 * frame.c (Fwindow_frame, Fframe_first_window)
11174 (Fframe_root_window, Fframe_selected_window)
11175 (Fset_frame_selected_window): Move to window.c.
11176 (Factive_minibuffer_window): Move to minibuf.c.
11177 (Fother_visible_frames_p): New function.
11178
11179 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11180
f230ecc9
MR
11181 * window.c (decode_window, decode_any_window): Move up in code.
11182 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11183 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11184 (Fwindow_buffer): Move up and rewrite doc-string.
11185 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11186 (Fwindow_prev): New functions.
727e958e
MR
11187 (Fwindow_frame): Move here from frame.c. Accept any window as
11188 argument.
11189 (Fframe_root_window, Fframe_first_window)
11190 (Fframe_selected_window): Move here from frame.c. Accept frame
11191 or arbitrary window as argument. Update doc-strings.
11192 (Fminibuffer_window): Move up in code.
11193 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11194 (Fset_frame_selected_window): Move here from frame.c.
11195 Marginal rewrite.
727e958e
MR
11196 (Fselected_window, select_window, Fselect_window): Move up in
11197 code. Minor doc-string fixes.
f230ecc9 11198
4d09bcf6
PE
111992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11200
11201 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11202 Do not assume that spare memory exists; that assumption is valid
11203 only if SYSTEM_MALLOC.
11204 (LARGE_REQUEST): New macro, so that the issue of large requests
11205 is separated from the issue of spare memory.
11206
810928a2
AS
112072011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11208
172418ad
AS
11209 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11210 format. (Bug#8806)
11211
43f862f7
AS
11212 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11213
810928a2
AS
11214 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11215 before statements.
11216
a059fe24
JD
112172011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11218
11219 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11220
11221 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11222
11223 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11224 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11225
989bf368
JB
112262011-06-05 Juanma Barranquero <lekktu@gmail.com>
11227
11228 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11229
4b80f674
CY
112302011-06-04 Chong Yidong <cyd@stupidchicken.com>
11231
11232 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11233 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11234 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11235 New error handlers.
4b80f674
CY
11236 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11237 Obey Vx_select_enable_clipboard_manager. Catch errors in
11238 x_clipboard_manager_save (Bug#8779).
11239 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11240 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11241
99a33b77 112422011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11243
11244 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11245
99a33b77 112462011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11247
11248 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11249 in the current matrix if keep_current_p is non-zero.
11250
8264569d
EZ
112512011-06-04 Eli Zaretskii <eliz@gnu.org>
11252
11253 * bidi.c (bidi_level_of_next_char): Fix last change.
11254
57f97249
EZ
112552011-06-03 Eli Zaretskii <eliz@gnu.org>
11256
fec2107c 11257 Support bidi reordering of text covered by display properties.
57f97249 11258
fec2107c
EZ
11259 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11260 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11261 (bidi_cache_search, bidi_cache_iterator_state)
11262 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11263 (bidi_level_of_next_char, bidi_move_to_visually_next):
11264 Support character positions inside a run of characters covered by a
fec2107c
EZ
11265 display string.
11266 (bidi_paragraph_init, bidi_resolve_explicit_1)
11267 (bidi_level_of_next_char): Call bidi_fetch_char and
11268 bidi_fetch_char_advance instead of FETCH_CHAR and
11269 FETCH_CHAR_ADVANCE.
11270 (bidi_init_it): Initialize new members.
11271 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11272 definitions.
11273 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11274 instead of using explicit *_CHAR codes.
d6d100dd
SM
11275 (bidi_resolve_explicit, bidi_resolve_weak):
11276 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11277 bidirectional text is supported only in multibyte buffers.
11278 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11279 it to initialize the frame_window_p member of struct bidi_it.
11280 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11281 (bidi_resolve_explicit, bidi_resolve_weak)
11282 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11283 bidi_it->nchars is non-positive.
11284 (bidi_level_of_next_char): Don't try to lookup the cache for the
11285 next/previous character if nothing is cached there yet, or if we
11286 were just reseat()'ed to a new position.
c40e2fb2 11287
0e14fe90
EZ
11288 * xdisp.c (set_cursor_from_row): Set start and stop points
11289 according to the row's direction when priming the loop that looks
11290 for the glyph on which to display cursor.
11291 (single_display_spec_intangible_p): Function deleted.
11292 (display_prop_intangible_p): Reimplement to call
11293 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11294 Accept 3 additional arguments needed by handle_display_spec.
11295 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11296 values: lists, `(when COND...)' forms, etc.
11297 (single_display_spec_string_p): Support property values that are
11298 lists with the argument STRING its top-level element.
11299 (display_prop_string_p): Fix the condition for processing a
11300 property that is a list to be consistent with handle_display_spec.
fec2107c 11301 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11302 last portion of handle_display_prop.
11303 (compute_display_string_pos): Accept additional argument
11304 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11305 value of a `display' property is a "replacing spec".
11306 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11307 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11308 the display property, but just return a value indicating whether
11309 the display property will replace the characters it covers.
11310 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11311 frame_window_p members of struct bidi_it.
d6d100dd
SM
11312 (compute_display_string_pos, compute_display_string_end):
11313 New functions.
fec2107c
EZ
11314 (push_it): Accept second argument POSITION, where pop_it should
11315 jump to continue iteration.
11316 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11317
fec2107c
EZ
11318 * keyboard.c (adjust_point_for_property): Adjust the call to
11319 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11320
11321 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11322 (bidi_init_it): Update prototypes.
11323 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11324 (compute_display_string_pos, compute_display_string_end):
11325 Declare prototypes.
fec2107c
EZ
11326 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11327 EMACS_INT.
fc6f18ce 11328
40087514 113292011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11330
57f53182
PE
11331 Malloc failure behavior now depends on size of allocation.
11332 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11333 * lisp.h: Change signatures accordingly.
11334 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11335 All callers changed. (Bug#8762)
11336
11337 * gnutls.c: Use Emacs's memory allocators.
11338 Without this change, the gnutls library would invoke malloc etc.
11339 directly, which causes problems on non-SYNC_INPUT hosts, and which
11340 runs afoul of improving memory_full behavior. (Bug#8761)
11341 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11342 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11343 xfree instead of the default malloc, realloc, free.
11344 (Fgnutls_boot): No need to check for memory allocation failure,
11345 since xmalloc does that for us.
11346
ac32cd99 11347 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11348 * category.c (hash_get_category_set):
11349 * ccl.c (ccl_driver):
11350 * charset.c (Fdefine_charset_internal):
11351 * charset.h (struct charset.hash_index):
11352 * composite.c (get_composition_id, gstring_lookup_cache)
11353 (composition_gstring_put_cache):
11354 * composite.h (struct composition.hash_index):
11355 * dispextern.h (struct image.hash):
11356 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11357 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11358 (hashfn_equal, hashfn_user_defined, make_hash_table)
11359 (maybe_resize_hash_table, hash_lookup, hash_put)
11360 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11361 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11362 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11363 * image.c (make_image, search_image_cache, lookup_image)
11364 (xpm_put_color_table_h):
11365 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11366 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11367 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11368 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11369 * alloc.c (allocate_vectorlike):
11370 Check for overflow in vector size calculations.
11371 * ccl.c (ccl_driver):
11372 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11373 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11374 need to be updated by these changes.
40087514
PE
11375 * fns.c (make_hash_table, maybe_resize_hash_table):
11376 Check for integer overflow with large hash tables.
0de4bb68
PE
11377 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11378 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11379 (SXHASH_REDUCE): New macro.
11380 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11381 Use it instead of discarding useful hash info with large hash values.
11382 (sxhash_float): New function.
11383 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11384 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11385 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11386 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11387 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11388 Adjust signatures to match updated version of code.
11389 (consing_since_gc): Now EMACS_INT, since a single hash table can
11390 use more than INT_MAX bytes.
11391
698d32e2
DN
113922011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11393
11394 Make it possible to build with GCC-4.6+ -O2 -flto.
11395
11396 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11397
fd6fa53f
SM
113982011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11399
11400 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11401 Call minibuffer-inactive-mode.
11402
864db017
JB
114032011-05-31 Juanma Barranquero <lekktu@gmail.com>
11404
11405 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11406 Update dependencies.
11407
2ad0baf4
DN
114082011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11409
11410 * data.c (init_data): Remove code for UTS, this system is not
11411 supported anymore.
11412
4fcc2638
DN
114132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11414
11415 Don't force ./temacs to start in terminal mode.
11416
11417 * frame.c (make_initial_frame): Initialize faces in all cases, not
11418 only when CANNOT_DUMP is defined.
11419 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11420
c56e0fd5
DN
114212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11422
11423 * dispnew.c (add_window_display_history): Use const for the string
11424 pointer. Remove declaration, not needed.
11425
333d54da 114262011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11427
55d4c1b2 11428 Use 'inline', not 'INLINE'.
333d54da 11429 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11430 * alloc.c, fontset.c (INLINE): Remove.
11431 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11432 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11433 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11434 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11435 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11436
738db178
DN
114372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11438
11439 Make it possible to run ./temacs.
11440
11441 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11442 syms_of_callproc does the same thing. Remove test for
11443 "initialized", do it in the caller.
11444 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11445
620c53a6
SM
114462011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11447
11448 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11449 (read_minibuf): Use get_minibuffer.
11450 (syms_of_minibuf): Use DEFSYM.
11451 (Qmetadata): New var.
11452 * data.c (Qbuffer): Don't make it static.
11453 (syms_of_data): Use DEFSYM.
11454
e003a292
PE
114552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11456
11457 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11458 (CCL_CODE_MIN): New macro.
11459
ed008a6d
PE
114602011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11461
3687c2ef
PE
11462 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11463
ed008a6d
PE
11464 * eval.c (Qdebug): Now static.
11465 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11466 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11467 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11468
d66c4c7c
CY
114692011-05-29 Chong Yidong <cyd@stupidchicken.com>
11470
11471 * image.c: Various fixes to ImageMagick code comments.
11472 (Fimagemagick_types): Doc fix.
11473
5fbc2025
PE
114742011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11475
0196f88a
PE
11476 Minor fixes prompted by GCC 4.6.0 warnings.
11477
11478 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11479
5fbc2025
PE
11480 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11481 (x_clipboard_manager_save_all): Move extern decl to ...
11482 * xterm.h: ... here, so that it can be checked for consistency.
11483
1dd3c2d9
CY
114842011-05-29 Chong Yidong <cyd@stupidchicken.com>
11485
11486 * xselect.c (x_clipboard_manager_save_frame)
11487 (x_clipboard_manager_save_all): New functions.
11488 (Fx_clipboard_manager_save): Lisp function deleted.
11489
11490 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11491 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11492
11493 * xterm.h: Update prototype.
11494
5ba6571d
WX
114952011-05-28 William Xu <william.xwl@gmail.com>
11496
11497 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11498 exiting (Bug#8239).
11499
3eaff834
JM
115002011-05-28 Jim Meyering <meyering@redhat.com>
11501
e1900994 11502 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11503 * fns.c (to_uchar): Define.
11504 (crypto_hash_function): Use it to convert some newly-signed
11505 variables to unsigned, to avoid sign-extension bugs. For example,
11506 without this change, (md5 "truc") would evaluate to
11507 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11508 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11509 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11510
0f6990a7
PE
115112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11512
11513 Integer overflow fixes.
c8a9ca5a 11514
08686060
PE
11515 * dbusbind.c: Serial number integer overflow fixes.
11516 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11517 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11518 to hold a serial number that is too large for a fixnum.
11519 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11520 Check for serial numbers out of range. Decode any serial number
59568bf0 11521 that was so large that it became a float. (Bug#8722)
08686060 11522
2d1fc3c7
PE
11523 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11524 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11525 Use XFASTINT rather than XUINT when numbers are nonnegative.
11526 (xd_append_arg, Fdbus_method_return_internal):
11527 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11528 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11529 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11530 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11531 (Bug#8722)
2d1fc3c7 11532
c8a9ca5a
PE
11533 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11534
519e1d69
PE
11535 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11536
6df6ae42 11537 ccl: Add integer overflow checks.
30569699
PE
11538 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11539 (IN_INT_RANGE): New macros.
11540 (ccl_driver): Use them to check for integer overflow when
11541 decoding a CCL program. Many of the new checks are whether XINT (x)
11542 fits in int; it doesn't always, on 64-bit hosts. The new version
11543 doesn't catch all possible integer overflows, but it's an
847044ea 11544 improvement. (Bug#8719)
30569699 11545
c11285dc
PE
11546 * alloc.c (make_event_array): Use XINT, not XUINT.
11547 There's no need for unsigned here.
11548
fdccd48e
PE
11549 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11550 This follows up to the 2011-05-06 change that substituted uintptr_t
11551 for EMACS_INT. This case wasn't caught back then.
11552
37910ab2
PE
11553 Rework Fformat to avoid integer overflow issues.
11554 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11555 now (part of C89). Include <verify.h>.
11556 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11557 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11558 (Fformat): Avoid the prepass trying to compute sizes; it was only
11559 approximate and thus did not catch overflow reliably. Instead, walk
11560 through the format just once, formatting and computing sizes as we go,
11561 checking for integer overflow at every step, and allocating a larger
11562 buffer as needed. Keep track separately whether the format is
11563 multibyte. Keep only the most-recently calculated precision, rather
11564 than them all. Record whether each argument has been converted to
11565 string. Use EMACS_INT, not int, for byte and char and arg counts.
11566 Support field widths and precisions larger than INT_MAX. Avoid
11567 sprintf's undefined behavior with conversion specifications such as %#d
11568 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11569 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11570 formatting out-of-range floating point numbers with int
9173deec 11571 formats. (Bug#8668)
37910ab2 11572
2e6578fb
PE
11573 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11574
0ae6bdee
PE
11575 * data.c: Avoid integer truncation in expressions involving floats.
11576 * data.c: Include <intprops.h>.
11577 (arith_driver): When there's an integer overflow in an expression
11578 involving floating point, convert the integers to floating point
11579 so that the resulting value does not suffer from catastrophic
11580 integer truncation. For example, on a 64-bit host (* 4
11581 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11582 Do not rely on undefined behavior after integer overflow.
11583
de883a70
PE
11584 merge count_size_as_multibyte, parse_str_to_multibyte
11585 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11586 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11587 Check for integer overflow.
11588 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11589 since it's now a duplicate of the other. This is more of
11590 a character than a buffer op, so better that it's in character.c.
11591 * fns.c, print.c: Adjust to above changes.
11592
2ff916cb
PE
115932011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11594
11595 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11596
f1b54466
PE
115972011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11598
fb1ac845
PE
11599 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11600 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11601 (x_clipboard_manager_save): Now static.
11602 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11603
f1b54466
PE
11604 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11605 (crypto_hash_function): Now static.
11606 Fix pointer signedness problems. Avoid unnecessary initializations.
11607
a9f737ee
CY
116082011-05-27 Chong Yidong <cyd@stupidchicken.com>
11609
11610 * termhooks.h (Vselection_alist): Make it terminal-local.
11611
11612 * terminal.c (create_terminal): Initialize it.
11613
11614 * xselect.c: Support for clipboard managers.
11615 (Vselection_alist): Move to termhooks.h as terminal-local var.
11616 (LOCAL_SELECTION): New macro.
11617 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11618 (symbol_to_x_atom): Remove gratuitous arg.
11619 (x_handle_selection_request, lisp_data_to_selection_data)
11620 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11621 (x_own_selection, x_get_local_selection, x_convert_selection):
11622 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11623 (some_frame_on_display): Delete unused function.
11624 (Fx_own_selection_internal, Fx_get_selection_internal)
11625 (Fx_disown_selection_internal, Fx_selection_owner_p)
11626 (Fx_selection_exists_p): New optional frame arg.
11627 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11628 (x_handle_selection_clear): Don't treat other terminals with the
11629 same keyboard specially. Use the terminal-local Vselection_alist.
11630 (x_clear_frame_selections): Use Frun_hook_with_args.
11631
11632 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11633
11634 * xterm.h: Add support for those atoms.
11635
e067f0c1
CY
116362011-05-26 Chong Yidong <cyd@stupidchicken.com>
11637
11638 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11639 (converted_selections, conversion_fail_tag): New global variables.
11640 (x_selection_request_lisp_error): Free the above.
11641 (x_get_local_selection): Remove unnecessary code.
11642 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11643 of converted selections stored in converted_selections.
11644 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11645 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11646 (x_convert_selection): New function.
11647 (x_handle_selection_event): Simplify.
11648 (x_get_foreign_selection): Don't ignore incoming requests while
11649 waiting for an answer; this will fail when we implement
11650 SAVE_TARGETS, and seems unnecessary anyway.
11651 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11652 (Vx_sent_selection_functions): Doc fix.
11653
0f4aebc0
LL
116542011-05-26 Leo Liu <sdl.web@gmail.com>
11655
11656 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11657
e61124cd
YM
116582011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11659
11660 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11661
11662 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11663 for fringe update if it has periodic bitmap.
ac389d0c 11664 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11665 and fringe_bitmap_periodic_p.
11666
11667 * fringe.c (get_fringe_bitmap_data): New function.
11668 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11669 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11670 row. Mark glyph row for fringe update if periodicity changed.
11671
11672 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11673 for fringe update unless it has periodic bitmap.
11674
f16d9837
KH
116752011-05-25 Kenichi Handa <handa@m17n.org>
11676
11677 * xdisp.c (get_next_display_element): Set correct it->face_id for
11678 a static composition.
11679
e1b90ef6
LL
116802011-05-24 Leo Liu <sdl.web@gmail.com>
11681
11682 * deps.mk (fns.o):
11683 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11684
11685 * fns.c (crypto_hash_function, Fsha1): New function.
11686 (Fmd5): Use crypto_hash_function.
11687 (syms_of_fns): Add Ssha1.
11688
7400048f
PE
116892011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11690
11691 * gnutls.c: Remove unused macros.
11692 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11693 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11694 Remove macros that are defined and never used.
11695 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11696
abb71cf4
CY
116972011-05-22 Chong Yidong <cyd@stupidchicken.com>
11698
11699 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11700 (Fx_get_selection_internal): Minor cleanup.
11701 (Fx_own_selection_internal): Rename arguments for consistency with
11702 select.el.
11703
6307db39
PE
117042011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11705
11706 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11707
f3d4e0a4
CY
117082011-05-22 Chong Yidong <cyd@stupidchicken.com>
11709
11710 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11711
4d8ade89
YM
117122011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11713
11714 * dispnew.c (scrolling_window): Don't exclude the case that the
11715 last enabled row in the desired matrix touches the bottom boundary.
11716
32078c8d
GM
117172011-05-21 Glenn Morris <rgm@gnu.org>
11718
11719 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11720 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11721 and add some more files.
32078c8d 11722
7285dc67
EZ
117232011-05-20 Eli Zaretskii <eliz@gnu.org>
11724
11725 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11726 report_file_error introduced by the change from 2011-05-07.
11727
89d1bd22
PE
117282011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11729
11730 * systime.h (Time): Define only if emacs is defined.
11731 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11732 where the include path doesn't have X11/X.h by default. See
11733 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11734
cd394be1 117352011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11736
11737 * composite.c (find_automatic_composition): Fix previous change.
11738
b9704ad9
GM
117392011-05-20 Glenn Morris <rgm@gnu.org>
11740
11741 * lisp.mk: New file, split from Makefile.in.
11742 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11743 (shortlisp): Remove.
11744 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11745
4a720484
GM
117462011-05-19 Glenn Morris <rgm@gnu.org>
11747
11748 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11749 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11750 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11751 (lisp): Set the order to that of loadup.el.
11752 (shortlisp): Make it a copy of $lisp.
11753 (SOME_MACHINE_LISP): Remove.
11754 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11755 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11756
a28d4396
KH
117572011-05-18 Kenichi Handa <handa@m17n.org>
11758
11759 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11760 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11761 (find_automatic_composition): Mostly rewrite for efficiency.
11762
a2b1fa8e
JB
117632011-05-18 Juanma Barranquero <lekktu@gmail.com>
11764
11765 * makefile.w32-in: Update dependencies.
11766
8e1f5610
CS
117672011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11768
11769 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11770 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11771
7025ee00 117722011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11773
cdfa6eab
PE
11774 Fix some integer overflow issues, such as string length overflow.
11775
06d6db33
PE
11776 * insdel.c (count_size_as_multibyte): Check for string overflow.
11777
2b4560a8
PE
11778 * character.c (lisp_string_width): Check for string overflow.
11779 Use EMACS_INT, not int, for string indexes and lengths; in
11780 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11781 the resulting string length overflows an EMACS_INT; instead,
11782 report a string overflow if no precision given. When checking for
11783 precision exhaustion, use a check that cannot possibly have
11784 integer overflow. (Bug#8675)
11785 * character.h (lisp_string_width): Adjust to new signature.
11786
cb93f9be
PE
11787 * alloc.c (string_overflow): New function.
11788 (Fmake_string): Use it. This doesn't change behavior, but saves
11789 a few bytes and will simplify future changes.
11790 * character.c (string_escape_byte8): Likewise.
11791 * lisp.h (string_overflow): New decl.
11792
1a1f3366
PE
11793 Fixups, following up to the user-interface timestamp change.
11794 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11795 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11796 * msdos.c (mouse_get_pos): Likewise.
11797 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11798 * w32gui.h (Time): Define by including "systime.h" rather than by
11799 declaring it ourselves. (Bug#8664)
11800
d4e3e4d3
PE
11801 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11802 * image.c (clear_image_cache): Likewise.
11803
f6a24d19
PE
11804 * term.c (term_mouse_position): Don't assume time_t wraparound.
11805
08dc5ae6
PE
11806 Be more systematic about user-interface timestamps.
11807 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11808 and sometimes 'EMACS_UINT', to represent these timestamps.
11809 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11810 This makes the code easier to follow, and makes it easier to catch
11811 integer overflow bugs such as Bug#8664.
11812 * frame.c (Fmouse_position, Fmouse_pixel_position):
11813 Use Time, not unsigned long, for user-interface timestamps.
11814 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11815 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11816 * keyboard.h (last_event_timestamp): Likewise.
11817 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11818 * menu.h (xmenu_show): Likewise.
11819 * term.c (term_mouse_position): Likewise.
11820 * termhooks.h (struct input_event.timestamp): Likewise.
11821 (struct terminal.mouse_position_hook): Likewise.
11822 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11823 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11824 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11825 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11826 what it was before.
11827 * menu.h, termhooks.h: Include "systime.h", for Time.
11828
8e55734a
PE
11829 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11830 Don't assume that the difference between two unsigned long values
11831 can fit into an integer. At this point, we know button_down_time
11832 <= event->timestamp, so the difference must be nonnegative, so
11833 there's no need to cast the result if double-click-time is
11834 nonnegative, as it should be; check that it's nonnegative, just in
11835 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11836 apart (about 25 days). (Bug#8664)
8e55734a 11837
841f1b75 11838 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11839 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11840
3e26f69c
PE
11841 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11842 that always fit in int. Use a sentinel instead of a counter, to
11843 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11844 * frame.h (struct frame): Use int for menu_bar_items_used
11845 instead of EMACS_INT, since it always fits in int.
3e26f69c 11846
5cc152c0
PE
11847 * menu.c (grow_menu_items): Check for int overflow.
11848
d89eb65e
PE
11849 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11850
5235bd3e
PE
11851 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11852 Before, the code was not consistent. These values cannot exceed
11853 2**31 - 1 so there's no need to make them unsigned.
11854 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11855 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11856 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11857 as modifiers.
11858 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11859
bc827e23
PE
11860 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11861 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11862 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11863 presumably because the widths might not match.
11864
78eb494e
PE
11865 * window.c (size_window): Avoid needless test at loop start.
11866
04f2d78b
CB
118672011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11868
11869 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11870
d2fc7e3d 118712011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11872
11873 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11874
d2fc7e3d 118752011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11876
11877 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11878 `width' to `bar_area_x' and `bar_area_width', respectively.
11879 (x_scroll_run): Take account of fringe background extension.
11880
04f2d78b
CB
11881 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11882 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11883 `bar_area_width', respectively.
11884 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11885 background extension.
11886
79b70037
GM
118872011-05-10 Jim Meyering <meyering@redhat.com>
11888
11889 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11890
2f142cc5
JB
118912011-05-10 Juanma Barranquero <lekktu@gmail.com>
11892
11893 * image.c (Finit_image_library): Return t for built-in image types,
11894 like pbm and xbm. (Bug#8640)
11895
57679c86
AS
118962011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11897
11898 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11899
888c9e86
EZ
119002011-05-07 Eli Zaretskii <eliz@gnu.org>
11901
b0512a1d
EZ
11902 * w32console.c (Fset_screen_color): Doc fix.
11903 (Fget_screen_color): New function.
11904 (syms_of_ntterm): Defsubr it.
11905
7285dc67
EZ
11906 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11907 unlink the temporary file if Fcall_process didn't create it in the
11908 first place.
11909 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11910 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11911 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11912 cue to call_process_cleanup not to close that handle.
11913
4d3fcc8e
BK
119142011-05-07 Ben Key <bkey76@gmail.com>
11915
11916 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11917 one of two shell specific rules, either bootstrap-temacs-CMD or
11918 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11919 to the previous implementation of the bootstrap-temacs rule.
11920 The bootstrap-temacs-CMD rule is similar to the previous
11921 implementation of the bootstrap-temacs rule except that it
11922 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11923 variable.
11924
11925 These changes, along with some changes to nt/configure.bat,
11926 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11927 earlier fix to add support for --cflags and --ldflags options
11928 that include quotes so that it works whether make uses cmd or
11929 sh as the shell.
11930
b4289b64
MA
119312011-05-06 Michael Albinus <michael.albinus@gmx.de>
11932
11933 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11934 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11935 is a constant.
11936 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11937 a string. Handle both cases.
11938 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11939 (Fdbus_register_method): Use Qinvalid_function.
11940
af4c0e28
JB
119412011-05-06 Juanma Barranquero <lekktu@gmail.com>
11942
11943 * makefile.w32-in: Update dependencies.
11944 (LISP_H): Add inttypes.h and stdin.h.
11945 (PROCESS_H): Add unistd.h.
11946
c51453d9
EZ
119472011-05-06 Eli Zaretskii <eliz@gnu.org>
11948
11949 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11950 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11951
8ff0ac3c 119522011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11953
4c4b566b
PE
11954 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11955
aab2b9b5
PE
11956 * term.c (vfatal): Remove stray call to va_end.
11957 It's not needed and the C Standard doesn't allow it here anyway.
11958
c378da0b
PE
11959 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11960 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11961
288b08c7
PE
11962 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11963 bytes.
11964
e3601888
PE
11965 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11966
db6c0e74
PE
11967 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11968
dd5963ea
PE
11969 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11970
88c9450f
PE
11971 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11972
2f9442b8
PE
11973 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11974
c032b5f8
PE
11975 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11976 * charset.c (Fdefine_charset_internal): Don't initialize
11977 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11978 32-bit int (Bug#8600).
a108c10b
PE
11979
11980 * lread.c (read_integer): Be more consistent with string-to-number.
11981 Use string_to_number to do the actual conversion; this avoids
11982 rounding errors and fixes some other screwups. Without this fix,
11983 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11984 (digit_to_number): Move earlier, for benefit of read_integer.
11985 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11986 not a digit in any supported base. (Bug#8602)
a108c10b 11987
ad5f9eea
PE
11988 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11989
aec1708a
PE
11990 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11991 to match comment at start of function. This also removes a
11992 GCC warning about overflow in a 32+64-bit port.
11993
47be4ab5
PE
11994 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11995
371cac43
PE
11996 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11997 Reported by Stefan Monnier in
11998 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11999 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12000 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12001
d01a7826
PE
12002 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12003 (EMACS_UINTPTR): Likewise, with uintptr_t.
12004
7fd47d5c
PE
12005 * lisp.h: Prefer 64-bit EMACS_INT if available.
12006 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12007 on 32-bit hosts that have 64-bit int, so that they can access
12008 large files.
122b0c86
PE
12009 However, temporarily disable this change unless the temporary
12010 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12011
8727937b
PE
12012 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12013
8ac068ac
PE
12014 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12015 This removes an assumption that EMACS_INT and long are the same
12016 width as pointers. The assumption is true for Emacs porting targets
12017 now, but we want to make other targets possible.
12018 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12019 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12020 In the rest of the code, change types of integers that hold casted
12021 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12022 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12023 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12024 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12025 No need to cast type when ORing.
12026 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12027 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12028 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12029 assume EMACS_INT is the same width as char *.
12030 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12031 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12032 Remove no-longer-needed casts.
12033 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12034 (xg_tool_bar_help_callback, xg_make_tool_item):
12035 Use EMACS_INTPTR to hold an integer
12036 that will be cast to void *; this can avoid a GCC warning
12037 if EMACS_INT is not the same width as void *.
12038 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12039 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12040 (current_message_1, set_message_1):
12041 Use a local to convert to proper width without a cast.
12042 * xmenu.c (dialog_selection_callback): Likewise.
12043
ede49d71
PE
12044 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12045 Also, don't assume VALBITS / RAND_BITS is less than 5,
12046 and don't rely on undefined behavior when shifting a 1 left into
12047 the sign bit.
12048 * lisp.h (get_random): Change signature to match.
12049
2f30ecd0
PE
12050 * lread.c (hash_string): Use size_t, not int, for hash computation.
12051 Normally we prefer signed values; but hashing is special, because
12052 it's better to use unsigned division on hash table sizes so that
12053 the remainder is nonnegative. Also, size_t is the natural width
12054 for hashing into memory. The previous code used 'int', which doesn't
12055 retain enough info to hash well into very large tables.
12056 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12057
2a866e7b
PE
12058 * dbusbind.c: Don't possibly lose pointer info when converting.
12059 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12060 Use XPNTR rather than XHASH, so that the high-order bits of
12061 the pointer aren't lost when converting through void *.
12062
51639eac
PE
12063 * eval.c (Fautoload): Don't double-shift a pointer.
12064
92394119
PE
12065 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12066
dbdb9a7c
JB
120672011-05-06 Juanma Barranquero <lekktu@gmail.com>
12068
12069 * gnutls.c (DEF_GNUTLS_FN):
12070 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12071
db7a0b4f
AS
120722011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12073
12074 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12075 marker. (Bug#8610)
12076
cd394be1 120772011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12078
12079 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12080 New version that can reserve upto 2GB of heap space.
12081
f7ff1b0f 120822011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12083
12084 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12085
639c109b
TZ
120862011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12087
12088 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12089 `gnutls_certificate_set_x509_key_file'.
12090
d2127135
JB
120912011-05-05 Juanma Barranquero <lekktu@gmail.com>
12092
12093 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12094 Update dependencies.
12095
e968f4f3
JB
120962011-05-04 Juanma Barranquero <lekktu@gmail.com>
12097
12098 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12099 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12100 Remove unused parameter `fildes'.
12101 * process.c (read_process_output, send_process): Don't pass it.
12102
84d358f0
JB
121032011-05-04 Juanma Barranquero <lekktu@gmail.com>
12104
12105 Fix previous change: the library cache is defined in w32.c.
12106 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12107 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12108
0898ca10
JB
121092011-05-04 Juanma Barranquero <lekktu@gmail.com>
12110
12111 Implement dynamic loading of GnuTLS on Windows.
12112
12113 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12114 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12115 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12116 Declare.
12117
12118 * gnutls.c (Qgnutls_dll): Define.
12119 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12120 (gnutls_*): Declare function pointers.
12121 (init_gnutls_functions): New function to initialize function pointers.
12122 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12123 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12124 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12125 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12126 (emacs_gnutls_write, emacs_gnutls_read)
12127 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12128 (Fgnutls_available_p): New function.
12129 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12130 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12131 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12132
12133 * image.c: Include w32.h.
12134 (Vimage_type_cache): Delete.
12135 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12136 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12137 (w32_delayed_load): Move to w32.c.
12138
12139 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12140
12141 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12142 (w32_delayed_load): Move from image.c. When loading a library, record
12143 its filename in the :loaded-from property of the library id.
12144 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12145 Initialize and staticpro them.
12146 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12147
12148 * process.c: Include lisp.h before w32.h, not after.
12149 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12150 instead of gnutls_record_check_pending.
12151
12152 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12153
ff4de4aa
TZ
121542011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12155
12156 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12157 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12158 as passed in.
12159
abe95abb
JD
121602011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12161
12162 * xterm.c (x_set_frame_alpha): Do not set property on anything
12163 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12164
e16e55d4
JB
121652011-05-02 Juanma Barranquero <lekktu@gmail.com>
12166
12167 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12168
bafcf6a5
JB
121692011-05-02 Juanma Barranquero <lekktu@gmail.com>
12170
12171 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12172 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12173 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12174 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12175 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12176 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12177 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12178 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12179 (Qgnutls_bootprop_callbacks_verify): Make static.
12180
e7a6747f
AS
121812011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12182
19ed11ba
AS
12183 * callproc.c: Indentation fixup.
12184
e7a6747f 12185 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12186 (wait_for_termination, interruptible_wait_for_termination):
12187 Move after wait_for_termination_1.
e7a6747f 12188
1ef14cb4
LMI
121892011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12190
12191 * sysdep.c (interruptible_wait_for_termination): New function
12192 which is like wait_for_termination, but allows keyboard
12193 interruptions.
12194
12195 * callproc.c (Fcall_process): Add (:file "file") as an option for
12196 the STDOUT buffer.
12197 (Fcall_process_region): Ditto.
12198
330d880c
EZ
121992011-04-30 Eli Zaretskii <eliz@gnu.org>
12200
8db90b73
EZ
12201 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12202 rather than `XVECTOR (FOO)->size'.
12203
330d880c
EZ
12204 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12205 inttypes.h, as a gnulib replacement is used if it not available in
12206 system headers.
12207
15cbd324
EZ
122082011-04-21 Eli Zaretskii <eliz@gnu.org>
12209
12210 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12211 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12212 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12213
12214 * coding.c (coding_alloc_by_realloc): Error out if destination
12215 will grow beyond MOST_POSITIVE_FIXNUM.
12216 (decode_coding_emacs_mule): Abort if there isn't enough place in
12217 charbuf for the composition carryover bytes. Reserve an extra
12218 space for up to 2 characters produced in a loop.
12219 (decode_coding_iso_2022): Abort if there isn't enough place in
12220 charbuf for the composition carryover bytes.
12221
122222011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12223
ae940cca
EZ
12224 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12225 aborting when %lld or %lll format is passed.
12226 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12227 %llo or %llx format is passed. (Bug#8545)
12228
03ab8921
EZ
12229 * window.c (window_scroll_line_based): Use a marker instead of
12230 simple variables to record original value of point. (Bug#7952)
12231
afda1437
EZ
12232 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12233 produced by %s or %c overflows available buffer space. (Bug#8545)
12234
f76dee0c
PE
122352011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12236
12237 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12238 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12239
fdc5744d
JB
122402011-04-28 Juanma Barranquero <lekktu@gmail.com>
12241
12242 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12243
638f053a
JB
122442011-04-28 Juanma Barranquero <lekktu@gmail.com>
12245
12246 * keyboard.c (Qdelayed_warnings_hook): Define.
12247 (command_loop_1): Run `delayed-warnings-hook'
12248 if Vdelayed_warnings_list is non-nil.
12249 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12250 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12251
d178f871
EZ
122522011-04-28 Eli Zaretskii <eliz@gnu.org>
12253
12254 * doprnt.c (doprnt): Don't return value smaller than the buffer
12255 size if the message was truncated. (Bug#8545).
12256
b124fd93
JB
122572011-04-28 Juanma Barranquero <lekktu@gmail.com>
12258
12259 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12260 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12261
e810457d
PE
122622011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12263
12264 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12265
ea51cceb
JB
122662011-04-27 Juanma Barranquero <lekktu@gmail.com>
12267
12268 * makefile.w32-in: Update dependencies.
12269
94dcfacf
EZ
122702011-04-27 Eli Zaretskii <eliz@gnu.org>
12271
12272 Improve `doprnt' and its usage. (Bug#8545)
12273 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12274 `format_end'. Remove support for %l as a conversion specifier.
12275 Don't use xrealloc. Improve diagnostics when the %l size modifier
12276 is used. Update the commentary.
12277
12278 * eval.c (verror): Simplify calculation of size_t.
12279
12280 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12281 messages.
12282
f61f41d7
PE
122832011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12284
12285 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12286 change.
12287
96fb4434
PE
122882011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12289
12290 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12291 This makes this file independent of the recent pseudovector change.
12292
671875da 122932011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12294
69e9b5a3
PE
12295 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12296
b5f869a7 12297 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12298 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12299 Remove unused local.
c8926152 12300 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12301
841a1577 12302 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12303 GCC 4.6.0 optimizes based on type-based alias analysis.
12304 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12305 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12306 != &v->size, and therefore "v->size = 1; b->size = 2; return
12307 v->size;" must therefore return 1. This assumption is incorrect
12308 for Emacs, since it type-puns struct Lisp_Vector * with many other
12309 types. To fix this problem, this patch adds a new type struct
f904488f 12310 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12311 and pseudovectors, and helps optimizing compilers not get fooled
12312 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12313 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12314 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12315 the size member.
eab3844f
PE
12316 (XSETPVECTYPE): Rewrite in terms of new macro.
12317 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12318 This is a bit clearer, and further avoids the possibility of
12319 undesirable aliasing.
12320 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12321 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12322 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12323 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12324 (ASIZE): Now uses header.size rather than size.
12325 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12326 to avoid the hassle of writing XVECTOR (foo)->header.size.
12327 (struct vectorlike_header): New type.
eab3844f
PE
12328 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12329 object, to help avoid aliasing.
12330 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12331 (SUBRP): Likewise, since Lisp_Subr is a special case.
12332 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12333 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12334 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12335 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12336 changed to be "header.size" and "header.next".
12337 * buffer.h (struct buffer): Likewise.
12338 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12339 * frame.h (struct frame): Likewise.
12340 * process.h (struct Lisp_Process): Likewise.
12341 * termhooks.h (struct terminal): Likewise.
12342 * window.c (struct save_window_data, struct saved_window): Likewise.
12343 * window.h (struct window): Likewise.
12344 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12345 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12346 * buffer.c (init_buffer_once): Likewise.
12347 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12348 special case.
12349 * process.c (Fformat_network_address): Use local var for size,
12350 for brevity.
12351
0df1eac5
PE
12352 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12353
847ab9d1 12354 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12355 * data.c (atof): Remove decl; no longer used or needed.
12356 (digit_to_number): Move to lread.c.
12357 (Fstring_to_number): Use new string_to_number function, to be
12358 consistent with how the Lisp reader treats infinities and NaNs.
12359 Do not assume that floating-point numbers represent EMACS_INT
12360 without losing information; this is not true on most 64-bit hosts.
12361 Avoid double-rounding errors, by insisting on integers when
12362 parsing non-base-10 numbers, as the documentation specifies.
12363 * lisp.h (string_to_number): New decl, replacing ...
12364 (isfloat_string): Remove.
bc0a5c13 12365 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12366 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12367 appears to have been a coding error. Similarly, do not accept
12368 strings like +-1e0 as floating point numbers. Do not report
12369 overflow for integer overflows unless the base is not 10 which
12370 means we have no simple and reliable way to continue.
12371 Break out the floating-point parsing into a new
12372 function string_to_number, so that Fstring_to_number parses
12373 floating point numbers consistently with the Lisp reader.
04f2d78b 12374 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12375 (E_CHAR, EXP_INT): Remove, replacing with ...
12376 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12377 (string_to_number): New function, replacing isfloat_string.
12378 This function checks for valid syntax and produces the resulting
12379 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12380 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12381 so that overflow for non-base-10 numbers is reported only when
12382 there's no portable and simple way to convert to floating point.
452f4150 12383
67769ffc
PE
12384 * textprop.c (set_text_properties_1): Rewrite for clarity,
12385 and to avoid GCC warning about integer overflow.
12386
c20db43f
PE
12387 * intervals.h (struct interval): Use EMACS_INT for members
12388 where EMACS_UINT might cause problems. See
12389 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12390 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12391 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12392 All uses changed.
37aa2f85
PE
12393 (offset_intervals): Tell GCC not to worry about length overflow
12394 when negating a negative length.
c20db43f 12395
2538aa2f
PE
12396 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12397 (overrun_check_free): Likewise.
12398
f2d3008d
PE
12399 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12400 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12401 word size.
12402
ec8df744
PE
12403 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12404 (gnutls_make_error): Rename local to avoid shadowing.
12405 (gnutls_emacs_global_deinit): ifdef out; not used.
12406 (Fgnutls_boot): Use const for pointer to readonly storage.
12407 Comment out unused local. Fix pointer signedness problems.
12408
640ee02d
PE
12409 * lread.c (openp): Don't stuff size_t into an 'int'.
12410 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12411 about possible signed overflow.
12412
6048fb2a
PE
12413 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12414 (GDK_KEY_g): Don't define if already defined.
12415 (xg_prepare_tooltip): Avoid pointer signedness problem.
12416 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12417
fa3c87e1
PE
12418 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12419 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12420
2172544b
PE
12421 * xfns.c (Fx_window_property): Simplify a bit,
12422 to make a bit faster and to avoid GCC 4.6.0 warning.
12423 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12424
9b821a21
PE
12425 * fns.c (internal_equal): Don't assume size_t fits in int.
12426
3c616cfa
PE
12427 * alloc.c (compact_small_strings): Tighten assertion a little.
12428
c2982e87
PE
12429 Replace pEd with more-general pI, and fix some printf arg casts.
12430 * lisp.h (pI): New macro, generalizing old pEd macro to other
12431 conversion specifiers. For example, use "...%"pI"d..." rather
12432 than "...%"pEd"...".
12433 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12434 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12435 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12436 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12437 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12438 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12439 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12440 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12441 64-bit hosts.
12442 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12443 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12444 * print.c (safe_debug_print, print_object): Likewise.
12445 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12446 to int.
6f04d126
PE
12447 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12448 avoiding the 0 flag, which is not portable.
c2982e87
PE
12449 * process.c (Fmake_network_process): Use pI to avoid cast.
12450 * region-cache.c (pp_cache): Likewise.
12451 * xdisp.c (decode_mode_spec): Likewise.
12452 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12453 behavior on 64-bit hosts with printf arg.
6f04d126 12454 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12455 (x_stop_queuing_selection_requests): Likewise.
12456 (x_get_window_property): Don't truncate byte count to an 'int'
12457 when tracing.
0b432f21 12458
5e073ec7
PE
12459 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12460 here, since it parses constructs like leading '-' and spaces,
12461 which are not wanted; and it overflows with large numbers.
12462 Instead, simply match F[0-9]+, which is what is wanted anyway.
12463
36372bf9
PE
12464 * alloc.c: Remove unportable assumptions about struct layout.
12465 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12466 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12467 (allocate_vectorlike, make_pure_vector): Use the new macros,
12468 plus offsetof, to remove unportable assumptions about struct layout.
12469 These assumptions hold on all porting targets that I know of, but
12470 they are not guaranteed, they're easy to remove, and removing them
12471 makes further changes easier.
12472
0b432f21
PE
12473 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12474 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12475 (string_overrun_cookie): Now const. Use initializers that
12476 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12477 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12478 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12479 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12480 multiple of sizeof (EMACS_INT); it need not be, if
12481 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12482 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12483
895009e1
JB
124842011-04-26 Juanma Barranquero <lekktu@gmail.com>
12485
12486 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12487
6a7a1b0b
TZ
124882011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12489
12490 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12491 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12492 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12493
841a1577 124942011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12495
12496 * lisp.h (Qdebug): List symbol.
895009e1 12497 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12498 * keyboard.c (debug-on-event): New variable.
12499 (handle_user_signal): Break into debugger when debug-on-event
12500 matches the current signal symbol.
12501
f2d3ba6f
DN
125022011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12503
12504 * alloc.c (check_sblock, check_string_bytes)
12505 (check_string_free_list): Convert to standard C.
12506
42ce4c63
TZ
125072011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12508
12509 * w32.c (emacs_gnutls_push): Fix typo.
12510
825cd63c
EZ
125112011-04-25 Eli Zaretskii <eliz@gnu.org>
12512
fb11d64d
EZ
12513 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12514 "cast to pointer from integer of different size".
12515
825cd63c
EZ
12516 Improve doprnt and its use in verror. (Bug#8545)
12517 * doprnt.c (doprnt): Document the set of format control sequences
12518 supported by the function. Use SAFE_ALLOCA instead of always
12519 using `alloca'.
12520
12521 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12522 is one byte too soon. Don't use xrealloc; instead xfree and
12523 xmalloc anew.
12524
e061a11b
TZ
125252011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12526
12527 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12528 callbacks stage.
12529
12530 * gnutls.c: Renamed global_initialized to
12531 gnutls_global_initialized. Added internals for the
12532 :verify-hostname-error, :verify-error, and :verify-flags
12533 parameters of `gnutls-boot' and documented those parameters in the
12534 docstring. Start callback support.
9173deec
JB
12535 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12536 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12537 on error. Return error code.
e061a11b
TZ
12538 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12539 (emacs_gnutls_read): Likewise.
12540 (Fgnutls_boot): Return handshake error code.
12541 (emacs_gnutls_handle_error): New function.
12542 (wsaerror_to_errno): Likewise.
12543
12544 * w32.h (emacs_gnutls_pull): Add prototype.
12545 (emacs_gnutls_push): Likewise.
12546
12547 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12548 (emacs_gnutls_push): Likewise.
12549
125502011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12551
12552 * process.c (wait_reading_process_output): Check if GnuTLS
12553 buffered some data internally if no FDs are set for TLS
12554 connections.
12555
12556 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12557 (LIBS): Link to USER_LIBS.
12558 ($(BLD)/gnutls.$(0)): New target.
12559
fa6996bc
EZ
125602011-04-24 Eli Zaretskii <eliz@gnu.org>
12561
eb35682e
EZ
12562 * xdisp.c (handle_single_display_spec): Rename the
12563 display_replaced_before_p argument into display_replaced_p, to
12564 make it consistent with the commentary. Fix typos in the
12565 commentary.
12566
e2ad650c
EZ
12567 * textprop.c (syms_of_textprop): Remove dead code.
12568 (copy_text_properties): Delete obsolete commentary about an
12569 interface that was deleted long ago. Fix typos in the description
12570 of arguments.
12571
1b2de274
EZ
12572 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12573 to changes in oldXMenu/XMenu.h from 2011-04-16.
12574 <menu_help_message, prev_menu_help_message>: Constify.
12575 (IT_menu_make_room): menu->help_text is now `const char **';
12576 adjust.
12577
12578 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12579 to changes in oldXMenu/XMenu.h from 2011-04-16.
12580 (struct XMenu): Declare `help_text' `const char **'.
12581
12582 * xfaces.c <Qunspecified>: Make extern again.
12583
12584 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12585 required by POSIX.
1b2de274 12586
762b15be
EZ
12587 * doc.c (get_doc_string): Improve the format passed to `error'.
12588
12589 * doprnt.c (doprnt): Improve commentary.
12590
12591 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12592
12593 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12594 them with etags.
12595
f1052e5d
EZ
12596 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12597 changes in globals.h immediately force recompilation.
762b15be
EZ
12598 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12599 $(CURDIR)/s/ms-w32.h.
12600 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12601
fa6996bc
EZ
12602 * character.c (Fchar_direction): Function deleted.
12603 (syms_of_character): Don't defsubr it.
12604 <char-direction-table>: Deleted.
12605
e6c3da20
EZ
126062011-04-23 Eli Zaretskii <eliz@gnu.org>
12607
12608 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12609 * doprnt.c: Include limits.h.
12610 (SIZE_MAX): New macro.
04f2d78b
CB
12611 (doprnt): Return a size_t value. 2nd arg is now size_t.
12612 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12613 Improve overflow protection. Support `l' modifier for integer
12614 conversions. Support %l conversion. Don't assume an EMACS_INT
12615 argument for integer conversions and for %c.
12616
12617 * lisp.h (doprnt): Restore prototype.
12618
12619 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12620 $(SRC)/character.h.
12621
12622 * Makefile.in (base_obj): Add back doprnt.o.
12623
12624 * deps.mk (doprnt.o): Add back prerequisites.
12625 (callint.o): Depend on character.h.
12626
12627 * eval.c (internal_lisp_condition_case): Include the handler
12628 representation in the error message.
12629 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12630 when breaking from the loop.
12631
12632 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12633
12634 * callint.c (Fcall_interactively): When displaying error message
12635 about invalid control letter, pass the character's codepoint, not
12636 a pointer to its multibyte form. Improve display of the character
12637 in octal and display also its hex code.
12638
12639 * character.c (char_string): Use %x to display the (unsigned)
12640 codepoint of an invalid character, to avoid displaying a bogus
12641 negative value.
12642
12643 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12644 `error', not SYMBOL_NAME itself.
12645
12646 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12647 character arguments to `error'.
12648
12649 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12650 to `error' in error message about FINAL_CHAR argument. Make sure
12651 FINAL_CHAR is a character, and use %c when it is passed as
12652 argument to `error'.
12653
4ffd0d6b 126542011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12655
12656 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12657
12658 * w32.c: Include <time.h>.
12659 (sys_localtime): New function.
12660
4ffd0d6b 126612011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12662
12663 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12664
4ffd0d6b 12665 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12666
4ffd0d6b 126672011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12668
4ffd0d6b
GM
12669 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12670 zombies (Bug#8467).
aac0c6e3 12671
04c56954
EZ
126722011-04-19 Eli Zaretskii <eliz@gnu.org>
12673
12674 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12675 gl_state.e_property when gl_state.object is Qt.
12676
12677 * insdel.c (make_gap_larger): Remove limitation of buffer size
12678 to <= INT_MAX.
12679
16a43933
CY
126802011-04-18 Chong Yidong <cyd@stupidchicken.com>
12681
12682 * xdisp.c (lookup_glyphless_char_display)
12683 (produce_glyphless_glyph): Handle cons cell entry in
12684 glyphless-char-display.
12685 (Vglyphless_char_display): Document it.
12686
12687 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12688 glyphless-char-display.
12689
4581706e
CY
126902011-04-17 Chong Yidong <cyd@stupidchicken.com>
12691
12692 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12693
12694 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12695
12696 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12697 definition for no-X builds.
12698
4887c6e2 126992011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12700
fd35b6f9
PE
12701 Static checks with GCC 4.6.0 and non-default toolkits.
12702
5c1ccb01
PE
12703 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12704
006c5daa
PE
12705 * process.c (keyboard_bit_set): Define only if SIGIO.
12706 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12707 (send_process): Repair possible setjmp clobbering.
12708
efc736d3
PE
12709 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12710
4e2fe2e6
PE
12711 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12712
f97334a2
PE
12713 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12714
4e75f29d
PE
12715 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12716 Define only if needed.
12717
90efadd1
PE
12718 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12719 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12720 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12721
3c647824
PE
12722 * dispextern.h (struct redisplay_interface): Rename param
12723 to avoid shadowing.
e264f262 12724 * termhooks.h (struct terminal): Likewise.
761383f4 12725 * xterm.c (xembed_send_message): Likewise.
3c647824 12726
b58c5c4a
PE
12727 * insdel.c (make_gap_smaller): Define only if
12728 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12729
cad59032
PE
12730 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12731 it.
12732
c339dc2e
PE
12733 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12734 so that we aren't warned about unused symbols.
12735
91a3e27b
PE
12736 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12737
399c71d3 12738 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12739
8ffc96f5
PE
12740 * xfns.c (x_real_positions): Mark locals as initialized.
12741
eef9bc79
PE
12742 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12743
098db9dd
PE
12744 * xterm.c: Fix problems found by static analysis with other toolkits.
12745 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12746 (x_dispatch_event): Declare static if USE_GTK, and
12747 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12748 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12749 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12750 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12751 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12752
eb18f6cc
PE
12753 * xmenu.c (menu_help_callback): Pointer type fixes.
12754 Use const pointers when pointing at readonly data. Avoid pointer
12755 signedness clashes.
12756 (FALSE): Remove unused macro.
12757 (update_frame_menubar): Remove unused decl.
12758
1fe72bf8
PE
12759 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12760
60d9e1db
PE
12761 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12762 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12763 (single_menu_item): Rename local to avoid shadowing.
12764
39261c26
PE
12765 * keyboard.c (make_lispy_event): Remove unused local var.
12766
018c5e19
PE
12767 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12768 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12769
63d2b86e
PE
12770 * bitmaps: Change bitmaps from unsigned char back to the X11
12771 compatible char. Avoid the old compiler warnings about
12772 out-of-range initializers by using, for example, '\xab' rather
12773 than 0xab.
12774
aefd87e1
PE
12775 * xgselect.c (xgselect_initialize): Check vs interface
12776 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12777
bf501fb9
PE
12778 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12779
e9829fdf
PE
12780 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12781 to read-only memory.
12782
1086c095
PE
12783 * fns.c (vector): Remove; this old hack is no longer needed.
12784
2baccd04 12785 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12786 Remove unused var.
dde42981 12787 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12788
72391843 12789 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12790
436c16df 12791 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12792 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12793 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12794
92bb796d 12795 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12796 (x_term_init): Remove local to avoid shadowing.
92bb796d 12797
764430a3 12798 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12799
12800 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12801 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12802
d1dfb56c
EZ
128032011-04-16 Eli Zaretskii <eliz@gnu.org>
12804
c4354cb4
EZ
12805 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12806
d1dfb56c
EZ
12807 Fix regex.c, syntax.c and friends for buffers > 2GB.
12808 * syntax.h (struct gl_state_s): Declare character position members
12809 EMACS_INT.
12810
12811 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12812
04f2d78b
CB
12813 * textprop.c (verify_interval_modification, interval_of):
12814 Declare arguments EMACS_INT.
d1dfb56c
EZ
12815
12816 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12817 EMACS_INT.
12818
12819 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12820
12821 * indent.c (Fvertical_motion): Local variable it_start is now
12822 EMACS_INT.
12823
12824 * regex.c (re_match, re_match_2, re_match_2_internal)
12825 (bcmp_translate, regcomp, regexec, print_double_string)
12826 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12827 (re_compile_pattern, re_exec): Declare arguments and local
12828 variables `size_t' and `ssize_t' and return values `regoff_t', as
12829 appropriate.
12830 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12831 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12832 <compile_stack_type>: `size' and `avail' are now `size_t'.
12833
12834 * regex.h <regoff_t>: Use ssize_t, not int.
12835 (re_search, re_search_2, re_match, re_match_2): Arguments that
12836 specify buffer/string position and length are now ssize_t and
12837 size_t. Return type is regoff_t.
12838
613052cd
BK
128392011-04-16 Ben Key <bkey76@gmail.com>
12840
12841 * nsfont.m: Fixed bugs in ns_get_family and
12842 ns_descriptor_to_entity that were caused by using free to
12843 deallocate memory blocks that were allocated by xmalloc (via
12844 xstrdup). This caused Emacs to crash when compiled with
12845 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12846 --enable-checking=xmallocoverrun). xfree is now used to
12847 deallocate these memory blocks.
12848
4170f62f 128492011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12850
71b41406
PE
12851 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12852
9587a89d
PE
12853 emacs_write: Accept and return EMACS_INT for sizes.
12854 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12855 et seq.
12856 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12857 Accept and return EMACS_INT.
12858 (emacs_gnutls_write): Return the number of bytes written on
12859 partial writes.
12860 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12861 (emacs_read, emacs_write): Remove check for negative size, as the
12862 Emacs source code has been audited now.
9587a89d
PE
12863 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12864 (emacs_read, emacs_write): Use it.
273a5f82
PE
12865 * process.c (send_process): Adjust to the new signatures of
12866 emacs_write and emacs_gnutls_write. Do not attempt to store
12867 a byte offset into an 'int'; it might overflow.
9587a89d 12868 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12869
3e047f51
PE
12870 * sound.c: Don't assume sizes fit in 'int'.
12871 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12872 Return EMACS_INT, not int.
3e047f51 12873 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12874 Accept EMACS_INT, not int.
12875 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12876 record read return values.
12877
cc39a9db
BK
128782011-04-15 Ben Key <bkey76@gmail.com>
12879
c9d0ec6d
JB
12880 * keyboard.c (Qundefined): Don't declare static since it is used
12881 in nsfns.m.
12882 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12883 static since they are used in nsfont.m.
cc39a9db 12884
6c60eb9f
SM
128852011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12886
12887 * process.c (Qprocessp): Don't declare static.
12888 * lisp.h (Qprocessp): Declare again.
12889
7990b61a
JB
128902011-04-15 Juanma Barranquero <lekktu@gmail.com>
12891
12892 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12893
5d4cb038
PE
128942011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12895
8bd7b830 12896 Improve C-level modularity by making more things 'static'.
cd64ea1d 12897
e3b27b31
PE
12898 Don't publish debugger-only interfaces to other modules.
12899 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12900 (verify_bytepos, count_markers): Move decls to the only modules
12901 that need them.
12902 * region-cache.h (pp_cache): Likewise.
12903 * window.h (check_all_windows): Likewise.
12904 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12905
5d4cb038
PE
12906 * sysdep.c (croak): Now static, if
12907 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12908 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12909
12910 * alloc.c (refill_memory_reserve): Now static if
12911 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12912 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12913
e87b6180
PE
12914 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12915 Define only if USE_LUCID.
12916
ac64929e
PE
12917 * xrdb.c (x_customization_string, x_rm_string): Now static.
12918
6f37259d
PE
12919 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12920 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12921
1683e3ab
PE
12922 * xdisp.c (draw_row_with_mouse_face): Now static.
12923 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12924
de9c2632
PE
12925 * window.h (check_all_windows): Mark externally visible.
12926
2b96acb7
PE
12927 * window.c (window_deletion_count): Now static.
12928
12929 * undo.c: Make symbols static if they're not exported.
12930 (last_undo_buffer, last_boundary_position, pending_boundary):
12931 Now static.
12932
50436f33
PE
12933 * textprop.c (interval_insert_behind_hooks): Now static.
12934 (interval_insert_in_front_hooks): Likewise.
12935
64520e5c
PE
12936 * term.c: Make symbols static if they're not exported.
12937 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12938 (max_frame_lines, tty_set_terminal_modes):
12939 (tty_reset_terminal_modes, tty_turn_off_highlight):
12940 (get_tty_terminal): Now static.
12941 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12942 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12943 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12944 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12945 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12946
1fa53021
PE
12947 * sysdep.c: Make symbols static if they're not exported.
12948 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12949 Now static.
12950 (sigprocmask_set, full_mask): Remove; unused.
12951 (wait_debugging): Mark as visible.
12952 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12953 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12954
d4b43b22
PE
12955 * syntax.c (syntax_temp): Define only if !__GNUC__.
12956
b7c513d0
PE
12957 * sound.c (current_sound_device, current_sound): Now static.
12958
989b29ad
PE
12959 * search.c (searchbufs, searchbuf_head): Now static.
12960
13a55a78
PE
12961 * scroll.c (scroll_cost): Remove; unused.
12962 * dispextern.h (scroll_cost): Remove decl.
12963
de68a1fc
PE
12964 * region-cache.h (pp_cache): Mark as externally visible.
12965
40ccffa6
PE
12966 * process.c: Make symbols static if they're not exported.
12967 (process_tick, update_tick, create_process, chan_process):
12968 (Vprocess_alist, proc_buffered_char, datagram_access):
12969 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12970 (deactivate_process): Mark defn as static, as well as decl.
12971 * lisp.h (create_process): Remove decl.
12972 * process.h (chan_process, Vprocess_alist): Remove decls.
12973
ad64fc97
PE
12974 * print.c: Make symbols static if they're not exported.
12975 (print_depth, new_backquote_output, being_printed, print_buffer):
12976 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12977 (print_interval, print_number_index, initial_stderr_stream):
12978 Now static.
12979 * lisp.h (Fprinc): Remove decl.
12980 (debug_output_compilation_hack): Mark as externally visible.
12981
adddb265
PE
12982 * sysdep.c (croak): Move decl from here to syssignal.h.
12983 * syssignal.h (croak): Put it here, so the API can be checked when
12984 'croak' is called from dissociate_if_controlling_tty.
12985
1717ede2
PE
12986 * minibuf.c: Make symbols static if they're not exported.
12987 (minibuf_save_list, choose_minibuf_frame): Now static.
12988 * lisp.h (choose_minibuf_frame): Remove decl.
12989
fa5fb2bc
PE
12990 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12991
1e3890d1
PE
12992 * lread.c: Make symbols static if they're not exported.
12993 (read_objects, initial_obarray, oblookup_last_bucket_number):
12994 Now static.
12995 (make_symbol): Remove; unused.
12996 * lisp.h (initial_obarray, make_symbol): Remove decls.
12997
8a1414fa
PE
12998 * keyboard.c: Make symbols static if they're not exported.
12999 (single_kboard, recent_keys_index, total_keys, recent_keys):
13000 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13001 (this_single_command_key_start, echoing, last_auto_save):
13002 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13003 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13004 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13005 (Vlispy_mouse_stem, double_click_count):
13006 Now static.
13007 (force_auto_save_soon): Define only if SIGDANGER.
13008 (ignore_mouse_drag_p): Now static if
13009 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13010 (print_help): Remove; unused.
13011 (stop_character, last_timer_event): Mark as externally visible.
13012 * keyboard.h (ignore_mouse_drag_p): Declare only if
13013 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13014 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13015 * lisp.h (echoing): Remove decl.
13016 (force_auto_save_soon): Declare only if SIGDANGER.
13017 * xdisp.c (redisplay_window): Simplify code, to make it more
13018 obvious that ignore_mouse_drag_p is not accessed if !defined
13019 USE_GTK && !defined HAVE_NS.
13020
93ea6e8f
PE
13021 * intervals.c: Make symbols static if they're not exported.
13022 (merge_properties_sticky, merge_interval_right, delete_interval):
13023 Now static.
13024 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13025
77382fcc
PE
13026 * insdel.c: Make symbols static if they're not exported.
13027 However, leave prepare_to_modify_buffer alone. It's never
13028 called from outside this function, but that appears to be a bug.
13029 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13030 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13031 (adjust_after_replace_noundo): Remove; unused.
13032 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13033 (signal_before_change): Remove decls.
77382fcc 13034
9306c32e
PE
13035 * indent.c (val_compute_motion, val_vmotion): Now static.
13036
cd44d2eb
PE
13037 * image.c: Make symbols static if they're not exported.
13038 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13039 if USE_GTK.
13040 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13041 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13042
ad9a7a06
PE
13043 * fringe.c (standard_bitmaps): Now static.
13044 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13045
81626931
PE
13046 * frame.c: Make symbols static if they're not exported.
13047 (x_report_frame_params, make_terminal_frame): Now static.
13048 (get_frame_param): Now static, unless HAVE_NS.
13049 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13050 (x_get_resource_string): Remove; not used.
13051 * frame.h (make_terminal_frame, x_report_frame_params):
13052 (x_get_resource_string); Remove decls.
13053 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13054 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13055
239f9db9
PE
13056 * font.c, fontset.c: Make symbols static if they're not exported.
13057 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13058 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13059 * font.c (font_close_object): Now static.
13060 * font.h (font_close_object): Remove.
13061 * fontset.c (FONTSET_OBJLIST): Remove.
13062 (free_realized_fontset) #if-0 the body, which does nothing.
13063 (face_suitable_for_char_p): #if-0, as it's never called.
13064 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13065 * xfaces.c (face_at_string_position):
13066 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13067 since 0 is always ASCII.
13068
dfcf3579
PE
13069 * fns.c (weak_hash_tables): Now static.
13070
5045092b
PE
13071 * fileio.c: Make symbols static if they're not exported.
13072 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13073 (Vwrite_region_annotation_buffers): Now static.
13074
57a96f5c
PE
13075 * eval.c: Make symbols static if they're not exported.
13076 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13077 * lisp.h (backtrace_list): Remove decl.
13078
35f08c38
PE
13079 * emacs.c: Make symbols static if they're not exported.
13080 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13081 (fatal_error_code, fatal_error_signal_hook, standard_args):
13082 Now static.
13083 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13084 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13085 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13086 * lisp.h (fatal_error_signal_hook): Remove decl.
13087 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13088
f44bd759
PE
13089 * editfns.c: Move a (normally-unused) function to its only use.
13090 * editfns.c, lisp.h (get_operating_system_release): Remove.
13091 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13092 worth the hassle of breaking this out.
13093
b532497d
PE
13094 * xterm.c: Make symbols static if they're not exported.
13095 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13096 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13097 (x_destroy_window, x_delete_display):
13098 Now static.
13099 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13100 (x_mouse_leave): Remove; unused.
13101 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13102 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13103 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13104 Remove decls.
13105 (x_mouse_leave): Declare only if WINDOWSNT.
13106 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13107 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13108 USE_X_TOOLKIT.
13109
1675728f
PE
13110 * ftxfont.c: Make symbols static if they're not exported.
13111 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13112 HAVE_FREETYPE.
13113 * font.h (ftxfont_driver): Likewise.
13114
e4cebfca
PE
13115 * xfns.c: Make symbols static if they're not exported.
13116 (x_last_font_name, x_display_info_for_name):
13117 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13118 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13119 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13120 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13121 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13122 (last_show_tip_args): Now static.
13123 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13124 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13125 (x_screen_planes): Remove; unused.
13126 * dispextern.h (x_screen_planes): Remove decl.
13127
5bf46f05
PE
13128 * dispnew.c: Make symbols static if they're not exported.
13129 * dispextern.h (redraw_garbaged_frames, scrolling):
13130 (increment_row_positions): Remove.
13131 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13132 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13133 Now static.
13134 (redraw_garbaged_frames): Remove; unused.
13135
435f4c28
PE
13136 * xfaces.c: Make symbols static if they're not exported.
13137 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13138 Remove decls.
13139 * xterm.h (defined_color): Remove decls.
13140 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13141 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13142 (menu_face_changed_default, defined_color, free_realized_face):
13143 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13144 (ascii_face_of_lisp_face): Remove; unused.
13145
8524aef3
PE
13146 * xdisp.c: Make symbols static if they're not exported.
13147 * dispextern.h (scratch_glyph_row, window_box_edges):
13148 (glyph_to_pixel_coords, set_cursor_from_row):
13149 (get_next_display_element, set_iterator_to_next):
13150 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13151 (show_mouse_face): Remove decls
13152 * frame.h (message_buf_print): Likewise.
13153 * lisp.h (pop_message, set_message, check_point_in_composition):
13154 Likewise.
13155 * xterm.h (set_vertical_scroll_bar): Likewise.
13156 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13157 (message_buf_print, scratch_glyph_row, displayed_buffer):
13158 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13159 (get_next_display_element, show_mouse_face, window_box_edges):
13160 (frame_to_window_pixel_xy, check_point_in_composition):
13161 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13162 (glyph_to_pixel_coords): Remove; unused.
13163
16390cd2
PE
13164 * dired.c (file_name_completion): Now static.
13165
13166 * dbusbind.c (xd_in_read_queued_messages): Now static.
13167
a25f4dfa
PE
13168 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13169 * data.c (circular_list_error): Remove.
13170
14a9c8df
PE
13171 * commands.h (last_point_position, last_point_position_buffer):
13172 (last_point_position_window): Remove decls.
13173 * keyboard.c: Make these variables static.
13174
04f2d78b
CB
13175 * coding.h (coding, code_convert_region, encode_coding_gap):
13176 Remove decls.
74ab6df5
PE
13177 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13178 (iso_code_class, detect_coding, code_convert_region): Now static.
13179 (encode_coding_gap): Remove; unused.
13180
38dfbee1
PE
13181 * chartab.c (chartab_chars, chartab_bits): Now static.
13182
a2cb4e63
PE
13183 * charset.h (charset_iso_8859_1): Remove decl.
13184 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13185 Now static.
13186
127198fd
PE
13187 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13188 * ccl.c (Vccl_program_table): Now static.
13189 (check_ccl_update): Remove; unused.
13190
d85b608f
PE
13191 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13192 * category.h: ... from here.
13193 * category.c (check_category_table, set_category_set): Now static.
13194
31cd66f3
PE
13195 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13196 * lisp.h: Remove these decls.
13197
c358e587
PE
13198 * buffer.c (buffer_count): Remove unused var.
13199
e78aecca
PE
13200 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13201 so that it's not optimized away.
13202 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13203 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13204 exported only to the debugger.
13205
e192d7d3 13206 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13207 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13208
92470028
PE
13209 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13210 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13211 was inaccessible from Lisp.
13212 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13213 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13214
244ed907
PE
13215 alloc.c: Import and export fewer symbols, and remove unused items.
13216 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13217 is defined.
13218 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13219 it's not optimized away by whole-program optimization.
13220 (message_enable_multibyte, free_misc): Remove.
13221 (catchlist, handlerlist, mark_backtrace):
13222 Declare only if BYTE_MARK_STACK.
13223 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13224 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13225 (message_enable_multibyte): Remove decl.
13226 (free_misc, interval_free_list, float_block, float_block_index):
13227 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13228 (cons_free_list, last_marked_index):
13229 Now static.
13230 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13231 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13232 (mark_backtrace): Define only if BYTE_MARK_STACK.
13233 * xdisp.c (message_enable_multibyte): Now static.
13234
61c2b50e 13235 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13236 This makes it easier for human readers (and static analyzers)
13237 to see whether these variables are used from other modules.
13238 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13239 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13240 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13241 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13242 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13243 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13244 * xmenu.c, xselect.c:
13245 Declare Q* vars static if they are not used in other modules.
13246 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13247 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13248 Remove decls of unexported vars.
13249 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13250
95c82688
PE
13251 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13252
16a97296
PE
13253 Make Emacs functions such as Fatom 'static' by default.
13254 This makes it easier for human readers (and static analyzers)
13255 to see whether these functions can be called from other modules.
13256 DEFUN now defines a static function. To make the function external
13257 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13258 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13259 (Finit_image_library):
16a97296
PE
13260 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13261 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13262 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13263 Remove decls, since these functions are now static.
13264 (Funintern, Fget_internal_run_time): New decls, since these functions
13265 were already external.
95c82688 13266
16a97296
PE
13267 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13268 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13269 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13270 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13271 * keyboard.c, keymap.c, lread.c:
13272 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13273 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13274 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13275 Mark functions with DEFUE instead of DEFUN,
13276 if they are used in other modules.
13277 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13278 decls for now-static functions.
13279 * buffer.h (Fdelete_overlay): Remove decl.
13280 * callproc.c (Fgetenv_internal): Mark as internal.
13281 * composite.c (Fremove_list_of_text_properties): Remove decl.
13282 (Fcomposition_get_gstring): New forward static decl.
13283 * composite.h (Fcomposite_get_gstring): Remove decl.
13284 * dired.c (Ffile_attributes): New forward static decl.
13285 * doc.c (Fdocumntation_property): New forward static decl.
13286 * eval.c (Ffetch_bytecode): New forward static decl.
13287 (Funintern): Remove extern decl; now in .h file where it belongs.
13288 * fileio.c (Fmake_symbolic_link): New forward static decl.
13289 * image.c (Finit_image_library): New forward static decl.
13290 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13291 * intervals.h (Fprevious_property_change):
13292 (Fremove_list_of_text_properties): Remove decls.
13293 * keyboard.c (Fthis_command_keys): Remove decl.
13294 (Fcommand_execute): New forward static decl.
13295 * keymap.c (Flookup_key): New forward static decl.
13296 (Fcopy_keymap): Now static.
13297 * keymap.h (Flookup_key): Remove decl.
13298 * process.c (Fget_process): New forward static decl.
13299 (Fprocess_datagram_address): Mark as internal.
13300 * syntax.c (Fsyntax_table_p): New forward static decl.
13301 (skip_chars): Remove duplicate decl.
13302 * textprop.c (Fprevious_property_change): New forward static decl.
13303 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13304 Now internal.
13305 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13306 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13307
785bbd42
PE
13308 * editfns.c (Fformat): Remove unreachable code.
13309
8b913b57
AS
133102011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13311
13312 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13313 change. (Bug#8496)
13314
a6744a35
EZ
133152011-04-13 Eli Zaretskii <eliz@gnu.org>
13316
13317 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13318 when at ZV. (Bug#8487)
13319
e7974947
AS
133202011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13321
baad03f0
AS
13322 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13323 (Bug#8437)
13324 * keyboard.c (parse_tool_bar_item): Likewise.
13325 * sound.c (sound_cleanup, alsa_close): Likewise.
13326 * termcap.c (tgetent): Likewise.
13327 * xfns.c (x_default_font_parameter): Likewise.
13328 * xsettings.c (read_and_apply_settings): Likewise.
13329
e7974947
AS
13330 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13331 (overrun_check_free): Protoize.
13332
28272684
PE
133332011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13334
13335 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13336 since callers should never pass a negative size.
13337 Change the signature to match that of plain 'read' and 'write'; see
13338 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13339 * lisp.h: Update prototypes of emacs_write and emacs_read.
13340
11997c76
EZ
133412011-04-11 Eli Zaretskii <eliz@gnu.org>
13342
13343 * xdisp.c (redisplay_window): Don't try to determine the character
13344 position of the scroll margin if the window start point w->startp
e896f03c 13345 is outside the buffer's accessible region. (Bug#8468)
11997c76 13346
8a2cbd72
EZ
133472011-04-10 Eli Zaretskii <eliz@gnu.org>
13348
13349 Fix write-region and its subroutines for buffers > 2GB.
13350 * fileio.c (a_write, e_write): Modify declaration of arguments and
13351 local variables to support buffers larger than 2GB.
13352 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13353
13354 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13355 argument, local variables, and return value.
13356
13357 * lisp.h: Update prototypes of emacs_write and emacs_read.
13358
13359 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13360
4073e537 133612011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13362
1ebfdcb6
PE
13363 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13364
b2ded58d
PE
13365 Fix more problems found by GCC 4.6.0's static checks.
13366
7d66342c
PE
13367 * xdisp.c (vmessage): Use a better test for character truncation.
13368
bbf47d44
PE
13369 * charset.c (load_charset_map): <, not <=, for optimization,
13370 and to avoid potential problems with integer overflow.
9248994d 13371 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13372 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13373 * editfns.c (Fformat): Likewise.
1e69125e 13374 * syntax.c (skip_chars): Likewise.
3befa583 13375
e3019616
PE
13376 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13377 This also lets GCC 4.6.0 generate slightly better loop code.
13378
becfa255
PE
13379 * callint.c (Fcall_interactively): <, not <=, for optimization.
13380 (Fcall_interactively): Count the number of arguments produced,
13381 not the number of arguments given. This is simpler and lets GCC
13382 4.6.0 generate slightly better code.
13383
dae0cd48
PE
13384 * ftfont.c: Distingish more carefully between FcChar8 and char.
13385 The previous code passed unsigned char * to a functions like
13386 strlen and xstrcasecmp that expect char *, which does not
13387 conform to the C standard.
13388 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13389 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13390 char * when the C standard requires it.
13391
76032d70
PE
13392 * keyboard.c (read_char): Remove unused var.
13393
eb3f1cc8
PE
13394 * eval.c: Port to Windows vsnprintf (Bug#8435).
13395 Include <limits.h>.
13396 (SIZE_MAX): Define if the headers do not.
13397 (verror): Do not give up if vsnprintf returns a negative count.
13398 Instead, grow the buffer. This ports to Windows vsnprintf, which
13399 does not conform to C99. Problem reported by Eli Zaretskii.
13400 Also, simplify the allocation scheme, by avoiding the need for
13401 calling realloc, and removing the ALLOCATED variable.
13402
70476b54
PE
13403 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13404
12020a9e
PE
13405 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13406 But keep the doprint source code for now, as we might revamp it
13407 and use it again (Bug#8435).
ea6c7ae6
PE
13408 * lisp.h (doprnt): Remove.
13409 * Makefile.in (base_obj): Remove doprnt.o.
13410 * deps.mk (doprnt.o): Remove.
13411
5fdb398c
PE
13412 error: Print 32- and 64-bit integers portably (Bug#8435).
13413 Without this change, on typical 64-bit hosts error ("...%d...", N)
13414 was used to print both 32- and 64-bit integers N, which relied on
13415 undefined behavior.
61bdb816 13416 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13417 * lisp.h (error, verror): Mark as printf-like functions.
13418 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13419 Report overflow in size calculations when allocating printf buffer.
13420 Do not truncate output string at its first null byte.
13421 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13422 Truncate the output at a character boundary, since vsnprintf does not
13423 do that.
13424 * charset.c (check_iso_charset_parameter): Convert internal
13425 character to string before calling 'error', since %c now has the
13426 printf meaning.
13427 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13428 overflow when computing char to be passed to 'error'. Do not
13429 pass Lisp_Object to 'error'; pass the integer instead.
13430 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13431 formatted with plain %d.
13432
b189fa66
PE
13433 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13434
bff87ef0
PE
13435 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13436
7e2cac20
PE
13437 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13438
ce4d90b5
PE
13439 * xterm.c (x_catch_errors): Remove duplicate declaration.
13440
266c9547
PE
13441 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13442
79c49ad2
PE
13443 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13444
368f4090
JM
134452011-04-10 Jim Meyering <meyering@redhat.com>
13446
13447 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13448 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13449 return ssize_t not "int", and use size_t as the buffer length.
13450 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13451 * gnutls.h: Update declarations.
13452 * process.c (read_process_output): Use ssize_t, to match.
13453 (send_process): Likewise.
13454
a32d4040
CY
134552011-04-09 Chong Yidong <cyd@stupidchicken.com>
13456
13457 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13458
8546720e 134592011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13460
04f2d78b
CB
13461 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13462 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13463
8546720e
GM
13464 * xterm.c (handle_one_xevent):
13465 * xmenu.c (create_and_show_popup_menu):
13466 * xselect.c (x_decline_selection_request)
13467 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13468
0a2f5c1a 134692011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13470
13471 Fix some uses of `int' instead of EMACS_INT.
13472 * search.c (string_match_1, fast_string_match)
13473 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13474 (scan_buffer, find_next_newline_no_quit)
13475 (find_before_next_newline, search_command, Freplace_match)
13476 (Fmatch_data): Make some `int' variables be EMACS_INT.
13477
13478 * xdisp.c (display_count_lines): 3rd argument and return value now
13479 EMACS_INT. All callers changed.
13480 (pint2hrstr): Last argument is now EMACS_INT.
13481
13482 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13483 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13484 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13485 (decode_coding_utf_16, decode_coding_emacs_mule)
13486 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13487 (decode_coding_ccl, decode_coding_charset)
13488 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13489 (decode_coding_iso_2022, decode_coding_emacs_mule)
13490 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13491 <char_offset, last_offset>: Declare EMACS_INT.
13492 (encode_coding_utf_8, encode_coding_utf_16)
13493 (encode_coding_emacs_mule, encode_invocation_designation)
13494 (encode_designation_at_bol, encode_coding_iso_2022)
13495 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13496 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13497 Declare EMACS_INT.
13498 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13499 (encode_invocation_designation): Last argument P_NCHARS is now
13500 EMACS_INT.
13501 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13502 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13503
13504 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13505 All users changed.
13506
13507 * ccl.c (Fccl_execute_on_string): Declare some variables
13508 EMACS_INT.
13509
8546720e 135102011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13511
13512 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13513
4e19a977
CS
135142011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13515
13516 * process.c (Fformat_network_address): Doc fix.
13517
87302331
R
135182011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13519
ee7683eb 13520 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13521
cbb59342
CY
135222011-04-08 Chong Yidong <cyd@stupidchicken.com>
13523
13524 * keyboard.c (read_char): Call Lisp function help-form-show,
13525 instead of using internal_with_output_to_temp_buffer.
13526 (Qhelp_form_show): New var.
e0d38eeb 13527 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13528
13529 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13530
13531 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13532
e67a13ab
CY
135332011-04-06 Chong Yidong <cyd@stupidchicken.com>
13534
04f2d78b
CB
13535 * process.c (Flist_processes): Remove to Lisp.
13536 (list_processes_1): Delete.
e67a13ab 13537
973f782d
EZ
135382011-04-06 Eli Zaretskii <eliz@gnu.org>
13539
7c106b1e
EZ
13540 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13541
973f782d
EZ
13542 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13543
41cf7d1a 135442011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13545
ca23cc88
PE
13546 Fix more problems found by GCC 4.6.0's static checks.
13547
f390e2d5
PE
13548 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13549
42eea0d0
PE
13550 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13551
b69769da 13552 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13553
f9541e84
PE
13554 * xdisp.c (vmessage): Mark as a printf-like function.
13555
13841b55
PE
13556 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13557
c136c10f
PE
13558 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13559
5e2d4a30
PE
13560 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13561 printf-like functions.
13562 (tiff_load): Add casts to remove these marks before passing them
13563 to system-supplied API.
13564
583f48b9
PE
13565 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13566
b25d760e
PE
13567 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13568 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13569 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13570 directly, rather than having caller test rule sign. This avoids
13571 some unnecessary tests.
13572 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13573 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13574 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13575
bc7b6697 13576 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13577 (xfont_open): Avoid unnecessary tests.
bc7b6697 13578
27ccc379
PE
13579 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13580
dcd5c89a
PE
13581 * composite.h, composite.c (composition_gstring_put_cache):
13582 Use EMACS_INT, not int, for length.
13583
b13a45c6
PE
13584 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13585 breaking out part of COMPOSITION_DECODE_RULE.
13586 (COMPOSITION_DECODE_RULE): Use it.
13587 * composite.c (get_composition_id): Remove unused local vars,
13588 by using the new macro.
13589
1e792e4d
PE
13590 * textprop.c (set_text_properties_1): Change while to do-while,
13591 since the condition is always true at first.
13592
dc6c6455 13593 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13594 (interval_deletion_adjustment): Return unsigned value.
13595 All uses changed.
dc6c6455 13596
aba7731a
PE
13597 * process.c (list_processes_1, create_pty, read_process_output):
13598 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13599 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13600 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13601 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13602 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13603
fdfc4bf3
PE
13604 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13605
fca8fe46 13606 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13607 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13608
06a0259a 13609 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13610 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13611 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13612
e7b9e80f
PE
13613 * print.c (print_error_message): Avoid int overflow.
13614
56201685
PE
13615 * font.c (font_list_entities): Redo for clarity,
13616 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13617
78834453 13618 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13619 (font_score): Avoid potential overflow in diff calculation.
78834453 13620
0bc0b309 13621 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13622 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13623
e610eaca
PE
13624 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13625
b895abce
PE
13626 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13627 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13628 can always succeed if overflow has undefined behavior.
13629
1f1d9321 13630 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13631 (wordify): Omit three unnecessary tests.
1f1d9321 13632
c59478bc
PE
13633 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13634 All callers changed. This avoids the need for an unused var.
13635
79b73827
PE
13636 * casefiddle.c (casify_region): Remove var that is set but not used.
13637
a4db5dfe
PE
13638 * dired.c (file_name_completion): Remove var that is set but not used.
13639
43aae36e
PE
13640 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13641
2a47c44d 13642 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13643 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13644
a37c69bf
PE
13645 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13646 Check for integer overflow on size calculations.
13647
328ab8e7
PE
13648 * buffer.c (Fprevious_overlay_change): Remove var that is set
13649 but not used.
13650
e5a2a5cb
PE
13651 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13652 Remove vars that are set but not used.
8d84a6eb 13653 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13654 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13655
a60e5f68
PE
13656 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13657
f661cb61 13658 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13659 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13660
f0397f5a
PE
13661 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13662 that are set but not used.
13663
8664db06 13664 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13665 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13666
6abdaa4a
PE
13667 * xselect.c (x_get_local_selection, x_handle_property_notify):
13668 Remove vars that are set but not used.
13669
0ce7538d 13670 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13671 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13672
9ae848fc
PE
13673 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13674 Remove var that is set but not used.
0b918413
PE
13675 (scroll_bar_windows_size): Now size_t, not int.
13676 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13677 Check for overflow.
9ae848fc 13678
a5a62657
PE
13679 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13680 (map_tty_color) [!defined MSDOS]: Likewise.
13681
5c5cdd39
PE
13682 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13683
66ebf983
PE
13684 * coding.c: Remove vars that are set but not used.
13685 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13686 All callers changed.
13687 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13688 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13689 (decode_coding_charset): Remove vars that are set but not used.
13690
1be4d761
PE
13691 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13692 that is set but not used.
13693
47553fa8
PE
13694 * print.c (print_object): Remove var that is set but not used.
13695
1f7196bf 13696 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13697 The gnulib version avoids calling malloc in the usual case,
13698 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13699 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13700 * filelock.c (current_lock_owner): Likewise.
13701 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13702 * sysdep.c: Include allocator.h, careadlinkat.h.
13703 (emacs_no_realloc_allocator): New static constant.
13704 (emacs_readlink): New function.
fdb61804
PE
13705 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13706 ../lib/careadlinkat.h.
d1fdcab7 13707
f84c17c7
SM
137082011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13709
13710 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13711 first non-nil return value).
13712
ef3862ad
JD
137132011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13714
13715 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13716 if not defined (Bug#8403).
13717
376a7006
JB
137182011-04-02 Juanma Barranquero <lekktu@gmail.com>
13719
13720 * xdisp.c (display_count_lines): Remove parameter `start',
13721 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13722 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13723 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13724 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13725 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13726 and thereabouts. All callers changed.
13727 (get_per_char_metric): Remove parameter `f', unused since
13728 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13729
6ca3801d
JM
137302011-04-02 Jim Meyering <meyering@redhat.com>
13731
13732 do not dereference NULL upon failed strdup
13733 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13734 (ns_get_family): Likewise.
13735
d8e2b5ba
JB
137362011-04-02 Juanma Barranquero <lekktu@gmail.com>
13737
13738 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13739
8c74fcbd
JD
137402011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13741
13742 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13743 later (Bug#8403).
13744
7200d79c
SM
137452011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13746
03408648 13747 Add lexical binding.
7200d79c 13748
03408648
SM
13749 * window.c (Ftemp_output_buffer_show): New fun.
13750 (Fsave_window_excursion):
13751 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13752
13753 * lread.c (lisp_file_lexically_bound_p): New function.
13754 (Fload): Bind Qlexical_binding.
13755 (readevalloop): Remove `evalfun' arg.
13756 Bind Qinternal_interpreter_environment.
13757 (Feval_buffer): Bind Qlexical_binding.
13758 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13759 Mark as dynamic.
13760 (syms_of_lread): Declare `lexical-binding'.
13761
13762 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13763
13764 * keyboard.c (eval_dyn): New fun.
13765 (menu_item_eval_property): Use it.
ca105506
SM
13766
13767 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13768
03408648
SM
13769 * fns.c (concat, mapcar1): Accept byte-code-functions.
13770
13771 * eval.c (Fsetq): Handle lexical vars.
13772 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13773 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13774 (FletX, Flet): Obey lexical binding.
13775 (Fcommandp): Handle closures.
13776 (Feval): New `lexical' arg.
13777 (eval_sub): New function extracted from Feval. Use it almost
13778 everywhere where Feval was used. Look up vars in lexical env.
13779 Handle closures.
13780 (Ffunctionp): Move from subr.el.
13781 (Ffuncall): Handle closures.
13782 (apply_lambda): Remove `eval_flags'.
13783 (funcall_lambda): Handle closures and new byte-code-functions.
13784 (Fspecial_variable_p): New function.
13785 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13786 but without exporting it to Lisp.
23aba0ea 13787
23aba0ea 13788 * doc.c (Fdocumentation, store_function_docstring):
03408648 13789 * data.c (Finteractive_form): Handle closures.
23aba0ea 13790
03408648
SM
13791 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13792 interactive spec.
ba83908c 13793
04f2d78b
CB
13794 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13795 New byte-codes.
03408648
SM
13796 (exec_byte_code): New function extracted from Fbyte_code to handle new
13797 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13798
03408648 13799 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13800
03408648 13801 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13802
e2abce01
JB
138032011-03-31 Juanma Barranquero <lekktu@gmail.com>
13804
13805 * xdisp.c (redisplay_internal): Fix prototype.
13806
63696a73 138072011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13808
63696a73 13809 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13810 (try_scrolling): Use it when setting scroll_limit.
13811 Limit scrolling to 100 screen lines.
63696a73
EZ
13812 (redisplay_window): Even when falling back on "recentering",
13813 position point in the window according to scroll-conservatively,
13814 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13815
13816 (try_scrolling): When point is above the window, allow searching
13817 as far as scroll_max, or one screenful, to compute vertical
13818 distance from PT to the scroll margin position. This prevents
13819 try_scrolling from unnecessarily failing when
13820 scroll-conservatively is set to a value slightly larger than the
13821 window height. Clean up the case of PT below the margin at bottom
13822 of window: scroll_max can no longer be INT_MAX. When aggressive
13823 scrolling is in use, don't let point enter the opposite scroll
13824 margin as result of the scroll.
13825 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13826 threshold of 100 lines for never-recentering scrolling.
13827
e4cc2dfc
JB
138282011-03-31 Juanma Barranquero <lekktu@gmail.com>
13829
13830 * dispextern.h (move_it_by_lines):
13831 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13832 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13833 (message_log_check_duplicate): Remove parameters `prev_bol' and
13834 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13835 (redisplay_internal): Remove parameter `preserve_echo_area',
13836 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13837
13838 * indent.c (Fvertical_motion):
13839 * window.c (window_scroll_pixel_based, Frecenter):
13840 Don't pass `need_y_p' to `move_it_by_lines'.
13841
1c470562
SM
138422011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13843
44f230aa
SM
13844 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13845 steal a few bits to be more compact.
13846 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13847 Remove unneeded casts.
13848
1c470562
SM
13849 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13850
888adce9
ZK
138512011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13852
13853 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13854 binding" message (bug#7967).
13855
f838ed7b
PE
138562011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13857
77861b95
PE
13858 Fix more problems found by GCC 4.6.0's static checks.
13859
de6dbc14
PE
13860 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13861 Remove unused local var.
13862
f838ed7b
PE
13863 * editfns.c (Fmessage_box): Remove unused local var.
13864
792c7b2b
PE
13865 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13866 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13867 Omit unused local vars.
c499e557 13868 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13869 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13870 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13871 Omit unused local var.
13872
ba0165e1
PE
13873 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13874 Don't assume string length fits in int.
32ad8845 13875 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13876 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13877
3c59b4c9
PE
13878 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13879 instead of alloca (Bug#8344).
13880
a3eed478 13881 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13882 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13883
eb4d412d
PE
13884 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13885
1658b401
PE
13886 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13887 concerns.
13888
13889 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13890
13891 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13892
9a2c6e05
PE
13893 * keyboard.c (syms_of_keyboard): Use the same style as later
13894 in this function when indexing through an array. This also
13895 works around GCC bug 48267.
13896
03d0a109
PE
13897 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13898
44f730c8
PE
13899 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13900
fe75f926
PE
13901 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13902 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13903
ffa8c828
PE
13904 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13905 This avoids undefined behavior on integer overflow, and is a bit
13906 more convenient anyway since it is compared to a size_t variable.
13907
c5101a77
PE
13908 Variadic C functions now count arguments with size_t, not int.
13909 This avoids an unnecessary limitation on 64-bit machines, which
13910 caused (substring ...) to crash on large vectors (Bug#8344).
13911 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13912 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13913 All variadic functions and their callers changed accordingly.
c5101a77
PE
13914 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13915 * data.c (arith_driver, float_arith_driver): Likewise.
13916 * editfns.c (general_insert_function): Likewise.
13917 * eval.c (struct backtrace.nargs, interactive_p)
13918 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13919 (funcall_lambda, mark_backtrace): Likewise.
13920 * fns.c (concat): Likewise.
13921 * frame.c (x_set_frame_parameters): Likewise.
13922 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13923 0 if not found, not -1. All callers changed.
13924
dd3f25f7
PE
13925 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13926 (stack_copy_size): Now size_t, not int.
13927 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13928
461c2ab9
JB
139292011-03-28 Juanma Barranquero <lekktu@gmail.com>
13930
13931 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13932 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13933 All callers changed.
13934
13935 * lisp.h (multibyte_char_to_unibyte):
13936 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13937 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13938 * character.h (CHAR_TO_BYTE8):
13939 * cmds.c (internal_self_insert):
13940 * editfns.c (general_insert_function):
13941 * keymap.c (push_key_description):
13942 * search.c (Freplace_match):
13943 * xdisp.c (message_dolog, set_message_1): All callers changed.
13944
f6d62986
SM
139452011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13946
13947 * keyboard.c (safe_run_hook_funcall): New function.
13948 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13949 don't set the hook to nil, but remove the offending function instead.
13950 (Qcommand_hook_internal): Remove, unused.
13951 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13952 Vcommand_hook_internal.
13953
13954 * eval.c (enum run_hooks_condition): Remove.
13955 (funcall_nil, funcall_not): New functions.
13956 (run_hook_with_args): Call each function through a `funcall' argument.
13957 Remove `cond' argument, now redundant.
13958 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13959 (Frun_hook_with_args_until_failure): Adjust accordingly.
13960 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13961
1db5b1ad
JB
139622011-03-28 Juanma Barranquero <lekktu@gmail.com>
13963
13964 * dispextern.h (string_buffer_position): Remove declaration.
13965
13966 * print.c (strout): Remove parameter `multibyte', unused since
13967 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13968
13969 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13970 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13971 All callers changed.
13972
13973 * w32.c (_wsa_errlist): Use braces for struct initializers.
13974
13975 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13976 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13977 All callers changed.
13978 (string_buffer_position): Likewise. Also, make static (it's never
13979 used outside xdisp.c).
13980 (cursor_row_p): Remove parameter `w', unused since
13981 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13982 (decode_mode_spec): Remove parameter `precision', introduced during
13983 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13984 All callers changed.
13985
5ffb62aa
JD
139862011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13987
13988 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13989
461c2ab9 139902011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13991
13992 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13993 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13994 (ns_update_auto_hide_menu_bar): New functions.
13995 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13996 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13997 ns_constrain_all_frames.
13998 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13999 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14000
5c380ffb
JD
140012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14002
14003 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14004
9af30bdf
GM
140052011-03-27 Glenn Morris <rgm@gnu.org>
14006
14007 * syssignal.h: Replace RETSIGTYPE with void.
14008 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14009 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14010 Replace SIGTYPE with void everywhere.
14011 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14012 * s/template.h (SIGTYPE): Remove commented out definition.
14013
e2abce01
JB
140142011-03-26 Eli Zaretskii <eliz@gnu.org>
14015
14016 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14017 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14018
f868cd8a
JB
140192011-03-26 Juanma Barranquero <lekktu@gmail.com>
14020
59eb0929
JB
14021 * w32.c (read_unc_volume): Use parameter `henum', instead of
14022 global variable `wget_enum_handle'.
14023
14024 * keymap.c (describe_vector): Remove parameters `indices' and
14025 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14026 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14027
f868cd8a
JB
14028 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14029
14030 * keyboard.c (timer_check): Remove parameter `do_it_now',
14031 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14032 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14033 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14034
14035 * keyboard.c (read_char):
14036 * w32menu.c (w32_menu_display_help):
14037 * xmenu.c (show_help_event, menu_help_callback):
14038 Adjust calls to `show_help_echo'.
14039
14040 * gtkutil.c (xg_maybe_add_timer):
14041 * keyboard.c (readable_events):
14042 * process.c (wait_reading_process_output):
14043 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14044
14045 * insdel.c (adjust_markers_gap_motion):
14046 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14047 (gap_left, gap_right): Don't call it.
14048
2ecf6fdb
CY
140492011-03-25 Chong Yidong <cyd@stupidchicken.com>
14050
14051 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14052 incurred during fontification.
14053
6b1f9ba4
JB
140542011-03-25 Juanma Barranquero <lekktu@gmail.com>
14055
14056 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14057 (DEFVAR_PER_BUFFER): Don't pass it.
14058
14059 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14060 (scrolling_window): Don't pass it.
14061
0f4a96b5
JB
140622011-03-25 Juanma Barranquero <lekktu@gmail.com>
14063
14064 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14065
14066 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14067 and `suffix'.
14068 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14069 of variables specific to SELinux and computation of `encoded_absname'.
14070
14071 * image.c (XPutPixel): Remove unused variable `height'.
14072
14073 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14074
14075 * unexw32.c (get_section_info): Remove unused variable `section'.
14076
14077 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14078 (system_process_attributes): Remove unused variable `sess'.
14079 (sys_read): Remove unused variable `err'.
14080
14081 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14082 (w32_wnd_proc): Remove unused variable `isdead'.
14083 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14084 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14085 (x_create_tip_frame): Remove unused variable `tem'.
14086
14087 * w32inevt.c (w32_console_read_socket):
14088 Remove unused variable `no_events'.
14089
14090 * w32term.c (x_draw_composite_glyph_string_foreground):
14091 Remove unused variable `width'.
14092
1149507c
JB
140932011-03-24 Juanma Barranquero <lekktu@gmail.com>
14094
14095 * w32term.c (x_set_glyph_string_clipping):
14096 Don't pass uninitialized region to CombineRgn.
14097
9c88f339
JB
140982011-03-23 Juanma Barranquero <lekktu@gmail.com>
14099
14100 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14101 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14102 (Fx_close_connection): Remove unused variable `i'.
14103
14104 * w32font.c (w32font_draw): Return number of glyphs.
14105 (w32font_open_internal): Remove unused variable `i'.
14106 (w32font_driver): Add missing initializer.
14107
14108 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14109 (fill_in_menu): Remove unused variable `items_added'.
14110
14111 * w32term.c (last_mouse_press_frame): Remove static global variable.
14112 (w32_clip_to_row): Remove unused variable `f'.
14113 (x_delete_terminal): Remove unused variable `i'.
14114
14115 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14116 (NOTHING): Remove unused static global variable.
14117 (uniscribe_check_otf): Remove unused variable `table'.
14118 (uniscribe_font_driver): Add missing initializers.
14119
dee091a3
JD
141202011-03-23 Julien Danjou <julien@danjou.info>
14121
14122 * term.c (Fsuspend_tty, Fresume_tty):
14123 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14124 * window.c (temp_output_buffer_show):
14125 * insdel.c (signal_before_change):
14126 * frame.c (Fhandle_switch_frame):
14127 * fileio.c (Fdo_auto_save):
14128 * emacs.c (Fkill_emacs):
14129 * editfns.c (save_excursion_restore):
14130 * cmds.c (internal_self_insert):
14131 * callint.c (Fcall_interactively):
14132 * buffer.c (Fkill_all_local_variables):
14133 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14134 Use Frun_hooks.
0f4a96b5 14135 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14136 unconditionally since it does the check itself.
dee091a3 14137
2c520ab5 141382011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14139
c9c49752
PE
14140 Fix more problems found by GCC 4.5.2's static checks.
14141
8abc3f12
PE
14142 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14143 the first time through the loop, since we know p0 < p1 then.
14144 This also avoids a gcc -Wstrict-overflow warning.
14145
a2d26660
PE
14146 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14147 leading to a memory leak, possible in functions like
14148 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14149 of objects (Bug#8318).
a2d26660 14150
916c72e9
PE
14151 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14152 that could (at least in theory) be that large.
14153
19ab8a18
PE
14154 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14155 This is less likely to overflow, and avoids undefined behavior if
14156 overflow does occur. All callers changed. Use strtoul to scan
14157 for the unsigned long integer.
b7cbbd6f
PE
14158 (pint2hrstr): Simplify and tune code slightly.
14159 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14160
f0641eff
PE
14161 * scroll.c (do_scrolling): Work around GCC bug 48228.
14162 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14163
7f650bb9
PE
14164 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14165 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14166 (validate_x_resource_name): Simplify count usage.
14167 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14168
37dd57d1
PE
14169 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14170 fail (Bug#8306).
81e56e61 14171
699979fc 14172 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14173
401bf9b4
PE
14174 * process.c (Fmake_network_process): Use socklen_t, not int,
14175 where POSIX says socklen_t is required in portable programs.
14176 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14177 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14178 (Fmake_network_process, server_accept_connection):
14179 (wait_reading_process_output, read_process_output):
14180 Likewise.
14181
b93aacde
PE
14182 * process.c: Rename or move locals to avoid shadowing.
14183 (list_processes_1, Fmake_network_process):
14184 (read_process_output_error_handler, exec_sentinel_error_handler):
14185 Rename or move locals.
4dc343ee 14186 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14187 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14188 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14189 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14190 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14191
af8a867c 14192 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14193 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14194 Include tparam.h instead, since it declares them.
af8a867c
PE
14195 * cm.h (PC): Remove extern decl; tparam.h now does this.
14196 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14197 * terminfo.c: Include tparam.h, to check interfaces.
14198 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14199 (tparam): Adjust signature to match interface in tparam.h;
14200 this removes some undefined behavior. Check that outstring and len
14201 are zero, which they always are with Emacs.
14202 * tparam.h (PC, BC, UP): New extern decls.
14203
0248044d 14204 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14205 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14206
8ff096c1 14207 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14208 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14209 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14210 (ftfont_list): Remove unused local.
49eaafba
PE
14211 (get_adstyle_property, ftfont_pattern_entity):
14212 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14213 Rename locals to avoid shadowing.
8ff096c1 14214
e2be39f6
PE
14215 * xfont.c (xfont_list_family): Mark var as initialized.
14216
c9735e30
PE
14217 * xml.c (make_dom): Now static.
14218
8f5201ae
PE
14219 * composite.c (composition_compute_stop_pos): Rename local to
14220 avoid shadowing.
b246f932
PE
14221 (composition_reseat_it): Remove unused locals.
14222 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14223 (composition_update_it): Mark var as initialized.
11b61122
PE
14224 (find_automatic_composition): Mark vars as initialized,
14225 with a FIXME (Bug#8290).
8f5201ae 14226
760fbc2c
PE
14227 character.h: Rename locals to avoid shadowing.
14228 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14229 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14230 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14231 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14232 to avoid shadowing.
14233
ff08eb85
PE
14234 * textprop.c (property_change_between_p): Remove; unused.
14235
fc7bf025
PE
14236 * intervals.c (interval_start_pos): Now static.
14237
235d7abc
PE
14238 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14239
44f230aa
SM
14240 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14241 Rename locals to avoid shadowing.
3e7d6594 14242
50060332
PE
14243 * sound.c (wav_play, au_play, Fplay_sound_internal):
14244 Fix pointer signedness.
d01f234b 14245 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14246 (wav_play): Initialize a variable to 0, to prevent undefined
14247 behavior (Bug#8278).
50060332 14248
c4fc4e30
PE
14249 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14250
918436ed
PE
14251 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14252
c939f91b
PE
14253 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14254 clobbering (Bug#8298).
b9c7f648
PE
14255 * sysdep.c (sys_subshell): Likewise.
14256 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14257
6bd8c144
PE
14258 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14259 This should get cleaned up, so that child_setup has the
14260 same signature on all platforms.
14261
7710357c 14262 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14263 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14264
c59da222
CY
142652011-03-22 Chong Yidong <cyd@stupidchicken.com>
14266
14267 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14268 not to be necessary, and produces flickering.
14269
66b87493
GM
142702011-03-20 Glenn Morris <rgm@gnu.org>
14271
14272 * config.in: Remove file.
14273
45b6f6d5
JB
142742011-03-20 Juanma Barranquero <lekktu@gmail.com>
14275
14276 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14277 are now in src/globals.h.
14278 (syms_of_minibuf): Remove spurious & from previous change.
14279
cd394be1 142802011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14281
14282 * minibuf.c (completing-read-function): New variable.
14283 (completing-read-default): Rename from completing-read.
14284 (completing-read): Call completing-read-function.
14285
b14e3e21
CY
142862011-03-19 Juanma Barranquero <lekktu@gmail.com>
14287
14288 * xfaces.c (Fx_load_color_file):
14289 Read color file from absolute filename (bug#8250).
14290
f2b726e6
JB
142912011-03-19 Juanma Barranquero <lekktu@gmail.com>
14292
14293 * makefile.w32-in: Update dependencies.
14294
09f6ff02
EZ
142952011-03-17 Eli Zaretskii <eliz@gnu.org>
14296
14297 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14298
29a6015a
PE
142992011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14300
a3a6c54e
PE
14301 Fix more problems found by GCC 4.5.2's static checks.
14302
b766f867
PE
14303 * process.c (make_serial_process_unwind, send_process_trap):
14304 (sigchld_handler): Now static.
14305
be02381c
PE
14306 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14307 That way, the code declares only the vars that it needs.
14308 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14309 * s/cygwin.h (PTY_ITERATION): Likewise.
14310 * s/darwin.h (PTY_ITERATION): Likewise.
14311 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14312
57048744
PE
14313 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14314 * process.c (allocate_pty): Don't declare stb unless it's needed.
14315
7914961c 14316 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14317 (CONSTANTLIM): Remove; unused.
14318 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14319 Define only if needed.
7914961c 14320
b3967b18
PE
14321 * unexelf.c (unexec): Name an expression,
14322 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14323 Use a different way to cause a compilation error if anyone uses
14324 n rather than nn, a way that does not involve shadowing.
73366a00 14325 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14326
29a6015a
PE
14327 * deps.mk (unexalpha.o): Remove; unused.
14328
43cfc33e 14329 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14330 * unexec.h: New file.
ce701a33
PE
14331 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14332 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14333 Depend on unexec.h.
14334 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14335 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14336 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14337 Change as necessary to match prototype in unexec.h.
ce701a33 14338
01f44d5a
PE
14339 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14340 shadowing.
4f63c6bb 14341 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14342
a6670b0b
PE
14343 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14344 Rename locals to avoid shadowing.
14345
cef2010d 14346 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14347 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14348
d4d7173a
PE
14349 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14350
f08b802a
PE
14351 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14352 warning when compiling print.c.
14353
3ddb0639
PE
14354 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14355 instead of using an uninitialized var.
5ad03b97 14356 (font_sort_entities): Mark var as initialized.
3ddb0639 14357
170a2692
PE
14358 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14359
e663c700
PE
14360 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14361 pointers to constants.
89bc529a 14362 (font_parse_fcname): Remove unused vars.
7b81e2d0 14363 (font_delete_unmatched): Now static.
ea838e10 14364 (font_get_spec): Remove; unused.
13a547c6
PE
14365 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14366 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14367 Rename or move locals to avoid shadowing.
e663c700 14368
2a80c887 14369 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14370 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14371
1384fa33 14372 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14373 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14374
8b2c52e9
PE
14375 * alloc.c (mark_backtrace): Move decl from here ...
14376 * lisp.h: ... to here, so that it can be checked.
14377
475545b5 14378 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14379 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14380 (lisp_indirect_variable): Name an expression,
14381 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14382 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14383
b1349114 14384 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14385 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14386 Use const pointer when appropriate.
b1349114 14387
a2928364
PE
14388 * lisp.h (get_system_name, get_operating_system_release):
14389 Move decls here, to check interfaces.
14390 * process.c (get_operating_system_release): Move decl to lisp.h.
14391 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14392 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14393 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14394 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14395 (Fformat_time_string, Fencode_time, Finsert_char):
14396 (Ftranslate_region_internal, Fformat):
14397 Rename or remove local vars to avoid shadowing.
9710023e 14398 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14399
a415e694
PE
14400 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14401 avoid shadowing.
14402
8ef4622d
PE
14403 * lisp.h (eassert): Check that the argument compiles, even if
14404 ENABLE_CHECKING is not defined.
14405
946f9a5b
PE
14406 * data.c (Findirect_variable): Name an expression, to avoid
14407 gcc -Wbad-function-cast warning.
112396d6 14408 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14409 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14410 (Fmake_variable_buffer_local, Fmake_local_variable):
14411 Mark variables as initialized.
52746918 14412 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14413
e5aab7e7 14414 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14415 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14416 Rename locals to avoid shadowing.
dff45157
PE
14417 (mark_stack): Move local variables into the #ifdef region where
14418 they're used.
7bc26fdb
PE
14419 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14420 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14421 needed otherwise.
14422 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14423 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14424 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14425
e5aab7e7
PE
14426 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14427 avoids undefined behavior in theory.
14428
4da60324
PE
14429 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14430
88043301
PE
14431 Use functions, not macros, for up- and down-casing (Bug#8254).
14432 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14433 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14434 to use the following functions instead of these macros.
14435 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14436 EMACS_INT, since callers assume the returned value fits in int.
14437 (upcase1): Likewise, for UPCASE_TABLE.
14438 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14439 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14440 the race-condition problem in the old DOWNCASE.
88043301 14441
19ed5445
PE
14442 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14443 Rename locals to avoid shadowing.
14444 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14445 (regex_compile, re_search_2, re_match_2_internal):
14446 Remove unused local vars.
952db0d7
PE
14447 (FREE_VAR): Rewrite so as not to use empty "else",
14448 which gcc can warn about.
da053e48 14449 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14450 (RETALLOC_IF): Define only if needed.
14451 (WORDCHAR_P): Likewise. This one is never needed, but is used
14452 only in a comment talking about a compiler bug, so put inside
14453 the #if 0 of that comment.
14454 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14455 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14456 Remove; unused.
19ed5445 14457
1f3561e4 14458 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14459 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14460 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14461
ded6f8f7
PE
14462 * search.c (simple_search): Remove unused var.
14463
dbd37a95
PE
14464 * dired.c (compile_pattern): Move decl from here ...
14465 * lisp.h: ... to here, so that it can be checked.
14466 (struct re_registers): New forward decl.
14467
7e47afad
PE
14468 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14469
85f24f61
PE
14470 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14471 All uses changed.
14472 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14473 Rename locals to avoid shadowing.
5671df8f 14474 (Fvertical_motion): Mark locals as initialized.
85f24f61 14475
181aa2be 14476 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14477 (casify_region): Mark local as initialized.
181aa2be 14478
930d429c
PE
14479 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14480
7082eac6
PE
14481 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14482 New macros, so that the caller can use some names other than
14483 gcpro1, gcpro2, etc.
14484 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14485 of the new macros.
14486 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14487 argument, for consistency with GCPRO2_VAR, etc: it is now the
14488 prefix of the variable, not the variable itself. All uses
14489 changed.
38b2c076
PE
14490 * dired.c (directory_files_internal, file_name_completion):
14491 Rename locals to avoid shadowing.
14492
15206ed9
PE
14493 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14494 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14495 dired.c's scmp function, had undefined behavior.
14496 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14497 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14498 * buffer.h: ... to here, because these macros use current_buffer,
14499 and the new implementation with inline functions needs to have
14500 current_buffer in scope now, rather than later when the macros
14501 are used.
14502 (downcase, upcase1): New static inline functions.
14503 (DOWNCASE, UPCASE1): Reimplement using these functions.
14504 This avoids undefined behavior in expressions like
14505 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14506 from race conditions in accessing the global variables
14507 case_temp1 and case_temp2.
14508 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14509 * lisp.h (case_temp1, case_temp2): Remove their decls.
14510 * character.h (ASCII_CHAR_P): Move from here ...
14511 * lisp.h: ... to here, so that the inline functions mentioned
14512 above can use them.
14513
4a6bea26
PE
14514 * dired.c (directory_files_internal_unwind): Now static.
14515
f14b7e14
PE
14516 * fileio.c (file_name_as_directory, directory_file_name):
14517 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14518 Now static.
2893f146
PE
14519 (file_name_as_directory): Use const pointers when appropriate.
14520 (Fexpand_file_name): Likewise. In particular, newdir might
14521 point at constant storage, so make it a const pointer.
fd4ead52 14522 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14523 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14524 signedness issues.
f839df0c
PE
14525 (Fset_file_times, Finsert_file_contents, auto_save_error):
14526 Rename locals to avoid shadowing.
f14b7e14 14527
5716756e 14528 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14529 (Ftry_completion, Fall_completions): Rename or remove locals
14530 to avoid shadowing.
5716756e 14531
b4c3046a
PE
14532 * marker.c (bytepos_to_charpos): Remove; unused.
14533
b45db522
PE
14534 * lisp.h (verify_bytepos, count_markers): New decls,
14535 so that gcc does not warn that these functions aren't declared.
14536
85876d07
PE
14537 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14538 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14539 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14540 (copy_text): Remove unused local var.
85876d07 14541
03d78a21 14542 * filelock.c (within_one_second): Now static.
b3dd38ab 14543 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14544
5df8f01b
PE
14545 * buffer.c (fix_overlays_before): Mark locals as initialized.
14546 (fix_start_end_in_overlays): Likewise. This function should be
14547 simplified by using pointers-to-pointers, but that's a different
14548 matter.
b1d876f1 14549 (switch_to_buffer_1): Now static.
8f54f30a
PE
14550 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14551 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14552
a70072c9 14553 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14554 Fix pointer signedness issue.
edced198
PE
14555 (sys_subshell): Mark local as volatile if checking for lint,
14556 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14557 (MAXPATHLEN): Define only if needed.
a70072c9 14558
a0977c44
PE
14559 * process.c (serial_open, serial_configure): Move decls from here ...
14560 * systty.h: ... to here, so that they can be checked.
14561
a884fdcc
PE
14562 * fns.c (get_random, seed_random): Move extern decls from here ...
14563 * lisp.h: ... to here, so that they can be checked.
14564
604efe86 14565 * sysdep.c (reset_io): Now static.
b8950c94 14566 (wait_for_termination_signal): Remove; unused.
604efe86 14567
38fc62d9
PE
14568 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14569 (copy_keymap_item, append_key, push_text_char_description):
14570 Now static.
1004a21a 14571 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14572 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14573 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14574 (describe_map_tree):
14575 Rename locals to avoid shadowing.
38fc62d9 14576
2f2650da
PE
14577 * keyboard.c: Declare functions static if they are not used elsewhere.
14578 (echo_char, echo_dash, cmd_error, top_level_2):
14579 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14580 (read_char, kbd_buffer_get_event, make_lispy_position):
14581 (make_lispy_event, make_lispy_movement, apply_modifiers):
14582 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14583 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14584 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14585 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14586 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14587
a053e86c 14588 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14589 (mark_kboards): Move decl here ...
14590 * alloc.c (mark_kboards): ... from here.
a053e86c 14591
4752793e
PE
14592 * lisp.h (force_auto_save_soon): New decl.
14593
74f10ca7 14594 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14595 (DEFINE_DUMMY_FUNCTION): New macro.
14596 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14597 Use it.
c03cd23f
PE
14598 (main): Add casts to avoid warnings
14599 if GCC considers string literals to be constants.
74f10ca7 14600
022e70d4
PE
14601 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14602
59d6fe83
PE
14603 * dbusbind.c: Pointer signedness fixes.
14604 (xd_signature, xd_append_arg, xd_initialize):
14605 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14606 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14607 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14608 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14609
78320123
PE
14610 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14611 if GCC considers string literals to be constants.
49cebcca 14612 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14613
35ac2a97
SM
146142011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14615
fb103ca9
SM
14616 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14617 (print_preprocess, print_object): New macro to fix last change.
14618
35ac2a97
SM
14619 * print.c (print_preprocess): Don't forget font objects.
14620
62973b41
JB
146212011-03-16 Juanma Barranquero <lekktu@gmail.com>
14622
14623 * emacs.c (USAGE3): Doc fixes.
14624
0e48bb22
AS
146252011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14626
14627 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14628 structure.
14629
7684e57b
JB
146302011-03-14 Juanma Barranquero <lekktu@gmail.com>
14631
14632 * lisp.h (VWindow_system, Qfile_name_history):
14633 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14634 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14635 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14636
14637 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14638 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14639
14640 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14641 * w32console.c (detect_input_pending, read_input_pending)
14642 (encode_terminal_code):
14643 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14644 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14645 (w32_system_caret_y, Qfile_name_history):
14646 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14647 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14648 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14649 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14650 * w32proc.c (Qlocal, report_file_error):
14651 * w32term.c (Vwindow_system, updating_frame):
14652 * w32uniscribe.c (initialized, uniscribe_font_driver):
14653 Remove unneeded extern declarations.
14654
2aa46d6c
CY
146552011-03-14 Chong Yidong <cyd@stupidchicken.com>
14656
c96bbc66 14657 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14658
cffc6f3b
CY
146592011-03-13 Chong Yidong <cyd@stupidchicken.com>
14660
14661 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14662 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14663 These macros can no longer be used for assignment.
14664
44f230aa
SM
14665 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14666 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14667 (record_buffer_markers, fetch_buffer_markers): New functions for
14668 recording and fetching special buffer markers.
14669 (set_buffer_internal_1, set_buffer_temp): Use them.
14670
14671 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14672
14673 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14674
14675 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14676 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14677
14678 * xdisp.c (hscroll_window_tree):
14679 (reconsider_clip_changes): Use PT instead of BUF_PT.
14680
d251f04b
EZ
146812011-03-13 Eli Zaretskii <eliz@gnu.org>
14682
14683 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14684 $(EMACS_ROOT)/lib/intprops.h.
14685
f0c77cd1
PE
146862011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14687
3eca4629
PE
14688 Fix more problems found by GCC 4.5.2's static checks.
14689
7c86ee98
PE
14690 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14691 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14692 (xg_free_frame_widgets): Make it clear that a local variable is
14693 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14694 (gdk_window_get_screen): Make it clear that this macro is needed
14695 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14696 (int_gtk_range_get_value): New function, which avoids a diagnostic
14697 from gcc -Wbad-function-cast.
14698 (xg_set_toolkit_scroll_bar_thumb): Use it.
14699 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14700 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14701 (get_utf8_string, xg_get_file_with_chooser):
14702 Rename locals to avoid shadowing.
14703 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14704
41729b81
PE
14705 * xgselect.c (xg_select): Remove unused var.
14706
f0c77cd1
PE
14707 * image.c (four_corners_best): Mark locals as initialized.
14708 (gif_load): Initialize transparent_p to zero (Bug#8238).
14709 Mark another local as initialized.
ec6cf4c6 14710 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14711
ce0ad53d 14712 * image.c (clear_image_cache): Now static.
d5d5a617 14713 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14714 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14715 (x_edge_detection): Remove unnecessary cast that
14716 gcc -Wbad-function-cast diagnoses.
2037898d 14717 (gif_load): Fix pointer signedness.
6ae141d6
PE
14718 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14719 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14720
33383987 147212011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14722
d32df629
PE
14723 Improve quality of tests for time stamp overflow.
14724 For example, without this patch (encode-time 0 0 0 1 1
14725 1152921504606846976) returns the obviously-bogus value (-948597
14726 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14727 reports time overflow. See
14728 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14729 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14730 * editfns.c: Include limits.h and intprops.h.
14731 (TIME_T_MIN, TIME_T_MAX): New macros.
14732 (time_overflow): Move earlier, to before first use.
14733 (hi_time, lo_time): New functions, for an accurate test for
14734 out-of-range times.
14735 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14736 (Fget_internal_run_time): Don't assume time_t fits in int.
14737 (make_time): Use list2 instead of Fcons twice.
14738 (Fdecode_time): More accurate test for out-of-range times.
14739 (check_tm_member): New function.
14740 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14741 (lisp_time_argument): Don't rely on undefined left-shift and
14742 right-shift behavior when checking for time stamp overflow.
8be6f318 14743
fe31d94c
PE
14744 * editfns.c (time_overflow): New function, refactoring common code.
14745 (Fformat_time_string, Fdecode_time, Fencode_time):
14746 (Fcurrent_time_string): Use it.
14747
8be6f318
PE
14748 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14749 * dired.c (make_time): Move to ...
14750 * editfns.c (make_time): ... here.
14751 * systime.h: Note the move.
14752
09d9db2c 147532011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14754
126bc0dc
YM
14755 * fringe.c (update_window_fringes): Remove unused variables.
14756
c47cbdfd
YM
14757 * unexmacosx.c (copy_data_segment): Also copy __got section.
14758 (Bug#8223)
14759
7ac80be9
EZ
147602011-03-12 Eli Zaretskii <eliz@gnu.org>
14761
c96bbc66 14762 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14763 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14764 Constify `char *' arguments and their references according to
14765 prototypes in tparam.h.
14766
ecb0f94d 14767 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14768
7ac80be9
EZ
14769 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14770 Adapt all references accordingly.
14771
14772 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14773
ef1fd07e
TT
147742011-03-11 Tom Tromey <tromey@redhat.com>
14775
14776 * buffer.c (syms_of_buffer): Remove obsolete comment.
14777
7ef4b50c
EZ
147782011-03-11 Eli Zaretskii <eliz@gnu.org>
14779
14780 * termhooks.h (encode_terminal_code): Declare prototype.
14781
14782 * msdos.c (encode_terminal_code): Don't declare prototype.
14783
14784 * term.c (encode_terminal_code): Now external again, used by
14785 w32console.c and msdos.c.
14786
44f230aa
SM
14787 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14788 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14789
4b1ec863 147902011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14791
1714f52b 14792 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14793
4b1ec863
PE
14794 * fringe.c (update_window_fringes): Mark locals as initialized
14795 (Bug#8227).
14796 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14797
524c7aa6
PE
14798 * alloc.c (mark_fringe_data): Move decl from here ...
14799 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14800 to check its interface.
14801 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14802
a5c0af81 14803 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14804 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14805 (fontset_font): Mark local as initialized.
a9a06e0b 14806 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14807
b4716021
PE
14808 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14809
811e9bac 14810 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14811 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14812 (x_own_selection, Fx_disown_selection_internal): Rename locals
14813 to avoid shadowing.
14814 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14815
7e3ab302
PE
14816 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14817 so that the caller can use some name other than gcpro1.
14818 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14819 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14820 (Fx_backspace_delete_keys_p):
14821 Use them to avoid shadowing, and rename vars to avoid shadowing.
14822 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14823 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14824 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14825 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14826 Remove unused locals.
7e3ab302
PE
14827 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14828 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14829 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14830 macros.
f78faa98 14831
e2b13473
PE
14832 * xterm.h (x_mouse_leave): New decl.
14833
77f23912
PE
14834 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14835 Remove unused functions.
cdf4ba58
PE
14836 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14837 (x_calc_absolute_position): Now static.
7411c686 14838 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14839 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14840 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14841 unless they are used.
38d0b34a
PE
14842 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14843 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14844 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14845 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14846 (x_error_catcher, x_connection_closed, x_error_handler):
14847 (x_error_quitter, xembed_send_message, x_iconify_frame):
14848 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14849 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14850 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14851
44f230aa
SM
14852 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14853 Rename or move locals to avoid shadowing.
6b463e58 14854 (tty_defined_color, merge_face_heights): Now static.
5967d051 14855 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14856 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14857 does not deduce is never used uninitialized.
73719eba
PE
14858 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14859 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14860
426994c3 14861 * terminal.c (store_terminal_param): Now static.
5489860b 14862
032f1620 14863 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14864 (set_frame_menubar): Remove unused local.
d4323972 14865 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14866 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14867 since they might point to immutable storage.
281585b0
PE
14868 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14869 since it's unused otherwise.
032f1620 14870
367c19e5 14871 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14872 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14873 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14874 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14875 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14876 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14877 does not deduce are never used uninitialized.
70739cbe 14878
07b48fa9
PE
14879 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14880
8868a238 14881 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14882 * window.c (window_loop, size_window):
14883 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14884
7e5cf297 14885 * window.c (display_buffer): Now static.
d6550a9f
PE
14886 (size_window): Mark variables that gcc -Wuninitialized
14887 does not deduce are never used uninitialized.
a586633d
PE
14888 * window.h (check_all_windows): New decl, to forestall
14889 gcc -Wmissing-prototypes diagnostic.
5b555da1 14890 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14891
f6095868
PE
14892 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14893 shadowing.
14894 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14895 Include <limits.h>.
14896 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14897 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14898 (load_charset_map): Mark variables that gcc -Wuninitialized
14899 does not deduce are never used uninitialized.
53df7c11 14900 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14901
f38b440c
PE
14902 * coding.c (coding_set_source, coding_set_destination):
14903 Use "else { /* comment */ }" rather than "else /* comment */;"
14904 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14905 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14906 a block, when the outer 'i' will do.
14907 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14908 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14909 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14910 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14911 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14912 Rename locals to avoid shadowing.
14913 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14914 * coding.c (emacs_mule_char, encode_invocation_designation):
14915 Now static, since they're not used elsewhere.
413bb2db 14916 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14917 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14918 (decode_coding_emacs_mule): Mark variables that gcc
14919 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14920 (detect_coding_iso_2022): Initialize a local variable that might
14921 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14922 this initialization is needed. (Bug#8211)
5f58e762
PE
14923 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14924 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14925 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14926 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14927 Remove unused macros.
f38b440c 14928
232b38b9 14929 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14930 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14931 * character.c (string_count_byte8): Likewise.
232b38b9 14932
fb90da1b
PE
14933 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14934 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14935
fb93dbc2
PE
14936 * chartab.c (copy_sub_char_table): Now static, since it's not used
14937 elsewhere.
5c156ace
PE
14938 (sub_char_table_ref_and_range, char_table_ref_and_range):
14939 Rename locals to avoid shadowing.
bbcd0949 14940 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14941
7d3b3862 14942 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14943 (BIDI_BOB): Remove unused macro.
7d3b3862 14944
6be7d3da
PE
14945 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14946 deduce are never used uninitialized.
c2ed9c8b 14947 * term.c (encode_terminal_code): Likewise.
6be7d3da 14948
75f8807f 14949 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14950
50938595
PE
14951 * tparam.h: New file.
14952 * term.c, tparam.h: Include it.
14953 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14954 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14955 Move these decls to tparam.h, and make them agree with what
14956 is actually in tparam.c. The previous trick of using incompatible
14957 decls in different modules does not conform to the C standard.
14958 All callers of tparam changed to use tparam's actual API.
14959 * tparam.c (tparam1, tparam, tgoto):
14960 Use const pointers where appropriate.
14961
fbceeba2
PE
14962 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14963 * cm.h (struct cm): Likewise.
14964 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14965 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14966 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14967 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14968 (turn_on_face, init_tty): Likewise.
14969 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14970
7f3f1250
PE
14971 * term.c (term_mouse_position): Rename local to avoid shadowing.
14972
e6ca6543
PE
14973 * alloc.c (mark_ttys): Move decl from here ...
14974 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14975
c40f8d15
AS
149762011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14977
14978 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14979
cfe0661d
JB
149802011-03-09 Juanma Barranquero <lekktu@gmail.com>
14981
14982 * search.c (compile_pattern_1): Remove argument regp, unused since
14983 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14984 (compile_pattern): Don't pass it.
14985
0afb4571
J
149862011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14987
14988 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14989 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14990 for ! HAVE_GTK3.
14991 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14992
14993 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14994
14995 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14996 gdk_window_get_screen, gdk_window_get_geometry,
14997 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14998 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14999 (xg_get_pixbuf_from_pixmap): New function.
15000 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15001 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15002 Call xg_get_pixbuf_from_pixmap instead of
15003 gdk_pixbuf_get_from_drawable.
15004 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15005 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15006 (xg_check_special_colors): Use GtkStyleContext and its functions
15007 for HAVE_GTK3.
15008 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15009 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15010 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15011 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15012 Call gtk_widget_get_preferred_size.
0afb4571
J
15013 (xg_frame_resized): gdk_window_get_geometry only takes 5
15014 parameters.
44f230aa
SM
15015 (xg_win_to_widget, xg_event_is_for_menubar):
15016 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15017 (xg_set_widget_bg): New function.
15018 (delete_cb): New function.
895009e1 15019 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15020 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15021 (xg_set_background_color): Call xg_set_widget_bg.
15022 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15023 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15024 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15025 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15026 if ! HAVE_GTK3.
15027 (update_frame_tool_bar): Call gtk_widget_hide.
15028 (xg_initialize): Use GDK_KEY_g.
15029
15030 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15031 if ! HAVE_GTK3
15032 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15033
15034 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15035 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15036 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15037
1c2cc4ef
JB
150382011-03-08 Juanma Barranquero <lekktu@gmail.com>
15039
15040 * w32xfns.c (select_palette): Check success of RealizePalette against
15041 GDI_ERROR, not zero.
15042
33383987 15043See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15044
15045;; Local Variables:
15046;; coding: utf-8
aac0c6e3
MR
15047;; End:
15048
2f097256 15049 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15050
15051 This file is part of GNU Emacs.
15052
15053 GNU Emacs is free software: you can redistribute it and/or modify
15054 it under the terms of the GNU General Public License as published by
15055 the Free Software Foundation, either version 3 of the License, or
15056 (at your option) any later version.
15057
15058 GNU Emacs is distributed in the hope that it will be useful,
15059 but WITHOUT ANY WARRANTY; without even the implied warranty of
15060 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15061 GNU General Public License for more details.
15062
15063 You should have received a copy of the GNU General Public License
15064 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.