* xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font): Avoid need for...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
51cab52b 12011-06-21 Paul Eggert <eggert@cs.ucla.edu>
882f0d81 2
aaafe47a
PE
3 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4 This is unlikely, but can occur if DPI is outlandish.
5
2674ddc8 6 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8
28154962
PE
9 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10 * xrdb.c (magic_file_p, search_magic_path):
11 Omit last arg SUFFIX; it was always 0. All callers changed.
12 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
13
7de51af5
PE
14 * xfont.c (xfont_match): Avoid need for strlen.
15
25ed6cc3
PE
16 * xfns.c: Don't assume strlen fits in int.
17 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
18
4eab31dd
PE
19 * xdisp.c (message_log_check_duplicate): Return intmax_t,
20 not unsigned long, as we prefer signed integers. All callers changed.
21 Detect integer overflow in repeat count.
22 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 23 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 24
171e2a58
PE
25 * termcap.c: Don't assume sizes fit in int and never overflow.
26 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
27 (gobble_line): Check for size-calculation overflow.
28
ad39faca 29 * minibuf.c (Fread_buffer):
6e5bb2dc 30 * lread.c (intern, intern_c_string):
74ca2eb3
PE
31 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
32 Don't assume string length fits in int.
33
52c61c22 34 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
35 * gtkutil.c (style_changed_cb): Avoid need for strlen.
36
b5b8c9e5
PE
37 * font.c: Don't assume string length fits in int.
38 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
39 Use ptrdiff_t, not int.
ccd6111c
PE
40 (font_intern_prop): Don't assume string length fits in int.
41 Don't assume integer property fits in fixnum.
42 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 43
882f0d81 44 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 45 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
46 Reformulate so as not to need the command string.
47 Invoke gzip -cd rather than gunzip, as it's more portable.
48 (lock_info_type, lock_file_1, lock_file):
49 Don't assume pid_t and time_t fit in unsigned long.
50 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
51 (current_lock_owner): Prefer signed type for sizes.
52 Use memcpy, not strncpy, where memcpy is what is really wanted.
53 Don't assume (via atoi) that time_t and pid_t fit in int.
54 Check for time_t and/or pid_t out of range, e.g., via a network share.
55 Don't alloca where an auto var works fine.
56
93f4cf88
PE
57 * fileio.c: Fix some integer overflow issues.
58 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
59 Don't assume string length fits in int.
60 (directory_file_name): Don't assume string length fits in long.
61 (make_temp_name): Don't assume pid fits in int, or that its print
62 length is less than 20.
63
f3e92b69
PE
64 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
65
1bfdaf10
PE
66 * coding.c (make_subsidiaries): Don't assume string length fits in int.
67
35016e9a
PE
68 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
69
3d1e65a1
PE
70 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
71 We prefer signed integers, even for size calculations.
72
0b963a93
PE
73 * emacs.c: Don't assume string length fits in 'int'.
74 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
75 (main): Don't invoke strlen when not needed.
76
573f4b54
PE
77 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
78 (XD_DEBUG_MESSAGE): Don't waste a byte.
79
989f33ba
PE
80 * callproc.c (getenv_internal_1, getenv_internal)
81 (Fgetenv_internal):
965d34eb
PE
82 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
83
e4d29b33
PE
84 * lread.c (invalid_syntax): Omit length argument.
85 All uses changed. This doesn't fix a bug, but it simplifies the
86 code away from its former Hollerith-constant appearance, and it's
87 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 88 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 89
eb49b136
PE
90 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
91 This didn't break anything, but it didn't help either.
92 It's confusing to put a bogus integer in a place where the actual
93 value does not matter.
9f62aeb1 94 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 95 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 96
15375a22
PE
97 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
98 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
99 implementation.
b61cc01c
PE
100 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
101 We prefer signed types, and the value cannot exceed the EMACS_INT
102 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
103 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
104 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
105 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 106
53b2623d
PE
107 * indent.c (sane_tab_width): New function.
108 (current_column, scan_for_column, Findent_to, position_indentation)
109 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 110 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 111
51cab52b 112 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 113
f2ed8a70
PE
114 * lisp.h (lint_assume): New macro.
115 * composite.c (composition_gstring_put_cache):
116 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
117
abe80cc6
PE
118 * editfns.c, insdel.c:
119 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 120
b02c740e
PE
121 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
122
ebc96716
PE
123 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
124
b4e50fa0 125 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 126 Use much-faster test for byte-length change.
311d5d7c 127 Don't assume string byte-length fits in 'int'.
a4cf38e4 128 Check that character arg fits in 'int'.
85461888 129 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 130
c0c1ee9f
PE
131 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
132
a498d7f4
PE
133 * fns.c (concat): Catch string overflow earlier.
134 Do not rely on integer wraparound.
135
51cab52b
PE
136 * dispextern.h (struct it.overlay_strings_charpos)
137 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
138 * xdisp.c (forward_to_next_line_start)
139 (back_to_previous_visible_line_start)
140 (reseat_at_next_visible_line_start, next_element_from_buffer):
141 Don't arbitrarily truncate the value of 'selective' to int.
142
76031fad
PE
143 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
144
5eb55db9
PE
145 * composite.c: Don't truncate sizes to 'int'.
146 (composition_gstring_p, composition_reseat_it)
147 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
148 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
149 not EMACS_UINT, for indexes.
5eb55db9 150
0703a717
PE
151 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
152
d6202519
PE
153 * buffer.c: Include <verify.h>.
154 (struct sortvec.priority, struct sortstr.priority):
8961a454 155 Now EMACS_INT, not int.
c20998a7 156 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
157 (struct sortstr.size, record_overlay_string)
158 (struct sortstrlist.size, struct sortlist.used):
159 Don't truncate size to int.
160 (record_overlay_string): Check for size-calculation overflow.
d6202519 161 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 162
76147d94
DD
1632011-06-20 Deniz Dogan <deniz@dogan.se>
164
165 * process.c (Fset_process_buffer): Clarify return value in
166 docstring.
167
7d7d0045
CY
1682011-06-18 Chong Yidong <cyd@stupidchicken.com>
169
170 * dispnew.c (add_window_display_history): Use BVAR.
171
172 * xdisp.c (debug_method_add): Use BVAR.
173 (check_window_end, dump_glyph_matrix, dump_glyph)
174 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
175
176 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
177 Likewise.
178
179 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
180 check till after the cache is created in init_frame_faces.
181
ff2bc410
SM
1822011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
183
184 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
185
28177add
PE
1862011-06-16 Paul Eggert <eggert@cs.ucla.edu>
187
dd3482fe
PE
188 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
189 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
190 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
191
393d71f3 192 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
193 * fileio.c (Finsert_file_contents):
194 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
195 Remove the old (too-loose) buffer overflow checks.
196 They weren't needed, since make_gap checks for buffer overflow.
197 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
198 The old code merely checked for Emacs fixnum overflow, and relied
199 on undefined (wraparound) behavior. The new code avoids undefined
200 behavior, and also checks for ptrdiff_t and/or size_t overflow.
201
2e6813b0 202 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
203 Tune. Don't use wider integers than needed. Don't use alloca.
204 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 205
599a9e4f
PE
206 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
207
99561444
PE
208 * insdel.c, lisp.h (buffer_overflow): New function.
209 (insert_from_buffer_1, replace_range, replace_range_2):
210 * insdel.c (make_gap_larger):
211 * editfns.c (Finsert_char):
212 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
213
28177add
PE
214 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
215
e69dafad
PE
2162011-06-15 Paul Eggert <eggert@cs.ucla.edu>
217
a7af7fde 218 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 219
b1c46f02
PE
220 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
221 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
222
e69dafad
PE
223 * fileio.c: Don't assume EMACS_INT fits in off_t.
224 (emacs_lseek): New static function.
225 (Finsert_file_contents, Fwrite_region): Use it.
226 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
227
566684ea
PE
228 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
229
e6966cd6
PE
230 * fns.c: Don't overflow int when computing a list length.
231 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
232 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
233 truncation on 64-bit hosts. Check for QUIT every
234 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
235 faster and is responsive enough.
236 (Flength): Report an error instead of overflowing an integer.
237 (Fsafe_length): Return a float if the value is not representable
238 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 239 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 240 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 241
dd0b0efb
PE
242 * alloc.c: Check that resized vectors' lengths fit in fixnums.
243 (header_size, word_size): New constants.
244 (allocate_vectorlike): Don't check size overflow here.
245 (allocate_vector): Check it here instead, since this is the only
246 caller of allocate_vectorlike that could cause overflow.
247 Check that the new vector's length is representable as a fixnum.
248
86fe5cfe
PE
249 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
250 The previous code was bogus. For example, next_almost_prime (32)
251 returned 39, which is undesirable as it is a multiple of 3; and
252 next_almost_prime (24) returned 25, which is a multiple of 5 so
253 why was the code bothering to check for multiples of 7?
254
80e88859
PE
255 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
256
4a2f0ad6
PE
257 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
258
f66c7cf8
PE
259 Variadic C functions now count arguments with ptrdiff_t.
260 This partly undoes my 2011-03-30 change, which replaced int with size_t.
261 Back then I didn't know that the Emacs coding style prefers signed int.
262 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
263 were being counted with int, which may truncate counts on 64-bit
264 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
265 * lisp.h (struct Lisp_Subr.function.aMANY)
266 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
267 Arg counts are now ptrdiff_t, not size_t.
268 All variadic functions and their callers changed accordingly.
269 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
270 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
271 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
272 * callint.c (Fcall_interactively): Check arg count for overflow,
273 to avoid potential buffer overrun. Use signed char, not 'int',
274 for 'varies' array, so that we needn't bother to check its size
275 calculation for overflow.
276 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
277 * eval.c (apply_lambda):
278 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
279 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
280 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
281
a1759b76
PE
282 * callint.c (Fcall_interactively): Don't use index var as event count.
283
d96be9fc
PE
284 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
285 * mem-limits.h (SIZE): Remove; no longer used.
286
a690a978 287 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 288
578c21e6
PE
289 Remove unnecessary casts.
290 * xterm.c (x_term_init):
291 * xfns.c (x_set_border_pixel):
292 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
293 These aren't needed now that we assume ANSI C.
294
96f53c6c
PE
295 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
296 It's more likely to cause problems (due to unsigned overflow)
297 than to cure them.
298
83c77d31
PE
299 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
300
ee2079f1
PE
301 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
302
6da65536
PE
303 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
304
7147c4a4
PE
305 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
306
193e32d9
PE
307 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
308
e5533da6
PE
309 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
310
9910e595
PE
311 GLYPH_CODE_FACE returns EMACS_INT, not int.
312 * dispextern.h (merge_faces):
313 * xfaces.c (merge_faces):
01103c44
PE
314 * xdisp.c (get_next_display_element, next_element_from_display_vector):
315 Don't assume EMACS_INT fits in int.
9910e595 316
2638320e
PE
317 * character.h (CHAR_VALID_P): Remove unused parameter.
318 * fontset.c, lisp.h, xdisp.c: All uses changed.
319
045eb8d9
PE
320 * editfns.c (Ftranslate_region_internal): Omit redundant test.
321
c1f134b5
PE
322 * fns.c (concat): Minor tuning based on overflow analysis.
323 This doesn't fix any bugs. Use int to hold character, instead
324 of constantly refetching from Emacs object. Use XFASTINT, not
325 XINT, for value known to be a character. Don't bother comparing
326 a single byte to 0400, as it's always less.
327
395fcb93 328 * floatfns.c (Fexpt):
327eeec8
PE
329 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
330
abbd3d23
PE
331 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
332 for characters.
333
684a03ef
PE
334 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
335
0fed43f3
PE
336 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
337 Without this fix, on a 64-bit host (aset S 0 4294967386) would
338 incorrectly succeed when S was a string, because 4294967386 was
339 truncated before it was used.
340
8fd02eb7
PE
341 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
342 Otherwise, an out-of-range integer could cause undefined behavior
343 on a 64-bit host.
344
f8c86b69
PE
345 * composite.c: Use int, not EMACS_INT, for characters.
346 (fill_gstring_body, composition_compute_stop_pos): Use int, not
347 EMACS_INT, for values that are known to be in character range.
348 This doesn't fix any bugs but is the usual style inside Emacs and
349 may generate better code on 32-bit machines.
350
34206dd2
PE
351 Make sure a 64-bit char is never passed to ENCODE_CHAR.
352 This is for reasons similar to the recent CHAR_STRING fix.
353 * charset.c (Fencode_char): Check that character arg is actually
354 a character. Pass an int to ENCODE_CHAR.
355 * charset.h (ENCODE_CHAR): Verify that the character argument is no
356 wider than 'int', as a compile-time check to prevent future regressions
357 in this area.
358
c5958d4c 359 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
360
361 Make sure a 64-bit char is never passed to CHAR_STRING.
362 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
363 by silently ignoring the top 32 bits, allowing some values
364 that were far too large to be valid characters.
365 * character.h: Include <verify.h>.
366 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
367 arguments are no wider than unsigned, as a compile-time check
368 to prevent future regressions in this area.
369 * data.c (Faset):
01103c44 370 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
371 (Fsubst_char_in_region):
372 * fns.c (concat):
373 * xdisp.c (decode_mode_spec_coding):
374 Adjust to CHAR_STRING's new requirement.
375 * editfns.c (Finsert_char, Fsubst_char_in_region):
376 * fns.c (concat): Check that character args are actually
377 characters. Without this test, these functions did the wrong
378 thing with wildly out-of-range values on 64-bit hosts.
379
d37ca623
PE
380 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
381 These casts should not be needed on 32-bit hosts, either.
382 * keyboard.c (read_char):
383 * lread.c (Fload): Remove casts to unsigned.
384
ea204efb
PE
385 * lisp.h (UNSIGNED_CMP): New macro.
386 This fixes comparison bugs on 64-bit hosts.
387 (ASCII_CHAR_P): Use it.
388 * casefiddle.c (casify_object):
01103c44 389 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
390 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
391 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
392 * dispextern.h (FACE_FROM_ID):
393 * keyboard.c (read_char): Use UNSIGNED_CMP.
394
41cb286c
PE
395 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
396 not to EMACS_INT, to avoid GCC warning.
397
4a1b9832
PE
398 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
399
55daad71
PE
400 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
401 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
402 isn't needed on 32-bit machines.
8f95c75c 403
01103c44
PE
404 * buffer.c (Fgenerate_new_buffer_name):
405 Use EMACS_INT for count, not int.
0ceccced 406 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
407
408 * data.c (Qcompiled_function): Now static.
409
c6f072e7
PE
410 * window.c (window_body_lines): Now static.
411
20ce5912
PE
412 * image.c (gif_load): Rename local to avoid shadowing.
413
9c4c5f81
PE
414 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
415 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
416 * alloc.c (make_save_value): Integer argument is now of type
417 ptrdiff_t, not int.
418 (mark_object): Use ptrdiff_t, not int.
419 * lisp.h (pD): New macro.
420 * print.c (print_object): Use it.
421
c0c5c8ae
PE
422 * alloc.c: Use EMACS_INT, not int, to count objects.
423 (total_conses, total_markers, total_symbols, total_vector_size)
424 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
425 (total_free_floats, total_floats, total_free_intervals)
426 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
427 Now EMACS_INT, not int. All uses changed.
428 (Fgarbage_collect): Compute overall total using a double, so that
429 integer overflow is less likely to be a problem. Check for overflow
430 when converting back to an integer.
5a25e253
PE
431 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
432 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
433 These were 'int' variables that could overflow on 64-bit hosts;
434 they were never used, so remove them instead of repairing them.
211a0b2a 435 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
436 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
437 Previously, this ceilinged at INT_MAX, but that doesn't work on
438 64-bit machines.
e46bb31a 439 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 440
c78baabf 441 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 442 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
443 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
444 when a (possibly-narrower) signed value would do just as well.
445 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 446
c9d624c6
PE
447 * alloc.c: Catch some string size overflows that we were missing.
448 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
449 for convenience in STRING_BYTES_MAX.
450 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
451 The definition here is exact; the one in lisp.h was approximate.
452 (allocate_string_data): Check for string overflow. This catches
453 some instances we weren't catching before. Also, it catches
454 size_t overflow on (unusual) hosts where SIZE_MAX <= min
455 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
456 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 457
c9d624c6
PE
458 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
459 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
460 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
461
353032ce
PE
462 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
463
2bccce07
PE
464 * alloc.c (Fmake_string): Check for out-of-range init.
465
0ac30604
SM
4662011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
467
468 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
469
c195f2de
JD
4702011-06-14 Jan Djärv <jan.h.d@swipnet.se>
471
472 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
473 xg_get_default_scrollbar_width.
474
475 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
476 (int_gtk_range_get_value): Move to the scroll bar part of the file.
477 (style_changed_cb): Call update_theme_scrollbar_width and call
478 x_set_scroll_bar_default_width and xg_frame_set_char_size for
479 all frames (Bug#8505).
480 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
481 Call gtk_window_set_resizable if HAVE_GTK3.
482 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
483 and height if HAVE_GTK3 (Bug#8505).
484 (scroll_bar_width_for_theme): New variable.
485 (update_theme_scrollbar_width): New function.
486 (xg_get_default_scrollbar_width): Move code to
487 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
488 (xg_initialize): Call update_theme_scrollbar_width.
489
490 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
491
492 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
493
e10ac9f1
MR
4942011-06-12 Martin Rudalics <rudalics@gmx.at>
495
496 * frame.c (make_frame): Call other_buffer_safely instead of
497 other_buffer.
498
499 * window.c (temp_output_buffer_show): Call display_buffer with
500 second argument Vtemp_buffer_show_specifiers and reset latter
501 immediately after the call.
502 (Vtemp_buffer_show_specifiers): New variable.
503 (auto_window_vscroll_p, next_screen_context_lines)
504 (Vscroll_preserve_screen_position): Remove leading asterisks from
505 doc-strings.
506
2d3c217e 5072011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 508
7b7f97e8 509 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
510 * buffer.c (Qclone_number): Remove for now, as it's unused.
511 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
512 (record_buffer): Remove unused local.
513 * frame.c (other_visible_frames, frame_buffer_list): Now static.
514 (set_frame_buffer_list): Remove; unused.
515 * frame.h (other_visible_frames): Remove decl.
516 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
517 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
518 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
519 if HAVE_GPM.
520 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
521 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
522 Define only if HAVE_GPM.
523 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
524 (update_hints_inhibit): Remove; never set. All uses removed.
525 * widgetprv.h (emacsFrameClassRec): Remove decl.
526 * window.c (delete_deletable_window): Now returns void, since it
527 wasn't returning anything.
528 (compare_window_configurations): Remove unused locals.
529 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
530 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
531 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
532 the same widths as pointers. This follows up on the 2011-05-06 patch.
533 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
534 * xterm.h: Likewise.
535 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
536
1384b89e
JB
5372011-06-12 Juanma Barranquero <lekktu@gmail.com>
538
539 * makefile.w32-in: Update dependencies.
540 (LISP_H): Add lib/intprops.h.
541
1100a63c
CY
5422011-06-11 Chong Yidong <cyd@stupidchicken.com>
543
544 * image.c (gif_load): Add animation frame delay to the metadata.
545 (syms_of_image): Use DEFSYM. New symbol `delay'.
546
6198ccd0
MR
5472011-06-11 Martin Rudalics <rudalics@gmx.at>
548
549 * window.c (delete_deletable_window): Re-add.
550 (Fset_window_configuration): Rewrite to handle dead buffers and
551 consequently deletable windows.
552 (window_tree, Fwindow_tree): Remove. Supply functionality in
553 window.el.
554 (compare_window_configurations): Simplify code.
555
b6e3633c
AS
5562011-06-11 Andreas Schwab <schwab@linux-m68k.org>
557
1ab0dee5
AS
558 * image.c (imagemagick_load_image): Fix type mismatch.
559 (Fimagemagick_types): Likewise.
560
b6e3633c
AS
561 * window.h (replace_buffer_in_windows): Declare.
562
9397e56f
MR
5632011-06-11 Martin Rudalics <rudalics@gmx.at>
564
565 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
566 Qclone_number. Remove external declaration of Qdelete_window.
567 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
568 code.
569 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
570 Qbuffer_list_update_hook if allowed.
571 (Fother_buffer): Rewrite doc-string. Major rewrite for new
572 buffer list implementation.
573 (other_buffer_safely): New function.
574 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
575 calls to replace_buffer_in_windows and
576 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
577 if allowed.
578 (record_buffer): Inhibit quitting and rewrite using quittable
579 functions. Run Qbuffer_list_update_hook if allowed.
580 (Frecord_buffer, Funrecord_buffer): New functions.
581 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
582 switch-to-buffer to window.el.
583 (bury-buffer): Move to window.el.
584 (Vbuffer_list_update_hook): New variable.
585
586 * lisp.h (other_buffer_safely): Add prototype in buffer.c
587 section.
588
589 * window.h (resize_frame_windows): Move up in code.
590 (Fwindow_frame): Remove EXFUN.
591 (replace_buffer_in_all_windows): Remove prototype.
592 (replace_buffer_in_windows_safely): Add prototype.
593
594 * window.c: Declare Qdelete_window static again. Move down
595 declaration of select_count.
596 (Fnext_window, Fprevious_window): Rewrite doc-strings.
597 (Fother_window): Move to window.el.
598 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
599 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
600 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
601 window.el.
602 (replace_buffer_in_windows): Implement by calling
603 Qreplace_buffer_in_windows.
604 (replace_buffer_in_all_windows): Remove with some functionality
605 moved into replace_buffer_in_windows_safely.
606 (replace_buffer_in_windows_safely): New function.
607 (select_window_norecord, select_frame_norecord): Move in front
608 of run_window_configuration_change_hook. Remove now obsolete
609 declarations.
610 (Fset_window_buffer): Rewrite doc-string. Call
611 Qrecord_window_buffer.
612 (keys_of_window): Move binding for other-window to window.el.
613
b50691aa
CY
6142011-06-11 Chong Yidong <cyd@stupidchicken.com>
615
616 * dispextern.h (struct image): Replace data member, whose int_val
617 and ptr_val fields were not used by anything, with a single
618 lisp_val object.
619
620 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
621 (gif_clear_image, gif_load, imagemagick_load_image)
622 (gs_clear_image, gs_load): Callers changed.
623
3f754b86
PE
6242011-06-10 Paul Eggert <eggert@cs.ucla.edu>
625
cca69397
PE
626 * buffer.h: Include <time.h>, for time_t.
627 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
628
109e28d0
PE
629 Fix minor problems found by static checking.
630
60737f02
PE
631 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
632
4b66faf3
PE
633 Make identifiers static if they are not used in other modules.
634 * data.c (Qcompiled_function, Qframe, Qvector):
635 * image.c (QimageMagick, Qsvg):
636 * minibuf.c (Qmetadata):
637 * window.c (resize_window_check, resize_root_window): Now static.
638 * window.h (resize_window_check, resize_root_window): Remove decls.
639
109e28d0
PE
640 * window.c (window_deletion_count, delete_deletable_window):
641 Remove; unused.
46a4ce9e
PE
642 (window_body_lines): Now static.
643 (Fdelete_other_windows_internal): Mark vars as initialized.
644 Make sure 'resize_failed' is initialized.
645 (run_window_configuration_change_hook): Rename local to avoid shadowing.
646 (resize_window_apply): Remove unused local.
647 * window.h (delete_deletable_window): Remove decl.
648
109e28d0 649 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
650 (imagemagick_load_image): Fix pointer signedness problem by changing
651 last arg from unsigned char * to char *. All uses changed.
652 Also, fix a local for similar reasons.
653 Remove unused locals. Remove locals to avoid shadowing.
654 (fn_rsvg_handle_free): Remove; unused.
655 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 656 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 657
3f754b86
PE
658 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
659
2547adb1
CY
6602011-06-10 Chong Yidong <cyd@stupidchicken.com>
661
662 * image.c (gif_load): Fix omitted cast error introduced by
663 2011-06-06 change.
664
2c8e37d4
MR
6652011-06-10 Martin Rudalics <rudalics@gmx.at>
666
667 * window.h (resize_proportionally, orig_total_lines)
668 (orig_top_line): Remove from window structure.
669 (set_window_height, set_window_width, change_window_heights)
670 (Fdelete_window): Remove prototypes.
671 (resize_frame_windows): Remove duplicate declaration.
672
440a42e3
EZ
6732011-06-10 Eli Zaretskii <eliz@gnu.org>
674
675 * window.h (resize_frame_windows, resize_window_check)
676 (delete_deletable_window, resize_root_window)
677 (resize_frame_windows): Declare prototypes.
678
679 * window.c (resize_window_apply): Make definition be "static" to
680 match the prototype.
681
562dd5e9
MR
6822011-06-10 Martin Rudalics <rudalics@gmx.at>
683
684 * window.c: Remove declarations of Qwindow_size_fixed,
685 window_min_size_1, window_min_size_2, window_min_size,
686 size_window, window_fixed_size_p, enlarge_window, delete_window.
687 Remove static from declaration of Qdelete_window, it's
688 temporarily needed by Fbury_buffer.
689 (replace_window): Don't assign orig_top_line and
690 orig_total_lines.
691 (Fdelete_window, delete_window): Remove. Window deletion is
692 handled by window.el.
693 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
694 Fdelete_window calls with calls to Qdelete_window.
695 (Fdelete_other_windows): Remove. Deleting other windows is
696 handled by window.el.
697 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
698 handled in window.el.
699 (window_min_size_2, window_min_size_1, window_min_size): Remove.
700 Window minimum sizes are handled in window.el.
701 (shrink_windows, size_window, set_window_height)
702 (set_window_width, change_window_heights, window_height)
703 (window_width, CURBEG, CURSIZE, enlarge_window)
704 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
705 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
706 handled in window.el.
707 (make_dummy_parent): Rename to make_parent_window and give it a
708 second argument horflag.
709 (make_window): Don't set resize_proportionally any more.
710 (Fsplit_window): Remove. Windows are split in window.el.
711 (save_restore_action, save_restore_orig_size)
712 (shrink_window_lowest_first, save_restore_orig_size): Remove.
713 Resize mini windows in window.el.
714 (grow_mini_window, shrink_mini_window): Implement by calling
715 Qresize_root_window_vertically, resize_window_check and
716 resize_window_apply.
717 (saved_window, Fset_window_configuration, save_window_save): Do
718 not handle orig_top_line, orig_total_lines, and
719 resize_proportionally.
720 (window_min_height, window_min_width): Move to window.el.
721 (keys_of_window): Move bindings for delete-other-windows,
722 split-window, delete-window and enlarge-window to window.el.
723
724 * buffer.c: Temporarily extern Qdelete_window.
725 (Fbury_buffer): Temporarily call Qdelete_window instead of
726 Fdelete_window (Fbury_buffer will move to window.el soon).
727
728 * frame.c (set_menu_bar_lines_1): Remove code handling
729 orig_top_line and orig_total_lines.
730
731 * dispnew.c (adjust_frame_glyphs_initially): Don't use
732 set_window_height but set heights directly.
733 (change_frame_size_1): Use resize_frame_windows.
734
735 * xdisp.c (init_xdisp): Don't use set_window_height but set
736 heights directly.
737
738 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
739 resize_frame_windows instead of change_window_heights and run
740 run_window_configuration_change_hook.
741
742 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
743 instead of change_window_heights and run
744 run_window_configuration_change_hook.
745
1a13852e
MR
7462011-06-09 Martin Rudalics <rudalics@gmx.at>
747
748 * window.c (replace_window): Rename second argument REPLACEMENT to
749 NEW. New third argument SETFLAG. Rewrite.
750 (delete_window, make_dummy_parent): Call replace_window with
751 third argument 1.
752 (window_list_1): Move down in code.
753 (run_window_configuration_change_hook): Move set_buffer part
754 before select_frame_norecord part in order to unwind correctly.
755 Rename count1 to count.
756 (recombine_windows, delete_deletable_window, resize_root_window)
757 (Fdelete_other_windows_internal)
758 (Frun_window_configuration_change_hook, make_parent_window)
759 (resize_window_check, resize_window_apply, Fresize_window_apply)
760 (resize_frame_windows, Fsplit_window_internal)
761 (Fdelete_window_internal, Fresize_mini_window_internal): New
762 functions.
763 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
764
f3d1777e
MR
7652011-06-08 Martin Rudalics <rudalics@gmx.at>
766
496e208e
MR
767 * window.h (window): Add some new members to window structure -
768 normal_lines, normal_cols, new_total, new_normal, clone_number,
769 splits, nest, prev_buffers, next_buffers.
770 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 771 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 772
f3d1777e
MR
773 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
774 Remove.
496e208e
MR
775 (make_dummy_parent): Set new members of windows structure.
776 (make_window): Move down in code. Handle new members of window
777 structure.
778 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
779 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
780 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
781 (Fset_window_prev_buffers, Fwindow_next_buffers)
782 (Fset_window_next_buffers, Fset_window_clone_number): New
783 functions.
784 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
785 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
786 Doc-string fixes.
787 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
788 Argument WINDOW can be now internal window too.
789 (Fwindow_use_time): Move up in code.
790 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
791 Rewrite doc-string.
792 (Fset_window_configuration, saved_window)
793 (Fcurrent_window_configuration, save_window_save): Handle new
794 members of window structure.
b9e809c2
MR
795 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
796 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
797 (syms_of_window): New Lisp objects Qrecord_window_buffer,
798 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
799 Qget_mru_window, Qresize_root_window,
800 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
801 Qauto_buffer_name; staticpro them.
f3d1777e 802
abde8f8c
MR
8032011-06-07 Martin Rudalics <rudalics@gmx.at>
804
805 * window.c (Fwindow_total_size, Fwindow_left_column)
806 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
807 (Fwindow_list_1): New functions.
808 (window_box_text_cols): Replace with window_body_cols.
809 (Fwindow_width, Fscroll_left, Fscroll_right): Use
810 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
811 (delete_window, Fset_window_configuration): Call
812 delete_all_subwindows with window as argument.
813 (delete_all_subwindows): Take a window as argument and not a
814 structure. Rewrite.
190b47e6
MR
815 (window_loop): Remove handling of GET_LRU_WINDOW and
816 GET_LARGEST_WINDOW.
817 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
818
819 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
820 window_box_text_cols. delete_all_subwindows now takes a
821 Lisp_Object as argument.
abde8f8c
MR
822
823 * indent.c (compute_motion, Fcompute_motion): Use
824 window_body_cols instead of window_box_text_cols.
825
fa8a67e6
MR
826 * frame.c (delete_frame): Call delete_all_subwindows with root
827 window as argument.
828
a54e3482
DC
8292011-06-07 Daniel Colascione <dan.colascione@gmail.com>
830
831 * fns.c (Fputhash): Document return value.
832
60002bf5
CY
8332011-06-06 Chong Yidong <cyd@stupidchicken.com>
834
835 * image.c (gif_load): Implement gif89a spec "no disposal" method.
836
0c671da6 8372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 838
b862a52a 839 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 840
be44ca6c
PE
841 Check for overflow when converting integer to cons and back.
842 * charset.c (Fdefine_charset_internal, Fdecode_char):
843 Use cons_to_unsigned to catch overflow.
844 (Fencode_char): Use INTEGER_TO_CONS.
845 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
846 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
847 * data.c (long_to_cons, cons_to_long): Remove.
848 (cons_to_unsigned, cons_to_signed): New functions.
849 These signal an error for invalid or out-of-range values.
850 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
851 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
852 * font.c (Ffont_variation_glyphs):
853 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
854 * lisp.h: Include <intprops.h>.
855 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
856 (cons_to_signed, cons_to_unsigned): New decls.
857 (long_to_cons, cons_to_long): Remove decls.
858 * undo.c (record_first_change): Use INTEGER_TO_CONS.
859 (Fprimitive_undo): Use CONS_TO_INTEGER.
860 * xfns.c (Fx_window_property): Likewise.
861 * xselect.c: Include <limits.h>.
862 (x_own_selection, selection_data_to_lisp_data):
863 Use INTEGER_TO_CONS.
864 (x_handle_selection_request, x_handle_selection_clear)
865 (x_get_foreign_selection, Fx_disown_selection_internal)
866 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
867 (lisp_data_to_selection_data): Use cons_to_unsigned.
868 (x_fill_property_data): Use cons_to_signed.
869 Report values out of range.
870
d1f3d2af
PE
871 Check for buffer and string overflow more precisely.
872 * buffer.h (BUF_BYTES_MAX): New macro.
873 * lisp.h (STRING_BYTES_MAX): New macro.
874 * alloc.c (Fmake_string):
875 * character.c (string_escape_byte8):
876 * coding.c (coding_alloc_by_realloc):
877 * doprnt.c (doprnt):
878 * editfns.c (Fformat):
879 * eval.c (verror):
880 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
881 since they may not be the same number.
882 * editfns.c (Finsert_char):
883 * fileio.c (Finsert_file_contents):
884 Likewise for BUF_BYTES_MAX.
885
dd52fcea
PE
886 * image.c: Use ptrdiff_t, not int, for sizes.
887 (slurp_file): Switch from int to ptrdiff_t.
888 All uses changed.
889 (slurp_file): Check that file size fits in both size_t (for
890 malloc) and ptrdiff_t (for sanity and safety).
891
7f9bbdbb
PE
892 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
893 if b->modtime has its maximal value.
894
dfe18f82
PE
895 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
896
84acfcf0
PE
897 Don't assume time_t can fit into int.
898 * buffer.h (struct buffer.modtime): Now time_t, not int.
899 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
900 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
901
ccd9a01a
PE
902 Minor fixes for signed vs unsigned integers.
903 * character.h (MAYBE_UNIFY_CHAR):
904 * charset.c (maybe_unify_char):
905 * keyboard.c (read_char, reorder_modifiers):
906 XINT -> XFASTINT, since the integer must be nonnegative.
907 * ftfont.c (ftfont_spec_pattern):
908 * keymap.c (access_keymap, silly_event_symbol_error):
909 XUINT -> XFASTINT, since the integer must be nonnegative.
910 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
911 since it makes no difference and we prefer signed.
912 * keyboard.c (record_char): Use XUINT when all the neighbors do.
913 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
914 nonnegative.
915
d6d100dd
SM
9162011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
917
918 * window.h (Fwindow_frame): Declare.
919
2b6148e4
PE
9202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
921
922 * alloc.c: Simplify handling of large-request failures (Bug#8800).
923 (SPARE_MEMORY): Always define.
924 (LARGE_REQUEST): Remove.
925 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
926
f230ecc9
MR
9272011-06-06 Martin Rudalics <rudalics@gmx.at>
928
727e958e
MR
929 * lisp.h: Move EXFUNS for Fframe_root_window,
930 Fframe_first_window and Fset_frame_selected_window to window.h.
931
932 * window.h: Move EXFUNS for Fframe_root_window,
933 Fframe_first_window and Fset_frame_selected_window here from
934 lisp.h.
935
936 * frame.c (Fwindow_frame, Fframe_first_window)
937 (Fframe_root_window, Fframe_selected_window)
938 (Fset_frame_selected_window): Move to window.c.
939 (Factive_minibuffer_window): Move to minibuf.c.
940 (Fother_visible_frames_p): New function.
941
942 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
943
f230ecc9
MR
944 * window.c (decode_window, decode_any_window): Move up in code.
945 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
946 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
947 (Fwindow_buffer): Move up and rewrite doc-string.
948 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
949 (Fwindow_prev): New functions.
727e958e
MR
950 (Fwindow_frame): Move here from frame.c. Accept any window as
951 argument.
952 (Fframe_root_window, Fframe_first_window)
953 (Fframe_selected_window): Move here from frame.c. Accept frame
954 or arbitrary window as argument. Update doc-strings.
955 (Fminibuffer_window): Move up in code.
956 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
957 (Fset_frame_selected_window): Move here from frame.c.
958 Marginal rewrite.
727e958e
MR
959 (Fselected_window, select_window, Fselect_window): Move up in
960 code. Minor doc-string fixes.
f230ecc9 961
4d09bcf6
PE
9622011-06-06 Paul Eggert <eggert@cs.ucla.edu>
963
964 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
965 Do not assume that spare memory exists; that assumption is valid
966 only if SYSTEM_MALLOC.
967 (LARGE_REQUEST): New macro, so that the issue of large requests
968 is separated from the issue of spare memory.
969
810928a2
AS
9702011-06-05 Andreas Schwab <schwab@linux-m68k.org>
971
172418ad
AS
972 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
973 format. (Bug#8806)
974
43f862f7
AS
975 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
976
810928a2
AS
977 * xfns.c (x_set_scroll_bar_default_width): Move declarations
978 before statements.
979
a059fe24
JD
9802011-06-05 Jan Djärv <jan.h.d@swipnet.se>
981
982 * gtkutil.c (xg_get_default_scrollbar_width): New function.
983
984 * gtkutil.h: Declare xg_get_default_scrollbar_width.
985
986 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
987 min width by calling x_set_scroll_bar_default_width (Bug#8505).
988
989bf368
JB
9892011-06-05 Juanma Barranquero <lekktu@gmail.com>
990
991 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
992
4b80f674
CY
9932011-06-04 Chong Yidong <cyd@stupidchicken.com>
994
995 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
996 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
997 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
998 New error handlers.
4b80f674
CY
999 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1000 Obey Vx_select_enable_clipboard_manager. Catch errors in
1001 x_clipboard_manager_save (Bug#8779).
1002 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1003 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1004
99a33b77 10052011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1006
1007 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1008
99a33b77 10092011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1010
1011 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1012 in the current matrix if keep_current_p is non-zero.
1013
8264569d
EZ
10142011-06-04 Eli Zaretskii <eliz@gnu.org>
1015
1016 * bidi.c (bidi_level_of_next_char): Fix last change.
1017
57f97249
EZ
10182011-06-03 Eli Zaretskii <eliz@gnu.org>
1019
fec2107c 1020 Support bidi reordering of text covered by display properties.
57f97249 1021
fec2107c
EZ
1022 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1023 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1024 (bidi_cache_search, bidi_cache_iterator_state)
1025 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1026 (bidi_level_of_next_char, bidi_move_to_visually_next):
1027 Support character positions inside a run of characters covered by a
fec2107c
EZ
1028 display string.
1029 (bidi_paragraph_init, bidi_resolve_explicit_1)
1030 (bidi_level_of_next_char): Call bidi_fetch_char and
1031 bidi_fetch_char_advance instead of FETCH_CHAR and
1032 FETCH_CHAR_ADVANCE.
1033 (bidi_init_it): Initialize new members.
1034 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1035 definitions.
1036 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1037 instead of using explicit *_CHAR codes.
d6d100dd
SM
1038 (bidi_resolve_explicit, bidi_resolve_weak):
1039 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1040 bidirectional text is supported only in multibyte buffers.
1041 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1042 it to initialize the frame_window_p member of struct bidi_it.
1043 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1044 (bidi_resolve_explicit, bidi_resolve_weak)
1045 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1046 bidi_it->nchars is non-positive.
1047 (bidi_level_of_next_char): Don't try to lookup the cache for the
1048 next/previous character if nothing is cached there yet, or if we
1049 were just reseat()'ed to a new position.
c40e2fb2 1050
0e14fe90
EZ
1051 * xdisp.c (set_cursor_from_row): Set start and stop points
1052 according to the row's direction when priming the loop that looks
1053 for the glyph on which to display cursor.
1054 (single_display_spec_intangible_p): Function deleted.
1055 (display_prop_intangible_p): Reimplement to call
1056 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1057 Accept 3 additional arguments needed by handle_display_spec.
1058 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1059 values: lists, `(when COND...)' forms, etc.
1060 (single_display_spec_string_p): Support property values that are
1061 lists with the argument STRING its top-level element.
1062 (display_prop_string_p): Fix the condition for processing a
1063 property that is a list to be consistent with handle_display_spec.
fec2107c 1064 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1065 last portion of handle_display_prop.
1066 (compute_display_string_pos): Accept additional argument
1067 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1068 value of a `display' property is a "replacing spec".
1069 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1070 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1071 the display property, but just return a value indicating whether
1072 the display property will replace the characters it covers.
1073 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1074 frame_window_p members of struct bidi_it.
d6d100dd
SM
1075 (compute_display_string_pos, compute_display_string_end):
1076 New functions.
fec2107c
EZ
1077 (push_it): Accept second argument POSITION, where pop_it should
1078 jump to continue iteration.
1079 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1080
fec2107c
EZ
1081 * keyboard.c (adjust_point_for_property): Adjust the call to
1082 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1083
1084 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1085 (bidi_init_it): Update prototypes.
1086 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1087 (compute_display_string_pos, compute_display_string_end):
1088 Declare prototypes.
fec2107c
EZ
1089 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1090 EMACS_INT.
fc6f18ce 1091
40087514 10922011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1093
57f53182
PE
1094 Malloc failure behavior now depends on size of allocation.
1095 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1096 * lisp.h: Change signatures accordingly.
1097 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1098 All callers changed. (Bug#8762)
1099
1100 * gnutls.c: Use Emacs's memory allocators.
1101 Without this change, the gnutls library would invoke malloc etc.
1102 directly, which causes problems on non-SYNC_INPUT hosts, and which
1103 runs afoul of improving memory_full behavior. (Bug#8761)
1104 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1105 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1106 xfree instead of the default malloc, realloc, free.
1107 (Fgnutls_boot): No need to check for memory allocation failure,
1108 since xmalloc does that for us.
1109
ac32cd99 1110 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1111 * category.c (hash_get_category_set):
1112 * ccl.c (ccl_driver):
1113 * charset.c (Fdefine_charset_internal):
1114 * charset.h (struct charset.hash_index):
1115 * composite.c (get_composition_id, gstring_lookup_cache)
1116 (composition_gstring_put_cache):
1117 * composite.h (struct composition.hash_index):
1118 * dispextern.h (struct image.hash):
1119 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1120 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1121 (hashfn_equal, hashfn_user_defined, make_hash_table)
1122 (maybe_resize_hash_table, hash_lookup, hash_put)
1123 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1124 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1125 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1126 * image.c (make_image, search_image_cache, lookup_image)
1127 (xpm_put_color_table_h):
1128 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1129 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1130 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1131 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1132 * alloc.c (allocate_vectorlike):
1133 Check for overflow in vector size calculations.
1134 * ccl.c (ccl_driver):
1135 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1136 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1137 need to be updated by these changes.
40087514
PE
1138 * fns.c (make_hash_table, maybe_resize_hash_table):
1139 Check for integer overflow with large hash tables.
0de4bb68
PE
1140 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1141 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1142 (SXHASH_REDUCE): New macro.
1143 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1144 Use it instead of discarding useful hash info with large hash values.
1145 (sxhash_float): New function.
1146 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1147 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1148 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1149 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1150 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1151 Adjust signatures to match updated version of code.
1152 (consing_since_gc): Now EMACS_INT, since a single hash table can
1153 use more than INT_MAX bytes.
1154
698d32e2
DN
11552011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1156
1157 Make it possible to build with GCC-4.6+ -O2 -flto.
1158
1159 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1160
fd6fa53f
SM
11612011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1162
1163 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1164 Call minibuffer-inactive-mode.
1165
864db017
JB
11662011-05-31 Juanma Barranquero <lekktu@gmail.com>
1167
1168 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1169 Update dependencies.
1170
2ad0baf4
DN
11712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1172
1173 * data.c (init_data): Remove code for UTS, this system is not
1174 supported anymore.
1175
4fcc2638
DN
11762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1177
1178 Don't force ./temacs to start in terminal mode.
1179
1180 * frame.c (make_initial_frame): Initialize faces in all cases, not
1181 only when CANNOT_DUMP is defined.
1182 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1183
c56e0fd5
DN
11842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1185
1186 * dispnew.c (add_window_display_history): Use const for the string
1187 pointer. Remove declaration, not needed.
1188
333d54da 11892011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1190
55d4c1b2 1191 Use 'inline', not 'INLINE'.
333d54da 1192 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1193 * alloc.c, fontset.c (INLINE): Remove.
1194 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1195 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1196 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1197 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1198 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1199
738db178
DN
12002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1201
1202 Make it possible to run ./temacs.
1203
1204 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1205 syms_of_callproc does the same thing. Remove test for
1206 "initialized", do it in the caller.
1207 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1208
620c53a6
SM
12092011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1210
1211 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1212 (read_minibuf): Use get_minibuffer.
1213 (syms_of_minibuf): Use DEFSYM.
1214 (Qmetadata): New var.
1215 * data.c (Qbuffer): Don't make it static.
1216 (syms_of_data): Use DEFSYM.
1217
e003a292
PE
12182011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1219
1220 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1221 (CCL_CODE_MIN): New macro.
1222
ed008a6d
PE
12232011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1224
3687c2ef
PE
1225 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1226
ed008a6d
PE
1227 * eval.c (Qdebug): Now static.
1228 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1229 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1230 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1231
d66c4c7c
CY
12322011-05-29 Chong Yidong <cyd@stupidchicken.com>
1233
1234 * image.c: Various fixes to ImageMagick code comments.
1235 (Fimagemagick_types): Doc fix.
1236
5fbc2025
PE
12372011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1238
0196f88a
PE
1239 Minor fixes prompted by GCC 4.6.0 warnings.
1240
1241 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1242
5fbc2025
PE
1243 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1244 (x_clipboard_manager_save_all): Move extern decl to ...
1245 * xterm.h: ... here, so that it can be checked for consistency.
1246
1dd3c2d9
CY
12472011-05-29 Chong Yidong <cyd@stupidchicken.com>
1248
1249 * xselect.c (x_clipboard_manager_save_frame)
1250 (x_clipboard_manager_save_all): New functions.
1251 (Fx_clipboard_manager_save): Lisp function deleted.
1252
1253 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1254 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1255
1256 * xterm.h: Update prototype.
1257
5ba6571d
WX
12582011-05-28 William Xu <william.xwl@gmail.com>
1259
1260 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1261 exiting (Bug#8239).
1262
3eaff834
JM
12632011-05-28 Jim Meyering <meyering@redhat.com>
1264
e1900994 1265 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1266 * fns.c (to_uchar): Define.
1267 (crypto_hash_function): Use it to convert some newly-signed
1268 variables to unsigned, to avoid sign-extension bugs. For example,
1269 without this change, (md5 "truc") would evaluate to
1270 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1271 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1272 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1273
0f6990a7
PE
12742011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1275
1276 Integer overflow fixes.
c8a9ca5a 1277
08686060
PE
1278 * dbusbind.c: Serial number integer overflow fixes.
1279 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1280 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1281 to hold a serial number that is too large for a fixnum.
1282 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1283 Check for serial numbers out of range. Decode any serial number
59568bf0 1284 that was so large that it became a float. (Bug#8722)
08686060 1285
2d1fc3c7
PE
1286 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1287 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1288 Use XFASTINT rather than XUINT when numbers are nonnegative.
1289 (xd_append_arg, Fdbus_method_return_internal):
1290 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1291 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1292 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1293 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1294 (Bug#8722)
2d1fc3c7 1295
c8a9ca5a
PE
1296 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1297
519e1d69
PE
1298 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1299
30569699
PE
1300 ccl: add integer overflow checks
1301 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1302 (IN_INT_RANGE): New macros.
1303 (ccl_driver): Use them to check for integer overflow when
1304 decoding a CCL program. Many of the new checks are whether XINT (x)
1305 fits in int; it doesn't always, on 64-bit hosts. The new version
1306 doesn't catch all possible integer overflows, but it's an
847044ea 1307 improvement. (Bug#8719)
30569699 1308
c11285dc
PE
1309 * alloc.c (make_event_array): Use XINT, not XUINT.
1310 There's no need for unsigned here.
1311
fdccd48e
PE
1312 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1313 This follows up to the 2011-05-06 change that substituted uintptr_t
1314 for EMACS_INT. This case wasn't caught back then.
1315
37910ab2
PE
1316 Rework Fformat to avoid integer overflow issues.
1317 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1318 now (part of C89). Include <verify.h>.
1319 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1320 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1321 (Fformat): Avoid the prepass trying to compute sizes; it was only
1322 approximate and thus did not catch overflow reliably. Instead, walk
1323 through the format just once, formatting and computing sizes as we go,
1324 checking for integer overflow at every step, and allocating a larger
1325 buffer as needed. Keep track separately whether the format is
1326 multibyte. Keep only the most-recently calculated precision, rather
1327 than them all. Record whether each argument has been converted to
1328 string. Use EMACS_INT, not int, for byte and char and arg counts.
1329 Support field widths and precisions larger than INT_MAX. Avoid
1330 sprintf's undefined behavior with conversion specifications such as %#d
1331 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1332 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1333 formatting out-of-range floating point numbers with int
1334 formats. (Bug#8668)
1335
2e6578fb
PE
1336 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1337
0ae6bdee
PE
1338 * data.c: Avoid integer truncation in expressions involving floats.
1339 * data.c: Include <intprops.h>.
1340 (arith_driver): When there's an integer overflow in an expression
1341 involving floating point, convert the integers to floating point
1342 so that the resulting value does not suffer from catastrophic
1343 integer truncation. For example, on a 64-bit host (* 4
1344 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1345 Do not rely on undefined behavior after integer overflow.
1346
de883a70
PE
1347 merge count_size_as_multibyte, parse_str_to_multibyte
1348 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1349 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1350 Check for integer overflow.
1351 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1352 since it's now a duplicate of the other. This is more of
1353 a character than a buffer op, so better that it's in character.c.
1354 * fns.c, print.c: Adjust to above changes.
1355
2ff916cb
PE
13562011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1357
1358 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1359
f1b54466
PE
13602011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1361
fb1ac845
PE
1362 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1363 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1364 (x_clipboard_manager_save): Now static.
1365 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1366
f1b54466
PE
1367 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1368 (crypto_hash_function): Now static.
1369 Fix pointer signedness problems. Avoid unnecessary initializations.
1370
a9f737ee
CY
13712011-05-27 Chong Yidong <cyd@stupidchicken.com>
1372
1373 * termhooks.h (Vselection_alist): Make it terminal-local.
1374
1375 * terminal.c (create_terminal): Initialize it.
1376
1377 * xselect.c: Support for clipboard managers.
1378 (Vselection_alist): Move to termhooks.h as terminal-local var.
1379 (LOCAL_SELECTION): New macro.
1380 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1381 (symbol_to_x_atom): Remove gratuitous arg.
1382 (x_handle_selection_request, lisp_data_to_selection_data)
1383 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1384 (x_own_selection, x_get_local_selection, x_convert_selection):
1385 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1386 (some_frame_on_display): Delete unused function.
1387 (Fx_own_selection_internal, Fx_get_selection_internal)
1388 (Fx_disown_selection_internal, Fx_selection_owner_p)
1389 (Fx_selection_exists_p): New optional frame arg.
1390 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1391 (x_handle_selection_clear): Don't treat other terminals with the
1392 same keyboard specially. Use the terminal-local Vselection_alist.
1393 (x_clear_frame_selections): Use Frun_hook_with_args.
1394
1395 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1396
1397 * xterm.h: Add support for those atoms.
1398
e067f0c1
CY
13992011-05-26 Chong Yidong <cyd@stupidchicken.com>
1400
1401 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1402 (converted_selections, conversion_fail_tag): New global variables.
1403 (x_selection_request_lisp_error): Free the above.
1404 (x_get_local_selection): Remove unnecessary code.
1405 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1406 of converted selections stored in converted_selections.
1407 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1408 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1409 (x_convert_selection): New function.
1410 (x_handle_selection_event): Simplify.
1411 (x_get_foreign_selection): Don't ignore incoming requests while
1412 waiting for an answer; this will fail when we implement
1413 SAVE_TARGETS, and seems unnecessary anyway.
1414 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1415 (Vx_sent_selection_functions): Doc fix.
1416
0f4aebc0
LL
14172011-05-26 Leo Liu <sdl.web@gmail.com>
1418
1419 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1420
e61124cd
YM
14212011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1422
1423 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1424
1425 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1426 for fringe update if it has periodic bitmap.
1427 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1428 and fringe_bitmap_periodic_p.
1429
1430 * fringe.c (get_fringe_bitmap_data): New function.
1431 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1432 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1433 row. Mark glyph row for fringe update if periodicity changed.
1434
1435 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1436 for fringe update unless it has periodic bitmap.
1437
f16d9837
KH
14382011-05-25 Kenichi Handa <handa@m17n.org>
1439
1440 * xdisp.c (get_next_display_element): Set correct it->face_id for
1441 a static composition.
1442
e1b90ef6
LL
14432011-05-24 Leo Liu <sdl.web@gmail.com>
1444
1445 * deps.mk (fns.o):
1446 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1447
1448 * fns.c (crypto_hash_function, Fsha1): New function.
1449 (Fmd5): Use crypto_hash_function.
1450 (syms_of_fns): Add Ssha1.
1451
7400048f
PE
14522011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1453
1454 * gnutls.c: Remove unused macros.
1455 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1456 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1457 Remove macros that are defined and never used.
1458 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1459
abb71cf4
CY
14602011-05-22 Chong Yidong <cyd@stupidchicken.com>
1461
1462 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1463 (Fx_get_selection_internal): Minor cleanup.
1464 (Fx_own_selection_internal): Rename arguments for consistency with
1465 select.el.
1466
6307db39
PE
14672011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1468
1469 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1470
f3d4e0a4
CY
14712011-05-22 Chong Yidong <cyd@stupidchicken.com>
1472
1473 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1474
4d8ade89
YM
14752011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1476
1477 * dispnew.c (scrolling_window): Don't exclude the case that the
1478 last enabled row in the desired matrix touches the bottom boundary.
1479
32078c8d
GM
14802011-05-21 Glenn Morris <rgm@gnu.org>
1481
1482 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1483 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1484 and add some more files.
32078c8d 1485
7285dc67
EZ
14862011-05-20 Eli Zaretskii <eliz@gnu.org>
1487
1488 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1489 report_file_error introduced by the change from 2011-05-07.
1490
89d1bd22
PE
14912011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1492
1493 * systime.h (Time): Define only if emacs is defined.
1494 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1495 where the include path doesn't have X11/X.h by default. See
1496 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1497
e23640bb 14982011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1499
1500 * composite.c (find_automatic_composition): Fix previous change.
1501
b9704ad9
GM
15022011-05-20 Glenn Morris <rgm@gnu.org>
1503
1504 * lisp.mk: New file, split from Makefile.in.
1505 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1506 (shortlisp): Remove.
1507 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1508
4a720484
GM
15092011-05-19 Glenn Morris <rgm@gnu.org>
1510
1511 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1512 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1513 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1514 (lisp): Set the order to that of loadup.el.
1515 (shortlisp): Make it a copy of $lisp.
1516 (SOME_MACHINE_LISP): Remove.
1517 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1518 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1519
a28d4396
KH
15202011-05-18 Kenichi Handa <handa@m17n.org>
1521
1522 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1523 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1524 (find_automatic_composition): Mostly rewrite for efficiency.
1525
a2b1fa8e
JB
15262011-05-18 Juanma Barranquero <lekktu@gmail.com>
1527
1528 * makefile.w32-in: Update dependencies.
1529
8e1f5610
CS
15302011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1531
1532 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1533 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1534
7025ee00 15352011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1536
cdfa6eab
PE
1537 Fix some integer overflow issues, such as string length overflow.
1538
06d6db33
PE
1539 * insdel.c (count_size_as_multibyte): Check for string overflow.
1540
2b4560a8
PE
1541 * character.c (lisp_string_width): Check for string overflow.
1542 Use EMACS_INT, not int, for string indexes and lengths; in
1543 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1544 the resulting string length overflows an EMACS_INT; instead,
1545 report a string overflow if no precision given. When checking for
1546 precision exhaustion, use a check that cannot possibly have
1547 integer overflow. (Bug#8675)
1548 * character.h (lisp_string_width): Adjust to new signature.
1549
cb93f9be
PE
1550 * alloc.c (string_overflow): New function.
1551 (Fmake_string): Use it. This doesn't change behavior, but saves
1552 a few bytes and will simplify future changes.
1553 * character.c (string_escape_byte8): Likewise.
1554 * lisp.h (string_overflow): New decl.
1555
1a1f3366
PE
1556 Fixups, following up to the user-interface timestamp change.
1557 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1558 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1559 * msdos.c (mouse_get_pos): Likewise.
1560 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1561 * w32gui.h (Time): Define by including "systime.h" rather than by
1562 declaring it ourselves. (Bug#8664)
1563
d4e3e4d3
PE
1564 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1565 * image.c (clear_image_cache): Likewise.
1566
f6a24d19
PE
1567 * term.c (term_mouse_position): Don't assume time_t wraparound.
1568
08dc5ae6
PE
1569 Be more systematic about user-interface timestamps.
1570 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1571 and sometimes 'EMACS_UINT', to represent these timestamps.
1572 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1573 This makes the code easier to follow, and makes it easier to catch
1574 integer overflow bugs such as Bug#8664.
1575 * frame.c (Fmouse_position, Fmouse_pixel_position):
1576 Use Time, not unsigned long, for user-interface timestamps.
1577 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1578 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1579 * keyboard.h (last_event_timestamp): Likewise.
1580 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1581 * menu.h (xmenu_show): Likewise.
1582 * term.c (term_mouse_position): Likewise.
1583 * termhooks.h (struct input_event.timestamp): Likewise.
1584 (struct terminal.mouse_position_hook): Likewise.
1585 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1586 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1587 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1588 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1589 what it was before.
1590 * menu.h, termhooks.h: Include "systime.h", for Time.
1591
8e55734a
PE
1592 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1593 Don't assume that the difference between two unsigned long values
1594 can fit into an integer. At this point, we know button_down_time
1595 <= event->timestamp, so the difference must be nonnegative, so
1596 there's no need to cast the result if double-click-time is
1597 nonnegative, as it should be; check that it's nonnegative, just in
1598 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1599 apart (about 25 days). (Bug#8664)
8e55734a 1600
841f1b75 1601 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1602 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1603
3e26f69c
PE
1604 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1605 that always fit in int. Use a sentinel instead of a counter, to
1606 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1607 * frame.h (struct frame): Use int for menu_bar_items_used
1608 instead of EMACS_INT, since it always fits in int.
3e26f69c 1609
5cc152c0
PE
1610 * menu.c (grow_menu_items): Check for int overflow.
1611
d89eb65e
PE
1612 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1613
5235bd3e
PE
1614 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1615 Before, the code was not consistent. These values cannot exceed
1616 2**31 - 1 so there's no need to make them unsigned.
1617 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1618 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1619 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1620 as modifiers.
1621 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1622
bc827e23
PE
1623 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1624 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1625 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1626 presumably because the widths might not match.
1627
78eb494e
PE
1628 * window.c (size_window): Avoid needless test at loop start.
1629
04f2d78b
CB
16302011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1631
1632 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1633
d2fc7e3d 16342011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1635
1636 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1637
d2fc7e3d 16382011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1639
1640 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1641 `width' to `bar_area_x' and `bar_area_width', respectively.
1642 (x_scroll_run): Take account of fringe background extension.
1643
04f2d78b
CB
1644 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1645 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1646 `bar_area_width', respectively.
1647 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1648 background extension.
1649
79b70037
GM
16502011-05-10 Jim Meyering <meyering@redhat.com>
1651
1652 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1653
2f142cc5
JB
16542011-05-10 Juanma Barranquero <lekktu@gmail.com>
1655
1656 * image.c (Finit_image_library): Return t for built-in image types,
1657 like pbm and xbm. (Bug#8640)
1658
57679c86
AS
16592011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1660
1661 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1662
888c9e86
EZ
16632011-05-07 Eli Zaretskii <eliz@gnu.org>
1664
b0512a1d
EZ
1665 * w32console.c (Fset_screen_color): Doc fix.
1666 (Fget_screen_color): New function.
1667 (syms_of_ntterm): Defsubr it.
1668
7285dc67
EZ
1669 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1670 unlink the temporary file if Fcall_process didn't create it in the
1671 first place.
1672 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1673 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1674 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1675 cue to call_process_cleanup not to close that handle.
1676
4d3fcc8e
BK
16772011-05-07 Ben Key <bkey76@gmail.com>
1678
1679 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1680 one of two shell specific rules, either bootstrap-temacs-CMD or
1681 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1682 to the previous implementation of the bootstrap-temacs rule.
1683 The bootstrap-temacs-CMD rule is similar to the previous
1684 implementation of the bootstrap-temacs rule except that it
1685 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1686 variable.
1687
1688 These changes, along with some changes to nt/configure.bat,
1689 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1690 earlier fix to add support for --cflags and --ldflags options
1691 that include quotes so that it works whether make uses cmd or
1692 sh as the shell.
1693
b4289b64
MA
16942011-05-06 Michael Albinus <michael.albinus@gmx.de>
1695
1696 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1697 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1698 is a constant.
1699 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1700 a string. Handle both cases.
1701 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1702 (Fdbus_register_method): Use Qinvalid_function.
1703
af4c0e28
JB
17042011-05-06 Juanma Barranquero <lekktu@gmail.com>
1705
1706 * makefile.w32-in: Update dependencies.
1707 (LISP_H): Add inttypes.h and stdin.h.
1708 (PROCESS_H): Add unistd.h.
1709
c51453d9
EZ
17102011-05-06 Eli Zaretskii <eliz@gnu.org>
1711
1712 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1713 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1714
8ff0ac3c 17152011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1716
4c4b566b
PE
1717 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1718
aab2b9b5
PE
1719 * term.c (vfatal): Remove stray call to va_end.
1720 It's not needed and the C Standard doesn't allow it here anyway.
1721
c378da0b
PE
1722 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1723 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1724
288b08c7
PE
1725 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1726 bytes.
1727
e3601888
PE
1728 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1729
db6c0e74
PE
1730 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1731
dd5963ea
PE
1732 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1733
88c9450f
PE
1734 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1735
2f9442b8
PE
1736 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1737
c032b5f8
PE
1738 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1739 * charset.c (Fdefine_charset_internal): Don't initialize
1740 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1741 32-bit int (Bug#8600).
a108c10b
PE
1742
1743 * lread.c (read_integer): Be more consistent with string-to-number.
1744 Use string_to_number to do the actual conversion; this avoids
1745 rounding errors and fixes some other screwups. Without this fix,
1746 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1747 (digit_to_number): Move earlier, for benefit of read_integer.
1748 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1749 not a digit in any supported base. (Bug#8602)
a108c10b 1750
ad5f9eea
PE
1751 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1752
aec1708a
PE
1753 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1754 to match comment at start of function. This also removes a
1755 GCC warning about overflow in a 32+64-bit port.
1756
47be4ab5
PE
1757 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1758
371cac43
PE
1759 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1760 Reported by Stefan Monnier in
1761 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1762 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1763 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1764
d01a7826
PE
1765 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1766 (EMACS_UINTPTR): Likewise, with uintptr_t.
1767
7fd47d5c
PE
1768 * lisp.h: Prefer 64-bit EMACS_INT if available.
1769 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1770 on 32-bit hosts that have 64-bit int, so that they can access
1771 large files.
122b0c86
PE
1772 However, temporarily disable this change unless the temporary
1773 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1774
8727937b
PE
1775 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1776
8ac068ac
PE
1777 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1778 This removes an assumption that EMACS_INT and long are the same
1779 width as pointers. The assumption is true for Emacs porting targets
1780 now, but we want to make other targets possible.
1781 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1782 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1783 In the rest of the code, change types of integers that hold casted
1784 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1785 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1786 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1787 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1788 No need to cast type when ORing.
1789 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1790 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1791 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1792 assume EMACS_INT is the same width as char *.
1793 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1794 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1795 Remove no-longer-needed casts.
1796 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1797 (xg_tool_bar_help_callback, xg_make_tool_item):
1798 Use EMACS_INTPTR to hold an integer
1799 that will be cast to void *; this can avoid a GCC warning
1800 if EMACS_INT is not the same width as void *.
1801 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1802 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1803 (current_message_1, set_message_1):
1804 Use a local to convert to proper width without a cast.
1805 * xmenu.c (dialog_selection_callback): Likewise.
1806
ede49d71
PE
1807 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1808 Also, don't assume VALBITS / RAND_BITS is less than 5,
1809 and don't rely on undefined behavior when shifting a 1 left into
1810 the sign bit.
1811 * lisp.h (get_random): Change signature to match.
1812
2f30ecd0
PE
1813 * lread.c (hash_string): Use size_t, not int, for hash computation.
1814 Normally we prefer signed values; but hashing is special, because
1815 it's better to use unsigned division on hash table sizes so that
1816 the remainder is nonnegative. Also, size_t is the natural width
1817 for hashing into memory. The previous code used 'int', which doesn't
1818 retain enough info to hash well into very large tables.
1819 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1820
2a866e7b
PE
1821 * dbusbind.c: Don't possibly lose pointer info when converting.
1822 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1823 Use XPNTR rather than XHASH, so that the high-order bits of
1824 the pointer aren't lost when converting through void *.
1825
51639eac
PE
1826 * eval.c (Fautoload): Don't double-shift a pointer.
1827
92394119
PE
1828 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1829
dbdb9a7c
JB
18302011-05-06 Juanma Barranquero <lekktu@gmail.com>
1831
1832 * gnutls.c (DEF_GNUTLS_FN):
1833 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1834
db7a0b4f
AS
18352011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1836
1837 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1838 marker. (Bug#8610)
1839
f7ff1b0f 18402011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1841
1842 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1843 New version that can reserve upto 2GB of heap space.
1844
f7ff1b0f 18452011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1846
1847 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1848
639c109b
TZ
18492011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1850
1851 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1852 `gnutls_certificate_set_x509_key_file'.
1853
d2127135
JB
18542011-05-05 Juanma Barranquero <lekktu@gmail.com>
1855
1856 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1857 Update dependencies.
1858
e968f4f3
JB
18592011-05-04 Juanma Barranquero <lekktu@gmail.com>
1860
1861 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1862 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1863 Remove unused parameter `fildes'.
1864 * process.c (read_process_output, send_process): Don't pass it.
1865
84d358f0
JB
18662011-05-04 Juanma Barranquero <lekktu@gmail.com>
1867
1868 Fix previous change: the library cache is defined in w32.c.
1869 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1870 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1871
0898ca10
JB
18722011-05-04 Juanma Barranquero <lekktu@gmail.com>
1873
1874 Implement dynamic loading of GnuTLS on Windows.
1875
1876 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1877 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1878 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1879 Declare.
1880
1881 * gnutls.c (Qgnutls_dll): Define.
1882 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1883 (gnutls_*): Declare function pointers.
1884 (init_gnutls_functions): New function to initialize function pointers.
1885 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1886 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1887 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1888 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1889 (emacs_gnutls_write, emacs_gnutls_read)
1890 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1891 (Fgnutls_available_p): New function.
1892 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1893 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1894 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1895
1896 * image.c: Include w32.h.
1897 (Vimage_type_cache): Delete.
1898 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1899 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1900 (w32_delayed_load): Move to w32.c.
1901
1902 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1903
1904 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1905 (w32_delayed_load): Move from image.c. When loading a library, record
1906 its filename in the :loaded-from property of the library id.
1907 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1908 Initialize and staticpro them.
1909 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1910
1911 * process.c: Include lisp.h before w32.h, not after.
1912 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1913 instead of gnutls_record_check_pending.
1914
1915 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1916
ff4de4aa
TZ
19172011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1918
1919 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1920 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1921 as passed in.
1922
abe95abb
JD
19232011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1924
1925 * xterm.c (x_set_frame_alpha): Do not set property on anything
1926 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1927
e16e55d4
JB
19282011-05-02 Juanma Barranquero <lekktu@gmail.com>
1929
1930 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1931
bafcf6a5
JB
19322011-05-02 Juanma Barranquero <lekktu@gmail.com>
1933
1934 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1935 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1936 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1937 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1938 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1939 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1940 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1941 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1942 (Qgnutls_bootprop_callbacks_verify): Make static.
1943
e7a6747f
AS
19442011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1945
19ed11ba
AS
1946 * callproc.c: Indentation fixup.
1947
e7a6747f 1948 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1949 (wait_for_termination, interruptible_wait_for_termination):
1950 Move after wait_for_termination_1.
e7a6747f 1951
1ef14cb4
LMI
19522011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1953
1954 * sysdep.c (interruptible_wait_for_termination): New function
1955 which is like wait_for_termination, but allows keyboard
1956 interruptions.
1957
1958 * callproc.c (Fcall_process): Add (:file "file") as an option for
1959 the STDOUT buffer.
1960 (Fcall_process_region): Ditto.
1961
330d880c
EZ
19622011-04-30 Eli Zaretskii <eliz@gnu.org>
1963
8db90b73
EZ
1964 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1965 rather than `XVECTOR (FOO)->size'.
1966
330d880c
EZ
1967 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1968 inttypes.h, as a gnulib replacement is used if it not available in
1969 system headers.
1970
15cbd324
EZ
19712011-04-21 Eli Zaretskii <eliz@gnu.org>
1972
1973 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1974 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1975 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1976
1977 * coding.c (coding_alloc_by_realloc): Error out if destination
1978 will grow beyond MOST_POSITIVE_FIXNUM.
1979 (decode_coding_emacs_mule): Abort if there isn't enough place in
1980 charbuf for the composition carryover bytes. Reserve an extra
1981 space for up to 2 characters produced in a loop.
1982 (decode_coding_iso_2022): Abort if there isn't enough place in
1983 charbuf for the composition carryover bytes.
1984
19852011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1986
ae940cca
EZ
1987 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1988 aborting when %lld or %lll format is passed.
1989 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1990 %llo or %llx format is passed. (Bug#8545)
1991
03ab8921
EZ
1992 * window.c (window_scroll_line_based): Use a marker instead of
1993 simple variables to record original value of point. (Bug#7952)
1994
afda1437
EZ
1995 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1996 produced by %s or %c overflows available buffer space. (Bug#8545)
1997
f76dee0c
PE
19982011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1999
2000 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2001 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2002
fdc5744d
JB
20032011-04-28 Juanma Barranquero <lekktu@gmail.com>
2004
2005 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2006
638f053a
JB
20072011-04-28 Juanma Barranquero <lekktu@gmail.com>
2008
2009 * keyboard.c (Qdelayed_warnings_hook): Define.
2010 (command_loop_1): Run `delayed-warnings-hook'
2011 if Vdelayed_warnings_list is non-nil.
2012 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2013 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2014
d178f871
EZ
20152011-04-28 Eli Zaretskii <eliz@gnu.org>
2016
2017 * doprnt.c (doprnt): Don't return value smaller than the buffer
2018 size if the message was truncated. (Bug#8545).
2019
b124fd93
JB
20202011-04-28 Juanma Barranquero <lekktu@gmail.com>
2021
2022 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2023 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2024
e810457d
PE
20252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2026
2027 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2028
ea51cceb
JB
20292011-04-27 Juanma Barranquero <lekktu@gmail.com>
2030
2031 * makefile.w32-in: Update dependencies.
2032
94dcfacf
EZ
20332011-04-27 Eli Zaretskii <eliz@gnu.org>
2034
2035 Improve `doprnt' and its usage. (Bug#8545)
2036 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2037 `format_end'. Remove support for %l as a conversion specifier.
2038 Don't use xrealloc. Improve diagnostics when the %l size modifier
2039 is used. Update the commentary.
2040
2041 * eval.c (verror): Simplify calculation of size_t.
2042
2043 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2044 messages.
2045
f61f41d7
PE
20462011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2047
2048 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2049 change.
2050
96fb4434
PE
20512011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2052
2053 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2054 This makes this file independent of the recent pseudovector change.
2055
671875da 20562011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2057
69e9b5a3
PE
2058 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2059
b5f869a7 2060 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2061 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2062 Remove unused local.
c8926152 2063 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2064
841a1577 2065 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2066 GCC 4.6.0 optimizes based on type-based alias analysis.
2067 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2068 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2069 != &v->size, and therefore "v->size = 1; b->size = 2; return
2070 v->size;" must therefore return 1. This assumption is incorrect
2071 for Emacs, since it type-puns struct Lisp_Vector * with many other
2072 types. To fix this problem, this patch adds a new type struct
f904488f 2073 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2074 and pseudovectors, and helps optimizing compilers not get fooled
2075 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2076 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2077 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2078 the size member.
eab3844f
PE
2079 (XSETPVECTYPE): Rewrite in terms of new macro.
2080 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2081 This is a bit clearer, and further avoids the possibility of
2082 undesirable aliasing.
2083 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2084 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2085 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2086 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2087 (ASIZE): Now uses header.size rather than size.
2088 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2089 to avoid the hassle of writing XVECTOR (foo)->header.size.
2090 (struct vectorlike_header): New type.
eab3844f
PE
2091 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2092 object, to help avoid aliasing.
2093 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2094 (SUBRP): Likewise, since Lisp_Subr is a special case.
2095 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2096 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2097 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2098 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2099 changed to be "header.size" and "header.next".
2100 * buffer.h (struct buffer): Likewise.
2101 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2102 * frame.h (struct frame): Likewise.
2103 * process.h (struct Lisp_Process): Likewise.
2104 * termhooks.h (struct terminal): Likewise.
2105 * window.c (struct save_window_data, struct saved_window): Likewise.
2106 * window.h (struct window): Likewise.
2107 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2108 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2109 * buffer.c (init_buffer_once): Likewise.
2110 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2111 special case.
2112 * process.c (Fformat_network_address): Use local var for size,
2113 for brevity.
2114
0df1eac5
PE
2115 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2116
847ab9d1 2117 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2118 * data.c (atof): Remove decl; no longer used or needed.
2119 (digit_to_number): Move to lread.c.
2120 (Fstring_to_number): Use new string_to_number function, to be
2121 consistent with how the Lisp reader treats infinities and NaNs.
2122 Do not assume that floating-point numbers represent EMACS_INT
2123 without losing information; this is not true on most 64-bit hosts.
2124 Avoid double-rounding errors, by insisting on integers when
2125 parsing non-base-10 numbers, as the documentation specifies.
2126 * lisp.h (string_to_number): New decl, replacing ...
2127 (isfloat_string): Remove.
bc0a5c13 2128 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2129 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2130 appears to have been a coding error. Similarly, do not accept
2131 strings like +-1e0 as floating point numbers. Do not report
2132 overflow for integer overflows unless the base is not 10 which
2133 means we have no simple and reliable way to continue.
2134 Break out the floating-point parsing into a new
2135 function string_to_number, so that Fstring_to_number parses
2136 floating point numbers consistently with the Lisp reader.
04f2d78b 2137 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2138 (E_CHAR, EXP_INT): Remove, replacing with ...
2139 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2140 (string_to_number): New function, replacing isfloat_string.
2141 This function checks for valid syntax and produces the resulting
2142 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2143 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2144 so that overflow for non-base-10 numbers is reported only when
2145 there's no portable and simple way to convert to floating point.
452f4150 2146
67769ffc
PE
2147 * textprop.c (set_text_properties_1): Rewrite for clarity,
2148 and to avoid GCC warning about integer overflow.
2149
c20db43f
PE
2150 * intervals.h (struct interval): Use EMACS_INT for members
2151 where EMACS_UINT might cause problems. See
2152 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2153 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2154 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2155 All uses changed.
37aa2f85
PE
2156 (offset_intervals): Tell GCC not to worry about length overflow
2157 when negating a negative length.
c20db43f 2158
2538aa2f
PE
2159 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2160 (overrun_check_free): Likewise.
2161
f2d3008d
PE
2162 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2163 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2164 word size.
2165
ec8df744
PE
2166 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2167 (gnutls_make_error): Rename local to avoid shadowing.
2168 (gnutls_emacs_global_deinit): ifdef out; not used.
2169 (Fgnutls_boot): Use const for pointer to readonly storage.
2170 Comment out unused local. Fix pointer signedness problems.
2171
640ee02d
PE
2172 * lread.c (openp): Don't stuff size_t into an 'int'.
2173 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2174 about possible signed overflow.
2175
6048fb2a
PE
2176 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2177 (GDK_KEY_g): Don't define if already defined.
2178 (xg_prepare_tooltip): Avoid pointer signedness problem.
2179 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2180
fa3c87e1
PE
2181 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2182 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2183
2172544b
PE
2184 * xfns.c (Fx_window_property): Simplify a bit,
2185 to make a bit faster and to avoid GCC 4.6.0 warning.
2186 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2187
9b821a21
PE
2188 * fns.c (internal_equal): Don't assume size_t fits in int.
2189
3c616cfa
PE
2190 * alloc.c (compact_small_strings): Tighten assertion a little.
2191
c2982e87
PE
2192 Replace pEd with more-general pI, and fix some printf arg casts.
2193 * lisp.h (pI): New macro, generalizing old pEd macro to other
2194 conversion specifiers. For example, use "...%"pI"d..." rather
2195 than "...%"pEd"...".
2196 (pEd): Remove. All uses replaced with similar uses of pI.
2197 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2198 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2199 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2200 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2201 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2202 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2203 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2204 64-bit hosts.
2205 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2206 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2207 * print.c (safe_debug_print, print_object): Likewise.
2208 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2209 to int.
6f04d126
PE
2210 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2211 avoiding the 0 flag, which is not portable.
c2982e87
PE
2212 * process.c (Fmake_network_process): Use pI to avoid cast.
2213 * region-cache.c (pp_cache): Likewise.
2214 * xdisp.c (decode_mode_spec): Likewise.
2215 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2216 behavior on 64-bit hosts with printf arg.
6f04d126 2217 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2218 (x_stop_queuing_selection_requests): Likewise.
2219 (x_get_window_property): Don't truncate byte count to an 'int'
2220 when tracing.
0b432f21 2221
5e073ec7
PE
2222 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2223 here, since it parses constructs like leading '-' and spaces,
2224 which are not wanted; and it overflows with large numbers.
2225 Instead, simply match F[0-9]+, which is what is wanted anyway.
2226
36372bf9
PE
2227 * alloc.c: Remove unportable assumptions about struct layout.
2228 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2229 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2230 (allocate_vectorlike, make_pure_vector): Use the new macros,
2231 plus offsetof, to remove unportable assumptions about struct layout.
2232 These assumptions hold on all porting targets that I know of, but
2233 they are not guaranteed, they're easy to remove, and removing them
2234 makes further changes easier.
2235
0b432f21
PE
2236 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2237 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2238 (string_overrun_cookie): Now const. Use initializers that
2239 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2240 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2241 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2242 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2243 multiple of sizeof (EMACS_INT); it need not be, if
2244 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2245 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2246
895009e1
JB
22472011-04-26 Juanma Barranquero <lekktu@gmail.com>
2248
2249 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2250
6a7a1b0b
TZ
22512011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2252
2253 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2254 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2255 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2256
841a1577 22572011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2258
2259 * lisp.h (Qdebug): List symbol.
895009e1 2260 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2261 * keyboard.c (debug-on-event): New variable.
2262 (handle_user_signal): Break into debugger when debug-on-event
2263 matches the current signal symbol.
2264
f2d3ba6f
DN
22652011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2266
2267 * alloc.c (check_sblock, check_string_bytes)
2268 (check_string_free_list): Convert to standard C.
2269
42ce4c63
TZ
22702011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2271
2272 * w32.c (emacs_gnutls_push): Fix typo.
2273
825cd63c
EZ
22742011-04-25 Eli Zaretskii <eliz@gnu.org>
2275
fb11d64d
EZ
2276 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2277 "cast to pointer from integer of different size".
2278
825cd63c
EZ
2279 Improve doprnt and its use in verror. (Bug#8545)
2280 * doprnt.c (doprnt): Document the set of format control sequences
2281 supported by the function. Use SAFE_ALLOCA instead of always
2282 using `alloca'.
2283
2284 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2285 is one byte too soon. Don't use xrealloc; instead xfree and
2286 xmalloc anew.
2287
e061a11b
TZ
22882011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2289
2290 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2291 callbacks stage.
2292
2293 * gnutls.c: Renamed global_initialized to
2294 gnutls_global_initialized. Added internals for the
2295 :verify-hostname-error, :verify-error, and :verify-flags
2296 parameters of `gnutls-boot' and documented those parameters in the
2297 docstring. Start callback support.
2298 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2299 unless a fatal error occured. Call gnutls_alert_send_appropriate
2300 on error. Return error code.
2301 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2302 (emacs_gnutls_read): Likewise.
2303 (Fgnutls_boot): Return handshake error code.
2304 (emacs_gnutls_handle_error): New function.
2305 (wsaerror_to_errno): Likewise.
2306
2307 * w32.h (emacs_gnutls_pull): Add prototype.
2308 (emacs_gnutls_push): Likewise.
2309
2310 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2311 (emacs_gnutls_push): Likewise.
2312
23132011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2314
2315 * process.c (wait_reading_process_output): Check if GnuTLS
2316 buffered some data internally if no FDs are set for TLS
2317 connections.
2318
2319 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2320 (LIBS): Link to USER_LIBS.
2321 ($(BLD)/gnutls.$(0)): New target.
2322
fa6996bc
EZ
23232011-04-24 Eli Zaretskii <eliz@gnu.org>
2324
eb35682e
EZ
2325 * xdisp.c (handle_single_display_spec): Rename the
2326 display_replaced_before_p argument into display_replaced_p, to
2327 make it consistent with the commentary. Fix typos in the
2328 commentary.
2329
e2ad650c
EZ
2330 * textprop.c (syms_of_textprop): Remove dead code.
2331 (copy_text_properties): Delete obsolete commentary about an
2332 interface that was deleted long ago. Fix typos in the description
2333 of arguments.
2334
1b2de274
EZ
2335 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2336 to changes in oldXMenu/XMenu.h from 2011-04-16.
2337 <menu_help_message, prev_menu_help_message>: Constify.
2338 (IT_menu_make_room): menu->help_text is now `const char **';
2339 adjust.
2340
2341 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2342 to changes in oldXMenu/XMenu.h from 2011-04-16.
2343 (struct XMenu): Declare `help_text' `const char **'.
2344
2345 * xfaces.c <Qunspecified>: Make extern again.
2346
2347 * syntax.c: Include sys/types.h before including regex.h, as
2348 required by Posix.
2349
762b15be
EZ
2350 * doc.c (get_doc_string): Improve the format passed to `error'.
2351
2352 * doprnt.c (doprnt): Improve commentary.
2353
2354 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2355
2356 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2357 them with etags.
2358
f1052e5d
EZ
2359 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2360 changes in globals.h immediately force recompilation.
762b15be
EZ
2361 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2362 $(CURDIR)/s/ms-w32.h.
2363 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2364
fa6996bc
EZ
2365 * character.c (Fchar_direction): Function deleted.
2366 (syms_of_character): Don't defsubr it.
2367 <char-direction-table>: Deleted.
2368
e6c3da20
EZ
23692011-04-23 Eli Zaretskii <eliz@gnu.org>
2370
2371 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2372 * doprnt.c: Include limits.h.
2373 (SIZE_MAX): New macro.
04f2d78b
CB
2374 (doprnt): Return a size_t value. 2nd arg is now size_t.
2375 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2376 Improve overflow protection. Support `l' modifier for integer
2377 conversions. Support %l conversion. Don't assume an EMACS_INT
2378 argument for integer conversions and for %c.
2379
2380 * lisp.h (doprnt): Restore prototype.
2381
2382 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2383 $(SRC)/character.h.
2384
2385 * Makefile.in (base_obj): Add back doprnt.o.
2386
2387 * deps.mk (doprnt.o): Add back prerequisites.
2388 (callint.o): Depend on character.h.
2389
2390 * eval.c (internal_lisp_condition_case): Include the handler
2391 representation in the error message.
2392 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2393 when breaking from the loop.
2394
2395 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2396
2397 * callint.c (Fcall_interactively): When displaying error message
2398 about invalid control letter, pass the character's codepoint, not
2399 a pointer to its multibyte form. Improve display of the character
2400 in octal and display also its hex code.
2401
2402 * character.c (char_string): Use %x to display the (unsigned)
2403 codepoint of an invalid character, to avoid displaying a bogus
2404 negative value.
2405
2406 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2407 `error', not SYMBOL_NAME itself.
2408
2409 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2410 character arguments to `error'.
2411
2412 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2413 to `error' in error message about FINAL_CHAR argument. Make sure
2414 FINAL_CHAR is a character, and use %c when it is passed as
2415 argument to `error'.
2416
4ffd0d6b 24172011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2418
2419 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2420
2421 * w32.c: Include <time.h>.
2422 (sys_localtime): New function.
2423
4ffd0d6b 24242011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2425
2426 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2427
4ffd0d6b 2428 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2429
4ffd0d6b 24302011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2431
4ffd0d6b
GM
2432 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2433 zombies (Bug#8467).
aac0c6e3 2434
04c56954
EZ
24352011-04-19 Eli Zaretskii <eliz@gnu.org>
2436
2437 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2438 gl_state.e_property when gl_state.object is Qt.
2439
2440 * insdel.c (make_gap_larger): Remove limitation of buffer size
2441 to <= INT_MAX.
2442
16a43933
CY
24432011-04-18 Chong Yidong <cyd@stupidchicken.com>
2444
2445 * xdisp.c (lookup_glyphless_char_display)
2446 (produce_glyphless_glyph): Handle cons cell entry in
2447 glyphless-char-display.
2448 (Vglyphless_char_display): Document it.
2449
2450 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2451 glyphless-char-display.
2452
4581706e
CY
24532011-04-17 Chong Yidong <cyd@stupidchicken.com>
2454
2455 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2456
2457 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2458
2459 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2460 definition for no-X builds.
2461
4887c6e2 24622011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2463
fd35b6f9
PE
2464 Static checks with GCC 4.6.0 and non-default toolkits.
2465
5c1ccb01
PE
2466 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2467
006c5daa
PE
2468 * process.c (keyboard_bit_set): Define only if SIGIO.
2469 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2470 (send_process): Repair possible setjmp clobbering.
2471
efc736d3
PE
2472 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2473
4e2fe2e6
PE
2474 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2475
f97334a2
PE
2476 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2477
4e75f29d
PE
2478 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2479 Define only if needed.
2480
90efadd1
PE
2481 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2482 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2483 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2484
3c647824
PE
2485 * dispextern.h (struct redisplay_interface): Rename param
2486 to avoid shadowing.
e264f262 2487 * termhooks.h (struct terminal): Likewise.
761383f4 2488 * xterm.c (xembed_send_message): Likewise.
3c647824 2489
b58c5c4a
PE
2490 * insdel.c (make_gap_smaller): Define only if
2491 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2492
cad59032
PE
2493 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2494 it.
2495
c339dc2e
PE
2496 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2497 so that we aren't warned about unused symbols.
2498
91a3e27b
PE
2499 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2500
399c71d3 2501 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2502
8ffc96f5
PE
2503 * xfns.c (x_real_positions): Mark locals as initialized.
2504
eef9bc79
PE
2505 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2506
098db9dd
PE
2507 * xterm.c: Fix problems found by static analysis with other toolkits.
2508 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2509 (x_dispatch_event): Declare static if USE_GTK, and
2510 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2511 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2512 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2513 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2514 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2515
eb18f6cc
PE
2516 * xmenu.c (menu_help_callback): Pointer type fixes.
2517 Use const pointers when pointing at readonly data. Avoid pointer
2518 signedness clashes.
2519 (FALSE): Remove unused macro.
2520 (update_frame_menubar): Remove unused decl.
2521
1fe72bf8
PE
2522 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2523
60d9e1db
PE
2524 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2525 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2526 (single_menu_item): Rename local to avoid shadowing.
2527
39261c26
PE
2528 * keyboard.c (make_lispy_event): Remove unused local var.
2529
018c5e19
PE
2530 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2531 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2532
63d2b86e
PE
2533 * bitmaps: Change bitmaps from unsigned char back to the X11
2534 compatible char. Avoid the old compiler warnings about
2535 out-of-range initializers by using, for example, '\xab' rather
2536 than 0xab.
2537
aefd87e1
PE
2538 * xgselect.c (xgselect_initialize): Check vs interface
2539 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2540
bf501fb9
PE
2541 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2542
e9829fdf
PE
2543 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2544 to read-only memory.
2545
1086c095
PE
2546 * fns.c (vector): Remove; this old hack is no longer needed.
2547
2baccd04 2548 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2549 Remove unused var.
dde42981 2550 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2551
72391843 2552 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2553
436c16df 2554 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2555 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2556 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2557
92bb796d 2558 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2559 (x_term_init): Remove local to avoid shadowing.
92bb796d 2560
764430a3 2561 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2562
2563 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2564 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2565
d1dfb56c
EZ
25662011-04-16 Eli Zaretskii <eliz@gnu.org>
2567
c4354cb4
EZ
2568 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2569
d1dfb56c
EZ
2570 Fix regex.c, syntax.c and friends for buffers > 2GB.
2571 * syntax.h (struct gl_state_s): Declare character position members
2572 EMACS_INT.
2573
2574 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2575
04f2d78b
CB
2576 * textprop.c (verify_interval_modification, interval_of):
2577 Declare arguments EMACS_INT.
d1dfb56c
EZ
2578
2579 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2580 EMACS_INT.
2581
2582 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2583
2584 * indent.c (Fvertical_motion): Local variable it_start is now
2585 EMACS_INT.
2586
2587 * regex.c (re_match, re_match_2, re_match_2_internal)
2588 (bcmp_translate, regcomp, regexec, print_double_string)
2589 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2590 (re_compile_pattern, re_exec): Declare arguments and local
2591 variables `size_t' and `ssize_t' and return values `regoff_t', as
2592 appropriate.
2593 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2594 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2595 <compile_stack_type>: `size' and `avail' are now `size_t'.
2596
2597 * regex.h <regoff_t>: Use ssize_t, not int.
2598 (re_search, re_search_2, re_match, re_match_2): Arguments that
2599 specify buffer/string position and length are now ssize_t and
2600 size_t. Return type is regoff_t.
2601
613052cd
BK
26022011-04-16 Ben Key <bkey76@gmail.com>
2603
2604 * nsfont.m: Fixed bugs in ns_get_family and
2605 ns_descriptor_to_entity that were caused by using free to
2606 deallocate memory blocks that were allocated by xmalloc (via
2607 xstrdup). This caused Emacs to crash when compiled with
2608 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2609 --enable-checking=xmallocoverrun). xfree is now used to
2610 deallocate these memory blocks.
2611
4170f62f 26122011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2613
71b41406
PE
2614 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2615
9587a89d
PE
2616 emacs_write: Accept and return EMACS_INT for sizes.
2617 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2618 et seq.
2619 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2620 Accept and return EMACS_INT.
2621 (emacs_gnutls_write): Return the number of bytes written on
2622 partial writes.
2623 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2624 (emacs_read, emacs_write): Remove check for negative size, as the
2625 Emacs source code has been audited now.
9587a89d
PE
2626 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2627 (emacs_read, emacs_write): Use it.
273a5f82
PE
2628 * process.c (send_process): Adjust to the new signatures of
2629 emacs_write and emacs_gnutls_write. Do not attempt to store
2630 a byte offset into an 'int'; it might overflow.
9587a89d 2631 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2632
3e047f51
PE
2633 * sound.c: Don't assume sizes fit in 'int'.
2634 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2635 Return EMACS_INT, not int.
3e047f51 2636 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2637 Accept EMACS_INT, not int.
2638 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2639 record read return values.
2640
cc39a9db
BK
26412011-04-15 Ben Key <bkey76@gmail.com>
2642
c9d0ec6d
JB
2643 * keyboard.c (Qundefined): Don't declare static since it is used
2644 in nsfns.m.
2645 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2646 static since they are used in nsfont.m.
cc39a9db 2647
6c60eb9f
SM
26482011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2649
2650 * process.c (Qprocessp): Don't declare static.
2651 * lisp.h (Qprocessp): Declare again.
2652
7990b61a
JB
26532011-04-15 Juanma Barranquero <lekktu@gmail.com>
2654
2655 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2656
5d4cb038
PE
26572011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2658
8bd7b830 2659 Improve C-level modularity by making more things 'static'.
cd64ea1d 2660
e3b27b31
PE
2661 Don't publish debugger-only interfaces to other modules.
2662 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2663 (verify_bytepos, count_markers): Move decls to the only modules
2664 that need them.
2665 * region-cache.h (pp_cache): Likewise.
2666 * window.h (check_all_windows): Likewise.
2667 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2668
5d4cb038
PE
2669 * sysdep.c (croak): Now static, if
2670 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2671 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2672
2673 * alloc.c (refill_memory_reserve): Now static if
2674 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2675 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2676
e87b6180
PE
2677 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2678 Define only if USE_LUCID.
2679
ac64929e
PE
2680 * xrdb.c (x_customization_string, x_rm_string): Now static.
2681
6f37259d
PE
2682 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2683 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2684
1683e3ab
PE
2685 * xdisp.c (draw_row_with_mouse_face): Now static.
2686 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2687
de9c2632
PE
2688 * window.h (check_all_windows): Mark externally visible.
2689
2b96acb7
PE
2690 * window.c (window_deletion_count): Now static.
2691
2692 * undo.c: Make symbols static if they're not exported.
2693 (last_undo_buffer, last_boundary_position, pending_boundary):
2694 Now static.
2695
50436f33
PE
2696 * textprop.c (interval_insert_behind_hooks): Now static.
2697 (interval_insert_in_front_hooks): Likewise.
2698
64520e5c
PE
2699 * term.c: Make symbols static if they're not exported.
2700 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2701 (max_frame_lines, tty_set_terminal_modes):
2702 (tty_reset_terminal_modes, tty_turn_off_highlight):
2703 (get_tty_terminal): Now static.
2704 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2705 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2706 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2707 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2708 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2709
1fa53021
PE
2710 * sysdep.c: Make symbols static if they're not exported.
2711 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2712 Now static.
2713 (sigprocmask_set, full_mask): Remove; unused.
2714 (wait_debugging): Mark as visible.
2715 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2716 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2717
d4b43b22
PE
2718 * syntax.c (syntax_temp): Define only if !__GNUC__.
2719
b7c513d0
PE
2720 * sound.c (current_sound_device, current_sound): Now static.
2721
989b29ad
PE
2722 * search.c (searchbufs, searchbuf_head): Now static.
2723
13a55a78
PE
2724 * scroll.c (scroll_cost): Remove; unused.
2725 * dispextern.h (scroll_cost): Remove decl.
2726
de68a1fc
PE
2727 * region-cache.h (pp_cache): Mark as externally visible.
2728
40ccffa6
PE
2729 * process.c: Make symbols static if they're not exported.
2730 (process_tick, update_tick, create_process, chan_process):
2731 (Vprocess_alist, proc_buffered_char, datagram_access):
2732 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2733 (deactivate_process): Mark defn as static, as well as decl.
2734 * lisp.h (create_process): Remove decl.
2735 * process.h (chan_process, Vprocess_alist): Remove decls.
2736
ad64fc97
PE
2737 * print.c: Make symbols static if they're not exported.
2738 (print_depth, new_backquote_output, being_printed, print_buffer):
2739 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2740 (print_interval, print_number_index, initial_stderr_stream):
2741 Now static.
2742 * lisp.h (Fprinc): Remove decl.
2743 (debug_output_compilation_hack): Mark as externally visible.
2744
adddb265
PE
2745 * sysdep.c (croak): Move decl from here to syssignal.h.
2746 * syssignal.h (croak): Put it here, so the API can be checked when
2747 'croak' is called from dissociate_if_controlling_tty.
2748
1717ede2
PE
2749 * minibuf.c: Make symbols static if they're not exported.
2750 (minibuf_save_list, choose_minibuf_frame): Now static.
2751 * lisp.h (choose_minibuf_frame): Remove decl.
2752
fa5fb2bc
PE
2753 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2754
1e3890d1
PE
2755 * lread.c: Make symbols static if they're not exported.
2756 (read_objects, initial_obarray, oblookup_last_bucket_number):
2757 Now static.
2758 (make_symbol): Remove; unused.
2759 * lisp.h (initial_obarray, make_symbol): Remove decls.
2760
8a1414fa
PE
2761 * keyboard.c: Make symbols static if they're not exported.
2762 (single_kboard, recent_keys_index, total_keys, recent_keys):
2763 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2764 (this_single_command_key_start, echoing, last_auto_save):
2765 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2766 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2767 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2768 (Vlispy_mouse_stem, double_click_count):
2769 Now static.
2770 (force_auto_save_soon): Define only if SIGDANGER.
2771 (ignore_mouse_drag_p): Now static if
2772 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2773 (print_help): Remove; unused.
2774 (stop_character, last_timer_event): Mark as externally visible.
2775 * keyboard.h (ignore_mouse_drag_p): Declare only if
2776 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2777 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2778 * lisp.h (echoing): Remove decl.
2779 (force_auto_save_soon): Declare only if SIGDANGER.
2780 * xdisp.c (redisplay_window): Simplify code, to make it more
2781 obvious that ignore_mouse_drag_p is not accessed if !defined
2782 USE_GTK && !defined HAVE_NS.
2783
93ea6e8f
PE
2784 * intervals.c: Make symbols static if they're not exported.
2785 (merge_properties_sticky, merge_interval_right, delete_interval):
2786 Now static.
2787 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2788
77382fcc
PE
2789 * insdel.c: Make symbols static if they're not exported.
2790 However, leave prepare_to_modify_buffer alone. It's never
2791 called from outside this function, but that appears to be a bug.
2792 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2793 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2794 (adjust_after_replace_noundo): Remove; unused.
2795 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2796 (signal_before_change): Remove decls.
77382fcc 2797
9306c32e
PE
2798 * indent.c (val_compute_motion, val_vmotion): Now static.
2799
cd44d2eb
PE
2800 * image.c: Make symbols static if they're not exported.
2801 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2802 if USE_GTK.
2803 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2804 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2805
ad9a7a06
PE
2806 * fringe.c (standard_bitmaps): Now static.
2807 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2808
81626931
PE
2809 * frame.c: Make symbols static if they're not exported.
2810 (x_report_frame_params, make_terminal_frame): Now static.
2811 (get_frame_param): Now static, unless HAVE_NS.
2812 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2813 (x_get_resource_string): Remove; not used.
2814 * frame.h (make_terminal_frame, x_report_frame_params):
2815 (x_get_resource_string); Remove decls.
2816 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2817 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2818
239f9db9
PE
2819 * font.c, fontset.c: Make symbols static if they're not exported.
2820 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2821 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2822 * font.c (font_close_object): Now static.
2823 * font.h (font_close_object): Remove.
2824 * fontset.c (FONTSET_OBJLIST): Remove.
2825 (free_realized_fontset) #if-0 the body, which does nothing.
2826 (face_suitable_for_char_p): #if-0, as it's never called.
2827 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2828 * xfaces.c (face_at_string_position):
2829 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2830 since 0 is always ASCII.
2831
dfcf3579
PE
2832 * fns.c (weak_hash_tables): Now static.
2833
5045092b
PE
2834 * fileio.c: Make symbols static if they're not exported.
2835 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2836 (Vwrite_region_annotation_buffers): Now static.
2837
57a96f5c
PE
2838 * eval.c: Make symbols static if they're not exported.
2839 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2840 * lisp.h (backtrace_list): Remove decl.
2841
35f08c38
PE
2842 * emacs.c: Make symbols static if they're not exported.
2843 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2844 (fatal_error_code, fatal_error_signal_hook, standard_args):
2845 Now static.
2846 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2847 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2848 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2849 * lisp.h (fatal_error_signal_hook): Remove decl.
2850 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2851
f44bd759
PE
2852 * editfns.c: Move a (normally-unused) function to its only use.
2853 * editfns.c, lisp.h (get_operating_system_release): Remove.
2854 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2855 worth the hassle of breaking this out.
2856
b532497d
PE
2857 * xterm.c: Make symbols static if they're not exported.
2858 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2859 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2860 (x_destroy_window, x_delete_display):
2861 Now static.
2862 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2863 (x_mouse_leave): Remove; unused.
2864 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2865 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2866 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2867 Remove decls.
2868 (x_mouse_leave): Declare only if WINDOWSNT.
2869 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2870 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2871 USE_X_TOOLKIT.
2872
1675728f
PE
2873 * ftxfont.c: Make symbols static if they're not exported.
2874 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2875 HAVE_FREETYPE.
2876 * font.h (ftxfont_driver): Likewise.
2877
e4cebfca
PE
2878 * xfns.c: Make symbols static if they're not exported.
2879 (x_last_font_name, x_display_info_for_name):
2880 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2881 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2882 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2883 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2884 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2885 (last_show_tip_args): Now static.
2886 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2887 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2888 (x_screen_planes): Remove; unused.
2889 * dispextern.h (x_screen_planes): Remove decl.
2890
5bf46f05
PE
2891 * dispnew.c: Make symbols static if they're not exported.
2892 * dispextern.h (redraw_garbaged_frames, scrolling):
2893 (increment_row_positions): Remove.
2894 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2895 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2896 Now static.
2897 (redraw_garbaged_frames): Remove; unused.
2898
435f4c28
PE
2899 * xfaces.c: Make symbols static if they're not exported.
2900 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2901 Remove decls.
2902 * xterm.h (defined_color): Remove decls.
2903 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2904 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2905 (menu_face_changed_default, defined_color, free_realized_face):
2906 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2907 (ascii_face_of_lisp_face): Remove; unused.
2908
8524aef3
PE
2909 * xdisp.c: Make symbols static if they're not exported.
2910 * dispextern.h (scratch_glyph_row, window_box_edges):
2911 (glyph_to_pixel_coords, set_cursor_from_row):
2912 (get_next_display_element, set_iterator_to_next):
2913 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2914 (show_mouse_face): Remove decls
2915 * frame.h (message_buf_print): Likewise.
2916 * lisp.h (pop_message, set_message, check_point_in_composition):
2917 Likewise.
2918 * xterm.h (set_vertical_scroll_bar): Likewise.
2919 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2920 (message_buf_print, scratch_glyph_row, displayed_buffer):
2921 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2922 (get_next_display_element, show_mouse_face, window_box_edges):
2923 (frame_to_window_pixel_xy, check_point_in_composition):
2924 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2925 (glyph_to_pixel_coords): Remove; unused.
2926
16390cd2
PE
2927 * dired.c (file_name_completion): Now static.
2928
2929 * dbusbind.c (xd_in_read_queued_messages): Now static.
2930
a25f4dfa
PE
2931 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2932 * data.c (circular_list_error): Remove.
2933
14a9c8df
PE
2934 * commands.h (last_point_position, last_point_position_buffer):
2935 (last_point_position_window): Remove decls.
2936 * keyboard.c: Make these variables static.
2937
04f2d78b
CB
2938 * coding.h (coding, code_convert_region, encode_coding_gap):
2939 Remove decls.
74ab6df5
PE
2940 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2941 (iso_code_class, detect_coding, code_convert_region): Now static.
2942 (encode_coding_gap): Remove; unused.
2943
38dfbee1
PE
2944 * chartab.c (chartab_chars, chartab_bits): Now static.
2945
a2cb4e63
PE
2946 * charset.h (charset_iso_8859_1): Remove decl.
2947 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2948 Now static.
2949
127198fd
PE
2950 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2951 * ccl.c (Vccl_program_table): Now static.
2952 (check_ccl_update): Remove; unused.
2953
d85b608f
PE
2954 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2955 * category.h: ... from here.
2956 * category.c (check_category_table, set_category_set): Now static.
2957
31cd66f3
PE
2958 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2959 * lisp.h: Remove these decls.
2960
c358e587
PE
2961 * buffer.c (buffer_count): Remove unused var.
2962
e78aecca
PE
2963 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2964 so that it's not optimized away.
2965 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2966 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2967 exported only to the debugger.
2968
e192d7d3 2969 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2970 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2971
92470028
PE
2972 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2973 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2974 was inaccessible from Lisp.
2975 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2976 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2977
244ed907
PE
2978 alloc.c: Import and export fewer symbols, and remove unused items.
2979 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2980 is defined.
2981 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2982 it's not optimized away by whole-program optimization.
2983 (message_enable_multibyte, free_misc): Remove.
2984 (catchlist, handlerlist, mark_backtrace):
2985 Declare only if BYTE_MARK_STACK.
2986 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2987 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2988 (message_enable_multibyte): Remove decl.
2989 (free_misc, interval_free_list, float_block, float_block_index):
2990 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2991 (cons_free_list, last_marked_index):
2992 Now static.
2993 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2994 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2995 (mark_backtrace): Define only if BYTE_MARK_STACK.
2996 * xdisp.c (message_enable_multibyte): Now static.
2997
61c2b50e 2998 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2999 This makes it easier for human readers (and static analyzers)
3000 to see whether these variables are used from other modules.
3001 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3002 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3003 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3004 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3005 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3006 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3007 * xmenu.c, xselect.c:
3008 Declare Q* vars static if they are not used in other modules.
3009 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3010 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3011 Remove decls of unexported vars.
3012 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3013
95c82688
PE
3014 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3015
16a97296
PE
3016 Make Emacs functions such as Fatom 'static' by default.
3017 This makes it easier for human readers (and static analyzers)
3018 to see whether these functions can be called from other modules.
3019 DEFUN now defines a static function. To make the function external
3020 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3021 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3022 (Finit_image_library):
16a97296
PE
3023 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3024 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3025 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3026 Remove decls, since these functions are now static.
3027 (Funintern, Fget_internal_run_time): New decls, since these functions
3028 were already external.
95c82688 3029
16a97296
PE
3030 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3031 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3032 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3033 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3034 * keyboard.c, keymap.c, lread.c:
3035 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3036 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3037 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3038 Mark functions with DEFUE instead of DEFUN,
3039 if they are used in other modules.
3040 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3041 decls for now-static functions.
3042 * buffer.h (Fdelete_overlay): Remove decl.
3043 * callproc.c (Fgetenv_internal): Mark as internal.
3044 * composite.c (Fremove_list_of_text_properties): Remove decl.
3045 (Fcomposition_get_gstring): New forward static decl.
3046 * composite.h (Fcomposite_get_gstring): Remove decl.
3047 * dired.c (Ffile_attributes): New forward static decl.
3048 * doc.c (Fdocumntation_property): New forward static decl.
3049 * eval.c (Ffetch_bytecode): New forward static decl.
3050 (Funintern): Remove extern decl; now in .h file where it belongs.
3051 * fileio.c (Fmake_symbolic_link): New forward static decl.
3052 * image.c (Finit_image_library): New forward static decl.
3053 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3054 * intervals.h (Fprevious_property_change):
3055 (Fremove_list_of_text_properties): Remove decls.
3056 * keyboard.c (Fthis_command_keys): Remove decl.
3057 (Fcommand_execute): New forward static decl.
3058 * keymap.c (Flookup_key): New forward static decl.
3059 (Fcopy_keymap): Now static.
3060 * keymap.h (Flookup_key): Remove decl.
3061 * process.c (Fget_process): New forward static decl.
3062 (Fprocess_datagram_address): Mark as internal.
3063 * syntax.c (Fsyntax_table_p): New forward static decl.
3064 (skip_chars): Remove duplicate decl.
3065 * textprop.c (Fprevious_property_change): New forward static decl.
3066 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3067 Now internal.
3068 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3069 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3070
785bbd42
PE
3071 * editfns.c (Fformat): Remove unreachable code.
3072
8b913b57
AS
30732011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3074
3075 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3076 change. (Bug#8496)
3077
a6744a35
EZ
30782011-04-13 Eli Zaretskii <eliz@gnu.org>
3079
3080 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3081 when at ZV. (Bug#8487)
3082
e7974947
AS
30832011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3084
baad03f0
AS
3085 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3086 (Bug#8437)
3087 * keyboard.c (parse_tool_bar_item): Likewise.
3088 * sound.c (sound_cleanup, alsa_close): Likewise.
3089 * termcap.c (tgetent): Likewise.
3090 * xfns.c (x_default_font_parameter): Likewise.
3091 * xsettings.c (read_and_apply_settings): Likewise.
3092
e7974947
AS
3093 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3094 (overrun_check_free): Protoize.
3095
28272684
PE
30962011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3097
3098 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3099 since callers should never pass a negative size.
3100 Change the signature to match that of plain 'read' and 'write'; see
3101 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3102 * lisp.h: Update prototypes of emacs_write and emacs_read.
3103
11997c76
EZ
31042011-04-11 Eli Zaretskii <eliz@gnu.org>
3105
3106 * xdisp.c (redisplay_window): Don't try to determine the character
3107 position of the scroll margin if the window start point w->startp
e896f03c 3108 is outside the buffer's accessible region. (Bug#8468)
11997c76 3109
8a2cbd72
EZ
31102011-04-10 Eli Zaretskii <eliz@gnu.org>
3111
3112 Fix write-region and its subroutines for buffers > 2GB.
3113 * fileio.c (a_write, e_write): Modify declaration of arguments and
3114 local variables to support buffers larger than 2GB.
3115 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3116
3117 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3118 argument, local variables, and return value.
3119
3120 * lisp.h: Update prototypes of emacs_write and emacs_read.
3121
3122 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3123
4073e537 31242011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3125
1ebfdcb6
PE
3126 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3127
b2ded58d
PE
3128 Fix more problems found by GCC 4.6.0's static checks.
3129
7d66342c
PE
3130 * xdisp.c (vmessage): Use a better test for character truncation.
3131
bbf47d44
PE
3132 * charset.c (load_charset_map): <, not <=, for optimization,
3133 and to avoid potential problems with integer overflow.
9248994d 3134 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3135 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3136 * editfns.c (Fformat): Likewise.
1e69125e 3137 * syntax.c (skip_chars): Likewise.
3befa583 3138
e3019616
PE
3139 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3140 This also lets GCC 4.6.0 generate slightly better loop code.
3141
becfa255
PE
3142 * callint.c (Fcall_interactively): <, not <=, for optimization.
3143 (Fcall_interactively): Count the number of arguments produced,
3144 not the number of arguments given. This is simpler and lets GCC
3145 4.6.0 generate slightly better code.
3146
dae0cd48
PE
3147 * ftfont.c: Distingish more carefully between FcChar8 and char.
3148 The previous code passed unsigned char * to a functions like
3149 strlen and xstrcasecmp that expect char *, which does not
3150 conform to the C standard.
3151 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3152 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3153 char * when the C standard requires it.
3154
76032d70
PE
3155 * keyboard.c (read_char): Remove unused var.
3156
eb3f1cc8
PE
3157 * eval.c: Port to Windows vsnprintf (Bug#8435).
3158 Include <limits.h>.
3159 (SIZE_MAX): Define if the headers do not.
3160 (verror): Do not give up if vsnprintf returns a negative count.
3161 Instead, grow the buffer. This ports to Windows vsnprintf, which
3162 does not conform to C99. Problem reported by Eli Zaretskii.
3163 Also, simplify the allocation scheme, by avoiding the need for
3164 calling realloc, and removing the ALLOCATED variable.
3165
70476b54
PE
3166 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3167
12020a9e
PE
3168 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3169 But keep the doprint source code for now, as we might revamp it
3170 and use it again (Bug#8435).
ea6c7ae6
PE
3171 * lisp.h (doprnt): Remove.
3172 * Makefile.in (base_obj): Remove doprnt.o.
3173 * deps.mk (doprnt.o): Remove.
3174
5fdb398c
PE
3175 error: Print 32- and 64-bit integers portably (Bug#8435).
3176 Without this change, on typical 64-bit hosts error ("...%d...", N)
3177 was used to print both 32- and 64-bit integers N, which relied on
3178 undefined behavior.
3179 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3180 New macro.
3181 * lisp.h (error, verror): Mark as printf-like functions.
3182 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3183 Report overflow in size calculations when allocating printf buffer.
3184 Do not truncate output string at its first null byte.
3185 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3186 Truncate the output at a character boundary, since vsnprintf does not
3187 do that.
3188 * charset.c (check_iso_charset_parameter): Convert internal
3189 character to string before calling 'error', since %c now has the
3190 printf meaning.
3191 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3192 overflow when computing char to be passed to 'error'. Do not
3193 pass Lisp_Object to 'error'; pass the integer instead.
3194 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3195 formatted with plain %d.
3196
b189fa66
PE
3197 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3198
bff87ef0
PE
3199 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3200
7e2cac20
PE
3201 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3202
ce4d90b5
PE
3203 * xterm.c (x_catch_errors): Remove duplicate declaration.
3204
266c9547
PE
3205 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3206
79c49ad2
PE
3207 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3208
368f4090
JM
32092011-04-10 Jim Meyering <meyering@redhat.com>
3210
3211 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3212 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3213 return ssize_t not "int", and use size_t as the buffer length.
3214 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3215 * gnutls.h: Update declarations.
3216 * process.c (read_process_output): Use ssize_t, to match.
3217 (send_process): Likewise.
3218
a32d4040
CY
32192011-04-09 Chong Yidong <cyd@stupidchicken.com>
3220
3221 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3222
8546720e 32232011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3224
04f2d78b
CB
3225 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3226 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3227
8546720e
GM
3228 * xterm.c (handle_one_xevent):
3229 * xmenu.c (create_and_show_popup_menu):
3230 * xselect.c (x_decline_selection_request)
3231 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3232
0a2f5c1a 32332011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3234
3235 Fix some uses of `int' instead of EMACS_INT.
3236 * search.c (string_match_1, fast_string_match)
3237 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3238 (scan_buffer, find_next_newline_no_quit)
3239 (find_before_next_newline, search_command, Freplace_match)
3240 (Fmatch_data): Make some `int' variables be EMACS_INT.
3241
3242 * xdisp.c (display_count_lines): 3rd argument and return value now
3243 EMACS_INT. All callers changed.
3244 (pint2hrstr): Last argument is now EMACS_INT.
3245
3246 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3247 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3248 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3249 (decode_coding_utf_16, decode_coding_emacs_mule)
3250 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3251 (decode_coding_ccl, decode_coding_charset)
3252 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3253 (decode_coding_iso_2022, decode_coding_emacs_mule)
3254 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3255 <char_offset, last_offset>: Declare EMACS_INT.
3256 (encode_coding_utf_8, encode_coding_utf_16)
3257 (encode_coding_emacs_mule, encode_invocation_designation)
3258 (encode_designation_at_bol, encode_coding_iso_2022)
3259 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3260 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3261 Declare EMACS_INT.
3262 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3263 (encode_invocation_designation): Last argument P_NCHARS is now
3264 EMACS_INT.
3265 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3266 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3267
3268 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3269 All users changed.
3270
3271 * ccl.c (Fccl_execute_on_string): Declare some variables
3272 EMACS_INT.
3273
8546720e 32742011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3275
3276 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3277
4e19a977
CS
32782011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3279
3280 * process.c (Fformat_network_address): Doc fix.
3281
87302331
R
32822011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3283
3284 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3285
cbb59342
CY
32862011-04-08 Chong Yidong <cyd@stupidchicken.com>
3287
3288 * keyboard.c (read_char): Call Lisp function help-form-show,
3289 instead of using internal_with_output_to_temp_buffer.
3290 (Qhelp_form_show): New var.
e0d38eeb 3291 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3292
3293 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3294
3295 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3296
e67a13ab
CY
32972011-04-06 Chong Yidong <cyd@stupidchicken.com>
3298
04f2d78b
CB
3299 * process.c (Flist_processes): Remove to Lisp.
3300 (list_processes_1): Delete.
e67a13ab 3301
973f782d
EZ
33022011-04-06 Eli Zaretskii <eliz@gnu.org>
3303
7c106b1e
EZ
3304 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3305
973f782d
EZ
3306 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3307
41cf7d1a 33082011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3309
ca23cc88
PE
3310 Fix more problems found by GCC 4.6.0's static checks.
3311
f390e2d5
PE
3312 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3313
42eea0d0
PE
3314 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3315
b69769da 3316 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3317
f9541e84
PE
3318 * xdisp.c (vmessage): Mark as a printf-like function.
3319
13841b55
PE
3320 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3321
c136c10f
PE
3322 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3323
5e2d4a30
PE
3324 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3325 printf-like functions.
3326 (tiff_load): Add casts to remove these marks before passing them
3327 to system-supplied API.
3328
583f48b9
PE
3329 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3330
b25d760e
PE
3331 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3332 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3333 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3334 directly, rather than having caller test rule sign. This avoids
3335 some unnecessary tests.
3336 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3337 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3338 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3339
bc7b6697 3340 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3341 (xfont_open): Avoid unnecessary tests.
bc7b6697 3342
27ccc379
PE
3343 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3344
dcd5c89a
PE
3345 * composite.h, composite.c (composition_gstring_put_cache):
3346 Use EMACS_INT, not int, for length.
3347
b13a45c6
PE
3348 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3349 breaking out part of COMPOSITION_DECODE_RULE.
3350 (COMPOSITION_DECODE_RULE): Use it.
3351 * composite.c (get_composition_id): Remove unused local vars,
3352 by using the new macro.
3353
1e792e4d
PE
3354 * textprop.c (set_text_properties_1): Change while to do-while,
3355 since the condition is always true at first.
3356
dc6c6455 3357 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3358 (interval_deletion_adjustment): Return unsigned value.
3359 All uses changed.
dc6c6455 3360
aba7731a
PE
3361 * process.c (list_processes_1, create_pty, read_process_output):
3362 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3363 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3364 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3365 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3366 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3367
fdfc4bf3
PE
3368 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3369
fca8fe46 3370 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3371 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3372
06a0259a 3373 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3374 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3375 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3376
e7b9e80f
PE
3377 * print.c (print_error_message): Avoid int overflow.
3378
56201685
PE
3379 * font.c (font_list_entities): Redo for clarity,
3380 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3381
78834453 3382 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3383 (font_score): Avoid potential overflow in diff calculation.
78834453 3384
0bc0b309 3385 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3386 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3387
e610eaca
PE
3388 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3389
b895abce
PE
3390 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3391 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3392 can always succeed if overflow has undefined behavior.
3393
1f1d9321 3394 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3395 (wordify): Omit three unnecessary tests.
1f1d9321 3396
c59478bc
PE
3397 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3398 All callers changed. This avoids the need for an unused var.
3399
79b73827
PE
3400 * casefiddle.c (casify_region): Remove var that is set but not used.
3401
a4db5dfe
PE
3402 * dired.c (file_name_completion): Remove var that is set but not used.
3403
43aae36e
PE
3404 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3405
2a47c44d 3406 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3407 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3408
a37c69bf
PE
3409 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3410 Check for integer overflow on size calculations.
3411
328ab8e7
PE
3412 * buffer.c (Fprevious_overlay_change): Remove var that is set
3413 but not used.
3414
e5a2a5cb
PE
3415 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3416 Remove vars that are set but not used.
8d84a6eb 3417 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3418 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3419
a60e5f68
PE
3420 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3421
f661cb61 3422 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3423 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3424
f0397f5a
PE
3425 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3426 that are set but not used.
3427
8664db06 3428 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3429 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3430
6abdaa4a
PE
3431 * xselect.c (x_get_local_selection, x_handle_property_notify):
3432 Remove vars that are set but not used.
3433
0ce7538d 3434 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3435 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3436
9ae848fc
PE
3437 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3438 Remove var that is set but not used.
0b918413
PE
3439 (scroll_bar_windows_size): Now size_t, not int.
3440 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3441 Check for overflow.
9ae848fc 3442
a5a62657
PE
3443 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3444 (map_tty_color) [!defined MSDOS]: Likewise.
3445
5c5cdd39
PE
3446 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3447
66ebf983
PE
3448 * coding.c: Remove vars that are set but not used.
3449 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3450 All callers changed.
3451 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3452 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3453 (decode_coding_charset): Remove vars that are set but not used.
3454
1be4d761
PE
3455 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3456 that is set but not used.
3457
47553fa8
PE
3458 * print.c (print_object): Remove var that is set but not used.
3459
1f7196bf 3460 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3461 The gnulib version avoids calling malloc in the usual case,
3462 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3463 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3464 * filelock.c (current_lock_owner): Likewise.
3465 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3466 * sysdep.c: Include allocator.h, careadlinkat.h.
3467 (emacs_no_realloc_allocator): New static constant.
3468 (emacs_readlink): New function.
fdb61804
PE
3469 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3470 ../lib/careadlinkat.h.
d1fdcab7 3471
f84c17c7
SM
34722011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3473
3474 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3475 first non-nil return value).
3476
ef3862ad
JD
34772011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3478
3479 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3480 if not defined (Bug#8403).
3481
376a7006
JB
34822011-04-02 Juanma Barranquero <lekktu@gmail.com>
3483
3484 * xdisp.c (display_count_lines): Remove parameter `start',
3485 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3486 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3487 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3488 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3489 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3490 and thereabouts. All callers changed.
3491 (get_per_char_metric): Remove parameter `f', unused since
3492 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3493
6ca3801d
JM
34942011-04-02 Jim Meyering <meyering@redhat.com>
3495
3496 do not dereference NULL upon failed strdup
3497 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3498 (ns_get_family): Likewise.
3499
d8e2b5ba
JB
35002011-04-02 Juanma Barranquero <lekktu@gmail.com>
3501
3502 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3503
8c74fcbd
JD
35042011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3505
3506 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3507 later (Bug#8403).
3508
7200d79c
SM
35092011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3510
03408648 3511 Add lexical binding.
7200d79c 3512
03408648
SM
3513 * window.c (Ftemp_output_buffer_show): New fun.
3514 (Fsave_window_excursion):
3515 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3516
3517 * lread.c (lisp_file_lexically_bound_p): New function.
3518 (Fload): Bind Qlexical_binding.
3519 (readevalloop): Remove `evalfun' arg.
3520 Bind Qinternal_interpreter_environment.
3521 (Feval_buffer): Bind Qlexical_binding.
3522 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3523 Mark as dynamic.
3524 (syms_of_lread): Declare `lexical-binding'.
3525
3526 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3527
3528 * keyboard.c (eval_dyn): New fun.
3529 (menu_item_eval_property): Use it.
ca105506
SM
3530
3531 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3532
03408648
SM
3533 * fns.c (concat, mapcar1): Accept byte-code-functions.
3534
3535 * eval.c (Fsetq): Handle lexical vars.
3536 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3537 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3538 (FletX, Flet): Obey lexical binding.
3539 (Fcommandp): Handle closures.
3540 (Feval): New `lexical' arg.
3541 (eval_sub): New function extracted from Feval. Use it almost
3542 everywhere where Feval was used. Look up vars in lexical env.
3543 Handle closures.
3544 (Ffunctionp): Move from subr.el.
3545 (Ffuncall): Handle closures.
3546 (apply_lambda): Remove `eval_flags'.
3547 (funcall_lambda): Handle closures and new byte-code-functions.
3548 (Fspecial_variable_p): New function.
3549 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3550 but without exporting it to Lisp.
23aba0ea 3551
23aba0ea 3552 * doc.c (Fdocumentation, store_function_docstring):
03408648 3553 * data.c (Finteractive_form): Handle closures.
23aba0ea 3554
03408648
SM
3555 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3556 interactive spec.
ba83908c 3557
04f2d78b
CB
3558 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3559 New byte-codes.
03408648
SM
3560 (exec_byte_code): New function extracted from Fbyte_code to handle new
3561 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3562
03408648 3563 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3564
03408648 3565 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3566
e2abce01
JB
35672011-03-31 Juanma Barranquero <lekktu@gmail.com>
3568
3569 * xdisp.c (redisplay_internal): Fix prototype.
3570
63696a73 35712011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3572
63696a73 3573 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3574 (try_scrolling): Use it when setting scroll_limit.
3575 Limit scrolling to 100 screen lines.
63696a73
EZ
3576 (redisplay_window): Even when falling back on "recentering",
3577 position point in the window according to scroll-conservatively,
3578 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3579
3580 (try_scrolling): When point is above the window, allow searching
3581 as far as scroll_max, or one screenful, to compute vertical
3582 distance from PT to the scroll margin position. This prevents
3583 try_scrolling from unnecessarily failing when
3584 scroll-conservatively is set to a value slightly larger than the
3585 window height. Clean up the case of PT below the margin at bottom
3586 of window: scroll_max can no longer be INT_MAX. When aggressive
3587 scrolling is in use, don't let point enter the opposite scroll
3588 margin as result of the scroll.
3589 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3590 threshold of 100 lines for never-recentering scrolling.
3591
e4cc2dfc
JB
35922011-03-31 Juanma Barranquero <lekktu@gmail.com>
3593
3594 * dispextern.h (move_it_by_lines):
3595 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3596 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3597 (message_log_check_duplicate): Remove parameters `prev_bol' and
3598 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3599 (redisplay_internal): Remove parameter `preserve_echo_area',
3600 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3601
3602 * indent.c (Fvertical_motion):
3603 * window.c (window_scroll_pixel_based, Frecenter):
3604 Don't pass `need_y_p' to `move_it_by_lines'.
3605
1c470562
SM
36062011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3607
44f230aa
SM
3608 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3609 steal a few bits to be more compact.
3610 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3611 Remove unneeded casts.
3612
1c470562
SM
3613 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3614
888adce9
ZK
36152011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3616
3617 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3618 binding" message (bug#7967).
3619
f838ed7b
PE
36202011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3621
77861b95
PE
3622 Fix more problems found by GCC 4.6.0's static checks.
3623
de6dbc14
PE
3624 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3625 Remove unused local var.
3626
f838ed7b
PE
3627 * editfns.c (Fmessage_box): Remove unused local var.
3628
792c7b2b
PE
3629 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3630 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3631 Omit unused local vars.
c499e557 3632 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3633 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3634 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3635 Omit unused local var.
3636
ba0165e1
PE
3637 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3638 Don't assume string length fits in int.
32ad8845 3639 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3640 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3641
3c59b4c9
PE
3642 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3643 instead of alloca (Bug#8344).
3644
a3eed478 3645 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3646 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3647
eb4d412d
PE
3648 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3649
1658b401
PE
3650 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3651 concerns.
3652
3653 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3654
3655 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3656
9a2c6e05
PE
3657 * keyboard.c (syms_of_keyboard): Use the same style as later
3658 in this function when indexing through an array. This also
3659 works around GCC bug 48267.
3660
03d0a109
PE
3661 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3662
44f730c8
PE
3663 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3664
fe75f926
PE
3665 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3666 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3667
ffa8c828
PE
3668 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3669 This avoids undefined behavior on integer overflow, and is a bit
3670 more convenient anyway since it is compared to a size_t variable.
3671
c5101a77
PE
3672 Variadic C functions now count arguments with size_t, not int.
3673 This avoids an unnecessary limitation on 64-bit machines, which
3674 caused (substring ...) to crash on large vectors (Bug#8344).
3675 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3676 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3677 All variadic functions and their callers changed accordingly.
c5101a77
PE
3678 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3679 * data.c (arith_driver, float_arith_driver): Likewise.
3680 * editfns.c (general_insert_function): Likewise.
3681 * eval.c (struct backtrace.nargs, interactive_p)
3682 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3683 (funcall_lambda, mark_backtrace): Likewise.
3684 * fns.c (concat): Likewise.
3685 * frame.c (x_set_frame_parameters): Likewise.
3686 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3687 0 if not found, not -1. All callers changed.
3688
dd3f25f7
PE
3689 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3690 (stack_copy_size): Now size_t, not int.
3691 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3692
461c2ab9
JB
36932011-03-28 Juanma Barranquero <lekktu@gmail.com>
3694
3695 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3696 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3697 All callers changed.
3698
3699 * lisp.h (multibyte_char_to_unibyte):
3700 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3701 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3702 * character.h (CHAR_TO_BYTE8):
3703 * cmds.c (internal_self_insert):
3704 * editfns.c (general_insert_function):
3705 * keymap.c (push_key_description):
3706 * search.c (Freplace_match):
3707 * xdisp.c (message_dolog, set_message_1): All callers changed.
3708
f6d62986
SM
37092011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3710
3711 * keyboard.c (safe_run_hook_funcall): New function.
3712 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3713 don't set the hook to nil, but remove the offending function instead.
3714 (Qcommand_hook_internal): Remove, unused.
3715 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3716 Vcommand_hook_internal.
3717
3718 * eval.c (enum run_hooks_condition): Remove.
3719 (funcall_nil, funcall_not): New functions.
3720 (run_hook_with_args): Call each function through a `funcall' argument.
3721 Remove `cond' argument, now redundant.
3722 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3723 (Frun_hook_with_args_until_failure): Adjust accordingly.
3724 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3725
1db5b1ad
JB
37262011-03-28 Juanma Barranquero <lekktu@gmail.com>
3727
3728 * dispextern.h (string_buffer_position): Remove declaration.
3729
3730 * print.c (strout): Remove parameter `multibyte', unused since
3731 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3732
3733 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3734 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3735 All callers changed.
3736
3737 * w32.c (_wsa_errlist): Use braces for struct initializers.
3738
3739 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3740 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3741 All callers changed.
3742 (string_buffer_position): Likewise. Also, make static (it's never
3743 used outside xdisp.c).
3744 (cursor_row_p): Remove parameter `w', unused since
3745 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3746 (decode_mode_spec): Remove parameter `precision', introduced during
3747 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3748 All callers changed.
3749
5ffb62aa
JD
37502011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3751
3752 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3753
461c2ab9 37542011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3755
3756 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3757 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3758 (ns_update_auto_hide_menu_bar): New functions.
3759 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3760 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3761 ns_constrain_all_frames.
3762 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3763 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3764
5c380ffb
JD
37652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3766
3767 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3768
9af30bdf
GM
37692011-03-27 Glenn Morris <rgm@gnu.org>
3770
3771 * syssignal.h: Replace RETSIGTYPE with void.
3772 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3773 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3774 Replace SIGTYPE with void everywhere.
3775 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3776 * s/template.h (SIGTYPE): Remove commented out definition.
3777
e2abce01
JB
37782011-03-26 Eli Zaretskii <eliz@gnu.org>
3779
3780 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3781 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3782
f868cd8a
JB
37832011-03-26 Juanma Barranquero <lekktu@gmail.com>
3784
59eb0929
JB
3785 * w32.c (read_unc_volume): Use parameter `henum', instead of
3786 global variable `wget_enum_handle'.
3787
3788 * keymap.c (describe_vector): Remove parameters `indices' and
3789 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3790 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3791
f868cd8a
JB
3792 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3793
3794 * keyboard.c (timer_check): Remove parameter `do_it_now',
3795 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3796 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3797 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3798
3799 * keyboard.c (read_char):
3800 * w32menu.c (w32_menu_display_help):
3801 * xmenu.c (show_help_event, menu_help_callback):
3802 Adjust calls to `show_help_echo'.
3803
3804 * gtkutil.c (xg_maybe_add_timer):
3805 * keyboard.c (readable_events):
3806 * process.c (wait_reading_process_output):
3807 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3808
3809 * insdel.c (adjust_markers_gap_motion):
3810 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3811 (gap_left, gap_right): Don't call it.
3812
2ecf6fdb
CY
38132011-03-25 Chong Yidong <cyd@stupidchicken.com>
3814
3815 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3816 incurred during fontification.
3817
6b1f9ba4
JB
38182011-03-25 Juanma Barranquero <lekktu@gmail.com>
3819
3820 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3821 (DEFVAR_PER_BUFFER): Don't pass it.
3822
3823 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3824 (scrolling_window): Don't pass it.
3825
0f4a96b5
JB
38262011-03-25 Juanma Barranquero <lekktu@gmail.com>
3827
3828 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3829
3830 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3831 and `suffix'.
3832 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3833 of variables specific to SELinux and computation of `encoded_absname'.
3834
3835 * image.c (XPutPixel): Remove unused variable `height'.
3836
3837 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3838
3839 * unexw32.c (get_section_info): Remove unused variable `section'.
3840
3841 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3842 (system_process_attributes): Remove unused variable `sess'.
3843 (sys_read): Remove unused variable `err'.
3844
3845 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3846 (w32_wnd_proc): Remove unused variable `isdead'.
3847 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3848 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3849 (x_create_tip_frame): Remove unused variable `tem'.
3850
3851 * w32inevt.c (w32_console_read_socket):
3852 Remove unused variable `no_events'.
3853
3854 * w32term.c (x_draw_composite_glyph_string_foreground):
3855 Remove unused variable `width'.
3856
1149507c
JB
38572011-03-24 Juanma Barranquero <lekktu@gmail.com>
3858
3859 * w32term.c (x_set_glyph_string_clipping):
3860 Don't pass uninitialized region to CombineRgn.
3861
9c88f339
JB
38622011-03-23 Juanma Barranquero <lekktu@gmail.com>
3863
3864 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3865 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3866 (Fx_close_connection): Remove unused variable `i'.
3867
3868 * w32font.c (w32font_draw): Return number of glyphs.
3869 (w32font_open_internal): Remove unused variable `i'.
3870 (w32font_driver): Add missing initializer.
3871
3872 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3873 (fill_in_menu): Remove unused variable `items_added'.
3874
3875 * w32term.c (last_mouse_press_frame): Remove static global variable.
3876 (w32_clip_to_row): Remove unused variable `f'.
3877 (x_delete_terminal): Remove unused variable `i'.
3878
3879 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3880 (NOTHING): Remove unused static global variable.
3881 (uniscribe_check_otf): Remove unused variable `table'.
3882 (uniscribe_font_driver): Add missing initializers.
3883
dee091a3
JD
38842011-03-23 Julien Danjou <julien@danjou.info>
3885
3886 * term.c (Fsuspend_tty, Fresume_tty):
3887 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3888 * window.c (temp_output_buffer_show):
3889 * insdel.c (signal_before_change):
3890 * frame.c (Fhandle_switch_frame):
3891 * fileio.c (Fdo_auto_save):
3892 * emacs.c (Fkill_emacs):
3893 * editfns.c (save_excursion_restore):
3894 * cmds.c (internal_self_insert):
3895 * callint.c (Fcall_interactively):
3896 * buffer.c (Fkill_all_local_variables):
3897 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3898 Use Frun_hooks.
0f4a96b5 3899 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3900 unconditionnaly since it does the check itself.
3901
2c520ab5 39022011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3903
c9c49752
PE
3904 Fix more problems found by GCC 4.5.2's static checks.
3905
8abc3f12
PE
3906 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3907 the first time through the loop, since we know p0 < p1 then.
3908 This also avoids a gcc -Wstrict-overflow warning.
3909
a2d26660
PE
3910 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3911 leading to a memory leak, possible in functions like
3912 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3913 of objects (Bug#8318).
a2d26660 3914
916c72e9
PE
3915 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3916 that could (at least in theory) be that large.
3917
19ab8a18
PE
3918 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3919 This is less likely to overflow, and avoids undefined behavior if
3920 overflow does occur. All callers changed. Use strtoul to scan
3921 for the unsigned long integer.
b7cbbd6f
PE
3922 (pint2hrstr): Simplify and tune code slightly.
3923 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3924
f0641eff
PE
3925 * scroll.c (do_scrolling): Work around GCC bug 48228.
3926 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3927
7f650bb9
PE
3928 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3929 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3930 (validate_x_resource_name): Simplify count usage.
3931 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3932
37dd57d1
PE
3933 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3934 fail (Bug#8306).
81e56e61 3935
699979fc 3936 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3937
401bf9b4
PE
3938 * process.c (Fmake_network_process): Use socklen_t, not int,
3939 where POSIX says socklen_t is required in portable programs.
3940 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3941 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3942 (Fmake_network_process, server_accept_connection):
3943 (wait_reading_process_output, read_process_output):
3944 Likewise.
3945
b93aacde
PE
3946 * process.c: Rename or move locals to avoid shadowing.
3947 (list_processes_1, Fmake_network_process):
3948 (read_process_output_error_handler, exec_sentinel_error_handler):
3949 Rename or move locals.
4dc343ee 3950 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3951 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3952 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3953 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3954 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3955
af8a867c 3956 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3957 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3958 Include tparam.h instead, since it declares them.
af8a867c
PE
3959 * cm.h (PC): Remove extern decl; tparam.h now does this.
3960 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3961 * terminfo.c: Include tparam.h, to check interfaces.
3962 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3963 (tparam): Adjust signature to match interface in tparam.h;
3964 this removes some undefined behavior. Check that outstring and len
3965 are zero, which they always are with Emacs.
3966 * tparam.h (PC, BC, UP): New extern decls.
3967
0248044d 3968 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3969 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3970
8ff096c1 3971 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3972 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3973 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3974 (ftfont_list): Remove unused local.
49eaafba
PE
3975 (get_adstyle_property, ftfont_pattern_entity):
3976 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3977 Rename locals to avoid shadowing.
8ff096c1 3978
e2be39f6
PE
3979 * xfont.c (xfont_list_family): Mark var as initialized.
3980
c9735e30
PE
3981 * xml.c (make_dom): Now static.
3982
8f5201ae
PE
3983 * composite.c (composition_compute_stop_pos): Rename local to
3984 avoid shadowing.
b246f932
PE
3985 (composition_reseat_it): Remove unused locals.
3986 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3987 (composition_update_it): Mark var as initialized.
11b61122
PE
3988 (find_automatic_composition): Mark vars as initialized,
3989 with a FIXME (Bug#8290).
8f5201ae 3990
760fbc2c
PE
3991 character.h: Rename locals to avoid shadowing.
3992 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3993 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3994 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3995 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3996 to avoid shadowing.
3997
ff08eb85
PE
3998 * textprop.c (property_change_between_p): Remove; unused.
3999
fc7bf025
PE
4000 * intervals.c (interval_start_pos): Now static.
4001
235d7abc
PE
4002 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4003
44f230aa
SM
4004 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4005 Rename locals to avoid shadowing.
3e7d6594 4006
50060332
PE
4007 * sound.c (wav_play, au_play, Fplay_sound_internal):
4008 Fix pointer signedness.
d01f234b 4009 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4010 (wav_play): Initialize a variable to 0, to prevent undefined
4011 behavior (Bug#8278).
50060332 4012
c4fc4e30
PE
4013 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4014
918436ed
PE
4015 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4016
c939f91b
PE
4017 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4018 clobbering (Bug#8298).
b9c7f648
PE
4019 * sysdep.c (sys_subshell): Likewise.
4020 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4021
6bd8c144
PE
4022 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4023 This should get cleaned up, so that child_setup has the
4024 same signature on all platforms.
4025
7710357c 4026 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4027 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4028
c59da222
CY
40292011-03-22 Chong Yidong <cyd@stupidchicken.com>
4030
4031 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4032 not to be necessary, and produces flickering.
4033
66b87493
GM
40342011-03-20 Glenn Morris <rgm@gnu.org>
4035
4036 * config.in: Remove file.
4037
45b6f6d5
JB
40382011-03-20 Juanma Barranquero <lekktu@gmail.com>
4039
4040 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4041 are now in src/globals.h.
4042 (syms_of_minibuf): Remove spurious & from previous change.
4043
3ec03f7e
LL
40442011-03-20 Leo <sdl.web@gmail.com>
4045
4046 * minibuf.c (completing-read-function): New variable.
4047 (completing-read-default): Rename from completing-read.
4048 (completing-read): Call completing-read-function.
4049
b14e3e21
CY
40502011-03-19 Juanma Barranquero <lekktu@gmail.com>
4051
4052 * xfaces.c (Fx_load_color_file):
4053 Read color file from absolute filename (bug#8250).
4054
f2b726e6
JB
40552011-03-19 Juanma Barranquero <lekktu@gmail.com>
4056
4057 * makefile.w32-in: Update dependencies.
4058
09f6ff02
EZ
40592011-03-17 Eli Zaretskii <eliz@gnu.org>
4060
4061 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4062
29a6015a
PE
40632011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4064
a3a6c54e
PE
4065 Fix more problems found by GCC 4.5.2's static checks.
4066
b766f867
PE
4067 * process.c (make_serial_process_unwind, send_process_trap):
4068 (sigchld_handler): Now static.
4069
be02381c
PE
4070 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4071 That way, the code declares only the vars that it needs.
4072 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4073 * s/cygwin.h (PTY_ITERATION): Likewise.
4074 * s/darwin.h (PTY_ITERATION): Likewise.
4075 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4076
57048744
PE
4077 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4078 * process.c (allocate_pty): Don't declare stb unless it's needed.
4079
7914961c 4080 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4081 (CONSTANTLIM): Remove; unused.
4082 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4083 Define only if needed.
7914961c 4084
b3967b18
PE
4085 * unexelf.c (unexec): Name an expression,
4086 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4087 Use a different way to cause a compilation error if anyone uses
4088 n rather than nn, a way that does not involve shadowing.
73366a00 4089 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4090
29a6015a
PE
4091 * deps.mk (unexalpha.o): Remove; unused.
4092
43cfc33e 4093 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4094 * unexec.h: New file.
ce701a33
PE
4095 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4096 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4097 Depend on unexec.h.
4098 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4099 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4100 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4101 Change as necessary to match prototype in unexec.h.
ce701a33 4102
01f44d5a
PE
4103 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4104 shadowing.
4f63c6bb 4105 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4106
a6670b0b
PE
4107 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4108 Rename locals to avoid shadowing.
4109
cef2010d 4110 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4111 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4112
d4d7173a
PE
4113 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4114
f08b802a
PE
4115 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4116 warning when compiling print.c.
4117
3ddb0639
PE
4118 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4119 instead of using an uninitialized var.
5ad03b97 4120 (font_sort_entities): Mark var as initialized.
3ddb0639 4121
170a2692
PE
4122 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4123
e663c700
PE
4124 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4125 pointers to constants.
89bc529a 4126 (font_parse_fcname): Remove unused vars.
7b81e2d0 4127 (font_delete_unmatched): Now static.
ea838e10 4128 (font_get_spec): Remove; unused.
13a547c6
PE
4129 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4130 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4131 Rename or move locals to avoid shadowing.
e663c700 4132
2a80c887 4133 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4134 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4135
1384fa33 4136 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4137 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4138
8b2c52e9
PE
4139 * alloc.c (mark_backtrace): Move decl from here ...
4140 * lisp.h: ... to here, so that it can be checked.
4141
475545b5 4142 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4143 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4144 (lisp_indirect_variable): Name an expression,
4145 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4146 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4147
b1349114 4148 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4149 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4150 Use const pointer when appropriate.
b1349114 4151
a2928364
PE
4152 * lisp.h (get_system_name, get_operating_system_release):
4153 Move decls here, to check interfaces.
4154 * process.c (get_operating_system_release): Move decl to lisp.h.
4155 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4156 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4157 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4158 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4159 (Fformat_time_string, Fencode_time, Finsert_char):
4160 (Ftranslate_region_internal, Fformat):
4161 Rename or remove local vars to avoid shadowing.
9710023e 4162 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4163
a415e694
PE
4164 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4165 avoid shadowing.
4166
8ef4622d
PE
4167 * lisp.h (eassert): Check that the argument compiles, even if
4168 ENABLE_CHECKING is not defined.
4169
946f9a5b
PE
4170 * data.c (Findirect_variable): Name an expression, to avoid
4171 gcc -Wbad-function-cast warning.
112396d6 4172 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4173 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4174 (Fmake_variable_buffer_local, Fmake_local_variable):
4175 Mark variables as initialized.
52746918 4176 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4177
e5aab7e7 4178 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4179 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4180 Rename locals to avoid shadowing.
dff45157
PE
4181 (mark_stack): Move local variables into the #ifdef region where
4182 they're used.
7bc26fdb
PE
4183 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4184 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4185 needed otherwise.
4186 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4187 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4188 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4189
e5aab7e7
PE
4190 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4191 avoids undefined behavior in theory.
4192
4da60324
PE
4193 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4194
88043301
PE
4195 Use functions, not macros, for up- and down-casing (Bug#8254).
4196 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4197 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4198 to use the following functions instead of these macros.
4199 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4200 EMACS_INT, since callers assume the returned value fits in int.
4201 (upcase1): Likewise, for UPCASE_TABLE.
4202 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4203 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4204 the race-condition problem in the old DOWNCASE.
88043301 4205
19ed5445
PE
4206 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4207 Rename locals to avoid shadowing.
4208 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4209 (regex_compile, re_search_2, re_match_2_internal):
4210 Remove unused local vars.
952db0d7
PE
4211 (FREE_VAR): Rewrite so as not to use empty "else",
4212 which gcc can warn about.
da053e48 4213 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4214 (RETALLOC_IF): Define only if needed.
4215 (WORDCHAR_P): Likewise. This one is never needed, but is used
4216 only in a comment talking about a compiler bug, so put inside
4217 the #if 0 of that comment.
4218 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4219 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4220 Remove; unused.
19ed5445 4221
1f3561e4 4222 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4223 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4224 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4225
ded6f8f7
PE
4226 * search.c (simple_search): Remove unused var.
4227
dbd37a95
PE
4228 * dired.c (compile_pattern): Move decl from here ...
4229 * lisp.h: ... to here, so that it can be checked.
4230 (struct re_registers): New forward decl.
4231
7e47afad
PE
4232 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4233
85f24f61
PE
4234 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4235 All uses changed.
4236 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4237 Rename locals to avoid shadowing.
5671df8f 4238 (Fvertical_motion): Mark locals as initialized.
85f24f61 4239
181aa2be 4240 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4241 (casify_region): Mark local as initialized.
181aa2be 4242
930d429c
PE
4243 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4244
7082eac6
PE
4245 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4246 New macros, so that the caller can use some names other than
4247 gcpro1, gcpro2, etc.
4248 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4249 of the new macros.
4250 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4251 argument, for consistency with GCPRO2_VAR, etc: it is now the
4252 prefix of the variable, not the variable itself. All uses
4253 changed.
38b2c076
PE
4254 * dired.c (directory_files_internal, file_name_completion):
4255 Rename locals to avoid shadowing.
4256
15206ed9
PE
4257 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4258 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4259 dired.c's scmp function, had undefined behavior.
4260 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4261 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4262 * buffer.h: ... to here, because these macros use current_buffer,
4263 and the new implementation with inline functions needs to have
4264 current_buffer in scope now, rather than later when the macros
4265 are used.
4266 (downcase, upcase1): New static inline functions.
4267 (DOWNCASE, UPCASE1): Reimplement using these functions.
4268 This avoids undefined behavior in expressions like
4269 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4270 from race conditions in accessing the global variables
4271 case_temp1 and case_temp2.
4272 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4273 * lisp.h (case_temp1, case_temp2): Remove their decls.
4274 * character.h (ASCII_CHAR_P): Move from here ...
4275 * lisp.h: ... to here, so that the inline functions mentioned
4276 above can use them.
4277
4a6bea26
PE
4278 * dired.c (directory_files_internal_unwind): Now static.
4279
f14b7e14
PE
4280 * fileio.c (file_name_as_directory, directory_file_name):
4281 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4282 Now static.
2893f146
PE
4283 (file_name_as_directory): Use const pointers when appropriate.
4284 (Fexpand_file_name): Likewise. In particular, newdir might
4285 point at constant storage, so make it a const pointer.
fd4ead52 4286 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4287 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4288 signedness issues.
f839df0c
PE
4289 (Fset_file_times, Finsert_file_contents, auto_save_error):
4290 Rename locals to avoid shadowing.
f14b7e14 4291
5716756e 4292 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4293 (Ftry_completion, Fall_completions): Rename or remove locals
4294 to avoid shadowing.
5716756e 4295
b4c3046a
PE
4296 * marker.c (bytepos_to_charpos): Remove; unused.
4297
b45db522
PE
4298 * lisp.h (verify_bytepos, count_markers): New decls,
4299 so that gcc does not warn that these functions aren't declared.
4300
85876d07
PE
4301 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4302 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4303 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4304 (copy_text): Remove unused local var.
85876d07 4305
03d78a21 4306 * filelock.c (within_one_second): Now static.
b3dd38ab 4307 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4308
5df8f01b
PE
4309 * buffer.c (fix_overlays_before): Mark locals as initialized.
4310 (fix_start_end_in_overlays): Likewise. This function should be
4311 simplified by using pointers-to-pointers, but that's a different
4312 matter.
b1d876f1 4313 (switch_to_buffer_1): Now static.
8f54f30a
PE
4314 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4315 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4316
a70072c9 4317 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4318 Fix pointer signedness issue.
edced198
PE
4319 (sys_subshell): Mark local as volatile if checking for lint,
4320 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4321 (MAXPATHLEN): Define only if needed.
a70072c9 4322
a0977c44
PE
4323 * process.c (serial_open, serial_configure): Move decls from here ...
4324 * systty.h: ... to here, so that they can be checked.
4325
a884fdcc
PE
4326 * fns.c (get_random, seed_random): Move extern decls from here ...
4327 * lisp.h: ... to here, so that they can be checked.
4328
604efe86 4329 * sysdep.c (reset_io): Now static.
b8950c94 4330 (wait_for_termination_signal): Remove; unused.
604efe86 4331
38fc62d9
PE
4332 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4333 (copy_keymap_item, append_key, push_text_char_description):
4334 Now static.
1004a21a 4335 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4336 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4337 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4338 (describe_map_tree):
4339 Rename locals to avoid shadowing.
38fc62d9 4340
2f2650da
PE
4341 * keyboard.c: Declare functions static if they are not used elsewhere.
4342 (echo_char, echo_dash, cmd_error, top_level_2):
4343 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4344 (read_char, kbd_buffer_get_event, make_lispy_position):
4345 (make_lispy_event, make_lispy_movement, apply_modifiers):
4346 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4347 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4348 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4349 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4350 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4351
a053e86c 4352 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4353 (mark_kboards): Move decl here ...
4354 * alloc.c (mark_kboards): ... from here.
a053e86c 4355
4752793e
PE
4356 * lisp.h (force_auto_save_soon): New decl.
4357
74f10ca7 4358 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4359 (DEFINE_DUMMY_FUNCTION): New macro.
4360 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4361 Use it.
c03cd23f
PE
4362 (main): Add casts to avoid warnings
4363 if GCC considers string literals to be constants.
74f10ca7 4364
022e70d4
PE
4365 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4366
59d6fe83
PE
4367 * dbusbind.c: Pointer signedness fixes.
4368 (xd_signature, xd_append_arg, xd_initialize):
4369 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4370 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4371 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4372 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4373
78320123
PE
4374 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4375 if GCC considers string literals to be constants.
49cebcca 4376 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4377
35ac2a97
SM
43782011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4379
fb103ca9
SM
4380 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4381 (print_preprocess, print_object): New macro to fix last change.
4382
35ac2a97
SM
4383 * print.c (print_preprocess): Don't forget font objects.
4384
62973b41
JB
43852011-03-16 Juanma Barranquero <lekktu@gmail.com>
4386
4387 * emacs.c (USAGE3): Doc fixes.
4388
0e48bb22
AS
43892011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4390
4391 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4392 structure.
4393
7684e57b
JB
43942011-03-14 Juanma Barranquero <lekktu@gmail.com>
4395
4396 * lisp.h (VWindow_system, Qfile_name_history):
4397 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4398 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4399 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4400
4401 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4402 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4403
4404 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4405 * w32console.c (detect_input_pending, read_input_pending)
4406 (encode_terminal_code):
4407 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4408 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4409 (w32_system_caret_y, Qfile_name_history):
4410 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4411 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4412 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4413 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4414 * w32proc.c (Qlocal, report_file_error):
4415 * w32term.c (Vwindow_system, updating_frame):
4416 * w32uniscribe.c (initialized, uniscribe_font_driver):
4417 Remove unneeded extern declarations.
4418
2aa46d6c
CY
44192011-03-14 Chong Yidong <cyd@stupidchicken.com>
4420
c96bbc66 4421 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4422
cffc6f3b
CY
44232011-03-13 Chong Yidong <cyd@stupidchicken.com>
4424
4425 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4426 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4427 These macros can no longer be used for assignment.
4428
44f230aa
SM
4429 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4430 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4431 (record_buffer_markers, fetch_buffer_markers): New functions for
4432 recording and fetching special buffer markers.
4433 (set_buffer_internal_1, set_buffer_temp): Use them.
4434
4435 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4436
4437 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4438
4439 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4440 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4441
4442 * xdisp.c (hscroll_window_tree):
4443 (reconsider_clip_changes): Use PT instead of BUF_PT.
4444
d251f04b
EZ
44452011-03-13 Eli Zaretskii <eliz@gnu.org>
4446
4447 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4448 $(EMACS_ROOT)/lib/intprops.h.
4449
f0c77cd1
PE
44502011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4451
3eca4629
PE
4452 Fix more problems found by GCC 4.5.2's static checks.
4453
7c86ee98
PE
4454 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4455 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4456 (xg_free_frame_widgets): Make it clear that a local variable is
4457 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4458 (gdk_window_get_screen): Make it clear that this macro is needed
4459 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4460 (int_gtk_range_get_value): New function, which avoids a diagnostic
4461 from gcc -Wbad-function-cast.
4462 (xg_set_toolkit_scroll_bar_thumb): Use it.
4463 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4464 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4465 (get_utf8_string, xg_get_file_with_chooser):
4466 Rename locals to avoid shadowing.
4467 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4468
41729b81
PE
4469 * xgselect.c (xg_select): Remove unused var.
4470
f0c77cd1
PE
4471 * image.c (four_corners_best): Mark locals as initialized.
4472 (gif_load): Initialize transparent_p to zero (Bug#8238).
4473 Mark another local as initialized.
ec6cf4c6 4474 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4475
ce0ad53d 4476 * image.c (clear_image_cache): Now static.
d5d5a617 4477 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4478 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4479 (x_edge_detection): Remove unnecessary cast that
4480 gcc -Wbad-function-cast diagnoses.
2037898d 4481 (gif_load): Fix pointer signedness.
6ae141d6
PE
4482 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4483 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4484
33383987 44852011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4486
d32df629
PE
4487 Improve quality of tests for time stamp overflow.
4488 For example, without this patch (encode-time 0 0 0 1 1
4489 1152921504606846976) returns the obviously-bogus value (-948597
4490 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4491 reports time overflow. See
4492 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4493 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4494 * editfns.c: Include limits.h and intprops.h.
4495 (TIME_T_MIN, TIME_T_MAX): New macros.
4496 (time_overflow): Move earlier, to before first use.
4497 (hi_time, lo_time): New functions, for an accurate test for
4498 out-of-range times.
4499 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4500 (Fget_internal_run_time): Don't assume time_t fits in int.
4501 (make_time): Use list2 instead of Fcons twice.
4502 (Fdecode_time): More accurate test for out-of-range times.
4503 (check_tm_member): New function.
4504 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4505 (lisp_time_argument): Don't rely on undefined left-shift and
4506 right-shift behavior when checking for time stamp overflow.
8be6f318 4507
fe31d94c
PE
4508 * editfns.c (time_overflow): New function, refactoring common code.
4509 (Fformat_time_string, Fdecode_time, Fencode_time):
4510 (Fcurrent_time_string): Use it.
4511
8be6f318
PE
4512 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4513 * dired.c (make_time): Move to ...
4514 * editfns.c (make_time): ... here.
4515 * systime.h: Note the move.
4516
09d9db2c 45172011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4518
126bc0dc
YM
4519 * fringe.c (update_window_fringes): Remove unused variables.
4520
c47cbdfd
YM
4521 * unexmacosx.c (copy_data_segment): Also copy __got section.
4522 (Bug#8223)
4523
7ac80be9
EZ
45242011-03-12 Eli Zaretskii <eliz@gnu.org>
4525
c96bbc66 4526 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4527 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4528 Constify `char *' arguments and their references according to
4529 prototypes in tparam.h.
4530
ecb0f94d 4531 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4532
7ac80be9
EZ
4533 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4534 Adapt all references accordingly.
4535
4536 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4537
ef1fd07e
TT
45382011-03-11 Tom Tromey <tromey@redhat.com>
4539
4540 * buffer.c (syms_of_buffer): Remove obsolete comment.
4541
7ef4b50c
EZ
45422011-03-11 Eli Zaretskii <eliz@gnu.org>
4543
4544 * termhooks.h (encode_terminal_code): Declare prototype.
4545
4546 * msdos.c (encode_terminal_code): Don't declare prototype.
4547
4548 * term.c (encode_terminal_code): Now external again, used by
4549 w32console.c and msdos.c.
4550
44f230aa
SM
4551 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4552 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4553
4b1ec863 45542011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4555
1714f52b 4556 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4557
4b1ec863
PE
4558 * fringe.c (update_window_fringes): Mark locals as initialized
4559 (Bug#8227).
4560 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4561
524c7aa6
PE
4562 * alloc.c (mark_fringe_data): Move decl from here ...
4563 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4564 to check its interface.
4565 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4566
a5c0af81 4567 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4568 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4569 (fontset_font): Mark local as initialized.
a9a06e0b 4570 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4571
b4716021
PE
4572 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4573
811e9bac 4574 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4575 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4576 (x_own_selection, Fx_disown_selection_internal): Rename locals
4577 to avoid shadowing.
4578 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4579
7e3ab302
PE
4580 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4581 so that the caller can use some name other than gcpro1.
4582 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4583 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4584 (Fx_backspace_delete_keys_p):
4585 Use them to avoid shadowing, and rename vars to avoid shadowing.
4586 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4587 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4588 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4589 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4590 Remove unused locals.
7e3ab302
PE
4591 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4592 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4593 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4594 macros.
f78faa98 4595
e2b13473
PE
4596 * xterm.h (x_mouse_leave): New decl.
4597
77f23912
PE
4598 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4599 Remove unused functions.
cdf4ba58
PE
4600 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4601 (x_calc_absolute_position): Now static.
7411c686 4602 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4603 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4604 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4605 unless they are used.
38d0b34a
PE
4606 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4607 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4608 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4609 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4610 (x_error_catcher, x_connection_closed, x_error_handler):
4611 (x_error_quitter, xembed_send_message, x_iconify_frame):
4612 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4613 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4614 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4615
44f230aa
SM
4616 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4617 Rename or move locals to avoid shadowing.
6b463e58 4618 (tty_defined_color, merge_face_heights): Now static.
5967d051 4619 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4620 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4621 does not deduce is never used uninitialized.
73719eba
PE
4622 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4623 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4624
426994c3 4625 * terminal.c (store_terminal_param): Now static.
5489860b 4626
032f1620 4627 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4628 (set_frame_menubar): Remove unused local.
d4323972 4629 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4630 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4631 since they might point to immutable storage.
281585b0
PE
4632 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4633 since it's unused otherwise.
032f1620 4634
367c19e5 4635 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4636 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4637 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4638 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4639 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4640 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4641 does not deduce are never used uninitialized.
70739cbe 4642
07b48fa9
PE
4643 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4644
8868a238 4645 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4646 * window.c (window_loop, size_window):
4647 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4648
7e5cf297 4649 * window.c (display_buffer): Now static.
d6550a9f
PE
4650 (size_window): Mark variables that gcc -Wuninitialized
4651 does not deduce are never used uninitialized.
a586633d
PE
4652 * window.h (check_all_windows): New decl, to forestall
4653 gcc -Wmissing-prototypes diagnostic.
5b555da1 4654 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4655
f6095868
PE
4656 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4657 shadowing.
4658 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4659 Include <limits.h>.
4660 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4661 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4662 (load_charset_map): Mark variables that gcc -Wuninitialized
4663 does not deduce are never used uninitialized.
53df7c11 4664 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4665
f38b440c
PE
4666 * coding.c (coding_set_source, coding_set_destination):
4667 Use "else { /* comment */ }" rather than "else /* comment */;"
4668 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4669 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4670 a block, when the outer 'i' will do.
4671 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4672 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4673 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4674 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4675 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4676 Rename locals to avoid shadowing.
4677 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4678 * coding.c (emacs_mule_char, encode_invocation_designation):
4679 Now static, since they're not used elsewhere.
413bb2db 4680 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4681 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4682 (decode_coding_emacs_mule): Mark variables that gcc
4683 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4684 (detect_coding_iso_2022): Initialize a local variable that might
4685 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4686 this initialization is needed. (Bug#8211)
5f58e762
PE
4687 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4688 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4689 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4690 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4691 Remove unused macros.
f38b440c 4692
232b38b9 4693 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4694 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4695 * character.c (string_count_byte8): Likewise.
232b38b9 4696
fb90da1b
PE
4697 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4698 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4699
fb93dbc2
PE
4700 * chartab.c (copy_sub_char_table): Now static, since it's not used
4701 elsewhere.
5c156ace
PE
4702 (sub_char_table_ref_and_range, char_table_ref_and_range):
4703 Rename locals to avoid shadowing.
bbcd0949 4704 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4705
7d3b3862 4706 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4707 (BIDI_BOB): Remove unused macro.
7d3b3862 4708
6be7d3da
PE
4709 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4710 deduce are never used uninitialized.
c2ed9c8b 4711 * term.c (encode_terminal_code): Likewise.
6be7d3da 4712
75f8807f 4713 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4714
50938595
PE
4715 * tparam.h: New file.
4716 * term.c, tparam.h: Include it.
4717 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4718 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4719 Move these decls to tparam.h, and make them agree with what
4720 is actually in tparam.c. The previous trick of using incompatible
4721 decls in different modules does not conform to the C standard.
4722 All callers of tparam changed to use tparam's actual API.
4723 * tparam.c (tparam1, tparam, tgoto):
4724 Use const pointers where appropriate.
4725
fbceeba2
PE
4726 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4727 * cm.h (struct cm): Likewise.
4728 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4729 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4730 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4731 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4732 (turn_on_face, init_tty): Likewise.
4733 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4734
7f3f1250
PE
4735 * term.c (term_mouse_position): Rename local to avoid shadowing.
4736
e6ca6543
PE
4737 * alloc.c (mark_ttys): Move decl from here ...
4738 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4739
c40f8d15
AS
47402011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4741
4742 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4743
cfe0661d
JB
47442011-03-09 Juanma Barranquero <lekktu@gmail.com>
4745
4746 * search.c (compile_pattern_1): Remove argument regp, unused since
4747 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4748 (compile_pattern): Don't pass it.
4749
0afb4571
J
47502011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4751
4752 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4753 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4754 for ! HAVE_GTK3.
4755 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4756
4757 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4758
4759 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4760 gdk_window_get_screen, gdk_window_get_geometry,
4761 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4762 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4763 (xg_get_pixbuf_from_pixmap): New function.
4764 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4765 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4766 Call xg_get_pixbuf_from_pixmap instead of
4767 gdk_pixbuf_get_from_drawable.
4768 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4769 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4770 (xg_check_special_colors): Use GtkStyleContext and its functions
4771 for HAVE_GTK3.
4772 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4773 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4774 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4775 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4776 Call gtk_widget_get_preferred_size.
0afb4571
J
4777 (xg_frame_resized): gdk_window_get_geometry only takes 5
4778 parameters.
44f230aa
SM
4779 (xg_win_to_widget, xg_event_is_for_menubar):
4780 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4781 (xg_set_widget_bg): New function.
4782 (delete_cb): New function.
895009e1 4783 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4784 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4785 (xg_set_background_color): Call xg_set_widget_bg.
4786 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4787 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4788 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4789 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4790 if ! HAVE_GTK3.
4791 (update_frame_tool_bar): Call gtk_widget_hide.
4792 (xg_initialize): Use GDK_KEY_g.
4793
4794 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4795 if ! HAVE_GTK3
4796 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4797
4798 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4799 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4800 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4801
1c2cc4ef
JB
48022011-03-08 Juanma Barranquero <lekktu@gmail.com>
4803
4804 * w32xfns.c (select_palette): Check success of RealizePalette against
4805 GDI_ERROR, not zero.
4806
33383987 4807See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4808
4809;; Local Variables:
4810;; coding: utf-8
aac0c6e3
MR
4811;; End:
4812
33383987 4813 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4814
4815 This file is part of GNU Emacs.
4816
4817 GNU Emacs is free software: you can redistribute it and/or modify
4818 it under the terms of the GNU General Public License as published by
4819 the Free Software Foundation, either version 3 of the License, or
4820 (at your option) any later version.
4821
4822 GNU Emacs is distributed in the hope that it will be useful,
4823 but WITHOUT ANY WARRANTY; without even the implied warranty of
4824 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4825 GNU General Public License for more details.
4826
4827 You should have received a copy of the GNU General Public License
4828 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.