nnir.el (nnir-read-server-parm): Add an argument to restrict to server-variables...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
640c8776
SM
12011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4
f26d0e4c
PE
52011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6
8a10d76c
PE
7 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8 so that it is not optimized away.
9
f26d0e4c
PE
10 * xdisp.c (compute_display_string_pos): Remove unused local.
11
55439c61
EZ
122011-08-02 Eli Zaretskii <eliz@gnu.org>
13
14 Fix slow cursor motion and scrolling in large buffers with
15 selective display, like Org Mode buffers. (Bug#9218)
16
17 * dispextern.h (struct bidi_it): New member disp_prop_p.
18
19 * xdisp.c: Remove one-slot cache of display string positions.
20 (compute_display_string_pos): Accept an additional argument
21 DISP_PROP_P; callers changed. Scan at most 5K characters forward
22 for a display string or property. If found, set DISP_PROP_P
23 non-zero.
24
25 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
26 DISP_PROP_P, and pass it to compute_display_string_pos.
27 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
28 non-zero. All callers of bidi_fetch_char changed.
29
fb33fa43
SM
302011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
31
32 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
33
b099e063
DM
342010-12-03 Don March <don@ohspite.net>
35
36 * keymap.c (Fdefine_key): Fix non-prefix key error message when
37 last character M-[char] is translated to ESC [char] (bug#7541).
38
5cc7f7af
KH
392011-08-02 Kenichi Handa <handa@m17n.org>
40
d0fffa3f 41 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
42
43 * chartab.c (uniprop_table): Make it non-static.
44
525d5e6e
EZ
452011-08-01 Eli Zaretskii <eliz@gnu.org>
46
47 * xdisp.c (forward_to_next_line_start): Accept additional argument
48 BIDI_IT_PREV, and store into it the state of the bidi iterator had
49 on the newline.
50 (reseat_at_next_visible_line_start): Use the bidi iterator state
51 returned by forward_to_next_line_start to restore the state of
52 it->bidi_it after backing up to previous newline. (Bug#9212)
53
31011111
AS
542011-07-30 Andreas Schwab <schwab@linux-m68k.org>
55
56 * regex.c (re_comp): Protoize.
57 (re_exec): Fix return type.
58 (regexec): Fix type of `ret'. (Bug#9203)
59
e5d76069
PE
602011-07-29 Paul Eggert <eggert@cs.ucla.edu>
61
62 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
63 This is needed if max-image-size is a floating-point number.
64
9a79b20c
AS
652011-07-28 Andreas Schwab <schwab@linux-m68k.org>
66
67 * print.c (print_object): Print empty symbol as ##.
68
69 * lread.c (read1): Read ## as empty symbol.
70
d8c2fa78
AA
712011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
72
73 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
74 setting frame foreground color (Bug#9175).
75 (x_set_background_color): Likewise.
76
ffe57a7a
AA
77 * nsmenu.m (-setText): Size tooltip dimensions precisely to
78 contents (Bug#9176).
79 (EmacsTooltip -init): Remove bezels and add shadows to
80 tooltip windows.
81
bf3492a5
AA
82 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
83 or scroll bar (Bug#8470).
84
d55e9c53
AA
85 * nsfont.m (nsfont_open): Remove assignment to voffset and
86 unnecessary vars hshink, expand, hd, full_height, min_height.
87 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
88
89 * nsterm.h (nsfont_info): Remove voffset field.
90
d8c2fa78 912011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
92
93 Implement strike-through and overline on NextStep (Bug#8863).
94
95 * nsfont.m (nsfont_open): Use underline position provided by font,
96 instead of hard-coded value of 2.
97 (nsfont_draw): Call ns_draw_text_decoration instead.
98
99 * nsterm.h: Add declaration for ns_draw_text_decoration.
100
101 * nsterm.m (ns_draw_text_decoration): New function for drawing
102 underline, overline, and strike-through.
103 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
104 ns_draw_text_decoration. Change treatment of cursor drawing to
105 accomodate underlining, etc.
106
4cc60b9b
EZ
1072011-07-28 Eli Zaretskii <eliz@gnu.org>
108
bc7ece87
EZ
109 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
110 default.
4cc60b9b 111
476371c4
PE
1122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
113
66606eea
PE
114 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
115 Without this fix, if a signal arrives just after memory fills up,
116 'malloc' might be invoked reentrantly.
117
476371c4
PE
118 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
119 In other words, assume that every image size is allowed, on non-X
120 hosts. This assumption is probably wrong, but it lets Emacs compile.
121
f3fcc40d
AS
1222011-07-28 Andreas Schwab <schwab@linux-m68k.org>
123
124 * regex.c (re_iswctype): Convert return values to boolean.
125
350c992f
EZ
1262011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
127
128 * xdisp.c (compute_display_string_pos): Don't use cached display
129 string position if the buffer had its restriction changed.
130 (Bug#9184)
131
5266b4bb
PE
1322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
133
134 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
135
2573a837 1362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 137
41f55ccd 138 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 139
39e378da
PE
140 * bidi.c: Integer size and overflow fixes.
141 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
142 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
143 (bidi_cache_find_level_change, bidi_cache_ensure_space)
144 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
145 (bidi_find_other_level_edge):
146 Use ptrdiff_t instead of EMACS_INT where either will do.
147 This works better on 32-bit hosts configured --with-wide-int.
148 (bidi_cache_ensure_space): Check for size-calculation overflow.
149 Use % rather than repeated addition, for better worst-case speed.
150 Don't set bidi_cache_size until after xrealloc returns, because it
151 might not return.
152 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
153 (bidi_cache_ensure_space): Also check that the bidi cache size
154 does not exceed that of the largest Lisp string or buffer. See Eli
155 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 156
5e927815
PE
157 * alloc.c (__malloc_size_t): Remove.
158 All uses replaced by size_t. See Andreas Schwab's note
159 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
160
ca4aa935
PE
161 * image.c: Improve checking for integer overflow.
162 (check_image_size): Assume that f is nonnull, since
163 it is always nonnull in practice. This is one less thing to
164 worry about when checking for integer overflow later.
165 (x_check_image_size): New function, which checks for integer
166 overflow issues inside X.
167 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
168 This removes the need for a memory_full check.
169 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
170 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
171 (xbm_read_bitmap_data): Change locals back to 'int', since
172 their values must fit in 'int'.
173 (xpm_load_image, png_load, tiff_load):
174 Invoke x_create_x_image_and_pixmap earlier,
175 to avoid much needless work if the image is too large.
176 (tiff_load): Treat overly large images as if
177 x_create_x_image_and_pixmap failed, not as malloc failures.
178 (gs_load): Use x_check_image_size.
179
5f8f9cc2
PE
180 * gtkutil.c: Omit integer casts.
181 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
182 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
183
5adf60bc
PE
184 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
185
c8907a93
PE
186 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
187 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
188 would wrongly return t on a 64-bit host.
189
e3c25c68
PE
190 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
191 The plain *_OVERFLOW macros run afoul of GCC bug 49705
192 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
193 and therefore cause GCC to emit a bogus diagnostic in some cases.
194
3f791afe
PE
195 * image.c: Integer signedness and overflow and related fixes.
196 This is not an exhaustive set of fixes, but it's time to
197 record what I've got.
198 (lookup_pixel_color, check_image_size): Remove redundant decls.
199 (check_image_size): Don't assume that arbitrary EMACS_INT values
200 fit in 'int', or that arbitrary 'double' values fit in 'int'.
201 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
202 (tiff_load, imagemagick_load_image):
203 Check for overflow in size calculations.
204 (x_create_x_image_and_pixmap): Remove unnecessary test for
205 xmalloc returning NULL; that can't happen.
206 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
207 (xpm_color_bucket): Use better integer hashing function.
208 (xpm_cache_color): Don't possibly over-allocate memory.
209 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
210 (gif_memory_source):
211 Use ptrdiff_t, not int or size_t, to record sizes.
212 (png_load): Don't assume values greater than 2**31 fit in 'int'.
213 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
214 either works, as we prefer signed integers.
215 (tiff_read_from_memory, tiff_write_from_memory):
216 Return tsize_t, not size_t, since that's what the TIFF API wants.
217 (tiff_read_from_memory): Don't fail simply because the read would
218 go past EOF; instead, return a short read.
219 (tiff_load): Omit no-longer-needed casts.
220 (Fimagemagick_types): Don't assume size fits into 'int'.
221
3cc5a532
PE
222 Improve hashing quality when configured --with-wide-int.
223 * fns.c (hash_string): New function, taken from sxhash_string.
224 Do not discard information about ASCII character case; this
225 discarding is no longer needed.
226 (sxhash-string): Use it. Change sig to match it. Caller changed.
227 * lisp.h: Declare it.
228 * lread.c (hash_string): Remove, since we now use fns.c's version.
229 The fns.c version returns a wider integer if --with-wide-int is
230 specified, so this should help the quality of the hashing a bit.
231
b312a492
PE
232 * emacs.c: Integer overflow minor fix.
233 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
234 Define only if GNU_LINUX.
235 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
236
dfd153ae
PE
237 * dispnew.c: Integer signedness and overflow fixes.
238 Remove unnecessary forward decls, that were a maintenance hassle.
239 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
240 All uses changed.
241 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
242 (scrolling_window): Use ptrdiff_t, not int, for byte count.
243 (prepare_desired_row, line_draw_cost):
244 Use int, not unsigned, where either works.
245 (save_current_matrix, restore_current_matrix):
246 Use ptrdiff_t, not size_t, where either works.
247 (init_display): Check for overflow more accurately, and without
248 relying on undefined behavior.
249
a81d11a3
PE
250 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
251 Remove, replacing with the new symbols in lisp.h. All uses changed.
252 * fileio.c (make_temp_name):
253 * filelock.c (lock_file_1, lock_file):
254 * xdisp.c (message_dolog):
255 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
256 Use pMd etc. instead.
257 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
258 replacing the pWIDE etc. symbols removed from editfns.c.
259
3300e6fd
PE
260 * keyboard.h (num_input_events): Now uintmax_t.
261 This is (very slightly) less likely to mess up due to wraparound.
262 All uses changed.
263
fd05c7e9
PE
264 * buffer.c: Integer signedness fixes.
265 (alloc_buffer_text, enlarge_buffer_text):
266 Use ptrdiff_t rather than size_t when either will do, as we prefer
267 signed integers.
268
903fe15d
PE
269 * alloc.c: Integer signedness and overflow fixes.
270 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
271 (__malloc_size_t): Default to size_t, not to int.
272 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
273 (Fgarbage_collect, mark_object_loop_halt, mark_object):
274 Prefer ptrdiff_t to size_t when either would do, as we prefer
275 signed integers.
276 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
277 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
278 Now const. Initialize with values that are in range even if char
279 is signed.
280 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
281 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
282 These functions do the right thing with sizes > 2**32.
283 (check_depth): Now ptrdiff_t, not int.
284 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
285 Adjust to new way of storing sizes. Check for size overflow bugs
286 in rest of code.
287 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
288 slightly wrong anyway, as it missed one instance of
289 XMALLOC_OVERRUN_CHECK_OVERHEAD.
290 (refill_memory_reserve): Omit needless cast to size_t.
291 (mark_object_loop_halt): Mark as externally visible.
292
ac82cc6a
PE
293 * xselect.c: Integer signedness and overflow fixes.
294 (Fx_register_dnd_atom, x_handle_dnd_message):
295 Use ptrdiff_t, not size_t, since we prefer signed.
296 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
297 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
298 x_dnd_atoms_size and x_dnd_atoms_length.
299
c2d1e36d
PE
300 * doprnt.c: Prefer signed to unsigned when either works.
301 * eval.c (verror):
302 * doprnt.c (doprnt):
303 * lisp.h (doprnt):
304 * xdisp.c (vmessage):
305 Use ptrdiff_t, not size_t, when using or implementing doprnt,
306 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
307 prefer signed arithmetic to avoid comparison confusion.
308 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
309 but is a bit tricky.
310
0e926e56
PE
311 Assume freestanding C89 headers, string.h, stdlib.h.
312 * data.c, doprnt.c, floatfns.c, print.c:
313 Include float.h unconditionally.
314 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
315 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
316 * regex.c: Likewise for stddef.h, string.h.
317 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
318 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
319 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
320 (STDC_HEADERS): Remove obsolete defines.
321 * sysdep.c: Include limits.h unconditionally.
322
9cfdb3ec
PE
323 Assume support for memcmp, memcpy, memmove, memset.
324 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
325 * regex.c (memcmp, memcpy):
326 Remove; we assume C89 now.
327
328 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
329 (__malloc_safe_bcopy): Remove; no longer needed.
330
cf950e6b 331 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
332 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
333 well either way, and we prefer signed to unsigned.
334
dbf38e02
LMI
3352011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
336
337 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
338 closes the connection while we're reading (bug#9182).
339
d6f0886c
JD
3402011-07-25 Jan Djärv <jan.h.d@swipnet.se>
341
342 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
343 are specified (Bug#9168).
344
2eb1f9e6
PE
3452011-07-25 Paul Eggert <eggert@cs.ucla.edu>
346
347 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
348 Found by GCC static checking and --with-wide-int on a 32-bit host.
349
22381272 3502011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
351
352 * xdisp.c (compute_display_string_pos): Fix logic of caching
353 previous display string position. Initialize cached_prev_pos to
354 -1. Fixes slow-down at the beginning of a buffer.
355
f25e39b4
EZ
3562011-07-24 Eli Zaretskii <eliz@gnu.org>
357
358 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
359 for attrs[LFACE_FONTSET_INDEX].
360
04c4b52e
PE
3612011-07-23 Paul Eggert <eggert@cs.ucla.edu>
362
363 * xml.c (parse_region): Remove unused local
364 that was recently introduced.
365
c1734fbd
EZ
3662011-07-23 Eli Zaretskii <eliz@gnu.org>
367
be18c5a5
EZ
368 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
369 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
370
c1734fbd
EZ
371 * xdisp.c (move_it_in_display_line_to): Record the best matching
372 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
373 exit if none of the characters scanned was an exact match.
374 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
375 when exact match is impossible due to invisible text, and the
376 lines are truncated.
377
a258d627
JD
3782011-07-23 Jan Djärv <jan.h.d@swipnet.se>
379
380 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
381 for OSX >= 10.7.
382
b6d5a689
EZ
3832011-07-22 Eli Zaretskii <eliz@gnu.org>
384
0f74f785
EZ
385 Fix a significant slow-down of cursor motion with C-n, C-p,
386 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
387 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 388 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
389 (next_element_from_buffer): Call compute_stop_pos_backwards to
390 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
391 base_level_stop.
392 (reseat): Don't look for prev_stop, as that could mean a very long
393 run.
394 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
395 <cached_disp_overlay_modiff>: Cache for last found display string
396 position.
551918c1 397 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
398 about the same buffer in the same area of character positions, and
399 the buffer wasn't changed since the time the display string
400 position was cached.
551918c1 401
b2d0c91a
EZ
4022011-07-22 Eli Zaretskii <eliz@gnu.org>
403
404 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
405 is an integer, which is important for empty lines. (Bug#9149)
406
043604ee
CY
4072011-07-22 Chong Yidong <cyd@stupidchicken.com>
408
409 * frame.c (Fmodify_frame_parameters): In tty case, update the
410 default face if necessary (Bug#4238).
411
da4adb04
CY
4122011-07-21 Chong Yidong <cyd@stupidchicken.com>
413
414 * editfns.c (Fstring_to_char): No need to explain what a character
415 is in the docstring (Bug#6576).
416
9abd0532
LMI
4172011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
418
419 * xml.c (parse_region): Make sure we always return a tree.
420
36881d16
HK
4212011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
422
423 * xml.c (parse_region): If a document contains only comments,
424 return that, too.
425
1e98674d
LMI
4262011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
427
428 * xml.c (make_dom): Return comments, too.
429
590bd467
PE
4302011-07-19 Paul Eggert <eggert@cs.ucla.edu>
431
432 Port to OpenBSD.
433 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
434 and the surrounding thread.
435 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
436 rather than fgets, and retry after EINTR. Otherwise, 'emacs
437 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
438 timer goes off.
439 * s/openbsd.h (BROKEN_SIGIO): Define.
440 * unexelf.c (unexec) [__OpenBSD__]:
441 Don't update the .mdebug section of the Alpha COFF symbol table.
442
f41628b2
LMI
4432011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
444
445 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
446 (bug#8460).
447
b59b67c5
PE
4482011-07-18 Paul Eggert <eggert@cs.ucla.edu>
449
15e3a074
PE
450 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
451 This fixes some race conditions on the permissions of any newly
452 created file.
453
41bed37d
PE
454 * alloc.c (valid_pointer_p): Use pipe, not open.
455 This fixes some permissions issues when debugging.
456
b59b67c5
PE
457 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
458 If fchown fails to set both uid and gid, try to set just gid,
459 as that is sometimes allowed. Adjust the file's mode to eliminate
460 setuid or setgid bits that are inappropriate if fchown fails.
461
925a6be7
SM
4622011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
463
464 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
465 to compare Lisp_Objects.
466 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
467 global_gnutls_log_level, don't mistake it for a Lisp_Object.
468 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
469
52968808
AS
4702011-07-17 Andreas Schwab <schwab@linux-m68k.org>
471
0a6a104b
AS
472 * lread.c (read_integer): Unread even EOF character.
473 (read1): Likewise. Properly record start position of symbol.
474
52968808
AS
475 * lread.c (read1): Read `#:' as empty uninterned symbol if no
476 symbol character follows.
477
9e381cdd
PE
4782011-07-17 Paul Eggert <eggert@cs.ucla.edu>
479
480 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
481 This works around a problem with the previous change to Fcopy_file.
482 Recent glibc declares fchown with __attribute__((warn_unused_result)),
483 and without this change, GCC might complain about discarding
484 fchown's return value.
485
b5641435
JB
4862011-07-16 Juanma Barranquero <lekktu@gmail.com>
487
488 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
489
a8031457
PE
4902011-07-16 Paul Eggert <eggert@cs.ucla.edu>
491
492 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
493
dd889327
LMI
4942011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
495
750c33f7
LMI
496 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
497 it's used from the C level.
498
dd889327
LMI
499 * process.c: Use the same condition for POLL_FOR_INPUT in both
500 keyboard.c and process.c (bug#1858).
501
87e86684
LM
5022011-07-09 Lawrence Mitchell <wence@gmx.li>
503
504 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
505 (Fgnutls_boot): Use it.
506
64348f40
AS
5072011-07-15 Andreas Schwab <schwab@linux-m68k.org>
508
509 * doc.c (Fsubstitute_command_keys): Revert last change.
510
1d698799
LMI
5112011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
512
f863868c
LMI
513 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
514 quotes the next character, and doesn't affect other longer
515 sequences (bug#8935).
516
1d698799
LMI
517 * lread.c (syms_of_lread): Clarify that is isn't only
518 `eval-buffer' and `eval-defun' that's affected by
519 `lexical-binding' (bug#8460).
520
aa4b6df6
EZ
5212011-07-15 Eli Zaretskii <eliz@gnu.org>
522
523 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
524 bidi redisplay when a line includes both an image and is
525 truncated.
526
5d856da6
PE
5272011-07-14 Paul Eggert <eggert@cs.ucla.edu>
528
ad6042bb
PE
529 Fix minor problems found by static checking.
530 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
531 (elsz): Now a signed constant, not a size_t var. We prefer signed
532 types to unsigned, to avoid integer comparison confusion. Without
533 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
534 "cannot optimize loop, the loop counter may overflow", a symptom
535 of the confusion.
f00bbb22 536 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
537 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
538
6468f31c
LMI
5392011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
540
49080b10
LMI
541 * search.c (Fre_search_backward): Mention `case-fold-search' in
542 all the re_search_* functions (bug#8138).
543
6468f31c
LMI
544 * keyboard.c (Fopen_dribble_file): Document when the file is
545 closed (bug#8056).
546
c965adc5
EZ
5472011-07-14 Eli Zaretskii <eliz@gnu.org>
548
df9733bf
EZ
549 * bidi.c (bidi_dump_cached_states): Fix format of displaying
550 bidi_cache_idx.
551
0bb23927
EZ
552 Support bidi reordering of display and overlay strings.
553 * xdisp.c (compute_display_string_pos)
554 (compute_display_string_end): Accept additional argument STRING.
555 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
556 (reseat_to_string): Initialize bidi_it->string.s and
557 bidi_it->string.schars.
558 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
559 NULL (avoids a crash in bidi_paragraph_init).
560 Initialize itb.string.lstring.
0bb23927
EZ
561 (init_iterator): Call bidi_init_it only of a valid
562 buffer position was specified. Initialize paragraph_embedding to
563 L2R.
564 (reseat_to_string): Initialize the bidi iterator.
565 (display_string): If we need to ignore text properties of
566 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
567 original value of -1 will not work with bidi.)
568 (compute_display_string_pos): First arg is now struct
569 `text_pos *'; all callers changed. Support display properties on
570 Lisp strings.
571 (compute_display_string_end): Support display properties on Lisp
572 strings.
573 (init_iterator, reseat_1, reseat_to_string): Initialize the
574 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
575 when iterating on a string not from display properties).
640c8776
SM
576 (compute_display_string_pos, compute_display_string_end):
577 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
578 arrow keys.
579 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
580 base_level_stop; instead, set base_level_stop to BEGV.
581 Fixes crashes in vertical-motion.
0bb23927
EZ
582 (next_element_from_buffer): Improve commentary for when
583 the iterator is before prev_stop.
584 (init_iterator): Initialize bidi_p from the default value of
585 bidi-display-reordering, not from buffer-local value. Use the
586 buffer-local value only if initializing for buffer iteration.
587 (handle_invisible_prop): Support invisible properties on strings
588 that are being bidi-reordered.
589 (set_iterator_to_next): Support bidi reordering of C strings and
590 Lisp strings.
591 (next_element_from_string): Support bidi reordering of Lisp
592 strings.
593 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
594 (display_string): Support display of R2L glyph rows.
595 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
596 (init_iterator): Don't initialize it->bidi_p for strings
597 here.
598 (reseat_to_string): Initialize it->bidi_p for strings here.
599 (next_element_from_string, next_element_from_c_string)
600 (next_element_from_buffer): Add xassert's for correspondence
601 between IT's object being iterated and it->bidi_it.string
602 structure.
603 (face_before_or_after_it_pos): Support bidi iteration.
604 (next_element_from_c_string): Handle the case of the first string
605 character that is not the first one in the visual order.
606 (get_visually_first_element): New function, refactored from common
607 parts of next_element_from_buffer, next_element_from_string, and
608 next_element_from_c_string.
609 (tool_bar_lines_needed, redisplay_tool_bar)
610 (display_menu_bar): Force left-to-right direction. Add a FIXME
611 comment for making that be controlled by a user option.
612 (push_it, pop_it): Save and restore the state of the
613 bidi iterator. Save and restore the bidi_p flag.
614 (pop_it): Iterate out of display property for string iteration as
615 well.
616 (iterate_out_of_display_property): Support iteration over strings.
617 (handle_single_display_spec): Set up it->bidi_it for iteration
618 over a display string, and call bidi_init_it.
619 (handle_single_display_spec, next_overlay_string)
620 (get_overlay_strings_1, push_display_prop): Set up the bidi
621 iterator for displaying display or overlay strings.
622 (forward_to_next_line_start): Don't use the shortcut if
623 bidi-iterating.
624 (back_to_previous_visible_line_start): If handle_display_prop
625 pushed the iterator stack, restore the internal state of the bidi
626 iterator by calling bidi_pop_it same number of times.
627 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
628 and we are bidi-iterating, don't decrement the iterator position;
629 instead, set the first_elt flag in the bidi iterator, to produce
630 the same effect.
631 (reseat_1): Remove redundant setting of string_from_display_prop_p.
632 (push_display_prop): xassert that we are iterating a buffer.
633 (push_it, pop_it): Save and restore paragraph_embedding member.
634 (handle_single_display_spec, next_overlay_string)
635 (get_overlay_strings_1, reseat_1, reseat_to_string)
636 (push_display_prop): Set up the `unibyte' member of bidi_it.string
637 correctly. Don't assume unibyte strings are not bidi-reordered.
638 (compute_display_string_pos)
639 (compute_display_string_end): Fix handling the case of C string.
640 (push_it, pop_it): Save and restore from_disp_prop_p.
641 (handle_single_display_spec, push_display_prop): Set the
642 from_disp_prop_p flag.
643 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
644 (pop_it): Call iterate_out_of_display_property only if we are
645 popping after iteration over a string that came from a display
646 property. Fix a typo in popping stretch info. Add an assertion
647 for verifying that the iterator position is in sync with the bidi
648 iterator.
649 (handle_single_display_spec, get_overlay_strings_1)
650 (push_display_prop): Fix initialization of paragraph direction for
651 string when that of the parent object is not yet determined.
652 (reseat_1): Call bidi_init_it to resync the bidi
653 iterator with IT's position. (Bug#7616)
654 (find_row_edges): If ROW->start.pos gives position
655 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
656 (handle_stop, back_to_previous_visible_line_start, reseat_1):
657 Reset the from_disp_prop_p flag.
658 (SAVE_IT, RESTORE_IT): New macros.
659 (pos_visible_p, face_before_or_after_it_pos)
660 (back_to_previous_visible_line_start)
661 (move_it_in_display_line_to, move_it_in_display_line)
662 (move_it_to, move_it_vertically_backward, move_it_by_lines)
663 (try_scrolling, redisplay_window, display_line): Use them when
664 saving a temporary copy of the iterator and restoring it back.
665 (back_to_previous_visible_line_start, reseat_1)
666 (init_iterator): Empty the bidi cache "stack".
667 (move_it_in_display_line_to): If iterator ended up at
668 EOL, but we never saw any buffer positions smaller than
669 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
670 motion in bidi-reordered lines.
671 (move_it_in_display_line_to): Record prev_method and prev_pos
672 immediately before the call to set_iterator_to_next. Fixes cursor
673 motion in bidi-reordered lines with stretch glyphs and strings
674 displayed in margins. (Bug#8133) (Bug#8867)
675 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
676 TO_CHARPOS.
640c8776
SM
677 (pos_visible_p): Support positions in bidi-reordered lines.
678 Save and restore bidi cache.
0bb23927
EZ
679
680 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
681 (bidi_paragraph_info): Delete unused struct.
682 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
683 (bidi_cache_start): New variable.
684 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
685 to zero.
686 (bidi_cache_fetch_state, bidi_cache_search)
687 (bidi_cache_find_level_change, bidi_cache_iterator_state)
688 (bidi_cache_find, bidi_peek_at_next_level)
689 (bidi_level_of_next_char, bidi_find_other_level_edge)
690 (bidi_move_to_visually_next): Compare cache index with
691 bidi_cache_start rather than with zero.
692 (bidi_fetch_char): Accept new argument STRING; all callers
693 changed. Support iteration over a string. Support strings with
694 display properties. Support unibyte strings. Fix the type of
695 `len' according to what STRING_CHAR_AND_LENGTH expects.
696 (bidi_paragraph_init, bidi_resolve_explicit_1)
697 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
698 (bidi_level_of_next_char, bidi_move_to_visually_next):
699 Support iteration over a string.
0bb23927
EZ
700 (bidi_set_sor_type, bidi_resolve_explicit_1)
701 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
702 can now be zero (for strings); special values 0 and -1 were
703 changed to -1 and -2, respectively.
704 (bidi_char_at_pos): New function.
705 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
706 Call it instead of FETCH_MULTIBYTE_CHAR.
707 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
708 initialized to valid values.
709 (bidi_init_it): Don't initialize charpos and bytepos with invalid
710 values.
711 (bidi_level_of_next_char): Allow the sentinel "position" to pass
712 the test for valid cached positions. Fix the logic for looking up
713 the sentinel state in the cache. GCPRO the Lisp string we are
714 iterating.
715 (bidi_push_it, bidi_pop_it): New functions.
716 (bidi_initialize): Initialize the bidi cache start stack pointer.
717 (bidi_cache_ensure_space): New function, refactored from part of
718 bidi_cache_iterator_state. Don't assume the required size is just
719 one BIDI_CACHE_CHUNK away.
720 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
721 (bidi_count_bytes, bidi_char_at_pos): New functions.
722 (bidi_cache_search): Don't assume bidi_cache_last_idx is
723 always valid if bidi_cache_idx is valid.
724 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
725 is valid if it's going to be used.
726 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
727 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
728 (bidi_cache_find_level_change, bidi_cache_ensure_space)
729 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
730 (bidi_find_other_level_edge, bidi_cache_start_stack):
731 All variables related to cache indices are now EMACS_INT.
c965adc5 732
0bb23927
EZ
733 * dispextern.h (struct bidi_string_data): New structure.
734 (struct bidi_it): New member `string'. Make flag members be 1-bit
735 fields, and put them last in the struct.
640c8776
SM
736 (compute_display_string_pos, compute_display_string_end):
737 Update prototypes.
0bb23927
EZ
738 (bidi_push_it, bidi_pop_it): Add prototypes.
739 (struct iterator_stack_entry): New members bidi_p,
740 paragraph_embedding, and from_disp_prop_p.
741 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
742 (bidi_shelve_cache, bidi_unshelve_cache):
743 Declare prototypes.
0bb23927
EZ
744
745 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
746 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
747 and vector-like objects.
748
749 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
750 cache around display iteration.
751
752 * window.c (Fwindow_end, window_scroll_pixel_based)
753 (displayed_window_lines, Frecenter): Save and restore the bidi
754 cache around display iteration.
755
3bbd2265
LMI
7562011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
757
758 * editfns.c (Fdelete_region): Clarify the use of the named
759 parameters (bug#6788).
760
adc47434
MR
7612011-07-14 Martin Rudalics <rudalics@gmx.at>
762
763 * indent.c (Fvertical_motion): Set and restore w->pointm when
764 saving and restoring the window's buffer (Bug#9006).
765
837c31f8
LMI
7662011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
767
768 * editfns.c (Fstring_to_char): Clarify just what is returned
769 (bug#6576). Text by Eli Zaretskii.
770
ac389d0c
JB
7712011-07-13 Juanma Barranquero <lekktu@gmail.com>
772
773 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
774
0be0ce47
EZ
7752011-07-13 Eli Zaretskii <eliz@gnu.org>
776
777 * buffer.c (mmap_find): Fix a typo.
778
cd18e7e3
JB
7792011-07-13 Johan Bockgård <bojohan@gnu.org>
780
781 Fix execution of x selection hooks.
782 * xselect.c (Qx_lost_selection_functions)
783 (Qx_sent_selection_functions): New vars.
784 (syms_of_xselect): DEFSYM them.
785 (x_handle_selection_request): Pass Qx_sent_selection_functions
786 rather than Vx_sent_selection_functions to Frun_hook_with_args.
787 (x_handle_selection_clear,x_clear_frame_selections):
788 Pass Qx_lost_selection_functions rather than
789 Vx_lost_selection_functions to Frun_hook_with_args.
790
47ea7f44
PE
7912011-07-13 Paul Eggert <eggert@cs.ucla.edu>
792
ac389d0c 793 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
794 The old code sometimes used this field without initializing it.
795
47ea7f44
PE
796 * alloc.c (gc_sweep): Don't read past end of array.
797 In theory, the old code could also have corrupted Emacs internals,
798 though it'd be very unlikely.
799
bc985c87
AS
8002011-07-12 Andreas Schwab <schwab@linux-m68k.org>
801
802 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 803 argument. (Bug#4026)
bc985c87 804
0cf34688
LMI
8052011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
806
b3dadd76
LMI
807 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
808 key" (bug#4257).
809
0cf34688
LMI
810 * window.c (Fset_window_start): Doc fix (bug#4199).
811 (Fset_window_hscroll): Ditto.
812
270768cd
PE
8132011-07-12 Paul Eggert <eggert@cs.ucla.edu>
814
077e3dda 815 Fix minor new problems caught by GCC 4.6.1.
270768cd 816 * term.c (init_tty): Remove unused local.
490011a6 817 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 818 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 819 not used otherwise.
270768cd 820
b1f58454
CY
8212011-07-12 Chong Yidong <cyd@stupidchicken.com>
822
823 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
824
22b9578d
LMI
8252011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
826
6e70ab07
LMI
827 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
828 are the mini-buffer and the echo area (bug#3320).
829
22b9578d
LMI
830 * term.c (init_tty): Remove support for supdup, c10 and perq
831 terminals, which are no longer supported (bug#1482).
832
8974cc9f
JB
8332011-07-10 Johan Bockgård <bojohan@gnu.org>
834
835 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
836
a560d974
JD
8372011-07-10 Jan Djärv <jan.h.d@swipnet.se>
838
839 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
840 for non-popups (Bug#3642).
841
1dae0f0a
AS
8422011-07-10 Andreas Schwab <schwab@linux-m68k.org>
843
268c2c36 844 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 845 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
846 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
847 * cm.c (losecursor): Likewise.
1dae0f0a
AS
848 * data.c (fmod): Likewise.
849 * dispnew.c (swap_glyphs_in_rows): Likewise.
850 * emacs.c (memory_warning_signal): Likewise.
851 * floatfns.c (float_error): Likewise.
852 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
853 (otf_open, font_otf_capability, generate_otf_features)
854 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
855 Likewise.
856 * image.c (pbm_read_file): Likewise.
857 * indent.c (string_display_width): Likewise.
858 * intervals.c (check_for_interval, search_for_interval)
859 (inc_interval_count, count_intervals, root_interval)
860 (adjust_intervals_for_insertion, make_new_interval): Likewise.
861 * lread.c (defalias): Likewise.
268c2c36 862 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
863 * regex.c (set_image_of_range_1, set_image_of_range)
864 (regex_grow_registers): Likewise.
865 * sysdep.c (strerror): Likewise.
866 * termcap.c (valid_filename_p, tprint, main): Likewise.
867 * tparam.c (main): Likewise.
868 * unexhp9k800.c (run_time_remap, save_data_space)
869 (update_file_ptrs, read_header, write_header, calculate_checksum)
870 (copy_file, copy_rest, display_header): Likewise.
871 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
872 Likewise.
873 * xdisp.c (check_it): Likewise.
874 * xfaces.c (register_color, unregister_color, unregister_colors):
875 Likewise.
876 * xfns.c (print_fontset_result): Likewise.
877 * xrdb.c (member, fatal, main): Likewise.
878
99033785
PE
8792011-07-10 Paul Eggert <eggert@cs.ucla.edu>
880
881 Fix minor problems found by static checking (Bug#9031).
882 * chartab.c (char_table_set_range, map_sub_char_table):
883 Remove unused locals.
884 (uniprop_table): Now static.
885 * composite.c (_work_char): Remove unused static var.
886
9cb2ac56
JB
8872011-07-09 Juanma Barranquero <lekktu@gmail.com>
888
889 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
890
f25661f0
JD
8912011-07-09 Jan Djärv <jan.h.d@swipnet.se>
892
893 * gtkutil.c (qttip_cb): Remove code without function.
894
8278c4fe
EZ
8952011-07-09 Eli Zaretskii <eliz@gnu.org>
896
897 * w32.c (pthread_sigmask): New stub.
898
1692ae2d 8992011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 900
8a6ebd58 901 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
902 sigprocmask is portable only for single-threaded applications, and
903 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
904 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
905 (LIBES): Use it.
906 * callproc.c (Fcall_process):
907 * process.c (create_process):
908 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
909 Use pthread_sigmask, not sigprocmask.
123403e4 910
1b854618
JD
9112011-07-08 Jan Djärv <jan.h.d@swipnet.se>
912
913 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
914 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
915 wrong (Bug#8591).
916
3fe4b549
JD
9172011-07-08 Jan Djärv <jan.h.d@swipnet.se>
918
0ce7e563
JD
919 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
920 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
921 (xg_hide_tooltip): Fix comment.
922
3fe4b549
JD
923 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
924 in registerServicesMenuSendTypes.
925 (validRequestorForSendType): Don't check ns_return_types.
926
927 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
928 ns_return_type.
929
5df75e47
JR
9302011-07-08 Jason Rumney <jasonr@gnu.org>
931
932 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
933 frame struct members of non-existent frames (Bug#6284).
934
699c10bd
JD
9352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
936
4393663b
JD
937 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
938 variable firstTime not needed on OSX >= 10.6.
939 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
940 >= 10.5. Use setKnobProportion, setDoubleValue.
941
942 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
943 (MAC_OS_X_VERSION_10_5): Define if not defined.
944 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
945 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
946 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
947
948 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
949 cString and lossyCString on OSX >= 10.4
950
951 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
952 sizeToFit on OSX >= 10.2.
953
954 * nsimage.m (allocInitFromFile): Don't use deprecated method
955 bestRepresentationForDevice on OSX >= 10.6.
956
957 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
958 to avoid warning.
959
960 * emacs.c: Declare unexec_init_emacs_zone.
961
a63e0781
JD
962 * nsgui.h: Fix compiler warning about gnulib redefining verify.
963
699c10bd
JD
964 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
965
966 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
967 on svcsMenu (Bug#8842).
968
969 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
970 ns_return_types.
971 (Fns_list_services): Just return Qnil on 10.6, code not working there.
972
973 * nsterm.m (QUTF8_STRING): Declare.
974 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
975 (validRequestorForSendType): Return type is (id).
976 Change indexOfObjectIdenticalTo to indexOfObject.
977 Check if we have local selection before returning self (Bug#8842).
978 (writeSelectionToPasteboard): Put local selection into paste board
979 if we have a local selection (Bug#8842).
980 (syms_of_nsterm): DEFSYM QUTF8_STRING.
981
982 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
983 (ns_get_local_selection): Declare.
984
54e10184
LMI
9852011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
986
9888ff71
LMI
987 * keymap.c (describe_map_tree): Don't insert a double newline at
988 the end of the buffer (bug#1169) and return whether we inserted
989 something.
990
54e10184
LMI
991 * callint.c (Fcall_interactively): Change "reading args" to
992 "providing args" to try to clarify what it does (bug#1010).
993
15fa4783
KH
9942011-07-07 Kenichi Handa <handa@m17n.org>
995
996 * composite.c (composition_compute_stop_pos): Ignore a static
997 composition starting before CHARPOS (Bug#8915).
998
999 * xdisp.c (handle_composition_prop): Likewise.
1000
a8815b00
EZ
10012011-07-07 Eli Zaretskii <eliz@gnu.org>
1002
1003 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1004 (Bug#9015)
1005
ef7b981d 10062011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1007
1008 * character.h (unicode_category_t): New enum type.
1009
1010 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1011 (Qchar_code_property_table): New variable.
1012 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1013 (UNIPROP_COMPRESSED_FORM_P): New macros.
1014 (char_table_ascii): Uncompress the compressed values.
1015 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1016 Uncompress the compressed values.
ac389d0c 1017 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1018 (char_table_ref_and_range): Uncompress the compressed values.
1019 (sub_char_table_set): New arg is_uniprop. Callers changed.
1020 Uncompress the compressed values.
1021 (sub_char_table_set_range): Args changed. Callers changed.
1022 (char_table_set_range): Adjuted for the above change.
1023 (map_sub_char_table): Delete args default_val and parent. Add arg
1024 top. Give decoded values to a Lisp function.
640c8776 1025 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1026 values to a Lisp function. Gcpro more variables.
1027 (uniprop_table_uncompress)
1028 (uniprop_decode_value_run_length): New functions.
1029 (uniprop_decoder, uniprop_decoder_count): New variables.
1030 (uniprop_get_decoder, uniprop_encode_value_character)
1031 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1032 New functions.
1033 (uniprop_encoder, uniprop_encoder_count): New variables.
1034 (uniprop_get_encoder, uniprop_table)
1035 (Funicode_property_table_internal, Fget_unicode_property_internal)
1036 (Fput_unicode_property_internal): New functions.
1037 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1038 Sunicode_property_table_internal, Sget_unicode_property_internal,
1039 and Sput_unicode_property_internal. Defvar_lisp
1040 char-code-property-alist.
1041
640c8776 1042 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1043 Vunicode_category_table.
1044
640c8776 1045 * font.c (font_range): Adjust for the change of
c805dec0
KH
1046 Vunicode_category_table.
1047
76b397fb
DN
10482011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1049
1050 * m/iris4d.h: Remove file, move contents ...
1051 * s/irix6-5.h: ... here.
1052
22b4128e
PE
10532011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1054
1055 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1056 * alloc.c (mark_buffer):
1057 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1058 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1059 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1060 This isn't true in general, and it's particularly not true
1061 if Emacs is configured with --with-wide-int.
1062 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1063 New macros, used in the buffer.c change.
1064
869795d6
JD
10652011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1066
1067 * xsettings.c: Use both GConf and GSettings if both are available.
1068 (store_config_changed_event): Add comment.
1069 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1070 (store_tool_bar_style_changed): New functions.
1071 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1072 (struct xsettings): Move font inside HAVE_XFT.
1073 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1074 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1075 Move inside HAVE_XFT.
640c8776 1076 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1077 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1078 also.
1079 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1080 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1081 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1082 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1083 (parse_settings): Move check for font inside HAVE_XFT.
1084 (read_settings, apply_xft_settings): Add comment.
1085 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1086 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1087 call store_font_name_changed.
1088 (xft_settings_event): Add comment.
1089 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1090 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1091 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1092 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1093 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1094 (xsettings_get_system_font, xsettings_get_system_normal_font):
1095 Add comment.
869795d6 1096
d8ed26bd
PE
10972011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1098
1099 Random fixes. E.g., (random) never returned negative values.
1100 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1101 subseconds part to the entropy, as that's a bit more random.
1102 Prefer signed to unsigned, since the signedness doesn't matter and
1103 in general we prefer signed. When given a limit, use a
1104 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1105 latter isn't right if USE_2_TAGS_FOR_INTS.
1106 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1107 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1108
cabf1cac
SM
11092011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1110
1111 * textprop.c (text_property_stickiness):
1112 Obey Vtext_property_default_nonsticky.
1113 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1114 * w32fns.c (syms_of_w32fns):
1115 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1116
6e9b2be9
PE
11172011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1118
1119 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1120 This is more efficient than Ffile_directory_p and avoids a minor race.
1121
90186c68
LMI
11222011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1123
7c301272
LMI
1124 * buffer.c (Foverlay_put): Say what the return value is
1125 (bug#7835).
1126
c4f2d8d4
LMI
1127 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1128 is a directory before asking whether to use the file name
1129 (bug#7564).
ad637907
LMI
1130 (barf_or_query_if_file_exists): Make the "File is a directory"
1131 error be more correct.
c4f2d8d4 1132
90186c68
LMI
1133 * fns.c (Frequire): Remove the mention of the .gz files, since
1134 that's installation-specific, but keep the mention of
1135 `get-load-suffixes'.
1136
da64016e
PE
11372011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1140 Report string overflow if the output is too long.
1141
7d47b580
JB
11422011-07-04 Juanma Barranquero <lekktu@gmail.com>
1143
a555cb87
JB
1144 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1145 (syms_of_gnutls): Remove duplicate DEFSYM for
1146 Qgnutls_bootprop_verify_hostname_error, an error for
1147 Qgnutls_bootprop_verify_error (which is no longer used).
1148
7d47b580
JB
1149 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1150 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1151 Also (re)move comments that are misplaced or no longer relevant.
1152
1e49bfab
LMI
11532011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1154
1155 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1156
1485f4c0
CY
11572011-07-03 Chong Yidong <cyd@stupidchicken.com>
1158
1159 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1160 and background color parameters if they have been changed.
1161
a9ab721e
LMI
11622011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1163
1164 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1165
cf7cff57
PE
11662011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1167
2e13213d
PE
1168 * xsettings.c (SYSTEM_FONT): Define only when used.
1169 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1170
cf7cff57
PE
1171 * keymap.c (access_keymap_1): Now static.
1172
7a8e04f7
CY
11732011-07-02 Chong Yidong <cyd@stupidchicken.com>
1174
1175 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1176 leave any prefix arg for the up event (Bug#1586).
1177
61352f62
LMI
11782011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1179
69bb1ef7
LMI
1180 * lread.c (syms_of_lread): Mention single symbols defined by
1181 `defvar' or `defconst' (bug#7154).
1182
61352f62 1183 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1184 (Frequire): Mention get-load-suffixes.
61352f62 1185
28545e04
MR
11862011-07-02 Martin Rudalics <rudalics@gmx.at>
1187
1188 * window.h (window): Remove clone_number slot.
1189 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1190 Remove.
1191 (make_parent_window, make_window, saved_window)
1192 (Fset_window_configuration, save_window_save): Don't deal with
1193 clone numbers.
1194 * buffer.c (Qclone_number): Remove declaration.
1195 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1196
3349e122
SM
11972011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1198
1199 Add multiple inheritance to keymaps.
1200 * keymap.c (Fmake_composed_keymap): New function.
1201 (Fset_keymap_parent): Simplify.
1202 (fix_submap_inheritance): Remove.
1203 (access_keymap_1): New function extracted from access_keymap to handle
1204 embedded parents and handle lists of maps.
1205 (access_keymap): Use it.
1206 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1207 (Fcopy_keymap): Handle embedded parents.
1208 (Fcommand_remapping, define_as_prefix): Simplify.
1209 (Fkey_binding): Simplify.
1210 (syms_of_keymap): Move minibuffer-local-completion-map,
1211 minibuffer-local-filename-completion-map,
1212 minibuffer-local-must-match-map, and
1213 minibuffer-local-filename-must-match-map to Elisp.
1214 (syms_of_keymap): Defsubr make-composed-keymap.
1215 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1216 (parse_menu_item): Trivial simplification.
1217
3279eb87
GM
12182011-07-01 Glenn Morris <rgm@gnu.org>
1219
1220 * Makefile.in (SETTINGS_LIBS): Fix typo.
1221
4550efdf
KI
12222011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1223
1224 * coding.c (Fencode_coding_string): Record the last coding system
1225 used, as the function doc string says (bug#8738).
1226
0949d2b6
JD
12272011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1228
1229 * xsettings.c (store_monospaced_changed): Take new font as arg and
1230 check for change against current_mono_font.
1231 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1232 (emacs_settings_constructor, emacs_settings_get_property)
1233 (emacs_settings_set_property, emacs_settings_class_init)
1234 (emacs_settings_init, gsettings_obj): Remove.
1235 (something_changedCB): New function for HAVE_GSETTINGS.
1236 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1237 with value as argument.
1238 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1239 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1240 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1241 "changed".
1242
1243 * xgselect.c: Add defined (HAVE_GSETTINGS).
1244 (xgselect_initialize): Ditto.
1245
1246 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1247 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1248 xg_select.
1249
bbc6b304
PE
12502011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1251
1252 * eval.c (struct backtrace): Simplify and port the data structure.
1253 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1254 signed bit field, as this assumption is not portable and it makes
1255 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1256 "char debug_on_exit : 1" as this is not portable either; instead,
1257 use the portable "unsigned int debug_on_exit : 1". Remove unused
1258 member evalargs. Remove obsolete comments about cc bombing out.
1259
9851bfc5
JD
12602011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1261
51bb811f 1262 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1263 Let HAVE_GSETTINGS override HAVE_GCONF.
1264 (store_monospaced_changed): New function.
1265 (EMACS_SETTINGS): A new type derived from GObject to handle
1266 GSettings notifications.
1267 (emacs_settings_constructor, emacs_settings_get_property)
1268 (emacs_settings_set_property, emacs_settings_class_init):
1269 New functions.
1270 (gsettings_client, gsettings_obj): New variables.
1271 (GSETTINGS_SCHEMA): New define.
1272 (something_changedCB): Call store_monospaced_changed.
1273 (init_gsettings): New function.
1274 (xsettings_initialize): Call init_gsettings.
1275 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1276 to NULL.
1277
640c8776 1278 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1279 GCONF_CFLAGS/LIBS.
1280
5386012d
MR
12812011-06-29 Martin Rudalics <rudalics@gmx.at>
1282
1283 * window.c (resize_root_window, grow_mini_window)
1284 (shrink_mini_window): Rename Qresize_root_window to
1285 Qwindow_resize_root_window and Qresize_root_window_vertically to
1286 Qwindow_resize_root_window_vertically.
1287
f13e0b08
PE
12882011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1289
1290 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1291
94515237
JB
12922011-06-27 Juanma Barranquero <lekktu@gmail.com>
1293
1294 * makefile.w32-in: Redesign dependencies so they reflect more
1295 clearly which files are directly included by each source file,
1296 and not through other includes.
1297
e43b6e43
MR
12982011-06-27 Martin Rudalics <rudalics@gmx.at>
1299
1300 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1301 (sort_overlays, overlay_strings): When an overlay's clone number
1302 matches the window's clone number process the overlay even if
1303 the overlay's window property doesn't match the current window.
1304
d68443dc
MR
1305 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1306 (Fwindow_hchild): Rename to Fwindow_left_child.
1307 (Fwindow_next): Rename to Fwindow_next_sibling.
1308 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1309 (resize_window_check): Rename to window_resize_check.
1310 (resize_window_apply): Rename to window_resize_apply.
1311 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1312 (Fdelete_other_windows_internal, resize_frame_windows)
1313 (Fsplit_window_internal, Fdelete_window_internal)
1314 (grow_mini_window, shrink_mini_window)
1315 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1316
c7e73be5
JD
13172011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1318
1319 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1320 (emacs_fixed_set_min_size): Remove.
1321 (emacs_fixed_new): Take frame as argument.
1322
1323 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1324 (_EmacsFixedPrivate): Remove minwidth/height.
1325 Add struct frame *f.
1326 (emacs_fixed_init): Initialize priv->f.
1327 (get_parent_class, emacs_fixed_set_min_size): Remove.
1328 (emacs_fixed_new): Set priv->f to argument.
1329 (emacs_fixed_get_preferred_width)
1330 (emacs_fixed_get_preferred_height): Use min_width/height from
1331 frames size_hint to set minimum and natural (Bug#8919).
1332 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1333 and use min_width/height from frames size_hint to set
1334 min_width/height (Bug#8919).
1335
1336 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1337 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1338 Fix indentation.
c7e73be5 1339
cf99dcf8
EZ
13402011-06-26 Eli Zaretskii <eliz@gnu.org>
1341
1342 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1343 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1344 called at ZV.
1345
029529ac
CY
13462011-06-26 Chong Yidong <cyd@stupidchicken.com>
1347
1348 * process.c (wait_reading_process_output): Bypass select if
1349 waiting for a cell while ignoring keyboard input, and input is
1350 pending. Suggested by Jan Djärv (Bug#8869).
1351
7a7ef429
PE
13522011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1353
1354 Use gnulib's dup2 module instead of rolling our own.
1355 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1356
11fdef7d 13572011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1358
1359 * dispnew.c (scrolling_window): Before scrolling, turn off a
1360 mouse-highlight in the window being scrolled.
1361
cd3520a4
JB
13622011-06-24 Juanma Barranquero <lekktu@gmail.com>
1363
1364 Move DEFSYM to lisp.h and use everywhere.
1365
1366 * character.h (DEFSYM): Move declaration...
1367 * lisp.h (DEFSYM): ...here.
1368
1369 * gnutls.c:
1370 * minibuf.c:
1371 * w32menu.c:
1372 * w32proc.c:
1373 * w32select.c: Don't include character.h.
1374
1375 * alloc.c (syms_of_alloc):
1376 * buffer.c (syms_of_buffer):
1377 * bytecode.c (syms_of_bytecode):
1378 * callint.c (syms_of_callint):
1379 * casefiddle.c (syms_of_casefiddle):
1380 * casetab.c (init_casetab_once):
1381 * category.c (init_category_once, syms_of_category):
1382 * ccl.c (syms_of_ccl):
1383 * cmds.c (syms_of_cmds):
1384 * composite.c (syms_of_composite):
1385 * dbusbind.c (syms_of_dbusbind):
1386 * dired.c (syms_of_dired):
1387 * dispnew.c (syms_of_display):
1388 * doc.c (syms_of_doc):
1389 * editfns.c (syms_of_editfns):
1390 * emacs.c (syms_of_emacs):
1391 * eval.c (syms_of_eval):
1392 * fileio.c (syms_of_fileio):
1393 * fns.c (syms_of_fns):
1394 * frame.c (syms_of_frame):
1395 * fringe.c (syms_of_fringe):
1396 * insdel.c (syms_of_insdel):
1397 * keymap.c (syms_of_keymap):
1398 * lread.c (init_obarray, syms_of_lread):
1399 * macros.c (syms_of_macros):
1400 * msdos.c (syms_of_msdos):
1401 * print.c (syms_of_print):
1402 * process.c (syms_of_process):
1403 * search.c (syms_of_search):
1404 * sound.c (syms_of_sound):
1405 * syntax.c (init_syntax_once, syms_of_syntax):
1406 * terminal.c (syms_of_terminal):
1407 * textprop.c (syms_of_textprop):
1408 * undo.c (syms_of_undo):
1409 * w32.c (globals_of_w32):
1410 * window.c (syms_of_window):
1411 * xdisp.c (syms_of_xdisp):
1412 * xfaces.c (syms_of_xfaces):
1413 * xfns.c (syms_of_xfns):
1414 * xmenu.c (syms_of_xmenu):
1415 * xsettings.c (syms_of_xsettings):
1416 * xterm.c (syms_of_xterm): Use DEFSYM.
1417
4228cf16
TZ
14182011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1419
cd3520a4 1420 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1421
7fcccf1e
PE
14222011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1423
7efb4e0e
PE
1424 Integer and buffer overflow fixes (Bug#8873).
1425
ff5844ad
PE
1426 * print.c (printchar, strout): Check for string overflow.
1427 (PRINTPREPARE, printchar, strout):
1428 Don't set size unless allocation succeeds.
1429
90532f02
PE
1430 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1431 for sizes. Check for string overflow more accurately.
1432 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1433
6d84508d
PE
1434 * macros.c: Integer and buffer overflow fixes.
1435 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1436 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1437 Use ptrdiff_t, not int, for sizes.
1438 Don't increment bufsize until after realloc succeeds.
1439 Check for size-calculation overflow.
1440 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1441
437b2cb4
PE
1442 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1443
8b9ac8b4
PE
1444 * lread.c: Integer overflow fixes.
1445 (read_integer): Radix is now EMACS_INT, not int,
1446 to improve quality of diagnostics for out-of-range radices.
1447 Calculate buffer size correctly for out-of-range radices.
1448 (read1): Check for integer overflow in radices, and in
1449 read-circle numbers.
82cb60d3
PE
1450 (read_escape): Avoid int overflow.
1451 (Fload, openp, read_buffer_size, read1)
1452 (substitute_object_recurse, read_vector, read_list, map_obarray):
1453 Use ptrdiff_t, not int, for sizes.
1454 (read1): Use EMACS_INT, not int, for sizes.
20270765 1455 Check for size overflow.
8b9ac8b4 1456
7fcccf1e
PE
1457 * image.c (cache_image): Check for size arithmetic overflow.
1458
bfbbd7e7
PE
1459 * lread.c: Integer overflow issues.
1460 (saved_doc_string_size, saved_doc_string_length)
1461 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1462 Now ptrdiff_t, not int.
1463 (read1): Don't assume doc string length fits in int. Check for
1464 out-of-range doc string lengths.
1465 (read_list): Don't assume file position fits in int.
39019e54 1466 (read_escape): Check for hex character overflow.
bfbbd7e7 1467
4e323265
LL
14682011-06-22 Leo Liu <sdl.web@gmail.com>
1469
1470 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1471 Move to minibuffer.el.
1472
85fece3e
PE
14732011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1474
20b84ce9 1475 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1476 The following patches are for when GLYPH_DEBUG && !XASSERT.
1477 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1478 * dispnew.c (flush_stdout):
1479 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1480 Mark as externally visible.
1481 * dispnew.c (check_window_matrix_pointers): Now static.
1482 * dispnew.c (window_to_frame_vpos):
1483 * xfns.c (unwind_create_frame):
1484 * xterm.c (x_check_font): Remove unused local.
1485 * scroll.c (CHECK_BOUNDS):
1486 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1487 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1488 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1489 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1490 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1491 Now static.
1492 (debug_method_add): Use va_list and vsprintf rather than relying
1493 on undefined behavior with wrong number of arguments.
1494 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1495 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1496 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1497 since we're not interested in debugging glyphs with old libraries.
1498 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1499 GCC 4.6.0's static checking.
1500
0766b489
PE
15012011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1502
31fd4b32
PE
1503 Integer overflow and signedness fixes (Bug#8873).
1504 A few related buffer overrun fixes, too.
1505
b79e8648
PE
1506 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1507
0766b489
PE
1508 * dispextern.h (struct face.stipple):
1509 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1510 (x_bitmap_mask, x_allocate_bitmap_record)
1511 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1512 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1513 (x_create_bitmap_from_xpm_data):
1514 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1515 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1516 (.bitmaps_last):
1517 * xfaces.c (load_pixmap):
1518 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1519 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1520 (.bitmaps_last, struct x_output.icon_bitmap):
1521 Use ptrdiff_t, not int, for bitmap indexes.
1522 (x_allocate_bitmap_record): Check for size overflow.
1523 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1524
b081724f
PE
1525 Use ptrdiff_t, not int, for overlay counts.
1526 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1527 * editfns.c (overlays_around, get_pos_property):
1528 * textprop.c (get_char_property_and_overlay):
1529 * xdisp.c (next_overlay_change, note_mouse_highlight):
1530 * xfaces.c (face_at_buffer_position):
21514da7
PE
1531 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1532 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1533 (Fnext_overlay_change, Fprevious_overlay_change)
1534 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1535 Use ptrdiff_t, not int, for sizes.
21514da7 1536 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1537
3de73e5e
PE
1538 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1539
2606c57b
PE
1540 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1541 (x_session_initialize): Do not assume string length fits in int.
1542
aaafe47a
PE
1543 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1544 This is unlikely, but can occur if DPI is outlandish.
1545
2674ddc8 1546 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1547 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1548
28154962
PE
1549 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1550 * xrdb.c (magic_file_p, search_magic_path):
1551 Omit last arg SUFFIX; it was always 0. All callers changed.
1552 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1553
7de51af5
PE
1554 * xfont.c (xfont_match): Avoid need for strlen.
1555
25ed6cc3
PE
1556 * xfns.c: Don't assume strlen fits in int.
1557 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1558
4eab31dd
PE
1559 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1560 not unsigned long, as we prefer signed integers. All callers changed.
1561 Detect integer overflow in repeat count.
1562 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1563 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1564
171e2a58
PE
1565 * termcap.c: Don't assume sizes fit in int and never overflow.
1566 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1567 (gobble_line): Check for size-calculation overflow.
1568
ad39faca 1569 * minibuf.c (Fread_buffer):
6e5bb2dc 1570 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1571 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1572 Don't assume string length fits in int.
1573
52c61c22 1574 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1575 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1576
b5b8c9e5
PE
1577 * font.c: Don't assume string length fits in int.
1578 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1579 Use ptrdiff_t, not int.
ccd6111c
PE
1580 (font_intern_prop): Don't assume string length fits in int.
1581 Don't assume integer property fits in fixnum.
1582 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1583
882f0d81 1584 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1585 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1586 Reformulate so as not to need the command string.
1587 Invoke gzip -cd rather than gunzip, as it's more portable.
1588 (lock_info_type, lock_file_1, lock_file):
1589 Don't assume pid_t and time_t fit in unsigned long.
1590 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1591 (current_lock_owner): Prefer signed type for sizes.
1592 Use memcpy, not strncpy, where memcpy is what is really wanted.
1593 Don't assume (via atoi) that time_t and pid_t fit in int.
1594 Check for time_t and/or pid_t out of range, e.g., via a network share.
1595 Don't alloca where an auto var works fine.
1596
93f4cf88
PE
1597 * fileio.c: Fix some integer overflow issues.
1598 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1599 Don't assume string length fits in int.
1600 (directory_file_name): Don't assume string length fits in long.
1601 (make_temp_name): Don't assume pid fits in int, or that its print
1602 length is less than 20.
1603
f3e92b69
PE
1604 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1605
1bfdaf10
PE
1606 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1607
35016e9a
PE
1608 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1609
3d1e65a1
PE
1610 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1611 We prefer signed integers, even for size calculations.
1612
0b963a93
PE
1613 * emacs.c: Don't assume string length fits in 'int'.
1614 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1615 (main): Don't invoke strlen when not needed.
1616
573f4b54
PE
1617 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1618 (XD_DEBUG_MESSAGE): Don't waste a byte.
1619
989f33ba
PE
1620 * callproc.c (getenv_internal_1, getenv_internal)
1621 (Fgetenv_internal):
965d34eb
PE
1622 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1623
e4d29b33
PE
1624 * lread.c (invalid_syntax): Omit length argument.
1625 All uses changed. This doesn't fix a bug, but it simplifies the
1626 code away from its former Hollerith-constant appearance, and it's
1627 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1628 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1629
eb49b136
PE
1630 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1631 This didn't break anything, but it didn't help either.
1632 It's confusing to put a bogus integer in a place where the actual
1633 value does not matter.
9f62aeb1 1634 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1635 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1636
15375a22
PE
1637 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1638 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1639 implementation.
b61cc01c
PE
1640 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1641 We prefer signed types, and the value cannot exceed the EMACS_INT
1642 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1643 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1644 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1645 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1646
53b2623d
PE
1647 * indent.c (sane_tab_width): New function.
1648 (current_column, scan_for_column, Findent_to, position_indentation)
1649 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1650 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1651
51cab52b 1652 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1653
f2ed8a70
PE
1654 * lisp.h (lint_assume): New macro.
1655 * composite.c (composition_gstring_put_cache):
1656 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1657
abe80cc6
PE
1658 * editfns.c, insdel.c:
1659 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1660
b02c740e
PE
1661 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1662
ebc96716
PE
1663 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1664
b4e50fa0 1665 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1666 Use much-faster test for byte-length change.
311d5d7c 1667 Don't assume string byte-length fits in 'int'.
a4cf38e4 1668 Check that character arg fits in 'int'.
85461888 1669 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1670
c0c1ee9f
PE
1671 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1672
a498d7f4
PE
1673 * fns.c (concat): Catch string overflow earlier.
1674 Do not rely on integer wraparound.
1675
51cab52b
PE
1676 * dispextern.h (struct it.overlay_strings_charpos)
1677 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1678 * xdisp.c (forward_to_next_line_start)
1679 (back_to_previous_visible_line_start)
1680 (reseat_at_next_visible_line_start, next_element_from_buffer):
1681 Don't arbitrarily truncate the value of 'selective' to int.
1682
76031fad
PE
1683 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1684
5eb55db9
PE
1685 * composite.c: Don't truncate sizes to 'int'.
1686 (composition_gstring_p, composition_reseat_it)
1687 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1688 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1689 not EMACS_UINT, for indexes.
5eb55db9 1690
0703a717
PE
1691 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1692
d6202519
PE
1693 * buffer.c: Include <verify.h>.
1694 (struct sortvec.priority, struct sortstr.priority):
8961a454 1695 Now EMACS_INT, not int.
c20998a7 1696 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1697 (struct sortstr.size, record_overlay_string)
1698 (struct sortstrlist.size, struct sortlist.used):
1699 Don't truncate size to int.
1700 (record_overlay_string): Check for size-calculation overflow.
d6202519 1701 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1702
d5a19415
JM
17032011-06-22 Jim Meyering <meyering@redhat.com>
1704
029529ac 1705 Don't leak an XBM-image-sized buffer
d5a19415
JM
1706 * image.c (xbm_load): Free the image buffer after using it.
1707
a9041e6c
PE
17082011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1709
1710 Port to Sun C.
1711 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1712 that Sun C diagnosed.
1713 * fns.c (secure_hash): Fix pointer signedness issue.
1714 * intervals.c (static_offset_intervals): New function.
1715 (offset_intervals): Use it.
1716
7f3f739f
LL
17172011-06-21 Leo Liu <sdl.web@gmail.com>
1718
1719 * deps.mk (fns.o):
1720 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1721 sha512.h.
1722
1723 * fns.c (secure_hash): Rename from crypto_hash_function and change
1724 the first arg to accept symbols.
5b66d427 1725 (Fsecure_hash): New primitive.
7f3f739f
LL
1726 (syms_of_fns): New symbols.
1727
76147d94
DD
17282011-06-20 Deniz Dogan <deniz@dogan.se>
1729
1730 * process.c (Fset_process_buffer): Clarify return value in
1731 docstring.
1732
7d7d0045
CY
17332011-06-18 Chong Yidong <cyd@stupidchicken.com>
1734
1735 * dispnew.c (add_window_display_history): Use BVAR.
1736
1737 * xdisp.c (debug_method_add): Use BVAR.
1738 (check_window_end, dump_glyph_matrix, dump_glyph)
1739 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1740
1741 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1742 Likewise.
1743
1744 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1745 check till after the cache is created in init_frame_faces.
1746
ff2bc410
SM
17472011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1748
1749 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1750
28177add
PE
17512011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1752
dd3482fe
PE
1753 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1754 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1755 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1756
393d71f3 1757 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1758 * fileio.c (Finsert_file_contents):
1759 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1760 Remove the old (too-loose) buffer overflow checks.
1761 They weren't needed, since make_gap checks for buffer overflow.
1762 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1763 The old code merely checked for Emacs fixnum overflow, and relied
1764 on undefined (wraparound) behavior. The new code avoids undefined
1765 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1766
2e6813b0 1767 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1768 Tune. Don't use wider integers than needed. Don't use alloca.
1769 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1770
599a9e4f
PE
1771 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1772
99561444
PE
1773 * insdel.c, lisp.h (buffer_overflow): New function.
1774 (insert_from_buffer_1, replace_range, replace_range_2):
1775 * insdel.c (make_gap_larger):
1776 * editfns.c (Finsert_char):
1777 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1778
28177add
PE
1779 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1780
e69dafad
PE
17812011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1782
a7af7fde 1783 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1784
b1c46f02
PE
1785 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1786 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1787
e69dafad
PE
1788 * fileio.c: Don't assume EMACS_INT fits in off_t.
1789 (emacs_lseek): New static function.
1790 (Finsert_file_contents, Fwrite_region): Use it.
1791 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1792
566684ea
PE
1793 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1794
e6966cd6
PE
1795 * fns.c: Don't overflow int when computing a list length.
1796 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1797 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1798 truncation on 64-bit hosts. Check for QUIT every
1799 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1800 faster and is responsive enough.
1801 (Flength): Report an error instead of overflowing an integer.
1802 (Fsafe_length): Return a float if the value is not representable
1803 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1804 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1805 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1806
dd0b0efb
PE
1807 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1808 (header_size, word_size): New constants.
1809 (allocate_vectorlike): Don't check size overflow here.
1810 (allocate_vector): Check it here instead, since this is the only
1811 caller of allocate_vectorlike that could cause overflow.
1812 Check that the new vector's length is representable as a fixnum.
1813
86fe5cfe
PE
1814 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1815 The previous code was bogus. For example, next_almost_prime (32)
1816 returned 39, which is undesirable as it is a multiple of 3; and
1817 next_almost_prime (24) returned 25, which is a multiple of 5 so
1818 why was the code bothering to check for multiples of 7?
1819
80e88859
PE
1820 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1821
4a2f0ad6
PE
1822 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1823
f66c7cf8
PE
1824 Variadic C functions now count arguments with ptrdiff_t.
1825 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1826 Back then I didn't know that the Emacs coding style prefers signed int.
1827 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1828 were being counted with int, which may truncate counts on 64-bit
1829 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1830 * lisp.h (struct Lisp_Subr.function.aMANY)
1831 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1832 Arg counts are now ptrdiff_t, not size_t.
1833 All variadic functions and their callers changed accordingly.
1834 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1835 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1836 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1837 * callint.c (Fcall_interactively): Check arg count for overflow,
1838 to avoid potential buffer overrun. Use signed char, not 'int',
1839 for 'varies' array, so that we needn't bother to check its size
1840 calculation for overflow.
1841 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1842 * eval.c (apply_lambda):
1843 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1844 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1845 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1846
a1759b76
PE
1847 * callint.c (Fcall_interactively): Don't use index var as event count.
1848
d96be9fc
PE
1849 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1850 * mem-limits.h (SIZE): Remove; no longer used.
1851
a690a978 1852 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1853
578c21e6
PE
1854 Remove unnecessary casts.
1855 * xterm.c (x_term_init):
1856 * xfns.c (x_set_border_pixel):
1857 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1858 These aren't needed now that we assume ANSI C.
1859
96f53c6c
PE
1860 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1861 It's more likely to cause problems (due to unsigned overflow)
1862 than to cure them.
1863
83c77d31
PE
1864 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1865
ee2079f1
PE
1866 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1867
6da65536
PE
1868 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1869
7147c4a4
PE
1870 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1871
193e32d9
PE
1872 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1873
e5533da6
PE
1874 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1875
9910e595
PE
1876 GLYPH_CODE_FACE returns EMACS_INT, not int.
1877 * dispextern.h (merge_faces):
1878 * xfaces.c (merge_faces):
01103c44
PE
1879 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1880 Don't assume EMACS_INT fits in int.
9910e595 1881
2638320e
PE
1882 * character.h (CHAR_VALID_P): Remove unused parameter.
1883 * fontset.c, lisp.h, xdisp.c: All uses changed.
1884
045eb8d9
PE
1885 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1886
c1f134b5
PE
1887 * fns.c (concat): Minor tuning based on overflow analysis.
1888 This doesn't fix any bugs. Use int to hold character, instead
1889 of constantly refetching from Emacs object. Use XFASTINT, not
1890 XINT, for value known to be a character. Don't bother comparing
1891 a single byte to 0400, as it's always less.
1892
395fcb93 1893 * floatfns.c (Fexpt):
327eeec8
PE
1894 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1895
abbd3d23
PE
1896 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1897 for characters.
1898
684a03ef
PE
1899 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1900
0fed43f3
PE
1901 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1902 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1903 incorrectly succeed when S was a string, because 4294967386 was
1904 truncated before it was used.
1905
8fd02eb7
PE
1906 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1907 Otherwise, an out-of-range integer could cause undefined behavior
1908 on a 64-bit host.
1909
f8c86b69
PE
1910 * composite.c: Use int, not EMACS_INT, for characters.
1911 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1912 EMACS_INT, for values that are known to be in character range.
1913 This doesn't fix any bugs but is the usual style inside Emacs and
1914 may generate better code on 32-bit machines.
1915
34206dd2
PE
1916 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1917 This is for reasons similar to the recent CHAR_STRING fix.
1918 * charset.c (Fencode_char): Check that character arg is actually
1919 a character. Pass an int to ENCODE_CHAR.
1920 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1921 wider than 'int', as a compile-time check to prevent future regressions
1922 in this area.
1923
c5958d4c 1924 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1925
1926 Make sure a 64-bit char is never passed to CHAR_STRING.
1927 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1928 by silently ignoring the top 32 bits, allowing some values
1929 that were far too large to be valid characters.
1930 * character.h: Include <verify.h>.
1931 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1932 arguments are no wider than unsigned, as a compile-time check
1933 to prevent future regressions in this area.
1934 * data.c (Faset):
01103c44 1935 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1936 (Fsubst_char_in_region):
1937 * fns.c (concat):
1938 * xdisp.c (decode_mode_spec_coding):
1939 Adjust to CHAR_STRING's new requirement.
1940 * editfns.c (Finsert_char, Fsubst_char_in_region):
1941 * fns.c (concat): Check that character args are actually
1942 characters. Without this test, these functions did the wrong
1943 thing with wildly out-of-range values on 64-bit hosts.
1944
d37ca623
PE
1945 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1946 These casts should not be needed on 32-bit hosts, either.
1947 * keyboard.c (read_char):
1948 * lread.c (Fload): Remove casts to unsigned.
1949
ea204efb
PE
1950 * lisp.h (UNSIGNED_CMP): New macro.
1951 This fixes comparison bugs on 64-bit hosts.
1952 (ASCII_CHAR_P): Use it.
1953 * casefiddle.c (casify_object):
01103c44 1954 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1955 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1956 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1957 * dispextern.h (FACE_FROM_ID):
1958 * keyboard.c (read_char): Use UNSIGNED_CMP.
1959
41cb286c
PE
1960 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1961 not to EMACS_INT, to avoid GCC warning.
1962
4a1b9832
PE
1963 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1964
55daad71
PE
1965 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1966 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1967 isn't needed on 32-bit machines.
8f95c75c 1968
01103c44
PE
1969 * buffer.c (Fgenerate_new_buffer_name):
1970 Use EMACS_INT for count, not int.
0ceccced 1971 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1972
1973 * data.c (Qcompiled_function): Now static.
1974
c6f072e7
PE
1975 * window.c (window_body_lines): Now static.
1976
20ce5912
PE
1977 * image.c (gif_load): Rename local to avoid shadowing.
1978
9c4c5f81
PE
1979 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1980 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1981 * alloc.c (make_save_value): Integer argument is now of type
1982 ptrdiff_t, not int.
1983 (mark_object): Use ptrdiff_t, not int.
1984 * lisp.h (pD): New macro.
1985 * print.c (print_object): Use it.
1986
c0c5c8ae
PE
1987 * alloc.c: Use EMACS_INT, not int, to count objects.
1988 (total_conses, total_markers, total_symbols, total_vector_size)
1989 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1990 (total_free_floats, total_floats, total_free_intervals)
1991 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1992 Now EMACS_INT, not int. All uses changed.
1993 (Fgarbage_collect): Compute overall total using a double, so that
1994 integer overflow is less likely to be a problem. Check for overflow
1995 when converting back to an integer.
5a25e253
PE
1996 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1997 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1998 These were 'int' variables that could overflow on 64-bit hosts;
1999 they were never used, so remove them instead of repairing them.
211a0b2a 2000 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2001 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2002 Previously, this ceilinged at INT_MAX, but that doesn't work on
2003 64-bit machines.
e46bb31a 2004 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2005
c78baabf 2006 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2007 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2008 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2009 when a (possibly-narrower) signed value would do just as well.
2010 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2011
c9d624c6
PE
2012 * alloc.c: Catch some string size overflows that we were missing.
2013 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2014 for convenience in STRING_BYTES_MAX.
2015 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2016 The definition here is exact; the one in lisp.h was approximate.
2017 (allocate_string_data): Check for string overflow. This catches
2018 some instances we weren't catching before. Also, it catches
2019 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2020 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2021 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2022
c9d624c6
PE
2023 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2024 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2025 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2026
353032ce
PE
2027 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2028
2bccce07
PE
2029 * alloc.c (Fmake_string): Check for out-of-range init.
2030
0ac30604
SM
20312011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2032
2033 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2034
c195f2de
JD
20352011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2036
2037 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2038 xg_get_default_scrollbar_width.
2039
2040 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2041 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2042 (style_changed_cb): Call update_theme_scrollbar_width and call
2043 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2044 all frames (Bug#8505).
2045 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2046 Call gtk_window_set_resizable if HAVE_GTK3.
2047 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2048 and height if HAVE_GTK3 (Bug#8505).
2049 (scroll_bar_width_for_theme): New variable.
2050 (update_theme_scrollbar_width): New function.
2051 (xg_get_default_scrollbar_width): Move code to
2052 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2053 (xg_initialize): Call update_theme_scrollbar_width.
2054
2055 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2056
2057 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2058
e10ac9f1
MR
20592011-06-12 Martin Rudalics <rudalics@gmx.at>
2060
2061 * frame.c (make_frame): Call other_buffer_safely instead of
2062 other_buffer.
2063
2064 * window.c (temp_output_buffer_show): Call display_buffer with
2065 second argument Vtemp_buffer_show_specifiers and reset latter
2066 immediately after the call.
2067 (Vtemp_buffer_show_specifiers): New variable.
2068 (auto_window_vscroll_p, next_screen_context_lines)
2069 (Vscroll_preserve_screen_position): Remove leading asterisks from
2070 doc-strings.
2071
2d3c217e 20722011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2073
7b7f97e8 2074 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2075 * buffer.c (Qclone_number): Remove for now, as it's unused.
2076 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2077 (record_buffer): Remove unused local.
2078 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2079 (set_frame_buffer_list): Remove; unused.
2080 * frame.h (other_visible_frames): Remove decl.
2081 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2082 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2083 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2084 if HAVE_GPM.
2085 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2086 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2087 Define only if HAVE_GPM.
2088 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2089 (update_hints_inhibit): Remove; never set. All uses removed.
2090 * widgetprv.h (emacsFrameClassRec): Remove decl.
2091 * window.c (delete_deletable_window): Now returns void, since it
2092 wasn't returning anything.
2093 (compare_window_configurations): Remove unused locals.
2094 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2095 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2096 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2097 the same widths as pointers. This follows up on the 2011-05-06 patch.
2098 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2099 * xterm.h: Likewise.
2100 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2101
1384b89e
JB
21022011-06-12 Juanma Barranquero <lekktu@gmail.com>
2103
2104 * makefile.w32-in: Update dependencies.
2105 (LISP_H): Add lib/intprops.h.
2106
1100a63c
CY
21072011-06-11 Chong Yidong <cyd@stupidchicken.com>
2108
2109 * image.c (gif_load): Add animation frame delay to the metadata.
2110 (syms_of_image): Use DEFSYM. New symbol `delay'.
2111
6198ccd0
MR
21122011-06-11 Martin Rudalics <rudalics@gmx.at>
2113
2114 * window.c (delete_deletable_window): Re-add.
2115 (Fset_window_configuration): Rewrite to handle dead buffers and
2116 consequently deletable windows.
2117 (window_tree, Fwindow_tree): Remove. Supply functionality in
2118 window.el.
2119 (compare_window_configurations): Simplify code.
2120
b6e3633c
AS
21212011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2122
1ab0dee5
AS
2123 * image.c (imagemagick_load_image): Fix type mismatch.
2124 (Fimagemagick_types): Likewise.
2125
b6e3633c
AS
2126 * window.h (replace_buffer_in_windows): Declare.
2127
9397e56f
MR
21282011-06-11 Martin Rudalics <rudalics@gmx.at>
2129
2130 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2131 Qclone_number. Remove external declaration of Qdelete_window.
2132 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2133 code.
640c8776
SM
2134 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2135 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2136 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2137 buffer list implementation.
2138 (other_buffer_safely): New function.
2139 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2140 calls to replace_buffer_in_windows and
2141 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2142 if allowed.
2143 (record_buffer): Inhibit quitting and rewrite using quittable
2144 functions. Run Qbuffer_list_update_hook if allowed.
2145 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2146 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2147 Move switch-to-buffer to window.el.
9397e56f
MR
2148 (bury-buffer): Move to window.el.
2149 (Vbuffer_list_update_hook): New variable.
2150
2151 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2152 section.
2153
2154 * window.h (resize_frame_windows): Move up in code.
2155 (Fwindow_frame): Remove EXFUN.
2156 (replace_buffer_in_all_windows): Remove prototype.
2157 (replace_buffer_in_windows_safely): Add prototype.
2158
2159 * window.c: Declare Qdelete_window static again. Move down
2160 declaration of select_count.
2161 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2162 (Fother_window): Move to window.el.
2163 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2164 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2165 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2166 window.el.
2167 (replace_buffer_in_windows): Implement by calling
2168 Qreplace_buffer_in_windows.
2169 (replace_buffer_in_all_windows): Remove with some functionality
2170 moved into replace_buffer_in_windows_safely.
2171 (replace_buffer_in_windows_safely): New function.
2172 (select_window_norecord, select_frame_norecord): Move in front
2173 of run_window_configuration_change_hook. Remove now obsolete
2174 declarations.
640c8776
SM
2175 (Fset_window_buffer): Rewrite doc-string.
2176 Call Qrecord_window_buffer.
9397e56f
MR
2177 (keys_of_window): Move binding for other-window to window.el.
2178
b50691aa
CY
21792011-06-11 Chong Yidong <cyd@stupidchicken.com>
2180
2181 * dispextern.h (struct image): Replace data member, whose int_val
2182 and ptr_val fields were not used by anything, with a single
2183 lisp_val object.
2184
2185 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2186 (gif_clear_image, gif_load, imagemagick_load_image)
2187 (gs_clear_image, gs_load): Callers changed.
2188
3f754b86
PE
21892011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2190
cca69397
PE
2191 * buffer.h: Include <time.h>, for time_t.
2192 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2193
109e28d0
PE
2194 Fix minor problems found by static checking.
2195
60737f02
PE
2196 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2197
4b66faf3
PE
2198 Make identifiers static if they are not used in other modules.
2199 * data.c (Qcompiled_function, Qframe, Qvector):
2200 * image.c (QimageMagick, Qsvg):
2201 * minibuf.c (Qmetadata):
2202 * window.c (resize_window_check, resize_root_window): Now static.
2203 * window.h (resize_window_check, resize_root_window): Remove decls.
2204
109e28d0
PE
2205 * window.c (window_deletion_count, delete_deletable_window):
2206 Remove; unused.
46a4ce9e
PE
2207 (window_body_lines): Now static.
2208 (Fdelete_other_windows_internal): Mark vars as initialized.
2209 Make sure 'resize_failed' is initialized.
2210 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2211 (resize_window_apply): Remove unused local.
2212 * window.h (delete_deletable_window): Remove decl.
2213
109e28d0 2214 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2215 (imagemagick_load_image): Fix pointer signedness problem by changing
2216 last arg from unsigned char * to char *. All uses changed.
2217 Also, fix a local for similar reasons.
2218 Remove unused locals. Remove locals to avoid shadowing.
2219 (fn_rsvg_handle_free): Remove; unused.
2220 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2221 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2222
3f754b86
PE
2223 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2224
2547adb1
CY
22252011-06-10 Chong Yidong <cyd@stupidchicken.com>
2226
2227 * image.c (gif_load): Fix omitted cast error introduced by
2228 2011-06-06 change.
2229
2c8e37d4
MR
22302011-06-10 Martin Rudalics <rudalics@gmx.at>
2231
2232 * window.h (resize_proportionally, orig_total_lines)
2233 (orig_top_line): Remove from window structure.
2234 (set_window_height, set_window_width, change_window_heights)
2235 (Fdelete_window): Remove prototypes.
2236 (resize_frame_windows): Remove duplicate declaration.
2237
440a42e3
EZ
22382011-06-10 Eli Zaretskii <eliz@gnu.org>
2239
2240 * window.h (resize_frame_windows, resize_window_check)
2241 (delete_deletable_window, resize_root_window)
2242 (resize_frame_windows): Declare prototypes.
2243
2244 * window.c (resize_window_apply): Make definition be "static" to
2245 match the prototype.
2246
562dd5e9
MR
22472011-06-10 Martin Rudalics <rudalics@gmx.at>
2248
2249 * window.c: Remove declarations of Qwindow_size_fixed,
2250 window_min_size_1, window_min_size_2, window_min_size,
2251 size_window, window_fixed_size_p, enlarge_window, delete_window.
2252 Remove static from declaration of Qdelete_window, it's
2253 temporarily needed by Fbury_buffer.
2254 (replace_window): Don't assign orig_top_line and
2255 orig_total_lines.
2256 (Fdelete_window, delete_window): Remove. Window deletion is
2257 handled by window.el.
640c8776
SM
2258 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2259 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2260 (Fdelete_other_windows): Remove. Deleting other windows is
2261 handled by window.el.
2262 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2263 handled in window.el.
2264 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2265 Window minimum sizes are handled in window.el.
2266 (shrink_windows, size_window, set_window_height)
2267 (set_window_width, change_window_heights, window_height)
2268 (window_width, CURBEG, CURSIZE, enlarge_window)
2269 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2270 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2271 handled in window.el.
2272 (make_dummy_parent): Rename to make_parent_window and give it a
2273 second argument horflag.
2274 (make_window): Don't set resize_proportionally any more.
2275 (Fsplit_window): Remove. Windows are split in window.el.
2276 (save_restore_action, save_restore_orig_size)
2277 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2278 Resize mini windows in window.el.
2279 (grow_mini_window, shrink_mini_window): Implement by calling
2280 Qresize_root_window_vertically, resize_window_check and
2281 resize_window_apply.
640c8776
SM
2282 (saved_window, Fset_window_configuration, save_window_save):
2283 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2284 resize_proportionally.
2285 (window_min_height, window_min_width): Move to window.el.
2286 (keys_of_window): Move bindings for delete-other-windows,
2287 split-window, delete-window and enlarge-window to window.el.
2288
2289 * buffer.c: Temporarily extern Qdelete_window.
2290 (Fbury_buffer): Temporarily call Qdelete_window instead of
2291 Fdelete_window (Fbury_buffer will move to window.el soon).
2292
2293 * frame.c (set_menu_bar_lines_1): Remove code handling
2294 orig_top_line and orig_total_lines.
2295
2296 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2297 set_window_height but set heights directly.
2298 (change_frame_size_1): Use resize_frame_windows.
2299
2300 * xdisp.c (init_xdisp): Don't use set_window_height but set
2301 heights directly.
2302
640c8776
SM
2303 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2304 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2305 run_window_configuration_change_hook.
2306
2307 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2308 instead of change_window_heights and run
2309 run_window_configuration_change_hook.
2310
1a13852e
MR
23112011-06-09 Martin Rudalics <rudalics@gmx.at>
2312
2313 * window.c (replace_window): Rename second argument REPLACEMENT to
2314 NEW. New third argument SETFLAG. Rewrite.
2315 (delete_window, make_dummy_parent): Call replace_window with
2316 third argument 1.
2317 (window_list_1): Move down in code.
2318 (run_window_configuration_change_hook): Move set_buffer part
2319 before select_frame_norecord part in order to unwind correctly.
2320 Rename count1 to count.
2321 (recombine_windows, delete_deletable_window, resize_root_window)
2322 (Fdelete_other_windows_internal)
2323 (Frun_window_configuration_change_hook, make_parent_window)
2324 (resize_window_check, resize_window_apply, Fresize_window_apply)
2325 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2326 (Fdelete_window_internal, Fresize_mini_window_internal):
2327 New functions.
1a13852e
MR
2328 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2329
f3d1777e
MR
23302011-06-08 Martin Rudalics <rudalics@gmx.at>
2331
496e208e
MR
2332 * window.h (window): Add some new members to window structure -
2333 normal_lines, normal_cols, new_total, new_normal, clone_number,
2334 splits, nest, prev_buffers, next_buffers.
2335 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2336 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2337
f3d1777e
MR
2338 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2339 Remove.
496e208e
MR
2340 (make_dummy_parent): Set new members of windows structure.
2341 (make_window): Move down in code. Handle new members of window
2342 structure.
2343 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2344 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2345 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2346 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2347 (Fset_window_next_buffers, Fset_window_clone_number):
2348 New functions.
496e208e
MR
2349 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2350 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2351 Doc-string fixes.
2352 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2353 Argument WINDOW can be now internal window too.
2354 (Fwindow_use_time): Move up in code.
2355 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2356 Rewrite doc-string.
2357 (Fset_window_configuration, saved_window)
2358 (Fcurrent_window_configuration, save_window_save): Handle new
2359 members of window structure.
b9e809c2
MR
2360 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2361 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2362 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2363 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2364 Qget_mru_window, Qresize_root_window,
2365 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2366 Qauto_buffer_name; staticpro them.
f3d1777e 2367
abde8f8c
MR
23682011-06-07 Martin Rudalics <rudalics@gmx.at>
2369
2370 * window.c (Fwindow_total_size, Fwindow_left_column)
2371 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2372 (Fwindow_list_1): New functions.
2373 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2374 (Fwindow_width, Fscroll_left, Fscroll_right):
2375 Use window_body_cols instead of window_box_text_cols.
2376 (delete_window, Fset_window_configuration):
2377 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2378 (delete_all_subwindows): Take a window as argument and not a
2379 structure. Rewrite.
190b47e6
MR
2380 (window_loop): Remove handling of GET_LRU_WINDOW and
2381 GET_LARGEST_WINDOW.
2382 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2383
2384 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2385 window_box_text_cols. delete_all_subwindows now takes a
2386 Lisp_Object as argument.
abde8f8c 2387
640c8776
SM
2388 * indent.c (compute_motion, Fcompute_motion):
2389 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2390
fa8a67e6
MR
2391 * frame.c (delete_frame): Call delete_all_subwindows with root
2392 window as argument.
2393
a54e3482
DC
23942011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2395
2396 * fns.c (Fputhash): Document return value.
2397
60002bf5
CY
23982011-06-06 Chong Yidong <cyd@stupidchicken.com>
2399
2400 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2401
0c671da6 24022011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2403
b862a52a 2404 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2405
be44ca6c
PE
2406 Check for overflow when converting integer to cons and back.
2407 * charset.c (Fdefine_charset_internal, Fdecode_char):
2408 Use cons_to_unsigned to catch overflow.
2409 (Fencode_char): Use INTEGER_TO_CONS.
2410 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2411 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2412 * data.c (long_to_cons, cons_to_long): Remove.
2413 (cons_to_unsigned, cons_to_signed): New functions.
2414 These signal an error for invalid or out-of-range values.
2415 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2416 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2417 * font.c (Ffont_variation_glyphs):
2418 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2419 * lisp.h: Include <intprops.h>.
2420 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2421 (cons_to_signed, cons_to_unsigned): New decls.
2422 (long_to_cons, cons_to_long): Remove decls.
2423 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2424 (Fprimitive_undo): Use CONS_TO_INTEGER.
2425 * xfns.c (Fx_window_property): Likewise.
2426 * xselect.c: Include <limits.h>.
2427 (x_own_selection, selection_data_to_lisp_data):
2428 Use INTEGER_TO_CONS.
2429 (x_handle_selection_request, x_handle_selection_clear)
2430 (x_get_foreign_selection, Fx_disown_selection_internal)
2431 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2432 (lisp_data_to_selection_data): Use cons_to_unsigned.
2433 (x_fill_property_data): Use cons_to_signed.
2434 Report values out of range.
2435
d1f3d2af
PE
2436 Check for buffer and string overflow more precisely.
2437 * buffer.h (BUF_BYTES_MAX): New macro.
2438 * lisp.h (STRING_BYTES_MAX): New macro.
2439 * alloc.c (Fmake_string):
2440 * character.c (string_escape_byte8):
2441 * coding.c (coding_alloc_by_realloc):
2442 * doprnt.c (doprnt):
2443 * editfns.c (Fformat):
2444 * eval.c (verror):
2445 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2446 since they may not be the same number.
2447 * editfns.c (Finsert_char):
2448 * fileio.c (Finsert_file_contents):
2449 Likewise for BUF_BYTES_MAX.
2450
dd52fcea
PE
2451 * image.c: Use ptrdiff_t, not int, for sizes.
2452 (slurp_file): Switch from int to ptrdiff_t.
2453 All uses changed.
2454 (slurp_file): Check that file size fits in both size_t (for
2455 malloc) and ptrdiff_t (for sanity and safety).
2456
7f9bbdbb
PE
2457 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2458 if b->modtime has its maximal value.
2459
dfe18f82
PE
2460 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2461
84acfcf0
PE
2462 Don't assume time_t can fit into int.
2463 * buffer.h (struct buffer.modtime): Now time_t, not int.
2464 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2465 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2466
ccd9a01a
PE
2467 Minor fixes for signed vs unsigned integers.
2468 * character.h (MAYBE_UNIFY_CHAR):
2469 * charset.c (maybe_unify_char):
2470 * keyboard.c (read_char, reorder_modifiers):
2471 XINT -> XFASTINT, since the integer must be nonnegative.
2472 * ftfont.c (ftfont_spec_pattern):
2473 * keymap.c (access_keymap, silly_event_symbol_error):
2474 XUINT -> XFASTINT, since the integer must be nonnegative.
2475 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2476 since it makes no difference and we prefer signed.
2477 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2478 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2479 nonnegative.
2480
d6d100dd
SM
24812011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2482
2483 * window.h (Fwindow_frame): Declare.
2484
2b6148e4
PE
24852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2486
2487 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2488 (SPARE_MEMORY): Always define.
2489 (LARGE_REQUEST): Remove.
2490 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2491
f230ecc9
MR
24922011-06-06 Martin Rudalics <rudalics@gmx.at>
2493
727e958e
MR
2494 * lisp.h: Move EXFUNS for Fframe_root_window,
2495 Fframe_first_window and Fset_frame_selected_window to window.h.
2496
2497 * window.h: Move EXFUNS for Fframe_root_window,
2498 Fframe_first_window and Fset_frame_selected_window here from
2499 lisp.h.
2500
2501 * frame.c (Fwindow_frame, Fframe_first_window)
2502 (Fframe_root_window, Fframe_selected_window)
2503 (Fset_frame_selected_window): Move to window.c.
2504 (Factive_minibuffer_window): Move to minibuf.c.
2505 (Fother_visible_frames_p): New function.
2506
2507 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2508
f230ecc9
MR
2509 * window.c (decode_window, decode_any_window): Move up in code.
2510 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2511 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2512 (Fwindow_buffer): Move up and rewrite doc-string.
2513 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2514 (Fwindow_prev): New functions.
727e958e
MR
2515 (Fwindow_frame): Move here from frame.c. Accept any window as
2516 argument.
2517 (Fframe_root_window, Fframe_first_window)
2518 (Fframe_selected_window): Move here from frame.c. Accept frame
2519 or arbitrary window as argument. Update doc-strings.
2520 (Fminibuffer_window): Move up in code.
2521 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2522 (Fset_frame_selected_window): Move here from frame.c.
2523 Marginal rewrite.
727e958e
MR
2524 (Fselected_window, select_window, Fselect_window): Move up in
2525 code. Minor doc-string fixes.
f230ecc9 2526
4d09bcf6
PE
25272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2528
2529 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2530 Do not assume that spare memory exists; that assumption is valid
2531 only if SYSTEM_MALLOC.
2532 (LARGE_REQUEST): New macro, so that the issue of large requests
2533 is separated from the issue of spare memory.
2534
810928a2
AS
25352011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2536
172418ad
AS
2537 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2538 format. (Bug#8806)
2539
43f862f7
AS
2540 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2541
810928a2
AS
2542 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2543 before statements.
2544
a059fe24
JD
25452011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2546
2547 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2548
2549 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2550
2551 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2552 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2553
989bf368
JB
25542011-06-05 Juanma Barranquero <lekktu@gmail.com>
2555
2556 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2557
4b80f674
CY
25582011-06-04 Chong Yidong <cyd@stupidchicken.com>
2559
2560 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2561 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2562 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2563 New error handlers.
4b80f674
CY
2564 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2565 Obey Vx_select_enable_clipboard_manager. Catch errors in
2566 x_clipboard_manager_save (Bug#8779).
2567 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2568 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2569
99a33b77 25702011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2571
2572 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2573
99a33b77 25742011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2575
2576 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2577 in the current matrix if keep_current_p is non-zero.
2578
8264569d
EZ
25792011-06-04 Eli Zaretskii <eliz@gnu.org>
2580
2581 * bidi.c (bidi_level_of_next_char): Fix last change.
2582
57f97249
EZ
25832011-06-03 Eli Zaretskii <eliz@gnu.org>
2584
fec2107c 2585 Support bidi reordering of text covered by display properties.
57f97249 2586
fec2107c
EZ
2587 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2588 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2589 (bidi_cache_search, bidi_cache_iterator_state)
2590 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2591 (bidi_level_of_next_char, bidi_move_to_visually_next):
2592 Support character positions inside a run of characters covered by a
fec2107c
EZ
2593 display string.
2594 (bidi_paragraph_init, bidi_resolve_explicit_1)
2595 (bidi_level_of_next_char): Call bidi_fetch_char and
2596 bidi_fetch_char_advance instead of FETCH_CHAR and
2597 FETCH_CHAR_ADVANCE.
2598 (bidi_init_it): Initialize new members.
2599 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2600 definitions.
2601 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2602 instead of using explicit *_CHAR codes.
d6d100dd
SM
2603 (bidi_resolve_explicit, bidi_resolve_weak):
2604 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2605 bidirectional text is supported only in multibyte buffers.
2606 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2607 it to initialize the frame_window_p member of struct bidi_it.
2608 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2609 (bidi_resolve_explicit, bidi_resolve_weak)
2610 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2611 bidi_it->nchars is non-positive.
2612 (bidi_level_of_next_char): Don't try to lookup the cache for the
2613 next/previous character if nothing is cached there yet, or if we
2614 were just reseat()'ed to a new position.
c40e2fb2 2615
0e14fe90
EZ
2616 * xdisp.c (set_cursor_from_row): Set start and stop points
2617 according to the row's direction when priming the loop that looks
2618 for the glyph on which to display cursor.
2619 (single_display_spec_intangible_p): Function deleted.
2620 (display_prop_intangible_p): Reimplement to call
2621 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2622 Accept 3 additional arguments needed by handle_display_spec.
2623 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2624 values: lists, `(when COND...)' forms, etc.
2625 (single_display_spec_string_p): Support property values that are
2626 lists with the argument STRING its top-level element.
2627 (display_prop_string_p): Fix the condition for processing a
2628 property that is a list to be consistent with handle_display_spec.
fec2107c 2629 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2630 last portion of handle_display_prop.
2631 (compute_display_string_pos): Accept additional argument
2632 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2633 value of a `display' property is a "replacing spec".
2634 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2635 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2636 the display property, but just return a value indicating whether
2637 the display property will replace the characters it covers.
2638 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2639 frame_window_p members of struct bidi_it.
d6d100dd
SM
2640 (compute_display_string_pos, compute_display_string_end):
2641 New functions.
fec2107c
EZ
2642 (push_it): Accept second argument POSITION, where pop_it should
2643 jump to continue iteration.
2644 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2645
fec2107c
EZ
2646 * keyboard.c (adjust_point_for_property): Adjust the call to
2647 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2648
2649 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2650 (bidi_init_it): Update prototypes.
2651 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2652 (compute_display_string_pos, compute_display_string_end):
2653 Declare prototypes.
fec2107c
EZ
2654 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2655 EMACS_INT.
fc6f18ce 2656
40087514 26572011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2658
57f53182
PE
2659 Malloc failure behavior now depends on size of allocation.
2660 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2661 * lisp.h: Change signatures accordingly.
2662 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2663 All callers changed. (Bug#8762)
2664
2665 * gnutls.c: Use Emacs's memory allocators.
2666 Without this change, the gnutls library would invoke malloc etc.
2667 directly, which causes problems on non-SYNC_INPUT hosts, and which
2668 runs afoul of improving memory_full behavior. (Bug#8761)
2669 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2670 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2671 xfree instead of the default malloc, realloc, free.
2672 (Fgnutls_boot): No need to check for memory allocation failure,
2673 since xmalloc does that for us.
2674
ac32cd99 2675 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2676 * category.c (hash_get_category_set):
2677 * ccl.c (ccl_driver):
2678 * charset.c (Fdefine_charset_internal):
2679 * charset.h (struct charset.hash_index):
2680 * composite.c (get_composition_id, gstring_lookup_cache)
2681 (composition_gstring_put_cache):
2682 * composite.h (struct composition.hash_index):
2683 * dispextern.h (struct image.hash):
2684 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2685 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2686 (hashfn_equal, hashfn_user_defined, make_hash_table)
2687 (maybe_resize_hash_table, hash_lookup, hash_put)
2688 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2689 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2690 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2691 * image.c (make_image, search_image_cache, lookup_image)
2692 (xpm_put_color_table_h):
2693 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2694 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2695 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2696 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2697 * alloc.c (allocate_vectorlike):
2698 Check for overflow in vector size calculations.
2699 * ccl.c (ccl_driver):
2700 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2701 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2702 need to be updated by these changes.
40087514
PE
2703 * fns.c (make_hash_table, maybe_resize_hash_table):
2704 Check for integer overflow with large hash tables.
0de4bb68
PE
2705 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2706 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2707 (SXHASH_REDUCE): New macro.
2708 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2709 Use it instead of discarding useful hash info with large hash values.
2710 (sxhash_float): New function.
2711 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2712 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2713 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2714 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2715 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2716 Adjust signatures to match updated version of code.
2717 (consing_since_gc): Now EMACS_INT, since a single hash table can
2718 use more than INT_MAX bytes.
2719
698d32e2
DN
27202011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2721
2722 Make it possible to build with GCC-4.6+ -O2 -flto.
2723
2724 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2725
fd6fa53f
SM
27262011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2727
2728 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2729 Call minibuffer-inactive-mode.
2730
864db017
JB
27312011-05-31 Juanma Barranquero <lekktu@gmail.com>
2732
2733 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2734 Update dependencies.
2735
2ad0baf4
DN
27362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2737
2738 * data.c (init_data): Remove code for UTS, this system is not
2739 supported anymore.
2740
4fcc2638
DN
27412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2742
2743 Don't force ./temacs to start in terminal mode.
2744
2745 * frame.c (make_initial_frame): Initialize faces in all cases, not
2746 only when CANNOT_DUMP is defined.
2747 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2748
c56e0fd5
DN
27492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2750
2751 * dispnew.c (add_window_display_history): Use const for the string
2752 pointer. Remove declaration, not needed.
2753
333d54da 27542011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2755
55d4c1b2 2756 Use 'inline', not 'INLINE'.
333d54da 2757 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2758 * alloc.c, fontset.c (INLINE): Remove.
2759 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2760 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2761 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2762 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2763 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2764
738db178
DN
27652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2766
2767 Make it possible to run ./temacs.
2768
2769 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2770 syms_of_callproc does the same thing. Remove test for
2771 "initialized", do it in the caller.
2772 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2773
620c53a6
SM
27742011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2775
2776 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2777 (read_minibuf): Use get_minibuffer.
2778 (syms_of_minibuf): Use DEFSYM.
2779 (Qmetadata): New var.
2780 * data.c (Qbuffer): Don't make it static.
2781 (syms_of_data): Use DEFSYM.
2782
e003a292
PE
27832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2784
2785 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2786 (CCL_CODE_MIN): New macro.
2787
ed008a6d
PE
27882011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2789
3687c2ef
PE
2790 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2791
ed008a6d
PE
2792 * eval.c (Qdebug): Now static.
2793 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2794 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2795 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2796
d66c4c7c
CY
27972011-05-29 Chong Yidong <cyd@stupidchicken.com>
2798
2799 * image.c: Various fixes to ImageMagick code comments.
2800 (Fimagemagick_types): Doc fix.
2801
5fbc2025
PE
28022011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2803
0196f88a
PE
2804 Minor fixes prompted by GCC 4.6.0 warnings.
2805
2806 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2807
5fbc2025
PE
2808 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2809 (x_clipboard_manager_save_all): Move extern decl to ...
2810 * xterm.h: ... here, so that it can be checked for consistency.
2811
1dd3c2d9
CY
28122011-05-29 Chong Yidong <cyd@stupidchicken.com>
2813
2814 * xselect.c (x_clipboard_manager_save_frame)
2815 (x_clipboard_manager_save_all): New functions.
2816 (Fx_clipboard_manager_save): Lisp function deleted.
2817
2818 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2819 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2820
2821 * xterm.h: Update prototype.
2822
5ba6571d
WX
28232011-05-28 William Xu <william.xwl@gmail.com>
2824
2825 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2826 exiting (Bug#8239).
2827
3eaff834
JM
28282011-05-28 Jim Meyering <meyering@redhat.com>
2829
e1900994 2830 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2831 * fns.c (to_uchar): Define.
2832 (crypto_hash_function): Use it to convert some newly-signed
2833 variables to unsigned, to avoid sign-extension bugs. For example,
2834 without this change, (md5 "truc") would evaluate to
2835 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2836 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2837 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2838
0f6990a7
PE
28392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2840
2841 Integer overflow fixes.
c8a9ca5a 2842
08686060
PE
2843 * dbusbind.c: Serial number integer overflow fixes.
2844 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2845 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2846 to hold a serial number that is too large for a fixnum.
2847 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2848 Check for serial numbers out of range. Decode any serial number
59568bf0 2849 that was so large that it became a float. (Bug#8722)
08686060 2850
2d1fc3c7
PE
2851 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2852 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2853 Use XFASTINT rather than XUINT when numbers are nonnegative.
2854 (xd_append_arg, Fdbus_method_return_internal):
2855 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2856 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2857 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2858 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2859 (Bug#8722)
2d1fc3c7 2860
c8a9ca5a
PE
2861 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2862
519e1d69
PE
2863 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2864
30569699
PE
2865 ccl: add integer overflow checks
2866 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2867 (IN_INT_RANGE): New macros.
2868 (ccl_driver): Use them to check for integer overflow when
2869 decoding a CCL program. Many of the new checks are whether XINT (x)
2870 fits in int; it doesn't always, on 64-bit hosts. The new version
2871 doesn't catch all possible integer overflows, but it's an
847044ea 2872 improvement. (Bug#8719)
30569699 2873
c11285dc
PE
2874 * alloc.c (make_event_array): Use XINT, not XUINT.
2875 There's no need for unsigned here.
2876
fdccd48e
PE
2877 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2878 This follows up to the 2011-05-06 change that substituted uintptr_t
2879 for EMACS_INT. This case wasn't caught back then.
2880
37910ab2
PE
2881 Rework Fformat to avoid integer overflow issues.
2882 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2883 now (part of C89). Include <verify.h>.
2884 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2885 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2886 (Fformat): Avoid the prepass trying to compute sizes; it was only
2887 approximate and thus did not catch overflow reliably. Instead, walk
2888 through the format just once, formatting and computing sizes as we go,
2889 checking for integer overflow at every step, and allocating a larger
2890 buffer as needed. Keep track separately whether the format is
2891 multibyte. Keep only the most-recently calculated precision, rather
2892 than them all. Record whether each argument has been converted to
2893 string. Use EMACS_INT, not int, for byte and char and arg counts.
2894 Support field widths and precisions larger than INT_MAX. Avoid
2895 sprintf's undefined behavior with conversion specifications such as %#d
2896 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2897 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2898 formatting out-of-range floating point numbers with int
9173deec 2899 formats. (Bug#8668)
37910ab2 2900
2e6578fb
PE
2901 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2902
0ae6bdee
PE
2903 * data.c: Avoid integer truncation in expressions involving floats.
2904 * data.c: Include <intprops.h>.
2905 (arith_driver): When there's an integer overflow in an expression
2906 involving floating point, convert the integers to floating point
2907 so that the resulting value does not suffer from catastrophic
2908 integer truncation. For example, on a 64-bit host (* 4
2909 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2910 Do not rely on undefined behavior after integer overflow.
2911
de883a70
PE
2912 merge count_size_as_multibyte, parse_str_to_multibyte
2913 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2914 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2915 Check for integer overflow.
2916 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2917 since it's now a duplicate of the other. This is more of
2918 a character than a buffer op, so better that it's in character.c.
2919 * fns.c, print.c: Adjust to above changes.
2920
2ff916cb
PE
29212011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2922
2923 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2924
f1b54466
PE
29252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2926
fb1ac845
PE
2927 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2928 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2929 (x_clipboard_manager_save): Now static.
2930 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2931
f1b54466
PE
2932 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2933 (crypto_hash_function): Now static.
2934 Fix pointer signedness problems. Avoid unnecessary initializations.
2935
a9f737ee
CY
29362011-05-27 Chong Yidong <cyd@stupidchicken.com>
2937
2938 * termhooks.h (Vselection_alist): Make it terminal-local.
2939
2940 * terminal.c (create_terminal): Initialize it.
2941
2942 * xselect.c: Support for clipboard managers.
2943 (Vselection_alist): Move to termhooks.h as terminal-local var.
2944 (LOCAL_SELECTION): New macro.
2945 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2946 (symbol_to_x_atom): Remove gratuitous arg.
2947 (x_handle_selection_request, lisp_data_to_selection_data)
2948 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2949 (x_own_selection, x_get_local_selection, x_convert_selection):
2950 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2951 (some_frame_on_display): Delete unused function.
2952 (Fx_own_selection_internal, Fx_get_selection_internal)
2953 (Fx_disown_selection_internal, Fx_selection_owner_p)
2954 (Fx_selection_exists_p): New optional frame arg.
2955 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2956 (x_handle_selection_clear): Don't treat other terminals with the
2957 same keyboard specially. Use the terminal-local Vselection_alist.
2958 (x_clear_frame_selections): Use Frun_hook_with_args.
2959
2960 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2961
2962 * xterm.h: Add support for those atoms.
2963
e067f0c1
CY
29642011-05-26 Chong Yidong <cyd@stupidchicken.com>
2965
2966 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2967 (converted_selections, conversion_fail_tag): New global variables.
2968 (x_selection_request_lisp_error): Free the above.
2969 (x_get_local_selection): Remove unnecessary code.
2970 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2971 of converted selections stored in converted_selections.
2972 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2973 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2974 (x_convert_selection): New function.
2975 (x_handle_selection_event): Simplify.
2976 (x_get_foreign_selection): Don't ignore incoming requests while
2977 waiting for an answer; this will fail when we implement
2978 SAVE_TARGETS, and seems unnecessary anyway.
2979 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2980 (Vx_sent_selection_functions): Doc fix.
2981
0f4aebc0
LL
29822011-05-26 Leo Liu <sdl.web@gmail.com>
2983
2984 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2985
e61124cd
YM
29862011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2987
2988 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2989
2990 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2991 for fringe update if it has periodic bitmap.
ac389d0c 2992 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2993 and fringe_bitmap_periodic_p.
2994
2995 * fringe.c (get_fringe_bitmap_data): New function.
2996 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2997 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2998 row. Mark glyph row for fringe update if periodicity changed.
2999
3000 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3001 for fringe update unless it has periodic bitmap.
3002
f16d9837
KH
30032011-05-25 Kenichi Handa <handa@m17n.org>
3004
3005 * xdisp.c (get_next_display_element): Set correct it->face_id for
3006 a static composition.
3007
e1b90ef6
LL
30082011-05-24 Leo Liu <sdl.web@gmail.com>
3009
3010 * deps.mk (fns.o):
3011 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3012
3013 * fns.c (crypto_hash_function, Fsha1): New function.
3014 (Fmd5): Use crypto_hash_function.
3015 (syms_of_fns): Add Ssha1.
3016
7400048f
PE
30172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 * gnutls.c: Remove unused macros.
3020 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3021 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3022 Remove macros that are defined and never used.
3023 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3024
abb71cf4
CY
30252011-05-22 Chong Yidong <cyd@stupidchicken.com>
3026
3027 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3028 (Fx_get_selection_internal): Minor cleanup.
3029 (Fx_own_selection_internal): Rename arguments for consistency with
3030 select.el.
3031
6307db39
PE
30322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3033
3034 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3035
f3d4e0a4
CY
30362011-05-22 Chong Yidong <cyd@stupidchicken.com>
3037
3038 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3039
4d8ade89
YM
30402011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3041
3042 * dispnew.c (scrolling_window): Don't exclude the case that the
3043 last enabled row in the desired matrix touches the bottom boundary.
3044
32078c8d
GM
30452011-05-21 Glenn Morris <rgm@gnu.org>
3046
3047 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3048 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3049 and add some more files.
32078c8d 3050
7285dc67
EZ
30512011-05-20 Eli Zaretskii <eliz@gnu.org>
3052
3053 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3054 report_file_error introduced by the change from 2011-05-07.
3055
89d1bd22
PE
30562011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3057
3058 * systime.h (Time): Define only if emacs is defined.
3059 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3060 where the include path doesn't have X11/X.h by default. See
3061 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3062
e23640bb 30632011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3064
3065 * composite.c (find_automatic_composition): Fix previous change.
3066
b9704ad9
GM
30672011-05-20 Glenn Morris <rgm@gnu.org>
3068
3069 * lisp.mk: New file, split from Makefile.in.
3070 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3071 (shortlisp): Remove.
3072 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3073
4a720484
GM
30742011-05-19 Glenn Morris <rgm@gnu.org>
3075
3076 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3077 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3078 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3079 (lisp): Set the order to that of loadup.el.
3080 (shortlisp): Make it a copy of $lisp.
3081 (SOME_MACHINE_LISP): Remove.
3082 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3083 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3084
a28d4396
KH
30852011-05-18 Kenichi Handa <handa@m17n.org>
3086
3087 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3088 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3089 (find_automatic_composition): Mostly rewrite for efficiency.
3090
a2b1fa8e
JB
30912011-05-18 Juanma Barranquero <lekktu@gmail.com>
3092
3093 * makefile.w32-in: Update dependencies.
3094
8e1f5610
CS
30952011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3096
3097 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3098 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3099
7025ee00 31002011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3101
cdfa6eab
PE
3102 Fix some integer overflow issues, such as string length overflow.
3103
06d6db33
PE
3104 * insdel.c (count_size_as_multibyte): Check for string overflow.
3105
2b4560a8
PE
3106 * character.c (lisp_string_width): Check for string overflow.
3107 Use EMACS_INT, not int, for string indexes and lengths; in
3108 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3109 the resulting string length overflows an EMACS_INT; instead,
3110 report a string overflow if no precision given. When checking for
3111 precision exhaustion, use a check that cannot possibly have
3112 integer overflow. (Bug#8675)
3113 * character.h (lisp_string_width): Adjust to new signature.
3114
cb93f9be
PE
3115 * alloc.c (string_overflow): New function.
3116 (Fmake_string): Use it. This doesn't change behavior, but saves
3117 a few bytes and will simplify future changes.
3118 * character.c (string_escape_byte8): Likewise.
3119 * lisp.h (string_overflow): New decl.
3120
1a1f3366
PE
3121 Fixups, following up to the user-interface timestamp change.
3122 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3123 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3124 * msdos.c (mouse_get_pos): Likewise.
3125 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3126 * w32gui.h (Time): Define by including "systime.h" rather than by
3127 declaring it ourselves. (Bug#8664)
3128
d4e3e4d3
PE
3129 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3130 * image.c (clear_image_cache): Likewise.
3131
f6a24d19
PE
3132 * term.c (term_mouse_position): Don't assume time_t wraparound.
3133
08dc5ae6
PE
3134 Be more systematic about user-interface timestamps.
3135 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3136 and sometimes 'EMACS_UINT', to represent these timestamps.
3137 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3138 This makes the code easier to follow, and makes it easier to catch
3139 integer overflow bugs such as Bug#8664.
3140 * frame.c (Fmouse_position, Fmouse_pixel_position):
3141 Use Time, not unsigned long, for user-interface timestamps.
3142 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3143 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3144 * keyboard.h (last_event_timestamp): Likewise.
3145 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3146 * menu.h (xmenu_show): Likewise.
3147 * term.c (term_mouse_position): Likewise.
3148 * termhooks.h (struct input_event.timestamp): Likewise.
3149 (struct terminal.mouse_position_hook): Likewise.
3150 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3151 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3152 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3153 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3154 what it was before.
3155 * menu.h, termhooks.h: Include "systime.h", for Time.
3156
8e55734a
PE
3157 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3158 Don't assume that the difference between two unsigned long values
3159 can fit into an integer. At this point, we know button_down_time
3160 <= event->timestamp, so the difference must be nonnegative, so
3161 there's no need to cast the result if double-click-time is
3162 nonnegative, as it should be; check that it's nonnegative, just in
3163 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3164 apart (about 25 days). (Bug#8664)
8e55734a 3165
841f1b75 3166 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3167 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3168
3e26f69c
PE
3169 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3170 that always fit in int. Use a sentinel instead of a counter, to
3171 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3172 * frame.h (struct frame): Use int for menu_bar_items_used
3173 instead of EMACS_INT, since it always fits in int.
3e26f69c 3174
5cc152c0
PE
3175 * menu.c (grow_menu_items): Check for int overflow.
3176
d89eb65e
PE
3177 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3178
5235bd3e
PE
3179 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3180 Before, the code was not consistent. These values cannot exceed
3181 2**31 - 1 so there's no need to make them unsigned.
3182 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3183 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3184 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3185 as modifiers.
3186 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3187
bc827e23
PE
3188 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3189 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3190 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3191 presumably because the widths might not match.
3192
78eb494e
PE
3193 * window.c (size_window): Avoid needless test at loop start.
3194
04f2d78b
CB
31952011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3196
3197 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3198
d2fc7e3d 31992011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3200
3201 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3202
d2fc7e3d 32032011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3204
3205 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3206 `width' to `bar_area_x' and `bar_area_width', respectively.
3207 (x_scroll_run): Take account of fringe background extension.
3208
04f2d78b
CB
3209 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3210 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3211 `bar_area_width', respectively.
3212 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3213 background extension.
3214
79b70037
GM
32152011-05-10 Jim Meyering <meyering@redhat.com>
3216
3217 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3218
2f142cc5
JB
32192011-05-10 Juanma Barranquero <lekktu@gmail.com>
3220
3221 * image.c (Finit_image_library): Return t for built-in image types,
3222 like pbm and xbm. (Bug#8640)
3223
57679c86
AS
32242011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3225
3226 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3227
888c9e86
EZ
32282011-05-07 Eli Zaretskii <eliz@gnu.org>
3229
b0512a1d
EZ
3230 * w32console.c (Fset_screen_color): Doc fix.
3231 (Fget_screen_color): New function.
3232 (syms_of_ntterm): Defsubr it.
3233
7285dc67
EZ
3234 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3235 unlink the temporary file if Fcall_process didn't create it in the
3236 first place.
3237 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3238 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3239 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3240 cue to call_process_cleanup not to close that handle.
3241
4d3fcc8e
BK
32422011-05-07 Ben Key <bkey76@gmail.com>
3243
3244 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3245 one of two shell specific rules, either bootstrap-temacs-CMD or
3246 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3247 to the previous implementation of the bootstrap-temacs rule.
3248 The bootstrap-temacs-CMD rule is similar to the previous
3249 implementation of the bootstrap-temacs rule except that it
3250 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3251 variable.
3252
3253 These changes, along with some changes to nt/configure.bat,
3254 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3255 earlier fix to add support for --cflags and --ldflags options
3256 that include quotes so that it works whether make uses cmd or
3257 sh as the shell.
3258
b4289b64
MA
32592011-05-06 Michael Albinus <michael.albinus@gmx.de>
3260
3261 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3262 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3263 is a constant.
3264 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3265 a string. Handle both cases.
3266 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3267 (Fdbus_register_method): Use Qinvalid_function.
3268
af4c0e28
JB
32692011-05-06 Juanma Barranquero <lekktu@gmail.com>
3270
3271 * makefile.w32-in: Update dependencies.
3272 (LISP_H): Add inttypes.h and stdin.h.
3273 (PROCESS_H): Add unistd.h.
3274
c51453d9
EZ
32752011-05-06 Eli Zaretskii <eliz@gnu.org>
3276
3277 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3278 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3279
8ff0ac3c 32802011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3281
4c4b566b
PE
3282 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3283
aab2b9b5
PE
3284 * term.c (vfatal): Remove stray call to va_end.
3285 It's not needed and the C Standard doesn't allow it here anyway.
3286
c378da0b
PE
3287 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3288 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3289
288b08c7
PE
3290 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3291 bytes.
3292
e3601888
PE
3293 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3294
db6c0e74
PE
3295 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3296
dd5963ea
PE
3297 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3298
88c9450f
PE
3299 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3300
2f9442b8
PE
3301 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3302
c032b5f8
PE
3303 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3304 * charset.c (Fdefine_charset_internal): Don't initialize
3305 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3306 32-bit int (Bug#8600).
a108c10b
PE
3307
3308 * lread.c (read_integer): Be more consistent with string-to-number.
3309 Use string_to_number to do the actual conversion; this avoids
3310 rounding errors and fixes some other screwups. Without this fix,
3311 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3312 (digit_to_number): Move earlier, for benefit of read_integer.
3313 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3314 not a digit in any supported base. (Bug#8602)
a108c10b 3315
ad5f9eea
PE
3316 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3317
aec1708a
PE
3318 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3319 to match comment at start of function. This also removes a
3320 GCC warning about overflow in a 32+64-bit port.
3321
47be4ab5
PE
3322 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3323
371cac43
PE
3324 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3325 Reported by Stefan Monnier in
3326 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3327 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3328 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3329
d01a7826
PE
3330 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3331 (EMACS_UINTPTR): Likewise, with uintptr_t.
3332
7fd47d5c
PE
3333 * lisp.h: Prefer 64-bit EMACS_INT if available.
3334 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3335 on 32-bit hosts that have 64-bit int, so that they can access
3336 large files.
122b0c86
PE
3337 However, temporarily disable this change unless the temporary
3338 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3339
8727937b
PE
3340 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3341
8ac068ac
PE
3342 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3343 This removes an assumption that EMACS_INT and long are the same
3344 width as pointers. The assumption is true for Emacs porting targets
3345 now, but we want to make other targets possible.
3346 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3347 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3348 In the rest of the code, change types of integers that hold casted
3349 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3350 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3351 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3352 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3353 No need to cast type when ORing.
3354 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3355 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3356 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3357 assume EMACS_INT is the same width as char *.
3358 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3359 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3360 Remove no-longer-needed casts.
3361 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3362 (xg_tool_bar_help_callback, xg_make_tool_item):
3363 Use EMACS_INTPTR to hold an integer
3364 that will be cast to void *; this can avoid a GCC warning
3365 if EMACS_INT is not the same width as void *.
3366 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3367 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3368 (current_message_1, set_message_1):
3369 Use a local to convert to proper width without a cast.
3370 * xmenu.c (dialog_selection_callback): Likewise.
3371
ede49d71
PE
3372 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3373 Also, don't assume VALBITS / RAND_BITS is less than 5,
3374 and don't rely on undefined behavior when shifting a 1 left into
3375 the sign bit.
3376 * lisp.h (get_random): Change signature to match.
3377
2f30ecd0
PE
3378 * lread.c (hash_string): Use size_t, not int, for hash computation.
3379 Normally we prefer signed values; but hashing is special, because
3380 it's better to use unsigned division on hash table sizes so that
3381 the remainder is nonnegative. Also, size_t is the natural width
3382 for hashing into memory. The previous code used 'int', which doesn't
3383 retain enough info to hash well into very large tables.
3384 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3385
2a866e7b
PE
3386 * dbusbind.c: Don't possibly lose pointer info when converting.
3387 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3388 Use XPNTR rather than XHASH, so that the high-order bits of
3389 the pointer aren't lost when converting through void *.
3390
51639eac
PE
3391 * eval.c (Fautoload): Don't double-shift a pointer.
3392
92394119
PE
3393 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3394
dbdb9a7c
JB
33952011-05-06 Juanma Barranquero <lekktu@gmail.com>
3396
3397 * gnutls.c (DEF_GNUTLS_FN):
3398 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3399
db7a0b4f
AS
34002011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3401
3402 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3403 marker. (Bug#8610)
3404
f7ff1b0f 34052011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3406
3407 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3408 New version that can reserve upto 2GB of heap space.
3409
f7ff1b0f 34102011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3411
3412 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3413
639c109b
TZ
34142011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3415
3416 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3417 `gnutls_certificate_set_x509_key_file'.
3418
d2127135
JB
34192011-05-05 Juanma Barranquero <lekktu@gmail.com>
3420
3421 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3422 Update dependencies.
3423
e968f4f3
JB
34242011-05-04 Juanma Barranquero <lekktu@gmail.com>
3425
3426 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3427 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3428 Remove unused parameter `fildes'.
3429 * process.c (read_process_output, send_process): Don't pass it.
3430
84d358f0
JB
34312011-05-04 Juanma Barranquero <lekktu@gmail.com>
3432
3433 Fix previous change: the library cache is defined in w32.c.
3434 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3435 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3436
0898ca10
JB
34372011-05-04 Juanma Barranquero <lekktu@gmail.com>
3438
3439 Implement dynamic loading of GnuTLS on Windows.
3440
3441 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3442 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3443 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3444 Declare.
3445
3446 * gnutls.c (Qgnutls_dll): Define.
3447 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3448 (gnutls_*): Declare function pointers.
3449 (init_gnutls_functions): New function to initialize function pointers.
3450 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3451 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3452 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3453 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3454 (emacs_gnutls_write, emacs_gnutls_read)
3455 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3456 (Fgnutls_available_p): New function.
3457 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3458 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3459 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3460
3461 * image.c: Include w32.h.
3462 (Vimage_type_cache): Delete.
3463 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3464 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3465 (w32_delayed_load): Move to w32.c.
3466
3467 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3468
3469 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3470 (w32_delayed_load): Move from image.c. When loading a library, record
3471 its filename in the :loaded-from property of the library id.
3472 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3473 Initialize and staticpro them.
3474 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3475
3476 * process.c: Include lisp.h before w32.h, not after.
3477 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3478 instead of gnutls_record_check_pending.
3479
3480 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3481
ff4de4aa
TZ
34822011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3483
3484 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3485 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3486 as passed in.
3487
abe95abb
JD
34882011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3489
3490 * xterm.c (x_set_frame_alpha): Do not set property on anything
3491 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3492
e16e55d4
JB
34932011-05-02 Juanma Barranquero <lekktu@gmail.com>
3494
3495 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3496
bafcf6a5
JB
34972011-05-02 Juanma Barranquero <lekktu@gmail.com>
3498
3499 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3500 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3501 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3502 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3503 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3504 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3505 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3506 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3507 (Qgnutls_bootprop_callbacks_verify): Make static.
3508
e7a6747f
AS
35092011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3510
19ed11ba
AS
3511 * callproc.c: Indentation fixup.
3512
e7a6747f 3513 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3514 (wait_for_termination, interruptible_wait_for_termination):
3515 Move after wait_for_termination_1.
e7a6747f 3516
1ef14cb4
LMI
35172011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3518
3519 * sysdep.c (interruptible_wait_for_termination): New function
3520 which is like wait_for_termination, but allows keyboard
3521 interruptions.
3522
3523 * callproc.c (Fcall_process): Add (:file "file") as an option for
3524 the STDOUT buffer.
3525 (Fcall_process_region): Ditto.
3526
330d880c
EZ
35272011-04-30 Eli Zaretskii <eliz@gnu.org>
3528
8db90b73
EZ
3529 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3530 rather than `XVECTOR (FOO)->size'.
3531
330d880c
EZ
3532 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3533 inttypes.h, as a gnulib replacement is used if it not available in
3534 system headers.
3535
15cbd324
EZ
35362011-04-21 Eli Zaretskii <eliz@gnu.org>
3537
3538 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3539 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3540 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3541
3542 * coding.c (coding_alloc_by_realloc): Error out if destination
3543 will grow beyond MOST_POSITIVE_FIXNUM.
3544 (decode_coding_emacs_mule): Abort if there isn't enough place in
3545 charbuf for the composition carryover bytes. Reserve an extra
3546 space for up to 2 characters produced in a loop.
3547 (decode_coding_iso_2022): Abort if there isn't enough place in
3548 charbuf for the composition carryover bytes.
3549
35502011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3551
ae940cca
EZ
3552 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3553 aborting when %lld or %lll format is passed.
3554 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3555 %llo or %llx format is passed. (Bug#8545)
3556
03ab8921
EZ
3557 * window.c (window_scroll_line_based): Use a marker instead of
3558 simple variables to record original value of point. (Bug#7952)
3559
afda1437
EZ
3560 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3561 produced by %s or %c overflows available buffer space. (Bug#8545)
3562
f76dee0c
PE
35632011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3564
3565 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3566 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3567
fdc5744d
JB
35682011-04-28 Juanma Barranquero <lekktu@gmail.com>
3569
3570 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3571
638f053a
JB
35722011-04-28 Juanma Barranquero <lekktu@gmail.com>
3573
3574 * keyboard.c (Qdelayed_warnings_hook): Define.
3575 (command_loop_1): Run `delayed-warnings-hook'
3576 if Vdelayed_warnings_list is non-nil.
3577 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3578 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3579
d178f871
EZ
35802011-04-28 Eli Zaretskii <eliz@gnu.org>
3581
3582 * doprnt.c (doprnt): Don't return value smaller than the buffer
3583 size if the message was truncated. (Bug#8545).
3584
b124fd93
JB
35852011-04-28 Juanma Barranquero <lekktu@gmail.com>
3586
3587 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3588 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3589
e810457d
PE
35902011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3591
3592 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3593
ea51cceb
JB
35942011-04-27 Juanma Barranquero <lekktu@gmail.com>
3595
3596 * makefile.w32-in: Update dependencies.
3597
94dcfacf
EZ
35982011-04-27 Eli Zaretskii <eliz@gnu.org>
3599
3600 Improve `doprnt' and its usage. (Bug#8545)
3601 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3602 `format_end'. Remove support for %l as a conversion specifier.
3603 Don't use xrealloc. Improve diagnostics when the %l size modifier
3604 is used. Update the commentary.
3605
3606 * eval.c (verror): Simplify calculation of size_t.
3607
3608 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3609 messages.
3610
f61f41d7
PE
36112011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3612
3613 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3614 change.
3615
96fb4434
PE
36162011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3617
3618 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3619 This makes this file independent of the recent pseudovector change.
3620
671875da 36212011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3622
69e9b5a3
PE
3623 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3624
b5f869a7 3625 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3626 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3627 Remove unused local.
c8926152 3628 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3629
841a1577 3630 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3631 GCC 4.6.0 optimizes based on type-based alias analysis.
3632 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3633 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3634 != &v->size, and therefore "v->size = 1; b->size = 2; return
3635 v->size;" must therefore return 1. This assumption is incorrect
3636 for Emacs, since it type-puns struct Lisp_Vector * with many other
3637 types. To fix this problem, this patch adds a new type struct
f904488f 3638 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3639 and pseudovectors, and helps optimizing compilers not get fooled
3640 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3641 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3642 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3643 the size member.
eab3844f
PE
3644 (XSETPVECTYPE): Rewrite in terms of new macro.
3645 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3646 This is a bit clearer, and further avoids the possibility of
3647 undesirable aliasing.
3648 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3649 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3650 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3651 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3652 (ASIZE): Now uses header.size rather than size.
3653 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3654 to avoid the hassle of writing XVECTOR (foo)->header.size.
3655 (struct vectorlike_header): New type.
eab3844f
PE
3656 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3657 object, to help avoid aliasing.
3658 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3659 (SUBRP): Likewise, since Lisp_Subr is a special case.
3660 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3661 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3662 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3663 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3664 changed to be "header.size" and "header.next".
3665 * buffer.h (struct buffer): Likewise.
3666 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3667 * frame.h (struct frame): Likewise.
3668 * process.h (struct Lisp_Process): Likewise.
3669 * termhooks.h (struct terminal): Likewise.
3670 * window.c (struct save_window_data, struct saved_window): Likewise.
3671 * window.h (struct window): Likewise.
3672 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3673 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3674 * buffer.c (init_buffer_once): Likewise.
3675 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3676 special case.
3677 * process.c (Fformat_network_address): Use local var for size,
3678 for brevity.
3679
0df1eac5
PE
3680 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3681
847ab9d1 3682 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3683 * data.c (atof): Remove decl; no longer used or needed.
3684 (digit_to_number): Move to lread.c.
3685 (Fstring_to_number): Use new string_to_number function, to be
3686 consistent with how the Lisp reader treats infinities and NaNs.
3687 Do not assume that floating-point numbers represent EMACS_INT
3688 without losing information; this is not true on most 64-bit hosts.
3689 Avoid double-rounding errors, by insisting on integers when
3690 parsing non-base-10 numbers, as the documentation specifies.
3691 * lisp.h (string_to_number): New decl, replacing ...
3692 (isfloat_string): Remove.
bc0a5c13 3693 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3694 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3695 appears to have been a coding error. Similarly, do not accept
3696 strings like +-1e0 as floating point numbers. Do not report
3697 overflow for integer overflows unless the base is not 10 which
3698 means we have no simple and reliable way to continue.
3699 Break out the floating-point parsing into a new
3700 function string_to_number, so that Fstring_to_number parses
3701 floating point numbers consistently with the Lisp reader.
04f2d78b 3702 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3703 (E_CHAR, EXP_INT): Remove, replacing with ...
3704 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3705 (string_to_number): New function, replacing isfloat_string.
3706 This function checks for valid syntax and produces the resulting
3707 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3708 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3709 so that overflow for non-base-10 numbers is reported only when
3710 there's no portable and simple way to convert to floating point.
452f4150 3711
67769ffc
PE
3712 * textprop.c (set_text_properties_1): Rewrite for clarity,
3713 and to avoid GCC warning about integer overflow.
3714
c20db43f
PE
3715 * intervals.h (struct interval): Use EMACS_INT for members
3716 where EMACS_UINT might cause problems. See
3717 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3718 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3719 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3720 All uses changed.
37aa2f85
PE
3721 (offset_intervals): Tell GCC not to worry about length overflow
3722 when negating a negative length.
c20db43f 3723
2538aa2f
PE
3724 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3725 (overrun_check_free): Likewise.
3726
f2d3008d
PE
3727 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3728 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3729 word size.
3730
ec8df744
PE
3731 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3732 (gnutls_make_error): Rename local to avoid shadowing.
3733 (gnutls_emacs_global_deinit): ifdef out; not used.
3734 (Fgnutls_boot): Use const for pointer to readonly storage.
3735 Comment out unused local. Fix pointer signedness problems.
3736
640ee02d
PE
3737 * lread.c (openp): Don't stuff size_t into an 'int'.
3738 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3739 about possible signed overflow.
3740
6048fb2a
PE
3741 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3742 (GDK_KEY_g): Don't define if already defined.
3743 (xg_prepare_tooltip): Avoid pointer signedness problem.
3744 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3745
fa3c87e1
PE
3746 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3747 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3748
2172544b
PE
3749 * xfns.c (Fx_window_property): Simplify a bit,
3750 to make a bit faster and to avoid GCC 4.6.0 warning.
3751 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3752
9b821a21
PE
3753 * fns.c (internal_equal): Don't assume size_t fits in int.
3754
3c616cfa
PE
3755 * alloc.c (compact_small_strings): Tighten assertion a little.
3756
c2982e87
PE
3757 Replace pEd with more-general pI, and fix some printf arg casts.
3758 * lisp.h (pI): New macro, generalizing old pEd macro to other
3759 conversion specifiers. For example, use "...%"pI"d..." rather
3760 than "...%"pEd"...".
3761 (pEd): Remove. All uses replaced with similar uses of pI.
3762 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3763 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3764 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3765 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3766 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3767 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3768 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3769 64-bit hosts.
3770 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3771 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3772 * print.c (safe_debug_print, print_object): Likewise.
3773 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3774 to int.
6f04d126
PE
3775 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3776 avoiding the 0 flag, which is not portable.
c2982e87
PE
3777 * process.c (Fmake_network_process): Use pI to avoid cast.
3778 * region-cache.c (pp_cache): Likewise.
3779 * xdisp.c (decode_mode_spec): Likewise.
3780 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3781 behavior on 64-bit hosts with printf arg.
6f04d126 3782 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3783 (x_stop_queuing_selection_requests): Likewise.
3784 (x_get_window_property): Don't truncate byte count to an 'int'
3785 when tracing.
0b432f21 3786
5e073ec7
PE
3787 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3788 here, since it parses constructs like leading '-' and spaces,
3789 which are not wanted; and it overflows with large numbers.
3790 Instead, simply match F[0-9]+, which is what is wanted anyway.
3791
36372bf9
PE
3792 * alloc.c: Remove unportable assumptions about struct layout.
3793 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3794 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3795 (allocate_vectorlike, make_pure_vector): Use the new macros,
3796 plus offsetof, to remove unportable assumptions about struct layout.
3797 These assumptions hold on all porting targets that I know of, but
3798 they are not guaranteed, they're easy to remove, and removing them
3799 makes further changes easier.
3800
0b432f21
PE
3801 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3802 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3803 (string_overrun_cookie): Now const. Use initializers that
3804 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3805 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3806 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3807 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3808 multiple of sizeof (EMACS_INT); it need not be, if
3809 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3810 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3811
895009e1
JB
38122011-04-26 Juanma Barranquero <lekktu@gmail.com>
3813
3814 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3815
6a7a1b0b
TZ
38162011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3817
3818 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3819 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3820 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3821
841a1577 38222011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3823
3824 * lisp.h (Qdebug): List symbol.
895009e1 3825 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3826 * keyboard.c (debug-on-event): New variable.
3827 (handle_user_signal): Break into debugger when debug-on-event
3828 matches the current signal symbol.
3829
f2d3ba6f
DN
38302011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3831
3832 * alloc.c (check_sblock, check_string_bytes)
3833 (check_string_free_list): Convert to standard C.
3834
42ce4c63
TZ
38352011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3836
3837 * w32.c (emacs_gnutls_push): Fix typo.
3838
825cd63c
EZ
38392011-04-25 Eli Zaretskii <eliz@gnu.org>
3840
fb11d64d
EZ
3841 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3842 "cast to pointer from integer of different size".
3843
825cd63c
EZ
3844 Improve doprnt and its use in verror. (Bug#8545)
3845 * doprnt.c (doprnt): Document the set of format control sequences
3846 supported by the function. Use SAFE_ALLOCA instead of always
3847 using `alloca'.
3848
3849 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3850 is one byte too soon. Don't use xrealloc; instead xfree and
3851 xmalloc anew.
3852
e061a11b
TZ
38532011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3854
3855 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3856 callbacks stage.
3857
3858 * gnutls.c: Renamed global_initialized to
3859 gnutls_global_initialized. Added internals for the
3860 :verify-hostname-error, :verify-error, and :verify-flags
3861 parameters of `gnutls-boot' and documented those parameters in the
3862 docstring. Start callback support.
9173deec
JB
3863 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3864 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3865 on error. Return error code.
e061a11b
TZ
3866 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3867 (emacs_gnutls_read): Likewise.
3868 (Fgnutls_boot): Return handshake error code.
3869 (emacs_gnutls_handle_error): New function.
3870 (wsaerror_to_errno): Likewise.
3871
3872 * w32.h (emacs_gnutls_pull): Add prototype.
3873 (emacs_gnutls_push): Likewise.
3874
3875 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3876 (emacs_gnutls_push): Likewise.
3877
38782011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3879
3880 * process.c (wait_reading_process_output): Check if GnuTLS
3881 buffered some data internally if no FDs are set for TLS
3882 connections.
3883
3884 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3885 (LIBS): Link to USER_LIBS.
3886 ($(BLD)/gnutls.$(0)): New target.
3887
fa6996bc
EZ
38882011-04-24 Eli Zaretskii <eliz@gnu.org>
3889
eb35682e
EZ
3890 * xdisp.c (handle_single_display_spec): Rename the
3891 display_replaced_before_p argument into display_replaced_p, to
3892 make it consistent with the commentary. Fix typos in the
3893 commentary.
3894
e2ad650c
EZ
3895 * textprop.c (syms_of_textprop): Remove dead code.
3896 (copy_text_properties): Delete obsolete commentary about an
3897 interface that was deleted long ago. Fix typos in the description
3898 of arguments.
3899
1b2de274
EZ
3900 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3901 to changes in oldXMenu/XMenu.h from 2011-04-16.
3902 <menu_help_message, prev_menu_help_message>: Constify.
3903 (IT_menu_make_room): menu->help_text is now `const char **';
3904 adjust.
3905
3906 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3907 to changes in oldXMenu/XMenu.h from 2011-04-16.
3908 (struct XMenu): Declare `help_text' `const char **'.
3909
3910 * xfaces.c <Qunspecified>: Make extern again.
3911
3912 * syntax.c: Include sys/types.h before including regex.h, as
3913 required by Posix.
3914
762b15be
EZ
3915 * doc.c (get_doc_string): Improve the format passed to `error'.
3916
3917 * doprnt.c (doprnt): Improve commentary.
3918
3919 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3920
3921 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3922 them with etags.
3923
f1052e5d
EZ
3924 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3925 changes in globals.h immediately force recompilation.
762b15be
EZ
3926 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3927 $(CURDIR)/s/ms-w32.h.
3928 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3929
fa6996bc
EZ
3930 * character.c (Fchar_direction): Function deleted.
3931 (syms_of_character): Don't defsubr it.
3932 <char-direction-table>: Deleted.
3933
e6c3da20
EZ
39342011-04-23 Eli Zaretskii <eliz@gnu.org>
3935
3936 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3937 * doprnt.c: Include limits.h.
3938 (SIZE_MAX): New macro.
04f2d78b
CB
3939 (doprnt): Return a size_t value. 2nd arg is now size_t.
3940 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3941 Improve overflow protection. Support `l' modifier for integer
3942 conversions. Support %l conversion. Don't assume an EMACS_INT
3943 argument for integer conversions and for %c.
3944
3945 * lisp.h (doprnt): Restore prototype.
3946
3947 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3948 $(SRC)/character.h.
3949
3950 * Makefile.in (base_obj): Add back doprnt.o.
3951
3952 * deps.mk (doprnt.o): Add back prerequisites.
3953 (callint.o): Depend on character.h.
3954
3955 * eval.c (internal_lisp_condition_case): Include the handler
3956 representation in the error message.
3957 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3958 when breaking from the loop.
3959
3960 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3961
3962 * callint.c (Fcall_interactively): When displaying error message
3963 about invalid control letter, pass the character's codepoint, not
3964 a pointer to its multibyte form. Improve display of the character
3965 in octal and display also its hex code.
3966
3967 * character.c (char_string): Use %x to display the (unsigned)
3968 codepoint of an invalid character, to avoid displaying a bogus
3969 negative value.
3970
3971 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3972 `error', not SYMBOL_NAME itself.
3973
3974 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3975 character arguments to `error'.
3976
3977 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3978 to `error' in error message about FINAL_CHAR argument. Make sure
3979 FINAL_CHAR is a character, and use %c when it is passed as
3980 argument to `error'.
3981
4ffd0d6b 39822011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3983
3984 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3985
3986 * w32.c: Include <time.h>.
3987 (sys_localtime): New function.
3988
4ffd0d6b 39892011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3990
3991 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3992
4ffd0d6b 3993 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3994
4ffd0d6b 39952011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3996
4ffd0d6b
GM
3997 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3998 zombies (Bug#8467).
aac0c6e3 3999
04c56954
EZ
40002011-04-19 Eli Zaretskii <eliz@gnu.org>
4001
4002 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4003 gl_state.e_property when gl_state.object is Qt.
4004
4005 * insdel.c (make_gap_larger): Remove limitation of buffer size
4006 to <= INT_MAX.
4007
16a43933
CY
40082011-04-18 Chong Yidong <cyd@stupidchicken.com>
4009
4010 * xdisp.c (lookup_glyphless_char_display)
4011 (produce_glyphless_glyph): Handle cons cell entry in
4012 glyphless-char-display.
4013 (Vglyphless_char_display): Document it.
4014
4015 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4016 glyphless-char-display.
4017
4581706e
CY
40182011-04-17 Chong Yidong <cyd@stupidchicken.com>
4019
4020 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4021
4022 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4023
4024 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4025 definition for no-X builds.
4026
4887c6e2 40272011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4028
fd35b6f9
PE
4029 Static checks with GCC 4.6.0 and non-default toolkits.
4030
5c1ccb01
PE
4031 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4032
006c5daa
PE
4033 * process.c (keyboard_bit_set): Define only if SIGIO.
4034 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4035 (send_process): Repair possible setjmp clobbering.
4036
efc736d3
PE
4037 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4038
4e2fe2e6
PE
4039 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4040
f97334a2
PE
4041 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4042
4e75f29d
PE
4043 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4044 Define only if needed.
4045
90efadd1
PE
4046 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4047 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4048 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4049
3c647824
PE
4050 * dispextern.h (struct redisplay_interface): Rename param
4051 to avoid shadowing.
e264f262 4052 * termhooks.h (struct terminal): Likewise.
761383f4 4053 * xterm.c (xembed_send_message): Likewise.
3c647824 4054
b58c5c4a
PE
4055 * insdel.c (make_gap_smaller): Define only if
4056 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4057
cad59032
PE
4058 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4059 it.
4060
c339dc2e
PE
4061 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4062 so that we aren't warned about unused symbols.
4063
91a3e27b
PE
4064 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4065
399c71d3 4066 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4067
8ffc96f5
PE
4068 * xfns.c (x_real_positions): Mark locals as initialized.
4069
eef9bc79
PE
4070 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4071
098db9dd
PE
4072 * xterm.c: Fix problems found by static analysis with other toolkits.
4073 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4074 (x_dispatch_event): Declare static if USE_GTK, and
4075 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4076 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4077 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4078 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4079 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4080
eb18f6cc
PE
4081 * xmenu.c (menu_help_callback): Pointer type fixes.
4082 Use const pointers when pointing at readonly data. Avoid pointer
4083 signedness clashes.
4084 (FALSE): Remove unused macro.
4085 (update_frame_menubar): Remove unused decl.
4086
1fe72bf8
PE
4087 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4088
60d9e1db
PE
4089 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4090 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4091 (single_menu_item): Rename local to avoid shadowing.
4092
39261c26
PE
4093 * keyboard.c (make_lispy_event): Remove unused local var.
4094
018c5e19
PE
4095 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4096 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4097
63d2b86e
PE
4098 * bitmaps: Change bitmaps from unsigned char back to the X11
4099 compatible char. Avoid the old compiler warnings about
4100 out-of-range initializers by using, for example, '\xab' rather
4101 than 0xab.
4102
aefd87e1
PE
4103 * xgselect.c (xgselect_initialize): Check vs interface
4104 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4105
bf501fb9
PE
4106 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4107
e9829fdf
PE
4108 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4109 to read-only memory.
4110
1086c095
PE
4111 * fns.c (vector): Remove; this old hack is no longer needed.
4112
2baccd04 4113 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4114 Remove unused var.
dde42981 4115 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4116
72391843 4117 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4118
436c16df 4119 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4120 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4121 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4122
92bb796d 4123 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4124 (x_term_init): Remove local to avoid shadowing.
92bb796d 4125
764430a3 4126 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4127
4128 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4129 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4130
d1dfb56c
EZ
41312011-04-16 Eli Zaretskii <eliz@gnu.org>
4132
c4354cb4
EZ
4133 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4134
d1dfb56c
EZ
4135 Fix regex.c, syntax.c and friends for buffers > 2GB.
4136 * syntax.h (struct gl_state_s): Declare character position members
4137 EMACS_INT.
4138
4139 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4140
04f2d78b
CB
4141 * textprop.c (verify_interval_modification, interval_of):
4142 Declare arguments EMACS_INT.
d1dfb56c
EZ
4143
4144 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4145 EMACS_INT.
4146
4147 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4148
4149 * indent.c (Fvertical_motion): Local variable it_start is now
4150 EMACS_INT.
4151
4152 * regex.c (re_match, re_match_2, re_match_2_internal)
4153 (bcmp_translate, regcomp, regexec, print_double_string)
4154 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4155 (re_compile_pattern, re_exec): Declare arguments and local
4156 variables `size_t' and `ssize_t' and return values `regoff_t', as
4157 appropriate.
4158 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4159 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4160 <compile_stack_type>: `size' and `avail' are now `size_t'.
4161
4162 * regex.h <regoff_t>: Use ssize_t, not int.
4163 (re_search, re_search_2, re_match, re_match_2): Arguments that
4164 specify buffer/string position and length are now ssize_t and
4165 size_t. Return type is regoff_t.
4166
613052cd
BK
41672011-04-16 Ben Key <bkey76@gmail.com>
4168
4169 * nsfont.m: Fixed bugs in ns_get_family and
4170 ns_descriptor_to_entity that were caused by using free to
4171 deallocate memory blocks that were allocated by xmalloc (via
4172 xstrdup). This caused Emacs to crash when compiled with
4173 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4174 --enable-checking=xmallocoverrun). xfree is now used to
4175 deallocate these memory blocks.
4176
4170f62f 41772011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4178
71b41406
PE
4179 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4180
9587a89d
PE
4181 emacs_write: Accept and return EMACS_INT for sizes.
4182 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4183 et seq.
4184 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4185 Accept and return EMACS_INT.
4186 (emacs_gnutls_write): Return the number of bytes written on
4187 partial writes.
4188 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4189 (emacs_read, emacs_write): Remove check for negative size, as the
4190 Emacs source code has been audited now.
9587a89d
PE
4191 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4192 (emacs_read, emacs_write): Use it.
273a5f82
PE
4193 * process.c (send_process): Adjust to the new signatures of
4194 emacs_write and emacs_gnutls_write. Do not attempt to store
4195 a byte offset into an 'int'; it might overflow.
9587a89d 4196 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4197
3e047f51
PE
4198 * sound.c: Don't assume sizes fit in 'int'.
4199 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4200 Return EMACS_INT, not int.
3e047f51 4201 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4202 Accept EMACS_INT, not int.
4203 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4204 record read return values.
4205
cc39a9db
BK
42062011-04-15 Ben Key <bkey76@gmail.com>
4207
c9d0ec6d
JB
4208 * keyboard.c (Qundefined): Don't declare static since it is used
4209 in nsfns.m.
4210 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4211 static since they are used in nsfont.m.
cc39a9db 4212
6c60eb9f
SM
42132011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4214
4215 * process.c (Qprocessp): Don't declare static.
4216 * lisp.h (Qprocessp): Declare again.
4217
7990b61a
JB
42182011-04-15 Juanma Barranquero <lekktu@gmail.com>
4219
4220 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4221
5d4cb038
PE
42222011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4223
8bd7b830 4224 Improve C-level modularity by making more things 'static'.
cd64ea1d 4225
e3b27b31
PE
4226 Don't publish debugger-only interfaces to other modules.
4227 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4228 (verify_bytepos, count_markers): Move decls to the only modules
4229 that need them.
4230 * region-cache.h (pp_cache): Likewise.
4231 * window.h (check_all_windows): Likewise.
4232 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4233
5d4cb038
PE
4234 * sysdep.c (croak): Now static, if
4235 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4236 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4237
4238 * alloc.c (refill_memory_reserve): Now static if
4239 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4240 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4241
e87b6180
PE
4242 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4243 Define only if USE_LUCID.
4244
ac64929e
PE
4245 * xrdb.c (x_customization_string, x_rm_string): Now static.
4246
6f37259d
PE
4247 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4248 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4249
1683e3ab
PE
4250 * xdisp.c (draw_row_with_mouse_face): Now static.
4251 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4252
de9c2632
PE
4253 * window.h (check_all_windows): Mark externally visible.
4254
2b96acb7
PE
4255 * window.c (window_deletion_count): Now static.
4256
4257 * undo.c: Make symbols static if they're not exported.
4258 (last_undo_buffer, last_boundary_position, pending_boundary):
4259 Now static.
4260
50436f33
PE
4261 * textprop.c (interval_insert_behind_hooks): Now static.
4262 (interval_insert_in_front_hooks): Likewise.
4263
64520e5c
PE
4264 * term.c: Make symbols static if they're not exported.
4265 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4266 (max_frame_lines, tty_set_terminal_modes):
4267 (tty_reset_terminal_modes, tty_turn_off_highlight):
4268 (get_tty_terminal): Now static.
4269 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4270 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4271 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4272 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4273 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4274
1fa53021
PE
4275 * sysdep.c: Make symbols static if they're not exported.
4276 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4277 Now static.
4278 (sigprocmask_set, full_mask): Remove; unused.
4279 (wait_debugging): Mark as visible.
4280 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4281 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4282
d4b43b22
PE
4283 * syntax.c (syntax_temp): Define only if !__GNUC__.
4284
b7c513d0
PE
4285 * sound.c (current_sound_device, current_sound): Now static.
4286
989b29ad
PE
4287 * search.c (searchbufs, searchbuf_head): Now static.
4288
13a55a78
PE
4289 * scroll.c (scroll_cost): Remove; unused.
4290 * dispextern.h (scroll_cost): Remove decl.
4291
de68a1fc
PE
4292 * region-cache.h (pp_cache): Mark as externally visible.
4293
40ccffa6
PE
4294 * process.c: Make symbols static if they're not exported.
4295 (process_tick, update_tick, create_process, chan_process):
4296 (Vprocess_alist, proc_buffered_char, datagram_access):
4297 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4298 (deactivate_process): Mark defn as static, as well as decl.
4299 * lisp.h (create_process): Remove decl.
4300 * process.h (chan_process, Vprocess_alist): Remove decls.
4301
ad64fc97
PE
4302 * print.c: Make symbols static if they're not exported.
4303 (print_depth, new_backquote_output, being_printed, print_buffer):
4304 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4305 (print_interval, print_number_index, initial_stderr_stream):
4306 Now static.
4307 * lisp.h (Fprinc): Remove decl.
4308 (debug_output_compilation_hack): Mark as externally visible.
4309
adddb265
PE
4310 * sysdep.c (croak): Move decl from here to syssignal.h.
4311 * syssignal.h (croak): Put it here, so the API can be checked when
4312 'croak' is called from dissociate_if_controlling_tty.
4313
1717ede2
PE
4314 * minibuf.c: Make symbols static if they're not exported.
4315 (minibuf_save_list, choose_minibuf_frame): Now static.
4316 * lisp.h (choose_minibuf_frame): Remove decl.
4317
fa5fb2bc
PE
4318 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4319
1e3890d1
PE
4320 * lread.c: Make symbols static if they're not exported.
4321 (read_objects, initial_obarray, oblookup_last_bucket_number):
4322 Now static.
4323 (make_symbol): Remove; unused.
4324 * lisp.h (initial_obarray, make_symbol): Remove decls.
4325
8a1414fa
PE
4326 * keyboard.c: Make symbols static if they're not exported.
4327 (single_kboard, recent_keys_index, total_keys, recent_keys):
4328 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4329 (this_single_command_key_start, echoing, last_auto_save):
4330 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4331 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4332 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4333 (Vlispy_mouse_stem, double_click_count):
4334 Now static.
4335 (force_auto_save_soon): Define only if SIGDANGER.
4336 (ignore_mouse_drag_p): Now static if
4337 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4338 (print_help): Remove; unused.
4339 (stop_character, last_timer_event): Mark as externally visible.
4340 * keyboard.h (ignore_mouse_drag_p): Declare only if
4341 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4342 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4343 * lisp.h (echoing): Remove decl.
4344 (force_auto_save_soon): Declare only if SIGDANGER.
4345 * xdisp.c (redisplay_window): Simplify code, to make it more
4346 obvious that ignore_mouse_drag_p is not accessed if !defined
4347 USE_GTK && !defined HAVE_NS.
4348
93ea6e8f
PE
4349 * intervals.c: Make symbols static if they're not exported.
4350 (merge_properties_sticky, merge_interval_right, delete_interval):
4351 Now static.
4352 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4353
77382fcc
PE
4354 * insdel.c: Make symbols static if they're not exported.
4355 However, leave prepare_to_modify_buffer alone. It's never
4356 called from outside this function, but that appears to be a bug.
4357 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4358 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4359 (adjust_after_replace_noundo): Remove; unused.
4360 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4361 (signal_before_change): Remove decls.
77382fcc 4362
9306c32e
PE
4363 * indent.c (val_compute_motion, val_vmotion): Now static.
4364
cd44d2eb
PE
4365 * image.c: Make symbols static if they're not exported.
4366 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4367 if USE_GTK.
4368 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4369 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4370
ad9a7a06
PE
4371 * fringe.c (standard_bitmaps): Now static.
4372 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4373
81626931
PE
4374 * frame.c: Make symbols static if they're not exported.
4375 (x_report_frame_params, make_terminal_frame): Now static.
4376 (get_frame_param): Now static, unless HAVE_NS.
4377 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4378 (x_get_resource_string): Remove; not used.
4379 * frame.h (make_terminal_frame, x_report_frame_params):
4380 (x_get_resource_string); Remove decls.
4381 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4382 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4383
239f9db9
PE
4384 * font.c, fontset.c: Make symbols static if they're not exported.
4385 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4386 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4387 * font.c (font_close_object): Now static.
4388 * font.h (font_close_object): Remove.
4389 * fontset.c (FONTSET_OBJLIST): Remove.
4390 (free_realized_fontset) #if-0 the body, which does nothing.
4391 (face_suitable_for_char_p): #if-0, as it's never called.
4392 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4393 * xfaces.c (face_at_string_position):
4394 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4395 since 0 is always ASCII.
4396
dfcf3579
PE
4397 * fns.c (weak_hash_tables): Now static.
4398
5045092b
PE
4399 * fileio.c: Make symbols static if they're not exported.
4400 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4401 (Vwrite_region_annotation_buffers): Now static.
4402
57a96f5c
PE
4403 * eval.c: Make symbols static if they're not exported.
4404 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4405 * lisp.h (backtrace_list): Remove decl.
4406
35f08c38
PE
4407 * emacs.c: Make symbols static if they're not exported.
4408 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4409 (fatal_error_code, fatal_error_signal_hook, standard_args):
4410 Now static.
4411 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4412 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4413 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4414 * lisp.h (fatal_error_signal_hook): Remove decl.
4415 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4416
f44bd759
PE
4417 * editfns.c: Move a (normally-unused) function to its only use.
4418 * editfns.c, lisp.h (get_operating_system_release): Remove.
4419 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4420 worth the hassle of breaking this out.
4421
b532497d
PE
4422 * xterm.c: Make symbols static if they're not exported.
4423 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4424 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4425 (x_destroy_window, x_delete_display):
4426 Now static.
4427 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4428 (x_mouse_leave): Remove; unused.
4429 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4430 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4431 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4432 Remove decls.
4433 (x_mouse_leave): Declare only if WINDOWSNT.
4434 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4435 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4436 USE_X_TOOLKIT.
4437
1675728f
PE
4438 * ftxfont.c: Make symbols static if they're not exported.
4439 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4440 HAVE_FREETYPE.
4441 * font.h (ftxfont_driver): Likewise.
4442
e4cebfca
PE
4443 * xfns.c: Make symbols static if they're not exported.
4444 (x_last_font_name, x_display_info_for_name):
4445 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4446 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4447 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4448 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4449 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4450 (last_show_tip_args): Now static.
4451 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4452 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4453 (x_screen_planes): Remove; unused.
4454 * dispextern.h (x_screen_planes): Remove decl.
4455
5bf46f05
PE
4456 * dispnew.c: Make symbols static if they're not exported.
4457 * dispextern.h (redraw_garbaged_frames, scrolling):
4458 (increment_row_positions): Remove.
4459 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4460 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4461 Now static.
4462 (redraw_garbaged_frames): Remove; unused.
4463
435f4c28
PE
4464 * xfaces.c: Make symbols static if they're not exported.
4465 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4466 Remove decls.
4467 * xterm.h (defined_color): Remove decls.
4468 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4469 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4470 (menu_face_changed_default, defined_color, free_realized_face):
4471 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4472 (ascii_face_of_lisp_face): Remove; unused.
4473
8524aef3
PE
4474 * xdisp.c: Make symbols static if they're not exported.
4475 * dispextern.h (scratch_glyph_row, window_box_edges):
4476 (glyph_to_pixel_coords, set_cursor_from_row):
4477 (get_next_display_element, set_iterator_to_next):
4478 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4479 (show_mouse_face): Remove decls
4480 * frame.h (message_buf_print): Likewise.
4481 * lisp.h (pop_message, set_message, check_point_in_composition):
4482 Likewise.
4483 * xterm.h (set_vertical_scroll_bar): Likewise.
4484 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4485 (message_buf_print, scratch_glyph_row, displayed_buffer):
4486 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4487 (get_next_display_element, show_mouse_face, window_box_edges):
4488 (frame_to_window_pixel_xy, check_point_in_composition):
4489 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4490 (glyph_to_pixel_coords): Remove; unused.
4491
16390cd2
PE
4492 * dired.c (file_name_completion): Now static.
4493
4494 * dbusbind.c (xd_in_read_queued_messages): Now static.
4495
a25f4dfa
PE
4496 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4497 * data.c (circular_list_error): Remove.
4498
14a9c8df
PE
4499 * commands.h (last_point_position, last_point_position_buffer):
4500 (last_point_position_window): Remove decls.
4501 * keyboard.c: Make these variables static.
4502
04f2d78b
CB
4503 * coding.h (coding, code_convert_region, encode_coding_gap):
4504 Remove decls.
74ab6df5
PE
4505 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4506 (iso_code_class, detect_coding, code_convert_region): Now static.
4507 (encode_coding_gap): Remove; unused.
4508
38dfbee1
PE
4509 * chartab.c (chartab_chars, chartab_bits): Now static.
4510
a2cb4e63
PE
4511 * charset.h (charset_iso_8859_1): Remove decl.
4512 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4513 Now static.
4514
127198fd
PE
4515 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4516 * ccl.c (Vccl_program_table): Now static.
4517 (check_ccl_update): Remove; unused.
4518
d85b608f
PE
4519 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4520 * category.h: ... from here.
4521 * category.c (check_category_table, set_category_set): Now static.
4522
31cd66f3
PE
4523 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4524 * lisp.h: Remove these decls.
4525
c358e587
PE
4526 * buffer.c (buffer_count): Remove unused var.
4527
e78aecca
PE
4528 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4529 so that it's not optimized away.
4530 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4531 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4532 exported only to the debugger.
4533
e192d7d3 4534 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4535 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4536
92470028
PE
4537 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4538 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4539 was inaccessible from Lisp.
4540 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4541 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4542
244ed907
PE
4543 alloc.c: Import and export fewer symbols, and remove unused items.
4544 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4545 is defined.
4546 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4547 it's not optimized away by whole-program optimization.
4548 (message_enable_multibyte, free_misc): Remove.
4549 (catchlist, handlerlist, mark_backtrace):
4550 Declare only if BYTE_MARK_STACK.
4551 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4552 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4553 (message_enable_multibyte): Remove decl.
4554 (free_misc, interval_free_list, float_block, float_block_index):
4555 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4556 (cons_free_list, last_marked_index):
4557 Now static.
4558 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4559 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4560 (mark_backtrace): Define only if BYTE_MARK_STACK.
4561 * xdisp.c (message_enable_multibyte): Now static.
4562
61c2b50e 4563 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4564 This makes it easier for human readers (and static analyzers)
4565 to see whether these variables are used from other modules.
4566 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4567 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4568 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4569 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4570 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4571 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4572 * xmenu.c, xselect.c:
4573 Declare Q* vars static if they are not used in other modules.
4574 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4575 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4576 Remove decls of unexported vars.
4577 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4578
95c82688
PE
4579 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4580
16a97296
PE
4581 Make Emacs functions such as Fatom 'static' by default.
4582 This makes it easier for human readers (and static analyzers)
4583 to see whether these functions can be called from other modules.
4584 DEFUN now defines a static function. To make the function external
4585 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4586 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4587 (Finit_image_library):
16a97296
PE
4588 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4589 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4590 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4591 Remove decls, since these functions are now static.
4592 (Funintern, Fget_internal_run_time): New decls, since these functions
4593 were already external.
95c82688 4594
16a97296
PE
4595 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4596 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4597 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4598 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4599 * keyboard.c, keymap.c, lread.c:
4600 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4601 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4602 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4603 Mark functions with DEFUE instead of DEFUN,
4604 if they are used in other modules.
4605 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4606 decls for now-static functions.
4607 * buffer.h (Fdelete_overlay): Remove decl.
4608 * callproc.c (Fgetenv_internal): Mark as internal.
4609 * composite.c (Fremove_list_of_text_properties): Remove decl.
4610 (Fcomposition_get_gstring): New forward static decl.
4611 * composite.h (Fcomposite_get_gstring): Remove decl.
4612 * dired.c (Ffile_attributes): New forward static decl.
4613 * doc.c (Fdocumntation_property): New forward static decl.
4614 * eval.c (Ffetch_bytecode): New forward static decl.
4615 (Funintern): Remove extern decl; now in .h file where it belongs.
4616 * fileio.c (Fmake_symbolic_link): New forward static decl.
4617 * image.c (Finit_image_library): New forward static decl.
4618 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4619 * intervals.h (Fprevious_property_change):
4620 (Fremove_list_of_text_properties): Remove decls.
4621 * keyboard.c (Fthis_command_keys): Remove decl.
4622 (Fcommand_execute): New forward static decl.
4623 * keymap.c (Flookup_key): New forward static decl.
4624 (Fcopy_keymap): Now static.
4625 * keymap.h (Flookup_key): Remove decl.
4626 * process.c (Fget_process): New forward static decl.
4627 (Fprocess_datagram_address): Mark as internal.
4628 * syntax.c (Fsyntax_table_p): New forward static decl.
4629 (skip_chars): Remove duplicate decl.
4630 * textprop.c (Fprevious_property_change): New forward static decl.
4631 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4632 Now internal.
4633 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4634 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4635
785bbd42
PE
4636 * editfns.c (Fformat): Remove unreachable code.
4637
8b913b57
AS
46382011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4639
4640 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4641 change. (Bug#8496)
4642
a6744a35
EZ
46432011-04-13 Eli Zaretskii <eliz@gnu.org>
4644
4645 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4646 when at ZV. (Bug#8487)
4647
e7974947
AS
46482011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4649
baad03f0
AS
4650 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4651 (Bug#8437)
4652 * keyboard.c (parse_tool_bar_item): Likewise.
4653 * sound.c (sound_cleanup, alsa_close): Likewise.
4654 * termcap.c (tgetent): Likewise.
4655 * xfns.c (x_default_font_parameter): Likewise.
4656 * xsettings.c (read_and_apply_settings): Likewise.
4657
e7974947
AS
4658 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4659 (overrun_check_free): Protoize.
4660
28272684
PE
46612011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4662
4663 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4664 since callers should never pass a negative size.
4665 Change the signature to match that of plain 'read' and 'write'; see
4666 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4667 * lisp.h: Update prototypes of emacs_write and emacs_read.
4668
11997c76
EZ
46692011-04-11 Eli Zaretskii <eliz@gnu.org>
4670
4671 * xdisp.c (redisplay_window): Don't try to determine the character
4672 position of the scroll margin if the window start point w->startp
e896f03c 4673 is outside the buffer's accessible region. (Bug#8468)
11997c76 4674
8a2cbd72
EZ
46752011-04-10 Eli Zaretskii <eliz@gnu.org>
4676
4677 Fix write-region and its subroutines for buffers > 2GB.
4678 * fileio.c (a_write, e_write): Modify declaration of arguments and
4679 local variables to support buffers larger than 2GB.
4680 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4681
4682 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4683 argument, local variables, and return value.
4684
4685 * lisp.h: Update prototypes of emacs_write and emacs_read.
4686
4687 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4688
4073e537 46892011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4690
1ebfdcb6
PE
4691 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4692
b2ded58d
PE
4693 Fix more problems found by GCC 4.6.0's static checks.
4694
7d66342c
PE
4695 * xdisp.c (vmessage): Use a better test for character truncation.
4696
bbf47d44
PE
4697 * charset.c (load_charset_map): <, not <=, for optimization,
4698 and to avoid potential problems with integer overflow.
9248994d 4699 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4700 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4701 * editfns.c (Fformat): Likewise.
1e69125e 4702 * syntax.c (skip_chars): Likewise.
3befa583 4703
e3019616
PE
4704 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4705 This also lets GCC 4.6.0 generate slightly better loop code.
4706
becfa255
PE
4707 * callint.c (Fcall_interactively): <, not <=, for optimization.
4708 (Fcall_interactively): Count the number of arguments produced,
4709 not the number of arguments given. This is simpler and lets GCC
4710 4.6.0 generate slightly better code.
4711
dae0cd48
PE
4712 * ftfont.c: Distingish more carefully between FcChar8 and char.
4713 The previous code passed unsigned char * to a functions like
4714 strlen and xstrcasecmp that expect char *, which does not
4715 conform to the C standard.
4716 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4717 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4718 char * when the C standard requires it.
4719
76032d70
PE
4720 * keyboard.c (read_char): Remove unused var.
4721
eb3f1cc8
PE
4722 * eval.c: Port to Windows vsnprintf (Bug#8435).
4723 Include <limits.h>.
4724 (SIZE_MAX): Define if the headers do not.
4725 (verror): Do not give up if vsnprintf returns a negative count.
4726 Instead, grow the buffer. This ports to Windows vsnprintf, which
4727 does not conform to C99. Problem reported by Eli Zaretskii.
4728 Also, simplify the allocation scheme, by avoiding the need for
4729 calling realloc, and removing the ALLOCATED variable.
4730
70476b54
PE
4731 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4732
12020a9e
PE
4733 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4734 But keep the doprint source code for now, as we might revamp it
4735 and use it again (Bug#8435).
ea6c7ae6
PE
4736 * lisp.h (doprnt): Remove.
4737 * Makefile.in (base_obj): Remove doprnt.o.
4738 * deps.mk (doprnt.o): Remove.
4739
5fdb398c
PE
4740 error: Print 32- and 64-bit integers portably (Bug#8435).
4741 Without this change, on typical 64-bit hosts error ("...%d...", N)
4742 was used to print both 32- and 64-bit integers N, which relied on
4743 undefined behavior.
4744 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4745 New macro.
4746 * lisp.h (error, verror): Mark as printf-like functions.
4747 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4748 Report overflow in size calculations when allocating printf buffer.
4749 Do not truncate output string at its first null byte.
4750 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4751 Truncate the output at a character boundary, since vsnprintf does not
4752 do that.
4753 * charset.c (check_iso_charset_parameter): Convert internal
4754 character to string before calling 'error', since %c now has the
4755 printf meaning.
4756 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4757 overflow when computing char to be passed to 'error'. Do not
4758 pass Lisp_Object to 'error'; pass the integer instead.
4759 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4760 formatted with plain %d.
4761
b189fa66
PE
4762 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4763
bff87ef0
PE
4764 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4765
7e2cac20
PE
4766 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4767
ce4d90b5
PE
4768 * xterm.c (x_catch_errors): Remove duplicate declaration.
4769
266c9547
PE
4770 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4771
79c49ad2
PE
4772 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4773
368f4090
JM
47742011-04-10 Jim Meyering <meyering@redhat.com>
4775
4776 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4777 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4778 return ssize_t not "int", and use size_t as the buffer length.
4779 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4780 * gnutls.h: Update declarations.
4781 * process.c (read_process_output): Use ssize_t, to match.
4782 (send_process): Likewise.
4783
a32d4040
CY
47842011-04-09 Chong Yidong <cyd@stupidchicken.com>
4785
4786 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4787
8546720e 47882011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4789
04f2d78b
CB
4790 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4791 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4792
8546720e
GM
4793 * xterm.c (handle_one_xevent):
4794 * xmenu.c (create_and_show_popup_menu):
4795 * xselect.c (x_decline_selection_request)
4796 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4797
0a2f5c1a 47982011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4799
4800 Fix some uses of `int' instead of EMACS_INT.
4801 * search.c (string_match_1, fast_string_match)
4802 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4803 (scan_buffer, find_next_newline_no_quit)
4804 (find_before_next_newline, search_command, Freplace_match)
4805 (Fmatch_data): Make some `int' variables be EMACS_INT.
4806
4807 * xdisp.c (display_count_lines): 3rd argument and return value now
4808 EMACS_INT. All callers changed.
4809 (pint2hrstr): Last argument is now EMACS_INT.
4810
4811 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4812 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4813 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4814 (decode_coding_utf_16, decode_coding_emacs_mule)
4815 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4816 (decode_coding_ccl, decode_coding_charset)
4817 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4818 (decode_coding_iso_2022, decode_coding_emacs_mule)
4819 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4820 <char_offset, last_offset>: Declare EMACS_INT.
4821 (encode_coding_utf_8, encode_coding_utf_16)
4822 (encode_coding_emacs_mule, encode_invocation_designation)
4823 (encode_designation_at_bol, encode_coding_iso_2022)
4824 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4825 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4826 Declare EMACS_INT.
4827 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4828 (encode_invocation_designation): Last argument P_NCHARS is now
4829 EMACS_INT.
4830 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4831 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4832
4833 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4834 All users changed.
4835
4836 * ccl.c (Fccl_execute_on_string): Declare some variables
4837 EMACS_INT.
4838
8546720e 48392011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4840
4841 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4842
4e19a977
CS
48432011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4844
4845 * process.c (Fformat_network_address): Doc fix.
4846
87302331
R
48472011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4848
4849 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4850
cbb59342
CY
48512011-04-08 Chong Yidong <cyd@stupidchicken.com>
4852
4853 * keyboard.c (read_char): Call Lisp function help-form-show,
4854 instead of using internal_with_output_to_temp_buffer.
4855 (Qhelp_form_show): New var.
e0d38eeb 4856 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4857
4858 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4859
4860 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4861
e67a13ab
CY
48622011-04-06 Chong Yidong <cyd@stupidchicken.com>
4863
04f2d78b
CB
4864 * process.c (Flist_processes): Remove to Lisp.
4865 (list_processes_1): Delete.
e67a13ab 4866
973f782d
EZ
48672011-04-06 Eli Zaretskii <eliz@gnu.org>
4868
7c106b1e
EZ
4869 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4870
973f782d
EZ
4871 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4872
41cf7d1a 48732011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4874
ca23cc88
PE
4875 Fix more problems found by GCC 4.6.0's static checks.
4876
f390e2d5
PE
4877 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4878
42eea0d0
PE
4879 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4880
b69769da 4881 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4882
f9541e84
PE
4883 * xdisp.c (vmessage): Mark as a printf-like function.
4884
13841b55
PE
4885 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4886
c136c10f
PE
4887 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4888
5e2d4a30
PE
4889 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4890 printf-like functions.
4891 (tiff_load): Add casts to remove these marks before passing them
4892 to system-supplied API.
4893
583f48b9
PE
4894 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4895
b25d760e
PE
4896 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4897 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4898 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4899 directly, rather than having caller test rule sign. This avoids
4900 some unnecessary tests.
4901 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4902 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4903 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4904
bc7b6697 4905 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4906 (xfont_open): Avoid unnecessary tests.
bc7b6697 4907
27ccc379
PE
4908 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4909
dcd5c89a
PE
4910 * composite.h, composite.c (composition_gstring_put_cache):
4911 Use EMACS_INT, not int, for length.
4912
b13a45c6
PE
4913 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4914 breaking out part of COMPOSITION_DECODE_RULE.
4915 (COMPOSITION_DECODE_RULE): Use it.
4916 * composite.c (get_composition_id): Remove unused local vars,
4917 by using the new macro.
4918
1e792e4d
PE
4919 * textprop.c (set_text_properties_1): Change while to do-while,
4920 since the condition is always true at first.
4921
dc6c6455 4922 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4923 (interval_deletion_adjustment): Return unsigned value.
4924 All uses changed.
dc6c6455 4925
aba7731a
PE
4926 * process.c (list_processes_1, create_pty, read_process_output):
4927 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4928 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4929 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4930 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4931 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4932
fdfc4bf3
PE
4933 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4934
fca8fe46 4935 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4936 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4937
06a0259a 4938 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4939 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4940 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4941
e7b9e80f
PE
4942 * print.c (print_error_message): Avoid int overflow.
4943
56201685
PE
4944 * font.c (font_list_entities): Redo for clarity,
4945 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4946
78834453 4947 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4948 (font_score): Avoid potential overflow in diff calculation.
78834453 4949
0bc0b309 4950 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4951 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4952
e610eaca
PE
4953 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4954
b895abce
PE
4955 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4956 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4957 can always succeed if overflow has undefined behavior.
4958
1f1d9321 4959 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4960 (wordify): Omit three unnecessary tests.
1f1d9321 4961
c59478bc
PE
4962 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4963 All callers changed. This avoids the need for an unused var.
4964
79b73827
PE
4965 * casefiddle.c (casify_region): Remove var that is set but not used.
4966
a4db5dfe
PE
4967 * dired.c (file_name_completion): Remove var that is set but not used.
4968
43aae36e
PE
4969 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4970
2a47c44d 4971 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4972 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4973
a37c69bf
PE
4974 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4975 Check for integer overflow on size calculations.
4976
328ab8e7
PE
4977 * buffer.c (Fprevious_overlay_change): Remove var that is set
4978 but not used.
4979
e5a2a5cb
PE
4980 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4981 Remove vars that are set but not used.
8d84a6eb 4982 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4983 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4984
a60e5f68
PE
4985 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4986
f661cb61 4987 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4988 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4989
f0397f5a
PE
4990 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4991 that are set but not used.
4992
8664db06 4993 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4994 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4995
6abdaa4a
PE
4996 * xselect.c (x_get_local_selection, x_handle_property_notify):
4997 Remove vars that are set but not used.
4998
0ce7538d 4999 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5000 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5001
9ae848fc
PE
5002 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5003 Remove var that is set but not used.
0b918413
PE
5004 (scroll_bar_windows_size): Now size_t, not int.
5005 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5006 Check for overflow.
9ae848fc 5007
a5a62657
PE
5008 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5009 (map_tty_color) [!defined MSDOS]: Likewise.
5010
5c5cdd39
PE
5011 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5012
66ebf983
PE
5013 * coding.c: Remove vars that are set but not used.
5014 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5015 All callers changed.
5016 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5017 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5018 (decode_coding_charset): Remove vars that are set but not used.
5019
1be4d761
PE
5020 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5021 that is set but not used.
5022
47553fa8
PE
5023 * print.c (print_object): Remove var that is set but not used.
5024
1f7196bf 5025 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5026 The gnulib version avoids calling malloc in the usual case,
5027 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5028 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5029 * filelock.c (current_lock_owner): Likewise.
5030 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5031 * sysdep.c: Include allocator.h, careadlinkat.h.
5032 (emacs_no_realloc_allocator): New static constant.
5033 (emacs_readlink): New function.
fdb61804
PE
5034 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5035 ../lib/careadlinkat.h.
d1fdcab7 5036
f84c17c7
SM
50372011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5038
5039 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5040 first non-nil return value).
5041
ef3862ad
JD
50422011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5043
5044 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5045 if not defined (Bug#8403).
5046
376a7006
JB
50472011-04-02 Juanma Barranquero <lekktu@gmail.com>
5048
5049 * xdisp.c (display_count_lines): Remove parameter `start',
5050 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5051 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5052 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5053 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5054 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5055 and thereabouts. All callers changed.
5056 (get_per_char_metric): Remove parameter `f', unused since
5057 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5058
6ca3801d
JM
50592011-04-02 Jim Meyering <meyering@redhat.com>
5060
5061 do not dereference NULL upon failed strdup
5062 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5063 (ns_get_family): Likewise.
5064
d8e2b5ba
JB
50652011-04-02 Juanma Barranquero <lekktu@gmail.com>
5066
5067 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5068
8c74fcbd
JD
50692011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5070
5071 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5072 later (Bug#8403).
5073
7200d79c
SM
50742011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5075
03408648 5076 Add lexical binding.
7200d79c 5077
03408648
SM
5078 * window.c (Ftemp_output_buffer_show): New fun.
5079 (Fsave_window_excursion):
5080 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5081
5082 * lread.c (lisp_file_lexically_bound_p): New function.
5083 (Fload): Bind Qlexical_binding.
5084 (readevalloop): Remove `evalfun' arg.
5085 Bind Qinternal_interpreter_environment.
5086 (Feval_buffer): Bind Qlexical_binding.
5087 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5088 Mark as dynamic.
5089 (syms_of_lread): Declare `lexical-binding'.
5090
5091 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5092
5093 * keyboard.c (eval_dyn): New fun.
5094 (menu_item_eval_property): Use it.
ca105506
SM
5095
5096 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5097
03408648
SM
5098 * fns.c (concat, mapcar1): Accept byte-code-functions.
5099
5100 * eval.c (Fsetq): Handle lexical vars.
5101 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5102 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5103 (FletX, Flet): Obey lexical binding.
5104 (Fcommandp): Handle closures.
5105 (Feval): New `lexical' arg.
5106 (eval_sub): New function extracted from Feval. Use it almost
5107 everywhere where Feval was used. Look up vars in lexical env.
5108 Handle closures.
5109 (Ffunctionp): Move from subr.el.
5110 (Ffuncall): Handle closures.
5111 (apply_lambda): Remove `eval_flags'.
5112 (funcall_lambda): Handle closures and new byte-code-functions.
5113 (Fspecial_variable_p): New function.
5114 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5115 but without exporting it to Lisp.
23aba0ea 5116
23aba0ea 5117 * doc.c (Fdocumentation, store_function_docstring):
03408648 5118 * data.c (Finteractive_form): Handle closures.
23aba0ea 5119
03408648
SM
5120 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5121 interactive spec.
ba83908c 5122
04f2d78b
CB
5123 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5124 New byte-codes.
03408648
SM
5125 (exec_byte_code): New function extracted from Fbyte_code to handle new
5126 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5127
03408648 5128 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5129
03408648 5130 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5131
e2abce01
JB
51322011-03-31 Juanma Barranquero <lekktu@gmail.com>
5133
5134 * xdisp.c (redisplay_internal): Fix prototype.
5135
63696a73 51362011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5137
63696a73 5138 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5139 (try_scrolling): Use it when setting scroll_limit.
5140 Limit scrolling to 100 screen lines.
63696a73
EZ
5141 (redisplay_window): Even when falling back on "recentering",
5142 position point in the window according to scroll-conservatively,
5143 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5144
5145 (try_scrolling): When point is above the window, allow searching
5146 as far as scroll_max, or one screenful, to compute vertical
5147 distance from PT to the scroll margin position. This prevents
5148 try_scrolling from unnecessarily failing when
5149 scroll-conservatively is set to a value slightly larger than the
5150 window height. Clean up the case of PT below the margin at bottom
5151 of window: scroll_max can no longer be INT_MAX. When aggressive
5152 scrolling is in use, don't let point enter the opposite scroll
5153 margin as result of the scroll.
5154 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5155 threshold of 100 lines for never-recentering scrolling.
5156
e4cc2dfc
JB
51572011-03-31 Juanma Barranquero <lekktu@gmail.com>
5158
5159 * dispextern.h (move_it_by_lines):
5160 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5161 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5162 (message_log_check_duplicate): Remove parameters `prev_bol' and
5163 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5164 (redisplay_internal): Remove parameter `preserve_echo_area',
5165 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5166
5167 * indent.c (Fvertical_motion):
5168 * window.c (window_scroll_pixel_based, Frecenter):
5169 Don't pass `need_y_p' to `move_it_by_lines'.
5170
1c470562
SM
51712011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5172
44f230aa
SM
5173 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5174 steal a few bits to be more compact.
5175 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5176 Remove unneeded casts.
5177
1c470562
SM
5178 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5179
888adce9
ZK
51802011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5181
5182 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5183 binding" message (bug#7967).
5184
f838ed7b
PE
51852011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5186
77861b95
PE
5187 Fix more problems found by GCC 4.6.0's static checks.
5188
de6dbc14
PE
5189 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5190 Remove unused local var.
5191
f838ed7b
PE
5192 * editfns.c (Fmessage_box): Remove unused local var.
5193
792c7b2b
PE
5194 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5195 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5196 Omit unused local vars.
c499e557 5197 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5198 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5199 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5200 Omit unused local var.
5201
ba0165e1
PE
5202 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5203 Don't assume string length fits in int.
32ad8845 5204 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5205 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5206
3c59b4c9
PE
5207 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5208 instead of alloca (Bug#8344).
5209
a3eed478 5210 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5211 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5212
eb4d412d
PE
5213 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5214
1658b401
PE
5215 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5216 concerns.
5217
5218 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5219
5220 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5221
9a2c6e05
PE
5222 * keyboard.c (syms_of_keyboard): Use the same style as later
5223 in this function when indexing through an array. This also
5224 works around GCC bug 48267.
5225
03d0a109
PE
5226 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5227
44f730c8
PE
5228 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5229
fe75f926
PE
5230 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5231 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5232
ffa8c828
PE
5233 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5234 This avoids undefined behavior on integer overflow, and is a bit
5235 more convenient anyway since it is compared to a size_t variable.
5236
c5101a77
PE
5237 Variadic C functions now count arguments with size_t, not int.
5238 This avoids an unnecessary limitation on 64-bit machines, which
5239 caused (substring ...) to crash on large vectors (Bug#8344).
5240 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5241 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5242 All variadic functions and their callers changed accordingly.
c5101a77
PE
5243 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5244 * data.c (arith_driver, float_arith_driver): Likewise.
5245 * editfns.c (general_insert_function): Likewise.
5246 * eval.c (struct backtrace.nargs, interactive_p)
5247 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5248 (funcall_lambda, mark_backtrace): Likewise.
5249 * fns.c (concat): Likewise.
5250 * frame.c (x_set_frame_parameters): Likewise.
5251 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5252 0 if not found, not -1. All callers changed.
5253
dd3f25f7
PE
5254 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5255 (stack_copy_size): Now size_t, not int.
5256 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5257
461c2ab9
JB
52582011-03-28 Juanma Barranquero <lekktu@gmail.com>
5259
5260 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5261 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5262 All callers changed.
5263
5264 * lisp.h (multibyte_char_to_unibyte):
5265 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5266 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5267 * character.h (CHAR_TO_BYTE8):
5268 * cmds.c (internal_self_insert):
5269 * editfns.c (general_insert_function):
5270 * keymap.c (push_key_description):
5271 * search.c (Freplace_match):
5272 * xdisp.c (message_dolog, set_message_1): All callers changed.
5273
f6d62986
SM
52742011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5275
5276 * keyboard.c (safe_run_hook_funcall): New function.
5277 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5278 don't set the hook to nil, but remove the offending function instead.
5279 (Qcommand_hook_internal): Remove, unused.
5280 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5281 Vcommand_hook_internal.
5282
5283 * eval.c (enum run_hooks_condition): Remove.
5284 (funcall_nil, funcall_not): New functions.
5285 (run_hook_with_args): Call each function through a `funcall' argument.
5286 Remove `cond' argument, now redundant.
5287 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5288 (Frun_hook_with_args_until_failure): Adjust accordingly.
5289 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5290
1db5b1ad
JB
52912011-03-28 Juanma Barranquero <lekktu@gmail.com>
5292
5293 * dispextern.h (string_buffer_position): Remove declaration.
5294
5295 * print.c (strout): Remove parameter `multibyte', unused since
5296 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5297
5298 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5299 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5300 All callers changed.
5301
5302 * w32.c (_wsa_errlist): Use braces for struct initializers.
5303
5304 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5305 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5306 All callers changed.
5307 (string_buffer_position): Likewise. Also, make static (it's never
5308 used outside xdisp.c).
5309 (cursor_row_p): Remove parameter `w', unused since
5310 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5311 (decode_mode_spec): Remove parameter `precision', introduced during
5312 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5313 All callers changed.
5314
5ffb62aa
JD
53152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5316
5317 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5318
461c2ab9 53192011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5320
5321 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5322 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5323 (ns_update_auto_hide_menu_bar): New functions.
5324 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5325 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5326 ns_constrain_all_frames.
5327 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5328 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5329
5c380ffb
JD
53302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5331
5332 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5333
9af30bdf
GM
53342011-03-27 Glenn Morris <rgm@gnu.org>
5335
5336 * syssignal.h: Replace RETSIGTYPE with void.
5337 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5338 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5339 Replace SIGTYPE with void everywhere.
5340 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5341 * s/template.h (SIGTYPE): Remove commented out definition.
5342
e2abce01
JB
53432011-03-26 Eli Zaretskii <eliz@gnu.org>
5344
5345 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5346 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5347
f868cd8a
JB
53482011-03-26 Juanma Barranquero <lekktu@gmail.com>
5349
59eb0929
JB
5350 * w32.c (read_unc_volume): Use parameter `henum', instead of
5351 global variable `wget_enum_handle'.
5352
5353 * keymap.c (describe_vector): Remove parameters `indices' and
5354 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5355 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5356
f868cd8a
JB
5357 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5358
5359 * keyboard.c (timer_check): Remove parameter `do_it_now',
5360 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5361 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5362 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5363
5364 * keyboard.c (read_char):
5365 * w32menu.c (w32_menu_display_help):
5366 * xmenu.c (show_help_event, menu_help_callback):
5367 Adjust calls to `show_help_echo'.
5368
5369 * gtkutil.c (xg_maybe_add_timer):
5370 * keyboard.c (readable_events):
5371 * process.c (wait_reading_process_output):
5372 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5373
5374 * insdel.c (adjust_markers_gap_motion):
5375 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5376 (gap_left, gap_right): Don't call it.
5377
2ecf6fdb
CY
53782011-03-25 Chong Yidong <cyd@stupidchicken.com>
5379
5380 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5381 incurred during fontification.
5382
6b1f9ba4
JB
53832011-03-25 Juanma Barranquero <lekktu@gmail.com>
5384
5385 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5386 (DEFVAR_PER_BUFFER): Don't pass it.
5387
5388 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5389 (scrolling_window): Don't pass it.
5390
0f4a96b5
JB
53912011-03-25 Juanma Barranquero <lekktu@gmail.com>
5392
5393 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5394
5395 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5396 and `suffix'.
5397 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5398 of variables specific to SELinux and computation of `encoded_absname'.
5399
5400 * image.c (XPutPixel): Remove unused variable `height'.
5401
5402 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5403
5404 * unexw32.c (get_section_info): Remove unused variable `section'.
5405
5406 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5407 (system_process_attributes): Remove unused variable `sess'.
5408 (sys_read): Remove unused variable `err'.
5409
5410 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5411 (w32_wnd_proc): Remove unused variable `isdead'.
5412 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5413 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5414 (x_create_tip_frame): Remove unused variable `tem'.
5415
5416 * w32inevt.c (w32_console_read_socket):
5417 Remove unused variable `no_events'.
5418
5419 * w32term.c (x_draw_composite_glyph_string_foreground):
5420 Remove unused variable `width'.
5421
1149507c
JB
54222011-03-24 Juanma Barranquero <lekktu@gmail.com>
5423
5424 * w32term.c (x_set_glyph_string_clipping):
5425 Don't pass uninitialized region to CombineRgn.
5426
9c88f339
JB
54272011-03-23 Juanma Barranquero <lekktu@gmail.com>
5428
5429 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5430 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5431 (Fx_close_connection): Remove unused variable `i'.
5432
5433 * w32font.c (w32font_draw): Return number of glyphs.
5434 (w32font_open_internal): Remove unused variable `i'.
5435 (w32font_driver): Add missing initializer.
5436
5437 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5438 (fill_in_menu): Remove unused variable `items_added'.
5439
5440 * w32term.c (last_mouse_press_frame): Remove static global variable.
5441 (w32_clip_to_row): Remove unused variable `f'.
5442 (x_delete_terminal): Remove unused variable `i'.
5443
5444 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5445 (NOTHING): Remove unused static global variable.
5446 (uniscribe_check_otf): Remove unused variable `table'.
5447 (uniscribe_font_driver): Add missing initializers.
5448
dee091a3
JD
54492011-03-23 Julien Danjou <julien@danjou.info>
5450
5451 * term.c (Fsuspend_tty, Fresume_tty):
5452 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5453 * window.c (temp_output_buffer_show):
5454 * insdel.c (signal_before_change):
5455 * frame.c (Fhandle_switch_frame):
5456 * fileio.c (Fdo_auto_save):
5457 * emacs.c (Fkill_emacs):
5458 * editfns.c (save_excursion_restore):
5459 * cmds.c (internal_self_insert):
5460 * callint.c (Fcall_interactively):
5461 * buffer.c (Fkill_all_local_variables):
5462 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5463 Use Frun_hooks.
0f4a96b5 5464 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5465 unconditionnaly since it does the check itself.
5466
2c520ab5 54672011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5468
c9c49752
PE
5469 Fix more problems found by GCC 4.5.2's static checks.
5470
8abc3f12
PE
5471 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5472 the first time through the loop, since we know p0 < p1 then.
5473 This also avoids a gcc -Wstrict-overflow warning.
5474
a2d26660
PE
5475 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5476 leading to a memory leak, possible in functions like
5477 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5478 of objects (Bug#8318).
a2d26660 5479
916c72e9
PE
5480 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5481 that could (at least in theory) be that large.
5482
19ab8a18
PE
5483 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5484 This is less likely to overflow, and avoids undefined behavior if
5485 overflow does occur. All callers changed. Use strtoul to scan
5486 for the unsigned long integer.
b7cbbd6f
PE
5487 (pint2hrstr): Simplify and tune code slightly.
5488 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5489
f0641eff
PE
5490 * scroll.c (do_scrolling): Work around GCC bug 48228.
5491 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5492
7f650bb9
PE
5493 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5494 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5495 (validate_x_resource_name): Simplify count usage.
5496 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5497
37dd57d1
PE
5498 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5499 fail (Bug#8306).
81e56e61 5500
699979fc 5501 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5502
401bf9b4
PE
5503 * process.c (Fmake_network_process): Use socklen_t, not int,
5504 where POSIX says socklen_t is required in portable programs.
5505 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5506 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5507 (Fmake_network_process, server_accept_connection):
5508 (wait_reading_process_output, read_process_output):
5509 Likewise.
5510
b93aacde
PE
5511 * process.c: Rename or move locals to avoid shadowing.
5512 (list_processes_1, Fmake_network_process):
5513 (read_process_output_error_handler, exec_sentinel_error_handler):
5514 Rename or move locals.
4dc343ee 5515 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5516 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5517 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5518 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5519 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5520
af8a867c 5521 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5522 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5523 Include tparam.h instead, since it declares them.
af8a867c
PE
5524 * cm.h (PC): Remove extern decl; tparam.h now does this.
5525 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5526 * terminfo.c: Include tparam.h, to check interfaces.
5527 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5528 (tparam): Adjust signature to match interface in tparam.h;
5529 this removes some undefined behavior. Check that outstring and len
5530 are zero, which they always are with Emacs.
5531 * tparam.h (PC, BC, UP): New extern decls.
5532
0248044d 5533 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5534 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5535
8ff096c1 5536 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5537 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5538 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5539 (ftfont_list): Remove unused local.
49eaafba
PE
5540 (get_adstyle_property, ftfont_pattern_entity):
5541 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5542 Rename locals to avoid shadowing.
8ff096c1 5543
e2be39f6
PE
5544 * xfont.c (xfont_list_family): Mark var as initialized.
5545
c9735e30
PE
5546 * xml.c (make_dom): Now static.
5547
8f5201ae
PE
5548 * composite.c (composition_compute_stop_pos): Rename local to
5549 avoid shadowing.
b246f932
PE
5550 (composition_reseat_it): Remove unused locals.
5551 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5552 (composition_update_it): Mark var as initialized.
11b61122
PE
5553 (find_automatic_composition): Mark vars as initialized,
5554 with a FIXME (Bug#8290).
8f5201ae 5555
760fbc2c
PE
5556 character.h: Rename locals to avoid shadowing.
5557 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5558 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5559 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5560 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5561 to avoid shadowing.
5562
ff08eb85
PE
5563 * textprop.c (property_change_between_p): Remove; unused.
5564
fc7bf025
PE
5565 * intervals.c (interval_start_pos): Now static.
5566
235d7abc
PE
5567 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5568
44f230aa
SM
5569 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5570 Rename locals to avoid shadowing.
3e7d6594 5571
50060332
PE
5572 * sound.c (wav_play, au_play, Fplay_sound_internal):
5573 Fix pointer signedness.
d01f234b 5574 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5575 (wav_play): Initialize a variable to 0, to prevent undefined
5576 behavior (Bug#8278).
50060332 5577
c4fc4e30
PE
5578 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5579
918436ed
PE
5580 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5581
c939f91b
PE
5582 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5583 clobbering (Bug#8298).
b9c7f648
PE
5584 * sysdep.c (sys_subshell): Likewise.
5585 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5586
6bd8c144
PE
5587 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5588 This should get cleaned up, so that child_setup has the
5589 same signature on all platforms.
5590
7710357c 5591 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5592 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5593
c59da222
CY
55942011-03-22 Chong Yidong <cyd@stupidchicken.com>
5595
5596 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5597 not to be necessary, and produces flickering.
5598
66b87493
GM
55992011-03-20 Glenn Morris <rgm@gnu.org>
5600
5601 * config.in: Remove file.
5602
45b6f6d5
JB
56032011-03-20 Juanma Barranquero <lekktu@gmail.com>
5604
5605 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5606 are now in src/globals.h.
5607 (syms_of_minibuf): Remove spurious & from previous change.
5608
3ec03f7e
LL
56092011-03-20 Leo <sdl.web@gmail.com>
5610
5611 * minibuf.c (completing-read-function): New variable.
5612 (completing-read-default): Rename from completing-read.
5613 (completing-read): Call completing-read-function.
5614
b14e3e21
CY
56152011-03-19 Juanma Barranquero <lekktu@gmail.com>
5616
5617 * xfaces.c (Fx_load_color_file):
5618 Read color file from absolute filename (bug#8250).
5619
f2b726e6
JB
56202011-03-19 Juanma Barranquero <lekktu@gmail.com>
5621
5622 * makefile.w32-in: Update dependencies.
5623
09f6ff02
EZ
56242011-03-17 Eli Zaretskii <eliz@gnu.org>
5625
5626 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5627
29a6015a
PE
56282011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5629
a3a6c54e
PE
5630 Fix more problems found by GCC 4.5.2's static checks.
5631
b766f867
PE
5632 * process.c (make_serial_process_unwind, send_process_trap):
5633 (sigchld_handler): Now static.
5634
be02381c
PE
5635 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5636 That way, the code declares only the vars that it needs.
5637 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5638 * s/cygwin.h (PTY_ITERATION): Likewise.
5639 * s/darwin.h (PTY_ITERATION): Likewise.
5640 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5641
57048744
PE
5642 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5643 * process.c (allocate_pty): Don't declare stb unless it's needed.
5644
7914961c 5645 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5646 (CONSTANTLIM): Remove; unused.
5647 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5648 Define only if needed.
7914961c 5649
b3967b18
PE
5650 * unexelf.c (unexec): Name an expression,
5651 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5652 Use a different way to cause a compilation error if anyone uses
5653 n rather than nn, a way that does not involve shadowing.
73366a00 5654 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5655
29a6015a
PE
5656 * deps.mk (unexalpha.o): Remove; unused.
5657
43cfc33e 5658 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5659 * unexec.h: New file.
ce701a33
PE
5660 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5661 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5662 Depend on unexec.h.
5663 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5664 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5665 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5666 Change as necessary to match prototype in unexec.h.
ce701a33 5667
01f44d5a
PE
5668 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5669 shadowing.
4f63c6bb 5670 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5671
a6670b0b
PE
5672 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5673 Rename locals to avoid shadowing.
5674
cef2010d 5675 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5676 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5677
d4d7173a
PE
5678 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5679
f08b802a
PE
5680 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5681 warning when compiling print.c.
5682
3ddb0639
PE
5683 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5684 instead of using an uninitialized var.
5ad03b97 5685 (font_sort_entities): Mark var as initialized.
3ddb0639 5686
170a2692
PE
5687 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5688
e663c700
PE
5689 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5690 pointers to constants.
89bc529a 5691 (font_parse_fcname): Remove unused vars.
7b81e2d0 5692 (font_delete_unmatched): Now static.
ea838e10 5693 (font_get_spec): Remove; unused.
13a547c6
PE
5694 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5695 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5696 Rename or move locals to avoid shadowing.
e663c700 5697
2a80c887 5698 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5699 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5700
1384fa33 5701 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5702 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5703
8b2c52e9
PE
5704 * alloc.c (mark_backtrace): Move decl from here ...
5705 * lisp.h: ... to here, so that it can be checked.
5706
475545b5 5707 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5708 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5709 (lisp_indirect_variable): Name an expression,
5710 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5711 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5712
b1349114 5713 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5714 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5715 Use const pointer when appropriate.
b1349114 5716
a2928364
PE
5717 * lisp.h (get_system_name, get_operating_system_release):
5718 Move decls here, to check interfaces.
5719 * process.c (get_operating_system_release): Move decl to lisp.h.
5720 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5721 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5722 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5723 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5724 (Fformat_time_string, Fencode_time, Finsert_char):
5725 (Ftranslate_region_internal, Fformat):
5726 Rename or remove local vars to avoid shadowing.
9710023e 5727 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5728
a415e694
PE
5729 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5730 avoid shadowing.
5731
8ef4622d
PE
5732 * lisp.h (eassert): Check that the argument compiles, even if
5733 ENABLE_CHECKING is not defined.
5734
946f9a5b
PE
5735 * data.c (Findirect_variable): Name an expression, to avoid
5736 gcc -Wbad-function-cast warning.
112396d6 5737 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5738 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5739 (Fmake_variable_buffer_local, Fmake_local_variable):
5740 Mark variables as initialized.
52746918 5741 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5742
e5aab7e7 5743 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5744 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5745 Rename locals to avoid shadowing.
dff45157
PE
5746 (mark_stack): Move local variables into the #ifdef region where
5747 they're used.
7bc26fdb
PE
5748 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5749 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5750 needed otherwise.
5751 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5752 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5753 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5754
e5aab7e7
PE
5755 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5756 avoids undefined behavior in theory.
5757
4da60324
PE
5758 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5759
88043301
PE
5760 Use functions, not macros, for up- and down-casing (Bug#8254).
5761 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5762 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5763 to use the following functions instead of these macros.
5764 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5765 EMACS_INT, since callers assume the returned value fits in int.
5766 (upcase1): Likewise, for UPCASE_TABLE.
5767 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5768 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5769 the race-condition problem in the old DOWNCASE.
88043301 5770
19ed5445
PE
5771 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5772 Rename locals to avoid shadowing.
5773 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5774 (regex_compile, re_search_2, re_match_2_internal):
5775 Remove unused local vars.
952db0d7
PE
5776 (FREE_VAR): Rewrite so as not to use empty "else",
5777 which gcc can warn about.
da053e48 5778 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5779 (RETALLOC_IF): Define only if needed.
5780 (WORDCHAR_P): Likewise. This one is never needed, but is used
5781 only in a comment talking about a compiler bug, so put inside
5782 the #if 0 of that comment.
5783 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5784 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5785 Remove; unused.
19ed5445 5786
1f3561e4 5787 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5788 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5789 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5790
ded6f8f7
PE
5791 * search.c (simple_search): Remove unused var.
5792
dbd37a95
PE
5793 * dired.c (compile_pattern): Move decl from here ...
5794 * lisp.h: ... to here, so that it can be checked.
5795 (struct re_registers): New forward decl.
5796
7e47afad
PE
5797 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5798
85f24f61
PE
5799 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5800 All uses changed.
5801 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5802 Rename locals to avoid shadowing.
5671df8f 5803 (Fvertical_motion): Mark locals as initialized.
85f24f61 5804
181aa2be 5805 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5806 (casify_region): Mark local as initialized.
181aa2be 5807
930d429c
PE
5808 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5809
7082eac6
PE
5810 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5811 New macros, so that the caller can use some names other than
5812 gcpro1, gcpro2, etc.
5813 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5814 of the new macros.
5815 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5816 argument, for consistency with GCPRO2_VAR, etc: it is now the
5817 prefix of the variable, not the variable itself. All uses
5818 changed.
38b2c076
PE
5819 * dired.c (directory_files_internal, file_name_completion):
5820 Rename locals to avoid shadowing.
5821
15206ed9
PE
5822 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5823 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5824 dired.c's scmp function, had undefined behavior.
5825 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5826 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5827 * buffer.h: ... to here, because these macros use current_buffer,
5828 and the new implementation with inline functions needs to have
5829 current_buffer in scope now, rather than later when the macros
5830 are used.
5831 (downcase, upcase1): New static inline functions.
5832 (DOWNCASE, UPCASE1): Reimplement using these functions.
5833 This avoids undefined behavior in expressions like
5834 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5835 from race conditions in accessing the global variables
5836 case_temp1 and case_temp2.
5837 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5838 * lisp.h (case_temp1, case_temp2): Remove their decls.
5839 * character.h (ASCII_CHAR_P): Move from here ...
5840 * lisp.h: ... to here, so that the inline functions mentioned
5841 above can use them.
5842
4a6bea26
PE
5843 * dired.c (directory_files_internal_unwind): Now static.
5844
f14b7e14
PE
5845 * fileio.c (file_name_as_directory, directory_file_name):
5846 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5847 Now static.
2893f146
PE
5848 (file_name_as_directory): Use const pointers when appropriate.
5849 (Fexpand_file_name): Likewise. In particular, newdir might
5850 point at constant storage, so make it a const pointer.
fd4ead52 5851 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5852 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5853 signedness issues.
f839df0c
PE
5854 (Fset_file_times, Finsert_file_contents, auto_save_error):
5855 Rename locals to avoid shadowing.
f14b7e14 5856
5716756e 5857 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5858 (Ftry_completion, Fall_completions): Rename or remove locals
5859 to avoid shadowing.
5716756e 5860
b4c3046a
PE
5861 * marker.c (bytepos_to_charpos): Remove; unused.
5862
b45db522
PE
5863 * lisp.h (verify_bytepos, count_markers): New decls,
5864 so that gcc does not warn that these functions aren't declared.
5865
85876d07
PE
5866 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5867 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5868 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5869 (copy_text): Remove unused local var.
85876d07 5870
03d78a21 5871 * filelock.c (within_one_second): Now static.
b3dd38ab 5872 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5873
5df8f01b
PE
5874 * buffer.c (fix_overlays_before): Mark locals as initialized.
5875 (fix_start_end_in_overlays): Likewise. This function should be
5876 simplified by using pointers-to-pointers, but that's a different
5877 matter.
b1d876f1 5878 (switch_to_buffer_1): Now static.
8f54f30a
PE
5879 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5880 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5881
a70072c9 5882 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5883 Fix pointer signedness issue.
edced198
PE
5884 (sys_subshell): Mark local as volatile if checking for lint,
5885 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5886 (MAXPATHLEN): Define only if needed.
a70072c9 5887
a0977c44
PE
5888 * process.c (serial_open, serial_configure): Move decls from here ...
5889 * systty.h: ... to here, so that they can be checked.
5890
a884fdcc
PE
5891 * fns.c (get_random, seed_random): Move extern decls from here ...
5892 * lisp.h: ... to here, so that they can be checked.
5893
604efe86 5894 * sysdep.c (reset_io): Now static.
b8950c94 5895 (wait_for_termination_signal): Remove; unused.
604efe86 5896
38fc62d9
PE
5897 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5898 (copy_keymap_item, append_key, push_text_char_description):
5899 Now static.
1004a21a 5900 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5901 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5902 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5903 (describe_map_tree):
5904 Rename locals to avoid shadowing.
38fc62d9 5905
2f2650da
PE
5906 * keyboard.c: Declare functions static if they are not used elsewhere.
5907 (echo_char, echo_dash, cmd_error, top_level_2):
5908 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5909 (read_char, kbd_buffer_get_event, make_lispy_position):
5910 (make_lispy_event, make_lispy_movement, apply_modifiers):
5911 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5912 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5913 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5914 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5915 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5916
a053e86c 5917 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5918 (mark_kboards): Move decl here ...
5919 * alloc.c (mark_kboards): ... from here.
a053e86c 5920
4752793e
PE
5921 * lisp.h (force_auto_save_soon): New decl.
5922
74f10ca7 5923 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5924 (DEFINE_DUMMY_FUNCTION): New macro.
5925 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5926 Use it.
c03cd23f
PE
5927 (main): Add casts to avoid warnings
5928 if GCC considers string literals to be constants.
74f10ca7 5929
022e70d4
PE
5930 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5931
59d6fe83
PE
5932 * dbusbind.c: Pointer signedness fixes.
5933 (xd_signature, xd_append_arg, xd_initialize):
5934 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5935 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5936 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5937 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5938
78320123
PE
5939 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5940 if GCC considers string literals to be constants.
49cebcca 5941 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5942
35ac2a97
SM
59432011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5944
fb103ca9
SM
5945 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5946 (print_preprocess, print_object): New macro to fix last change.
5947
35ac2a97
SM
5948 * print.c (print_preprocess): Don't forget font objects.
5949
62973b41
JB
59502011-03-16 Juanma Barranquero <lekktu@gmail.com>
5951
5952 * emacs.c (USAGE3): Doc fixes.
5953
0e48bb22
AS
59542011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5955
5956 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5957 structure.
5958
7684e57b
JB
59592011-03-14 Juanma Barranquero <lekktu@gmail.com>
5960
5961 * lisp.h (VWindow_system, Qfile_name_history):
5962 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5963 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5964 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5965
5966 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5967 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5968
5969 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5970 * w32console.c (detect_input_pending, read_input_pending)
5971 (encode_terminal_code):
5972 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5973 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5974 (w32_system_caret_y, Qfile_name_history):
5975 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5976 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5977 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5978 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5979 * w32proc.c (Qlocal, report_file_error):
5980 * w32term.c (Vwindow_system, updating_frame):
5981 * w32uniscribe.c (initialized, uniscribe_font_driver):
5982 Remove unneeded extern declarations.
5983
2aa46d6c
CY
59842011-03-14 Chong Yidong <cyd@stupidchicken.com>
5985
c96bbc66 5986 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5987
cffc6f3b
CY
59882011-03-13 Chong Yidong <cyd@stupidchicken.com>
5989
5990 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5991 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5992 These macros can no longer be used for assignment.
5993
44f230aa
SM
5994 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5995 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5996 (record_buffer_markers, fetch_buffer_markers): New functions for
5997 recording and fetching special buffer markers.
5998 (set_buffer_internal_1, set_buffer_temp): Use them.
5999
6000 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6001
6002 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6003
6004 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6005 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6006
6007 * xdisp.c (hscroll_window_tree):
6008 (reconsider_clip_changes): Use PT instead of BUF_PT.
6009
d251f04b
EZ
60102011-03-13 Eli Zaretskii <eliz@gnu.org>
6011
6012 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6013 $(EMACS_ROOT)/lib/intprops.h.
6014
f0c77cd1
PE
60152011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6016
3eca4629
PE
6017 Fix more problems found by GCC 4.5.2's static checks.
6018
7c86ee98
PE
6019 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6020 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6021 (xg_free_frame_widgets): Make it clear that a local variable is
6022 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6023 (gdk_window_get_screen): Make it clear that this macro is needed
6024 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6025 (int_gtk_range_get_value): New function, which avoids a diagnostic
6026 from gcc -Wbad-function-cast.
6027 (xg_set_toolkit_scroll_bar_thumb): Use it.
6028 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6029 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6030 (get_utf8_string, xg_get_file_with_chooser):
6031 Rename locals to avoid shadowing.
6032 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6033
41729b81
PE
6034 * xgselect.c (xg_select): Remove unused var.
6035
f0c77cd1
PE
6036 * image.c (four_corners_best): Mark locals as initialized.
6037 (gif_load): Initialize transparent_p to zero (Bug#8238).
6038 Mark another local as initialized.
ec6cf4c6 6039 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6040
ce0ad53d 6041 * image.c (clear_image_cache): Now static.
d5d5a617 6042 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6043 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6044 (x_edge_detection): Remove unnecessary cast that
6045 gcc -Wbad-function-cast diagnoses.
2037898d 6046 (gif_load): Fix pointer signedness.
6ae141d6
PE
6047 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6048 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6049
33383987 60502011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6051
d32df629
PE
6052 Improve quality of tests for time stamp overflow.
6053 For example, without this patch (encode-time 0 0 0 1 1
6054 1152921504606846976) returns the obviously-bogus value (-948597
6055 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6056 reports time overflow. See
6057 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6058 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6059 * editfns.c: Include limits.h and intprops.h.
6060 (TIME_T_MIN, TIME_T_MAX): New macros.
6061 (time_overflow): Move earlier, to before first use.
6062 (hi_time, lo_time): New functions, for an accurate test for
6063 out-of-range times.
6064 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6065 (Fget_internal_run_time): Don't assume time_t fits in int.
6066 (make_time): Use list2 instead of Fcons twice.
6067 (Fdecode_time): More accurate test for out-of-range times.
6068 (check_tm_member): New function.
6069 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6070 (lisp_time_argument): Don't rely on undefined left-shift and
6071 right-shift behavior when checking for time stamp overflow.
8be6f318 6072
fe31d94c
PE
6073 * editfns.c (time_overflow): New function, refactoring common code.
6074 (Fformat_time_string, Fdecode_time, Fencode_time):
6075 (Fcurrent_time_string): Use it.
6076
8be6f318
PE
6077 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6078 * dired.c (make_time): Move to ...
6079 * editfns.c (make_time): ... here.
6080 * systime.h: Note the move.
6081
09d9db2c 60822011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6083
126bc0dc
YM
6084 * fringe.c (update_window_fringes): Remove unused variables.
6085
c47cbdfd
YM
6086 * unexmacosx.c (copy_data_segment): Also copy __got section.
6087 (Bug#8223)
6088
7ac80be9
EZ
60892011-03-12 Eli Zaretskii <eliz@gnu.org>
6090
c96bbc66 6091 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6092 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6093 Constify `char *' arguments and their references according to
6094 prototypes in tparam.h.
6095
ecb0f94d 6096 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6097
7ac80be9
EZ
6098 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6099 Adapt all references accordingly.
6100
6101 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6102
ef1fd07e
TT
61032011-03-11 Tom Tromey <tromey@redhat.com>
6104
6105 * buffer.c (syms_of_buffer): Remove obsolete comment.
6106
7ef4b50c
EZ
61072011-03-11 Eli Zaretskii <eliz@gnu.org>
6108
6109 * termhooks.h (encode_terminal_code): Declare prototype.
6110
6111 * msdos.c (encode_terminal_code): Don't declare prototype.
6112
6113 * term.c (encode_terminal_code): Now external again, used by
6114 w32console.c and msdos.c.
6115
44f230aa
SM
6116 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6117 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6118
4b1ec863 61192011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6120
1714f52b 6121 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6122
4b1ec863
PE
6123 * fringe.c (update_window_fringes): Mark locals as initialized
6124 (Bug#8227).
6125 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6126
524c7aa6
PE
6127 * alloc.c (mark_fringe_data): Move decl from here ...
6128 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6129 to check its interface.
6130 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6131
a5c0af81 6132 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6133 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6134 (fontset_font): Mark local as initialized.
a9a06e0b 6135 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6136
b4716021
PE
6137 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6138
811e9bac 6139 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6140 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6141 (x_own_selection, Fx_disown_selection_internal): Rename locals
6142 to avoid shadowing.
6143 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6144
7e3ab302
PE
6145 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6146 so that the caller can use some name other than gcpro1.
6147 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6148 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6149 (Fx_backspace_delete_keys_p):
6150 Use them to avoid shadowing, and rename vars to avoid shadowing.
6151 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6152 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6153 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6154 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6155 Remove unused locals.
7e3ab302
PE
6156 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6157 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6158 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6159 macros.
f78faa98 6160
e2b13473
PE
6161 * xterm.h (x_mouse_leave): New decl.
6162
77f23912
PE
6163 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6164 Remove unused functions.
cdf4ba58
PE
6165 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6166 (x_calc_absolute_position): Now static.
7411c686 6167 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6168 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6169 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6170 unless they are used.
38d0b34a
PE
6171 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6172 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6173 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6174 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6175 (x_error_catcher, x_connection_closed, x_error_handler):
6176 (x_error_quitter, xembed_send_message, x_iconify_frame):
6177 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6178 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6179 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6180
44f230aa
SM
6181 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6182 Rename or move locals to avoid shadowing.
6b463e58 6183 (tty_defined_color, merge_face_heights): Now static.
5967d051 6184 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6185 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6186 does not deduce is never used uninitialized.
73719eba
PE
6187 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6188 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6189
426994c3 6190 * terminal.c (store_terminal_param): Now static.
5489860b 6191
032f1620 6192 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6193 (set_frame_menubar): Remove unused local.
d4323972 6194 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6195 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6196 since they might point to immutable storage.
281585b0
PE
6197 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6198 since it's unused otherwise.
032f1620 6199
367c19e5 6200 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6201 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6202 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6203 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6204 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6205 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6206 does not deduce are never used uninitialized.
70739cbe 6207
07b48fa9
PE
6208 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6209
8868a238 6210 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6211 * window.c (window_loop, size_window):
6212 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6213
7e5cf297 6214 * window.c (display_buffer): Now static.
d6550a9f
PE
6215 (size_window): Mark variables that gcc -Wuninitialized
6216 does not deduce are never used uninitialized.
a586633d
PE
6217 * window.h (check_all_windows): New decl, to forestall
6218 gcc -Wmissing-prototypes diagnostic.
5b555da1 6219 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6220
f6095868
PE
6221 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6222 shadowing.
6223 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6224 Include <limits.h>.
6225 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6226 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6227 (load_charset_map): Mark variables that gcc -Wuninitialized
6228 does not deduce are never used uninitialized.
53df7c11 6229 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6230
f38b440c
PE
6231 * coding.c (coding_set_source, coding_set_destination):
6232 Use "else { /* comment */ }" rather than "else /* comment */;"
6233 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6234 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6235 a block, when the outer 'i' will do.
6236 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6237 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6238 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6239 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6240 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6241 Rename locals to avoid shadowing.
6242 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6243 * coding.c (emacs_mule_char, encode_invocation_designation):
6244 Now static, since they're not used elsewhere.
413bb2db 6245 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6246 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6247 (decode_coding_emacs_mule): Mark variables that gcc
6248 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6249 (detect_coding_iso_2022): Initialize a local variable that might
6250 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6251 this initialization is needed. (Bug#8211)
5f58e762
PE
6252 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6253 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6254 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6255 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6256 Remove unused macros.
f38b440c 6257
232b38b9 6258 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6259 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6260 * character.c (string_count_byte8): Likewise.
232b38b9 6261
fb90da1b
PE
6262 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6263 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6264
fb93dbc2
PE
6265 * chartab.c (copy_sub_char_table): Now static, since it's not used
6266 elsewhere.
5c156ace
PE
6267 (sub_char_table_ref_and_range, char_table_ref_and_range):
6268 Rename locals to avoid shadowing.
bbcd0949 6269 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6270
7d3b3862 6271 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6272 (BIDI_BOB): Remove unused macro.
7d3b3862 6273
6be7d3da
PE
6274 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6275 deduce are never used uninitialized.
c2ed9c8b 6276 * term.c (encode_terminal_code): Likewise.
6be7d3da 6277
75f8807f 6278 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6279
50938595
PE
6280 * tparam.h: New file.
6281 * term.c, tparam.h: Include it.
6282 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6283 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6284 Move these decls to tparam.h, and make them agree with what
6285 is actually in tparam.c. The previous trick of using incompatible
6286 decls in different modules does not conform to the C standard.
6287 All callers of tparam changed to use tparam's actual API.
6288 * tparam.c (tparam1, tparam, tgoto):
6289 Use const pointers where appropriate.
6290
fbceeba2
PE
6291 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6292 * cm.h (struct cm): Likewise.
6293 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6294 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6295 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6296 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6297 (turn_on_face, init_tty): Likewise.
6298 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6299
7f3f1250
PE
6300 * term.c (term_mouse_position): Rename local to avoid shadowing.
6301
e6ca6543
PE
6302 * alloc.c (mark_ttys): Move decl from here ...
6303 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6304
c40f8d15
AS
63052011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6306
6307 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6308
cfe0661d
JB
63092011-03-09 Juanma Barranquero <lekktu@gmail.com>
6310
6311 * search.c (compile_pattern_1): Remove argument regp, unused since
6312 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6313 (compile_pattern): Don't pass it.
6314
0afb4571
J
63152011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6316
6317 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6318 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6319 for ! HAVE_GTK3.
6320 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6321
6322 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6323
6324 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6325 gdk_window_get_screen, gdk_window_get_geometry,
6326 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6327 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6328 (xg_get_pixbuf_from_pixmap): New function.
6329 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6330 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6331 Call xg_get_pixbuf_from_pixmap instead of
6332 gdk_pixbuf_get_from_drawable.
6333 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6334 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6335 (xg_check_special_colors): Use GtkStyleContext and its functions
6336 for HAVE_GTK3.
6337 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6338 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6339 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6340 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6341 Call gtk_widget_get_preferred_size.
0afb4571
J
6342 (xg_frame_resized): gdk_window_get_geometry only takes 5
6343 parameters.
44f230aa
SM
6344 (xg_win_to_widget, xg_event_is_for_menubar):
6345 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6346 (xg_set_widget_bg): New function.
6347 (delete_cb): New function.
895009e1 6348 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6349 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6350 (xg_set_background_color): Call xg_set_widget_bg.
6351 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6352 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6353 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6354 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6355 if ! HAVE_GTK3.
6356 (update_frame_tool_bar): Call gtk_widget_hide.
6357 (xg_initialize): Use GDK_KEY_g.
6358
6359 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6360 if ! HAVE_GTK3
6361 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6362
6363 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6364 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6365 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6366
1c2cc4ef
JB
63672011-03-08 Juanma Barranquero <lekktu@gmail.com>
6368
6369 * w32xfns.c (select_palette): Check success of RealizePalette against
6370 GDI_ERROR, not zero.
6371
33383987 6372See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6373
6374;; Local Variables:
6375;; coding: utf-8
aac0c6e3
MR
6376;; End:
6377
33383987 6378 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6379
6380 This file is part of GNU Emacs.
6381
6382 GNU Emacs is free software: you can redistribute it and/or modify
6383 it under the terms of the GNU General Public License as published by
6384 the Free Software Foundation, either version 3 of the License, or
6385 (at your option) any later version.
6386
6387 GNU Emacs is distributed in the hope that it will be useful,
6388 but WITHOUT ANY WARRANTY; without even the implied warranty of
6389 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6390 GNU General Public License for more details.
6391
6392 You should have received a copy of the GNU General Public License
6393 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.