* xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
51cab52b 12011-06-21 Paul Eggert <eggert@cs.ucla.edu>
882f0d81 2
2606c57b
PE
3 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4 (x_session_initialize): Do not assume string length fits in int.
5
aaafe47a
PE
6 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7 This is unlikely, but can occur if DPI is outlandish.
8
2674ddc8 9 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
11
28154962
PE
12 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
13 * xrdb.c (magic_file_p, search_magic_path):
14 Omit last arg SUFFIX; it was always 0. All callers changed.
15 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
16
7de51af5
PE
17 * xfont.c (xfont_match): Avoid need for strlen.
18
25ed6cc3
PE
19 * xfns.c: Don't assume strlen fits in int.
20 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
21
4eab31dd
PE
22 * xdisp.c (message_log_check_duplicate): Return intmax_t,
23 not unsigned long, as we prefer signed integers. All callers changed.
24 Detect integer overflow in repeat count.
25 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 26 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 27
171e2a58
PE
28 * termcap.c: Don't assume sizes fit in int and never overflow.
29 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
30 (gobble_line): Check for size-calculation overflow.
31
ad39faca 32 * minibuf.c (Fread_buffer):
6e5bb2dc 33 * lread.c (intern, intern_c_string):
74ca2eb3
PE
34 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
35 Don't assume string length fits in int.
36
52c61c22 37 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
38 * gtkutil.c (style_changed_cb): Avoid need for strlen.
39
b5b8c9e5
PE
40 * font.c: Don't assume string length fits in int.
41 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
42 Use ptrdiff_t, not int.
ccd6111c
PE
43 (font_intern_prop): Don't assume string length fits in int.
44 Don't assume integer property fits in fixnum.
45 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 46
882f0d81 47 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 48 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
49 Reformulate so as not to need the command string.
50 Invoke gzip -cd rather than gunzip, as it's more portable.
51 (lock_info_type, lock_file_1, lock_file):
52 Don't assume pid_t and time_t fit in unsigned long.
53 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
54 (current_lock_owner): Prefer signed type for sizes.
55 Use memcpy, not strncpy, where memcpy is what is really wanted.
56 Don't assume (via atoi) that time_t and pid_t fit in int.
57 Check for time_t and/or pid_t out of range, e.g., via a network share.
58 Don't alloca where an auto var works fine.
59
93f4cf88
PE
60 * fileio.c: Fix some integer overflow issues.
61 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
62 Don't assume string length fits in int.
63 (directory_file_name): Don't assume string length fits in long.
64 (make_temp_name): Don't assume pid fits in int, or that its print
65 length is less than 20.
66
f3e92b69
PE
67 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
68
1bfdaf10
PE
69 * coding.c (make_subsidiaries): Don't assume string length fits in int.
70
35016e9a
PE
71 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
72
3d1e65a1
PE
73 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
74 We prefer signed integers, even for size calculations.
75
0b963a93
PE
76 * emacs.c: Don't assume string length fits in 'int'.
77 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
78 (main): Don't invoke strlen when not needed.
79
573f4b54
PE
80 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
81 (XD_DEBUG_MESSAGE): Don't waste a byte.
82
989f33ba
PE
83 * callproc.c (getenv_internal_1, getenv_internal)
84 (Fgetenv_internal):
965d34eb
PE
85 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
86
e4d29b33
PE
87 * lread.c (invalid_syntax): Omit length argument.
88 All uses changed. This doesn't fix a bug, but it simplifies the
89 code away from its former Hollerith-constant appearance, and it's
90 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 91 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 92
eb49b136
PE
93 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
94 This didn't break anything, but it didn't help either.
95 It's confusing to put a bogus integer in a place where the actual
96 value does not matter.
9f62aeb1 97 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 98 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 99
15375a22
PE
100 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
101 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
102 implementation.
b61cc01c
PE
103 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
104 We prefer signed types, and the value cannot exceed the EMACS_INT
105 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
106 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
107 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
108 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 109
53b2623d
PE
110 * indent.c (sane_tab_width): New function.
111 (current_column, scan_for_column, Findent_to, position_indentation)
112 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 113 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 114
51cab52b 115 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 116
f2ed8a70
PE
117 * lisp.h (lint_assume): New macro.
118 * composite.c (composition_gstring_put_cache):
119 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
120
abe80cc6
PE
121 * editfns.c, insdel.c:
122 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 123
b02c740e
PE
124 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
125
ebc96716
PE
126 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
127
b4e50fa0 128 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 129 Use much-faster test for byte-length change.
311d5d7c 130 Don't assume string byte-length fits in 'int'.
a4cf38e4 131 Check that character arg fits in 'int'.
85461888 132 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 133
c0c1ee9f
PE
134 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
135
a498d7f4
PE
136 * fns.c (concat): Catch string overflow earlier.
137 Do not rely on integer wraparound.
138
51cab52b
PE
139 * dispextern.h (struct it.overlay_strings_charpos)
140 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
141 * xdisp.c (forward_to_next_line_start)
142 (back_to_previous_visible_line_start)
143 (reseat_at_next_visible_line_start, next_element_from_buffer):
144 Don't arbitrarily truncate the value of 'selective' to int.
145
76031fad
PE
146 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
147
5eb55db9
PE
148 * composite.c: Don't truncate sizes to 'int'.
149 (composition_gstring_p, composition_reseat_it)
150 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
151 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
152 not EMACS_UINT, for indexes.
5eb55db9 153
0703a717
PE
154 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
155
d6202519
PE
156 * buffer.c: Include <verify.h>.
157 (struct sortvec.priority, struct sortstr.priority):
8961a454 158 Now EMACS_INT, not int.
c20998a7 159 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
160 (struct sortstr.size, record_overlay_string)
161 (struct sortstrlist.size, struct sortlist.used):
162 Don't truncate size to int.
163 (record_overlay_string): Check for size-calculation overflow.
d6202519 164 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 165
76147d94
DD
1662011-06-20 Deniz Dogan <deniz@dogan.se>
167
168 * process.c (Fset_process_buffer): Clarify return value in
169 docstring.
170
7d7d0045
CY
1712011-06-18 Chong Yidong <cyd@stupidchicken.com>
172
173 * dispnew.c (add_window_display_history): Use BVAR.
174
175 * xdisp.c (debug_method_add): Use BVAR.
176 (check_window_end, dump_glyph_matrix, dump_glyph)
177 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
178
179 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
180 Likewise.
181
182 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
183 check till after the cache is created in init_frame_faces.
184
ff2bc410
SM
1852011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
186
187 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
188
28177add
PE
1892011-06-16 Paul Eggert <eggert@cs.ucla.edu>
190
dd3482fe
PE
191 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
192 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
193 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
194
393d71f3 195 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
196 * fileio.c (Finsert_file_contents):
197 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
198 Remove the old (too-loose) buffer overflow checks.
199 They weren't needed, since make_gap checks for buffer overflow.
200 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
201 The old code merely checked for Emacs fixnum overflow, and relied
202 on undefined (wraparound) behavior. The new code avoids undefined
203 behavior, and also checks for ptrdiff_t and/or size_t overflow.
204
2e6813b0 205 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
206 Tune. Don't use wider integers than needed. Don't use alloca.
207 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 208
599a9e4f
PE
209 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
210
99561444
PE
211 * insdel.c, lisp.h (buffer_overflow): New function.
212 (insert_from_buffer_1, replace_range, replace_range_2):
213 * insdel.c (make_gap_larger):
214 * editfns.c (Finsert_char):
215 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
216
28177add
PE
217 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
218
e69dafad
PE
2192011-06-15 Paul Eggert <eggert@cs.ucla.edu>
220
a7af7fde 221 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 222
b1c46f02
PE
223 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
224 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
225
e69dafad
PE
226 * fileio.c: Don't assume EMACS_INT fits in off_t.
227 (emacs_lseek): New static function.
228 (Finsert_file_contents, Fwrite_region): Use it.
229 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
230
566684ea
PE
231 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
232
e6966cd6
PE
233 * fns.c: Don't overflow int when computing a list length.
234 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
235 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
236 truncation on 64-bit hosts. Check for QUIT every
237 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
238 faster and is responsive enough.
239 (Flength): Report an error instead of overflowing an integer.
240 (Fsafe_length): Return a float if the value is not representable
241 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 242 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 243 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 244
dd0b0efb
PE
245 * alloc.c: Check that resized vectors' lengths fit in fixnums.
246 (header_size, word_size): New constants.
247 (allocate_vectorlike): Don't check size overflow here.
248 (allocate_vector): Check it here instead, since this is the only
249 caller of allocate_vectorlike that could cause overflow.
250 Check that the new vector's length is representable as a fixnum.
251
86fe5cfe
PE
252 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
253 The previous code was bogus. For example, next_almost_prime (32)
254 returned 39, which is undesirable as it is a multiple of 3; and
255 next_almost_prime (24) returned 25, which is a multiple of 5 so
256 why was the code bothering to check for multiples of 7?
257
80e88859
PE
258 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
259
4a2f0ad6
PE
260 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
261
f66c7cf8
PE
262 Variadic C functions now count arguments with ptrdiff_t.
263 This partly undoes my 2011-03-30 change, which replaced int with size_t.
264 Back then I didn't know that the Emacs coding style prefers signed int.
265 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
266 were being counted with int, which may truncate counts on 64-bit
267 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
268 * lisp.h (struct Lisp_Subr.function.aMANY)
269 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
270 Arg counts are now ptrdiff_t, not size_t.
271 All variadic functions and their callers changed accordingly.
272 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
273 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
274 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
275 * callint.c (Fcall_interactively): Check arg count for overflow,
276 to avoid potential buffer overrun. Use signed char, not 'int',
277 for 'varies' array, so that we needn't bother to check its size
278 calculation for overflow.
279 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
280 * eval.c (apply_lambda):
281 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
282 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
283 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
284
a1759b76
PE
285 * callint.c (Fcall_interactively): Don't use index var as event count.
286
d96be9fc
PE
287 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
288 * mem-limits.h (SIZE): Remove; no longer used.
289
a690a978 290 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 291
578c21e6
PE
292 Remove unnecessary casts.
293 * xterm.c (x_term_init):
294 * xfns.c (x_set_border_pixel):
295 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
296 These aren't needed now that we assume ANSI C.
297
96f53c6c
PE
298 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
299 It's more likely to cause problems (due to unsigned overflow)
300 than to cure them.
301
83c77d31
PE
302 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
303
ee2079f1
PE
304 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
305
6da65536
PE
306 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
307
7147c4a4
PE
308 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
309
193e32d9
PE
310 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
311
e5533da6
PE
312 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
313
9910e595
PE
314 GLYPH_CODE_FACE returns EMACS_INT, not int.
315 * dispextern.h (merge_faces):
316 * xfaces.c (merge_faces):
01103c44
PE
317 * xdisp.c (get_next_display_element, next_element_from_display_vector):
318 Don't assume EMACS_INT fits in int.
9910e595 319
2638320e
PE
320 * character.h (CHAR_VALID_P): Remove unused parameter.
321 * fontset.c, lisp.h, xdisp.c: All uses changed.
322
045eb8d9
PE
323 * editfns.c (Ftranslate_region_internal): Omit redundant test.
324
c1f134b5
PE
325 * fns.c (concat): Minor tuning based on overflow analysis.
326 This doesn't fix any bugs. Use int to hold character, instead
327 of constantly refetching from Emacs object. Use XFASTINT, not
328 XINT, for value known to be a character. Don't bother comparing
329 a single byte to 0400, as it's always less.
330
395fcb93 331 * floatfns.c (Fexpt):
327eeec8
PE
332 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
333
abbd3d23
PE
334 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
335 for characters.
336
684a03ef
PE
337 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
338
0fed43f3
PE
339 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
340 Without this fix, on a 64-bit host (aset S 0 4294967386) would
341 incorrectly succeed when S was a string, because 4294967386 was
342 truncated before it was used.
343
8fd02eb7
PE
344 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
345 Otherwise, an out-of-range integer could cause undefined behavior
346 on a 64-bit host.
347
f8c86b69
PE
348 * composite.c: Use int, not EMACS_INT, for characters.
349 (fill_gstring_body, composition_compute_stop_pos): Use int, not
350 EMACS_INT, for values that are known to be in character range.
351 This doesn't fix any bugs but is the usual style inside Emacs and
352 may generate better code on 32-bit machines.
353
34206dd2
PE
354 Make sure a 64-bit char is never passed to ENCODE_CHAR.
355 This is for reasons similar to the recent CHAR_STRING fix.
356 * charset.c (Fencode_char): Check that character arg is actually
357 a character. Pass an int to ENCODE_CHAR.
358 * charset.h (ENCODE_CHAR): Verify that the character argument is no
359 wider than 'int', as a compile-time check to prevent future regressions
360 in this area.
361
c5958d4c 362 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
363
364 Make sure a 64-bit char is never passed to CHAR_STRING.
365 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
366 by silently ignoring the top 32 bits, allowing some values
367 that were far too large to be valid characters.
368 * character.h: Include <verify.h>.
369 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
370 arguments are no wider than unsigned, as a compile-time check
371 to prevent future regressions in this area.
372 * data.c (Faset):
01103c44 373 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
374 (Fsubst_char_in_region):
375 * fns.c (concat):
376 * xdisp.c (decode_mode_spec_coding):
377 Adjust to CHAR_STRING's new requirement.
378 * editfns.c (Finsert_char, Fsubst_char_in_region):
379 * fns.c (concat): Check that character args are actually
380 characters. Without this test, these functions did the wrong
381 thing with wildly out-of-range values on 64-bit hosts.
382
d37ca623
PE
383 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
384 These casts should not be needed on 32-bit hosts, either.
385 * keyboard.c (read_char):
386 * lread.c (Fload): Remove casts to unsigned.
387
ea204efb
PE
388 * lisp.h (UNSIGNED_CMP): New macro.
389 This fixes comparison bugs on 64-bit hosts.
390 (ASCII_CHAR_P): Use it.
391 * casefiddle.c (casify_object):
01103c44 392 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
393 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
394 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
395 * dispextern.h (FACE_FROM_ID):
396 * keyboard.c (read_char): Use UNSIGNED_CMP.
397
41cb286c
PE
398 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
399 not to EMACS_INT, to avoid GCC warning.
400
4a1b9832
PE
401 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
402
55daad71
PE
403 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
404 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
405 isn't needed on 32-bit machines.
8f95c75c 406
01103c44
PE
407 * buffer.c (Fgenerate_new_buffer_name):
408 Use EMACS_INT for count, not int.
0ceccced 409 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
410
411 * data.c (Qcompiled_function): Now static.
412
c6f072e7
PE
413 * window.c (window_body_lines): Now static.
414
20ce5912
PE
415 * image.c (gif_load): Rename local to avoid shadowing.
416
9c4c5f81
PE
417 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
418 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
419 * alloc.c (make_save_value): Integer argument is now of type
420 ptrdiff_t, not int.
421 (mark_object): Use ptrdiff_t, not int.
422 * lisp.h (pD): New macro.
423 * print.c (print_object): Use it.
424
c0c5c8ae
PE
425 * alloc.c: Use EMACS_INT, not int, to count objects.
426 (total_conses, total_markers, total_symbols, total_vector_size)
427 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
428 (total_free_floats, total_floats, total_free_intervals)
429 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
430 Now EMACS_INT, not int. All uses changed.
431 (Fgarbage_collect): Compute overall total using a double, so that
432 integer overflow is less likely to be a problem. Check for overflow
433 when converting back to an integer.
5a25e253
PE
434 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
435 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
436 These were 'int' variables that could overflow on 64-bit hosts;
437 they were never used, so remove them instead of repairing them.
211a0b2a 438 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
439 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
440 Previously, this ceilinged at INT_MAX, but that doesn't work on
441 64-bit machines.
e46bb31a 442 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 443
c78baabf 444 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 445 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
446 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
447 when a (possibly-narrower) signed value would do just as well.
448 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 449
c9d624c6
PE
450 * alloc.c: Catch some string size overflows that we were missing.
451 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
452 for convenience in STRING_BYTES_MAX.
453 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
454 The definition here is exact; the one in lisp.h was approximate.
455 (allocate_string_data): Check for string overflow. This catches
456 some instances we weren't catching before. Also, it catches
457 size_t overflow on (unusual) hosts where SIZE_MAX <= min
458 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
459 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 460
c9d624c6
PE
461 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
462 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
463 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
464
353032ce
PE
465 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
466
2bccce07
PE
467 * alloc.c (Fmake_string): Check for out-of-range init.
468
0ac30604
SM
4692011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
470
471 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
472
c195f2de
JD
4732011-06-14 Jan Djärv <jan.h.d@swipnet.se>
474
475 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
476 xg_get_default_scrollbar_width.
477
478 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
479 (int_gtk_range_get_value): Move to the scroll bar part of the file.
480 (style_changed_cb): Call update_theme_scrollbar_width and call
481 x_set_scroll_bar_default_width and xg_frame_set_char_size for
482 all frames (Bug#8505).
483 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
484 Call gtk_window_set_resizable if HAVE_GTK3.
485 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
486 and height if HAVE_GTK3 (Bug#8505).
487 (scroll_bar_width_for_theme): New variable.
488 (update_theme_scrollbar_width): New function.
489 (xg_get_default_scrollbar_width): Move code to
490 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
491 (xg_initialize): Call update_theme_scrollbar_width.
492
493 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
494
495 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
496
e10ac9f1
MR
4972011-06-12 Martin Rudalics <rudalics@gmx.at>
498
499 * frame.c (make_frame): Call other_buffer_safely instead of
500 other_buffer.
501
502 * window.c (temp_output_buffer_show): Call display_buffer with
503 second argument Vtemp_buffer_show_specifiers and reset latter
504 immediately after the call.
505 (Vtemp_buffer_show_specifiers): New variable.
506 (auto_window_vscroll_p, next_screen_context_lines)
507 (Vscroll_preserve_screen_position): Remove leading asterisks from
508 doc-strings.
509
2d3c217e 5102011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 511
7b7f97e8 512 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
513 * buffer.c (Qclone_number): Remove for now, as it's unused.
514 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
515 (record_buffer): Remove unused local.
516 * frame.c (other_visible_frames, frame_buffer_list): Now static.
517 (set_frame_buffer_list): Remove; unused.
518 * frame.h (other_visible_frames): Remove decl.
519 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
520 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
521 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
522 if HAVE_GPM.
523 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
524 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
525 Define only if HAVE_GPM.
526 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
527 (update_hints_inhibit): Remove; never set. All uses removed.
528 * widgetprv.h (emacsFrameClassRec): Remove decl.
529 * window.c (delete_deletable_window): Now returns void, since it
530 wasn't returning anything.
531 (compare_window_configurations): Remove unused locals.
532 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
533 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
534 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
535 the same widths as pointers. This follows up on the 2011-05-06 patch.
536 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
537 * xterm.h: Likewise.
538 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
539
1384b89e
JB
5402011-06-12 Juanma Barranquero <lekktu@gmail.com>
541
542 * makefile.w32-in: Update dependencies.
543 (LISP_H): Add lib/intprops.h.
544
1100a63c
CY
5452011-06-11 Chong Yidong <cyd@stupidchicken.com>
546
547 * image.c (gif_load): Add animation frame delay to the metadata.
548 (syms_of_image): Use DEFSYM. New symbol `delay'.
549
6198ccd0
MR
5502011-06-11 Martin Rudalics <rudalics@gmx.at>
551
552 * window.c (delete_deletable_window): Re-add.
553 (Fset_window_configuration): Rewrite to handle dead buffers and
554 consequently deletable windows.
555 (window_tree, Fwindow_tree): Remove. Supply functionality in
556 window.el.
557 (compare_window_configurations): Simplify code.
558
b6e3633c
AS
5592011-06-11 Andreas Schwab <schwab@linux-m68k.org>
560
1ab0dee5
AS
561 * image.c (imagemagick_load_image): Fix type mismatch.
562 (Fimagemagick_types): Likewise.
563
b6e3633c
AS
564 * window.h (replace_buffer_in_windows): Declare.
565
9397e56f
MR
5662011-06-11 Martin Rudalics <rudalics@gmx.at>
567
568 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
569 Qclone_number. Remove external declaration of Qdelete_window.
570 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
571 code.
572 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
573 Qbuffer_list_update_hook if allowed.
574 (Fother_buffer): Rewrite doc-string. Major rewrite for new
575 buffer list implementation.
576 (other_buffer_safely): New function.
577 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
578 calls to replace_buffer_in_windows and
579 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
580 if allowed.
581 (record_buffer): Inhibit quitting and rewrite using quittable
582 functions. Run Qbuffer_list_update_hook if allowed.
583 (Frecord_buffer, Funrecord_buffer): New functions.
584 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
585 switch-to-buffer to window.el.
586 (bury-buffer): Move to window.el.
587 (Vbuffer_list_update_hook): New variable.
588
589 * lisp.h (other_buffer_safely): Add prototype in buffer.c
590 section.
591
592 * window.h (resize_frame_windows): Move up in code.
593 (Fwindow_frame): Remove EXFUN.
594 (replace_buffer_in_all_windows): Remove prototype.
595 (replace_buffer_in_windows_safely): Add prototype.
596
597 * window.c: Declare Qdelete_window static again. Move down
598 declaration of select_count.
599 (Fnext_window, Fprevious_window): Rewrite doc-strings.
600 (Fother_window): Move to window.el.
601 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
602 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
603 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
604 window.el.
605 (replace_buffer_in_windows): Implement by calling
606 Qreplace_buffer_in_windows.
607 (replace_buffer_in_all_windows): Remove with some functionality
608 moved into replace_buffer_in_windows_safely.
609 (replace_buffer_in_windows_safely): New function.
610 (select_window_norecord, select_frame_norecord): Move in front
611 of run_window_configuration_change_hook. Remove now obsolete
612 declarations.
613 (Fset_window_buffer): Rewrite doc-string. Call
614 Qrecord_window_buffer.
615 (keys_of_window): Move binding for other-window to window.el.
616
b50691aa
CY
6172011-06-11 Chong Yidong <cyd@stupidchicken.com>
618
619 * dispextern.h (struct image): Replace data member, whose int_val
620 and ptr_val fields were not used by anything, with a single
621 lisp_val object.
622
623 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
624 (gif_clear_image, gif_load, imagemagick_load_image)
625 (gs_clear_image, gs_load): Callers changed.
626
3f754b86
PE
6272011-06-10 Paul Eggert <eggert@cs.ucla.edu>
628
cca69397
PE
629 * buffer.h: Include <time.h>, for time_t.
630 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
631
109e28d0
PE
632 Fix minor problems found by static checking.
633
60737f02
PE
634 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
635
4b66faf3
PE
636 Make identifiers static if they are not used in other modules.
637 * data.c (Qcompiled_function, Qframe, Qvector):
638 * image.c (QimageMagick, Qsvg):
639 * minibuf.c (Qmetadata):
640 * window.c (resize_window_check, resize_root_window): Now static.
641 * window.h (resize_window_check, resize_root_window): Remove decls.
642
109e28d0
PE
643 * window.c (window_deletion_count, delete_deletable_window):
644 Remove; unused.
46a4ce9e
PE
645 (window_body_lines): Now static.
646 (Fdelete_other_windows_internal): Mark vars as initialized.
647 Make sure 'resize_failed' is initialized.
648 (run_window_configuration_change_hook): Rename local to avoid shadowing.
649 (resize_window_apply): Remove unused local.
650 * window.h (delete_deletable_window): Remove decl.
651
109e28d0 652 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
653 (imagemagick_load_image): Fix pointer signedness problem by changing
654 last arg from unsigned char * to char *. All uses changed.
655 Also, fix a local for similar reasons.
656 Remove unused locals. Remove locals to avoid shadowing.
657 (fn_rsvg_handle_free): Remove; unused.
658 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 659 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 660
3f754b86
PE
661 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
662
2547adb1
CY
6632011-06-10 Chong Yidong <cyd@stupidchicken.com>
664
665 * image.c (gif_load): Fix omitted cast error introduced by
666 2011-06-06 change.
667
2c8e37d4
MR
6682011-06-10 Martin Rudalics <rudalics@gmx.at>
669
670 * window.h (resize_proportionally, orig_total_lines)
671 (orig_top_line): Remove from window structure.
672 (set_window_height, set_window_width, change_window_heights)
673 (Fdelete_window): Remove prototypes.
674 (resize_frame_windows): Remove duplicate declaration.
675
440a42e3
EZ
6762011-06-10 Eli Zaretskii <eliz@gnu.org>
677
678 * window.h (resize_frame_windows, resize_window_check)
679 (delete_deletable_window, resize_root_window)
680 (resize_frame_windows): Declare prototypes.
681
682 * window.c (resize_window_apply): Make definition be "static" to
683 match the prototype.
684
562dd5e9
MR
6852011-06-10 Martin Rudalics <rudalics@gmx.at>
686
687 * window.c: Remove declarations of Qwindow_size_fixed,
688 window_min_size_1, window_min_size_2, window_min_size,
689 size_window, window_fixed_size_p, enlarge_window, delete_window.
690 Remove static from declaration of Qdelete_window, it's
691 temporarily needed by Fbury_buffer.
692 (replace_window): Don't assign orig_top_line and
693 orig_total_lines.
694 (Fdelete_window, delete_window): Remove. Window deletion is
695 handled by window.el.
696 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
697 Fdelete_window calls with calls to Qdelete_window.
698 (Fdelete_other_windows): Remove. Deleting other windows is
699 handled by window.el.
700 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
701 handled in window.el.
702 (window_min_size_2, window_min_size_1, window_min_size): Remove.
703 Window minimum sizes are handled in window.el.
704 (shrink_windows, size_window, set_window_height)
705 (set_window_width, change_window_heights, window_height)
706 (window_width, CURBEG, CURSIZE, enlarge_window)
707 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
708 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
709 handled in window.el.
710 (make_dummy_parent): Rename to make_parent_window and give it a
711 second argument horflag.
712 (make_window): Don't set resize_proportionally any more.
713 (Fsplit_window): Remove. Windows are split in window.el.
714 (save_restore_action, save_restore_orig_size)
715 (shrink_window_lowest_first, save_restore_orig_size): Remove.
716 Resize mini windows in window.el.
717 (grow_mini_window, shrink_mini_window): Implement by calling
718 Qresize_root_window_vertically, resize_window_check and
719 resize_window_apply.
720 (saved_window, Fset_window_configuration, save_window_save): Do
721 not handle orig_top_line, orig_total_lines, and
722 resize_proportionally.
723 (window_min_height, window_min_width): Move to window.el.
724 (keys_of_window): Move bindings for delete-other-windows,
725 split-window, delete-window and enlarge-window to window.el.
726
727 * buffer.c: Temporarily extern Qdelete_window.
728 (Fbury_buffer): Temporarily call Qdelete_window instead of
729 Fdelete_window (Fbury_buffer will move to window.el soon).
730
731 * frame.c (set_menu_bar_lines_1): Remove code handling
732 orig_top_line and orig_total_lines.
733
734 * dispnew.c (adjust_frame_glyphs_initially): Don't use
735 set_window_height but set heights directly.
736 (change_frame_size_1): Use resize_frame_windows.
737
738 * xdisp.c (init_xdisp): Don't use set_window_height but set
739 heights directly.
740
741 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
742 resize_frame_windows instead of change_window_heights and run
743 run_window_configuration_change_hook.
744
745 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
746 instead of change_window_heights and run
747 run_window_configuration_change_hook.
748
1a13852e
MR
7492011-06-09 Martin Rudalics <rudalics@gmx.at>
750
751 * window.c (replace_window): Rename second argument REPLACEMENT to
752 NEW. New third argument SETFLAG. Rewrite.
753 (delete_window, make_dummy_parent): Call replace_window with
754 third argument 1.
755 (window_list_1): Move down in code.
756 (run_window_configuration_change_hook): Move set_buffer part
757 before select_frame_norecord part in order to unwind correctly.
758 Rename count1 to count.
759 (recombine_windows, delete_deletable_window, resize_root_window)
760 (Fdelete_other_windows_internal)
761 (Frun_window_configuration_change_hook, make_parent_window)
762 (resize_window_check, resize_window_apply, Fresize_window_apply)
763 (resize_frame_windows, Fsplit_window_internal)
764 (Fdelete_window_internal, Fresize_mini_window_internal): New
765 functions.
766 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
767
f3d1777e
MR
7682011-06-08 Martin Rudalics <rudalics@gmx.at>
769
496e208e
MR
770 * window.h (window): Add some new members to window structure -
771 normal_lines, normal_cols, new_total, new_normal, clone_number,
772 splits, nest, prev_buffers, next_buffers.
773 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 774 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 775
f3d1777e
MR
776 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
777 Remove.
496e208e
MR
778 (make_dummy_parent): Set new members of windows structure.
779 (make_window): Move down in code. Handle new members of window
780 structure.
781 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
782 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
783 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
784 (Fset_window_prev_buffers, Fwindow_next_buffers)
785 (Fset_window_next_buffers, Fset_window_clone_number): New
786 functions.
787 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
788 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
789 Doc-string fixes.
790 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
791 Argument WINDOW can be now internal window too.
792 (Fwindow_use_time): Move up in code.
793 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
794 Rewrite doc-string.
795 (Fset_window_configuration, saved_window)
796 (Fcurrent_window_configuration, save_window_save): Handle new
797 members of window structure.
b9e809c2
MR
798 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
799 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
800 (syms_of_window): New Lisp objects Qrecord_window_buffer,
801 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
802 Qget_mru_window, Qresize_root_window,
803 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
804 Qauto_buffer_name; staticpro them.
f3d1777e 805
abde8f8c
MR
8062011-06-07 Martin Rudalics <rudalics@gmx.at>
807
808 * window.c (Fwindow_total_size, Fwindow_left_column)
809 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
810 (Fwindow_list_1): New functions.
811 (window_box_text_cols): Replace with window_body_cols.
812 (Fwindow_width, Fscroll_left, Fscroll_right): Use
813 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
814 (delete_window, Fset_window_configuration): Call
815 delete_all_subwindows with window as argument.
816 (delete_all_subwindows): Take a window as argument and not a
817 structure. Rewrite.
190b47e6
MR
818 (window_loop): Remove handling of GET_LRU_WINDOW and
819 GET_LARGEST_WINDOW.
820 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
821
822 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
823 window_box_text_cols. delete_all_subwindows now takes a
824 Lisp_Object as argument.
abde8f8c
MR
825
826 * indent.c (compute_motion, Fcompute_motion): Use
827 window_body_cols instead of window_box_text_cols.
828
fa8a67e6
MR
829 * frame.c (delete_frame): Call delete_all_subwindows with root
830 window as argument.
831
a54e3482
DC
8322011-06-07 Daniel Colascione <dan.colascione@gmail.com>
833
834 * fns.c (Fputhash): Document return value.
835
60002bf5
CY
8362011-06-06 Chong Yidong <cyd@stupidchicken.com>
837
838 * image.c (gif_load): Implement gif89a spec "no disposal" method.
839
0c671da6 8402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 841
b862a52a 842 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 843
be44ca6c
PE
844 Check for overflow when converting integer to cons and back.
845 * charset.c (Fdefine_charset_internal, Fdecode_char):
846 Use cons_to_unsigned to catch overflow.
847 (Fencode_char): Use INTEGER_TO_CONS.
848 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
849 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
850 * data.c (long_to_cons, cons_to_long): Remove.
851 (cons_to_unsigned, cons_to_signed): New functions.
852 These signal an error for invalid or out-of-range values.
853 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
854 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
855 * font.c (Ffont_variation_glyphs):
856 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
857 * lisp.h: Include <intprops.h>.
858 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
859 (cons_to_signed, cons_to_unsigned): New decls.
860 (long_to_cons, cons_to_long): Remove decls.
861 * undo.c (record_first_change): Use INTEGER_TO_CONS.
862 (Fprimitive_undo): Use CONS_TO_INTEGER.
863 * xfns.c (Fx_window_property): Likewise.
864 * xselect.c: Include <limits.h>.
865 (x_own_selection, selection_data_to_lisp_data):
866 Use INTEGER_TO_CONS.
867 (x_handle_selection_request, x_handle_selection_clear)
868 (x_get_foreign_selection, Fx_disown_selection_internal)
869 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
870 (lisp_data_to_selection_data): Use cons_to_unsigned.
871 (x_fill_property_data): Use cons_to_signed.
872 Report values out of range.
873
d1f3d2af
PE
874 Check for buffer and string overflow more precisely.
875 * buffer.h (BUF_BYTES_MAX): New macro.
876 * lisp.h (STRING_BYTES_MAX): New macro.
877 * alloc.c (Fmake_string):
878 * character.c (string_escape_byte8):
879 * coding.c (coding_alloc_by_realloc):
880 * doprnt.c (doprnt):
881 * editfns.c (Fformat):
882 * eval.c (verror):
883 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
884 since they may not be the same number.
885 * editfns.c (Finsert_char):
886 * fileio.c (Finsert_file_contents):
887 Likewise for BUF_BYTES_MAX.
888
dd52fcea
PE
889 * image.c: Use ptrdiff_t, not int, for sizes.
890 (slurp_file): Switch from int to ptrdiff_t.
891 All uses changed.
892 (slurp_file): Check that file size fits in both size_t (for
893 malloc) and ptrdiff_t (for sanity and safety).
894
7f9bbdbb
PE
895 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
896 if b->modtime has its maximal value.
897
dfe18f82
PE
898 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
899
84acfcf0
PE
900 Don't assume time_t can fit into int.
901 * buffer.h (struct buffer.modtime): Now time_t, not int.
902 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
903 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
904
ccd9a01a
PE
905 Minor fixes for signed vs unsigned integers.
906 * character.h (MAYBE_UNIFY_CHAR):
907 * charset.c (maybe_unify_char):
908 * keyboard.c (read_char, reorder_modifiers):
909 XINT -> XFASTINT, since the integer must be nonnegative.
910 * ftfont.c (ftfont_spec_pattern):
911 * keymap.c (access_keymap, silly_event_symbol_error):
912 XUINT -> XFASTINT, since the integer must be nonnegative.
913 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
914 since it makes no difference and we prefer signed.
915 * keyboard.c (record_char): Use XUINT when all the neighbors do.
916 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
917 nonnegative.
918
d6d100dd
SM
9192011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
920
921 * window.h (Fwindow_frame): Declare.
922
2b6148e4
PE
9232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
924
925 * alloc.c: Simplify handling of large-request failures (Bug#8800).
926 (SPARE_MEMORY): Always define.
927 (LARGE_REQUEST): Remove.
928 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
929
f230ecc9
MR
9302011-06-06 Martin Rudalics <rudalics@gmx.at>
931
727e958e
MR
932 * lisp.h: Move EXFUNS for Fframe_root_window,
933 Fframe_first_window and Fset_frame_selected_window to window.h.
934
935 * window.h: Move EXFUNS for Fframe_root_window,
936 Fframe_first_window and Fset_frame_selected_window here from
937 lisp.h.
938
939 * frame.c (Fwindow_frame, Fframe_first_window)
940 (Fframe_root_window, Fframe_selected_window)
941 (Fset_frame_selected_window): Move to window.c.
942 (Factive_minibuffer_window): Move to minibuf.c.
943 (Fother_visible_frames_p): New function.
944
945 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
946
f230ecc9
MR
947 * window.c (decode_window, decode_any_window): Move up in code.
948 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
949 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
950 (Fwindow_buffer): Move up and rewrite doc-string.
951 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
952 (Fwindow_prev): New functions.
727e958e
MR
953 (Fwindow_frame): Move here from frame.c. Accept any window as
954 argument.
955 (Fframe_root_window, Fframe_first_window)
956 (Fframe_selected_window): Move here from frame.c. Accept frame
957 or arbitrary window as argument. Update doc-strings.
958 (Fminibuffer_window): Move up in code.
959 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
960 (Fset_frame_selected_window): Move here from frame.c.
961 Marginal rewrite.
727e958e
MR
962 (Fselected_window, select_window, Fselect_window): Move up in
963 code. Minor doc-string fixes.
f230ecc9 964
4d09bcf6
PE
9652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
966
967 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
968 Do not assume that spare memory exists; that assumption is valid
969 only if SYSTEM_MALLOC.
970 (LARGE_REQUEST): New macro, so that the issue of large requests
971 is separated from the issue of spare memory.
972
810928a2
AS
9732011-06-05 Andreas Schwab <schwab@linux-m68k.org>
974
172418ad
AS
975 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
976 format. (Bug#8806)
977
43f862f7
AS
978 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
979
810928a2
AS
980 * xfns.c (x_set_scroll_bar_default_width): Move declarations
981 before statements.
982
a059fe24
JD
9832011-06-05 Jan Djärv <jan.h.d@swipnet.se>
984
985 * gtkutil.c (xg_get_default_scrollbar_width): New function.
986
987 * gtkutil.h: Declare xg_get_default_scrollbar_width.
988
989 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
990 min width by calling x_set_scroll_bar_default_width (Bug#8505).
991
989bf368
JB
9922011-06-05 Juanma Barranquero <lekktu@gmail.com>
993
994 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
995
4b80f674
CY
9962011-06-04 Chong Yidong <cyd@stupidchicken.com>
997
998 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
999 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1000 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1001 New error handlers.
4b80f674
CY
1002 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1003 Obey Vx_select_enable_clipboard_manager. Catch errors in
1004 x_clipboard_manager_save (Bug#8779).
1005 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1006 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1007
99a33b77 10082011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1009
1010 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1011
99a33b77 10122011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1013
1014 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1015 in the current matrix if keep_current_p is non-zero.
1016
8264569d
EZ
10172011-06-04 Eli Zaretskii <eliz@gnu.org>
1018
1019 * bidi.c (bidi_level_of_next_char): Fix last change.
1020
57f97249
EZ
10212011-06-03 Eli Zaretskii <eliz@gnu.org>
1022
fec2107c 1023 Support bidi reordering of text covered by display properties.
57f97249 1024
fec2107c
EZ
1025 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1026 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1027 (bidi_cache_search, bidi_cache_iterator_state)
1028 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1029 (bidi_level_of_next_char, bidi_move_to_visually_next):
1030 Support character positions inside a run of characters covered by a
fec2107c
EZ
1031 display string.
1032 (bidi_paragraph_init, bidi_resolve_explicit_1)
1033 (bidi_level_of_next_char): Call bidi_fetch_char and
1034 bidi_fetch_char_advance instead of FETCH_CHAR and
1035 FETCH_CHAR_ADVANCE.
1036 (bidi_init_it): Initialize new members.
1037 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1038 definitions.
1039 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1040 instead of using explicit *_CHAR codes.
d6d100dd
SM
1041 (bidi_resolve_explicit, bidi_resolve_weak):
1042 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1043 bidirectional text is supported only in multibyte buffers.
1044 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1045 it to initialize the frame_window_p member of struct bidi_it.
1046 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1047 (bidi_resolve_explicit, bidi_resolve_weak)
1048 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1049 bidi_it->nchars is non-positive.
1050 (bidi_level_of_next_char): Don't try to lookup the cache for the
1051 next/previous character if nothing is cached there yet, or if we
1052 were just reseat()'ed to a new position.
c40e2fb2 1053
0e14fe90
EZ
1054 * xdisp.c (set_cursor_from_row): Set start and stop points
1055 according to the row's direction when priming the loop that looks
1056 for the glyph on which to display cursor.
1057 (single_display_spec_intangible_p): Function deleted.
1058 (display_prop_intangible_p): Reimplement to call
1059 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1060 Accept 3 additional arguments needed by handle_display_spec.
1061 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1062 values: lists, `(when COND...)' forms, etc.
1063 (single_display_spec_string_p): Support property values that are
1064 lists with the argument STRING its top-level element.
1065 (display_prop_string_p): Fix the condition for processing a
1066 property that is a list to be consistent with handle_display_spec.
fec2107c 1067 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1068 last portion of handle_display_prop.
1069 (compute_display_string_pos): Accept additional argument
1070 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1071 value of a `display' property is a "replacing spec".
1072 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1073 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1074 the display property, but just return a value indicating whether
1075 the display property will replace the characters it covers.
1076 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1077 frame_window_p members of struct bidi_it.
d6d100dd
SM
1078 (compute_display_string_pos, compute_display_string_end):
1079 New functions.
fec2107c
EZ
1080 (push_it): Accept second argument POSITION, where pop_it should
1081 jump to continue iteration.
1082 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1083
fec2107c
EZ
1084 * keyboard.c (adjust_point_for_property): Adjust the call to
1085 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1086
1087 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1088 (bidi_init_it): Update prototypes.
1089 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1090 (compute_display_string_pos, compute_display_string_end):
1091 Declare prototypes.
fec2107c
EZ
1092 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1093 EMACS_INT.
fc6f18ce 1094
40087514 10952011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1096
57f53182
PE
1097 Malloc failure behavior now depends on size of allocation.
1098 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1099 * lisp.h: Change signatures accordingly.
1100 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1101 All callers changed. (Bug#8762)
1102
1103 * gnutls.c: Use Emacs's memory allocators.
1104 Without this change, the gnutls library would invoke malloc etc.
1105 directly, which causes problems on non-SYNC_INPUT hosts, and which
1106 runs afoul of improving memory_full behavior. (Bug#8761)
1107 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1108 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1109 xfree instead of the default malloc, realloc, free.
1110 (Fgnutls_boot): No need to check for memory allocation failure,
1111 since xmalloc does that for us.
1112
ac32cd99 1113 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1114 * category.c (hash_get_category_set):
1115 * ccl.c (ccl_driver):
1116 * charset.c (Fdefine_charset_internal):
1117 * charset.h (struct charset.hash_index):
1118 * composite.c (get_composition_id, gstring_lookup_cache)
1119 (composition_gstring_put_cache):
1120 * composite.h (struct composition.hash_index):
1121 * dispextern.h (struct image.hash):
1122 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1123 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1124 (hashfn_equal, hashfn_user_defined, make_hash_table)
1125 (maybe_resize_hash_table, hash_lookup, hash_put)
1126 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1127 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1128 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1129 * image.c (make_image, search_image_cache, lookup_image)
1130 (xpm_put_color_table_h):
1131 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1132 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1133 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1134 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1135 * alloc.c (allocate_vectorlike):
1136 Check for overflow in vector size calculations.
1137 * ccl.c (ccl_driver):
1138 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1139 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1140 need to be updated by these changes.
40087514
PE
1141 * fns.c (make_hash_table, maybe_resize_hash_table):
1142 Check for integer overflow with large hash tables.
0de4bb68
PE
1143 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1144 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1145 (SXHASH_REDUCE): New macro.
1146 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1147 Use it instead of discarding useful hash info with large hash values.
1148 (sxhash_float): New function.
1149 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1150 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1151 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1152 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1153 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1154 Adjust signatures to match updated version of code.
1155 (consing_since_gc): Now EMACS_INT, since a single hash table can
1156 use more than INT_MAX bytes.
1157
698d32e2
DN
11582011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1159
1160 Make it possible to build with GCC-4.6+ -O2 -flto.
1161
1162 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1163
fd6fa53f
SM
11642011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1165
1166 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1167 Call minibuffer-inactive-mode.
1168
864db017
JB
11692011-05-31 Juanma Barranquero <lekktu@gmail.com>
1170
1171 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1172 Update dependencies.
1173
2ad0baf4
DN
11742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1175
1176 * data.c (init_data): Remove code for UTS, this system is not
1177 supported anymore.
1178
4fcc2638
DN
11792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1180
1181 Don't force ./temacs to start in terminal mode.
1182
1183 * frame.c (make_initial_frame): Initialize faces in all cases, not
1184 only when CANNOT_DUMP is defined.
1185 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1186
c56e0fd5
DN
11872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1188
1189 * dispnew.c (add_window_display_history): Use const for the string
1190 pointer. Remove declaration, not needed.
1191
333d54da 11922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1193
55d4c1b2 1194 Use 'inline', not 'INLINE'.
333d54da 1195 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1196 * alloc.c, fontset.c (INLINE): Remove.
1197 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1198 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1199 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1200 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1201 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1202
738db178
DN
12032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1204
1205 Make it possible to run ./temacs.
1206
1207 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1208 syms_of_callproc does the same thing. Remove test for
1209 "initialized", do it in the caller.
1210 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1211
620c53a6
SM
12122011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1213
1214 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1215 (read_minibuf): Use get_minibuffer.
1216 (syms_of_minibuf): Use DEFSYM.
1217 (Qmetadata): New var.
1218 * data.c (Qbuffer): Don't make it static.
1219 (syms_of_data): Use DEFSYM.
1220
e003a292
PE
12212011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1222
1223 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1224 (CCL_CODE_MIN): New macro.
1225
ed008a6d
PE
12262011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1227
3687c2ef
PE
1228 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1229
ed008a6d
PE
1230 * eval.c (Qdebug): Now static.
1231 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1232 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1233 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1234
d66c4c7c
CY
12352011-05-29 Chong Yidong <cyd@stupidchicken.com>
1236
1237 * image.c: Various fixes to ImageMagick code comments.
1238 (Fimagemagick_types): Doc fix.
1239
5fbc2025
PE
12402011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1241
0196f88a
PE
1242 Minor fixes prompted by GCC 4.6.0 warnings.
1243
1244 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1245
5fbc2025
PE
1246 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1247 (x_clipboard_manager_save_all): Move extern decl to ...
1248 * xterm.h: ... here, so that it can be checked for consistency.
1249
1dd3c2d9
CY
12502011-05-29 Chong Yidong <cyd@stupidchicken.com>
1251
1252 * xselect.c (x_clipboard_manager_save_frame)
1253 (x_clipboard_manager_save_all): New functions.
1254 (Fx_clipboard_manager_save): Lisp function deleted.
1255
1256 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1257 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1258
1259 * xterm.h: Update prototype.
1260
5ba6571d
WX
12612011-05-28 William Xu <william.xwl@gmail.com>
1262
1263 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1264 exiting (Bug#8239).
1265
3eaff834
JM
12662011-05-28 Jim Meyering <meyering@redhat.com>
1267
e1900994 1268 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1269 * fns.c (to_uchar): Define.
1270 (crypto_hash_function): Use it to convert some newly-signed
1271 variables to unsigned, to avoid sign-extension bugs. For example,
1272 without this change, (md5 "truc") would evaluate to
1273 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1274 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1275 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1276
0f6990a7
PE
12772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1278
1279 Integer overflow fixes.
c8a9ca5a 1280
08686060
PE
1281 * dbusbind.c: Serial number integer overflow fixes.
1282 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1283 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1284 to hold a serial number that is too large for a fixnum.
1285 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1286 Check for serial numbers out of range. Decode any serial number
59568bf0 1287 that was so large that it became a float. (Bug#8722)
08686060 1288
2d1fc3c7
PE
1289 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1290 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1291 Use XFASTINT rather than XUINT when numbers are nonnegative.
1292 (xd_append_arg, Fdbus_method_return_internal):
1293 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1294 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1295 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1296 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1297 (Bug#8722)
2d1fc3c7 1298
c8a9ca5a
PE
1299 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1300
519e1d69
PE
1301 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1302
30569699
PE
1303 ccl: add integer overflow checks
1304 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1305 (IN_INT_RANGE): New macros.
1306 (ccl_driver): Use them to check for integer overflow when
1307 decoding a CCL program. Many of the new checks are whether XINT (x)
1308 fits in int; it doesn't always, on 64-bit hosts. The new version
1309 doesn't catch all possible integer overflows, but it's an
847044ea 1310 improvement. (Bug#8719)
30569699 1311
c11285dc
PE
1312 * alloc.c (make_event_array): Use XINT, not XUINT.
1313 There's no need for unsigned here.
1314
fdccd48e
PE
1315 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1316 This follows up to the 2011-05-06 change that substituted uintptr_t
1317 for EMACS_INT. This case wasn't caught back then.
1318
37910ab2
PE
1319 Rework Fformat to avoid integer overflow issues.
1320 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1321 now (part of C89). Include <verify.h>.
1322 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1323 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1324 (Fformat): Avoid the prepass trying to compute sizes; it was only
1325 approximate and thus did not catch overflow reliably. Instead, walk
1326 through the format just once, formatting and computing sizes as we go,
1327 checking for integer overflow at every step, and allocating a larger
1328 buffer as needed. Keep track separately whether the format is
1329 multibyte. Keep only the most-recently calculated precision, rather
1330 than them all. Record whether each argument has been converted to
1331 string. Use EMACS_INT, not int, for byte and char and arg counts.
1332 Support field widths and precisions larger than INT_MAX. Avoid
1333 sprintf's undefined behavior with conversion specifications such as %#d
1334 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1335 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1336 formatting out-of-range floating point numbers with int
1337 formats. (Bug#8668)
1338
2e6578fb
PE
1339 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1340
0ae6bdee
PE
1341 * data.c: Avoid integer truncation in expressions involving floats.
1342 * data.c: Include <intprops.h>.
1343 (arith_driver): When there's an integer overflow in an expression
1344 involving floating point, convert the integers to floating point
1345 so that the resulting value does not suffer from catastrophic
1346 integer truncation. For example, on a 64-bit host (* 4
1347 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1348 Do not rely on undefined behavior after integer overflow.
1349
de883a70
PE
1350 merge count_size_as_multibyte, parse_str_to_multibyte
1351 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1352 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1353 Check for integer overflow.
1354 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1355 since it's now a duplicate of the other. This is more of
1356 a character than a buffer op, so better that it's in character.c.
1357 * fns.c, print.c: Adjust to above changes.
1358
2ff916cb
PE
13592011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1360
1361 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1362
f1b54466
PE
13632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1364
fb1ac845
PE
1365 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1366 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1367 (x_clipboard_manager_save): Now static.
1368 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1369
f1b54466
PE
1370 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1371 (crypto_hash_function): Now static.
1372 Fix pointer signedness problems. Avoid unnecessary initializations.
1373
a9f737ee
CY
13742011-05-27 Chong Yidong <cyd@stupidchicken.com>
1375
1376 * termhooks.h (Vselection_alist): Make it terminal-local.
1377
1378 * terminal.c (create_terminal): Initialize it.
1379
1380 * xselect.c: Support for clipboard managers.
1381 (Vselection_alist): Move to termhooks.h as terminal-local var.
1382 (LOCAL_SELECTION): New macro.
1383 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1384 (symbol_to_x_atom): Remove gratuitous arg.
1385 (x_handle_selection_request, lisp_data_to_selection_data)
1386 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1387 (x_own_selection, x_get_local_selection, x_convert_selection):
1388 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1389 (some_frame_on_display): Delete unused function.
1390 (Fx_own_selection_internal, Fx_get_selection_internal)
1391 (Fx_disown_selection_internal, Fx_selection_owner_p)
1392 (Fx_selection_exists_p): New optional frame arg.
1393 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1394 (x_handle_selection_clear): Don't treat other terminals with the
1395 same keyboard specially. Use the terminal-local Vselection_alist.
1396 (x_clear_frame_selections): Use Frun_hook_with_args.
1397
1398 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1399
1400 * xterm.h: Add support for those atoms.
1401
e067f0c1
CY
14022011-05-26 Chong Yidong <cyd@stupidchicken.com>
1403
1404 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1405 (converted_selections, conversion_fail_tag): New global variables.
1406 (x_selection_request_lisp_error): Free the above.
1407 (x_get_local_selection): Remove unnecessary code.
1408 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1409 of converted selections stored in converted_selections.
1410 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1411 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1412 (x_convert_selection): New function.
1413 (x_handle_selection_event): Simplify.
1414 (x_get_foreign_selection): Don't ignore incoming requests while
1415 waiting for an answer; this will fail when we implement
1416 SAVE_TARGETS, and seems unnecessary anyway.
1417 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1418 (Vx_sent_selection_functions): Doc fix.
1419
0f4aebc0
LL
14202011-05-26 Leo Liu <sdl.web@gmail.com>
1421
1422 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1423
e61124cd
YM
14242011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1425
1426 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1427
1428 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1429 for fringe update if it has periodic bitmap.
1430 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1431 and fringe_bitmap_periodic_p.
1432
1433 * fringe.c (get_fringe_bitmap_data): New function.
1434 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1435 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1436 row. Mark glyph row for fringe update if periodicity changed.
1437
1438 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1439 for fringe update unless it has periodic bitmap.
1440
f16d9837
KH
14412011-05-25 Kenichi Handa <handa@m17n.org>
1442
1443 * xdisp.c (get_next_display_element): Set correct it->face_id for
1444 a static composition.
1445
e1b90ef6
LL
14462011-05-24 Leo Liu <sdl.web@gmail.com>
1447
1448 * deps.mk (fns.o):
1449 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1450
1451 * fns.c (crypto_hash_function, Fsha1): New function.
1452 (Fmd5): Use crypto_hash_function.
1453 (syms_of_fns): Add Ssha1.
1454
7400048f
PE
14552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1456
1457 * gnutls.c: Remove unused macros.
1458 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1459 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1460 Remove macros that are defined and never used.
1461 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1462
abb71cf4
CY
14632011-05-22 Chong Yidong <cyd@stupidchicken.com>
1464
1465 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1466 (Fx_get_selection_internal): Minor cleanup.
1467 (Fx_own_selection_internal): Rename arguments for consistency with
1468 select.el.
1469
6307db39
PE
14702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1471
1472 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1473
f3d4e0a4
CY
14742011-05-22 Chong Yidong <cyd@stupidchicken.com>
1475
1476 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1477
4d8ade89
YM
14782011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1479
1480 * dispnew.c (scrolling_window): Don't exclude the case that the
1481 last enabled row in the desired matrix touches the bottom boundary.
1482
32078c8d
GM
14832011-05-21 Glenn Morris <rgm@gnu.org>
1484
1485 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1486 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1487 and add some more files.
32078c8d 1488
7285dc67
EZ
14892011-05-20 Eli Zaretskii <eliz@gnu.org>
1490
1491 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1492 report_file_error introduced by the change from 2011-05-07.
1493
89d1bd22
PE
14942011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1495
1496 * systime.h (Time): Define only if emacs is defined.
1497 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1498 where the include path doesn't have X11/X.h by default. See
1499 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1500
e23640bb 15012011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1502
1503 * composite.c (find_automatic_composition): Fix previous change.
1504
b9704ad9
GM
15052011-05-20 Glenn Morris <rgm@gnu.org>
1506
1507 * lisp.mk: New file, split from Makefile.in.
1508 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1509 (shortlisp): Remove.
1510 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1511
4a720484
GM
15122011-05-19 Glenn Morris <rgm@gnu.org>
1513
1514 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1515 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1516 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1517 (lisp): Set the order to that of loadup.el.
1518 (shortlisp): Make it a copy of $lisp.
1519 (SOME_MACHINE_LISP): Remove.
1520 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1521 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1522
a28d4396
KH
15232011-05-18 Kenichi Handa <handa@m17n.org>
1524
1525 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1526 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1527 (find_automatic_composition): Mostly rewrite for efficiency.
1528
a2b1fa8e
JB
15292011-05-18 Juanma Barranquero <lekktu@gmail.com>
1530
1531 * makefile.w32-in: Update dependencies.
1532
8e1f5610
CS
15332011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1534
1535 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1536 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1537
7025ee00 15382011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1539
cdfa6eab
PE
1540 Fix some integer overflow issues, such as string length overflow.
1541
06d6db33
PE
1542 * insdel.c (count_size_as_multibyte): Check for string overflow.
1543
2b4560a8
PE
1544 * character.c (lisp_string_width): Check for string overflow.
1545 Use EMACS_INT, not int, for string indexes and lengths; in
1546 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1547 the resulting string length overflows an EMACS_INT; instead,
1548 report a string overflow if no precision given. When checking for
1549 precision exhaustion, use a check that cannot possibly have
1550 integer overflow. (Bug#8675)
1551 * character.h (lisp_string_width): Adjust to new signature.
1552
cb93f9be
PE
1553 * alloc.c (string_overflow): New function.
1554 (Fmake_string): Use it. This doesn't change behavior, but saves
1555 a few bytes and will simplify future changes.
1556 * character.c (string_escape_byte8): Likewise.
1557 * lisp.h (string_overflow): New decl.
1558
1a1f3366
PE
1559 Fixups, following up to the user-interface timestamp change.
1560 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1561 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1562 * msdos.c (mouse_get_pos): Likewise.
1563 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1564 * w32gui.h (Time): Define by including "systime.h" rather than by
1565 declaring it ourselves. (Bug#8664)
1566
d4e3e4d3
PE
1567 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1568 * image.c (clear_image_cache): Likewise.
1569
f6a24d19
PE
1570 * term.c (term_mouse_position): Don't assume time_t wraparound.
1571
08dc5ae6
PE
1572 Be more systematic about user-interface timestamps.
1573 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1574 and sometimes 'EMACS_UINT', to represent these timestamps.
1575 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1576 This makes the code easier to follow, and makes it easier to catch
1577 integer overflow bugs such as Bug#8664.
1578 * frame.c (Fmouse_position, Fmouse_pixel_position):
1579 Use Time, not unsigned long, for user-interface timestamps.
1580 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1581 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1582 * keyboard.h (last_event_timestamp): Likewise.
1583 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1584 * menu.h (xmenu_show): Likewise.
1585 * term.c (term_mouse_position): Likewise.
1586 * termhooks.h (struct input_event.timestamp): Likewise.
1587 (struct terminal.mouse_position_hook): Likewise.
1588 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1589 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1590 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1591 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1592 what it was before.
1593 * menu.h, termhooks.h: Include "systime.h", for Time.
1594
8e55734a
PE
1595 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1596 Don't assume that the difference between two unsigned long values
1597 can fit into an integer. At this point, we know button_down_time
1598 <= event->timestamp, so the difference must be nonnegative, so
1599 there's no need to cast the result if double-click-time is
1600 nonnegative, as it should be; check that it's nonnegative, just in
1601 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1602 apart (about 25 days). (Bug#8664)
8e55734a 1603
841f1b75 1604 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1605 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1606
3e26f69c
PE
1607 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1608 that always fit in int. Use a sentinel instead of a counter, to
1609 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1610 * frame.h (struct frame): Use int for menu_bar_items_used
1611 instead of EMACS_INT, since it always fits in int.
3e26f69c 1612
5cc152c0
PE
1613 * menu.c (grow_menu_items): Check for int overflow.
1614
d89eb65e
PE
1615 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1616
5235bd3e
PE
1617 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1618 Before, the code was not consistent. These values cannot exceed
1619 2**31 - 1 so there's no need to make them unsigned.
1620 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1621 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1622 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1623 as modifiers.
1624 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1625
bc827e23
PE
1626 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1627 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1628 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1629 presumably because the widths might not match.
1630
78eb494e
PE
1631 * window.c (size_window): Avoid needless test at loop start.
1632
04f2d78b
CB
16332011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1634
1635 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1636
d2fc7e3d 16372011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1638
1639 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1640
d2fc7e3d 16412011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1642
1643 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1644 `width' to `bar_area_x' and `bar_area_width', respectively.
1645 (x_scroll_run): Take account of fringe background extension.
1646
04f2d78b
CB
1647 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1648 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1649 `bar_area_width', respectively.
1650 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1651 background extension.
1652
79b70037
GM
16532011-05-10 Jim Meyering <meyering@redhat.com>
1654
1655 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1656
2f142cc5
JB
16572011-05-10 Juanma Barranquero <lekktu@gmail.com>
1658
1659 * image.c (Finit_image_library): Return t for built-in image types,
1660 like pbm and xbm. (Bug#8640)
1661
57679c86
AS
16622011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1663
1664 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1665
888c9e86
EZ
16662011-05-07 Eli Zaretskii <eliz@gnu.org>
1667
b0512a1d
EZ
1668 * w32console.c (Fset_screen_color): Doc fix.
1669 (Fget_screen_color): New function.
1670 (syms_of_ntterm): Defsubr it.
1671
7285dc67
EZ
1672 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1673 unlink the temporary file if Fcall_process didn't create it in the
1674 first place.
1675 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1676 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1677 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1678 cue to call_process_cleanup not to close that handle.
1679
4d3fcc8e
BK
16802011-05-07 Ben Key <bkey76@gmail.com>
1681
1682 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1683 one of two shell specific rules, either bootstrap-temacs-CMD or
1684 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1685 to the previous implementation of the bootstrap-temacs rule.
1686 The bootstrap-temacs-CMD rule is similar to the previous
1687 implementation of the bootstrap-temacs rule except that it
1688 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1689 variable.
1690
1691 These changes, along with some changes to nt/configure.bat,
1692 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1693 earlier fix to add support for --cflags and --ldflags options
1694 that include quotes so that it works whether make uses cmd or
1695 sh as the shell.
1696
b4289b64
MA
16972011-05-06 Michael Albinus <michael.albinus@gmx.de>
1698
1699 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1700 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1701 is a constant.
1702 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1703 a string. Handle both cases.
1704 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1705 (Fdbus_register_method): Use Qinvalid_function.
1706
af4c0e28
JB
17072011-05-06 Juanma Barranquero <lekktu@gmail.com>
1708
1709 * makefile.w32-in: Update dependencies.
1710 (LISP_H): Add inttypes.h and stdin.h.
1711 (PROCESS_H): Add unistd.h.
1712
c51453d9
EZ
17132011-05-06 Eli Zaretskii <eliz@gnu.org>
1714
1715 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1716 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1717
8ff0ac3c 17182011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1719
4c4b566b
PE
1720 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1721
aab2b9b5
PE
1722 * term.c (vfatal): Remove stray call to va_end.
1723 It's not needed and the C Standard doesn't allow it here anyway.
1724
c378da0b
PE
1725 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1726 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1727
288b08c7
PE
1728 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1729 bytes.
1730
e3601888
PE
1731 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1732
db6c0e74
PE
1733 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1734
dd5963ea
PE
1735 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1736
88c9450f
PE
1737 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1738
2f9442b8
PE
1739 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1740
c032b5f8
PE
1741 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1742 * charset.c (Fdefine_charset_internal): Don't initialize
1743 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1744 32-bit int (Bug#8600).
a108c10b
PE
1745
1746 * lread.c (read_integer): Be more consistent with string-to-number.
1747 Use string_to_number to do the actual conversion; this avoids
1748 rounding errors and fixes some other screwups. Without this fix,
1749 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1750 (digit_to_number): Move earlier, for benefit of read_integer.
1751 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1752 not a digit in any supported base. (Bug#8602)
a108c10b 1753
ad5f9eea
PE
1754 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1755
aec1708a
PE
1756 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1757 to match comment at start of function. This also removes a
1758 GCC warning about overflow in a 32+64-bit port.
1759
47be4ab5
PE
1760 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1761
371cac43
PE
1762 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1763 Reported by Stefan Monnier in
1764 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1765 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1766 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1767
d01a7826
PE
1768 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1769 (EMACS_UINTPTR): Likewise, with uintptr_t.
1770
7fd47d5c
PE
1771 * lisp.h: Prefer 64-bit EMACS_INT if available.
1772 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1773 on 32-bit hosts that have 64-bit int, so that they can access
1774 large files.
122b0c86
PE
1775 However, temporarily disable this change unless the temporary
1776 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1777
8727937b
PE
1778 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1779
8ac068ac
PE
1780 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1781 This removes an assumption that EMACS_INT and long are the same
1782 width as pointers. The assumption is true for Emacs porting targets
1783 now, but we want to make other targets possible.
1784 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1785 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1786 In the rest of the code, change types of integers that hold casted
1787 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1788 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1789 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1790 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1791 No need to cast type when ORing.
1792 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1793 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1794 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1795 assume EMACS_INT is the same width as char *.
1796 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1797 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1798 Remove no-longer-needed casts.
1799 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1800 (xg_tool_bar_help_callback, xg_make_tool_item):
1801 Use EMACS_INTPTR to hold an integer
1802 that will be cast to void *; this can avoid a GCC warning
1803 if EMACS_INT is not the same width as void *.
1804 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1805 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1806 (current_message_1, set_message_1):
1807 Use a local to convert to proper width without a cast.
1808 * xmenu.c (dialog_selection_callback): Likewise.
1809
ede49d71
PE
1810 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1811 Also, don't assume VALBITS / RAND_BITS is less than 5,
1812 and don't rely on undefined behavior when shifting a 1 left into
1813 the sign bit.
1814 * lisp.h (get_random): Change signature to match.
1815
2f30ecd0
PE
1816 * lread.c (hash_string): Use size_t, not int, for hash computation.
1817 Normally we prefer signed values; but hashing is special, because
1818 it's better to use unsigned division on hash table sizes so that
1819 the remainder is nonnegative. Also, size_t is the natural width
1820 for hashing into memory. The previous code used 'int', which doesn't
1821 retain enough info to hash well into very large tables.
1822 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1823
2a866e7b
PE
1824 * dbusbind.c: Don't possibly lose pointer info when converting.
1825 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1826 Use XPNTR rather than XHASH, so that the high-order bits of
1827 the pointer aren't lost when converting through void *.
1828
51639eac
PE
1829 * eval.c (Fautoload): Don't double-shift a pointer.
1830
92394119
PE
1831 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1832
dbdb9a7c
JB
18332011-05-06 Juanma Barranquero <lekktu@gmail.com>
1834
1835 * gnutls.c (DEF_GNUTLS_FN):
1836 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1837
db7a0b4f
AS
18382011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1839
1840 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1841 marker. (Bug#8610)
1842
f7ff1b0f 18432011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1844
1845 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1846 New version that can reserve upto 2GB of heap space.
1847
f7ff1b0f 18482011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1849
1850 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1851
639c109b
TZ
18522011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1853
1854 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1855 `gnutls_certificate_set_x509_key_file'.
1856
d2127135
JB
18572011-05-05 Juanma Barranquero <lekktu@gmail.com>
1858
1859 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1860 Update dependencies.
1861
e968f4f3
JB
18622011-05-04 Juanma Barranquero <lekktu@gmail.com>
1863
1864 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1865 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1866 Remove unused parameter `fildes'.
1867 * process.c (read_process_output, send_process): Don't pass it.
1868
84d358f0
JB
18692011-05-04 Juanma Barranquero <lekktu@gmail.com>
1870
1871 Fix previous change: the library cache is defined in w32.c.
1872 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1873 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1874
0898ca10
JB
18752011-05-04 Juanma Barranquero <lekktu@gmail.com>
1876
1877 Implement dynamic loading of GnuTLS on Windows.
1878
1879 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1880 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1881 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1882 Declare.
1883
1884 * gnutls.c (Qgnutls_dll): Define.
1885 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1886 (gnutls_*): Declare function pointers.
1887 (init_gnutls_functions): New function to initialize function pointers.
1888 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1889 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1890 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1891 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1892 (emacs_gnutls_write, emacs_gnutls_read)
1893 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1894 (Fgnutls_available_p): New function.
1895 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1896 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1897 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1898
1899 * image.c: Include w32.h.
1900 (Vimage_type_cache): Delete.
1901 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1902 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1903 (w32_delayed_load): Move to w32.c.
1904
1905 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1906
1907 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1908 (w32_delayed_load): Move from image.c. When loading a library, record
1909 its filename in the :loaded-from property of the library id.
1910 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1911 Initialize and staticpro them.
1912 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1913
1914 * process.c: Include lisp.h before w32.h, not after.
1915 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1916 instead of gnutls_record_check_pending.
1917
1918 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1919
ff4de4aa
TZ
19202011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1921
1922 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1923 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1924 as passed in.
1925
abe95abb
JD
19262011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1927
1928 * xterm.c (x_set_frame_alpha): Do not set property on anything
1929 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1930
e16e55d4
JB
19312011-05-02 Juanma Barranquero <lekktu@gmail.com>
1932
1933 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1934
bafcf6a5
JB
19352011-05-02 Juanma Barranquero <lekktu@gmail.com>
1936
1937 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1938 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1939 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1940 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1941 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1942 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1943 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1944 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1945 (Qgnutls_bootprop_callbacks_verify): Make static.
1946
e7a6747f
AS
19472011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1948
19ed11ba
AS
1949 * callproc.c: Indentation fixup.
1950
e7a6747f 1951 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1952 (wait_for_termination, interruptible_wait_for_termination):
1953 Move after wait_for_termination_1.
e7a6747f 1954
1ef14cb4
LMI
19552011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1956
1957 * sysdep.c (interruptible_wait_for_termination): New function
1958 which is like wait_for_termination, but allows keyboard
1959 interruptions.
1960
1961 * callproc.c (Fcall_process): Add (:file "file") as an option for
1962 the STDOUT buffer.
1963 (Fcall_process_region): Ditto.
1964
330d880c
EZ
19652011-04-30 Eli Zaretskii <eliz@gnu.org>
1966
8db90b73
EZ
1967 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1968 rather than `XVECTOR (FOO)->size'.
1969
330d880c
EZ
1970 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1971 inttypes.h, as a gnulib replacement is used if it not available in
1972 system headers.
1973
15cbd324
EZ
19742011-04-21 Eli Zaretskii <eliz@gnu.org>
1975
1976 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1977 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1978 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1979
1980 * coding.c (coding_alloc_by_realloc): Error out if destination
1981 will grow beyond MOST_POSITIVE_FIXNUM.
1982 (decode_coding_emacs_mule): Abort if there isn't enough place in
1983 charbuf for the composition carryover bytes. Reserve an extra
1984 space for up to 2 characters produced in a loop.
1985 (decode_coding_iso_2022): Abort if there isn't enough place in
1986 charbuf for the composition carryover bytes.
1987
19882011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1989
ae940cca
EZ
1990 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1991 aborting when %lld or %lll format is passed.
1992 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1993 %llo or %llx format is passed. (Bug#8545)
1994
03ab8921
EZ
1995 * window.c (window_scroll_line_based): Use a marker instead of
1996 simple variables to record original value of point. (Bug#7952)
1997
afda1437
EZ
1998 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1999 produced by %s or %c overflows available buffer space. (Bug#8545)
2000
f76dee0c
PE
20012011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2004 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2005
fdc5744d
JB
20062011-04-28 Juanma Barranquero <lekktu@gmail.com>
2007
2008 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2009
638f053a
JB
20102011-04-28 Juanma Barranquero <lekktu@gmail.com>
2011
2012 * keyboard.c (Qdelayed_warnings_hook): Define.
2013 (command_loop_1): Run `delayed-warnings-hook'
2014 if Vdelayed_warnings_list is non-nil.
2015 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2016 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2017
d178f871
EZ
20182011-04-28 Eli Zaretskii <eliz@gnu.org>
2019
2020 * doprnt.c (doprnt): Don't return value smaller than the buffer
2021 size if the message was truncated. (Bug#8545).
2022
b124fd93
JB
20232011-04-28 Juanma Barranquero <lekktu@gmail.com>
2024
2025 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2026 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2027
e810457d
PE
20282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2029
2030 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2031
ea51cceb
JB
20322011-04-27 Juanma Barranquero <lekktu@gmail.com>
2033
2034 * makefile.w32-in: Update dependencies.
2035
94dcfacf
EZ
20362011-04-27 Eli Zaretskii <eliz@gnu.org>
2037
2038 Improve `doprnt' and its usage. (Bug#8545)
2039 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2040 `format_end'. Remove support for %l as a conversion specifier.
2041 Don't use xrealloc. Improve diagnostics when the %l size modifier
2042 is used. Update the commentary.
2043
2044 * eval.c (verror): Simplify calculation of size_t.
2045
2046 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2047 messages.
2048
f61f41d7
PE
20492011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2050
2051 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2052 change.
2053
96fb4434
PE
20542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2055
2056 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2057 This makes this file independent of the recent pseudovector change.
2058
671875da 20592011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2060
69e9b5a3
PE
2061 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2062
b5f869a7 2063 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2064 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2065 Remove unused local.
c8926152 2066 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2067
841a1577 2068 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2069 GCC 4.6.0 optimizes based on type-based alias analysis.
2070 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2071 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2072 != &v->size, and therefore "v->size = 1; b->size = 2; return
2073 v->size;" must therefore return 1. This assumption is incorrect
2074 for Emacs, since it type-puns struct Lisp_Vector * with many other
2075 types. To fix this problem, this patch adds a new type struct
f904488f 2076 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2077 and pseudovectors, and helps optimizing compilers not get fooled
2078 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2079 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2080 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2081 the size member.
eab3844f
PE
2082 (XSETPVECTYPE): Rewrite in terms of new macro.
2083 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2084 This is a bit clearer, and further avoids the possibility of
2085 undesirable aliasing.
2086 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2087 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2088 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2089 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2090 (ASIZE): Now uses header.size rather than size.
2091 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2092 to avoid the hassle of writing XVECTOR (foo)->header.size.
2093 (struct vectorlike_header): New type.
eab3844f
PE
2094 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2095 object, to help avoid aliasing.
2096 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2097 (SUBRP): Likewise, since Lisp_Subr is a special case.
2098 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2099 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2100 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2101 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2102 changed to be "header.size" and "header.next".
2103 * buffer.h (struct buffer): Likewise.
2104 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2105 * frame.h (struct frame): Likewise.
2106 * process.h (struct Lisp_Process): Likewise.
2107 * termhooks.h (struct terminal): Likewise.
2108 * window.c (struct save_window_data, struct saved_window): Likewise.
2109 * window.h (struct window): Likewise.
2110 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2111 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2112 * buffer.c (init_buffer_once): Likewise.
2113 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2114 special case.
2115 * process.c (Fformat_network_address): Use local var for size,
2116 for brevity.
2117
0df1eac5
PE
2118 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2119
847ab9d1 2120 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2121 * data.c (atof): Remove decl; no longer used or needed.
2122 (digit_to_number): Move to lread.c.
2123 (Fstring_to_number): Use new string_to_number function, to be
2124 consistent with how the Lisp reader treats infinities and NaNs.
2125 Do not assume that floating-point numbers represent EMACS_INT
2126 without losing information; this is not true on most 64-bit hosts.
2127 Avoid double-rounding errors, by insisting on integers when
2128 parsing non-base-10 numbers, as the documentation specifies.
2129 * lisp.h (string_to_number): New decl, replacing ...
2130 (isfloat_string): Remove.
bc0a5c13 2131 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2132 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2133 appears to have been a coding error. Similarly, do not accept
2134 strings like +-1e0 as floating point numbers. Do not report
2135 overflow for integer overflows unless the base is not 10 which
2136 means we have no simple and reliable way to continue.
2137 Break out the floating-point parsing into a new
2138 function string_to_number, so that Fstring_to_number parses
2139 floating point numbers consistently with the Lisp reader.
04f2d78b 2140 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2141 (E_CHAR, EXP_INT): Remove, replacing with ...
2142 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2143 (string_to_number): New function, replacing isfloat_string.
2144 This function checks for valid syntax and produces the resulting
2145 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2146 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2147 so that overflow for non-base-10 numbers is reported only when
2148 there's no portable and simple way to convert to floating point.
452f4150 2149
67769ffc
PE
2150 * textprop.c (set_text_properties_1): Rewrite for clarity,
2151 and to avoid GCC warning about integer overflow.
2152
c20db43f
PE
2153 * intervals.h (struct interval): Use EMACS_INT for members
2154 where EMACS_UINT might cause problems. See
2155 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2156 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2157 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2158 All uses changed.
37aa2f85
PE
2159 (offset_intervals): Tell GCC not to worry about length overflow
2160 when negating a negative length.
c20db43f 2161
2538aa2f
PE
2162 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2163 (overrun_check_free): Likewise.
2164
f2d3008d
PE
2165 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2166 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2167 word size.
2168
ec8df744
PE
2169 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2170 (gnutls_make_error): Rename local to avoid shadowing.
2171 (gnutls_emacs_global_deinit): ifdef out; not used.
2172 (Fgnutls_boot): Use const for pointer to readonly storage.
2173 Comment out unused local. Fix pointer signedness problems.
2174
640ee02d
PE
2175 * lread.c (openp): Don't stuff size_t into an 'int'.
2176 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2177 about possible signed overflow.
2178
6048fb2a
PE
2179 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2180 (GDK_KEY_g): Don't define if already defined.
2181 (xg_prepare_tooltip): Avoid pointer signedness problem.
2182 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2183
fa3c87e1
PE
2184 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2185 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2186
2172544b
PE
2187 * xfns.c (Fx_window_property): Simplify a bit,
2188 to make a bit faster and to avoid GCC 4.6.0 warning.
2189 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2190
9b821a21
PE
2191 * fns.c (internal_equal): Don't assume size_t fits in int.
2192
3c616cfa
PE
2193 * alloc.c (compact_small_strings): Tighten assertion a little.
2194
c2982e87
PE
2195 Replace pEd with more-general pI, and fix some printf arg casts.
2196 * lisp.h (pI): New macro, generalizing old pEd macro to other
2197 conversion specifiers. For example, use "...%"pI"d..." rather
2198 than "...%"pEd"...".
2199 (pEd): Remove. All uses replaced with similar uses of pI.
2200 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2201 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2202 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2203 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2204 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2205 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2206 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2207 64-bit hosts.
2208 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2209 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2210 * print.c (safe_debug_print, print_object): Likewise.
2211 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2212 to int.
6f04d126
PE
2213 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2214 avoiding the 0 flag, which is not portable.
c2982e87
PE
2215 * process.c (Fmake_network_process): Use pI to avoid cast.
2216 * region-cache.c (pp_cache): Likewise.
2217 * xdisp.c (decode_mode_spec): Likewise.
2218 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2219 behavior on 64-bit hosts with printf arg.
6f04d126 2220 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2221 (x_stop_queuing_selection_requests): Likewise.
2222 (x_get_window_property): Don't truncate byte count to an 'int'
2223 when tracing.
0b432f21 2224
5e073ec7
PE
2225 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2226 here, since it parses constructs like leading '-' and spaces,
2227 which are not wanted; and it overflows with large numbers.
2228 Instead, simply match F[0-9]+, which is what is wanted anyway.
2229
36372bf9
PE
2230 * alloc.c: Remove unportable assumptions about struct layout.
2231 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2232 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2233 (allocate_vectorlike, make_pure_vector): Use the new macros,
2234 plus offsetof, to remove unportable assumptions about struct layout.
2235 These assumptions hold on all porting targets that I know of, but
2236 they are not guaranteed, they're easy to remove, and removing them
2237 makes further changes easier.
2238
0b432f21
PE
2239 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2240 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2241 (string_overrun_cookie): Now const. Use initializers that
2242 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2243 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2244 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2245 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2246 multiple of sizeof (EMACS_INT); it need not be, if
2247 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2248 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2249
895009e1
JB
22502011-04-26 Juanma Barranquero <lekktu@gmail.com>
2251
2252 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2253
6a7a1b0b
TZ
22542011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2255
2256 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2257 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2258 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2259
841a1577 22602011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2261
2262 * lisp.h (Qdebug): List symbol.
895009e1 2263 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2264 * keyboard.c (debug-on-event): New variable.
2265 (handle_user_signal): Break into debugger when debug-on-event
2266 matches the current signal symbol.
2267
f2d3ba6f
DN
22682011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2269
2270 * alloc.c (check_sblock, check_string_bytes)
2271 (check_string_free_list): Convert to standard C.
2272
42ce4c63
TZ
22732011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2274
2275 * w32.c (emacs_gnutls_push): Fix typo.
2276
825cd63c
EZ
22772011-04-25 Eli Zaretskii <eliz@gnu.org>
2278
fb11d64d
EZ
2279 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2280 "cast to pointer from integer of different size".
2281
825cd63c
EZ
2282 Improve doprnt and its use in verror. (Bug#8545)
2283 * doprnt.c (doprnt): Document the set of format control sequences
2284 supported by the function. Use SAFE_ALLOCA instead of always
2285 using `alloca'.
2286
2287 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2288 is one byte too soon. Don't use xrealloc; instead xfree and
2289 xmalloc anew.
2290
e061a11b
TZ
22912011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2292
2293 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2294 callbacks stage.
2295
2296 * gnutls.c: Renamed global_initialized to
2297 gnutls_global_initialized. Added internals for the
2298 :verify-hostname-error, :verify-error, and :verify-flags
2299 parameters of `gnutls-boot' and documented those parameters in the
2300 docstring. Start callback support.
2301 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2302 unless a fatal error occured. Call gnutls_alert_send_appropriate
2303 on error. Return error code.
2304 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2305 (emacs_gnutls_read): Likewise.
2306 (Fgnutls_boot): Return handshake error code.
2307 (emacs_gnutls_handle_error): New function.
2308 (wsaerror_to_errno): Likewise.
2309
2310 * w32.h (emacs_gnutls_pull): Add prototype.
2311 (emacs_gnutls_push): Likewise.
2312
2313 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2314 (emacs_gnutls_push): Likewise.
2315
23162011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2317
2318 * process.c (wait_reading_process_output): Check if GnuTLS
2319 buffered some data internally if no FDs are set for TLS
2320 connections.
2321
2322 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2323 (LIBS): Link to USER_LIBS.
2324 ($(BLD)/gnutls.$(0)): New target.
2325
fa6996bc
EZ
23262011-04-24 Eli Zaretskii <eliz@gnu.org>
2327
eb35682e
EZ
2328 * xdisp.c (handle_single_display_spec): Rename the
2329 display_replaced_before_p argument into display_replaced_p, to
2330 make it consistent with the commentary. Fix typos in the
2331 commentary.
2332
e2ad650c
EZ
2333 * textprop.c (syms_of_textprop): Remove dead code.
2334 (copy_text_properties): Delete obsolete commentary about an
2335 interface that was deleted long ago. Fix typos in the description
2336 of arguments.
2337
1b2de274
EZ
2338 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2339 to changes in oldXMenu/XMenu.h from 2011-04-16.
2340 <menu_help_message, prev_menu_help_message>: Constify.
2341 (IT_menu_make_room): menu->help_text is now `const char **';
2342 adjust.
2343
2344 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2345 to changes in oldXMenu/XMenu.h from 2011-04-16.
2346 (struct XMenu): Declare `help_text' `const char **'.
2347
2348 * xfaces.c <Qunspecified>: Make extern again.
2349
2350 * syntax.c: Include sys/types.h before including regex.h, as
2351 required by Posix.
2352
762b15be
EZ
2353 * doc.c (get_doc_string): Improve the format passed to `error'.
2354
2355 * doprnt.c (doprnt): Improve commentary.
2356
2357 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2358
2359 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2360 them with etags.
2361
f1052e5d
EZ
2362 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2363 changes in globals.h immediately force recompilation.
762b15be
EZ
2364 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2365 $(CURDIR)/s/ms-w32.h.
2366 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2367
fa6996bc
EZ
2368 * character.c (Fchar_direction): Function deleted.
2369 (syms_of_character): Don't defsubr it.
2370 <char-direction-table>: Deleted.
2371
e6c3da20
EZ
23722011-04-23 Eli Zaretskii <eliz@gnu.org>
2373
2374 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2375 * doprnt.c: Include limits.h.
2376 (SIZE_MAX): New macro.
04f2d78b
CB
2377 (doprnt): Return a size_t value. 2nd arg is now size_t.
2378 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2379 Improve overflow protection. Support `l' modifier for integer
2380 conversions. Support %l conversion. Don't assume an EMACS_INT
2381 argument for integer conversions and for %c.
2382
2383 * lisp.h (doprnt): Restore prototype.
2384
2385 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2386 $(SRC)/character.h.
2387
2388 * Makefile.in (base_obj): Add back doprnt.o.
2389
2390 * deps.mk (doprnt.o): Add back prerequisites.
2391 (callint.o): Depend on character.h.
2392
2393 * eval.c (internal_lisp_condition_case): Include the handler
2394 representation in the error message.
2395 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2396 when breaking from the loop.
2397
2398 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2399
2400 * callint.c (Fcall_interactively): When displaying error message
2401 about invalid control letter, pass the character's codepoint, not
2402 a pointer to its multibyte form. Improve display of the character
2403 in octal and display also its hex code.
2404
2405 * character.c (char_string): Use %x to display the (unsigned)
2406 codepoint of an invalid character, to avoid displaying a bogus
2407 negative value.
2408
2409 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2410 `error', not SYMBOL_NAME itself.
2411
2412 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2413 character arguments to `error'.
2414
2415 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2416 to `error' in error message about FINAL_CHAR argument. Make sure
2417 FINAL_CHAR is a character, and use %c when it is passed as
2418 argument to `error'.
2419
4ffd0d6b 24202011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2421
2422 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2423
2424 * w32.c: Include <time.h>.
2425 (sys_localtime): New function.
2426
4ffd0d6b 24272011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2428
2429 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2430
4ffd0d6b 2431 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2432
4ffd0d6b 24332011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2434
4ffd0d6b
GM
2435 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2436 zombies (Bug#8467).
aac0c6e3 2437
04c56954
EZ
24382011-04-19 Eli Zaretskii <eliz@gnu.org>
2439
2440 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2441 gl_state.e_property when gl_state.object is Qt.
2442
2443 * insdel.c (make_gap_larger): Remove limitation of buffer size
2444 to <= INT_MAX.
2445
16a43933
CY
24462011-04-18 Chong Yidong <cyd@stupidchicken.com>
2447
2448 * xdisp.c (lookup_glyphless_char_display)
2449 (produce_glyphless_glyph): Handle cons cell entry in
2450 glyphless-char-display.
2451 (Vglyphless_char_display): Document it.
2452
2453 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2454 glyphless-char-display.
2455
4581706e
CY
24562011-04-17 Chong Yidong <cyd@stupidchicken.com>
2457
2458 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2459
2460 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2461
2462 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2463 definition for no-X builds.
2464
4887c6e2 24652011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2466
fd35b6f9
PE
2467 Static checks with GCC 4.6.0 and non-default toolkits.
2468
5c1ccb01
PE
2469 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2470
006c5daa
PE
2471 * process.c (keyboard_bit_set): Define only if SIGIO.
2472 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2473 (send_process): Repair possible setjmp clobbering.
2474
efc736d3
PE
2475 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2476
4e2fe2e6
PE
2477 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2478
f97334a2
PE
2479 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2480
4e75f29d
PE
2481 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2482 Define only if needed.
2483
90efadd1
PE
2484 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2485 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2486 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2487
3c647824
PE
2488 * dispextern.h (struct redisplay_interface): Rename param
2489 to avoid shadowing.
e264f262 2490 * termhooks.h (struct terminal): Likewise.
761383f4 2491 * xterm.c (xembed_send_message): Likewise.
3c647824 2492
b58c5c4a
PE
2493 * insdel.c (make_gap_smaller): Define only if
2494 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2495
cad59032
PE
2496 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2497 it.
2498
c339dc2e
PE
2499 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2500 so that we aren't warned about unused symbols.
2501
91a3e27b
PE
2502 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2503
399c71d3 2504 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2505
8ffc96f5
PE
2506 * xfns.c (x_real_positions): Mark locals as initialized.
2507
eef9bc79
PE
2508 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2509
098db9dd
PE
2510 * xterm.c: Fix problems found by static analysis with other toolkits.
2511 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2512 (x_dispatch_event): Declare static if USE_GTK, and
2513 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2514 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2515 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2516 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2517 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2518
eb18f6cc
PE
2519 * xmenu.c (menu_help_callback): Pointer type fixes.
2520 Use const pointers when pointing at readonly data. Avoid pointer
2521 signedness clashes.
2522 (FALSE): Remove unused macro.
2523 (update_frame_menubar): Remove unused decl.
2524
1fe72bf8
PE
2525 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2526
60d9e1db
PE
2527 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2528 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2529 (single_menu_item): Rename local to avoid shadowing.
2530
39261c26
PE
2531 * keyboard.c (make_lispy_event): Remove unused local var.
2532
018c5e19
PE
2533 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2534 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2535
63d2b86e
PE
2536 * bitmaps: Change bitmaps from unsigned char back to the X11
2537 compatible char. Avoid the old compiler warnings about
2538 out-of-range initializers by using, for example, '\xab' rather
2539 than 0xab.
2540
aefd87e1
PE
2541 * xgselect.c (xgselect_initialize): Check vs interface
2542 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2543
bf501fb9
PE
2544 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2545
e9829fdf
PE
2546 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2547 to read-only memory.
2548
1086c095
PE
2549 * fns.c (vector): Remove; this old hack is no longer needed.
2550
2baccd04 2551 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2552 Remove unused var.
dde42981 2553 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2554
72391843 2555 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2556
436c16df 2557 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2558 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2559 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2560
92bb796d 2561 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2562 (x_term_init): Remove local to avoid shadowing.
92bb796d 2563
764430a3 2564 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2565
2566 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2567 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2568
d1dfb56c
EZ
25692011-04-16 Eli Zaretskii <eliz@gnu.org>
2570
c4354cb4
EZ
2571 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2572
d1dfb56c
EZ
2573 Fix regex.c, syntax.c and friends for buffers > 2GB.
2574 * syntax.h (struct gl_state_s): Declare character position members
2575 EMACS_INT.
2576
2577 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2578
04f2d78b
CB
2579 * textprop.c (verify_interval_modification, interval_of):
2580 Declare arguments EMACS_INT.
d1dfb56c
EZ
2581
2582 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2583 EMACS_INT.
2584
2585 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2586
2587 * indent.c (Fvertical_motion): Local variable it_start is now
2588 EMACS_INT.
2589
2590 * regex.c (re_match, re_match_2, re_match_2_internal)
2591 (bcmp_translate, regcomp, regexec, print_double_string)
2592 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2593 (re_compile_pattern, re_exec): Declare arguments and local
2594 variables `size_t' and `ssize_t' and return values `regoff_t', as
2595 appropriate.
2596 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2597 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2598 <compile_stack_type>: `size' and `avail' are now `size_t'.
2599
2600 * regex.h <regoff_t>: Use ssize_t, not int.
2601 (re_search, re_search_2, re_match, re_match_2): Arguments that
2602 specify buffer/string position and length are now ssize_t and
2603 size_t. Return type is regoff_t.
2604
613052cd
BK
26052011-04-16 Ben Key <bkey76@gmail.com>
2606
2607 * nsfont.m: Fixed bugs in ns_get_family and
2608 ns_descriptor_to_entity that were caused by using free to
2609 deallocate memory blocks that were allocated by xmalloc (via
2610 xstrdup). This caused Emacs to crash when compiled with
2611 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2612 --enable-checking=xmallocoverrun). xfree is now used to
2613 deallocate these memory blocks.
2614
4170f62f 26152011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2616
71b41406
PE
2617 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2618
9587a89d
PE
2619 emacs_write: Accept and return EMACS_INT for sizes.
2620 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2621 et seq.
2622 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2623 Accept and return EMACS_INT.
2624 (emacs_gnutls_write): Return the number of bytes written on
2625 partial writes.
2626 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2627 (emacs_read, emacs_write): Remove check for negative size, as the
2628 Emacs source code has been audited now.
9587a89d
PE
2629 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2630 (emacs_read, emacs_write): Use it.
273a5f82
PE
2631 * process.c (send_process): Adjust to the new signatures of
2632 emacs_write and emacs_gnutls_write. Do not attempt to store
2633 a byte offset into an 'int'; it might overflow.
9587a89d 2634 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2635
3e047f51
PE
2636 * sound.c: Don't assume sizes fit in 'int'.
2637 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2638 Return EMACS_INT, not int.
3e047f51 2639 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2640 Accept EMACS_INT, not int.
2641 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2642 record read return values.
2643
cc39a9db
BK
26442011-04-15 Ben Key <bkey76@gmail.com>
2645
c9d0ec6d
JB
2646 * keyboard.c (Qundefined): Don't declare static since it is used
2647 in nsfns.m.
2648 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2649 static since they are used in nsfont.m.
cc39a9db 2650
6c60eb9f
SM
26512011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2652
2653 * process.c (Qprocessp): Don't declare static.
2654 * lisp.h (Qprocessp): Declare again.
2655
7990b61a
JB
26562011-04-15 Juanma Barranquero <lekktu@gmail.com>
2657
2658 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2659
5d4cb038
PE
26602011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2661
8bd7b830 2662 Improve C-level modularity by making more things 'static'.
cd64ea1d 2663
e3b27b31
PE
2664 Don't publish debugger-only interfaces to other modules.
2665 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2666 (verify_bytepos, count_markers): Move decls to the only modules
2667 that need them.
2668 * region-cache.h (pp_cache): Likewise.
2669 * window.h (check_all_windows): Likewise.
2670 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2671
5d4cb038
PE
2672 * sysdep.c (croak): Now static, if
2673 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2674 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2675
2676 * alloc.c (refill_memory_reserve): Now static if
2677 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2678 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2679
e87b6180
PE
2680 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2681 Define only if USE_LUCID.
2682
ac64929e
PE
2683 * xrdb.c (x_customization_string, x_rm_string): Now static.
2684
6f37259d
PE
2685 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2686 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2687
1683e3ab
PE
2688 * xdisp.c (draw_row_with_mouse_face): Now static.
2689 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2690
de9c2632
PE
2691 * window.h (check_all_windows): Mark externally visible.
2692
2b96acb7
PE
2693 * window.c (window_deletion_count): Now static.
2694
2695 * undo.c: Make symbols static if they're not exported.
2696 (last_undo_buffer, last_boundary_position, pending_boundary):
2697 Now static.
2698
50436f33
PE
2699 * textprop.c (interval_insert_behind_hooks): Now static.
2700 (interval_insert_in_front_hooks): Likewise.
2701
64520e5c
PE
2702 * term.c: Make symbols static if they're not exported.
2703 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2704 (max_frame_lines, tty_set_terminal_modes):
2705 (tty_reset_terminal_modes, tty_turn_off_highlight):
2706 (get_tty_terminal): Now static.
2707 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2708 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2709 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2710 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2711 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2712
1fa53021
PE
2713 * sysdep.c: Make symbols static if they're not exported.
2714 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2715 Now static.
2716 (sigprocmask_set, full_mask): Remove; unused.
2717 (wait_debugging): Mark as visible.
2718 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2719 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2720
d4b43b22
PE
2721 * syntax.c (syntax_temp): Define only if !__GNUC__.
2722
b7c513d0
PE
2723 * sound.c (current_sound_device, current_sound): Now static.
2724
989b29ad
PE
2725 * search.c (searchbufs, searchbuf_head): Now static.
2726
13a55a78
PE
2727 * scroll.c (scroll_cost): Remove; unused.
2728 * dispextern.h (scroll_cost): Remove decl.
2729
de68a1fc
PE
2730 * region-cache.h (pp_cache): Mark as externally visible.
2731
40ccffa6
PE
2732 * process.c: Make symbols static if they're not exported.
2733 (process_tick, update_tick, create_process, chan_process):
2734 (Vprocess_alist, proc_buffered_char, datagram_access):
2735 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2736 (deactivate_process): Mark defn as static, as well as decl.
2737 * lisp.h (create_process): Remove decl.
2738 * process.h (chan_process, Vprocess_alist): Remove decls.
2739
ad64fc97
PE
2740 * print.c: Make symbols static if they're not exported.
2741 (print_depth, new_backquote_output, being_printed, print_buffer):
2742 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2743 (print_interval, print_number_index, initial_stderr_stream):
2744 Now static.
2745 * lisp.h (Fprinc): Remove decl.
2746 (debug_output_compilation_hack): Mark as externally visible.
2747
adddb265
PE
2748 * sysdep.c (croak): Move decl from here to syssignal.h.
2749 * syssignal.h (croak): Put it here, so the API can be checked when
2750 'croak' is called from dissociate_if_controlling_tty.
2751
1717ede2
PE
2752 * minibuf.c: Make symbols static if they're not exported.
2753 (minibuf_save_list, choose_minibuf_frame): Now static.
2754 * lisp.h (choose_minibuf_frame): Remove decl.
2755
fa5fb2bc
PE
2756 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2757
1e3890d1
PE
2758 * lread.c: Make symbols static if they're not exported.
2759 (read_objects, initial_obarray, oblookup_last_bucket_number):
2760 Now static.
2761 (make_symbol): Remove; unused.
2762 * lisp.h (initial_obarray, make_symbol): Remove decls.
2763
8a1414fa
PE
2764 * keyboard.c: Make symbols static if they're not exported.
2765 (single_kboard, recent_keys_index, total_keys, recent_keys):
2766 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2767 (this_single_command_key_start, echoing, last_auto_save):
2768 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2769 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2770 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2771 (Vlispy_mouse_stem, double_click_count):
2772 Now static.
2773 (force_auto_save_soon): Define only if SIGDANGER.
2774 (ignore_mouse_drag_p): Now static if
2775 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2776 (print_help): Remove; unused.
2777 (stop_character, last_timer_event): Mark as externally visible.
2778 * keyboard.h (ignore_mouse_drag_p): Declare only if
2779 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2780 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2781 * lisp.h (echoing): Remove decl.
2782 (force_auto_save_soon): Declare only if SIGDANGER.
2783 * xdisp.c (redisplay_window): Simplify code, to make it more
2784 obvious that ignore_mouse_drag_p is not accessed if !defined
2785 USE_GTK && !defined HAVE_NS.
2786
93ea6e8f
PE
2787 * intervals.c: Make symbols static if they're not exported.
2788 (merge_properties_sticky, merge_interval_right, delete_interval):
2789 Now static.
2790 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2791
77382fcc
PE
2792 * insdel.c: Make symbols static if they're not exported.
2793 However, leave prepare_to_modify_buffer alone. It's never
2794 called from outside this function, but that appears to be a bug.
2795 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2796 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2797 (adjust_after_replace_noundo): Remove; unused.
2798 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2799 (signal_before_change): Remove decls.
77382fcc 2800
9306c32e
PE
2801 * indent.c (val_compute_motion, val_vmotion): Now static.
2802
cd44d2eb
PE
2803 * image.c: Make symbols static if they're not exported.
2804 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2805 if USE_GTK.
2806 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2807 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2808
ad9a7a06
PE
2809 * fringe.c (standard_bitmaps): Now static.
2810 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2811
81626931
PE
2812 * frame.c: Make symbols static if they're not exported.
2813 (x_report_frame_params, make_terminal_frame): Now static.
2814 (get_frame_param): Now static, unless HAVE_NS.
2815 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2816 (x_get_resource_string): Remove; not used.
2817 * frame.h (make_terminal_frame, x_report_frame_params):
2818 (x_get_resource_string); Remove decls.
2819 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2820 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2821
239f9db9
PE
2822 * font.c, fontset.c: Make symbols static if they're not exported.
2823 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2824 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2825 * font.c (font_close_object): Now static.
2826 * font.h (font_close_object): Remove.
2827 * fontset.c (FONTSET_OBJLIST): Remove.
2828 (free_realized_fontset) #if-0 the body, which does nothing.
2829 (face_suitable_for_char_p): #if-0, as it's never called.
2830 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2831 * xfaces.c (face_at_string_position):
2832 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2833 since 0 is always ASCII.
2834
dfcf3579
PE
2835 * fns.c (weak_hash_tables): Now static.
2836
5045092b
PE
2837 * fileio.c: Make symbols static if they're not exported.
2838 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2839 (Vwrite_region_annotation_buffers): Now static.
2840
57a96f5c
PE
2841 * eval.c: Make symbols static if they're not exported.
2842 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2843 * lisp.h (backtrace_list): Remove decl.
2844
35f08c38
PE
2845 * emacs.c: Make symbols static if they're not exported.
2846 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2847 (fatal_error_code, fatal_error_signal_hook, standard_args):
2848 Now static.
2849 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2850 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2851 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2852 * lisp.h (fatal_error_signal_hook): Remove decl.
2853 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2854
f44bd759
PE
2855 * editfns.c: Move a (normally-unused) function to its only use.
2856 * editfns.c, lisp.h (get_operating_system_release): Remove.
2857 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2858 worth the hassle of breaking this out.
2859
b532497d
PE
2860 * xterm.c: Make symbols static if they're not exported.
2861 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2862 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2863 (x_destroy_window, x_delete_display):
2864 Now static.
2865 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2866 (x_mouse_leave): Remove; unused.
2867 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2868 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2869 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2870 Remove decls.
2871 (x_mouse_leave): Declare only if WINDOWSNT.
2872 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2873 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2874 USE_X_TOOLKIT.
2875
1675728f
PE
2876 * ftxfont.c: Make symbols static if they're not exported.
2877 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2878 HAVE_FREETYPE.
2879 * font.h (ftxfont_driver): Likewise.
2880
e4cebfca
PE
2881 * xfns.c: Make symbols static if they're not exported.
2882 (x_last_font_name, x_display_info_for_name):
2883 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2884 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2885 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2886 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2887 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2888 (last_show_tip_args): Now static.
2889 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2890 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2891 (x_screen_planes): Remove; unused.
2892 * dispextern.h (x_screen_planes): Remove decl.
2893
5bf46f05
PE
2894 * dispnew.c: Make symbols static if they're not exported.
2895 * dispextern.h (redraw_garbaged_frames, scrolling):
2896 (increment_row_positions): Remove.
2897 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2898 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2899 Now static.
2900 (redraw_garbaged_frames): Remove; unused.
2901
435f4c28
PE
2902 * xfaces.c: Make symbols static if they're not exported.
2903 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2904 Remove decls.
2905 * xterm.h (defined_color): Remove decls.
2906 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2907 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2908 (menu_face_changed_default, defined_color, free_realized_face):
2909 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2910 (ascii_face_of_lisp_face): Remove; unused.
2911
8524aef3
PE
2912 * xdisp.c: Make symbols static if they're not exported.
2913 * dispextern.h (scratch_glyph_row, window_box_edges):
2914 (glyph_to_pixel_coords, set_cursor_from_row):
2915 (get_next_display_element, set_iterator_to_next):
2916 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2917 (show_mouse_face): Remove decls
2918 * frame.h (message_buf_print): Likewise.
2919 * lisp.h (pop_message, set_message, check_point_in_composition):
2920 Likewise.
2921 * xterm.h (set_vertical_scroll_bar): Likewise.
2922 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2923 (message_buf_print, scratch_glyph_row, displayed_buffer):
2924 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2925 (get_next_display_element, show_mouse_face, window_box_edges):
2926 (frame_to_window_pixel_xy, check_point_in_composition):
2927 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2928 (glyph_to_pixel_coords): Remove; unused.
2929
16390cd2
PE
2930 * dired.c (file_name_completion): Now static.
2931
2932 * dbusbind.c (xd_in_read_queued_messages): Now static.
2933
a25f4dfa
PE
2934 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2935 * data.c (circular_list_error): Remove.
2936
14a9c8df
PE
2937 * commands.h (last_point_position, last_point_position_buffer):
2938 (last_point_position_window): Remove decls.
2939 * keyboard.c: Make these variables static.
2940
04f2d78b
CB
2941 * coding.h (coding, code_convert_region, encode_coding_gap):
2942 Remove decls.
74ab6df5
PE
2943 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2944 (iso_code_class, detect_coding, code_convert_region): Now static.
2945 (encode_coding_gap): Remove; unused.
2946
38dfbee1
PE
2947 * chartab.c (chartab_chars, chartab_bits): Now static.
2948
a2cb4e63
PE
2949 * charset.h (charset_iso_8859_1): Remove decl.
2950 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2951 Now static.
2952
127198fd
PE
2953 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2954 * ccl.c (Vccl_program_table): Now static.
2955 (check_ccl_update): Remove; unused.
2956
d85b608f
PE
2957 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2958 * category.h: ... from here.
2959 * category.c (check_category_table, set_category_set): Now static.
2960
31cd66f3
PE
2961 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2962 * lisp.h: Remove these decls.
2963
c358e587
PE
2964 * buffer.c (buffer_count): Remove unused var.
2965
e78aecca
PE
2966 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2967 so that it's not optimized away.
2968 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2969 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2970 exported only to the debugger.
2971
e192d7d3 2972 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2973 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2974
92470028
PE
2975 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2976 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2977 was inaccessible from Lisp.
2978 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2979 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2980
244ed907
PE
2981 alloc.c: Import and export fewer symbols, and remove unused items.
2982 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2983 is defined.
2984 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2985 it's not optimized away by whole-program optimization.
2986 (message_enable_multibyte, free_misc): Remove.
2987 (catchlist, handlerlist, mark_backtrace):
2988 Declare only if BYTE_MARK_STACK.
2989 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2990 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2991 (message_enable_multibyte): Remove decl.
2992 (free_misc, interval_free_list, float_block, float_block_index):
2993 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2994 (cons_free_list, last_marked_index):
2995 Now static.
2996 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2997 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2998 (mark_backtrace): Define only if BYTE_MARK_STACK.
2999 * xdisp.c (message_enable_multibyte): Now static.
3000
61c2b50e 3001 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3002 This makes it easier for human readers (and static analyzers)
3003 to see whether these variables are used from other modules.
3004 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3005 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3006 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3007 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3008 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3009 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3010 * xmenu.c, xselect.c:
3011 Declare Q* vars static if they are not used in other modules.
3012 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3013 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3014 Remove decls of unexported vars.
3015 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3016
95c82688
PE
3017 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3018
16a97296
PE
3019 Make Emacs functions such as Fatom 'static' by default.
3020 This makes it easier for human readers (and static analyzers)
3021 to see whether these functions can be called from other modules.
3022 DEFUN now defines a static function. To make the function external
3023 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3024 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3025 (Finit_image_library):
16a97296
PE
3026 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3027 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3028 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3029 Remove decls, since these functions are now static.
3030 (Funintern, Fget_internal_run_time): New decls, since these functions
3031 were already external.
95c82688 3032
16a97296
PE
3033 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3034 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3035 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3036 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3037 * keyboard.c, keymap.c, lread.c:
3038 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3039 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3040 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3041 Mark functions with DEFUE instead of DEFUN,
3042 if they are used in other modules.
3043 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3044 decls for now-static functions.
3045 * buffer.h (Fdelete_overlay): Remove decl.
3046 * callproc.c (Fgetenv_internal): Mark as internal.
3047 * composite.c (Fremove_list_of_text_properties): Remove decl.
3048 (Fcomposition_get_gstring): New forward static decl.
3049 * composite.h (Fcomposite_get_gstring): Remove decl.
3050 * dired.c (Ffile_attributes): New forward static decl.
3051 * doc.c (Fdocumntation_property): New forward static decl.
3052 * eval.c (Ffetch_bytecode): New forward static decl.
3053 (Funintern): Remove extern decl; now in .h file where it belongs.
3054 * fileio.c (Fmake_symbolic_link): New forward static decl.
3055 * image.c (Finit_image_library): New forward static decl.
3056 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3057 * intervals.h (Fprevious_property_change):
3058 (Fremove_list_of_text_properties): Remove decls.
3059 * keyboard.c (Fthis_command_keys): Remove decl.
3060 (Fcommand_execute): New forward static decl.
3061 * keymap.c (Flookup_key): New forward static decl.
3062 (Fcopy_keymap): Now static.
3063 * keymap.h (Flookup_key): Remove decl.
3064 * process.c (Fget_process): New forward static decl.
3065 (Fprocess_datagram_address): Mark as internal.
3066 * syntax.c (Fsyntax_table_p): New forward static decl.
3067 (skip_chars): Remove duplicate decl.
3068 * textprop.c (Fprevious_property_change): New forward static decl.
3069 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3070 Now internal.
3071 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3072 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3073
785bbd42
PE
3074 * editfns.c (Fformat): Remove unreachable code.
3075
8b913b57
AS
30762011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3077
3078 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3079 change. (Bug#8496)
3080
a6744a35
EZ
30812011-04-13 Eli Zaretskii <eliz@gnu.org>
3082
3083 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3084 when at ZV. (Bug#8487)
3085
e7974947
AS
30862011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3087
baad03f0
AS
3088 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3089 (Bug#8437)
3090 * keyboard.c (parse_tool_bar_item): Likewise.
3091 * sound.c (sound_cleanup, alsa_close): Likewise.
3092 * termcap.c (tgetent): Likewise.
3093 * xfns.c (x_default_font_parameter): Likewise.
3094 * xsettings.c (read_and_apply_settings): Likewise.
3095
e7974947
AS
3096 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3097 (overrun_check_free): Protoize.
3098
28272684
PE
30992011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3100
3101 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3102 since callers should never pass a negative size.
3103 Change the signature to match that of plain 'read' and 'write'; see
3104 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3105 * lisp.h: Update prototypes of emacs_write and emacs_read.
3106
11997c76
EZ
31072011-04-11 Eli Zaretskii <eliz@gnu.org>
3108
3109 * xdisp.c (redisplay_window): Don't try to determine the character
3110 position of the scroll margin if the window start point w->startp
e896f03c 3111 is outside the buffer's accessible region. (Bug#8468)
11997c76 3112
8a2cbd72
EZ
31132011-04-10 Eli Zaretskii <eliz@gnu.org>
3114
3115 Fix write-region and its subroutines for buffers > 2GB.
3116 * fileio.c (a_write, e_write): Modify declaration of arguments and
3117 local variables to support buffers larger than 2GB.
3118 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3119
3120 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3121 argument, local variables, and return value.
3122
3123 * lisp.h: Update prototypes of emacs_write and emacs_read.
3124
3125 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3126
4073e537 31272011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3128
1ebfdcb6
PE
3129 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3130
b2ded58d
PE
3131 Fix more problems found by GCC 4.6.0's static checks.
3132
7d66342c
PE
3133 * xdisp.c (vmessage): Use a better test for character truncation.
3134
bbf47d44
PE
3135 * charset.c (load_charset_map): <, not <=, for optimization,
3136 and to avoid potential problems with integer overflow.
9248994d 3137 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3138 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3139 * editfns.c (Fformat): Likewise.
1e69125e 3140 * syntax.c (skip_chars): Likewise.
3befa583 3141
e3019616
PE
3142 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3143 This also lets GCC 4.6.0 generate slightly better loop code.
3144
becfa255
PE
3145 * callint.c (Fcall_interactively): <, not <=, for optimization.
3146 (Fcall_interactively): Count the number of arguments produced,
3147 not the number of arguments given. This is simpler and lets GCC
3148 4.6.0 generate slightly better code.
3149
dae0cd48
PE
3150 * ftfont.c: Distingish more carefully between FcChar8 and char.
3151 The previous code passed unsigned char * to a functions like
3152 strlen and xstrcasecmp that expect char *, which does not
3153 conform to the C standard.
3154 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3155 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3156 char * when the C standard requires it.
3157
76032d70
PE
3158 * keyboard.c (read_char): Remove unused var.
3159
eb3f1cc8
PE
3160 * eval.c: Port to Windows vsnprintf (Bug#8435).
3161 Include <limits.h>.
3162 (SIZE_MAX): Define if the headers do not.
3163 (verror): Do not give up if vsnprintf returns a negative count.
3164 Instead, grow the buffer. This ports to Windows vsnprintf, which
3165 does not conform to C99. Problem reported by Eli Zaretskii.
3166 Also, simplify the allocation scheme, by avoiding the need for
3167 calling realloc, and removing the ALLOCATED variable.
3168
70476b54
PE
3169 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3170
12020a9e
PE
3171 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3172 But keep the doprint source code for now, as we might revamp it
3173 and use it again (Bug#8435).
ea6c7ae6
PE
3174 * lisp.h (doprnt): Remove.
3175 * Makefile.in (base_obj): Remove doprnt.o.
3176 * deps.mk (doprnt.o): Remove.
3177
5fdb398c
PE
3178 error: Print 32- and 64-bit integers portably (Bug#8435).
3179 Without this change, on typical 64-bit hosts error ("...%d...", N)
3180 was used to print both 32- and 64-bit integers N, which relied on
3181 undefined behavior.
3182 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3183 New macro.
3184 * lisp.h (error, verror): Mark as printf-like functions.
3185 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3186 Report overflow in size calculations when allocating printf buffer.
3187 Do not truncate output string at its first null byte.
3188 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3189 Truncate the output at a character boundary, since vsnprintf does not
3190 do that.
3191 * charset.c (check_iso_charset_parameter): Convert internal
3192 character to string before calling 'error', since %c now has the
3193 printf meaning.
3194 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3195 overflow when computing char to be passed to 'error'. Do not
3196 pass Lisp_Object to 'error'; pass the integer instead.
3197 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3198 formatted with plain %d.
3199
b189fa66
PE
3200 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3201
bff87ef0
PE
3202 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3203
7e2cac20
PE
3204 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3205
ce4d90b5
PE
3206 * xterm.c (x_catch_errors): Remove duplicate declaration.
3207
266c9547
PE
3208 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3209
79c49ad2
PE
3210 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3211
368f4090
JM
32122011-04-10 Jim Meyering <meyering@redhat.com>
3213
3214 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3215 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3216 return ssize_t not "int", and use size_t as the buffer length.
3217 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3218 * gnutls.h: Update declarations.
3219 * process.c (read_process_output): Use ssize_t, to match.
3220 (send_process): Likewise.
3221
a32d4040
CY
32222011-04-09 Chong Yidong <cyd@stupidchicken.com>
3223
3224 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3225
8546720e 32262011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3227
04f2d78b
CB
3228 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3229 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3230
8546720e
GM
3231 * xterm.c (handle_one_xevent):
3232 * xmenu.c (create_and_show_popup_menu):
3233 * xselect.c (x_decline_selection_request)
3234 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3235
0a2f5c1a 32362011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3237
3238 Fix some uses of `int' instead of EMACS_INT.
3239 * search.c (string_match_1, fast_string_match)
3240 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3241 (scan_buffer, find_next_newline_no_quit)
3242 (find_before_next_newline, search_command, Freplace_match)
3243 (Fmatch_data): Make some `int' variables be EMACS_INT.
3244
3245 * xdisp.c (display_count_lines): 3rd argument and return value now
3246 EMACS_INT. All callers changed.
3247 (pint2hrstr): Last argument is now EMACS_INT.
3248
3249 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3250 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3251 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3252 (decode_coding_utf_16, decode_coding_emacs_mule)
3253 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3254 (decode_coding_ccl, decode_coding_charset)
3255 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3256 (decode_coding_iso_2022, decode_coding_emacs_mule)
3257 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3258 <char_offset, last_offset>: Declare EMACS_INT.
3259 (encode_coding_utf_8, encode_coding_utf_16)
3260 (encode_coding_emacs_mule, encode_invocation_designation)
3261 (encode_designation_at_bol, encode_coding_iso_2022)
3262 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3263 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3264 Declare EMACS_INT.
3265 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3266 (encode_invocation_designation): Last argument P_NCHARS is now
3267 EMACS_INT.
3268 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3269 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3270
3271 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3272 All users changed.
3273
3274 * ccl.c (Fccl_execute_on_string): Declare some variables
3275 EMACS_INT.
3276
8546720e 32772011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3278
3279 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3280
4e19a977
CS
32812011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3282
3283 * process.c (Fformat_network_address): Doc fix.
3284
87302331
R
32852011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3286
3287 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3288
cbb59342
CY
32892011-04-08 Chong Yidong <cyd@stupidchicken.com>
3290
3291 * keyboard.c (read_char): Call Lisp function help-form-show,
3292 instead of using internal_with_output_to_temp_buffer.
3293 (Qhelp_form_show): New var.
e0d38eeb 3294 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3295
3296 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3297
3298 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3299
e67a13ab
CY
33002011-04-06 Chong Yidong <cyd@stupidchicken.com>
3301
04f2d78b
CB
3302 * process.c (Flist_processes): Remove to Lisp.
3303 (list_processes_1): Delete.
e67a13ab 3304
973f782d
EZ
33052011-04-06 Eli Zaretskii <eliz@gnu.org>
3306
7c106b1e
EZ
3307 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3308
973f782d
EZ
3309 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3310
41cf7d1a 33112011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3312
ca23cc88
PE
3313 Fix more problems found by GCC 4.6.0's static checks.
3314
f390e2d5
PE
3315 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3316
42eea0d0
PE
3317 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3318
b69769da 3319 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3320
f9541e84
PE
3321 * xdisp.c (vmessage): Mark as a printf-like function.
3322
13841b55
PE
3323 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3324
c136c10f
PE
3325 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3326
5e2d4a30
PE
3327 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3328 printf-like functions.
3329 (tiff_load): Add casts to remove these marks before passing them
3330 to system-supplied API.
3331
583f48b9
PE
3332 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3333
b25d760e
PE
3334 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3335 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3336 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3337 directly, rather than having caller test rule sign. This avoids
3338 some unnecessary tests.
3339 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3340 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3341 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3342
bc7b6697 3343 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3344 (xfont_open): Avoid unnecessary tests.
bc7b6697 3345
27ccc379
PE
3346 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3347
dcd5c89a
PE
3348 * composite.h, composite.c (composition_gstring_put_cache):
3349 Use EMACS_INT, not int, for length.
3350
b13a45c6
PE
3351 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3352 breaking out part of COMPOSITION_DECODE_RULE.
3353 (COMPOSITION_DECODE_RULE): Use it.
3354 * composite.c (get_composition_id): Remove unused local vars,
3355 by using the new macro.
3356
1e792e4d
PE
3357 * textprop.c (set_text_properties_1): Change while to do-while,
3358 since the condition is always true at first.
3359
dc6c6455 3360 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3361 (interval_deletion_adjustment): Return unsigned value.
3362 All uses changed.
dc6c6455 3363
aba7731a
PE
3364 * process.c (list_processes_1, create_pty, read_process_output):
3365 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3366 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3367 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3368 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3369 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3370
fdfc4bf3
PE
3371 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3372
fca8fe46 3373 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3374 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3375
06a0259a 3376 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3377 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3378 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3379
e7b9e80f
PE
3380 * print.c (print_error_message): Avoid int overflow.
3381
56201685
PE
3382 * font.c (font_list_entities): Redo for clarity,
3383 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3384
78834453 3385 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3386 (font_score): Avoid potential overflow in diff calculation.
78834453 3387
0bc0b309 3388 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3389 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3390
e610eaca
PE
3391 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3392
b895abce
PE
3393 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3394 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3395 can always succeed if overflow has undefined behavior.
3396
1f1d9321 3397 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3398 (wordify): Omit three unnecessary tests.
1f1d9321 3399
c59478bc
PE
3400 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3401 All callers changed. This avoids the need for an unused var.
3402
79b73827
PE
3403 * casefiddle.c (casify_region): Remove var that is set but not used.
3404
a4db5dfe
PE
3405 * dired.c (file_name_completion): Remove var that is set but not used.
3406
43aae36e
PE
3407 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3408
2a47c44d 3409 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3410 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3411
a37c69bf
PE
3412 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3413 Check for integer overflow on size calculations.
3414
328ab8e7
PE
3415 * buffer.c (Fprevious_overlay_change): Remove var that is set
3416 but not used.
3417
e5a2a5cb
PE
3418 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3419 Remove vars that are set but not used.
8d84a6eb 3420 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3421 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3422
a60e5f68
PE
3423 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3424
f661cb61 3425 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3426 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3427
f0397f5a
PE
3428 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3429 that are set but not used.
3430
8664db06 3431 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3432 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3433
6abdaa4a
PE
3434 * xselect.c (x_get_local_selection, x_handle_property_notify):
3435 Remove vars that are set but not used.
3436
0ce7538d 3437 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3438 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3439
9ae848fc
PE
3440 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3441 Remove var that is set but not used.
0b918413
PE
3442 (scroll_bar_windows_size): Now size_t, not int.
3443 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3444 Check for overflow.
9ae848fc 3445
a5a62657
PE
3446 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3447 (map_tty_color) [!defined MSDOS]: Likewise.
3448
5c5cdd39
PE
3449 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3450
66ebf983
PE
3451 * coding.c: Remove vars that are set but not used.
3452 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3453 All callers changed.
3454 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3455 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3456 (decode_coding_charset): Remove vars that are set but not used.
3457
1be4d761
PE
3458 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3459 that is set but not used.
3460
47553fa8
PE
3461 * print.c (print_object): Remove var that is set but not used.
3462
1f7196bf 3463 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3464 The gnulib version avoids calling malloc in the usual case,
3465 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3466 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3467 * filelock.c (current_lock_owner): Likewise.
3468 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3469 * sysdep.c: Include allocator.h, careadlinkat.h.
3470 (emacs_no_realloc_allocator): New static constant.
3471 (emacs_readlink): New function.
fdb61804
PE
3472 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3473 ../lib/careadlinkat.h.
d1fdcab7 3474
f84c17c7
SM
34752011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3476
3477 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3478 first non-nil return value).
3479
ef3862ad
JD
34802011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3481
3482 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3483 if not defined (Bug#8403).
3484
376a7006
JB
34852011-04-02 Juanma Barranquero <lekktu@gmail.com>
3486
3487 * xdisp.c (display_count_lines): Remove parameter `start',
3488 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3489 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3490 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3491 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3492 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3493 and thereabouts. All callers changed.
3494 (get_per_char_metric): Remove parameter `f', unused since
3495 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3496
6ca3801d
JM
34972011-04-02 Jim Meyering <meyering@redhat.com>
3498
3499 do not dereference NULL upon failed strdup
3500 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3501 (ns_get_family): Likewise.
3502
d8e2b5ba
JB
35032011-04-02 Juanma Barranquero <lekktu@gmail.com>
3504
3505 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3506
8c74fcbd
JD
35072011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3508
3509 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3510 later (Bug#8403).
3511
7200d79c
SM
35122011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3513
03408648 3514 Add lexical binding.
7200d79c 3515
03408648
SM
3516 * window.c (Ftemp_output_buffer_show): New fun.
3517 (Fsave_window_excursion):
3518 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3519
3520 * lread.c (lisp_file_lexically_bound_p): New function.
3521 (Fload): Bind Qlexical_binding.
3522 (readevalloop): Remove `evalfun' arg.
3523 Bind Qinternal_interpreter_environment.
3524 (Feval_buffer): Bind Qlexical_binding.
3525 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3526 Mark as dynamic.
3527 (syms_of_lread): Declare `lexical-binding'.
3528
3529 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3530
3531 * keyboard.c (eval_dyn): New fun.
3532 (menu_item_eval_property): Use it.
ca105506
SM
3533
3534 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3535
03408648
SM
3536 * fns.c (concat, mapcar1): Accept byte-code-functions.
3537
3538 * eval.c (Fsetq): Handle lexical vars.
3539 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3540 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3541 (FletX, Flet): Obey lexical binding.
3542 (Fcommandp): Handle closures.
3543 (Feval): New `lexical' arg.
3544 (eval_sub): New function extracted from Feval. Use it almost
3545 everywhere where Feval was used. Look up vars in lexical env.
3546 Handle closures.
3547 (Ffunctionp): Move from subr.el.
3548 (Ffuncall): Handle closures.
3549 (apply_lambda): Remove `eval_flags'.
3550 (funcall_lambda): Handle closures and new byte-code-functions.
3551 (Fspecial_variable_p): New function.
3552 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3553 but without exporting it to Lisp.
23aba0ea 3554
23aba0ea 3555 * doc.c (Fdocumentation, store_function_docstring):
03408648 3556 * data.c (Finteractive_form): Handle closures.
23aba0ea 3557
03408648
SM
3558 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3559 interactive spec.
ba83908c 3560
04f2d78b
CB
3561 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3562 New byte-codes.
03408648
SM
3563 (exec_byte_code): New function extracted from Fbyte_code to handle new
3564 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3565
03408648 3566 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3567
03408648 3568 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3569
e2abce01
JB
35702011-03-31 Juanma Barranquero <lekktu@gmail.com>
3571
3572 * xdisp.c (redisplay_internal): Fix prototype.
3573
63696a73 35742011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3575
63696a73 3576 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3577 (try_scrolling): Use it when setting scroll_limit.
3578 Limit scrolling to 100 screen lines.
63696a73
EZ
3579 (redisplay_window): Even when falling back on "recentering",
3580 position point in the window according to scroll-conservatively,
3581 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3582
3583 (try_scrolling): When point is above the window, allow searching
3584 as far as scroll_max, or one screenful, to compute vertical
3585 distance from PT to the scroll margin position. This prevents
3586 try_scrolling from unnecessarily failing when
3587 scroll-conservatively is set to a value slightly larger than the
3588 window height. Clean up the case of PT below the margin at bottom
3589 of window: scroll_max can no longer be INT_MAX. When aggressive
3590 scrolling is in use, don't let point enter the opposite scroll
3591 margin as result of the scroll.
3592 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3593 threshold of 100 lines for never-recentering scrolling.
3594
e4cc2dfc
JB
35952011-03-31 Juanma Barranquero <lekktu@gmail.com>
3596
3597 * dispextern.h (move_it_by_lines):
3598 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3599 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3600 (message_log_check_duplicate): Remove parameters `prev_bol' and
3601 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3602 (redisplay_internal): Remove parameter `preserve_echo_area',
3603 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3604
3605 * indent.c (Fvertical_motion):
3606 * window.c (window_scroll_pixel_based, Frecenter):
3607 Don't pass `need_y_p' to `move_it_by_lines'.
3608
1c470562
SM
36092011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3610
44f230aa
SM
3611 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3612 steal a few bits to be more compact.
3613 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3614 Remove unneeded casts.
3615
1c470562
SM
3616 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3617
888adce9
ZK
36182011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3619
3620 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3621 binding" message (bug#7967).
3622
f838ed7b
PE
36232011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3624
77861b95
PE
3625 Fix more problems found by GCC 4.6.0's static checks.
3626
de6dbc14
PE
3627 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3628 Remove unused local var.
3629
f838ed7b
PE
3630 * editfns.c (Fmessage_box): Remove unused local var.
3631
792c7b2b
PE
3632 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3633 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3634 Omit unused local vars.
c499e557 3635 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3636 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3637 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3638 Omit unused local var.
3639
ba0165e1
PE
3640 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3641 Don't assume string length fits in int.
32ad8845 3642 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3643 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3644
3c59b4c9
PE
3645 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3646 instead of alloca (Bug#8344).
3647
a3eed478 3648 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3649 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3650
eb4d412d
PE
3651 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3652
1658b401
PE
3653 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3654 concerns.
3655
3656 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3657
3658 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3659
9a2c6e05
PE
3660 * keyboard.c (syms_of_keyboard): Use the same style as later
3661 in this function when indexing through an array. This also
3662 works around GCC bug 48267.
3663
03d0a109
PE
3664 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3665
44f730c8
PE
3666 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3667
fe75f926
PE
3668 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3669 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3670
ffa8c828
PE
3671 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3672 This avoids undefined behavior on integer overflow, and is a bit
3673 more convenient anyway since it is compared to a size_t variable.
3674
c5101a77
PE
3675 Variadic C functions now count arguments with size_t, not int.
3676 This avoids an unnecessary limitation on 64-bit machines, which
3677 caused (substring ...) to crash on large vectors (Bug#8344).
3678 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3679 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3680 All variadic functions and their callers changed accordingly.
c5101a77
PE
3681 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3682 * data.c (arith_driver, float_arith_driver): Likewise.
3683 * editfns.c (general_insert_function): Likewise.
3684 * eval.c (struct backtrace.nargs, interactive_p)
3685 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3686 (funcall_lambda, mark_backtrace): Likewise.
3687 * fns.c (concat): Likewise.
3688 * frame.c (x_set_frame_parameters): Likewise.
3689 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3690 0 if not found, not -1. All callers changed.
3691
dd3f25f7
PE
3692 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3693 (stack_copy_size): Now size_t, not int.
3694 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3695
461c2ab9
JB
36962011-03-28 Juanma Barranquero <lekktu@gmail.com>
3697
3698 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3699 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3700 All callers changed.
3701
3702 * lisp.h (multibyte_char_to_unibyte):
3703 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3704 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3705 * character.h (CHAR_TO_BYTE8):
3706 * cmds.c (internal_self_insert):
3707 * editfns.c (general_insert_function):
3708 * keymap.c (push_key_description):
3709 * search.c (Freplace_match):
3710 * xdisp.c (message_dolog, set_message_1): All callers changed.
3711
f6d62986
SM
37122011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3713
3714 * keyboard.c (safe_run_hook_funcall): New function.
3715 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3716 don't set the hook to nil, but remove the offending function instead.
3717 (Qcommand_hook_internal): Remove, unused.
3718 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3719 Vcommand_hook_internal.
3720
3721 * eval.c (enum run_hooks_condition): Remove.
3722 (funcall_nil, funcall_not): New functions.
3723 (run_hook_with_args): Call each function through a `funcall' argument.
3724 Remove `cond' argument, now redundant.
3725 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3726 (Frun_hook_with_args_until_failure): Adjust accordingly.
3727 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3728
1db5b1ad
JB
37292011-03-28 Juanma Barranquero <lekktu@gmail.com>
3730
3731 * dispextern.h (string_buffer_position): Remove declaration.
3732
3733 * print.c (strout): Remove parameter `multibyte', unused since
3734 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3735
3736 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3737 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3738 All callers changed.
3739
3740 * w32.c (_wsa_errlist): Use braces for struct initializers.
3741
3742 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3743 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3744 All callers changed.
3745 (string_buffer_position): Likewise. Also, make static (it's never
3746 used outside xdisp.c).
3747 (cursor_row_p): Remove parameter `w', unused since
3748 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3749 (decode_mode_spec): Remove parameter `precision', introduced during
3750 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3751 All callers changed.
3752
5ffb62aa
JD
37532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3754
3755 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3756
461c2ab9 37572011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3758
3759 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3760 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3761 (ns_update_auto_hide_menu_bar): New functions.
3762 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3763 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3764 ns_constrain_all_frames.
3765 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3766 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3767
5c380ffb
JD
37682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3769
3770 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3771
9af30bdf
GM
37722011-03-27 Glenn Morris <rgm@gnu.org>
3773
3774 * syssignal.h: Replace RETSIGTYPE with void.
3775 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3776 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3777 Replace SIGTYPE with void everywhere.
3778 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3779 * s/template.h (SIGTYPE): Remove commented out definition.
3780
e2abce01
JB
37812011-03-26 Eli Zaretskii <eliz@gnu.org>
3782
3783 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3784 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3785
f868cd8a
JB
37862011-03-26 Juanma Barranquero <lekktu@gmail.com>
3787
59eb0929
JB
3788 * w32.c (read_unc_volume): Use parameter `henum', instead of
3789 global variable `wget_enum_handle'.
3790
3791 * keymap.c (describe_vector): Remove parameters `indices' and
3792 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3793 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3794
f868cd8a
JB
3795 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3796
3797 * keyboard.c (timer_check): Remove parameter `do_it_now',
3798 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3799 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3800 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3801
3802 * keyboard.c (read_char):
3803 * w32menu.c (w32_menu_display_help):
3804 * xmenu.c (show_help_event, menu_help_callback):
3805 Adjust calls to `show_help_echo'.
3806
3807 * gtkutil.c (xg_maybe_add_timer):
3808 * keyboard.c (readable_events):
3809 * process.c (wait_reading_process_output):
3810 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3811
3812 * insdel.c (adjust_markers_gap_motion):
3813 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3814 (gap_left, gap_right): Don't call it.
3815
2ecf6fdb
CY
38162011-03-25 Chong Yidong <cyd@stupidchicken.com>
3817
3818 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3819 incurred during fontification.
3820
6b1f9ba4
JB
38212011-03-25 Juanma Barranquero <lekktu@gmail.com>
3822
3823 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3824 (DEFVAR_PER_BUFFER): Don't pass it.
3825
3826 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3827 (scrolling_window): Don't pass it.
3828
0f4a96b5
JB
38292011-03-25 Juanma Barranquero <lekktu@gmail.com>
3830
3831 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3832
3833 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3834 and `suffix'.
3835 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3836 of variables specific to SELinux and computation of `encoded_absname'.
3837
3838 * image.c (XPutPixel): Remove unused variable `height'.
3839
3840 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3841
3842 * unexw32.c (get_section_info): Remove unused variable `section'.
3843
3844 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3845 (system_process_attributes): Remove unused variable `sess'.
3846 (sys_read): Remove unused variable `err'.
3847
3848 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3849 (w32_wnd_proc): Remove unused variable `isdead'.
3850 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3851 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3852 (x_create_tip_frame): Remove unused variable `tem'.
3853
3854 * w32inevt.c (w32_console_read_socket):
3855 Remove unused variable `no_events'.
3856
3857 * w32term.c (x_draw_composite_glyph_string_foreground):
3858 Remove unused variable `width'.
3859
1149507c
JB
38602011-03-24 Juanma Barranquero <lekktu@gmail.com>
3861
3862 * w32term.c (x_set_glyph_string_clipping):
3863 Don't pass uninitialized region to CombineRgn.
3864
9c88f339
JB
38652011-03-23 Juanma Barranquero <lekktu@gmail.com>
3866
3867 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3868 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3869 (Fx_close_connection): Remove unused variable `i'.
3870
3871 * w32font.c (w32font_draw): Return number of glyphs.
3872 (w32font_open_internal): Remove unused variable `i'.
3873 (w32font_driver): Add missing initializer.
3874
3875 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3876 (fill_in_menu): Remove unused variable `items_added'.
3877
3878 * w32term.c (last_mouse_press_frame): Remove static global variable.
3879 (w32_clip_to_row): Remove unused variable `f'.
3880 (x_delete_terminal): Remove unused variable `i'.
3881
3882 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3883 (NOTHING): Remove unused static global variable.
3884 (uniscribe_check_otf): Remove unused variable `table'.
3885 (uniscribe_font_driver): Add missing initializers.
3886
dee091a3
JD
38872011-03-23 Julien Danjou <julien@danjou.info>
3888
3889 * term.c (Fsuspend_tty, Fresume_tty):
3890 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3891 * window.c (temp_output_buffer_show):
3892 * insdel.c (signal_before_change):
3893 * frame.c (Fhandle_switch_frame):
3894 * fileio.c (Fdo_auto_save):
3895 * emacs.c (Fkill_emacs):
3896 * editfns.c (save_excursion_restore):
3897 * cmds.c (internal_self_insert):
3898 * callint.c (Fcall_interactively):
3899 * buffer.c (Fkill_all_local_variables):
3900 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3901 Use Frun_hooks.
0f4a96b5 3902 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3903 unconditionnaly since it does the check itself.
3904
2c520ab5 39052011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3906
c9c49752
PE
3907 Fix more problems found by GCC 4.5.2's static checks.
3908
8abc3f12
PE
3909 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3910 the first time through the loop, since we know p0 < p1 then.
3911 This also avoids a gcc -Wstrict-overflow warning.
3912
a2d26660
PE
3913 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3914 leading to a memory leak, possible in functions like
3915 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3916 of objects (Bug#8318).
a2d26660 3917
916c72e9
PE
3918 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3919 that could (at least in theory) be that large.
3920
19ab8a18
PE
3921 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3922 This is less likely to overflow, and avoids undefined behavior if
3923 overflow does occur. All callers changed. Use strtoul to scan
3924 for the unsigned long integer.
b7cbbd6f
PE
3925 (pint2hrstr): Simplify and tune code slightly.
3926 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3927
f0641eff
PE
3928 * scroll.c (do_scrolling): Work around GCC bug 48228.
3929 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3930
7f650bb9
PE
3931 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3932 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3933 (validate_x_resource_name): Simplify count usage.
3934 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3935
37dd57d1
PE
3936 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3937 fail (Bug#8306).
81e56e61 3938
699979fc 3939 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3940
401bf9b4
PE
3941 * process.c (Fmake_network_process): Use socklen_t, not int,
3942 where POSIX says socklen_t is required in portable programs.
3943 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3944 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3945 (Fmake_network_process, server_accept_connection):
3946 (wait_reading_process_output, read_process_output):
3947 Likewise.
3948
b93aacde
PE
3949 * process.c: Rename or move locals to avoid shadowing.
3950 (list_processes_1, Fmake_network_process):
3951 (read_process_output_error_handler, exec_sentinel_error_handler):
3952 Rename or move locals.
4dc343ee 3953 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3954 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3955 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3956 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3957 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3958
af8a867c 3959 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3960 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3961 Include tparam.h instead, since it declares them.
af8a867c
PE
3962 * cm.h (PC): Remove extern decl; tparam.h now does this.
3963 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3964 * terminfo.c: Include tparam.h, to check interfaces.
3965 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3966 (tparam): Adjust signature to match interface in tparam.h;
3967 this removes some undefined behavior. Check that outstring and len
3968 are zero, which they always are with Emacs.
3969 * tparam.h (PC, BC, UP): New extern decls.
3970
0248044d 3971 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3972 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3973
8ff096c1 3974 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3975 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3976 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3977 (ftfont_list): Remove unused local.
49eaafba
PE
3978 (get_adstyle_property, ftfont_pattern_entity):
3979 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3980 Rename locals to avoid shadowing.
8ff096c1 3981
e2be39f6
PE
3982 * xfont.c (xfont_list_family): Mark var as initialized.
3983
c9735e30
PE
3984 * xml.c (make_dom): Now static.
3985
8f5201ae
PE
3986 * composite.c (composition_compute_stop_pos): Rename local to
3987 avoid shadowing.
b246f932
PE
3988 (composition_reseat_it): Remove unused locals.
3989 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3990 (composition_update_it): Mark var as initialized.
11b61122
PE
3991 (find_automatic_composition): Mark vars as initialized,
3992 with a FIXME (Bug#8290).
8f5201ae 3993
760fbc2c
PE
3994 character.h: Rename locals to avoid shadowing.
3995 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3996 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3997 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3998 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3999 to avoid shadowing.
4000
ff08eb85
PE
4001 * textprop.c (property_change_between_p): Remove; unused.
4002
fc7bf025
PE
4003 * intervals.c (interval_start_pos): Now static.
4004
235d7abc
PE
4005 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4006
44f230aa
SM
4007 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4008 Rename locals to avoid shadowing.
3e7d6594 4009
50060332
PE
4010 * sound.c (wav_play, au_play, Fplay_sound_internal):
4011 Fix pointer signedness.
d01f234b 4012 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4013 (wav_play): Initialize a variable to 0, to prevent undefined
4014 behavior (Bug#8278).
50060332 4015
c4fc4e30
PE
4016 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4017
918436ed
PE
4018 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4019
c939f91b
PE
4020 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4021 clobbering (Bug#8298).
b9c7f648
PE
4022 * sysdep.c (sys_subshell): Likewise.
4023 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4024
6bd8c144
PE
4025 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4026 This should get cleaned up, so that child_setup has the
4027 same signature on all platforms.
4028
7710357c 4029 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4030 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4031
c59da222
CY
40322011-03-22 Chong Yidong <cyd@stupidchicken.com>
4033
4034 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4035 not to be necessary, and produces flickering.
4036
66b87493
GM
40372011-03-20 Glenn Morris <rgm@gnu.org>
4038
4039 * config.in: Remove file.
4040
45b6f6d5
JB
40412011-03-20 Juanma Barranquero <lekktu@gmail.com>
4042
4043 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4044 are now in src/globals.h.
4045 (syms_of_minibuf): Remove spurious & from previous change.
4046
3ec03f7e
LL
40472011-03-20 Leo <sdl.web@gmail.com>
4048
4049 * minibuf.c (completing-read-function): New variable.
4050 (completing-read-default): Rename from completing-read.
4051 (completing-read): Call completing-read-function.
4052
b14e3e21
CY
40532011-03-19 Juanma Barranquero <lekktu@gmail.com>
4054
4055 * xfaces.c (Fx_load_color_file):
4056 Read color file from absolute filename (bug#8250).
4057
f2b726e6
JB
40582011-03-19 Juanma Barranquero <lekktu@gmail.com>
4059
4060 * makefile.w32-in: Update dependencies.
4061
09f6ff02
EZ
40622011-03-17 Eli Zaretskii <eliz@gnu.org>
4063
4064 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4065
29a6015a
PE
40662011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4067
a3a6c54e
PE
4068 Fix more problems found by GCC 4.5.2's static checks.
4069
b766f867
PE
4070 * process.c (make_serial_process_unwind, send_process_trap):
4071 (sigchld_handler): Now static.
4072
be02381c
PE
4073 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4074 That way, the code declares only the vars that it needs.
4075 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4076 * s/cygwin.h (PTY_ITERATION): Likewise.
4077 * s/darwin.h (PTY_ITERATION): Likewise.
4078 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4079
57048744
PE
4080 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4081 * process.c (allocate_pty): Don't declare stb unless it's needed.
4082
7914961c 4083 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4084 (CONSTANTLIM): Remove; unused.
4085 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4086 Define only if needed.
7914961c 4087
b3967b18
PE
4088 * unexelf.c (unexec): Name an expression,
4089 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4090 Use a different way to cause a compilation error if anyone uses
4091 n rather than nn, a way that does not involve shadowing.
73366a00 4092 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4093
29a6015a
PE
4094 * deps.mk (unexalpha.o): Remove; unused.
4095
43cfc33e 4096 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4097 * unexec.h: New file.
ce701a33
PE
4098 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4099 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4100 Depend on unexec.h.
4101 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4102 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4103 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4104 Change as necessary to match prototype in unexec.h.
ce701a33 4105
01f44d5a
PE
4106 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4107 shadowing.
4f63c6bb 4108 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4109
a6670b0b
PE
4110 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4111 Rename locals to avoid shadowing.
4112
cef2010d 4113 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4114 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4115
d4d7173a
PE
4116 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4117
f08b802a
PE
4118 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4119 warning when compiling print.c.
4120
3ddb0639
PE
4121 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4122 instead of using an uninitialized var.
5ad03b97 4123 (font_sort_entities): Mark var as initialized.
3ddb0639 4124
170a2692
PE
4125 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4126
e663c700
PE
4127 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4128 pointers to constants.
89bc529a 4129 (font_parse_fcname): Remove unused vars.
7b81e2d0 4130 (font_delete_unmatched): Now static.
ea838e10 4131 (font_get_spec): Remove; unused.
13a547c6
PE
4132 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4133 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4134 Rename or move locals to avoid shadowing.
e663c700 4135
2a80c887 4136 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4137 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4138
1384fa33 4139 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4140 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4141
8b2c52e9
PE
4142 * alloc.c (mark_backtrace): Move decl from here ...
4143 * lisp.h: ... to here, so that it can be checked.
4144
475545b5 4145 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4146 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4147 (lisp_indirect_variable): Name an expression,
4148 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4149 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4150
b1349114 4151 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4152 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4153 Use const pointer when appropriate.
b1349114 4154
a2928364
PE
4155 * lisp.h (get_system_name, get_operating_system_release):
4156 Move decls here, to check interfaces.
4157 * process.c (get_operating_system_release): Move decl to lisp.h.
4158 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4159 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4160 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4161 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4162 (Fformat_time_string, Fencode_time, Finsert_char):
4163 (Ftranslate_region_internal, Fformat):
4164 Rename or remove local vars to avoid shadowing.
9710023e 4165 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4166
a415e694
PE
4167 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4168 avoid shadowing.
4169
8ef4622d
PE
4170 * lisp.h (eassert): Check that the argument compiles, even if
4171 ENABLE_CHECKING is not defined.
4172
946f9a5b
PE
4173 * data.c (Findirect_variable): Name an expression, to avoid
4174 gcc -Wbad-function-cast warning.
112396d6 4175 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4176 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4177 (Fmake_variable_buffer_local, Fmake_local_variable):
4178 Mark variables as initialized.
52746918 4179 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4180
e5aab7e7 4181 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4182 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4183 Rename locals to avoid shadowing.
dff45157
PE
4184 (mark_stack): Move local variables into the #ifdef region where
4185 they're used.
7bc26fdb
PE
4186 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4187 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4188 needed otherwise.
4189 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4190 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4191 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4192
e5aab7e7
PE
4193 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4194 avoids undefined behavior in theory.
4195
4da60324
PE
4196 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4197
88043301
PE
4198 Use functions, not macros, for up- and down-casing (Bug#8254).
4199 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4200 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4201 to use the following functions instead of these macros.
4202 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4203 EMACS_INT, since callers assume the returned value fits in int.
4204 (upcase1): Likewise, for UPCASE_TABLE.
4205 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4206 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4207 the race-condition problem in the old DOWNCASE.
88043301 4208
19ed5445
PE
4209 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4210 Rename locals to avoid shadowing.
4211 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4212 (regex_compile, re_search_2, re_match_2_internal):
4213 Remove unused local vars.
952db0d7
PE
4214 (FREE_VAR): Rewrite so as not to use empty "else",
4215 which gcc can warn about.
da053e48 4216 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4217 (RETALLOC_IF): Define only if needed.
4218 (WORDCHAR_P): Likewise. This one is never needed, but is used
4219 only in a comment talking about a compiler bug, so put inside
4220 the #if 0 of that comment.
4221 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4222 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4223 Remove; unused.
19ed5445 4224
1f3561e4 4225 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4226 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4227 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4228
ded6f8f7
PE
4229 * search.c (simple_search): Remove unused var.
4230
dbd37a95
PE
4231 * dired.c (compile_pattern): Move decl from here ...
4232 * lisp.h: ... to here, so that it can be checked.
4233 (struct re_registers): New forward decl.
4234
7e47afad
PE
4235 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4236
85f24f61
PE
4237 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4238 All uses changed.
4239 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4240 Rename locals to avoid shadowing.
5671df8f 4241 (Fvertical_motion): Mark locals as initialized.
85f24f61 4242
181aa2be 4243 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4244 (casify_region): Mark local as initialized.
181aa2be 4245
930d429c
PE
4246 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4247
7082eac6
PE
4248 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4249 New macros, so that the caller can use some names other than
4250 gcpro1, gcpro2, etc.
4251 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4252 of the new macros.
4253 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4254 argument, for consistency with GCPRO2_VAR, etc: it is now the
4255 prefix of the variable, not the variable itself. All uses
4256 changed.
38b2c076
PE
4257 * dired.c (directory_files_internal, file_name_completion):
4258 Rename locals to avoid shadowing.
4259
15206ed9
PE
4260 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4261 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4262 dired.c's scmp function, had undefined behavior.
4263 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4264 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4265 * buffer.h: ... to here, because these macros use current_buffer,
4266 and the new implementation with inline functions needs to have
4267 current_buffer in scope now, rather than later when the macros
4268 are used.
4269 (downcase, upcase1): New static inline functions.
4270 (DOWNCASE, UPCASE1): Reimplement using these functions.
4271 This avoids undefined behavior in expressions like
4272 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4273 from race conditions in accessing the global variables
4274 case_temp1 and case_temp2.
4275 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4276 * lisp.h (case_temp1, case_temp2): Remove their decls.
4277 * character.h (ASCII_CHAR_P): Move from here ...
4278 * lisp.h: ... to here, so that the inline functions mentioned
4279 above can use them.
4280
4a6bea26
PE
4281 * dired.c (directory_files_internal_unwind): Now static.
4282
f14b7e14
PE
4283 * fileio.c (file_name_as_directory, directory_file_name):
4284 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4285 Now static.
2893f146
PE
4286 (file_name_as_directory): Use const pointers when appropriate.
4287 (Fexpand_file_name): Likewise. In particular, newdir might
4288 point at constant storage, so make it a const pointer.
fd4ead52 4289 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4290 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4291 signedness issues.
f839df0c
PE
4292 (Fset_file_times, Finsert_file_contents, auto_save_error):
4293 Rename locals to avoid shadowing.
f14b7e14 4294
5716756e 4295 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4296 (Ftry_completion, Fall_completions): Rename or remove locals
4297 to avoid shadowing.
5716756e 4298
b4c3046a
PE
4299 * marker.c (bytepos_to_charpos): Remove; unused.
4300
b45db522
PE
4301 * lisp.h (verify_bytepos, count_markers): New decls,
4302 so that gcc does not warn that these functions aren't declared.
4303
85876d07
PE
4304 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4305 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4306 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4307 (copy_text): Remove unused local var.
85876d07 4308
03d78a21 4309 * filelock.c (within_one_second): Now static.
b3dd38ab 4310 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4311
5df8f01b
PE
4312 * buffer.c (fix_overlays_before): Mark locals as initialized.
4313 (fix_start_end_in_overlays): Likewise. This function should be
4314 simplified by using pointers-to-pointers, but that's a different
4315 matter.
b1d876f1 4316 (switch_to_buffer_1): Now static.
8f54f30a
PE
4317 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4318 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4319
a70072c9 4320 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4321 Fix pointer signedness issue.
edced198
PE
4322 (sys_subshell): Mark local as volatile if checking for lint,
4323 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4324 (MAXPATHLEN): Define only if needed.
a70072c9 4325
a0977c44
PE
4326 * process.c (serial_open, serial_configure): Move decls from here ...
4327 * systty.h: ... to here, so that they can be checked.
4328
a884fdcc
PE
4329 * fns.c (get_random, seed_random): Move extern decls from here ...
4330 * lisp.h: ... to here, so that they can be checked.
4331
604efe86 4332 * sysdep.c (reset_io): Now static.
b8950c94 4333 (wait_for_termination_signal): Remove; unused.
604efe86 4334
38fc62d9
PE
4335 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4336 (copy_keymap_item, append_key, push_text_char_description):
4337 Now static.
1004a21a 4338 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4339 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4340 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4341 (describe_map_tree):
4342 Rename locals to avoid shadowing.
38fc62d9 4343
2f2650da
PE
4344 * keyboard.c: Declare functions static if they are not used elsewhere.
4345 (echo_char, echo_dash, cmd_error, top_level_2):
4346 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4347 (read_char, kbd_buffer_get_event, make_lispy_position):
4348 (make_lispy_event, make_lispy_movement, apply_modifiers):
4349 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4350 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4351 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4352 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4353 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4354
a053e86c 4355 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4356 (mark_kboards): Move decl here ...
4357 * alloc.c (mark_kboards): ... from here.
a053e86c 4358
4752793e
PE
4359 * lisp.h (force_auto_save_soon): New decl.
4360
74f10ca7 4361 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4362 (DEFINE_DUMMY_FUNCTION): New macro.
4363 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4364 Use it.
c03cd23f
PE
4365 (main): Add casts to avoid warnings
4366 if GCC considers string literals to be constants.
74f10ca7 4367
022e70d4
PE
4368 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4369
59d6fe83
PE
4370 * dbusbind.c: Pointer signedness fixes.
4371 (xd_signature, xd_append_arg, xd_initialize):
4372 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4373 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4374 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4375 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4376
78320123
PE
4377 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4378 if GCC considers string literals to be constants.
49cebcca 4379 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4380
35ac2a97
SM
43812011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4382
fb103ca9
SM
4383 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4384 (print_preprocess, print_object): New macro to fix last change.
4385
35ac2a97
SM
4386 * print.c (print_preprocess): Don't forget font objects.
4387
62973b41
JB
43882011-03-16 Juanma Barranquero <lekktu@gmail.com>
4389
4390 * emacs.c (USAGE3): Doc fixes.
4391
0e48bb22
AS
43922011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4393
4394 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4395 structure.
4396
7684e57b
JB
43972011-03-14 Juanma Barranquero <lekktu@gmail.com>
4398
4399 * lisp.h (VWindow_system, Qfile_name_history):
4400 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4401 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4402 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4403
4404 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4405 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4406
4407 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4408 * w32console.c (detect_input_pending, read_input_pending)
4409 (encode_terminal_code):
4410 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4411 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4412 (w32_system_caret_y, Qfile_name_history):
4413 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4414 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4415 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4416 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4417 * w32proc.c (Qlocal, report_file_error):
4418 * w32term.c (Vwindow_system, updating_frame):
4419 * w32uniscribe.c (initialized, uniscribe_font_driver):
4420 Remove unneeded extern declarations.
4421
2aa46d6c
CY
44222011-03-14 Chong Yidong <cyd@stupidchicken.com>
4423
c96bbc66 4424 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4425
cffc6f3b
CY
44262011-03-13 Chong Yidong <cyd@stupidchicken.com>
4427
4428 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4429 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4430 These macros can no longer be used for assignment.
4431
44f230aa
SM
4432 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4433 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4434 (record_buffer_markers, fetch_buffer_markers): New functions for
4435 recording and fetching special buffer markers.
4436 (set_buffer_internal_1, set_buffer_temp): Use them.
4437
4438 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4439
4440 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4441
4442 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4443 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4444
4445 * xdisp.c (hscroll_window_tree):
4446 (reconsider_clip_changes): Use PT instead of BUF_PT.
4447
d251f04b
EZ
44482011-03-13 Eli Zaretskii <eliz@gnu.org>
4449
4450 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4451 $(EMACS_ROOT)/lib/intprops.h.
4452
f0c77cd1
PE
44532011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4454
3eca4629
PE
4455 Fix more problems found by GCC 4.5.2's static checks.
4456
7c86ee98
PE
4457 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4458 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4459 (xg_free_frame_widgets): Make it clear that a local variable is
4460 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4461 (gdk_window_get_screen): Make it clear that this macro is needed
4462 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4463 (int_gtk_range_get_value): New function, which avoids a diagnostic
4464 from gcc -Wbad-function-cast.
4465 (xg_set_toolkit_scroll_bar_thumb): Use it.
4466 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4467 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4468 (get_utf8_string, xg_get_file_with_chooser):
4469 Rename locals to avoid shadowing.
4470 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4471
41729b81
PE
4472 * xgselect.c (xg_select): Remove unused var.
4473
f0c77cd1
PE
4474 * image.c (four_corners_best): Mark locals as initialized.
4475 (gif_load): Initialize transparent_p to zero (Bug#8238).
4476 Mark another local as initialized.
ec6cf4c6 4477 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4478
ce0ad53d 4479 * image.c (clear_image_cache): Now static.
d5d5a617 4480 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4481 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4482 (x_edge_detection): Remove unnecessary cast that
4483 gcc -Wbad-function-cast diagnoses.
2037898d 4484 (gif_load): Fix pointer signedness.
6ae141d6
PE
4485 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4486 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4487
33383987 44882011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4489
d32df629
PE
4490 Improve quality of tests for time stamp overflow.
4491 For example, without this patch (encode-time 0 0 0 1 1
4492 1152921504606846976) returns the obviously-bogus value (-948597
4493 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4494 reports time overflow. See
4495 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4496 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4497 * editfns.c: Include limits.h and intprops.h.
4498 (TIME_T_MIN, TIME_T_MAX): New macros.
4499 (time_overflow): Move earlier, to before first use.
4500 (hi_time, lo_time): New functions, for an accurate test for
4501 out-of-range times.
4502 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4503 (Fget_internal_run_time): Don't assume time_t fits in int.
4504 (make_time): Use list2 instead of Fcons twice.
4505 (Fdecode_time): More accurate test for out-of-range times.
4506 (check_tm_member): New function.
4507 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4508 (lisp_time_argument): Don't rely on undefined left-shift and
4509 right-shift behavior when checking for time stamp overflow.
8be6f318 4510
fe31d94c
PE
4511 * editfns.c (time_overflow): New function, refactoring common code.
4512 (Fformat_time_string, Fdecode_time, Fencode_time):
4513 (Fcurrent_time_string): Use it.
4514
8be6f318
PE
4515 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4516 * dired.c (make_time): Move to ...
4517 * editfns.c (make_time): ... here.
4518 * systime.h: Note the move.
4519
09d9db2c 45202011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4521
126bc0dc
YM
4522 * fringe.c (update_window_fringes): Remove unused variables.
4523
c47cbdfd
YM
4524 * unexmacosx.c (copy_data_segment): Also copy __got section.
4525 (Bug#8223)
4526
7ac80be9
EZ
45272011-03-12 Eli Zaretskii <eliz@gnu.org>
4528
c96bbc66 4529 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4530 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4531 Constify `char *' arguments and their references according to
4532 prototypes in tparam.h.
4533
ecb0f94d 4534 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4535
7ac80be9
EZ
4536 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4537 Adapt all references accordingly.
4538
4539 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4540
ef1fd07e
TT
45412011-03-11 Tom Tromey <tromey@redhat.com>
4542
4543 * buffer.c (syms_of_buffer): Remove obsolete comment.
4544
7ef4b50c
EZ
45452011-03-11 Eli Zaretskii <eliz@gnu.org>
4546
4547 * termhooks.h (encode_terminal_code): Declare prototype.
4548
4549 * msdos.c (encode_terminal_code): Don't declare prototype.
4550
4551 * term.c (encode_terminal_code): Now external again, used by
4552 w32console.c and msdos.c.
4553
44f230aa
SM
4554 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4555 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4556
4b1ec863 45572011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4558
1714f52b 4559 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4560
4b1ec863
PE
4561 * fringe.c (update_window_fringes): Mark locals as initialized
4562 (Bug#8227).
4563 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4564
524c7aa6
PE
4565 * alloc.c (mark_fringe_data): Move decl from here ...
4566 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4567 to check its interface.
4568 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4569
a5c0af81 4570 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4571 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4572 (fontset_font): Mark local as initialized.
a9a06e0b 4573 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4574
b4716021
PE
4575 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4576
811e9bac 4577 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4578 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4579 (x_own_selection, Fx_disown_selection_internal): Rename locals
4580 to avoid shadowing.
4581 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4582
7e3ab302
PE
4583 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4584 so that the caller can use some name other than gcpro1.
4585 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4586 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4587 (Fx_backspace_delete_keys_p):
4588 Use them to avoid shadowing, and rename vars to avoid shadowing.
4589 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4590 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4591 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4592 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4593 Remove unused locals.
7e3ab302
PE
4594 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4595 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4596 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4597 macros.
f78faa98 4598
e2b13473
PE
4599 * xterm.h (x_mouse_leave): New decl.
4600
77f23912
PE
4601 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4602 Remove unused functions.
cdf4ba58
PE
4603 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4604 (x_calc_absolute_position): Now static.
7411c686 4605 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4606 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4607 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4608 unless they are used.
38d0b34a
PE
4609 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4610 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4611 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4612 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4613 (x_error_catcher, x_connection_closed, x_error_handler):
4614 (x_error_quitter, xembed_send_message, x_iconify_frame):
4615 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4616 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4617 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4618
44f230aa
SM
4619 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4620 Rename or move locals to avoid shadowing.
6b463e58 4621 (tty_defined_color, merge_face_heights): Now static.
5967d051 4622 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4623 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4624 does not deduce is never used uninitialized.
73719eba
PE
4625 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4626 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4627
426994c3 4628 * terminal.c (store_terminal_param): Now static.
5489860b 4629
032f1620 4630 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4631 (set_frame_menubar): Remove unused local.
d4323972 4632 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4633 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4634 since they might point to immutable storage.
281585b0
PE
4635 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4636 since it's unused otherwise.
032f1620 4637
367c19e5 4638 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4639 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4640 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4641 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4642 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4643 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4644 does not deduce are never used uninitialized.
70739cbe 4645
07b48fa9
PE
4646 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4647
8868a238 4648 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4649 * window.c (window_loop, size_window):
4650 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4651
7e5cf297 4652 * window.c (display_buffer): Now static.
d6550a9f
PE
4653 (size_window): Mark variables that gcc -Wuninitialized
4654 does not deduce are never used uninitialized.
a586633d
PE
4655 * window.h (check_all_windows): New decl, to forestall
4656 gcc -Wmissing-prototypes diagnostic.
5b555da1 4657 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4658
f6095868
PE
4659 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4660 shadowing.
4661 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4662 Include <limits.h>.
4663 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4664 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4665 (load_charset_map): Mark variables that gcc -Wuninitialized
4666 does not deduce are never used uninitialized.
53df7c11 4667 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4668
f38b440c
PE
4669 * coding.c (coding_set_source, coding_set_destination):
4670 Use "else { /* comment */ }" rather than "else /* comment */;"
4671 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4672 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4673 a block, when the outer 'i' will do.
4674 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4675 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4676 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4677 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4678 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4679 Rename locals to avoid shadowing.
4680 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4681 * coding.c (emacs_mule_char, encode_invocation_designation):
4682 Now static, since they're not used elsewhere.
413bb2db 4683 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4684 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4685 (decode_coding_emacs_mule): Mark variables that gcc
4686 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4687 (detect_coding_iso_2022): Initialize a local variable that might
4688 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4689 this initialization is needed. (Bug#8211)
5f58e762
PE
4690 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4691 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4692 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4693 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4694 Remove unused macros.
f38b440c 4695
232b38b9 4696 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4697 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4698 * character.c (string_count_byte8): Likewise.
232b38b9 4699
fb90da1b
PE
4700 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4701 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4702
fb93dbc2
PE
4703 * chartab.c (copy_sub_char_table): Now static, since it's not used
4704 elsewhere.
5c156ace
PE
4705 (sub_char_table_ref_and_range, char_table_ref_and_range):
4706 Rename locals to avoid shadowing.
bbcd0949 4707 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4708
7d3b3862 4709 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4710 (BIDI_BOB): Remove unused macro.
7d3b3862 4711
6be7d3da
PE
4712 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4713 deduce are never used uninitialized.
c2ed9c8b 4714 * term.c (encode_terminal_code): Likewise.
6be7d3da 4715
75f8807f 4716 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4717
50938595
PE
4718 * tparam.h: New file.
4719 * term.c, tparam.h: Include it.
4720 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4721 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4722 Move these decls to tparam.h, and make them agree with what
4723 is actually in tparam.c. The previous trick of using incompatible
4724 decls in different modules does not conform to the C standard.
4725 All callers of tparam changed to use tparam's actual API.
4726 * tparam.c (tparam1, tparam, tgoto):
4727 Use const pointers where appropriate.
4728
fbceeba2
PE
4729 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4730 * cm.h (struct cm): Likewise.
4731 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4732 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4733 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4734 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4735 (turn_on_face, init_tty): Likewise.
4736 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4737
7f3f1250
PE
4738 * term.c (term_mouse_position): Rename local to avoid shadowing.
4739
e6ca6543
PE
4740 * alloc.c (mark_ttys): Move decl from here ...
4741 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4742
c40f8d15
AS
47432011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4744
4745 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4746
cfe0661d
JB
47472011-03-09 Juanma Barranquero <lekktu@gmail.com>
4748
4749 * search.c (compile_pattern_1): Remove argument regp, unused since
4750 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4751 (compile_pattern): Don't pass it.
4752
0afb4571
J
47532011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4754
4755 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4756 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4757 for ! HAVE_GTK3.
4758 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4759
4760 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4761
4762 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4763 gdk_window_get_screen, gdk_window_get_geometry,
4764 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4765 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4766 (xg_get_pixbuf_from_pixmap): New function.
4767 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4768 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4769 Call xg_get_pixbuf_from_pixmap instead of
4770 gdk_pixbuf_get_from_drawable.
4771 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4772 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4773 (xg_check_special_colors): Use GtkStyleContext and its functions
4774 for HAVE_GTK3.
4775 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4776 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4777 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4778 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4779 Call gtk_widget_get_preferred_size.
0afb4571
J
4780 (xg_frame_resized): gdk_window_get_geometry only takes 5
4781 parameters.
44f230aa
SM
4782 (xg_win_to_widget, xg_event_is_for_menubar):
4783 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4784 (xg_set_widget_bg): New function.
4785 (delete_cb): New function.
895009e1 4786 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4787 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4788 (xg_set_background_color): Call xg_set_widget_bg.
4789 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4790 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4791 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4792 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4793 if ! HAVE_GTK3.
4794 (update_frame_tool_bar): Call gtk_widget_hide.
4795 (xg_initialize): Use GDK_KEY_g.
4796
4797 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4798 if ! HAVE_GTK3
4799 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4800
4801 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4802 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4803 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4804
1c2cc4ef
JB
48052011-03-08 Juanma Barranquero <lekktu@gmail.com>
4806
4807 * w32xfns.c (select_palette): Check success of RealizePalette against
4808 GDI_ERROR, not zero.
4809
33383987 4810See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4811
4812;; Local Variables:
4813;; coding: utf-8
aac0c6e3
MR
4814;; End:
4815
33383987 4816 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4817
4818 This file is part of GNU Emacs.
4819
4820 GNU Emacs is free software: you can redistribute it and/or modify
4821 it under the terms of the GNU General Public License as published by
4822 the Free Software Foundation, either version 3 of the License, or
4823 (at your option) any later version.
4824
4825 GNU Emacs is distributed in the hope that it will be useful,
4826 but WITHOUT ANY WARRANTY; without even the implied warranty of
4827 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4828 GNU General Public License for more details.
4829
4830 You should have received a copy of the GNU General Public License
4831 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.