* alloc.c, lisp.h (make_pure_vector): Now static.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
72cb32cf
PE
12012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2
3 * alloc.c, lisp.h (make_pure_vector): Now static.
4
61b108cc
SM
52012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
6
7 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
8 Move to byte-run.el.
9 (Fautoload): Do the hash-doc more carefully.
10 * data.c (Fdefalias): Purify definition, except for keymaps.
11 (Qdefun): Move from eval.c.
12 * lisp.h (Qdefun): Remove.
13 * lread.c (read1): Tiny simplification.
14
471fe23d
TN
152012-05-29 Troels Nielsen <bn.troels@gmail.com>
16
934f3f58 17 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
18 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
19 Bug#9642, but explicitly check that the buffer the overlay would
20 be moved to is live and rearrange lines to make sure that errors
21 will not put the overlay in an inconsistent state.
22 (Fdelete_overlay): Cosmetics.
23
85d0efd1
EZ
242012-05-28 Eli Zaretskii <eliz@gnu.org>
25
26 * w32term.c (my_bring_window_to_top): New function.
27 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
28 could be different from the original one.
29 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
30 (Bug#11513)
31
32 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
33 by calling BringWindowToTop.
34
35 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
36 (WM_EMACS_END): Increase by one.
37
da92a98c
PE
382012-05-28 Paul Eggert <eggert@cs.ucla.edu>
39
40 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
41 This avoids undefined behavior that might cause the eassert
42 to not catch an out-of-range value.
43
74d1f848
JB
442012-05-28 Juanma Barranquero <lekktu@gmail.com>
45
46 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
47 Update dependencies.
48
9e1a06fc
EZ
492012-05-27 Eli Zaretskii <eliz@gnu.org>
50
51 * bidi.c (bidi_mirror_char): Fix last change.
52
f3dd7312
AS
532012-05-27 Andreas Schwab <schwab@linux-m68k.org>
54
55 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
56 when referring to sectname field in printf format.
57
81899c91
PE
582012-05-27 Paul Eggert <eggert@cs.ucla.edu>
59
57b81a9f
PE
60 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
61 Only r_alloc_inhibit_buffer_relocation needed to be added;
62 the others were already declared.
63
81899c91
PE
64 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
65 before checking whether it's out of range. Put the check inside
66 eassert. See
67 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
68
33017faf 692012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
70
71 * callproc.c (Fcall_process): Restore a line that was accidentally
72 commented out in the 2011-02-13 change (bug#11547).
73
33017faf 742012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
75
76 * lisp.h [REL_ALLOC]: Add prototypes for external functions
77 defined on ralloc.c.
78
79 * buffer.c [REL_ALLOC]: Remove prototypes of
80 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
81 they are now on lisp.h.
82
83 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
84
85 * search.c (search_buffer): Use it to inhibit relocation of buffer
86 text while re_search_2 is doing its job, because re_search_2 is
87 passed C pointers to buffer text. (Bug#11519)
88
23415acf
EZ
89 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
90 Update value to 24.
91
44e27368
EZ
92 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
93 state after an additional call to move_it_in_display_line_to, keep
94 the values of it->max_ascent and it->max_descent found for the
95 entire line.
96 (pos_visible_p): Revert the comparison against bottom_y to what it
97 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
98 (Bug#11464)
99
c1892f11
PE
1002012-05-26 Paul Eggert <eggert@cs.ucla.edu>
101
102 Fix coding-related core dumps with gcc -ftrapv.
103 The code was computing A - B, where A and B are pointers, and B is
104 random garbage. This can lead to core dumps on platforms that
105 have special pointer registers, and it also leads to core dumps on
106 x86-64 when compiled with gcc -ftrapv. The fix is to compute
107 A - B only when B is initialized properly.
108 * coding.c (coding_set_source, coding_set_destination): Return void.
109 (coding_change_source, coding_change_destinations): New functions,
110 with the old behaviors of coding_set_source and coding_set_destination.
111 All callers that need an offset changed to use these new functions.
112
eb7afdad
GM
1132012-05-26 Glenn Morris <rgm@gnu.org>
114
115 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
116
f12fdf02
EZ
1172012-05-26 Eli Zaretskii <eliz@gnu.org>
118
53a63be6 119 Extend mouse support on W32 text-mode console.
61b108cc
SM
120 * xdisp.c (draw_row_with_mouse_face):
121 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 122
eb3f6f01 123 * w32console.c: Include window.h.
61b108cc
SM
124 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
125 New functions.
eb3f6f01
EZ
126 (initialize_w32_display): Initialize mouse-highlight data.
127
53a63be6
EZ
128 * w32inevt.c: Include termchar.h and window.h.
129 (do_mouse_event): Support mouse-autoselect-window. When the mouse
130 moves, call note_mouse_highlight. If help_echo changed, call
131 gen_help_event to produce help-echo message in the echo area.
132 Call clear_mouse_face if mouse_face_hidden is set in the mouse
133 highlight info.
134
4cfd81f6
PE
1352012-05-26 Paul Eggert <eggert@cs.ucla.edu>
136
137 * lread.c (read1): Simplify slightly to avoid an overflow warning
138 with GCC 4.7.0 on x86-64.
139
4446092a
EZ
1402012-05-26 Eli Zaretskii <eliz@gnu.org>
141
142 * bidi.c (bidi_mirror_char): Revert last change: an int is
143 definitely wide enough here.
144
42b2a986 1452012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 146
42b2a986 147 Fix integer width and related bugs (Bug#9874).
eb106a49 148 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
149 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
150 (string_bytes, check_sblock, allocate_string_data):
151 (compact_small_strings, Fmake_bool_vector, make_string)
152 (make_unibyte_string, make_multibyte_string)
153 (make_string_from_bytes, make_specified_string)
154 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
155 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
156 (mark_vectorlike):
157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
158 (allocate_pseudovector):
159 Use int, not EMACS_INT, where int is wide enough.
160 (inhibit_garbage_collection, Fgarbage_collect):
161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
162 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
163 int might not be wide enough.
164 (bidi_cache_search, bidi_cache_find, bidi_init_it)
165 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
166 (bidi_at_paragraph_end, bidi_find_paragraph_start)
167 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
168 (bidi_level_of_next_char, bidi_move_to_visually_next):
169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
170 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
171 (Fkill_buffer, Fset_buffer_major_mode)
172 (advance_to_char_boundary, Fbuffer_swap_text)
173 (Fset_buffer_multibyte, overlays_at, overlays_in)
174 (overlay_touches_p, struct sortvec, record_overlay_string)
175 (overlay_strings, recenter_overlay_lists)
176 (adjust_overlays_for_insert, adjust_overlays_for_delete)
177 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
178 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
179 (Foverlay_recenter, last_overlay_modification_hooks_used)
180 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
182 (validate_region): Omit unnecessary test for b <= e,
183 since that's guaranteed by the previous test.
d311d28c
PE
184 (adjust_overlays_for_delete): Avoid pos + length overflow.
185 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
186 (report_overlay_modification):
187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
188 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
189 Omit pointer cast, which isn't needed anyway, and doesn't work
190 after the EMACS_INT -> ptrdiff_t change.
02481186 191 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
192 * buffer.h: Adjust decls to match defn changes elsewhere.
193 (struct buffer_text, struct buffer):
194 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
195 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
196 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
197 not int, to avoid needless 32-bit limit on 64-bit hosts.
198 (exec_byte_code): Use tighter memory-full test, one that checks
199 for alloca overflow. Don't compute the address of the object just
200 before an array, as that's not portable. Use EMACS_INT, not
201 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
202 * callint.c (Fcall_interactively):
203 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
204 * callproc.c (call_process_kill, Fcall_process):
205 Don't assume pid_t fits into an Emacs fixnum.
206 (call_process_cleanup, Fcall_process, child_setup):
207 Don't assume pid_t fits into int.
208 (call_process_cleanup, Fcall_process, delete_temp_file)
209 (Fcall_process_region):
210 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
211 (Fcall_process): Simplify handling of volatile integers.
212 Use int, not EMACS_INT, where int will do.
213 * casefiddle.c (casify_object, casify_region, operate_on_word)
214 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
216 (casify_object): Avoid integer overflow when overallocating buffer.
217 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 218 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
219 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
220 * category.h (CATEGORYP): Don't assume arg is nonnegative.
221 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
222 integers are now checked earlier. All uses replaced with XINT.
223 (ccl_driver):
224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
226 (ccl_driver, Fregister_code_conversion_map):
227 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
228 (resolve_symbol_ccl_program): Check that vector header is in range.
229 Always copy the vector, so that we can check its contents reliably
230 now rather than having to recheck each instruction as it's being
231 executed. Check that vector words fit in 'int'.
232 (ccl_get_compiled_code, Fregister_ccl_program)
233 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
234 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
235 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
236 contents are in range.
237 (Fccl_execute_on_string): Check that status is in range.
238 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
239 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
240 Accept and return EMACS_INT, not int, because callers can pass values
241 out of 'int' range.
242 (c_string_width, strwidth, lisp_string_width, chars_in_text)
243 (multibyte_chars_in_text, parse_str_as_multibyte)
244 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
245 (str_as_unibyte, str_to_unibyte, string_count_byte8)
246 (string_escape_byte8, Fget_byte):
247 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 248 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
249 avoid mishandling large integers.
250 * character.h: Adjust decls to match defn changes elsewhere.
251 * charset.c (load_charset_map_from_file, find_charsets_in_text)
252 (Ffind_charset_region):
253 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
254 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
255 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 256 Don't assume fixnum fits in int.
d311d28c
PE
257 (load_charset_map_from_vector, Fmap_charset_chars):
258 Remove now-unnecessary CHECK_NATNUMs.
259 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
260 Don't rely on undefined behavior with signed left shift overflow.
261 Don't assume unsigned int fits into fixnum, or that fixnum fits
262 into unsigned int. Don't require max_code to be a valid fixnum;
263 that's not true for gb10830 4-byte on a 32-bit host. Allow
264 invalid_code to be a cons, for the same reason. Require code_offset
265 to be a character. Avoid int overflow if max_char is close
266 to INT_MAX.
267 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
268 this is intended anyway and avoids some undefined behavior.
269 (load_charset_map): Pass unsigned, not int, as 2nd arg of
270 INDEX_TO_CODE_POINT, as that's what it expects.
271 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
272 * charset.h (DECODE_CHAR): Return int, not unsigned;
273 this is what was intended anyway, and it avoids undefined behavior.
274 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
275 integer-overflow issues.
276 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
277 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
278 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
279 * chartab.c (Fmake_char_table, Fset_char_table_range)
280 (uniprop_get_decoder, uniprop_get_encoder):
281 Don't assume fixnum fits in int.
282 * cmds.c (move_point): New function, that does the gist of
283 Fforward_char and Fbackward_char, but does so while checking
284 for integer overflow more accurately.
c96e5d6a 285 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
286 (Fforward_line, Fend_of_line, internal_self_insert)
287 (internal_self_insert):
288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
289 Fix a FIXME, by checking for integer overflow when calculating
290 target_clm and actual_clm.
291 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 292 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
293 (ASSURE_DESTINATION, coding_alloc_by_realloc)
294 (coding_alloc_by_making_gap, alloc_destination)
295 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
296 (encode_coding_utf_16, detect_coding_emacs_mule)
297 (decode_coding_emacs_mule, encode_coding_emacs_mule)
298 (detect_coding_iso_2022, decode_coding_iso_2022)
299 (encode_invocation_designation, encode_designation_at_bol)
300 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
301 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
302 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
303 (encode_coding_ccl, encode_coding_raw_text)
304 (detect_coding_charset, decode_coding_charset)
305 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
306 (produce_composition, produce_charset, produce_annotation)
307 (decode_coding, handle_composition_annotation)
308 (handle_charset_annotation, consume_chars, decode_coding_gap)
309 (decode_coding_object, encode_coding_object, detect_coding_system)
310 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
311 (code_convert_region, code_convert_string)
8f50130c
PE
312 (Fdefine_coding_system_internal)
313 (coding_set_source, coding_set_destination):
d311d28c
PE
314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
315 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
316 (Fdefine_coding_system_internal):
317 Don't assume fixnums fit in int.
318 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 319 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
320 (Funencodable_char_position, Fcheck_coding_systems_region)
321 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 322 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 323 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 324 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 325 Don't access memory outside of the args array.
d311d28c 326 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
327 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
328 result of ENCODE_CHAR.
d311d28c
PE
329 * coding.h: Adjust decls to match defn changes elsewhere.
330 (struct coding_system):
331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
332 * composite.c (get_composition_id, find_composition)
333 (run_composition_function, update_compositions)
334 (compose_text, composition_gstring_put_cache)
335 (composition_gstring_p, composition_gstring_width)
336 (fill_gstring_header, fill_gstring_body, autocmp_chars)
337 (composition_compute_stop_pos, composition_reseat_it)
338 (composition_update_it, struct position_record)
339 (find_automatic_composition, composition_adjust_point)
340 (Fcomposition_get_gstring, Ffind_composition_internal):
341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
342 (update_compositions):
343 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
344 * composite.h: Adjust decls to match defn changes elsewhere.
345 (struct composition):
346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
347 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
348 Do not attempt to compute the address of the object just before a
349 buffer; this is not portable.
350 (Faref, Faset):
351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
352 (Faset): Use int, not EMACS_INT, where int is wide enough.
353 (Fstring_to_number): Don't assume fixnums fit in int.
354 (Frem): Don't assume arg is nonnegative.
355 * dbusbind.c (xd_append_arg): Check for integers out of range.
356 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 357 (extract_signed, extract_unsigned): New functions.
243e0530
PE
358 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
359 (xd_get_connection_references): Return ptrdiff_t, not int.
360 All uses changed.
361 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
362 (xd_read_message_1):
363 Use int, not unsigned, where the dbus API uses int.
364 (Fdbus_message_internal): Don't overflow mtype.
365 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
366 * dired.c (directory_files_internal, file_name_completion, scmp)
367 (file_name_completion_stat):
368 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
369 (file_name_completion): Don't overflow matchcount.
370 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
371 * dispextern.h: Adjust decls to match defn changes elsewhere.
372 (struct text_pos, struct glyph, struct bidi_saved_info)
373 (struct bidi_string_data, struct bidi_it, struct composition_it)
374 (struct it):
375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
376 (struct display_pos, struct composition_it, struct it):
377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
378 * dispnew.c (increment_matrix_positions)
379 (increment_row_positions, mode_line_string)
380 (marginal_area_string):
381 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 382 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
383 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
384 (duration_to_sec_usec): New function, to check for overflow better.
385 (Fsleep_for, sit_for): Use it.
386 * doc.c (get_doc_string, store_function_docstring):
387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
388 (get_doc_string, Fsnarf_documentation):
389 Use int, not EMACS_INT, where int is wide enough.
390 (get_doc_string):
391 Use SAFE_ALLOCA, not alloca.
392 Check for overflow when converting EMACS_INT to off_t.
393 * doprnt.c (doprnt):
394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
395 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
396 Don't assume uid_t fits into fixnum.
397 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
398 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
399 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
400 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
401 (general_insert_function)
402 (Finsert_char, make_buffer_string, make_buffer_string_both)
403 (update_buffer_properties, Fbuffer_substring)
404 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
405 (Fsubst_char_in_region, check_translation)
406 (Ftranslate_region_internal, save_restriction_restore, Fformat)
407 (transpose_markers, Ftranspose_regions):
408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
409 (clip_to_bounds): Move to lisp.h as an inline function).
410 (Fconstrain_to_field): Don't assume integers are nonnegative.
411 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
412 (Fsubst_char_in_region, Fsave_restriction):
413 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
414 (Femacs_pid): Don't assume pid_t fits into fixnum.
415 (lo_time): Use int, not EMACS_INT, when int suffices.
416 (lisp_time_argument): Check for usec out of range.
417 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
418 (Fuser_login_name, Fuser_full_name): Signal an error
419 if a uid argument is out of range, rather than relying on
420 undefined behavior.
c8d5c857
PE
421 (Fformat_time_string): Remove now-unnecessary check.
422 lisp_time_argument checks for out-of-range usec now.
243e0530 423 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
424 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
425 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
426 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
427 (init_cmdargs, Fdump_emacs):
428 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
429 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
430 the bottom (typically) 32 bits of the fixnum.
431 * eval.c (specpdl_size, call_debugger):
432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
433 (when_entered_debugger, Fbacktrace_debug):
434 Don't assume fixnum can fit in int.
435 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
436 the object just before a buffer; this is not portable.
437 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
438 (grow_specpdl, unbind_to):
439 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
440 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
441 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 442 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
443 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
444 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
446 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
447 (a_write, e_write):
448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
449 (Fcopy_file, non_regular_nbytes, read_non_regular)
450 (Finsert_file_contents):
451 Use int, not EMACS_INT, where int is wide enough.
452 (READ_BUF_SIZE): Verify that it fits in int.
453 (Finsert_file_contents): Check that counts are in proper range,
454 rather than assuming fixnums fit into ptrdiff_t etc.
455 Don't assume fixnums fit into int.
125b3835 456 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
457 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
458 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
459 (string_char_to_byte, string_byte_to_char)
460 (string_make_multibyte, string_to_multibyte)
461 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
462 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
463 (substring_both, Fdelete, internal_equal, Ffillarray)
464 (Fclear_string, mapcar1)
465 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
466 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
467 (larger_vector, make_hash_table, maybe_resize_hash_table)
468 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
469 (Fmaphash, secure_hash):
470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
471 (concat): Check for string index and length overflow.
472 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
473 (Frequire):
474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
475 (larger_vector): New API (vec, incr_min, size_max) replaces old
476 one (vec, new_size, init). This catches size overflow.
477 INIT was removed because it was always Qnil.
478 All callers changed.
479 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
480 the upper bound on a hash table index size.
481 (make_hash_table, maybe_resize_hash_table): Use it.
482 (secure_hash): Computer start_byte and end_byte only after
483 they're known to be in ptrdiff_t range.
484 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
485 (Ffont_get_glyphs, Ffont_at):
486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
487 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
488 (Flist_fonts, Fopen_font):
489 Don't assume fixnum can fit in int.
490 (check_gstring): Don't assume index can fit in int.
491 (font_match_p): Check that fixnum is a character, not a nonnegative
492 fixnum, since the later code needs to stuff it into an int.
493 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
494 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
495 conversion overflow issues.
496 (Fopen_font): Check for integer out of range.
497 (Ffont_get_glyphs): Don't assume index can fit in int.
498 * font.h: Adjust decls to match defn changes elsewhere.
499 * fontset.c (reorder_font_vector): Redo score calculation to avoid
500 integer overflow.
501 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
502 printmax_t, where ptrdiff_t is wide enough.
503 (Finternal_char_font):
504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
505 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
506 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
507 (Fset_frame_position, x_set_frame_parameters)
508 (x_set_line_spacing, x_set_border_width)
509 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
510 Check that fixnums are in proper range for system types.
511 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
513 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
514 Use SAFE_ALLOCA_LISP, not alloca.
515 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
516 intptr_t is wide enough.
517 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
518 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
519 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
520 Check for fixnum out of range.
521 * ftfont.c (ftfont_list): Don't assume index fits in int.
522 Check that fixnums are in proper range for system types.
523 (ftfont_shape_by_flt):
524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
525 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
527 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
528 Check that fixnums are in proper range for system types.
529 * gnutls.h: Adjust decls to match defn changes elsewhere.
530 * gtkutil.c (xg_dialog_run):
531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
532 (update_frame_tool_bar):
533 Check that fixnums are in proper range for system types.
534 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 535 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
536 * indent.c (last_known_column, last_known_column_point):
537 (current_column_bol_cache):
538 (skip_invisible, current_column, check_display_width):
539 (check_display_width, scan_for_column, current_column_1)
540 (Findent_to, Fcurrent_indentation, position_indentation)
541 (indented_beyond_p, Fmove_to_column, compute_motion):
542 (Fcompute_motion, Fvertical_motion):
543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
544 (last_known_column_modified): Use EMACS_INT, not int.
545 (check_display_width):
546 (Fcompute_motion):
547 Check that fixnums and floats are in proper range for system types.
548 (compute_motion): Don't assume index or fixnum fits in int.
549 (compute_motion, Fcompute_motion):
550 Use int, not EMACS_INT, when it is wide enough.
551 (vmotion): Omit local var start_hpos that is always 0; that way
552 we don't need to worry about overflow in expressions involving it.
553 * indent.h: Adjust decls to match defn changes elsewhere.
554 (struct position):
555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
556 Use int, not EMACS_INT, where int is wide enough.
557 Remove unused members ovstring_chars_done and tab_offset;
558 all uses removed.
559 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
560 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
561 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
562 (make_gap, copy_text, insert, insert_and_inherit)
563 (insert_before_markers, insert_before_markers_and_inherit)
564 (insert_1, count_combining_before, count_combining_after)
565 (insert_1_both, insert_from_string)
566 (insert_from_string_before_markers, insert_from_string_1)
567 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
568 (adjust_after_replace, adjust_after_insert, replace_range)
569 (replace_range_2, del_range, del_range_1, del_range_byte)
570 (del_range_both, del_range_2, modify_region)
571 (prepare_to_modify_buffer, signal_before_change)
572 (signal_after_change, Fcombine_after_change_execute):
573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
574 * intervals.c (traverse_intervals, rotate_right, rotate_left)
575 (balance_an_interval, split_interval_right, split_interval_left)
576 (find_interval, next_interval, update_interval)
577 (adjust_intervals_for_insertion, delete_node, delete_interval)
578 (interval_deletion_adjustment, adjust_intervals_for_deletion)
579 (static_offset_intervals, offset_intervals)
580 (merge_interval_right, merge_interval_left, make_new_interval)
581 (graft_intervals_into_buffer, temp_set_point_both)
582 (temp_set_point, set_point, adjust_for_invis_intang)
583 (set_point_both, move_if_not_intangible, get_property_and_range)
584 (get_local_map, copy_intervals, copy_intervals_to_string)
585 (compare_string_intervals, set_intervals_multibyte_1):
586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
587 * intervals.h: Adjust decls to match defn changes elsewhere.
588 (struct interval):
589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
590 * keyboard.c (this_command_key_count, this_single_command_key_start)
591 (before_command_key_count, before_command_echo_length, echo_now)
592 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
593 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
594 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
595 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
597 (last_non_minibuf_size, last_point_position, echo_truncate)
598 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
599 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
600 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
601 (stuff_buffered_input):
602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
603 (last_auto_save, command_loop_1, read_char):
604 Use EMACS_INT, not int, to avoid integer overflow.
605 (record_char): Avoid overflow in total_keys computation.
606 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
607 * keyboard.h: Adjust decls to match defn changes elsewhere.
608 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
609 (Fkey_description, Fdescribe_vector, Flookup_key):
610 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
611 (click_position): New function, to check that positions are in range.
612 (Fcurrent_active_maps):
613 (describe_command):
614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
615 (Faccessible_keymaps, Fkey_description):
616 (preferred_sequence_p):
617 Don't assume fixnum can fit into int.
618 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
619 Check for integer overflow in size calculations.
620 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
621 avoid mishandling large integers.
622 * lisp.h: Adjust decls to match defn changes elsewhere.
623 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
624 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
625 (struct Lisp_Marker):
626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
627 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
628 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
629 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
630 All callers changed.
631 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
632 Assume the arg has valid form, since it always does.
633 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
634 unsigned integer system type.
635 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
636 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
638 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
639 (duration_to_sec_usec): New decl.
640 * lread.c (read_from_string_index, read_from_string_index_byte)
641 (read_from_string_limit, readchar, unreadchar, openp)
642 (read_internal_start, read1, oblookup):
643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
644 (Fload, readevalloop, Feval_buffer, Feval_region):
645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
646 (openp): Check for out-of-range argument to 'access'.
647 (read1): Use int, not EMACS_INT, where int is wide enough.
648 Don't assume fixnum fits into int.
6efdadfd 649 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
650 (read_filtered_event): Use duration_to_sec_usec
651 to do proper overflow checking on durations.
d311d28c
PE
652 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
653 in size calculation.
654 (Fexecute_kbd_macro):
655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
656 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
657 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
658 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
659 (set_marker_both, set_marker_restricted_both, marker_position)
660 (marker_byte_position, Fbuffer_has_markers_at):
661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
662 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 663 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
664 It now merely ensures that the menu is large enough, without
665 necessarily growing it, as this avoids some integer overflow issues.
666 All callers changed.
667 (keymap_panes, parse_single_submenu, Fx_popup_menu):
668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
669 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
670 Use SAFE_ALLOCA_LISP, not alloca.
671 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
672 to EMACS_INT. Check that fixnums are in proper range for system types.
673 * minibuf.c (minibuf_prompt_width, string_to_object)
674 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
675 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
676 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
677 (get_minibuffer, read_minibuf_unwind):
678 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
679 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
680 this simplifies overflow checking. All callers changed.
681 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
682 (Ftest_completion):
683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
684 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
685 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
686 Check that fixnums are in proper range for system types.
687 (Fx_create_frame, Fx_show_tip):
688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
689 * nsfont.m (ns_findfonts, nsfont_list_family):
690 Don't assume fixnum fits in long.
691 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
693 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
694 wide enough.
17fdb222 695 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
697 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
698 (PRINTDECLARE, PRINTPREPARE):
699 (strout, print_string):
700 (print, print_preprocess, print_check_string_charset_prop)
701 (print_object):
702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
703 (PRINTDECLARE):
704 (temp_output_buffer_setup, Fprin1_to_string, print_object):
705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
706 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 707 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 708 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
709 (print_error_message): Use SAFE_ALLOCA, not alloca.
710 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
711 (print_depth, new_backquote_output, print_number_index):
712 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
713 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
714 (Fset_process_window_size, Fformat_network_address)
715 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 716 (sigchld_handler):
d311d28c 717 Check that fixnums are in proper range for system types.
d44287d4 718 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
719 Check for process-ids out of pid_t range rather than relying on
720 undefined behavior.
e4d81efc 721 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
722 (Fformat_network_address, read_process_output, send_process)
723 (Fprocess_send_region, status_notify):
724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
725 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
726 (wait_reading_process_output, read_process_output, exec_sentinel):
727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
728 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
729 (Faccept_process_output): Use duration_to_sec_usec to do proper
730 overflow checking on durations.
dde14581
PE
731 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
732 Don't assume pid_t fits in int.
02481186
PE
733 * process.h (struct Lisp_Process): Members tick and update_tick
734 are now of type EMACS_INT, not int.
b62b53e8
PE
735 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
736 configured --with-wide-int.
d311d28c
PE
737 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
738 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
739 * search.c (looking_at_1, string_match_1):
740 (fast_string_match, fast_c_string_match_ignore_case)
741 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
742 (scan_newline, find_before_next_newline, search_command)
743 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
744 (set_search_regs, wordify):
745 (Freplace_match):
746 (Fmatch_data):
747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
748 (string_match_1, search_buffer, set_search_regs):
749 (Fmatch_data):
750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
751 (wordify): Check for overflow in size calculation.
752 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
753 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
754 Check that fixnums are in proper range for system types.
755 * sound.c (struct sound_device)
756 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
758 (Fplay_sound_internal):
759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 760 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
761 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
762 (Fparse_partial_sexp):
763 Don't assume fixnums can fit in int.
764 (struct lisp_parse_state, find_start_pos, find_start_value)
765 (find_start_value_byte, find_start_begv)
766 (update_syntax_table, char_quoted, dec_bytepos)
767 (find_defun_start, prev_char_comend_first, back_comment):
768 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
769 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
771 (Finternal_describe_syntax_value): Check that match_lisp is a
772 character, not an integer, since the code stuffs it into int.
773 (scan_words, scan_sexps_forward):
774 Check that fixnums are in proper range for system types.
775 (Fforward_word):
776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
777 (scan_sexps_forward):
778 Use CHARACTERP, not INTEGERP, since the value must fit into int.
779 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
780 * syntax.h: Adjust decls to match defn changes elsewhere.
781 (struct gl_state_s):
782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
783 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
784 MOST_POSITIVE_FIXNUM.
d311d28c
PE
785 * sysdep.c (wait_for_termination_1, wait_for_termination)
786 (interruptible_wait_for_termination, mkdir):
787 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
788 (emacs_read, emacs_write):
789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
790 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
791 and double all fit in int.
d311d28c
PE
792 * term.c (set_tty_color_mode):
793 Check that fixnums are in proper range for system types.
794 * termhooks.h (struct input_event):
795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
796 * textprop.c (validate_interval_range, interval_of)
797 (Fadd_text_properties, set_text_properties_1)
798 (Fremove_text_properties, Fremove_list_of_text_properties)
799 (Ftext_property_any, Ftext_property_not_all)
800 (copy_text_properties, text_property_list, extend_property_ranges)
801 (verify_interval_modification):
802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
803 (Fnext_single_char_property_change)
804 (Fprevious_single_char_property_change):
805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
806 (copy_text_properties):
807 Check for integer overflow in index calculation.
d311d28c
PE
808 * undo.c (last_boundary_position, record_point, record_insert)
809 (record_delete, record_marker_adjustment, record_change)
810 (record_property_change):
811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
812 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
814 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
815 (Fx_hide_tip, Fx_file_dialog):
816 * w32menu.c (set_frame_menubar):
817 Use ptrdiff_t, not int, for consistency with rest of code.
818 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
819 (select_window, Fdelete_other_windows_internal)
820 (window_scroll_pixel_based, window_scroll_line_based)
821 (Frecenter, Fset_window_configuration):
822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
823 (Fset_window_hscroll, run_window_configuration_change_hook)
824 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 825 (Fscroll_other_window, Frecenter):
d311d28c
PE
826 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
827 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
828 Don't assume fixnum fits in int.
829 (Fset_window_scroll_bars):
830 Check that fixnums are in proper range for system types.
831 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
832 (string_pos, c_string_pos, number_of_chars, init_iterator)
833 (in_ellipses_for_invisible_text_p, init_from_display_pos)
834 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
835 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
836 (face_before_or_after_it_pos, handle_invisible_prop)
837 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
838 (display_prop_intangible_p, string_buffer_position_lim)
839 (string_buffer_position, handle_composition_prop, load_overlay_strings)
840 (get_overlay_strings_1, get_overlay_strings)
841 (iterate_out_of_display_property, forward_to_next_line_start)
842 (back_to_previous_visible_line_start, reseat, reseat_to_string)
843 (get_next_display_element, set_iterator_to_next)
844 (get_visually_first_element, compute_stop_pos_backwards)
845 (handle_stop_backwards, next_element_from_buffer)
846 (move_it_in_display_line_to, move_it_in_display_line)
847 (move_it_to, move_it_vertically_backward, move_it_by_lines)
848 (add_to_log, message_dolog, message_log_check_duplicate)
849 (message2, message2_nolog, message3, message3_nolog
850 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
851 (current_message_1, truncate_echo_area, truncate_message_1)
852 (set_message, set_message_1, store_mode_line_noprop)
853 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
854 (text_outside_line_unchanged_p, check_point_in_composition)
855 (reconsider_clip_changes)
856 (redisplay_internal, set_cursor_from_row, try_scrolling)
857 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
858 (redisplay_window, find_last_unchanged_at_beg_row)
859 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
860 (trailing_whitespace_p, find_row_edges, display_line)
861 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
862 (display_mode_element, store_mode_line_string)
863 (pint2str, pint2hrstr, decode_mode_spec)
864 (display_count_lines, display_string, draw_glyphs)
865 (x_produce_glyphs, x_insert_glyphs)
866 (rows_from_pos_range, mouse_face_from_buffer_pos)
867 (fast_find_string_pos, mouse_face_from_string_pos)
868 (note_mode_line_or_margin_highlight, note_mouse_highlight):
869 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
870 (safe_call, init_from_display_pos, handle_fontified_prop)
871 (handle_single_display_spec, load_overlay_strings)
872 (with_echo_area_buffer, setup_echo_area_for_printing)
873 (display_echo_area, echo_area_display)
874 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
875 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
876 (redisplay_window, dump_glyph_row, display_mode_line)
877 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 878 (handle_display_spec, display_prop_string_p):
d311d28c
PE
879 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
880 (handle_single_display_spec, build_desired_tool_bar_string)
881 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
882 (get_specified_cursor_type):
883 Check that fixnums are in proper range for system types.
884 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
885 (Flookup_image_map):
886 Don't assume fixnums fit in int.
887 (compare_overlay_entries):
888 Avoid mishandling comparisons due to subtraction overflow.
889 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
890 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
891 (handle_tool_bar_click):
892 Use int, not unsigned, since we prefer signed and the signedness
893 doesn't matter here.
894 (get_next_display_element, next_element_from_display_vector):
895 Use int, not EMACS_INT, when int is wide enough.
896 (start_hourglass): Use duration_to_sec_usec to do proper
897 overflow checking on durations.
898 * xfaces.c (Fbitmap_spec_p):
899 Check that fixnums are in proper range for system types.
900 (compare_fonts_by_sort_order):
901 Avoid mishandling comparisons due to subtraction overflow.
902 (Fx_family_fonts, realize_basic_faces):
903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
904 (Fx_family_fonts):
905 Don't assume fixnum fits in int.
906 Use SAFE_ALLOCA_LISP, not alloca.
907 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
908 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
909 (face_at_buffer_position, face_for_overlay_string)
910 (face_at_string_position):
911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
912 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
913 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
914 (Fx_show_tip):
915 Check that fixnums are in proper range for system types.
916 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
917 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
918 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
919 (Fx_change_window_property): Don't assume fixnums fit in int.
920 * xfont.c (xfont_chars_supported):
921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
922 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
923 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
924 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
925 * xml.c (parse_region):
926 * xrdb.c (magic_file_p):
927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
928 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
929 (x_get_local_selection, x_reply_selection_request)
930 (x_handle_selection_request, wait_for_property_change):
931 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
932 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
933 short is wide enough.
934 (x_send_client_event): Don't assume fixnum fits in int.
935 * xterm.c (x_x_to_emacs_modifiers):
936 Don't assume EMACS_INT overflows nicely into int.
937 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
938 may come from Lisp.
939 (handle_one_xevent): NATNUMP can eval its arg twice.
940 (x_connection_closed):
941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
942 * xterm.h: Adjust decls to match defn changes elsewhere.
943 (struct scroll_bar): Use struct vectorlike_header
944 rather than rolling our own approximation.
945 (SCROLL_BAR_VEC_SIZE): Remove; not used.
946
c6574eb5
GM
9472012-05-25 Glenn Morris <rgm@gnu.org>
948
949 * lisp.mk (lisp): Update for more files being compiled now.
950
e8d32c7e
SM
9512012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
952
48def666
SM
953 * lread.c: Remove `read_pure' which makes no difference.
954 (read_pure): Remove var.
955 (unreadpure): Remove function.
956 (readevalloop): Don't call read_list with -1 flag.
957 (read1, read_vector): Don't test read_pure any more.
958 (read_list): Simplify.
959
e8d32c7e
SM
960 * fileio.c, character.h: Minor style tweaks.
961
4b2addb7
DA
9622012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
963
964 * window.h (clip_changed): Remove useless declaration.
965
584461b2
JB
9662012-05-22 Juanma Barranquero <lekktu@gmail.com>
967
968 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
969 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
970
34374650
PE
9712012-05-22 Paul Eggert <eggert@cs.ucla.edu>
972
973 Remove src/m/*.
974 This directory predates autoconf and is no longer needed nowadays.
975 Move its few remaining bits of functionality to where they're needed.
976 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
977 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
978 * m/template.h: Remove.
979 * Makefile.in (M_FILE): Remove. All uses removed.
980 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
981 * lisp.h (USE_LSB_TAG):
982 * mem-limits.h (EXCEEDS_LISP_PTR):
983 Use VAL_MAX, not VALBITS, in #if.
984 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
985 (EMACS_UINT): Define unconditionally now.
986 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
987 (BITS_PER_EMACS_INT): New constants, replacing
988 what used to be in config.h, but not useful in #if.
989 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
990 define them any more.
991 (VAL_MAX): New macro.
992 (VALMASK): Use it.
993 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
994 BITS_PER_EMACS_INT, in #if.
995 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
996 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
997 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
998 * s/ms-w32.h (DATA_START):
999 Move here from removed file m/intel386.h.
1000 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1001 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1002
261cb4bb
PE
10032012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1004
1005 Assume C89 or later.
1006 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1007 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1008 (xrealloc):
1009 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1010 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1011 * textprop.c, tparam.c (NULL): Remove.
1012 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1013 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1014 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1015 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1016 * xterm.c (input_signal_count): Assume volatile works.
1017
ff23cd9f
KB
10182012-05-21 Ken Brown <kbrown@cornell.edu>
1019
1020 * xgselect.c (xg_select): Fix first argument in call to 'select'
1021 (bug#11508).
1022
1b170bc6
KB
10232012-05-20 Ken Brown <kbrown@cornell.edu>
1024
1025 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1026 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1027
b2f4d39f
KB
10282012-05-19 Ken Brown <kbrown@cornell.edu>
1029
1030 * xfns.c (x_in_use): Remove `static' qualifier.
1031 * xterm.h (x_in_use): Declare.
1032 * xgselect.c: Include xterm.h.
1033 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1034 and `display_arg' (bug#9754).
1035
003fdae2
PE
10362012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1037
9232a6d9
PE
1038 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1039
003fdae2
PE
1040 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1041 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1042
784b56e2
EZ
10432012-05-18 Eli Zaretskii <eliz@gnu.org>
1044
1045 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1046
1047 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1048 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1049
1050 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1051 reference to image_cache->refcount.
1052 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1053
a0a79cde
JL
10542012-05-17 Juri Linkov <juri@jurta.org>
1055
1056 * search.c (Fword_search_regexp, Fword_search_backward)
1057 (Fword_search_forward, Fword_search_backward_lax)
1058 (Fword_search_forward_lax): Move functions to isearch.el
1059 (bug#10145, bug#11381).
1060
b0572523
PE
10612012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1062
1063 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1064
9660f5fc
SM
10652012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1066
1067 * lread.c (init_obarray): Declare Qt and Qnil as special.
1068
4374de83
GM
10692012-05-14 Glenn Morris <rgm@gnu.org>
1070
1071 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1072 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1073
dc44c39a
PE
10742012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1075
078c97cb
PE
1076 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1077
dc44c39a
PE
1078 * unexaix.c: Port to more-recent AIX compilers.
1079 (report_error, report_error_1, make_hdr, copy_sym)
1080 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1081 Make arguments const char *, not char *, to avoid violations of C
1082 standard and to fix some AIX warnings reported by Gilles Pion.
1083
e18afed7 10842012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1085
1086 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1087 already have overlays loaded.
1088 (handle_single_display_spec): Before returning without displaying
1089 fringe bitmap, synchronize the bidi iterator with the main display
1090 iterator, by calling iterate_out_of_display_property.
1091 (iterate_out_of_display_property): Detect buffer iteration by
1092 testing that it->string is a Lisp string.
1093 (get_next_display_element): When the current object is exhausted,
1094 and there's something on it->stack, call set_iterator_to_next to
1095 proceed with what's on the stack, instead of returning zero.
1096 (set_iterator_to_next): If called at the end of a Lisp string,
1097 proceed to consider_string_end without incrementing string
1098 position. Don't increment display vector index past the end of
1099 the display vector. (Bug#11417)
c8fb9dc6
EZ
1100 (pos_visible_p): Don't report a position visible when move_it_to
1101 stopped at the last line of window, which happens to be scanned
1102 backwards by the bidi iteration. (Bug#11464)
ac268e67 1103
e18afed7 11042012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1105
1106 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1107 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1108 are on a TTY, and thus unable to display on the fringes.
1109 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1110 so we need to signal to the caller that this is a "replacing"
1111 display spec. This fixes display when the spec is invalid or we
1112 are on a TTY.
1113
e18afed7 11142012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1115
1116 * unexaix.c (make_hdr): Fix typo in prototype.
1117 This bug broke the build on AIX. Problem reported by Gilles Pion.
1118
9d0a235a
MA
11192012-05-14 Michael Albinus <michael.albinus@gmx.de>
1120
1121 * keyboard.c (kbd_buffer_get_event): Read special events also in
1122 batch mode. (Bug#11415)
1123
9e6b06ed
GM
11242012-05-12 Glenn Morris <rgm@gnu.org>
1125
1126 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1127
c1a1d7a3
EZ
11282012-05-12 Eli Zaretskii <eliz@gnu.org>
1129
1130 * lisp.mk (lisp): Add newcomment.elc.
1131
3fe7cdc8
GM
11322012-05-12 Glenn Morris <rgm@gnu.org>
1133
1134 * Makefile.in (MKDIR_P): New, set by configure.
1135 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1136
53f7d2c0
PE
11372012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 Remove unused function hourglass_started.
1140 * dispextern.h (hourglass_started):
1141 * w32fns.c (hourglass_started):
1142 * xdisp.c (hourglass_started): Remove.
1143
75aafb17
JB
11442012-05-10 Juanma Barranquero <lekktu@gmail.com>
1145
1146 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1147 Update dependencies.
1148
12959e8e
PE
11492012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1150
97107e2e
PE
1151 * xgselect.c (xg_select): Put maxfds+1 into a var.
1152 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1153
12959e8e
PE
1154 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1155
836d29b3
DA
11562012-05-10 Dave Abrahams <dave@boostpro.com>
1157
1158 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1159 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1160
5cb67954
MA
11612012-05-09 Michael Albinus <michael.albinus@gmx.de>
1162
1163 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1164 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1165 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1166 Initialize xd_registered_buses.
1167
3478ec45
PE
11682012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1169
b263a6b0
PE
1170 Untag more efficiently if USE_LSB_TAG.
1171 This is based on a proposal by YAMAMOTO Mitsuharu in
1172 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1173 For an admittedly artificial (nth 8000 longlist) benchmark on
1174 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1175 Emacs's overall text size by 1%.
1176 * lisp.h (XUNTAG): New macro.
1177 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1178 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1179 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1180 * eval.c (Fautoload):
1181 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1182 * frame.h (XFRAME): Use XUNTAG.
1183
3478ec45
PE
1184 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1185 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1186 Remove unportable assumptions about print widths of types like
1187 dbus_uint32_t.
1188 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1189 intptr_t when converting between pointer and integer, to avoid GCC
1190 warnings about wrong width.
1191
666b903b 11922012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1193
1194 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1195 stack for each reader_thread, instead of defaulting to 8MB
1196 determined by the linker. This avoids failures in creating
1197 subprocesses on Windows 7, see the discussion in this thread:
1198 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1199
b120cc17
JC
12002012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1201
1202 Fix up display of the *Minibuf-0* buffer in the mini window.
1203 * keyboard.c (read_char): Don't clear the echo area if there's no
1204 message to clear.
1205 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1206 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1207
9a4b36f8
MA
12082012-05-07 Michael Albinus <michael.albinus@gmx.de>
1209
1210 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1211 batch mode.
1212
e5f9458f
CY
12132012-05-06 Chong Yidong <cyd@gnu.org>
1214
1215 * lisp.mk (lisp): Update.
1216
eceeb5fc 12172012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1218
1219 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1220
71873e2b
SM
12212012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1222
1223 * data.c (PUT_ERROR): New macro.
1224 (syms_of_data): Use it. Add new error type `user-error'.
1225 * undo.c (user_error): New function.
1226 (Fprimitive_undo): Use it.
1227 * print.c (print_error_message): Adjust print style for `user-error'.
1228 * keyboard.c (user_error): New function.
1229 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1230
ab0fa4e4
PE
12312012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1232
1233 Do not limit current-time-string to years 1000..9999.
1234 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1235 (Fcurrent_time_string): Support any year that is supported by the
1236 underlying localtime representation. Don't use asctime, as it
1237 has undefined behavior for years outside the range -999..9999.
1238
7ed806a7
PE
12392012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1240
1241 Fix race conditions involving setenv, gmtime, localtime, asctime.
1242 Without this fix, interrupts could mess up code that uses these
1243 nonreentrant functions, since setting TZ invalidates existing
1244 tm_zone or tzname values, and since most of these functions return
1245 pointers to static storage.
1246 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1247 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1248 Grow the critical sections to include not just invoking
1249 localtime/gmtime, but also accessing these functions' results
1250 including their tm_zone values if any, and any related TZ setting.
1251 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1252 so that the struct tm is saved in the critical section.
1253 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1254 motivated by the fact that memory allocation needs to be outside
1255 the critical section.
1256
0c16dfed
DA
12572012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1258
1259 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1260 with RESET_INTERVAL.
1261
1262 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1263 Remove duplicated buffer name initialization.
1264
3f83ace8
JM
12652012-05-02 Jim Meyering <jim@meyering.net>
1266
1267 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1268
c7b8541e
JM
1269 * xfns.c (x_window): Use xstrdup (Bug#11375).
1270
90207a15 12712012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1272
1273 * xdisp.c (pos_visible_p): If already at a newline from the
1274 display string before the 'while' loop, don't walk back the glyphs
1275 from it3.glyph_row. Solves assertion violation when the display
1276 string begins with a newline (egg.el). (Bug#11367)
1277
b593d6a9
AH
12782012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1279
1280 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1281 Move to simple.el.
1282
4737362e
GM
12832012-05-01 Glenn Morris <rgm@gnu.org>
1284
99cf43f9
GM
1285 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1286 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1287 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1288 All were removed before 23.1.
1289
9311dcff
GM
1290 * dispnew.c: Remove HAVE_LIBNCURSES test;
1291 it is always true on relevant platforms.
1292
4d5c6349
GM
1293 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1294 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1295
4737362e
GM
1296 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1297
74dd3a6b
AS
12982012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1299
1300 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1301 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1302 Remove.
1303
13c379ee
PE
13042012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1305
1306 Do not avoid creating empty evaporating overlays (Bug#9642).
1307 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1308 That is, do not delete an evaporating overlay if it becomes
1309 empty after its bounds are adjusted to fit within its buffer.
1310 This fix caused other problems, and I'm reverting it until we get
1311 to the bottom of them.
1312
a8e7d6d7 13132012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1314
1315 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1316
a8e7d6d7 13172012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1318
1319 * xdisp.c (pos_visible_p): If the window start position is beyond
1320 ZV, start the display from buffer beginning. Prevents assertion
1321 violation in init_iterator when the minibuffer window is scrolled
1322 via the scroll bar.
1323
1324 * window.c (window_scroll_pixel_based): Likewise.
1325
a8e7d6d7 13262012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1327
1328 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1329
a8e7d6d7 13302012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1331
1332 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1333 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1334
a8e7d6d7 13352012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1336
b593d6a9
AH
1337 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1338 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1339
1c6900d9
EZ
13402012-04-26 Eli Zaretskii <eliz@gnu.org>
1341
4c3fa1d9
EZ
1342 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1343 display element, check also the underlying string or buffer
1344 character. (Bug#11341)
1345
1c6900d9
EZ
1346 * w32menu.c: Include w32heap.h.
1347 (add_menu_item): If the call to AppendMenuW (via
1348 unicode_append_menu) fails, disable Unicode menus only if we are
1349 running on Windows 9X/Me.
1350
42bf8205
AS
13512012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1352
1353 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1354 (xgetint): Add missing shift for LSB tags.
1355
b1bac16e
MR
13562012-04-24 Martin Rudalics <rudalics@gmx.at>
1357
1358 * keyboard.c (read_char): Don't wipe echo area for select window
1359 events: These might get delayed via `mouse-autoselect-window'
1360 (Bug#11304).
1361
d69621cc
JB
13622012-04-24 Juanma Barranquero <lekktu@gmail.com>
1363
1364 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1365 manipulation of :loaded-from data.
1366
02fd101b
JB
13672012-04-23 Juanma Barranquero <lekktu@gmail.com>
1368
1369 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1370 now a cons (bug#11311).
1371
888bec30
PE
13722012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1373
89a438bd
PE
1374 Do not create empty overlays with the evaporate property (Bug#9642).
1375 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1376 if it becomes empty after its bounds are adjusted to fit within
1377 its buffer. Without this fix, in a nonempty buffer (let ((o
1378 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1379 yields an empty overlay that has the evaporate property, which is
1380 not supposed to happen.
1381
1068fe4d
PE
1382 Fix minor GTK3 problems found by static checking.
1383 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1384 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1385 (struct _EmacsFixedClass, emacs_fixed_get_type):
1386 Move decls here from emacsgtkfixed.h, since they needn't be public.
1387 (emacs_fixed_get_type): Now static.
1388 (emacs_fixed_class_init): Omit unused local.
1389 (emacs_fixed_child_type): Remove; unused.
1390 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1391 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1392 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1393 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1394 (EMACS_FIXED_GET_CLASS): Remove; unused.
1395 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1396
888bec30
PE
1397 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1398 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1399
de85e130
PE
14002012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1401
d0baac98 1402 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1403 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1404 (__malloc_size_t, __malloc_ptrdiff_t):
1405 Remove. All uses removed, replaced by the definiens if needed,
1406 since we can assume C89 or better now.
1407 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1408 (protect_malloc_state, align, get_contiguous_space)
1409 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1410 (malloc_atfork_handler_child, malloc_enable_thread)
1411 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1412 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1413 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1414 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1415 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1416 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1417 Define using prototypes, not old style.
1418 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1419 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1420 (align): Don't assume that signed integer overflow wraps around.
1421 Omit unused local var.
1422 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1423 (_free_internal_nolock, memalign, mallochook, reallochook):
1424 Omit no-longer-needed casts.
1425 (valloc): Use getpagesize, not __getpagesize.
1426 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1427 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1428
de85e130
PE
1429 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1430
dcbf5805
MA
14312012-04-22 Michael Albinus <michael.albinus@gmx.de>
1432
1433 Move functions from C to Lisp. Make non-blocking method calls
1434 the default. Implement further D-Bus standard interfaces.
1435
1436 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1437 (QCdbus_request_name_allow_replacement)
1438 (QCdbus_request_name_replace_existing)
1439 (QCdbus_request_name_do_not_queue)
1440 (QCdbus_request_name_reply_primary_owner)
1441 (QCdbus_request_name_reply_in_queue)
1442 (QCdbus_request_name_reply_exists)
1443 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1444 (QCdbus_registered_serial, QCdbus_registered_method)
1445 (QCdbus_registered_signal): New Lisp objects.
1446 (XD_DEBUG_MESSAGE): Use sizeof.
1447 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1448 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1449 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1450 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1451 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1452 (xd_signature, xd_append_arg): Allow float for integer types.
1453 (xd_get_connection_references): New function.
b593d6a9
AH
1454 (xd_get_connection_address): Rename from xd_initialize.
1455 Return cached address.
dcbf5805
MA
1456 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1457 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1458 level.
1459 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1460 Return number of refcounts.
dcbf5805
MA
1461 (Fdbus_get_unique_name): Make stronger parameter check.
1462 (Fdbus_message_internal): New defun.
1463 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1464 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1465 (Fdbus_send_signal, Fdbus_register_service)
1466 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1467 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1468 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1469 (Vdbus_compiled_version, Vdbus_runtime_version)
1470 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1471 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1472 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1473 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1474 Adapt docstring.
dcbf5805 1475
52828e02
PE
14762012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1477
da05bc4c
PE
1478 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1479 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1480 Do not assume ptrdiff_t is the same width as 'int'.
1481
52828e02
PE
1482 * alloc.c: Handle unusual debugging option combinations.
1483 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1484 since the two debugging options are incompatible.
1485 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1486 is defined.
1487 (mem_init, mem_insert, mem_insert_fixup):
1488 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1489 (NEED_MEM_INSERT): Remove; no longer needed.
1490
f01769f9
LL
14912012-04-22 Leo Liu <sdl.web@gmail.com>
1492
1493 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1494
5790543d
PE
14952012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1496
1497 * sysdep.c [__FreeBSD__]: Minor cleanups.
1498 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1499 Use Emacs indenting style more consistently. Avoid some casts.
1500 Use 'double' consistently rather than mixing 'float' and 'double'.
1501
b91b7e4d
EW
15022012-04-21 Eduard Wiebe <usenet@pusto.de>
1503
b593d6a9
AH
1504 * sysdep.c (list_system_processes, system_process_attributes):
1505 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1506
6114eb15
AS
15072012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1508
1509 * lisp.mk (lisp): Update.
1510
2f38dff7
PE
15112012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1512
1513 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1514 It is never used otherwise.
1515
4ae29f89
SM
15162012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1517
1518 * print.c (print_preprocess): Only check print_depth if print-circle
1519 is nil.
1520 (print_object): Check for cycles even when print-circle is nil and
1521 print-gensym is t, but only check print_depth if print-circle is nil.
1522
f30d612a
CY
15232012-04-20 Chong Yidong <cyd@gnu.org>
1524
1525 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1526 set the status to "failed" and ensure that sentinel is run.
1527
c07a4c0b 15282012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1529
1530 * process.c (Fset_process_inherit_coding_system_flag)
1531 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1532 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1533
c07a4c0b 15342012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1535
1536 * xdisp.c (string_buffer_position_lim): Limit starting position to
1537 BEGV.
1538 (set_cursor_from_row): If called for a mode-line or header-line
1539 row, return zero immediately.
1540 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1541 farther than the first row after the header line, if any.
1542 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1543 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1544
c07a4c0b 15452012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1546
4ae29f89
SM
1547 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1548 (bug#11238).
ad3a2b41 1549
c07a4c0b 15502012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 15512012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1552
1553 configure: new option --enable-gcc-warnings (Bug#11207)
1554 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1555 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1556 (ALL_CFLAGS): Use new macros rather than old.
1557 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1558 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1559 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1560 -Wunused-result, -Wunused-variable. This should go away once
1561 the Emacs and Gnulib regex code is merged.
1562 (xmalloc, xrealloc): Now static.
1563
aba027e8
PE
15642012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1565
1566 * dired.c (Fsystem_groups): Remove unused local.
1567
e5a36063
GM
15682012-04-17 Glenn Morris <rgm@gnu.org>
1569
1570 * dired.c (Fsystem_users): Doc fix.
1571
316411f0
DA
15722012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1573
1574 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1575 (syms_of_dired): Add them.
1576
9426aba4
PE
15772012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1578
b62a57be
PE
1579 Fix minor alloc.c problems found by static checking.
1580 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1581 New extern decls, to avoid calling undeclared functions.
1582 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1583 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1584 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1585 (NEED_MEM_INSERT): New macro.
1586 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1587 Remove one incorrect comment and fix another.
b62a57be 1588
3539f31f
PE
1589 Fix minor ralloc.c problems found by static checking.
1590 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1591 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1592 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1593 (r_alloc_sbrk): Now static.
1594
a041960a
PE
1595 Improve ralloc.c interface checking.
1596 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1597 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1598 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1599 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1600 [REL_ALLOC]: ... to here, to check interface.
1601 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1602 Remove decls. This fixes an "It stinks!".
1603
9426aba4
PE
1604 * alloc.c (which_symbols): Fix alignment issue / type clash.
1605
d55c12ed
AS
16062012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1607
1608 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1609 (struct Lisp_Misc_Any): Likewise.
1610 (struct Lisp_Free): Likewise.
1611 * alloc.c (union aligned_Lisp_Symbol): Define.
1612 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1613 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1614 (union aligned_Lisp_Misc): Define.
1615 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1616 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1617 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1618
b948ce8b
PE
16192012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1620
1621 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1622 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1623 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1624 * s/netbsd.h, s/sol2-6.h:
1625 Remove definition of GC_MARK_STACK, since the default now works.
1626 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1627 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1628 no longer the default.
1629 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1630
35dc09a1 16312012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1632
35dc09a1
GM
1633 * lread.c (lisp_file_lexically_bound_p):
1634 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1635
35dc09a1
GM
16362012-04-14 Eli Zaretskii <eliz@gnu.org>
1637
1638 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1639 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1640
16412012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1642
1643 * nsterm.m (constrainFrameRect): Always constrain when there is only
1644 one screen (Bug#10962).
1645
bcd86815
KB
16462012-04-13 Ken Brown <kbrown@cornell.edu>
1647
1648 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1649
c25df26e
RT
16502012-04-13 Reuben Thomas <rrt@sc3d.org>
1651
1652 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1653
0fc59f1e
DC
16542012-04-11 Daniel Colascione <dancol@dancol.org>
1655
1656 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1657 against is gone. It's better to use vfork now so that when Cygwin
1658 gains a new, working vfork, we use it automatically (bug#10398).
1659
de8c03dc
SM
16602012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1661
1662 * window.c (save_window_save): Obey window-point-insertion-type.
1663
2f097256
GM
16642012-04-11 Glenn Morris <rgm@gnu.org>
1665
1666 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1667
453b951e
SM
16682012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1669
1670 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1671
75f1671a 16722012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1673
1674 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1675 (force_quit_count): New var.
1676 (handle_interrupt): Use it.
1677
2a8ce227
JB
16782012-04-10 Juanma Barranquero <lekktu@gmail.com>
1679
1680 * w32.c (w32_delayed_load): Record the full path of the library
1681 being loaded (bug#10424).
1682
935396c0
GM
16832012-04-09 Glenn Morris <rgm@gnu.org>
1684
05920a43
GM
1685 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1686 not just in the obarray, before snarfing them. (Bug#11036)
1687
935396c0
GM
1688 * Makefile.in ($(leimdir)/leim-list.el):
1689 Pass EMACS rather than BUILT_EMACS.
1690
a18ecafa
TZ
16912012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1692
1693 * process.c (make_process):
1694 * process.h: Add integer `gnutls_handshakes_tried' member to
1695 process struct.
1696
6bbef4e5
JC
1697 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1698 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1699
1700 * gnutls.c (gnutls_log_function2i): Convenience log function.
1701 (emacs_gnutls_read): Use new log functions,
1702 `gnutls_handshakes_tried' process member, and
1703 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1704 attempts per process (connection).
1705
b4d3bc10
CY
17062012-04-09 Chong Yidong <cyd@gnu.org>
1707
1708 * eval.c (Fuser_variable_p, user_variable_p_eh)
1709 (lisp_indirect_variable): Functions deleted.
1710 (Fdefvar): Caller changed.
1711
1712 * callint.c (Finteractive, Fcall_interactively):
1713 * minibuf.c (Fread_variable): Callers changed.
1714
70f4d973
EZ
17152012-04-09 Eli Zaretskii <eliz@gnu.org>
1716
1717 * xdisp.c (set_cursor_from_row): If the display string appears in
1718 the buffer at position that is closer to point than the position
1719 after the display string, display the cursor on the first glyph of
1720 the display string. Fixes cursor display when a 'display' text
1721 property immediately follows invisible text. (Bug#11094)
1722
cb3c2e3e
PE
17232012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1724
1725 composite.c: use 'double' consistently
1726 * composite.c (get_composition_id): Use 'double' consistently
1727 instead of converting 'float' to 'double' and vice versa; this is
1728 easier to understand and avoids a GCC warning.
1729
fd06db5d
GM
17302012-04-09 Glenn Morris <rgm@gnu.org>
1731
50fe702a
GM
1732 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1733 preparation for dumping it with emacs. (Bug#4789)
1734 (leimdir): New variable.
1735 ($(leimdir)/leim-list.el): New rule.
1736 (emacs$(EXEEXT)): Depend on leim-list.el.
1737
fd06db5d
GM
1738 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1739 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1740 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1741
55c131ee
AS
17422012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1743
1744 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1745 proper alignment.
1746
9209588f
JB
17472012-04-07 Juanma Barranquero <lekktu@gmail.com>
1748
1749 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1750 Remove unused local variable.
1751
e3fb2efb
PE
17522012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1753
1754 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1755 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1756 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1757 objects, as mark_maybe_pointer will catch them otherwise.
1758 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1759 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1760
b5385551
PE
17612012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1762
1763 Fix typo that broke non-Windows builds.
1764 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1765
9078ead6
EZ
17662012-04-07 Eli Zaretskii <eliz@gnu.org>
1767
1768 Support building on MS-Windows with libxml2.
1769
1770 * makefile.w32-in (OBJ2): Add xml.$(O).
1771 (GLOBAL_SOURCES): Add xml.c.
1772 ($(BLD)/xml.$(O)): New dependency list.
1773
1774 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1775 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1776 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1777 [!WINDOWSNT]: New macros.
1778 (init_libxml2_functions, libxml2_loaded_p): New functions.
1779 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1780 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1781 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1782 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1783 linked in).
6bbef4e5
JC
1784 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1785 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
1786 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1787
1788 * emacs.c: Don't include libxml/parser.h.
1789 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1790 xmlCleanupParser directly.
1791
1792 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1793
3811fdf3
EZ
17942012-04-07 Eli Zaretskii <eliz@gnu.org>
1795
1796 * indent.c (Fvertical_motion): If there is a display string at
1797 point, use it.vpos to compute how many lines to backtrack after
1798 move_it_to point. (Bug#11133)
1799
2f8e16b2
EZ
18002012-04-06 Eli Zaretskii <eliz@gnu.org>
1801
1802 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1803 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1804 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1805 macros related to unification of CJK characters. For the details,
1806 see the discussion following the message here:
1807 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1808
3d439cd1
CY
18092012-04-04 Chong Yidong <cyd@gnu.org>
1810
1811 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1812
8bc53d00
EZ
18132012-04-01 Eli Zaretskii <eliz@gnu.org>
1814
1815 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1816 instead of alloca. (Bug#11138)
1817
3b0512a3
AS
18182012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1819
1820 * w32menu.c (is_simple_dialog): Properly check lisp types.
1821 (Bug#11141)
1822
8427ddd2
EZ
18232012-03-31 Eli Zaretskii <eliz@gnu.org>
1824
979022ef
EZ
1825 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1826 position we get to after a call to move_it_to fails the
1827 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1828 only if we wind up in a string from display property. (Bug#11063)
1829
a6b1c7cc
EZ
1830 * window.c (Fdelete_other_windows_internal): Invalidate the row
1831 and column information about mouse highlight, so that redisplay
1832 restores it after reallocating the glyph matrices. (Bug#7464)
1833
8427ddd2
EZ
1834 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1835 string comes from a `display' text property, use the buffer
1836 position of that property as if we actually saw that position in
1837 the row's glyphs.
697ba24b
EZ
1838 (move_it_by_lines): Remove the assertion that
1839 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1840 violated when there's a before-string at the beginning of a line.
1841 (Bug#11063)
8427ddd2 1842
65a0a738
EZ
18432012-03-30 Eli Zaretskii <eliz@gnu.org>
1844
1845 * xdisp.c (append_space_for_newline): If the default face was
1846 remapped, use the remapped face for the appended newline.
1847 (extend_face_to_end_of_line): Use the remapped default face for
1848 extending the face to the end of the line.
1849 (display_line): Call extend_face_to_end_of_line when the default
1850 face was remapped. (Bug#11068)
1851
581355cc
EZ
18522012-03-29 Eli Zaretskii <eliz@gnu.org>
1853
1854 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1855
e8fc049f
SM
18562012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1857
1858 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1859
4fb9a543
GM
18602012-03-27 Glenn Morris <rgm@gnu.org>
1861
1862 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1863 Doc fixes.
1864
679910f1
KH
18652012-03-26 Kenichi Handa <handa@m17n.org>
1866
1867 * dispextern.h (struct glyph): Fix previous change. Change the
1868 bit length of glyphless.ch to 25 (Bug#11082).
1869
90d49b7f
CY
18702012-03-26 Chong Yidong <cyd@gnu.org>
1871
1872 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1873 (command_loop_1): Use it; inhibit selection update for
1874 handle-select-window too (Bug#8996).
1875
f514f6f0
FP
18762012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1877
e8fc049f 1878 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 1879
bf43fa51
KH
18802012-03-25 Kenichi Handa <handa@m17n.org>
1881
1882 * dispextern.h (struct glyph): Change the bit length of
1883 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1884
8a0c01dd
EZ
18852012-03-24 Eli Zaretskii <eliz@gnu.org>
1886
1887 * s/ms-w32.h (tzname): Include time.h before redirecting to
1888 _tzname. Fixes the MSVC build. (Bug#9960)
1889
7d1c3a76
AS
18902012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1891
8ed79523
AS
1892 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1893 characters.
1894
7d1c3a76
AS
1895 * xterm.c (XTread_socket): Only modify handling_signal if
1896 !SYNC_INPUT. (Bug#11080)
1897
e99a9b8b
EZ
18982012-03-23 Eli Zaretskii <eliz@gnu.org>
1899
1900 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1901 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1902 when fetching a multibyte character consumes more bytes than
1903 CHAR_BYTES returns, due to unification of CJK characters in
1904 string_char. (Bug#11073)
1905
5063c0e1
TN
19062012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1907
1908 * process.c (wait_reading_process_output): Handle pty disconnect
1909 by refraining from sending oneself a SIGCHLD (bug#10933).
1910
9f851fbd
CY
19112012-03-22 Chong Yidong <cyd@gnu.org>
1912
1913 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1914
5063c0e1 1915 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
1916 Mark string as coming from a prefix property.
1917 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1918 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1919
fb5b8aca
CY
19202012-03-21 Chong Yidong <cyd@gnu.org>
1921
1922 * xfaces.c (Vface_remapping_alist): Doc fix.
1923
62356a1b
EZ
19242012-03-20 Eli Zaretskii <eliz@gnu.org>
1925
1926 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
1927 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1928 Doc fixes.
62356a1b 1929
025de85b
CY
19302012-03-20 Chong Yidong <cyd@gnu.org>
1931
1932 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1933 to reflect default non-nil value of redisplay-dont-pause.
1934
4827f94e
KH
19352012-03-19 Kenichi Handa <handa@m17n.org>
1936
1937 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1938 it fit in a valid range (Bug#11003).
1939
e50a24a2
EZ
19402012-03-18 Eli Zaretskii <eliz@gnu.org>
1941
1942 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1943 that is not from display property, accept the row as a "cursor
1944 row" if one of the string's character has a non-nil `cursor'
1945 property. Fixes cursor positioning when there are newlines in
1946 overlay strings, e.g. in icomplete.el. (Bug#11035)
1947
9af5ed87
PE
19482012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1949
1950 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1951
d1f55f16
CY
19522012-03-12 Chong Yidong <cyd@gnu.org>
1953
1954 * eval.c (inhibit_lisp_code): Rename from
1955 inhibit_window_configuration_change_hook; move from window.c.
1956
1957 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1958 * window.c (run_window_configuration_change_hook)
1959 (syms_of_window): Callers changed.
1960
66c5eebd
CY
19612012-03-11 Chong Yidong <cyd@gnu.org>
1962
413df973
CY
1963 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1964
66c5eebd
CY
1965 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1966
1de11f56
CY
19672012-03-10 Chong Yidong <cyd@gnu.org>
1968
1969 * frame.c (other_visible_frames): Don't assume the selected frame
1970 is visible (Bug#10955).
1971
cae07000
SM
19722012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1973
1974 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1975
89c94350
JD
19762012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1977
1978 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1979 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1980 zero (Bug#10954).
1981
999dd333
GM
19822012-03-03 Glenn Morris <rgm@gnu.org>
1983
01a6dcc8 1984 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 1985
de0100f2
EZ
19862012-03-02 Eli Zaretskii <eliz@gnu.org>
1987
1988 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1989 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
1990 (redisplay_window, next_element_from_string): Fix typos in
1991 comments.
3e441275
EZ
1992 (redisplay_window): Pass to move_it_vertically the margin in
1993 pixels, not in screen lines.
de0100f2 1994
96a72ee9
GM
19952012-03-02 Glenn Morris <rgm@gnu.org>
1996
1997 * buffer.c (buffer-list-update-hook): Doc fix.
1998
312508d7
EZ
19992012-02-29 Eli Zaretskii <eliz@gnu.org>
2000
2001 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2002 push_it before setting up the iterator for the first overlay
2003 string, even if we have an empty string loaded.
2004 (next_overlay_string): If there's an empty string on the iterator
2005 stack, pop the stack. (Bug#10903)
2006
27f3c637
PE
20072012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2010 Suggested by Stefan Monnier in
2011 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2012 * alloc.c (widen_to_Lisp_Object): New static function.
2013 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2014 and widening them to Lisp_Objects. This would work even if
2015 USE_LSB_TAG is defined and wide integers are used, which might
2016 happen in a future version of Emacs.
2017
3c9dfce6
CY
20182012-02-25 Chong Yidong <cyd@gnu.org>
2019
fa74b241
CY
2020 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2021 Doc fix.
2022
3c9dfce6
CY
2023 * xselect.c (Fx_selection_exists_p): Doc fix.
2024 (x_clipboard_manager_save_all): Print an informative message
2025 before saving to clipboard manager.
2026
9486df08
CY
20272012-02-24 Chong Yidong <cyd@gnu.org>
2028
2029 * keyboard.c (process_special_events): Handle all X selection
2030 requests in kbd_buffer, not just the next one (Bug#8869).
2031
f01d3321
CY
20322012-02-23 Chong Yidong <cyd@gnu.org>
2033
2034 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2035 call when setting menu-bar-lines and tool-bar-lines parameters.
2036 (unwind_create_frame_1): New helper function.
2037
2038 * window.c (inhibit_window_configuration_change_hook): New var.
2039 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2040 (syms_of_window): Initialize it.
f01d3321 2041
86b847b6
CY
20422012-02-22 Chong Yidong <cyd@gnu.org>
2043
2044 * xterm.c (x_draw_image_relief): Add missing type check for
2045 Vtool_bar_button_margin (Bug#10743).
2046
a59225b1
CY
20472012-02-21 Chong Yidong <cyd@gnu.org>
2048
2049 * fileio.c (Vfile_name_handler_alist): Doc fix.
2050
2051 * buffer.c (Fget_file_buffer): Protect against invalid file
2052 handler return value.
2053
310f5bd4
PE
20542012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2055
cb3a28cc
PE
2056 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2057 when computing $valmask.
2058
310f5bd4
PE
2059 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2060 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2061 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2062 It's useless in that case, and it can cause problems on hosts
2063 that allocate halves of EMACS_INT values separately.
2064 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2065 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2066 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2067 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2068 it avoids undefined behavior on hosts where shifting right by more
2069 than the word width has undefined behavior.
2070
2375c96a
CY
20712012-02-19 Chong Yidong <cyd@gnu.org>
2072
2073 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2074 (Funhandled_file_name_directory, Ffile_name_as_directory)
2075 (Fdirectory_file_name, Fexpand_file_name)
2076 (Fsubstitute_in_file_name): Protect against invalid file handler
2077 return values (Bug#10845).
2078
3eb49e71
EZ
20792012-02-18 Eli Zaretskii <eliz@gnu.org>
2080
2081 * .gdbinit (pitx): Fix incorrect references to fields of the
2082 iterator stack.
2083
7b926f3f
CY
20842012-02-17 Chong Yidong <cyd@gnu.org>
2085
2086 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2087
11273115
PE
20882012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2089
2090 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2091 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2092
c3a70e2b
CY
20932012-02-15 Chong Yidong <cyd@gnu.org>
2094
2095 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2096 marked as special. Also, starting docstrings with * is obsolete.
2097
0ca43699
AS
20982012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2099
2100 * gnutls.c (emacs_gnutls_write): Fix last change.
2101
2e8f3c56
LI
21022012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2103
2104 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2105 send_process.
2106
af70074f
SM
21072012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2108
2109 * keymap.c (Fsingle_key_description): Handle char ranges.
2110
95986d52
CY
21112012-02-12 Chong Yidong <cyd@gnu.org>
2112
afd83bd1
CY
2113 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2114 as that creates a dangerous corner case.
2115
95986d52
CY
2116 * window.c (Fdelete_window_internal): Invalidate the mouse
2117 highlight (Bug#9904).
2118
bd7da63e
GM
21192012-02-12 Glenn Morris <rgm@gnu.org>
2120
2121 * xselect.c (Fx_own_selection_internal)
2122 (Fx_get_selection_internal, Fx_disown_selection_internal)
2123 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2124 * nsselect.m (Fx_own_selection_internal)
2125 (Fx_disown_selection_internal, Fx_selection_exists_p)
2126 (Fx_selection_owner_p, Fx_get_selection_internal):
2127 Sync docs and argument specs with the xselect.c versions.
2128
77abcbc2
LI
21292012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2130
2131 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2132
90b671e2
EZ
21332012-02-11 Eli Zaretskii <eliz@gnu.org>
2134
1c0ca0b7
EZ
2135 * w32select.c (Fx_selection_exists_p): Sync doc string and
2136 argument list with xselect.c. (Bug#10783)
2137
2138 * w16select.c (Fx_selection_exists_p): Sync doc string and
2139 argument list with xselect.c. (Bug#10783)
90b671e2 2140
49241268
GM
21412012-02-10 Glenn Morris <rgm@gnu.org>
2142
2143 * fns.c (Fsecure_hash): Doc fix.
2144
f998bbe7 21452012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2146
2147 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2148
0992bd9c
CY
21492012-02-07 Chong Yidong <cyd@gnu.org>
2150
2151 * buffer.c (Fbuffer_local_variables)
2152 (buffer_lisp_local_variables): Handle unbound vars correctly;
2153 don't let Qunbound leak into Lisp.
2154
af008560
GM
21552012-02-07 Glenn Morris <rgm@gnu.org>
2156
dd605cc4
GM
2157 * image.c (Fimagemagick_types): Doc fix.
2158
af008560
GM
2159 * image.c (imagemagick-render-type): Change it from a lisp object
2160 to an integer. Move the doc here from the lisp manual.
2161 Treat all values not equal to 0 the same.
2162
1449fa1d
CY
21632012-02-06 Chong Yidong <cyd@gnu.org>
2164
2165 * doc.c (store_function_docstring): Avoid applying docstring of
2166 alias to base function (Bug#2603).
2167
3723ec07
AS
21682012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2169
2170 * .gdbinit (pp1, pv1): Remove redundant defines.
2171 (pr): Use pp.
2172
79c1cc1e
CY
21732012-02-04 Chong Yidong <cyd@gnu.org>
2174
2175 * nsterm.m: Declare a global (Bug#10694).
2176
d7f29f8e
EZ
21772012-02-04 Eli Zaretskii <eliz@gnu.org>
2178
cae07000
SM
2179 * w32.c (get_emacs_configuration_options):
2180 Include --enable-checking, if specified, in the return value.
d7f29f8e 2181
3b95a6f9
MR
21822012-02-04 Martin Rudalics <rudalics@gmx.at>
2183
2184 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2185 after rounding frame sizes. (Bug#9723)
2186
d6fa96a6
EZ
21872012-02-04 Eli Zaretskii <eliz@gnu.org>
2188
2189 * keyboard.c (adjust_point_for_property): Don't position point
2190 before BEGV. (Bug#10696)
2191
df0b2940
PE
21922012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2193
2194 Handle overflow when computing char display width (Bug#9496).
2195 * character.c (char_width): Return EMACS_INT, not int.
2196 (char_width, c_string_width): Check for overflow when
2197 computing the width; this is possible now that individual
2198 characters can have unbounded width. Problem introduced
2199 by merge from Emacs 23 on 2012-01-19.
2200
6bee44d6
MA
22012012-02-02 Michael Albinus <michael.albinus@gmx.de>
2202
2203 * dbusbind.c (Fdbus_register_method): Mention the return value
2204 :ignore in the docstring.
2205
44f92739
GM
22062012-02-02 Glenn Morris <rgm@gnu.org>
2207
1b9f60cc
GM
2208 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2209
44f92739
GM
2210 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2211 Unconditionally set to t. (Bug#10673)
2212 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2213 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2214 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2215
c5d3843c
KH
22162012-02-02 Kenichi Handa <handa@m17n.org>
2217
2218 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2219 0, do not call append_composite_glyph.
2220
159462d4 22212012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2222
2223 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2224 NULL (Bug#6988).
2225 (x_produce_glyphs): If the component of a composition is a null
2226 string, set it->pixel_width to 1 to avoid zero-width glyph.
2227
78cef877
EZ
22282012-02-01 Eli Zaretskii <eliz@gnu.org>
2229
2230 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2231 first 2 arguments are identical. This makes inserting large
2232 output from a subprocess an order of magnitude faster on
2233 MS-Windows, where all sbrk'ed memory is always contiguous.
2234
97897668
GM
22352012-01-31 Glenn Morris <rgm@gnu.org>
2236
2237 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2238 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2239 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2240
31fd3586
GM
22412012-01-29 Glenn Morris <rgm@gnu.org>
2242
2243 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2244
0e24a8b2
CY
22452012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2246
2247 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2248
cc0adcb0
CY
22492012-01-28 Chong Yidong <cyd@gnu.org>
2250
2251 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2252
acc28cb9
CY
22532012-01-26 Chong Yidong <cyd@gnu.org>
2254
9c69cfb7
CY
2255 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2256
acc28cb9
CY
2257 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2258 repeat counts (Bug#10507).
2259
48da7392
GM
22602012-01-26 Glenn Morris <rgm@gnu.org>
2261
2262 * lread.c (syms_of_lread): Doc fix.
2263
14af5f7f
CY
22642012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2265
2266 * coding.c (encode_designation_at_bol): Change return value to
2267 EMACS_INT.
2268
0b21c100
CY
22692012-01-25 Chong Yidong <cyd@gnu.org>
2270
2271 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2272
3c2907f7
CY
22732012-01-21 Chong Yidong <cyd@gnu.org>
2274
2275 * floatfns.c (Fcopysign): Make the second argument non-optional,
2276 since nil is not allowed anyway.
2277
959ad23f
AS
22782012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2279
2280 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2281 (send_process): Likewise.
2282
34a02f46
MR
22832012-01-19 Martin Rudalics <rudalics@gmx.at>
2284
2285 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2286 (Vwindow_persistent_parameters): Do not use Qstate.
2287 Rewrite doc-strings.
34a02f46 2288
1259009a 22892012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2290
2291 * character.c (char_width): New function.
70d4fdf6
GM
2292 (Fchar_width, c_string_width, lisp_string_width):
2293 Use char_width (Bug#9496).
25ed9e61 2294
6a6ee00d
MR
22952012-01-16 Martin Rudalics <rudalics@gmx.at>
2296
2297 * window.c (Vwindow_persistent_parameters): New variable.
2298 (Fset_window_configuration, save_window_save): Handle persistent
2299 window parameters.
2300
c85efaf7
EZ
23012012-01-14 Eli Zaretskii <eliz@gnu.org>
2302
2303 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2304 thrashing the stack of the thread. (Bug#9087)
2305
5944709e
PE
23062012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2307
2308 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2309
e71f5d99
EZ
23102012-01-11 Eli Zaretskii <eliz@gnu.org>
2311
2312 * xdisp.c (rows_from_pos_range): Handle the case where the
2313 highlight ends on a newline. (Bug#10464)
2314 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2315 he end column for display of highlight that ends on a newline
2316 before a R2L line.
2317
ce316182
GM
23182012-01-11 Glenn Morris <rgm@gnu.org>
2319
2320 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2321 from load-path also when installation-directory is nil. (Bug#10208)
2322
5b43da69
GM
23232012-01-10 Glenn Morris <rgm@gnu.org>
2324
74cc8ff9
GM
2325 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2326
7d8d6e4e
GM
2327 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2328 Update template values to be closer to their typical values these days.
5b43da69 2329
a0db8d43
EZ
23302012-01-09 Eli Zaretskii <eliz@gnu.org>
2331
2332 * xdisp.c (rows_from_pos_range): Accept additional argument
2333 DISP_STRING, and accept any glyph in a row whose object is that
2334 string as eligible for mouse highlight. Fixes mouse highlight of
2335 display strings from overlays. (Bug#10464)
2336
9a0115ab 23372012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2338
b9110d6a 2339 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2340 * fileio.c (auto_saving_dir_umask): New static var.
2341 (Fmake_directory_internal): Use it.
2342 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2343 creating the directory. The old code temporarily assigns
2344 too-generous permissions to the directory.
2345 (do_auto_save_eh): Clear it.
b9110d6a 2346 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2347 that the var is always cleared.
2348
6c1bd3f3
EZ
23492012-01-07 Eli Zaretskii <eliz@gnu.org>
2350
2351 * search.c (scan_buffer): Pass character positions to
2352 know_region_cache, not byte positions. (Bug#6540)
2353
069d2b50
L
23542012-01-07 LynX <_LynX@bk.ru> (tiny change)
2355
2356 * w32.c (sys_rename): Report EXDEV when rename of a directory
2357 fails because the target is on another logical disk. (Bug#10284)
2358
75bf0d33
DB
23592012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2360
2361 * xterm.c (x_embed_request_focus): New function.
2362
2363 * xterm.h: Add prototype.
2364
2365 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2366
1c6e5a32
GM
23672012-01-05 Glenn Morris <rgm@gnu.org>
2368
2369 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2370
651e947e
EZ
23712012-01-01 Eli Zaretskii <eliz@gnu.org>
2372
2373 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2374 Load gnutls_transport_set_lowat only if GnuTLS version is below
2375 2.11.1.
2376 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2377 GnuTLS versions below 2.11.1.
2378
3778cdd8
AL
23792011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2380
2381 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2382 to the doc string advising against its use for altering the way
2383 windows are scrolled.
2384
0e5317f7
KH
23852011-12-28 Kenichi Handa <handa@m17n.org>
2386
2387 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2388 coding-system ASCII compatible only when it does not produce BOM
2389 on encoding (Bug#10383).
2390
93d5ca1f
JD
23912011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2392
2393 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2394 can scroll.
2395 (create_and_show_popup_menu): Always use menu_position_func for
2396 Gtk3 (Bug#10361).
2397
ca22b785
AS
23982011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2399
2400 * callint.c (Fcall_interactively): Don't truncate prompt string.
2401
d048e1e6
EZ
24022011-12-23 Eli Zaretskii <eliz@gnu.org>
2403
2404 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2405 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2406 resumed from there (after widening). (Bug#10360)
d048e1e6 2407
5ccaba1f
JD
24082011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2409
2410 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2411
204ee57f
JD
24122011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2413
b81d40f0
JB
2414 * nsterm.m (x_free_frame_resources):
2415 Release f->output_data.ns->miniimage.
204ee57f
JD
2416 (ns_index_color): Fix indentation. Do not retain
2417 color_table->colors[i].
2418
2419 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2420 before returning.
2421
2422 * nsfns.m (x_set_background_color): Assign return value from
2423 ns_index_color to face-background instead of NSColor*.
2424 (ns_implicitly_set_icon_type): Fix indentation.
2425 Change assignment in for loop to comparison.
2426
2427 * emacs.c (ns_pool): New variable.
2428 (main): Assign ns_pool.
2429 (Fkill_emacs): Call ns_release_autorelease_pool.
2430
2431 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2432 autorelease fdesc, release fdAttrs and tdict.
2433 (ns_get_covering_families): Release charset.
2434 (ns_findfonts): Release NSFontDescriptor created with new.
2435 (ns_uni_to_glyphs): Fix indentation.
2436 (setString): Release attrStr before assigning new value.
2437
c803b2b7
JD
24382011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2439
678f4426
JD
2440 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2441 and NS_IMPL_COCOA.
2442 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2443 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2444
cd394be1 24452011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2446
5fecd5fc
JD
2447 * nsterm.m (ns_term_init): Subscribe for notifications
2448 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2449 to method trackingNotification in EmacsMenu.
2450
2451 * nsmenu.m (trackingMenu): New variable.
3771cb17 2452 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2453 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2454 from Aquamacs (Bug#7030).
678f4426
JD
2455
24562011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2457
c803b2b7
JD
2458 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2459 (symbol_to_nsstring): Fix indentation.
2460 (ns_symbol_to_pb): New function.
cae07000
SM
2461 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2462 (Fns_rotate_cut_buffers_internal): Remove.
2463 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2464 Fns_store_cut_buffer_internal.
2465 (ns_get_foreign_selection, Fx_own_selection_internal)
2466 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2467 (Fns_get_selection_internal, Fns_store_selection_internal):
2468 Use ns_symbol_to_pb and check if return value is nil.
2469 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2470 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2471 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2472 renamed to Sns_store_selection_internal.
2473 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2474 and remove this function.
2475 (ns_handle_selection_clear): Remove, never used.
2476 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2477 here.
2478
e1b01a3a
KB
24792011-12-17 Ken Brown <kbrown@cornell.edu>
2480
2481 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2482 GID is unknown (Bug#10257).
2483
2adb6e85
PE
24842011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2485
2486 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2487 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2488 which caused a build failure on GNU/Linux IA-64. This problem was
2489 introduced by my 2011-10-07 patch.
2490
d1d7b339
JL
24912011-12-15 Juri Linkov <juri@jurta.org>
2492
2493 * image.c (imagemagick_error): New function. (Bug#10112)
2494 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2495 Use `imagemagick_error' where ImageMagick functions return
2496 `MagickFalse'.
2497 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2498 proper order.
2499
100d5755
KH
25002011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2501
2502 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2503 fill background (Bug#8992).
2504
454592a6
MR
25052011-12-13 Martin Rudalics <rudalics@gmx.at>
2506
2507 * window.c (Vwindow_combination_resize)
2508 (Vwindow_combination_limit): Use t instead of non-nil in
2509 doc-strings.
61d4b438
MR
2510 (Vrecenter_redisplay): Add first sentence of doc-string on
2511 separate line.
53524d93 2512 (Frecenter): Fix doc-string typo.
454592a6 2513
3633e3aa
KH
25142011-12-11 Kenichi Handa <handa@m17n.org>
2515
2516 * coding.c (Funencodable_char_position): Pay attention to the
2517 buffer text relocation (Bug#9389).
2518
7b9d523a 25192011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2520
7b9d523a
JD
2521 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2522 gtk_init (Bug#10100).
2523
b73189c6
EZ
25242011-12-10 Eli Zaretskii <eliz@gnu.org>
2525
2526 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2527 IT->string is nil. (Bug#10263)
2528
f7dfe5d6
JD
25292011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2530
83faebb4
JD
2531 * nsterm.h (x_free_frame_resources): Declare.
2532
f7dfe5d6
JD
2533 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2534 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2535
2536 * nsterm.h (ns_get_defaults_value): Declare.
2537
2538 * nsterm.m (ns_default): Call ns_get_defaults_value.
2539
7cd4e72c
EZ
25402011-12-09 Eli Zaretskii <eliz@gnu.org>
2541
2542 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2543 (Bug#10170)
2544
b34d7317
YM
25452011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2546
2547 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2548 that where the value of an _OBJC_* symbol points to is in the .bss
2549 section (Bug#10240).
2550
76470ad1
KH
25512011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2552
2553 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2554 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2555
745fff94
KH
25562011-12-08 Kenichi Handa <handa@m17n.org>
2557
2558 * ftfont.c (get_adstyle_property): Fix previous change
2559 (Bug#10233).
2560
6e44397c
JB
25612011-12-07 Juanma Barranquero <lekktu@gmail.com>
2562
2563 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2564 dirs from the default value of EMACSLOADPATH (bug#10208).
2565
7efa6272
GM
25662011-12-07 Glenn Morris <rgm@gnu.org>
2567
2568 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2569 installation and source directories as well. (Bug#10208)
2570
f6fc4d87
CY
25712011-12-06 Chong Yidong <cyd@gnu.org>
2572
2573 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2574
2bf26180
GM
25752011-12-06 Glenn Morris <rgm@gnu.org>
2576
2577 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2578 as an error, not just -1. (Bug#10217)
2579
3a6ad4f0
CY
25802011-12-05 Chong Yidong <cyd@gnu.org>
2581
2582 * keyboard.c (process_special_events): New function.
2583 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2584
75a3b399
PE
25852011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2586
2587 * coding.c (encode_designation_at_bol): Don't use uninitialized
2588 local variable (Bug#9318).
2589
c3c9e25e
KH
25902011-12-05 Kenichi Handa <handa@m17n.org>
2591
2592 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2593 return Qnil (Bug#8046, Bug#10193).
2594
5eb05ea3
KH
25952011-12-05 Kenichi Handa <handa@m17n.org>
2596
2597 * coding.c (encode_designation_at_bol): New args charbuf_end and
2598 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2599 (coding_set_source): Return how many bytes coding->source was
2600 relocated.
2601 (coding_set_destination): Return how many bytes
2602 coding->destination was relocated.
2603 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2604 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2605
26062011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2607
2608 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2609 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2610 macro (Bug#9318).
2611
26122011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2613
2614 The following changes are to fix Bug#9318.
2615
a79703f5 2616 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2617 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2618 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2619 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2620
7dbda6df
JB
26212011-12-05 Juanma Barranquero <lekktu@gmail.com>
2622
2623 * lisp.h (process_quit_flag): Fix external declaration.
2624
6d5eb5b0
SM
26252011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2626
2627 Don't macro-inline non-performance-critical code.
2628 * eval.c (process_quit_flag): New function.
2629 * lisp.h (QUIT): Use it.
2630
a0c3fad0
JD
26312011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2632
2633 * nsfns.m (get_geometry_from_preferences): New function.
2634 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2635
6c07aac2
AS
26362011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2637
2638 * emacs.c (Qkill_emacs): Define.
2639 (syms_of_emacs): Initialize it.
2640 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2641 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2642 (quit_throw_to_read_char): Add parameter `from_signal'.
2643 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2644 * lisp.h (QUIT): Call Fkill_emacs if requested.
2645
c052ead4
JD
26462011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2647
2648 * widget.c (update_wm_hints): Return if wmshell is null.
2649 (widget_update_wm_size_hints): New function.
2650
2651 * widget.h (widget_update_wm_size_hints): Declare.
2652
2653 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2654 widget_update_wm_size_hints (Bug#10104).
2655
9e49252b
EZ
26562011-12-03 Eli Zaretskii <eliz@gnu.org>
2657
2658 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2659 before a newline, prepare the bidi iterator for consuming the
2660 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2661 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2662
02b16839
JL
26632011-12-02 Juri Linkov <juri@jurta.org>
2664
2665 * search.c (Fword_search_regexp): New Lisp function created from
2666 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2667 (Fword_search_backward, Fword_search_forward)
2668 (Fword_search_backward_lax, Fword_search_forward_lax):
2669 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2670 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2671
0068070e
SM
26722011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2673
2674 * fileio.c (Finsert_file_contents): Move after-change-function call
2675 to before the "handled:" label, since all "goto handled" appear in
2676 cases where the *-change-functions have already been properly called
2677 (bug#10117).
2678
3360a3fc
AS
26792011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2680
2681 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2682 waiting for input. (Bug#10169)
2683
73d6c093
EZ
26842011-11-30 Eli Zaretskii <eliz@gnu.org>
2685
2686 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2687 verifies glyph row's hash code--we have just reallocated the
2688 glyphs, so their contents can be complete garbage. (Bug#10164)
2689
febe6bea
JB
26902011-11-30 Juanma Barranquero <lekktu@gmail.com>
2691
2692 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2693
801a4313
EZ
26942011-11-30 Eli Zaretskii <eliz@gnu.org>
2695
2696 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2697 attributes are tested _before_ calling verify_row_hash, to protect
2698 against GCC re-ordering of the tests. (Bug#10164)
2699
2b56b87e
JD
27002011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2701
2702 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2703
2704 * xterm.c (handle_one_xevent): Only set async_visible and friends
2705 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2706 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2707 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2708
dbf31225
PE
27092011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2710
2711 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2712 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2713 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2714 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2715 All uses changed to use GCPRO1 etc.
2716 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2717 Revert to old implementation (i.e., before 2011-03-11).
2718
1305621b
YM
27192011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2720
2721 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2722 of scroll runs so as to avoid assigning disabled bogus rows and
2723 unnecessary graphics copy operations.
2724
8c9afb46
EZ
27252011-11-27 Eli Zaretskii <eliz@gnu.org>
2726
2727 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2728 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2729 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2730 (malloc, free, realloc, calloc): Redirect to e_* only when
2731 compiling Emacs.
2732
2733 * lisp.h (GCTYPEBITS): Move before first use.
2734 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2735 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2736 this macro definition.
2737
2738 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2739 _MSC_VER.
2740
54e9e3bf
JD
27412011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2742
6d5eb5b0
SM
2743 * gtkutil.c (xg_create_frame_widgets):
2744 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2745 present with Gtk+ 2.0.
2746
83aca1cb
PE
27472011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2748
2749 * fileio.c (Finsert_file_contents): Undo previous change; see
2750 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2751
5b76caa4
PE
27522011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2753
2754 Rename locals to avoid shadowing.
2755 * fileio.c (Finsert_file_contents):
2756 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2757 * process.c (wait_reading_process_output):
2758 Rename inner 'proc' to 'p' to avoid shadowing.
2759 Indent for consistency with usual Emacs style.
2760
8c535114
EZ
27612011-11-25 Eli Zaretskii <eliz@gnu.org>
2762
2763 * xdisp.c (redisplay_window): If cursor row is not fully visible
2764 after recentering, and scroll-conservatively is set to a large
2765 number, scroll window by a few more lines to make the cursor fully
2766 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
2767 (start_display): Don't move to the next line if the display should
2768 start at a newline that is part of a display vector or an overlay
2769 string. (Bug#10119)
8c535114 2770
fa4fdb5c
JL
27712011-11-24 Juri Linkov <juri@jurta.org>
2772
2773 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2774 after the `MagickPingImage' call. (Bug#10112)
2775
90ec88df
CY
27762011-11-23 Chong Yidong <cyd@gnu.org>
2777
2778 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2779
56e2e794
MR
27802011-11-23 Martin Rudalics <rudalics@gmx.at>
2781
2782 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2783 making another buffer current. (Bug#10114)
2784
b6e64c41
GM
27852011-11-23 Glenn Morris <rgm@gnu.org>
2786
2787 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2788
6b21de18
CY
27892011-11-23 Chong Yidong <cyd@gnu.org>
2790
2791 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2792 using it (Bug#5984).
2793
b12cd789
EZ
27942011-11-22 Eli Zaretskii <eliz@gnu.org>
2795
2796 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2797 and header-lines, as they don't have one computed for them.
2798 (Bug#10098)
2799
2800 * .gdbinit (prow): Make displayed values more self-explaining.
2801 Add row's hash code.
2802
261b6fd4
LMI
28032011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2804
2805 * process.c (wait_reading_process_output): Fix asynchrounous
2806 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 2807 (wait_reading_process_output): Add comment and URL.
261b6fd4 2808
e7cfd277
JD
28092011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2810
2811 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2812
a9b9b7f5
CY
28132011-11-21 Chong Yidong <cyd@gnu.org>
2814
2815 * window.c (Fnext_window, Fprevious_window): Doc fix.
2816
b0d15b4f
SM
28172011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2818
2819 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2820
fe7a3057
JB
28212011-11-20 Juanma Barranquero <lekktu@gmail.com>
2822
2823 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2824
d2999b1a
MR
28252011-11-20 Martin Rudalics <rudalics@gmx.at>
2826
2827 * window.c (Fset_window_combination_limit): Rename argument
2828 STATUS to LIMIT.
2829 (Vwindow_combination_limit): Remove "status" from doc-string.
2830
d5ff9cd0
AS
28312011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2832
2833 * m/ibms390.h: Remove.
2834 * m/ibms390x.h: Don't include "ibms390.h".
2835
a5bb9bd3
SM
28362011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2837
2838 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2839 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2840
cd1181db
JB
28412011-11-20 Juanma Barranquero <lekktu@gmail.com>
2842
2843 * casetab.c (Fset_case_table):
2844 * charset.c (Fcharset_after): Fix typos.
2845
615a3b8d 28462011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 2847
17e845af
PE
2848 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2849 Otherwise, valgrind does not work on some platforms.
2850 Problem reported by Andreas Schwab in
6a0bf43d
PE
2851 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2852 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2853 is set, removing the need for VIRT_ADDRESS_VARIES.
2854 (PURE_P): Use a more-efficient implementation that needs just one
2855 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2856 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2857 to 4 (xorl, subq, cmpq, setbe).
2858 * alloc.c (pure): Always extern now, since that's the
2859 VIRT_ADDR_VARIES behavior.
2860 (PURE_POINTER_P): Use a single comparison, not two, for
2861 consistency with the new puresize.h.
2862 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2863 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2864 Remove VIRT_ADDR_VARIES no longer needed.
2865
f8fe6f96
EZ
28662011-11-19 Eli Zaretskii <eliz@gnu.org>
2867
2868 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2869 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2870 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2871 behave as if the cursor position were at the window margin.
2872
2873 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2874 and the cursor position is out of bounds, behave as if the cursor
2875 position were at the window margin. (Bug#10075)
2876
df05a53c
CY
28772011-11-18 Chong Yidong <cyd@gnu.org>
2878
2879 * window.c (Fwindow_combination_limit): Make first argument
2880 non-optional, since it is meaningless for live windows like the
2881 selected window.
61ccba97 2882
2071918e
DA
28832011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2884
2885 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2886
b50a28de
SM
28872011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2888
2889 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2890 (graft_intervals_into_buffer): Simplify.
2891
015137db
EZ
28922011-11-18 Eli Zaretskii <eliz@gnu.org>
2893
2894 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2895 hash values of the two rows.
2896 (copy_row_except_pointers): Preserve the used[] arrays and the
2897 hash values of the two rows. (Bug#10035)
68c95424 2898 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
2899
2900 * xdisp.c (row_hash): New function, body extracted from
2901 compute_line_metrics.
2902 (compute_line_metrics): Call row_hash, instead of computing the
2903 hash code inline.
2904
2905 * dispnew.c (verify_row_hash): Call row_hash for computing the
2906 hash code of a row, instead of duplicating code from xdisp.c.
2907
2908 * dispextern.h (row_hash): Add prototype.
2909
a2addb04
TH
29102011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2911
2912 * frame.c (delete_frame): Don't delete the terminal when the last
2913 X frame is closed if emacs is built with GTK toolkit.
2914
df85d315
JB
29152011-11-17 Juanma Barranquero <lekktu@gmail.com>
2916
2917 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2918
a0c2d0ae
MR
29192011-11-17 Martin Rudalics <rudalics@gmx.at>
2920
2921 * window.c (Vwindow_splits): Rename to
2922 Vwindow_combination_resize. Suggested by Juri Linkov.
2923 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2924 of Vwindow_splits.
2925
58179cce
JB
29262011-11-16 Juanma Barranquero <lekktu@gmail.com>
2927
7877f373
JB
2928 * nsfns.m (Fns_font_name):
2929 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 2930
b6f67890
MR
29312011-11-16 Martin Rudalics <rudalics@gmx.at>
2932
2933 * window.h (window): Rename slot "nest" to "combination_limit".
2934 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2935 (Fset_window_nest): Rename to Fset_window_combination_limit.
2936 (Vwindow_nest): Rename to Vwindow_combination_limit.
2937 (recombine_windows, make_parent_window, make_window)
2938 (Fsplit_window_internal, saved_window)
2939 (Fset_window_configuration, save_window_save): Rename all
2940 occurrences of window_nest to window_combination_limit.
2941
c7015153
JB
29422011-11-15 Juanma Barranquero <lekktu@gmail.com>
2943
2944 * image.c (imagemagick_load_image): Fix typo.
2945
322ad6ec
EZ
29462011-11-14 Eli Zaretskii <eliz@gnu.org>
2947
2948 * xdisp.c (display_line): Move the call to
2949 highlight_trailing_whitespace before the call to
2950 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
2951 faces of all the glyphs to compute ROW's hash value.
2952 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 2953
f067b8ec
JB
29542011-11-14 Juanma Barranquero <lekktu@gmail.com>
2955
2956 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2957 just return (bug#10044).
2958
1e5b2111
EZ
29592011-11-12 Eli Zaretskii <eliz@gnu.org>
2960
7ef3cbd5
EZ
2961 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2962 with user-defined heap size. Bump the default size of the temacs
2963 heap to 27MB, to avoid memory warning when running temacs.
2964 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2965
1e5b2111
EZ
2966 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2967 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
2968 (verify_row_hash) [XASSERTS]: New function.
2969 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2970 that the hash value of glyph rows is correct.
1e5b2111 2971
89d61221
MR
29722011-11-12 Martin Rudalics <rudalics@gmx.at>
2973
2974 * window.h (window): Remove splits slot.
2975 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2976 (Fdelete_other_windows_internal, make_parent_window)
2977 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2978 (Fset_window_configuration, save_window_save): Don't deal with
2979 split status of windows.
2980 (saved_window): Remove splits slot.
2981 (Vwindow_splits): Rewrite doc-string.
2982
97f18cc8
JD
29832011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2984
2985 * xfns.c (unwind_create_frame):
2986 * nsfns.m (unwind_create_frame):
2987 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2988 Vframe_list (Bug#9999).
2989
22a648b4
DA
29902011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2991
0b381c7e 2992 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 2993
659afede
KH
29942011-11-11 Kenichi Handa <handa@m17n.org>
2995
2996 * callproc.c (Fcall_process): Set the member dst_multibyte of
2997 process_coding.
2998
9ac0394b
KH
29992011-11-11 Johan Bockgård <bojohan@gnu.org>
3000
3001 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3002 avoid a crash (bug#9496).
3003
2fbdc249
CY
30042011-11-09 Chong Yidong <cyd@gnu.org>
3005
3006 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3007 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3008
ac6b1f81
PE
30092011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3010
3011 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3012
09db192c
PE
30132011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3014
3015 Avoid some portability problems by eschewing 'extern inline' functions.
3016 The trivial performance wins aren't worth the portability hassles; see
3017 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3018 et seq.
3019 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3020 (window_box_width, window_box_left, window_box_left_offset)
3021 (window_box_right, window_box_right_offset): Undo previous change,
3022 by removing the "extern"s.
3023 * intervals.c (adjust_intervals_for_insertion)
3024 (adjust_intervals_for_deletion): Undo previous change,
3025 making these static again.
3026 (offset_intervals, temp_set_point_both, temp_set_point)
3027 (copy_intervals_to_string): No longer inline.
3028 * xdisp.c (window_text_bottom_y, window_box_width)
3029 (window_box_height, window_box_left_offset)
3030 (window_box_right_offset, window_box_left, window_box_right)
3031 (window_box): No longer inline.
3032
105216ed
CY
30332011-11-08 Chong Yidong <cyd@gnu.org>
3034
3035 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3036 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3037 Signal an error if not a live window.
105216ed
CY
3038 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3039 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3040
ae9e237f
JB
30412011-11-07 Juanma Barranquero <lekktu@gmail.com>
3042
3043 * lisp.h (syms_of_abbrev): Remove declaration.
3044 Reported by CHENG Gao <chenggao@royau.me>.
3045
c7aa8333
EZ
30462011-11-07 Eli Zaretskii <eliz@gnu.org>
3047
3048 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3049 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3050 of temacs in GUI mode.
3051
be7f5545
MR
30522011-11-07 Martin Rudalics <rudalics@gmx.at>
3053
3054 * window.h: Declare delete_all_child_windows instead of
3055 delete_all_subwindows.
3056 * window.c (Fwindow_nest, Fset_window_nest)
3057 (Fset_window_new_total, Fset_window_new_normal)
3058 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3059 (delete_all_subwindows): Rename to delete_all_child_windows.
3060 (Fdelete_other_windows_internal, Fset_window_configuration):
3061 Call delete_all_child_windows instead of delete_all_subwindows.
3062 * frame.c (delete_frame): Call delete_all_child_windows instead
3063 of delete_all_subwindows.
3064
ca78dc43
PE
30652011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3066
3067 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3068 This is also needed for porting to any host where GC_MARK_STACK is
3069 not GC_MAKE_GCPROS_NOOPS.
3070 (which_symbols): Use it.
3071
a0241d01
KH
30722011-11-07 Kenichi Handa <handa@m17n.org>
3073
3074 * coding.c (coding_set_destination): Check coding->src_pos only
3075 when coding->src_object is a buffer (bug#9910).
3076
3077 * process.c (send_process): Set the member src_multibyte of coding
3078 to 0 (bug#9911) when sending a unibyte text.
3079
3080 * callproc.c (Fcall_process): Set the member src_multibyte of
3081 process_coding to 0 (bug#9912).
3082
a64bfdfa 30832011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3084
3085 * xmenu.c (cleanup_widget_value_tree): New function.
3086 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3087 calling free_menubar_widget_value_tree directly (Bug#9830).
3088
cb41b32a
PE
30892011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3090
3091 Fix some portability problems with 'inline'.
3092 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3093 (window_box_width, window_box_left, window_box_left_offset)
3094 (window_box_right, window_box_right_offset): Declare extern.
3095 Otherwise, these inline functions do not conform to C99 and
3096 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3097 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3098 * intervals.c (adjust_intervals_for_insertion)
3099 (adjust_intervals_for_deletion): Now extern, because otherwise the
3100 extern inline functions 'offset_intervals' couldn't refer to it.
3101 (static_offset_intervals): Remove.
3102 (offset_intervals): Rewrite using the old contents of
3103 static_offset_intervals. The old version didn't conform to C99
3104 because an extern inline function contained a reference to an
3105 identifier with static linkage.
3106
b7041366
AS
31072011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3108
3109 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3110 GC.
3111
88a37c4d
EZ
31122011-11-06 Eli Zaretskii <eliz@gnu.org>
3113
3114 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3115 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3116 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3117 return Qleft_to_right.
3118
49745b39
CY
31192011-11-06 Chong Yidong <cyd@gnu.org>
3120
3121 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3122 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3123 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3124 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3125 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3126 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3127 (Fwindow_vscroll): Doc fix.
3128 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3129 argument, since it makes no sense to pass a live window and for
3130 consistency with window-child.
3131
1f05cd82
CS
31322011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3133
3134 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3135 support MSVC.
3136
22610910
JR
31372011-11-05 Jason Rumney <jasonr@gnu.org>
3138
3139 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3140 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3141 fonts (Bug#6029).
3142 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3143 bitwise arithmetic preventing use of unicode-sip and non-truetype
3144 opentype fonts.
3145
a06776b2
EZ
31462011-11-05 Eli Zaretskii <eliz@gnu.org>
3147
3ad924ba
EZ
3148 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3149 "emacs"-only part.
3150
a06776b2
EZ
3151 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3152 initialization code to keep similarity to xfns.c after changes
3153 from 2011-11-05.
3154
c9e7db78
JD
31552011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3156
a97f8f3f
JD
3157 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3158 (unwind_create_frame): New function (Bug#9943).
3159 (Fx_create_frame): Restructure code to be more similar to the one in
3160 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3161 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3162 Move terminal->reference_count++ just before making the frame official
3163 (Bug#9943).
3164
3165 * nsterm.m (x_free_frame_resources): New function.
3166 (x_destroy_window): Move code to x_free_frame_resources.
3167
c9e7db78 3168 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3169 (Fx_create_frame, x_create_tip_frame):
3170 Move terminal->reference_count++ just before making the frame
75f1671a 3171 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3172 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3173
a6fc3b5c
EZ
31742011-11-05 Eli Zaretskii <eliz@gnu.org>
3175
3176 Support MSVC build with newer versions of Visual Studio.
3177 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3178 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3179 nt/gmake.defs.
3180
3181 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3182 which are not supported by MSVC.
3183 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3184 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3185 bitfields.
3186 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3187 types in bitfields.
3188 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3189
3190 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3191
58179cce 31922011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3193
3194 Support MSVC build with newer versions of Visual Studio.
3195 * w32.c: Don't include w32api.h for MSVC.
3196 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3197
3198 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3199 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3200 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3201 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3202 e_* cousins.
3203 (alloca) [_MSC_VER]: Define to _alloca.
3204
3205 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3206
3207 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3208
a58c13ed
EZ
32092011-11-04 Eli Zaretskii <eliz@gnu.org>
3210
3211 * xdisp.c (note_mouse_highlight): If either of
3212 previous/next-single-property-change returns nil, treat that as
3213 the beginning or the end of the buffer. (Bug#9955)
3214
fe0b6370
JD
32152011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3216
a58c13ed 3217 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3218 label is not null (Bug#9951).
3219 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3220 may be NULL.
3221
89bd5ee1
EZ
32222011-11-04 Eli Zaretskii <eliz@gnu.org>
3223
3224 * window.c (Fwindow_body_size): Mention in the doc string that the
3225 return value is in frame's canonical units. (Bug#9949)
3226
84c3edb9
EZ
32272011-11-03 Eli Zaretskii <eliz@gnu.org>
3228
4e2fb5c7
EZ
3229 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3230
84c3edb9 3231 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3232 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3233 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3234
bc17a887
EZ
32352011-11-01 Eli Zaretskii <eliz@gnu.org>
3236
3237 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3238 Don't stop backward scan on the continuation glyph, even though
3239 its CHARPOS is positive.
6d5eb5b0
SM
3240 (mouse_face_from_buffer_pos, note_mouse_highlight):
3241 Rename cover_string to disp_string.
bc17a887 3242
4ee88440
MR
32432011-11-01 Martin Rudalics <rudalics@gmx.at>
3244
3245 * window.c (temp_output_buffer_show): Don't use
3246 Vtemp_buffer_show_specifiers.
3247 (Vtemp_buffer_show_specifiers): Remove unused variable.
3248
c2ff3c02
EZ
32492011-10-30 Eli Zaretskii <eliz@gnu.org>
3250
3251 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3252 past the beginning of the current glyph matrix.
3253
58179cce 32542011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3255
3256 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3257 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3258 HAVE_GTK3 (Bug#9869).
b77a6a7f 3259
3b574623
JD
3260 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3261 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3262
b77a6a7f
JD
3263 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3264
3265 * xterm.c: Declare x_handle_net_wm_state to return int.
3266 (handle_one_xevent): Check if we are iconified but don't have
3267 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3268 (get_current_wm_state): Return non-zero if not hidden,
3269 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3270 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3271 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3272 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3273
196e41e4
PE
32742011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3275
3276 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3277 so that this new function doesn't get optimized away by a
3278 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3279
021f2e1a
AS
32802011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3281
3282 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3283
8b058d44
EZ
32842011-10-29 Eli Zaretskii <eliz@gnu.org>
3285
3286 Fix the `xbytecode' command.
3287 * .gdbinit (xprintbytestr): New command.
b50a28de 3288 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3289 (xbytecode): Print the byte-code string as well.
3290
4452fb80
EZ
32912011-10-29 Kim Storm <storm@cua.dk>
3292
8b058d44
EZ
3293 * alloc.c (which_symbols): New function.
3294
21b72067
AS
32952011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3296
3297 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3298 line. (Bug#9903)
3299
83ed7b5c
GM
33002011-10-29 Glenn Morris <rgm@gnu.org>
3301
3302 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3303 Not clear what it was for, and it causes various bugs. (Bug#9839)
3304
5a7a728b
EZ
33052011-10-28 Eli Zaretskii <eliz@gnu.org>
3306
3307 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3308 possible random value that matches one of those tested as
3309 condition to clear the mouse face.
3310
d3d0842f
CY
33112011-10-28 Chong Yidong <cyd@gnu.org>
3312
3313 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3314
31b39d13
DN
33152011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3316
3317 * window.c (make_window): Initialize phys_cursor_on_p.
3318
9aba6043
SM
33192011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3320
3321 * lisp.h (struct Lisp_Symbol): Update comments.
3322
c20992f4
JB
33232011-10-28 Juanma Barranquero <lekktu@gmail.com>
3324
3325 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3326
db4f02f2
EZ
33272011-10-28 Eli Zaretskii <eliz@gnu.org>
3328
3329 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3330 <oslsachem@gmail.com> for helping to debug this.
3331
3332 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3333 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3334 (g_b_init_get_glyph_outline_w): New static variables.
3335 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3336 (GetGlyphOutlineW_Proc): New typedefs.
3337 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3338 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3339 New functions.
3340 (w32font_open_internal, compute_metrics):
3341 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3342 instead of calling the "wide" APIs directly.
3343
3344 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3345
3346 * w32.h (syms_of_w32font): Add prototype.
3347
87e68db4
JB
33482011-10-27 Juanma Barranquero <lekktu@gmail.com>
3349
3350 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3351 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3352 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3353 (Fmove_to_window_line): Doc fix.
3354
435c1d67
CY
33552011-10-27 Chong Yidong <cyd@gnu.org>
3356
3357 * process.c (make_process): Set gnutls_state to NULL.
3358
3359 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3360 non-NULL, regardless of GNUTLS_INITSTAGE.
3361 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3362 an error. Set process slots as soon as we allocate them.
3363
3364 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3365
9c6c6f49
CY
33662011-10-27 Chong Yidong <cyd@gnu.org>
3367
9aba6043
SM
3368 * gnutls.c (emacs_gnutls_deinit): New function.
3369 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3370 (Fgnutls_deinit, Fgnutls_boot): Use it.
3371
3372 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3373 (deactivate_process): Call emacs_gnutls_deinit.
3374
657d08d3
JB
33752011-10-27 Juanma Barranquero <lekktu@gmail.com>
3376
3377 * image.c (x_create_x_image_and_pixmap):
3378 * w32.c (sys_rename, w32_delayed_load):
3379 * w32font.c (fill_in_logfont):
3380 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3381
5430d399
JB
33822011-10-26 Juanma Barranquero <lekktu@gmail.com>
3383
3384 * w32fns.c (w32_default_color_map): New function,
3385 extracted from Fw32_default_color_map.
a7ef684b 3386 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3387
fe0055fa
PE
33882011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3389
3390 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3391
e6346438
SM
33922011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3393
3394 * keyboard.c (test_undefined): New function (bug#9751).
3395 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3396
e112cc37
ET
33972011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3398
3399 * sysdep.c (init_sys_modes): Fix the check for the controlling
3400 terminal (Bug#6649).
3401
7b5d6677
EZ
34022011-10-20 Eli Zaretskii <eliz@gnu.org>
3403
3404 * dispextern.h (struct bidi_it): New member next_en_type.
3405
3406 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3407 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3408 current character, check also for next_en_type being WEAK_EN.
3409 (bidi_resolve_weak): Don't enter the expensive loop if the current
3410 position is before next_en_pos. Record the bidi type of the first
3411 non-ET, non-BN character we find, in addition to its position.
3412 (bidi_level_of_next_char): Invalidate next_en_type when
3413 next_en_pos is over-stepped.
3414
7da0b018
PE
34152011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3416
3417 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3418 * editfns.c: Rewrite current-time-zone so that it invokes
3419 the equivalent of (format-time-string "%Z") to get the time zone name.
3420 This fixes a bug when the time zone name contains characters that
3421 need converting from the system time locale to Emacs internal format.
3422 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3423 that patch fixed format-time-string to do the conversion, but
3424 I forgot to fix current-time-zone.
3425 (format_time_string): New function, containing most of
3426 what Fformat_time_string used to contain.
3427 (Fformat_time_string): Rewrite in terms of format_time_string.
3428 This doesn't change this function's behavior.
3429 (current-time-zone): Rewrite to use format_time_string.
3430 This fixes the bug reported by Michael Schierl in
3431 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3432 Jason Rumney's 2007-06-07 change worked around this bug, but
3433 didn't fix it.
3434 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3435
8547b010
EZ
34362011-10-19 Eli Zaretskii <eliz@gnu.org>
3437
3438 * xdisp.c (start_display): If the character at POS is displayed
3439 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3440 (try_window_reusing_current_matrix): If a line ends in a display
3441 vector or the next line starts in a display vector, continue
3442 redrawing the window even though the character position of
3443 start_row was reached.
8547b010
EZ
3444 (Bug#9771, part 2)
3445
4e948d15
CY
34462011-10-18 Chong Yidong <cyd@gnu.org>
3447
3448 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3449 with nobreak-char-display too.
3450
4787455f
EZ
34512011-10-18 Eli Zaretskii <eliz@gnu.org>
3452
3453 Fix part 3 of bug#9771.
3454 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3455 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3456 non-neutral characters if the current character is a paragraph
3457 separator (a.k.a. Newline). This avoids running the same
3458 expensive loop twice, once when we consume the preceding newline
3459 and the other time when the line actually needs to be displayed.
3460 Avoid the loop when we see neutrals on the base embedding level
3461 following a character whose directionality is the same as the
3462 paragraph's. This avoids running the expensive loop when a line
3463 ends in a long sequence of neutrals, like control characters.
3464 Add assertion against STRONG_AL type. Slightly rearrange code
3465 that determines the type of a neutral given the first non-neutral
3466 that follows it.
3467 (bidi_level_of_next_char): Set next_en_pos to zero when
3468 invalidating its info.
3469
2c91f553
EZ
34702011-10-17 Eli Zaretskii <eliz@gnu.org>
3471
3472 * xdisp.c (push_display_prop): Determine whether to record string
3473 or buffer position by IT->string, not by IT->method. Allow
3474 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3475 (move_it_vertically_backward): Don't look for character position
3476 immediately after the newline when in a continuation line.
3477 (Bug#9771, part 1)
2c91f553 3478
c7b08b0d
MR
34792011-10-15 Martin Rudalics <rudalics@gmx.at>
3480
3481 * window.c (coordinates_in_window): Rewrite and delabelize
3482 vertical border check. (Bug#5357) (Bug#9618)
3483
6b02f655
SM
34842011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3485
3486 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3487 errors in XSetWindowBorder (bug#9310).
3488
81d40c92
DA
34892011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3490
3491 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3492 avoid crash when xmalloc overrun checking is enabled.
3493
d4172c3b
EZ
34942011-10-13 Eli Zaretskii <eliz@gnu.org>
3495
3496 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3497 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3498 cursor motion with <left> and <right> arrow keys.
3499
3500 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3501 some callers set that themselves.
3502
b00eea75
EZ
35032011-10-12 Eli Zaretskii <eliz@gnu.org>
3504
3505 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3506 display string and the previous row comes from the same string and
3507 is empty. (Bug#9739) (Bug#9738)
3508
8fe012c4
SM
35092011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3510
3511 * doc.c (get_doc_string): Encode file name (bug#9735).
3512
0074aef2
EZ
35132011-10-12 Eli Zaretskii <eliz@gnu.org>
3514
79beb178
EZ
3515 * bidi.c (bidi_level_of_next_char):
3516 * xdisp.c (get_visually_first_element): Remove old incorrect
3517 comments regarding the Unicode Line Separator character.
3518
0074aef2
EZ
3519 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3520
6e4b3fbe
DA
35212011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3522
3523 * alloc.c (Fgc_status): Do not access beyond zombies array
3524 boundary if nzombies > MAX_ZOMBIES.
3525 * alloc.c (dump_zombies): Add missing format specifier.
3526
0324f3af
PE
35272011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3528
b5525cac
PE
3529 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3530 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3531
0324f3af
PE
3532 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3533 Some packages use them to denote characters with modifiers.
3534
e9b5f888
AS
35352011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3536
3537 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3538 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3539 matching a pp-number. Rename parameter var to var1.
3540
127827c0
SM
35412011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3542
3543 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3544
c8fd3bd0
GM
35452011-10-08 Glenn Morris <rgm@gnu.org>
3546
3547 * callint.c (Fcall_interactively): Give a more explicit error for the
3548 'c' case with a non-character input. (Bug#8479)
3549
352ec8ff
EZ
35502011-10-08 Eli Zaretskii <eliz@gnu.org>
3551
03669ccb
EZ
3552 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3553 lines.
7061c986
EZ
3554 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3555 lines that are hscrolled on the left.
03669ccb 3556
352ec8ff
EZ
3557 * dispnew.c (buffer_posn_from_coords): Account for a possible
3558 presence of header-line. (Bug#4426)
3559
a66cfb1c
SM
35602011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3561
6b02f655
SM
3562 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3563 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3564
7c5ee88e
PE
35652011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3566
3567 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3568 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3569 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3570 this makes Emacs dump core during garbage collection on rare
3571 occasions. sizeof is obviously inferior to offsetof here, so
3572 stick with offsetof.
3573 (GC_POINTER_ALIGNMENT): New macro.
3574 (mark_memory): Omit 3rd (offset) arg; caller changed.
3575 Don't assume EMACS_INT alignment is the same as pointer alignment.
3576
df1bbe5b
SM
35772011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3578
3579 * keyboard.c (read_key_sequence_remapped): New var.
3580 (read_key_sequence): Compute remapping in the right buffer.
3581 (command_loop_1): Use read_key_sequence's remapping directly.
3582
51553db6
SM
35832011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3584
32c1fffd
SM
3585 * dired.c (file_name_completion): Don't expand file name.
3586 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3587 before checking file name handler.
3588
51553db6
SM
3589 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3590 they've been requested explicitly (bug#9591).
3591
b6bd1599 35922011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3593
3594 * keymap.c (Fsingle_key_description): Use make_specified_string
3595 instead of build_string to build string from push_key_description.
3596 (Bug#5193)
3597
f701dc2a
PE
35982011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3599
4222c55d
PE
3600 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3601 This fixes a Y2038 bug on 64-bit hosts.
3602 * buffer.c (reset_buffer):
3603 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3604 (Fclear_buffer_auto_save_failure):
3605 Use 0, not -1, to represent an unset failure time, since time_t
3606 might not be signed.
3607
f701dc2a
PE
3608 Remove dependency on glibc malloc internals.
3609 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3610 Move back here from lisp.h, but with their new implementations.
3611 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3612 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3613 * charset.c (charset_table_init): New static var.
3614 (syms_of_charset): Use it instead of xmalloc. This removes a
3615 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3616 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3617 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3618 Move back to alloc.c.
3619 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3620 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3621
9ceebf39
JD
36222011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3623
3624 * nsterm.m (windowDidResize): Call x_set_window_size only when
3625 ns_in_resize is true. Otherwise set pixelwidth/height and
3626 call change_frame_size (Bug#9628).
3627
cb993c58
PE
36282011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3629
3930c88b
PE
3630 Port --enable-checking=all to Fedora 14 x86-64.
3631 * charset.c (syms_of_charset): Also account for glibc malloc's
3632 internal overhead when calculating the initial malloc maximum.
3633
cb993c58
PE
3634 Port --enable-checking=all to Fedora 14 x86.
3635 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3636 Move to lisp.h.
3637 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3638 (overrun_check_realloc, overrun_check_free):
3639 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3640 That way, xmalloc returns a properly-aligned pointer even if
3641 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3642 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3643 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3644 into account when calculating the initial malloc maximum.
3645 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3646 Move here from alloc.c, so that charset.c can use it too.
3647 Properly align; the old code wasn't right for common 32-bit hosts
3648 when configured with --enable-checking=all.
3649 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3650 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3651
31bed486
EZ
36522011-09-29 Eli Zaretskii <eliz@gnu.org>
3653
04c70788 3654 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3655 use EDOM.
3656
fbcaa2f3
EZ
36572011-09-28 Eli Zaretskii <eliz@gnu.org>
3658
3659 * xdisp.c (compute_display_string_end): If there's no display
3660 string at CHARPOS, return -1.
3661
3662 * bidi.c (bidi_fetch_char): When compute_display_string_end
3663 returns a negative value, treat the character as a normal
3664 character not covered by a display string. (Bug#9624)
3665
a239d4e9
JB
36662011-09-28 Juanma Barranquero <lekktu@gmail.com>
3667
3668 * lread.c (Fread_from_string): Fix typo in docstring.
3669
88652fd5
EZ
36702011-09-27 Eli Zaretskii <eliz@gnu.org>
3671
3672 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3673 newline, reseat the iterator instead of bidi-iterating there one
3674 character at a time. (Bug#9610)
32c1fffd
SM
3675 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3676 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3677
ed497dd4
AS
36782011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3679
3680 * lread.c (readevalloop): Use correct code for NBSP.
3681 (read1): Likewise. (Bug#9608)
3682
b2bf61aa
MA
36832011-09-25 Michael Albinus <michael.albinus@gmx.de>
3684
3685 * dbusbind.c (Fdbus_register_signal): When service is not
3686 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3687
32bbb17c
GM
36882011-09-25 Glenn Morris <rgm@gnu.org>
3689
3690 * buffer.c (truncate-lines): Doc fix.
3691
94e0933e
CY
36922011-09-24 Chong Yidong <cyd@stupidchicken.com>
3693
3694 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3695 (Fset_window_next_buffers): Doc fix.
3696
cddde921
GM
36972011-09-24 Glenn Morris <rgm@gnu.org>
3698
3699 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3700
1260aef1
PE
37012011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3702
25b4bfa0
PE
3703 Fix minor problems found by static checking.
3704 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3705 * indent.c (Fvertical_motion): Fix == vs = typo.
3706
e3cbd34b
EZ
37072011-09-24 Eli Zaretskii <eliz@gnu.org>
3708
a66cfb1c
SM
3709 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3710 Default value is now t. Doc fix.
6bf7006f 3711
e3cbd34b 3712 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3713 logic when moving up, not only when moving down. Fix the
e3cbd34b 3714 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3715 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3716
3717 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3718 CHARPOS is covered by a display string which includes newlines.
3719 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3720 is covered by a display string with embedded newlines.
3721
a3de0cbd
MA
37222011-09-24 Michael Albinus <michael.albinus@gmx.de>
3723
3724 * dbusbind.c (Fdbus_register_signal): Add match rule to
3725 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3726 (Fdbus_register_method, Vdbus_registered_objects_table):
3727 Fix docstring.
a3de0cbd 3728
b260039d
JM
37292011-09-24 Jim Meyering <meyering@redhat.com>
3730
32c1fffd 3731 do not ignore write error for any output size
b260039d
JM
3732 The previous change was incomplete.
3733 While it makes emacs --batch detect the vast majority of stdout
3734 write failures, errors were still ignored whenever the output size is
3735 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3736 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3737 && echo FAIL: ignored write error
3738 FAIL: ignored write error
3739 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3740 && echo FAIL: ignored write error
3741 FAIL: ignored write error
3742 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3743
8eca8a7c
AS
37442011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3745
3746 * emacs.c (Fkill_emacs): In noninteractive mode exit
3747 non-successfully if a write error occurred on stdout. (Bug#9574)
3748
3341db62
EZ
37492011-09-21 Eli Zaretskii <eliz@gnu.org>
3750
3751 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3752 the xassert test.
3753
3754 * dispextern.h (struct it): Update the comment documenting what
3755 can it->OBJECT be.
3756
8c203dbf
EZ
37572011-09-20 Eli Zaretskii <eliz@gnu.org>
3758
3759 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3760 a display string, extend search for cursor position to end of row.
3761 (find_row_edges): If the row ends in a newline from a display
3762 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3763 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
3764 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3765 non-empty line. Fixes confusing cursor motion with arrow keys at
3766 the beginning of a line that starts with whitespace.
8c203dbf 3767
a4824228
LMI
37682011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3769
3770 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3771 (bug#9493).
3772
33ed493b
CY
37732011-09-18 Chong Yidong <cyd@stupidchicken.com>
3774
3775 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3776 boolean (Bug#9154).
3777
56cd55c8
EZ
37782011-09-18 Eli Zaretskii <eliz@gnu.org>
3779
3780 * xdisp.c (display_line): Record maximum and minimum buffer
3781 positions even if no glyphs were produced (e.g., by a zero-width
3782 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3783 buffer positions that will be removed from the glyph row because
3784 they don't fit.
c02dcedf
EZ
3785 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3786 column is beyond frame width: don't subtract 1 "pixel" when
3787 computing width of the stretch.
3e62b7e0
EZ
3788 (reseat_at_next_visible_line_start): Undo the change made on
3789 2011-09-17 that saved paragraph information and restored it after
3790 the call to `reseat'. (Bug#9545)
56cd55c8 3791
5ed99d36 37922011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
3793
3794 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3795 and turn window cursor on if cleared (Bug#9415).
3796
5ed99d36 37972011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
3798
3799 * search.c (boyer_moore): Take unibyte characters from pattern
3800 literally. (Bug#9458)
3801
9bade7b2
EZ
38022011-09-18 Eli Zaretskii <eliz@gnu.org>
3803
3804 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3805
e5e9d610
PE
38062011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3807
87e4427a
PE
3808 Fix minor problem found by static checking.
3809 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3810 initialized, to pacify gcc -Wuninitialized.
3811
e5e9d610
PE
3812 * fileio.c: Report proper errno when syscall falls.
3813 (Finsert_file_contents): Save and restore errno,
3814 so that report_file_error outputs the correct diagnostic.
3815 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3816
a1674f0b
EZ
38172011-09-18 Eli Zaretskii <eliz@gnu.org>
3818
3819 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3820
fbfb6dd4
EZ
38212011-09-17 Eli Zaretskii <eliz@gnu.org>
3822
3823 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3824 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3825
bb187662
EZ
38262011-09-17 Eli Zaretskii <eliz@gnu.org>
3827
1137e8b8 3828 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 3829 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
3830
3831 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3832 (bidi_find_paragraph_start): Search back for paragraph beginning
3833 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3834 (bidi_move_to_visually_next): Only trigger paragraph-related
3835 computations when the last character is a newline or at EOB, not
3836 just any NEUTRAL_B. (Bug#9470)
3837
bb187662
EZ
3838 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3839 truncated lines if point is covered by a display string. (Bug#9524)
3840
2e621251
PE
38412011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3842
3843 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3844 (cons_to_x_long): New function.
3845 (lisp_data_to_selection_data): Use it. Correct the test for
3846 short-versus-long data; it was negated. Break out of vector
3847 loop, for efficiency, when a long datum is discovered.
3848
91a15bc6
SM
38492011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3850
3851 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3852
b41c3a35
EZ
38532011-09-16 Eli Zaretskii <eliz@gnu.org>
3854
3855 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3856 GCC PR/17406) by declaring this function with external scope.
3857
7812ba2d
PE
38582011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3859
3860 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3861 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3862
cf7edc2a
AS
38632011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3864
3865 * editfns.c (Fformat): Correctly handle text properties on "%%".
3866
bd01620e
EZ
38672011-09-15 Eli Zaretskii <eliz@gnu.org>
3868
3869 * xterm.c (x_draw_composite_glyph_string_foreground):
3870 * w32term.c (x_draw_composite_glyph_string_foreground):
3871 * term.c (encode_terminal_code):
3872 * composite.c (composition_update_it, get_composition_id):
3873 * xdisp.c (get_next_display_element)
3874 (fill_composite_glyph_string): Add comments about special meaning
3875 of TAB characters in a composition.
3876
a02719a3
PE
38772011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3878
3879 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
3880 This occurs when processing a multibyte format.
3881 Problem reported by Wolfgang Jenker.
a02719a3 3882
72589a3c
JB
38832011-09-15 Johan Bockgård <bojohan@gnu.org>
3884
3885 * xdisp.c (try_cursor_movement): Only check for exact match if
3886 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3887
1c14176c
PE
38882011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3889
3890 Remove unused external symbols.
3891 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3892 * xdisp.c (calc_pixel_width_or_height): Now static.
3893 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3894 * indent.c (check_display_width):
3895 * w32term.c: Fix comment to match code.
3896 * xterm.c, xterm.h (x_catching_errors): Remove.
3897
d2eea5b5
PE
38982011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3899
3900 * xselect.c: Use signed conversions more consistently (Bug#9498).
3901 (selection_data_to_lisp_data): Assume incoming selection data are
3902 signed integers, not unsigned. This is to be consistent with
3903 outgoing selection data, which was modified to use signed integers
3904 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3905 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3906 expects long, not unsigned long.
3907
46888499
EZ
39082011-09-14 Eli Zaretskii <eliz@gnu.org>
3909
3910 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3911 computation of loop end. Reported by Johan Bockgård
3912 <bojohan@gnu.org>.
3913
ef8ef9fb
CY
39142011-09-13 Chong Yidong <cyd@stupidchicken.com>
3915
3916 * frame.c (Fother_visible_frames_p): Function deleted.
3917
fa819fed
EZ
39182011-09-12 Eli Zaretskii <eliz@gnu.org>
3919
3920 * indent.c (compute_motion): Process display vector front to back
3921 rather than the other way around. (Bug#2496)
3922
2ba8e008
SM
39232011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3924
3925 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3926
20f53c69
CY
39272011-09-11 Chong Yidong <cyd@stupidchicken.com>
3928
3929 * minibuf.c (Fread_from_minibuffer): Doc fix.
3930
d562d7a4
EZ
39312011-09-11 Eli Zaretskii <eliz@gnu.org>
3932
3933 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3934 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3935
1c4d7f3d
LMI
39362011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3937
3938 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3939 value for non-existent files.
3940
b885bf36
EZ
39412011-09-11 Eli Zaretskii <eliz@gnu.org>
3942
3943 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3944 set its "size" to -1. This will set the modtime_size field of
3945 the corresponding buffer to -1, which is what
3946 verify-visited-file-modtime expects for files that do not exist.
3947 (Bug#9139)
3948
6612f0bf
PE
39492011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3950
3951 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3952 here ...
3953 * lisp.h: ... from here. push_key_description is no longer
3954 defined in keyboard.c, so its declaration should not be in
3955 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3956 logically belongs with push_key_description.
3957
dfb3f755
PE
39582011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3959
3960 * buffer.h: Include <sys/types.h> instead of <time.h>.
3961 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3962 Problem reported by Herbert J. Skuhra.
3963
3134906c
LMI
39642011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3965
3966 * xml.c (parse_region): Make the parsing work for
3967 non-comment-starting XML files again (bug#9144).
3968
8d903f4e
AS
39692011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3970
3971 * image.c (gif_load): Fix calculation of bottom and right corner.
3972 (Bug#9468)
3973
80ad64f4
EZ
39742011-09-10 Eli Zaretskii <eliz@gnu.org>
3975
3976 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3977 redisplay in small windows.
3978
208a048d
EZ
39792011-09-09 Eli Zaretskii <eliz@gnu.org>
3980
3981 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3982
9b1c252e
MR
39832011-09-08 Martin Rudalics <rudalics@gmx.at>
3984
3985 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3986 Operate on live windows only.
3987
2949f33b
JB
39882011-09-08 Juanma Barranquero <lekktu@gmail.com>
3989
3990 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3991
e08dcafd
EZ
39922011-09-07 Eli Zaretskii <eliz@gnu.org>
3993
3994 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3995 only under bidi iteration.
3996
115b96bd
JD
39972011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3998
3999 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4000
c8199d0f
PE
40012011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4002
4003 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4004 Without this fix, the command to link temacs failed due to an
4005 undefined symbol __builtin_isnan. This is because
4006 /usr/include/iso/math_c99.h #defines isnan(x) to
4007 __builtin_isnan(x), but the bundled gcc, which identifies itself
4008 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4009 a __builtin_isnan.
4010 * floatfns.c (isnan): #undef, and then #define to a clone of
4011 what's in data.c.
4012 (Fisnan): Always define, since it's always available now.
4013 (syms_of_floatfns): Always define isnan at the Lisp level.
4014
e39b275c 40152011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4016
4017 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4018
b2db44d9 40192011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4020
f4af5137 4021 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4022 The previous code assumed that file offsets (off_t values) fit in
4023 EMACS_INT variables, which is not true on typical 32-bit hosts.
4024 The code messed up by falsely reporting buffer overflow in cases
4025 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4026 when "big" contains more than 2**29 bytes, even though this
4027 inserts just one byte and does not overflow the buffer.
4028 (Finsert_file_contents): Store file offsets as off_t
4029 values, not as EMACS_INT values. Check for overflow when
4030 converting between EMACS_INT and off_t. When checking for
4031 buffer overflow or for overlap, take the offsets into account.
4032 Don't use EMACS_INT for small values where int suffices.
4033 When checking for overlap, fix a typo: ZV was used where
4034 ZV_BYTE was intended.
4035 (Fwrite_region): Don't assume off_t fits into 'long'.
4036 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4037
ecfc0a49
MA
40382011-09-05 Michael Albinus <michael.albinus@gmx.de>
4039
4040 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4041
6511acf2 40422011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4043
0999621a 4044 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4045
4046 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4047 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4048 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4049 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4050 (modify_event_symbol): Do not assume that the length of
4051 name_alist_or_stem is safe to alloca and fits in int.
4052 (Fexecute_extended_command): Likewise for function name and binding.
4053 (Frecursion_depth): Wrap around reliably on integer overflow.
4054 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4055 since some callers pass EMACS_INT values.
4056 (Fsingle_key_description): Don't crash if symbol name contains more
4057 than MAX_ALLOCA bytes.
4058 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4059 (get_minibuffer): Arg is now EMACS_INT, not int.
4060 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4061 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4062 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4063
2be7d702
PE
4064 * dbusbind.c (signature_cat): New function.
4065 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4066 Do not overrun buffer; instead, report string overflow.
4067
9d1df220
PE
4068 * dispnew.c (add_window_display_history): Don't overrun buffer.
4069 Truncate instead; this is OK since it's just a log.
4070
33ef5c64
PE
4071 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4072 even if the time zone offset is outlandishly large.
4073 Don't mishandle offset == INT_MIN.
4074
66c6fdd5
PE
4075 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4076 when creating daemon; the previous buffer-overflow check was incorrect.
4077
d749b01b
PE
4078 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4079 which has the guts of the old verror function.
4080
b5cd1905
PE
4081 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4082 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4083
6e1a67fb
PE
4084 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4085 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4086 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4087 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4088 length of string rather than counting it via multiple sprintfs;
4089 that's simpler and more reliable.
c21721cc
PE
4090 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4091 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4092 sprintf, in case result does not fit in int.
4093
c57b67fc
PE
4094 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4095 (fontset_from_font): Print it.
4096
8a401434
PE
4097 * frame.c (tty_frame_count): Now printmax_t, not int.
4098 (make_terminal_frame, set_term_frame_name): Print it.
4099 (x_report_frame_params): In X, window IDs are unsigned long,
4100 not signed long, so print them as unsigned.
4101 (validate_x_resource_name): Check for implausibly long names,
4102 and don't assume name length fits in 'int'.
4103 (x_get_resource_string): Don't blindly alloca invocation name;
4104 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4105 not fit in int.
4106
6e1a67fb
PE
4107 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4108 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4109 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4110
0df02bf3
PE
4111 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4112 Use esprintf, not sprintf, in case result does not fit in int.
4113
48e30793
PE
4114 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4115 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4116 it as a large positive number.
4117 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4118 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4119
a66ff6d8
PE
4120 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4121 in case result does not fit in int.
4122
aca216ff
PE
4123 * print.c (float_to_string): Detect width overflow more reliably.
4124 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4125 buffer overrun. Don't assume list length fits in 'int'. Treat
4126 print length of 0 as 0, not as infinity; to be consistent with other
4127 uses of print length in this function. Don't overflow print length
4128 index. Don't assume hash table size fits in 'long', or that
4129 vectorlike size fits in 'unsigned long'.
4130
31c286f7
PE
4131 * process.c (make_process): Use printmax_t, not int, to format
4132 process-name gensyms.
4133
55e5faa1
PE
4134 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4135
80f2e268
PE
4136 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4137 to avoid potential buffer overrun.
4138
670741ab
PE
4139 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4140 if X resource line is longer than 512 bytes.
4141
b7163a50
PE
4142 * xfns.c (x_window): Make sprintf buffer a bit bigger
4143 to avoid potential buffer overrun.
4144
ae58ff1f
PE
4145 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4146
c43c8a6a
PE
4147 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4148
3f8236f4
PE
41492011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4150
53e9fe90 4151 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4152 Without these, Emacs silently mishandles large integers sometimes.
4153 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4154 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4155
6511acf2
PE
4156 * xdisp.c (try_window_id): Check Emacs fixnum range before
4157 converting to 'int'.
806add1d 4158
6511acf2 4159 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4160 Check that an Emacs fixnum is in range before assigning it to 'int'.
4161 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4162 values converted from Emacs fixnums.
4163 (Frecenter): Don't wrap around a line count if it is out of 'int'
4164 range; instead, treat it as an extreme value.
4165 (Fset_window_configuration, compare_window_configurations):
4166 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4167
6511acf2
PE
4168 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4169 that can exceed INT_MAX. Check that EMACS_INT value is in range
4170 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4171 (match_limit): Don't assume that a fixnum can fit in 'int'.
4172
6511acf2 4173 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4174 exceed INT_MAX.
4175
6511acf2 4176 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4177 (Fvertical_motion): Don't wrap around LINES values that don't fit
4178 in 'int'. Instead, treat them as extreme values. This is good
4179 enough for windows, which can't have more than INT_MAX lines anyway.
4180
fcb901a7
LMI
41812011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4182
0f2f6b6d
LMI
4183 * Require libxml/parser.h to avoid compilation warning.
4184
fcb901a7
LMI
4185 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4186
4187 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4188 since this reportedly can destroy thread storage.
4189
6e20a0d4
CY
41902011-08-30 Chong Yidong <cyd@stupidchicken.com>
4191
4192 * syntax.c (find_defun_start): Update all cache variables if
4193 exiting early (Bug#9401).
4194
148ae00e
EZ
41952011-08-30 Eli Zaretskii <eliz@gnu.org>
4196
f6cfbd8f
EZ
4197 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4198
148ae00e
EZ
4199 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4200 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4201 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4202
4203 * term.c (tty_append_glyph): New function.
4204 (produce_stretch_glyph): Static function and its prototype deleted.
4205
a66cfb1c
SM
4206 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4207 Add prototypes.
148ae00e 4208
c4a07a4c
PE
42092011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4210
4211 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4212 when checking :margin (Bug#9390).
4213 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4214 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4215 so that the name doesn't mislead. All uses changed.
4216
6bc8cd65
JB
42172011-08-28 Johan Bockgård <bojohan@gnu.org>
4218
4219 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4220 set_tty_hooks.
4221
dca4927e
EZ
42222011-08-27 Eli Zaretskii <eliz@gnu.org>
4223
4224 * xdisp.c (move_it_to): Don't bail out early when reaching
4225 position beyond to_charpos, if we are scanning backwards.
4226 (move_it_vertically_backward): When DY == 0, make sure we get to
4227 the first character in the line after the newline.
4228
f2cad773
PE
42292011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4230
4231 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4232 (ccl_driver): Do not generate an out-of-range pointer.
4233 (Fccl_execute_on_string): Remove unnecessary check for
4234 integer overflow, noted by Stefan Monnier in
4235 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4236 Remove a FIXME that didn't need fixing.
4237 Simplify the newly-introduced buffer reallocation code.
4238
0cae2cdb
JB
42392011-08-27 Juanma Barranquero <lekktu@gmail.com>
4240
4241 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4242
5fc295a4 42432011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4244
70c60eb2 4245 Integer and memory overflow issues (Bug#9196).
726e0ab1 4246
d31850da
PE
4247 * doc.c (get_doc_string): Rework so that
4248 get_doc_string_buffer_size is the actual buffer size, rather than
4249 being 1 less than the actual buffer size; this makes xpalloc more
4250 convenient.
4251
a69fbedb
PE
4252 * image.c (x_allocate_bitmap_record, cache_image):
4253 * xselect.c (Fx_register_dnd_atom):
4254 Simplify previous changes by using xpalloc.
4255
fe5c5d37
PE
4256 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4257 since either will do and ptrdiff_t is convenient with xpalloc.
4258
0065d054
PE
4259 * charset.c (charset_table_size)
4260 (struct charset_sort_data.priority): Now ptrdiff_t.
4261 (charset_compare): Don't overflow if priorities differ greatly.
4262 (Fsort_charsets): Don't assume list length fits in int.
4263 Check for size-calculation overflow when allocating sort data.
4264 (syms_of_charset): Allocate an initial charset table that is
4265 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4266
4267 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4268
4269 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4270 The actual value is always <= INT_MAX, and leaving it unsigned made
4271 overflow checking harder.
4272
4273 * dispextern.h (struct glyph_matrix.rows_allocated)
4274 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4275 with xpalloc. The values are still always <= INT_MAX.
4276
4277 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4278
4279 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4280 (SAFE_NALLOCA): New macro.
4281
4282 * region-cache.c (struct boundary.pos, find_cache_boundary)
4283 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4284 (set_cache_region, invalidate_region_cache)
4285 (revalidate_region_cache, know_region_cache, region_cache_forward)
4286 (region_cache_backward, pp_cache):
4287 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4288 so that ptrdiff_t * can be passed to xpalloc.
4289 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4290 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4291 (pp_cache): Don't assume cache_len fits in int.
4292 * region-cache.h: Adjust extern decls to match.
4293
4294 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4295 EMACS_INT, since either will do, for xpalloc.
4296
4297 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4298 (xnmalloc, xnrealloc, xpalloc): New functions.
4299
726e0ab1
PE
4300 * bidi.c (bidi_shelve_header_size): New constant.
4301 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4302 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4303
51f30bc5 4304 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4305 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4306 (overlay_strings):
4307 Don't update size of array until after memory allocation succeeds,
4308 because xmalloc/xrealloc may not return.
0065d054
PE
4309 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4310 now that we have proper integer overflow checking.
4311 (record_overlay_string, overlay_strings): Catch overflows when
4312 calculating size of overlay_str_buf.
726e0ab1 4313
0065d054
PE
4314 * callproc.c (Fcall_process): Check for size overflow when
4315 calculating size of args2.
4316 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4317 Normally we prefer signed values, but sticking with ptrdiff_t would
4318 require adding more-complicated checks.
726e0ab1
PE
4319
4320 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4321 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4322 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4323 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4324
4325 * character.c (Fstring): Check for size-calculation overflow.
4326
4327 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4328 unnecessary integer overflow. Check for size overflow.
4329 (encode_coding_object): Don't update size until xmalloc succeeds.
4330
4331 * composite.c (get_composition_id): Check for overflow in glyph
4332 length calculations.
4333
4334 Integer and memory overflow fixes for display code.
4335 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4336 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4337 (scrolling_window): Check for overflow in size calculations.
4338 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4339 Don't assume glyph table len fits in int.
4340 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4341 (row_table_size): Now ptrdiff_t, not int.
4342 (scrolling_window): Avoid overflow in size calculations.
4343 Don't update size until allocation succeeds.
4344 * fns.c (concat): Check for overflow in size calculations.
4345 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4346 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4347 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4348
4349 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4350 (get_doc_string): Check for size calculation overflow.
4351 Don't update size until allocation succeeds.
4352 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4353 EMACS_INT, where ptrdiff_t will do.
4354 (Fsubstitute_command_keys): Check for string overflow.
4355
4356 * editfns.c (set_time_zone_rule): Don't assume environment length
4357 fits in int.
4358 (message_length): Now ptrdiff_t, not int.
4359 (Fmessage_box): Don't update size until allocation succeeds.
4360 Don't assume message length fits in int.
4361 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4362
0065d054
PE
4363 * emacs.c (main): Do not reallocate argv, since there is a null at
4364 the end that can be overwritten, and this way there's no need to
4365 worry about size-calculation overflow.
4366 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4367
4368 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4369 alloc succeeds.
4370 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4371
4372 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4373 (x_set_scroll_bar_width, x_figure_window_size):
4374 Check for integer overflow.
4375 (x_set_alpha): Do not assume XINT fits in int.
4376
4377 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4378 This is for the members text_lines, text_cols, total_lines, total_cols,
4379 where the system imposes an 'int' limit.
4380
4381 * fringe.c (Fdefine_fringe_bitmap):
4382 Don't update size until alloc works.
4383
4384 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4385 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4386
4387 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4388 Check for size-calculation overflow.
4389 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4390 do, as we prefer signed integers.
4391 (id_to_widget.max_size, id_to_widget.used)
4392 (xg_store_widget_in_map, xg_remove_widget_from_map)
4393 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4394 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4395 Use and return ptrdiff_t, not int.
4396 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4397 * gtkutil.h: Change prototypes to match the above.
4398
4399 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4400 are duplicate now that they've been promoted to lisp.h.
4401 (x_allocate_bitmap_record, x_alloc_image_color)
4402 (make_image_cache, cache_image, xpm_load):
4403 Don't update size until alloc is done.
4404 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4405 (x_detect_edges):
3256efce 4406 Check for size calculation overflow.
726e0ab1
PE
4407 (ct_colors_allocated_max): New constant.
4408 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4409 overflow.
3256efce 4410
726e0ab1
PE
4411 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4412 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4413 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4414 Use ptrdiff_t, not int, to count maps.
4415 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4416 calculations. Don't update size until allocation succeeds.
4417 Redo calculations to avoid overflow.
726e0ab1
PE
4418 * keyboard.h: Change prototypes to match the above.
4419
4420 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4421 to count maps.
4422 (current_minor_maps): Check for size calculation overflow.
4423 * keymap.h: Change prototypes to match the above.
4424
4425 * lread.c (read1, init_obarray): Don't update size until alloc done.
4426
4427 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4428 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4429
726e0ab1
PE
4430 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4431 Now ptrdiff_t, not int.
4432 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4433 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4434
4435 * process.c (Fnetwork_interface_list): Check for overflow
4436 in size calculation.
4437
4438 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4439
4440 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4441 overflow. Don't bother calling xmalloc when xrealloc will do.
4442
4443 * search.c (Freplace_match): Check for size calculation overflow.
4444 (Fset_match_data): Don't assume list lengths fit in 'int'.
4445
4446 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4447 for command line length. Do not attempt to address one before the
4448 beginning of an array, as that's not portable.
4449
4450 * term.c (max_frame_lines): Remove; unused.
4451 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4452 not int.
4453 (encode_terminal_code, calculate_costs): Check for size
4454 calculation overflow.
4455 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4456 table lengths and related sizes. Don't update size until alloc
4457 done. Redo calculations to avoid overflow.
4458 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4459
4460 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4461 subtracting pointers.
4462 (gobble_line): Check for overflow more carefully. Don't update size
4463 until alloc done.
4464
4465 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4466 Don't update size until alloc done.
4467 Redo size calculations to avoid overflow.
4468 Check for size calculation overflow.
0065d054 4469 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4470
4471 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4472 Use ptrdiff_t, not int, for sizes.
4473 (store_mode_line_noprop_char): Don't update size until alloc done.
4474
0065d054
PE
4475 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4476 Use ptrdiff_t, not int, for sizes.
4477 (Finternal_make_lisp_face, cache_face):
4478 Check for size calculation overflow.
4479 (cache_face): Treat size calculation overflows as if they were
4480 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4481
4482 * xfns.c (x_encode_text, x_set_name_internal)
4483 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4484 sizes, since they can exceed INT_MAX in size. Check for size
4485 calculation overflow.
4486
0065d054
PE
4487 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4488 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4489 Don't update size until alloc done.
4490
0065d054 4491 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4492 as sprintf is limited to int lengths.
1d526e2f 4493
252c5ee1
PE
4494 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4495 (X_LONG_MIN): New macros.
864d7ce7
PE
4496 Use them to make the following changes clearer.
4497 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4498 This change doesn't affect the value now, but it may help remind
4499 future maintainers not to raise the value too much later.
4500 (SELECTION_QUANTUM): Remove, replacing with ...
4501 (selection_quantum): ... new function, which avoids overflow.
4502 All uses changed.
4503 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4504 assumption that selection length fits in 'int'.
4505 (x_reply_selection_request, x_handle_selection_request)
4506 (x_get_window_property, receive_incremental_selection)
4507 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4508 (lisp_data_to_selection_data, clean_local_selection_data):
4509 Use ptrdiff_t, not int, to record length of selection.
4510 (x_reply_selection_request, x_get_window_property)
4511 (receive_incremental_selection, x_property_data_to_lisp):
4512 Redo calculations to avoid overflow.
4513 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4514 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4515 something.
4516 (x_get_window_property, receive_incremental_selection)
4517 (lisp_data_to_selection_data, x_property_data_to_lisp):
4518 Check for size-calculation overflow.
4519 (x_get_window_property, receive_incremental_selection)
4520 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4521 Don't store size until memory allocation succeeds.
4522 (x_get_window_property): Plug memory leak on memory exhaustion.
4523 Don't double-block input; malloc is safe here. Don't assume 2**34
4524 - 4 fits in unsigned long. Add an xassert to check
4525 XGetWindowProperty overflow. Be more careful about overflow
4526 calculations, and distinguish size from memory overflow better.
4527 (receive_incremental_selection): When tracing, don't assume
4528 unsigned int is less than INT_MAX.
4529 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4530 harmful) conversions of unsigned short to int.
4531 (lisp_data_to_selection_data): Don't assume that integers
4532 in the range -65535 through -1 fit in an X unsigned short.
4533 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4534 result parameters unless successful. Rely on cons_to_unsigned
4535 to report problems with elements; the old code wasn't right anyway.
4536 (x_check_property_data): Check for int overflow; we cannot use
4537 a wider type due to X limits.
4538 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4539
726e0ab1 4540 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4541
0065d054
PE
4542 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4543 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4544 (x_color_cells): Don't store size until memory allocation succeeds.
4545 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4546 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4547 (x_term_init): Don't assume length fits in int (sprintf is limited
4548 to int size).
bc18e09d 4549
ebfa62c0
PE
4550 Use ptrdiff_t for composition IDs.
4551 * character.c (lisp_string_width):
4552 * composite.c (composition_table_size, n_compositions)
4553 (get_composition_id, composition_gstring_from_id):
4554 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4555 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4556 * window.c (Frecenter):
4557 Use ptrdiff_t, not int, for composition IDs.
4558 * composite.c (get_composition_id): Check for integer overflow.
4559 * composite.h: Adjust prototypes to match the above changes.
4560
d3411f89
PE
4561 Use ptrdiff_t for hash table indexes.
4562 * category.c (hash_get_category_set):
4563 * ccl.c (ccl_driver):
4564 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4565 * coding.c (coding_system_charset_list, detect_coding_system):
4566 * coding.h (struct coding_system.id):
4567 * composite.c (get_composition_id, gstring_lookup_cache):
4568 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4569 * image.c (xpm_get_color_table_h):
4570 * lisp.h (hash_lookup, hash_put):
4571 * minibuf.c (Ftest_completion):
4572 Use ptrdiff_t for hash table indexes, not int (which is too
4573 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4574 32-bit --with-wide-int hosts).
4575
e097a6fa
PE
4576 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4577 Add a FIXME comment about memory leaks.
4578 (syms_of_charset): Don't assume xmalloc returns.
4579
5637687f
PE
4580 Don't assume that stated character widths fit in int.
4581 * character.c (Fchar_width, c_string_width, lisp_string_width):
4582 * character.h (CHAR_WIDTH):
4583 * indent.c (MULTIBYTE_BYTES_WIDTH):
4584 Use sanitize_char_width to avoid undefined and/or bad behavior
4585 with outlandish widths.
a66cfb1c 4586 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4587 now that we have two such functions. All uses changed.
4588 (sanitize_char_width): New inline function.
4589
a2271ba2
PE
4590 Don't assume that tab-width fits in int.
4591 * character.h (sanitize_width): New inline function.
4592 (SANE_TAB_WIDTH): New macro.
4593 (ASCII_CHAR_WIDTH): Use it.
4594 * indent.c (sane_tab_width): Remove. All uses replaced by
4595 SANE_TAB_WIDTH (current_buffer).
4596 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4597
18c52557
PE
4598 * fileio.c: Integer overflow issues with file modes.
4599 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4600
caeeedc1
PE
4601 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4602 Remove unreachable code.
4603 (read_hex, load_charset_map_from_file): Check for integer overflow.
4604
6df6ae42 4605 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4606 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4607 (x_send_scroll_bar_event): Likewise. Check that the size does not
4608 exceed limits imposed by XClientMessageEvent, as well as the usual
4609 ptrdiff_t and size_t limits.
4610
b13995db
PE
4611 * keyboard.c: Overflow, signedness and related fixes.
4612 (make_lispy_movement): Use same integer type in forward decl
4613 that is used in the definition.
4614 (read_key_sequence, keyremap_step):
4615 Change bufsize argument back to int, undoing my 2011-03-30 change.
4616 We prefer signed types, and int is wide enough here.
4617 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4618 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4619 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4620 length, not size_t. Use ptrdiff_t for index, not int.
4621 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4622 possibility of integer overflow.
4623
13464394
PE
4624 Overflow, signedness and related fixes for images.
4625
4626 * dispextern.h (struct it.stack[0].u.image.image_id)
4627 (struct_it.image_id, struct image.id, struct image_cache.size)
4628 (struct image_cache.used, struct image_cache.ref_count):
4629 * gtkutil.c (update_frame_tool_bar):
4630 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4631 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4632 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4633 * nsmenu.m (update_frame_tool_bar):
4634 * xdisp.c (calc_pixel_width_or_height):
4635 * xfns.c (image_cache_refcount):
4636 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4637 on typical 64-bit hosts.
4638
4639 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4640 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4641 Omit unnecessary casts to int.
4642 (parse_image_spec): Check that integers fall into 'int' range
4643 when the callers expect that.
4644 (image_ascent): Redo ascent calculation to avoid int overflow.
4645 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4646 (lookup_image): Remove unnecessary tests.
4647 (xbm_image_p): Locals are now of int, not EMACS_INT,
4648 since parse_image_check makes sure they fit into int.
4649 (png_load, gif_load, svg_load_image):
4650 Prefer int to unsigned where either will do.
4651 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4652 old tiff_error_handler and tiff_warning_handler.
4653 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4654 stack buffer overflows. It uses only the features of vsnprintf
4655 that are common to both POSIX and native Microsoft.
4656 (tiff_error_handler, tiff_warning_handler): Use it.
4657 (tiff_load, gif_load, imagemagick_load_image):
4658 Don't assume :index value fits in 'int'.
4659 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4660 (imagemagick_load_image): Check that crop parameters fit into
4661 the integer types that MagickCropImage accepts. Don't assume
4662 Vimagemagick_render_type has a nonnegative value. Don't assume
4663 size_t fits in 'long'.
4664 (gs_load): Use printmax_t to print the widest integers possible.
4665 Check for integer overflow when computing image height and width.
4666
c11821d4
EZ
46672011-08-26 Eli Zaretskii <eliz@gnu.org>
4668
4669 * xdisp.c (redisplay_window): Don't force window start if point
4670 will be invisible in the resulting window. (Bug#9324)
4671
0c95fcf7
EZ
46722011-08-25 Eli Zaretskii <eliz@gnu.org>
4673
4674 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4675 the display spec is of the form `(space ...)'.
4676 (handle_display_spec): Return the value returned by
4677 handle_single_display_spec, not just 1 or zero.
4678 (handle_single_display_spec): If the display spec is of the form
4679 `(space ...)', and specifies display in the text area, return 2
4680 rather than 1.
fee65a97 4681 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4682 accurately, and prefer exact match for point under bidi.
4683 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4684
4685 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4686 into disp_prop; all users changed.
4687
4688 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4689 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4690 for the text covered by the display property.
4691
e4ed06f1
CY
46922011-08-25 Chong Yidong <cyd@stupidchicken.com>
4693
4694 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4695 Change return value to nil.
4696 (Frecord_buffer): Delete unused function.
4697
f67cdd7f
EZ
46982011-08-24 Eli Zaretskii <eliz@gnu.org>
4699
5980d4c6
EZ
4700 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4701 buffers, return left-to-right.
8610fe8b
EZ
4702 (set_cursor_from_row): Consider candidate row a win if its glyph
4703 represents a newline and point is on that newline. Fixes cursor
4704 positioning on the newline at EOL of R2L text within L2R
4705 paragraph, and vice versa.
4706 (try_cursor_movement): Check continued rows, in addition to
4707 continuation rows. Fixes unwarranted scroll when point enters a
4708 continued line of R2L text within an L2R paragraph, or vice versa.
4709 (cursor_row_p): Consider the case of point being equal to
4710 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4711 from the end of a short line to the beginning of a continued line
4712 of R2L text within L2R paragraph.
4713 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4714 composed characters.
5980d4c6 4715
f67cdd7f
EZ
4716 * bidi.c (bidi_check_type): Use xassert.
4717 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4718 members.
4719
bca633fb
EZ
47202011-08-23 Eli Zaretskii <eliz@gnu.org>
4721
4722 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4723 a character.
4724
4a5885a7
CY
47252011-08-23 Chong Yidong <cyd@stupidchicken.com>
4726
4727 * nsfont.m (ns_otf_to_script): Fix typo.
4728
0902a04e
KH
47292011-08-22 Kenichi Handa <handa@m17n.org>
4730
4731 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4732 extra slot even if the purpose is char-code-property-table.
4733
1a2e6670
EZ
47342011-08-23 Eli Zaretskii <eliz@gnu.org>
4735
8ddde651
EZ
4736 * xdisp.c (redisplay_window): When computing centering_position,
4737 account for the height of the header line. (Bug#8874)
4738
425cc014
EZ
4739 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4740 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4741 candidate is selected by the mouse, and that candidate has a
4742 composed character under the mouse.
4743
1a2e6670
EZ
4744 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4745 coordinates reported by pos-visible-in-window-p for a composed
4746 character in column zero.
4747
8b76d6f8
SM
47482011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4749
4750 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4751
dac347dd
EZ
47522011-08-22 Eli Zaretskii <eliz@gnu.org>
4753
4754 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4755 consider it a hit if to_charpos is anywhere in the range of the
4756 composed buffer positions.
4757
e013fb34
CY
47582011-08-22 Chong Yidong <cyd@stupidchicken.com>
4759
4760 * image.c (gif_load): Don't assume that each subimage has the same
4761 dimensions as the base image. Handle disposal method that is
4762 "undefined" by the gif spec (Bug#9335).
4763
bd1ba3e8
CY
47642011-08-20 Chong Yidong <cyd@stupidchicken.com>
4765
4766 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 4767 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 4768
54a1215b
EZ
47692011-08-19 Eli Zaretskii <eliz@gnu.org>
4770
823564e5
EZ
4771 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4772 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4773 from an Org mode buffer to a Speedbar frame.
4774
54a1215b
EZ
4775 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4776 a composition, take its buffer position from IT->cmp_it.charpos.
4777 Fixes cursor positioning at the beginning of a line that begins
4778 with a composed character.
4779
9778ebcc
EZ
47802011-08-18 Eli Zaretskii <eliz@gnu.org>
4781
0be6ee06
EZ
4782 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4783 character bidirectional type, use STRONG_L instead. Fixes crashes
4784 in a buffer produced by `describe-categories'.
4785
9778ebcc
EZ
4786 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4787 members before the level stack, so they would be saved and
4788 restored when copying iterator state. Fixes incorrect reordering
4789 around TABs covered by display properties.
4790
156bffbe
AS
47912011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4792
6b02f655 4793 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 4794
72ad093b
CY
47952011-08-17 Chong Yidong <cyd@stupidchicken.com>
4796
4797 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
4798 (internal_condition_case_2, internal_condition_case_n):
4799 Remove unnecessary aborts (Bug#9081).
72ad093b 4800
35774242
EZ
48012011-08-17 Eli Zaretskii <eliz@gnu.org>
4802
4803 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4804 has no `load' handler, try opening the file locally. (Bug#9311)
4805
db76dd85
KB
48062011-08-16 Ken Brown <kbrown@cornell.edu>
4807
4808 * gmalloc.c: Expand comment.
4809
b215eee5
EZ
48102011-08-16 Eli Zaretskii <eliz@gnu.org>
4811
4812 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4813 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4814
a4579d33
KB
48152011-08-16 Ken Brown <kbrown@cornell.edu>
4816
4817 Fix memory allocation problems in Cygwin build (Bug#9273).
4818
4819 * unexcw.c ( __malloc_initialized): Declare external variable.
4820 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4821
8b76d6f8
SM
4822 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4823 New variables.
a4579d33
KB
4824 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4825 dumped emacs.
4826 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4827 in the static heap.
4828 [CYGWIN] (special_realloc): New function.
4829 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4830 requests to realloc storage in the static heap.
4831
3ebec551
PE
48322011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4833
4834 * bidi.c (bidi_initialize): Remove unused local.
4835
9fd8be00
EZ
48362011-08-15 Eli Zaretskii <eliz@gnu.org>
4837
6b02f655
SM
4838 * bidimirror.h:
4839 * biditype.h: Remove file.
4840 * makefile.w32-in ($(BLD)/bidi.$(O)):
4841 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
4842
4843 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4844
4845 * chartab.c: Improve commentary for the uniprop_table API.
4846
32413314
EZ
4847 * bidi.c (bidi_paragraph_init): Support zero value of
4848 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
4849 (bidi_initialize): Use uniprop_table instead of including
4850 biditype.h and bidimirror.h.
32413314 4851
9fd8be00
EZ
4852 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4853 coordinates of the iterator when restoring from ppos_it.
4854 (Bug#9296)
4855
5cf2b69b
KH
48562011-08-14 Kenichi Handa <handa@m17n.org>
4857
4858 * process.c (create_process): Call setup_process_coding_systems
72ad093b 4859 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 4860
daf17d00
EZ
48612011-08-14 Eli Zaretskii <eliz@gnu.org>
4862
4863 * xdisp.c (move_it_in_display_line_to): Don't invoke
4864 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4865 ppos_it. Fixes vertical cursor motion when line beginning is
4866 covered by an image. (Bug#9296)
4867
08e3161a
JD
48682011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4869
4870 * nsterm.h (ns_run_ascript): Declare.
4871 (NSAPP_DATA2_RUNASSCRIPT): Define.
4872
4873 * nsfns.m (as_script, as_result, as_status): New static variables.
4874 (ns_run_ascript): New function.
5e617bc2 4875 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
4876 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4877 the event loop. Get status from as_status (Bug#7276).
4878
4879 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4880 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4881 the event loop (Bug#7276).
4882
a3720aa2
AS
48832011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4884
4885 * gnutls.c (QCgnutls_bootprop_priority)
4886 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4887 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4888 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4889 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4890 (QCgnutls_bootprop_verify_hostname_error)
4891 (QCgnutls_bootprop_callbacks_verify): Rename from
4892 Qgnutls_bootprop_..., all uses changed.
4893
4894 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4895 uses changed.
4896
0a0d27fb
PE
48972011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4898
19d5c50c
PE
4899 * xfaces.c (Qframe_set_background_mode): Now static.
4900 * dispextern.h (Qframe_set_background_mode): Remove decl.
4901
0a0d27fb
PE
4902 * process.c (Fnetwork_interface_info): Declare local only if needed.
4903
377538cb
JD
49042011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4905
4906 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4907 (Fnetwork_interface_list): Allocate in increments of bytes instead
4908 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4909 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4910 sockaddr.
4911 (struct ifflag_def): notrailers is smart on OSX.
4912 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4913 Get hardware address with getifaddrs if available.
4914
08fff70c
EZ
49152011-08-12 Eli Zaretskii <eliz@gnu.org>
4916
4917 * xdisp.c (iterate_out_of_display_property): xassert that
4918 IT->position is set to within IT->object's boundaries. Break from
4919 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
4920 when IT->position is set up wrongly due to some bug.
4921 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
4922 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4923 entry. Force push_it to save on the stack the current
4924 buffer/string position, to be restored by pop_it. Fix flags in
4925 the iterator structure wrt the object coming from a display
4926 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4927 properties. (Bug#9284)
4928
7be1c708 49292011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 4930
7be1c708
CY
4931 * fontset.c (fontset_get_font_group): Add proper type checks.
4932 (Bug#9172)
aac0c6e3 4933
7be1c708 49342011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 4935
7be1c708
CY
4936 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4937 and LC_VERSION_MIN_MACOSX.
4938 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4939 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 4940
97bb72a6
EZ
49412011-08-08 Eli Zaretskii <eliz@gnu.org>
4942
4943 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
4944 no-display-properties-and-no-overlays under bidi display.
4945 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 4946 properties and overlays.
97bb72a6 4947
d5617611
CY
49482011-08-08 Chong Yidong <cyd@stupidchicken.com>
4949
37e11a63
CY
4950 * editfns.c (Fset_time_zone_rule): Document relationship with the
4951 setenv function.
4952
d5617611
CY
4953 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4954 the font entity extracted from the cache (Bug#8109).
4955
58872834
CY
49562011-08-07 Chong Yidong <cyd@stupidchicken.com>
4957
4958 * composite.c (autocmp_chars): Don't reset point. That is done by
4959 restore_point_unwind (Bug#5984).
4960
75bfc667
JL
49612011-08-07 Juri Linkov <juri@jurta.org>
4962
4963 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4964 to show the arg `TIME' instead of `TIMEVAL'.
4965
d1410150
EZ
49662011-08-06 Eli Zaretskii <eliz@gnu.org>
4967
4968 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4969 display property strides EOL and includes a newline, as in
4970 longlines-mode. (Bug#9254)
75b771e4
EZ
4971 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4972 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
4973
4974 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4975 is non-zero, even if the data buffer is NULL. Fixes a crash in
4976 vertical-motion with longlines-mode. (Bug#9254)
4977
35928349
EZ
49782011-08-05 Eli Zaretskii <eliz@gnu.org>
4979
ec7cc85b
EZ
4980 * bidi.c <bidi_cache_total_alloc>: Now static.
4981 (bidi_initialize): Initialize bidi_cache_total_alloc.
4982
8b76d6f8 4983 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
4984 cache. (Bug#9221)
4985
4986 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4987 amount allocated this far in `bidi_cache_total_alloc'.
4988 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4989 non-zero, only free the data buffer without restoring the cache
4990 contents. All callers changed.
4991
4992 * dispextern.h (bidi_unshelve_cache): Update prototype.
4993
4994 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4995 (move_it_in_display_line, move_it_to)
4996 (move_it_vertically_backward, move_it_by_lines): Replace the call
4997 to xfree to an equivalent call to bidi_unshelve_cache.
4998 (move_it_in_display_line_to): Fix logic of returning
412b6358 4999 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5000
e2e2423b
EZ
50012011-08-05 Eli Zaretskii <eliz@gnu.org>
5002
5003 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5004 came from a string character with a `cursor' property. (Bug#9229)
5005
ae9e757a
JD
50062011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5007
5008 * Makefile.in (LIB_PTHREAD): New variable.
5009 (LIBES): Add LIB_PTHREAD (Bug#9216).
5010
5011 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5012 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5013
213bd7f2
AS
50142011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5015
6b02f655 5016 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5017
99aaf75f
JD
50182011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5019
5020 * xterm.c (x_find_topmost_parent): New function.
5021 (x_set_frame_alpha): Find topmost parent window with
5022 x_find_topmost_parent and set the property there also (bug#9181).
5023 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5024
c74e9d86
PE
50252011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5026
5027 * callproc.c (Fcall_process): Avoid vfork clobbering
5028 the local vars buffer, coding_systems, current_dir.
5029
640c8776
SM
50302011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5031
5032 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5033
f26d0e4c
PE
50342011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5035
8a10d76c
PE
5036 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5037 so that it is not optimized away.
5038
f26d0e4c
PE
5039 * xdisp.c (compute_display_string_pos): Remove unused local.
5040
55439c61
EZ
50412011-08-02 Eli Zaretskii <eliz@gnu.org>
5042
5043 Fix slow cursor motion and scrolling in large buffers with
5044 selective display, like Org Mode buffers. (Bug#9218)
5045
5046 * dispextern.h (struct bidi_it): New member disp_prop_p.
5047
5048 * xdisp.c: Remove one-slot cache of display string positions.
5049 (compute_display_string_pos): Accept an additional argument
5e617bc2 5050 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5051 for a display string or property. If found, set DISP_PROP_P
5052 non-zero.
5053
5054 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5055 DISP_PROP_P, and pass it to compute_display_string_pos.
5056 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5057 non-zero. All callers of bidi_fetch_char changed.
5058
fb33fa43
SM
50592011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5060
5061 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5062
b099e063
DM
50632010-12-03 Don March <don@ohspite.net>
5064
5065 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5066 last character M-[char] is translated to ESC [char] (bug#7541).
5067
5cc7f7af
KH
50682011-08-02 Kenichi Handa <handa@m17n.org>
5069
d0fffa3f 5070 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5071
5072 * chartab.c (uniprop_table): Make it non-static.
5073
525d5e6e
EZ
50742011-08-01 Eli Zaretskii <eliz@gnu.org>
5075
5076 * xdisp.c (forward_to_next_line_start): Accept additional argument
5077 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5078 on the newline.
5079 (reseat_at_next_visible_line_start): Use the bidi iterator state
5080 returned by forward_to_next_line_start to restore the state of
5081 it->bidi_it after backing up to previous newline. (Bug#9212)
5082
31011111
AS
50832011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5084
5085 * regex.c (re_comp): Protoize.
5086 (re_exec): Fix return type.
5087 (regexec): Fix type of `ret'. (Bug#9203)
5088
476371c4
PE
50892011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5090
e5d76069
PE
5091 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5092 This is needed if max-image-size is a floating-point number.
5093
9a79b20c
AS
50942011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5095
5096 * print.c (print_object): Print empty symbol as ##.
5097
5098 * lread.c (read1): Read ## as empty symbol.
5099
d8c2fa78
AA
51002011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5101
5102 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5103 setting frame foreground color (Bug#9175).
5104 (x_set_background_color): Likewise.
5105
ffe57a7a
AA
5106 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5107 contents (Bug#9176).
5108 (EmacsTooltip -init): Remove bezels and add shadows to
5109 tooltip windows.
5110
bf3492a5
AA
5111 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5112 or scroll bar (Bug#8470).
5113
d55e9c53
AA
5114 * nsfont.m (nsfont_open): Remove assignment to voffset and
5115 unnecessary vars hshink, expand, hd, full_height, min_height.
5116 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5117
5118 * nsterm.h (nsfont_info): Remove voffset field.
5119
d8c2fa78 51202011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5121
5122 Implement strike-through and overline on NextStep (Bug#8863).
5123
5124 * nsfont.m (nsfont_open): Use underline position provided by font,
5125 instead of hard-coded value of 2.
5126 (nsfont_draw): Call ns_draw_text_decoration instead.
5127
5128 * nsterm.h: Add declaration for ns_draw_text_decoration.
5129
5130 * nsterm.m (ns_draw_text_decoration): New function for drawing
5131 underline, overline, and strike-through.
5132 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5133 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5134 accommodate underlining, etc.
4843aac3 5135
4cc60b9b
EZ
51362011-07-28 Eli Zaretskii <eliz@gnu.org>
5137
bc7ece87
EZ
5138 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5139 default.
4cc60b9b 5140
476371c4
PE
51412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5142
66606eea
PE
5143 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5144 Without this fix, if a signal arrives just after memory fills up,
5145 'malloc' might be invoked reentrantly.
5146
476371c4
PE
5147 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5148 In other words, assume that every image size is allowed, on non-X
5149 hosts. This assumption is probably wrong, but it lets Emacs compile.
5150
f3fcc40d
AS
51512011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5152
5153 * regex.c (re_iswctype): Convert return values to boolean.
5154
350c992f
EZ
51552011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5156
5157 * xdisp.c (compute_display_string_pos): Don't use cached display
5158 string position if the buffer had its restriction changed.
5159 (Bug#9184)
5160
5266b4bb
PE
51612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5162
5163 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5164
2573a837 51652011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5166
41f55ccd 5167 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5168
39e378da
PE
5169 * bidi.c: Integer size and overflow fixes.
5170 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5171 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5172 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5173 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5174 (bidi_find_other_level_edge):
5175 Use ptrdiff_t instead of EMACS_INT where either will do.
5176 This works better on 32-bit hosts configured --with-wide-int.
5177 (bidi_cache_ensure_space): Check for size-calculation overflow.
5178 Use % rather than repeated addition, for better worst-case speed.
5179 Don't set bidi_cache_size until after xrealloc returns, because it
5180 might not return.
5181 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5182 (bidi_cache_ensure_space): Also check that the bidi cache size
5183 does not exceed that of the largest Lisp string or buffer. See Eli
5184 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5185
5e927815
PE
5186 * alloc.c (__malloc_size_t): Remove.
5187 All uses replaced by size_t. See Andreas Schwab's note
5188 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5189
ca4aa935
PE
5190 * image.c: Improve checking for integer overflow.
5191 (check_image_size): Assume that f is nonnull, since
5192 it is always nonnull in practice. This is one less thing to
5193 worry about when checking for integer overflow later.
5194 (x_check_image_size): New function, which checks for integer
5195 overflow issues inside X.
5196 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5197 This removes the need for a memory_full check.
5198 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5199 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5200 (xbm_read_bitmap_data): Change locals back to 'int', since
5201 their values must fit in 'int'.
5202 (xpm_load_image, png_load, tiff_load):
5203 Invoke x_create_x_image_and_pixmap earlier,
5204 to avoid much needless work if the image is too large.
5205 (tiff_load): Treat overly large images as if
5206 x_create_x_image_and_pixmap failed, not as malloc failures.
5207 (gs_load): Use x_check_image_size.
5208
5f8f9cc2
PE
5209 * gtkutil.c: Omit integer casts.
5210 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5211 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5212
5adf60bc
PE
5213 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5214
c8907a93
PE
5215 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5216 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5217 would wrongly return t on a 64-bit host.
5218
e3c25c68
PE
5219 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5220 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5221 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5222 and therefore cause GCC to emit a bogus diagnostic in some cases.
5223
3f791afe
PE
5224 * image.c: Integer signedness and overflow and related fixes.
5225 This is not an exhaustive set of fixes, but it's time to
5226 record what I've got.
5227 (lookup_pixel_color, check_image_size): Remove redundant decls.
5228 (check_image_size): Don't assume that arbitrary EMACS_INT values
5229 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5230 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5231 (tiff_load, imagemagick_load_image):
5232 Check for overflow in size calculations.
5233 (x_create_x_image_and_pixmap): Remove unnecessary test for
5234 xmalloc returning NULL; that can't happen.
5235 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5236 (xpm_color_bucket): Use better integer hashing function.
5237 (xpm_cache_color): Don't possibly over-allocate memory.
5238 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5239 (gif_memory_source):
5240 Use ptrdiff_t, not int or size_t, to record sizes.
5241 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5242 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5243 either works, as we prefer signed integers.
5244 (tiff_read_from_memory, tiff_write_from_memory):
5245 Return tsize_t, not size_t, since that's what the TIFF API wants.
5246 (tiff_read_from_memory): Don't fail simply because the read would
5247 go past EOF; instead, return a short read.
5248 (tiff_load): Omit no-longer-needed casts.
5249 (Fimagemagick_types): Don't assume size fits into 'int'.
5250
3cc5a532
PE
5251 Improve hashing quality when configured --with-wide-int.
5252 * fns.c (hash_string): New function, taken from sxhash_string.
5253 Do not discard information about ASCII character case; this
5254 discarding is no longer needed.
5255 (sxhash-string): Use it. Change sig to match it. Caller changed.
5256 * lisp.h: Declare it.
5257 * lread.c (hash_string): Remove, since we now use fns.c's version.
5258 The fns.c version returns a wider integer if --with-wide-int is
5259 specified, so this should help the quality of the hashing a bit.
5260
b312a492
PE
5261 * emacs.c: Integer overflow minor fix.
5262 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5263 Define only if GNU_LINUX.
5264 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5265
dfd153ae
PE
5266 * dispnew.c: Integer signedness and overflow fixes.
5267 Remove unnecessary forward decls, that were a maintenance hassle.
5268 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5269 All uses changed.
5270 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5271 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5272 (prepare_desired_row, line_draw_cost):
5273 Use int, not unsigned, where either works.
5274 (save_current_matrix, restore_current_matrix):
5275 Use ptrdiff_t, not size_t, where either works.
5276 (init_display): Check for overflow more accurately, and without
5277 relying on undefined behavior.
5278
a81d11a3
PE
5279 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5280 Remove, replacing with the new symbols in lisp.h. All uses changed.
5281 * fileio.c (make_temp_name):
5282 * filelock.c (lock_file_1, lock_file):
5283 * xdisp.c (message_dolog):
5284 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5285 Use pMd etc. instead.
5286 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5287 replacing the pWIDE etc. symbols removed from editfns.c.
5288
3300e6fd
PE
5289 * keyboard.h (num_input_events): Now uintmax_t.
5290 This is (very slightly) less likely to mess up due to wraparound.
5291 All uses changed.
5292
fd05c7e9
PE
5293 * buffer.c: Integer signedness fixes.
5294 (alloc_buffer_text, enlarge_buffer_text):
5295 Use ptrdiff_t rather than size_t when either will do, as we prefer
5296 signed integers.
5297
903fe15d
PE
5298 * alloc.c: Integer signedness and overflow fixes.
5299 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5300 (__malloc_size_t): Default to size_t, not to int.
5301 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5302 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5303 Prefer ptrdiff_t to size_t when either would do, as we prefer
5304 signed integers.
5305 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5306 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5307 Now const. Initialize with values that are in range even if char
5308 is signed.
5309 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5310 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5311 These functions do the right thing with sizes > 2**32.
5312 (check_depth): Now ptrdiff_t, not int.
5313 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5314 Adjust to new way of storing sizes. Check for size overflow bugs
5315 in rest of code.
5316 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5317 slightly wrong anyway, as it missed one instance of
5318 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5319 (refill_memory_reserve): Omit needless cast to size_t.
5320 (mark_object_loop_halt): Mark as externally visible.
5321
ac82cc6a
PE
5322 * xselect.c: Integer signedness and overflow fixes.
5323 (Fx_register_dnd_atom, x_handle_dnd_message):
5324 Use ptrdiff_t, not size_t, since we prefer signed.
5325 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5326 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5327 x_dnd_atoms_size and x_dnd_atoms_length.
5328
c2d1e36d
PE
5329 * doprnt.c: Prefer signed to unsigned when either works.
5330 * eval.c (verror):
5331 * doprnt.c (doprnt):
5332 * lisp.h (doprnt):
5333 * xdisp.c (vmessage):
5334 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5335 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5336 prefer signed arithmetic to avoid comparison confusion.
5337 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5338 but is a bit tricky.
5339
0e926e56
PE
5340 Assume freestanding C89 headers, string.h, stdlib.h.
5341 * data.c, doprnt.c, floatfns.c, print.c:
5342 Include float.h unconditionally.
5343 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5344 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5345 * regex.c: Likewise for stddef.h, string.h.
5346 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5347 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5348 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5349 (STDC_HEADERS): Remove obsolete defines.
5350 * sysdep.c: Include limits.h unconditionally.
5351
9cfdb3ec
PE
5352 Assume support for memcmp, memcpy, memmove, memset.
5353 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5354 * regex.c (memcmp, memcpy):
5355 Remove; we assume C89 now.
5356
5357 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5358 (__malloc_safe_bcopy): Remove; no longer needed.
5359
cf950e6b 5360 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5361 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5362 well either way, and we prefer signed to unsigned.
5363
dbf38e02
LMI
53642011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5365
5366 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5367 closes the connection while we're reading (bug#9182).
5368
d6f0886c 53692011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5370
d6f0886c
JD
5371 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5372 are specified (Bug#9168).
24e0f6b1 5373
2eb1f9e6
PE
53742011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5375
5376 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5377 Found by GCC static checking and --with-wide-int on a 32-bit host.
5378
22381272 53792011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5380
5381 * xdisp.c (compute_display_string_pos): Fix logic of caching
5382 previous display string position. Initialize cached_prev_pos to
5383 -1. Fixes slow-down at the beginning of a buffer.
5384
f25e39b4
EZ
53852011-07-24 Eli Zaretskii <eliz@gnu.org>
5386
5387 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5388 for attrs[LFACE_FONTSET_INDEX].
5389
04c4b52e
PE
53902011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5391
5392 * xml.c (parse_region): Remove unused local
5393 that was recently introduced.
5394
c1734fbd
EZ
53952011-07-23 Eli Zaretskii <eliz@gnu.org>
5396
be18c5a5
EZ
5397 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5398 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5399
c1734fbd
EZ
5400 * xdisp.c (move_it_in_display_line_to): Record the best matching
5401 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5402 exit if none of the characters scanned was an exact match.
5403 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5404 when exact match is impossible due to invisible text, and the
5405 lines are truncated.
5406
a258d627
JD
54072011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5408
5409 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5410 for OSX >= 10.7.
5411
b6d5a689
EZ
54122011-07-22 Eli Zaretskii <eliz@gnu.org>
5413
0f74f785
EZ
5414 Fix a significant slow-down of cursor motion with C-n, C-p,
5415 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5416 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5417 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5418 (next_element_from_buffer): Call compute_stop_pos_backwards to
5419 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5420 base_level_stop.
5421 (reseat): Don't look for prev_stop, as that could mean a very long
5422 run.
5423 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5424 <cached_disp_overlay_modiff>: Cache for last found display string
5425 position.
551918c1 5426 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5427 about the same buffer in the same area of character positions, and
5428 the buffer wasn't changed since the time the display string
5429 position was cached.
551918c1 5430
b2d0c91a
EZ
54312011-07-22 Eli Zaretskii <eliz@gnu.org>
5432
5433 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5434 is an integer, which is important for empty lines. (Bug#9149)
5435
043604ee
CY
54362011-07-22 Chong Yidong <cyd@stupidchicken.com>
5437
5438 * frame.c (Fmodify_frame_parameters): In tty case, update the
5439 default face if necessary (Bug#4238).
5440
da4adb04
CY
54412011-07-21 Chong Yidong <cyd@stupidchicken.com>
5442
5443 * editfns.c (Fstring_to_char): No need to explain what a character
5444 is in the docstring (Bug#6576).
5445
9abd0532
LMI
54462011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5447
5448 * xml.c (parse_region): Make sure we always return a tree.
5449
36881d16
HK
54502011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5451
5452 * xml.c (parse_region): If a document contains only comments,
5453 return that, too.
5454
1e98674d
LMI
54552011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5456
5457 * xml.c (make_dom): Return comments, too.
5458
590bd467
PE
54592011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5460
5461 Port to OpenBSD.
5462 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5463 and the surrounding thread.
5464 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5465 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5466 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5467 timer goes off.
5468 * s/openbsd.h (BROKEN_SIGIO): Define.
5469 * unexelf.c (unexec) [__OpenBSD__]:
5470 Don't update the .mdebug section of the Alpha COFF symbol table.
5471
f41628b2
LMI
54722011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5473
5474 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5475 (bug#8460).
5476
b59b67c5
PE
54772011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5478
15e3a074
PE
5479 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5480 This fixes some race conditions on the permissions of any newly
5481 created file.
5482
41bed37d
PE
5483 * alloc.c (valid_pointer_p): Use pipe, not open.
5484 This fixes some permissions issues when debugging.
5485
b59b67c5
PE
5486 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5487 If fchown fails to set both uid and gid, try to set just gid,
5488 as that is sometimes allowed. Adjust the file's mode to eliminate
5489 setuid or setgid bits that are inappropriate if fchown fails.
5490
925a6be7
SM
54912011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5492
5493 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5494 to compare Lisp_Objects.
5495 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5496 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5497 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5498
52968808
AS
54992011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5500
0a6a104b
AS
5501 * lread.c (read_integer): Unread even EOF character.
5502 (read1): Likewise. Properly record start position of symbol.
5503
52968808
AS
5504 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5505 symbol character follows.
5506
9e381cdd
PE
55072011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5508
5509 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5510 This works around a problem with the previous change to Fcopy_file.
5511 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5512 and without this change, GCC might complain about discarding
5513 fchown's return value.
5514
b5641435
JB
55152011-07-16 Juanma Barranquero <lekktu@gmail.com>
5516
5517 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5518
a8031457
PE
55192011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5520
5521 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5522
dd889327
LMI
55232011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5524
750c33f7
LMI
5525 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5526 it's used from the C level.
5527
dd889327
LMI
5528 * process.c: Use the same condition for POLL_FOR_INPUT in both
5529 keyboard.c and process.c (bug#1858).
5530
87e86684
LM
55312011-07-09 Lawrence Mitchell <wence@gmx.li>
5532
5533 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5534 (Fgnutls_boot): Use it.
5535
64348f40
AS
55362011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5537
5538 * doc.c (Fsubstitute_command_keys): Revert last change.
5539
1d698799
LMI
55402011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5541
f863868c
LMI
5542 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5543 quotes the next character, and doesn't affect other longer
5544 sequences (bug#8935).
5545
1d698799
LMI
5546 * lread.c (syms_of_lread): Clarify that is isn't only
5547 `eval-buffer' and `eval-defun' that's affected by
5548 `lexical-binding' (bug#8460).
5549
aa4b6df6
EZ
55502011-07-15 Eli Zaretskii <eliz@gnu.org>
5551
5552 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5553 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5554
5d856da6
PE
55552011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5556
ad6042bb
PE
5557 Fix minor problems found by static checking.
5558 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5559 (elsz): Now a signed constant, not a size_t var. We prefer signed
5560 types to unsigned, to avoid integer comparison confusion. Without
5561 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5562 "cannot optimize loop, the loop counter may overflow", a symptom
5563 of the confusion.
f00bbb22 5564 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5565 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5566
6468f31c
LMI
55672011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5568
49080b10
LMI
5569 * search.c (Fre_search_backward): Mention `case-fold-search' in
5570 all the re_search_* functions (bug#8138).
5571
6468f31c
LMI
5572 * keyboard.c (Fopen_dribble_file): Document when the file is
5573 closed (bug#8056).
5574
c965adc5
EZ
55752011-07-14 Eli Zaretskii <eliz@gnu.org>
5576
df9733bf
EZ
5577 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5578 bidi_cache_idx.
5579
0bb23927
EZ
5580 Support bidi reordering of display and overlay strings.
5581 * xdisp.c (compute_display_string_pos)
5582 (compute_display_string_end): Accept additional argument STRING.
5583 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5584 (reseat_to_string): Initialize bidi_it->string.s and
5585 bidi_it->string.schars.
5586 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5587 NULL (avoids a crash in bidi_paragraph_init).
5588 Initialize itb.string.lstring.
0bb23927
EZ
5589 (init_iterator): Call bidi_init_it only of a valid
5590 buffer position was specified. Initialize paragraph_embedding to
5591 L2R.
5592 (reseat_to_string): Initialize the bidi iterator.
5593 (display_string): If we need to ignore text properties of
5594 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5595 original value of -1 will not work with bidi.)
5596 (compute_display_string_pos): First arg is now struct
5597 `text_pos *'; all callers changed. Support display properties on
5598 Lisp strings.
5599 (compute_display_string_end): Support display properties on Lisp
5600 strings.
5601 (init_iterator, reseat_1, reseat_to_string): Initialize the
5602 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5603 when iterating on a string not from display properties).
640c8776
SM
5604 (compute_display_string_pos, compute_display_string_end):
5605 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5606 arrow keys.
5607 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5608 base_level_stop; instead, set base_level_stop to BEGV.
5609 Fixes crashes in vertical-motion.
0bb23927
EZ
5610 (next_element_from_buffer): Improve commentary for when
5611 the iterator is before prev_stop.
5612 (init_iterator): Initialize bidi_p from the default value of
5613 bidi-display-reordering, not from buffer-local value. Use the
5614 buffer-local value only if initializing for buffer iteration.
5615 (handle_invisible_prop): Support invisible properties on strings
5616 that are being bidi-reordered.
5617 (set_iterator_to_next): Support bidi reordering of C strings and
5618 Lisp strings.
5619 (next_element_from_string): Support bidi reordering of Lisp
5620 strings.
5621 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5622 (display_string): Support display of R2L glyph rows.
5623 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5624 (init_iterator): Don't initialize it->bidi_p for strings
5625 here.
5626 (reseat_to_string): Initialize it->bidi_p for strings here.
5627 (next_element_from_string, next_element_from_c_string)
5628 (next_element_from_buffer): Add xassert's for correspondence
5629 between IT's object being iterated and it->bidi_it.string
5630 structure.
5631 (face_before_or_after_it_pos): Support bidi iteration.
5632 (next_element_from_c_string): Handle the case of the first string
5633 character that is not the first one in the visual order.
5634 (get_visually_first_element): New function, refactored from common
5635 parts of next_element_from_buffer, next_element_from_string, and
5636 next_element_from_c_string.
5637 (tool_bar_lines_needed, redisplay_tool_bar)
5638 (display_menu_bar): Force left-to-right direction. Add a FIXME
5639 comment for making that be controlled by a user option.
5640 (push_it, pop_it): Save and restore the state of the
5641 bidi iterator. Save and restore the bidi_p flag.
5642 (pop_it): Iterate out of display property for string iteration as
5643 well.
5644 (iterate_out_of_display_property): Support iteration over strings.
5645 (handle_single_display_spec): Set up it->bidi_it for iteration
5646 over a display string, and call bidi_init_it.
5647 (handle_single_display_spec, next_overlay_string)
5648 (get_overlay_strings_1, push_display_prop): Set up the bidi
5649 iterator for displaying display or overlay strings.
5650 (forward_to_next_line_start): Don't use the shortcut if
5651 bidi-iterating.
5652 (back_to_previous_visible_line_start): If handle_display_prop
5653 pushed the iterator stack, restore the internal state of the bidi
5654 iterator by calling bidi_pop_it same number of times.
5655 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5656 and we are bidi-iterating, don't decrement the iterator position;
5657 instead, set the first_elt flag in the bidi iterator, to produce
5658 the same effect.
5659 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5660 (push_display_prop): xassert that we are iterating a buffer.
5661 (push_it, pop_it): Save and restore paragraph_embedding member.
5662 (handle_single_display_spec, next_overlay_string)
5663 (get_overlay_strings_1, reseat_1, reseat_to_string)
5664 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5665 correctly. Don't assume unibyte strings are not bidi-reordered.
5666 (compute_display_string_pos)
5667 (compute_display_string_end): Fix handling the case of C string.
5668 (push_it, pop_it): Save and restore from_disp_prop_p.
5669 (handle_single_display_spec, push_display_prop): Set the
5670 from_disp_prop_p flag.
5671 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5672 (pop_it): Call iterate_out_of_display_property only if we are
5673 popping after iteration over a string that came from a display
5674 property. Fix a typo in popping stretch info. Add an assertion
5675 for verifying that the iterator position is in sync with the bidi
5676 iterator.
5677 (handle_single_display_spec, get_overlay_strings_1)
5678 (push_display_prop): Fix initialization of paragraph direction for
5679 string when that of the parent object is not yet determined.
5680 (reseat_1): Call bidi_init_it to resync the bidi
5681 iterator with IT's position. (Bug#7616)
5682 (find_row_edges): If ROW->start.pos gives position
5683 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5684 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5685 Reset the from_disp_prop_p flag.
5686 (SAVE_IT, RESTORE_IT): New macros.
5687 (pos_visible_p, face_before_or_after_it_pos)
5688 (back_to_previous_visible_line_start)
5689 (move_it_in_display_line_to, move_it_in_display_line)
5690 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5691 (try_scrolling, redisplay_window, display_line): Use them when
5692 saving a temporary copy of the iterator and restoring it back.
5693 (back_to_previous_visible_line_start, reseat_1)
5694 (init_iterator): Empty the bidi cache "stack".
5695 (move_it_in_display_line_to): If iterator ended up at
5696 EOL, but we never saw any buffer positions smaller than
5697 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5698 motion in bidi-reordered lines.
5699 (move_it_in_display_line_to): Record prev_method and prev_pos
5700 immediately before the call to set_iterator_to_next. Fixes cursor
5701 motion in bidi-reordered lines with stretch glyphs and strings
5702 displayed in margins. (Bug#8133) (Bug#8867)
5703 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5704 TO_CHARPOS.
640c8776
SM
5705 (pos_visible_p): Support positions in bidi-reordered lines.
5706 Save and restore bidi cache.
0bb23927
EZ
5707
5708 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5709 (bidi_paragraph_info): Delete unused struct.
5710 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5711 (bidi_cache_start): New variable.
5712 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5713 to zero.
5714 (bidi_cache_fetch_state, bidi_cache_search)
5715 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5716 (bidi_cache_find, bidi_peek_at_next_level)
5717 (bidi_level_of_next_char, bidi_find_other_level_edge)
5718 (bidi_move_to_visually_next): Compare cache index with
5719 bidi_cache_start rather than with zero.
5720 (bidi_fetch_char): Accept new argument STRING; all callers
5721 changed. Support iteration over a string. Support strings with
5722 display properties. Support unibyte strings. Fix the type of
5723 `len' according to what STRING_CHAR_AND_LENGTH expects.
5724 (bidi_paragraph_init, bidi_resolve_explicit_1)
5725 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5726 (bidi_level_of_next_char, bidi_move_to_visually_next):
5727 Support iteration over a string.
0bb23927
EZ
5728 (bidi_set_sor_type, bidi_resolve_explicit_1)
5729 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5730 can now be zero (for strings); special values 0 and -1 were
5731 changed to -1 and -2, respectively.
5732 (bidi_char_at_pos): New function.
5733 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5734 Call it instead of FETCH_MULTIBYTE_CHAR.
5735 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5736 initialized to valid values.
5737 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5738 values.
5739 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5740 the test for valid cached positions. Fix the logic for looking up
5741 the sentinel state in the cache. GCPRO the Lisp string we are
5742 iterating.
5743 (bidi_push_it, bidi_pop_it): New functions.
5744 (bidi_initialize): Initialize the bidi cache start stack pointer.
5745 (bidi_cache_ensure_space): New function, refactored from part of
5746 bidi_cache_iterator_state. Don't assume the required size is just
5747 one BIDI_CACHE_CHUNK away.
5748 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5749 (bidi_count_bytes, bidi_char_at_pos): New functions.
5750 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5751 always valid if bidi_cache_idx is valid.
5752 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5753 is valid if it's going to be used.
5754 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5755 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
5756 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5757 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
5758 (bidi_find_other_level_edge, bidi_cache_start_stack):
5759 All variables related to cache indices are now EMACS_INT.
c965adc5 5760
0bb23927
EZ
5761 * dispextern.h (struct bidi_string_data): New structure.
5762 (struct bidi_it): New member `string'. Make flag members be 1-bit
5763 fields, and put them last in the struct.
640c8776
SM
5764 (compute_display_string_pos, compute_display_string_end):
5765 Update prototypes.
0bb23927
EZ
5766 (bidi_push_it, bidi_pop_it): Add prototypes.
5767 (struct iterator_stack_entry): New members bidi_p,
5768 paragraph_embedding, and from_disp_prop_p.
5769 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
5770 (bidi_shelve_cache, bidi_unshelve_cache):
5771 Declare prototypes.
0bb23927
EZ
5772
5773 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5774 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5775 and vector-like objects.
5776
5777 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5778 cache around display iteration.
5779
5780 * window.c (Fwindow_end, window_scroll_pixel_based)
5781 (displayed_window_lines, Frecenter): Save and restore the bidi
5782 cache around display iteration.
5783
3bbd2265
LMI
57842011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5785
5786 * editfns.c (Fdelete_region): Clarify the use of the named
5787 parameters (bug#6788).
5788
adc47434
MR
57892011-07-14 Martin Rudalics <rudalics@gmx.at>
5790
5791 * indent.c (Fvertical_motion): Set and restore w->pointm when
5792 saving and restoring the window's buffer (Bug#9006).
5793
837c31f8
LMI
57942011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5795
5796 * editfns.c (Fstring_to_char): Clarify just what is returned
5797 (bug#6576). Text by Eli Zaretskii.
5798
ac389d0c
JB
57992011-07-13 Juanma Barranquero <lekktu@gmail.com>
5800
5801 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5802
0be0ce47
EZ
58032011-07-13 Eli Zaretskii <eliz@gnu.org>
5804
5805 * buffer.c (mmap_find): Fix a typo.
5806
cd18e7e3
JB
58072011-07-13 Johan Bockgård <bojohan@gnu.org>
5808
5809 Fix execution of x selection hooks.
5810 * xselect.c (Qx_lost_selection_functions)
5811 (Qx_sent_selection_functions): New vars.
5812 (syms_of_xselect): DEFSYM them.
5813 (x_handle_selection_request): Pass Qx_sent_selection_functions
5814 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5815 (x_handle_selection_clear,x_clear_frame_selections):
5816 Pass Qx_lost_selection_functions rather than
5817 Vx_lost_selection_functions to Frun_hook_with_args.
5818
47ea7f44
PE
58192011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5820
ac389d0c 5821 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
5822 The old code sometimes used this field without initializing it.
5823
47ea7f44
PE
5824 * alloc.c (gc_sweep): Don't read past end of array.
5825 In theory, the old code could also have corrupted Emacs internals,
5826 though it'd be very unlikely.
5827
bc985c87
AS
58282011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5829
5830 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 5831 argument. (Bug#4026)
bc985c87 5832
0cf34688
LMI
58332011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5834
b3dadd76
LMI
5835 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5836 key" (bug#4257).
5837
0cf34688
LMI
5838 * window.c (Fset_window_start): Doc fix (bug#4199).
5839 (Fset_window_hscroll): Ditto.
5840
270768cd
PE
58412011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5842
077e3dda 5843 Fix minor new problems caught by GCC 4.6.1.
270768cd 5844 * term.c (init_tty): Remove unused local.
490011a6 5845 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 5846 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 5847 not used otherwise.
270768cd 5848
b1f58454
CY
58492011-07-12 Chong Yidong <cyd@stupidchicken.com>
5850
5851 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5852
22b9578d
LMI
58532011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5854
6e70ab07
LMI
5855 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5856 are the mini-buffer and the echo area (bug#3320).
5857
22b9578d
LMI
5858 * term.c (init_tty): Remove support for supdup, c10 and perq
5859 terminals, which are no longer supported (bug#1482).
5860
8974cc9f
JB
58612011-07-10 Johan Bockgård <bojohan@gnu.org>
5862
5863 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5864
a560d974
JD
58652011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5866
5867 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5868 for non-popups (Bug#3642).
5869
1dae0f0a
AS
58702011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5871
268c2c36 5872 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 5873 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
5874 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5875 * cm.c (losecursor): Likewise.
1dae0f0a
AS
5876 * data.c (fmod): Likewise.
5877 * dispnew.c (swap_glyphs_in_rows): Likewise.
5878 * emacs.c (memory_warning_signal): Likewise.
5879 * floatfns.c (float_error): Likewise.
5880 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5881 (otf_open, font_otf_capability, generate_otf_features)
5882 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5883 Likewise.
5884 * image.c (pbm_read_file): Likewise.
5885 * indent.c (string_display_width): Likewise.
5886 * intervals.c (check_for_interval, search_for_interval)
5887 (inc_interval_count, count_intervals, root_interval)
5888 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5889 * lread.c (defalias): Likewise.
268c2c36 5890 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
5891 * regex.c (set_image_of_range_1, set_image_of_range)
5892 (regex_grow_registers): Likewise.
5893 * sysdep.c (strerror): Likewise.
5894 * termcap.c (valid_filename_p, tprint, main): Likewise.
5895 * tparam.c (main): Likewise.
5896 * unexhp9k800.c (run_time_remap, save_data_space)
5897 (update_file_ptrs, read_header, write_header, calculate_checksum)
5898 (copy_file, copy_rest, display_header): Likewise.
5899 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5900 Likewise.
5901 * xdisp.c (check_it): Likewise.
5902 * xfaces.c (register_color, unregister_color, unregister_colors):
5903 Likewise.
5904 * xfns.c (print_fontset_result): Likewise.
5905 * xrdb.c (member, fatal, main): Likewise.
5906
99033785
PE
59072011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5908
5909 Fix minor problems found by static checking (Bug#9031).
5910 * chartab.c (char_table_set_range, map_sub_char_table):
5911 Remove unused locals.
5912 (uniprop_table): Now static.
5913 * composite.c (_work_char): Remove unused static var.
5914
9cb2ac56
JB
59152011-07-09 Juanma Barranquero <lekktu@gmail.com>
5916
5917 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5918
f25661f0
JD
59192011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5920
5921 * gtkutil.c (qttip_cb): Remove code without function.
5922
8278c4fe
EZ
59232011-07-09 Eli Zaretskii <eliz@gnu.org>
5924
5925 * w32.c (pthread_sigmask): New stub.
5926
1692ae2d 59272011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 5928
8a6ebd58 5929 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
5930 sigprocmask is portable only for single-threaded applications, and
5931 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
5932 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5933 (LIBES): Use it.
5934 * callproc.c (Fcall_process):
5935 * process.c (create_process):
5936 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5937 Use pthread_sigmask, not sigprocmask.
123403e4 5938
1b854618
JD
59392011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5940
5941 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5942 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5943 wrong (Bug#8591).
5944
3fe4b549
JD
59452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5946
0ce7e563
JD
5947 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5948 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5949 (xg_hide_tooltip): Fix comment.
5950
3fe4b549
JD
5951 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5952 in registerServicesMenuSendTypes.
5953 (validRequestorForSendType): Don't check ns_return_types.
5954
5955 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5956 ns_return_type.
5957
5df75e47
JR
59582011-07-08 Jason Rumney <jasonr@gnu.org>
5959
22610910
JR
5960 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5961 SH_SHOW for hidden windows (Bug#5482).
5962
5df75e47
JR
5963 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5964 frame struct members of non-existent frames (Bug#6284).
5965
699c10bd
JD
59662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5967
4393663b
JD
5968 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5969 variable firstTime not needed on OSX >= 10.6.
5970 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5971 >= 10.5. Use setKnobProportion, setDoubleValue.
5972
5973 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5974 (MAC_OS_X_VERSION_10_5): Define if not defined.
5975 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5976 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5977 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5978
5979 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5980 cString and lossyCString on OSX >= 10.4
5981
58179cce 5982 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
5983 sizeToFit on OSX >= 10.2.
5984
5985 * nsimage.m (allocInitFromFile): Don't use deprecated method
5986 bestRepresentationForDevice on OSX >= 10.6.
5987
5988 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5989 to avoid warning.
5990
5991 * emacs.c: Declare unexec_init_emacs_zone.
5992
a63e0781
JD
5993 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5994
699c10bd
JD
5995 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5996
5997 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5998 on svcsMenu (Bug#8842).
5999
6000 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6001 ns_return_types.
6002 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6003
6004 * nsterm.m (QUTF8_STRING): Declare.
6005 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6006 (validRequestorForSendType): Return type is (id).
6007 Change indexOfObjectIdenticalTo to indexOfObject.
6008 Check if we have local selection before returning self (Bug#8842).
6009 (writeSelectionToPasteboard): Put local selection into paste board
6010 if we have a local selection (Bug#8842).
6011 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6012
6013 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6014 (ns_get_local_selection): Declare.
6015
54e10184
LMI
60162011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6017
9888ff71
LMI
6018 * keymap.c (describe_map_tree): Don't insert a double newline at
6019 the end of the buffer (bug#1169) and return whether we inserted
6020 something.
6021
54e10184
LMI
6022 * callint.c (Fcall_interactively): Change "reading args" to
6023 "providing args" to try to clarify what it does (bug#1010).
6024
15fa4783
KH
60252011-07-07 Kenichi Handa <handa@m17n.org>
6026
6027 * composite.c (composition_compute_stop_pos): Ignore a static
6028 composition starting before CHARPOS (Bug#8915).
6029
6030 * xdisp.c (handle_composition_prop): Likewise.
6031
a8815b00
EZ
60322011-07-07 Eli Zaretskii <eliz@gnu.org>
6033
6034 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6035 (Bug#9015)
6036
ef7b981d 60372011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6038
6039 * character.h (unicode_category_t): New enum type.
6040
6041 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6042 (Qchar_code_property_table): New variable.
6043 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6044 (UNIPROP_COMPRESSED_FORM_P): New macros.
6045 (char_table_ascii): Uncompress the compressed values.
6046 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6047 Uncompress the compressed values.
ac389d0c 6048 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6049 (char_table_ref_and_range): Uncompress the compressed values.
6050 (sub_char_table_set): New arg is_uniprop. Callers changed.
6051 Uncompress the compressed values.
6052 (sub_char_table_set_range): Args changed. Callers changed.
6053 (char_table_set_range): Adjuted for the above change.
6054 (map_sub_char_table): Delete args default_val and parent. Add arg
6055 top. Give decoded values to a Lisp function.
640c8776 6056 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6057 values to a Lisp function. Gcpro more variables.
6058 (uniprop_table_uncompress)
6059 (uniprop_decode_value_run_length): New functions.
6060 (uniprop_decoder, uniprop_decoder_count): New variables.
6061 (uniprop_get_decoder, uniprop_encode_value_character)
6062 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6063 New functions.
6064 (uniprop_encoder, uniprop_encoder_count): New variables.
6065 (uniprop_get_encoder, uniprop_table)
6066 (Funicode_property_table_internal, Fget_unicode_property_internal)
6067 (Fput_unicode_property_internal): New functions.
6068 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6069 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6070 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6071 char-code-property-alist.
6072
640c8776 6073 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6074 Vunicode_category_table.
6075
640c8776 6076 * font.c (font_range): Adjust for the change of
c805dec0
KH
6077 Vunicode_category_table.
6078
76b397fb
DN
60792011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6080
6081 * m/iris4d.h: Remove file, move contents ...
6082 * s/irix6-5.h: ... here.
6083
22b4128e
PE
60842011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6085
6086 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6087 * alloc.c (mark_buffer):
6088 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6089 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6090 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6091 This isn't true in general, and it's particularly not true
6092 if Emacs is configured with --with-wide-int.
6093 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6094 New macros, used in the buffer.c change.
6095
869795d6
JD
60962011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6097
6098 * xsettings.c: Use both GConf and GSettings if both are available.
6099 (store_config_changed_event): Add comment.
6100 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6101 (store_tool_bar_style_changed): New functions.
5e617bc2 6102 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6103 (struct xsettings): Move font inside HAVE_XFT.
6104 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6105 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6106 Move inside HAVE_XFT.
640c8776 6107 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6108 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6109 also.
6110 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6111 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6112 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6113 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6114 (parse_settings): Move check for font inside HAVE_XFT.
6115 (read_settings, apply_xft_settings): Add comment.
6116 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6117 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6118 call store_font_name_changed.
6119 (xft_settings_event): Add comment.
6120 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6121 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6122 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6123 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6124 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6125 (xsettings_get_system_font, xsettings_get_system_normal_font):
6126 Add comment.
869795d6 6127
d8ed26bd
PE
61282011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6129
6130 Random fixes. E.g., (random) never returned negative values.
6131 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6132 subseconds part to the entropy, as that's a bit more random.
6133 Prefer signed to unsigned, since the signedness doesn't matter and
6134 in general we prefer signed. When given a limit, use a
6135 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6136 latter isn't right if USE_2_TAGS_FOR_INTS.
6137 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6138 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6139
cabf1cac
SM
61402011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6141
6142 * textprop.c (text_property_stickiness):
6143 Obey Vtext_property_default_nonsticky.
6144 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6145 * w32fns.c (syms_of_w32fns):
6146 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6147
6e9b2be9
PE
61482011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6149
6150 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6151 This is more efficient than Ffile_directory_p and avoids a minor race.
6152
90186c68
LMI
61532011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6154
7c301272
LMI
6155 * buffer.c (Foverlay_put): Say what the return value is
6156 (bug#7835).
6157
c4f2d8d4
LMI
6158 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6159 is a directory before asking whether to use the file name
6160 (bug#7564).
ad637907
LMI
6161 (barf_or_query_if_file_exists): Make the "File is a directory"
6162 error be more correct.
c4f2d8d4 6163
90186c68
LMI
6164 * fns.c (Frequire): Remove the mention of the .gz files, since
6165 that's installation-specific, but keep the mention of
6166 `get-load-suffixes'.
6167
da64016e
PE
61682011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6169
6170 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6171 Report string overflow if the output is too long.
6172
7d47b580
JB
61732011-07-04 Juanma Barranquero <lekktu@gmail.com>
6174
a555cb87
JB
6175 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6176 (syms_of_gnutls): Remove duplicate DEFSYM for
6177 Qgnutls_bootprop_verify_hostname_error, an error for
6178 Qgnutls_bootprop_verify_error (which is no longer used).
6179
7d47b580
JB
6180 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6181 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6182 Also (re)move comments that are misplaced or no longer relevant.
6183
1e49bfab
LMI
61842011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6185
6186 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6187
1485f4c0
CY
61882011-07-03 Chong Yidong <cyd@stupidchicken.com>
6189
6190 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6191 and background color parameters if they have been changed.
6192
a9ab721e
LMI
61932011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6194
6195 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6196
cf7cff57
PE
61972011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6198
2e13213d
PE
6199 * xsettings.c (SYSTEM_FONT): Define only when used.
6200 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6201
cf7cff57
PE
6202 * keymap.c (access_keymap_1): Now static.
6203
7a8e04f7
CY
62042011-07-02 Chong Yidong <cyd@stupidchicken.com>
6205
6206 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6207 leave any prefix arg for the up event (Bug#1586).
6208
61352f62
LMI
62092011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6210
69bb1ef7
LMI
6211 * lread.c (syms_of_lread): Mention single symbols defined by
6212 `defvar' or `defconst' (bug#7154).
6213
61352f62 6214 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6215 (Frequire): Mention get-load-suffixes.
61352f62 6216
28545e04
MR
62172011-07-02 Martin Rudalics <rudalics@gmx.at>
6218
6219 * window.h (window): Remove clone_number slot.
6220 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6221 Remove.
6222 (make_parent_window, make_window, saved_window)
6223 (Fset_window_configuration, save_window_save): Don't deal with
6224 clone numbers.
6225 * buffer.c (Qclone_number): Remove declaration.
6226 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6227
3349e122
SM
62282011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6229
6230 Add multiple inheritance to keymaps.
6231 * keymap.c (Fmake_composed_keymap): New function.
6232 (Fset_keymap_parent): Simplify.
6233 (fix_submap_inheritance): Remove.
6234 (access_keymap_1): New function extracted from access_keymap to handle
6235 embedded parents and handle lists of maps.
6236 (access_keymap): Use it.
6237 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6238 (Fcopy_keymap): Handle embedded parents.
6239 (Fcommand_remapping, define_as_prefix): Simplify.
6240 (Fkey_binding): Simplify.
6241 (syms_of_keymap): Move minibuffer-local-completion-map,
6242 minibuffer-local-filename-completion-map,
6243 minibuffer-local-must-match-map, and
6244 minibuffer-local-filename-must-match-map to Elisp.
6245 (syms_of_keymap): Defsubr make-composed-keymap.
6246 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6247 (parse_menu_item): Trivial simplification.
6248
3279eb87
GM
62492011-07-01 Glenn Morris <rgm@gnu.org>
6250
6251 * Makefile.in (SETTINGS_LIBS): Fix typo.
6252
4550efdf
KI
62532011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6254
6255 * coding.c (Fencode_coding_string): Record the last coding system
6256 used, as the function doc string says (bug#8738).
6257
0949d2b6
JD
62582011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6259
6260 * xsettings.c (store_monospaced_changed): Take new font as arg and
6261 check for change against current_mono_font.
6262 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6263 (emacs_settings_constructor, emacs_settings_get_property)
6264 (emacs_settings_set_property, emacs_settings_class_init)
6265 (emacs_settings_init, gsettings_obj): Remove.
6266 (something_changedCB): New function for HAVE_GSETTINGS.
6267 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6268 with value as argument.
6269 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6270 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6271 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6272 "changed".
6273
6274 * xgselect.c: Add defined (HAVE_GSETTINGS).
6275 (xgselect_initialize): Ditto.
6276
6277 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6278 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6279 xg_select.
6280
bbc6b304
PE
62812011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6282
6283 * eval.c (struct backtrace): Simplify and port the data structure.
6284 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6285 signed bit field, as this assumption is not portable and it makes
6286 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6287 "char debug_on_exit : 1" as this is not portable either; instead,
6288 use the portable "unsigned int debug_on_exit : 1". Remove unused
6289 member evalargs. Remove obsolete comments about cc bombing out.
6290
9851bfc5
JD
62912011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6292
51bb811f 6293 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6294 Let HAVE_GSETTINGS override HAVE_GCONF.
6295 (store_monospaced_changed): New function.
6296 (EMACS_SETTINGS): A new type derived from GObject to handle
6297 GSettings notifications.
6298 (emacs_settings_constructor, emacs_settings_get_property)
6299 (emacs_settings_set_property, emacs_settings_class_init):
6300 New functions.
6301 (gsettings_client, gsettings_obj): New variables.
6302 (GSETTINGS_SCHEMA): New define.
6303 (something_changedCB): Call store_monospaced_changed.
6304 (init_gsettings): New function.
6305 (xsettings_initialize): Call init_gsettings.
6306 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6307 to NULL.
6308
640c8776 6309 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6310 GCONF_CFLAGS/LIBS.
6311
5386012d
MR
63122011-06-29 Martin Rudalics <rudalics@gmx.at>
6313
6314 * window.c (resize_root_window, grow_mini_window)
6315 (shrink_mini_window): Rename Qresize_root_window to
6316 Qwindow_resize_root_window and Qresize_root_window_vertically to
6317 Qwindow_resize_root_window_vertically.
6318
f13e0b08
PE
63192011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6320
6321 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6322
94515237
JB
63232011-06-27 Juanma Barranquero <lekktu@gmail.com>
6324
6325 * makefile.w32-in: Redesign dependencies so they reflect more
6326 clearly which files are directly included by each source file,
6327 and not through other includes.
6328
e43b6e43
MR
63292011-06-27 Martin Rudalics <rudalics@gmx.at>
6330
6331 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6332 (sort_overlays, overlay_strings): When an overlay's clone number
6333 matches the window's clone number process the overlay even if
6334 the overlay's window property doesn't match the current window.
6335
d68443dc
MR
6336 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6337 (Fwindow_hchild): Rename to Fwindow_left_child.
6338 (Fwindow_next): Rename to Fwindow_next_sibling.
6339 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6340 (resize_window_check): Rename to window_resize_check.
6341 (resize_window_apply): Rename to window_resize_apply.
6342 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6343 (Fdelete_other_windows_internal, resize_frame_windows)
6344 (Fsplit_window_internal, Fdelete_window_internal)
6345 (grow_mini_window, shrink_mini_window)
6346 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6347
c7e73be5
JD
63482011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6349
6350 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6351 (emacs_fixed_set_min_size): Remove.
6352 (emacs_fixed_new): Take frame as argument.
6353
6354 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6355 (_EmacsFixedPrivate): Remove minwidth/height.
6356 Add struct frame *f.
6357 (emacs_fixed_init): Initialize priv->f.
6358 (get_parent_class, emacs_fixed_set_min_size): Remove.
6359 (emacs_fixed_new): Set priv->f to argument.
6360 (emacs_fixed_get_preferred_width)
6361 (emacs_fixed_get_preferred_height): Use min_width/height from
6362 frames size_hint to set minimum and natural (Bug#8919).
6363 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6364 and use min_width/height from frames size_hint to set
6365 min_width/height (Bug#8919).
6366
6367 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6368 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6369 Fix indentation.
c7e73be5 6370
cf99dcf8
EZ
63712011-06-26 Eli Zaretskii <eliz@gnu.org>
6372
6373 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6374 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6375 called at ZV.
6376
029529ac
CY
63772011-06-26 Chong Yidong <cyd@stupidchicken.com>
6378
6379 * process.c (wait_reading_process_output): Bypass select if
6380 waiting for a cell while ignoring keyboard input, and input is
6381 pending. Suggested by Jan Djärv (Bug#8869).
6382
7a7ef429
PE
63832011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6384
6385 Use gnulib's dup2 module instead of rolling our own.
6386 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6387
11fdef7d 63882011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6389
6390 * dispnew.c (scrolling_window): Before scrolling, turn off a
6391 mouse-highlight in the window being scrolled.
6392
cd3520a4
JB
63932011-06-24 Juanma Barranquero <lekktu@gmail.com>
6394
6395 Move DEFSYM to lisp.h and use everywhere.
6396
6397 * character.h (DEFSYM): Move declaration...
6398 * lisp.h (DEFSYM): ...here.
6399
6400 * gnutls.c:
6401 * minibuf.c:
6402 * w32menu.c:
6403 * w32proc.c:
6404 * w32select.c: Don't include character.h.
6405
6406 * alloc.c (syms_of_alloc):
6407 * buffer.c (syms_of_buffer):
6408 * bytecode.c (syms_of_bytecode):
6409 * callint.c (syms_of_callint):
6410 * casefiddle.c (syms_of_casefiddle):
6411 * casetab.c (init_casetab_once):
6412 * category.c (init_category_once, syms_of_category):
6413 * ccl.c (syms_of_ccl):
6414 * cmds.c (syms_of_cmds):
6415 * composite.c (syms_of_composite):
6416 * dbusbind.c (syms_of_dbusbind):
6417 * dired.c (syms_of_dired):
6418 * dispnew.c (syms_of_display):
6419 * doc.c (syms_of_doc):
6420 * editfns.c (syms_of_editfns):
6421 * emacs.c (syms_of_emacs):
6422 * eval.c (syms_of_eval):
6423 * fileio.c (syms_of_fileio):
6424 * fns.c (syms_of_fns):
6425 * frame.c (syms_of_frame):
6426 * fringe.c (syms_of_fringe):
6427 * insdel.c (syms_of_insdel):
6428 * keymap.c (syms_of_keymap):
6429 * lread.c (init_obarray, syms_of_lread):
6430 * macros.c (syms_of_macros):
6431 * msdos.c (syms_of_msdos):
6432 * print.c (syms_of_print):
6433 * process.c (syms_of_process):
6434 * search.c (syms_of_search):
6435 * sound.c (syms_of_sound):
6436 * syntax.c (init_syntax_once, syms_of_syntax):
6437 * terminal.c (syms_of_terminal):
6438 * textprop.c (syms_of_textprop):
6439 * undo.c (syms_of_undo):
6440 * w32.c (globals_of_w32):
6441 * window.c (syms_of_window):
6442 * xdisp.c (syms_of_xdisp):
6443 * xfaces.c (syms_of_xfaces):
6444 * xfns.c (syms_of_xfns):
6445 * xmenu.c (syms_of_xmenu):
6446 * xsettings.c (syms_of_xsettings):
6447 * xterm.c (syms_of_xterm): Use DEFSYM.
6448
4228cf16
TZ
64492011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6450
cd3520a4 6451 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6452
7fcccf1e
PE
64532011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6454
7efb4e0e
PE
6455 Integer and buffer overflow fixes (Bug#8873).
6456
ff5844ad
PE
6457 * print.c (printchar, strout): Check for string overflow.
6458 (PRINTPREPARE, printchar, strout):
6459 Don't set size unless allocation succeeds.
6460
90532f02
PE
6461 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6462 for sizes. Check for string overflow more accurately.
6463 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6464
6d84508d
PE
6465 * macros.c: Integer and buffer overflow fixes.
6466 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6467 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6468 Use ptrdiff_t, not int, for sizes.
6469 Don't increment bufsize until after realloc succeeds.
6470 Check for size-calculation overflow.
6471 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6472
437b2cb4
PE
6473 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6474
8b9ac8b4
PE
6475 * lread.c: Integer overflow fixes.
6476 (read_integer): Radix is now EMACS_INT, not int,
6477 to improve quality of diagnostics for out-of-range radices.
6478 Calculate buffer size correctly for out-of-range radices.
6479 (read1): Check for integer overflow in radices, and in
6480 read-circle numbers.
82cb60d3
PE
6481 (read_escape): Avoid int overflow.
6482 (Fload, openp, read_buffer_size, read1)
6483 (substitute_object_recurse, read_vector, read_list, map_obarray):
6484 Use ptrdiff_t, not int, for sizes.
6485 (read1): Use EMACS_INT, not int, for sizes.
20270765 6486 Check for size overflow.
8b9ac8b4 6487
7fcccf1e
PE
6488 * image.c (cache_image): Check for size arithmetic overflow.
6489
bfbbd7e7
PE
6490 * lread.c: Integer overflow issues.
6491 (saved_doc_string_size, saved_doc_string_length)
6492 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6493 Now ptrdiff_t, not int.
6494 (read1): Don't assume doc string length fits in int. Check for
6495 out-of-range doc string lengths.
6496 (read_list): Don't assume file position fits in int.
39019e54 6497 (read_escape): Check for hex character overflow.
bfbbd7e7 6498
4e323265
LL
64992011-06-22 Leo Liu <sdl.web@gmail.com>
6500
6501 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6502 Move to minibuffer.el.
6503
85fece3e
PE
65042011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6505
20b84ce9 6506 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6507 The following patches are for when GLYPH_DEBUG && !XASSERT.
6508 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6509 * dispnew.c (flush_stdout):
6510 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6511 Mark as externally visible.
6512 * dispnew.c (check_window_matrix_pointers): Now static.
6513 * dispnew.c (window_to_frame_vpos):
6514 * xfns.c (unwind_create_frame):
6515 * xterm.c (x_check_font): Remove unused local.
6516 * scroll.c (CHECK_BOUNDS):
6517 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6518 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6519 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6520 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6521 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6522 Now static.
6523 (debug_method_add): Use va_list and vsprintf rather than relying
6524 on undefined behavior with wrong number of arguments.
6525 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6526 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6527 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6528 since we're not interested in debugging glyphs with old libraries.
6529 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6530 GCC 4.6.0's static checking.
6531
0766b489
PE
65322011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6533
31fd4b32
PE
6534 Integer overflow and signedness fixes (Bug#8873).
6535 A few related buffer overrun fixes, too.
6536
b79e8648
PE
6537 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6538
0766b489
PE
6539 * dispextern.h (struct face.stipple):
6540 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6541 (x_bitmap_mask, x_allocate_bitmap_record)
6542 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6543 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6544 (x_create_bitmap_from_xpm_data):
6545 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6546 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6547 (.bitmaps_last):
6548 * xfaces.c (load_pixmap):
6549 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6550 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6551 (.bitmaps_last, struct x_output.icon_bitmap):
6552 Use ptrdiff_t, not int, for bitmap indexes.
6553 (x_allocate_bitmap_record): Check for size overflow.
6554 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6555
b081724f
PE
6556 Use ptrdiff_t, not int, for overlay counts.
6557 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6558 * editfns.c (overlays_around, get_pos_property):
6559 * textprop.c (get_char_property_and_overlay):
6560 * xdisp.c (next_overlay_change, note_mouse_highlight):
6561 * xfaces.c (face_at_buffer_position):
21514da7
PE
6562 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6563 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6564 (Fnext_overlay_change, Fprevious_overlay_change)
6565 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6566 Use ptrdiff_t, not int, for sizes.
21514da7 6567 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6568
3de73e5e
PE
6569 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6570
2606c57b
PE
6571 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6572 (x_session_initialize): Do not assume string length fits in int.
6573
aaafe47a
PE
6574 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6575 This is unlikely, but can occur if DPI is outlandish.
6576
2674ddc8 6577 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6578 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6579
28154962
PE
6580 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6581 * xrdb.c (magic_file_p, search_magic_path):
6582 Omit last arg SUFFIX; it was always 0. All callers changed.
6583 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6584
7de51af5
PE
6585 * xfont.c (xfont_match): Avoid need for strlen.
6586
25ed6cc3
PE
6587 * xfns.c: Don't assume strlen fits in int.
6588 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6589
4eab31dd
PE
6590 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6591 not unsigned long, as we prefer signed integers. All callers changed.
6592 Detect integer overflow in repeat count.
6593 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6594 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6595
171e2a58
PE
6596 * termcap.c: Don't assume sizes fit in int and never overflow.
6597 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6598 (gobble_line): Check for size-calculation overflow.
6599
ad39faca 6600 * minibuf.c (Fread_buffer):
6e5bb2dc 6601 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6602 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6603 Don't assume string length fits in int.
6604
52c61c22 6605 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6606 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6607
b5b8c9e5
PE
6608 * font.c: Don't assume string length fits in int.
6609 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6610 Use ptrdiff_t, not int.
ccd6111c
PE
6611 (font_intern_prop): Don't assume string length fits in int.
6612 Don't assume integer property fits in fixnum.
6613 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6614
882f0d81 6615 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6616 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6617 Reformulate so as not to need the command string.
6618 Invoke gzip -cd rather than gunzip, as it's more portable.
6619 (lock_info_type, lock_file_1, lock_file):
6620 Don't assume pid_t and time_t fit in unsigned long.
6621 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6622 (current_lock_owner): Prefer signed type for sizes.
6623 Use memcpy, not strncpy, where memcpy is what is really wanted.
6624 Don't assume (via atoi) that time_t and pid_t fit in int.
6625 Check for time_t and/or pid_t out of range, e.g., via a network share.
6626 Don't alloca where an auto var works fine.
6627
93f4cf88
PE
6628 * fileio.c: Fix some integer overflow issues.
6629 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6630 Don't assume string length fits in int.
6631 (directory_file_name): Don't assume string length fits in long.
6632 (make_temp_name): Don't assume pid fits in int, or that its print
6633 length is less than 20.
6634
f3e92b69
PE
6635 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6636
1bfdaf10
PE
6637 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6638
35016e9a
PE
6639 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6640
3d1e65a1
PE
6641 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6642 We prefer signed integers, even for size calculations.
6643
0b963a93
PE
6644 * emacs.c: Don't assume string length fits in 'int'.
6645 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6646 (main): Don't invoke strlen when not needed.
6647
573f4b54
PE
6648 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6649 (XD_DEBUG_MESSAGE): Don't waste a byte.
6650
989f33ba
PE
6651 * callproc.c (getenv_internal_1, getenv_internal)
6652 (Fgetenv_internal):
965d34eb
PE
6653 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6654
e4d29b33
PE
6655 * lread.c (invalid_syntax): Omit length argument.
6656 All uses changed. This doesn't fix a bug, but it simplifies the
6657 code away from its former Hollerith-constant appearance, and it's
6658 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6659 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6660
eb49b136
PE
6661 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6662 This didn't break anything, but it didn't help either.
6663 It's confusing to put a bogus integer in a place where the actual
6664 value does not matter.
9f62aeb1 6665 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6666 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6667
15375a22
PE
6668 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6669 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6670 implementation.
b61cc01c
PE
6671 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6672 We prefer signed types, and the value cannot exceed the EMACS_INT
6673 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6674 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6675 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6676 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6677
53b2623d
PE
6678 * indent.c (sane_tab_width): New function.
6679 (current_column, scan_for_column, Findent_to, position_indentation)
6680 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6681 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6682
51cab52b 6683 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6684
f2ed8a70
PE
6685 * lisp.h (lint_assume): New macro.
6686 * composite.c (composition_gstring_put_cache):
6687 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6688
abe80cc6
PE
6689 * editfns.c, insdel.c:
6690 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6691
b02c740e
PE
6692 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6693
ebc96716
PE
6694 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6695
b4e50fa0 6696 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6697 Use much-faster test for byte-length change.
311d5d7c 6698 Don't assume string byte-length fits in 'int'.
a4cf38e4 6699 Check that character arg fits in 'int'.
85461888 6700 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6701
c0c1ee9f
PE
6702 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6703
a498d7f4
PE
6704 * fns.c (concat): Catch string overflow earlier.
6705 Do not rely on integer wraparound.
6706
51cab52b
PE
6707 * dispextern.h (struct it.overlay_strings_charpos)
6708 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6709 * xdisp.c (forward_to_next_line_start)
6710 (back_to_previous_visible_line_start)
6711 (reseat_at_next_visible_line_start, next_element_from_buffer):
6712 Don't arbitrarily truncate the value of 'selective' to int.
6713
76031fad
PE
6714 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6715
5eb55db9
PE
6716 * composite.c: Don't truncate sizes to 'int'.
6717 (composition_gstring_p, composition_reseat_it)
6718 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6719 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6720 not EMACS_UINT, for indexes.
5eb55db9 6721
0703a717
PE
6722 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6723
d6202519
PE
6724 * buffer.c: Include <verify.h>.
6725 (struct sortvec.priority, struct sortstr.priority):
8961a454 6726 Now EMACS_INT, not int.
c20998a7 6727 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6728 (struct sortstr.size, record_overlay_string)
6729 (struct sortstrlist.size, struct sortlist.used):
6730 Don't truncate size to int.
6731 (record_overlay_string): Check for size-calculation overflow.
d6202519 6732 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6733
d5a19415
JM
67342011-06-22 Jim Meyering <meyering@redhat.com>
6735
029529ac 6736 Don't leak an XBM-image-sized buffer
d5a19415
JM
6737 * image.c (xbm_load): Free the image buffer after using it.
6738
a9041e6c
PE
67392011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6740
6741 Port to Sun C.
6742 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6743 that Sun C diagnosed.
6744 * fns.c (secure_hash): Fix pointer signedness issue.
6745 * intervals.c (static_offset_intervals): New function.
6746 (offset_intervals): Use it.
6747
7f3f739f
LL
67482011-06-21 Leo Liu <sdl.web@gmail.com>
6749
6750 * deps.mk (fns.o):
6751 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6752 sha512.h.
6753
6754 * fns.c (secure_hash): Rename from crypto_hash_function and change
6755 the first arg to accept symbols.
5b66d427 6756 (Fsecure_hash): New primitive.
7f3f739f
LL
6757 (syms_of_fns): New symbols.
6758
76147d94
DD
67592011-06-20 Deniz Dogan <deniz@dogan.se>
6760
6761 * process.c (Fset_process_buffer): Clarify return value in
6762 docstring.
6763
7d7d0045
CY
67642011-06-18 Chong Yidong <cyd@stupidchicken.com>
6765
6766 * dispnew.c (add_window_display_history): Use BVAR.
6767
6768 * xdisp.c (debug_method_add): Use BVAR.
6769 (check_window_end, dump_glyph_matrix, dump_glyph)
6770 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6771
6772 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6773 Likewise.
6774
6775 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6776 check till after the cache is created in init_frame_faces.
6777
ff2bc410
SM
67782011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6779
6780 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6781
28177add
PE
67822011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6783
dd3482fe
PE
6784 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6785 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6786 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6787
393d71f3 6788 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
6789 * fileio.c (Finsert_file_contents):
6790 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6791 Remove the old (too-loose) buffer overflow checks.
6792 They weren't needed, since make_gap checks for buffer overflow.
6793 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6794 The old code merely checked for Emacs fixnum overflow, and relied
6795 on undefined (wraparound) behavior. The new code avoids undefined
6796 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6797
2e6813b0 6798 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
6799 Tune. Don't use wider integers than needed. Don't use alloca.
6800 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 6801
599a9e4f
PE
6802 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6803
99561444
PE
6804 * insdel.c, lisp.h (buffer_overflow): New function.
6805 (insert_from_buffer_1, replace_range, replace_range_2):
6806 * insdel.c (make_gap_larger):
6807 * editfns.c (Finsert_char):
6808 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6809
28177add
PE
6810 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6811
e69dafad
PE
68122011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6813
4baa020d 6814 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 6815
b1c46f02
PE
6816 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6817 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6818
e69dafad
PE
6819 * fileio.c: Don't assume EMACS_INT fits in off_t.
6820 (emacs_lseek): New static function.
6821 (Finsert_file_contents, Fwrite_region): Use it.
6822 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6823
566684ea
PE
6824 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6825
e6966cd6
PE
6826 * fns.c: Don't overflow int when computing a list length.
6827 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6828 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6829 truncation on 64-bit hosts. Check for QUIT every
6830 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6831 faster and is responsive enough.
6832 (Flength): Report an error instead of overflowing an integer.
6833 (Fsafe_length): Return a float if the value is not representable
6834 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 6835 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 6836 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 6837
dd0b0efb
PE
6838 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6839 (header_size, word_size): New constants.
6840 (allocate_vectorlike): Don't check size overflow here.
6841 (allocate_vector): Check it here instead, since this is the only
6842 caller of allocate_vectorlike that could cause overflow.
6843 Check that the new vector's length is representable as a fixnum.
6844
86fe5cfe
PE
6845 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6846 The previous code was bogus. For example, next_almost_prime (32)
6847 returned 39, which is undesirable as it is a multiple of 3; and
6848 next_almost_prime (24) returned 25, which is a multiple of 5 so
6849 why was the code bothering to check for multiples of 7?
6850
80e88859
PE
6851 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6852
4a2f0ad6
PE
6853 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6854
f66c7cf8
PE
6855 Variadic C functions now count arguments with ptrdiff_t.
6856 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6857 Back then I didn't know that the Emacs coding style prefers signed int.
6858 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
6859 were being counted with int, which may truncate counts on 64-bit
6860 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
6861 * lisp.h (struct Lisp_Subr.function.aMANY)
6862 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6863 Arg counts are now ptrdiff_t, not size_t.
6864 All variadic functions and their callers changed accordingly.
6865 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6866 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6867 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6868 * callint.c (Fcall_interactively): Check arg count for overflow,
6869 to avoid potential buffer overrun. Use signed char, not 'int',
6870 for 'varies' array, so that we needn't bother to check its size
6871 calculation for overflow.
6872 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6873 * eval.c (apply_lambda):
6874 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6875 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6876 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6877
a1759b76
PE
6878 * callint.c (Fcall_interactively): Don't use index var as event count.
6879
d96be9fc
PE
6880 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6881 * mem-limits.h (SIZE): Remove; no longer used.
6882
a690a978 6883 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 6884
578c21e6
PE
6885 Remove unnecessary casts.
6886 * xterm.c (x_term_init):
6887 * xfns.c (x_set_border_pixel):
6888 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6889 These aren't needed now that we assume ANSI C.
6890
96f53c6c
PE
6891 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6892 It's more likely to cause problems (due to unsigned overflow)
6893 than to cure them.
6894
83c77d31
PE
6895 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6896
ee2079f1
PE
6897 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6898
6da65536
PE
6899 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6900
7147c4a4
PE
6901 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6902
193e32d9
PE
6903 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6904
e5533da6
PE
6905 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6906
9910e595
PE
6907 GLYPH_CODE_FACE returns EMACS_INT, not int.
6908 * dispextern.h (merge_faces):
6909 * xfaces.c (merge_faces):
01103c44
PE
6910 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6911 Don't assume EMACS_INT fits in int.
9910e595 6912
2638320e
PE
6913 * character.h (CHAR_VALID_P): Remove unused parameter.
6914 * fontset.c, lisp.h, xdisp.c: All uses changed.
6915
045eb8d9
PE
6916 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6917
c1f134b5
PE
6918 * fns.c (concat): Minor tuning based on overflow analysis.
6919 This doesn't fix any bugs. Use int to hold character, instead
6920 of constantly refetching from Emacs object. Use XFASTINT, not
6921 XINT, for value known to be a character. Don't bother comparing
6922 a single byte to 0400, as it's always less.
6923
395fcb93 6924 * floatfns.c (Fexpt):
327eeec8
PE
6925 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6926
abbd3d23
PE
6927 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6928 for characters.
6929
684a03ef
PE
6930 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6931
0fed43f3
PE
6932 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6933 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6934 incorrectly succeed when S was a string, because 4294967386 was
6935 truncated before it was used.
6936
8fd02eb7
PE
6937 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6938 Otherwise, an out-of-range integer could cause undefined behavior
6939 on a 64-bit host.
6940
f8c86b69
PE
6941 * composite.c: Use int, not EMACS_INT, for characters.
6942 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6943 EMACS_INT, for values that are known to be in character range.
6944 This doesn't fix any bugs but is the usual style inside Emacs and
6945 may generate better code on 32-bit machines.
6946
34206dd2
PE
6947 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6948 This is for reasons similar to the recent CHAR_STRING fix.
6949 * charset.c (Fencode_char): Check that character arg is actually
6950 a character. Pass an int to ENCODE_CHAR.
6951 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6952 wider than 'int', as a compile-time check to prevent future regressions
6953 in this area.
6954
c5958d4c 6955 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
6956
6957 Make sure a 64-bit char is never passed to CHAR_STRING.
6958 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6959 by silently ignoring the top 32 bits, allowing some values
6960 that were far too large to be valid characters.
6961 * character.h: Include <verify.h>.
6962 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6963 arguments are no wider than unsigned, as a compile-time check
6964 to prevent future regressions in this area.
6965 * data.c (Faset):
01103c44 6966 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
6967 (Fsubst_char_in_region):
6968 * fns.c (concat):
6969 * xdisp.c (decode_mode_spec_coding):
6970 Adjust to CHAR_STRING's new requirement.
6971 * editfns.c (Finsert_char, Fsubst_char_in_region):
6972 * fns.c (concat): Check that character args are actually
6973 characters. Without this test, these functions did the wrong
6974 thing with wildly out-of-range values on 64-bit hosts.
6975
d37ca623
PE
6976 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6977 These casts should not be needed on 32-bit hosts, either.
6978 * keyboard.c (read_char):
6979 * lread.c (Fload): Remove casts to unsigned.
6980
ea204efb
PE
6981 * lisp.h (UNSIGNED_CMP): New macro.
6982 This fixes comparison bugs on 64-bit hosts.
6983 (ASCII_CHAR_P): Use it.
6984 * casefiddle.c (casify_object):
01103c44 6985 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
6986 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6987 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6988 * dispextern.h (FACE_FROM_ID):
6989 * keyboard.c (read_char): Use UNSIGNED_CMP.
6990
41cb286c
PE
6991 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6992 not to EMACS_INT, to avoid GCC warning.
6993
4a1b9832
PE
6994 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6995
55daad71
PE
6996 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6997 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6998 isn't needed on 32-bit machines.
8f95c75c 6999
01103c44
PE
7000 * buffer.c (Fgenerate_new_buffer_name):
7001 Use EMACS_INT for count, not int.
0ceccced 7002 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7003
7004 * data.c (Qcompiled_function): Now static.
7005
c6f072e7
PE
7006 * window.c (window_body_lines): Now static.
7007
20ce5912
PE
7008 * image.c (gif_load): Rename local to avoid shadowing.
7009
9c4c5f81
PE
7010 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7011 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7012 * alloc.c (make_save_value): Integer argument is now of type
7013 ptrdiff_t, not int.
7014 (mark_object): Use ptrdiff_t, not int.
7015 * lisp.h (pD): New macro.
7016 * print.c (print_object): Use it.
7017
c0c5c8ae
PE
7018 * alloc.c: Use EMACS_INT, not int, to count objects.
7019 (total_conses, total_markers, total_symbols, total_vector_size)
7020 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7021 (total_free_floats, total_floats, total_free_intervals)
7022 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7023 Now EMACS_INT, not int. All uses changed.
7024 (Fgarbage_collect): Compute overall total using a double, so that
7025 integer overflow is less likely to be a problem. Check for overflow
7026 when converting back to an integer.
5a25e253
PE
7027 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7028 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7029 These were 'int' variables that could overflow on 64-bit hosts;
7030 they were never used, so remove them instead of repairing them.
211a0b2a 7031 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7032 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7033 Previously, this ceilinged at INT_MAX, but that doesn't work on
7034 64-bit machines.
e46bb31a 7035 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7036
c78baabf 7037 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7038 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7039 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7040 when a (possibly-narrower) signed value would do just as well.
7041 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7042
c9d624c6
PE
7043 * alloc.c: Catch some string size overflows that we were missing.
7044 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7045 for convenience in STRING_BYTES_MAX.
7046 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7047 The definition here is exact; the one in lisp.h was approximate.
7048 (allocate_string_data): Check for string overflow. This catches
7049 some instances we weren't catching before. Also, it catches
7050 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7051 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7052 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7053
c9d624c6
PE
7054 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7055 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7056 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7057
353032ce
PE
7058 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7059
2bccce07
PE
7060 * alloc.c (Fmake_string): Check for out-of-range init.
7061
0ac30604
SM
70622011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7063
7064 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7065
c195f2de
JD
70662011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7067
7068 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7069 xg_get_default_scrollbar_width.
7070
7071 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7072 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7073 (style_changed_cb): Call update_theme_scrollbar_width and call
7074 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7075 all frames (Bug#8505).
7076 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7077 Call gtk_window_set_resizable if HAVE_GTK3.
7078 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7079 and height if HAVE_GTK3 (Bug#8505).
7080 (scroll_bar_width_for_theme): New variable.
7081 (update_theme_scrollbar_width): New function.
7082 (xg_get_default_scrollbar_width): Move code to
7083 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7084 (xg_initialize): Call update_theme_scrollbar_width.
7085
7086 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7087
7088 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7089
e10ac9f1
MR
70902011-06-12 Martin Rudalics <rudalics@gmx.at>
7091
7092 * frame.c (make_frame): Call other_buffer_safely instead of
7093 other_buffer.
7094
7095 * window.c (temp_output_buffer_show): Call display_buffer with
7096 second argument Vtemp_buffer_show_specifiers and reset latter
7097 immediately after the call.
7098 (Vtemp_buffer_show_specifiers): New variable.
7099 (auto_window_vscroll_p, next_screen_context_lines)
7100 (Vscroll_preserve_screen_position): Remove leading asterisks from
7101 doc-strings.
7102
2d3c217e 71032011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7104
7b7f97e8 7105 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7106 * buffer.c (Qclone_number): Remove for now, as it's unused.
7107 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7108 (record_buffer): Remove unused local.
7109 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7110 (set_frame_buffer_list): Remove; unused.
7111 * frame.h (other_visible_frames): Remove decl.
7112 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7113 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7114 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7115 if HAVE_GPM.
7116 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7117 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7118 Define only if HAVE_GPM.
7119 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7120 (update_hints_inhibit): Remove; never set. All uses removed.
7121 * widgetprv.h (emacsFrameClassRec): Remove decl.
7122 * window.c (delete_deletable_window): Now returns void, since it
7123 wasn't returning anything.
7124 (compare_window_configurations): Remove unused locals.
7125 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7126 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7127 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7128 the same widths as pointers. This follows up on the 2011-05-06 patch.
7129 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7130 * xterm.h: Likewise.
7131 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7132
1384b89e
JB
71332011-06-12 Juanma Barranquero <lekktu@gmail.com>
7134
7135 * makefile.w32-in: Update dependencies.
7136 (LISP_H): Add lib/intprops.h.
7137
1100a63c
CY
71382011-06-11 Chong Yidong <cyd@stupidchicken.com>
7139
7140 * image.c (gif_load): Add animation frame delay to the metadata.
7141 (syms_of_image): Use DEFSYM. New symbol `delay'.
7142
6198ccd0
MR
71432011-06-11 Martin Rudalics <rudalics@gmx.at>
7144
7145 * window.c (delete_deletable_window): Re-add.
7146 (Fset_window_configuration): Rewrite to handle dead buffers and
7147 consequently deletable windows.
7148 (window_tree, Fwindow_tree): Remove. Supply functionality in
7149 window.el.
7150 (compare_window_configurations): Simplify code.
7151
b6e3633c
AS
71522011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7153
1ab0dee5
AS
7154 * image.c (imagemagick_load_image): Fix type mismatch.
7155 (Fimagemagick_types): Likewise.
7156
b6e3633c
AS
7157 * window.h (replace_buffer_in_windows): Declare.
7158
9397e56f
MR
71592011-06-11 Martin Rudalics <rudalics@gmx.at>
7160
7161 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7162 Qclone_number. Remove external declaration of Qdelete_window.
7163 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7164 code.
640c8776
SM
7165 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7166 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7167 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7168 buffer list implementation.
7169 (other_buffer_safely): New function.
7170 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7171 calls to replace_buffer_in_windows and
7172 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7173 if allowed.
7174 (record_buffer): Inhibit quitting and rewrite using quittable
7175 functions. Run Qbuffer_list_update_hook if allowed.
7176 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7177 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7178 Move switch-to-buffer to window.el.
9397e56f
MR
7179 (bury-buffer): Move to window.el.
7180 (Vbuffer_list_update_hook): New variable.
7181
7182 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7183 section.
7184
7185 * window.h (resize_frame_windows): Move up in code.
7186 (Fwindow_frame): Remove EXFUN.
7187 (replace_buffer_in_all_windows): Remove prototype.
7188 (replace_buffer_in_windows_safely): Add prototype.
7189
7190 * window.c: Declare Qdelete_window static again. Move down
7191 declaration of select_count.
7192 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7193 (Fother_window): Move to window.el.
7194 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7195 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7196 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7197 window.el.
7198 (replace_buffer_in_windows): Implement by calling
7199 Qreplace_buffer_in_windows.
7200 (replace_buffer_in_all_windows): Remove with some functionality
7201 moved into replace_buffer_in_windows_safely.
7202 (replace_buffer_in_windows_safely): New function.
7203 (select_window_norecord, select_frame_norecord): Move in front
7204 of run_window_configuration_change_hook. Remove now obsolete
7205 declarations.
640c8776
SM
7206 (Fset_window_buffer): Rewrite doc-string.
7207 Call Qrecord_window_buffer.
9397e56f
MR
7208 (keys_of_window): Move binding for other-window to window.el.
7209
b50691aa
CY
72102011-06-11 Chong Yidong <cyd@stupidchicken.com>
7211
7212 * dispextern.h (struct image): Replace data member, whose int_val
7213 and ptr_val fields were not used by anything, with a single
7214 lisp_val object.
7215
7216 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7217 (gif_clear_image, gif_load, imagemagick_load_image)
7218 (gs_clear_image, gs_load): Callers changed.
7219
3f754b86
PE
72202011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7221
cca69397
PE
7222 * buffer.h: Include <time.h>, for time_t.
7223 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7224
109e28d0
PE
7225 Fix minor problems found by static checking.
7226
60737f02
PE
7227 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7228
4b66faf3
PE
7229 Make identifiers static if they are not used in other modules.
7230 * data.c (Qcompiled_function, Qframe, Qvector):
7231 * image.c (QimageMagick, Qsvg):
7232 * minibuf.c (Qmetadata):
7233 * window.c (resize_window_check, resize_root_window): Now static.
7234 * window.h (resize_window_check, resize_root_window): Remove decls.
7235
109e28d0
PE
7236 * window.c (window_deletion_count, delete_deletable_window):
7237 Remove; unused.
46a4ce9e
PE
7238 (window_body_lines): Now static.
7239 (Fdelete_other_windows_internal): Mark vars as initialized.
7240 Make sure 'resize_failed' is initialized.
7241 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7242 (resize_window_apply): Remove unused local.
7243 * window.h (delete_deletable_window): Remove decl.
7244
109e28d0 7245 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7246 (imagemagick_load_image): Fix pointer signedness problem by changing
7247 last arg from unsigned char * to char *. All uses changed.
7248 Also, fix a local for similar reasons.
7249 Remove unused locals. Remove locals to avoid shadowing.
7250 (fn_rsvg_handle_free): Remove; unused.
7251 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7252 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7253
3f754b86
PE
7254 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7255
2547adb1
CY
72562011-06-10 Chong Yidong <cyd@stupidchicken.com>
7257
7258 * image.c (gif_load): Fix omitted cast error introduced by
7259 2011-06-06 change.
7260
2c8e37d4
MR
72612011-06-10 Martin Rudalics <rudalics@gmx.at>
7262
7263 * window.h (resize_proportionally, orig_total_lines)
7264 (orig_top_line): Remove from window structure.
7265 (set_window_height, set_window_width, change_window_heights)
7266 (Fdelete_window): Remove prototypes.
7267 (resize_frame_windows): Remove duplicate declaration.
7268
440a42e3
EZ
72692011-06-10 Eli Zaretskii <eliz@gnu.org>
7270
7271 * window.h (resize_frame_windows, resize_window_check)
7272 (delete_deletable_window, resize_root_window)
7273 (resize_frame_windows): Declare prototypes.
7274
7275 * window.c (resize_window_apply): Make definition be "static" to
7276 match the prototype.
7277
562dd5e9
MR
72782011-06-10 Martin Rudalics <rudalics@gmx.at>
7279
7280 * window.c: Remove declarations of Qwindow_size_fixed,
7281 window_min_size_1, window_min_size_2, window_min_size,
7282 size_window, window_fixed_size_p, enlarge_window, delete_window.
7283 Remove static from declaration of Qdelete_window, it's
7284 temporarily needed by Fbury_buffer.
7285 (replace_window): Don't assign orig_top_line and
7286 orig_total_lines.
7287 (Fdelete_window, delete_window): Remove. Window deletion is
7288 handled by window.el.
640c8776
SM
7289 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7290 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7291 (Fdelete_other_windows): Remove. Deleting other windows is
7292 handled by window.el.
7293 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7294 handled in window.el.
7295 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7296 Window minimum sizes are handled in window.el.
7297 (shrink_windows, size_window, set_window_height)
7298 (set_window_width, change_window_heights, window_height)
7299 (window_width, CURBEG, CURSIZE, enlarge_window)
7300 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7301 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7302 handled in window.el.
7303 (make_dummy_parent): Rename to make_parent_window and give it a
7304 second argument horflag.
7305 (make_window): Don't set resize_proportionally any more.
7306 (Fsplit_window): Remove. Windows are split in window.el.
7307 (save_restore_action, save_restore_orig_size)
7308 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7309 Resize mini windows in window.el.
7310 (grow_mini_window, shrink_mini_window): Implement by calling
7311 Qresize_root_window_vertically, resize_window_check and
7312 resize_window_apply.
640c8776
SM
7313 (saved_window, Fset_window_configuration, save_window_save):
7314 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7315 resize_proportionally.
7316 (window_min_height, window_min_width): Move to window.el.
7317 (keys_of_window): Move bindings for delete-other-windows,
7318 split-window, delete-window and enlarge-window to window.el.
7319
7320 * buffer.c: Temporarily extern Qdelete_window.
7321 (Fbury_buffer): Temporarily call Qdelete_window instead of
7322 Fdelete_window (Fbury_buffer will move to window.el soon).
7323
7324 * frame.c (set_menu_bar_lines_1): Remove code handling
7325 orig_top_line and orig_total_lines.
7326
7327 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7328 set_window_height but set heights directly.
7329 (change_frame_size_1): Use resize_frame_windows.
7330
7331 * xdisp.c (init_xdisp): Don't use set_window_height but set
7332 heights directly.
7333
640c8776
SM
7334 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7335 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7336 run_window_configuration_change_hook.
7337
7338 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7339 instead of change_window_heights and run
7340 run_window_configuration_change_hook.
7341
1a13852e
MR
73422011-06-09 Martin Rudalics <rudalics@gmx.at>
7343
7344 * window.c (replace_window): Rename second argument REPLACEMENT to
7345 NEW. New third argument SETFLAG. Rewrite.
7346 (delete_window, make_dummy_parent): Call replace_window with
7347 third argument 1.
7348 (window_list_1): Move down in code.
7349 (run_window_configuration_change_hook): Move set_buffer part
7350 before select_frame_norecord part in order to unwind correctly.
7351 Rename count1 to count.
7352 (recombine_windows, delete_deletable_window, resize_root_window)
7353 (Fdelete_other_windows_internal)
7354 (Frun_window_configuration_change_hook, make_parent_window)
7355 (resize_window_check, resize_window_apply, Fresize_window_apply)
7356 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7357 (Fdelete_window_internal, Fresize_mini_window_internal):
7358 New functions.
1a13852e
MR
7359 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7360
f3d1777e
MR
73612011-06-08 Martin Rudalics <rudalics@gmx.at>
7362
496e208e
MR
7363 * window.h (window): Add some new members to window structure -
7364 normal_lines, normal_cols, new_total, new_normal, clone_number,
7365 splits, nest, prev_buffers, next_buffers.
7366 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7367 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7368
f3d1777e
MR
7369 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7370 Remove.
496e208e
MR
7371 (make_dummy_parent): Set new members of windows structure.
7372 (make_window): Move down in code. Handle new members of window
7373 structure.
7374 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7375 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7376 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7377 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7378 (Fset_window_next_buffers, Fset_window_clone_number):
7379 New functions.
496e208e
MR
7380 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7381 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7382 Doc-string fixes.
7383 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7384 Argument WINDOW can be now internal window too.
7385 (Fwindow_use_time): Move up in code.
7386 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7387 Rewrite doc-string.
7388 (Fset_window_configuration, saved_window)
7389 (Fcurrent_window_configuration, save_window_save): Handle new
7390 members of window structure.
b9e809c2
MR
7391 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7392 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7393 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7394 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7395 Qget_mru_window, Qresize_root_window,
7396 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7397 Qauto_buffer_name; staticpro them.
f3d1777e 7398
abde8f8c
MR
73992011-06-07 Martin Rudalics <rudalics@gmx.at>
7400
7401 * window.c (Fwindow_total_size, Fwindow_left_column)
7402 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7403 (Fwindow_list_1): New functions.
7404 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7405 (Fwindow_width, Fscroll_left, Fscroll_right):
7406 Use window_body_cols instead of window_box_text_cols.
7407 (delete_window, Fset_window_configuration):
7408 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7409 (delete_all_subwindows): Take a window as argument and not a
7410 structure. Rewrite.
190b47e6
MR
7411 (window_loop): Remove handling of GET_LRU_WINDOW and
7412 GET_LARGEST_WINDOW.
7413 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7414
7415 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7416 window_box_text_cols. delete_all_subwindows now takes a
7417 Lisp_Object as argument.
abde8f8c 7418
640c8776
SM
7419 * indent.c (compute_motion, Fcompute_motion):
7420 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7421
fa8a67e6
MR
7422 * frame.c (delete_frame): Call delete_all_subwindows with root
7423 window as argument.
7424
a54e3482
DC
74252011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7426
7427 * fns.c (Fputhash): Document return value.
7428
60002bf5
CY
74292011-06-06 Chong Yidong <cyd@stupidchicken.com>
7430
7431 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7432
0c671da6 74332011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7434
b862a52a 7435 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7436
be44ca6c
PE
7437 Check for overflow when converting integer to cons and back.
7438 * charset.c (Fdefine_charset_internal, Fdecode_char):
7439 Use cons_to_unsigned to catch overflow.
7440 (Fencode_char): Use INTEGER_TO_CONS.
7441 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7442 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7443 * data.c (long_to_cons, cons_to_long): Remove.
7444 (cons_to_unsigned, cons_to_signed): New functions.
7445 These signal an error for invalid or out-of-range values.
7446 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7447 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7448 * font.c (Ffont_variation_glyphs):
7449 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7450 * lisp.h: Include <intprops.h>.
7451 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7452 (cons_to_signed, cons_to_unsigned): New decls.
7453 (long_to_cons, cons_to_long): Remove decls.
7454 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7455 (Fprimitive_undo): Use CONS_TO_INTEGER.
7456 * xfns.c (Fx_window_property): Likewise.
7457 * xselect.c: Include <limits.h>.
7458 (x_own_selection, selection_data_to_lisp_data):
7459 Use INTEGER_TO_CONS.
7460 (x_handle_selection_request, x_handle_selection_clear)
7461 (x_get_foreign_selection, Fx_disown_selection_internal)
7462 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7463 (lisp_data_to_selection_data): Use cons_to_unsigned.
7464 (x_fill_property_data): Use cons_to_signed.
7465 Report values out of range.
7466
d1f3d2af
PE
7467 Check for buffer and string overflow more precisely.
7468 * buffer.h (BUF_BYTES_MAX): New macro.
7469 * lisp.h (STRING_BYTES_MAX): New macro.
7470 * alloc.c (Fmake_string):
7471 * character.c (string_escape_byte8):
7472 * coding.c (coding_alloc_by_realloc):
7473 * doprnt.c (doprnt):
7474 * editfns.c (Fformat):
7475 * eval.c (verror):
7476 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7477 since they may not be the same number.
7478 * editfns.c (Finsert_char):
7479 * fileio.c (Finsert_file_contents):
7480 Likewise for BUF_BYTES_MAX.
7481
dd52fcea
PE
7482 * image.c: Use ptrdiff_t, not int, for sizes.
7483 (slurp_file): Switch from int to ptrdiff_t.
7484 All uses changed.
7485 (slurp_file): Check that file size fits in both size_t (for
7486 malloc) and ptrdiff_t (for sanity and safety).
7487
7f9bbdbb
PE
7488 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7489 if b->modtime has its maximal value.
7490
dfe18f82
PE
7491 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7492
84acfcf0
PE
7493 Don't assume time_t can fit into int.
7494 * buffer.h (struct buffer.modtime): Now time_t, not int.
7495 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7496 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7497
ccd9a01a
PE
7498 Minor fixes for signed vs unsigned integers.
7499 * character.h (MAYBE_UNIFY_CHAR):
7500 * charset.c (maybe_unify_char):
7501 * keyboard.c (read_char, reorder_modifiers):
7502 XINT -> XFASTINT, since the integer must be nonnegative.
7503 * ftfont.c (ftfont_spec_pattern):
7504 * keymap.c (access_keymap, silly_event_symbol_error):
7505 XUINT -> XFASTINT, since the integer must be nonnegative.
7506 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7507 since it makes no difference and we prefer signed.
7508 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7509 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7510 nonnegative.
7511
d6d100dd
SM
75122011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7513
7514 * window.h (Fwindow_frame): Declare.
7515
2b6148e4
PE
75162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7517
7518 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7519 (SPARE_MEMORY): Always define.
7520 (LARGE_REQUEST): Remove.
7521 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7522
f230ecc9
MR
75232011-06-06 Martin Rudalics <rudalics@gmx.at>
7524
727e958e
MR
7525 * lisp.h: Move EXFUNS for Fframe_root_window,
7526 Fframe_first_window and Fset_frame_selected_window to window.h.
7527
7528 * window.h: Move EXFUNS for Fframe_root_window,
7529 Fframe_first_window and Fset_frame_selected_window here from
7530 lisp.h.
7531
7532 * frame.c (Fwindow_frame, Fframe_first_window)
7533 (Fframe_root_window, Fframe_selected_window)
7534 (Fset_frame_selected_window): Move to window.c.
7535 (Factive_minibuffer_window): Move to minibuf.c.
7536 (Fother_visible_frames_p): New function.
7537
7538 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7539
f230ecc9
MR
7540 * window.c (decode_window, decode_any_window): Move up in code.
7541 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7542 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7543 (Fwindow_buffer): Move up and rewrite doc-string.
7544 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7545 (Fwindow_prev): New functions.
727e958e
MR
7546 (Fwindow_frame): Move here from frame.c. Accept any window as
7547 argument.
7548 (Fframe_root_window, Fframe_first_window)
7549 (Fframe_selected_window): Move here from frame.c. Accept frame
7550 or arbitrary window as argument. Update doc-strings.
7551 (Fminibuffer_window): Move up in code.
7552 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7553 (Fset_frame_selected_window): Move here from frame.c.
7554 Marginal rewrite.
727e958e
MR
7555 (Fselected_window, select_window, Fselect_window): Move up in
7556 code. Minor doc-string fixes.
f230ecc9 7557
4d09bcf6
PE
75582011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7559
7560 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7561 Do not assume that spare memory exists; that assumption is valid
7562 only if SYSTEM_MALLOC.
7563 (LARGE_REQUEST): New macro, so that the issue of large requests
7564 is separated from the issue of spare memory.
7565
810928a2
AS
75662011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7567
172418ad
AS
7568 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7569 format. (Bug#8806)
7570
43f862f7
AS
7571 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7572
810928a2
AS
7573 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7574 before statements.
7575
a059fe24
JD
75762011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7577
7578 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7579
7580 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7581
7582 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7583 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7584
989bf368
JB
75852011-06-05 Juanma Barranquero <lekktu@gmail.com>
7586
7587 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7588
4b80f674
CY
75892011-06-04 Chong Yidong <cyd@stupidchicken.com>
7590
7591 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7592 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7593 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7594 New error handlers.
4b80f674
CY
7595 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7596 Obey Vx_select_enable_clipboard_manager. Catch errors in
7597 x_clipboard_manager_save (Bug#8779).
7598 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7599 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7600
99a33b77 76012011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7602
7603 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7604
99a33b77 76052011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7606
7607 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7608 in the current matrix if keep_current_p is non-zero.
7609
8264569d
EZ
76102011-06-04 Eli Zaretskii <eliz@gnu.org>
7611
7612 * bidi.c (bidi_level_of_next_char): Fix last change.
7613
57f97249
EZ
76142011-06-03 Eli Zaretskii <eliz@gnu.org>
7615
fec2107c 7616 Support bidi reordering of text covered by display properties.
57f97249 7617
fec2107c
EZ
7618 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7619 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7620 (bidi_cache_search, bidi_cache_iterator_state)
7621 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7622 (bidi_level_of_next_char, bidi_move_to_visually_next):
7623 Support character positions inside a run of characters covered by a
fec2107c
EZ
7624 display string.
7625 (bidi_paragraph_init, bidi_resolve_explicit_1)
7626 (bidi_level_of_next_char): Call bidi_fetch_char and
7627 bidi_fetch_char_advance instead of FETCH_CHAR and
7628 FETCH_CHAR_ADVANCE.
7629 (bidi_init_it): Initialize new members.
7630 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7631 definitions.
7632 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7633 instead of using explicit *_CHAR codes.
d6d100dd
SM
7634 (bidi_resolve_explicit, bidi_resolve_weak):
7635 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7636 bidirectional text is supported only in multibyte buffers.
7637 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7638 it to initialize the frame_window_p member of struct bidi_it.
7639 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7640 (bidi_resolve_explicit, bidi_resolve_weak)
7641 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7642 bidi_it->nchars is non-positive.
7643 (bidi_level_of_next_char): Don't try to lookup the cache for the
7644 next/previous character if nothing is cached there yet, or if we
7645 were just reseat()'ed to a new position.
c40e2fb2 7646
0e14fe90
EZ
7647 * xdisp.c (set_cursor_from_row): Set start and stop points
7648 according to the row's direction when priming the loop that looks
7649 for the glyph on which to display cursor.
7650 (single_display_spec_intangible_p): Function deleted.
7651 (display_prop_intangible_p): Reimplement to call
7652 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7653 Accept 3 additional arguments needed by handle_display_spec.
7654 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7655 values: lists, `(when COND...)' forms, etc.
7656 (single_display_spec_string_p): Support property values that are
7657 lists with the argument STRING its top-level element.
7658 (display_prop_string_p): Fix the condition for processing a
7659 property that is a list to be consistent with handle_display_spec.
fec2107c 7660 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7661 last portion of handle_display_prop.
7662 (compute_display_string_pos): Accept additional argument
7663 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7664 value of a `display' property is a "replacing spec".
7665 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7666 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7667 the display property, but just return a value indicating whether
7668 the display property will replace the characters it covers.
7669 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7670 frame_window_p members of struct bidi_it.
d6d100dd
SM
7671 (compute_display_string_pos, compute_display_string_end):
7672 New functions.
fec2107c
EZ
7673 (push_it): Accept second argument POSITION, where pop_it should
7674 jump to continue iteration.
7675 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7676
fec2107c
EZ
7677 * keyboard.c (adjust_point_for_property): Adjust the call to
7678 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7679
7680 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7681 (bidi_init_it): Update prototypes.
7682 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7683 (compute_display_string_pos, compute_display_string_end):
7684 Declare prototypes.
fec2107c
EZ
7685 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7686 EMACS_INT.
fc6f18ce 7687
40087514 76882011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7689
57f53182
PE
7690 Malloc failure behavior now depends on size of allocation.
7691 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7692 * lisp.h: Change signatures accordingly.
7693 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7694 All callers changed. (Bug#8762)
7695
7696 * gnutls.c: Use Emacs's memory allocators.
7697 Without this change, the gnutls library would invoke malloc etc.
7698 directly, which causes problems on non-SYNC_INPUT hosts, and which
7699 runs afoul of improving memory_full behavior. (Bug#8761)
7700 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7701 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7702 xfree instead of the default malloc, realloc, free.
7703 (Fgnutls_boot): No need to check for memory allocation failure,
7704 since xmalloc does that for us.
7705
ac32cd99 7706 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7707 * category.c (hash_get_category_set):
7708 * ccl.c (ccl_driver):
7709 * charset.c (Fdefine_charset_internal):
7710 * charset.h (struct charset.hash_index):
7711 * composite.c (get_composition_id, gstring_lookup_cache)
7712 (composition_gstring_put_cache):
7713 * composite.h (struct composition.hash_index):
7714 * dispextern.h (struct image.hash):
7715 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7716 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7717 (hashfn_equal, hashfn_user_defined, make_hash_table)
7718 (maybe_resize_hash_table, hash_lookup, hash_put)
7719 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7720 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7721 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7722 * image.c (make_image, search_image_cache, lookup_image)
7723 (xpm_put_color_table_h):
7724 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7725 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7726 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7727 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7728 * alloc.c (allocate_vectorlike):
7729 Check for overflow in vector size calculations.
7730 * ccl.c (ccl_driver):
7731 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7732 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7733 need to be updated by these changes.
40087514
PE
7734 * fns.c (make_hash_table, maybe_resize_hash_table):
7735 Check for integer overflow with large hash tables.
0de4bb68
PE
7736 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7737 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7738 (SXHASH_REDUCE): New macro.
7739 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7740 Use it instead of discarding useful hash info with large hash values.
7741 (sxhash_float): New function.
7742 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7743 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7744 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7745 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
7746 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7747 Adjust signatures to match updated version of code.
7748 (consing_since_gc): Now EMACS_INT, since a single hash table can
7749 use more than INT_MAX bytes.
7750
698d32e2
DN
77512011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7752
7753 Make it possible to build with GCC-4.6+ -O2 -flto.
7754
7755 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7756
fd6fa53f
SM
77572011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7758
7759 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7760 Call minibuffer-inactive-mode.
7761
864db017
JB
77622011-05-31 Juanma Barranquero <lekktu@gmail.com>
7763
7764 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7765 Update dependencies.
7766
2ad0baf4
DN
77672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7768
7769 * data.c (init_data): Remove code for UTS, this system is not
7770 supported anymore.
7771
4fcc2638
DN
77722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7773
7774 Don't force ./temacs to start in terminal mode.
7775
7776 * frame.c (make_initial_frame): Initialize faces in all cases, not
7777 only when CANNOT_DUMP is defined.
7778 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7779
c56e0fd5
DN
77802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7781
7782 * dispnew.c (add_window_display_history): Use const for the string
7783 pointer. Remove declaration, not needed.
7784
333d54da 77852011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 7786
55d4c1b2 7787 Use 'inline', not 'INLINE'.
333d54da 7788 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
7789 * alloc.c, fontset.c (INLINE): Remove.
7790 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7791 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7792 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7793 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7794 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7795
738db178
DN
77962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7797
7798 Make it possible to run ./temacs.
7799
7800 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7801 syms_of_callproc does the same thing. Remove test for
7802 "initialized", do it in the caller.
7803 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7804
620c53a6
SM
78052011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7806
7807 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7808 (read_minibuf): Use get_minibuffer.
7809 (syms_of_minibuf): Use DEFSYM.
7810 (Qmetadata): New var.
7811 * data.c (Qbuffer): Don't make it static.
7812 (syms_of_data): Use DEFSYM.
7813
e003a292
PE
78142011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7815
7816 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7817 (CCL_CODE_MIN): New macro.
7818
ed008a6d
PE
78192011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7820
3687c2ef
PE
7821 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7822
ed008a6d
PE
7823 * eval.c (Qdebug): Now static.
7824 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7825 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7826 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7827
d66c4c7c
CY
78282011-05-29 Chong Yidong <cyd@stupidchicken.com>
7829
7830 * image.c: Various fixes to ImageMagick code comments.
7831 (Fimagemagick_types): Doc fix.
7832
5fbc2025
PE
78332011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7834
0196f88a
PE
7835 Minor fixes prompted by GCC 4.6.0 warnings.
7836
7837 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7838
5fbc2025
PE
7839 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7840 (x_clipboard_manager_save_all): Move extern decl to ...
7841 * xterm.h: ... here, so that it can be checked for consistency.
7842
1dd3c2d9
CY
78432011-05-29 Chong Yidong <cyd@stupidchicken.com>
7844
7845 * xselect.c (x_clipboard_manager_save_frame)
7846 (x_clipboard_manager_save_all): New functions.
7847 (Fx_clipboard_manager_save): Lisp function deleted.
7848
7849 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7850 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7851
7852 * xterm.h: Update prototype.
7853
5ba6571d
WX
78542011-05-28 William Xu <william.xwl@gmail.com>
7855
7856 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7857 exiting (Bug#8239).
7858
3eaff834
JM
78592011-05-28 Jim Meyering <meyering@redhat.com>
7860
e1900994 7861 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
7862 * fns.c (to_uchar): Define.
7863 (crypto_hash_function): Use it to convert some newly-signed
7864 variables to unsigned, to avoid sign-extension bugs. For example,
7865 without this change, (md5 "truc") would evaluate to
7866 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7867 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 7868 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 7869
0f6990a7
PE
78702011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7871
7872 Integer overflow fixes.
c8a9ca5a 7873
08686060
PE
7874 * dbusbind.c: Serial number integer overflow fixes.
7875 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
7876 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7877 to hold a serial number that is too large for a fixnum.
7878 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7879 Check for serial numbers out of range. Decode any serial number
59568bf0 7880 that was so large that it became a float. (Bug#8722)
08686060 7881
2d1fc3c7
PE
7882 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7883 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7884 Use XFASTINT rather than XUINT when numbers are nonnegative.
7885 (xd_append_arg, Fdbus_method_return_internal):
7886 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7887 arguments, check that Lisp number is nonnegative, rather than
59568bf0 7888 silently wrapping negative numbers around. (Bug#8722)
30217ff0 7889 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 7890 (Bug#8722)
2d1fc3c7 7891
c8a9ca5a
PE
7892 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7893
519e1d69
PE
7894 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7895
6df6ae42 7896 ccl: Add integer overflow checks.
30569699
PE
7897 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7898 (IN_INT_RANGE): New macros.
7899 (ccl_driver): Use them to check for integer overflow when
7900 decoding a CCL program. Many of the new checks are whether XINT (x)
7901 fits in int; it doesn't always, on 64-bit hosts. The new version
7902 doesn't catch all possible integer overflows, but it's an
847044ea 7903 improvement. (Bug#8719)
30569699 7904
c11285dc
PE
7905 * alloc.c (make_event_array): Use XINT, not XUINT.
7906 There's no need for unsigned here.
7907
fdccd48e
PE
7908 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7909 This follows up to the 2011-05-06 change that substituted uintptr_t
7910 for EMACS_INT. This case wasn't caught back then.
7911
37910ab2
PE
7912 Rework Fformat to avoid integer overflow issues.
7913 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7914 now (part of C89). Include <verify.h>.
7915 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7916 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7917 (Fformat): Avoid the prepass trying to compute sizes; it was only
7918 approximate and thus did not catch overflow reliably. Instead, walk
7919 through the format just once, formatting and computing sizes as we go,
7920 checking for integer overflow at every step, and allocating a larger
7921 buffer as needed. Keep track separately whether the format is
7922 multibyte. Keep only the most-recently calculated precision, rather
7923 than them all. Record whether each argument has been converted to
7924 string. Use EMACS_INT, not int, for byte and char and arg counts.
7925 Support field widths and precisions larger than INT_MAX. Avoid
7926 sprintf's undefined behavior with conversion specifications such as %#d
7927 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7928 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7929 formatting out-of-range floating point numbers with int
9173deec 7930 formats. (Bug#8668)
37910ab2 7931
2e6578fb
PE
7932 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7933
0ae6bdee
PE
7934 * data.c: Avoid integer truncation in expressions involving floats.
7935 * data.c: Include <intprops.h>.
7936 (arith_driver): When there's an integer overflow in an expression
7937 involving floating point, convert the integers to floating point
7938 so that the resulting value does not suffer from catastrophic
7939 integer truncation. For example, on a 64-bit host (* 4
7940 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7941 Do not rely on undefined behavior after integer overflow.
7942
de883a70
PE
7943 merge count_size_as_multibyte, parse_str_to_multibyte
7944 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 7945 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
7946 Check for integer overflow.
7947 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7948 since it's now a duplicate of the other. This is more of
7949 a character than a buffer op, so better that it's in character.c.
7950 * fns.c, print.c: Adjust to above changes.
7951
2ff916cb
PE
79522011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7953
7954 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7955
f1b54466
PE
79562011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7957
fb1ac845
PE
7958 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7959 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7960 (x_clipboard_manager_save): Now static.
7961 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7962
f1b54466
PE
7963 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7964 (crypto_hash_function): Now static.
7965 Fix pointer signedness problems. Avoid unnecessary initializations.
7966
a9f737ee
CY
79672011-05-27 Chong Yidong <cyd@stupidchicken.com>
7968
7969 * termhooks.h (Vselection_alist): Make it terminal-local.
7970
7971 * terminal.c (create_terminal): Initialize it.
7972
7973 * xselect.c: Support for clipboard managers.
7974 (Vselection_alist): Move to termhooks.h as terminal-local var.
7975 (LOCAL_SELECTION): New macro.
7976 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7977 (symbol_to_x_atom): Remove gratuitous arg.
7978 (x_handle_selection_request, lisp_data_to_selection_data)
7979 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
7980 (x_own_selection, x_get_local_selection, x_convert_selection):
7981 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
7982 (some_frame_on_display): Delete unused function.
7983 (Fx_own_selection_internal, Fx_get_selection_internal)
7984 (Fx_disown_selection_internal, Fx_selection_owner_p)
7985 (Fx_selection_exists_p): New optional frame arg.
7986 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7987 (x_handle_selection_clear): Don't treat other terminals with the
7988 same keyboard specially. Use the terminal-local Vselection_alist.
7989 (x_clear_frame_selections): Use Frun_hook_with_args.
7990
7991 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7992
7993 * xterm.h: Add support for those atoms.
7994
e067f0c1
CY
79952011-05-26 Chong Yidong <cyd@stupidchicken.com>
7996
7997 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7998 (converted_selections, conversion_fail_tag): New global variables.
7999 (x_selection_request_lisp_error): Free the above.
8000 (x_get_local_selection): Remove unnecessary code.
8001 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8002 of converted selections stored in converted_selections.
8003 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8004 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8005 (x_convert_selection): New function.
8006 (x_handle_selection_event): Simplify.
8007 (x_get_foreign_selection): Don't ignore incoming requests while
8008 waiting for an answer; this will fail when we implement
8009 SAVE_TARGETS, and seems unnecessary anyway.
8010 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8011 (Vx_sent_selection_functions): Doc fix.
8012
0f4aebc0
LL
80132011-05-26 Leo Liu <sdl.web@gmail.com>
8014
8015 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8016
e61124cd
YM
80172011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8018
8019 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8020
8021 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8022 for fringe update if it has periodic bitmap.
ac389d0c 8023 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8024 and fringe_bitmap_periodic_p.
8025
8026 * fringe.c (get_fringe_bitmap_data): New function.
8027 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8028 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8029 row. Mark glyph row for fringe update if periodicity changed.
8030
8031 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8032 for fringe update unless it has periodic bitmap.
8033
f16d9837
KH
80342011-05-25 Kenichi Handa <handa@m17n.org>
8035
8036 * xdisp.c (get_next_display_element): Set correct it->face_id for
8037 a static composition.
8038
e1b90ef6
LL
80392011-05-24 Leo Liu <sdl.web@gmail.com>
8040
8041 * deps.mk (fns.o):
8042 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8043
8044 * fns.c (crypto_hash_function, Fsha1): New function.
8045 (Fmd5): Use crypto_hash_function.
8046 (syms_of_fns): Add Ssha1.
8047
7400048f
PE
80482011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8049
8050 * gnutls.c: Remove unused macros.
8051 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8052 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8053 Remove macros that are defined and never used.
8054 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8055
abb71cf4
CY
80562011-05-22 Chong Yidong <cyd@stupidchicken.com>
8057
8058 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8059 (Fx_get_selection_internal): Minor cleanup.
8060 (Fx_own_selection_internal): Rename arguments for consistency with
8061 select.el.
8062
6307db39
PE
80632011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8064
8065 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8066
f3d4e0a4
CY
80672011-05-22 Chong Yidong <cyd@stupidchicken.com>
8068
8069 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8070
4d8ade89
YM
80712011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8072
8073 * dispnew.c (scrolling_window): Don't exclude the case that the
8074 last enabled row in the desired matrix touches the bottom boundary.
8075
32078c8d
GM
80762011-05-21 Glenn Morris <rgm@gnu.org>
8077
8078 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8079 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8080 and add some more files.
32078c8d 8081
7285dc67
EZ
80822011-05-20 Eli Zaretskii <eliz@gnu.org>
8083
8084 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8085 report_file_error introduced by the change from 2011-05-07.
8086
89d1bd22
PE
80872011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8088
8089 * systime.h (Time): Define only if emacs is defined.
8090 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8091 where the include path doesn't have X11/X.h by default. See
8092 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8093
cd394be1 80942011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8095
8096 * composite.c (find_automatic_composition): Fix previous change.
8097
b9704ad9
GM
80982011-05-20 Glenn Morris <rgm@gnu.org>
8099
8100 * lisp.mk: New file, split from Makefile.in.
8101 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8102 (shortlisp): Remove.
8103 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8104
4a720484
GM
81052011-05-19 Glenn Morris <rgm@gnu.org>
8106
8107 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8108 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8109 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8110 (lisp): Set the order to that of loadup.el.
8111 (shortlisp): Make it a copy of $lisp.
8112 (SOME_MACHINE_LISP): Remove.
8113 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8114 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8115
a28d4396
KH
81162011-05-18 Kenichi Handa <handa@m17n.org>
8117
8118 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8119 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8120 (find_automatic_composition): Mostly rewrite for efficiency.
8121
a2b1fa8e
JB
81222011-05-18 Juanma Barranquero <lekktu@gmail.com>
8123
8124 * makefile.w32-in: Update dependencies.
8125
8e1f5610
CS
81262011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8127
8128 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8129 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8130
7025ee00 81312011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8132
cdfa6eab
PE
8133 Fix some integer overflow issues, such as string length overflow.
8134
06d6db33
PE
8135 * insdel.c (count_size_as_multibyte): Check for string overflow.
8136
2b4560a8
PE
8137 * character.c (lisp_string_width): Check for string overflow.
8138 Use EMACS_INT, not int, for string indexes and lengths; in
8139 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8140 the resulting string length overflows an EMACS_INT; instead,
8141 report a string overflow if no precision given. When checking for
8142 precision exhaustion, use a check that cannot possibly have
8143 integer overflow. (Bug#8675)
8144 * character.h (lisp_string_width): Adjust to new signature.
8145
cb93f9be
PE
8146 * alloc.c (string_overflow): New function.
8147 (Fmake_string): Use it. This doesn't change behavior, but saves
8148 a few bytes and will simplify future changes.
8149 * character.c (string_escape_byte8): Likewise.
8150 * lisp.h (string_overflow): New decl.
8151
1a1f3366
PE
8152 Fixups, following up to the user-interface timestamp change.
8153 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8154 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8155 * msdos.c (mouse_get_pos): Likewise.
8156 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8157 * w32gui.h (Time): Define by including "systime.h" rather than by
8158 declaring it ourselves. (Bug#8664)
8159
d4e3e4d3
PE
8160 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8161 * image.c (clear_image_cache): Likewise.
8162
f6a24d19
PE
8163 * term.c (term_mouse_position): Don't assume time_t wraparound.
8164
08dc5ae6
PE
8165 Be more systematic about user-interface timestamps.
8166 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8167 and sometimes 'EMACS_UINT', to represent these timestamps.
8168 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8169 This makes the code easier to follow, and makes it easier to catch
8170 integer overflow bugs such as Bug#8664.
8171 * frame.c (Fmouse_position, Fmouse_pixel_position):
8172 Use Time, not unsigned long, for user-interface timestamps.
8173 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8174 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8175 * keyboard.h (last_event_timestamp): Likewise.
8176 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8177 * menu.h (xmenu_show): Likewise.
8178 * term.c (term_mouse_position): Likewise.
8179 * termhooks.h (struct input_event.timestamp): Likewise.
8180 (struct terminal.mouse_position_hook): Likewise.
8181 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8182 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8183 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8184 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8185 what it was before.
8186 * menu.h, termhooks.h: Include "systime.h", for Time.
8187
8e55734a
PE
8188 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8189 Don't assume that the difference between two unsigned long values
8190 can fit into an integer. At this point, we know button_down_time
8191 <= event->timestamp, so the difference must be nonnegative, so
8192 there's no need to cast the result if double-click-time is
8193 nonnegative, as it should be; check that it's nonnegative, just in
8194 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8195 apart (about 25 days). (Bug#8664)
8e55734a 8196
841f1b75 8197 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8198 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8199
3e26f69c
PE
8200 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8201 that always fit in int. Use a sentinel instead of a counter, to
8202 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8203 * frame.h (struct frame): Use int for menu_bar_items_used
8204 instead of EMACS_INT, since it always fits in int.
3e26f69c 8205
5cc152c0
PE
8206 * menu.c (grow_menu_items): Check for int overflow.
8207
d89eb65e
PE
8208 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8209
5235bd3e
PE
8210 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8211 Before, the code was not consistent. These values cannot exceed
8212 2**31 - 1 so there's no need to make them unsigned.
8213 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8214 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8215 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8216 as modifiers.
8217 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8218
bc827e23
PE
8219 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8220 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8221 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8222 presumably because the widths might not match.
8223
78eb494e
PE
8224 * window.c (size_window): Avoid needless test at loop start.
8225
04f2d78b
CB
82262011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8227
8228 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8229
d2fc7e3d 82302011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8231
8232 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8233
d2fc7e3d 82342011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8235
8236 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8237 `width' to `bar_area_x' and `bar_area_width', respectively.
8238 (x_scroll_run): Take account of fringe background extension.
8239
04f2d78b
CB
8240 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8241 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8242 `bar_area_width', respectively.
8243 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8244 background extension.
8245
79b70037
GM
82462011-05-10 Jim Meyering <meyering@redhat.com>
8247
8248 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8249
2f142cc5
JB
82502011-05-10 Juanma Barranquero <lekktu@gmail.com>
8251
8252 * image.c (Finit_image_library): Return t for built-in image types,
8253 like pbm and xbm. (Bug#8640)
8254
57679c86
AS
82552011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8256
8257 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8258
888c9e86
EZ
82592011-05-07 Eli Zaretskii <eliz@gnu.org>
8260
b0512a1d
EZ
8261 * w32console.c (Fset_screen_color): Doc fix.
8262 (Fget_screen_color): New function.
8263 (syms_of_ntterm): Defsubr it.
8264
7285dc67
EZ
8265 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8266 unlink the temporary file if Fcall_process didn't create it in the
8267 first place.
8268 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8269 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8270 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8271 cue to call_process_cleanup not to close that handle.
8272
4d3fcc8e
BK
82732011-05-07 Ben Key <bkey76@gmail.com>
8274
8275 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8276 one of two shell specific rules, either bootstrap-temacs-CMD or
8277 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8278 to the previous implementation of the bootstrap-temacs rule.
8279 The bootstrap-temacs-CMD rule is similar to the previous
8280 implementation of the bootstrap-temacs rule except that it
8281 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8282 variable.
8283
8284 These changes, along with some changes to nt/configure.bat,
8285 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8286 earlier fix to add support for --cflags and --ldflags options
8287 that include quotes so that it works whether make uses cmd or
8288 sh as the shell.
8289
b4289b64
MA
82902011-05-06 Michael Albinus <michael.albinus@gmx.de>
8291
8292 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8293 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8294 is a constant.
8295 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8296 a string. Handle both cases.
8297 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8298 (Fdbus_register_method): Use Qinvalid_function.
8299
af4c0e28
JB
83002011-05-06 Juanma Barranquero <lekktu@gmail.com>
8301
8302 * makefile.w32-in: Update dependencies.
8303 (LISP_H): Add inttypes.h and stdin.h.
8304 (PROCESS_H): Add unistd.h.
8305
c51453d9
EZ
83062011-05-06 Eli Zaretskii <eliz@gnu.org>
8307
8308 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8309 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8310
8ff0ac3c 83112011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8312
4c4b566b
PE
8313 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8314
aab2b9b5
PE
8315 * term.c (vfatal): Remove stray call to va_end.
8316 It's not needed and the C Standard doesn't allow it here anyway.
8317
c378da0b
PE
8318 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8319 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8320
288b08c7
PE
8321 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8322 bytes.
8323
e3601888
PE
8324 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8325
db6c0e74
PE
8326 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8327
dd5963ea
PE
8328 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8329
88c9450f
PE
8330 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8331
2f9442b8
PE
8332 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8333
c032b5f8
PE
8334 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8335 * charset.c (Fdefine_charset_internal): Don't initialize
8336 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8337 32-bit int (Bug#8600).
a108c10b
PE
8338
8339 * lread.c (read_integer): Be more consistent with string-to-number.
8340 Use string_to_number to do the actual conversion; this avoids
8341 rounding errors and fixes some other screwups. Without this fix,
8342 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8343 (digit_to_number): Move earlier, for benefit of read_integer.
8344 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8345 not a digit in any supported base. (Bug#8602)
a108c10b 8346
ad5f9eea
PE
8347 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8348
aec1708a
PE
8349 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8350 to match comment at start of function. This also removes a
8351 GCC warning about overflow in a 32+64-bit port.
8352
47be4ab5
PE
8353 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8354
371cac43
PE
8355 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8356 Reported by Stefan Monnier in
8357 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8358 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8359 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8360
d01a7826
PE
8361 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8362 (EMACS_UINTPTR): Likewise, with uintptr_t.
8363
7fd47d5c
PE
8364 * lisp.h: Prefer 64-bit EMACS_INT if available.
8365 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8366 on 32-bit hosts that have 64-bit int, so that they can access
8367 large files.
122b0c86
PE
8368 However, temporarily disable this change unless the temporary
8369 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8370
8727937b
PE
8371 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8372
8ac068ac
PE
8373 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8374 This removes an assumption that EMACS_INT and long are the same
8375 width as pointers. The assumption is true for Emacs porting targets
8376 now, but we want to make other targets possible.
8377 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8378 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8379 In the rest of the code, change types of integers that hold casted
8380 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8381 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8382 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8383 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8384 No need to cast type when ORing.
8385 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8386 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8387 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8388 assume EMACS_INT is the same width as char *.
8389 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8390 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8391 Remove no-longer-needed casts.
8392 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8393 (xg_tool_bar_help_callback, xg_make_tool_item):
8394 Use EMACS_INTPTR to hold an integer
8395 that will be cast to void *; this can avoid a GCC warning
8396 if EMACS_INT is not the same width as void *.
8397 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8398 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8399 (current_message_1, set_message_1):
8400 Use a local to convert to proper width without a cast.
8401 * xmenu.c (dialog_selection_callback): Likewise.
8402
ede49d71
PE
8403 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8404 Also, don't assume VALBITS / RAND_BITS is less than 5,
8405 and don't rely on undefined behavior when shifting a 1 left into
8406 the sign bit.
8407 * lisp.h (get_random): Change signature to match.
8408
2f30ecd0
PE
8409 * lread.c (hash_string): Use size_t, not int, for hash computation.
8410 Normally we prefer signed values; but hashing is special, because
8411 it's better to use unsigned division on hash table sizes so that
8412 the remainder is nonnegative. Also, size_t is the natural width
8413 for hashing into memory. The previous code used 'int', which doesn't
8414 retain enough info to hash well into very large tables.
8415 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8416
2a866e7b
PE
8417 * dbusbind.c: Don't possibly lose pointer info when converting.
8418 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8419 Use XPNTR rather than XHASH, so that the high-order bits of
8420 the pointer aren't lost when converting through void *.
8421
51639eac
PE
8422 * eval.c (Fautoload): Don't double-shift a pointer.
8423
92394119
PE
8424 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8425
dbdb9a7c
JB
84262011-05-06 Juanma Barranquero <lekktu@gmail.com>
8427
8428 * gnutls.c (DEF_GNUTLS_FN):
8429 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8430
db7a0b4f
AS
84312011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8432
8433 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8434 marker. (Bug#8610)
8435
cd394be1 84362011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8437
8438 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8439 New version that can reserve upto 2GB of heap space.
8440
f7ff1b0f 84412011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8442
8443 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8444
639c109b
TZ
84452011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8446
8447 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8448 `gnutls_certificate_set_x509_key_file'.
8449
d2127135
JB
84502011-05-05 Juanma Barranquero <lekktu@gmail.com>
8451
8452 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8453 Update dependencies.
8454
e968f4f3
JB
84552011-05-04 Juanma Barranquero <lekktu@gmail.com>
8456
8457 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8458 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8459 Remove unused parameter `fildes'.
8460 * process.c (read_process_output, send_process): Don't pass it.
8461
84d358f0
JB
84622011-05-04 Juanma Barranquero <lekktu@gmail.com>
8463
8464 Fix previous change: the library cache is defined in w32.c.
8465 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8466 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8467
0898ca10
JB
84682011-05-04 Juanma Barranquero <lekktu@gmail.com>
8469
8470 Implement dynamic loading of GnuTLS on Windows.
8471
8472 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8473 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8474 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8475 Declare.
8476
8477 * gnutls.c (Qgnutls_dll): Define.
8478 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8479 (gnutls_*): Declare function pointers.
8480 (init_gnutls_functions): New function to initialize function pointers.
8481 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8482 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8483 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8484 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8485 (emacs_gnutls_write, emacs_gnutls_read)
8486 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8487 (Fgnutls_available_p): New function.
8488 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8489 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8490 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8491
8492 * image.c: Include w32.h.
8493 (Vimage_type_cache): Delete.
8494 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8495 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8496 (w32_delayed_load): Move to w32.c.
8497
8498 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8499
8500 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8501 (w32_delayed_load): Move from image.c. When loading a library, record
8502 its filename in the :loaded-from property of the library id.
8503 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8504 Initialize and staticpro them.
8505 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8506
8507 * process.c: Include lisp.h before w32.h, not after.
8508 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8509 instead of gnutls_record_check_pending.
8510
8511 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8512
ff4de4aa
TZ
85132011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8514
8515 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8516 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8517 as passed in.
8518
abe95abb
JD
85192011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8520
8521 * xterm.c (x_set_frame_alpha): Do not set property on anything
8522 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8523
e16e55d4
JB
85242011-05-02 Juanma Barranquero <lekktu@gmail.com>
8525
8526 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8527
bafcf6a5
JB
85282011-05-02 Juanma Barranquero <lekktu@gmail.com>
8529
8530 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8531 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8532 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8533 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8534 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8535 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8536 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8537 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8538 (Qgnutls_bootprop_callbacks_verify): Make static.
8539
e7a6747f
AS
85402011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8541
19ed11ba
AS
8542 * callproc.c: Indentation fixup.
8543
e7a6747f 8544 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8545 (wait_for_termination, interruptible_wait_for_termination):
8546 Move after wait_for_termination_1.
e7a6747f 8547
1ef14cb4
LMI
85482011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8549
8550 * sysdep.c (interruptible_wait_for_termination): New function
8551 which is like wait_for_termination, but allows keyboard
8552 interruptions.
8553
8554 * callproc.c (Fcall_process): Add (:file "file") as an option for
8555 the STDOUT buffer.
8556 (Fcall_process_region): Ditto.
8557
330d880c
EZ
85582011-04-30 Eli Zaretskii <eliz@gnu.org>
8559
8db90b73
EZ
8560 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8561 rather than `XVECTOR (FOO)->size'.
8562
330d880c
EZ
8563 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8564 inttypes.h, as a gnulib replacement is used if it not available in
8565 system headers.
8566
15cbd324
EZ
85672011-04-21 Eli Zaretskii <eliz@gnu.org>
8568
8569 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8570 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8571 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8572
8573 * coding.c (coding_alloc_by_realloc): Error out if destination
8574 will grow beyond MOST_POSITIVE_FIXNUM.
8575 (decode_coding_emacs_mule): Abort if there isn't enough place in
8576 charbuf for the composition carryover bytes. Reserve an extra
8577 space for up to 2 characters produced in a loop.
8578 (decode_coding_iso_2022): Abort if there isn't enough place in
8579 charbuf for the composition carryover bytes.
8580
85812011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8582
ae940cca
EZ
8583 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8584 aborting when %lld or %lll format is passed.
8585 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8586 %llo or %llx format is passed. (Bug#8545)
8587
03ab8921
EZ
8588 * window.c (window_scroll_line_based): Use a marker instead of
8589 simple variables to record original value of point. (Bug#7952)
8590
afda1437
EZ
8591 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8592 produced by %s or %c overflows available buffer space. (Bug#8545)
8593
f76dee0c
PE
85942011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8595
8596 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8597 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8598
fdc5744d
JB
85992011-04-28 Juanma Barranquero <lekktu@gmail.com>
8600
8601 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8602
638f053a
JB
86032011-04-28 Juanma Barranquero <lekktu@gmail.com>
8604
8605 * keyboard.c (Qdelayed_warnings_hook): Define.
8606 (command_loop_1): Run `delayed-warnings-hook'
8607 if Vdelayed_warnings_list is non-nil.
8608 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8609 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8610
d178f871
EZ
86112011-04-28 Eli Zaretskii <eliz@gnu.org>
8612
8613 * doprnt.c (doprnt): Don't return value smaller than the buffer
8614 size if the message was truncated. (Bug#8545).
8615
b124fd93
JB
86162011-04-28 Juanma Barranquero <lekktu@gmail.com>
8617
8618 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8619 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8620
e810457d
PE
86212011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8622
8623 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8624
ea51cceb
JB
86252011-04-27 Juanma Barranquero <lekktu@gmail.com>
8626
8627 * makefile.w32-in: Update dependencies.
8628
94dcfacf
EZ
86292011-04-27 Eli Zaretskii <eliz@gnu.org>
8630
8631 Improve `doprnt' and its usage. (Bug#8545)
8632 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8633 `format_end'. Remove support for %l as a conversion specifier.
8634 Don't use xrealloc. Improve diagnostics when the %l size modifier
8635 is used. Update the commentary.
8636
8637 * eval.c (verror): Simplify calculation of size_t.
8638
8639 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8640 messages.
8641
f61f41d7
PE
86422011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8643
8644 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8645 change.
8646
96fb4434
PE
86472011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8648
8649 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8650 This makes this file independent of the recent pseudovector change.
8651
671875da 86522011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8653
69e9b5a3
PE
8654 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8655
b5f869a7 8656 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8657 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8658 Remove unused local.
c8926152 8659 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8660
841a1577 8661 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8662 GCC 4.6.0 optimizes based on type-based alias analysis.
8663 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8664 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8665 != &v->size, and therefore "v->size = 1; b->size = 2; return
8666 v->size;" must therefore return 1. This assumption is incorrect
8667 for Emacs, since it type-puns struct Lisp_Vector * with many other
8668 types. To fix this problem, this patch adds a new type struct
f904488f 8669 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8670 and pseudovectors, and helps optimizing compilers not get fooled
8671 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8672 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8673 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8674 the size member.
eab3844f
PE
8675 (XSETPVECTYPE): Rewrite in terms of new macro.
8676 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8677 This is a bit clearer, and further avoids the possibility of
8678 undesirable aliasing.
8679 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8680 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8681 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8682 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8683 (ASIZE): Now uses header.size rather than size.
8684 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8685 to avoid the hassle of writing XVECTOR (foo)->header.size.
8686 (struct vectorlike_header): New type.
eab3844f
PE
8687 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8688 object, to help avoid aliasing.
8689 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8690 (SUBRP): Likewise, since Lisp_Subr is a special case.
8691 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8692 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8693 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8694 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8695 changed to be "header.size" and "header.next".
8696 * buffer.h (struct buffer): Likewise.
8697 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8698 * frame.h (struct frame): Likewise.
8699 * process.h (struct Lisp_Process): Likewise.
8700 * termhooks.h (struct terminal): Likewise.
8701 * window.c (struct save_window_data, struct saved_window): Likewise.
8702 * window.h (struct window): Likewise.
8703 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8704 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8705 * buffer.c (init_buffer_once): Likewise.
8706 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8707 special case.
8708 * process.c (Fformat_network_address): Use local var for size,
8709 for brevity.
8710
0df1eac5
PE
8711 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8712
847ab9d1 8713 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8714 * data.c (atof): Remove decl; no longer used or needed.
8715 (digit_to_number): Move to lread.c.
8716 (Fstring_to_number): Use new string_to_number function, to be
8717 consistent with how the Lisp reader treats infinities and NaNs.
8718 Do not assume that floating-point numbers represent EMACS_INT
8719 without losing information; this is not true on most 64-bit hosts.
8720 Avoid double-rounding errors, by insisting on integers when
8721 parsing non-base-10 numbers, as the documentation specifies.
8722 * lisp.h (string_to_number): New decl, replacing ...
8723 (isfloat_string): Remove.
bc0a5c13 8724 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8725 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8726 appears to have been a coding error. Similarly, do not accept
8727 strings like +-1e0 as floating point numbers. Do not report
8728 overflow for integer overflows unless the base is not 10 which
8729 means we have no simple and reliable way to continue.
8730 Break out the floating-point parsing into a new
8731 function string_to_number, so that Fstring_to_number parses
8732 floating point numbers consistently with the Lisp reader.
04f2d78b 8733 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8734 (E_CHAR, EXP_INT): Remove, replacing with ...
8735 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8736 (string_to_number): New function, replacing isfloat_string.
8737 This function checks for valid syntax and produces the resulting
8738 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8739 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8740 so that overflow for non-base-10 numbers is reported only when
8741 there's no portable and simple way to convert to floating point.
452f4150 8742
67769ffc
PE
8743 * textprop.c (set_text_properties_1): Rewrite for clarity,
8744 and to avoid GCC warning about integer overflow.
8745
c20db43f
PE
8746 * intervals.h (struct interval): Use EMACS_INT for members
8747 where EMACS_UINT might cause problems. See
8748 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8749 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8750 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8751 All uses changed.
37aa2f85
PE
8752 (offset_intervals): Tell GCC not to worry about length overflow
8753 when negating a negative length.
c20db43f 8754
2538aa2f
PE
8755 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8756 (overrun_check_free): Likewise.
8757
f2d3008d
PE
8758 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8759 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8760 word size.
8761
ec8df744
PE
8762 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8763 (gnutls_make_error): Rename local to avoid shadowing.
8764 (gnutls_emacs_global_deinit): ifdef out; not used.
8765 (Fgnutls_boot): Use const for pointer to readonly storage.
8766 Comment out unused local. Fix pointer signedness problems.
8767
640ee02d
PE
8768 * lread.c (openp): Don't stuff size_t into an 'int'.
8769 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8770 about possible signed overflow.
8771
6048fb2a
PE
8772 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8773 (GDK_KEY_g): Don't define if already defined.
8774 (xg_prepare_tooltip): Avoid pointer signedness problem.
8775 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8776
fa3c87e1
PE
8777 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8778 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8779
2172544b
PE
8780 * xfns.c (Fx_window_property): Simplify a bit,
8781 to make a bit faster and to avoid GCC 4.6.0 warning.
8782 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8783
9b821a21
PE
8784 * fns.c (internal_equal): Don't assume size_t fits in int.
8785
3c616cfa
PE
8786 * alloc.c (compact_small_strings): Tighten assertion a little.
8787
c2982e87
PE
8788 Replace pEd with more-general pI, and fix some printf arg casts.
8789 * lisp.h (pI): New macro, generalizing old pEd macro to other
8790 conversion specifiers. For example, use "...%"pI"d..." rather
8791 than "...%"pEd"...".
8792 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 8793 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
8794 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8795 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8796 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8797 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8798 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8799 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8800 64-bit hosts.
8801 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8802 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8803 * print.c (safe_debug_print, print_object): Likewise.
8804 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8805 to int.
6f04d126
PE
8806 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8807 avoiding the 0 flag, which is not portable.
c2982e87
PE
8808 * process.c (Fmake_network_process): Use pI to avoid cast.
8809 * region-cache.c (pp_cache): Likewise.
8810 * xdisp.c (decode_mode_spec): Likewise.
8811 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8812 behavior on 64-bit hosts with printf arg.
6f04d126 8813 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
8814 (x_stop_queuing_selection_requests): Likewise.
8815 (x_get_window_property): Don't truncate byte count to an 'int'
8816 when tracing.
0b432f21 8817
5e073ec7
PE
8818 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8819 here, since it parses constructs like leading '-' and spaces,
8820 which are not wanted; and it overflows with large numbers.
8821 Instead, simply match F[0-9]+, which is what is wanted anyway.
8822
36372bf9
PE
8823 * alloc.c: Remove unportable assumptions about struct layout.
8824 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8825 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8826 (allocate_vectorlike, make_pure_vector): Use the new macros,
8827 plus offsetof, to remove unportable assumptions about struct layout.
8828 These assumptions hold on all porting targets that I know of, but
8829 they are not guaranteed, they're easy to remove, and removing them
8830 makes further changes easier.
8831
0b432f21
PE
8832 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8833 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
8834 (string_overrun_cookie): Now const. Use initializers that
8835 don't formally overflow signed char, to avoid warnings.
000098c1
PE
8836 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8837 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
8838 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8839 multiple of sizeof (EMACS_INT); it need not be, if
8840 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 8841 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 8842
895009e1
JB
88432011-04-26 Juanma Barranquero <lekktu@gmail.com>
8844
8845 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8846
6a7a1b0b
TZ
88472011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8848
8849 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 8850 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
8851 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8852
841a1577 88532011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
8854
8855 * lisp.h (Qdebug): List symbol.
895009e1 8856 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
8857 * keyboard.c (debug-on-event): New variable.
8858 (handle_user_signal): Break into debugger when debug-on-event
8859 matches the current signal symbol.
8860
f2d3ba6f
DN
88612011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8862
8863 * alloc.c (check_sblock, check_string_bytes)
8864 (check_string_free_list): Convert to standard C.
8865
42ce4c63
TZ
88662011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8867
8868 * w32.c (emacs_gnutls_push): Fix typo.
8869
825cd63c
EZ
88702011-04-25 Eli Zaretskii <eliz@gnu.org>
8871
fb11d64d
EZ
8872 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8873 "cast to pointer from integer of different size".
8874
825cd63c
EZ
8875 Improve doprnt and its use in verror. (Bug#8545)
8876 * doprnt.c (doprnt): Document the set of format control sequences
8877 supported by the function. Use SAFE_ALLOCA instead of always
8878 using `alloca'.
8879
8880 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8881 is one byte too soon. Don't use xrealloc; instead xfree and
8882 xmalloc anew.
8883
e061a11b
TZ
88842011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8885
8886 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8887 callbacks stage.
8888
8889 * gnutls.c: Renamed global_initialized to
8890 gnutls_global_initialized. Added internals for the
8891 :verify-hostname-error, :verify-error, and :verify-flags
8892 parameters of `gnutls-boot' and documented those parameters in the
8893 docstring. Start callback support.
9173deec
JB
8894 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8895 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8896 on error. Return error code.
e061a11b
TZ
8897 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8898 (emacs_gnutls_read): Likewise.
8899 (Fgnutls_boot): Return handshake error code.
8900 (emacs_gnutls_handle_error): New function.
8901 (wsaerror_to_errno): Likewise.
8902
8903 * w32.h (emacs_gnutls_pull): Add prototype.
8904 (emacs_gnutls_push): Likewise.
8905
8906 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8907 (emacs_gnutls_push): Likewise.
8908
89092011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8910
8911 * process.c (wait_reading_process_output): Check if GnuTLS
8912 buffered some data internally if no FDs are set for TLS
8913 connections.
8914
8915 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8916 (LIBS): Link to USER_LIBS.
8917 ($(BLD)/gnutls.$(0)): New target.
8918
fa6996bc
EZ
89192011-04-24 Eli Zaretskii <eliz@gnu.org>
8920
eb35682e
EZ
8921 * xdisp.c (handle_single_display_spec): Rename the
8922 display_replaced_before_p argument into display_replaced_p, to
8923 make it consistent with the commentary. Fix typos in the
8924 commentary.
8925
e2ad650c
EZ
8926 * textprop.c (syms_of_textprop): Remove dead code.
8927 (copy_text_properties): Delete obsolete commentary about an
8928 interface that was deleted long ago. Fix typos in the description
8929 of arguments.
8930
1b2de274
EZ
8931 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8932 to changes in oldXMenu/XMenu.h from 2011-04-16.
8933 <menu_help_message, prev_menu_help_message>: Constify.
8934 (IT_menu_make_room): menu->help_text is now `const char **';
8935 adjust.
8936
8937 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8938 to changes in oldXMenu/XMenu.h from 2011-04-16.
8939 (struct XMenu): Declare `help_text' `const char **'.
8940
8941 * xfaces.c <Qunspecified>: Make extern again.
8942
8943 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 8944 required by POSIX.
1b2de274 8945
762b15be
EZ
8946 * doc.c (get_doc_string): Improve the format passed to `error'.
8947
8948 * doprnt.c (doprnt): Improve commentary.
8949
8950 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8951
8952 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8953 them with etags.
8954
f1052e5d
EZ
8955 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8956 changes in globals.h immediately force recompilation.
762b15be
EZ
8957 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8958 $(CURDIR)/s/ms-w32.h.
8959 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 8960
fa6996bc
EZ
8961 * character.c (Fchar_direction): Function deleted.
8962 (syms_of_character): Don't defsubr it.
8963 <char-direction-table>: Deleted.
8964
e6c3da20
EZ
89652011-04-23 Eli Zaretskii <eliz@gnu.org>
8966
8967 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8968 * doprnt.c: Include limits.h.
8969 (SIZE_MAX): New macro.
04f2d78b
CB
8970 (doprnt): Return a size_t value. 2nd arg is now size_t.
8971 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
8972 Improve overflow protection. Support `l' modifier for integer
8973 conversions. Support %l conversion. Don't assume an EMACS_INT
8974 argument for integer conversions and for %c.
8975
8976 * lisp.h (doprnt): Restore prototype.
8977
8978 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8979 $(SRC)/character.h.
8980
8981 * Makefile.in (base_obj): Add back doprnt.o.
8982
8983 * deps.mk (doprnt.o): Add back prerequisites.
8984 (callint.o): Depend on character.h.
8985
8986 * eval.c (internal_lisp_condition_case): Include the handler
8987 representation in the error message.
8988 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8989 when breaking from the loop.
8990
8991 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8992
8993 * callint.c (Fcall_interactively): When displaying error message
8994 about invalid control letter, pass the character's codepoint, not
8995 a pointer to its multibyte form. Improve display of the character
8996 in octal and display also its hex code.
8997
8998 * character.c (char_string): Use %x to display the (unsigned)
8999 codepoint of an invalid character, to avoid displaying a bogus
9000 negative value.
9001
9002 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9003 `error', not SYMBOL_NAME itself.
9004
9005 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9006 character arguments to `error'.
9007
9008 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9009 to `error' in error message about FINAL_CHAR argument. Make sure
9010 FINAL_CHAR is a character, and use %c when it is passed as
9011 argument to `error'.
9012
4ffd0d6b 90132011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9014
9015 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9016
9017 * w32.c: Include <time.h>.
9018 (sys_localtime): New function.
9019
4ffd0d6b 90202011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9021
9022 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9023
4ffd0d6b 9024 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9025
4ffd0d6b 90262011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9027
4ffd0d6b
GM
9028 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9029 zombies (Bug#8467).
aac0c6e3 9030
04c56954
EZ
90312011-04-19 Eli Zaretskii <eliz@gnu.org>
9032
9033 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9034 gl_state.e_property when gl_state.object is Qt.
9035
9036 * insdel.c (make_gap_larger): Remove limitation of buffer size
9037 to <= INT_MAX.
9038
16a43933
CY
90392011-04-18 Chong Yidong <cyd@stupidchicken.com>
9040
9041 * xdisp.c (lookup_glyphless_char_display)
9042 (produce_glyphless_glyph): Handle cons cell entry in
9043 glyphless-char-display.
9044 (Vglyphless_char_display): Document it.
9045
9046 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9047 glyphless-char-display.
9048
4581706e
CY
90492011-04-17 Chong Yidong <cyd@stupidchicken.com>
9050
9051 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9052
9053 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9054
9055 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9056 definition for no-X builds.
9057
4887c6e2 90582011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9059
fd35b6f9
PE
9060 Static checks with GCC 4.6.0 and non-default toolkits.
9061
5c1ccb01
PE
9062 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9063
006c5daa
PE
9064 * process.c (keyboard_bit_set): Define only if SIGIO.
9065 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9066 (send_process): Repair possible setjmp clobbering.
9067
efc736d3
PE
9068 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9069
4e2fe2e6
PE
9070 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9071
f97334a2
PE
9072 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9073
4e75f29d
PE
9074 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9075 Define only if needed.
9076
90efadd1
PE
9077 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9078 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9079 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9080
3c647824
PE
9081 * dispextern.h (struct redisplay_interface): Rename param
9082 to avoid shadowing.
e264f262 9083 * termhooks.h (struct terminal): Likewise.
761383f4 9084 * xterm.c (xembed_send_message): Likewise.
3c647824 9085
b58c5c4a
PE
9086 * insdel.c (make_gap_smaller): Define only if
9087 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9088
cad59032
PE
9089 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9090 it.
9091
c339dc2e
PE
9092 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9093 so that we aren't warned about unused symbols.
9094
91a3e27b
PE
9095 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9096
399c71d3 9097 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9098
8ffc96f5
PE
9099 * xfns.c (x_real_positions): Mark locals as initialized.
9100
eef9bc79
PE
9101 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9102
098db9dd
PE
9103 * xterm.c: Fix problems found by static analysis with other toolkits.
9104 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9105 (x_dispatch_event): Declare static if USE_GTK, and
9106 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9107 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9108 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9109 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9110 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9111
eb18f6cc
PE
9112 * xmenu.c (menu_help_callback): Pointer type fixes.
9113 Use const pointers when pointing at readonly data. Avoid pointer
9114 signedness clashes.
9115 (FALSE): Remove unused macro.
9116 (update_frame_menubar): Remove unused decl.
9117
1fe72bf8
PE
9118 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9119
60d9e1db
PE
9120 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9121 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9122 (single_menu_item): Rename local to avoid shadowing.
9123
39261c26
PE
9124 * keyboard.c (make_lispy_event): Remove unused local var.
9125
018c5e19
PE
9126 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9127 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9128
63d2b86e
PE
9129 * bitmaps: Change bitmaps from unsigned char back to the X11
9130 compatible char. Avoid the old compiler warnings about
9131 out-of-range initializers by using, for example, '\xab' rather
9132 than 0xab.
9133
aefd87e1
PE
9134 * xgselect.c (xgselect_initialize): Check vs interface
9135 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9136
bf501fb9
PE
9137 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9138
e9829fdf
PE
9139 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9140 to read-only memory.
9141
1086c095
PE
9142 * fns.c (vector): Remove; this old hack is no longer needed.
9143
2baccd04 9144 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9145 Remove unused var.
dde42981 9146 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9147
72391843 9148 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9149
436c16df 9150 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9151 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9152 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9153
92bb796d 9154 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9155 (x_term_init): Remove local to avoid shadowing.
92bb796d 9156
764430a3 9157 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9158
9159 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9160 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9161
d1dfb56c
EZ
91622011-04-16 Eli Zaretskii <eliz@gnu.org>
9163
c4354cb4
EZ
9164 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9165
d1dfb56c
EZ
9166 Fix regex.c, syntax.c and friends for buffers > 2GB.
9167 * syntax.h (struct gl_state_s): Declare character position members
9168 EMACS_INT.
9169
9170 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9171
04f2d78b
CB
9172 * textprop.c (verify_interval_modification, interval_of):
9173 Declare arguments EMACS_INT.
d1dfb56c
EZ
9174
9175 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9176 EMACS_INT.
9177
9178 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9179
9180 * indent.c (Fvertical_motion): Local variable it_start is now
9181 EMACS_INT.
9182
9183 * regex.c (re_match, re_match_2, re_match_2_internal)
9184 (bcmp_translate, regcomp, regexec, print_double_string)
9185 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9186 (re_compile_pattern, re_exec): Declare arguments and local
9187 variables `size_t' and `ssize_t' and return values `regoff_t', as
9188 appropriate.
9189 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9190 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9191 <compile_stack_type>: `size' and `avail' are now `size_t'.
9192
9193 * regex.h <regoff_t>: Use ssize_t, not int.
9194 (re_search, re_search_2, re_match, re_match_2): Arguments that
9195 specify buffer/string position and length are now ssize_t and
9196 size_t. Return type is regoff_t.
9197
613052cd
BK
91982011-04-16 Ben Key <bkey76@gmail.com>
9199
9200 * nsfont.m: Fixed bugs in ns_get_family and
9201 ns_descriptor_to_entity that were caused by using free to
9202 deallocate memory blocks that were allocated by xmalloc (via
9203 xstrdup). This caused Emacs to crash when compiled with
9204 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9205 --enable-checking=xmallocoverrun). xfree is now used to
9206 deallocate these memory blocks.
9207
4170f62f 92082011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9209
71b41406
PE
9210 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9211
9587a89d
PE
9212 emacs_write: Accept and return EMACS_INT for sizes.
9213 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9214 et seq.
9215 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9216 Accept and return EMACS_INT.
9217 (emacs_gnutls_write): Return the number of bytes written on
9218 partial writes.
9219 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9220 (emacs_read, emacs_write): Remove check for negative size, as the
9221 Emacs source code has been audited now.
9587a89d
PE
9222 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9223 (emacs_read, emacs_write): Use it.
273a5f82
PE
9224 * process.c (send_process): Adjust to the new signatures of
9225 emacs_write and emacs_gnutls_write. Do not attempt to store
9226 a byte offset into an 'int'; it might overflow.
9587a89d 9227 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9228
3e047f51
PE
9229 * sound.c: Don't assume sizes fit in 'int'.
9230 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9231 Return EMACS_INT, not int.
3e047f51 9232 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9233 Accept EMACS_INT, not int.
9234 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9235 record read return values.
9236
cc39a9db
BK
92372011-04-15 Ben Key <bkey76@gmail.com>
9238
c9d0ec6d
JB
9239 * keyboard.c (Qundefined): Don't declare static since it is used
9240 in nsfns.m.
9241 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9242 static since they are used in nsfont.m.
cc39a9db 9243
6c60eb9f
SM
92442011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9245
9246 * process.c (Qprocessp): Don't declare static.
9247 * lisp.h (Qprocessp): Declare again.
9248
7990b61a
JB
92492011-04-15 Juanma Barranquero <lekktu@gmail.com>
9250
9251 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9252
5d4cb038
PE
92532011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9254
8bd7b830 9255 Improve C-level modularity by making more things 'static'.
cd64ea1d 9256
e3b27b31
PE
9257 Don't publish debugger-only interfaces to other modules.
9258 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9259 (verify_bytepos, count_markers): Move decls to the only modules
9260 that need them.
9261 * region-cache.h (pp_cache): Likewise.
9262 * window.h (check_all_windows): Likewise.
9263 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9264
5d4cb038
PE
9265 * sysdep.c (croak): Now static, if
9266 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9267 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9268
9269 * alloc.c (refill_memory_reserve): Now static if
9270 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9271 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9272
e87b6180
PE
9273 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9274 Define only if USE_LUCID.
9275
ac64929e
PE
9276 * xrdb.c (x_customization_string, x_rm_string): Now static.
9277
6f37259d
PE
9278 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9279 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9280
1683e3ab
PE
9281 * xdisp.c (draw_row_with_mouse_face): Now static.
9282 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9283
de9c2632
PE
9284 * window.h (check_all_windows): Mark externally visible.
9285
2b96acb7
PE
9286 * window.c (window_deletion_count): Now static.
9287
9288 * undo.c: Make symbols static if they're not exported.
9289 (last_undo_buffer, last_boundary_position, pending_boundary):
9290 Now static.
9291
50436f33
PE
9292 * textprop.c (interval_insert_behind_hooks): Now static.
9293 (interval_insert_in_front_hooks): Likewise.
9294
64520e5c
PE
9295 * term.c: Make symbols static if they're not exported.
9296 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9297 (max_frame_lines, tty_set_terminal_modes):
9298 (tty_reset_terminal_modes, tty_turn_off_highlight):
9299 (get_tty_terminal): Now static.
9300 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9301 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9302 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9303 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9304 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9305
1fa53021
PE
9306 * sysdep.c: Make symbols static if they're not exported.
9307 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9308 Now static.
9309 (sigprocmask_set, full_mask): Remove; unused.
9310 (wait_debugging): Mark as visible.
9311 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9312 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9313
d4b43b22
PE
9314 * syntax.c (syntax_temp): Define only if !__GNUC__.
9315
b7c513d0
PE
9316 * sound.c (current_sound_device, current_sound): Now static.
9317
989b29ad
PE
9318 * search.c (searchbufs, searchbuf_head): Now static.
9319
13a55a78
PE
9320 * scroll.c (scroll_cost): Remove; unused.
9321 * dispextern.h (scroll_cost): Remove decl.
9322
de68a1fc
PE
9323 * region-cache.h (pp_cache): Mark as externally visible.
9324
40ccffa6
PE
9325 * process.c: Make symbols static if they're not exported.
9326 (process_tick, update_tick, create_process, chan_process):
9327 (Vprocess_alist, proc_buffered_char, datagram_access):
9328 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9329 (deactivate_process): Mark defn as static, as well as decl.
9330 * lisp.h (create_process): Remove decl.
9331 * process.h (chan_process, Vprocess_alist): Remove decls.
9332
ad64fc97
PE
9333 * print.c: Make symbols static if they're not exported.
9334 (print_depth, new_backquote_output, being_printed, print_buffer):
9335 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9336 (print_interval, print_number_index, initial_stderr_stream):
9337 Now static.
9338 * lisp.h (Fprinc): Remove decl.
9339 (debug_output_compilation_hack): Mark as externally visible.
9340
adddb265
PE
9341 * sysdep.c (croak): Move decl from here to syssignal.h.
9342 * syssignal.h (croak): Put it here, so the API can be checked when
9343 'croak' is called from dissociate_if_controlling_tty.
9344
1717ede2
PE
9345 * minibuf.c: Make symbols static if they're not exported.
9346 (minibuf_save_list, choose_minibuf_frame): Now static.
9347 * lisp.h (choose_minibuf_frame): Remove decl.
9348
fa5fb2bc
PE
9349 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9350
1e3890d1
PE
9351 * lread.c: Make symbols static if they're not exported.
9352 (read_objects, initial_obarray, oblookup_last_bucket_number):
9353 Now static.
9354 (make_symbol): Remove; unused.
9355 * lisp.h (initial_obarray, make_symbol): Remove decls.
9356
8a1414fa
PE
9357 * keyboard.c: Make symbols static if they're not exported.
9358 (single_kboard, recent_keys_index, total_keys, recent_keys):
9359 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9360 (this_single_command_key_start, echoing, last_auto_save):
9361 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9362 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9363 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9364 (Vlispy_mouse_stem, double_click_count):
9365 Now static.
9366 (force_auto_save_soon): Define only if SIGDANGER.
9367 (ignore_mouse_drag_p): Now static if
9368 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9369 (print_help): Remove; unused.
9370 (stop_character, last_timer_event): Mark as externally visible.
9371 * keyboard.h (ignore_mouse_drag_p): Declare only if
9372 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9373 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9374 * lisp.h (echoing): Remove decl.
9375 (force_auto_save_soon): Declare only if SIGDANGER.
9376 * xdisp.c (redisplay_window): Simplify code, to make it more
9377 obvious that ignore_mouse_drag_p is not accessed if !defined
9378 USE_GTK && !defined HAVE_NS.
9379
93ea6e8f
PE
9380 * intervals.c: Make symbols static if they're not exported.
9381 (merge_properties_sticky, merge_interval_right, delete_interval):
9382 Now static.
9383 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9384
77382fcc
PE
9385 * insdel.c: Make symbols static if they're not exported.
9386 However, leave prepare_to_modify_buffer alone. It's never
9387 called from outside this function, but that appears to be a bug.
9388 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9389 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9390 (adjust_after_replace_noundo): Remove; unused.
9391 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9392 (signal_before_change): Remove decls.
77382fcc 9393
9306c32e
PE
9394 * indent.c (val_compute_motion, val_vmotion): Now static.
9395
cd44d2eb
PE
9396 * image.c: Make symbols static if they're not exported.
9397 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9398 if USE_GTK.
9399 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9400 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9401
ad9a7a06
PE
9402 * fringe.c (standard_bitmaps): Now static.
9403 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9404
81626931
PE
9405 * frame.c: Make symbols static if they're not exported.
9406 (x_report_frame_params, make_terminal_frame): Now static.
9407 (get_frame_param): Now static, unless HAVE_NS.
9408 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9409 (x_get_resource_string): Remove; not used.
9410 * frame.h (make_terminal_frame, x_report_frame_params):
9411 (x_get_resource_string); Remove decls.
9412 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9413 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9414
239f9db9
PE
9415 * font.c, fontset.c: Make symbols static if they're not exported.
9416 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9417 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9418 * font.c (font_close_object): Now static.
9419 * font.h (font_close_object): Remove.
9420 * fontset.c (FONTSET_OBJLIST): Remove.
9421 (free_realized_fontset) #if-0 the body, which does nothing.
9422 (face_suitable_for_char_p): #if-0, as it's never called.
9423 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9424 * xfaces.c (face_at_string_position):
9425 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9426 since 0 is always ASCII.
9427
dfcf3579
PE
9428 * fns.c (weak_hash_tables): Now static.
9429
5045092b
PE
9430 * fileio.c: Make symbols static if they're not exported.
9431 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9432 (Vwrite_region_annotation_buffers): Now static.
9433
57a96f5c
PE
9434 * eval.c: Make symbols static if they're not exported.
9435 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9436 * lisp.h (backtrace_list): Remove decl.
9437
35f08c38
PE
9438 * emacs.c: Make symbols static if they're not exported.
9439 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9440 (fatal_error_code, fatal_error_signal_hook, standard_args):
9441 Now static.
9442 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9443 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9444 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9445 * lisp.h (fatal_error_signal_hook): Remove decl.
9446 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9447
f44bd759
PE
9448 * editfns.c: Move a (normally-unused) function to its only use.
9449 * editfns.c, lisp.h (get_operating_system_release): Remove.
9450 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9451 worth the hassle of breaking this out.
9452
b532497d
PE
9453 * xterm.c: Make symbols static if they're not exported.
9454 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9455 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9456 (x_destroy_window, x_delete_display):
9457 Now static.
9458 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9459 (x_mouse_leave): Remove; unused.
9460 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9461 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9462 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9463 Remove decls.
9464 (x_mouse_leave): Declare only if WINDOWSNT.
9465 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9466 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9467 USE_X_TOOLKIT.
9468
1675728f
PE
9469 * ftxfont.c: Make symbols static if they're not exported.
9470 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9471 HAVE_FREETYPE.
9472 * font.h (ftxfont_driver): Likewise.
9473
e4cebfca
PE
9474 * xfns.c: Make symbols static if they're not exported.
9475 (x_last_font_name, x_display_info_for_name):
9476 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9477 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9478 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9479 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9480 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9481 (last_show_tip_args): Now static.
9482 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9483 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9484 (x_screen_planes): Remove; unused.
9485 * dispextern.h (x_screen_planes): Remove decl.
9486
5bf46f05
PE
9487 * dispnew.c: Make symbols static if they're not exported.
9488 * dispextern.h (redraw_garbaged_frames, scrolling):
9489 (increment_row_positions): Remove.
9490 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9491 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9492 Now static.
9493 (redraw_garbaged_frames): Remove; unused.
9494
435f4c28
PE
9495 * xfaces.c: Make symbols static if they're not exported.
9496 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9497 Remove decls.
9498 * xterm.h (defined_color): Remove decls.
9499 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9500 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9501 (menu_face_changed_default, defined_color, free_realized_face):
9502 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9503 (ascii_face_of_lisp_face): Remove; unused.
9504
8524aef3
PE
9505 * xdisp.c: Make symbols static if they're not exported.
9506 * dispextern.h (scratch_glyph_row, window_box_edges):
9507 (glyph_to_pixel_coords, set_cursor_from_row):
9508 (get_next_display_element, set_iterator_to_next):
9509 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9510 (show_mouse_face): Remove decls
9511 * frame.h (message_buf_print): Likewise.
9512 * lisp.h (pop_message, set_message, check_point_in_composition):
9513 Likewise.
9514 * xterm.h (set_vertical_scroll_bar): Likewise.
9515 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9516 (message_buf_print, scratch_glyph_row, displayed_buffer):
9517 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9518 (get_next_display_element, show_mouse_face, window_box_edges):
9519 (frame_to_window_pixel_xy, check_point_in_composition):
9520 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9521 (glyph_to_pixel_coords): Remove; unused.
9522
16390cd2
PE
9523 * dired.c (file_name_completion): Now static.
9524
9525 * dbusbind.c (xd_in_read_queued_messages): Now static.
9526
a25f4dfa
PE
9527 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9528 * data.c (circular_list_error): Remove.
9529
14a9c8df
PE
9530 * commands.h (last_point_position, last_point_position_buffer):
9531 (last_point_position_window): Remove decls.
9532 * keyboard.c: Make these variables static.
9533
04f2d78b
CB
9534 * coding.h (coding, code_convert_region, encode_coding_gap):
9535 Remove decls.
74ab6df5
PE
9536 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9537 (iso_code_class, detect_coding, code_convert_region): Now static.
9538 (encode_coding_gap): Remove; unused.
9539
38dfbee1
PE
9540 * chartab.c (chartab_chars, chartab_bits): Now static.
9541
a2cb4e63
PE
9542 * charset.h (charset_iso_8859_1): Remove decl.
9543 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9544 Now static.
9545
127198fd
PE
9546 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9547 * ccl.c (Vccl_program_table): Now static.
9548 (check_ccl_update): Remove; unused.
9549
d85b608f
PE
9550 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9551 * category.h: ... from here.
9552 * category.c (check_category_table, set_category_set): Now static.
9553
31cd66f3
PE
9554 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9555 * lisp.h: Remove these decls.
9556
c358e587
PE
9557 * buffer.c (buffer_count): Remove unused var.
9558
e78aecca
PE
9559 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9560 so that it's not optimized away.
9561 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9562 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9563 exported only to the debugger.
9564
e192d7d3 9565 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9566 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9567
92470028
PE
9568 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9569 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9570 was inaccessible from Lisp.
9571 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9572 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9573
244ed907
PE
9574 alloc.c: Import and export fewer symbols, and remove unused items.
9575 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9576 is defined.
9577 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9578 it's not optimized away by whole-program optimization.
9579 (message_enable_multibyte, free_misc): Remove.
9580 (catchlist, handlerlist, mark_backtrace):
9581 Declare only if BYTE_MARK_STACK.
9582 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9583 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9584 (message_enable_multibyte): Remove decl.
9585 (free_misc, interval_free_list, float_block, float_block_index):
9586 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9587 (cons_free_list, last_marked_index):
9588 Now static.
9589 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9590 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9591 (mark_backtrace): Define only if BYTE_MARK_STACK.
9592 * xdisp.c (message_enable_multibyte): Now static.
9593
61c2b50e 9594 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9595 This makes it easier for human readers (and static analyzers)
9596 to see whether these variables are used from other modules.
9597 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9598 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9599 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9600 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9601 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9602 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9603 * xmenu.c, xselect.c:
9604 Declare Q* vars static if they are not used in other modules.
9605 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9606 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9607 Remove decls of unexported vars.
9608 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9609
95c82688
PE
9610 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9611
16a97296
PE
9612 Make Emacs functions such as Fatom 'static' by default.
9613 This makes it easier for human readers (and static analyzers)
9614 to see whether these functions can be called from other modules.
9615 DEFUN now defines a static function. To make the function external
9616 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9617 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9618 (Finit_image_library):
16a97296
PE
9619 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9620 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9621 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9622 Remove decls, since these functions are now static.
9623 (Funintern, Fget_internal_run_time): New decls, since these functions
9624 were already external.
95c82688 9625
16a97296
PE
9626 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9627 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9628 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9629 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9630 * keyboard.c, keymap.c, lread.c:
9631 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9632 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9633 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9634 Mark functions with DEFUE instead of DEFUN,
9635 if they are used in other modules.
9636 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9637 decls for now-static functions.
9638 * buffer.h (Fdelete_overlay): Remove decl.
9639 * callproc.c (Fgetenv_internal): Mark as internal.
9640 * composite.c (Fremove_list_of_text_properties): Remove decl.
9641 (Fcomposition_get_gstring): New forward static decl.
9642 * composite.h (Fcomposite_get_gstring): Remove decl.
9643 * dired.c (Ffile_attributes): New forward static decl.
9644 * doc.c (Fdocumntation_property): New forward static decl.
9645 * eval.c (Ffetch_bytecode): New forward static decl.
9646 (Funintern): Remove extern decl; now in .h file where it belongs.
9647 * fileio.c (Fmake_symbolic_link): New forward static decl.
9648 * image.c (Finit_image_library): New forward static decl.
9649 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9650 * intervals.h (Fprevious_property_change):
9651 (Fremove_list_of_text_properties): Remove decls.
9652 * keyboard.c (Fthis_command_keys): Remove decl.
9653 (Fcommand_execute): New forward static decl.
9654 * keymap.c (Flookup_key): New forward static decl.
9655 (Fcopy_keymap): Now static.
9656 * keymap.h (Flookup_key): Remove decl.
9657 * process.c (Fget_process): New forward static decl.
9658 (Fprocess_datagram_address): Mark as internal.
9659 * syntax.c (Fsyntax_table_p): New forward static decl.
9660 (skip_chars): Remove duplicate decl.
9661 * textprop.c (Fprevious_property_change): New forward static decl.
9662 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9663 Now internal.
9664 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9665 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9666
785bbd42
PE
9667 * editfns.c (Fformat): Remove unreachable code.
9668
8b913b57
AS
96692011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9670
9671 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9672 change. (Bug#8496)
9673
a6744a35
EZ
96742011-04-13 Eli Zaretskii <eliz@gnu.org>
9675
9676 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9677 when at ZV. (Bug#8487)
9678
e7974947
AS
96792011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9680
baad03f0
AS
9681 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9682 (Bug#8437)
9683 * keyboard.c (parse_tool_bar_item): Likewise.
9684 * sound.c (sound_cleanup, alsa_close): Likewise.
9685 * termcap.c (tgetent): Likewise.
9686 * xfns.c (x_default_font_parameter): Likewise.
9687 * xsettings.c (read_and_apply_settings): Likewise.
9688
e7974947
AS
9689 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9690 (overrun_check_free): Protoize.
9691
28272684
PE
96922011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9693
9694 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9695 since callers should never pass a negative size.
9696 Change the signature to match that of plain 'read' and 'write'; see
9697 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9698 * lisp.h: Update prototypes of emacs_write and emacs_read.
9699
11997c76
EZ
97002011-04-11 Eli Zaretskii <eliz@gnu.org>
9701
9702 * xdisp.c (redisplay_window): Don't try to determine the character
9703 position of the scroll margin if the window start point w->startp
e896f03c 9704 is outside the buffer's accessible region. (Bug#8468)
11997c76 9705
8a2cbd72
EZ
97062011-04-10 Eli Zaretskii <eliz@gnu.org>
9707
9708 Fix write-region and its subroutines for buffers > 2GB.
9709 * fileio.c (a_write, e_write): Modify declaration of arguments and
9710 local variables to support buffers larger than 2GB.
9711 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9712
9713 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9714 argument, local variables, and return value.
9715
9716 * lisp.h: Update prototypes of emacs_write and emacs_read.
9717
9718 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9719
4073e537 97202011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9721
1ebfdcb6
PE
9722 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9723
b2ded58d
PE
9724 Fix more problems found by GCC 4.6.0's static checks.
9725
7d66342c
PE
9726 * xdisp.c (vmessage): Use a better test for character truncation.
9727
bbf47d44
PE
9728 * charset.c (load_charset_map): <, not <=, for optimization,
9729 and to avoid potential problems with integer overflow.
9248994d 9730 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9731 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9732 * editfns.c (Fformat): Likewise.
1e69125e 9733 * syntax.c (skip_chars): Likewise.
3befa583 9734
e3019616
PE
9735 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9736 This also lets GCC 4.6.0 generate slightly better loop code.
9737
becfa255
PE
9738 * callint.c (Fcall_interactively): <, not <=, for optimization.
9739 (Fcall_interactively): Count the number of arguments produced,
9740 not the number of arguments given. This is simpler and lets GCC
9741 4.6.0 generate slightly better code.
9742
dae0cd48
PE
9743 * ftfont.c: Distingish more carefully between FcChar8 and char.
9744 The previous code passed unsigned char * to a functions like
9745 strlen and xstrcasecmp that expect char *, which does not
9746 conform to the C standard.
9747 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9748 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9749 char * when the C standard requires it.
9750
76032d70
PE
9751 * keyboard.c (read_char): Remove unused var.
9752
eb3f1cc8
PE
9753 * eval.c: Port to Windows vsnprintf (Bug#8435).
9754 Include <limits.h>.
9755 (SIZE_MAX): Define if the headers do not.
9756 (verror): Do not give up if vsnprintf returns a negative count.
9757 Instead, grow the buffer. This ports to Windows vsnprintf, which
9758 does not conform to C99. Problem reported by Eli Zaretskii.
9759 Also, simplify the allocation scheme, by avoiding the need for
9760 calling realloc, and removing the ALLOCATED variable.
9761
70476b54
PE
9762 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9763
12020a9e
PE
9764 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9765 But keep the doprint source code for now, as we might revamp it
9766 and use it again (Bug#8435).
ea6c7ae6
PE
9767 * lisp.h (doprnt): Remove.
9768 * Makefile.in (base_obj): Remove doprnt.o.
9769 * deps.mk (doprnt.o): Remove.
9770
5fdb398c
PE
9771 error: Print 32- and 64-bit integers portably (Bug#8435).
9772 Without this change, on typical 64-bit hosts error ("...%d...", N)
9773 was used to print both 32- and 64-bit integers N, which relied on
9774 undefined behavior.
61bdb816 9775 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
9776 * lisp.h (error, verror): Mark as printf-like functions.
9777 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9778 Report overflow in size calculations when allocating printf buffer.
9779 Do not truncate output string at its first null byte.
9780 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9781 Truncate the output at a character boundary, since vsnprintf does not
9782 do that.
9783 * charset.c (check_iso_charset_parameter): Convert internal
9784 character to string before calling 'error', since %c now has the
9785 printf meaning.
9786 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9787 overflow when computing char to be passed to 'error'. Do not
9788 pass Lisp_Object to 'error'; pass the integer instead.
9789 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9790 formatted with plain %d.
9791
b189fa66
PE
9792 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9793
bff87ef0
PE
9794 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9795
7e2cac20
PE
9796 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9797
ce4d90b5
PE
9798 * xterm.c (x_catch_errors): Remove duplicate declaration.
9799
266c9547
PE
9800 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9801
79c49ad2
PE
9802 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9803
368f4090
JM
98042011-04-10 Jim Meyering <meyering@redhat.com>
9805
9806 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9807 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9808 return ssize_t not "int", and use size_t as the buffer length.
9809 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9810 * gnutls.h: Update declarations.
9811 * process.c (read_process_output): Use ssize_t, to match.
9812 (send_process): Likewise.
9813
a32d4040
CY
98142011-04-09 Chong Yidong <cyd@stupidchicken.com>
9815
9816 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9817
8546720e 98182011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 9819
04f2d78b
CB
9820 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9821 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 9822
8546720e
GM
9823 * xterm.c (handle_one_xevent):
9824 * xmenu.c (create_and_show_popup_menu):
9825 * xselect.c (x_decline_selection_request)
9826 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 9827
0a2f5c1a 98282011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
9829
9830 Fix some uses of `int' instead of EMACS_INT.
9831 * search.c (string_match_1, fast_string_match)
9832 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9833 (scan_buffer, find_next_newline_no_quit)
9834 (find_before_next_newline, search_command, Freplace_match)
9835 (Fmatch_data): Make some `int' variables be EMACS_INT.
9836
9837 * xdisp.c (display_count_lines): 3rd argument and return value now
9838 EMACS_INT. All callers changed.
9839 (pint2hrstr): Last argument is now EMACS_INT.
9840
9841 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9842 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9843 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9844 (decode_coding_utf_16, decode_coding_emacs_mule)
9845 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9846 (decode_coding_ccl, decode_coding_charset)
9847 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9848 (decode_coding_iso_2022, decode_coding_emacs_mule)
9849 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9850 <char_offset, last_offset>: Declare EMACS_INT.
9851 (encode_coding_utf_8, encode_coding_utf_16)
9852 (encode_coding_emacs_mule, encode_invocation_designation)
9853 (encode_designation_at_bol, encode_coding_iso_2022)
9854 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9855 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9856 Declare EMACS_INT.
9857 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9858 (encode_invocation_designation): Last argument P_NCHARS is now
9859 EMACS_INT.
9860 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9861 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9862
9863 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9864 All users changed.
9865
9866 * ccl.c (Fccl_execute_on_string): Declare some variables
9867 EMACS_INT.
9868
8546720e 98692011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
9870
9871 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9872
4e19a977
CS
98732011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9874
9875 * process.c (Fformat_network_address): Doc fix.
9876
87302331
R
98772011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9878
ee7683eb 9879 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 9880
cbb59342
CY
98812011-04-08 Chong Yidong <cyd@stupidchicken.com>
9882
9883 * keyboard.c (read_char): Call Lisp function help-form-show,
9884 instead of using internal_with_output_to_temp_buffer.
9885 (Qhelp_form_show): New var.
e0d38eeb 9886 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
9887
9888 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9889
9890 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9891
e67a13ab
CY
98922011-04-06 Chong Yidong <cyd@stupidchicken.com>
9893
04f2d78b
CB
9894 * process.c (Flist_processes): Remove to Lisp.
9895 (list_processes_1): Delete.
e67a13ab 9896
973f782d
EZ
98972011-04-06 Eli Zaretskii <eliz@gnu.org>
9898
7c106b1e
EZ
9899 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9900
973f782d
EZ
9901 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9902
41cf7d1a 99032011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 9904
ca23cc88
PE
9905 Fix more problems found by GCC 4.6.0's static checks.
9906
f390e2d5
PE
9907 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9908
42eea0d0
PE
9909 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9910
b69769da 9911 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 9912
f9541e84
PE
9913 * xdisp.c (vmessage): Mark as a printf-like function.
9914
13841b55
PE
9915 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9916
c136c10f
PE
9917 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9918
5e2d4a30
PE
9919 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9920 printf-like functions.
9921 (tiff_load): Add casts to remove these marks before passing them
9922 to system-supplied API.
9923
583f48b9
PE
9924 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9925
b25d760e
PE
9926 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9927 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
9928 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9929 directly, rather than having caller test rule sign. This avoids
9930 some unnecessary tests.
9931 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9932 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9933 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 9934
bc7b6697 9935 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 9936 (xfont_open): Avoid unnecessary tests.
bc7b6697 9937
27ccc379
PE
9938 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9939
dcd5c89a
PE
9940 * composite.h, composite.c (composition_gstring_put_cache):
9941 Use EMACS_INT, not int, for length.
9942
b13a45c6
PE
9943 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9944 breaking out part of COMPOSITION_DECODE_RULE.
9945 (COMPOSITION_DECODE_RULE): Use it.
9946 * composite.c (get_composition_id): Remove unused local vars,
9947 by using the new macro.
9948
1e792e4d
PE
9949 * textprop.c (set_text_properties_1): Change while to do-while,
9950 since the condition is always true at first.
9951
dc6c6455 9952 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
9953 (interval_deletion_adjustment): Return unsigned value.
9954 All uses changed.
dc6c6455 9955
aba7731a
PE
9956 * process.c (list_processes_1, create_pty, read_process_output):
9957 (exec_sentinel): Remove vars that were set but not used.
afd4052b 9958 (create_pty): Remove unnecessary "volatile"s.
bc57d757 9959 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 9960 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 9961 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 9962
fdfc4bf3
PE
9963 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9964
fca8fe46 9965 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 9966 (update_syntax_table): Use unsigned instead of int.
fca8fe46 9967
06a0259a 9968 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 9969 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 9970 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 9971
e7b9e80f
PE
9972 * print.c (print_error_message): Avoid int overflow.
9973
56201685
PE
9974 * font.c (font_list_entities): Redo for clarity,
9975 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9976
78834453 9977 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 9978 (font_score): Avoid potential overflow in diff calculation.
78834453 9979
0bc0b309 9980 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 9981 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 9982
e610eaca
PE
9983 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9984
b895abce
PE
9985 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9986 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9987 can always succeed if overflow has undefined behavior.
9988
1f1d9321 9989 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 9990 (wordify): Omit three unnecessary tests.
1f1d9321 9991
c59478bc
PE
9992 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9993 All callers changed. This avoids the need for an unused var.
9994
79b73827
PE
9995 * casefiddle.c (casify_region): Remove var that is set but not used.
9996
a4db5dfe
PE
9997 * dired.c (file_name_completion): Remove var that is set but not used.
9998
43aae36e
PE
9999 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10000
2a47c44d 10001 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10002 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10003
a37c69bf
PE
10004 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10005 Check for integer overflow on size calculations.
10006
328ab8e7
PE
10007 * buffer.c (Fprevious_overlay_change): Remove var that is set
10008 but not used.
10009
e5a2a5cb
PE
10010 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10011 Remove vars that are set but not used.
8d84a6eb 10012 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10013 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10014
a60e5f68
PE
10015 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10016
f661cb61 10017 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10018 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10019
f0397f5a
PE
10020 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10021 that are set but not used.
10022
8664db06 10023 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10024 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10025
6abdaa4a
PE
10026 * xselect.c (x_get_local_selection, x_handle_property_notify):
10027 Remove vars that are set but not used.
10028
0ce7538d 10029 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10030 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10031
9ae848fc
PE
10032 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10033 Remove var that is set but not used.
0b918413
PE
10034 (scroll_bar_windows_size): Now size_t, not int.
10035 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10036 Check for overflow.
9ae848fc 10037
a5a62657
PE
10038 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10039 (map_tty_color) [!defined MSDOS]: Likewise.
10040
5c5cdd39
PE
10041 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10042
66ebf983
PE
10043 * coding.c: Remove vars that are set but not used.
10044 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10045 All callers changed.
10046 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10047 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10048 (decode_coding_charset): Remove vars that are set but not used.
10049
1be4d761
PE
10050 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10051 that is set but not used.
10052
47553fa8
PE
10053 * print.c (print_object): Remove var that is set but not used.
10054
1f7196bf 10055 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10056 The gnulib version avoids calling malloc in the usual case,
10057 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10058 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10059 * filelock.c (current_lock_owner): Likewise.
10060 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10061 * sysdep.c: Include allocator.h, careadlinkat.h.
10062 (emacs_no_realloc_allocator): New static constant.
10063 (emacs_readlink): New function.
fdb61804
PE
10064 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10065 ../lib/careadlinkat.h.
d1fdcab7 10066
f84c17c7
SM
100672011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10068
10069 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10070 first non-nil return value).
10071
ef3862ad
JD
100722011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10073
10074 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10075 if not defined (Bug#8403).
10076
376a7006
JB
100772011-04-02 Juanma Barranquero <lekktu@gmail.com>
10078
10079 * xdisp.c (display_count_lines): Remove parameter `start',
10080 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10081 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10082 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10083 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10084 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10085 and thereabouts. All callers changed.
10086 (get_per_char_metric): Remove parameter `f', unused since
10087 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10088
6ca3801d
JM
100892011-04-02 Jim Meyering <meyering@redhat.com>
10090
10091 do not dereference NULL upon failed strdup
10092 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10093 (ns_get_family): Likewise.
10094
d8e2b5ba
JB
100952011-04-02 Juanma Barranquero <lekktu@gmail.com>
10096
10097 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10098
8c74fcbd
JD
100992011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10100
10101 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10102 later (Bug#8403).
10103
7200d79c
SM
101042011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10105
03408648 10106 Add lexical binding.
7200d79c 10107
03408648
SM
10108 * window.c (Ftemp_output_buffer_show): New fun.
10109 (Fsave_window_excursion):
10110 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10111
10112 * lread.c (lisp_file_lexically_bound_p): New function.
10113 (Fload): Bind Qlexical_binding.
10114 (readevalloop): Remove `evalfun' arg.
10115 Bind Qinternal_interpreter_environment.
10116 (Feval_buffer): Bind Qlexical_binding.
10117 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10118 Mark as dynamic.
10119 (syms_of_lread): Declare `lexical-binding'.
10120
10121 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10122
10123 * keyboard.c (eval_dyn): New fun.
10124 (menu_item_eval_property): Use it.
ca105506
SM
10125
10126 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10127
03408648
SM
10128 * fns.c (concat, mapcar1): Accept byte-code-functions.
10129
10130 * eval.c (Fsetq): Handle lexical vars.
10131 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10132 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10133 (FletX, Flet): Obey lexical binding.
10134 (Fcommandp): Handle closures.
10135 (Feval): New `lexical' arg.
10136 (eval_sub): New function extracted from Feval. Use it almost
10137 everywhere where Feval was used. Look up vars in lexical env.
10138 Handle closures.
10139 (Ffunctionp): Move from subr.el.
10140 (Ffuncall): Handle closures.
10141 (apply_lambda): Remove `eval_flags'.
10142 (funcall_lambda): Handle closures and new byte-code-functions.
10143 (Fspecial_variable_p): New function.
10144 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10145 but without exporting it to Lisp.
23aba0ea 10146
23aba0ea 10147 * doc.c (Fdocumentation, store_function_docstring):
03408648 10148 * data.c (Finteractive_form): Handle closures.
23aba0ea 10149
03408648
SM
10150 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10151 interactive spec.
ba83908c 10152
04f2d78b
CB
10153 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10154 New byte-codes.
03408648
SM
10155 (exec_byte_code): New function extracted from Fbyte_code to handle new
10156 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10157
03408648 10158 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10159
03408648 10160 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10161
e2abce01
JB
101622011-03-31 Juanma Barranquero <lekktu@gmail.com>
10163
10164 * xdisp.c (redisplay_internal): Fix prototype.
10165
63696a73 101662011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10167
63696a73 10168 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10169 (try_scrolling): Use it when setting scroll_limit.
10170 Limit scrolling to 100 screen lines.
63696a73
EZ
10171 (redisplay_window): Even when falling back on "recentering",
10172 position point in the window according to scroll-conservatively,
10173 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10174
10175 (try_scrolling): When point is above the window, allow searching
10176 as far as scroll_max, or one screenful, to compute vertical
10177 distance from PT to the scroll margin position. This prevents
10178 try_scrolling from unnecessarily failing when
10179 scroll-conservatively is set to a value slightly larger than the
10180 window height. Clean up the case of PT below the margin at bottom
10181 of window: scroll_max can no longer be INT_MAX. When aggressive
10182 scrolling is in use, don't let point enter the opposite scroll
10183 margin as result of the scroll.
10184 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10185 threshold of 100 lines for never-recentering scrolling.
10186
e4cc2dfc
JB
101872011-03-31 Juanma Barranquero <lekktu@gmail.com>
10188
10189 * dispextern.h (move_it_by_lines):
10190 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10191 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10192 (message_log_check_duplicate): Remove parameters `prev_bol' and
10193 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10194 (redisplay_internal): Remove parameter `preserve_echo_area',
10195 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10196
10197 * indent.c (Fvertical_motion):
10198 * window.c (window_scroll_pixel_based, Frecenter):
10199 Don't pass `need_y_p' to `move_it_by_lines'.
10200
1c470562
SM
102012011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10202
44f230aa
SM
10203 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10204 steal a few bits to be more compact.
10205 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10206 Remove unneeded casts.
10207
1c470562
SM
10208 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10209
888adce9
ZK
102102011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10211
10212 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10213 binding" message (bug#7967).
10214
f838ed7b
PE
102152011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10216
77861b95
PE
10217 Fix more problems found by GCC 4.6.0's static checks.
10218
de6dbc14
PE
10219 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10220 Remove unused local var.
10221
f838ed7b
PE
10222 * editfns.c (Fmessage_box): Remove unused local var.
10223
792c7b2b
PE
10224 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10225 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10226 Omit unused local vars.
c499e557 10227 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10228 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10229 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10230 Omit unused local var.
10231
ba0165e1
PE
10232 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10233 Don't assume string length fits in int.
32ad8845 10234 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10235 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10236
3c59b4c9
PE
10237 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10238 instead of alloca (Bug#8344).
10239
a3eed478 10240 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10241 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10242
eb4d412d
PE
10243 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10244
1658b401
PE
10245 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10246 concerns.
10247
10248 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10249
10250 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10251
9a2c6e05
PE
10252 * keyboard.c (syms_of_keyboard): Use the same style as later
10253 in this function when indexing through an array. This also
10254 works around GCC bug 48267.
10255
03d0a109
PE
10256 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10257
44f730c8
PE
10258 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10259
fe75f926
PE
10260 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10261 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10262
ffa8c828
PE
10263 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10264 This avoids undefined behavior on integer overflow, and is a bit
10265 more convenient anyway since it is compared to a size_t variable.
10266
c5101a77
PE
10267 Variadic C functions now count arguments with size_t, not int.
10268 This avoids an unnecessary limitation on 64-bit machines, which
10269 caused (substring ...) to crash on large vectors (Bug#8344).
10270 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10271 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10272 All variadic functions and their callers changed accordingly.
c5101a77
PE
10273 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10274 * data.c (arith_driver, float_arith_driver): Likewise.
10275 * editfns.c (general_insert_function): Likewise.
10276 * eval.c (struct backtrace.nargs, interactive_p)
10277 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10278 (funcall_lambda, mark_backtrace): Likewise.
10279 * fns.c (concat): Likewise.
10280 * frame.c (x_set_frame_parameters): Likewise.
10281 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10282 0 if not found, not -1. All callers changed.
10283
dd3f25f7
PE
10284 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10285 (stack_copy_size): Now size_t, not int.
10286 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10287
461c2ab9
JB
102882011-03-28 Juanma Barranquero <lekktu@gmail.com>
10289
10290 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10291 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10292 All callers changed.
10293
10294 * lisp.h (multibyte_char_to_unibyte):
10295 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10296 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10297 * character.h (CHAR_TO_BYTE8):
10298 * cmds.c (internal_self_insert):
10299 * editfns.c (general_insert_function):
10300 * keymap.c (push_key_description):
10301 * search.c (Freplace_match):
10302 * xdisp.c (message_dolog, set_message_1): All callers changed.
10303
f6d62986
SM
103042011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10305
10306 * keyboard.c (safe_run_hook_funcall): New function.
10307 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10308 don't set the hook to nil, but remove the offending function instead.
10309 (Qcommand_hook_internal): Remove, unused.
10310 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10311 Vcommand_hook_internal.
10312
10313 * eval.c (enum run_hooks_condition): Remove.
10314 (funcall_nil, funcall_not): New functions.
10315 (run_hook_with_args): Call each function through a `funcall' argument.
10316 Remove `cond' argument, now redundant.
10317 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10318 (Frun_hook_with_args_until_failure): Adjust accordingly.
10319 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10320
1db5b1ad
JB
103212011-03-28 Juanma Barranquero <lekktu@gmail.com>
10322
10323 * dispextern.h (string_buffer_position): Remove declaration.
10324
10325 * print.c (strout): Remove parameter `multibyte', unused since
10326 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10327
10328 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10329 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10330 All callers changed.
10331
10332 * w32.c (_wsa_errlist): Use braces for struct initializers.
10333
10334 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10335 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10336 All callers changed.
10337 (string_buffer_position): Likewise. Also, make static (it's never
10338 used outside xdisp.c).
10339 (cursor_row_p): Remove parameter `w', unused since
10340 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10341 (decode_mode_spec): Remove parameter `precision', introduced during
10342 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10343 All callers changed.
10344
5ffb62aa
JD
103452011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10346
10347 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10348
461c2ab9 103492011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10350
10351 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10352 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10353 (ns_update_auto_hide_menu_bar): New functions.
10354 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10355 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10356 ns_constrain_all_frames.
10357 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10358 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10359
5c380ffb
JD
103602011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10361
10362 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10363
9af30bdf
GM
103642011-03-27 Glenn Morris <rgm@gnu.org>
10365
10366 * syssignal.h: Replace RETSIGTYPE with void.
10367 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10368 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10369 Replace SIGTYPE with void everywhere.
10370 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10371 * s/template.h (SIGTYPE): Remove commented out definition.
10372
e2abce01
JB
103732011-03-26 Eli Zaretskii <eliz@gnu.org>
10374
10375 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10376 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10377
f868cd8a
JB
103782011-03-26 Juanma Barranquero <lekktu@gmail.com>
10379
59eb0929
JB
10380 * w32.c (read_unc_volume): Use parameter `henum', instead of
10381 global variable `wget_enum_handle'.
10382
10383 * keymap.c (describe_vector): Remove parameters `indices' and
10384 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10385 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10386
f868cd8a
JB
10387 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10388
10389 * keyboard.c (timer_check): Remove parameter `do_it_now',
10390 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10391 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10392 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10393
10394 * keyboard.c (read_char):
10395 * w32menu.c (w32_menu_display_help):
10396 * xmenu.c (show_help_event, menu_help_callback):
10397 Adjust calls to `show_help_echo'.
10398
10399 * gtkutil.c (xg_maybe_add_timer):
10400 * keyboard.c (readable_events):
10401 * process.c (wait_reading_process_output):
10402 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10403
10404 * insdel.c (adjust_markers_gap_motion):
10405 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10406 (gap_left, gap_right): Don't call it.
10407
2ecf6fdb
CY
104082011-03-25 Chong Yidong <cyd@stupidchicken.com>
10409
10410 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10411 incurred during fontification.
10412
6b1f9ba4
JB
104132011-03-25 Juanma Barranquero <lekktu@gmail.com>
10414
10415 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10416 (DEFVAR_PER_BUFFER): Don't pass it.
10417
10418 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10419 (scrolling_window): Don't pass it.
10420
0f4a96b5
JB
104212011-03-25 Juanma Barranquero <lekktu@gmail.com>
10422
10423 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10424
10425 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10426 and `suffix'.
10427 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10428 of variables specific to SELinux and computation of `encoded_absname'.
10429
10430 * image.c (XPutPixel): Remove unused variable `height'.
10431
10432 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10433
10434 * unexw32.c (get_section_info): Remove unused variable `section'.
10435
10436 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10437 (system_process_attributes): Remove unused variable `sess'.
10438 (sys_read): Remove unused variable `err'.
10439
10440 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10441 (w32_wnd_proc): Remove unused variable `isdead'.
10442 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10443 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10444 (x_create_tip_frame): Remove unused variable `tem'.
10445
10446 * w32inevt.c (w32_console_read_socket):
10447 Remove unused variable `no_events'.
10448
10449 * w32term.c (x_draw_composite_glyph_string_foreground):
10450 Remove unused variable `width'.
10451
1149507c
JB
104522011-03-24 Juanma Barranquero <lekktu@gmail.com>
10453
10454 * w32term.c (x_set_glyph_string_clipping):
10455 Don't pass uninitialized region to CombineRgn.
10456
9c88f339
JB
104572011-03-23 Juanma Barranquero <lekktu@gmail.com>
10458
10459 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10460 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10461 (Fx_close_connection): Remove unused variable `i'.
10462
10463 * w32font.c (w32font_draw): Return number of glyphs.
10464 (w32font_open_internal): Remove unused variable `i'.
10465 (w32font_driver): Add missing initializer.
10466
10467 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10468 (fill_in_menu): Remove unused variable `items_added'.
10469
10470 * w32term.c (last_mouse_press_frame): Remove static global variable.
10471 (w32_clip_to_row): Remove unused variable `f'.
10472 (x_delete_terminal): Remove unused variable `i'.
10473
10474 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10475 (NOTHING): Remove unused static global variable.
10476 (uniscribe_check_otf): Remove unused variable `table'.
10477 (uniscribe_font_driver): Add missing initializers.
10478
dee091a3
JD
104792011-03-23 Julien Danjou <julien@danjou.info>
10480
10481 * term.c (Fsuspend_tty, Fresume_tty):
10482 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10483 * window.c (temp_output_buffer_show):
10484 * insdel.c (signal_before_change):
10485 * frame.c (Fhandle_switch_frame):
10486 * fileio.c (Fdo_auto_save):
10487 * emacs.c (Fkill_emacs):
10488 * editfns.c (save_excursion_restore):
10489 * cmds.c (internal_self_insert):
10490 * callint.c (Fcall_interactively):
10491 * buffer.c (Fkill_all_local_variables):
10492 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10493 Use Frun_hooks.
0f4a96b5 10494 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10495 unconditionally since it does the check itself.
dee091a3 10496
2c520ab5 104972011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10498
c9c49752
PE
10499 Fix more problems found by GCC 4.5.2's static checks.
10500
8abc3f12
PE
10501 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10502 the first time through the loop, since we know p0 < p1 then.
10503 This also avoids a gcc -Wstrict-overflow warning.
10504
a2d26660
PE
10505 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10506 leading to a memory leak, possible in functions like
10507 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10508 of objects (Bug#8318).
a2d26660 10509
916c72e9
PE
10510 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10511 that could (at least in theory) be that large.
10512
19ab8a18
PE
10513 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10514 This is less likely to overflow, and avoids undefined behavior if
10515 overflow does occur. All callers changed. Use strtoul to scan
10516 for the unsigned long integer.
b7cbbd6f
PE
10517 (pint2hrstr): Simplify and tune code slightly.
10518 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10519
f0641eff
PE
10520 * scroll.c (do_scrolling): Work around GCC bug 48228.
10521 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10522
7f650bb9
PE
10523 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10524 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10525 (validate_x_resource_name): Simplify count usage.
10526 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10527
37dd57d1
PE
10528 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10529 fail (Bug#8306).
81e56e61 10530
699979fc 10531 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10532
401bf9b4
PE
10533 * process.c (Fmake_network_process): Use socklen_t, not int,
10534 where POSIX says socklen_t is required in portable programs.
10535 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10536 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10537 (Fmake_network_process, server_accept_connection):
10538 (wait_reading_process_output, read_process_output):
10539 Likewise.
10540
b93aacde
PE
10541 * process.c: Rename or move locals to avoid shadowing.
10542 (list_processes_1, Fmake_network_process):
10543 (read_process_output_error_handler, exec_sentinel_error_handler):
10544 Rename or move locals.
4dc343ee 10545 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10546 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10547 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10548 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10549 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10550
af8a867c 10551 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10552 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10553 Include tparam.h instead, since it declares them.
af8a867c
PE
10554 * cm.h (PC): Remove extern decl; tparam.h now does this.
10555 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10556 * terminfo.c: Include tparam.h, to check interfaces.
10557 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10558 (tparam): Adjust signature to match interface in tparam.h;
10559 this removes some undefined behavior. Check that outstring and len
10560 are zero, which they always are with Emacs.
10561 * tparam.h (PC, BC, UP): New extern decls.
10562
0248044d 10563 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10564 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10565
8ff096c1 10566 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10567 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10568 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10569 (ftfont_list): Remove unused local.
49eaafba
PE
10570 (get_adstyle_property, ftfont_pattern_entity):
10571 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10572 Rename locals to avoid shadowing.
8ff096c1 10573
e2be39f6
PE
10574 * xfont.c (xfont_list_family): Mark var as initialized.
10575
c9735e30
PE
10576 * xml.c (make_dom): Now static.
10577
8f5201ae
PE
10578 * composite.c (composition_compute_stop_pos): Rename local to
10579 avoid shadowing.
b246f932
PE
10580 (composition_reseat_it): Remove unused locals.
10581 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10582 (composition_update_it): Mark var as initialized.
11b61122
PE
10583 (find_automatic_composition): Mark vars as initialized,
10584 with a FIXME (Bug#8290).
8f5201ae 10585
760fbc2c
PE
10586 character.h: Rename locals to avoid shadowing.
10587 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10588 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10589 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10590 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10591 to avoid shadowing.
10592
ff08eb85
PE
10593 * textprop.c (property_change_between_p): Remove; unused.
10594
fc7bf025
PE
10595 * intervals.c (interval_start_pos): Now static.
10596
235d7abc
PE
10597 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10598
44f230aa
SM
10599 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10600 Rename locals to avoid shadowing.
3e7d6594 10601
50060332
PE
10602 * sound.c (wav_play, au_play, Fplay_sound_internal):
10603 Fix pointer signedness.
d01f234b 10604 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10605 (wav_play): Initialize a variable to 0, to prevent undefined
10606 behavior (Bug#8278).
50060332 10607
c4fc4e30
PE
10608 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10609
918436ed
PE
10610 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10611
c939f91b
PE
10612 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10613 clobbering (Bug#8298).
b9c7f648
PE
10614 * sysdep.c (sys_subshell): Likewise.
10615 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10616
6bd8c144
PE
10617 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10618 This should get cleaned up, so that child_setup has the
10619 same signature on all platforms.
10620
7710357c 10621 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10622 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10623
c59da222
CY
106242011-03-22 Chong Yidong <cyd@stupidchicken.com>
10625
10626 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10627 not to be necessary, and produces flickering.
10628
66b87493
GM
106292011-03-20 Glenn Morris <rgm@gnu.org>
10630
10631 * config.in: Remove file.
10632
45b6f6d5
JB
106332011-03-20 Juanma Barranquero <lekktu@gmail.com>
10634
10635 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10636 are now in src/globals.h.
10637 (syms_of_minibuf): Remove spurious & from previous change.
10638
cd394be1 106392011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10640
10641 * minibuf.c (completing-read-function): New variable.
10642 (completing-read-default): Rename from completing-read.
10643 (completing-read): Call completing-read-function.
10644
b14e3e21
CY
106452011-03-19 Juanma Barranquero <lekktu@gmail.com>
10646
10647 * xfaces.c (Fx_load_color_file):
10648 Read color file from absolute filename (bug#8250).
10649
f2b726e6
JB
106502011-03-19 Juanma Barranquero <lekktu@gmail.com>
10651
10652 * makefile.w32-in: Update dependencies.
10653
09f6ff02
EZ
106542011-03-17 Eli Zaretskii <eliz@gnu.org>
10655
10656 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10657
29a6015a
PE
106582011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10659
a3a6c54e
PE
10660 Fix more problems found by GCC 4.5.2's static checks.
10661
b766f867
PE
10662 * process.c (make_serial_process_unwind, send_process_trap):
10663 (sigchld_handler): Now static.
10664
be02381c
PE
10665 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10666 That way, the code declares only the vars that it needs.
10667 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10668 * s/cygwin.h (PTY_ITERATION): Likewise.
10669 * s/darwin.h (PTY_ITERATION): Likewise.
10670 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10671
57048744
PE
10672 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10673 * process.c (allocate_pty): Don't declare stb unless it's needed.
10674
7914961c 10675 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10676 (CONSTANTLIM): Remove; unused.
10677 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10678 Define only if needed.
7914961c 10679
b3967b18
PE
10680 * unexelf.c (unexec): Name an expression,
10681 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10682 Use a different way to cause a compilation error if anyone uses
10683 n rather than nn, a way that does not involve shadowing.
73366a00 10684 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10685
29a6015a
PE
10686 * deps.mk (unexalpha.o): Remove; unused.
10687
43cfc33e 10688 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10689 * unexec.h: New file.
ce701a33
PE
10690 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10691 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10692 Depend on unexec.h.
10693 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10694 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10695 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10696 Change as necessary to match prototype in unexec.h.
ce701a33 10697
01f44d5a
PE
10698 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10699 shadowing.
4f63c6bb 10700 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10701
a6670b0b
PE
10702 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10703 Rename locals to avoid shadowing.
10704
cef2010d 10705 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10706 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10707
d4d7173a
PE
10708 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10709
f08b802a
PE
10710 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10711 warning when compiling print.c.
10712
3ddb0639
PE
10713 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10714 instead of using an uninitialized var.
5ad03b97 10715 (font_sort_entities): Mark var as initialized.
3ddb0639 10716
170a2692
PE
10717 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10718
e663c700
PE
10719 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10720 pointers to constants.
89bc529a 10721 (font_parse_fcname): Remove unused vars.
7b81e2d0 10722 (font_delete_unmatched): Now static.
ea838e10 10723 (font_get_spec): Remove; unused.
13a547c6
PE
10724 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10725 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10726 Rename or move locals to avoid shadowing.
e663c700 10727
2a80c887 10728 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10729 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10730
1384fa33 10731 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10732 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10733
8b2c52e9
PE
10734 * alloc.c (mark_backtrace): Move decl from here ...
10735 * lisp.h: ... to here, so that it can be checked.
10736
475545b5 10737 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10738 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10739 (lisp_indirect_variable): Name an expression,
10740 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10741 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10742
b1349114 10743 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10744 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10745 Use const pointer when appropriate.
b1349114 10746
a2928364
PE
10747 * lisp.h (get_system_name, get_operating_system_release):
10748 Move decls here, to check interfaces.
10749 * process.c (get_operating_system_release): Move decl to lisp.h.
10750 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
10751 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10752 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10753 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
10754 (Fformat_time_string, Fencode_time, Finsert_char):
10755 (Ftranslate_region_internal, Fformat):
10756 Rename or remove local vars to avoid shadowing.
9710023e 10757 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 10758
a415e694
PE
10759 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10760 avoid shadowing.
10761
8ef4622d
PE
10762 * lisp.h (eassert): Check that the argument compiles, even if
10763 ENABLE_CHECKING is not defined.
10764
946f9a5b
PE
10765 * data.c (Findirect_variable): Name an expression, to avoid
10766 gcc -Wbad-function-cast warning.
112396d6 10767 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 10768 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
10769 (Fmake_variable_buffer_local, Fmake_local_variable):
10770 Mark variables as initialized.
52746918 10771 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 10772
e5aab7e7 10773 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
10774 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10775 Rename locals to avoid shadowing.
dff45157
PE
10776 (mark_stack): Move local variables into the #ifdef region where
10777 they're used.
7bc26fdb
PE
10778 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10779 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10780 needed otherwise.
10781 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10782 (GC_STRING_CHARS): Remove; not used.
d40d4be1 10783 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 10784
e5aab7e7
PE
10785 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10786 avoids undefined behavior in theory.
10787
4da60324
PE
10788 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10789
88043301
PE
10790 Use functions, not macros, for up- and down-casing (Bug#8254).
10791 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10792 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10793 to use the following functions instead of these macros.
10794 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10795 EMACS_INT, since callers assume the returned value fits in int.
10796 (upcase1): Likewise, for UPCASE_TABLE.
10797 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 10798 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 10799 the race-condition problem in the old DOWNCASE.
88043301 10800
19ed5445
PE
10801 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10802 Rename locals to avoid shadowing.
10803 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
10804 (regex_compile, re_search_2, re_match_2_internal):
10805 Remove unused local vars.
952db0d7
PE
10806 (FREE_VAR): Rewrite so as not to use empty "else",
10807 which gcc can warn about.
da053e48 10808 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
10809 (RETALLOC_IF): Define only if needed.
10810 (WORDCHAR_P): Likewise. This one is never needed, but is used
10811 only in a comment talking about a compiler bug, so put inside
10812 the #if 0 of that comment.
10813 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10814 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10815 Remove; unused.
19ed5445 10816
1f3561e4 10817 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
10818 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10819 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 10820
ded6f8f7
PE
10821 * search.c (simple_search): Remove unused var.
10822
dbd37a95
PE
10823 * dired.c (compile_pattern): Move decl from here ...
10824 * lisp.h: ... to here, so that it can be checked.
10825 (struct re_registers): New forward decl.
10826
7e47afad
PE
10827 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10828
85f24f61
PE
10829 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10830 All uses changed.
10831 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10832 Rename locals to avoid shadowing.
5671df8f 10833 (Fvertical_motion): Mark locals as initialized.
85f24f61 10834
181aa2be 10835 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 10836 (casify_region): Mark local as initialized.
181aa2be 10837
930d429c
PE
10838 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10839
7082eac6
PE
10840 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10841 New macros, so that the caller can use some names other than
10842 gcpro1, gcpro2, etc.
10843 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10844 of the new macros.
10845 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10846 argument, for consistency with GCPRO2_VAR, etc: it is now the
10847 prefix of the variable, not the variable itself. All uses
10848 changed.
38b2c076
PE
10849 * dired.c (directory_files_internal, file_name_completion):
10850 Rename locals to avoid shadowing.
10851
15206ed9
PE
10852 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10853 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10854 dired.c's scmp function, had undefined behavior.
10855 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10856 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10857 * buffer.h: ... to here, because these macros use current_buffer,
10858 and the new implementation with inline functions needs to have
10859 current_buffer in scope now, rather than later when the macros
10860 are used.
10861 (downcase, upcase1): New static inline functions.
10862 (DOWNCASE, UPCASE1): Reimplement using these functions.
10863 This avoids undefined behavior in expressions like
10864 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10865 from race conditions in accessing the global variables
10866 case_temp1 and case_temp2.
10867 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10868 * lisp.h (case_temp1, case_temp2): Remove their decls.
10869 * character.h (ASCII_CHAR_P): Move from here ...
10870 * lisp.h: ... to here, so that the inline functions mentioned
10871 above can use them.
10872
4a6bea26
PE
10873 * dired.c (directory_files_internal_unwind): Now static.
10874
f14b7e14
PE
10875 * fileio.c (file_name_as_directory, directory_file_name):
10876 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10877 Now static.
2893f146
PE
10878 (file_name_as_directory): Use const pointers when appropriate.
10879 (Fexpand_file_name): Likewise. In particular, newdir might
10880 point at constant storage, so make it a const pointer.
fd4ead52 10881 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
10882 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10883 signedness issues.
f839df0c
PE
10884 (Fset_file_times, Finsert_file_contents, auto_save_error):
10885 Rename locals to avoid shadowing.
f14b7e14 10886
5716756e 10887 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
10888 (Ftry_completion, Fall_completions): Rename or remove locals
10889 to avoid shadowing.
5716756e 10890
b4c3046a
PE
10891 * marker.c (bytepos_to_charpos): Remove; unused.
10892
b45db522
PE
10893 * lisp.h (verify_bytepos, count_markers): New decls,
10894 so that gcc does not warn that these functions aren't declared.
10895
85876d07
PE
10896 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10897 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 10898 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 10899 (copy_text): Remove unused local var.
85876d07 10900
03d78a21 10901 * filelock.c (within_one_second): Now static.
b3dd38ab 10902 (lock_file_1): Rename local to avoid shadowing.
03d78a21 10903
5df8f01b
PE
10904 * buffer.c (fix_overlays_before): Mark locals as initialized.
10905 (fix_start_end_in_overlays): Likewise. This function should be
10906 simplified by using pointers-to-pointers, but that's a different
10907 matter.
b1d876f1 10908 (switch_to_buffer_1): Now static.
8f54f30a
PE
10909 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10910 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 10911
a70072c9 10912 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 10913 Fix pointer signedness issue.
edced198
PE
10914 (sys_subshell): Mark local as volatile if checking for lint,
10915 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 10916 (MAXPATHLEN): Define only if needed.
a70072c9 10917
a0977c44
PE
10918 * process.c (serial_open, serial_configure): Move decls from here ...
10919 * systty.h: ... to here, so that they can be checked.
10920
a884fdcc
PE
10921 * fns.c (get_random, seed_random): Move extern decls from here ...
10922 * lisp.h: ... to here, so that they can be checked.
10923
604efe86 10924 * sysdep.c (reset_io): Now static.
b8950c94 10925 (wait_for_termination_signal): Remove; unused.
604efe86 10926
38fc62d9
PE
10927 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10928 (copy_keymap_item, append_key, push_text_char_description):
10929 Now static.
1004a21a 10930 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 10931 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
10932 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10933 (describe_map_tree):
10934 Rename locals to avoid shadowing.
38fc62d9 10935
2f2650da
PE
10936 * keyboard.c: Declare functions static if they are not used elsewhere.
10937 (echo_char, echo_dash, cmd_error, top_level_2):
10938 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
10939 (read_char, kbd_buffer_get_event, make_lispy_position):
10940 (make_lispy_event, make_lispy_movement, apply_modifiers):
10941 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10942 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10943 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 10944 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 10945 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 10946
a053e86c 10947 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
10948 (mark_kboards): Move decl here ...
10949 * alloc.c (mark_kboards): ... from here.
a053e86c 10950
4752793e
PE
10951 * lisp.h (force_auto_save_soon): New decl.
10952
74f10ca7 10953 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
10954 (DEFINE_DUMMY_FUNCTION): New macro.
10955 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10956 Use it.
c03cd23f
PE
10957 (main): Add casts to avoid warnings
10958 if GCC considers string literals to be constants.
74f10ca7 10959
022e70d4
PE
10960 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10961
59d6fe83
PE
10962 * dbusbind.c: Pointer signedness fixes.
10963 (xd_signature, xd_append_arg, xd_initialize):
10964 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10965 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10966 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10967 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10968
78320123
PE
10969 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10970 if GCC considers string literals to be constants.
49cebcca 10971 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 10972
35ac2a97
SM
109732011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10974
fb103ca9
SM
10975 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10976 (print_preprocess, print_object): New macro to fix last change.
10977
35ac2a97
SM
10978 * print.c (print_preprocess): Don't forget font objects.
10979
62973b41
JB
109802011-03-16 Juanma Barranquero <lekktu@gmail.com>
10981
10982 * emacs.c (USAGE3): Doc fixes.
10983
0e48bb22
AS
109842011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10985
10986 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10987 structure.
10988
7684e57b
JB
109892011-03-14 Juanma Barranquero <lekktu@gmail.com>
10990
10991 * lisp.h (VWindow_system, Qfile_name_history):
10992 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10993 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10994 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10995
10996 * w32select.c: Don't #include "keyboard.h".
c96bbc66 10997 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
10998
10999 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11000 * w32console.c (detect_input_pending, read_input_pending)
11001 (encode_terminal_code):
11002 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11003 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11004 (w32_system_caret_y, Qfile_name_history):
11005 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11006 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11007 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11008 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11009 * w32proc.c (Qlocal, report_file_error):
11010 * w32term.c (Vwindow_system, updating_frame):
11011 * w32uniscribe.c (initialized, uniscribe_font_driver):
11012 Remove unneeded extern declarations.
11013
2aa46d6c
CY
110142011-03-14 Chong Yidong <cyd@stupidchicken.com>
11015
c96bbc66 11016 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11017
cffc6f3b
CY
110182011-03-13 Chong Yidong <cyd@stupidchicken.com>
11019
11020 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11021 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11022 These macros can no longer be used for assignment.
11023
44f230aa
SM
11024 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11025 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11026 (record_buffer_markers, fetch_buffer_markers): New functions for
11027 recording and fetching special buffer markers.
11028 (set_buffer_internal_1, set_buffer_temp): Use them.
11029
11030 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11031
11032 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11033
11034 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11035 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11036
11037 * xdisp.c (hscroll_window_tree):
11038 (reconsider_clip_changes): Use PT instead of BUF_PT.
11039
d251f04b
EZ
110402011-03-13 Eli Zaretskii <eliz@gnu.org>
11041
11042 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11043 $(EMACS_ROOT)/lib/intprops.h.
11044
f0c77cd1
PE
110452011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11046
3eca4629
PE
11047 Fix more problems found by GCC 4.5.2's static checks.
11048
7c86ee98
PE
11049 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11050 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11051 (xg_free_frame_widgets): Make it clear that a local variable is
11052 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11053 (gdk_window_get_screen): Make it clear that this macro is needed
11054 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11055 (int_gtk_range_get_value): New function, which avoids a diagnostic
11056 from gcc -Wbad-function-cast.
11057 (xg_set_toolkit_scroll_bar_thumb): Use it.
11058 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11059 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11060 (get_utf8_string, xg_get_file_with_chooser):
11061 Rename locals to avoid shadowing.
11062 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11063
41729b81
PE
11064 * xgselect.c (xg_select): Remove unused var.
11065
f0c77cd1
PE
11066 * image.c (four_corners_best): Mark locals as initialized.
11067 (gif_load): Initialize transparent_p to zero (Bug#8238).
11068 Mark another local as initialized.
ec6cf4c6 11069 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11070
ce0ad53d 11071 * image.c (clear_image_cache): Now static.
d5d5a617 11072 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11073 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11074 (x_edge_detection): Remove unnecessary cast that
11075 gcc -Wbad-function-cast diagnoses.
2037898d 11076 (gif_load): Fix pointer signedness.
6ae141d6
PE
11077 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11078 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11079
33383987 110802011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11081
d32df629
PE
11082 Improve quality of tests for time stamp overflow.
11083 For example, without this patch (encode-time 0 0 0 1 1
11084 1152921504606846976) returns the obviously-bogus value (-948597
11085 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11086 reports time overflow. See
11087 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11088 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11089 * editfns.c: Include limits.h and intprops.h.
11090 (TIME_T_MIN, TIME_T_MAX): New macros.
11091 (time_overflow): Move earlier, to before first use.
11092 (hi_time, lo_time): New functions, for an accurate test for
11093 out-of-range times.
11094 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11095 (Fget_internal_run_time): Don't assume time_t fits in int.
11096 (make_time): Use list2 instead of Fcons twice.
11097 (Fdecode_time): More accurate test for out-of-range times.
11098 (check_tm_member): New function.
11099 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11100 (lisp_time_argument): Don't rely on undefined left-shift and
11101 right-shift behavior when checking for time stamp overflow.
8be6f318 11102
fe31d94c
PE
11103 * editfns.c (time_overflow): New function, refactoring common code.
11104 (Fformat_time_string, Fdecode_time, Fencode_time):
11105 (Fcurrent_time_string): Use it.
11106
8be6f318
PE
11107 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11108 * dired.c (make_time): Move to ...
11109 * editfns.c (make_time): ... here.
11110 * systime.h: Note the move.
11111
09d9db2c 111122011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11113
126bc0dc
YM
11114 * fringe.c (update_window_fringes): Remove unused variables.
11115
c47cbdfd
YM
11116 * unexmacosx.c (copy_data_segment): Also copy __got section.
11117 (Bug#8223)
11118
7ac80be9
EZ
111192011-03-12 Eli Zaretskii <eliz@gnu.org>
11120
c96bbc66 11121 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11122 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11123 Constify `char *' arguments and their references according to
11124 prototypes in tparam.h.
11125
ecb0f94d 11126 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11127
7ac80be9
EZ
11128 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11129 Adapt all references accordingly.
11130
11131 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11132
ef1fd07e
TT
111332011-03-11 Tom Tromey <tromey@redhat.com>
11134
11135 * buffer.c (syms_of_buffer): Remove obsolete comment.
11136
7ef4b50c
EZ
111372011-03-11 Eli Zaretskii <eliz@gnu.org>
11138
11139 * termhooks.h (encode_terminal_code): Declare prototype.
11140
11141 * msdos.c (encode_terminal_code): Don't declare prototype.
11142
11143 * term.c (encode_terminal_code): Now external again, used by
11144 w32console.c and msdos.c.
11145
44f230aa
SM
11146 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11147 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11148
4b1ec863 111492011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11150
1714f52b 11151 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11152
4b1ec863
PE
11153 * fringe.c (update_window_fringes): Mark locals as initialized
11154 (Bug#8227).
11155 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11156
524c7aa6
PE
11157 * alloc.c (mark_fringe_data): Move decl from here ...
11158 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11159 to check its interface.
11160 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11161
a5c0af81 11162 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11163 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11164 (fontset_font): Mark local as initialized.
a9a06e0b 11165 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11166
b4716021
PE
11167 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11168
811e9bac 11169 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11170 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11171 (x_own_selection, Fx_disown_selection_internal): Rename locals
11172 to avoid shadowing.
11173 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11174
7e3ab302
PE
11175 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11176 so that the caller can use some name other than gcpro1.
11177 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11178 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11179 (Fx_backspace_delete_keys_p):
11180 Use them to avoid shadowing, and rename vars to avoid shadowing.
11181 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11182 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11183 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11184 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11185 Remove unused locals.
7e3ab302
PE
11186 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11187 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11188 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11189 macros.
f78faa98 11190
e2b13473
PE
11191 * xterm.h (x_mouse_leave): New decl.
11192
77f23912
PE
11193 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11194 Remove unused functions.
cdf4ba58
PE
11195 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11196 (x_calc_absolute_position): Now static.
7411c686 11197 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11198 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11199 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11200 unless they are used.
38d0b34a
PE
11201 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11202 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11203 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11204 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11205 (x_error_catcher, x_connection_closed, x_error_handler):
11206 (x_error_quitter, xembed_send_message, x_iconify_frame):
11207 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11208 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11209 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11210
44f230aa
SM
11211 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11212 Rename or move locals to avoid shadowing.
6b463e58 11213 (tty_defined_color, merge_face_heights): Now static.
5967d051 11214 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11215 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11216 does not deduce is never used uninitialized.
73719eba
PE
11217 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11218 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11219
426994c3 11220 * terminal.c (store_terminal_param): Now static.
5489860b 11221
032f1620 11222 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11223 (set_frame_menubar): Remove unused local.
d4323972 11224 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11225 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11226 since they might point to immutable storage.
281585b0
PE
11227 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11228 since it's unused otherwise.
032f1620 11229
367c19e5 11230 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11231 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11232 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11233 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11234 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11235 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11236 does not deduce are never used uninitialized.
70739cbe 11237
07b48fa9
PE
11238 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11239
8868a238 11240 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11241 * window.c (window_loop, size_window):
11242 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11243
7e5cf297 11244 * window.c (display_buffer): Now static.
d6550a9f
PE
11245 (size_window): Mark variables that gcc -Wuninitialized
11246 does not deduce are never used uninitialized.
a586633d
PE
11247 * window.h (check_all_windows): New decl, to forestall
11248 gcc -Wmissing-prototypes diagnostic.
5b555da1 11249 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11250
f6095868
PE
11251 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11252 shadowing.
11253 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11254 Include <limits.h>.
11255 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11256 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11257 (load_charset_map): Mark variables that gcc -Wuninitialized
11258 does not deduce are never used uninitialized.
53df7c11 11259 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11260
f38b440c
PE
11261 * coding.c (coding_set_source, coding_set_destination):
11262 Use "else { /* comment */ }" rather than "else /* comment */;"
11263 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11264 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11265 a block, when the outer 'i' will do.
11266 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11267 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11268 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11269 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11270 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11271 Rename locals to avoid shadowing.
11272 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11273 * coding.c (emacs_mule_char, encode_invocation_designation):
11274 Now static, since they're not used elsewhere.
413bb2db 11275 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11276 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11277 (decode_coding_emacs_mule): Mark variables that gcc
11278 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11279 (detect_coding_iso_2022): Initialize a local variable that might
11280 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11281 this initialization is needed. (Bug#8211)
5f58e762
PE
11282 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11283 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11284 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11285 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11286 Remove unused macros.
f38b440c 11287
232b38b9 11288 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11289 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11290 * character.c (string_count_byte8): Likewise.
232b38b9 11291
fb90da1b
PE
11292 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11293 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11294
fb93dbc2
PE
11295 * chartab.c (copy_sub_char_table): Now static, since it's not used
11296 elsewhere.
5c156ace
PE
11297 (sub_char_table_ref_and_range, char_table_ref_and_range):
11298 Rename locals to avoid shadowing.
bbcd0949 11299 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11300
7d3b3862 11301 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11302 (BIDI_BOB): Remove unused macro.
7d3b3862 11303
6be7d3da
PE
11304 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11305 deduce are never used uninitialized.
c2ed9c8b 11306 * term.c (encode_terminal_code): Likewise.
6be7d3da 11307
75f8807f 11308 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11309
50938595
PE
11310 * tparam.h: New file.
11311 * term.c, tparam.h: Include it.
11312 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11313 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11314 Move these decls to tparam.h, and make them agree with what
11315 is actually in tparam.c. The previous trick of using incompatible
11316 decls in different modules does not conform to the C standard.
11317 All callers of tparam changed to use tparam's actual API.
11318 * tparam.c (tparam1, tparam, tgoto):
11319 Use const pointers where appropriate.
11320
fbceeba2
PE
11321 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11322 * cm.h (struct cm): Likewise.
11323 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11324 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11325 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11326 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11327 (turn_on_face, init_tty): Likewise.
11328 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11329
7f3f1250
PE
11330 * term.c (term_mouse_position): Rename local to avoid shadowing.
11331
e6ca6543
PE
11332 * alloc.c (mark_ttys): Move decl from here ...
11333 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11334
c40f8d15
AS
113352011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11336
11337 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11338
cfe0661d
JB
113392011-03-09 Juanma Barranquero <lekktu@gmail.com>
11340
11341 * search.c (compile_pattern_1): Remove argument regp, unused since
11342 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11343 (compile_pattern): Don't pass it.
11344
0afb4571
J
113452011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11346
11347 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11348 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11349 for ! HAVE_GTK3.
11350 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11351
11352 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11353
11354 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11355 gdk_window_get_screen, gdk_window_get_geometry,
11356 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11357 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11358 (xg_get_pixbuf_from_pixmap): New function.
11359 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11360 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11361 Call xg_get_pixbuf_from_pixmap instead of
11362 gdk_pixbuf_get_from_drawable.
11363 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11364 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11365 (xg_check_special_colors): Use GtkStyleContext and its functions
11366 for HAVE_GTK3.
11367 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11368 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11369 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11370 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11371 Call gtk_widget_get_preferred_size.
0afb4571
J
11372 (xg_frame_resized): gdk_window_get_geometry only takes 5
11373 parameters.
44f230aa
SM
11374 (xg_win_to_widget, xg_event_is_for_menubar):
11375 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11376 (xg_set_widget_bg): New function.
11377 (delete_cb): New function.
895009e1 11378 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11379 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11380 (xg_set_background_color): Call xg_set_widget_bg.
11381 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11382 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11383 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11384 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11385 if ! HAVE_GTK3.
11386 (update_frame_tool_bar): Call gtk_widget_hide.
11387 (xg_initialize): Use GDK_KEY_g.
11388
11389 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11390 if ! HAVE_GTK3
11391 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11392
11393 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11394 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11395 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11396
1c2cc4ef
JB
113972011-03-08 Juanma Barranquero <lekktu@gmail.com>
11398
11399 * w32xfns.c (select_palette): Check success of RealizePalette against
11400 GDI_ERROR, not zero.
11401
33383987 11402See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11403
11404;; Local Variables:
11405;; coding: utf-8
aac0c6e3
MR
11406;; End:
11407
2f097256 11408 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11409
11410 This file is part of GNU Emacs.
11411
11412 GNU Emacs is free software: you can redistribute it and/or modify
11413 it under the terms of the GNU General Public License as published by
11414 the Free Software Foundation, either version 3 of the License, or
11415 (at your option) any later version.
11416
11417 GNU Emacs is distributed in the hope that it will be useful,
11418 but WITHOUT ANY WARRANTY; without even the implied warranty of
11419 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11420 GNU General Public License for more details.
11421
11422 You should have received a copy of the GNU General Public License
11423 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.