Add missing ChangeLog entry for last change.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9a0115ab 12012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2
b9110d6a 3 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4 * fileio.c (auto_saving_dir_umask): New static var.
5 (Fmake_directory_internal): Use it.
6 (do_auto_save_make_dir): Set it, instead of invoking chmod after
7 creating the directory. The old code temporarily assigns
8 too-generous permissions to the directory.
9 (do_auto_save_eh): Clear it.
b9110d6a 10 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
11 that the var is always cleared.
12
6c1bd3f3
EZ
132012-01-07 Eli Zaretskii <eliz@gnu.org>
14
15 * search.c (scan_buffer): Pass character positions to
16 know_region_cache, not byte positions. (Bug#6540)
17
069d2b50
L
182012-01-07 LynX <_LynX@bk.ru> (tiny change)
19
20 * w32.c (sys_rename): Report EXDEV when rename of a directory
21 fails because the target is on another logical disk. (Bug#10284)
22
75bf0d33
DB
232012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
24
25 * xterm.c (x_embed_request_focus): New function.
26
27 * xterm.h: Add prototype.
28
29 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
30
1c6e5a32
GM
312012-01-05 Glenn Morris <rgm@gnu.org>
32
33 * emacs.c (emacs_copyright): Update short copyright year to 2012.
34
651e947e
EZ
352012-01-01 Eli Zaretskii <eliz@gnu.org>
36
37 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
38 Load gnutls_transport_set_lowat only if GnuTLS version is below
39 2.11.1.
40 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
41 GnuTLS versions below 2.11.1.
42
3778cdd8
AL
432011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
44
45 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
46 to the doc string advising against its use for altering the way
47 windows are scrolled.
48
0e5317f7
KH
492011-12-28 Kenichi Handa <handa@m17n.org>
50
51 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
52 coding-system ASCII compatible only when it does not produce BOM
53 on encoding (Bug#10383).
54
93d5ca1f
JD
552011-12-26 Jan Djärv <jan.h.d@swipnet.se>
56
57 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
58 can scroll.
59 (create_and_show_popup_menu): Always use menu_position_func for
60 Gtk3 (Bug#10361).
61
ca22b785
AS
622011-12-24 Andreas Schwab <schwab@linux-m68k.org>
63
64 * callint.c (Fcall_interactively): Don't truncate prompt string.
65
d048e1e6
EZ
662011-12-23 Eli Zaretskii <eliz@gnu.org>
67
68 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
69 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 70 resumed from there (after widening). (Bug#10360)
d048e1e6 71
5ccaba1f
JD
722011-12-22 Jan Djärv <jan.h.d@swipnet.se>
73
74 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
75
204ee57f
JD
762011-12-21 Jan Djärv <jan.h.d@swipnet.se>
77
b81d40f0
JB
78 * nsterm.m (x_free_frame_resources):
79 Release f->output_data.ns->miniimage.
204ee57f
JD
80 (ns_index_color): Fix indentation. Do not retain
81 color_table->colors[i].
82
83 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
84 before returning.
85
86 * nsfns.m (x_set_background_color): Assign return value from
87 ns_index_color to face-background instead of NSColor*.
88 (ns_implicitly_set_icon_type): Fix indentation.
89 Change assignment in for loop to comparison.
90
91 * emacs.c (ns_pool): New variable.
92 (main): Assign ns_pool.
93 (Fkill_emacs): Call ns_release_autorelease_pool.
94
95 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
96 autorelease fdesc, release fdAttrs and tdict.
97 (ns_get_covering_families): Release charset.
98 (ns_findfonts): Release NSFontDescriptor created with new.
99 (ns_uni_to_glyphs): Fix indentation.
100 (setString): Release attrStr before assigning new value.
101
c803b2b7
JD
1022011-12-18 Jan Djärv <jan.h.d@swipnet.se>
103
678f4426
JD
104 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
105 and NS_IMPL_COCOA.
106 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
107 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
108
1092011-12-18 David Reitter <reitter@cmu.edu>
110
5fecd5fc
JD
111 * nsterm.m (ns_term_init): Subscribe for notifications
112 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
113 to method trackingNotification in EmacsMenu.
114
115 * nsmenu.m (trackingMenu): New variable.
3771cb17 116 (trackingNotification): New method (from Aquamacs).
5fecd5fc 117 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 118 from Aquamacs (Bug#7030).
678f4426
JD
119
1202011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 121
c803b2b7
JD
122 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
123 (symbol_to_nsstring): Fix indentation.
124 (ns_symbol_to_pb): New function.
125 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
126 (Fns_rotate_cut_buffers_internal): Removed.
127 (Fns_store_selection_internal): Renamed from
128 Fns_store_cut_buffer_internal.
129 (ns_get_foreign_selection, Fx_own_selection_internal)
130 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
131 (Fns_get_selection_internal, Fns_store_selection_internal):
132 Use ns_symbol_to_pb and check if return value is nil.
133 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
134 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
135 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
136 renamed to Sns_store_selection_internal.
137 (ns_handle_selection_request): Move code to Fx_own_selection_internal
138 and remove this function.
139 (ns_handle_selection_clear): Remove, never used.
140 (Fx_own_selection_internal): Move code from ns_handle_selection_request
141 here.
142
e1b01a3a
KB
1432011-12-17 Ken Brown <kbrown@cornell.edu>
144
145 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
146 GID is unknown (Bug#10257).
147
2adb6e85
PE
1482011-12-17 Paul Eggert <eggert@cs.ucla.edu>
149
150 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
151 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
152 which caused a build failure on GNU/Linux IA-64. This problem was
153 introduced by my 2011-10-07 patch.
154
d1d7b339
JL
1552011-12-15 Juri Linkov <juri@jurta.org>
156
157 * image.c (imagemagick_error): New function. (Bug#10112)
158 (imagemagick_load_image): Comment out `MagickSetResolution' call.
159 Use `imagemagick_error' where ImageMagick functions return
160 `MagickFalse'.
161 (Fimagemagick_types): Add `Fnreverse' to return the list in the
162 proper order.
163
100d5755
KH
1642011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
165
166 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
167 fill background (Bug#8992).
168
454592a6
MR
1692011-12-13 Martin Rudalics <rudalics@gmx.at>
170
171 * window.c (Vwindow_combination_resize)
172 (Vwindow_combination_limit): Use t instead of non-nil in
173 doc-strings.
61d4b438
MR
174 (Vrecenter_redisplay): Add first sentence of doc-string on
175 separate line.
53524d93 176 (Frecenter): Fix doc-string typo.
454592a6 177
3633e3aa
KH
1782011-12-11 Kenichi Handa <handa@m17n.org>
179
180 * coding.c (Funencodable_char_position): Pay attention to the
181 buffer text relocation (Bug#9389).
182
7b9d523a
JD
1832011-12-10 Jan Djärv <jan.h.d@swipnet.se>
184
185 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
186 gtk_init (Bug#10100).
187
b73189c6
EZ
1882011-12-10 Eli Zaretskii <eliz@gnu.org>
189
190 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
191 IT->string is nil. (Bug#10263)
192
f7dfe5d6
JD
1932011-12-10 Jan Djärv <jan.h.d@swipnet.se>
194
83faebb4
JD
195 * nsterm.h (x_free_frame_resources): Declare.
196
f7dfe5d6
JD
197 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
198 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
199
200 * nsterm.h (ns_get_defaults_value): Declare.
201
202 * nsterm.m (ns_default): Call ns_get_defaults_value.
203
7cd4e72c
EZ
2042011-12-09 Eli Zaretskii <eliz@gnu.org>
205
206 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
207 (Bug#10170)
208
b34d7317
YM
2092011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
210
211 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
212 that where the value of an _OBJC_* symbol points to is in the .bss
213 section (Bug#10240).
214
76470ad1
KH
2152011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
216
217 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 218 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 219
745fff94
KH
2202011-12-08 Kenichi Handa <handa@m17n.org>
221
222 * ftfont.c (get_adstyle_property): Fix previous change
223 (Bug#10233).
224
6e44397c
JB
2252011-12-07 Juanma Barranquero <lekktu@gmail.com>
226
227 * w32.c (init_environment): If no_site_lisp, remove site-lisp
228 dirs from the default value of EMACSLOADPATH (bug#10208).
229
7efa6272
GM
2302011-12-07 Glenn Morris <rgm@gnu.org>
231
232 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
233 installation and source directories as well. (Bug#10208)
234
f6fc4d87
CY
2352011-12-06 Chong Yidong <cyd@gnu.org>
236
237 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
238
2bf26180
GM
2392011-12-06 Glenn Morris <rgm@gnu.org>
240
241 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
242 as an error, not just -1. (Bug#10217)
243
3a6ad4f0
CY
2442011-12-05 Chong Yidong <cyd@gnu.org>
245
246 * keyboard.c (process_special_events): New function.
247 (swallow_events, Finput_pending_p): Use it (Bug#10195).
248
75a3b399
PE
2492011-12-05 Paul Eggert <eggert@cs.ucla.edu>
250
251 * coding.c (encode_designation_at_bol): Don't use uninitialized
252 local variable (Bug#9318).
253
c3c9e25e
KH
2542011-12-05 Kenichi Handa <handa@m17n.org>
255
256 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
257 return Qnil (Bug#8046, Bug#10193).
258
5eb05ea3
KH
2592011-12-05 Kenichi Handa <handa@m17n.org>
260
261 * coding.c (encode_designation_at_bol): New args charbuf_end and
262 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
263 (coding_set_source): Return how many bytes coding->source was
264 relocated.
265 (coding_set_destination): Return how many bytes
266 coding->destination was relocated.
267 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
268 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
269
2702011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
271
272 * coding.c (CODING_CHAR_CHARSET_P): New macro.
273 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
274 macro (Bug#9318).
275
2762011-12-05 Andreas Schwab <schwab@linux-m68k.org>
277
278 The following changes are to fix Bug#9318.
279
a79703f5 280 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
281 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
282 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 283 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 284
7dbda6df
JB
2852011-12-05 Juanma Barranquero <lekktu@gmail.com>
286
287 * lisp.h (process_quit_flag): Fix external declaration.
288
6d5eb5b0
SM
2892011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
290
291 Don't macro-inline non-performance-critical code.
292 * eval.c (process_quit_flag): New function.
293 * lisp.h (QUIT): Use it.
294
a0c3fad0
JD
2952011-12-04 Jan Djärv <jan.h.d@swipnet.se>
296
297 * nsfns.m (get_geometry_from_preferences): New function.
298 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
299
6c07aac2
AS
3002011-12-04 Andreas Schwab <schwab@linux-m68k.org>
301
302 * emacs.c (Qkill_emacs): Define.
303 (syms_of_emacs): Initialize it.
304 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
305 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
306 (quit_throw_to_read_char): Add parameter `from_signal'.
307 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
308 * lisp.h (QUIT): Call Fkill_emacs if requested.
309
c052ead4
JD
3102011-12-03 Jan Djärv <jan.h.d@swipnet.se>
311
312 * widget.c (update_wm_hints): Return if wmshell is null.
313 (widget_update_wm_size_hints): New function.
314
315 * widget.h (widget_update_wm_size_hints): Declare.
316
317 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
318 widget_update_wm_size_hints (Bug#10104).
319
9e49252b
EZ
3202011-12-03 Eli Zaretskii <eliz@gnu.org>
321
322 * xdisp.c (handle_invisible_prop): If the invisible text ends just
323 before a newline, prepare the bidi iterator for consuming the
324 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 325 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 326
02b16839
JL
3272011-12-02 Juri Linkov <juri@jurta.org>
328
329 * search.c (Fword_search_regexp): New Lisp function created from
330 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
331 (Fword_search_backward, Fword_search_forward)
332 (Fword_search_backward_lax, Fword_search_forward_lax):
333 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
334 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
335
0068070e
SM
3362011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
337
338 * fileio.c (Finsert_file_contents): Move after-change-function call
339 to before the "handled:" label, since all "goto handled" appear in
340 cases where the *-change-functions have already been properly called
341 (bug#10117).
342
3360a3fc
AS
3432011-12-01 Andreas Schwab <schwab@linux-m68k.org>
344
345 * keyboard.c (interrupt_signal): Don't call kill-emacs when
346 waiting for input. (Bug#10169)
347
73d6c093
EZ
3482011-11-30 Eli Zaretskii <eliz@gnu.org>
349
350 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
351 verifies glyph row's hash code--we have just reallocated the
352 glyphs, so their contents can be complete garbage. (Bug#10164)
353
febe6bea
JB
3542011-11-30 Juanma Barranquero <lekktu@gmail.com>
355
356 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
357
801a4313
EZ
3582011-11-30 Eli Zaretskii <eliz@gnu.org>
359
360 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
361 attributes are tested _before_ calling verify_row_hash, to protect
362 against GCC re-ordering of the tests. (Bug#10164)
363
2b56b87e
JD
3642011-11-29 Jan Djärv <jan.h.d@swipnet.se>
365
366 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
367
368 * xterm.c (handle_one_xevent): Only set async_visible and friends
369 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 370 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
371 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
372
dbf31225
PE
3732011-11-28 Paul Eggert <eggert@cs.ucla.edu>
374
375 Remove GCPRO-related macros that exist only to avoid shadowing locals.
376 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
377 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
378 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
379 All uses changed to use GCPRO1 etc.
380 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
381 Revert to old implementation (i.e., before 2011-03-11).
382
1305621b
YM
3832011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
384
385 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
386 of scroll runs so as to avoid assigning disabled bogus rows and
387 unnecessary graphics copy operations.
388
8c9afb46
EZ
3892011-11-27 Eli Zaretskii <eliz@gnu.org>
390
391 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
392 (snprintf) [_MSC_VER]: Redirect to _snprintf.
393 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
394 (malloc, free, realloc, calloc): Redirect to e_* only when
395 compiling Emacs.
396
397 * lisp.h (GCTYPEBITS): Move before first use.
398 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
399 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
400 this macro definition.
401
402 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
403 _MSC_VER.
404
54e9e3bf
JD
4052011-11-27 Jan Djärv <jan.h.d@swipnet.se>
406
6d5eb5b0
SM
407 * gtkutil.c (xg_create_frame_widgets):
408 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
409 present with Gtk+ 2.0.
410
83aca1cb
PE
4112011-11-26 Paul Eggert <eggert@cs.ucla.edu>
412
413 * fileio.c (Finsert_file_contents): Undo previous change; see
414 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
415
5b76caa4
PE
4162011-11-26 Paul Eggert <eggert@cs.ucla.edu>
417
418 Rename locals to avoid shadowing.
419 * fileio.c (Finsert_file_contents):
420 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
421 * process.c (wait_reading_process_output):
422 Rename inner 'proc' to 'p' to avoid shadowing.
423 Indent for consistency with usual Emacs style.
424
8c535114
EZ
4252011-11-25 Eli Zaretskii <eliz@gnu.org>
426
427 * xdisp.c (redisplay_window): If cursor row is not fully visible
428 after recentering, and scroll-conservatively is set to a large
429 number, scroll window by a few more lines to make the cursor fully
430 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
431 (start_display): Don't move to the next line if the display should
432 start at a newline that is part of a display vector or an overlay
433 string. (Bug#10119)
8c535114 434
fa4fdb5c
JL
4352011-11-24 Juri Linkov <juri@jurta.org>
436
437 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
438 after the `MagickPingImage' call. (Bug#10112)
439
90ec88df
CY
4402011-11-23 Chong Yidong <cyd@gnu.org>
441
442 * window.c (Fcoordinates_in_window_p): Accept only live windows.
443
56e2e794
MR
4442011-11-23 Martin Rudalics <rudalics@gmx.at>
445
446 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
447 making another buffer current. (Bug#10114)
448
b6e64c41
GM
4492011-11-23 Glenn Morris <rgm@gnu.org>
450
451 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
452
6b21de18
CY
4532011-11-23 Chong Yidong <cyd@gnu.org>
454
455 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
456 using it (Bug#5984).
457
b12cd789
EZ
4582011-11-22 Eli Zaretskii <eliz@gnu.org>
459
460 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
461 and header-lines, as they don't have one computed for them.
462 (Bug#10098)
463
464 * .gdbinit (prow): Make displayed values more self-explaining.
465 Add row's hash code.
466
261b6fd4
LMI
4672011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
468
469 * process.c (wait_reading_process_output): Fix asynchrounous
470 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 471 (wait_reading_process_output): Add comment and URL.
261b6fd4 472
e7cfd277
JD
4732011-11-21 Jan Djärv <jan.h.d@swipnet.se>
474
475 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
476
a9b9b7f5
CY
4772011-11-21 Chong Yidong <cyd@gnu.org>
478
479 * window.c (Fnext_window, Fprevious_window): Doc fix.
480
b0d15b4f
SM
4812011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
482
483 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
484
fe7a3057
JB
4852011-11-20 Juanma Barranquero <lekktu@gmail.com>
486
487 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
488
d2999b1a
MR
4892011-11-20 Martin Rudalics <rudalics@gmx.at>
490
491 * window.c (Fset_window_combination_limit): Rename argument
492 STATUS to LIMIT.
493 (Vwindow_combination_limit): Remove "status" from doc-string.
494
d5ff9cd0
AS
4952011-11-20 Andreas Schwab <schwab@linux-m68k.org>
496
497 * m/ibms390.h: Remove.
498 * m/ibms390x.h: Don't include "ibms390.h".
499
a5bb9bd3
SM
5002011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
501
502 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
503 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
504
cd1181db
JB
5052011-11-20 Juanma Barranquero <lekktu@gmail.com>
506
507 * casetab.c (Fset_case_table):
508 * charset.c (Fcharset_after): Fix typos.
509
615a3b8d 5102011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 511
17e845af
PE
512 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
513 Otherwise, valgrind does not work on some platforms.
514 Problem reported by Andreas Schwab in
6a0bf43d
PE
515 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
516 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
517 is set, removing the need for VIRT_ADDRESS_VARIES.
518 (PURE_P): Use a more-efficient implementation that needs just one
519 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
520 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
521 to 4 (xorl, subq, cmpq, setbe).
522 * alloc.c (pure): Always extern now, since that's the
523 VIRT_ADDR_VARIES behavior.
524 (PURE_POINTER_P): Use a single comparison, not two, for
525 consistency with the new puresize.h.
526 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
527 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
528 Remove VIRT_ADDR_VARIES no longer needed.
529
f8fe6f96
EZ
5302011-11-19 Eli Zaretskii <eliz@gnu.org>
531
532 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
533 (erase_phys_cursor, update_window_cursor, show_mouse_face)
534 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
535 behave as if the cursor position were at the window margin.
536
537 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
538 and the cursor position is out of bounds, behave as if the cursor
539 position were at the window margin. (Bug#10075)
540
df05a53c
CY
5412011-11-18 Chong Yidong <cyd@gnu.org>
542
543 * window.c (Fwindow_combination_limit): Make first argument
544 non-optional, since it is meaningless for live windows like the
545 selected window.
546
2071918e
DA
5472011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
548
549 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
550
b50a28de
SM
5512011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
552
553 * intervals.c: Fix grafting over the whole buffer (bug#10071).
554 (graft_intervals_into_buffer): Simplify.
555
015137db
EZ
5562011-11-18 Eli Zaretskii <eliz@gnu.org>
557
558 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
559 hash values of the two rows.
560 (copy_row_except_pointers): Preserve the used[] arrays and the
561 hash values of the two rows. (Bug#10035)
68c95424 562 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
563
564 * xdisp.c (row_hash): New function, body extracted from
565 compute_line_metrics.
566 (compute_line_metrics): Call row_hash, instead of computing the
567 hash code inline.
568
569 * dispnew.c (verify_row_hash): Call row_hash for computing the
570 hash code of a row, instead of duplicating code from xdisp.c.
571
572 * dispextern.h (row_hash): Add prototype.
573
a2addb04
TH
5742011-11-18 Tassilo Horn <tassilo@member.fsf.org>
575
576 * frame.c (delete_frame): Don't delete the terminal when the last
577 X frame is closed if emacs is built with GTK toolkit.
578
df85d315
JB
5792011-11-17 Juanma Barranquero <lekktu@gmail.com>
580
581 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
582
a0c2d0ae
MR
5832011-11-17 Martin Rudalics <rudalics@gmx.at>
584
585 * window.c (Vwindow_splits): Rename to
586 Vwindow_combination_resize. Suggested by Juri Linkov.
587 (Fsplit_window_internal): Use Vwindow_combination_resize instead
588 of Vwindow_splits.
589
58179cce
JB
5902011-11-16 Juanma Barranquero <lekktu@gmail.com>
591
7877f373
JB
592 * nsfns.m (Fns_font_name):
593 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 594
b6f67890
MR
5952011-11-16 Martin Rudalics <rudalics@gmx.at>
596
597 * window.h (window): Rename slot "nest" to "combination_limit".
598 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
599 (Fset_window_nest): Rename to Fset_window_combination_limit.
600 (Vwindow_nest): Rename to Vwindow_combination_limit.
601 (recombine_windows, make_parent_window, make_window)
602 (Fsplit_window_internal, saved_window)
603 (Fset_window_configuration, save_window_save): Rename all
604 occurrences of window_nest to window_combination_limit.
605
c7015153
JB
6062011-11-15 Juanma Barranquero <lekktu@gmail.com>
607
608 * image.c (imagemagick_load_image): Fix typo.
609
322ad6ec
EZ
6102011-11-14 Eli Zaretskii <eliz@gnu.org>
611
612 * xdisp.c (display_line): Move the call to
613 highlight_trailing_whitespace before the call to
614 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
615 faces of all the glyphs to compute ROW's hash value.
616 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 617
f067b8ec
JB
6182011-11-14 Juanma Barranquero <lekktu@gmail.com>
619
620 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
621 just return (bug#10044).
622
1e5b2111
EZ
6232011-11-12 Eli Zaretskii <eliz@gnu.org>
624
7ef3cbd5
EZ
625 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
626 with user-defined heap size. Bump the default size of the temacs
627 heap to 27MB, to avoid memory warning when running temacs.
628 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
629
1e5b2111
EZ
630 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
631 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
632 (verify_row_hash) [XASSERTS]: New function.
633 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
634 that the hash value of glyph rows is correct.
1e5b2111 635
89d61221
MR
6362011-11-12 Martin Rudalics <rudalics@gmx.at>
637
638 * window.h (window): Remove splits slot.
639 * window.c (Fwindow_splits, Fset_window_splits): Remove.
640 (Fdelete_other_windows_internal, make_parent_window)
641 (make_window, Fsplit_window_internal, Fdelete_window_internal)
642 (Fset_window_configuration, save_window_save): Don't deal with
643 split status of windows.
644 (saved_window): Remove splits slot.
645 (Vwindow_splits): Rewrite doc-string.
646
97f18cc8
JD
6472011-11-11 Jan Djärv <jan.h.d@swipnet.se>
648
649 * xfns.c (unwind_create_frame):
650 * nsfns.m (unwind_create_frame):
651 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
652 Vframe_list (Bug#9999).
653
22a648b4
DA
6542011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
655
0b381c7e 656 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 657
659afede
KH
6582011-11-11 Kenichi Handa <handa@m17n.org>
659
660 * callproc.c (Fcall_process): Set the member dst_multibyte of
661 process_coding.
662
9ac0394b
KH
6632011-11-11 Johan Bockgård <bojohan@gnu.org>
664
665 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
666 avoid a crash (bug#9496).
667
2fbdc249
CY
6682011-11-09 Chong Yidong <cyd@gnu.org>
669
670 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
671 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
672
ac6b1f81
PE
6732011-11-08 Paul Eggert <eggert@cs.ucla.edu>
674
675 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
676
09db192c
PE
6772011-11-08 Paul Eggert <eggert@cs.ucla.edu>
678
679 Avoid some portability problems by eschewing 'extern inline' functions.
680 The trivial performance wins aren't worth the portability hassles; see
681 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
682 et seq.
683 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
684 (window_box_width, window_box_left, window_box_left_offset)
685 (window_box_right, window_box_right_offset): Undo previous change,
686 by removing the "extern"s.
687 * intervals.c (adjust_intervals_for_insertion)
688 (adjust_intervals_for_deletion): Undo previous change,
689 making these static again.
690 (offset_intervals, temp_set_point_both, temp_set_point)
691 (copy_intervals_to_string): No longer inline.
692 * xdisp.c (window_text_bottom_y, window_box_width)
693 (window_box_height, window_box_left_offset)
694 (window_box_right_offset, window_box_left, window_box_right)
695 (window_box): No longer inline.
696
105216ed
CY
6972011-11-08 Chong Yidong <cyd@gnu.org>
698
699 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
700 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
701 Signal an error if not a live window.
105216ed
CY
702 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
703 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
704
ae9e237f
JB
7052011-11-07 Juanma Barranquero <lekktu@gmail.com>
706
707 * lisp.h (syms_of_abbrev): Remove declaration.
708 Reported by CHENG Gao <chenggao@royau.me>.
709
c7aa8333
EZ
7102011-11-07 Eli Zaretskii <eliz@gnu.org>
711
712 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
713 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
714 of temacs in GUI mode.
715
be7f5545
MR
7162011-11-07 Martin Rudalics <rudalics@gmx.at>
717
718 * window.h: Declare delete_all_child_windows instead of
719 delete_all_subwindows.
720 * window.c (Fwindow_nest, Fset_window_nest)
721 (Fset_window_new_total, Fset_window_new_normal)
722 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
723 (delete_all_subwindows): Rename to delete_all_child_windows.
724 (Fdelete_other_windows_internal, Fset_window_configuration):
725 Call delete_all_child_windows instead of delete_all_subwindows.
726 * frame.c (delete_frame): Call delete_all_child_windows instead
727 of delete_all_subwindows.
728
ca78dc43
PE
7292011-11-07 Paul Eggert <eggert@cs.ucla.edu>
730
731 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
732 This is also needed for porting to any host where GC_MARK_STACK is
733 not GC_MAKE_GCPROS_NOOPS.
734 (which_symbols): Use it.
735
a0241d01
KH
7362011-11-07 Kenichi Handa <handa@m17n.org>
737
738 * coding.c (coding_set_destination): Check coding->src_pos only
739 when coding->src_object is a buffer (bug#9910).
740
741 * process.c (send_process): Set the member src_multibyte of coding
742 to 0 (bug#9911) when sending a unibyte text.
743
744 * callproc.c (Fcall_process): Set the member src_multibyte of
745 process_coding to 0 (bug#9912).
746
a64bfdfa 7472011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
748
749 * xmenu.c (cleanup_widget_value_tree): New function.
750 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
751 calling free_menubar_widget_value_tree directly (Bug#9830).
752
cb41b32a
PE
7532011-11-06 Paul Eggert <eggert@cs.ucla.edu>
754
755 Fix some portability problems with 'inline'.
756 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
757 (window_box_width, window_box_left, window_box_left_offset)
758 (window_box_right, window_box_right_offset): Declare extern.
759 Otherwise, these inline functions do not conform to C99 and
760 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
761 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
762 * intervals.c (adjust_intervals_for_insertion)
763 (adjust_intervals_for_deletion): Now extern, because otherwise the
764 extern inline functions 'offset_intervals' couldn't refer to it.
765 (static_offset_intervals): Remove.
766 (offset_intervals): Rewrite using the old contents of
767 static_offset_intervals. The old version didn't conform to C99
768 because an extern inline function contained a reference to an
769 identifier with static linkage.
770
b7041366
AS
7712011-11-06 Andreas Schwab <schwab@linux-m68k.org>
772
773 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
774 GC.
775
88a37c4d
EZ
7762011-11-06 Eli Zaretskii <eliz@gnu.org>
777
778 * xdisp.c (init_iterator, reseat_to_string): Don't set the
779 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
780 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
781 return Qleft_to_right.
782
49745b39
CY
7832011-11-06 Chong Yidong <cyd@gnu.org>
784
785 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
786 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
787 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
788 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
789 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
790 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
791 (Fwindow_vscroll): Doc fix.
792 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
793 argument, since it makes no sense to pass a live window and for
794 consistency with window-child.
795
1f05cd82
CS
7962011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
797
798 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
799 support MSVC.
800
22610910
JR
8012011-11-05 Jason Rumney <jasonr@gnu.org>
802
803 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
804 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
805 fonts (Bug#6029).
806 (add_font_entity_to_list): Fix logic errors in mixed boolean and
807 bitwise arithmetic preventing use of unicode-sip and non-truetype
808 opentype fonts.
809
a06776b2
EZ
8102011-11-05 Eli Zaretskii <eliz@gnu.org>
811
3ad924ba
EZ
812 * s/ms-w32.h (fstat, stat, utime): Move redirections to
813 "emacs"-only part.
814
a06776b2
EZ
815 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
816 initialization code to keep similarity to xfns.c after changes
817 from 2011-11-05.
818
c9e7db78
JD
8192011-11-05 Jan Djärv <jan.h.d@swipnet.se>
820
a97f8f3f
JD
821 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
822 (unwind_create_frame): New function (Bug#9943).
823 (Fx_create_frame): Restructure code to be more similar to the one in
824 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
825 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
826 Move terminal->reference_count++ just before making the frame official
827 (Bug#9943).
828
829 * nsterm.m (x_free_frame_resources): New function.
830 (x_destroy_window): Move code to x_free_frame_resources.
831
c9e7db78 832 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
833 (Fx_create_frame, x_create_tip_frame):
834 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
835 official. Move initialization of image_cache_refcount and
836 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
837
a6fc3b5c
EZ
8382011-11-05 Eli Zaretskii <eliz@gnu.org>
839
840 Support MSVC build with newer versions of Visual Studio.
841 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
842 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
843 nt/gmake.defs.
844
845 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
846 which are not supported by MSVC.
847 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
848 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
849 bitfields.
850 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
851 types in bitfields.
852 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
853
854 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
855
58179cce 8562011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
857
858 Support MSVC build with newer versions of Visual Studio.
859 * w32.c: Don't include w32api.h for MSVC.
860 (init_environment) [_MSC_VER]: Call sys_access, not _access.
861
862 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
863 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
864 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
865 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
866 e_* cousins.
867 (alloca) [_MSC_VER]: Define to _alloca.
868
869 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
870
871 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
872
a58c13ed
EZ
8732011-11-04 Eli Zaretskii <eliz@gnu.org>
874
875 * xdisp.c (note_mouse_highlight): If either of
876 previous/next-single-property-change returns nil, treat that as
877 the beginning or the end of the buffer. (Bug#9955)
878
fe0b6370
JD
8792011-11-04 Jan Djärv <jan.h.d@swipnet.se>
880
a58c13ed 881 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
882 label is not null (Bug#9951).
883 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
884 may be NULL.
885
89bd5ee1
EZ
8862011-11-04 Eli Zaretskii <eliz@gnu.org>
887
888 * window.c (Fwindow_body_size): Mention in the doc string that the
889 return value is in frame's canonical units. (Bug#9949)
890
84c3edb9
EZ
8912011-11-03 Eli Zaretskii <eliz@gnu.org>
892
4e2fb5c7
EZ
893 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
894
84c3edb9 895 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 896 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 897 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 898
bc17a887
EZ
8992011-11-01 Eli Zaretskii <eliz@gnu.org>
900
901 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
902 Don't stop backward scan on the continuation glyph, even though
903 its CHARPOS is positive.
6d5eb5b0
SM
904 (mouse_face_from_buffer_pos, note_mouse_highlight):
905 Rename cover_string to disp_string.
bc17a887 906
4ee88440
MR
9072011-11-01 Martin Rudalics <rudalics@gmx.at>
908
909 * window.c (temp_output_buffer_show): Don't use
910 Vtemp_buffer_show_specifiers.
911 (Vtemp_buffer_show_specifiers): Remove unused variable.
912
c2ff3c02
EZ
9132011-10-30 Eli Zaretskii <eliz@gnu.org>
914
915 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
916 past the beginning of the current glyph matrix.
917
58179cce 9182011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
919
920 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
921 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
922 HAVE_GTK3 (Bug#9869).
b77a6a7f 923
3b574623
JD
924 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
925 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
926
b77a6a7f
JD
927 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
928
929 * xterm.c: Declare x_handle_net_wm_state to return int.
930 (handle_one_xevent): Check if we are iconified but don't have
931 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
932 (get_current_wm_state): Return non-zero if not hidden,
933 check for _NET_WM_STATE_HIDDEN (Bug#9893).
934 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
935 (x_handle_net_wm_state): Return what get_current_wm_state returns.
936 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
937
196e41e4
PE
9382011-10-29 Paul Eggert <eggert@cs.ucla.edu>
939
940 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
941 so that this new function doesn't get optimized away by a
942 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
943
021f2e1a
AS
9442011-10-29 Andreas Schwab <schwab@linux-m68k.org>
945
946 * frame.h (MOUSE_HL_INFO): Remove excess parens.
947
8b058d44
EZ
9482011-10-29 Eli Zaretskii <eliz@gnu.org>
949
950 Fix the `xbytecode' command.
951 * .gdbinit (xprintbytestr): New command.
b50a28de 952 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
953 (xbytecode): Print the byte-code string as well.
954
4452fb80
EZ
9552011-10-29 Kim Storm <storm@cua.dk>
956
8b058d44
EZ
957 * alloc.c (which_symbols): New function.
958
21b72067
AS
9592011-10-29 Andreas Schwab <schwab@linux-m68k.org>
960
961 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
962 line. (Bug#9903)
963
83ed7b5c
GM
9642011-10-29 Glenn Morris <rgm@gnu.org>
965
966 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
967 Not clear what it was for, and it causes various bugs. (Bug#9839)
968
5a7a728b
EZ
9692011-10-28 Eli Zaretskii <eliz@gnu.org>
970
971 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
972 possible random value that matches one of those tested as
973 condition to clear the mouse face.
974
d3d0842f
CY
9752011-10-28 Chong Yidong <cyd@gnu.org>
976
977 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
978
31b39d13
DN
9792011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
980
981 * window.c (make_window): Initialize phys_cursor_on_p.
982
9aba6043
SM
9832011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
984
985 * lisp.h (struct Lisp_Symbol): Update comments.
986
c20992f4
JB
9872011-10-28 Juanma Barranquero <lekktu@gmail.com>
988
989 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
990
db4f02f2
EZ
9912011-10-28 Eli Zaretskii <eliz@gnu.org>
992
993 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
994 <oslsachem@gmail.com> for helping to debug this.
995
996 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
997 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
998 (g_b_init_get_glyph_outline_w): New static variables.
999 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1000 (GetGlyphOutlineW_Proc): New typedefs.
1001 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1002 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1003 New functions.
1004 (w32font_open_internal, compute_metrics):
1005 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1006 instead of calling the "wide" APIs directly.
1007
1008 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1009
1010 * w32.h (syms_of_w32font): Add prototype.
1011
87e68db4
JB
10122011-10-27 Juanma Barranquero <lekktu@gmail.com>
1013
1014 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1015 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1016 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1017 (Fmove_to_window_line): Doc fix.
1018
435c1d67
CY
10192011-10-27 Chong Yidong <cyd@gnu.org>
1020
1021 * process.c (make_process): Set gnutls_state to NULL.
1022
1023 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1024 non-NULL, regardless of GNUTLS_INITSTAGE.
1025 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1026 an error. Set process slots as soon as we allocate them.
1027
1028 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1029
9c6c6f49
CY
10302011-10-27 Chong Yidong <cyd@gnu.org>
1031
9aba6043
SM
1032 * gnutls.c (emacs_gnutls_deinit): New function.
1033 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1034 (Fgnutls_deinit, Fgnutls_boot): Use it.
1035
1036 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1037 (deactivate_process): Call emacs_gnutls_deinit.
1038
657d08d3
JB
10392011-10-27 Juanma Barranquero <lekktu@gmail.com>
1040
1041 * image.c (x_create_x_image_and_pixmap):
1042 * w32.c (sys_rename, w32_delayed_load):
1043 * w32font.c (fill_in_logfont):
1044 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1045
5430d399
JB
10462011-10-26 Juanma Barranquero <lekktu@gmail.com>
1047
1048 * w32fns.c (w32_default_color_map): New function,
1049 extracted from Fw32_default_color_map.
a7ef684b 1050 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1051
fe0055fa
PE
10522011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1053
1054 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1055
e6346438
SM
10562011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1057
1058 * keyboard.c (test_undefined): New function (bug#9751).
1059 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1060
e112cc37
ET
10612011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1062
1063 * sysdep.c (init_sys_modes): Fix the check for the controlling
1064 terminal (Bug#6649).
1065
7b5d6677
EZ
10662011-10-20 Eli Zaretskii <eliz@gnu.org>
1067
1068 * dispextern.h (struct bidi_it): New member next_en_type.
1069
1070 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1071 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1072 current character, check also for next_en_type being WEAK_EN.
1073 (bidi_resolve_weak): Don't enter the expensive loop if the current
1074 position is before next_en_pos. Record the bidi type of the first
1075 non-ET, non-BN character we find, in addition to its position.
1076 (bidi_level_of_next_char): Invalidate next_en_type when
1077 next_en_pos is over-stepped.
1078
7da0b018
PE
10792011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1082 * editfns.c: Rewrite current-time-zone so that it invokes
1083 the equivalent of (format-time-string "%Z") to get the time zone name.
1084 This fixes a bug when the time zone name contains characters that
1085 need converting from the system time locale to Emacs internal format.
1086 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1087 that patch fixed format-time-string to do the conversion, but
1088 I forgot to fix current-time-zone.
1089 (format_time_string): New function, containing most of
1090 what Fformat_time_string used to contain.
1091 (Fformat_time_string): Rewrite in terms of format_time_string.
1092 This doesn't change this function's behavior.
1093 (current-time-zone): Rewrite to use format_time_string.
1094 This fixes the bug reported by Michael Schierl in
1095 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1096 Jason Rumney's 2007-06-07 change worked around this bug, but
1097 didn't fix it.
1098 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1099
8547b010
EZ
11002011-10-19 Eli Zaretskii <eliz@gnu.org>
1101
1102 * xdisp.c (start_display): If the character at POS is displayed
1103 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1104 (try_window_reusing_current_matrix): If a line ends in a display
1105 vector or the next line starts in a display vector, continue
1106 redrawing the window even though the character position of
1107 start_row was reached.
8547b010
EZ
1108 (Bug#9771, part 2)
1109
4e948d15
CY
11102011-10-18 Chong Yidong <cyd@gnu.org>
1111
1112 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1113 with nobreak-char-display too.
1114
4787455f
EZ
11152011-10-18 Eli Zaretskii <eliz@gnu.org>
1116
1117 Fix part 3 of bug#9771.
1118 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1119 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1120 non-neutral characters if the current character is a paragraph
1121 separator (a.k.a. Newline). This avoids running the same
1122 expensive loop twice, once when we consume the preceding newline
1123 and the other time when the line actually needs to be displayed.
1124 Avoid the loop when we see neutrals on the base embedding level
1125 following a character whose directionality is the same as the
1126 paragraph's. This avoids running the expensive loop when a line
1127 ends in a long sequence of neutrals, like control characters.
1128 Add assertion against STRONG_AL type. Slightly rearrange code
1129 that determines the type of a neutral given the first non-neutral
1130 that follows it.
1131 (bidi_level_of_next_char): Set next_en_pos to zero when
1132 invalidating its info.
1133
2c91f553
EZ
11342011-10-17 Eli Zaretskii <eliz@gnu.org>
1135
1136 * xdisp.c (push_display_prop): Determine whether to record string
1137 or buffer position by IT->string, not by IT->method. Allow
1138 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1139 (move_it_vertically_backward): Don't look for character position
1140 immediately after the newline when in a continuation line.
1141 (Bug#9771, part 1)
2c91f553 1142
c7b08b0d
MR
11432011-10-15 Martin Rudalics <rudalics@gmx.at>
1144
1145 * window.c (coordinates_in_window): Rewrite and delabelize
1146 vertical border check. (Bug#5357) (Bug#9618)
1147
6b02f655
SM
11482011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1149
1150 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1151 errors in XSetWindowBorder (bug#9310).
1152
81d40c92
DA
11532011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1154
1155 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1156 avoid crash when xmalloc overrun checking is enabled.
1157
d4172c3b
EZ
11582011-10-13 Eli Zaretskii <eliz@gnu.org>
1159
1160 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1161 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1162 cursor motion with <left> and <right> arrow keys.
1163
1164 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1165 some callers set that themselves.
1166
b00eea75
EZ
11672011-10-12 Eli Zaretskii <eliz@gnu.org>
1168
1169 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1170 display string and the previous row comes from the same string and
1171 is empty. (Bug#9739) (Bug#9738)
1172
8fe012c4
SM
11732011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1174
1175 * doc.c (get_doc_string): Encode file name (bug#9735).
1176
0074aef2
EZ
11772011-10-12 Eli Zaretskii <eliz@gnu.org>
1178
79beb178
EZ
1179 * bidi.c (bidi_level_of_next_char):
1180 * xdisp.c (get_visually_first_element): Remove old incorrect
1181 comments regarding the Unicode Line Separator character.
1182
0074aef2
EZ
1183 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1184
6e4b3fbe
DA
11852011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1186
1187 * alloc.c (Fgc_status): Do not access beyond zombies array
1188 boundary if nzombies > MAX_ZOMBIES.
1189 * alloc.c (dump_zombies): Add missing format specifier.
1190
0324f3af
PE
11912011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1192
b5525cac
PE
1193 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1194 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1195
0324f3af
PE
1196 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1197 Some packages use them to denote characters with modifiers.
1198
e9b5f888
AS
11992011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1200
1201 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1202 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1203 matching a pp-number. Rename parameter var to var1.
1204
127827c0
SM
12052011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1206
1207 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1208
c8fd3bd0
GM
12092011-10-08 Glenn Morris <rgm@gnu.org>
1210
1211 * callint.c (Fcall_interactively): Give a more explicit error for the
1212 'c' case with a non-character input. (Bug#8479)
1213
352ec8ff
EZ
12142011-10-08 Eli Zaretskii <eliz@gnu.org>
1215
03669ccb
EZ
1216 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1217 lines.
7061c986
EZ
1218 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1219 lines that are hscrolled on the left.
03669ccb 1220
352ec8ff
EZ
1221 * dispnew.c (buffer_posn_from_coords): Account for a possible
1222 presence of header-line. (Bug#4426)
1223
a66cfb1c
SM
12242011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1225
6b02f655
SM
1226 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1227 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1228
7c5ee88e
PE
12292011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1230
1231 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1232 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1233 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1234 this makes Emacs dump core during garbage collection on rare
1235 occasions. sizeof is obviously inferior to offsetof here, so
1236 stick with offsetof.
1237 (GC_POINTER_ALIGNMENT): New macro.
1238 (mark_memory): Omit 3rd (offset) arg; caller changed.
1239 Don't assume EMACS_INT alignment is the same as pointer alignment.
1240
df1bbe5b
SM
12412011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1242
1243 * keyboard.c (read_key_sequence_remapped): New var.
1244 (read_key_sequence): Compute remapping in the right buffer.
1245 (command_loop_1): Use read_key_sequence's remapping directly.
1246
51553db6
SM
12472011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1248
32c1fffd
SM
1249 * dired.c (file_name_completion): Don't expand file name.
1250 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1251 before checking file name handler.
1252
51553db6
SM
1253 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1254 they've been requested explicitly (bug#9591).
1255
b6bd1599 12562011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1257
1258 * keymap.c (Fsingle_key_description): Use make_specified_string
1259 instead of build_string to build string from push_key_description.
1260 (Bug#5193)
1261
f701dc2a
PE
12622011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1263
4222c55d
PE
1264 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1265 This fixes a Y2038 bug on 64-bit hosts.
1266 * buffer.c (reset_buffer):
1267 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1268 (Fclear_buffer_auto_save_failure):
1269 Use 0, not -1, to represent an unset failure time, since time_t
1270 might not be signed.
1271
f701dc2a
PE
1272 Remove dependency on glibc malloc internals.
1273 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1274 Move back here from lisp.h, but with their new implementations.
1275 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1276 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1277 * charset.c (charset_table_init): New static var.
1278 (syms_of_charset): Use it instead of xmalloc. This removes a
1279 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1280 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1281 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1282 Move back to alloc.c.
1283 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1284 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1285
9ceebf39
JD
12862011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1287
1288 * nsterm.m (windowDidResize): Call x_set_window_size only when
1289 ns_in_resize is true. Otherwise set pixelwidth/height and
1290 call change_frame_size (Bug#9628).
1291
cb993c58
PE
12922011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1293
3930c88b
PE
1294 Port --enable-checking=all to Fedora 14 x86-64.
1295 * charset.c (syms_of_charset): Also account for glibc malloc's
1296 internal overhead when calculating the initial malloc maximum.
1297
cb993c58
PE
1298 Port --enable-checking=all to Fedora 14 x86.
1299 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1300 Move to lisp.h.
1301 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1302 (overrun_check_realloc, overrun_check_free):
1303 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1304 That way, xmalloc returns a properly-aligned pointer even if
1305 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1306 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1307 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1308 into account when calculating the initial malloc maximum.
1309 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1310 Move here from alloc.c, so that charset.c can use it too.
1311 Properly align; the old code wasn't right for common 32-bit hosts
1312 when configured with --enable-checking=all.
1313 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1314 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1315
31bed486
EZ
13162011-09-29 Eli Zaretskii <eliz@gnu.org>
1317
04c70788 1318 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1319 use EDOM.
1320
fbcaa2f3
EZ
13212011-09-28 Eli Zaretskii <eliz@gnu.org>
1322
1323 * xdisp.c (compute_display_string_end): If there's no display
1324 string at CHARPOS, return -1.
1325
1326 * bidi.c (bidi_fetch_char): When compute_display_string_end
1327 returns a negative value, treat the character as a normal
1328 character not covered by a display string. (Bug#9624)
1329
a239d4e9
JB
13302011-09-28 Juanma Barranquero <lekktu@gmail.com>
1331
1332 * lread.c (Fread_from_string): Fix typo in docstring.
1333
88652fd5
EZ
13342011-09-27 Eli Zaretskii <eliz@gnu.org>
1335
1336 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1337 newline, reseat the iterator instead of bidi-iterating there one
1338 character at a time. (Bug#9610)
32c1fffd
SM
1339 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1340 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1341
ed497dd4
AS
13422011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1343
1344 * lread.c (readevalloop): Use correct code for NBSP.
1345 (read1): Likewise. (Bug#9608)
1346
b2bf61aa
MA
13472011-09-25 Michael Albinus <michael.albinus@gmx.de>
1348
1349 * dbusbind.c (Fdbus_register_signal): When service is not
1350 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1351
32bbb17c
GM
13522011-09-25 Glenn Morris <rgm@gnu.org>
1353
1354 * buffer.c (truncate-lines): Doc fix.
1355
94e0933e
CY
13562011-09-24 Chong Yidong <cyd@stupidchicken.com>
1357
1358 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1359 (Fset_window_next_buffers): Doc fix.
1360
cddde921
GM
13612011-09-24 Glenn Morris <rgm@gnu.org>
1362
1363 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1364
1260aef1
PE
13652011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1366
25b4bfa0
PE
1367 Fix minor problems found by static checking.
1368 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1369 * indent.c (Fvertical_motion): Fix == vs = typo.
1370
e3cbd34b
EZ
13712011-09-24 Eli Zaretskii <eliz@gnu.org>
1372
a66cfb1c
SM
1373 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1374 Default value is now t. Doc fix.
6bf7006f 1375
e3cbd34b 1376 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1377 logic when moving up, not only when moving down. Fix the
e3cbd34b 1378 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1379 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1380
1381 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1382 CHARPOS is covered by a display string which includes newlines.
1383 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1384 is covered by a display string with embedded newlines.
1385
a3de0cbd
MA
13862011-09-24 Michael Albinus <michael.albinus@gmx.de>
1387
1388 * dbusbind.c (Fdbus_register_signal): Add match rule to
1389 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1390 (Fdbus_register_method, Vdbus_registered_objects_table):
1391 Fix docstring.
a3de0cbd 1392
b260039d
JM
13932011-09-24 Jim Meyering <meyering@redhat.com>
1394
32c1fffd 1395 do not ignore write error for any output size
b260039d
JM
1396 The previous change was incomplete.
1397 While it makes emacs --batch detect the vast majority of stdout
1398 write failures, errors were still ignored whenever the output size is
1399 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1400 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1401 && echo FAIL: ignored write error
1402 FAIL: ignored write error
1403 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1404 && echo FAIL: ignored write error
1405 FAIL: ignored write error
1406 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1407
8eca8a7c
AS
14082011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1409
1410 * emacs.c (Fkill_emacs): In noninteractive mode exit
1411 non-successfully if a write error occurred on stdout. (Bug#9574)
1412
3341db62
EZ
14132011-09-21 Eli Zaretskii <eliz@gnu.org>
1414
1415 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1416 the xassert test.
1417
1418 * dispextern.h (struct it): Update the comment documenting what
1419 can it->OBJECT be.
1420
8c203dbf
EZ
14212011-09-20 Eli Zaretskii <eliz@gnu.org>
1422
1423 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1424 a display string, extend search for cursor position to end of row.
1425 (find_row_edges): If the row ends in a newline from a display
1426 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1427 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1428 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1429 non-empty line. Fixes confusing cursor motion with arrow keys at
1430 the beginning of a line that starts with whitespace.
8c203dbf 1431
a4824228
LMI
14322011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1433
1434 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1435 (bug#9493).
1436
33ed493b
CY
14372011-09-18 Chong Yidong <cyd@stupidchicken.com>
1438
1439 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1440 boolean (Bug#9154).
1441
56cd55c8
EZ
14422011-09-18 Eli Zaretskii <eliz@gnu.org>
1443
1444 * xdisp.c (display_line): Record maximum and minimum buffer
1445 positions even if no glyphs were produced (e.g., by a zero-width
1446 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1447 buffer positions that will be removed from the glyph row because
1448 they don't fit.
c02dcedf
EZ
1449 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1450 column is beyond frame width: don't subtract 1 "pixel" when
1451 computing width of the stretch.
3e62b7e0
EZ
1452 (reseat_at_next_visible_line_start): Undo the change made on
1453 2011-09-17 that saved paragraph information and restored it after
1454 the call to `reseat'. (Bug#9545)
56cd55c8 1455
5ed99d36 14562011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1457
1458 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1459 and turn window cursor on if cleared (Bug#9415).
1460
5ed99d36 14612011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1462
1463 * search.c (boyer_moore): Take unibyte characters from pattern
1464 literally. (Bug#9458)
1465
9bade7b2
EZ
14662011-09-18 Eli Zaretskii <eliz@gnu.org>
1467
1468 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1469
e5e9d610
PE
14702011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1471
87e4427a
PE
1472 Fix minor problem found by static checking.
1473 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1474 initialized, to pacify gcc -Wuninitialized.
1475
e5e9d610
PE
1476 * fileio.c: Report proper errno when syscall falls.
1477 (Finsert_file_contents): Save and restore errno,
1478 so that report_file_error outputs the correct diagnostic.
1479 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1480
a1674f0b
EZ
14812011-09-18 Eli Zaretskii <eliz@gnu.org>
1482
1483 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1484
fbfb6dd4
EZ
14852011-09-17 Eli Zaretskii <eliz@gnu.org>
1486
1487 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1488 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1489
bb187662
EZ
14902011-09-17 Eli Zaretskii <eliz@gnu.org>
1491
1137e8b8 1492 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1493 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1494
1495 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1496 (bidi_find_paragraph_start): Search back for paragraph beginning
1497 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1498 (bidi_move_to_visually_next): Only trigger paragraph-related
1499 computations when the last character is a newline or at EOB, not
1500 just any NEUTRAL_B. (Bug#9470)
1501
bb187662
EZ
1502 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1503 truncated lines if point is covered by a display string. (Bug#9524)
1504
2e621251
PE
15052011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1506
1507 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1508 (cons_to_x_long): New function.
1509 (lisp_data_to_selection_data): Use it. Correct the test for
1510 short-versus-long data; it was negated. Break out of vector
1511 loop, for efficiency, when a long datum is discovered.
1512
91a15bc6
SM
15132011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1514
1515 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1516
b41c3a35
EZ
15172011-09-16 Eli Zaretskii <eliz@gnu.org>
1518
1519 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1520 GCC PR/17406) by declaring this function with external scope.
1521
7812ba2d
PE
15222011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1525 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1526
cf7edc2a
AS
15272011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1528
1529 * editfns.c (Fformat): Correctly handle text properties on "%%".
1530
bd01620e
EZ
15312011-09-15 Eli Zaretskii <eliz@gnu.org>
1532
1533 * xterm.c (x_draw_composite_glyph_string_foreground):
1534 * w32term.c (x_draw_composite_glyph_string_foreground):
1535 * term.c (encode_terminal_code):
1536 * composite.c (composition_update_it, get_composition_id):
1537 * xdisp.c (get_next_display_element)
1538 (fill_composite_glyph_string): Add comments about special meaning
1539 of TAB characters in a composition.
1540
a02719a3
PE
15412011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1542
1543 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1544 This occurs when processing a multibyte format.
1545 Problem reported by Wolfgang Jenker.
a02719a3 1546
72589a3c
JB
15472011-09-15 Johan Bockgård <bojohan@gnu.org>
1548
1549 * xdisp.c (try_cursor_movement): Only check for exact match if
1550 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1551
1c14176c
PE
15522011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 Remove unused external symbols.
1555 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1556 * xdisp.c (calc_pixel_width_or_height): Now static.
1557 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1558 * indent.c (check_display_width):
1559 * w32term.c: Fix comment to match code.
1560 * xterm.c, xterm.h (x_catching_errors): Remove.
1561
d2eea5b5
PE
15622011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1563
1564 * xselect.c: Use signed conversions more consistently (Bug#9498).
1565 (selection_data_to_lisp_data): Assume incoming selection data are
1566 signed integers, not unsigned. This is to be consistent with
1567 outgoing selection data, which was modified to use signed integers
1568 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1569 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1570 expects long, not unsigned long.
1571
46888499
EZ
15722011-09-14 Eli Zaretskii <eliz@gnu.org>
1573
1574 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1575 computation of loop end. Reported by Johan Bockgård
1576 <bojohan@gnu.org>.
1577
ef8ef9fb
CY
15782011-09-13 Chong Yidong <cyd@stupidchicken.com>
1579
1580 * frame.c (Fother_visible_frames_p): Function deleted.
1581
fa819fed
EZ
15822011-09-12 Eli Zaretskii <eliz@gnu.org>
1583
1584 * indent.c (compute_motion): Process display vector front to back
1585 rather than the other way around. (Bug#2496)
1586
2ba8e008
SM
15872011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1588
1589 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1590
20f53c69
CY
15912011-09-11 Chong Yidong <cyd@stupidchicken.com>
1592
1593 * minibuf.c (Fread_from_minibuffer): Doc fix.
1594
d562d7a4
EZ
15952011-09-11 Eli Zaretskii <eliz@gnu.org>
1596
1597 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1598 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1599
1c4d7f3d
LMI
16002011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1601
1602 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1603 value for non-existent files.
1604
b885bf36
EZ
16052011-09-11 Eli Zaretskii <eliz@gnu.org>
1606
1607 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1608 set its "size" to -1. This will set the modtime_size field of
1609 the corresponding buffer to -1, which is what
1610 verify-visited-file-modtime expects for files that do not exist.
1611 (Bug#9139)
1612
6612f0bf
PE
16132011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1614
1615 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1616 here ...
1617 * lisp.h: ... from here. push_key_description is no longer
1618 defined in keyboard.c, so its declaration should not be in
1619 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1620 logically belongs with push_key_description.
1621
dfb3f755
PE
16222011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1623
1624 * buffer.h: Include <sys/types.h> instead of <time.h>.
1625 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1626 Problem reported by Herbert J. Skuhra.
1627
3134906c
LMI
16282011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1629
1630 * xml.c (parse_region): Make the parsing work for
1631 non-comment-starting XML files again (bug#9144).
1632
8d903f4e
AS
16332011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1634
1635 * image.c (gif_load): Fix calculation of bottom and right corner.
1636 (Bug#9468)
1637
80ad64f4
EZ
16382011-09-10 Eli Zaretskii <eliz@gnu.org>
1639
1640 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1641 redisplay in small windows.
1642
208a048d
EZ
16432011-09-09 Eli Zaretskii <eliz@gnu.org>
1644
1645 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1646
9b1c252e
MR
16472011-09-08 Martin Rudalics <rudalics@gmx.at>
1648
1649 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1650 Operate on live windows only.
1651
2949f33b
JB
16522011-09-08 Juanma Barranquero <lekktu@gmail.com>
1653
1654 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1655
e08dcafd
EZ
16562011-09-07 Eli Zaretskii <eliz@gnu.org>
1657
1658 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1659 only under bidi iteration.
1660
115b96bd
JD
16612011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1662
1663 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1664
c8199d0f
PE
16652011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1666
1667 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1668 Without this fix, the command to link temacs failed due to an
1669 undefined symbol __builtin_isnan. This is because
1670 /usr/include/iso/math_c99.h #defines isnan(x) to
1671 __builtin_isnan(x), but the bundled gcc, which identifies itself
1672 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1673 a __builtin_isnan.
1674 * floatfns.c (isnan): #undef, and then #define to a clone of
1675 what's in data.c.
1676 (Fisnan): Always define, since it's always available now.
1677 (syms_of_floatfns): Always define isnan at the Lisp level.
1678
e39b275c 16792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1680
1681 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1682
b2db44d9 16832011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1684
f4af5137 1685 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1686 The previous code assumed that file offsets (off_t values) fit in
1687 EMACS_INT variables, which is not true on typical 32-bit hosts.
1688 The code messed up by falsely reporting buffer overflow in cases
1689 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1690 when "big" contains more than 2**29 bytes, even though this
1691 inserts just one byte and does not overflow the buffer.
1692 (Finsert_file_contents): Store file offsets as off_t
1693 values, not as EMACS_INT values. Check for overflow when
1694 converting between EMACS_INT and off_t. When checking for
1695 buffer overflow or for overlap, take the offsets into account.
1696 Don't use EMACS_INT for small values where int suffices.
1697 When checking for overlap, fix a typo: ZV was used where
1698 ZV_BYTE was intended.
1699 (Fwrite_region): Don't assume off_t fits into 'long'.
1700 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1701
ecfc0a49
MA
17022011-09-05 Michael Albinus <michael.albinus@gmx.de>
1703
1704 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1705
6511acf2 17062011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1707
0999621a 1708 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1709
1710 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1711 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1712 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1713 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1714 (modify_event_symbol): Do not assume that the length of
1715 name_alist_or_stem is safe to alloca and fits in int.
1716 (Fexecute_extended_command): Likewise for function name and binding.
1717 (Frecursion_depth): Wrap around reliably on integer overflow.
1718 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1719 since some callers pass EMACS_INT values.
1720 (Fsingle_key_description): Don't crash if symbol name contains more
1721 than MAX_ALLOCA bytes.
1722 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1723 (get_minibuffer): Arg is now EMACS_INT, not int.
1724 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1725 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1726 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1727
2be7d702
PE
1728 * dbusbind.c (signature_cat): New function.
1729 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1730 Do not overrun buffer; instead, report string overflow.
1731
9d1df220
PE
1732 * dispnew.c (add_window_display_history): Don't overrun buffer.
1733 Truncate instead; this is OK since it's just a log.
1734
33ef5c64
PE
1735 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1736 even if the time zone offset is outlandishly large.
1737 Don't mishandle offset == INT_MIN.
1738
66c6fdd5
PE
1739 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1740 when creating daemon; the previous buffer-overflow check was incorrect.
1741
d749b01b
PE
1742 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1743 which has the guts of the old verror function.
1744
b5cd1905
PE
1745 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1746 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1747
6e1a67fb
PE
1748 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1749 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1750 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1751 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1752 length of string rather than counting it via multiple sprintfs;
1753 that's simpler and more reliable.
c21721cc
PE
1754 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1755 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1756 sprintf, in case result does not fit in int.
1757
c57b67fc
PE
1758 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1759 (fontset_from_font): Print it.
1760
8a401434
PE
1761 * frame.c (tty_frame_count): Now printmax_t, not int.
1762 (make_terminal_frame, set_term_frame_name): Print it.
1763 (x_report_frame_params): In X, window IDs are unsigned long,
1764 not signed long, so print them as unsigned.
1765 (validate_x_resource_name): Check for implausibly long names,
1766 and don't assume name length fits in 'int'.
1767 (x_get_resource_string): Don't blindly alloca invocation name;
1768 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1769 not fit in int.
1770
6e1a67fb
PE
1771 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1772 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1773 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1774
0df02bf3
PE
1775 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1776 Use esprintf, not sprintf, in case result does not fit in int.
1777
48e30793
PE
1778 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1779 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1780 it as a large positive number.
1781 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1782 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1783
a66ff6d8
PE
1784 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1785 in case result does not fit in int.
1786
aca216ff
PE
1787 * print.c (float_to_string): Detect width overflow more reliably.
1788 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1789 buffer overrun. Don't assume list length fits in 'int'. Treat
1790 print length of 0 as 0, not as infinity; to be consistent with other
1791 uses of print length in this function. Don't overflow print length
1792 index. Don't assume hash table size fits in 'long', or that
1793 vectorlike size fits in 'unsigned long'.
1794
31c286f7
PE
1795 * process.c (make_process): Use printmax_t, not int, to format
1796 process-name gensyms.
1797
55e5faa1
PE
1798 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1799
80f2e268
PE
1800 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1801 to avoid potential buffer overrun.
1802
670741ab
PE
1803 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1804 if X resource line is longer than 512 bytes.
1805
b7163a50
PE
1806 * xfns.c (x_window): Make sprintf buffer a bit bigger
1807 to avoid potential buffer overrun.
1808
ae58ff1f
PE
1809 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1810
c43c8a6a
PE
1811 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1812
3f8236f4
PE
18132011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1814
53e9fe90 1815 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1816 Without these, Emacs silently mishandles large integers sometimes.
1817 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1818 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1819
6511acf2
PE
1820 * xdisp.c (try_window_id): Check Emacs fixnum range before
1821 converting to 'int'.
806add1d 1822
6511acf2 1823 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1824 Check that an Emacs fixnum is in range before assigning it to 'int'.
1825 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1826 values converted from Emacs fixnums.
1827 (Frecenter): Don't wrap around a line count if it is out of 'int'
1828 range; instead, treat it as an extreme value.
1829 (Fset_window_configuration, compare_window_configurations):
1830 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1831
6511acf2
PE
1832 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1833 that can exceed INT_MAX. Check that EMACS_INT value is in range
1834 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1835 (match_limit): Don't assume that a fixnum can fit in 'int'.
1836
6511acf2 1837 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1838 exceed INT_MAX.
1839
6511acf2 1840 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1841 (Fvertical_motion): Don't wrap around LINES values that don't fit
1842 in 'int'. Instead, treat them as extreme values. This is good
1843 enough for windows, which can't have more than INT_MAX lines anyway.
1844
fcb901a7
LMI
18452011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1846
0f2f6b6d
LMI
1847 * Require libxml/parser.h to avoid compilation warning.
1848
fcb901a7
LMI
1849 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1850
1851 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1852 since this reportedly can destroy thread storage.
1853
6e20a0d4
CY
18542011-08-30 Chong Yidong <cyd@stupidchicken.com>
1855
1856 * syntax.c (find_defun_start): Update all cache variables if
1857 exiting early (Bug#9401).
1858
148ae00e
EZ
18592011-08-30 Eli Zaretskii <eliz@gnu.org>
1860
f6cfbd8f
EZ
1861 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1862
148ae00e
EZ
1863 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1864 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1865 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1866
1867 * term.c (tty_append_glyph): New function.
1868 (produce_stretch_glyph): Static function and its prototype deleted.
1869
a66cfb1c
SM
1870 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1871 Add prototypes.
148ae00e 1872
c4a07a4c
PE
18732011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1876 when checking :margin (Bug#9390).
1877 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1878 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1879 so that the name doesn't mislead. All uses changed.
1880
6bc8cd65
JB
18812011-08-28 Johan Bockgård <bojohan@gnu.org>
1882
1883 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1884 set_tty_hooks.
1885
dca4927e
EZ
18862011-08-27 Eli Zaretskii <eliz@gnu.org>
1887
1888 * xdisp.c (move_it_to): Don't bail out early when reaching
1889 position beyond to_charpos, if we are scanning backwards.
1890 (move_it_vertically_backward): When DY == 0, make sure we get to
1891 the first character in the line after the newline.
1892
f2cad773
PE
18932011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1894
1895 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1896 (ccl_driver): Do not generate an out-of-range pointer.
1897 (Fccl_execute_on_string): Remove unnecessary check for
1898 integer overflow, noted by Stefan Monnier in
1899 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1900 Remove a FIXME that didn't need fixing.
1901 Simplify the newly-introduced buffer reallocation code.
1902
0cae2cdb
JB
19032011-08-27 Juanma Barranquero <lekktu@gmail.com>
1904
1905 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1906
5fc295a4 19072011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1908
70c60eb2 1909 Integer and memory overflow issues (Bug#9196).
726e0ab1 1910
d31850da
PE
1911 * doc.c (get_doc_string): Rework so that
1912 get_doc_string_buffer_size is the actual buffer size, rather than
1913 being 1 less than the actual buffer size; this makes xpalloc more
1914 convenient.
1915
a69fbedb
PE
1916 * image.c (x_allocate_bitmap_record, cache_image):
1917 * xselect.c (Fx_register_dnd_atom):
1918 Simplify previous changes by using xpalloc.
1919
fe5c5d37
PE
1920 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1921 since either will do and ptrdiff_t is convenient with xpalloc.
1922
0065d054
PE
1923 * charset.c (charset_table_size)
1924 (struct charset_sort_data.priority): Now ptrdiff_t.
1925 (charset_compare): Don't overflow if priorities differ greatly.
1926 (Fsort_charsets): Don't assume list length fits in int.
1927 Check for size-calculation overflow when allocating sort data.
1928 (syms_of_charset): Allocate an initial charset table that is
1929 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1930
1931 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1932
1933 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1934 The actual value is always <= INT_MAX, and leaving it unsigned made
1935 overflow checking harder.
1936
1937 * dispextern.h (struct glyph_matrix.rows_allocated)
1938 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1939 with xpalloc. The values are still always <= INT_MAX.
1940
1941 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1942
1943 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1944 (SAFE_NALLOCA): New macro.
1945
1946 * region-cache.c (struct boundary.pos, find_cache_boundary)
1947 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1948 (set_cache_region, invalidate_region_cache)
1949 (revalidate_region_cache, know_region_cache, region_cache_forward)
1950 (region_cache_backward, pp_cache):
1951 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1952 so that ptrdiff_t * can be passed to xpalloc.
1953 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1954 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1955 (pp_cache): Don't assume cache_len fits in int.
1956 * region-cache.h: Adjust extern decls to match.
1957
1958 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1959 EMACS_INT, since either will do, for xpalloc.
1960
1961 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1962 (xnmalloc, xnrealloc, xpalloc): New functions.
1963
726e0ab1
PE
1964 * bidi.c (bidi_shelve_header_size): New constant.
1965 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1966 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1967
51f30bc5 1968 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1969 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1970 (overlay_strings):
1971 Don't update size of array until after memory allocation succeeds,
1972 because xmalloc/xrealloc may not return.
0065d054
PE
1973 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1974 now that we have proper integer overflow checking.
1975 (record_overlay_string, overlay_strings): Catch overflows when
1976 calculating size of overlay_str_buf.
726e0ab1 1977
0065d054
PE
1978 * callproc.c (Fcall_process): Check for size overflow when
1979 calculating size of args2.
1980 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1981 Normally we prefer signed values, but sticking with ptrdiff_t would
1982 require adding more-complicated checks.
726e0ab1
PE
1983
1984 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1985 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1986 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1987 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1988
1989 * character.c (Fstring): Check for size-calculation overflow.
1990
1991 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1992 unnecessary integer overflow. Check for size overflow.
1993 (encode_coding_object): Don't update size until xmalloc succeeds.
1994
1995 * composite.c (get_composition_id): Check for overflow in glyph
1996 length calculations.
1997
1998 Integer and memory overflow fixes for display code.
1999 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2000 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2001 (scrolling_window): Check for overflow in size calculations.
2002 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2003 Don't assume glyph table len fits in int.
2004 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2005 (row_table_size): Now ptrdiff_t, not int.
2006 (scrolling_window): Avoid overflow in size calculations.
2007 Don't update size until allocation succeeds.
2008 * fns.c (concat): Check for overflow in size calculations.
2009 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2010 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2011 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2012
2013 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2014 (get_doc_string): Check for size calculation overflow.
2015 Don't update size until allocation succeeds.
2016 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2017 EMACS_INT, where ptrdiff_t will do.
2018 (Fsubstitute_command_keys): Check for string overflow.
2019
2020 * editfns.c (set_time_zone_rule): Don't assume environment length
2021 fits in int.
2022 (message_length): Now ptrdiff_t, not int.
2023 (Fmessage_box): Don't update size until allocation succeeds.
2024 Don't assume message length fits in int.
2025 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2026
0065d054
PE
2027 * emacs.c (main): Do not reallocate argv, since there is a null at
2028 the end that can be overwritten, and this way there's no need to
2029 worry about size-calculation overflow.
2030 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2031
2032 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2033 alloc succeeds.
2034 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2035
2036 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2037 (x_set_scroll_bar_width, x_figure_window_size):
2038 Check for integer overflow.
2039 (x_set_alpha): Do not assume XINT fits in int.
2040
2041 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2042 This is for the members text_lines, text_cols, total_lines, total_cols,
2043 where the system imposes an 'int' limit.
2044
2045 * fringe.c (Fdefine_fringe_bitmap):
2046 Don't update size until alloc works.
2047
2048 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2049 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2050
2051 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2052 Check for size-calculation overflow.
2053 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2054 do, as we prefer signed integers.
2055 (id_to_widget.max_size, id_to_widget.used)
2056 (xg_store_widget_in_map, xg_remove_widget_from_map)
2057 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2058 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2059 Use and return ptrdiff_t, not int.
2060 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2061 * gtkutil.h: Change prototypes to match the above.
2062
2063 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2064 are duplicate now that they've been promoted to lisp.h.
2065 (x_allocate_bitmap_record, x_alloc_image_color)
2066 (make_image_cache, cache_image, xpm_load):
2067 Don't update size until alloc is done.
2068 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2069 (x_detect_edges):
3256efce 2070 Check for size calculation overflow.
726e0ab1
PE
2071 (ct_colors_allocated_max): New constant.
2072 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2073 overflow.
3256efce 2074
726e0ab1
PE
2075 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2076 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2077 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2078 Use ptrdiff_t, not int, to count maps.
2079 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2080 calculations. Don't update size until allocation succeeds.
2081 Redo calculations to avoid overflow.
726e0ab1
PE
2082 * keyboard.h: Change prototypes to match the above.
2083
2084 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2085 to count maps.
2086 (current_minor_maps): Check for size calculation overflow.
2087 * keymap.h: Change prototypes to match the above.
2088
2089 * lread.c (read1, init_obarray): Don't update size until alloc done.
2090
2091 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2092 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2093
726e0ab1
PE
2094 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2095 Now ptrdiff_t, not int.
2096 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2097 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2098
2099 * process.c (Fnetwork_interface_list): Check for overflow
2100 in size calculation.
2101
2102 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2103
2104 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2105 overflow. Don't bother calling xmalloc when xrealloc will do.
2106
2107 * search.c (Freplace_match): Check for size calculation overflow.
2108 (Fset_match_data): Don't assume list lengths fit in 'int'.
2109
2110 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2111 for command line length. Do not attempt to address one before the
2112 beginning of an array, as that's not portable.
2113
2114 * term.c (max_frame_lines): Remove; unused.
2115 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2116 not int.
2117 (encode_terminal_code, calculate_costs): Check for size
2118 calculation overflow.
2119 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2120 table lengths and related sizes. Don't update size until alloc
2121 done. Redo calculations to avoid overflow.
2122 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2123
2124 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2125 subtracting pointers.
2126 (gobble_line): Check for overflow more carefully. Don't update size
2127 until alloc done.
2128
2129 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2130 Don't update size until alloc done.
2131 Redo size calculations to avoid overflow.
2132 Check for size calculation overflow.
0065d054 2133 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2134
2135 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2136 Use ptrdiff_t, not int, for sizes.
2137 (store_mode_line_noprop_char): Don't update size until alloc done.
2138
0065d054
PE
2139 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2140 Use ptrdiff_t, not int, for sizes.
2141 (Finternal_make_lisp_face, cache_face):
2142 Check for size calculation overflow.
2143 (cache_face): Treat size calculation overflows as if they were
2144 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2145
2146 * xfns.c (x_encode_text, x_set_name_internal)
2147 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2148 sizes, since they can exceed INT_MAX in size. Check for size
2149 calculation overflow.
2150
0065d054
PE
2151 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2152 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2153 Don't update size until alloc done.
2154
0065d054 2155 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2156 as sprintf is limited to int lengths.
1d526e2f 2157
252c5ee1
PE
2158 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2159 (X_LONG_MIN): New macros.
864d7ce7
PE
2160 Use them to make the following changes clearer.
2161 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2162 This change doesn't affect the value now, but it may help remind
2163 future maintainers not to raise the value too much later.
2164 (SELECTION_QUANTUM): Remove, replacing with ...
2165 (selection_quantum): ... new function, which avoids overflow.
2166 All uses changed.
2167 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2168 assumption that selection length fits in 'int'.
2169 (x_reply_selection_request, x_handle_selection_request)
2170 (x_get_window_property, receive_incremental_selection)
2171 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2172 (lisp_data_to_selection_data, clean_local_selection_data):
2173 Use ptrdiff_t, not int, to record length of selection.
2174 (x_reply_selection_request, x_get_window_property)
2175 (receive_incremental_selection, x_property_data_to_lisp):
2176 Redo calculations to avoid overflow.
2177 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2178 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2179 something.
2180 (x_get_window_property, receive_incremental_selection)
2181 (lisp_data_to_selection_data, x_property_data_to_lisp):
2182 Check for size-calculation overflow.
2183 (x_get_window_property, receive_incremental_selection)
2184 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2185 Don't store size until memory allocation succeeds.
2186 (x_get_window_property): Plug memory leak on memory exhaustion.
2187 Don't double-block input; malloc is safe here. Don't assume 2**34
2188 - 4 fits in unsigned long. Add an xassert to check
2189 XGetWindowProperty overflow. Be more careful about overflow
2190 calculations, and distinguish size from memory overflow better.
2191 (receive_incremental_selection): When tracing, don't assume
2192 unsigned int is less than INT_MAX.
2193 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2194 harmful) conversions of unsigned short to int.
2195 (lisp_data_to_selection_data): Don't assume that integers
2196 in the range -65535 through -1 fit in an X unsigned short.
2197 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2198 result parameters unless successful. Rely on cons_to_unsigned
2199 to report problems with elements; the old code wasn't right anyway.
2200 (x_check_property_data): Check for int overflow; we cannot use
2201 a wider type due to X limits.
2202 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2203
726e0ab1 2204 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2205
0065d054
PE
2206 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2207 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2208 (x_color_cells): Don't store size until memory allocation succeeds.
2209 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2210 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2211 (x_term_init): Don't assume length fits in int (sprintf is limited
2212 to int size).
bc18e09d 2213
ebfa62c0
PE
2214 Use ptrdiff_t for composition IDs.
2215 * character.c (lisp_string_width):
2216 * composite.c (composition_table_size, n_compositions)
2217 (get_composition_id, composition_gstring_from_id):
2218 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2219 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2220 * window.c (Frecenter):
2221 Use ptrdiff_t, not int, for composition IDs.
2222 * composite.c (get_composition_id): Check for integer overflow.
2223 * composite.h: Adjust prototypes to match the above changes.
2224
d3411f89
PE
2225 Use ptrdiff_t for hash table indexes.
2226 * category.c (hash_get_category_set):
2227 * ccl.c (ccl_driver):
2228 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2229 * coding.c (coding_system_charset_list, detect_coding_system):
2230 * coding.h (struct coding_system.id):
2231 * composite.c (get_composition_id, gstring_lookup_cache):
2232 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2233 * image.c (xpm_get_color_table_h):
2234 * lisp.h (hash_lookup, hash_put):
2235 * minibuf.c (Ftest_completion):
2236 Use ptrdiff_t for hash table indexes, not int (which is too
2237 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2238 32-bit --with-wide-int hosts).
2239
e097a6fa
PE
2240 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2241 Add a FIXME comment about memory leaks.
2242 (syms_of_charset): Don't assume xmalloc returns.
2243
5637687f
PE
2244 Don't assume that stated character widths fit in int.
2245 * character.c (Fchar_width, c_string_width, lisp_string_width):
2246 * character.h (CHAR_WIDTH):
2247 * indent.c (MULTIBYTE_BYTES_WIDTH):
2248 Use sanitize_char_width to avoid undefined and/or bad behavior
2249 with outlandish widths.
a66cfb1c 2250 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2251 now that we have two such functions. All uses changed.
2252 (sanitize_char_width): New inline function.
2253
a2271ba2
PE
2254 Don't assume that tab-width fits in int.
2255 * character.h (sanitize_width): New inline function.
2256 (SANE_TAB_WIDTH): New macro.
2257 (ASCII_CHAR_WIDTH): Use it.
2258 * indent.c (sane_tab_width): Remove. All uses replaced by
2259 SANE_TAB_WIDTH (current_buffer).
2260 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2261
18c52557
PE
2262 * fileio.c: Integer overflow issues with file modes.
2263 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2264
caeeedc1
PE
2265 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2266 Remove unreachable code.
2267 (read_hex, load_charset_map_from_file): Check for integer overflow.
2268
50849c52
PE
2269 * xterm.c: don't go over XClientMessageEvent limit
2270 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2271 (x_send_scroll_bar_event): Likewise. Check that the size does not
2272 exceed limits imposed by XClientMessageEvent, as well as the usual
2273 ptrdiff_t and size_t limits.
2274
b13995db
PE
2275 * keyboard.c: Overflow, signedness and related fixes.
2276 (make_lispy_movement): Use same integer type in forward decl
2277 that is used in the definition.
2278 (read_key_sequence, keyremap_step):
2279 Change bufsize argument back to int, undoing my 2011-03-30 change.
2280 We prefer signed types, and int is wide enough here.
2281 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2282 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2283 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2284 length, not size_t. Use ptrdiff_t for index, not int.
2285 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2286 possibility of integer overflow.
2287
13464394
PE
2288 Overflow, signedness and related fixes for images.
2289
2290 * dispextern.h (struct it.stack[0].u.image.image_id)
2291 (struct_it.image_id, struct image.id, struct image_cache.size)
2292 (struct image_cache.used, struct image_cache.ref_count):
2293 * gtkutil.c (update_frame_tool_bar):
2294 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2295 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2296 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2297 * nsmenu.m (update_frame_tool_bar):
2298 * xdisp.c (calc_pixel_width_or_height):
2299 * xfns.c (image_cache_refcount):
2300 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2301 on typical 64-bit hosts.
2302
2303 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2304 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2305 Omit unnecessary casts to int.
2306 (parse_image_spec): Check that integers fall into 'int' range
2307 when the callers expect that.
2308 (image_ascent): Redo ascent calculation to avoid int overflow.
2309 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2310 (lookup_image): Remove unnecessary tests.
2311 (xbm_image_p): Locals are now of int, not EMACS_INT,
2312 since parse_image_check makes sure they fit into int.
2313 (png_load, gif_load, svg_load_image):
2314 Prefer int to unsigned where either will do.
2315 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2316 old tiff_error_handler and tiff_warning_handler.
2317 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2318 stack buffer overflows. It uses only the features of vsnprintf
2319 that are common to both POSIX and native Microsoft.
2320 (tiff_error_handler, tiff_warning_handler): Use it.
2321 (tiff_load, gif_load, imagemagick_load_image):
2322 Don't assume :index value fits in 'int'.
2323 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2324 (imagemagick_load_image): Check that crop parameters fit into
2325 the integer types that MagickCropImage accepts. Don't assume
2326 Vimagemagick_render_type has a nonnegative value. Don't assume
2327 size_t fits in 'long'.
2328 (gs_load): Use printmax_t to print the widest integers possible.
2329 Check for integer overflow when computing image height and width.
2330
c11821d4
EZ
23312011-08-26 Eli Zaretskii <eliz@gnu.org>
2332
2333 * xdisp.c (redisplay_window): Don't force window start if point
2334 will be invisible in the resulting window. (Bug#9324)
2335
0c95fcf7
EZ
23362011-08-25 Eli Zaretskii <eliz@gnu.org>
2337
2338 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2339 the display spec is of the form `(space ...)'.
2340 (handle_display_spec): Return the value returned by
2341 handle_single_display_spec, not just 1 or zero.
2342 (handle_single_display_spec): If the display spec is of the form
2343 `(space ...)', and specifies display in the text area, return 2
2344 rather than 1.
fee65a97 2345 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2346 accurately, and prefer exact match for point under bidi.
2347 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2348
2349 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2350 into disp_prop; all users changed.
2351
2352 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2353 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2354 for the text covered by the display property.
2355
e4ed06f1
CY
23562011-08-25 Chong Yidong <cyd@stupidchicken.com>
2357
2358 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2359 Change return value to nil.
2360 (Frecord_buffer): Delete unused function.
2361
f67cdd7f
EZ
23622011-08-24 Eli Zaretskii <eliz@gnu.org>
2363
5980d4c6
EZ
2364 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2365 buffers, return left-to-right.
8610fe8b
EZ
2366 (set_cursor_from_row): Consider candidate row a win if its glyph
2367 represents a newline and point is on that newline. Fixes cursor
2368 positioning on the newline at EOL of R2L text within L2R
2369 paragraph, and vice versa.
2370 (try_cursor_movement): Check continued rows, in addition to
2371 continuation rows. Fixes unwarranted scroll when point enters a
2372 continued line of R2L text within an L2R paragraph, or vice versa.
2373 (cursor_row_p): Consider the case of point being equal to
2374 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2375 from the end of a short line to the beginning of a continued line
2376 of R2L text within L2R paragraph.
2377 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2378 composed characters.
5980d4c6 2379
f67cdd7f
EZ
2380 * bidi.c (bidi_check_type): Use xassert.
2381 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2382 members.
2383
bca633fb
EZ
23842011-08-23 Eli Zaretskii <eliz@gnu.org>
2385
2386 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2387 a character.
2388
4a5885a7
CY
23892011-08-23 Chong Yidong <cyd@stupidchicken.com>
2390
2391 * nsfont.m (ns_otf_to_script): Fix typo.
2392
0902a04e
KH
23932011-08-22 Kenichi Handa <handa@m17n.org>
2394
2395 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2396 extra slot even if the purpose is char-code-property-table.
2397
1a2e6670
EZ
23982011-08-23 Eli Zaretskii <eliz@gnu.org>
2399
8ddde651
EZ
2400 * xdisp.c (redisplay_window): When computing centering_position,
2401 account for the height of the header line. (Bug#8874)
2402
425cc014
EZ
2403 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2404 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2405 candidate is selected by the mouse, and that candidate has a
2406 composed character under the mouse.
2407
1a2e6670
EZ
2408 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2409 coordinates reported by pos-visible-in-window-p for a composed
2410 character in column zero.
2411
8b76d6f8
SM
24122011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2413
2414 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2415
dac347dd
EZ
24162011-08-22 Eli Zaretskii <eliz@gnu.org>
2417
2418 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2419 consider it a hit if to_charpos is anywhere in the range of the
2420 composed buffer positions.
2421
e013fb34
CY
24222011-08-22 Chong Yidong <cyd@stupidchicken.com>
2423
2424 * image.c (gif_load): Don't assume that each subimage has the same
2425 dimensions as the base image. Handle disposal method that is
2426 "undefined" by the gif spec (Bug#9335).
2427
bd1ba3e8
CY
24282011-08-20 Chong Yidong <cyd@stupidchicken.com>
2429
2430 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2431 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2432
54a1215b
EZ
24332011-08-19 Eli Zaretskii <eliz@gnu.org>
2434
823564e5
EZ
2435 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2436 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2437 from an Org mode buffer to a Speedbar frame.
2438
54a1215b
EZ
2439 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2440 a composition, take its buffer position from IT->cmp_it.charpos.
2441 Fixes cursor positioning at the beginning of a line that begins
2442 with a composed character.
2443
9778ebcc
EZ
24442011-08-18 Eli Zaretskii <eliz@gnu.org>
2445
0be6ee06
EZ
2446 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2447 character bidirectional type, use STRONG_L instead. Fixes crashes
2448 in a buffer produced by `describe-categories'.
2449
9778ebcc
EZ
2450 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2451 members before the level stack, so they would be saved and
2452 restored when copying iterator state. Fixes incorrect reordering
2453 around TABs covered by display properties.
2454
156bffbe
AS
24552011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2456
6b02f655 2457 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2458
72ad093b
CY
24592011-08-17 Chong Yidong <cyd@stupidchicken.com>
2460
2461 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2462 (internal_condition_case_2, internal_condition_case_n):
2463 Remove unnecessary aborts (Bug#9081).
72ad093b 2464
35774242
EZ
24652011-08-17 Eli Zaretskii <eliz@gnu.org>
2466
2467 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2468 has no `load' handler, try opening the file locally. (Bug#9311)
2469
db76dd85
KB
24702011-08-16 Ken Brown <kbrown@cornell.edu>
2471
2472 * gmalloc.c: Expand comment.
2473
b215eee5
EZ
24742011-08-16 Eli Zaretskii <eliz@gnu.org>
2475
2476 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2477 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2478
a4579d33
KB
24792011-08-16 Ken Brown <kbrown@cornell.edu>
2480
2481 Fix memory allocation problems in Cygwin build (Bug#9273).
2482
2483 * unexcw.c ( __malloc_initialized): Declare external variable.
2484 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2485
8b76d6f8
SM
2486 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2487 New variables.
a4579d33
KB
2488 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2489 dumped emacs.
2490 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2491 in the static heap.
2492 [CYGWIN] (special_realloc): New function.
2493 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2494 requests to realloc storage in the static heap.
2495
3ebec551
PE
24962011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2497
2498 * bidi.c (bidi_initialize): Remove unused local.
2499
9fd8be00
EZ
25002011-08-15 Eli Zaretskii <eliz@gnu.org>
2501
6b02f655
SM
2502 * bidimirror.h:
2503 * biditype.h: Remove file.
2504 * makefile.w32-in ($(BLD)/bidi.$(O)):
2505 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2506
2507 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2508
2509 * chartab.c: Improve commentary for the uniprop_table API.
2510
32413314
EZ
2511 * bidi.c (bidi_paragraph_init): Support zero value of
2512 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2513 (bidi_initialize): Use uniprop_table instead of including
2514 biditype.h and bidimirror.h.
32413314 2515
9fd8be00
EZ
2516 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2517 coordinates of the iterator when restoring from ppos_it.
2518 (Bug#9296)
2519
5cf2b69b
KH
25202011-08-14 Kenichi Handa <handa@m17n.org>
2521
2522 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2523 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2524
daf17d00
EZ
25252011-08-14 Eli Zaretskii <eliz@gnu.org>
2526
2527 * xdisp.c (move_it_in_display_line_to): Don't invoke
2528 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2529 ppos_it. Fixes vertical cursor motion when line beginning is
2530 covered by an image. (Bug#9296)
2531
08e3161a
JD
25322011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2533
2534 * nsterm.h (ns_run_ascript): Declare.
2535 (NSAPP_DATA2_RUNASSCRIPT): Define.
2536
2537 * nsfns.m (as_script, as_result, as_status): New static variables.
2538 (ns_run_ascript): New function.
5e617bc2 2539 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2540 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2541 the event loop. Get status from as_status (Bug#7276).
2542
2543 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2544 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2545 the event loop (Bug#7276).
2546
a3720aa2
AS
25472011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2548
2549 * gnutls.c (QCgnutls_bootprop_priority)
2550 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2551 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2552 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2553 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2554 (QCgnutls_bootprop_verify_hostname_error)
2555 (QCgnutls_bootprop_callbacks_verify): Rename from
2556 Qgnutls_bootprop_..., all uses changed.
2557
2558 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2559 uses changed.
2560
0a0d27fb
PE
25612011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2562
19d5c50c
PE
2563 * xfaces.c (Qframe_set_background_mode): Now static.
2564 * dispextern.h (Qframe_set_background_mode): Remove decl.
2565
0a0d27fb
PE
2566 * process.c (Fnetwork_interface_info): Declare local only if needed.
2567
377538cb
JD
25682011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2569
2570 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2571 (Fnetwork_interface_list): Allocate in increments of bytes instead
2572 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2573 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2574 sockaddr.
2575 (struct ifflag_def): notrailers is smart on OSX.
2576 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2577 Get hardware address with getifaddrs if available.
2578
08fff70c
EZ
25792011-08-12 Eli Zaretskii <eliz@gnu.org>
2580
2581 * xdisp.c (iterate_out_of_display_property): xassert that
2582 IT->position is set to within IT->object's boundaries. Break from
2583 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2584 when IT->position is set up wrongly due to some bug.
2585 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2586 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2587 entry. Force push_it to save on the stack the current
2588 buffer/string position, to be restored by pop_it. Fix flags in
2589 the iterator structure wrt the object coming from a display
2590 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2591 properties. (Bug#9284)
2592
7be1c708 25932011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2594
7be1c708
CY
2595 * fontset.c (fontset_get_font_group): Add proper type checks.
2596 (Bug#9172)
aac0c6e3 2597
7be1c708 25982011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2599
7be1c708
CY
2600 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2601 and LC_VERSION_MIN_MACOSX.
2602 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2603 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2604
97bb72a6
EZ
26052011-08-08 Eli Zaretskii <eliz@gnu.org>
2606
2607 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2608 no-display-properties-and-no-overlays under bidi display.
2609 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2610 properties and overlays.
97bb72a6 2611
d5617611
CY
26122011-08-08 Chong Yidong <cyd@stupidchicken.com>
2613
37e11a63
CY
2614 * editfns.c (Fset_time_zone_rule): Document relationship with the
2615 setenv function.
2616
d5617611
CY
2617 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2618 the font entity extracted from the cache (Bug#8109).
2619
58872834
CY
26202011-08-07 Chong Yidong <cyd@stupidchicken.com>
2621
2622 * composite.c (autocmp_chars): Don't reset point. That is done by
2623 restore_point_unwind (Bug#5984).
2624
75bfc667
JL
26252011-08-07 Juri Linkov <juri@jurta.org>
2626
2627 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2628 to show the arg `TIME' instead of `TIMEVAL'.
2629
d1410150
EZ
26302011-08-06 Eli Zaretskii <eliz@gnu.org>
2631
2632 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2633 display property strides EOL and includes a newline, as in
2634 longlines-mode. (Bug#9254)
75b771e4
EZ
2635 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2636 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2637
2638 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2639 is non-zero, even if the data buffer is NULL. Fixes a crash in
2640 vertical-motion with longlines-mode. (Bug#9254)
2641
35928349
EZ
26422011-08-05 Eli Zaretskii <eliz@gnu.org>
2643
ec7cc85b
EZ
2644 * bidi.c <bidi_cache_total_alloc>: Now static.
2645 (bidi_initialize): Initialize bidi_cache_total_alloc.
2646
8b76d6f8 2647 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2648 cache. (Bug#9221)
2649
2650 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2651 amount allocated this far in `bidi_cache_total_alloc'.
2652 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2653 non-zero, only free the data buffer without restoring the cache
2654 contents. All callers changed.
2655
2656 * dispextern.h (bidi_unshelve_cache): Update prototype.
2657
2658 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2659 (move_it_in_display_line, move_it_to)
2660 (move_it_vertically_backward, move_it_by_lines): Replace the call
2661 to xfree to an equivalent call to bidi_unshelve_cache.
2662 (move_it_in_display_line_to): Fix logic of returning
412b6358 2663 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2664
e2e2423b
EZ
26652011-08-05 Eli Zaretskii <eliz@gnu.org>
2666
2667 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2668 came from a string character with a `cursor' property. (Bug#9229)
2669
ae9e757a
JD
26702011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2671
2672 * Makefile.in (LIB_PTHREAD): New variable.
2673 (LIBES): Add LIB_PTHREAD (Bug#9216).
2674
2675 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2676 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2677
213bd7f2
AS
26782011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2679
6b02f655 2680 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2681
99aaf75f
JD
26822011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2683
2684 * xterm.c (x_find_topmost_parent): New function.
2685 (x_set_frame_alpha): Find topmost parent window with
2686 x_find_topmost_parent and set the property there also (bug#9181).
2687 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2688
c74e9d86
PE
26892011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2690
2691 * callproc.c (Fcall_process): Avoid vfork clobbering
2692 the local vars buffer, coding_systems, current_dir.
2693
640c8776
SM
26942011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2695
2696 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2697
f26d0e4c
PE
26982011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2699
8a10d76c
PE
2700 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2701 so that it is not optimized away.
2702
f26d0e4c
PE
2703 * xdisp.c (compute_display_string_pos): Remove unused local.
2704
55439c61
EZ
27052011-08-02 Eli Zaretskii <eliz@gnu.org>
2706
2707 Fix slow cursor motion and scrolling in large buffers with
2708 selective display, like Org Mode buffers. (Bug#9218)
2709
2710 * dispextern.h (struct bidi_it): New member disp_prop_p.
2711
2712 * xdisp.c: Remove one-slot cache of display string positions.
2713 (compute_display_string_pos): Accept an additional argument
5e617bc2 2714 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2715 for a display string or property. If found, set DISP_PROP_P
2716 non-zero.
2717
2718 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2719 DISP_PROP_P, and pass it to compute_display_string_pos.
2720 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2721 non-zero. All callers of bidi_fetch_char changed.
2722
fb33fa43
SM
27232011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2724
2725 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2726
b099e063
DM
27272010-12-03 Don March <don@ohspite.net>
2728
2729 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2730 last character M-[char] is translated to ESC [char] (bug#7541).
2731
5cc7f7af
KH
27322011-08-02 Kenichi Handa <handa@m17n.org>
2733
d0fffa3f 2734 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2735
2736 * chartab.c (uniprop_table): Make it non-static.
2737
525d5e6e
EZ
27382011-08-01 Eli Zaretskii <eliz@gnu.org>
2739
2740 * xdisp.c (forward_to_next_line_start): Accept additional argument
2741 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2742 on the newline.
2743 (reseat_at_next_visible_line_start): Use the bidi iterator state
2744 returned by forward_to_next_line_start to restore the state of
2745 it->bidi_it after backing up to previous newline. (Bug#9212)
2746
31011111
AS
27472011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2748
2749 * regex.c (re_comp): Protoize.
2750 (re_exec): Fix return type.
2751 (regexec): Fix type of `ret'. (Bug#9203)
2752
476371c4
PE
27532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2754
e5d76069
PE
2755 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2756 This is needed if max-image-size is a floating-point number.
2757
9a79b20c
AS
27582011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2759
2760 * print.c (print_object): Print empty symbol as ##.
2761
2762 * lread.c (read1): Read ## as empty symbol.
2763
d8c2fa78
AA
27642011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2765
2766 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2767 setting frame foreground color (Bug#9175).
2768 (x_set_background_color): Likewise.
2769
ffe57a7a
AA
2770 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2771 contents (Bug#9176).
2772 (EmacsTooltip -init): Remove bezels and add shadows to
2773 tooltip windows.
2774
bf3492a5
AA
2775 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2776 or scroll bar (Bug#8470).
2777
d55e9c53
AA
2778 * nsfont.m (nsfont_open): Remove assignment to voffset and
2779 unnecessary vars hshink, expand, hd, full_height, min_height.
2780 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2781
2782 * nsterm.h (nsfont_info): Remove voffset field.
2783
d8c2fa78 27842011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2785
2786 Implement strike-through and overline on NextStep (Bug#8863).
2787
2788 * nsfont.m (nsfont_open): Use underline position provided by font,
2789 instead of hard-coded value of 2.
2790 (nsfont_draw): Call ns_draw_text_decoration instead.
2791
2792 * nsterm.h: Add declaration for ns_draw_text_decoration.
2793
2794 * nsterm.m (ns_draw_text_decoration): New function for drawing
2795 underline, overline, and strike-through.
2796 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2797 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2798 accommodate underlining, etc.
4843aac3 2799
4cc60b9b
EZ
28002011-07-28 Eli Zaretskii <eliz@gnu.org>
2801
bc7ece87
EZ
2802 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2803 default.
4cc60b9b 2804
476371c4
PE
28052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2806
66606eea
PE
2807 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2808 Without this fix, if a signal arrives just after memory fills up,
2809 'malloc' might be invoked reentrantly.
2810
476371c4
PE
2811 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2812 In other words, assume that every image size is allowed, on non-X
2813 hosts. This assumption is probably wrong, but it lets Emacs compile.
2814
f3fcc40d
AS
28152011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2816
2817 * regex.c (re_iswctype): Convert return values to boolean.
2818
350c992f
EZ
28192011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2820
2821 * xdisp.c (compute_display_string_pos): Don't use cached display
2822 string position if the buffer had its restriction changed.
2823 (Bug#9184)
2824
5266b4bb
PE
28252011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2826
2827 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2828
2573a837 28292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2830
41f55ccd 2831 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2832
39e378da
PE
2833 * bidi.c: Integer size and overflow fixes.
2834 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2835 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2836 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2837 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2838 (bidi_find_other_level_edge):
2839 Use ptrdiff_t instead of EMACS_INT where either will do.
2840 This works better on 32-bit hosts configured --with-wide-int.
2841 (bidi_cache_ensure_space): Check for size-calculation overflow.
2842 Use % rather than repeated addition, for better worst-case speed.
2843 Don't set bidi_cache_size until after xrealloc returns, because it
2844 might not return.
2845 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2846 (bidi_cache_ensure_space): Also check that the bidi cache size
2847 does not exceed that of the largest Lisp string or buffer. See Eli
2848 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2849
5e927815
PE
2850 * alloc.c (__malloc_size_t): Remove.
2851 All uses replaced by size_t. See Andreas Schwab's note
2852 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2853
ca4aa935
PE
2854 * image.c: Improve checking for integer overflow.
2855 (check_image_size): Assume that f is nonnull, since
2856 it is always nonnull in practice. This is one less thing to
2857 worry about when checking for integer overflow later.
2858 (x_check_image_size): New function, which checks for integer
2859 overflow issues inside X.
2860 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2861 This removes the need for a memory_full check.
2862 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2863 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2864 (xbm_read_bitmap_data): Change locals back to 'int', since
2865 their values must fit in 'int'.
2866 (xpm_load_image, png_load, tiff_load):
2867 Invoke x_create_x_image_and_pixmap earlier,
2868 to avoid much needless work if the image is too large.
2869 (tiff_load): Treat overly large images as if
2870 x_create_x_image_and_pixmap failed, not as malloc failures.
2871 (gs_load): Use x_check_image_size.
2872
5f8f9cc2
PE
2873 * gtkutil.c: Omit integer casts.
2874 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2875 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2876
5adf60bc
PE
2877 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2878
c8907a93
PE
2879 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2880 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2881 would wrongly return t on a 64-bit host.
2882
e3c25c68
PE
2883 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2884 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2885 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2886 and therefore cause GCC to emit a bogus diagnostic in some cases.
2887
3f791afe
PE
2888 * image.c: Integer signedness and overflow and related fixes.
2889 This is not an exhaustive set of fixes, but it's time to
2890 record what I've got.
2891 (lookup_pixel_color, check_image_size): Remove redundant decls.
2892 (check_image_size): Don't assume that arbitrary EMACS_INT values
2893 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2894 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2895 (tiff_load, imagemagick_load_image):
2896 Check for overflow in size calculations.
2897 (x_create_x_image_and_pixmap): Remove unnecessary test for
2898 xmalloc returning NULL; that can't happen.
2899 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2900 (xpm_color_bucket): Use better integer hashing function.
2901 (xpm_cache_color): Don't possibly over-allocate memory.
2902 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2903 (gif_memory_source):
2904 Use ptrdiff_t, not int or size_t, to record sizes.
2905 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2906 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2907 either works, as we prefer signed integers.
2908 (tiff_read_from_memory, tiff_write_from_memory):
2909 Return tsize_t, not size_t, since that's what the TIFF API wants.
2910 (tiff_read_from_memory): Don't fail simply because the read would
2911 go past EOF; instead, return a short read.
2912 (tiff_load): Omit no-longer-needed casts.
2913 (Fimagemagick_types): Don't assume size fits into 'int'.
2914
3cc5a532
PE
2915 Improve hashing quality when configured --with-wide-int.
2916 * fns.c (hash_string): New function, taken from sxhash_string.
2917 Do not discard information about ASCII character case; this
2918 discarding is no longer needed.
2919 (sxhash-string): Use it. Change sig to match it. Caller changed.
2920 * lisp.h: Declare it.
2921 * lread.c (hash_string): Remove, since we now use fns.c's version.
2922 The fns.c version returns a wider integer if --with-wide-int is
2923 specified, so this should help the quality of the hashing a bit.
2924
b312a492
PE
2925 * emacs.c: Integer overflow minor fix.
2926 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2927 Define only if GNU_LINUX.
2928 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2929
dfd153ae
PE
2930 * dispnew.c: Integer signedness and overflow fixes.
2931 Remove unnecessary forward decls, that were a maintenance hassle.
2932 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2933 All uses changed.
2934 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2935 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2936 (prepare_desired_row, line_draw_cost):
2937 Use int, not unsigned, where either works.
2938 (save_current_matrix, restore_current_matrix):
2939 Use ptrdiff_t, not size_t, where either works.
2940 (init_display): Check for overflow more accurately, and without
2941 relying on undefined behavior.
2942
a81d11a3
PE
2943 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2944 Remove, replacing with the new symbols in lisp.h. All uses changed.
2945 * fileio.c (make_temp_name):
2946 * filelock.c (lock_file_1, lock_file):
2947 * xdisp.c (message_dolog):
2948 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2949 Use pMd etc. instead.
2950 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2951 replacing the pWIDE etc. symbols removed from editfns.c.
2952
3300e6fd
PE
2953 * keyboard.h (num_input_events): Now uintmax_t.
2954 This is (very slightly) less likely to mess up due to wraparound.
2955 All uses changed.
2956
fd05c7e9
PE
2957 * buffer.c: Integer signedness fixes.
2958 (alloc_buffer_text, enlarge_buffer_text):
2959 Use ptrdiff_t rather than size_t when either will do, as we prefer
2960 signed integers.
2961
903fe15d
PE
2962 * alloc.c: Integer signedness and overflow fixes.
2963 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2964 (__malloc_size_t): Default to size_t, not to int.
2965 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2966 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2967 Prefer ptrdiff_t to size_t when either would do, as we prefer
2968 signed integers.
2969 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2970 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2971 Now const. Initialize with values that are in range even if char
2972 is signed.
2973 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2974 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2975 These functions do the right thing with sizes > 2**32.
2976 (check_depth): Now ptrdiff_t, not int.
2977 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2978 Adjust to new way of storing sizes. Check for size overflow bugs
2979 in rest of code.
2980 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2981 slightly wrong anyway, as it missed one instance of
2982 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2983 (refill_memory_reserve): Omit needless cast to size_t.
2984 (mark_object_loop_halt): Mark as externally visible.
2985
ac82cc6a
PE
2986 * xselect.c: Integer signedness and overflow fixes.
2987 (Fx_register_dnd_atom, x_handle_dnd_message):
2988 Use ptrdiff_t, not size_t, since we prefer signed.
2989 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2990 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2991 x_dnd_atoms_size and x_dnd_atoms_length.
2992
c2d1e36d
PE
2993 * doprnt.c: Prefer signed to unsigned when either works.
2994 * eval.c (verror):
2995 * doprnt.c (doprnt):
2996 * lisp.h (doprnt):
2997 * xdisp.c (vmessage):
2998 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2999 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3000 prefer signed arithmetic to avoid comparison confusion.
3001 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3002 but is a bit tricky.
3003
0e926e56
PE
3004 Assume freestanding C89 headers, string.h, stdlib.h.
3005 * data.c, doprnt.c, floatfns.c, print.c:
3006 Include float.h unconditionally.
3007 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3008 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3009 * regex.c: Likewise for stddef.h, string.h.
3010 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3011 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3012 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3013 (STDC_HEADERS): Remove obsolete defines.
3014 * sysdep.c: Include limits.h unconditionally.
3015
9cfdb3ec
PE
3016 Assume support for memcmp, memcpy, memmove, memset.
3017 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3018 * regex.c (memcmp, memcpy):
3019 Remove; we assume C89 now.
3020
3021 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3022 (__malloc_safe_bcopy): Remove; no longer needed.
3023
cf950e6b 3024 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3025 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3026 well either way, and we prefer signed to unsigned.
3027
dbf38e02
LMI
30282011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3029
3030 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3031 closes the connection while we're reading (bug#9182).
3032
d6f0886c 30332011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3034
d6f0886c
JD
3035 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3036 are specified (Bug#9168).
24e0f6b1 3037
2eb1f9e6
PE
30382011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3039
3040 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3041 Found by GCC static checking and --with-wide-int on a 32-bit host.
3042
22381272 30432011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3044
3045 * xdisp.c (compute_display_string_pos): Fix logic of caching
3046 previous display string position. Initialize cached_prev_pos to
3047 -1. Fixes slow-down at the beginning of a buffer.
3048
f25e39b4
EZ
30492011-07-24 Eli Zaretskii <eliz@gnu.org>
3050
3051 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3052 for attrs[LFACE_FONTSET_INDEX].
3053
04c4b52e
PE
30542011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3055
3056 * xml.c (parse_region): Remove unused local
3057 that was recently introduced.
3058
c1734fbd
EZ
30592011-07-23 Eli Zaretskii <eliz@gnu.org>
3060
be18c5a5
EZ
3061 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3062 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3063
c1734fbd
EZ
3064 * xdisp.c (move_it_in_display_line_to): Record the best matching
3065 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3066 exit if none of the characters scanned was an exact match.
3067 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3068 when exact match is impossible due to invisible text, and the
3069 lines are truncated.
3070
a258d627
JD
30712011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3072
3073 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3074 for OSX >= 10.7.
3075
b6d5a689
EZ
30762011-07-22 Eli Zaretskii <eliz@gnu.org>
3077
0f74f785
EZ
3078 Fix a significant slow-down of cursor motion with C-n, C-p,
3079 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3080 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3081 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3082 (next_element_from_buffer): Call compute_stop_pos_backwards to
3083 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3084 base_level_stop.
3085 (reseat): Don't look for prev_stop, as that could mean a very long
3086 run.
3087 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3088 <cached_disp_overlay_modiff>: Cache for last found display string
3089 position.
551918c1 3090 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3091 about the same buffer in the same area of character positions, and
3092 the buffer wasn't changed since the time the display string
3093 position was cached.
551918c1 3094
b2d0c91a
EZ
30952011-07-22 Eli Zaretskii <eliz@gnu.org>
3096
3097 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3098 is an integer, which is important for empty lines. (Bug#9149)
3099
043604ee
CY
31002011-07-22 Chong Yidong <cyd@stupidchicken.com>
3101
3102 * frame.c (Fmodify_frame_parameters): In tty case, update the
3103 default face if necessary (Bug#4238).
3104
da4adb04
CY
31052011-07-21 Chong Yidong <cyd@stupidchicken.com>
3106
3107 * editfns.c (Fstring_to_char): No need to explain what a character
3108 is in the docstring (Bug#6576).
3109
9abd0532
LMI
31102011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3111
3112 * xml.c (parse_region): Make sure we always return a tree.
3113
36881d16
HK
31142011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3115
3116 * xml.c (parse_region): If a document contains only comments,
3117 return that, too.
3118
1e98674d
LMI
31192011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3120
3121 * xml.c (make_dom): Return comments, too.
3122
590bd467
PE
31232011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3124
3125 Port to OpenBSD.
3126 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3127 and the surrounding thread.
3128 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3129 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3130 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3131 timer goes off.
3132 * s/openbsd.h (BROKEN_SIGIO): Define.
3133 * unexelf.c (unexec) [__OpenBSD__]:
3134 Don't update the .mdebug section of the Alpha COFF symbol table.
3135
f41628b2
LMI
31362011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3137
3138 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3139 (bug#8460).
3140
b59b67c5
PE
31412011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3142
15e3a074
PE
3143 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3144 This fixes some race conditions on the permissions of any newly
3145 created file.
3146
41bed37d
PE
3147 * alloc.c (valid_pointer_p): Use pipe, not open.
3148 This fixes some permissions issues when debugging.
3149
b59b67c5
PE
3150 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3151 If fchown fails to set both uid and gid, try to set just gid,
3152 as that is sometimes allowed. Adjust the file's mode to eliminate
3153 setuid or setgid bits that are inappropriate if fchown fails.
3154
925a6be7
SM
31552011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3156
3157 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3158 to compare Lisp_Objects.
3159 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3160 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3161 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3162
52968808
AS
31632011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3164
0a6a104b
AS
3165 * lread.c (read_integer): Unread even EOF character.
3166 (read1): Likewise. Properly record start position of symbol.
3167
52968808
AS
3168 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3169 symbol character follows.
3170
9e381cdd
PE
31712011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3172
3173 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3174 This works around a problem with the previous change to Fcopy_file.
3175 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3176 and without this change, GCC might complain about discarding
3177 fchown's return value.
3178
b5641435
JB
31792011-07-16 Juanma Barranquero <lekktu@gmail.com>
3180
3181 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3182
a8031457
PE
31832011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3186
dd889327
LMI
31872011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3188
750c33f7
LMI
3189 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3190 it's used from the C level.
3191
dd889327
LMI
3192 * process.c: Use the same condition for POLL_FOR_INPUT in both
3193 keyboard.c and process.c (bug#1858).
3194
87e86684
LM
31952011-07-09 Lawrence Mitchell <wence@gmx.li>
3196
3197 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3198 (Fgnutls_boot): Use it.
3199
64348f40
AS
32002011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3201
3202 * doc.c (Fsubstitute_command_keys): Revert last change.
3203
1d698799
LMI
32042011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3205
f863868c
LMI
3206 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3207 quotes the next character, and doesn't affect other longer
3208 sequences (bug#8935).
3209
1d698799
LMI
3210 * lread.c (syms_of_lread): Clarify that is isn't only
3211 `eval-buffer' and `eval-defun' that's affected by
3212 `lexical-binding' (bug#8460).
3213
aa4b6df6
EZ
32142011-07-15 Eli Zaretskii <eliz@gnu.org>
3215
3216 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3217 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3218
5d856da6
PE
32192011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3220
ad6042bb
PE
3221 Fix minor problems found by static checking.
3222 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3223 (elsz): Now a signed constant, not a size_t var. We prefer signed
3224 types to unsigned, to avoid integer comparison confusion. Without
3225 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3226 "cannot optimize loop, the loop counter may overflow", a symptom
3227 of the confusion.
f00bbb22 3228 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3229 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3230
6468f31c
LMI
32312011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3232
49080b10
LMI
3233 * search.c (Fre_search_backward): Mention `case-fold-search' in
3234 all the re_search_* functions (bug#8138).
3235
6468f31c
LMI
3236 * keyboard.c (Fopen_dribble_file): Document when the file is
3237 closed (bug#8056).
3238
c965adc5
EZ
32392011-07-14 Eli Zaretskii <eliz@gnu.org>
3240
df9733bf
EZ
3241 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3242 bidi_cache_idx.
3243
0bb23927
EZ
3244 Support bidi reordering of display and overlay strings.
3245 * xdisp.c (compute_display_string_pos)
3246 (compute_display_string_end): Accept additional argument STRING.
3247 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3248 (reseat_to_string): Initialize bidi_it->string.s and
3249 bidi_it->string.schars.
3250 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3251 NULL (avoids a crash in bidi_paragraph_init).
3252 Initialize itb.string.lstring.
0bb23927
EZ
3253 (init_iterator): Call bidi_init_it only of a valid
3254 buffer position was specified. Initialize paragraph_embedding to
3255 L2R.
3256 (reseat_to_string): Initialize the bidi iterator.
3257 (display_string): If we need to ignore text properties of
3258 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3259 original value of -1 will not work with bidi.)
3260 (compute_display_string_pos): First arg is now struct
3261 `text_pos *'; all callers changed. Support display properties on
3262 Lisp strings.
3263 (compute_display_string_end): Support display properties on Lisp
3264 strings.
3265 (init_iterator, reseat_1, reseat_to_string): Initialize the
3266 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3267 when iterating on a string not from display properties).
640c8776
SM
3268 (compute_display_string_pos, compute_display_string_end):
3269 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3270 arrow keys.
3271 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3272 base_level_stop; instead, set base_level_stop to BEGV.
3273 Fixes crashes in vertical-motion.
0bb23927
EZ
3274 (next_element_from_buffer): Improve commentary for when
3275 the iterator is before prev_stop.
3276 (init_iterator): Initialize bidi_p from the default value of
3277 bidi-display-reordering, not from buffer-local value. Use the
3278 buffer-local value only if initializing for buffer iteration.
3279 (handle_invisible_prop): Support invisible properties on strings
3280 that are being bidi-reordered.
3281 (set_iterator_to_next): Support bidi reordering of C strings and
3282 Lisp strings.
3283 (next_element_from_string): Support bidi reordering of Lisp
3284 strings.
3285 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3286 (display_string): Support display of R2L glyph rows.
3287 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3288 (init_iterator): Don't initialize it->bidi_p for strings
3289 here.
3290 (reseat_to_string): Initialize it->bidi_p for strings here.
3291 (next_element_from_string, next_element_from_c_string)
3292 (next_element_from_buffer): Add xassert's for correspondence
3293 between IT's object being iterated and it->bidi_it.string
3294 structure.
3295 (face_before_or_after_it_pos): Support bidi iteration.
3296 (next_element_from_c_string): Handle the case of the first string
3297 character that is not the first one in the visual order.
3298 (get_visually_first_element): New function, refactored from common
3299 parts of next_element_from_buffer, next_element_from_string, and
3300 next_element_from_c_string.
3301 (tool_bar_lines_needed, redisplay_tool_bar)
3302 (display_menu_bar): Force left-to-right direction. Add a FIXME
3303 comment for making that be controlled by a user option.
3304 (push_it, pop_it): Save and restore the state of the
3305 bidi iterator. Save and restore the bidi_p flag.
3306 (pop_it): Iterate out of display property for string iteration as
3307 well.
3308 (iterate_out_of_display_property): Support iteration over strings.
3309 (handle_single_display_spec): Set up it->bidi_it for iteration
3310 over a display string, and call bidi_init_it.
3311 (handle_single_display_spec, next_overlay_string)
3312 (get_overlay_strings_1, push_display_prop): Set up the bidi
3313 iterator for displaying display or overlay strings.
3314 (forward_to_next_line_start): Don't use the shortcut if
3315 bidi-iterating.
3316 (back_to_previous_visible_line_start): If handle_display_prop
3317 pushed the iterator stack, restore the internal state of the bidi
3318 iterator by calling bidi_pop_it same number of times.
3319 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3320 and we are bidi-iterating, don't decrement the iterator position;
3321 instead, set the first_elt flag in the bidi iterator, to produce
3322 the same effect.
3323 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3324 (push_display_prop): xassert that we are iterating a buffer.
3325 (push_it, pop_it): Save and restore paragraph_embedding member.
3326 (handle_single_display_spec, next_overlay_string)
3327 (get_overlay_strings_1, reseat_1, reseat_to_string)
3328 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3329 correctly. Don't assume unibyte strings are not bidi-reordered.
3330 (compute_display_string_pos)
3331 (compute_display_string_end): Fix handling the case of C string.
3332 (push_it, pop_it): Save and restore from_disp_prop_p.
3333 (handle_single_display_spec, push_display_prop): Set the
3334 from_disp_prop_p flag.
3335 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3336 (pop_it): Call iterate_out_of_display_property only if we are
3337 popping after iteration over a string that came from a display
3338 property. Fix a typo in popping stretch info. Add an assertion
3339 for verifying that the iterator position is in sync with the bidi
3340 iterator.
3341 (handle_single_display_spec, get_overlay_strings_1)
3342 (push_display_prop): Fix initialization of paragraph direction for
3343 string when that of the parent object is not yet determined.
3344 (reseat_1): Call bidi_init_it to resync the bidi
3345 iterator with IT's position. (Bug#7616)
3346 (find_row_edges): If ROW->start.pos gives position
3347 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3348 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3349 Reset the from_disp_prop_p flag.
3350 (SAVE_IT, RESTORE_IT): New macros.
3351 (pos_visible_p, face_before_or_after_it_pos)
3352 (back_to_previous_visible_line_start)
3353 (move_it_in_display_line_to, move_it_in_display_line)
3354 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3355 (try_scrolling, redisplay_window, display_line): Use them when
3356 saving a temporary copy of the iterator and restoring it back.
3357 (back_to_previous_visible_line_start, reseat_1)
3358 (init_iterator): Empty the bidi cache "stack".
3359 (move_it_in_display_line_to): If iterator ended up at
3360 EOL, but we never saw any buffer positions smaller than
3361 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3362 motion in bidi-reordered lines.
3363 (move_it_in_display_line_to): Record prev_method and prev_pos
3364 immediately before the call to set_iterator_to_next. Fixes cursor
3365 motion in bidi-reordered lines with stretch glyphs and strings
3366 displayed in margins. (Bug#8133) (Bug#8867)
3367 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3368 TO_CHARPOS.
640c8776
SM
3369 (pos_visible_p): Support positions in bidi-reordered lines.
3370 Save and restore bidi cache.
0bb23927
EZ
3371
3372 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3373 (bidi_paragraph_info): Delete unused struct.
3374 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3375 (bidi_cache_start): New variable.
3376 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3377 to zero.
3378 (bidi_cache_fetch_state, bidi_cache_search)
3379 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3380 (bidi_cache_find, bidi_peek_at_next_level)
3381 (bidi_level_of_next_char, bidi_find_other_level_edge)
3382 (bidi_move_to_visually_next): Compare cache index with
3383 bidi_cache_start rather than with zero.
3384 (bidi_fetch_char): Accept new argument STRING; all callers
3385 changed. Support iteration over a string. Support strings with
3386 display properties. Support unibyte strings. Fix the type of
3387 `len' according to what STRING_CHAR_AND_LENGTH expects.
3388 (bidi_paragraph_init, bidi_resolve_explicit_1)
3389 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3390 (bidi_level_of_next_char, bidi_move_to_visually_next):
3391 Support iteration over a string.
0bb23927
EZ
3392 (bidi_set_sor_type, bidi_resolve_explicit_1)
3393 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3394 can now be zero (for strings); special values 0 and -1 were
3395 changed to -1 and -2, respectively.
3396 (bidi_char_at_pos): New function.
3397 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3398 Call it instead of FETCH_MULTIBYTE_CHAR.
3399 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3400 initialized to valid values.
3401 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3402 values.
3403 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3404 the test for valid cached positions. Fix the logic for looking up
3405 the sentinel state in the cache. GCPRO the Lisp string we are
3406 iterating.
3407 (bidi_push_it, bidi_pop_it): New functions.
3408 (bidi_initialize): Initialize the bidi cache start stack pointer.
3409 (bidi_cache_ensure_space): New function, refactored from part of
3410 bidi_cache_iterator_state. Don't assume the required size is just
3411 one BIDI_CACHE_CHUNK away.
3412 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3413 (bidi_count_bytes, bidi_char_at_pos): New functions.
3414 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3415 always valid if bidi_cache_idx is valid.
3416 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3417 is valid if it's going to be used.
3418 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3419 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3420 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3421 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3422 (bidi_find_other_level_edge, bidi_cache_start_stack):
3423 All variables related to cache indices are now EMACS_INT.
c965adc5 3424
0bb23927
EZ
3425 * dispextern.h (struct bidi_string_data): New structure.
3426 (struct bidi_it): New member `string'. Make flag members be 1-bit
3427 fields, and put them last in the struct.
640c8776
SM
3428 (compute_display_string_pos, compute_display_string_end):
3429 Update prototypes.
0bb23927
EZ
3430 (bidi_push_it, bidi_pop_it): Add prototypes.
3431 (struct iterator_stack_entry): New members bidi_p,
3432 paragraph_embedding, and from_disp_prop_p.
3433 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3434 (bidi_shelve_cache, bidi_unshelve_cache):
3435 Declare prototypes.
0bb23927
EZ
3436
3437 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3438 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3439 and vector-like objects.
3440
3441 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3442 cache around display iteration.
3443
3444 * window.c (Fwindow_end, window_scroll_pixel_based)
3445 (displayed_window_lines, Frecenter): Save and restore the bidi
3446 cache around display iteration.
3447
3bbd2265
LMI
34482011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3449
3450 * editfns.c (Fdelete_region): Clarify the use of the named
3451 parameters (bug#6788).
3452
adc47434
MR
34532011-07-14 Martin Rudalics <rudalics@gmx.at>
3454
3455 * indent.c (Fvertical_motion): Set and restore w->pointm when
3456 saving and restoring the window's buffer (Bug#9006).
3457
837c31f8
LMI
34582011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3459
3460 * editfns.c (Fstring_to_char): Clarify just what is returned
3461 (bug#6576). Text by Eli Zaretskii.
3462
ac389d0c
JB
34632011-07-13 Juanma Barranquero <lekktu@gmail.com>
3464
3465 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3466
0be0ce47
EZ
34672011-07-13 Eli Zaretskii <eliz@gnu.org>
3468
3469 * buffer.c (mmap_find): Fix a typo.
3470
cd18e7e3
JB
34712011-07-13 Johan Bockgård <bojohan@gnu.org>
3472
3473 Fix execution of x selection hooks.
3474 * xselect.c (Qx_lost_selection_functions)
3475 (Qx_sent_selection_functions): New vars.
3476 (syms_of_xselect): DEFSYM them.
3477 (x_handle_selection_request): Pass Qx_sent_selection_functions
3478 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3479 (x_handle_selection_clear,x_clear_frame_selections):
3480 Pass Qx_lost_selection_functions rather than
3481 Vx_lost_selection_functions to Frun_hook_with_args.
3482
47ea7f44
PE
34832011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3484
ac389d0c 3485 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3486 The old code sometimes used this field without initializing it.
3487
47ea7f44
PE
3488 * alloc.c (gc_sweep): Don't read past end of array.
3489 In theory, the old code could also have corrupted Emacs internals,
3490 though it'd be very unlikely.
3491
bc985c87
AS
34922011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3493
3494 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3495 argument. (Bug#4026)
bc985c87 3496
0cf34688
LMI
34972011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3498
b3dadd76
LMI
3499 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3500 key" (bug#4257).
3501
0cf34688
LMI
3502 * window.c (Fset_window_start): Doc fix (bug#4199).
3503 (Fset_window_hscroll): Ditto.
3504
270768cd
PE
35052011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3506
077e3dda 3507 Fix minor new problems caught by GCC 4.6.1.
270768cd 3508 * term.c (init_tty): Remove unused local.
490011a6 3509 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3510 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3511 not used otherwise.
270768cd 3512
b1f58454
CY
35132011-07-12 Chong Yidong <cyd@stupidchicken.com>
3514
3515 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3516
22b9578d
LMI
35172011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3518
6e70ab07
LMI
3519 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3520 are the mini-buffer and the echo area (bug#3320).
3521
22b9578d
LMI
3522 * term.c (init_tty): Remove support for supdup, c10 and perq
3523 terminals, which are no longer supported (bug#1482).
3524
8974cc9f
JB
35252011-07-10 Johan Bockgård <bojohan@gnu.org>
3526
3527 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3528
a560d974
JD
35292011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3530
3531 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3532 for non-popups (Bug#3642).
3533
1dae0f0a
AS
35342011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3535
268c2c36 3536 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3537 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3538 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3539 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3540 * data.c (fmod): Likewise.
3541 * dispnew.c (swap_glyphs_in_rows): Likewise.
3542 * emacs.c (memory_warning_signal): Likewise.
3543 * floatfns.c (float_error): Likewise.
3544 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3545 (otf_open, font_otf_capability, generate_otf_features)
3546 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3547 Likewise.
3548 * image.c (pbm_read_file): Likewise.
3549 * indent.c (string_display_width): Likewise.
3550 * intervals.c (check_for_interval, search_for_interval)
3551 (inc_interval_count, count_intervals, root_interval)
3552 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3553 * lread.c (defalias): Likewise.
268c2c36 3554 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3555 * regex.c (set_image_of_range_1, set_image_of_range)
3556 (regex_grow_registers): Likewise.
3557 * sysdep.c (strerror): Likewise.
3558 * termcap.c (valid_filename_p, tprint, main): Likewise.
3559 * tparam.c (main): Likewise.
3560 * unexhp9k800.c (run_time_remap, save_data_space)
3561 (update_file_ptrs, read_header, write_header, calculate_checksum)
3562 (copy_file, copy_rest, display_header): Likewise.
3563 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3564 Likewise.
3565 * xdisp.c (check_it): Likewise.
3566 * xfaces.c (register_color, unregister_color, unregister_colors):
3567 Likewise.
3568 * xfns.c (print_fontset_result): Likewise.
3569 * xrdb.c (member, fatal, main): Likewise.
3570
99033785
PE
35712011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3572
3573 Fix minor problems found by static checking (Bug#9031).
3574 * chartab.c (char_table_set_range, map_sub_char_table):
3575 Remove unused locals.
3576 (uniprop_table): Now static.
3577 * composite.c (_work_char): Remove unused static var.
3578
9cb2ac56
JB
35792011-07-09 Juanma Barranquero <lekktu@gmail.com>
3580
3581 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3582
f25661f0
JD
35832011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3584
3585 * gtkutil.c (qttip_cb): Remove code without function.
3586
8278c4fe
EZ
35872011-07-09 Eli Zaretskii <eliz@gnu.org>
3588
3589 * w32.c (pthread_sigmask): New stub.
3590
1692ae2d 35912011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3592
8a6ebd58 3593 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3594 sigprocmask is portable only for single-threaded applications, and
3595 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3596 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3597 (LIBES): Use it.
3598 * callproc.c (Fcall_process):
3599 * process.c (create_process):
3600 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3601 Use pthread_sigmask, not sigprocmask.
123403e4 3602
1b854618
JD
36032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3604
3605 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3606 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3607 wrong (Bug#8591).
3608
3fe4b549
JD
36092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3610
0ce7e563
JD
3611 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3612 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3613 (xg_hide_tooltip): Fix comment.
3614
3fe4b549
JD
3615 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3616 in registerServicesMenuSendTypes.
3617 (validRequestorForSendType): Don't check ns_return_types.
3618
3619 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3620 ns_return_type.
3621
5df75e47
JR
36222011-07-08 Jason Rumney <jasonr@gnu.org>
3623
22610910
JR
3624 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3625 SH_SHOW for hidden windows (Bug#5482).
3626
5df75e47
JR
3627 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3628 frame struct members of non-existent frames (Bug#6284).
3629
699c10bd
JD
36302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3631
4393663b
JD
3632 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3633 variable firstTime not needed on OSX >= 10.6.
3634 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3635 >= 10.5. Use setKnobProportion, setDoubleValue.
3636
3637 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3638 (MAC_OS_X_VERSION_10_5): Define if not defined.
3639 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3640 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3641 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3642
3643 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3644 cString and lossyCString on OSX >= 10.4
3645
58179cce 3646 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3647 sizeToFit on OSX >= 10.2.
3648
3649 * nsimage.m (allocInitFromFile): Don't use deprecated method
3650 bestRepresentationForDevice on OSX >= 10.6.
3651
3652 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3653 to avoid warning.
3654
3655 * emacs.c: Declare unexec_init_emacs_zone.
3656
a63e0781
JD
3657 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3658
699c10bd
JD
3659 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3660
3661 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3662 on svcsMenu (Bug#8842).
3663
3664 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3665 ns_return_types.
3666 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3667
3668 * nsterm.m (QUTF8_STRING): Declare.
3669 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3670 (validRequestorForSendType): Return type is (id).
3671 Change indexOfObjectIdenticalTo to indexOfObject.
3672 Check if we have local selection before returning self (Bug#8842).
3673 (writeSelectionToPasteboard): Put local selection into paste board
3674 if we have a local selection (Bug#8842).
3675 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3676
3677 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3678 (ns_get_local_selection): Declare.
3679
54e10184
LMI
36802011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3681
9888ff71
LMI
3682 * keymap.c (describe_map_tree): Don't insert a double newline at
3683 the end of the buffer (bug#1169) and return whether we inserted
3684 something.
3685
54e10184
LMI
3686 * callint.c (Fcall_interactively): Change "reading args" to
3687 "providing args" to try to clarify what it does (bug#1010).
3688
15fa4783
KH
36892011-07-07 Kenichi Handa <handa@m17n.org>
3690
3691 * composite.c (composition_compute_stop_pos): Ignore a static
3692 composition starting before CHARPOS (Bug#8915).
3693
3694 * xdisp.c (handle_composition_prop): Likewise.
3695
a8815b00
EZ
36962011-07-07 Eli Zaretskii <eliz@gnu.org>
3697
3698 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3699 (Bug#9015)
3700
ef7b981d 37012011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3702
3703 * character.h (unicode_category_t): New enum type.
3704
3705 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3706 (Qchar_code_property_table): New variable.
3707 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3708 (UNIPROP_COMPRESSED_FORM_P): New macros.
3709 (char_table_ascii): Uncompress the compressed values.
3710 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3711 Uncompress the compressed values.
ac389d0c 3712 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3713 (char_table_ref_and_range): Uncompress the compressed values.
3714 (sub_char_table_set): New arg is_uniprop. Callers changed.
3715 Uncompress the compressed values.
3716 (sub_char_table_set_range): Args changed. Callers changed.
3717 (char_table_set_range): Adjuted for the above change.
3718 (map_sub_char_table): Delete args default_val and parent. Add arg
3719 top. Give decoded values to a Lisp function.
640c8776 3720 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3721 values to a Lisp function. Gcpro more variables.
3722 (uniprop_table_uncompress)
3723 (uniprop_decode_value_run_length): New functions.
3724 (uniprop_decoder, uniprop_decoder_count): New variables.
3725 (uniprop_get_decoder, uniprop_encode_value_character)
3726 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3727 New functions.
3728 (uniprop_encoder, uniprop_encoder_count): New variables.
3729 (uniprop_get_encoder, uniprop_table)
3730 (Funicode_property_table_internal, Fget_unicode_property_internal)
3731 (Fput_unicode_property_internal): New functions.
3732 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3733 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3734 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3735 char-code-property-alist.
3736
640c8776 3737 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3738 Vunicode_category_table.
3739
640c8776 3740 * font.c (font_range): Adjust for the change of
c805dec0
KH
3741 Vunicode_category_table.
3742
76b397fb
DN
37432011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3744
3745 * m/iris4d.h: Remove file, move contents ...
3746 * s/irix6-5.h: ... here.
3747
22b4128e
PE
37482011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3749
3750 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3751 * alloc.c (mark_buffer):
3752 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3753 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3754 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3755 This isn't true in general, and it's particularly not true
3756 if Emacs is configured with --with-wide-int.
3757 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3758 New macros, used in the buffer.c change.
3759
869795d6
JD
37602011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3761
3762 * xsettings.c: Use both GConf and GSettings if both are available.
3763 (store_config_changed_event): Add comment.
3764 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3765 (store_tool_bar_style_changed): New functions.
5e617bc2 3766 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3767 (struct xsettings): Move font inside HAVE_XFT.
3768 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3769 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3770 Move inside HAVE_XFT.
640c8776 3771 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3772 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3773 also.
3774 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3775 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3776 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3777 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3778 (parse_settings): Move check for font inside HAVE_XFT.
3779 (read_settings, apply_xft_settings): Add comment.
3780 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3781 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3782 call store_font_name_changed.
3783 (xft_settings_event): Add comment.
3784 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3785 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3786 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3787 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3788 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3789 (xsettings_get_system_font, xsettings_get_system_normal_font):
3790 Add comment.
869795d6 3791
d8ed26bd
PE
37922011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3793
3794 Random fixes. E.g., (random) never returned negative values.
3795 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3796 subseconds part to the entropy, as that's a bit more random.
3797 Prefer signed to unsigned, since the signedness doesn't matter and
3798 in general we prefer signed. When given a limit, use a
3799 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3800 latter isn't right if USE_2_TAGS_FOR_INTS.
3801 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3802 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3803
cabf1cac
SM
38042011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3805
3806 * textprop.c (text_property_stickiness):
3807 Obey Vtext_property_default_nonsticky.
3808 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3809 * w32fns.c (syms_of_w32fns):
3810 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3811
6e9b2be9
PE
38122011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3813
3814 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3815 This is more efficient than Ffile_directory_p and avoids a minor race.
3816
90186c68
LMI
38172011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3818
7c301272
LMI
3819 * buffer.c (Foverlay_put): Say what the return value is
3820 (bug#7835).
3821
c4f2d8d4
LMI
3822 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3823 is a directory before asking whether to use the file name
3824 (bug#7564).
ad637907
LMI
3825 (barf_or_query_if_file_exists): Make the "File is a directory"
3826 error be more correct.
c4f2d8d4 3827
90186c68
LMI
3828 * fns.c (Frequire): Remove the mention of the .gz files, since
3829 that's installation-specific, but keep the mention of
3830 `get-load-suffixes'.
3831
da64016e
PE
38322011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3833
3834 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3835 Report string overflow if the output is too long.
3836
7d47b580
JB
38372011-07-04 Juanma Barranquero <lekktu@gmail.com>
3838
a555cb87
JB
3839 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3840 (syms_of_gnutls): Remove duplicate DEFSYM for
3841 Qgnutls_bootprop_verify_hostname_error, an error for
3842 Qgnutls_bootprop_verify_error (which is no longer used).
3843
7d47b580
JB
3844 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3845 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3846 Also (re)move comments that are misplaced or no longer relevant.
3847
1e49bfab
LMI
38482011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3849
3850 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3851
1485f4c0
CY
38522011-07-03 Chong Yidong <cyd@stupidchicken.com>
3853
3854 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3855 and background color parameters if they have been changed.
3856
a9ab721e
LMI
38572011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3858
3859 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3860
cf7cff57
PE
38612011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3862
2e13213d
PE
3863 * xsettings.c (SYSTEM_FONT): Define only when used.
3864 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3865
cf7cff57
PE
3866 * keymap.c (access_keymap_1): Now static.
3867
7a8e04f7
CY
38682011-07-02 Chong Yidong <cyd@stupidchicken.com>
3869
3870 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3871 leave any prefix arg for the up event (Bug#1586).
3872
61352f62
LMI
38732011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3874
69bb1ef7
LMI
3875 * lread.c (syms_of_lread): Mention single symbols defined by
3876 `defvar' or `defconst' (bug#7154).
3877
61352f62 3878 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3879 (Frequire): Mention get-load-suffixes.
61352f62 3880
28545e04
MR
38812011-07-02 Martin Rudalics <rudalics@gmx.at>
3882
3883 * window.h (window): Remove clone_number slot.
3884 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3885 Remove.
3886 (make_parent_window, make_window, saved_window)
3887 (Fset_window_configuration, save_window_save): Don't deal with
3888 clone numbers.
3889 * buffer.c (Qclone_number): Remove declaration.
3890 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3891
3349e122
SM
38922011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3893
3894 Add multiple inheritance to keymaps.
3895 * keymap.c (Fmake_composed_keymap): New function.
3896 (Fset_keymap_parent): Simplify.
3897 (fix_submap_inheritance): Remove.
3898 (access_keymap_1): New function extracted from access_keymap to handle
3899 embedded parents and handle lists of maps.
3900 (access_keymap): Use it.
3901 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3902 (Fcopy_keymap): Handle embedded parents.
3903 (Fcommand_remapping, define_as_prefix): Simplify.
3904 (Fkey_binding): Simplify.
3905 (syms_of_keymap): Move minibuffer-local-completion-map,
3906 minibuffer-local-filename-completion-map,
3907 minibuffer-local-must-match-map, and
3908 minibuffer-local-filename-must-match-map to Elisp.
3909 (syms_of_keymap): Defsubr make-composed-keymap.
3910 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3911 (parse_menu_item): Trivial simplification.
3912
3279eb87
GM
39132011-07-01 Glenn Morris <rgm@gnu.org>
3914
3915 * Makefile.in (SETTINGS_LIBS): Fix typo.
3916
4550efdf
KI
39172011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3918
3919 * coding.c (Fencode_coding_string): Record the last coding system
3920 used, as the function doc string says (bug#8738).
3921
0949d2b6
JD
39222011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3923
3924 * xsettings.c (store_monospaced_changed): Take new font as arg and
3925 check for change against current_mono_font.
3926 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3927 (emacs_settings_constructor, emacs_settings_get_property)
3928 (emacs_settings_set_property, emacs_settings_class_init)
3929 (emacs_settings_init, gsettings_obj): Remove.
3930 (something_changedCB): New function for HAVE_GSETTINGS.
3931 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3932 with value as argument.
3933 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3934 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3935 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3936 "changed".
3937
3938 * xgselect.c: Add defined (HAVE_GSETTINGS).
3939 (xgselect_initialize): Ditto.
3940
3941 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3942 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3943 xg_select.
3944
bbc6b304
PE
39452011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3946
3947 * eval.c (struct backtrace): Simplify and port the data structure.
3948 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3949 signed bit field, as this assumption is not portable and it makes
3950 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3951 "char debug_on_exit : 1" as this is not portable either; instead,
3952 use the portable "unsigned int debug_on_exit : 1". Remove unused
3953 member evalargs. Remove obsolete comments about cc bombing out.
3954
9851bfc5
JD
39552011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3956
51bb811f 3957 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3958 Let HAVE_GSETTINGS override HAVE_GCONF.
3959 (store_monospaced_changed): New function.
3960 (EMACS_SETTINGS): A new type derived from GObject to handle
3961 GSettings notifications.
3962 (emacs_settings_constructor, emacs_settings_get_property)
3963 (emacs_settings_set_property, emacs_settings_class_init):
3964 New functions.
3965 (gsettings_client, gsettings_obj): New variables.
3966 (GSETTINGS_SCHEMA): New define.
3967 (something_changedCB): Call store_monospaced_changed.
3968 (init_gsettings): New function.
3969 (xsettings_initialize): Call init_gsettings.
3970 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3971 to NULL.
3972
640c8776 3973 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3974 GCONF_CFLAGS/LIBS.
3975
5386012d
MR
39762011-06-29 Martin Rudalics <rudalics@gmx.at>
3977
3978 * window.c (resize_root_window, grow_mini_window)
3979 (shrink_mini_window): Rename Qresize_root_window to
3980 Qwindow_resize_root_window and Qresize_root_window_vertically to
3981 Qwindow_resize_root_window_vertically.
3982
f13e0b08
PE
39832011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3984
3985 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3986
94515237
JB
39872011-06-27 Juanma Barranquero <lekktu@gmail.com>
3988
3989 * makefile.w32-in: Redesign dependencies so they reflect more
3990 clearly which files are directly included by each source file,
3991 and not through other includes.
3992
e43b6e43
MR
39932011-06-27 Martin Rudalics <rudalics@gmx.at>
3994
3995 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3996 (sort_overlays, overlay_strings): When an overlay's clone number
3997 matches the window's clone number process the overlay even if
3998 the overlay's window property doesn't match the current window.
3999
d68443dc
MR
4000 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4001 (Fwindow_hchild): Rename to Fwindow_left_child.
4002 (Fwindow_next): Rename to Fwindow_next_sibling.
4003 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4004 (resize_window_check): Rename to window_resize_check.
4005 (resize_window_apply): Rename to window_resize_apply.
4006 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4007 (Fdelete_other_windows_internal, resize_frame_windows)
4008 (Fsplit_window_internal, Fdelete_window_internal)
4009 (grow_mini_window, shrink_mini_window)
4010 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4011
c7e73be5
JD
40122011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4013
4014 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4015 (emacs_fixed_set_min_size): Remove.
4016 (emacs_fixed_new): Take frame as argument.
4017
4018 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4019 (_EmacsFixedPrivate): Remove minwidth/height.
4020 Add struct frame *f.
4021 (emacs_fixed_init): Initialize priv->f.
4022 (get_parent_class, emacs_fixed_set_min_size): Remove.
4023 (emacs_fixed_new): Set priv->f to argument.
4024 (emacs_fixed_get_preferred_width)
4025 (emacs_fixed_get_preferred_height): Use min_width/height from
4026 frames size_hint to set minimum and natural (Bug#8919).
4027 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4028 and use min_width/height from frames size_hint to set
4029 min_width/height (Bug#8919).
4030
4031 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4032 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4033 Fix indentation.
c7e73be5 4034
cf99dcf8
EZ
40352011-06-26 Eli Zaretskii <eliz@gnu.org>
4036
4037 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4038 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4039 called at ZV.
4040
029529ac
CY
40412011-06-26 Chong Yidong <cyd@stupidchicken.com>
4042
4043 * process.c (wait_reading_process_output): Bypass select if
4044 waiting for a cell while ignoring keyboard input, and input is
4045 pending. Suggested by Jan Djärv (Bug#8869).
4046
7a7ef429
PE
40472011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4048
4049 Use gnulib's dup2 module instead of rolling our own.
4050 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4051
11fdef7d 40522011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4053
4054 * dispnew.c (scrolling_window): Before scrolling, turn off a
4055 mouse-highlight in the window being scrolled.
4056
cd3520a4
JB
40572011-06-24 Juanma Barranquero <lekktu@gmail.com>
4058
4059 Move DEFSYM to lisp.h and use everywhere.
4060
4061 * character.h (DEFSYM): Move declaration...
4062 * lisp.h (DEFSYM): ...here.
4063
4064 * gnutls.c:
4065 * minibuf.c:
4066 * w32menu.c:
4067 * w32proc.c:
4068 * w32select.c: Don't include character.h.
4069
4070 * alloc.c (syms_of_alloc):
4071 * buffer.c (syms_of_buffer):
4072 * bytecode.c (syms_of_bytecode):
4073 * callint.c (syms_of_callint):
4074 * casefiddle.c (syms_of_casefiddle):
4075 * casetab.c (init_casetab_once):
4076 * category.c (init_category_once, syms_of_category):
4077 * ccl.c (syms_of_ccl):
4078 * cmds.c (syms_of_cmds):
4079 * composite.c (syms_of_composite):
4080 * dbusbind.c (syms_of_dbusbind):
4081 * dired.c (syms_of_dired):
4082 * dispnew.c (syms_of_display):
4083 * doc.c (syms_of_doc):
4084 * editfns.c (syms_of_editfns):
4085 * emacs.c (syms_of_emacs):
4086 * eval.c (syms_of_eval):
4087 * fileio.c (syms_of_fileio):
4088 * fns.c (syms_of_fns):
4089 * frame.c (syms_of_frame):
4090 * fringe.c (syms_of_fringe):
4091 * insdel.c (syms_of_insdel):
4092 * keymap.c (syms_of_keymap):
4093 * lread.c (init_obarray, syms_of_lread):
4094 * macros.c (syms_of_macros):
4095 * msdos.c (syms_of_msdos):
4096 * print.c (syms_of_print):
4097 * process.c (syms_of_process):
4098 * search.c (syms_of_search):
4099 * sound.c (syms_of_sound):
4100 * syntax.c (init_syntax_once, syms_of_syntax):
4101 * terminal.c (syms_of_terminal):
4102 * textprop.c (syms_of_textprop):
4103 * undo.c (syms_of_undo):
4104 * w32.c (globals_of_w32):
4105 * window.c (syms_of_window):
4106 * xdisp.c (syms_of_xdisp):
4107 * xfaces.c (syms_of_xfaces):
4108 * xfns.c (syms_of_xfns):
4109 * xmenu.c (syms_of_xmenu):
4110 * xsettings.c (syms_of_xsettings):
4111 * xterm.c (syms_of_xterm): Use DEFSYM.
4112
4228cf16
TZ
41132011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4114
cd3520a4 4115 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4116
7fcccf1e
PE
41172011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4118
7efb4e0e
PE
4119 Integer and buffer overflow fixes (Bug#8873).
4120
ff5844ad
PE
4121 * print.c (printchar, strout): Check for string overflow.
4122 (PRINTPREPARE, printchar, strout):
4123 Don't set size unless allocation succeeds.
4124
90532f02
PE
4125 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4126 for sizes. Check for string overflow more accurately.
4127 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4128
6d84508d
PE
4129 * macros.c: Integer and buffer overflow fixes.
4130 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4131 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4132 Use ptrdiff_t, not int, for sizes.
4133 Don't increment bufsize until after realloc succeeds.
4134 Check for size-calculation overflow.
4135 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4136
437b2cb4
PE
4137 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4138
8b9ac8b4
PE
4139 * lread.c: Integer overflow fixes.
4140 (read_integer): Radix is now EMACS_INT, not int,
4141 to improve quality of diagnostics for out-of-range radices.
4142 Calculate buffer size correctly for out-of-range radices.
4143 (read1): Check for integer overflow in radices, and in
4144 read-circle numbers.
82cb60d3
PE
4145 (read_escape): Avoid int overflow.
4146 (Fload, openp, read_buffer_size, read1)
4147 (substitute_object_recurse, read_vector, read_list, map_obarray):
4148 Use ptrdiff_t, not int, for sizes.
4149 (read1): Use EMACS_INT, not int, for sizes.
20270765 4150 Check for size overflow.
8b9ac8b4 4151
7fcccf1e
PE
4152 * image.c (cache_image): Check for size arithmetic overflow.
4153
bfbbd7e7
PE
4154 * lread.c: Integer overflow issues.
4155 (saved_doc_string_size, saved_doc_string_length)
4156 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4157 Now ptrdiff_t, not int.
4158 (read1): Don't assume doc string length fits in int. Check for
4159 out-of-range doc string lengths.
4160 (read_list): Don't assume file position fits in int.
39019e54 4161 (read_escape): Check for hex character overflow.
bfbbd7e7 4162
4e323265
LL
41632011-06-22 Leo Liu <sdl.web@gmail.com>
4164
4165 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4166 Move to minibuffer.el.
4167
85fece3e
PE
41682011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4169
20b84ce9 4170 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4171 The following patches are for when GLYPH_DEBUG && !XASSERT.
4172 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4173 * dispnew.c (flush_stdout):
4174 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4175 Mark as externally visible.
4176 * dispnew.c (check_window_matrix_pointers): Now static.
4177 * dispnew.c (window_to_frame_vpos):
4178 * xfns.c (unwind_create_frame):
4179 * xterm.c (x_check_font): Remove unused local.
4180 * scroll.c (CHECK_BOUNDS):
4181 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4182 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4183 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4184 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4185 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4186 Now static.
4187 (debug_method_add): Use va_list and vsprintf rather than relying
4188 on undefined behavior with wrong number of arguments.
4189 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4190 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4191 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4192 since we're not interested in debugging glyphs with old libraries.
4193 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4194 GCC 4.6.0's static checking.
4195
0766b489
PE
41962011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4197
31fd4b32
PE
4198 Integer overflow and signedness fixes (Bug#8873).
4199 A few related buffer overrun fixes, too.
4200
b79e8648
PE
4201 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4202
0766b489
PE
4203 * dispextern.h (struct face.stipple):
4204 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4205 (x_bitmap_mask, x_allocate_bitmap_record)
4206 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4207 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4208 (x_create_bitmap_from_xpm_data):
4209 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4210 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4211 (.bitmaps_last):
4212 * xfaces.c (load_pixmap):
4213 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4214 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4215 (.bitmaps_last, struct x_output.icon_bitmap):
4216 Use ptrdiff_t, not int, for bitmap indexes.
4217 (x_allocate_bitmap_record): Check for size overflow.
4218 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4219
b081724f
PE
4220 Use ptrdiff_t, not int, for overlay counts.
4221 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4222 * editfns.c (overlays_around, get_pos_property):
4223 * textprop.c (get_char_property_and_overlay):
4224 * xdisp.c (next_overlay_change, note_mouse_highlight):
4225 * xfaces.c (face_at_buffer_position):
21514da7
PE
4226 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4227 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4228 (Fnext_overlay_change, Fprevious_overlay_change)
4229 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4230 Use ptrdiff_t, not int, for sizes.
21514da7 4231 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4232
3de73e5e
PE
4233 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4234
2606c57b
PE
4235 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4236 (x_session_initialize): Do not assume string length fits in int.
4237
aaafe47a
PE
4238 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4239 This is unlikely, but can occur if DPI is outlandish.
4240
2674ddc8 4241 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4242 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4243
28154962
PE
4244 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4245 * xrdb.c (magic_file_p, search_magic_path):
4246 Omit last arg SUFFIX; it was always 0. All callers changed.
4247 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4248
7de51af5
PE
4249 * xfont.c (xfont_match): Avoid need for strlen.
4250
25ed6cc3
PE
4251 * xfns.c: Don't assume strlen fits in int.
4252 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4253
4eab31dd
PE
4254 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4255 not unsigned long, as we prefer signed integers. All callers changed.
4256 Detect integer overflow in repeat count.
4257 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4258 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4259
171e2a58
PE
4260 * termcap.c: Don't assume sizes fit in int and never overflow.
4261 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4262 (gobble_line): Check for size-calculation overflow.
4263
ad39faca 4264 * minibuf.c (Fread_buffer):
6e5bb2dc 4265 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4266 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4267 Don't assume string length fits in int.
4268
52c61c22 4269 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4270 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4271
b5b8c9e5
PE
4272 * font.c: Don't assume string length fits in int.
4273 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4274 Use ptrdiff_t, not int.
ccd6111c
PE
4275 (font_intern_prop): Don't assume string length fits in int.
4276 Don't assume integer property fits in fixnum.
4277 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4278
882f0d81 4279 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4280 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4281 Reformulate so as not to need the command string.
4282 Invoke gzip -cd rather than gunzip, as it's more portable.
4283 (lock_info_type, lock_file_1, lock_file):
4284 Don't assume pid_t and time_t fit in unsigned long.
4285 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4286 (current_lock_owner): Prefer signed type for sizes.
4287 Use memcpy, not strncpy, where memcpy is what is really wanted.
4288 Don't assume (via atoi) that time_t and pid_t fit in int.
4289 Check for time_t and/or pid_t out of range, e.g., via a network share.
4290 Don't alloca where an auto var works fine.
4291
93f4cf88
PE
4292 * fileio.c: Fix some integer overflow issues.
4293 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4294 Don't assume string length fits in int.
4295 (directory_file_name): Don't assume string length fits in long.
4296 (make_temp_name): Don't assume pid fits in int, or that its print
4297 length is less than 20.
4298
f3e92b69
PE
4299 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4300
1bfdaf10
PE
4301 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4302
35016e9a
PE
4303 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4304
3d1e65a1
PE
4305 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4306 We prefer signed integers, even for size calculations.
4307
0b963a93
PE
4308 * emacs.c: Don't assume string length fits in 'int'.
4309 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4310 (main): Don't invoke strlen when not needed.
4311
573f4b54
PE
4312 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4313 (XD_DEBUG_MESSAGE): Don't waste a byte.
4314
989f33ba
PE
4315 * callproc.c (getenv_internal_1, getenv_internal)
4316 (Fgetenv_internal):
965d34eb
PE
4317 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4318
e4d29b33
PE
4319 * lread.c (invalid_syntax): Omit length argument.
4320 All uses changed. This doesn't fix a bug, but it simplifies the
4321 code away from its former Hollerith-constant appearance, and it's
4322 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4323 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4324
eb49b136
PE
4325 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4326 This didn't break anything, but it didn't help either.
4327 It's confusing to put a bogus integer in a place where the actual
4328 value does not matter.
9f62aeb1 4329 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4330 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4331
15375a22
PE
4332 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4333 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4334 implementation.
b61cc01c
PE
4335 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4336 We prefer signed types, and the value cannot exceed the EMACS_INT
4337 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4338 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4339 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4340 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4341
53b2623d
PE
4342 * indent.c (sane_tab_width): New function.
4343 (current_column, scan_for_column, Findent_to, position_indentation)
4344 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4345 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4346
51cab52b 4347 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4348
f2ed8a70
PE
4349 * lisp.h (lint_assume): New macro.
4350 * composite.c (composition_gstring_put_cache):
4351 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4352
abe80cc6
PE
4353 * editfns.c, insdel.c:
4354 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4355
b02c740e
PE
4356 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4357
ebc96716
PE
4358 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4359
b4e50fa0 4360 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4361 Use much-faster test for byte-length change.
311d5d7c 4362 Don't assume string byte-length fits in 'int'.
a4cf38e4 4363 Check that character arg fits in 'int'.
85461888 4364 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4365
c0c1ee9f
PE
4366 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4367
a498d7f4
PE
4368 * fns.c (concat): Catch string overflow earlier.
4369 Do not rely on integer wraparound.
4370
51cab52b
PE
4371 * dispextern.h (struct it.overlay_strings_charpos)
4372 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4373 * xdisp.c (forward_to_next_line_start)
4374 (back_to_previous_visible_line_start)
4375 (reseat_at_next_visible_line_start, next_element_from_buffer):
4376 Don't arbitrarily truncate the value of 'selective' to int.
4377
76031fad
PE
4378 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4379
5eb55db9
PE
4380 * composite.c: Don't truncate sizes to 'int'.
4381 (composition_gstring_p, composition_reseat_it)
4382 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4383 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4384 not EMACS_UINT, for indexes.
5eb55db9 4385
0703a717
PE
4386 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4387
d6202519
PE
4388 * buffer.c: Include <verify.h>.
4389 (struct sortvec.priority, struct sortstr.priority):
8961a454 4390 Now EMACS_INT, not int.
c20998a7 4391 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4392 (struct sortstr.size, record_overlay_string)
4393 (struct sortstrlist.size, struct sortlist.used):
4394 Don't truncate size to int.
4395 (record_overlay_string): Check for size-calculation overflow.
d6202519 4396 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4397
d5a19415
JM
43982011-06-22 Jim Meyering <meyering@redhat.com>
4399
029529ac 4400 Don't leak an XBM-image-sized buffer
d5a19415
JM
4401 * image.c (xbm_load): Free the image buffer after using it.
4402
a9041e6c
PE
44032011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4404
4405 Port to Sun C.
4406 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4407 that Sun C diagnosed.
4408 * fns.c (secure_hash): Fix pointer signedness issue.
4409 * intervals.c (static_offset_intervals): New function.
4410 (offset_intervals): Use it.
4411
7f3f739f
LL
44122011-06-21 Leo Liu <sdl.web@gmail.com>
4413
4414 * deps.mk (fns.o):
4415 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4416 sha512.h.
4417
4418 * fns.c (secure_hash): Rename from crypto_hash_function and change
4419 the first arg to accept symbols.
5b66d427 4420 (Fsecure_hash): New primitive.
7f3f739f
LL
4421 (syms_of_fns): New symbols.
4422
76147d94
DD
44232011-06-20 Deniz Dogan <deniz@dogan.se>
4424
4425 * process.c (Fset_process_buffer): Clarify return value in
4426 docstring.
4427
7d7d0045
CY
44282011-06-18 Chong Yidong <cyd@stupidchicken.com>
4429
4430 * dispnew.c (add_window_display_history): Use BVAR.
4431
4432 * xdisp.c (debug_method_add): Use BVAR.
4433 (check_window_end, dump_glyph_matrix, dump_glyph)
4434 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4435
4436 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4437 Likewise.
4438
4439 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4440 check till after the cache is created in init_frame_faces.
4441
ff2bc410
SM
44422011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4443
4444 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4445
28177add
PE
44462011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4447
dd3482fe
PE
4448 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4449 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4450 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4451
393d71f3 4452 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4453 * fileio.c (Finsert_file_contents):
4454 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4455 Remove the old (too-loose) buffer overflow checks.
4456 They weren't needed, since make_gap checks for buffer overflow.
4457 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4458 The old code merely checked for Emacs fixnum overflow, and relied
4459 on undefined (wraparound) behavior. The new code avoids undefined
4460 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4461
2e6813b0 4462 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4463 Tune. Don't use wider integers than needed. Don't use alloca.
4464 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4465
599a9e4f
PE
4466 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4467
99561444
PE
4468 * insdel.c, lisp.h (buffer_overflow): New function.
4469 (insert_from_buffer_1, replace_range, replace_range_2):
4470 * insdel.c (make_gap_larger):
4471 * editfns.c (Finsert_char):
4472 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4473
28177add
PE
4474 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4475
e69dafad
PE
44762011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4477
4baa020d 4478 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4479
b1c46f02
PE
4480 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4481 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4482
e69dafad
PE
4483 * fileio.c: Don't assume EMACS_INT fits in off_t.
4484 (emacs_lseek): New static function.
4485 (Finsert_file_contents, Fwrite_region): Use it.
4486 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4487
566684ea
PE
4488 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4489
e6966cd6
PE
4490 * fns.c: Don't overflow int when computing a list length.
4491 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4492 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4493 truncation on 64-bit hosts. Check for QUIT every
4494 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4495 faster and is responsive enough.
4496 (Flength): Report an error instead of overflowing an integer.
4497 (Fsafe_length): Return a float if the value is not representable
4498 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4499 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4500 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4501
dd0b0efb
PE
4502 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4503 (header_size, word_size): New constants.
4504 (allocate_vectorlike): Don't check size overflow here.
4505 (allocate_vector): Check it here instead, since this is the only
4506 caller of allocate_vectorlike that could cause overflow.
4507 Check that the new vector's length is representable as a fixnum.
4508
86fe5cfe
PE
4509 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4510 The previous code was bogus. For example, next_almost_prime (32)
4511 returned 39, which is undesirable as it is a multiple of 3; and
4512 next_almost_prime (24) returned 25, which is a multiple of 5 so
4513 why was the code bothering to check for multiples of 7?
4514
80e88859
PE
4515 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4516
4a2f0ad6
PE
4517 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4518
f66c7cf8
PE
4519 Variadic C functions now count arguments with ptrdiff_t.
4520 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4521 Back then I didn't know that the Emacs coding style prefers signed int.
4522 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4523 were being counted with int, which may truncate counts on 64-bit
4524 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4525 * lisp.h (struct Lisp_Subr.function.aMANY)
4526 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4527 Arg counts are now ptrdiff_t, not size_t.
4528 All variadic functions and their callers changed accordingly.
4529 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4530 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4531 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4532 * callint.c (Fcall_interactively): Check arg count for overflow,
4533 to avoid potential buffer overrun. Use signed char, not 'int',
4534 for 'varies' array, so that we needn't bother to check its size
4535 calculation for overflow.
4536 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4537 * eval.c (apply_lambda):
4538 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4539 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4540 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4541
a1759b76
PE
4542 * callint.c (Fcall_interactively): Don't use index var as event count.
4543
d96be9fc
PE
4544 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4545 * mem-limits.h (SIZE): Remove; no longer used.
4546
a690a978 4547 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4548
578c21e6
PE
4549 Remove unnecessary casts.
4550 * xterm.c (x_term_init):
4551 * xfns.c (x_set_border_pixel):
4552 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4553 These aren't needed now that we assume ANSI C.
4554
96f53c6c
PE
4555 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4556 It's more likely to cause problems (due to unsigned overflow)
4557 than to cure them.
4558
83c77d31
PE
4559 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4560
ee2079f1
PE
4561 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4562
6da65536
PE
4563 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4564
7147c4a4
PE
4565 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4566
193e32d9
PE
4567 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4568
e5533da6
PE
4569 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4570
9910e595
PE
4571 GLYPH_CODE_FACE returns EMACS_INT, not int.
4572 * dispextern.h (merge_faces):
4573 * xfaces.c (merge_faces):
01103c44
PE
4574 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4575 Don't assume EMACS_INT fits in int.
9910e595 4576
2638320e
PE
4577 * character.h (CHAR_VALID_P): Remove unused parameter.
4578 * fontset.c, lisp.h, xdisp.c: All uses changed.
4579
045eb8d9
PE
4580 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4581
c1f134b5
PE
4582 * fns.c (concat): Minor tuning based on overflow analysis.
4583 This doesn't fix any bugs. Use int to hold character, instead
4584 of constantly refetching from Emacs object. Use XFASTINT, not
4585 XINT, for value known to be a character. Don't bother comparing
4586 a single byte to 0400, as it's always less.
4587
395fcb93 4588 * floatfns.c (Fexpt):
327eeec8
PE
4589 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4590
abbd3d23
PE
4591 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4592 for characters.
4593
684a03ef
PE
4594 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4595
0fed43f3
PE
4596 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4597 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4598 incorrectly succeed when S was a string, because 4294967386 was
4599 truncated before it was used.
4600
8fd02eb7
PE
4601 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4602 Otherwise, an out-of-range integer could cause undefined behavior
4603 on a 64-bit host.
4604
f8c86b69
PE
4605 * composite.c: Use int, not EMACS_INT, for characters.
4606 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4607 EMACS_INT, for values that are known to be in character range.
4608 This doesn't fix any bugs but is the usual style inside Emacs and
4609 may generate better code on 32-bit machines.
4610
34206dd2
PE
4611 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4612 This is for reasons similar to the recent CHAR_STRING fix.
4613 * charset.c (Fencode_char): Check that character arg is actually
4614 a character. Pass an int to ENCODE_CHAR.
4615 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4616 wider than 'int', as a compile-time check to prevent future regressions
4617 in this area.
4618
c5958d4c 4619 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4620
4621 Make sure a 64-bit char is never passed to CHAR_STRING.
4622 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4623 by silently ignoring the top 32 bits, allowing some values
4624 that were far too large to be valid characters.
4625 * character.h: Include <verify.h>.
4626 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4627 arguments are no wider than unsigned, as a compile-time check
4628 to prevent future regressions in this area.
4629 * data.c (Faset):
01103c44 4630 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4631 (Fsubst_char_in_region):
4632 * fns.c (concat):
4633 * xdisp.c (decode_mode_spec_coding):
4634 Adjust to CHAR_STRING's new requirement.
4635 * editfns.c (Finsert_char, Fsubst_char_in_region):
4636 * fns.c (concat): Check that character args are actually
4637 characters. Without this test, these functions did the wrong
4638 thing with wildly out-of-range values on 64-bit hosts.
4639
d37ca623
PE
4640 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4641 These casts should not be needed on 32-bit hosts, either.
4642 * keyboard.c (read_char):
4643 * lread.c (Fload): Remove casts to unsigned.
4644
ea204efb
PE
4645 * lisp.h (UNSIGNED_CMP): New macro.
4646 This fixes comparison bugs on 64-bit hosts.
4647 (ASCII_CHAR_P): Use it.
4648 * casefiddle.c (casify_object):
01103c44 4649 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4650 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4651 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4652 * dispextern.h (FACE_FROM_ID):
4653 * keyboard.c (read_char): Use UNSIGNED_CMP.
4654
41cb286c
PE
4655 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4656 not to EMACS_INT, to avoid GCC warning.
4657
4a1b9832
PE
4658 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4659
55daad71
PE
4660 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4661 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4662 isn't needed on 32-bit machines.
8f95c75c 4663
01103c44
PE
4664 * buffer.c (Fgenerate_new_buffer_name):
4665 Use EMACS_INT for count, not int.
0ceccced 4666 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4667
4668 * data.c (Qcompiled_function): Now static.
4669
c6f072e7
PE
4670 * window.c (window_body_lines): Now static.
4671
20ce5912
PE
4672 * image.c (gif_load): Rename local to avoid shadowing.
4673
9c4c5f81
PE
4674 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4675 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4676 * alloc.c (make_save_value): Integer argument is now of type
4677 ptrdiff_t, not int.
4678 (mark_object): Use ptrdiff_t, not int.
4679 * lisp.h (pD): New macro.
4680 * print.c (print_object): Use it.
4681
c0c5c8ae
PE
4682 * alloc.c: Use EMACS_INT, not int, to count objects.
4683 (total_conses, total_markers, total_symbols, total_vector_size)
4684 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4685 (total_free_floats, total_floats, total_free_intervals)
4686 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4687 Now EMACS_INT, not int. All uses changed.
4688 (Fgarbage_collect): Compute overall total using a double, so that
4689 integer overflow is less likely to be a problem. Check for overflow
4690 when converting back to an integer.
5a25e253
PE
4691 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4692 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4693 These were 'int' variables that could overflow on 64-bit hosts;
4694 they were never used, so remove them instead of repairing them.
211a0b2a 4695 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4696 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4697 Previously, this ceilinged at INT_MAX, but that doesn't work on
4698 64-bit machines.
e46bb31a 4699 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4700
c78baabf 4701 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4702 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4703 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4704 when a (possibly-narrower) signed value would do just as well.
4705 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4706
c9d624c6
PE
4707 * alloc.c: Catch some string size overflows that we were missing.
4708 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4709 for convenience in STRING_BYTES_MAX.
4710 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4711 The definition here is exact; the one in lisp.h was approximate.
4712 (allocate_string_data): Check for string overflow. This catches
4713 some instances we weren't catching before. Also, it catches
4714 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4715 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4716 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4717
c9d624c6
PE
4718 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4719 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4720 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4721
353032ce
PE
4722 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4723
2bccce07
PE
4724 * alloc.c (Fmake_string): Check for out-of-range init.
4725
0ac30604
SM
47262011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4727
4728 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4729
c195f2de
JD
47302011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4731
4732 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4733 xg_get_default_scrollbar_width.
4734
4735 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4736 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4737 (style_changed_cb): Call update_theme_scrollbar_width and call
4738 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4739 all frames (Bug#8505).
4740 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4741 Call gtk_window_set_resizable if HAVE_GTK3.
4742 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4743 and height if HAVE_GTK3 (Bug#8505).
4744 (scroll_bar_width_for_theme): New variable.
4745 (update_theme_scrollbar_width): New function.
4746 (xg_get_default_scrollbar_width): Move code to
4747 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4748 (xg_initialize): Call update_theme_scrollbar_width.
4749
4750 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4751
4752 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4753
e10ac9f1
MR
47542011-06-12 Martin Rudalics <rudalics@gmx.at>
4755
4756 * frame.c (make_frame): Call other_buffer_safely instead of
4757 other_buffer.
4758
4759 * window.c (temp_output_buffer_show): Call display_buffer with
4760 second argument Vtemp_buffer_show_specifiers and reset latter
4761 immediately after the call.
4762 (Vtemp_buffer_show_specifiers): New variable.
4763 (auto_window_vscroll_p, next_screen_context_lines)
4764 (Vscroll_preserve_screen_position): Remove leading asterisks from
4765 doc-strings.
4766
2d3c217e 47672011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4768
7b7f97e8 4769 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4770 * buffer.c (Qclone_number): Remove for now, as it's unused.
4771 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4772 (record_buffer): Remove unused local.
4773 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4774 (set_frame_buffer_list): Remove; unused.
4775 * frame.h (other_visible_frames): Remove decl.
4776 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4777 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4778 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4779 if HAVE_GPM.
4780 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4781 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4782 Define only if HAVE_GPM.
4783 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4784 (update_hints_inhibit): Remove; never set. All uses removed.
4785 * widgetprv.h (emacsFrameClassRec): Remove decl.
4786 * window.c (delete_deletable_window): Now returns void, since it
4787 wasn't returning anything.
4788 (compare_window_configurations): Remove unused locals.
4789 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4790 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4791 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4792 the same widths as pointers. This follows up on the 2011-05-06 patch.
4793 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4794 * xterm.h: Likewise.
4795 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4796
1384b89e
JB
47972011-06-12 Juanma Barranquero <lekktu@gmail.com>
4798
4799 * makefile.w32-in: Update dependencies.
4800 (LISP_H): Add lib/intprops.h.
4801
1100a63c
CY
48022011-06-11 Chong Yidong <cyd@stupidchicken.com>
4803
4804 * image.c (gif_load): Add animation frame delay to the metadata.
4805 (syms_of_image): Use DEFSYM. New symbol `delay'.
4806
6198ccd0
MR
48072011-06-11 Martin Rudalics <rudalics@gmx.at>
4808
4809 * window.c (delete_deletable_window): Re-add.
4810 (Fset_window_configuration): Rewrite to handle dead buffers and
4811 consequently deletable windows.
4812 (window_tree, Fwindow_tree): Remove. Supply functionality in
4813 window.el.
4814 (compare_window_configurations): Simplify code.
4815
b6e3633c
AS
48162011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4817
1ab0dee5
AS
4818 * image.c (imagemagick_load_image): Fix type mismatch.
4819 (Fimagemagick_types): Likewise.
4820
b6e3633c
AS
4821 * window.h (replace_buffer_in_windows): Declare.
4822
9397e56f
MR
48232011-06-11 Martin Rudalics <rudalics@gmx.at>
4824
4825 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4826 Qclone_number. Remove external declaration of Qdelete_window.
4827 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4828 code.
640c8776
SM
4829 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4830 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4831 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4832 buffer list implementation.
4833 (other_buffer_safely): New function.
4834 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4835 calls to replace_buffer_in_windows and
4836 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4837 if allowed.
4838 (record_buffer): Inhibit quitting and rewrite using quittable
4839 functions. Run Qbuffer_list_update_hook if allowed.
4840 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4841 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4842 Move switch-to-buffer to window.el.
9397e56f
MR
4843 (bury-buffer): Move to window.el.
4844 (Vbuffer_list_update_hook): New variable.
4845
4846 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4847 section.
4848
4849 * window.h (resize_frame_windows): Move up in code.
4850 (Fwindow_frame): Remove EXFUN.
4851 (replace_buffer_in_all_windows): Remove prototype.
4852 (replace_buffer_in_windows_safely): Add prototype.
4853
4854 * window.c: Declare Qdelete_window static again. Move down
4855 declaration of select_count.
4856 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4857 (Fother_window): Move to window.el.
4858 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4859 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4860 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4861 window.el.
4862 (replace_buffer_in_windows): Implement by calling
4863 Qreplace_buffer_in_windows.
4864 (replace_buffer_in_all_windows): Remove with some functionality
4865 moved into replace_buffer_in_windows_safely.
4866 (replace_buffer_in_windows_safely): New function.
4867 (select_window_norecord, select_frame_norecord): Move in front
4868 of run_window_configuration_change_hook. Remove now obsolete
4869 declarations.
640c8776
SM
4870 (Fset_window_buffer): Rewrite doc-string.
4871 Call Qrecord_window_buffer.
9397e56f
MR
4872 (keys_of_window): Move binding for other-window to window.el.
4873
b50691aa
CY
48742011-06-11 Chong Yidong <cyd@stupidchicken.com>
4875
4876 * dispextern.h (struct image): Replace data member, whose int_val
4877 and ptr_val fields were not used by anything, with a single
4878 lisp_val object.
4879
4880 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4881 (gif_clear_image, gif_load, imagemagick_load_image)
4882 (gs_clear_image, gs_load): Callers changed.
4883
3f754b86
PE
48842011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4885
cca69397
PE
4886 * buffer.h: Include <time.h>, for time_t.
4887 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4888
109e28d0
PE
4889 Fix minor problems found by static checking.
4890
60737f02
PE
4891 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4892
4b66faf3
PE
4893 Make identifiers static if they are not used in other modules.
4894 * data.c (Qcompiled_function, Qframe, Qvector):
4895 * image.c (QimageMagick, Qsvg):
4896 * minibuf.c (Qmetadata):
4897 * window.c (resize_window_check, resize_root_window): Now static.
4898 * window.h (resize_window_check, resize_root_window): Remove decls.
4899
109e28d0
PE
4900 * window.c (window_deletion_count, delete_deletable_window):
4901 Remove; unused.
46a4ce9e
PE
4902 (window_body_lines): Now static.
4903 (Fdelete_other_windows_internal): Mark vars as initialized.
4904 Make sure 'resize_failed' is initialized.
4905 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4906 (resize_window_apply): Remove unused local.
4907 * window.h (delete_deletable_window): Remove decl.
4908
109e28d0 4909 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4910 (imagemagick_load_image): Fix pointer signedness problem by changing
4911 last arg from unsigned char * to char *. All uses changed.
4912 Also, fix a local for similar reasons.
4913 Remove unused locals. Remove locals to avoid shadowing.
4914 (fn_rsvg_handle_free): Remove; unused.
4915 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4916 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4917
3f754b86
PE
4918 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4919
2547adb1
CY
49202011-06-10 Chong Yidong <cyd@stupidchicken.com>
4921
4922 * image.c (gif_load): Fix omitted cast error introduced by
4923 2011-06-06 change.
4924
2c8e37d4
MR
49252011-06-10 Martin Rudalics <rudalics@gmx.at>
4926
4927 * window.h (resize_proportionally, orig_total_lines)
4928 (orig_top_line): Remove from window structure.
4929 (set_window_height, set_window_width, change_window_heights)
4930 (Fdelete_window): Remove prototypes.
4931 (resize_frame_windows): Remove duplicate declaration.
4932
440a42e3
EZ
49332011-06-10 Eli Zaretskii <eliz@gnu.org>
4934
4935 * window.h (resize_frame_windows, resize_window_check)
4936 (delete_deletable_window, resize_root_window)
4937 (resize_frame_windows): Declare prototypes.
4938
4939 * window.c (resize_window_apply): Make definition be "static" to
4940 match the prototype.
4941
562dd5e9
MR
49422011-06-10 Martin Rudalics <rudalics@gmx.at>
4943
4944 * window.c: Remove declarations of Qwindow_size_fixed,
4945 window_min_size_1, window_min_size_2, window_min_size,
4946 size_window, window_fixed_size_p, enlarge_window, delete_window.
4947 Remove static from declaration of Qdelete_window, it's
4948 temporarily needed by Fbury_buffer.
4949 (replace_window): Don't assign orig_top_line and
4950 orig_total_lines.
4951 (Fdelete_window, delete_window): Remove. Window deletion is
4952 handled by window.el.
640c8776
SM
4953 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4954 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4955 (Fdelete_other_windows): Remove. Deleting other windows is
4956 handled by window.el.
4957 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4958 handled in window.el.
4959 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4960 Window minimum sizes are handled in window.el.
4961 (shrink_windows, size_window, set_window_height)
4962 (set_window_width, change_window_heights, window_height)
4963 (window_width, CURBEG, CURSIZE, enlarge_window)
4964 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4965 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4966 handled in window.el.
4967 (make_dummy_parent): Rename to make_parent_window and give it a
4968 second argument horflag.
4969 (make_window): Don't set resize_proportionally any more.
4970 (Fsplit_window): Remove. Windows are split in window.el.
4971 (save_restore_action, save_restore_orig_size)
4972 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4973 Resize mini windows in window.el.
4974 (grow_mini_window, shrink_mini_window): Implement by calling
4975 Qresize_root_window_vertically, resize_window_check and
4976 resize_window_apply.
640c8776
SM
4977 (saved_window, Fset_window_configuration, save_window_save):
4978 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4979 resize_proportionally.
4980 (window_min_height, window_min_width): Move to window.el.
4981 (keys_of_window): Move bindings for delete-other-windows,
4982 split-window, delete-window and enlarge-window to window.el.
4983
4984 * buffer.c: Temporarily extern Qdelete_window.
4985 (Fbury_buffer): Temporarily call Qdelete_window instead of
4986 Fdelete_window (Fbury_buffer will move to window.el soon).
4987
4988 * frame.c (set_menu_bar_lines_1): Remove code handling
4989 orig_top_line and orig_total_lines.
4990
4991 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4992 set_window_height but set heights directly.
4993 (change_frame_size_1): Use resize_frame_windows.
4994
4995 * xdisp.c (init_xdisp): Don't use set_window_height but set
4996 heights directly.
4997
640c8776
SM
4998 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4999 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5000 run_window_configuration_change_hook.
5001
5002 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5003 instead of change_window_heights and run
5004 run_window_configuration_change_hook.
5005
1a13852e
MR
50062011-06-09 Martin Rudalics <rudalics@gmx.at>
5007
5008 * window.c (replace_window): Rename second argument REPLACEMENT to
5009 NEW. New third argument SETFLAG. Rewrite.
5010 (delete_window, make_dummy_parent): Call replace_window with
5011 third argument 1.
5012 (window_list_1): Move down in code.
5013 (run_window_configuration_change_hook): Move set_buffer part
5014 before select_frame_norecord part in order to unwind correctly.
5015 Rename count1 to count.
5016 (recombine_windows, delete_deletable_window, resize_root_window)
5017 (Fdelete_other_windows_internal)
5018 (Frun_window_configuration_change_hook, make_parent_window)
5019 (resize_window_check, resize_window_apply, Fresize_window_apply)
5020 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5021 (Fdelete_window_internal, Fresize_mini_window_internal):
5022 New functions.
1a13852e
MR
5023 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5024
f3d1777e
MR
50252011-06-08 Martin Rudalics <rudalics@gmx.at>
5026
496e208e
MR
5027 * window.h (window): Add some new members to window structure -
5028 normal_lines, normal_cols, new_total, new_normal, clone_number,
5029 splits, nest, prev_buffers, next_buffers.
5030 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5031 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5032
f3d1777e
MR
5033 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5034 Remove.
496e208e
MR
5035 (make_dummy_parent): Set new members of windows structure.
5036 (make_window): Move down in code. Handle new members of window
5037 structure.
5038 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5039 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5040 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5041 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5042 (Fset_window_next_buffers, Fset_window_clone_number):
5043 New functions.
496e208e
MR
5044 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5045 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5046 Doc-string fixes.
5047 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5048 Argument WINDOW can be now internal window too.
5049 (Fwindow_use_time): Move up in code.
5050 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5051 Rewrite doc-string.
5052 (Fset_window_configuration, saved_window)
5053 (Fcurrent_window_configuration, save_window_save): Handle new
5054 members of window structure.
b9e809c2
MR
5055 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5056 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5057 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5058 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5059 Qget_mru_window, Qresize_root_window,
5060 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5061 Qauto_buffer_name; staticpro them.
f3d1777e 5062
abde8f8c
MR
50632011-06-07 Martin Rudalics <rudalics@gmx.at>
5064
5065 * window.c (Fwindow_total_size, Fwindow_left_column)
5066 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5067 (Fwindow_list_1): New functions.
5068 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5069 (Fwindow_width, Fscroll_left, Fscroll_right):
5070 Use window_body_cols instead of window_box_text_cols.
5071 (delete_window, Fset_window_configuration):
5072 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5073 (delete_all_subwindows): Take a window as argument and not a
5074 structure. Rewrite.
190b47e6
MR
5075 (window_loop): Remove handling of GET_LRU_WINDOW and
5076 GET_LARGEST_WINDOW.
5077 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5078
5079 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5080 window_box_text_cols. delete_all_subwindows now takes a
5081 Lisp_Object as argument.
abde8f8c 5082
640c8776
SM
5083 * indent.c (compute_motion, Fcompute_motion):
5084 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5085
fa8a67e6
MR
5086 * frame.c (delete_frame): Call delete_all_subwindows with root
5087 window as argument.
5088
a54e3482
DC
50892011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5090
5091 * fns.c (Fputhash): Document return value.
5092
60002bf5
CY
50932011-06-06 Chong Yidong <cyd@stupidchicken.com>
5094
5095 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5096
0c671da6 50972011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5098
b862a52a 5099 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5100
be44ca6c
PE
5101 Check for overflow when converting integer to cons and back.
5102 * charset.c (Fdefine_charset_internal, Fdecode_char):
5103 Use cons_to_unsigned to catch overflow.
5104 (Fencode_char): Use INTEGER_TO_CONS.
5105 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5106 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5107 * data.c (long_to_cons, cons_to_long): Remove.
5108 (cons_to_unsigned, cons_to_signed): New functions.
5109 These signal an error for invalid or out-of-range values.
5110 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5111 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5112 * font.c (Ffont_variation_glyphs):
5113 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5114 * lisp.h: Include <intprops.h>.
5115 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5116 (cons_to_signed, cons_to_unsigned): New decls.
5117 (long_to_cons, cons_to_long): Remove decls.
5118 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5119 (Fprimitive_undo): Use CONS_TO_INTEGER.
5120 * xfns.c (Fx_window_property): Likewise.
5121 * xselect.c: Include <limits.h>.
5122 (x_own_selection, selection_data_to_lisp_data):
5123 Use INTEGER_TO_CONS.
5124 (x_handle_selection_request, x_handle_selection_clear)
5125 (x_get_foreign_selection, Fx_disown_selection_internal)
5126 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5127 (lisp_data_to_selection_data): Use cons_to_unsigned.
5128 (x_fill_property_data): Use cons_to_signed.
5129 Report values out of range.
5130
d1f3d2af
PE
5131 Check for buffer and string overflow more precisely.
5132 * buffer.h (BUF_BYTES_MAX): New macro.
5133 * lisp.h (STRING_BYTES_MAX): New macro.
5134 * alloc.c (Fmake_string):
5135 * character.c (string_escape_byte8):
5136 * coding.c (coding_alloc_by_realloc):
5137 * doprnt.c (doprnt):
5138 * editfns.c (Fformat):
5139 * eval.c (verror):
5140 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5141 since they may not be the same number.
5142 * editfns.c (Finsert_char):
5143 * fileio.c (Finsert_file_contents):
5144 Likewise for BUF_BYTES_MAX.
5145
dd52fcea
PE
5146 * image.c: Use ptrdiff_t, not int, for sizes.
5147 (slurp_file): Switch from int to ptrdiff_t.
5148 All uses changed.
5149 (slurp_file): Check that file size fits in both size_t (for
5150 malloc) and ptrdiff_t (for sanity and safety).
5151
7f9bbdbb
PE
5152 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5153 if b->modtime has its maximal value.
5154
dfe18f82
PE
5155 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5156
84acfcf0
PE
5157 Don't assume time_t can fit into int.
5158 * buffer.h (struct buffer.modtime): Now time_t, not int.
5159 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5160 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5161
ccd9a01a
PE
5162 Minor fixes for signed vs unsigned integers.
5163 * character.h (MAYBE_UNIFY_CHAR):
5164 * charset.c (maybe_unify_char):
5165 * keyboard.c (read_char, reorder_modifiers):
5166 XINT -> XFASTINT, since the integer must be nonnegative.
5167 * ftfont.c (ftfont_spec_pattern):
5168 * keymap.c (access_keymap, silly_event_symbol_error):
5169 XUINT -> XFASTINT, since the integer must be nonnegative.
5170 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5171 since it makes no difference and we prefer signed.
5172 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5173 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5174 nonnegative.
5175
d6d100dd
SM
51762011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5177
5178 * window.h (Fwindow_frame): Declare.
5179
2b6148e4
PE
51802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5181
5182 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5183 (SPARE_MEMORY): Always define.
5184 (LARGE_REQUEST): Remove.
5185 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5186
f230ecc9
MR
51872011-06-06 Martin Rudalics <rudalics@gmx.at>
5188
727e958e
MR
5189 * lisp.h: Move EXFUNS for Fframe_root_window,
5190 Fframe_first_window and Fset_frame_selected_window to window.h.
5191
5192 * window.h: Move EXFUNS for Fframe_root_window,
5193 Fframe_first_window and Fset_frame_selected_window here from
5194 lisp.h.
5195
5196 * frame.c (Fwindow_frame, Fframe_first_window)
5197 (Fframe_root_window, Fframe_selected_window)
5198 (Fset_frame_selected_window): Move to window.c.
5199 (Factive_minibuffer_window): Move to minibuf.c.
5200 (Fother_visible_frames_p): New function.
5201
5202 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5203
f230ecc9
MR
5204 * window.c (decode_window, decode_any_window): Move up in code.
5205 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5206 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5207 (Fwindow_buffer): Move up and rewrite doc-string.
5208 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5209 (Fwindow_prev): New functions.
727e958e
MR
5210 (Fwindow_frame): Move here from frame.c. Accept any window as
5211 argument.
5212 (Fframe_root_window, Fframe_first_window)
5213 (Fframe_selected_window): Move here from frame.c. Accept frame
5214 or arbitrary window as argument. Update doc-strings.
5215 (Fminibuffer_window): Move up in code.
5216 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5217 (Fset_frame_selected_window): Move here from frame.c.
5218 Marginal rewrite.
727e958e
MR
5219 (Fselected_window, select_window, Fselect_window): Move up in
5220 code. Minor doc-string fixes.
f230ecc9 5221
4d09bcf6
PE
52222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5223
5224 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5225 Do not assume that spare memory exists; that assumption is valid
5226 only if SYSTEM_MALLOC.
5227 (LARGE_REQUEST): New macro, so that the issue of large requests
5228 is separated from the issue of spare memory.
5229
810928a2
AS
52302011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5231
172418ad
AS
5232 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5233 format. (Bug#8806)
5234
43f862f7
AS
5235 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5236
810928a2
AS
5237 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5238 before statements.
5239
a059fe24
JD
52402011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5241
5242 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5243
5244 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5245
5246 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5247 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5248
989bf368
JB
52492011-06-05 Juanma Barranquero <lekktu@gmail.com>
5250
5251 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5252
4b80f674
CY
52532011-06-04 Chong Yidong <cyd@stupidchicken.com>
5254
5255 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5256 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5257 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5258 New error handlers.
4b80f674
CY
5259 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5260 Obey Vx_select_enable_clipboard_manager. Catch errors in
5261 x_clipboard_manager_save (Bug#8779).
5262 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5263 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5264
99a33b77 52652011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5266
5267 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5268
99a33b77 52692011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5270
5271 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5272 in the current matrix if keep_current_p is non-zero.
5273
8264569d
EZ
52742011-06-04 Eli Zaretskii <eliz@gnu.org>
5275
5276 * bidi.c (bidi_level_of_next_char): Fix last change.
5277
57f97249
EZ
52782011-06-03 Eli Zaretskii <eliz@gnu.org>
5279
fec2107c 5280 Support bidi reordering of text covered by display properties.
57f97249 5281
fec2107c
EZ
5282 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5283 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5284 (bidi_cache_search, bidi_cache_iterator_state)
5285 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5286 (bidi_level_of_next_char, bidi_move_to_visually_next):
5287 Support character positions inside a run of characters covered by a
fec2107c
EZ
5288 display string.
5289 (bidi_paragraph_init, bidi_resolve_explicit_1)
5290 (bidi_level_of_next_char): Call bidi_fetch_char and
5291 bidi_fetch_char_advance instead of FETCH_CHAR and
5292 FETCH_CHAR_ADVANCE.
5293 (bidi_init_it): Initialize new members.
5294 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5295 definitions.
5296 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5297 instead of using explicit *_CHAR codes.
d6d100dd
SM
5298 (bidi_resolve_explicit, bidi_resolve_weak):
5299 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5300 bidirectional text is supported only in multibyte buffers.
5301 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5302 it to initialize the frame_window_p member of struct bidi_it.
5303 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5304 (bidi_resolve_explicit, bidi_resolve_weak)
5305 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5306 bidi_it->nchars is non-positive.
5307 (bidi_level_of_next_char): Don't try to lookup the cache for the
5308 next/previous character if nothing is cached there yet, or if we
5309 were just reseat()'ed to a new position.
c40e2fb2 5310
0e14fe90
EZ
5311 * xdisp.c (set_cursor_from_row): Set start and stop points
5312 according to the row's direction when priming the loop that looks
5313 for the glyph on which to display cursor.
5314 (single_display_spec_intangible_p): Function deleted.
5315 (display_prop_intangible_p): Reimplement to call
5316 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5317 Accept 3 additional arguments needed by handle_display_spec.
5318 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5319 values: lists, `(when COND...)' forms, etc.
5320 (single_display_spec_string_p): Support property values that are
5321 lists with the argument STRING its top-level element.
5322 (display_prop_string_p): Fix the condition for processing a
5323 property that is a list to be consistent with handle_display_spec.
fec2107c 5324 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5325 last portion of handle_display_prop.
5326 (compute_display_string_pos): Accept additional argument
5327 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5328 value of a `display' property is a "replacing spec".
5329 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5330 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5331 the display property, but just return a value indicating whether
5332 the display property will replace the characters it covers.
5333 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5334 frame_window_p members of struct bidi_it.
d6d100dd
SM
5335 (compute_display_string_pos, compute_display_string_end):
5336 New functions.
fec2107c
EZ
5337 (push_it): Accept second argument POSITION, where pop_it should
5338 jump to continue iteration.
5339 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5340
fec2107c
EZ
5341 * keyboard.c (adjust_point_for_property): Adjust the call to
5342 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5343
5344 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5345 (bidi_init_it): Update prototypes.
5346 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5347 (compute_display_string_pos, compute_display_string_end):
5348 Declare prototypes.
fec2107c
EZ
5349 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5350 EMACS_INT.
fc6f18ce 5351
40087514 53522011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5353
57f53182
PE
5354 Malloc failure behavior now depends on size of allocation.
5355 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5356 * lisp.h: Change signatures accordingly.
5357 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5358 All callers changed. (Bug#8762)
5359
5360 * gnutls.c: Use Emacs's memory allocators.
5361 Without this change, the gnutls library would invoke malloc etc.
5362 directly, which causes problems on non-SYNC_INPUT hosts, and which
5363 runs afoul of improving memory_full behavior. (Bug#8761)
5364 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5365 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5366 xfree instead of the default malloc, realloc, free.
5367 (Fgnutls_boot): No need to check for memory allocation failure,
5368 since xmalloc does that for us.
5369
ac32cd99 5370 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5371 * category.c (hash_get_category_set):
5372 * ccl.c (ccl_driver):
5373 * charset.c (Fdefine_charset_internal):
5374 * charset.h (struct charset.hash_index):
5375 * composite.c (get_composition_id, gstring_lookup_cache)
5376 (composition_gstring_put_cache):
5377 * composite.h (struct composition.hash_index):
5378 * dispextern.h (struct image.hash):
5379 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5380 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5381 (hashfn_equal, hashfn_user_defined, make_hash_table)
5382 (maybe_resize_hash_table, hash_lookup, hash_put)
5383 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5384 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5385 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5386 * image.c (make_image, search_image_cache, lookup_image)
5387 (xpm_put_color_table_h):
5388 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5389 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5390 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5391 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5392 * alloc.c (allocate_vectorlike):
5393 Check for overflow in vector size calculations.
5394 * ccl.c (ccl_driver):
5395 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5396 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5397 need to be updated by these changes.
40087514
PE
5398 * fns.c (make_hash_table, maybe_resize_hash_table):
5399 Check for integer overflow with large hash tables.
0de4bb68
PE
5400 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5401 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5402 (SXHASH_REDUCE): New macro.
5403 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5404 Use it instead of discarding useful hash info with large hash values.
5405 (sxhash_float): New function.
5406 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5407 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5408 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5409 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5410 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5411 Adjust signatures to match updated version of code.
5412 (consing_since_gc): Now EMACS_INT, since a single hash table can
5413 use more than INT_MAX bytes.
5414
698d32e2
DN
54152011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5416
5417 Make it possible to build with GCC-4.6+ -O2 -flto.
5418
5419 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5420
fd6fa53f
SM
54212011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5422
5423 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5424 Call minibuffer-inactive-mode.
5425
864db017
JB
54262011-05-31 Juanma Barranquero <lekktu@gmail.com>
5427
5428 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5429 Update dependencies.
5430
2ad0baf4
DN
54312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5432
5433 * data.c (init_data): Remove code for UTS, this system is not
5434 supported anymore.
5435
4fcc2638
DN
54362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5437
5438 Don't force ./temacs to start in terminal mode.
5439
5440 * frame.c (make_initial_frame): Initialize faces in all cases, not
5441 only when CANNOT_DUMP is defined.
5442 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5443
c56e0fd5
DN
54442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5445
5446 * dispnew.c (add_window_display_history): Use const for the string
5447 pointer. Remove declaration, not needed.
5448
333d54da 54492011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5450
55d4c1b2 5451 Use 'inline', not 'INLINE'.
333d54da 5452 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5453 * alloc.c, fontset.c (INLINE): Remove.
5454 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5455 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5456 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5457 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5458 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5459
738db178
DN
54602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5461
5462 Make it possible to run ./temacs.
5463
5464 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5465 syms_of_callproc does the same thing. Remove test for
5466 "initialized", do it in the caller.
5467 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5468
620c53a6
SM
54692011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5470
5471 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5472 (read_minibuf): Use get_minibuffer.
5473 (syms_of_minibuf): Use DEFSYM.
5474 (Qmetadata): New var.
5475 * data.c (Qbuffer): Don't make it static.
5476 (syms_of_data): Use DEFSYM.
5477
e003a292
PE
54782011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5479
5480 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5481 (CCL_CODE_MIN): New macro.
5482
ed008a6d
PE
54832011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5484
3687c2ef
PE
5485 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5486
ed008a6d
PE
5487 * eval.c (Qdebug): Now static.
5488 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5489 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5490 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5491
d66c4c7c
CY
54922011-05-29 Chong Yidong <cyd@stupidchicken.com>
5493
5494 * image.c: Various fixes to ImageMagick code comments.
5495 (Fimagemagick_types): Doc fix.
5496
5fbc2025
PE
54972011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5498
0196f88a
PE
5499 Minor fixes prompted by GCC 4.6.0 warnings.
5500
5501 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5502
5fbc2025
PE
5503 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5504 (x_clipboard_manager_save_all): Move extern decl to ...
5505 * xterm.h: ... here, so that it can be checked for consistency.
5506
1dd3c2d9
CY
55072011-05-29 Chong Yidong <cyd@stupidchicken.com>
5508
5509 * xselect.c (x_clipboard_manager_save_frame)
5510 (x_clipboard_manager_save_all): New functions.
5511 (Fx_clipboard_manager_save): Lisp function deleted.
5512
5513 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5514 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5515
5516 * xterm.h: Update prototype.
5517
5ba6571d
WX
55182011-05-28 William Xu <william.xwl@gmail.com>
5519
5520 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5521 exiting (Bug#8239).
5522
3eaff834
JM
55232011-05-28 Jim Meyering <meyering@redhat.com>
5524
e1900994 5525 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5526 * fns.c (to_uchar): Define.
5527 (crypto_hash_function): Use it to convert some newly-signed
5528 variables to unsigned, to avoid sign-extension bugs. For example,
5529 without this change, (md5 "truc") would evaluate to
5530 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5531 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5532 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5533
0f6990a7
PE
55342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5535
5536 Integer overflow fixes.
c8a9ca5a 5537
08686060
PE
5538 * dbusbind.c: Serial number integer overflow fixes.
5539 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5540 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5541 to hold a serial number that is too large for a fixnum.
5542 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5543 Check for serial numbers out of range. Decode any serial number
59568bf0 5544 that was so large that it became a float. (Bug#8722)
08686060 5545
2d1fc3c7
PE
5546 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5547 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5548 Use XFASTINT rather than XUINT when numbers are nonnegative.
5549 (xd_append_arg, Fdbus_method_return_internal):
5550 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5551 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5552 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5553 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5554 (Bug#8722)
2d1fc3c7 5555
c8a9ca5a
PE
5556 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5557
519e1d69
PE
5558 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5559
30569699
PE
5560 ccl: add integer overflow checks
5561 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5562 (IN_INT_RANGE): New macros.
5563 (ccl_driver): Use them to check for integer overflow when
5564 decoding a CCL program. Many of the new checks are whether XINT (x)
5565 fits in int; it doesn't always, on 64-bit hosts. The new version
5566 doesn't catch all possible integer overflows, but it's an
847044ea 5567 improvement. (Bug#8719)
30569699 5568
c11285dc
PE
5569 * alloc.c (make_event_array): Use XINT, not XUINT.
5570 There's no need for unsigned here.
5571
fdccd48e
PE
5572 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5573 This follows up to the 2011-05-06 change that substituted uintptr_t
5574 for EMACS_INT. This case wasn't caught back then.
5575
37910ab2
PE
5576 Rework Fformat to avoid integer overflow issues.
5577 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5578 now (part of C89). Include <verify.h>.
5579 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5580 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5581 (Fformat): Avoid the prepass trying to compute sizes; it was only
5582 approximate and thus did not catch overflow reliably. Instead, walk
5583 through the format just once, formatting and computing sizes as we go,
5584 checking for integer overflow at every step, and allocating a larger
5585 buffer as needed. Keep track separately whether the format is
5586 multibyte. Keep only the most-recently calculated precision, rather
5587 than them all. Record whether each argument has been converted to
5588 string. Use EMACS_INT, not int, for byte and char and arg counts.
5589 Support field widths and precisions larger than INT_MAX. Avoid
5590 sprintf's undefined behavior with conversion specifications such as %#d
5591 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5592 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5593 formatting out-of-range floating point numbers with int
9173deec 5594 formats. (Bug#8668)
37910ab2 5595
2e6578fb
PE
5596 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5597
0ae6bdee
PE
5598 * data.c: Avoid integer truncation in expressions involving floats.
5599 * data.c: Include <intprops.h>.
5600 (arith_driver): When there's an integer overflow in an expression
5601 involving floating point, convert the integers to floating point
5602 so that the resulting value does not suffer from catastrophic
5603 integer truncation. For example, on a 64-bit host (* 4
5604 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5605 Do not rely on undefined behavior after integer overflow.
5606
de883a70
PE
5607 merge count_size_as_multibyte, parse_str_to_multibyte
5608 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5609 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5610 Check for integer overflow.
5611 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5612 since it's now a duplicate of the other. This is more of
5613 a character than a buffer op, so better that it's in character.c.
5614 * fns.c, print.c: Adjust to above changes.
5615
2ff916cb
PE
56162011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5617
5618 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5619
f1b54466
PE
56202011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5621
fb1ac845
PE
5622 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5623 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5624 (x_clipboard_manager_save): Now static.
5625 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5626
f1b54466
PE
5627 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5628 (crypto_hash_function): Now static.
5629 Fix pointer signedness problems. Avoid unnecessary initializations.
5630
a9f737ee
CY
56312011-05-27 Chong Yidong <cyd@stupidchicken.com>
5632
5633 * termhooks.h (Vselection_alist): Make it terminal-local.
5634
5635 * terminal.c (create_terminal): Initialize it.
5636
5637 * xselect.c: Support for clipboard managers.
5638 (Vselection_alist): Move to termhooks.h as terminal-local var.
5639 (LOCAL_SELECTION): New macro.
5640 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5641 (symbol_to_x_atom): Remove gratuitous arg.
5642 (x_handle_selection_request, lisp_data_to_selection_data)
5643 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5644 (x_own_selection, x_get_local_selection, x_convert_selection):
5645 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5646 (some_frame_on_display): Delete unused function.
5647 (Fx_own_selection_internal, Fx_get_selection_internal)
5648 (Fx_disown_selection_internal, Fx_selection_owner_p)
5649 (Fx_selection_exists_p): New optional frame arg.
5650 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5651 (x_handle_selection_clear): Don't treat other terminals with the
5652 same keyboard specially. Use the terminal-local Vselection_alist.
5653 (x_clear_frame_selections): Use Frun_hook_with_args.
5654
5655 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5656
5657 * xterm.h: Add support for those atoms.
5658
e067f0c1
CY
56592011-05-26 Chong Yidong <cyd@stupidchicken.com>
5660
5661 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5662 (converted_selections, conversion_fail_tag): New global variables.
5663 (x_selection_request_lisp_error): Free the above.
5664 (x_get_local_selection): Remove unnecessary code.
5665 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5666 of converted selections stored in converted_selections.
5667 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5668 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5669 (x_convert_selection): New function.
5670 (x_handle_selection_event): Simplify.
5671 (x_get_foreign_selection): Don't ignore incoming requests while
5672 waiting for an answer; this will fail when we implement
5673 SAVE_TARGETS, and seems unnecessary anyway.
5674 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5675 (Vx_sent_selection_functions): Doc fix.
5676
0f4aebc0
LL
56772011-05-26 Leo Liu <sdl.web@gmail.com>
5678
5679 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5680
e61124cd
YM
56812011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5682
5683 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5684
5685 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5686 for fringe update if it has periodic bitmap.
ac389d0c 5687 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5688 and fringe_bitmap_periodic_p.
5689
5690 * fringe.c (get_fringe_bitmap_data): New function.
5691 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5692 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5693 row. Mark glyph row for fringe update if periodicity changed.
5694
5695 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5696 for fringe update unless it has periodic bitmap.
5697
f16d9837
KH
56982011-05-25 Kenichi Handa <handa@m17n.org>
5699
5700 * xdisp.c (get_next_display_element): Set correct it->face_id for
5701 a static composition.
5702
e1b90ef6
LL
57032011-05-24 Leo Liu <sdl.web@gmail.com>
5704
5705 * deps.mk (fns.o):
5706 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5707
5708 * fns.c (crypto_hash_function, Fsha1): New function.
5709 (Fmd5): Use crypto_hash_function.
5710 (syms_of_fns): Add Ssha1.
5711
7400048f
PE
57122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5713
5714 * gnutls.c: Remove unused macros.
5715 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5716 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5717 Remove macros that are defined and never used.
5718 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5719
abb71cf4
CY
57202011-05-22 Chong Yidong <cyd@stupidchicken.com>
5721
5722 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5723 (Fx_get_selection_internal): Minor cleanup.
5724 (Fx_own_selection_internal): Rename arguments for consistency with
5725 select.el.
5726
6307db39
PE
57272011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5728
5729 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5730
f3d4e0a4
CY
57312011-05-22 Chong Yidong <cyd@stupidchicken.com>
5732
5733 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5734
4d8ade89
YM
57352011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5736
5737 * dispnew.c (scrolling_window): Don't exclude the case that the
5738 last enabled row in the desired matrix touches the bottom boundary.
5739
32078c8d
GM
57402011-05-21 Glenn Morris <rgm@gnu.org>
5741
5742 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5743 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5744 and add some more files.
32078c8d 5745
7285dc67
EZ
57462011-05-20 Eli Zaretskii <eliz@gnu.org>
5747
5748 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5749 report_file_error introduced by the change from 2011-05-07.
5750
89d1bd22
PE
57512011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5752
5753 * systime.h (Time): Define only if emacs is defined.
5754 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5755 where the include path doesn't have X11/X.h by default. See
5756 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5757
e23640bb 57582011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5759
5760 * composite.c (find_automatic_composition): Fix previous change.
5761
b9704ad9
GM
57622011-05-20 Glenn Morris <rgm@gnu.org>
5763
5764 * lisp.mk: New file, split from Makefile.in.
5765 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5766 (shortlisp): Remove.
5767 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5768
4a720484
GM
57692011-05-19 Glenn Morris <rgm@gnu.org>
5770
5771 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5772 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5773 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5774 (lisp): Set the order to that of loadup.el.
5775 (shortlisp): Make it a copy of $lisp.
5776 (SOME_MACHINE_LISP): Remove.
5777 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5778 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5779
a28d4396
KH
57802011-05-18 Kenichi Handa <handa@m17n.org>
5781
5782 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5783 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5784 (find_automatic_composition): Mostly rewrite for efficiency.
5785
a2b1fa8e
JB
57862011-05-18 Juanma Barranquero <lekktu@gmail.com>
5787
5788 * makefile.w32-in: Update dependencies.
5789
8e1f5610
CS
57902011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5791
5792 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5793 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5794
7025ee00 57952011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5796
cdfa6eab
PE
5797 Fix some integer overflow issues, such as string length overflow.
5798
06d6db33
PE
5799 * insdel.c (count_size_as_multibyte): Check for string overflow.
5800
2b4560a8
PE
5801 * character.c (lisp_string_width): Check for string overflow.
5802 Use EMACS_INT, not int, for string indexes and lengths; in
5803 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5804 the resulting string length overflows an EMACS_INT; instead,
5805 report a string overflow if no precision given. When checking for
5806 precision exhaustion, use a check that cannot possibly have
5807 integer overflow. (Bug#8675)
5808 * character.h (lisp_string_width): Adjust to new signature.
5809
cb93f9be
PE
5810 * alloc.c (string_overflow): New function.
5811 (Fmake_string): Use it. This doesn't change behavior, but saves
5812 a few bytes and will simplify future changes.
5813 * character.c (string_escape_byte8): Likewise.
5814 * lisp.h (string_overflow): New decl.
5815
1a1f3366
PE
5816 Fixups, following up to the user-interface timestamp change.
5817 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5818 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5819 * msdos.c (mouse_get_pos): Likewise.
5820 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5821 * w32gui.h (Time): Define by including "systime.h" rather than by
5822 declaring it ourselves. (Bug#8664)
5823
d4e3e4d3
PE
5824 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5825 * image.c (clear_image_cache): Likewise.
5826
f6a24d19
PE
5827 * term.c (term_mouse_position): Don't assume time_t wraparound.
5828
08dc5ae6
PE
5829 Be more systematic about user-interface timestamps.
5830 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5831 and sometimes 'EMACS_UINT', to represent these timestamps.
5832 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5833 This makes the code easier to follow, and makes it easier to catch
5834 integer overflow bugs such as Bug#8664.
5835 * frame.c (Fmouse_position, Fmouse_pixel_position):
5836 Use Time, not unsigned long, for user-interface timestamps.
5837 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5838 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5839 * keyboard.h (last_event_timestamp): Likewise.
5840 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5841 * menu.h (xmenu_show): Likewise.
5842 * term.c (term_mouse_position): Likewise.
5843 * termhooks.h (struct input_event.timestamp): Likewise.
5844 (struct terminal.mouse_position_hook): Likewise.
5845 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5846 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5847 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5848 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5849 what it was before.
5850 * menu.h, termhooks.h: Include "systime.h", for Time.
5851
8e55734a
PE
5852 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5853 Don't assume that the difference between two unsigned long values
5854 can fit into an integer. At this point, we know button_down_time
5855 <= event->timestamp, so the difference must be nonnegative, so
5856 there's no need to cast the result if double-click-time is
5857 nonnegative, as it should be; check that it's nonnegative, just in
5858 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5859 apart (about 25 days). (Bug#8664)
8e55734a 5860
841f1b75 5861 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5862 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5863
3e26f69c
PE
5864 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5865 that always fit in int. Use a sentinel instead of a counter, to
5866 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5867 * frame.h (struct frame): Use int for menu_bar_items_used
5868 instead of EMACS_INT, since it always fits in int.
3e26f69c 5869
5cc152c0
PE
5870 * menu.c (grow_menu_items): Check for int overflow.
5871
d89eb65e
PE
5872 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5873
5235bd3e
PE
5874 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5875 Before, the code was not consistent. These values cannot exceed
5876 2**31 - 1 so there's no need to make them unsigned.
5877 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5878 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5879 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5880 as modifiers.
5881 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5882
bc827e23
PE
5883 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5884 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5885 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5886 presumably because the widths might not match.
5887
78eb494e
PE
5888 * window.c (size_window): Avoid needless test at loop start.
5889
04f2d78b
CB
58902011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5891
5892 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5893
d2fc7e3d 58942011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5895
5896 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5897
d2fc7e3d 58982011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5899
5900 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5901 `width' to `bar_area_x' and `bar_area_width', respectively.
5902 (x_scroll_run): Take account of fringe background extension.
5903
04f2d78b
CB
5904 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5905 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5906 `bar_area_width', respectively.
5907 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5908 background extension.
5909
79b70037
GM
59102011-05-10 Jim Meyering <meyering@redhat.com>
5911
5912 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5913
2f142cc5
JB
59142011-05-10 Juanma Barranquero <lekktu@gmail.com>
5915
5916 * image.c (Finit_image_library): Return t for built-in image types,
5917 like pbm and xbm. (Bug#8640)
5918
57679c86
AS
59192011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5920
5921 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5922
888c9e86
EZ
59232011-05-07 Eli Zaretskii <eliz@gnu.org>
5924
b0512a1d
EZ
5925 * w32console.c (Fset_screen_color): Doc fix.
5926 (Fget_screen_color): New function.
5927 (syms_of_ntterm): Defsubr it.
5928
7285dc67
EZ
5929 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5930 unlink the temporary file if Fcall_process didn't create it in the
5931 first place.
5932 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5933 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5934 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5935 cue to call_process_cleanup not to close that handle.
5936
4d3fcc8e
BK
59372011-05-07 Ben Key <bkey76@gmail.com>
5938
5939 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5940 one of two shell specific rules, either bootstrap-temacs-CMD or
5941 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5942 to the previous implementation of the bootstrap-temacs rule.
5943 The bootstrap-temacs-CMD rule is similar to the previous
5944 implementation of the bootstrap-temacs rule except that it
5945 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5946 variable.
5947
5948 These changes, along with some changes to nt/configure.bat,
5949 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5950 earlier fix to add support for --cflags and --ldflags options
5951 that include quotes so that it works whether make uses cmd or
5952 sh as the shell.
5953
b4289b64
MA
59542011-05-06 Michael Albinus <michael.albinus@gmx.de>
5955
5956 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5957 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5958 is a constant.
5959 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5960 a string. Handle both cases.
5961 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5962 (Fdbus_register_method): Use Qinvalid_function.
5963
af4c0e28
JB
59642011-05-06 Juanma Barranquero <lekktu@gmail.com>
5965
5966 * makefile.w32-in: Update dependencies.
5967 (LISP_H): Add inttypes.h and stdin.h.
5968 (PROCESS_H): Add unistd.h.
5969
c51453d9
EZ
59702011-05-06 Eli Zaretskii <eliz@gnu.org>
5971
5972 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5973 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5974
8ff0ac3c 59752011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5976
4c4b566b
PE
5977 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5978
aab2b9b5
PE
5979 * term.c (vfatal): Remove stray call to va_end.
5980 It's not needed and the C Standard doesn't allow it here anyway.
5981
c378da0b
PE
5982 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5983 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5984
288b08c7
PE
5985 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5986 bytes.
5987
e3601888
PE
5988 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5989
db6c0e74
PE
5990 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5991
dd5963ea
PE
5992 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5993
88c9450f
PE
5994 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5995
2f9442b8
PE
5996 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5997
c032b5f8
PE
5998 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5999 * charset.c (Fdefine_charset_internal): Don't initialize
6000 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6001 32-bit int (Bug#8600).
a108c10b
PE
6002
6003 * lread.c (read_integer): Be more consistent with string-to-number.
6004 Use string_to_number to do the actual conversion; this avoids
6005 rounding errors and fixes some other screwups. Without this fix,
6006 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6007 (digit_to_number): Move earlier, for benefit of read_integer.
6008 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6009 not a digit in any supported base. (Bug#8602)
a108c10b 6010
ad5f9eea
PE
6011 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6012
aec1708a
PE
6013 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6014 to match comment at start of function. This also removes a
6015 GCC warning about overflow in a 32+64-bit port.
6016
47be4ab5
PE
6017 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6018
371cac43
PE
6019 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6020 Reported by Stefan Monnier in
6021 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6022 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6023 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6024
d01a7826
PE
6025 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6026 (EMACS_UINTPTR): Likewise, with uintptr_t.
6027
7fd47d5c
PE
6028 * lisp.h: Prefer 64-bit EMACS_INT if available.
6029 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6030 on 32-bit hosts that have 64-bit int, so that they can access
6031 large files.
122b0c86
PE
6032 However, temporarily disable this change unless the temporary
6033 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6034
8727937b
PE
6035 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6036
8ac068ac
PE
6037 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6038 This removes an assumption that EMACS_INT and long are the same
6039 width as pointers. The assumption is true for Emacs porting targets
6040 now, but we want to make other targets possible.
6041 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6042 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6043 In the rest of the code, change types of integers that hold casted
6044 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6045 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6046 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6047 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6048 No need to cast type when ORing.
6049 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6050 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6051 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6052 assume EMACS_INT is the same width as char *.
6053 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6054 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6055 Remove no-longer-needed casts.
6056 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6057 (xg_tool_bar_help_callback, xg_make_tool_item):
6058 Use EMACS_INTPTR to hold an integer
6059 that will be cast to void *; this can avoid a GCC warning
6060 if EMACS_INT is not the same width as void *.
6061 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6062 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6063 (current_message_1, set_message_1):
6064 Use a local to convert to proper width without a cast.
6065 * xmenu.c (dialog_selection_callback): Likewise.
6066
ede49d71
PE
6067 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6068 Also, don't assume VALBITS / RAND_BITS is less than 5,
6069 and don't rely on undefined behavior when shifting a 1 left into
6070 the sign bit.
6071 * lisp.h (get_random): Change signature to match.
6072
2f30ecd0
PE
6073 * lread.c (hash_string): Use size_t, not int, for hash computation.
6074 Normally we prefer signed values; but hashing is special, because
6075 it's better to use unsigned division on hash table sizes so that
6076 the remainder is nonnegative. Also, size_t is the natural width
6077 for hashing into memory. The previous code used 'int', which doesn't
6078 retain enough info to hash well into very large tables.
6079 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6080
2a866e7b
PE
6081 * dbusbind.c: Don't possibly lose pointer info when converting.
6082 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6083 Use XPNTR rather than XHASH, so that the high-order bits of
6084 the pointer aren't lost when converting through void *.
6085
51639eac
PE
6086 * eval.c (Fautoload): Don't double-shift a pointer.
6087
92394119
PE
6088 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6089
dbdb9a7c
JB
60902011-05-06 Juanma Barranquero <lekktu@gmail.com>
6091
6092 * gnutls.c (DEF_GNUTLS_FN):
6093 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6094
db7a0b4f
AS
60952011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6096
6097 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6098 marker. (Bug#8610)
6099
f7ff1b0f 61002011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6101
6102 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6103 New version that can reserve upto 2GB of heap space.
6104
f7ff1b0f 61052011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6106
6107 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6108
639c109b
TZ
61092011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6110
6111 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6112 `gnutls_certificate_set_x509_key_file'.
6113
d2127135
JB
61142011-05-05 Juanma Barranquero <lekktu@gmail.com>
6115
6116 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6117 Update dependencies.
6118
e968f4f3
JB
61192011-05-04 Juanma Barranquero <lekktu@gmail.com>
6120
6121 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6122 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6123 Remove unused parameter `fildes'.
6124 * process.c (read_process_output, send_process): Don't pass it.
6125
84d358f0
JB
61262011-05-04 Juanma Barranquero <lekktu@gmail.com>
6127
6128 Fix previous change: the library cache is defined in w32.c.
6129 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6130 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6131
0898ca10
JB
61322011-05-04 Juanma Barranquero <lekktu@gmail.com>
6133
6134 Implement dynamic loading of GnuTLS on Windows.
6135
6136 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6137 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6138 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6139 Declare.
6140
6141 * gnutls.c (Qgnutls_dll): Define.
6142 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6143 (gnutls_*): Declare function pointers.
6144 (init_gnutls_functions): New function to initialize function pointers.
6145 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6146 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6147 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6148 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6149 (emacs_gnutls_write, emacs_gnutls_read)
6150 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6151 (Fgnutls_available_p): New function.
6152 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6153 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6154 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6155
6156 * image.c: Include w32.h.
6157 (Vimage_type_cache): Delete.
6158 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6159 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6160 (w32_delayed_load): Move to w32.c.
6161
6162 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6163
6164 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6165 (w32_delayed_load): Move from image.c. When loading a library, record
6166 its filename in the :loaded-from property of the library id.
6167 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6168 Initialize and staticpro them.
6169 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6170
6171 * process.c: Include lisp.h before w32.h, not after.
6172 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6173 instead of gnutls_record_check_pending.
6174
6175 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6176
ff4de4aa
TZ
61772011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6178
6179 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6180 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6181 as passed in.
6182
abe95abb
JD
61832011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6184
6185 * xterm.c (x_set_frame_alpha): Do not set property on anything
6186 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6187
e16e55d4
JB
61882011-05-02 Juanma Barranquero <lekktu@gmail.com>
6189
6190 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6191
bafcf6a5
JB
61922011-05-02 Juanma Barranquero <lekktu@gmail.com>
6193
6194 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6195 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6196 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6197 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6198 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6199 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6200 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6201 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6202 (Qgnutls_bootprop_callbacks_verify): Make static.
6203
e7a6747f
AS
62042011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6205
19ed11ba
AS
6206 * callproc.c: Indentation fixup.
6207
e7a6747f 6208 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6209 (wait_for_termination, interruptible_wait_for_termination):
6210 Move after wait_for_termination_1.
e7a6747f 6211
1ef14cb4
LMI
62122011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6213
6214 * sysdep.c (interruptible_wait_for_termination): New function
6215 which is like wait_for_termination, but allows keyboard
6216 interruptions.
6217
6218 * callproc.c (Fcall_process): Add (:file "file") as an option for
6219 the STDOUT buffer.
6220 (Fcall_process_region): Ditto.
6221
330d880c
EZ
62222011-04-30 Eli Zaretskii <eliz@gnu.org>
6223
8db90b73
EZ
6224 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6225 rather than `XVECTOR (FOO)->size'.
6226
330d880c
EZ
6227 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6228 inttypes.h, as a gnulib replacement is used if it not available in
6229 system headers.
6230
15cbd324
EZ
62312011-04-21 Eli Zaretskii <eliz@gnu.org>
6232
6233 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6234 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6235 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6236
6237 * coding.c (coding_alloc_by_realloc): Error out if destination
6238 will grow beyond MOST_POSITIVE_FIXNUM.
6239 (decode_coding_emacs_mule): Abort if there isn't enough place in
6240 charbuf for the composition carryover bytes. Reserve an extra
6241 space for up to 2 characters produced in a loop.
6242 (decode_coding_iso_2022): Abort if there isn't enough place in
6243 charbuf for the composition carryover bytes.
6244
62452011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6246
ae940cca
EZ
6247 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6248 aborting when %lld or %lll format is passed.
6249 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6250 %llo or %llx format is passed. (Bug#8545)
6251
03ab8921
EZ
6252 * window.c (window_scroll_line_based): Use a marker instead of
6253 simple variables to record original value of point. (Bug#7952)
6254
afda1437
EZ
6255 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6256 produced by %s or %c overflows available buffer space. (Bug#8545)
6257
f76dee0c
PE
62582011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6259
6260 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6261 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6262
fdc5744d
JB
62632011-04-28 Juanma Barranquero <lekktu@gmail.com>
6264
6265 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6266
638f053a
JB
62672011-04-28 Juanma Barranquero <lekktu@gmail.com>
6268
6269 * keyboard.c (Qdelayed_warnings_hook): Define.
6270 (command_loop_1): Run `delayed-warnings-hook'
6271 if Vdelayed_warnings_list is non-nil.
6272 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6273 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6274
d178f871
EZ
62752011-04-28 Eli Zaretskii <eliz@gnu.org>
6276
6277 * doprnt.c (doprnt): Don't return value smaller than the buffer
6278 size if the message was truncated. (Bug#8545).
6279
b124fd93
JB
62802011-04-28 Juanma Barranquero <lekktu@gmail.com>
6281
6282 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6283 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6284
e810457d
PE
62852011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6286
6287 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6288
ea51cceb
JB
62892011-04-27 Juanma Barranquero <lekktu@gmail.com>
6290
6291 * makefile.w32-in: Update dependencies.
6292
94dcfacf
EZ
62932011-04-27 Eli Zaretskii <eliz@gnu.org>
6294
6295 Improve `doprnt' and its usage. (Bug#8545)
6296 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6297 `format_end'. Remove support for %l as a conversion specifier.
6298 Don't use xrealloc. Improve diagnostics when the %l size modifier
6299 is used. Update the commentary.
6300
6301 * eval.c (verror): Simplify calculation of size_t.
6302
6303 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6304 messages.
6305
f61f41d7
PE
63062011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6307
6308 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6309 change.
6310
96fb4434
PE
63112011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6312
6313 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6314 This makes this file independent of the recent pseudovector change.
6315
671875da 63162011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6317
69e9b5a3
PE
6318 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6319
b5f869a7 6320 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6321 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6322 Remove unused local.
c8926152 6323 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6324
841a1577 6325 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6326 GCC 4.6.0 optimizes based on type-based alias analysis.
6327 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6328 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6329 != &v->size, and therefore "v->size = 1; b->size = 2; return
6330 v->size;" must therefore return 1. This assumption is incorrect
6331 for Emacs, since it type-puns struct Lisp_Vector * with many other
6332 types. To fix this problem, this patch adds a new type struct
f904488f 6333 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6334 and pseudovectors, and helps optimizing compilers not get fooled
6335 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6336 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6337 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6338 the size member.
eab3844f
PE
6339 (XSETPVECTYPE): Rewrite in terms of new macro.
6340 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6341 This is a bit clearer, and further avoids the possibility of
6342 undesirable aliasing.
6343 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6344 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6345 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6346 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6347 (ASIZE): Now uses header.size rather than size.
6348 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6349 to avoid the hassle of writing XVECTOR (foo)->header.size.
6350 (struct vectorlike_header): New type.
eab3844f
PE
6351 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6352 object, to help avoid aliasing.
6353 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6354 (SUBRP): Likewise, since Lisp_Subr is a special case.
6355 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6356 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6357 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6358 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6359 changed to be "header.size" and "header.next".
6360 * buffer.h (struct buffer): Likewise.
6361 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6362 * frame.h (struct frame): Likewise.
6363 * process.h (struct Lisp_Process): Likewise.
6364 * termhooks.h (struct terminal): Likewise.
6365 * window.c (struct save_window_data, struct saved_window): Likewise.
6366 * window.h (struct window): Likewise.
6367 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6368 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6369 * buffer.c (init_buffer_once): Likewise.
6370 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6371 special case.
6372 * process.c (Fformat_network_address): Use local var for size,
6373 for brevity.
6374
0df1eac5
PE
6375 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6376
847ab9d1 6377 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6378 * data.c (atof): Remove decl; no longer used or needed.
6379 (digit_to_number): Move to lread.c.
6380 (Fstring_to_number): Use new string_to_number function, to be
6381 consistent with how the Lisp reader treats infinities and NaNs.
6382 Do not assume that floating-point numbers represent EMACS_INT
6383 without losing information; this is not true on most 64-bit hosts.
6384 Avoid double-rounding errors, by insisting on integers when
6385 parsing non-base-10 numbers, as the documentation specifies.
6386 * lisp.h (string_to_number): New decl, replacing ...
6387 (isfloat_string): Remove.
bc0a5c13 6388 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6389 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6390 appears to have been a coding error. Similarly, do not accept
6391 strings like +-1e0 as floating point numbers. Do not report
6392 overflow for integer overflows unless the base is not 10 which
6393 means we have no simple and reliable way to continue.
6394 Break out the floating-point parsing into a new
6395 function string_to_number, so that Fstring_to_number parses
6396 floating point numbers consistently with the Lisp reader.
04f2d78b 6397 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6398 (E_CHAR, EXP_INT): Remove, replacing with ...
6399 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6400 (string_to_number): New function, replacing isfloat_string.
6401 This function checks for valid syntax and produces the resulting
6402 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6403 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6404 so that overflow for non-base-10 numbers is reported only when
6405 there's no portable and simple way to convert to floating point.
452f4150 6406
67769ffc
PE
6407 * textprop.c (set_text_properties_1): Rewrite for clarity,
6408 and to avoid GCC warning about integer overflow.
6409
c20db43f
PE
6410 * intervals.h (struct interval): Use EMACS_INT for members
6411 where EMACS_UINT might cause problems. See
6412 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6413 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6414 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6415 All uses changed.
37aa2f85
PE
6416 (offset_intervals): Tell GCC not to worry about length overflow
6417 when negating a negative length.
c20db43f 6418
2538aa2f
PE
6419 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6420 (overrun_check_free): Likewise.
6421
f2d3008d
PE
6422 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6423 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6424 word size.
6425
ec8df744
PE
6426 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6427 (gnutls_make_error): Rename local to avoid shadowing.
6428 (gnutls_emacs_global_deinit): ifdef out; not used.
6429 (Fgnutls_boot): Use const for pointer to readonly storage.
6430 Comment out unused local. Fix pointer signedness problems.
6431
640ee02d
PE
6432 * lread.c (openp): Don't stuff size_t into an 'int'.
6433 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6434 about possible signed overflow.
6435
6048fb2a
PE
6436 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6437 (GDK_KEY_g): Don't define if already defined.
6438 (xg_prepare_tooltip): Avoid pointer signedness problem.
6439 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6440
fa3c87e1
PE
6441 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6442 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6443
2172544b
PE
6444 * xfns.c (Fx_window_property): Simplify a bit,
6445 to make a bit faster and to avoid GCC 4.6.0 warning.
6446 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6447
9b821a21
PE
6448 * fns.c (internal_equal): Don't assume size_t fits in int.
6449
3c616cfa
PE
6450 * alloc.c (compact_small_strings): Tighten assertion a little.
6451
c2982e87
PE
6452 Replace pEd with more-general pI, and fix some printf arg casts.
6453 * lisp.h (pI): New macro, generalizing old pEd macro to other
6454 conversion specifiers. For example, use "...%"pI"d..." rather
6455 than "...%"pEd"...".
6456 (pEd): Remove. All uses replaced with similar uses of pI.
6457 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6458 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6459 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6460 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6461 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6462 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6463 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6464 64-bit hosts.
6465 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6466 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6467 * print.c (safe_debug_print, print_object): Likewise.
6468 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6469 to int.
6f04d126
PE
6470 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6471 avoiding the 0 flag, which is not portable.
c2982e87
PE
6472 * process.c (Fmake_network_process): Use pI to avoid cast.
6473 * region-cache.c (pp_cache): Likewise.
6474 * xdisp.c (decode_mode_spec): Likewise.
6475 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6476 behavior on 64-bit hosts with printf arg.
6f04d126 6477 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6478 (x_stop_queuing_selection_requests): Likewise.
6479 (x_get_window_property): Don't truncate byte count to an 'int'
6480 when tracing.
0b432f21 6481
5e073ec7
PE
6482 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6483 here, since it parses constructs like leading '-' and spaces,
6484 which are not wanted; and it overflows with large numbers.
6485 Instead, simply match F[0-9]+, which is what is wanted anyway.
6486
36372bf9
PE
6487 * alloc.c: Remove unportable assumptions about struct layout.
6488 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6489 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6490 (allocate_vectorlike, make_pure_vector): Use the new macros,
6491 plus offsetof, to remove unportable assumptions about struct layout.
6492 These assumptions hold on all porting targets that I know of, but
6493 they are not guaranteed, they're easy to remove, and removing them
6494 makes further changes easier.
6495
0b432f21
PE
6496 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6497 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6498 (string_overrun_cookie): Now const. Use initializers that
6499 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6500 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6501 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6502 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6503 multiple of sizeof (EMACS_INT); it need not be, if
6504 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6505 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6506
895009e1
JB
65072011-04-26 Juanma Barranquero <lekktu@gmail.com>
6508
6509 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6510
6a7a1b0b
TZ
65112011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6512
6513 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6514 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6515 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6516
841a1577 65172011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6518
6519 * lisp.h (Qdebug): List symbol.
895009e1 6520 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6521 * keyboard.c (debug-on-event): New variable.
6522 (handle_user_signal): Break into debugger when debug-on-event
6523 matches the current signal symbol.
6524
f2d3ba6f
DN
65252011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6526
6527 * alloc.c (check_sblock, check_string_bytes)
6528 (check_string_free_list): Convert to standard C.
6529
42ce4c63
TZ
65302011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6531
6532 * w32.c (emacs_gnutls_push): Fix typo.
6533
825cd63c
EZ
65342011-04-25 Eli Zaretskii <eliz@gnu.org>
6535
fb11d64d
EZ
6536 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6537 "cast to pointer from integer of different size".
6538
825cd63c
EZ
6539 Improve doprnt and its use in verror. (Bug#8545)
6540 * doprnt.c (doprnt): Document the set of format control sequences
6541 supported by the function. Use SAFE_ALLOCA instead of always
6542 using `alloca'.
6543
6544 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6545 is one byte too soon. Don't use xrealloc; instead xfree and
6546 xmalloc anew.
6547
e061a11b
TZ
65482011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6549
6550 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6551 callbacks stage.
6552
6553 * gnutls.c: Renamed global_initialized to
6554 gnutls_global_initialized. Added internals for the
6555 :verify-hostname-error, :verify-error, and :verify-flags
6556 parameters of `gnutls-boot' and documented those parameters in the
6557 docstring. Start callback support.
9173deec
JB
6558 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6559 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6560 on error. Return error code.
e061a11b
TZ
6561 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6562 (emacs_gnutls_read): Likewise.
6563 (Fgnutls_boot): Return handshake error code.
6564 (emacs_gnutls_handle_error): New function.
6565 (wsaerror_to_errno): Likewise.
6566
6567 * w32.h (emacs_gnutls_pull): Add prototype.
6568 (emacs_gnutls_push): Likewise.
6569
6570 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6571 (emacs_gnutls_push): Likewise.
6572
65732011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6574
6575 * process.c (wait_reading_process_output): Check if GnuTLS
6576 buffered some data internally if no FDs are set for TLS
6577 connections.
6578
6579 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6580 (LIBS): Link to USER_LIBS.
6581 ($(BLD)/gnutls.$(0)): New target.
6582
fa6996bc
EZ
65832011-04-24 Eli Zaretskii <eliz@gnu.org>
6584
eb35682e
EZ
6585 * xdisp.c (handle_single_display_spec): Rename the
6586 display_replaced_before_p argument into display_replaced_p, to
6587 make it consistent with the commentary. Fix typos in the
6588 commentary.
6589
e2ad650c
EZ
6590 * textprop.c (syms_of_textprop): Remove dead code.
6591 (copy_text_properties): Delete obsolete commentary about an
6592 interface that was deleted long ago. Fix typos in the description
6593 of arguments.
6594
1b2de274
EZ
6595 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6596 to changes in oldXMenu/XMenu.h from 2011-04-16.
6597 <menu_help_message, prev_menu_help_message>: Constify.
6598 (IT_menu_make_room): menu->help_text is now `const char **';
6599 adjust.
6600
6601 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6602 to changes in oldXMenu/XMenu.h from 2011-04-16.
6603 (struct XMenu): Declare `help_text' `const char **'.
6604
6605 * xfaces.c <Qunspecified>: Make extern again.
6606
6607 * syntax.c: Include sys/types.h before including regex.h, as
6608 required by Posix.
6609
762b15be
EZ
6610 * doc.c (get_doc_string): Improve the format passed to `error'.
6611
6612 * doprnt.c (doprnt): Improve commentary.
6613
6614 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6615
6616 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6617 them with etags.
6618
f1052e5d
EZ
6619 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6620 changes in globals.h immediately force recompilation.
762b15be
EZ
6621 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6622 $(CURDIR)/s/ms-w32.h.
6623 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6624
fa6996bc
EZ
6625 * character.c (Fchar_direction): Function deleted.
6626 (syms_of_character): Don't defsubr it.
6627 <char-direction-table>: Deleted.
6628
e6c3da20
EZ
66292011-04-23 Eli Zaretskii <eliz@gnu.org>
6630
6631 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6632 * doprnt.c: Include limits.h.
6633 (SIZE_MAX): New macro.
04f2d78b
CB
6634 (doprnt): Return a size_t value. 2nd arg is now size_t.
6635 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6636 Improve overflow protection. Support `l' modifier for integer
6637 conversions. Support %l conversion. Don't assume an EMACS_INT
6638 argument for integer conversions and for %c.
6639
6640 * lisp.h (doprnt): Restore prototype.
6641
6642 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6643 $(SRC)/character.h.
6644
6645 * Makefile.in (base_obj): Add back doprnt.o.
6646
6647 * deps.mk (doprnt.o): Add back prerequisites.
6648 (callint.o): Depend on character.h.
6649
6650 * eval.c (internal_lisp_condition_case): Include the handler
6651 representation in the error message.
6652 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6653 when breaking from the loop.
6654
6655 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6656
6657 * callint.c (Fcall_interactively): When displaying error message
6658 about invalid control letter, pass the character's codepoint, not
6659 a pointer to its multibyte form. Improve display of the character
6660 in octal and display also its hex code.
6661
6662 * character.c (char_string): Use %x to display the (unsigned)
6663 codepoint of an invalid character, to avoid displaying a bogus
6664 negative value.
6665
6666 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6667 `error', not SYMBOL_NAME itself.
6668
6669 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6670 character arguments to `error'.
6671
6672 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6673 to `error' in error message about FINAL_CHAR argument. Make sure
6674 FINAL_CHAR is a character, and use %c when it is passed as
6675 argument to `error'.
6676
4ffd0d6b 66772011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6678
6679 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6680
6681 * w32.c: Include <time.h>.
6682 (sys_localtime): New function.
6683
4ffd0d6b 66842011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6685
6686 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6687
4ffd0d6b 6688 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6689
4ffd0d6b 66902011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6691
4ffd0d6b
GM
6692 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6693 zombies (Bug#8467).
aac0c6e3 6694
04c56954
EZ
66952011-04-19 Eli Zaretskii <eliz@gnu.org>
6696
6697 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6698 gl_state.e_property when gl_state.object is Qt.
6699
6700 * insdel.c (make_gap_larger): Remove limitation of buffer size
6701 to <= INT_MAX.
6702
16a43933
CY
67032011-04-18 Chong Yidong <cyd@stupidchicken.com>
6704
6705 * xdisp.c (lookup_glyphless_char_display)
6706 (produce_glyphless_glyph): Handle cons cell entry in
6707 glyphless-char-display.
6708 (Vglyphless_char_display): Document it.
6709
6710 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6711 glyphless-char-display.
6712
4581706e
CY
67132011-04-17 Chong Yidong <cyd@stupidchicken.com>
6714
6715 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6716
6717 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6718
6719 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6720 definition for no-X builds.
6721
4887c6e2 67222011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6723
fd35b6f9
PE
6724 Static checks with GCC 4.6.0 and non-default toolkits.
6725
5c1ccb01
PE
6726 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6727
006c5daa
PE
6728 * process.c (keyboard_bit_set): Define only if SIGIO.
6729 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6730 (send_process): Repair possible setjmp clobbering.
6731
efc736d3
PE
6732 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6733
4e2fe2e6
PE
6734 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6735
f97334a2
PE
6736 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6737
4e75f29d
PE
6738 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6739 Define only if needed.
6740
90efadd1
PE
6741 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6742 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6743 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6744
3c647824
PE
6745 * dispextern.h (struct redisplay_interface): Rename param
6746 to avoid shadowing.
e264f262 6747 * termhooks.h (struct terminal): Likewise.
761383f4 6748 * xterm.c (xembed_send_message): Likewise.
3c647824 6749
b58c5c4a
PE
6750 * insdel.c (make_gap_smaller): Define only if
6751 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6752
cad59032
PE
6753 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6754 it.
6755
c339dc2e
PE
6756 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6757 so that we aren't warned about unused symbols.
6758
91a3e27b
PE
6759 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6760
399c71d3 6761 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6762
8ffc96f5
PE
6763 * xfns.c (x_real_positions): Mark locals as initialized.
6764
eef9bc79
PE
6765 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6766
098db9dd
PE
6767 * xterm.c: Fix problems found by static analysis with other toolkits.
6768 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6769 (x_dispatch_event): Declare static if USE_GTK, and
6770 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6771 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6772 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6773 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6774 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6775
eb18f6cc
PE
6776 * xmenu.c (menu_help_callback): Pointer type fixes.
6777 Use const pointers when pointing at readonly data. Avoid pointer
6778 signedness clashes.
6779 (FALSE): Remove unused macro.
6780 (update_frame_menubar): Remove unused decl.
6781
1fe72bf8
PE
6782 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6783
60d9e1db
PE
6784 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6785 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6786 (single_menu_item): Rename local to avoid shadowing.
6787
39261c26
PE
6788 * keyboard.c (make_lispy_event): Remove unused local var.
6789
018c5e19
PE
6790 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6791 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6792
63d2b86e
PE
6793 * bitmaps: Change bitmaps from unsigned char back to the X11
6794 compatible char. Avoid the old compiler warnings about
6795 out-of-range initializers by using, for example, '\xab' rather
6796 than 0xab.
6797
aefd87e1
PE
6798 * xgselect.c (xgselect_initialize): Check vs interface
6799 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6800
bf501fb9
PE
6801 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6802
e9829fdf
PE
6803 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6804 to read-only memory.
6805
1086c095
PE
6806 * fns.c (vector): Remove; this old hack is no longer needed.
6807
2baccd04 6808 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6809 Remove unused var.
dde42981 6810 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6811
72391843 6812 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6813
436c16df 6814 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6815 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6816 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6817
92bb796d 6818 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6819 (x_term_init): Remove local to avoid shadowing.
92bb796d 6820
764430a3 6821 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6822
6823 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6824 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6825
d1dfb56c
EZ
68262011-04-16 Eli Zaretskii <eliz@gnu.org>
6827
c4354cb4
EZ
6828 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6829
d1dfb56c
EZ
6830 Fix regex.c, syntax.c and friends for buffers > 2GB.
6831 * syntax.h (struct gl_state_s): Declare character position members
6832 EMACS_INT.
6833
6834 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6835
04f2d78b
CB
6836 * textprop.c (verify_interval_modification, interval_of):
6837 Declare arguments EMACS_INT.
d1dfb56c
EZ
6838
6839 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6840 EMACS_INT.
6841
6842 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6843
6844 * indent.c (Fvertical_motion): Local variable it_start is now
6845 EMACS_INT.
6846
6847 * regex.c (re_match, re_match_2, re_match_2_internal)
6848 (bcmp_translate, regcomp, regexec, print_double_string)
6849 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6850 (re_compile_pattern, re_exec): Declare arguments and local
6851 variables `size_t' and `ssize_t' and return values `regoff_t', as
6852 appropriate.
6853 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6854 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6855 <compile_stack_type>: `size' and `avail' are now `size_t'.
6856
6857 * regex.h <regoff_t>: Use ssize_t, not int.
6858 (re_search, re_search_2, re_match, re_match_2): Arguments that
6859 specify buffer/string position and length are now ssize_t and
6860 size_t. Return type is regoff_t.
6861
613052cd
BK
68622011-04-16 Ben Key <bkey76@gmail.com>
6863
6864 * nsfont.m: Fixed bugs in ns_get_family and
6865 ns_descriptor_to_entity that were caused by using free to
6866 deallocate memory blocks that were allocated by xmalloc (via
6867 xstrdup). This caused Emacs to crash when compiled with
6868 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6869 --enable-checking=xmallocoverrun). xfree is now used to
6870 deallocate these memory blocks.
6871
4170f62f 68722011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6873
71b41406
PE
6874 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6875
9587a89d
PE
6876 emacs_write: Accept and return EMACS_INT for sizes.
6877 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6878 et seq.
6879 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6880 Accept and return EMACS_INT.
6881 (emacs_gnutls_write): Return the number of bytes written on
6882 partial writes.
6883 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6884 (emacs_read, emacs_write): Remove check for negative size, as the
6885 Emacs source code has been audited now.
9587a89d
PE
6886 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6887 (emacs_read, emacs_write): Use it.
273a5f82
PE
6888 * process.c (send_process): Adjust to the new signatures of
6889 emacs_write and emacs_gnutls_write. Do not attempt to store
6890 a byte offset into an 'int'; it might overflow.
9587a89d 6891 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6892
3e047f51
PE
6893 * sound.c: Don't assume sizes fit in 'int'.
6894 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6895 Return EMACS_INT, not int.
3e047f51 6896 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6897 Accept EMACS_INT, not int.
6898 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6899 record read return values.
6900
cc39a9db
BK
69012011-04-15 Ben Key <bkey76@gmail.com>
6902
c9d0ec6d
JB
6903 * keyboard.c (Qundefined): Don't declare static since it is used
6904 in nsfns.m.
6905 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6906 static since they are used in nsfont.m.
cc39a9db 6907
6c60eb9f
SM
69082011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6909
6910 * process.c (Qprocessp): Don't declare static.
6911 * lisp.h (Qprocessp): Declare again.
6912
7990b61a
JB
69132011-04-15 Juanma Barranquero <lekktu@gmail.com>
6914
6915 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6916
5d4cb038
PE
69172011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6918
8bd7b830 6919 Improve C-level modularity by making more things 'static'.
cd64ea1d 6920
e3b27b31
PE
6921 Don't publish debugger-only interfaces to other modules.
6922 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6923 (verify_bytepos, count_markers): Move decls to the only modules
6924 that need them.
6925 * region-cache.h (pp_cache): Likewise.
6926 * window.h (check_all_windows): Likewise.
6927 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6928
5d4cb038
PE
6929 * sysdep.c (croak): Now static, if
6930 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6931 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6932
6933 * alloc.c (refill_memory_reserve): Now static if
6934 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6935 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6936
e87b6180
PE
6937 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6938 Define only if USE_LUCID.
6939
ac64929e
PE
6940 * xrdb.c (x_customization_string, x_rm_string): Now static.
6941
6f37259d
PE
6942 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6943 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6944
1683e3ab
PE
6945 * xdisp.c (draw_row_with_mouse_face): Now static.
6946 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6947
de9c2632
PE
6948 * window.h (check_all_windows): Mark externally visible.
6949
2b96acb7
PE
6950 * window.c (window_deletion_count): Now static.
6951
6952 * undo.c: Make symbols static if they're not exported.
6953 (last_undo_buffer, last_boundary_position, pending_boundary):
6954 Now static.
6955
50436f33
PE
6956 * textprop.c (interval_insert_behind_hooks): Now static.
6957 (interval_insert_in_front_hooks): Likewise.
6958
64520e5c
PE
6959 * term.c: Make symbols static if they're not exported.
6960 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6961 (max_frame_lines, tty_set_terminal_modes):
6962 (tty_reset_terminal_modes, tty_turn_off_highlight):
6963 (get_tty_terminal): Now static.
6964 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6965 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6966 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6967 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6968 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6969
1fa53021
PE
6970 * sysdep.c: Make symbols static if they're not exported.
6971 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6972 Now static.
6973 (sigprocmask_set, full_mask): Remove; unused.
6974 (wait_debugging): Mark as visible.
6975 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6976 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6977
d4b43b22
PE
6978 * syntax.c (syntax_temp): Define only if !__GNUC__.
6979
b7c513d0
PE
6980 * sound.c (current_sound_device, current_sound): Now static.
6981
989b29ad
PE
6982 * search.c (searchbufs, searchbuf_head): Now static.
6983
13a55a78
PE
6984 * scroll.c (scroll_cost): Remove; unused.
6985 * dispextern.h (scroll_cost): Remove decl.
6986
de68a1fc
PE
6987 * region-cache.h (pp_cache): Mark as externally visible.
6988
40ccffa6
PE
6989 * process.c: Make symbols static if they're not exported.
6990 (process_tick, update_tick, create_process, chan_process):
6991 (Vprocess_alist, proc_buffered_char, datagram_access):
6992 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6993 (deactivate_process): Mark defn as static, as well as decl.
6994 * lisp.h (create_process): Remove decl.
6995 * process.h (chan_process, Vprocess_alist): Remove decls.
6996
ad64fc97
PE
6997 * print.c: Make symbols static if they're not exported.
6998 (print_depth, new_backquote_output, being_printed, print_buffer):
6999 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7000 (print_interval, print_number_index, initial_stderr_stream):
7001 Now static.
7002 * lisp.h (Fprinc): Remove decl.
7003 (debug_output_compilation_hack): Mark as externally visible.
7004
adddb265
PE
7005 * sysdep.c (croak): Move decl from here to syssignal.h.
7006 * syssignal.h (croak): Put it here, so the API can be checked when
7007 'croak' is called from dissociate_if_controlling_tty.
7008
1717ede2
PE
7009 * minibuf.c: Make symbols static if they're not exported.
7010 (minibuf_save_list, choose_minibuf_frame): Now static.
7011 * lisp.h (choose_minibuf_frame): Remove decl.
7012
fa5fb2bc
PE
7013 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7014
1e3890d1
PE
7015 * lread.c: Make symbols static if they're not exported.
7016 (read_objects, initial_obarray, oblookup_last_bucket_number):
7017 Now static.
7018 (make_symbol): Remove; unused.
7019 * lisp.h (initial_obarray, make_symbol): Remove decls.
7020
8a1414fa
PE
7021 * keyboard.c: Make symbols static if they're not exported.
7022 (single_kboard, recent_keys_index, total_keys, recent_keys):
7023 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7024 (this_single_command_key_start, echoing, last_auto_save):
7025 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7026 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7027 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7028 (Vlispy_mouse_stem, double_click_count):
7029 Now static.
7030 (force_auto_save_soon): Define only if SIGDANGER.
7031 (ignore_mouse_drag_p): Now static if
7032 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7033 (print_help): Remove; unused.
7034 (stop_character, last_timer_event): Mark as externally visible.
7035 * keyboard.h (ignore_mouse_drag_p): Declare only if
7036 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7037 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7038 * lisp.h (echoing): Remove decl.
7039 (force_auto_save_soon): Declare only if SIGDANGER.
7040 * xdisp.c (redisplay_window): Simplify code, to make it more
7041 obvious that ignore_mouse_drag_p is not accessed if !defined
7042 USE_GTK && !defined HAVE_NS.
7043
93ea6e8f
PE
7044 * intervals.c: Make symbols static if they're not exported.
7045 (merge_properties_sticky, merge_interval_right, delete_interval):
7046 Now static.
7047 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7048
77382fcc
PE
7049 * insdel.c: Make symbols static if they're not exported.
7050 However, leave prepare_to_modify_buffer alone. It's never
7051 called from outside this function, but that appears to be a bug.
7052 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7053 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7054 (adjust_after_replace_noundo): Remove; unused.
7055 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7056 (signal_before_change): Remove decls.
77382fcc 7057
9306c32e
PE
7058 * indent.c (val_compute_motion, val_vmotion): Now static.
7059
cd44d2eb
PE
7060 * image.c: Make symbols static if they're not exported.
7061 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7062 if USE_GTK.
7063 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7064 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7065
ad9a7a06
PE
7066 * fringe.c (standard_bitmaps): Now static.
7067 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7068
81626931
PE
7069 * frame.c: Make symbols static if they're not exported.
7070 (x_report_frame_params, make_terminal_frame): Now static.
7071 (get_frame_param): Now static, unless HAVE_NS.
7072 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7073 (x_get_resource_string): Remove; not used.
7074 * frame.h (make_terminal_frame, x_report_frame_params):
7075 (x_get_resource_string); Remove decls.
7076 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7077 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7078
239f9db9
PE
7079 * font.c, fontset.c: Make symbols static if they're not exported.
7080 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7081 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7082 * font.c (font_close_object): Now static.
7083 * font.h (font_close_object): Remove.
7084 * fontset.c (FONTSET_OBJLIST): Remove.
7085 (free_realized_fontset) #if-0 the body, which does nothing.
7086 (face_suitable_for_char_p): #if-0, as it's never called.
7087 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7088 * xfaces.c (face_at_string_position):
7089 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7090 since 0 is always ASCII.
7091
dfcf3579
PE
7092 * fns.c (weak_hash_tables): Now static.
7093
5045092b
PE
7094 * fileio.c: Make symbols static if they're not exported.
7095 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7096 (Vwrite_region_annotation_buffers): Now static.
7097
57a96f5c
PE
7098 * eval.c: Make symbols static if they're not exported.
7099 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7100 * lisp.h (backtrace_list): Remove decl.
7101
35f08c38
PE
7102 * emacs.c: Make symbols static if they're not exported.
7103 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7104 (fatal_error_code, fatal_error_signal_hook, standard_args):
7105 Now static.
7106 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7107 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7108 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7109 * lisp.h (fatal_error_signal_hook): Remove decl.
7110 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7111
f44bd759
PE
7112 * editfns.c: Move a (normally-unused) function to its only use.
7113 * editfns.c, lisp.h (get_operating_system_release): Remove.
7114 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7115 worth the hassle of breaking this out.
7116
b532497d
PE
7117 * xterm.c: Make symbols static if they're not exported.
7118 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7119 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7120 (x_destroy_window, x_delete_display):
7121 Now static.
7122 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7123 (x_mouse_leave): Remove; unused.
7124 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7125 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7126 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7127 Remove decls.
7128 (x_mouse_leave): Declare only if WINDOWSNT.
7129 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7130 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7131 USE_X_TOOLKIT.
7132
1675728f
PE
7133 * ftxfont.c: Make symbols static if they're not exported.
7134 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7135 HAVE_FREETYPE.
7136 * font.h (ftxfont_driver): Likewise.
7137
e4cebfca
PE
7138 * xfns.c: Make symbols static if they're not exported.
7139 (x_last_font_name, x_display_info_for_name):
7140 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7141 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7142 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7143 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7144 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7145 (last_show_tip_args): Now static.
7146 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7147 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7148 (x_screen_planes): Remove; unused.
7149 * dispextern.h (x_screen_planes): Remove decl.
7150
5bf46f05
PE
7151 * dispnew.c: Make symbols static if they're not exported.
7152 * dispextern.h (redraw_garbaged_frames, scrolling):
7153 (increment_row_positions): Remove.
7154 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7155 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7156 Now static.
7157 (redraw_garbaged_frames): Remove; unused.
7158
435f4c28
PE
7159 * xfaces.c: Make symbols static if they're not exported.
7160 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7161 Remove decls.
7162 * xterm.h (defined_color): Remove decls.
7163 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7164 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7165 (menu_face_changed_default, defined_color, free_realized_face):
7166 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7167 (ascii_face_of_lisp_face): Remove; unused.
7168
8524aef3
PE
7169 * xdisp.c: Make symbols static if they're not exported.
7170 * dispextern.h (scratch_glyph_row, window_box_edges):
7171 (glyph_to_pixel_coords, set_cursor_from_row):
7172 (get_next_display_element, set_iterator_to_next):
7173 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7174 (show_mouse_face): Remove decls
7175 * frame.h (message_buf_print): Likewise.
7176 * lisp.h (pop_message, set_message, check_point_in_composition):
7177 Likewise.
7178 * xterm.h (set_vertical_scroll_bar): Likewise.
7179 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7180 (message_buf_print, scratch_glyph_row, displayed_buffer):
7181 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7182 (get_next_display_element, show_mouse_face, window_box_edges):
7183 (frame_to_window_pixel_xy, check_point_in_composition):
7184 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7185 (glyph_to_pixel_coords): Remove; unused.
7186
16390cd2
PE
7187 * dired.c (file_name_completion): Now static.
7188
7189 * dbusbind.c (xd_in_read_queued_messages): Now static.
7190
a25f4dfa
PE
7191 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7192 * data.c (circular_list_error): Remove.
7193
14a9c8df
PE
7194 * commands.h (last_point_position, last_point_position_buffer):
7195 (last_point_position_window): Remove decls.
7196 * keyboard.c: Make these variables static.
7197
04f2d78b
CB
7198 * coding.h (coding, code_convert_region, encode_coding_gap):
7199 Remove decls.
74ab6df5
PE
7200 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7201 (iso_code_class, detect_coding, code_convert_region): Now static.
7202 (encode_coding_gap): Remove; unused.
7203
38dfbee1
PE
7204 * chartab.c (chartab_chars, chartab_bits): Now static.
7205
a2cb4e63
PE
7206 * charset.h (charset_iso_8859_1): Remove decl.
7207 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7208 Now static.
7209
127198fd
PE
7210 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7211 * ccl.c (Vccl_program_table): Now static.
7212 (check_ccl_update): Remove; unused.
7213
d85b608f
PE
7214 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7215 * category.h: ... from here.
7216 * category.c (check_category_table, set_category_set): Now static.
7217
31cd66f3
PE
7218 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7219 * lisp.h: Remove these decls.
7220
c358e587
PE
7221 * buffer.c (buffer_count): Remove unused var.
7222
e78aecca
PE
7223 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7224 so that it's not optimized away.
7225 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7226 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7227 exported only to the debugger.
7228
e192d7d3 7229 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7230 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7231
92470028
PE
7232 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7233 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7234 was inaccessible from Lisp.
7235 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7236 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7237
244ed907
PE
7238 alloc.c: Import and export fewer symbols, and remove unused items.
7239 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7240 is defined.
7241 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7242 it's not optimized away by whole-program optimization.
7243 (message_enable_multibyte, free_misc): Remove.
7244 (catchlist, handlerlist, mark_backtrace):
7245 Declare only if BYTE_MARK_STACK.
7246 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7247 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7248 (message_enable_multibyte): Remove decl.
7249 (free_misc, interval_free_list, float_block, float_block_index):
7250 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7251 (cons_free_list, last_marked_index):
7252 Now static.
7253 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7254 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7255 (mark_backtrace): Define only if BYTE_MARK_STACK.
7256 * xdisp.c (message_enable_multibyte): Now static.
7257
61c2b50e 7258 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7259 This makes it easier for human readers (and static analyzers)
7260 to see whether these variables are used from other modules.
7261 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7262 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7263 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7264 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7265 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7266 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7267 * xmenu.c, xselect.c:
7268 Declare Q* vars static if they are not used in other modules.
7269 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7270 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7271 Remove decls of unexported vars.
7272 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7273
95c82688
PE
7274 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7275
16a97296
PE
7276 Make Emacs functions such as Fatom 'static' by default.
7277 This makes it easier for human readers (and static analyzers)
7278 to see whether these functions can be called from other modules.
7279 DEFUN now defines a static function. To make the function external
7280 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7281 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7282 (Finit_image_library):
16a97296
PE
7283 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7284 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7285 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7286 Remove decls, since these functions are now static.
7287 (Funintern, Fget_internal_run_time): New decls, since these functions
7288 were already external.
95c82688 7289
16a97296
PE
7290 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7291 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7292 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7293 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7294 * keyboard.c, keymap.c, lread.c:
7295 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7296 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7297 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7298 Mark functions with DEFUE instead of DEFUN,
7299 if they are used in other modules.
7300 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7301 decls for now-static functions.
7302 * buffer.h (Fdelete_overlay): Remove decl.
7303 * callproc.c (Fgetenv_internal): Mark as internal.
7304 * composite.c (Fremove_list_of_text_properties): Remove decl.
7305 (Fcomposition_get_gstring): New forward static decl.
7306 * composite.h (Fcomposite_get_gstring): Remove decl.
7307 * dired.c (Ffile_attributes): New forward static decl.
7308 * doc.c (Fdocumntation_property): New forward static decl.
7309 * eval.c (Ffetch_bytecode): New forward static decl.
7310 (Funintern): Remove extern decl; now in .h file where it belongs.
7311 * fileio.c (Fmake_symbolic_link): New forward static decl.
7312 * image.c (Finit_image_library): New forward static decl.
7313 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7314 * intervals.h (Fprevious_property_change):
7315 (Fremove_list_of_text_properties): Remove decls.
7316 * keyboard.c (Fthis_command_keys): Remove decl.
7317 (Fcommand_execute): New forward static decl.
7318 * keymap.c (Flookup_key): New forward static decl.
7319 (Fcopy_keymap): Now static.
7320 * keymap.h (Flookup_key): Remove decl.
7321 * process.c (Fget_process): New forward static decl.
7322 (Fprocess_datagram_address): Mark as internal.
7323 * syntax.c (Fsyntax_table_p): New forward static decl.
7324 (skip_chars): Remove duplicate decl.
7325 * textprop.c (Fprevious_property_change): New forward static decl.
7326 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7327 Now internal.
7328 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7329 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7330
785bbd42
PE
7331 * editfns.c (Fformat): Remove unreachable code.
7332
8b913b57
AS
73332011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7334
7335 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7336 change. (Bug#8496)
7337
a6744a35
EZ
73382011-04-13 Eli Zaretskii <eliz@gnu.org>
7339
7340 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7341 when at ZV. (Bug#8487)
7342
e7974947
AS
73432011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7344
baad03f0
AS
7345 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7346 (Bug#8437)
7347 * keyboard.c (parse_tool_bar_item): Likewise.
7348 * sound.c (sound_cleanup, alsa_close): Likewise.
7349 * termcap.c (tgetent): Likewise.
7350 * xfns.c (x_default_font_parameter): Likewise.
7351 * xsettings.c (read_and_apply_settings): Likewise.
7352
e7974947
AS
7353 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7354 (overrun_check_free): Protoize.
7355
28272684
PE
73562011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7357
7358 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7359 since callers should never pass a negative size.
7360 Change the signature to match that of plain 'read' and 'write'; see
7361 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7362 * lisp.h: Update prototypes of emacs_write and emacs_read.
7363
11997c76
EZ
73642011-04-11 Eli Zaretskii <eliz@gnu.org>
7365
7366 * xdisp.c (redisplay_window): Don't try to determine the character
7367 position of the scroll margin if the window start point w->startp
e896f03c 7368 is outside the buffer's accessible region. (Bug#8468)
11997c76 7369
8a2cbd72
EZ
73702011-04-10 Eli Zaretskii <eliz@gnu.org>
7371
7372 Fix write-region and its subroutines for buffers > 2GB.
7373 * fileio.c (a_write, e_write): Modify declaration of arguments and
7374 local variables to support buffers larger than 2GB.
7375 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7376
7377 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7378 argument, local variables, and return value.
7379
7380 * lisp.h: Update prototypes of emacs_write and emacs_read.
7381
7382 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7383
4073e537 73842011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7385
1ebfdcb6
PE
7386 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7387
b2ded58d
PE
7388 Fix more problems found by GCC 4.6.0's static checks.
7389
7d66342c
PE
7390 * xdisp.c (vmessage): Use a better test for character truncation.
7391
bbf47d44
PE
7392 * charset.c (load_charset_map): <, not <=, for optimization,
7393 and to avoid potential problems with integer overflow.
9248994d 7394 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7395 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7396 * editfns.c (Fformat): Likewise.
1e69125e 7397 * syntax.c (skip_chars): Likewise.
3befa583 7398
e3019616
PE
7399 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7400 This also lets GCC 4.6.0 generate slightly better loop code.
7401
becfa255
PE
7402 * callint.c (Fcall_interactively): <, not <=, for optimization.
7403 (Fcall_interactively): Count the number of arguments produced,
7404 not the number of arguments given. This is simpler and lets GCC
7405 4.6.0 generate slightly better code.
7406
dae0cd48
PE
7407 * ftfont.c: Distingish more carefully between FcChar8 and char.
7408 The previous code passed unsigned char * to a functions like
7409 strlen and xstrcasecmp that expect char *, which does not
7410 conform to the C standard.
7411 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7412 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7413 char * when the C standard requires it.
7414
76032d70
PE
7415 * keyboard.c (read_char): Remove unused var.
7416
eb3f1cc8
PE
7417 * eval.c: Port to Windows vsnprintf (Bug#8435).
7418 Include <limits.h>.
7419 (SIZE_MAX): Define if the headers do not.
7420 (verror): Do not give up if vsnprintf returns a negative count.
7421 Instead, grow the buffer. This ports to Windows vsnprintf, which
7422 does not conform to C99. Problem reported by Eli Zaretskii.
7423 Also, simplify the allocation scheme, by avoiding the need for
7424 calling realloc, and removing the ALLOCATED variable.
7425
70476b54
PE
7426 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7427
12020a9e
PE
7428 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7429 But keep the doprint source code for now, as we might revamp it
7430 and use it again (Bug#8435).
ea6c7ae6
PE
7431 * lisp.h (doprnt): Remove.
7432 * Makefile.in (base_obj): Remove doprnt.o.
7433 * deps.mk (doprnt.o): Remove.
7434
5fdb398c
PE
7435 error: Print 32- and 64-bit integers portably (Bug#8435).
7436 Without this change, on typical 64-bit hosts error ("...%d...", N)
7437 was used to print both 32- and 64-bit integers N, which relied on
7438 undefined behavior.
7439 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7440 New macro.
7441 * lisp.h (error, verror): Mark as printf-like functions.
7442 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7443 Report overflow in size calculations when allocating printf buffer.
7444 Do not truncate output string at its first null byte.
7445 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7446 Truncate the output at a character boundary, since vsnprintf does not
7447 do that.
7448 * charset.c (check_iso_charset_parameter): Convert internal
7449 character to string before calling 'error', since %c now has the
7450 printf meaning.
7451 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7452 overflow when computing char to be passed to 'error'. Do not
7453 pass Lisp_Object to 'error'; pass the integer instead.
7454 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7455 formatted with plain %d.
7456
b189fa66
PE
7457 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7458
bff87ef0
PE
7459 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7460
7e2cac20
PE
7461 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7462
ce4d90b5
PE
7463 * xterm.c (x_catch_errors): Remove duplicate declaration.
7464
266c9547
PE
7465 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7466
79c49ad2
PE
7467 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7468
368f4090
JM
74692011-04-10 Jim Meyering <meyering@redhat.com>
7470
7471 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7472 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7473 return ssize_t not "int", and use size_t as the buffer length.
7474 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7475 * gnutls.h: Update declarations.
7476 * process.c (read_process_output): Use ssize_t, to match.
7477 (send_process): Likewise.
7478
a32d4040
CY
74792011-04-09 Chong Yidong <cyd@stupidchicken.com>
7480
7481 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7482
8546720e 74832011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7484
04f2d78b
CB
7485 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7486 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7487
8546720e
GM
7488 * xterm.c (handle_one_xevent):
7489 * xmenu.c (create_and_show_popup_menu):
7490 * xselect.c (x_decline_selection_request)
7491 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7492
0a2f5c1a 74932011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7494
7495 Fix some uses of `int' instead of EMACS_INT.
7496 * search.c (string_match_1, fast_string_match)
7497 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7498 (scan_buffer, find_next_newline_no_quit)
7499 (find_before_next_newline, search_command, Freplace_match)
7500 (Fmatch_data): Make some `int' variables be EMACS_INT.
7501
7502 * xdisp.c (display_count_lines): 3rd argument and return value now
7503 EMACS_INT. All callers changed.
7504 (pint2hrstr): Last argument is now EMACS_INT.
7505
7506 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7507 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7508 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7509 (decode_coding_utf_16, decode_coding_emacs_mule)
7510 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7511 (decode_coding_ccl, decode_coding_charset)
7512 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7513 (decode_coding_iso_2022, decode_coding_emacs_mule)
7514 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7515 <char_offset, last_offset>: Declare EMACS_INT.
7516 (encode_coding_utf_8, encode_coding_utf_16)
7517 (encode_coding_emacs_mule, encode_invocation_designation)
7518 (encode_designation_at_bol, encode_coding_iso_2022)
7519 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7520 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7521 Declare EMACS_INT.
7522 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7523 (encode_invocation_designation): Last argument P_NCHARS is now
7524 EMACS_INT.
7525 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7526 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7527
7528 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7529 All users changed.
7530
7531 * ccl.c (Fccl_execute_on_string): Declare some variables
7532 EMACS_INT.
7533
8546720e 75342011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7535
7536 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7537
4e19a977
CS
75382011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7539
7540 * process.c (Fformat_network_address): Doc fix.
7541
87302331
R
75422011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7543
ee7683eb 7544 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7545
cbb59342
CY
75462011-04-08 Chong Yidong <cyd@stupidchicken.com>
7547
7548 * keyboard.c (read_char): Call Lisp function help-form-show,
7549 instead of using internal_with_output_to_temp_buffer.
7550 (Qhelp_form_show): New var.
e0d38eeb 7551 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7552
7553 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7554
7555 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7556
e67a13ab
CY
75572011-04-06 Chong Yidong <cyd@stupidchicken.com>
7558
04f2d78b
CB
7559 * process.c (Flist_processes): Remove to Lisp.
7560 (list_processes_1): Delete.
e67a13ab 7561
973f782d
EZ
75622011-04-06 Eli Zaretskii <eliz@gnu.org>
7563
7c106b1e
EZ
7564 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7565
973f782d
EZ
7566 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7567
41cf7d1a 75682011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7569
ca23cc88
PE
7570 Fix more problems found by GCC 4.6.0's static checks.
7571
f390e2d5
PE
7572 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7573
42eea0d0
PE
7574 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7575
b69769da 7576 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7577
f9541e84
PE
7578 * xdisp.c (vmessage): Mark as a printf-like function.
7579
13841b55
PE
7580 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7581
c136c10f
PE
7582 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7583
5e2d4a30
PE
7584 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7585 printf-like functions.
7586 (tiff_load): Add casts to remove these marks before passing them
7587 to system-supplied API.
7588
583f48b9
PE
7589 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7590
b25d760e
PE
7591 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7592 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7593 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7594 directly, rather than having caller test rule sign. This avoids
7595 some unnecessary tests.
7596 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7597 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7598 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7599
bc7b6697 7600 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7601 (xfont_open): Avoid unnecessary tests.
bc7b6697 7602
27ccc379
PE
7603 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7604
dcd5c89a
PE
7605 * composite.h, composite.c (composition_gstring_put_cache):
7606 Use EMACS_INT, not int, for length.
7607
b13a45c6
PE
7608 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7609 breaking out part of COMPOSITION_DECODE_RULE.
7610 (COMPOSITION_DECODE_RULE): Use it.
7611 * composite.c (get_composition_id): Remove unused local vars,
7612 by using the new macro.
7613
1e792e4d
PE
7614 * textprop.c (set_text_properties_1): Change while to do-while,
7615 since the condition is always true at first.
7616
dc6c6455 7617 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7618 (interval_deletion_adjustment): Return unsigned value.
7619 All uses changed.
dc6c6455 7620
aba7731a
PE
7621 * process.c (list_processes_1, create_pty, read_process_output):
7622 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7623 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7624 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7625 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7626 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7627
fdfc4bf3
PE
7628 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7629
fca8fe46 7630 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7631 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7632
06a0259a 7633 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7634 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7635 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7636
e7b9e80f
PE
7637 * print.c (print_error_message): Avoid int overflow.
7638
56201685
PE
7639 * font.c (font_list_entities): Redo for clarity,
7640 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7641
78834453 7642 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7643 (font_score): Avoid potential overflow in diff calculation.
78834453 7644
0bc0b309 7645 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7646 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7647
e610eaca
PE
7648 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7649
b895abce
PE
7650 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7651 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7652 can always succeed if overflow has undefined behavior.
7653
1f1d9321 7654 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7655 (wordify): Omit three unnecessary tests.
1f1d9321 7656
c59478bc
PE
7657 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7658 All callers changed. This avoids the need for an unused var.
7659
79b73827
PE
7660 * casefiddle.c (casify_region): Remove var that is set but not used.
7661
a4db5dfe
PE
7662 * dired.c (file_name_completion): Remove var that is set but not used.
7663
43aae36e
PE
7664 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7665
2a47c44d 7666 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7667 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7668
a37c69bf
PE
7669 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7670 Check for integer overflow on size calculations.
7671
328ab8e7
PE
7672 * buffer.c (Fprevious_overlay_change): Remove var that is set
7673 but not used.
7674
e5a2a5cb
PE
7675 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7676 Remove vars that are set but not used.
8d84a6eb 7677 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7678 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7679
a60e5f68
PE
7680 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7681
f661cb61 7682 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7683 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7684
f0397f5a
PE
7685 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7686 that are set but not used.
7687
8664db06 7688 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7689 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7690
6abdaa4a
PE
7691 * xselect.c (x_get_local_selection, x_handle_property_notify):
7692 Remove vars that are set but not used.
7693
0ce7538d 7694 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7695 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7696
9ae848fc
PE
7697 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7698 Remove var that is set but not used.
0b918413
PE
7699 (scroll_bar_windows_size): Now size_t, not int.
7700 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7701 Check for overflow.
9ae848fc 7702
a5a62657
PE
7703 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7704 (map_tty_color) [!defined MSDOS]: Likewise.
7705
5c5cdd39
PE
7706 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7707
66ebf983
PE
7708 * coding.c: Remove vars that are set but not used.
7709 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7710 All callers changed.
7711 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7712 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7713 (decode_coding_charset): Remove vars that are set but not used.
7714
1be4d761
PE
7715 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7716 that is set but not used.
7717
47553fa8
PE
7718 * print.c (print_object): Remove var that is set but not used.
7719
1f7196bf 7720 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7721 The gnulib version avoids calling malloc in the usual case,
7722 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7723 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7724 * filelock.c (current_lock_owner): Likewise.
7725 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7726 * sysdep.c: Include allocator.h, careadlinkat.h.
7727 (emacs_no_realloc_allocator): New static constant.
7728 (emacs_readlink): New function.
fdb61804
PE
7729 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7730 ../lib/careadlinkat.h.
d1fdcab7 7731
f84c17c7
SM
77322011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7733
7734 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7735 first non-nil return value).
7736
ef3862ad
JD
77372011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7738
7739 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7740 if not defined (Bug#8403).
7741
376a7006
JB
77422011-04-02 Juanma Barranquero <lekktu@gmail.com>
7743
7744 * xdisp.c (display_count_lines): Remove parameter `start',
7745 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7746 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7747 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7748 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7749 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7750 and thereabouts. All callers changed.
7751 (get_per_char_metric): Remove parameter `f', unused since
7752 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7753
6ca3801d
JM
77542011-04-02 Jim Meyering <meyering@redhat.com>
7755
7756 do not dereference NULL upon failed strdup
7757 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7758 (ns_get_family): Likewise.
7759
d8e2b5ba
JB
77602011-04-02 Juanma Barranquero <lekktu@gmail.com>
7761
7762 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7763
8c74fcbd
JD
77642011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7765
7766 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7767 later (Bug#8403).
7768
7200d79c
SM
77692011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7770
03408648 7771 Add lexical binding.
7200d79c 7772
03408648
SM
7773 * window.c (Ftemp_output_buffer_show): New fun.
7774 (Fsave_window_excursion):
7775 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7776
7777 * lread.c (lisp_file_lexically_bound_p): New function.
7778 (Fload): Bind Qlexical_binding.
7779 (readevalloop): Remove `evalfun' arg.
7780 Bind Qinternal_interpreter_environment.
7781 (Feval_buffer): Bind Qlexical_binding.
7782 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7783 Mark as dynamic.
7784 (syms_of_lread): Declare `lexical-binding'.
7785
7786 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7787
7788 * keyboard.c (eval_dyn): New fun.
7789 (menu_item_eval_property): Use it.
ca105506
SM
7790
7791 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7792
03408648
SM
7793 * fns.c (concat, mapcar1): Accept byte-code-functions.
7794
7795 * eval.c (Fsetq): Handle lexical vars.
7796 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7797 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7798 (FletX, Flet): Obey lexical binding.
7799 (Fcommandp): Handle closures.
7800 (Feval): New `lexical' arg.
7801 (eval_sub): New function extracted from Feval. Use it almost
7802 everywhere where Feval was used. Look up vars in lexical env.
7803 Handle closures.
7804 (Ffunctionp): Move from subr.el.
7805 (Ffuncall): Handle closures.
7806 (apply_lambda): Remove `eval_flags'.
7807 (funcall_lambda): Handle closures and new byte-code-functions.
7808 (Fspecial_variable_p): New function.
7809 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7810 but without exporting it to Lisp.
23aba0ea 7811
23aba0ea 7812 * doc.c (Fdocumentation, store_function_docstring):
03408648 7813 * data.c (Finteractive_form): Handle closures.
23aba0ea 7814
03408648
SM
7815 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7816 interactive spec.
ba83908c 7817
04f2d78b
CB
7818 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7819 New byte-codes.
03408648
SM
7820 (exec_byte_code): New function extracted from Fbyte_code to handle new
7821 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7822
03408648 7823 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7824
03408648 7825 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7826
e2abce01
JB
78272011-03-31 Juanma Barranquero <lekktu@gmail.com>
7828
7829 * xdisp.c (redisplay_internal): Fix prototype.
7830
63696a73 78312011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7832
63696a73 7833 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7834 (try_scrolling): Use it when setting scroll_limit.
7835 Limit scrolling to 100 screen lines.
63696a73
EZ
7836 (redisplay_window): Even when falling back on "recentering",
7837 position point in the window according to scroll-conservatively,
7838 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7839
7840 (try_scrolling): When point is above the window, allow searching
7841 as far as scroll_max, or one screenful, to compute vertical
7842 distance from PT to the scroll margin position. This prevents
7843 try_scrolling from unnecessarily failing when
7844 scroll-conservatively is set to a value slightly larger than the
7845 window height. Clean up the case of PT below the margin at bottom
7846 of window: scroll_max can no longer be INT_MAX. When aggressive
7847 scrolling is in use, don't let point enter the opposite scroll
7848 margin as result of the scroll.
7849 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7850 threshold of 100 lines for never-recentering scrolling.
7851
e4cc2dfc
JB
78522011-03-31 Juanma Barranquero <lekktu@gmail.com>
7853
7854 * dispextern.h (move_it_by_lines):
7855 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7856 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7857 (message_log_check_duplicate): Remove parameters `prev_bol' and
7858 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7859 (redisplay_internal): Remove parameter `preserve_echo_area',
7860 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7861
7862 * indent.c (Fvertical_motion):
7863 * window.c (window_scroll_pixel_based, Frecenter):
7864 Don't pass `need_y_p' to `move_it_by_lines'.
7865
1c470562
SM
78662011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7867
44f230aa
SM
7868 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7869 steal a few bits to be more compact.
7870 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7871 Remove unneeded casts.
7872
1c470562
SM
7873 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7874
888adce9
ZK
78752011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7876
7877 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7878 binding" message (bug#7967).
7879
f838ed7b
PE
78802011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7881
77861b95
PE
7882 Fix more problems found by GCC 4.6.0's static checks.
7883
de6dbc14
PE
7884 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7885 Remove unused local var.
7886
f838ed7b
PE
7887 * editfns.c (Fmessage_box): Remove unused local var.
7888
792c7b2b
PE
7889 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7890 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7891 Omit unused local vars.
c499e557 7892 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7893 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7894 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7895 Omit unused local var.
7896
ba0165e1
PE
7897 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7898 Don't assume string length fits in int.
32ad8845 7899 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7900 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7901
3c59b4c9
PE
7902 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7903 instead of alloca (Bug#8344).
7904
a3eed478 7905 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7906 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7907
eb4d412d
PE
7908 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7909
1658b401
PE
7910 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7911 concerns.
7912
7913 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7914
7915 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7916
9a2c6e05
PE
7917 * keyboard.c (syms_of_keyboard): Use the same style as later
7918 in this function when indexing through an array. This also
7919 works around GCC bug 48267.
7920
03d0a109
PE
7921 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7922
44f730c8
PE
7923 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7924
fe75f926
PE
7925 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7926 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7927
ffa8c828
PE
7928 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7929 This avoids undefined behavior on integer overflow, and is a bit
7930 more convenient anyway since it is compared to a size_t variable.
7931
c5101a77
PE
7932 Variadic C functions now count arguments with size_t, not int.
7933 This avoids an unnecessary limitation on 64-bit machines, which
7934 caused (substring ...) to crash on large vectors (Bug#8344).
7935 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7936 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7937 All variadic functions and their callers changed accordingly.
c5101a77
PE
7938 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7939 * data.c (arith_driver, float_arith_driver): Likewise.
7940 * editfns.c (general_insert_function): Likewise.
7941 * eval.c (struct backtrace.nargs, interactive_p)
7942 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7943 (funcall_lambda, mark_backtrace): Likewise.
7944 * fns.c (concat): Likewise.
7945 * frame.c (x_set_frame_parameters): Likewise.
7946 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7947 0 if not found, not -1. All callers changed.
7948
dd3f25f7
PE
7949 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7950 (stack_copy_size): Now size_t, not int.
7951 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7952
461c2ab9
JB
79532011-03-28 Juanma Barranquero <lekktu@gmail.com>
7954
7955 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7956 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7957 All callers changed.
7958
7959 * lisp.h (multibyte_char_to_unibyte):
7960 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7961 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7962 * character.h (CHAR_TO_BYTE8):
7963 * cmds.c (internal_self_insert):
7964 * editfns.c (general_insert_function):
7965 * keymap.c (push_key_description):
7966 * search.c (Freplace_match):
7967 * xdisp.c (message_dolog, set_message_1): All callers changed.
7968
f6d62986
SM
79692011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7970
7971 * keyboard.c (safe_run_hook_funcall): New function.
7972 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7973 don't set the hook to nil, but remove the offending function instead.
7974 (Qcommand_hook_internal): Remove, unused.
7975 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7976 Vcommand_hook_internal.
7977
7978 * eval.c (enum run_hooks_condition): Remove.
7979 (funcall_nil, funcall_not): New functions.
7980 (run_hook_with_args): Call each function through a `funcall' argument.
7981 Remove `cond' argument, now redundant.
7982 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7983 (Frun_hook_with_args_until_failure): Adjust accordingly.
7984 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7985
1db5b1ad
JB
79862011-03-28 Juanma Barranquero <lekktu@gmail.com>
7987
7988 * dispextern.h (string_buffer_position): Remove declaration.
7989
7990 * print.c (strout): Remove parameter `multibyte', unused since
7991 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7992
7993 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7994 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7995 All callers changed.
7996
7997 * w32.c (_wsa_errlist): Use braces for struct initializers.
7998
7999 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8000 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8001 All callers changed.
8002 (string_buffer_position): Likewise. Also, make static (it's never
8003 used outside xdisp.c).
8004 (cursor_row_p): Remove parameter `w', unused since
8005 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8006 (decode_mode_spec): Remove parameter `precision', introduced during
8007 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8008 All callers changed.
8009
5ffb62aa
JD
80102011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8011
8012 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8013
461c2ab9 80142011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8015
8016 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8017 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8018 (ns_update_auto_hide_menu_bar): New functions.
8019 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8020 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8021 ns_constrain_all_frames.
8022 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8023 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8024
5c380ffb
JD
80252011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8026
8027 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8028
9af30bdf
GM
80292011-03-27 Glenn Morris <rgm@gnu.org>
8030
8031 * syssignal.h: Replace RETSIGTYPE with void.
8032 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8033 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8034 Replace SIGTYPE with void everywhere.
8035 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8036 * s/template.h (SIGTYPE): Remove commented out definition.
8037
e2abce01
JB
80382011-03-26 Eli Zaretskii <eliz@gnu.org>
8039
8040 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8041 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8042
f868cd8a
JB
80432011-03-26 Juanma Barranquero <lekktu@gmail.com>
8044
59eb0929
JB
8045 * w32.c (read_unc_volume): Use parameter `henum', instead of
8046 global variable `wget_enum_handle'.
8047
8048 * keymap.c (describe_vector): Remove parameters `indices' and
8049 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8050 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8051
f868cd8a
JB
8052 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8053
8054 * keyboard.c (timer_check): Remove parameter `do_it_now',
8055 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8056 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8057 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8058
8059 * keyboard.c (read_char):
8060 * w32menu.c (w32_menu_display_help):
8061 * xmenu.c (show_help_event, menu_help_callback):
8062 Adjust calls to `show_help_echo'.
8063
8064 * gtkutil.c (xg_maybe_add_timer):
8065 * keyboard.c (readable_events):
8066 * process.c (wait_reading_process_output):
8067 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8068
8069 * insdel.c (adjust_markers_gap_motion):
8070 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8071 (gap_left, gap_right): Don't call it.
8072
2ecf6fdb
CY
80732011-03-25 Chong Yidong <cyd@stupidchicken.com>
8074
8075 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8076 incurred during fontification.
8077
6b1f9ba4
JB
80782011-03-25 Juanma Barranquero <lekktu@gmail.com>
8079
8080 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8081 (DEFVAR_PER_BUFFER): Don't pass it.
8082
8083 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8084 (scrolling_window): Don't pass it.
8085
0f4a96b5
JB
80862011-03-25 Juanma Barranquero <lekktu@gmail.com>
8087
8088 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8089
8090 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8091 and `suffix'.
8092 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8093 of variables specific to SELinux and computation of `encoded_absname'.
8094
8095 * image.c (XPutPixel): Remove unused variable `height'.
8096
8097 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8098
8099 * unexw32.c (get_section_info): Remove unused variable `section'.
8100
8101 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8102 (system_process_attributes): Remove unused variable `sess'.
8103 (sys_read): Remove unused variable `err'.
8104
8105 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8106 (w32_wnd_proc): Remove unused variable `isdead'.
8107 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8108 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8109 (x_create_tip_frame): Remove unused variable `tem'.
8110
8111 * w32inevt.c (w32_console_read_socket):
8112 Remove unused variable `no_events'.
8113
8114 * w32term.c (x_draw_composite_glyph_string_foreground):
8115 Remove unused variable `width'.
8116
1149507c
JB
81172011-03-24 Juanma Barranquero <lekktu@gmail.com>
8118
8119 * w32term.c (x_set_glyph_string_clipping):
8120 Don't pass uninitialized region to CombineRgn.
8121
9c88f339
JB
81222011-03-23 Juanma Barranquero <lekktu@gmail.com>
8123
8124 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8125 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8126 (Fx_close_connection): Remove unused variable `i'.
8127
8128 * w32font.c (w32font_draw): Return number of glyphs.
8129 (w32font_open_internal): Remove unused variable `i'.
8130 (w32font_driver): Add missing initializer.
8131
8132 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8133 (fill_in_menu): Remove unused variable `items_added'.
8134
8135 * w32term.c (last_mouse_press_frame): Remove static global variable.
8136 (w32_clip_to_row): Remove unused variable `f'.
8137 (x_delete_terminal): Remove unused variable `i'.
8138
8139 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8140 (NOTHING): Remove unused static global variable.
8141 (uniscribe_check_otf): Remove unused variable `table'.
8142 (uniscribe_font_driver): Add missing initializers.
8143
dee091a3
JD
81442011-03-23 Julien Danjou <julien@danjou.info>
8145
8146 * term.c (Fsuspend_tty, Fresume_tty):
8147 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8148 * window.c (temp_output_buffer_show):
8149 * insdel.c (signal_before_change):
8150 * frame.c (Fhandle_switch_frame):
8151 * fileio.c (Fdo_auto_save):
8152 * emacs.c (Fkill_emacs):
8153 * editfns.c (save_excursion_restore):
8154 * cmds.c (internal_self_insert):
8155 * callint.c (Fcall_interactively):
8156 * buffer.c (Fkill_all_local_variables):
8157 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8158 Use Frun_hooks.
0f4a96b5 8159 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8160 unconditionally since it does the check itself.
dee091a3 8161
2c520ab5 81622011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8163
c9c49752
PE
8164 Fix more problems found by GCC 4.5.2's static checks.
8165
8abc3f12
PE
8166 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8167 the first time through the loop, since we know p0 < p1 then.
8168 This also avoids a gcc -Wstrict-overflow warning.
8169
a2d26660
PE
8170 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8171 leading to a memory leak, possible in functions like
8172 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8173 of objects (Bug#8318).
a2d26660 8174
916c72e9
PE
8175 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8176 that could (at least in theory) be that large.
8177
19ab8a18
PE
8178 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8179 This is less likely to overflow, and avoids undefined behavior if
8180 overflow does occur. All callers changed. Use strtoul to scan
8181 for the unsigned long integer.
b7cbbd6f
PE
8182 (pint2hrstr): Simplify and tune code slightly.
8183 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8184
f0641eff
PE
8185 * scroll.c (do_scrolling): Work around GCC bug 48228.
8186 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8187
7f650bb9
PE
8188 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8189 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8190 (validate_x_resource_name): Simplify count usage.
8191 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8192
37dd57d1
PE
8193 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8194 fail (Bug#8306).
81e56e61 8195
699979fc 8196 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8197
401bf9b4
PE
8198 * process.c (Fmake_network_process): Use socklen_t, not int,
8199 where POSIX says socklen_t is required in portable programs.
8200 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8201 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8202 (Fmake_network_process, server_accept_connection):
8203 (wait_reading_process_output, read_process_output):
8204 Likewise.
8205
b93aacde
PE
8206 * process.c: Rename or move locals to avoid shadowing.
8207 (list_processes_1, Fmake_network_process):
8208 (read_process_output_error_handler, exec_sentinel_error_handler):
8209 Rename or move locals.
4dc343ee 8210 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8211 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8212 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8213 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8214 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8215
af8a867c 8216 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8217 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8218 Include tparam.h instead, since it declares them.
af8a867c
PE
8219 * cm.h (PC): Remove extern decl; tparam.h now does this.
8220 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8221 * terminfo.c: Include tparam.h, to check interfaces.
8222 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8223 (tparam): Adjust signature to match interface in tparam.h;
8224 this removes some undefined behavior. Check that outstring and len
8225 are zero, which they always are with Emacs.
8226 * tparam.h (PC, BC, UP): New extern decls.
8227
0248044d 8228 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8229 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8230
8ff096c1 8231 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8232 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8233 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8234 (ftfont_list): Remove unused local.
49eaafba
PE
8235 (get_adstyle_property, ftfont_pattern_entity):
8236 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8237 Rename locals to avoid shadowing.
8ff096c1 8238
e2be39f6
PE
8239 * xfont.c (xfont_list_family): Mark var as initialized.
8240
c9735e30
PE
8241 * xml.c (make_dom): Now static.
8242
8f5201ae
PE
8243 * composite.c (composition_compute_stop_pos): Rename local to
8244 avoid shadowing.
b246f932
PE
8245 (composition_reseat_it): Remove unused locals.
8246 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8247 (composition_update_it): Mark var as initialized.
11b61122
PE
8248 (find_automatic_composition): Mark vars as initialized,
8249 with a FIXME (Bug#8290).
8f5201ae 8250
760fbc2c
PE
8251 character.h: Rename locals to avoid shadowing.
8252 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8253 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8254 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8255 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8256 to avoid shadowing.
8257
ff08eb85
PE
8258 * textprop.c (property_change_between_p): Remove; unused.
8259
fc7bf025
PE
8260 * intervals.c (interval_start_pos): Now static.
8261
235d7abc
PE
8262 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8263
44f230aa
SM
8264 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8265 Rename locals to avoid shadowing.
3e7d6594 8266
50060332
PE
8267 * sound.c (wav_play, au_play, Fplay_sound_internal):
8268 Fix pointer signedness.
d01f234b 8269 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8270 (wav_play): Initialize a variable to 0, to prevent undefined
8271 behavior (Bug#8278).
50060332 8272
c4fc4e30
PE
8273 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8274
918436ed
PE
8275 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8276
c939f91b
PE
8277 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8278 clobbering (Bug#8298).
b9c7f648
PE
8279 * sysdep.c (sys_subshell): Likewise.
8280 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8281
6bd8c144
PE
8282 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8283 This should get cleaned up, so that child_setup has the
8284 same signature on all platforms.
8285
7710357c 8286 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8287 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8288
c59da222
CY
82892011-03-22 Chong Yidong <cyd@stupidchicken.com>
8290
8291 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8292 not to be necessary, and produces flickering.
8293
66b87493
GM
82942011-03-20 Glenn Morris <rgm@gnu.org>
8295
8296 * config.in: Remove file.
8297
45b6f6d5
JB
82982011-03-20 Juanma Barranquero <lekktu@gmail.com>
8299
8300 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8301 are now in src/globals.h.
8302 (syms_of_minibuf): Remove spurious & from previous change.
8303
3ec03f7e
LL
83042011-03-20 Leo <sdl.web@gmail.com>
8305
8306 * minibuf.c (completing-read-function): New variable.
8307 (completing-read-default): Rename from completing-read.
8308 (completing-read): Call completing-read-function.
8309
b14e3e21
CY
83102011-03-19 Juanma Barranquero <lekktu@gmail.com>
8311
8312 * xfaces.c (Fx_load_color_file):
8313 Read color file from absolute filename (bug#8250).
8314
f2b726e6
JB
83152011-03-19 Juanma Barranquero <lekktu@gmail.com>
8316
8317 * makefile.w32-in: Update dependencies.
8318
09f6ff02
EZ
83192011-03-17 Eli Zaretskii <eliz@gnu.org>
8320
8321 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8322
29a6015a
PE
83232011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8324
a3a6c54e
PE
8325 Fix more problems found by GCC 4.5.2's static checks.
8326
b766f867
PE
8327 * process.c (make_serial_process_unwind, send_process_trap):
8328 (sigchld_handler): Now static.
8329
be02381c
PE
8330 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8331 That way, the code declares only the vars that it needs.
8332 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8333 * s/cygwin.h (PTY_ITERATION): Likewise.
8334 * s/darwin.h (PTY_ITERATION): Likewise.
8335 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8336
57048744
PE
8337 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8338 * process.c (allocate_pty): Don't declare stb unless it's needed.
8339
7914961c 8340 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8341 (CONSTANTLIM): Remove; unused.
8342 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8343 Define only if needed.
7914961c 8344
b3967b18
PE
8345 * unexelf.c (unexec): Name an expression,
8346 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8347 Use a different way to cause a compilation error if anyone uses
8348 n rather than nn, a way that does not involve shadowing.
73366a00 8349 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8350
29a6015a
PE
8351 * deps.mk (unexalpha.o): Remove; unused.
8352
43cfc33e 8353 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8354 * unexec.h: New file.
ce701a33
PE
8355 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8356 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8357 Depend on unexec.h.
8358 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8359 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8360 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8361 Change as necessary to match prototype in unexec.h.
ce701a33 8362
01f44d5a
PE
8363 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8364 shadowing.
4f63c6bb 8365 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8366
a6670b0b
PE
8367 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8368 Rename locals to avoid shadowing.
8369
cef2010d 8370 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8371 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8372
d4d7173a
PE
8373 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8374
f08b802a
PE
8375 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8376 warning when compiling print.c.
8377
3ddb0639
PE
8378 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8379 instead of using an uninitialized var.
5ad03b97 8380 (font_sort_entities): Mark var as initialized.
3ddb0639 8381
170a2692
PE
8382 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8383
e663c700
PE
8384 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8385 pointers to constants.
89bc529a 8386 (font_parse_fcname): Remove unused vars.
7b81e2d0 8387 (font_delete_unmatched): Now static.
ea838e10 8388 (font_get_spec): Remove; unused.
13a547c6
PE
8389 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8390 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8391 Rename or move locals to avoid shadowing.
e663c700 8392
2a80c887 8393 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8394 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8395
1384fa33 8396 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8397 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8398
8b2c52e9
PE
8399 * alloc.c (mark_backtrace): Move decl from here ...
8400 * lisp.h: ... to here, so that it can be checked.
8401
475545b5 8402 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8403 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8404 (lisp_indirect_variable): Name an expression,
8405 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8406 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8407
b1349114 8408 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8409 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8410 Use const pointer when appropriate.
b1349114 8411
a2928364
PE
8412 * lisp.h (get_system_name, get_operating_system_release):
8413 Move decls here, to check interfaces.
8414 * process.c (get_operating_system_release): Move decl to lisp.h.
8415 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8416 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8417 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8418 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8419 (Fformat_time_string, Fencode_time, Finsert_char):
8420 (Ftranslate_region_internal, Fformat):
8421 Rename or remove local vars to avoid shadowing.
9710023e 8422 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8423
a415e694
PE
8424 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8425 avoid shadowing.
8426
8ef4622d
PE
8427 * lisp.h (eassert): Check that the argument compiles, even if
8428 ENABLE_CHECKING is not defined.
8429
946f9a5b
PE
8430 * data.c (Findirect_variable): Name an expression, to avoid
8431 gcc -Wbad-function-cast warning.
112396d6 8432 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8433 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8434 (Fmake_variable_buffer_local, Fmake_local_variable):
8435 Mark variables as initialized.
52746918 8436 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8437
e5aab7e7 8438 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8439 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8440 Rename locals to avoid shadowing.
dff45157
PE
8441 (mark_stack): Move local variables into the #ifdef region where
8442 they're used.
7bc26fdb
PE
8443 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8444 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8445 needed otherwise.
8446 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8447 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8448 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8449
e5aab7e7
PE
8450 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8451 avoids undefined behavior in theory.
8452
4da60324
PE
8453 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8454
88043301
PE
8455 Use functions, not macros, for up- and down-casing (Bug#8254).
8456 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8457 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8458 to use the following functions instead of these macros.
8459 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8460 EMACS_INT, since callers assume the returned value fits in int.
8461 (upcase1): Likewise, for UPCASE_TABLE.
8462 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8463 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8464 the race-condition problem in the old DOWNCASE.
88043301 8465
19ed5445
PE
8466 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8467 Rename locals to avoid shadowing.
8468 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8469 (regex_compile, re_search_2, re_match_2_internal):
8470 Remove unused local vars.
952db0d7
PE
8471 (FREE_VAR): Rewrite so as not to use empty "else",
8472 which gcc can warn about.
da053e48 8473 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8474 (RETALLOC_IF): Define only if needed.
8475 (WORDCHAR_P): Likewise. This one is never needed, but is used
8476 only in a comment talking about a compiler bug, so put inside
8477 the #if 0 of that comment.
8478 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8479 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8480 Remove; unused.
19ed5445 8481
1f3561e4 8482 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8483 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8484 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8485
ded6f8f7
PE
8486 * search.c (simple_search): Remove unused var.
8487
dbd37a95
PE
8488 * dired.c (compile_pattern): Move decl from here ...
8489 * lisp.h: ... to here, so that it can be checked.
8490 (struct re_registers): New forward decl.
8491
7e47afad
PE
8492 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8493
85f24f61
PE
8494 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8495 All uses changed.
8496 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8497 Rename locals to avoid shadowing.
5671df8f 8498 (Fvertical_motion): Mark locals as initialized.
85f24f61 8499
181aa2be 8500 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8501 (casify_region): Mark local as initialized.
181aa2be 8502
930d429c
PE
8503 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8504
7082eac6
PE
8505 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8506 New macros, so that the caller can use some names other than
8507 gcpro1, gcpro2, etc.
8508 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8509 of the new macros.
8510 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8511 argument, for consistency with GCPRO2_VAR, etc: it is now the
8512 prefix of the variable, not the variable itself. All uses
8513 changed.
38b2c076
PE
8514 * dired.c (directory_files_internal, file_name_completion):
8515 Rename locals to avoid shadowing.
8516
15206ed9
PE
8517 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8518 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8519 dired.c's scmp function, had undefined behavior.
8520 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8521 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8522 * buffer.h: ... to here, because these macros use current_buffer,
8523 and the new implementation with inline functions needs to have
8524 current_buffer in scope now, rather than later when the macros
8525 are used.
8526 (downcase, upcase1): New static inline functions.
8527 (DOWNCASE, UPCASE1): Reimplement using these functions.
8528 This avoids undefined behavior in expressions like
8529 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8530 from race conditions in accessing the global variables
8531 case_temp1 and case_temp2.
8532 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8533 * lisp.h (case_temp1, case_temp2): Remove their decls.
8534 * character.h (ASCII_CHAR_P): Move from here ...
8535 * lisp.h: ... to here, so that the inline functions mentioned
8536 above can use them.
8537
4a6bea26
PE
8538 * dired.c (directory_files_internal_unwind): Now static.
8539
f14b7e14
PE
8540 * fileio.c (file_name_as_directory, directory_file_name):
8541 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8542 Now static.
2893f146
PE
8543 (file_name_as_directory): Use const pointers when appropriate.
8544 (Fexpand_file_name): Likewise. In particular, newdir might
8545 point at constant storage, so make it a const pointer.
fd4ead52 8546 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8547 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8548 signedness issues.
f839df0c
PE
8549 (Fset_file_times, Finsert_file_contents, auto_save_error):
8550 Rename locals to avoid shadowing.
f14b7e14 8551
5716756e 8552 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8553 (Ftry_completion, Fall_completions): Rename or remove locals
8554 to avoid shadowing.
5716756e 8555
b4c3046a
PE
8556 * marker.c (bytepos_to_charpos): Remove; unused.
8557
b45db522
PE
8558 * lisp.h (verify_bytepos, count_markers): New decls,
8559 so that gcc does not warn that these functions aren't declared.
8560
85876d07
PE
8561 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8562 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8563 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8564 (copy_text): Remove unused local var.
85876d07 8565
03d78a21 8566 * filelock.c (within_one_second): Now static.
b3dd38ab 8567 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8568
5df8f01b
PE
8569 * buffer.c (fix_overlays_before): Mark locals as initialized.
8570 (fix_start_end_in_overlays): Likewise. This function should be
8571 simplified by using pointers-to-pointers, but that's a different
8572 matter.
b1d876f1 8573 (switch_to_buffer_1): Now static.
8f54f30a
PE
8574 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8575 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8576
a70072c9 8577 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8578 Fix pointer signedness issue.
edced198
PE
8579 (sys_subshell): Mark local as volatile if checking for lint,
8580 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8581 (MAXPATHLEN): Define only if needed.
a70072c9 8582
a0977c44
PE
8583 * process.c (serial_open, serial_configure): Move decls from here ...
8584 * systty.h: ... to here, so that they can be checked.
8585
a884fdcc
PE
8586 * fns.c (get_random, seed_random): Move extern decls from here ...
8587 * lisp.h: ... to here, so that they can be checked.
8588
604efe86 8589 * sysdep.c (reset_io): Now static.
b8950c94 8590 (wait_for_termination_signal): Remove; unused.
604efe86 8591
38fc62d9
PE
8592 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8593 (copy_keymap_item, append_key, push_text_char_description):
8594 Now static.
1004a21a 8595 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8596 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8597 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8598 (describe_map_tree):
8599 Rename locals to avoid shadowing.
38fc62d9 8600
2f2650da
PE
8601 * keyboard.c: Declare functions static if they are not used elsewhere.
8602 (echo_char, echo_dash, cmd_error, top_level_2):
8603 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8604 (read_char, kbd_buffer_get_event, make_lispy_position):
8605 (make_lispy_event, make_lispy_movement, apply_modifiers):
8606 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8607 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8608 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8609 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8610 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8611
a053e86c 8612 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8613 (mark_kboards): Move decl here ...
8614 * alloc.c (mark_kboards): ... from here.
a053e86c 8615
4752793e
PE
8616 * lisp.h (force_auto_save_soon): New decl.
8617
74f10ca7 8618 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8619 (DEFINE_DUMMY_FUNCTION): New macro.
8620 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8621 Use it.
c03cd23f
PE
8622 (main): Add casts to avoid warnings
8623 if GCC considers string literals to be constants.
74f10ca7 8624
022e70d4
PE
8625 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8626
59d6fe83
PE
8627 * dbusbind.c: Pointer signedness fixes.
8628 (xd_signature, xd_append_arg, xd_initialize):
8629 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8630 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8631 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8632 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8633
78320123
PE
8634 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8635 if GCC considers string literals to be constants.
49cebcca 8636 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8637
35ac2a97
SM
86382011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8639
fb103ca9
SM
8640 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8641 (print_preprocess, print_object): New macro to fix last change.
8642
35ac2a97
SM
8643 * print.c (print_preprocess): Don't forget font objects.
8644
62973b41
JB
86452011-03-16 Juanma Barranquero <lekktu@gmail.com>
8646
8647 * emacs.c (USAGE3): Doc fixes.
8648
0e48bb22
AS
86492011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8650
8651 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8652 structure.
8653
7684e57b
JB
86542011-03-14 Juanma Barranquero <lekktu@gmail.com>
8655
8656 * lisp.h (VWindow_system, Qfile_name_history):
8657 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8658 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8659 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8660
8661 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8662 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8663
8664 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8665 * w32console.c (detect_input_pending, read_input_pending)
8666 (encode_terminal_code):
8667 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8668 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8669 (w32_system_caret_y, Qfile_name_history):
8670 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8671 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8672 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8673 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8674 * w32proc.c (Qlocal, report_file_error):
8675 * w32term.c (Vwindow_system, updating_frame):
8676 * w32uniscribe.c (initialized, uniscribe_font_driver):
8677 Remove unneeded extern declarations.
8678
2aa46d6c
CY
86792011-03-14 Chong Yidong <cyd@stupidchicken.com>
8680
c96bbc66 8681 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8682
cffc6f3b
CY
86832011-03-13 Chong Yidong <cyd@stupidchicken.com>
8684
8685 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8686 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8687 These macros can no longer be used for assignment.
8688
44f230aa
SM
8689 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8690 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8691 (record_buffer_markers, fetch_buffer_markers): New functions for
8692 recording and fetching special buffer markers.
8693 (set_buffer_internal_1, set_buffer_temp): Use them.
8694
8695 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8696
8697 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8698
8699 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8700 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8701
8702 * xdisp.c (hscroll_window_tree):
8703 (reconsider_clip_changes): Use PT instead of BUF_PT.
8704
d251f04b
EZ
87052011-03-13 Eli Zaretskii <eliz@gnu.org>
8706
8707 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8708 $(EMACS_ROOT)/lib/intprops.h.
8709
f0c77cd1
PE
87102011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8711
3eca4629
PE
8712 Fix more problems found by GCC 4.5.2's static checks.
8713
7c86ee98
PE
8714 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8715 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8716 (xg_free_frame_widgets): Make it clear that a local variable is
8717 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8718 (gdk_window_get_screen): Make it clear that this macro is needed
8719 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8720 (int_gtk_range_get_value): New function, which avoids a diagnostic
8721 from gcc -Wbad-function-cast.
8722 (xg_set_toolkit_scroll_bar_thumb): Use it.
8723 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8724 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8725 (get_utf8_string, xg_get_file_with_chooser):
8726 Rename locals to avoid shadowing.
8727 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8728
41729b81
PE
8729 * xgselect.c (xg_select): Remove unused var.
8730
f0c77cd1
PE
8731 * image.c (four_corners_best): Mark locals as initialized.
8732 (gif_load): Initialize transparent_p to zero (Bug#8238).
8733 Mark another local as initialized.
ec6cf4c6 8734 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8735
ce0ad53d 8736 * image.c (clear_image_cache): Now static.
d5d5a617 8737 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8738 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8739 (x_edge_detection): Remove unnecessary cast that
8740 gcc -Wbad-function-cast diagnoses.
2037898d 8741 (gif_load): Fix pointer signedness.
6ae141d6
PE
8742 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8743 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8744
33383987 87452011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8746
d32df629
PE
8747 Improve quality of tests for time stamp overflow.
8748 For example, without this patch (encode-time 0 0 0 1 1
8749 1152921504606846976) returns the obviously-bogus value (-948597
8750 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8751 reports time overflow. See
8752 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8753 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8754 * editfns.c: Include limits.h and intprops.h.
8755 (TIME_T_MIN, TIME_T_MAX): New macros.
8756 (time_overflow): Move earlier, to before first use.
8757 (hi_time, lo_time): New functions, for an accurate test for
8758 out-of-range times.
8759 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8760 (Fget_internal_run_time): Don't assume time_t fits in int.
8761 (make_time): Use list2 instead of Fcons twice.
8762 (Fdecode_time): More accurate test for out-of-range times.
8763 (check_tm_member): New function.
8764 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8765 (lisp_time_argument): Don't rely on undefined left-shift and
8766 right-shift behavior when checking for time stamp overflow.
8be6f318 8767
fe31d94c
PE
8768 * editfns.c (time_overflow): New function, refactoring common code.
8769 (Fformat_time_string, Fdecode_time, Fencode_time):
8770 (Fcurrent_time_string): Use it.
8771
8be6f318
PE
8772 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8773 * dired.c (make_time): Move to ...
8774 * editfns.c (make_time): ... here.
8775 * systime.h: Note the move.
8776
09d9db2c 87772011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8778
126bc0dc
YM
8779 * fringe.c (update_window_fringes): Remove unused variables.
8780
c47cbdfd
YM
8781 * unexmacosx.c (copy_data_segment): Also copy __got section.
8782 (Bug#8223)
8783
7ac80be9
EZ
87842011-03-12 Eli Zaretskii <eliz@gnu.org>
8785
c96bbc66 8786 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8787 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8788 Constify `char *' arguments and their references according to
8789 prototypes in tparam.h.
8790
ecb0f94d 8791 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8792
7ac80be9
EZ
8793 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8794 Adapt all references accordingly.
8795
8796 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8797
ef1fd07e
TT
87982011-03-11 Tom Tromey <tromey@redhat.com>
8799
8800 * buffer.c (syms_of_buffer): Remove obsolete comment.
8801
7ef4b50c
EZ
88022011-03-11 Eli Zaretskii <eliz@gnu.org>
8803
8804 * termhooks.h (encode_terminal_code): Declare prototype.
8805
8806 * msdos.c (encode_terminal_code): Don't declare prototype.
8807
8808 * term.c (encode_terminal_code): Now external again, used by
8809 w32console.c and msdos.c.
8810
44f230aa
SM
8811 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8812 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8813
4b1ec863 88142011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8815
1714f52b 8816 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8817
4b1ec863
PE
8818 * fringe.c (update_window_fringes): Mark locals as initialized
8819 (Bug#8227).
8820 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8821
524c7aa6
PE
8822 * alloc.c (mark_fringe_data): Move decl from here ...
8823 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8824 to check its interface.
8825 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8826
a5c0af81 8827 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8828 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8829 (fontset_font): Mark local as initialized.
a9a06e0b 8830 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8831
b4716021
PE
8832 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8833
811e9bac 8834 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8835 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8836 (x_own_selection, Fx_disown_selection_internal): Rename locals
8837 to avoid shadowing.
8838 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8839
7e3ab302
PE
8840 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8841 so that the caller can use some name other than gcpro1.
8842 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8843 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8844 (Fx_backspace_delete_keys_p):
8845 Use them to avoid shadowing, and rename vars to avoid shadowing.
8846 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8847 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8848 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8849 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8850 Remove unused locals.
7e3ab302
PE
8851 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8852 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8853 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8854 macros.
f78faa98 8855
e2b13473
PE
8856 * xterm.h (x_mouse_leave): New decl.
8857
77f23912
PE
8858 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8859 Remove unused functions.
cdf4ba58
PE
8860 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8861 (x_calc_absolute_position): Now static.
7411c686 8862 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8863 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8864 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8865 unless they are used.
38d0b34a
PE
8866 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8867 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8868 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8869 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8870 (x_error_catcher, x_connection_closed, x_error_handler):
8871 (x_error_quitter, xembed_send_message, x_iconify_frame):
8872 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8873 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8874 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8875
44f230aa
SM
8876 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8877 Rename or move locals to avoid shadowing.
6b463e58 8878 (tty_defined_color, merge_face_heights): Now static.
5967d051 8879 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8880 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8881 does not deduce is never used uninitialized.
73719eba
PE
8882 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8883 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8884
426994c3 8885 * terminal.c (store_terminal_param): Now static.
5489860b 8886
032f1620 8887 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8888 (set_frame_menubar): Remove unused local.
d4323972 8889 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8890 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8891 since they might point to immutable storage.
281585b0
PE
8892 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8893 since it's unused otherwise.
032f1620 8894
367c19e5 8895 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8896 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8897 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8898 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8899 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8900 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8901 does not deduce are never used uninitialized.
70739cbe 8902
07b48fa9
PE
8903 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8904
8868a238 8905 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8906 * window.c (window_loop, size_window):
8907 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8908
7e5cf297 8909 * window.c (display_buffer): Now static.
d6550a9f
PE
8910 (size_window): Mark variables that gcc -Wuninitialized
8911 does not deduce are never used uninitialized.
a586633d
PE
8912 * window.h (check_all_windows): New decl, to forestall
8913 gcc -Wmissing-prototypes diagnostic.
5b555da1 8914 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8915
f6095868
PE
8916 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8917 shadowing.
8918 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8919 Include <limits.h>.
8920 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8921 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8922 (load_charset_map): Mark variables that gcc -Wuninitialized
8923 does not deduce are never used uninitialized.
53df7c11 8924 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8925
f38b440c
PE
8926 * coding.c (coding_set_source, coding_set_destination):
8927 Use "else { /* comment */ }" rather than "else /* comment */;"
8928 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8929 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8930 a block, when the outer 'i' will do.
8931 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8932 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8933 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8934 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8935 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8936 Rename locals to avoid shadowing.
8937 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8938 * coding.c (emacs_mule_char, encode_invocation_designation):
8939 Now static, since they're not used elsewhere.
413bb2db 8940 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8941 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8942 (decode_coding_emacs_mule): Mark variables that gcc
8943 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8944 (detect_coding_iso_2022): Initialize a local variable that might
8945 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8946 this initialization is needed. (Bug#8211)
5f58e762
PE
8947 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8948 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8949 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8950 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8951 Remove unused macros.
f38b440c 8952
232b38b9 8953 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8954 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8955 * character.c (string_count_byte8): Likewise.
232b38b9 8956
fb90da1b
PE
8957 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8958 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8959
fb93dbc2
PE
8960 * chartab.c (copy_sub_char_table): Now static, since it's not used
8961 elsewhere.
5c156ace
PE
8962 (sub_char_table_ref_and_range, char_table_ref_and_range):
8963 Rename locals to avoid shadowing.
bbcd0949 8964 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8965
7d3b3862 8966 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8967 (BIDI_BOB): Remove unused macro.
7d3b3862 8968
6be7d3da
PE
8969 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8970 deduce are never used uninitialized.
c2ed9c8b 8971 * term.c (encode_terminal_code): Likewise.
6be7d3da 8972
75f8807f 8973 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8974
50938595
PE
8975 * tparam.h: New file.
8976 * term.c, tparam.h: Include it.
8977 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8978 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8979 Move these decls to tparam.h, and make them agree with what
8980 is actually in tparam.c. The previous trick of using incompatible
8981 decls in different modules does not conform to the C standard.
8982 All callers of tparam changed to use tparam's actual API.
8983 * tparam.c (tparam1, tparam, tgoto):
8984 Use const pointers where appropriate.
8985
fbceeba2
PE
8986 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8987 * cm.h (struct cm): Likewise.
8988 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8989 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8990 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8991 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8992 (turn_on_face, init_tty): Likewise.
8993 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8994
7f3f1250
PE
8995 * term.c (term_mouse_position): Rename local to avoid shadowing.
8996
e6ca6543
PE
8997 * alloc.c (mark_ttys): Move decl from here ...
8998 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8999
c40f8d15
AS
90002011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9001
9002 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9003
cfe0661d
JB
90042011-03-09 Juanma Barranquero <lekktu@gmail.com>
9005
9006 * search.c (compile_pattern_1): Remove argument regp, unused since
9007 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9008 (compile_pattern): Don't pass it.
9009
0afb4571
J
90102011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9011
9012 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9013 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9014 for ! HAVE_GTK3.
9015 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9016
9017 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9018
9019 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9020 gdk_window_get_screen, gdk_window_get_geometry,
9021 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9022 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9023 (xg_get_pixbuf_from_pixmap): New function.
9024 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9025 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9026 Call xg_get_pixbuf_from_pixmap instead of
9027 gdk_pixbuf_get_from_drawable.
9028 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9029 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9030 (xg_check_special_colors): Use GtkStyleContext and its functions
9031 for HAVE_GTK3.
9032 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9033 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9034 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9035 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9036 Call gtk_widget_get_preferred_size.
0afb4571
J
9037 (xg_frame_resized): gdk_window_get_geometry only takes 5
9038 parameters.
44f230aa
SM
9039 (xg_win_to_widget, xg_event_is_for_menubar):
9040 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9041 (xg_set_widget_bg): New function.
9042 (delete_cb): New function.
895009e1 9043 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9044 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9045 (xg_set_background_color): Call xg_set_widget_bg.
9046 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9047 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9048 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9049 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9050 if ! HAVE_GTK3.
9051 (update_frame_tool_bar): Call gtk_widget_hide.
9052 (xg_initialize): Use GDK_KEY_g.
9053
9054 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9055 if ! HAVE_GTK3
9056 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9057
9058 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9059 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9060 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9061
1c2cc4ef
JB
90622011-03-08 Juanma Barranquero <lekktu@gmail.com>
9063
9064 * w32xfns.c (select_palette): Check success of RealizePalette against
9065 GDI_ERROR, not zero.
9066
33383987 9067See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9068
9069;; Local Variables:
9070;; coding: utf-8
aac0c6e3
MR
9071;; End:
9072
acaf905b 9073 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9074
9075 This file is part of GNU Emacs.
9076
9077 GNU Emacs is free software: you can redistribute it and/or modify
9078 it under the terms of the GNU General Public License as published by
9079 the Free Software Foundation, either version 3 of the License, or
9080 (at your option) any later version.
9081
9082 GNU Emacs is distributed in the hope that it will be useful,
9083 but WITHOUT ANY WARRANTY; without even the implied warranty of
9084 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9085 GNU General Public License for more details.
9086
9087 You should have received a copy of the GNU General Public License
9088 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.