Fix compiler warning in keyboard.c.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9b8d5165
EZ
12012-08-14 Eli Zaretskii <eliz@gnu.org>
2
3 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
4 iteration through the command loop. Fixes a problem whereby mouse
5 movements are ignored until the first mouse click.
6
f5d9e83a
PE
72012-08-14 Paul Eggert <eggert@cs.ucla.edu>
8
9 Use bool, not int, for Lisp booleans.
10 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
11 makes Emacs a bit smaller and presumably a bit faster.
12 * lisp.h: Include <stdbool.h>.
13 (struct Lisp_Boolfwd, defvar_bool):
14 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
15 * regex.c [!emacs]: Include <stdbool.h>.
16 (false, true): Remove; <stdbool.h> does this for us now.
17
55802e4a
CY
182012-08-14 Chong Yidong <cyd@gnu.org>
19
4abcdac8
CY
20 * character.c (Fcharacterp): Doc fix (Bug#12076).
21
22 * data.c (Findirect_variable): Doc fix (Bug#11040).
23
55802e4a
CY
24 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
25
26 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 27 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 28
8e99d072
BR
292012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
30
31 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
32 (bug#12022).
33
08908aca
MR
342012-08-14 Martin Rudalics <rudalics@gmx.at>
35
36 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
37 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
38 * minibuf.c (choose_minibuf_frame, read_minibuf):
39 * w32fns.c (x_create_tip_frame):
40 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
41 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
42
56120d6f
PE
432012-08-14 Paul Eggert <eggert@cs.ucla.edu>
44
45 * intervals.c (offset_intervals): Remove obsolete comment.
46
67b77c0b
AS
472012-08-14 Andreas Schwab <schwab@linux-m68k.org>
48
49 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
50
f48b82fd
GR
512012-08-14 Gergely Risko <gergely@risko.hu>
52
53 * coding.c (decode_coding): Record buffer modification before
54 disabling undo_list (Bug#11773).
55
fd318b54
DA
562012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
57
58 Revert and cleanup some recent overlay changes.
59 * buffer.h (enum overlay_type): Remove.
60 (buffer_get_overlays, buffer_set_overlays): Likewise.
61 (buffer_set_overlays_before, buffer_set_overlays_after):
62 New function. Adjust users.
63 (unchain_both): Add eassert.
64
41a62dd9
DA
652012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
66
67 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
68
5884c324
PE
692012-08-14 Paul Eggert <eggert@cs.ucla.edu>
70
71 * gtkutil.c (xg_mark_data): Don't assume C99.
72
ca06f160
JD
732012-08-13 Jan Djärv <jan.h.d@swipnet.se>
74
75 * gtkutil.c (xg_frame_tb_info): New struct.
76 (TB_INFO_KEY): New define.
77 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
78 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
79 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
80 if not present.
81 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
82 is up to date. Otherwise store new data.
83 (free_frame_tool_bar): Free xg_frame_tb_info if present.
84
7864a3f7
DA
852012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
86
87 Use KSET for write access to Lisp_Object members of struct kboard.
88 * keyboard.h (KSET): New macro.
89 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
90 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
91 * xterm.c: Adjust users.
92
4c31be61
DA
932012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
94
95 Use BSET for write access to Lisp_Object members of struct buffer.
96 * buffer.h (BSET): New macro.
97 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
98 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
99 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
100 * window.c, xdisp.c, xfns.c: Adjust users.
101
14ae4239
BT
1022012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
103
104 * lread.c (syms_of_lread): Initialize Vlexical_binding.
105
32bcadb4
JD
1062012-08-11 Jan Djärv <jan.h.d@swipnet.se>
107
3d29b2ce
JD
108 * nsterm.m (not_in_argv): New function.
109 (application:openFile, application:openTempFile:):
110 (application:openFileWithoutUI:, application:openFiles:): Open file
111 if not_in_argv returns non-zero (bug#12171).
112
32bcadb4 113 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
114 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
115 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
116 (xg_get_font_name): Use those functions/macros here.
117 Reported by Frans Oilinki <moilinki@gmail.com>.
118
9ff9402d 1192012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
120
121 * unexmacosx.c (copy_data_segment): Copy initialized data in
122 statically linked libraries from input file rather than memory.
123
db74a5fc
YM
124 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
125 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
126 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
127
25e65510
GM
1282012-08-10 Glenn Morris <rgm@gnu.org>
129
130 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
131 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
132
7961135c
DA
1332012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
134
135 Fix last change to allow compilation with low optimization levels.
136 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
137 Reported by Jan Djärv <jan.h.d@swipnet.se>.
138
42b3a444
DA
1392012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
140
141 Use common inline syntax in intervals.h.
142 * intervals.h (INTERVALS_INLINE): New macro.
143 Change all users from LISP_INLINE.
144
9fb0c957
DA
1452012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
146
147 Define Qnone once for all platforms.
148 * frame.c (Qnone): Define here.
149 (syms_of_frame): DEFSYM it.
150 * lisp.h (Qnone): New declaration.
151 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
152 * xfns.c: Remove duplication. Adjust users.
153
65e8ee52
DA
1542012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
155
156 Remove unused macros from intervals.h.
157 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
158 * intervals.c: Adjust comment.
159
9b855fd6
EZ
1602012-08-10 Eli Zaretskii <eliz@gnu.org>
161
162 * w32fns.c <w32_unicode_gui>: New static variable.
163 (globals_of_w32fns): Initialize it according to os_subtype.
164 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
165 testing os_subtype.
166
39cb9e56 1672012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
168 Eli Zaretskii <eliz@gnu.org>
169
170 Fix bug #10299 with Unicode characters sent by customized
171 keyboards created by MSKLC.
172 * w32fns.c (INIT_WINDOW_CLASS): New macro.
173 (w32_init_class): Use it to initialize the Emacs class with either
174 ANSI or Unicode API calls.
175 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
176 later.
177 (w32_wnd_proc): If the character code sent by WM_CHAR or
178 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
179 original message. Call DefWindowProcW on NT and later.
180
9374581a
GM
1812012-08-10 Glenn Morris <rgm@gnu.org>
182
4b94e8cf
GM
183 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
184
9374581a
GM
185 * lisp.h (DIRECTORY_SEP): Let configure set it.
186
a2752828
DA
1872012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
188
189 Use TSET for write access to Lisp_Object slots of struct terminal.
190 * termhooks.h (TSET): New macro.
191 * coding.c, terminal.c, xselect.c: Adjust users.
192
cc92c454
SM
1932012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
194
195 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
196 the failing expression, include them in the error message.
197 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
198 * lisp.h (internal_condition_case_n): Update declaration.
199
4cb3e6b3
DA
2002012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
201
202 Inline functions to examine and change buffer overlays.
203 * buffer.c (unchain_both): New function.
204 * buffer.h (buffer_get_overlays, buffer_set_overlays):
205 (buffer_has_overlays): New function.
206 (enum overlay_type): New enum.
207 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
208 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
209
8707c1e5
DA
2102012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
211
212 Inline functions to examine and change buffer intervals.
213 * alloc.c (mark_interval_tree): Remove.
214 (MARK_INTERVAL_TREE): Simplify.
215 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
216 * intervals.c (buffer_balance_intervals): New function.
217 (graft_intervals_into_buffer): Adjust indentation.
218 (set_intervals_multibyte): Simplify.
219 * buffer.h (BUF_INTERVALS): Remove.
220 (buffer_get_intervals, buffer_set_intervals): New function.
221 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
222 * intervals.c, textprop.c: Adjust users.
223
ad8c997f
DA
2242012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
225
226 Inline functions to examine and change string intervals.
227 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
228 (string_get_intervals, string_set_intervals): New function.
229 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
230 * lread.c, print.c, textprop.c: Adjust users.
231
32ac3a6b
GM
2322012-08-08 Glenn Morris <rgm@gnu.org>
233
234 * lisp.mk (lisp): Remove language/persian.elc.
235
77c7bcb1
DA
2362012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
237
238 Cleanup intervals.
239 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
240 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
241 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
242 Adjust comment. Move under #if 0.
77c7bcb1
DA
243 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
244 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
245
9c08a8d4
DA
2462012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
247
248 Check total length of intervals with eassert.
249 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
250 * intervals.c: Change all users to eassert.
251
26d16b35
EZ
2522012-08-07 Eli Zaretskii <eliz@gnu.org>
253
14ae4239
BT
254 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
255 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
256 INTERNAL_FIELD in Lisp_Cons.
257
c644523b
DA
2582012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
259
260 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
261 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
262 name since all xname users are fixed long time ago. Do not
263 use INTERNAL_FIELD.
264 (set_symbol_name, set_symbol_function, set_symbol_plist):
265 (set_symbol_next, set_overlay_plist): New function.
266 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
267 (struct Lisp_Overlay): Likewise.
268 (CVAR, MVAR, SVAR): Remove.
269 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
270 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
271 * xterm.c: Adjust users.
272 * .gdbinit: Change to use name field of struct Lisp_Symbol
273 where appropriate.
274
6a3d20cc
DA
2752012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
276
277 Basic functions to set Lisp_Object and pointer slots of intervals.
278 * intervals.h (interval_set_parent, interval_set_object):
279 (interval_set_left, interval_set_right, interval_set_plist):
280 (interval_copy_parent): New function.
281 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
282 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
283 Adjust indentation.
6a3d20cc
DA
284 (INTERVAL_SIZE): Remove. Adjust users.
285 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
286
4d2b044c
DA
2872012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
288
289 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
290 * process.h (PGET): Remove.
291 (struct Lisp_Process): Do not use INTERNAL_FIELD.
292 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
293
d3d50620
DA
2942012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
295
296 Drop WGET and revert read access to Lisp_Objects slots of struct window.
297 * window.h (WGET): Remove.
298 (struct window): Do not use INTERNAL_FIELD.
299 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
300 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
301 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
302 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
303 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
304 Adjust users.
305
d10a51dc
CY
3062012-08-07 Chong Yidong <cyd@gnu.org>
307
308 * window.c (Fwindow_edges, Fwindow_pixel_edges)
309 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
310 (Fdelete_window_internal): Signal an error if the window is not on
311 a live frame (Bug#12025).
312
e69b0960
DA
3132012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
314
315 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
316 * frame.h (FGET): Remove.
317 (struct frame): Do not use INTERNAL_FIELD.
318 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
319 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
320 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
321 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
322
25a20a3a
JB
3232012-08-06 Juanma Barranquero <lekktu@gmail.com>
324
325 * w32.c: Silence compiler warnings.
326 (map_w32_filename): Remove unused variable `is_fat'.
327 (chase_symlinks): Add parentheses around expression.
328
1c6f11f4
GM
3292012-08-06 Glenn Morris <rgm@gnu.org>
330
1db4583a
GM
331 * sysdep.c: Respect BROKEN_GETWD.
332
1c6f11f4
GM
333 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
334 Let configure handle it.
335 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
336
2b90362b
DA
3372012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
338
339 Use GCALIGNMENT where appropriate.
340 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
341 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
342 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
343
5f50daf2
EZ
3442012-08-06 Eli Zaretskii <eliz@gnu.org>
345
14ae4239
BT
346 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
347 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 348
cbcc7007
SM
3492012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
350
351 * buffer.h (struct buffer): Revert `indirections' to a simple int;
352 that should be sufficient for everyone.
353
4d365fa4
JD
3542012-08-06 Jan Djärv <jan.h.d@swipnet.se>
355
356 * keyboard.c (timer_check_2): Add break so timer_check returns next
357 timeout.
358
dd86bd82
DA
3592012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
360
361 Fix Windows build errors introduced after converting to WGET and WSET.
362 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
363 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
364
054e1668
JD
3652012-08-06 Jan Djärv <jan.h.d@swipnet.se>
366
367 * nsterm.m (ns_frame_rehighlight): Use FSET.
368
369 * nsmenu.m (ns_update_menubar): Use FSET.
370
21238f11
DA
3712012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
372
373 Separate read and write access to Lisp_Object slots of Lisp_Process.
374 * process.h (PGET, PSET): New macros similar to AREF and ASET.
375 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
376
077288cf
DA
3772012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
378
379 Separate read and write access to Lisp_Object slots of struct window.
380 * window.h (WGET, WSET): New macros similar to AREF and ASET.
381 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
382 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
383 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
384 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
385 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
386 Adjust users.
387
71688bd7
DA
3882012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
389
390 Fix Windows build errors introduced after converting to FGET and FSET.
391 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
392 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
393 (w32_judge_scroll_bars): Change to use FSET.
394 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
395
f99bac93
DA
3962012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
397
398 Fix replacement typo.
399 * window.c (replace_window): Set root_window instead of
400 selected_window. This fixes a total window subsystem
401 malfunction reported by Bastien Guerry <bzg@gnu.org>.
402
8c2a0f2d
GM
4032012-08-06 Glenn Morris <rgm@gnu.org>
404
405 * lisp.mk (lisp): Add language/persian.elc.
406
edd74c35
DA
4072012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
408
409 Separate read and write access to Lisp_Object slots of struct frame.
410 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
411 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
412 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
413 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
414 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
415
8671676c
AS
4162012-08-05 Andreas Schwab <schwab@linux-m68k.org>
417
418 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
419
663e2b3f
DA
4202012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
421
422 Generalize common compile-time constants.
423 * lisp.h (header_size, bool_header_size, word_size): Now here.
424 (struct Lisp_Vector): Add comment.
425 (struct Lisp_Bool_Vector): Move up to define handy constants.
426 (VECSIZE, PSEUDOVECSIZE): Simplify.
427 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
428 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
429 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
430 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
431 * xfont.c, xmenu.c: Use word_size where appropriate.
432
d32e47af
LM
4332012-08-05 Lawrence Mitchell <wence@gmx.li>
434
435 * search.c (Freplace_match): Treat \? in the replacement text
436 literally (Bug#8161).
437
e5d9c0d1
CY
4382012-08-05 Chong Yidong <cyd@gnu.org>
439
440 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
441 * frame.c (Vdelete_frame_functions):
442 * emacs.c (Vkill_emacs_hook): Doc fix.
443
8da0576b
EZ
4442012-08-04 Eli Zaretskii <eliz@gnu.org>
445
446 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
447 --with-x-toolkit=no builds.
448 Reported by Carsten Mattner <carstenmattner@gmail.com>.
449
02676e5d
CY
4502012-08-04 Chong Yidong <cyd@gnu.org>
451
452 * syntax.c (Fmodify_syntax_entry): Doc fix.
453
97147da9
EZ
4542012-08-04 Eli Zaretskii <eliz@gnu.org>
455
76151e2c
EZ
456 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
457 * w32.c (init_environment): Change the default values of many
458 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
459 them into environment when they were not already defined.
460 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 461 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
462 (check_windows_init_file): Now external, not static.
463 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
464 called when Vload_path is already set up.
465
466 * w32.h (check_windows_init_file): Add prototype.
467
468 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
469 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
470 compatibility with Posix platforms.
471 (main): Move the call to check_windows_init_file to here from
472 w32.c.
473 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
474 any, in the DEFALT argument into the root of the Emacs build or
475 installation tree, as appropriate.
476
477 * callproc.c (init_callproc_1): Call decode_env_path instead of
478 doing its equivalent by hand.
479 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
480 the code that sets Vexec_path run on MS-Windows.
481
482 * lread.c (init_lread): Add comments to #ifdef's.
483
97147da9
EZ
484 * msdos.c (dos_set_window_size, IT_update_begin)
485 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
486 instead of direct references.
487
185ee146
PE
4882012-08-04 Paul Eggert <eggert@cs.ucla.edu>
489
490 Export DEFAULT_REHASH_* to GDB.
491 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
492 Now constants, not macros.
493
8834c57a
PE
4942012-08-03 Paul Eggert <eggert@cs.ucla.edu>
495
98c6f1e3
PE
496 Remove unnecessary casts involving pointers.
497 These casts are no longer needed now that we assume C89 or later,
498 since they involve casting to or from void *.
499 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
500 (make_pure_float, make_pure_vector):
501 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
502 * macros.c (Fstart_kbd_macro):
503 * menu.c (find_and_return_menu_selection):
504 * minibuf.c (read_minibuf_noninteractive):
505 * sysdep.c (closedir):
506 * xdisp.c (x_produce_glyphs):
507 * xfaces.c (compare_fonts_by_sort_order):
508 * xfns.c (x_real_positions, select_visual):
509 * xselect.c (x_stop_queuing_selection_requests)
510 (x_get_window_property, x_get_window_property_as_lisp_data):
511 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
512 Remove unnecessary pointer casts.
513 * alloc.c (record_xmalloc): New function.
514 * lisp.h (record_xmalloc): New decl.
515 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
516 more like a function. This is because the pointer cast is not
517 needed. All uses changed.
518 * print.c (print_string, print_error_message): Avoid length recalc.
519
8834c57a
PE
520 Improve fix for macroexp crash with debugging (Bug#12118).
521 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
522 ARRAY_MARK_FLAG when checking subscripts, because ASET is
523 not supposed to be invoked from the garbage collector.
524 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
525 (gc_aset): New function, which is like ASET but can be
526 used in the garbage collector.
527 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
528 (set_hash_index): Use it instead of ASET.
529
6dad7178
EZ
5302012-08-03 Eli Zaretskii <eliz@gnu.org>
531
532 Support symlinks on latest versions of MS-Windows.
533 * w32.c: Include winioctl.h and aclapi.h.
534 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
535 (revert_to_self): Forward declarations of static functions.
536 <static BOOL g_b_init_get_security_info>:
537 <g_b_init_create_symbolic_link>: New static flags.
538 (globals_of_w32): Initialize them to zero.
539 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
540 (map_w32_filename): Improve commentary. Simplify switch.
541 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
542 headers (most versions of MinGW w32api don't).
543 (get_security_info, create_symbolic_link)
544 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
545 New functions.
546 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
547 in the argument file name.
548 (sys_access): Call unc_volume_file_attributes only if
549 GetFileAttributes fails with network-related error codes.
550 (sys_rename): Diagnose renaming of a symlink when the user doesn't
551 have the required privileges.
14ae4239 552 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
553 get_file_security_desc.
554 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
555 with addition of handling of symlinks and support for 'lstat'.
556 If possible, get file's attributes and security information by
6dad7178
EZ
557 handle, not by name. Produce S_IFLNK bit for symlinks, when
558 called from 'lstat'.
559 (stat, lstat): New functions, call 'stat_worker'.
560 (symlink, readlink, careadlinkat): Rewritten to create and resolve
561 symlinks when the underlying filesystem supports them.
562
f162bcc3
PE
5632012-08-02 Paul Eggert <eggert@cs.ucla.edu>
564
79ea6c20
PE
565 Fix macroexp crash on Windows with debugging (Bug#12118).
566 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
567 checking subscripts; problem introduced with the recent
568 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
569 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
570 since it's used in non-static inline functions now.
571
c0ce93fd
PE
572 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
573 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 574
f162bcc3
PE
575 Use C99-style 'extern inline' if available.
576 * buffer.h (BUFFER_INLINE):
577 * category.h (CATEGORY_INLINE):
578 * character.h (CHARACTER_INLINE):
579 * charset.h (CHARSET_INLINE):
580 * composite.h (COMPOSITE_INLINE):
581 * dispextern.h (DISPEXTERN_INLINE):
582 * lisp.h (LISP_INLINE):
583 * systime.h (SYSTIME_INLINE):
584 New macro, replacing 'static inline' in this header.
585 * buffer.h, category.h, character.h, charset.h, composite.h:
586 * dispextern.h, lisp.h, systime.h:
587 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
588 * alloc.c (LISP_INLINE):
589 * buffer.c (BUFFER_INLINE):
590 * category.c (CATEGORY_INLINE):
591 * character.c (CHARACTER_INLINE):
592 * charset.c (CHARSET_INLINE):
593 * composite.c (COMPOSITE_INLINE):
594 * dispnew.c (DISPEXTERN_INLINE):
595 * sysdep.c (SYSTIME_INLINE):
596 Define to EXTERN_INLINE, so that the corresponding functions
597 are compiled into code.
598 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
599 (INLINE_HEADER_END): New macros.
600 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
601 since it's used in non-static inline functions now.
a8333d03 602 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 603
837b365b
GM
6042012-08-02 Glenn Morris <rgm@gnu.org>
605
d66b744d
GM
606 * s/: Remove empty directory.
607
837b365b
GM
608 * s/ms-w32.h: Move to ../nt/inc.
609 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
610 Update for new ms-w32.h location.
611
13294f95
PE
6122012-08-02 Paul Eggert <eggert@cs.ucla.edu>
613
614 Port to Solaris 8.
615 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
616
90df0db3
GM
6172012-08-02 Glenn Morris <rgm@gnu.org>
618
619 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
620 hard-coding the path separator.
621
4939150c
PE
6222012-08-01 Paul Eggert <eggert@cs.ucla.edu>
623
624 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
625 This how ASET and AREF are supposed to work, and makes
626 it easier to think about future improvements. See
627 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
628 * charset.h (set_charset_attr): New function.
629 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
630 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
631 (aref_addr): New function. All uses of &AREF(...) changed.
632 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
633 (set_hash_index): New functions. All lvalue-style uses of
634 HASH_KEY etc. changed.
635 * keyboard.c (set_prop): New function. All lvalue-style uses
636 of PROP changed.
637
947b2afd
AA
6382012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
639
640 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
641 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
642 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
643 * nsfns.m (ns_set_name_as_filename): Likewise.
644 * nsmenu.m (ns_update_menubar): Likewise.
645 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
646
4f5d0325
EZ
6472012-08-01 Eli Zaretskii <eliz@gnu.org>
648
2008beae
EZ
649 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
650 Adapt to latest changes in field names of the corresponding Lisp
288479f6 651 objects.
2008beae 652
4f5d0325
EZ
653 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
654
fe3cc771
GM
6552012-08-01 Glenn Morris <rgm@gnu.org>
656
657 * s/msdos.h: Remove file.
658 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
659 * Makefile.in (S_FILE): Remove.
660 (config_h): Remove S_FILE.
661
c90acc54
JB
6622012-08-01 Juanma Barranquero <lekktu@gmail.com>
663
664 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
665 Remove; moved to nt/config.nt.
666
d8a05828
DA
6672012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
668
669 Use INTERNAL_FIELD for conses and overlays.
670 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
671 Remove obsolete comment.
672 (MVAR): New macro.
673 (struct Lisp_Overlay): Use INTERNAL_FIELD.
674 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
675
8271d590
DA
6762012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
677
678 Use INTERNAL_FIELD for symbols.
679 * lisp.h (SVAR): New macro. Adjust users.
680 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
681 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
682
3193acd2
DA
6832012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
684
685 Use INTERNAL_FIELD for processes.
686 * process.h (PVAR): New macro. Adjust style.
687 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
688 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
689
3a45383a
DA
6902012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
691
692 Use INTERNAL_FIELD for windows.
693 * window.h (WVAR): New macro.
694 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
695 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
696 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
697 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
698 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
699 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
700
c1dbc63c
PE
7012012-08-01 Paul Eggert <eggert@cs.ucla.edu>
702
703 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
704
5c0c0e8a
GM
7052012-08-01 Glenn Morris <rgm@gnu.org>
706
707 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
708 Move to configure.ac.
709
552a99b4
JB
7102012-08-01 Juanma Barranquero <lekktu@gmail.com>
711
712 * makefile.w32-in (CONFIG_H): Update dependencies.
713 (CONF_POST_H): New macro.
714
715 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
716
8d8e2dfe
GM
7172012-07-31 Glenn Morris <rgm@gnu.org>
718
bc96620a
GM
719 * Makefile.in (S_FILE): No longer set by configure.
720
476b1b2d
GM
721 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
722 is available.
723 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
724
b2c7a106
GM
725 * process.h (NULL_DEVICE):
726 * emacs.c (SEPCHAR):
727 * editfns.c (USER_FULL_NAME): Let configure set them.
728
d53d062a
GM
729 * s/README, s/template.h: Remove files.
730
4515017f
GM
731 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
732
8d8e2dfe
GM
733 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
734 Move to configure.ac.
735
5b20b3cc
EZ
7362012-07-31 Eli Zaretskii <eliz@gnu.org>
737
1e0afd9a
EZ
738 * .gdbinit (xframe): Adapt to introduction of FVAR and the
739 resulting renaming of 'struct frame' members.
740
5b20b3cc
EZ
741 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
742
743 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
744 after introduction of FVAR.
745
f1310128
JD
7462012-07-31 Jan Djärv <jan.h.d@swipnet.se>
747
79e721e0
JD
748 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
749
750 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
751 instead of compositeToPoint.
752 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
753
8d7c7eed 754 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 755
e34f7f79
DA
7562012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
757
758 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
759 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 760 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
761 (BVAR): Change to use INTERNAL_FIELD.
762 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
763 (KVAR): Change to use INTERNAL_FIELD.
764 * frame.h (FVAR): New macro.
765 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
766 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
767 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
768 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
769 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
770
c09bfb2f
DA
7712012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
772
773 Miscellaneous fixes for non-default X toolkits.
774 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
775 * xterm.c (x_frame_of_widget): Remove redundant prototype.
776 Move under #ifdef USE_LUCID.
777 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
778 definition and usage to avoid warnings.
779
14c114ae
JD
7802012-07-31 Jan Djärv <jan.h.d@swipnet.se>
781
782 * nsterm.m (openFiles): Fix previous checkin.
783
3bd21e82
PE
7842012-07-31 Paul Eggert <eggert@cs.ucla.edu>
785
786 * indent.c (compute_motion): Remove unused local.
787
c1529ded
GM
7882012-07-31 Glenn Morris <rgm@gnu.org>
789
400d5621
GM
790 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
791
268e2432
GM
792 * conf_post.h [USG5_4]:
793 Move remaining contents of s/usg5-4-common.h here.
794 * s/usg5-4-common.h: Remove file.
795
7552f3ee
GM
796 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
797 * s/irix6-5.h: Remove file.
798
6a381852
GM
799 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
800 * s/darwin.h: Remove file.
801
c1529ded
GM
802 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
803 * s/hpux10-20.h: Remove file, which is now empty.
804
b429a4ee
GM
8052012-07-30 Glenn Morris <rgm@gnu.org>
806
807 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
808 * Makefile.in (config_h): Add conf_post.h.
809 * makefile.w32-in (CONFIG_H): Add conf_post.h.
810
adff3182
JD
8112012-07-30 Jan Djärv <jan.h.d@swipnet.se>
812
813 * nsterm.m (ns_do_open_file): New variable.
b9031d69 814 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
815 (openFile, openTempFile, openFileWithoutUI, openFiles):
816 Open files only if ns_do_open_file.
adff3182 817
c32af1e4
PE
8182012-07-30 Paul Eggert <eggert@cs.ucla.edu>
819
7393bcbb
PE
820 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
821 This no-op macro hasn't been needed for many years.
822 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
823
c32af1e4
PE
824 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
825 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
826 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
827 gdb_make_enums_visible.
828 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
829 (DIRECTORY_SEP): Now a constant, not a macro.
830
302fc036
EZ
8312012-07-30 Eli Zaretskii <eliz@gnu.org>
832
833 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
834 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
835
836 * w32term.c <w32_keyboard_codepage>: Renamed from
837 keyboard_codepage and now external. All users changed.
838
839 * w32term.h: Add declaration of w32_keyboard_codepage.
840
841 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
842 the codepage to translate keys to Unicode. If this argument is
843 -1, use the value returned by GetConsoleCP. All callers changed.
844
88fb40b4
PE
8452012-07-30 Paul Eggert <eggert@cs.ucla.edu>
846
0aee6912
PE
847 Update .PHONY listings in makefiles.
848 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
849 bootstrap-clean, distclean, maintainer-clean, versioclean,
850 extraclean, frc.
851
88fb40b4
PE
852 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
853 This is a bit clearer. Fix some commentary typos.
854
0a763bd1
GM
8552012-07-30 Glenn Morris <rgm@gnu.org>
856
32bac6d6
GM
857 * s/netbsd.h: Let configure include signal.h if needed.
858 Remove file, which is now empty.
859
b65e7c46
GM
860 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
861 Let configure set them.
862 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
863 No more need to undefine.
0a763bd1 864
169304bd
AS
8652012-07-30 Andreas Schwab <schwab@linux-m68k.org>
866
867 * keymap.c (Fkey_description): Don't remove 0x80 bit from
868 non-single-byte char when adding meta modifier. (Bug#12090)
869
6cd7a139
DA
8702012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
871
872 Convert safe_call to use variable number of arguments.
873 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
874 (safe_call2): Fix comment.
875 * lisp.h (safe_call): Adjust prototype.
876 * coding.c (encode_coding_object): Change to use safe_call2.
877 * xfaces.c (merge_face_heights): Change to use safe_call1.
878
d34d6ffc
GM
8792012-07-30 Glenn Morris <rgm@gnu.org>
880
7b8a48e4 881 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 882 does that unconditionally. Remove file, which is now empty.
7b8a48e4 883
d34d6ffc
GM
884 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
885 Remove empty files.
886
03a660a6
PE
8872012-07-30 Paul Eggert <eggert@cs.ucla.edu>
888
889 Export to GDB most of lisp.h's remaining object-like macros.
890 * lisp.h (min, max): Move earlier, because they're used earlier now.
891 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
892 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
893 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
894 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
895 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
896 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
897 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
898 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
899 Now constants, for GDB. They need not be macros.
900 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
901 Now constants, for GDB, as well as macros, for static initializers.
902 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
903 Move to after the definition of struct Lisp_Char_Table,
904 since the former now needs that type defined.
905 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
906 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
907 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
908 New enums, for gdb_make_enums_visible.
909 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 910 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
911 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
912 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
913 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
914 enum maxargs, enum MAX_ALLOCA.
915 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
916 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
917 no longer needed, now that they are done in lisp.h.
918
e499d0ee
DA
9192012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
920
921 Cleanup string bytes checking.
922 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
923 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
924 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
925 (check_sblock, compact_small_strings): Simplify.
926
d5040d2d
PE
9272012-07-29 Paul Eggert <eggert@cs.ucla.edu>
928
929 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
930 These macros are confusing and no longer need to be defined, as
931 the enum values now suffice. All uses replaced with definiens.
932 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
933
7f259ae6
JB
9342012-07-29 Juanma Barranquero <lekktu@gmail.com>
935
936 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
937 ($(BLD)/w32console.$(O)): Update dependencies.
938
7e63e0c3
DA
9392012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
940
941 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
942 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
943 time. Adjust users.
944 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
945
ffd817eb
JD
9462012-07-29 Jan Djärv <jan.h.d@swipnet.se>
947
948 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
949 setting sitelisp (Bug#12010).
950
417a7a0e
EZ
9512012-07-29 Eli Zaretskii <eliz@gnu.org>
952
14ae4239 953 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
954
955 * w32heap.c (cache_system_info):
956 * w32.c (sys_rename):
957 * w32proc.c (find_child_console, sys_kill): All users changed.
958
387d4d92
PE
9592012-07-29 Paul Eggert <eggert@cs.ucla.edu>
960
961 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
962
55a6cca6
EZ
9632012-07-29 Eli Zaretskii <eliz@gnu.org>
964
965 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
966
dbcf001c
DA
9672012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
968
969 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
970 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
971 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 972
e2688e4a
DA
9732012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
974
975 Generalize marker debugging code under MARKER_DEBUG and use eassert.
976 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
977 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
978 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
979 (replace_range, replace_range_2, del_range_2): Change to eassert.
980 * marker.c (byte_char_debug_check): Adjust style.
981
b46a6a83
PE
9822012-07-29 Paul Eggert <eggert@cs.ucla.edu>
983
984 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
985 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
986 long-ago-commented-out code that talks about "WIN32".
987 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
988 All uses changed.
989
e32a5799
PE
9902012-07-28 Paul Eggert <eggert@cs.ucla.edu>
991
992 Use Gnulib stdalign module (Bug#9772, Bug#9960).
993 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
994 Simplify by using alignof.
995 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
996 * lisp.h: Include <stdalign.h>.
997 (GCALIGNMENT): New macro and constant.
998 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
999 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
1000 (stdalign): New macro, if not already defined.
1001
df81cd29
EZ
10022012-07-28 Eli Zaretskii <eliz@gnu.org>
1003
01bd1b0d
EZ
1004 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
1005 * w32inevt.c: Include w32inevt.h.
1006 (w32_read_console_input): New inline function, calls either
1007 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1008 w32_console_unicode_input.
1009 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1010 (w32_kbd_patch_key, key_event): Use the codepage returned by
1011 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1012 (key_event): use uChar.UnicodeChar only if
1013 w32_console_unicode_input is non-zero.
1014
1015 * w32console.c: Include w32heap.h.
1016 <w32_console_unicode_input>: New global variable.
1017 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1018 family of Windows, zero otherwise.
1019
1020 * w32inevt.h: Declare w32_console_unicode_input.
1021
df81cd29
EZ
1022 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1023 --without-x. (Bug#11742)
1024
c20fdd9e
PE
10252012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1026
1027 Adjust GDB to reflect pvec_type changes (Bug#12036).
1028 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1029 2012-07-04 changes to pseudovector representation.
1030 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1031
32770973 10322012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1033
1034 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1035 bus address.
1036 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1037
3438fe21
EZ
10382012-07-27 Eli Zaretskii <eliz@gnu.org>
1039
bcfbc9de
EZ
1040 * alloc.c (listn): Fix the order the arguments are consed onto the
1041 list.
1042
3438fe21
EZ
1043 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1044 enumeration constants, as PURE and HEAP are too general, and clash
1045 with other headers and sources, such as gmalloc.c and the
1046 MS-Windows system headers. All users changed.
1047
eeaea515
DA
10482012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1049
1050 Revert last save_excursion_save and save_excursion_restore changes.
1051 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1052 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1053
073c88c2
DA
10542012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1055
1056 Fix recently-introduced typos in Windows port.
1057 Reported by Martin Rudalics <rudalics@gmx.at>.
1058 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1059 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1060
4706125e
PE
10612012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1062
1063 Improve GDB symbol export (Bug#12036).
1064 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1065 arms of an 'if', not using conditional expressions; otherwise GDB
1066 complains about the types in the unevaluated arm when the argument
1067 is an integer literal.
1068 (xgetint): Simplify expression.
1069 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1070 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1071 Zaretskii in <http://bugs.gnu.org/12036#13>.
1072 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1073 needed now that we have gdb_make_enums_visible.
1074 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1075 (enum enum_USE_LSB_TAG):
1076 New enum types, packaging up enums that need to be exported to GDB.
1077
694b6c97
DA
10782012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1079
1080 Utility function to make a list from specified amount of objects.
1081 * lisp.h (enum constype): New datatype.
1082 (listn): New prototype.
1083 * alloc.c (listn): New function.
1084 (Fmemory_use_count, syms_of_alloc): Use it.
1085 * buffer.c (syms_of_buffer): Likewise.
1086 * callint.c (syms_of_callint): Likewise.
1087 * charset.c (define_charset_internal): Likewise.
1088 * coding.c (syms_of_coding): Likewise.
1089 * keymap.c (syms_of_keymap): Likewise.
1090 * search.c (syms_of_search): Likewise.
1091 * syntax.c (syms_of_syntax): Likewise.
1092 * w32.c (init_environment): Likewise.
1093 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1094 * xdisp.c (syms_of_xdisp): Likewise.
1095 * xfns.c (syms_of_xfns): Likewise.
1096
6195f384
DA
10972012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1098
1099 Fast save_excursion_save and save_excursion_restore.
1100 * lisp.h (struct Lisp_Excursion): New data type.
1101 (PVEC_EXCURSION): New pseudovector type.
1102 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1103 to deal with it. Adjust comments.
1104 (init_marker, attach_marker): New prototype.
1105 (unchain_marker): Adjust prototype.
1106 * marker.c (attach_marker): Change to global.
1107 (init_marker): New function.
1108 * alloc.c (Fmake_marker, build_marker): Use it.
1109 (build_marker): More easserts.
1110 (mark_object): Handle struct Lisp_Excursion.
1111 * editfns.c (save_excursion_save, save_excursion_restore):
1112 Reimplement to use struct Lisp_Excursion. Add comments.
1113
5eceb8fb
PE
11142012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1115
1116 Fix export of symbols to GDB (Bug#12036).
1117 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1118 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1119 emacs.c, as this is a more-suitable home. Had this been done earlier
1120 the fix for 12036 would have avoided some of the problems noted in
1121 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1122 would have been more obvious.
562157c8
PE
1123 * emacs.c: Do not include <verify.h>; no longer needed.
1124 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1125 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1126 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1127 Remove; now done in lisp.h.
1128 * lisp.h (PUBLISH_TO_GDB): New macro.
1129 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1130 (DATA_SEG_BITS): Use it.
1131 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1132 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1133 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1134 not be usable in #if. This simplifies things.
1135
d6749401
JB
11362012-07-26 Juanma Barranquero <lekktu@gmail.com>
1137
1138 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1139
1781b9e9
PE
11402012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1141
d89518db 1142 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1143 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1144 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1145 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1146 Adjust to changes in lisp.h and emacs.c, by using
1147 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1148 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1149 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1150 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1151 instead of gdb_valbits.
1152 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1153 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1154 instead of gdb_array_mark_flag.
1155 (xboolvector): Get size from $->size, not $->header.size.
1156 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1157 (xreload, hook-run, hookpost-run): Remove.
1158 * emacs.c: Include <verify.h>.
1159 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1160 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1161 Remove.
1162 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1163 (gdb_USE_LSB_TAG): New enum constants.
1164 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1165 Also define these as enum constants, so they're visible to GDB.
1166 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1167 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1168 as constants, so they're visible to GDB.
1169 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1170 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1171 Now enum constants, not macros, so they're visible to GDB.
1172 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1173 more convenient now. All uses changed.
1174 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1175 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1176
3628596a
DA
11772012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1178
1179 Explicitly free restriction data that are not needed anymore.
1180 * editfns.c (save_restriction_restore): Free restriction data.
1181
7abaf5cc
SM
11822012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1183
1184 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1185 add argument, tune behavior, and adjust all callers.
1186
71f88e00
PE
11872012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1188
1189 Use typedef for EMACS_INT, EMACS_UINT.
1190 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1191 than macros. This simplifies debugging in the usual case, since
1192 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1193 and it allows expressions involving EMACS_INT casts.
1194 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1195
57ec3034
JD
11962012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1197
1198 * nsterm.m (ns_read_socket): Return early if there is a modal
1199 window (Bug#12043).
1200
8137e7b3
MR
12012012-07-25 Martin Rudalics <rudalics@gmx.at>
1202
1203 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1204 that FOCUS-FRAME can be omitted.
1205
04e9897c
DA
12062012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1207
1208 Adjust buffer text indirection counters at the end of Fkill_buffer.
1209 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1210 buffer is definitely dead. This should really fix an issue reported
1211 by Christoph Scholtes again. (Bug#12007).
1212 (init_buffer_once): Initialize indirection counters of
1213 buffer_defaults and buffer_local_symbols (for sanity and safety).
1214
8a0484e1
EZ
12152012-07-24 Eli Zaretskii <eliz@gnu.org>
1216
1217 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1218 and continuation glyphs on tooltip frames, leave them at zero.
1219 Avoids continued lines in tooltips. (Bug#11832)
1220
fa691a83
DA
12212012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1222
1223 Simplify copy_overlay.
04e9897c 1224 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1225 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1226
436bc8e0
EZ
12272012-07-23 Eli Zaretskii <eliz@gnu.org>
1228
1229 * print.c (print_object): Don't crash when a frame's name is nil
1230 or invalid. (Bug#12025)
1231
1232 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1233 it signals an error when a tooltip frame is being created.
1234
d7a7fda3
DA
12352012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1236
1237 Cleanup miscellaneous objects allocation and initialization.
1238 * alloc.c (allocate_misc): Change to static. Add argument to
1239 specify the subtype. Adjust comment and users.
1240 (build_overlay): New function.
1241 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1242 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1243 (allocate_misc): Remove prototype.
1244 (build_overlay): Add prototype.
1245
12462012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1247
1248 Swap buffer text indirection counters in Fbuffer_swap_text.
1249 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1250 This avoids crash reported by Christoph Scholtes at
1251 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1252
9d7fa573
JD
12532012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1254
1255 * nsmenu.m (Popdown_data): New struct.
1256 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1257 free Popdown_data.
1258 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1259 (initWithContentRect): Make imgView and contentView non-static
1260 and autorelease them. Also autorelease img and matrix (Bug#12005).
1261 (dealloc): Remove (Bug#12005).
1262
0dd6d66d
DA
12632012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1264
1265 Adjust consing_since_gc when objects are explicitly freed.
1266 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1267 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1268 (free_cons, free_misc): Subtract object size from consing_since_gc.
1269
d36d71df
DA
12702012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1271
1272 Simplify and cleanup markers positioning code.
1273 * marker.c (attach_marker): More useful eassert.
1274 (live_buffer, set_marker_internal): New function.
1275 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1276 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1277
fb9ea40f
PE
12782012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1279
1280 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1281 as it's limited by the amount of memory, not by INT_MAX.
1282
2d5c5f7d
EZ
12832012-07-21 Eli Zaretskii <eliz@gnu.org>
1284
07fb592e
EZ
1285 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1286 in special-event-map. See the discussion at
1287 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1288 for the reasons.
1289
37a9eac8 1290 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1291 info.dwItemData. Fixes crashes on 64-bit Windows.
1292 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1293
c4328746
JD
12942012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1295
1296 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1297 (conversationIdentifier): Return value is NSInteger.
784051c4 1298 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1299
6e5d1c12
CY
13002012-07-21 Chong Yidong <cyd@gnu.org>
1301
1302 * window.c (decode_any_window): Signal an error if the window is
1303 on a dead frame (Bug#11984).
1304
9928463d
DA
13052012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1306
1307 Add indirection counting to speed up Fkill_buffer.
1308 * buffer.h (struct buffer): New member.
1309 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1310 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1311 base buffer indirection counter.
1312 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1313 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1314 through buffer list if indirection counter is 0.
1315
f8643a6b
DA
13162012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1317
1318 Extend the value returned by Fgarbage_collect with heap statistics.
1319 * alloc.c (Qheap): New symbol.
1320 (syms_of_alloc): DEFSYM it.
1321 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1322 (Fmemory_free): Remove.
1323 (syms_of_alloc): Don't defsubr it.
1324 * buffer.c (Fcompact_buffer): Remove.
1325 (syms_of_buffer): Don't defsubr it.
1326
dac616ff
DA
13272012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1328
1329 Make maybe_gc inline.
1330 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1331 * lisp.h (consing_since_gc, gc_relative_threshold)
1332 (memory_full_cons_threshold): Revert declaration.
1333 (maybe_gc): Remove prototype, define as inline.
1334 * alloc.c: Remove old commented-out code.
1335 (consing_since_gc, gc_relative_threshold)
1336 (memory_full_cons_threshold): Revert to global.
1337 (maybe_gc): Remove.
1338
d7ea76b4
DA
13392012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1340
1341 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1342 * lisp.h (build_unibyte_string): New function.
1343 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1344 * sysdep.c, w32fns.c, xfns.c: Use it.
1345 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1346 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1347 Adjust users accordingly.
1348 * font.h (font_open_by_name): Adjust prototype.
1349
765e61e3
DA
13502012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1351
1352 Cleanup calls to Fgarbage_collect.
1353 * lisp.h (maybe_gc): New prototype.
1354 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1355 Remove declarations.
1356 * alloc.c (maybe_gc): New function.
1357 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1358 Make them static.
1359 * bytecode.c (MAYBE_GC): Use maybe_gc.
1360 * eval.c (eval_sub, Ffuncall): Likewise.
1361 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1362 to avoid dependency from auto-save feature.
1363
52b852c7
PE
13642012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1365
1366 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1367 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1368 'for_each_per_buffer_object_at'.
1369 All uses changed. It's better to use upper-case for macros that
1370 cannot be implemented as functions, to give the reader a clue
1371 that they're special.
1372
5db81e33
SM
13732012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1374
1375 * alloc.c (Fgarbage_collect): Tweak docstring.
1376
5b835e1d
DA
13772012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1378
1379 Tweak the value returned from Fgarbage_collect again.
1380 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1381 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1382 Adjust documentation.
1383 (total_vector_bytes): Rename to total_vector_slots, adjust
1384 accounting.
1385 (total_free_vector_bytes): Rename to total_free_vector_slots,
1386 adjust accounting.
1387 (Qstring_bytes, Qvector_slots): New symbols.
1388 (syms_of_alloc): DEFSYM them.
1389
9cd47b72
DA
13902012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1391
1392 Buffer compaction primitive which may be used from Lisp.
1393 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1394 (syms_of_buffer): Register Fcompact_buffer.
1395 * alloc.c (Fgarbage_collect): Use compact_buffer.
1396 * buffer.h (compact_buffer): New prototype.
1397 (struct buffer_text): New member.
1398
d17337e5
DA
13992012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1400
1401 New macro to iterate over all buffers, miscellaneous cleanups.
1402 * lisp.h (all_buffers): Remove declaration.
1403 * buffer.h (all_buffers): Add declaration, with comment.
1404 (for_each_buffer): New macro.
1405 * alloc.c (Fgarbage_collect, mark_object): Use it.
1406 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1407 (init_buffer): Likewise.
1408 * data.c (Fset_default): Likewise.
1409 * coding.c (code_conversion_restore): Remove redundant check
1410 for dead buffer.
1411 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1412
60cfd278
AS
14132012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1414
1415 Fix bug that created negative-length intervals.
1416 * intervals.c (merge_interval_right, merge_interval_left):
1417 Do not zero out this interval if it is absorbed by its children,
1418 as this interval's total length doesn't change in that case. See
1419 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1420
d06714cb
PE
14212012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1422
83713154
PE
1423 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1424 when invoking (make-bool-vector N t) and N is a positive
1425 multiple of 8 -- the last 8 bits were mistakenly cleared.
1426
d06714cb
PE
1427 Remove some struct layout assumptions in bool vectors.
1428 * alloc.c (bool_header_size): New constant.
1429 (header_size, word_size): Move earlier, as they're now used earlier.
1430 Use 'word_size' in a few more places, where it's appropriate.
1431 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1432 padding before the data member of a bool vector.
1433 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1434 than doing the check by hand with an abort ().
1435
464d5a5e
SM
14362012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1437
5fbc0409
SM
1438 * eval.c (Fdefvar): Don't check constants since we only set the var if
1439 it's not yet defined anyway (bug#11904).
1440
464d5a5e
SM
1441 * lisp.h (last_undo_boundary): Declare new var.
1442 * keyboard.c (command_loop_1): Set it.
1443 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1444 were auto-added by the command loop (bug#11774).
1445
8dc2e44a
AS
14462012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1447
1448 * w32font.c (Qsymbol): Remove local definition.
1449 (syms_of_w32font): Don't DEFSYM it.
1450
169925ec
DA
14512012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1452
1453 Fix sweep_vectors to handle large bool vectors correctly.
1454 * alloc.c (sweep_vectors): Account total_vector_bytes for
1455 bool vectors larger than VBLOCK_BYTES_MAX.
1456
5fbfb018
CY
14572012-07-18 Chong Yidong <cyd@gnu.org>
1458
1459 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1460 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1461
3ab6e069
DA
14622012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1463
1464 Return more descriptive data from Fgarbage_collect.
1465 Suggested by Stefan Monnier in
1466 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1467 * alloc.c (bounded_number): New function.
1468 (total_buffers, total_vectors): New variable.
1469 (total_string_size): Rename to total_string_bytes, adjust users.
1470 (total_vector_size): Rename to total_vector_bytes, adjust users.
1471 (sweep_vectors): Account total_vectors and total_vector_bytes.
1472 (Fgarbage_collect): New return value. Adjust documentation.
1473 (gc_sweep): Account total_buffers.
1474 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1475 (VECTOR_SIZE): Remove.
1476 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1477 (Qinterval, Qmisc): New symbols.
1478 (syms_of_data): Initialize them.
1479 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1480 (Qcons, Qbuffer): New declarations.
1481
6d02fe5b
PE
14822012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1483
1484 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1485 Round up, not down. Improve doc.
1486
b7ffe040
DA
14872012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1488
1489 Restore old code in allocate_string_data to avoid Faset breakage.
1490 Reported by Julien Danjou <julien@danjou.info> in
1491 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1492 * alloc.c (allocate_string_data): Restore old code with minor
1493 adjustments, fix comment to explain this subtle issue.
1494
4dc7c8d5
SM
14952012-07-17 Eli Zaretskii <eliz@gnu.org>
1496
1497 Remove FILE_SYSTEM_CASE.
1498 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1499
1500 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1501 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1502 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1503 call-process-region passes it through expand-file-name.
1504
1505 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1506
15072012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1508
1509 Fix crash when creating indirect buffer (Bug#11917)
1510 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1511 Don't handle unbound variables specially if non-zero.
1512 (Fbuffer_local_variables): Pass zero.
1513 (clone_per_buffer_values): Pass non-zero.
1514
15152012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1516
1517 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1518 to make the loop interruptible.
1519
15202012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1521
1522 * gnutls.c (emacs_gnutls_handshake): Only retry if
1523 GNUTLS_E_INTERRUPTED.
1524
cce7fefc
DA
15252012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1526
1527 Cleanup and convert miscellaneous checks to eassert.
1528 * alloc.c (mark_interval): Fix comment, partially rephrase
1529 old comment from intervals.h (see below).
1530 * intervals.c (find_interval, adjust_intervals_for_insertion)
1531 (delete_interval, adjust_intervals_for_deletion)
1532 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1533 Convert to eassert.
1534 (adjust_intervals_for_insertion, make_new_interval):
1535 Remove obsolete and unused code.
1536 * intervals.h (struct interval): Remove obsolete comment.
1537 * textprotp.c (erase_properties): Remove unused code.
1538 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1539 (Fremove_list_of_text_properties): Convert to eassert.
1540
9ea10cc3
CY
15412012-07-17 Chong Yidong <cyd@gnu.org>
1542
1543 * editfns.c (Finsert_char): Doc fix.
1544
3900d5de
DA
15452012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1546
1547 Fix previous change to make Fmemory_free always accurate.
1548 * alloc.c (make_interval): Update total_free_intervals.
1549 (make_float): Likewise for total_free_floats.
1550 (free_cons, Fcons): Likewise for total_free_conses.
1551 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1552 Likewise for total_free_vector_bytes.
1553 (Fmake_symbol): Likewise for total_free_symbols.
1554 (bytes_free): Remove.
1555
7098646f
DA
15562012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1557
1558 Simple free memory accounting feature.
1559 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1560 (sweep_vectors): Accumulate size of free vectors.
1561 (Fgarbage_collect): Setup bytes_free.
1562 (Fmemory_free): New function.
1563 (syms_of_alloc): Register it.
1564
22657b40
DA
15652012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1566
1567 Cleanup overlays checking.
1568 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1569 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1570 eassert and OVERLAYP.
1571 (sort_overlays): Change to use OVERLAYP.
1572
ddfc8813
RK
15732012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1574
1575 * editfns.c (Finsert_char): Make it interactive, and make the
1576 second arg optional. Copy interactive spec and docstring from
1577 ucs-insert.
1578
7c26cf3c
PE
15792012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1580
1581 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1582 Unlike the other wrapped functions, fabs has an unspecified
1583 effect on errno.
1584
5d127af9
JD
15852012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1586
1587 * nsterm.m (keyDown): Interpret flags without left/right bits
1588 as the left key (Bug#11670).
1589
6a0dd1d7
DA
15902012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1591
1592 Remove empty and useless init functions.
1593 * lisp.h (init_character_once, init_fns, init_image)
1594 (init_filelock, init_sound): Remove prototype.
1595 * character.c (init_character_once): Remove.
1596 * filelock.c (init_filelock): Likewise.
1597 * fns.c (init_fns): Likewise.
1598 * image.c (init_image): Likewise.
1599 * sound.c (init_sound): Likewise.
1600 * emacs.c (main): Adjust accordingly.
1601
7a6136fd
DA
16022012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1603
1604 * gtkutil.h: Tiny cleanups.
1605 (use_old_gtk_file_dialog): Remove useless declaration.
1606 (xg_uses_old_file_dialog): Add suggested const attribute.
1607
ce811ad9
EZ
16082012-07-15 Eli Zaretskii <eliz@gnu.org>
1609
1610 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1611 (bidi_paragraph_init): Use it to limit search forward for a strong
1612 directional character in abnormally large paragraphs full of
1613 neutral or weak characters. (Bug#11943)
1614
c9adfeaa
SF
16152012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1616
1617 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1618 the toolbar (Bug#9451).
1619 (xg_make_tool_item): Give the widget event box a transparent
1620 background.
1621
fff62aa9
DA
16222012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1623
1624 Cleanup basic allocation variables and functions.
1625 * alloc.c (ignore_warnings, init_intervals, init_float)
1626 (init_cons, init_symbol, init_marker): Remove.
1627 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1628 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1629 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1630 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1631 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1632 (staticidx, init_alloc_once, init_strings, free_ablock):
1633 Remove redundant initialization.
1634 * fns.c (init_weak_hash_tables): Remove.
1635 * lisp.h (init_weak_hash_tables): Remove prototype.
1636
9730daca
DA
16372012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1638
1639 Use zero_vector where appropriate.
1640 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1641 accordingly.
1642 * lisp.h (zero_vector): New declaration.
1643 * font.c (null_vector): Remove.
1644 (syms_of_font): Remove initialization and staticpro.
1645 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1646 * keymap.c (Faccessible_keymaps): Likewise.
1647
2e2d2a13
LL
16482012-07-15 Leo Liu <sdl.web@gmail.com>
1649
1650 * fringe.c: Fix typo in comments.
1651
cd276f6e
LL
16522012-07-14 Leo Liu <sdl.web@gmail.com>
1653
1654 * fringe.c: Add a new bitmap exclamation-mark.
1655
5a1131d9
EZ
16562012-07-14 Eli Zaretskii <eliz@gnu.org>
1657
1658 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1659
1660 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1661 (HAVE_MENUS): Don't define, defined by editing config.in with
1662 msdos/sed2v2.inp.
1663 (GMALLOC_INHIBIT_VALLOC): Don't define.
1664 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1665
22e983b7
JB
16662012-07-14 Juanma Barranquero <lekktu@gmail.com>
1667
1668 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1669
5b3f250f
GM
16702012-07-14 Glenn Morris <rgm@gnu.org>
1671
1672 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1673 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1674 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1675
33d63ff4
GM
16762012-07-13 Glenn Morris <rgm@gnu.org>
1677
5b633342
GM
1678 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1679
33d63ff4
GM
1680 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1681 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1682
b55b9f85
JD
16832012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1684
0dc8cf50
JD
1685 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1686 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1687 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1688 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1689 where appropriate.
1690 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1691 as boolean expression.
1692 (x_set_window_size): Remove unused variable toolbar.
1693 (ns_get_color_default, ns_mod_to_lisp): Remove.
1694 (ns_mouse_position): Remove unused variables xchar and ychar.
1695 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1696 (ns_set_vertical_scroll_bar): Remove unused variable count.
1697 (ns_delete_terminal): Remove unused variable i.
1698 (ns_term_init): Remove unused variables r, g and b.
1699 (mouseDown): Remove unused variable window.
1700 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1701 (initFrameFromEmacs): Remove unused variable vbextra.
1702 (mouseEntered): Remove unused variables p and dpyinfo.
1703 (mouseExited): Remove unused variables p and r.
1704 (ns_define_frame_cursor, ns_clear_frame_area)
1705 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1706 (menuDown): Assign [sender tag] to variable and cast the variable.
1707
1708 * nsterm.h (menuDown): Add id as type to argument sender.
1709 (ns_display_info_for_name): Add Lisp_Object argument.
1710 (ns_term_init): Add Lisp_Object argument.
1711 (ns_map_event_to_object): Add void argument.
1712 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1713 prototype with arguments and only declare if __OBJC__.
1714 (nxatoms_of_nsselect): Add void argument.
1715 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1716 (ns_alloc_autorelease_pool): Add void argument.
1717 (ns_release_autorelease_pool): Add void* argument.
1718 (ns_get_defaults_value): Add const char* argument.
1719
1720 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1721 (initFromContents): Use SSDATA where appropriate.
1722 (ns_update_menubar): Add braces to ambigous if-else.
1723 (initWithTitle): Put () around assignment in if statement.
1724 (ns_menu_show): Remove unused variables window and keymap.
1725 (update_frame_tool_bar): Remove unused variable selected_p.
1726 (initWithContentRect): Remove unused variable this_cmd_name.
1727
1728 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1729 appropriate.
1730 (setXBMColor): Remove unused variable len.
1731 (setPixmapData): Put () around assignment in loop statement.
1732
1733 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1734 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1735 where appropriate.
1736 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1737 around assignment in loop statement.
1738 (nsfont_open): Remove unused variable i.
1739 (nsfont_open): Remove unused variable len.
1740 (nsfont_draw): Remove unused variable cs.
1741
1742 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1743 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1744 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1745 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1746 (Fns_font_name, Fns_perform_service)
1747 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1748 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1749 (ns_set_name): Remove unused variable view.
1750 (x_set_menu_bar_lines): Remove unused variable olines.
1751 (x_set_tool_bar_lines): Remove unused variable root_window.
1752 (Fns_list_colors): Put () around assignment in while statement.
1753 (Fns_perform_service): Remove unused variable len.
1754 (Fns_display_usable_bounds): Remove unused variable top.
1755 (syms_of_nsfns): Remove unused variable i.
1756
b55b9f85
JD
1757 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1758 memcpy (Bug#11907).
1759
ed9265fc 17602012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1761
1762 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1763 and free it with DestroyExceptionInfo (Bug#11558).
1764
ef099b57
JB
17652012-07-13 Juanma Barranquero <lekktu@gmail.com>
1766
1767 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1768 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1769 Set here, not in nt/config.nt.
1770
ea814a5d
EZ
17712012-07-13 Eli Zaretskii <eliz@gnu.org>
1772
1773 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1774 cursor overflow into the last glyph on display line when the right
1775 fringe is off. (Bug#11832)
1776
1a952767
PE
17772012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1778
1779 * xdisp.c (produce_special_glyphs): Now static.
1780 * dispextern.h (produce_special_glyphs): Remove decl.
1781
983188fd
GM
17822012-07-13 Glenn Morris <rgm@gnu.org>
1783
8d7c7eed 1784 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1785 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1786
983188fd
GM
1787 * s/usg5-4-common.h (USG, USG5):
1788 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1789 * s/sol2-6.h (SOLARIS2):
1790 * s/irix6-5.h (IRIX6_5):
1791 * s/hpux10-20.h (USG, USG5, HPUX):
1792 * s/gnu-linux.h (USG, GNU_LINUX):
1793 * s/freebsd.h (BSD_SYSTEM):
1794 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1795 * s/cygwin.h (CYGWIN):
1796 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1797 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1798
d1e68667 17992012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1800
1801 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1802
6de0e799
GM
18032012-07-13 Glenn Morris <rgm@gnu.org>
1804
739ae010
GM
1805 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1806
dbee5793
GM
1807 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1808
6de0e799
GM
1809 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1810 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1811
b82da769
GM
18122012-07-12 Glenn Morris <rgm@gnu.org>
1813
4fae5a7a 1814 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1815
1816 * process.c (init_process_emacs): Rename from init_process.
1817 The old name is also the name of a Mach system call.
1818 * lisp.h, emacs.c: Update for this name change.
1819 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1820 longer needed.
1821
5a979817
EZ
18222012-07-12 Eli Zaretskii <eliz@gnu.org>
1823
1824 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1825 memmove call that removes glyphs covered by the left truncation
1826 glyph. Improve commentary.
1827 (display_line): Fix display of continuation glyphs on GUI frames
1828 when the right fringe is turned off and variable-size fonts are
1829 used in the window. Move the code that appends a stretch glyph to
1830 produce_special_glyphs, so that it could be used for truncation
1831 and continuation glyphs alike.
1832 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1833 glyph of a suitably computed width, to align the special glyphs at
1834 the window margin. Code moved from display_line. (Bug#11832)
1835
3e91a053
GM
18362012-07-12 Glenn Morris <rgm@gnu.org>
1837
ba9e4b84
GM
1838 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1839
1840 * s/gnu-linux.h, s/hpux10-20.h:
1841 Do not unconditionally define HAVE_XRMSETDATABASE.
1842
3e91a053
GM
1843 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1844
b300b1f4
PE
18452012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1846
1847 Fix typos that broke OS X build.
1848 Reported by Randal L. Schwartz in
1849 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1850 * nsterm.m (ns_timeout): Add missing local decl.
1851 (ns_get_color): snprintf -> sprintf, to fix typo.
1852
6e777848
GM
18532012-07-12 Glenn Morris <rgm@gnu.org>
1854
3f922c37
GM
1855 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1856 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1857 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1858 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1859
0ab7b23a
GM
1860 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1861 Move PTY_OPEN to configure.
1862
6e777848
GM
1863 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1864 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1865 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1866
4a7edc24
DA
18672012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1868
1869 Use empty_unibyte_string where applicable.
1870 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1871 * lread.c (read1): Likewise.
1872 * xsettings.c (syms_of_xsettings): Likewise.
1873
308aab79
GM
18742012-07-12 Glenn Morris <rgm@gnu.org>
1875
42bd1719
GM
1876 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1877 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1878 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1879 * s/hpux10-20.h (RUN_TIME_REMAP):
1880 * s/bsd-common.h (TABDLY): Move to configure.
1881
1882 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1883
1884 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1885
ea0bbd17 1886 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1887 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1888
1889 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1890
308aab79
GM
1891 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1892 * s/template.h: Move NARROWPROTO to configure.
1893
ee1cf5cf
GM
18942012-07-11 Glenn Morris <rgm@gnu.org>
1895
30fe9bf4
GM
1896 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1897 unused since 2011-01-17 change to systty.h.
1898
ee1cf5cf
GM
1899 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1900 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1901 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1902
63e47e07
PE
19032012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1904
1905 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1906
c43fb4c3
GM
19072012-07-11 Glenn Morris <rgm@gnu.org>
1908
1909 * s/darwin.h, s/gnu-linux.h, s/template.h:
1910 Move INTERRUPT_INPUT to configure.
1911
e8df9267
DA
19122012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1913
1914 Minor adjustments to interning code.
1915 * lisp.h (intern, intern_c_string): Redefine as static inline
1916 wrappers for intern_1 and intern_c_string_1, respectively.
1917 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
1918 * lread.c (intern_1, intern_c_string_1, oblookup):
1919 Simplify Vobarray checking.
e8df9267
DA
1920 * font.c (font_intern_prop): Likewise. Adjust comment.
1921 * w32font.c (intern_font_name): Likewise.
1922
34348bd4
AS
19232012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1924
d96a1e0c
AS
1925 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1926
34348bd4
AS
1927 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1928 of Fcar/Fcdr if possible.
1929 * font.c (check_otf_features): Likewise.
1930 * fontset.c (Fnew_fontset): Likewise.
1931 * gnutls.c (Fgnutls_boot): Likewise.
1932 * minibuf.c (read_minibuf): Likewise.
1933 * msdos.c (IT_set_frame_parameters): Likewise.
1934 * xmenu.c (Fx_popup_dialog): Likewise.
1935 * w32menu.c (Fx_popup_dialog): Likewise.
1936
c8add24e
GM
19372012-07-11 Glenn Morris <rgm@gnu.org>
1938
4b575b3c
GM
1939 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1940 since nothing has defined it on these platforms.
1941
09f4e3b0
GM
1942 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1943 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1944
172bedef
GM
1945 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1946 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1947 Move CLASH_DETECTION to configure.
1948
249685df
GM
1949 * s/gnu.h: Remove file, which is now empty.
1950
c8add24e
GM
1951 * s/gnu.h, s/gnu-linux.h:
1952 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1953
b41253a3
JW
19542012-07-11 John Wiegley <johnw@newartisans.com>
1955
1956 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1957 function attribute, so we only use it if it exists in the
1958 compiler.
1959
d923b542
DA
19602012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1961
1962 Avoid call to strlen in fast_c_string_match_ignore_case.
1963 * search.c (fast_c_string_match_ignore_case): Change to use
1964 length argument. Adjust users accordingly.
1965 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1966
5ebbef1d
PE
19672012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1968
bb352260
PE
1969 Assume mkdir, rmdir.
1970 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1971 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1972
57054ddd
PE
1973 Assume rename.
1974 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1975
b747d3f7
PE
1976 Assume perror.
1977 * s/hpux10-20.h (HAVE_PERROR): Remove.
1978 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1979 Remove dummy definition, as this problem was obsolete long ago.
1980
5ebbef1d
PE
1981 Assume strerror.
1982 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1983
984e7f30
DA
19842012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1985
1986 Avoid calls to strlen in font processing functions.
1987 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
1988 (font_open_by_name): Change to use length argument.
1989 Adjust users accordingly.
d923b542
DA
1990 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1991 Adjust prototypes.
1992 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1993 Change to return ptrdiff_t.
984e7f30
DA
1994 (xfont_list_pattern, xfont_match): Use length returned by
1995 xfont_decode_coding_xlfd.
1996 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1997
20e94fdd
GM
19982012-07-11 Glenn Morris <rgm@gnu.org>
1999
9d596af3
GM
2000 * s/darwin.h, s/freebsd.h, s/netbsd.h:
2001 Move DONT_REOPEN_PTY to configure.
2002
20e94fdd
GM
2003 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
2004 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
2005
e99a530f
PE
20062012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2007
22ffb973
PE
2008 Remove "#define unix" that is no longer needed (Bug#11905).
2009 * s/aix4-2.h (unix): Remove; no longer needed.
2010
e9a9ae03
PE
2011 EMACS_TIME simplification (Bug#11875).
2012 This replaces macros (which typically do not work in GDB)
2013 with functions, typedefs and enums, making the code easier to debug.
2014 The functional style also makes code easier to read and maintain.
2015 * systime.h: Include <sys/time.h> on all hosts, not just if
2016 WINDOWSNT, since 'struct timeval' is needed in general.
2017 (EMACS_TIME): Now a typedef, not a macro.
2018 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2019 not macros.
2020 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2021 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2022 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2023 (EMACS_TIME_LE): Now functions, not macros.
2024 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2025 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2026 which are not functions. All uses rewritten to use:
2027 (make_emacs_time): New function.
2028 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2029 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2030 not functions. All uses rewritten to use the following, respectively:
2031 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2032 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2033 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2034 * fileio.c (Fcopy_file):
2035 * xterm.c (XTflash): Get the current time closer to when it's used.
2036 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2037
ffacb126
PE
2038 * bytecode.c (targets): Suppress -Woverride-init warnings.
2039
e99a530f
PE
2040 Simplify by avoiding confusing use of strncpy etc.
2041 * doc.c (Fsnarf_documentation):
2042 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2043 * frame.c (Fmake_terminal_frame):
2044 * gtkutil.c (get_utf8_string):
2045 * lread.c (openp):
2046 * nsmenu.m (ns_update_menubar):
2047 * regex.c (regerror):
2048 Prefer memcpy to strncpy and strncat when either will do.
2049 * fileio.c (Fsubstitute_in_file_name):
2050 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2051 (menu_separator_name_p):
2052 * nsmenu.m (ns_update_menubar):
2053 Prefer memcmp to strncmp when either will do.
2054 * nsterm.m: Include <ftoastr.h>.
2055 (ns_get_color):
2056 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2057 Prefer snprintf to strncpy.
2058 * nsterm.m (ns_term_init):
2059 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2060 * nsterm.m (ns_term_init):
2061 Avoid the need for strncpy, by using build_string or
2062 make_unibyte_string directly. Use dtoastr, not snprintf.
2063 * process.c (Fmake_network_process): Diagnose service names that
2064 are too long, rather than silently truncating them or creating
2065 non-null-terminated names.
2066 (Fnetwork_interface_info): Likewise, for interface names.
2067 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2068 Prefer sprintf to strncat.
2069 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2070 Prefer vsnprintf to vsprintf + strncpy.
2071
c59592b3
GM
20722012-07-10 Glenn Morris <rgm@gnu.org>
2073
2074 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2075 Clarify fallback case.
2076
7d7bbefd
DA
20772012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2078
2079 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2080 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2081 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2082 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2083 where argument type is known to be a Lisp_Cons.
2084
3a4c8000
TT
20852012-07-10 Tom Tromey <tromey@redhat.com>
2086
2087 * bytecode.c (BYTE_CODE_THREADED): New macro.
2088 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2089 (enum byte_code_op): New type.
2090 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2091 (exec_byte_code): Use them. Use token threading when applicable.
2092
2a0213a6
DA
20932012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2094
2095 Optimize pure C strings initialization.
2096 * lisp.h (make_pure_string): Fix prototype.
2097 (build_pure_c_string): New function, defined as static inline. This
2098 provides a better opportunity to optimize away calls to strlen when
2099 the function is called with compile-time constant argument.
2100 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2101 argument, adjust users accordingly. Use build_pure_c_string where
2102 appropriate.
2103 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2104 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2105 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2106
cb1caeaf
DA
21072012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2108
2109 Avoid calls to strlen in miscellaneous functions.
2110 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2111 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2112 * lread.c (openp): Likewise.
2113
c293e30c
DA
21142012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2115
2116 Avoid calls to strlen in path processing functions.
2117 * fileio.c (file_name_as_directory): Add comment. Change to add
2118 srclen argument and return the length of result. Adjust users
2119 accordingly.
2120 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2121 swap 1st and 2nd arguments to obey the common convention.
2122 Adjust users accordingly.
c293e30c
DA
2123 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2124
9e059e3f
GM
21252012-07-10 Glenn Morris <rgm@gnu.org>
2126
d02eb359
GM
2127 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2128 Move PENDING_OUTPUT_COUNT definition to configure.
2129
882cf227
GM
2130 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2131 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2132 * s/gnu.h (DATA_START): Move definitions to configure.
2133
af6e839f
GM
2134 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2135 We include usg5-4-common.h, which defines them both.
2136
40289a12
GM
2137 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2138 O_RDONLY already includes it).
2139
9e059e3f
GM
2140 Stop ns builds setting the EMACSLOADPATH environment variable.
2141 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2142 Now it does not set EMACSLOADPATH, just returns the load-path string.
2143 * nsterm.h: Update accordingly.
2144 * lread.c [HAVE_NS]: Include nsterm.h.
2145 (init_lread) [HAVE_NS]: Use ns_load_path.
2146 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2147
7c4e8ec0
GM
21482012-07-09 Glenn Morris <rgm@gnu.org>
2149
d4f600ff
GM
2150 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2151 since the included bsd-common.h does so.
2152
cbb31951
GM
2153 Stop ns builds setting the EMACSPATH environment variable.
2154 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2155 (ns_init_paths): Do not set EMACSPATH.
2156 * nsterm.h (ns_exec_path): Add it.
2157 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2158 Use ns_exec_path.
2159
7c4e8ec0
GM
2160 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2161
26bccfae
PE
21622012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2163
a0bee46f
PE
2164 * process.c (wait_reading_process_output): 'waitchannels' was unset
2165 when read_kbd || !NILP (wait_for_cell); fix this.
2166
5994c183
PE
2167 Add GCC-style 'const' attribute to functions that can use it.
2168 * character.h (char_resolve_modifier_mask):
2169 * keyboard.h (make_ctrl_char):
2170 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2171 (init_character_once, next_almost_prime, init_fns, init_image)
2172 (flush_pending_output, init_sound):
2173 * mem-limits.h (start_of_data):
2174 * menu.h (finish_menu_items):
2175 Add ATTRIBUTE_CONST.
2176 * emacs.c (DEFINE_DUMMY_FUNCTION):
2177 Declare the dummy function with ATTRIBUTE_CONST.
2178 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2179 Add decls with ATTRIBUTE_CONST.
2180
26bccfae
PE
2181 Minor improvements to make_formatted_string.
2182 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2183 where int is good enough, as vsprintf returns an int.
2184 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2185
a8290ec3
DA
21862012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2187
2188 Use make_formatted_string to avoid double length calculation.
2189 * lisp.h (make_formatted_string): New prototype.
2190 * alloc.c (make_formatted_string): New function.
2191 * buffer.c (Fgenerate_new_buffer_name): Use it.
2192 * dbus.c (syms_of_dbusbind): Likewise.
2193 * editfns.c (Fcurrent_time_zone): Likewise.
2194 * filelock.c (get_boot_time): Likewise.
2195 * frame.c (make_terminal_frame, set_term_frame_name)
2196 (x_report_frame_params): Likewise.
2197 * image.c (gs_load): Likewise.
2198 * minibuf.c (get_minibuffer): Likewise.
2199 * msdos.c (dos_set_window_size): Likewise.
2200 * process.c (make_process): Likewise.
2201 * xdisp.c (ensure_echo_area_buffers): Likewise.
2202 * xsettings.c (apply_xft_settings): Likewise.
2203
d01ba2f1
GM
22042012-07-09 Glenn Morris <rgm@gnu.org>
2205
2206 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2207 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2208 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2209 * nsterm.h (ns_etc_directory): Add it.
2210 * callproc.c [HAVE_NS]: Include nsterm.h.
2211 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2212
f1f924b6
DA
22132012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2214
2215 Move marker debugging code under MARKER_DEBUG.
2216 * marker.c (MARKER_DEBUG): Move marker debugging code under
2217 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2218 for bootstrap with --enable-checking (~3x slowdown reported
2219 by Juanma Barranquero <lekktu@gmail.com>).
2220 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2221
ab531b66
PE
22222012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2223
2224 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2225 See <http://bugs.gnu.org/11825#29>.
2226
c4b3bc8a
EZ
22272012-07-08 Eli Zaretskii <eliz@gnu.org>
2228
2229 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2230 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2231 (display_line): Add commentary about displaying truncation glyphs
2232 on GUI frames.
2233 (produce_special_glyphs): Move here from term.c.
2234
2235 * term.c (produce_special_glyphs): Move to xdisp.c.
2236
2237 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2238 section.
c4b3bc8a 2239
b676b881
AS
22402012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2241
f17c5273
AS
2242 * xdisp.c (display_line): Avoid warning about implicit declaration
2243 of FRAME_FONT.
2244
298819b9
AS
2245 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2246
b676b881
AS
2247 * lisp.h: Remove empty conditional.
2248
6045c4fd
PE
22492012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2250
b3350bf9
PE
2251 * lread.c (load_path_check): Now static.
2252
6045c4fd
PE
2253 Fix some minor --with-ns problems found by static checking.
2254 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2255 (x_set_font) [!HAVE_X_WINDOWS]:
2256 * image.c (xpm_load_image) [HAVE_NS]:
2257 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2258 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2259 Remove unused local.
2260 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2261 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2262 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2263 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2264 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2265 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2266 Fix pointer signedness problem.
2267 * xfaces.c (FRAME_X_FONT_TABLE):
2268 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2269
929e7845
GM
22702012-07-07 Glenn Morris <rgm@gnu.org>
2271
2272 * lread.c (load_path_check): New function, split from init_lread.
2273 (init_lread): Reorganize. Motivation:
2274 If EMACSLOADPATH is set, check/warn about that rather than the
2275 defaults, which we are not going to use. Hence we can remove
2276 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2277 Don't warn if site-lisp directories are missing.
2278 If not installed, start from a blank load-path, since
2279 PATH_LOADSEARCH refers to the eventual installation directories.
2280
58dd0aa4
EZ
22812012-07-07 Eli Zaretskii <eliz@gnu.org>
2282
2283 Support truncation and continuation glyphs on GUI frames, when
2284 fringes are disabled. (Bug#11832)
2285 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2286 continuation glyphs even if on GUI frames.
2287 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2288 or both, are absent.
2289 (start_display, move_it_in_display_line_to): Handle the case of a
2290 GUI frame without a fringe to display continuation or truncation
2291 glyphs.
2292 (insert_left_trunc_glyphs): Support GUI frames: make sure
2293 truncation glyphs overwrite enough glyphs from the current line to
2294 have sufficient space in pixels.
2295 (display_line): Support truncation and continuation glyphs on GUI
2296 frames. If some spare pixels are left on the line after inserting
2297 the truncation glyphs, fill that space with a stretch glyph of a
2298 suitably computed width.
2299
2300 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2301 produce_glyphs, to support GUI sessions.
2302
31571fd7
PE
23032012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2304
5a16b9bc
PE
2305 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2306
f3047c75
PE
2307 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2308
31571fd7
PE
2309 Do not require float-time's arg to fit in time_t (Bug#11825).
2310 This works better on hosts where time_t is unsigned, and where
2311 float-time is applied to the (negative) difference between two times.
2312 * editfns.c (decode_time_components): Last arg is now double *,
2313 not int *, and means to store all the result as a double, without
2314 worrying about whether the seconds part fits in time_t.
2315 All callers changed.
2316 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2317 All callers changed.
2318 (Ffloat_time): Do not fail merely because the specified time falls
2319 outside of time_t range.
2320
4516fbef
GM
23212012-07-07 Glenn Morris <rgm@gnu.org>
2322
2323 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2324 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2325 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2326
07adc2c6
JB
23272012-07-07 Juanma Barranquero <lekktu@gmail.com>
2328
2329 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2330 Update dependencies.
2331
2332 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2333
fd573f31
PE
23342012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2335
fee5959d
PE
2336 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2337 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2338 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2339 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2340 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2341 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2342
fd573f31
PE
2343 * xfont.c (compare_font_names): Redo to omit the need for casts.
2344
ddadbc0e
AS
23452012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2346
fca8d6b6
AS
2347 * xfns.c (Fx_change_window_property): Doc fix.
2348 * w32fns.c (Fx_change_window_property): Doc fix.
2349
ddadbc0e
AS
2350 * w32fns.c (Fx_window_property): Accept the same arguments as the
2351 X Windows version. Doc fix.
2352 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2353
ed9265fc 23542012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2355 Eli Zaretskii <eliz@gnu.org>
2356
2357 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2358 Windows-specific code from nt/config.nt moved here.
2359 Obsolete settings removed.
2360
216ee680
PE
23612012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2362
2363 * process.c: Avoid unnecessary calls to gettime.
2364 (wait_reading_process_output): Don't get the time of day
2365 when gobbling data immediately and not waiting, as there's no need
2366 for it in that case. This removes a FIXME.
2367
bdd091e4
JD
23682012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2369
2370 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2371 is defined (Bug#11768).
2372
9d44f8ce
DA
23732012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2374
2375 Fix marker debugging code.
2376 * marker.c (byte_char_debug_check): Do not perform the check
2377 if buffer is not multibyte.
090bd7cb
JB
2378 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2379 Call byte_char_debug_check with correct arguments.
9d44f8ce 2380
90fc4786
DA
23812012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2382
2383 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2384 * marker.c (byte_char_debug_check, count_markers):
2385 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2386 (byte_debug_flag): Remove.
2387 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2388 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2389
7b7ae965
DA
23902012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2391
4e57b342
DA
2392 Avoid code repetition in marker-related functions.
2393 * marker.c (attach_marker): New function.
2394 (Fset_marker, set_marker_restricted, set_marker_both)
2395 (set_marker_restricted_both): Use it.
2396 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2397 Consistently rename charno to charpos.
2398 (marker_position): Add eassert.
2399 (marker_byte_position): Convert to eassert.
2400
24012012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2402
2403 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2404 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2405 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2406
657924ff
DA
24072012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2408
2409 Introduce fast path for the widely used marker operation.
2410 * alloc.c (build_marker): New function.
2411 * lisp.h (build_marker): New prototype.
2412 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2413 * composite.c (autocmp_chars): Likewise.
2414 * editfns.c (buildmark): Remove.
2415 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2416 (save_restriction_save): Use build_marker.
2417 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2418 * window.c (save_window_save): Likewise.
2419
041a49a6
DA
24202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2421
2422 Do not use Fdelete_overlay in delete_all_overlays
2423 to avoid redundant calls to unchain_overlay.
2424 * buffer.c (drop_overlay): New function.
2425 (delete_all_overlays, Fdelete_overlay): Use it.
2426 * minibuf.c (get_minibuffer): Fix comment.
2427
7dca65a4
PE
24282012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2429
2430 Port to OpenBSD 5.1 amd64.
2431 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2432 This is needed for OpenBSD, and should be harmless on all BSD systems.
2433 Also, include <sys/sysctl.h>, as it should be available on all
2434 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2435 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2436 use p_pid member, not kp_proc.pid.
2437
8eb876e2
GM
24382012-07-06 Glenn Morris <rgm@gnu.org>
2439
2440 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2441
38182d90
PE
24422012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2443
2444 More xmalloc and related cleanup.
2445 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2446 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2447 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2448 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2449 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2450 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2451 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2452 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2453 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2454 * xterm.c:
2455 Omit needless casts involving void * pointers and allocation.
2456 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2457 as the former is more robust if P's type is changed.
2458 Prefer xzalloc to xmalloc + memset 0.
2459 Simplify malloc-or-realloc to realloc.
2460 Don't worry about xmalloc returning a null pointer.
2461 Prefer xstrdup to xmalloc + strcpy.
2462 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2463 growing it.
2464 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2465 alloca of a constant.
2466
6dd5a677
EZ
24672012-07-05 Eli Zaretskii <eliz@gnu.org>
2468
2469 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2470 hscroll is larger than the line width. Fixes long and futile
2471 looping inside extend_face_to_end_of_line (on a TTY) producing
2472 glyphs that are not needed and thrown away.
2473
6b312f0f
DA
24742012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2475
2476 * marker.c (set_marker_restricted_both): Simplify by using
2477 clip_to_bounds.
2478
f520ef9b
PE
24792012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2480
2481 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2482
383b7c95
JD
24832012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2484
2485 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2486 not defined (Bug#11768).
2487 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2488 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2489 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2490 followed by gtk_box_set_homogeneous (Bug#11768).
2491 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2492 (update_theme_scrollbar_width, xg_create_scroll_bar):
2493 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2494 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2495 (is_box_type): New function (Bug#11768).
2496 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2497 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2498 with default display (Bug#11768).
2499
d6e7bf45
EZ
25002012-07-05 Eli Zaretskii <eliz@gnu.org>
2501
2502 * xdisp.c (window_hscroll_limited): New function.
2503 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2504 coordinates when window's hscroll is set to insanely large
2505 values. (Bug#11857)
2506
431391ec
JB
25072012-07-05 Juanma Barranquero <lekktu@gmail.com>
2508
2509 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2510 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2511
23f86fce
DA
25122012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2513
2514 Cleanup xmalloc.
2515 * lisp.h (xzalloc): New prototype. Omit needless casts.
2516 * alloc.c (xzalloc): New function. Omit needless casts.
2517 * charset.c: Omit needless casts. Convert all calls to
2518 xmalloc with following memset to xzalloc.
2519 * dispnew.c: Likewise.
2520 * fringe.c: Likewise.
2521 * image.c: Likewise.
2522 * sound.c: Likewise.
2523 * term.c: Likewise.
2524 * w32fns.c: Likewise.
2525 * w32font.c: Likewise.
2526 * w32term.c: Likewise.
2527 * xfaces.c: Likewise.
2528 * xfns.c: Likewise.
2529 * xterm.c: Likewise.
2530 * atimer.c: Omit needless casts.
2531 * buffer.c: Likewise.
2532 * callproc.c: Likewise.
2533 * ccl.c: Likewise.
2534 * coding.c: Likewise.
2535 * composite.c: Likewise.
2536 * doc.c: Likewise.
2537 * doprnt.c: Likewise.
2538 * editfns.c: Likewise.
2539 * emacs.c: Likewise.
2540 * eval.c: Likewise.
2541 * filelock.c: Likewise.
2542 * fns.c: Likewise.
2543 * gtkutil.c: Likewise.
2544 * keyboard.c: Likewise.
2545 * lisp.h: Likewise.
2546 * lread.c: Likewise.
2547 * minibuf.c: Likewise.
2548 * msdos.c: Likewise.
2549 * print.c: Likewise.
2550 * process.c: Likewise.
2551 * region-cache.c: Likewise.
2552 * search.c: Likewise.
2553 * sysdep.c: Likewise.
2554 * termcap.c: Likewise.
2555 * terminal.c: Likewise.
2556 * tparam.c: Likewise.
2557 * w16select.c: Likewise.
2558 * w32.c: Likewise.
2559 * w32reg.c: Likewise.
2560 * w32select.c: Likewise.
2561 * w32uniscribe.c: Likewise.
2562 * widget.c: Likewise.
2563 * xdisp.c: Likewise.
2564 * xmenu.c: Likewise.
2565 * xrdb.c: Likewise.
2566 * xselect.c: Likewise.
2567
0497dc44
PE
25682012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2569
2570 * fileio.c (time_error_value): Check the right error number.
2571 Problem reported by Troels Nielsen in
2572 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2573
356e7178
PE
25742012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2575
4e71fd89
PE
2576 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2577 This should be fixed in a better way; see Eli Zaretskii in
2578 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2579 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2580
f0941253
PE
2581 * fileio.c (time_error_value): Rename from special_mtime.
2582 The old name's problems were noted by Eli Zaretskii in
2583 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2584
065c9eb4
PE
2585 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2586 This variable's comment says Emacs needs at least one GDB-visible
2587 symbol of type enum pvec_type, to work around GDB problems.
2588 The symbol's value doesn't matter.
2589
356e7178
PE
2590 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2591 that causes compilation to fail on pre-C99 compilers.
2592
ed9265fc 25932012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2594
2595 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2596 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2597
3884d954
DA
25982012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2599
d209e2fb 2600 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2601 headers for buffer_defaults and buffer_local_symbols.
2602 Reported by Juanma Barranquero <lekktu@gmail.com>.
2603
ee28be33
SM
26042012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2605
2606 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2607 * lisp.h (enum pvec_type): Use fewer bits.
2608 (PSEUDOVECTOR_SIZE_BITS): New constant.
2609 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2610 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2611 change in pvec_type.
2612 (PSEUDOVECTOR_TYPEP): New macro.
2613 (TYPED_PSEUDOVECTORP): Use it.
2614 * fns.c (internal_equal): Adapt code to extract pvectype.
2615 * emacs.c (gdb_pvec_type): Update type.
2616 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2617 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2618 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2619 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2620 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2621 abusing vector->header.next.nbytes.
2622 (live_vector_p): Use PVEC_TYPE.
2623 (mark_object): Adapt code to extract pvectype. Use switch.
2624
c7f2cd7f
PE
26252012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2626
2627 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2628 Tighten new eassert a bit.
2629
8ce70ed2
DA
26302012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2631
2632 Fix compilation with --enable-gcc-warnings and -O1
2633 optimization level.
2634 * doprnt.c (doprnt): Change type of tem to int, initialize
2635 to avoid compiler warning. Add eassert.
2636 * search.c (simple_search): Initialize match_byte to avoid
2637 compiler warning. Add eassert.
2638
dea7f1e5
PE
26392012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2640
24a212eb
PE
2641 Avoid weird behavior with large horizontal scrolls.
2642 Without this change, for example, large hscroll values would
2643 mess up Emacs's display on Fedora 15 x86, presumably due to
2644 overflows in int calculations in the display code.
2645 Also, if buffers had long lines, Emacs would freeze.
2646 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2647 (set_window_hscroll): New function, containing the old guts of
2648 Fset_window_hscroll. Return the clipped value.
2649 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2650 This avoids the need to check against PTRDIFF_MAX.
2651
dea7f1e5
PE
2652 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2653
76046526
DA
26542012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2655
2656 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2657
39adff0d
PE
26582012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2659
63807d47
PE
2660 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2661 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2662 since GCC 4.4.6 issues a bogus warning for them.
2663
39adff0d
PE
2664 Fix bugs in file timestamp newness comparisons.
2665 * fileio.c (Ffile_newer_than_file_p):
2666 * lread.c (Fload): Use full timestamp resolution of files,
2667 not just the 1-second resolution, so that files that are only
2668 slightly newer still count as newer.
2669 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2670 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2671
dbeed9a6
PE
26722012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 * fileio.c: Improve handling of file time marker. (Bug#11852)
2675 (special_mtime): New function.
2676 (Finsert_file_contents, Fverify_visited_file_modtime):
2677 Use it to set special mtime values consistently.
2678
636334d6
AS
26792012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2680
2681 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2682 marker for non-existing file. (Bug#11852)
2683
e2017fe2
GM
26842012-07-03 Glenn Morris <rgm@gnu.org>
2685
2686 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2687 and did not make it into globals.h).
2688
404dbd37
TT
26892012-07-03 Tom Tromey <tromey@redhat.com>
2690
2691 * window.c (Fset_window_margins, Fset_window_fringes)
2692 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2693 * textprop.c (Fprevious_property_change): No longer static.
2694 * syntax.c (Fsyntax_table_p): No longer static.
2695 * process.c (Fget_process, Fprocess_datagram_address): No longer
2696 static.
2697 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2698 * keyboard.c (Fcommand_execute): No longer static.
2699 Remove EXFUN.
2700 * insdel.c (Fcombine_after_change_execute): No longer static.
2701 * image.c (Finit_image_library): No longer static.
2702 * fileio.c (Fmake_symbolic_link): No longer static.
2703 * eval.c (Ffetch_bytecode): No longer static.
2704 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2705 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2706 No longer static.
404dbd37
TT
2707 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2708 static.
2709 * dired.c (Ffile_attributes): No longer static.
2710 * composite.c (Fcomposition_get_gstring): No longer static.
2711 * callproc.c (Fgetenv_internal): No longer static.
2712
2713 * ccl.h: Remove EXFUNs.
2714 * buffer.h: Remove EXFUNs.
2715 * dispextern.h: Remove EXFUNs.
2716 * intervals.h: Remove EXFUNs.
2717 * fontset.h: Remove EXFUN.
2718 * font.h: Remove EXFUNs.
2719 * dosfns.c (system_process_attributes): Remove EXFUN.
2720 * keymap.h: Remove EXFUNs.
2721 * lisp.h: Remove EXFUNs.
2722 * w32term.h: Remove EXFUNs.
2723 * window.h: Remove EXFUNs.
2724 * xsettings.h: Remove EXFUN.
2725 * xterm.h: Remove EXFUN.
2726
8e4fd1e1
GM
27272012-07-03 Glenn Morris <rgm@gnu.org>
2728
2729 * lisp.h (Frandom): Make it visible to C.
2730 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2731 buffer for invisible buffers. (Bug#1229)
2732
ca95b3eb
DA
27332012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2734
2735 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2736 values which aren't power of 2.
14ae4239
BT
2737 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2738 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2739 accordingly.
2740
7555c33f
SM
27412012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2742
2743 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2744
2745 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2746
d12e8f5a
DA
27472012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2748
2749 * alloc.c (allocate_vector_block): Remove redundant
2750 calls to mallopt if DOUG_LEA_MALLOC is defined.
2751 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2752 avoid calls to mallopt if zero_vector is returned.
2753
296094c3
DA
27542012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2755
2756 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2757 is enabled, avoid dereferencing NULL current_sblock if
2758 running undumped.
2759
36429c89
DA
27602012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2761
2762 Cleanup basic buffer management.
2763 * buffer.h (struct buffer): Change layout to use generic vector
2764 marking code. Fix some comments. Change type of 'clip_changed'
2765 to bitfield. Remove unused #ifndef old.
2766 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2767 (GET_OVERLAYS_AT): Fix indentation.
2768 (for_each_per_buffer_object_at): New macro.
2769 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2770 (Fbuffer_local_variables): Use it.
2771 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2772 * alloc.c (allocate_buffer): Adjust to match new layout of
2773 struct buffer. Fix comment.
2774 (mark_overlay): New function.
2775 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2776 Lisp area of struct buffer.
2777 (mark_object): Use it. Adjust marking of misc objects
2778 and related comments.
2779
3b3e4cac
PE
27802012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2781
2782 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2783 wrapper that is not needed because the wrapped code is a no-op (zero
2784 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2785 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2786
cf5c0175
DA
27872012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2788
2789 * alloc.c (mark_buffer): Simplify. Remove prototype.
2790 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2791 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2792 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2793 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2794
ca26824c
GM
27952012-06-30 Glenn Morris <rgm@gnu.org>
2796
2e4c5312
GM
2797 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2798
ca26824c
GM
2799 * epaths.in (PATH_SITELOADSEARCH): New.
2800 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2801 This is rather than relying on --enable-locallisppath elements
2802 having "site-lisp" in their names. (Bug#10208#25, 11658)
2803
0d23c240
EZ
28042012-06-30 Eli Zaretskii <eliz@gnu.org>
2805
c9240d7a
EZ
2806 * w32proc.c (sys_select): Accept and ignore one more argument.
2807
2808 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2809
0d23c240 2810 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2811 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2812
2813 * sysdep.c: Don't include dos.h and dosfns.h.
2814
2815 * process.c (sys_select):
2816 * msdos.c (sys_select): Accept one more argument and ignore it.
2817
2818 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2819 adapt data types and code to that.
2820
2821 * dosfns.c:
2822 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2823 which clashes with the gnulib function of the same name.
2824
af5a5a98
AS
28252012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2826
c5e4379c
AS
2827 * font.c (font_style_to_value, font_style_symbolic)
2828 (font_prop_validate_style): Add type checks for values in
2829 font_style_table.
2830
af5a5a98
AS
2831 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2832 argument.
2833 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2834 uses.
2835
8d38f461
EZ
28362012-06-29 Eli Zaretskii <eliz@gnu.org>
2837
2e5a6631
EZ
2838 * xdisp.c (try_window_id): Undo last change.
2839
8d38f461
EZ
2840 * w32.c (getwd): Adjust commentary about startup_dir.
2841 (init_environment): Always call sys_access, even in non-MSVC
2842 builds. Don't chdir to the directory of the Emacs executable.
2843 This undoes code from 1997 which was justified by the need to
2844 "avoid conflicts when removing and renaming directories". But its
2845 downside was that every relative file name was being interpreted
2846 relative to the directory of the Emacs executable, which can never
2847 be TRT. In particular, it broke sys_access when called with
2848 relative file names.
2849 (sys_access): Map GetLastError to errno.
2850
2af3565e
DA
28512012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2852
2853 * window.h (struct window): Change type of 'fringes_outside_margins'
2854 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2855 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2856 Adjust comment.
2857 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2858 to ptrdiff_t.
2859
c8d3a25c 28602012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2861
c8d3a25c
GM
2862 * gnutls.c (emacs_gnutls_handshake):
2863 Add QUIT to make the loop interruptible.
57570cd3 2864
c8d3a25c 28652012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2866
c8d3a25c
GM
2867 * charset.c (init_charset): Make lack of etc/charsets fatal.
2868
3e984ee8
DA
28692012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2870
2871 * editfns.c (region_limit): Fix type mismatch.
2872
ef884f23
DA
28732012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2874
2875 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2876 undefined. Convert from xassert to eassert.
2877 * nsmenu.m: Convert from xassert to eassert.
2878 * nsterm.m: Likewise.
2879
7d7e0027
SM
28802012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2881
2882 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2883
aa754e6a
PE
28842012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2885
2886 Avoid integer overflow on scroll-left and scroll-right.
2887 * window.c (HSCROLL_MAX): New macro.
2888 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2889 overflow when requested scroll falls outside ptrdiff_t range.
2890
80b00b08
DA
28912012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2892
2893 * window.h (struct window): Change type of 'hscroll',
2894 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2895 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2896 Adjust users accordingly.
2897 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2898 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2899 from EMACS_INT to ptrdiff_t.
2900 (make_window): Omit redundant initialization.
2901
62b2bcf6
JB
29022012-06-28 Juanma Barranquero <lekktu@gmail.com>
2903
2904 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2905
45942c7d
DA
29062012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2907
2908 * window.h (struct window): Change type of 'use_time' and
2909 'sequence_number' from Lisp_Object to int.
2910 * frame.c (make_frame): Adjust users accordingly.
2911 * print.c (print_object): Likewise.
2912 * window.c (select_window, Fwindow_use_time, make_parent_window)
2913 (make_window): Likewise.
2914
e509cfa6
DA
29152012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2916
2917 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2918 enabled with --enable-checking=[all,glyphs] configure option.
2919 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2920 adjust comments accordingly.
2921 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2922 undefined, adjust comments accordingly.
2923 * image.c: Likewise.
2924 * scroll.c: Likewise.
2925 * w32fns.c: Likewise.
2926 * w32term.c: Likewise.
2927 * xdisp.c: Likewise.
2928 * xfaces.c: Likewise.
2929 * xfns.c: Likewise.
2930 * xterm.c: Likewise.
2931
a54e2c05
DA
29322012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2933
2934 Generalize run-time debugging checks.
2935 * dispextern.h (XASSERTS): Remove.
2936 * fontset.c (xassert): Remove.
2937 Convert from xassert to eassert.
2938 * alloc.c: Convert from xassert to eassert.
2939 * bidi.c: Likewise.
2940 * dispnew.c: Likewise.
2941 * fns.c: Likewise.
2942 * fringe.c: Likewise.
2943 * ftfont.c: Likewise.
2944 * gtkutil.c: Likewise.
2945 * image.c: Likewise.
2946 * keyboard.c: Likewise.
2947 * menu.c: Likewise.
2948 * process.c: Likewise.
2949 * scroll.c: Likewise.
2950 * sound.c: Likewise.
2951 * term.c: Likewise.
2952 * w32console.c: Likewise.
2953 * w32fns.c: Likewise.
2954 * w32term.c: Likewise.
2955 * window.c: Likewise.
2956 * xdisp.c: Likewise.
2957 * xfaces.c: Likewise.
2958 * xfns.c: Likewise.
2959 * xselect.c: Likewise.
2960 * xterm.c: Likewise.
2961
1ec4b7b2
SM
29622012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2963
2964 * fns.c (maybe_resize_hash_table): Output message when growing the
2965 purify-hashtable.
2966
2014308a
DA
29672012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2968
2969 * alloc.c (allocate_string_data): Remove dead code.
2970 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2971 avoid GCC warning about unused macro.
2972
246155eb
DA
29732012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2974
2975 * alloc.c (allocate_string): Omit intervals initialization.
2976 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2977 as in make_pure_string and make_pure_c_string.
2978
43184b7b
DA
29792012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2980
d209e2fb 2981 * alloc.c (allocate_string): Fix last change.
43184b7b 2982
3fe6dd74
DA
29832012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2984
d209e2fb 2985 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2986 to memset, add explicit initialization where appropriate.
2987
1ba6038a
GM
29882012-06-27 Glenn Morris <rgm@gnu.org>
2989
2990 * lisp.mk (lisp): Remove paths.elc.
2991
c89926a5
CY
29922012-06-27 Chong Yidong <cyd@gnu.org>
2993
2994 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2995
ed6b3510
JW
29962012-06-26 John Wiegley <johnw@newartisans.com>
2997
1ec4b7b2 2998 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2999 on Mac OS X Lion: __mod_init_func and __mod_term_func.
3000
ed6b3510
JW
3001 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
3002 when building with Clang.
3003
8edd4a2b
SM
30042012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
3005
3006 * eval.c (Fapply): Allow calling it with a single argument.
3007
f6f62d1b
EZ
30082012-06-26 Eli Zaretskii <eliz@gnu.org>
3009
3010 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3011 _stricmp and _strnicmp.
3012 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3013
62efea5e
DA
30142012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3015
3016 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3017 allocated window.
3018 (allocate_process): Likewise for new process.
8edd4a2b 3019 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3020 (allocate_frame): Likewise.
3021 * frame.c (make_frame): Omit redundant initialization.
3022 * window.c (make_parent_window): Use memset.
3023 (make_window): Omit redundant initialization.
3024 * process.c (make_process): Omit redundant initialization.
3025 * terminal.c (create_terminal): Likewise.
3026
42997f4d
DA
30272012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3028
3029 * term.c (delete_tty): Remove redundant call to memset.
3030
1130ecfc
DA
30312012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3032
3033 * alloc.c: Remove build_string.
3034 * lisp.h: Define build_string as static inline. This provides
3035 a better opportunity to optimize away calls to strlen when the
3036 function is called with compile-time constant argument.
3037 * image.c (imagemagick_error): Convert to build_string.
3038 * w32proc.c (sys_spawnve): Likewise.
3039 * xterm.c (x_term_init): Likewise.
3040
cf38a720
PE
30412012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3042
99027bdd
PE
3043 Use sprintf return value instead of invoking strlen on result.
3044 In the old days this wasn't portable, since some sprintf
3045 implementations returned char *. But they died out years ago and
3046 Emacs already assumes sprintf returns int.
3047 Similarly for float_to_string.
3048 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3049 * ccl.c (ccl_driver):
3050 * character.c (string_escape_byte8):
3051 * data.c (Fnumber_to_string):
3052 * doprnt.c (doprnt):
3053 * print.c (print_object):
3054 * xdisp.c (message_dolog):
3055 * xfns.c (syms_of_xfns):
3056 Use sprintf or float_to_string result to avoid need to call strlen.
3057 * data.c (Fnumber_to_string):
3058 Use make_unibyte_string, since the string must be ASCII.
3059 * lisp.h, print.c (float_to_string): Now returns int length.
3060 * term.c (produce_glyphless_glyph):
3061 Use sprintf result rather than recomputing it.
3062
cf38a720
PE
3063 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3064 * Makefile.in (ALL_CFLAGS):
3065 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3066 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3067
3511c784
DA
30682012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3069
0a08eb21 3070 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3071 strcasecmp if available.
3072 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3073
fb7da12e
AS
30742012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3075
3076 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3077 Avoid comma operator.
3078 * menu.c (push_submenu_start, push_submenu_end)
3079 (push_left_right_boundary, push_menu_pane): Likewise.
3080 * msdos.c (dos_rawgetc): Likewise.
3081
afa2ffd8
DA
30822012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3083
3084 * xfns.c (xic_create_fontsetname): Remove redundant calls
3085 to memset.
3086
b3b4476b
PE
30872012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3088
4495ff38
PE
3089 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3090 sprintf already null-terminates its output.
3091
b3b4476b
PE
3092 * xfns.c (x_window): Remove redundant cast.
3093
b00876c9
DA
30942012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3095
3096 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3097 `const char *' to `char *' to avoid compiler warning.
3098
d188e26b
PE
30992012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3100
885d1d74
PE
3101 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3102 instead of truncating it to 63 (admittedly a generous limit).
3103
d188e26b
PE
3104 * process.c: Fix spelling and caps in comments.
3105
e2f560b1
DN
31062012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3107
e86db54b 3108 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3109 * sysdep.c (setpgrp): Remove definition, not used in this file.
3110
7583a3a1
JB
31112012-06-24 Juanma Barranquero <lekktu@gmail.com>
3112
3113 * makefile.w32-in: Update dependencies.
3114
696056c2
EZ
31152012-06-24 Eli Zaretskii <eliz@gnu.org>
3116
3117 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3118 (SYSTIME_H): Add nt/inc/sys/time.h.
3119
3120 * systime.h [WINDOWSNT]: Include sys/time.h.
3121
3122 * s/ms-w32.h (struct timespec): Definition moved from
3123 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3124
845ca893
PE
31252012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3126
3127 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3128 * buffer.h (buffer_slot_type_mismatch):
3129 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3130 * eval.c (unwind_to_catch):
3131 * image.c (my_png_error, my_error_exit):
3132 * keyboard.c (quit_throw_to_read_char, user_error)
3133 (Fexit_recursive_edit, Fabort_recursive_edit):
3134 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3135 (wrong_type_argument, buffer_overflow, __executable_start)
3136 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3137 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3138 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3139 (fatal):
3140 (child_setup) [!DOS_NT]:
3141 * lread.c (end_of_file_error, invalid_syntax):
3142 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3143 * puresize.h (pure_write_error):
3144 * search.c (matcher_overflow):
3145 * sound.c (sound_perror, alsa_sound_perror):
3146 * sysdep.c, syssignal.h (croak):
3147 * term.c (maybe_fatal, vfatal):
3148 * textprop.c (text_read_only):
3149 * undo.c (user_error):
3150 * unexmacosx.c (unexec_error):
3151 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3152 Use _Noreturn rather than NO_RETURN.
3153 No need for separate decl merely because of _Noreturn.
3154 * sound.c (sound_warning, parse_sound):
3155 Remove unnecessary forward decls.
3156
f1dd8073
PE
31572012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3158
3159 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3160 * lisp.h (WAIT_READING_MAX): New macro.
3161 * dispnew.c (Fsleep_for, sit_for):
3162 * keyboard.c (kbd_buffer_get_event):
3163 * process.c (Faccept_process_output):
3164 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3165 This improves on the previous patch, which introduced a bug
3166 when time_t is unsigned and as wide as intmax_t.
3167 See <http://bugs.gnu.org/9000#51>.
3168
b82c1755
EZ
31692012-06-23 Eli Zaretskii <eliz@gnu.org>
3170
3171 * dispnew.c (sit_for, Fsleep_for):
3172 * keyboard.c (kbd_buffer_get_event):
3173 * process.c (Faccept_process_output): Avoid compiler warnings when
3174 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3175
ca300656
JB
31762012-06-23 Juanma Barranquero <lekktu@gmail.com>
3177
049ec95b
JB
3178 * makefile.w32-in: Update dependencies.
3179
ca300656
JB
3180 * w32.c (ltime): Add return type and declare static.
3181 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3182
db7b8d06
PE
31832012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3186 Privately reported by Herbert J. Skuhra.
3187 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3188 All uses changed.
3189 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3190 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3191
0bd8297f
EZ
31922012-06-23 Eli Zaretskii <eliz@gnu.org>
3193
96512555
EZ
3194 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3195 last argument of make_unibyte_string.
3196
0bd8297f
EZ
3197 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3198 language ID in the event parameters.
3199
3200 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3201 event.code, not the obscure "character set ID".
3202
63def6b6
CY
32032012-06-23 Chong Yidong <cyd@gnu.org>
3204
3205 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3206
e8a02204
EZ
32072012-06-23 Eli Zaretskii <eliz@gnu.org>
3208
388cdec0
EZ
3209 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3210 * w32.c (fdutimens): New function.
3211
3212 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3213
3214 * s/ms-w32.h (pselect): Redirect to sys_select.
3215
3216 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3217
e8a02204
EZ
3218 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3219 in the logic of incrementing and decrementing the value of
3220 use_relocatable_buffers.
3221
d054f3fb
PE
32222012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3223
3224 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3225 Privately reported by Herbert J. Skuhra.
3226 [__FreeBSD__]: Remove "*/" typo after "#include".
3227 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3228 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3229 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3230 Don't assume EMACS_TIME and struct timeval are the same type.
3231
d35af63c
PE
32322012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3233
3234 Support higher-resolution time stamps (Bug#9000).
3235 The time stamps are only nanosecond-resolution at the C level,
3236 since that's the best that any real-world system supports now.
3237 But they are picosecond-resolution at the Lisp level, as that's
3238 easy, and leaves room for future OS improvements.
3239
3240 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3241 (LIBES): Use it.
3242
3243 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3244 Don't get current time unless it's needed.
3245
3246 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3247 now provides it if it's absent.
3248 (start_atimer): Port to higher-res time stamps.
3249 Check for time stamp overflow. Don't get current time more
3250 often than is needed.
3251
3252 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3253 Include systime.h, not time.h.
3254 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3255
3256 * dired.c: Include stat-time.h.
3257 (Ffile-attributes): File times now have higher resolution.
3258
3259 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3260 (struct image): Timestamp now has higher resolution.
3261
3262 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3263 has at least microseconds now. All uses removed.
3264 (update_frame, update_single_window, update_window, update_frame_1)
3265 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3266
3267 * editfns.c (time_overflow): Now extern.
3268 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3269 (float-time, Fformat_time_string, Fcurrent_time_string)
3270 (Fcurrent_time_zone): Accept and generate higher-resolution
3271 time stamps.
3272 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3273 (decode_time_components, lisp_seconds_argument): New functions.
3274 (make_time): Now static.
3275 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3276 Report an error if the time is invalid, rather than having the caller
3277 do that.
3278
3279 * fileio.c: Include <stat-time.h>
3280 (Fcopy_file): Copy higher-resolution time stamps.
3281 Prefer to set the time stamp via a file descriptor if that works.
3282 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3283 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3284 (Fvisited_file_modtime, Fset_visited_file_modtime):
3285 Support higher-resolution time stamps.
3286
3287 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3288
3289 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3290
3291 * image.c (prepare_image_for_display, clear_image_cache)
3292 (lookup_image): Port to higer-resolution time stamps.
3293
3294 * keyboard.c (start_polling, bind_polling_period):
3295 Check for time stamp overflow.
3296 (read_char, kbd_buffer_get_event, timer_start_idle)
3297 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3298 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3299 Port to higher-resolution time stamps. Do not assume time_t is signed.
3300 (decode_timer): New function. Timers are now vectors of length 9,
3301 not 8, to accommodate the picosecond component.
3302 (timer_check_2): Use it.
3303
3304 * nsterm.m (select_timeout, timeval_subtract): Remove.
3305 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3306 as they're a bit more accurate and handle overflow better.
3307 (ns_select): Change prototype to be compatible with pselect.
3308 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3309 * nsterm.h (ns_select): Adjust prototype.
3310
3311 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3312 us-resolution time stamps.
3313 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3314
3315 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3316
3317 * lisp.h (time_overflow): New decl.
3318 (wait_reading_process_output): First arg is now intmax_t, not int,
3319 to accommodate larger waits.
3320
3321 * process.h (struct Lisp_Process.read_output_delay):
3322 Now counts nanoseconds, not microseconds.
3323 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3324 EMACS_HAS_USECS.
3325 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3326 (wait_reading_process_output):
3327 Port to ns-resolution time stamps.
3328 (Faccept_process_output, wait_reading_process_output):
3329 Check for time stamp overflow. Do not assume time_t is signed.
3330 (select_wrapper): Remove; we now use pselect.
3331 (Fprocess_attributes): Now generates ns-resolution time stamps.
3332
3333 * sysdep.c: Include utimens.h. Don't include utime.h
3334 or worry about struct utimbuf; gnulib does that for us now.
3335 (gettimeofday): Remove; gnulib provides a substitute.
3336 (make_timeval): New function.
3337 (set_file_times): Now sets ns-resolution time stamps.
3338 New arg FD; all uses changed.
3339 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3340 (system_process_attributes):
3341 Now returns ns-resolution time stamp. All uses changed.
3342 Check for time stamp overflow.
3343
3344 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3345 provides a substitute now.
3346
3347 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3348 since it guarantees struct timespec.
3349 (EMACS_TIME): Now struct timespec, so that we can support
3350 ns-resolution time stamps.
3351 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3352 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3353 (EMACS_USECS): Remove.
3354 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3355 so multiply the arg by 1000 before storing it.
3356 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3357 New macros.
3358 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3359 Port to ns-resolution time stamps.
3360 (EMACS_TIME_NEG_P): Remove; replaced by....
3361 (EMACS_TIME_SIGN): New macro.
3362 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3363 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3364 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3365 (make_timeval, make_lisp_time, decode_time_components): New decls.
3366 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3367 that it mishandled time_t overflow. You can't compare by subtracting!
3368 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3369 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3370
3371 * term.c: Include <sys/time.h>.
3372 (timeval_to_Time): New function, for proper overflow wraparound.
3373 (term_mouse_position, term_mouse_click): Use it.
3374
3375 * undo.c (record_first_change): Support higher-resolution time stamps
3376 in the undo buffer.
3377 (Fprimitive_undo): Use them when restoring time stamps.
3378
3379 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3380 (w32_get_internal_run_time):
3381 Port to higher-resolution Emacs time stamps.
3382 (ltime): Now accepts single 64-bit integer, as that's more convenient
3383 for callers.
3384
3385 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3386
3387 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3388 for compatibility with pselect. Support ns-resolution time stamps.
3389
3390 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3391
3392 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3393 Check for time stamp overflow, and support ns-resolution time stamps.
3394
3395 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3396 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3397 (timeval_subtract): Remove; no longer needed.
3398 (XTflash, XTring_bell, x_wait_for_event):
3399 Port to ns-resolution time stamps. Don't assume time_t is signed.
3400
b6a92dfe
CY
34012012-06-22 Chong Yidong <cyd@gnu.org>
3402
3403 * xdisp.c (x_consider_frame_title): Revert last change.
3404
d251c37c
EZ
34052012-06-22 Eli Zaretskii <eliz@gnu.org>
3406
3407 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3408 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3409 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3410 staticidx goes up to 1597 out of 1600 = 0x640.)
3411
f10deafb
PE
34122012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3413
3414 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3415 Otherwise, the umask might be mistakenly 0 while handling input signals.
3416
ec6de1e2
SM
34172012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3418
3419 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3420
28be1ada
DA
34212012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3422
3423 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3424 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3425 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3426 access to `contents' member of Lisp_Vector objects with AREF and ASET
3427 where appropriate.
3428
c6bf3022
CY
34292012-06-19 Chong Yidong <cyd@gnu.org>
3430
3431 * frame.c (delete_frame): When selecting a frame on a different
3432 text terminal, do not alter the terminal's top-frame.
3433
3434 * xdisp.c (format_mode_line_unwind_data): Record the target
3435 frame's selected window and its terminal's top-frame.
3436 (unwind_format_mode_line): Restore them.
3437 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3438 Callers changed.
3439 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3440 since tty frames can be explicitly named.
3441 (prepare_menu_bars): Likewise.
3442
3443 * term.c (Ftty_top_frame): New function.
3444
defd4196
PE
34452012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3446
3447 Port byte-code-meter to modern targets.
3448 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3449 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3450 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3451 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3452 (METER_1, METER_2): Simplify.
3453
1053a871
SM
34542012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3455
3456 * data.c (Fdefalias): Return `symbol' (bug#11686).
3457
b7e8d081
MR
34582012-06-18 Martin Rudalics <rudalics@gmx.at>
3459
3460 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3461 gets killed during executing of this function (Bug#11665).
3462 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3463 (Vkill_buffer_query_functions): In doc-string say that functions
3464 run by this hook should not change the current buffer.
3465
7ea2b339
PE
34662012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3467
3468 Fix recently-introduced process.c problems found by static checking.
3469 * process.c (write_queue_push, write_queue_pop, send_process):
3470 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3471 (write_queue_pop): Fix pointer signedness problem.
3472 (send_process): Remove unused local.
3473
96a313a1
CY
34742012-06-17 Chong Yidong <cyd@gnu.org>
3475
3476 * xdisp.c (redisplay_internal): No need to redisplay terminal
3477 frames that are not on top.
3478
20ca2e94
TN
34792012-06-17 Troels Nielsen <bn.troels@gmail.com>
3480
3481 * process.c (make_process): Initialize write_queue.
3482 (write_queue_push, write_queue_pop): New functions.
3483 (send_process): Use them to maintain correct ordering of process
3484 writes (Bug#10815).
3485
9a900ca9
PE
34862012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3487
310fbfa8
PE
3488 * lisp.h (eassert): Assume C89 or later.
3489 This removes the need for CHECK.
3490 (CHECK): Remove. Its comments about always evaluating its
3491 argument were confusing, as 'eassert' typically does not evaluate
3492 its argument.
3493
27bb1ca4
PE
3494 * coding.c (produce_chars): Use ptrdiff_t, not int.
3495
9a900ca9
PE
3496 * xterm.c (x_draw_underwave): Check for integer overflow.
3497 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3498
41b7f8bc 34992012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3500
3501 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3502 referenced (Bug#11583).
3503
9b0e3eba
AA
35042012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3505
3506 Implement wave-style variant of underlining.
3507 * dispextern.h (face_underline_type): New enum.
3508 (face): Add field for underline type.
3509 * nsterm.m (ns_draw_underwave): New function.
3510 (ns_draw_text_decoration): Use it.
3511 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3512 New functions.
3513 (x_draw_glyph_string): Use them.
3514 * xfaces.c (Qline, Qwave): New Lisp objects.
3515 (check_lface_attrs, merge_face_ref)
1053a871
SM
3516 (Finternal_set_lisp_face_attribute, realize_x_face):
3517 Handle wave-style underline face attributes.
9b0e3eba
AA
3518 * xterm.c (x_draw_underwave): New function.
3519 (x_draw_glyph_string): Use it.
3520
0fb52f11
JB
35212012-06-16 Juanma Barranquero <lekktu@gmail.com>
3522
3523 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3524 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3525 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3526 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3527 ($(BLD)/w32select.$(O)): Update dependencies.
3528
e5560ff7
AS
35292012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3530
3531 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3532 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3533 * character.c (_fetch_multibyte_char_p): Remove.
3534 * alloc.c: Include "character.h" before "buffer.h".
3535 * bidi.c: Likewise.
3536 * buffer.c: Likewise.
3537 * bytecode.c: Likewise.
3538 * callint.c: Likewise.
3539 * callproc.c: Likewise.
3540 * casefiddle.c: Likewise.
3541 * casetab.c: Likewise.
3542 * category.c: Likewise.
3543 * cmds.c: Likewise.
3544 * coding.c: Likewise.
3545 * composite.c: Likewise.
3546 * dired.c: Likewise.
3547 * dispnew.c: Likewise.
3548 * doc.c: Likewise.
3549 * dosfns.c: Likewise.
3550 * editfns.c: Likewise.
3551 * emacs.c: Likewise.
3552 * fileio.c: Likewise.
3553 * filelock.c: Likewise.
3554 * font.c: Likewise.
3555 * fontset.c: Likewise.
3556 * fringe.c: Likewise.
3557 * indent.c: Likewise.
3558 * insdel.c: Likewise.
3559 * intervals.c: Likewise.
3560 * keyboard.c: Likewise.
3561 * keymap.c: Likewise.
3562 * lread.c: Likewise.
3563 * macros.c: Likewise.
3564 * marker.c: Likewise.
3565 * minibuf.c: Likewise.
3566 * nsfns.m: Likewise.
3567 * nsmenu.m: Likewise.
3568 * print.c: Likewise.
3569 * process.c: Likewise.
3570 * regex.c: Likewise.
3571 * region-cache.c: Likewise.
3572 * search.c: Likewise.
3573 * syntax.c: Likewise.
3574 * term.c: Likewise.
3575 * textprop.c: Likewise.
3576 * undo.c: Likewise.
3577 * unexsol.c: Likewise.
3578 * w16select.c: Likewise.
3579 * w32fns.c: Likewise.
3580 * w32menu.c: Likewise.
3581 * window.c: Likewise.
3582 * xdisp.c: Likewise.
3583 * xfns.c: Likewise.
3584 * xmenu.c: Likewise.
3585 * xml.c: Likewise.
3586 * xselect.c: Likewise.
3587
2f07e6af
EZ
35882012-06-16 Eli Zaretskii <eliz@gnu.org>
3589
1053a871
SM
3590 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3591 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3592 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3593 row.
3594 (handle_face_prop): Use chunk-relative overlay string index when
3595 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3596 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3597 the rightmost. (Bug#11720)
2f07e6af 3598
29b83cec
AS
35992012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3600
3601 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3602 (CATEGORY_MEMBER): Enforce 1/0 value.
3603 * category.c (_temp_category_set): Remove.
3604
4c5501e9
EZ
36052012-06-16 Eli Zaretskii <eliz@gnu.org>
3606
3607 * window.c (Fdelete_other_windows_internal)
3608 (Fdelete_window_internal): Don't access frame's mouse highlight
3609 info of the initial frame. (Bug#11677)
3610
2b570124
PE
36112012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3612
e93864f9
PE
3613 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3614 Assume USE_2_TAGS_FOR_INTS.
3615 (xreload): Adjust $tagmask width to match recent lisp.h change.
3616
2b570124
PE
3617 Simplify lisp.h in minor ways that should not affect code.
3618 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3619 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3620 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3621 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3622 (INTTYPEBITS): New macro, for clarity.
3623 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3624 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3625 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3626 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3627 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3628
81755f69
JB
36292012-06-13 Juanma Barranquero <lekktu@gmail.com>
3630
3631 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3632
16192a57
GM
36332012-06-13 Glenn Morris <rgm@gnu.org>
3634
3635 * s/bsd-common.h (BSD4_3):
3636 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3637
646b5f55
AS
36382012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3639
3640 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3641 instead of union.
3642 (XLI, XIL): Define.
1053a871
SM
3643 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3644 Use them.
3645 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3646 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3647 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3648 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3649 * frame.c (delete_frame): Remove outdated comment.
3650 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3651 USE_LISP_UNION_TYPE.
3652 (Fw32_unregister_hot_key): Likewise.
3653 (Fw32_toggle_lock_key): Likewise.
3654 * w32menu.c (add_menu_item): Likewise.
3655 (w32_menu_display_help): Use XIL instead of checking
3656 USE_LISP_UNION_TYPE.
3657 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3658 (init_heap): Likewise.
3659 * w32term.c (w32_read_socket): Update comment.
3660
1d3823c9
GM
36612012-06-13 Glenn Morris <rgm@gnu.org>
3662
c62ff706
GM
3663 * s/usg5-4-common.h, src/s/unixware.h:
3664 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3665
1d3823c9
GM
3666 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3667
bfe3e0a2
PE
36682012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3669
3670 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3671 * alloc.c (make_number) [!defined make_number]:
3672 Remove, as lisp.h always defines this now.
3673 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3674 (roundup_size): Verify that it is a power of 2.
3675 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3676 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3677 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3678 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3679 USE_LSB_TAG now is always defined to be either 0 or 1.
3680 All uses changed.
3681 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3682 code works fine either way, and efficiency is not a concern here,
3683 as the union type is for debugging, not for production.
3684 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3685 Use an inline function on all platforms when using the union type,
3686 since this is simpler and 'static inline' can be used portably
3687 within Emacs now.
3688 (LISP_INITIALLY_ZERO): New macro.
3689 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3690 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3691
45fa9c0f
GM
36922012-06-12 Glenn Morris <rgm@gnu.org>
3693
b4492cba
GM
3694 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3695
3696 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3697
45fa9c0f
GM
3698 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3699 Move BROKEN_SIGIO to configure.
3700
3701 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3702 Move NO_TERMIO to configure.
3703
0e25d334
CY
37042012-06-12 Chong Yidong <cyd@gnu.org>
3705
3706 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3707 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3708 MagickExportImagePixels is undefined.
3709
43682bb6
PE
37102012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3711
3712 * image.c (imagemagick_load_image): Remove unused label.
3713
a9be7d2b
GM
37142012-06-11 Glenn Morris <rgm@gnu.org>
3715
3716 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3717 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3718 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3719 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3720
3017f87f
SM
37212012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3722
3723 * alloc.c (make_byte_code): New function.
3724 (Fmake_byte_code): Use it. Don't purify here.
3725 * lread.c (read1): Use it as well to avoid extra allocation.
3726
1b9b4cf4
CY
37272012-06-11 Chong Yidong <cyd@gnu.org>
3728
3729 * image.c (imagemagick_load_image): Implement transparency.
3730
95988fcf
AS
37312012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3732
3733 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3734 account for preceding backslashes. (Bug#11663)
3735
cd4eb164
CY
37362012-06-09 Chong Yidong <cyd@gnu.org>
3737
3738 * term.c: Support italics in capable terminals (Bug#9652).
3739 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3740 (turn_on_face): Output using TS_enter_italic_mode if available.
3741 Don't handle unused blinking and alt-charset cases.
3742 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3743 and tty_alt_charset_p cases.
3744 (tty_capable_p, init_tty): Support italics.
3745
3746 * termchar.h (struct tty_display_info): Add field for italics.
3747 Remove unused blink field.
3748
3749 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3750 Handle slant.
3751
3752 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3753 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3754 tty_alt_charset_p. Add tty_italic_p.
3755
ff88beb8
MA
37562012-06-09 Michael Albinus <michael.albinus@gmx.de>
3757
3758 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3759 dbus_type_is_basic if available.
3760 (xd_extract_signed, xd_extract_unsigned): Rename from
3761 extract_signed and extract_unsigned, respectively. Adapt callers.
3762
44286096
CY
37632012-06-09 Chong Yidong <cyd@gnu.org>
3764
1682701f
CY
3765 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3766
44286096
CY
3767 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3768 case (Bug#9752).
3769
d86feb17
PE
37702012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3771
3772 * xdisp.c (vmessage): Treat frame message as multibyte.
3773 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3774 would generate the diagnostic "Making \302\247 buffer-local while
3775 let-bound!".
3776
d5c20fe8
EZ
37772012-06-08 Eli Zaretskii <eliz@gnu.org>
3778
3779 * dispnew.c (showing_window_margins_p): Undo last change, which
3780 was done due to an inadvertent commit.
3781 (adjust_frame_glyphs_for_frame_redisplay): Do call
3782 showing_window_margins_p.
3783
513749ee
SM
37842012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3785
3786 * eval.c (Fmake_var_non_special): New primitive.
3787 (syms_of_eval): Defsubr it.
3788 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3789
d4a8f5c1
JB
37902012-06-08 Juanma Barranquero <lekktu@gmail.com>
3791
3792 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3793 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3794
8bbbc977
EZ
37952012-06-08 Eli Zaretskii <eliz@gnu.org>
3796
3797 * alloc.c (allocate_vectorlike): Fix last change.
3798
f3372c87
DA
37992012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3800
3801 Block-based vector allocation of small vectors.
3802 * lisp.h (struct vectorlike_header): New field `nbytes',
3803 adjust comment accordingly.
3804 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3805 to denote vector blocks. Adjust users (live_vector_p,
3806 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3807 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3808 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3809 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3810 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3811 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3812 (roundup_size): New constant.
3813 (struct vector_block): New data type.
3814 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3815 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3816 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3817 (sweep_vectors): New functions.
3818 (allocate_vectorlike): Return `zero_vector' as the only vector of
3819 0 items. Allocate new vector from block if vector size is less than
3820 or equal to VBLOCK_BYTES_MAX.
3821 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3822 (init_alloc_once): Add call to init_vectors.
3823
4f18a4ed
SM
38242012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3825
3826 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3827
86f158bc
PE
38282012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3829
3830 * doprnt.c (doprnt): Truncate multibyte char correctly.
3831 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3832 would mishandle a string argument "Xc" if X was a multibyte
3833 character of length 2: it would truncate after X's first byte
3834 rather than including all of X.
3835
c5cfcbe0
CY
38362012-06-06 Chong Yidong <cyd@gnu.org>
3837
3838 * buffer.c (word_wrap): Doc fix.
3839
c05cf390
PE
38402012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3841
3842 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3843
0c3461de
GM
38442012-06-03 Glenn Morris <rgm@gnu.org>
3845
3846 * xdisp.c (tool-bar-style): Doc fix.
3847
c71232db
UM
38482012-06-03 Ulrich Müller <ulm@gentoo.org>
3849
3850 * Makefile.in (PAXCTL): Define.
3851 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3852 binary via PaX flags if the paxctl utility is available.
3853 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3854 Restore PaX flags to their default. (Bug#11398)
3855
383f7350
CY
38562012-06-03 Chong Yidong <cyd@gnu.org>
3857
3858 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3859 buffer (Bug#11226).
3860
5f2c76c6
CY
38612012-06-03 Chong Yidong <cyd@gnu.org>
3862
3863 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3864 (note_mode_line_or_margin_highlight): If there is no help echo,
3865 use mode-line-default-help-echo. Handle the case where the mouse
3866 position is past the end of the mode line string.
3867
3868 * buffer.c (buffer_local_value_1): New function, split from
3869 Fbuffer_local_value; can return Qunbound.
3870 (Fbuffer_local_value): Use it.
3871 (Vmode_line_format): Docstring tweaks.
3872
773d47f6
PE
38732012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3874
3875 * sysdep.c (system_process_attributes): Improve comment.
3876
f2d6a3df
SM
38772012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3878
3879 * keyboard.c: Export real-this-command to Elisp.
3880 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3881 and DEFVAR it. Update all users.
3882
63810350
PE
38832012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3884
7bd5c1f4
PE
3885 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3886
63810350
PE
3887 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3888 Convert pctcpu and pctmem to Lisp float properly.
3889 Let the compiler fold better, as 100.0/0x8000 is exact.
3890
a2821611
AS
38912012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3892
3893 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3894 cons_block.
3895
5fceba1d
PE
38962012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3897
3898 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3899
c98ff5dd
DA
39002012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3901
3902 For a 'struct window', replace some Lisp_Object fields to
3903 bitfields where appropriate, remove unused fields.
3904 * window.h (struct window): Remove unused 'last_mark_x' and
3905 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3906 change it's type from Lisp_Object to bitfield.
3907 Change type of 'force_start', 'optional_new_start',
3908 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3909 fields from Lisp_Object to bitfield. Adjust users accordingly.
3910
ca34e0be
PE
39112012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3912
3913 Pacify gcc -Wdouble-precision when using Xaw.
3914 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3915 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3916 Use 'float' consistently, rather than 'float' in most places
3917 and 'double' in a couple of places.
3918
efc00ab1 39192012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3920
3921 * xdisp.c (handle_stop): Detect whether we have overlay strings
3922 loaded by testing it->current.overlay_string_index to be
3923 non-negative, instead of checking whether n_overlay_strings is
3924 positive. (Bug#11587)
3925
efc00ab1 39262012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3927
3928 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3929
3930 * doc.c (Fsubstitute_command_keys): Doc fix.
3931
efc00ab1 39322012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3933
3934 * search.c (search_buffer): Remove calls to
3935 r_alloc_inhibit_buffer_relocation, as it is now called by
3936 maybe_unify_char, which was the cause of relocation of buffer text
3937 in bug#11519.
3938
efc00ab1 39392012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3940
3941 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3942 for the duration of call to load_charset, to avoid problems with
3943 callers of maybe_unify_char that access buffer text through C
3944 pointers.
3945
3946 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3947 decrement the inhibition flag, instead of just setting or
3948 resetting it.
3949
ba93a187
PE
39502012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3951
3952 Remove obsolete '#define static' cruft.
3953 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3954 This #undef was "temporary" in 2000; it is no longer needed
3955 now that '#define static' has gone away.
3956 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3957 (gray_bitmap_bits): Remove; no longer needed.
3958 All uses replaced with definiens.
3959 * xterm.c: Include "bitmaps/gray.xbm".
3960
9e4bf381
PE
39612012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3962
3963 Clean up __executable_start, monstartup when --enable-profiling.
3964 The following changes affect the code only when profiling.
3965 * dispnew.c (__executable_start): Rename from safe_bcopy.
3966 Define only on platforms that need it.
3967 * emacs.c: Include <sys/gmon.h> when profiling.
3968 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3969 (__executable_start): Remove decl, since lisp.h does it now.
3970 (safe_bcopy): Remove decl; no longer has that name.
3971 (main): Coalesce #if into single bit of code, for simplicity.
3972 Cast pointers to uintptr_t, since standard libraries want integers
3973 and not pointers.
3974 * lisp.h (__executable_start): New decl.
3975
32d72c2f
GM
39762012-05-31 Glenn Morris <rgm@gnu.org>
3977
3978 * image.c (Fimagemagick_types): Doc fix.
3979
baac5bc7
JM
39802012-05-30 Jim Meyering <meyering@redhat.com>
3981
3982 * callproc.c (Fcall_process_region): Include directory component
3983 in mkstemp error message (Bug#11586).
3984
72cb32cf
PE
39852012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3986
3987 * alloc.c, lisp.h (make_pure_vector): Now static.
3988
61b108cc
SM
39892012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3990
3991 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3992 Move to byte-run.el.
3993 (Fautoload): Do the hash-doc more carefully.
3994 * data.c (Fdefalias): Purify definition, except for keymaps.
3995 (Qdefun): Move from eval.c.
3996 * lisp.h (Qdefun): Remove.
3997 * lread.c (read1): Tiny simplification.
3998
471fe23d
TN
39992012-05-29 Troels Nielsen <bn.troels@gmail.com>
4000
934f3f58 4001 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
4002 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
4003 Bug#9642, but explicitly check that the buffer the overlay would
4004 be moved to is live and rearrange lines to make sure that errors
4005 will not put the overlay in an inconsistent state.
4006 (Fdelete_overlay): Cosmetics.
4007
85d0efd1
EZ
40082012-05-28 Eli Zaretskii <eliz@gnu.org>
4009
4010 * w32term.c (my_bring_window_to_top): New function.
4011 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4012 could be different from the original one.
4013 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4014 (Bug#11513)
4015
4016 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4017 by calling BringWindowToTop.
4018
4019 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4020 (WM_EMACS_END): Increase by one.
4021
da92a98c
PE
40222012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4023
4024 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4025 This avoids undefined behavior that might cause the eassert
4026 to not catch an out-of-range value.
4027
74d1f848
JB
40282012-05-28 Juanma Barranquero <lekktu@gmail.com>
4029
4030 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4031 Update dependencies.
4032
9e1a06fc
EZ
40332012-05-27 Eli Zaretskii <eliz@gnu.org>
4034
4035 * bidi.c (bidi_mirror_char): Fix last change.
4036
f3dd7312
AS
40372012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4038
4039 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4040 when referring to sectname field in printf format.
4041
81899c91
PE
40422012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4043
57b81a9f
PE
4044 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4045 Only r_alloc_inhibit_buffer_relocation needed to be added;
4046 the others were already declared.
4047
81899c91
PE
4048 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4049 before checking whether it's out of range. Put the check inside
4050 eassert. See
4051 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4052
33017faf 40532012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4054
4055 * callproc.c (Fcall_process): Restore a line that was accidentally
4056 commented out in the 2011-02-13 change (bug#11547).
4057
33017faf 40582012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4059
4060 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4061 defined on ralloc.c.
4062
4063 * buffer.c [REL_ALLOC]: Remove prototypes of
4064 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4065 they are now on lisp.h.
4066
4067 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4068
4069 * search.c (search_buffer): Use it to inhibit relocation of buffer
4070 text while re_search_2 is doing its job, because re_search_2 is
4071 passed C pointers to buffer text. (Bug#11519)
4072
23415acf
EZ
4073 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4074 Update value to 24.
4075
44e27368
EZ
4076 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4077 state after an additional call to move_it_in_display_line_to, keep
4078 the values of it->max_ascent and it->max_descent found for the
4079 entire line.
4080 (pos_visible_p): Revert the comparison against bottom_y to what it
4081 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4082 (Bug#11464)
4083
c1892f11
PE
40842012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4085
4086 Fix coding-related core dumps with gcc -ftrapv.
4087 The code was computing A - B, where A and B are pointers, and B is
4088 random garbage. This can lead to core dumps on platforms that
4089 have special pointer registers, and it also leads to core dumps on
4090 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4091 A - B only when B is initialized properly.
4092 * coding.c (coding_set_source, coding_set_destination): Return void.
4093 (coding_change_source, coding_change_destinations): New functions,
4094 with the old behaviors of coding_set_source and coding_set_destination.
4095 All callers that need an offset changed to use these new functions.
4096
eb7afdad
GM
40972012-05-26 Glenn Morris <rgm@gnu.org>
4098
4099 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4100
f12fdf02
EZ
41012012-05-26 Eli Zaretskii <eliz@gnu.org>
4102
53a63be6 4103 Extend mouse support on W32 text-mode console.
61b108cc
SM
4104 * xdisp.c (draw_row_with_mouse_face):
4105 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4106
eb3f6f01 4107 * w32console.c: Include window.h.
61b108cc
SM
4108 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4109 New functions.
eb3f6f01
EZ
4110 (initialize_w32_display): Initialize mouse-highlight data.
4111
53a63be6
EZ
4112 * w32inevt.c: Include termchar.h and window.h.
4113 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4114 moves, call note_mouse_highlight. If help_echo changed, call
4115 gen_help_event to produce help-echo message in the echo area.
4116 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4117 highlight info.
4118
4cfd81f6
PE
41192012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4120
4121 * lread.c (read1): Simplify slightly to avoid an overflow warning
4122 with GCC 4.7.0 on x86-64.
4123
4446092a
EZ
41242012-05-26 Eli Zaretskii <eliz@gnu.org>
4125
4126 * bidi.c (bidi_mirror_char): Revert last change: an int is
4127 definitely wide enough here.
4128
42b2a986 41292012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4130
42b2a986 4131 Fix integer width and related bugs (Bug#9874).
eb106a49 4132 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4133 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4134 (string_bytes, check_sblock, allocate_string_data):
4135 (compact_small_strings, Fmake_bool_vector, make_string)
4136 (make_unibyte_string, make_multibyte_string)
4137 (make_string_from_bytes, make_specified_string)
4138 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4139 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4140 (mark_vectorlike):
4141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4142 (allocate_pseudovector):
4143 Use int, not EMACS_INT, where int is wide enough.
4144 (inhibit_garbage_collection, Fgarbage_collect):
4145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4146 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4147 int might not be wide enough.
4148 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4149 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4150 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4151 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4152 (bidi_level_of_next_char, bidi_move_to_visually_next):
4153 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4154 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4155 (Fkill_buffer, Fset_buffer_major_mode)
4156 (advance_to_char_boundary, Fbuffer_swap_text)
4157 (Fset_buffer_multibyte, overlays_at, overlays_in)
4158 (overlay_touches_p, struct sortvec, record_overlay_string)
4159 (overlay_strings, recenter_overlay_lists)
4160 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4161 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4162 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4163 (Foverlay_recenter, last_overlay_modification_hooks_used)
4164 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4166 (validate_region): Omit unnecessary test for b <= e,
4167 since that's guaranteed by the previous test.
d311d28c
PE
4168 (adjust_overlays_for_delete): Avoid pos + length overflow.
4169 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4170 (report_overlay_modification):
4171 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4172 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4173 Omit pointer cast, which isn't needed anyway, and doesn't work
4174 after the EMACS_INT -> ptrdiff_t change.
02481186 4175 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4176 * buffer.h: Adjust decls to match defn changes elsewhere.
4177 (struct buffer_text, struct buffer):
4178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4179 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4180 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4181 not int, to avoid needless 32-bit limit on 64-bit hosts.
4182 (exec_byte_code): Use tighter memory-full test, one that checks
4183 for alloca overflow. Don't compute the address of the object just
4184 before an array, as that's not portable. Use EMACS_INT, not
4185 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4186 * callint.c (Fcall_interactively):
4187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4188 * callproc.c (call_process_kill, Fcall_process):
4189 Don't assume pid_t fits into an Emacs fixnum.
4190 (call_process_cleanup, Fcall_process, child_setup):
4191 Don't assume pid_t fits into int.
4192 (call_process_cleanup, Fcall_process, delete_temp_file)
4193 (Fcall_process_region):
4194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4195 (Fcall_process): Simplify handling of volatile integers.
4196 Use int, not EMACS_INT, where int will do.
4197 * casefiddle.c (casify_object, casify_region, operate_on_word)
4198 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4199 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4200 (casify_object): Avoid integer overflow when overallocating buffer.
4201 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4202 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4203 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4204 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4205 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4206 integers are now checked earlier. All uses replaced with XINT.
4207 (ccl_driver):
4208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4209 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4210 (ccl_driver, Fregister_code_conversion_map):
4211 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4212 (resolve_symbol_ccl_program): Check that vector header is in range.
4213 Always copy the vector, so that we can check its contents reliably
4214 now rather than having to recheck each instruction as it's being
4215 executed. Check that vector words fit in 'int'.
4216 (ccl_get_compiled_code, Fregister_ccl_program)
4217 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4218 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4219 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4220 contents are in range.
4221 (Fccl_execute_on_string): Check that status is in range.
4222 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4223 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4224 Accept and return EMACS_INT, not int, because callers can pass values
4225 out of 'int' range.
4226 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4227 (multibyte_chars_in_text, parse_str_as_multibyte)
4228 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4229 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4230 (string_escape_byte8, Fget_byte):
4231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4232 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4233 avoid mishandling large integers.
4234 * character.h: Adjust decls to match defn changes elsewhere.
4235 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4236 (Ffind_charset_region):
4237 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4238 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4239 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4240 Don't assume fixnum fits in int.
d311d28c
PE
4241 (load_charset_map_from_vector, Fmap_charset_chars):
4242 Remove now-unnecessary CHECK_NATNUMs.
4243 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4244 Don't rely on undefined behavior with signed left shift overflow.
4245 Don't assume unsigned int fits into fixnum, or that fixnum fits
4246 into unsigned int. Don't require max_code to be a valid fixnum;
4247 that's not true for gb10830 4-byte on a 32-bit host. Allow
4248 invalid_code to be a cons, for the same reason. Require code_offset
4249 to be a character. Avoid int overflow if max_char is close
4250 to INT_MAX.
4251 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4252 this is intended anyway and avoids some undefined behavior.
4253 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4254 INDEX_TO_CODE_POINT, as that's what it expects.
4255 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4256 * charset.h (DECODE_CHAR): Return int, not unsigned;
4257 this is what was intended anyway, and it avoids undefined behavior.
4258 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4259 integer-overflow issues.
4260 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4261 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4262 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4263 * chartab.c (Fmake_char_table, Fset_char_table_range)
4264 (uniprop_get_decoder, uniprop_get_encoder):
4265 Don't assume fixnum fits in int.
4266 * cmds.c (move_point): New function, that does the gist of
4267 Fforward_char and Fbackward_char, but does so while checking
4268 for integer overflow more accurately.
c96e5d6a 4269 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4270 (Fforward_line, Fend_of_line, internal_self_insert)
4271 (internal_self_insert):
4272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4273 Fix a FIXME, by checking for integer overflow when calculating
4274 target_clm and actual_clm.
4275 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4276 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4277 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4278 (coding_alloc_by_making_gap, alloc_destination)
4279 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4280 (encode_coding_utf_16, detect_coding_emacs_mule)
4281 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4282 (detect_coding_iso_2022, decode_coding_iso_2022)
4283 (encode_invocation_designation, encode_designation_at_bol)
4284 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4285 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4286 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4287 (encode_coding_ccl, encode_coding_raw_text)
4288 (detect_coding_charset, decode_coding_charset)
4289 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4290 (produce_composition, produce_charset, produce_annotation)
4291 (decode_coding, handle_composition_annotation)
4292 (handle_charset_annotation, consume_chars, decode_coding_gap)
4293 (decode_coding_object, encode_coding_object, detect_coding_system)
4294 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4295 (code_convert_region, code_convert_string)
8f50130c
PE
4296 (Fdefine_coding_system_internal)
4297 (coding_set_source, coding_set_destination):
d311d28c
PE
4298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4299 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4300 (Fdefine_coding_system_internal):
4301 Don't assume fixnums fit in int.
4302 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4303 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4304 (Funencodable_char_position, Fcheck_coding_systems_region)
4305 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4307 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4308 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4309 Don't access memory outside of the args array.
d311d28c 4310 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4311 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4312 result of ENCODE_CHAR.
d311d28c
PE
4313 * coding.h: Adjust decls to match defn changes elsewhere.
4314 (struct coding_system):
4315 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4316 * composite.c (get_composition_id, find_composition)
4317 (run_composition_function, update_compositions)
4318 (compose_text, composition_gstring_put_cache)
4319 (composition_gstring_p, composition_gstring_width)
4320 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4321 (composition_compute_stop_pos, composition_reseat_it)
4322 (composition_update_it, struct position_record)
4323 (find_automatic_composition, composition_adjust_point)
4324 (Fcomposition_get_gstring, Ffind_composition_internal):
4325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4326 (update_compositions):
4327 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4328 * composite.h: Adjust decls to match defn changes elsewhere.
4329 (struct composition):
4330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4331 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4332 Do not attempt to compute the address of the object just before a
4333 buffer; this is not portable.
4334 (Faref, Faset):
4335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4336 (Faset): Use int, not EMACS_INT, where int is wide enough.
4337 (Fstring_to_number): Don't assume fixnums fit in int.
4338 (Frem): Don't assume arg is nonnegative.
4339 * dbusbind.c (xd_append_arg): Check for integers out of range.
4340 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4341 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4342 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4343 (xd_get_connection_references): Return ptrdiff_t, not int.
4344 All uses changed.
4345 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4346 (xd_read_message_1):
4347 Use int, not unsigned, where the dbus API uses int.
4348 (Fdbus_message_internal): Don't overflow mtype.
4349 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4350 * dired.c (directory_files_internal, file_name_completion, scmp)
4351 (file_name_completion_stat):
4352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4353 (file_name_completion): Don't overflow matchcount.
4354 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4355 * dispextern.h: Adjust decls to match defn changes elsewhere.
4356 (struct text_pos, struct glyph, struct bidi_saved_info)
4357 (struct bidi_string_data, struct bidi_it, struct composition_it)
4358 (struct it):
4359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4360 (struct display_pos, struct composition_it, struct it):
4361 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4362 * dispnew.c (increment_matrix_positions)
4363 (increment_row_positions, mode_line_string)
4364 (marginal_area_string):
4365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4366 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4367 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4368 (duration_to_sec_usec): New function, to check for overflow better.
4369 (Fsleep_for, sit_for): Use it.
4370 * doc.c (get_doc_string, store_function_docstring):
4371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4372 (get_doc_string, Fsnarf_documentation):
4373 Use int, not EMACS_INT, where int is wide enough.
4374 (get_doc_string):
4375 Use SAFE_ALLOCA, not alloca.
4376 Check for overflow when converting EMACS_INT to off_t.
4377 * doprnt.c (doprnt):
4378 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4379 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4380 Don't assume uid_t fits into fixnum.
4381 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4382 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4383 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4384 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4385 (general_insert_function)
4386 (Finsert_char, make_buffer_string, make_buffer_string_both)
4387 (update_buffer_properties, Fbuffer_substring)
4388 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4389 (Fsubst_char_in_region, check_translation)
4390 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4391 (transpose_markers, Ftranspose_regions):
4392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4393 (clip_to_bounds): Move to lisp.h as an inline function).
4394 (Fconstrain_to_field): Don't assume integers are nonnegative.
4395 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4396 (Fsubst_char_in_region, Fsave_restriction):
4397 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4398 (Femacs_pid): Don't assume pid_t fits into fixnum.
4399 (lo_time): Use int, not EMACS_INT, when int suffices.
4400 (lisp_time_argument): Check for usec out of range.
4401 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4402 (Fuser_login_name, Fuser_full_name): Signal an error
4403 if a uid argument is out of range, rather than relying on
4404 undefined behavior.
c8d5c857
PE
4405 (Fformat_time_string): Remove now-unnecessary check.
4406 lisp_time_argument checks for out-of-range usec now.
243e0530 4407 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4408 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4409 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4410 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4411 (init_cmdargs, Fdump_emacs):
4412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4413 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4414 the bottom (typically) 32 bits of the fixnum.
4415 * eval.c (specpdl_size, call_debugger):
4416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4417 (when_entered_debugger, Fbacktrace_debug):
4418 Don't assume fixnum can fit in int.
4419 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4420 the object just before a buffer; this is not portable.
4421 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4422 (grow_specpdl, unbind_to):
4423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4424 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4425 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4426 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4427 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4428 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4429 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4430 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4431 (a_write, e_write):
4432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4433 (Fcopy_file, non_regular_nbytes, read_non_regular)
4434 (Finsert_file_contents):
4435 Use int, not EMACS_INT, where int is wide enough.
4436 (READ_BUF_SIZE): Verify that it fits in int.
4437 (Finsert_file_contents): Check that counts are in proper range,
4438 rather than assuming fixnums fit into ptrdiff_t etc.
4439 Don't assume fixnums fit into int.
125b3835 4440 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4441 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4442 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4443 (string_char_to_byte, string_byte_to_char)
4444 (string_make_multibyte, string_to_multibyte)
4445 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4446 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4447 (substring_both, Fdelete, internal_equal, Ffillarray)
4448 (Fclear_string, mapcar1)
4449 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4450 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4451 (larger_vector, make_hash_table, maybe_resize_hash_table)
4452 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4453 (Fmaphash, secure_hash):
4454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4455 (concat): Check for string index and length overflow.
4456 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4457 (Frequire):
4458 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4459 (larger_vector): New API (vec, incr_min, size_max) replaces old
4460 one (vec, new_size, init). This catches size overflow.
4461 INIT was removed because it was always Qnil.
4462 All callers changed.
4463 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4464 the upper bound on a hash table index size.
4465 (make_hash_table, maybe_resize_hash_table): Use it.
4466 (secure_hash): Computer start_byte and end_byte only after
4467 they're known to be in ptrdiff_t range.
4468 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4469 (Ffont_get_glyphs, Ffont_at):
4470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4471 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4472 (Flist_fonts, Fopen_font):
4473 Don't assume fixnum can fit in int.
4474 (check_gstring): Don't assume index can fit in int.
4475 (font_match_p): Check that fixnum is a character, not a nonnegative
4476 fixnum, since the later code needs to stuff it into an int.
4477 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4478 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4479 conversion overflow issues.
4480 (Fopen_font): Check for integer out of range.
4481 (Ffont_get_glyphs): Don't assume index can fit in int.
4482 * font.h: Adjust decls to match defn changes elsewhere.
4483 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4484 integer overflow.
4485 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4486 printmax_t, where ptrdiff_t is wide enough.
4487 (Finternal_char_font):
4488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4489 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4490 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4491 (Fset_frame_position, x_set_frame_parameters)
4492 (x_set_line_spacing, x_set_border_width)
4493 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4494 Check that fixnums are in proper range for system types.
4495 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4497 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4498 Use SAFE_ALLOCA_LISP, not alloca.
4499 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4500 intptr_t is wide enough.
4501 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4502 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4503 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4504 Check for fixnum out of range.
4505 * ftfont.c (ftfont_list): Don't assume index fits in int.
4506 Check that fixnums are in proper range for system types.
4507 (ftfont_shape_by_flt):
4508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4509 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4511 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4512 Check that fixnums are in proper range for system types.
4513 * gnutls.h: Adjust decls to match defn changes elsewhere.
4514 * gtkutil.c (xg_dialog_run):
4515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4516 (update_frame_tool_bar):
4517 Check that fixnums are in proper range for system types.
4518 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4519 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4520 * indent.c (last_known_column, last_known_column_point):
4521 (current_column_bol_cache):
4522 (skip_invisible, current_column, check_display_width):
4523 (check_display_width, scan_for_column, current_column_1)
4524 (Findent_to, Fcurrent_indentation, position_indentation)
4525 (indented_beyond_p, Fmove_to_column, compute_motion):
4526 (Fcompute_motion, Fvertical_motion):
4527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4528 (last_known_column_modified): Use EMACS_INT, not int.
4529 (check_display_width):
4530 (Fcompute_motion):
4531 Check that fixnums and floats are in proper range for system types.
4532 (compute_motion): Don't assume index or fixnum fits in int.
4533 (compute_motion, Fcompute_motion):
4534 Use int, not EMACS_INT, when it is wide enough.
4535 (vmotion): Omit local var start_hpos that is always 0; that way
4536 we don't need to worry about overflow in expressions involving it.
4537 * indent.h: Adjust decls to match defn changes elsewhere.
4538 (struct position):
4539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4540 Use int, not EMACS_INT, where int is wide enough.
4541 Remove unused members ovstring_chars_done and tab_offset;
4542 all uses removed.
4543 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4544 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4545 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4546 (make_gap, copy_text, insert, insert_and_inherit)
4547 (insert_before_markers, insert_before_markers_and_inherit)
4548 (insert_1, count_combining_before, count_combining_after)
4549 (insert_1_both, insert_from_string)
4550 (insert_from_string_before_markers, insert_from_string_1)
4551 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4552 (adjust_after_replace, adjust_after_insert, replace_range)
4553 (replace_range_2, del_range, del_range_1, del_range_byte)
4554 (del_range_both, del_range_2, modify_region)
4555 (prepare_to_modify_buffer, signal_before_change)
4556 (signal_after_change, Fcombine_after_change_execute):
4557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4558 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4559 (balance_an_interval, split_interval_right, split_interval_left)
4560 (find_interval, next_interval, update_interval)
4561 (adjust_intervals_for_insertion, delete_node, delete_interval)
4562 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4563 (static_offset_intervals, offset_intervals)
4564 (merge_interval_right, merge_interval_left, make_new_interval)
4565 (graft_intervals_into_buffer, temp_set_point_both)
4566 (temp_set_point, set_point, adjust_for_invis_intang)
4567 (set_point_both, move_if_not_intangible, get_property_and_range)
4568 (get_local_map, copy_intervals, copy_intervals_to_string)
4569 (compare_string_intervals, set_intervals_multibyte_1):
4570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4571 * intervals.h: Adjust decls to match defn changes elsewhere.
4572 (struct interval):
4573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4574 * keyboard.c (this_command_key_count, this_single_command_key_start)
4575 (before_command_key_count, before_command_echo_length, echo_now)
4576 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4577 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4578 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4579 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4581 (last_non_minibuf_size, last_point_position, echo_truncate)
4582 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4583 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4584 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4585 (stuff_buffered_input):
4586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4587 (last_auto_save, command_loop_1, read_char):
4588 Use EMACS_INT, not int, to avoid integer overflow.
4589 (record_char): Avoid overflow in total_keys computation.
4590 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4591 * keyboard.h: Adjust decls to match defn changes elsewhere.
4592 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4593 (Fkey_description, Fdescribe_vector, Flookup_key):
4594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4595 (click_position): New function, to check that positions are in range.
4596 (Fcurrent_active_maps):
4597 (describe_command):
4598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4599 (Faccessible_keymaps, Fkey_description):
4600 (preferred_sequence_p):
4601 Don't assume fixnum can fit into int.
4602 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4603 Check for integer overflow in size calculations.
4604 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4605 avoid mishandling large integers.
4606 * lisp.h: Adjust decls to match defn changes elsewhere.
4607 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4608 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4609 (struct Lisp_Marker):
4610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4611 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4612 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4613 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4614 All callers changed.
4615 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4616 Assume the arg has valid form, since it always does.
4617 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4618 unsigned integer system type.
4619 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4620 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4622 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4623 (duration_to_sec_usec): New decl.
4624 * lread.c (read_from_string_index, read_from_string_index_byte)
4625 (read_from_string_limit, readchar, unreadchar, openp)
4626 (read_internal_start, read1, oblookup):
4627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4628 (Fload, readevalloop, Feval_buffer, Feval_region):
4629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4630 (openp): Check for out-of-range argument to 'access'.
4631 (read1): Use int, not EMACS_INT, where int is wide enough.
4632 Don't assume fixnum fits into int.
6efdadfd 4633 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4634 (read_filtered_event): Use duration_to_sec_usec
4635 to do proper overflow checking on durations.
d311d28c
PE
4636 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4637 in size calculation.
4638 (Fexecute_kbd_macro):
4639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4640 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4641 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4642 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4643 (set_marker_both, set_marker_restricted_both, marker_position)
4644 (marker_byte_position, Fbuffer_has_markers_at):
4645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4646 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4647 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4648 It now merely ensures that the menu is large enough, without
4649 necessarily growing it, as this avoids some integer overflow issues.
4650 All callers changed.
4651 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4653 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4654 Use SAFE_ALLOCA_LISP, not alloca.
4655 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4656 to EMACS_INT. Check that fixnums are in proper range for system types.
4657 * minibuf.c (minibuf_prompt_width, string_to_object)
4658 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4659 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4661 (get_minibuffer, read_minibuf_unwind):
4662 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4663 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4664 this simplifies overflow checking. All callers changed.
4665 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4666 (Ftest_completion):
4667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4668 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4669 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4670 Check that fixnums are in proper range for system types.
4671 (Fx_create_frame, Fx_show_tip):
4672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4673 * nsfont.m (ns_findfonts, nsfont_list_family):
4674 Don't assume fixnum fits in long.
4675 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4677 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4678 wide enough.
17fdb222 4679 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4680 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4681 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4682 (PRINTDECLARE, PRINTPREPARE):
4683 (strout, print_string):
4684 (print, print_preprocess, print_check_string_charset_prop)
4685 (print_object):
4686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4687 (PRINTDECLARE):
4688 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4690 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4691 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4692 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4693 (print_error_message): Use SAFE_ALLOCA, not alloca.
4694 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4695 (print_depth, new_backquote_output, print_number_index):
4696 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4697 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4698 (Fset_process_window_size, Fformat_network_address)
4699 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4700 (sigchld_handler):
d311d28c 4701 Check that fixnums are in proper range for system types.
d44287d4 4702 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4703 Check for process-ids out of pid_t range rather than relying on
4704 undefined behavior.
e4d81efc 4705 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4706 (Fformat_network_address, read_process_output, send_process)
4707 (Fprocess_send_region, status_notify):
4708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4709 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4710 (wait_reading_process_output, read_process_output, exec_sentinel):
4711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4712 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4713 (Faccept_process_output): Use duration_to_sec_usec to do proper
4714 overflow checking on durations.
dde14581
PE
4715 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4716 Don't assume pid_t fits in int.
02481186
PE
4717 * process.h (struct Lisp_Process): Members tick and update_tick
4718 are now of type EMACS_INT, not int.
b62b53e8
PE
4719 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4720 configured --with-wide-int.
d311d28c
PE
4721 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4722 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4723 * search.c (looking_at_1, string_match_1):
4724 (fast_string_match, fast_c_string_match_ignore_case)
4725 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4726 (scan_newline, find_before_next_newline, search_command)
4727 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4728 (set_search_regs, wordify):
4729 (Freplace_match):
4730 (Fmatch_data):
4731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4732 (string_match_1, search_buffer, set_search_regs):
4733 (Fmatch_data):
4734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4735 (wordify): Check for overflow in size calculation.
4736 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4737 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4738 Check that fixnums are in proper range for system types.
4739 * sound.c (struct sound_device)
4740 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4742 (Fplay_sound_internal):
4743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4744 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4745 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4746 (Fparse_partial_sexp):
4747 Don't assume fixnums can fit in int.
4748 (struct lisp_parse_state, find_start_pos, find_start_value)
4749 (find_start_value_byte, find_start_begv)
4750 (update_syntax_table, char_quoted, dec_bytepos)
4751 (find_defun_start, prev_char_comend_first, back_comment):
4752 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4753 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4755 (Finternal_describe_syntax_value): Check that match_lisp is a
4756 character, not an integer, since the code stuffs it into int.
4757 (scan_words, scan_sexps_forward):
4758 Check that fixnums are in proper range for system types.
4759 (Fforward_word):
4760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4761 (scan_sexps_forward):
4762 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4763 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4764 * syntax.h: Adjust decls to match defn changes elsewhere.
4765 (struct gl_state_s):
4766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4767 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4768 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4769 * sysdep.c (wait_for_termination_1, wait_for_termination)
4770 (interruptible_wait_for_termination, mkdir):
4771 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4772 (emacs_read, emacs_write):
4773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4774 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4775 and double all fit in int.
d311d28c
PE
4776 * term.c (set_tty_color_mode):
4777 Check that fixnums are in proper range for system types.
4778 * termhooks.h (struct input_event):
4779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4780 * textprop.c (validate_interval_range, interval_of)
4781 (Fadd_text_properties, set_text_properties_1)
4782 (Fremove_text_properties, Fremove_list_of_text_properties)
4783 (Ftext_property_any, Ftext_property_not_all)
4784 (copy_text_properties, text_property_list, extend_property_ranges)
4785 (verify_interval_modification):
4786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4787 (Fnext_single_char_property_change)
4788 (Fprevious_single_char_property_change):
4789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4790 (copy_text_properties):
4791 Check for integer overflow in index calculation.
d311d28c
PE
4792 * undo.c (last_boundary_position, record_point, record_insert)
4793 (record_delete, record_marker_adjustment, record_change)
4794 (record_property_change):
4795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4796 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4798 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4799 (Fx_hide_tip, Fx_file_dialog):
4800 * w32menu.c (set_frame_menubar):
4801 Use ptrdiff_t, not int, for consistency with rest of code.
4802 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4803 (select_window, Fdelete_other_windows_internal)
4804 (window_scroll_pixel_based, window_scroll_line_based)
4805 (Frecenter, Fset_window_configuration):
4806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4807 (Fset_window_hscroll, run_window_configuration_change_hook)
4808 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4809 (Fscroll_other_window, Frecenter):
d311d28c
PE
4810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4811 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4812 Don't assume fixnum fits in int.
4813 (Fset_window_scroll_bars):
4814 Check that fixnums are in proper range for system types.
4815 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4816 (string_pos, c_string_pos, number_of_chars, init_iterator)
4817 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4818 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4819 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4820 (face_before_or_after_it_pos, handle_invisible_prop)
4821 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4822 (display_prop_intangible_p, string_buffer_position_lim)
4823 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4824 (get_overlay_strings_1, get_overlay_strings)
4825 (iterate_out_of_display_property, forward_to_next_line_start)
4826 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4827 (get_next_display_element, set_iterator_to_next)
4828 (get_visually_first_element, compute_stop_pos_backwards)
4829 (handle_stop_backwards, next_element_from_buffer)
4830 (move_it_in_display_line_to, move_it_in_display_line)
4831 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4832 (add_to_log, message_dolog, message_log_check_duplicate)
4833 (message2, message2_nolog, message3, message3_nolog
4834 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4835 (current_message_1, truncate_echo_area, truncate_message_1)
4836 (set_message, set_message_1, store_mode_line_noprop)
4837 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4838 (text_outside_line_unchanged_p, check_point_in_composition)
4839 (reconsider_clip_changes)
4840 (redisplay_internal, set_cursor_from_row, try_scrolling)
4841 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4842 (redisplay_window, find_last_unchanged_at_beg_row)
4843 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4844 (trailing_whitespace_p, find_row_edges, display_line)
4845 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4846 (display_mode_element, store_mode_line_string)
4847 (pint2str, pint2hrstr, decode_mode_spec)
4848 (display_count_lines, display_string, draw_glyphs)
4849 (x_produce_glyphs, x_insert_glyphs)
4850 (rows_from_pos_range, mouse_face_from_buffer_pos)
4851 (fast_find_string_pos, mouse_face_from_string_pos)
4852 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4853 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4854 (safe_call, init_from_display_pos, handle_fontified_prop)
4855 (handle_single_display_spec, load_overlay_strings)
4856 (with_echo_area_buffer, setup_echo_area_for_printing)
4857 (display_echo_area, echo_area_display)
4858 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4859 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4860 (redisplay_window, dump_glyph_row, display_mode_line)
4861 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4862 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4864 (handle_single_display_spec, build_desired_tool_bar_string)
4865 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4866 (get_specified_cursor_type):
4867 Check that fixnums are in proper range for system types.
4868 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4869 (Flookup_image_map):
4870 Don't assume fixnums fit in int.
4871 (compare_overlay_entries):
4872 Avoid mishandling comparisons due to subtraction overflow.
4873 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4874 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4875 (handle_tool_bar_click):
4876 Use int, not unsigned, since we prefer signed and the signedness
4877 doesn't matter here.
4878 (get_next_display_element, next_element_from_display_vector):
4879 Use int, not EMACS_INT, when int is wide enough.
4880 (start_hourglass): Use duration_to_sec_usec to do proper
4881 overflow checking on durations.
4882 * xfaces.c (Fbitmap_spec_p):
4883 Check that fixnums are in proper range for system types.
4884 (compare_fonts_by_sort_order):
4885 Avoid mishandling comparisons due to subtraction overflow.
4886 (Fx_family_fonts, realize_basic_faces):
4887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4888 (Fx_family_fonts):
4889 Don't assume fixnum fits in int.
4890 Use SAFE_ALLOCA_LISP, not alloca.
4891 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4892 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4893 (face_at_buffer_position, face_for_overlay_string)
4894 (face_at_string_position):
4895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4896 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4897 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4898 (Fx_show_tip):
4899 Check that fixnums are in proper range for system types.
4900 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4901 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4902 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4903 (Fx_change_window_property): Don't assume fixnums fit in int.
4904 * xfont.c (xfont_chars_supported):
4905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4906 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4907 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4909 * xml.c (parse_region):
4910 * xrdb.c (magic_file_p):
4911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4912 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4913 (x_get_local_selection, x_reply_selection_request)
4914 (x_handle_selection_request, wait_for_property_change):
4915 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4916 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4917 short is wide enough.
4918 (x_send_client_event): Don't assume fixnum fits in int.
4919 * xterm.c (x_x_to_emacs_modifiers):
4920 Don't assume EMACS_INT overflows nicely into int.
4921 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4922 may come from Lisp.
4923 (handle_one_xevent): NATNUMP can eval its arg twice.
4924 (x_connection_closed):
4925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4926 * xterm.h: Adjust decls to match defn changes elsewhere.
4927 (struct scroll_bar): Use struct vectorlike_header
4928 rather than rolling our own approximation.
4929 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4930
c6574eb5
GM
49312012-05-25 Glenn Morris <rgm@gnu.org>
4932
4933 * lisp.mk (lisp): Update for more files being compiled now.
4934
e8d32c7e
SM
49352012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4936
48def666
SM
4937 * lread.c: Remove `read_pure' which makes no difference.
4938 (read_pure): Remove var.
4939 (unreadpure): Remove function.
4940 (readevalloop): Don't call read_list with -1 flag.
4941 (read1, read_vector): Don't test read_pure any more.
4942 (read_list): Simplify.
4943
e8d32c7e
SM
4944 * fileio.c, character.h: Minor style tweaks.
4945
4b2addb7
DA
49462012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4947
4948 * window.h (clip_changed): Remove useless declaration.
4949
584461b2
JB
49502012-05-22 Juanma Barranquero <lekktu@gmail.com>
4951
4952 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4953 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4954
34374650
PE
49552012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4956
4957 Remove src/m/*.
4958 This directory predates autoconf and is no longer needed nowadays.
4959 Move its few remaining bits of functionality to where they're needed.
4960 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4961 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4962 * m/template.h: Remove.
4963 * Makefile.in (M_FILE): Remove. All uses removed.
4964 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4965 * lisp.h (USE_LSB_TAG):
4966 * mem-limits.h (EXCEEDS_LISP_PTR):
4967 Use VAL_MAX, not VALBITS, in #if.
4968 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4969 (EMACS_UINT): Define unconditionally now.
4970 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4971 (BITS_PER_EMACS_INT): New constants, replacing
4972 what used to be in config.h, but not useful in #if.
4973 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4974 define them any more.
4975 (VAL_MAX): New macro.
4976 (VALMASK): Use it.
4977 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4978 BITS_PER_EMACS_INT, in #if.
4979 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4980 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4981 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4982 * s/ms-w32.h (DATA_START):
4983 Move here from removed file m/intel386.h.
4984 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4985 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4986
261cb4bb
PE
49872012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4988
4989 Assume C89 or later.
4990 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4991 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4992 (xrealloc):
4993 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4994 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4995 * textprop.c, tparam.c (NULL): Remove.
4996 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4997 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4998 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4999 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
5000 * xterm.c (input_signal_count): Assume volatile works.
5001
ff23cd9f
KB
50022012-05-21 Ken Brown <kbrown@cornell.edu>
5003
5004 * xgselect.c (xg_select): Fix first argument in call to 'select'
5005 (bug#11508).
5006
1b170bc6
KB
50072012-05-20 Ken Brown <kbrown@cornell.edu>
5008
5009 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5010 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5011
b2f4d39f
KB
50122012-05-19 Ken Brown <kbrown@cornell.edu>
5013
5014 * xfns.c (x_in_use): Remove `static' qualifier.
5015 * xterm.h (x_in_use): Declare.
5016 * xgselect.c: Include xterm.h.
5017 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5018 and `display_arg' (bug#9754).
5019
003fdae2
PE
50202012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5021
9232a6d9
PE
5022 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5023
003fdae2
PE
5024 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5025 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5026
784b56e2
EZ
50272012-05-18 Eli Zaretskii <eliz@gnu.org>
5028
5029 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5030
5031 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5032 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5033
5034 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5035 reference to image_cache->refcount.
5036 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5037
a0a79cde
JL
50382012-05-17 Juri Linkov <juri@jurta.org>
5039
5040 * search.c (Fword_search_regexp, Fword_search_backward)
5041 (Fword_search_forward, Fword_search_backward_lax)
5042 (Fword_search_forward_lax): Move functions to isearch.el
5043 (bug#10145, bug#11381).
5044
b0572523
PE
50452012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5046
5047 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5048
9660f5fc
SM
50492012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5050
5051 * lread.c (init_obarray): Declare Qt and Qnil as special.
5052
4374de83
GM
50532012-05-14 Glenn Morris <rgm@gnu.org>
5054
5055 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5056 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5057
dc44c39a
PE
50582012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5059
078c97cb
PE
5060 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5061
dc44c39a
PE
5062 * unexaix.c: Port to more-recent AIX compilers.
5063 (report_error, report_error_1, make_hdr, copy_sym)
5064 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5065 Make arguments const char *, not char *, to avoid violations of C
5066 standard and to fix some AIX warnings reported by Gilles Pion.
5067
e18afed7 50682012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5069
5070 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5071 already have overlays loaded.
5072 (handle_single_display_spec): Before returning without displaying
5073 fringe bitmap, synchronize the bidi iterator with the main display
5074 iterator, by calling iterate_out_of_display_property.
5075 (iterate_out_of_display_property): Detect buffer iteration by
5076 testing that it->string is a Lisp string.
5077 (get_next_display_element): When the current object is exhausted,
5078 and there's something on it->stack, call set_iterator_to_next to
5079 proceed with what's on the stack, instead of returning zero.
5080 (set_iterator_to_next): If called at the end of a Lisp string,
5081 proceed to consider_string_end without incrementing string
5082 position. Don't increment display vector index past the end of
5083 the display vector. (Bug#11417)
c8fb9dc6
EZ
5084 (pos_visible_p): Don't report a position visible when move_it_to
5085 stopped at the last line of window, which happens to be scanned
5086 backwards by the bidi iteration. (Bug#11464)
ac268e67 5087
e18afed7 50882012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5089
5090 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5091 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5092 are on a TTY, and thus unable to display on the fringes.
5093 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5094 so we need to signal to the caller that this is a "replacing"
5095 display spec. This fixes display when the spec is invalid or we
5096 are on a TTY.
5097
e18afed7 50982012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5099
5100 * unexaix.c (make_hdr): Fix typo in prototype.
5101 This bug broke the build on AIX. Problem reported by Gilles Pion.
5102
9d0a235a
MA
51032012-05-14 Michael Albinus <michael.albinus@gmx.de>
5104
5105 * keyboard.c (kbd_buffer_get_event): Read special events also in
5106 batch mode. (Bug#11415)
5107
9e6b06ed
GM
51082012-05-12 Glenn Morris <rgm@gnu.org>
5109
5110 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5111
c1a1d7a3
EZ
51122012-05-12 Eli Zaretskii <eliz@gnu.org>
5113
5114 * lisp.mk (lisp): Add newcomment.elc.
5115
3fe7cdc8
GM
51162012-05-12 Glenn Morris <rgm@gnu.org>
5117
5118 * Makefile.in (MKDIR_P): New, set by configure.
5119 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5120
53f7d2c0
PE
51212012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5122
5123 Remove unused function hourglass_started.
5124 * dispextern.h (hourglass_started):
5125 * w32fns.c (hourglass_started):
5126 * xdisp.c (hourglass_started): Remove.
5127
75aafb17
JB
51282012-05-10 Juanma Barranquero <lekktu@gmail.com>
5129
5130 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5131 Update dependencies.
5132
12959e8e
PE
51332012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5134
97107e2e
PE
5135 * xgselect.c (xg_select): Put maxfds+1 into a var.
5136 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5137
12959e8e
PE
5138 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5139
836d29b3
DA
51402012-05-10 Dave Abrahams <dave@boostpro.com>
5141
5142 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5143 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5144
5cb67954
MA
51452012-05-09 Michael Albinus <michael.albinus@gmx.de>
5146
5147 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5148 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5149 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5150 Initialize xd_registered_buses.
5151
3478ec45
PE
51522012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5153
b263a6b0
PE
5154 Untag more efficiently if USE_LSB_TAG.
5155 This is based on a proposal by YAMAMOTO Mitsuharu in
5156 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5157 For an admittedly artificial (nth 8000 longlist) benchmark on
5158 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5159 Emacs's overall text size by 1%.
5160 * lisp.h (XUNTAG): New macro.
5161 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5162 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5163 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5164 * eval.c (Fautoload):
5165 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5166 * frame.h (XFRAME): Use XUNTAG.
5167
3478ec45
PE
5168 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5169 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5170 Remove unportable assumptions about print widths of types like
5171 dbus_uint32_t.
5172 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5173 intptr_t when converting between pointer and integer, to avoid GCC
5174 warnings about wrong width.
5175
666b903b 51762012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5177
5178 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5179 stack for each reader_thread, instead of defaulting to 8MB
5180 determined by the linker. This avoids failures in creating
5181 subprocesses on Windows 7, see the discussion in this thread:
5182 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5183
b120cc17
JC
51842012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5185
5186 Fix up display of the *Minibuf-0* buffer in the mini window.
5187 * keyboard.c (read_char): Don't clear the echo area if there's no
5188 message to clear.
5189 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5190 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5191
9a4b36f8
MA
51922012-05-07 Michael Albinus <michael.albinus@gmx.de>
5193
5194 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5195 batch mode.
5196
e5f9458f
CY
51972012-05-06 Chong Yidong <cyd@gnu.org>
5198
5199 * lisp.mk (lisp): Update.
5200
eceeb5fc 52012012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5202
5203 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5204
71873e2b
SM
52052012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5206
5207 * data.c (PUT_ERROR): New macro.
5208 (syms_of_data): Use it. Add new error type `user-error'.
5209 * undo.c (user_error): New function.
5210 (Fprimitive_undo): Use it.
5211 * print.c (print_error_message): Adjust print style for `user-error'.
5212 * keyboard.c (user_error): New function.
5213 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5214
ab0fa4e4
PE
52152012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5216
5217 Do not limit current-time-string to years 1000..9999.
5218 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5219 (Fcurrent_time_string): Support any year that is supported by the
5220 underlying localtime representation. Don't use asctime, as it
5221 has undefined behavior for years outside the range -999..9999.
5222
7ed806a7
PE
52232012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5224
5225 Fix race conditions involving setenv, gmtime, localtime, asctime.
5226 Without this fix, interrupts could mess up code that uses these
5227 nonreentrant functions, since setting TZ invalidates existing
5228 tm_zone or tzname values, and since most of these functions return
5229 pointers to static storage.
5230 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5231 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5232 Grow the critical sections to include not just invoking
5233 localtime/gmtime, but also accessing these functions' results
5234 including their tm_zone values if any, and any related TZ setting.
5235 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5236 so that the struct tm is saved in the critical section.
5237 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5238 motivated by the fact that memory allocation needs to be outside
5239 the critical section.
5240
0c16dfed
DA
52412012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5242
5243 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5244 with RESET_INTERVAL.
5245
5246 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5247 Remove duplicated buffer name initialization.
5248
3f83ace8
JM
52492012-05-02 Jim Meyering <jim@meyering.net>
5250
5251 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5252
c7b8541e
JM
5253 * xfns.c (x_window): Use xstrdup (Bug#11375).
5254
90207a15 52552012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5256
5257 * xdisp.c (pos_visible_p): If already at a newline from the
5258 display string before the 'while' loop, don't walk back the glyphs
5259 from it3.glyph_row. Solves assertion violation when the display
5260 string begins with a newline (egg.el). (Bug#11367)
5261
b593d6a9
AH
52622012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5263
5264 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5265 Move to simple.el.
5266
4737362e
GM
52672012-05-01 Glenn Morris <rgm@gnu.org>
5268
99cf43f9
GM
5269 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5270 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5271 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5272 All were removed before 23.1.
5273
9311dcff
GM
5274 * dispnew.c: Remove HAVE_LIBNCURSES test;
5275 it is always true on relevant platforms.
5276
4d5c6349
GM
5277 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5278 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5279
4737362e
GM
5280 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5281
74dd3a6b
AS
52822012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5283
5284 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5285 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5286 Remove.
5287
13c379ee
PE
52882012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5289
5290 Do not avoid creating empty evaporating overlays (Bug#9642).
5291 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5292 That is, do not delete an evaporating overlay if it becomes
5293 empty after its bounds are adjusted to fit within its buffer.
5294 This fix caused other problems, and I'm reverting it until we get
5295 to the bottom of them.
5296
a8e7d6d7 52972012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5298
5299 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5300
a8e7d6d7 53012012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5302
5303 * xdisp.c (pos_visible_p): If the window start position is beyond
5304 ZV, start the display from buffer beginning. Prevents assertion
5305 violation in init_iterator when the minibuffer window is scrolled
5306 via the scroll bar.
5307
5308 * window.c (window_scroll_pixel_based): Likewise.
5309
a8e7d6d7 53102012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5311
5312 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5313
a8e7d6d7 53142012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5315
5316 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5317 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5318
a8e7d6d7 53192012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5320
b593d6a9
AH
5321 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5322 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5323
1c6900d9
EZ
53242012-04-26 Eli Zaretskii <eliz@gnu.org>
5325
4c3fa1d9
EZ
5326 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5327 display element, check also the underlying string or buffer
5328 character. (Bug#11341)
5329
1c6900d9
EZ
5330 * w32menu.c: Include w32heap.h.
5331 (add_menu_item): If the call to AppendMenuW (via
5332 unicode_append_menu) fails, disable Unicode menus only if we are
5333 running on Windows 9X/Me.
5334
42bf8205
AS
53352012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5336
5337 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5338 (xgetint): Add missing shift for LSB tags.
5339
b1bac16e
MR
53402012-04-24 Martin Rudalics <rudalics@gmx.at>
5341
5342 * keyboard.c (read_char): Don't wipe echo area for select window
5343 events: These might get delayed via `mouse-autoselect-window'
5344 (Bug#11304).
5345
d69621cc
JB
53462012-04-24 Juanma Barranquero <lekktu@gmail.com>
5347
5348 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5349 manipulation of :loaded-from data.
5350
02fd101b
JB
53512012-04-23 Juanma Barranquero <lekktu@gmail.com>
5352
5353 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5354 now a cons (bug#11311).
5355
888bec30
PE
53562012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5357
89a438bd
PE
5358 Do not create empty overlays with the evaporate property (Bug#9642).
5359 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5360 if it becomes empty after its bounds are adjusted to fit within
5361 its buffer. Without this fix, in a nonempty buffer (let ((o
5362 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5363 yields an empty overlay that has the evaporate property, which is
5364 not supposed to happen.
5365
1068fe4d
PE
5366 Fix minor GTK3 problems found by static checking.
5367 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5368 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5369 (struct _EmacsFixedClass, emacs_fixed_get_type):
5370 Move decls here from emacsgtkfixed.h, since they needn't be public.
5371 (emacs_fixed_get_type): Now static.
5372 (emacs_fixed_class_init): Omit unused local.
5373 (emacs_fixed_child_type): Remove; unused.
5374 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5375 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5376 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5377 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5378 (EMACS_FIXED_GET_CLASS): Remove; unused.
5379 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5380
888bec30
PE
5381 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5382 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5383
de85e130
PE
53842012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5385
d0baac98 5386 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5387 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5388 (__malloc_size_t, __malloc_ptrdiff_t):
5389 Remove. All uses removed, replaced by the definiens if needed,
5390 since we can assume C89 or better now.
5391 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5392 (protect_malloc_state, align, get_contiguous_space)
5393 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5394 (malloc_atfork_handler_child, malloc_enable_thread)
5395 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5396 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5397 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5398 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5399 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5400 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5401 Define using prototypes, not old style.
5402 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5403 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5404 (align): Don't assume that signed integer overflow wraps around.
5405 Omit unused local var.
5406 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5407 (_free_internal_nolock, memalign, mallochook, reallochook):
5408 Omit no-longer-needed casts.
5409 (valloc): Use getpagesize, not __getpagesize.
5410 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5411 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5412
de85e130
PE
5413 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5414
dcbf5805
MA
54152012-04-22 Michael Albinus <michael.albinus@gmx.de>
5416
5417 Move functions from C to Lisp. Make non-blocking method calls
5418 the default. Implement further D-Bus standard interfaces.
5419
5420 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5421 (QCdbus_request_name_allow_replacement)
5422 (QCdbus_request_name_replace_existing)
5423 (QCdbus_request_name_do_not_queue)
5424 (QCdbus_request_name_reply_primary_owner)
5425 (QCdbus_request_name_reply_in_queue)
5426 (QCdbus_request_name_reply_exists)
5427 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5428 (QCdbus_registered_serial, QCdbus_registered_method)
5429 (QCdbus_registered_signal): New Lisp objects.
5430 (XD_DEBUG_MESSAGE): Use sizeof.
5431 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5432 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5433 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5434 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5435 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5436 (xd_signature, xd_append_arg): Allow float for integer types.
5437 (xd_get_connection_references): New function.
b593d6a9
AH
5438 (xd_get_connection_address): Rename from xd_initialize.
5439 Return cached address.
dcbf5805
MA
5440 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5441 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5442 level.
5443 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5444 Return number of refcounts.
dcbf5805
MA
5445 (Fdbus_get_unique_name): Make stronger parameter check.
5446 (Fdbus_message_internal): New defun.
5447 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5448 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5449 (Fdbus_send_signal, Fdbus_register_service)
5450 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5451 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5452 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5453 (Vdbus_compiled_version, Vdbus_runtime_version)
5454 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5455 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5456 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5457 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5458 Adapt docstring.
dcbf5805 5459
52828e02
PE
54602012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5461
da05bc4c
PE
5462 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5463 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5464 Do not assume ptrdiff_t is the same width as 'int'.
5465
52828e02
PE
5466 * alloc.c: Handle unusual debugging option combinations.
5467 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5468 since the two debugging options are incompatible.
5469 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5470 is defined.
5471 (mem_init, mem_insert, mem_insert_fixup):
5472 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5473 (NEED_MEM_INSERT): Remove; no longer needed.
5474
f01769f9
LL
54752012-04-22 Leo Liu <sdl.web@gmail.com>
5476
5477 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5478
5790543d
PE
54792012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5480
5481 * sysdep.c [__FreeBSD__]: Minor cleanups.
5482 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5483 Use Emacs indenting style more consistently. Avoid some casts.
5484 Use 'double' consistently rather than mixing 'float' and 'double'.
5485
b91b7e4d
EW
54862012-04-21 Eduard Wiebe <usenet@pusto.de>
5487
b593d6a9
AH
5488 * sysdep.c (list_system_processes, system_process_attributes):
5489 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5490
6114eb15
AS
54912012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5492
5493 * lisp.mk (lisp): Update.
5494
2f38dff7
PE
54952012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5496
5497 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5498 It is never used otherwise.
5499
4ae29f89
SM
55002012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5501
5502 * print.c (print_preprocess): Only check print_depth if print-circle
5503 is nil.
5504 (print_object): Check for cycles even when print-circle is nil and
5505 print-gensym is t, but only check print_depth if print-circle is nil.
5506
f30d612a
CY
55072012-04-20 Chong Yidong <cyd@gnu.org>
5508
5509 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5510 set the status to "failed" and ensure that sentinel is run.
5511
c07a4c0b 55122012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5513
5514 * process.c (Fset_process_inherit_coding_system_flag)
5515 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5516 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5517
c07a4c0b 55182012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5519
5520 * xdisp.c (string_buffer_position_lim): Limit starting position to
5521 BEGV.
5522 (set_cursor_from_row): If called for a mode-line or header-line
5523 row, return zero immediately.
5524 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5525 farther than the first row after the header line, if any.
5526 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5527 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5528
c07a4c0b 55292012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5530
4ae29f89
SM
5531 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5532 (bug#11238).
ad3a2b41 5533
c07a4c0b 55342012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 55352012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5536
5537 configure: new option --enable-gcc-warnings (Bug#11207)
5538 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5539 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5540 (ALL_CFLAGS): Use new macros rather than old.
5541 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5542 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5543 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5544 -Wunused-result, -Wunused-variable. This should go away once
5545 the Emacs and Gnulib regex code is merged.
5546 (xmalloc, xrealloc): Now static.
5547
aba027e8
PE
55482012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5549
5550 * dired.c (Fsystem_groups): Remove unused local.
5551
e5a36063
GM
55522012-04-17 Glenn Morris <rgm@gnu.org>
5553
5554 * dired.c (Fsystem_users): Doc fix.
5555
316411f0
DA
55562012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5557
5558 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5559 (syms_of_dired): Add them.
5560
9426aba4
PE
55612012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5562
b62a57be
PE
5563 Fix minor alloc.c problems found by static checking.
5564 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5565 New extern decls, to avoid calling undeclared functions.
5566 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5567 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5568 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5569 (NEED_MEM_INSERT): New macro.
5570 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5571 Remove one incorrect comment and fix another.
b62a57be 5572
3539f31f
PE
5573 Fix minor ralloc.c problems found by static checking.
5574 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5575 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5576 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5577 (r_alloc_sbrk): Now static.
5578
a041960a
PE
5579 Improve ralloc.c interface checking.
5580 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5581 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5582 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5583 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5584 [REL_ALLOC]: ... to here, to check interface.
5585 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5586 Remove decls. This fixes an "It stinks!".
5587
9426aba4
PE
5588 * alloc.c (which_symbols): Fix alignment issue / type clash.
5589
d55c12ed
AS
55902012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5591
5592 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5593 (struct Lisp_Misc_Any): Likewise.
5594 (struct Lisp_Free): Likewise.
5595 * alloc.c (union aligned_Lisp_Symbol): Define.
5596 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5597 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5598 (union aligned_Lisp_Misc): Define.
5599 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5600 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5601 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5602
b948ce8b
PE
56032012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5604
5605 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5606 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5607 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5608 * s/netbsd.h, s/sol2-6.h:
5609 Remove definition of GC_MARK_STACK, since the default now works.
5610 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5611 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5612 no longer the default.
5613 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5614
35dc09a1 56152012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5616
35dc09a1
GM
5617 * lread.c (lisp_file_lexically_bound_p):
5618 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5619
35dc09a1
GM
56202012-04-14 Eli Zaretskii <eliz@gnu.org>
5621
5622 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5623 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5624
56252012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5626
5627 * nsterm.m (constrainFrameRect): Always constrain when there is only
5628 one screen (Bug#10962).
5629
bcd86815
KB
56302012-04-13 Ken Brown <kbrown@cornell.edu>
5631
5632 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5633
c25df26e
RT
56342012-04-13 Reuben Thomas <rrt@sc3d.org>
5635
5636 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5637
0fc59f1e
DC
56382012-04-11 Daniel Colascione <dancol@dancol.org>
5639
5640 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5641 against is gone. It's better to use vfork now so that when Cygwin
5642 gains a new, working vfork, we use it automatically (bug#10398).
5643
de8c03dc
SM
56442012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5645
5646 * window.c (save_window_save): Obey window-point-insertion-type.
5647
2f097256
GM
56482012-04-11 Glenn Morris <rgm@gnu.org>
5649
5650 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5651
453b951e
SM
56522012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5653
5654 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5655
75f1671a 56562012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5657
5658 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5659 (force_quit_count): New var.
5660 (handle_interrupt): Use it.
5661
2a8ce227
JB
56622012-04-10 Juanma Barranquero <lekktu@gmail.com>
5663
5664 * w32.c (w32_delayed_load): Record the full path of the library
5665 being loaded (bug#10424).
5666
935396c0
GM
56672012-04-09 Glenn Morris <rgm@gnu.org>
5668
05920a43
GM
5669 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5670 not just in the obarray, before snarfing them. (Bug#11036)
5671
935396c0
GM
5672 * Makefile.in ($(leimdir)/leim-list.el):
5673 Pass EMACS rather than BUILT_EMACS.
5674
a18ecafa
TZ
56752012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5676
5677 * process.c (make_process):
5678 * process.h: Add integer `gnutls_handshakes_tried' member to
5679 process struct.
5680
6bbef4e5
JC
5681 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5682 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5683
5684 * gnutls.c (gnutls_log_function2i): Convenience log function.
5685 (emacs_gnutls_read): Use new log functions,
5686 `gnutls_handshakes_tried' process member, and
5687 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5688 attempts per process (connection).
5689
b4d3bc10
CY
56902012-04-09 Chong Yidong <cyd@gnu.org>
5691
5692 * eval.c (Fuser_variable_p, user_variable_p_eh)
5693 (lisp_indirect_variable): Functions deleted.
5694 (Fdefvar): Caller changed.
5695
5696 * callint.c (Finteractive, Fcall_interactively):
5697 * minibuf.c (Fread_variable): Callers changed.
5698
70f4d973
EZ
56992012-04-09 Eli Zaretskii <eliz@gnu.org>
5700
5701 * xdisp.c (set_cursor_from_row): If the display string appears in
5702 the buffer at position that is closer to point than the position
5703 after the display string, display the cursor on the first glyph of
5704 the display string. Fixes cursor display when a 'display' text
5705 property immediately follows invisible text. (Bug#11094)
5706
cb3c2e3e
PE
57072012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5708
5709 composite.c: use 'double' consistently
5710 * composite.c (get_composition_id): Use 'double' consistently
5711 instead of converting 'float' to 'double' and vice versa; this is
5712 easier to understand and avoids a GCC warning.
5713
fd06db5d
GM
57142012-04-09 Glenn Morris <rgm@gnu.org>
5715
50fe702a
GM
5716 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5717 preparation for dumping it with emacs. (Bug#4789)
5718 (leimdir): New variable.
5719 ($(leimdir)/leim-list.el): New rule.
5720 (emacs$(EXEEXT)): Depend on leim-list.el.
5721
fd06db5d
GM
5722 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5723 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5724 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5725
55c131ee
AS
57262012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5727
5728 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5729 proper alignment.
5730
9209588f
JB
57312012-04-07 Juanma Barranquero <lekktu@gmail.com>
5732
5733 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5734 Remove unused local variable.
5735
e3fb2efb
PE
57362012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5737
5738 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5739 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5740 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5741 objects, as mark_maybe_pointer will catch them otherwise.
5742 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5743 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5744
b5385551
PE
57452012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5746
5747 Fix typo that broke non-Windows builds.
5748 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5749
9078ead6
EZ
57502012-04-07 Eli Zaretskii <eliz@gnu.org>
5751
5752 Support building on MS-Windows with libxml2.
5753
5754 * makefile.w32-in (OBJ2): Add xml.$(O).
5755 (GLOBAL_SOURCES): Add xml.c.
5756 ($(BLD)/xml.$(O)): New dependency list.
5757
5758 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5759 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5760 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5761 [!WINDOWSNT]: New macros.
5762 (init_libxml2_functions, libxml2_loaded_p): New functions.
5763 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5764 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5765 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5766 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5767 linked in).
6bbef4e5
JC
5768 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5769 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5770 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5771
5772 * emacs.c: Don't include libxml/parser.h.
5773 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5774 xmlCleanupParser directly.
5775
5776 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5777
3811fdf3
EZ
57782012-04-07 Eli Zaretskii <eliz@gnu.org>
5779
5780 * indent.c (Fvertical_motion): If there is a display string at
5781 point, use it.vpos to compute how many lines to backtrack after
5782 move_it_to point. (Bug#11133)
5783
2f8e16b2
EZ
57842012-04-06 Eli Zaretskii <eliz@gnu.org>
5785
5786 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5787 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5788 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5789 macros related to unification of CJK characters. For the details,
5790 see the discussion following the message here:
5791 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5792
3d439cd1
CY
57932012-04-04 Chong Yidong <cyd@gnu.org>
5794
5795 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5796
8bc53d00
EZ
57972012-04-01 Eli Zaretskii <eliz@gnu.org>
5798
5799 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5800 instead of alloca. (Bug#11138)
5801
3b0512a3
AS
58022012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5803
5804 * w32menu.c (is_simple_dialog): Properly check lisp types.
5805 (Bug#11141)
5806
8427ddd2
EZ
58072012-03-31 Eli Zaretskii <eliz@gnu.org>
5808
979022ef
EZ
5809 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5810 position we get to after a call to move_it_to fails the
5811 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5812 only if we wind up in a string from display property. (Bug#11063)
5813
a6b1c7cc
EZ
5814 * window.c (Fdelete_other_windows_internal): Invalidate the row
5815 and column information about mouse highlight, so that redisplay
5816 restores it after reallocating the glyph matrices. (Bug#7464)
5817
8427ddd2
EZ
5818 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5819 string comes from a `display' text property, use the buffer
5820 position of that property as if we actually saw that position in
5821 the row's glyphs.
697ba24b
EZ
5822 (move_it_by_lines): Remove the assertion that
5823 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5824 violated when there's a before-string at the beginning of a line.
5825 (Bug#11063)
8427ddd2 5826
65a0a738
EZ
58272012-03-30 Eli Zaretskii <eliz@gnu.org>
5828
5829 * xdisp.c (append_space_for_newline): If the default face was
5830 remapped, use the remapped face for the appended newline.
5831 (extend_face_to_end_of_line): Use the remapped default face for
5832 extending the face to the end of the line.
5833 (display_line): Call extend_face_to_end_of_line when the default
5834 face was remapped. (Bug#11068)
5835
581355cc
EZ
58362012-03-29 Eli Zaretskii <eliz@gnu.org>
5837
5838 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5839
e8fc049f
SM
58402012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5841
5842 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5843
4fb9a543
GM
58442012-03-27 Glenn Morris <rgm@gnu.org>
5845
5846 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5847 Doc fixes.
5848
679910f1
KH
58492012-03-26 Kenichi Handa <handa@m17n.org>
5850
5851 * dispextern.h (struct glyph): Fix previous change. Change the
5852 bit length of glyphless.ch to 25 (Bug#11082).
5853
90d49b7f
CY
58542012-03-26 Chong Yidong <cyd@gnu.org>
5855
5856 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5857 (command_loop_1): Use it; inhibit selection update for
5858 handle-select-window too (Bug#8996).
5859
f514f6f0
FP
58602012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5861
e8fc049f 5862 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5863
bf43fa51
KH
58642012-03-25 Kenichi Handa <handa@m17n.org>
5865
5866 * dispextern.h (struct glyph): Change the bit length of
5867 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5868
8a0c01dd
EZ
58692012-03-24 Eli Zaretskii <eliz@gnu.org>
5870
5871 * s/ms-w32.h (tzname): Include time.h before redirecting to
5872 _tzname. Fixes the MSVC build. (Bug#9960)
5873
7d1c3a76
AS
58742012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5875
8ed79523
AS
5876 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5877 characters.
5878
7d1c3a76
AS
5879 * xterm.c (XTread_socket): Only modify handling_signal if
5880 !SYNC_INPUT. (Bug#11080)
5881
e99a9b8b
EZ
58822012-03-23 Eli Zaretskii <eliz@gnu.org>
5883
5884 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5885 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5886 when fetching a multibyte character consumes more bytes than
5887 CHAR_BYTES returns, due to unification of CJK characters in
5888 string_char. (Bug#11073)
5889
5063c0e1
TN
58902012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5891
5892 * process.c (wait_reading_process_output): Handle pty disconnect
5893 by refraining from sending oneself a SIGCHLD (bug#10933).
5894
9f851fbd
CY
58952012-03-22 Chong Yidong <cyd@gnu.org>
5896
5897 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5898
5063c0e1 5899 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5900 Mark string as coming from a prefix property.
5901 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5902 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5903
fb5b8aca
CY
59042012-03-21 Chong Yidong <cyd@gnu.org>
5905
5906 * xfaces.c (Vface_remapping_alist): Doc fix.
5907
62356a1b
EZ
59082012-03-20 Eli Zaretskii <eliz@gnu.org>
5909
5910 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5911 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5912 Doc fixes.
62356a1b 5913
025de85b
CY
59142012-03-20 Chong Yidong <cyd@gnu.org>
5915
5916 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5917 to reflect default non-nil value of redisplay-dont-pause.
5918
4827f94e
KH
59192012-03-19 Kenichi Handa <handa@m17n.org>
5920
5921 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5922 it fit in a valid range (Bug#11003).
5923
e50a24a2
EZ
59242012-03-18 Eli Zaretskii <eliz@gnu.org>
5925
5926 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5927 that is not from display property, accept the row as a "cursor
5928 row" if one of the string's character has a non-nil `cursor'
5929 property. Fixes cursor positioning when there are newlines in
5930 overlay strings, e.g. in icomplete.el. (Bug#11035)
5931
9af5ed87
PE
59322012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5933
5934 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5935
d1f55f16
CY
59362012-03-12 Chong Yidong <cyd@gnu.org>
5937
5938 * eval.c (inhibit_lisp_code): Rename from
5939 inhibit_window_configuration_change_hook; move from window.c.
5940
5941 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5942 * window.c (run_window_configuration_change_hook)
5943 (syms_of_window): Callers changed.
5944
66c5eebd
CY
59452012-03-11 Chong Yidong <cyd@gnu.org>
5946
413df973
CY
5947 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5948
66c5eebd
CY
5949 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5950
1de11f56
CY
59512012-03-10 Chong Yidong <cyd@gnu.org>
5952
5953 * frame.c (other_visible_frames): Don't assume the selected frame
5954 is visible (Bug#10955).
5955
cae07000
SM
59562012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5957
5958 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5959
89c94350
JD
59602012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5961
5962 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5963 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5964 zero (Bug#10954).
5965
999dd333
GM
59662012-03-03 Glenn Morris <rgm@gnu.org>
5967
01a6dcc8 5968 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5969
de0100f2
EZ
59702012-03-02 Eli Zaretskii <eliz@gnu.org>
5971
5972 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5973 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5974 (redisplay_window, next_element_from_string): Fix typos in
5975 comments.
3e441275
EZ
5976 (redisplay_window): Pass to move_it_vertically the margin in
5977 pixels, not in screen lines.
de0100f2 5978
96a72ee9
GM
59792012-03-02 Glenn Morris <rgm@gnu.org>
5980
5981 * buffer.c (buffer-list-update-hook): Doc fix.
5982
312508d7
EZ
59832012-02-29 Eli Zaretskii <eliz@gnu.org>
5984
5985 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5986 push_it before setting up the iterator for the first overlay
5987 string, even if we have an empty string loaded.
5988 (next_overlay_string): If there's an empty string on the iterator
5989 stack, pop the stack. (Bug#10903)
5990
27f3c637
PE
59912012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5992
5993 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5994 Suggested by Stefan Monnier in
5995 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5996 * alloc.c (widen_to_Lisp_Object): New static function.
5997 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5998 and widening them to Lisp_Objects. This would work even if
5999 USE_LSB_TAG is defined and wide integers are used, which might
6000 happen in a future version of Emacs.
6001
3c9dfce6
CY
60022012-02-25 Chong Yidong <cyd@gnu.org>
6003
fa74b241
CY
6004 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6005 Doc fix.
6006
3c9dfce6
CY
6007 * xselect.c (Fx_selection_exists_p): Doc fix.
6008 (x_clipboard_manager_save_all): Print an informative message
6009 before saving to clipboard manager.
6010
9486df08
CY
60112012-02-24 Chong Yidong <cyd@gnu.org>
6012
6013 * keyboard.c (process_special_events): Handle all X selection
6014 requests in kbd_buffer, not just the next one (Bug#8869).
6015
f01d3321
CY
60162012-02-23 Chong Yidong <cyd@gnu.org>
6017
6018 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6019 call when setting menu-bar-lines and tool-bar-lines parameters.
6020 (unwind_create_frame_1): New helper function.
6021
6022 * window.c (inhibit_window_configuration_change_hook): New var.
6023 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6024 (syms_of_window): Initialize it.
f01d3321 6025
86b847b6
CY
60262012-02-22 Chong Yidong <cyd@gnu.org>
6027
6028 * xterm.c (x_draw_image_relief): Add missing type check for
6029 Vtool_bar_button_margin (Bug#10743).
6030
a59225b1
CY
60312012-02-21 Chong Yidong <cyd@gnu.org>
6032
6033 * fileio.c (Vfile_name_handler_alist): Doc fix.
6034
6035 * buffer.c (Fget_file_buffer): Protect against invalid file
6036 handler return value.
6037
310f5bd4
PE
60382012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6039
cb3a28cc
PE
6040 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6041 when computing $valmask.
6042
310f5bd4
PE
6043 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6044 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6045 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6046 It's useless in that case, and it can cause problems on hosts
6047 that allocate halves of EMACS_INT values separately.
6048 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6049 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6050 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6051 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6052 it avoids undefined behavior on hosts where shifting right by more
6053 than the word width has undefined behavior.
6054
2375c96a
CY
60552012-02-19 Chong Yidong <cyd@gnu.org>
6056
6057 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6058 (Funhandled_file_name_directory, Ffile_name_as_directory)
6059 (Fdirectory_file_name, Fexpand_file_name)
6060 (Fsubstitute_in_file_name): Protect against invalid file handler
6061 return values (Bug#10845).
6062
3eb49e71
EZ
60632012-02-18 Eli Zaretskii <eliz@gnu.org>
6064
6065 * .gdbinit (pitx): Fix incorrect references to fields of the
6066 iterator stack.
6067
7b926f3f
CY
60682012-02-17 Chong Yidong <cyd@gnu.org>
6069
6070 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6071
11273115
PE
60722012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6073
6074 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6075 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6076
c3a70e2b
CY
60772012-02-15 Chong Yidong <cyd@gnu.org>
6078
6079 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6080 marked as special. Also, starting docstrings with * is obsolete.
6081
0ca43699
AS
60822012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6083
6084 * gnutls.c (emacs_gnutls_write): Fix last change.
6085
2e8f3c56
LI
60862012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6087
6088 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6089 send_process.
6090
af70074f
SM
60912012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6092
6093 * keymap.c (Fsingle_key_description): Handle char ranges.
6094
95986d52
CY
60952012-02-12 Chong Yidong <cyd@gnu.org>
6096
afd83bd1
CY
6097 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6098 as that creates a dangerous corner case.
6099
95986d52
CY
6100 * window.c (Fdelete_window_internal): Invalidate the mouse
6101 highlight (Bug#9904).
6102
bd7da63e
GM
61032012-02-12 Glenn Morris <rgm@gnu.org>
6104
6105 * xselect.c (Fx_own_selection_internal)
6106 (Fx_get_selection_internal, Fx_disown_selection_internal)
6107 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6108 * nsselect.m (Fx_own_selection_internal)
6109 (Fx_disown_selection_internal, Fx_selection_exists_p)
6110 (Fx_selection_owner_p, Fx_get_selection_internal):
6111 Sync docs and argument specs with the xselect.c versions.
6112
77abcbc2
LI
61132012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6114
6115 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6116
90b671e2
EZ
61172012-02-11 Eli Zaretskii <eliz@gnu.org>
6118
1c0ca0b7
EZ
6119 * w32select.c (Fx_selection_exists_p): Sync doc string and
6120 argument list with xselect.c. (Bug#10783)
6121
6122 * w16select.c (Fx_selection_exists_p): Sync doc string and
6123 argument list with xselect.c. (Bug#10783)
90b671e2 6124
49241268
GM
61252012-02-10 Glenn Morris <rgm@gnu.org>
6126
6127 * fns.c (Fsecure_hash): Doc fix.
6128
f998bbe7 61292012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6130
6131 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6132
0992bd9c
CY
61332012-02-07 Chong Yidong <cyd@gnu.org>
6134
6135 * buffer.c (Fbuffer_local_variables)
6136 (buffer_lisp_local_variables): Handle unbound vars correctly;
6137 don't let Qunbound leak into Lisp.
6138
af008560
GM
61392012-02-07 Glenn Morris <rgm@gnu.org>
6140
dd605cc4
GM
6141 * image.c (Fimagemagick_types): Doc fix.
6142
af008560
GM
6143 * image.c (imagemagick-render-type): Change it from a lisp object
6144 to an integer. Move the doc here from the lisp manual.
6145 Treat all values not equal to 0 the same.
6146
1449fa1d
CY
61472012-02-06 Chong Yidong <cyd@gnu.org>
6148
6149 * doc.c (store_function_docstring): Avoid applying docstring of
6150 alias to base function (Bug#2603).
6151
3723ec07
AS
61522012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6153
6154 * .gdbinit (pp1, pv1): Remove redundant defines.
6155 (pr): Use pp.
6156
79c1cc1e
CY
61572012-02-04 Chong Yidong <cyd@gnu.org>
6158
6159 * nsterm.m: Declare a global (Bug#10694).
6160
d7f29f8e
EZ
61612012-02-04 Eli Zaretskii <eliz@gnu.org>
6162
cae07000
SM
6163 * w32.c (get_emacs_configuration_options):
6164 Include --enable-checking, if specified, in the return value.
d7f29f8e 6165
3b95a6f9
MR
61662012-02-04 Martin Rudalics <rudalics@gmx.at>
6167
6168 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6169 after rounding frame sizes. (Bug#9723)
6170
d6fa96a6
EZ
61712012-02-04 Eli Zaretskii <eliz@gnu.org>
6172
6173 * keyboard.c (adjust_point_for_property): Don't position point
6174 before BEGV. (Bug#10696)
6175
df0b2940
PE
61762012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6177
6178 Handle overflow when computing char display width (Bug#9496).
6179 * character.c (char_width): Return EMACS_INT, not int.
6180 (char_width, c_string_width): Check for overflow when
6181 computing the width; this is possible now that individual
6182 characters can have unbounded width. Problem introduced
6183 by merge from Emacs 23 on 2012-01-19.
6184
6bee44d6
MA
61852012-02-02 Michael Albinus <michael.albinus@gmx.de>
6186
6187 * dbusbind.c (Fdbus_register_method): Mention the return value
6188 :ignore in the docstring.
6189
44f92739
GM
61902012-02-02 Glenn Morris <rgm@gnu.org>
6191
1b9f60cc
GM
6192 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6193
44f92739
GM
6194 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6195 Unconditionally set to t. (Bug#10673)
6196 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6197 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6198 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6199
c5d3843c
KH
62002012-02-02 Kenichi Handa <handa@m17n.org>
6201
6202 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6203 0, do not call append_composite_glyph.
6204
159462d4 62052012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6206
6207 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6208 NULL (Bug#6988).
6209 (x_produce_glyphs): If the component of a composition is a null
6210 string, set it->pixel_width to 1 to avoid zero-width glyph.
6211
78cef877
EZ
62122012-02-01 Eli Zaretskii <eliz@gnu.org>
6213
6214 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6215 first 2 arguments are identical. This makes inserting large
6216 output from a subprocess an order of magnitude faster on
6217 MS-Windows, where all sbrk'ed memory is always contiguous.
6218
97897668
GM
62192012-01-31 Glenn Morris <rgm@gnu.org>
6220
6221 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6222 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6223 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6224
31fd3586
GM
62252012-01-29 Glenn Morris <rgm@gnu.org>
6226
6227 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6228
0e24a8b2
CY
62292012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6230
6231 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6232
cc0adcb0
CY
62332012-01-28 Chong Yidong <cyd@gnu.org>
6234
6235 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6236
acc28cb9
CY
62372012-01-26 Chong Yidong <cyd@gnu.org>
6238
9c69cfb7
CY
6239 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6240
acc28cb9
CY
6241 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6242 repeat counts (Bug#10507).
6243
48da7392
GM
62442012-01-26 Glenn Morris <rgm@gnu.org>
6245
6246 * lread.c (syms_of_lread): Doc fix.
6247
14af5f7f
CY
62482012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6249
6250 * coding.c (encode_designation_at_bol): Change return value to
6251 EMACS_INT.
6252
0b21c100
CY
62532012-01-25 Chong Yidong <cyd@gnu.org>
6254
6255 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6256
3c2907f7
CY
62572012-01-21 Chong Yidong <cyd@gnu.org>
6258
6259 * floatfns.c (Fcopysign): Make the second argument non-optional,
6260 since nil is not allowed anyway.
6261
959ad23f
AS
62622012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6263
6264 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6265 (send_process): Likewise.
6266
34a02f46
MR
62672012-01-19 Martin Rudalics <rudalics@gmx.at>
6268
6269 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6270 (Vwindow_persistent_parameters): Do not use Qstate.
6271 Rewrite doc-strings.
34a02f46 6272
1259009a 62732012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6274
6275 * character.c (char_width): New function.
70d4fdf6
GM
6276 (Fchar_width, c_string_width, lisp_string_width):
6277 Use char_width (Bug#9496).
25ed9e61 6278
6a6ee00d
MR
62792012-01-16 Martin Rudalics <rudalics@gmx.at>
6280
6281 * window.c (Vwindow_persistent_parameters): New variable.
6282 (Fset_window_configuration, save_window_save): Handle persistent
6283 window parameters.
6284
c85efaf7
EZ
62852012-01-14 Eli Zaretskii <eliz@gnu.org>
6286
6287 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6288 thrashing the stack of the thread. (Bug#9087)
6289
5944709e
PE
62902012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6291
6292 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6293
e71f5d99
EZ
62942012-01-11 Eli Zaretskii <eliz@gnu.org>
6295
6296 * xdisp.c (rows_from_pos_range): Handle the case where the
6297 highlight ends on a newline. (Bug#10464)
6298 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6299 he end column for display of highlight that ends on a newline
6300 before a R2L line.
6301
ce316182
GM
63022012-01-11 Glenn Morris <rgm@gnu.org>
6303
6304 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6305 from load-path also when installation-directory is nil. (Bug#10208)
6306
5b43da69
GM
63072012-01-10 Glenn Morris <rgm@gnu.org>
6308
74cc8ff9
GM
6309 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6310
7d8d6e4e
GM
6311 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6312 Update template values to be closer to their typical values these days.
5b43da69 6313
a0db8d43
EZ
63142012-01-09 Eli Zaretskii <eliz@gnu.org>
6315
6316 * xdisp.c (rows_from_pos_range): Accept additional argument
6317 DISP_STRING, and accept any glyph in a row whose object is that
6318 string as eligible for mouse highlight. Fixes mouse highlight of
6319 display strings from overlays. (Bug#10464)
6320
9a0115ab 63212012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6322
b9110d6a 6323 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6324 * fileio.c (auto_saving_dir_umask): New static var.
6325 (Fmake_directory_internal): Use it.
6326 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6327 creating the directory. The old code temporarily assigns
6328 too-generous permissions to the directory.
6329 (do_auto_save_eh): Clear it.
b9110d6a 6330 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6331 that the var is always cleared.
6332
6c1bd3f3
EZ
63332012-01-07 Eli Zaretskii <eliz@gnu.org>
6334
6335 * search.c (scan_buffer): Pass character positions to
6336 know_region_cache, not byte positions. (Bug#6540)
6337
069d2b50
L
63382012-01-07 LynX <_LynX@bk.ru> (tiny change)
6339
6340 * w32.c (sys_rename): Report EXDEV when rename of a directory
6341 fails because the target is on another logical disk. (Bug#10284)
6342
75bf0d33
DB
63432012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6344
6345 * xterm.c (x_embed_request_focus): New function.
6346
6347 * xterm.h: Add prototype.
6348
6349 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6350
1c6e5a32
GM
63512012-01-05 Glenn Morris <rgm@gnu.org>
6352
6353 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6354
651e947e
EZ
63552012-01-01 Eli Zaretskii <eliz@gnu.org>
6356
6357 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6358 Load gnutls_transport_set_lowat only if GnuTLS version is below
6359 2.11.1.
6360 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6361 GnuTLS versions below 2.11.1.
6362
3778cdd8
AL
63632011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6364
6365 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6366 to the doc string advising against its use for altering the way
6367 windows are scrolled.
6368
0e5317f7
KH
63692011-12-28 Kenichi Handa <handa@m17n.org>
6370
6371 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6372 coding-system ASCII compatible only when it does not produce BOM
6373 on encoding (Bug#10383).
6374
93d5ca1f
JD
63752011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6376
6377 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6378 can scroll.
6379 (create_and_show_popup_menu): Always use menu_position_func for
6380 Gtk3 (Bug#10361).
6381
ca22b785
AS
63822011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6383
6384 * callint.c (Fcall_interactively): Don't truncate prompt string.
6385
d048e1e6
EZ
63862011-12-23 Eli Zaretskii <eliz@gnu.org>
6387
6388 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6389 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6390 resumed from there (after widening). (Bug#10360)
d048e1e6 6391
5ccaba1f
JD
63922011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6393
6394 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6395
204ee57f
JD
63962011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6397
b81d40f0
JB
6398 * nsterm.m (x_free_frame_resources):
6399 Release f->output_data.ns->miniimage.
204ee57f
JD
6400 (ns_index_color): Fix indentation. Do not retain
6401 color_table->colors[i].
6402
6403 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6404 before returning.
6405
6406 * nsfns.m (x_set_background_color): Assign return value from
6407 ns_index_color to face-background instead of NSColor*.
6408 (ns_implicitly_set_icon_type): Fix indentation.
6409 Change assignment in for loop to comparison.
6410
6411 * emacs.c (ns_pool): New variable.
6412 (main): Assign ns_pool.
6413 (Fkill_emacs): Call ns_release_autorelease_pool.
6414
6415 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6416 autorelease fdesc, release fdAttrs and tdict.
6417 (ns_get_covering_families): Release charset.
6418 (ns_findfonts): Release NSFontDescriptor created with new.
6419 (ns_uni_to_glyphs): Fix indentation.
6420 (setString): Release attrStr before assigning new value.
6421
c803b2b7
JD
64222011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6423
678f4426
JD
6424 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6425 and NS_IMPL_COCOA.
6426 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6427 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6428
cd394be1 64292011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6430
5fecd5fc
JD
6431 * nsterm.m (ns_term_init): Subscribe for notifications
6432 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6433 to method trackingNotification in EmacsMenu.
6434
6435 * nsmenu.m (trackingMenu): New variable.
3771cb17 6436 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6437 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6438 from Aquamacs (Bug#7030).
678f4426
JD
6439
64402011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6441
c803b2b7
JD
6442 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6443 (symbol_to_nsstring): Fix indentation.
6444 (ns_symbol_to_pb): New function.
cae07000
SM
6445 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6446 (Fns_rotate_cut_buffers_internal): Remove.
6447 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6448 Fns_store_cut_buffer_internal.
6449 (ns_get_foreign_selection, Fx_own_selection_internal)
6450 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6451 (Fns_get_selection_internal, Fns_store_selection_internal):
6452 Use ns_symbol_to_pb and check if return value is nil.
6453 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6454 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6455 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6456 renamed to Sns_store_selection_internal.
6457 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6458 and remove this function.
6459 (ns_handle_selection_clear): Remove, never used.
6460 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6461 here.
6462
e1b01a3a
KB
64632011-12-17 Ken Brown <kbrown@cornell.edu>
6464
6465 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6466 GID is unknown (Bug#10257).
6467
2adb6e85
PE
64682011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6469
6470 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6471 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6472 which caused a build failure on GNU/Linux IA-64. This problem was
6473 introduced by my 2011-10-07 patch.
6474
d1d7b339
JL
64752011-12-15 Juri Linkov <juri@jurta.org>
6476
6477 * image.c (imagemagick_error): New function. (Bug#10112)
6478 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6479 Use `imagemagick_error' where ImageMagick functions return
6480 `MagickFalse'.
6481 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6482 proper order.
6483
100d5755
KH
64842011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6485
6486 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6487 fill background (Bug#8992).
6488
454592a6
MR
64892011-12-13 Martin Rudalics <rudalics@gmx.at>
6490
6491 * window.c (Vwindow_combination_resize)
6492 (Vwindow_combination_limit): Use t instead of non-nil in
6493 doc-strings.
61d4b438
MR
6494 (Vrecenter_redisplay): Add first sentence of doc-string on
6495 separate line.
53524d93 6496 (Frecenter): Fix doc-string typo.
454592a6 6497
3633e3aa
KH
64982011-12-11 Kenichi Handa <handa@m17n.org>
6499
6500 * coding.c (Funencodable_char_position): Pay attention to the
6501 buffer text relocation (Bug#9389).
6502
7b9d523a 65032011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6504
7b9d523a
JD
6505 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6506 gtk_init (Bug#10100).
6507
b73189c6
EZ
65082011-12-10 Eli Zaretskii <eliz@gnu.org>
6509
6510 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6511 IT->string is nil. (Bug#10263)
6512
f7dfe5d6
JD
65132011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6514
83faebb4
JD
6515 * nsterm.h (x_free_frame_resources): Declare.
6516
f7dfe5d6
JD
6517 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6518 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6519
6520 * nsterm.h (ns_get_defaults_value): Declare.
6521
6522 * nsterm.m (ns_default): Call ns_get_defaults_value.
6523
7cd4e72c
EZ
65242011-12-09 Eli Zaretskii <eliz@gnu.org>
6525
6526 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6527 (Bug#10170)
6528
b34d7317
YM
65292011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6530
6531 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6532 that where the value of an _OBJC_* symbol points to is in the .bss
6533 section (Bug#10240).
6534
76470ad1
KH
65352011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6536
6537 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6538 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6539
745fff94
KH
65402011-12-08 Kenichi Handa <handa@m17n.org>
6541
6542 * ftfont.c (get_adstyle_property): Fix previous change
6543 (Bug#10233).
6544
6e44397c
JB
65452011-12-07 Juanma Barranquero <lekktu@gmail.com>
6546
6547 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6548 dirs from the default value of EMACSLOADPATH (bug#10208).
6549
7efa6272
GM
65502011-12-07 Glenn Morris <rgm@gnu.org>
6551
6552 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6553 installation and source directories as well. (Bug#10208)
6554
f6fc4d87
CY
65552011-12-06 Chong Yidong <cyd@gnu.org>
6556
6557 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6558
2bf26180
GM
65592011-12-06 Glenn Morris <rgm@gnu.org>
6560
6561 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6562 as an error, not just -1. (Bug#10217)
6563
3a6ad4f0
CY
65642011-12-05 Chong Yidong <cyd@gnu.org>
6565
6566 * keyboard.c (process_special_events): New function.
6567 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6568
75a3b399
PE
65692011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6570
6571 * coding.c (encode_designation_at_bol): Don't use uninitialized
6572 local variable (Bug#9318).
6573
c3c9e25e
KH
65742011-12-05 Kenichi Handa <handa@m17n.org>
6575
6576 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6577 return Qnil (Bug#8046, Bug#10193).
6578
5eb05ea3
KH
65792011-12-05 Kenichi Handa <handa@m17n.org>
6580
6581 * coding.c (encode_designation_at_bol): New args charbuf_end and
6582 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6583 (coding_set_source): Return how many bytes coding->source was
6584 relocated.
6585 (coding_set_destination): Return how many bytes
6586 coding->destination was relocated.
6587 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6588 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6589
65902011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6591
6592 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6593 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6594 macro (Bug#9318).
6595
65962011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6597
6598 The following changes are to fix Bug#9318.
6599
a79703f5 6600 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6601 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6602 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6603 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6604
7dbda6df
JB
66052011-12-05 Juanma Barranquero <lekktu@gmail.com>
6606
6607 * lisp.h (process_quit_flag): Fix external declaration.
6608
6d5eb5b0
SM
66092011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6610
6611 Don't macro-inline non-performance-critical code.
6612 * eval.c (process_quit_flag): New function.
6613 * lisp.h (QUIT): Use it.
6614
a0c3fad0
JD
66152011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6616
6617 * nsfns.m (get_geometry_from_preferences): New function.
6618 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6619
6c07aac2
AS
66202011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6621
6622 * emacs.c (Qkill_emacs): Define.
6623 (syms_of_emacs): Initialize it.
6624 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6625 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6626 (quit_throw_to_read_char): Add parameter `from_signal'.
6627 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6628 * lisp.h (QUIT): Call Fkill_emacs if requested.
6629
c052ead4
JD
66302011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6631
6632 * widget.c (update_wm_hints): Return if wmshell is null.
6633 (widget_update_wm_size_hints): New function.
6634
6635 * widget.h (widget_update_wm_size_hints): Declare.
6636
6637 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6638 widget_update_wm_size_hints (Bug#10104).
6639
9e49252b
EZ
66402011-12-03 Eli Zaretskii <eliz@gnu.org>
6641
6642 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6643 before a newline, prepare the bidi iterator for consuming the
6644 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6645 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6646
02b16839
JL
66472011-12-02 Juri Linkov <juri@jurta.org>
6648
6649 * search.c (Fword_search_regexp): New Lisp function created from
6650 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6651 (Fword_search_backward, Fword_search_forward)
6652 (Fword_search_backward_lax, Fword_search_forward_lax):
6653 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6654 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6655
0068070e
SM
66562011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6657
6658 * fileio.c (Finsert_file_contents): Move after-change-function call
6659 to before the "handled:" label, since all "goto handled" appear in
6660 cases where the *-change-functions have already been properly called
6661 (bug#10117).
6662
3360a3fc
AS
66632011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6664
6665 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6666 waiting for input. (Bug#10169)
6667
73d6c093
EZ
66682011-11-30 Eli Zaretskii <eliz@gnu.org>
6669
6670 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6671 verifies glyph row's hash code--we have just reallocated the
6672 glyphs, so their contents can be complete garbage. (Bug#10164)
6673
febe6bea
JB
66742011-11-30 Juanma Barranquero <lekktu@gmail.com>
6675
6676 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6677
801a4313
EZ
66782011-11-30 Eli Zaretskii <eliz@gnu.org>
6679
6680 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6681 attributes are tested _before_ calling verify_row_hash, to protect
6682 against GCC re-ordering of the tests. (Bug#10164)
6683
2b56b87e
JD
66842011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6685
6686 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6687
6688 * xterm.c (handle_one_xevent): Only set async_visible and friends
6689 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6690 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6691 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6692
dbf31225
PE
66932011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6694
6695 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6696 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6697 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6698 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6699 All uses changed to use GCPRO1 etc.
6700 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6701 Revert to old implementation (i.e., before 2011-03-11).
6702
1305621b
YM
67032011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6704
6705 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6706 of scroll runs so as to avoid assigning disabled bogus rows and
6707 unnecessary graphics copy operations.
6708
8c9afb46
EZ
67092011-11-27 Eli Zaretskii <eliz@gnu.org>
6710
6711 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6712 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6713 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6714 (malloc, free, realloc, calloc): Redirect to e_* only when
6715 compiling Emacs.
6716
6717 * lisp.h (GCTYPEBITS): Move before first use.
6718 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6719 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6720 this macro definition.
6721
6722 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6723 _MSC_VER.
6724
54e9e3bf
JD
67252011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6726
6d5eb5b0
SM
6727 * gtkutil.c (xg_create_frame_widgets):
6728 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6729 present with Gtk+ 2.0.
6730
83aca1cb
PE
67312011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6732
6733 * fileio.c (Finsert_file_contents): Undo previous change; see
6734 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6735
5b76caa4
PE
67362011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6737
6738 Rename locals to avoid shadowing.
6739 * fileio.c (Finsert_file_contents):
6740 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6741 * process.c (wait_reading_process_output):
6742 Rename inner 'proc' to 'p' to avoid shadowing.
6743 Indent for consistency with usual Emacs style.
6744
8c535114
EZ
67452011-11-25 Eli Zaretskii <eliz@gnu.org>
6746
6747 * xdisp.c (redisplay_window): If cursor row is not fully visible
6748 after recentering, and scroll-conservatively is set to a large
6749 number, scroll window by a few more lines to make the cursor fully
6750 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6751 (start_display): Don't move to the next line if the display should
6752 start at a newline that is part of a display vector or an overlay
6753 string. (Bug#10119)
8c535114 6754
fa4fdb5c
JL
67552011-11-24 Juri Linkov <juri@jurta.org>
6756
6757 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6758 after the `MagickPingImage' call. (Bug#10112)
6759
90ec88df
CY
67602011-11-23 Chong Yidong <cyd@gnu.org>
6761
6762 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6763
56e2e794
MR
67642011-11-23 Martin Rudalics <rudalics@gmx.at>
6765
6766 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6767 making another buffer current. (Bug#10114)
6768
b6e64c41
GM
67692011-11-23 Glenn Morris <rgm@gnu.org>
6770
6771 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6772
6b21de18
CY
67732011-11-23 Chong Yidong <cyd@gnu.org>
6774
6775 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6776 using it (Bug#5984).
6777
b12cd789
EZ
67782011-11-22 Eli Zaretskii <eliz@gnu.org>
6779
6780 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6781 and header-lines, as they don't have one computed for them.
6782 (Bug#10098)
6783
6784 * .gdbinit (prow): Make displayed values more self-explaining.
6785 Add row's hash code.
6786
261b6fd4
LMI
67872011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6788
6789 * process.c (wait_reading_process_output): Fix asynchrounous
6790 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6791 (wait_reading_process_output): Add comment and URL.
261b6fd4 6792
e7cfd277
JD
67932011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6794
6795 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6796
a9b9b7f5
CY
67972011-11-21 Chong Yidong <cyd@gnu.org>
6798
6799 * window.c (Fnext_window, Fprevious_window): Doc fix.
6800
b0d15b4f
SM
68012011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6802
6803 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6804
fe7a3057
JB
68052011-11-20 Juanma Barranquero <lekktu@gmail.com>
6806
6807 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6808
d2999b1a
MR
68092011-11-20 Martin Rudalics <rudalics@gmx.at>
6810
6811 * window.c (Fset_window_combination_limit): Rename argument
6812 STATUS to LIMIT.
6813 (Vwindow_combination_limit): Remove "status" from doc-string.
6814
d5ff9cd0
AS
68152011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6816
6817 * m/ibms390.h: Remove.
6818 * m/ibms390x.h: Don't include "ibms390.h".
6819
a5bb9bd3
SM
68202011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6821
6822 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6823 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6824
cd1181db
JB
68252011-11-20 Juanma Barranquero <lekktu@gmail.com>
6826
6827 * casetab.c (Fset_case_table):
6828 * charset.c (Fcharset_after): Fix typos.
6829
615a3b8d 68302011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6831
17e845af
PE
6832 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6833 Otherwise, valgrind does not work on some platforms.
6834 Problem reported by Andreas Schwab in
6a0bf43d
PE
6835 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6836 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6837 is set, removing the need for VIRT_ADDRESS_VARIES.
6838 (PURE_P): Use a more-efficient implementation that needs just one
6839 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6840 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6841 to 4 (xorl, subq, cmpq, setbe).
6842 * alloc.c (pure): Always extern now, since that's the
6843 VIRT_ADDR_VARIES behavior.
6844 (PURE_POINTER_P): Use a single comparison, not two, for
6845 consistency with the new puresize.h.
6846 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6847 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6848 Remove VIRT_ADDR_VARIES no longer needed.
6849
f8fe6f96
EZ
68502011-11-19 Eli Zaretskii <eliz@gnu.org>
6851
6852 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6853 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6854 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6855 behave as if the cursor position were at the window margin.
6856
6857 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6858 and the cursor position is out of bounds, behave as if the cursor
6859 position were at the window margin. (Bug#10075)
6860
df05a53c
CY
68612011-11-18 Chong Yidong <cyd@gnu.org>
6862
6863 * window.c (Fwindow_combination_limit): Make first argument
6864 non-optional, since it is meaningless for live windows like the
6865 selected window.
61ccba97 6866
2071918e
DA
68672011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6868
6869 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6870
b50a28de
SM
68712011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6872
6873 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6874 (graft_intervals_into_buffer): Simplify.
6875
015137db
EZ
68762011-11-18 Eli Zaretskii <eliz@gnu.org>
6877
6878 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6879 hash values of the two rows.
6880 (copy_row_except_pointers): Preserve the used[] arrays and the
6881 hash values of the two rows. (Bug#10035)
68c95424 6882 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6883
6884 * xdisp.c (row_hash): New function, body extracted from
6885 compute_line_metrics.
6886 (compute_line_metrics): Call row_hash, instead of computing the
6887 hash code inline.
6888
6889 * dispnew.c (verify_row_hash): Call row_hash for computing the
6890 hash code of a row, instead of duplicating code from xdisp.c.
6891
6892 * dispextern.h (row_hash): Add prototype.
6893
a2addb04
TH
68942011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6895
6896 * frame.c (delete_frame): Don't delete the terminal when the last
6897 X frame is closed if emacs is built with GTK toolkit.
6898
df85d315
JB
68992011-11-17 Juanma Barranquero <lekktu@gmail.com>
6900
6901 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6902
a0c2d0ae
MR
69032011-11-17 Martin Rudalics <rudalics@gmx.at>
6904
6905 * window.c (Vwindow_splits): Rename to
6906 Vwindow_combination_resize. Suggested by Juri Linkov.
6907 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6908 of Vwindow_splits.
6909
58179cce
JB
69102011-11-16 Juanma Barranquero <lekktu@gmail.com>
6911
7877f373
JB
6912 * nsfns.m (Fns_font_name):
6913 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6914
b6f67890
MR
69152011-11-16 Martin Rudalics <rudalics@gmx.at>
6916
6917 * window.h (window): Rename slot "nest" to "combination_limit".
6918 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6919 (Fset_window_nest): Rename to Fset_window_combination_limit.
6920 (Vwindow_nest): Rename to Vwindow_combination_limit.
6921 (recombine_windows, make_parent_window, make_window)
6922 (Fsplit_window_internal, saved_window)
6923 (Fset_window_configuration, save_window_save): Rename all
6924 occurrences of window_nest to window_combination_limit.
6925
c7015153
JB
69262011-11-15 Juanma Barranquero <lekktu@gmail.com>
6927
6928 * image.c (imagemagick_load_image): Fix typo.
6929
322ad6ec
EZ
69302011-11-14 Eli Zaretskii <eliz@gnu.org>
6931
6932 * xdisp.c (display_line): Move the call to
6933 highlight_trailing_whitespace before the call to
6934 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6935 faces of all the glyphs to compute ROW's hash value.
6936 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6937
f067b8ec
JB
69382011-11-14 Juanma Barranquero <lekktu@gmail.com>
6939
6940 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6941 just return (bug#10044).
6942
1e5b2111
EZ
69432011-11-12 Eli Zaretskii <eliz@gnu.org>
6944
7ef3cbd5
EZ
6945 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6946 with user-defined heap size. Bump the default size of the temacs
6947 heap to 27MB, to avoid memory warning when running temacs.
6948 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6949
1e5b2111
EZ
6950 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6951 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6952 (verify_row_hash) [XASSERTS]: New function.
6953 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6954 that the hash value of glyph rows is correct.
1e5b2111 6955
89d61221
MR
69562011-11-12 Martin Rudalics <rudalics@gmx.at>
6957
6958 * window.h (window): Remove splits slot.
6959 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6960 (Fdelete_other_windows_internal, make_parent_window)
6961 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6962 (Fset_window_configuration, save_window_save): Don't deal with
6963 split status of windows.
6964 (saved_window): Remove splits slot.
6965 (Vwindow_splits): Rewrite doc-string.
6966
97f18cc8
JD
69672011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6968
6969 * xfns.c (unwind_create_frame):
6970 * nsfns.m (unwind_create_frame):
6971 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6972 Vframe_list (Bug#9999).
6973
22a648b4
DA
69742011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6975
0b381c7e 6976 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6977
659afede
KH
69782011-11-11 Kenichi Handa <handa@m17n.org>
6979
6980 * callproc.c (Fcall_process): Set the member dst_multibyte of
6981 process_coding.
6982
9ac0394b
KH
69832011-11-11 Johan Bockgård <bojohan@gnu.org>
6984
6985 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6986 avoid a crash (bug#9496).
6987
2fbdc249
CY
69882011-11-09 Chong Yidong <cyd@gnu.org>
6989
6990 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6991 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6992
ac6b1f81
PE
69932011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6994
6995 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6996
09db192c
PE
69972011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6998
6999 Avoid some portability problems by eschewing 'extern inline' functions.
7000 The trivial performance wins aren't worth the portability hassles; see
7001 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
7002 et seq.
7003 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7004 (window_box_width, window_box_left, window_box_left_offset)
7005 (window_box_right, window_box_right_offset): Undo previous change,
7006 by removing the "extern"s.
7007 * intervals.c (adjust_intervals_for_insertion)
7008 (adjust_intervals_for_deletion): Undo previous change,
7009 making these static again.
7010 (offset_intervals, temp_set_point_both, temp_set_point)
7011 (copy_intervals_to_string): No longer inline.
7012 * xdisp.c (window_text_bottom_y, window_box_width)
7013 (window_box_height, window_box_left_offset)
7014 (window_box_right_offset, window_box_left, window_box_right)
7015 (window_box): No longer inline.
7016
105216ed
CY
70172011-11-08 Chong Yidong <cyd@gnu.org>
7018
7019 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7020 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7021 Signal an error if not a live window.
105216ed
CY
7022 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7023 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7024
ae9e237f
JB
70252011-11-07 Juanma Barranquero <lekktu@gmail.com>
7026
7027 * lisp.h (syms_of_abbrev): Remove declaration.
7028 Reported by CHENG Gao <chenggao@royau.me>.
7029
c7aa8333
EZ
70302011-11-07 Eli Zaretskii <eliz@gnu.org>
7031
7032 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7033 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7034 of temacs in GUI mode.
7035
be7f5545
MR
70362011-11-07 Martin Rudalics <rudalics@gmx.at>
7037
7038 * window.h: Declare delete_all_child_windows instead of
7039 delete_all_subwindows.
7040 * window.c (Fwindow_nest, Fset_window_nest)
7041 (Fset_window_new_total, Fset_window_new_normal)
7042 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7043 (delete_all_subwindows): Rename to delete_all_child_windows.
7044 (Fdelete_other_windows_internal, Fset_window_configuration):
7045 Call delete_all_child_windows instead of delete_all_subwindows.
7046 * frame.c (delete_frame): Call delete_all_child_windows instead
7047 of delete_all_subwindows.
7048
ca78dc43
PE
70492011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7050
7051 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7052 This is also needed for porting to any host where GC_MARK_STACK is
7053 not GC_MAKE_GCPROS_NOOPS.
7054 (which_symbols): Use it.
7055
a0241d01
KH
70562011-11-07 Kenichi Handa <handa@m17n.org>
7057
7058 * coding.c (coding_set_destination): Check coding->src_pos only
7059 when coding->src_object is a buffer (bug#9910).
7060
7061 * process.c (send_process): Set the member src_multibyte of coding
7062 to 0 (bug#9911) when sending a unibyte text.
7063
7064 * callproc.c (Fcall_process): Set the member src_multibyte of
7065 process_coding to 0 (bug#9912).
7066
a64bfdfa 70672011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7068
7069 * xmenu.c (cleanup_widget_value_tree): New function.
7070 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7071 calling free_menubar_widget_value_tree directly (Bug#9830).
7072
cb41b32a
PE
70732011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7074
7075 Fix some portability problems with 'inline'.
7076 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7077 (window_box_width, window_box_left, window_box_left_offset)
7078 (window_box_right, window_box_right_offset): Declare extern.
7079 Otherwise, these inline functions do not conform to C99 and
7080 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7081 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7082 * intervals.c (adjust_intervals_for_insertion)
7083 (adjust_intervals_for_deletion): Now extern, because otherwise the
7084 extern inline functions 'offset_intervals' couldn't refer to it.
7085 (static_offset_intervals): Remove.
7086 (offset_intervals): Rewrite using the old contents of
7087 static_offset_intervals. The old version didn't conform to C99
7088 because an extern inline function contained a reference to an
7089 identifier with static linkage.
7090
b7041366
AS
70912011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7092
7093 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7094 GC.
7095
88a37c4d
EZ
70962011-11-06 Eli Zaretskii <eliz@gnu.org>
7097
7098 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7099 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7100 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7101 return Qleft_to_right.
7102
49745b39
CY
71032011-11-06 Chong Yidong <cyd@gnu.org>
7104
7105 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7106 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7107 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7108 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7109 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7110 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7111 (Fwindow_vscroll): Doc fix.
7112 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7113 argument, since it makes no sense to pass a live window and for
7114 consistency with window-child.
7115
1f05cd82
CS
71162011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7117
7118 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7119 support MSVC.
7120
22610910
JR
71212011-11-05 Jason Rumney <jasonr@gnu.org>
7122
7123 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7124 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7125 fonts (Bug#6029).
7126 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7127 bitwise arithmetic preventing use of unicode-sip and non-truetype
7128 opentype fonts.
7129
a06776b2
EZ
71302011-11-05 Eli Zaretskii <eliz@gnu.org>
7131
3ad924ba
EZ
7132 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7133 "emacs"-only part.
7134
a06776b2
EZ
7135 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7136 initialization code to keep similarity to xfns.c after changes
7137 from 2011-11-05.
7138
c9e7db78
JD
71392011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7140
a97f8f3f
JD
7141 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7142 (unwind_create_frame): New function (Bug#9943).
7143 (Fx_create_frame): Restructure code to be more similar to the one in
7144 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7145 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7146 Move terminal->reference_count++ just before making the frame official
7147 (Bug#9943).
7148
7149 * nsterm.m (x_free_frame_resources): New function.
7150 (x_destroy_window): Move code to x_free_frame_resources.
7151
c9e7db78 7152 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7153 (Fx_create_frame, x_create_tip_frame):
7154 Move terminal->reference_count++ just before making the frame
75f1671a 7155 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7156 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7157
a6fc3b5c
EZ
71582011-11-05 Eli Zaretskii <eliz@gnu.org>
7159
7160 Support MSVC build with newer versions of Visual Studio.
7161 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7162 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7163 nt/gmake.defs.
7164
7165 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7166 which are not supported by MSVC.
7167 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7168 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7169 bitfields.
7170 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7171 types in bitfields.
7172 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7173
7174 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7175
58179cce 71762011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7177
7178 Support MSVC build with newer versions of Visual Studio.
7179 * w32.c: Don't include w32api.h for MSVC.
7180 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7181
7182 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7183 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7184 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7185 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7186 e_* cousins.
7187 (alloca) [_MSC_VER]: Define to _alloca.
7188
7189 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7190
7191 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7192
a58c13ed
EZ
71932011-11-04 Eli Zaretskii <eliz@gnu.org>
7194
7195 * xdisp.c (note_mouse_highlight): If either of
7196 previous/next-single-property-change returns nil, treat that as
7197 the beginning or the end of the buffer. (Bug#9955)
7198
fe0b6370
JD
71992011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7200
a58c13ed 7201 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7202 label is not null (Bug#9951).
7203 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7204 may be NULL.
7205
89bd5ee1
EZ
72062011-11-04 Eli Zaretskii <eliz@gnu.org>
7207
7208 * window.c (Fwindow_body_size): Mention in the doc string that the
7209 return value is in frame's canonical units. (Bug#9949)
7210
84c3edb9
EZ
72112011-11-03 Eli Zaretskii <eliz@gnu.org>
7212
4e2fb5c7
EZ
7213 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7214
84c3edb9 7215 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7216 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7217 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7218
bc17a887
EZ
72192011-11-01 Eli Zaretskii <eliz@gnu.org>
7220
7221 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7222 Don't stop backward scan on the continuation glyph, even though
7223 its CHARPOS is positive.
6d5eb5b0
SM
7224 (mouse_face_from_buffer_pos, note_mouse_highlight):
7225 Rename cover_string to disp_string.
bc17a887 7226
4ee88440
MR
72272011-11-01 Martin Rudalics <rudalics@gmx.at>
7228
7229 * window.c (temp_output_buffer_show): Don't use
7230 Vtemp_buffer_show_specifiers.
7231 (Vtemp_buffer_show_specifiers): Remove unused variable.
7232
c2ff3c02
EZ
72332011-10-30 Eli Zaretskii <eliz@gnu.org>
7234
7235 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7236 past the beginning of the current glyph matrix.
7237
58179cce 72382011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7239
7240 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7241 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7242 HAVE_GTK3 (Bug#9869).
b77a6a7f 7243
3b574623
JD
7244 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7245 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7246
b77a6a7f
JD
7247 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7248
7249 * xterm.c: Declare x_handle_net_wm_state to return int.
7250 (handle_one_xevent): Check if we are iconified but don't have
7251 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7252 (get_current_wm_state): Return non-zero if not hidden,
7253 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7254 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7255 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7256 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7257
196e41e4
PE
72582011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7259
7260 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7261 so that this new function doesn't get optimized away by a
7262 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7263
021f2e1a
AS
72642011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7265
7266 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7267
8b058d44
EZ
72682011-10-29 Eli Zaretskii <eliz@gnu.org>
7269
7270 Fix the `xbytecode' command.
7271 * .gdbinit (xprintbytestr): New command.
b50a28de 7272 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7273 (xbytecode): Print the byte-code string as well.
7274
4452fb80
EZ
72752011-10-29 Kim Storm <storm@cua.dk>
7276
8b058d44
EZ
7277 * alloc.c (which_symbols): New function.
7278
21b72067
AS
72792011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7280
7281 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7282 line. (Bug#9903)
7283
83ed7b5c
GM
72842011-10-29 Glenn Morris <rgm@gnu.org>
7285
7286 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7287 Not clear what it was for, and it causes various bugs. (Bug#9839)
7288
5a7a728b
EZ
72892011-10-28 Eli Zaretskii <eliz@gnu.org>
7290
7291 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7292 possible random value that matches one of those tested as
7293 condition to clear the mouse face.
7294
d3d0842f
CY
72952011-10-28 Chong Yidong <cyd@gnu.org>
7296
7297 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7298
31b39d13
DN
72992011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7300
7301 * window.c (make_window): Initialize phys_cursor_on_p.
7302
9aba6043
SM
73032011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7304
7305 * lisp.h (struct Lisp_Symbol): Update comments.
7306
c20992f4
JB
73072011-10-28 Juanma Barranquero <lekktu@gmail.com>
7308
7309 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7310
db4f02f2
EZ
73112011-10-28 Eli Zaretskii <eliz@gnu.org>
7312
7313 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7314 <oslsachem@gmail.com> for helping to debug this.
7315
7316 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7317 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7318 (g_b_init_get_glyph_outline_w): New static variables.
7319 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7320 (GetGlyphOutlineW_Proc): New typedefs.
7321 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7322 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7323 New functions.
7324 (w32font_open_internal, compute_metrics):
7325 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7326 instead of calling the "wide" APIs directly.
7327
7328 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7329
7330 * w32.h (syms_of_w32font): Add prototype.
7331
87e68db4
JB
73322011-10-27 Juanma Barranquero <lekktu@gmail.com>
7333
7334 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7335 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7336 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7337 (Fmove_to_window_line): Doc fix.
7338
435c1d67
CY
73392011-10-27 Chong Yidong <cyd@gnu.org>
7340
7341 * process.c (make_process): Set gnutls_state to NULL.
7342
7343 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7344 non-NULL, regardless of GNUTLS_INITSTAGE.
7345 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7346 an error. Set process slots as soon as we allocate them.
7347
7348 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7349
9c6c6f49
CY
73502011-10-27 Chong Yidong <cyd@gnu.org>
7351
9aba6043
SM
7352 * gnutls.c (emacs_gnutls_deinit): New function.
7353 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7354 (Fgnutls_deinit, Fgnutls_boot): Use it.
7355
7356 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7357 (deactivate_process): Call emacs_gnutls_deinit.
7358
657d08d3
JB
73592011-10-27 Juanma Barranquero <lekktu@gmail.com>
7360
7361 * image.c (x_create_x_image_and_pixmap):
7362 * w32.c (sys_rename, w32_delayed_load):
7363 * w32font.c (fill_in_logfont):
7364 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7365
5430d399
JB
73662011-10-26 Juanma Barranquero <lekktu@gmail.com>
7367
7368 * w32fns.c (w32_default_color_map): New function,
7369 extracted from Fw32_default_color_map.
a7ef684b 7370 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7371
fe0055fa
PE
73722011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7373
7374 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7375
e6346438
SM
73762011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7377
7378 * keyboard.c (test_undefined): New function (bug#9751).
7379 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7380
e112cc37
ET
73812011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7382
7383 * sysdep.c (init_sys_modes): Fix the check for the controlling
7384 terminal (Bug#6649).
7385
7b5d6677
EZ
73862011-10-20 Eli Zaretskii <eliz@gnu.org>
7387
7388 * dispextern.h (struct bidi_it): New member next_en_type.
7389
7390 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7391 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7392 current character, check also for next_en_type being WEAK_EN.
7393 (bidi_resolve_weak): Don't enter the expensive loop if the current
7394 position is before next_en_pos. Record the bidi type of the first
7395 non-ET, non-BN character we find, in addition to its position.
7396 (bidi_level_of_next_char): Invalidate next_en_type when
7397 next_en_pos is over-stepped.
7398
7da0b018
PE
73992011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7400
7401 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7402 * editfns.c: Rewrite current-time-zone so that it invokes
7403 the equivalent of (format-time-string "%Z") to get the time zone name.
7404 This fixes a bug when the time zone name contains characters that
7405 need converting from the system time locale to Emacs internal format.
7406 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7407 that patch fixed format-time-string to do the conversion, but
7408 I forgot to fix current-time-zone.
7409 (format_time_string): New function, containing most of
7410 what Fformat_time_string used to contain.
7411 (Fformat_time_string): Rewrite in terms of format_time_string.
7412 This doesn't change this function's behavior.
7413 (current-time-zone): Rewrite to use format_time_string.
7414 This fixes the bug reported by Michael Schierl in
7415 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7416 Jason Rumney's 2007-06-07 change worked around this bug, but
7417 didn't fix it.
7418 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7419
8547b010
EZ
74202011-10-19 Eli Zaretskii <eliz@gnu.org>
7421
7422 * xdisp.c (start_display): If the character at POS is displayed
7423 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7424 (try_window_reusing_current_matrix): If a line ends in a display
7425 vector or the next line starts in a display vector, continue
7426 redrawing the window even though the character position of
7427 start_row was reached.
8547b010
EZ
7428 (Bug#9771, part 2)
7429
4e948d15
CY
74302011-10-18 Chong Yidong <cyd@gnu.org>
7431
7432 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7433 with nobreak-char-display too.
7434
4787455f
EZ
74352011-10-18 Eli Zaretskii <eliz@gnu.org>
7436
7437 Fix part 3 of bug#9771.
7438 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7439 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7440 non-neutral characters if the current character is a paragraph
7441 separator (a.k.a. Newline). This avoids running the same
7442 expensive loop twice, once when we consume the preceding newline
7443 and the other time when the line actually needs to be displayed.
7444 Avoid the loop when we see neutrals on the base embedding level
7445 following a character whose directionality is the same as the
7446 paragraph's. This avoids running the expensive loop when a line
7447 ends in a long sequence of neutrals, like control characters.
7448 Add assertion against STRONG_AL type. Slightly rearrange code
7449 that determines the type of a neutral given the first non-neutral
7450 that follows it.
7451 (bidi_level_of_next_char): Set next_en_pos to zero when
7452 invalidating its info.
7453
2c91f553
EZ
74542011-10-17 Eli Zaretskii <eliz@gnu.org>
7455
7456 * xdisp.c (push_display_prop): Determine whether to record string
7457 or buffer position by IT->string, not by IT->method. Allow
7458 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7459 (move_it_vertically_backward): Don't look for character position
7460 immediately after the newline when in a continuation line.
7461 (Bug#9771, part 1)
2c91f553 7462
c7b08b0d
MR
74632011-10-15 Martin Rudalics <rudalics@gmx.at>
7464
7465 * window.c (coordinates_in_window): Rewrite and delabelize
7466 vertical border check. (Bug#5357) (Bug#9618)
7467
6b02f655
SM
74682011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7469
7470 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7471 errors in XSetWindowBorder (bug#9310).
7472
81d40c92
DA
74732011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7474
7475 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7476 avoid crash when xmalloc overrun checking is enabled.
7477
d4172c3b
EZ
74782011-10-13 Eli Zaretskii <eliz@gnu.org>
7479
7480 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7481 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7482 cursor motion with <left> and <right> arrow keys.
7483
7484 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7485 some callers set that themselves.
7486
b00eea75
EZ
74872011-10-12 Eli Zaretskii <eliz@gnu.org>
7488
7489 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7490 display string and the previous row comes from the same string and
7491 is empty. (Bug#9739) (Bug#9738)
7492
8fe012c4
SM
74932011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7494
7495 * doc.c (get_doc_string): Encode file name (bug#9735).
7496
0074aef2
EZ
74972011-10-12 Eli Zaretskii <eliz@gnu.org>
7498
79beb178
EZ
7499 * bidi.c (bidi_level_of_next_char):
7500 * xdisp.c (get_visually_first_element): Remove old incorrect
7501 comments regarding the Unicode Line Separator character.
7502
0074aef2
EZ
7503 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7504
6e4b3fbe
DA
75052011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7506
7507 * alloc.c (Fgc_status): Do not access beyond zombies array
7508 boundary if nzombies > MAX_ZOMBIES.
7509 * alloc.c (dump_zombies): Add missing format specifier.
7510
0324f3af
PE
75112011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7512
b5525cac
PE
7513 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7514 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7515
0324f3af
PE
7516 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7517 Some packages use them to denote characters with modifiers.
7518
e9b5f888
AS
75192011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7520
7521 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7522 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7523 matching a pp-number. Rename parameter var to var1.
7524
127827c0
SM
75252011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7526
7527 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7528
c8fd3bd0
GM
75292011-10-08 Glenn Morris <rgm@gnu.org>
7530
7531 * callint.c (Fcall_interactively): Give a more explicit error for the
7532 'c' case with a non-character input. (Bug#8479)
7533
352ec8ff
EZ
75342011-10-08 Eli Zaretskii <eliz@gnu.org>
7535
03669ccb
EZ
7536 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7537 lines.
7061c986
EZ
7538 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7539 lines that are hscrolled on the left.
03669ccb 7540
352ec8ff
EZ
7541 * dispnew.c (buffer_posn_from_coords): Account for a possible
7542 presence of header-line. (Bug#4426)
7543
a66cfb1c
SM
75442011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7545
6b02f655
SM
7546 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7547 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7548
7c5ee88e
PE
75492011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7550
7551 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7552 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7553 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7554 this makes Emacs dump core during garbage collection on rare
7555 occasions. sizeof is obviously inferior to offsetof here, so
7556 stick with offsetof.
7557 (GC_POINTER_ALIGNMENT): New macro.
7558 (mark_memory): Omit 3rd (offset) arg; caller changed.
7559 Don't assume EMACS_INT alignment is the same as pointer alignment.
7560
df1bbe5b
SM
75612011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7562
7563 * keyboard.c (read_key_sequence_remapped): New var.
7564 (read_key_sequence): Compute remapping in the right buffer.
7565 (command_loop_1): Use read_key_sequence's remapping directly.
7566
51553db6
SM
75672011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7568
32c1fffd
SM
7569 * dired.c (file_name_completion): Don't expand file name.
7570 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7571 before checking file name handler.
7572
51553db6
SM
7573 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7574 they've been requested explicitly (bug#9591).
7575
b6bd1599 75762011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7577
7578 * keymap.c (Fsingle_key_description): Use make_specified_string
7579 instead of build_string to build string from push_key_description.
7580 (Bug#5193)
7581
f701dc2a
PE
75822011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7583
4222c55d
PE
7584 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7585 This fixes a Y2038 bug on 64-bit hosts.
7586 * buffer.c (reset_buffer):
7587 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7588 (Fclear_buffer_auto_save_failure):
7589 Use 0, not -1, to represent an unset failure time, since time_t
7590 might not be signed.
7591
f701dc2a
PE
7592 Remove dependency on glibc malloc internals.
7593 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7594 Move back here from lisp.h, but with their new implementations.
7595 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7596 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7597 * charset.c (charset_table_init): New static var.
7598 (syms_of_charset): Use it instead of xmalloc. This removes a
7599 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7600 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7601 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7602 Move back to alloc.c.
7603 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7604 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7605
9ceebf39
JD
76062011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7607
7608 * nsterm.m (windowDidResize): Call x_set_window_size only when
7609 ns_in_resize is true. Otherwise set pixelwidth/height and
7610 call change_frame_size (Bug#9628).
7611
cb993c58
PE
76122011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7613
3930c88b
PE
7614 Port --enable-checking=all to Fedora 14 x86-64.
7615 * charset.c (syms_of_charset): Also account for glibc malloc's
7616 internal overhead when calculating the initial malloc maximum.
7617
cb993c58
PE
7618 Port --enable-checking=all to Fedora 14 x86.
7619 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7620 Move to lisp.h.
7621 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7622 (overrun_check_realloc, overrun_check_free):
7623 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7624 That way, xmalloc returns a properly-aligned pointer even if
7625 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7626 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7627 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7628 into account when calculating the initial malloc maximum.
7629 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7630 Move here from alloc.c, so that charset.c can use it too.
7631 Properly align; the old code wasn't right for common 32-bit hosts
7632 when configured with --enable-checking=all.
7633 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7634 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7635
31bed486
EZ
76362011-09-29 Eli Zaretskii <eliz@gnu.org>
7637
04c70788 7638 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7639 use EDOM.
7640
fbcaa2f3
EZ
76412011-09-28 Eli Zaretskii <eliz@gnu.org>
7642
7643 * xdisp.c (compute_display_string_end): If there's no display
7644 string at CHARPOS, return -1.
7645
7646 * bidi.c (bidi_fetch_char): When compute_display_string_end
7647 returns a negative value, treat the character as a normal
7648 character not covered by a display string. (Bug#9624)
7649
a239d4e9
JB
76502011-09-28 Juanma Barranquero <lekktu@gmail.com>
7651
7652 * lread.c (Fread_from_string): Fix typo in docstring.
7653
88652fd5
EZ
76542011-09-27 Eli Zaretskii <eliz@gnu.org>
7655
7656 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7657 newline, reseat the iterator instead of bidi-iterating there one
7658 character at a time. (Bug#9610)
32c1fffd
SM
7659 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7660 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7661
ed497dd4
AS
76622011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7663
7664 * lread.c (readevalloop): Use correct code for NBSP.
7665 (read1): Likewise. (Bug#9608)
7666
b2bf61aa
MA
76672011-09-25 Michael Albinus <michael.albinus@gmx.de>
7668
7669 * dbusbind.c (Fdbus_register_signal): When service is not
7670 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7671
32bbb17c
GM
76722011-09-25 Glenn Morris <rgm@gnu.org>
7673
7674 * buffer.c (truncate-lines): Doc fix.
7675
94e0933e
CY
76762011-09-24 Chong Yidong <cyd@stupidchicken.com>
7677
7678 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7679 (Fset_window_next_buffers): Doc fix.
7680
cddde921
GM
76812011-09-24 Glenn Morris <rgm@gnu.org>
7682
7683 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7684
1260aef1
PE
76852011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7686
25b4bfa0
PE
7687 Fix minor problems found by static checking.
7688 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7689 * indent.c (Fvertical_motion): Fix == vs = typo.
7690
e3cbd34b
EZ
76912011-09-24 Eli Zaretskii <eliz@gnu.org>
7692
a66cfb1c
SM
7693 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7694 Default value is now t. Doc fix.
6bf7006f 7695
e3cbd34b 7696 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7697 logic when moving up, not only when moving down. Fix the
e3cbd34b 7698 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7699 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7700
7701 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7702 CHARPOS is covered by a display string which includes newlines.
7703 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7704 is covered by a display string with embedded newlines.
7705
a3de0cbd
MA
77062011-09-24 Michael Albinus <michael.albinus@gmx.de>
7707
7708 * dbusbind.c (Fdbus_register_signal): Add match rule to
7709 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7710 (Fdbus_register_method, Vdbus_registered_objects_table):
7711 Fix docstring.
a3de0cbd 7712
b260039d
JM
77132011-09-24 Jim Meyering <meyering@redhat.com>
7714
32c1fffd 7715 do not ignore write error for any output size
b260039d
JM
7716 The previous change was incomplete.
7717 While it makes emacs --batch detect the vast majority of stdout
7718 write failures, errors were still ignored whenever the output size is
7719 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7720 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7721 && echo FAIL: ignored write error
7722 FAIL: ignored write error
7723 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7724 && echo FAIL: ignored write error
7725 FAIL: ignored write error
7726 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7727
8eca8a7c
AS
77282011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7729
7730 * emacs.c (Fkill_emacs): In noninteractive mode exit
7731 non-successfully if a write error occurred on stdout. (Bug#9574)
7732
3341db62
EZ
77332011-09-21 Eli Zaretskii <eliz@gnu.org>
7734
7735 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7736 the xassert test.
7737
7738 * dispextern.h (struct it): Update the comment documenting what
7739 can it->OBJECT be.
7740
8c203dbf
EZ
77412011-09-20 Eli Zaretskii <eliz@gnu.org>
7742
7743 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7744 a display string, extend search for cursor position to end of row.
7745 (find_row_edges): If the row ends in a newline from a display
7746 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7747 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7748 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7749 non-empty line. Fixes confusing cursor motion with arrow keys at
7750 the beginning of a line that starts with whitespace.
8c203dbf 7751
a4824228
LMI
77522011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7753
7754 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7755 (bug#9493).
7756
33ed493b
CY
77572011-09-18 Chong Yidong <cyd@stupidchicken.com>
7758
7759 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7760 boolean (Bug#9154).
7761
56cd55c8
EZ
77622011-09-18 Eli Zaretskii <eliz@gnu.org>
7763
7764 * xdisp.c (display_line): Record maximum and minimum buffer
7765 positions even if no glyphs were produced (e.g., by a zero-width
7766 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7767 buffer positions that will be removed from the glyph row because
7768 they don't fit.
c02dcedf
EZ
7769 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7770 column is beyond frame width: don't subtract 1 "pixel" when
7771 computing width of the stretch.
3e62b7e0
EZ
7772 (reseat_at_next_visible_line_start): Undo the change made on
7773 2011-09-17 that saved paragraph information and restored it after
7774 the call to `reseat'. (Bug#9545)
56cd55c8 7775
5ed99d36 77762011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7777
7778 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7779 and turn window cursor on if cleared (Bug#9415).
7780
5ed99d36 77812011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7782
7783 * search.c (boyer_moore): Take unibyte characters from pattern
7784 literally. (Bug#9458)
7785
9bade7b2
EZ
77862011-09-18 Eli Zaretskii <eliz@gnu.org>
7787
7788 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7789
e5e9d610
PE
77902011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7791
87e4427a
PE
7792 Fix minor problem found by static checking.
7793 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7794 initialized, to pacify gcc -Wuninitialized.
7795
e5e9d610
PE
7796 * fileio.c: Report proper errno when syscall falls.
7797 (Finsert_file_contents): Save and restore errno,
7798 so that report_file_error outputs the correct diagnostic.
7799 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7800
a1674f0b
EZ
78012011-09-18 Eli Zaretskii <eliz@gnu.org>
7802
7803 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7804
fbfb6dd4
EZ
78052011-09-17 Eli Zaretskii <eliz@gnu.org>
7806
7807 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7808 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7809
bb187662
EZ
78102011-09-17 Eli Zaretskii <eliz@gnu.org>
7811
1137e8b8 7812 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7813 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7814
7815 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7816 (bidi_find_paragraph_start): Search back for paragraph beginning
7817 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7818 (bidi_move_to_visually_next): Only trigger paragraph-related
7819 computations when the last character is a newline or at EOB, not
7820 just any NEUTRAL_B. (Bug#9470)
7821
bb187662
EZ
7822 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7823 truncated lines if point is covered by a display string. (Bug#9524)
7824
2e621251
PE
78252011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7826
7827 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7828 (cons_to_x_long): New function.
7829 (lisp_data_to_selection_data): Use it. Correct the test for
7830 short-versus-long data; it was negated. Break out of vector
7831 loop, for efficiency, when a long datum is discovered.
7832
91a15bc6
SM
78332011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7834
7835 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7836
b41c3a35
EZ
78372011-09-16 Eli Zaretskii <eliz@gnu.org>
7838
7839 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7840 GCC PR/17406) by declaring this function with external scope.
7841
7812ba2d
PE
78422011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7843
7844 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7845 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7846
cf7edc2a
AS
78472011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7848
7849 * editfns.c (Fformat): Correctly handle text properties on "%%".
7850
bd01620e
EZ
78512011-09-15 Eli Zaretskii <eliz@gnu.org>
7852
7853 * xterm.c (x_draw_composite_glyph_string_foreground):
7854 * w32term.c (x_draw_composite_glyph_string_foreground):
7855 * term.c (encode_terminal_code):
7856 * composite.c (composition_update_it, get_composition_id):
7857 * xdisp.c (get_next_display_element)
7858 (fill_composite_glyph_string): Add comments about special meaning
7859 of TAB characters in a composition.
7860
a02719a3
PE
78612011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7862
7863 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7864 This occurs when processing a multibyte format.
7865 Problem reported by Wolfgang Jenker.
a02719a3 7866
72589a3c
JB
78672011-09-15 Johan Bockgård <bojohan@gnu.org>
7868
7869 * xdisp.c (try_cursor_movement): Only check for exact match if
7870 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7871
1c14176c
PE
78722011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7873
7874 Remove unused external symbols.
7875 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7876 * xdisp.c (calc_pixel_width_or_height): Now static.
7877 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7878 * indent.c (check_display_width):
7879 * w32term.c: Fix comment to match code.
7880 * xterm.c, xterm.h (x_catching_errors): Remove.
7881
d2eea5b5
PE
78822011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7883
7884 * xselect.c: Use signed conversions more consistently (Bug#9498).
7885 (selection_data_to_lisp_data): Assume incoming selection data are
7886 signed integers, not unsigned. This is to be consistent with
7887 outgoing selection data, which was modified to use signed integers
7888 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7889 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7890 expects long, not unsigned long.
7891
46888499
EZ
78922011-09-14 Eli Zaretskii <eliz@gnu.org>
7893
7894 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7895 computation of loop end. Reported by Johan Bockgård
7896 <bojohan@gnu.org>.
7897
ef8ef9fb
CY
78982011-09-13 Chong Yidong <cyd@stupidchicken.com>
7899
7900 * frame.c (Fother_visible_frames_p): Function deleted.
7901
fa819fed
EZ
79022011-09-12 Eli Zaretskii <eliz@gnu.org>
7903
7904 * indent.c (compute_motion): Process display vector front to back
7905 rather than the other way around. (Bug#2496)
7906
2ba8e008
SM
79072011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7908
7909 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7910
20f53c69
CY
79112011-09-11 Chong Yidong <cyd@stupidchicken.com>
7912
7913 * minibuf.c (Fread_from_minibuffer): Doc fix.
7914
d562d7a4
EZ
79152011-09-11 Eli Zaretskii <eliz@gnu.org>
7916
7917 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7918 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7919
1c4d7f3d
LMI
79202011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7921
7922 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7923 value for non-existent files.
7924
b885bf36
EZ
79252011-09-11 Eli Zaretskii <eliz@gnu.org>
7926
7927 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7928 set its "size" to -1. This will set the modtime_size field of
7929 the corresponding buffer to -1, which is what
7930 verify-visited-file-modtime expects for files that do not exist.
7931 (Bug#9139)
7932
6612f0bf
PE
79332011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7934
7935 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7936 here ...
7937 * lisp.h: ... from here. push_key_description is no longer
7938 defined in keyboard.c, so its declaration should not be in
7939 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7940 logically belongs with push_key_description.
7941
dfb3f755
PE
79422011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7943
7944 * buffer.h: Include <sys/types.h> instead of <time.h>.
7945 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7946 Problem reported by Herbert J. Skuhra.
7947
3134906c
LMI
79482011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7949
7950 * xml.c (parse_region): Make the parsing work for
7951 non-comment-starting XML files again (bug#9144).
7952
8d903f4e
AS
79532011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7954
7955 * image.c (gif_load): Fix calculation of bottom and right corner.
7956 (Bug#9468)
7957
80ad64f4
EZ
79582011-09-10 Eli Zaretskii <eliz@gnu.org>
7959
7960 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7961 redisplay in small windows.
7962
208a048d
EZ
79632011-09-09 Eli Zaretskii <eliz@gnu.org>
7964
7965 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7966
9b1c252e
MR
79672011-09-08 Martin Rudalics <rudalics@gmx.at>
7968
7969 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7970 Operate on live windows only.
7971
2949f33b
JB
79722011-09-08 Juanma Barranquero <lekktu@gmail.com>
7973
7974 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7975
e08dcafd
EZ
79762011-09-07 Eli Zaretskii <eliz@gnu.org>
7977
7978 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7979 only under bidi iteration.
7980
115b96bd
JD
79812011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7982
7983 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7984
c8199d0f
PE
79852011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7986
7987 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7988 Without this fix, the command to link temacs failed due to an
7989 undefined symbol __builtin_isnan. This is because
7990 /usr/include/iso/math_c99.h #defines isnan(x) to
7991 __builtin_isnan(x), but the bundled gcc, which identifies itself
7992 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7993 a __builtin_isnan.
7994 * floatfns.c (isnan): #undef, and then #define to a clone of
7995 what's in data.c.
7996 (Fisnan): Always define, since it's always available now.
7997 (syms_of_floatfns): Always define isnan at the Lisp level.
7998
e39b275c 79992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
8000
8001 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
8002
b2db44d9 80032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 8004
f4af5137 8005 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8006 The previous code assumed that file offsets (off_t values) fit in
8007 EMACS_INT variables, which is not true on typical 32-bit hosts.
8008 The code messed up by falsely reporting buffer overflow in cases
8009 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8010 when "big" contains more than 2**29 bytes, even though this
8011 inserts just one byte and does not overflow the buffer.
8012 (Finsert_file_contents): Store file offsets as off_t
8013 values, not as EMACS_INT values. Check for overflow when
8014 converting between EMACS_INT and off_t. When checking for
8015 buffer overflow or for overlap, take the offsets into account.
8016 Don't use EMACS_INT for small values where int suffices.
8017 When checking for overlap, fix a typo: ZV was used where
8018 ZV_BYTE was intended.
8019 (Fwrite_region): Don't assume off_t fits into 'long'.
8020 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8021
ecfc0a49
MA
80222011-09-05 Michael Albinus <michael.albinus@gmx.de>
8023
8024 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8025
6511acf2 80262011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8027
0999621a 8028 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8029
8030 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8031 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8032 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8033 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8034 (modify_event_symbol): Do not assume that the length of
8035 name_alist_or_stem is safe to alloca and fits in int.
8036 (Fexecute_extended_command): Likewise for function name and binding.
8037 (Frecursion_depth): Wrap around reliably on integer overflow.
8038 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8039 since some callers pass EMACS_INT values.
8040 (Fsingle_key_description): Don't crash if symbol name contains more
8041 than MAX_ALLOCA bytes.
8042 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8043 (get_minibuffer): Arg is now EMACS_INT, not int.
8044 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8045 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8046 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8047
2be7d702
PE
8048 * dbusbind.c (signature_cat): New function.
8049 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8050 Do not overrun buffer; instead, report string overflow.
8051
9d1df220
PE
8052 * dispnew.c (add_window_display_history): Don't overrun buffer.
8053 Truncate instead; this is OK since it's just a log.
8054
33ef5c64
PE
8055 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8056 even if the time zone offset is outlandishly large.
8057 Don't mishandle offset == INT_MIN.
8058
66c6fdd5
PE
8059 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8060 when creating daemon; the previous buffer-overflow check was incorrect.
8061
d749b01b
PE
8062 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8063 which has the guts of the old verror function.
8064
b5cd1905
PE
8065 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8066 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8067
6e1a67fb
PE
8068 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8069 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8070 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8071 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8072 length of string rather than counting it via multiple sprintfs;
8073 that's simpler and more reliable.
c21721cc
PE
8074 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8075 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8076 sprintf, in case result does not fit in int.
8077
c57b67fc
PE
8078 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8079 (fontset_from_font): Print it.
8080
8a401434
PE
8081 * frame.c (tty_frame_count): Now printmax_t, not int.
8082 (make_terminal_frame, set_term_frame_name): Print it.
8083 (x_report_frame_params): In X, window IDs are unsigned long,
8084 not signed long, so print them as unsigned.
8085 (validate_x_resource_name): Check for implausibly long names,
8086 and don't assume name length fits in 'int'.
8087 (x_get_resource_string): Don't blindly alloca invocation name;
8088 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8089 not fit in int.
8090
6e1a67fb
PE
8091 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8092 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8093 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8094
0df02bf3
PE
8095 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8096 Use esprintf, not sprintf, in case result does not fit in int.
8097
48e30793
PE
8098 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8099 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8100 it as a large positive number.
8101 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8102 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8103
a66ff6d8
PE
8104 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8105 in case result does not fit in int.
8106
aca216ff
PE
8107 * print.c (float_to_string): Detect width overflow more reliably.
8108 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8109 buffer overrun. Don't assume list length fits in 'int'. Treat
8110 print length of 0 as 0, not as infinity; to be consistent with other
8111 uses of print length in this function. Don't overflow print length
8112 index. Don't assume hash table size fits in 'long', or that
8113 vectorlike size fits in 'unsigned long'.
8114
31c286f7
PE
8115 * process.c (make_process): Use printmax_t, not int, to format
8116 process-name gensyms.
8117
55e5faa1
PE
8118 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8119
80f2e268
PE
8120 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8121 to avoid potential buffer overrun.
8122
670741ab
PE
8123 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8124 if X resource line is longer than 512 bytes.
8125
b7163a50
PE
8126 * xfns.c (x_window): Make sprintf buffer a bit bigger
8127 to avoid potential buffer overrun.
8128
ae58ff1f
PE
8129 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8130
c43c8a6a
PE
8131 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8132
3f8236f4
PE
81332011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8134
53e9fe90 8135 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8136 Without these, Emacs silently mishandles large integers sometimes.
8137 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8138 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8139
6511acf2
PE
8140 * xdisp.c (try_window_id): Check Emacs fixnum range before
8141 converting to 'int'.
806add1d 8142
6511acf2 8143 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8144 Check that an Emacs fixnum is in range before assigning it to 'int'.
8145 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8146 values converted from Emacs fixnums.
8147 (Frecenter): Don't wrap around a line count if it is out of 'int'
8148 range; instead, treat it as an extreme value.
8149 (Fset_window_configuration, compare_window_configurations):
8150 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8151
6511acf2
PE
8152 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8153 that can exceed INT_MAX. Check that EMACS_INT value is in range
8154 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8155 (match_limit): Don't assume that a fixnum can fit in 'int'.
8156
6511acf2 8157 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8158 exceed INT_MAX.
8159
6511acf2 8160 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8161 (Fvertical_motion): Don't wrap around LINES values that don't fit
8162 in 'int'. Instead, treat them as extreme values. This is good
8163 enough for windows, which can't have more than INT_MAX lines anyway.
8164
fcb901a7
LMI
81652011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8166
0f2f6b6d
LMI
8167 * Require libxml/parser.h to avoid compilation warning.
8168
fcb901a7
LMI
8169 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8170
8171 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8172 since this reportedly can destroy thread storage.
8173
6e20a0d4
CY
81742011-08-30 Chong Yidong <cyd@stupidchicken.com>
8175
8176 * syntax.c (find_defun_start): Update all cache variables if
8177 exiting early (Bug#9401).
8178
148ae00e
EZ
81792011-08-30 Eli Zaretskii <eliz@gnu.org>
8180
f6cfbd8f
EZ
8181 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8182
148ae00e
EZ
8183 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8184 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8185 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8186
8187 * term.c (tty_append_glyph): New function.
8188 (produce_stretch_glyph): Static function and its prototype deleted.
8189
a66cfb1c
SM
8190 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8191 Add prototypes.
148ae00e 8192
c4a07a4c
PE
81932011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8194
8195 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8196 when checking :margin (Bug#9390).
8197 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8198 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8199 so that the name doesn't mislead. All uses changed.
8200
6bc8cd65
JB
82012011-08-28 Johan Bockgård <bojohan@gnu.org>
8202
8203 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8204 set_tty_hooks.
8205
dca4927e
EZ
82062011-08-27 Eli Zaretskii <eliz@gnu.org>
8207
8208 * xdisp.c (move_it_to): Don't bail out early when reaching
8209 position beyond to_charpos, if we are scanning backwards.
8210 (move_it_vertically_backward): When DY == 0, make sure we get to
8211 the first character in the line after the newline.
8212
f2cad773
PE
82132011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8214
8215 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8216 (ccl_driver): Do not generate an out-of-range pointer.
8217 (Fccl_execute_on_string): Remove unnecessary check for
8218 integer overflow, noted by Stefan Monnier in
8219 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8220 Remove a FIXME that didn't need fixing.
8221 Simplify the newly-introduced buffer reallocation code.
8222
0cae2cdb
JB
82232011-08-27 Juanma Barranquero <lekktu@gmail.com>
8224
8225 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8226
5fc295a4 82272011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8228
70c60eb2 8229 Integer and memory overflow issues (Bug#9196).
726e0ab1 8230
d31850da
PE
8231 * doc.c (get_doc_string): Rework so that
8232 get_doc_string_buffer_size is the actual buffer size, rather than
8233 being 1 less than the actual buffer size; this makes xpalloc more
8234 convenient.
8235
a69fbedb
PE
8236 * image.c (x_allocate_bitmap_record, cache_image):
8237 * xselect.c (Fx_register_dnd_atom):
8238 Simplify previous changes by using xpalloc.
8239
fe5c5d37
PE
8240 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8241 since either will do and ptrdiff_t is convenient with xpalloc.
8242
0065d054
PE
8243 * charset.c (charset_table_size)
8244 (struct charset_sort_data.priority): Now ptrdiff_t.
8245 (charset_compare): Don't overflow if priorities differ greatly.
8246 (Fsort_charsets): Don't assume list length fits in int.
8247 Check for size-calculation overflow when allocating sort data.
8248 (syms_of_charset): Allocate an initial charset table that is
8249 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8250
8251 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8252
8253 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8254 The actual value is always <= INT_MAX, and leaving it unsigned made
8255 overflow checking harder.
8256
8257 * dispextern.h (struct glyph_matrix.rows_allocated)
8258 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8259 with xpalloc. The values are still always <= INT_MAX.
8260
8261 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8262
8263 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8264 (SAFE_NALLOCA): New macro.
8265
8266 * region-cache.c (struct boundary.pos, find_cache_boundary)
8267 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8268 (set_cache_region, invalidate_region_cache)
8269 (revalidate_region_cache, know_region_cache, region_cache_forward)
8270 (region_cache_backward, pp_cache):
8271 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8272 so that ptrdiff_t * can be passed to xpalloc.
8273 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8274 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8275 (pp_cache): Don't assume cache_len fits in int.
8276 * region-cache.h: Adjust extern decls to match.
8277
8278 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8279 EMACS_INT, since either will do, for xpalloc.
8280
8281 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8282 (xnmalloc, xnrealloc, xpalloc): New functions.
8283
726e0ab1
PE
8284 * bidi.c (bidi_shelve_header_size): New constant.
8285 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8286 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8287
51f30bc5 8288 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8289 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8290 (overlay_strings):
8291 Don't update size of array until after memory allocation succeeds,
8292 because xmalloc/xrealloc may not return.
0065d054
PE
8293 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8294 now that we have proper integer overflow checking.
8295 (record_overlay_string, overlay_strings): Catch overflows when
8296 calculating size of overlay_str_buf.
726e0ab1 8297
0065d054
PE
8298 * callproc.c (Fcall_process): Check for size overflow when
8299 calculating size of args2.
8300 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8301 Normally we prefer signed values, but sticking with ptrdiff_t would
8302 require adding more-complicated checks.
726e0ab1
PE
8303
8304 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8305 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8306 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8307 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8308
8309 * character.c (Fstring): Check for size-calculation overflow.
8310
8311 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8312 unnecessary integer overflow. Check for size overflow.
8313 (encode_coding_object): Don't update size until xmalloc succeeds.
8314
8315 * composite.c (get_composition_id): Check for overflow in glyph
8316 length calculations.
8317
8318 Integer and memory overflow fixes for display code.
8319 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8320 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8321 (scrolling_window): Check for overflow in size calculations.
8322 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8323 Don't assume glyph table len fits in int.
8324 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8325 (row_table_size): Now ptrdiff_t, not int.
8326 (scrolling_window): Avoid overflow in size calculations.
8327 Don't update size until allocation succeeds.
8328 * fns.c (concat): Check for overflow in size calculations.
8329 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8330 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8331 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8332
8333 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8334 (get_doc_string): Check for size calculation overflow.
8335 Don't update size until allocation succeeds.
8336 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8337 EMACS_INT, where ptrdiff_t will do.
8338 (Fsubstitute_command_keys): Check for string overflow.
8339
8340 * editfns.c (set_time_zone_rule): Don't assume environment length
8341 fits in int.
8342 (message_length): Now ptrdiff_t, not int.
8343 (Fmessage_box): Don't update size until allocation succeeds.
8344 Don't assume message length fits in int.
8345 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8346
0065d054
PE
8347 * emacs.c (main): Do not reallocate argv, since there is a null at
8348 the end that can be overwritten, and this way there's no need to
8349 worry about size-calculation overflow.
8350 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8351
8352 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8353 alloc succeeds.
8354 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8355
8356 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8357 (x_set_scroll_bar_width, x_figure_window_size):
8358 Check for integer overflow.
8359 (x_set_alpha): Do not assume XINT fits in int.
8360
8361 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8362 This is for the members text_lines, text_cols, total_lines, total_cols,
8363 where the system imposes an 'int' limit.
8364
8365 * fringe.c (Fdefine_fringe_bitmap):
8366 Don't update size until alloc works.
8367
8368 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8369 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8370
8371 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8372 Check for size-calculation overflow.
8373 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8374 do, as we prefer signed integers.
8375 (id_to_widget.max_size, id_to_widget.used)
8376 (xg_store_widget_in_map, xg_remove_widget_from_map)
8377 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8378 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8379 Use and return ptrdiff_t, not int.
8380 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8381 * gtkutil.h: Change prototypes to match the above.
8382
8383 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8384 are duplicate now that they've been promoted to lisp.h.
8385 (x_allocate_bitmap_record, x_alloc_image_color)
8386 (make_image_cache, cache_image, xpm_load):
8387 Don't update size until alloc is done.
8388 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8389 (x_detect_edges):
3256efce 8390 Check for size calculation overflow.
726e0ab1
PE
8391 (ct_colors_allocated_max): New constant.
8392 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8393 overflow.
3256efce 8394
726e0ab1
PE
8395 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8396 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8397 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8398 Use ptrdiff_t, not int, to count maps.
8399 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8400 calculations. Don't update size until allocation succeeds.
8401 Redo calculations to avoid overflow.
726e0ab1
PE
8402 * keyboard.h: Change prototypes to match the above.
8403
8404 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8405 to count maps.
8406 (current_minor_maps): Check for size calculation overflow.
8407 * keymap.h: Change prototypes to match the above.
8408
8409 * lread.c (read1, init_obarray): Don't update size until alloc done.
8410
8411 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8412 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8413
726e0ab1
PE
8414 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8415 Now ptrdiff_t, not int.
8416 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8417 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8418
8419 * process.c (Fnetwork_interface_list): Check for overflow
8420 in size calculation.
8421
8422 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8423
8424 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8425 overflow. Don't bother calling xmalloc when xrealloc will do.
8426
8427 * search.c (Freplace_match): Check for size calculation overflow.
8428 (Fset_match_data): Don't assume list lengths fit in 'int'.
8429
8430 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8431 for command line length. Do not attempt to address one before the
8432 beginning of an array, as that's not portable.
8433
8434 * term.c (max_frame_lines): Remove; unused.
8435 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8436 not int.
8437 (encode_terminal_code, calculate_costs): Check for size
8438 calculation overflow.
8439 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8440 table lengths and related sizes. Don't update size until alloc
8441 done. Redo calculations to avoid overflow.
8442 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8443
8444 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8445 subtracting pointers.
8446 (gobble_line): Check for overflow more carefully. Don't update size
8447 until alloc done.
8448
8449 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8450 Don't update size until alloc done.
8451 Redo size calculations to avoid overflow.
8452 Check for size calculation overflow.
0065d054 8453 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8454
8455 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8456 Use ptrdiff_t, not int, for sizes.
8457 (store_mode_line_noprop_char): Don't update size until alloc done.
8458
0065d054
PE
8459 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8460 Use ptrdiff_t, not int, for sizes.
8461 (Finternal_make_lisp_face, cache_face):
8462 Check for size calculation overflow.
8463 (cache_face): Treat size calculation overflows as if they were
8464 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8465
8466 * xfns.c (x_encode_text, x_set_name_internal)
8467 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8468 sizes, since they can exceed INT_MAX in size. Check for size
8469 calculation overflow.
8470
0065d054
PE
8471 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8472 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8473 Don't update size until alloc done.
8474
0065d054 8475 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8476 as sprintf is limited to int lengths.
1d526e2f 8477
252c5ee1
PE
8478 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8479 (X_LONG_MIN): New macros.
864d7ce7
PE
8480 Use them to make the following changes clearer.
8481 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8482 This change doesn't affect the value now, but it may help remind
8483 future maintainers not to raise the value too much later.
8484 (SELECTION_QUANTUM): Remove, replacing with ...
8485 (selection_quantum): ... new function, which avoids overflow.
8486 All uses changed.
8487 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8488 assumption that selection length fits in 'int'.
8489 (x_reply_selection_request, x_handle_selection_request)
8490 (x_get_window_property, receive_incremental_selection)
8491 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8492 (lisp_data_to_selection_data, clean_local_selection_data):
8493 Use ptrdiff_t, not int, to record length of selection.
8494 (x_reply_selection_request, x_get_window_property)
8495 (receive_incremental_selection, x_property_data_to_lisp):
8496 Redo calculations to avoid overflow.
8497 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8498 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8499 something.
8500 (x_get_window_property, receive_incremental_selection)
8501 (lisp_data_to_selection_data, x_property_data_to_lisp):
8502 Check for size-calculation overflow.
8503 (x_get_window_property, receive_incremental_selection)
8504 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8505 Don't store size until memory allocation succeeds.
8506 (x_get_window_property): Plug memory leak on memory exhaustion.
8507 Don't double-block input; malloc is safe here. Don't assume 2**34
8508 - 4 fits in unsigned long. Add an xassert to check
8509 XGetWindowProperty overflow. Be more careful about overflow
8510 calculations, and distinguish size from memory overflow better.
8511 (receive_incremental_selection): When tracing, don't assume
8512 unsigned int is less than INT_MAX.
8513 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8514 harmful) conversions of unsigned short to int.
8515 (lisp_data_to_selection_data): Don't assume that integers
8516 in the range -65535 through -1 fit in an X unsigned short.
8517 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8518 result parameters unless successful. Rely on cons_to_unsigned
8519 to report problems with elements; the old code wasn't right anyway.
8520 (x_check_property_data): Check for int overflow; we cannot use
8521 a wider type due to X limits.
8522 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8523
726e0ab1 8524 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8525
0065d054
PE
8526 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8527 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8528 (x_color_cells): Don't store size until memory allocation succeeds.
8529 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8530 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8531 (x_term_init): Don't assume length fits in int (sprintf is limited
8532 to int size).
bc18e09d 8533
ebfa62c0
PE
8534 Use ptrdiff_t for composition IDs.
8535 * character.c (lisp_string_width):
8536 * composite.c (composition_table_size, n_compositions)
8537 (get_composition_id, composition_gstring_from_id):
8538 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8539 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8540 * window.c (Frecenter):
8541 Use ptrdiff_t, not int, for composition IDs.
8542 * composite.c (get_composition_id): Check for integer overflow.
8543 * composite.h: Adjust prototypes to match the above changes.
8544
d3411f89
PE
8545 Use ptrdiff_t for hash table indexes.
8546 * category.c (hash_get_category_set):
8547 * ccl.c (ccl_driver):
8548 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8549 * coding.c (coding_system_charset_list, detect_coding_system):
8550 * coding.h (struct coding_system.id):
8551 * composite.c (get_composition_id, gstring_lookup_cache):
8552 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8553 * image.c (xpm_get_color_table_h):
8554 * lisp.h (hash_lookup, hash_put):
8555 * minibuf.c (Ftest_completion):
8556 Use ptrdiff_t for hash table indexes, not int (which is too
8557 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8558 32-bit --with-wide-int hosts).
8559
e097a6fa
PE
8560 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8561 Add a FIXME comment about memory leaks.
8562 (syms_of_charset): Don't assume xmalloc returns.
8563
5637687f
PE
8564 Don't assume that stated character widths fit in int.
8565 * character.c (Fchar_width, c_string_width, lisp_string_width):
8566 * character.h (CHAR_WIDTH):
8567 * indent.c (MULTIBYTE_BYTES_WIDTH):
8568 Use sanitize_char_width to avoid undefined and/or bad behavior
8569 with outlandish widths.
a66cfb1c 8570 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8571 now that we have two such functions. All uses changed.
8572 (sanitize_char_width): New inline function.
8573
a2271ba2
PE
8574 Don't assume that tab-width fits in int.
8575 * character.h (sanitize_width): New inline function.
8576 (SANE_TAB_WIDTH): New macro.
8577 (ASCII_CHAR_WIDTH): Use it.
8578 * indent.c (sane_tab_width): Remove. All uses replaced by
8579 SANE_TAB_WIDTH (current_buffer).
8580 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8581
18c52557
PE
8582 * fileio.c: Integer overflow issues with file modes.
8583 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8584
caeeedc1
PE
8585 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8586 Remove unreachable code.
8587 (read_hex, load_charset_map_from_file): Check for integer overflow.
8588
6df6ae42 8589 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8590 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8591 (x_send_scroll_bar_event): Likewise. Check that the size does not
8592 exceed limits imposed by XClientMessageEvent, as well as the usual
8593 ptrdiff_t and size_t limits.
8594
b13995db
PE
8595 * keyboard.c: Overflow, signedness and related fixes.
8596 (make_lispy_movement): Use same integer type in forward decl
8597 that is used in the definition.
8598 (read_key_sequence, keyremap_step):
8599 Change bufsize argument back to int, undoing my 2011-03-30 change.
8600 We prefer signed types, and int is wide enough here.
8601 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8602 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8603 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8604 length, not size_t. Use ptrdiff_t for index, not int.
8605 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8606 possibility of integer overflow.
8607
13464394
PE
8608 Overflow, signedness and related fixes for images.
8609
8610 * dispextern.h (struct it.stack[0].u.image.image_id)
8611 (struct_it.image_id, struct image.id, struct image_cache.size)
8612 (struct image_cache.used, struct image_cache.ref_count):
8613 * gtkutil.c (update_frame_tool_bar):
8614 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8615 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8616 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8617 * nsmenu.m (update_frame_tool_bar):
8618 * xdisp.c (calc_pixel_width_or_height):
8619 * xfns.c (image_cache_refcount):
8620 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8621 on typical 64-bit hosts.
8622
8623 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8624 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8625 Omit unnecessary casts to int.
8626 (parse_image_spec): Check that integers fall into 'int' range
8627 when the callers expect that.
8628 (image_ascent): Redo ascent calculation to avoid int overflow.
8629 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8630 (lookup_image): Remove unnecessary tests.
8631 (xbm_image_p): Locals are now of int, not EMACS_INT,
8632 since parse_image_check makes sure they fit into int.
8633 (png_load, gif_load, svg_load_image):
8634 Prefer int to unsigned where either will do.
8635 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8636 old tiff_error_handler and tiff_warning_handler.
8637 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8638 stack buffer overflows. It uses only the features of vsnprintf
8639 that are common to both POSIX and native Microsoft.
8640 (tiff_error_handler, tiff_warning_handler): Use it.
8641 (tiff_load, gif_load, imagemagick_load_image):
8642 Don't assume :index value fits in 'int'.
8643 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8644 (imagemagick_load_image): Check that crop parameters fit into
8645 the integer types that MagickCropImage accepts. Don't assume
8646 Vimagemagick_render_type has a nonnegative value. Don't assume
8647 size_t fits in 'long'.
8648 (gs_load): Use printmax_t to print the widest integers possible.
8649 Check for integer overflow when computing image height and width.
8650
c11821d4
EZ
86512011-08-26 Eli Zaretskii <eliz@gnu.org>
8652
8653 * xdisp.c (redisplay_window): Don't force window start if point
8654 will be invisible in the resulting window. (Bug#9324)
8655
0c95fcf7
EZ
86562011-08-25 Eli Zaretskii <eliz@gnu.org>
8657
8658 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8659 the display spec is of the form `(space ...)'.
8660 (handle_display_spec): Return the value returned by
8661 handle_single_display_spec, not just 1 or zero.
8662 (handle_single_display_spec): If the display spec is of the form
8663 `(space ...)', and specifies display in the text area, return 2
8664 rather than 1.
fee65a97 8665 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8666 accurately, and prefer exact match for point under bidi.
8667 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8668
8669 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8670 into disp_prop; all users changed.
8671
8672 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8673 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8674 for the text covered by the display property.
8675
e4ed06f1
CY
86762011-08-25 Chong Yidong <cyd@stupidchicken.com>
8677
8678 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8679 Change return value to nil.
8680 (Frecord_buffer): Delete unused function.
8681
f67cdd7f
EZ
86822011-08-24 Eli Zaretskii <eliz@gnu.org>
8683
5980d4c6
EZ
8684 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8685 buffers, return left-to-right.
8610fe8b
EZ
8686 (set_cursor_from_row): Consider candidate row a win if its glyph
8687 represents a newline and point is on that newline. Fixes cursor
8688 positioning on the newline at EOL of R2L text within L2R
8689 paragraph, and vice versa.
8690 (try_cursor_movement): Check continued rows, in addition to
8691 continuation rows. Fixes unwarranted scroll when point enters a
8692 continued line of R2L text within an L2R paragraph, or vice versa.
8693 (cursor_row_p): Consider the case of point being equal to
8694 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8695 from the end of a short line to the beginning of a continued line
8696 of R2L text within L2R paragraph.
8697 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8698 composed characters.
5980d4c6 8699
f67cdd7f
EZ
8700 * bidi.c (bidi_check_type): Use xassert.
8701 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8702 members.
8703
bca633fb
EZ
87042011-08-23 Eli Zaretskii <eliz@gnu.org>
8705
8706 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8707 a character.
8708
4a5885a7
CY
87092011-08-23 Chong Yidong <cyd@stupidchicken.com>
8710
8711 * nsfont.m (ns_otf_to_script): Fix typo.
8712
0902a04e
KH
87132011-08-22 Kenichi Handa <handa@m17n.org>
8714
8715 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8716 extra slot even if the purpose is char-code-property-table.
8717
1a2e6670
EZ
87182011-08-23 Eli Zaretskii <eliz@gnu.org>
8719
8ddde651
EZ
8720 * xdisp.c (redisplay_window): When computing centering_position,
8721 account for the height of the header line. (Bug#8874)
8722
425cc014
EZ
8723 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8724 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8725 candidate is selected by the mouse, and that candidate has a
8726 composed character under the mouse.
8727
1a2e6670
EZ
8728 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8729 coordinates reported by pos-visible-in-window-p for a composed
8730 character in column zero.
8731
8b76d6f8
SM
87322011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8733
8734 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8735
dac347dd
EZ
87362011-08-22 Eli Zaretskii <eliz@gnu.org>
8737
8738 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8739 consider it a hit if to_charpos is anywhere in the range of the
8740 composed buffer positions.
8741
e013fb34
CY
87422011-08-22 Chong Yidong <cyd@stupidchicken.com>
8743
8744 * image.c (gif_load): Don't assume that each subimage has the same
8745 dimensions as the base image. Handle disposal method that is
8746 "undefined" by the gif spec (Bug#9335).
8747
bd1ba3e8
CY
87482011-08-20 Chong Yidong <cyd@stupidchicken.com>
8749
8750 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8751 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8752
54a1215b
EZ
87532011-08-19 Eli Zaretskii <eliz@gnu.org>
8754
823564e5
EZ
8755 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8756 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8757 from an Org mode buffer to a Speedbar frame.
8758
54a1215b
EZ
8759 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8760 a composition, take its buffer position from IT->cmp_it.charpos.
8761 Fixes cursor positioning at the beginning of a line that begins
8762 with a composed character.
8763
9778ebcc
EZ
87642011-08-18 Eli Zaretskii <eliz@gnu.org>
8765
0be6ee06
EZ
8766 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8767 character bidirectional type, use STRONG_L instead. Fixes crashes
8768 in a buffer produced by `describe-categories'.
8769
9778ebcc
EZ
8770 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8771 members before the level stack, so they would be saved and
8772 restored when copying iterator state. Fixes incorrect reordering
8773 around TABs covered by display properties.
8774
156bffbe
AS
87752011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8776
6b02f655 8777 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8778
72ad093b
CY
87792011-08-17 Chong Yidong <cyd@stupidchicken.com>
8780
8781 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8782 (internal_condition_case_2, internal_condition_case_n):
8783 Remove unnecessary aborts (Bug#9081).
72ad093b 8784
35774242
EZ
87852011-08-17 Eli Zaretskii <eliz@gnu.org>
8786
8787 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8788 has no `load' handler, try opening the file locally. (Bug#9311)
8789
db76dd85
KB
87902011-08-16 Ken Brown <kbrown@cornell.edu>
8791
8792 * gmalloc.c: Expand comment.
8793
b215eee5
EZ
87942011-08-16 Eli Zaretskii <eliz@gnu.org>
8795
8796 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8797 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8798
a4579d33
KB
87992011-08-16 Ken Brown <kbrown@cornell.edu>
8800
8801 Fix memory allocation problems in Cygwin build (Bug#9273).
8802
8803 * unexcw.c ( __malloc_initialized): Declare external variable.
8804 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8805
8b76d6f8
SM
8806 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8807 New variables.
a4579d33
KB
8808 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8809 dumped emacs.
8810 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8811 in the static heap.
8812 [CYGWIN] (special_realloc): New function.
8813 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8814 requests to realloc storage in the static heap.
8815
3ebec551
PE
88162011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8817
8818 * bidi.c (bidi_initialize): Remove unused local.
8819
9fd8be00
EZ
88202011-08-15 Eli Zaretskii <eliz@gnu.org>
8821
6b02f655
SM
8822 * bidimirror.h:
8823 * biditype.h: Remove file.
8824 * makefile.w32-in ($(BLD)/bidi.$(O)):
8825 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8826
8827 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8828
8829 * chartab.c: Improve commentary for the uniprop_table API.
8830
32413314
EZ
8831 * bidi.c (bidi_paragraph_init): Support zero value of
8832 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8833 (bidi_initialize): Use uniprop_table instead of including
8834 biditype.h and bidimirror.h.
32413314 8835
9fd8be00
EZ
8836 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8837 coordinates of the iterator when restoring from ppos_it.
8838 (Bug#9296)
8839
5cf2b69b
KH
88402011-08-14 Kenichi Handa <handa@m17n.org>
8841
8842 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8843 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8844
daf17d00
EZ
88452011-08-14 Eli Zaretskii <eliz@gnu.org>
8846
8847 * xdisp.c (move_it_in_display_line_to): Don't invoke
8848 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8849 ppos_it. Fixes vertical cursor motion when line beginning is
8850 covered by an image. (Bug#9296)
8851
08e3161a
JD
88522011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8853
8854 * nsterm.h (ns_run_ascript): Declare.
8855 (NSAPP_DATA2_RUNASSCRIPT): Define.
8856
8857 * nsfns.m (as_script, as_result, as_status): New static variables.
8858 (ns_run_ascript): New function.
5e617bc2 8859 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8860 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8861 the event loop. Get status from as_status (Bug#7276).
8862
8863 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8864 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8865 the event loop (Bug#7276).
8866
a3720aa2
AS
88672011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8868
8869 * gnutls.c (QCgnutls_bootprop_priority)
8870 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8871 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8872 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8873 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8874 (QCgnutls_bootprop_verify_hostname_error)
8875 (QCgnutls_bootprop_callbacks_verify): Rename from
8876 Qgnutls_bootprop_..., all uses changed.
8877
8878 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8879 uses changed.
8880
0a0d27fb
PE
88812011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8882
19d5c50c
PE
8883 * xfaces.c (Qframe_set_background_mode): Now static.
8884 * dispextern.h (Qframe_set_background_mode): Remove decl.
8885
0a0d27fb
PE
8886 * process.c (Fnetwork_interface_info): Declare local only if needed.
8887
377538cb
JD
88882011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8889
8890 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8891 (Fnetwork_interface_list): Allocate in increments of bytes instead
8892 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8893 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8894 sockaddr.
8895 (struct ifflag_def): notrailers is smart on OSX.
8896 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8897 Get hardware address with getifaddrs if available.
8898
08fff70c
EZ
88992011-08-12 Eli Zaretskii <eliz@gnu.org>
8900
8901 * xdisp.c (iterate_out_of_display_property): xassert that
8902 IT->position is set to within IT->object's boundaries. Break from
8903 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8904 when IT->position is set up wrongly due to some bug.
8905 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8906 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8907 entry. Force push_it to save on the stack the current
8908 buffer/string position, to be restored by pop_it. Fix flags in
8909 the iterator structure wrt the object coming from a display
8910 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8911 properties. (Bug#9284)
8912
7be1c708 89132011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8914
7be1c708
CY
8915 * fontset.c (fontset_get_font_group): Add proper type checks.
8916 (Bug#9172)
aac0c6e3 8917
7be1c708 89182011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8919
7be1c708
CY
8920 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8921 and LC_VERSION_MIN_MACOSX.
8922 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8923 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8924
97bb72a6
EZ
89252011-08-08 Eli Zaretskii <eliz@gnu.org>
8926
8927 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8928 no-display-properties-and-no-overlays under bidi display.
8929 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8930 properties and overlays.
97bb72a6 8931
d5617611
CY
89322011-08-08 Chong Yidong <cyd@stupidchicken.com>
8933
37e11a63
CY
8934 * editfns.c (Fset_time_zone_rule): Document relationship with the
8935 setenv function.
8936
d5617611
CY
8937 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8938 the font entity extracted from the cache (Bug#8109).
8939
58872834
CY
89402011-08-07 Chong Yidong <cyd@stupidchicken.com>
8941
8942 * composite.c (autocmp_chars): Don't reset point. That is done by
8943 restore_point_unwind (Bug#5984).
8944
75bfc667
JL
89452011-08-07 Juri Linkov <juri@jurta.org>
8946
8947 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8948 to show the arg `TIME' instead of `TIMEVAL'.
8949
d1410150
EZ
89502011-08-06 Eli Zaretskii <eliz@gnu.org>
8951
8952 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8953 display property strides EOL and includes a newline, as in
8954 longlines-mode. (Bug#9254)
75b771e4
EZ
8955 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8956 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8957
8958 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8959 is non-zero, even if the data buffer is NULL. Fixes a crash in
8960 vertical-motion with longlines-mode. (Bug#9254)
8961
35928349
EZ
89622011-08-05 Eli Zaretskii <eliz@gnu.org>
8963
ec7cc85b
EZ
8964 * bidi.c <bidi_cache_total_alloc>: Now static.
8965 (bidi_initialize): Initialize bidi_cache_total_alloc.
8966
8b76d6f8 8967 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8968 cache. (Bug#9221)
8969
8970 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8971 amount allocated this far in `bidi_cache_total_alloc'.
8972 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8973 non-zero, only free the data buffer without restoring the cache
8974 contents. All callers changed.
8975
8976 * dispextern.h (bidi_unshelve_cache): Update prototype.
8977
8978 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8979 (move_it_in_display_line, move_it_to)
8980 (move_it_vertically_backward, move_it_by_lines): Replace the call
8981 to xfree to an equivalent call to bidi_unshelve_cache.
8982 (move_it_in_display_line_to): Fix logic of returning
412b6358 8983 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8984
e2e2423b
EZ
89852011-08-05 Eli Zaretskii <eliz@gnu.org>
8986
8987 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8988 came from a string character with a `cursor' property. (Bug#9229)
8989
ae9e757a
JD
89902011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8991
8992 * Makefile.in (LIB_PTHREAD): New variable.
8993 (LIBES): Add LIB_PTHREAD (Bug#9216).
8994
8995 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8996 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8997
213bd7f2
AS
89982011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8999
6b02f655 9000 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 9001
99aaf75f
JD
90022011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9003
9004 * xterm.c (x_find_topmost_parent): New function.
9005 (x_set_frame_alpha): Find topmost parent window with
9006 x_find_topmost_parent and set the property there also (bug#9181).
9007 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9008
c74e9d86
PE
90092011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9010
9011 * callproc.c (Fcall_process): Avoid vfork clobbering
9012 the local vars buffer, coding_systems, current_dir.
9013
640c8776
SM
90142011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9015
9016 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9017
f26d0e4c
PE
90182011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9019
8a10d76c
PE
9020 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9021 so that it is not optimized away.
9022
f26d0e4c
PE
9023 * xdisp.c (compute_display_string_pos): Remove unused local.
9024
55439c61
EZ
90252011-08-02 Eli Zaretskii <eliz@gnu.org>
9026
9027 Fix slow cursor motion and scrolling in large buffers with
9028 selective display, like Org Mode buffers. (Bug#9218)
9029
9030 * dispextern.h (struct bidi_it): New member disp_prop_p.
9031
9032 * xdisp.c: Remove one-slot cache of display string positions.
9033 (compute_display_string_pos): Accept an additional argument
5e617bc2 9034 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9035 for a display string or property. If found, set DISP_PROP_P
9036 non-zero.
9037
9038 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9039 DISP_PROP_P, and pass it to compute_display_string_pos.
9040 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9041 non-zero. All callers of bidi_fetch_char changed.
9042
fb33fa43
SM
90432011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9044
9045 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9046
b099e063
DM
90472010-12-03 Don March <don@ohspite.net>
9048
9049 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9050 last character M-[char] is translated to ESC [char] (bug#7541).
9051
5cc7f7af
KH
90522011-08-02 Kenichi Handa <handa@m17n.org>
9053
d0fffa3f 9054 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9055
9056 * chartab.c (uniprop_table): Make it non-static.
9057
525d5e6e
EZ
90582011-08-01 Eli Zaretskii <eliz@gnu.org>
9059
9060 * xdisp.c (forward_to_next_line_start): Accept additional argument
9061 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9062 on the newline.
9063 (reseat_at_next_visible_line_start): Use the bidi iterator state
9064 returned by forward_to_next_line_start to restore the state of
9065 it->bidi_it after backing up to previous newline. (Bug#9212)
9066
31011111
AS
90672011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9068
9069 * regex.c (re_comp): Protoize.
9070 (re_exec): Fix return type.
9071 (regexec): Fix type of `ret'. (Bug#9203)
9072
476371c4
PE
90732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9074
e5d76069
PE
9075 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9076 This is needed if max-image-size is a floating-point number.
9077
9a79b20c
AS
90782011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9079
9080 * print.c (print_object): Print empty symbol as ##.
9081
9082 * lread.c (read1): Read ## as empty symbol.
9083
d8c2fa78
AA
90842011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9085
9086 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9087 setting frame foreground color (Bug#9175).
9088 (x_set_background_color): Likewise.
9089
ffe57a7a
AA
9090 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9091 contents (Bug#9176).
9092 (EmacsTooltip -init): Remove bezels and add shadows to
9093 tooltip windows.
9094
bf3492a5
AA
9095 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9096 or scroll bar (Bug#8470).
9097
d55e9c53
AA
9098 * nsfont.m (nsfont_open): Remove assignment to voffset and
9099 unnecessary vars hshink, expand, hd, full_height, min_height.
9100 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9101
9102 * nsterm.h (nsfont_info): Remove voffset field.
9103
d8c2fa78 91042011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9105
9106 Implement strike-through and overline on NextStep (Bug#8863).
9107
9108 * nsfont.m (nsfont_open): Use underline position provided by font,
9109 instead of hard-coded value of 2.
9110 (nsfont_draw): Call ns_draw_text_decoration instead.
9111
9112 * nsterm.h: Add declaration for ns_draw_text_decoration.
9113
9114 * nsterm.m (ns_draw_text_decoration): New function for drawing
9115 underline, overline, and strike-through.
9116 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9117 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9118 accommodate underlining, etc.
4843aac3 9119
4cc60b9b
EZ
91202011-07-28 Eli Zaretskii <eliz@gnu.org>
9121
bc7ece87
EZ
9122 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9123 default.
4cc60b9b 9124
476371c4
PE
91252011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9126
66606eea
PE
9127 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9128 Without this fix, if a signal arrives just after memory fills up,
9129 'malloc' might be invoked reentrantly.
9130
476371c4
PE
9131 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9132 In other words, assume that every image size is allowed, on non-X
9133 hosts. This assumption is probably wrong, but it lets Emacs compile.
9134
f3fcc40d
AS
91352011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9136
9137 * regex.c (re_iswctype): Convert return values to boolean.
9138
350c992f
EZ
91392011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9140
9141 * xdisp.c (compute_display_string_pos): Don't use cached display
9142 string position if the buffer had its restriction changed.
9143 (Bug#9184)
9144
5266b4bb
PE
91452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9146
9147 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9148
2573a837 91492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9150
41f55ccd 9151 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9152
39e378da
PE
9153 * bidi.c: Integer size and overflow fixes.
9154 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9155 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9156 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9157 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9158 (bidi_find_other_level_edge):
9159 Use ptrdiff_t instead of EMACS_INT where either will do.
9160 This works better on 32-bit hosts configured --with-wide-int.
9161 (bidi_cache_ensure_space): Check for size-calculation overflow.
9162 Use % rather than repeated addition, for better worst-case speed.
9163 Don't set bidi_cache_size until after xrealloc returns, because it
9164 might not return.
9165 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9166 (bidi_cache_ensure_space): Also check that the bidi cache size
9167 does not exceed that of the largest Lisp string or buffer. See Eli
9168 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9169
5e927815
PE
9170 * alloc.c (__malloc_size_t): Remove.
9171 All uses replaced by size_t. See Andreas Schwab's note
9172 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9173
ca4aa935
PE
9174 * image.c: Improve checking for integer overflow.
9175 (check_image_size): Assume that f is nonnull, since
9176 it is always nonnull in practice. This is one less thing to
9177 worry about when checking for integer overflow later.
9178 (x_check_image_size): New function, which checks for integer
9179 overflow issues inside X.
9180 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9181 This removes the need for a memory_full check.
9182 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9183 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9184 (xbm_read_bitmap_data): Change locals back to 'int', since
9185 their values must fit in 'int'.
9186 (xpm_load_image, png_load, tiff_load):
9187 Invoke x_create_x_image_and_pixmap earlier,
9188 to avoid much needless work if the image is too large.
9189 (tiff_load): Treat overly large images as if
9190 x_create_x_image_and_pixmap failed, not as malloc failures.
9191 (gs_load): Use x_check_image_size.
9192
5f8f9cc2
PE
9193 * gtkutil.c: Omit integer casts.
9194 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9195 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9196
5adf60bc
PE
9197 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9198
c8907a93
PE
9199 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9200 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9201 would wrongly return t on a 64-bit host.
9202
e3c25c68
PE
9203 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9204 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9205 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9206 and therefore cause GCC to emit a bogus diagnostic in some cases.
9207
3f791afe
PE
9208 * image.c: Integer signedness and overflow and related fixes.
9209 This is not an exhaustive set of fixes, but it's time to
9210 record what I've got.
9211 (lookup_pixel_color, check_image_size): Remove redundant decls.
9212 (check_image_size): Don't assume that arbitrary EMACS_INT values
9213 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9214 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9215 (tiff_load, imagemagick_load_image):
9216 Check for overflow in size calculations.
9217 (x_create_x_image_and_pixmap): Remove unnecessary test for
9218 xmalloc returning NULL; that can't happen.
9219 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9220 (xpm_color_bucket): Use better integer hashing function.
9221 (xpm_cache_color): Don't possibly over-allocate memory.
9222 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9223 (gif_memory_source):
9224 Use ptrdiff_t, not int or size_t, to record sizes.
9225 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9226 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9227 either works, as we prefer signed integers.
9228 (tiff_read_from_memory, tiff_write_from_memory):
9229 Return tsize_t, not size_t, since that's what the TIFF API wants.
9230 (tiff_read_from_memory): Don't fail simply because the read would
9231 go past EOF; instead, return a short read.
9232 (tiff_load): Omit no-longer-needed casts.
9233 (Fimagemagick_types): Don't assume size fits into 'int'.
9234
3cc5a532
PE
9235 Improve hashing quality when configured --with-wide-int.
9236 * fns.c (hash_string): New function, taken from sxhash_string.
9237 Do not discard information about ASCII character case; this
9238 discarding is no longer needed.
9239 (sxhash-string): Use it. Change sig to match it. Caller changed.
9240 * lisp.h: Declare it.
9241 * lread.c (hash_string): Remove, since we now use fns.c's version.
9242 The fns.c version returns a wider integer if --with-wide-int is
9243 specified, so this should help the quality of the hashing a bit.
9244
b312a492
PE
9245 * emacs.c: Integer overflow minor fix.
9246 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9247 Define only if GNU_LINUX.
9248 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9249
dfd153ae
PE
9250 * dispnew.c: Integer signedness and overflow fixes.
9251 Remove unnecessary forward decls, that were a maintenance hassle.
9252 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9253 All uses changed.
9254 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9255 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9256 (prepare_desired_row, line_draw_cost):
9257 Use int, not unsigned, where either works.
9258 (save_current_matrix, restore_current_matrix):
9259 Use ptrdiff_t, not size_t, where either works.
9260 (init_display): Check for overflow more accurately, and without
9261 relying on undefined behavior.
9262
a81d11a3
PE
9263 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9264 Remove, replacing with the new symbols in lisp.h. All uses changed.
9265 * fileio.c (make_temp_name):
9266 * filelock.c (lock_file_1, lock_file):
9267 * xdisp.c (message_dolog):
9268 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9269 Use pMd etc. instead.
9270 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9271 replacing the pWIDE etc. symbols removed from editfns.c.
9272
3300e6fd
PE
9273 * keyboard.h (num_input_events): Now uintmax_t.
9274 This is (very slightly) less likely to mess up due to wraparound.
9275 All uses changed.
9276
fd05c7e9
PE
9277 * buffer.c: Integer signedness fixes.
9278 (alloc_buffer_text, enlarge_buffer_text):
9279 Use ptrdiff_t rather than size_t when either will do, as we prefer
9280 signed integers.
9281
903fe15d
PE
9282 * alloc.c: Integer signedness and overflow fixes.
9283 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9284 (__malloc_size_t): Default to size_t, not to int.
9285 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9286 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9287 Prefer ptrdiff_t to size_t when either would do, as we prefer
9288 signed integers.
9289 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9290 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9291 Now const. Initialize with values that are in range even if char
9292 is signed.
9293 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9294 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9295 These functions do the right thing with sizes > 2**32.
9296 (check_depth): Now ptrdiff_t, not int.
9297 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9298 Adjust to new way of storing sizes. Check for size overflow bugs
9299 in rest of code.
9300 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9301 slightly wrong anyway, as it missed one instance of
9302 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9303 (refill_memory_reserve): Omit needless cast to size_t.
9304 (mark_object_loop_halt): Mark as externally visible.
9305
ac82cc6a
PE
9306 * xselect.c: Integer signedness and overflow fixes.
9307 (Fx_register_dnd_atom, x_handle_dnd_message):
9308 Use ptrdiff_t, not size_t, since we prefer signed.
9309 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9310 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9311 x_dnd_atoms_size and x_dnd_atoms_length.
9312
c2d1e36d
PE
9313 * doprnt.c: Prefer signed to unsigned when either works.
9314 * eval.c (verror):
9315 * doprnt.c (doprnt):
9316 * lisp.h (doprnt):
9317 * xdisp.c (vmessage):
9318 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9319 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9320 prefer signed arithmetic to avoid comparison confusion.
9321 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9322 but is a bit tricky.
9323
0e926e56
PE
9324 Assume freestanding C89 headers, string.h, stdlib.h.
9325 * data.c, doprnt.c, floatfns.c, print.c:
9326 Include float.h unconditionally.
9327 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9328 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9329 * regex.c: Likewise for stddef.h, string.h.
9330 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9331 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9332 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9333 (STDC_HEADERS): Remove obsolete defines.
9334 * sysdep.c: Include limits.h unconditionally.
9335
9cfdb3ec
PE
9336 Assume support for memcmp, memcpy, memmove, memset.
9337 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9338 * regex.c (memcmp, memcpy):
9339 Remove; we assume C89 now.
9340
9341 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9342 (__malloc_safe_bcopy): Remove; no longer needed.
9343
cf950e6b 9344 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9345 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9346 well either way, and we prefer signed to unsigned.
9347
dbf38e02
LMI
93482011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9349
9350 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9351 closes the connection while we're reading (bug#9182).
9352
d6f0886c 93532011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9354
d6f0886c
JD
9355 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9356 are specified (Bug#9168).
24e0f6b1 9357
2eb1f9e6
PE
93582011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9359
9360 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9361 Found by GCC static checking and --with-wide-int on a 32-bit host.
9362
22381272 93632011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9364
9365 * xdisp.c (compute_display_string_pos): Fix logic of caching
9366 previous display string position. Initialize cached_prev_pos to
9367 -1. Fixes slow-down at the beginning of a buffer.
9368
f25e39b4
EZ
93692011-07-24 Eli Zaretskii <eliz@gnu.org>
9370
9371 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9372 for attrs[LFACE_FONTSET_INDEX].
9373
04c4b52e
PE
93742011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9375
9376 * xml.c (parse_region): Remove unused local
9377 that was recently introduced.
9378
c1734fbd
EZ
93792011-07-23 Eli Zaretskii <eliz@gnu.org>
9380
be18c5a5
EZ
9381 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9382 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9383
c1734fbd
EZ
9384 * xdisp.c (move_it_in_display_line_to): Record the best matching
9385 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9386 exit if none of the characters scanned was an exact match.
9387 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9388 when exact match is impossible due to invisible text, and the
9389 lines are truncated.
9390
a258d627
JD
93912011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9392
9393 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9394 for OSX >= 10.7.
9395
b6d5a689
EZ
93962011-07-22 Eli Zaretskii <eliz@gnu.org>
9397
0f74f785
EZ
9398 Fix a significant slow-down of cursor motion with C-n, C-p,
9399 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9400 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9401 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9402 (next_element_from_buffer): Call compute_stop_pos_backwards to
9403 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9404 base_level_stop.
9405 (reseat): Don't look for prev_stop, as that could mean a very long
9406 run.
9407 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9408 <cached_disp_overlay_modiff>: Cache for last found display string
9409 position.
551918c1 9410 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9411 about the same buffer in the same area of character positions, and
9412 the buffer wasn't changed since the time the display string
9413 position was cached.
551918c1 9414
b2d0c91a
EZ
94152011-07-22 Eli Zaretskii <eliz@gnu.org>
9416
9417 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9418 is an integer, which is important for empty lines. (Bug#9149)
9419
043604ee
CY
94202011-07-22 Chong Yidong <cyd@stupidchicken.com>
9421
9422 * frame.c (Fmodify_frame_parameters): In tty case, update the
9423 default face if necessary (Bug#4238).
9424
da4adb04
CY
94252011-07-21 Chong Yidong <cyd@stupidchicken.com>
9426
9427 * editfns.c (Fstring_to_char): No need to explain what a character
9428 is in the docstring (Bug#6576).
9429
9abd0532
LMI
94302011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9431
9432 * xml.c (parse_region): Make sure we always return a tree.
9433
36881d16
HK
94342011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9435
9436 * xml.c (parse_region): If a document contains only comments,
9437 return that, too.
9438
1e98674d
LMI
94392011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9440
9441 * xml.c (make_dom): Return comments, too.
9442
590bd467
PE
94432011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9444
9445 Port to OpenBSD.
9446 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9447 and the surrounding thread.
9448 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9449 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9450 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9451 timer goes off.
9452 * s/openbsd.h (BROKEN_SIGIO): Define.
9453 * unexelf.c (unexec) [__OpenBSD__]:
9454 Don't update the .mdebug section of the Alpha COFF symbol table.
9455
f41628b2
LMI
94562011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9457
9458 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9459 (bug#8460).
9460
b59b67c5
PE
94612011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9462
15e3a074
PE
9463 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9464 This fixes some race conditions on the permissions of any newly
9465 created file.
9466
41bed37d
PE
9467 * alloc.c (valid_pointer_p): Use pipe, not open.
9468 This fixes some permissions issues when debugging.
9469
b59b67c5
PE
9470 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9471 If fchown fails to set both uid and gid, try to set just gid,
9472 as that is sometimes allowed. Adjust the file's mode to eliminate
9473 setuid or setgid bits that are inappropriate if fchown fails.
9474
925a6be7
SM
94752011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9476
9477 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9478 to compare Lisp_Objects.
9479 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9480 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9481 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9482
52968808
AS
94832011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9484
0a6a104b
AS
9485 * lread.c (read_integer): Unread even EOF character.
9486 (read1): Likewise. Properly record start position of symbol.
9487
52968808
AS
9488 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9489 symbol character follows.
9490
9e381cdd
PE
94912011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9492
9493 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9494 This works around a problem with the previous change to Fcopy_file.
9495 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9496 and without this change, GCC might complain about discarding
9497 fchown's return value.
9498
b5641435
JB
94992011-07-16 Juanma Barranquero <lekktu@gmail.com>
9500
9501 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9502
a8031457
PE
95032011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9504
9505 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9506
dd889327
LMI
95072011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9508
750c33f7
LMI
9509 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9510 it's used from the C level.
9511
dd889327
LMI
9512 * process.c: Use the same condition for POLL_FOR_INPUT in both
9513 keyboard.c and process.c (bug#1858).
9514
87e86684
LM
95152011-07-09 Lawrence Mitchell <wence@gmx.li>
9516
9517 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9518 (Fgnutls_boot): Use it.
9519
64348f40
AS
95202011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9521
9522 * doc.c (Fsubstitute_command_keys): Revert last change.
9523
1d698799
LMI
95242011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9525
f863868c
LMI
9526 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9527 quotes the next character, and doesn't affect other longer
9528 sequences (bug#8935).
9529
1d698799
LMI
9530 * lread.c (syms_of_lread): Clarify that is isn't only
9531 `eval-buffer' and `eval-defun' that's affected by
9532 `lexical-binding' (bug#8460).
9533
aa4b6df6
EZ
95342011-07-15 Eli Zaretskii <eliz@gnu.org>
9535
9536 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9537 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9538
5d856da6
PE
95392011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9540
ad6042bb
PE
9541 Fix minor problems found by static checking.
9542 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9543 (elsz): Now a signed constant, not a size_t var. We prefer signed
9544 types to unsigned, to avoid integer comparison confusion. Without
9545 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9546 "cannot optimize loop, the loop counter may overflow", a symptom
9547 of the confusion.
f00bbb22 9548 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9549 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9550
6468f31c
LMI
95512011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9552
49080b10
LMI
9553 * search.c (Fre_search_backward): Mention `case-fold-search' in
9554 all the re_search_* functions (bug#8138).
9555
6468f31c
LMI
9556 * keyboard.c (Fopen_dribble_file): Document when the file is
9557 closed (bug#8056).
9558
c965adc5
EZ
95592011-07-14 Eli Zaretskii <eliz@gnu.org>
9560
df9733bf
EZ
9561 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9562 bidi_cache_idx.
9563
0bb23927
EZ
9564 Support bidi reordering of display and overlay strings.
9565 * xdisp.c (compute_display_string_pos)
9566 (compute_display_string_end): Accept additional argument STRING.
9567 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9568 (reseat_to_string): Initialize bidi_it->string.s and
9569 bidi_it->string.schars.
9570 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9571 NULL (avoids a crash in bidi_paragraph_init).
9572 Initialize itb.string.lstring.
0bb23927
EZ
9573 (init_iterator): Call bidi_init_it only of a valid
9574 buffer position was specified. Initialize paragraph_embedding to
9575 L2R.
9576 (reseat_to_string): Initialize the bidi iterator.
9577 (display_string): If we need to ignore text properties of
9578 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9579 original value of -1 will not work with bidi.)
9580 (compute_display_string_pos): First arg is now struct
9581 `text_pos *'; all callers changed. Support display properties on
9582 Lisp strings.
9583 (compute_display_string_end): Support display properties on Lisp
9584 strings.
9585 (init_iterator, reseat_1, reseat_to_string): Initialize the
9586 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9587 when iterating on a string not from display properties).
640c8776
SM
9588 (compute_display_string_pos, compute_display_string_end):
9589 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9590 arrow keys.
9591 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9592 base_level_stop; instead, set base_level_stop to BEGV.
9593 Fixes crashes in vertical-motion.
0bb23927
EZ
9594 (next_element_from_buffer): Improve commentary for when
9595 the iterator is before prev_stop.
9596 (init_iterator): Initialize bidi_p from the default value of
9597 bidi-display-reordering, not from buffer-local value. Use the
9598 buffer-local value only if initializing for buffer iteration.
9599 (handle_invisible_prop): Support invisible properties on strings
9600 that are being bidi-reordered.
9601 (set_iterator_to_next): Support bidi reordering of C strings and
9602 Lisp strings.
9603 (next_element_from_string): Support bidi reordering of Lisp
9604 strings.
9605 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9606 (display_string): Support display of R2L glyph rows.
9607 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9608 (init_iterator): Don't initialize it->bidi_p for strings
9609 here.
9610 (reseat_to_string): Initialize it->bidi_p for strings here.
9611 (next_element_from_string, next_element_from_c_string)
9612 (next_element_from_buffer): Add xassert's for correspondence
9613 between IT's object being iterated and it->bidi_it.string
9614 structure.
9615 (face_before_or_after_it_pos): Support bidi iteration.
9616 (next_element_from_c_string): Handle the case of the first string
9617 character that is not the first one in the visual order.
9618 (get_visually_first_element): New function, refactored from common
9619 parts of next_element_from_buffer, next_element_from_string, and
9620 next_element_from_c_string.
9621 (tool_bar_lines_needed, redisplay_tool_bar)
9622 (display_menu_bar): Force left-to-right direction. Add a FIXME
9623 comment for making that be controlled by a user option.
9624 (push_it, pop_it): Save and restore the state of the
9625 bidi iterator. Save and restore the bidi_p flag.
9626 (pop_it): Iterate out of display property for string iteration as
9627 well.
9628 (iterate_out_of_display_property): Support iteration over strings.
9629 (handle_single_display_spec): Set up it->bidi_it for iteration
9630 over a display string, and call bidi_init_it.
9631 (handle_single_display_spec, next_overlay_string)
9632 (get_overlay_strings_1, push_display_prop): Set up the bidi
9633 iterator for displaying display or overlay strings.
9634 (forward_to_next_line_start): Don't use the shortcut if
9635 bidi-iterating.
9636 (back_to_previous_visible_line_start): If handle_display_prop
9637 pushed the iterator stack, restore the internal state of the bidi
9638 iterator by calling bidi_pop_it same number of times.
9639 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9640 and we are bidi-iterating, don't decrement the iterator position;
9641 instead, set the first_elt flag in the bidi iterator, to produce
9642 the same effect.
9643 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9644 (push_display_prop): xassert that we are iterating a buffer.
9645 (push_it, pop_it): Save and restore paragraph_embedding member.
9646 (handle_single_display_spec, next_overlay_string)
9647 (get_overlay_strings_1, reseat_1, reseat_to_string)
9648 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9649 correctly. Don't assume unibyte strings are not bidi-reordered.
9650 (compute_display_string_pos)
9651 (compute_display_string_end): Fix handling the case of C string.
9652 (push_it, pop_it): Save and restore from_disp_prop_p.
9653 (handle_single_display_spec, push_display_prop): Set the
9654 from_disp_prop_p flag.
9655 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9656 (pop_it): Call iterate_out_of_display_property only if we are
9657 popping after iteration over a string that came from a display
9658 property. Fix a typo in popping stretch info. Add an assertion
9659 for verifying that the iterator position is in sync with the bidi
9660 iterator.
9661 (handle_single_display_spec, get_overlay_strings_1)
9662 (push_display_prop): Fix initialization of paragraph direction for
9663 string when that of the parent object is not yet determined.
9664 (reseat_1): Call bidi_init_it to resync the bidi
9665 iterator with IT's position. (Bug#7616)
9666 (find_row_edges): If ROW->start.pos gives position
9667 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9668 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9669 Reset the from_disp_prop_p flag.
9670 (SAVE_IT, RESTORE_IT): New macros.
9671 (pos_visible_p, face_before_or_after_it_pos)
9672 (back_to_previous_visible_line_start)
9673 (move_it_in_display_line_to, move_it_in_display_line)
9674 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9675 (try_scrolling, redisplay_window, display_line): Use them when
9676 saving a temporary copy of the iterator and restoring it back.
9677 (back_to_previous_visible_line_start, reseat_1)
9678 (init_iterator): Empty the bidi cache "stack".
9679 (move_it_in_display_line_to): If iterator ended up at
9680 EOL, but we never saw any buffer positions smaller than
9681 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9682 motion in bidi-reordered lines.
9683 (move_it_in_display_line_to): Record prev_method and prev_pos
9684 immediately before the call to set_iterator_to_next. Fixes cursor
9685 motion in bidi-reordered lines with stretch glyphs and strings
9686 displayed in margins. (Bug#8133) (Bug#8867)
9687 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9688 TO_CHARPOS.
640c8776
SM
9689 (pos_visible_p): Support positions in bidi-reordered lines.
9690 Save and restore bidi cache.
0bb23927
EZ
9691
9692 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9693 (bidi_paragraph_info): Delete unused struct.
9694 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9695 (bidi_cache_start): New variable.
9696 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9697 to zero.
9698 (bidi_cache_fetch_state, bidi_cache_search)
9699 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9700 (bidi_cache_find, bidi_peek_at_next_level)
9701 (bidi_level_of_next_char, bidi_find_other_level_edge)
9702 (bidi_move_to_visually_next): Compare cache index with
9703 bidi_cache_start rather than with zero.
9704 (bidi_fetch_char): Accept new argument STRING; all callers
9705 changed. Support iteration over a string. Support strings with
9706 display properties. Support unibyte strings. Fix the type of
9707 `len' according to what STRING_CHAR_AND_LENGTH expects.
9708 (bidi_paragraph_init, bidi_resolve_explicit_1)
9709 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9710 (bidi_level_of_next_char, bidi_move_to_visually_next):
9711 Support iteration over a string.
0bb23927
EZ
9712 (bidi_set_sor_type, bidi_resolve_explicit_1)
9713 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9714 can now be zero (for strings); special values 0 and -1 were
9715 changed to -1 and -2, respectively.
9716 (bidi_char_at_pos): New function.
9717 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9718 Call it instead of FETCH_MULTIBYTE_CHAR.
9719 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9720 initialized to valid values.
9721 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9722 values.
9723 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9724 the test for valid cached positions. Fix the logic for looking up
9725 the sentinel state in the cache. GCPRO the Lisp string we are
9726 iterating.
9727 (bidi_push_it, bidi_pop_it): New functions.
9728 (bidi_initialize): Initialize the bidi cache start stack pointer.
9729 (bidi_cache_ensure_space): New function, refactored from part of
9730 bidi_cache_iterator_state. Don't assume the required size is just
9731 one BIDI_CACHE_CHUNK away.
9732 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9733 (bidi_count_bytes, bidi_char_at_pos): New functions.
9734 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9735 always valid if bidi_cache_idx is valid.
9736 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9737 is valid if it's going to be used.
9738 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9739 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9740 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9741 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9742 (bidi_find_other_level_edge, bidi_cache_start_stack):
9743 All variables related to cache indices are now EMACS_INT.
c965adc5 9744
0bb23927
EZ
9745 * dispextern.h (struct bidi_string_data): New structure.
9746 (struct bidi_it): New member `string'. Make flag members be 1-bit
9747 fields, and put them last in the struct.
640c8776
SM
9748 (compute_display_string_pos, compute_display_string_end):
9749 Update prototypes.
0bb23927
EZ
9750 (bidi_push_it, bidi_pop_it): Add prototypes.
9751 (struct iterator_stack_entry): New members bidi_p,
9752 paragraph_embedding, and from_disp_prop_p.
9753 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9754 (bidi_shelve_cache, bidi_unshelve_cache):
9755 Declare prototypes.
0bb23927
EZ
9756
9757 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9758 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9759 and vector-like objects.
9760
9761 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9762 cache around display iteration.
9763
9764 * window.c (Fwindow_end, window_scroll_pixel_based)
9765 (displayed_window_lines, Frecenter): Save and restore the bidi
9766 cache around display iteration.
9767
3bbd2265
LMI
97682011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9769
9770 * editfns.c (Fdelete_region): Clarify the use of the named
9771 parameters (bug#6788).
9772
adc47434
MR
97732011-07-14 Martin Rudalics <rudalics@gmx.at>
9774
9775 * indent.c (Fvertical_motion): Set and restore w->pointm when
9776 saving and restoring the window's buffer (Bug#9006).
9777
837c31f8
LMI
97782011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9779
9780 * editfns.c (Fstring_to_char): Clarify just what is returned
9781 (bug#6576). Text by Eli Zaretskii.
9782
ac389d0c
JB
97832011-07-13 Juanma Barranquero <lekktu@gmail.com>
9784
9785 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9786
0be0ce47
EZ
97872011-07-13 Eli Zaretskii <eliz@gnu.org>
9788
9789 * buffer.c (mmap_find): Fix a typo.
9790
cd18e7e3
JB
97912011-07-13 Johan Bockgård <bojohan@gnu.org>
9792
9793 Fix execution of x selection hooks.
9794 * xselect.c (Qx_lost_selection_functions)
9795 (Qx_sent_selection_functions): New vars.
9796 (syms_of_xselect): DEFSYM them.
9797 (x_handle_selection_request): Pass Qx_sent_selection_functions
9798 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9799 (x_handle_selection_clear,x_clear_frame_selections):
9800 Pass Qx_lost_selection_functions rather than
9801 Vx_lost_selection_functions to Frun_hook_with_args.
9802
47ea7f44
PE
98032011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9804
ac389d0c 9805 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9806 The old code sometimes used this field without initializing it.
9807
47ea7f44
PE
9808 * alloc.c (gc_sweep): Don't read past end of array.
9809 In theory, the old code could also have corrupted Emacs internals,
9810 though it'd be very unlikely.
9811
bc985c87
AS
98122011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9813
9814 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9815 argument. (Bug#4026)
bc985c87 9816
0cf34688
LMI
98172011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9818
b3dadd76
LMI
9819 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9820 key" (bug#4257).
9821
0cf34688
LMI
9822 * window.c (Fset_window_start): Doc fix (bug#4199).
9823 (Fset_window_hscroll): Ditto.
9824
270768cd
PE
98252011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9826
077e3dda 9827 Fix minor new problems caught by GCC 4.6.1.
270768cd 9828 * term.c (init_tty): Remove unused local.
490011a6 9829 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9830 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9831 not used otherwise.
270768cd 9832
b1f58454
CY
98332011-07-12 Chong Yidong <cyd@stupidchicken.com>
9834
9835 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9836
22b9578d
LMI
98372011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9838
6e70ab07
LMI
9839 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9840 are the mini-buffer and the echo area (bug#3320).
9841
22b9578d
LMI
9842 * term.c (init_tty): Remove support for supdup, c10 and perq
9843 terminals, which are no longer supported (bug#1482).
9844
8974cc9f
JB
98452011-07-10 Johan Bockgård <bojohan@gnu.org>
9846
9847 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9848
a560d974
JD
98492011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9850
9851 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9852 for non-popups (Bug#3642).
9853
1dae0f0a
AS
98542011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9855
268c2c36 9856 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9857 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9858 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9859 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9860 * data.c (fmod): Likewise.
9861 * dispnew.c (swap_glyphs_in_rows): Likewise.
9862 * emacs.c (memory_warning_signal): Likewise.
9863 * floatfns.c (float_error): Likewise.
9864 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9865 (otf_open, font_otf_capability, generate_otf_features)
9866 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9867 Likewise.
9868 * image.c (pbm_read_file): Likewise.
9869 * indent.c (string_display_width): Likewise.
9870 * intervals.c (check_for_interval, search_for_interval)
9871 (inc_interval_count, count_intervals, root_interval)
9872 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9873 * lread.c (defalias): Likewise.
268c2c36 9874 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9875 * regex.c (set_image_of_range_1, set_image_of_range)
9876 (regex_grow_registers): Likewise.
9877 * sysdep.c (strerror): Likewise.
9878 * termcap.c (valid_filename_p, tprint, main): Likewise.
9879 * tparam.c (main): Likewise.
9880 * unexhp9k800.c (run_time_remap, save_data_space)
9881 (update_file_ptrs, read_header, write_header, calculate_checksum)
9882 (copy_file, copy_rest, display_header): Likewise.
9883 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9884 Likewise.
9885 * xdisp.c (check_it): Likewise.
9886 * xfaces.c (register_color, unregister_color, unregister_colors):
9887 Likewise.
9888 * xfns.c (print_fontset_result): Likewise.
9889 * xrdb.c (member, fatal, main): Likewise.
9890
99033785
PE
98912011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9892
9893 Fix minor problems found by static checking (Bug#9031).
9894 * chartab.c (char_table_set_range, map_sub_char_table):
9895 Remove unused locals.
9896 (uniprop_table): Now static.
9897 * composite.c (_work_char): Remove unused static var.
9898
9cb2ac56
JB
98992011-07-09 Juanma Barranquero <lekktu@gmail.com>
9900
9901 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9902
f25661f0
JD
99032011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9904
9905 * gtkutil.c (qttip_cb): Remove code without function.
9906
8278c4fe
EZ
99072011-07-09 Eli Zaretskii <eliz@gnu.org>
9908
9909 * w32.c (pthread_sigmask): New stub.
9910
1692ae2d 99112011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9912
8a6ebd58 9913 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9914 sigprocmask is portable only for single-threaded applications, and
9915 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9916 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9917 (LIBES): Use it.
9918 * callproc.c (Fcall_process):
9919 * process.c (create_process):
9920 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9921 Use pthread_sigmask, not sigprocmask.
123403e4 9922
1b854618
JD
99232011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9924
9925 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9926 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9927 wrong (Bug#8591).
9928
3fe4b549
JD
99292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9930
0ce7e563
JD
9931 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9932 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9933 (xg_hide_tooltip): Fix comment.
9934
3fe4b549
JD
9935 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9936 in registerServicesMenuSendTypes.
9937 (validRequestorForSendType): Don't check ns_return_types.
9938
9939 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9940 ns_return_type.
9941
5df75e47
JR
99422011-07-08 Jason Rumney <jasonr@gnu.org>
9943
22610910
JR
9944 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9945 SH_SHOW for hidden windows (Bug#5482).
9946
5df75e47
JR
9947 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9948 frame struct members of non-existent frames (Bug#6284).
9949
699c10bd
JD
99502011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9951
4393663b
JD
9952 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9953 variable firstTime not needed on OSX >= 10.6.
9954 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9955 >= 10.5. Use setKnobProportion, setDoubleValue.
9956
9957 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9958 (MAC_OS_X_VERSION_10_5): Define if not defined.
9959 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9960 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9961 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9962
9963 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9964 cString and lossyCString on OSX >= 10.4.
4393663b 9965
58179cce 9966 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9967 sizeToFit on OSX >= 10.2.
9968
9969 * nsimage.m (allocInitFromFile): Don't use deprecated method
9970 bestRepresentationForDevice on OSX >= 10.6.
9971
9972 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9973 to avoid warning.
9974
9975 * emacs.c: Declare unexec_init_emacs_zone.
9976
a63e0781
JD
9977 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9978
699c10bd
JD
9979 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9980
9981 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9982 on svcsMenu (Bug#8842).
9983
9984 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9985 ns_return_types.
9986 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9987
9988 * nsterm.m (QUTF8_STRING): Declare.
9989 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9990 (validRequestorForSendType): Return type is (id).
9991 Change indexOfObjectIdenticalTo to indexOfObject.
9992 Check if we have local selection before returning self (Bug#8842).
9993 (writeSelectionToPasteboard): Put local selection into paste board
9994 if we have a local selection (Bug#8842).
9995 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9996
9997 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9998 (ns_get_local_selection): Declare.
9999
54e10184
LMI
100002011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
10001
9888ff71
LMI
10002 * keymap.c (describe_map_tree): Don't insert a double newline at
10003 the end of the buffer (bug#1169) and return whether we inserted
10004 something.
10005
54e10184
LMI
10006 * callint.c (Fcall_interactively): Change "reading args" to
10007 "providing args" to try to clarify what it does (bug#1010).
10008
15fa4783
KH
100092011-07-07 Kenichi Handa <handa@m17n.org>
10010
10011 * composite.c (composition_compute_stop_pos): Ignore a static
10012 composition starting before CHARPOS (Bug#8915).
10013
10014 * xdisp.c (handle_composition_prop): Likewise.
10015
a8815b00
EZ
100162011-07-07 Eli Zaretskii <eliz@gnu.org>
10017
10018 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10019 (Bug#9015)
10020
ef7b981d 100212011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10022
10023 * character.h (unicode_category_t): New enum type.
10024
10025 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10026 (Qchar_code_property_table): New variable.
10027 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10028 (UNIPROP_COMPRESSED_FORM_P): New macros.
10029 (char_table_ascii): Uncompress the compressed values.
10030 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10031 Uncompress the compressed values.
ac389d0c 10032 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10033 (char_table_ref_and_range): Uncompress the compressed values.
10034 (sub_char_table_set): New arg is_uniprop. Callers changed.
10035 Uncompress the compressed values.
10036 (sub_char_table_set_range): Args changed. Callers changed.
10037 (char_table_set_range): Adjuted for the above change.
10038 (map_sub_char_table): Delete args default_val and parent. Add arg
10039 top. Give decoded values to a Lisp function.
640c8776 10040 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10041 values to a Lisp function. Gcpro more variables.
10042 (uniprop_table_uncompress)
10043 (uniprop_decode_value_run_length): New functions.
10044 (uniprop_decoder, uniprop_decoder_count): New variables.
10045 (uniprop_get_decoder, uniprop_encode_value_character)
10046 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10047 New functions.
10048 (uniprop_encoder, uniprop_encoder_count): New variables.
10049 (uniprop_get_encoder, uniprop_table)
10050 (Funicode_property_table_internal, Fget_unicode_property_internal)
10051 (Fput_unicode_property_internal): New functions.
10052 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10053 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10054 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10055 char-code-property-alist.
10056
640c8776 10057 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10058 Vunicode_category_table.
10059
640c8776 10060 * font.c (font_range): Adjust for the change of
c805dec0
KH
10061 Vunicode_category_table.
10062
76b397fb
DN
100632011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10064
10065 * m/iris4d.h: Remove file, move contents ...
10066 * s/irix6-5.h: ... here.
10067
22b4128e
PE
100682011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10069
10070 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10071 * alloc.c (mark_buffer):
10072 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10073 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10074 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10075 This isn't true in general, and it's particularly not true
10076 if Emacs is configured with --with-wide-int.
10077 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10078 New macros, used in the buffer.c change.
10079
869795d6
JD
100802011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10081
10082 * xsettings.c: Use both GConf and GSettings if both are available.
10083 (store_config_changed_event): Add comment.
10084 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10085 (store_tool_bar_style_changed): New functions.
5e617bc2 10086 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10087 (struct xsettings): Move font inside HAVE_XFT.
10088 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10089 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10090 Move inside HAVE_XFT.
640c8776 10091 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10092 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10093 also.
10094 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10095 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10096 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10097 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10098 (parse_settings): Move check for font inside HAVE_XFT.
10099 (read_settings, apply_xft_settings): Add comment.
10100 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10101 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10102 call store_font_name_changed.
10103 (xft_settings_event): Add comment.
10104 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10105 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10106 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10107 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10108 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10109 (xsettings_get_system_font, xsettings_get_system_normal_font):
10110 Add comment.
869795d6 10111
d8ed26bd
PE
101122011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10113
10114 Random fixes. E.g., (random) never returned negative values.
10115 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10116 subseconds part to the entropy, as that's a bit more random.
10117 Prefer signed to unsigned, since the signedness doesn't matter and
10118 in general we prefer signed. When given a limit, use a
10119 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10120 latter isn't right if USE_2_TAGS_FOR_INTS.
10121 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10122 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10123
cabf1cac
SM
101242011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10125
10126 * textprop.c (text_property_stickiness):
10127 Obey Vtext_property_default_nonsticky.
10128 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10129 * w32fns.c (syms_of_w32fns):
10130 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10131
6e9b2be9
PE
101322011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10133
10134 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10135 This is more efficient than Ffile_directory_p and avoids a minor race.
10136
90186c68
LMI
101372011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10138
7c301272
LMI
10139 * buffer.c (Foverlay_put): Say what the return value is
10140 (bug#7835).
10141
c4f2d8d4
LMI
10142 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10143 is a directory before asking whether to use the file name
10144 (bug#7564).
ad637907
LMI
10145 (barf_or_query_if_file_exists): Make the "File is a directory"
10146 error be more correct.
c4f2d8d4 10147
90186c68
LMI
10148 * fns.c (Frequire): Remove the mention of the .gz files, since
10149 that's installation-specific, but keep the mention of
10150 `get-load-suffixes'.
10151
da64016e
PE
101522011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10153
10154 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10155 Report string overflow if the output is too long.
10156
7d47b580
JB
101572011-07-04 Juanma Barranquero <lekktu@gmail.com>
10158
a555cb87
JB
10159 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10160 (syms_of_gnutls): Remove duplicate DEFSYM for
10161 Qgnutls_bootprop_verify_hostname_error, an error for
10162 Qgnutls_bootprop_verify_error (which is no longer used).
10163
7d47b580
JB
10164 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10165 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10166 Also (re)move comments that are misplaced or no longer relevant.
10167
1e49bfab
LMI
101682011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10169
10170 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10171
1485f4c0
CY
101722011-07-03 Chong Yidong <cyd@stupidchicken.com>
10173
10174 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10175 and background color parameters if they have been changed.
10176
a9ab721e
LMI
101772011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10178
10179 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10180
cf7cff57
PE
101812011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10182
2e13213d
PE
10183 * xsettings.c (SYSTEM_FONT): Define only when used.
10184 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10185
cf7cff57
PE
10186 * keymap.c (access_keymap_1): Now static.
10187
7a8e04f7
CY
101882011-07-02 Chong Yidong <cyd@stupidchicken.com>
10189
10190 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10191 leave any prefix arg for the up event (Bug#1586).
10192
61352f62
LMI
101932011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10194
69bb1ef7
LMI
10195 * lread.c (syms_of_lread): Mention single symbols defined by
10196 `defvar' or `defconst' (bug#7154).
10197
61352f62 10198 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10199 (Frequire): Mention get-load-suffixes.
61352f62 10200
28545e04
MR
102012011-07-02 Martin Rudalics <rudalics@gmx.at>
10202
10203 * window.h (window): Remove clone_number slot.
10204 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10205 Remove.
10206 (make_parent_window, make_window, saved_window)
10207 (Fset_window_configuration, save_window_save): Don't deal with
10208 clone numbers.
10209 * buffer.c (Qclone_number): Remove declaration.
10210 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10211
3349e122
SM
102122011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10213
10214 Add multiple inheritance to keymaps.
10215 * keymap.c (Fmake_composed_keymap): New function.
10216 (Fset_keymap_parent): Simplify.
10217 (fix_submap_inheritance): Remove.
10218 (access_keymap_1): New function extracted from access_keymap to handle
10219 embedded parents and handle lists of maps.
10220 (access_keymap): Use it.
10221 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10222 (Fcopy_keymap): Handle embedded parents.
10223 (Fcommand_remapping, define_as_prefix): Simplify.
10224 (Fkey_binding): Simplify.
10225 (syms_of_keymap): Move minibuffer-local-completion-map,
10226 minibuffer-local-filename-completion-map,
10227 minibuffer-local-must-match-map, and
10228 minibuffer-local-filename-must-match-map to Elisp.
10229 (syms_of_keymap): Defsubr make-composed-keymap.
10230 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10231 (parse_menu_item): Trivial simplification.
10232
3279eb87
GM
102332011-07-01 Glenn Morris <rgm@gnu.org>
10234
10235 * Makefile.in (SETTINGS_LIBS): Fix typo.
10236
39cb9e56 102372011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10238
10239 * coding.c (Fencode_coding_string): Record the last coding system
10240 used, as the function doc string says (bug#8738).
10241
0949d2b6
JD
102422011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10243
10244 * xsettings.c (store_monospaced_changed): Take new font as arg and
10245 check for change against current_mono_font.
10246 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10247 (emacs_settings_constructor, emacs_settings_get_property)
10248 (emacs_settings_set_property, emacs_settings_class_init)
10249 (emacs_settings_init, gsettings_obj): Remove.
10250 (something_changedCB): New function for HAVE_GSETTINGS.
10251 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10252 with value as argument.
10253 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10254 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10255 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10256 "changed".
10257
10258 * xgselect.c: Add defined (HAVE_GSETTINGS).
10259 (xgselect_initialize): Ditto.
10260
10261 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10262 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10263 xg_select.
10264
bbc6b304
PE
102652011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10266
10267 * eval.c (struct backtrace): Simplify and port the data structure.
10268 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10269 signed bit field, as this assumption is not portable and it makes
10270 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10271 "char debug_on_exit : 1" as this is not portable either; instead,
10272 use the portable "unsigned int debug_on_exit : 1". Remove unused
10273 member evalargs. Remove obsolete comments about cc bombing out.
10274
9851bfc5
JD
102752011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10276
51bb811f 10277 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10278 Let HAVE_GSETTINGS override HAVE_GCONF.
10279 (store_monospaced_changed): New function.
10280 (EMACS_SETTINGS): A new type derived from GObject to handle
10281 GSettings notifications.
10282 (emacs_settings_constructor, emacs_settings_get_property)
10283 (emacs_settings_set_property, emacs_settings_class_init):
10284 New functions.
10285 (gsettings_client, gsettings_obj): New variables.
10286 (GSETTINGS_SCHEMA): New define.
10287 (something_changedCB): Call store_monospaced_changed.
10288 (init_gsettings): New function.
10289 (xsettings_initialize): Call init_gsettings.
10290 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10291 to NULL.
10292
640c8776 10293 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10294 GCONF_CFLAGS/LIBS.
10295
5386012d
MR
102962011-06-29 Martin Rudalics <rudalics@gmx.at>
10297
10298 * window.c (resize_root_window, grow_mini_window)
10299 (shrink_mini_window): Rename Qresize_root_window to
10300 Qwindow_resize_root_window and Qresize_root_window_vertically to
10301 Qwindow_resize_root_window_vertically.
10302
f13e0b08
PE
103032011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10304
10305 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10306
94515237
JB
103072011-06-27 Juanma Barranquero <lekktu@gmail.com>
10308
10309 * makefile.w32-in: Redesign dependencies so they reflect more
10310 clearly which files are directly included by each source file,
10311 and not through other includes.
10312
e43b6e43
MR
103132011-06-27 Martin Rudalics <rudalics@gmx.at>
10314
10315 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10316 (sort_overlays, overlay_strings): When an overlay's clone number
10317 matches the window's clone number process the overlay even if
10318 the overlay's window property doesn't match the current window.
10319
d68443dc
MR
10320 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10321 (Fwindow_hchild): Rename to Fwindow_left_child.
10322 (Fwindow_next): Rename to Fwindow_next_sibling.
10323 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10324 (resize_window_check): Rename to window_resize_check.
10325 (resize_window_apply): Rename to window_resize_apply.
10326 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10327 (Fdelete_other_windows_internal, resize_frame_windows)
10328 (Fsplit_window_internal, Fdelete_window_internal)
10329 (grow_mini_window, shrink_mini_window)
10330 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10331
c7e73be5
JD
103322011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10333
10334 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10335 (emacs_fixed_set_min_size): Remove.
10336 (emacs_fixed_new): Take frame as argument.
10337
10338 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10339 (_EmacsFixedPrivate): Remove minwidth/height.
10340 Add struct frame *f.
10341 (emacs_fixed_init): Initialize priv->f.
10342 (get_parent_class, emacs_fixed_set_min_size): Remove.
10343 (emacs_fixed_new): Set priv->f to argument.
10344 (emacs_fixed_get_preferred_width)
10345 (emacs_fixed_get_preferred_height): Use min_width/height from
10346 frames size_hint to set minimum and natural (Bug#8919).
10347 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10348 and use min_width/height from frames size_hint to set
10349 min_width/height (Bug#8919).
10350
10351 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10352 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10353 Fix indentation.
c7e73be5 10354
cf99dcf8
EZ
103552011-06-26 Eli Zaretskii <eliz@gnu.org>
10356
10357 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10358 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10359 called at ZV.
10360
029529ac
CY
103612011-06-26 Chong Yidong <cyd@stupidchicken.com>
10362
10363 * process.c (wait_reading_process_output): Bypass select if
10364 waiting for a cell while ignoring keyboard input, and input is
10365 pending. Suggested by Jan Djärv (Bug#8869).
10366
7a7ef429
PE
103672011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10368
10369 Use gnulib's dup2 module instead of rolling our own.
10370 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10371
11fdef7d 103722011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10373
10374 * dispnew.c (scrolling_window): Before scrolling, turn off a
10375 mouse-highlight in the window being scrolled.
10376
cd3520a4
JB
103772011-06-24 Juanma Barranquero <lekktu@gmail.com>
10378
10379 Move DEFSYM to lisp.h and use everywhere.
10380
10381 * character.h (DEFSYM): Move declaration...
10382 * lisp.h (DEFSYM): ...here.
10383
10384 * gnutls.c:
10385 * minibuf.c:
10386 * w32menu.c:
10387 * w32proc.c:
10388 * w32select.c: Don't include character.h.
10389
10390 * alloc.c (syms_of_alloc):
10391 * buffer.c (syms_of_buffer):
10392 * bytecode.c (syms_of_bytecode):
10393 * callint.c (syms_of_callint):
10394 * casefiddle.c (syms_of_casefiddle):
10395 * casetab.c (init_casetab_once):
10396 * category.c (init_category_once, syms_of_category):
10397 * ccl.c (syms_of_ccl):
10398 * cmds.c (syms_of_cmds):
10399 * composite.c (syms_of_composite):
10400 * dbusbind.c (syms_of_dbusbind):
10401 * dired.c (syms_of_dired):
10402 * dispnew.c (syms_of_display):
10403 * doc.c (syms_of_doc):
10404 * editfns.c (syms_of_editfns):
10405 * emacs.c (syms_of_emacs):
10406 * eval.c (syms_of_eval):
10407 * fileio.c (syms_of_fileio):
10408 * fns.c (syms_of_fns):
10409 * frame.c (syms_of_frame):
10410 * fringe.c (syms_of_fringe):
10411 * insdel.c (syms_of_insdel):
10412 * keymap.c (syms_of_keymap):
10413 * lread.c (init_obarray, syms_of_lread):
10414 * macros.c (syms_of_macros):
10415 * msdos.c (syms_of_msdos):
10416 * print.c (syms_of_print):
10417 * process.c (syms_of_process):
10418 * search.c (syms_of_search):
10419 * sound.c (syms_of_sound):
10420 * syntax.c (init_syntax_once, syms_of_syntax):
10421 * terminal.c (syms_of_terminal):
10422 * textprop.c (syms_of_textprop):
10423 * undo.c (syms_of_undo):
10424 * w32.c (globals_of_w32):
10425 * window.c (syms_of_window):
10426 * xdisp.c (syms_of_xdisp):
10427 * xfaces.c (syms_of_xfaces):
10428 * xfns.c (syms_of_xfns):
10429 * xmenu.c (syms_of_xmenu):
10430 * xsettings.c (syms_of_xsettings):
10431 * xterm.c (syms_of_xterm): Use DEFSYM.
10432
4228cf16
TZ
104332011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10434
cd3520a4 10435 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10436
7fcccf1e
PE
104372011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10438
7efb4e0e
PE
10439 Integer and buffer overflow fixes (Bug#8873).
10440
ff5844ad
PE
10441 * print.c (printchar, strout): Check for string overflow.
10442 (PRINTPREPARE, printchar, strout):
10443 Don't set size unless allocation succeeds.
10444
90532f02
PE
10445 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10446 for sizes. Check for string overflow more accurately.
10447 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10448
6d84508d
PE
10449 * macros.c: Integer and buffer overflow fixes.
10450 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10451 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10452 Use ptrdiff_t, not int, for sizes.
10453 Don't increment bufsize until after realloc succeeds.
10454 Check for size-calculation overflow.
10455 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10456
437b2cb4
PE
10457 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10458
8b9ac8b4
PE
10459 * lread.c: Integer overflow fixes.
10460 (read_integer): Radix is now EMACS_INT, not int,
10461 to improve quality of diagnostics for out-of-range radices.
10462 Calculate buffer size correctly for out-of-range radices.
10463 (read1): Check for integer overflow in radices, and in
10464 read-circle numbers.
82cb60d3
PE
10465 (read_escape): Avoid int overflow.
10466 (Fload, openp, read_buffer_size, read1)
10467 (substitute_object_recurse, read_vector, read_list, map_obarray):
10468 Use ptrdiff_t, not int, for sizes.
10469 (read1): Use EMACS_INT, not int, for sizes.
20270765 10470 Check for size overflow.
8b9ac8b4 10471
7fcccf1e
PE
10472 * image.c (cache_image): Check for size arithmetic overflow.
10473
bfbbd7e7
PE
10474 * lread.c: Integer overflow issues.
10475 (saved_doc_string_size, saved_doc_string_length)
10476 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10477 Now ptrdiff_t, not int.
10478 (read1): Don't assume doc string length fits in int. Check for
10479 out-of-range doc string lengths.
10480 (read_list): Don't assume file position fits in int.
39019e54 10481 (read_escape): Check for hex character overflow.
bfbbd7e7 10482
4e323265
LL
104832011-06-22 Leo Liu <sdl.web@gmail.com>
10484
10485 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10486 Move to minibuffer.el.
10487
85fece3e
PE
104882011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10489
20b84ce9 10490 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10491 The following patches are for when GLYPH_DEBUG && !XASSERT.
10492 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10493 * dispnew.c (flush_stdout):
10494 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10495 Mark as externally visible.
10496 * dispnew.c (check_window_matrix_pointers): Now static.
10497 * dispnew.c (window_to_frame_vpos):
10498 * xfns.c (unwind_create_frame):
10499 * xterm.c (x_check_font): Remove unused local.
10500 * scroll.c (CHECK_BOUNDS):
10501 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10502 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10503 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10504 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10505 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10506 Now static.
10507 (debug_method_add): Use va_list and vsprintf rather than relying
10508 on undefined behavior with wrong number of arguments.
10509 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10510 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10511 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10512 since we're not interested in debugging glyphs with old libraries.
10513 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10514 GCC 4.6.0's static checking.
10515
0766b489
PE
105162011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10517
31fd4b32
PE
10518 Integer overflow and signedness fixes (Bug#8873).
10519 A few related buffer overrun fixes, too.
10520
b79e8648
PE
10521 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10522
0766b489
PE
10523 * dispextern.h (struct face.stipple):
10524 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10525 (x_bitmap_mask, x_allocate_bitmap_record)
10526 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10527 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10528 (x_create_bitmap_from_xpm_data):
10529 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10530 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10531 (.bitmaps_last):
10532 * xfaces.c (load_pixmap):
10533 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10534 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10535 (.bitmaps_last, struct x_output.icon_bitmap):
10536 Use ptrdiff_t, not int, for bitmap indexes.
10537 (x_allocate_bitmap_record): Check for size overflow.
10538 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10539
b081724f
PE
10540 Use ptrdiff_t, not int, for overlay counts.
10541 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10542 * editfns.c (overlays_around, get_pos_property):
10543 * textprop.c (get_char_property_and_overlay):
10544 * xdisp.c (next_overlay_change, note_mouse_highlight):
10545 * xfaces.c (face_at_buffer_position):
21514da7
PE
10546 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10547 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10548 (Fnext_overlay_change, Fprevious_overlay_change)
10549 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10550 Use ptrdiff_t, not int, for sizes.
21514da7 10551 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10552
3de73e5e
PE
10553 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10554
2606c57b
PE
10555 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10556 (x_session_initialize): Do not assume string length fits in int.
10557
aaafe47a
PE
10558 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10559 This is unlikely, but can occur if DPI is outlandish.
10560
2674ddc8 10561 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10562 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10563
28154962
PE
10564 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10565 * xrdb.c (magic_file_p, search_magic_path):
10566 Omit last arg SUFFIX; it was always 0. All callers changed.
10567 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10568
7de51af5
PE
10569 * xfont.c (xfont_match): Avoid need for strlen.
10570
25ed6cc3
PE
10571 * xfns.c: Don't assume strlen fits in int.
10572 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10573
4eab31dd
PE
10574 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10575 not unsigned long, as we prefer signed integers. All callers changed.
10576 Detect integer overflow in repeat count.
10577 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10578 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10579
171e2a58
PE
10580 * termcap.c: Don't assume sizes fit in int and never overflow.
10581 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10582 (gobble_line): Check for size-calculation overflow.
10583
ad39faca 10584 * minibuf.c (Fread_buffer):
6e5bb2dc 10585 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10586 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10587 Don't assume string length fits in int.
10588
52c61c22 10589 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10590 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10591
b5b8c9e5
PE
10592 * font.c: Don't assume string length fits in int.
10593 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10594 Use ptrdiff_t, not int.
ccd6111c
PE
10595 (font_intern_prop): Don't assume string length fits in int.
10596 Don't assume integer property fits in fixnum.
10597 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10598
882f0d81 10599 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10600 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10601 Reformulate so as not to need the command string.
10602 Invoke gzip -cd rather than gunzip, as it's more portable.
10603 (lock_info_type, lock_file_1, lock_file):
10604 Don't assume pid_t and time_t fit in unsigned long.
10605 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10606 (current_lock_owner): Prefer signed type for sizes.
10607 Use memcpy, not strncpy, where memcpy is what is really wanted.
10608 Don't assume (via atoi) that time_t and pid_t fit in int.
10609 Check for time_t and/or pid_t out of range, e.g., via a network share.
10610 Don't alloca where an auto var works fine.
10611
93f4cf88
PE
10612 * fileio.c: Fix some integer overflow issues.
10613 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10614 Don't assume string length fits in int.
10615 (directory_file_name): Don't assume string length fits in long.
10616 (make_temp_name): Don't assume pid fits in int, or that its print
10617 length is less than 20.
10618
f3e92b69
PE
10619 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10620
1bfdaf10
PE
10621 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10622
35016e9a
PE
10623 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10624
3d1e65a1
PE
10625 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10626 We prefer signed integers, even for size calculations.
10627
0b963a93
PE
10628 * emacs.c: Don't assume string length fits in 'int'.
10629 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10630 (main): Don't invoke strlen when not needed.
10631
573f4b54
PE
10632 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10633 (XD_DEBUG_MESSAGE): Don't waste a byte.
10634
989f33ba
PE
10635 * callproc.c (getenv_internal_1, getenv_internal)
10636 (Fgetenv_internal):
965d34eb
PE
10637 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10638
e4d29b33
PE
10639 * lread.c (invalid_syntax): Omit length argument.
10640 All uses changed. This doesn't fix a bug, but it simplifies the
10641 code away from its former Hollerith-constant appearance, and it's
10642 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10643 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10644
eb49b136
PE
10645 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10646 This didn't break anything, but it didn't help either.
10647 It's confusing to put a bogus integer in a place where the actual
10648 value does not matter.
9f62aeb1 10649 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10650 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10651
15375a22
PE
10652 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10653 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10654 implementation.
b61cc01c
PE
10655 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10656 We prefer signed types, and the value cannot exceed the EMACS_INT
10657 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10658 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10659 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10660 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10661
53b2623d
PE
10662 * indent.c (sane_tab_width): New function.
10663 (current_column, scan_for_column, Findent_to, position_indentation)
10664 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10665 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10666
51cab52b 10667 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10668
f2ed8a70
PE
10669 * lisp.h (lint_assume): New macro.
10670 * composite.c (composition_gstring_put_cache):
10671 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10672
abe80cc6
PE
10673 * editfns.c, insdel.c:
10674 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10675
b02c740e
PE
10676 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10677
ebc96716
PE
10678 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10679
b4e50fa0 10680 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10681 Use much-faster test for byte-length change.
311d5d7c 10682 Don't assume string byte-length fits in 'int'.
a4cf38e4 10683 Check that character arg fits in 'int'.
85461888 10684 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10685
c0c1ee9f
PE
10686 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10687
a498d7f4
PE
10688 * fns.c (concat): Catch string overflow earlier.
10689 Do not rely on integer wraparound.
10690
51cab52b
PE
10691 * dispextern.h (struct it.overlay_strings_charpos)
10692 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10693 * xdisp.c (forward_to_next_line_start)
10694 (back_to_previous_visible_line_start)
10695 (reseat_at_next_visible_line_start, next_element_from_buffer):
10696 Don't arbitrarily truncate the value of 'selective' to int.
10697
76031fad
PE
10698 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10699
5eb55db9
PE
10700 * composite.c: Don't truncate sizes to 'int'.
10701 (composition_gstring_p, composition_reseat_it)
10702 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10703 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10704 not EMACS_UINT, for indexes.
5eb55db9 10705
0703a717
PE
10706 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10707
d6202519
PE
10708 * buffer.c: Include <verify.h>.
10709 (struct sortvec.priority, struct sortstr.priority):
8961a454 10710 Now EMACS_INT, not int.
c20998a7 10711 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10712 (struct sortstr.size, record_overlay_string)
10713 (struct sortstrlist.size, struct sortlist.used):
10714 Don't truncate size to int.
10715 (record_overlay_string): Check for size-calculation overflow.
d6202519 10716 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10717
d5a19415
JM
107182011-06-22 Jim Meyering <meyering@redhat.com>
10719
029529ac 10720 Don't leak an XBM-image-sized buffer
d5a19415
JM
10721 * image.c (xbm_load): Free the image buffer after using it.
10722
a9041e6c
PE
107232011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10724
10725 Port to Sun C.
10726 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10727 that Sun C diagnosed.
10728 * fns.c (secure_hash): Fix pointer signedness issue.
10729 * intervals.c (static_offset_intervals): New function.
10730 (offset_intervals): Use it.
10731
7f3f739f
LL
107322011-06-21 Leo Liu <sdl.web@gmail.com>
10733
10734 * deps.mk (fns.o):
10735 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10736 sha512.h.
10737
10738 * fns.c (secure_hash): Rename from crypto_hash_function and change
10739 the first arg to accept symbols.
5b66d427 10740 (Fsecure_hash): New primitive.
7f3f739f
LL
10741 (syms_of_fns): New symbols.
10742
76147d94
DD
107432011-06-20 Deniz Dogan <deniz@dogan.se>
10744
10745 * process.c (Fset_process_buffer): Clarify return value in
10746 docstring.
10747
7d7d0045
CY
107482011-06-18 Chong Yidong <cyd@stupidchicken.com>
10749
10750 * dispnew.c (add_window_display_history): Use BVAR.
10751
10752 * xdisp.c (debug_method_add): Use BVAR.
10753 (check_window_end, dump_glyph_matrix, dump_glyph)
10754 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10755
10756 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10757 Likewise.
10758
10759 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10760 check till after the cache is created in init_frame_faces.
10761
ff2bc410
SM
107622011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10763
10764 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10765
28177add
PE
107662011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10767
dd3482fe
PE
10768 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10769 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10770 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10771
393d71f3 10772 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10773 * fileio.c (Finsert_file_contents):
10774 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10775 Remove the old (too-loose) buffer overflow checks.
10776 They weren't needed, since make_gap checks for buffer overflow.
10777 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10778 The old code merely checked for Emacs fixnum overflow, and relied
10779 on undefined (wraparound) behavior. The new code avoids undefined
10780 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10781
2e6813b0 10782 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10783 Tune. Don't use wider integers than needed. Don't use alloca.
10784 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10785
599a9e4f
PE
10786 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10787
99561444
PE
10788 * insdel.c, lisp.h (buffer_overflow): New function.
10789 (insert_from_buffer_1, replace_range, replace_range_2):
10790 * insdel.c (make_gap_larger):
10791 * editfns.c (Finsert_char):
10792 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10793
28177add
PE
10794 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10795
e69dafad
PE
107962011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10797
4baa020d 10798 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10799
b1c46f02
PE
10800 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10801 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10802
e69dafad
PE
10803 * fileio.c: Don't assume EMACS_INT fits in off_t.
10804 (emacs_lseek): New static function.
10805 (Finsert_file_contents, Fwrite_region): Use it.
10806 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10807
566684ea
PE
10808 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10809
e6966cd6
PE
10810 * fns.c: Don't overflow int when computing a list length.
10811 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10812 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10813 truncation on 64-bit hosts. Check for QUIT every
10814 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10815 faster and is responsive enough.
10816 (Flength): Report an error instead of overflowing an integer.
10817 (Fsafe_length): Return a float if the value is not representable
10818 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10819 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10820 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10821
dd0b0efb
PE
10822 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10823 (header_size, word_size): New constants.
10824 (allocate_vectorlike): Don't check size overflow here.
10825 (allocate_vector): Check it here instead, since this is the only
10826 caller of allocate_vectorlike that could cause overflow.
10827 Check that the new vector's length is representable as a fixnum.
10828
86fe5cfe
PE
10829 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10830 The previous code was bogus. For example, next_almost_prime (32)
10831 returned 39, which is undesirable as it is a multiple of 3; and
10832 next_almost_prime (24) returned 25, which is a multiple of 5 so
10833 why was the code bothering to check for multiples of 7?
10834
80e88859
PE
10835 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10836
4a2f0ad6
PE
10837 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10838
f66c7cf8
PE
10839 Variadic C functions now count arguments with ptrdiff_t.
10840 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10841 Back then I didn't know that the Emacs coding style prefers signed int.
10842 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10843 were being counted with int, which may truncate counts on 64-bit
10844 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10845 * lisp.h (struct Lisp_Subr.function.aMANY)
10846 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10847 Arg counts are now ptrdiff_t, not size_t.
10848 All variadic functions and their callers changed accordingly.
10849 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10850 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10851 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10852 * callint.c (Fcall_interactively): Check arg count for overflow,
10853 to avoid potential buffer overrun. Use signed char, not 'int',
10854 for 'varies' array, so that we needn't bother to check its size
10855 calculation for overflow.
10856 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10857 * eval.c (apply_lambda):
10858 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10859 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10860 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10861
a1759b76
PE
10862 * callint.c (Fcall_interactively): Don't use index var as event count.
10863
d96be9fc
PE
10864 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10865 * mem-limits.h (SIZE): Remove; no longer used.
10866
a690a978 10867 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10868
578c21e6
PE
10869 Remove unnecessary casts.
10870 * xterm.c (x_term_init):
10871 * xfns.c (x_set_border_pixel):
10872 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10873 These aren't needed now that we assume ANSI C.
10874
96f53c6c
PE
10875 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10876 It's more likely to cause problems (due to unsigned overflow)
10877 than to cure them.
10878
83c77d31
PE
10879 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10880
ee2079f1
PE
10881 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10882
6da65536
PE
10883 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10884
7147c4a4
PE
10885 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10886
193e32d9
PE
10887 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10888
e5533da6
PE
10889 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10890
9910e595
PE
10891 GLYPH_CODE_FACE returns EMACS_INT, not int.
10892 * dispextern.h (merge_faces):
10893 * xfaces.c (merge_faces):
01103c44
PE
10894 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10895 Don't assume EMACS_INT fits in int.
9910e595 10896
2638320e
PE
10897 * character.h (CHAR_VALID_P): Remove unused parameter.
10898 * fontset.c, lisp.h, xdisp.c: All uses changed.
10899
045eb8d9
PE
10900 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10901
c1f134b5
PE
10902 * fns.c (concat): Minor tuning based on overflow analysis.
10903 This doesn't fix any bugs. Use int to hold character, instead
10904 of constantly refetching from Emacs object. Use XFASTINT, not
10905 XINT, for value known to be a character. Don't bother comparing
10906 a single byte to 0400, as it's always less.
10907
395fcb93 10908 * floatfns.c (Fexpt):
327eeec8
PE
10909 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10910
abbd3d23
PE
10911 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10912 for characters.
10913
684a03ef
PE
10914 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10915
0fed43f3
PE
10916 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10917 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10918 incorrectly succeed when S was a string, because 4294967386 was
10919 truncated before it was used.
10920
8fd02eb7
PE
10921 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10922 Otherwise, an out-of-range integer could cause undefined behavior
10923 on a 64-bit host.
10924
f8c86b69
PE
10925 * composite.c: Use int, not EMACS_INT, for characters.
10926 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10927 EMACS_INT, for values that are known to be in character range.
10928 This doesn't fix any bugs but is the usual style inside Emacs and
10929 may generate better code on 32-bit machines.
10930
34206dd2
PE
10931 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10932 This is for reasons similar to the recent CHAR_STRING fix.
10933 * charset.c (Fencode_char): Check that character arg is actually
10934 a character. Pass an int to ENCODE_CHAR.
10935 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10936 wider than 'int', as a compile-time check to prevent future regressions
10937 in this area.
10938
c5958d4c 10939 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10940
10941 Make sure a 64-bit char is never passed to CHAR_STRING.
10942 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10943 by silently ignoring the top 32 bits, allowing some values
10944 that were far too large to be valid characters.
10945 * character.h: Include <verify.h>.
10946 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10947 arguments are no wider than unsigned, as a compile-time check
10948 to prevent future regressions in this area.
10949 * data.c (Faset):
01103c44 10950 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10951 (Fsubst_char_in_region):
10952 * fns.c (concat):
10953 * xdisp.c (decode_mode_spec_coding):
10954 Adjust to CHAR_STRING's new requirement.
10955 * editfns.c (Finsert_char, Fsubst_char_in_region):
10956 * fns.c (concat): Check that character args are actually
10957 characters. Without this test, these functions did the wrong
10958 thing with wildly out-of-range values on 64-bit hosts.
10959
d37ca623
PE
10960 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10961 These casts should not be needed on 32-bit hosts, either.
10962 * keyboard.c (read_char):
10963 * lread.c (Fload): Remove casts to unsigned.
10964
ea204efb
PE
10965 * lisp.h (UNSIGNED_CMP): New macro.
10966 This fixes comparison bugs on 64-bit hosts.
10967 (ASCII_CHAR_P): Use it.
10968 * casefiddle.c (casify_object):
01103c44 10969 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10970 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10971 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10972 * dispextern.h (FACE_FROM_ID):
10973 * keyboard.c (read_char): Use UNSIGNED_CMP.
10974
41cb286c
PE
10975 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10976 not to EMACS_INT, to avoid GCC warning.
10977
4a1b9832
PE
10978 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10979
55daad71
PE
10980 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10981 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10982 isn't needed on 32-bit machines.
8f95c75c 10983
01103c44
PE
10984 * buffer.c (Fgenerate_new_buffer_name):
10985 Use EMACS_INT for count, not int.
0ceccced 10986 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10987
10988 * data.c (Qcompiled_function): Now static.
10989
c6f072e7
PE
10990 * window.c (window_body_lines): Now static.
10991
20ce5912
PE
10992 * image.c (gif_load): Rename local to avoid shadowing.
10993
9c4c5f81
PE
10994 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10995 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10996 * alloc.c (make_save_value): Integer argument is now of type
10997 ptrdiff_t, not int.
10998 (mark_object): Use ptrdiff_t, not int.
10999 * lisp.h (pD): New macro.
11000 * print.c (print_object): Use it.
11001
c0c5c8ae
PE
11002 * alloc.c: Use EMACS_INT, not int, to count objects.
11003 (total_conses, total_markers, total_symbols, total_vector_size)
11004 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
11005 (total_free_floats, total_floats, total_free_intervals)
11006 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11007 Now EMACS_INT, not int. All uses changed.
11008 (Fgarbage_collect): Compute overall total using a double, so that
11009 integer overflow is less likely to be a problem. Check for overflow
11010 when converting back to an integer.
5a25e253
PE
11011 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11012 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11013 These were 'int' variables that could overflow on 64-bit hosts;
11014 they were never used, so remove them instead of repairing them.
211a0b2a 11015 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11016 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11017 Previously, this ceilinged at INT_MAX, but that doesn't work on
11018 64-bit machines.
e46bb31a 11019 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11020
c78baabf 11021 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11022 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11023 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11024 when a (possibly-narrower) signed value would do just as well.
11025 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11026
c9d624c6
PE
11027 * alloc.c: Catch some string size overflows that we were missing.
11028 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11029 for convenience in STRING_BYTES_MAX.
11030 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11031 The definition here is exact; the one in lisp.h was approximate.
11032 (allocate_string_data): Check for string overflow. This catches
11033 some instances we weren't catching before. Also, it catches
11034 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11035 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11036 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11037
c9d624c6
PE
11038 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11039 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11040 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11041
353032ce
PE
11042 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11043
2bccce07
PE
11044 * alloc.c (Fmake_string): Check for out-of-range init.
11045
0ac30604
SM
110462011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11047
11048 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11049
c195f2de
JD
110502011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11051
11052 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11053 xg_get_default_scrollbar_width.
11054
11055 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11056 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11057 (style_changed_cb): Call update_theme_scrollbar_width and call
11058 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11059 all frames (Bug#8505).
11060 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11061 Call gtk_window_set_resizable if HAVE_GTK3.
11062 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11063 and height if HAVE_GTK3 (Bug#8505).
11064 (scroll_bar_width_for_theme): New variable.
11065 (update_theme_scrollbar_width): New function.
11066 (xg_get_default_scrollbar_width): Move code to
11067 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11068 (xg_initialize): Call update_theme_scrollbar_width.
11069
11070 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11071
11072 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11073
e10ac9f1
MR
110742011-06-12 Martin Rudalics <rudalics@gmx.at>
11075
11076 * frame.c (make_frame): Call other_buffer_safely instead of
11077 other_buffer.
11078
11079 * window.c (temp_output_buffer_show): Call display_buffer with
11080 second argument Vtemp_buffer_show_specifiers and reset latter
11081 immediately after the call.
11082 (Vtemp_buffer_show_specifiers): New variable.
11083 (auto_window_vscroll_p, next_screen_context_lines)
11084 (Vscroll_preserve_screen_position): Remove leading asterisks from
11085 doc-strings.
11086
2d3c217e 110872011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11088
7b7f97e8 11089 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11090 * buffer.c (Qclone_number): Remove for now, as it's unused.
11091 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11092 (record_buffer): Remove unused local.
11093 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11094 (set_frame_buffer_list): Remove; unused.
11095 * frame.h (other_visible_frames): Remove decl.
11096 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11097 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11098 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11099 if HAVE_GPM.
11100 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11101 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11102 Define only if HAVE_GPM.
11103 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11104 (update_hints_inhibit): Remove; never set. All uses removed.
11105 * widgetprv.h (emacsFrameClassRec): Remove decl.
11106 * window.c (delete_deletable_window): Now returns void, since it
11107 wasn't returning anything.
11108 (compare_window_configurations): Remove unused locals.
11109 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11110 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11111 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11112 the same widths as pointers. This follows up on the 2011-05-06 patch.
11113 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11114 * xterm.h: Likewise.
11115 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11116
1384b89e
JB
111172011-06-12 Juanma Barranquero <lekktu@gmail.com>
11118
11119 * makefile.w32-in: Update dependencies.
11120 (LISP_H): Add lib/intprops.h.
11121
1100a63c
CY
111222011-06-11 Chong Yidong <cyd@stupidchicken.com>
11123
11124 * image.c (gif_load): Add animation frame delay to the metadata.
11125 (syms_of_image): Use DEFSYM. New symbol `delay'.
11126
6198ccd0
MR
111272011-06-11 Martin Rudalics <rudalics@gmx.at>
11128
11129 * window.c (delete_deletable_window): Re-add.
11130 (Fset_window_configuration): Rewrite to handle dead buffers and
11131 consequently deletable windows.
11132 (window_tree, Fwindow_tree): Remove. Supply functionality in
11133 window.el.
11134 (compare_window_configurations): Simplify code.
11135
b6e3633c
AS
111362011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11137
1ab0dee5
AS
11138 * image.c (imagemagick_load_image): Fix type mismatch.
11139 (Fimagemagick_types): Likewise.
11140
b6e3633c
AS
11141 * window.h (replace_buffer_in_windows): Declare.
11142
9397e56f
MR
111432011-06-11 Martin Rudalics <rudalics@gmx.at>
11144
11145 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11146 Qclone_number. Remove external declaration of Qdelete_window.
11147 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11148 code.
640c8776
SM
11149 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11150 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11151 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11152 buffer list implementation.
11153 (other_buffer_safely): New function.
11154 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11155 calls to replace_buffer_in_windows and
11156 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11157 if allowed.
11158 (record_buffer): Inhibit quitting and rewrite using quittable
11159 functions. Run Qbuffer_list_update_hook if allowed.
11160 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11161 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11162 Move switch-to-buffer to window.el.
9397e56f
MR
11163 (bury-buffer): Move to window.el.
11164 (Vbuffer_list_update_hook): New variable.
11165
11166 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11167 section.
11168
11169 * window.h (resize_frame_windows): Move up in code.
11170 (Fwindow_frame): Remove EXFUN.
11171 (replace_buffer_in_all_windows): Remove prototype.
11172 (replace_buffer_in_windows_safely): Add prototype.
11173
11174 * window.c: Declare Qdelete_window static again. Move down
11175 declaration of select_count.
11176 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11177 (Fother_window): Move to window.el.
11178 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11179 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11180 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11181 window.el.
11182 (replace_buffer_in_windows): Implement by calling
11183 Qreplace_buffer_in_windows.
11184 (replace_buffer_in_all_windows): Remove with some functionality
11185 moved into replace_buffer_in_windows_safely.
11186 (replace_buffer_in_windows_safely): New function.
11187 (select_window_norecord, select_frame_norecord): Move in front
11188 of run_window_configuration_change_hook. Remove now obsolete
11189 declarations.
640c8776
SM
11190 (Fset_window_buffer): Rewrite doc-string.
11191 Call Qrecord_window_buffer.
9397e56f
MR
11192 (keys_of_window): Move binding for other-window to window.el.
11193
b50691aa
CY
111942011-06-11 Chong Yidong <cyd@stupidchicken.com>
11195
11196 * dispextern.h (struct image): Replace data member, whose int_val
11197 and ptr_val fields were not used by anything, with a single
11198 lisp_val object.
11199
11200 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11201 (gif_clear_image, gif_load, imagemagick_load_image)
11202 (gs_clear_image, gs_load): Callers changed.
11203
3f754b86
PE
112042011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11205
cca69397
PE
11206 * buffer.h: Include <time.h>, for time_t.
11207 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11208
109e28d0
PE
11209 Fix minor problems found by static checking.
11210
60737f02
PE
11211 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11212
4b66faf3
PE
11213 Make identifiers static if they are not used in other modules.
11214 * data.c (Qcompiled_function, Qframe, Qvector):
11215 * image.c (QimageMagick, Qsvg):
11216 * minibuf.c (Qmetadata):
11217 * window.c (resize_window_check, resize_root_window): Now static.
11218 * window.h (resize_window_check, resize_root_window): Remove decls.
11219
109e28d0
PE
11220 * window.c (window_deletion_count, delete_deletable_window):
11221 Remove; unused.
46a4ce9e
PE
11222 (window_body_lines): Now static.
11223 (Fdelete_other_windows_internal): Mark vars as initialized.
11224 Make sure 'resize_failed' is initialized.
11225 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11226 (resize_window_apply): Remove unused local.
11227 * window.h (delete_deletable_window): Remove decl.
11228
109e28d0 11229 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11230 (imagemagick_load_image): Fix pointer signedness problem by changing
11231 last arg from unsigned char * to char *. All uses changed.
11232 Also, fix a local for similar reasons.
11233 Remove unused locals. Remove locals to avoid shadowing.
11234 (fn_rsvg_handle_free): Remove; unused.
11235 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11236 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11237
3f754b86
PE
11238 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11239
2547adb1
CY
112402011-06-10 Chong Yidong <cyd@stupidchicken.com>
11241
11242 * image.c (gif_load): Fix omitted cast error introduced by
11243 2011-06-06 change.
11244
2c8e37d4
MR
112452011-06-10 Martin Rudalics <rudalics@gmx.at>
11246
11247 * window.h (resize_proportionally, orig_total_lines)
11248 (orig_top_line): Remove from window structure.
11249 (set_window_height, set_window_width, change_window_heights)
11250 (Fdelete_window): Remove prototypes.
11251 (resize_frame_windows): Remove duplicate declaration.
11252
440a42e3
EZ
112532011-06-10 Eli Zaretskii <eliz@gnu.org>
11254
11255 * window.h (resize_frame_windows, resize_window_check)
11256 (delete_deletable_window, resize_root_window)
11257 (resize_frame_windows): Declare prototypes.
11258
11259 * window.c (resize_window_apply): Make definition be "static" to
11260 match the prototype.
11261
562dd5e9
MR
112622011-06-10 Martin Rudalics <rudalics@gmx.at>
11263
11264 * window.c: Remove declarations of Qwindow_size_fixed,
11265 window_min_size_1, window_min_size_2, window_min_size,
11266 size_window, window_fixed_size_p, enlarge_window, delete_window.
11267 Remove static from declaration of Qdelete_window, it's
11268 temporarily needed by Fbury_buffer.
11269 (replace_window): Don't assign orig_top_line and
11270 orig_total_lines.
11271 (Fdelete_window, delete_window): Remove. Window deletion is
11272 handled by window.el.
640c8776
SM
11273 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11274 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11275 (Fdelete_other_windows): Remove. Deleting other windows is
11276 handled by window.el.
11277 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11278 handled in window.el.
11279 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11280 Window minimum sizes are handled in window.el.
11281 (shrink_windows, size_window, set_window_height)
11282 (set_window_width, change_window_heights, window_height)
11283 (window_width, CURBEG, CURSIZE, enlarge_window)
11284 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11285 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11286 handled in window.el.
11287 (make_dummy_parent): Rename to make_parent_window and give it a
11288 second argument horflag.
11289 (make_window): Don't set resize_proportionally any more.
11290 (Fsplit_window): Remove. Windows are split in window.el.
11291 (save_restore_action, save_restore_orig_size)
11292 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11293 Resize mini windows in window.el.
11294 (grow_mini_window, shrink_mini_window): Implement by calling
11295 Qresize_root_window_vertically, resize_window_check and
11296 resize_window_apply.
640c8776
SM
11297 (saved_window, Fset_window_configuration, save_window_save):
11298 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11299 resize_proportionally.
11300 (window_min_height, window_min_width): Move to window.el.
11301 (keys_of_window): Move bindings for delete-other-windows,
11302 split-window, delete-window and enlarge-window to window.el.
11303
11304 * buffer.c: Temporarily extern Qdelete_window.
11305 (Fbury_buffer): Temporarily call Qdelete_window instead of
11306 Fdelete_window (Fbury_buffer will move to window.el soon).
11307
11308 * frame.c (set_menu_bar_lines_1): Remove code handling
11309 orig_top_line and orig_total_lines.
11310
11311 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11312 set_window_height but set heights directly.
11313 (change_frame_size_1): Use resize_frame_windows.
11314
11315 * xdisp.c (init_xdisp): Don't use set_window_height but set
11316 heights directly.
11317
640c8776
SM
11318 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11319 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11320 run_window_configuration_change_hook.
11321
11322 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11323 instead of change_window_heights and run
11324 run_window_configuration_change_hook.
11325
1a13852e
MR
113262011-06-09 Martin Rudalics <rudalics@gmx.at>
11327
11328 * window.c (replace_window): Rename second argument REPLACEMENT to
11329 NEW. New third argument SETFLAG. Rewrite.
11330 (delete_window, make_dummy_parent): Call replace_window with
11331 third argument 1.
11332 (window_list_1): Move down in code.
11333 (run_window_configuration_change_hook): Move set_buffer part
11334 before select_frame_norecord part in order to unwind correctly.
11335 Rename count1 to count.
11336 (recombine_windows, delete_deletable_window, resize_root_window)
11337 (Fdelete_other_windows_internal)
11338 (Frun_window_configuration_change_hook, make_parent_window)
11339 (resize_window_check, resize_window_apply, Fresize_window_apply)
11340 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11341 (Fdelete_window_internal, Fresize_mini_window_internal):
11342 New functions.
1a13852e
MR
11343 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11344
f3d1777e
MR
113452011-06-08 Martin Rudalics <rudalics@gmx.at>
11346
496e208e
MR
11347 * window.h (window): Add some new members to window structure -
11348 normal_lines, normal_cols, new_total, new_normal, clone_number,
11349 splits, nest, prev_buffers, next_buffers.
11350 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11351 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11352
f3d1777e
MR
11353 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11354 Remove.
496e208e
MR
11355 (make_dummy_parent): Set new members of windows structure.
11356 (make_window): Move down in code. Handle new members of window
11357 structure.
11358 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11359 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11360 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11361 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11362 (Fset_window_next_buffers, Fset_window_clone_number):
11363 New functions.
496e208e
MR
11364 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11365 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11366 Doc-string fixes.
11367 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11368 Argument WINDOW can be now internal window too.
11369 (Fwindow_use_time): Move up in code.
11370 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11371 Rewrite doc-string.
11372 (Fset_window_configuration, saved_window)
11373 (Fcurrent_window_configuration, save_window_save): Handle new
11374 members of window structure.
b9e809c2
MR
11375 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11376 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11377 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11378 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11379 Qget_mru_window, Qresize_root_window,
11380 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11381 Qauto_buffer_name; staticpro them.
f3d1777e 11382
abde8f8c
MR
113832011-06-07 Martin Rudalics <rudalics@gmx.at>
11384
11385 * window.c (Fwindow_total_size, Fwindow_left_column)
11386 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11387 (Fwindow_list_1): New functions.
11388 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11389 (Fwindow_width, Fscroll_left, Fscroll_right):
11390 Use window_body_cols instead of window_box_text_cols.
11391 (delete_window, Fset_window_configuration):
11392 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11393 (delete_all_subwindows): Take a window as argument and not a
11394 structure. Rewrite.
190b47e6
MR
11395 (window_loop): Remove handling of GET_LRU_WINDOW and
11396 GET_LARGEST_WINDOW.
11397 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11398
11399 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11400 window_box_text_cols. delete_all_subwindows now takes a
11401 Lisp_Object as argument.
abde8f8c 11402
640c8776
SM
11403 * indent.c (compute_motion, Fcompute_motion):
11404 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11405
fa8a67e6
MR
11406 * frame.c (delete_frame): Call delete_all_subwindows with root
11407 window as argument.
11408
a54e3482
DC
114092011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11410
11411 * fns.c (Fputhash): Document return value.
11412
60002bf5
CY
114132011-06-06 Chong Yidong <cyd@stupidchicken.com>
11414
11415 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11416
0c671da6 114172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11418
b862a52a 11419 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11420
be44ca6c
PE
11421 Check for overflow when converting integer to cons and back.
11422 * charset.c (Fdefine_charset_internal, Fdecode_char):
11423 Use cons_to_unsigned to catch overflow.
11424 (Fencode_char): Use INTEGER_TO_CONS.
11425 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11426 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11427 * data.c (long_to_cons, cons_to_long): Remove.
11428 (cons_to_unsigned, cons_to_signed): New functions.
11429 These signal an error for invalid or out-of-range values.
11430 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11431 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11432 * font.c (Ffont_variation_glyphs):
11433 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11434 * lisp.h: Include <intprops.h>.
11435 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11436 (cons_to_signed, cons_to_unsigned): New decls.
11437 (long_to_cons, cons_to_long): Remove decls.
11438 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11439 (Fprimitive_undo): Use CONS_TO_INTEGER.
11440 * xfns.c (Fx_window_property): Likewise.
11441 * xselect.c: Include <limits.h>.
11442 (x_own_selection, selection_data_to_lisp_data):
11443 Use INTEGER_TO_CONS.
11444 (x_handle_selection_request, x_handle_selection_clear)
11445 (x_get_foreign_selection, Fx_disown_selection_internal)
11446 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11447 (lisp_data_to_selection_data): Use cons_to_unsigned.
11448 (x_fill_property_data): Use cons_to_signed.
11449 Report values out of range.
11450
d1f3d2af
PE
11451 Check for buffer and string overflow more precisely.
11452 * buffer.h (BUF_BYTES_MAX): New macro.
11453 * lisp.h (STRING_BYTES_MAX): New macro.
11454 * alloc.c (Fmake_string):
11455 * character.c (string_escape_byte8):
11456 * coding.c (coding_alloc_by_realloc):
11457 * doprnt.c (doprnt):
11458 * editfns.c (Fformat):
11459 * eval.c (verror):
11460 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11461 since they may not be the same number.
11462 * editfns.c (Finsert_char):
11463 * fileio.c (Finsert_file_contents):
11464 Likewise for BUF_BYTES_MAX.
11465
dd52fcea
PE
11466 * image.c: Use ptrdiff_t, not int, for sizes.
11467 (slurp_file): Switch from int to ptrdiff_t.
11468 All uses changed.
11469 (slurp_file): Check that file size fits in both size_t (for
11470 malloc) and ptrdiff_t (for sanity and safety).
11471
7f9bbdbb
PE
11472 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11473 if b->modtime has its maximal value.
11474
dfe18f82
PE
11475 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11476
84acfcf0
PE
11477 Don't assume time_t can fit into int.
11478 * buffer.h (struct buffer.modtime): Now time_t, not int.
11479 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11480 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11481
ccd9a01a
PE
11482 Minor fixes for signed vs unsigned integers.
11483 * character.h (MAYBE_UNIFY_CHAR):
11484 * charset.c (maybe_unify_char):
11485 * keyboard.c (read_char, reorder_modifiers):
11486 XINT -> XFASTINT, since the integer must be nonnegative.
11487 * ftfont.c (ftfont_spec_pattern):
11488 * keymap.c (access_keymap, silly_event_symbol_error):
11489 XUINT -> XFASTINT, since the integer must be nonnegative.
11490 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11491 since it makes no difference and we prefer signed.
11492 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11493 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11494 nonnegative.
11495
d6d100dd
SM
114962011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11497
11498 * window.h (Fwindow_frame): Declare.
11499
2b6148e4
PE
115002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11501
11502 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11503 (SPARE_MEMORY): Always define.
11504 (LARGE_REQUEST): Remove.
11505 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11506
f230ecc9
MR
115072011-06-06 Martin Rudalics <rudalics@gmx.at>
11508
727e958e
MR
11509 * lisp.h: Move EXFUNS for Fframe_root_window,
11510 Fframe_first_window and Fset_frame_selected_window to window.h.
11511
11512 * window.h: Move EXFUNS for Fframe_root_window,
11513 Fframe_first_window and Fset_frame_selected_window here from
11514 lisp.h.
11515
11516 * frame.c (Fwindow_frame, Fframe_first_window)
11517 (Fframe_root_window, Fframe_selected_window)
11518 (Fset_frame_selected_window): Move to window.c.
11519 (Factive_minibuffer_window): Move to minibuf.c.
11520 (Fother_visible_frames_p): New function.
11521
11522 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11523
f230ecc9
MR
11524 * window.c (decode_window, decode_any_window): Move up in code.
11525 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11526 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11527 (Fwindow_buffer): Move up and rewrite doc-string.
11528 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11529 (Fwindow_prev): New functions.
727e958e
MR
11530 (Fwindow_frame): Move here from frame.c. Accept any window as
11531 argument.
11532 (Fframe_root_window, Fframe_first_window)
11533 (Fframe_selected_window): Move here from frame.c. Accept frame
11534 or arbitrary window as argument. Update doc-strings.
11535 (Fminibuffer_window): Move up in code.
11536 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11537 (Fset_frame_selected_window): Move here from frame.c.
11538 Marginal rewrite.
727e958e
MR
11539 (Fselected_window, select_window, Fselect_window): Move up in
11540 code. Minor doc-string fixes.
f230ecc9 11541
4d09bcf6
PE
115422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11543
11544 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11545 Do not assume that spare memory exists; that assumption is valid
11546 only if SYSTEM_MALLOC.
11547 (LARGE_REQUEST): New macro, so that the issue of large requests
11548 is separated from the issue of spare memory.
11549
810928a2
AS
115502011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11551
172418ad
AS
11552 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11553 format. (Bug#8806)
11554
43f862f7
AS
11555 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11556
810928a2
AS
11557 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11558 before statements.
11559
a059fe24
JD
115602011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11561
11562 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11563
11564 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11565
11566 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11567 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11568
989bf368
JB
115692011-06-05 Juanma Barranquero <lekktu@gmail.com>
11570
11571 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11572
4b80f674
CY
115732011-06-04 Chong Yidong <cyd@stupidchicken.com>
11574
11575 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11576 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11577 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11578 New error handlers.
4b80f674
CY
11579 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11580 Obey Vx_select_enable_clipboard_manager. Catch errors in
11581 x_clipboard_manager_save (Bug#8779).
11582 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11583 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11584
99a33b77 115852011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11586
11587 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11588
99a33b77 115892011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11590
11591 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11592 in the current matrix if keep_current_p is non-zero.
11593
8264569d
EZ
115942011-06-04 Eli Zaretskii <eliz@gnu.org>
11595
11596 * bidi.c (bidi_level_of_next_char): Fix last change.
11597
57f97249
EZ
115982011-06-03 Eli Zaretskii <eliz@gnu.org>
11599
fec2107c 11600 Support bidi reordering of text covered by display properties.
57f97249 11601
fec2107c
EZ
11602 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11603 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11604 (bidi_cache_search, bidi_cache_iterator_state)
11605 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11606 (bidi_level_of_next_char, bidi_move_to_visually_next):
11607 Support character positions inside a run of characters covered by a
fec2107c
EZ
11608 display string.
11609 (bidi_paragraph_init, bidi_resolve_explicit_1)
11610 (bidi_level_of_next_char): Call bidi_fetch_char and
11611 bidi_fetch_char_advance instead of FETCH_CHAR and
11612 FETCH_CHAR_ADVANCE.
11613 (bidi_init_it): Initialize new members.
11614 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11615 definitions.
11616 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11617 instead of using explicit *_CHAR codes.
d6d100dd
SM
11618 (bidi_resolve_explicit, bidi_resolve_weak):
11619 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11620 bidirectional text is supported only in multibyte buffers.
11621 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11622 it to initialize the frame_window_p member of struct bidi_it.
11623 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11624 (bidi_resolve_explicit, bidi_resolve_weak)
11625 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11626 bidi_it->nchars is non-positive.
11627 (bidi_level_of_next_char): Don't try to lookup the cache for the
11628 next/previous character if nothing is cached there yet, or if we
11629 were just reseat()'ed to a new position.
c40e2fb2 11630
0e14fe90
EZ
11631 * xdisp.c (set_cursor_from_row): Set start and stop points
11632 according to the row's direction when priming the loop that looks
11633 for the glyph on which to display cursor.
11634 (single_display_spec_intangible_p): Function deleted.
11635 (display_prop_intangible_p): Reimplement to call
11636 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11637 Accept 3 additional arguments needed by handle_display_spec.
11638 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11639 values: lists, `(when COND...)' forms, etc.
11640 (single_display_spec_string_p): Support property values that are
11641 lists with the argument STRING its top-level element.
11642 (display_prop_string_p): Fix the condition for processing a
11643 property that is a list to be consistent with handle_display_spec.
fec2107c 11644 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11645 last portion of handle_display_prop.
11646 (compute_display_string_pos): Accept additional argument
11647 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11648 value of a `display' property is a "replacing spec".
11649 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11650 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11651 the display property, but just return a value indicating whether
11652 the display property will replace the characters it covers.
11653 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11654 frame_window_p members of struct bidi_it.
d6d100dd
SM
11655 (compute_display_string_pos, compute_display_string_end):
11656 New functions.
fec2107c
EZ
11657 (push_it): Accept second argument POSITION, where pop_it should
11658 jump to continue iteration.
11659 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11660
fec2107c
EZ
11661 * keyboard.c (adjust_point_for_property): Adjust the call to
11662 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11663
11664 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11665 (bidi_init_it): Update prototypes.
11666 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11667 (compute_display_string_pos, compute_display_string_end):
11668 Declare prototypes.
fec2107c
EZ
11669 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11670 EMACS_INT.
fc6f18ce 11671
40087514 116722011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11673
57f53182
PE
11674 Malloc failure behavior now depends on size of allocation.
11675 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11676 * lisp.h: Change signatures accordingly.
11677 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11678 All callers changed. (Bug#8762)
11679
11680 * gnutls.c: Use Emacs's memory allocators.
11681 Without this change, the gnutls library would invoke malloc etc.
11682 directly, which causes problems on non-SYNC_INPUT hosts, and which
11683 runs afoul of improving memory_full behavior. (Bug#8761)
11684 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11685 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11686 xfree instead of the default malloc, realloc, free.
11687 (Fgnutls_boot): No need to check for memory allocation failure,
11688 since xmalloc does that for us.
11689
ac32cd99 11690 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11691 * category.c (hash_get_category_set):
11692 * ccl.c (ccl_driver):
11693 * charset.c (Fdefine_charset_internal):
11694 * charset.h (struct charset.hash_index):
11695 * composite.c (get_composition_id, gstring_lookup_cache)
11696 (composition_gstring_put_cache):
11697 * composite.h (struct composition.hash_index):
11698 * dispextern.h (struct image.hash):
11699 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11700 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11701 (hashfn_equal, hashfn_user_defined, make_hash_table)
11702 (maybe_resize_hash_table, hash_lookup, hash_put)
11703 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11704 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11705 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11706 * image.c (make_image, search_image_cache, lookup_image)
11707 (xpm_put_color_table_h):
11708 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11709 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11710 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11711 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11712 * alloc.c (allocate_vectorlike):
11713 Check for overflow in vector size calculations.
11714 * ccl.c (ccl_driver):
11715 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11716 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11717 need to be updated by these changes.
40087514
PE
11718 * fns.c (make_hash_table, maybe_resize_hash_table):
11719 Check for integer overflow with large hash tables.
0de4bb68
PE
11720 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11721 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11722 (SXHASH_REDUCE): New macro.
11723 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11724 Use it instead of discarding useful hash info with large hash values.
11725 (sxhash_float): New function.
11726 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11727 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11728 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11729 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11730 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11731 Adjust signatures to match updated version of code.
11732 (consing_since_gc): Now EMACS_INT, since a single hash table can
11733 use more than INT_MAX bytes.
11734
698d32e2
DN
117352011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11736
11737 Make it possible to build with GCC-4.6+ -O2 -flto.
11738
11739 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11740
fd6fa53f
SM
117412011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11742
11743 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11744 Call minibuffer-inactive-mode.
11745
864db017
JB
117462011-05-31 Juanma Barranquero <lekktu@gmail.com>
11747
11748 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11749 Update dependencies.
11750
2ad0baf4
DN
117512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11752
11753 * data.c (init_data): Remove code for UTS, this system is not
11754 supported anymore.
11755
4fcc2638
DN
117562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11757
11758 Don't force ./temacs to start in terminal mode.
11759
11760 * frame.c (make_initial_frame): Initialize faces in all cases, not
11761 only when CANNOT_DUMP is defined.
11762 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11763
c56e0fd5
DN
117642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11765
11766 * dispnew.c (add_window_display_history): Use const for the string
11767 pointer. Remove declaration, not needed.
11768
333d54da 117692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11770
55d4c1b2 11771 Use 'inline', not 'INLINE'.
333d54da 11772 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11773 * alloc.c, fontset.c (INLINE): Remove.
11774 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11775 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11776 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11777 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11778 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11779
738db178
DN
117802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11781
11782 Make it possible to run ./temacs.
11783
11784 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11785 syms_of_callproc does the same thing. Remove test for
11786 "initialized", do it in the caller.
11787 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11788
620c53a6
SM
117892011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11790
11791 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11792 (read_minibuf): Use get_minibuffer.
11793 (syms_of_minibuf): Use DEFSYM.
11794 (Qmetadata): New var.
11795 * data.c (Qbuffer): Don't make it static.
11796 (syms_of_data): Use DEFSYM.
11797
e003a292
PE
117982011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11799
11800 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11801 (CCL_CODE_MIN): New macro.
11802
ed008a6d
PE
118032011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11804
3687c2ef
PE
11805 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11806
ed008a6d
PE
11807 * eval.c (Qdebug): Now static.
11808 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11809 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11810 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11811
d66c4c7c
CY
118122011-05-29 Chong Yidong <cyd@stupidchicken.com>
11813
11814 * image.c: Various fixes to ImageMagick code comments.
11815 (Fimagemagick_types): Doc fix.
11816
5fbc2025
PE
118172011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11818
0196f88a
PE
11819 Minor fixes prompted by GCC 4.6.0 warnings.
11820
11821 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11822
5fbc2025
PE
11823 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11824 (x_clipboard_manager_save_all): Move extern decl to ...
11825 * xterm.h: ... here, so that it can be checked for consistency.
11826
1dd3c2d9
CY
118272011-05-29 Chong Yidong <cyd@stupidchicken.com>
11828
11829 * xselect.c (x_clipboard_manager_save_frame)
11830 (x_clipboard_manager_save_all): New functions.
11831 (Fx_clipboard_manager_save): Lisp function deleted.
11832
11833 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11834 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11835
11836 * xterm.h: Update prototype.
11837
5ba6571d
WX
118382011-05-28 William Xu <william.xwl@gmail.com>
11839
11840 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11841 exiting (Bug#8239).
11842
3eaff834
JM
118432011-05-28 Jim Meyering <meyering@redhat.com>
11844
e1900994 11845 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11846 * fns.c (to_uchar): Define.
11847 (crypto_hash_function): Use it to convert some newly-signed
11848 variables to unsigned, to avoid sign-extension bugs. For example,
11849 without this change, (md5 "truc") would evaluate to
11850 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11851 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11852 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11853
0f6990a7
PE
118542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11855
11856 Integer overflow fixes.
c8a9ca5a 11857
08686060
PE
11858 * dbusbind.c: Serial number integer overflow fixes.
11859 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11860 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11861 to hold a serial number that is too large for a fixnum.
11862 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11863 Check for serial numbers out of range. Decode any serial number
59568bf0 11864 that was so large that it became a float. (Bug#8722)
08686060 11865
2d1fc3c7
PE
11866 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11867 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11868 Use XFASTINT rather than XUINT when numbers are nonnegative.
11869 (xd_append_arg, Fdbus_method_return_internal):
11870 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11871 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11872 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11873 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11874 (Bug#8722)
2d1fc3c7 11875
c8a9ca5a
PE
11876 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11877
519e1d69
PE
11878 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11879
6df6ae42 11880 ccl: Add integer overflow checks.
30569699
PE
11881 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11882 (IN_INT_RANGE): New macros.
11883 (ccl_driver): Use them to check for integer overflow when
11884 decoding a CCL program. Many of the new checks are whether XINT (x)
11885 fits in int; it doesn't always, on 64-bit hosts. The new version
11886 doesn't catch all possible integer overflows, but it's an
847044ea 11887 improvement. (Bug#8719)
30569699 11888
c11285dc
PE
11889 * alloc.c (make_event_array): Use XINT, not XUINT.
11890 There's no need for unsigned here.
11891
fdccd48e
PE
11892 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11893 This follows up to the 2011-05-06 change that substituted uintptr_t
11894 for EMACS_INT. This case wasn't caught back then.
11895
37910ab2
PE
11896 Rework Fformat to avoid integer overflow issues.
11897 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11898 now (part of C89). Include <verify.h>.
11899 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11900 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11901 (Fformat): Avoid the prepass trying to compute sizes; it was only
11902 approximate and thus did not catch overflow reliably. Instead, walk
11903 through the format just once, formatting and computing sizes as we go,
11904 checking for integer overflow at every step, and allocating a larger
11905 buffer as needed. Keep track separately whether the format is
11906 multibyte. Keep only the most-recently calculated precision, rather
11907 than them all. Record whether each argument has been converted to
11908 string. Use EMACS_INT, not int, for byte and char and arg counts.
11909 Support field widths and precisions larger than INT_MAX. Avoid
11910 sprintf's undefined behavior with conversion specifications such as %#d
11911 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11912 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11913 formatting out-of-range floating point numbers with int
9173deec 11914 formats. (Bug#8668)
37910ab2 11915
2e6578fb
PE
11916 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11917
0ae6bdee
PE
11918 * data.c: Avoid integer truncation in expressions involving floats.
11919 * data.c: Include <intprops.h>.
11920 (arith_driver): When there's an integer overflow in an expression
11921 involving floating point, convert the integers to floating point
11922 so that the resulting value does not suffer from catastrophic
11923 integer truncation. For example, on a 64-bit host (* 4
11924 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11925 Do not rely on undefined behavior after integer overflow.
11926
de883a70
PE
11927 merge count_size_as_multibyte, parse_str_to_multibyte
11928 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11929 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11930 Check for integer overflow.
11931 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11932 since it's now a duplicate of the other. This is more of
11933 a character than a buffer op, so better that it's in character.c.
11934 * fns.c, print.c: Adjust to above changes.
11935
2ff916cb
PE
119362011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11937
11938 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11939
f1b54466
PE
119402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11941
fb1ac845
PE
11942 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11943 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11944 (x_clipboard_manager_save): Now static.
11945 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11946
f1b54466
PE
11947 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11948 (crypto_hash_function): Now static.
11949 Fix pointer signedness problems. Avoid unnecessary initializations.
11950
a9f737ee
CY
119512011-05-27 Chong Yidong <cyd@stupidchicken.com>
11952
11953 * termhooks.h (Vselection_alist): Make it terminal-local.
11954
11955 * terminal.c (create_terminal): Initialize it.
11956
11957 * xselect.c: Support for clipboard managers.
11958 (Vselection_alist): Move to termhooks.h as terminal-local var.
11959 (LOCAL_SELECTION): New macro.
11960 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11961 (symbol_to_x_atom): Remove gratuitous arg.
11962 (x_handle_selection_request, lisp_data_to_selection_data)
11963 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11964 (x_own_selection, x_get_local_selection, x_convert_selection):
11965 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11966 (some_frame_on_display): Delete unused function.
11967 (Fx_own_selection_internal, Fx_get_selection_internal)
11968 (Fx_disown_selection_internal, Fx_selection_owner_p)
11969 (Fx_selection_exists_p): New optional frame arg.
11970 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11971 (x_handle_selection_clear): Don't treat other terminals with the
11972 same keyboard specially. Use the terminal-local Vselection_alist.
11973 (x_clear_frame_selections): Use Frun_hook_with_args.
11974
11975 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11976
11977 * xterm.h: Add support for those atoms.
11978
e067f0c1
CY
119792011-05-26 Chong Yidong <cyd@stupidchicken.com>
11980
11981 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11982 (converted_selections, conversion_fail_tag): New global variables.
11983 (x_selection_request_lisp_error): Free the above.
11984 (x_get_local_selection): Remove unnecessary code.
11985 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11986 of converted selections stored in converted_selections.
11987 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11988 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11989 (x_convert_selection): New function.
11990 (x_handle_selection_event): Simplify.
11991 (x_get_foreign_selection): Don't ignore incoming requests while
11992 waiting for an answer; this will fail when we implement
11993 SAVE_TARGETS, and seems unnecessary anyway.
11994 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11995 (Vx_sent_selection_functions): Doc fix.
11996
0f4aebc0
LL
119972011-05-26 Leo Liu <sdl.web@gmail.com>
11998
11999 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
12000
e61124cd
YM
120012011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12002
12003 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
12004
12005 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12006 for fringe update if it has periodic bitmap.
ac389d0c 12007 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12008 and fringe_bitmap_periodic_p.
12009
12010 * fringe.c (get_fringe_bitmap_data): New function.
12011 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12012 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12013 row. Mark glyph row for fringe update if periodicity changed.
12014
12015 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12016 for fringe update unless it has periodic bitmap.
12017
f16d9837
KH
120182011-05-25 Kenichi Handa <handa@m17n.org>
12019
12020 * xdisp.c (get_next_display_element): Set correct it->face_id for
12021 a static composition.
12022
e1b90ef6
LL
120232011-05-24 Leo Liu <sdl.web@gmail.com>
12024
12025 * deps.mk (fns.o):
12026 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12027
12028 * fns.c (crypto_hash_function, Fsha1): New function.
12029 (Fmd5): Use crypto_hash_function.
12030 (syms_of_fns): Add Ssha1.
12031
7400048f
PE
120322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12033
12034 * gnutls.c: Remove unused macros.
12035 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12036 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12037 Remove macros that are defined and never used.
12038 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12039
abb71cf4
CY
120402011-05-22 Chong Yidong <cyd@stupidchicken.com>
12041
12042 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12043 (Fx_get_selection_internal): Minor cleanup.
12044 (Fx_own_selection_internal): Rename arguments for consistency with
12045 select.el.
12046
6307db39
PE
120472011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12048
12049 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12050
f3d4e0a4
CY
120512011-05-22 Chong Yidong <cyd@stupidchicken.com>
12052
12053 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12054
4d8ade89
YM
120552011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12056
12057 * dispnew.c (scrolling_window): Don't exclude the case that the
12058 last enabled row in the desired matrix touches the bottom boundary.
12059
32078c8d
GM
120602011-05-21 Glenn Morris <rgm@gnu.org>
12061
12062 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12063 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12064 and add some more files.
32078c8d 12065
7285dc67
EZ
120662011-05-20 Eli Zaretskii <eliz@gnu.org>
12067
12068 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12069 report_file_error introduced by the change from 2011-05-07.
12070
89d1bd22
PE
120712011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12072
12073 * systime.h (Time): Define only if emacs is defined.
12074 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12075 where the include path doesn't have X11/X.h by default. See
12076 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12077
cd394be1 120782011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12079
12080 * composite.c (find_automatic_composition): Fix previous change.
12081
b9704ad9
GM
120822011-05-20 Glenn Morris <rgm@gnu.org>
12083
12084 * lisp.mk: New file, split from Makefile.in.
12085 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12086 (shortlisp): Remove.
12087 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12088
4a720484
GM
120892011-05-19 Glenn Morris <rgm@gnu.org>
12090
12091 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12092 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12093 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12094 (lisp): Set the order to that of loadup.el.
12095 (shortlisp): Make it a copy of $lisp.
12096 (SOME_MACHINE_LISP): Remove.
12097 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12098 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12099
a28d4396
KH
121002011-05-18 Kenichi Handa <handa@m17n.org>
12101
12102 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12103 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12104 (find_automatic_composition): Mostly rewrite for efficiency.
12105
a2b1fa8e
JB
121062011-05-18 Juanma Barranquero <lekktu@gmail.com>
12107
12108 * makefile.w32-in: Update dependencies.
12109
8e1f5610
CS
121102011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12111
12112 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12113 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12114
7025ee00 121152011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12116
cdfa6eab
PE
12117 Fix some integer overflow issues, such as string length overflow.
12118
06d6db33
PE
12119 * insdel.c (count_size_as_multibyte): Check for string overflow.
12120
2b4560a8
PE
12121 * character.c (lisp_string_width): Check for string overflow.
12122 Use EMACS_INT, not int, for string indexes and lengths; in
12123 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12124 the resulting string length overflows an EMACS_INT; instead,
12125 report a string overflow if no precision given. When checking for
12126 precision exhaustion, use a check that cannot possibly have
12127 integer overflow. (Bug#8675)
12128 * character.h (lisp_string_width): Adjust to new signature.
12129
cb93f9be
PE
12130 * alloc.c (string_overflow): New function.
12131 (Fmake_string): Use it. This doesn't change behavior, but saves
12132 a few bytes and will simplify future changes.
12133 * character.c (string_escape_byte8): Likewise.
12134 * lisp.h (string_overflow): New decl.
12135
1a1f3366
PE
12136 Fixups, following up to the user-interface timestamp change.
12137 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12138 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12139 * msdos.c (mouse_get_pos): Likewise.
12140 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12141 * w32gui.h (Time): Define by including "systime.h" rather than by
12142 declaring it ourselves. (Bug#8664)
12143
d4e3e4d3
PE
12144 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12145 * image.c (clear_image_cache): Likewise.
12146
f6a24d19
PE
12147 * term.c (term_mouse_position): Don't assume time_t wraparound.
12148
08dc5ae6
PE
12149 Be more systematic about user-interface timestamps.
12150 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12151 and sometimes 'EMACS_UINT', to represent these timestamps.
12152 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12153 This makes the code easier to follow, and makes it easier to catch
12154 integer overflow bugs such as Bug#8664.
12155 * frame.c (Fmouse_position, Fmouse_pixel_position):
12156 Use Time, not unsigned long, for user-interface timestamps.
12157 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12158 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12159 * keyboard.h (last_event_timestamp): Likewise.
12160 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12161 * menu.h (xmenu_show): Likewise.
12162 * term.c (term_mouse_position): Likewise.
12163 * termhooks.h (struct input_event.timestamp): Likewise.
12164 (struct terminal.mouse_position_hook): Likewise.
12165 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12166 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12167 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12168 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12169 what it was before.
12170 * menu.h, termhooks.h: Include "systime.h", for Time.
12171
8e55734a
PE
12172 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12173 Don't assume that the difference between two unsigned long values
12174 can fit into an integer. At this point, we know button_down_time
12175 <= event->timestamp, so the difference must be nonnegative, so
12176 there's no need to cast the result if double-click-time is
12177 nonnegative, as it should be; check that it's nonnegative, just in
12178 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12179 apart (about 25 days). (Bug#8664)
8e55734a 12180
841f1b75 12181 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12182 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12183
3e26f69c
PE
12184 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12185 that always fit in int. Use a sentinel instead of a counter, to
12186 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12187 * frame.h (struct frame): Use int for menu_bar_items_used
12188 instead of EMACS_INT, since it always fits in int.
3e26f69c 12189
5cc152c0
PE
12190 * menu.c (grow_menu_items): Check for int overflow.
12191
d89eb65e
PE
12192 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12193
5235bd3e
PE
12194 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12195 Before, the code was not consistent. These values cannot exceed
12196 2**31 - 1 so there's no need to make them unsigned.
12197 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12198 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12199 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12200 as modifiers.
12201 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12202
bc827e23
PE
12203 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12204 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12205 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12206 presumably because the widths might not match.
12207
78eb494e
PE
12208 * window.c (size_window): Avoid needless test at loop start.
12209
04f2d78b
CB
122102011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12211
12212 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12213
d2fc7e3d 122142011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12215
12216 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12217
d2fc7e3d 122182011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12219
12220 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12221 `width' to `bar_area_x' and `bar_area_width', respectively.
12222 (x_scroll_run): Take account of fringe background extension.
12223
04f2d78b
CB
12224 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12225 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12226 `bar_area_width', respectively.
12227 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12228 background extension.
12229
79b70037
GM
122302011-05-10 Jim Meyering <meyering@redhat.com>
12231
12232 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12233
2f142cc5
JB
122342011-05-10 Juanma Barranquero <lekktu@gmail.com>
12235
12236 * image.c (Finit_image_library): Return t for built-in image types,
12237 like pbm and xbm. (Bug#8640)
12238
57679c86
AS
122392011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12240
12241 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12242
888c9e86
EZ
122432011-05-07 Eli Zaretskii <eliz@gnu.org>
12244
b0512a1d
EZ
12245 * w32console.c (Fset_screen_color): Doc fix.
12246 (Fget_screen_color): New function.
12247 (syms_of_ntterm): Defsubr it.
12248
7285dc67
EZ
12249 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12250 unlink the temporary file if Fcall_process didn't create it in the
12251 first place.
12252 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12253 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12254 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12255 cue to call_process_cleanup not to close that handle.
12256
4d3fcc8e
BK
122572011-05-07 Ben Key <bkey76@gmail.com>
12258
12259 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12260 one of two shell specific rules, either bootstrap-temacs-CMD or
12261 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12262 to the previous implementation of the bootstrap-temacs rule.
12263 The bootstrap-temacs-CMD rule is similar to the previous
12264 implementation of the bootstrap-temacs rule except that it
12265 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12266 variable.
12267
12268 These changes, along with some changes to nt/configure.bat,
12269 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12270 earlier fix to add support for --cflags and --ldflags options
12271 that include quotes so that it works whether make uses cmd or
12272 sh as the shell.
12273
b4289b64
MA
122742011-05-06 Michael Albinus <michael.albinus@gmx.de>
12275
12276 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12277 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12278 is a constant.
12279 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12280 a string. Handle both cases.
12281 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12282 (Fdbus_register_method): Use Qinvalid_function.
12283
af4c0e28
JB
122842011-05-06 Juanma Barranquero <lekktu@gmail.com>
12285
12286 * makefile.w32-in: Update dependencies.
12287 (LISP_H): Add inttypes.h and stdin.h.
12288 (PROCESS_H): Add unistd.h.
12289
c51453d9
EZ
122902011-05-06 Eli Zaretskii <eliz@gnu.org>
12291
12292 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12293 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12294
8ff0ac3c 122952011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12296
4c4b566b
PE
12297 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12298
aab2b9b5
PE
12299 * term.c (vfatal): Remove stray call to va_end.
12300 It's not needed and the C Standard doesn't allow it here anyway.
12301
c378da0b
PE
12302 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12303 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12304
288b08c7
PE
12305 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12306 bytes.
12307
e3601888
PE
12308 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12309
db6c0e74
PE
12310 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12311
dd5963ea
PE
12312 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12313
88c9450f
PE
12314 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12315
2f9442b8
PE
12316 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12317
c032b5f8
PE
12318 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12319 * charset.c (Fdefine_charset_internal): Don't initialize
12320 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12321 32-bit int (Bug#8600).
a108c10b
PE
12322
12323 * lread.c (read_integer): Be more consistent with string-to-number.
12324 Use string_to_number to do the actual conversion; this avoids
12325 rounding errors and fixes some other screwups. Without this fix,
12326 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12327 (digit_to_number): Move earlier, for benefit of read_integer.
12328 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12329 not a digit in any supported base. (Bug#8602)
a108c10b 12330
ad5f9eea
PE
12331 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12332
aec1708a
PE
12333 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12334 to match comment at start of function. This also removes a
12335 GCC warning about overflow in a 32+64-bit port.
12336
47be4ab5
PE
12337 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12338
371cac43
PE
12339 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12340 Reported by Stefan Monnier in
12341 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12342 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12343 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12344
d01a7826
PE
12345 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12346 (EMACS_UINTPTR): Likewise, with uintptr_t.
12347
7fd47d5c
PE
12348 * lisp.h: Prefer 64-bit EMACS_INT if available.
12349 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12350 on 32-bit hosts that have 64-bit int, so that they can access
12351 large files.
122b0c86
PE
12352 However, temporarily disable this change unless the temporary
12353 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12354
8727937b
PE
12355 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12356
8ac068ac
PE
12357 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12358 This removes an assumption that EMACS_INT and long are the same
12359 width as pointers. The assumption is true for Emacs porting targets
12360 now, but we want to make other targets possible.
12361 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12362 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12363 In the rest of the code, change types of integers that hold casted
12364 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12365 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12366 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12367 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12368 No need to cast type when ORing.
12369 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12370 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12371 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12372 assume EMACS_INT is the same width as char *.
12373 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12374 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12375 Remove no-longer-needed casts.
12376 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12377 (xg_tool_bar_help_callback, xg_make_tool_item):
12378 Use EMACS_INTPTR to hold an integer
12379 that will be cast to void *; this can avoid a GCC warning
12380 if EMACS_INT is not the same width as void *.
12381 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12382 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12383 (current_message_1, set_message_1):
12384 Use a local to convert to proper width without a cast.
12385 * xmenu.c (dialog_selection_callback): Likewise.
12386
ede49d71
PE
12387 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12388 Also, don't assume VALBITS / RAND_BITS is less than 5,
12389 and don't rely on undefined behavior when shifting a 1 left into
12390 the sign bit.
12391 * lisp.h (get_random): Change signature to match.
12392
2f30ecd0
PE
12393 * lread.c (hash_string): Use size_t, not int, for hash computation.
12394 Normally we prefer signed values; but hashing is special, because
12395 it's better to use unsigned division on hash table sizes so that
12396 the remainder is nonnegative. Also, size_t is the natural width
12397 for hashing into memory. The previous code used 'int', which doesn't
12398 retain enough info to hash well into very large tables.
12399 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12400
2a866e7b
PE
12401 * dbusbind.c: Don't possibly lose pointer info when converting.
12402 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12403 Use XPNTR rather than XHASH, so that the high-order bits of
12404 the pointer aren't lost when converting through void *.
12405
51639eac
PE
12406 * eval.c (Fautoload): Don't double-shift a pointer.
12407
92394119
PE
12408 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12409
dbdb9a7c
JB
124102011-05-06 Juanma Barranquero <lekktu@gmail.com>
12411
12412 * gnutls.c (DEF_GNUTLS_FN):
12413 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12414
db7a0b4f
AS
124152011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12416
12417 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12418 marker. (Bug#8610)
12419
cd394be1 124202011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12421
12422 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12423 New version that can reserve upto 2GB of heap space.
12424
f7ff1b0f 124252011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12426
12427 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12428
639c109b
TZ
124292011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12430
12431 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12432 `gnutls_certificate_set_x509_key_file'.
12433
d2127135
JB
124342011-05-05 Juanma Barranquero <lekktu@gmail.com>
12435
12436 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12437 Update dependencies.
12438
e968f4f3
JB
124392011-05-04 Juanma Barranquero <lekktu@gmail.com>
12440
12441 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12442 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12443 Remove unused parameter `fildes'.
12444 * process.c (read_process_output, send_process): Don't pass it.
12445
84d358f0
JB
124462011-05-04 Juanma Barranquero <lekktu@gmail.com>
12447
12448 Fix previous change: the library cache is defined in w32.c.
12449 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12450 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12451
0898ca10
JB
124522011-05-04 Juanma Barranquero <lekktu@gmail.com>
12453
12454 Implement dynamic loading of GnuTLS on Windows.
12455
12456 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12457 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12458 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12459 Declare.
12460
12461 * gnutls.c (Qgnutls_dll): Define.
12462 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12463 (gnutls_*): Declare function pointers.
12464 (init_gnutls_functions): New function to initialize function pointers.
12465 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12466 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12467 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12468 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12469 (emacs_gnutls_write, emacs_gnutls_read)
12470 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12471 (Fgnutls_available_p): New function.
12472 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12473 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12474 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12475
12476 * image.c: Include w32.h.
12477 (Vimage_type_cache): Delete.
12478 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12479 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12480 (w32_delayed_load): Move to w32.c.
12481
12482 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12483
12484 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12485 (w32_delayed_load): Move from image.c. When loading a library, record
12486 its filename in the :loaded-from property of the library id.
12487 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12488 Initialize and staticpro them.
12489 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12490
12491 * process.c: Include lisp.h before w32.h, not after.
12492 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12493 instead of gnutls_record_check_pending.
12494
12495 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12496
ff4de4aa
TZ
124972011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12498
12499 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12500 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12501 as passed in.
12502
abe95abb
JD
125032011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12504
12505 * xterm.c (x_set_frame_alpha): Do not set property on anything
12506 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12507
e16e55d4
JB
125082011-05-02 Juanma Barranquero <lekktu@gmail.com>
12509
12510 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12511
bafcf6a5
JB
125122011-05-02 Juanma Barranquero <lekktu@gmail.com>
12513
12514 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12515 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12516 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12517 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12518 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12519 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12520 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12521 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12522 (Qgnutls_bootprop_callbacks_verify): Make static.
12523
e7a6747f
AS
125242011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12525
19ed11ba
AS
12526 * callproc.c: Indentation fixup.
12527
e7a6747f 12528 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12529 (wait_for_termination, interruptible_wait_for_termination):
12530 Move after wait_for_termination_1.
e7a6747f 12531
1ef14cb4
LMI
125322011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12533
12534 * sysdep.c (interruptible_wait_for_termination): New function
12535 which is like wait_for_termination, but allows keyboard
12536 interruptions.
12537
12538 * callproc.c (Fcall_process): Add (:file "file") as an option for
12539 the STDOUT buffer.
12540 (Fcall_process_region): Ditto.
12541
330d880c
EZ
125422011-04-30 Eli Zaretskii <eliz@gnu.org>
12543
8db90b73
EZ
12544 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12545 rather than `XVECTOR (FOO)->size'.
12546
330d880c
EZ
12547 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12548 inttypes.h, as a gnulib replacement is used if it not available in
12549 system headers.
12550
15cbd324
EZ
125512011-04-21 Eli Zaretskii <eliz@gnu.org>
12552
12553 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12554 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12555 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12556
12557 * coding.c (coding_alloc_by_realloc): Error out if destination
12558 will grow beyond MOST_POSITIVE_FIXNUM.
12559 (decode_coding_emacs_mule): Abort if there isn't enough place in
12560 charbuf for the composition carryover bytes. Reserve an extra
12561 space for up to 2 characters produced in a loop.
12562 (decode_coding_iso_2022): Abort if there isn't enough place in
12563 charbuf for the composition carryover bytes.
12564
125652011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12566
ae940cca
EZ
12567 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12568 aborting when %lld or %lll format is passed.
12569 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12570 %llo or %llx format is passed. (Bug#8545)
12571
03ab8921
EZ
12572 * window.c (window_scroll_line_based): Use a marker instead of
12573 simple variables to record original value of point. (Bug#7952)
12574
afda1437
EZ
12575 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12576 produced by %s or %c overflows available buffer space. (Bug#8545)
12577
f76dee0c
PE
125782011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12579
12580 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12581 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12582
fdc5744d
JB
125832011-04-28 Juanma Barranquero <lekktu@gmail.com>
12584
12585 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12586
638f053a
JB
125872011-04-28 Juanma Barranquero <lekktu@gmail.com>
12588
12589 * keyboard.c (Qdelayed_warnings_hook): Define.
12590 (command_loop_1): Run `delayed-warnings-hook'
12591 if Vdelayed_warnings_list is non-nil.
12592 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12593 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12594
d178f871
EZ
125952011-04-28 Eli Zaretskii <eliz@gnu.org>
12596
12597 * doprnt.c (doprnt): Don't return value smaller than the buffer
12598 size if the message was truncated. (Bug#8545).
12599
b124fd93
JB
126002011-04-28 Juanma Barranquero <lekktu@gmail.com>
12601
12602 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12603 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12604
e810457d
PE
126052011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12606
12607 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12608
ea51cceb
JB
126092011-04-27 Juanma Barranquero <lekktu@gmail.com>
12610
12611 * makefile.w32-in: Update dependencies.
12612
94dcfacf
EZ
126132011-04-27 Eli Zaretskii <eliz@gnu.org>
12614
12615 Improve `doprnt' and its usage. (Bug#8545)
12616 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12617 `format_end'. Remove support for %l as a conversion specifier.
12618 Don't use xrealloc. Improve diagnostics when the %l size modifier
12619 is used. Update the commentary.
12620
12621 * eval.c (verror): Simplify calculation of size_t.
12622
12623 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12624 messages.
12625
f61f41d7
PE
126262011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12627
12628 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12629 change.
12630
96fb4434
PE
126312011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12632
12633 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12634 This makes this file independent of the recent pseudovector change.
12635
671875da 126362011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12637
69e9b5a3
PE
12638 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12639
b5f869a7 12640 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12641 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12642 Remove unused local.
c8926152 12643 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12644
841a1577 12645 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12646 GCC 4.6.0 optimizes based on type-based alias analysis.
12647 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12648 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12649 != &v->size, and therefore "v->size = 1; b->size = 2; return
12650 v->size;" must therefore return 1. This assumption is incorrect
12651 for Emacs, since it type-puns struct Lisp_Vector * with many other
12652 types. To fix this problem, this patch adds a new type struct
f904488f 12653 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12654 and pseudovectors, and helps optimizing compilers not get fooled
12655 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12656 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12657 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12658 the size member.
eab3844f
PE
12659 (XSETPVECTYPE): Rewrite in terms of new macro.
12660 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12661 This is a bit clearer, and further avoids the possibility of
12662 undesirable aliasing.
12663 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12664 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12665 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12666 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12667 (ASIZE): Now uses header.size rather than size.
12668 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12669 to avoid the hassle of writing XVECTOR (foo)->header.size.
12670 (struct vectorlike_header): New type.
eab3844f
PE
12671 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12672 object, to help avoid aliasing.
12673 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12674 (SUBRP): Likewise, since Lisp_Subr is a special case.
12675 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12676 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12677 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12678 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12679 changed to be "header.size" and "header.next".
12680 * buffer.h (struct buffer): Likewise.
12681 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12682 * frame.h (struct frame): Likewise.
12683 * process.h (struct Lisp_Process): Likewise.
12684 * termhooks.h (struct terminal): Likewise.
12685 * window.c (struct save_window_data, struct saved_window): Likewise.
12686 * window.h (struct window): Likewise.
12687 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12688 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12689 * buffer.c (init_buffer_once): Likewise.
12690 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12691 special case.
12692 * process.c (Fformat_network_address): Use local var for size,
12693 for brevity.
12694
0df1eac5
PE
12695 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12696
847ab9d1 12697 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12698 * data.c (atof): Remove decl; no longer used or needed.
12699 (digit_to_number): Move to lread.c.
12700 (Fstring_to_number): Use new string_to_number function, to be
12701 consistent with how the Lisp reader treats infinities and NaNs.
12702 Do not assume that floating-point numbers represent EMACS_INT
12703 without losing information; this is not true on most 64-bit hosts.
12704 Avoid double-rounding errors, by insisting on integers when
12705 parsing non-base-10 numbers, as the documentation specifies.
12706 * lisp.h (string_to_number): New decl, replacing ...
12707 (isfloat_string): Remove.
bc0a5c13 12708 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12709 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12710 appears to have been a coding error. Similarly, do not accept
12711 strings like +-1e0 as floating point numbers. Do not report
12712 overflow for integer overflows unless the base is not 10 which
12713 means we have no simple and reliable way to continue.
12714 Break out the floating-point parsing into a new
12715 function string_to_number, so that Fstring_to_number parses
12716 floating point numbers consistently with the Lisp reader.
04f2d78b 12717 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12718 (E_CHAR, EXP_INT): Remove, replacing with ...
12719 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12720 (string_to_number): New function, replacing isfloat_string.
12721 This function checks for valid syntax and produces the resulting
12722 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12723 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12724 so that overflow for non-base-10 numbers is reported only when
12725 there's no portable and simple way to convert to floating point.
452f4150 12726
67769ffc
PE
12727 * textprop.c (set_text_properties_1): Rewrite for clarity,
12728 and to avoid GCC warning about integer overflow.
12729
c20db43f
PE
12730 * intervals.h (struct interval): Use EMACS_INT for members
12731 where EMACS_UINT might cause problems. See
12732 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12733 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12734 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12735 All uses changed.
37aa2f85
PE
12736 (offset_intervals): Tell GCC not to worry about length overflow
12737 when negating a negative length.
c20db43f 12738
2538aa2f
PE
12739 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12740 (overrun_check_free): Likewise.
12741
f2d3008d
PE
12742 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12743 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12744 word size.
12745
ec8df744
PE
12746 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12747 (gnutls_make_error): Rename local to avoid shadowing.
12748 (gnutls_emacs_global_deinit): ifdef out; not used.
12749 (Fgnutls_boot): Use const for pointer to readonly storage.
12750 Comment out unused local. Fix pointer signedness problems.
12751
640ee02d
PE
12752 * lread.c (openp): Don't stuff size_t into an 'int'.
12753 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12754 about possible signed overflow.
12755
6048fb2a
PE
12756 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12757 (GDK_KEY_g): Don't define if already defined.
12758 (xg_prepare_tooltip): Avoid pointer signedness problem.
12759 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12760
fa3c87e1
PE
12761 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12762 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12763
2172544b
PE
12764 * xfns.c (Fx_window_property): Simplify a bit,
12765 to make a bit faster and to avoid GCC 4.6.0 warning.
12766 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12767
9b821a21
PE
12768 * fns.c (internal_equal): Don't assume size_t fits in int.
12769
3c616cfa
PE
12770 * alloc.c (compact_small_strings): Tighten assertion a little.
12771
c2982e87
PE
12772 Replace pEd with more-general pI, and fix some printf arg casts.
12773 * lisp.h (pI): New macro, generalizing old pEd macro to other
12774 conversion specifiers. For example, use "...%"pI"d..." rather
12775 than "...%"pEd"...".
12776 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12777 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12778 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12779 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12780 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12781 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12782 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12783 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12784 64-bit hosts.
12785 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12786 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12787 * print.c (safe_debug_print, print_object): Likewise.
12788 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12789 to int.
6f04d126
PE
12790 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12791 avoiding the 0 flag, which is not portable.
c2982e87
PE
12792 * process.c (Fmake_network_process): Use pI to avoid cast.
12793 * region-cache.c (pp_cache): Likewise.
12794 * xdisp.c (decode_mode_spec): Likewise.
12795 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12796 behavior on 64-bit hosts with printf arg.
6f04d126 12797 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12798 (x_stop_queuing_selection_requests): Likewise.
12799 (x_get_window_property): Don't truncate byte count to an 'int'
12800 when tracing.
0b432f21 12801
5e073ec7
PE
12802 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12803 here, since it parses constructs like leading '-' and spaces,
12804 which are not wanted; and it overflows with large numbers.
12805 Instead, simply match F[0-9]+, which is what is wanted anyway.
12806
36372bf9
PE
12807 * alloc.c: Remove unportable assumptions about struct layout.
12808 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12809 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12810 (allocate_vectorlike, make_pure_vector): Use the new macros,
12811 plus offsetof, to remove unportable assumptions about struct layout.
12812 These assumptions hold on all porting targets that I know of, but
12813 they are not guaranteed, they're easy to remove, and removing them
12814 makes further changes easier.
12815
0b432f21
PE
12816 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12817 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12818 (string_overrun_cookie): Now const. Use initializers that
12819 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12820 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12821 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12822 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12823 multiple of sizeof (EMACS_INT); it need not be, if
12824 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12825 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12826
895009e1
JB
128272011-04-26 Juanma Barranquero <lekktu@gmail.com>
12828
12829 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12830
6a7a1b0b
TZ
128312011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12832
12833 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12834 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12835 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12836
841a1577 128372011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12838
12839 * lisp.h (Qdebug): List symbol.
895009e1 12840 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12841 * keyboard.c (debug-on-event): New variable.
12842 (handle_user_signal): Break into debugger when debug-on-event
12843 matches the current signal symbol.
12844
f2d3ba6f
DN
128452011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12846
12847 * alloc.c (check_sblock, check_string_bytes)
12848 (check_string_free_list): Convert to standard C.
12849
42ce4c63
TZ
128502011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12851
12852 * w32.c (emacs_gnutls_push): Fix typo.
12853
825cd63c
EZ
128542011-04-25 Eli Zaretskii <eliz@gnu.org>
12855
fb11d64d
EZ
12856 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12857 "cast to pointer from integer of different size".
12858
825cd63c
EZ
12859 Improve doprnt and its use in verror. (Bug#8545)
12860 * doprnt.c (doprnt): Document the set of format control sequences
12861 supported by the function. Use SAFE_ALLOCA instead of always
12862 using `alloca'.
12863
12864 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12865 is one byte too soon. Don't use xrealloc; instead xfree and
12866 xmalloc anew.
12867
e061a11b
TZ
128682011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12869
12870 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12871 callbacks stage.
12872
12873 * gnutls.c: Renamed global_initialized to
12874 gnutls_global_initialized. Added internals for the
12875 :verify-hostname-error, :verify-error, and :verify-flags
12876 parameters of `gnutls-boot' and documented those parameters in the
12877 docstring. Start callback support.
9173deec
JB
12878 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12879 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12880 on error. Return error code.
e061a11b
TZ
12881 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12882 (emacs_gnutls_read): Likewise.
12883 (Fgnutls_boot): Return handshake error code.
12884 (emacs_gnutls_handle_error): New function.
12885 (wsaerror_to_errno): Likewise.
12886
12887 * w32.h (emacs_gnutls_pull): Add prototype.
12888 (emacs_gnutls_push): Likewise.
12889
12890 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12891 (emacs_gnutls_push): Likewise.
12892
128932011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12894
12895 * process.c (wait_reading_process_output): Check if GnuTLS
12896 buffered some data internally if no FDs are set for TLS
12897 connections.
12898
12899 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12900 (LIBS): Link to USER_LIBS.
12901 ($(BLD)/gnutls.$(0)): New target.
12902
fa6996bc
EZ
129032011-04-24 Eli Zaretskii <eliz@gnu.org>
12904
eb35682e
EZ
12905 * xdisp.c (handle_single_display_spec): Rename the
12906 display_replaced_before_p argument into display_replaced_p, to
12907 make it consistent with the commentary. Fix typos in the
12908 commentary.
12909
e2ad650c
EZ
12910 * textprop.c (syms_of_textprop): Remove dead code.
12911 (copy_text_properties): Delete obsolete commentary about an
12912 interface that was deleted long ago. Fix typos in the description
12913 of arguments.
12914
1b2de274
EZ
12915 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12916 to changes in oldXMenu/XMenu.h from 2011-04-16.
12917 <menu_help_message, prev_menu_help_message>: Constify.
12918 (IT_menu_make_room): menu->help_text is now `const char **';
12919 adjust.
12920
12921 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12922 to changes in oldXMenu/XMenu.h from 2011-04-16.
12923 (struct XMenu): Declare `help_text' `const char **'.
12924
12925 * xfaces.c <Qunspecified>: Make extern again.
12926
12927 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12928 required by POSIX.
1b2de274 12929
762b15be
EZ
12930 * doc.c (get_doc_string): Improve the format passed to `error'.
12931
12932 * doprnt.c (doprnt): Improve commentary.
12933
12934 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12935
12936 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12937 them with etags.
12938
f1052e5d
EZ
12939 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12940 changes in globals.h immediately force recompilation.
762b15be
EZ
12941 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12942 $(CURDIR)/s/ms-w32.h.
12943 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12944
fa6996bc
EZ
12945 * character.c (Fchar_direction): Function deleted.
12946 (syms_of_character): Don't defsubr it.
12947 <char-direction-table>: Deleted.
12948
e6c3da20
EZ
129492011-04-23 Eli Zaretskii <eliz@gnu.org>
12950
12951 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12952 * doprnt.c: Include limits.h.
12953 (SIZE_MAX): New macro.
04f2d78b
CB
12954 (doprnt): Return a size_t value. 2nd arg is now size_t.
12955 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12956 Improve overflow protection. Support `l' modifier for integer
12957 conversions. Support %l conversion. Don't assume an EMACS_INT
12958 argument for integer conversions and for %c.
12959
12960 * lisp.h (doprnt): Restore prototype.
12961
12962 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12963 $(SRC)/character.h.
12964
12965 * Makefile.in (base_obj): Add back doprnt.o.
12966
12967 * deps.mk (doprnt.o): Add back prerequisites.
12968 (callint.o): Depend on character.h.
12969
12970 * eval.c (internal_lisp_condition_case): Include the handler
12971 representation in the error message.
12972 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12973 when breaking from the loop.
12974
12975 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12976
12977 * callint.c (Fcall_interactively): When displaying error message
12978 about invalid control letter, pass the character's codepoint, not
12979 a pointer to its multibyte form. Improve display of the character
12980 in octal and display also its hex code.
12981
12982 * character.c (char_string): Use %x to display the (unsigned)
12983 codepoint of an invalid character, to avoid displaying a bogus
12984 negative value.
12985
12986 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12987 `error', not SYMBOL_NAME itself.
12988
12989 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12990 character arguments to `error'.
12991
12992 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12993 to `error' in error message about FINAL_CHAR argument. Make sure
12994 FINAL_CHAR is a character, and use %c when it is passed as
12995 argument to `error'.
12996
4ffd0d6b 129972011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12998
12999 * s/ms-w32.h (localtime): Redirect to sys_localtime.
13000
13001 * w32.c: Include <time.h>.
13002 (sys_localtime): New function.
13003
4ffd0d6b 130042011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
13005
13006 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13007
4ffd0d6b 13008 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13009
4ffd0d6b 130102011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13011
4ffd0d6b
GM
13012 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13013 zombies (Bug#8467).
aac0c6e3 13014
04c56954
EZ
130152011-04-19 Eli Zaretskii <eliz@gnu.org>
13016
13017 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13018 gl_state.e_property when gl_state.object is Qt.
13019
13020 * insdel.c (make_gap_larger): Remove limitation of buffer size
13021 to <= INT_MAX.
13022
16a43933
CY
130232011-04-18 Chong Yidong <cyd@stupidchicken.com>
13024
13025 * xdisp.c (lookup_glyphless_char_display)
13026 (produce_glyphless_glyph): Handle cons cell entry in
13027 glyphless-char-display.
13028 (Vglyphless_char_display): Document it.
13029
13030 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13031 glyphless-char-display.
13032
4581706e
CY
130332011-04-17 Chong Yidong <cyd@stupidchicken.com>
13034
13035 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13036
13037 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13038
13039 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13040 definition for no-X builds.
13041
4887c6e2 130422011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13043
fd35b6f9
PE
13044 Static checks with GCC 4.6.0 and non-default toolkits.
13045
5c1ccb01
PE
13046 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13047
006c5daa
PE
13048 * process.c (keyboard_bit_set): Define only if SIGIO.
13049 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13050 (send_process): Repair possible setjmp clobbering.
13051
efc736d3
PE
13052 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13053
4e2fe2e6
PE
13054 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13055
f97334a2
PE
13056 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13057
4e75f29d
PE
13058 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13059 Define only if needed.
13060
90efadd1
PE
13061 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13062 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13063 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13064
3c647824
PE
13065 * dispextern.h (struct redisplay_interface): Rename param
13066 to avoid shadowing.
e264f262 13067 * termhooks.h (struct terminal): Likewise.
761383f4 13068 * xterm.c (xembed_send_message): Likewise.
3c647824 13069
b58c5c4a
PE
13070 * insdel.c (make_gap_smaller): Define only if
13071 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13072
cad59032
PE
13073 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13074 it.
13075
c339dc2e
PE
13076 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13077 so that we aren't warned about unused symbols.
13078
91a3e27b
PE
13079 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13080
399c71d3 13081 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13082
8ffc96f5
PE
13083 * xfns.c (x_real_positions): Mark locals as initialized.
13084
eef9bc79
PE
13085 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13086
098db9dd
PE
13087 * xterm.c: Fix problems found by static analysis with other toolkits.
13088 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13089 (x_dispatch_event): Declare static if USE_GTK, and
13090 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13091 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13092 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13093 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13094 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13095
eb18f6cc
PE
13096 * xmenu.c (menu_help_callback): Pointer type fixes.
13097 Use const pointers when pointing at readonly data. Avoid pointer
13098 signedness clashes.
13099 (FALSE): Remove unused macro.
13100 (update_frame_menubar): Remove unused decl.
13101
1fe72bf8
PE
13102 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13103
60d9e1db
PE
13104 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13105 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13106 (single_menu_item): Rename local to avoid shadowing.
13107
39261c26
PE
13108 * keyboard.c (make_lispy_event): Remove unused local var.
13109
018c5e19
PE
13110 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13111 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13112
63d2b86e
PE
13113 * bitmaps: Change bitmaps from unsigned char back to the X11
13114 compatible char. Avoid the old compiler warnings about
13115 out-of-range initializers by using, for example, '\xab' rather
13116 than 0xab.
13117
aefd87e1
PE
13118 * xgselect.c (xgselect_initialize): Check vs interface
13119 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13120
bf501fb9
PE
13121 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13122
e9829fdf
PE
13123 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13124 to read-only memory.
13125
1086c095
PE
13126 * fns.c (vector): Remove; this old hack is no longer needed.
13127
2baccd04 13128 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13129 Remove unused var.
dde42981 13130 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13131
72391843 13132 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13133
436c16df 13134 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13135 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13136 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13137
92bb796d 13138 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13139 (x_term_init): Remove local to avoid shadowing.
92bb796d 13140
764430a3 13141 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13142
13143 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13144 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13145
d1dfb56c
EZ
131462011-04-16 Eli Zaretskii <eliz@gnu.org>
13147
c4354cb4
EZ
13148 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13149
d1dfb56c
EZ
13150 Fix regex.c, syntax.c and friends for buffers > 2GB.
13151 * syntax.h (struct gl_state_s): Declare character position members
13152 EMACS_INT.
13153
13154 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13155
04f2d78b
CB
13156 * textprop.c (verify_interval_modification, interval_of):
13157 Declare arguments EMACS_INT.
d1dfb56c
EZ
13158
13159 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13160 EMACS_INT.
13161
13162 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13163
13164 * indent.c (Fvertical_motion): Local variable it_start is now
13165 EMACS_INT.
13166
13167 * regex.c (re_match, re_match_2, re_match_2_internal)
13168 (bcmp_translate, regcomp, regexec, print_double_string)
13169 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13170 (re_compile_pattern, re_exec): Declare arguments and local
13171 variables `size_t' and `ssize_t' and return values `regoff_t', as
13172 appropriate.
13173 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13174 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13175 <compile_stack_type>: `size' and `avail' are now `size_t'.
13176
13177 * regex.h <regoff_t>: Use ssize_t, not int.
13178 (re_search, re_search_2, re_match, re_match_2): Arguments that
13179 specify buffer/string position and length are now ssize_t and
13180 size_t. Return type is regoff_t.
13181
613052cd
BK
131822011-04-16 Ben Key <bkey76@gmail.com>
13183
13184 * nsfont.m: Fixed bugs in ns_get_family and
13185 ns_descriptor_to_entity that were caused by using free to
13186 deallocate memory blocks that were allocated by xmalloc (via
13187 xstrdup). This caused Emacs to crash when compiled with
13188 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13189 --enable-checking=xmallocoverrun). xfree is now used to
13190 deallocate these memory blocks.
13191
4170f62f 131922011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13193
71b41406
PE
13194 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13195
9587a89d
PE
13196 emacs_write: Accept and return EMACS_INT for sizes.
13197 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13198 et seq.
13199 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13200 Accept and return EMACS_INT.
13201 (emacs_gnutls_write): Return the number of bytes written on
13202 partial writes.
13203 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13204 (emacs_read, emacs_write): Remove check for negative size, as the
13205 Emacs source code has been audited now.
9587a89d
PE
13206 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13207 (emacs_read, emacs_write): Use it.
273a5f82
PE
13208 * process.c (send_process): Adjust to the new signatures of
13209 emacs_write and emacs_gnutls_write. Do not attempt to store
13210 a byte offset into an 'int'; it might overflow.
9587a89d 13211 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13212
3e047f51
PE
13213 * sound.c: Don't assume sizes fit in 'int'.
13214 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13215 Return EMACS_INT, not int.
3e047f51 13216 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13217 Accept EMACS_INT, not int.
13218 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13219 record read return values.
13220
cc39a9db
BK
132212011-04-15 Ben Key <bkey76@gmail.com>
13222
c9d0ec6d
JB
13223 * keyboard.c (Qundefined): Don't declare static since it is used
13224 in nsfns.m.
13225 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13226 static since they are used in nsfont.m.
cc39a9db 13227
6c60eb9f
SM
132282011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13229
13230 * process.c (Qprocessp): Don't declare static.
13231 * lisp.h (Qprocessp): Declare again.
13232
7990b61a
JB
132332011-04-15 Juanma Barranquero <lekktu@gmail.com>
13234
13235 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13236
5d4cb038
PE
132372011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13238
8bd7b830 13239 Improve C-level modularity by making more things 'static'.
cd64ea1d 13240
e3b27b31
PE
13241 Don't publish debugger-only interfaces to other modules.
13242 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13243 (verify_bytepos, count_markers): Move decls to the only modules
13244 that need them.
13245 * region-cache.h (pp_cache): Likewise.
13246 * window.h (check_all_windows): Likewise.
13247 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13248
5d4cb038
PE
13249 * sysdep.c (croak): Now static, if
13250 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13251 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13252
13253 * alloc.c (refill_memory_reserve): Now static if
13254 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13255 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13256
e87b6180
PE
13257 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13258 Define only if USE_LUCID.
13259
ac64929e
PE
13260 * xrdb.c (x_customization_string, x_rm_string): Now static.
13261
6f37259d
PE
13262 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13263 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13264
1683e3ab
PE
13265 * xdisp.c (draw_row_with_mouse_face): Now static.
13266 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13267
de9c2632
PE
13268 * window.h (check_all_windows): Mark externally visible.
13269
2b96acb7
PE
13270 * window.c (window_deletion_count): Now static.
13271
13272 * undo.c: Make symbols static if they're not exported.
13273 (last_undo_buffer, last_boundary_position, pending_boundary):
13274 Now static.
13275
50436f33
PE
13276 * textprop.c (interval_insert_behind_hooks): Now static.
13277 (interval_insert_in_front_hooks): Likewise.
13278
64520e5c
PE
13279 * term.c: Make symbols static if they're not exported.
13280 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13281 (max_frame_lines, tty_set_terminal_modes):
13282 (tty_reset_terminal_modes, tty_turn_off_highlight):
13283 (get_tty_terminal): Now static.
13284 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13285 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13286 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13287 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13288 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13289
1fa53021
PE
13290 * sysdep.c: Make symbols static if they're not exported.
13291 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13292 Now static.
13293 (sigprocmask_set, full_mask): Remove; unused.
13294 (wait_debugging): Mark as visible.
13295 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13296 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13297
d4b43b22
PE
13298 * syntax.c (syntax_temp): Define only if !__GNUC__.
13299
b7c513d0
PE
13300 * sound.c (current_sound_device, current_sound): Now static.
13301
989b29ad
PE
13302 * search.c (searchbufs, searchbuf_head): Now static.
13303
13a55a78
PE
13304 * scroll.c (scroll_cost): Remove; unused.
13305 * dispextern.h (scroll_cost): Remove decl.
13306
de68a1fc
PE
13307 * region-cache.h (pp_cache): Mark as externally visible.
13308
40ccffa6
PE
13309 * process.c: Make symbols static if they're not exported.
13310 (process_tick, update_tick, create_process, chan_process):
13311 (Vprocess_alist, proc_buffered_char, datagram_access):
13312 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13313 (deactivate_process): Mark defn as static, as well as decl.
13314 * lisp.h (create_process): Remove decl.
13315 * process.h (chan_process, Vprocess_alist): Remove decls.
13316
ad64fc97
PE
13317 * print.c: Make symbols static if they're not exported.
13318 (print_depth, new_backquote_output, being_printed, print_buffer):
13319 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13320 (print_interval, print_number_index, initial_stderr_stream):
13321 Now static.
13322 * lisp.h (Fprinc): Remove decl.
13323 (debug_output_compilation_hack): Mark as externally visible.
13324
adddb265
PE
13325 * sysdep.c (croak): Move decl from here to syssignal.h.
13326 * syssignal.h (croak): Put it here, so the API can be checked when
13327 'croak' is called from dissociate_if_controlling_tty.
13328
1717ede2
PE
13329 * minibuf.c: Make symbols static if they're not exported.
13330 (minibuf_save_list, choose_minibuf_frame): Now static.
13331 * lisp.h (choose_minibuf_frame): Remove decl.
13332
fa5fb2bc
PE
13333 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13334
1e3890d1
PE
13335 * lread.c: Make symbols static if they're not exported.
13336 (read_objects, initial_obarray, oblookup_last_bucket_number):
13337 Now static.
13338 (make_symbol): Remove; unused.
13339 * lisp.h (initial_obarray, make_symbol): Remove decls.
13340
8a1414fa
PE
13341 * keyboard.c: Make symbols static if they're not exported.
13342 (single_kboard, recent_keys_index, total_keys, recent_keys):
13343 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13344 (this_single_command_key_start, echoing, last_auto_save):
13345 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13346 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13347 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13348 (Vlispy_mouse_stem, double_click_count):
13349 Now static.
13350 (force_auto_save_soon): Define only if SIGDANGER.
13351 (ignore_mouse_drag_p): Now static if
13352 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13353 (print_help): Remove; unused.
13354 (stop_character, last_timer_event): Mark as externally visible.
13355 * keyboard.h (ignore_mouse_drag_p): Declare only if
13356 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13357 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13358 * lisp.h (echoing): Remove decl.
13359 (force_auto_save_soon): Declare only if SIGDANGER.
13360 * xdisp.c (redisplay_window): Simplify code, to make it more
13361 obvious that ignore_mouse_drag_p is not accessed if !defined
13362 USE_GTK && !defined HAVE_NS.
13363
93ea6e8f
PE
13364 * intervals.c: Make symbols static if they're not exported.
13365 (merge_properties_sticky, merge_interval_right, delete_interval):
13366 Now static.
13367 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13368
77382fcc
PE
13369 * insdel.c: Make symbols static if they're not exported.
13370 However, leave prepare_to_modify_buffer alone. It's never
13371 called from outside this function, but that appears to be a bug.
13372 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13373 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13374 (adjust_after_replace_noundo): Remove; unused.
13375 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13376 (signal_before_change): Remove decls.
77382fcc 13377
9306c32e
PE
13378 * indent.c (val_compute_motion, val_vmotion): Now static.
13379
cd44d2eb
PE
13380 * image.c: Make symbols static if they're not exported.
13381 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13382 if USE_GTK.
13383 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13384 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13385
ad9a7a06
PE
13386 * fringe.c (standard_bitmaps): Now static.
13387 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13388
81626931
PE
13389 * frame.c: Make symbols static if they're not exported.
13390 (x_report_frame_params, make_terminal_frame): Now static.
13391 (get_frame_param): Now static, unless HAVE_NS.
13392 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13393 (x_get_resource_string): Remove; not used.
13394 * frame.h (make_terminal_frame, x_report_frame_params):
13395 (x_get_resource_string); Remove decls.
13396 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13397 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13398
239f9db9
PE
13399 * font.c, fontset.c: Make symbols static if they're not exported.
13400 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13401 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13402 * font.c (font_close_object): Now static.
13403 * font.h (font_close_object): Remove.
13404 * fontset.c (FONTSET_OBJLIST): Remove.
13405 (free_realized_fontset) #if-0 the body, which does nothing.
13406 (face_suitable_for_char_p): #if-0, as it's never called.
13407 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13408 * xfaces.c (face_at_string_position):
13409 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13410 since 0 is always ASCII.
13411
dfcf3579
PE
13412 * fns.c (weak_hash_tables): Now static.
13413
5045092b
PE
13414 * fileio.c: Make symbols static if they're not exported.
13415 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13416 (Vwrite_region_annotation_buffers): Now static.
13417
57a96f5c
PE
13418 * eval.c: Make symbols static if they're not exported.
13419 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13420 * lisp.h (backtrace_list): Remove decl.
13421
35f08c38
PE
13422 * emacs.c: Make symbols static if they're not exported.
13423 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13424 (fatal_error_code, fatal_error_signal_hook, standard_args):
13425 Now static.
13426 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13427 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13428 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13429 * lisp.h (fatal_error_signal_hook): Remove decl.
13430 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13431
f44bd759
PE
13432 * editfns.c: Move a (normally-unused) function to its only use.
13433 * editfns.c, lisp.h (get_operating_system_release): Remove.
13434 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13435 worth the hassle of breaking this out.
13436
b532497d
PE
13437 * xterm.c: Make symbols static if they're not exported.
13438 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13439 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13440 (x_destroy_window, x_delete_display):
13441 Now static.
13442 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13443 (x_mouse_leave): Remove; unused.
13444 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13445 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13446 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13447 Remove decls.
13448 (x_mouse_leave): Declare only if WINDOWSNT.
13449 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13450 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13451 USE_X_TOOLKIT.
13452
1675728f
PE
13453 * ftxfont.c: Make symbols static if they're not exported.
13454 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13455 HAVE_FREETYPE.
13456 * font.h (ftxfont_driver): Likewise.
13457
e4cebfca
PE
13458 * xfns.c: Make symbols static if they're not exported.
13459 (x_last_font_name, x_display_info_for_name):
13460 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13461 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13462 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13463 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13464 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13465 (last_show_tip_args): Now static.
13466 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13467 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13468 (x_screen_planes): Remove; unused.
13469 * dispextern.h (x_screen_planes): Remove decl.
13470
5bf46f05
PE
13471 * dispnew.c: Make symbols static if they're not exported.
13472 * dispextern.h (redraw_garbaged_frames, scrolling):
13473 (increment_row_positions): Remove.
13474 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13475 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13476 Now static.
13477 (redraw_garbaged_frames): Remove; unused.
13478
435f4c28
PE
13479 * xfaces.c: Make symbols static if they're not exported.
13480 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13481 Remove decls.
13482 * xterm.h (defined_color): Remove decls.
13483 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13484 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13485 (menu_face_changed_default, defined_color, free_realized_face):
13486 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13487 (ascii_face_of_lisp_face): Remove; unused.
13488
8524aef3
PE
13489 * xdisp.c: Make symbols static if they're not exported.
13490 * dispextern.h (scratch_glyph_row, window_box_edges):
13491 (glyph_to_pixel_coords, set_cursor_from_row):
13492 (get_next_display_element, set_iterator_to_next):
13493 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13494 (show_mouse_face): Remove decls
13495 * frame.h (message_buf_print): Likewise.
13496 * lisp.h (pop_message, set_message, check_point_in_composition):
13497 Likewise.
13498 * xterm.h (set_vertical_scroll_bar): Likewise.
13499 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13500 (message_buf_print, scratch_glyph_row, displayed_buffer):
13501 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13502 (get_next_display_element, show_mouse_face, window_box_edges):
13503 (frame_to_window_pixel_xy, check_point_in_composition):
13504 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13505 (glyph_to_pixel_coords): Remove; unused.
13506
16390cd2
PE
13507 * dired.c (file_name_completion): Now static.
13508
13509 * dbusbind.c (xd_in_read_queued_messages): Now static.
13510
a25f4dfa
PE
13511 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13512 * data.c (circular_list_error): Remove.
13513
14a9c8df
PE
13514 * commands.h (last_point_position, last_point_position_buffer):
13515 (last_point_position_window): Remove decls.
13516 * keyboard.c: Make these variables static.
13517
04f2d78b
CB
13518 * coding.h (coding, code_convert_region, encode_coding_gap):
13519 Remove decls.
74ab6df5
PE
13520 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13521 (iso_code_class, detect_coding, code_convert_region): Now static.
13522 (encode_coding_gap): Remove; unused.
13523
38dfbee1
PE
13524 * chartab.c (chartab_chars, chartab_bits): Now static.
13525
a2cb4e63
PE
13526 * charset.h (charset_iso_8859_1): Remove decl.
13527 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13528 Now static.
13529
127198fd
PE
13530 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13531 * ccl.c (Vccl_program_table): Now static.
13532 (check_ccl_update): Remove; unused.
13533
d85b608f
PE
13534 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13535 * category.h: ... from here.
13536 * category.c (check_category_table, set_category_set): Now static.
13537
31cd66f3
PE
13538 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13539 * lisp.h: Remove these decls.
13540
c358e587
PE
13541 * buffer.c (buffer_count): Remove unused var.
13542
e78aecca
PE
13543 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13544 so that it's not optimized away.
13545 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13546 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13547 exported only to the debugger.
13548
e192d7d3 13549 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13550 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13551
92470028
PE
13552 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13553 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13554 was inaccessible from Lisp.
13555 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13556 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13557
244ed907
PE
13558 alloc.c: Import and export fewer symbols, and remove unused items.
13559 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13560 is defined.
13561 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13562 it's not optimized away by whole-program optimization.
13563 (message_enable_multibyte, free_misc): Remove.
13564 (catchlist, handlerlist, mark_backtrace):
13565 Declare only if BYTE_MARK_STACK.
13566 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13567 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13568 (message_enable_multibyte): Remove decl.
13569 (free_misc, interval_free_list, float_block, float_block_index):
13570 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13571 (cons_free_list, last_marked_index):
13572 Now static.
13573 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13574 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13575 (mark_backtrace): Define only if BYTE_MARK_STACK.
13576 * xdisp.c (message_enable_multibyte): Now static.
13577
61c2b50e 13578 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13579 This makes it easier for human readers (and static analyzers)
13580 to see whether these variables are used from other modules.
13581 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13582 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13583 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13584 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13585 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13586 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13587 * xmenu.c, xselect.c:
13588 Declare Q* vars static if they are not used in other modules.
13589 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13590 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13591 Remove decls of unexported vars.
13592 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13593
95c82688
PE
13594 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13595
16a97296
PE
13596 Make Emacs functions such as Fatom 'static' by default.
13597 This makes it easier for human readers (and static analyzers)
13598 to see whether these functions can be called from other modules.
13599 DEFUN now defines a static function. To make the function external
13600 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13601 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13602 (Finit_image_library):
16a97296
PE
13603 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13604 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13605 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13606 Remove decls, since these functions are now static.
13607 (Funintern, Fget_internal_run_time): New decls, since these functions
13608 were already external.
95c82688 13609
16a97296
PE
13610 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13611 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13612 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13613 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13614 * keyboard.c, keymap.c, lread.c:
13615 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13616 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13617 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13618 Mark functions with DEFUE instead of DEFUN,
13619 if they are used in other modules.
13620 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13621 decls for now-static functions.
13622 * buffer.h (Fdelete_overlay): Remove decl.
13623 * callproc.c (Fgetenv_internal): Mark as internal.
13624 * composite.c (Fremove_list_of_text_properties): Remove decl.
13625 (Fcomposition_get_gstring): New forward static decl.
13626 * composite.h (Fcomposite_get_gstring): Remove decl.
13627 * dired.c (Ffile_attributes): New forward static decl.
13628 * doc.c (Fdocumntation_property): New forward static decl.
13629 * eval.c (Ffetch_bytecode): New forward static decl.
13630 (Funintern): Remove extern decl; now in .h file where it belongs.
13631 * fileio.c (Fmake_symbolic_link): New forward static decl.
13632 * image.c (Finit_image_library): New forward static decl.
13633 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13634 * intervals.h (Fprevious_property_change):
13635 (Fremove_list_of_text_properties): Remove decls.
13636 * keyboard.c (Fthis_command_keys): Remove decl.
13637 (Fcommand_execute): New forward static decl.
13638 * keymap.c (Flookup_key): New forward static decl.
13639 (Fcopy_keymap): Now static.
13640 * keymap.h (Flookup_key): Remove decl.
13641 * process.c (Fget_process): New forward static decl.
13642 (Fprocess_datagram_address): Mark as internal.
13643 * syntax.c (Fsyntax_table_p): New forward static decl.
13644 (skip_chars): Remove duplicate decl.
13645 * textprop.c (Fprevious_property_change): New forward static decl.
13646 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13647 Now internal.
13648 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13649 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13650
785bbd42
PE
13651 * editfns.c (Fformat): Remove unreachable code.
13652
8b913b57
AS
136532011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13654
13655 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13656 change. (Bug#8496)
13657
a6744a35
EZ
136582011-04-13 Eli Zaretskii <eliz@gnu.org>
13659
13660 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13661 when at ZV. (Bug#8487)
13662
e7974947
AS
136632011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13664
baad03f0
AS
13665 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13666 (Bug#8437)
13667 * keyboard.c (parse_tool_bar_item): Likewise.
13668 * sound.c (sound_cleanup, alsa_close): Likewise.
13669 * termcap.c (tgetent): Likewise.
13670 * xfns.c (x_default_font_parameter): Likewise.
13671 * xsettings.c (read_and_apply_settings): Likewise.
13672
e7974947
AS
13673 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13674 (overrun_check_free): Protoize.
13675
28272684
PE
136762011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13677
13678 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13679 since callers should never pass a negative size.
13680 Change the signature to match that of plain 'read' and 'write'; see
13681 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13682 * lisp.h: Update prototypes of emacs_write and emacs_read.
13683
11997c76
EZ
136842011-04-11 Eli Zaretskii <eliz@gnu.org>
13685
13686 * xdisp.c (redisplay_window): Don't try to determine the character
13687 position of the scroll margin if the window start point w->startp
e896f03c 13688 is outside the buffer's accessible region. (Bug#8468)
11997c76 13689
8a2cbd72
EZ
136902011-04-10 Eli Zaretskii <eliz@gnu.org>
13691
13692 Fix write-region and its subroutines for buffers > 2GB.
13693 * fileio.c (a_write, e_write): Modify declaration of arguments and
13694 local variables to support buffers larger than 2GB.
13695 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13696
13697 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13698 argument, local variables, and return value.
13699
13700 * lisp.h: Update prototypes of emacs_write and emacs_read.
13701
13702 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13703
4073e537 137042011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13705
1ebfdcb6
PE
13706 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13707
b2ded58d
PE
13708 Fix more problems found by GCC 4.6.0's static checks.
13709
7d66342c
PE
13710 * xdisp.c (vmessage): Use a better test for character truncation.
13711
bbf47d44
PE
13712 * charset.c (load_charset_map): <, not <=, for optimization,
13713 and to avoid potential problems with integer overflow.
9248994d 13714 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13715 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13716 * editfns.c (Fformat): Likewise.
1e69125e 13717 * syntax.c (skip_chars): Likewise.
3befa583 13718
e3019616
PE
13719 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13720 This also lets GCC 4.6.0 generate slightly better loop code.
13721
becfa255
PE
13722 * callint.c (Fcall_interactively): <, not <=, for optimization.
13723 (Fcall_interactively): Count the number of arguments produced,
13724 not the number of arguments given. This is simpler and lets GCC
13725 4.6.0 generate slightly better code.
13726
dae0cd48
PE
13727 * ftfont.c: Distingish more carefully between FcChar8 and char.
13728 The previous code passed unsigned char * to a functions like
13729 strlen and xstrcasecmp that expect char *, which does not
13730 conform to the C standard.
13731 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13732 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13733 char * when the C standard requires it.
13734
76032d70
PE
13735 * keyboard.c (read_char): Remove unused var.
13736
eb3f1cc8
PE
13737 * eval.c: Port to Windows vsnprintf (Bug#8435).
13738 Include <limits.h>.
13739 (SIZE_MAX): Define if the headers do not.
13740 (verror): Do not give up if vsnprintf returns a negative count.
13741 Instead, grow the buffer. This ports to Windows vsnprintf, which
13742 does not conform to C99. Problem reported by Eli Zaretskii.
13743 Also, simplify the allocation scheme, by avoiding the need for
13744 calling realloc, and removing the ALLOCATED variable.
13745
70476b54
PE
13746 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13747
12020a9e
PE
13748 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13749 But keep the doprint source code for now, as we might revamp it
13750 and use it again (Bug#8435).
ea6c7ae6
PE
13751 * lisp.h (doprnt): Remove.
13752 * Makefile.in (base_obj): Remove doprnt.o.
13753 * deps.mk (doprnt.o): Remove.
13754
5fdb398c
PE
13755 error: Print 32- and 64-bit integers portably (Bug#8435).
13756 Without this change, on typical 64-bit hosts error ("...%d...", N)
13757 was used to print both 32- and 64-bit integers N, which relied on
13758 undefined behavior.
61bdb816 13759 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13760 * lisp.h (error, verror): Mark as printf-like functions.
13761 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13762 Report overflow in size calculations when allocating printf buffer.
13763 Do not truncate output string at its first null byte.
13764 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13765 Truncate the output at a character boundary, since vsnprintf does not
13766 do that.
13767 * charset.c (check_iso_charset_parameter): Convert internal
13768 character to string before calling 'error', since %c now has the
13769 printf meaning.
13770 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13771 overflow when computing char to be passed to 'error'. Do not
13772 pass Lisp_Object to 'error'; pass the integer instead.
13773 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13774 formatted with plain %d.
13775
b189fa66
PE
13776 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13777
bff87ef0
PE
13778 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13779
7e2cac20
PE
13780 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13781
ce4d90b5
PE
13782 * xterm.c (x_catch_errors): Remove duplicate declaration.
13783
266c9547
PE
13784 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13785
79c49ad2
PE
13786 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13787
368f4090
JM
137882011-04-10 Jim Meyering <meyering@redhat.com>
13789
13790 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13791 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13792 return ssize_t not "int", and use size_t as the buffer length.
13793 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13794 * gnutls.h: Update declarations.
13795 * process.c (read_process_output): Use ssize_t, to match.
13796 (send_process): Likewise.
13797
a32d4040
CY
137982011-04-09 Chong Yidong <cyd@stupidchicken.com>
13799
13800 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13801
8546720e 138022011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13803
04f2d78b
CB
13804 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13805 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13806
8546720e
GM
13807 * xterm.c (handle_one_xevent):
13808 * xmenu.c (create_and_show_popup_menu):
13809 * xselect.c (x_decline_selection_request)
13810 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13811
0a2f5c1a 138122011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13813
13814 Fix some uses of `int' instead of EMACS_INT.
13815 * search.c (string_match_1, fast_string_match)
13816 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13817 (scan_buffer, find_next_newline_no_quit)
13818 (find_before_next_newline, search_command, Freplace_match)
13819 (Fmatch_data): Make some `int' variables be EMACS_INT.
13820
13821 * xdisp.c (display_count_lines): 3rd argument and return value now
13822 EMACS_INT. All callers changed.
13823 (pint2hrstr): Last argument is now EMACS_INT.
13824
13825 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13826 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13827 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13828 (decode_coding_utf_16, decode_coding_emacs_mule)
13829 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13830 (decode_coding_ccl, decode_coding_charset)
13831 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13832 (decode_coding_iso_2022, decode_coding_emacs_mule)
13833 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13834 <char_offset, last_offset>: Declare EMACS_INT.
13835 (encode_coding_utf_8, encode_coding_utf_16)
13836 (encode_coding_emacs_mule, encode_invocation_designation)
13837 (encode_designation_at_bol, encode_coding_iso_2022)
13838 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13839 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13840 Declare EMACS_INT.
13841 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13842 (encode_invocation_designation): Last argument P_NCHARS is now
13843 EMACS_INT.
13844 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13845 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13846
13847 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13848 All users changed.
13849
13850 * ccl.c (Fccl_execute_on_string): Declare some variables
13851 EMACS_INT.
13852
8546720e 138532011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13854
13855 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13856
4e19a977
CS
138572011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13858
13859 * process.c (Fformat_network_address): Doc fix.
13860
87302331
R
138612011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13862
ee7683eb 13863 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13864
cbb59342
CY
138652011-04-08 Chong Yidong <cyd@stupidchicken.com>
13866
13867 * keyboard.c (read_char): Call Lisp function help-form-show,
13868 instead of using internal_with_output_to_temp_buffer.
13869 (Qhelp_form_show): New var.
e0d38eeb 13870 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13871
13872 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13873
13874 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13875
e67a13ab
CY
138762011-04-06 Chong Yidong <cyd@stupidchicken.com>
13877
04f2d78b
CB
13878 * process.c (Flist_processes): Remove to Lisp.
13879 (list_processes_1): Delete.
e67a13ab 13880
973f782d
EZ
138812011-04-06 Eli Zaretskii <eliz@gnu.org>
13882
7c106b1e
EZ
13883 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13884
973f782d
EZ
13885 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13886
41cf7d1a 138872011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13888
ca23cc88
PE
13889 Fix more problems found by GCC 4.6.0's static checks.
13890
f390e2d5
PE
13891 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13892
42eea0d0
PE
13893 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13894
b69769da 13895 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13896
f9541e84
PE
13897 * xdisp.c (vmessage): Mark as a printf-like function.
13898
13841b55
PE
13899 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13900
c136c10f
PE
13901 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13902
5e2d4a30
PE
13903 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13904 printf-like functions.
13905 (tiff_load): Add casts to remove these marks before passing them
13906 to system-supplied API.
13907
583f48b9
PE
13908 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13909
b25d760e
PE
13910 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13911 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13912 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13913 directly, rather than having caller test rule sign. This avoids
13914 some unnecessary tests.
13915 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13916 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13917 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13918
bc7b6697 13919 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13920 (xfont_open): Avoid unnecessary tests.
bc7b6697 13921
27ccc379
PE
13922 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13923
dcd5c89a
PE
13924 * composite.h, composite.c (composition_gstring_put_cache):
13925 Use EMACS_INT, not int, for length.
13926
b13a45c6
PE
13927 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13928 breaking out part of COMPOSITION_DECODE_RULE.
13929 (COMPOSITION_DECODE_RULE): Use it.
13930 * composite.c (get_composition_id): Remove unused local vars,
13931 by using the new macro.
13932
1e792e4d
PE
13933 * textprop.c (set_text_properties_1): Change while to do-while,
13934 since the condition is always true at first.
13935
dc6c6455 13936 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13937 (interval_deletion_adjustment): Return unsigned value.
13938 All uses changed.
dc6c6455 13939
aba7731a
PE
13940 * process.c (list_processes_1, create_pty, read_process_output):
13941 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13942 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13943 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13944 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13945 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13946
fdfc4bf3
PE
13947 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13948
fca8fe46 13949 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13950 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13951
06a0259a 13952 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13953 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13954 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13955
e7b9e80f
PE
13956 * print.c (print_error_message): Avoid int overflow.
13957
56201685
PE
13958 * font.c (font_list_entities): Redo for clarity,
13959 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13960
78834453 13961 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13962 (font_score): Avoid potential overflow in diff calculation.
78834453 13963
0bc0b309 13964 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13965 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13966
e610eaca
PE
13967 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13968
b895abce
PE
13969 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13970 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13971 can always succeed if overflow has undefined behavior.
13972
1f1d9321 13973 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13974 (wordify): Omit three unnecessary tests.
1f1d9321 13975
c59478bc
PE
13976 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13977 All callers changed. This avoids the need for an unused var.
13978
79b73827
PE
13979 * casefiddle.c (casify_region): Remove var that is set but not used.
13980
a4db5dfe
PE
13981 * dired.c (file_name_completion): Remove var that is set but not used.
13982
43aae36e
PE
13983 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13984
2a47c44d 13985 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13986 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13987
a37c69bf
PE
13988 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13989 Check for integer overflow on size calculations.
13990
328ab8e7
PE
13991 * buffer.c (Fprevious_overlay_change): Remove var that is set
13992 but not used.
13993
e5a2a5cb
PE
13994 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13995 Remove vars that are set but not used.
8d84a6eb 13996 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13997 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13998
a60e5f68
PE
13999 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
14000
f661cb61 14001 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 14002 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 14003
f0397f5a
PE
14004 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
14005 that are set but not used.
14006
8664db06 14007 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14008 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14009
6abdaa4a
PE
14010 * xselect.c (x_get_local_selection, x_handle_property_notify):
14011 Remove vars that are set but not used.
14012
0ce7538d 14013 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14014 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14015
9ae848fc
PE
14016 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14017 Remove var that is set but not used.
0b918413
PE
14018 (scroll_bar_windows_size): Now size_t, not int.
14019 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14020 Check for overflow.
9ae848fc 14021
a5a62657
PE
14022 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14023 (map_tty_color) [!defined MSDOS]: Likewise.
14024
5c5cdd39
PE
14025 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14026
66ebf983
PE
14027 * coding.c: Remove vars that are set but not used.
14028 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14029 All callers changed.
14030 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14031 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14032 (decode_coding_charset): Remove vars that are set but not used.
14033
1be4d761
PE
14034 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14035 that is set but not used.
14036
47553fa8
PE
14037 * print.c (print_object): Remove var that is set but not used.
14038
1f7196bf 14039 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14040 The gnulib version avoids calling malloc in the usual case,
14041 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14042 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14043 * filelock.c (current_lock_owner): Likewise.
14044 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14045 * sysdep.c: Include allocator.h, careadlinkat.h.
14046 (emacs_no_realloc_allocator): New static constant.
14047 (emacs_readlink): New function.
fdb61804
PE
14048 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14049 ../lib/careadlinkat.h.
d1fdcab7 14050
f84c17c7
SM
140512011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14052
14053 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14054 first non-nil return value).
14055
ef3862ad
JD
140562011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14057
14058 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14059 if not defined (Bug#8403).
14060
376a7006
JB
140612011-04-02 Juanma Barranquero <lekktu@gmail.com>
14062
14063 * xdisp.c (display_count_lines): Remove parameter `start',
14064 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14065 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14066 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14067 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14068 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14069 and thereabouts. All callers changed.
14070 (get_per_char_metric): Remove parameter `f', unused since
14071 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14072
6ca3801d
JM
140732011-04-02 Jim Meyering <meyering@redhat.com>
14074
14075 do not dereference NULL upon failed strdup
14076 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14077 (ns_get_family): Likewise.
14078
d8e2b5ba
JB
140792011-04-02 Juanma Barranquero <lekktu@gmail.com>
14080
14081 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14082
8c74fcbd
JD
140832011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14084
14085 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14086 later (Bug#8403).
14087
7200d79c
SM
140882011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14089
03408648 14090 Add lexical binding.
7200d79c 14091
03408648
SM
14092 * window.c (Ftemp_output_buffer_show): New fun.
14093 (Fsave_window_excursion):
14094 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14095
14096 * lread.c (lisp_file_lexically_bound_p): New function.
14097 (Fload): Bind Qlexical_binding.
14098 (readevalloop): Remove `evalfun' arg.
14099 Bind Qinternal_interpreter_environment.
14100 (Feval_buffer): Bind Qlexical_binding.
14101 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14102 Mark as dynamic.
14103 (syms_of_lread): Declare `lexical-binding'.
14104
14105 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14106
14107 * keyboard.c (eval_dyn): New fun.
14108 (menu_item_eval_property): Use it.
ca105506
SM
14109
14110 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14111
03408648
SM
14112 * fns.c (concat, mapcar1): Accept byte-code-functions.
14113
14114 * eval.c (Fsetq): Handle lexical vars.
14115 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14116 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14117 (FletX, Flet): Obey lexical binding.
14118 (Fcommandp): Handle closures.
14119 (Feval): New `lexical' arg.
14120 (eval_sub): New function extracted from Feval. Use it almost
14121 everywhere where Feval was used. Look up vars in lexical env.
14122 Handle closures.
14123 (Ffunctionp): Move from subr.el.
14124 (Ffuncall): Handle closures.
14125 (apply_lambda): Remove `eval_flags'.
14126 (funcall_lambda): Handle closures and new byte-code-functions.
14127 (Fspecial_variable_p): New function.
14128 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14129 but without exporting it to Lisp.
23aba0ea 14130
23aba0ea 14131 * doc.c (Fdocumentation, store_function_docstring):
03408648 14132 * data.c (Finteractive_form): Handle closures.
23aba0ea 14133
03408648
SM
14134 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14135 interactive spec.
ba83908c 14136
04f2d78b
CB
14137 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14138 New byte-codes.
03408648
SM
14139 (exec_byte_code): New function extracted from Fbyte_code to handle new
14140 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14141
03408648 14142 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14143
03408648 14144 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14145
e2abce01
JB
141462011-03-31 Juanma Barranquero <lekktu@gmail.com>
14147
14148 * xdisp.c (redisplay_internal): Fix prototype.
14149
63696a73 141502011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14151
63696a73 14152 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14153 (try_scrolling): Use it when setting scroll_limit.
14154 Limit scrolling to 100 screen lines.
63696a73
EZ
14155 (redisplay_window): Even when falling back on "recentering",
14156 position point in the window according to scroll-conservatively,
14157 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14158
14159 (try_scrolling): When point is above the window, allow searching
14160 as far as scroll_max, or one screenful, to compute vertical
14161 distance from PT to the scroll margin position. This prevents
14162 try_scrolling from unnecessarily failing when
14163 scroll-conservatively is set to a value slightly larger than the
14164 window height. Clean up the case of PT below the margin at bottom
14165 of window: scroll_max can no longer be INT_MAX. When aggressive
14166 scrolling is in use, don't let point enter the opposite scroll
14167 margin as result of the scroll.
14168 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14169 threshold of 100 lines for never-recentering scrolling.
14170
e4cc2dfc
JB
141712011-03-31 Juanma Barranquero <lekktu@gmail.com>
14172
14173 * dispextern.h (move_it_by_lines):
14174 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14175 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14176 (message_log_check_duplicate): Remove parameters `prev_bol' and
14177 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14178 (redisplay_internal): Remove parameter `preserve_echo_area',
14179 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14180
14181 * indent.c (Fvertical_motion):
14182 * window.c (window_scroll_pixel_based, Frecenter):
14183 Don't pass `need_y_p' to `move_it_by_lines'.
14184
1c470562
SM
141852011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14186
44f230aa
SM
14187 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14188 steal a few bits to be more compact.
14189 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14190 Remove unneeded casts.
14191
1c470562
SM
14192 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14193
888adce9
ZK
141942011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14195
14196 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14197 binding" message (bug#7967).
14198
f838ed7b
PE
141992011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14200
77861b95
PE
14201 Fix more problems found by GCC 4.6.0's static checks.
14202
de6dbc14
PE
14203 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14204 Remove unused local var.
14205
f838ed7b
PE
14206 * editfns.c (Fmessage_box): Remove unused local var.
14207
792c7b2b
PE
14208 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14209 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14210 Omit unused local vars.
c499e557 14211 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14212 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14213 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14214 Omit unused local var.
14215
ba0165e1
PE
14216 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14217 Don't assume string length fits in int.
32ad8845 14218 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14219 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14220
3c59b4c9
PE
14221 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14222 instead of alloca (Bug#8344).
14223
a3eed478 14224 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14225 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14226
eb4d412d
PE
14227 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14228
1658b401
PE
14229 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14230 concerns.
14231
14232 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14233
14234 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14235
9a2c6e05
PE
14236 * keyboard.c (syms_of_keyboard): Use the same style as later
14237 in this function when indexing through an array. This also
14238 works around GCC bug 48267.
14239
03d0a109
PE
14240 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14241
44f730c8
PE
14242 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14243
fe75f926
PE
14244 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14245 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14246
ffa8c828
PE
14247 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14248 This avoids undefined behavior on integer overflow, and is a bit
14249 more convenient anyway since it is compared to a size_t variable.
14250
c5101a77
PE
14251 Variadic C functions now count arguments with size_t, not int.
14252 This avoids an unnecessary limitation on 64-bit machines, which
14253 caused (substring ...) to crash on large vectors (Bug#8344).
14254 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14255 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14256 All variadic functions and their callers changed accordingly.
c5101a77
PE
14257 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14258 * data.c (arith_driver, float_arith_driver): Likewise.
14259 * editfns.c (general_insert_function): Likewise.
14260 * eval.c (struct backtrace.nargs, interactive_p)
14261 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14262 (funcall_lambda, mark_backtrace): Likewise.
14263 * fns.c (concat): Likewise.
14264 * frame.c (x_set_frame_parameters): Likewise.
14265 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14266 0 if not found, not -1. All callers changed.
14267
dd3f25f7
PE
14268 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14269 (stack_copy_size): Now size_t, not int.
14270 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14271
461c2ab9
JB
142722011-03-28 Juanma Barranquero <lekktu@gmail.com>
14273
14274 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14275 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14276 All callers changed.
14277
14278 * lisp.h (multibyte_char_to_unibyte):
14279 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14280 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14281 * character.h (CHAR_TO_BYTE8):
14282 * cmds.c (internal_self_insert):
14283 * editfns.c (general_insert_function):
14284 * keymap.c (push_key_description):
14285 * search.c (Freplace_match):
14286 * xdisp.c (message_dolog, set_message_1): All callers changed.
14287
f6d62986
SM
142882011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14289
14290 * keyboard.c (safe_run_hook_funcall): New function.
14291 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14292 don't set the hook to nil, but remove the offending function instead.
14293 (Qcommand_hook_internal): Remove, unused.
14294 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14295 Vcommand_hook_internal.
14296
14297 * eval.c (enum run_hooks_condition): Remove.
14298 (funcall_nil, funcall_not): New functions.
14299 (run_hook_with_args): Call each function through a `funcall' argument.
14300 Remove `cond' argument, now redundant.
14301 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14302 (Frun_hook_with_args_until_failure): Adjust accordingly.
14303 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14304
1db5b1ad
JB
143052011-03-28 Juanma Barranquero <lekktu@gmail.com>
14306
14307 * dispextern.h (string_buffer_position): Remove declaration.
14308
14309 * print.c (strout): Remove parameter `multibyte', unused since
14310 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14311
14312 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14313 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14314 All callers changed.
14315
14316 * w32.c (_wsa_errlist): Use braces for struct initializers.
14317
14318 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14319 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14320 All callers changed.
14321 (string_buffer_position): Likewise. Also, make static (it's never
14322 used outside xdisp.c).
14323 (cursor_row_p): Remove parameter `w', unused since
14324 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14325 (decode_mode_spec): Remove parameter `precision', introduced during
14326 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14327 All callers changed.
14328
5ffb62aa
JD
143292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14330
14331 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14332
461c2ab9 143332011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14334
14335 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14336 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14337 (ns_update_auto_hide_menu_bar): New functions.
14338 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14339 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14340 ns_constrain_all_frames.
14341 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14342 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14343
5c380ffb
JD
143442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14345
14346 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14347
9af30bdf
GM
143482011-03-27 Glenn Morris <rgm@gnu.org>
14349
14350 * syssignal.h: Replace RETSIGTYPE with void.
14351 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14352 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14353 Replace SIGTYPE with void everywhere.
14354 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14355 * s/template.h (SIGTYPE): Remove commented out definition.
14356
e2abce01
JB
143572011-03-26 Eli Zaretskii <eliz@gnu.org>
14358
14359 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14360 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14361
f868cd8a
JB
143622011-03-26 Juanma Barranquero <lekktu@gmail.com>
14363
59eb0929
JB
14364 * w32.c (read_unc_volume): Use parameter `henum', instead of
14365 global variable `wget_enum_handle'.
14366
14367 * keymap.c (describe_vector): Remove parameters `indices' and
14368 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14369 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14370
f868cd8a
JB
14371 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14372
14373 * keyboard.c (timer_check): Remove parameter `do_it_now',
14374 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14375 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14376 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14377
14378 * keyboard.c (read_char):
14379 * w32menu.c (w32_menu_display_help):
14380 * xmenu.c (show_help_event, menu_help_callback):
14381 Adjust calls to `show_help_echo'.
14382
14383 * gtkutil.c (xg_maybe_add_timer):
14384 * keyboard.c (readable_events):
14385 * process.c (wait_reading_process_output):
14386 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14387
14388 * insdel.c (adjust_markers_gap_motion):
14389 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14390 (gap_left, gap_right): Don't call it.
14391
2ecf6fdb
CY
143922011-03-25 Chong Yidong <cyd@stupidchicken.com>
14393
14394 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14395 incurred during fontification.
14396
6b1f9ba4
JB
143972011-03-25 Juanma Barranquero <lekktu@gmail.com>
14398
14399 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14400 (DEFVAR_PER_BUFFER): Don't pass it.
14401
14402 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14403 (scrolling_window): Don't pass it.
14404
0f4a96b5
JB
144052011-03-25 Juanma Barranquero <lekktu@gmail.com>
14406
14407 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14408
14409 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14410 and `suffix'.
14411 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14412 of variables specific to SELinux and computation of `encoded_absname'.
14413
14414 * image.c (XPutPixel): Remove unused variable `height'.
14415
14416 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14417
14418 * unexw32.c (get_section_info): Remove unused variable `section'.
14419
14420 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14421 (system_process_attributes): Remove unused variable `sess'.
14422 (sys_read): Remove unused variable `err'.
14423
14424 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14425 (w32_wnd_proc): Remove unused variable `isdead'.
14426 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14427 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14428 (x_create_tip_frame): Remove unused variable `tem'.
14429
14430 * w32inevt.c (w32_console_read_socket):
14431 Remove unused variable `no_events'.
14432
14433 * w32term.c (x_draw_composite_glyph_string_foreground):
14434 Remove unused variable `width'.
14435
1149507c
JB
144362011-03-24 Juanma Barranquero <lekktu@gmail.com>
14437
14438 * w32term.c (x_set_glyph_string_clipping):
14439 Don't pass uninitialized region to CombineRgn.
14440
9c88f339
JB
144412011-03-23 Juanma Barranquero <lekktu@gmail.com>
14442
14443 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14444 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14445 (Fx_close_connection): Remove unused variable `i'.
14446
14447 * w32font.c (w32font_draw): Return number of glyphs.
14448 (w32font_open_internal): Remove unused variable `i'.
14449 (w32font_driver): Add missing initializer.
14450
14451 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14452 (fill_in_menu): Remove unused variable `items_added'.
14453
14454 * w32term.c (last_mouse_press_frame): Remove static global variable.
14455 (w32_clip_to_row): Remove unused variable `f'.
14456 (x_delete_terminal): Remove unused variable `i'.
14457
14458 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14459 (NOTHING): Remove unused static global variable.
14460 (uniscribe_check_otf): Remove unused variable `table'.
14461 (uniscribe_font_driver): Add missing initializers.
14462
dee091a3
JD
144632011-03-23 Julien Danjou <julien@danjou.info>
14464
14465 * term.c (Fsuspend_tty, Fresume_tty):
14466 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14467 * window.c (temp_output_buffer_show):
14468 * insdel.c (signal_before_change):
14469 * frame.c (Fhandle_switch_frame):
14470 * fileio.c (Fdo_auto_save):
14471 * emacs.c (Fkill_emacs):
14472 * editfns.c (save_excursion_restore):
14473 * cmds.c (internal_self_insert):
14474 * callint.c (Fcall_interactively):
14475 * buffer.c (Fkill_all_local_variables):
14476 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14477 Use Frun_hooks.
0f4a96b5 14478 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14479 unconditionally since it does the check itself.
dee091a3 14480
2c520ab5 144812011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14482
c9c49752
PE
14483 Fix more problems found by GCC 4.5.2's static checks.
14484
8abc3f12
PE
14485 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14486 the first time through the loop, since we know p0 < p1 then.
14487 This also avoids a gcc -Wstrict-overflow warning.
14488
a2d26660
PE
14489 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14490 leading to a memory leak, possible in functions like
14491 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14492 of objects (Bug#8318).
a2d26660 14493
916c72e9
PE
14494 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14495 that could (at least in theory) be that large.
14496
19ab8a18
PE
14497 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14498 This is less likely to overflow, and avoids undefined behavior if
14499 overflow does occur. All callers changed. Use strtoul to scan
14500 for the unsigned long integer.
b7cbbd6f
PE
14501 (pint2hrstr): Simplify and tune code slightly.
14502 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14503
f0641eff
PE
14504 * scroll.c (do_scrolling): Work around GCC bug 48228.
14505 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14506
7f650bb9
PE
14507 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14508 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14509 (validate_x_resource_name): Simplify count usage.
14510 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14511
37dd57d1
PE
14512 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14513 fail (Bug#8306).
81e56e61 14514
699979fc 14515 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14516
401bf9b4
PE
14517 * process.c (Fmake_network_process): Use socklen_t, not int,
14518 where POSIX says socklen_t is required in portable programs.
14519 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14520 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14521 (Fmake_network_process, server_accept_connection):
14522 (wait_reading_process_output, read_process_output):
14523 Likewise.
14524
b93aacde
PE
14525 * process.c: Rename or move locals to avoid shadowing.
14526 (list_processes_1, Fmake_network_process):
14527 (read_process_output_error_handler, exec_sentinel_error_handler):
14528 Rename or move locals.
4dc343ee 14529 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14530 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14531 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14532 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14533 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14534
af8a867c 14535 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14536 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14537 Include tparam.h instead, since it declares them.
af8a867c
PE
14538 * cm.h (PC): Remove extern decl; tparam.h now does this.
14539 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14540 * terminfo.c: Include tparam.h, to check interfaces.
14541 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14542 (tparam): Adjust signature to match interface in tparam.h;
14543 this removes some undefined behavior. Check that outstring and len
14544 are zero, which they always are with Emacs.
14545 * tparam.h (PC, BC, UP): New extern decls.
14546
0248044d 14547 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14548 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14549
8ff096c1 14550 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14551 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14552 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14553 (ftfont_list): Remove unused local.
49eaafba
PE
14554 (get_adstyle_property, ftfont_pattern_entity):
14555 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14556 Rename locals to avoid shadowing.
8ff096c1 14557
e2be39f6
PE
14558 * xfont.c (xfont_list_family): Mark var as initialized.
14559
c9735e30
PE
14560 * xml.c (make_dom): Now static.
14561
8f5201ae
PE
14562 * composite.c (composition_compute_stop_pos): Rename local to
14563 avoid shadowing.
b246f932
PE
14564 (composition_reseat_it): Remove unused locals.
14565 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14566 (composition_update_it): Mark var as initialized.
11b61122
PE
14567 (find_automatic_composition): Mark vars as initialized,
14568 with a FIXME (Bug#8290).
8f5201ae 14569
760fbc2c
PE
14570 character.h: Rename locals to avoid shadowing.
14571 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14572 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14573 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14574 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14575 to avoid shadowing.
14576
ff08eb85
PE
14577 * textprop.c (property_change_between_p): Remove; unused.
14578
fc7bf025
PE
14579 * intervals.c (interval_start_pos): Now static.
14580
235d7abc
PE
14581 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14582
44f230aa
SM
14583 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14584 Rename locals to avoid shadowing.
3e7d6594 14585
50060332
PE
14586 * sound.c (wav_play, au_play, Fplay_sound_internal):
14587 Fix pointer signedness.
d01f234b 14588 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14589 (wav_play): Initialize a variable to 0, to prevent undefined
14590 behavior (Bug#8278).
50060332 14591
c4fc4e30
PE
14592 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14593
918436ed
PE
14594 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14595
c939f91b
PE
14596 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14597 clobbering (Bug#8298).
b9c7f648
PE
14598 * sysdep.c (sys_subshell): Likewise.
14599 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14600
6bd8c144
PE
14601 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14602 This should get cleaned up, so that child_setup has the
14603 same signature on all platforms.
14604
7710357c 14605 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14606 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14607
c59da222
CY
146082011-03-22 Chong Yidong <cyd@stupidchicken.com>
14609
14610 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14611 not to be necessary, and produces flickering.
14612
66b87493
GM
146132011-03-20 Glenn Morris <rgm@gnu.org>
14614
14615 * config.in: Remove file.
14616
45b6f6d5
JB
146172011-03-20 Juanma Barranquero <lekktu@gmail.com>
14618
14619 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14620 are now in src/globals.h.
14621 (syms_of_minibuf): Remove spurious & from previous change.
14622
cd394be1 146232011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14624
14625 * minibuf.c (completing-read-function): New variable.
14626 (completing-read-default): Rename from completing-read.
14627 (completing-read): Call completing-read-function.
14628
b14e3e21
CY
146292011-03-19 Juanma Barranquero <lekktu@gmail.com>
14630
14631 * xfaces.c (Fx_load_color_file):
14632 Read color file from absolute filename (bug#8250).
14633
f2b726e6
JB
146342011-03-19 Juanma Barranquero <lekktu@gmail.com>
14635
14636 * makefile.w32-in: Update dependencies.
14637
09f6ff02
EZ
146382011-03-17 Eli Zaretskii <eliz@gnu.org>
14639
14640 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14641
29a6015a
PE
146422011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14643
a3a6c54e
PE
14644 Fix more problems found by GCC 4.5.2's static checks.
14645
b766f867
PE
14646 * process.c (make_serial_process_unwind, send_process_trap):
14647 (sigchld_handler): Now static.
14648
be02381c
PE
14649 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14650 That way, the code declares only the vars that it needs.
14651 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14652 * s/cygwin.h (PTY_ITERATION): Likewise.
14653 * s/darwin.h (PTY_ITERATION): Likewise.
14654 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14655
57048744
PE
14656 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14657 * process.c (allocate_pty): Don't declare stb unless it's needed.
14658
7914961c 14659 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14660 (CONSTANTLIM): Remove; unused.
14661 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14662 Define only if needed.
7914961c 14663
b3967b18
PE
14664 * unexelf.c (unexec): Name an expression,
14665 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14666 Use a different way to cause a compilation error if anyone uses
14667 n rather than nn, a way that does not involve shadowing.
73366a00 14668 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14669
29a6015a
PE
14670 * deps.mk (unexalpha.o): Remove; unused.
14671
43cfc33e 14672 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14673 * unexec.h: New file.
ce701a33
PE
14674 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14675 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14676 Depend on unexec.h.
14677 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14678 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14679 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14680 Change as necessary to match prototype in unexec.h.
ce701a33 14681
01f44d5a
PE
14682 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14683 shadowing.
4f63c6bb 14684 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14685
a6670b0b
PE
14686 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14687 Rename locals to avoid shadowing.
14688
cef2010d 14689 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14690 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14691
d4d7173a
PE
14692 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14693
f08b802a
PE
14694 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14695 warning when compiling print.c.
14696
3ddb0639
PE
14697 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14698 instead of using an uninitialized var.
5ad03b97 14699 (font_sort_entities): Mark var as initialized.
3ddb0639 14700
170a2692
PE
14701 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14702
e663c700
PE
14703 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14704 pointers to constants.
89bc529a 14705 (font_parse_fcname): Remove unused vars.
7b81e2d0 14706 (font_delete_unmatched): Now static.
ea838e10 14707 (font_get_spec): Remove; unused.
13a547c6
PE
14708 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14709 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14710 Rename or move locals to avoid shadowing.
e663c700 14711
2a80c887 14712 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14713 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14714
1384fa33 14715 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14716 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14717
8b2c52e9
PE
14718 * alloc.c (mark_backtrace): Move decl from here ...
14719 * lisp.h: ... to here, so that it can be checked.
14720
475545b5 14721 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14722 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14723 (lisp_indirect_variable): Name an expression,
14724 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14725 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14726
b1349114 14727 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14728 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14729 Use const pointer when appropriate.
b1349114 14730
a2928364
PE
14731 * lisp.h (get_system_name, get_operating_system_release):
14732 Move decls here, to check interfaces.
14733 * process.c (get_operating_system_release): Move decl to lisp.h.
14734 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14735 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14736 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14737 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14738 (Fformat_time_string, Fencode_time, Finsert_char):
14739 (Ftranslate_region_internal, Fformat):
14740 Rename or remove local vars to avoid shadowing.
9710023e 14741 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14742
a415e694
PE
14743 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14744 avoid shadowing.
14745
8ef4622d
PE
14746 * lisp.h (eassert): Check that the argument compiles, even if
14747 ENABLE_CHECKING is not defined.
14748
946f9a5b
PE
14749 * data.c (Findirect_variable): Name an expression, to avoid
14750 gcc -Wbad-function-cast warning.
112396d6 14751 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14752 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14753 (Fmake_variable_buffer_local, Fmake_local_variable):
14754 Mark variables as initialized.
52746918 14755 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14756
e5aab7e7 14757 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14758 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14759 Rename locals to avoid shadowing.
dff45157
PE
14760 (mark_stack): Move local variables into the #ifdef region where
14761 they're used.
7bc26fdb
PE
14762 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14763 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14764 needed otherwise.
14765 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14766 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14767 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14768
e5aab7e7
PE
14769 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14770 avoids undefined behavior in theory.
14771
4da60324
PE
14772 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14773
88043301
PE
14774 Use functions, not macros, for up- and down-casing (Bug#8254).
14775 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14776 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14777 to use the following functions instead of these macros.
14778 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14779 EMACS_INT, since callers assume the returned value fits in int.
14780 (upcase1): Likewise, for UPCASE_TABLE.
14781 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14782 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14783 the race-condition problem in the old DOWNCASE.
88043301 14784
19ed5445
PE
14785 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14786 Rename locals to avoid shadowing.
14787 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14788 (regex_compile, re_search_2, re_match_2_internal):
14789 Remove unused local vars.
952db0d7
PE
14790 (FREE_VAR): Rewrite so as not to use empty "else",
14791 which gcc can warn about.
da053e48 14792 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14793 (RETALLOC_IF): Define only if needed.
14794 (WORDCHAR_P): Likewise. This one is never needed, but is used
14795 only in a comment talking about a compiler bug, so put inside
14796 the #if 0 of that comment.
14797 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14798 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14799 Remove; unused.
19ed5445 14800
1f3561e4 14801 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14802 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14803 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14804
ded6f8f7
PE
14805 * search.c (simple_search): Remove unused var.
14806
dbd37a95
PE
14807 * dired.c (compile_pattern): Move decl from here ...
14808 * lisp.h: ... to here, so that it can be checked.
14809 (struct re_registers): New forward decl.
14810
7e47afad
PE
14811 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14812
85f24f61
PE
14813 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14814 All uses changed.
14815 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14816 Rename locals to avoid shadowing.
5671df8f 14817 (Fvertical_motion): Mark locals as initialized.
85f24f61 14818
181aa2be 14819 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14820 (casify_region): Mark local as initialized.
181aa2be 14821
930d429c
PE
14822 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14823
7082eac6
PE
14824 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14825 New macros, so that the caller can use some names other than
14826 gcpro1, gcpro2, etc.
14827 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14828 of the new macros.
14829 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14830 argument, for consistency with GCPRO2_VAR, etc: it is now the
14831 prefix of the variable, not the variable itself. All uses
14832 changed.
38b2c076
PE
14833 * dired.c (directory_files_internal, file_name_completion):
14834 Rename locals to avoid shadowing.
14835
15206ed9
PE
14836 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14837 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14838 dired.c's scmp function, had undefined behavior.
14839 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14840 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14841 * buffer.h: ... to here, because these macros use current_buffer,
14842 and the new implementation with inline functions needs to have
14843 current_buffer in scope now, rather than later when the macros
14844 are used.
14845 (downcase, upcase1): New static inline functions.
14846 (DOWNCASE, UPCASE1): Reimplement using these functions.
14847 This avoids undefined behavior in expressions like
14848 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14849 from race conditions in accessing the global variables
14850 case_temp1 and case_temp2.
14851 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14852 * lisp.h (case_temp1, case_temp2): Remove their decls.
14853 * character.h (ASCII_CHAR_P): Move from here ...
14854 * lisp.h: ... to here, so that the inline functions mentioned
14855 above can use them.
14856
4a6bea26
PE
14857 * dired.c (directory_files_internal_unwind): Now static.
14858
f14b7e14
PE
14859 * fileio.c (file_name_as_directory, directory_file_name):
14860 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14861 Now static.
2893f146
PE
14862 (file_name_as_directory): Use const pointers when appropriate.
14863 (Fexpand_file_name): Likewise. In particular, newdir might
14864 point at constant storage, so make it a const pointer.
fd4ead52 14865 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14866 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14867 signedness issues.
f839df0c
PE
14868 (Fset_file_times, Finsert_file_contents, auto_save_error):
14869 Rename locals to avoid shadowing.
f14b7e14 14870
5716756e 14871 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14872 (Ftry_completion, Fall_completions): Rename or remove locals
14873 to avoid shadowing.
5716756e 14874
b4c3046a
PE
14875 * marker.c (bytepos_to_charpos): Remove; unused.
14876
b45db522
PE
14877 * lisp.h (verify_bytepos, count_markers): New decls,
14878 so that gcc does not warn that these functions aren't declared.
14879
85876d07
PE
14880 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14881 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14882 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14883 (copy_text): Remove unused local var.
85876d07 14884
03d78a21 14885 * filelock.c (within_one_second): Now static.
b3dd38ab 14886 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14887
5df8f01b
PE
14888 * buffer.c (fix_overlays_before): Mark locals as initialized.
14889 (fix_start_end_in_overlays): Likewise. This function should be
14890 simplified by using pointers-to-pointers, but that's a different
14891 matter.
b1d876f1 14892 (switch_to_buffer_1): Now static.
8f54f30a
PE
14893 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14894 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14895
a70072c9 14896 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14897 Fix pointer signedness issue.
edced198
PE
14898 (sys_subshell): Mark local as volatile if checking for lint,
14899 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14900 (MAXPATHLEN): Define only if needed.
a70072c9 14901
a0977c44
PE
14902 * process.c (serial_open, serial_configure): Move decls from here ...
14903 * systty.h: ... to here, so that they can be checked.
14904
a884fdcc
PE
14905 * fns.c (get_random, seed_random): Move extern decls from here ...
14906 * lisp.h: ... to here, so that they can be checked.
14907
604efe86 14908 * sysdep.c (reset_io): Now static.
b8950c94 14909 (wait_for_termination_signal): Remove; unused.
604efe86 14910
38fc62d9
PE
14911 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14912 (copy_keymap_item, append_key, push_text_char_description):
14913 Now static.
1004a21a 14914 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14915 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14916 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14917 (describe_map_tree):
14918 Rename locals to avoid shadowing.
38fc62d9 14919
2f2650da
PE
14920 * keyboard.c: Declare functions static if they are not used elsewhere.
14921 (echo_char, echo_dash, cmd_error, top_level_2):
14922 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14923 (read_char, kbd_buffer_get_event, make_lispy_position):
14924 (make_lispy_event, make_lispy_movement, apply_modifiers):
14925 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14926 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14927 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14928 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14929 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14930
a053e86c 14931 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14932 (mark_kboards): Move decl here ...
14933 * alloc.c (mark_kboards): ... from here.
a053e86c 14934
4752793e
PE
14935 * lisp.h (force_auto_save_soon): New decl.
14936
74f10ca7 14937 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14938 (DEFINE_DUMMY_FUNCTION): New macro.
14939 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14940 Use it.
c03cd23f
PE
14941 (main): Add casts to avoid warnings
14942 if GCC considers string literals to be constants.
74f10ca7 14943
022e70d4
PE
14944 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14945
59d6fe83
PE
14946 * dbusbind.c: Pointer signedness fixes.
14947 (xd_signature, xd_append_arg, xd_initialize):
14948 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14949 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14950 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14951 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14952
78320123
PE
14953 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14954 if GCC considers string literals to be constants.
49cebcca 14955 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14956
35ac2a97
SM
149572011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14958
fb103ca9
SM
14959 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14960 (print_preprocess, print_object): New macro to fix last change.
14961
35ac2a97
SM
14962 * print.c (print_preprocess): Don't forget font objects.
14963
62973b41
JB
149642011-03-16 Juanma Barranquero <lekktu@gmail.com>
14965
14966 * emacs.c (USAGE3): Doc fixes.
14967
0e48bb22
AS
149682011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14969
14970 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14971 structure.
14972
7684e57b
JB
149732011-03-14 Juanma Barranquero <lekktu@gmail.com>
14974
14975 * lisp.h (VWindow_system, Qfile_name_history):
14976 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14977 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14978 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14979
14980 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14981 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14982
14983 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14984 * w32console.c (detect_input_pending, read_input_pending)
14985 (encode_terminal_code):
14986 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14987 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14988 (w32_system_caret_y, Qfile_name_history):
14989 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14990 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14991 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14992 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14993 * w32proc.c (Qlocal, report_file_error):
14994 * w32term.c (Vwindow_system, updating_frame):
14995 * w32uniscribe.c (initialized, uniscribe_font_driver):
14996 Remove unneeded extern declarations.
14997
2aa46d6c
CY
149982011-03-14 Chong Yidong <cyd@stupidchicken.com>
14999
c96bbc66 15000 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 15001
cffc6f3b
CY
150022011-03-13 Chong Yidong <cyd@stupidchicken.com>
15003
15004 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
15005 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15006 These macros can no longer be used for assignment.
15007
44f230aa
SM
15008 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15009 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15010 (record_buffer_markers, fetch_buffer_markers): New functions for
15011 recording and fetching special buffer markers.
15012 (set_buffer_internal_1, set_buffer_temp): Use them.
15013
15014 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15015
15016 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15017
15018 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15019 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15020
15021 * xdisp.c (hscroll_window_tree):
15022 (reconsider_clip_changes): Use PT instead of BUF_PT.
15023
d251f04b
EZ
150242011-03-13 Eli Zaretskii <eliz@gnu.org>
15025
15026 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15027 $(EMACS_ROOT)/lib/intprops.h.
15028
f0c77cd1
PE
150292011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15030
3eca4629
PE
15031 Fix more problems found by GCC 4.5.2's static checks.
15032
7c86ee98
PE
15033 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15034 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15035 (xg_free_frame_widgets): Make it clear that a local variable is
15036 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15037 (gdk_window_get_screen): Make it clear that this macro is needed
15038 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15039 (int_gtk_range_get_value): New function, which avoids a diagnostic
15040 from gcc -Wbad-function-cast.
15041 (xg_set_toolkit_scroll_bar_thumb): Use it.
15042 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15043 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15044 (get_utf8_string, xg_get_file_with_chooser):
15045 Rename locals to avoid shadowing.
15046 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15047
41729b81
PE
15048 * xgselect.c (xg_select): Remove unused var.
15049
f0c77cd1
PE
15050 * image.c (four_corners_best): Mark locals as initialized.
15051 (gif_load): Initialize transparent_p to zero (Bug#8238).
15052 Mark another local as initialized.
ec6cf4c6 15053 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15054
ce0ad53d 15055 * image.c (clear_image_cache): Now static.
d5d5a617 15056 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15057 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15058 (x_edge_detection): Remove unnecessary cast that
15059 gcc -Wbad-function-cast diagnoses.
2037898d 15060 (gif_load): Fix pointer signedness.
6ae141d6
PE
15061 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15062 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15063
33383987 150642011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15065
d32df629
PE
15066 Improve quality of tests for time stamp overflow.
15067 For example, without this patch (encode-time 0 0 0 1 1
15068 1152921504606846976) returns the obviously-bogus value (-948597
15069 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15070 reports time overflow. See
15071 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15072 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15073 * editfns.c: Include limits.h and intprops.h.
15074 (TIME_T_MIN, TIME_T_MAX): New macros.
15075 (time_overflow): Move earlier, to before first use.
15076 (hi_time, lo_time): New functions, for an accurate test for
15077 out-of-range times.
15078 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15079 (Fget_internal_run_time): Don't assume time_t fits in int.
15080 (make_time): Use list2 instead of Fcons twice.
15081 (Fdecode_time): More accurate test for out-of-range times.
15082 (check_tm_member): New function.
15083 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15084 (lisp_time_argument): Don't rely on undefined left-shift and
15085 right-shift behavior when checking for time stamp overflow.
8be6f318 15086
fe31d94c
PE
15087 * editfns.c (time_overflow): New function, refactoring common code.
15088 (Fformat_time_string, Fdecode_time, Fencode_time):
15089 (Fcurrent_time_string): Use it.
15090
8be6f318
PE
15091 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15092 * dired.c (make_time): Move to ...
15093 * editfns.c (make_time): ... here.
15094 * systime.h: Note the move.
15095
09d9db2c 150962011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15097
126bc0dc
YM
15098 * fringe.c (update_window_fringes): Remove unused variables.
15099
c47cbdfd
YM
15100 * unexmacosx.c (copy_data_segment): Also copy __got section.
15101 (Bug#8223)
15102
7ac80be9
EZ
151032011-03-12 Eli Zaretskii <eliz@gnu.org>
15104
c96bbc66 15105 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15106 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15107 Constify `char *' arguments and their references according to
15108 prototypes in tparam.h.
15109
ecb0f94d 15110 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15111
7ac80be9
EZ
15112 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15113 Adapt all references accordingly.
15114
15115 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15116
ef1fd07e
TT
151172011-03-11 Tom Tromey <tromey@redhat.com>
15118
15119 * buffer.c (syms_of_buffer): Remove obsolete comment.
15120
7ef4b50c
EZ
151212011-03-11 Eli Zaretskii <eliz@gnu.org>
15122
15123 * termhooks.h (encode_terminal_code): Declare prototype.
15124
15125 * msdos.c (encode_terminal_code): Don't declare prototype.
15126
15127 * term.c (encode_terminal_code): Now external again, used by
15128 w32console.c and msdos.c.
15129
44f230aa
SM
15130 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15131 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15132
4b1ec863 151332011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15134
1714f52b 15135 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15136
4b1ec863
PE
15137 * fringe.c (update_window_fringes): Mark locals as initialized
15138 (Bug#8227).
15139 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15140
524c7aa6
PE
15141 * alloc.c (mark_fringe_data): Move decl from here ...
15142 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15143 to check its interface.
15144 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15145
a5c0af81 15146 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15147 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15148 (fontset_font): Mark local as initialized.
a9a06e0b 15149 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15150
b4716021
PE
15151 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15152
811e9bac 15153 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15154 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15155 (x_own_selection, Fx_disown_selection_internal): Rename locals
15156 to avoid shadowing.
15157 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15158
7e3ab302
PE
15159 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15160 so that the caller can use some name other than gcpro1.
15161 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15162 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15163 (Fx_backspace_delete_keys_p):
15164 Use them to avoid shadowing, and rename vars to avoid shadowing.
15165 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15166 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15167 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15168 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15169 Remove unused locals.
7e3ab302
PE
15170 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15171 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15172 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15173 macros.
f78faa98 15174
e2b13473
PE
15175 * xterm.h (x_mouse_leave): New decl.
15176
77f23912
PE
15177 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15178 Remove unused functions.
cdf4ba58
PE
15179 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15180 (x_calc_absolute_position): Now static.
7411c686 15181 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15182 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15183 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15184 unless they are used.
38d0b34a
PE
15185 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15186 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15187 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15188 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15189 (x_error_catcher, x_connection_closed, x_error_handler):
15190 (x_error_quitter, xembed_send_message, x_iconify_frame):
15191 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15192 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15193 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15194
44f230aa
SM
15195 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15196 Rename or move locals to avoid shadowing.
6b463e58 15197 (tty_defined_color, merge_face_heights): Now static.
5967d051 15198 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15199 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15200 does not deduce is never used uninitialized.
73719eba
PE
15201 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15202 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15203
426994c3 15204 * terminal.c (store_terminal_param): Now static.
5489860b 15205
032f1620 15206 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15207 (set_frame_menubar): Remove unused local.
d4323972 15208 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15209 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15210 since they might point to immutable storage.
281585b0
PE
15211 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15212 since it's unused otherwise.
032f1620 15213
367c19e5 15214 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15215 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15216 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15217 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15218 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15219 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15220 does not deduce are never used uninitialized.
70739cbe 15221
07b48fa9
PE
15222 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15223
8868a238 15224 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15225 * window.c (window_loop, size_window):
15226 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15227
7e5cf297 15228 * window.c (display_buffer): Now static.
d6550a9f
PE
15229 (size_window): Mark variables that gcc -Wuninitialized
15230 does not deduce are never used uninitialized.
a586633d
PE
15231 * window.h (check_all_windows): New decl, to forestall
15232 gcc -Wmissing-prototypes diagnostic.
5b555da1 15233 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15234
f6095868
PE
15235 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15236 shadowing.
15237 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15238 Include <limits.h>.
15239 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15240 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15241 (load_charset_map): Mark variables that gcc -Wuninitialized
15242 does not deduce are never used uninitialized.
53df7c11 15243 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15244
f38b440c
PE
15245 * coding.c (coding_set_source, coding_set_destination):
15246 Use "else { /* comment */ }" rather than "else /* comment */;"
15247 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15248 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15249 a block, when the outer 'i' will do.
15250 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15251 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15252 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15253 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15254 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15255 Rename locals to avoid shadowing.
15256 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15257 * coding.c (emacs_mule_char, encode_invocation_designation):
15258 Now static, since they're not used elsewhere.
413bb2db 15259 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15260 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15261 (decode_coding_emacs_mule): Mark variables that gcc
15262 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15263 (detect_coding_iso_2022): Initialize a local variable that might
15264 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15265 this initialization is needed. (Bug#8211)
5f58e762
PE
15266 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15267 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15268 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15269 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15270 Remove unused macros.
f38b440c 15271
232b38b9 15272 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15273 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15274 * character.c (string_count_byte8): Likewise.
232b38b9 15275
fb90da1b
PE
15276 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15277 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15278
fb93dbc2
PE
15279 * chartab.c (copy_sub_char_table): Now static, since it's not used
15280 elsewhere.
5c156ace
PE
15281 (sub_char_table_ref_and_range, char_table_ref_and_range):
15282 Rename locals to avoid shadowing.
bbcd0949 15283 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15284
7d3b3862 15285 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15286 (BIDI_BOB): Remove unused macro.
7d3b3862 15287
6be7d3da
PE
15288 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15289 deduce are never used uninitialized.
c2ed9c8b 15290 * term.c (encode_terminal_code): Likewise.
6be7d3da 15291
75f8807f 15292 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15293
50938595
PE
15294 * tparam.h: New file.
15295 * term.c, tparam.h: Include it.
15296 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15297 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15298 Move these decls to tparam.h, and make them agree with what
15299 is actually in tparam.c. The previous trick of using incompatible
15300 decls in different modules does not conform to the C standard.
15301 All callers of tparam changed to use tparam's actual API.
15302 * tparam.c (tparam1, tparam, tgoto):
15303 Use const pointers where appropriate.
15304
fbceeba2
PE
15305 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15306 * cm.h (struct cm): Likewise.
15307 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15308 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15309 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15310 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15311 (turn_on_face, init_tty): Likewise.
15312 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15313
7f3f1250
PE
15314 * term.c (term_mouse_position): Rename local to avoid shadowing.
15315
e6ca6543
PE
15316 * alloc.c (mark_ttys): Move decl from here ...
15317 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15318
c40f8d15
AS
153192011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15320
15321 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15322
cfe0661d
JB
153232011-03-09 Juanma Barranquero <lekktu@gmail.com>
15324
15325 * search.c (compile_pattern_1): Remove argument regp, unused since
15326 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15327 (compile_pattern): Don't pass it.
15328
0afb4571
J
153292011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15330
15331 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15332 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15333 for ! HAVE_GTK3.
15334 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15335
15336 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15337
15338 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15339 gdk_window_get_screen, gdk_window_get_geometry,
15340 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15341 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15342 (xg_get_pixbuf_from_pixmap): New function.
15343 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15344 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15345 Call xg_get_pixbuf_from_pixmap instead of
15346 gdk_pixbuf_get_from_drawable.
15347 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15348 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15349 (xg_check_special_colors): Use GtkStyleContext and its functions
15350 for HAVE_GTK3.
15351 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15352 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15353 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15354 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15355 Call gtk_widget_get_preferred_size.
0afb4571
J
15356 (xg_frame_resized): gdk_window_get_geometry only takes 5
15357 parameters.
44f230aa
SM
15358 (xg_win_to_widget, xg_event_is_for_menubar):
15359 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15360 (xg_set_widget_bg): New function.
15361 (delete_cb): New function.
895009e1 15362 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15363 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15364 (xg_set_background_color): Call xg_set_widget_bg.
15365 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15366 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15367 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15368 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15369 if ! HAVE_GTK3.
15370 (update_frame_tool_bar): Call gtk_widget_hide.
15371 (xg_initialize): Use GDK_KEY_g.
15372
15373 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15374 if ! HAVE_GTK3
15375 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15376
15377 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15378 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15379 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15380
1c2cc4ef
JB
153812011-03-08 Juanma Barranquero <lekktu@gmail.com>
15382
15383 * w32xfns.c (select_palette): Check success of RealizePalette against
15384 GDI_ERROR, not zero.
15385
33383987 15386See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15387
15388;; Local Variables:
15389;; coding: utf-8
aac0c6e3
MR
15390;; End:
15391
2f097256 15392 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15393
15394 This file is part of GNU Emacs.
15395
15396 GNU Emacs is free software: you can redistribute it and/or modify
15397 it under the terms of the GNU General Public License as published by
15398 the Free Software Foundation, either version 3 of the License, or
15399 (at your option) any later version.
15400
15401 GNU Emacs is distributed in the hope that it will be useful,
15402 but WITHOUT ANY WARRANTY; without even the implied warranty of
15403 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15404 GNU General Public License for more details.
15405
15406 You should have received a copy of the GNU General Public License
15407 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.