Rewrite display-buffer-alist and display-buffer-normalize-specifiers.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
28177add
PE
12011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2
dd3482fe
PE
3 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6
393d71f3 7 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8 * fileio.c (Finsert_file_contents):
9 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10 Remove the old (too-loose) buffer overflow checks.
11 They weren't needed, since make_gap checks for buffer overflow.
12 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
13 The old code merely checked for Emacs fixnum overflow, and relied
14 on undefined (wraparound) behavior. The new code avoids undefined
15 behavior, and also checks for ptrdiff_t and/or size_t overflow.
16
2e6813b0 17 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
18 Tune. Don't use wider integers than needed. Don't use alloca.
19 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 20
599a9e4f
PE
21 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
22
99561444
PE
23 * insdel.c, lisp.h (buffer_overflow): New function.
24 (insert_from_buffer_1, replace_range, replace_range_2):
25 * insdel.c (make_gap_larger):
26 * editfns.c (Finsert_char):
27 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
28
28177add
PE
29 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
30
e69dafad
PE
312011-06-15 Paul Eggert <eggert@cs.ucla.edu>
32
a7af7fde 33 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 34
b1c46f02
PE
35 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
36 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
37
e69dafad
PE
38 * fileio.c: Don't assume EMACS_INT fits in off_t.
39 (emacs_lseek): New static function.
40 (Finsert_file_contents, Fwrite_region): Use it.
41 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
42
566684ea
PE
43 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
44
e6966cd6
PE
45 * fns.c: Don't overflow int when computing a list length.
46 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
47 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
48 truncation on 64-bit hosts. Check for QUIT every
49 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
50 faster and is responsive enough.
51 (Flength): Report an error instead of overflowing an integer.
52 (Fsafe_length): Return a float if the value is not representable
53 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 54 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 55 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 56
dd0b0efb
PE
57 * alloc.c: Check that resized vectors' lengths fit in fixnums.
58 (header_size, word_size): New constants.
59 (allocate_vectorlike): Don't check size overflow here.
60 (allocate_vector): Check it here instead, since this is the only
61 caller of allocate_vectorlike that could cause overflow.
62 Check that the new vector's length is representable as a fixnum.
63
86fe5cfe
PE
64 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
65 The previous code was bogus. For example, next_almost_prime (32)
66 returned 39, which is undesirable as it is a multiple of 3; and
67 next_almost_prime (24) returned 25, which is a multiple of 5 so
68 why was the code bothering to check for multiples of 7?
69
80e88859
PE
70 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
71
4a2f0ad6
PE
72 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
73
f66c7cf8
PE
74 Variadic C functions now count arguments with ptrdiff_t.
75 This partly undoes my 2011-03-30 change, which replaced int with size_t.
76 Back then I didn't know that the Emacs coding style prefers signed int.
77 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
78 were being counted with int, which may truncate counts on 64-bit
79 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
80 * lisp.h (struct Lisp_Subr.function.aMANY)
81 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
82 Arg counts are now ptrdiff_t, not size_t.
83 All variadic functions and their callers changed accordingly.
84 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
85 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
86 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
87 * callint.c (Fcall_interactively): Check arg count for overflow,
88 to avoid potential buffer overrun. Use signed char, not 'int',
89 for 'varies' array, so that we needn't bother to check its size
90 calculation for overflow.
91 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
92 * eval.c (apply_lambda):
93 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
94 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
95 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
96
a1759b76
PE
97 * callint.c (Fcall_interactively): Don't use index var as event count.
98
d96be9fc
PE
99 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
100 * mem-limits.h (SIZE): Remove; no longer used.
101
a690a978 102 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 103
578c21e6
PE
104 Remove unnecessary casts.
105 * xterm.c (x_term_init):
106 * xfns.c (x_set_border_pixel):
107 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
108 These aren't needed now that we assume ANSI C.
109
96f53c6c
PE
110 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
111 It's more likely to cause problems (due to unsigned overflow)
112 than to cure them.
113
83c77d31
PE
114 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
115
ee2079f1
PE
116 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
117
6da65536
PE
118 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
119
7147c4a4
PE
120 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
121
193e32d9
PE
122 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
123
e5533da6
PE
124 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
125
9910e595
PE
126 GLYPH_CODE_FACE returns EMACS_INT, not int.
127 * dispextern.h (merge_faces):
128 * xfaces.c (merge_faces):
01103c44
PE
129 * xdisp.c (get_next_display_element, next_element_from_display_vector):
130 Don't assume EMACS_INT fits in int.
9910e595 131
2638320e
PE
132 * character.h (CHAR_VALID_P): Remove unused parameter.
133 * fontset.c, lisp.h, xdisp.c: All uses changed.
134
045eb8d9
PE
135 * editfns.c (Ftranslate_region_internal): Omit redundant test.
136
c1f134b5
PE
137 * fns.c (concat): Minor tuning based on overflow analysis.
138 This doesn't fix any bugs. Use int to hold character, instead
139 of constantly refetching from Emacs object. Use XFASTINT, not
140 XINT, for value known to be a character. Don't bother comparing
141 a single byte to 0400, as it's always less.
142
395fcb93 143 * floatfns.c (Fexpt):
327eeec8
PE
144 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
145
abbd3d23
PE
146 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
147 for characters.
148
684a03ef
PE
149 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
150
0fed43f3
PE
151 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
152 Without this fix, on a 64-bit host (aset S 0 4294967386) would
153 incorrectly succeed when S was a string, because 4294967386 was
154 truncated before it was used.
155
8fd02eb7
PE
156 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
157 Otherwise, an out-of-range integer could cause undefined behavior
158 on a 64-bit host.
159
f8c86b69
PE
160 * composite.c: Use int, not EMACS_INT, for characters.
161 (fill_gstring_body, composition_compute_stop_pos): Use int, not
162 EMACS_INT, for values that are known to be in character range.
163 This doesn't fix any bugs but is the usual style inside Emacs and
164 may generate better code on 32-bit machines.
165
34206dd2
PE
166 Make sure a 64-bit char is never passed to ENCODE_CHAR.
167 This is for reasons similar to the recent CHAR_STRING fix.
168 * charset.c (Fencode_char): Check that character arg is actually
169 a character. Pass an int to ENCODE_CHAR.
170 * charset.h (ENCODE_CHAR): Verify that the character argument is no
171 wider than 'int', as a compile-time check to prevent future regressions
172 in this area.
173
c5958d4c 174 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
175
176 Make sure a 64-bit char is never passed to CHAR_STRING.
177 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
178 by silently ignoring the top 32 bits, allowing some values
179 that were far too large to be valid characters.
180 * character.h: Include <verify.h>.
181 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
182 arguments are no wider than unsigned, as a compile-time check
183 to prevent future regressions in this area.
184 * data.c (Faset):
01103c44 185 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
186 (Fsubst_char_in_region):
187 * fns.c (concat):
188 * xdisp.c (decode_mode_spec_coding):
189 Adjust to CHAR_STRING's new requirement.
190 * editfns.c (Finsert_char, Fsubst_char_in_region):
191 * fns.c (concat): Check that character args are actually
192 characters. Without this test, these functions did the wrong
193 thing with wildly out-of-range values on 64-bit hosts.
194
d37ca623
PE
195 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
196 These casts should not be needed on 32-bit hosts, either.
197 * keyboard.c (read_char):
198 * lread.c (Fload): Remove casts to unsigned.
199
ea204efb
PE
200 * lisp.h (UNSIGNED_CMP): New macro.
201 This fixes comparison bugs on 64-bit hosts.
202 (ASCII_CHAR_P): Use it.
203 * casefiddle.c (casify_object):
01103c44 204 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
205 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
206 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
207 * dispextern.h (FACE_FROM_ID):
208 * keyboard.c (read_char): Use UNSIGNED_CMP.
209
41cb286c
PE
210 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
211 not to EMACS_INT, to avoid GCC warning.
212
4a1b9832
PE
213 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
214
55daad71
PE
215 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
216 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
217 isn't needed on 32-bit machines.
8f95c75c 218
01103c44
PE
219 * buffer.c (Fgenerate_new_buffer_name):
220 Use EMACS_INT for count, not int.
0ceccced 221 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
222
223 * data.c (Qcompiled_function): Now static.
224
c6f072e7
PE
225 * window.c (window_body_lines): Now static.
226
20ce5912
PE
227 * image.c (gif_load): Rename local to avoid shadowing.
228
9c4c5f81
PE
229 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
230 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
231 * alloc.c (make_save_value): Integer argument is now of type
232 ptrdiff_t, not int.
233 (mark_object): Use ptrdiff_t, not int.
234 * lisp.h (pD): New macro.
235 * print.c (print_object): Use it.
236
c0c5c8ae
PE
237 * alloc.c: Use EMACS_INT, not int, to count objects.
238 (total_conses, total_markers, total_symbols, total_vector_size)
239 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
240 (total_free_floats, total_floats, total_free_intervals)
241 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
242 Now EMACS_INT, not int. All uses changed.
243 (Fgarbage_collect): Compute overall total using a double, so that
244 integer overflow is less likely to be a problem. Check for overflow
245 when converting back to an integer.
5a25e253
PE
246 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
247 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
248 These were 'int' variables that could overflow on 64-bit hosts;
249 they were never used, so remove them instead of repairing them.
211a0b2a 250 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
251 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
252 Previously, this ceilinged at INT_MAX, but that doesn't work on
253 64-bit machines.
e46bb31a 254 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 255
c78baabf 256 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 257 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
258 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
259 when a (possibly-narrower) signed value would do just as well.
260 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 261
c9d624c6
PE
262 * alloc.c: Catch some string size overflows that we were missing.
263 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
264 for convenience in STRING_BYTES_MAX.
265 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
266 The definition here is exact; the one in lisp.h was approximate.
267 (allocate_string_data): Check for string overflow. This catches
268 some instances we weren't catching before. Also, it catches
269 size_t overflow on (unusual) hosts where SIZE_MAX <= min
270 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
271 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 272
c9d624c6
PE
273 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
274 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
275 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
276
353032ce
PE
277 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
278
2bccce07
PE
279 * alloc.c (Fmake_string): Check for out-of-range init.
280
0ac30604
SM
2812011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
282
283 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
284
c195f2de
JD
2852011-06-14 Jan Djärv <jan.h.d@swipnet.se>
286
287 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
288 xg_get_default_scrollbar_width.
289
290 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
291 (int_gtk_range_get_value): Move to the scroll bar part of the file.
292 (style_changed_cb): Call update_theme_scrollbar_width and call
293 x_set_scroll_bar_default_width and xg_frame_set_char_size for
294 all frames (Bug#8505).
295 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
296 Call gtk_window_set_resizable if HAVE_GTK3.
297 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
298 and height if HAVE_GTK3 (Bug#8505).
299 (scroll_bar_width_for_theme): New variable.
300 (update_theme_scrollbar_width): New function.
301 (xg_get_default_scrollbar_width): Move code to
302 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
303 (xg_initialize): Call update_theme_scrollbar_width.
304
305 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
306
307 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
308
e10ac9f1
MR
3092011-06-12 Martin Rudalics <rudalics@gmx.at>
310
311 * frame.c (make_frame): Call other_buffer_safely instead of
312 other_buffer.
313
314 * window.c (temp_output_buffer_show): Call display_buffer with
315 second argument Vtemp_buffer_show_specifiers and reset latter
316 immediately after the call.
317 (Vtemp_buffer_show_specifiers): New variable.
318 (auto_window_vscroll_p, next_screen_context_lines)
319 (Vscroll_preserve_screen_position): Remove leading asterisks from
320 doc-strings.
321
2d3c217e 3222011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 323
7b7f97e8 324 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
325 * buffer.c (Qclone_number): Remove for now, as it's unused.
326 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
327 (record_buffer): Remove unused local.
328 * frame.c (other_visible_frames, frame_buffer_list): Now static.
329 (set_frame_buffer_list): Remove; unused.
330 * frame.h (other_visible_frames): Remove decl.
331 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
332 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
333 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
334 if HAVE_GPM.
335 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
336 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
337 Define only if HAVE_GPM.
338 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
339 (update_hints_inhibit): Remove; never set. All uses removed.
340 * widgetprv.h (emacsFrameClassRec): Remove decl.
341 * window.c (delete_deletable_window): Now returns void, since it
342 wasn't returning anything.
343 (compare_window_configurations): Remove unused locals.
344 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
345 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
346 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
347 the same widths as pointers. This follows up on the 2011-05-06 patch.
348 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
349 * xterm.h: Likewise.
350 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
351
1384b89e
JB
3522011-06-12 Juanma Barranquero <lekktu@gmail.com>
353
354 * makefile.w32-in: Update dependencies.
355 (LISP_H): Add lib/intprops.h.
356
1100a63c
CY
3572011-06-11 Chong Yidong <cyd@stupidchicken.com>
358
359 * image.c (gif_load): Add animation frame delay to the metadata.
360 (syms_of_image): Use DEFSYM. New symbol `delay'.
361
6198ccd0
MR
3622011-06-11 Martin Rudalics <rudalics@gmx.at>
363
364 * window.c (delete_deletable_window): Re-add.
365 (Fset_window_configuration): Rewrite to handle dead buffers and
366 consequently deletable windows.
367 (window_tree, Fwindow_tree): Remove. Supply functionality in
368 window.el.
369 (compare_window_configurations): Simplify code.
370
b6e3633c
AS
3712011-06-11 Andreas Schwab <schwab@linux-m68k.org>
372
1ab0dee5
AS
373 * image.c (imagemagick_load_image): Fix type mismatch.
374 (Fimagemagick_types): Likewise.
375
b6e3633c
AS
376 * window.h (replace_buffer_in_windows): Declare.
377
9397e56f
MR
3782011-06-11 Martin Rudalics <rudalics@gmx.at>
379
380 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
381 Qclone_number. Remove external declaration of Qdelete_window.
382 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
383 code.
384 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
385 Qbuffer_list_update_hook if allowed.
386 (Fother_buffer): Rewrite doc-string. Major rewrite for new
387 buffer list implementation.
388 (other_buffer_safely): New function.
389 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
390 calls to replace_buffer_in_windows and
391 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
392 if allowed.
393 (record_buffer): Inhibit quitting and rewrite using quittable
394 functions. Run Qbuffer_list_update_hook if allowed.
395 (Frecord_buffer, Funrecord_buffer): New functions.
396 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
397 switch-to-buffer to window.el.
398 (bury-buffer): Move to window.el.
399 (Vbuffer_list_update_hook): New variable.
400
401 * lisp.h (other_buffer_safely): Add prototype in buffer.c
402 section.
403
404 * window.h (resize_frame_windows): Move up in code.
405 (Fwindow_frame): Remove EXFUN.
406 (replace_buffer_in_all_windows): Remove prototype.
407 (replace_buffer_in_windows_safely): Add prototype.
408
409 * window.c: Declare Qdelete_window static again. Move down
410 declaration of select_count.
411 (Fnext_window, Fprevious_window): Rewrite doc-strings.
412 (Fother_window): Move to window.el.
413 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
414 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
415 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
416 window.el.
417 (replace_buffer_in_windows): Implement by calling
418 Qreplace_buffer_in_windows.
419 (replace_buffer_in_all_windows): Remove with some functionality
420 moved into replace_buffer_in_windows_safely.
421 (replace_buffer_in_windows_safely): New function.
422 (select_window_norecord, select_frame_norecord): Move in front
423 of run_window_configuration_change_hook. Remove now obsolete
424 declarations.
425 (Fset_window_buffer): Rewrite doc-string. Call
426 Qrecord_window_buffer.
427 (keys_of_window): Move binding for other-window to window.el.
428
b50691aa
CY
4292011-06-11 Chong Yidong <cyd@stupidchicken.com>
430
431 * dispextern.h (struct image): Replace data member, whose int_val
432 and ptr_val fields were not used by anything, with a single
433 lisp_val object.
434
435 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
436 (gif_clear_image, gif_load, imagemagick_load_image)
437 (gs_clear_image, gs_load): Callers changed.
438
3f754b86
PE
4392011-06-10 Paul Eggert <eggert@cs.ucla.edu>
440
cca69397
PE
441 * buffer.h: Include <time.h>, for time_t.
442 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
443
109e28d0
PE
444 Fix minor problems found by static checking.
445
60737f02
PE
446 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
447
4b66faf3
PE
448 Make identifiers static if they are not used in other modules.
449 * data.c (Qcompiled_function, Qframe, Qvector):
450 * image.c (QimageMagick, Qsvg):
451 * minibuf.c (Qmetadata):
452 * window.c (resize_window_check, resize_root_window): Now static.
453 * window.h (resize_window_check, resize_root_window): Remove decls.
454
109e28d0
PE
455 * window.c (window_deletion_count, delete_deletable_window):
456 Remove; unused.
46a4ce9e
PE
457 (window_body_lines): Now static.
458 (Fdelete_other_windows_internal): Mark vars as initialized.
459 Make sure 'resize_failed' is initialized.
460 (run_window_configuration_change_hook): Rename local to avoid shadowing.
461 (resize_window_apply): Remove unused local.
462 * window.h (delete_deletable_window): Remove decl.
463
109e28d0 464 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
465 (imagemagick_load_image): Fix pointer signedness problem by changing
466 last arg from unsigned char * to char *. All uses changed.
467 Also, fix a local for similar reasons.
468 Remove unused locals. Remove locals to avoid shadowing.
469 (fn_rsvg_handle_free): Remove; unused.
470 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 471 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 472
3f754b86
PE
473 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
474
2547adb1
CY
4752011-06-10 Chong Yidong <cyd@stupidchicken.com>
476
477 * image.c (gif_load): Fix omitted cast error introduced by
478 2011-06-06 change.
479
2c8e37d4
MR
4802011-06-10 Martin Rudalics <rudalics@gmx.at>
481
482 * window.h (resize_proportionally, orig_total_lines)
483 (orig_top_line): Remove from window structure.
484 (set_window_height, set_window_width, change_window_heights)
485 (Fdelete_window): Remove prototypes.
486 (resize_frame_windows): Remove duplicate declaration.
487
440a42e3
EZ
4882011-06-10 Eli Zaretskii <eliz@gnu.org>
489
490 * window.h (resize_frame_windows, resize_window_check)
491 (delete_deletable_window, resize_root_window)
492 (resize_frame_windows): Declare prototypes.
493
494 * window.c (resize_window_apply): Make definition be "static" to
495 match the prototype.
496
562dd5e9
MR
4972011-06-10 Martin Rudalics <rudalics@gmx.at>
498
499 * window.c: Remove declarations of Qwindow_size_fixed,
500 window_min_size_1, window_min_size_2, window_min_size,
501 size_window, window_fixed_size_p, enlarge_window, delete_window.
502 Remove static from declaration of Qdelete_window, it's
503 temporarily needed by Fbury_buffer.
504 (replace_window): Don't assign orig_top_line and
505 orig_total_lines.
506 (Fdelete_window, delete_window): Remove. Window deletion is
507 handled by window.el.
508 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
509 Fdelete_window calls with calls to Qdelete_window.
510 (Fdelete_other_windows): Remove. Deleting other windows is
511 handled by window.el.
512 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
513 handled in window.el.
514 (window_min_size_2, window_min_size_1, window_min_size): Remove.
515 Window minimum sizes are handled in window.el.
516 (shrink_windows, size_window, set_window_height)
517 (set_window_width, change_window_heights, window_height)
518 (window_width, CURBEG, CURSIZE, enlarge_window)
519 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
520 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
521 handled in window.el.
522 (make_dummy_parent): Rename to make_parent_window and give it a
523 second argument horflag.
524 (make_window): Don't set resize_proportionally any more.
525 (Fsplit_window): Remove. Windows are split in window.el.
526 (save_restore_action, save_restore_orig_size)
527 (shrink_window_lowest_first, save_restore_orig_size): Remove.
528 Resize mini windows in window.el.
529 (grow_mini_window, shrink_mini_window): Implement by calling
530 Qresize_root_window_vertically, resize_window_check and
531 resize_window_apply.
532 (saved_window, Fset_window_configuration, save_window_save): Do
533 not handle orig_top_line, orig_total_lines, and
534 resize_proportionally.
535 (window_min_height, window_min_width): Move to window.el.
536 (keys_of_window): Move bindings for delete-other-windows,
537 split-window, delete-window and enlarge-window to window.el.
538
539 * buffer.c: Temporarily extern Qdelete_window.
540 (Fbury_buffer): Temporarily call Qdelete_window instead of
541 Fdelete_window (Fbury_buffer will move to window.el soon).
542
543 * frame.c (set_menu_bar_lines_1): Remove code handling
544 orig_top_line and orig_total_lines.
545
546 * dispnew.c (adjust_frame_glyphs_initially): Don't use
547 set_window_height but set heights directly.
548 (change_frame_size_1): Use resize_frame_windows.
549
550 * xdisp.c (init_xdisp): Don't use set_window_height but set
551 heights directly.
552
553 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
554 resize_frame_windows instead of change_window_heights and run
555 run_window_configuration_change_hook.
556
557 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
558 instead of change_window_heights and run
559 run_window_configuration_change_hook.
560
1a13852e
MR
5612011-06-09 Martin Rudalics <rudalics@gmx.at>
562
563 * window.c (replace_window): Rename second argument REPLACEMENT to
564 NEW. New third argument SETFLAG. Rewrite.
565 (delete_window, make_dummy_parent): Call replace_window with
566 third argument 1.
567 (window_list_1): Move down in code.
568 (run_window_configuration_change_hook): Move set_buffer part
569 before select_frame_norecord part in order to unwind correctly.
570 Rename count1 to count.
571 (recombine_windows, delete_deletable_window, resize_root_window)
572 (Fdelete_other_windows_internal)
573 (Frun_window_configuration_change_hook, make_parent_window)
574 (resize_window_check, resize_window_apply, Fresize_window_apply)
575 (resize_frame_windows, Fsplit_window_internal)
576 (Fdelete_window_internal, Fresize_mini_window_internal): New
577 functions.
578 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
579
f3d1777e
MR
5802011-06-08 Martin Rudalics <rudalics@gmx.at>
581
496e208e
MR
582 * window.h (window): Add some new members to window structure -
583 normal_lines, normal_cols, new_total, new_normal, clone_number,
584 splits, nest, prev_buffers, next_buffers.
585 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 586 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 587
f3d1777e
MR
588 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
589 Remove.
496e208e
MR
590 (make_dummy_parent): Set new members of windows structure.
591 (make_window): Move down in code. Handle new members of window
592 structure.
593 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
594 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
595 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
596 (Fset_window_prev_buffers, Fwindow_next_buffers)
597 (Fset_window_next_buffers, Fset_window_clone_number): New
598 functions.
599 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
600 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
601 Doc-string fixes.
602 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
603 Argument WINDOW can be now internal window too.
604 (Fwindow_use_time): Move up in code.
605 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
606 Rewrite doc-string.
607 (Fset_window_configuration, saved_window)
608 (Fcurrent_window_configuration, save_window_save): Handle new
609 members of window structure.
b9e809c2
MR
610 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
611 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
612 (syms_of_window): New Lisp objects Qrecord_window_buffer,
613 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
614 Qget_mru_window, Qresize_root_window,
615 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
616 Qauto_buffer_name; staticpro them.
f3d1777e 617
abde8f8c
MR
6182011-06-07 Martin Rudalics <rudalics@gmx.at>
619
620 * window.c (Fwindow_total_size, Fwindow_left_column)
621 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
622 (Fwindow_list_1): New functions.
623 (window_box_text_cols): Replace with window_body_cols.
624 (Fwindow_width, Fscroll_left, Fscroll_right): Use
625 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
626 (delete_window, Fset_window_configuration): Call
627 delete_all_subwindows with window as argument.
628 (delete_all_subwindows): Take a window as argument and not a
629 structure. Rewrite.
190b47e6
MR
630 (window_loop): Remove handling of GET_LRU_WINDOW and
631 GET_LARGEST_WINDOW.
632 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
633
634 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
635 window_box_text_cols. delete_all_subwindows now takes a
636 Lisp_Object as argument.
abde8f8c
MR
637
638 * indent.c (compute_motion, Fcompute_motion): Use
639 window_body_cols instead of window_box_text_cols.
640
fa8a67e6
MR
641 * frame.c (delete_frame): Call delete_all_subwindows with root
642 window as argument.
643
a54e3482
DC
6442011-06-07 Daniel Colascione <dan.colascione@gmail.com>
645
646 * fns.c (Fputhash): Document return value.
647
60002bf5
CY
6482011-06-06 Chong Yidong <cyd@stupidchicken.com>
649
650 * image.c (gif_load): Implement gif89a spec "no disposal" method.
651
0c671da6 6522011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 653
b862a52a 654 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 655
be44ca6c
PE
656 Check for overflow when converting integer to cons and back.
657 * charset.c (Fdefine_charset_internal, Fdecode_char):
658 Use cons_to_unsigned to catch overflow.
659 (Fencode_char): Use INTEGER_TO_CONS.
660 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
661 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
662 * data.c (long_to_cons, cons_to_long): Remove.
663 (cons_to_unsigned, cons_to_signed): New functions.
664 These signal an error for invalid or out-of-range values.
665 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
666 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
667 * font.c (Ffont_variation_glyphs):
668 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
669 * lisp.h: Include <intprops.h>.
670 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
671 (cons_to_signed, cons_to_unsigned): New decls.
672 (long_to_cons, cons_to_long): Remove decls.
673 * undo.c (record_first_change): Use INTEGER_TO_CONS.
674 (Fprimitive_undo): Use CONS_TO_INTEGER.
675 * xfns.c (Fx_window_property): Likewise.
676 * xselect.c: Include <limits.h>.
677 (x_own_selection, selection_data_to_lisp_data):
678 Use INTEGER_TO_CONS.
679 (x_handle_selection_request, x_handle_selection_clear)
680 (x_get_foreign_selection, Fx_disown_selection_internal)
681 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
682 (lisp_data_to_selection_data): Use cons_to_unsigned.
683 (x_fill_property_data): Use cons_to_signed.
684 Report values out of range.
685
d1f3d2af
PE
686 Check for buffer and string overflow more precisely.
687 * buffer.h (BUF_BYTES_MAX): New macro.
688 * lisp.h (STRING_BYTES_MAX): New macro.
689 * alloc.c (Fmake_string):
690 * character.c (string_escape_byte8):
691 * coding.c (coding_alloc_by_realloc):
692 * doprnt.c (doprnt):
693 * editfns.c (Fformat):
694 * eval.c (verror):
695 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
696 since they may not be the same number.
697 * editfns.c (Finsert_char):
698 * fileio.c (Finsert_file_contents):
699 Likewise for BUF_BYTES_MAX.
700
dd52fcea
PE
701 * image.c: Use ptrdiff_t, not int, for sizes.
702 (slurp_file): Switch from int to ptrdiff_t.
703 All uses changed.
704 (slurp_file): Check that file size fits in both size_t (for
705 malloc) and ptrdiff_t (for sanity and safety).
706
7f9bbdbb
PE
707 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
708 if b->modtime has its maximal value.
709
dfe18f82
PE
710 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
711
84acfcf0
PE
712 Don't assume time_t can fit into int.
713 * buffer.h (struct buffer.modtime): Now time_t, not int.
714 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
715 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
716
ccd9a01a
PE
717 Minor fixes for signed vs unsigned integers.
718 * character.h (MAYBE_UNIFY_CHAR):
719 * charset.c (maybe_unify_char):
720 * keyboard.c (read_char, reorder_modifiers):
721 XINT -> XFASTINT, since the integer must be nonnegative.
722 * ftfont.c (ftfont_spec_pattern):
723 * keymap.c (access_keymap, silly_event_symbol_error):
724 XUINT -> XFASTINT, since the integer must be nonnegative.
725 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
726 since it makes no difference and we prefer signed.
727 * keyboard.c (record_char): Use XUINT when all the neighbors do.
728 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
729 nonnegative.
730
d6d100dd
SM
7312011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
732
733 * window.h (Fwindow_frame): Declare.
734
2b6148e4
PE
7352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
736
737 * alloc.c: Simplify handling of large-request failures (Bug#8800).
738 (SPARE_MEMORY): Always define.
739 (LARGE_REQUEST): Remove.
740 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
741
f230ecc9
MR
7422011-06-06 Martin Rudalics <rudalics@gmx.at>
743
727e958e
MR
744 * lisp.h: Move EXFUNS for Fframe_root_window,
745 Fframe_first_window and Fset_frame_selected_window to window.h.
746
747 * window.h: Move EXFUNS for Fframe_root_window,
748 Fframe_first_window and Fset_frame_selected_window here from
749 lisp.h.
750
751 * frame.c (Fwindow_frame, Fframe_first_window)
752 (Fframe_root_window, Fframe_selected_window)
753 (Fset_frame_selected_window): Move to window.c.
754 (Factive_minibuffer_window): Move to minibuf.c.
755 (Fother_visible_frames_p): New function.
756
757 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
758
f230ecc9
MR
759 * window.c (decode_window, decode_any_window): Move up in code.
760 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
761 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
762 (Fwindow_buffer): Move up and rewrite doc-string.
763 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
764 (Fwindow_prev): New functions.
727e958e
MR
765 (Fwindow_frame): Move here from frame.c. Accept any window as
766 argument.
767 (Fframe_root_window, Fframe_first_window)
768 (Fframe_selected_window): Move here from frame.c. Accept frame
769 or arbitrary window as argument. Update doc-strings.
770 (Fminibuffer_window): Move up in code.
771 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
772 (Fset_frame_selected_window): Move here from frame.c.
773 Marginal rewrite.
727e958e
MR
774 (Fselected_window, select_window, Fselect_window): Move up in
775 code. Minor doc-string fixes.
f230ecc9 776
4d09bcf6
PE
7772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
778
779 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
780 Do not assume that spare memory exists; that assumption is valid
781 only if SYSTEM_MALLOC.
782 (LARGE_REQUEST): New macro, so that the issue of large requests
783 is separated from the issue of spare memory.
784
810928a2
AS
7852011-06-05 Andreas Schwab <schwab@linux-m68k.org>
786
172418ad
AS
787 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
788 format. (Bug#8806)
789
43f862f7
AS
790 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
791
810928a2
AS
792 * xfns.c (x_set_scroll_bar_default_width): Move declarations
793 before statements.
794
a059fe24
JD
7952011-06-05 Jan Djärv <jan.h.d@swipnet.se>
796
797 * gtkutil.c (xg_get_default_scrollbar_width): New function.
798
799 * gtkutil.h: Declare xg_get_default_scrollbar_width.
800
801 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
802 min width by calling x_set_scroll_bar_default_width (Bug#8505).
803
989bf368
JB
8042011-06-05 Juanma Barranquero <lekktu@gmail.com>
805
806 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
807
4b80f674
CY
8082011-06-04 Chong Yidong <cyd@stupidchicken.com>
809
810 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
811 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
812 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
813 New error handlers.
4b80f674
CY
814 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
815 Obey Vx_select_enable_clipboard_manager. Catch errors in
816 x_clipboard_manager_save (Bug#8779).
817 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 818 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 819
99a33b77 8202011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
821
822 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
823
99a33b77 8242011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
825
826 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
827 in the current matrix if keep_current_p is non-zero.
828
8264569d
EZ
8292011-06-04 Eli Zaretskii <eliz@gnu.org>
830
831 * bidi.c (bidi_level_of_next_char): Fix last change.
832
57f97249
EZ
8332011-06-03 Eli Zaretskii <eliz@gnu.org>
834
fec2107c 835 Support bidi reordering of text covered by display properties.
57f97249 836
fec2107c
EZ
837 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
838 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
839 (bidi_cache_search, bidi_cache_iterator_state)
840 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
841 (bidi_level_of_next_char, bidi_move_to_visually_next):
842 Support character positions inside a run of characters covered by a
fec2107c
EZ
843 display string.
844 (bidi_paragraph_init, bidi_resolve_explicit_1)
845 (bidi_level_of_next_char): Call bidi_fetch_char and
846 bidi_fetch_char_advance instead of FETCH_CHAR and
847 FETCH_CHAR_ADVANCE.
848 (bidi_init_it): Initialize new members.
849 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
850 definitions.
851 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
852 instead of using explicit *_CHAR codes.
d6d100dd
SM
853 (bidi_resolve_explicit, bidi_resolve_weak):
854 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
855 bidirectional text is supported only in multibyte buffers.
856 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
857 it to initialize the frame_window_p member of struct bidi_it.
858 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
859 (bidi_resolve_explicit, bidi_resolve_weak)
860 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
861 bidi_it->nchars is non-positive.
862 (bidi_level_of_next_char): Don't try to lookup the cache for the
863 next/previous character if nothing is cached there yet, or if we
864 were just reseat()'ed to a new position.
c40e2fb2 865
0e14fe90
EZ
866 * xdisp.c (set_cursor_from_row): Set start and stop points
867 according to the row's direction when priming the loop that looks
868 for the glyph on which to display cursor.
869 (single_display_spec_intangible_p): Function deleted.
870 (display_prop_intangible_p): Reimplement to call
871 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
872 Accept 3 additional arguments needed by handle_display_spec.
873 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
874 values: lists, `(when COND...)' forms, etc.
875 (single_display_spec_string_p): Support property values that are
876 lists with the argument STRING its top-level element.
877 (display_prop_string_p): Fix the condition for processing a
878 property that is a list to be consistent with handle_display_spec.
fec2107c 879 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
880 last portion of handle_display_prop.
881 (compute_display_string_pos): Accept additional argument
882 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
883 value of a `display' property is a "replacing spec".
884 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
885 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
886 the display property, but just return a value indicating whether
887 the display property will replace the characters it covers.
888 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
889 frame_window_p members of struct bidi_it.
d6d100dd
SM
890 (compute_display_string_pos, compute_display_string_end):
891 New functions.
fec2107c
EZ
892 (push_it): Accept second argument POSITION, where pop_it should
893 jump to continue iteration.
894 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 895
fec2107c
EZ
896 * keyboard.c (adjust_point_for_property): Adjust the call to
897 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
898
899 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
900 (bidi_init_it): Update prototypes.
901 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
902 (compute_display_string_pos, compute_display_string_end):
903 Declare prototypes.
fec2107c
EZ
904 (struct bidi_it): New members nchars and disp_pos. ch_len is now
905 EMACS_INT.
fc6f18ce 906
40087514 9072011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 908
57f53182
PE
909 Malloc failure behavior now depends on size of allocation.
910 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
911 * lisp.h: Change signatures accordingly.
912 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
913 All callers changed. (Bug#8762)
914
915 * gnutls.c: Use Emacs's memory allocators.
916 Without this change, the gnutls library would invoke malloc etc.
917 directly, which causes problems on non-SYNC_INPUT hosts, and which
918 runs afoul of improving memory_full behavior. (Bug#8761)
919 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
920 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
921 xfree instead of the default malloc, realloc, free.
922 (Fgnutls_boot): No need to check for memory allocation failure,
923 since xmalloc does that for us.
924
ac32cd99 925 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
926 * category.c (hash_get_category_set):
927 * ccl.c (ccl_driver):
928 * charset.c (Fdefine_charset_internal):
929 * charset.h (struct charset.hash_index):
930 * composite.c (get_composition_id, gstring_lookup_cache)
931 (composition_gstring_put_cache):
932 * composite.h (struct composition.hash_index):
933 * dispextern.h (struct image.hash):
934 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
935 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
936 (hashfn_equal, hashfn_user_defined, make_hash_table)
937 (maybe_resize_hash_table, hash_lookup, hash_put)
938 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
939 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
940 (Fsxhash, Fgethash, Fputhash, Fmaphash):
941 * image.c (make_image, search_image_cache, lookup_image)
942 (xpm_put_color_table_h):
943 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 944 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
945 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
946 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
947 * alloc.c (allocate_vectorlike):
948 Check for overflow in vector size calculations.
949 * ccl.c (ccl_driver):
950 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
951 * fns.c, image.c: Remove unnecessary static decls that would otherwise
952 need to be updated by these changes.
40087514
PE
953 * fns.c (make_hash_table, maybe_resize_hash_table):
954 Check for integer overflow with large hash tables.
0de4bb68
PE
955 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
956 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
957 (SXHASH_REDUCE): New macro.
958 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
959 Use it instead of discarding useful hash info with large hash values.
960 (sxhash_float): New function.
961 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
962 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
963 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
964 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
965 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
966 Adjust signatures to match updated version of code.
967 (consing_since_gc): Now EMACS_INT, since a single hash table can
968 use more than INT_MAX bytes.
969
698d32e2
DN
9702011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
971
972 Make it possible to build with GCC-4.6+ -O2 -flto.
973
974 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
975
fd6fa53f
SM
9762011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
977
978 * minibuf.c (get_minibuffer, read_minibuf_unwind):
979 Call minibuffer-inactive-mode.
980
864db017
JB
9812011-05-31 Juanma Barranquero <lekktu@gmail.com>
982
983 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
984 Update dependencies.
985
2ad0baf4
DN
9862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
987
988 * data.c (init_data): Remove code for UTS, this system is not
989 supported anymore.
990
4fcc2638
DN
9912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
992
993 Don't force ./temacs to start in terminal mode.
994
995 * frame.c (make_initial_frame): Initialize faces in all cases, not
996 only when CANNOT_DUMP is defined.
997 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
998
c56e0fd5
DN
9992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1000
1001 * dispnew.c (add_window_display_history): Use const for the string
1002 pointer. Remove declaration, not needed.
1003
333d54da 10042011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1005
55d4c1b2 1006 Use 'inline', not 'INLINE'.
333d54da 1007 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1008 * alloc.c, fontset.c (INLINE): Remove.
1009 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1010 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1011 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1012 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1013 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1014
738db178
DN
10152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1016
1017 Make it possible to run ./temacs.
1018
1019 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1020 syms_of_callproc does the same thing. Remove test for
1021 "initialized", do it in the caller.
1022 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1023
620c53a6
SM
10242011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1025
1026 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1027 (read_minibuf): Use get_minibuffer.
1028 (syms_of_minibuf): Use DEFSYM.
1029 (Qmetadata): New var.
1030 * data.c (Qbuffer): Don't make it static.
1031 (syms_of_data): Use DEFSYM.
1032
e003a292
PE
10332011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1036 (CCL_CODE_MIN): New macro.
1037
ed008a6d
PE
10382011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1039
3687c2ef
PE
1040 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1041
ed008a6d
PE
1042 * eval.c (Qdebug): Now static.
1043 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1044 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1045 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1046
d66c4c7c
CY
10472011-05-29 Chong Yidong <cyd@stupidchicken.com>
1048
1049 * image.c: Various fixes to ImageMagick code comments.
1050 (Fimagemagick_types): Doc fix.
1051
5fbc2025
PE
10522011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1053
0196f88a
PE
1054 Minor fixes prompted by GCC 4.6.0 warnings.
1055
1056 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1057
5fbc2025
PE
1058 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1059 (x_clipboard_manager_save_all): Move extern decl to ...
1060 * xterm.h: ... here, so that it can be checked for consistency.
1061
1dd3c2d9
CY
10622011-05-29 Chong Yidong <cyd@stupidchicken.com>
1063
1064 * xselect.c (x_clipboard_manager_save_frame)
1065 (x_clipboard_manager_save_all): New functions.
1066 (Fx_clipboard_manager_save): Lisp function deleted.
1067
1068 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1069 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1070
1071 * xterm.h: Update prototype.
1072
5ba6571d
WX
10732011-05-28 William Xu <william.xwl@gmail.com>
1074
1075 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1076 exiting (Bug#8239).
1077
3eaff834
JM
10782011-05-28 Jim Meyering <meyering@redhat.com>
1079
e1900994 1080 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1081 * fns.c (to_uchar): Define.
1082 (crypto_hash_function): Use it to convert some newly-signed
1083 variables to unsigned, to avoid sign-extension bugs. For example,
1084 without this change, (md5 "truc") would evaluate to
1085 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1086 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1087 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1088
0f6990a7
PE
10892011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1090
1091 Integer overflow fixes.
c8a9ca5a 1092
08686060
PE
1093 * dbusbind.c: Serial number integer overflow fixes.
1094 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1095 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1096 to hold a serial number that is too large for a fixnum.
1097 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1098 Check for serial numbers out of range. Decode any serial number
59568bf0 1099 that was so large that it became a float. (Bug#8722)
08686060 1100
2d1fc3c7
PE
1101 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1102 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1103 Use XFASTINT rather than XUINT when numbers are nonnegative.
1104 (xd_append_arg, Fdbus_method_return_internal):
1105 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1106 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1107 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1108 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1109 (Bug#8722)
2d1fc3c7 1110
c8a9ca5a
PE
1111 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1112
519e1d69
PE
1113 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1114
30569699
PE
1115 ccl: add integer overflow checks
1116 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1117 (IN_INT_RANGE): New macros.
1118 (ccl_driver): Use them to check for integer overflow when
1119 decoding a CCL program. Many of the new checks are whether XINT (x)
1120 fits in int; it doesn't always, on 64-bit hosts. The new version
1121 doesn't catch all possible integer overflows, but it's an
847044ea 1122 improvement. (Bug#8719)
30569699 1123
c11285dc
PE
1124 * alloc.c (make_event_array): Use XINT, not XUINT.
1125 There's no need for unsigned here.
1126
fdccd48e
PE
1127 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1128 This follows up to the 2011-05-06 change that substituted uintptr_t
1129 for EMACS_INT. This case wasn't caught back then.
1130
37910ab2
PE
1131 Rework Fformat to avoid integer overflow issues.
1132 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1133 now (part of C89). Include <verify.h>.
1134 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1135 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1136 (Fformat): Avoid the prepass trying to compute sizes; it was only
1137 approximate and thus did not catch overflow reliably. Instead, walk
1138 through the format just once, formatting and computing sizes as we go,
1139 checking for integer overflow at every step, and allocating a larger
1140 buffer as needed. Keep track separately whether the format is
1141 multibyte. Keep only the most-recently calculated precision, rather
1142 than them all. Record whether each argument has been converted to
1143 string. Use EMACS_INT, not int, for byte and char and arg counts.
1144 Support field widths and precisions larger than INT_MAX. Avoid
1145 sprintf's undefined behavior with conversion specifications such as %#d
1146 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1147 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1148 formatting out-of-range floating point numbers with int
1149 formats. (Bug#8668)
1150
2e6578fb
PE
1151 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1152
0ae6bdee
PE
1153 * data.c: Avoid integer truncation in expressions involving floats.
1154 * data.c: Include <intprops.h>.
1155 (arith_driver): When there's an integer overflow in an expression
1156 involving floating point, convert the integers to floating point
1157 so that the resulting value does not suffer from catastrophic
1158 integer truncation. For example, on a 64-bit host (* 4
1159 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1160 Do not rely on undefined behavior after integer overflow.
1161
de883a70
PE
1162 merge count_size_as_multibyte, parse_str_to_multibyte
1163 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1164 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1165 Check for integer overflow.
1166 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1167 since it's now a duplicate of the other. This is more of
1168 a character than a buffer op, so better that it's in character.c.
1169 * fns.c, print.c: Adjust to above changes.
1170
2ff916cb
PE
11712011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1172
1173 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1174
f1b54466
PE
11752011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1176
fb1ac845
PE
1177 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1178 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1179 (x_clipboard_manager_save): Now static.
1180 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1181
f1b54466
PE
1182 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1183 (crypto_hash_function): Now static.
1184 Fix pointer signedness problems. Avoid unnecessary initializations.
1185
a9f737ee
CY
11862011-05-27 Chong Yidong <cyd@stupidchicken.com>
1187
1188 * termhooks.h (Vselection_alist): Make it terminal-local.
1189
1190 * terminal.c (create_terminal): Initialize it.
1191
1192 * xselect.c: Support for clipboard managers.
1193 (Vselection_alist): Move to termhooks.h as terminal-local var.
1194 (LOCAL_SELECTION): New macro.
1195 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1196 (symbol_to_x_atom): Remove gratuitous arg.
1197 (x_handle_selection_request, lisp_data_to_selection_data)
1198 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1199 (x_own_selection, x_get_local_selection, x_convert_selection):
1200 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1201 (some_frame_on_display): Delete unused function.
1202 (Fx_own_selection_internal, Fx_get_selection_internal)
1203 (Fx_disown_selection_internal, Fx_selection_owner_p)
1204 (Fx_selection_exists_p): New optional frame arg.
1205 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1206 (x_handle_selection_clear): Don't treat other terminals with the
1207 same keyboard specially. Use the terminal-local Vselection_alist.
1208 (x_clear_frame_selections): Use Frun_hook_with_args.
1209
1210 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1211
1212 * xterm.h: Add support for those atoms.
1213
e067f0c1
CY
12142011-05-26 Chong Yidong <cyd@stupidchicken.com>
1215
1216 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1217 (converted_selections, conversion_fail_tag): New global variables.
1218 (x_selection_request_lisp_error): Free the above.
1219 (x_get_local_selection): Remove unnecessary code.
1220 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1221 of converted selections stored in converted_selections.
1222 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1223 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1224 (x_convert_selection): New function.
1225 (x_handle_selection_event): Simplify.
1226 (x_get_foreign_selection): Don't ignore incoming requests while
1227 waiting for an answer; this will fail when we implement
1228 SAVE_TARGETS, and seems unnecessary anyway.
1229 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1230 (Vx_sent_selection_functions): Doc fix.
1231
0f4aebc0
LL
12322011-05-26 Leo Liu <sdl.web@gmail.com>
1233
1234 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1235
e61124cd
YM
12362011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1237
1238 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1239
1240 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1241 for fringe update if it has periodic bitmap.
1242 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1243 and fringe_bitmap_periodic_p.
1244
1245 * fringe.c (get_fringe_bitmap_data): New function.
1246 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1247 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1248 row. Mark glyph row for fringe update if periodicity changed.
1249
1250 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1251 for fringe update unless it has periodic bitmap.
1252
f16d9837
KH
12532011-05-25 Kenichi Handa <handa@m17n.org>
1254
1255 * xdisp.c (get_next_display_element): Set correct it->face_id for
1256 a static composition.
1257
e1b90ef6
LL
12582011-05-24 Leo Liu <sdl.web@gmail.com>
1259
1260 * deps.mk (fns.o):
1261 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1262
1263 * fns.c (crypto_hash_function, Fsha1): New function.
1264 (Fmd5): Use crypto_hash_function.
1265 (syms_of_fns): Add Ssha1.
1266
7400048f
PE
12672011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1268
1269 * gnutls.c: Remove unused macros.
1270 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1271 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1272 Remove macros that are defined and never used.
1273 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1274
abb71cf4
CY
12752011-05-22 Chong Yidong <cyd@stupidchicken.com>
1276
1277 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1278 (Fx_get_selection_internal): Minor cleanup.
1279 (Fx_own_selection_internal): Rename arguments for consistency with
1280 select.el.
1281
6307db39
PE
12822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1285
f3d4e0a4
CY
12862011-05-22 Chong Yidong <cyd@stupidchicken.com>
1287
1288 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1289
4d8ade89
YM
12902011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1291
1292 * dispnew.c (scrolling_window): Don't exclude the case that the
1293 last enabled row in the desired matrix touches the bottom boundary.
1294
32078c8d
GM
12952011-05-21 Glenn Morris <rgm@gnu.org>
1296
1297 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1298 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1299 and add some more files.
32078c8d 1300
7285dc67
EZ
13012011-05-20 Eli Zaretskii <eliz@gnu.org>
1302
1303 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1304 report_file_error introduced by the change from 2011-05-07.
1305
89d1bd22
PE
13062011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1307
1308 * systime.h (Time): Define only if emacs is defined.
1309 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1310 where the include path doesn't have X11/X.h by default. See
1311 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1312
e23640bb 13132011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1314
1315 * composite.c (find_automatic_composition): Fix previous change.
1316
b9704ad9
GM
13172011-05-20 Glenn Morris <rgm@gnu.org>
1318
1319 * lisp.mk: New file, split from Makefile.in.
1320 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1321 (shortlisp): Remove.
1322 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1323
4a720484
GM
13242011-05-19 Glenn Morris <rgm@gnu.org>
1325
1326 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1327 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1328 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1329 (lisp): Set the order to that of loadup.el.
1330 (shortlisp): Make it a copy of $lisp.
1331 (SOME_MACHINE_LISP): Remove.
1332 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1333 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1334
a28d4396
KH
13352011-05-18 Kenichi Handa <handa@m17n.org>
1336
1337 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1338 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1339 (find_automatic_composition): Mostly rewrite for efficiency.
1340
a2b1fa8e
JB
13412011-05-18 Juanma Barranquero <lekktu@gmail.com>
1342
1343 * makefile.w32-in: Update dependencies.
1344
8e1f5610
CS
13452011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1346
1347 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1348 revision 104625).
1349
7025ee00 13502011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1351
cdfa6eab
PE
1352 Fix some integer overflow issues, such as string length overflow.
1353
06d6db33
PE
1354 * insdel.c (count_size_as_multibyte): Check for string overflow.
1355
2b4560a8
PE
1356 * character.c (lisp_string_width): Check for string overflow.
1357 Use EMACS_INT, not int, for string indexes and lengths; in
1358 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1359 the resulting string length overflows an EMACS_INT; instead,
1360 report a string overflow if no precision given. When checking for
1361 precision exhaustion, use a check that cannot possibly have
1362 integer overflow. (Bug#8675)
1363 * character.h (lisp_string_width): Adjust to new signature.
1364
cb93f9be
PE
1365 * alloc.c (string_overflow): New function.
1366 (Fmake_string): Use it. This doesn't change behavior, but saves
1367 a few bytes and will simplify future changes.
1368 * character.c (string_escape_byte8): Likewise.
1369 * lisp.h (string_overflow): New decl.
1370
1a1f3366
PE
1371 Fixups, following up to the user-interface timestamp change.
1372 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1373 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1374 * msdos.c (mouse_get_pos): Likewise.
1375 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1376 * w32gui.h (Time): Define by including "systime.h" rather than by
1377 declaring it ourselves. (Bug#8664)
1378
d4e3e4d3
PE
1379 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1380 * image.c (clear_image_cache): Likewise.
1381
f6a24d19
PE
1382 * term.c (term_mouse_position): Don't assume time_t wraparound.
1383
08dc5ae6
PE
1384 Be more systematic about user-interface timestamps.
1385 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1386 and sometimes 'EMACS_UINT', to represent these timestamps.
1387 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1388 This makes the code easier to follow, and makes it easier to catch
1389 integer overflow bugs such as Bug#8664.
1390 * frame.c (Fmouse_position, Fmouse_pixel_position):
1391 Use Time, not unsigned long, for user-interface timestamps.
1392 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1393 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1394 * keyboard.h (last_event_timestamp): Likewise.
1395 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1396 * menu.h (xmenu_show): Likewise.
1397 * term.c (term_mouse_position): Likewise.
1398 * termhooks.h (struct input_event.timestamp): Likewise.
1399 (struct terminal.mouse_position_hook): Likewise.
1400 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1401 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1402 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1403 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1404 what it was before.
1405 * menu.h, termhooks.h: Include "systime.h", for Time.
1406
8e55734a
PE
1407 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1408 Don't assume that the difference between two unsigned long values
1409 can fit into an integer. At this point, we know button_down_time
1410 <= event->timestamp, so the difference must be nonnegative, so
1411 there's no need to cast the result if double-click-time is
1412 nonnegative, as it should be; check that it's nonnegative, just in
1413 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1414 apart (about 25 days). (Bug#8664)
8e55734a 1415
841f1b75 1416 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1417 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1418
3e26f69c
PE
1419 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1420 that always fit in int. Use a sentinel instead of a counter, to
1421 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1422 * frame.h (struct frame): Use int for menu_bar_items_used
1423 instead of EMACS_INT, since it always fits in int.
3e26f69c 1424
5cc152c0
PE
1425 * menu.c (grow_menu_items): Check for int overflow.
1426
d89eb65e
PE
1427 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1428
5235bd3e
PE
1429 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1430 Before, the code was not consistent. These values cannot exceed
1431 2**31 - 1 so there's no need to make them unsigned.
1432 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1433 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1434 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1435 as modifiers.
1436 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1437
bc827e23
PE
1438 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1439 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1440 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1441 presumably because the widths might not match.
1442
78eb494e
PE
1443 * window.c (size_window): Avoid needless test at loop start.
1444
04f2d78b
CB
14452011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1446
1447 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1448
d2fc7e3d 14492011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1450
1451 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1452
d2fc7e3d 14532011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1454
1455 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1456 `width' to `bar_area_x' and `bar_area_width', respectively.
1457 (x_scroll_run): Take account of fringe background extension.
1458
04f2d78b
CB
1459 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1460 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1461 `bar_area_width', respectively.
1462 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1463 background extension.
1464
79b70037
GM
14652011-05-10 Jim Meyering <meyering@redhat.com>
1466
1467 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1468
2f142cc5
JB
14692011-05-10 Juanma Barranquero <lekktu@gmail.com>
1470
1471 * image.c (Finit_image_library): Return t for built-in image types,
1472 like pbm and xbm. (Bug#8640)
1473
57679c86
AS
14742011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1475
1476 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1477
888c9e86
EZ
14782011-05-07 Eli Zaretskii <eliz@gnu.org>
1479
b0512a1d
EZ
1480 * w32console.c (Fset_screen_color): Doc fix.
1481 (Fget_screen_color): New function.
1482 (syms_of_ntterm): Defsubr it.
1483
7285dc67
EZ
1484 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1485 unlink the temporary file if Fcall_process didn't create it in the
1486 first place.
1487 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1488 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1489 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1490 cue to call_process_cleanup not to close that handle.
1491
4d3fcc8e
BK
14922011-05-07 Ben Key <bkey76@gmail.com>
1493
1494 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1495 one of two shell specific rules, either bootstrap-temacs-CMD or
1496 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1497 to the previous implementation of the bootstrap-temacs rule.
1498 The bootstrap-temacs-CMD rule is similar to the previous
1499 implementation of the bootstrap-temacs rule except that it
1500 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1501 variable.
1502
1503 These changes, along with some changes to nt/configure.bat,
1504 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1505 earlier fix to add support for --cflags and --ldflags options
1506 that include quotes so that it works whether make uses cmd or
1507 sh as the shell.
1508
b4289b64
MA
15092011-05-06 Michael Albinus <michael.albinus@gmx.de>
1510
1511 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1512 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1513 is a constant.
1514 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1515 a string. Handle both cases.
1516 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1517 (Fdbus_register_method): Use Qinvalid_function.
1518
af4c0e28
JB
15192011-05-06 Juanma Barranquero <lekktu@gmail.com>
1520
1521 * makefile.w32-in: Update dependencies.
1522 (LISP_H): Add inttypes.h and stdin.h.
1523 (PROCESS_H): Add unistd.h.
1524
c51453d9
EZ
15252011-05-06 Eli Zaretskii <eliz@gnu.org>
1526
1527 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1528 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1529
8ff0ac3c 15302011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1531
4c4b566b
PE
1532 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1533
aab2b9b5
PE
1534 * term.c (vfatal): Remove stray call to va_end.
1535 It's not needed and the C Standard doesn't allow it here anyway.
1536
c378da0b
PE
1537 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1538 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1539
288b08c7
PE
1540 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1541 bytes.
1542
e3601888
PE
1543 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1544
db6c0e74
PE
1545 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1546
dd5963ea
PE
1547 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1548
88c9450f
PE
1549 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1550
2f9442b8
PE
1551 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1552
c032b5f8
PE
1553 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1554 * charset.c (Fdefine_charset_internal): Don't initialize
1555 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1556 32-bit int (Bug#8600).
a108c10b
PE
1557
1558 * lread.c (read_integer): Be more consistent with string-to-number.
1559 Use string_to_number to do the actual conversion; this avoids
1560 rounding errors and fixes some other screwups. Without this fix,
1561 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1562 (digit_to_number): Move earlier, for benefit of read_integer.
1563 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1564 not a digit in any supported base. (Bug#8602)
a108c10b 1565
ad5f9eea
PE
1566 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1567
aec1708a
PE
1568 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1569 to match comment at start of function. This also removes a
1570 GCC warning about overflow in a 32+64-bit port.
1571
47be4ab5
PE
1572 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1573
371cac43
PE
1574 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1575 Reported by Stefan Monnier in
1576 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1577 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1578 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1579
d01a7826
PE
1580 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1581 (EMACS_UINTPTR): Likewise, with uintptr_t.
1582
7fd47d5c
PE
1583 * lisp.h: Prefer 64-bit EMACS_INT if available.
1584 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1585 on 32-bit hosts that have 64-bit int, so that they can access
1586 large files.
122b0c86
PE
1587 However, temporarily disable this change unless the temporary
1588 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1589
8727937b
PE
1590 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1591
8ac068ac
PE
1592 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1593 This removes an assumption that EMACS_INT and long are the same
1594 width as pointers. The assumption is true for Emacs porting targets
1595 now, but we want to make other targets possible.
1596 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1597 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1598 In the rest of the code, change types of integers that hold casted
1599 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1600 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1601 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1602 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1603 No need to cast type when ORing.
1604 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1605 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1606 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1607 assume EMACS_INT is the same width as char *.
1608 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1609 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1610 Remove no-longer-needed casts.
1611 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1612 (xg_tool_bar_help_callback, xg_make_tool_item):
1613 Use EMACS_INTPTR to hold an integer
1614 that will be cast to void *; this can avoid a GCC warning
1615 if EMACS_INT is not the same width as void *.
1616 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1617 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1618 (current_message_1, set_message_1):
1619 Use a local to convert to proper width without a cast.
1620 * xmenu.c (dialog_selection_callback): Likewise.
1621
ede49d71
PE
1622 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1623 Also, don't assume VALBITS / RAND_BITS is less than 5,
1624 and don't rely on undefined behavior when shifting a 1 left into
1625 the sign bit.
1626 * lisp.h (get_random): Change signature to match.
1627
2f30ecd0
PE
1628 * lread.c (hash_string): Use size_t, not int, for hash computation.
1629 Normally we prefer signed values; but hashing is special, because
1630 it's better to use unsigned division on hash table sizes so that
1631 the remainder is nonnegative. Also, size_t is the natural width
1632 for hashing into memory. The previous code used 'int', which doesn't
1633 retain enough info to hash well into very large tables.
1634 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1635
2a866e7b
PE
1636 * dbusbind.c: Don't possibly lose pointer info when converting.
1637 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1638 Use XPNTR rather than XHASH, so that the high-order bits of
1639 the pointer aren't lost when converting through void *.
1640
51639eac
PE
1641 * eval.c (Fautoload): Don't double-shift a pointer.
1642
92394119
PE
1643 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1644
dbdb9a7c
JB
16452011-05-06 Juanma Barranquero <lekktu@gmail.com>
1646
1647 * gnutls.c (DEF_GNUTLS_FN):
1648 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1649
db7a0b4f
AS
16502011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1651
1652 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1653 marker. (Bug#8610)
1654
f7ff1b0f 16552011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1656
1657 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1658 New version that can reserve upto 2GB of heap space.
1659
f7ff1b0f 16602011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1661
1662 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1663
639c109b
TZ
16642011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1665
1666 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1667 `gnutls_certificate_set_x509_key_file'.
1668
d2127135
JB
16692011-05-05 Juanma Barranquero <lekktu@gmail.com>
1670
1671 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1672 Update dependencies.
1673
e968f4f3
JB
16742011-05-04 Juanma Barranquero <lekktu@gmail.com>
1675
1676 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1677 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1678 Remove unused parameter `fildes'.
1679 * process.c (read_process_output, send_process): Don't pass it.
1680
84d358f0
JB
16812011-05-04 Juanma Barranquero <lekktu@gmail.com>
1682
1683 Fix previous change: the library cache is defined in w32.c.
1684 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1685 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1686
0898ca10
JB
16872011-05-04 Juanma Barranquero <lekktu@gmail.com>
1688
1689 Implement dynamic loading of GnuTLS on Windows.
1690
1691 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1692 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1693 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1694 Declare.
1695
1696 * gnutls.c (Qgnutls_dll): Define.
1697 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1698 (gnutls_*): Declare function pointers.
1699 (init_gnutls_functions): New function to initialize function pointers.
1700 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1701 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1702 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1703 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1704 (emacs_gnutls_write, emacs_gnutls_read)
1705 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1706 (Fgnutls_available_p): New function.
1707 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1708 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1709 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1710
1711 * image.c: Include w32.h.
1712 (Vimage_type_cache): Delete.
1713 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1714 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1715 (w32_delayed_load): Move to w32.c.
1716
1717 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1718
1719 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1720 (w32_delayed_load): Move from image.c. When loading a library, record
1721 its filename in the :loaded-from property of the library id.
1722 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1723 Initialize and staticpro them.
1724 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1725
1726 * process.c: Include lisp.h before w32.h, not after.
1727 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1728 instead of gnutls_record_check_pending.
1729
1730 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1731
ff4de4aa
TZ
17322011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1733
1734 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1735 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1736 as passed in.
1737
abe95abb
JD
17382011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1739
1740 * xterm.c (x_set_frame_alpha): Do not set property on anything
1741 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1742
e16e55d4
JB
17432011-05-02 Juanma Barranquero <lekktu@gmail.com>
1744
1745 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1746
bafcf6a5
JB
17472011-05-02 Juanma Barranquero <lekktu@gmail.com>
1748
1749 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1750 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1751 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1752 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1753 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1754 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1755 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1756 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1757 (Qgnutls_bootprop_callbacks_verify): Make static.
1758
e7a6747f
AS
17592011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1760
19ed11ba
AS
1761 * callproc.c: Indentation fixup.
1762
e7a6747f 1763 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1764 (wait_for_termination, interruptible_wait_for_termination):
1765 Move after wait_for_termination_1.
e7a6747f 1766
1ef14cb4
LMI
17672011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1768
1769 * sysdep.c (interruptible_wait_for_termination): New function
1770 which is like wait_for_termination, but allows keyboard
1771 interruptions.
1772
1773 * callproc.c (Fcall_process): Add (:file "file") as an option for
1774 the STDOUT buffer.
1775 (Fcall_process_region): Ditto.
1776
330d880c
EZ
17772011-04-30 Eli Zaretskii <eliz@gnu.org>
1778
8db90b73
EZ
1779 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1780 rather than `XVECTOR (FOO)->size'.
1781
330d880c
EZ
1782 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1783 inttypes.h, as a gnulib replacement is used if it not available in
1784 system headers.
1785
15cbd324
EZ
17862011-04-21 Eli Zaretskii <eliz@gnu.org>
1787
1788 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1789 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1790 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1791
1792 * coding.c (coding_alloc_by_realloc): Error out if destination
1793 will grow beyond MOST_POSITIVE_FIXNUM.
1794 (decode_coding_emacs_mule): Abort if there isn't enough place in
1795 charbuf for the composition carryover bytes. Reserve an extra
1796 space for up to 2 characters produced in a loop.
1797 (decode_coding_iso_2022): Abort if there isn't enough place in
1798 charbuf for the composition carryover bytes.
1799
18002011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1801
ae940cca
EZ
1802 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1803 aborting when %lld or %lll format is passed.
1804 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1805 %llo or %llx format is passed. (Bug#8545)
1806
03ab8921
EZ
1807 * window.c (window_scroll_line_based): Use a marker instead of
1808 simple variables to record original value of point. (Bug#7952)
1809
afda1437
EZ
1810 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1811 produced by %s or %c overflows available buffer space. (Bug#8545)
1812
f76dee0c
PE
18132011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1814
1815 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1816 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1817
fdc5744d
JB
18182011-04-28 Juanma Barranquero <lekktu@gmail.com>
1819
1820 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1821
638f053a
JB
18222011-04-28 Juanma Barranquero <lekktu@gmail.com>
1823
1824 * keyboard.c (Qdelayed_warnings_hook): Define.
1825 (command_loop_1): Run `delayed-warnings-hook'
1826 if Vdelayed_warnings_list is non-nil.
1827 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1828 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1829
d178f871
EZ
18302011-04-28 Eli Zaretskii <eliz@gnu.org>
1831
1832 * doprnt.c (doprnt): Don't return value smaller than the buffer
1833 size if the message was truncated. (Bug#8545).
1834
b124fd93
JB
18352011-04-28 Juanma Barranquero <lekktu@gmail.com>
1836
1837 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1838 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1839
e810457d
PE
18402011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1841
1842 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1843
ea51cceb
JB
18442011-04-27 Juanma Barranquero <lekktu@gmail.com>
1845
1846 * makefile.w32-in: Update dependencies.
1847
94dcfacf
EZ
18482011-04-27 Eli Zaretskii <eliz@gnu.org>
1849
1850 Improve `doprnt' and its usage. (Bug#8545)
1851 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1852 `format_end'. Remove support for %l as a conversion specifier.
1853 Don't use xrealloc. Improve diagnostics when the %l size modifier
1854 is used. Update the commentary.
1855
1856 * eval.c (verror): Simplify calculation of size_t.
1857
1858 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1859 messages.
1860
f61f41d7
PE
18612011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1862
1863 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1864 change.
1865
96fb4434
PE
18662011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1867
1868 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1869 This makes this file independent of the recent pseudovector change.
1870
671875da 18712011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1872
69e9b5a3
PE
1873 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1874
b5f869a7 1875 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1876 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1877 Remove unused local.
c8926152 1878 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1879
841a1577 1880 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1881 GCC 4.6.0 optimizes based on type-based alias analysis.
1882 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1883 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1884 != &v->size, and therefore "v->size = 1; b->size = 2; return
1885 v->size;" must therefore return 1. This assumption is incorrect
1886 for Emacs, since it type-puns struct Lisp_Vector * with many other
1887 types. To fix this problem, this patch adds a new type struct
f904488f 1888 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1889 and pseudovectors, and helps optimizing compilers not get fooled
1890 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1891 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1892 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1893 the size member.
eab3844f
PE
1894 (XSETPVECTYPE): Rewrite in terms of new macro.
1895 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1896 This is a bit clearer, and further avoids the possibility of
1897 undesirable aliasing.
1898 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1899 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1900 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1901 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1902 (ASIZE): Now uses header.size rather than size.
1903 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1904 to avoid the hassle of writing XVECTOR (foo)->header.size.
1905 (struct vectorlike_header): New type.
eab3844f
PE
1906 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1907 object, to help avoid aliasing.
1908 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1909 (SUBRP): Likewise, since Lisp_Subr is a special case.
1910 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1911 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1912 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1913 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1914 changed to be "header.size" and "header.next".
1915 * buffer.h (struct buffer): Likewise.
1916 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1917 * frame.h (struct frame): Likewise.
1918 * process.h (struct Lisp_Process): Likewise.
1919 * termhooks.h (struct terminal): Likewise.
1920 * window.c (struct save_window_data, struct saved_window): Likewise.
1921 * window.h (struct window): Likewise.
1922 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1923 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1924 * buffer.c (init_buffer_once): Likewise.
1925 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1926 special case.
1927 * process.c (Fformat_network_address): Use local var for size,
1928 for brevity.
1929
0df1eac5
PE
1930 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1931
847ab9d1 1932 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1933 * data.c (atof): Remove decl; no longer used or needed.
1934 (digit_to_number): Move to lread.c.
1935 (Fstring_to_number): Use new string_to_number function, to be
1936 consistent with how the Lisp reader treats infinities and NaNs.
1937 Do not assume that floating-point numbers represent EMACS_INT
1938 without losing information; this is not true on most 64-bit hosts.
1939 Avoid double-rounding errors, by insisting on integers when
1940 parsing non-base-10 numbers, as the documentation specifies.
1941 * lisp.h (string_to_number): New decl, replacing ...
1942 (isfloat_string): Remove.
bc0a5c13 1943 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1944 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1945 appears to have been a coding error. Similarly, do not accept
1946 strings like +-1e0 as floating point numbers. Do not report
1947 overflow for integer overflows unless the base is not 10 which
1948 means we have no simple and reliable way to continue.
1949 Break out the floating-point parsing into a new
1950 function string_to_number, so that Fstring_to_number parses
1951 floating point numbers consistently with the Lisp reader.
04f2d78b 1952 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1953 (E_CHAR, EXP_INT): Remove, replacing with ...
1954 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1955 (string_to_number): New function, replacing isfloat_string.
1956 This function checks for valid syntax and produces the resulting
1957 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1958 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1959 so that overflow for non-base-10 numbers is reported only when
1960 there's no portable and simple way to convert to floating point.
452f4150 1961
67769ffc
PE
1962 * textprop.c (set_text_properties_1): Rewrite for clarity,
1963 and to avoid GCC warning about integer overflow.
1964
c20db43f
PE
1965 * intervals.h (struct interval): Use EMACS_INT for members
1966 where EMACS_UINT might cause problems. See
1967 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1968 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1969 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1970 All uses changed.
37aa2f85
PE
1971 (offset_intervals): Tell GCC not to worry about length overflow
1972 when negating a negative length.
c20db43f 1973
2538aa2f
PE
1974 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1975 (overrun_check_free): Likewise.
1976
f2d3008d
PE
1977 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1978 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1979 word size.
1980
ec8df744
PE
1981 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1982 (gnutls_make_error): Rename local to avoid shadowing.
1983 (gnutls_emacs_global_deinit): ifdef out; not used.
1984 (Fgnutls_boot): Use const for pointer to readonly storage.
1985 Comment out unused local. Fix pointer signedness problems.
1986
640ee02d
PE
1987 * lread.c (openp): Don't stuff size_t into an 'int'.
1988 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1989 about possible signed overflow.
1990
6048fb2a
PE
1991 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1992 (GDK_KEY_g): Don't define if already defined.
1993 (xg_prepare_tooltip): Avoid pointer signedness problem.
1994 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1995
fa3c87e1
PE
1996 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1997 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1998
2172544b
PE
1999 * xfns.c (Fx_window_property): Simplify a bit,
2000 to make a bit faster and to avoid GCC 4.6.0 warning.
2001 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2002
9b821a21
PE
2003 * fns.c (internal_equal): Don't assume size_t fits in int.
2004
3c616cfa
PE
2005 * alloc.c (compact_small_strings): Tighten assertion a little.
2006
c2982e87
PE
2007 Replace pEd with more-general pI, and fix some printf arg casts.
2008 * lisp.h (pI): New macro, generalizing old pEd macro to other
2009 conversion specifiers. For example, use "...%"pI"d..." rather
2010 than "...%"pEd"...".
2011 (pEd): Remove. All uses replaced with similar uses of pI.
2012 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2013 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2014 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2015 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2016 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2017 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2018 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2019 64-bit hosts.
2020 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2021 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2022 * print.c (safe_debug_print, print_object): Likewise.
2023 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2024 to int.
6f04d126
PE
2025 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2026 avoiding the 0 flag, which is not portable.
c2982e87
PE
2027 * process.c (Fmake_network_process): Use pI to avoid cast.
2028 * region-cache.c (pp_cache): Likewise.
2029 * xdisp.c (decode_mode_spec): Likewise.
2030 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2031 behavior on 64-bit hosts with printf arg.
6f04d126 2032 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2033 (x_stop_queuing_selection_requests): Likewise.
2034 (x_get_window_property): Don't truncate byte count to an 'int'
2035 when tracing.
0b432f21 2036
5e073ec7
PE
2037 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2038 here, since it parses constructs like leading '-' and spaces,
2039 which are not wanted; and it overflows with large numbers.
2040 Instead, simply match F[0-9]+, which is what is wanted anyway.
2041
36372bf9
PE
2042 * alloc.c: Remove unportable assumptions about struct layout.
2043 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2044 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2045 (allocate_vectorlike, make_pure_vector): Use the new macros,
2046 plus offsetof, to remove unportable assumptions about struct layout.
2047 These assumptions hold on all porting targets that I know of, but
2048 they are not guaranteed, they're easy to remove, and removing them
2049 makes further changes easier.
2050
0b432f21
PE
2051 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2052 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2053 (string_overrun_cookie): Now const. Use initializers that
2054 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2055 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2056 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2057 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2058 multiple of sizeof (EMACS_INT); it need not be, if
2059 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2060 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2061
895009e1
JB
20622011-04-26 Juanma Barranquero <lekktu@gmail.com>
2063
2064 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2065
6a7a1b0b
TZ
20662011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2067
2068 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2069 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2070 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2071
841a1577 20722011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2073
2074 * lisp.h (Qdebug): List symbol.
895009e1 2075 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2076 * keyboard.c (debug-on-event): New variable.
2077 (handle_user_signal): Break into debugger when debug-on-event
2078 matches the current signal symbol.
2079
f2d3ba6f
DN
20802011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2081
2082 * alloc.c (check_sblock, check_string_bytes)
2083 (check_string_free_list): Convert to standard C.
2084
42ce4c63
TZ
20852011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2086
2087 * w32.c (emacs_gnutls_push): Fix typo.
2088
825cd63c
EZ
20892011-04-25 Eli Zaretskii <eliz@gnu.org>
2090
fb11d64d
EZ
2091 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2092 "cast to pointer from integer of different size".
2093
825cd63c
EZ
2094 Improve doprnt and its use in verror. (Bug#8545)
2095 * doprnt.c (doprnt): Document the set of format control sequences
2096 supported by the function. Use SAFE_ALLOCA instead of always
2097 using `alloca'.
2098
2099 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2100 is one byte too soon. Don't use xrealloc; instead xfree and
2101 xmalloc anew.
2102
e061a11b
TZ
21032011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2104
2105 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2106 callbacks stage.
2107
2108 * gnutls.c: Renamed global_initialized to
2109 gnutls_global_initialized. Added internals for the
2110 :verify-hostname-error, :verify-error, and :verify-flags
2111 parameters of `gnutls-boot' and documented those parameters in the
2112 docstring. Start callback support.
2113 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2114 unless a fatal error occured. Call gnutls_alert_send_appropriate
2115 on error. Return error code.
2116 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2117 (emacs_gnutls_read): Likewise.
2118 (Fgnutls_boot): Return handshake error code.
2119 (emacs_gnutls_handle_error): New function.
2120 (wsaerror_to_errno): Likewise.
2121
2122 * w32.h (emacs_gnutls_pull): Add prototype.
2123 (emacs_gnutls_push): Likewise.
2124
2125 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2126 (emacs_gnutls_push): Likewise.
2127
21282011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2129
2130 * process.c (wait_reading_process_output): Check if GnuTLS
2131 buffered some data internally if no FDs are set for TLS
2132 connections.
2133
2134 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2135 (LIBS): Link to USER_LIBS.
2136 ($(BLD)/gnutls.$(0)): New target.
2137
fa6996bc
EZ
21382011-04-24 Eli Zaretskii <eliz@gnu.org>
2139
eb35682e
EZ
2140 * xdisp.c (handle_single_display_spec): Rename the
2141 display_replaced_before_p argument into display_replaced_p, to
2142 make it consistent with the commentary. Fix typos in the
2143 commentary.
2144
e2ad650c
EZ
2145 * textprop.c (syms_of_textprop): Remove dead code.
2146 (copy_text_properties): Delete obsolete commentary about an
2147 interface that was deleted long ago. Fix typos in the description
2148 of arguments.
2149
1b2de274
EZ
2150 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2151 to changes in oldXMenu/XMenu.h from 2011-04-16.
2152 <menu_help_message, prev_menu_help_message>: Constify.
2153 (IT_menu_make_room): menu->help_text is now `const char **';
2154 adjust.
2155
2156 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2157 to changes in oldXMenu/XMenu.h from 2011-04-16.
2158 (struct XMenu): Declare `help_text' `const char **'.
2159
2160 * xfaces.c <Qunspecified>: Make extern again.
2161
2162 * syntax.c: Include sys/types.h before including regex.h, as
2163 required by Posix.
2164
762b15be
EZ
2165 * doc.c (get_doc_string): Improve the format passed to `error'.
2166
2167 * doprnt.c (doprnt): Improve commentary.
2168
2169 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2170
2171 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2172 them with etags.
2173
f1052e5d
EZ
2174 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2175 changes in globals.h immediately force recompilation.
762b15be
EZ
2176 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2177 $(CURDIR)/s/ms-w32.h.
2178 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2179
fa6996bc
EZ
2180 * character.c (Fchar_direction): Function deleted.
2181 (syms_of_character): Don't defsubr it.
2182 <char-direction-table>: Deleted.
2183
e6c3da20
EZ
21842011-04-23 Eli Zaretskii <eliz@gnu.org>
2185
2186 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2187 * doprnt.c: Include limits.h.
2188 (SIZE_MAX): New macro.
04f2d78b
CB
2189 (doprnt): Return a size_t value. 2nd arg is now size_t.
2190 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2191 Improve overflow protection. Support `l' modifier for integer
2192 conversions. Support %l conversion. Don't assume an EMACS_INT
2193 argument for integer conversions and for %c.
2194
2195 * lisp.h (doprnt): Restore prototype.
2196
2197 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2198 $(SRC)/character.h.
2199
2200 * Makefile.in (base_obj): Add back doprnt.o.
2201
2202 * deps.mk (doprnt.o): Add back prerequisites.
2203 (callint.o): Depend on character.h.
2204
2205 * eval.c (internal_lisp_condition_case): Include the handler
2206 representation in the error message.
2207 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2208 when breaking from the loop.
2209
2210 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2211
2212 * callint.c (Fcall_interactively): When displaying error message
2213 about invalid control letter, pass the character's codepoint, not
2214 a pointer to its multibyte form. Improve display of the character
2215 in octal and display also its hex code.
2216
2217 * character.c (char_string): Use %x to display the (unsigned)
2218 codepoint of an invalid character, to avoid displaying a bogus
2219 negative value.
2220
2221 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2222 `error', not SYMBOL_NAME itself.
2223
2224 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2225 character arguments to `error'.
2226
2227 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2228 to `error' in error message about FINAL_CHAR argument. Make sure
2229 FINAL_CHAR is a character, and use %c when it is passed as
2230 argument to `error'.
2231
4ffd0d6b 22322011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2233
2234 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2235
2236 * w32.c: Include <time.h>.
2237 (sys_localtime): New function.
2238
4ffd0d6b 22392011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2240
2241 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2242
4ffd0d6b 2243 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2244
4ffd0d6b 22452011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2246
4ffd0d6b
GM
2247 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2248 zombies (Bug#8467).
aac0c6e3 2249
04c56954
EZ
22502011-04-19 Eli Zaretskii <eliz@gnu.org>
2251
2252 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2253 gl_state.e_property when gl_state.object is Qt.
2254
2255 * insdel.c (make_gap_larger): Remove limitation of buffer size
2256 to <= INT_MAX.
2257
16a43933
CY
22582011-04-18 Chong Yidong <cyd@stupidchicken.com>
2259
2260 * xdisp.c (lookup_glyphless_char_display)
2261 (produce_glyphless_glyph): Handle cons cell entry in
2262 glyphless-char-display.
2263 (Vglyphless_char_display): Document it.
2264
2265 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2266 glyphless-char-display.
2267
4581706e
CY
22682011-04-17 Chong Yidong <cyd@stupidchicken.com>
2269
2270 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2271
2272 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2273
2274 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2275 definition for no-X builds.
2276
4887c6e2 22772011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2278
fd35b6f9
PE
2279 Static checks with GCC 4.6.0 and non-default toolkits.
2280
5c1ccb01
PE
2281 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2282
006c5daa
PE
2283 * process.c (keyboard_bit_set): Define only if SIGIO.
2284 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2285 (send_process): Repair possible setjmp clobbering.
2286
efc736d3
PE
2287 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2288
4e2fe2e6
PE
2289 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2290
f97334a2
PE
2291 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2292
4e75f29d
PE
2293 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2294 Define only if needed.
2295
90efadd1
PE
2296 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2297 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2298 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2299
3c647824
PE
2300 * dispextern.h (struct redisplay_interface): Rename param
2301 to avoid shadowing.
e264f262 2302 * termhooks.h (struct terminal): Likewise.
761383f4 2303 * xterm.c (xembed_send_message): Likewise.
3c647824 2304
b58c5c4a
PE
2305 * insdel.c (make_gap_smaller): Define only if
2306 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2307
cad59032
PE
2308 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2309 it.
2310
c339dc2e
PE
2311 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2312 so that we aren't warned about unused symbols.
2313
91a3e27b
PE
2314 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2315
399c71d3 2316 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2317
8ffc96f5
PE
2318 * xfns.c (x_real_positions): Mark locals as initialized.
2319
eef9bc79
PE
2320 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2321
098db9dd
PE
2322 * xterm.c: Fix problems found by static analysis with other toolkits.
2323 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2324 (x_dispatch_event): Declare static if USE_GTK, and
2325 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2326 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2327 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2328 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2329 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2330
eb18f6cc
PE
2331 * xmenu.c (menu_help_callback): Pointer type fixes.
2332 Use const pointers when pointing at readonly data. Avoid pointer
2333 signedness clashes.
2334 (FALSE): Remove unused macro.
2335 (update_frame_menubar): Remove unused decl.
2336
1fe72bf8
PE
2337 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2338
60d9e1db
PE
2339 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2340 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2341 (single_menu_item): Rename local to avoid shadowing.
2342
39261c26
PE
2343 * keyboard.c (make_lispy_event): Remove unused local var.
2344
018c5e19
PE
2345 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2346 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2347
63d2b86e
PE
2348 * bitmaps: Change bitmaps from unsigned char back to the X11
2349 compatible char. Avoid the old compiler warnings about
2350 out-of-range initializers by using, for example, '\xab' rather
2351 than 0xab.
2352
aefd87e1
PE
2353 * xgselect.c (xgselect_initialize): Check vs interface
2354 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2355
bf501fb9
PE
2356 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2357
e9829fdf
PE
2358 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2359 to read-only memory.
2360
1086c095
PE
2361 * fns.c (vector): Remove; this old hack is no longer needed.
2362
2baccd04 2363 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2364 Remove unused var.
dde42981 2365 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2366
72391843 2367 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2368
436c16df 2369 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2370 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2371 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2372
92bb796d 2373 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2374 (x_term_init): Remove local to avoid shadowing.
92bb796d 2375
764430a3 2376 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2377
2378 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2379 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2380
d1dfb56c
EZ
23812011-04-16 Eli Zaretskii <eliz@gnu.org>
2382
c4354cb4
EZ
2383 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2384
d1dfb56c
EZ
2385 Fix regex.c, syntax.c and friends for buffers > 2GB.
2386 * syntax.h (struct gl_state_s): Declare character position members
2387 EMACS_INT.
2388
2389 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2390
04f2d78b
CB
2391 * textprop.c (verify_interval_modification, interval_of):
2392 Declare arguments EMACS_INT.
d1dfb56c
EZ
2393
2394 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2395 EMACS_INT.
2396
2397 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2398
2399 * indent.c (Fvertical_motion): Local variable it_start is now
2400 EMACS_INT.
2401
2402 * regex.c (re_match, re_match_2, re_match_2_internal)
2403 (bcmp_translate, regcomp, regexec, print_double_string)
2404 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2405 (re_compile_pattern, re_exec): Declare arguments and local
2406 variables `size_t' and `ssize_t' and return values `regoff_t', as
2407 appropriate.
2408 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2409 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2410 <compile_stack_type>: `size' and `avail' are now `size_t'.
2411
2412 * regex.h <regoff_t>: Use ssize_t, not int.
2413 (re_search, re_search_2, re_match, re_match_2): Arguments that
2414 specify buffer/string position and length are now ssize_t and
2415 size_t. Return type is regoff_t.
2416
613052cd
BK
24172011-04-16 Ben Key <bkey76@gmail.com>
2418
2419 * nsfont.m: Fixed bugs in ns_get_family and
2420 ns_descriptor_to_entity that were caused by using free to
2421 deallocate memory blocks that were allocated by xmalloc (via
2422 xstrdup). This caused Emacs to crash when compiled with
2423 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2424 --enable-checking=xmallocoverrun). xfree is now used to
2425 deallocate these memory blocks.
2426
4170f62f 24272011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2428
71b41406
PE
2429 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2430
9587a89d
PE
2431 emacs_write: Accept and return EMACS_INT for sizes.
2432 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2433 et seq.
2434 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2435 Accept and return EMACS_INT.
2436 (emacs_gnutls_write): Return the number of bytes written on
2437 partial writes.
2438 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2439 (emacs_read, emacs_write): Remove check for negative size, as the
2440 Emacs source code has been audited now.
9587a89d
PE
2441 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2442 (emacs_read, emacs_write): Use it.
273a5f82
PE
2443 * process.c (send_process): Adjust to the new signatures of
2444 emacs_write and emacs_gnutls_write. Do not attempt to store
2445 a byte offset into an 'int'; it might overflow.
9587a89d 2446 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2447
3e047f51
PE
2448 * sound.c: Don't assume sizes fit in 'int'.
2449 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2450 Return EMACS_INT, not int.
3e047f51 2451 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2452 Accept EMACS_INT, not int.
2453 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2454 record read return values.
2455
cc39a9db
BK
24562011-04-15 Ben Key <bkey76@gmail.com>
2457
c9d0ec6d
JB
2458 * keyboard.c (Qundefined): Don't declare static since it is used
2459 in nsfns.m.
2460 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2461 static since they are used in nsfont.m.
cc39a9db 2462
6c60eb9f
SM
24632011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2464
2465 * process.c (Qprocessp): Don't declare static.
2466 * lisp.h (Qprocessp): Declare again.
2467
7990b61a
JB
24682011-04-15 Juanma Barranquero <lekktu@gmail.com>
2469
2470 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2471
5d4cb038
PE
24722011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2473
8bd7b830 2474 Improve C-level modularity by making more things 'static'.
cd64ea1d 2475
e3b27b31
PE
2476 Don't publish debugger-only interfaces to other modules.
2477 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2478 (verify_bytepos, count_markers): Move decls to the only modules
2479 that need them.
2480 * region-cache.h (pp_cache): Likewise.
2481 * window.h (check_all_windows): Likewise.
2482 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2483
5d4cb038
PE
2484 * sysdep.c (croak): Now static, if
2485 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2486 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2487
2488 * alloc.c (refill_memory_reserve): Now static if
2489 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2490 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2491
e87b6180
PE
2492 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2493 Define only if USE_LUCID.
2494
ac64929e
PE
2495 * xrdb.c (x_customization_string, x_rm_string): Now static.
2496
6f37259d
PE
2497 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2498 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2499
1683e3ab
PE
2500 * xdisp.c (draw_row_with_mouse_face): Now static.
2501 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2502
de9c2632
PE
2503 * window.h (check_all_windows): Mark externally visible.
2504
2b96acb7
PE
2505 * window.c (window_deletion_count): Now static.
2506
2507 * undo.c: Make symbols static if they're not exported.
2508 (last_undo_buffer, last_boundary_position, pending_boundary):
2509 Now static.
2510
50436f33
PE
2511 * textprop.c (interval_insert_behind_hooks): Now static.
2512 (interval_insert_in_front_hooks): Likewise.
2513
64520e5c
PE
2514 * term.c: Make symbols static if they're not exported.
2515 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2516 (max_frame_lines, tty_set_terminal_modes):
2517 (tty_reset_terminal_modes, tty_turn_off_highlight):
2518 (get_tty_terminal): Now static.
2519 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2520 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2521 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2522 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2523 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2524
1fa53021
PE
2525 * sysdep.c: Make symbols static if they're not exported.
2526 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2527 Now static.
2528 (sigprocmask_set, full_mask): Remove; unused.
2529 (wait_debugging): Mark as visible.
2530 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2531 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2532
d4b43b22
PE
2533 * syntax.c (syntax_temp): Define only if !__GNUC__.
2534
b7c513d0
PE
2535 * sound.c (current_sound_device, current_sound): Now static.
2536
989b29ad
PE
2537 * search.c (searchbufs, searchbuf_head): Now static.
2538
13a55a78
PE
2539 * scroll.c (scroll_cost): Remove; unused.
2540 * dispextern.h (scroll_cost): Remove decl.
2541
de68a1fc
PE
2542 * region-cache.h (pp_cache): Mark as externally visible.
2543
40ccffa6
PE
2544 * process.c: Make symbols static if they're not exported.
2545 (process_tick, update_tick, create_process, chan_process):
2546 (Vprocess_alist, proc_buffered_char, datagram_access):
2547 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2548 (deactivate_process): Mark defn as static, as well as decl.
2549 * lisp.h (create_process): Remove decl.
2550 * process.h (chan_process, Vprocess_alist): Remove decls.
2551
ad64fc97
PE
2552 * print.c: Make symbols static if they're not exported.
2553 (print_depth, new_backquote_output, being_printed, print_buffer):
2554 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2555 (print_interval, print_number_index, initial_stderr_stream):
2556 Now static.
2557 * lisp.h (Fprinc): Remove decl.
2558 (debug_output_compilation_hack): Mark as externally visible.
2559
adddb265
PE
2560 * sysdep.c (croak): Move decl from here to syssignal.h.
2561 * syssignal.h (croak): Put it here, so the API can be checked when
2562 'croak' is called from dissociate_if_controlling_tty.
2563
1717ede2
PE
2564 * minibuf.c: Make symbols static if they're not exported.
2565 (minibuf_save_list, choose_minibuf_frame): Now static.
2566 * lisp.h (choose_minibuf_frame): Remove decl.
2567
fa5fb2bc
PE
2568 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2569
1e3890d1
PE
2570 * lread.c: Make symbols static if they're not exported.
2571 (read_objects, initial_obarray, oblookup_last_bucket_number):
2572 Now static.
2573 (make_symbol): Remove; unused.
2574 * lisp.h (initial_obarray, make_symbol): Remove decls.
2575
8a1414fa
PE
2576 * keyboard.c: Make symbols static if they're not exported.
2577 (single_kboard, recent_keys_index, total_keys, recent_keys):
2578 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2579 (this_single_command_key_start, echoing, last_auto_save):
2580 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2581 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2582 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2583 (Vlispy_mouse_stem, double_click_count):
2584 Now static.
2585 (force_auto_save_soon): Define only if SIGDANGER.
2586 (ignore_mouse_drag_p): Now static if
2587 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2588 (print_help): Remove; unused.
2589 (stop_character, last_timer_event): Mark as externally visible.
2590 * keyboard.h (ignore_mouse_drag_p): Declare only if
2591 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2592 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2593 * lisp.h (echoing): Remove decl.
2594 (force_auto_save_soon): Declare only if SIGDANGER.
2595 * xdisp.c (redisplay_window): Simplify code, to make it more
2596 obvious that ignore_mouse_drag_p is not accessed if !defined
2597 USE_GTK && !defined HAVE_NS.
2598
93ea6e8f
PE
2599 * intervals.c: Make symbols static if they're not exported.
2600 (merge_properties_sticky, merge_interval_right, delete_interval):
2601 Now static.
2602 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2603
77382fcc
PE
2604 * insdel.c: Make symbols static if they're not exported.
2605 However, leave prepare_to_modify_buffer alone. It's never
2606 called from outside this function, but that appears to be a bug.
2607 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2608 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2609 (adjust_after_replace_noundo): Remove; unused.
2610 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2611 (signal_before_change): Remove decls.
77382fcc 2612
9306c32e
PE
2613 * indent.c (val_compute_motion, val_vmotion): Now static.
2614
cd44d2eb
PE
2615 * image.c: Make symbols static if they're not exported.
2616 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2617 if USE_GTK.
2618 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2619 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2620
ad9a7a06
PE
2621 * fringe.c (standard_bitmaps): Now static.
2622 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2623
81626931
PE
2624 * frame.c: Make symbols static if they're not exported.
2625 (x_report_frame_params, make_terminal_frame): Now static.
2626 (get_frame_param): Now static, unless HAVE_NS.
2627 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2628 (x_get_resource_string): Remove; not used.
2629 * frame.h (make_terminal_frame, x_report_frame_params):
2630 (x_get_resource_string); Remove decls.
2631 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2632 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2633
239f9db9
PE
2634 * font.c, fontset.c: Make symbols static if they're not exported.
2635 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2636 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2637 * font.c (font_close_object): Now static.
2638 * font.h (font_close_object): Remove.
2639 * fontset.c (FONTSET_OBJLIST): Remove.
2640 (free_realized_fontset) #if-0 the body, which does nothing.
2641 (face_suitable_for_char_p): #if-0, as it's never called.
2642 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2643 * xfaces.c (face_at_string_position):
2644 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2645 since 0 is always ASCII.
2646
dfcf3579
PE
2647 * fns.c (weak_hash_tables): Now static.
2648
5045092b
PE
2649 * fileio.c: Make symbols static if they're not exported.
2650 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2651 (Vwrite_region_annotation_buffers): Now static.
2652
57a96f5c
PE
2653 * eval.c: Make symbols static if they're not exported.
2654 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2655 * lisp.h (backtrace_list): Remove decl.
2656
35f08c38
PE
2657 * emacs.c: Make symbols static if they're not exported.
2658 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2659 (fatal_error_code, fatal_error_signal_hook, standard_args):
2660 Now static.
2661 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2662 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2663 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2664 * lisp.h (fatal_error_signal_hook): Remove decl.
2665 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2666
f44bd759
PE
2667 * editfns.c: Move a (normally-unused) function to its only use.
2668 * editfns.c, lisp.h (get_operating_system_release): Remove.
2669 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2670 worth the hassle of breaking this out.
2671
b532497d
PE
2672 * xterm.c: Make symbols static if they're not exported.
2673 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2674 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2675 (x_destroy_window, x_delete_display):
2676 Now static.
2677 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2678 (x_mouse_leave): Remove; unused.
2679 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2680 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2681 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2682 Remove decls.
2683 (x_mouse_leave): Declare only if WINDOWSNT.
2684 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2685 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2686 USE_X_TOOLKIT.
2687
1675728f
PE
2688 * ftxfont.c: Make symbols static if they're not exported.
2689 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2690 HAVE_FREETYPE.
2691 * font.h (ftxfont_driver): Likewise.
2692
e4cebfca
PE
2693 * xfns.c: Make symbols static if they're not exported.
2694 (x_last_font_name, x_display_info_for_name):
2695 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2696 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2697 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2698 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2699 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2700 (last_show_tip_args): Now static.
2701 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2702 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2703 (x_screen_planes): Remove; unused.
2704 * dispextern.h (x_screen_planes): Remove decl.
2705
5bf46f05
PE
2706 * dispnew.c: Make symbols static if they're not exported.
2707 * dispextern.h (redraw_garbaged_frames, scrolling):
2708 (increment_row_positions): Remove.
2709 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2710 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2711 Now static.
2712 (redraw_garbaged_frames): Remove; unused.
2713
435f4c28
PE
2714 * xfaces.c: Make symbols static if they're not exported.
2715 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2716 Remove decls.
2717 * xterm.h (defined_color): Remove decls.
2718 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2719 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2720 (menu_face_changed_default, defined_color, free_realized_face):
2721 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2722 (ascii_face_of_lisp_face): Remove; unused.
2723
8524aef3
PE
2724 * xdisp.c: Make symbols static if they're not exported.
2725 * dispextern.h (scratch_glyph_row, window_box_edges):
2726 (glyph_to_pixel_coords, set_cursor_from_row):
2727 (get_next_display_element, set_iterator_to_next):
2728 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2729 (show_mouse_face): Remove decls
2730 * frame.h (message_buf_print): Likewise.
2731 * lisp.h (pop_message, set_message, check_point_in_composition):
2732 Likewise.
2733 * xterm.h (set_vertical_scroll_bar): Likewise.
2734 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2735 (message_buf_print, scratch_glyph_row, displayed_buffer):
2736 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2737 (get_next_display_element, show_mouse_face, window_box_edges):
2738 (frame_to_window_pixel_xy, check_point_in_composition):
2739 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2740 (glyph_to_pixel_coords): Remove; unused.
2741
16390cd2
PE
2742 * dired.c (file_name_completion): Now static.
2743
2744 * dbusbind.c (xd_in_read_queued_messages): Now static.
2745
a25f4dfa
PE
2746 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2747 * data.c (circular_list_error): Remove.
2748
14a9c8df
PE
2749 * commands.h (last_point_position, last_point_position_buffer):
2750 (last_point_position_window): Remove decls.
2751 * keyboard.c: Make these variables static.
2752
04f2d78b
CB
2753 * coding.h (coding, code_convert_region, encode_coding_gap):
2754 Remove decls.
74ab6df5
PE
2755 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2756 (iso_code_class, detect_coding, code_convert_region): Now static.
2757 (encode_coding_gap): Remove; unused.
2758
38dfbee1
PE
2759 * chartab.c (chartab_chars, chartab_bits): Now static.
2760
a2cb4e63
PE
2761 * charset.h (charset_iso_8859_1): Remove decl.
2762 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2763 Now static.
2764
127198fd
PE
2765 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2766 * ccl.c (Vccl_program_table): Now static.
2767 (check_ccl_update): Remove; unused.
2768
d85b608f
PE
2769 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2770 * category.h: ... from here.
2771 * category.c (check_category_table, set_category_set): Now static.
2772
31cd66f3
PE
2773 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2774 * lisp.h: Remove these decls.
2775
c358e587
PE
2776 * buffer.c (buffer_count): Remove unused var.
2777
e78aecca
PE
2778 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2779 so that it's not optimized away.
2780 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2781 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2782 exported only to the debugger.
2783
e192d7d3 2784 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2785 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2786
92470028
PE
2787 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2788 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2789 was inaccessible from Lisp.
2790 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2791 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2792
244ed907
PE
2793 alloc.c: Import and export fewer symbols, and remove unused items.
2794 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2795 is defined.
2796 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2797 it's not optimized away by whole-program optimization.
2798 (message_enable_multibyte, free_misc): Remove.
2799 (catchlist, handlerlist, mark_backtrace):
2800 Declare only if BYTE_MARK_STACK.
2801 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2802 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2803 (message_enable_multibyte): Remove decl.
2804 (free_misc, interval_free_list, float_block, float_block_index):
2805 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2806 (cons_free_list, last_marked_index):
2807 Now static.
2808 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2809 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2810 (mark_backtrace): Define only if BYTE_MARK_STACK.
2811 * xdisp.c (message_enable_multibyte): Now static.
2812
61c2b50e 2813 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2814 This makes it easier for human readers (and static analyzers)
2815 to see whether these variables are used from other modules.
2816 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2817 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2818 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2819 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2820 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2821 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2822 * xmenu.c, xselect.c:
2823 Declare Q* vars static if they are not used in other modules.
2824 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2825 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2826 Remove decls of unexported vars.
2827 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2828
95c82688
PE
2829 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2830
16a97296
PE
2831 Make Emacs functions such as Fatom 'static' by default.
2832 This makes it easier for human readers (and static analyzers)
2833 to see whether these functions can be called from other modules.
2834 DEFUN now defines a static function. To make the function external
2835 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2836 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2837 (Finit_image_library):
16a97296
PE
2838 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2839 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2840 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2841 Remove decls, since these functions are now static.
2842 (Funintern, Fget_internal_run_time): New decls, since these functions
2843 were already external.
95c82688 2844
16a97296
PE
2845 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2846 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2847 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2848 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2849 * keyboard.c, keymap.c, lread.c:
2850 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2851 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2852 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2853 Mark functions with DEFUE instead of DEFUN,
2854 if they are used in other modules.
2855 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2856 decls for now-static functions.
2857 * buffer.h (Fdelete_overlay): Remove decl.
2858 * callproc.c (Fgetenv_internal): Mark as internal.
2859 * composite.c (Fremove_list_of_text_properties): Remove decl.
2860 (Fcomposition_get_gstring): New forward static decl.
2861 * composite.h (Fcomposite_get_gstring): Remove decl.
2862 * dired.c (Ffile_attributes): New forward static decl.
2863 * doc.c (Fdocumntation_property): New forward static decl.
2864 * eval.c (Ffetch_bytecode): New forward static decl.
2865 (Funintern): Remove extern decl; now in .h file where it belongs.
2866 * fileio.c (Fmake_symbolic_link): New forward static decl.
2867 * image.c (Finit_image_library): New forward static decl.
2868 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2869 * intervals.h (Fprevious_property_change):
2870 (Fremove_list_of_text_properties): Remove decls.
2871 * keyboard.c (Fthis_command_keys): Remove decl.
2872 (Fcommand_execute): New forward static decl.
2873 * keymap.c (Flookup_key): New forward static decl.
2874 (Fcopy_keymap): Now static.
2875 * keymap.h (Flookup_key): Remove decl.
2876 * process.c (Fget_process): New forward static decl.
2877 (Fprocess_datagram_address): Mark as internal.
2878 * syntax.c (Fsyntax_table_p): New forward static decl.
2879 (skip_chars): Remove duplicate decl.
2880 * textprop.c (Fprevious_property_change): New forward static decl.
2881 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2882 Now internal.
2883 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2884 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2885
785bbd42
PE
2886 * editfns.c (Fformat): Remove unreachable code.
2887
8b913b57
AS
28882011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2889
2890 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2891 change. (Bug#8496)
2892
a6744a35
EZ
28932011-04-13 Eli Zaretskii <eliz@gnu.org>
2894
2895 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2896 when at ZV. (Bug#8487)
2897
e7974947
AS
28982011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2899
baad03f0
AS
2900 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2901 (Bug#8437)
2902 * keyboard.c (parse_tool_bar_item): Likewise.
2903 * sound.c (sound_cleanup, alsa_close): Likewise.
2904 * termcap.c (tgetent): Likewise.
2905 * xfns.c (x_default_font_parameter): Likewise.
2906 * xsettings.c (read_and_apply_settings): Likewise.
2907
e7974947
AS
2908 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2909 (overrun_check_free): Protoize.
2910
28272684
PE
29112011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2912
2913 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2914 since callers should never pass a negative size.
2915 Change the signature to match that of plain 'read' and 'write'; see
2916 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2917 * lisp.h: Update prototypes of emacs_write and emacs_read.
2918
11997c76
EZ
29192011-04-11 Eli Zaretskii <eliz@gnu.org>
2920
2921 * xdisp.c (redisplay_window): Don't try to determine the character
2922 position of the scroll margin if the window start point w->startp
e896f03c 2923 is outside the buffer's accessible region. (Bug#8468)
11997c76 2924
8a2cbd72
EZ
29252011-04-10 Eli Zaretskii <eliz@gnu.org>
2926
2927 Fix write-region and its subroutines for buffers > 2GB.
2928 * fileio.c (a_write, e_write): Modify declaration of arguments and
2929 local variables to support buffers larger than 2GB.
2930 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2931
2932 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2933 argument, local variables, and return value.
2934
2935 * lisp.h: Update prototypes of emacs_write and emacs_read.
2936
2937 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2938
4073e537 29392011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2940
1ebfdcb6
PE
2941 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2942
b2ded58d
PE
2943 Fix more problems found by GCC 4.6.0's static checks.
2944
7d66342c
PE
2945 * xdisp.c (vmessage): Use a better test for character truncation.
2946
bbf47d44
PE
2947 * charset.c (load_charset_map): <, not <=, for optimization,
2948 and to avoid potential problems with integer overflow.
9248994d 2949 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2950 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2951 * editfns.c (Fformat): Likewise.
1e69125e 2952 * syntax.c (skip_chars): Likewise.
3befa583 2953
e3019616
PE
2954 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2955 This also lets GCC 4.6.0 generate slightly better loop code.
2956
becfa255
PE
2957 * callint.c (Fcall_interactively): <, not <=, for optimization.
2958 (Fcall_interactively): Count the number of arguments produced,
2959 not the number of arguments given. This is simpler and lets GCC
2960 4.6.0 generate slightly better code.
2961
dae0cd48
PE
2962 * ftfont.c: Distingish more carefully between FcChar8 and char.
2963 The previous code passed unsigned char * to a functions like
2964 strlen and xstrcasecmp that expect char *, which does not
2965 conform to the C standard.
2966 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2967 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2968 char * when the C standard requires it.
2969
76032d70
PE
2970 * keyboard.c (read_char): Remove unused var.
2971
eb3f1cc8
PE
2972 * eval.c: Port to Windows vsnprintf (Bug#8435).
2973 Include <limits.h>.
2974 (SIZE_MAX): Define if the headers do not.
2975 (verror): Do not give up if vsnprintf returns a negative count.
2976 Instead, grow the buffer. This ports to Windows vsnprintf, which
2977 does not conform to C99. Problem reported by Eli Zaretskii.
2978 Also, simplify the allocation scheme, by avoiding the need for
2979 calling realloc, and removing the ALLOCATED variable.
2980
70476b54
PE
2981 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2982
12020a9e
PE
2983 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2984 But keep the doprint source code for now, as we might revamp it
2985 and use it again (Bug#8435).
ea6c7ae6
PE
2986 * lisp.h (doprnt): Remove.
2987 * Makefile.in (base_obj): Remove doprnt.o.
2988 * deps.mk (doprnt.o): Remove.
2989
5fdb398c
PE
2990 error: Print 32- and 64-bit integers portably (Bug#8435).
2991 Without this change, on typical 64-bit hosts error ("...%d...", N)
2992 was used to print both 32- and 64-bit integers N, which relied on
2993 undefined behavior.
2994 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2995 New macro.
2996 * lisp.h (error, verror): Mark as printf-like functions.
2997 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2998 Report overflow in size calculations when allocating printf buffer.
2999 Do not truncate output string at its first null byte.
3000 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3001 Truncate the output at a character boundary, since vsnprintf does not
3002 do that.
3003 * charset.c (check_iso_charset_parameter): Convert internal
3004 character to string before calling 'error', since %c now has the
3005 printf meaning.
3006 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3007 overflow when computing char to be passed to 'error'. Do not
3008 pass Lisp_Object to 'error'; pass the integer instead.
3009 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3010 formatted with plain %d.
3011
b189fa66
PE
3012 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3013
bff87ef0
PE
3014 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3015
7e2cac20
PE
3016 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3017
ce4d90b5
PE
3018 * xterm.c (x_catch_errors): Remove duplicate declaration.
3019
266c9547
PE
3020 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3021
79c49ad2
PE
3022 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3023
368f4090
JM
30242011-04-10 Jim Meyering <meyering@redhat.com>
3025
3026 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3027 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3028 return ssize_t not "int", and use size_t as the buffer length.
3029 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3030 * gnutls.h: Update declarations.
3031 * process.c (read_process_output): Use ssize_t, to match.
3032 (send_process): Likewise.
3033
a32d4040
CY
30342011-04-09 Chong Yidong <cyd@stupidchicken.com>
3035
3036 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3037
8546720e 30382011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3039
04f2d78b
CB
3040 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3041 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3042
8546720e
GM
3043 * xterm.c (handle_one_xevent):
3044 * xmenu.c (create_and_show_popup_menu):
3045 * xselect.c (x_decline_selection_request)
3046 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3047
0a2f5c1a 30482011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3049
3050 Fix some uses of `int' instead of EMACS_INT.
3051 * search.c (string_match_1, fast_string_match)
3052 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3053 (scan_buffer, find_next_newline_no_quit)
3054 (find_before_next_newline, search_command, Freplace_match)
3055 (Fmatch_data): Make some `int' variables be EMACS_INT.
3056
3057 * xdisp.c (display_count_lines): 3rd argument and return value now
3058 EMACS_INT. All callers changed.
3059 (pint2hrstr): Last argument is now EMACS_INT.
3060
3061 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3062 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3063 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3064 (decode_coding_utf_16, decode_coding_emacs_mule)
3065 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3066 (decode_coding_ccl, decode_coding_charset)
3067 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3068 (decode_coding_iso_2022, decode_coding_emacs_mule)
3069 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3070 <char_offset, last_offset>: Declare EMACS_INT.
3071 (encode_coding_utf_8, encode_coding_utf_16)
3072 (encode_coding_emacs_mule, encode_invocation_designation)
3073 (encode_designation_at_bol, encode_coding_iso_2022)
3074 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3075 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3076 Declare EMACS_INT.
3077 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3078 (encode_invocation_designation): Last argument P_NCHARS is now
3079 EMACS_INT.
3080 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3081 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3082
3083 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3084 All users changed.
3085
3086 * ccl.c (Fccl_execute_on_string): Declare some variables
3087 EMACS_INT.
3088
8546720e 30892011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3090
3091 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3092
4e19a977
CS
30932011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3094
3095 * process.c (Fformat_network_address): Doc fix.
3096
87302331
R
30972011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3098
3099 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3100
cbb59342
CY
31012011-04-08 Chong Yidong <cyd@stupidchicken.com>
3102
3103 * keyboard.c (read_char): Call Lisp function help-form-show,
3104 instead of using internal_with_output_to_temp_buffer.
3105 (Qhelp_form_show): New var.
e0d38eeb 3106 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3107
3108 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3109
3110 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3111
e67a13ab
CY
31122011-04-06 Chong Yidong <cyd@stupidchicken.com>
3113
04f2d78b
CB
3114 * process.c (Flist_processes): Remove to Lisp.
3115 (list_processes_1): Delete.
e67a13ab 3116
973f782d
EZ
31172011-04-06 Eli Zaretskii <eliz@gnu.org>
3118
7c106b1e
EZ
3119 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3120
973f782d
EZ
3121 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3122
41cf7d1a 31232011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3124
ca23cc88
PE
3125 Fix more problems found by GCC 4.6.0's static checks.
3126
f390e2d5
PE
3127 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3128
42eea0d0
PE
3129 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3130
b69769da 3131 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3132
f9541e84
PE
3133 * xdisp.c (vmessage): Mark as a printf-like function.
3134
13841b55
PE
3135 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3136
c136c10f
PE
3137 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3138
5e2d4a30
PE
3139 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3140 printf-like functions.
3141 (tiff_load): Add casts to remove these marks before passing them
3142 to system-supplied API.
3143
583f48b9
PE
3144 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3145
b25d760e
PE
3146 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3147 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3148 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3149 directly, rather than having caller test rule sign. This avoids
3150 some unnecessary tests.
3151 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3152 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3153 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3154
bc7b6697 3155 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3156 (xfont_open): Avoid unnecessary tests.
bc7b6697 3157
27ccc379
PE
3158 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3159
dcd5c89a
PE
3160 * composite.h, composite.c (composition_gstring_put_cache):
3161 Use EMACS_INT, not int, for length.
3162
b13a45c6
PE
3163 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3164 breaking out part of COMPOSITION_DECODE_RULE.
3165 (COMPOSITION_DECODE_RULE): Use it.
3166 * composite.c (get_composition_id): Remove unused local vars,
3167 by using the new macro.
3168
1e792e4d
PE
3169 * textprop.c (set_text_properties_1): Change while to do-while,
3170 since the condition is always true at first.
3171
dc6c6455 3172 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3173 (interval_deletion_adjustment): Return unsigned value.
3174 All uses changed.
dc6c6455 3175
aba7731a
PE
3176 * process.c (list_processes_1, create_pty, read_process_output):
3177 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3178 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3179 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3180 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3181 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3182
fdfc4bf3
PE
3183 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3184
fca8fe46 3185 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3186 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3187
06a0259a 3188 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3189 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3190 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3191
e7b9e80f
PE
3192 * print.c (print_error_message): Avoid int overflow.
3193
56201685
PE
3194 * font.c (font_list_entities): Redo for clarity,
3195 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3196
78834453 3197 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3198 (font_score): Avoid potential overflow in diff calculation.
78834453 3199
0bc0b309 3200 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3201 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3202
e610eaca
PE
3203 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3204
b895abce
PE
3205 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3206 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3207 can always succeed if overflow has undefined behavior.
3208
1f1d9321 3209 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3210 (wordify): Omit three unnecessary tests.
1f1d9321 3211
c59478bc
PE
3212 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3213 All callers changed. This avoids the need for an unused var.
3214
79b73827
PE
3215 * casefiddle.c (casify_region): Remove var that is set but not used.
3216
a4db5dfe
PE
3217 * dired.c (file_name_completion): Remove var that is set but not used.
3218
43aae36e
PE
3219 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3220
2a47c44d 3221 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3222 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3223
a37c69bf
PE
3224 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3225 Check for integer overflow on size calculations.
3226
328ab8e7
PE
3227 * buffer.c (Fprevious_overlay_change): Remove var that is set
3228 but not used.
3229
e5a2a5cb
PE
3230 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3231 Remove vars that are set but not used.
8d84a6eb 3232 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3233 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3234
a60e5f68
PE
3235 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3236
f661cb61 3237 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3238 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3239
f0397f5a
PE
3240 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3241 that are set but not used.
3242
8664db06 3243 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3244 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3245
6abdaa4a
PE
3246 * xselect.c (x_get_local_selection, x_handle_property_notify):
3247 Remove vars that are set but not used.
3248
0ce7538d 3249 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3250 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3251
9ae848fc
PE
3252 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3253 Remove var that is set but not used.
0b918413
PE
3254 (scroll_bar_windows_size): Now size_t, not int.
3255 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3256 Check for overflow.
9ae848fc 3257
a5a62657
PE
3258 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3259 (map_tty_color) [!defined MSDOS]: Likewise.
3260
5c5cdd39
PE
3261 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3262
66ebf983
PE
3263 * coding.c: Remove vars that are set but not used.
3264 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3265 All callers changed.
3266 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3267 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3268 (decode_coding_charset): Remove vars that are set but not used.
3269
1be4d761
PE
3270 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3271 that is set but not used.
3272
47553fa8
PE
3273 * print.c (print_object): Remove var that is set but not used.
3274
1f7196bf 3275 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3276 The gnulib version avoids calling malloc in the usual case,
3277 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3278 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3279 * filelock.c (current_lock_owner): Likewise.
3280 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3281 * sysdep.c: Include allocator.h, careadlinkat.h.
3282 (emacs_no_realloc_allocator): New static constant.
3283 (emacs_readlink): New function.
fdb61804
PE
3284 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3285 ../lib/careadlinkat.h.
d1fdcab7 3286
f84c17c7
SM
32872011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3288
3289 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3290 first non-nil return value).
3291
ef3862ad
JD
32922011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3293
3294 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3295 if not defined (Bug#8403).
3296
376a7006
JB
32972011-04-02 Juanma Barranquero <lekktu@gmail.com>
3298
3299 * xdisp.c (display_count_lines): Remove parameter `start',
3300 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3301 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3302 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3303 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3304 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3305 and thereabouts. All callers changed.
3306 (get_per_char_metric): Remove parameter `f', unused since
3307 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3308
6ca3801d
JM
33092011-04-02 Jim Meyering <meyering@redhat.com>
3310
3311 do not dereference NULL upon failed strdup
3312 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3313 (ns_get_family): Likewise.
3314
d8e2b5ba
JB
33152011-04-02 Juanma Barranquero <lekktu@gmail.com>
3316
3317 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3318
8c74fcbd
JD
33192011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3320
3321 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3322 later (Bug#8403).
3323
7200d79c
SM
33242011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3325
03408648 3326 Add lexical binding.
7200d79c 3327
03408648
SM
3328 * window.c (Ftemp_output_buffer_show): New fun.
3329 (Fsave_window_excursion):
3330 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3331
3332 * lread.c (lisp_file_lexically_bound_p): New function.
3333 (Fload): Bind Qlexical_binding.
3334 (readevalloop): Remove `evalfun' arg.
3335 Bind Qinternal_interpreter_environment.
3336 (Feval_buffer): Bind Qlexical_binding.
3337 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3338 Mark as dynamic.
3339 (syms_of_lread): Declare `lexical-binding'.
3340
3341 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3342
3343 * keyboard.c (eval_dyn): New fun.
3344 (menu_item_eval_property): Use it.
ca105506
SM
3345
3346 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3347
03408648
SM
3348 * fns.c (concat, mapcar1): Accept byte-code-functions.
3349
3350 * eval.c (Fsetq): Handle lexical vars.
3351 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3352 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3353 (FletX, Flet): Obey lexical binding.
3354 (Fcommandp): Handle closures.
3355 (Feval): New `lexical' arg.
3356 (eval_sub): New function extracted from Feval. Use it almost
3357 everywhere where Feval was used. Look up vars in lexical env.
3358 Handle closures.
3359 (Ffunctionp): Move from subr.el.
3360 (Ffuncall): Handle closures.
3361 (apply_lambda): Remove `eval_flags'.
3362 (funcall_lambda): Handle closures and new byte-code-functions.
3363 (Fspecial_variable_p): New function.
3364 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3365 but without exporting it to Lisp.
23aba0ea 3366
23aba0ea 3367 * doc.c (Fdocumentation, store_function_docstring):
03408648 3368 * data.c (Finteractive_form): Handle closures.
23aba0ea 3369
03408648
SM
3370 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3371 interactive spec.
ba83908c 3372
04f2d78b
CB
3373 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3374 New byte-codes.
03408648
SM
3375 (exec_byte_code): New function extracted from Fbyte_code to handle new
3376 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3377
03408648 3378 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3379
03408648 3380 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3381
e2abce01
JB
33822011-03-31 Juanma Barranquero <lekktu@gmail.com>
3383
3384 * xdisp.c (redisplay_internal): Fix prototype.
3385
63696a73 33862011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3387
63696a73 3388 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3389 (try_scrolling): Use it when setting scroll_limit.
3390 Limit scrolling to 100 screen lines.
63696a73
EZ
3391 (redisplay_window): Even when falling back on "recentering",
3392 position point in the window according to scroll-conservatively,
3393 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3394
3395 (try_scrolling): When point is above the window, allow searching
3396 as far as scroll_max, or one screenful, to compute vertical
3397 distance from PT to the scroll margin position. This prevents
3398 try_scrolling from unnecessarily failing when
3399 scroll-conservatively is set to a value slightly larger than the
3400 window height. Clean up the case of PT below the margin at bottom
3401 of window: scroll_max can no longer be INT_MAX. When aggressive
3402 scrolling is in use, don't let point enter the opposite scroll
3403 margin as result of the scroll.
3404 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3405 threshold of 100 lines for never-recentering scrolling.
3406
e4cc2dfc
JB
34072011-03-31 Juanma Barranquero <lekktu@gmail.com>
3408
3409 * dispextern.h (move_it_by_lines):
3410 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3411 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3412 (message_log_check_duplicate): Remove parameters `prev_bol' and
3413 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3414 (redisplay_internal): Remove parameter `preserve_echo_area',
3415 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3416
3417 * indent.c (Fvertical_motion):
3418 * window.c (window_scroll_pixel_based, Frecenter):
3419 Don't pass `need_y_p' to `move_it_by_lines'.
3420
1c470562
SM
34212011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3422
44f230aa
SM
3423 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3424 steal a few bits to be more compact.
3425 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3426 Remove unneeded casts.
3427
1c470562
SM
3428 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3429
888adce9
ZK
34302011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3431
3432 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3433 binding" message (bug#7967).
3434
f838ed7b
PE
34352011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3436
77861b95
PE
3437 Fix more problems found by GCC 4.6.0's static checks.
3438
de6dbc14
PE
3439 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3440 Remove unused local var.
3441
f838ed7b
PE
3442 * editfns.c (Fmessage_box): Remove unused local var.
3443
792c7b2b
PE
3444 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3445 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3446 Omit unused local vars.
c499e557 3447 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3448 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3449 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3450 Omit unused local var.
3451
ba0165e1
PE
3452 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3453 Don't assume string length fits in int.
32ad8845 3454 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3455 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3456
3c59b4c9
PE
3457 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3458 instead of alloca (Bug#8344).
3459
a3eed478 3460 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3461 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3462
eb4d412d
PE
3463 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3464
1658b401
PE
3465 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3466 concerns.
3467
3468 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3469
3470 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3471
9a2c6e05
PE
3472 * keyboard.c (syms_of_keyboard): Use the same style as later
3473 in this function when indexing through an array. This also
3474 works around GCC bug 48267.
3475
03d0a109
PE
3476 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3477
44f730c8
PE
3478 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3479
fe75f926
PE
3480 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3481 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3482
ffa8c828
PE
3483 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3484 This avoids undefined behavior on integer overflow, and is a bit
3485 more convenient anyway since it is compared to a size_t variable.
3486
c5101a77
PE
3487 Variadic C functions now count arguments with size_t, not int.
3488 This avoids an unnecessary limitation on 64-bit machines, which
3489 caused (substring ...) to crash on large vectors (Bug#8344).
3490 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3491 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3492 All variadic functions and their callers changed accordingly.
c5101a77
PE
3493 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3494 * data.c (arith_driver, float_arith_driver): Likewise.
3495 * editfns.c (general_insert_function): Likewise.
3496 * eval.c (struct backtrace.nargs, interactive_p)
3497 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3498 (funcall_lambda, mark_backtrace): Likewise.
3499 * fns.c (concat): Likewise.
3500 * frame.c (x_set_frame_parameters): Likewise.
3501 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3502 0 if not found, not -1. All callers changed.
3503
dd3f25f7
PE
3504 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3505 (stack_copy_size): Now size_t, not int.
3506 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3507
461c2ab9
JB
35082011-03-28 Juanma Barranquero <lekktu@gmail.com>
3509
3510 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3511 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3512 All callers changed.
3513
3514 * lisp.h (multibyte_char_to_unibyte):
3515 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3516 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3517 * character.h (CHAR_TO_BYTE8):
3518 * cmds.c (internal_self_insert):
3519 * editfns.c (general_insert_function):
3520 * keymap.c (push_key_description):
3521 * search.c (Freplace_match):
3522 * xdisp.c (message_dolog, set_message_1): All callers changed.
3523
f6d62986
SM
35242011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3525
3526 * keyboard.c (safe_run_hook_funcall): New function.
3527 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3528 don't set the hook to nil, but remove the offending function instead.
3529 (Qcommand_hook_internal): Remove, unused.
3530 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3531 Vcommand_hook_internal.
3532
3533 * eval.c (enum run_hooks_condition): Remove.
3534 (funcall_nil, funcall_not): New functions.
3535 (run_hook_with_args): Call each function through a `funcall' argument.
3536 Remove `cond' argument, now redundant.
3537 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3538 (Frun_hook_with_args_until_failure): Adjust accordingly.
3539 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3540
1db5b1ad
JB
35412011-03-28 Juanma Barranquero <lekktu@gmail.com>
3542
3543 * dispextern.h (string_buffer_position): Remove declaration.
3544
3545 * print.c (strout): Remove parameter `multibyte', unused since
3546 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3547
3548 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3549 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3550 All callers changed.
3551
3552 * w32.c (_wsa_errlist): Use braces for struct initializers.
3553
3554 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3555 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3556 All callers changed.
3557 (string_buffer_position): Likewise. Also, make static (it's never
3558 used outside xdisp.c).
3559 (cursor_row_p): Remove parameter `w', unused since
3560 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3561 (decode_mode_spec): Remove parameter `precision', introduced during
3562 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3563 All callers changed.
3564
5ffb62aa
JD
35652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3566
3567 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3568
461c2ab9 35692011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3570
3571 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3572 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3573 (ns_update_auto_hide_menu_bar): New functions.
3574 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3575 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3576 ns_constrain_all_frames.
3577 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3578 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3579
5c380ffb
JD
35802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3581
3582 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3583
9af30bdf
GM
35842011-03-27 Glenn Morris <rgm@gnu.org>
3585
3586 * syssignal.h: Replace RETSIGTYPE with void.
3587 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3588 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3589 Replace SIGTYPE with void everywhere.
3590 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3591 * s/template.h (SIGTYPE): Remove commented out definition.
3592
e2abce01
JB
35932011-03-26 Eli Zaretskii <eliz@gnu.org>
3594
3595 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3596 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3597
f868cd8a
JB
35982011-03-26 Juanma Barranquero <lekktu@gmail.com>
3599
59eb0929
JB
3600 * w32.c (read_unc_volume): Use parameter `henum', instead of
3601 global variable `wget_enum_handle'.
3602
3603 * keymap.c (describe_vector): Remove parameters `indices' and
3604 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3605 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3606
f868cd8a
JB
3607 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3608
3609 * keyboard.c (timer_check): Remove parameter `do_it_now',
3610 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3611 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3612 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3613
3614 * keyboard.c (read_char):
3615 * w32menu.c (w32_menu_display_help):
3616 * xmenu.c (show_help_event, menu_help_callback):
3617 Adjust calls to `show_help_echo'.
3618
3619 * gtkutil.c (xg_maybe_add_timer):
3620 * keyboard.c (readable_events):
3621 * process.c (wait_reading_process_output):
3622 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3623
3624 * insdel.c (adjust_markers_gap_motion):
3625 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3626 (gap_left, gap_right): Don't call it.
3627
2ecf6fdb
CY
36282011-03-25 Chong Yidong <cyd@stupidchicken.com>
3629
3630 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3631 incurred during fontification.
3632
6b1f9ba4
JB
36332011-03-25 Juanma Barranquero <lekktu@gmail.com>
3634
3635 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3636 (DEFVAR_PER_BUFFER): Don't pass it.
3637
3638 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3639 (scrolling_window): Don't pass it.
3640
0f4a96b5
JB
36412011-03-25 Juanma Barranquero <lekktu@gmail.com>
3642
3643 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3644
3645 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3646 and `suffix'.
3647 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3648 of variables specific to SELinux and computation of `encoded_absname'.
3649
3650 * image.c (XPutPixel): Remove unused variable `height'.
3651
3652 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3653
3654 * unexw32.c (get_section_info): Remove unused variable `section'.
3655
3656 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3657 (system_process_attributes): Remove unused variable `sess'.
3658 (sys_read): Remove unused variable `err'.
3659
3660 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3661 (w32_wnd_proc): Remove unused variable `isdead'.
3662 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3663 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3664 (x_create_tip_frame): Remove unused variable `tem'.
3665
3666 * w32inevt.c (w32_console_read_socket):
3667 Remove unused variable `no_events'.
3668
3669 * w32term.c (x_draw_composite_glyph_string_foreground):
3670 Remove unused variable `width'.
3671
1149507c
JB
36722011-03-24 Juanma Barranquero <lekktu@gmail.com>
3673
3674 * w32term.c (x_set_glyph_string_clipping):
3675 Don't pass uninitialized region to CombineRgn.
3676
9c88f339
JB
36772011-03-23 Juanma Barranquero <lekktu@gmail.com>
3678
3679 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3680 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3681 (Fx_close_connection): Remove unused variable `i'.
3682
3683 * w32font.c (w32font_draw): Return number of glyphs.
3684 (w32font_open_internal): Remove unused variable `i'.
3685 (w32font_driver): Add missing initializer.
3686
3687 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3688 (fill_in_menu): Remove unused variable `items_added'.
3689
3690 * w32term.c (last_mouse_press_frame): Remove static global variable.
3691 (w32_clip_to_row): Remove unused variable `f'.
3692 (x_delete_terminal): Remove unused variable `i'.
3693
3694 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3695 (NOTHING): Remove unused static global variable.
3696 (uniscribe_check_otf): Remove unused variable `table'.
3697 (uniscribe_font_driver): Add missing initializers.
3698
dee091a3
JD
36992011-03-23 Julien Danjou <julien@danjou.info>
3700
3701 * term.c (Fsuspend_tty, Fresume_tty):
3702 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3703 * window.c (temp_output_buffer_show):
3704 * insdel.c (signal_before_change):
3705 * frame.c (Fhandle_switch_frame):
3706 * fileio.c (Fdo_auto_save):
3707 * emacs.c (Fkill_emacs):
3708 * editfns.c (save_excursion_restore):
3709 * cmds.c (internal_self_insert):
3710 * callint.c (Fcall_interactively):
3711 * buffer.c (Fkill_all_local_variables):
3712 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3713 Use Frun_hooks.
0f4a96b5 3714 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3715 unconditionnaly since it does the check itself.
3716
2c520ab5 37172011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3718
c9c49752
PE
3719 Fix more problems found by GCC 4.5.2's static checks.
3720
8abc3f12
PE
3721 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3722 the first time through the loop, since we know p0 < p1 then.
3723 This also avoids a gcc -Wstrict-overflow warning.
3724
a2d26660
PE
3725 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3726 leading to a memory leak, possible in functions like
3727 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3728 of objects (Bug#8318).
a2d26660 3729
916c72e9
PE
3730 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3731 that could (at least in theory) be that large.
3732
19ab8a18
PE
3733 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3734 This is less likely to overflow, and avoids undefined behavior if
3735 overflow does occur. All callers changed. Use strtoul to scan
3736 for the unsigned long integer.
b7cbbd6f
PE
3737 (pint2hrstr): Simplify and tune code slightly.
3738 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3739
f0641eff
PE
3740 * scroll.c (do_scrolling): Work around GCC bug 48228.
3741 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3742
7f650bb9
PE
3743 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3744 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3745 (validate_x_resource_name): Simplify count usage.
3746 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3747
37dd57d1
PE
3748 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3749 fail (Bug#8306).
81e56e61 3750
699979fc 3751 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3752
401bf9b4
PE
3753 * process.c (Fmake_network_process): Use socklen_t, not int,
3754 where POSIX says socklen_t is required in portable programs.
3755 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3756 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3757 (Fmake_network_process, server_accept_connection):
3758 (wait_reading_process_output, read_process_output):
3759 Likewise.
3760
b93aacde
PE
3761 * process.c: Rename or move locals to avoid shadowing.
3762 (list_processes_1, Fmake_network_process):
3763 (read_process_output_error_handler, exec_sentinel_error_handler):
3764 Rename or move locals.
4dc343ee 3765 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3766 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3767 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3768 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3769 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3770
af8a867c 3771 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3772 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3773 Include tparam.h instead, since it declares them.
af8a867c
PE
3774 * cm.h (PC): Remove extern decl; tparam.h now does this.
3775 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3776 * terminfo.c: Include tparam.h, to check interfaces.
3777 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3778 (tparam): Adjust signature to match interface in tparam.h;
3779 this removes some undefined behavior. Check that outstring and len
3780 are zero, which they always are with Emacs.
3781 * tparam.h (PC, BC, UP): New extern decls.
3782
0248044d 3783 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3784 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3785
8ff096c1 3786 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3787 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3788 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3789 (ftfont_list): Remove unused local.
49eaafba
PE
3790 (get_adstyle_property, ftfont_pattern_entity):
3791 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3792 Rename locals to avoid shadowing.
8ff096c1 3793
e2be39f6
PE
3794 * xfont.c (xfont_list_family): Mark var as initialized.
3795
c9735e30
PE
3796 * xml.c (make_dom): Now static.
3797
8f5201ae
PE
3798 * composite.c (composition_compute_stop_pos): Rename local to
3799 avoid shadowing.
b246f932
PE
3800 (composition_reseat_it): Remove unused locals.
3801 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3802 (composition_update_it): Mark var as initialized.
11b61122
PE
3803 (find_automatic_composition): Mark vars as initialized,
3804 with a FIXME (Bug#8290).
8f5201ae 3805
760fbc2c
PE
3806 character.h: Rename locals to avoid shadowing.
3807 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3808 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3809 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3810 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3811 to avoid shadowing.
3812
ff08eb85
PE
3813 * textprop.c (property_change_between_p): Remove; unused.
3814
fc7bf025
PE
3815 * intervals.c (interval_start_pos): Now static.
3816
235d7abc
PE
3817 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3818
44f230aa
SM
3819 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3820 Rename locals to avoid shadowing.
3e7d6594 3821
50060332
PE
3822 * sound.c (wav_play, au_play, Fplay_sound_internal):
3823 Fix pointer signedness.
d01f234b 3824 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3825 (wav_play): Initialize a variable to 0, to prevent undefined
3826 behavior (Bug#8278).
50060332 3827
c4fc4e30
PE
3828 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3829
918436ed
PE
3830 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3831
c939f91b
PE
3832 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3833 clobbering (Bug#8298).
b9c7f648
PE
3834 * sysdep.c (sys_subshell): Likewise.
3835 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3836
6bd8c144
PE
3837 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3838 This should get cleaned up, so that child_setup has the
3839 same signature on all platforms.
3840
7710357c 3841 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3842 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3843
c59da222
CY
38442011-03-22 Chong Yidong <cyd@stupidchicken.com>
3845
3846 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3847 not to be necessary, and produces flickering.
3848
66b87493
GM
38492011-03-20 Glenn Morris <rgm@gnu.org>
3850
3851 * config.in: Remove file.
3852
45b6f6d5
JB
38532011-03-20 Juanma Barranquero <lekktu@gmail.com>
3854
3855 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3856 are now in src/globals.h.
3857 (syms_of_minibuf): Remove spurious & from previous change.
3858
3ec03f7e
LL
38592011-03-20 Leo <sdl.web@gmail.com>
3860
3861 * minibuf.c (completing-read-function): New variable.
3862 (completing-read-default): Rename from completing-read.
3863 (completing-read): Call completing-read-function.
3864
b14e3e21
CY
38652011-03-19 Juanma Barranquero <lekktu@gmail.com>
3866
3867 * xfaces.c (Fx_load_color_file):
3868 Read color file from absolute filename (bug#8250).
3869
f2b726e6
JB
38702011-03-19 Juanma Barranquero <lekktu@gmail.com>
3871
3872 * makefile.w32-in: Update dependencies.
3873
09f6ff02
EZ
38742011-03-17 Eli Zaretskii <eliz@gnu.org>
3875
3876 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3877
29a6015a
PE
38782011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3879
a3a6c54e
PE
3880 Fix more problems found by GCC 4.5.2's static checks.
3881
b766f867
PE
3882 * process.c (make_serial_process_unwind, send_process_trap):
3883 (sigchld_handler): Now static.
3884
be02381c
PE
3885 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3886 That way, the code declares only the vars that it needs.
3887 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3888 * s/cygwin.h (PTY_ITERATION): Likewise.
3889 * s/darwin.h (PTY_ITERATION): Likewise.
3890 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3891
57048744
PE
3892 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3893 * process.c (allocate_pty): Don't declare stb unless it's needed.
3894
7914961c 3895 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3896 (CONSTANTLIM): Remove; unused.
3897 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3898 Define only if needed.
7914961c 3899
b3967b18
PE
3900 * unexelf.c (unexec): Name an expression,
3901 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3902 Use a different way to cause a compilation error if anyone uses
3903 n rather than nn, a way that does not involve shadowing.
73366a00 3904 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3905
29a6015a
PE
3906 * deps.mk (unexalpha.o): Remove; unused.
3907
43cfc33e 3908 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3909 * unexec.h: New file.
ce701a33
PE
3910 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3911 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3912 Depend on unexec.h.
3913 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3914 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3915 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3916 Change as necessary to match prototype in unexec.h.
ce701a33 3917
01f44d5a
PE
3918 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3919 shadowing.
4f63c6bb 3920 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3921
a6670b0b
PE
3922 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3923 Rename locals to avoid shadowing.
3924
cef2010d 3925 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3926 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3927
d4d7173a
PE
3928 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3929
f08b802a
PE
3930 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3931 warning when compiling print.c.
3932
3ddb0639
PE
3933 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3934 instead of using an uninitialized var.
5ad03b97 3935 (font_sort_entities): Mark var as initialized.
3ddb0639 3936
170a2692
PE
3937 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3938
e663c700
PE
3939 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3940 pointers to constants.
89bc529a 3941 (font_parse_fcname): Remove unused vars.
7b81e2d0 3942 (font_delete_unmatched): Now static.
ea838e10 3943 (font_get_spec): Remove; unused.
13a547c6
PE
3944 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3945 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3946 Rename or move locals to avoid shadowing.
e663c700 3947
2a80c887 3948 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3949 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3950
1384fa33 3951 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3952 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3953
8b2c52e9
PE
3954 * alloc.c (mark_backtrace): Move decl from here ...
3955 * lisp.h: ... to here, so that it can be checked.
3956
475545b5 3957 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3958 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3959 (lisp_indirect_variable): Name an expression,
3960 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3961 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3962
b1349114 3963 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3964 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3965 Use const pointer when appropriate.
b1349114 3966
a2928364
PE
3967 * lisp.h (get_system_name, get_operating_system_release):
3968 Move decls here, to check interfaces.
3969 * process.c (get_operating_system_release): Move decl to lisp.h.
3970 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3971 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3972 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3973 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3974 (Fformat_time_string, Fencode_time, Finsert_char):
3975 (Ftranslate_region_internal, Fformat):
3976 Rename or remove local vars to avoid shadowing.
9710023e 3977 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3978
a415e694
PE
3979 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3980 avoid shadowing.
3981
8ef4622d
PE
3982 * lisp.h (eassert): Check that the argument compiles, even if
3983 ENABLE_CHECKING is not defined.
3984
946f9a5b
PE
3985 * data.c (Findirect_variable): Name an expression, to avoid
3986 gcc -Wbad-function-cast warning.
112396d6 3987 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3988 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3989 (Fmake_variable_buffer_local, Fmake_local_variable):
3990 Mark variables as initialized.
52746918 3991 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3992
e5aab7e7 3993 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3994 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3995 Rename locals to avoid shadowing.
dff45157
PE
3996 (mark_stack): Move local variables into the #ifdef region where
3997 they're used.
7bc26fdb
PE
3998 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3999 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4000 needed otherwise.
4001 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4002 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4003 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4004
e5aab7e7
PE
4005 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4006 avoids undefined behavior in theory.
4007
4da60324
PE
4008 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4009
88043301
PE
4010 Use functions, not macros, for up- and down-casing (Bug#8254).
4011 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4012 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4013 to use the following functions instead of these macros.
4014 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4015 EMACS_INT, since callers assume the returned value fits in int.
4016 (upcase1): Likewise, for UPCASE_TABLE.
4017 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4018 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4019 the race-condition problem in the old DOWNCASE.
88043301 4020
19ed5445
PE
4021 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4022 Rename locals to avoid shadowing.
4023 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4024 (regex_compile, re_search_2, re_match_2_internal):
4025 Remove unused local vars.
952db0d7
PE
4026 (FREE_VAR): Rewrite so as not to use empty "else",
4027 which gcc can warn about.
da053e48 4028 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4029 (RETALLOC_IF): Define only if needed.
4030 (WORDCHAR_P): Likewise. This one is never needed, but is used
4031 only in a comment talking about a compiler bug, so put inside
4032 the #if 0 of that comment.
4033 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4034 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4035 Remove; unused.
19ed5445 4036
1f3561e4 4037 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4038 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4039 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4040
ded6f8f7
PE
4041 * search.c (simple_search): Remove unused var.
4042
dbd37a95
PE
4043 * dired.c (compile_pattern): Move decl from here ...
4044 * lisp.h: ... to here, so that it can be checked.
4045 (struct re_registers): New forward decl.
4046
7e47afad
PE
4047 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4048
85f24f61
PE
4049 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4050 All uses changed.
4051 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4052 Rename locals to avoid shadowing.
5671df8f 4053 (Fvertical_motion): Mark locals as initialized.
85f24f61 4054
181aa2be 4055 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4056 (casify_region): Mark local as initialized.
181aa2be 4057
930d429c
PE
4058 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4059
7082eac6
PE
4060 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4061 New macros, so that the caller can use some names other than
4062 gcpro1, gcpro2, etc.
4063 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4064 of the new macros.
4065 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4066 argument, for consistency with GCPRO2_VAR, etc: it is now the
4067 prefix of the variable, not the variable itself. All uses
4068 changed.
38b2c076
PE
4069 * dired.c (directory_files_internal, file_name_completion):
4070 Rename locals to avoid shadowing.
4071
15206ed9
PE
4072 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4073 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4074 dired.c's scmp function, had undefined behavior.
4075 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4076 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4077 * buffer.h: ... to here, because these macros use current_buffer,
4078 and the new implementation with inline functions needs to have
4079 current_buffer in scope now, rather than later when the macros
4080 are used.
4081 (downcase, upcase1): New static inline functions.
4082 (DOWNCASE, UPCASE1): Reimplement using these functions.
4083 This avoids undefined behavior in expressions like
4084 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4085 from race conditions in accessing the global variables
4086 case_temp1 and case_temp2.
4087 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4088 * lisp.h (case_temp1, case_temp2): Remove their decls.
4089 * character.h (ASCII_CHAR_P): Move from here ...
4090 * lisp.h: ... to here, so that the inline functions mentioned
4091 above can use them.
4092
4a6bea26
PE
4093 * dired.c (directory_files_internal_unwind): Now static.
4094
f14b7e14
PE
4095 * fileio.c (file_name_as_directory, directory_file_name):
4096 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4097 Now static.
2893f146
PE
4098 (file_name_as_directory): Use const pointers when appropriate.
4099 (Fexpand_file_name): Likewise. In particular, newdir might
4100 point at constant storage, so make it a const pointer.
fd4ead52 4101 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4102 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4103 signedness issues.
f839df0c
PE
4104 (Fset_file_times, Finsert_file_contents, auto_save_error):
4105 Rename locals to avoid shadowing.
f14b7e14 4106
5716756e 4107 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4108 (Ftry_completion, Fall_completions): Rename or remove locals
4109 to avoid shadowing.
5716756e 4110
b4c3046a
PE
4111 * marker.c (bytepos_to_charpos): Remove; unused.
4112
b45db522
PE
4113 * lisp.h (verify_bytepos, count_markers): New decls,
4114 so that gcc does not warn that these functions aren't declared.
4115
85876d07
PE
4116 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4117 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4118 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4119 (copy_text): Remove unused local var.
85876d07 4120
03d78a21 4121 * filelock.c (within_one_second): Now static.
b3dd38ab 4122 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4123
5df8f01b
PE
4124 * buffer.c (fix_overlays_before): Mark locals as initialized.
4125 (fix_start_end_in_overlays): Likewise. This function should be
4126 simplified by using pointers-to-pointers, but that's a different
4127 matter.
b1d876f1 4128 (switch_to_buffer_1): Now static.
8f54f30a
PE
4129 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4130 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4131
a70072c9 4132 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4133 Fix pointer signedness issue.
edced198
PE
4134 (sys_subshell): Mark local as volatile if checking for lint,
4135 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4136 (MAXPATHLEN): Define only if needed.
a70072c9 4137
a0977c44
PE
4138 * process.c (serial_open, serial_configure): Move decls from here ...
4139 * systty.h: ... to here, so that they can be checked.
4140
a884fdcc
PE
4141 * fns.c (get_random, seed_random): Move extern decls from here ...
4142 * lisp.h: ... to here, so that they can be checked.
4143
604efe86 4144 * sysdep.c (reset_io): Now static.
b8950c94 4145 (wait_for_termination_signal): Remove; unused.
604efe86 4146
38fc62d9
PE
4147 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4148 (copy_keymap_item, append_key, push_text_char_description):
4149 Now static.
1004a21a 4150 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4151 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4152 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4153 (describe_map_tree):
4154 Rename locals to avoid shadowing.
38fc62d9 4155
2f2650da
PE
4156 * keyboard.c: Declare functions static if they are not used elsewhere.
4157 (echo_char, echo_dash, cmd_error, top_level_2):
4158 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4159 (read_char, kbd_buffer_get_event, make_lispy_position):
4160 (make_lispy_event, make_lispy_movement, apply_modifiers):
4161 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4162 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4163 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4164 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4165 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4166
a053e86c 4167 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4168 (mark_kboards): Move decl here ...
4169 * alloc.c (mark_kboards): ... from here.
a053e86c 4170
4752793e
PE
4171 * lisp.h (force_auto_save_soon): New decl.
4172
74f10ca7 4173 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4174 (DEFINE_DUMMY_FUNCTION): New macro.
4175 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4176 Use it.
c03cd23f
PE
4177 (main): Add casts to avoid warnings
4178 if GCC considers string literals to be constants.
74f10ca7 4179
022e70d4
PE
4180 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4181
59d6fe83
PE
4182 * dbusbind.c: Pointer signedness fixes.
4183 (xd_signature, xd_append_arg, xd_initialize):
4184 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4185 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4186 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4187 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4188
78320123
PE
4189 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4190 if GCC considers string literals to be constants.
49cebcca 4191 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4192
35ac2a97
SM
41932011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4194
fb103ca9
SM
4195 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4196 (print_preprocess, print_object): New macro to fix last change.
4197
35ac2a97
SM
4198 * print.c (print_preprocess): Don't forget font objects.
4199
62973b41
JB
42002011-03-16 Juanma Barranquero <lekktu@gmail.com>
4201
4202 * emacs.c (USAGE3): Doc fixes.
4203
0e48bb22
AS
42042011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4205
4206 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4207 structure.
4208
7684e57b
JB
42092011-03-14 Juanma Barranquero <lekktu@gmail.com>
4210
4211 * lisp.h (VWindow_system, Qfile_name_history):
4212 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4213 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4214 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4215
4216 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4217 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4218
4219 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4220 * w32console.c (detect_input_pending, read_input_pending)
4221 (encode_terminal_code):
4222 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4223 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4224 (w32_system_caret_y, Qfile_name_history):
4225 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4226 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4227 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4228 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4229 * w32proc.c (Qlocal, report_file_error):
4230 * w32term.c (Vwindow_system, updating_frame):
4231 * w32uniscribe.c (initialized, uniscribe_font_driver):
4232 Remove unneeded extern declarations.
4233
2aa46d6c
CY
42342011-03-14 Chong Yidong <cyd@stupidchicken.com>
4235
c96bbc66 4236 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4237
cffc6f3b
CY
42382011-03-13 Chong Yidong <cyd@stupidchicken.com>
4239
4240 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4241 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4242 These macros can no longer be used for assignment.
4243
44f230aa
SM
4244 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4245 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4246 (record_buffer_markers, fetch_buffer_markers): New functions for
4247 recording and fetching special buffer markers.
4248 (set_buffer_internal_1, set_buffer_temp): Use them.
4249
4250 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4251
4252 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4253
4254 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4255 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4256
4257 * xdisp.c (hscroll_window_tree):
4258 (reconsider_clip_changes): Use PT instead of BUF_PT.
4259
d251f04b
EZ
42602011-03-13 Eli Zaretskii <eliz@gnu.org>
4261
4262 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4263 $(EMACS_ROOT)/lib/intprops.h.
4264
f0c77cd1
PE
42652011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4266
3eca4629
PE
4267 Fix more problems found by GCC 4.5.2's static checks.
4268
7c86ee98
PE
4269 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4270 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4271 (xg_free_frame_widgets): Make it clear that a local variable is
4272 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4273 (gdk_window_get_screen): Make it clear that this macro is needed
4274 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4275 (int_gtk_range_get_value): New function, which avoids a diagnostic
4276 from gcc -Wbad-function-cast.
4277 (xg_set_toolkit_scroll_bar_thumb): Use it.
4278 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4279 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4280 (get_utf8_string, xg_get_file_with_chooser):
4281 Rename locals to avoid shadowing.
4282 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4283
41729b81
PE
4284 * xgselect.c (xg_select): Remove unused var.
4285
f0c77cd1
PE
4286 * image.c (four_corners_best): Mark locals as initialized.
4287 (gif_load): Initialize transparent_p to zero (Bug#8238).
4288 Mark another local as initialized.
ec6cf4c6 4289 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4290
ce0ad53d 4291 * image.c (clear_image_cache): Now static.
d5d5a617 4292 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4293 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4294 (x_edge_detection): Remove unnecessary cast that
4295 gcc -Wbad-function-cast diagnoses.
2037898d 4296 (gif_load): Fix pointer signedness.
6ae141d6
PE
4297 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4298 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4299
33383987 43002011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4301
d32df629
PE
4302 Improve quality of tests for time stamp overflow.
4303 For example, without this patch (encode-time 0 0 0 1 1
4304 1152921504606846976) returns the obviously-bogus value (-948597
4305 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4306 reports time overflow. See
4307 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4308 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4309 * editfns.c: Include limits.h and intprops.h.
4310 (TIME_T_MIN, TIME_T_MAX): New macros.
4311 (time_overflow): Move earlier, to before first use.
4312 (hi_time, lo_time): New functions, for an accurate test for
4313 out-of-range times.
4314 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4315 (Fget_internal_run_time): Don't assume time_t fits in int.
4316 (make_time): Use list2 instead of Fcons twice.
4317 (Fdecode_time): More accurate test for out-of-range times.
4318 (check_tm_member): New function.
4319 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4320 (lisp_time_argument): Don't rely on undefined left-shift and
4321 right-shift behavior when checking for time stamp overflow.
8be6f318 4322
fe31d94c
PE
4323 * editfns.c (time_overflow): New function, refactoring common code.
4324 (Fformat_time_string, Fdecode_time, Fencode_time):
4325 (Fcurrent_time_string): Use it.
4326
8be6f318
PE
4327 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4328 * dired.c (make_time): Move to ...
4329 * editfns.c (make_time): ... here.
4330 * systime.h: Note the move.
4331
09d9db2c 43322011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4333
126bc0dc
YM
4334 * fringe.c (update_window_fringes): Remove unused variables.
4335
c47cbdfd
YM
4336 * unexmacosx.c (copy_data_segment): Also copy __got section.
4337 (Bug#8223)
4338
7ac80be9
EZ
43392011-03-12 Eli Zaretskii <eliz@gnu.org>
4340
c96bbc66 4341 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4342 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4343 Constify `char *' arguments and their references according to
4344 prototypes in tparam.h.
4345
ecb0f94d 4346 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4347
7ac80be9
EZ
4348 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4349 Adapt all references accordingly.
4350
4351 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4352
ef1fd07e
TT
43532011-03-11 Tom Tromey <tromey@redhat.com>
4354
4355 * buffer.c (syms_of_buffer): Remove obsolete comment.
4356
7ef4b50c
EZ
43572011-03-11 Eli Zaretskii <eliz@gnu.org>
4358
4359 * termhooks.h (encode_terminal_code): Declare prototype.
4360
4361 * msdos.c (encode_terminal_code): Don't declare prototype.
4362
4363 * term.c (encode_terminal_code): Now external again, used by
4364 w32console.c and msdos.c.
4365
44f230aa
SM
4366 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4367 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4368
4b1ec863 43692011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4370
1714f52b 4371 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4372
4b1ec863
PE
4373 * fringe.c (update_window_fringes): Mark locals as initialized
4374 (Bug#8227).
4375 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4376
524c7aa6
PE
4377 * alloc.c (mark_fringe_data): Move decl from here ...
4378 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4379 to check its interface.
4380 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4381
a5c0af81 4382 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4383 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4384 (fontset_font): Mark local as initialized.
a9a06e0b 4385 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4386
b4716021
PE
4387 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4388
811e9bac 4389 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4390 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4391 (x_own_selection, Fx_disown_selection_internal): Rename locals
4392 to avoid shadowing.
4393 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4394
7e3ab302
PE
4395 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4396 so that the caller can use some name other than gcpro1.
4397 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4398 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4399 (Fx_backspace_delete_keys_p):
4400 Use them to avoid shadowing, and rename vars to avoid shadowing.
4401 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4402 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4403 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4404 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4405 Remove unused locals.
7e3ab302
PE
4406 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4407 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4408 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4409 macros.
f78faa98 4410
e2b13473
PE
4411 * xterm.h (x_mouse_leave): New decl.
4412
77f23912
PE
4413 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4414 Remove unused functions.
cdf4ba58
PE
4415 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4416 (x_calc_absolute_position): Now static.
7411c686 4417 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4418 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4419 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4420 unless they are used.
38d0b34a
PE
4421 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4422 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4423 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4424 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4425 (x_error_catcher, x_connection_closed, x_error_handler):
4426 (x_error_quitter, xembed_send_message, x_iconify_frame):
4427 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4428 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4429 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4430
44f230aa
SM
4431 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4432 Rename or move locals to avoid shadowing.
6b463e58 4433 (tty_defined_color, merge_face_heights): Now static.
5967d051 4434 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4435 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4436 does not deduce is never used uninitialized.
73719eba
PE
4437 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4438 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4439
426994c3 4440 * terminal.c (store_terminal_param): Now static.
5489860b 4441
032f1620 4442 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4443 (set_frame_menubar): Remove unused local.
d4323972 4444 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4445 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4446 since they might point to immutable storage.
281585b0
PE
4447 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4448 since it's unused otherwise.
032f1620 4449
367c19e5 4450 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4451 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4452 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4453 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4454 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4455 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4456 does not deduce are never used uninitialized.
70739cbe 4457
07b48fa9
PE
4458 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4459
8868a238 4460 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4461 * window.c (window_loop, size_window):
4462 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4463
7e5cf297 4464 * window.c (display_buffer): Now static.
d6550a9f
PE
4465 (size_window): Mark variables that gcc -Wuninitialized
4466 does not deduce are never used uninitialized.
a586633d
PE
4467 * window.h (check_all_windows): New decl, to forestall
4468 gcc -Wmissing-prototypes diagnostic.
5b555da1 4469 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4470
f6095868
PE
4471 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4472 shadowing.
4473 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4474 Include <limits.h>.
4475 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4476 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4477 (load_charset_map): Mark variables that gcc -Wuninitialized
4478 does not deduce are never used uninitialized.
53df7c11 4479 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4480
f38b440c
PE
4481 * coding.c (coding_set_source, coding_set_destination):
4482 Use "else { /* comment */ }" rather than "else /* comment */;"
4483 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4484 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4485 a block, when the outer 'i' will do.
4486 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4487 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4488 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4489 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4490 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4491 Rename locals to avoid shadowing.
4492 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4493 * coding.c (emacs_mule_char, encode_invocation_designation):
4494 Now static, since they're not used elsewhere.
413bb2db 4495 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4496 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4497 (decode_coding_emacs_mule): Mark variables that gcc
4498 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4499 (detect_coding_iso_2022): Initialize a local variable that might
4500 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4501 this initialization is needed. (Bug#8211)
5f58e762
PE
4502 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4503 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4504 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4505 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4506 Remove unused macros.
f38b440c 4507
232b38b9 4508 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4509 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4510 * character.c (string_count_byte8): Likewise.
232b38b9 4511
fb90da1b
PE
4512 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4513 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4514
fb93dbc2
PE
4515 * chartab.c (copy_sub_char_table): Now static, since it's not used
4516 elsewhere.
5c156ace
PE
4517 (sub_char_table_ref_and_range, char_table_ref_and_range):
4518 Rename locals to avoid shadowing.
bbcd0949 4519 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4520
7d3b3862 4521 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4522 (BIDI_BOB): Remove unused macro.
7d3b3862 4523
6be7d3da
PE
4524 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4525 deduce are never used uninitialized.
c2ed9c8b 4526 * term.c (encode_terminal_code): Likewise.
6be7d3da 4527
75f8807f 4528 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4529
50938595
PE
4530 * tparam.h: New file.
4531 * term.c, tparam.h: Include it.
4532 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4533 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4534 Move these decls to tparam.h, and make them agree with what
4535 is actually in tparam.c. The previous trick of using incompatible
4536 decls in different modules does not conform to the C standard.
4537 All callers of tparam changed to use tparam's actual API.
4538 * tparam.c (tparam1, tparam, tgoto):
4539 Use const pointers where appropriate.
4540
fbceeba2
PE
4541 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4542 * cm.h (struct cm): Likewise.
4543 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4544 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4545 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4546 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4547 (turn_on_face, init_tty): Likewise.
4548 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4549
7f3f1250
PE
4550 * term.c (term_mouse_position): Rename local to avoid shadowing.
4551
e6ca6543
PE
4552 * alloc.c (mark_ttys): Move decl from here ...
4553 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4554
c40f8d15
AS
45552011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4556
4557 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4558
cfe0661d
JB
45592011-03-09 Juanma Barranquero <lekktu@gmail.com>
4560
4561 * search.c (compile_pattern_1): Remove argument regp, unused since
4562 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4563 (compile_pattern): Don't pass it.
4564
0afb4571
J
45652011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4566
4567 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4568 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4569 for ! HAVE_GTK3.
4570 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4571
4572 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4573
4574 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4575 gdk_window_get_screen, gdk_window_get_geometry,
4576 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4577 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4578 (xg_get_pixbuf_from_pixmap): New function.
4579 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4580 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4581 Call xg_get_pixbuf_from_pixmap instead of
4582 gdk_pixbuf_get_from_drawable.
4583 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4584 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4585 (xg_check_special_colors): Use GtkStyleContext and its functions
4586 for HAVE_GTK3.
4587 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4588 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4589 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4590 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4591 Call gtk_widget_get_preferred_size.
0afb4571
J
4592 (xg_frame_resized): gdk_window_get_geometry only takes 5
4593 parameters.
44f230aa
SM
4594 (xg_win_to_widget, xg_event_is_for_menubar):
4595 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4596 (xg_set_widget_bg): New function.
4597 (delete_cb): New function.
895009e1 4598 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4599 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4600 (xg_set_background_color): Call xg_set_widget_bg.
4601 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4602 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4603 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4604 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4605 if ! HAVE_GTK3.
4606 (update_frame_tool_bar): Call gtk_widget_hide.
4607 (xg_initialize): Use GDK_KEY_g.
4608
4609 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4610 if ! HAVE_GTK3
4611 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4612
4613 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4614 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4615 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4616
1c2cc4ef
JB
46172011-03-08 Juanma Barranquero <lekktu@gmail.com>
4618
4619 * w32xfns.c (select_palette): Check success of RealizePalette against
4620 GDI_ERROR, not zero.
4621
33383987 4622See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4623
4624;; Local Variables:
4625;; coding: utf-8
aac0c6e3
MR
4626;; End:
4627
33383987 4628 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4629
4630 This file is part of GNU Emacs.
4631
4632 GNU Emacs is free software: you can redistribute it and/or modify
4633 it under the terms of the GNU General Public License as published by
4634 the Free Software Foundation, either version 3 of the License, or
4635 (at your option) any later version.
4636
4637 GNU Emacs is distributed in the hope that it will be useful,
4638 but WITHOUT ANY WARRANTY; without even the implied warranty of
4639 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4640 GNU General Public License for more details.
4641
4642 You should have received a copy of the GNU General Public License
4643 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.