* xfaces.c (x_update_menu_appearance): Don't overrun buffer
[bpt/emacs.git] / src / ChangeLog
CommitLineData
62f19c19
PE
12011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 sprintf-related integer and memory overflow issues.
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
2ea16b89
PE
23 * dbusbind.c (xd_signature, Fdbus_register_signal):
24 Do not overrun buffer; instead, report string overflow.
25
9d1df220
PE
26 * dispnew.c (add_window_display_history): Don't overrun buffer.
27 Truncate instead; this is OK since it's just a log.
28
33ef5c64
PE
29 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
30 even if the time zone offset is outlandishly large.
31 Don't mishandle offset == INT_MIN.
32
66c6fdd5
PE
33 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
34 when creating daemon; the previous buffer-overflow check was incorrect.
35
d749b01b
PE
36 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
37 which has the guts of the old verror function.
38
b5cd1905
PE
39 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
40 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
41
c21721cc
PE
42 * font.c (font_unparse_xlfd): Don't blindly alloca long strings.
43 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
44 fits in int, when using sprintf. Use single snprintf to count
45 length of string rather than counting it via multiple sprintfs;
46 that's simpler and more reliable.
47 (APPEND_SPRINTF): New macro.
48 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
49 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
50 sprintf, in case result does not fit in int.
51
c57b67fc
PE
52 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
53 (fontset_from_font): Print it.
54
8a401434
PE
55 * frame.c (tty_frame_count): Now printmax_t, not int.
56 (make_terminal_frame, set_term_frame_name): Print it.
57 (x_report_frame_params): In X, window IDs are unsigned long,
58 not signed long, so print them as unsigned.
59 (validate_x_resource_name): Check for implausibly long names,
60 and don't assume name length fits in 'int'.
61 (x_get_resource_string): Don't blindly alloca invocation name;
62 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
63 not fit in int.
64
84722b3d
PE
65 * gtkutil.c (xg_check_special_colors, xg_set_geometry):
66 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
67
0df02bf3
PE
68 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
69 Use esprintf, not sprintf, in case result does not fit in int.
70
48e30793
PE
71 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
72 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
73 it as a large positive number.
74 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
75 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
76
a66ff6d8
PE
77 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
78 in case result does not fit in int.
79
aca216ff
PE
80 * print.c (float_to_string): Detect width overflow more reliably.
81 (print_object): Make sprintf buffer a bit bigger, to avoid potential
82 buffer overrun. Don't assume list length fits in 'int'. Treat
83 print length of 0 as 0, not as infinity; to be consistent with other
84 uses of print length in this function. Don't overflow print length
85 index. Don't assume hash table size fits in 'long', or that
86 vectorlike size fits in 'unsigned long'.
87
31c286f7
PE
88 * process.c (make_process): Use printmax_t, not int, to format
89 process-name gensyms.
90
80f2e268
PE
91 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
92 to avoid potential buffer overrun.
93
670741ab
PE
94 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
95 if X resource line is longer than 512 bytes.
96
5fc295a4 972011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 98
70c60eb2 99 Integer and memory overflow issues (Bug#9196).
726e0ab1 100
d31850da
PE
101 * doc.c (get_doc_string): Rework so that
102 get_doc_string_buffer_size is the actual buffer size, rather than
103 being 1 less than the actual buffer size; this makes xpalloc more
104 convenient.
105
a69fbedb
PE
106 * image.c (x_allocate_bitmap_record, cache_image):
107 * xselect.c (Fx_register_dnd_atom):
108 Simplify previous changes by using xpalloc.
109
fe5c5d37
PE
110 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
111 since either will do and ptrdiff_t is convenient with xpalloc.
112
0065d054
PE
113 * charset.c (charset_table_size)
114 (struct charset_sort_data.priority): Now ptrdiff_t.
115 (charset_compare): Don't overflow if priorities differ greatly.
116 (Fsort_charsets): Don't assume list length fits in int.
117 Check for size-calculation overflow when allocating sort data.
118 (syms_of_charset): Allocate an initial charset table that is
119 just under 64 KiB, to avoid problems with glibc malloc and mmap.
120
121 * cmds.c (internal_self_insert): Check for size-calculation overflow.
122
123 * composite.h (struct composition.glyph_len): Now int, not unsigned.
124 The actual value is always <= INT_MAX, and leaving it unsigned made
125 overflow checking harder.
126
127 * dispextern.h (struct glyph_matrix.rows_allocated)
128 (struct face_cache.size): Now ptrdiff_t, for convenience in use
129 with xpalloc. The values are still always <= INT_MAX.
130
131 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
132
133 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
134 (SAFE_NALLOCA): New macro.
135
136 * region-cache.c (struct boundary.pos, find_cache_boundary)
137 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
138 (set_cache_region, invalidate_region_cache)
139 (revalidate_region_cache, know_region_cache, region_cache_forward)
140 (region_cache_backward, pp_cache):
141 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
142 so that ptrdiff_t * can be passed to xpalloc.
143 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
144 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
145 (pp_cache): Don't assume cache_len fits in int.
146 * region-cache.h: Adjust extern decls to match.
147
148 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
149 EMACS_INT, since either will do, for xpalloc.
150
151 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
152 (xnmalloc, xnrealloc, xpalloc): New functions.
153
726e0ab1
PE
154 * bidi.c (bidi_shelve_header_size): New constant.
155 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
156 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
157
51f30bc5 158 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
159 * buffer.c (overlays_at, overlays_in, record_overlay_string)
160 (overlay_strings):
161 Don't update size of array until after memory allocation succeeds,
162 because xmalloc/xrealloc may not return.
0065d054
PE
163 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
164 now that we have proper integer overflow checking.
165 (record_overlay_string, overlay_strings): Catch overflows when
166 calculating size of overlay_str_buf.
726e0ab1 167
0065d054
PE
168 * callproc.c (Fcall_process): Check for size overflow when
169 calculating size of args2.
170 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
171 Normally we prefer signed values, but sticking with ptrdiff_t would
172 require adding more-complicated checks.
726e0ab1
PE
173
174 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
175 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
176 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 177 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
178
179 * character.c (Fstring): Check for size-calculation overflow.
180
181 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
182 unnecessary integer overflow. Check for size overflow.
183 (encode_coding_object): Don't update size until xmalloc succeeds.
184
185 * composite.c (get_composition_id): Check for overflow in glyph
186 length calculations.
187
188 Integer and memory overflow fixes for display code.
189 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
190 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
191 (scrolling_window): Check for overflow in size calculations.
192 (line_draw_cost, realloc_glyph_pool, add_row_entry):
193 Don't assume glyph table len fits in int.
194 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
195 (row_table_size): Now ptrdiff_t, not int.
196 (scrolling_window): Avoid overflow in size calculations.
197 Don't update size until allocation succeeds.
198 * fns.c (concat): Check for overflow in size calculations.
199 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
200 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
201 (NEXT_ALMOST_PRIME_LIMIT): New constant.
202
203 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
204 (get_doc_string): Check for size calculation overflow.
205 Don't update size until allocation succeeds.
206 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
207 EMACS_INT, where ptrdiff_t will do.
208 (Fsubstitute_command_keys): Check for string overflow.
209
210 * editfns.c (set_time_zone_rule): Don't assume environment length
211 fits in int.
212 (message_length): Now ptrdiff_t, not int.
213 (Fmessage_box): Don't update size until allocation succeeds.
214 Don't assume message length fits in int.
215 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
216
0065d054
PE
217 * emacs.c (main): Do not reallocate argv, since there is a null at
218 the end that can be overwritten, and this way there's no need to
219 worry about size-calculation overflow.
220 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
221
222 * eval.c (init_eval_once, grow_specpdl): Don't update size until
223 alloc succeeds.
224 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
225
226 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
227 (x_set_scroll_bar_width, x_figure_window_size):
228 Check for integer overflow.
229 (x_set_alpha): Do not assume XINT fits in int.
230
231 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
232 This is for the members text_lines, text_cols, total_lines, total_cols,
233 where the system imposes an 'int' limit.
234
235 * fringe.c (Fdefine_fringe_bitmap):
236 Don't update size until alloc works.
237
238 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
239 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
240
241 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
242 Check for size-calculation overflow.
243 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
244 do, as we prefer signed integers.
245 (id_to_widget.max_size, id_to_widget.used)
246 (xg_store_widget_in_map, xg_remove_widget_from_map)
247 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
248 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
249 Use and return ptrdiff_t, not int.
250 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
251 * gtkutil.h: Change prototypes to match the above.
252
253 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
254 are duplicate now that they've been promoted to lisp.h.
255 (x_allocate_bitmap_record, x_alloc_image_color)
256 (make_image_cache, cache_image, xpm_load):
257 Don't update size until alloc is done.
258 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
259 (x_detect_edges):
3256efce 260 Check for size calculation overflow.
726e0ab1
PE
261 (ct_colors_allocated_max): New constant.
262 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
263 overflow.
3256efce 264
726e0ab1
PE
265 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
266 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
267 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
268 Use ptrdiff_t, not int, to count maps.
269 (read_char_minibuf_menu_prompt): Check for overflow in size
270 calculations. Don't update size until allocation succeeds. Redo
271 calculations to avoid overflow.
272 * keyboard.h: Change prototypes to match the above.
273
274 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
275 to count maps.
276 (current_minor_maps): Check for size calculation overflow.
277 * keymap.h: Change prototypes to match the above.
278
279 * lread.c (read1, init_obarray): Don't update size until alloc done.
280
281 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
282 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
283
726e0ab1
PE
284 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
285 Now ptrdiff_t, not int.
286 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
287 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
288
289 * process.c (Fnetwork_interface_list): Check for overflow
290 in size calculation.
291
292 * region-cache.c (move_cache_gap): Check for size calculation overflow.
293
294 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
295 overflow. Don't bother calling xmalloc when xrealloc will do.
296
297 * search.c (Freplace_match): Check for size calculation overflow.
298 (Fset_match_data): Don't assume list lengths fit in 'int'.
299
300 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
301 for command line length. Do not attempt to address one before the
302 beginning of an array, as that's not portable.
303
304 * term.c (max_frame_lines): Remove; unused.
305 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
306 not int.
307 (encode_terminal_code, calculate_costs): Check for size
308 calculation overflow.
309 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
310 table lengths and related sizes. Don't update size until alloc
311 done. Redo calculations to avoid overflow.
312 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
313
314 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
315 subtracting pointers.
316 (gobble_line): Check for overflow more carefully. Don't update size
317 until alloc done.
318
319 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
320 Don't update size until alloc done.
321 Redo size calculations to avoid overflow.
322 Check for size calculation overflow.
0065d054 323 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
324
325 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
326 Use ptrdiff_t, not int, for sizes.
327 (store_mode_line_noprop_char): Don't update size until alloc done.
328
0065d054
PE
329 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
330 Use ptrdiff_t, not int, for sizes.
331 (Finternal_make_lisp_face, cache_face):
332 Check for size calculation overflow.
333 (cache_face): Treat size calculation overflows as if they were
334 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
335
336 * xfns.c (x_encode_text, x_set_name_internal)
337 (Fx_change_window_property): Use ptrdiff_t, not int, to count
338 sizes, since they can exceed INT_MAX in size. Check for size
339 calculation overflow.
340
0065d054
PE
341 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
342 (xg_select): Check for size calculation overflow.
726e0ab1
PE
343 Don't update size until alloc done.
344
0065d054 345 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 346 as sprintf is limited to int lengths.
1d526e2f 347
252c5ee1
PE
348 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
349 (X_LONG_MIN): New macros.
864d7ce7
PE
350 Use them to make the following changes clearer.
351 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
352 This change doesn't affect the value now, but it may help remind
353 future maintainers not to raise the value too much later.
354 (SELECTION_QUANTUM): Remove, replacing with ...
355 (selection_quantum): ... new function, which avoids overflow.
356 All uses changed.
357 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
358 assumption that selection length fits in 'int'.
359 (x_reply_selection_request, x_handle_selection_request)
360 (x_get_window_property, receive_incremental_selection)
361 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
362 (lisp_data_to_selection_data, clean_local_selection_data):
363 Use ptrdiff_t, not int, to record length of selection.
364 (x_reply_selection_request, x_get_window_property)
365 (receive_incremental_selection, x_property_data_to_lisp):
366 Redo calculations to avoid overflow.
367 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 368 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
369 something.
370 (x_get_window_property, receive_incremental_selection)
371 (lisp_data_to_selection_data, x_property_data_to_lisp):
372 Check for size-calculation overflow.
373 (x_get_window_property, receive_incremental_selection)
374 (lisp_data_to_selection_data, Fx_register_dnd_atom):
375 Don't store size until memory allocation succeeds.
376 (x_get_window_property): Plug memory leak on memory exhaustion.
377 Don't double-block input; malloc is safe here. Don't assume 2**34
378 - 4 fits in unsigned long. Add an xassert to check
379 XGetWindowProperty overflow. Be more careful about overflow
380 calculations, and distinguish size from memory overflow better.
381 (receive_incremental_selection): When tracing, don't assume
382 unsigned int is less than INT_MAX.
383 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
384 harmful) conversions of unsigned short to int.
385 (lisp_data_to_selection_data): Don't assume that integers
386 in the range -65535 through -1 fit in an X unsigned short.
387 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
388 result parameters unless successful. Rely on cons_to_unsigned
389 to report problems with elements; the old code wasn't right anyway.
390 (x_check_property_data): Check for int overflow; we cannot use
391 a wider type due to X limits.
392 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
393
726e0ab1 394 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 395
0065d054
PE
396 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
397 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
398 (x_color_cells): Don't store size until memory allocation succeeds.
399 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 400 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
401 (x_term_init): Don't assume length fits in int (sprintf is limited
402 to int size).
bc18e09d 403
ebfa62c0
PE
404 Use ptrdiff_t for composition IDs.
405 * character.c (lisp_string_width):
406 * composite.c (composition_table_size, n_compositions)
407 (get_composition_id, composition_gstring_from_id):
408 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
409 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
410 * window.c (Frecenter):
411 Use ptrdiff_t, not int, for composition IDs.
412 * composite.c (get_composition_id): Check for integer overflow.
413 * composite.h: Adjust prototypes to match the above changes.
414
d3411f89
PE
415 Use ptrdiff_t for hash table indexes.
416 * category.c (hash_get_category_set):
417 * ccl.c (ccl_driver):
418 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
419 * coding.c (coding_system_charset_list, detect_coding_system):
420 * coding.h (struct coding_system.id):
421 * composite.c (get_composition_id, gstring_lookup_cache):
422 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
423 * image.c (xpm_get_color_table_h):
424 * lisp.h (hash_lookup, hash_put):
425 * minibuf.c (Ftest_completion):
426 Use ptrdiff_t for hash table indexes, not int (which is too
427 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
428 32-bit --with-wide-int hosts).
429
e097a6fa
PE
430 * charset.c (Fdefine_charset_internal): Check for integer overflow.
431 Add a FIXME comment about memory leaks.
432 (syms_of_charset): Don't assume xmalloc returns.
433
5637687f
PE
434 Don't assume that stated character widths fit in int.
435 * character.c (Fchar_width, c_string_width, lisp_string_width):
436 * character.h (CHAR_WIDTH):
437 * indent.c (MULTIBYTE_BYTES_WIDTH):
438 Use sanitize_char_width to avoid undefined and/or bad behavior
439 with outlandish widths.
440 * character.h (sanitize_tab_width): Renamed from sanitize_width,
441 now that we have two such functions. All uses changed.
442 (sanitize_char_width): New inline function.
443
a2271ba2
PE
444 Don't assume that tab-width fits in int.
445 * character.h (sanitize_width): New inline function.
446 (SANE_TAB_WIDTH): New macro.
447 (ASCII_CHAR_WIDTH): Use it.
448 * indent.c (sane_tab_width): Remove. All uses replaced by
449 SANE_TAB_WIDTH (current_buffer).
450 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
451
18c52557
PE
452 * fileio.c: Integer overflow issues with file modes.
453 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
454
caeeedc1
PE
455 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
456 Remove unreachable code.
457 (read_hex, load_charset_map_from_file): Check for integer overflow.
458
50849c52
PE
459 * xterm.c: don't go over XClientMessageEvent limit
460 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
461 (x_send_scroll_bar_event): Likewise. Check that the size does not
462 exceed limits imposed by XClientMessageEvent, as well as the usual
463 ptrdiff_t and size_t limits.
464
b13995db
PE
465 * keyboard.c: Overflow, signedness and related fixes.
466 (make_lispy_movement): Use same integer type in forward decl
467 that is used in the definition.
468 (read_key_sequence, keyremap_step):
469 Change bufsize argument back to int, undoing my 2011-03-30 change.
470 We prefer signed types, and int is wide enough here.
471 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
472 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
473 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
474 length, not size_t. Use ptrdiff_t for index, not int.
475 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
476 possibility of integer overflow.
477
13464394
PE
478 Overflow, signedness and related fixes for images.
479
480 * dispextern.h (struct it.stack[0].u.image.image_id)
481 (struct_it.image_id, struct image.id, struct image_cache.size)
482 (struct image_cache.used, struct image_cache.ref_count):
483 * gtkutil.c (update_frame_tool_bar):
484 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
485 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
486 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
487 * nsmenu.m (update_frame_tool_bar):
488 * xdisp.c (calc_pixel_width_or_height):
489 * xfns.c (image_cache_refcount):
490 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
491 on typical 64-bit hosts.
492
493 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
494 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
495 Omit unnecessary casts to int.
496 (parse_image_spec): Check that integers fall into 'int' range
497 when the callers expect that.
498 (image_ascent): Redo ascent calculation to avoid int overflow.
499 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
500 (lookup_image): Remove unnecessary tests.
501 (xbm_image_p): Locals are now of int, not EMACS_INT,
502 since parse_image_check makes sure they fit into int.
503 (png_load, gif_load, svg_load_image):
504 Prefer int to unsigned where either will do.
505 (tiff_handler): New function, combining the cores of the
506 old tiff_error_handler and tiff_warning_handler. This
507 function is rewritten to use vsnprintf and thereby avoid
508 stack buffer overflows. It uses only the features of vsnprintf
509 that are common to both POSIX and native Microsoft.
510 (tiff_error_handler, tiff_warning_handler): Use it.
511 (tiff_load, gif_load, imagemagick_load_image):
512 Don't assume :index value fits in 'int'.
513 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
514 (imagemagick_load_image): Check that crop parameters fit into
515 the integer types that MagickCropImage accepts. Don't assume
516 Vimagemagick_render_type has a nonnegative value. Don't assume
517 size_t fits in 'long'.
518 (gs_load): Use printmax_t to print the widest integers possible.
519 Check for integer overflow when computing image height and width.
520
c11821d4
EZ
5212011-08-26 Eli Zaretskii <eliz@gnu.org>
522
523 * xdisp.c (redisplay_window): Don't force window start if point
524 will be invisible in the resulting window. (Bug#9324)
525
0c95fcf7
EZ
5262011-08-25 Eli Zaretskii <eliz@gnu.org>
527
528 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
529 the display spec is of the form `(space ...)'.
530 (handle_display_spec): Return the value returned by
531 handle_single_display_spec, not just 1 or zero.
532 (handle_single_display_spec): If the display spec is of the form
533 `(space ...)', and specifies display in the text area, return 2
534 rather than 1.
fee65a97 535 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
536 accurately, and prefer exact match for point under bidi. Don't
537 advance `row' beyond the last row of the window.
0c95fcf7
EZ
538
539 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
540 into disp_prop; all users changed.
541
542 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
543 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
544 for the text covered by the display property.
545
e4ed06f1
CY
5462011-08-25 Chong Yidong <cyd@stupidchicken.com>
547
548 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
549 Change return value to nil.
550 (Frecord_buffer): Delete unused function.
551
f67cdd7f
EZ
5522011-08-24 Eli Zaretskii <eliz@gnu.org>
553
5980d4c6
EZ
554 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
555 buffers, return left-to-right.
8610fe8b
EZ
556 (set_cursor_from_row): Consider candidate row a win if its glyph
557 represents a newline and point is on that newline. Fixes cursor
558 positioning on the newline at EOL of R2L text within L2R
559 paragraph, and vice versa.
560 (try_cursor_movement): Check continued rows, in addition to
561 continuation rows. Fixes unwarranted scroll when point enters a
562 continued line of R2L text within an L2R paragraph, or vice versa.
563 (cursor_row_p): Consider the case of point being equal to
564 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
565 from the end of a short line to the beginning of a continued line
566 of R2L text within L2R paragraph.
567 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
568 composed characters.
5980d4c6 569
f67cdd7f
EZ
570 * bidi.c (bidi_check_type): Use xassert.
571 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
572 members.
573
bca633fb
EZ
5742011-08-23 Eli Zaretskii <eliz@gnu.org>
575
576 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
577 a character.
578
4a5885a7
CY
5792011-08-23 Chong Yidong <cyd@stupidchicken.com>
580
581 * nsfont.m (ns_otf_to_script): Fix typo.
582
0902a04e
KH
5832011-08-22 Kenichi Handa <handa@m17n.org>
584
585 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
586 extra slot even if the purpose is char-code-property-table.
587
1a2e6670
EZ
5882011-08-23 Eli Zaretskii <eliz@gnu.org>
589
8ddde651
EZ
590 * xdisp.c (redisplay_window): When computing centering_position,
591 account for the height of the header line. (Bug#8874)
592
425cc014
EZ
593 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
594 instead of CHAR_TO_BYTE. Fixes a crash when a completion
595 candidate is selected by the mouse, and that candidate has a
596 composed character under the mouse.
597
1a2e6670
EZ
598 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
599 coordinates reported by pos-visible-in-window-p for a composed
600 character in column zero.
601
8b76d6f8
SM
6022011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
603
604 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
605
dac347dd
EZ
6062011-08-22 Eli Zaretskii <eliz@gnu.org>
607
608 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
609 consider it a hit if to_charpos is anywhere in the range of the
610 composed buffer positions.
611
e013fb34
CY
6122011-08-22 Chong Yidong <cyd@stupidchicken.com>
613
614 * image.c (gif_load): Don't assume that each subimage has the same
615 dimensions as the base image. Handle disposal method that is
616 "undefined" by the gif spec (Bug#9335).
617
bd1ba3e8
CY
6182011-08-20 Chong Yidong <cyd@stupidchicken.com>
619
620 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 621 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 622
54a1215b
EZ
6232011-08-19 Eli Zaretskii <eliz@gnu.org>
624
823564e5
EZ
625 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
626 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
627 from an Org mode buffer to a Speedbar frame.
628
54a1215b
EZ
629 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
630 a composition, take its buffer position from IT->cmp_it.charpos.
631 Fixes cursor positioning at the beginning of a line that begins
632 with a composed character.
633
9778ebcc
EZ
6342011-08-18 Eli Zaretskii <eliz@gnu.org>
635
0be6ee06
EZ
636 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
637 character bidirectional type, use STRONG_L instead. Fixes crashes
638 in a buffer produced by `describe-categories'.
639
9778ebcc
EZ
640 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
641 members before the level stack, so they would be saved and
642 restored when copying iterator state. Fixes incorrect reordering
643 around TABs covered by display properties.
644
156bffbe
AS
6452011-08-18 Andreas Schwab <schwab@linux-m68k.org>
646
647 * process.c (Fnetwork_interface_list): Correctly determine buffer
648 size.
649
72ad093b
CY
6502011-08-17 Chong Yidong <cyd@stupidchicken.com>
651
652 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
653 (internal_condition_case_2, internal_condition_case_n):
654 Remove unnecessary aborts (Bug#9081).
72ad093b 655
35774242
EZ
6562011-08-17 Eli Zaretskii <eliz@gnu.org>
657
658 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
659 has no `load' handler, try opening the file locally. (Bug#9311)
660
db76dd85
KB
6612011-08-16 Ken Brown <kbrown@cornell.edu>
662
663 * gmalloc.c: Expand comment.
664
b215eee5
EZ
6652011-08-16 Eli Zaretskii <eliz@gnu.org>
666
667 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
668 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
669
a4579d33
KB
6702011-08-16 Ken Brown <kbrown@cornell.edu>
671
672 Fix memory allocation problems in Cygwin build (Bug#9273).
673
674 * unexcw.c ( __malloc_initialized): Declare external variable.
675 (fixup_executable): Force the dumped emacs to reinitialize malloc.
676
8b76d6f8
SM
677 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
678 New variables.
a4579d33
KB
679 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
680 dumped emacs.
681 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
682 in the static heap.
683 [CYGWIN] (special_realloc): New function.
684 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
685 requests to realloc storage in the static heap.
686
3ebec551
PE
6872011-08-15 Paul Eggert <eggert@cs.ucla.edu>
688
689 * bidi.c (bidi_initialize): Remove unused local.
690
9fd8be00
EZ
6912011-08-15 Eli Zaretskii <eliz@gnu.org>
692
474a8465
EZ
693 * biditype.h: File removed.
694
695 * bidimirror.h: File removed.
696
697 * deps.mk (bidi.o): Remove biditype.h and
698 bidimirror.h.
699
700 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
701 bidimirror.h.
702
703 * dispextern.h: Fix a typo in the comment to bidi_type_t.
704
705 * chartab.c: Improve commentary for the uniprop_table API.
706
32413314
EZ
707 * bidi.c (bidi_paragraph_init): Support zero value of
708 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
709 (bidi_initialize): Use uniprop_table instead of including
710 biditype.h and bidimirror.h.
32413314 711
9fd8be00
EZ
712 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
713 coordinates of the iterator when restoring from ppos_it.
714 (Bug#9296)
715
5cf2b69b
KH
7162011-08-14 Kenichi Handa <handa@m17n.org>
717
718 * process.c (create_process): Call setup_process_coding_systems
72ad093b 719 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 720
daf17d00
EZ
7212011-08-14 Eli Zaretskii <eliz@gnu.org>
722
723 * xdisp.c (move_it_in_display_line_to): Don't invoke
724 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
725 ppos_it. Fixes vertical cursor motion when line beginning is
726 covered by an image. (Bug#9296)
727
08e3161a
JD
7282011-08-14 Jan Djärv <jan.h.d@swipnet.se>
729
730 * nsterm.h (ns_run_ascript): Declare.
731 (NSAPP_DATA2_RUNASSCRIPT): Define.
732
733 * nsfns.m (as_script, as_result, as_status): New static variables.
734 (ns_run_ascript): New function.
735 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
736 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
737 the event loop. Get status from as_status (Bug#7276).
738
739 * nsterm.m (sendEvent): If event is NSApplicationDefined and
740 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
741 the event loop (Bug#7276).
742
a3720aa2
AS
7432011-08-14 Andreas Schwab <schwab@linux-m68k.org>
744
745 * gnutls.c (QCgnutls_bootprop_priority)
746 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
747 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
748 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
749 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
750 (QCgnutls_bootprop_verify_hostname_error)
751 (QCgnutls_bootprop_callbacks_verify): Rename from
752 Qgnutls_bootprop_..., all uses changed.
753
754 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
755 uses changed.
756
0a0d27fb
PE
7572011-08-14 Paul Eggert <eggert@cs.ucla.edu>
758
19d5c50c
PE
759 * xfaces.c (Qframe_set_background_mode): Now static.
760 * dispextern.h (Qframe_set_background_mode): Remove decl.
761
0a0d27fb
PE
762 * process.c (Fnetwork_interface_info): Declare local only if needed.
763
377538cb
JD
7642011-08-13 Jan Djärv <jan.h.d@swipnet.se>
765
766 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
767 (Fnetwork_interface_list): Allocate in increments of bytes instead
768 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
769 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
770 sockaddr.
771 (struct ifflag_def): notrailers is smart on OSX.
772 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
773 Get hardware address with getifaddrs if available.
774
08fff70c
EZ
7752011-08-12 Eli Zaretskii <eliz@gnu.org>
776
777 * xdisp.c (iterate_out_of_display_property): xassert that
778 IT->position is set to within IT->object's boundaries. Break from
779 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
780 when IT->position is set up wrongly due to some bug.
781 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
782 (push_display_prop): Allow GET_FROM_STRING as IT->method on
783 entry. Force push_it to save on the stack the current
784 buffer/string position, to be restored by pop_it. Fix flags in
785 the iterator structure wrt the object coming from a display
786 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
787 properties. (Bug#9284)
788
7be1c708 7892011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 790
7be1c708
CY
791 * fontset.c (fontset_get_font_group): Add proper type checks.
792 (Bug#9172)
aac0c6e3 793
7be1c708 7942011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 795
7be1c708
CY
796 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
797 and LC_VERSION_MIN_MACOSX.
798 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
799 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 800
97bb72a6
EZ
8012011-08-08 Eli Zaretskii <eliz@gnu.org>
802
803 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
804 no-display-properties-and-no-overlays under bidi display.
805 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 806 properties and overlays.
97bb72a6 807
d5617611
CY
8082011-08-08 Chong Yidong <cyd@stupidchicken.com>
809
37e11a63
CY
810 * editfns.c (Fset_time_zone_rule): Document relationship with the
811 setenv function.
812
d5617611
CY
813 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
814 the font entity extracted from the cache (Bug#8109).
815
58872834
CY
8162011-08-07 Chong Yidong <cyd@stupidchicken.com>
817
818 * composite.c (autocmp_chars): Don't reset point. That is done by
819 restore_point_unwind (Bug#5984).
820
75bfc667
JL
8212011-08-07 Juri Linkov <juri@jurta.org>
822
823 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
824 to show the arg `TIME' instead of `TIMEVAL'.
825
d1410150
EZ
8262011-08-06 Eli Zaretskii <eliz@gnu.org>
827
828 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
829 display property strides EOL and includes a newline, as in
830 longlines-mode. (Bug#9254)
75b771e4
EZ
831 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
832 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
833
834 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
835 is non-zero, even if the data buffer is NULL. Fixes a crash in
836 vertical-motion with longlines-mode. (Bug#9254)
837
35928349
EZ
8382011-08-05 Eli Zaretskii <eliz@gnu.org>
839
ec7cc85b
EZ
840 * bidi.c <bidi_cache_total_alloc>: Now static.
841 (bidi_initialize): Initialize bidi_cache_total_alloc.
842
8b76d6f8 843 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
844 cache. (Bug#9221)
845
846 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
847 amount allocated this far in `bidi_cache_total_alloc'.
848 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
849 non-zero, only free the data buffer without restoring the cache
850 contents. All callers changed.
851
852 * dispextern.h (bidi_unshelve_cache): Update prototype.
853
854 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
855 (move_it_in_display_line, move_it_to)
856 (move_it_vertically_backward, move_it_by_lines): Replace the call
857 to xfree to an equivalent call to bidi_unshelve_cache.
858 (move_it_in_display_line_to): Fix logic of returning
412b6358 859 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 860
e2e2423b
EZ
8612011-08-05 Eli Zaretskii <eliz@gnu.org>
862
863 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
864 came from a string character with a `cursor' property. (Bug#9229)
865
ae9e757a
JD
8662011-08-04 Jan Djärv <jan.h.d@swipnet.se>
867
868 * Makefile.in (LIB_PTHREAD): New variable.
869 (LIBES): Add LIB_PTHREAD (Bug#9216).
870
871 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
872 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
873
213bd7f2
AS
8742011-08-04 Andreas Schwab <schwab@linux-m68k.org>
875
876 * regex.c (re_iswctype): Remove some redundant boolean
877 conversions.
878
99aaf75f
JD
8792011-08-04 Jan Djärv <jan.h.d@swipnet.se>
880
881 * xterm.c (x_find_topmost_parent): New function.
882 (x_set_frame_alpha): Find topmost parent window with
883 x_find_topmost_parent and set the property there also (bug#9181).
884 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
885
c74e9d86
PE
8862011-08-04 Paul Eggert <eggert@cs.ucla.edu>
887
888 * callproc.c (Fcall_process): Avoid vfork clobbering
889 the local vars buffer, coding_systems, current_dir.
890
640c8776
SM
8912011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
892
893 * keymap.c (Fmake_composed_keymap): Move to subr.el.
894
f26d0e4c
PE
8952011-08-03 Paul Eggert <eggert@cs.ucla.edu>
896
8a10d76c
PE
897 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
898 so that it is not optimized away.
899
f26d0e4c
PE
900 * xdisp.c (compute_display_string_pos): Remove unused local.
901
55439c61
EZ
9022011-08-02 Eli Zaretskii <eliz@gnu.org>
903
904 Fix slow cursor motion and scrolling in large buffers with
905 selective display, like Org Mode buffers. (Bug#9218)
906
907 * dispextern.h (struct bidi_it): New member disp_prop_p.
908
909 * xdisp.c: Remove one-slot cache of display string positions.
910 (compute_display_string_pos): Accept an additional argument
911 DISP_PROP_P; callers changed. Scan at most 5K characters forward
912 for a display string or property. If found, set DISP_PROP_P
913 non-zero.
914
915 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
916 DISP_PROP_P, and pass it to compute_display_string_pos.
917 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
918 non-zero. All callers of bidi_fetch_char changed.
919
fb33fa43
SM
9202011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
921
922 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
923
b099e063
DM
9242010-12-03 Don March <don@ohspite.net>
925
926 * keymap.c (Fdefine_key): Fix non-prefix key error message when
927 last character M-[char] is translated to ESC [char] (bug#7541).
928
5cc7f7af
KH
9292011-08-02 Kenichi Handa <handa@m17n.org>
930
d0fffa3f 931 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
932
933 * chartab.c (uniprop_table): Make it non-static.
934
525d5e6e
EZ
9352011-08-01 Eli Zaretskii <eliz@gnu.org>
936
937 * xdisp.c (forward_to_next_line_start): Accept additional argument
938 BIDI_IT_PREV, and store into it the state of the bidi iterator had
939 on the newline.
940 (reseat_at_next_visible_line_start): Use the bidi iterator state
941 returned by forward_to_next_line_start to restore the state of
942 it->bidi_it after backing up to previous newline. (Bug#9212)
943
31011111
AS
9442011-07-30 Andreas Schwab <schwab@linux-m68k.org>
945
946 * regex.c (re_comp): Protoize.
947 (re_exec): Fix return type.
948 (regexec): Fix type of `ret'. (Bug#9203)
949
e5d76069
PE
9502011-07-29 Paul Eggert <eggert@cs.ucla.edu>
951
952 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
953 This is needed if max-image-size is a floating-point number.
954
9a79b20c
AS
9552011-07-28 Andreas Schwab <schwab@linux-m68k.org>
956
957 * print.c (print_object): Print empty symbol as ##.
958
959 * lread.c (read1): Read ## as empty symbol.
960
d8c2fa78
AA
9612011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
962
963 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
964 setting frame foreground color (Bug#9175).
965 (x_set_background_color): Likewise.
966
ffe57a7a
AA
967 * nsmenu.m (-setText): Size tooltip dimensions precisely to
968 contents (Bug#9176).
969 (EmacsTooltip -init): Remove bezels and add shadows to
970 tooltip windows.
971
bf3492a5
AA
972 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
973 or scroll bar (Bug#8470).
974
d55e9c53
AA
975 * nsfont.m (nsfont_open): Remove assignment to voffset and
976 unnecessary vars hshink, expand, hd, full_height, min_height.
977 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
978
979 * nsterm.h (nsfont_info): Remove voffset field.
980
d8c2fa78 9812011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
982
983 Implement strike-through and overline on NextStep (Bug#8863).
984
985 * nsfont.m (nsfont_open): Use underline position provided by font,
986 instead of hard-coded value of 2.
987 (nsfont_draw): Call ns_draw_text_decoration instead.
988
989 * nsterm.h: Add declaration for ns_draw_text_decoration.
990
991 * nsterm.m (ns_draw_text_decoration): New function for drawing
992 underline, overline, and strike-through.
993 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
994 ns_draw_text_decoration. Change treatment of cursor drawing to
995 accomodate underlining, etc.
996
4cc60b9b
EZ
9972011-07-28 Eli Zaretskii <eliz@gnu.org>
998
bc7ece87
EZ
999 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1000 default.
4cc60b9b 1001
476371c4
PE
10022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1003
66606eea
PE
1004 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1005 Without this fix, if a signal arrives just after memory fills up,
1006 'malloc' might be invoked reentrantly.
1007
476371c4
PE
1008 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1009 In other words, assume that every image size is allowed, on non-X
1010 hosts. This assumption is probably wrong, but it lets Emacs compile.
1011
f3fcc40d
AS
10122011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1013
1014 * regex.c (re_iswctype): Convert return values to boolean.
1015
350c992f
EZ
10162011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1017
1018 * xdisp.c (compute_display_string_pos): Don't use cached display
1019 string position if the buffer had its restriction changed.
1020 (Bug#9184)
1021
5266b4bb
PE
10222011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1023
1024 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1025
2573a837 10262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1027
41f55ccd 1028 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1029
39e378da
PE
1030 * bidi.c: Integer size and overflow fixes.
1031 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1032 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1033 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1034 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1035 (bidi_find_other_level_edge):
1036 Use ptrdiff_t instead of EMACS_INT where either will do.
1037 This works better on 32-bit hosts configured --with-wide-int.
1038 (bidi_cache_ensure_space): Check for size-calculation overflow.
1039 Use % rather than repeated addition, for better worst-case speed.
1040 Don't set bidi_cache_size until after xrealloc returns, because it
1041 might not return.
1042 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1043 (bidi_cache_ensure_space): Also check that the bidi cache size
1044 does not exceed that of the largest Lisp string or buffer. See Eli
1045 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1046
5e927815
PE
1047 * alloc.c (__malloc_size_t): Remove.
1048 All uses replaced by size_t. See Andreas Schwab's note
1049 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1050
ca4aa935
PE
1051 * image.c: Improve checking for integer overflow.
1052 (check_image_size): Assume that f is nonnull, since
1053 it is always nonnull in practice. This is one less thing to
1054 worry about when checking for integer overflow later.
1055 (x_check_image_size): New function, which checks for integer
1056 overflow issues inside X.
1057 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1058 This removes the need for a memory_full check.
1059 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1060 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1061 (xbm_read_bitmap_data): Change locals back to 'int', since
1062 their values must fit in 'int'.
1063 (xpm_load_image, png_load, tiff_load):
1064 Invoke x_create_x_image_and_pixmap earlier,
1065 to avoid much needless work if the image is too large.
1066 (tiff_load): Treat overly large images as if
1067 x_create_x_image_and_pixmap failed, not as malloc failures.
1068 (gs_load): Use x_check_image_size.
1069
5f8f9cc2
PE
1070 * gtkutil.c: Omit integer casts.
1071 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1072 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1073
5adf60bc
PE
1074 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1075
c8907a93
PE
1076 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1077 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1078 would wrongly return t on a 64-bit host.
1079
e3c25c68
PE
1080 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1081 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1082 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1083 and therefore cause GCC to emit a bogus diagnostic in some cases.
1084
3f791afe
PE
1085 * image.c: Integer signedness and overflow and related fixes.
1086 This is not an exhaustive set of fixes, but it's time to
1087 record what I've got.
1088 (lookup_pixel_color, check_image_size): Remove redundant decls.
1089 (check_image_size): Don't assume that arbitrary EMACS_INT values
1090 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1091 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1092 (tiff_load, imagemagick_load_image):
1093 Check for overflow in size calculations.
1094 (x_create_x_image_and_pixmap): Remove unnecessary test for
1095 xmalloc returning NULL; that can't happen.
1096 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1097 (xpm_color_bucket): Use better integer hashing function.
1098 (xpm_cache_color): Don't possibly over-allocate memory.
1099 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1100 (gif_memory_source):
1101 Use ptrdiff_t, not int or size_t, to record sizes.
1102 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1103 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1104 either works, as we prefer signed integers.
1105 (tiff_read_from_memory, tiff_write_from_memory):
1106 Return tsize_t, not size_t, since that's what the TIFF API wants.
1107 (tiff_read_from_memory): Don't fail simply because the read would
1108 go past EOF; instead, return a short read.
1109 (tiff_load): Omit no-longer-needed casts.
1110 (Fimagemagick_types): Don't assume size fits into 'int'.
1111
3cc5a532
PE
1112 Improve hashing quality when configured --with-wide-int.
1113 * fns.c (hash_string): New function, taken from sxhash_string.
1114 Do not discard information about ASCII character case; this
1115 discarding is no longer needed.
1116 (sxhash-string): Use it. Change sig to match it. Caller changed.
1117 * lisp.h: Declare it.
1118 * lread.c (hash_string): Remove, since we now use fns.c's version.
1119 The fns.c version returns a wider integer if --with-wide-int is
1120 specified, so this should help the quality of the hashing a bit.
1121
b312a492
PE
1122 * emacs.c: Integer overflow minor fix.
1123 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1124 Define only if GNU_LINUX.
1125 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1126
dfd153ae
PE
1127 * dispnew.c: Integer signedness and overflow fixes.
1128 Remove unnecessary forward decls, that were a maintenance hassle.
1129 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1130 All uses changed.
1131 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1132 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1133 (prepare_desired_row, line_draw_cost):
1134 Use int, not unsigned, where either works.
1135 (save_current_matrix, restore_current_matrix):
1136 Use ptrdiff_t, not size_t, where either works.
1137 (init_display): Check for overflow more accurately, and without
1138 relying on undefined behavior.
1139
a81d11a3
PE
1140 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1141 Remove, replacing with the new symbols in lisp.h. All uses changed.
1142 * fileio.c (make_temp_name):
1143 * filelock.c (lock_file_1, lock_file):
1144 * xdisp.c (message_dolog):
1145 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1146 Use pMd etc. instead.
1147 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1148 replacing the pWIDE etc. symbols removed from editfns.c.
1149
3300e6fd
PE
1150 * keyboard.h (num_input_events): Now uintmax_t.
1151 This is (very slightly) less likely to mess up due to wraparound.
1152 All uses changed.
1153
fd05c7e9
PE
1154 * buffer.c: Integer signedness fixes.
1155 (alloc_buffer_text, enlarge_buffer_text):
1156 Use ptrdiff_t rather than size_t when either will do, as we prefer
1157 signed integers.
1158
903fe15d
PE
1159 * alloc.c: Integer signedness and overflow fixes.
1160 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1161 (__malloc_size_t): Default to size_t, not to int.
1162 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1163 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1164 Prefer ptrdiff_t to size_t when either would do, as we prefer
1165 signed integers.
1166 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1167 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1168 Now const. Initialize with values that are in range even if char
1169 is signed.
1170 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1171 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1172 These functions do the right thing with sizes > 2**32.
1173 (check_depth): Now ptrdiff_t, not int.
1174 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1175 Adjust to new way of storing sizes. Check for size overflow bugs
1176 in rest of code.
1177 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1178 slightly wrong anyway, as it missed one instance of
1179 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1180 (refill_memory_reserve): Omit needless cast to size_t.
1181 (mark_object_loop_halt): Mark as externally visible.
1182
ac82cc6a
PE
1183 * xselect.c: Integer signedness and overflow fixes.
1184 (Fx_register_dnd_atom, x_handle_dnd_message):
1185 Use ptrdiff_t, not size_t, since we prefer signed.
1186 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1187 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1188 x_dnd_atoms_size and x_dnd_atoms_length.
1189
c2d1e36d
PE
1190 * doprnt.c: Prefer signed to unsigned when either works.
1191 * eval.c (verror):
1192 * doprnt.c (doprnt):
1193 * lisp.h (doprnt):
1194 * xdisp.c (vmessage):
1195 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1196 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1197 prefer signed arithmetic to avoid comparison confusion.
1198 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1199 but is a bit tricky.
1200
0e926e56
PE
1201 Assume freestanding C89 headers, string.h, stdlib.h.
1202 * data.c, doprnt.c, floatfns.c, print.c:
1203 Include float.h unconditionally.
1204 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1205 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1206 * regex.c: Likewise for stddef.h, string.h.
1207 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1208 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1209 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1210 (STDC_HEADERS): Remove obsolete defines.
1211 * sysdep.c: Include limits.h unconditionally.
1212
9cfdb3ec
PE
1213 Assume support for memcmp, memcpy, memmove, memset.
1214 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1215 * regex.c (memcmp, memcpy):
1216 Remove; we assume C89 now.
1217
1218 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1219 (__malloc_safe_bcopy): Remove; no longer needed.
1220
cf950e6b 1221 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1222 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1223 well either way, and we prefer signed to unsigned.
1224
dbf38e02
LMI
12252011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1226
1227 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1228 closes the connection while we're reading (bug#9182).
1229
d6f0886c
JD
12302011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1231
1232 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1233 are specified (Bug#9168).
1234
2eb1f9e6
PE
12352011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1236
1237 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1238 Found by GCC static checking and --with-wide-int on a 32-bit host.
1239
22381272 12402011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1241
1242 * xdisp.c (compute_display_string_pos): Fix logic of caching
1243 previous display string position. Initialize cached_prev_pos to
1244 -1. Fixes slow-down at the beginning of a buffer.
1245
f25e39b4
EZ
12462011-07-24 Eli Zaretskii <eliz@gnu.org>
1247
1248 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1249 for attrs[LFACE_FONTSET_INDEX].
1250
04c4b52e
PE
12512011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1252
1253 * xml.c (parse_region): Remove unused local
1254 that was recently introduced.
1255
c1734fbd
EZ
12562011-07-23 Eli Zaretskii <eliz@gnu.org>
1257
be18c5a5
EZ
1258 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1259 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1260
c1734fbd
EZ
1261 * xdisp.c (move_it_in_display_line_to): Record the best matching
1262 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1263 exit if none of the characters scanned was an exact match.
1264 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1265 when exact match is impossible due to invisible text, and the
1266 lines are truncated.
1267
a258d627
JD
12682011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1269
1270 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1271 for OSX >= 10.7.
1272
b6d5a689
EZ
12732011-07-22 Eli Zaretskii <eliz@gnu.org>
1274
0f74f785
EZ
1275 Fix a significant slow-down of cursor motion with C-n, C-p,
1276 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1277 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1278 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1279 (next_element_from_buffer): Call compute_stop_pos_backwards to
1280 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1281 base_level_stop.
1282 (reseat): Don't look for prev_stop, as that could mean a very long
1283 run.
1284 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1285 <cached_disp_overlay_modiff>: Cache for last found display string
1286 position.
551918c1 1287 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1288 about the same buffer in the same area of character positions, and
1289 the buffer wasn't changed since the time the display string
1290 position was cached.
551918c1 1291
b2d0c91a
EZ
12922011-07-22 Eli Zaretskii <eliz@gnu.org>
1293
1294 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1295 is an integer, which is important for empty lines. (Bug#9149)
1296
043604ee
CY
12972011-07-22 Chong Yidong <cyd@stupidchicken.com>
1298
1299 * frame.c (Fmodify_frame_parameters): In tty case, update the
1300 default face if necessary (Bug#4238).
1301
da4adb04
CY
13022011-07-21 Chong Yidong <cyd@stupidchicken.com>
1303
1304 * editfns.c (Fstring_to_char): No need to explain what a character
1305 is in the docstring (Bug#6576).
1306
9abd0532
LMI
13072011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1308
1309 * xml.c (parse_region): Make sure we always return a tree.
1310
36881d16
HK
13112011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1312
1313 * xml.c (parse_region): If a document contains only comments,
1314 return that, too.
1315
1e98674d
LMI
13162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1317
1318 * xml.c (make_dom): Return comments, too.
1319
590bd467
PE
13202011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1321
1322 Port to OpenBSD.
1323 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1324 and the surrounding thread.
1325 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1326 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1327 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1328 timer goes off.
1329 * s/openbsd.h (BROKEN_SIGIO): Define.
1330 * unexelf.c (unexec) [__OpenBSD__]:
1331 Don't update the .mdebug section of the Alpha COFF symbol table.
1332
f41628b2
LMI
13332011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1334
1335 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1336 (bug#8460).
1337
b59b67c5
PE
13382011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1339
15e3a074
PE
1340 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1341 This fixes some race conditions on the permissions of any newly
1342 created file.
1343
41bed37d
PE
1344 * alloc.c (valid_pointer_p): Use pipe, not open.
1345 This fixes some permissions issues when debugging.
1346
b59b67c5
PE
1347 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1348 If fchown fails to set both uid and gid, try to set just gid,
1349 as that is sometimes allowed. Adjust the file's mode to eliminate
1350 setuid or setgid bits that are inappropriate if fchown fails.
1351
925a6be7
SM
13522011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1353
1354 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1355 to compare Lisp_Objects.
1356 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1357 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1358 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1359
52968808
AS
13602011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1361
0a6a104b
AS
1362 * lread.c (read_integer): Unread even EOF character.
1363 (read1): Likewise. Properly record start position of symbol.
1364
52968808
AS
1365 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1366 symbol character follows.
1367
9e381cdd
PE
13682011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1371 This works around a problem with the previous change to Fcopy_file.
1372 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1373 and without this change, GCC might complain about discarding
1374 fchown's return value.
1375
b5641435
JB
13762011-07-16 Juanma Barranquero <lekktu@gmail.com>
1377
1378 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1379
a8031457
PE
13802011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1381
1382 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1383
dd889327
LMI
13842011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1385
750c33f7
LMI
1386 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1387 it's used from the C level.
1388
dd889327
LMI
1389 * process.c: Use the same condition for POLL_FOR_INPUT in both
1390 keyboard.c and process.c (bug#1858).
1391
87e86684
LM
13922011-07-09 Lawrence Mitchell <wence@gmx.li>
1393
1394 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1395 (Fgnutls_boot): Use it.
1396
64348f40
AS
13972011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1398
1399 * doc.c (Fsubstitute_command_keys): Revert last change.
1400
1d698799
LMI
14012011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1402
f863868c
LMI
1403 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1404 quotes the next character, and doesn't affect other longer
1405 sequences (bug#8935).
1406
1d698799
LMI
1407 * lread.c (syms_of_lread): Clarify that is isn't only
1408 `eval-buffer' and `eval-defun' that's affected by
1409 `lexical-binding' (bug#8460).
1410
aa4b6df6
EZ
14112011-07-15 Eli Zaretskii <eliz@gnu.org>
1412
1413 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1414 bidi redisplay when a line includes both an image and is
1415 truncated.
1416
5d856da6
PE
14172011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1418
ad6042bb
PE
1419 Fix minor problems found by static checking.
1420 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1421 (elsz): Now a signed constant, not a size_t var. We prefer signed
1422 types to unsigned, to avoid integer comparison confusion. Without
1423 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1424 "cannot optimize loop, the loop counter may overflow", a symptom
1425 of the confusion.
f00bbb22 1426 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1427 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1428
6468f31c
LMI
14292011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1430
49080b10
LMI
1431 * search.c (Fre_search_backward): Mention `case-fold-search' in
1432 all the re_search_* functions (bug#8138).
1433
6468f31c
LMI
1434 * keyboard.c (Fopen_dribble_file): Document when the file is
1435 closed (bug#8056).
1436
c965adc5
EZ
14372011-07-14 Eli Zaretskii <eliz@gnu.org>
1438
df9733bf
EZ
1439 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1440 bidi_cache_idx.
1441
0bb23927
EZ
1442 Support bidi reordering of display and overlay strings.
1443 * xdisp.c (compute_display_string_pos)
1444 (compute_display_string_end): Accept additional argument STRING.
1445 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1446 (reseat_to_string): Initialize bidi_it->string.s and
1447 bidi_it->string.schars.
1448 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1449 NULL (avoids a crash in bidi_paragraph_init).
1450 Initialize itb.string.lstring.
0bb23927
EZ
1451 (init_iterator): Call bidi_init_it only of a valid
1452 buffer position was specified. Initialize paragraph_embedding to
1453 L2R.
1454 (reseat_to_string): Initialize the bidi iterator.
1455 (display_string): If we need to ignore text properties of
1456 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1457 original value of -1 will not work with bidi.)
1458 (compute_display_string_pos): First arg is now struct
1459 `text_pos *'; all callers changed. Support display properties on
1460 Lisp strings.
1461 (compute_display_string_end): Support display properties on Lisp
1462 strings.
1463 (init_iterator, reseat_1, reseat_to_string): Initialize the
1464 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1465 when iterating on a string not from display properties).
640c8776
SM
1466 (compute_display_string_pos, compute_display_string_end):
1467 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1468 arrow keys.
1469 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1470 base_level_stop; instead, set base_level_stop to BEGV.
1471 Fixes crashes in vertical-motion.
0bb23927
EZ
1472 (next_element_from_buffer): Improve commentary for when
1473 the iterator is before prev_stop.
1474 (init_iterator): Initialize bidi_p from the default value of
1475 bidi-display-reordering, not from buffer-local value. Use the
1476 buffer-local value only if initializing for buffer iteration.
1477 (handle_invisible_prop): Support invisible properties on strings
1478 that are being bidi-reordered.
1479 (set_iterator_to_next): Support bidi reordering of C strings and
1480 Lisp strings.
1481 (next_element_from_string): Support bidi reordering of Lisp
1482 strings.
1483 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1484 (display_string): Support display of R2L glyph rows.
1485 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1486 (init_iterator): Don't initialize it->bidi_p for strings
1487 here.
1488 (reseat_to_string): Initialize it->bidi_p for strings here.
1489 (next_element_from_string, next_element_from_c_string)
1490 (next_element_from_buffer): Add xassert's for correspondence
1491 between IT's object being iterated and it->bidi_it.string
1492 structure.
1493 (face_before_or_after_it_pos): Support bidi iteration.
1494 (next_element_from_c_string): Handle the case of the first string
1495 character that is not the first one in the visual order.
1496 (get_visually_first_element): New function, refactored from common
1497 parts of next_element_from_buffer, next_element_from_string, and
1498 next_element_from_c_string.
1499 (tool_bar_lines_needed, redisplay_tool_bar)
1500 (display_menu_bar): Force left-to-right direction. Add a FIXME
1501 comment for making that be controlled by a user option.
1502 (push_it, pop_it): Save and restore the state of the
1503 bidi iterator. Save and restore the bidi_p flag.
1504 (pop_it): Iterate out of display property for string iteration as
1505 well.
1506 (iterate_out_of_display_property): Support iteration over strings.
1507 (handle_single_display_spec): Set up it->bidi_it for iteration
1508 over a display string, and call bidi_init_it.
1509 (handle_single_display_spec, next_overlay_string)
1510 (get_overlay_strings_1, push_display_prop): Set up the bidi
1511 iterator for displaying display or overlay strings.
1512 (forward_to_next_line_start): Don't use the shortcut if
1513 bidi-iterating.
1514 (back_to_previous_visible_line_start): If handle_display_prop
1515 pushed the iterator stack, restore the internal state of the bidi
1516 iterator by calling bidi_pop_it same number of times.
1517 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1518 and we are bidi-iterating, don't decrement the iterator position;
1519 instead, set the first_elt flag in the bidi iterator, to produce
1520 the same effect.
1521 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1522 (push_display_prop): xassert that we are iterating a buffer.
1523 (push_it, pop_it): Save and restore paragraph_embedding member.
1524 (handle_single_display_spec, next_overlay_string)
1525 (get_overlay_strings_1, reseat_1, reseat_to_string)
1526 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1527 correctly. Don't assume unibyte strings are not bidi-reordered.
1528 (compute_display_string_pos)
1529 (compute_display_string_end): Fix handling the case of C string.
1530 (push_it, pop_it): Save and restore from_disp_prop_p.
1531 (handle_single_display_spec, push_display_prop): Set the
1532 from_disp_prop_p flag.
1533 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1534 (pop_it): Call iterate_out_of_display_property only if we are
1535 popping after iteration over a string that came from a display
1536 property. Fix a typo in popping stretch info. Add an assertion
1537 for verifying that the iterator position is in sync with the bidi
1538 iterator.
1539 (handle_single_display_spec, get_overlay_strings_1)
1540 (push_display_prop): Fix initialization of paragraph direction for
1541 string when that of the parent object is not yet determined.
1542 (reseat_1): Call bidi_init_it to resync the bidi
1543 iterator with IT's position. (Bug#7616)
1544 (find_row_edges): If ROW->start.pos gives position
1545 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1546 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1547 Reset the from_disp_prop_p flag.
1548 (SAVE_IT, RESTORE_IT): New macros.
1549 (pos_visible_p, face_before_or_after_it_pos)
1550 (back_to_previous_visible_line_start)
1551 (move_it_in_display_line_to, move_it_in_display_line)
1552 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1553 (try_scrolling, redisplay_window, display_line): Use them when
1554 saving a temporary copy of the iterator and restoring it back.
1555 (back_to_previous_visible_line_start, reseat_1)
1556 (init_iterator): Empty the bidi cache "stack".
1557 (move_it_in_display_line_to): If iterator ended up at
1558 EOL, but we never saw any buffer positions smaller than
1559 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1560 motion in bidi-reordered lines.
1561 (move_it_in_display_line_to): Record prev_method and prev_pos
1562 immediately before the call to set_iterator_to_next. Fixes cursor
1563 motion in bidi-reordered lines with stretch glyphs and strings
1564 displayed in margins. (Bug#8133) (Bug#8867)
1565 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1566 TO_CHARPOS.
640c8776
SM
1567 (pos_visible_p): Support positions in bidi-reordered lines.
1568 Save and restore bidi cache.
0bb23927
EZ
1569
1570 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1571 (bidi_paragraph_info): Delete unused struct.
1572 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1573 (bidi_cache_start): New variable.
1574 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1575 to zero.
1576 (bidi_cache_fetch_state, bidi_cache_search)
1577 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1578 (bidi_cache_find, bidi_peek_at_next_level)
1579 (bidi_level_of_next_char, bidi_find_other_level_edge)
1580 (bidi_move_to_visually_next): Compare cache index with
1581 bidi_cache_start rather than with zero.
1582 (bidi_fetch_char): Accept new argument STRING; all callers
1583 changed. Support iteration over a string. Support strings with
1584 display properties. Support unibyte strings. Fix the type of
1585 `len' according to what STRING_CHAR_AND_LENGTH expects.
1586 (bidi_paragraph_init, bidi_resolve_explicit_1)
1587 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1588 (bidi_level_of_next_char, bidi_move_to_visually_next):
1589 Support iteration over a string.
0bb23927
EZ
1590 (bidi_set_sor_type, bidi_resolve_explicit_1)
1591 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1592 can now be zero (for strings); special values 0 and -1 were
1593 changed to -1 and -2, respectively.
1594 (bidi_char_at_pos): New function.
1595 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1596 Call it instead of FETCH_MULTIBYTE_CHAR.
1597 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1598 initialized to valid values.
1599 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1600 values.
1601 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1602 the test for valid cached positions. Fix the logic for looking up
1603 the sentinel state in the cache. GCPRO the Lisp string we are
1604 iterating.
1605 (bidi_push_it, bidi_pop_it): New functions.
1606 (bidi_initialize): Initialize the bidi cache start stack pointer.
1607 (bidi_cache_ensure_space): New function, refactored from part of
1608 bidi_cache_iterator_state. Don't assume the required size is just
1609 one BIDI_CACHE_CHUNK away.
1610 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1611 (bidi_count_bytes, bidi_char_at_pos): New functions.
1612 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1613 always valid if bidi_cache_idx is valid.
1614 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1615 is valid if it's going to be used.
1616 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1617 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1618 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1619 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1620 (bidi_find_other_level_edge, bidi_cache_start_stack):
1621 All variables related to cache indices are now EMACS_INT.
c965adc5 1622
0bb23927
EZ
1623 * dispextern.h (struct bidi_string_data): New structure.
1624 (struct bidi_it): New member `string'. Make flag members be 1-bit
1625 fields, and put them last in the struct.
640c8776
SM
1626 (compute_display_string_pos, compute_display_string_end):
1627 Update prototypes.
0bb23927
EZ
1628 (bidi_push_it, bidi_pop_it): Add prototypes.
1629 (struct iterator_stack_entry): New members bidi_p,
1630 paragraph_embedding, and from_disp_prop_p.
1631 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1632 (bidi_shelve_cache, bidi_unshelve_cache):
1633 Declare prototypes.
0bb23927
EZ
1634
1635 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1636 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1637 and vector-like objects.
1638
1639 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1640 cache around display iteration.
1641
1642 * window.c (Fwindow_end, window_scroll_pixel_based)
1643 (displayed_window_lines, Frecenter): Save and restore the bidi
1644 cache around display iteration.
1645
3bbd2265
LMI
16462011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1647
1648 * editfns.c (Fdelete_region): Clarify the use of the named
1649 parameters (bug#6788).
1650
adc47434
MR
16512011-07-14 Martin Rudalics <rudalics@gmx.at>
1652
1653 * indent.c (Fvertical_motion): Set and restore w->pointm when
1654 saving and restoring the window's buffer (Bug#9006).
1655
837c31f8
LMI
16562011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1657
1658 * editfns.c (Fstring_to_char): Clarify just what is returned
1659 (bug#6576). Text by Eli Zaretskii.
1660
ac389d0c
JB
16612011-07-13 Juanma Barranquero <lekktu@gmail.com>
1662
1663 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1664
0be0ce47
EZ
16652011-07-13 Eli Zaretskii <eliz@gnu.org>
1666
1667 * buffer.c (mmap_find): Fix a typo.
1668
cd18e7e3
JB
16692011-07-13 Johan Bockgård <bojohan@gnu.org>
1670
1671 Fix execution of x selection hooks.
1672 * xselect.c (Qx_lost_selection_functions)
1673 (Qx_sent_selection_functions): New vars.
1674 (syms_of_xselect): DEFSYM them.
1675 (x_handle_selection_request): Pass Qx_sent_selection_functions
1676 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1677 (x_handle_selection_clear,x_clear_frame_selections):
1678 Pass Qx_lost_selection_functions rather than
1679 Vx_lost_selection_functions to Frun_hook_with_args.
1680
47ea7f44
PE
16812011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1682
ac389d0c 1683 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1684 The old code sometimes used this field without initializing it.
1685
47ea7f44
PE
1686 * alloc.c (gc_sweep): Don't read past end of array.
1687 In theory, the old code could also have corrupted Emacs internals,
1688 though it'd be very unlikely.
1689
bc985c87
AS
16902011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1691
1692 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1693 argument. (Bug#4026)
bc985c87 1694
0cf34688
LMI
16952011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1696
b3dadd76
LMI
1697 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1698 key" (bug#4257).
1699
0cf34688
LMI
1700 * window.c (Fset_window_start): Doc fix (bug#4199).
1701 (Fset_window_hscroll): Ditto.
1702
270768cd
PE
17032011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1704
077e3dda 1705 Fix minor new problems caught by GCC 4.6.1.
270768cd 1706 * term.c (init_tty): Remove unused local.
490011a6 1707 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1708 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1709 not used otherwise.
270768cd 1710
b1f58454
CY
17112011-07-12 Chong Yidong <cyd@stupidchicken.com>
1712
1713 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1714
22b9578d
LMI
17152011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1716
6e70ab07
LMI
1717 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1718 are the mini-buffer and the echo area (bug#3320).
1719
22b9578d
LMI
1720 * term.c (init_tty): Remove support for supdup, c10 and perq
1721 terminals, which are no longer supported (bug#1482).
1722
8974cc9f
JB
17232011-07-10 Johan Bockgård <bojohan@gnu.org>
1724
1725 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1726
a560d974
JD
17272011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1728
1729 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1730 for non-popups (Bug#3642).
1731
1dae0f0a
AS
17322011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1733
268c2c36 1734 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1735 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1736 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1737 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1738 * data.c (fmod): Likewise.
1739 * dispnew.c (swap_glyphs_in_rows): Likewise.
1740 * emacs.c (memory_warning_signal): Likewise.
1741 * floatfns.c (float_error): Likewise.
1742 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1743 (otf_open, font_otf_capability, generate_otf_features)
1744 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1745 Likewise.
1746 * image.c (pbm_read_file): Likewise.
1747 * indent.c (string_display_width): Likewise.
1748 * intervals.c (check_for_interval, search_for_interval)
1749 (inc_interval_count, count_intervals, root_interval)
1750 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1751 * lread.c (defalias): Likewise.
268c2c36 1752 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1753 * regex.c (set_image_of_range_1, set_image_of_range)
1754 (regex_grow_registers): Likewise.
1755 * sysdep.c (strerror): Likewise.
1756 * termcap.c (valid_filename_p, tprint, main): Likewise.
1757 * tparam.c (main): Likewise.
1758 * unexhp9k800.c (run_time_remap, save_data_space)
1759 (update_file_ptrs, read_header, write_header, calculate_checksum)
1760 (copy_file, copy_rest, display_header): Likewise.
1761 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1762 Likewise.
1763 * xdisp.c (check_it): Likewise.
1764 * xfaces.c (register_color, unregister_color, unregister_colors):
1765 Likewise.
1766 * xfns.c (print_fontset_result): Likewise.
1767 * xrdb.c (member, fatal, main): Likewise.
1768
99033785
PE
17692011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1770
1771 Fix minor problems found by static checking (Bug#9031).
1772 * chartab.c (char_table_set_range, map_sub_char_table):
1773 Remove unused locals.
1774 (uniprop_table): Now static.
1775 * composite.c (_work_char): Remove unused static var.
1776
9cb2ac56
JB
17772011-07-09 Juanma Barranquero <lekktu@gmail.com>
1778
1779 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1780
f25661f0
JD
17812011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1782
1783 * gtkutil.c (qttip_cb): Remove code without function.
1784
8278c4fe
EZ
17852011-07-09 Eli Zaretskii <eliz@gnu.org>
1786
1787 * w32.c (pthread_sigmask): New stub.
1788
1692ae2d 17892011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1790
8a6ebd58 1791 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1792 sigprocmask is portable only for single-threaded applications, and
1793 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1794 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1795 (LIBES): Use it.
1796 * callproc.c (Fcall_process):
1797 * process.c (create_process):
1798 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1799 Use pthread_sigmask, not sigprocmask.
123403e4 1800
1b854618
JD
18012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1802
1803 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1804 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1805 wrong (Bug#8591).
1806
3fe4b549
JD
18072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1808
0ce7e563
JD
1809 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1810 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1811 (xg_hide_tooltip): Fix comment.
1812
3fe4b549
JD
1813 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1814 in registerServicesMenuSendTypes.
1815 (validRequestorForSendType): Don't check ns_return_types.
1816
1817 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1818 ns_return_type.
1819
5df75e47
JR
18202011-07-08 Jason Rumney <jasonr@gnu.org>
1821
1822 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1823 frame struct members of non-existent frames (Bug#6284).
1824
699c10bd
JD
18252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1826
4393663b
JD
1827 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1828 variable firstTime not needed on OSX >= 10.6.
1829 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1830 >= 10.5. Use setKnobProportion, setDoubleValue.
1831
1832 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1833 (MAC_OS_X_VERSION_10_5): Define if not defined.
1834 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1835 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1836 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1837
1838 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1839 cString and lossyCString on OSX >= 10.4
1840
1841 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1842 sizeToFit on OSX >= 10.2.
1843
1844 * nsimage.m (allocInitFromFile): Don't use deprecated method
1845 bestRepresentationForDevice on OSX >= 10.6.
1846
1847 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1848 to avoid warning.
1849
1850 * emacs.c: Declare unexec_init_emacs_zone.
1851
a63e0781
JD
1852 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1853
699c10bd
JD
1854 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1855
1856 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1857 on svcsMenu (Bug#8842).
1858
1859 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1860 ns_return_types.
1861 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1862
1863 * nsterm.m (QUTF8_STRING): Declare.
1864 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1865 (validRequestorForSendType): Return type is (id).
1866 Change indexOfObjectIdenticalTo to indexOfObject.
1867 Check if we have local selection before returning self (Bug#8842).
1868 (writeSelectionToPasteboard): Put local selection into paste board
1869 if we have a local selection (Bug#8842).
1870 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1871
1872 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1873 (ns_get_local_selection): Declare.
1874
54e10184
LMI
18752011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1876
9888ff71
LMI
1877 * keymap.c (describe_map_tree): Don't insert a double newline at
1878 the end of the buffer (bug#1169) and return whether we inserted
1879 something.
1880
54e10184
LMI
1881 * callint.c (Fcall_interactively): Change "reading args" to
1882 "providing args" to try to clarify what it does (bug#1010).
1883
15fa4783
KH
18842011-07-07 Kenichi Handa <handa@m17n.org>
1885
1886 * composite.c (composition_compute_stop_pos): Ignore a static
1887 composition starting before CHARPOS (Bug#8915).
1888
1889 * xdisp.c (handle_composition_prop): Likewise.
1890
a8815b00
EZ
18912011-07-07 Eli Zaretskii <eliz@gnu.org>
1892
1893 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1894 (Bug#9015)
1895
ef7b981d 18962011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1897
1898 * character.h (unicode_category_t): New enum type.
1899
1900 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1901 (Qchar_code_property_table): New variable.
1902 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1903 (UNIPROP_COMPRESSED_FORM_P): New macros.
1904 (char_table_ascii): Uncompress the compressed values.
1905 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1906 Uncompress the compressed values.
ac389d0c 1907 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1908 (char_table_ref_and_range): Uncompress the compressed values.
1909 (sub_char_table_set): New arg is_uniprop. Callers changed.
1910 Uncompress the compressed values.
1911 (sub_char_table_set_range): Args changed. Callers changed.
1912 (char_table_set_range): Adjuted for the above change.
1913 (map_sub_char_table): Delete args default_val and parent. Add arg
1914 top. Give decoded values to a Lisp function.
640c8776 1915 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1916 values to a Lisp function. Gcpro more variables.
1917 (uniprop_table_uncompress)
1918 (uniprop_decode_value_run_length): New functions.
1919 (uniprop_decoder, uniprop_decoder_count): New variables.
1920 (uniprop_get_decoder, uniprop_encode_value_character)
1921 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1922 New functions.
1923 (uniprop_encoder, uniprop_encoder_count): New variables.
1924 (uniprop_get_encoder, uniprop_table)
1925 (Funicode_property_table_internal, Fget_unicode_property_internal)
1926 (Fput_unicode_property_internal): New functions.
1927 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1928 Sunicode_property_table_internal, Sget_unicode_property_internal,
1929 and Sput_unicode_property_internal. Defvar_lisp
1930 char-code-property-alist.
1931
640c8776 1932 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1933 Vunicode_category_table.
1934
640c8776 1935 * font.c (font_range): Adjust for the change of
c805dec0
KH
1936 Vunicode_category_table.
1937
76b397fb
DN
19382011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1939
1940 * m/iris4d.h: Remove file, move contents ...
1941 * s/irix6-5.h: ... here.
1942
22b4128e
PE
19432011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1944
1945 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1946 * alloc.c (mark_buffer):
1947 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1948 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1949 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1950 This isn't true in general, and it's particularly not true
1951 if Emacs is configured with --with-wide-int.
1952 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1953 New macros, used in the buffer.c change.
1954
869795d6
JD
19552011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1956
1957 * xsettings.c: Use both GConf and GSettings if both are available.
1958 (store_config_changed_event): Add comment.
1959 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1960 (store_tool_bar_style_changed): New functions.
1961 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1962 (struct xsettings): Move font inside HAVE_XFT.
1963 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1964 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1965 Move inside HAVE_XFT.
640c8776 1966 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1967 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1968 also.
1969 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1970 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1971 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1972 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1973 (parse_settings): Move check for font inside HAVE_XFT.
1974 (read_settings, apply_xft_settings): Add comment.
1975 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1976 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1977 call store_font_name_changed.
1978 (xft_settings_event): Add comment.
1979 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1980 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1981 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1982 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1983 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1984 (xsettings_get_system_font, xsettings_get_system_normal_font):
1985 Add comment.
869795d6 1986
d8ed26bd
PE
19872011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1988
1989 Random fixes. E.g., (random) never returned negative values.
1990 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1991 subseconds part to the entropy, as that's a bit more random.
1992 Prefer signed to unsigned, since the signedness doesn't matter and
1993 in general we prefer signed. When given a limit, use a
1994 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1995 latter isn't right if USE_2_TAGS_FOR_INTS.
1996 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1997 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1998
cabf1cac
SM
19992011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2000
2001 * textprop.c (text_property_stickiness):
2002 Obey Vtext_property_default_nonsticky.
2003 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2004 * w32fns.c (syms_of_w32fns):
2005 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2006
6e9b2be9
PE
20072011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2010 This is more efficient than Ffile_directory_p and avoids a minor race.
2011
90186c68
LMI
20122011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2013
7c301272
LMI
2014 * buffer.c (Foverlay_put): Say what the return value is
2015 (bug#7835).
2016
c4f2d8d4
LMI
2017 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2018 is a directory before asking whether to use the file name
2019 (bug#7564).
ad637907
LMI
2020 (barf_or_query_if_file_exists): Make the "File is a directory"
2021 error be more correct.
c4f2d8d4 2022
90186c68
LMI
2023 * fns.c (Frequire): Remove the mention of the .gz files, since
2024 that's installation-specific, but keep the mention of
2025 `get-load-suffixes'.
2026
da64016e
PE
20272011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2028
2029 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2030 Report string overflow if the output is too long.
2031
7d47b580
JB
20322011-07-04 Juanma Barranquero <lekktu@gmail.com>
2033
a555cb87
JB
2034 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2035 (syms_of_gnutls): Remove duplicate DEFSYM for
2036 Qgnutls_bootprop_verify_hostname_error, an error for
2037 Qgnutls_bootprop_verify_error (which is no longer used).
2038
7d47b580
JB
2039 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2040 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2041 Also (re)move comments that are misplaced or no longer relevant.
2042
1e49bfab
LMI
20432011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2044
2045 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2046
1485f4c0
CY
20472011-07-03 Chong Yidong <cyd@stupidchicken.com>
2048
2049 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2050 and background color parameters if they have been changed.
2051
a9ab721e
LMI
20522011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2053
2054 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2055
cf7cff57
PE
20562011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2057
2e13213d
PE
2058 * xsettings.c (SYSTEM_FONT): Define only when used.
2059 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2060
cf7cff57
PE
2061 * keymap.c (access_keymap_1): Now static.
2062
7a8e04f7
CY
20632011-07-02 Chong Yidong <cyd@stupidchicken.com>
2064
2065 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2066 leave any prefix arg for the up event (Bug#1586).
2067
61352f62
LMI
20682011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2069
69bb1ef7
LMI
2070 * lread.c (syms_of_lread): Mention single symbols defined by
2071 `defvar' or `defconst' (bug#7154).
2072
61352f62 2073 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2074 (Frequire): Mention get-load-suffixes.
61352f62 2075
28545e04
MR
20762011-07-02 Martin Rudalics <rudalics@gmx.at>
2077
2078 * window.h (window): Remove clone_number slot.
2079 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2080 Remove.
2081 (make_parent_window, make_window, saved_window)
2082 (Fset_window_configuration, save_window_save): Don't deal with
2083 clone numbers.
2084 * buffer.c (Qclone_number): Remove declaration.
2085 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2086
3349e122
SM
20872011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2088
2089 Add multiple inheritance to keymaps.
2090 * keymap.c (Fmake_composed_keymap): New function.
2091 (Fset_keymap_parent): Simplify.
2092 (fix_submap_inheritance): Remove.
2093 (access_keymap_1): New function extracted from access_keymap to handle
2094 embedded parents and handle lists of maps.
2095 (access_keymap): Use it.
2096 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2097 (Fcopy_keymap): Handle embedded parents.
2098 (Fcommand_remapping, define_as_prefix): Simplify.
2099 (Fkey_binding): Simplify.
2100 (syms_of_keymap): Move minibuffer-local-completion-map,
2101 minibuffer-local-filename-completion-map,
2102 minibuffer-local-must-match-map, and
2103 minibuffer-local-filename-must-match-map to Elisp.
2104 (syms_of_keymap): Defsubr make-composed-keymap.
2105 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2106 (parse_menu_item): Trivial simplification.
2107
3279eb87
GM
21082011-07-01 Glenn Morris <rgm@gnu.org>
2109
2110 * Makefile.in (SETTINGS_LIBS): Fix typo.
2111
4550efdf
KI
21122011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2113
2114 * coding.c (Fencode_coding_string): Record the last coding system
2115 used, as the function doc string says (bug#8738).
2116
0949d2b6
JD
21172011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2118
2119 * xsettings.c (store_monospaced_changed): Take new font as arg and
2120 check for change against current_mono_font.
2121 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2122 (emacs_settings_constructor, emacs_settings_get_property)
2123 (emacs_settings_set_property, emacs_settings_class_init)
2124 (emacs_settings_init, gsettings_obj): Remove.
2125 (something_changedCB): New function for HAVE_GSETTINGS.
2126 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2127 with value as argument.
2128 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2129 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2130 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2131 "changed".
2132
2133 * xgselect.c: Add defined (HAVE_GSETTINGS).
2134 (xgselect_initialize): Ditto.
2135
2136 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2137 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2138 xg_select.
2139
bbc6b304
PE
21402011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2141
2142 * eval.c (struct backtrace): Simplify and port the data structure.
2143 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2144 signed bit field, as this assumption is not portable and it makes
2145 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2146 "char debug_on_exit : 1" as this is not portable either; instead,
2147 use the portable "unsigned int debug_on_exit : 1". Remove unused
2148 member evalargs. Remove obsolete comments about cc bombing out.
2149
9851bfc5
JD
21502011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2151
51bb811f 2152 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2153 Let HAVE_GSETTINGS override HAVE_GCONF.
2154 (store_monospaced_changed): New function.
2155 (EMACS_SETTINGS): A new type derived from GObject to handle
2156 GSettings notifications.
2157 (emacs_settings_constructor, emacs_settings_get_property)
2158 (emacs_settings_set_property, emacs_settings_class_init):
2159 New functions.
2160 (gsettings_client, gsettings_obj): New variables.
2161 (GSETTINGS_SCHEMA): New define.
2162 (something_changedCB): Call store_monospaced_changed.
2163 (init_gsettings): New function.
2164 (xsettings_initialize): Call init_gsettings.
2165 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2166 to NULL.
2167
640c8776 2168 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2169 GCONF_CFLAGS/LIBS.
2170
5386012d
MR
21712011-06-29 Martin Rudalics <rudalics@gmx.at>
2172
2173 * window.c (resize_root_window, grow_mini_window)
2174 (shrink_mini_window): Rename Qresize_root_window to
2175 Qwindow_resize_root_window and Qresize_root_window_vertically to
2176 Qwindow_resize_root_window_vertically.
2177
f13e0b08
PE
21782011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2179
2180 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2181
94515237
JB
21822011-06-27 Juanma Barranquero <lekktu@gmail.com>
2183
2184 * makefile.w32-in: Redesign dependencies so they reflect more
2185 clearly which files are directly included by each source file,
2186 and not through other includes.
2187
e43b6e43
MR
21882011-06-27 Martin Rudalics <rudalics@gmx.at>
2189
2190 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2191 (sort_overlays, overlay_strings): When an overlay's clone number
2192 matches the window's clone number process the overlay even if
2193 the overlay's window property doesn't match the current window.
2194
d68443dc
MR
2195 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2196 (Fwindow_hchild): Rename to Fwindow_left_child.
2197 (Fwindow_next): Rename to Fwindow_next_sibling.
2198 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2199 (resize_window_check): Rename to window_resize_check.
2200 (resize_window_apply): Rename to window_resize_apply.
2201 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2202 (Fdelete_other_windows_internal, resize_frame_windows)
2203 (Fsplit_window_internal, Fdelete_window_internal)
2204 (grow_mini_window, shrink_mini_window)
2205 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2206
c7e73be5
JD
22072011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2208
2209 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2210 (emacs_fixed_set_min_size): Remove.
2211 (emacs_fixed_new): Take frame as argument.
2212
2213 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2214 (_EmacsFixedPrivate): Remove minwidth/height.
2215 Add struct frame *f.
2216 (emacs_fixed_init): Initialize priv->f.
2217 (get_parent_class, emacs_fixed_set_min_size): Remove.
2218 (emacs_fixed_new): Set priv->f to argument.
2219 (emacs_fixed_get_preferred_width)
2220 (emacs_fixed_get_preferred_height): Use min_width/height from
2221 frames size_hint to set minimum and natural (Bug#8919).
2222 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2223 and use min_width/height from frames size_hint to set
2224 min_width/height (Bug#8919).
2225
2226 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2227 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2228 Fix indentation.
c7e73be5 2229
cf99dcf8
EZ
22302011-06-26 Eli Zaretskii <eliz@gnu.org>
2231
2232 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2233 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2234 called at ZV.
2235
029529ac
CY
22362011-06-26 Chong Yidong <cyd@stupidchicken.com>
2237
2238 * process.c (wait_reading_process_output): Bypass select if
2239 waiting for a cell while ignoring keyboard input, and input is
2240 pending. Suggested by Jan Djärv (Bug#8869).
2241
7a7ef429
PE
22422011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2243
2244 Use gnulib's dup2 module instead of rolling our own.
2245 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2246
11fdef7d 22472011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2248
2249 * dispnew.c (scrolling_window): Before scrolling, turn off a
2250 mouse-highlight in the window being scrolled.
2251
cd3520a4
JB
22522011-06-24 Juanma Barranquero <lekktu@gmail.com>
2253
2254 Move DEFSYM to lisp.h and use everywhere.
2255
2256 * character.h (DEFSYM): Move declaration...
2257 * lisp.h (DEFSYM): ...here.
2258
2259 * gnutls.c:
2260 * minibuf.c:
2261 * w32menu.c:
2262 * w32proc.c:
2263 * w32select.c: Don't include character.h.
2264
2265 * alloc.c (syms_of_alloc):
2266 * buffer.c (syms_of_buffer):
2267 * bytecode.c (syms_of_bytecode):
2268 * callint.c (syms_of_callint):
2269 * casefiddle.c (syms_of_casefiddle):
2270 * casetab.c (init_casetab_once):
2271 * category.c (init_category_once, syms_of_category):
2272 * ccl.c (syms_of_ccl):
2273 * cmds.c (syms_of_cmds):
2274 * composite.c (syms_of_composite):
2275 * dbusbind.c (syms_of_dbusbind):
2276 * dired.c (syms_of_dired):
2277 * dispnew.c (syms_of_display):
2278 * doc.c (syms_of_doc):
2279 * editfns.c (syms_of_editfns):
2280 * emacs.c (syms_of_emacs):
2281 * eval.c (syms_of_eval):
2282 * fileio.c (syms_of_fileio):
2283 * fns.c (syms_of_fns):
2284 * frame.c (syms_of_frame):
2285 * fringe.c (syms_of_fringe):
2286 * insdel.c (syms_of_insdel):
2287 * keymap.c (syms_of_keymap):
2288 * lread.c (init_obarray, syms_of_lread):
2289 * macros.c (syms_of_macros):
2290 * msdos.c (syms_of_msdos):
2291 * print.c (syms_of_print):
2292 * process.c (syms_of_process):
2293 * search.c (syms_of_search):
2294 * sound.c (syms_of_sound):
2295 * syntax.c (init_syntax_once, syms_of_syntax):
2296 * terminal.c (syms_of_terminal):
2297 * textprop.c (syms_of_textprop):
2298 * undo.c (syms_of_undo):
2299 * w32.c (globals_of_w32):
2300 * window.c (syms_of_window):
2301 * xdisp.c (syms_of_xdisp):
2302 * xfaces.c (syms_of_xfaces):
2303 * xfns.c (syms_of_xfns):
2304 * xmenu.c (syms_of_xmenu):
2305 * xsettings.c (syms_of_xsettings):
2306 * xterm.c (syms_of_xterm): Use DEFSYM.
2307
4228cf16
TZ
23082011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2309
cd3520a4 2310 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2311
7fcccf1e
PE
23122011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2313
7efb4e0e
PE
2314 Integer and buffer overflow fixes (Bug#8873).
2315
ff5844ad
PE
2316 * print.c (printchar, strout): Check for string overflow.
2317 (PRINTPREPARE, printchar, strout):
2318 Don't set size unless allocation succeeds.
2319
90532f02
PE
2320 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2321 for sizes. Check for string overflow more accurately.
2322 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2323
6d84508d
PE
2324 * macros.c: Integer and buffer overflow fixes.
2325 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2326 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2327 Use ptrdiff_t, not int, for sizes.
2328 Don't increment bufsize until after realloc succeeds.
2329 Check for size-calculation overflow.
2330 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2331
437b2cb4
PE
2332 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2333
8b9ac8b4
PE
2334 * lread.c: Integer overflow fixes.
2335 (read_integer): Radix is now EMACS_INT, not int,
2336 to improve quality of diagnostics for out-of-range radices.
2337 Calculate buffer size correctly for out-of-range radices.
2338 (read1): Check for integer overflow in radices, and in
2339 read-circle numbers.
82cb60d3
PE
2340 (read_escape): Avoid int overflow.
2341 (Fload, openp, read_buffer_size, read1)
2342 (substitute_object_recurse, read_vector, read_list, map_obarray):
2343 Use ptrdiff_t, not int, for sizes.
2344 (read1): Use EMACS_INT, not int, for sizes.
20270765 2345 Check for size overflow.
8b9ac8b4 2346
7fcccf1e
PE
2347 * image.c (cache_image): Check for size arithmetic overflow.
2348
bfbbd7e7
PE
2349 * lread.c: Integer overflow issues.
2350 (saved_doc_string_size, saved_doc_string_length)
2351 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2352 Now ptrdiff_t, not int.
2353 (read1): Don't assume doc string length fits in int. Check for
2354 out-of-range doc string lengths.
2355 (read_list): Don't assume file position fits in int.
39019e54 2356 (read_escape): Check for hex character overflow.
bfbbd7e7 2357
4e323265
LL
23582011-06-22 Leo Liu <sdl.web@gmail.com>
2359
2360 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2361 Move to minibuffer.el.
2362
85fece3e
PE
23632011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2364
20b84ce9 2365 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2366 The following patches are for when GLYPH_DEBUG && !XASSERT.
2367 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2368 * dispnew.c (flush_stdout):
2369 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2370 Mark as externally visible.
2371 * dispnew.c (check_window_matrix_pointers): Now static.
2372 * dispnew.c (window_to_frame_vpos):
2373 * xfns.c (unwind_create_frame):
2374 * xterm.c (x_check_font): Remove unused local.
2375 * scroll.c (CHECK_BOUNDS):
2376 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2377 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2378 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2379 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2380 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2381 Now static.
2382 (debug_method_add): Use va_list and vsprintf rather than relying
2383 on undefined behavior with wrong number of arguments.
2384 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2385 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2386 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2387 since we're not interested in debugging glyphs with old libraries.
2388 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2389 GCC 4.6.0's static checking.
2390
0766b489
PE
23912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2392
31fd4b32
PE
2393 Integer overflow and signedness fixes (Bug#8873).
2394 A few related buffer overrun fixes, too.
2395
b79e8648
PE
2396 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2397
0766b489
PE
2398 * dispextern.h (struct face.stipple):
2399 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2400 (x_bitmap_mask, x_allocate_bitmap_record)
2401 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2402 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2403 (x_create_bitmap_from_xpm_data):
2404 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2405 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2406 (.bitmaps_last):
2407 * xfaces.c (load_pixmap):
2408 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2409 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2410 (.bitmaps_last, struct x_output.icon_bitmap):
2411 Use ptrdiff_t, not int, for bitmap indexes.
2412 (x_allocate_bitmap_record): Check for size overflow.
2413 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2414
b081724f
PE
2415 Use ptrdiff_t, not int, for overlay counts.
2416 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2417 * editfns.c (overlays_around, get_pos_property):
2418 * textprop.c (get_char_property_and_overlay):
2419 * xdisp.c (next_overlay_change, note_mouse_highlight):
2420 * xfaces.c (face_at_buffer_position):
21514da7
PE
2421 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2422 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2423 (Fnext_overlay_change, Fprevious_overlay_change)
2424 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2425 Use ptrdiff_t, not int, for sizes.
21514da7 2426 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2427
3de73e5e
PE
2428 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2429
2606c57b
PE
2430 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2431 (x_session_initialize): Do not assume string length fits in int.
2432
aaafe47a
PE
2433 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2434 This is unlikely, but can occur if DPI is outlandish.
2435
2674ddc8 2436 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2437 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2438
28154962
PE
2439 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2440 * xrdb.c (magic_file_p, search_magic_path):
2441 Omit last arg SUFFIX; it was always 0. All callers changed.
2442 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2443
7de51af5
PE
2444 * xfont.c (xfont_match): Avoid need for strlen.
2445
25ed6cc3
PE
2446 * xfns.c: Don't assume strlen fits in int.
2447 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2448
4eab31dd
PE
2449 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2450 not unsigned long, as we prefer signed integers. All callers changed.
2451 Detect integer overflow in repeat count.
2452 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2453 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2454
171e2a58
PE
2455 * termcap.c: Don't assume sizes fit in int and never overflow.
2456 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2457 (gobble_line): Check for size-calculation overflow.
2458
ad39faca 2459 * minibuf.c (Fread_buffer):
6e5bb2dc 2460 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2461 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2462 Don't assume string length fits in int.
2463
52c61c22 2464 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2465 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2466
b5b8c9e5
PE
2467 * font.c: Don't assume string length fits in int.
2468 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2469 Use ptrdiff_t, not int.
ccd6111c
PE
2470 (font_intern_prop): Don't assume string length fits in int.
2471 Don't assume integer property fits in fixnum.
2472 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2473
882f0d81 2474 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2475 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2476 Reformulate so as not to need the command string.
2477 Invoke gzip -cd rather than gunzip, as it's more portable.
2478 (lock_info_type, lock_file_1, lock_file):
2479 Don't assume pid_t and time_t fit in unsigned long.
2480 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2481 (current_lock_owner): Prefer signed type for sizes.
2482 Use memcpy, not strncpy, where memcpy is what is really wanted.
2483 Don't assume (via atoi) that time_t and pid_t fit in int.
2484 Check for time_t and/or pid_t out of range, e.g., via a network share.
2485 Don't alloca where an auto var works fine.
2486
93f4cf88
PE
2487 * fileio.c: Fix some integer overflow issues.
2488 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2489 Don't assume string length fits in int.
2490 (directory_file_name): Don't assume string length fits in long.
2491 (make_temp_name): Don't assume pid fits in int, or that its print
2492 length is less than 20.
2493
f3e92b69
PE
2494 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2495
1bfdaf10
PE
2496 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2497
35016e9a
PE
2498 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2499
3d1e65a1
PE
2500 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2501 We prefer signed integers, even for size calculations.
2502
0b963a93
PE
2503 * emacs.c: Don't assume string length fits in 'int'.
2504 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2505 (main): Don't invoke strlen when not needed.
2506
573f4b54
PE
2507 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2508 (XD_DEBUG_MESSAGE): Don't waste a byte.
2509
989f33ba
PE
2510 * callproc.c (getenv_internal_1, getenv_internal)
2511 (Fgetenv_internal):
965d34eb
PE
2512 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2513
e4d29b33
PE
2514 * lread.c (invalid_syntax): Omit length argument.
2515 All uses changed. This doesn't fix a bug, but it simplifies the
2516 code away from its former Hollerith-constant appearance, and it's
2517 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2518 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2519
eb49b136
PE
2520 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2521 This didn't break anything, but it didn't help either.
2522 It's confusing to put a bogus integer in a place where the actual
2523 value does not matter.
9f62aeb1 2524 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2525 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2526
15375a22
PE
2527 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2528 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2529 implementation.
b61cc01c
PE
2530 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2531 We prefer signed types, and the value cannot exceed the EMACS_INT
2532 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2533 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2534 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2535 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2536
53b2623d
PE
2537 * indent.c (sane_tab_width): New function.
2538 (current_column, scan_for_column, Findent_to, position_indentation)
2539 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2540 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2541
51cab52b 2542 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2543
f2ed8a70
PE
2544 * lisp.h (lint_assume): New macro.
2545 * composite.c (composition_gstring_put_cache):
2546 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2547
abe80cc6
PE
2548 * editfns.c, insdel.c:
2549 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2550
b02c740e
PE
2551 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2552
ebc96716
PE
2553 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2554
b4e50fa0 2555 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2556 Use much-faster test for byte-length change.
311d5d7c 2557 Don't assume string byte-length fits in 'int'.
a4cf38e4 2558 Check that character arg fits in 'int'.
85461888 2559 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2560
c0c1ee9f
PE
2561 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2562
a498d7f4
PE
2563 * fns.c (concat): Catch string overflow earlier.
2564 Do not rely on integer wraparound.
2565
51cab52b
PE
2566 * dispextern.h (struct it.overlay_strings_charpos)
2567 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2568 * xdisp.c (forward_to_next_line_start)
2569 (back_to_previous_visible_line_start)
2570 (reseat_at_next_visible_line_start, next_element_from_buffer):
2571 Don't arbitrarily truncate the value of 'selective' to int.
2572
76031fad
PE
2573 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2574
5eb55db9
PE
2575 * composite.c: Don't truncate sizes to 'int'.
2576 (composition_gstring_p, composition_reseat_it)
2577 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2578 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2579 not EMACS_UINT, for indexes.
5eb55db9 2580
0703a717
PE
2581 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2582
d6202519
PE
2583 * buffer.c: Include <verify.h>.
2584 (struct sortvec.priority, struct sortstr.priority):
8961a454 2585 Now EMACS_INT, not int.
c20998a7 2586 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2587 (struct sortstr.size, record_overlay_string)
2588 (struct sortstrlist.size, struct sortlist.used):
2589 Don't truncate size to int.
2590 (record_overlay_string): Check for size-calculation overflow.
d6202519 2591 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2592
d5a19415
JM
25932011-06-22 Jim Meyering <meyering@redhat.com>
2594
029529ac 2595 Don't leak an XBM-image-sized buffer
d5a19415
JM
2596 * image.c (xbm_load): Free the image buffer after using it.
2597
a9041e6c
PE
25982011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2599
2600 Port to Sun C.
2601 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2602 that Sun C diagnosed.
2603 * fns.c (secure_hash): Fix pointer signedness issue.
2604 * intervals.c (static_offset_intervals): New function.
2605 (offset_intervals): Use it.
2606
7f3f739f
LL
26072011-06-21 Leo Liu <sdl.web@gmail.com>
2608
2609 * deps.mk (fns.o):
2610 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2611 sha512.h.
2612
2613 * fns.c (secure_hash): Rename from crypto_hash_function and change
2614 the first arg to accept symbols.
5b66d427 2615 (Fsecure_hash): New primitive.
7f3f739f
LL
2616 (syms_of_fns): New symbols.
2617
76147d94
DD
26182011-06-20 Deniz Dogan <deniz@dogan.se>
2619
2620 * process.c (Fset_process_buffer): Clarify return value in
2621 docstring.
2622
7d7d0045
CY
26232011-06-18 Chong Yidong <cyd@stupidchicken.com>
2624
2625 * dispnew.c (add_window_display_history): Use BVAR.
2626
2627 * xdisp.c (debug_method_add): Use BVAR.
2628 (check_window_end, dump_glyph_matrix, dump_glyph)
2629 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2630
2631 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2632 Likewise.
2633
2634 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2635 check till after the cache is created in init_frame_faces.
2636
ff2bc410
SM
26372011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2638
2639 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2640
28177add
PE
26412011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2642
dd3482fe
PE
2643 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2644 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2645 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2646
393d71f3 2647 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2648 * fileio.c (Finsert_file_contents):
2649 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2650 Remove the old (too-loose) buffer overflow checks.
2651 They weren't needed, since make_gap checks for buffer overflow.
2652 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2653 The old code merely checked for Emacs fixnum overflow, and relied
2654 on undefined (wraparound) behavior. The new code avoids undefined
2655 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2656
2e6813b0 2657 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2658 Tune. Don't use wider integers than needed. Don't use alloca.
2659 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2660
599a9e4f
PE
2661 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2662
99561444
PE
2663 * insdel.c, lisp.h (buffer_overflow): New function.
2664 (insert_from_buffer_1, replace_range, replace_range_2):
2665 * insdel.c (make_gap_larger):
2666 * editfns.c (Finsert_char):
2667 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2668
28177add
PE
2669 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2670
e69dafad
PE
26712011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2672
a7af7fde 2673 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2674
b1c46f02
PE
2675 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2676 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2677
e69dafad
PE
2678 * fileio.c: Don't assume EMACS_INT fits in off_t.
2679 (emacs_lseek): New static function.
2680 (Finsert_file_contents, Fwrite_region): Use it.
2681 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2682
566684ea
PE
2683 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2684
e6966cd6
PE
2685 * fns.c: Don't overflow int when computing a list length.
2686 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2687 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2688 truncation on 64-bit hosts. Check for QUIT every
2689 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2690 faster and is responsive enough.
2691 (Flength): Report an error instead of overflowing an integer.
2692 (Fsafe_length): Return a float if the value is not representable
2693 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2694 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2695 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2696
dd0b0efb
PE
2697 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2698 (header_size, word_size): New constants.
2699 (allocate_vectorlike): Don't check size overflow here.
2700 (allocate_vector): Check it here instead, since this is the only
2701 caller of allocate_vectorlike that could cause overflow.
2702 Check that the new vector's length is representable as a fixnum.
2703
86fe5cfe
PE
2704 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2705 The previous code was bogus. For example, next_almost_prime (32)
2706 returned 39, which is undesirable as it is a multiple of 3; and
2707 next_almost_prime (24) returned 25, which is a multiple of 5 so
2708 why was the code bothering to check for multiples of 7?
2709
80e88859
PE
2710 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2711
4a2f0ad6
PE
2712 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2713
f66c7cf8
PE
2714 Variadic C functions now count arguments with ptrdiff_t.
2715 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2716 Back then I didn't know that the Emacs coding style prefers signed int.
2717 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2718 were being counted with int, which may truncate counts on 64-bit
2719 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2720 * lisp.h (struct Lisp_Subr.function.aMANY)
2721 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2722 Arg counts are now ptrdiff_t, not size_t.
2723 All variadic functions and their callers changed accordingly.
2724 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2725 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2726 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2727 * callint.c (Fcall_interactively): Check arg count for overflow,
2728 to avoid potential buffer overrun. Use signed char, not 'int',
2729 for 'varies' array, so that we needn't bother to check its size
2730 calculation for overflow.
2731 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2732 * eval.c (apply_lambda):
2733 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2734 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2735 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2736
a1759b76
PE
2737 * callint.c (Fcall_interactively): Don't use index var as event count.
2738
d96be9fc
PE
2739 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2740 * mem-limits.h (SIZE): Remove; no longer used.
2741
a690a978 2742 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2743
578c21e6
PE
2744 Remove unnecessary casts.
2745 * xterm.c (x_term_init):
2746 * xfns.c (x_set_border_pixel):
2747 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2748 These aren't needed now that we assume ANSI C.
2749
96f53c6c
PE
2750 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2751 It's more likely to cause problems (due to unsigned overflow)
2752 than to cure them.
2753
83c77d31
PE
2754 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2755
ee2079f1
PE
2756 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2757
6da65536
PE
2758 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2759
7147c4a4
PE
2760 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2761
193e32d9
PE
2762 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2763
e5533da6
PE
2764 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2765
9910e595
PE
2766 GLYPH_CODE_FACE returns EMACS_INT, not int.
2767 * dispextern.h (merge_faces):
2768 * xfaces.c (merge_faces):
01103c44
PE
2769 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2770 Don't assume EMACS_INT fits in int.
9910e595 2771
2638320e
PE
2772 * character.h (CHAR_VALID_P): Remove unused parameter.
2773 * fontset.c, lisp.h, xdisp.c: All uses changed.
2774
045eb8d9
PE
2775 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2776
c1f134b5
PE
2777 * fns.c (concat): Minor tuning based on overflow analysis.
2778 This doesn't fix any bugs. Use int to hold character, instead
2779 of constantly refetching from Emacs object. Use XFASTINT, not
2780 XINT, for value known to be a character. Don't bother comparing
2781 a single byte to 0400, as it's always less.
2782
395fcb93 2783 * floatfns.c (Fexpt):
327eeec8
PE
2784 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2785
abbd3d23
PE
2786 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2787 for characters.
2788
684a03ef
PE
2789 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2790
0fed43f3
PE
2791 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2792 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2793 incorrectly succeed when S was a string, because 4294967386 was
2794 truncated before it was used.
2795
8fd02eb7
PE
2796 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2797 Otherwise, an out-of-range integer could cause undefined behavior
2798 on a 64-bit host.
2799
f8c86b69
PE
2800 * composite.c: Use int, not EMACS_INT, for characters.
2801 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2802 EMACS_INT, for values that are known to be in character range.
2803 This doesn't fix any bugs but is the usual style inside Emacs and
2804 may generate better code on 32-bit machines.
2805
34206dd2
PE
2806 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2807 This is for reasons similar to the recent CHAR_STRING fix.
2808 * charset.c (Fencode_char): Check that character arg is actually
2809 a character. Pass an int to ENCODE_CHAR.
2810 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2811 wider than 'int', as a compile-time check to prevent future regressions
2812 in this area.
2813
c5958d4c 2814 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2815
2816 Make sure a 64-bit char is never passed to CHAR_STRING.
2817 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2818 by silently ignoring the top 32 bits, allowing some values
2819 that were far too large to be valid characters.
2820 * character.h: Include <verify.h>.
2821 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2822 arguments are no wider than unsigned, as a compile-time check
2823 to prevent future regressions in this area.
2824 * data.c (Faset):
01103c44 2825 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2826 (Fsubst_char_in_region):
2827 * fns.c (concat):
2828 * xdisp.c (decode_mode_spec_coding):
2829 Adjust to CHAR_STRING's new requirement.
2830 * editfns.c (Finsert_char, Fsubst_char_in_region):
2831 * fns.c (concat): Check that character args are actually
2832 characters. Without this test, these functions did the wrong
2833 thing with wildly out-of-range values on 64-bit hosts.
2834
d37ca623
PE
2835 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2836 These casts should not be needed on 32-bit hosts, either.
2837 * keyboard.c (read_char):
2838 * lread.c (Fload): Remove casts to unsigned.
2839
ea204efb
PE
2840 * lisp.h (UNSIGNED_CMP): New macro.
2841 This fixes comparison bugs on 64-bit hosts.
2842 (ASCII_CHAR_P): Use it.
2843 * casefiddle.c (casify_object):
01103c44 2844 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2845 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2846 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2847 * dispextern.h (FACE_FROM_ID):
2848 * keyboard.c (read_char): Use UNSIGNED_CMP.
2849
41cb286c
PE
2850 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2851 not to EMACS_INT, to avoid GCC warning.
2852
4a1b9832
PE
2853 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2854
55daad71
PE
2855 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2856 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2857 isn't needed on 32-bit machines.
8f95c75c 2858
01103c44
PE
2859 * buffer.c (Fgenerate_new_buffer_name):
2860 Use EMACS_INT for count, not int.
0ceccced 2861 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2862
2863 * data.c (Qcompiled_function): Now static.
2864
c6f072e7
PE
2865 * window.c (window_body_lines): Now static.
2866
20ce5912
PE
2867 * image.c (gif_load): Rename local to avoid shadowing.
2868
9c4c5f81
PE
2869 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2870 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2871 * alloc.c (make_save_value): Integer argument is now of type
2872 ptrdiff_t, not int.
2873 (mark_object): Use ptrdiff_t, not int.
2874 * lisp.h (pD): New macro.
2875 * print.c (print_object): Use it.
2876
c0c5c8ae
PE
2877 * alloc.c: Use EMACS_INT, not int, to count objects.
2878 (total_conses, total_markers, total_symbols, total_vector_size)
2879 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2880 (total_free_floats, total_floats, total_free_intervals)
2881 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2882 Now EMACS_INT, not int. All uses changed.
2883 (Fgarbage_collect): Compute overall total using a double, so that
2884 integer overflow is less likely to be a problem. Check for overflow
2885 when converting back to an integer.
5a25e253
PE
2886 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2887 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2888 These were 'int' variables that could overflow on 64-bit hosts;
2889 they were never used, so remove them instead of repairing them.
211a0b2a 2890 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2891 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2892 Previously, this ceilinged at INT_MAX, but that doesn't work on
2893 64-bit machines.
e46bb31a 2894 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2895
c78baabf 2896 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2897 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2898 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2899 when a (possibly-narrower) signed value would do just as well.
2900 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2901
c9d624c6
PE
2902 * alloc.c: Catch some string size overflows that we were missing.
2903 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2904 for convenience in STRING_BYTES_MAX.
2905 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2906 The definition here is exact; the one in lisp.h was approximate.
2907 (allocate_string_data): Check for string overflow. This catches
2908 some instances we weren't catching before. Also, it catches
2909 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2910 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2911 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2912
c9d624c6
PE
2913 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2914 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2915 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2916
353032ce
PE
2917 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2918
2bccce07
PE
2919 * alloc.c (Fmake_string): Check for out-of-range init.
2920
0ac30604
SM
29212011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2922
2923 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2924
c195f2de
JD
29252011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2926
2927 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2928 xg_get_default_scrollbar_width.
2929
2930 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2931 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2932 (style_changed_cb): Call update_theme_scrollbar_width and call
2933 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2934 all frames (Bug#8505).
2935 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2936 Call gtk_window_set_resizable if HAVE_GTK3.
2937 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2938 and height if HAVE_GTK3 (Bug#8505).
2939 (scroll_bar_width_for_theme): New variable.
2940 (update_theme_scrollbar_width): New function.
2941 (xg_get_default_scrollbar_width): Move code to
2942 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2943 (xg_initialize): Call update_theme_scrollbar_width.
2944
2945 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2946
2947 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2948
e10ac9f1
MR
29492011-06-12 Martin Rudalics <rudalics@gmx.at>
2950
2951 * frame.c (make_frame): Call other_buffer_safely instead of
2952 other_buffer.
2953
2954 * window.c (temp_output_buffer_show): Call display_buffer with
2955 second argument Vtemp_buffer_show_specifiers and reset latter
2956 immediately after the call.
2957 (Vtemp_buffer_show_specifiers): New variable.
2958 (auto_window_vscroll_p, next_screen_context_lines)
2959 (Vscroll_preserve_screen_position): Remove leading asterisks from
2960 doc-strings.
2961
2d3c217e 29622011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2963
7b7f97e8 2964 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2965 * buffer.c (Qclone_number): Remove for now, as it's unused.
2966 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2967 (record_buffer): Remove unused local.
2968 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2969 (set_frame_buffer_list): Remove; unused.
2970 * frame.h (other_visible_frames): Remove decl.
2971 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2972 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2973 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2974 if HAVE_GPM.
2975 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2976 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2977 Define only if HAVE_GPM.
2978 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2979 (update_hints_inhibit): Remove; never set. All uses removed.
2980 * widgetprv.h (emacsFrameClassRec): Remove decl.
2981 * window.c (delete_deletable_window): Now returns void, since it
2982 wasn't returning anything.
2983 (compare_window_configurations): Remove unused locals.
2984 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2985 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2986 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2987 the same widths as pointers. This follows up on the 2011-05-06 patch.
2988 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2989 * xterm.h: Likewise.
2990 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2991
1384b89e
JB
29922011-06-12 Juanma Barranquero <lekktu@gmail.com>
2993
2994 * makefile.w32-in: Update dependencies.
2995 (LISP_H): Add lib/intprops.h.
2996
1100a63c
CY
29972011-06-11 Chong Yidong <cyd@stupidchicken.com>
2998
2999 * image.c (gif_load): Add animation frame delay to the metadata.
3000 (syms_of_image): Use DEFSYM. New symbol `delay'.
3001
6198ccd0
MR
30022011-06-11 Martin Rudalics <rudalics@gmx.at>
3003
3004 * window.c (delete_deletable_window): Re-add.
3005 (Fset_window_configuration): Rewrite to handle dead buffers and
3006 consequently deletable windows.
3007 (window_tree, Fwindow_tree): Remove. Supply functionality in
3008 window.el.
3009 (compare_window_configurations): Simplify code.
3010
b6e3633c
AS
30112011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3012
1ab0dee5
AS
3013 * image.c (imagemagick_load_image): Fix type mismatch.
3014 (Fimagemagick_types): Likewise.
3015
b6e3633c
AS
3016 * window.h (replace_buffer_in_windows): Declare.
3017
9397e56f
MR
30182011-06-11 Martin Rudalics <rudalics@gmx.at>
3019
3020 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3021 Qclone_number. Remove external declaration of Qdelete_window.
3022 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3023 code.
640c8776
SM
3024 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3025 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3026 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3027 buffer list implementation.
3028 (other_buffer_safely): New function.
3029 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3030 calls to replace_buffer_in_windows and
3031 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3032 if allowed.
3033 (record_buffer): Inhibit quitting and rewrite using quittable
3034 functions. Run Qbuffer_list_update_hook if allowed.
3035 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3036 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3037 Move switch-to-buffer to window.el.
9397e56f
MR
3038 (bury-buffer): Move to window.el.
3039 (Vbuffer_list_update_hook): New variable.
3040
3041 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3042 section.
3043
3044 * window.h (resize_frame_windows): Move up in code.
3045 (Fwindow_frame): Remove EXFUN.
3046 (replace_buffer_in_all_windows): Remove prototype.
3047 (replace_buffer_in_windows_safely): Add prototype.
3048
3049 * window.c: Declare Qdelete_window static again. Move down
3050 declaration of select_count.
3051 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3052 (Fother_window): Move to window.el.
3053 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3054 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3055 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3056 window.el.
3057 (replace_buffer_in_windows): Implement by calling
3058 Qreplace_buffer_in_windows.
3059 (replace_buffer_in_all_windows): Remove with some functionality
3060 moved into replace_buffer_in_windows_safely.
3061 (replace_buffer_in_windows_safely): New function.
3062 (select_window_norecord, select_frame_norecord): Move in front
3063 of run_window_configuration_change_hook. Remove now obsolete
3064 declarations.
640c8776
SM
3065 (Fset_window_buffer): Rewrite doc-string.
3066 Call Qrecord_window_buffer.
9397e56f
MR
3067 (keys_of_window): Move binding for other-window to window.el.
3068
b50691aa
CY
30692011-06-11 Chong Yidong <cyd@stupidchicken.com>
3070
3071 * dispextern.h (struct image): Replace data member, whose int_val
3072 and ptr_val fields were not used by anything, with a single
3073 lisp_val object.
3074
3075 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3076 (gif_clear_image, gif_load, imagemagick_load_image)
3077 (gs_clear_image, gs_load): Callers changed.
3078
3f754b86
PE
30792011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3080
cca69397
PE
3081 * buffer.h: Include <time.h>, for time_t.
3082 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3083
109e28d0
PE
3084 Fix minor problems found by static checking.
3085
60737f02
PE
3086 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3087
4b66faf3
PE
3088 Make identifiers static if they are not used in other modules.
3089 * data.c (Qcompiled_function, Qframe, Qvector):
3090 * image.c (QimageMagick, Qsvg):
3091 * minibuf.c (Qmetadata):
3092 * window.c (resize_window_check, resize_root_window): Now static.
3093 * window.h (resize_window_check, resize_root_window): Remove decls.
3094
109e28d0
PE
3095 * window.c (window_deletion_count, delete_deletable_window):
3096 Remove; unused.
46a4ce9e
PE
3097 (window_body_lines): Now static.
3098 (Fdelete_other_windows_internal): Mark vars as initialized.
3099 Make sure 'resize_failed' is initialized.
3100 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3101 (resize_window_apply): Remove unused local.
3102 * window.h (delete_deletable_window): Remove decl.
3103
109e28d0 3104 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3105 (imagemagick_load_image): Fix pointer signedness problem by changing
3106 last arg from unsigned char * to char *. All uses changed.
3107 Also, fix a local for similar reasons.
3108 Remove unused locals. Remove locals to avoid shadowing.
3109 (fn_rsvg_handle_free): Remove; unused.
3110 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3111 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3112
3f754b86
PE
3113 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3114
2547adb1
CY
31152011-06-10 Chong Yidong <cyd@stupidchicken.com>
3116
3117 * image.c (gif_load): Fix omitted cast error introduced by
3118 2011-06-06 change.
3119
2c8e37d4
MR
31202011-06-10 Martin Rudalics <rudalics@gmx.at>
3121
3122 * window.h (resize_proportionally, orig_total_lines)
3123 (orig_top_line): Remove from window structure.
3124 (set_window_height, set_window_width, change_window_heights)
3125 (Fdelete_window): Remove prototypes.
3126 (resize_frame_windows): Remove duplicate declaration.
3127
440a42e3
EZ
31282011-06-10 Eli Zaretskii <eliz@gnu.org>
3129
3130 * window.h (resize_frame_windows, resize_window_check)
3131 (delete_deletable_window, resize_root_window)
3132 (resize_frame_windows): Declare prototypes.
3133
3134 * window.c (resize_window_apply): Make definition be "static" to
3135 match the prototype.
3136
562dd5e9
MR
31372011-06-10 Martin Rudalics <rudalics@gmx.at>
3138
3139 * window.c: Remove declarations of Qwindow_size_fixed,
3140 window_min_size_1, window_min_size_2, window_min_size,
3141 size_window, window_fixed_size_p, enlarge_window, delete_window.
3142 Remove static from declaration of Qdelete_window, it's
3143 temporarily needed by Fbury_buffer.
3144 (replace_window): Don't assign orig_top_line and
3145 orig_total_lines.
3146 (Fdelete_window, delete_window): Remove. Window deletion is
3147 handled by window.el.
640c8776
SM
3148 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3149 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3150 (Fdelete_other_windows): Remove. Deleting other windows is
3151 handled by window.el.
3152 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3153 handled in window.el.
3154 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3155 Window minimum sizes are handled in window.el.
3156 (shrink_windows, size_window, set_window_height)
3157 (set_window_width, change_window_heights, window_height)
3158 (window_width, CURBEG, CURSIZE, enlarge_window)
3159 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3160 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3161 handled in window.el.
3162 (make_dummy_parent): Rename to make_parent_window and give it a
3163 second argument horflag.
3164 (make_window): Don't set resize_proportionally any more.
3165 (Fsplit_window): Remove. Windows are split in window.el.
3166 (save_restore_action, save_restore_orig_size)
3167 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3168 Resize mini windows in window.el.
3169 (grow_mini_window, shrink_mini_window): Implement by calling
3170 Qresize_root_window_vertically, resize_window_check and
3171 resize_window_apply.
640c8776
SM
3172 (saved_window, Fset_window_configuration, save_window_save):
3173 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3174 resize_proportionally.
3175 (window_min_height, window_min_width): Move to window.el.
3176 (keys_of_window): Move bindings for delete-other-windows,
3177 split-window, delete-window and enlarge-window to window.el.
3178
3179 * buffer.c: Temporarily extern Qdelete_window.
3180 (Fbury_buffer): Temporarily call Qdelete_window instead of
3181 Fdelete_window (Fbury_buffer will move to window.el soon).
3182
3183 * frame.c (set_menu_bar_lines_1): Remove code handling
3184 orig_top_line and orig_total_lines.
3185
3186 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3187 set_window_height but set heights directly.
3188 (change_frame_size_1): Use resize_frame_windows.
3189
3190 * xdisp.c (init_xdisp): Don't use set_window_height but set
3191 heights directly.
3192
640c8776
SM
3193 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3194 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3195 run_window_configuration_change_hook.
3196
3197 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3198 instead of change_window_heights and run
3199 run_window_configuration_change_hook.
3200
1a13852e
MR
32012011-06-09 Martin Rudalics <rudalics@gmx.at>
3202
3203 * window.c (replace_window): Rename second argument REPLACEMENT to
3204 NEW. New third argument SETFLAG. Rewrite.
3205 (delete_window, make_dummy_parent): Call replace_window with
3206 third argument 1.
3207 (window_list_1): Move down in code.
3208 (run_window_configuration_change_hook): Move set_buffer part
3209 before select_frame_norecord part in order to unwind correctly.
3210 Rename count1 to count.
3211 (recombine_windows, delete_deletable_window, resize_root_window)
3212 (Fdelete_other_windows_internal)
3213 (Frun_window_configuration_change_hook, make_parent_window)
3214 (resize_window_check, resize_window_apply, Fresize_window_apply)
3215 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3216 (Fdelete_window_internal, Fresize_mini_window_internal):
3217 New functions.
1a13852e
MR
3218 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3219
f3d1777e
MR
32202011-06-08 Martin Rudalics <rudalics@gmx.at>
3221
496e208e
MR
3222 * window.h (window): Add some new members to window structure -
3223 normal_lines, normal_cols, new_total, new_normal, clone_number,
3224 splits, nest, prev_buffers, next_buffers.
3225 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3226 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3227
f3d1777e
MR
3228 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3229 Remove.
496e208e
MR
3230 (make_dummy_parent): Set new members of windows structure.
3231 (make_window): Move down in code. Handle new members of window
3232 structure.
3233 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3234 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3235 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3236 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3237 (Fset_window_next_buffers, Fset_window_clone_number):
3238 New functions.
496e208e
MR
3239 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3240 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3241 Doc-string fixes.
3242 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3243 Argument WINDOW can be now internal window too.
3244 (Fwindow_use_time): Move up in code.
3245 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3246 Rewrite doc-string.
3247 (Fset_window_configuration, saved_window)
3248 (Fcurrent_window_configuration, save_window_save): Handle new
3249 members of window structure.
b9e809c2
MR
3250 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3251 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3252 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3253 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3254 Qget_mru_window, Qresize_root_window,
3255 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3256 Qauto_buffer_name; staticpro them.
f3d1777e 3257
abde8f8c
MR
32582011-06-07 Martin Rudalics <rudalics@gmx.at>
3259
3260 * window.c (Fwindow_total_size, Fwindow_left_column)
3261 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3262 (Fwindow_list_1): New functions.
3263 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3264 (Fwindow_width, Fscroll_left, Fscroll_right):
3265 Use window_body_cols instead of window_box_text_cols.
3266 (delete_window, Fset_window_configuration):
3267 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3268 (delete_all_subwindows): Take a window as argument and not a
3269 structure. Rewrite.
190b47e6
MR
3270 (window_loop): Remove handling of GET_LRU_WINDOW and
3271 GET_LARGEST_WINDOW.
3272 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3273
3274 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3275 window_box_text_cols. delete_all_subwindows now takes a
3276 Lisp_Object as argument.
abde8f8c 3277
640c8776
SM
3278 * indent.c (compute_motion, Fcompute_motion):
3279 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3280
fa8a67e6
MR
3281 * frame.c (delete_frame): Call delete_all_subwindows with root
3282 window as argument.
3283
a54e3482
DC
32842011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3285
3286 * fns.c (Fputhash): Document return value.
3287
60002bf5
CY
32882011-06-06 Chong Yidong <cyd@stupidchicken.com>
3289
3290 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3291
0c671da6 32922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3293
b862a52a 3294 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3295
be44ca6c
PE
3296 Check for overflow when converting integer to cons and back.
3297 * charset.c (Fdefine_charset_internal, Fdecode_char):
3298 Use cons_to_unsigned to catch overflow.
3299 (Fencode_char): Use INTEGER_TO_CONS.
3300 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3301 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3302 * data.c (long_to_cons, cons_to_long): Remove.
3303 (cons_to_unsigned, cons_to_signed): New functions.
3304 These signal an error for invalid or out-of-range values.
3305 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3306 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3307 * font.c (Ffont_variation_glyphs):
3308 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3309 * lisp.h: Include <intprops.h>.
3310 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3311 (cons_to_signed, cons_to_unsigned): New decls.
3312 (long_to_cons, cons_to_long): Remove decls.
3313 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3314 (Fprimitive_undo): Use CONS_TO_INTEGER.
3315 * xfns.c (Fx_window_property): Likewise.
3316 * xselect.c: Include <limits.h>.
3317 (x_own_selection, selection_data_to_lisp_data):
3318 Use INTEGER_TO_CONS.
3319 (x_handle_selection_request, x_handle_selection_clear)
3320 (x_get_foreign_selection, Fx_disown_selection_internal)
3321 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3322 (lisp_data_to_selection_data): Use cons_to_unsigned.
3323 (x_fill_property_data): Use cons_to_signed.
3324 Report values out of range.
3325
d1f3d2af
PE
3326 Check for buffer and string overflow more precisely.
3327 * buffer.h (BUF_BYTES_MAX): New macro.
3328 * lisp.h (STRING_BYTES_MAX): New macro.
3329 * alloc.c (Fmake_string):
3330 * character.c (string_escape_byte8):
3331 * coding.c (coding_alloc_by_realloc):
3332 * doprnt.c (doprnt):
3333 * editfns.c (Fformat):
3334 * eval.c (verror):
3335 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3336 since they may not be the same number.
3337 * editfns.c (Finsert_char):
3338 * fileio.c (Finsert_file_contents):
3339 Likewise for BUF_BYTES_MAX.
3340
dd52fcea
PE
3341 * image.c: Use ptrdiff_t, not int, for sizes.
3342 (slurp_file): Switch from int to ptrdiff_t.
3343 All uses changed.
3344 (slurp_file): Check that file size fits in both size_t (for
3345 malloc) and ptrdiff_t (for sanity and safety).
3346
7f9bbdbb
PE
3347 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3348 if b->modtime has its maximal value.
3349
dfe18f82
PE
3350 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3351
84acfcf0
PE
3352 Don't assume time_t can fit into int.
3353 * buffer.h (struct buffer.modtime): Now time_t, not int.
3354 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3355 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3356
ccd9a01a
PE
3357 Minor fixes for signed vs unsigned integers.
3358 * character.h (MAYBE_UNIFY_CHAR):
3359 * charset.c (maybe_unify_char):
3360 * keyboard.c (read_char, reorder_modifiers):
3361 XINT -> XFASTINT, since the integer must be nonnegative.
3362 * ftfont.c (ftfont_spec_pattern):
3363 * keymap.c (access_keymap, silly_event_symbol_error):
3364 XUINT -> XFASTINT, since the integer must be nonnegative.
3365 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3366 since it makes no difference and we prefer signed.
3367 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3368 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3369 nonnegative.
3370
d6d100dd
SM
33712011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3372
3373 * window.h (Fwindow_frame): Declare.
3374
2b6148e4
PE
33752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3376
3377 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3378 (SPARE_MEMORY): Always define.
3379 (LARGE_REQUEST): Remove.
3380 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3381
f230ecc9
MR
33822011-06-06 Martin Rudalics <rudalics@gmx.at>
3383
727e958e
MR
3384 * lisp.h: Move EXFUNS for Fframe_root_window,
3385 Fframe_first_window and Fset_frame_selected_window to window.h.
3386
3387 * window.h: Move EXFUNS for Fframe_root_window,
3388 Fframe_first_window and Fset_frame_selected_window here from
3389 lisp.h.
3390
3391 * frame.c (Fwindow_frame, Fframe_first_window)
3392 (Fframe_root_window, Fframe_selected_window)
3393 (Fset_frame_selected_window): Move to window.c.
3394 (Factive_minibuffer_window): Move to minibuf.c.
3395 (Fother_visible_frames_p): New function.
3396
3397 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3398
f230ecc9
MR
3399 * window.c (decode_window, decode_any_window): Move up in code.
3400 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3401 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3402 (Fwindow_buffer): Move up and rewrite doc-string.
3403 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3404 (Fwindow_prev): New functions.
727e958e
MR
3405 (Fwindow_frame): Move here from frame.c. Accept any window as
3406 argument.
3407 (Fframe_root_window, Fframe_first_window)
3408 (Fframe_selected_window): Move here from frame.c. Accept frame
3409 or arbitrary window as argument. Update doc-strings.
3410 (Fminibuffer_window): Move up in code.
3411 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3412 (Fset_frame_selected_window): Move here from frame.c.
3413 Marginal rewrite.
727e958e
MR
3414 (Fselected_window, select_window, Fselect_window): Move up in
3415 code. Minor doc-string fixes.
f230ecc9 3416
4d09bcf6
PE
34172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3418
3419 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3420 Do not assume that spare memory exists; that assumption is valid
3421 only if SYSTEM_MALLOC.
3422 (LARGE_REQUEST): New macro, so that the issue of large requests
3423 is separated from the issue of spare memory.
3424
810928a2
AS
34252011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3426
172418ad
AS
3427 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3428 format. (Bug#8806)
3429
43f862f7
AS
3430 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3431
810928a2
AS
3432 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3433 before statements.
3434
a059fe24
JD
34352011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3436
3437 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3438
3439 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3440
3441 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3442 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3443
989bf368
JB
34442011-06-05 Juanma Barranquero <lekktu@gmail.com>
3445
3446 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3447
4b80f674
CY
34482011-06-04 Chong Yidong <cyd@stupidchicken.com>
3449
3450 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3451 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3452 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3453 New error handlers.
4b80f674
CY
3454 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3455 Obey Vx_select_enable_clipboard_manager. Catch errors in
3456 x_clipboard_manager_save (Bug#8779).
3457 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3458 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3459
99a33b77 34602011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3461
3462 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3463
99a33b77 34642011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3465
3466 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3467 in the current matrix if keep_current_p is non-zero.
3468
8264569d
EZ
34692011-06-04 Eli Zaretskii <eliz@gnu.org>
3470
3471 * bidi.c (bidi_level_of_next_char): Fix last change.
3472
57f97249
EZ
34732011-06-03 Eli Zaretskii <eliz@gnu.org>
3474
fec2107c 3475 Support bidi reordering of text covered by display properties.
57f97249 3476
fec2107c
EZ
3477 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3478 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3479 (bidi_cache_search, bidi_cache_iterator_state)
3480 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3481 (bidi_level_of_next_char, bidi_move_to_visually_next):
3482 Support character positions inside a run of characters covered by a
fec2107c
EZ
3483 display string.
3484 (bidi_paragraph_init, bidi_resolve_explicit_1)
3485 (bidi_level_of_next_char): Call bidi_fetch_char and
3486 bidi_fetch_char_advance instead of FETCH_CHAR and
3487 FETCH_CHAR_ADVANCE.
3488 (bidi_init_it): Initialize new members.
3489 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3490 definitions.
3491 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3492 instead of using explicit *_CHAR codes.
d6d100dd
SM
3493 (bidi_resolve_explicit, bidi_resolve_weak):
3494 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3495 bidirectional text is supported only in multibyte buffers.
3496 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3497 it to initialize the frame_window_p member of struct bidi_it.
3498 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3499 (bidi_resolve_explicit, bidi_resolve_weak)
3500 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3501 bidi_it->nchars is non-positive.
3502 (bidi_level_of_next_char): Don't try to lookup the cache for the
3503 next/previous character if nothing is cached there yet, or if we
3504 were just reseat()'ed to a new position.
c40e2fb2 3505
0e14fe90
EZ
3506 * xdisp.c (set_cursor_from_row): Set start and stop points
3507 according to the row's direction when priming the loop that looks
3508 for the glyph on which to display cursor.
3509 (single_display_spec_intangible_p): Function deleted.
3510 (display_prop_intangible_p): Reimplement to call
3511 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3512 Accept 3 additional arguments needed by handle_display_spec.
3513 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3514 values: lists, `(when COND...)' forms, etc.
3515 (single_display_spec_string_p): Support property values that are
3516 lists with the argument STRING its top-level element.
3517 (display_prop_string_p): Fix the condition for processing a
3518 property that is a list to be consistent with handle_display_spec.
fec2107c 3519 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3520 last portion of handle_display_prop.
3521 (compute_display_string_pos): Accept additional argument
3522 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3523 value of a `display' property is a "replacing spec".
3524 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3525 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3526 the display property, but just return a value indicating whether
3527 the display property will replace the characters it covers.
3528 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3529 frame_window_p members of struct bidi_it.
d6d100dd
SM
3530 (compute_display_string_pos, compute_display_string_end):
3531 New functions.
fec2107c
EZ
3532 (push_it): Accept second argument POSITION, where pop_it should
3533 jump to continue iteration.
3534 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3535
fec2107c
EZ
3536 * keyboard.c (adjust_point_for_property): Adjust the call to
3537 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3538
3539 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3540 (bidi_init_it): Update prototypes.
3541 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3542 (compute_display_string_pos, compute_display_string_end):
3543 Declare prototypes.
fec2107c
EZ
3544 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3545 EMACS_INT.
fc6f18ce 3546
40087514 35472011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3548
57f53182
PE
3549 Malloc failure behavior now depends on size of allocation.
3550 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3551 * lisp.h: Change signatures accordingly.
3552 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3553 All callers changed. (Bug#8762)
3554
3555 * gnutls.c: Use Emacs's memory allocators.
3556 Without this change, the gnutls library would invoke malloc etc.
3557 directly, which causes problems on non-SYNC_INPUT hosts, and which
3558 runs afoul of improving memory_full behavior. (Bug#8761)
3559 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3560 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3561 xfree instead of the default malloc, realloc, free.
3562 (Fgnutls_boot): No need to check for memory allocation failure,
3563 since xmalloc does that for us.
3564
ac32cd99 3565 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3566 * category.c (hash_get_category_set):
3567 * ccl.c (ccl_driver):
3568 * charset.c (Fdefine_charset_internal):
3569 * charset.h (struct charset.hash_index):
3570 * composite.c (get_composition_id, gstring_lookup_cache)
3571 (composition_gstring_put_cache):
3572 * composite.h (struct composition.hash_index):
3573 * dispextern.h (struct image.hash):
3574 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3575 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3576 (hashfn_equal, hashfn_user_defined, make_hash_table)
3577 (maybe_resize_hash_table, hash_lookup, hash_put)
3578 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3579 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3580 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3581 * image.c (make_image, search_image_cache, lookup_image)
3582 (xpm_put_color_table_h):
3583 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3584 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3585 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3586 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3587 * alloc.c (allocate_vectorlike):
3588 Check for overflow in vector size calculations.
3589 * ccl.c (ccl_driver):
3590 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3591 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3592 need to be updated by these changes.
40087514
PE
3593 * fns.c (make_hash_table, maybe_resize_hash_table):
3594 Check for integer overflow with large hash tables.
0de4bb68
PE
3595 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3596 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3597 (SXHASH_REDUCE): New macro.
3598 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3599 Use it instead of discarding useful hash info with large hash values.
3600 (sxhash_float): New function.
3601 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3602 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3603 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3604 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3605 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3606 Adjust signatures to match updated version of code.
3607 (consing_since_gc): Now EMACS_INT, since a single hash table can
3608 use more than INT_MAX bytes.
3609
698d32e2
DN
36102011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3611
3612 Make it possible to build with GCC-4.6+ -O2 -flto.
3613
3614 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3615
fd6fa53f
SM
36162011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3617
3618 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3619 Call minibuffer-inactive-mode.
3620
864db017
JB
36212011-05-31 Juanma Barranquero <lekktu@gmail.com>
3622
3623 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3624 Update dependencies.
3625
2ad0baf4
DN
36262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3627
3628 * data.c (init_data): Remove code for UTS, this system is not
3629 supported anymore.
3630
4fcc2638
DN
36312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3632
3633 Don't force ./temacs to start in terminal mode.
3634
3635 * frame.c (make_initial_frame): Initialize faces in all cases, not
3636 only when CANNOT_DUMP is defined.
3637 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3638
c56e0fd5
DN
36392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3640
3641 * dispnew.c (add_window_display_history): Use const for the string
3642 pointer. Remove declaration, not needed.
3643
333d54da 36442011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3645
55d4c1b2 3646 Use 'inline', not 'INLINE'.
333d54da 3647 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3648 * alloc.c, fontset.c (INLINE): Remove.
3649 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3650 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3651 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3652 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3653 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3654
738db178
DN
36552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3656
3657 Make it possible to run ./temacs.
3658
3659 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3660 syms_of_callproc does the same thing. Remove test for
3661 "initialized", do it in the caller.
3662 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3663
620c53a6
SM
36642011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3665
3666 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3667 (read_minibuf): Use get_minibuffer.
3668 (syms_of_minibuf): Use DEFSYM.
3669 (Qmetadata): New var.
3670 * data.c (Qbuffer): Don't make it static.
3671 (syms_of_data): Use DEFSYM.
3672
e003a292
PE
36732011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3674
3675 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3676 (CCL_CODE_MIN): New macro.
3677
ed008a6d
PE
36782011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3679
3687c2ef
PE
3680 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3681
ed008a6d
PE
3682 * eval.c (Qdebug): Now static.
3683 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3684 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3685 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3686
d66c4c7c
CY
36872011-05-29 Chong Yidong <cyd@stupidchicken.com>
3688
3689 * image.c: Various fixes to ImageMagick code comments.
3690 (Fimagemagick_types): Doc fix.
3691
5fbc2025
PE
36922011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3693
0196f88a
PE
3694 Minor fixes prompted by GCC 4.6.0 warnings.
3695
3696 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3697
5fbc2025
PE
3698 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3699 (x_clipboard_manager_save_all): Move extern decl to ...
3700 * xterm.h: ... here, so that it can be checked for consistency.
3701
1dd3c2d9
CY
37022011-05-29 Chong Yidong <cyd@stupidchicken.com>
3703
3704 * xselect.c (x_clipboard_manager_save_frame)
3705 (x_clipboard_manager_save_all): New functions.
3706 (Fx_clipboard_manager_save): Lisp function deleted.
3707
3708 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3709 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3710
3711 * xterm.h: Update prototype.
3712
5ba6571d
WX
37132011-05-28 William Xu <william.xwl@gmail.com>
3714
3715 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3716 exiting (Bug#8239).
3717
3eaff834
JM
37182011-05-28 Jim Meyering <meyering@redhat.com>
3719
e1900994 3720 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3721 * fns.c (to_uchar): Define.
3722 (crypto_hash_function): Use it to convert some newly-signed
3723 variables to unsigned, to avoid sign-extension bugs. For example,
3724 without this change, (md5 "truc") would evaluate to
3725 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3726 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3727 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3728
0f6990a7
PE
37292011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3730
3731 Integer overflow fixes.
c8a9ca5a 3732
08686060
PE
3733 * dbusbind.c: Serial number integer overflow fixes.
3734 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3735 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3736 to hold a serial number that is too large for a fixnum.
3737 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3738 Check for serial numbers out of range. Decode any serial number
59568bf0 3739 that was so large that it became a float. (Bug#8722)
08686060 3740
2d1fc3c7
PE
3741 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3742 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3743 Use XFASTINT rather than XUINT when numbers are nonnegative.
3744 (xd_append_arg, Fdbus_method_return_internal):
3745 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3746 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3747 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3748 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3749 (Bug#8722)
2d1fc3c7 3750
c8a9ca5a
PE
3751 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3752
519e1d69
PE
3753 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3754
30569699
PE
3755 ccl: add integer overflow checks
3756 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3757 (IN_INT_RANGE): New macros.
3758 (ccl_driver): Use them to check for integer overflow when
3759 decoding a CCL program. Many of the new checks are whether XINT (x)
3760 fits in int; it doesn't always, on 64-bit hosts. The new version
3761 doesn't catch all possible integer overflows, but it's an
847044ea 3762 improvement. (Bug#8719)
30569699 3763
c11285dc
PE
3764 * alloc.c (make_event_array): Use XINT, not XUINT.
3765 There's no need for unsigned here.
3766
fdccd48e
PE
3767 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3768 This follows up to the 2011-05-06 change that substituted uintptr_t
3769 for EMACS_INT. This case wasn't caught back then.
3770
37910ab2
PE
3771 Rework Fformat to avoid integer overflow issues.
3772 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3773 now (part of C89). Include <verify.h>.
3774 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3775 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3776 (Fformat): Avoid the prepass trying to compute sizes; it was only
3777 approximate and thus did not catch overflow reliably. Instead, walk
3778 through the format just once, formatting and computing sizes as we go,
3779 checking for integer overflow at every step, and allocating a larger
3780 buffer as needed. Keep track separately whether the format is
3781 multibyte. Keep only the most-recently calculated precision, rather
3782 than them all. Record whether each argument has been converted to
3783 string. Use EMACS_INT, not int, for byte and char and arg counts.
3784 Support field widths and precisions larger than INT_MAX. Avoid
3785 sprintf's undefined behavior with conversion specifications such as %#d
3786 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3787 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3788 formatting out-of-range floating point numbers with int
9173deec 3789 formats. (Bug#8668)
37910ab2 3790
2e6578fb
PE
3791 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3792
0ae6bdee
PE
3793 * data.c: Avoid integer truncation in expressions involving floats.
3794 * data.c: Include <intprops.h>.
3795 (arith_driver): When there's an integer overflow in an expression
3796 involving floating point, convert the integers to floating point
3797 so that the resulting value does not suffer from catastrophic
3798 integer truncation. For example, on a 64-bit host (* 4
3799 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3800 Do not rely on undefined behavior after integer overflow.
3801
de883a70
PE
3802 merge count_size_as_multibyte, parse_str_to_multibyte
3803 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3804 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3805 Check for integer overflow.
3806 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3807 since it's now a duplicate of the other. This is more of
3808 a character than a buffer op, so better that it's in character.c.
3809 * fns.c, print.c: Adjust to above changes.
3810
2ff916cb
PE
38112011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3812
3813 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3814
f1b54466
PE
38152011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3816
fb1ac845
PE
3817 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3818 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3819 (x_clipboard_manager_save): Now static.
3820 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3821
f1b54466
PE
3822 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3823 (crypto_hash_function): Now static.
3824 Fix pointer signedness problems. Avoid unnecessary initializations.
3825
a9f737ee
CY
38262011-05-27 Chong Yidong <cyd@stupidchicken.com>
3827
3828 * termhooks.h (Vselection_alist): Make it terminal-local.
3829
3830 * terminal.c (create_terminal): Initialize it.
3831
3832 * xselect.c: Support for clipboard managers.
3833 (Vselection_alist): Move to termhooks.h as terminal-local var.
3834 (LOCAL_SELECTION): New macro.
3835 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3836 (symbol_to_x_atom): Remove gratuitous arg.
3837 (x_handle_selection_request, lisp_data_to_selection_data)
3838 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3839 (x_own_selection, x_get_local_selection, x_convert_selection):
3840 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3841 (some_frame_on_display): Delete unused function.
3842 (Fx_own_selection_internal, Fx_get_selection_internal)
3843 (Fx_disown_selection_internal, Fx_selection_owner_p)
3844 (Fx_selection_exists_p): New optional frame arg.
3845 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3846 (x_handle_selection_clear): Don't treat other terminals with the
3847 same keyboard specially. Use the terminal-local Vselection_alist.
3848 (x_clear_frame_selections): Use Frun_hook_with_args.
3849
3850 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3851
3852 * xterm.h: Add support for those atoms.
3853
e067f0c1
CY
38542011-05-26 Chong Yidong <cyd@stupidchicken.com>
3855
3856 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3857 (converted_selections, conversion_fail_tag): New global variables.
3858 (x_selection_request_lisp_error): Free the above.
3859 (x_get_local_selection): Remove unnecessary code.
3860 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3861 of converted selections stored in converted_selections.
3862 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3863 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3864 (x_convert_selection): New function.
3865 (x_handle_selection_event): Simplify.
3866 (x_get_foreign_selection): Don't ignore incoming requests while
3867 waiting for an answer; this will fail when we implement
3868 SAVE_TARGETS, and seems unnecessary anyway.
3869 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3870 (Vx_sent_selection_functions): Doc fix.
3871
0f4aebc0
LL
38722011-05-26 Leo Liu <sdl.web@gmail.com>
3873
3874 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3875
e61124cd
YM
38762011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3877
3878 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3879
3880 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3881 for fringe update if it has periodic bitmap.
ac389d0c 3882 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3883 and fringe_bitmap_periodic_p.
3884
3885 * fringe.c (get_fringe_bitmap_data): New function.
3886 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3887 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3888 row. Mark glyph row for fringe update if periodicity changed.
3889
3890 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3891 for fringe update unless it has periodic bitmap.
3892
f16d9837
KH
38932011-05-25 Kenichi Handa <handa@m17n.org>
3894
3895 * xdisp.c (get_next_display_element): Set correct it->face_id for
3896 a static composition.
3897
e1b90ef6
LL
38982011-05-24 Leo Liu <sdl.web@gmail.com>
3899
3900 * deps.mk (fns.o):
3901 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3902
3903 * fns.c (crypto_hash_function, Fsha1): New function.
3904 (Fmd5): Use crypto_hash_function.
3905 (syms_of_fns): Add Ssha1.
3906
7400048f
PE
39072011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3908
3909 * gnutls.c: Remove unused macros.
3910 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3911 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3912 Remove macros that are defined and never used.
3913 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3914
abb71cf4
CY
39152011-05-22 Chong Yidong <cyd@stupidchicken.com>
3916
3917 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3918 (Fx_get_selection_internal): Minor cleanup.
3919 (Fx_own_selection_internal): Rename arguments for consistency with
3920 select.el.
3921
6307db39
PE
39222011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3923
3924 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3925
f3d4e0a4
CY
39262011-05-22 Chong Yidong <cyd@stupidchicken.com>
3927
3928 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3929
4d8ade89
YM
39302011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3931
3932 * dispnew.c (scrolling_window): Don't exclude the case that the
3933 last enabled row in the desired matrix touches the bottom boundary.
3934
32078c8d
GM
39352011-05-21 Glenn Morris <rgm@gnu.org>
3936
3937 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3938 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3939 and add some more files.
32078c8d 3940
7285dc67
EZ
39412011-05-20 Eli Zaretskii <eliz@gnu.org>
3942
3943 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3944 report_file_error introduced by the change from 2011-05-07.
3945
89d1bd22
PE
39462011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3947
3948 * systime.h (Time): Define only if emacs is defined.
3949 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3950 where the include path doesn't have X11/X.h by default. See
3951 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3952
e23640bb 39532011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3954
3955 * composite.c (find_automatic_composition): Fix previous change.
3956
b9704ad9
GM
39572011-05-20 Glenn Morris <rgm@gnu.org>
3958
3959 * lisp.mk: New file, split from Makefile.in.
3960 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3961 (shortlisp): Remove.
3962 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3963
4a720484
GM
39642011-05-19 Glenn Morris <rgm@gnu.org>
3965
3966 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3967 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3968 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3969 (lisp): Set the order to that of loadup.el.
3970 (shortlisp): Make it a copy of $lisp.
3971 (SOME_MACHINE_LISP): Remove.
3972 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3973 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3974
a28d4396
KH
39752011-05-18 Kenichi Handa <handa@m17n.org>
3976
3977 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3978 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3979 (find_automatic_composition): Mostly rewrite for efficiency.
3980
a2b1fa8e
JB
39812011-05-18 Juanma Barranquero <lekktu@gmail.com>
3982
3983 * makefile.w32-in: Update dependencies.
3984
8e1f5610
CS
39852011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3986
3987 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3988 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3989
7025ee00 39902011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3991
cdfa6eab
PE
3992 Fix some integer overflow issues, such as string length overflow.
3993
06d6db33
PE
3994 * insdel.c (count_size_as_multibyte): Check for string overflow.
3995
2b4560a8
PE
3996 * character.c (lisp_string_width): Check for string overflow.
3997 Use EMACS_INT, not int, for string indexes and lengths; in
3998 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3999 the resulting string length overflows an EMACS_INT; instead,
4000 report a string overflow if no precision given. When checking for
4001 precision exhaustion, use a check that cannot possibly have
4002 integer overflow. (Bug#8675)
4003 * character.h (lisp_string_width): Adjust to new signature.
4004
cb93f9be
PE
4005 * alloc.c (string_overflow): New function.
4006 (Fmake_string): Use it. This doesn't change behavior, but saves
4007 a few bytes and will simplify future changes.
4008 * character.c (string_escape_byte8): Likewise.
4009 * lisp.h (string_overflow): New decl.
4010
1a1f3366
PE
4011 Fixups, following up to the user-interface timestamp change.
4012 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4013 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4014 * msdos.c (mouse_get_pos): Likewise.
4015 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4016 * w32gui.h (Time): Define by including "systime.h" rather than by
4017 declaring it ourselves. (Bug#8664)
4018
d4e3e4d3
PE
4019 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4020 * image.c (clear_image_cache): Likewise.
4021
f6a24d19
PE
4022 * term.c (term_mouse_position): Don't assume time_t wraparound.
4023
08dc5ae6
PE
4024 Be more systematic about user-interface timestamps.
4025 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4026 and sometimes 'EMACS_UINT', to represent these timestamps.
4027 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4028 This makes the code easier to follow, and makes it easier to catch
4029 integer overflow bugs such as Bug#8664.
4030 * frame.c (Fmouse_position, Fmouse_pixel_position):
4031 Use Time, not unsigned long, for user-interface timestamps.
4032 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4033 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4034 * keyboard.h (last_event_timestamp): Likewise.
4035 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4036 * menu.h (xmenu_show): Likewise.
4037 * term.c (term_mouse_position): Likewise.
4038 * termhooks.h (struct input_event.timestamp): Likewise.
4039 (struct terminal.mouse_position_hook): Likewise.
4040 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4041 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4042 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4043 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4044 what it was before.
4045 * menu.h, termhooks.h: Include "systime.h", for Time.
4046
8e55734a
PE
4047 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4048 Don't assume that the difference between two unsigned long values
4049 can fit into an integer. At this point, we know button_down_time
4050 <= event->timestamp, so the difference must be nonnegative, so
4051 there's no need to cast the result if double-click-time is
4052 nonnegative, as it should be; check that it's nonnegative, just in
4053 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4054 apart (about 25 days). (Bug#8664)
8e55734a 4055
841f1b75 4056 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4057 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4058
3e26f69c
PE
4059 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4060 that always fit in int. Use a sentinel instead of a counter, to
4061 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4062 * frame.h (struct frame): Use int for menu_bar_items_used
4063 instead of EMACS_INT, since it always fits in int.
3e26f69c 4064
5cc152c0
PE
4065 * menu.c (grow_menu_items): Check for int overflow.
4066
d89eb65e
PE
4067 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4068
5235bd3e
PE
4069 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4070 Before, the code was not consistent. These values cannot exceed
4071 2**31 - 1 so there's no need to make them unsigned.
4072 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4073 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4074 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4075 as modifiers.
4076 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4077
bc827e23
PE
4078 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4079 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4080 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4081 presumably because the widths might not match.
4082
78eb494e
PE
4083 * window.c (size_window): Avoid needless test at loop start.
4084
04f2d78b
CB
40852011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4086
4087 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4088
d2fc7e3d 40892011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4090
4091 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4092
d2fc7e3d 40932011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4094
4095 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4096 `width' to `bar_area_x' and `bar_area_width', respectively.
4097 (x_scroll_run): Take account of fringe background extension.
4098
04f2d78b
CB
4099 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4100 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4101 `bar_area_width', respectively.
4102 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4103 background extension.
4104
79b70037
GM
41052011-05-10 Jim Meyering <meyering@redhat.com>
4106
4107 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4108
2f142cc5
JB
41092011-05-10 Juanma Barranquero <lekktu@gmail.com>
4110
4111 * image.c (Finit_image_library): Return t for built-in image types,
4112 like pbm and xbm. (Bug#8640)
4113
57679c86
AS
41142011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4115
4116 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4117
888c9e86
EZ
41182011-05-07 Eli Zaretskii <eliz@gnu.org>
4119
b0512a1d
EZ
4120 * w32console.c (Fset_screen_color): Doc fix.
4121 (Fget_screen_color): New function.
4122 (syms_of_ntterm): Defsubr it.
4123
7285dc67
EZ
4124 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4125 unlink the temporary file if Fcall_process didn't create it in the
4126 first place.
4127 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4128 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4129 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4130 cue to call_process_cleanup not to close that handle.
4131
4d3fcc8e
BK
41322011-05-07 Ben Key <bkey76@gmail.com>
4133
4134 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4135 one of two shell specific rules, either bootstrap-temacs-CMD or
4136 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4137 to the previous implementation of the bootstrap-temacs rule.
4138 The bootstrap-temacs-CMD rule is similar to the previous
4139 implementation of the bootstrap-temacs rule except that it
4140 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4141 variable.
4142
4143 These changes, along with some changes to nt/configure.bat,
4144 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4145 earlier fix to add support for --cflags and --ldflags options
4146 that include quotes so that it works whether make uses cmd or
4147 sh as the shell.
4148
b4289b64
MA
41492011-05-06 Michael Albinus <michael.albinus@gmx.de>
4150
4151 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4152 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4153 is a constant.
4154 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4155 a string. Handle both cases.
4156 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4157 (Fdbus_register_method): Use Qinvalid_function.
4158
af4c0e28
JB
41592011-05-06 Juanma Barranquero <lekktu@gmail.com>
4160
4161 * makefile.w32-in: Update dependencies.
4162 (LISP_H): Add inttypes.h and stdin.h.
4163 (PROCESS_H): Add unistd.h.
4164
c51453d9
EZ
41652011-05-06 Eli Zaretskii <eliz@gnu.org>
4166
4167 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4168 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4169
8ff0ac3c 41702011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4171
4c4b566b
PE
4172 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4173
aab2b9b5
PE
4174 * term.c (vfatal): Remove stray call to va_end.
4175 It's not needed and the C Standard doesn't allow it here anyway.
4176
c378da0b
PE
4177 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4178 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4179
288b08c7
PE
4180 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4181 bytes.
4182
e3601888
PE
4183 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4184
db6c0e74
PE
4185 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4186
dd5963ea
PE
4187 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4188
88c9450f
PE
4189 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4190
2f9442b8
PE
4191 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4192
c032b5f8
PE
4193 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4194 * charset.c (Fdefine_charset_internal): Don't initialize
4195 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4196 32-bit int (Bug#8600).
a108c10b
PE
4197
4198 * lread.c (read_integer): Be more consistent with string-to-number.
4199 Use string_to_number to do the actual conversion; this avoids
4200 rounding errors and fixes some other screwups. Without this fix,
4201 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4202 (digit_to_number): Move earlier, for benefit of read_integer.
4203 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4204 not a digit in any supported base. (Bug#8602)
a108c10b 4205
ad5f9eea
PE
4206 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4207
aec1708a
PE
4208 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4209 to match comment at start of function. This also removes a
4210 GCC warning about overflow in a 32+64-bit port.
4211
47be4ab5
PE
4212 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4213
371cac43
PE
4214 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4215 Reported by Stefan Monnier in
4216 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4217 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4218 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4219
d01a7826
PE
4220 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4221 (EMACS_UINTPTR): Likewise, with uintptr_t.
4222
7fd47d5c
PE
4223 * lisp.h: Prefer 64-bit EMACS_INT if available.
4224 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4225 on 32-bit hosts that have 64-bit int, so that they can access
4226 large files.
122b0c86
PE
4227 However, temporarily disable this change unless the temporary
4228 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4229
8727937b
PE
4230 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4231
8ac068ac
PE
4232 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4233 This removes an assumption that EMACS_INT and long are the same
4234 width as pointers. The assumption is true for Emacs porting targets
4235 now, but we want to make other targets possible.
4236 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4237 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4238 In the rest of the code, change types of integers that hold casted
4239 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4240 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4241 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4242 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4243 No need to cast type when ORing.
4244 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4245 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4246 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4247 assume EMACS_INT is the same width as char *.
4248 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4249 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4250 Remove no-longer-needed casts.
4251 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4252 (xg_tool_bar_help_callback, xg_make_tool_item):
4253 Use EMACS_INTPTR to hold an integer
4254 that will be cast to void *; this can avoid a GCC warning
4255 if EMACS_INT is not the same width as void *.
4256 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4257 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4258 (current_message_1, set_message_1):
4259 Use a local to convert to proper width without a cast.
4260 * xmenu.c (dialog_selection_callback): Likewise.
4261
ede49d71
PE
4262 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4263 Also, don't assume VALBITS / RAND_BITS is less than 5,
4264 and don't rely on undefined behavior when shifting a 1 left into
4265 the sign bit.
4266 * lisp.h (get_random): Change signature to match.
4267
2f30ecd0
PE
4268 * lread.c (hash_string): Use size_t, not int, for hash computation.
4269 Normally we prefer signed values; but hashing is special, because
4270 it's better to use unsigned division on hash table sizes so that
4271 the remainder is nonnegative. Also, size_t is the natural width
4272 for hashing into memory. The previous code used 'int', which doesn't
4273 retain enough info to hash well into very large tables.
4274 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4275
2a866e7b
PE
4276 * dbusbind.c: Don't possibly lose pointer info when converting.
4277 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4278 Use XPNTR rather than XHASH, so that the high-order bits of
4279 the pointer aren't lost when converting through void *.
4280
51639eac
PE
4281 * eval.c (Fautoload): Don't double-shift a pointer.
4282
92394119
PE
4283 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4284
dbdb9a7c
JB
42852011-05-06 Juanma Barranquero <lekktu@gmail.com>
4286
4287 * gnutls.c (DEF_GNUTLS_FN):
4288 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4289
db7a0b4f
AS
42902011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4291
4292 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4293 marker. (Bug#8610)
4294
f7ff1b0f 42952011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4296
4297 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4298 New version that can reserve upto 2GB of heap space.
4299
f7ff1b0f 43002011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4301
4302 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4303
639c109b
TZ
43042011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4305
4306 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4307 `gnutls_certificate_set_x509_key_file'.
4308
d2127135
JB
43092011-05-05 Juanma Barranquero <lekktu@gmail.com>
4310
4311 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4312 Update dependencies.
4313
e968f4f3
JB
43142011-05-04 Juanma Barranquero <lekktu@gmail.com>
4315
4316 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4317 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4318 Remove unused parameter `fildes'.
4319 * process.c (read_process_output, send_process): Don't pass it.
4320
84d358f0
JB
43212011-05-04 Juanma Barranquero <lekktu@gmail.com>
4322
4323 Fix previous change: the library cache is defined in w32.c.
4324 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4325 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4326
0898ca10
JB
43272011-05-04 Juanma Barranquero <lekktu@gmail.com>
4328
4329 Implement dynamic loading of GnuTLS on Windows.
4330
4331 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4332 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4333 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4334 Declare.
4335
4336 * gnutls.c (Qgnutls_dll): Define.
4337 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4338 (gnutls_*): Declare function pointers.
4339 (init_gnutls_functions): New function to initialize function pointers.
4340 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4341 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4342 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4343 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4344 (emacs_gnutls_write, emacs_gnutls_read)
4345 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4346 (Fgnutls_available_p): New function.
4347 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4348 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4349 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4350
4351 * image.c: Include w32.h.
4352 (Vimage_type_cache): Delete.
4353 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4354 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4355 (w32_delayed_load): Move to w32.c.
4356
4357 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4358
4359 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4360 (w32_delayed_load): Move from image.c. When loading a library, record
4361 its filename in the :loaded-from property of the library id.
4362 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4363 Initialize and staticpro them.
4364 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4365
4366 * process.c: Include lisp.h before w32.h, not after.
4367 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4368 instead of gnutls_record_check_pending.
4369
4370 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4371
ff4de4aa
TZ
43722011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4373
4374 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4375 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4376 as passed in.
4377
abe95abb
JD
43782011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4379
4380 * xterm.c (x_set_frame_alpha): Do not set property on anything
4381 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4382
e16e55d4
JB
43832011-05-02 Juanma Barranquero <lekktu@gmail.com>
4384
4385 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4386
bafcf6a5
JB
43872011-05-02 Juanma Barranquero <lekktu@gmail.com>
4388
4389 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4390 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4391 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4392 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4393 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4394 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4395 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4396 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4397 (Qgnutls_bootprop_callbacks_verify): Make static.
4398
e7a6747f
AS
43992011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4400
19ed11ba
AS
4401 * callproc.c: Indentation fixup.
4402
e7a6747f 4403 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4404 (wait_for_termination, interruptible_wait_for_termination):
4405 Move after wait_for_termination_1.
e7a6747f 4406
1ef14cb4
LMI
44072011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4408
4409 * sysdep.c (interruptible_wait_for_termination): New function
4410 which is like wait_for_termination, but allows keyboard
4411 interruptions.
4412
4413 * callproc.c (Fcall_process): Add (:file "file") as an option for
4414 the STDOUT buffer.
4415 (Fcall_process_region): Ditto.
4416
330d880c
EZ
44172011-04-30 Eli Zaretskii <eliz@gnu.org>
4418
8db90b73
EZ
4419 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4420 rather than `XVECTOR (FOO)->size'.
4421
330d880c
EZ
4422 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4423 inttypes.h, as a gnulib replacement is used if it not available in
4424 system headers.
4425
15cbd324
EZ
44262011-04-21 Eli Zaretskii <eliz@gnu.org>
4427
4428 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4429 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4430 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4431
4432 * coding.c (coding_alloc_by_realloc): Error out if destination
4433 will grow beyond MOST_POSITIVE_FIXNUM.
4434 (decode_coding_emacs_mule): Abort if there isn't enough place in
4435 charbuf for the composition carryover bytes. Reserve an extra
4436 space for up to 2 characters produced in a loop.
4437 (decode_coding_iso_2022): Abort if there isn't enough place in
4438 charbuf for the composition carryover bytes.
4439
44402011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4441
ae940cca
EZ
4442 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4443 aborting when %lld or %lll format is passed.
4444 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4445 %llo or %llx format is passed. (Bug#8545)
4446
03ab8921
EZ
4447 * window.c (window_scroll_line_based): Use a marker instead of
4448 simple variables to record original value of point. (Bug#7952)
4449
afda1437
EZ
4450 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4451 produced by %s or %c overflows available buffer space. (Bug#8545)
4452
f76dee0c
PE
44532011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4454
4455 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4456 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4457
fdc5744d
JB
44582011-04-28 Juanma Barranquero <lekktu@gmail.com>
4459
4460 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4461
638f053a
JB
44622011-04-28 Juanma Barranquero <lekktu@gmail.com>
4463
4464 * keyboard.c (Qdelayed_warnings_hook): Define.
4465 (command_loop_1): Run `delayed-warnings-hook'
4466 if Vdelayed_warnings_list is non-nil.
4467 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4468 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4469
d178f871
EZ
44702011-04-28 Eli Zaretskii <eliz@gnu.org>
4471
4472 * doprnt.c (doprnt): Don't return value smaller than the buffer
4473 size if the message was truncated. (Bug#8545).
4474
b124fd93
JB
44752011-04-28 Juanma Barranquero <lekktu@gmail.com>
4476
4477 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4478 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4479
e810457d
PE
44802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4481
4482 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4483
ea51cceb
JB
44842011-04-27 Juanma Barranquero <lekktu@gmail.com>
4485
4486 * makefile.w32-in: Update dependencies.
4487
94dcfacf
EZ
44882011-04-27 Eli Zaretskii <eliz@gnu.org>
4489
4490 Improve `doprnt' and its usage. (Bug#8545)
4491 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4492 `format_end'. Remove support for %l as a conversion specifier.
4493 Don't use xrealloc. Improve diagnostics when the %l size modifier
4494 is used. Update the commentary.
4495
4496 * eval.c (verror): Simplify calculation of size_t.
4497
4498 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4499 messages.
4500
f61f41d7
PE
45012011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4502
4503 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4504 change.
4505
96fb4434
PE
45062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4507
4508 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4509 This makes this file independent of the recent pseudovector change.
4510
671875da 45112011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4512
69e9b5a3
PE
4513 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4514
b5f869a7 4515 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4516 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4517 Remove unused local.
c8926152 4518 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4519
841a1577 4520 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4521 GCC 4.6.0 optimizes based on type-based alias analysis.
4522 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4523 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4524 != &v->size, and therefore "v->size = 1; b->size = 2; return
4525 v->size;" must therefore return 1. This assumption is incorrect
4526 for Emacs, since it type-puns struct Lisp_Vector * with many other
4527 types. To fix this problem, this patch adds a new type struct
f904488f 4528 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4529 and pseudovectors, and helps optimizing compilers not get fooled
4530 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4531 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4532 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4533 the size member.
eab3844f
PE
4534 (XSETPVECTYPE): Rewrite in terms of new macro.
4535 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4536 This is a bit clearer, and further avoids the possibility of
4537 undesirable aliasing.
4538 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4539 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4540 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4541 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4542 (ASIZE): Now uses header.size rather than size.
4543 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4544 to avoid the hassle of writing XVECTOR (foo)->header.size.
4545 (struct vectorlike_header): New type.
eab3844f
PE
4546 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4547 object, to help avoid aliasing.
4548 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4549 (SUBRP): Likewise, since Lisp_Subr is a special case.
4550 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4551 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4552 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4553 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4554 changed to be "header.size" and "header.next".
4555 * buffer.h (struct buffer): Likewise.
4556 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4557 * frame.h (struct frame): Likewise.
4558 * process.h (struct Lisp_Process): Likewise.
4559 * termhooks.h (struct terminal): Likewise.
4560 * window.c (struct save_window_data, struct saved_window): Likewise.
4561 * window.h (struct window): Likewise.
4562 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4563 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4564 * buffer.c (init_buffer_once): Likewise.
4565 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4566 special case.
4567 * process.c (Fformat_network_address): Use local var for size,
4568 for brevity.
4569
0df1eac5
PE
4570 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4571
847ab9d1 4572 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4573 * data.c (atof): Remove decl; no longer used or needed.
4574 (digit_to_number): Move to lread.c.
4575 (Fstring_to_number): Use new string_to_number function, to be
4576 consistent with how the Lisp reader treats infinities and NaNs.
4577 Do not assume that floating-point numbers represent EMACS_INT
4578 without losing information; this is not true on most 64-bit hosts.
4579 Avoid double-rounding errors, by insisting on integers when
4580 parsing non-base-10 numbers, as the documentation specifies.
4581 * lisp.h (string_to_number): New decl, replacing ...
4582 (isfloat_string): Remove.
bc0a5c13 4583 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4584 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4585 appears to have been a coding error. Similarly, do not accept
4586 strings like +-1e0 as floating point numbers. Do not report
4587 overflow for integer overflows unless the base is not 10 which
4588 means we have no simple and reliable way to continue.
4589 Break out the floating-point parsing into a new
4590 function string_to_number, so that Fstring_to_number parses
4591 floating point numbers consistently with the Lisp reader.
04f2d78b 4592 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4593 (E_CHAR, EXP_INT): Remove, replacing with ...
4594 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4595 (string_to_number): New function, replacing isfloat_string.
4596 This function checks for valid syntax and produces the resulting
4597 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4598 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4599 so that overflow for non-base-10 numbers is reported only when
4600 there's no portable and simple way to convert to floating point.
452f4150 4601
67769ffc
PE
4602 * textprop.c (set_text_properties_1): Rewrite for clarity,
4603 and to avoid GCC warning about integer overflow.
4604
c20db43f
PE
4605 * intervals.h (struct interval): Use EMACS_INT for members
4606 where EMACS_UINT might cause problems. See
4607 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4608 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4609 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4610 All uses changed.
37aa2f85
PE
4611 (offset_intervals): Tell GCC not to worry about length overflow
4612 when negating a negative length.
c20db43f 4613
2538aa2f
PE
4614 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4615 (overrun_check_free): Likewise.
4616
f2d3008d
PE
4617 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4618 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4619 word size.
4620
ec8df744
PE
4621 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4622 (gnutls_make_error): Rename local to avoid shadowing.
4623 (gnutls_emacs_global_deinit): ifdef out; not used.
4624 (Fgnutls_boot): Use const for pointer to readonly storage.
4625 Comment out unused local. Fix pointer signedness problems.
4626
640ee02d
PE
4627 * lread.c (openp): Don't stuff size_t into an 'int'.
4628 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4629 about possible signed overflow.
4630
6048fb2a
PE
4631 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4632 (GDK_KEY_g): Don't define if already defined.
4633 (xg_prepare_tooltip): Avoid pointer signedness problem.
4634 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4635
fa3c87e1
PE
4636 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4637 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4638
2172544b
PE
4639 * xfns.c (Fx_window_property): Simplify a bit,
4640 to make a bit faster and to avoid GCC 4.6.0 warning.
4641 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4642
9b821a21
PE
4643 * fns.c (internal_equal): Don't assume size_t fits in int.
4644
3c616cfa
PE
4645 * alloc.c (compact_small_strings): Tighten assertion a little.
4646
c2982e87
PE
4647 Replace pEd with more-general pI, and fix some printf arg casts.
4648 * lisp.h (pI): New macro, generalizing old pEd macro to other
4649 conversion specifiers. For example, use "...%"pI"d..." rather
4650 than "...%"pEd"...".
4651 (pEd): Remove. All uses replaced with similar uses of pI.
4652 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4653 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4654 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4655 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4656 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4657 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4658 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4659 64-bit hosts.
4660 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4661 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4662 * print.c (safe_debug_print, print_object): Likewise.
4663 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4664 to int.
6f04d126
PE
4665 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4666 avoiding the 0 flag, which is not portable.
c2982e87
PE
4667 * process.c (Fmake_network_process): Use pI to avoid cast.
4668 * region-cache.c (pp_cache): Likewise.
4669 * xdisp.c (decode_mode_spec): Likewise.
4670 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4671 behavior on 64-bit hosts with printf arg.
6f04d126 4672 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4673 (x_stop_queuing_selection_requests): Likewise.
4674 (x_get_window_property): Don't truncate byte count to an 'int'
4675 when tracing.
0b432f21 4676
5e073ec7
PE
4677 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4678 here, since it parses constructs like leading '-' and spaces,
4679 which are not wanted; and it overflows with large numbers.
4680 Instead, simply match F[0-9]+, which is what is wanted anyway.
4681
36372bf9
PE
4682 * alloc.c: Remove unportable assumptions about struct layout.
4683 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4684 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4685 (allocate_vectorlike, make_pure_vector): Use the new macros,
4686 plus offsetof, to remove unportable assumptions about struct layout.
4687 These assumptions hold on all porting targets that I know of, but
4688 they are not guaranteed, they're easy to remove, and removing them
4689 makes further changes easier.
4690
0b432f21
PE
4691 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4692 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4693 (string_overrun_cookie): Now const. Use initializers that
4694 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4695 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4696 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4697 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4698 multiple of sizeof (EMACS_INT); it need not be, if
4699 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4700 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4701
895009e1
JB
47022011-04-26 Juanma Barranquero <lekktu@gmail.com>
4703
4704 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4705
6a7a1b0b
TZ
47062011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4707
4708 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4709 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4710 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4711
841a1577 47122011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4713
4714 * lisp.h (Qdebug): List symbol.
895009e1 4715 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4716 * keyboard.c (debug-on-event): New variable.
4717 (handle_user_signal): Break into debugger when debug-on-event
4718 matches the current signal symbol.
4719
f2d3ba6f
DN
47202011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4721
4722 * alloc.c (check_sblock, check_string_bytes)
4723 (check_string_free_list): Convert to standard C.
4724
42ce4c63
TZ
47252011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4726
4727 * w32.c (emacs_gnutls_push): Fix typo.
4728
825cd63c
EZ
47292011-04-25 Eli Zaretskii <eliz@gnu.org>
4730
fb11d64d
EZ
4731 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4732 "cast to pointer from integer of different size".
4733
825cd63c
EZ
4734 Improve doprnt and its use in verror. (Bug#8545)
4735 * doprnt.c (doprnt): Document the set of format control sequences
4736 supported by the function. Use SAFE_ALLOCA instead of always
4737 using `alloca'.
4738
4739 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4740 is one byte too soon. Don't use xrealloc; instead xfree and
4741 xmalloc anew.
4742
e061a11b
TZ
47432011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4744
4745 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4746 callbacks stage.
4747
4748 * gnutls.c: Renamed global_initialized to
4749 gnutls_global_initialized. Added internals for the
4750 :verify-hostname-error, :verify-error, and :verify-flags
4751 parameters of `gnutls-boot' and documented those parameters in the
4752 docstring. Start callback support.
9173deec
JB
4753 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4754 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4755 on error. Return error code.
e061a11b
TZ
4756 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4757 (emacs_gnutls_read): Likewise.
4758 (Fgnutls_boot): Return handshake error code.
4759 (emacs_gnutls_handle_error): New function.
4760 (wsaerror_to_errno): Likewise.
4761
4762 * w32.h (emacs_gnutls_pull): Add prototype.
4763 (emacs_gnutls_push): Likewise.
4764
4765 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4766 (emacs_gnutls_push): Likewise.
4767
47682011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4769
4770 * process.c (wait_reading_process_output): Check if GnuTLS
4771 buffered some data internally if no FDs are set for TLS
4772 connections.
4773
4774 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4775 (LIBS): Link to USER_LIBS.
4776 ($(BLD)/gnutls.$(0)): New target.
4777
fa6996bc
EZ
47782011-04-24 Eli Zaretskii <eliz@gnu.org>
4779
eb35682e
EZ
4780 * xdisp.c (handle_single_display_spec): Rename the
4781 display_replaced_before_p argument into display_replaced_p, to
4782 make it consistent with the commentary. Fix typos in the
4783 commentary.
4784
e2ad650c
EZ
4785 * textprop.c (syms_of_textprop): Remove dead code.
4786 (copy_text_properties): Delete obsolete commentary about an
4787 interface that was deleted long ago. Fix typos in the description
4788 of arguments.
4789
1b2de274
EZ
4790 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4791 to changes in oldXMenu/XMenu.h from 2011-04-16.
4792 <menu_help_message, prev_menu_help_message>: Constify.
4793 (IT_menu_make_room): menu->help_text is now `const char **';
4794 adjust.
4795
4796 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4797 to changes in oldXMenu/XMenu.h from 2011-04-16.
4798 (struct XMenu): Declare `help_text' `const char **'.
4799
4800 * xfaces.c <Qunspecified>: Make extern again.
4801
4802 * syntax.c: Include sys/types.h before including regex.h, as
4803 required by Posix.
4804
762b15be
EZ
4805 * doc.c (get_doc_string): Improve the format passed to `error'.
4806
4807 * doprnt.c (doprnt): Improve commentary.
4808
4809 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4810
4811 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4812 them with etags.
4813
f1052e5d
EZ
4814 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4815 changes in globals.h immediately force recompilation.
762b15be
EZ
4816 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4817 $(CURDIR)/s/ms-w32.h.
4818 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4819
fa6996bc
EZ
4820 * character.c (Fchar_direction): Function deleted.
4821 (syms_of_character): Don't defsubr it.
4822 <char-direction-table>: Deleted.
4823
e6c3da20
EZ
48242011-04-23 Eli Zaretskii <eliz@gnu.org>
4825
4826 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4827 * doprnt.c: Include limits.h.
4828 (SIZE_MAX): New macro.
04f2d78b
CB
4829 (doprnt): Return a size_t value. 2nd arg is now size_t.
4830 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4831 Improve overflow protection. Support `l' modifier for integer
4832 conversions. Support %l conversion. Don't assume an EMACS_INT
4833 argument for integer conversions and for %c.
4834
4835 * lisp.h (doprnt): Restore prototype.
4836
4837 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4838 $(SRC)/character.h.
4839
4840 * Makefile.in (base_obj): Add back doprnt.o.
4841
4842 * deps.mk (doprnt.o): Add back prerequisites.
4843 (callint.o): Depend on character.h.
4844
4845 * eval.c (internal_lisp_condition_case): Include the handler
4846 representation in the error message.
4847 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4848 when breaking from the loop.
4849
4850 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4851
4852 * callint.c (Fcall_interactively): When displaying error message
4853 about invalid control letter, pass the character's codepoint, not
4854 a pointer to its multibyte form. Improve display of the character
4855 in octal and display also its hex code.
4856
4857 * character.c (char_string): Use %x to display the (unsigned)
4858 codepoint of an invalid character, to avoid displaying a bogus
4859 negative value.
4860
4861 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4862 `error', not SYMBOL_NAME itself.
4863
4864 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4865 character arguments to `error'.
4866
4867 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4868 to `error' in error message about FINAL_CHAR argument. Make sure
4869 FINAL_CHAR is a character, and use %c when it is passed as
4870 argument to `error'.
4871
4ffd0d6b 48722011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4873
4874 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4875
4876 * w32.c: Include <time.h>.
4877 (sys_localtime): New function.
4878
4ffd0d6b 48792011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4880
4881 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4882
4ffd0d6b 4883 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4884
4ffd0d6b 48852011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4886
4ffd0d6b
GM
4887 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4888 zombies (Bug#8467).
aac0c6e3 4889
04c56954
EZ
48902011-04-19 Eli Zaretskii <eliz@gnu.org>
4891
4892 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4893 gl_state.e_property when gl_state.object is Qt.
4894
4895 * insdel.c (make_gap_larger): Remove limitation of buffer size
4896 to <= INT_MAX.
4897
16a43933
CY
48982011-04-18 Chong Yidong <cyd@stupidchicken.com>
4899
4900 * xdisp.c (lookup_glyphless_char_display)
4901 (produce_glyphless_glyph): Handle cons cell entry in
4902 glyphless-char-display.
4903 (Vglyphless_char_display): Document it.
4904
4905 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4906 glyphless-char-display.
4907
4581706e
CY
49082011-04-17 Chong Yidong <cyd@stupidchicken.com>
4909
4910 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4911
4912 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4913
4914 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4915 definition for no-X builds.
4916
4887c6e2 49172011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4918
fd35b6f9
PE
4919 Static checks with GCC 4.6.0 and non-default toolkits.
4920
5c1ccb01
PE
4921 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4922
006c5daa
PE
4923 * process.c (keyboard_bit_set): Define only if SIGIO.
4924 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4925 (send_process): Repair possible setjmp clobbering.
4926
efc736d3
PE
4927 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4928
4e2fe2e6
PE
4929 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4930
f97334a2
PE
4931 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4932
4e75f29d
PE
4933 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4934 Define only if needed.
4935
90efadd1
PE
4936 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4937 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4938 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4939
3c647824
PE
4940 * dispextern.h (struct redisplay_interface): Rename param
4941 to avoid shadowing.
e264f262 4942 * termhooks.h (struct terminal): Likewise.
761383f4 4943 * xterm.c (xembed_send_message): Likewise.
3c647824 4944
b58c5c4a
PE
4945 * insdel.c (make_gap_smaller): Define only if
4946 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4947
cad59032
PE
4948 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4949 it.
4950
c339dc2e
PE
4951 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4952 so that we aren't warned about unused symbols.
4953
91a3e27b
PE
4954 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4955
399c71d3 4956 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4957
8ffc96f5
PE
4958 * xfns.c (x_real_positions): Mark locals as initialized.
4959
eef9bc79
PE
4960 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4961
098db9dd
PE
4962 * xterm.c: Fix problems found by static analysis with other toolkits.
4963 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4964 (x_dispatch_event): Declare static if USE_GTK, and
4965 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4966 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4967 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4968 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4969 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4970
eb18f6cc
PE
4971 * xmenu.c (menu_help_callback): Pointer type fixes.
4972 Use const pointers when pointing at readonly data. Avoid pointer
4973 signedness clashes.
4974 (FALSE): Remove unused macro.
4975 (update_frame_menubar): Remove unused decl.
4976
1fe72bf8
PE
4977 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4978
60d9e1db
PE
4979 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4980 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4981 (single_menu_item): Rename local to avoid shadowing.
4982
39261c26
PE
4983 * keyboard.c (make_lispy_event): Remove unused local var.
4984
018c5e19
PE
4985 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4986 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4987
63d2b86e
PE
4988 * bitmaps: Change bitmaps from unsigned char back to the X11
4989 compatible char. Avoid the old compiler warnings about
4990 out-of-range initializers by using, for example, '\xab' rather
4991 than 0xab.
4992
aefd87e1
PE
4993 * xgselect.c (xgselect_initialize): Check vs interface
4994 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4995
bf501fb9
PE
4996 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4997
e9829fdf
PE
4998 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4999 to read-only memory.
5000
1086c095
PE
5001 * fns.c (vector): Remove; this old hack is no longer needed.
5002
2baccd04 5003 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5004 Remove unused var.
dde42981 5005 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5006
72391843 5007 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5008
436c16df 5009 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5010 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5011 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5012
92bb796d 5013 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5014 (x_term_init): Remove local to avoid shadowing.
92bb796d 5015
764430a3 5016 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5017
5018 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5019 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5020
d1dfb56c
EZ
50212011-04-16 Eli Zaretskii <eliz@gnu.org>
5022
c4354cb4
EZ
5023 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5024
d1dfb56c
EZ
5025 Fix regex.c, syntax.c and friends for buffers > 2GB.
5026 * syntax.h (struct gl_state_s): Declare character position members
5027 EMACS_INT.
5028
5029 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5030
04f2d78b
CB
5031 * textprop.c (verify_interval_modification, interval_of):
5032 Declare arguments EMACS_INT.
d1dfb56c
EZ
5033
5034 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5035 EMACS_INT.
5036
5037 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5038
5039 * indent.c (Fvertical_motion): Local variable it_start is now
5040 EMACS_INT.
5041
5042 * regex.c (re_match, re_match_2, re_match_2_internal)
5043 (bcmp_translate, regcomp, regexec, print_double_string)
5044 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5045 (re_compile_pattern, re_exec): Declare arguments and local
5046 variables `size_t' and `ssize_t' and return values `regoff_t', as
5047 appropriate.
5048 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5049 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5050 <compile_stack_type>: `size' and `avail' are now `size_t'.
5051
5052 * regex.h <regoff_t>: Use ssize_t, not int.
5053 (re_search, re_search_2, re_match, re_match_2): Arguments that
5054 specify buffer/string position and length are now ssize_t and
5055 size_t. Return type is regoff_t.
5056
613052cd
BK
50572011-04-16 Ben Key <bkey76@gmail.com>
5058
5059 * nsfont.m: Fixed bugs in ns_get_family and
5060 ns_descriptor_to_entity that were caused by using free to
5061 deallocate memory blocks that were allocated by xmalloc (via
5062 xstrdup). This caused Emacs to crash when compiled with
5063 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5064 --enable-checking=xmallocoverrun). xfree is now used to
5065 deallocate these memory blocks.
5066
4170f62f 50672011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5068
71b41406
PE
5069 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5070
9587a89d
PE
5071 emacs_write: Accept and return EMACS_INT for sizes.
5072 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5073 et seq.
5074 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5075 Accept and return EMACS_INT.
5076 (emacs_gnutls_write): Return the number of bytes written on
5077 partial writes.
5078 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5079 (emacs_read, emacs_write): Remove check for negative size, as the
5080 Emacs source code has been audited now.
9587a89d
PE
5081 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5082 (emacs_read, emacs_write): Use it.
273a5f82
PE
5083 * process.c (send_process): Adjust to the new signatures of
5084 emacs_write and emacs_gnutls_write. Do not attempt to store
5085 a byte offset into an 'int'; it might overflow.
9587a89d 5086 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5087
3e047f51
PE
5088 * sound.c: Don't assume sizes fit in 'int'.
5089 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5090 Return EMACS_INT, not int.
3e047f51 5091 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5092 Accept EMACS_INT, not int.
5093 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5094 record read return values.
5095
cc39a9db
BK
50962011-04-15 Ben Key <bkey76@gmail.com>
5097
c9d0ec6d
JB
5098 * keyboard.c (Qundefined): Don't declare static since it is used
5099 in nsfns.m.
5100 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5101 static since they are used in nsfont.m.
cc39a9db 5102
6c60eb9f
SM
51032011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5104
5105 * process.c (Qprocessp): Don't declare static.
5106 * lisp.h (Qprocessp): Declare again.
5107
7990b61a
JB
51082011-04-15 Juanma Barranquero <lekktu@gmail.com>
5109
5110 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5111
5d4cb038
PE
51122011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5113
8bd7b830 5114 Improve C-level modularity by making more things 'static'.
cd64ea1d 5115
e3b27b31
PE
5116 Don't publish debugger-only interfaces to other modules.
5117 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5118 (verify_bytepos, count_markers): Move decls to the only modules
5119 that need them.
5120 * region-cache.h (pp_cache): Likewise.
5121 * window.h (check_all_windows): Likewise.
5122 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5123
5d4cb038
PE
5124 * sysdep.c (croak): Now static, if
5125 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5126 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5127
5128 * alloc.c (refill_memory_reserve): Now static if
5129 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5130 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5131
e87b6180
PE
5132 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5133 Define only if USE_LUCID.
5134
ac64929e
PE
5135 * xrdb.c (x_customization_string, x_rm_string): Now static.
5136
6f37259d
PE
5137 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5138 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5139
1683e3ab
PE
5140 * xdisp.c (draw_row_with_mouse_face): Now static.
5141 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5142
de9c2632
PE
5143 * window.h (check_all_windows): Mark externally visible.
5144
2b96acb7
PE
5145 * window.c (window_deletion_count): Now static.
5146
5147 * undo.c: Make symbols static if they're not exported.
5148 (last_undo_buffer, last_boundary_position, pending_boundary):
5149 Now static.
5150
50436f33
PE
5151 * textprop.c (interval_insert_behind_hooks): Now static.
5152 (interval_insert_in_front_hooks): Likewise.
5153
64520e5c
PE
5154 * term.c: Make symbols static if they're not exported.
5155 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5156 (max_frame_lines, tty_set_terminal_modes):
5157 (tty_reset_terminal_modes, tty_turn_off_highlight):
5158 (get_tty_terminal): Now static.
5159 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5160 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5161 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5162 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5163 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5164
1fa53021
PE
5165 * sysdep.c: Make symbols static if they're not exported.
5166 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5167 Now static.
5168 (sigprocmask_set, full_mask): Remove; unused.
5169 (wait_debugging): Mark as visible.
5170 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5171 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5172
d4b43b22
PE
5173 * syntax.c (syntax_temp): Define only if !__GNUC__.
5174
b7c513d0
PE
5175 * sound.c (current_sound_device, current_sound): Now static.
5176
989b29ad
PE
5177 * search.c (searchbufs, searchbuf_head): Now static.
5178
13a55a78
PE
5179 * scroll.c (scroll_cost): Remove; unused.
5180 * dispextern.h (scroll_cost): Remove decl.
5181
de68a1fc
PE
5182 * region-cache.h (pp_cache): Mark as externally visible.
5183
40ccffa6
PE
5184 * process.c: Make symbols static if they're not exported.
5185 (process_tick, update_tick, create_process, chan_process):
5186 (Vprocess_alist, proc_buffered_char, datagram_access):
5187 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5188 (deactivate_process): Mark defn as static, as well as decl.
5189 * lisp.h (create_process): Remove decl.
5190 * process.h (chan_process, Vprocess_alist): Remove decls.
5191
ad64fc97
PE
5192 * print.c: Make symbols static if they're not exported.
5193 (print_depth, new_backquote_output, being_printed, print_buffer):
5194 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5195 (print_interval, print_number_index, initial_stderr_stream):
5196 Now static.
5197 * lisp.h (Fprinc): Remove decl.
5198 (debug_output_compilation_hack): Mark as externally visible.
5199
adddb265
PE
5200 * sysdep.c (croak): Move decl from here to syssignal.h.
5201 * syssignal.h (croak): Put it here, so the API can be checked when
5202 'croak' is called from dissociate_if_controlling_tty.
5203
1717ede2
PE
5204 * minibuf.c: Make symbols static if they're not exported.
5205 (minibuf_save_list, choose_minibuf_frame): Now static.
5206 * lisp.h (choose_minibuf_frame): Remove decl.
5207
fa5fb2bc
PE
5208 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5209
1e3890d1
PE
5210 * lread.c: Make symbols static if they're not exported.
5211 (read_objects, initial_obarray, oblookup_last_bucket_number):
5212 Now static.
5213 (make_symbol): Remove; unused.
5214 * lisp.h (initial_obarray, make_symbol): Remove decls.
5215
8a1414fa
PE
5216 * keyboard.c: Make symbols static if they're not exported.
5217 (single_kboard, recent_keys_index, total_keys, recent_keys):
5218 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5219 (this_single_command_key_start, echoing, last_auto_save):
5220 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5221 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5222 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5223 (Vlispy_mouse_stem, double_click_count):
5224 Now static.
5225 (force_auto_save_soon): Define only if SIGDANGER.
5226 (ignore_mouse_drag_p): Now static if
5227 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5228 (print_help): Remove; unused.
5229 (stop_character, last_timer_event): Mark as externally visible.
5230 * keyboard.h (ignore_mouse_drag_p): Declare only if
5231 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5232 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5233 * lisp.h (echoing): Remove decl.
5234 (force_auto_save_soon): Declare only if SIGDANGER.
5235 * xdisp.c (redisplay_window): Simplify code, to make it more
5236 obvious that ignore_mouse_drag_p is not accessed if !defined
5237 USE_GTK && !defined HAVE_NS.
5238
93ea6e8f
PE
5239 * intervals.c: Make symbols static if they're not exported.
5240 (merge_properties_sticky, merge_interval_right, delete_interval):
5241 Now static.
5242 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5243
77382fcc
PE
5244 * insdel.c: Make symbols static if they're not exported.
5245 However, leave prepare_to_modify_buffer alone. It's never
5246 called from outside this function, but that appears to be a bug.
5247 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5248 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5249 (adjust_after_replace_noundo): Remove; unused.
5250 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5251 (signal_before_change): Remove decls.
77382fcc 5252
9306c32e
PE
5253 * indent.c (val_compute_motion, val_vmotion): Now static.
5254
cd44d2eb
PE
5255 * image.c: Make symbols static if they're not exported.
5256 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5257 if USE_GTK.
5258 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5259 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5260
ad9a7a06
PE
5261 * fringe.c (standard_bitmaps): Now static.
5262 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5263
81626931
PE
5264 * frame.c: Make symbols static if they're not exported.
5265 (x_report_frame_params, make_terminal_frame): Now static.
5266 (get_frame_param): Now static, unless HAVE_NS.
5267 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5268 (x_get_resource_string): Remove; not used.
5269 * frame.h (make_terminal_frame, x_report_frame_params):
5270 (x_get_resource_string); Remove decls.
5271 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5272 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5273
239f9db9
PE
5274 * font.c, fontset.c: Make symbols static if they're not exported.
5275 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5276 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5277 * font.c (font_close_object): Now static.
5278 * font.h (font_close_object): Remove.
5279 * fontset.c (FONTSET_OBJLIST): Remove.
5280 (free_realized_fontset) #if-0 the body, which does nothing.
5281 (face_suitable_for_char_p): #if-0, as it's never called.
5282 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5283 * xfaces.c (face_at_string_position):
5284 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5285 since 0 is always ASCII.
5286
dfcf3579
PE
5287 * fns.c (weak_hash_tables): Now static.
5288
5045092b
PE
5289 * fileio.c: Make symbols static if they're not exported.
5290 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5291 (Vwrite_region_annotation_buffers): Now static.
5292
57a96f5c
PE
5293 * eval.c: Make symbols static if they're not exported.
5294 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5295 * lisp.h (backtrace_list): Remove decl.
5296
35f08c38
PE
5297 * emacs.c: Make symbols static if they're not exported.
5298 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5299 (fatal_error_code, fatal_error_signal_hook, standard_args):
5300 Now static.
5301 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5302 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5303 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5304 * lisp.h (fatal_error_signal_hook): Remove decl.
5305 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5306
f44bd759
PE
5307 * editfns.c: Move a (normally-unused) function to its only use.
5308 * editfns.c, lisp.h (get_operating_system_release): Remove.
5309 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5310 worth the hassle of breaking this out.
5311
b532497d
PE
5312 * xterm.c: Make symbols static if they're not exported.
5313 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5314 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5315 (x_destroy_window, x_delete_display):
5316 Now static.
5317 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5318 (x_mouse_leave): Remove; unused.
5319 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5320 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5321 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5322 Remove decls.
5323 (x_mouse_leave): Declare only if WINDOWSNT.
5324 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5325 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5326 USE_X_TOOLKIT.
5327
1675728f
PE
5328 * ftxfont.c: Make symbols static if they're not exported.
5329 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5330 HAVE_FREETYPE.
5331 * font.h (ftxfont_driver): Likewise.
5332
e4cebfca
PE
5333 * xfns.c: Make symbols static if they're not exported.
5334 (x_last_font_name, x_display_info_for_name):
5335 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5336 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5337 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5338 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5339 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5340 (last_show_tip_args): Now static.
5341 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5342 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5343 (x_screen_planes): Remove; unused.
5344 * dispextern.h (x_screen_planes): Remove decl.
5345
5bf46f05
PE
5346 * dispnew.c: Make symbols static if they're not exported.
5347 * dispextern.h (redraw_garbaged_frames, scrolling):
5348 (increment_row_positions): Remove.
5349 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5350 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5351 Now static.
5352 (redraw_garbaged_frames): Remove; unused.
5353
435f4c28
PE
5354 * xfaces.c: Make symbols static if they're not exported.
5355 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5356 Remove decls.
5357 * xterm.h (defined_color): Remove decls.
5358 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5359 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5360 (menu_face_changed_default, defined_color, free_realized_face):
5361 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5362 (ascii_face_of_lisp_face): Remove; unused.
5363
8524aef3
PE
5364 * xdisp.c: Make symbols static if they're not exported.
5365 * dispextern.h (scratch_glyph_row, window_box_edges):
5366 (glyph_to_pixel_coords, set_cursor_from_row):
5367 (get_next_display_element, set_iterator_to_next):
5368 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5369 (show_mouse_face): Remove decls
5370 * frame.h (message_buf_print): Likewise.
5371 * lisp.h (pop_message, set_message, check_point_in_composition):
5372 Likewise.
5373 * xterm.h (set_vertical_scroll_bar): Likewise.
5374 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5375 (message_buf_print, scratch_glyph_row, displayed_buffer):
5376 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5377 (get_next_display_element, show_mouse_face, window_box_edges):
5378 (frame_to_window_pixel_xy, check_point_in_composition):
5379 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5380 (glyph_to_pixel_coords): Remove; unused.
5381
16390cd2
PE
5382 * dired.c (file_name_completion): Now static.
5383
5384 * dbusbind.c (xd_in_read_queued_messages): Now static.
5385
a25f4dfa
PE
5386 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5387 * data.c (circular_list_error): Remove.
5388
14a9c8df
PE
5389 * commands.h (last_point_position, last_point_position_buffer):
5390 (last_point_position_window): Remove decls.
5391 * keyboard.c: Make these variables static.
5392
04f2d78b
CB
5393 * coding.h (coding, code_convert_region, encode_coding_gap):
5394 Remove decls.
74ab6df5
PE
5395 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5396 (iso_code_class, detect_coding, code_convert_region): Now static.
5397 (encode_coding_gap): Remove; unused.
5398
38dfbee1
PE
5399 * chartab.c (chartab_chars, chartab_bits): Now static.
5400
a2cb4e63
PE
5401 * charset.h (charset_iso_8859_1): Remove decl.
5402 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5403 Now static.
5404
127198fd
PE
5405 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5406 * ccl.c (Vccl_program_table): Now static.
5407 (check_ccl_update): Remove; unused.
5408
d85b608f
PE
5409 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5410 * category.h: ... from here.
5411 * category.c (check_category_table, set_category_set): Now static.
5412
31cd66f3
PE
5413 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5414 * lisp.h: Remove these decls.
5415
c358e587
PE
5416 * buffer.c (buffer_count): Remove unused var.
5417
e78aecca
PE
5418 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5419 so that it's not optimized away.
5420 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5421 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5422 exported only to the debugger.
5423
e192d7d3 5424 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5425 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5426
92470028
PE
5427 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5428 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5429 was inaccessible from Lisp.
5430 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5431 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5432
244ed907
PE
5433 alloc.c: Import and export fewer symbols, and remove unused items.
5434 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5435 is defined.
5436 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5437 it's not optimized away by whole-program optimization.
5438 (message_enable_multibyte, free_misc): Remove.
5439 (catchlist, handlerlist, mark_backtrace):
5440 Declare only if BYTE_MARK_STACK.
5441 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5442 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5443 (message_enable_multibyte): Remove decl.
5444 (free_misc, interval_free_list, float_block, float_block_index):
5445 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5446 (cons_free_list, last_marked_index):
5447 Now static.
5448 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5449 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5450 (mark_backtrace): Define only if BYTE_MARK_STACK.
5451 * xdisp.c (message_enable_multibyte): Now static.
5452
61c2b50e 5453 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5454 This makes it easier for human readers (and static analyzers)
5455 to see whether these variables are used from other modules.
5456 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5457 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5458 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5459 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5460 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5461 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5462 * xmenu.c, xselect.c:
5463 Declare Q* vars static if they are not used in other modules.
5464 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5465 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5466 Remove decls of unexported vars.
5467 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5468
95c82688
PE
5469 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5470
16a97296
PE
5471 Make Emacs functions such as Fatom 'static' by default.
5472 This makes it easier for human readers (and static analyzers)
5473 to see whether these functions can be called from other modules.
5474 DEFUN now defines a static function. To make the function external
5475 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5476 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5477 (Finit_image_library):
16a97296
PE
5478 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5479 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5480 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5481 Remove decls, since these functions are now static.
5482 (Funintern, Fget_internal_run_time): New decls, since these functions
5483 were already external.
95c82688 5484
16a97296
PE
5485 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5486 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5487 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5488 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5489 * keyboard.c, keymap.c, lread.c:
5490 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5491 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5492 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5493 Mark functions with DEFUE instead of DEFUN,
5494 if they are used in other modules.
5495 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5496 decls for now-static functions.
5497 * buffer.h (Fdelete_overlay): Remove decl.
5498 * callproc.c (Fgetenv_internal): Mark as internal.
5499 * composite.c (Fremove_list_of_text_properties): Remove decl.
5500 (Fcomposition_get_gstring): New forward static decl.
5501 * composite.h (Fcomposite_get_gstring): Remove decl.
5502 * dired.c (Ffile_attributes): New forward static decl.
5503 * doc.c (Fdocumntation_property): New forward static decl.
5504 * eval.c (Ffetch_bytecode): New forward static decl.
5505 (Funintern): Remove extern decl; now in .h file where it belongs.
5506 * fileio.c (Fmake_symbolic_link): New forward static decl.
5507 * image.c (Finit_image_library): New forward static decl.
5508 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5509 * intervals.h (Fprevious_property_change):
5510 (Fremove_list_of_text_properties): Remove decls.
5511 * keyboard.c (Fthis_command_keys): Remove decl.
5512 (Fcommand_execute): New forward static decl.
5513 * keymap.c (Flookup_key): New forward static decl.
5514 (Fcopy_keymap): Now static.
5515 * keymap.h (Flookup_key): Remove decl.
5516 * process.c (Fget_process): New forward static decl.
5517 (Fprocess_datagram_address): Mark as internal.
5518 * syntax.c (Fsyntax_table_p): New forward static decl.
5519 (skip_chars): Remove duplicate decl.
5520 * textprop.c (Fprevious_property_change): New forward static decl.
5521 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5522 Now internal.
5523 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5524 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5525
785bbd42
PE
5526 * editfns.c (Fformat): Remove unreachable code.
5527
8b913b57
AS
55282011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5529
5530 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5531 change. (Bug#8496)
5532
a6744a35
EZ
55332011-04-13 Eli Zaretskii <eliz@gnu.org>
5534
5535 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5536 when at ZV. (Bug#8487)
5537
e7974947
AS
55382011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5539
baad03f0
AS
5540 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5541 (Bug#8437)
5542 * keyboard.c (parse_tool_bar_item): Likewise.
5543 * sound.c (sound_cleanup, alsa_close): Likewise.
5544 * termcap.c (tgetent): Likewise.
5545 * xfns.c (x_default_font_parameter): Likewise.
5546 * xsettings.c (read_and_apply_settings): Likewise.
5547
e7974947
AS
5548 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5549 (overrun_check_free): Protoize.
5550
28272684
PE
55512011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5552
5553 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5554 since callers should never pass a negative size.
5555 Change the signature to match that of plain 'read' and 'write'; see
5556 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5557 * lisp.h: Update prototypes of emacs_write and emacs_read.
5558
11997c76
EZ
55592011-04-11 Eli Zaretskii <eliz@gnu.org>
5560
5561 * xdisp.c (redisplay_window): Don't try to determine the character
5562 position of the scroll margin if the window start point w->startp
e896f03c 5563 is outside the buffer's accessible region. (Bug#8468)
11997c76 5564
8a2cbd72
EZ
55652011-04-10 Eli Zaretskii <eliz@gnu.org>
5566
5567 Fix write-region and its subroutines for buffers > 2GB.
5568 * fileio.c (a_write, e_write): Modify declaration of arguments and
5569 local variables to support buffers larger than 2GB.
5570 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5571
5572 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5573 argument, local variables, and return value.
5574
5575 * lisp.h: Update prototypes of emacs_write and emacs_read.
5576
5577 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5578
4073e537 55792011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5580
1ebfdcb6
PE
5581 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5582
b2ded58d
PE
5583 Fix more problems found by GCC 4.6.0's static checks.
5584
7d66342c
PE
5585 * xdisp.c (vmessage): Use a better test for character truncation.
5586
bbf47d44
PE
5587 * charset.c (load_charset_map): <, not <=, for optimization,
5588 and to avoid potential problems with integer overflow.
9248994d 5589 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5590 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5591 * editfns.c (Fformat): Likewise.
1e69125e 5592 * syntax.c (skip_chars): Likewise.
3befa583 5593
e3019616
PE
5594 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5595 This also lets GCC 4.6.0 generate slightly better loop code.
5596
becfa255
PE
5597 * callint.c (Fcall_interactively): <, not <=, for optimization.
5598 (Fcall_interactively): Count the number of arguments produced,
5599 not the number of arguments given. This is simpler and lets GCC
5600 4.6.0 generate slightly better code.
5601
dae0cd48
PE
5602 * ftfont.c: Distingish more carefully between FcChar8 and char.
5603 The previous code passed unsigned char * to a functions like
5604 strlen and xstrcasecmp that expect char *, which does not
5605 conform to the C standard.
5606 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5607 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5608 char * when the C standard requires it.
5609
76032d70
PE
5610 * keyboard.c (read_char): Remove unused var.
5611
eb3f1cc8
PE
5612 * eval.c: Port to Windows vsnprintf (Bug#8435).
5613 Include <limits.h>.
5614 (SIZE_MAX): Define if the headers do not.
5615 (verror): Do not give up if vsnprintf returns a negative count.
5616 Instead, grow the buffer. This ports to Windows vsnprintf, which
5617 does not conform to C99. Problem reported by Eli Zaretskii.
5618 Also, simplify the allocation scheme, by avoiding the need for
5619 calling realloc, and removing the ALLOCATED variable.
5620
70476b54
PE
5621 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5622
12020a9e
PE
5623 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5624 But keep the doprint source code for now, as we might revamp it
5625 and use it again (Bug#8435).
ea6c7ae6
PE
5626 * lisp.h (doprnt): Remove.
5627 * Makefile.in (base_obj): Remove doprnt.o.
5628 * deps.mk (doprnt.o): Remove.
5629
5fdb398c
PE
5630 error: Print 32- and 64-bit integers portably (Bug#8435).
5631 Without this change, on typical 64-bit hosts error ("...%d...", N)
5632 was used to print both 32- and 64-bit integers N, which relied on
5633 undefined behavior.
5634 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5635 New macro.
5636 * lisp.h (error, verror): Mark as printf-like functions.
5637 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5638 Report overflow in size calculations when allocating printf buffer.
5639 Do not truncate output string at its first null byte.
5640 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5641 Truncate the output at a character boundary, since vsnprintf does not
5642 do that.
5643 * charset.c (check_iso_charset_parameter): Convert internal
5644 character to string before calling 'error', since %c now has the
5645 printf meaning.
5646 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5647 overflow when computing char to be passed to 'error'. Do not
5648 pass Lisp_Object to 'error'; pass the integer instead.
5649 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5650 formatted with plain %d.
5651
b189fa66
PE
5652 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5653
bff87ef0
PE
5654 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5655
7e2cac20
PE
5656 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5657
ce4d90b5
PE
5658 * xterm.c (x_catch_errors): Remove duplicate declaration.
5659
266c9547
PE
5660 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5661
79c49ad2
PE
5662 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5663
368f4090
JM
56642011-04-10 Jim Meyering <meyering@redhat.com>
5665
5666 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5667 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5668 return ssize_t not "int", and use size_t as the buffer length.
5669 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5670 * gnutls.h: Update declarations.
5671 * process.c (read_process_output): Use ssize_t, to match.
5672 (send_process): Likewise.
5673
a32d4040
CY
56742011-04-09 Chong Yidong <cyd@stupidchicken.com>
5675
5676 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5677
8546720e 56782011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5679
04f2d78b
CB
5680 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5681 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5682
8546720e
GM
5683 * xterm.c (handle_one_xevent):
5684 * xmenu.c (create_and_show_popup_menu):
5685 * xselect.c (x_decline_selection_request)
5686 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5687
0a2f5c1a 56882011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5689
5690 Fix some uses of `int' instead of EMACS_INT.
5691 * search.c (string_match_1, fast_string_match)
5692 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5693 (scan_buffer, find_next_newline_no_quit)
5694 (find_before_next_newline, search_command, Freplace_match)
5695 (Fmatch_data): Make some `int' variables be EMACS_INT.
5696
5697 * xdisp.c (display_count_lines): 3rd argument and return value now
5698 EMACS_INT. All callers changed.
5699 (pint2hrstr): Last argument is now EMACS_INT.
5700
5701 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5702 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5703 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5704 (decode_coding_utf_16, decode_coding_emacs_mule)
5705 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5706 (decode_coding_ccl, decode_coding_charset)
5707 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5708 (decode_coding_iso_2022, decode_coding_emacs_mule)
5709 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5710 <char_offset, last_offset>: Declare EMACS_INT.
5711 (encode_coding_utf_8, encode_coding_utf_16)
5712 (encode_coding_emacs_mule, encode_invocation_designation)
5713 (encode_designation_at_bol, encode_coding_iso_2022)
5714 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5715 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5716 Declare EMACS_INT.
5717 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5718 (encode_invocation_designation): Last argument P_NCHARS is now
5719 EMACS_INT.
5720 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5721 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5722
5723 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5724 All users changed.
5725
5726 * ccl.c (Fccl_execute_on_string): Declare some variables
5727 EMACS_INT.
5728
8546720e 57292011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5730
5731 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5732
4e19a977
CS
57332011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5734
5735 * process.c (Fformat_network_address): Doc fix.
5736
87302331
R
57372011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5738
5739 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5740
cbb59342
CY
57412011-04-08 Chong Yidong <cyd@stupidchicken.com>
5742
5743 * keyboard.c (read_char): Call Lisp function help-form-show,
5744 instead of using internal_with_output_to_temp_buffer.
5745 (Qhelp_form_show): New var.
e0d38eeb 5746 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5747
5748 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5749
5750 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5751
e67a13ab
CY
57522011-04-06 Chong Yidong <cyd@stupidchicken.com>
5753
04f2d78b
CB
5754 * process.c (Flist_processes): Remove to Lisp.
5755 (list_processes_1): Delete.
e67a13ab 5756
973f782d
EZ
57572011-04-06 Eli Zaretskii <eliz@gnu.org>
5758
7c106b1e
EZ
5759 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5760
973f782d
EZ
5761 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5762
41cf7d1a 57632011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5764
ca23cc88
PE
5765 Fix more problems found by GCC 4.6.0's static checks.
5766
f390e2d5
PE
5767 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5768
42eea0d0
PE
5769 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5770
b69769da 5771 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5772
f9541e84
PE
5773 * xdisp.c (vmessage): Mark as a printf-like function.
5774
13841b55
PE
5775 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5776
c136c10f
PE
5777 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5778
5e2d4a30
PE
5779 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5780 printf-like functions.
5781 (tiff_load): Add casts to remove these marks before passing them
5782 to system-supplied API.
5783
583f48b9
PE
5784 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5785
b25d760e
PE
5786 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5787 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5788 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5789 directly, rather than having caller test rule sign. This avoids
5790 some unnecessary tests.
5791 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5792 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5793 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5794
bc7b6697 5795 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5796 (xfont_open): Avoid unnecessary tests.
bc7b6697 5797
27ccc379
PE
5798 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5799
dcd5c89a
PE
5800 * composite.h, composite.c (composition_gstring_put_cache):
5801 Use EMACS_INT, not int, for length.
5802
b13a45c6
PE
5803 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5804 breaking out part of COMPOSITION_DECODE_RULE.
5805 (COMPOSITION_DECODE_RULE): Use it.
5806 * composite.c (get_composition_id): Remove unused local vars,
5807 by using the new macro.
5808
1e792e4d
PE
5809 * textprop.c (set_text_properties_1): Change while to do-while,
5810 since the condition is always true at first.
5811
dc6c6455 5812 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5813 (interval_deletion_adjustment): Return unsigned value.
5814 All uses changed.
dc6c6455 5815
aba7731a
PE
5816 * process.c (list_processes_1, create_pty, read_process_output):
5817 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5818 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5819 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5820 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5821 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5822
fdfc4bf3
PE
5823 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5824
fca8fe46 5825 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5826 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5827
06a0259a 5828 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5829 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5830 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5831
e7b9e80f
PE
5832 * print.c (print_error_message): Avoid int overflow.
5833
56201685
PE
5834 * font.c (font_list_entities): Redo for clarity,
5835 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5836
78834453 5837 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5838 (font_score): Avoid potential overflow in diff calculation.
78834453 5839
0bc0b309 5840 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5841 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5842
e610eaca
PE
5843 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5844
b895abce
PE
5845 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5846 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5847 can always succeed if overflow has undefined behavior.
5848
1f1d9321 5849 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5850 (wordify): Omit three unnecessary tests.
1f1d9321 5851
c59478bc
PE
5852 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5853 All callers changed. This avoids the need for an unused var.
5854
79b73827
PE
5855 * casefiddle.c (casify_region): Remove var that is set but not used.
5856
a4db5dfe
PE
5857 * dired.c (file_name_completion): Remove var that is set but not used.
5858
43aae36e
PE
5859 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5860
2a47c44d 5861 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5862 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5863
a37c69bf
PE
5864 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5865 Check for integer overflow on size calculations.
5866
328ab8e7
PE
5867 * buffer.c (Fprevious_overlay_change): Remove var that is set
5868 but not used.
5869
e5a2a5cb
PE
5870 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5871 Remove vars that are set but not used.
8d84a6eb 5872 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5873 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5874
a60e5f68
PE
5875 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5876
f661cb61 5877 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5878 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5879
f0397f5a
PE
5880 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5881 that are set but not used.
5882
8664db06 5883 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5884 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5885
6abdaa4a
PE
5886 * xselect.c (x_get_local_selection, x_handle_property_notify):
5887 Remove vars that are set but not used.
5888
0ce7538d 5889 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5890 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5891
9ae848fc
PE
5892 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5893 Remove var that is set but not used.
0b918413
PE
5894 (scroll_bar_windows_size): Now size_t, not int.
5895 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5896 Check for overflow.
9ae848fc 5897
a5a62657
PE
5898 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5899 (map_tty_color) [!defined MSDOS]: Likewise.
5900
5c5cdd39
PE
5901 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5902
66ebf983
PE
5903 * coding.c: Remove vars that are set but not used.
5904 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5905 All callers changed.
5906 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5907 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5908 (decode_coding_charset): Remove vars that are set but not used.
5909
1be4d761
PE
5910 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5911 that is set but not used.
5912
47553fa8
PE
5913 * print.c (print_object): Remove var that is set but not used.
5914
1f7196bf 5915 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5916 The gnulib version avoids calling malloc in the usual case,
5917 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5918 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5919 * filelock.c (current_lock_owner): Likewise.
5920 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5921 * sysdep.c: Include allocator.h, careadlinkat.h.
5922 (emacs_no_realloc_allocator): New static constant.
5923 (emacs_readlink): New function.
fdb61804
PE
5924 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5925 ../lib/careadlinkat.h.
d1fdcab7 5926
f84c17c7
SM
59272011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5928
5929 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5930 first non-nil return value).
5931
ef3862ad
JD
59322011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5933
5934 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5935 if not defined (Bug#8403).
5936
376a7006
JB
59372011-04-02 Juanma Barranquero <lekktu@gmail.com>
5938
5939 * xdisp.c (display_count_lines): Remove parameter `start',
5940 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5941 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5942 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5943 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5944 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5945 and thereabouts. All callers changed.
5946 (get_per_char_metric): Remove parameter `f', unused since
5947 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5948
6ca3801d
JM
59492011-04-02 Jim Meyering <meyering@redhat.com>
5950
5951 do not dereference NULL upon failed strdup
5952 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5953 (ns_get_family): Likewise.
5954
d8e2b5ba
JB
59552011-04-02 Juanma Barranquero <lekktu@gmail.com>
5956
5957 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5958
8c74fcbd
JD
59592011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5960
5961 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5962 later (Bug#8403).
5963
7200d79c
SM
59642011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5965
03408648 5966 Add lexical binding.
7200d79c 5967
03408648
SM
5968 * window.c (Ftemp_output_buffer_show): New fun.
5969 (Fsave_window_excursion):
5970 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5971
5972 * lread.c (lisp_file_lexically_bound_p): New function.
5973 (Fload): Bind Qlexical_binding.
5974 (readevalloop): Remove `evalfun' arg.
5975 Bind Qinternal_interpreter_environment.
5976 (Feval_buffer): Bind Qlexical_binding.
5977 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5978 Mark as dynamic.
5979 (syms_of_lread): Declare `lexical-binding'.
5980
5981 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5982
5983 * keyboard.c (eval_dyn): New fun.
5984 (menu_item_eval_property): Use it.
ca105506
SM
5985
5986 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5987
03408648
SM
5988 * fns.c (concat, mapcar1): Accept byte-code-functions.
5989
5990 * eval.c (Fsetq): Handle lexical vars.
5991 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5992 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5993 (FletX, Flet): Obey lexical binding.
5994 (Fcommandp): Handle closures.
5995 (Feval): New `lexical' arg.
5996 (eval_sub): New function extracted from Feval. Use it almost
5997 everywhere where Feval was used. Look up vars in lexical env.
5998 Handle closures.
5999 (Ffunctionp): Move from subr.el.
6000 (Ffuncall): Handle closures.
6001 (apply_lambda): Remove `eval_flags'.
6002 (funcall_lambda): Handle closures and new byte-code-functions.
6003 (Fspecial_variable_p): New function.
6004 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6005 but without exporting it to Lisp.
23aba0ea 6006
23aba0ea 6007 * doc.c (Fdocumentation, store_function_docstring):
03408648 6008 * data.c (Finteractive_form): Handle closures.
23aba0ea 6009
03408648
SM
6010 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6011 interactive spec.
ba83908c 6012
04f2d78b
CB
6013 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6014 New byte-codes.
03408648
SM
6015 (exec_byte_code): New function extracted from Fbyte_code to handle new
6016 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6017
03408648 6018 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6019
03408648 6020 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6021
e2abce01
JB
60222011-03-31 Juanma Barranquero <lekktu@gmail.com>
6023
6024 * xdisp.c (redisplay_internal): Fix prototype.
6025
63696a73 60262011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6027
63696a73 6028 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6029 (try_scrolling): Use it when setting scroll_limit.
6030 Limit scrolling to 100 screen lines.
63696a73
EZ
6031 (redisplay_window): Even when falling back on "recentering",
6032 position point in the window according to scroll-conservatively,
6033 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6034
6035 (try_scrolling): When point is above the window, allow searching
6036 as far as scroll_max, or one screenful, to compute vertical
6037 distance from PT to the scroll margin position. This prevents
6038 try_scrolling from unnecessarily failing when
6039 scroll-conservatively is set to a value slightly larger than the
6040 window height. Clean up the case of PT below the margin at bottom
6041 of window: scroll_max can no longer be INT_MAX. When aggressive
6042 scrolling is in use, don't let point enter the opposite scroll
6043 margin as result of the scroll.
6044 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6045 threshold of 100 lines for never-recentering scrolling.
6046
e4cc2dfc
JB
60472011-03-31 Juanma Barranquero <lekktu@gmail.com>
6048
6049 * dispextern.h (move_it_by_lines):
6050 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6051 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6052 (message_log_check_duplicate): Remove parameters `prev_bol' and
6053 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6054 (redisplay_internal): Remove parameter `preserve_echo_area',
6055 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6056
6057 * indent.c (Fvertical_motion):
6058 * window.c (window_scroll_pixel_based, Frecenter):
6059 Don't pass `need_y_p' to `move_it_by_lines'.
6060
1c470562
SM
60612011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6062
44f230aa
SM
6063 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6064 steal a few bits to be more compact.
6065 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6066 Remove unneeded casts.
6067
1c470562
SM
6068 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6069
888adce9
ZK
60702011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6071
6072 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6073 binding" message (bug#7967).
6074
f838ed7b
PE
60752011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6076
77861b95
PE
6077 Fix more problems found by GCC 4.6.0's static checks.
6078
de6dbc14
PE
6079 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6080 Remove unused local var.
6081
f838ed7b
PE
6082 * editfns.c (Fmessage_box): Remove unused local var.
6083
792c7b2b
PE
6084 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6085 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6086 Omit unused local vars.
c499e557 6087 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6088 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6089 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6090 Omit unused local var.
6091
ba0165e1
PE
6092 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6093 Don't assume string length fits in int.
32ad8845 6094 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6095 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6096
3c59b4c9
PE
6097 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6098 instead of alloca (Bug#8344).
6099
a3eed478 6100 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6101 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6102
eb4d412d
PE
6103 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6104
1658b401
PE
6105 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6106 concerns.
6107
6108 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6109
6110 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6111
9a2c6e05
PE
6112 * keyboard.c (syms_of_keyboard): Use the same style as later
6113 in this function when indexing through an array. This also
6114 works around GCC bug 48267.
6115
03d0a109
PE
6116 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6117
44f730c8
PE
6118 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6119
fe75f926
PE
6120 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6121 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6122
ffa8c828
PE
6123 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6124 This avoids undefined behavior on integer overflow, and is a bit
6125 more convenient anyway since it is compared to a size_t variable.
6126
c5101a77
PE
6127 Variadic C functions now count arguments with size_t, not int.
6128 This avoids an unnecessary limitation on 64-bit machines, which
6129 caused (substring ...) to crash on large vectors (Bug#8344).
6130 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6131 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6132 All variadic functions and their callers changed accordingly.
c5101a77
PE
6133 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6134 * data.c (arith_driver, float_arith_driver): Likewise.
6135 * editfns.c (general_insert_function): Likewise.
6136 * eval.c (struct backtrace.nargs, interactive_p)
6137 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6138 (funcall_lambda, mark_backtrace): Likewise.
6139 * fns.c (concat): Likewise.
6140 * frame.c (x_set_frame_parameters): Likewise.
6141 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6142 0 if not found, not -1. All callers changed.
6143
dd3f25f7
PE
6144 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6145 (stack_copy_size): Now size_t, not int.
6146 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6147
461c2ab9
JB
61482011-03-28 Juanma Barranquero <lekktu@gmail.com>
6149
6150 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6151 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6152 All callers changed.
6153
6154 * lisp.h (multibyte_char_to_unibyte):
6155 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6156 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6157 * character.h (CHAR_TO_BYTE8):
6158 * cmds.c (internal_self_insert):
6159 * editfns.c (general_insert_function):
6160 * keymap.c (push_key_description):
6161 * search.c (Freplace_match):
6162 * xdisp.c (message_dolog, set_message_1): All callers changed.
6163
f6d62986
SM
61642011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6165
6166 * keyboard.c (safe_run_hook_funcall): New function.
6167 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6168 don't set the hook to nil, but remove the offending function instead.
6169 (Qcommand_hook_internal): Remove, unused.
6170 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6171 Vcommand_hook_internal.
6172
6173 * eval.c (enum run_hooks_condition): Remove.
6174 (funcall_nil, funcall_not): New functions.
6175 (run_hook_with_args): Call each function through a `funcall' argument.
6176 Remove `cond' argument, now redundant.
6177 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6178 (Frun_hook_with_args_until_failure): Adjust accordingly.
6179 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6180
1db5b1ad
JB
61812011-03-28 Juanma Barranquero <lekktu@gmail.com>
6182
6183 * dispextern.h (string_buffer_position): Remove declaration.
6184
6185 * print.c (strout): Remove parameter `multibyte', unused since
6186 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6187
6188 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6189 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6190 All callers changed.
6191
6192 * w32.c (_wsa_errlist): Use braces for struct initializers.
6193
6194 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6195 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6196 All callers changed.
6197 (string_buffer_position): Likewise. Also, make static (it's never
6198 used outside xdisp.c).
6199 (cursor_row_p): Remove parameter `w', unused since
6200 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6201 (decode_mode_spec): Remove parameter `precision', introduced during
6202 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6203 All callers changed.
6204
5ffb62aa
JD
62052011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6206
6207 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6208
461c2ab9 62092011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6210
6211 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6212 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6213 (ns_update_auto_hide_menu_bar): New functions.
6214 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6215 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6216 ns_constrain_all_frames.
6217 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6218 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6219
5c380ffb
JD
62202011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6221
6222 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6223
9af30bdf
GM
62242011-03-27 Glenn Morris <rgm@gnu.org>
6225
6226 * syssignal.h: Replace RETSIGTYPE with void.
6227 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6228 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6229 Replace SIGTYPE with void everywhere.
6230 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6231 * s/template.h (SIGTYPE): Remove commented out definition.
6232
e2abce01
JB
62332011-03-26 Eli Zaretskii <eliz@gnu.org>
6234
6235 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6236 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6237
f868cd8a
JB
62382011-03-26 Juanma Barranquero <lekktu@gmail.com>
6239
59eb0929
JB
6240 * w32.c (read_unc_volume): Use parameter `henum', instead of
6241 global variable `wget_enum_handle'.
6242
6243 * keymap.c (describe_vector): Remove parameters `indices' and
6244 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6245 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6246
f868cd8a
JB
6247 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6248
6249 * keyboard.c (timer_check): Remove parameter `do_it_now',
6250 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6251 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6252 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6253
6254 * keyboard.c (read_char):
6255 * w32menu.c (w32_menu_display_help):
6256 * xmenu.c (show_help_event, menu_help_callback):
6257 Adjust calls to `show_help_echo'.
6258
6259 * gtkutil.c (xg_maybe_add_timer):
6260 * keyboard.c (readable_events):
6261 * process.c (wait_reading_process_output):
6262 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6263
6264 * insdel.c (adjust_markers_gap_motion):
6265 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6266 (gap_left, gap_right): Don't call it.
6267
2ecf6fdb
CY
62682011-03-25 Chong Yidong <cyd@stupidchicken.com>
6269
6270 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6271 incurred during fontification.
6272
6b1f9ba4
JB
62732011-03-25 Juanma Barranquero <lekktu@gmail.com>
6274
6275 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6276 (DEFVAR_PER_BUFFER): Don't pass it.
6277
6278 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6279 (scrolling_window): Don't pass it.
6280
0f4a96b5
JB
62812011-03-25 Juanma Barranquero <lekktu@gmail.com>
6282
6283 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6284
6285 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6286 and `suffix'.
6287 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6288 of variables specific to SELinux and computation of `encoded_absname'.
6289
6290 * image.c (XPutPixel): Remove unused variable `height'.
6291
6292 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6293
6294 * unexw32.c (get_section_info): Remove unused variable `section'.
6295
6296 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6297 (system_process_attributes): Remove unused variable `sess'.
6298 (sys_read): Remove unused variable `err'.
6299
6300 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6301 (w32_wnd_proc): Remove unused variable `isdead'.
6302 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6303 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6304 (x_create_tip_frame): Remove unused variable `tem'.
6305
6306 * w32inevt.c (w32_console_read_socket):
6307 Remove unused variable `no_events'.
6308
6309 * w32term.c (x_draw_composite_glyph_string_foreground):
6310 Remove unused variable `width'.
6311
1149507c
JB
63122011-03-24 Juanma Barranquero <lekktu@gmail.com>
6313
6314 * w32term.c (x_set_glyph_string_clipping):
6315 Don't pass uninitialized region to CombineRgn.
6316
9c88f339
JB
63172011-03-23 Juanma Barranquero <lekktu@gmail.com>
6318
6319 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6320 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6321 (Fx_close_connection): Remove unused variable `i'.
6322
6323 * w32font.c (w32font_draw): Return number of glyphs.
6324 (w32font_open_internal): Remove unused variable `i'.
6325 (w32font_driver): Add missing initializer.
6326
6327 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6328 (fill_in_menu): Remove unused variable `items_added'.
6329
6330 * w32term.c (last_mouse_press_frame): Remove static global variable.
6331 (w32_clip_to_row): Remove unused variable `f'.
6332 (x_delete_terminal): Remove unused variable `i'.
6333
6334 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6335 (NOTHING): Remove unused static global variable.
6336 (uniscribe_check_otf): Remove unused variable `table'.
6337 (uniscribe_font_driver): Add missing initializers.
6338
dee091a3
JD
63392011-03-23 Julien Danjou <julien@danjou.info>
6340
6341 * term.c (Fsuspend_tty, Fresume_tty):
6342 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6343 * window.c (temp_output_buffer_show):
6344 * insdel.c (signal_before_change):
6345 * frame.c (Fhandle_switch_frame):
6346 * fileio.c (Fdo_auto_save):
6347 * emacs.c (Fkill_emacs):
6348 * editfns.c (save_excursion_restore):
6349 * cmds.c (internal_self_insert):
6350 * callint.c (Fcall_interactively):
6351 * buffer.c (Fkill_all_local_variables):
6352 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6353 Use Frun_hooks.
0f4a96b5 6354 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6355 unconditionnaly since it does the check itself.
6356
2c520ab5 63572011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6358
c9c49752
PE
6359 Fix more problems found by GCC 4.5.2's static checks.
6360
8abc3f12
PE
6361 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6362 the first time through the loop, since we know p0 < p1 then.
6363 This also avoids a gcc -Wstrict-overflow warning.
6364
a2d26660
PE
6365 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6366 leading to a memory leak, possible in functions like
6367 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6368 of objects (Bug#8318).
a2d26660 6369
916c72e9
PE
6370 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6371 that could (at least in theory) be that large.
6372
19ab8a18
PE
6373 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6374 This is less likely to overflow, and avoids undefined behavior if
6375 overflow does occur. All callers changed. Use strtoul to scan
6376 for the unsigned long integer.
b7cbbd6f
PE
6377 (pint2hrstr): Simplify and tune code slightly.
6378 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6379
f0641eff
PE
6380 * scroll.c (do_scrolling): Work around GCC bug 48228.
6381 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6382
7f650bb9
PE
6383 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6384 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6385 (validate_x_resource_name): Simplify count usage.
6386 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6387
37dd57d1
PE
6388 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6389 fail (Bug#8306).
81e56e61 6390
699979fc 6391 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6392
401bf9b4
PE
6393 * process.c (Fmake_network_process): Use socklen_t, not int,
6394 where POSIX says socklen_t is required in portable programs.
6395 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6396 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6397 (Fmake_network_process, server_accept_connection):
6398 (wait_reading_process_output, read_process_output):
6399 Likewise.
6400
b93aacde
PE
6401 * process.c: Rename or move locals to avoid shadowing.
6402 (list_processes_1, Fmake_network_process):
6403 (read_process_output_error_handler, exec_sentinel_error_handler):
6404 Rename or move locals.
4dc343ee 6405 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6406 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6407 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6408 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6409 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6410
af8a867c 6411 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6412 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6413 Include tparam.h instead, since it declares them.
af8a867c
PE
6414 * cm.h (PC): Remove extern decl; tparam.h now does this.
6415 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6416 * terminfo.c: Include tparam.h, to check interfaces.
6417 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6418 (tparam): Adjust signature to match interface in tparam.h;
6419 this removes some undefined behavior. Check that outstring and len
6420 are zero, which they always are with Emacs.
6421 * tparam.h (PC, BC, UP): New extern decls.
6422
0248044d 6423 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6424 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6425
8ff096c1 6426 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6427 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6428 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6429 (ftfont_list): Remove unused local.
49eaafba
PE
6430 (get_adstyle_property, ftfont_pattern_entity):
6431 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6432 Rename locals to avoid shadowing.
8ff096c1 6433
e2be39f6
PE
6434 * xfont.c (xfont_list_family): Mark var as initialized.
6435
c9735e30
PE
6436 * xml.c (make_dom): Now static.
6437
8f5201ae
PE
6438 * composite.c (composition_compute_stop_pos): Rename local to
6439 avoid shadowing.
b246f932
PE
6440 (composition_reseat_it): Remove unused locals.
6441 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6442 (composition_update_it): Mark var as initialized.
11b61122
PE
6443 (find_automatic_composition): Mark vars as initialized,
6444 with a FIXME (Bug#8290).
8f5201ae 6445
760fbc2c
PE
6446 character.h: Rename locals to avoid shadowing.
6447 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6448 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6449 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6450 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6451 to avoid shadowing.
6452
ff08eb85
PE
6453 * textprop.c (property_change_between_p): Remove; unused.
6454
fc7bf025
PE
6455 * intervals.c (interval_start_pos): Now static.
6456
235d7abc
PE
6457 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6458
44f230aa
SM
6459 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6460 Rename locals to avoid shadowing.
3e7d6594 6461
50060332
PE
6462 * sound.c (wav_play, au_play, Fplay_sound_internal):
6463 Fix pointer signedness.
d01f234b 6464 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6465 (wav_play): Initialize a variable to 0, to prevent undefined
6466 behavior (Bug#8278).
50060332 6467
c4fc4e30
PE
6468 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6469
918436ed
PE
6470 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6471
c939f91b
PE
6472 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6473 clobbering (Bug#8298).
b9c7f648
PE
6474 * sysdep.c (sys_subshell): Likewise.
6475 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6476
6bd8c144
PE
6477 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6478 This should get cleaned up, so that child_setup has the
6479 same signature on all platforms.
6480
7710357c 6481 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6482 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6483
c59da222
CY
64842011-03-22 Chong Yidong <cyd@stupidchicken.com>
6485
6486 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6487 not to be necessary, and produces flickering.
6488
66b87493
GM
64892011-03-20 Glenn Morris <rgm@gnu.org>
6490
6491 * config.in: Remove file.
6492
45b6f6d5
JB
64932011-03-20 Juanma Barranquero <lekktu@gmail.com>
6494
6495 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6496 are now in src/globals.h.
6497 (syms_of_minibuf): Remove spurious & from previous change.
6498
3ec03f7e
LL
64992011-03-20 Leo <sdl.web@gmail.com>
6500
6501 * minibuf.c (completing-read-function): New variable.
6502 (completing-read-default): Rename from completing-read.
6503 (completing-read): Call completing-read-function.
6504
b14e3e21
CY
65052011-03-19 Juanma Barranquero <lekktu@gmail.com>
6506
6507 * xfaces.c (Fx_load_color_file):
6508 Read color file from absolute filename (bug#8250).
6509
f2b726e6
JB
65102011-03-19 Juanma Barranquero <lekktu@gmail.com>
6511
6512 * makefile.w32-in: Update dependencies.
6513
09f6ff02
EZ
65142011-03-17 Eli Zaretskii <eliz@gnu.org>
6515
6516 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6517
29a6015a
PE
65182011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6519
a3a6c54e
PE
6520 Fix more problems found by GCC 4.5.2's static checks.
6521
b766f867
PE
6522 * process.c (make_serial_process_unwind, send_process_trap):
6523 (sigchld_handler): Now static.
6524
be02381c
PE
6525 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6526 That way, the code declares only the vars that it needs.
6527 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6528 * s/cygwin.h (PTY_ITERATION): Likewise.
6529 * s/darwin.h (PTY_ITERATION): Likewise.
6530 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6531
57048744
PE
6532 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6533 * process.c (allocate_pty): Don't declare stb unless it's needed.
6534
7914961c 6535 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6536 (CONSTANTLIM): Remove; unused.
6537 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6538 Define only if needed.
7914961c 6539
b3967b18
PE
6540 * unexelf.c (unexec): Name an expression,
6541 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6542 Use a different way to cause a compilation error if anyone uses
6543 n rather than nn, a way that does not involve shadowing.
73366a00 6544 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6545
29a6015a
PE
6546 * deps.mk (unexalpha.o): Remove; unused.
6547
43cfc33e 6548 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6549 * unexec.h: New file.
ce701a33
PE
6550 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6551 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6552 Depend on unexec.h.
6553 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6554 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6555 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6556 Change as necessary to match prototype in unexec.h.
ce701a33 6557
01f44d5a
PE
6558 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6559 shadowing.
4f63c6bb 6560 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6561
a6670b0b
PE
6562 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6563 Rename locals to avoid shadowing.
6564
cef2010d 6565 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6566 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6567
d4d7173a
PE
6568 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6569
f08b802a
PE
6570 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6571 warning when compiling print.c.
6572
3ddb0639
PE
6573 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6574 instead of using an uninitialized var.
5ad03b97 6575 (font_sort_entities): Mark var as initialized.
3ddb0639 6576
170a2692
PE
6577 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6578
e663c700
PE
6579 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6580 pointers to constants.
89bc529a 6581 (font_parse_fcname): Remove unused vars.
7b81e2d0 6582 (font_delete_unmatched): Now static.
ea838e10 6583 (font_get_spec): Remove; unused.
13a547c6
PE
6584 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6585 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6586 Rename or move locals to avoid shadowing.
e663c700 6587
2a80c887 6588 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6589 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6590
1384fa33 6591 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6592 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6593
8b2c52e9
PE
6594 * alloc.c (mark_backtrace): Move decl from here ...
6595 * lisp.h: ... to here, so that it can be checked.
6596
475545b5 6597 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6598 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6599 (lisp_indirect_variable): Name an expression,
6600 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6601 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6602
b1349114 6603 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6604 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6605 Use const pointer when appropriate.
b1349114 6606
a2928364
PE
6607 * lisp.h (get_system_name, get_operating_system_release):
6608 Move decls here, to check interfaces.
6609 * process.c (get_operating_system_release): Move decl to lisp.h.
6610 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6611 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6612 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6613 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6614 (Fformat_time_string, Fencode_time, Finsert_char):
6615 (Ftranslate_region_internal, Fformat):
6616 Rename or remove local vars to avoid shadowing.
9710023e 6617 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6618
a415e694
PE
6619 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6620 avoid shadowing.
6621
8ef4622d
PE
6622 * lisp.h (eassert): Check that the argument compiles, even if
6623 ENABLE_CHECKING is not defined.
6624
946f9a5b
PE
6625 * data.c (Findirect_variable): Name an expression, to avoid
6626 gcc -Wbad-function-cast warning.
112396d6 6627 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6628 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6629 (Fmake_variable_buffer_local, Fmake_local_variable):
6630 Mark variables as initialized.
52746918 6631 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6632
e5aab7e7 6633 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6634 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6635 Rename locals to avoid shadowing.
dff45157
PE
6636 (mark_stack): Move local variables into the #ifdef region where
6637 they're used.
7bc26fdb
PE
6638 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6639 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6640 needed otherwise.
6641 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6642 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6643 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6644
e5aab7e7
PE
6645 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6646 avoids undefined behavior in theory.
6647
4da60324
PE
6648 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6649
88043301
PE
6650 Use functions, not macros, for up- and down-casing (Bug#8254).
6651 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6652 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6653 to use the following functions instead of these macros.
6654 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6655 EMACS_INT, since callers assume the returned value fits in int.
6656 (upcase1): Likewise, for UPCASE_TABLE.
6657 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6658 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6659 the race-condition problem in the old DOWNCASE.
88043301 6660
19ed5445
PE
6661 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6662 Rename locals to avoid shadowing.
6663 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6664 (regex_compile, re_search_2, re_match_2_internal):
6665 Remove unused local vars.
952db0d7
PE
6666 (FREE_VAR): Rewrite so as not to use empty "else",
6667 which gcc can warn about.
da053e48 6668 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6669 (RETALLOC_IF): Define only if needed.
6670 (WORDCHAR_P): Likewise. This one is never needed, but is used
6671 only in a comment talking about a compiler bug, so put inside
6672 the #if 0 of that comment.
6673 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6674 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6675 Remove; unused.
19ed5445 6676
1f3561e4 6677 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6678 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6679 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6680
ded6f8f7
PE
6681 * search.c (simple_search): Remove unused var.
6682
dbd37a95
PE
6683 * dired.c (compile_pattern): Move decl from here ...
6684 * lisp.h: ... to here, so that it can be checked.
6685 (struct re_registers): New forward decl.
6686
7e47afad
PE
6687 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6688
85f24f61
PE
6689 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6690 All uses changed.
6691 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6692 Rename locals to avoid shadowing.
5671df8f 6693 (Fvertical_motion): Mark locals as initialized.
85f24f61 6694
181aa2be 6695 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6696 (casify_region): Mark local as initialized.
181aa2be 6697
930d429c
PE
6698 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6699
7082eac6
PE
6700 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6701 New macros, so that the caller can use some names other than
6702 gcpro1, gcpro2, etc.
6703 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6704 of the new macros.
6705 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6706 argument, for consistency with GCPRO2_VAR, etc: it is now the
6707 prefix of the variable, not the variable itself. All uses
6708 changed.
38b2c076
PE
6709 * dired.c (directory_files_internal, file_name_completion):
6710 Rename locals to avoid shadowing.
6711
15206ed9
PE
6712 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6713 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6714 dired.c's scmp function, had undefined behavior.
6715 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6716 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6717 * buffer.h: ... to here, because these macros use current_buffer,
6718 and the new implementation with inline functions needs to have
6719 current_buffer in scope now, rather than later when the macros
6720 are used.
6721 (downcase, upcase1): New static inline functions.
6722 (DOWNCASE, UPCASE1): Reimplement using these functions.
6723 This avoids undefined behavior in expressions like
6724 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6725 from race conditions in accessing the global variables
6726 case_temp1 and case_temp2.
6727 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6728 * lisp.h (case_temp1, case_temp2): Remove their decls.
6729 * character.h (ASCII_CHAR_P): Move from here ...
6730 * lisp.h: ... to here, so that the inline functions mentioned
6731 above can use them.
6732
4a6bea26
PE
6733 * dired.c (directory_files_internal_unwind): Now static.
6734
f14b7e14
PE
6735 * fileio.c (file_name_as_directory, directory_file_name):
6736 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6737 Now static.
2893f146
PE
6738 (file_name_as_directory): Use const pointers when appropriate.
6739 (Fexpand_file_name): Likewise. In particular, newdir might
6740 point at constant storage, so make it a const pointer.
fd4ead52 6741 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6742 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6743 signedness issues.
f839df0c
PE
6744 (Fset_file_times, Finsert_file_contents, auto_save_error):
6745 Rename locals to avoid shadowing.
f14b7e14 6746
5716756e 6747 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6748 (Ftry_completion, Fall_completions): Rename or remove locals
6749 to avoid shadowing.
5716756e 6750
b4c3046a
PE
6751 * marker.c (bytepos_to_charpos): Remove; unused.
6752
b45db522
PE
6753 * lisp.h (verify_bytepos, count_markers): New decls,
6754 so that gcc does not warn that these functions aren't declared.
6755
85876d07
PE
6756 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6757 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6758 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6759 (copy_text): Remove unused local var.
85876d07 6760
03d78a21 6761 * filelock.c (within_one_second): Now static.
b3dd38ab 6762 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6763
5df8f01b
PE
6764 * buffer.c (fix_overlays_before): Mark locals as initialized.
6765 (fix_start_end_in_overlays): Likewise. This function should be
6766 simplified by using pointers-to-pointers, but that's a different
6767 matter.
b1d876f1 6768 (switch_to_buffer_1): Now static.
8f54f30a
PE
6769 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6770 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6771
a70072c9 6772 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6773 Fix pointer signedness issue.
edced198
PE
6774 (sys_subshell): Mark local as volatile if checking for lint,
6775 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6776 (MAXPATHLEN): Define only if needed.
a70072c9 6777
a0977c44
PE
6778 * process.c (serial_open, serial_configure): Move decls from here ...
6779 * systty.h: ... to here, so that they can be checked.
6780
a884fdcc
PE
6781 * fns.c (get_random, seed_random): Move extern decls from here ...
6782 * lisp.h: ... to here, so that they can be checked.
6783
604efe86 6784 * sysdep.c (reset_io): Now static.
b8950c94 6785 (wait_for_termination_signal): Remove; unused.
604efe86 6786
38fc62d9
PE
6787 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6788 (copy_keymap_item, append_key, push_text_char_description):
6789 Now static.
1004a21a 6790 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6791 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6792 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6793 (describe_map_tree):
6794 Rename locals to avoid shadowing.
38fc62d9 6795
2f2650da
PE
6796 * keyboard.c: Declare functions static if they are not used elsewhere.
6797 (echo_char, echo_dash, cmd_error, top_level_2):
6798 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6799 (read_char, kbd_buffer_get_event, make_lispy_position):
6800 (make_lispy_event, make_lispy_movement, apply_modifiers):
6801 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6802 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6803 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6804 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6805 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6806
a053e86c 6807 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6808 (mark_kboards): Move decl here ...
6809 * alloc.c (mark_kboards): ... from here.
a053e86c 6810
4752793e
PE
6811 * lisp.h (force_auto_save_soon): New decl.
6812
74f10ca7 6813 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6814 (DEFINE_DUMMY_FUNCTION): New macro.
6815 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6816 Use it.
c03cd23f
PE
6817 (main): Add casts to avoid warnings
6818 if GCC considers string literals to be constants.
74f10ca7 6819
022e70d4
PE
6820 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6821
59d6fe83
PE
6822 * dbusbind.c: Pointer signedness fixes.
6823 (xd_signature, xd_append_arg, xd_initialize):
6824 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6825 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6826 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6827 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6828
78320123
PE
6829 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6830 if GCC considers string literals to be constants.
49cebcca 6831 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6832
35ac2a97
SM
68332011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6834
fb103ca9
SM
6835 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6836 (print_preprocess, print_object): New macro to fix last change.
6837
35ac2a97
SM
6838 * print.c (print_preprocess): Don't forget font objects.
6839
62973b41
JB
68402011-03-16 Juanma Barranquero <lekktu@gmail.com>
6841
6842 * emacs.c (USAGE3): Doc fixes.
6843
0e48bb22
AS
68442011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6845
6846 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6847 structure.
6848
7684e57b
JB
68492011-03-14 Juanma Barranquero <lekktu@gmail.com>
6850
6851 * lisp.h (VWindow_system, Qfile_name_history):
6852 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6853 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6854 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6855
6856 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6857 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6858
6859 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6860 * w32console.c (detect_input_pending, read_input_pending)
6861 (encode_terminal_code):
6862 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6863 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6864 (w32_system_caret_y, Qfile_name_history):
6865 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6866 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6867 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6868 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6869 * w32proc.c (Qlocal, report_file_error):
6870 * w32term.c (Vwindow_system, updating_frame):
6871 * w32uniscribe.c (initialized, uniscribe_font_driver):
6872 Remove unneeded extern declarations.
6873
2aa46d6c
CY
68742011-03-14 Chong Yidong <cyd@stupidchicken.com>
6875
c96bbc66 6876 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6877
cffc6f3b
CY
68782011-03-13 Chong Yidong <cyd@stupidchicken.com>
6879
6880 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6881 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6882 These macros can no longer be used for assignment.
6883
44f230aa
SM
6884 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6885 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6886 (record_buffer_markers, fetch_buffer_markers): New functions for
6887 recording and fetching special buffer markers.
6888 (set_buffer_internal_1, set_buffer_temp): Use them.
6889
6890 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6891
6892 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6893
6894 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6895 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6896
6897 * xdisp.c (hscroll_window_tree):
6898 (reconsider_clip_changes): Use PT instead of BUF_PT.
6899
d251f04b
EZ
69002011-03-13 Eli Zaretskii <eliz@gnu.org>
6901
6902 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6903 $(EMACS_ROOT)/lib/intprops.h.
6904
f0c77cd1
PE
69052011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6906
3eca4629
PE
6907 Fix more problems found by GCC 4.5.2's static checks.
6908
7c86ee98
PE
6909 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6910 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6911 (xg_free_frame_widgets): Make it clear that a local variable is
6912 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6913 (gdk_window_get_screen): Make it clear that this macro is needed
6914 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6915 (int_gtk_range_get_value): New function, which avoids a diagnostic
6916 from gcc -Wbad-function-cast.
6917 (xg_set_toolkit_scroll_bar_thumb): Use it.
6918 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6919 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6920 (get_utf8_string, xg_get_file_with_chooser):
6921 Rename locals to avoid shadowing.
6922 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6923
41729b81
PE
6924 * xgselect.c (xg_select): Remove unused var.
6925
f0c77cd1
PE
6926 * image.c (four_corners_best): Mark locals as initialized.
6927 (gif_load): Initialize transparent_p to zero (Bug#8238).
6928 Mark another local as initialized.
ec6cf4c6 6929 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6930
ce0ad53d 6931 * image.c (clear_image_cache): Now static.
d5d5a617 6932 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6933 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6934 (x_edge_detection): Remove unnecessary cast that
6935 gcc -Wbad-function-cast diagnoses.
2037898d 6936 (gif_load): Fix pointer signedness.
6ae141d6
PE
6937 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6938 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6939
33383987 69402011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6941
d32df629
PE
6942 Improve quality of tests for time stamp overflow.
6943 For example, without this patch (encode-time 0 0 0 1 1
6944 1152921504606846976) returns the obviously-bogus value (-948597
6945 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6946 reports time overflow. See
6947 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6948 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6949 * editfns.c: Include limits.h and intprops.h.
6950 (TIME_T_MIN, TIME_T_MAX): New macros.
6951 (time_overflow): Move earlier, to before first use.
6952 (hi_time, lo_time): New functions, for an accurate test for
6953 out-of-range times.
6954 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6955 (Fget_internal_run_time): Don't assume time_t fits in int.
6956 (make_time): Use list2 instead of Fcons twice.
6957 (Fdecode_time): More accurate test for out-of-range times.
6958 (check_tm_member): New function.
6959 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6960 (lisp_time_argument): Don't rely on undefined left-shift and
6961 right-shift behavior when checking for time stamp overflow.
8be6f318 6962
fe31d94c
PE
6963 * editfns.c (time_overflow): New function, refactoring common code.
6964 (Fformat_time_string, Fdecode_time, Fencode_time):
6965 (Fcurrent_time_string): Use it.
6966
8be6f318
PE
6967 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6968 * dired.c (make_time): Move to ...
6969 * editfns.c (make_time): ... here.
6970 * systime.h: Note the move.
6971
09d9db2c 69722011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6973
126bc0dc
YM
6974 * fringe.c (update_window_fringes): Remove unused variables.
6975
c47cbdfd
YM
6976 * unexmacosx.c (copy_data_segment): Also copy __got section.
6977 (Bug#8223)
6978
7ac80be9
EZ
69792011-03-12 Eli Zaretskii <eliz@gnu.org>
6980
c96bbc66 6981 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6982 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6983 Constify `char *' arguments and their references according to
6984 prototypes in tparam.h.
6985
ecb0f94d 6986 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6987
7ac80be9
EZ
6988 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6989 Adapt all references accordingly.
6990
6991 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6992
ef1fd07e
TT
69932011-03-11 Tom Tromey <tromey@redhat.com>
6994
6995 * buffer.c (syms_of_buffer): Remove obsolete comment.
6996
7ef4b50c
EZ
69972011-03-11 Eli Zaretskii <eliz@gnu.org>
6998
6999 * termhooks.h (encode_terminal_code): Declare prototype.
7000
7001 * msdos.c (encode_terminal_code): Don't declare prototype.
7002
7003 * term.c (encode_terminal_code): Now external again, used by
7004 w32console.c and msdos.c.
7005
44f230aa
SM
7006 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7007 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7008
4b1ec863 70092011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7010
1714f52b 7011 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7012
4b1ec863
PE
7013 * fringe.c (update_window_fringes): Mark locals as initialized
7014 (Bug#8227).
7015 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7016
524c7aa6
PE
7017 * alloc.c (mark_fringe_data): Move decl from here ...
7018 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7019 to check its interface.
7020 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7021
a5c0af81 7022 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7023 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7024 (fontset_font): Mark local as initialized.
a9a06e0b 7025 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7026
b4716021
PE
7027 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7028
811e9bac 7029 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7030 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7031 (x_own_selection, Fx_disown_selection_internal): Rename locals
7032 to avoid shadowing.
7033 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7034
7e3ab302
PE
7035 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7036 so that the caller can use some name other than gcpro1.
7037 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7038 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7039 (Fx_backspace_delete_keys_p):
7040 Use them to avoid shadowing, and rename vars to avoid shadowing.
7041 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7042 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7043 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7044 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7045 Remove unused locals.
7e3ab302
PE
7046 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7047 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7048 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7049 macros.
f78faa98 7050
e2b13473
PE
7051 * xterm.h (x_mouse_leave): New decl.
7052
77f23912
PE
7053 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7054 Remove unused functions.
cdf4ba58
PE
7055 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7056 (x_calc_absolute_position): Now static.
7411c686 7057 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7058 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7059 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7060 unless they are used.
38d0b34a
PE
7061 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7062 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7063 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7064 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7065 (x_error_catcher, x_connection_closed, x_error_handler):
7066 (x_error_quitter, xembed_send_message, x_iconify_frame):
7067 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7068 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7069 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7070
44f230aa
SM
7071 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7072 Rename or move locals to avoid shadowing.
6b463e58 7073 (tty_defined_color, merge_face_heights): Now static.
5967d051 7074 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7075 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7076 does not deduce is never used uninitialized.
73719eba
PE
7077 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7078 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7079
426994c3 7080 * terminal.c (store_terminal_param): Now static.
5489860b 7081
032f1620 7082 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7083 (set_frame_menubar): Remove unused local.
d4323972 7084 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7085 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7086 since they might point to immutable storage.
281585b0
PE
7087 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7088 since it's unused otherwise.
032f1620 7089
367c19e5 7090 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7091 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7092 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7093 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7094 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7095 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7096 does not deduce are never used uninitialized.
70739cbe 7097
07b48fa9
PE
7098 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7099
8868a238 7100 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7101 * window.c (window_loop, size_window):
7102 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7103
7e5cf297 7104 * window.c (display_buffer): Now static.
d6550a9f
PE
7105 (size_window): Mark variables that gcc -Wuninitialized
7106 does not deduce are never used uninitialized.
a586633d
PE
7107 * window.h (check_all_windows): New decl, to forestall
7108 gcc -Wmissing-prototypes diagnostic.
5b555da1 7109 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7110
f6095868
PE
7111 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7112 shadowing.
7113 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7114 Include <limits.h>.
7115 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7116 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7117 (load_charset_map): Mark variables that gcc -Wuninitialized
7118 does not deduce are never used uninitialized.
53df7c11 7119 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7120
f38b440c
PE
7121 * coding.c (coding_set_source, coding_set_destination):
7122 Use "else { /* comment */ }" rather than "else /* comment */;"
7123 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7124 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7125 a block, when the outer 'i' will do.
7126 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7127 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7128 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7129 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7130 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7131 Rename locals to avoid shadowing.
7132 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7133 * coding.c (emacs_mule_char, encode_invocation_designation):
7134 Now static, since they're not used elsewhere.
413bb2db 7135 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7136 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7137 (decode_coding_emacs_mule): Mark variables that gcc
7138 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7139 (detect_coding_iso_2022): Initialize a local variable that might
7140 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7141 this initialization is needed. (Bug#8211)
5f58e762
PE
7142 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7143 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7144 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7145 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7146 Remove unused macros.
f38b440c 7147
232b38b9 7148 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7149 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7150 * character.c (string_count_byte8): Likewise.
232b38b9 7151
fb90da1b
PE
7152 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7153 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7154
fb93dbc2
PE
7155 * chartab.c (copy_sub_char_table): Now static, since it's not used
7156 elsewhere.
5c156ace
PE
7157 (sub_char_table_ref_and_range, char_table_ref_and_range):
7158 Rename locals to avoid shadowing.
bbcd0949 7159 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7160
7d3b3862 7161 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7162 (BIDI_BOB): Remove unused macro.
7d3b3862 7163
6be7d3da
PE
7164 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7165 deduce are never used uninitialized.
c2ed9c8b 7166 * term.c (encode_terminal_code): Likewise.
6be7d3da 7167
75f8807f 7168 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7169
50938595
PE
7170 * tparam.h: New file.
7171 * term.c, tparam.h: Include it.
7172 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7173 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7174 Move these decls to tparam.h, and make them agree with what
7175 is actually in tparam.c. The previous trick of using incompatible
7176 decls in different modules does not conform to the C standard.
7177 All callers of tparam changed to use tparam's actual API.
7178 * tparam.c (tparam1, tparam, tgoto):
7179 Use const pointers where appropriate.
7180
fbceeba2
PE
7181 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7182 * cm.h (struct cm): Likewise.
7183 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7184 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7185 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7186 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7187 (turn_on_face, init_tty): Likewise.
7188 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7189
7f3f1250
PE
7190 * term.c (term_mouse_position): Rename local to avoid shadowing.
7191
e6ca6543
PE
7192 * alloc.c (mark_ttys): Move decl from here ...
7193 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7194
c40f8d15
AS
71952011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7196
7197 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7198
cfe0661d
JB
71992011-03-09 Juanma Barranquero <lekktu@gmail.com>
7200
7201 * search.c (compile_pattern_1): Remove argument regp, unused since
7202 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7203 (compile_pattern): Don't pass it.
7204
0afb4571
J
72052011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7206
7207 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7208 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7209 for ! HAVE_GTK3.
7210 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7211
7212 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7213
7214 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7215 gdk_window_get_screen, gdk_window_get_geometry,
7216 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7217 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7218 (xg_get_pixbuf_from_pixmap): New function.
7219 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7220 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7221 Call xg_get_pixbuf_from_pixmap instead of
7222 gdk_pixbuf_get_from_drawable.
7223 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7224 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7225 (xg_check_special_colors): Use GtkStyleContext and its functions
7226 for HAVE_GTK3.
7227 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7228 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7229 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7230 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7231 Call gtk_widget_get_preferred_size.
0afb4571
J
7232 (xg_frame_resized): gdk_window_get_geometry only takes 5
7233 parameters.
44f230aa
SM
7234 (xg_win_to_widget, xg_event_is_for_menubar):
7235 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7236 (xg_set_widget_bg): New function.
7237 (delete_cb): New function.
895009e1 7238 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7239 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7240 (xg_set_background_color): Call xg_set_widget_bg.
7241 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7242 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7243 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7244 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7245 if ! HAVE_GTK3.
7246 (update_frame_tool_bar): Call gtk_widget_hide.
7247 (xg_initialize): Use GDK_KEY_g.
7248
7249 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7250 if ! HAVE_GTK3
7251 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7252
7253 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7254 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7255 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7256
1c2cc4ef
JB
72572011-03-08 Juanma Barranquero <lekktu@gmail.com>
7258
7259 * w32xfns.c (select_palette): Check success of RealizePalette against
7260 GDI_ERROR, not zero.
7261
33383987 7262See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7263
7264;; Local Variables:
7265;; coding: utf-8
aac0c6e3
MR
7266;; End:
7267
33383987 7268 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7269
7270 This file is part of GNU Emacs.
7271
7272 GNU Emacs is free software: you can redistribute it and/or modify
7273 it under the terms of the GNU General Public License as published by
7274 the Free Software Foundation, either version 3 of the License, or
7275 (at your option) any later version.
7276
7277 GNU Emacs is distributed in the hope that it will be useful,
7278 but WITHOUT ANY WARRANTY; without even the implied warranty of
7279 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7280 GNU General Public License for more details.
7281
7282 You should have received a copy of the GNU General Public License
7283 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.