lisp/bindings.el (top): Use `mapc' instead of `mapcar'.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2277de02
JD
12012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2
3 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
4 and free it with DestroyExceptionInfo (Bug#11558).
5
ef099b57
JB
62012-07-13 Juanma Barranquero <lekktu@gmail.com>
7
8 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
9 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
10 Set here, not in nt/config.nt.
11
ea814a5d
EZ
122012-07-13 Eli Zaretskii <eliz@gnu.org>
13
14 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
15 cursor overflow into the last glyph on display line when the right
16 fringe is off. (Bug#11832)
17
1a952767
PE
182012-07-13 Paul Eggert <eggert@cs.ucla.edu>
19
20 * xdisp.c (produce_special_glyphs): Now static.
21 * dispextern.h (produce_special_glyphs): Remove decl.
22
983188fd
GM
232012-07-13 Glenn Morris <rgm@gnu.org>
24
32fb4bb6
GM
25 * s/bsd-common, s/cygwin.h: Remove empty files.
26 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
27
983188fd
GM
28 * s/usg5-4-common.h (USG, USG5):
29 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
30 * s/sol2-6.h (SOLARIS2):
31 * s/irix6-5.h (IRIX6_5):
32 * s/hpux10-20.h (USG, USG5, HPUX):
33 * s/gnu-linux.h (USG, GNU_LINUX):
34 * s/freebsd.h (BSD_SYSTEM):
35 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
36 * s/cygwin.h (CYGWIN):
37 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
38 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
39
d1e68667 402012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
41
42 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 43
6de0e799
GM
442012-07-13 Glenn Morris <rgm@gnu.org>
45
739ae010
GM
46 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
47
dbee5793
GM
48 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
49
6de0e799
GM
50 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
51 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
52
b82da769
GM
532012-07-12 Glenn Morris <rgm@gnu.org>
54
4fae5a7a 55 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
56
57 * process.c (init_process_emacs): Rename from init_process.
58 The old name is also the name of a Mach system call.
59 * lisp.h, emacs.c: Update for this name change.
60 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
61 longer needed.
62
5a979817
EZ
632012-07-12 Eli Zaretskii <eliz@gnu.org>
64
65 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
66 memmove call that removes glyphs covered by the left truncation
67 glyph. Improve commentary.
68 (display_line): Fix display of continuation glyphs on GUI frames
69 when the right fringe is turned off and variable-size fonts are
70 used in the window. Move the code that appends a stretch glyph to
71 produce_special_glyphs, so that it could be used for truncation
72 and continuation glyphs alike.
73 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
74 glyph of a suitably computed width, to align the special glyphs at
75 the window margin. Code moved from display_line. (Bug#11832)
76
3e91a053
GM
772012-07-12 Glenn Morris <rgm@gnu.org>
78
ba9e4b84
GM
79 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
80
81 * s/gnu-linux.h, s/hpux10-20.h:
82 Do not unconditionally define HAVE_XRMSETDATABASE.
83
3e91a053
GM
84 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
85
b300b1f4
PE
862012-07-12 Paul Eggert <eggert@cs.ucla.edu>
87
88 Fix typos that broke OS X build.
89 Reported by Randal L. Schwartz in
90 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
91 * nsterm.m (ns_timeout): Add missing local decl.
92 (ns_get_color): snprintf -> sprintf, to fix typo.
93
6e777848
GM
942012-07-12 Glenn Morris <rgm@gnu.org>
95
3f922c37
GM
96 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
97 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
98 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
99 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
100
0ab7b23a
GM
101 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
102 Move PTY_OPEN to configure.
103
6e777848
GM
104 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
105 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
106 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
107
4a7edc24
DA
1082012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
109
110 Use empty_unibyte_string where applicable.
111 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
112 * lread.c (read1): Likewise.
113 * xsettings.c (syms_of_xsettings): Likewise.
114
308aab79
GM
1152012-07-12 Glenn Morris <rgm@gnu.org>
116
42bd1719
GM
117 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
118 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
119 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
120 * s/hpux10-20.h (RUN_TIME_REMAP):
121 * s/bsd-common.h (TABDLY): Move to configure.
122
123 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
124
125 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
126
ea0bbd17 127 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 128 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
129
130 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 131
308aab79
GM
132 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
133 * s/template.h: Move NARROWPROTO to configure.
134
ee1cf5cf
GM
1352012-07-11 Glenn Morris <rgm@gnu.org>
136
30fe9bf4
GM
137 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
138 unused since 2011-01-17 change to systty.h.
139
ee1cf5cf
GM
140 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
141 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
142 Move HAVE_PTYS and HAVE_SOCKETS to configure.
143
63e47e07
PE
1442012-07-11 Paul Eggert <eggert@cs.ucla.edu>
145
146 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
147
c43fb4c3
GM
1482012-07-11 Glenn Morris <rgm@gnu.org>
149
150 * s/darwin.h, s/gnu-linux.h, s/template.h:
151 Move INTERRUPT_INPUT to configure.
152
e8df9267
DA
1532012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
154
155 Minor adjustments to interning code.
156 * lisp.h (intern, intern_c_string): Redefine as static inline
157 wrappers for intern_1 and intern_c_string_1, respectively.
158 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
159 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
160 Vobarray checking.
e8df9267
DA
161 * font.c (font_intern_prop): Likewise. Adjust comment.
162 * w32font.c (intern_font_name): Likewise.
163
34348bd4
AS
1642012-07-11 Andreas Schwab <schwab@linux-m68k.org>
165
d96a1e0c
AS
166 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
167
34348bd4
AS
168 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
169 of Fcar/Fcdr if possible.
170 * font.c (check_otf_features): Likewise.
171 * fontset.c (Fnew_fontset): Likewise.
172 * gnutls.c (Fgnutls_boot): Likewise.
173 * minibuf.c (read_minibuf): Likewise.
174 * msdos.c (IT_set_frame_parameters): Likewise.
175 * xmenu.c (Fx_popup_dialog): Likewise.
176 * w32menu.c (Fx_popup_dialog): Likewise.
177
c8add24e
GM
1782012-07-11 Glenn Morris <rgm@gnu.org>
179
4b575b3c
GM
180 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
181 since nothing has defined it on these platforms.
182
09f4e3b0
GM
183 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
184 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
185
172bedef
GM
186 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
187 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
188 Move CLASH_DETECTION to configure.
189
249685df
GM
190 * s/gnu.h: Remove file, which is now empty.
191
c8add24e
GM
192 * s/gnu.h, s/gnu-linux.h:
193 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
194
b41253a3
JW
1952012-07-11 John Wiegley <johnw@newartisans.com>
196
197 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
198 function attribute, so we only use it if it exists in the
199 compiler.
200
d923b542
DA
2012012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
202
203 Avoid call to strlen in fast_c_string_match_ignore_case.
204 * search.c (fast_c_string_match_ignore_case): Change to use
205 length argument. Adjust users accordingly.
206 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
207
5ebbef1d
PE
2082012-07-11 Paul Eggert <eggert@cs.ucla.edu>
209
bb352260
PE
210 Assume mkdir, rmdir.
211 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
212 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
213
57054ddd
PE
214 Assume rename.
215 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
216
b747d3f7
PE
217 Assume perror.
218 * s/hpux10-20.h (HAVE_PERROR): Remove.
219 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
220 Remove dummy definition, as this problem was obsolete long ago.
221
5ebbef1d
PE
222 Assume strerror.
223 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
224
984e7f30
DA
2252012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
226
227 Avoid calls to strlen in font processing functions.
228 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 229 (font_open_by_name): Change to use length argument. Adjust
984e7f30 230 users accordingly.
d923b542
DA
231 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
232 Adjust prototypes.
233 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
234 Change to return ptrdiff_t.
984e7f30
DA
235 (xfont_list_pattern, xfont_match): Use length returned by
236 xfont_decode_coding_xlfd.
237 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
238
20e94fdd
GM
2392012-07-11 Glenn Morris <rgm@gnu.org>
240
9d596af3
GM
241 * s/darwin.h, s/freebsd.h, s/netbsd.h:
242 Move DONT_REOPEN_PTY to configure.
243
20e94fdd
GM
244 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
245 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
246
e99a530f
PE
2472012-07-10 Paul Eggert <eggert@cs.ucla.edu>
248
22ffb973
PE
249 Remove "#define unix" that is no longer needed (Bug#11905).
250 * s/aix4-2.h (unix): Remove; no longer needed.
251
e9a9ae03
PE
252 EMACS_TIME simplification (Bug#11875).
253 This replaces macros (which typically do not work in GDB)
254 with functions, typedefs and enums, making the code easier to debug.
255 The functional style also makes code easier to read and maintain.
256 * systime.h: Include <sys/time.h> on all hosts, not just if
257 WINDOWSNT, since 'struct timeval' is needed in general.
258 (EMACS_TIME): Now a typedef, not a macro.
259 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
260 not macros.
261 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
262 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
263 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
264 (EMACS_TIME_LE): Now functions, not macros.
265 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
266 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
267 which are not functions. All uses rewritten to use:
268 (make_emacs_time): New function.
269 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
270 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
271 not functions. All uses rewritten to use the following, respectively:
272 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
273 (add_emacs_time, sub_emacs_time): New functions.
274 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
275 * fileio.c (Fcopy_file):
276 * xterm.c (XTflash): Get the current time closer to when it's used.
277 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
278
ffacb126
PE
279 * bytecode.c (targets): Suppress -Woverride-init warnings.
280
e99a530f
PE
281 Simplify by avoiding confusing use of strncpy etc.
282 * doc.c (Fsnarf_documentation):
283 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
284 * frame.c (Fmake_terminal_frame):
285 * gtkutil.c (get_utf8_string):
286 * lread.c (openp):
287 * nsmenu.m (ns_update_menubar):
288 * regex.c (regerror):
289 Prefer memcpy to strncpy and strncat when either will do.
290 * fileio.c (Fsubstitute_in_file_name):
291 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
292 (menu_separator_name_p):
293 * nsmenu.m (ns_update_menubar):
294 Prefer memcmp to strncmp when either will do.
295 * nsterm.m: Include <ftoastr.h>.
296 (ns_get_color):
297 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
298 Prefer snprintf to strncpy.
299 * nsterm.m (ns_term_init):
300 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
301 * nsterm.m (ns_term_init):
302 Avoid the need for strncpy, by using build_string or
303 make_unibyte_string directly. Use dtoastr, not snprintf.
304 * process.c (Fmake_network_process): Diagnose service names that
305 are too long, rather than silently truncating them or creating
306 non-null-terminated names.
307 (Fnetwork_interface_info): Likewise, for interface names.
308 * sysdep.c (system_process_attributes) [GNU_LINUX]:
309 Prefer sprintf to strncat.
310 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
311 Prefer vsnprintf to vsprintf + strncpy.
312
c59592b3
GM
3132012-07-10 Glenn Morris <rgm@gnu.org>
314
315 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
316 Clarify fallback case.
317
7d7bbefd
DA
3182012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
319
320 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
321 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
322 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 323 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
324 where argument type is known to be a Lisp_Cons.
325
3a4c8000
TT
3262012-07-10 Tom Tromey <tromey@redhat.com>
327
328 * bytecode.c (BYTE_CODE_THREADED): New macro.
329 (BYTE_CODES): New macro. Replaces all old byte-code defines.
330 (enum byte_code_op): New type.
331 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
332 (exec_byte_code): Use them. Use token threading when applicable.
333
2a0213a6
DA
3342012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
335
336 Optimize pure C strings initialization.
337 * lisp.h (make_pure_string): Fix prototype.
338 (build_pure_c_string): New function, defined as static inline. This
339 provides a better opportunity to optimize away calls to strlen when
340 the function is called with compile-time constant argument.
341 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
342 argument, adjust users accordingly. Use build_pure_c_string where
343 appropriate.
344 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
345 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
346 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
347
cb1caeaf
DA
3482012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
349
350 Avoid calls to strlen in miscellaneous functions.
351 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
352 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
353 * lread.c (openp): Likewise.
354
c293e30c
DA
3552012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
356
357 Avoid calls to strlen in path processing functions.
358 * fileio.c (file_name_as_directory): Add comment. Change to add
359 srclen argument and return the length of result. Adjust users
360 accordingly.
361 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 362 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
363 users accordingly.
364 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
365
9e059e3f
GM
3662012-07-10 Glenn Morris <rgm@gnu.org>
367
d02eb359
GM
368 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
369 Move PENDING_OUTPUT_COUNT definition to configure.
370
882cf227
GM
371 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
372 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
373 * s/gnu.h (DATA_START): Move definitions to configure.
374
af6e839f
GM
375 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
376 We include usg5-4-common.h, which defines them both.
377
40289a12
GM
378 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
379 O_RDONLY already includes it).
380
9e059e3f
GM
381 Stop ns builds setting the EMACSLOADPATH environment variable.
382 * nsterm.m (ns_load_path): Rename from ns_init_paths.
383 Now it does not set EMACSLOADPATH, just returns the load-path string.
384 * nsterm.h: Update accordingly.
385 * lread.c [HAVE_NS]: Include nsterm.h.
386 (init_lread) [HAVE_NS]: Use ns_load_path.
387 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
388
7c4e8ec0
GM
3892012-07-09 Glenn Morris <rgm@gnu.org>
390
d4f600ff
GM
391 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
392 since the included bsd-common.h does so.
393
cbb31951
GM
394 Stop ns builds setting the EMACSPATH environment variable.
395 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
396 (ns_init_paths): Do not set EMACSPATH.
397 * nsterm.h (ns_exec_path): Add it.
398 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
399 Use ns_exec_path.
400
7c4e8ec0
GM
401 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
402
26bccfae
PE
4032012-07-09 Paul Eggert <eggert@cs.ucla.edu>
404
a0bee46f
PE
405 * process.c (wait_reading_process_output): 'waitchannels' was unset
406 when read_kbd || !NILP (wait_for_cell); fix this.
407
5994c183
PE
408 Add GCC-style 'const' attribute to functions that can use it.
409 * character.h (char_resolve_modifier_mask):
410 * keyboard.h (make_ctrl_char):
411 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
412 (init_character_once, next_almost_prime, init_fns, init_image)
413 (flush_pending_output, init_sound):
414 * mem-limits.h (start_of_data):
415 * menu.h (finish_menu_items):
416 Add ATTRIBUTE_CONST.
417 * emacs.c (DEFINE_DUMMY_FUNCTION):
418 Declare the dummy function with ATTRIBUTE_CONST.
419 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
420 Add decls with ATTRIBUTE_CONST.
421
26bccfae
PE
422 Minor improvements to make_formatted_string.
423 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
424 where int is good enough, as vsprintf returns an int.
425 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
426
a8290ec3
DA
4272012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
428
429 Use make_formatted_string to avoid double length calculation.
430 * lisp.h (make_formatted_string): New prototype.
431 * alloc.c (make_formatted_string): New function.
432 * buffer.c (Fgenerate_new_buffer_name): Use it.
433 * dbus.c (syms_of_dbusbind): Likewise.
434 * editfns.c (Fcurrent_time_zone): Likewise.
435 * filelock.c (get_boot_time): Likewise.
436 * frame.c (make_terminal_frame, set_term_frame_name)
437 (x_report_frame_params): Likewise.
438 * image.c (gs_load): Likewise.
439 * minibuf.c (get_minibuffer): Likewise.
440 * msdos.c (dos_set_window_size): Likewise.
441 * process.c (make_process): Likewise.
442 * xdisp.c (ensure_echo_area_buffers): Likewise.
443 * xsettings.c (apply_xft_settings): Likewise.
444
d01ba2f1
GM
4452012-07-09 Glenn Morris <rgm@gnu.org>
446
447 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
448 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
449 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
450 * nsterm.h (ns_etc_directory): Add it.
451 * callproc.c [HAVE_NS]: Include nsterm.h.
452 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
453
f1f924b6
DA
4542012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
455
456 Move marker debugging code under MARKER_DEBUG.
457 * marker.c (MARKER_DEBUG): Move marker debugging code under
458 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
459 for bootstrap with --enable-checking (~3x slowdown reported
460 by Juanma Barranquero <lekktu@gmail.com>).
461 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
462
ab531b66
PE
4632012-07-08 Paul Eggert <eggert@cs.ucla.edu>
464
465 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
466 See <http://bugs.gnu.org/11825#29>.
467
c4b3bc8a
EZ
4682012-07-08 Eli Zaretskii <eliz@gnu.org>
469
470 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
471 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
472 (display_line): Add commentary about displaying truncation glyphs
473 on GUI frames.
474 (produce_special_glyphs): Move here from term.c.
475
476 * term.c (produce_special_glyphs): Move to xdisp.c.
477
478 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
479 section.
c4b3bc8a 480
b676b881
AS
4812012-07-07 Andreas Schwab <schwab@linux-m68k.org>
482
f17c5273
AS
483 * xdisp.c (display_line): Avoid warning about implicit declaration
484 of FRAME_FONT.
485
298819b9
AS
486 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
487
b676b881
AS
488 * lisp.h: Remove empty conditional.
489
6045c4fd
PE
4902012-07-07 Paul Eggert <eggert@cs.ucla.edu>
491
b3350bf9
PE
492 * lread.c (load_path_check): Now static.
493
6045c4fd
PE
494 Fix some minor --with-ns problems found by static checking.
495 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
496 (x_set_font) [!HAVE_X_WINDOWS]:
497 * image.c (xpm_load_image) [HAVE_NS]:
498 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
499 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
500 Remove unused local.
501 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
502 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
503 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
504 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
505 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
506 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
507 Fix pointer signedness problem.
508 * xfaces.c (FRAME_X_FONT_TABLE):
509 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
510
929e7845
GM
5112012-07-07 Glenn Morris <rgm@gnu.org>
512
513 * lread.c (load_path_check): New function, split from init_lread.
514 (init_lread): Reorganize. Motivation:
515 If EMACSLOADPATH is set, check/warn about that rather than the
516 defaults, which we are not going to use. Hence we can remove
517 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
518 Don't warn if site-lisp directories are missing.
519 If not installed, start from a blank load-path, since
520 PATH_LOADSEARCH refers to the eventual installation directories.
521
58dd0aa4
EZ
5222012-07-07 Eli Zaretskii <eliz@gnu.org>
523
524 Support truncation and continuation glyphs on GUI frames, when
525 fringes are disabled. (Bug#11832)
526 * xdisp.c (init_iterator): Get dimensions of truncation and
527 continuation glyphs even if on GUI frames. Adjust
528 it->last_visible_x on GUI frames when the left or right fringes,
529 or both, are absent.
530 (start_display, move_it_in_display_line_to): Handle the case of a
531 GUI frame without a fringe to display continuation or truncation
532 glyphs.
533 (insert_left_trunc_glyphs): Support GUI frames: make sure
534 truncation glyphs overwrite enough glyphs from the current line to
535 have sufficient space in pixels.
536 (display_line): Support truncation and continuation glyphs on GUI
537 frames. If some spare pixels are left on the line after inserting
538 the truncation glyphs, fill that space with a stretch glyph of a
539 suitably computed width.
540
541 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
542 produce_glyphs, to support GUI sessions.
543
31571fd7
PE
5442012-07-07 Paul Eggert <eggert@cs.ucla.edu>
545
5a16b9bc
PE
546 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
547
f3047c75
PE
548 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
549
31571fd7
PE
550 Do not require float-time's arg to fit in time_t (Bug#11825).
551 This works better on hosts where time_t is unsigned, and where
552 float-time is applied to the (negative) difference between two times.
553 * editfns.c (decode_time_components): Last arg is now double *,
554 not int *, and means to store all the result as a double, without
555 worrying about whether the seconds part fits in time_t.
556 All callers changed.
557 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
558 All callers changed.
559 (Ffloat_time): Do not fail merely because the specified time falls
560 outside of time_t range.
561
4516fbef
GM
5622012-07-07 Glenn Morris <rgm@gnu.org>
563
564 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
565 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
566 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
567
07adc2c6
JB
5682012-07-07 Juanma Barranquero <lekktu@gmail.com>
569
570 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
571 Update dependencies.
572
573 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
574
fd573f31
PE
5752012-07-06 Paul Eggert <eggert@cs.ucla.edu>
576
fee5959d
PE
577 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
578 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
579 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
580 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
581 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
582 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
583
fd573f31
PE
584 * xfont.c (compare_font_names): Redo to omit the need for casts.
585
ddadbc0e
AS
5862012-07-06 Andreas Schwab <schwab@linux-m68k.org>
587
fca8d6b6
AS
588 * xfns.c (Fx_change_window_property): Doc fix.
589 * w32fns.c (Fx_change_window_property): Doc fix.
590
ddadbc0e
AS
591 * w32fns.c (Fx_window_property): Accept the same arguments as the
592 X Windows version. Doc fix.
593 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
594
f247498e
JB
5952012-07-06 Juanma Barranquero <lekktu@gmail.com>
596 Eli Zaretskii <eliz@gnu.org>
597
598 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
599 Windows-specific code from nt/config.nt moved here.
600 Obsolete settings removed.
601
216ee680
PE
6022012-07-06 Paul Eggert <eggert@cs.ucla.edu>
603
604 * process.c: Avoid unnecessary calls to gettime.
605 (wait_reading_process_output): Don't get the time of day
606 when gobbling data immediately and not waiting, as there's no need
607 for it in that case. This removes a FIXME.
608
bdd091e4
JD
6092012-07-06 Jan Djärv <jan.h.d@swipnet.se>
610
611 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
612 is defined (Bug#11768).
613
9d44f8ce
DA
6142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
615
616 Fix marker debugging code.
617 * marker.c (byte_char_debug_check): Do not perform the check
618 if buffer is not multibyte.
090bd7cb
JB
619 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
620 Call byte_char_debug_check with correct arguments.
9d44f8ce 621
90fc4786
DA
6222012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
623
624 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
625 * marker.c (byte_char_debug_check, count_markers):
626 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
627 (byte_debug_flag): Remove.
628 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
629 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
630
7b7ae965
DA
6312012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
632
4e57b342
DA
633 Avoid code repetition in marker-related functions.
634 * marker.c (attach_marker): New function.
635 (Fset_marker, set_marker_restricted, set_marker_both)
636 (set_marker_restricted_both): Use it.
637 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
638 Consistently rename charno to charpos.
639 (marker_position): Add eassert.
640 (marker_byte_position): Convert to eassert.
641
6422012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
643
644 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 645 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 646 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 647
657924ff
DA
6482012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
649
650 Introduce fast path for the widely used marker operation.
651 * alloc.c (build_marker): New function.
652 * lisp.h (build_marker): New prototype.
653 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
654 * composite.c (autocmp_chars): Likewise.
655 * editfns.c (buildmark): Remove.
656 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
657 (save_restriction_save): Use build_marker.
658 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
659 * window.c (save_window_save): Likewise.
660
041a49a6
DA
6612012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
662
663 Do not use Fdelete_overlay in delete_all_overlays
664 to avoid redundant calls to unchain_overlay.
665 * buffer.c (drop_overlay): New function.
666 (delete_all_overlays, Fdelete_overlay): Use it.
667 * minibuf.c (get_minibuffer): Fix comment.
668
7dca65a4
PE
6692012-07-06 Paul Eggert <eggert@cs.ucla.edu>
670
671 Port to OpenBSD 5.1 amd64.
672 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
673 This is needed for OpenBSD, and should be harmless on all BSD systems.
674 Also, include <sys/sysctl.h>, as it should be available on all
675 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
676 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
677 use p_pid member, not kp_proc.pid.
678
8eb876e2
GM
6792012-07-06 Glenn Morris <rgm@gnu.org>
680
681 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
682
38182d90
PE
6832012-07-05 Paul Eggert <eggert@cs.ucla.edu>
684
685 More xmalloc and related cleanup.
686 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
687 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
688 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
689 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
690 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
691 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
692 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
693 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
694 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
695 * xterm.c:
696 Omit needless casts involving void * pointers and allocation.
697 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
698 as the former is more robust if P's type is changed.
699 Prefer xzalloc to xmalloc + memset 0.
700 Simplify malloc-or-realloc to realloc.
701 Don't worry about xmalloc returning a null pointer.
702 Prefer xstrdup to xmalloc + strcpy.
703 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
704 growing it.
705 * keyboard.c (apply_modifiers_uncached): Prefer local array to
706 alloca of a constant.
707
6dd5a677
EZ
7082012-07-05 Eli Zaretskii <eliz@gnu.org>
709
710 * xdisp.c (display_line): Fix horizontal pixel coordinates when
711 hscroll is larger than the line width. Fixes long and futile
712 looping inside extend_face_to_end_of_line (on a TTY) producing
713 glyphs that are not needed and thrown away.
714
6b312f0f
DA
7152012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
716
717 * marker.c (set_marker_restricted_both): Simplify by using
718 clip_to_bounds.
719
f520ef9b
PE
7202012-07-05 Paul Eggert <eggert@cs.ucla.edu>
721
722 * editfns.c (region_limit): Simplify by using clip_to_bounds.
723
383b7c95
JD
7242012-07-05 Jan Djärv <jan.h.d@swipnet.se>
725
726 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
727 not defined (Bug#11768).
728 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
729 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
730 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
731 followed by gtk_box_set_homogeneous (Bug#11768).
732 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
733 (update_theme_scrollbar_width, xg_create_scroll_bar):
734 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
735 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
736 (is_box_type): New function (Bug#11768).
737 (xg_tool_item_stale_p): Call is_box_type.
5293d758 738 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
739 with default display (Bug#11768).
740
d6e7bf45
EZ
7412012-07-05 Eli Zaretskii <eliz@gnu.org>
742
743 * xdisp.c (window_hscroll_limited): New function.
744 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
745 coordinates when window's hscroll is set to insanely large
746 values. (Bug#11857)
747
431391ec
JB
7482012-07-05 Juanma Barranquero <lekktu@gmail.com>
749
750 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
751 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
752
23f86fce
DA
7532012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
754
755 Cleanup xmalloc.
756 * lisp.h (xzalloc): New prototype. Omit needless casts.
757 * alloc.c (xzalloc): New function. Omit needless casts.
758 * charset.c: Omit needless casts. Convert all calls to
759 xmalloc with following memset to xzalloc.
760 * dispnew.c: Likewise.
761 * fringe.c: Likewise.
762 * image.c: Likewise.
763 * sound.c: Likewise.
764 * term.c: Likewise.
765 * w32fns.c: Likewise.
766 * w32font.c: Likewise.
767 * w32term.c: Likewise.
768 * xfaces.c: Likewise.
769 * xfns.c: Likewise.
770 * xterm.c: Likewise.
771 * atimer.c: Omit needless casts.
772 * buffer.c: Likewise.
773 * callproc.c: Likewise.
774 * ccl.c: Likewise.
775 * coding.c: Likewise.
776 * composite.c: Likewise.
777 * doc.c: Likewise.
778 * doprnt.c: Likewise.
779 * editfns.c: Likewise.
780 * emacs.c: Likewise.
781 * eval.c: Likewise.
782 * filelock.c: Likewise.
783 * fns.c: Likewise.
784 * gtkutil.c: Likewise.
785 * keyboard.c: Likewise.
786 * lisp.h: Likewise.
787 * lread.c: Likewise.
788 * minibuf.c: Likewise.
789 * msdos.c: Likewise.
790 * print.c: Likewise.
791 * process.c: Likewise.
792 * region-cache.c: Likewise.
793 * search.c: Likewise.
794 * sysdep.c: Likewise.
795 * termcap.c: Likewise.
796 * terminal.c: Likewise.
797 * tparam.c: Likewise.
798 * w16select.c: Likewise.
799 * w32.c: Likewise.
800 * w32reg.c: Likewise.
801 * w32select.c: Likewise.
802 * w32uniscribe.c: Likewise.
803 * widget.c: Likewise.
804 * xdisp.c: Likewise.
805 * xmenu.c: Likewise.
806 * xrdb.c: Likewise.
807 * xselect.c: Likewise.
808
0497dc44
PE
8092012-07-05 Paul Eggert <eggert@cs.ucla.edu>
810
811 * fileio.c (time_error_value): Check the right error number.
812 Problem reported by Troels Nielsen in
813 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
814
356e7178
PE
8152012-07-04 Paul Eggert <eggert@cs.ucla.edu>
816
4e71fd89
PE
817 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
818 This should be fixed in a better way; see Eli Zaretskii in
819 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
820 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
821
f0941253
PE
822 * fileio.c (time_error_value): Rename from special_mtime.
823 The old name's problems were noted by Eli Zaretskii in
824 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
825
065c9eb4
PE
826 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
827 This variable's comment says Emacs needs at least one GDB-visible
828 symbol of type enum pvec_type, to work around GDB problems.
829 The symbol's value doesn't matter.
830
356e7178
PE
831 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
832 that causes compilation to fail on pre-C99 compilers.
833
95f61aa2
JB
8342012-07-04 Juanma Barranquero <lekktu@gmail.com>
835
836 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
837 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
838
3884d954
DA
8392012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
840
d209e2fb 841 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
842 headers for buffer_defaults and buffer_local_symbols.
843 Reported by Juanma Barranquero <lekktu@gmail.com>.
844
ee28be33
SM
8452012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
846
847 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
848 * lisp.h (enum pvec_type): Use fewer bits.
849 (PSEUDOVECTOR_SIZE_BITS): New constant.
850 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
851 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
852 change in pvec_type.
853 (PSEUDOVECTOR_TYPEP): New macro.
854 (TYPED_PSEUDOVECTORP): Use it.
855 * fns.c (internal_equal): Adapt code to extract pvectype.
856 * emacs.c (gdb_pvec_type): Update type.
857 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
858 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
859 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
860 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
861 (sweep_vectors): Use it. Use local var `total_bytes' instead of
862 abusing vector->header.next.nbytes.
863 (live_vector_p): Use PVEC_TYPE.
864 (mark_object): Adapt code to extract pvectype. Use switch.
865
c7f2cd7f
PE
8662012-07-04 Paul Eggert <eggert@cs.ucla.edu>
867
868 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
869 Tighten new eassert a bit.
870
8ce70ed2
DA
8712012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
872
873 Fix compilation with --enable-gcc-warnings and -O1
874 optimization level.
875 * doprnt.c (doprnt): Change type of tem to int, initialize
876 to avoid compiler warning. Add eassert.
877 * search.c (simple_search): Initialize match_byte to avoid
878 compiler warning. Add eassert.
879
dea7f1e5
PE
8802012-07-04 Paul Eggert <eggert@cs.ucla.edu>
881
24a212eb
PE
882 Avoid weird behavior with large horizontal scrolls.
883 Without this change, for example, large hscroll values would
884 mess up Emacs's display on Fedora 15 x86, presumably due to
885 overflows in int calculations in the display code.
886 Also, if buffers had long lines, Emacs would freeze.
887 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
888 (set_window_hscroll): New function, containing the old guts of
889 Fset_window_hscroll. Return the clipped value.
890 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
891 This avoids the need to check against PTRDIFF_MAX.
892
dea7f1e5
PE
893 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
894
76046526
DA
8952012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
896
897 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
898
39adff0d
PE
8992012-07-04 Paul Eggert <eggert@cs.ucla.edu>
900
63807d47
PE
901 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
902 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
903 since GCC 4.4.6 issues a bogus warning for them.
904
39adff0d
PE
905 Fix bugs in file timestamp newness comparisons.
906 * fileio.c (Ffile_newer_than_file_p):
907 * lread.c (Fload): Use full timestamp resolution of files,
908 not just the 1-second resolution, so that files that are only
909 slightly newer still count as newer.
910 * fileio.c (Ffile_newer_than_file_p): Don't assume file
911 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
912
dbeed9a6
PE
9132012-07-03 Paul Eggert <eggert@cs.ucla.edu>
914
915 * fileio.c: Improve handling of file time marker. (Bug#11852)
916 (special_mtime): New function.
917 (Finsert_file_contents, Fverify_visited_file_modtime):
918 Use it to set special mtime values consistently.
919
636334d6
AS
9202012-07-03 Andreas Schwab <schwab@linux-m68k.org>
921
922 * fileio.c (Finsert_file_contents): Properly handle st_mtime
923 marker for non-existing file. (Bug#11852)
924
e2017fe2
GM
9252012-07-03 Glenn Morris <rgm@gnu.org>
926
927 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
928 and did not make it into globals.h).
929
404dbd37
TT
9302012-07-03 Tom Tromey <tromey@redhat.com>
931
932 * window.c (Fset_window_margins, Fset_window_fringes)
933 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
934 * textprop.c (Fprevious_property_change): No longer static.
935 * syntax.c (Fsyntax_table_p): No longer static.
936 * process.c (Fget_process, Fprocess_datagram_address): No longer
937 static.
938 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
939 * keyboard.c (Fcommand_execute): No longer static.
940 Remove EXFUN.
941 * insdel.c (Fcombine_after_change_execute): No longer static.
942 * image.c (Finit_image_library): No longer static.
943 * fileio.c (Fmake_symbolic_link): No longer static.
944 * eval.c (Ffetch_bytecode): No longer static.
945 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
946 * doc.c (Fdocumentation_property, Fsnarf_documentation):
947 No longer static.
404dbd37
TT
948 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
949 static.
950 * dired.c (Ffile_attributes): No longer static.
951 * composite.c (Fcomposition_get_gstring): No longer static.
952 * callproc.c (Fgetenv_internal): No longer static.
953
954 * ccl.h: Remove EXFUNs.
955 * buffer.h: Remove EXFUNs.
956 * dispextern.h: Remove EXFUNs.
957 * intervals.h: Remove EXFUNs.
958 * fontset.h: Remove EXFUN.
959 * font.h: Remove EXFUNs.
960 * dosfns.c (system_process_attributes): Remove EXFUN.
961 * keymap.h: Remove EXFUNs.
962 * lisp.h: Remove EXFUNs.
963 * w32term.h: Remove EXFUNs.
964 * window.h: Remove EXFUNs.
965 * xsettings.h: Remove EXFUN.
966 * xterm.h: Remove EXFUN.
967
8e4fd1e1
GM
9682012-07-03 Glenn Morris <rgm@gnu.org>
969
970 * lisp.h (Frandom): Make it visible to C.
971 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
972 buffer for invisible buffers. (Bug#1229)
973
ca95b3eb
DA
9742012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
975
976 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
977 values which aren't power of 2.
978 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
979 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
980 accordingly.
981
7555c33f
SM
9822012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
983
984 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
985
986 * alloc.c (mark_object): Revert part of last patch to use `switch'.
987
d12e8f5a
DA
9882012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
989
990 * alloc.c (allocate_vector_block): Remove redundant
991 calls to mallopt if DOUG_LEA_MALLOC is defined.
992 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
993 avoid calls to mallopt if zero_vector is returned.
994
296094c3
DA
9952012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
996
997 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
998 is enabled, avoid dereferencing NULL current_sblock if
999 running undumped.
1000
36429c89
DA
10012012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1002
1003 Cleanup basic buffer management.
1004 * buffer.h (struct buffer): Change layout to use generic vector
1005 marking code. Fix some comments. Change type of 'clip_changed'
1006 to bitfield. Remove unused #ifndef old.
1007 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1008 (GET_OVERLAYS_AT): Fix indentation.
1009 (for_each_per_buffer_object_at): New macro.
1010 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1011 (Fbuffer_local_variables): Use it.
1012 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1013 * alloc.c (allocate_buffer): Adjust to match new layout of
1014 struct buffer. Fix comment.
1015 (mark_overlay): New function.
1016 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1017 Lisp area of struct buffer.
1018 (mark_object): Use it. Adjust marking of misc objects
1019 and related comments.
1020
3b3e4cac
PE
10212012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1022
1023 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1024 wrapper that is not needed because the wrapped code is a no-op (zero
1025 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1026 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1027
cf5c0175
DA
10282012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1029
1030 * alloc.c (mark_buffer): Simplify. Remove prototype.
1031 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1032 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1033 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1034 redundant calls to mark_vectorlike for bool vectors.
1035
ca26824c
GM
10362012-06-30 Glenn Morris <rgm@gnu.org>
1037
2e4c5312
GM
1038 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1039
ca26824c
GM
1040 * epaths.in (PATH_SITELOADSEARCH): New.
1041 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1042 This is rather than relying on --enable-locallisppath elements
1043 having "site-lisp" in their names. (Bug#10208#25, 11658)
1044
0d23c240
EZ
10452012-06-30 Eli Zaretskii <eliz@gnu.org>
1046
c9240d7a
EZ
1047 * w32proc.c (sys_select): Accept and ignore one more argument.
1048
1049 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1050
0d23c240 1051 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1052 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1053
1054 * sysdep.c: Don't include dos.h and dosfns.h.
1055
1056 * process.c (sys_select):
1057 * msdos.c (sys_select): Accept one more argument and ignore it.
1058
1059 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1060 adapt data types and code to that.
1061
1062 * dosfns.c:
1063 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1064 which clashes with the gnulib function of the same name.
1065
af5a5a98
AS
10662012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1067
c5e4379c
AS
1068 * font.c (font_style_to_value, font_style_symbolic)
1069 (font_prop_validate_style): Add type checks for values in
1070 font_style_table.
1071
af5a5a98
AS
1072 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1073 argument.
1074 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1075 uses.
1076
8d38f461
EZ
10772012-06-29 Eli Zaretskii <eliz@gnu.org>
1078
2e5a6631
EZ
1079 * xdisp.c (try_window_id): Undo last change.
1080
8d38f461
EZ
1081 * w32.c (getwd): Adjust commentary about startup_dir.
1082 (init_environment): Always call sys_access, even in non-MSVC
1083 builds. Don't chdir to the directory of the Emacs executable.
1084 This undoes code from 1997 which was justified by the need to
1085 "avoid conflicts when removing and renaming directories". But its
1086 downside was that every relative file name was being interpreted
1087 relative to the directory of the Emacs executable, which can never
1088 be TRT. In particular, it broke sys_access when called with
1089 relative file names.
1090 (sys_access): Map GetLastError to errno.
1091
2af3565e
DA
10922012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1093
1094 * window.h (struct window): Change type of 'fringes_outside_margins'
1095 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1096 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1097 Adjust comment.
1098 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1099 to ptrdiff_t.
1100
c8d3a25c 11012012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1102
c8d3a25c
GM
1103 * gnutls.c (emacs_gnutls_handshake):
1104 Add QUIT to make the loop interruptible.
57570cd3 1105
c8d3a25c 11062012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1107
c8d3a25c
GM
1108 * charset.c (init_charset): Make lack of etc/charsets fatal.
1109
3e984ee8
DA
11102012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1111
1112 * editfns.c (region_limit): Fix type mismatch.
1113
ef884f23
DA
11142012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1115
1116 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1117 undefined. Convert from xassert to eassert.
1118 * nsmenu.m: Convert from xassert to eassert.
1119 * nsterm.m: Likewise.
1120
7d7e0027
SM
11212012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1122
1123 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1124
aa754e6a
PE
11252012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1126
1127 Avoid integer overflow on scroll-left and scroll-right.
1128 * window.c (HSCROLL_MAX): New macro.
1129 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1130 overflow when requested scroll falls outside ptrdiff_t range.
1131
80b00b08
DA
11322012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1133
1134 * window.h (struct window): Change type of 'hscroll',
1135 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1136 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1137 Adjust users accordingly.
1138 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1139 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1140 from EMACS_INT to ptrdiff_t.
1141 (make_window): Omit redundant initialization.
1142
62b2bcf6
JB
11432012-06-28 Juanma Barranquero <lekktu@gmail.com>
1144
1145 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1146
45942c7d
DA
11472012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1148
1149 * window.h (struct window): Change type of 'use_time' and
1150 'sequence_number' from Lisp_Object to int.
1151 * frame.c (make_frame): Adjust users accordingly.
1152 * print.c (print_object): Likewise.
1153 * window.c (select_window, Fwindow_use_time, make_parent_window)
1154 (make_window): Likewise.
1155
e509cfa6
DA
11562012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1157
1158 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1159 enabled with --enable-checking=[all,glyphs] configure option.
1160 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1161 adjust comments accordingly.
1162 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1163 undefined, adjust comments accordingly.
1164 * image.c: Likewise.
1165 * scroll.c: Likewise.
1166 * w32fns.c: Likewise.
1167 * w32term.c: Likewise.
1168 * xdisp.c: Likewise.
1169 * xfaces.c: Likewise.
1170 * xfns.c: Likewise.
1171 * xterm.c: Likewise.
1172
a54e2c05
DA
11732012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1174
1175 Generalize run-time debugging checks.
1176 * dispextern.h (XASSERTS): Remove.
1177 * fontset.c (xassert): Remove.
1178 Convert from xassert to eassert.
1179 * alloc.c: Convert from xassert to eassert.
1180 * bidi.c: Likewise.
1181 * dispnew.c: Likewise.
1182 * fns.c: Likewise.
1183 * fringe.c: Likewise.
1184 * ftfont.c: Likewise.
1185 * gtkutil.c: Likewise.
1186 * image.c: Likewise.
1187 * keyboard.c: Likewise.
1188 * menu.c: Likewise.
1189 * process.c: Likewise.
1190 * scroll.c: Likewise.
1191 * sound.c: Likewise.
1192 * term.c: Likewise.
1193 * w32console.c: Likewise.
1194 * w32fns.c: Likewise.
1195 * w32term.c: Likewise.
1196 * window.c: Likewise.
1197 * xdisp.c: Likewise.
1198 * xfaces.c: Likewise.
1199 * xfns.c: Likewise.
1200 * xselect.c: Likewise.
1201 * xterm.c: Likewise.
1202
1ec4b7b2
SM
12032012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1204
1205 * fns.c (maybe_resize_hash_table): Output message when growing the
1206 purify-hashtable.
1207
2014308a
DA
12082012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1209
1210 * alloc.c (allocate_string_data): Remove dead code.
1211 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1212 avoid GCC warning about unused macro.
1213
246155eb
DA
12142012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1215
1216 * alloc.c (allocate_string): Omit intervals initialization.
1217 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1218 as in make_pure_string and make_pure_c_string.
1219
43184b7b
DA
12202012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1221
d209e2fb 1222 * alloc.c (allocate_string): Fix last change.
43184b7b 1223
3fe6dd74
DA
12242012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1225
d209e2fb 1226 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1227 to memset, add explicit initialization where appropriate.
1228
1ba6038a
GM
12292012-06-27 Glenn Morris <rgm@gnu.org>
1230
1231 * lisp.mk (lisp): Remove paths.elc.
1232
c89926a5
CY
12332012-06-27 Chong Yidong <cyd@gnu.org>
1234
1235 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1236
ed6b3510
JW
12372012-06-26 John Wiegley <johnw@newartisans.com>
1238
1ec4b7b2 1239 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1240 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1241
ed6b3510
JW
1242 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1243 when building with Clang.
1244
8edd4a2b
SM
12452012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1246
1247 * eval.c (Fapply): Allow calling it with a single argument.
1248
f6f62d1b
EZ
12492012-06-26 Eli Zaretskii <eliz@gnu.org>
1250
1251 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1252 _stricmp and _strnicmp.
1253 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1254
62efea5e
DA
12552012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1256
1257 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1258 allocated window.
1259 (allocate_process): Likewise for new process.
8edd4a2b 1260 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1261 (allocate_frame): Likewise.
1262 * frame.c (make_frame): Omit redundant initialization.
1263 * window.c (make_parent_window): Use memset.
1264 (make_window): Omit redundant initialization.
1265 * process.c (make_process): Omit redundant initialization.
1266 * terminal.c (create_terminal): Likewise.
1267
42997f4d
DA
12682012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1269
1270 * term.c (delete_tty): Remove redundant call to memset.
1271
1130ecfc
DA
12722012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1273
1274 * alloc.c: Remove build_string.
1275 * lisp.h: Define build_string as static inline. This provides
1276 a better opportunity to optimize away calls to strlen when the
1277 function is called with compile-time constant argument.
1278 * image.c (imagemagick_error): Convert to build_string.
1279 * w32proc.c (sys_spawnve): Likewise.
1280 * xterm.c (x_term_init): Likewise.
1281
cf38a720
PE
12822012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1283
99027bdd
PE
1284 Use sprintf return value instead of invoking strlen on result.
1285 In the old days this wasn't portable, since some sprintf
1286 implementations returned char *. But they died out years ago and
1287 Emacs already assumes sprintf returns int.
1288 Similarly for float_to_string.
1289 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1290 * ccl.c (ccl_driver):
1291 * character.c (string_escape_byte8):
1292 * data.c (Fnumber_to_string):
1293 * doprnt.c (doprnt):
1294 * print.c (print_object):
1295 * xdisp.c (message_dolog):
1296 * xfns.c (syms_of_xfns):
1297 Use sprintf or float_to_string result to avoid need to call strlen.
1298 * data.c (Fnumber_to_string):
1299 Use make_unibyte_string, since the string must be ASCII.
1300 * lisp.h, print.c (float_to_string): Now returns int length.
1301 * term.c (produce_glyphless_glyph):
1302 Use sprintf result rather than recomputing it.
1303
cf38a720
PE
1304 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1305 * Makefile.in (ALL_CFLAGS):
1306 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1307 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1308
3511c784
DA
13092012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1310
0a08eb21 1311 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1312 strcasecmp if available.
1313 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1314
fb7da12e
AS
13152012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1316
1317 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1318 Avoid comma operator.
1319 * menu.c (push_submenu_start, push_submenu_end)
1320 (push_left_right_boundary, push_menu_pane): Likewise.
1321 * msdos.c (dos_rawgetc): Likewise.
1322
afa2ffd8
DA
13232012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1324
1325 * xfns.c (xic_create_fontsetname): Remove redundant calls
1326 to memset.
1327
b3b4476b
PE
13282012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1329
4495ff38
PE
1330 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1331 sprintf already null-terminates its output.
1332
b3b4476b
PE
1333 * xfns.c (x_window): Remove redundant cast.
1334
b00876c9
DA
13352012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1336
1337 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1338 `const char *' to `char *' to avoid compiler warning.
1339
d188e26b
PE
13402012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1341
885d1d74
PE
1342 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1343 instead of truncating it to 63 (admittedly a generous limit).
1344
d188e26b
PE
1345 * process.c: Fix spelling and caps in comments.
1346
e2f560b1
DN
13472012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1348
e86db54b 1349 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1350 * sysdep.c (setpgrp): Remove definition, not used in this file.
1351
7583a3a1
JB
13522012-06-24 Juanma Barranquero <lekktu@gmail.com>
1353
1354 * makefile.w32-in: Update dependencies.
1355
696056c2
EZ
13562012-06-24 Eli Zaretskii <eliz@gnu.org>
1357
1358 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1359 (SYSTIME_H): Add nt/inc/sys/time.h.
1360
1361 * systime.h [WINDOWSNT]: Include sys/time.h.
1362
1363 * s/ms-w32.h (struct timespec): Definition moved from
1364 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1365
845ca893
PE
13662012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1367
1368 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1369 * buffer.h (buffer_slot_type_mismatch):
1370 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1371 * eval.c (unwind_to_catch):
1372 * image.c (my_png_error, my_error_exit):
1373 * keyboard.c (quit_throw_to_read_char, user_error)
1374 (Fexit_recursive_edit, Fabort_recursive_edit):
1375 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1376 (wrong_type_argument, buffer_overflow, __executable_start)
1377 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1378 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1379 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1380 (fatal):
1381 (child_setup) [!DOS_NT]:
1382 * lread.c (end_of_file_error, invalid_syntax):
1383 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1384 * puresize.h (pure_write_error):
1385 * search.c (matcher_overflow):
1386 * sound.c (sound_perror, alsa_sound_perror):
1387 * sysdep.c, syssignal.h (croak):
1388 * term.c (maybe_fatal, vfatal):
1389 * textprop.c (text_read_only):
1390 * undo.c (user_error):
1391 * unexmacosx.c (unexec_error):
1392 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1393 Use _Noreturn rather than NO_RETURN.
1394 No need for separate decl merely because of _Noreturn.
1395 * sound.c (sound_warning, parse_sound):
1396 Remove unnecessary forward decls.
1397
f1dd8073
PE
13982012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1399
1400 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1401 * lisp.h (WAIT_READING_MAX): New macro.
1402 * dispnew.c (Fsleep_for, sit_for):
1403 * keyboard.c (kbd_buffer_get_event):
1404 * process.c (Faccept_process_output):
1405 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1406 This improves on the previous patch, which introduced a bug
1407 when time_t is unsigned and as wide as intmax_t.
1408 See <http://bugs.gnu.org/9000#51>.
1409
b82c1755
EZ
14102012-06-23 Eli Zaretskii <eliz@gnu.org>
1411
1412 * dispnew.c (sit_for, Fsleep_for):
1413 * keyboard.c (kbd_buffer_get_event):
1414 * process.c (Faccept_process_output): Avoid compiler warnings when
1415 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1416
ca300656
JB
14172012-06-23 Juanma Barranquero <lekktu@gmail.com>
1418
049ec95b
JB
1419 * makefile.w32-in: Update dependencies.
1420
ca300656
JB
1421 * w32.c (ltime): Add return type and declare static.
1422 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1423
db7b8d06
PE
14242012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1425
1426 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1427 Privately reported by Herbert J. Skuhra.
1428 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1429 All uses changed.
1430 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1431 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1432
0bd8297f
EZ
14332012-06-23 Eli Zaretskii <eliz@gnu.org>
1434
96512555
EZ
1435 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1436 last argument of make_unibyte_string.
1437
0bd8297f
EZ
1438 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1439 language ID in the event parameters.
1440
1441 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1442 event.code, not the obscure "character set ID".
1443
63def6b6
CY
14442012-06-23 Chong Yidong <cyd@gnu.org>
1445
1446 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1447
e8a02204
EZ
14482012-06-23 Eli Zaretskii <eliz@gnu.org>
1449
388cdec0
EZ
1450 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1451 * w32.c (fdutimens): New function.
1452
1453 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1454
1455 * s/ms-w32.h (pselect): Redirect to sys_select.
1456
1457 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1458
e8a02204
EZ
1459 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1460 in the logic of incrementing and decrementing the value of
1461 use_relocatable_buffers.
1462
d054f3fb
PE
14632012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1464
1465 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1466 Privately reported by Herbert J. Skuhra.
1467 [__FreeBSD__]: Remove "*/" typo after "#include".
1468 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1469 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1470 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1471 Don't assume EMACS_TIME and struct timeval are the same type.
1472
d35af63c
PE
14732012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1474
1475 Support higher-resolution time stamps (Bug#9000).
1476 The time stamps are only nanosecond-resolution at the C level,
1477 since that's the best that any real-world system supports now.
1478 But they are picosecond-resolution at the Lisp level, as that's
1479 easy, and leaves room for future OS improvements.
1480
1481 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1482 (LIBES): Use it.
1483
1484 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1485 Don't get current time unless it's needed.
1486
1487 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1488 now provides it if it's absent.
1489 (start_atimer): Port to higher-res time stamps.
1490 Check for time stamp overflow. Don't get current time more
1491 often than is needed.
1492
1493 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1494 Include systime.h, not time.h.
1495 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1496
1497 * dired.c: Include stat-time.h.
1498 (Ffile-attributes): File times now have higher resolution.
1499
1500 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1501 (struct image): Timestamp now has higher resolution.
1502
1503 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1504 has at least microseconds now. All uses removed.
1505 (update_frame, update_single_window, update_window, update_frame_1)
1506 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1507
1508 * editfns.c (time_overflow): Now extern.
1509 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1510 (float-time, Fformat_time_string, Fcurrent_time_string)
1511 (Fcurrent_time_zone): Accept and generate higher-resolution
1512 time stamps.
1513 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1514 (decode_time_components, lisp_seconds_argument): New functions.
1515 (make_time): Now static.
1516 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1517 Report an error if the time is invalid, rather than having the caller
1518 do that.
1519
1520 * fileio.c: Include <stat-time.h>
1521 (Fcopy_file): Copy higher-resolution time stamps.
1522 Prefer to set the time stamp via a file descriptor if that works.
1523 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1524 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1525 (Fvisited_file_modtime, Fset_visited_file_modtime):
1526 Support higher-resolution time stamps.
1527
1528 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1529
1530 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1531
1532 * image.c (prepare_image_for_display, clear_image_cache)
1533 (lookup_image): Port to higer-resolution time stamps.
1534
1535 * keyboard.c (start_polling, bind_polling_period):
1536 Check for time stamp overflow.
1537 (read_char, kbd_buffer_get_event, timer_start_idle)
1538 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1539 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1540 Port to higher-resolution time stamps. Do not assume time_t is signed.
1541 (decode_timer): New function. Timers are now vectors of length 9,
1542 not 8, to accommodate the picosecond component.
1543 (timer_check_2): Use it.
1544
1545 * nsterm.m (select_timeout, timeval_subtract): Remove.
1546 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1547 as they're a bit more accurate and handle overflow better.
1548 (ns_select): Change prototype to be compatible with pselect.
1549 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1550 * nsterm.h (ns_select): Adjust prototype.
1551
1552 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1553 us-resolution time stamps.
1554 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1555
1556 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1557
1558 * lisp.h (time_overflow): New decl.
1559 (wait_reading_process_output): First arg is now intmax_t, not int,
1560 to accommodate larger waits.
1561
1562 * process.h (struct Lisp_Process.read_output_delay):
1563 Now counts nanoseconds, not microseconds.
1564 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1565 EMACS_HAS_USECS.
1566 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1567 (wait_reading_process_output):
1568 Port to ns-resolution time stamps.
1569 (Faccept_process_output, wait_reading_process_output):
1570 Check for time stamp overflow. Do not assume time_t is signed.
1571 (select_wrapper): Remove; we now use pselect.
1572 (Fprocess_attributes): Now generates ns-resolution time stamps.
1573
1574 * sysdep.c: Include utimens.h. Don't include utime.h
1575 or worry about struct utimbuf; gnulib does that for us now.
1576 (gettimeofday): Remove; gnulib provides a substitute.
1577 (make_timeval): New function.
1578 (set_file_times): Now sets ns-resolution time stamps.
1579 New arg FD; all uses changed.
1580 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1581 (system_process_attributes):
1582 Now returns ns-resolution time stamp. All uses changed.
1583 Check for time stamp overflow.
1584
1585 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1586 provides a substitute now.
1587
1588 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1589 since it guarantees struct timespec.
1590 (EMACS_TIME): Now struct timespec, so that we can support
1591 ns-resolution time stamps.
1592 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1593 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1594 (EMACS_USECS): Remove.
1595 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1596 so multiply the arg by 1000 before storing it.
1597 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1598 New macros.
1599 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1600 Port to ns-resolution time stamps.
1601 (EMACS_TIME_NEG_P): Remove; replaced by....
1602 (EMACS_TIME_SIGN): New macro.
1603 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1604 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1605 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1606 (make_timeval, make_lisp_time, decode_time_components): New decls.
1607 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1608 that it mishandled time_t overflow. You can't compare by subtracting!
1609 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1610 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1611
1612 * term.c: Include <sys/time.h>.
1613 (timeval_to_Time): New function, for proper overflow wraparound.
1614 (term_mouse_position, term_mouse_click): Use it.
1615
1616 * undo.c (record_first_change): Support higher-resolution time stamps
1617 in the undo buffer.
1618 (Fprimitive_undo): Use them when restoring time stamps.
1619
1620 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1621 (w32_get_internal_run_time):
1622 Port to higher-resolution Emacs time stamps.
1623 (ltime): Now accepts single 64-bit integer, as that's more convenient
1624 for callers.
1625
1626 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1627
1628 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1629 for compatibility with pselect. Support ns-resolution time stamps.
1630
1631 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1632
1633 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1634 Check for time stamp overflow, and support ns-resolution time stamps.
1635
1636 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1637 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1638 (timeval_subtract): Remove; no longer needed.
1639 (XTflash, XTring_bell, x_wait_for_event):
1640 Port to ns-resolution time stamps. Don't assume time_t is signed.
1641
b6a92dfe
CY
16422012-06-22 Chong Yidong <cyd@gnu.org>
1643
1644 * xdisp.c (x_consider_frame_title): Revert last change.
1645
d251c37c
EZ
16462012-06-22 Eli Zaretskii <eliz@gnu.org>
1647
1648 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1649 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1650 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1651 staticidx goes up to 1597 out of 1600 = 0x640.)
1652
f10deafb
PE
16532012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1654
1655 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1656 Otherwise, the umask might be mistakenly 0 while handling input signals.
1657
ec6de1e2
SM
16582012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1659
1660 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1661
28be1ada
DA
16622012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1663
1664 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1665 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1666 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1667 access to `contents' member of Lisp_Vector objects with AREF and ASET
1668 where appropriate.
1669
c6bf3022
CY
16702012-06-19 Chong Yidong <cyd@gnu.org>
1671
1672 * frame.c (delete_frame): When selecting a frame on a different
1673 text terminal, do not alter the terminal's top-frame.
1674
1675 * xdisp.c (format_mode_line_unwind_data): Record the target
1676 frame's selected window and its terminal's top-frame.
1677 (unwind_format_mode_line): Restore them.
1678 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1679 Callers changed.
1680 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1681 since tty frames can be explicitly named.
1682 (prepare_menu_bars): Likewise.
1683
1684 * term.c (Ftty_top_frame): New function.
1685
defd4196
PE
16862012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 Port byte-code-meter to modern targets.
1689 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1690 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1691 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1692 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1693 (METER_1, METER_2): Simplify.
1694
1053a871
SM
16952012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1696
1697 * data.c (Fdefalias): Return `symbol' (bug#11686).
1698
b7e8d081
MR
16992012-06-18 Martin Rudalics <rudalics@gmx.at>
1700
1701 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1702 gets killed during executing of this function (Bug#11665).
1703 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1704 (Vkill_buffer_query_functions): In doc-string say that functions
1705 run by this hook should not change the current buffer.
1706
7ea2b339
PE
17072012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1708
1709 Fix recently-introduced process.c problems found by static checking.
1710 * process.c (write_queue_push, write_queue_pop, send_process):
1711 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1712 (write_queue_pop): Fix pointer signedness problem.
1713 (send_process): Remove unused local.
1714
96a313a1
CY
17152012-06-17 Chong Yidong <cyd@gnu.org>
1716
1717 * xdisp.c (redisplay_internal): No need to redisplay terminal
1718 frames that are not on top.
1719
20ca2e94
TN
17202012-06-17 Troels Nielsen <bn.troels@gmail.com>
1721
1722 * process.c (make_process): Initialize write_queue.
1723 (write_queue_push, write_queue_pop): New functions.
1724 (send_process): Use them to maintain correct ordering of process
1725 writes (Bug#10815).
1726
9a900ca9
PE
17272012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1728
310fbfa8
PE
1729 * lisp.h (eassert): Assume C89 or later.
1730 This removes the need for CHECK.
1731 (CHECK): Remove. Its comments about always evaluating its
1732 argument were confusing, as 'eassert' typically does not evaluate
1733 its argument.
1734
27bb1ca4
PE
1735 * coding.c (produce_chars): Use ptrdiff_t, not int.
1736
9a900ca9
PE
1737 * xterm.c (x_draw_underwave): Check for integer overflow.
1738 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1739
41b7f8bc 17402012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1741
1742 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1743 referenced (Bug#11583).
1744
9b0e3eba
AA
17452012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1746
1747 Implement wave-style variant of underlining.
1748 * dispextern.h (face_underline_type): New enum.
1749 (face): Add field for underline type.
1750 * nsterm.m (ns_draw_underwave): New function.
1751 (ns_draw_text_decoration): Use it.
1752 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1753 New functions.
1754 (x_draw_glyph_string): Use them.
1755 * xfaces.c (Qline, Qwave): New Lisp objects.
1756 (check_lface_attrs, merge_face_ref)
1053a871
SM
1757 (Finternal_set_lisp_face_attribute, realize_x_face):
1758 Handle wave-style underline face attributes.
9b0e3eba
AA
1759 * xterm.c (x_draw_underwave): New function.
1760 (x_draw_glyph_string): Use it.
1761
0fb52f11
JB
17622012-06-16 Juanma Barranquero <lekktu@gmail.com>
1763
1764 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1765 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1766 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1767 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1768 ($(BLD)/w32select.$(O)): Update dependencies.
1769
e5560ff7
AS
17702012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1771
1772 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1773 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1774 * character.c (_fetch_multibyte_char_p): Remove.
1775 * alloc.c: Include "character.h" before "buffer.h".
1776 * bidi.c: Likewise.
1777 * buffer.c: Likewise.
1778 * bytecode.c: Likewise.
1779 * callint.c: Likewise.
1780 * callproc.c: Likewise.
1781 * casefiddle.c: Likewise.
1782 * casetab.c: Likewise.
1783 * category.c: Likewise.
1784 * cmds.c: Likewise.
1785 * coding.c: Likewise.
1786 * composite.c: Likewise.
1787 * dired.c: Likewise.
1788 * dispnew.c: Likewise.
1789 * doc.c: Likewise.
1790 * dosfns.c: Likewise.
1791 * editfns.c: Likewise.
1792 * emacs.c: Likewise.
1793 * fileio.c: Likewise.
1794 * filelock.c: Likewise.
1795 * font.c: Likewise.
1796 * fontset.c: Likewise.
1797 * fringe.c: Likewise.
1798 * indent.c: Likewise.
1799 * insdel.c: Likewise.
1800 * intervals.c: Likewise.
1801 * keyboard.c: Likewise.
1802 * keymap.c: Likewise.
1803 * lread.c: Likewise.
1804 * macros.c: Likewise.
1805 * marker.c: Likewise.
1806 * minibuf.c: Likewise.
1807 * nsfns.m: Likewise.
1808 * nsmenu.m: Likewise.
1809 * print.c: Likewise.
1810 * process.c: Likewise.
1811 * regex.c: Likewise.
1812 * region-cache.c: Likewise.
1813 * search.c: Likewise.
1814 * syntax.c: Likewise.
1815 * term.c: Likewise.
1816 * textprop.c: Likewise.
1817 * undo.c: Likewise.
1818 * unexsol.c: Likewise.
1819 * w16select.c: Likewise.
1820 * w32fns.c: Likewise.
1821 * w32menu.c: Likewise.
1822 * window.c: Likewise.
1823 * xdisp.c: Likewise.
1824 * xfns.c: Likewise.
1825 * xmenu.c: Likewise.
1826 * xml.c: Likewise.
1827 * xselect.c: Likewise.
1828
2f07e6af
EZ
18292012-06-16 Eli Zaretskii <eliz@gnu.org>
1830
1053a871
SM
1831 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1832 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1833 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1834 row.
1835 (handle_face_prop): Use chunk-relative overlay string index when
1836 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1837 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1838 the rightmost. (Bug#11720)
2f07e6af 1839
29b83cec
AS
18402012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1841
1842 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1843 (CATEGORY_MEMBER): Enforce 1/0 value.
1844 * category.c (_temp_category_set): Remove.
1845
4c5501e9
EZ
18462012-06-16 Eli Zaretskii <eliz@gnu.org>
1847
1848 * window.c (Fdelete_other_windows_internal)
1849 (Fdelete_window_internal): Don't access frame's mouse highlight
1850 info of the initial frame. (Bug#11677)
1851
2b570124
PE
18522012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1853
e93864f9
PE
1854 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1855 Assume USE_2_TAGS_FOR_INTS.
1856 (xreload): Adjust $tagmask width to match recent lisp.h change.
1857
2b570124
PE
1858 Simplify lisp.h in minor ways that should not affect code.
1859 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1860 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1861 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1862 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1863 (INTTYPEBITS): New macro, for clarity.
1864 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1865 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1866 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1867 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1868 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1869
81755f69
JB
18702012-06-13 Juanma Barranquero <lekktu@gmail.com>
1871
1872 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1873
16192a57
GM
18742012-06-13 Glenn Morris <rgm@gnu.org>
1875
1876 * s/bsd-common.h (BSD4_3):
1877 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1878
646b5f55
AS
18792012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1880
1881 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1882 instead of union.
1883 (XLI, XIL): Define.
1053a871
SM
1884 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1885 Use them.
1886 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1887 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1888 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1889 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1890 * frame.c (delete_frame): Remove outdated comment.
1891 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1892 USE_LISP_UNION_TYPE.
1893 (Fw32_unregister_hot_key): Likewise.
1894 (Fw32_toggle_lock_key): Likewise.
1895 * w32menu.c (add_menu_item): Likewise.
1896 (w32_menu_display_help): Use XIL instead of checking
1897 USE_LISP_UNION_TYPE.
1898 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1899 (init_heap): Likewise.
1900 * w32term.c (w32_read_socket): Update comment.
1901
1d3823c9
GM
19022012-06-13 Glenn Morris <rgm@gnu.org>
1903
c62ff706
GM
1904 * s/usg5-4-common.h, src/s/unixware.h:
1905 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1906
1d3823c9
GM
1907 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1908
bfe3e0a2
PE
19092012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1910
1911 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1912 * alloc.c (make_number) [!defined make_number]:
1913 Remove, as lisp.h always defines this now.
1914 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1915 (roundup_size): Verify that it is a power of 2.
1916 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1917 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1918 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1919 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1920 USE_LSB_TAG now is always defined to be either 0 or 1.
1921 All uses changed.
1922 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1923 code works fine either way, and efficiency is not a concern here,
1924 as the union type is for debugging, not for production.
1925 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1926 Use an inline function on all platforms when using the union type,
1927 since this is simpler and 'static inline' can be used portably
1928 within Emacs now.
1929 (LISP_INITIALLY_ZERO): New macro.
1930 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1931 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1932
45fa9c0f
GM
19332012-06-12 Glenn Morris <rgm@gnu.org>
1934
b4492cba
GM
1935 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1936
1937 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1938
45fa9c0f
GM
1939 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1940 Move BROKEN_SIGIO to configure.
1941
1942 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1943 Move NO_TERMIO to configure.
1944
0e25d334
CY
19452012-06-12 Chong Yidong <cyd@gnu.org>
1946
1947 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1948 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1949 MagickExportImagePixels is undefined.
1950
43682bb6
PE
19512012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1952
1953 * image.c (imagemagick_load_image): Remove unused label.
1954
a9be7d2b
GM
19552012-06-11 Glenn Morris <rgm@gnu.org>
1956
1957 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1958 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1959 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1960 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1961
3017f87f
SM
19622012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1963
1964 * alloc.c (make_byte_code): New function.
1965 (Fmake_byte_code): Use it. Don't purify here.
1966 * lread.c (read1): Use it as well to avoid extra allocation.
1967
1b9b4cf4
CY
19682012-06-11 Chong Yidong <cyd@gnu.org>
1969
1970 * image.c (imagemagick_load_image): Implement transparency.
1971
95988fcf
AS
19722012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1973
1974 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1975 account for preceding backslashes. (Bug#11663)
1976
cd4eb164
CY
19772012-06-09 Chong Yidong <cyd@gnu.org>
1978
1979 * term.c: Support italics in capable terminals (Bug#9652).
1980 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1981 (turn_on_face): Output using TS_enter_italic_mode if available.
1982 Don't handle unused blinking and alt-charset cases.
1983 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1984 and tty_alt_charset_p cases.
1985 (tty_capable_p, init_tty): Support italics.
1986
1987 * termchar.h (struct tty_display_info): Add field for italics.
1988 Remove unused blink field.
1989
1990 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1991 Handle slant.
1992
1993 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1994 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1995 tty_alt_charset_p. Add tty_italic_p.
1996
ff88beb8
MA
19972012-06-09 Michael Albinus <michael.albinus@gmx.de>
1998
1999 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2000 dbus_type_is_basic if available.
2001 (xd_extract_signed, xd_extract_unsigned): Rename from
2002 extract_signed and extract_unsigned, respectively. Adapt callers.
2003
44286096
CY
20042012-06-09 Chong Yidong <cyd@gnu.org>
2005
1682701f
CY
2006 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2007
44286096
CY
2008 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2009 case (Bug#9752).
2010
d86feb17
PE
20112012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2012
2013 * xdisp.c (vmessage): Treat frame message as multibyte.
2014 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2015 would generate the diagnostic "Making \302\247 buffer-local while
2016 let-bound!".
2017
d5c20fe8
EZ
20182012-06-08 Eli Zaretskii <eliz@gnu.org>
2019
2020 * dispnew.c (showing_window_margins_p): Undo last change, which
2021 was done due to an inadvertent commit.
2022 (adjust_frame_glyphs_for_frame_redisplay): Do call
2023 showing_window_margins_p.
2024
513749ee
SM
20252012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2026
2027 * eval.c (Fmake_var_non_special): New primitive.
2028 (syms_of_eval): Defsubr it.
2029 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2030
d4a8f5c1
JB
20312012-06-08 Juanma Barranquero <lekktu@gmail.com>
2032
2033 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2034 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2035
8bbbc977
EZ
20362012-06-08 Eli Zaretskii <eliz@gnu.org>
2037
2038 * alloc.c (allocate_vectorlike): Fix last change.
2039
f3372c87
DA
20402012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2041
2042 Block-based vector allocation of small vectors.
2043 * lisp.h (struct vectorlike_header): New field `nbytes',
2044 adjust comment accordingly.
2045 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2046 to denote vector blocks. Adjust users (live_vector_p,
2047 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2048 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2049 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2050 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2051 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2052 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2053 (roundup_size): New constant.
2054 (struct vector_block): New data type.
2055 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2056 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2057 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2058 (sweep_vectors): New functions.
2059 (allocate_vectorlike): Return `zero_vector' as the only vector of
2060 0 items. Allocate new vector from block if vector size is less than
2061 or equal to VBLOCK_BYTES_MAX.
2062 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2063 (init_alloc_once): Add call to init_vectors.
2064
4f18a4ed
SM
20652012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2066
2067 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2068
86f158bc
PE
20692012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2070
2071 * doprnt.c (doprnt): Truncate multibyte char correctly.
2072 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2073 would mishandle a string argument "Xc" if X was a multibyte
2074 character of length 2: it would truncate after X's first byte
2075 rather than including all of X.
2076
c5cfcbe0
CY
20772012-06-06 Chong Yidong <cyd@gnu.org>
2078
2079 * buffer.c (word_wrap): Doc fix.
2080
c05cf390
PE
20812012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2082
2083 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2084
0c3461de
GM
20852012-06-03 Glenn Morris <rgm@gnu.org>
2086
2087 * xdisp.c (tool-bar-style): Doc fix.
2088
c71232db
UM
20892012-06-03 Ulrich Müller <ulm@gentoo.org>
2090
2091 * Makefile.in (PAXCTL): Define.
2092 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2093 binary via PaX flags if the paxctl utility is available.
2094 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2095 Restore PaX flags to their default. (Bug#11398)
2096
383f7350
CY
20972012-06-03 Chong Yidong <cyd@gnu.org>
2098
2099 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2100 buffer (Bug#11226).
2101
5f2c76c6
CY
21022012-06-03 Chong Yidong <cyd@gnu.org>
2103
2104 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2105 (note_mode_line_or_margin_highlight): If there is no help echo,
2106 use mode-line-default-help-echo. Handle the case where the mouse
2107 position is past the end of the mode line string.
2108
2109 * buffer.c (buffer_local_value_1): New function, split from
2110 Fbuffer_local_value; can return Qunbound.
2111 (Fbuffer_local_value): Use it.
2112 (Vmode_line_format): Docstring tweaks.
2113
773d47f6
PE
21142012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2115
2116 * sysdep.c (system_process_attributes): Improve comment.
2117
f2d6a3df
SM
21182012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2119
2120 * keyboard.c: Export real-this-command to Elisp.
2121 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2122 and DEFVAR it. Update all users.
2123
63810350
PE
21242012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2125
7bd5c1f4
PE
2126 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2127
63810350
PE
2128 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2129 Convert pctcpu and pctmem to Lisp float properly.
2130 Let the compiler fold better, as 100.0/0x8000 is exact.
2131
a2821611
AS
21322012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2133
2134 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2135 cons_block.
2136
5fceba1d
PE
21372012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2138
2139 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2140
c98ff5dd
DA
21412012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2142
2143 For a 'struct window', replace some Lisp_Object fields to
2144 bitfields where appropriate, remove unused fields.
2145 * window.h (struct window): Remove unused 'last_mark_x' and
2146 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2147 change it's type from Lisp_Object to bitfield.
2148 Change type of 'force_start', 'optional_new_start',
2149 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2150 fields from Lisp_Object to bitfield. Adjust users accordingly.
2151
ca34e0be
PE
21522012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2153
2154 Pacify gcc -Wdouble-precision when using Xaw.
2155 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2156 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2157 Use 'float' consistently, rather than 'float' in most places
2158 and 'double' in a couple of places.
2159
efc00ab1 21602012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2161
2162 * xdisp.c (handle_stop): Detect whether we have overlay strings
2163 loaded by testing it->current.overlay_string_index to be
2164 non-negative, instead of checking whether n_overlay_strings is
2165 positive. (Bug#11587)
2166
efc00ab1 21672012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2168
2169 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2170
2171 * doc.c (Fsubstitute_command_keys): Doc fix.
2172
efc00ab1 21732012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2174
2175 * search.c (search_buffer): Remove calls to
2176 r_alloc_inhibit_buffer_relocation, as it is now called by
2177 maybe_unify_char, which was the cause of relocation of buffer text
2178 in bug#11519.
2179
efc00ab1 21802012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2181
2182 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2183 for the duration of call to load_charset, to avoid problems with
2184 callers of maybe_unify_char that access buffer text through C
2185 pointers.
2186
2187 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2188 decrement the inhibition flag, instead of just setting or
2189 resetting it.
2190
ba93a187
PE
21912012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2192
2193 Remove obsolete '#define static' cruft.
2194 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2195 This #undef was "temporary" in 2000; it is no longer needed
2196 now that '#define static' has gone away.
2197 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2198 (gray_bitmap_bits): Remove; no longer needed.
2199 All uses replaced with definiens.
2200 * xterm.c: Include "bitmaps/gray.xbm".
2201
9e4bf381
PE
22022012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 Clean up __executable_start, monstartup when --enable-profiling.
2205 The following changes affect the code only when profiling.
2206 * dispnew.c (__executable_start): Rename from safe_bcopy.
2207 Define only on platforms that need it.
2208 * emacs.c: Include <sys/gmon.h> when profiling.
2209 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2210 (__executable_start): Remove decl, since lisp.h does it now.
2211 (safe_bcopy): Remove decl; no longer has that name.
2212 (main): Coalesce #if into single bit of code, for simplicity.
2213 Cast pointers to uintptr_t, since standard libraries want integers
2214 and not pointers.
2215 * lisp.h (__executable_start): New decl.
2216
32d72c2f
GM
22172012-05-31 Glenn Morris <rgm@gnu.org>
2218
2219 * image.c (Fimagemagick_types): Doc fix.
2220
baac5bc7
JM
22212012-05-30 Jim Meyering <meyering@redhat.com>
2222
2223 * callproc.c (Fcall_process_region): Include directory component
2224 in mkstemp error message (Bug#11586).
2225
72cb32cf
PE
22262012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2227
2228 * alloc.c, lisp.h (make_pure_vector): Now static.
2229
61b108cc
SM
22302012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2231
2232 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2233 Move to byte-run.el.
2234 (Fautoload): Do the hash-doc more carefully.
2235 * data.c (Fdefalias): Purify definition, except for keymaps.
2236 (Qdefun): Move from eval.c.
2237 * lisp.h (Qdefun): Remove.
2238 * lread.c (read1): Tiny simplification.
2239
471fe23d
TN
22402012-05-29 Troels Nielsen <bn.troels@gmail.com>
2241
934f3f58 2242 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2243 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2244 Bug#9642, but explicitly check that the buffer the overlay would
2245 be moved to is live and rearrange lines to make sure that errors
2246 will not put the overlay in an inconsistent state.
2247 (Fdelete_overlay): Cosmetics.
2248
85d0efd1
EZ
22492012-05-28 Eli Zaretskii <eliz@gnu.org>
2250
2251 * w32term.c (my_bring_window_to_top): New function.
2252 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2253 could be different from the original one.
2254 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2255 (Bug#11513)
2256
2257 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2258 by calling BringWindowToTop.
2259
2260 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2261 (WM_EMACS_END): Increase by one.
2262
da92a98c
PE
22632012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2264
2265 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2266 This avoids undefined behavior that might cause the eassert
2267 to not catch an out-of-range value.
2268
74d1f848
JB
22692012-05-28 Juanma Barranquero <lekktu@gmail.com>
2270
2271 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2272 Update dependencies.
2273
9e1a06fc
EZ
22742012-05-27 Eli Zaretskii <eliz@gnu.org>
2275
2276 * bidi.c (bidi_mirror_char): Fix last change.
2277
f3dd7312
AS
22782012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2279
2280 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2281 when referring to sectname field in printf format.
2282
81899c91
PE
22832012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2284
57b81a9f
PE
2285 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2286 Only r_alloc_inhibit_buffer_relocation needed to be added;
2287 the others were already declared.
2288
81899c91
PE
2289 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2290 before checking whether it's out of range. Put the check inside
2291 eassert. See
2292 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2293
33017faf 22942012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2295
2296 * callproc.c (Fcall_process): Restore a line that was accidentally
2297 commented out in the 2011-02-13 change (bug#11547).
2298
33017faf 22992012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2300
2301 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2302 defined on ralloc.c.
2303
2304 * buffer.c [REL_ALLOC]: Remove prototypes of
2305 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2306 they are now on lisp.h.
2307
2308 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2309
2310 * search.c (search_buffer): Use it to inhibit relocation of buffer
2311 text while re_search_2 is doing its job, because re_search_2 is
2312 passed C pointers to buffer text. (Bug#11519)
2313
23415acf
EZ
2314 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2315 Update value to 24.
2316
44e27368
EZ
2317 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2318 state after an additional call to move_it_in_display_line_to, keep
2319 the values of it->max_ascent and it->max_descent found for the
2320 entire line.
2321 (pos_visible_p): Revert the comparison against bottom_y to what it
2322 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2323 (Bug#11464)
2324
c1892f11
PE
23252012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2326
2327 Fix coding-related core dumps with gcc -ftrapv.
2328 The code was computing A - B, where A and B are pointers, and B is
2329 random garbage. This can lead to core dumps on platforms that
2330 have special pointer registers, and it also leads to core dumps on
2331 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2332 A - B only when B is initialized properly.
2333 * coding.c (coding_set_source, coding_set_destination): Return void.
2334 (coding_change_source, coding_change_destinations): New functions,
2335 with the old behaviors of coding_set_source and coding_set_destination.
2336 All callers that need an offset changed to use these new functions.
2337
eb7afdad
GM
23382012-05-26 Glenn Morris <rgm@gnu.org>
2339
2340 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2341
f12fdf02
EZ
23422012-05-26 Eli Zaretskii <eliz@gnu.org>
2343
53a63be6 2344 Extend mouse support on W32 text-mode console.
61b108cc
SM
2345 * xdisp.c (draw_row_with_mouse_face):
2346 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2347
eb3f6f01 2348 * w32console.c: Include window.h.
61b108cc
SM
2349 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2350 New functions.
eb3f6f01
EZ
2351 (initialize_w32_display): Initialize mouse-highlight data.
2352
53a63be6
EZ
2353 * w32inevt.c: Include termchar.h and window.h.
2354 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2355 moves, call note_mouse_highlight. If help_echo changed, call
2356 gen_help_event to produce help-echo message in the echo area.
2357 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2358 highlight info.
2359
4cfd81f6
PE
23602012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2361
2362 * lread.c (read1): Simplify slightly to avoid an overflow warning
2363 with GCC 4.7.0 on x86-64.
2364
4446092a
EZ
23652012-05-26 Eli Zaretskii <eliz@gnu.org>
2366
2367 * bidi.c (bidi_mirror_char): Revert last change: an int is
2368 definitely wide enough here.
2369
42b2a986 23702012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2371
42b2a986 2372 Fix integer width and related bugs (Bug#9874).
eb106a49 2373 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2374 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2375 (string_bytes, check_sblock, allocate_string_data):
2376 (compact_small_strings, Fmake_bool_vector, make_string)
2377 (make_unibyte_string, make_multibyte_string)
2378 (make_string_from_bytes, make_specified_string)
2379 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2380 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2381 (mark_vectorlike):
2382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2383 (allocate_pseudovector):
2384 Use int, not EMACS_INT, where int is wide enough.
2385 (inhibit_garbage_collection, Fgarbage_collect):
2386 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2387 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2388 int might not be wide enough.
2389 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2390 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2391 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2392 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2393 (bidi_level_of_next_char, bidi_move_to_visually_next):
2394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2395 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2396 (Fkill_buffer, Fset_buffer_major_mode)
2397 (advance_to_char_boundary, Fbuffer_swap_text)
2398 (Fset_buffer_multibyte, overlays_at, overlays_in)
2399 (overlay_touches_p, struct sortvec, record_overlay_string)
2400 (overlay_strings, recenter_overlay_lists)
2401 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2402 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2403 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2404 (Foverlay_recenter, last_overlay_modification_hooks_used)
2405 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2407 (validate_region): Omit unnecessary test for b <= e,
2408 since that's guaranteed by the previous test.
d311d28c
PE
2409 (adjust_overlays_for_delete): Avoid pos + length overflow.
2410 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2411 (report_overlay_modification):
2412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2413 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2414 Omit pointer cast, which isn't needed anyway, and doesn't work
2415 after the EMACS_INT -> ptrdiff_t change.
02481186 2416 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2417 * buffer.h: Adjust decls to match defn changes elsewhere.
2418 (struct buffer_text, struct buffer):
2419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2420 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2421 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2422 not int, to avoid needless 32-bit limit on 64-bit hosts.
2423 (exec_byte_code): Use tighter memory-full test, one that checks
2424 for alloca overflow. Don't compute the address of the object just
2425 before an array, as that's not portable. Use EMACS_INT, not
2426 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2427 * callint.c (Fcall_interactively):
2428 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2429 * callproc.c (call_process_kill, Fcall_process):
2430 Don't assume pid_t fits into an Emacs fixnum.
2431 (call_process_cleanup, Fcall_process, child_setup):
2432 Don't assume pid_t fits into int.
2433 (call_process_cleanup, Fcall_process, delete_temp_file)
2434 (Fcall_process_region):
2435 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2436 (Fcall_process): Simplify handling of volatile integers.
2437 Use int, not EMACS_INT, where int will do.
2438 * casefiddle.c (casify_object, casify_region, operate_on_word)
2439 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2441 (casify_object): Avoid integer overflow when overallocating buffer.
2442 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2443 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2444 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2445 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2446 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2447 integers are now checked earlier. All uses replaced with XINT.
2448 (ccl_driver):
2449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2450 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2451 (ccl_driver, Fregister_code_conversion_map):
2452 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2453 (resolve_symbol_ccl_program): Check that vector header is in range.
2454 Always copy the vector, so that we can check its contents reliably
2455 now rather than having to recheck each instruction as it's being
2456 executed. Check that vector words fit in 'int'.
2457 (ccl_get_compiled_code, Fregister_ccl_program)
2458 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2459 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2460 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2461 contents are in range.
2462 (Fccl_execute_on_string): Check that status is in range.
2463 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2464 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2465 Accept and return EMACS_INT, not int, because callers can pass values
2466 out of 'int' range.
2467 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2468 (multibyte_chars_in_text, parse_str_as_multibyte)
2469 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2470 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2471 (string_escape_byte8, Fget_byte):
2472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2473 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2474 avoid mishandling large integers.
2475 * character.h: Adjust decls to match defn changes elsewhere.
2476 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2477 (Ffind_charset_region):
2478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2479 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2480 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2481 Don't assume fixnum fits in int.
d311d28c
PE
2482 (load_charset_map_from_vector, Fmap_charset_chars):
2483 Remove now-unnecessary CHECK_NATNUMs.
2484 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2485 Don't rely on undefined behavior with signed left shift overflow.
2486 Don't assume unsigned int fits into fixnum, or that fixnum fits
2487 into unsigned int. Don't require max_code to be a valid fixnum;
2488 that's not true for gb10830 4-byte on a 32-bit host. Allow
2489 invalid_code to be a cons, for the same reason. Require code_offset
2490 to be a character. Avoid int overflow if max_char is close
2491 to INT_MAX.
2492 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2493 this is intended anyway and avoids some undefined behavior.
2494 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2495 INDEX_TO_CODE_POINT, as that's what it expects.
2496 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2497 * charset.h (DECODE_CHAR): Return int, not unsigned;
2498 this is what was intended anyway, and it avoids undefined behavior.
2499 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2500 integer-overflow issues.
2501 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2502 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2503 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2504 * chartab.c (Fmake_char_table, Fset_char_table_range)
2505 (uniprop_get_decoder, uniprop_get_encoder):
2506 Don't assume fixnum fits in int.
2507 * cmds.c (move_point): New function, that does the gist of
2508 Fforward_char and Fbackward_char, but does so while checking
2509 for integer overflow more accurately.
c96e5d6a 2510 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2511 (Fforward_line, Fend_of_line, internal_self_insert)
2512 (internal_self_insert):
2513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2514 Fix a FIXME, by checking for integer overflow when calculating
2515 target_clm and actual_clm.
2516 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2517 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2518 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2519 (coding_alloc_by_making_gap, alloc_destination)
2520 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2521 (encode_coding_utf_16, detect_coding_emacs_mule)
2522 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2523 (detect_coding_iso_2022, decode_coding_iso_2022)
2524 (encode_invocation_designation, encode_designation_at_bol)
2525 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2526 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2527 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2528 (encode_coding_ccl, encode_coding_raw_text)
2529 (detect_coding_charset, decode_coding_charset)
2530 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2531 (produce_composition, produce_charset, produce_annotation)
2532 (decode_coding, handle_composition_annotation)
2533 (handle_charset_annotation, consume_chars, decode_coding_gap)
2534 (decode_coding_object, encode_coding_object, detect_coding_system)
2535 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2536 (code_convert_region, code_convert_string)
8f50130c
PE
2537 (Fdefine_coding_system_internal)
2538 (coding_set_source, coding_set_destination):
d311d28c
PE
2539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2540 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2541 (Fdefine_coding_system_internal):
2542 Don't assume fixnums fit in int.
2543 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2544 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2545 (Funencodable_char_position, Fcheck_coding_systems_region)
2546 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2548 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2549 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2550 Don't access memory outside of the args array.
d311d28c 2551 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2552 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2553 result of ENCODE_CHAR.
d311d28c
PE
2554 * coding.h: Adjust decls to match defn changes elsewhere.
2555 (struct coding_system):
2556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2557 * composite.c (get_composition_id, find_composition)
2558 (run_composition_function, update_compositions)
2559 (compose_text, composition_gstring_put_cache)
2560 (composition_gstring_p, composition_gstring_width)
2561 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2562 (composition_compute_stop_pos, composition_reseat_it)
2563 (composition_update_it, struct position_record)
2564 (find_automatic_composition, composition_adjust_point)
2565 (Fcomposition_get_gstring, Ffind_composition_internal):
2566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2567 (update_compositions):
2568 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2569 * composite.h: Adjust decls to match defn changes elsewhere.
2570 (struct composition):
2571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2572 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2573 Do not attempt to compute the address of the object just before a
2574 buffer; this is not portable.
2575 (Faref, Faset):
2576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2577 (Faset): Use int, not EMACS_INT, where int is wide enough.
2578 (Fstring_to_number): Don't assume fixnums fit in int.
2579 (Frem): Don't assume arg is nonnegative.
2580 * dbusbind.c (xd_append_arg): Check for integers out of range.
2581 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2582 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2583 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2584 (xd_get_connection_references): Return ptrdiff_t, not int.
2585 All uses changed.
2586 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2587 (xd_read_message_1):
2588 Use int, not unsigned, where the dbus API uses int.
2589 (Fdbus_message_internal): Don't overflow mtype.
2590 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2591 * dired.c (directory_files_internal, file_name_completion, scmp)
2592 (file_name_completion_stat):
2593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2594 (file_name_completion): Don't overflow matchcount.
2595 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2596 * dispextern.h: Adjust decls to match defn changes elsewhere.
2597 (struct text_pos, struct glyph, struct bidi_saved_info)
2598 (struct bidi_string_data, struct bidi_it, struct composition_it)
2599 (struct it):
2600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2601 (struct display_pos, struct composition_it, struct it):
2602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2603 * dispnew.c (increment_matrix_positions)
2604 (increment_row_positions, mode_line_string)
2605 (marginal_area_string):
2606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2607 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2609 (duration_to_sec_usec): New function, to check for overflow better.
2610 (Fsleep_for, sit_for): Use it.
2611 * doc.c (get_doc_string, store_function_docstring):
2612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2613 (get_doc_string, Fsnarf_documentation):
2614 Use int, not EMACS_INT, where int is wide enough.
2615 (get_doc_string):
2616 Use SAFE_ALLOCA, not alloca.
2617 Check for overflow when converting EMACS_INT to off_t.
2618 * doprnt.c (doprnt):
2619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2620 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2621 Don't assume uid_t fits into fixnum.
2622 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2623 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2624 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2625 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2626 (general_insert_function)
2627 (Finsert_char, make_buffer_string, make_buffer_string_both)
2628 (update_buffer_properties, Fbuffer_substring)
2629 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2630 (Fsubst_char_in_region, check_translation)
2631 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2632 (transpose_markers, Ftranspose_regions):
2633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2634 (clip_to_bounds): Move to lisp.h as an inline function).
2635 (Fconstrain_to_field): Don't assume integers are nonnegative.
2636 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2637 (Fsubst_char_in_region, Fsave_restriction):
2638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2639 (Femacs_pid): Don't assume pid_t fits into fixnum.
2640 (lo_time): Use int, not EMACS_INT, when int suffices.
2641 (lisp_time_argument): Check for usec out of range.
2642 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2643 (Fuser_login_name, Fuser_full_name): Signal an error
2644 if a uid argument is out of range, rather than relying on
2645 undefined behavior.
c8d5c857
PE
2646 (Fformat_time_string): Remove now-unnecessary check.
2647 lisp_time_argument checks for out-of-range usec now.
243e0530 2648 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2649 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2650 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2651 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2652 (init_cmdargs, Fdump_emacs):
2653 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2654 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2655 the bottom (typically) 32 bits of the fixnum.
2656 * eval.c (specpdl_size, call_debugger):
2657 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2658 (when_entered_debugger, Fbacktrace_debug):
2659 Don't assume fixnum can fit in int.
2660 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2661 the object just before a buffer; this is not portable.
2662 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2663 (grow_specpdl, unbind_to):
2664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2665 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2666 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2667 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2668 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2669 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2671 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2672 (a_write, e_write):
2673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2674 (Fcopy_file, non_regular_nbytes, read_non_regular)
2675 (Finsert_file_contents):
2676 Use int, not EMACS_INT, where int is wide enough.
2677 (READ_BUF_SIZE): Verify that it fits in int.
2678 (Finsert_file_contents): Check that counts are in proper range,
2679 rather than assuming fixnums fit into ptrdiff_t etc.
2680 Don't assume fixnums fit into int.
125b3835 2681 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2682 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2683 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2684 (string_char_to_byte, string_byte_to_char)
2685 (string_make_multibyte, string_to_multibyte)
2686 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2687 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2688 (substring_both, Fdelete, internal_equal, Ffillarray)
2689 (Fclear_string, mapcar1)
2690 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2691 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2692 (larger_vector, make_hash_table, maybe_resize_hash_table)
2693 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2694 (Fmaphash, secure_hash):
2695 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2696 (concat): Check for string index and length overflow.
2697 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2698 (Frequire):
2699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2700 (larger_vector): New API (vec, incr_min, size_max) replaces old
2701 one (vec, new_size, init). This catches size overflow.
2702 INIT was removed because it was always Qnil.
2703 All callers changed.
2704 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2705 the upper bound on a hash table index size.
2706 (make_hash_table, maybe_resize_hash_table): Use it.
2707 (secure_hash): Computer start_byte and end_byte only after
2708 they're known to be in ptrdiff_t range.
2709 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2710 (Ffont_get_glyphs, Ffont_at):
2711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2712 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2713 (Flist_fonts, Fopen_font):
2714 Don't assume fixnum can fit in int.
2715 (check_gstring): Don't assume index can fit in int.
2716 (font_match_p): Check that fixnum is a character, not a nonnegative
2717 fixnum, since the later code needs to stuff it into an int.
2718 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2719 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2720 conversion overflow issues.
2721 (Fopen_font): Check for integer out of range.
2722 (Ffont_get_glyphs): Don't assume index can fit in int.
2723 * font.h: Adjust decls to match defn changes elsewhere.
2724 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2725 integer overflow.
2726 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2727 printmax_t, where ptrdiff_t is wide enough.
2728 (Finternal_char_font):
2729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2730 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2731 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2732 (Fset_frame_position, x_set_frame_parameters)
2733 (x_set_line_spacing, x_set_border_width)
2734 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2735 Check that fixnums are in proper range for system types.
2736 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2737 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2738 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2739 Use SAFE_ALLOCA_LISP, not alloca.
2740 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2741 intptr_t is wide enough.
2742 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2743 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2744 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2745 Check for fixnum out of range.
2746 * ftfont.c (ftfont_list): Don't assume index fits in int.
2747 Check that fixnums are in proper range for system types.
2748 (ftfont_shape_by_flt):
2749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2750 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2752 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2753 Check that fixnums are in proper range for system types.
2754 * gnutls.h: Adjust decls to match defn changes elsewhere.
2755 * gtkutil.c (xg_dialog_run):
2756 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2757 (update_frame_tool_bar):
2758 Check that fixnums are in proper range for system types.
2759 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2760 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2761 * indent.c (last_known_column, last_known_column_point):
2762 (current_column_bol_cache):
2763 (skip_invisible, current_column, check_display_width):
2764 (check_display_width, scan_for_column, current_column_1)
2765 (Findent_to, Fcurrent_indentation, position_indentation)
2766 (indented_beyond_p, Fmove_to_column, compute_motion):
2767 (Fcompute_motion, Fvertical_motion):
2768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2769 (last_known_column_modified): Use EMACS_INT, not int.
2770 (check_display_width):
2771 (Fcompute_motion):
2772 Check that fixnums and floats are in proper range for system types.
2773 (compute_motion): Don't assume index or fixnum fits in int.
2774 (compute_motion, Fcompute_motion):
2775 Use int, not EMACS_INT, when it is wide enough.
2776 (vmotion): Omit local var start_hpos that is always 0; that way
2777 we don't need to worry about overflow in expressions involving it.
2778 * indent.h: Adjust decls to match defn changes elsewhere.
2779 (struct position):
2780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2781 Use int, not EMACS_INT, where int is wide enough.
2782 Remove unused members ovstring_chars_done and tab_offset;
2783 all uses removed.
2784 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2785 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2786 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2787 (make_gap, copy_text, insert, insert_and_inherit)
2788 (insert_before_markers, insert_before_markers_and_inherit)
2789 (insert_1, count_combining_before, count_combining_after)
2790 (insert_1_both, insert_from_string)
2791 (insert_from_string_before_markers, insert_from_string_1)
2792 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2793 (adjust_after_replace, adjust_after_insert, replace_range)
2794 (replace_range_2, del_range, del_range_1, del_range_byte)
2795 (del_range_both, del_range_2, modify_region)
2796 (prepare_to_modify_buffer, signal_before_change)
2797 (signal_after_change, Fcombine_after_change_execute):
2798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2799 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2800 (balance_an_interval, split_interval_right, split_interval_left)
2801 (find_interval, next_interval, update_interval)
2802 (adjust_intervals_for_insertion, delete_node, delete_interval)
2803 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2804 (static_offset_intervals, offset_intervals)
2805 (merge_interval_right, merge_interval_left, make_new_interval)
2806 (graft_intervals_into_buffer, temp_set_point_both)
2807 (temp_set_point, set_point, adjust_for_invis_intang)
2808 (set_point_both, move_if_not_intangible, get_property_and_range)
2809 (get_local_map, copy_intervals, copy_intervals_to_string)
2810 (compare_string_intervals, set_intervals_multibyte_1):
2811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2812 * intervals.h: Adjust decls to match defn changes elsewhere.
2813 (struct interval):
2814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2815 * keyboard.c (this_command_key_count, this_single_command_key_start)
2816 (before_command_key_count, before_command_echo_length, echo_now)
2817 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2818 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2819 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2820 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2822 (last_non_minibuf_size, last_point_position, echo_truncate)
2823 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2824 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2825 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2826 (stuff_buffered_input):
2827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2828 (last_auto_save, command_loop_1, read_char):
2829 Use EMACS_INT, not int, to avoid integer overflow.
2830 (record_char): Avoid overflow in total_keys computation.
2831 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2832 * keyboard.h: Adjust decls to match defn changes elsewhere.
2833 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2834 (Fkey_description, Fdescribe_vector, Flookup_key):
2835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2836 (click_position): New function, to check that positions are in range.
2837 (Fcurrent_active_maps):
2838 (describe_command):
2839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2840 (Faccessible_keymaps, Fkey_description):
2841 (preferred_sequence_p):
2842 Don't assume fixnum can fit into int.
2843 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2844 Check for integer overflow in size calculations.
2845 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2846 avoid mishandling large integers.
2847 * lisp.h: Adjust decls to match defn changes elsewhere.
2848 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2849 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2850 (struct Lisp_Marker):
2851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2852 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2853 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2854 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2855 All callers changed.
2856 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2857 Assume the arg has valid form, since it always does.
2858 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2859 unsigned integer system type.
2860 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2861 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2862 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2863 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2864 (duration_to_sec_usec): New decl.
2865 * lread.c (read_from_string_index, read_from_string_index_byte)
2866 (read_from_string_limit, readchar, unreadchar, openp)
2867 (read_internal_start, read1, oblookup):
2868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2869 (Fload, readevalloop, Feval_buffer, Feval_region):
2870 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2871 (openp): Check for out-of-range argument to 'access'.
2872 (read1): Use int, not EMACS_INT, where int is wide enough.
2873 Don't assume fixnum fits into int.
6efdadfd 2874 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2875 (read_filtered_event): Use duration_to_sec_usec
2876 to do proper overflow checking on durations.
d311d28c
PE
2877 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2878 in size calculation.
2879 (Fexecute_kbd_macro):
2880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2881 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2882 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2883 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2884 (set_marker_both, set_marker_restricted_both, marker_position)
2885 (marker_byte_position, Fbuffer_has_markers_at):
2886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2887 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2888 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2889 It now merely ensures that the menu is large enough, without
2890 necessarily growing it, as this avoids some integer overflow issues.
2891 All callers changed.
2892 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2893 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2894 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2895 Use SAFE_ALLOCA_LISP, not alloca.
2896 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2897 to EMACS_INT. Check that fixnums are in proper range for system types.
2898 * minibuf.c (minibuf_prompt_width, string_to_object)
2899 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2900 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2902 (get_minibuffer, read_minibuf_unwind):
2903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2904 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2905 this simplifies overflow checking. All callers changed.
2906 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2907 (Ftest_completion):
2908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2909 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2910 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2911 Check that fixnums are in proper range for system types.
2912 (Fx_create_frame, Fx_show_tip):
2913 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2914 * nsfont.m (ns_findfonts, nsfont_list_family):
2915 Don't assume fixnum fits in long.
2916 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2918 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2919 wide enough.
17fdb222 2920 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2922 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2923 (PRINTDECLARE, PRINTPREPARE):
2924 (strout, print_string):
2925 (print, print_preprocess, print_check_string_charset_prop)
2926 (print_object):
2927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2928 (PRINTDECLARE):
2929 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2931 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2932 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2933 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2934 (print_error_message): Use SAFE_ALLOCA, not alloca.
2935 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2936 (print_depth, new_backquote_output, print_number_index):
2937 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2938 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2939 (Fset_process_window_size, Fformat_network_address)
2940 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2941 (sigchld_handler):
d311d28c 2942 Check that fixnums are in proper range for system types.
d44287d4 2943 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2944 Check for process-ids out of pid_t range rather than relying on
2945 undefined behavior.
e4d81efc 2946 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2947 (Fformat_network_address, read_process_output, send_process)
2948 (Fprocess_send_region, status_notify):
2949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2950 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2951 (wait_reading_process_output, read_process_output, exec_sentinel):
2952 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2953 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2954 (Faccept_process_output): Use duration_to_sec_usec to do proper
2955 overflow checking on durations.
dde14581
PE
2956 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2957 Don't assume pid_t fits in int.
02481186
PE
2958 * process.h (struct Lisp_Process): Members tick and update_tick
2959 are now of type EMACS_INT, not int.
b62b53e8
PE
2960 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2961 configured --with-wide-int.
d311d28c
PE
2962 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2963 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2964 * search.c (looking_at_1, string_match_1):
2965 (fast_string_match, fast_c_string_match_ignore_case)
2966 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2967 (scan_newline, find_before_next_newline, search_command)
2968 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2969 (set_search_regs, wordify):
2970 (Freplace_match):
2971 (Fmatch_data):
2972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2973 (string_match_1, search_buffer, set_search_regs):
2974 (Fmatch_data):
2975 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2976 (wordify): Check for overflow in size calculation.
2977 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2978 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2979 Check that fixnums are in proper range for system types.
2980 * sound.c (struct sound_device)
2981 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2983 (Fplay_sound_internal):
2984 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2985 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2986 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2987 (Fparse_partial_sexp):
2988 Don't assume fixnums can fit in int.
2989 (struct lisp_parse_state, find_start_pos, find_start_value)
2990 (find_start_value_byte, find_start_begv)
2991 (update_syntax_table, char_quoted, dec_bytepos)
2992 (find_defun_start, prev_char_comend_first, back_comment):
2993 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2994 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2996 (Finternal_describe_syntax_value): Check that match_lisp is a
2997 character, not an integer, since the code stuffs it into int.
2998 (scan_words, scan_sexps_forward):
2999 Check that fixnums are in proper range for system types.
3000 (Fforward_word):
3001 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3002 (scan_sexps_forward):
3003 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3004 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3005 * syntax.h: Adjust decls to match defn changes elsewhere.
3006 (struct gl_state_s):
3007 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3008 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3009 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3010 * sysdep.c (wait_for_termination_1, wait_for_termination)
3011 (interruptible_wait_for_termination, mkdir):
3012 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3013 (emacs_read, emacs_write):
3014 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3015 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3016 and double all fit in int.
d311d28c
PE
3017 * term.c (set_tty_color_mode):
3018 Check that fixnums are in proper range for system types.
3019 * termhooks.h (struct input_event):
3020 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3021 * textprop.c (validate_interval_range, interval_of)
3022 (Fadd_text_properties, set_text_properties_1)
3023 (Fremove_text_properties, Fremove_list_of_text_properties)
3024 (Ftext_property_any, Ftext_property_not_all)
3025 (copy_text_properties, text_property_list, extend_property_ranges)
3026 (verify_interval_modification):
3027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3028 (Fnext_single_char_property_change)
3029 (Fprevious_single_char_property_change):
3030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3031 (copy_text_properties):
3032 Check for integer overflow in index calculation.
d311d28c
PE
3033 * undo.c (last_boundary_position, record_point, record_insert)
3034 (record_delete, record_marker_adjustment, record_change)
3035 (record_property_change):
3036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3037 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3038 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3039 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3040 (Fx_hide_tip, Fx_file_dialog):
3041 * w32menu.c (set_frame_menubar):
3042 Use ptrdiff_t, not int, for consistency with rest of code.
3043 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3044 (select_window, Fdelete_other_windows_internal)
3045 (window_scroll_pixel_based, window_scroll_line_based)
3046 (Frecenter, Fset_window_configuration):
3047 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3048 (Fset_window_hscroll, run_window_configuration_change_hook)
3049 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3050 (Fscroll_other_window, Frecenter):
d311d28c
PE
3051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3052 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3053 Don't assume fixnum fits in int.
3054 (Fset_window_scroll_bars):
3055 Check that fixnums are in proper range for system types.
3056 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3057 (string_pos, c_string_pos, number_of_chars, init_iterator)
3058 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3059 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3060 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3061 (face_before_or_after_it_pos, handle_invisible_prop)
3062 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3063 (display_prop_intangible_p, string_buffer_position_lim)
3064 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3065 (get_overlay_strings_1, get_overlay_strings)
3066 (iterate_out_of_display_property, forward_to_next_line_start)
3067 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3068 (get_next_display_element, set_iterator_to_next)
3069 (get_visually_first_element, compute_stop_pos_backwards)
3070 (handle_stop_backwards, next_element_from_buffer)
3071 (move_it_in_display_line_to, move_it_in_display_line)
3072 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3073 (add_to_log, message_dolog, message_log_check_duplicate)
3074 (message2, message2_nolog, message3, message3_nolog
3075 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3076 (current_message_1, truncate_echo_area, truncate_message_1)
3077 (set_message, set_message_1, store_mode_line_noprop)
3078 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3079 (text_outside_line_unchanged_p, check_point_in_composition)
3080 (reconsider_clip_changes)
3081 (redisplay_internal, set_cursor_from_row, try_scrolling)
3082 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3083 (redisplay_window, find_last_unchanged_at_beg_row)
3084 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3085 (trailing_whitespace_p, find_row_edges, display_line)
3086 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3087 (display_mode_element, store_mode_line_string)
3088 (pint2str, pint2hrstr, decode_mode_spec)
3089 (display_count_lines, display_string, draw_glyphs)
3090 (x_produce_glyphs, x_insert_glyphs)
3091 (rows_from_pos_range, mouse_face_from_buffer_pos)
3092 (fast_find_string_pos, mouse_face_from_string_pos)
3093 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3095 (safe_call, init_from_display_pos, handle_fontified_prop)
3096 (handle_single_display_spec, load_overlay_strings)
3097 (with_echo_area_buffer, setup_echo_area_for_printing)
3098 (display_echo_area, echo_area_display)
3099 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3100 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3101 (redisplay_window, dump_glyph_row, display_mode_line)
3102 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3103 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3105 (handle_single_display_spec, build_desired_tool_bar_string)
3106 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3107 (get_specified_cursor_type):
3108 Check that fixnums are in proper range for system types.
3109 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3110 (Flookup_image_map):
3111 Don't assume fixnums fit in int.
3112 (compare_overlay_entries):
3113 Avoid mishandling comparisons due to subtraction overflow.
3114 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3115 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3116 (handle_tool_bar_click):
3117 Use int, not unsigned, since we prefer signed and the signedness
3118 doesn't matter here.
3119 (get_next_display_element, next_element_from_display_vector):
3120 Use int, not EMACS_INT, when int is wide enough.
3121 (start_hourglass): Use duration_to_sec_usec to do proper
3122 overflow checking on durations.
3123 * xfaces.c (Fbitmap_spec_p):
3124 Check that fixnums are in proper range for system types.
3125 (compare_fonts_by_sort_order):
3126 Avoid mishandling comparisons due to subtraction overflow.
3127 (Fx_family_fonts, realize_basic_faces):
3128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3129 (Fx_family_fonts):
3130 Don't assume fixnum fits in int.
3131 Use SAFE_ALLOCA_LISP, not alloca.
3132 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3133 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3134 (face_at_buffer_position, face_for_overlay_string)
3135 (face_at_string_position):
3136 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3137 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3138 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3139 (Fx_show_tip):
3140 Check that fixnums are in proper range for system types.
3141 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3142 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3144 (Fx_change_window_property): Don't assume fixnums fit in int.
3145 * xfont.c (xfont_chars_supported):
3146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3147 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3148 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3149 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3150 * xml.c (parse_region):
3151 * xrdb.c (magic_file_p):
3152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3153 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3154 (x_get_local_selection, x_reply_selection_request)
3155 (x_handle_selection_request, wait_for_property_change):
3156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3157 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3158 short is wide enough.
3159 (x_send_client_event): Don't assume fixnum fits in int.
3160 * xterm.c (x_x_to_emacs_modifiers):
3161 Don't assume EMACS_INT overflows nicely into int.
3162 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3163 may come from Lisp.
3164 (handle_one_xevent): NATNUMP can eval its arg twice.
3165 (x_connection_closed):
3166 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3167 * xterm.h: Adjust decls to match defn changes elsewhere.
3168 (struct scroll_bar): Use struct vectorlike_header
3169 rather than rolling our own approximation.
3170 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3171
c6574eb5
GM
31722012-05-25 Glenn Morris <rgm@gnu.org>
3173
3174 * lisp.mk (lisp): Update for more files being compiled now.
3175
e8d32c7e
SM
31762012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3177
48def666
SM
3178 * lread.c: Remove `read_pure' which makes no difference.
3179 (read_pure): Remove var.
3180 (unreadpure): Remove function.
3181 (readevalloop): Don't call read_list with -1 flag.
3182 (read1, read_vector): Don't test read_pure any more.
3183 (read_list): Simplify.
3184
e8d32c7e
SM
3185 * fileio.c, character.h: Minor style tweaks.
3186
4b2addb7
DA
31872012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3188
3189 * window.h (clip_changed): Remove useless declaration.
3190
584461b2
JB
31912012-05-22 Juanma Barranquero <lekktu@gmail.com>
3192
3193 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3194 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3195
34374650
PE
31962012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3197
3198 Remove src/m/*.
3199 This directory predates autoconf and is no longer needed nowadays.
3200 Move its few remaining bits of functionality to where they're needed.
3201 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3202 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3203 * m/template.h: Remove.
3204 * Makefile.in (M_FILE): Remove. All uses removed.
3205 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3206 * lisp.h (USE_LSB_TAG):
3207 * mem-limits.h (EXCEEDS_LISP_PTR):
3208 Use VAL_MAX, not VALBITS, in #if.
3209 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3210 (EMACS_UINT): Define unconditionally now.
3211 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3212 (BITS_PER_EMACS_INT): New constants, replacing
3213 what used to be in config.h, but not useful in #if.
3214 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3215 define them any more.
3216 (VAL_MAX): New macro.
3217 (VALMASK): Use it.
3218 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3219 BITS_PER_EMACS_INT, in #if.
3220 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3221 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3222 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3223 * s/ms-w32.h (DATA_START):
3224 Move here from removed file m/intel386.h.
3225 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3226 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3227
261cb4bb
PE
32282012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3229
3230 Assume C89 or later.
3231 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3232 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3233 (xrealloc):
3234 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3235 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3236 * textprop.c, tparam.c (NULL): Remove.
3237 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3238 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3239 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3240 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3241 * xterm.c (input_signal_count): Assume volatile works.
3242
ff23cd9f
KB
32432012-05-21 Ken Brown <kbrown@cornell.edu>
3244
3245 * xgselect.c (xg_select): Fix first argument in call to 'select'
3246 (bug#11508).
3247
1b170bc6
KB
32482012-05-20 Ken Brown <kbrown@cornell.edu>
3249
3250 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3251 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3252
b2f4d39f
KB
32532012-05-19 Ken Brown <kbrown@cornell.edu>
3254
3255 * xfns.c (x_in_use): Remove `static' qualifier.
3256 * xterm.h (x_in_use): Declare.
3257 * xgselect.c: Include xterm.h.
3258 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3259 and `display_arg' (bug#9754).
3260
003fdae2
PE
32612012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3262
9232a6d9
PE
3263 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3264
003fdae2
PE
3265 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3266 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3267
784b56e2
EZ
32682012-05-18 Eli Zaretskii <eliz@gnu.org>
3269
3270 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3271
3272 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3273 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3274
3275 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3276 reference to image_cache->refcount.
3277 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3278
a0a79cde
JL
32792012-05-17 Juri Linkov <juri@jurta.org>
3280
3281 * search.c (Fword_search_regexp, Fword_search_backward)
3282 (Fword_search_forward, Fword_search_backward_lax)
3283 (Fword_search_forward_lax): Move functions to isearch.el
3284 (bug#10145, bug#11381).
3285
b0572523
PE
32862012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3287
3288 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3289
9660f5fc
SM
32902012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3291
3292 * lread.c (init_obarray): Declare Qt and Qnil as special.
3293
4374de83
GM
32942012-05-14 Glenn Morris <rgm@gnu.org>
3295
3296 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3297 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3298
dc44c39a
PE
32992012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3300
078c97cb
PE
3301 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3302
dc44c39a
PE
3303 * unexaix.c: Port to more-recent AIX compilers.
3304 (report_error, report_error_1, make_hdr, copy_sym)
3305 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3306 Make arguments const char *, not char *, to avoid violations of C
3307 standard and to fix some AIX warnings reported by Gilles Pion.
3308
e18afed7 33092012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3310
3311 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3312 already have overlays loaded.
3313 (handle_single_display_spec): Before returning without displaying
3314 fringe bitmap, synchronize the bidi iterator with the main display
3315 iterator, by calling iterate_out_of_display_property.
3316 (iterate_out_of_display_property): Detect buffer iteration by
3317 testing that it->string is a Lisp string.
3318 (get_next_display_element): When the current object is exhausted,
3319 and there's something on it->stack, call set_iterator_to_next to
3320 proceed with what's on the stack, instead of returning zero.
3321 (set_iterator_to_next): If called at the end of a Lisp string,
3322 proceed to consider_string_end without incrementing string
3323 position. Don't increment display vector index past the end of
3324 the display vector. (Bug#11417)
c8fb9dc6
EZ
3325 (pos_visible_p): Don't report a position visible when move_it_to
3326 stopped at the last line of window, which happens to be scanned
3327 backwards by the bidi iteration. (Bug#11464)
ac268e67 3328
e18afed7 33292012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3330
3331 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3332 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3333 are on a TTY, and thus unable to display on the fringes.
3334 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3335 so we need to signal to the caller that this is a "replacing"
3336 display spec. This fixes display when the spec is invalid or we
3337 are on a TTY.
3338
e18afed7 33392012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3340
3341 * unexaix.c (make_hdr): Fix typo in prototype.
3342 This bug broke the build on AIX. Problem reported by Gilles Pion.
3343
9d0a235a
MA
33442012-05-14 Michael Albinus <michael.albinus@gmx.de>
3345
3346 * keyboard.c (kbd_buffer_get_event): Read special events also in
3347 batch mode. (Bug#11415)
3348
9e6b06ed
GM
33492012-05-12 Glenn Morris <rgm@gnu.org>
3350
3351 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3352
c1a1d7a3
EZ
33532012-05-12 Eli Zaretskii <eliz@gnu.org>
3354
3355 * lisp.mk (lisp): Add newcomment.elc.
3356
3fe7cdc8
GM
33572012-05-12 Glenn Morris <rgm@gnu.org>
3358
3359 * Makefile.in (MKDIR_P): New, set by configure.
3360 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3361
53f7d2c0
PE
33622012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3363
3364 Remove unused function hourglass_started.
3365 * dispextern.h (hourglass_started):
3366 * w32fns.c (hourglass_started):
3367 * xdisp.c (hourglass_started): Remove.
3368
75aafb17
JB
33692012-05-10 Juanma Barranquero <lekktu@gmail.com>
3370
3371 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3372 Update dependencies.
3373
12959e8e
PE
33742012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3375
97107e2e
PE
3376 * xgselect.c (xg_select): Put maxfds+1 into a var.
3377 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3378
12959e8e
PE
3379 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3380
836d29b3
DA
33812012-05-10 Dave Abrahams <dave@boostpro.com>
3382
3383 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3384 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3385
5cb67954
MA
33862012-05-09 Michael Albinus <michael.albinus@gmx.de>
3387
3388 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3389 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3390 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3391 Initialize xd_registered_buses.
3392
3478ec45
PE
33932012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3394
b263a6b0
PE
3395 Untag more efficiently if USE_LSB_TAG.
3396 This is based on a proposal by YAMAMOTO Mitsuharu in
3397 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3398 For an admittedly artificial (nth 8000 longlist) benchmark on
3399 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3400 Emacs's overall text size by 1%.
3401 * lisp.h (XUNTAG): New macro.
3402 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3403 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3404 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3405 * eval.c (Fautoload):
3406 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3407 * frame.h (XFRAME): Use XUNTAG.
3408
3478ec45
PE
3409 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3410 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3411 Remove unportable assumptions about print widths of types like
3412 dbus_uint32_t.
3413 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3414 intptr_t when converting between pointer and integer, to avoid GCC
3415 warnings about wrong width.
3416
666b903b 34172012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3418
3419 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3420 stack for each reader_thread, instead of defaulting to 8MB
3421 determined by the linker. This avoids failures in creating
3422 subprocesses on Windows 7, see the discussion in this thread:
3423 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3424
b120cc17
JC
34252012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3426
3427 Fix up display of the *Minibuf-0* buffer in the mini window.
3428 * keyboard.c (read_char): Don't clear the echo area if there's no
3429 message to clear.
3430 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3431 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3432
9a4b36f8
MA
34332012-05-07 Michael Albinus <michael.albinus@gmx.de>
3434
3435 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3436 batch mode.
3437
e5f9458f
CY
34382012-05-06 Chong Yidong <cyd@gnu.org>
3439
3440 * lisp.mk (lisp): Update.
3441
eceeb5fc 34422012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3443
3444 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3445
71873e2b
SM
34462012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3447
3448 * data.c (PUT_ERROR): New macro.
3449 (syms_of_data): Use it. Add new error type `user-error'.
3450 * undo.c (user_error): New function.
3451 (Fprimitive_undo): Use it.
3452 * print.c (print_error_message): Adjust print style for `user-error'.
3453 * keyboard.c (user_error): New function.
3454 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3455
ab0fa4e4
PE
34562012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3457
3458 Do not limit current-time-string to years 1000..9999.
3459 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3460 (Fcurrent_time_string): Support any year that is supported by the
3461 underlying localtime representation. Don't use asctime, as it
3462 has undefined behavior for years outside the range -999..9999.
3463
7ed806a7
PE
34642012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3465
3466 Fix race conditions involving setenv, gmtime, localtime, asctime.
3467 Without this fix, interrupts could mess up code that uses these
3468 nonreentrant functions, since setting TZ invalidates existing
3469 tm_zone or tzname values, and since most of these functions return
3470 pointers to static storage.
3471 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3472 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3473 Grow the critical sections to include not just invoking
3474 localtime/gmtime, but also accessing these functions' results
3475 including their tm_zone values if any, and any related TZ setting.
3476 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3477 so that the struct tm is saved in the critical section.
3478 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3479 motivated by the fact that memory allocation needs to be outside
3480 the critical section.
3481
0c16dfed
DA
34822012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3483
3484 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3485 with RESET_INTERVAL.
3486
3487 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3488 Remove duplicated buffer name initialization.
3489
3f83ace8
JM
34902012-05-02 Jim Meyering <jim@meyering.net>
3491
3492 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3493
c7b8541e
JM
3494 * xfns.c (x_window): Use xstrdup (Bug#11375).
3495
90207a15 34962012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3497
3498 * xdisp.c (pos_visible_p): If already at a newline from the
3499 display string before the 'while' loop, don't walk back the glyphs
3500 from it3.glyph_row. Solves assertion violation when the display
3501 string begins with a newline (egg.el). (Bug#11367)
3502
b593d6a9
AH
35032012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3504
3505 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3506 Move to simple.el.
3507
4737362e
GM
35082012-05-01 Glenn Morris <rgm@gnu.org>
3509
99cf43f9
GM
3510 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3511 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3512 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3513 All were removed before 23.1.
3514
9311dcff
GM
3515 * dispnew.c: Remove HAVE_LIBNCURSES test;
3516 it is always true on relevant platforms.
3517
4d5c6349
GM
3518 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3519 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3520
4737362e
GM
3521 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3522
74dd3a6b
AS
35232012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3524
3525 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3526 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3527 Remove.
3528
13c379ee
PE
35292012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3530
3531 Do not avoid creating empty evaporating overlays (Bug#9642).
3532 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3533 That is, do not delete an evaporating overlay if it becomes
3534 empty after its bounds are adjusted to fit within its buffer.
3535 This fix caused other problems, and I'm reverting it until we get
3536 to the bottom of them.
3537
a8e7d6d7 35382012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3539
3540 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3541
a8e7d6d7 35422012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3543
3544 * xdisp.c (pos_visible_p): If the window start position is beyond
3545 ZV, start the display from buffer beginning. Prevents assertion
3546 violation in init_iterator when the minibuffer window is scrolled
3547 via the scroll bar.
3548
3549 * window.c (window_scroll_pixel_based): Likewise.
3550
a8e7d6d7 35512012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3552
3553 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3554
a8e7d6d7 35552012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3556
3557 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3558 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3559
a8e7d6d7 35602012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3561
b593d6a9
AH
3562 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3563 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3564
1c6900d9
EZ
35652012-04-26 Eli Zaretskii <eliz@gnu.org>
3566
4c3fa1d9
EZ
3567 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3568 display element, check also the underlying string or buffer
3569 character. (Bug#11341)
3570
1c6900d9
EZ
3571 * w32menu.c: Include w32heap.h.
3572 (add_menu_item): If the call to AppendMenuW (via
3573 unicode_append_menu) fails, disable Unicode menus only if we are
3574 running on Windows 9X/Me.
3575
42bf8205
AS
35762012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3577
3578 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3579 (xgetint): Add missing shift for LSB tags.
3580
b1bac16e
MR
35812012-04-24 Martin Rudalics <rudalics@gmx.at>
3582
3583 * keyboard.c (read_char): Don't wipe echo area for select window
3584 events: These might get delayed via `mouse-autoselect-window'
3585 (Bug#11304).
3586
d69621cc
JB
35872012-04-24 Juanma Barranquero <lekktu@gmail.com>
3588
3589 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3590 manipulation of :loaded-from data.
3591
02fd101b
JB
35922012-04-23 Juanma Barranquero <lekktu@gmail.com>
3593
3594 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3595 now a cons (bug#11311).
3596
888bec30
PE
35972012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3598
89a438bd
PE
3599 Do not create empty overlays with the evaporate property (Bug#9642).
3600 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3601 if it becomes empty after its bounds are adjusted to fit within
3602 its buffer. Without this fix, in a nonempty buffer (let ((o
3603 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3604 yields an empty overlay that has the evaporate property, which is
3605 not supposed to happen.
3606
1068fe4d
PE
3607 Fix minor GTK3 problems found by static checking.
3608 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3609 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3610 (struct _EmacsFixedClass, emacs_fixed_get_type):
3611 Move decls here from emacsgtkfixed.h, since they needn't be public.
3612 (emacs_fixed_get_type): Now static.
3613 (emacs_fixed_class_init): Omit unused local.
3614 (emacs_fixed_child_type): Remove; unused.
3615 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3616 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3617 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3618 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3619 (EMACS_FIXED_GET_CLASS): Remove; unused.
3620 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3621
888bec30
PE
3622 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3623 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3624
de85e130
PE
36252012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3626
d0baac98 3627 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3628 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3629 (__malloc_size_t, __malloc_ptrdiff_t):
3630 Remove. All uses removed, replaced by the definiens if needed,
3631 since we can assume C89 or better now.
3632 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3633 (protect_malloc_state, align, get_contiguous_space)
3634 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3635 (malloc_atfork_handler_child, malloc_enable_thread)
3636 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3637 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3638 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3639 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3640 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3641 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3642 Define using prototypes, not old style.
3643 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3644 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3645 (align): Don't assume that signed integer overflow wraps around.
3646 Omit unused local var.
3647 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3648 (_free_internal_nolock, memalign, mallochook, reallochook):
3649 Omit no-longer-needed casts.
3650 (valloc): Use getpagesize, not __getpagesize.
3651 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3652 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3653
de85e130
PE
3654 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3655
dcbf5805
MA
36562012-04-22 Michael Albinus <michael.albinus@gmx.de>
3657
3658 Move functions from C to Lisp. Make non-blocking method calls
3659 the default. Implement further D-Bus standard interfaces.
3660
3661 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3662 (QCdbus_request_name_allow_replacement)
3663 (QCdbus_request_name_replace_existing)
3664 (QCdbus_request_name_do_not_queue)
3665 (QCdbus_request_name_reply_primary_owner)
3666 (QCdbus_request_name_reply_in_queue)
3667 (QCdbus_request_name_reply_exists)
3668 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3669 (QCdbus_registered_serial, QCdbus_registered_method)
3670 (QCdbus_registered_signal): New Lisp objects.
3671 (XD_DEBUG_MESSAGE): Use sizeof.
3672 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3673 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3674 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3675 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3676 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3677 (xd_signature, xd_append_arg): Allow float for integer types.
3678 (xd_get_connection_references): New function.
b593d6a9
AH
3679 (xd_get_connection_address): Rename from xd_initialize.
3680 Return cached address.
dcbf5805
MA
3681 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3682 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3683 level.
3684 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3685 Return number of refcounts.
dcbf5805
MA
3686 (Fdbus_get_unique_name): Make stronger parameter check.
3687 (Fdbus_message_internal): New defun.
3688 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3689 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3690 (Fdbus_send_signal, Fdbus_register_service)
3691 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3692 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3693 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3694 (Vdbus_compiled_version, Vdbus_runtime_version)
3695 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3696 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3697 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3698 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3699 Adapt docstring.
dcbf5805 3700
52828e02
PE
37012012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3702
da05bc4c
PE
3703 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3704 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3705 Do not assume ptrdiff_t is the same width as 'int'.
3706
52828e02
PE
3707 * alloc.c: Handle unusual debugging option combinations.
3708 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3709 since the two debugging options are incompatible.
3710 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3711 is defined.
3712 (mem_init, mem_insert, mem_insert_fixup):
3713 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3714 (NEED_MEM_INSERT): Remove; no longer needed.
3715
f01769f9
LL
37162012-04-22 Leo Liu <sdl.web@gmail.com>
3717
3718 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3719
5790543d
PE
37202012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3721
3722 * sysdep.c [__FreeBSD__]: Minor cleanups.
3723 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3724 Use Emacs indenting style more consistently. Avoid some casts.
3725 Use 'double' consistently rather than mixing 'float' and 'double'.
3726
b91b7e4d
EW
37272012-04-21 Eduard Wiebe <usenet@pusto.de>
3728
b593d6a9
AH
3729 * sysdep.c (list_system_processes, system_process_attributes):
3730 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3731
6114eb15
AS
37322012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3733
3734 * lisp.mk (lisp): Update.
3735
2f38dff7
PE
37362012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3737
3738 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3739 It is never used otherwise.
3740
4ae29f89
SM
37412012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3742
3743 * print.c (print_preprocess): Only check print_depth if print-circle
3744 is nil.
3745 (print_object): Check for cycles even when print-circle is nil and
3746 print-gensym is t, but only check print_depth if print-circle is nil.
3747
f30d612a
CY
37482012-04-20 Chong Yidong <cyd@gnu.org>
3749
3750 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3751 set the status to "failed" and ensure that sentinel is run.
3752
c07a4c0b 37532012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3754
3755 * process.c (Fset_process_inherit_coding_system_flag)
3756 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3757 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3758
c07a4c0b 37592012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3760
3761 * xdisp.c (string_buffer_position_lim): Limit starting position to
3762 BEGV.
3763 (set_cursor_from_row): If called for a mode-line or header-line
3764 row, return zero immediately.
3765 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3766 farther than the first row after the header line, if any.
3767 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3768 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3769
c07a4c0b 37702012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3771
4ae29f89
SM
3772 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3773 (bug#11238).
ad3a2b41 3774
c07a4c0b 37752012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 37762012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3777
3778 configure: new option --enable-gcc-warnings (Bug#11207)
3779 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3780 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3781 (ALL_CFLAGS): Use new macros rather than old.
3782 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3783 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3784 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3785 -Wunused-result, -Wunused-variable. This should go away once
3786 the Emacs and Gnulib regex code is merged.
3787 (xmalloc, xrealloc): Now static.
3788
aba027e8
PE
37892012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3790
3791 * dired.c (Fsystem_groups): Remove unused local.
3792
e5a36063
GM
37932012-04-17 Glenn Morris <rgm@gnu.org>
3794
3795 * dired.c (Fsystem_users): Doc fix.
3796
316411f0
DA
37972012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3798
3799 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3800 (syms_of_dired): Add them.
3801
9426aba4
PE
38022012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3803
b62a57be
PE
3804 Fix minor alloc.c problems found by static checking.
3805 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3806 New extern decls, to avoid calling undeclared functions.
3807 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3808 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3809 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3810 (NEED_MEM_INSERT): New macro.
3811 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3812 Remove one incorrect comment and fix another.
b62a57be 3813
3539f31f
PE
3814 Fix minor ralloc.c problems found by static checking.
3815 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3816 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3817 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3818 (r_alloc_sbrk): Now static.
3819
a041960a
PE
3820 Improve ralloc.c interface checking.
3821 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3822 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3823 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3824 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3825 [REL_ALLOC]: ... to here, to check interface.
3826 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3827 Remove decls. This fixes an "It stinks!".
3828
9426aba4
PE
3829 * alloc.c (which_symbols): Fix alignment issue / type clash.
3830
d55c12ed
AS
38312012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3832
3833 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3834 (struct Lisp_Misc_Any): Likewise.
3835 (struct Lisp_Free): Likewise.
3836 * alloc.c (union aligned_Lisp_Symbol): Define.
3837 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3838 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3839 (union aligned_Lisp_Misc): Define.
3840 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3841 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3842 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3843
b948ce8b
PE
38442012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3845
3846 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3847 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3848 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3849 * s/netbsd.h, s/sol2-6.h:
3850 Remove definition of GC_MARK_STACK, since the default now works.
3851 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3852 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3853 no longer the default.
3854 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3855
35dc09a1 38562012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3857
35dc09a1
GM
3858 * lread.c (lisp_file_lexically_bound_p):
3859 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3860
35dc09a1
GM
38612012-04-14 Eli Zaretskii <eliz@gnu.org>
3862
3863 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3864 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3865
38662012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3867
3868 * nsterm.m (constrainFrameRect): Always constrain when there is only
3869 one screen (Bug#10962).
3870
bcd86815
KB
38712012-04-13 Ken Brown <kbrown@cornell.edu>
3872
3873 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3874
c25df26e
RT
38752012-04-13 Reuben Thomas <rrt@sc3d.org>
3876
3877 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3878
0fc59f1e
DC
38792012-04-11 Daniel Colascione <dancol@dancol.org>
3880
3881 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3882 against is gone. It's better to use vfork now so that when Cygwin
3883 gains a new, working vfork, we use it automatically (bug#10398).
3884
de8c03dc
SM
38852012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3886
3887 * window.c (save_window_save): Obey window-point-insertion-type.
3888
2f097256
GM
38892012-04-11 Glenn Morris <rgm@gnu.org>
3890
3891 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3892
453b951e
SM
38932012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3894
3895 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3896
75f1671a 38972012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3898
3899 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3900 (force_quit_count): New var.
3901 (handle_interrupt): Use it.
3902
2a8ce227
JB
39032012-04-10 Juanma Barranquero <lekktu@gmail.com>
3904
3905 * w32.c (w32_delayed_load): Record the full path of the library
3906 being loaded (bug#10424).
3907
935396c0
GM
39082012-04-09 Glenn Morris <rgm@gnu.org>
3909
05920a43
GM
3910 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3911 not just in the obarray, before snarfing them. (Bug#11036)
3912
935396c0
GM
3913 * Makefile.in ($(leimdir)/leim-list.el):
3914 Pass EMACS rather than BUILT_EMACS.
3915
a18ecafa
TZ
39162012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3917
3918 * process.c (make_process):
3919 * process.h: Add integer `gnutls_handshakes_tried' member to
3920 process struct.
3921
6bbef4e5
JC
3922 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3923 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3924
3925 * gnutls.c (gnutls_log_function2i): Convenience log function.
3926 (emacs_gnutls_read): Use new log functions,
3927 `gnutls_handshakes_tried' process member, and
3928 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3929 attempts per process (connection).
3930
b4d3bc10
CY
39312012-04-09 Chong Yidong <cyd@gnu.org>
3932
3933 * eval.c (Fuser_variable_p, user_variable_p_eh)
3934 (lisp_indirect_variable): Functions deleted.
3935 (Fdefvar): Caller changed.
3936
3937 * callint.c (Finteractive, Fcall_interactively):
3938 * minibuf.c (Fread_variable): Callers changed.
3939
70f4d973
EZ
39402012-04-09 Eli Zaretskii <eliz@gnu.org>
3941
3942 * xdisp.c (set_cursor_from_row): If the display string appears in
3943 the buffer at position that is closer to point than the position
3944 after the display string, display the cursor on the first glyph of
3945 the display string. Fixes cursor display when a 'display' text
3946 property immediately follows invisible text. (Bug#11094)
3947
cb3c2e3e
PE
39482012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3949
3950 composite.c: use 'double' consistently
3951 * composite.c (get_composition_id): Use 'double' consistently
3952 instead of converting 'float' to 'double' and vice versa; this is
3953 easier to understand and avoids a GCC warning.
3954
fd06db5d
GM
39552012-04-09 Glenn Morris <rgm@gnu.org>
3956
50fe702a
GM
3957 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3958 preparation for dumping it with emacs. (Bug#4789)
3959 (leimdir): New variable.
3960 ($(leimdir)/leim-list.el): New rule.
3961 (emacs$(EXEEXT)): Depend on leim-list.el.
3962
fd06db5d
GM
3963 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3964 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3965 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3966
55c131ee
AS
39672012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3968
3969 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3970 proper alignment.
3971
9209588f
JB
39722012-04-07 Juanma Barranquero <lekktu@gmail.com>
3973
3974 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3975 Remove unused local variable.
3976
e3fb2efb
PE
39772012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3978
3979 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3980 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3981 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3982 objects, as mark_maybe_pointer will catch them otherwise.
3983 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3984 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3985
b5385551
PE
39862012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 Fix typo that broke non-Windows builds.
3989 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3990
9078ead6
EZ
39912012-04-07 Eli Zaretskii <eliz@gnu.org>
3992
3993 Support building on MS-Windows with libxml2.
3994
3995 * makefile.w32-in (OBJ2): Add xml.$(O).
3996 (GLOBAL_SOURCES): Add xml.c.
3997 ($(BLD)/xml.$(O)): New dependency list.
3998
3999 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4000 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4001 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4002 [!WINDOWSNT]: New macros.
4003 (init_libxml2_functions, libxml2_loaded_p): New functions.
4004 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4005 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4006 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4007 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4008 linked in).
6bbef4e5
JC
4009 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4010 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4011 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4012
4013 * emacs.c: Don't include libxml/parser.h.
4014 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4015 xmlCleanupParser directly.
4016
4017 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4018
3811fdf3
EZ
40192012-04-07 Eli Zaretskii <eliz@gnu.org>
4020
4021 * indent.c (Fvertical_motion): If there is a display string at
4022 point, use it.vpos to compute how many lines to backtrack after
4023 move_it_to point. (Bug#11133)
4024
2f8e16b2
EZ
40252012-04-06 Eli Zaretskii <eliz@gnu.org>
4026
4027 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4028 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4029 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4030 macros related to unification of CJK characters. For the details,
4031 see the discussion following the message here:
4032 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4033
3d439cd1
CY
40342012-04-04 Chong Yidong <cyd@gnu.org>
4035
4036 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4037
8bc53d00
EZ
40382012-04-01 Eli Zaretskii <eliz@gnu.org>
4039
4040 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4041 instead of alloca. (Bug#11138)
4042
3b0512a3
AS
40432012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4044
4045 * w32menu.c (is_simple_dialog): Properly check lisp types.
4046 (Bug#11141)
4047
8427ddd2
EZ
40482012-03-31 Eli Zaretskii <eliz@gnu.org>
4049
979022ef
EZ
4050 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4051 position we get to after a call to move_it_to fails the
4052 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4053 only if we wind up in a string from display property. (Bug#11063)
4054
a6b1c7cc
EZ
4055 * window.c (Fdelete_other_windows_internal): Invalidate the row
4056 and column information about mouse highlight, so that redisplay
4057 restores it after reallocating the glyph matrices. (Bug#7464)
4058
8427ddd2
EZ
4059 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4060 string comes from a `display' text property, use the buffer
4061 position of that property as if we actually saw that position in
4062 the row's glyphs.
697ba24b
EZ
4063 (move_it_by_lines): Remove the assertion that
4064 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4065 violated when there's a before-string at the beginning of a line.
4066 (Bug#11063)
8427ddd2 4067
65a0a738
EZ
40682012-03-30 Eli Zaretskii <eliz@gnu.org>
4069
4070 * xdisp.c (append_space_for_newline): If the default face was
4071 remapped, use the remapped face for the appended newline.
4072 (extend_face_to_end_of_line): Use the remapped default face for
4073 extending the face to the end of the line.
4074 (display_line): Call extend_face_to_end_of_line when the default
4075 face was remapped. (Bug#11068)
4076
581355cc
EZ
40772012-03-29 Eli Zaretskii <eliz@gnu.org>
4078
4079 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4080
e8fc049f
SM
40812012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4082
4083 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4084
4fb9a543
GM
40852012-03-27 Glenn Morris <rgm@gnu.org>
4086
4087 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4088 Doc fixes.
4089
679910f1
KH
40902012-03-26 Kenichi Handa <handa@m17n.org>
4091
4092 * dispextern.h (struct glyph): Fix previous change. Change the
4093 bit length of glyphless.ch to 25 (Bug#11082).
4094
90d49b7f
CY
40952012-03-26 Chong Yidong <cyd@gnu.org>
4096
4097 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4098 (command_loop_1): Use it; inhibit selection update for
4099 handle-select-window too (Bug#8996).
4100
f514f6f0
FP
41012012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4102
e8fc049f 4103 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4104
bf43fa51
KH
41052012-03-25 Kenichi Handa <handa@m17n.org>
4106
4107 * dispextern.h (struct glyph): Change the bit length of
4108 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4109
8a0c01dd
EZ
41102012-03-24 Eli Zaretskii <eliz@gnu.org>
4111
4112 * s/ms-w32.h (tzname): Include time.h before redirecting to
4113 _tzname. Fixes the MSVC build. (Bug#9960)
4114
7d1c3a76
AS
41152012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4116
8ed79523
AS
4117 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4118 characters.
4119
7d1c3a76
AS
4120 * xterm.c (XTread_socket): Only modify handling_signal if
4121 !SYNC_INPUT. (Bug#11080)
4122
e99a9b8b
EZ
41232012-03-23 Eli Zaretskii <eliz@gnu.org>
4124
4125 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4126 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4127 when fetching a multibyte character consumes more bytes than
4128 CHAR_BYTES returns, due to unification of CJK characters in
4129 string_char. (Bug#11073)
4130
5063c0e1
TN
41312012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4132
4133 * process.c (wait_reading_process_output): Handle pty disconnect
4134 by refraining from sending oneself a SIGCHLD (bug#10933).
4135
9f851fbd
CY
41362012-03-22 Chong Yidong <cyd@gnu.org>
4137
4138 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4139
5063c0e1 4140 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4141 Mark string as coming from a prefix property.
4142 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4143 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4144
fb5b8aca
CY
41452012-03-21 Chong Yidong <cyd@gnu.org>
4146
4147 * xfaces.c (Vface_remapping_alist): Doc fix.
4148
62356a1b
EZ
41492012-03-20 Eli Zaretskii <eliz@gnu.org>
4150
4151 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4152 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4153 Doc fixes.
62356a1b 4154
025de85b
CY
41552012-03-20 Chong Yidong <cyd@gnu.org>
4156
4157 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4158 to reflect default non-nil value of redisplay-dont-pause.
4159
4827f94e
KH
41602012-03-19 Kenichi Handa <handa@m17n.org>
4161
4162 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4163 it fit in a valid range (Bug#11003).
4164
e50a24a2
EZ
41652012-03-18 Eli Zaretskii <eliz@gnu.org>
4166
4167 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4168 that is not from display property, accept the row as a "cursor
4169 row" if one of the string's character has a non-nil `cursor'
4170 property. Fixes cursor positioning when there are newlines in
4171 overlay strings, e.g. in icomplete.el. (Bug#11035)
4172
9af5ed87
PE
41732012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4174
4175 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4176
d1f55f16
CY
41772012-03-12 Chong Yidong <cyd@gnu.org>
4178
4179 * eval.c (inhibit_lisp_code): Rename from
4180 inhibit_window_configuration_change_hook; move from window.c.
4181
4182 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4183 * window.c (run_window_configuration_change_hook)
4184 (syms_of_window): Callers changed.
4185
66c5eebd
CY
41862012-03-11 Chong Yidong <cyd@gnu.org>
4187
413df973
CY
4188 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4189
66c5eebd
CY
4190 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4191
1de11f56
CY
41922012-03-10 Chong Yidong <cyd@gnu.org>
4193
4194 * frame.c (other_visible_frames): Don't assume the selected frame
4195 is visible (Bug#10955).
4196
cae07000
SM
41972012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4198
4199 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4200
89c94350
JD
42012012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4202
4203 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4204 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4205 zero (Bug#10954).
4206
999dd333
GM
42072012-03-03 Glenn Morris <rgm@gnu.org>
4208
01a6dcc8 4209 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4210
de0100f2
EZ
42112012-03-02 Eli Zaretskii <eliz@gnu.org>
4212
4213 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4214 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4215 (redisplay_window, next_element_from_string): Fix typos in
4216 comments.
3e441275
EZ
4217 (redisplay_window): Pass to move_it_vertically the margin in
4218 pixels, not in screen lines.
de0100f2 4219
96a72ee9
GM
42202012-03-02 Glenn Morris <rgm@gnu.org>
4221
4222 * buffer.c (buffer-list-update-hook): Doc fix.
4223
312508d7
EZ
42242012-02-29 Eli Zaretskii <eliz@gnu.org>
4225
4226 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4227 push_it before setting up the iterator for the first overlay
4228 string, even if we have an empty string loaded.
4229 (next_overlay_string): If there's an empty string on the iterator
4230 stack, pop the stack. (Bug#10903)
4231
27f3c637
PE
42322012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4233
4234 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4235 Suggested by Stefan Monnier in
4236 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4237 * alloc.c (widen_to_Lisp_Object): New static function.
4238 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4239 and widening them to Lisp_Objects. This would work even if
4240 USE_LSB_TAG is defined and wide integers are used, which might
4241 happen in a future version of Emacs.
4242
3c9dfce6
CY
42432012-02-25 Chong Yidong <cyd@gnu.org>
4244
fa74b241
CY
4245 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4246 Doc fix.
4247
3c9dfce6
CY
4248 * xselect.c (Fx_selection_exists_p): Doc fix.
4249 (x_clipboard_manager_save_all): Print an informative message
4250 before saving to clipboard manager.
4251
9486df08
CY
42522012-02-24 Chong Yidong <cyd@gnu.org>
4253
4254 * keyboard.c (process_special_events): Handle all X selection
4255 requests in kbd_buffer, not just the next one (Bug#8869).
4256
f01d3321
CY
42572012-02-23 Chong Yidong <cyd@gnu.org>
4258
4259 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4260 call when setting menu-bar-lines and tool-bar-lines parameters.
4261 (unwind_create_frame_1): New helper function.
4262
4263 * window.c (inhibit_window_configuration_change_hook): New var.
4264 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4265 (syms_of_window): Initialize it.
f01d3321 4266
86b847b6
CY
42672012-02-22 Chong Yidong <cyd@gnu.org>
4268
4269 * xterm.c (x_draw_image_relief): Add missing type check for
4270 Vtool_bar_button_margin (Bug#10743).
4271
a59225b1
CY
42722012-02-21 Chong Yidong <cyd@gnu.org>
4273
4274 * fileio.c (Vfile_name_handler_alist): Doc fix.
4275
4276 * buffer.c (Fget_file_buffer): Protect against invalid file
4277 handler return value.
4278
310f5bd4
PE
42792012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4280
cb3a28cc
PE
4281 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4282 when computing $valmask.
4283
310f5bd4
PE
4284 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4285 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4286 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4287 It's useless in that case, and it can cause problems on hosts
4288 that allocate halves of EMACS_INT values separately.
4289 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4290 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4291 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4292 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4293 it avoids undefined behavior on hosts where shifting right by more
4294 than the word width has undefined behavior.
4295
2375c96a
CY
42962012-02-19 Chong Yidong <cyd@gnu.org>
4297
4298 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4299 (Funhandled_file_name_directory, Ffile_name_as_directory)
4300 (Fdirectory_file_name, Fexpand_file_name)
4301 (Fsubstitute_in_file_name): Protect against invalid file handler
4302 return values (Bug#10845).
4303
3eb49e71
EZ
43042012-02-18 Eli Zaretskii <eliz@gnu.org>
4305
4306 * .gdbinit (pitx): Fix incorrect references to fields of the
4307 iterator stack.
4308
7b926f3f
CY
43092012-02-17 Chong Yidong <cyd@gnu.org>
4310
4311 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4312
11273115
PE
43132012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4314
4315 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4316 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4317
c3a70e2b
CY
43182012-02-15 Chong Yidong <cyd@gnu.org>
4319
4320 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4321 marked as special. Also, starting docstrings with * is obsolete.
4322
0ca43699
AS
43232012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4324
4325 * gnutls.c (emacs_gnutls_write): Fix last change.
4326
2e8f3c56
LI
43272012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4328
4329 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4330 send_process.
4331
af70074f
SM
43322012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4333
4334 * keymap.c (Fsingle_key_description): Handle char ranges.
4335
95986d52
CY
43362012-02-12 Chong Yidong <cyd@gnu.org>
4337
afd83bd1
CY
4338 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4339 as that creates a dangerous corner case.
4340
95986d52
CY
4341 * window.c (Fdelete_window_internal): Invalidate the mouse
4342 highlight (Bug#9904).
4343
bd7da63e
GM
43442012-02-12 Glenn Morris <rgm@gnu.org>
4345
4346 * xselect.c (Fx_own_selection_internal)
4347 (Fx_get_selection_internal, Fx_disown_selection_internal)
4348 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4349 * nsselect.m (Fx_own_selection_internal)
4350 (Fx_disown_selection_internal, Fx_selection_exists_p)
4351 (Fx_selection_owner_p, Fx_get_selection_internal):
4352 Sync docs and argument specs with the xselect.c versions.
4353
77abcbc2
LI
43542012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4355
4356 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4357
90b671e2
EZ
43582012-02-11 Eli Zaretskii <eliz@gnu.org>
4359
1c0ca0b7
EZ
4360 * w32select.c (Fx_selection_exists_p): Sync doc string and
4361 argument list with xselect.c. (Bug#10783)
4362
4363 * w16select.c (Fx_selection_exists_p): Sync doc string and
4364 argument list with xselect.c. (Bug#10783)
90b671e2 4365
49241268
GM
43662012-02-10 Glenn Morris <rgm@gnu.org>
4367
4368 * fns.c (Fsecure_hash): Doc fix.
4369
f998bbe7 43702012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4371
4372 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4373
0992bd9c
CY
43742012-02-07 Chong Yidong <cyd@gnu.org>
4375
4376 * buffer.c (Fbuffer_local_variables)
4377 (buffer_lisp_local_variables): Handle unbound vars correctly;
4378 don't let Qunbound leak into Lisp.
4379
af008560
GM
43802012-02-07 Glenn Morris <rgm@gnu.org>
4381
dd605cc4
GM
4382 * image.c (Fimagemagick_types): Doc fix.
4383
af008560
GM
4384 * image.c (imagemagick-render-type): Change it from a lisp object
4385 to an integer. Move the doc here from the lisp manual.
4386 Treat all values not equal to 0 the same.
4387
1449fa1d
CY
43882012-02-06 Chong Yidong <cyd@gnu.org>
4389
4390 * doc.c (store_function_docstring): Avoid applying docstring of
4391 alias to base function (Bug#2603).
4392
3723ec07
AS
43932012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4394
4395 * .gdbinit (pp1, pv1): Remove redundant defines.
4396 (pr): Use pp.
4397
79c1cc1e
CY
43982012-02-04 Chong Yidong <cyd@gnu.org>
4399
4400 * nsterm.m: Declare a global (Bug#10694).
4401
d7f29f8e
EZ
44022012-02-04 Eli Zaretskii <eliz@gnu.org>
4403
cae07000
SM
4404 * w32.c (get_emacs_configuration_options):
4405 Include --enable-checking, if specified, in the return value.
d7f29f8e 4406
3b95a6f9
MR
44072012-02-04 Martin Rudalics <rudalics@gmx.at>
4408
4409 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4410 after rounding frame sizes. (Bug#9723)
4411
d6fa96a6
EZ
44122012-02-04 Eli Zaretskii <eliz@gnu.org>
4413
4414 * keyboard.c (adjust_point_for_property): Don't position point
4415 before BEGV. (Bug#10696)
4416
df0b2940
PE
44172012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4418
4419 Handle overflow when computing char display width (Bug#9496).
4420 * character.c (char_width): Return EMACS_INT, not int.
4421 (char_width, c_string_width): Check for overflow when
4422 computing the width; this is possible now that individual
4423 characters can have unbounded width. Problem introduced
4424 by merge from Emacs 23 on 2012-01-19.
4425
6bee44d6
MA
44262012-02-02 Michael Albinus <michael.albinus@gmx.de>
4427
4428 * dbusbind.c (Fdbus_register_method): Mention the return value
4429 :ignore in the docstring.
4430
44f92739
GM
44312012-02-02 Glenn Morris <rgm@gnu.org>
4432
1b9f60cc
GM
4433 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4434
44f92739
GM
4435 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4436 Unconditionally set to t. (Bug#10673)
4437 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4438 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4439 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4440
c5d3843c
KH
44412012-02-02 Kenichi Handa <handa@m17n.org>
4442
4443 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4444 0, do not call append_composite_glyph.
4445
159462d4 44462012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4447
4448 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4449 NULL (Bug#6988).
4450 (x_produce_glyphs): If the component of a composition is a null
4451 string, set it->pixel_width to 1 to avoid zero-width glyph.
4452
78cef877
EZ
44532012-02-01 Eli Zaretskii <eliz@gnu.org>
4454
4455 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4456 first 2 arguments are identical. This makes inserting large
4457 output from a subprocess an order of magnitude faster on
4458 MS-Windows, where all sbrk'ed memory is always contiguous.
4459
97897668
GM
44602012-01-31 Glenn Morris <rgm@gnu.org>
4461
4462 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4463 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4464 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4465
31fd3586
GM
44662012-01-29 Glenn Morris <rgm@gnu.org>
4467
4468 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4469
0e24a8b2
CY
44702012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4471
4472 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4473
cc0adcb0
CY
44742012-01-28 Chong Yidong <cyd@gnu.org>
4475
4476 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4477
acc28cb9
CY
44782012-01-26 Chong Yidong <cyd@gnu.org>
4479
9c69cfb7
CY
4480 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4481
acc28cb9
CY
4482 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4483 repeat counts (Bug#10507).
4484
48da7392
GM
44852012-01-26 Glenn Morris <rgm@gnu.org>
4486
4487 * lread.c (syms_of_lread): Doc fix.
4488
14af5f7f
CY
44892012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4490
4491 * coding.c (encode_designation_at_bol): Change return value to
4492 EMACS_INT.
4493
0b21c100
CY
44942012-01-25 Chong Yidong <cyd@gnu.org>
4495
4496 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4497
3c2907f7
CY
44982012-01-21 Chong Yidong <cyd@gnu.org>
4499
4500 * floatfns.c (Fcopysign): Make the second argument non-optional,
4501 since nil is not allowed anyway.
4502
959ad23f
AS
45032012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4504
4505 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4506 (send_process): Likewise.
4507
34a02f46
MR
45082012-01-19 Martin Rudalics <rudalics@gmx.at>
4509
4510 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4511 (Vwindow_persistent_parameters): Do not use Qstate.
4512 Rewrite doc-strings.
34a02f46 4513
1259009a 45142012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4515
4516 * character.c (char_width): New function.
70d4fdf6
GM
4517 (Fchar_width, c_string_width, lisp_string_width):
4518 Use char_width (Bug#9496).
25ed9e61 4519
6a6ee00d
MR
45202012-01-16 Martin Rudalics <rudalics@gmx.at>
4521
4522 * window.c (Vwindow_persistent_parameters): New variable.
4523 (Fset_window_configuration, save_window_save): Handle persistent
4524 window parameters.
4525
c85efaf7
EZ
45262012-01-14 Eli Zaretskii <eliz@gnu.org>
4527
4528 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4529 thrashing the stack of the thread. (Bug#9087)
4530
5944709e
PE
45312012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4532
4533 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4534
e71f5d99
EZ
45352012-01-11 Eli Zaretskii <eliz@gnu.org>
4536
4537 * xdisp.c (rows_from_pos_range): Handle the case where the
4538 highlight ends on a newline. (Bug#10464)
4539 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4540 he end column for display of highlight that ends on a newline
4541 before a R2L line.
4542
ce316182
GM
45432012-01-11 Glenn Morris <rgm@gnu.org>
4544
4545 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4546 from load-path also when installation-directory is nil. (Bug#10208)
4547
5b43da69
GM
45482012-01-10 Glenn Morris <rgm@gnu.org>
4549
74cc8ff9
GM
4550 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4551
7d8d6e4e
GM
4552 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4553 Update template values to be closer to their typical values these days.
5b43da69 4554
a0db8d43
EZ
45552012-01-09 Eli Zaretskii <eliz@gnu.org>
4556
4557 * xdisp.c (rows_from_pos_range): Accept additional argument
4558 DISP_STRING, and accept any glyph in a row whose object is that
4559 string as eligible for mouse highlight. Fixes mouse highlight of
4560 display strings from overlays. (Bug#10464)
4561
9a0115ab 45622012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4563
b9110d6a 4564 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4565 * fileio.c (auto_saving_dir_umask): New static var.
4566 (Fmake_directory_internal): Use it.
4567 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4568 creating the directory. The old code temporarily assigns
4569 too-generous permissions to the directory.
4570 (do_auto_save_eh): Clear it.
b9110d6a 4571 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4572 that the var is always cleared.
4573
6c1bd3f3
EZ
45742012-01-07 Eli Zaretskii <eliz@gnu.org>
4575
4576 * search.c (scan_buffer): Pass character positions to
4577 know_region_cache, not byte positions. (Bug#6540)
4578
069d2b50
L
45792012-01-07 LynX <_LynX@bk.ru> (tiny change)
4580
4581 * w32.c (sys_rename): Report EXDEV when rename of a directory
4582 fails because the target is on another logical disk. (Bug#10284)
4583
75bf0d33
DB
45842012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4585
4586 * xterm.c (x_embed_request_focus): New function.
4587
4588 * xterm.h: Add prototype.
4589
4590 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4591
1c6e5a32
GM
45922012-01-05 Glenn Morris <rgm@gnu.org>
4593
4594 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4595
651e947e
EZ
45962012-01-01 Eli Zaretskii <eliz@gnu.org>
4597
4598 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4599 Load gnutls_transport_set_lowat only if GnuTLS version is below
4600 2.11.1.
4601 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4602 GnuTLS versions below 2.11.1.
4603
3778cdd8
AL
46042011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4605
4606 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4607 to the doc string advising against its use for altering the way
4608 windows are scrolled.
4609
0e5317f7
KH
46102011-12-28 Kenichi Handa <handa@m17n.org>
4611
4612 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4613 coding-system ASCII compatible only when it does not produce BOM
4614 on encoding (Bug#10383).
4615
93d5ca1f
JD
46162011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4617
4618 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4619 can scroll.
4620 (create_and_show_popup_menu): Always use menu_position_func for
4621 Gtk3 (Bug#10361).
4622
ca22b785
AS
46232011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4624
4625 * callint.c (Fcall_interactively): Don't truncate prompt string.
4626
d048e1e6
EZ
46272011-12-23 Eli Zaretskii <eliz@gnu.org>
4628
4629 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4630 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4631 resumed from there (after widening). (Bug#10360)
d048e1e6 4632
5ccaba1f
JD
46332011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4634
4635 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4636
204ee57f
JD
46372011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4638
b81d40f0
JB
4639 * nsterm.m (x_free_frame_resources):
4640 Release f->output_data.ns->miniimage.
204ee57f
JD
4641 (ns_index_color): Fix indentation. Do not retain
4642 color_table->colors[i].
4643
4644 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4645 before returning.
4646
4647 * nsfns.m (x_set_background_color): Assign return value from
4648 ns_index_color to face-background instead of NSColor*.
4649 (ns_implicitly_set_icon_type): Fix indentation.
4650 Change assignment in for loop to comparison.
4651
4652 * emacs.c (ns_pool): New variable.
4653 (main): Assign ns_pool.
4654 (Fkill_emacs): Call ns_release_autorelease_pool.
4655
4656 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4657 autorelease fdesc, release fdAttrs and tdict.
4658 (ns_get_covering_families): Release charset.
4659 (ns_findfonts): Release NSFontDescriptor created with new.
4660 (ns_uni_to_glyphs): Fix indentation.
4661 (setString): Release attrStr before assigning new value.
4662
c803b2b7
JD
46632011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4664
678f4426
JD
4665 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4666 and NS_IMPL_COCOA.
4667 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4668 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4669
cd394be1 46702011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4671
5fecd5fc
JD
4672 * nsterm.m (ns_term_init): Subscribe for notifications
4673 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4674 to method trackingNotification in EmacsMenu.
4675
4676 * nsmenu.m (trackingMenu): New variable.
3771cb17 4677 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4678 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4679 from Aquamacs (Bug#7030).
678f4426
JD
4680
46812011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4682
c803b2b7
JD
4683 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4684 (symbol_to_nsstring): Fix indentation.
4685 (ns_symbol_to_pb): New function.
cae07000
SM
4686 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4687 (Fns_rotate_cut_buffers_internal): Remove.
4688 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4689 Fns_store_cut_buffer_internal.
4690 (ns_get_foreign_selection, Fx_own_selection_internal)
4691 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4692 (Fns_get_selection_internal, Fns_store_selection_internal):
4693 Use ns_symbol_to_pb and check if return value is nil.
4694 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4695 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4696 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4697 renamed to Sns_store_selection_internal.
4698 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4699 and remove this function.
4700 (ns_handle_selection_clear): Remove, never used.
4701 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4702 here.
4703
e1b01a3a
KB
47042011-12-17 Ken Brown <kbrown@cornell.edu>
4705
4706 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4707 GID is unknown (Bug#10257).
4708
2adb6e85
PE
47092011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4710
4711 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4712 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4713 which caused a build failure on GNU/Linux IA-64. This problem was
4714 introduced by my 2011-10-07 patch.
4715
d1d7b339
JL
47162011-12-15 Juri Linkov <juri@jurta.org>
4717
4718 * image.c (imagemagick_error): New function. (Bug#10112)
4719 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4720 Use `imagemagick_error' where ImageMagick functions return
4721 `MagickFalse'.
4722 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4723 proper order.
4724
100d5755
KH
47252011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4726
4727 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4728 fill background (Bug#8992).
4729
454592a6
MR
47302011-12-13 Martin Rudalics <rudalics@gmx.at>
4731
4732 * window.c (Vwindow_combination_resize)
4733 (Vwindow_combination_limit): Use t instead of non-nil in
4734 doc-strings.
61d4b438
MR
4735 (Vrecenter_redisplay): Add first sentence of doc-string on
4736 separate line.
53524d93 4737 (Frecenter): Fix doc-string typo.
454592a6 4738
3633e3aa
KH
47392011-12-11 Kenichi Handa <handa@m17n.org>
4740
4741 * coding.c (Funencodable_char_position): Pay attention to the
4742 buffer text relocation (Bug#9389).
4743
7b9d523a 47442011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4745
7b9d523a
JD
4746 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4747 gtk_init (Bug#10100).
4748
b73189c6
EZ
47492011-12-10 Eli Zaretskii <eliz@gnu.org>
4750
4751 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4752 IT->string is nil. (Bug#10263)
4753
f7dfe5d6
JD
47542011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4755
83faebb4
JD
4756 * nsterm.h (x_free_frame_resources): Declare.
4757
f7dfe5d6
JD
4758 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4759 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4760
4761 * nsterm.h (ns_get_defaults_value): Declare.
4762
4763 * nsterm.m (ns_default): Call ns_get_defaults_value.
4764
7cd4e72c
EZ
47652011-12-09 Eli Zaretskii <eliz@gnu.org>
4766
4767 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4768 (Bug#10170)
4769
b34d7317
YM
47702011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4771
4772 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4773 that where the value of an _OBJC_* symbol points to is in the .bss
4774 section (Bug#10240).
4775
76470ad1
KH
47762011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4777
4778 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4779 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4780
745fff94
KH
47812011-12-08 Kenichi Handa <handa@m17n.org>
4782
4783 * ftfont.c (get_adstyle_property): Fix previous change
4784 (Bug#10233).
4785
6e44397c
JB
47862011-12-07 Juanma Barranquero <lekktu@gmail.com>
4787
4788 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4789 dirs from the default value of EMACSLOADPATH (bug#10208).
4790
7efa6272
GM
47912011-12-07 Glenn Morris <rgm@gnu.org>
4792
4793 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4794 installation and source directories as well. (Bug#10208)
4795
f6fc4d87
CY
47962011-12-06 Chong Yidong <cyd@gnu.org>
4797
4798 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4799
2bf26180
GM
48002011-12-06 Glenn Morris <rgm@gnu.org>
4801
4802 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4803 as an error, not just -1. (Bug#10217)
4804
3a6ad4f0
CY
48052011-12-05 Chong Yidong <cyd@gnu.org>
4806
4807 * keyboard.c (process_special_events): New function.
4808 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4809
75a3b399
PE
48102011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4811
4812 * coding.c (encode_designation_at_bol): Don't use uninitialized
4813 local variable (Bug#9318).
4814
c3c9e25e
KH
48152011-12-05 Kenichi Handa <handa@m17n.org>
4816
4817 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4818 return Qnil (Bug#8046, Bug#10193).
4819
5eb05ea3
KH
48202011-12-05 Kenichi Handa <handa@m17n.org>
4821
4822 * coding.c (encode_designation_at_bol): New args charbuf_end and
4823 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4824 (coding_set_source): Return how many bytes coding->source was
4825 relocated.
4826 (coding_set_destination): Return how many bytes
4827 coding->destination was relocated.
4828 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4829 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4830
48312011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4832
4833 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4834 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4835 macro (Bug#9318).
4836
48372011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4838
4839 The following changes are to fix Bug#9318.
4840
a79703f5 4841 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4842 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4843 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4844 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4845
7dbda6df
JB
48462011-12-05 Juanma Barranquero <lekktu@gmail.com>
4847
4848 * lisp.h (process_quit_flag): Fix external declaration.
4849
6d5eb5b0
SM
48502011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4851
4852 Don't macro-inline non-performance-critical code.
4853 * eval.c (process_quit_flag): New function.
4854 * lisp.h (QUIT): Use it.
4855
a0c3fad0
JD
48562011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4857
4858 * nsfns.m (get_geometry_from_preferences): New function.
4859 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4860
6c07aac2
AS
48612011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4862
4863 * emacs.c (Qkill_emacs): Define.
4864 (syms_of_emacs): Initialize it.
4865 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4866 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4867 (quit_throw_to_read_char): Add parameter `from_signal'.
4868 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4869 * lisp.h (QUIT): Call Fkill_emacs if requested.
4870
c052ead4
JD
48712011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4872
4873 * widget.c (update_wm_hints): Return if wmshell is null.
4874 (widget_update_wm_size_hints): New function.
4875
4876 * widget.h (widget_update_wm_size_hints): Declare.
4877
4878 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4879 widget_update_wm_size_hints (Bug#10104).
4880
9e49252b
EZ
48812011-12-03 Eli Zaretskii <eliz@gnu.org>
4882
4883 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4884 before a newline, prepare the bidi iterator for consuming the
4885 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4886 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4887
02b16839
JL
48882011-12-02 Juri Linkov <juri@jurta.org>
4889
4890 * search.c (Fword_search_regexp): New Lisp function created from
4891 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4892 (Fword_search_backward, Fword_search_forward)
4893 (Fword_search_backward_lax, Fword_search_forward_lax):
4894 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4895 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4896
0068070e
SM
48972011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4898
4899 * fileio.c (Finsert_file_contents): Move after-change-function call
4900 to before the "handled:" label, since all "goto handled" appear in
4901 cases where the *-change-functions have already been properly called
4902 (bug#10117).
4903
3360a3fc
AS
49042011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4905
4906 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4907 waiting for input. (Bug#10169)
4908
73d6c093
EZ
49092011-11-30 Eli Zaretskii <eliz@gnu.org>
4910
4911 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4912 verifies glyph row's hash code--we have just reallocated the
4913 glyphs, so their contents can be complete garbage. (Bug#10164)
4914
febe6bea
JB
49152011-11-30 Juanma Barranquero <lekktu@gmail.com>
4916
4917 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4918
801a4313
EZ
49192011-11-30 Eli Zaretskii <eliz@gnu.org>
4920
4921 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4922 attributes are tested _before_ calling verify_row_hash, to protect
4923 against GCC re-ordering of the tests. (Bug#10164)
4924
2b56b87e
JD
49252011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4926
4927 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4928
4929 * xterm.c (handle_one_xevent): Only set async_visible and friends
4930 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4931 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4932 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4933
dbf31225
PE
49342011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4935
4936 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4937 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4938 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4939 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4940 All uses changed to use GCPRO1 etc.
4941 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4942 Revert to old implementation (i.e., before 2011-03-11).
4943
1305621b
YM
49442011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4945
4946 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4947 of scroll runs so as to avoid assigning disabled bogus rows and
4948 unnecessary graphics copy operations.
4949
8c9afb46
EZ
49502011-11-27 Eli Zaretskii <eliz@gnu.org>
4951
4952 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4953 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4954 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4955 (malloc, free, realloc, calloc): Redirect to e_* only when
4956 compiling Emacs.
4957
4958 * lisp.h (GCTYPEBITS): Move before first use.
4959 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4960 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4961 this macro definition.
4962
4963 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4964 _MSC_VER.
4965
54e9e3bf
JD
49662011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4967
6d5eb5b0
SM
4968 * gtkutil.c (xg_create_frame_widgets):
4969 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4970 present with Gtk+ 2.0.
4971
83aca1cb
PE
49722011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4973
4974 * fileio.c (Finsert_file_contents): Undo previous change; see
4975 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4976
5b76caa4
PE
49772011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4978
4979 Rename locals to avoid shadowing.
4980 * fileio.c (Finsert_file_contents):
4981 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4982 * process.c (wait_reading_process_output):
4983 Rename inner 'proc' to 'p' to avoid shadowing.
4984 Indent for consistency with usual Emacs style.
4985
8c535114
EZ
49862011-11-25 Eli Zaretskii <eliz@gnu.org>
4987
4988 * xdisp.c (redisplay_window): If cursor row is not fully visible
4989 after recentering, and scroll-conservatively is set to a large
4990 number, scroll window by a few more lines to make the cursor fully
4991 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4992 (start_display): Don't move to the next line if the display should
4993 start at a newline that is part of a display vector or an overlay
4994 string. (Bug#10119)
8c535114 4995
fa4fdb5c
JL
49962011-11-24 Juri Linkov <juri@jurta.org>
4997
4998 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4999 after the `MagickPingImage' call. (Bug#10112)
5000
90ec88df
CY
50012011-11-23 Chong Yidong <cyd@gnu.org>
5002
5003 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5004
56e2e794
MR
50052011-11-23 Martin Rudalics <rudalics@gmx.at>
5006
5007 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5008 making another buffer current. (Bug#10114)
5009
b6e64c41
GM
50102011-11-23 Glenn Morris <rgm@gnu.org>
5011
5012 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5013
6b21de18
CY
50142011-11-23 Chong Yidong <cyd@gnu.org>
5015
5016 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5017 using it (Bug#5984).
5018
b12cd789
EZ
50192011-11-22 Eli Zaretskii <eliz@gnu.org>
5020
5021 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5022 and header-lines, as they don't have one computed for them.
5023 (Bug#10098)
5024
5025 * .gdbinit (prow): Make displayed values more self-explaining.
5026 Add row's hash code.
5027
261b6fd4
LMI
50282011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5029
5030 * process.c (wait_reading_process_output): Fix asynchrounous
5031 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5032 (wait_reading_process_output): Add comment and URL.
261b6fd4 5033
e7cfd277
JD
50342011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5035
5036 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5037
a9b9b7f5
CY
50382011-11-21 Chong Yidong <cyd@gnu.org>
5039
5040 * window.c (Fnext_window, Fprevious_window): Doc fix.
5041
b0d15b4f
SM
50422011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5043
5044 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5045
fe7a3057
JB
50462011-11-20 Juanma Barranquero <lekktu@gmail.com>
5047
5048 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5049
d2999b1a
MR
50502011-11-20 Martin Rudalics <rudalics@gmx.at>
5051
5052 * window.c (Fset_window_combination_limit): Rename argument
5053 STATUS to LIMIT.
5054 (Vwindow_combination_limit): Remove "status" from doc-string.
5055
d5ff9cd0
AS
50562011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5057
5058 * m/ibms390.h: Remove.
5059 * m/ibms390x.h: Don't include "ibms390.h".
5060
a5bb9bd3
SM
50612011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5062
5063 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5064 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5065
cd1181db
JB
50662011-11-20 Juanma Barranquero <lekktu@gmail.com>
5067
5068 * casetab.c (Fset_case_table):
5069 * charset.c (Fcharset_after): Fix typos.
5070
615a3b8d 50712011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5072
17e845af
PE
5073 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5074 Otherwise, valgrind does not work on some platforms.
5075 Problem reported by Andreas Schwab in
6a0bf43d
PE
5076 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5077 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5078 is set, removing the need for VIRT_ADDRESS_VARIES.
5079 (PURE_P): Use a more-efficient implementation that needs just one
5080 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5081 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5082 to 4 (xorl, subq, cmpq, setbe).
5083 * alloc.c (pure): Always extern now, since that's the
5084 VIRT_ADDR_VARIES behavior.
5085 (PURE_POINTER_P): Use a single comparison, not two, for
5086 consistency with the new puresize.h.
5087 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5088 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5089 Remove VIRT_ADDR_VARIES no longer needed.
5090
f8fe6f96
EZ
50912011-11-19 Eli Zaretskii <eliz@gnu.org>
5092
5093 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5094 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5095 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5096 behave as if the cursor position were at the window margin.
5097
5098 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5099 and the cursor position is out of bounds, behave as if the cursor
5100 position were at the window margin. (Bug#10075)
5101
df05a53c
CY
51022011-11-18 Chong Yidong <cyd@gnu.org>
5103
5104 * window.c (Fwindow_combination_limit): Make first argument
5105 non-optional, since it is meaningless for live windows like the
5106 selected window.
61ccba97 5107
2071918e
DA
51082011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5109
5110 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5111
b50a28de
SM
51122011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5113
5114 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5115 (graft_intervals_into_buffer): Simplify.
5116
015137db
EZ
51172011-11-18 Eli Zaretskii <eliz@gnu.org>
5118
5119 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5120 hash values of the two rows.
5121 (copy_row_except_pointers): Preserve the used[] arrays and the
5122 hash values of the two rows. (Bug#10035)
68c95424 5123 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5124
5125 * xdisp.c (row_hash): New function, body extracted from
5126 compute_line_metrics.
5127 (compute_line_metrics): Call row_hash, instead of computing the
5128 hash code inline.
5129
5130 * dispnew.c (verify_row_hash): Call row_hash for computing the
5131 hash code of a row, instead of duplicating code from xdisp.c.
5132
5133 * dispextern.h (row_hash): Add prototype.
5134
a2addb04
TH
51352011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5136
5137 * frame.c (delete_frame): Don't delete the terminal when the last
5138 X frame is closed if emacs is built with GTK toolkit.
5139
df85d315
JB
51402011-11-17 Juanma Barranquero <lekktu@gmail.com>
5141
5142 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5143
a0c2d0ae
MR
51442011-11-17 Martin Rudalics <rudalics@gmx.at>
5145
5146 * window.c (Vwindow_splits): Rename to
5147 Vwindow_combination_resize. Suggested by Juri Linkov.
5148 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5149 of Vwindow_splits.
5150
58179cce
JB
51512011-11-16 Juanma Barranquero <lekktu@gmail.com>
5152
7877f373
JB
5153 * nsfns.m (Fns_font_name):
5154 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5155
b6f67890
MR
51562011-11-16 Martin Rudalics <rudalics@gmx.at>
5157
5158 * window.h (window): Rename slot "nest" to "combination_limit".
5159 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5160 (Fset_window_nest): Rename to Fset_window_combination_limit.
5161 (Vwindow_nest): Rename to Vwindow_combination_limit.
5162 (recombine_windows, make_parent_window, make_window)
5163 (Fsplit_window_internal, saved_window)
5164 (Fset_window_configuration, save_window_save): Rename all
5165 occurrences of window_nest to window_combination_limit.
5166
c7015153
JB
51672011-11-15 Juanma Barranquero <lekktu@gmail.com>
5168
5169 * image.c (imagemagick_load_image): Fix typo.
5170
322ad6ec
EZ
51712011-11-14 Eli Zaretskii <eliz@gnu.org>
5172
5173 * xdisp.c (display_line): Move the call to
5174 highlight_trailing_whitespace before the call to
5175 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5176 faces of all the glyphs to compute ROW's hash value.
5177 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5178
f067b8ec
JB
51792011-11-14 Juanma Barranquero <lekktu@gmail.com>
5180
5181 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5182 just return (bug#10044).
5183
1e5b2111
EZ
51842011-11-12 Eli Zaretskii <eliz@gnu.org>
5185
7ef3cbd5
EZ
5186 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5187 with user-defined heap size. Bump the default size of the temacs
5188 heap to 27MB, to avoid memory warning when running temacs.
5189 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5190
1e5b2111
EZ
5191 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5192 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5193 (verify_row_hash) [XASSERTS]: New function.
5194 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5195 that the hash value of glyph rows is correct.
1e5b2111 5196
89d61221
MR
51972011-11-12 Martin Rudalics <rudalics@gmx.at>
5198
5199 * window.h (window): Remove splits slot.
5200 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5201 (Fdelete_other_windows_internal, make_parent_window)
5202 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5203 (Fset_window_configuration, save_window_save): Don't deal with
5204 split status of windows.
5205 (saved_window): Remove splits slot.
5206 (Vwindow_splits): Rewrite doc-string.
5207
97f18cc8
JD
52082011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5209
5210 * xfns.c (unwind_create_frame):
5211 * nsfns.m (unwind_create_frame):
5212 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5213 Vframe_list (Bug#9999).
5214
22a648b4
DA
52152011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5216
0b381c7e 5217 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5218
659afede
KH
52192011-11-11 Kenichi Handa <handa@m17n.org>
5220
5221 * callproc.c (Fcall_process): Set the member dst_multibyte of
5222 process_coding.
5223
9ac0394b
KH
52242011-11-11 Johan Bockgård <bojohan@gnu.org>
5225
5226 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5227 avoid a crash (bug#9496).
5228
2fbdc249
CY
52292011-11-09 Chong Yidong <cyd@gnu.org>
5230
5231 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5232 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5233
ac6b1f81
PE
52342011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5235
5236 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5237
09db192c
PE
52382011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5239
5240 Avoid some portability problems by eschewing 'extern inline' functions.
5241 The trivial performance wins aren't worth the portability hassles; see
5242 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5243 et seq.
5244 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5245 (window_box_width, window_box_left, window_box_left_offset)
5246 (window_box_right, window_box_right_offset): Undo previous change,
5247 by removing the "extern"s.
5248 * intervals.c (adjust_intervals_for_insertion)
5249 (adjust_intervals_for_deletion): Undo previous change,
5250 making these static again.
5251 (offset_intervals, temp_set_point_both, temp_set_point)
5252 (copy_intervals_to_string): No longer inline.
5253 * xdisp.c (window_text_bottom_y, window_box_width)
5254 (window_box_height, window_box_left_offset)
5255 (window_box_right_offset, window_box_left, window_box_right)
5256 (window_box): No longer inline.
5257
105216ed
CY
52582011-11-08 Chong Yidong <cyd@gnu.org>
5259
5260 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5261 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5262 Signal an error if not a live window.
105216ed
CY
5263 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5264 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5265
ae9e237f
JB
52662011-11-07 Juanma Barranquero <lekktu@gmail.com>
5267
5268 * lisp.h (syms_of_abbrev): Remove declaration.
5269 Reported by CHENG Gao <chenggao@royau.me>.
5270
c7aa8333
EZ
52712011-11-07 Eli Zaretskii <eliz@gnu.org>
5272
5273 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5274 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5275 of temacs in GUI mode.
5276
be7f5545
MR
52772011-11-07 Martin Rudalics <rudalics@gmx.at>
5278
5279 * window.h: Declare delete_all_child_windows instead of
5280 delete_all_subwindows.
5281 * window.c (Fwindow_nest, Fset_window_nest)
5282 (Fset_window_new_total, Fset_window_new_normal)
5283 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5284 (delete_all_subwindows): Rename to delete_all_child_windows.
5285 (Fdelete_other_windows_internal, Fset_window_configuration):
5286 Call delete_all_child_windows instead of delete_all_subwindows.
5287 * frame.c (delete_frame): Call delete_all_child_windows instead
5288 of delete_all_subwindows.
5289
ca78dc43
PE
52902011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5291
5292 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5293 This is also needed for porting to any host where GC_MARK_STACK is
5294 not GC_MAKE_GCPROS_NOOPS.
5295 (which_symbols): Use it.
5296
a0241d01
KH
52972011-11-07 Kenichi Handa <handa@m17n.org>
5298
5299 * coding.c (coding_set_destination): Check coding->src_pos only
5300 when coding->src_object is a buffer (bug#9910).
5301
5302 * process.c (send_process): Set the member src_multibyte of coding
5303 to 0 (bug#9911) when sending a unibyte text.
5304
5305 * callproc.c (Fcall_process): Set the member src_multibyte of
5306 process_coding to 0 (bug#9912).
5307
a64bfdfa 53082011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5309
5310 * xmenu.c (cleanup_widget_value_tree): New function.
5311 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5312 calling free_menubar_widget_value_tree directly (Bug#9830).
5313
cb41b32a
PE
53142011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5315
5316 Fix some portability problems with 'inline'.
5317 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5318 (window_box_width, window_box_left, window_box_left_offset)
5319 (window_box_right, window_box_right_offset): Declare extern.
5320 Otherwise, these inline functions do not conform to C99 and
5321 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5322 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5323 * intervals.c (adjust_intervals_for_insertion)
5324 (adjust_intervals_for_deletion): Now extern, because otherwise the
5325 extern inline functions 'offset_intervals' couldn't refer to it.
5326 (static_offset_intervals): Remove.
5327 (offset_intervals): Rewrite using the old contents of
5328 static_offset_intervals. The old version didn't conform to C99
5329 because an extern inline function contained a reference to an
5330 identifier with static linkage.
5331
b7041366
AS
53322011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5333
5334 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5335 GC.
5336
88a37c4d
EZ
53372011-11-06 Eli Zaretskii <eliz@gnu.org>
5338
5339 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5340 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5341 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5342 return Qleft_to_right.
5343
49745b39
CY
53442011-11-06 Chong Yidong <cyd@gnu.org>
5345
5346 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5347 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5348 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5349 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5350 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5351 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5352 (Fwindow_vscroll): Doc fix.
5353 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5354 argument, since it makes no sense to pass a live window and for
5355 consistency with window-child.
5356
1f05cd82
CS
53572011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5358
5359 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5360 support MSVC.
5361
22610910
JR
53622011-11-05 Jason Rumney <jasonr@gnu.org>
5363
5364 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5365 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5366 fonts (Bug#6029).
5367 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5368 bitwise arithmetic preventing use of unicode-sip and non-truetype
5369 opentype fonts.
5370
a06776b2
EZ
53712011-11-05 Eli Zaretskii <eliz@gnu.org>
5372
3ad924ba
EZ
5373 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5374 "emacs"-only part.
5375
a06776b2
EZ
5376 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5377 initialization code to keep similarity to xfns.c after changes
5378 from 2011-11-05.
5379
c9e7db78
JD
53802011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5381
a97f8f3f
JD
5382 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5383 (unwind_create_frame): New function (Bug#9943).
5384 (Fx_create_frame): Restructure code to be more similar to the one in
5385 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5386 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5387 Move terminal->reference_count++ just before making the frame official
5388 (Bug#9943).
5389
5390 * nsterm.m (x_free_frame_resources): New function.
5391 (x_destroy_window): Move code to x_free_frame_resources.
5392
c9e7db78 5393 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5394 (Fx_create_frame, x_create_tip_frame):
5395 Move terminal->reference_count++ just before making the frame
75f1671a 5396 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5397 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5398
a6fc3b5c
EZ
53992011-11-05 Eli Zaretskii <eliz@gnu.org>
5400
5401 Support MSVC build with newer versions of Visual Studio.
5402 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5403 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5404 nt/gmake.defs.
5405
5406 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5407 which are not supported by MSVC.
5408 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5409 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5410 bitfields.
5411 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5412 types in bitfields.
5413 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5414
5415 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5416
58179cce 54172011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5418
5419 Support MSVC build with newer versions of Visual Studio.
5420 * w32.c: Don't include w32api.h for MSVC.
5421 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5422
5423 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5424 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5425 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5426 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5427 e_* cousins.
5428 (alloca) [_MSC_VER]: Define to _alloca.
5429
5430 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5431
5432 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5433
a58c13ed
EZ
54342011-11-04 Eli Zaretskii <eliz@gnu.org>
5435
5436 * xdisp.c (note_mouse_highlight): If either of
5437 previous/next-single-property-change returns nil, treat that as
5438 the beginning or the end of the buffer. (Bug#9955)
5439
fe0b6370
JD
54402011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5441
a58c13ed 5442 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5443 label is not null (Bug#9951).
5444 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5445 may be NULL.
5446
89bd5ee1
EZ
54472011-11-04 Eli Zaretskii <eliz@gnu.org>
5448
5449 * window.c (Fwindow_body_size): Mention in the doc string that the
5450 return value is in frame's canonical units. (Bug#9949)
5451
84c3edb9
EZ
54522011-11-03 Eli Zaretskii <eliz@gnu.org>
5453
4e2fb5c7
EZ
5454 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5455
84c3edb9 5456 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5457 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5458 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5459
bc17a887
EZ
54602011-11-01 Eli Zaretskii <eliz@gnu.org>
5461
5462 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5463 Don't stop backward scan on the continuation glyph, even though
5464 its CHARPOS is positive.
6d5eb5b0
SM
5465 (mouse_face_from_buffer_pos, note_mouse_highlight):
5466 Rename cover_string to disp_string.
bc17a887 5467
4ee88440
MR
54682011-11-01 Martin Rudalics <rudalics@gmx.at>
5469
5470 * window.c (temp_output_buffer_show): Don't use
5471 Vtemp_buffer_show_specifiers.
5472 (Vtemp_buffer_show_specifiers): Remove unused variable.
5473
c2ff3c02
EZ
54742011-10-30 Eli Zaretskii <eliz@gnu.org>
5475
5476 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5477 past the beginning of the current glyph matrix.
5478
58179cce 54792011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5480
5481 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5482 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5483 HAVE_GTK3 (Bug#9869).
b77a6a7f 5484
3b574623
JD
5485 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5486 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5487
b77a6a7f
JD
5488 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5489
5490 * xterm.c: Declare x_handle_net_wm_state to return int.
5491 (handle_one_xevent): Check if we are iconified but don't have
5492 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5493 (get_current_wm_state): Return non-zero if not hidden,
5494 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5495 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5496 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5497 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5498
196e41e4
PE
54992011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5500
5501 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5502 so that this new function doesn't get optimized away by a
5503 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5504
021f2e1a
AS
55052011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5506
5507 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5508
8b058d44
EZ
55092011-10-29 Eli Zaretskii <eliz@gnu.org>
5510
5511 Fix the `xbytecode' command.
5512 * .gdbinit (xprintbytestr): New command.
b50a28de 5513 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5514 (xbytecode): Print the byte-code string as well.
5515
4452fb80
EZ
55162011-10-29 Kim Storm <storm@cua.dk>
5517
8b058d44
EZ
5518 * alloc.c (which_symbols): New function.
5519
21b72067
AS
55202011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5521
5522 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5523 line. (Bug#9903)
5524
83ed7b5c
GM
55252011-10-29 Glenn Morris <rgm@gnu.org>
5526
5527 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5528 Not clear what it was for, and it causes various bugs. (Bug#9839)
5529
5a7a728b
EZ
55302011-10-28 Eli Zaretskii <eliz@gnu.org>
5531
5532 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5533 possible random value that matches one of those tested as
5534 condition to clear the mouse face.
5535
d3d0842f
CY
55362011-10-28 Chong Yidong <cyd@gnu.org>
5537
5538 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5539
31b39d13
DN
55402011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5541
5542 * window.c (make_window): Initialize phys_cursor_on_p.
5543
9aba6043
SM
55442011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5545
5546 * lisp.h (struct Lisp_Symbol): Update comments.
5547
c20992f4
JB
55482011-10-28 Juanma Barranquero <lekktu@gmail.com>
5549
5550 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5551
db4f02f2
EZ
55522011-10-28 Eli Zaretskii <eliz@gnu.org>
5553
5554 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5555 <oslsachem@gmail.com> for helping to debug this.
5556
5557 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5558 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5559 (g_b_init_get_glyph_outline_w): New static variables.
5560 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5561 (GetGlyphOutlineW_Proc): New typedefs.
5562 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5563 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5564 New functions.
5565 (w32font_open_internal, compute_metrics):
5566 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5567 instead of calling the "wide" APIs directly.
5568
5569 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5570
5571 * w32.h (syms_of_w32font): Add prototype.
5572
87e68db4
JB
55732011-10-27 Juanma Barranquero <lekktu@gmail.com>
5574
5575 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5576 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5577 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5578 (Fmove_to_window_line): Doc fix.
5579
435c1d67
CY
55802011-10-27 Chong Yidong <cyd@gnu.org>
5581
5582 * process.c (make_process): Set gnutls_state to NULL.
5583
5584 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5585 non-NULL, regardless of GNUTLS_INITSTAGE.
5586 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5587 an error. Set process slots as soon as we allocate them.
5588
5589 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5590
9c6c6f49
CY
55912011-10-27 Chong Yidong <cyd@gnu.org>
5592
9aba6043
SM
5593 * gnutls.c (emacs_gnutls_deinit): New function.
5594 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5595 (Fgnutls_deinit, Fgnutls_boot): Use it.
5596
5597 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5598 (deactivate_process): Call emacs_gnutls_deinit.
5599
657d08d3
JB
56002011-10-27 Juanma Barranquero <lekktu@gmail.com>
5601
5602 * image.c (x_create_x_image_and_pixmap):
5603 * w32.c (sys_rename, w32_delayed_load):
5604 * w32font.c (fill_in_logfont):
5605 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5606
5430d399
JB
56072011-10-26 Juanma Barranquero <lekktu@gmail.com>
5608
5609 * w32fns.c (w32_default_color_map): New function,
5610 extracted from Fw32_default_color_map.
a7ef684b 5611 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5612
fe0055fa
PE
56132011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5614
5615 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5616
e6346438
SM
56172011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5618
5619 * keyboard.c (test_undefined): New function (bug#9751).
5620 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5621
e112cc37
ET
56222011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5623
5624 * sysdep.c (init_sys_modes): Fix the check for the controlling
5625 terminal (Bug#6649).
5626
7b5d6677
EZ
56272011-10-20 Eli Zaretskii <eliz@gnu.org>
5628
5629 * dispextern.h (struct bidi_it): New member next_en_type.
5630
5631 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5632 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5633 current character, check also for next_en_type being WEAK_EN.
5634 (bidi_resolve_weak): Don't enter the expensive loop if the current
5635 position is before next_en_pos. Record the bidi type of the first
5636 non-ET, non-BN character we find, in addition to its position.
5637 (bidi_level_of_next_char): Invalidate next_en_type when
5638 next_en_pos is over-stepped.
5639
7da0b018
PE
56402011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5641
5642 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5643 * editfns.c: Rewrite current-time-zone so that it invokes
5644 the equivalent of (format-time-string "%Z") to get the time zone name.
5645 This fixes a bug when the time zone name contains characters that
5646 need converting from the system time locale to Emacs internal format.
5647 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5648 that patch fixed format-time-string to do the conversion, but
5649 I forgot to fix current-time-zone.
5650 (format_time_string): New function, containing most of
5651 what Fformat_time_string used to contain.
5652 (Fformat_time_string): Rewrite in terms of format_time_string.
5653 This doesn't change this function's behavior.
5654 (current-time-zone): Rewrite to use format_time_string.
5655 This fixes the bug reported by Michael Schierl in
5656 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5657 Jason Rumney's 2007-06-07 change worked around this bug, but
5658 didn't fix it.
5659 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5660
8547b010
EZ
56612011-10-19 Eli Zaretskii <eliz@gnu.org>
5662
5663 * xdisp.c (start_display): If the character at POS is displayed
5664 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5665 (try_window_reusing_current_matrix): If a line ends in a display
5666 vector or the next line starts in a display vector, continue
5667 redrawing the window even though the character position of
5668 start_row was reached.
8547b010
EZ
5669 (Bug#9771, part 2)
5670
4e948d15
CY
56712011-10-18 Chong Yidong <cyd@gnu.org>
5672
5673 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5674 with nobreak-char-display too.
5675
4787455f
EZ
56762011-10-18 Eli Zaretskii <eliz@gnu.org>
5677
5678 Fix part 3 of bug#9771.
5679 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5680 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5681 non-neutral characters if the current character is a paragraph
5682 separator (a.k.a. Newline). This avoids running the same
5683 expensive loop twice, once when we consume the preceding newline
5684 and the other time when the line actually needs to be displayed.
5685 Avoid the loop when we see neutrals on the base embedding level
5686 following a character whose directionality is the same as the
5687 paragraph's. This avoids running the expensive loop when a line
5688 ends in a long sequence of neutrals, like control characters.
5689 Add assertion against STRONG_AL type. Slightly rearrange code
5690 that determines the type of a neutral given the first non-neutral
5691 that follows it.
5692 (bidi_level_of_next_char): Set next_en_pos to zero when
5693 invalidating its info.
5694
2c91f553
EZ
56952011-10-17 Eli Zaretskii <eliz@gnu.org>
5696
5697 * xdisp.c (push_display_prop): Determine whether to record string
5698 or buffer position by IT->string, not by IT->method. Allow
5699 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5700 (move_it_vertically_backward): Don't look for character position
5701 immediately after the newline when in a continuation line.
5702 (Bug#9771, part 1)
2c91f553 5703
c7b08b0d
MR
57042011-10-15 Martin Rudalics <rudalics@gmx.at>
5705
5706 * window.c (coordinates_in_window): Rewrite and delabelize
5707 vertical border check. (Bug#5357) (Bug#9618)
5708
6b02f655
SM
57092011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5710
5711 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5712 errors in XSetWindowBorder (bug#9310).
5713
81d40c92
DA
57142011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5715
5716 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5717 avoid crash when xmalloc overrun checking is enabled.
5718
d4172c3b
EZ
57192011-10-13 Eli Zaretskii <eliz@gnu.org>
5720
5721 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5722 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5723 cursor motion with <left> and <right> arrow keys.
5724
5725 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5726 some callers set that themselves.
5727
b00eea75
EZ
57282011-10-12 Eli Zaretskii <eliz@gnu.org>
5729
5730 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5731 display string and the previous row comes from the same string and
5732 is empty. (Bug#9739) (Bug#9738)
5733
8fe012c4
SM
57342011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5735
5736 * doc.c (get_doc_string): Encode file name (bug#9735).
5737
0074aef2
EZ
57382011-10-12 Eli Zaretskii <eliz@gnu.org>
5739
79beb178
EZ
5740 * bidi.c (bidi_level_of_next_char):
5741 * xdisp.c (get_visually_first_element): Remove old incorrect
5742 comments regarding the Unicode Line Separator character.
5743
0074aef2
EZ
5744 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5745
6e4b3fbe
DA
57462011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5747
5748 * alloc.c (Fgc_status): Do not access beyond zombies array
5749 boundary if nzombies > MAX_ZOMBIES.
5750 * alloc.c (dump_zombies): Add missing format specifier.
5751
0324f3af
PE
57522011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5753
b5525cac
PE
5754 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5755 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5756
0324f3af
PE
5757 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5758 Some packages use them to denote characters with modifiers.
5759
e9b5f888
AS
57602011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5761
5762 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5763 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5764 matching a pp-number. Rename parameter var to var1.
5765
127827c0
SM
57662011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5767
5768 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5769
c8fd3bd0
GM
57702011-10-08 Glenn Morris <rgm@gnu.org>
5771
5772 * callint.c (Fcall_interactively): Give a more explicit error for the
5773 'c' case with a non-character input. (Bug#8479)
5774
352ec8ff
EZ
57752011-10-08 Eli Zaretskii <eliz@gnu.org>
5776
03669ccb
EZ
5777 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5778 lines.
7061c986
EZ
5779 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5780 lines that are hscrolled on the left.
03669ccb 5781
352ec8ff
EZ
5782 * dispnew.c (buffer_posn_from_coords): Account for a possible
5783 presence of header-line. (Bug#4426)
5784
a66cfb1c
SM
57852011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5786
6b02f655
SM
5787 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5788 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5789
7c5ee88e
PE
57902011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5791
5792 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5793 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5794 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5795 this makes Emacs dump core during garbage collection on rare
5796 occasions. sizeof is obviously inferior to offsetof here, so
5797 stick with offsetof.
5798 (GC_POINTER_ALIGNMENT): New macro.
5799 (mark_memory): Omit 3rd (offset) arg; caller changed.
5800 Don't assume EMACS_INT alignment is the same as pointer alignment.
5801
df1bbe5b
SM
58022011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5803
5804 * keyboard.c (read_key_sequence_remapped): New var.
5805 (read_key_sequence): Compute remapping in the right buffer.
5806 (command_loop_1): Use read_key_sequence's remapping directly.
5807
51553db6
SM
58082011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5809
32c1fffd
SM
5810 * dired.c (file_name_completion): Don't expand file name.
5811 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5812 before checking file name handler.
5813
51553db6
SM
5814 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5815 they've been requested explicitly (bug#9591).
5816
b6bd1599 58172011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5818
5819 * keymap.c (Fsingle_key_description): Use make_specified_string
5820 instead of build_string to build string from push_key_description.
5821 (Bug#5193)
5822
f701dc2a
PE
58232011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5824
4222c55d
PE
5825 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5826 This fixes a Y2038 bug on 64-bit hosts.
5827 * buffer.c (reset_buffer):
5828 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5829 (Fclear_buffer_auto_save_failure):
5830 Use 0, not -1, to represent an unset failure time, since time_t
5831 might not be signed.
5832
f701dc2a
PE
5833 Remove dependency on glibc malloc internals.
5834 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5835 Move back here from lisp.h, but with their new implementations.
5836 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5837 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5838 * charset.c (charset_table_init): New static var.
5839 (syms_of_charset): Use it instead of xmalloc. This removes a
5840 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5841 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5842 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5843 Move back to alloc.c.
5844 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5845 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5846
9ceebf39
JD
58472011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5848
5849 * nsterm.m (windowDidResize): Call x_set_window_size only when
5850 ns_in_resize is true. Otherwise set pixelwidth/height and
5851 call change_frame_size (Bug#9628).
5852
cb993c58
PE
58532011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5854
3930c88b
PE
5855 Port --enable-checking=all to Fedora 14 x86-64.
5856 * charset.c (syms_of_charset): Also account for glibc malloc's
5857 internal overhead when calculating the initial malloc maximum.
5858
cb993c58
PE
5859 Port --enable-checking=all to Fedora 14 x86.
5860 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5861 Move to lisp.h.
5862 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5863 (overrun_check_realloc, overrun_check_free):
5864 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5865 That way, xmalloc returns a properly-aligned pointer even if
5866 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5867 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5868 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5869 into account when calculating the initial malloc maximum.
5870 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5871 Move here from alloc.c, so that charset.c can use it too.
5872 Properly align; the old code wasn't right for common 32-bit hosts
5873 when configured with --enable-checking=all.
5874 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5875 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5876
31bed486
EZ
58772011-09-29 Eli Zaretskii <eliz@gnu.org>
5878
04c70788 5879 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5880 use EDOM.
5881
fbcaa2f3
EZ
58822011-09-28 Eli Zaretskii <eliz@gnu.org>
5883
5884 * xdisp.c (compute_display_string_end): If there's no display
5885 string at CHARPOS, return -1.
5886
5887 * bidi.c (bidi_fetch_char): When compute_display_string_end
5888 returns a negative value, treat the character as a normal
5889 character not covered by a display string. (Bug#9624)
5890
a239d4e9
JB
58912011-09-28 Juanma Barranquero <lekktu@gmail.com>
5892
5893 * lread.c (Fread_from_string): Fix typo in docstring.
5894
88652fd5
EZ
58952011-09-27 Eli Zaretskii <eliz@gnu.org>
5896
5897 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5898 newline, reseat the iterator instead of bidi-iterating there one
5899 character at a time. (Bug#9610)
32c1fffd
SM
5900 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5901 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5902
ed497dd4
AS
59032011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5904
5905 * lread.c (readevalloop): Use correct code for NBSP.
5906 (read1): Likewise. (Bug#9608)
5907
b2bf61aa
MA
59082011-09-25 Michael Albinus <michael.albinus@gmx.de>
5909
5910 * dbusbind.c (Fdbus_register_signal): When service is not
5911 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5912
32bbb17c
GM
59132011-09-25 Glenn Morris <rgm@gnu.org>
5914
5915 * buffer.c (truncate-lines): Doc fix.
5916
94e0933e
CY
59172011-09-24 Chong Yidong <cyd@stupidchicken.com>
5918
5919 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5920 (Fset_window_next_buffers): Doc fix.
5921
cddde921
GM
59222011-09-24 Glenn Morris <rgm@gnu.org>
5923
5924 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5925
1260aef1
PE
59262011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5927
25b4bfa0
PE
5928 Fix minor problems found by static checking.
5929 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5930 * indent.c (Fvertical_motion): Fix == vs = typo.
5931
e3cbd34b
EZ
59322011-09-24 Eli Zaretskii <eliz@gnu.org>
5933
a66cfb1c
SM
5934 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5935 Default value is now t. Doc fix.
6bf7006f 5936
e3cbd34b 5937 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5938 logic when moving up, not only when moving down. Fix the
e3cbd34b 5939 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5940 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5941
5942 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5943 CHARPOS is covered by a display string which includes newlines.
5944 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5945 is covered by a display string with embedded newlines.
5946
a3de0cbd
MA
59472011-09-24 Michael Albinus <michael.albinus@gmx.de>
5948
5949 * dbusbind.c (Fdbus_register_signal): Add match rule to
5950 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5951 (Fdbus_register_method, Vdbus_registered_objects_table):
5952 Fix docstring.
a3de0cbd 5953
b260039d
JM
59542011-09-24 Jim Meyering <meyering@redhat.com>
5955
32c1fffd 5956 do not ignore write error for any output size
b260039d
JM
5957 The previous change was incomplete.
5958 While it makes emacs --batch detect the vast majority of stdout
5959 write failures, errors were still ignored whenever the output size is
5960 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5961 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5962 && echo FAIL: ignored write error
5963 FAIL: ignored write error
5964 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5965 && echo FAIL: ignored write error
5966 FAIL: ignored write error
5967 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5968
8eca8a7c
AS
59692011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5970
5971 * emacs.c (Fkill_emacs): In noninteractive mode exit
5972 non-successfully if a write error occurred on stdout. (Bug#9574)
5973
3341db62
EZ
59742011-09-21 Eli Zaretskii <eliz@gnu.org>
5975
5976 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5977 the xassert test.
5978
5979 * dispextern.h (struct it): Update the comment documenting what
5980 can it->OBJECT be.
5981
8c203dbf
EZ
59822011-09-20 Eli Zaretskii <eliz@gnu.org>
5983
5984 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5985 a display string, extend search for cursor position to end of row.
5986 (find_row_edges): If the row ends in a newline from a display
5987 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5988 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5989 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5990 non-empty line. Fixes confusing cursor motion with arrow keys at
5991 the beginning of a line that starts with whitespace.
8c203dbf 5992
a4824228
LMI
59932011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5994
5995 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5996 (bug#9493).
5997
33ed493b
CY
59982011-09-18 Chong Yidong <cyd@stupidchicken.com>
5999
6000 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6001 boolean (Bug#9154).
6002
56cd55c8
EZ
60032011-09-18 Eli Zaretskii <eliz@gnu.org>
6004
6005 * xdisp.c (display_line): Record maximum and minimum buffer
6006 positions even if no glyphs were produced (e.g., by a zero-width
6007 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6008 buffer positions that will be removed from the glyph row because
6009 they don't fit.
c02dcedf
EZ
6010 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6011 column is beyond frame width: don't subtract 1 "pixel" when
6012 computing width of the stretch.
3e62b7e0
EZ
6013 (reseat_at_next_visible_line_start): Undo the change made on
6014 2011-09-17 that saved paragraph information and restored it after
6015 the call to `reseat'. (Bug#9545)
56cd55c8 6016
5ed99d36 60172011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6018
6019 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6020 and turn window cursor on if cleared (Bug#9415).
6021
5ed99d36 60222011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6023
6024 * search.c (boyer_moore): Take unibyte characters from pattern
6025 literally. (Bug#9458)
6026
9bade7b2
EZ
60272011-09-18 Eli Zaretskii <eliz@gnu.org>
6028
6029 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6030
e5e9d610
PE
60312011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6032
87e4427a
PE
6033 Fix minor problem found by static checking.
6034 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6035 initialized, to pacify gcc -Wuninitialized.
6036
e5e9d610
PE
6037 * fileio.c: Report proper errno when syscall falls.
6038 (Finsert_file_contents): Save and restore errno,
6039 so that report_file_error outputs the correct diagnostic.
6040 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6041
a1674f0b
EZ
60422011-09-18 Eli Zaretskii <eliz@gnu.org>
6043
6044 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6045
fbfb6dd4
EZ
60462011-09-17 Eli Zaretskii <eliz@gnu.org>
6047
6048 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6049 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6050
bb187662
EZ
60512011-09-17 Eli Zaretskii <eliz@gnu.org>
6052
1137e8b8 6053 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6054 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6055
6056 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6057 (bidi_find_paragraph_start): Search back for paragraph beginning
6058 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6059 (bidi_move_to_visually_next): Only trigger paragraph-related
6060 computations when the last character is a newline or at EOB, not
6061 just any NEUTRAL_B. (Bug#9470)
6062
bb187662
EZ
6063 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6064 truncated lines if point is covered by a display string. (Bug#9524)
6065
2e621251
PE
60662011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6067
6068 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6069 (cons_to_x_long): New function.
6070 (lisp_data_to_selection_data): Use it. Correct the test for
6071 short-versus-long data; it was negated. Break out of vector
6072 loop, for efficiency, when a long datum is discovered.
6073
91a15bc6
SM
60742011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6075
6076 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6077
b41c3a35
EZ
60782011-09-16 Eli Zaretskii <eliz@gnu.org>
6079
6080 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6081 GCC PR/17406) by declaring this function with external scope.
6082
7812ba2d
PE
60832011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6084
6085 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6086 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6087
cf7edc2a
AS
60882011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6089
6090 * editfns.c (Fformat): Correctly handle text properties on "%%".
6091
bd01620e
EZ
60922011-09-15 Eli Zaretskii <eliz@gnu.org>
6093
6094 * xterm.c (x_draw_composite_glyph_string_foreground):
6095 * w32term.c (x_draw_composite_glyph_string_foreground):
6096 * term.c (encode_terminal_code):
6097 * composite.c (composition_update_it, get_composition_id):
6098 * xdisp.c (get_next_display_element)
6099 (fill_composite_glyph_string): Add comments about special meaning
6100 of TAB characters in a composition.
6101
a02719a3
PE
61022011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6103
6104 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6105 This occurs when processing a multibyte format.
6106 Problem reported by Wolfgang Jenker.
a02719a3 6107
72589a3c
JB
61082011-09-15 Johan Bockgård <bojohan@gnu.org>
6109
6110 * xdisp.c (try_cursor_movement): Only check for exact match if
6111 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6112
1c14176c
PE
61132011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6114
6115 Remove unused external symbols.
6116 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6117 * xdisp.c (calc_pixel_width_or_height): Now static.
6118 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6119 * indent.c (check_display_width):
6120 * w32term.c: Fix comment to match code.
6121 * xterm.c, xterm.h (x_catching_errors): Remove.
6122
d2eea5b5
PE
61232011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6124
6125 * xselect.c: Use signed conversions more consistently (Bug#9498).
6126 (selection_data_to_lisp_data): Assume incoming selection data are
6127 signed integers, not unsigned. This is to be consistent with
6128 outgoing selection data, which was modified to use signed integers
6129 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6130 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6131 expects long, not unsigned long.
6132
46888499
EZ
61332011-09-14 Eli Zaretskii <eliz@gnu.org>
6134
6135 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6136 computation of loop end. Reported by Johan Bockgård
6137 <bojohan@gnu.org>.
6138
ef8ef9fb
CY
61392011-09-13 Chong Yidong <cyd@stupidchicken.com>
6140
6141 * frame.c (Fother_visible_frames_p): Function deleted.
6142
fa819fed
EZ
61432011-09-12 Eli Zaretskii <eliz@gnu.org>
6144
6145 * indent.c (compute_motion): Process display vector front to back
6146 rather than the other way around. (Bug#2496)
6147
2ba8e008
SM
61482011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6149
6150 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6151
20f53c69
CY
61522011-09-11 Chong Yidong <cyd@stupidchicken.com>
6153
6154 * minibuf.c (Fread_from_minibuffer): Doc fix.
6155
d562d7a4
EZ
61562011-09-11 Eli Zaretskii <eliz@gnu.org>
6157
6158 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6159 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6160
1c4d7f3d
LMI
61612011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6162
6163 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6164 value for non-existent files.
6165
b885bf36
EZ
61662011-09-11 Eli Zaretskii <eliz@gnu.org>
6167
6168 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6169 set its "size" to -1. This will set the modtime_size field of
6170 the corresponding buffer to -1, which is what
6171 verify-visited-file-modtime expects for files that do not exist.
6172 (Bug#9139)
6173
6612f0bf
PE
61742011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6175
6176 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6177 here ...
6178 * lisp.h: ... from here. push_key_description is no longer
6179 defined in keyboard.c, so its declaration should not be in
6180 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6181 logically belongs with push_key_description.
6182
dfb3f755
PE
61832011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6184
6185 * buffer.h: Include <sys/types.h> instead of <time.h>.
6186 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6187 Problem reported by Herbert J. Skuhra.
6188
3134906c
LMI
61892011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6190
6191 * xml.c (parse_region): Make the parsing work for
6192 non-comment-starting XML files again (bug#9144).
6193
8d903f4e
AS
61942011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6195
6196 * image.c (gif_load): Fix calculation of bottom and right corner.
6197 (Bug#9468)
6198
80ad64f4
EZ
61992011-09-10 Eli Zaretskii <eliz@gnu.org>
6200
6201 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6202 redisplay in small windows.
6203
208a048d
EZ
62042011-09-09 Eli Zaretskii <eliz@gnu.org>
6205
6206 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6207
9b1c252e
MR
62082011-09-08 Martin Rudalics <rudalics@gmx.at>
6209
6210 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6211 Operate on live windows only.
6212
2949f33b
JB
62132011-09-08 Juanma Barranquero <lekktu@gmail.com>
6214
6215 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6216
e08dcafd
EZ
62172011-09-07 Eli Zaretskii <eliz@gnu.org>
6218
6219 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6220 only under bidi iteration.
6221
115b96bd
JD
62222011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6223
6224 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6225
c8199d0f
PE
62262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6227
6228 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6229 Without this fix, the command to link temacs failed due to an
6230 undefined symbol __builtin_isnan. This is because
6231 /usr/include/iso/math_c99.h #defines isnan(x) to
6232 __builtin_isnan(x), but the bundled gcc, which identifies itself
6233 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6234 a __builtin_isnan.
6235 * floatfns.c (isnan): #undef, and then #define to a clone of
6236 what's in data.c.
6237 (Fisnan): Always define, since it's always available now.
6238 (syms_of_floatfns): Always define isnan at the Lisp level.
6239
e39b275c 62402011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6241
6242 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6243
b2db44d9 62442011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6245
f4af5137 6246 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6247 The previous code assumed that file offsets (off_t values) fit in
6248 EMACS_INT variables, which is not true on typical 32-bit hosts.
6249 The code messed up by falsely reporting buffer overflow in cases
6250 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6251 when "big" contains more than 2**29 bytes, even though this
6252 inserts just one byte and does not overflow the buffer.
6253 (Finsert_file_contents): Store file offsets as off_t
6254 values, not as EMACS_INT values. Check for overflow when
6255 converting between EMACS_INT and off_t. When checking for
6256 buffer overflow or for overlap, take the offsets into account.
6257 Don't use EMACS_INT for small values where int suffices.
6258 When checking for overlap, fix a typo: ZV was used where
6259 ZV_BYTE was intended.
6260 (Fwrite_region): Don't assume off_t fits into 'long'.
6261 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6262
ecfc0a49
MA
62632011-09-05 Michael Albinus <michael.albinus@gmx.de>
6264
6265 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6266
6511acf2 62672011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6268
0999621a 6269 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6270
6271 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6272 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6273 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6274 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6275 (modify_event_symbol): Do not assume that the length of
6276 name_alist_or_stem is safe to alloca and fits in int.
6277 (Fexecute_extended_command): Likewise for function name and binding.
6278 (Frecursion_depth): Wrap around reliably on integer overflow.
6279 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6280 since some callers pass EMACS_INT values.
6281 (Fsingle_key_description): Don't crash if symbol name contains more
6282 than MAX_ALLOCA bytes.
6283 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6284 (get_minibuffer): Arg is now EMACS_INT, not int.
6285 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6286 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6287 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6288
2be7d702
PE
6289 * dbusbind.c (signature_cat): New function.
6290 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6291 Do not overrun buffer; instead, report string overflow.
6292
9d1df220
PE
6293 * dispnew.c (add_window_display_history): Don't overrun buffer.
6294 Truncate instead; this is OK since it's just a log.
6295
33ef5c64
PE
6296 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6297 even if the time zone offset is outlandishly large.
6298 Don't mishandle offset == INT_MIN.
6299
66c6fdd5
PE
6300 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6301 when creating daemon; the previous buffer-overflow check was incorrect.
6302
d749b01b
PE
6303 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6304 which has the guts of the old verror function.
6305
b5cd1905
PE
6306 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6307 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6308
6e1a67fb
PE
6309 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6310 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6311 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6312 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6313 length of string rather than counting it via multiple sprintfs;
6314 that's simpler and more reliable.
c21721cc
PE
6315 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6316 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6317 sprintf, in case result does not fit in int.
6318
c57b67fc
PE
6319 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6320 (fontset_from_font): Print it.
6321
8a401434
PE
6322 * frame.c (tty_frame_count): Now printmax_t, not int.
6323 (make_terminal_frame, set_term_frame_name): Print it.
6324 (x_report_frame_params): In X, window IDs are unsigned long,
6325 not signed long, so print them as unsigned.
6326 (validate_x_resource_name): Check for implausibly long names,
6327 and don't assume name length fits in 'int'.
6328 (x_get_resource_string): Don't blindly alloca invocation name;
6329 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6330 not fit in int.
6331
6e1a67fb
PE
6332 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6333 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6334 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6335
0df02bf3
PE
6336 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6337 Use esprintf, not sprintf, in case result does not fit in int.
6338
48e30793
PE
6339 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6340 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6341 it as a large positive number.
6342 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6343 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6344
a66ff6d8
PE
6345 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6346 in case result does not fit in int.
6347
aca216ff
PE
6348 * print.c (float_to_string): Detect width overflow more reliably.
6349 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6350 buffer overrun. Don't assume list length fits in 'int'. Treat
6351 print length of 0 as 0, not as infinity; to be consistent with other
6352 uses of print length in this function. Don't overflow print length
6353 index. Don't assume hash table size fits in 'long', or that
6354 vectorlike size fits in 'unsigned long'.
6355
31c286f7
PE
6356 * process.c (make_process): Use printmax_t, not int, to format
6357 process-name gensyms.
6358
55e5faa1
PE
6359 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6360
80f2e268
PE
6361 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6362 to avoid potential buffer overrun.
6363
670741ab
PE
6364 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6365 if X resource line is longer than 512 bytes.
6366
b7163a50
PE
6367 * xfns.c (x_window): Make sprintf buffer a bit bigger
6368 to avoid potential buffer overrun.
6369
ae58ff1f
PE
6370 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6371
c43c8a6a
PE
6372 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6373
3f8236f4
PE
63742011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6375
53e9fe90 6376 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6377 Without these, Emacs silently mishandles large integers sometimes.
6378 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6379 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6380
6511acf2
PE
6381 * xdisp.c (try_window_id): Check Emacs fixnum range before
6382 converting to 'int'.
806add1d 6383
6511acf2 6384 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6385 Check that an Emacs fixnum is in range before assigning it to 'int'.
6386 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6387 values converted from Emacs fixnums.
6388 (Frecenter): Don't wrap around a line count if it is out of 'int'
6389 range; instead, treat it as an extreme value.
6390 (Fset_window_configuration, compare_window_configurations):
6391 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6392
6511acf2
PE
6393 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6394 that can exceed INT_MAX. Check that EMACS_INT value is in range
6395 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6396 (match_limit): Don't assume that a fixnum can fit in 'int'.
6397
6511acf2 6398 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6399 exceed INT_MAX.
6400
6511acf2 6401 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6402 (Fvertical_motion): Don't wrap around LINES values that don't fit
6403 in 'int'. Instead, treat them as extreme values. This is good
6404 enough for windows, which can't have more than INT_MAX lines anyway.
6405
fcb901a7
LMI
64062011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6407
0f2f6b6d
LMI
6408 * Require libxml/parser.h to avoid compilation warning.
6409
fcb901a7
LMI
6410 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6411
6412 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6413 since this reportedly can destroy thread storage.
6414
6e20a0d4
CY
64152011-08-30 Chong Yidong <cyd@stupidchicken.com>
6416
6417 * syntax.c (find_defun_start): Update all cache variables if
6418 exiting early (Bug#9401).
6419
148ae00e
EZ
64202011-08-30 Eli Zaretskii <eliz@gnu.org>
6421
f6cfbd8f
EZ
6422 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6423
148ae00e
EZ
6424 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6425 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6426 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6427
6428 * term.c (tty_append_glyph): New function.
6429 (produce_stretch_glyph): Static function and its prototype deleted.
6430
a66cfb1c
SM
6431 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6432 Add prototypes.
148ae00e 6433
c4a07a4c
PE
64342011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6435
6436 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6437 when checking :margin (Bug#9390).
6438 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6439 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6440 so that the name doesn't mislead. All uses changed.
6441
6bc8cd65
JB
64422011-08-28 Johan Bockgård <bojohan@gnu.org>
6443
6444 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6445 set_tty_hooks.
6446
dca4927e
EZ
64472011-08-27 Eli Zaretskii <eliz@gnu.org>
6448
6449 * xdisp.c (move_it_to): Don't bail out early when reaching
6450 position beyond to_charpos, if we are scanning backwards.
6451 (move_it_vertically_backward): When DY == 0, make sure we get to
6452 the first character in the line after the newline.
6453
f2cad773
PE
64542011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6455
6456 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6457 (ccl_driver): Do not generate an out-of-range pointer.
6458 (Fccl_execute_on_string): Remove unnecessary check for
6459 integer overflow, noted by Stefan Monnier in
6460 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6461 Remove a FIXME that didn't need fixing.
6462 Simplify the newly-introduced buffer reallocation code.
6463
0cae2cdb
JB
64642011-08-27 Juanma Barranquero <lekktu@gmail.com>
6465
6466 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6467
5fc295a4 64682011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6469
70c60eb2 6470 Integer and memory overflow issues (Bug#9196).
726e0ab1 6471
d31850da
PE
6472 * doc.c (get_doc_string): Rework so that
6473 get_doc_string_buffer_size is the actual buffer size, rather than
6474 being 1 less than the actual buffer size; this makes xpalloc more
6475 convenient.
6476
a69fbedb
PE
6477 * image.c (x_allocate_bitmap_record, cache_image):
6478 * xselect.c (Fx_register_dnd_atom):
6479 Simplify previous changes by using xpalloc.
6480
fe5c5d37
PE
6481 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6482 since either will do and ptrdiff_t is convenient with xpalloc.
6483
0065d054
PE
6484 * charset.c (charset_table_size)
6485 (struct charset_sort_data.priority): Now ptrdiff_t.
6486 (charset_compare): Don't overflow if priorities differ greatly.
6487 (Fsort_charsets): Don't assume list length fits in int.
6488 Check for size-calculation overflow when allocating sort data.
6489 (syms_of_charset): Allocate an initial charset table that is
6490 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6491
6492 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6493
6494 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6495 The actual value is always <= INT_MAX, and leaving it unsigned made
6496 overflow checking harder.
6497
6498 * dispextern.h (struct glyph_matrix.rows_allocated)
6499 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6500 with xpalloc. The values are still always <= INT_MAX.
6501
6502 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6503
6504 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6505 (SAFE_NALLOCA): New macro.
6506
6507 * region-cache.c (struct boundary.pos, find_cache_boundary)
6508 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6509 (set_cache_region, invalidate_region_cache)
6510 (revalidate_region_cache, know_region_cache, region_cache_forward)
6511 (region_cache_backward, pp_cache):
6512 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6513 so that ptrdiff_t * can be passed to xpalloc.
6514 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6515 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6516 (pp_cache): Don't assume cache_len fits in int.
6517 * region-cache.h: Adjust extern decls to match.
6518
6519 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6520 EMACS_INT, since either will do, for xpalloc.
6521
6522 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6523 (xnmalloc, xnrealloc, xpalloc): New functions.
6524
726e0ab1
PE
6525 * bidi.c (bidi_shelve_header_size): New constant.
6526 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6527 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6528
51f30bc5 6529 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6530 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6531 (overlay_strings):
6532 Don't update size of array until after memory allocation succeeds,
6533 because xmalloc/xrealloc may not return.
0065d054
PE
6534 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6535 now that we have proper integer overflow checking.
6536 (record_overlay_string, overlay_strings): Catch overflows when
6537 calculating size of overlay_str_buf.
726e0ab1 6538
0065d054
PE
6539 * callproc.c (Fcall_process): Check for size overflow when
6540 calculating size of args2.
6541 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6542 Normally we prefer signed values, but sticking with ptrdiff_t would
6543 require adding more-complicated checks.
726e0ab1
PE
6544
6545 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6546 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6547 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6548 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6549
6550 * character.c (Fstring): Check for size-calculation overflow.
6551
6552 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6553 unnecessary integer overflow. Check for size overflow.
6554 (encode_coding_object): Don't update size until xmalloc succeeds.
6555
6556 * composite.c (get_composition_id): Check for overflow in glyph
6557 length calculations.
6558
6559 Integer and memory overflow fixes for display code.
6560 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6561 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6562 (scrolling_window): Check for overflow in size calculations.
6563 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6564 Don't assume glyph table len fits in int.
6565 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6566 (row_table_size): Now ptrdiff_t, not int.
6567 (scrolling_window): Avoid overflow in size calculations.
6568 Don't update size until allocation succeeds.
6569 * fns.c (concat): Check for overflow in size calculations.
6570 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6571 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6572 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6573
6574 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6575 (get_doc_string): Check for size calculation overflow.
6576 Don't update size until allocation succeeds.
6577 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6578 EMACS_INT, where ptrdiff_t will do.
6579 (Fsubstitute_command_keys): Check for string overflow.
6580
6581 * editfns.c (set_time_zone_rule): Don't assume environment length
6582 fits in int.
6583 (message_length): Now ptrdiff_t, not int.
6584 (Fmessage_box): Don't update size until allocation succeeds.
6585 Don't assume message length fits in int.
6586 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6587
0065d054
PE
6588 * emacs.c (main): Do not reallocate argv, since there is a null at
6589 the end that can be overwritten, and this way there's no need to
6590 worry about size-calculation overflow.
6591 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6592
6593 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6594 alloc succeeds.
6595 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6596
6597 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6598 (x_set_scroll_bar_width, x_figure_window_size):
6599 Check for integer overflow.
6600 (x_set_alpha): Do not assume XINT fits in int.
6601
6602 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6603 This is for the members text_lines, text_cols, total_lines, total_cols,
6604 where the system imposes an 'int' limit.
6605
6606 * fringe.c (Fdefine_fringe_bitmap):
6607 Don't update size until alloc works.
6608
6609 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6610 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6611
6612 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6613 Check for size-calculation overflow.
6614 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6615 do, as we prefer signed integers.
6616 (id_to_widget.max_size, id_to_widget.used)
6617 (xg_store_widget_in_map, xg_remove_widget_from_map)
6618 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6619 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6620 Use and return ptrdiff_t, not int.
6621 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6622 * gtkutil.h: Change prototypes to match the above.
6623
6624 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6625 are duplicate now that they've been promoted to lisp.h.
6626 (x_allocate_bitmap_record, x_alloc_image_color)
6627 (make_image_cache, cache_image, xpm_load):
6628 Don't update size until alloc is done.
6629 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6630 (x_detect_edges):
3256efce 6631 Check for size calculation overflow.
726e0ab1
PE
6632 (ct_colors_allocated_max): New constant.
6633 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6634 overflow.
3256efce 6635
726e0ab1
PE
6636 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6637 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6638 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6639 Use ptrdiff_t, not int, to count maps.
6640 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6641 calculations. Don't update size until allocation succeeds.
6642 Redo calculations to avoid overflow.
726e0ab1
PE
6643 * keyboard.h: Change prototypes to match the above.
6644
6645 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6646 to count maps.
6647 (current_minor_maps): Check for size calculation overflow.
6648 * keymap.h: Change prototypes to match the above.
6649
6650 * lread.c (read1, init_obarray): Don't update size until alloc done.
6651
6652 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6653 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6654
726e0ab1
PE
6655 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6656 Now ptrdiff_t, not int.
6657 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6658 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6659
6660 * process.c (Fnetwork_interface_list): Check for overflow
6661 in size calculation.
6662
6663 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6664
6665 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6666 overflow. Don't bother calling xmalloc when xrealloc will do.
6667
6668 * search.c (Freplace_match): Check for size calculation overflow.
6669 (Fset_match_data): Don't assume list lengths fit in 'int'.
6670
6671 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6672 for command line length. Do not attempt to address one before the
6673 beginning of an array, as that's not portable.
6674
6675 * term.c (max_frame_lines): Remove; unused.
6676 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6677 not int.
6678 (encode_terminal_code, calculate_costs): Check for size
6679 calculation overflow.
6680 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6681 table lengths and related sizes. Don't update size until alloc
6682 done. Redo calculations to avoid overflow.
6683 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6684
6685 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6686 subtracting pointers.
6687 (gobble_line): Check for overflow more carefully. Don't update size
6688 until alloc done.
6689
6690 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6691 Don't update size until alloc done.
6692 Redo size calculations to avoid overflow.
6693 Check for size calculation overflow.
0065d054 6694 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6695
6696 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6697 Use ptrdiff_t, not int, for sizes.
6698 (store_mode_line_noprop_char): Don't update size until alloc done.
6699
0065d054
PE
6700 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6701 Use ptrdiff_t, not int, for sizes.
6702 (Finternal_make_lisp_face, cache_face):
6703 Check for size calculation overflow.
6704 (cache_face): Treat size calculation overflows as if they were
6705 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6706
6707 * xfns.c (x_encode_text, x_set_name_internal)
6708 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6709 sizes, since they can exceed INT_MAX in size. Check for size
6710 calculation overflow.
6711
0065d054
PE
6712 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6713 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6714 Don't update size until alloc done.
6715
0065d054 6716 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6717 as sprintf is limited to int lengths.
1d526e2f 6718
252c5ee1
PE
6719 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6720 (X_LONG_MIN): New macros.
864d7ce7
PE
6721 Use them to make the following changes clearer.
6722 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6723 This change doesn't affect the value now, but it may help remind
6724 future maintainers not to raise the value too much later.
6725 (SELECTION_QUANTUM): Remove, replacing with ...
6726 (selection_quantum): ... new function, which avoids overflow.
6727 All uses changed.
6728 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6729 assumption that selection length fits in 'int'.
6730 (x_reply_selection_request, x_handle_selection_request)
6731 (x_get_window_property, receive_incremental_selection)
6732 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6733 (lisp_data_to_selection_data, clean_local_selection_data):
6734 Use ptrdiff_t, not int, to record length of selection.
6735 (x_reply_selection_request, x_get_window_property)
6736 (receive_incremental_selection, x_property_data_to_lisp):
6737 Redo calculations to avoid overflow.
6738 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6739 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6740 something.
6741 (x_get_window_property, receive_incremental_selection)
6742 (lisp_data_to_selection_data, x_property_data_to_lisp):
6743 Check for size-calculation overflow.
6744 (x_get_window_property, receive_incremental_selection)
6745 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6746 Don't store size until memory allocation succeeds.
6747 (x_get_window_property): Plug memory leak on memory exhaustion.
6748 Don't double-block input; malloc is safe here. Don't assume 2**34
6749 - 4 fits in unsigned long. Add an xassert to check
6750 XGetWindowProperty overflow. Be more careful about overflow
6751 calculations, and distinguish size from memory overflow better.
6752 (receive_incremental_selection): When tracing, don't assume
6753 unsigned int is less than INT_MAX.
6754 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6755 harmful) conversions of unsigned short to int.
6756 (lisp_data_to_selection_data): Don't assume that integers
6757 in the range -65535 through -1 fit in an X unsigned short.
6758 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6759 result parameters unless successful. Rely on cons_to_unsigned
6760 to report problems with elements; the old code wasn't right anyway.
6761 (x_check_property_data): Check for int overflow; we cannot use
6762 a wider type due to X limits.
6763 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6764
726e0ab1 6765 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6766
0065d054
PE
6767 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6768 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6769 (x_color_cells): Don't store size until memory allocation succeeds.
6770 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6771 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6772 (x_term_init): Don't assume length fits in int (sprintf is limited
6773 to int size).
bc18e09d 6774
ebfa62c0
PE
6775 Use ptrdiff_t for composition IDs.
6776 * character.c (lisp_string_width):
6777 * composite.c (composition_table_size, n_compositions)
6778 (get_composition_id, composition_gstring_from_id):
6779 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6780 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6781 * window.c (Frecenter):
6782 Use ptrdiff_t, not int, for composition IDs.
6783 * composite.c (get_composition_id): Check for integer overflow.
6784 * composite.h: Adjust prototypes to match the above changes.
6785
d3411f89
PE
6786 Use ptrdiff_t for hash table indexes.
6787 * category.c (hash_get_category_set):
6788 * ccl.c (ccl_driver):
6789 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6790 * coding.c (coding_system_charset_list, detect_coding_system):
6791 * coding.h (struct coding_system.id):
6792 * composite.c (get_composition_id, gstring_lookup_cache):
6793 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6794 * image.c (xpm_get_color_table_h):
6795 * lisp.h (hash_lookup, hash_put):
6796 * minibuf.c (Ftest_completion):
6797 Use ptrdiff_t for hash table indexes, not int (which is too
6798 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6799 32-bit --with-wide-int hosts).
6800
e097a6fa
PE
6801 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6802 Add a FIXME comment about memory leaks.
6803 (syms_of_charset): Don't assume xmalloc returns.
6804
5637687f
PE
6805 Don't assume that stated character widths fit in int.
6806 * character.c (Fchar_width, c_string_width, lisp_string_width):
6807 * character.h (CHAR_WIDTH):
6808 * indent.c (MULTIBYTE_BYTES_WIDTH):
6809 Use sanitize_char_width to avoid undefined and/or bad behavior
6810 with outlandish widths.
a66cfb1c 6811 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6812 now that we have two such functions. All uses changed.
6813 (sanitize_char_width): New inline function.
6814
a2271ba2
PE
6815 Don't assume that tab-width fits in int.
6816 * character.h (sanitize_width): New inline function.
6817 (SANE_TAB_WIDTH): New macro.
6818 (ASCII_CHAR_WIDTH): Use it.
6819 * indent.c (sane_tab_width): Remove. All uses replaced by
6820 SANE_TAB_WIDTH (current_buffer).
6821 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6822
18c52557
PE
6823 * fileio.c: Integer overflow issues with file modes.
6824 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6825
caeeedc1
PE
6826 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6827 Remove unreachable code.
6828 (read_hex, load_charset_map_from_file): Check for integer overflow.
6829
6df6ae42 6830 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6831 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6832 (x_send_scroll_bar_event): Likewise. Check that the size does not
6833 exceed limits imposed by XClientMessageEvent, as well as the usual
6834 ptrdiff_t and size_t limits.
6835
b13995db
PE
6836 * keyboard.c: Overflow, signedness and related fixes.
6837 (make_lispy_movement): Use same integer type in forward decl
6838 that is used in the definition.
6839 (read_key_sequence, keyremap_step):
6840 Change bufsize argument back to int, undoing my 2011-03-30 change.
6841 We prefer signed types, and int is wide enough here.
6842 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6843 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6844 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6845 length, not size_t. Use ptrdiff_t for index, not int.
6846 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6847 possibility of integer overflow.
6848
13464394
PE
6849 Overflow, signedness and related fixes for images.
6850
6851 * dispextern.h (struct it.stack[0].u.image.image_id)
6852 (struct_it.image_id, struct image.id, struct image_cache.size)
6853 (struct image_cache.used, struct image_cache.ref_count):
6854 * gtkutil.c (update_frame_tool_bar):
6855 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6856 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6857 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6858 * nsmenu.m (update_frame_tool_bar):
6859 * xdisp.c (calc_pixel_width_or_height):
6860 * xfns.c (image_cache_refcount):
6861 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6862 on typical 64-bit hosts.
6863
6864 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6865 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6866 Omit unnecessary casts to int.
6867 (parse_image_spec): Check that integers fall into 'int' range
6868 when the callers expect that.
6869 (image_ascent): Redo ascent calculation to avoid int overflow.
6870 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6871 (lookup_image): Remove unnecessary tests.
6872 (xbm_image_p): Locals are now of int, not EMACS_INT,
6873 since parse_image_check makes sure they fit into int.
6874 (png_load, gif_load, svg_load_image):
6875 Prefer int to unsigned where either will do.
6876 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6877 old tiff_error_handler and tiff_warning_handler.
6878 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6879 stack buffer overflows. It uses only the features of vsnprintf
6880 that are common to both POSIX and native Microsoft.
6881 (tiff_error_handler, tiff_warning_handler): Use it.
6882 (tiff_load, gif_load, imagemagick_load_image):
6883 Don't assume :index value fits in 'int'.
6884 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6885 (imagemagick_load_image): Check that crop parameters fit into
6886 the integer types that MagickCropImage accepts. Don't assume
6887 Vimagemagick_render_type has a nonnegative value. Don't assume
6888 size_t fits in 'long'.
6889 (gs_load): Use printmax_t to print the widest integers possible.
6890 Check for integer overflow when computing image height and width.
6891
c11821d4
EZ
68922011-08-26 Eli Zaretskii <eliz@gnu.org>
6893
6894 * xdisp.c (redisplay_window): Don't force window start if point
6895 will be invisible in the resulting window. (Bug#9324)
6896
0c95fcf7
EZ
68972011-08-25 Eli Zaretskii <eliz@gnu.org>
6898
6899 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6900 the display spec is of the form `(space ...)'.
6901 (handle_display_spec): Return the value returned by
6902 handle_single_display_spec, not just 1 or zero.
6903 (handle_single_display_spec): If the display spec is of the form
6904 `(space ...)', and specifies display in the text area, return 2
6905 rather than 1.
fee65a97 6906 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6907 accurately, and prefer exact match for point under bidi.
6908 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6909
6910 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6911 into disp_prop; all users changed.
6912
6913 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6914 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6915 for the text covered by the display property.
6916
e4ed06f1
CY
69172011-08-25 Chong Yidong <cyd@stupidchicken.com>
6918
6919 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6920 Change return value to nil.
6921 (Frecord_buffer): Delete unused function.
6922
f67cdd7f
EZ
69232011-08-24 Eli Zaretskii <eliz@gnu.org>
6924
5980d4c6
EZ
6925 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6926 buffers, return left-to-right.
8610fe8b
EZ
6927 (set_cursor_from_row): Consider candidate row a win if its glyph
6928 represents a newline and point is on that newline. Fixes cursor
6929 positioning on the newline at EOL of R2L text within L2R
6930 paragraph, and vice versa.
6931 (try_cursor_movement): Check continued rows, in addition to
6932 continuation rows. Fixes unwarranted scroll when point enters a
6933 continued line of R2L text within an L2R paragraph, or vice versa.
6934 (cursor_row_p): Consider the case of point being equal to
6935 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6936 from the end of a short line to the beginning of a continued line
6937 of R2L text within L2R paragraph.
6938 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6939 composed characters.
5980d4c6 6940
f67cdd7f
EZ
6941 * bidi.c (bidi_check_type): Use xassert.
6942 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6943 members.
6944
bca633fb
EZ
69452011-08-23 Eli Zaretskii <eliz@gnu.org>
6946
6947 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6948 a character.
6949
4a5885a7
CY
69502011-08-23 Chong Yidong <cyd@stupidchicken.com>
6951
6952 * nsfont.m (ns_otf_to_script): Fix typo.
6953
0902a04e
KH
69542011-08-22 Kenichi Handa <handa@m17n.org>
6955
6956 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6957 extra slot even if the purpose is char-code-property-table.
6958
1a2e6670
EZ
69592011-08-23 Eli Zaretskii <eliz@gnu.org>
6960
8ddde651
EZ
6961 * xdisp.c (redisplay_window): When computing centering_position,
6962 account for the height of the header line. (Bug#8874)
6963
425cc014
EZ
6964 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6965 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6966 candidate is selected by the mouse, and that candidate has a
6967 composed character under the mouse.
6968
1a2e6670
EZ
6969 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6970 coordinates reported by pos-visible-in-window-p for a composed
6971 character in column zero.
6972
8b76d6f8
SM
69732011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6974
6975 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6976
dac347dd
EZ
69772011-08-22 Eli Zaretskii <eliz@gnu.org>
6978
6979 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6980 consider it a hit if to_charpos is anywhere in the range of the
6981 composed buffer positions.
6982
e013fb34
CY
69832011-08-22 Chong Yidong <cyd@stupidchicken.com>
6984
6985 * image.c (gif_load): Don't assume that each subimage has the same
6986 dimensions as the base image. Handle disposal method that is
6987 "undefined" by the gif spec (Bug#9335).
6988
bd1ba3e8
CY
69892011-08-20 Chong Yidong <cyd@stupidchicken.com>
6990
6991 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6992 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6993
54a1215b
EZ
69942011-08-19 Eli Zaretskii <eliz@gnu.org>
6995
823564e5
EZ
6996 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6997 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6998 from an Org mode buffer to a Speedbar frame.
6999
54a1215b
EZ
7000 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7001 a composition, take its buffer position from IT->cmp_it.charpos.
7002 Fixes cursor positioning at the beginning of a line that begins
7003 with a composed character.
7004
9778ebcc
EZ
70052011-08-18 Eli Zaretskii <eliz@gnu.org>
7006
0be6ee06
EZ
7007 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7008 character bidirectional type, use STRONG_L instead. Fixes crashes
7009 in a buffer produced by `describe-categories'.
7010
9778ebcc
EZ
7011 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7012 members before the level stack, so they would be saved and
7013 restored when copying iterator state. Fixes incorrect reordering
7014 around TABs covered by display properties.
7015
156bffbe
AS
70162011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7017
6b02f655 7018 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7019
72ad093b
CY
70202011-08-17 Chong Yidong <cyd@stupidchicken.com>
7021
7022 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7023 (internal_condition_case_2, internal_condition_case_n):
7024 Remove unnecessary aborts (Bug#9081).
72ad093b 7025
35774242
EZ
70262011-08-17 Eli Zaretskii <eliz@gnu.org>
7027
7028 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7029 has no `load' handler, try opening the file locally. (Bug#9311)
7030
db76dd85
KB
70312011-08-16 Ken Brown <kbrown@cornell.edu>
7032
7033 * gmalloc.c: Expand comment.
7034
b215eee5
EZ
70352011-08-16 Eli Zaretskii <eliz@gnu.org>
7036
7037 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7038 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7039
a4579d33
KB
70402011-08-16 Ken Brown <kbrown@cornell.edu>
7041
7042 Fix memory allocation problems in Cygwin build (Bug#9273).
7043
7044 * unexcw.c ( __malloc_initialized): Declare external variable.
7045 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7046
8b76d6f8
SM
7047 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7048 New variables.
a4579d33
KB
7049 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7050 dumped emacs.
7051 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7052 in the static heap.
7053 [CYGWIN] (special_realloc): New function.
7054 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7055 requests to realloc storage in the static heap.
7056
3ebec551
PE
70572011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7058
7059 * bidi.c (bidi_initialize): Remove unused local.
7060
9fd8be00
EZ
70612011-08-15 Eli Zaretskii <eliz@gnu.org>
7062
6b02f655
SM
7063 * bidimirror.h:
7064 * biditype.h: Remove file.
7065 * makefile.w32-in ($(BLD)/bidi.$(O)):
7066 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7067
7068 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7069
7070 * chartab.c: Improve commentary for the uniprop_table API.
7071
32413314
EZ
7072 * bidi.c (bidi_paragraph_init): Support zero value of
7073 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7074 (bidi_initialize): Use uniprop_table instead of including
7075 biditype.h and bidimirror.h.
32413314 7076
9fd8be00
EZ
7077 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7078 coordinates of the iterator when restoring from ppos_it.
7079 (Bug#9296)
7080
5cf2b69b
KH
70812011-08-14 Kenichi Handa <handa@m17n.org>
7082
7083 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7084 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7085
daf17d00
EZ
70862011-08-14 Eli Zaretskii <eliz@gnu.org>
7087
7088 * xdisp.c (move_it_in_display_line_to): Don't invoke
7089 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7090 ppos_it. Fixes vertical cursor motion when line beginning is
7091 covered by an image. (Bug#9296)
7092
08e3161a
JD
70932011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7094
7095 * nsterm.h (ns_run_ascript): Declare.
7096 (NSAPP_DATA2_RUNASSCRIPT): Define.
7097
7098 * nsfns.m (as_script, as_result, as_status): New static variables.
7099 (ns_run_ascript): New function.
5e617bc2 7100 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7101 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7102 the event loop. Get status from as_status (Bug#7276).
7103
7104 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7105 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7106 the event loop (Bug#7276).
7107
a3720aa2
AS
71082011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7109
7110 * gnutls.c (QCgnutls_bootprop_priority)
7111 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7112 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7113 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7114 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7115 (QCgnutls_bootprop_verify_hostname_error)
7116 (QCgnutls_bootprop_callbacks_verify): Rename from
7117 Qgnutls_bootprop_..., all uses changed.
7118
7119 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7120 uses changed.
7121
0a0d27fb
PE
71222011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7123
19d5c50c
PE
7124 * xfaces.c (Qframe_set_background_mode): Now static.
7125 * dispextern.h (Qframe_set_background_mode): Remove decl.
7126
0a0d27fb
PE
7127 * process.c (Fnetwork_interface_info): Declare local only if needed.
7128
377538cb
JD
71292011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7130
7131 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7132 (Fnetwork_interface_list): Allocate in increments of bytes instead
7133 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7134 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7135 sockaddr.
7136 (struct ifflag_def): notrailers is smart on OSX.
7137 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7138 Get hardware address with getifaddrs if available.
7139
08fff70c
EZ
71402011-08-12 Eli Zaretskii <eliz@gnu.org>
7141
7142 * xdisp.c (iterate_out_of_display_property): xassert that
7143 IT->position is set to within IT->object's boundaries. Break from
7144 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7145 when IT->position is set up wrongly due to some bug.
7146 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7147 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7148 entry. Force push_it to save on the stack the current
7149 buffer/string position, to be restored by pop_it. Fix flags in
7150 the iterator structure wrt the object coming from a display
7151 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7152 properties. (Bug#9284)
7153
7be1c708 71542011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7155
7be1c708
CY
7156 * fontset.c (fontset_get_font_group): Add proper type checks.
7157 (Bug#9172)
aac0c6e3 7158
7be1c708 71592011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7160
7be1c708
CY
7161 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7162 and LC_VERSION_MIN_MACOSX.
7163 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7164 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7165
97bb72a6
EZ
71662011-08-08 Eli Zaretskii <eliz@gnu.org>
7167
7168 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7169 no-display-properties-and-no-overlays under bidi display.
7170 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7171 properties and overlays.
97bb72a6 7172
d5617611
CY
71732011-08-08 Chong Yidong <cyd@stupidchicken.com>
7174
37e11a63
CY
7175 * editfns.c (Fset_time_zone_rule): Document relationship with the
7176 setenv function.
7177
d5617611
CY
7178 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7179 the font entity extracted from the cache (Bug#8109).
7180
58872834
CY
71812011-08-07 Chong Yidong <cyd@stupidchicken.com>
7182
7183 * composite.c (autocmp_chars): Don't reset point. That is done by
7184 restore_point_unwind (Bug#5984).
7185
75bfc667
JL
71862011-08-07 Juri Linkov <juri@jurta.org>
7187
7188 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7189 to show the arg `TIME' instead of `TIMEVAL'.
7190
d1410150
EZ
71912011-08-06 Eli Zaretskii <eliz@gnu.org>
7192
7193 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7194 display property strides EOL and includes a newline, as in
7195 longlines-mode. (Bug#9254)
75b771e4
EZ
7196 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7197 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7198
7199 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7200 is non-zero, even if the data buffer is NULL. Fixes a crash in
7201 vertical-motion with longlines-mode. (Bug#9254)
7202
35928349
EZ
72032011-08-05 Eli Zaretskii <eliz@gnu.org>
7204
ec7cc85b
EZ
7205 * bidi.c <bidi_cache_total_alloc>: Now static.
7206 (bidi_initialize): Initialize bidi_cache_total_alloc.
7207
8b76d6f8 7208 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7209 cache. (Bug#9221)
7210
7211 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7212 amount allocated this far in `bidi_cache_total_alloc'.
7213 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7214 non-zero, only free the data buffer without restoring the cache
7215 contents. All callers changed.
7216
7217 * dispextern.h (bidi_unshelve_cache): Update prototype.
7218
7219 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7220 (move_it_in_display_line, move_it_to)
7221 (move_it_vertically_backward, move_it_by_lines): Replace the call
7222 to xfree to an equivalent call to bidi_unshelve_cache.
7223 (move_it_in_display_line_to): Fix logic of returning
412b6358 7224 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7225
e2e2423b
EZ
72262011-08-05 Eli Zaretskii <eliz@gnu.org>
7227
7228 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7229 came from a string character with a `cursor' property. (Bug#9229)
7230
ae9e757a
JD
72312011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7232
7233 * Makefile.in (LIB_PTHREAD): New variable.
7234 (LIBES): Add LIB_PTHREAD (Bug#9216).
7235
7236 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7237 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7238
213bd7f2
AS
72392011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7240
6b02f655 7241 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7242
99aaf75f
JD
72432011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7244
7245 * xterm.c (x_find_topmost_parent): New function.
7246 (x_set_frame_alpha): Find topmost parent window with
7247 x_find_topmost_parent and set the property there also (bug#9181).
7248 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7249
c74e9d86
PE
72502011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7251
7252 * callproc.c (Fcall_process): Avoid vfork clobbering
7253 the local vars buffer, coding_systems, current_dir.
7254
640c8776
SM
72552011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7256
7257 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7258
f26d0e4c
PE
72592011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7260
8a10d76c
PE
7261 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7262 so that it is not optimized away.
7263
f26d0e4c
PE
7264 * xdisp.c (compute_display_string_pos): Remove unused local.
7265
55439c61
EZ
72662011-08-02 Eli Zaretskii <eliz@gnu.org>
7267
7268 Fix slow cursor motion and scrolling in large buffers with
7269 selective display, like Org Mode buffers. (Bug#9218)
7270
7271 * dispextern.h (struct bidi_it): New member disp_prop_p.
7272
7273 * xdisp.c: Remove one-slot cache of display string positions.
7274 (compute_display_string_pos): Accept an additional argument
5e617bc2 7275 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7276 for a display string or property. If found, set DISP_PROP_P
7277 non-zero.
7278
7279 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7280 DISP_PROP_P, and pass it to compute_display_string_pos.
7281 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7282 non-zero. All callers of bidi_fetch_char changed.
7283
fb33fa43
SM
72842011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7285
7286 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7287
b099e063
DM
72882010-12-03 Don March <don@ohspite.net>
7289
7290 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7291 last character M-[char] is translated to ESC [char] (bug#7541).
7292
5cc7f7af
KH
72932011-08-02 Kenichi Handa <handa@m17n.org>
7294
d0fffa3f 7295 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7296
7297 * chartab.c (uniprop_table): Make it non-static.
7298
525d5e6e
EZ
72992011-08-01 Eli Zaretskii <eliz@gnu.org>
7300
7301 * xdisp.c (forward_to_next_line_start): Accept additional argument
7302 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7303 on the newline.
7304 (reseat_at_next_visible_line_start): Use the bidi iterator state
7305 returned by forward_to_next_line_start to restore the state of
7306 it->bidi_it after backing up to previous newline. (Bug#9212)
7307
31011111
AS
73082011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7309
7310 * regex.c (re_comp): Protoize.
7311 (re_exec): Fix return type.
7312 (regexec): Fix type of `ret'. (Bug#9203)
7313
476371c4
PE
73142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7315
e5d76069
PE
7316 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7317 This is needed if max-image-size is a floating-point number.
7318
9a79b20c
AS
73192011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7320
7321 * print.c (print_object): Print empty symbol as ##.
7322
7323 * lread.c (read1): Read ## as empty symbol.
7324
d8c2fa78
AA
73252011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7326
7327 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7328 setting frame foreground color (Bug#9175).
7329 (x_set_background_color): Likewise.
7330
ffe57a7a
AA
7331 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7332 contents (Bug#9176).
7333 (EmacsTooltip -init): Remove bezels and add shadows to
7334 tooltip windows.
7335
bf3492a5
AA
7336 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7337 or scroll bar (Bug#8470).
7338
d55e9c53
AA
7339 * nsfont.m (nsfont_open): Remove assignment to voffset and
7340 unnecessary vars hshink, expand, hd, full_height, min_height.
7341 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7342
7343 * nsterm.h (nsfont_info): Remove voffset field.
7344
d8c2fa78 73452011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7346
7347 Implement strike-through and overline on NextStep (Bug#8863).
7348
7349 * nsfont.m (nsfont_open): Use underline position provided by font,
7350 instead of hard-coded value of 2.
7351 (nsfont_draw): Call ns_draw_text_decoration instead.
7352
7353 * nsterm.h: Add declaration for ns_draw_text_decoration.
7354
7355 * nsterm.m (ns_draw_text_decoration): New function for drawing
7356 underline, overline, and strike-through.
7357 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7358 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7359 accommodate underlining, etc.
4843aac3 7360
4cc60b9b
EZ
73612011-07-28 Eli Zaretskii <eliz@gnu.org>
7362
bc7ece87
EZ
7363 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7364 default.
4cc60b9b 7365
476371c4
PE
73662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7367
66606eea
PE
7368 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7369 Without this fix, if a signal arrives just after memory fills up,
7370 'malloc' might be invoked reentrantly.
7371
476371c4
PE
7372 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7373 In other words, assume that every image size is allowed, on non-X
7374 hosts. This assumption is probably wrong, but it lets Emacs compile.
7375
f3fcc40d
AS
73762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7377
7378 * regex.c (re_iswctype): Convert return values to boolean.
7379
350c992f
EZ
73802011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7381
7382 * xdisp.c (compute_display_string_pos): Don't use cached display
7383 string position if the buffer had its restriction changed.
7384 (Bug#9184)
7385
5266b4bb
PE
73862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7387
7388 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7389
2573a837 73902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7391
41f55ccd 7392 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7393
39e378da
PE
7394 * bidi.c: Integer size and overflow fixes.
7395 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7396 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7397 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7398 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7399 (bidi_find_other_level_edge):
7400 Use ptrdiff_t instead of EMACS_INT where either will do.
7401 This works better on 32-bit hosts configured --with-wide-int.
7402 (bidi_cache_ensure_space): Check for size-calculation overflow.
7403 Use % rather than repeated addition, for better worst-case speed.
7404 Don't set bidi_cache_size until after xrealloc returns, because it
7405 might not return.
7406 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7407 (bidi_cache_ensure_space): Also check that the bidi cache size
7408 does not exceed that of the largest Lisp string or buffer. See Eli
7409 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7410
5e927815
PE
7411 * alloc.c (__malloc_size_t): Remove.
7412 All uses replaced by size_t. See Andreas Schwab's note
7413 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7414
ca4aa935
PE
7415 * image.c: Improve checking for integer overflow.
7416 (check_image_size): Assume that f is nonnull, since
7417 it is always nonnull in practice. This is one less thing to
7418 worry about when checking for integer overflow later.
7419 (x_check_image_size): New function, which checks for integer
7420 overflow issues inside X.
7421 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7422 This removes the need for a memory_full check.
7423 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7424 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7425 (xbm_read_bitmap_data): Change locals back to 'int', since
7426 their values must fit in 'int'.
7427 (xpm_load_image, png_load, tiff_load):
7428 Invoke x_create_x_image_and_pixmap earlier,
7429 to avoid much needless work if the image is too large.
7430 (tiff_load): Treat overly large images as if
7431 x_create_x_image_and_pixmap failed, not as malloc failures.
7432 (gs_load): Use x_check_image_size.
7433
5f8f9cc2
PE
7434 * gtkutil.c: Omit integer casts.
7435 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7436 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7437
5adf60bc
PE
7438 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7439
c8907a93
PE
7440 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7441 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7442 would wrongly return t on a 64-bit host.
7443
e3c25c68
PE
7444 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7445 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7446 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7447 and therefore cause GCC to emit a bogus diagnostic in some cases.
7448
3f791afe
PE
7449 * image.c: Integer signedness and overflow and related fixes.
7450 This is not an exhaustive set of fixes, but it's time to
7451 record what I've got.
7452 (lookup_pixel_color, check_image_size): Remove redundant decls.
7453 (check_image_size): Don't assume that arbitrary EMACS_INT values
7454 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7455 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7456 (tiff_load, imagemagick_load_image):
7457 Check for overflow in size calculations.
7458 (x_create_x_image_and_pixmap): Remove unnecessary test for
7459 xmalloc returning NULL; that can't happen.
7460 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7461 (xpm_color_bucket): Use better integer hashing function.
7462 (xpm_cache_color): Don't possibly over-allocate memory.
7463 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7464 (gif_memory_source):
7465 Use ptrdiff_t, not int or size_t, to record sizes.
7466 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7467 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7468 either works, as we prefer signed integers.
7469 (tiff_read_from_memory, tiff_write_from_memory):
7470 Return tsize_t, not size_t, since that's what the TIFF API wants.
7471 (tiff_read_from_memory): Don't fail simply because the read would
7472 go past EOF; instead, return a short read.
7473 (tiff_load): Omit no-longer-needed casts.
7474 (Fimagemagick_types): Don't assume size fits into 'int'.
7475
3cc5a532
PE
7476 Improve hashing quality when configured --with-wide-int.
7477 * fns.c (hash_string): New function, taken from sxhash_string.
7478 Do not discard information about ASCII character case; this
7479 discarding is no longer needed.
7480 (sxhash-string): Use it. Change sig to match it. Caller changed.
7481 * lisp.h: Declare it.
7482 * lread.c (hash_string): Remove, since we now use fns.c's version.
7483 The fns.c version returns a wider integer if --with-wide-int is
7484 specified, so this should help the quality of the hashing a bit.
7485
b312a492
PE
7486 * emacs.c: Integer overflow minor fix.
7487 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7488 Define only if GNU_LINUX.
7489 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7490
dfd153ae
PE
7491 * dispnew.c: Integer signedness and overflow fixes.
7492 Remove unnecessary forward decls, that were a maintenance hassle.
7493 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7494 All uses changed.
7495 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7496 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7497 (prepare_desired_row, line_draw_cost):
7498 Use int, not unsigned, where either works.
7499 (save_current_matrix, restore_current_matrix):
7500 Use ptrdiff_t, not size_t, where either works.
7501 (init_display): Check for overflow more accurately, and without
7502 relying on undefined behavior.
7503
a81d11a3
PE
7504 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7505 Remove, replacing with the new symbols in lisp.h. All uses changed.
7506 * fileio.c (make_temp_name):
7507 * filelock.c (lock_file_1, lock_file):
7508 * xdisp.c (message_dolog):
7509 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7510 Use pMd etc. instead.
7511 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7512 replacing the pWIDE etc. symbols removed from editfns.c.
7513
3300e6fd
PE
7514 * keyboard.h (num_input_events): Now uintmax_t.
7515 This is (very slightly) less likely to mess up due to wraparound.
7516 All uses changed.
7517
fd05c7e9
PE
7518 * buffer.c: Integer signedness fixes.
7519 (alloc_buffer_text, enlarge_buffer_text):
7520 Use ptrdiff_t rather than size_t when either will do, as we prefer
7521 signed integers.
7522
903fe15d
PE
7523 * alloc.c: Integer signedness and overflow fixes.
7524 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7525 (__malloc_size_t): Default to size_t, not to int.
7526 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7527 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7528 Prefer ptrdiff_t to size_t when either would do, as we prefer
7529 signed integers.
7530 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7531 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7532 Now const. Initialize with values that are in range even if char
7533 is signed.
7534 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7535 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7536 These functions do the right thing with sizes > 2**32.
7537 (check_depth): Now ptrdiff_t, not int.
7538 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7539 Adjust to new way of storing sizes. Check for size overflow bugs
7540 in rest of code.
7541 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7542 slightly wrong anyway, as it missed one instance of
7543 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7544 (refill_memory_reserve): Omit needless cast to size_t.
7545 (mark_object_loop_halt): Mark as externally visible.
7546
ac82cc6a
PE
7547 * xselect.c: Integer signedness and overflow fixes.
7548 (Fx_register_dnd_atom, x_handle_dnd_message):
7549 Use ptrdiff_t, not size_t, since we prefer signed.
7550 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7551 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7552 x_dnd_atoms_size and x_dnd_atoms_length.
7553
c2d1e36d
PE
7554 * doprnt.c: Prefer signed to unsigned when either works.
7555 * eval.c (verror):
7556 * doprnt.c (doprnt):
7557 * lisp.h (doprnt):
7558 * xdisp.c (vmessage):
7559 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7560 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7561 prefer signed arithmetic to avoid comparison confusion.
7562 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7563 but is a bit tricky.
7564
0e926e56
PE
7565 Assume freestanding C89 headers, string.h, stdlib.h.
7566 * data.c, doprnt.c, floatfns.c, print.c:
7567 Include float.h unconditionally.
7568 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7569 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7570 * regex.c: Likewise for stddef.h, string.h.
7571 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7572 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7573 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7574 (STDC_HEADERS): Remove obsolete defines.
7575 * sysdep.c: Include limits.h unconditionally.
7576
9cfdb3ec
PE
7577 Assume support for memcmp, memcpy, memmove, memset.
7578 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7579 * regex.c (memcmp, memcpy):
7580 Remove; we assume C89 now.
7581
7582 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7583 (__malloc_safe_bcopy): Remove; no longer needed.
7584
cf950e6b 7585 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7586 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7587 well either way, and we prefer signed to unsigned.
7588
dbf38e02
LMI
75892011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7590
7591 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7592 closes the connection while we're reading (bug#9182).
7593
d6f0886c 75942011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7595
d6f0886c
JD
7596 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7597 are specified (Bug#9168).
24e0f6b1 7598
2eb1f9e6
PE
75992011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7600
7601 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7602 Found by GCC static checking and --with-wide-int on a 32-bit host.
7603
22381272 76042011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7605
7606 * xdisp.c (compute_display_string_pos): Fix logic of caching
7607 previous display string position. Initialize cached_prev_pos to
7608 -1. Fixes slow-down at the beginning of a buffer.
7609
f25e39b4
EZ
76102011-07-24 Eli Zaretskii <eliz@gnu.org>
7611
7612 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7613 for attrs[LFACE_FONTSET_INDEX].
7614
04c4b52e
PE
76152011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7616
7617 * xml.c (parse_region): Remove unused local
7618 that was recently introduced.
7619
c1734fbd
EZ
76202011-07-23 Eli Zaretskii <eliz@gnu.org>
7621
be18c5a5
EZ
7622 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7623 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7624
c1734fbd
EZ
7625 * xdisp.c (move_it_in_display_line_to): Record the best matching
7626 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7627 exit if none of the characters scanned was an exact match.
7628 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7629 when exact match is impossible due to invisible text, and the
7630 lines are truncated.
7631
a258d627
JD
76322011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7633
7634 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7635 for OSX >= 10.7.
7636
b6d5a689
EZ
76372011-07-22 Eli Zaretskii <eliz@gnu.org>
7638
0f74f785
EZ
7639 Fix a significant slow-down of cursor motion with C-n, C-p,
7640 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7641 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7642 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7643 (next_element_from_buffer): Call compute_stop_pos_backwards to
7644 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7645 base_level_stop.
7646 (reseat): Don't look for prev_stop, as that could mean a very long
7647 run.
7648 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7649 <cached_disp_overlay_modiff>: Cache for last found display string
7650 position.
551918c1 7651 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7652 about the same buffer in the same area of character positions, and
7653 the buffer wasn't changed since the time the display string
7654 position was cached.
551918c1 7655
b2d0c91a
EZ
76562011-07-22 Eli Zaretskii <eliz@gnu.org>
7657
7658 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7659 is an integer, which is important for empty lines. (Bug#9149)
7660
043604ee
CY
76612011-07-22 Chong Yidong <cyd@stupidchicken.com>
7662
7663 * frame.c (Fmodify_frame_parameters): In tty case, update the
7664 default face if necessary (Bug#4238).
7665
da4adb04
CY
76662011-07-21 Chong Yidong <cyd@stupidchicken.com>
7667
7668 * editfns.c (Fstring_to_char): No need to explain what a character
7669 is in the docstring (Bug#6576).
7670
9abd0532
LMI
76712011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7672
7673 * xml.c (parse_region): Make sure we always return a tree.
7674
36881d16
HK
76752011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7676
7677 * xml.c (parse_region): If a document contains only comments,
7678 return that, too.
7679
1e98674d
LMI
76802011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7681
7682 * xml.c (make_dom): Return comments, too.
7683
590bd467
PE
76842011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7685
7686 Port to OpenBSD.
7687 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7688 and the surrounding thread.
7689 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7690 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7691 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7692 timer goes off.
7693 * s/openbsd.h (BROKEN_SIGIO): Define.
7694 * unexelf.c (unexec) [__OpenBSD__]:
7695 Don't update the .mdebug section of the Alpha COFF symbol table.
7696
f41628b2
LMI
76972011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7698
7699 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7700 (bug#8460).
7701
b59b67c5
PE
77022011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7703
15e3a074
PE
7704 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7705 This fixes some race conditions on the permissions of any newly
7706 created file.
7707
41bed37d
PE
7708 * alloc.c (valid_pointer_p): Use pipe, not open.
7709 This fixes some permissions issues when debugging.
7710
b59b67c5
PE
7711 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7712 If fchown fails to set both uid and gid, try to set just gid,
7713 as that is sometimes allowed. Adjust the file's mode to eliminate
7714 setuid or setgid bits that are inappropriate if fchown fails.
7715
925a6be7
SM
77162011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7717
7718 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7719 to compare Lisp_Objects.
7720 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7721 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7722 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7723
52968808
AS
77242011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7725
0a6a104b
AS
7726 * lread.c (read_integer): Unread even EOF character.
7727 (read1): Likewise. Properly record start position of symbol.
7728
52968808
AS
7729 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7730 symbol character follows.
7731
9e381cdd
PE
77322011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7733
7734 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7735 This works around a problem with the previous change to Fcopy_file.
7736 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7737 and without this change, GCC might complain about discarding
7738 fchown's return value.
7739
b5641435
JB
77402011-07-16 Juanma Barranquero <lekktu@gmail.com>
7741
7742 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7743
a8031457
PE
77442011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7745
7746 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7747
dd889327
LMI
77482011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7749
750c33f7
LMI
7750 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7751 it's used from the C level.
7752
dd889327
LMI
7753 * process.c: Use the same condition for POLL_FOR_INPUT in both
7754 keyboard.c and process.c (bug#1858).
7755
87e86684
LM
77562011-07-09 Lawrence Mitchell <wence@gmx.li>
7757
7758 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7759 (Fgnutls_boot): Use it.
7760
64348f40
AS
77612011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7762
7763 * doc.c (Fsubstitute_command_keys): Revert last change.
7764
1d698799
LMI
77652011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7766
f863868c
LMI
7767 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7768 quotes the next character, and doesn't affect other longer
7769 sequences (bug#8935).
7770
1d698799
LMI
7771 * lread.c (syms_of_lread): Clarify that is isn't only
7772 `eval-buffer' and `eval-defun' that's affected by
7773 `lexical-binding' (bug#8460).
7774
aa4b6df6
EZ
77752011-07-15 Eli Zaretskii <eliz@gnu.org>
7776
7777 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7778 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7779
5d856da6
PE
77802011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7781
ad6042bb
PE
7782 Fix minor problems found by static checking.
7783 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7784 (elsz): Now a signed constant, not a size_t var. We prefer signed
7785 types to unsigned, to avoid integer comparison confusion. Without
7786 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7787 "cannot optimize loop, the loop counter may overflow", a symptom
7788 of the confusion.
f00bbb22 7789 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7790 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7791
6468f31c
LMI
77922011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7793
49080b10
LMI
7794 * search.c (Fre_search_backward): Mention `case-fold-search' in
7795 all the re_search_* functions (bug#8138).
7796
6468f31c
LMI
7797 * keyboard.c (Fopen_dribble_file): Document when the file is
7798 closed (bug#8056).
7799
c965adc5
EZ
78002011-07-14 Eli Zaretskii <eliz@gnu.org>
7801
df9733bf
EZ
7802 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7803 bidi_cache_idx.
7804
0bb23927
EZ
7805 Support bidi reordering of display and overlay strings.
7806 * xdisp.c (compute_display_string_pos)
7807 (compute_display_string_end): Accept additional argument STRING.
7808 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7809 (reseat_to_string): Initialize bidi_it->string.s and
7810 bidi_it->string.schars.
7811 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7812 NULL (avoids a crash in bidi_paragraph_init).
7813 Initialize itb.string.lstring.
0bb23927
EZ
7814 (init_iterator): Call bidi_init_it only of a valid
7815 buffer position was specified. Initialize paragraph_embedding to
7816 L2R.
7817 (reseat_to_string): Initialize the bidi iterator.
7818 (display_string): If we need to ignore text properties of
7819 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7820 original value of -1 will not work with bidi.)
7821 (compute_display_string_pos): First arg is now struct
7822 `text_pos *'; all callers changed. Support display properties on
7823 Lisp strings.
7824 (compute_display_string_end): Support display properties on Lisp
7825 strings.
7826 (init_iterator, reseat_1, reseat_to_string): Initialize the
7827 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7828 when iterating on a string not from display properties).
640c8776
SM
7829 (compute_display_string_pos, compute_display_string_end):
7830 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7831 arrow keys.
7832 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7833 base_level_stop; instead, set base_level_stop to BEGV.
7834 Fixes crashes in vertical-motion.
0bb23927
EZ
7835 (next_element_from_buffer): Improve commentary for when
7836 the iterator is before prev_stop.
7837 (init_iterator): Initialize bidi_p from the default value of
7838 bidi-display-reordering, not from buffer-local value. Use the
7839 buffer-local value only if initializing for buffer iteration.
7840 (handle_invisible_prop): Support invisible properties on strings
7841 that are being bidi-reordered.
7842 (set_iterator_to_next): Support bidi reordering of C strings and
7843 Lisp strings.
7844 (next_element_from_string): Support bidi reordering of Lisp
7845 strings.
7846 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7847 (display_string): Support display of R2L glyph rows.
7848 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7849 (init_iterator): Don't initialize it->bidi_p for strings
7850 here.
7851 (reseat_to_string): Initialize it->bidi_p for strings here.
7852 (next_element_from_string, next_element_from_c_string)
7853 (next_element_from_buffer): Add xassert's for correspondence
7854 between IT's object being iterated and it->bidi_it.string
7855 structure.
7856 (face_before_or_after_it_pos): Support bidi iteration.
7857 (next_element_from_c_string): Handle the case of the first string
7858 character that is not the first one in the visual order.
7859 (get_visually_first_element): New function, refactored from common
7860 parts of next_element_from_buffer, next_element_from_string, and
7861 next_element_from_c_string.
7862 (tool_bar_lines_needed, redisplay_tool_bar)
7863 (display_menu_bar): Force left-to-right direction. Add a FIXME
7864 comment for making that be controlled by a user option.
7865 (push_it, pop_it): Save and restore the state of the
7866 bidi iterator. Save and restore the bidi_p flag.
7867 (pop_it): Iterate out of display property for string iteration as
7868 well.
7869 (iterate_out_of_display_property): Support iteration over strings.
7870 (handle_single_display_spec): Set up it->bidi_it for iteration
7871 over a display string, and call bidi_init_it.
7872 (handle_single_display_spec, next_overlay_string)
7873 (get_overlay_strings_1, push_display_prop): Set up the bidi
7874 iterator for displaying display or overlay strings.
7875 (forward_to_next_line_start): Don't use the shortcut if
7876 bidi-iterating.
7877 (back_to_previous_visible_line_start): If handle_display_prop
7878 pushed the iterator stack, restore the internal state of the bidi
7879 iterator by calling bidi_pop_it same number of times.
7880 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7881 and we are bidi-iterating, don't decrement the iterator position;
7882 instead, set the first_elt flag in the bidi iterator, to produce
7883 the same effect.
7884 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7885 (push_display_prop): xassert that we are iterating a buffer.
7886 (push_it, pop_it): Save and restore paragraph_embedding member.
7887 (handle_single_display_spec, next_overlay_string)
7888 (get_overlay_strings_1, reseat_1, reseat_to_string)
7889 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7890 correctly. Don't assume unibyte strings are not bidi-reordered.
7891 (compute_display_string_pos)
7892 (compute_display_string_end): Fix handling the case of C string.
7893 (push_it, pop_it): Save and restore from_disp_prop_p.
7894 (handle_single_display_spec, push_display_prop): Set the
7895 from_disp_prop_p flag.
7896 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7897 (pop_it): Call iterate_out_of_display_property only if we are
7898 popping after iteration over a string that came from a display
7899 property. Fix a typo in popping stretch info. Add an assertion
7900 for verifying that the iterator position is in sync with the bidi
7901 iterator.
7902 (handle_single_display_spec, get_overlay_strings_1)
7903 (push_display_prop): Fix initialization of paragraph direction for
7904 string when that of the parent object is not yet determined.
7905 (reseat_1): Call bidi_init_it to resync the bidi
7906 iterator with IT's position. (Bug#7616)
7907 (find_row_edges): If ROW->start.pos gives position
7908 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7909 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7910 Reset the from_disp_prop_p flag.
7911 (SAVE_IT, RESTORE_IT): New macros.
7912 (pos_visible_p, face_before_or_after_it_pos)
7913 (back_to_previous_visible_line_start)
7914 (move_it_in_display_line_to, move_it_in_display_line)
7915 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7916 (try_scrolling, redisplay_window, display_line): Use them when
7917 saving a temporary copy of the iterator and restoring it back.
7918 (back_to_previous_visible_line_start, reseat_1)
7919 (init_iterator): Empty the bidi cache "stack".
7920 (move_it_in_display_line_to): If iterator ended up at
7921 EOL, but we never saw any buffer positions smaller than
7922 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7923 motion in bidi-reordered lines.
7924 (move_it_in_display_line_to): Record prev_method and prev_pos
7925 immediately before the call to set_iterator_to_next. Fixes cursor
7926 motion in bidi-reordered lines with stretch glyphs and strings
7927 displayed in margins. (Bug#8133) (Bug#8867)
7928 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7929 TO_CHARPOS.
640c8776
SM
7930 (pos_visible_p): Support positions in bidi-reordered lines.
7931 Save and restore bidi cache.
0bb23927
EZ
7932
7933 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7934 (bidi_paragraph_info): Delete unused struct.
7935 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7936 (bidi_cache_start): New variable.
7937 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7938 to zero.
7939 (bidi_cache_fetch_state, bidi_cache_search)
7940 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7941 (bidi_cache_find, bidi_peek_at_next_level)
7942 (bidi_level_of_next_char, bidi_find_other_level_edge)
7943 (bidi_move_to_visually_next): Compare cache index with
7944 bidi_cache_start rather than with zero.
7945 (bidi_fetch_char): Accept new argument STRING; all callers
7946 changed. Support iteration over a string. Support strings with
7947 display properties. Support unibyte strings. Fix the type of
7948 `len' according to what STRING_CHAR_AND_LENGTH expects.
7949 (bidi_paragraph_init, bidi_resolve_explicit_1)
7950 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7951 (bidi_level_of_next_char, bidi_move_to_visually_next):
7952 Support iteration over a string.
0bb23927
EZ
7953 (bidi_set_sor_type, bidi_resolve_explicit_1)
7954 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7955 can now be zero (for strings); special values 0 and -1 were
7956 changed to -1 and -2, respectively.
7957 (bidi_char_at_pos): New function.
7958 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7959 Call it instead of FETCH_MULTIBYTE_CHAR.
7960 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7961 initialized to valid values.
7962 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7963 values.
7964 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7965 the test for valid cached positions. Fix the logic for looking up
7966 the sentinel state in the cache. GCPRO the Lisp string we are
7967 iterating.
7968 (bidi_push_it, bidi_pop_it): New functions.
7969 (bidi_initialize): Initialize the bidi cache start stack pointer.
7970 (bidi_cache_ensure_space): New function, refactored from part of
7971 bidi_cache_iterator_state. Don't assume the required size is just
7972 one BIDI_CACHE_CHUNK away.
7973 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7974 (bidi_count_bytes, bidi_char_at_pos): New functions.
7975 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7976 always valid if bidi_cache_idx is valid.
7977 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7978 is valid if it's going to be used.
7979 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7980 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7981 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7982 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7983 (bidi_find_other_level_edge, bidi_cache_start_stack):
7984 All variables related to cache indices are now EMACS_INT.
c965adc5 7985
0bb23927
EZ
7986 * dispextern.h (struct bidi_string_data): New structure.
7987 (struct bidi_it): New member `string'. Make flag members be 1-bit
7988 fields, and put them last in the struct.
640c8776
SM
7989 (compute_display_string_pos, compute_display_string_end):
7990 Update prototypes.
0bb23927
EZ
7991 (bidi_push_it, bidi_pop_it): Add prototypes.
7992 (struct iterator_stack_entry): New members bidi_p,
7993 paragraph_embedding, and from_disp_prop_p.
7994 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7995 (bidi_shelve_cache, bidi_unshelve_cache):
7996 Declare prototypes.
0bb23927
EZ
7997
7998 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7999 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8000 and vector-like objects.
8001
8002 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8003 cache around display iteration.
8004
8005 * window.c (Fwindow_end, window_scroll_pixel_based)
8006 (displayed_window_lines, Frecenter): Save and restore the bidi
8007 cache around display iteration.
8008
3bbd2265
LMI
80092011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8010
8011 * editfns.c (Fdelete_region): Clarify the use of the named
8012 parameters (bug#6788).
8013
adc47434
MR
80142011-07-14 Martin Rudalics <rudalics@gmx.at>
8015
8016 * indent.c (Fvertical_motion): Set and restore w->pointm when
8017 saving and restoring the window's buffer (Bug#9006).
8018
837c31f8
LMI
80192011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8020
8021 * editfns.c (Fstring_to_char): Clarify just what is returned
8022 (bug#6576). Text by Eli Zaretskii.
8023
ac389d0c
JB
80242011-07-13 Juanma Barranquero <lekktu@gmail.com>
8025
8026 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8027
0be0ce47
EZ
80282011-07-13 Eli Zaretskii <eliz@gnu.org>
8029
8030 * buffer.c (mmap_find): Fix a typo.
8031
cd18e7e3
JB
80322011-07-13 Johan Bockgård <bojohan@gnu.org>
8033
8034 Fix execution of x selection hooks.
8035 * xselect.c (Qx_lost_selection_functions)
8036 (Qx_sent_selection_functions): New vars.
8037 (syms_of_xselect): DEFSYM them.
8038 (x_handle_selection_request): Pass Qx_sent_selection_functions
8039 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8040 (x_handle_selection_clear,x_clear_frame_selections):
8041 Pass Qx_lost_selection_functions rather than
8042 Vx_lost_selection_functions to Frun_hook_with_args.
8043
47ea7f44
PE
80442011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8045
ac389d0c 8046 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8047 The old code sometimes used this field without initializing it.
8048
47ea7f44
PE
8049 * alloc.c (gc_sweep): Don't read past end of array.
8050 In theory, the old code could also have corrupted Emacs internals,
8051 though it'd be very unlikely.
8052
bc985c87
AS
80532011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8054
8055 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8056 argument. (Bug#4026)
bc985c87 8057
0cf34688
LMI
80582011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8059
b3dadd76
LMI
8060 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8061 key" (bug#4257).
8062
0cf34688
LMI
8063 * window.c (Fset_window_start): Doc fix (bug#4199).
8064 (Fset_window_hscroll): Ditto.
8065
270768cd
PE
80662011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8067
077e3dda 8068 Fix minor new problems caught by GCC 4.6.1.
270768cd 8069 * term.c (init_tty): Remove unused local.
490011a6 8070 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8071 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8072 not used otherwise.
270768cd 8073
b1f58454
CY
80742011-07-12 Chong Yidong <cyd@stupidchicken.com>
8075
8076 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8077
22b9578d
LMI
80782011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8079
6e70ab07
LMI
8080 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8081 are the mini-buffer and the echo area (bug#3320).
8082
22b9578d
LMI
8083 * term.c (init_tty): Remove support for supdup, c10 and perq
8084 terminals, which are no longer supported (bug#1482).
8085
8974cc9f
JB
80862011-07-10 Johan Bockgård <bojohan@gnu.org>
8087
8088 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8089
a560d974
JD
80902011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8091
8092 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8093 for non-popups (Bug#3642).
8094
1dae0f0a
AS
80952011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8096
268c2c36 8097 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8098 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8099 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8100 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8101 * data.c (fmod): Likewise.
8102 * dispnew.c (swap_glyphs_in_rows): Likewise.
8103 * emacs.c (memory_warning_signal): Likewise.
8104 * floatfns.c (float_error): Likewise.
8105 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8106 (otf_open, font_otf_capability, generate_otf_features)
8107 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8108 Likewise.
8109 * image.c (pbm_read_file): Likewise.
8110 * indent.c (string_display_width): Likewise.
8111 * intervals.c (check_for_interval, search_for_interval)
8112 (inc_interval_count, count_intervals, root_interval)
8113 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8114 * lread.c (defalias): Likewise.
268c2c36 8115 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8116 * regex.c (set_image_of_range_1, set_image_of_range)
8117 (regex_grow_registers): Likewise.
8118 * sysdep.c (strerror): Likewise.
8119 * termcap.c (valid_filename_p, tprint, main): Likewise.
8120 * tparam.c (main): Likewise.
8121 * unexhp9k800.c (run_time_remap, save_data_space)
8122 (update_file_ptrs, read_header, write_header, calculate_checksum)
8123 (copy_file, copy_rest, display_header): Likewise.
8124 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8125 Likewise.
8126 * xdisp.c (check_it): Likewise.
8127 * xfaces.c (register_color, unregister_color, unregister_colors):
8128 Likewise.
8129 * xfns.c (print_fontset_result): Likewise.
8130 * xrdb.c (member, fatal, main): Likewise.
8131
99033785
PE
81322011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8133
8134 Fix minor problems found by static checking (Bug#9031).
8135 * chartab.c (char_table_set_range, map_sub_char_table):
8136 Remove unused locals.
8137 (uniprop_table): Now static.
8138 * composite.c (_work_char): Remove unused static var.
8139
9cb2ac56
JB
81402011-07-09 Juanma Barranquero <lekktu@gmail.com>
8141
8142 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8143
f25661f0
JD
81442011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8145
8146 * gtkutil.c (qttip_cb): Remove code without function.
8147
8278c4fe
EZ
81482011-07-09 Eli Zaretskii <eliz@gnu.org>
8149
8150 * w32.c (pthread_sigmask): New stub.
8151
1692ae2d 81522011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8153
8a6ebd58 8154 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8155 sigprocmask is portable only for single-threaded applications, and
8156 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8157 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8158 (LIBES): Use it.
8159 * callproc.c (Fcall_process):
8160 * process.c (create_process):
8161 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8162 Use pthread_sigmask, not sigprocmask.
123403e4 8163
1b854618
JD
81642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8165
8166 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8167 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8168 wrong (Bug#8591).
8169
3fe4b549
JD
81702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8171
0ce7e563
JD
8172 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8173 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8174 (xg_hide_tooltip): Fix comment.
8175
3fe4b549
JD
8176 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8177 in registerServicesMenuSendTypes.
8178 (validRequestorForSendType): Don't check ns_return_types.
8179
8180 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8181 ns_return_type.
8182
5df75e47
JR
81832011-07-08 Jason Rumney <jasonr@gnu.org>
8184
22610910
JR
8185 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8186 SH_SHOW for hidden windows (Bug#5482).
8187
5df75e47
JR
8188 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8189 frame struct members of non-existent frames (Bug#6284).
8190
699c10bd
JD
81912011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8192
4393663b
JD
8193 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8194 variable firstTime not needed on OSX >= 10.6.
8195 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8196 >= 10.5. Use setKnobProportion, setDoubleValue.
8197
8198 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8199 (MAC_OS_X_VERSION_10_5): Define if not defined.
8200 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8201 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8202 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8203
8204 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8205 cString and lossyCString on OSX >= 10.4.
4393663b 8206
58179cce 8207 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8208 sizeToFit on OSX >= 10.2.
8209
8210 * nsimage.m (allocInitFromFile): Don't use deprecated method
8211 bestRepresentationForDevice on OSX >= 10.6.
8212
8213 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8214 to avoid warning.
8215
8216 * emacs.c: Declare unexec_init_emacs_zone.
8217
a63e0781
JD
8218 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8219
699c10bd
JD
8220 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8221
8222 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8223 on svcsMenu (Bug#8842).
8224
8225 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8226 ns_return_types.
8227 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8228
8229 * nsterm.m (QUTF8_STRING): Declare.
8230 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8231 (validRequestorForSendType): Return type is (id).
8232 Change indexOfObjectIdenticalTo to indexOfObject.
8233 Check if we have local selection before returning self (Bug#8842).
8234 (writeSelectionToPasteboard): Put local selection into paste board
8235 if we have a local selection (Bug#8842).
8236 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8237
8238 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8239 (ns_get_local_selection): Declare.
8240
54e10184
LMI
82412011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8242
9888ff71
LMI
8243 * keymap.c (describe_map_tree): Don't insert a double newline at
8244 the end of the buffer (bug#1169) and return whether we inserted
8245 something.
8246
54e10184
LMI
8247 * callint.c (Fcall_interactively): Change "reading args" to
8248 "providing args" to try to clarify what it does (bug#1010).
8249
15fa4783
KH
82502011-07-07 Kenichi Handa <handa@m17n.org>
8251
8252 * composite.c (composition_compute_stop_pos): Ignore a static
8253 composition starting before CHARPOS (Bug#8915).
8254
8255 * xdisp.c (handle_composition_prop): Likewise.
8256
a8815b00
EZ
82572011-07-07 Eli Zaretskii <eliz@gnu.org>
8258
8259 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8260 (Bug#9015)
8261
ef7b981d 82622011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8263
8264 * character.h (unicode_category_t): New enum type.
8265
8266 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8267 (Qchar_code_property_table): New variable.
8268 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8269 (UNIPROP_COMPRESSED_FORM_P): New macros.
8270 (char_table_ascii): Uncompress the compressed values.
8271 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8272 Uncompress the compressed values.
ac389d0c 8273 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8274 (char_table_ref_and_range): Uncompress the compressed values.
8275 (sub_char_table_set): New arg is_uniprop. Callers changed.
8276 Uncompress the compressed values.
8277 (sub_char_table_set_range): Args changed. Callers changed.
8278 (char_table_set_range): Adjuted for the above change.
8279 (map_sub_char_table): Delete args default_val and parent. Add arg
8280 top. Give decoded values to a Lisp function.
640c8776 8281 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8282 values to a Lisp function. Gcpro more variables.
8283 (uniprop_table_uncompress)
8284 (uniprop_decode_value_run_length): New functions.
8285 (uniprop_decoder, uniprop_decoder_count): New variables.
8286 (uniprop_get_decoder, uniprop_encode_value_character)
8287 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8288 New functions.
8289 (uniprop_encoder, uniprop_encoder_count): New variables.
8290 (uniprop_get_encoder, uniprop_table)
8291 (Funicode_property_table_internal, Fget_unicode_property_internal)
8292 (Fput_unicode_property_internal): New functions.
8293 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8294 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8295 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8296 char-code-property-alist.
8297
640c8776 8298 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8299 Vunicode_category_table.
8300
640c8776 8301 * font.c (font_range): Adjust for the change of
c805dec0
KH
8302 Vunicode_category_table.
8303
76b397fb
DN
83042011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8305
8306 * m/iris4d.h: Remove file, move contents ...
8307 * s/irix6-5.h: ... here.
8308
22b4128e
PE
83092011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8310
8311 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8312 * alloc.c (mark_buffer):
8313 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8314 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8315 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8316 This isn't true in general, and it's particularly not true
8317 if Emacs is configured with --with-wide-int.
8318 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8319 New macros, used in the buffer.c change.
8320
869795d6
JD
83212011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8322
8323 * xsettings.c: Use both GConf and GSettings if both are available.
8324 (store_config_changed_event): Add comment.
8325 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8326 (store_tool_bar_style_changed): New functions.
5e617bc2 8327 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8328 (struct xsettings): Move font inside HAVE_XFT.
8329 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8330 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8331 Move inside HAVE_XFT.
640c8776 8332 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8333 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8334 also.
8335 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8336 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8337 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8338 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8339 (parse_settings): Move check for font inside HAVE_XFT.
8340 (read_settings, apply_xft_settings): Add comment.
8341 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8342 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8343 call store_font_name_changed.
8344 (xft_settings_event): Add comment.
8345 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8346 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8347 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8348 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8349 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8350 (xsettings_get_system_font, xsettings_get_system_normal_font):
8351 Add comment.
869795d6 8352
d8ed26bd
PE
83532011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8354
8355 Random fixes. E.g., (random) never returned negative values.
8356 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8357 subseconds part to the entropy, as that's a bit more random.
8358 Prefer signed to unsigned, since the signedness doesn't matter and
8359 in general we prefer signed. When given a limit, use a
8360 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8361 latter isn't right if USE_2_TAGS_FOR_INTS.
8362 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8363 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8364
cabf1cac
SM
83652011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8366
8367 * textprop.c (text_property_stickiness):
8368 Obey Vtext_property_default_nonsticky.
8369 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8370 * w32fns.c (syms_of_w32fns):
8371 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8372
6e9b2be9
PE
83732011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8374
8375 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8376 This is more efficient than Ffile_directory_p and avoids a minor race.
8377
90186c68
LMI
83782011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8379
7c301272
LMI
8380 * buffer.c (Foverlay_put): Say what the return value is
8381 (bug#7835).
8382
c4f2d8d4
LMI
8383 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8384 is a directory before asking whether to use the file name
8385 (bug#7564).
ad637907
LMI
8386 (barf_or_query_if_file_exists): Make the "File is a directory"
8387 error be more correct.
c4f2d8d4 8388
90186c68
LMI
8389 * fns.c (Frequire): Remove the mention of the .gz files, since
8390 that's installation-specific, but keep the mention of
8391 `get-load-suffixes'.
8392
da64016e
PE
83932011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8394
8395 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8396 Report string overflow if the output is too long.
8397
7d47b580
JB
83982011-07-04 Juanma Barranquero <lekktu@gmail.com>
8399
a555cb87
JB
8400 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8401 (syms_of_gnutls): Remove duplicate DEFSYM for
8402 Qgnutls_bootprop_verify_hostname_error, an error for
8403 Qgnutls_bootprop_verify_error (which is no longer used).
8404
7d47b580
JB
8405 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8406 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8407 Also (re)move comments that are misplaced or no longer relevant.
8408
1e49bfab
LMI
84092011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8410
8411 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8412
1485f4c0
CY
84132011-07-03 Chong Yidong <cyd@stupidchicken.com>
8414
8415 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8416 and background color parameters if they have been changed.
8417
a9ab721e
LMI
84182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8419
8420 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8421
cf7cff57
PE
84222011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8423
2e13213d
PE
8424 * xsettings.c (SYSTEM_FONT): Define only when used.
8425 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8426
cf7cff57
PE
8427 * keymap.c (access_keymap_1): Now static.
8428
7a8e04f7
CY
84292011-07-02 Chong Yidong <cyd@stupidchicken.com>
8430
8431 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8432 leave any prefix arg for the up event (Bug#1586).
8433
61352f62
LMI
84342011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8435
69bb1ef7
LMI
8436 * lread.c (syms_of_lread): Mention single symbols defined by
8437 `defvar' or `defconst' (bug#7154).
8438
61352f62 8439 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8440 (Frequire): Mention get-load-suffixes.
61352f62 8441
28545e04
MR
84422011-07-02 Martin Rudalics <rudalics@gmx.at>
8443
8444 * window.h (window): Remove clone_number slot.
8445 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8446 Remove.
8447 (make_parent_window, make_window, saved_window)
8448 (Fset_window_configuration, save_window_save): Don't deal with
8449 clone numbers.
8450 * buffer.c (Qclone_number): Remove declaration.
8451 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8452
3349e122
SM
84532011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8454
8455 Add multiple inheritance to keymaps.
8456 * keymap.c (Fmake_composed_keymap): New function.
8457 (Fset_keymap_parent): Simplify.
8458 (fix_submap_inheritance): Remove.
8459 (access_keymap_1): New function extracted from access_keymap to handle
8460 embedded parents and handle lists of maps.
8461 (access_keymap): Use it.
8462 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8463 (Fcopy_keymap): Handle embedded parents.
8464 (Fcommand_remapping, define_as_prefix): Simplify.
8465 (Fkey_binding): Simplify.
8466 (syms_of_keymap): Move minibuffer-local-completion-map,
8467 minibuffer-local-filename-completion-map,
8468 minibuffer-local-must-match-map, and
8469 minibuffer-local-filename-must-match-map to Elisp.
8470 (syms_of_keymap): Defsubr make-composed-keymap.
8471 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8472 (parse_menu_item): Trivial simplification.
8473
3279eb87
GM
84742011-07-01 Glenn Morris <rgm@gnu.org>
8475
8476 * Makefile.in (SETTINGS_LIBS): Fix typo.
8477
4550efdf
KI
84782011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8479
8480 * coding.c (Fencode_coding_string): Record the last coding system
8481 used, as the function doc string says (bug#8738).
8482
0949d2b6
JD
84832011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8484
8485 * xsettings.c (store_monospaced_changed): Take new font as arg and
8486 check for change against current_mono_font.
8487 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8488 (emacs_settings_constructor, emacs_settings_get_property)
8489 (emacs_settings_set_property, emacs_settings_class_init)
8490 (emacs_settings_init, gsettings_obj): Remove.
8491 (something_changedCB): New function for HAVE_GSETTINGS.
8492 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8493 with value as argument.
8494 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8495 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8496 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8497 "changed".
8498
8499 * xgselect.c: Add defined (HAVE_GSETTINGS).
8500 (xgselect_initialize): Ditto.
8501
8502 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8503 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8504 xg_select.
8505
bbc6b304
PE
85062011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8507
8508 * eval.c (struct backtrace): Simplify and port the data structure.
8509 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8510 signed bit field, as this assumption is not portable and it makes
8511 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8512 "char debug_on_exit : 1" as this is not portable either; instead,
8513 use the portable "unsigned int debug_on_exit : 1". Remove unused
8514 member evalargs. Remove obsolete comments about cc bombing out.
8515
9851bfc5
JD
85162011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8517
51bb811f 8518 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8519 Let HAVE_GSETTINGS override HAVE_GCONF.
8520 (store_monospaced_changed): New function.
8521 (EMACS_SETTINGS): A new type derived from GObject to handle
8522 GSettings notifications.
8523 (emacs_settings_constructor, emacs_settings_get_property)
8524 (emacs_settings_set_property, emacs_settings_class_init):
8525 New functions.
8526 (gsettings_client, gsettings_obj): New variables.
8527 (GSETTINGS_SCHEMA): New define.
8528 (something_changedCB): Call store_monospaced_changed.
8529 (init_gsettings): New function.
8530 (xsettings_initialize): Call init_gsettings.
8531 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8532 to NULL.
8533
640c8776 8534 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8535 GCONF_CFLAGS/LIBS.
8536
5386012d
MR
85372011-06-29 Martin Rudalics <rudalics@gmx.at>
8538
8539 * window.c (resize_root_window, grow_mini_window)
8540 (shrink_mini_window): Rename Qresize_root_window to
8541 Qwindow_resize_root_window and Qresize_root_window_vertically to
8542 Qwindow_resize_root_window_vertically.
8543
f13e0b08
PE
85442011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8545
8546 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8547
94515237
JB
85482011-06-27 Juanma Barranquero <lekktu@gmail.com>
8549
8550 * makefile.w32-in: Redesign dependencies so they reflect more
8551 clearly which files are directly included by each source file,
8552 and not through other includes.
8553
e43b6e43
MR
85542011-06-27 Martin Rudalics <rudalics@gmx.at>
8555
8556 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8557 (sort_overlays, overlay_strings): When an overlay's clone number
8558 matches the window's clone number process the overlay even if
8559 the overlay's window property doesn't match the current window.
8560
d68443dc
MR
8561 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8562 (Fwindow_hchild): Rename to Fwindow_left_child.
8563 (Fwindow_next): Rename to Fwindow_next_sibling.
8564 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8565 (resize_window_check): Rename to window_resize_check.
8566 (resize_window_apply): Rename to window_resize_apply.
8567 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8568 (Fdelete_other_windows_internal, resize_frame_windows)
8569 (Fsplit_window_internal, Fdelete_window_internal)
8570 (grow_mini_window, shrink_mini_window)
8571 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8572
c7e73be5
JD
85732011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8574
8575 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8576 (emacs_fixed_set_min_size): Remove.
8577 (emacs_fixed_new): Take frame as argument.
8578
8579 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8580 (_EmacsFixedPrivate): Remove minwidth/height.
8581 Add struct frame *f.
8582 (emacs_fixed_init): Initialize priv->f.
8583 (get_parent_class, emacs_fixed_set_min_size): Remove.
8584 (emacs_fixed_new): Set priv->f to argument.
8585 (emacs_fixed_get_preferred_width)
8586 (emacs_fixed_get_preferred_height): Use min_width/height from
8587 frames size_hint to set minimum and natural (Bug#8919).
8588 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8589 and use min_width/height from frames size_hint to set
8590 min_width/height (Bug#8919).
8591
8592 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8593 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8594 Fix indentation.
c7e73be5 8595
cf99dcf8
EZ
85962011-06-26 Eli Zaretskii <eliz@gnu.org>
8597
8598 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8599 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8600 called at ZV.
8601
029529ac
CY
86022011-06-26 Chong Yidong <cyd@stupidchicken.com>
8603
8604 * process.c (wait_reading_process_output): Bypass select if
8605 waiting for a cell while ignoring keyboard input, and input is
8606 pending. Suggested by Jan Djärv (Bug#8869).
8607
7a7ef429
PE
86082011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8609
8610 Use gnulib's dup2 module instead of rolling our own.
8611 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8612
11fdef7d 86132011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8614
8615 * dispnew.c (scrolling_window): Before scrolling, turn off a
8616 mouse-highlight in the window being scrolled.
8617
cd3520a4
JB
86182011-06-24 Juanma Barranquero <lekktu@gmail.com>
8619
8620 Move DEFSYM to lisp.h and use everywhere.
8621
8622 * character.h (DEFSYM): Move declaration...
8623 * lisp.h (DEFSYM): ...here.
8624
8625 * gnutls.c:
8626 * minibuf.c:
8627 * w32menu.c:
8628 * w32proc.c:
8629 * w32select.c: Don't include character.h.
8630
8631 * alloc.c (syms_of_alloc):
8632 * buffer.c (syms_of_buffer):
8633 * bytecode.c (syms_of_bytecode):
8634 * callint.c (syms_of_callint):
8635 * casefiddle.c (syms_of_casefiddle):
8636 * casetab.c (init_casetab_once):
8637 * category.c (init_category_once, syms_of_category):
8638 * ccl.c (syms_of_ccl):
8639 * cmds.c (syms_of_cmds):
8640 * composite.c (syms_of_composite):
8641 * dbusbind.c (syms_of_dbusbind):
8642 * dired.c (syms_of_dired):
8643 * dispnew.c (syms_of_display):
8644 * doc.c (syms_of_doc):
8645 * editfns.c (syms_of_editfns):
8646 * emacs.c (syms_of_emacs):
8647 * eval.c (syms_of_eval):
8648 * fileio.c (syms_of_fileio):
8649 * fns.c (syms_of_fns):
8650 * frame.c (syms_of_frame):
8651 * fringe.c (syms_of_fringe):
8652 * insdel.c (syms_of_insdel):
8653 * keymap.c (syms_of_keymap):
8654 * lread.c (init_obarray, syms_of_lread):
8655 * macros.c (syms_of_macros):
8656 * msdos.c (syms_of_msdos):
8657 * print.c (syms_of_print):
8658 * process.c (syms_of_process):
8659 * search.c (syms_of_search):
8660 * sound.c (syms_of_sound):
8661 * syntax.c (init_syntax_once, syms_of_syntax):
8662 * terminal.c (syms_of_terminal):
8663 * textprop.c (syms_of_textprop):
8664 * undo.c (syms_of_undo):
8665 * w32.c (globals_of_w32):
8666 * window.c (syms_of_window):
8667 * xdisp.c (syms_of_xdisp):
8668 * xfaces.c (syms_of_xfaces):
8669 * xfns.c (syms_of_xfns):
8670 * xmenu.c (syms_of_xmenu):
8671 * xsettings.c (syms_of_xsettings):
8672 * xterm.c (syms_of_xterm): Use DEFSYM.
8673
4228cf16
TZ
86742011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8675
cd3520a4 8676 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8677
7fcccf1e
PE
86782011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8679
7efb4e0e
PE
8680 Integer and buffer overflow fixes (Bug#8873).
8681
ff5844ad
PE
8682 * print.c (printchar, strout): Check for string overflow.
8683 (PRINTPREPARE, printchar, strout):
8684 Don't set size unless allocation succeeds.
8685
90532f02
PE
8686 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8687 for sizes. Check for string overflow more accurately.
8688 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8689
6d84508d
PE
8690 * macros.c: Integer and buffer overflow fixes.
8691 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8692 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8693 Use ptrdiff_t, not int, for sizes.
8694 Don't increment bufsize until after realloc succeeds.
8695 Check for size-calculation overflow.
8696 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8697
437b2cb4
PE
8698 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8699
8b9ac8b4
PE
8700 * lread.c: Integer overflow fixes.
8701 (read_integer): Radix is now EMACS_INT, not int,
8702 to improve quality of diagnostics for out-of-range radices.
8703 Calculate buffer size correctly for out-of-range radices.
8704 (read1): Check for integer overflow in radices, and in
8705 read-circle numbers.
82cb60d3
PE
8706 (read_escape): Avoid int overflow.
8707 (Fload, openp, read_buffer_size, read1)
8708 (substitute_object_recurse, read_vector, read_list, map_obarray):
8709 Use ptrdiff_t, not int, for sizes.
8710 (read1): Use EMACS_INT, not int, for sizes.
20270765 8711 Check for size overflow.
8b9ac8b4 8712
7fcccf1e
PE
8713 * image.c (cache_image): Check for size arithmetic overflow.
8714
bfbbd7e7
PE
8715 * lread.c: Integer overflow issues.
8716 (saved_doc_string_size, saved_doc_string_length)
8717 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8718 Now ptrdiff_t, not int.
8719 (read1): Don't assume doc string length fits in int. Check for
8720 out-of-range doc string lengths.
8721 (read_list): Don't assume file position fits in int.
39019e54 8722 (read_escape): Check for hex character overflow.
bfbbd7e7 8723
4e323265
LL
87242011-06-22 Leo Liu <sdl.web@gmail.com>
8725
8726 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8727 Move to minibuffer.el.
8728
85fece3e
PE
87292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8730
20b84ce9 8731 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8732 The following patches are for when GLYPH_DEBUG && !XASSERT.
8733 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8734 * dispnew.c (flush_stdout):
8735 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8736 Mark as externally visible.
8737 * dispnew.c (check_window_matrix_pointers): Now static.
8738 * dispnew.c (window_to_frame_vpos):
8739 * xfns.c (unwind_create_frame):
8740 * xterm.c (x_check_font): Remove unused local.
8741 * scroll.c (CHECK_BOUNDS):
8742 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8743 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8744 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8745 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8746 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8747 Now static.
8748 (debug_method_add): Use va_list and vsprintf rather than relying
8749 on undefined behavior with wrong number of arguments.
8750 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8751 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8752 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8753 since we're not interested in debugging glyphs with old libraries.
8754 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8755 GCC 4.6.0's static checking.
8756
0766b489
PE
87572011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8758
31fd4b32
PE
8759 Integer overflow and signedness fixes (Bug#8873).
8760 A few related buffer overrun fixes, too.
8761
b79e8648
PE
8762 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8763
0766b489
PE
8764 * dispextern.h (struct face.stipple):
8765 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8766 (x_bitmap_mask, x_allocate_bitmap_record)
8767 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8768 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8769 (x_create_bitmap_from_xpm_data):
8770 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8771 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8772 (.bitmaps_last):
8773 * xfaces.c (load_pixmap):
8774 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8775 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8776 (.bitmaps_last, struct x_output.icon_bitmap):
8777 Use ptrdiff_t, not int, for bitmap indexes.
8778 (x_allocate_bitmap_record): Check for size overflow.
8779 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8780
b081724f
PE
8781 Use ptrdiff_t, not int, for overlay counts.
8782 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8783 * editfns.c (overlays_around, get_pos_property):
8784 * textprop.c (get_char_property_and_overlay):
8785 * xdisp.c (next_overlay_change, note_mouse_highlight):
8786 * xfaces.c (face_at_buffer_position):
21514da7
PE
8787 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8788 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8789 (Fnext_overlay_change, Fprevious_overlay_change)
8790 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8791 Use ptrdiff_t, not int, for sizes.
21514da7 8792 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8793
3de73e5e
PE
8794 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8795
2606c57b
PE
8796 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8797 (x_session_initialize): Do not assume string length fits in int.
8798
aaafe47a
PE
8799 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8800 This is unlikely, but can occur if DPI is outlandish.
8801
2674ddc8 8802 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8803 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8804
28154962
PE
8805 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8806 * xrdb.c (magic_file_p, search_magic_path):
8807 Omit last arg SUFFIX; it was always 0. All callers changed.
8808 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8809
7de51af5
PE
8810 * xfont.c (xfont_match): Avoid need for strlen.
8811
25ed6cc3
PE
8812 * xfns.c: Don't assume strlen fits in int.
8813 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8814
4eab31dd
PE
8815 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8816 not unsigned long, as we prefer signed integers. All callers changed.
8817 Detect integer overflow in repeat count.
8818 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8819 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8820
171e2a58
PE
8821 * termcap.c: Don't assume sizes fit in int and never overflow.
8822 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8823 (gobble_line): Check for size-calculation overflow.
8824
ad39faca 8825 * minibuf.c (Fread_buffer):
6e5bb2dc 8826 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8827 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8828 Don't assume string length fits in int.
8829
52c61c22 8830 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8831 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8832
b5b8c9e5
PE
8833 * font.c: Don't assume string length fits in int.
8834 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8835 Use ptrdiff_t, not int.
ccd6111c
PE
8836 (font_intern_prop): Don't assume string length fits in int.
8837 Don't assume integer property fits in fixnum.
8838 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8839
882f0d81 8840 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8841 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8842 Reformulate so as not to need the command string.
8843 Invoke gzip -cd rather than gunzip, as it's more portable.
8844 (lock_info_type, lock_file_1, lock_file):
8845 Don't assume pid_t and time_t fit in unsigned long.
8846 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8847 (current_lock_owner): Prefer signed type for sizes.
8848 Use memcpy, not strncpy, where memcpy is what is really wanted.
8849 Don't assume (via atoi) that time_t and pid_t fit in int.
8850 Check for time_t and/or pid_t out of range, e.g., via a network share.
8851 Don't alloca where an auto var works fine.
8852
93f4cf88
PE
8853 * fileio.c: Fix some integer overflow issues.
8854 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8855 Don't assume string length fits in int.
8856 (directory_file_name): Don't assume string length fits in long.
8857 (make_temp_name): Don't assume pid fits in int, or that its print
8858 length is less than 20.
8859
f3e92b69
PE
8860 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8861
1bfdaf10
PE
8862 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8863
35016e9a
PE
8864 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8865
3d1e65a1
PE
8866 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8867 We prefer signed integers, even for size calculations.
8868
0b963a93
PE
8869 * emacs.c: Don't assume string length fits in 'int'.
8870 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8871 (main): Don't invoke strlen when not needed.
8872
573f4b54
PE
8873 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8874 (XD_DEBUG_MESSAGE): Don't waste a byte.
8875
989f33ba
PE
8876 * callproc.c (getenv_internal_1, getenv_internal)
8877 (Fgetenv_internal):
965d34eb
PE
8878 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8879
e4d29b33
PE
8880 * lread.c (invalid_syntax): Omit length argument.
8881 All uses changed. This doesn't fix a bug, but it simplifies the
8882 code away from its former Hollerith-constant appearance, and it's
8883 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8884 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8885
eb49b136
PE
8886 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8887 This didn't break anything, but it didn't help either.
8888 It's confusing to put a bogus integer in a place where the actual
8889 value does not matter.
9f62aeb1 8890 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8891 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8892
15375a22
PE
8893 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8894 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8895 implementation.
b61cc01c
PE
8896 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8897 We prefer signed types, and the value cannot exceed the EMACS_INT
8898 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8899 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8900 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8901 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8902
53b2623d
PE
8903 * indent.c (sane_tab_width): New function.
8904 (current_column, scan_for_column, Findent_to, position_indentation)
8905 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8906 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8907
51cab52b 8908 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8909
f2ed8a70
PE
8910 * lisp.h (lint_assume): New macro.
8911 * composite.c (composition_gstring_put_cache):
8912 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8913
abe80cc6
PE
8914 * editfns.c, insdel.c:
8915 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8916
b02c740e
PE
8917 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8918
ebc96716
PE
8919 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8920
b4e50fa0 8921 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8922 Use much-faster test for byte-length change.
311d5d7c 8923 Don't assume string byte-length fits in 'int'.
a4cf38e4 8924 Check that character arg fits in 'int'.
85461888 8925 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8926
c0c1ee9f
PE
8927 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8928
a498d7f4
PE
8929 * fns.c (concat): Catch string overflow earlier.
8930 Do not rely on integer wraparound.
8931
51cab52b
PE
8932 * dispextern.h (struct it.overlay_strings_charpos)
8933 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8934 * xdisp.c (forward_to_next_line_start)
8935 (back_to_previous_visible_line_start)
8936 (reseat_at_next_visible_line_start, next_element_from_buffer):
8937 Don't arbitrarily truncate the value of 'selective' to int.
8938
76031fad
PE
8939 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8940
5eb55db9
PE
8941 * composite.c: Don't truncate sizes to 'int'.
8942 (composition_gstring_p, composition_reseat_it)
8943 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8944 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8945 not EMACS_UINT, for indexes.
5eb55db9 8946
0703a717
PE
8947 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8948
d6202519
PE
8949 * buffer.c: Include <verify.h>.
8950 (struct sortvec.priority, struct sortstr.priority):
8961a454 8951 Now EMACS_INT, not int.
c20998a7 8952 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8953 (struct sortstr.size, record_overlay_string)
8954 (struct sortstrlist.size, struct sortlist.used):
8955 Don't truncate size to int.
8956 (record_overlay_string): Check for size-calculation overflow.
d6202519 8957 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8958
d5a19415
JM
89592011-06-22 Jim Meyering <meyering@redhat.com>
8960
029529ac 8961 Don't leak an XBM-image-sized buffer
d5a19415
JM
8962 * image.c (xbm_load): Free the image buffer after using it.
8963
a9041e6c
PE
89642011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8965
8966 Port to Sun C.
8967 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8968 that Sun C diagnosed.
8969 * fns.c (secure_hash): Fix pointer signedness issue.
8970 * intervals.c (static_offset_intervals): New function.
8971 (offset_intervals): Use it.
8972
7f3f739f
LL
89732011-06-21 Leo Liu <sdl.web@gmail.com>
8974
8975 * deps.mk (fns.o):
8976 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8977 sha512.h.
8978
8979 * fns.c (secure_hash): Rename from crypto_hash_function and change
8980 the first arg to accept symbols.
5b66d427 8981 (Fsecure_hash): New primitive.
7f3f739f
LL
8982 (syms_of_fns): New symbols.
8983
76147d94
DD
89842011-06-20 Deniz Dogan <deniz@dogan.se>
8985
8986 * process.c (Fset_process_buffer): Clarify return value in
8987 docstring.
8988
7d7d0045
CY
89892011-06-18 Chong Yidong <cyd@stupidchicken.com>
8990
8991 * dispnew.c (add_window_display_history): Use BVAR.
8992
8993 * xdisp.c (debug_method_add): Use BVAR.
8994 (check_window_end, dump_glyph_matrix, dump_glyph)
8995 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8996
8997 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8998 Likewise.
8999
9000 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9001 check till after the cache is created in init_frame_faces.
9002
ff2bc410
SM
90032011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9004
9005 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9006
28177add
PE
90072011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9008
dd3482fe
PE
9009 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9010 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9011 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9012
393d71f3 9013 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9014 * fileio.c (Finsert_file_contents):
9015 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9016 Remove the old (too-loose) buffer overflow checks.
9017 They weren't needed, since make_gap checks for buffer overflow.
9018 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9019 The old code merely checked for Emacs fixnum overflow, and relied
9020 on undefined (wraparound) behavior. The new code avoids undefined
9021 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9022
2e6813b0 9023 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9024 Tune. Don't use wider integers than needed. Don't use alloca.
9025 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9026
599a9e4f
PE
9027 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9028
99561444
PE
9029 * insdel.c, lisp.h (buffer_overflow): New function.
9030 (insert_from_buffer_1, replace_range, replace_range_2):
9031 * insdel.c (make_gap_larger):
9032 * editfns.c (Finsert_char):
9033 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9034
28177add
PE
9035 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9036
e69dafad
PE
90372011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9038
4baa020d 9039 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9040
b1c46f02
PE
9041 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9042 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9043
e69dafad
PE
9044 * fileio.c: Don't assume EMACS_INT fits in off_t.
9045 (emacs_lseek): New static function.
9046 (Finsert_file_contents, Fwrite_region): Use it.
9047 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9048
566684ea
PE
9049 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9050
e6966cd6
PE
9051 * fns.c: Don't overflow int when computing a list length.
9052 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9053 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9054 truncation on 64-bit hosts. Check for QUIT every
9055 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9056 faster and is responsive enough.
9057 (Flength): Report an error instead of overflowing an integer.
9058 (Fsafe_length): Return a float if the value is not representable
9059 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9060 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9061 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9062
dd0b0efb
PE
9063 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9064 (header_size, word_size): New constants.
9065 (allocate_vectorlike): Don't check size overflow here.
9066 (allocate_vector): Check it here instead, since this is the only
9067 caller of allocate_vectorlike that could cause overflow.
9068 Check that the new vector's length is representable as a fixnum.
9069
86fe5cfe
PE
9070 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9071 The previous code was bogus. For example, next_almost_prime (32)
9072 returned 39, which is undesirable as it is a multiple of 3; and
9073 next_almost_prime (24) returned 25, which is a multiple of 5 so
9074 why was the code bothering to check for multiples of 7?
9075
80e88859
PE
9076 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9077
4a2f0ad6
PE
9078 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9079
f66c7cf8
PE
9080 Variadic C functions now count arguments with ptrdiff_t.
9081 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9082 Back then I didn't know that the Emacs coding style prefers signed int.
9083 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9084 were being counted with int, which may truncate counts on 64-bit
9085 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9086 * lisp.h (struct Lisp_Subr.function.aMANY)
9087 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9088 Arg counts are now ptrdiff_t, not size_t.
9089 All variadic functions and their callers changed accordingly.
9090 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9091 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9092 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9093 * callint.c (Fcall_interactively): Check arg count for overflow,
9094 to avoid potential buffer overrun. Use signed char, not 'int',
9095 for 'varies' array, so that we needn't bother to check its size
9096 calculation for overflow.
9097 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9098 * eval.c (apply_lambda):
9099 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9100 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9101 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9102
a1759b76
PE
9103 * callint.c (Fcall_interactively): Don't use index var as event count.
9104
d96be9fc
PE
9105 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9106 * mem-limits.h (SIZE): Remove; no longer used.
9107
a690a978 9108 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9109
578c21e6
PE
9110 Remove unnecessary casts.
9111 * xterm.c (x_term_init):
9112 * xfns.c (x_set_border_pixel):
9113 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9114 These aren't needed now that we assume ANSI C.
9115
96f53c6c
PE
9116 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9117 It's more likely to cause problems (due to unsigned overflow)
9118 than to cure them.
9119
83c77d31
PE
9120 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9121
ee2079f1
PE
9122 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9123
6da65536
PE
9124 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9125
7147c4a4
PE
9126 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9127
193e32d9
PE
9128 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9129
e5533da6
PE
9130 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9131
9910e595
PE
9132 GLYPH_CODE_FACE returns EMACS_INT, not int.
9133 * dispextern.h (merge_faces):
9134 * xfaces.c (merge_faces):
01103c44
PE
9135 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9136 Don't assume EMACS_INT fits in int.
9910e595 9137
2638320e
PE
9138 * character.h (CHAR_VALID_P): Remove unused parameter.
9139 * fontset.c, lisp.h, xdisp.c: All uses changed.
9140
045eb8d9
PE
9141 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9142
c1f134b5
PE
9143 * fns.c (concat): Minor tuning based on overflow analysis.
9144 This doesn't fix any bugs. Use int to hold character, instead
9145 of constantly refetching from Emacs object. Use XFASTINT, not
9146 XINT, for value known to be a character. Don't bother comparing
9147 a single byte to 0400, as it's always less.
9148
395fcb93 9149 * floatfns.c (Fexpt):
327eeec8
PE
9150 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9151
abbd3d23
PE
9152 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9153 for characters.
9154
684a03ef
PE
9155 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9156
0fed43f3
PE
9157 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9158 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9159 incorrectly succeed when S was a string, because 4294967386 was
9160 truncated before it was used.
9161
8fd02eb7
PE
9162 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9163 Otherwise, an out-of-range integer could cause undefined behavior
9164 on a 64-bit host.
9165
f8c86b69
PE
9166 * composite.c: Use int, not EMACS_INT, for characters.
9167 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9168 EMACS_INT, for values that are known to be in character range.
9169 This doesn't fix any bugs but is the usual style inside Emacs and
9170 may generate better code on 32-bit machines.
9171
34206dd2
PE
9172 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9173 This is for reasons similar to the recent CHAR_STRING fix.
9174 * charset.c (Fencode_char): Check that character arg is actually
9175 a character. Pass an int to ENCODE_CHAR.
9176 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9177 wider than 'int', as a compile-time check to prevent future regressions
9178 in this area.
9179
c5958d4c 9180 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9181
9182 Make sure a 64-bit char is never passed to CHAR_STRING.
9183 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9184 by silently ignoring the top 32 bits, allowing some values
9185 that were far too large to be valid characters.
9186 * character.h: Include <verify.h>.
9187 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9188 arguments are no wider than unsigned, as a compile-time check
9189 to prevent future regressions in this area.
9190 * data.c (Faset):
01103c44 9191 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9192 (Fsubst_char_in_region):
9193 * fns.c (concat):
9194 * xdisp.c (decode_mode_spec_coding):
9195 Adjust to CHAR_STRING's new requirement.
9196 * editfns.c (Finsert_char, Fsubst_char_in_region):
9197 * fns.c (concat): Check that character args are actually
9198 characters. Without this test, these functions did the wrong
9199 thing with wildly out-of-range values on 64-bit hosts.
9200
d37ca623
PE
9201 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9202 These casts should not be needed on 32-bit hosts, either.
9203 * keyboard.c (read_char):
9204 * lread.c (Fload): Remove casts to unsigned.
9205
ea204efb
PE
9206 * lisp.h (UNSIGNED_CMP): New macro.
9207 This fixes comparison bugs on 64-bit hosts.
9208 (ASCII_CHAR_P): Use it.
9209 * casefiddle.c (casify_object):
01103c44 9210 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9211 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9212 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9213 * dispextern.h (FACE_FROM_ID):
9214 * keyboard.c (read_char): Use UNSIGNED_CMP.
9215
41cb286c
PE
9216 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9217 not to EMACS_INT, to avoid GCC warning.
9218
4a1b9832
PE
9219 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9220
55daad71
PE
9221 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9222 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9223 isn't needed on 32-bit machines.
8f95c75c 9224
01103c44
PE
9225 * buffer.c (Fgenerate_new_buffer_name):
9226 Use EMACS_INT for count, not int.
0ceccced 9227 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9228
9229 * data.c (Qcompiled_function): Now static.
9230
c6f072e7
PE
9231 * window.c (window_body_lines): Now static.
9232
20ce5912
PE
9233 * image.c (gif_load): Rename local to avoid shadowing.
9234
9c4c5f81
PE
9235 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9236 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9237 * alloc.c (make_save_value): Integer argument is now of type
9238 ptrdiff_t, not int.
9239 (mark_object): Use ptrdiff_t, not int.
9240 * lisp.h (pD): New macro.
9241 * print.c (print_object): Use it.
9242
c0c5c8ae
PE
9243 * alloc.c: Use EMACS_INT, not int, to count objects.
9244 (total_conses, total_markers, total_symbols, total_vector_size)
9245 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9246 (total_free_floats, total_floats, total_free_intervals)
9247 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9248 Now EMACS_INT, not int. All uses changed.
9249 (Fgarbage_collect): Compute overall total using a double, so that
9250 integer overflow is less likely to be a problem. Check for overflow
9251 when converting back to an integer.
5a25e253
PE
9252 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9253 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9254 These were 'int' variables that could overflow on 64-bit hosts;
9255 they were never used, so remove them instead of repairing them.
211a0b2a 9256 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9257 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9258 Previously, this ceilinged at INT_MAX, but that doesn't work on
9259 64-bit machines.
e46bb31a 9260 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9261
c78baabf 9262 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9263 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9264 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9265 when a (possibly-narrower) signed value would do just as well.
9266 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9267
c9d624c6
PE
9268 * alloc.c: Catch some string size overflows that we were missing.
9269 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9270 for convenience in STRING_BYTES_MAX.
9271 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9272 The definition here is exact; the one in lisp.h was approximate.
9273 (allocate_string_data): Check for string overflow. This catches
9274 some instances we weren't catching before. Also, it catches
9275 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9276 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9277 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9278
c9d624c6
PE
9279 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9280 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9281 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9282
353032ce
PE
9283 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9284
2bccce07
PE
9285 * alloc.c (Fmake_string): Check for out-of-range init.
9286
0ac30604
SM
92872011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9288
9289 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9290
c195f2de
JD
92912011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9292
9293 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9294 xg_get_default_scrollbar_width.
9295
9296 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9297 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9298 (style_changed_cb): Call update_theme_scrollbar_width and call
9299 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9300 all frames (Bug#8505).
9301 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9302 Call gtk_window_set_resizable if HAVE_GTK3.
9303 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9304 and height if HAVE_GTK3 (Bug#8505).
9305 (scroll_bar_width_for_theme): New variable.
9306 (update_theme_scrollbar_width): New function.
9307 (xg_get_default_scrollbar_width): Move code to
9308 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9309 (xg_initialize): Call update_theme_scrollbar_width.
9310
9311 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9312
9313 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9314
e10ac9f1
MR
93152011-06-12 Martin Rudalics <rudalics@gmx.at>
9316
9317 * frame.c (make_frame): Call other_buffer_safely instead of
9318 other_buffer.
9319
9320 * window.c (temp_output_buffer_show): Call display_buffer with
9321 second argument Vtemp_buffer_show_specifiers and reset latter
9322 immediately after the call.
9323 (Vtemp_buffer_show_specifiers): New variable.
9324 (auto_window_vscroll_p, next_screen_context_lines)
9325 (Vscroll_preserve_screen_position): Remove leading asterisks from
9326 doc-strings.
9327
2d3c217e 93282011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9329
7b7f97e8 9330 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9331 * buffer.c (Qclone_number): Remove for now, as it's unused.
9332 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9333 (record_buffer): Remove unused local.
9334 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9335 (set_frame_buffer_list): Remove; unused.
9336 * frame.h (other_visible_frames): Remove decl.
9337 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9338 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9339 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9340 if HAVE_GPM.
9341 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9342 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9343 Define only if HAVE_GPM.
9344 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9345 (update_hints_inhibit): Remove; never set. All uses removed.
9346 * widgetprv.h (emacsFrameClassRec): Remove decl.
9347 * window.c (delete_deletable_window): Now returns void, since it
9348 wasn't returning anything.
9349 (compare_window_configurations): Remove unused locals.
9350 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9351 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9352 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9353 the same widths as pointers. This follows up on the 2011-05-06 patch.
9354 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9355 * xterm.h: Likewise.
9356 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9357
1384b89e
JB
93582011-06-12 Juanma Barranquero <lekktu@gmail.com>
9359
9360 * makefile.w32-in: Update dependencies.
9361 (LISP_H): Add lib/intprops.h.
9362
1100a63c
CY
93632011-06-11 Chong Yidong <cyd@stupidchicken.com>
9364
9365 * image.c (gif_load): Add animation frame delay to the metadata.
9366 (syms_of_image): Use DEFSYM. New symbol `delay'.
9367
6198ccd0
MR
93682011-06-11 Martin Rudalics <rudalics@gmx.at>
9369
9370 * window.c (delete_deletable_window): Re-add.
9371 (Fset_window_configuration): Rewrite to handle dead buffers and
9372 consequently deletable windows.
9373 (window_tree, Fwindow_tree): Remove. Supply functionality in
9374 window.el.
9375 (compare_window_configurations): Simplify code.
9376
b6e3633c
AS
93772011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9378
1ab0dee5
AS
9379 * image.c (imagemagick_load_image): Fix type mismatch.
9380 (Fimagemagick_types): Likewise.
9381
b6e3633c
AS
9382 * window.h (replace_buffer_in_windows): Declare.
9383
9397e56f
MR
93842011-06-11 Martin Rudalics <rudalics@gmx.at>
9385
9386 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9387 Qclone_number. Remove external declaration of Qdelete_window.
9388 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9389 code.
640c8776
SM
9390 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9391 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9392 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9393 buffer list implementation.
9394 (other_buffer_safely): New function.
9395 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9396 calls to replace_buffer_in_windows and
9397 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9398 if allowed.
9399 (record_buffer): Inhibit quitting and rewrite using quittable
9400 functions. Run Qbuffer_list_update_hook if allowed.
9401 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9402 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9403 Move switch-to-buffer to window.el.
9397e56f
MR
9404 (bury-buffer): Move to window.el.
9405 (Vbuffer_list_update_hook): New variable.
9406
9407 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9408 section.
9409
9410 * window.h (resize_frame_windows): Move up in code.
9411 (Fwindow_frame): Remove EXFUN.
9412 (replace_buffer_in_all_windows): Remove prototype.
9413 (replace_buffer_in_windows_safely): Add prototype.
9414
9415 * window.c: Declare Qdelete_window static again. Move down
9416 declaration of select_count.
9417 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9418 (Fother_window): Move to window.el.
9419 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9420 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9421 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9422 window.el.
9423 (replace_buffer_in_windows): Implement by calling
9424 Qreplace_buffer_in_windows.
9425 (replace_buffer_in_all_windows): Remove with some functionality
9426 moved into replace_buffer_in_windows_safely.
9427 (replace_buffer_in_windows_safely): New function.
9428 (select_window_norecord, select_frame_norecord): Move in front
9429 of run_window_configuration_change_hook. Remove now obsolete
9430 declarations.
640c8776
SM
9431 (Fset_window_buffer): Rewrite doc-string.
9432 Call Qrecord_window_buffer.
9397e56f
MR
9433 (keys_of_window): Move binding for other-window to window.el.
9434
b50691aa
CY
94352011-06-11 Chong Yidong <cyd@stupidchicken.com>
9436
9437 * dispextern.h (struct image): Replace data member, whose int_val
9438 and ptr_val fields were not used by anything, with a single
9439 lisp_val object.
9440
9441 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9442 (gif_clear_image, gif_load, imagemagick_load_image)
9443 (gs_clear_image, gs_load): Callers changed.
9444
3f754b86
PE
94452011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9446
cca69397
PE
9447 * buffer.h: Include <time.h>, for time_t.
9448 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9449
109e28d0
PE
9450 Fix minor problems found by static checking.
9451
60737f02
PE
9452 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9453
4b66faf3
PE
9454 Make identifiers static if they are not used in other modules.
9455 * data.c (Qcompiled_function, Qframe, Qvector):
9456 * image.c (QimageMagick, Qsvg):
9457 * minibuf.c (Qmetadata):
9458 * window.c (resize_window_check, resize_root_window): Now static.
9459 * window.h (resize_window_check, resize_root_window): Remove decls.
9460
109e28d0
PE
9461 * window.c (window_deletion_count, delete_deletable_window):
9462 Remove; unused.
46a4ce9e
PE
9463 (window_body_lines): Now static.
9464 (Fdelete_other_windows_internal): Mark vars as initialized.
9465 Make sure 'resize_failed' is initialized.
9466 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9467 (resize_window_apply): Remove unused local.
9468 * window.h (delete_deletable_window): Remove decl.
9469
109e28d0 9470 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9471 (imagemagick_load_image): Fix pointer signedness problem by changing
9472 last arg from unsigned char * to char *. All uses changed.
9473 Also, fix a local for similar reasons.
9474 Remove unused locals. Remove locals to avoid shadowing.
9475 (fn_rsvg_handle_free): Remove; unused.
9476 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9477 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9478
3f754b86
PE
9479 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9480
2547adb1
CY
94812011-06-10 Chong Yidong <cyd@stupidchicken.com>
9482
9483 * image.c (gif_load): Fix omitted cast error introduced by
9484 2011-06-06 change.
9485
2c8e37d4
MR
94862011-06-10 Martin Rudalics <rudalics@gmx.at>
9487
9488 * window.h (resize_proportionally, orig_total_lines)
9489 (orig_top_line): Remove from window structure.
9490 (set_window_height, set_window_width, change_window_heights)
9491 (Fdelete_window): Remove prototypes.
9492 (resize_frame_windows): Remove duplicate declaration.
9493
440a42e3
EZ
94942011-06-10 Eli Zaretskii <eliz@gnu.org>
9495
9496 * window.h (resize_frame_windows, resize_window_check)
9497 (delete_deletable_window, resize_root_window)
9498 (resize_frame_windows): Declare prototypes.
9499
9500 * window.c (resize_window_apply): Make definition be "static" to
9501 match the prototype.
9502
562dd5e9
MR
95032011-06-10 Martin Rudalics <rudalics@gmx.at>
9504
9505 * window.c: Remove declarations of Qwindow_size_fixed,
9506 window_min_size_1, window_min_size_2, window_min_size,
9507 size_window, window_fixed_size_p, enlarge_window, delete_window.
9508 Remove static from declaration of Qdelete_window, it's
9509 temporarily needed by Fbury_buffer.
9510 (replace_window): Don't assign orig_top_line and
9511 orig_total_lines.
9512 (Fdelete_window, delete_window): Remove. Window deletion is
9513 handled by window.el.
640c8776
SM
9514 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9515 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9516 (Fdelete_other_windows): Remove. Deleting other windows is
9517 handled by window.el.
9518 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9519 handled in window.el.
9520 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9521 Window minimum sizes are handled in window.el.
9522 (shrink_windows, size_window, set_window_height)
9523 (set_window_width, change_window_heights, window_height)
9524 (window_width, CURBEG, CURSIZE, enlarge_window)
9525 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9526 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9527 handled in window.el.
9528 (make_dummy_parent): Rename to make_parent_window and give it a
9529 second argument horflag.
9530 (make_window): Don't set resize_proportionally any more.
9531 (Fsplit_window): Remove. Windows are split in window.el.
9532 (save_restore_action, save_restore_orig_size)
9533 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9534 Resize mini windows in window.el.
9535 (grow_mini_window, shrink_mini_window): Implement by calling
9536 Qresize_root_window_vertically, resize_window_check and
9537 resize_window_apply.
640c8776
SM
9538 (saved_window, Fset_window_configuration, save_window_save):
9539 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9540 resize_proportionally.
9541 (window_min_height, window_min_width): Move to window.el.
9542 (keys_of_window): Move bindings for delete-other-windows,
9543 split-window, delete-window and enlarge-window to window.el.
9544
9545 * buffer.c: Temporarily extern Qdelete_window.
9546 (Fbury_buffer): Temporarily call Qdelete_window instead of
9547 Fdelete_window (Fbury_buffer will move to window.el soon).
9548
9549 * frame.c (set_menu_bar_lines_1): Remove code handling
9550 orig_top_line and orig_total_lines.
9551
9552 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9553 set_window_height but set heights directly.
9554 (change_frame_size_1): Use resize_frame_windows.
9555
9556 * xdisp.c (init_xdisp): Don't use set_window_height but set
9557 heights directly.
9558
640c8776
SM
9559 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9560 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9561 run_window_configuration_change_hook.
9562
9563 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9564 instead of change_window_heights and run
9565 run_window_configuration_change_hook.
9566
1a13852e
MR
95672011-06-09 Martin Rudalics <rudalics@gmx.at>
9568
9569 * window.c (replace_window): Rename second argument REPLACEMENT to
9570 NEW. New third argument SETFLAG. Rewrite.
9571 (delete_window, make_dummy_parent): Call replace_window with
9572 third argument 1.
9573 (window_list_1): Move down in code.
9574 (run_window_configuration_change_hook): Move set_buffer part
9575 before select_frame_norecord part in order to unwind correctly.
9576 Rename count1 to count.
9577 (recombine_windows, delete_deletable_window, resize_root_window)
9578 (Fdelete_other_windows_internal)
9579 (Frun_window_configuration_change_hook, make_parent_window)
9580 (resize_window_check, resize_window_apply, Fresize_window_apply)
9581 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9582 (Fdelete_window_internal, Fresize_mini_window_internal):
9583 New functions.
1a13852e
MR
9584 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9585
f3d1777e
MR
95862011-06-08 Martin Rudalics <rudalics@gmx.at>
9587
496e208e
MR
9588 * window.h (window): Add some new members to window structure -
9589 normal_lines, normal_cols, new_total, new_normal, clone_number,
9590 splits, nest, prev_buffers, next_buffers.
9591 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9592 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9593
f3d1777e
MR
9594 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9595 Remove.
496e208e
MR
9596 (make_dummy_parent): Set new members of windows structure.
9597 (make_window): Move down in code. Handle new members of window
9598 structure.
9599 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9600 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9601 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9602 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9603 (Fset_window_next_buffers, Fset_window_clone_number):
9604 New functions.
496e208e
MR
9605 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9606 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9607 Doc-string fixes.
9608 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9609 Argument WINDOW can be now internal window too.
9610 (Fwindow_use_time): Move up in code.
9611 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9612 Rewrite doc-string.
9613 (Fset_window_configuration, saved_window)
9614 (Fcurrent_window_configuration, save_window_save): Handle new
9615 members of window structure.
b9e809c2
MR
9616 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9617 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9618 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9619 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9620 Qget_mru_window, Qresize_root_window,
9621 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9622 Qauto_buffer_name; staticpro them.
f3d1777e 9623
abde8f8c
MR
96242011-06-07 Martin Rudalics <rudalics@gmx.at>
9625
9626 * window.c (Fwindow_total_size, Fwindow_left_column)
9627 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9628 (Fwindow_list_1): New functions.
9629 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9630 (Fwindow_width, Fscroll_left, Fscroll_right):
9631 Use window_body_cols instead of window_box_text_cols.
9632 (delete_window, Fset_window_configuration):
9633 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9634 (delete_all_subwindows): Take a window as argument and not a
9635 structure. Rewrite.
190b47e6
MR
9636 (window_loop): Remove handling of GET_LRU_WINDOW and
9637 GET_LARGEST_WINDOW.
9638 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9639
9640 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9641 window_box_text_cols. delete_all_subwindows now takes a
9642 Lisp_Object as argument.
abde8f8c 9643
640c8776
SM
9644 * indent.c (compute_motion, Fcompute_motion):
9645 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9646
fa8a67e6
MR
9647 * frame.c (delete_frame): Call delete_all_subwindows with root
9648 window as argument.
9649
a54e3482
DC
96502011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9651
9652 * fns.c (Fputhash): Document return value.
9653
60002bf5
CY
96542011-06-06 Chong Yidong <cyd@stupidchicken.com>
9655
9656 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9657
0c671da6 96582011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9659
b862a52a 9660 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9661
be44ca6c
PE
9662 Check for overflow when converting integer to cons and back.
9663 * charset.c (Fdefine_charset_internal, Fdecode_char):
9664 Use cons_to_unsigned to catch overflow.
9665 (Fencode_char): Use INTEGER_TO_CONS.
9666 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9667 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9668 * data.c (long_to_cons, cons_to_long): Remove.
9669 (cons_to_unsigned, cons_to_signed): New functions.
9670 These signal an error for invalid or out-of-range values.
9671 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9672 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9673 * font.c (Ffont_variation_glyphs):
9674 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9675 * lisp.h: Include <intprops.h>.
9676 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9677 (cons_to_signed, cons_to_unsigned): New decls.
9678 (long_to_cons, cons_to_long): Remove decls.
9679 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9680 (Fprimitive_undo): Use CONS_TO_INTEGER.
9681 * xfns.c (Fx_window_property): Likewise.
9682 * xselect.c: Include <limits.h>.
9683 (x_own_selection, selection_data_to_lisp_data):
9684 Use INTEGER_TO_CONS.
9685 (x_handle_selection_request, x_handle_selection_clear)
9686 (x_get_foreign_selection, Fx_disown_selection_internal)
9687 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9688 (lisp_data_to_selection_data): Use cons_to_unsigned.
9689 (x_fill_property_data): Use cons_to_signed.
9690 Report values out of range.
9691
d1f3d2af
PE
9692 Check for buffer and string overflow more precisely.
9693 * buffer.h (BUF_BYTES_MAX): New macro.
9694 * lisp.h (STRING_BYTES_MAX): New macro.
9695 * alloc.c (Fmake_string):
9696 * character.c (string_escape_byte8):
9697 * coding.c (coding_alloc_by_realloc):
9698 * doprnt.c (doprnt):
9699 * editfns.c (Fformat):
9700 * eval.c (verror):
9701 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9702 since they may not be the same number.
9703 * editfns.c (Finsert_char):
9704 * fileio.c (Finsert_file_contents):
9705 Likewise for BUF_BYTES_MAX.
9706
dd52fcea
PE
9707 * image.c: Use ptrdiff_t, not int, for sizes.
9708 (slurp_file): Switch from int to ptrdiff_t.
9709 All uses changed.
9710 (slurp_file): Check that file size fits in both size_t (for
9711 malloc) and ptrdiff_t (for sanity and safety).
9712
7f9bbdbb
PE
9713 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9714 if b->modtime has its maximal value.
9715
dfe18f82
PE
9716 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9717
84acfcf0
PE
9718 Don't assume time_t can fit into int.
9719 * buffer.h (struct buffer.modtime): Now time_t, not int.
9720 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9721 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9722
ccd9a01a
PE
9723 Minor fixes for signed vs unsigned integers.
9724 * character.h (MAYBE_UNIFY_CHAR):
9725 * charset.c (maybe_unify_char):
9726 * keyboard.c (read_char, reorder_modifiers):
9727 XINT -> XFASTINT, since the integer must be nonnegative.
9728 * ftfont.c (ftfont_spec_pattern):
9729 * keymap.c (access_keymap, silly_event_symbol_error):
9730 XUINT -> XFASTINT, since the integer must be nonnegative.
9731 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9732 since it makes no difference and we prefer signed.
9733 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9734 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9735 nonnegative.
9736
d6d100dd
SM
97372011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9738
9739 * window.h (Fwindow_frame): Declare.
9740
2b6148e4
PE
97412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9742
9743 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9744 (SPARE_MEMORY): Always define.
9745 (LARGE_REQUEST): Remove.
9746 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9747
f230ecc9
MR
97482011-06-06 Martin Rudalics <rudalics@gmx.at>
9749
727e958e
MR
9750 * lisp.h: Move EXFUNS for Fframe_root_window,
9751 Fframe_first_window and Fset_frame_selected_window to window.h.
9752
9753 * window.h: Move EXFUNS for Fframe_root_window,
9754 Fframe_first_window and Fset_frame_selected_window here from
9755 lisp.h.
9756
9757 * frame.c (Fwindow_frame, Fframe_first_window)
9758 (Fframe_root_window, Fframe_selected_window)
9759 (Fset_frame_selected_window): Move to window.c.
9760 (Factive_minibuffer_window): Move to minibuf.c.
9761 (Fother_visible_frames_p): New function.
9762
9763 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9764
f230ecc9
MR
9765 * window.c (decode_window, decode_any_window): Move up in code.
9766 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9767 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9768 (Fwindow_buffer): Move up and rewrite doc-string.
9769 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9770 (Fwindow_prev): New functions.
727e958e
MR
9771 (Fwindow_frame): Move here from frame.c. Accept any window as
9772 argument.
9773 (Fframe_root_window, Fframe_first_window)
9774 (Fframe_selected_window): Move here from frame.c. Accept frame
9775 or arbitrary window as argument. Update doc-strings.
9776 (Fminibuffer_window): Move up in code.
9777 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9778 (Fset_frame_selected_window): Move here from frame.c.
9779 Marginal rewrite.
727e958e
MR
9780 (Fselected_window, select_window, Fselect_window): Move up in
9781 code. Minor doc-string fixes.
f230ecc9 9782
4d09bcf6
PE
97832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9784
9785 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9786 Do not assume that spare memory exists; that assumption is valid
9787 only if SYSTEM_MALLOC.
9788 (LARGE_REQUEST): New macro, so that the issue of large requests
9789 is separated from the issue of spare memory.
9790
810928a2
AS
97912011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9792
172418ad
AS
9793 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9794 format. (Bug#8806)
9795
43f862f7
AS
9796 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9797
810928a2
AS
9798 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9799 before statements.
9800
a059fe24
JD
98012011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9802
9803 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9804
9805 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9806
9807 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9808 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9809
989bf368
JB
98102011-06-05 Juanma Barranquero <lekktu@gmail.com>
9811
9812 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9813
4b80f674
CY
98142011-06-04 Chong Yidong <cyd@stupidchicken.com>
9815
9816 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9817 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9818 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9819 New error handlers.
4b80f674
CY
9820 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9821 Obey Vx_select_enable_clipboard_manager. Catch errors in
9822 x_clipboard_manager_save (Bug#8779).
9823 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9824 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9825
99a33b77 98262011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9827
9828 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9829
99a33b77 98302011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9831
9832 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9833 in the current matrix if keep_current_p is non-zero.
9834
8264569d
EZ
98352011-06-04 Eli Zaretskii <eliz@gnu.org>
9836
9837 * bidi.c (bidi_level_of_next_char): Fix last change.
9838
57f97249
EZ
98392011-06-03 Eli Zaretskii <eliz@gnu.org>
9840
fec2107c 9841 Support bidi reordering of text covered by display properties.
57f97249 9842
fec2107c
EZ
9843 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9844 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9845 (bidi_cache_search, bidi_cache_iterator_state)
9846 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9847 (bidi_level_of_next_char, bidi_move_to_visually_next):
9848 Support character positions inside a run of characters covered by a
fec2107c
EZ
9849 display string.
9850 (bidi_paragraph_init, bidi_resolve_explicit_1)
9851 (bidi_level_of_next_char): Call bidi_fetch_char and
9852 bidi_fetch_char_advance instead of FETCH_CHAR and
9853 FETCH_CHAR_ADVANCE.
9854 (bidi_init_it): Initialize new members.
9855 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9856 definitions.
9857 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9858 instead of using explicit *_CHAR codes.
d6d100dd
SM
9859 (bidi_resolve_explicit, bidi_resolve_weak):
9860 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9861 bidirectional text is supported only in multibyte buffers.
9862 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9863 it to initialize the frame_window_p member of struct bidi_it.
9864 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9865 (bidi_resolve_explicit, bidi_resolve_weak)
9866 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9867 bidi_it->nchars is non-positive.
9868 (bidi_level_of_next_char): Don't try to lookup the cache for the
9869 next/previous character if nothing is cached there yet, or if we
9870 were just reseat()'ed to a new position.
c40e2fb2 9871
0e14fe90
EZ
9872 * xdisp.c (set_cursor_from_row): Set start and stop points
9873 according to the row's direction when priming the loop that looks
9874 for the glyph on which to display cursor.
9875 (single_display_spec_intangible_p): Function deleted.
9876 (display_prop_intangible_p): Reimplement to call
9877 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9878 Accept 3 additional arguments needed by handle_display_spec.
9879 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9880 values: lists, `(when COND...)' forms, etc.
9881 (single_display_spec_string_p): Support property values that are
9882 lists with the argument STRING its top-level element.
9883 (display_prop_string_p): Fix the condition for processing a
9884 property that is a list to be consistent with handle_display_spec.
fec2107c 9885 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9886 last portion of handle_display_prop.
9887 (compute_display_string_pos): Accept additional argument
9888 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9889 value of a `display' property is a "replacing spec".
9890 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9891 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9892 the display property, but just return a value indicating whether
9893 the display property will replace the characters it covers.
9894 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9895 frame_window_p members of struct bidi_it.
d6d100dd
SM
9896 (compute_display_string_pos, compute_display_string_end):
9897 New functions.
fec2107c
EZ
9898 (push_it): Accept second argument POSITION, where pop_it should
9899 jump to continue iteration.
9900 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9901
fec2107c
EZ
9902 * keyboard.c (adjust_point_for_property): Adjust the call to
9903 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9904
9905 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9906 (bidi_init_it): Update prototypes.
9907 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9908 (compute_display_string_pos, compute_display_string_end):
9909 Declare prototypes.
fec2107c
EZ
9910 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9911 EMACS_INT.
fc6f18ce 9912
40087514 99132011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9914
57f53182
PE
9915 Malloc failure behavior now depends on size of allocation.
9916 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9917 * lisp.h: Change signatures accordingly.
9918 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9919 All callers changed. (Bug#8762)
9920
9921 * gnutls.c: Use Emacs's memory allocators.
9922 Without this change, the gnutls library would invoke malloc etc.
9923 directly, which causes problems on non-SYNC_INPUT hosts, and which
9924 runs afoul of improving memory_full behavior. (Bug#8761)
9925 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9926 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9927 xfree instead of the default malloc, realloc, free.
9928 (Fgnutls_boot): No need to check for memory allocation failure,
9929 since xmalloc does that for us.
9930
ac32cd99 9931 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9932 * category.c (hash_get_category_set):
9933 * ccl.c (ccl_driver):
9934 * charset.c (Fdefine_charset_internal):
9935 * charset.h (struct charset.hash_index):
9936 * composite.c (get_composition_id, gstring_lookup_cache)
9937 (composition_gstring_put_cache):
9938 * composite.h (struct composition.hash_index):
9939 * dispextern.h (struct image.hash):
9940 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9941 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9942 (hashfn_equal, hashfn_user_defined, make_hash_table)
9943 (maybe_resize_hash_table, hash_lookup, hash_put)
9944 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9945 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9946 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9947 * image.c (make_image, search_image_cache, lookup_image)
9948 (xpm_put_color_table_h):
9949 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9950 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9951 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9952 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9953 * alloc.c (allocate_vectorlike):
9954 Check for overflow in vector size calculations.
9955 * ccl.c (ccl_driver):
9956 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9957 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9958 need to be updated by these changes.
40087514
PE
9959 * fns.c (make_hash_table, maybe_resize_hash_table):
9960 Check for integer overflow with large hash tables.
0de4bb68
PE
9961 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9962 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9963 (SXHASH_REDUCE): New macro.
9964 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9965 Use it instead of discarding useful hash info with large hash values.
9966 (sxhash_float): New function.
9967 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9968 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9969 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9970 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9971 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9972 Adjust signatures to match updated version of code.
9973 (consing_since_gc): Now EMACS_INT, since a single hash table can
9974 use more than INT_MAX bytes.
9975
698d32e2
DN
99762011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9977
9978 Make it possible to build with GCC-4.6+ -O2 -flto.
9979
9980 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9981
fd6fa53f
SM
99822011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9983
9984 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9985 Call minibuffer-inactive-mode.
9986
864db017
JB
99872011-05-31 Juanma Barranquero <lekktu@gmail.com>
9988
9989 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9990 Update dependencies.
9991
2ad0baf4
DN
99922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9993
9994 * data.c (init_data): Remove code for UTS, this system is not
9995 supported anymore.
9996
4fcc2638
DN
99972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9998
9999 Don't force ./temacs to start in terminal mode.
10000
10001 * frame.c (make_initial_frame): Initialize faces in all cases, not
10002 only when CANNOT_DUMP is defined.
10003 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10004
c56e0fd5
DN
100052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10006
10007 * dispnew.c (add_window_display_history): Use const for the string
10008 pointer. Remove declaration, not needed.
10009
333d54da 100102011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10011
55d4c1b2 10012 Use 'inline', not 'INLINE'.
333d54da 10013 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10014 * alloc.c, fontset.c (INLINE): Remove.
10015 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10016 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10017 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10018 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10019 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10020
738db178
DN
100212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10022
10023 Make it possible to run ./temacs.
10024
10025 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10026 syms_of_callproc does the same thing. Remove test for
10027 "initialized", do it in the caller.
10028 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10029
620c53a6
SM
100302011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10031
10032 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10033 (read_minibuf): Use get_minibuffer.
10034 (syms_of_minibuf): Use DEFSYM.
10035 (Qmetadata): New var.
10036 * data.c (Qbuffer): Don't make it static.
10037 (syms_of_data): Use DEFSYM.
10038
e003a292
PE
100392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10040
10041 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10042 (CCL_CODE_MIN): New macro.
10043
ed008a6d
PE
100442011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10045
3687c2ef
PE
10046 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10047
ed008a6d
PE
10048 * eval.c (Qdebug): Now static.
10049 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10050 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10051 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10052
d66c4c7c
CY
100532011-05-29 Chong Yidong <cyd@stupidchicken.com>
10054
10055 * image.c: Various fixes to ImageMagick code comments.
10056 (Fimagemagick_types): Doc fix.
10057
5fbc2025
PE
100582011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10059
0196f88a
PE
10060 Minor fixes prompted by GCC 4.6.0 warnings.
10061
10062 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10063
5fbc2025
PE
10064 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10065 (x_clipboard_manager_save_all): Move extern decl to ...
10066 * xterm.h: ... here, so that it can be checked for consistency.
10067
1dd3c2d9
CY
100682011-05-29 Chong Yidong <cyd@stupidchicken.com>
10069
10070 * xselect.c (x_clipboard_manager_save_frame)
10071 (x_clipboard_manager_save_all): New functions.
10072 (Fx_clipboard_manager_save): Lisp function deleted.
10073
10074 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10075 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10076
10077 * xterm.h: Update prototype.
10078
5ba6571d
WX
100792011-05-28 William Xu <william.xwl@gmail.com>
10080
10081 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10082 exiting (Bug#8239).
10083
3eaff834
JM
100842011-05-28 Jim Meyering <meyering@redhat.com>
10085
e1900994 10086 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10087 * fns.c (to_uchar): Define.
10088 (crypto_hash_function): Use it to convert some newly-signed
10089 variables to unsigned, to avoid sign-extension bugs. For example,
10090 without this change, (md5 "truc") would evaluate to
10091 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10092 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10093 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10094
0f6990a7
PE
100952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10096
10097 Integer overflow fixes.
c8a9ca5a 10098
08686060
PE
10099 * dbusbind.c: Serial number integer overflow fixes.
10100 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10101 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10102 to hold a serial number that is too large for a fixnum.
10103 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10104 Check for serial numbers out of range. Decode any serial number
59568bf0 10105 that was so large that it became a float. (Bug#8722)
08686060 10106
2d1fc3c7
PE
10107 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10108 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10109 Use XFASTINT rather than XUINT when numbers are nonnegative.
10110 (xd_append_arg, Fdbus_method_return_internal):
10111 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10112 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10113 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10114 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10115 (Bug#8722)
2d1fc3c7 10116
c8a9ca5a
PE
10117 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10118
519e1d69
PE
10119 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10120
6df6ae42 10121 ccl: Add integer overflow checks.
30569699
PE
10122 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10123 (IN_INT_RANGE): New macros.
10124 (ccl_driver): Use them to check for integer overflow when
10125 decoding a CCL program. Many of the new checks are whether XINT (x)
10126 fits in int; it doesn't always, on 64-bit hosts. The new version
10127 doesn't catch all possible integer overflows, but it's an
847044ea 10128 improvement. (Bug#8719)
30569699 10129
c11285dc
PE
10130 * alloc.c (make_event_array): Use XINT, not XUINT.
10131 There's no need for unsigned here.
10132
fdccd48e
PE
10133 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10134 This follows up to the 2011-05-06 change that substituted uintptr_t
10135 for EMACS_INT. This case wasn't caught back then.
10136
37910ab2
PE
10137 Rework Fformat to avoid integer overflow issues.
10138 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10139 now (part of C89). Include <verify.h>.
10140 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10141 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10142 (Fformat): Avoid the prepass trying to compute sizes; it was only
10143 approximate and thus did not catch overflow reliably. Instead, walk
10144 through the format just once, formatting and computing sizes as we go,
10145 checking for integer overflow at every step, and allocating a larger
10146 buffer as needed. Keep track separately whether the format is
10147 multibyte. Keep only the most-recently calculated precision, rather
10148 than them all. Record whether each argument has been converted to
10149 string. Use EMACS_INT, not int, for byte and char and arg counts.
10150 Support field widths and precisions larger than INT_MAX. Avoid
10151 sprintf's undefined behavior with conversion specifications such as %#d
10152 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10153 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10154 formatting out-of-range floating point numbers with int
9173deec 10155 formats. (Bug#8668)
37910ab2 10156
2e6578fb
PE
10157 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10158
0ae6bdee
PE
10159 * data.c: Avoid integer truncation in expressions involving floats.
10160 * data.c: Include <intprops.h>.
10161 (arith_driver): When there's an integer overflow in an expression
10162 involving floating point, convert the integers to floating point
10163 so that the resulting value does not suffer from catastrophic
10164 integer truncation. For example, on a 64-bit host (* 4
10165 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10166 Do not rely on undefined behavior after integer overflow.
10167
de883a70
PE
10168 merge count_size_as_multibyte, parse_str_to_multibyte
10169 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10170 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10171 Check for integer overflow.
10172 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10173 since it's now a duplicate of the other. This is more of
10174 a character than a buffer op, so better that it's in character.c.
10175 * fns.c, print.c: Adjust to above changes.
10176
2ff916cb
PE
101772011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10178
10179 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10180
f1b54466
PE
101812011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10182
fb1ac845
PE
10183 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10184 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10185 (x_clipboard_manager_save): Now static.
10186 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10187
f1b54466
PE
10188 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10189 (crypto_hash_function): Now static.
10190 Fix pointer signedness problems. Avoid unnecessary initializations.
10191
a9f737ee
CY
101922011-05-27 Chong Yidong <cyd@stupidchicken.com>
10193
10194 * termhooks.h (Vselection_alist): Make it terminal-local.
10195
10196 * terminal.c (create_terminal): Initialize it.
10197
10198 * xselect.c: Support for clipboard managers.
10199 (Vselection_alist): Move to termhooks.h as terminal-local var.
10200 (LOCAL_SELECTION): New macro.
10201 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10202 (symbol_to_x_atom): Remove gratuitous arg.
10203 (x_handle_selection_request, lisp_data_to_selection_data)
10204 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10205 (x_own_selection, x_get_local_selection, x_convert_selection):
10206 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10207 (some_frame_on_display): Delete unused function.
10208 (Fx_own_selection_internal, Fx_get_selection_internal)
10209 (Fx_disown_selection_internal, Fx_selection_owner_p)
10210 (Fx_selection_exists_p): New optional frame arg.
10211 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10212 (x_handle_selection_clear): Don't treat other terminals with the
10213 same keyboard specially. Use the terminal-local Vselection_alist.
10214 (x_clear_frame_selections): Use Frun_hook_with_args.
10215
10216 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10217
10218 * xterm.h: Add support for those atoms.
10219
e067f0c1
CY
102202011-05-26 Chong Yidong <cyd@stupidchicken.com>
10221
10222 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10223 (converted_selections, conversion_fail_tag): New global variables.
10224 (x_selection_request_lisp_error): Free the above.
10225 (x_get_local_selection): Remove unnecessary code.
10226 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10227 of converted selections stored in converted_selections.
10228 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10229 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10230 (x_convert_selection): New function.
10231 (x_handle_selection_event): Simplify.
10232 (x_get_foreign_selection): Don't ignore incoming requests while
10233 waiting for an answer; this will fail when we implement
10234 SAVE_TARGETS, and seems unnecessary anyway.
10235 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10236 (Vx_sent_selection_functions): Doc fix.
10237
0f4aebc0
LL
102382011-05-26 Leo Liu <sdl.web@gmail.com>
10239
10240 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10241
e61124cd
YM
102422011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10243
10244 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10245
10246 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10247 for fringe update if it has periodic bitmap.
ac389d0c 10248 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10249 and fringe_bitmap_periodic_p.
10250
10251 * fringe.c (get_fringe_bitmap_data): New function.
10252 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10253 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10254 row. Mark glyph row for fringe update if periodicity changed.
10255
10256 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10257 for fringe update unless it has periodic bitmap.
10258
f16d9837
KH
102592011-05-25 Kenichi Handa <handa@m17n.org>
10260
10261 * xdisp.c (get_next_display_element): Set correct it->face_id for
10262 a static composition.
10263
e1b90ef6
LL
102642011-05-24 Leo Liu <sdl.web@gmail.com>
10265
10266 * deps.mk (fns.o):
10267 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10268
10269 * fns.c (crypto_hash_function, Fsha1): New function.
10270 (Fmd5): Use crypto_hash_function.
10271 (syms_of_fns): Add Ssha1.
10272
7400048f
PE
102732011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10274
10275 * gnutls.c: Remove unused macros.
10276 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10277 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10278 Remove macros that are defined and never used.
10279 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10280
abb71cf4
CY
102812011-05-22 Chong Yidong <cyd@stupidchicken.com>
10282
10283 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10284 (Fx_get_selection_internal): Minor cleanup.
10285 (Fx_own_selection_internal): Rename arguments for consistency with
10286 select.el.
10287
6307db39
PE
102882011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10289
10290 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10291
f3d4e0a4
CY
102922011-05-22 Chong Yidong <cyd@stupidchicken.com>
10293
10294 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10295
4d8ade89
YM
102962011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10297
10298 * dispnew.c (scrolling_window): Don't exclude the case that the
10299 last enabled row in the desired matrix touches the bottom boundary.
10300
32078c8d
GM
103012011-05-21 Glenn Morris <rgm@gnu.org>
10302
10303 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10304 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10305 and add some more files.
32078c8d 10306
7285dc67
EZ
103072011-05-20 Eli Zaretskii <eliz@gnu.org>
10308
10309 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10310 report_file_error introduced by the change from 2011-05-07.
10311
89d1bd22
PE
103122011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10313
10314 * systime.h (Time): Define only if emacs is defined.
10315 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10316 where the include path doesn't have X11/X.h by default. See
10317 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10318
cd394be1 103192011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10320
10321 * composite.c (find_automatic_composition): Fix previous change.
10322
b9704ad9
GM
103232011-05-20 Glenn Morris <rgm@gnu.org>
10324
10325 * lisp.mk: New file, split from Makefile.in.
10326 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10327 (shortlisp): Remove.
10328 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10329
4a720484
GM
103302011-05-19 Glenn Morris <rgm@gnu.org>
10331
10332 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10333 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10334 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10335 (lisp): Set the order to that of loadup.el.
10336 (shortlisp): Make it a copy of $lisp.
10337 (SOME_MACHINE_LISP): Remove.
10338 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10339 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10340
a28d4396
KH
103412011-05-18 Kenichi Handa <handa@m17n.org>
10342
10343 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10344 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10345 (find_automatic_composition): Mostly rewrite for efficiency.
10346
a2b1fa8e
JB
103472011-05-18 Juanma Barranquero <lekktu@gmail.com>
10348
10349 * makefile.w32-in: Update dependencies.
10350
8e1f5610
CS
103512011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10352
10353 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10354 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10355
7025ee00 103562011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10357
cdfa6eab
PE
10358 Fix some integer overflow issues, such as string length overflow.
10359
06d6db33
PE
10360 * insdel.c (count_size_as_multibyte): Check for string overflow.
10361
2b4560a8
PE
10362 * character.c (lisp_string_width): Check for string overflow.
10363 Use EMACS_INT, not int, for string indexes and lengths; in
10364 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10365 the resulting string length overflows an EMACS_INT; instead,
10366 report a string overflow if no precision given. When checking for
10367 precision exhaustion, use a check that cannot possibly have
10368 integer overflow. (Bug#8675)
10369 * character.h (lisp_string_width): Adjust to new signature.
10370
cb93f9be
PE
10371 * alloc.c (string_overflow): New function.
10372 (Fmake_string): Use it. This doesn't change behavior, but saves
10373 a few bytes and will simplify future changes.
10374 * character.c (string_escape_byte8): Likewise.
10375 * lisp.h (string_overflow): New decl.
10376
1a1f3366
PE
10377 Fixups, following up to the user-interface timestamp change.
10378 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10379 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10380 * msdos.c (mouse_get_pos): Likewise.
10381 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10382 * w32gui.h (Time): Define by including "systime.h" rather than by
10383 declaring it ourselves. (Bug#8664)
10384
d4e3e4d3
PE
10385 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10386 * image.c (clear_image_cache): Likewise.
10387
f6a24d19
PE
10388 * term.c (term_mouse_position): Don't assume time_t wraparound.
10389
08dc5ae6
PE
10390 Be more systematic about user-interface timestamps.
10391 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10392 and sometimes 'EMACS_UINT', to represent these timestamps.
10393 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10394 This makes the code easier to follow, and makes it easier to catch
10395 integer overflow bugs such as Bug#8664.
10396 * frame.c (Fmouse_position, Fmouse_pixel_position):
10397 Use Time, not unsigned long, for user-interface timestamps.
10398 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10399 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10400 * keyboard.h (last_event_timestamp): Likewise.
10401 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10402 * menu.h (xmenu_show): Likewise.
10403 * term.c (term_mouse_position): Likewise.
10404 * termhooks.h (struct input_event.timestamp): Likewise.
10405 (struct terminal.mouse_position_hook): Likewise.
10406 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10407 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10408 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10409 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10410 what it was before.
10411 * menu.h, termhooks.h: Include "systime.h", for Time.
10412
8e55734a
PE
10413 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10414 Don't assume that the difference between two unsigned long values
10415 can fit into an integer. At this point, we know button_down_time
10416 <= event->timestamp, so the difference must be nonnegative, so
10417 there's no need to cast the result if double-click-time is
10418 nonnegative, as it should be; check that it's nonnegative, just in
10419 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10420 apart (about 25 days). (Bug#8664)
8e55734a 10421
841f1b75 10422 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10423 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10424
3e26f69c
PE
10425 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10426 that always fit in int. Use a sentinel instead of a counter, to
10427 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10428 * frame.h (struct frame): Use int for menu_bar_items_used
10429 instead of EMACS_INT, since it always fits in int.
3e26f69c 10430
5cc152c0
PE
10431 * menu.c (grow_menu_items): Check for int overflow.
10432
d89eb65e
PE
10433 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10434
5235bd3e
PE
10435 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10436 Before, the code was not consistent. These values cannot exceed
10437 2**31 - 1 so there's no need to make them unsigned.
10438 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10439 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10440 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10441 as modifiers.
10442 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10443
bc827e23
PE
10444 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10445 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10446 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10447 presumably because the widths might not match.
10448
78eb494e
PE
10449 * window.c (size_window): Avoid needless test at loop start.
10450
04f2d78b
CB
104512011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10452
10453 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10454
d2fc7e3d 104552011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10456
10457 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10458
d2fc7e3d 104592011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10460
10461 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10462 `width' to `bar_area_x' and `bar_area_width', respectively.
10463 (x_scroll_run): Take account of fringe background extension.
10464
04f2d78b
CB
10465 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10466 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10467 `bar_area_width', respectively.
10468 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10469 background extension.
10470
79b70037
GM
104712011-05-10 Jim Meyering <meyering@redhat.com>
10472
10473 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10474
2f142cc5
JB
104752011-05-10 Juanma Barranquero <lekktu@gmail.com>
10476
10477 * image.c (Finit_image_library): Return t for built-in image types,
10478 like pbm and xbm. (Bug#8640)
10479
57679c86
AS
104802011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10481
10482 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10483
888c9e86
EZ
104842011-05-07 Eli Zaretskii <eliz@gnu.org>
10485
b0512a1d
EZ
10486 * w32console.c (Fset_screen_color): Doc fix.
10487 (Fget_screen_color): New function.
10488 (syms_of_ntterm): Defsubr it.
10489
7285dc67
EZ
10490 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10491 unlink the temporary file if Fcall_process didn't create it in the
10492 first place.
10493 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10494 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10495 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10496 cue to call_process_cleanup not to close that handle.
10497
4d3fcc8e
BK
104982011-05-07 Ben Key <bkey76@gmail.com>
10499
10500 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10501 one of two shell specific rules, either bootstrap-temacs-CMD or
10502 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10503 to the previous implementation of the bootstrap-temacs rule.
10504 The bootstrap-temacs-CMD rule is similar to the previous
10505 implementation of the bootstrap-temacs rule except that it
10506 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10507 variable.
10508
10509 These changes, along with some changes to nt/configure.bat,
10510 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10511 earlier fix to add support for --cflags and --ldflags options
10512 that include quotes so that it works whether make uses cmd or
10513 sh as the shell.
10514
b4289b64
MA
105152011-05-06 Michael Albinus <michael.albinus@gmx.de>
10516
10517 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10518 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10519 is a constant.
10520 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10521 a string. Handle both cases.
10522 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10523 (Fdbus_register_method): Use Qinvalid_function.
10524
af4c0e28
JB
105252011-05-06 Juanma Barranquero <lekktu@gmail.com>
10526
10527 * makefile.w32-in: Update dependencies.
10528 (LISP_H): Add inttypes.h and stdin.h.
10529 (PROCESS_H): Add unistd.h.
10530
c51453d9
EZ
105312011-05-06 Eli Zaretskii <eliz@gnu.org>
10532
10533 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10534 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10535
8ff0ac3c 105362011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10537
4c4b566b
PE
10538 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10539
aab2b9b5
PE
10540 * term.c (vfatal): Remove stray call to va_end.
10541 It's not needed and the C Standard doesn't allow it here anyway.
10542
c378da0b
PE
10543 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10544 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10545
288b08c7
PE
10546 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10547 bytes.
10548
e3601888
PE
10549 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10550
db6c0e74
PE
10551 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10552
dd5963ea
PE
10553 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10554
88c9450f
PE
10555 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10556
2f9442b8
PE
10557 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10558
c032b5f8
PE
10559 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10560 * charset.c (Fdefine_charset_internal): Don't initialize
10561 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10562 32-bit int (Bug#8600).
a108c10b
PE
10563
10564 * lread.c (read_integer): Be more consistent with string-to-number.
10565 Use string_to_number to do the actual conversion; this avoids
10566 rounding errors and fixes some other screwups. Without this fix,
10567 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10568 (digit_to_number): Move earlier, for benefit of read_integer.
10569 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10570 not a digit in any supported base. (Bug#8602)
a108c10b 10571
ad5f9eea
PE
10572 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10573
aec1708a
PE
10574 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10575 to match comment at start of function. This also removes a
10576 GCC warning about overflow in a 32+64-bit port.
10577
47be4ab5
PE
10578 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10579
371cac43
PE
10580 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10581 Reported by Stefan Monnier in
10582 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10583 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10584 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10585
d01a7826
PE
10586 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10587 (EMACS_UINTPTR): Likewise, with uintptr_t.
10588
7fd47d5c
PE
10589 * lisp.h: Prefer 64-bit EMACS_INT if available.
10590 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10591 on 32-bit hosts that have 64-bit int, so that they can access
10592 large files.
122b0c86
PE
10593 However, temporarily disable this change unless the temporary
10594 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10595
8727937b
PE
10596 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10597
8ac068ac
PE
10598 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10599 This removes an assumption that EMACS_INT and long are the same
10600 width as pointers. The assumption is true for Emacs porting targets
10601 now, but we want to make other targets possible.
10602 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10603 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10604 In the rest of the code, change types of integers that hold casted
10605 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10606 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10607 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10608 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10609 No need to cast type when ORing.
10610 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10611 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10612 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10613 assume EMACS_INT is the same width as char *.
10614 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10615 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10616 Remove no-longer-needed casts.
10617 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10618 (xg_tool_bar_help_callback, xg_make_tool_item):
10619 Use EMACS_INTPTR to hold an integer
10620 that will be cast to void *; this can avoid a GCC warning
10621 if EMACS_INT is not the same width as void *.
10622 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10623 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10624 (current_message_1, set_message_1):
10625 Use a local to convert to proper width without a cast.
10626 * xmenu.c (dialog_selection_callback): Likewise.
10627
ede49d71
PE
10628 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10629 Also, don't assume VALBITS / RAND_BITS is less than 5,
10630 and don't rely on undefined behavior when shifting a 1 left into
10631 the sign bit.
10632 * lisp.h (get_random): Change signature to match.
10633
2f30ecd0
PE
10634 * lread.c (hash_string): Use size_t, not int, for hash computation.
10635 Normally we prefer signed values; but hashing is special, because
10636 it's better to use unsigned division on hash table sizes so that
10637 the remainder is nonnegative. Also, size_t is the natural width
10638 for hashing into memory. The previous code used 'int', which doesn't
10639 retain enough info to hash well into very large tables.
10640 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10641
2a866e7b
PE
10642 * dbusbind.c: Don't possibly lose pointer info when converting.
10643 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10644 Use XPNTR rather than XHASH, so that the high-order bits of
10645 the pointer aren't lost when converting through void *.
10646
51639eac
PE
10647 * eval.c (Fautoload): Don't double-shift a pointer.
10648
92394119
PE
10649 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10650
dbdb9a7c
JB
106512011-05-06 Juanma Barranquero <lekktu@gmail.com>
10652
10653 * gnutls.c (DEF_GNUTLS_FN):
10654 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10655
db7a0b4f
AS
106562011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10657
10658 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10659 marker. (Bug#8610)
10660
cd394be1 106612011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10662
10663 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10664 New version that can reserve upto 2GB of heap space.
10665
f7ff1b0f 106662011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10667
10668 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10669
639c109b
TZ
106702011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10671
10672 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10673 `gnutls_certificate_set_x509_key_file'.
10674
d2127135
JB
106752011-05-05 Juanma Barranquero <lekktu@gmail.com>
10676
10677 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10678 Update dependencies.
10679
e968f4f3
JB
106802011-05-04 Juanma Barranquero <lekktu@gmail.com>
10681
10682 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10683 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10684 Remove unused parameter `fildes'.
10685 * process.c (read_process_output, send_process): Don't pass it.
10686
84d358f0
JB
106872011-05-04 Juanma Barranquero <lekktu@gmail.com>
10688
10689 Fix previous change: the library cache is defined in w32.c.
10690 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10691 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10692
0898ca10
JB
106932011-05-04 Juanma Barranquero <lekktu@gmail.com>
10694
10695 Implement dynamic loading of GnuTLS on Windows.
10696
10697 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10698 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10699 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10700 Declare.
10701
10702 * gnutls.c (Qgnutls_dll): Define.
10703 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10704 (gnutls_*): Declare function pointers.
10705 (init_gnutls_functions): New function to initialize function pointers.
10706 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10707 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10708 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10709 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10710 (emacs_gnutls_write, emacs_gnutls_read)
10711 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10712 (Fgnutls_available_p): New function.
10713 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10714 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10715 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10716
10717 * image.c: Include w32.h.
10718 (Vimage_type_cache): Delete.
10719 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10720 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10721 (w32_delayed_load): Move to w32.c.
10722
10723 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10724
10725 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10726 (w32_delayed_load): Move from image.c. When loading a library, record
10727 its filename in the :loaded-from property of the library id.
10728 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10729 Initialize and staticpro them.
10730 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10731
10732 * process.c: Include lisp.h before w32.h, not after.
10733 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10734 instead of gnutls_record_check_pending.
10735
10736 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10737
ff4de4aa
TZ
107382011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10739
10740 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10741 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10742 as passed in.
10743
abe95abb
JD
107442011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10745
10746 * xterm.c (x_set_frame_alpha): Do not set property on anything
10747 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10748
e16e55d4
JB
107492011-05-02 Juanma Barranquero <lekktu@gmail.com>
10750
10751 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10752
bafcf6a5
JB
107532011-05-02 Juanma Barranquero <lekktu@gmail.com>
10754
10755 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10756 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10757 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10758 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10759 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10760 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10761 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10762 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10763 (Qgnutls_bootprop_callbacks_verify): Make static.
10764
e7a6747f
AS
107652011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10766
19ed11ba
AS
10767 * callproc.c: Indentation fixup.
10768
e7a6747f 10769 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10770 (wait_for_termination, interruptible_wait_for_termination):
10771 Move after wait_for_termination_1.
e7a6747f 10772
1ef14cb4
LMI
107732011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10774
10775 * sysdep.c (interruptible_wait_for_termination): New function
10776 which is like wait_for_termination, but allows keyboard
10777 interruptions.
10778
10779 * callproc.c (Fcall_process): Add (:file "file") as an option for
10780 the STDOUT buffer.
10781 (Fcall_process_region): Ditto.
10782
330d880c
EZ
107832011-04-30 Eli Zaretskii <eliz@gnu.org>
10784
8db90b73
EZ
10785 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10786 rather than `XVECTOR (FOO)->size'.
10787
330d880c
EZ
10788 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10789 inttypes.h, as a gnulib replacement is used if it not available in
10790 system headers.
10791
15cbd324
EZ
107922011-04-21 Eli Zaretskii <eliz@gnu.org>
10793
10794 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10795 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10796 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10797
10798 * coding.c (coding_alloc_by_realloc): Error out if destination
10799 will grow beyond MOST_POSITIVE_FIXNUM.
10800 (decode_coding_emacs_mule): Abort if there isn't enough place in
10801 charbuf for the composition carryover bytes. Reserve an extra
10802 space for up to 2 characters produced in a loop.
10803 (decode_coding_iso_2022): Abort if there isn't enough place in
10804 charbuf for the composition carryover bytes.
10805
108062011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10807
ae940cca
EZ
10808 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10809 aborting when %lld or %lll format is passed.
10810 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10811 %llo or %llx format is passed. (Bug#8545)
10812
03ab8921
EZ
10813 * window.c (window_scroll_line_based): Use a marker instead of
10814 simple variables to record original value of point. (Bug#7952)
10815
afda1437
EZ
10816 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10817 produced by %s or %c overflows available buffer space. (Bug#8545)
10818
f76dee0c
PE
108192011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10820
10821 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10822 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10823
fdc5744d
JB
108242011-04-28 Juanma Barranquero <lekktu@gmail.com>
10825
10826 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10827
638f053a
JB
108282011-04-28 Juanma Barranquero <lekktu@gmail.com>
10829
10830 * keyboard.c (Qdelayed_warnings_hook): Define.
10831 (command_loop_1): Run `delayed-warnings-hook'
10832 if Vdelayed_warnings_list is non-nil.
10833 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10834 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10835
d178f871
EZ
108362011-04-28 Eli Zaretskii <eliz@gnu.org>
10837
10838 * doprnt.c (doprnt): Don't return value smaller than the buffer
10839 size if the message was truncated. (Bug#8545).
10840
b124fd93
JB
108412011-04-28 Juanma Barranquero <lekktu@gmail.com>
10842
10843 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10844 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10845
e810457d
PE
108462011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10847
10848 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10849
ea51cceb
JB
108502011-04-27 Juanma Barranquero <lekktu@gmail.com>
10851
10852 * makefile.w32-in: Update dependencies.
10853
94dcfacf
EZ
108542011-04-27 Eli Zaretskii <eliz@gnu.org>
10855
10856 Improve `doprnt' and its usage. (Bug#8545)
10857 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10858 `format_end'. Remove support for %l as a conversion specifier.
10859 Don't use xrealloc. Improve diagnostics when the %l size modifier
10860 is used. Update the commentary.
10861
10862 * eval.c (verror): Simplify calculation of size_t.
10863
10864 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10865 messages.
10866
f61f41d7
PE
108672011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10868
10869 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10870 change.
10871
96fb4434
PE
108722011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10873
10874 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10875 This makes this file independent of the recent pseudovector change.
10876
671875da 108772011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10878
69e9b5a3
PE
10879 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10880
b5f869a7 10881 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10882 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10883 Remove unused local.
c8926152 10884 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10885
841a1577 10886 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10887 GCC 4.6.0 optimizes based on type-based alias analysis.
10888 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10889 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10890 != &v->size, and therefore "v->size = 1; b->size = 2; return
10891 v->size;" must therefore return 1. This assumption is incorrect
10892 for Emacs, since it type-puns struct Lisp_Vector * with many other
10893 types. To fix this problem, this patch adds a new type struct
f904488f 10894 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10895 and pseudovectors, and helps optimizing compilers not get fooled
10896 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10897 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10898 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10899 the size member.
eab3844f
PE
10900 (XSETPVECTYPE): Rewrite in terms of new macro.
10901 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10902 This is a bit clearer, and further avoids the possibility of
10903 undesirable aliasing.
10904 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10905 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10906 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10907 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10908 (ASIZE): Now uses header.size rather than size.
10909 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10910 to avoid the hassle of writing XVECTOR (foo)->header.size.
10911 (struct vectorlike_header): New type.
eab3844f
PE
10912 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10913 object, to help avoid aliasing.
10914 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10915 (SUBRP): Likewise, since Lisp_Subr is a special case.
10916 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10917 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10918 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10919 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10920 changed to be "header.size" and "header.next".
10921 * buffer.h (struct buffer): Likewise.
10922 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10923 * frame.h (struct frame): Likewise.
10924 * process.h (struct Lisp_Process): Likewise.
10925 * termhooks.h (struct terminal): Likewise.
10926 * window.c (struct save_window_data, struct saved_window): Likewise.
10927 * window.h (struct window): Likewise.
10928 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10929 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10930 * buffer.c (init_buffer_once): Likewise.
10931 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10932 special case.
10933 * process.c (Fformat_network_address): Use local var for size,
10934 for brevity.
10935
0df1eac5
PE
10936 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10937
847ab9d1 10938 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10939 * data.c (atof): Remove decl; no longer used or needed.
10940 (digit_to_number): Move to lread.c.
10941 (Fstring_to_number): Use new string_to_number function, to be
10942 consistent with how the Lisp reader treats infinities and NaNs.
10943 Do not assume that floating-point numbers represent EMACS_INT
10944 without losing information; this is not true on most 64-bit hosts.
10945 Avoid double-rounding errors, by insisting on integers when
10946 parsing non-base-10 numbers, as the documentation specifies.
10947 * lisp.h (string_to_number): New decl, replacing ...
10948 (isfloat_string): Remove.
bc0a5c13 10949 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10950 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10951 appears to have been a coding error. Similarly, do not accept
10952 strings like +-1e0 as floating point numbers. Do not report
10953 overflow for integer overflows unless the base is not 10 which
10954 means we have no simple and reliable way to continue.
10955 Break out the floating-point parsing into a new
10956 function string_to_number, so that Fstring_to_number parses
10957 floating point numbers consistently with the Lisp reader.
04f2d78b 10958 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10959 (E_CHAR, EXP_INT): Remove, replacing with ...
10960 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10961 (string_to_number): New function, replacing isfloat_string.
10962 This function checks for valid syntax and produces the resulting
10963 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10964 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10965 so that overflow for non-base-10 numbers is reported only when
10966 there's no portable and simple way to convert to floating point.
452f4150 10967
67769ffc
PE
10968 * textprop.c (set_text_properties_1): Rewrite for clarity,
10969 and to avoid GCC warning about integer overflow.
10970
c20db43f
PE
10971 * intervals.h (struct interval): Use EMACS_INT for members
10972 where EMACS_UINT might cause problems. See
10973 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10974 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10975 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10976 All uses changed.
37aa2f85
PE
10977 (offset_intervals): Tell GCC not to worry about length overflow
10978 when negating a negative length.
c20db43f 10979
2538aa2f
PE
10980 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10981 (overrun_check_free): Likewise.
10982
f2d3008d
PE
10983 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10984 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10985 word size.
10986
ec8df744
PE
10987 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10988 (gnutls_make_error): Rename local to avoid shadowing.
10989 (gnutls_emacs_global_deinit): ifdef out; not used.
10990 (Fgnutls_boot): Use const for pointer to readonly storage.
10991 Comment out unused local. Fix pointer signedness problems.
10992
640ee02d
PE
10993 * lread.c (openp): Don't stuff size_t into an 'int'.
10994 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10995 about possible signed overflow.
10996
6048fb2a
PE
10997 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10998 (GDK_KEY_g): Don't define if already defined.
10999 (xg_prepare_tooltip): Avoid pointer signedness problem.
11000 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11001
fa3c87e1
PE
11002 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11003 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11004
2172544b
PE
11005 * xfns.c (Fx_window_property): Simplify a bit,
11006 to make a bit faster and to avoid GCC 4.6.0 warning.
11007 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11008
9b821a21
PE
11009 * fns.c (internal_equal): Don't assume size_t fits in int.
11010
3c616cfa
PE
11011 * alloc.c (compact_small_strings): Tighten assertion a little.
11012
c2982e87
PE
11013 Replace pEd with more-general pI, and fix some printf arg casts.
11014 * lisp.h (pI): New macro, generalizing old pEd macro to other
11015 conversion specifiers. For example, use "...%"pI"d..." rather
11016 than "...%"pEd"...".
11017 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11018 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11019 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11020 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11021 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11022 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11023 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11024 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11025 64-bit hosts.
11026 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11027 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11028 * print.c (safe_debug_print, print_object): Likewise.
11029 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11030 to int.
6f04d126
PE
11031 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11032 avoiding the 0 flag, which is not portable.
c2982e87
PE
11033 * process.c (Fmake_network_process): Use pI to avoid cast.
11034 * region-cache.c (pp_cache): Likewise.
11035 * xdisp.c (decode_mode_spec): Likewise.
11036 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11037 behavior on 64-bit hosts with printf arg.
6f04d126 11038 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11039 (x_stop_queuing_selection_requests): Likewise.
11040 (x_get_window_property): Don't truncate byte count to an 'int'
11041 when tracing.
0b432f21 11042
5e073ec7
PE
11043 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11044 here, since it parses constructs like leading '-' and spaces,
11045 which are not wanted; and it overflows with large numbers.
11046 Instead, simply match F[0-9]+, which is what is wanted anyway.
11047
36372bf9
PE
11048 * alloc.c: Remove unportable assumptions about struct layout.
11049 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11050 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11051 (allocate_vectorlike, make_pure_vector): Use the new macros,
11052 plus offsetof, to remove unportable assumptions about struct layout.
11053 These assumptions hold on all porting targets that I know of, but
11054 they are not guaranteed, they're easy to remove, and removing them
11055 makes further changes easier.
11056
0b432f21
PE
11057 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11058 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11059 (string_overrun_cookie): Now const. Use initializers that
11060 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11061 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11062 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11063 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11064 multiple of sizeof (EMACS_INT); it need not be, if
11065 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11066 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11067
895009e1
JB
110682011-04-26 Juanma Barranquero <lekktu@gmail.com>
11069
11070 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11071
6a7a1b0b
TZ
110722011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11073
11074 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11075 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11076 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11077
841a1577 110782011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11079
11080 * lisp.h (Qdebug): List symbol.
895009e1 11081 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11082 * keyboard.c (debug-on-event): New variable.
11083 (handle_user_signal): Break into debugger when debug-on-event
11084 matches the current signal symbol.
11085
f2d3ba6f
DN
110862011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11087
11088 * alloc.c (check_sblock, check_string_bytes)
11089 (check_string_free_list): Convert to standard C.
11090
42ce4c63
TZ
110912011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11092
11093 * w32.c (emacs_gnutls_push): Fix typo.
11094
825cd63c
EZ
110952011-04-25 Eli Zaretskii <eliz@gnu.org>
11096
fb11d64d
EZ
11097 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11098 "cast to pointer from integer of different size".
11099
825cd63c
EZ
11100 Improve doprnt and its use in verror. (Bug#8545)
11101 * doprnt.c (doprnt): Document the set of format control sequences
11102 supported by the function. Use SAFE_ALLOCA instead of always
11103 using `alloca'.
11104
11105 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11106 is one byte too soon. Don't use xrealloc; instead xfree and
11107 xmalloc anew.
11108
e061a11b
TZ
111092011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11110
11111 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11112 callbacks stage.
11113
11114 * gnutls.c: Renamed global_initialized to
11115 gnutls_global_initialized. Added internals for the
11116 :verify-hostname-error, :verify-error, and :verify-flags
11117 parameters of `gnutls-boot' and documented those parameters in the
11118 docstring. Start callback support.
9173deec
JB
11119 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11120 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11121 on error. Return error code.
e061a11b
TZ
11122 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11123 (emacs_gnutls_read): Likewise.
11124 (Fgnutls_boot): Return handshake error code.
11125 (emacs_gnutls_handle_error): New function.
11126 (wsaerror_to_errno): Likewise.
11127
11128 * w32.h (emacs_gnutls_pull): Add prototype.
11129 (emacs_gnutls_push): Likewise.
11130
11131 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11132 (emacs_gnutls_push): Likewise.
11133
111342011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11135
11136 * process.c (wait_reading_process_output): Check if GnuTLS
11137 buffered some data internally if no FDs are set for TLS
11138 connections.
11139
11140 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11141 (LIBS): Link to USER_LIBS.
11142 ($(BLD)/gnutls.$(0)): New target.
11143
fa6996bc
EZ
111442011-04-24 Eli Zaretskii <eliz@gnu.org>
11145
eb35682e
EZ
11146 * xdisp.c (handle_single_display_spec): Rename the
11147 display_replaced_before_p argument into display_replaced_p, to
11148 make it consistent with the commentary. Fix typos in the
11149 commentary.
11150
e2ad650c
EZ
11151 * textprop.c (syms_of_textprop): Remove dead code.
11152 (copy_text_properties): Delete obsolete commentary about an
11153 interface that was deleted long ago. Fix typos in the description
11154 of arguments.
11155
1b2de274
EZ
11156 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11157 to changes in oldXMenu/XMenu.h from 2011-04-16.
11158 <menu_help_message, prev_menu_help_message>: Constify.
11159 (IT_menu_make_room): menu->help_text is now `const char **';
11160 adjust.
11161
11162 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11163 to changes in oldXMenu/XMenu.h from 2011-04-16.
11164 (struct XMenu): Declare `help_text' `const char **'.
11165
11166 * xfaces.c <Qunspecified>: Make extern again.
11167
11168 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11169 required by POSIX.
1b2de274 11170
762b15be
EZ
11171 * doc.c (get_doc_string): Improve the format passed to `error'.
11172
11173 * doprnt.c (doprnt): Improve commentary.
11174
11175 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11176
11177 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11178 them with etags.
11179
f1052e5d
EZ
11180 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11181 changes in globals.h immediately force recompilation.
762b15be
EZ
11182 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11183 $(CURDIR)/s/ms-w32.h.
11184 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11185
fa6996bc
EZ
11186 * character.c (Fchar_direction): Function deleted.
11187 (syms_of_character): Don't defsubr it.
11188 <char-direction-table>: Deleted.
11189
e6c3da20
EZ
111902011-04-23 Eli Zaretskii <eliz@gnu.org>
11191
11192 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11193 * doprnt.c: Include limits.h.
11194 (SIZE_MAX): New macro.
04f2d78b
CB
11195 (doprnt): Return a size_t value. 2nd arg is now size_t.
11196 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11197 Improve overflow protection. Support `l' modifier for integer
11198 conversions. Support %l conversion. Don't assume an EMACS_INT
11199 argument for integer conversions and for %c.
11200
11201 * lisp.h (doprnt): Restore prototype.
11202
11203 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11204 $(SRC)/character.h.
11205
11206 * Makefile.in (base_obj): Add back doprnt.o.
11207
11208 * deps.mk (doprnt.o): Add back prerequisites.
11209 (callint.o): Depend on character.h.
11210
11211 * eval.c (internal_lisp_condition_case): Include the handler
11212 representation in the error message.
11213 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11214 when breaking from the loop.
11215
11216 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11217
11218 * callint.c (Fcall_interactively): When displaying error message
11219 about invalid control letter, pass the character's codepoint, not
11220 a pointer to its multibyte form. Improve display of the character
11221 in octal and display also its hex code.
11222
11223 * character.c (char_string): Use %x to display the (unsigned)
11224 codepoint of an invalid character, to avoid displaying a bogus
11225 negative value.
11226
11227 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11228 `error', not SYMBOL_NAME itself.
11229
11230 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11231 character arguments to `error'.
11232
11233 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11234 to `error' in error message about FINAL_CHAR argument. Make sure
11235 FINAL_CHAR is a character, and use %c when it is passed as
11236 argument to `error'.
11237
4ffd0d6b 112382011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11239
11240 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11241
11242 * w32.c: Include <time.h>.
11243 (sys_localtime): New function.
11244
4ffd0d6b 112452011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11246
11247 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11248
4ffd0d6b 11249 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11250
4ffd0d6b 112512011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11252
4ffd0d6b
GM
11253 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11254 zombies (Bug#8467).
aac0c6e3 11255
04c56954
EZ
112562011-04-19 Eli Zaretskii <eliz@gnu.org>
11257
11258 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11259 gl_state.e_property when gl_state.object is Qt.
11260
11261 * insdel.c (make_gap_larger): Remove limitation of buffer size
11262 to <= INT_MAX.
11263
16a43933
CY
112642011-04-18 Chong Yidong <cyd@stupidchicken.com>
11265
11266 * xdisp.c (lookup_glyphless_char_display)
11267 (produce_glyphless_glyph): Handle cons cell entry in
11268 glyphless-char-display.
11269 (Vglyphless_char_display): Document it.
11270
11271 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11272 glyphless-char-display.
11273
4581706e
CY
112742011-04-17 Chong Yidong <cyd@stupidchicken.com>
11275
11276 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11277
11278 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11279
11280 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11281 definition for no-X builds.
11282
4887c6e2 112832011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11284
fd35b6f9
PE
11285 Static checks with GCC 4.6.0 and non-default toolkits.
11286
5c1ccb01
PE
11287 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11288
006c5daa
PE
11289 * process.c (keyboard_bit_set): Define only if SIGIO.
11290 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11291 (send_process): Repair possible setjmp clobbering.
11292
efc736d3
PE
11293 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11294
4e2fe2e6
PE
11295 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11296
f97334a2
PE
11297 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11298
4e75f29d
PE
11299 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11300 Define only if needed.
11301
90efadd1
PE
11302 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11303 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11304 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11305
3c647824
PE
11306 * dispextern.h (struct redisplay_interface): Rename param
11307 to avoid shadowing.
e264f262 11308 * termhooks.h (struct terminal): Likewise.
761383f4 11309 * xterm.c (xembed_send_message): Likewise.
3c647824 11310
b58c5c4a
PE
11311 * insdel.c (make_gap_smaller): Define only if
11312 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11313
cad59032
PE
11314 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11315 it.
11316
c339dc2e
PE
11317 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11318 so that we aren't warned about unused symbols.
11319
91a3e27b
PE
11320 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11321
399c71d3 11322 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11323
8ffc96f5
PE
11324 * xfns.c (x_real_positions): Mark locals as initialized.
11325
eef9bc79
PE
11326 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11327
098db9dd
PE
11328 * xterm.c: Fix problems found by static analysis with other toolkits.
11329 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11330 (x_dispatch_event): Declare static if USE_GTK, and
11331 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11332 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11333 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11334 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11335 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11336
eb18f6cc
PE
11337 * xmenu.c (menu_help_callback): Pointer type fixes.
11338 Use const pointers when pointing at readonly data. Avoid pointer
11339 signedness clashes.
11340 (FALSE): Remove unused macro.
11341 (update_frame_menubar): Remove unused decl.
11342
1fe72bf8
PE
11343 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11344
60d9e1db
PE
11345 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11346 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11347 (single_menu_item): Rename local to avoid shadowing.
11348
39261c26
PE
11349 * keyboard.c (make_lispy_event): Remove unused local var.
11350
018c5e19
PE
11351 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11352 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11353
63d2b86e
PE
11354 * bitmaps: Change bitmaps from unsigned char back to the X11
11355 compatible char. Avoid the old compiler warnings about
11356 out-of-range initializers by using, for example, '\xab' rather
11357 than 0xab.
11358
aefd87e1
PE
11359 * xgselect.c (xgselect_initialize): Check vs interface
11360 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11361
bf501fb9
PE
11362 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11363
e9829fdf
PE
11364 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11365 to read-only memory.
11366
1086c095
PE
11367 * fns.c (vector): Remove; this old hack is no longer needed.
11368
2baccd04 11369 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11370 Remove unused var.
dde42981 11371 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11372
72391843 11373 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11374
436c16df 11375 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11376 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11377 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11378
92bb796d 11379 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11380 (x_term_init): Remove local to avoid shadowing.
92bb796d 11381
764430a3 11382 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11383
11384 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11385 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11386
d1dfb56c
EZ
113872011-04-16 Eli Zaretskii <eliz@gnu.org>
11388
c4354cb4
EZ
11389 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11390
d1dfb56c
EZ
11391 Fix regex.c, syntax.c and friends for buffers > 2GB.
11392 * syntax.h (struct gl_state_s): Declare character position members
11393 EMACS_INT.
11394
11395 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11396
04f2d78b
CB
11397 * textprop.c (verify_interval_modification, interval_of):
11398 Declare arguments EMACS_INT.
d1dfb56c
EZ
11399
11400 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11401 EMACS_INT.
11402
11403 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11404
11405 * indent.c (Fvertical_motion): Local variable it_start is now
11406 EMACS_INT.
11407
11408 * regex.c (re_match, re_match_2, re_match_2_internal)
11409 (bcmp_translate, regcomp, regexec, print_double_string)
11410 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11411 (re_compile_pattern, re_exec): Declare arguments and local
11412 variables `size_t' and `ssize_t' and return values `regoff_t', as
11413 appropriate.
11414 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11415 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11416 <compile_stack_type>: `size' and `avail' are now `size_t'.
11417
11418 * regex.h <regoff_t>: Use ssize_t, not int.
11419 (re_search, re_search_2, re_match, re_match_2): Arguments that
11420 specify buffer/string position and length are now ssize_t and
11421 size_t. Return type is regoff_t.
11422
613052cd
BK
114232011-04-16 Ben Key <bkey76@gmail.com>
11424
11425 * nsfont.m: Fixed bugs in ns_get_family and
11426 ns_descriptor_to_entity that were caused by using free to
11427 deallocate memory blocks that were allocated by xmalloc (via
11428 xstrdup). This caused Emacs to crash when compiled with
11429 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11430 --enable-checking=xmallocoverrun). xfree is now used to
11431 deallocate these memory blocks.
11432
4170f62f 114332011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11434
71b41406
PE
11435 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11436
9587a89d
PE
11437 emacs_write: Accept and return EMACS_INT for sizes.
11438 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11439 et seq.
11440 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11441 Accept and return EMACS_INT.
11442 (emacs_gnutls_write): Return the number of bytes written on
11443 partial writes.
11444 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11445 (emacs_read, emacs_write): Remove check for negative size, as the
11446 Emacs source code has been audited now.
9587a89d
PE
11447 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11448 (emacs_read, emacs_write): Use it.
273a5f82
PE
11449 * process.c (send_process): Adjust to the new signatures of
11450 emacs_write and emacs_gnutls_write. Do not attempt to store
11451 a byte offset into an 'int'; it might overflow.
9587a89d 11452 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11453
3e047f51
PE
11454 * sound.c: Don't assume sizes fit in 'int'.
11455 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11456 Return EMACS_INT, not int.
3e047f51 11457 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11458 Accept EMACS_INT, not int.
11459 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11460 record read return values.
11461
cc39a9db
BK
114622011-04-15 Ben Key <bkey76@gmail.com>
11463
c9d0ec6d
JB
11464 * keyboard.c (Qundefined): Don't declare static since it is used
11465 in nsfns.m.
11466 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11467 static since they are used in nsfont.m.
cc39a9db 11468
6c60eb9f
SM
114692011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11470
11471 * process.c (Qprocessp): Don't declare static.
11472 * lisp.h (Qprocessp): Declare again.
11473
7990b61a
JB
114742011-04-15 Juanma Barranquero <lekktu@gmail.com>
11475
11476 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11477
5d4cb038
PE
114782011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11479
8bd7b830 11480 Improve C-level modularity by making more things 'static'.
cd64ea1d 11481
e3b27b31
PE
11482 Don't publish debugger-only interfaces to other modules.
11483 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11484 (verify_bytepos, count_markers): Move decls to the only modules
11485 that need them.
11486 * region-cache.h (pp_cache): Likewise.
11487 * window.h (check_all_windows): Likewise.
11488 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11489
5d4cb038
PE
11490 * sysdep.c (croak): Now static, if
11491 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11492 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11493
11494 * alloc.c (refill_memory_reserve): Now static if
11495 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11496 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11497
e87b6180
PE
11498 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11499 Define only if USE_LUCID.
11500
ac64929e
PE
11501 * xrdb.c (x_customization_string, x_rm_string): Now static.
11502
6f37259d
PE
11503 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11504 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11505
1683e3ab
PE
11506 * xdisp.c (draw_row_with_mouse_face): Now static.
11507 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11508
de9c2632
PE
11509 * window.h (check_all_windows): Mark externally visible.
11510
2b96acb7
PE
11511 * window.c (window_deletion_count): Now static.
11512
11513 * undo.c: Make symbols static if they're not exported.
11514 (last_undo_buffer, last_boundary_position, pending_boundary):
11515 Now static.
11516
50436f33
PE
11517 * textprop.c (interval_insert_behind_hooks): Now static.
11518 (interval_insert_in_front_hooks): Likewise.
11519
64520e5c
PE
11520 * term.c: Make symbols static if they're not exported.
11521 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11522 (max_frame_lines, tty_set_terminal_modes):
11523 (tty_reset_terminal_modes, tty_turn_off_highlight):
11524 (get_tty_terminal): Now static.
11525 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11526 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11527 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11528 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11529 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11530
1fa53021
PE
11531 * sysdep.c: Make symbols static if they're not exported.
11532 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11533 Now static.
11534 (sigprocmask_set, full_mask): Remove; unused.
11535 (wait_debugging): Mark as visible.
11536 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11537 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11538
d4b43b22
PE
11539 * syntax.c (syntax_temp): Define only if !__GNUC__.
11540
b7c513d0
PE
11541 * sound.c (current_sound_device, current_sound): Now static.
11542
989b29ad
PE
11543 * search.c (searchbufs, searchbuf_head): Now static.
11544
13a55a78
PE
11545 * scroll.c (scroll_cost): Remove; unused.
11546 * dispextern.h (scroll_cost): Remove decl.
11547
de68a1fc
PE
11548 * region-cache.h (pp_cache): Mark as externally visible.
11549
40ccffa6
PE
11550 * process.c: Make symbols static if they're not exported.
11551 (process_tick, update_tick, create_process, chan_process):
11552 (Vprocess_alist, proc_buffered_char, datagram_access):
11553 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11554 (deactivate_process): Mark defn as static, as well as decl.
11555 * lisp.h (create_process): Remove decl.
11556 * process.h (chan_process, Vprocess_alist): Remove decls.
11557
ad64fc97
PE
11558 * print.c: Make symbols static if they're not exported.
11559 (print_depth, new_backquote_output, being_printed, print_buffer):
11560 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11561 (print_interval, print_number_index, initial_stderr_stream):
11562 Now static.
11563 * lisp.h (Fprinc): Remove decl.
11564 (debug_output_compilation_hack): Mark as externally visible.
11565
adddb265
PE
11566 * sysdep.c (croak): Move decl from here to syssignal.h.
11567 * syssignal.h (croak): Put it here, so the API can be checked when
11568 'croak' is called from dissociate_if_controlling_tty.
11569
1717ede2
PE
11570 * minibuf.c: Make symbols static if they're not exported.
11571 (minibuf_save_list, choose_minibuf_frame): Now static.
11572 * lisp.h (choose_minibuf_frame): Remove decl.
11573
fa5fb2bc
PE
11574 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11575
1e3890d1
PE
11576 * lread.c: Make symbols static if they're not exported.
11577 (read_objects, initial_obarray, oblookup_last_bucket_number):
11578 Now static.
11579 (make_symbol): Remove; unused.
11580 * lisp.h (initial_obarray, make_symbol): Remove decls.
11581
8a1414fa
PE
11582 * keyboard.c: Make symbols static if they're not exported.
11583 (single_kboard, recent_keys_index, total_keys, recent_keys):
11584 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11585 (this_single_command_key_start, echoing, last_auto_save):
11586 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11587 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11588 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11589 (Vlispy_mouse_stem, double_click_count):
11590 Now static.
11591 (force_auto_save_soon): Define only if SIGDANGER.
11592 (ignore_mouse_drag_p): Now static if
11593 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11594 (print_help): Remove; unused.
11595 (stop_character, last_timer_event): Mark as externally visible.
11596 * keyboard.h (ignore_mouse_drag_p): Declare only if
11597 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11598 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11599 * lisp.h (echoing): Remove decl.
11600 (force_auto_save_soon): Declare only if SIGDANGER.
11601 * xdisp.c (redisplay_window): Simplify code, to make it more
11602 obvious that ignore_mouse_drag_p is not accessed if !defined
11603 USE_GTK && !defined HAVE_NS.
11604
93ea6e8f
PE
11605 * intervals.c: Make symbols static if they're not exported.
11606 (merge_properties_sticky, merge_interval_right, delete_interval):
11607 Now static.
11608 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11609
77382fcc
PE
11610 * insdel.c: Make symbols static if they're not exported.
11611 However, leave prepare_to_modify_buffer alone. It's never
11612 called from outside this function, but that appears to be a bug.
11613 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11614 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11615 (adjust_after_replace_noundo): Remove; unused.
11616 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11617 (signal_before_change): Remove decls.
77382fcc 11618
9306c32e
PE
11619 * indent.c (val_compute_motion, val_vmotion): Now static.
11620
cd44d2eb
PE
11621 * image.c: Make symbols static if they're not exported.
11622 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11623 if USE_GTK.
11624 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11625 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11626
ad9a7a06
PE
11627 * fringe.c (standard_bitmaps): Now static.
11628 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11629
81626931
PE
11630 * frame.c: Make symbols static if they're not exported.
11631 (x_report_frame_params, make_terminal_frame): Now static.
11632 (get_frame_param): Now static, unless HAVE_NS.
11633 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11634 (x_get_resource_string): Remove; not used.
11635 * frame.h (make_terminal_frame, x_report_frame_params):
11636 (x_get_resource_string); Remove decls.
11637 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11638 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11639
239f9db9
PE
11640 * font.c, fontset.c: Make symbols static if they're not exported.
11641 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11642 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11643 * font.c (font_close_object): Now static.
11644 * font.h (font_close_object): Remove.
11645 * fontset.c (FONTSET_OBJLIST): Remove.
11646 (free_realized_fontset) #if-0 the body, which does nothing.
11647 (face_suitable_for_char_p): #if-0, as it's never called.
11648 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11649 * xfaces.c (face_at_string_position):
11650 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11651 since 0 is always ASCII.
11652
dfcf3579
PE
11653 * fns.c (weak_hash_tables): Now static.
11654
5045092b
PE
11655 * fileio.c: Make symbols static if they're not exported.
11656 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11657 (Vwrite_region_annotation_buffers): Now static.
11658
57a96f5c
PE
11659 * eval.c: Make symbols static if they're not exported.
11660 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11661 * lisp.h (backtrace_list): Remove decl.
11662
35f08c38
PE
11663 * emacs.c: Make symbols static if they're not exported.
11664 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11665 (fatal_error_code, fatal_error_signal_hook, standard_args):
11666 Now static.
11667 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11668 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11669 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11670 * lisp.h (fatal_error_signal_hook): Remove decl.
11671 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11672
f44bd759
PE
11673 * editfns.c: Move a (normally-unused) function to its only use.
11674 * editfns.c, lisp.h (get_operating_system_release): Remove.
11675 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11676 worth the hassle of breaking this out.
11677
b532497d
PE
11678 * xterm.c: Make symbols static if they're not exported.
11679 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11680 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11681 (x_destroy_window, x_delete_display):
11682 Now static.
11683 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11684 (x_mouse_leave): Remove; unused.
11685 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11686 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11687 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11688 Remove decls.
11689 (x_mouse_leave): Declare only if WINDOWSNT.
11690 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11691 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11692 USE_X_TOOLKIT.
11693
1675728f
PE
11694 * ftxfont.c: Make symbols static if they're not exported.
11695 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11696 HAVE_FREETYPE.
11697 * font.h (ftxfont_driver): Likewise.
11698
e4cebfca
PE
11699 * xfns.c: Make symbols static if they're not exported.
11700 (x_last_font_name, x_display_info_for_name):
11701 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11702 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11703 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11704 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11705 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11706 (last_show_tip_args): Now static.
11707 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11708 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11709 (x_screen_planes): Remove; unused.
11710 * dispextern.h (x_screen_planes): Remove decl.
11711
5bf46f05
PE
11712 * dispnew.c: Make symbols static if they're not exported.
11713 * dispextern.h (redraw_garbaged_frames, scrolling):
11714 (increment_row_positions): Remove.
11715 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11716 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11717 Now static.
11718 (redraw_garbaged_frames): Remove; unused.
11719
435f4c28
PE
11720 * xfaces.c: Make symbols static if they're not exported.
11721 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11722 Remove decls.
11723 * xterm.h (defined_color): Remove decls.
11724 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11725 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11726 (menu_face_changed_default, defined_color, free_realized_face):
11727 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11728 (ascii_face_of_lisp_face): Remove; unused.
11729
8524aef3
PE
11730 * xdisp.c: Make symbols static if they're not exported.
11731 * dispextern.h (scratch_glyph_row, window_box_edges):
11732 (glyph_to_pixel_coords, set_cursor_from_row):
11733 (get_next_display_element, set_iterator_to_next):
11734 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11735 (show_mouse_face): Remove decls
11736 * frame.h (message_buf_print): Likewise.
11737 * lisp.h (pop_message, set_message, check_point_in_composition):
11738 Likewise.
11739 * xterm.h (set_vertical_scroll_bar): Likewise.
11740 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11741 (message_buf_print, scratch_glyph_row, displayed_buffer):
11742 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11743 (get_next_display_element, show_mouse_face, window_box_edges):
11744 (frame_to_window_pixel_xy, check_point_in_composition):
11745 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11746 (glyph_to_pixel_coords): Remove; unused.
11747
16390cd2
PE
11748 * dired.c (file_name_completion): Now static.
11749
11750 * dbusbind.c (xd_in_read_queued_messages): Now static.
11751
a25f4dfa
PE
11752 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11753 * data.c (circular_list_error): Remove.
11754
14a9c8df
PE
11755 * commands.h (last_point_position, last_point_position_buffer):
11756 (last_point_position_window): Remove decls.
11757 * keyboard.c: Make these variables static.
11758
04f2d78b
CB
11759 * coding.h (coding, code_convert_region, encode_coding_gap):
11760 Remove decls.
74ab6df5
PE
11761 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11762 (iso_code_class, detect_coding, code_convert_region): Now static.
11763 (encode_coding_gap): Remove; unused.
11764
38dfbee1
PE
11765 * chartab.c (chartab_chars, chartab_bits): Now static.
11766
a2cb4e63
PE
11767 * charset.h (charset_iso_8859_1): Remove decl.
11768 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11769 Now static.
11770
127198fd
PE
11771 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11772 * ccl.c (Vccl_program_table): Now static.
11773 (check_ccl_update): Remove; unused.
11774
d85b608f
PE
11775 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11776 * category.h: ... from here.
11777 * category.c (check_category_table, set_category_set): Now static.
11778
31cd66f3
PE
11779 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11780 * lisp.h: Remove these decls.
11781
c358e587
PE
11782 * buffer.c (buffer_count): Remove unused var.
11783
e78aecca
PE
11784 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11785 so that it's not optimized away.
11786 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11787 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11788 exported only to the debugger.
11789
e192d7d3 11790 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11791 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11792
92470028
PE
11793 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11794 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11795 was inaccessible from Lisp.
11796 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11797 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11798
244ed907
PE
11799 alloc.c: Import and export fewer symbols, and remove unused items.
11800 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11801 is defined.
11802 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11803 it's not optimized away by whole-program optimization.
11804 (message_enable_multibyte, free_misc): Remove.
11805 (catchlist, handlerlist, mark_backtrace):
11806 Declare only if BYTE_MARK_STACK.
11807 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11808 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11809 (message_enable_multibyte): Remove decl.
11810 (free_misc, interval_free_list, float_block, float_block_index):
11811 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11812 (cons_free_list, last_marked_index):
11813 Now static.
11814 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11815 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11816 (mark_backtrace): Define only if BYTE_MARK_STACK.
11817 * xdisp.c (message_enable_multibyte): Now static.
11818
61c2b50e 11819 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11820 This makes it easier for human readers (and static analyzers)
11821 to see whether these variables are used from other modules.
11822 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11823 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11824 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11825 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11826 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11827 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11828 * xmenu.c, xselect.c:
11829 Declare Q* vars static if they are not used in other modules.
11830 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11831 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11832 Remove decls of unexported vars.
11833 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11834
95c82688
PE
11835 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11836
16a97296
PE
11837 Make Emacs functions such as Fatom 'static' by default.
11838 This makes it easier for human readers (and static analyzers)
11839 to see whether these functions can be called from other modules.
11840 DEFUN now defines a static function. To make the function external
11841 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11842 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11843 (Finit_image_library):
16a97296
PE
11844 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11845 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11846 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11847 Remove decls, since these functions are now static.
11848 (Funintern, Fget_internal_run_time): New decls, since these functions
11849 were already external.
95c82688 11850
16a97296
PE
11851 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11852 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11853 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11854 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11855 * keyboard.c, keymap.c, lread.c:
11856 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11857 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11858 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11859 Mark functions with DEFUE instead of DEFUN,
11860 if they are used in other modules.
11861 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11862 decls for now-static functions.
11863 * buffer.h (Fdelete_overlay): Remove decl.
11864 * callproc.c (Fgetenv_internal): Mark as internal.
11865 * composite.c (Fremove_list_of_text_properties): Remove decl.
11866 (Fcomposition_get_gstring): New forward static decl.
11867 * composite.h (Fcomposite_get_gstring): Remove decl.
11868 * dired.c (Ffile_attributes): New forward static decl.
11869 * doc.c (Fdocumntation_property): New forward static decl.
11870 * eval.c (Ffetch_bytecode): New forward static decl.
11871 (Funintern): Remove extern decl; now in .h file where it belongs.
11872 * fileio.c (Fmake_symbolic_link): New forward static decl.
11873 * image.c (Finit_image_library): New forward static decl.
11874 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11875 * intervals.h (Fprevious_property_change):
11876 (Fremove_list_of_text_properties): Remove decls.
11877 * keyboard.c (Fthis_command_keys): Remove decl.
11878 (Fcommand_execute): New forward static decl.
11879 * keymap.c (Flookup_key): New forward static decl.
11880 (Fcopy_keymap): Now static.
11881 * keymap.h (Flookup_key): Remove decl.
11882 * process.c (Fget_process): New forward static decl.
11883 (Fprocess_datagram_address): Mark as internal.
11884 * syntax.c (Fsyntax_table_p): New forward static decl.
11885 (skip_chars): Remove duplicate decl.
11886 * textprop.c (Fprevious_property_change): New forward static decl.
11887 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11888 Now internal.
11889 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11890 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11891
785bbd42
PE
11892 * editfns.c (Fformat): Remove unreachable code.
11893
8b913b57
AS
118942011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11895
11896 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11897 change. (Bug#8496)
11898
a6744a35
EZ
118992011-04-13 Eli Zaretskii <eliz@gnu.org>
11900
11901 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11902 when at ZV. (Bug#8487)
11903
e7974947
AS
119042011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11905
baad03f0
AS
11906 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11907 (Bug#8437)
11908 * keyboard.c (parse_tool_bar_item): Likewise.
11909 * sound.c (sound_cleanup, alsa_close): Likewise.
11910 * termcap.c (tgetent): Likewise.
11911 * xfns.c (x_default_font_parameter): Likewise.
11912 * xsettings.c (read_and_apply_settings): Likewise.
11913
e7974947
AS
11914 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11915 (overrun_check_free): Protoize.
11916
28272684
PE
119172011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11918
11919 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11920 since callers should never pass a negative size.
11921 Change the signature to match that of plain 'read' and 'write'; see
11922 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11923 * lisp.h: Update prototypes of emacs_write and emacs_read.
11924
11997c76
EZ
119252011-04-11 Eli Zaretskii <eliz@gnu.org>
11926
11927 * xdisp.c (redisplay_window): Don't try to determine the character
11928 position of the scroll margin if the window start point w->startp
e896f03c 11929 is outside the buffer's accessible region. (Bug#8468)
11997c76 11930
8a2cbd72
EZ
119312011-04-10 Eli Zaretskii <eliz@gnu.org>
11932
11933 Fix write-region and its subroutines for buffers > 2GB.
11934 * fileio.c (a_write, e_write): Modify declaration of arguments and
11935 local variables to support buffers larger than 2GB.
11936 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11937
11938 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11939 argument, local variables, and return value.
11940
11941 * lisp.h: Update prototypes of emacs_write and emacs_read.
11942
11943 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11944
4073e537 119452011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11946
1ebfdcb6
PE
11947 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11948
b2ded58d
PE
11949 Fix more problems found by GCC 4.6.0's static checks.
11950
7d66342c
PE
11951 * xdisp.c (vmessage): Use a better test for character truncation.
11952
bbf47d44
PE
11953 * charset.c (load_charset_map): <, not <=, for optimization,
11954 and to avoid potential problems with integer overflow.
9248994d 11955 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11956 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11957 * editfns.c (Fformat): Likewise.
1e69125e 11958 * syntax.c (skip_chars): Likewise.
3befa583 11959
e3019616
PE
11960 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11961 This also lets GCC 4.6.0 generate slightly better loop code.
11962
becfa255
PE
11963 * callint.c (Fcall_interactively): <, not <=, for optimization.
11964 (Fcall_interactively): Count the number of arguments produced,
11965 not the number of arguments given. This is simpler and lets GCC
11966 4.6.0 generate slightly better code.
11967
dae0cd48
PE
11968 * ftfont.c: Distingish more carefully between FcChar8 and char.
11969 The previous code passed unsigned char * to a functions like
11970 strlen and xstrcasecmp that expect char *, which does not
11971 conform to the C standard.
11972 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11973 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11974 char * when the C standard requires it.
11975
76032d70
PE
11976 * keyboard.c (read_char): Remove unused var.
11977
eb3f1cc8
PE
11978 * eval.c: Port to Windows vsnprintf (Bug#8435).
11979 Include <limits.h>.
11980 (SIZE_MAX): Define if the headers do not.
11981 (verror): Do not give up if vsnprintf returns a negative count.
11982 Instead, grow the buffer. This ports to Windows vsnprintf, which
11983 does not conform to C99. Problem reported by Eli Zaretskii.
11984 Also, simplify the allocation scheme, by avoiding the need for
11985 calling realloc, and removing the ALLOCATED variable.
11986
70476b54
PE
11987 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11988
12020a9e
PE
11989 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11990 But keep the doprint source code for now, as we might revamp it
11991 and use it again (Bug#8435).
ea6c7ae6
PE
11992 * lisp.h (doprnt): Remove.
11993 * Makefile.in (base_obj): Remove doprnt.o.
11994 * deps.mk (doprnt.o): Remove.
11995
5fdb398c
PE
11996 error: Print 32- and 64-bit integers portably (Bug#8435).
11997 Without this change, on typical 64-bit hosts error ("...%d...", N)
11998 was used to print both 32- and 64-bit integers N, which relied on
11999 undefined behavior.
61bdb816 12000 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12001 * lisp.h (error, verror): Mark as printf-like functions.
12002 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12003 Report overflow in size calculations when allocating printf buffer.
12004 Do not truncate output string at its first null byte.
12005 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12006 Truncate the output at a character boundary, since vsnprintf does not
12007 do that.
12008 * charset.c (check_iso_charset_parameter): Convert internal
12009 character to string before calling 'error', since %c now has the
12010 printf meaning.
12011 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12012 overflow when computing char to be passed to 'error'. Do not
12013 pass Lisp_Object to 'error'; pass the integer instead.
12014 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12015 formatted with plain %d.
12016
b189fa66
PE
12017 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12018
bff87ef0
PE
12019 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12020
7e2cac20
PE
12021 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12022
ce4d90b5
PE
12023 * xterm.c (x_catch_errors): Remove duplicate declaration.
12024
266c9547
PE
12025 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12026
79c49ad2
PE
12027 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12028
368f4090
JM
120292011-04-10 Jim Meyering <meyering@redhat.com>
12030
12031 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12032 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12033 return ssize_t not "int", and use size_t as the buffer length.
12034 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12035 * gnutls.h: Update declarations.
12036 * process.c (read_process_output): Use ssize_t, to match.
12037 (send_process): Likewise.
12038
a32d4040
CY
120392011-04-09 Chong Yidong <cyd@stupidchicken.com>
12040
12041 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12042
8546720e 120432011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12044
04f2d78b
CB
12045 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12046 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12047
8546720e
GM
12048 * xterm.c (handle_one_xevent):
12049 * xmenu.c (create_and_show_popup_menu):
12050 * xselect.c (x_decline_selection_request)
12051 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12052
0a2f5c1a 120532011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12054
12055 Fix some uses of `int' instead of EMACS_INT.
12056 * search.c (string_match_1, fast_string_match)
12057 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12058 (scan_buffer, find_next_newline_no_quit)
12059 (find_before_next_newline, search_command, Freplace_match)
12060 (Fmatch_data): Make some `int' variables be EMACS_INT.
12061
12062 * xdisp.c (display_count_lines): 3rd argument and return value now
12063 EMACS_INT. All callers changed.
12064 (pint2hrstr): Last argument is now EMACS_INT.
12065
12066 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12067 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12068 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12069 (decode_coding_utf_16, decode_coding_emacs_mule)
12070 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12071 (decode_coding_ccl, decode_coding_charset)
12072 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12073 (decode_coding_iso_2022, decode_coding_emacs_mule)
12074 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12075 <char_offset, last_offset>: Declare EMACS_INT.
12076 (encode_coding_utf_8, encode_coding_utf_16)
12077 (encode_coding_emacs_mule, encode_invocation_designation)
12078 (encode_designation_at_bol, encode_coding_iso_2022)
12079 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12080 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12081 Declare EMACS_INT.
12082 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12083 (encode_invocation_designation): Last argument P_NCHARS is now
12084 EMACS_INT.
12085 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12086 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12087
12088 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12089 All users changed.
12090
12091 * ccl.c (Fccl_execute_on_string): Declare some variables
12092 EMACS_INT.
12093
8546720e 120942011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12095
12096 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12097
4e19a977
CS
120982011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12099
12100 * process.c (Fformat_network_address): Doc fix.
12101
87302331
R
121022011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12103
ee7683eb 12104 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12105
cbb59342
CY
121062011-04-08 Chong Yidong <cyd@stupidchicken.com>
12107
12108 * keyboard.c (read_char): Call Lisp function help-form-show,
12109 instead of using internal_with_output_to_temp_buffer.
12110 (Qhelp_form_show): New var.
e0d38eeb 12111 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12112
12113 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12114
12115 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12116
e67a13ab
CY
121172011-04-06 Chong Yidong <cyd@stupidchicken.com>
12118
04f2d78b
CB
12119 * process.c (Flist_processes): Remove to Lisp.
12120 (list_processes_1): Delete.
e67a13ab 12121
973f782d
EZ
121222011-04-06 Eli Zaretskii <eliz@gnu.org>
12123
7c106b1e
EZ
12124 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12125
973f782d
EZ
12126 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12127
41cf7d1a 121282011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12129
ca23cc88
PE
12130 Fix more problems found by GCC 4.6.0's static checks.
12131
f390e2d5
PE
12132 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12133
42eea0d0
PE
12134 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12135
b69769da 12136 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12137
f9541e84
PE
12138 * xdisp.c (vmessage): Mark as a printf-like function.
12139
13841b55
PE
12140 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12141
c136c10f
PE
12142 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12143
5e2d4a30
PE
12144 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12145 printf-like functions.
12146 (tiff_load): Add casts to remove these marks before passing them
12147 to system-supplied API.
12148
583f48b9
PE
12149 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12150
b25d760e
PE
12151 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12152 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12153 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12154 directly, rather than having caller test rule sign. This avoids
12155 some unnecessary tests.
12156 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12157 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12158 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12159
bc7b6697 12160 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12161 (xfont_open): Avoid unnecessary tests.
bc7b6697 12162
27ccc379
PE
12163 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12164
dcd5c89a
PE
12165 * composite.h, composite.c (composition_gstring_put_cache):
12166 Use EMACS_INT, not int, for length.
12167
b13a45c6
PE
12168 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12169 breaking out part of COMPOSITION_DECODE_RULE.
12170 (COMPOSITION_DECODE_RULE): Use it.
12171 * composite.c (get_composition_id): Remove unused local vars,
12172 by using the new macro.
12173
1e792e4d
PE
12174 * textprop.c (set_text_properties_1): Change while to do-while,
12175 since the condition is always true at first.
12176
dc6c6455 12177 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12178 (interval_deletion_adjustment): Return unsigned value.
12179 All uses changed.
dc6c6455 12180
aba7731a
PE
12181 * process.c (list_processes_1, create_pty, read_process_output):
12182 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12183 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12184 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12185 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12186 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12187
fdfc4bf3
PE
12188 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12189
fca8fe46 12190 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12191 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12192
06a0259a 12193 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12194 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12195 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12196
e7b9e80f
PE
12197 * print.c (print_error_message): Avoid int overflow.
12198
56201685
PE
12199 * font.c (font_list_entities): Redo for clarity,
12200 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12201
78834453 12202 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12203 (font_score): Avoid potential overflow in diff calculation.
78834453 12204
0bc0b309 12205 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12206 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12207
e610eaca
PE
12208 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12209
b895abce
PE
12210 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12211 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12212 can always succeed if overflow has undefined behavior.
12213
1f1d9321 12214 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12215 (wordify): Omit three unnecessary tests.
1f1d9321 12216
c59478bc
PE
12217 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12218 All callers changed. This avoids the need for an unused var.
12219
79b73827
PE
12220 * casefiddle.c (casify_region): Remove var that is set but not used.
12221
a4db5dfe
PE
12222 * dired.c (file_name_completion): Remove var that is set but not used.
12223
43aae36e
PE
12224 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12225
2a47c44d 12226 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12227 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12228
a37c69bf
PE
12229 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12230 Check for integer overflow on size calculations.
12231
328ab8e7
PE
12232 * buffer.c (Fprevious_overlay_change): Remove var that is set
12233 but not used.
12234
e5a2a5cb
PE
12235 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12236 Remove vars that are set but not used.
8d84a6eb 12237 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12238 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12239
a60e5f68
PE
12240 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12241
f661cb61 12242 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12243 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12244
f0397f5a
PE
12245 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12246 that are set but not used.
12247
8664db06 12248 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12249 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12250
6abdaa4a
PE
12251 * xselect.c (x_get_local_selection, x_handle_property_notify):
12252 Remove vars that are set but not used.
12253
0ce7538d 12254 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12255 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12256
9ae848fc
PE
12257 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12258 Remove var that is set but not used.
0b918413
PE
12259 (scroll_bar_windows_size): Now size_t, not int.
12260 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12261 Check for overflow.
9ae848fc 12262
a5a62657
PE
12263 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12264 (map_tty_color) [!defined MSDOS]: Likewise.
12265
5c5cdd39
PE
12266 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12267
66ebf983
PE
12268 * coding.c: Remove vars that are set but not used.
12269 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12270 All callers changed.
12271 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12272 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12273 (decode_coding_charset): Remove vars that are set but not used.
12274
1be4d761
PE
12275 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12276 that is set but not used.
12277
47553fa8
PE
12278 * print.c (print_object): Remove var that is set but not used.
12279
1f7196bf 12280 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12281 The gnulib version avoids calling malloc in the usual case,
12282 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12283 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12284 * filelock.c (current_lock_owner): Likewise.
12285 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12286 * sysdep.c: Include allocator.h, careadlinkat.h.
12287 (emacs_no_realloc_allocator): New static constant.
12288 (emacs_readlink): New function.
fdb61804
PE
12289 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12290 ../lib/careadlinkat.h.
d1fdcab7 12291
f84c17c7
SM
122922011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12293
12294 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12295 first non-nil return value).
12296
ef3862ad
JD
122972011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12298
12299 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12300 if not defined (Bug#8403).
12301
376a7006
JB
123022011-04-02 Juanma Barranquero <lekktu@gmail.com>
12303
12304 * xdisp.c (display_count_lines): Remove parameter `start',
12305 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12306 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12307 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12308 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12309 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12310 and thereabouts. All callers changed.
12311 (get_per_char_metric): Remove parameter `f', unused since
12312 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12313
6ca3801d
JM
123142011-04-02 Jim Meyering <meyering@redhat.com>
12315
12316 do not dereference NULL upon failed strdup
12317 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12318 (ns_get_family): Likewise.
12319
d8e2b5ba
JB
123202011-04-02 Juanma Barranquero <lekktu@gmail.com>
12321
12322 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12323
8c74fcbd
JD
123242011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12325
12326 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12327 later (Bug#8403).
12328
7200d79c
SM
123292011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12330
03408648 12331 Add lexical binding.
7200d79c 12332
03408648
SM
12333 * window.c (Ftemp_output_buffer_show): New fun.
12334 (Fsave_window_excursion):
12335 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12336
12337 * lread.c (lisp_file_lexically_bound_p): New function.
12338 (Fload): Bind Qlexical_binding.
12339 (readevalloop): Remove `evalfun' arg.
12340 Bind Qinternal_interpreter_environment.
12341 (Feval_buffer): Bind Qlexical_binding.
12342 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12343 Mark as dynamic.
12344 (syms_of_lread): Declare `lexical-binding'.
12345
12346 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12347
12348 * keyboard.c (eval_dyn): New fun.
12349 (menu_item_eval_property): Use it.
ca105506
SM
12350
12351 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12352
03408648
SM
12353 * fns.c (concat, mapcar1): Accept byte-code-functions.
12354
12355 * eval.c (Fsetq): Handle lexical vars.
12356 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12357 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12358 (FletX, Flet): Obey lexical binding.
12359 (Fcommandp): Handle closures.
12360 (Feval): New `lexical' arg.
12361 (eval_sub): New function extracted from Feval. Use it almost
12362 everywhere where Feval was used. Look up vars in lexical env.
12363 Handle closures.
12364 (Ffunctionp): Move from subr.el.
12365 (Ffuncall): Handle closures.
12366 (apply_lambda): Remove `eval_flags'.
12367 (funcall_lambda): Handle closures and new byte-code-functions.
12368 (Fspecial_variable_p): New function.
12369 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12370 but without exporting it to Lisp.
23aba0ea 12371
23aba0ea 12372 * doc.c (Fdocumentation, store_function_docstring):
03408648 12373 * data.c (Finteractive_form): Handle closures.
23aba0ea 12374
03408648
SM
12375 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12376 interactive spec.
ba83908c 12377
04f2d78b
CB
12378 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12379 New byte-codes.
03408648
SM
12380 (exec_byte_code): New function extracted from Fbyte_code to handle new
12381 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12382
03408648 12383 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12384
03408648 12385 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12386
e2abce01
JB
123872011-03-31 Juanma Barranquero <lekktu@gmail.com>
12388
12389 * xdisp.c (redisplay_internal): Fix prototype.
12390
63696a73 123912011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12392
63696a73 12393 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12394 (try_scrolling): Use it when setting scroll_limit.
12395 Limit scrolling to 100 screen lines.
63696a73
EZ
12396 (redisplay_window): Even when falling back on "recentering",
12397 position point in the window according to scroll-conservatively,
12398 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12399
12400 (try_scrolling): When point is above the window, allow searching
12401 as far as scroll_max, or one screenful, to compute vertical
12402 distance from PT to the scroll margin position. This prevents
12403 try_scrolling from unnecessarily failing when
12404 scroll-conservatively is set to a value slightly larger than the
12405 window height. Clean up the case of PT below the margin at bottom
12406 of window: scroll_max can no longer be INT_MAX. When aggressive
12407 scrolling is in use, don't let point enter the opposite scroll
12408 margin as result of the scroll.
12409 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12410 threshold of 100 lines for never-recentering scrolling.
12411
e4cc2dfc
JB
124122011-03-31 Juanma Barranquero <lekktu@gmail.com>
12413
12414 * dispextern.h (move_it_by_lines):
12415 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12416 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12417 (message_log_check_duplicate): Remove parameters `prev_bol' and
12418 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12419 (redisplay_internal): Remove parameter `preserve_echo_area',
12420 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12421
12422 * indent.c (Fvertical_motion):
12423 * window.c (window_scroll_pixel_based, Frecenter):
12424 Don't pass `need_y_p' to `move_it_by_lines'.
12425
1c470562
SM
124262011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12427
44f230aa
SM
12428 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12429 steal a few bits to be more compact.
12430 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12431 Remove unneeded casts.
12432
1c470562
SM
12433 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12434
888adce9
ZK
124352011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12436
12437 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12438 binding" message (bug#7967).
12439
f838ed7b
PE
124402011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12441
77861b95
PE
12442 Fix more problems found by GCC 4.6.0's static checks.
12443
de6dbc14
PE
12444 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12445 Remove unused local var.
12446
f838ed7b
PE
12447 * editfns.c (Fmessage_box): Remove unused local var.
12448
792c7b2b
PE
12449 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12450 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12451 Omit unused local vars.
c499e557 12452 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12453 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12454 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12455 Omit unused local var.
12456
ba0165e1
PE
12457 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12458 Don't assume string length fits in int.
32ad8845 12459 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12460 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12461
3c59b4c9
PE
12462 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12463 instead of alloca (Bug#8344).
12464
a3eed478 12465 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12466 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12467
eb4d412d
PE
12468 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12469
1658b401
PE
12470 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12471 concerns.
12472
12473 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12474
12475 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12476
9a2c6e05
PE
12477 * keyboard.c (syms_of_keyboard): Use the same style as later
12478 in this function when indexing through an array. This also
12479 works around GCC bug 48267.
12480
03d0a109
PE
12481 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12482
44f730c8
PE
12483 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12484
fe75f926
PE
12485 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12486 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12487
ffa8c828
PE
12488 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12489 This avoids undefined behavior on integer overflow, and is a bit
12490 more convenient anyway since it is compared to a size_t variable.
12491
c5101a77
PE
12492 Variadic C functions now count arguments with size_t, not int.
12493 This avoids an unnecessary limitation on 64-bit machines, which
12494 caused (substring ...) to crash on large vectors (Bug#8344).
12495 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12496 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12497 All variadic functions and their callers changed accordingly.
c5101a77
PE
12498 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12499 * data.c (arith_driver, float_arith_driver): Likewise.
12500 * editfns.c (general_insert_function): Likewise.
12501 * eval.c (struct backtrace.nargs, interactive_p)
12502 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12503 (funcall_lambda, mark_backtrace): Likewise.
12504 * fns.c (concat): Likewise.
12505 * frame.c (x_set_frame_parameters): Likewise.
12506 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12507 0 if not found, not -1. All callers changed.
12508
dd3f25f7
PE
12509 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12510 (stack_copy_size): Now size_t, not int.
12511 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12512
461c2ab9
JB
125132011-03-28 Juanma Barranquero <lekktu@gmail.com>
12514
12515 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12516 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12517 All callers changed.
12518
12519 * lisp.h (multibyte_char_to_unibyte):
12520 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12521 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12522 * character.h (CHAR_TO_BYTE8):
12523 * cmds.c (internal_self_insert):
12524 * editfns.c (general_insert_function):
12525 * keymap.c (push_key_description):
12526 * search.c (Freplace_match):
12527 * xdisp.c (message_dolog, set_message_1): All callers changed.
12528
f6d62986
SM
125292011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12530
12531 * keyboard.c (safe_run_hook_funcall): New function.
12532 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12533 don't set the hook to nil, but remove the offending function instead.
12534 (Qcommand_hook_internal): Remove, unused.
12535 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12536 Vcommand_hook_internal.
12537
12538 * eval.c (enum run_hooks_condition): Remove.
12539 (funcall_nil, funcall_not): New functions.
12540 (run_hook_with_args): Call each function through a `funcall' argument.
12541 Remove `cond' argument, now redundant.
12542 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12543 (Frun_hook_with_args_until_failure): Adjust accordingly.
12544 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12545
1db5b1ad
JB
125462011-03-28 Juanma Barranquero <lekktu@gmail.com>
12547
12548 * dispextern.h (string_buffer_position): Remove declaration.
12549
12550 * print.c (strout): Remove parameter `multibyte', unused since
12551 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12552
12553 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12554 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12555 All callers changed.
12556
12557 * w32.c (_wsa_errlist): Use braces for struct initializers.
12558
12559 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12560 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12561 All callers changed.
12562 (string_buffer_position): Likewise. Also, make static (it's never
12563 used outside xdisp.c).
12564 (cursor_row_p): Remove parameter `w', unused since
12565 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12566 (decode_mode_spec): Remove parameter `precision', introduced during
12567 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12568 All callers changed.
12569
5ffb62aa
JD
125702011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12571
12572 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12573
461c2ab9 125742011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12575
12576 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12577 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12578 (ns_update_auto_hide_menu_bar): New functions.
12579 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12580 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12581 ns_constrain_all_frames.
12582 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12583 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12584
5c380ffb
JD
125852011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12586
12587 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12588
9af30bdf
GM
125892011-03-27 Glenn Morris <rgm@gnu.org>
12590
12591 * syssignal.h: Replace RETSIGTYPE with void.
12592 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12593 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12594 Replace SIGTYPE with void everywhere.
12595 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12596 * s/template.h (SIGTYPE): Remove commented out definition.
12597
e2abce01
JB
125982011-03-26 Eli Zaretskii <eliz@gnu.org>
12599
12600 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12601 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12602
f868cd8a
JB
126032011-03-26 Juanma Barranquero <lekktu@gmail.com>
12604
59eb0929
JB
12605 * w32.c (read_unc_volume): Use parameter `henum', instead of
12606 global variable `wget_enum_handle'.
12607
12608 * keymap.c (describe_vector): Remove parameters `indices' and
12609 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12610 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12611
f868cd8a
JB
12612 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12613
12614 * keyboard.c (timer_check): Remove parameter `do_it_now',
12615 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12616 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12617 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12618
12619 * keyboard.c (read_char):
12620 * w32menu.c (w32_menu_display_help):
12621 * xmenu.c (show_help_event, menu_help_callback):
12622 Adjust calls to `show_help_echo'.
12623
12624 * gtkutil.c (xg_maybe_add_timer):
12625 * keyboard.c (readable_events):
12626 * process.c (wait_reading_process_output):
12627 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12628
12629 * insdel.c (adjust_markers_gap_motion):
12630 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12631 (gap_left, gap_right): Don't call it.
12632
2ecf6fdb
CY
126332011-03-25 Chong Yidong <cyd@stupidchicken.com>
12634
12635 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12636 incurred during fontification.
12637
6b1f9ba4
JB
126382011-03-25 Juanma Barranquero <lekktu@gmail.com>
12639
12640 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12641 (DEFVAR_PER_BUFFER): Don't pass it.
12642
12643 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12644 (scrolling_window): Don't pass it.
12645
0f4a96b5
JB
126462011-03-25 Juanma Barranquero <lekktu@gmail.com>
12647
12648 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12649
12650 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12651 and `suffix'.
12652 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12653 of variables specific to SELinux and computation of `encoded_absname'.
12654
12655 * image.c (XPutPixel): Remove unused variable `height'.
12656
12657 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12658
12659 * unexw32.c (get_section_info): Remove unused variable `section'.
12660
12661 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12662 (system_process_attributes): Remove unused variable `sess'.
12663 (sys_read): Remove unused variable `err'.
12664
12665 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12666 (w32_wnd_proc): Remove unused variable `isdead'.
12667 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12668 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12669 (x_create_tip_frame): Remove unused variable `tem'.
12670
12671 * w32inevt.c (w32_console_read_socket):
12672 Remove unused variable `no_events'.
12673
12674 * w32term.c (x_draw_composite_glyph_string_foreground):
12675 Remove unused variable `width'.
12676
1149507c
JB
126772011-03-24 Juanma Barranquero <lekktu@gmail.com>
12678
12679 * w32term.c (x_set_glyph_string_clipping):
12680 Don't pass uninitialized region to CombineRgn.
12681
9c88f339
JB
126822011-03-23 Juanma Barranquero <lekktu@gmail.com>
12683
12684 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12685 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12686 (Fx_close_connection): Remove unused variable `i'.
12687
12688 * w32font.c (w32font_draw): Return number of glyphs.
12689 (w32font_open_internal): Remove unused variable `i'.
12690 (w32font_driver): Add missing initializer.
12691
12692 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12693 (fill_in_menu): Remove unused variable `items_added'.
12694
12695 * w32term.c (last_mouse_press_frame): Remove static global variable.
12696 (w32_clip_to_row): Remove unused variable `f'.
12697 (x_delete_terminal): Remove unused variable `i'.
12698
12699 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12700 (NOTHING): Remove unused static global variable.
12701 (uniscribe_check_otf): Remove unused variable `table'.
12702 (uniscribe_font_driver): Add missing initializers.
12703
dee091a3
JD
127042011-03-23 Julien Danjou <julien@danjou.info>
12705
12706 * term.c (Fsuspend_tty, Fresume_tty):
12707 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12708 * window.c (temp_output_buffer_show):
12709 * insdel.c (signal_before_change):
12710 * frame.c (Fhandle_switch_frame):
12711 * fileio.c (Fdo_auto_save):
12712 * emacs.c (Fkill_emacs):
12713 * editfns.c (save_excursion_restore):
12714 * cmds.c (internal_self_insert):
12715 * callint.c (Fcall_interactively):
12716 * buffer.c (Fkill_all_local_variables):
12717 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12718 Use Frun_hooks.
0f4a96b5 12719 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12720 unconditionally since it does the check itself.
dee091a3 12721
2c520ab5 127222011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12723
c9c49752
PE
12724 Fix more problems found by GCC 4.5.2's static checks.
12725
8abc3f12
PE
12726 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12727 the first time through the loop, since we know p0 < p1 then.
12728 This also avoids a gcc -Wstrict-overflow warning.
12729
a2d26660
PE
12730 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12731 leading to a memory leak, possible in functions like
12732 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12733 of objects (Bug#8318).
a2d26660 12734
916c72e9
PE
12735 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12736 that could (at least in theory) be that large.
12737
19ab8a18
PE
12738 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12739 This is less likely to overflow, and avoids undefined behavior if
12740 overflow does occur. All callers changed. Use strtoul to scan
12741 for the unsigned long integer.
b7cbbd6f
PE
12742 (pint2hrstr): Simplify and tune code slightly.
12743 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12744
f0641eff
PE
12745 * scroll.c (do_scrolling): Work around GCC bug 48228.
12746 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12747
7f650bb9
PE
12748 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12749 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12750 (validate_x_resource_name): Simplify count usage.
12751 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12752
37dd57d1
PE
12753 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12754 fail (Bug#8306).
81e56e61 12755
699979fc 12756 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12757
401bf9b4
PE
12758 * process.c (Fmake_network_process): Use socklen_t, not int,
12759 where POSIX says socklen_t is required in portable programs.
12760 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12761 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12762 (Fmake_network_process, server_accept_connection):
12763 (wait_reading_process_output, read_process_output):
12764 Likewise.
12765
b93aacde
PE
12766 * process.c: Rename or move locals to avoid shadowing.
12767 (list_processes_1, Fmake_network_process):
12768 (read_process_output_error_handler, exec_sentinel_error_handler):
12769 Rename or move locals.
4dc343ee 12770 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12771 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12772 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12773 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12774 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12775
af8a867c 12776 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12777 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12778 Include tparam.h instead, since it declares them.
af8a867c
PE
12779 * cm.h (PC): Remove extern decl; tparam.h now does this.
12780 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12781 * terminfo.c: Include tparam.h, to check interfaces.
12782 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12783 (tparam): Adjust signature to match interface in tparam.h;
12784 this removes some undefined behavior. Check that outstring and len
12785 are zero, which they always are with Emacs.
12786 * tparam.h (PC, BC, UP): New extern decls.
12787
0248044d 12788 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12789 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12790
8ff096c1 12791 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12792 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12793 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12794 (ftfont_list): Remove unused local.
49eaafba
PE
12795 (get_adstyle_property, ftfont_pattern_entity):
12796 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12797 Rename locals to avoid shadowing.
8ff096c1 12798
e2be39f6
PE
12799 * xfont.c (xfont_list_family): Mark var as initialized.
12800
c9735e30
PE
12801 * xml.c (make_dom): Now static.
12802
8f5201ae
PE
12803 * composite.c (composition_compute_stop_pos): Rename local to
12804 avoid shadowing.
b246f932
PE
12805 (composition_reseat_it): Remove unused locals.
12806 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12807 (composition_update_it): Mark var as initialized.
11b61122
PE
12808 (find_automatic_composition): Mark vars as initialized,
12809 with a FIXME (Bug#8290).
8f5201ae 12810
760fbc2c
PE
12811 character.h: Rename locals to avoid shadowing.
12812 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12813 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12814 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12815 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12816 to avoid shadowing.
12817
ff08eb85
PE
12818 * textprop.c (property_change_between_p): Remove; unused.
12819
fc7bf025
PE
12820 * intervals.c (interval_start_pos): Now static.
12821
235d7abc
PE
12822 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12823
44f230aa
SM
12824 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12825 Rename locals to avoid shadowing.
3e7d6594 12826
50060332
PE
12827 * sound.c (wav_play, au_play, Fplay_sound_internal):
12828 Fix pointer signedness.
d01f234b 12829 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12830 (wav_play): Initialize a variable to 0, to prevent undefined
12831 behavior (Bug#8278).
50060332 12832
c4fc4e30
PE
12833 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12834
918436ed
PE
12835 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12836
c939f91b
PE
12837 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12838 clobbering (Bug#8298).
b9c7f648
PE
12839 * sysdep.c (sys_subshell): Likewise.
12840 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12841
6bd8c144
PE
12842 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12843 This should get cleaned up, so that child_setup has the
12844 same signature on all platforms.
12845
7710357c 12846 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12847 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12848
c59da222
CY
128492011-03-22 Chong Yidong <cyd@stupidchicken.com>
12850
12851 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12852 not to be necessary, and produces flickering.
12853
66b87493
GM
128542011-03-20 Glenn Morris <rgm@gnu.org>
12855
12856 * config.in: Remove file.
12857
45b6f6d5
JB
128582011-03-20 Juanma Barranquero <lekktu@gmail.com>
12859
12860 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12861 are now in src/globals.h.
12862 (syms_of_minibuf): Remove spurious & from previous change.
12863
cd394be1 128642011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12865
12866 * minibuf.c (completing-read-function): New variable.
12867 (completing-read-default): Rename from completing-read.
12868 (completing-read): Call completing-read-function.
12869
b14e3e21
CY
128702011-03-19 Juanma Barranquero <lekktu@gmail.com>
12871
12872 * xfaces.c (Fx_load_color_file):
12873 Read color file from absolute filename (bug#8250).
12874
f2b726e6
JB
128752011-03-19 Juanma Barranquero <lekktu@gmail.com>
12876
12877 * makefile.w32-in: Update dependencies.
12878
09f6ff02
EZ
128792011-03-17 Eli Zaretskii <eliz@gnu.org>
12880
12881 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12882
29a6015a
PE
128832011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12884
a3a6c54e
PE
12885 Fix more problems found by GCC 4.5.2's static checks.
12886
b766f867
PE
12887 * process.c (make_serial_process_unwind, send_process_trap):
12888 (sigchld_handler): Now static.
12889
be02381c
PE
12890 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12891 That way, the code declares only the vars that it needs.
12892 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12893 * s/cygwin.h (PTY_ITERATION): Likewise.
12894 * s/darwin.h (PTY_ITERATION): Likewise.
12895 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12896
57048744
PE
12897 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12898 * process.c (allocate_pty): Don't declare stb unless it's needed.
12899
7914961c 12900 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12901 (CONSTANTLIM): Remove; unused.
12902 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12903 Define only if needed.
7914961c 12904
b3967b18
PE
12905 * unexelf.c (unexec): Name an expression,
12906 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12907 Use a different way to cause a compilation error if anyone uses
12908 n rather than nn, a way that does not involve shadowing.
73366a00 12909 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12910
29a6015a
PE
12911 * deps.mk (unexalpha.o): Remove; unused.
12912
43cfc33e 12913 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12914 * unexec.h: New file.
ce701a33
PE
12915 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12916 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12917 Depend on unexec.h.
12918 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12919 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12920 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12921 Change as necessary to match prototype in unexec.h.
ce701a33 12922
01f44d5a
PE
12923 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12924 shadowing.
4f63c6bb 12925 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12926
a6670b0b
PE
12927 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12928 Rename locals to avoid shadowing.
12929
cef2010d 12930 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12931 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12932
d4d7173a
PE
12933 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12934
f08b802a
PE
12935 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12936 warning when compiling print.c.
12937
3ddb0639
PE
12938 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12939 instead of using an uninitialized var.
5ad03b97 12940 (font_sort_entities): Mark var as initialized.
3ddb0639 12941
170a2692
PE
12942 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12943
e663c700
PE
12944 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12945 pointers to constants.
89bc529a 12946 (font_parse_fcname): Remove unused vars.
7b81e2d0 12947 (font_delete_unmatched): Now static.
ea838e10 12948 (font_get_spec): Remove; unused.
13a547c6
PE
12949 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12950 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12951 Rename or move locals to avoid shadowing.
e663c700 12952
2a80c887 12953 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12954 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12955
1384fa33 12956 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12957 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12958
8b2c52e9
PE
12959 * alloc.c (mark_backtrace): Move decl from here ...
12960 * lisp.h: ... to here, so that it can be checked.
12961
475545b5 12962 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12963 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12964 (lisp_indirect_variable): Name an expression,
12965 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12966 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12967
b1349114 12968 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12969 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12970 Use const pointer when appropriate.
b1349114 12971
a2928364
PE
12972 * lisp.h (get_system_name, get_operating_system_release):
12973 Move decls here, to check interfaces.
12974 * process.c (get_operating_system_release): Move decl to lisp.h.
12975 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12976 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12977 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12978 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12979 (Fformat_time_string, Fencode_time, Finsert_char):
12980 (Ftranslate_region_internal, Fformat):
12981 Rename or remove local vars to avoid shadowing.
9710023e 12982 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12983
a415e694
PE
12984 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12985 avoid shadowing.
12986
8ef4622d
PE
12987 * lisp.h (eassert): Check that the argument compiles, even if
12988 ENABLE_CHECKING is not defined.
12989
946f9a5b
PE
12990 * data.c (Findirect_variable): Name an expression, to avoid
12991 gcc -Wbad-function-cast warning.
112396d6 12992 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12993 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12994 (Fmake_variable_buffer_local, Fmake_local_variable):
12995 Mark variables as initialized.
52746918 12996 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12997
e5aab7e7 12998 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12999 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13000 Rename locals to avoid shadowing.
dff45157
PE
13001 (mark_stack): Move local variables into the #ifdef region where
13002 they're used.
7bc26fdb
PE
13003 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13004 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13005 needed otherwise.
13006 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13007 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13008 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13009
e5aab7e7
PE
13010 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13011 avoids undefined behavior in theory.
13012
4da60324
PE
13013 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13014
88043301
PE
13015 Use functions, not macros, for up- and down-casing (Bug#8254).
13016 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13017 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13018 to use the following functions instead of these macros.
13019 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13020 EMACS_INT, since callers assume the returned value fits in int.
13021 (upcase1): Likewise, for UPCASE_TABLE.
13022 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13023 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13024 the race-condition problem in the old DOWNCASE.
88043301 13025
19ed5445
PE
13026 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13027 Rename locals to avoid shadowing.
13028 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13029 (regex_compile, re_search_2, re_match_2_internal):
13030 Remove unused local vars.
952db0d7
PE
13031 (FREE_VAR): Rewrite so as not to use empty "else",
13032 which gcc can warn about.
da053e48 13033 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13034 (RETALLOC_IF): Define only if needed.
13035 (WORDCHAR_P): Likewise. This one is never needed, but is used
13036 only in a comment talking about a compiler bug, so put inside
13037 the #if 0 of that comment.
13038 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13039 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13040 Remove; unused.
19ed5445 13041
1f3561e4 13042 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13043 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13044 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13045
ded6f8f7
PE
13046 * search.c (simple_search): Remove unused var.
13047
dbd37a95
PE
13048 * dired.c (compile_pattern): Move decl from here ...
13049 * lisp.h: ... to here, so that it can be checked.
13050 (struct re_registers): New forward decl.
13051
7e47afad
PE
13052 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13053
85f24f61
PE
13054 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13055 All uses changed.
13056 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13057 Rename locals to avoid shadowing.
5671df8f 13058 (Fvertical_motion): Mark locals as initialized.
85f24f61 13059
181aa2be 13060 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13061 (casify_region): Mark local as initialized.
181aa2be 13062
930d429c
PE
13063 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13064
7082eac6
PE
13065 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13066 New macros, so that the caller can use some names other than
13067 gcpro1, gcpro2, etc.
13068 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13069 of the new macros.
13070 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13071 argument, for consistency with GCPRO2_VAR, etc: it is now the
13072 prefix of the variable, not the variable itself. All uses
13073 changed.
38b2c076
PE
13074 * dired.c (directory_files_internal, file_name_completion):
13075 Rename locals to avoid shadowing.
13076
15206ed9
PE
13077 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13078 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13079 dired.c's scmp function, had undefined behavior.
13080 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13081 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13082 * buffer.h: ... to here, because these macros use current_buffer,
13083 and the new implementation with inline functions needs to have
13084 current_buffer in scope now, rather than later when the macros
13085 are used.
13086 (downcase, upcase1): New static inline functions.
13087 (DOWNCASE, UPCASE1): Reimplement using these functions.
13088 This avoids undefined behavior in expressions like
13089 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13090 from race conditions in accessing the global variables
13091 case_temp1 and case_temp2.
13092 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13093 * lisp.h (case_temp1, case_temp2): Remove their decls.
13094 * character.h (ASCII_CHAR_P): Move from here ...
13095 * lisp.h: ... to here, so that the inline functions mentioned
13096 above can use them.
13097
4a6bea26
PE
13098 * dired.c (directory_files_internal_unwind): Now static.
13099
f14b7e14
PE
13100 * fileio.c (file_name_as_directory, directory_file_name):
13101 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13102 Now static.
2893f146
PE
13103 (file_name_as_directory): Use const pointers when appropriate.
13104 (Fexpand_file_name): Likewise. In particular, newdir might
13105 point at constant storage, so make it a const pointer.
fd4ead52 13106 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13107 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13108 signedness issues.
f839df0c
PE
13109 (Fset_file_times, Finsert_file_contents, auto_save_error):
13110 Rename locals to avoid shadowing.
f14b7e14 13111
5716756e 13112 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13113 (Ftry_completion, Fall_completions): Rename or remove locals
13114 to avoid shadowing.
5716756e 13115
b4c3046a
PE
13116 * marker.c (bytepos_to_charpos): Remove; unused.
13117
b45db522
PE
13118 * lisp.h (verify_bytepos, count_markers): New decls,
13119 so that gcc does not warn that these functions aren't declared.
13120
85876d07
PE
13121 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13122 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13123 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13124 (copy_text): Remove unused local var.
85876d07 13125
03d78a21 13126 * filelock.c (within_one_second): Now static.
b3dd38ab 13127 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13128
5df8f01b
PE
13129 * buffer.c (fix_overlays_before): Mark locals as initialized.
13130 (fix_start_end_in_overlays): Likewise. This function should be
13131 simplified by using pointers-to-pointers, but that's a different
13132 matter.
b1d876f1 13133 (switch_to_buffer_1): Now static.
8f54f30a
PE
13134 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13135 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13136
a70072c9 13137 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13138 Fix pointer signedness issue.
edced198
PE
13139 (sys_subshell): Mark local as volatile if checking for lint,
13140 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13141 (MAXPATHLEN): Define only if needed.
a70072c9 13142
a0977c44
PE
13143 * process.c (serial_open, serial_configure): Move decls from here ...
13144 * systty.h: ... to here, so that they can be checked.
13145
a884fdcc
PE
13146 * fns.c (get_random, seed_random): Move extern decls from here ...
13147 * lisp.h: ... to here, so that they can be checked.
13148
604efe86 13149 * sysdep.c (reset_io): Now static.
b8950c94 13150 (wait_for_termination_signal): Remove; unused.
604efe86 13151
38fc62d9
PE
13152 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13153 (copy_keymap_item, append_key, push_text_char_description):
13154 Now static.
1004a21a 13155 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13156 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13157 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13158 (describe_map_tree):
13159 Rename locals to avoid shadowing.
38fc62d9 13160
2f2650da
PE
13161 * keyboard.c: Declare functions static if they are not used elsewhere.
13162 (echo_char, echo_dash, cmd_error, top_level_2):
13163 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13164 (read_char, kbd_buffer_get_event, make_lispy_position):
13165 (make_lispy_event, make_lispy_movement, apply_modifiers):
13166 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13167 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13168 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13169 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13170 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13171
a053e86c 13172 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13173 (mark_kboards): Move decl here ...
13174 * alloc.c (mark_kboards): ... from here.
a053e86c 13175
4752793e
PE
13176 * lisp.h (force_auto_save_soon): New decl.
13177
74f10ca7 13178 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13179 (DEFINE_DUMMY_FUNCTION): New macro.
13180 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13181 Use it.
c03cd23f
PE
13182 (main): Add casts to avoid warnings
13183 if GCC considers string literals to be constants.
74f10ca7 13184
022e70d4
PE
13185 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13186
59d6fe83
PE
13187 * dbusbind.c: Pointer signedness fixes.
13188 (xd_signature, xd_append_arg, xd_initialize):
13189 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13190 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13191 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13192 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13193
78320123
PE
13194 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13195 if GCC considers string literals to be constants.
49cebcca 13196 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13197
35ac2a97
SM
131982011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13199
fb103ca9
SM
13200 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13201 (print_preprocess, print_object): New macro to fix last change.
13202
35ac2a97
SM
13203 * print.c (print_preprocess): Don't forget font objects.
13204
62973b41
JB
132052011-03-16 Juanma Barranquero <lekktu@gmail.com>
13206
13207 * emacs.c (USAGE3): Doc fixes.
13208
0e48bb22
AS
132092011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13210
13211 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13212 structure.
13213
7684e57b
JB
132142011-03-14 Juanma Barranquero <lekktu@gmail.com>
13215
13216 * lisp.h (VWindow_system, Qfile_name_history):
13217 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13218 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13219 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13220
13221 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13222 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13223
13224 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13225 * w32console.c (detect_input_pending, read_input_pending)
13226 (encode_terminal_code):
13227 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13228 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13229 (w32_system_caret_y, Qfile_name_history):
13230 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13231 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13232 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13233 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13234 * w32proc.c (Qlocal, report_file_error):
13235 * w32term.c (Vwindow_system, updating_frame):
13236 * w32uniscribe.c (initialized, uniscribe_font_driver):
13237 Remove unneeded extern declarations.
13238
2aa46d6c
CY
132392011-03-14 Chong Yidong <cyd@stupidchicken.com>
13240
c96bbc66 13241 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13242
cffc6f3b
CY
132432011-03-13 Chong Yidong <cyd@stupidchicken.com>
13244
13245 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13246 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13247 These macros can no longer be used for assignment.
13248
44f230aa
SM
13249 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13250 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13251 (record_buffer_markers, fetch_buffer_markers): New functions for
13252 recording and fetching special buffer markers.
13253 (set_buffer_internal_1, set_buffer_temp): Use them.
13254
13255 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13256
13257 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13258
13259 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13260 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13261
13262 * xdisp.c (hscroll_window_tree):
13263 (reconsider_clip_changes): Use PT instead of BUF_PT.
13264
d251f04b
EZ
132652011-03-13 Eli Zaretskii <eliz@gnu.org>
13266
13267 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13268 $(EMACS_ROOT)/lib/intprops.h.
13269
f0c77cd1
PE
132702011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13271
3eca4629
PE
13272 Fix more problems found by GCC 4.5.2's static checks.
13273
7c86ee98
PE
13274 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13275 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13276 (xg_free_frame_widgets): Make it clear that a local variable is
13277 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13278 (gdk_window_get_screen): Make it clear that this macro is needed
13279 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13280 (int_gtk_range_get_value): New function, which avoids a diagnostic
13281 from gcc -Wbad-function-cast.
13282 (xg_set_toolkit_scroll_bar_thumb): Use it.
13283 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13284 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13285 (get_utf8_string, xg_get_file_with_chooser):
13286 Rename locals to avoid shadowing.
13287 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13288
41729b81
PE
13289 * xgselect.c (xg_select): Remove unused var.
13290
f0c77cd1
PE
13291 * image.c (four_corners_best): Mark locals as initialized.
13292 (gif_load): Initialize transparent_p to zero (Bug#8238).
13293 Mark another local as initialized.
ec6cf4c6 13294 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13295
ce0ad53d 13296 * image.c (clear_image_cache): Now static.
d5d5a617 13297 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13298 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13299 (x_edge_detection): Remove unnecessary cast that
13300 gcc -Wbad-function-cast diagnoses.
2037898d 13301 (gif_load): Fix pointer signedness.
6ae141d6
PE
13302 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13303 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13304
33383987 133052011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13306
d32df629
PE
13307 Improve quality of tests for time stamp overflow.
13308 For example, without this patch (encode-time 0 0 0 1 1
13309 1152921504606846976) returns the obviously-bogus value (-948597
13310 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13311 reports time overflow. See
13312 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13313 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13314 * editfns.c: Include limits.h and intprops.h.
13315 (TIME_T_MIN, TIME_T_MAX): New macros.
13316 (time_overflow): Move earlier, to before first use.
13317 (hi_time, lo_time): New functions, for an accurate test for
13318 out-of-range times.
13319 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13320 (Fget_internal_run_time): Don't assume time_t fits in int.
13321 (make_time): Use list2 instead of Fcons twice.
13322 (Fdecode_time): More accurate test for out-of-range times.
13323 (check_tm_member): New function.
13324 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13325 (lisp_time_argument): Don't rely on undefined left-shift and
13326 right-shift behavior when checking for time stamp overflow.
8be6f318 13327
fe31d94c
PE
13328 * editfns.c (time_overflow): New function, refactoring common code.
13329 (Fformat_time_string, Fdecode_time, Fencode_time):
13330 (Fcurrent_time_string): Use it.
13331
8be6f318
PE
13332 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13333 * dired.c (make_time): Move to ...
13334 * editfns.c (make_time): ... here.
13335 * systime.h: Note the move.
13336
09d9db2c 133372011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13338
126bc0dc
YM
13339 * fringe.c (update_window_fringes): Remove unused variables.
13340
c47cbdfd
YM
13341 * unexmacosx.c (copy_data_segment): Also copy __got section.
13342 (Bug#8223)
13343
7ac80be9
EZ
133442011-03-12 Eli Zaretskii <eliz@gnu.org>
13345
c96bbc66 13346 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13347 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13348 Constify `char *' arguments and their references according to
13349 prototypes in tparam.h.
13350
ecb0f94d 13351 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13352
7ac80be9
EZ
13353 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13354 Adapt all references accordingly.
13355
13356 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13357
ef1fd07e
TT
133582011-03-11 Tom Tromey <tromey@redhat.com>
13359
13360 * buffer.c (syms_of_buffer): Remove obsolete comment.
13361
7ef4b50c
EZ
133622011-03-11 Eli Zaretskii <eliz@gnu.org>
13363
13364 * termhooks.h (encode_terminal_code): Declare prototype.
13365
13366 * msdos.c (encode_terminal_code): Don't declare prototype.
13367
13368 * term.c (encode_terminal_code): Now external again, used by
13369 w32console.c and msdos.c.
13370
44f230aa
SM
13371 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13372 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13373
4b1ec863 133742011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13375
1714f52b 13376 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13377
4b1ec863
PE
13378 * fringe.c (update_window_fringes): Mark locals as initialized
13379 (Bug#8227).
13380 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13381
524c7aa6
PE
13382 * alloc.c (mark_fringe_data): Move decl from here ...
13383 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13384 to check its interface.
13385 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13386
a5c0af81 13387 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13388 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13389 (fontset_font): Mark local as initialized.
a9a06e0b 13390 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13391
b4716021
PE
13392 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13393
811e9bac 13394 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13395 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13396 (x_own_selection, Fx_disown_selection_internal): Rename locals
13397 to avoid shadowing.
13398 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13399
7e3ab302
PE
13400 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13401 so that the caller can use some name other than gcpro1.
13402 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13403 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13404 (Fx_backspace_delete_keys_p):
13405 Use them to avoid shadowing, and rename vars to avoid shadowing.
13406 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13407 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13408 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13409 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13410 Remove unused locals.
7e3ab302
PE
13411 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13412 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13413 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13414 macros.
f78faa98 13415
e2b13473
PE
13416 * xterm.h (x_mouse_leave): New decl.
13417
77f23912
PE
13418 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13419 Remove unused functions.
cdf4ba58
PE
13420 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13421 (x_calc_absolute_position): Now static.
7411c686 13422 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13423 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13424 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13425 unless they are used.
38d0b34a
PE
13426 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13427 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13428 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13429 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13430 (x_error_catcher, x_connection_closed, x_error_handler):
13431 (x_error_quitter, xembed_send_message, x_iconify_frame):
13432 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13433 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13434 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13435
44f230aa
SM
13436 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13437 Rename or move locals to avoid shadowing.
6b463e58 13438 (tty_defined_color, merge_face_heights): Now static.
5967d051 13439 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13440 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13441 does not deduce is never used uninitialized.
73719eba
PE
13442 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13443 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13444
426994c3 13445 * terminal.c (store_terminal_param): Now static.
5489860b 13446
032f1620 13447 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13448 (set_frame_menubar): Remove unused local.
d4323972 13449 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13450 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13451 since they might point to immutable storage.
281585b0
PE
13452 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13453 since it's unused otherwise.
032f1620 13454
367c19e5 13455 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13456 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13457 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13458 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13459 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13460 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13461 does not deduce are never used uninitialized.
70739cbe 13462
07b48fa9
PE
13463 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13464
8868a238 13465 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13466 * window.c (window_loop, size_window):
13467 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13468
7e5cf297 13469 * window.c (display_buffer): Now static.
d6550a9f
PE
13470 (size_window): Mark variables that gcc -Wuninitialized
13471 does not deduce are never used uninitialized.
a586633d
PE
13472 * window.h (check_all_windows): New decl, to forestall
13473 gcc -Wmissing-prototypes diagnostic.
5b555da1 13474 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13475
f6095868
PE
13476 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13477 shadowing.
13478 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13479 Include <limits.h>.
13480 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13481 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13482 (load_charset_map): Mark variables that gcc -Wuninitialized
13483 does not deduce are never used uninitialized.
53df7c11 13484 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13485
f38b440c
PE
13486 * coding.c (coding_set_source, coding_set_destination):
13487 Use "else { /* comment */ }" rather than "else /* comment */;"
13488 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13489 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13490 a block, when the outer 'i' will do.
13491 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13492 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13493 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13494 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13495 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13496 Rename locals to avoid shadowing.
13497 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13498 * coding.c (emacs_mule_char, encode_invocation_designation):
13499 Now static, since they're not used elsewhere.
413bb2db 13500 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13501 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13502 (decode_coding_emacs_mule): Mark variables that gcc
13503 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13504 (detect_coding_iso_2022): Initialize a local variable that might
13505 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13506 this initialization is needed. (Bug#8211)
5f58e762
PE
13507 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13508 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13509 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13510 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13511 Remove unused macros.
f38b440c 13512
232b38b9 13513 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13514 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13515 * character.c (string_count_byte8): Likewise.
232b38b9 13516
fb90da1b
PE
13517 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13518 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13519
fb93dbc2
PE
13520 * chartab.c (copy_sub_char_table): Now static, since it's not used
13521 elsewhere.
5c156ace
PE
13522 (sub_char_table_ref_and_range, char_table_ref_and_range):
13523 Rename locals to avoid shadowing.
bbcd0949 13524 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13525
7d3b3862 13526 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13527 (BIDI_BOB): Remove unused macro.
7d3b3862 13528
6be7d3da
PE
13529 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13530 deduce are never used uninitialized.
c2ed9c8b 13531 * term.c (encode_terminal_code): Likewise.
6be7d3da 13532
75f8807f 13533 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13534
50938595
PE
13535 * tparam.h: New file.
13536 * term.c, tparam.h: Include it.
13537 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13538 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13539 Move these decls to tparam.h, and make them agree with what
13540 is actually in tparam.c. The previous trick of using incompatible
13541 decls in different modules does not conform to the C standard.
13542 All callers of tparam changed to use tparam's actual API.
13543 * tparam.c (tparam1, tparam, tgoto):
13544 Use const pointers where appropriate.
13545
fbceeba2
PE
13546 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13547 * cm.h (struct cm): Likewise.
13548 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13549 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13550 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13551 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13552 (turn_on_face, init_tty): Likewise.
13553 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13554
7f3f1250
PE
13555 * term.c (term_mouse_position): Rename local to avoid shadowing.
13556
e6ca6543
PE
13557 * alloc.c (mark_ttys): Move decl from here ...
13558 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13559
c40f8d15
AS
135602011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13561
13562 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13563
cfe0661d
JB
135642011-03-09 Juanma Barranquero <lekktu@gmail.com>
13565
13566 * search.c (compile_pattern_1): Remove argument regp, unused since
13567 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13568 (compile_pattern): Don't pass it.
13569
0afb4571
J
135702011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13571
13572 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13573 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13574 for ! HAVE_GTK3.
13575 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13576
13577 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13578
13579 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13580 gdk_window_get_screen, gdk_window_get_geometry,
13581 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13582 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13583 (xg_get_pixbuf_from_pixmap): New function.
13584 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13585 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13586 Call xg_get_pixbuf_from_pixmap instead of
13587 gdk_pixbuf_get_from_drawable.
13588 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13589 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13590 (xg_check_special_colors): Use GtkStyleContext and its functions
13591 for HAVE_GTK3.
13592 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13593 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13594 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13595 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13596 Call gtk_widget_get_preferred_size.
0afb4571
J
13597 (xg_frame_resized): gdk_window_get_geometry only takes 5
13598 parameters.
44f230aa
SM
13599 (xg_win_to_widget, xg_event_is_for_menubar):
13600 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13601 (xg_set_widget_bg): New function.
13602 (delete_cb): New function.
895009e1 13603 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13604 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13605 (xg_set_background_color): Call xg_set_widget_bg.
13606 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13607 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13608 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13609 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13610 if ! HAVE_GTK3.
13611 (update_frame_tool_bar): Call gtk_widget_hide.
13612 (xg_initialize): Use GDK_KEY_g.
13613
13614 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13615 if ! HAVE_GTK3
13616 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13617
13618 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13619 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13620 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13621
1c2cc4ef
JB
136222011-03-08 Juanma Barranquero <lekktu@gmail.com>
13623
13624 * w32xfns.c (select_palette): Check success of RealizePalette against
13625 GDI_ERROR, not zero.
13626
33383987 13627See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13628
13629;; Local Variables:
13630;; coding: utf-8
aac0c6e3
MR
13631;; End:
13632
2f097256 13633 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13634
13635 This file is part of GNU Emacs.
13636
13637 GNU Emacs is free software: you can redistribute it and/or modify
13638 it under the terms of the GNU General Public License as published by
13639 the Free Software Foundation, either version 3 of the License, or
13640 (at your option) any later version.
13641
13642 GNU Emacs is distributed in the hope that it will be useful,
13643 but WITHOUT ANY WARRANTY; without even the implied warranty of
13644 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13645 GNU General Public License for more details.
13646
13647 You should have received a copy of the GNU General Public License
13648 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.