Don't force ./temacs to start in terminal mode.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4fcc2638
DN
12011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2
3 Don't force ./temacs to start in terminal mode.
4
5 * frame.c (make_initial_frame): Initialize faces in all cases, not
6 only when CANNOT_DUMP is defined.
7 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8
c56e0fd5
DN
92011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10
11 * dispnew.c (add_window_display_history): Use const for the string
12 pointer. Remove declaration, not needed.
13
333d54da 142011-05-31 Paul Eggert <eggert@cs.ucla.edu>
55d4c1b2
PE
15
16 Use 'inline', not 'INLINE'.
333d54da 17 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
18 * alloc.c, fontset.c (INLINE): Remove.
19 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
20 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
21 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
22 * gmalloc.c (register_heapinfo): Use inline unconditionally.
23 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
24
738db178
DN
252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
26
27 Make it possible to run ./temacs.
28
29 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
30 syms_of_callproc does the same thing. Remove test for
31 "initialized", do it in the caller.
32 * emacs.c (main): Avoid calling set_initial_environment when dumping.
33
620c53a6
SM
342011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
35
36 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
37 (read_minibuf): Use get_minibuffer.
38 (syms_of_minibuf): Use DEFSYM.
39 (Qmetadata): New var.
40 * data.c (Qbuffer): Don't make it static.
41 (syms_of_data): Use DEFSYM.
42
e003a292
PE
432011-05-31 Paul Eggert <eggert@cs.ucla.edu>
44
45 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
46 (CCL_CODE_MIN): New macro.
47
ed008a6d
PE
482011-05-30 Paul Eggert <eggert@cs.ucla.edu>
49
3687c2ef
PE
50 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
51
ed008a6d
PE
52 * eval.c (Qdebug): Now static.
53 * lisp.h (Qdebug): Remove decl. This reverts a part of the
54 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
55 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
56
d66c4c7c
CY
572011-05-29 Chong Yidong <cyd@stupidchicken.com>
58
59 * image.c: Various fixes to ImageMagick code comments.
60 (Fimagemagick_types): Doc fix.
61
5fbc2025
PE
622011-05-29 Paul Eggert <eggert@cs.ucla.edu>
63
0196f88a
PE
64 Minor fixes prompted by GCC 4.6.0 warnings.
65
66 * xselect.c (converted_selections, conversion_fail_tag): Now static.
67
5fbc2025
PE
68 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
69 (x_clipboard_manager_save_all): Move extern decl to ...
70 * xterm.h: ... here, so that it can be checked for consistency.
71
1dd3c2d9
CY
722011-05-29 Chong Yidong <cyd@stupidchicken.com>
73
74 * xselect.c (x_clipboard_manager_save_frame)
75 (x_clipboard_manager_save_all): New functions.
76 (Fx_clipboard_manager_save): Lisp function deleted.
77
78 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
79 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
80
81 * xterm.h: Update prototype.
82
5ba6571d
WX
832011-05-28 William Xu <william.xwl@gmail.com>
84
85 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
86 exiting (Bug#8239).
87
3eaff834
JM
882011-05-28 Jim Meyering <meyering@redhat.com>
89
e1900994 90 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
91 * fns.c (to_uchar): Define.
92 (crypto_hash_function): Use it to convert some newly-signed
93 variables to unsigned, to avoid sign-extension bugs. For example,
94 without this change, (md5 "truc") would evaluate to
95 45723a2aff78ff4fff7fff1114760e62 rather than the expected
96 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 97 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 98
0f6990a7
PE
992011-05-27 Paul Eggert <eggert@cs.ucla.edu>
100
101 Integer overflow fixes.
c8a9ca5a 102
08686060
PE
103 * dbusbind.c: Serial number integer overflow fixes.
104 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
105 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
106 to hold a serial number that is too large for a fixnum.
107 (Fdbus_method_return_internal, Fdbus_method_error_internal):
108 Check for serial numbers out of range. Decode any serial number
59568bf0 109 that was so large that it became a float. (Bug#8722)
08686060 110
2d1fc3c7
PE
111 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
112 (Fdbus_call_method, Fdbus_call_method_asynchronously):
113 Use XFASTINT rather than XUINT when numbers are nonnegative.
114 (xd_append_arg, Fdbus_method_return_internal):
115 (Fdbus_method_error_internal): Likewise. Also, for unsigned
116 arguments, check that Lisp number is nonnegative, rather than
59568bf0 117 silently wrapping negative numbers around. (Bug#8722)
30217ff0 118 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 119 (Bug#8722)
2d1fc3c7 120
c8a9ca5a
PE
121 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
122
519e1d69
PE
123 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
124
30569699
PE
125 ccl: add integer overflow checks
126 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
127 (IN_INT_RANGE): New macros.
128 (ccl_driver): Use them to check for integer overflow when
129 decoding a CCL program. Many of the new checks are whether XINT (x)
130 fits in int; it doesn't always, on 64-bit hosts. The new version
131 doesn't catch all possible integer overflows, but it's an
847044ea 132 improvement. (Bug#8719)
30569699 133
c11285dc
PE
134 * alloc.c (make_event_array): Use XINT, not XUINT.
135 There's no need for unsigned here.
136
fdccd48e
PE
137 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
138 This follows up to the 2011-05-06 change that substituted uintptr_t
139 for EMACS_INT. This case wasn't caught back then.
140
37910ab2
PE
141 Rework Fformat to avoid integer overflow issues.
142 * editfns.c: Include <float.h> unconditionally, as it's everywhere
143 now (part of C89). Include <verify.h>.
144 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
145 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
146 (Fformat): Avoid the prepass trying to compute sizes; it was only
147 approximate and thus did not catch overflow reliably. Instead, walk
148 through the format just once, formatting and computing sizes as we go,
149 checking for integer overflow at every step, and allocating a larger
150 buffer as needed. Keep track separately whether the format is
151 multibyte. Keep only the most-recently calculated precision, rather
152 than them all. Record whether each argument has been converted to
153 string. Use EMACS_INT, not int, for byte and char and arg counts.
154 Support field widths and precisions larger than INT_MAX. Avoid
155 sprintf's undefined behavior with conversion specifications such as %#d
156 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
157 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
158 formatting out-of-range floating point numbers with int
159 formats. (Bug#8668)
160
2e6578fb
PE
161 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
162
0ae6bdee
PE
163 * data.c: Avoid integer truncation in expressions involving floats.
164 * data.c: Include <intprops.h>.
165 (arith_driver): When there's an integer overflow in an expression
166 involving floating point, convert the integers to floating point
167 so that the resulting value does not suffer from catastrophic
168 integer truncation. For example, on a 64-bit host (* 4
169 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
170 Do not rely on undefined behavior after integer overflow.
171
de883a70
PE
172 merge count_size_as_multibyte, parse_str_to_multibyte
173 * character.c, character.h (count_size_as_multibyte):
174 Renamed from parse_str_to_multibyte; all uses changed.
175 Check for integer overflow.
176 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
177 since it's now a duplicate of the other. This is more of
178 a character than a buffer op, so better that it's in character.c.
179 * fns.c, print.c: Adjust to above changes.
180
2ff916cb
PE
1812011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
182
183 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
184
f1b54466
PE
1852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
186
fb1ac845
PE
187 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
188 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
189 (x_clipboard_manager_save): Now static.
190 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
191
f1b54466
PE
192 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
193 (crypto_hash_function): Now static.
194 Fix pointer signedness problems. Avoid unnecessary initializations.
195
a9f737ee
CY
1962011-05-27 Chong Yidong <cyd@stupidchicken.com>
197
198 * termhooks.h (Vselection_alist): Make it terminal-local.
199
200 * terminal.c (create_terminal): Initialize it.
201
202 * xselect.c: Support for clipboard managers.
203 (Vselection_alist): Move to termhooks.h as terminal-local var.
204 (LOCAL_SELECTION): New macro.
205 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
206 (symbol_to_x_atom): Remove gratuitous arg.
207 (x_handle_selection_request, lisp_data_to_selection_data)
208 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
209 (x_own_selection, x_get_local_selection, x_convert_selection):
210 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
211 (some_frame_on_display): Delete unused function.
212 (Fx_own_selection_internal, Fx_get_selection_internal)
213 (Fx_disown_selection_internal, Fx_selection_owner_p)
214 (Fx_selection_exists_p): New optional frame arg.
215 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
216 (x_handle_selection_clear): Don't treat other terminals with the
217 same keyboard specially. Use the terminal-local Vselection_alist.
218 (x_clear_frame_selections): Use Frun_hook_with_args.
219
220 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
221
222 * xterm.h: Add support for those atoms.
223
e067f0c1
CY
2242011-05-26 Chong Yidong <cyd@stupidchicken.com>
225
226 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
227 (converted_selections, conversion_fail_tag): New global variables.
228 (x_selection_request_lisp_error): Free the above.
229 (x_get_local_selection): Remove unnecessary code.
230 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
231 of converted selections stored in converted_selections.
232 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
233 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
234 (x_convert_selection): New function.
235 (x_handle_selection_event): Simplify.
236 (x_get_foreign_selection): Don't ignore incoming requests while
237 waiting for an answer; this will fail when we implement
238 SAVE_TARGETS, and seems unnecessary anyway.
239 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
240 (Vx_sent_selection_functions): Doc fix.
241
0f4aebc0
LL
2422011-05-26 Leo Liu <sdl.web@gmail.com>
243
244 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
245
e61124cd
YM
2462011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
247
248 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
249
250 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
251 for fringe update if it has periodic bitmap.
252 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
253 and fringe_bitmap_periodic_p.
254
255 * fringe.c (get_fringe_bitmap_data): New function.
256 (draw_fringe_bitmap_1, update_window_fringes): Use it.
257 (update_window_fringes): Record periodicity of fringe bitmap in glyph
258 row. Mark glyph row for fringe update if periodicity changed.
259
260 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
261 for fringe update unless it has periodic bitmap.
262
f16d9837
KH
2632011-05-25 Kenichi Handa <handa@m17n.org>
264
265 * xdisp.c (get_next_display_element): Set correct it->face_id for
266 a static composition.
267
e1b90ef6
LL
2682011-05-24 Leo Liu <sdl.web@gmail.com>
269
270 * deps.mk (fns.o):
271 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
272
273 * fns.c (crypto_hash_function, Fsha1): New function.
274 (Fmd5): Use crypto_hash_function.
275 (syms_of_fns): Add Ssha1.
276
7400048f
PE
2772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
278
279 * gnutls.c: Remove unused macros.
280 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
281 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
282 Remove macros that are defined and never used.
283 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
284
abb71cf4
CY
2852011-05-22 Chong Yidong <cyd@stupidchicken.com>
286
287 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
288 (Fx_get_selection_internal): Minor cleanup.
289 (Fx_own_selection_internal): Rename arguments for consistency with
290 select.el.
291
6307db39
PE
2922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
293
294 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
295
f3d4e0a4
CY
2962011-05-22 Chong Yidong <cyd@stupidchicken.com>
297
298 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
299
4d8ade89
YM
3002011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
301
302 * dispnew.c (scrolling_window): Don't exclude the case that the
303 last enabled row in the desired matrix touches the bottom boundary.
304
32078c8d
GM
3052011-05-21 Glenn Morris <rgm@gnu.org>
306
307 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
308 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
309 and add some more files.
32078c8d 310
7285dc67
EZ
3112011-05-20 Eli Zaretskii <eliz@gnu.org>
312
313 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
314 report_file_error introduced by the change from 2011-05-07.
315
89d1bd22
PE
3162011-05-20 Paul Eggert <eggert@cs.ucla.edu>
317
318 * systime.h (Time): Define only if emacs is defined.
319 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
320 where the include path doesn't have X11/X.h by default. See
321 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
322
e23640bb 3232011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
324
325 * composite.c (find_automatic_composition): Fix previous change.
326
b9704ad9
GM
3272011-05-20 Glenn Morris <rgm@gnu.org>
328
329 * lisp.mk: New file, split from Makefile.in.
330 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
331 (shortlisp): Remove.
332 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
333
4a720484
GM
3342011-05-19 Glenn Morris <rgm@gnu.org>
335
336 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
337 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
338 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
339 (lisp): Set the order to that of loadup.el.
340 (shortlisp): Make it a copy of $lisp.
341 (SOME_MACHINE_LISP): Remove.
342 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
343 Use just $shortlisp, not $SOME_MACHINE_LISP too.
344
a28d4396
KH
3452011-05-18 Kenichi Handa <handa@m17n.org>
346
347 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
348 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
349 (find_automatic_composition): Mostly rewrite for efficiency.
350
a2b1fa8e
JB
3512011-05-18 Juanma Barranquero <lekktu@gmail.com>
352
353 * makefile.w32-in: Update dependencies.
354
8e1f5610
CS
3552011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
356
357 * menu.c: Include limits.h (fixes the MS-Windows build broken by
358 revision 104625).
359
7025ee00 3602011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 361
cdfa6eab
PE
362 Fix some integer overflow issues, such as string length overflow.
363
06d6db33
PE
364 * insdel.c (count_size_as_multibyte): Check for string overflow.
365
2b4560a8
PE
366 * character.c (lisp_string_width): Check for string overflow.
367 Use EMACS_INT, not int, for string indexes and lengths; in
368 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
369 the resulting string length overflows an EMACS_INT; instead,
370 report a string overflow if no precision given. When checking for
371 precision exhaustion, use a check that cannot possibly have
372 integer overflow. (Bug#8675)
373 * character.h (lisp_string_width): Adjust to new signature.
374
cb93f9be
PE
375 * alloc.c (string_overflow): New function.
376 (Fmake_string): Use it. This doesn't change behavior, but saves
377 a few bytes and will simplify future changes.
378 * character.c (string_escape_byte8): Likewise.
379 * lisp.h (string_overflow): New decl.
380
1a1f3366
PE
381 Fixups, following up to the user-interface timestamp change.
382 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
383 for UI timestamps, instead of unsigned long.
9fbd6841
PE
384 * msdos.c (mouse_get_pos): Likewise.
385 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
386 * w32gui.h (Time): Define by including "systime.h" rather than by
387 declaring it ourselves. (Bug#8664)
388
d4e3e4d3
PE
389 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
390 * image.c (clear_image_cache): Likewise.
391
f6a24d19
PE
392 * term.c (term_mouse_position): Don't assume time_t wraparound.
393
08dc5ae6
PE
394 Be more systematic about user-interface timestamps.
395 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
396 and sometimes 'EMACS_UINT', to represent these timestamps.
397 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
398 This makes the code easier to follow, and makes it easier to catch
399 integer overflow bugs such as Bug#8664.
400 * frame.c (Fmouse_position, Fmouse_pixel_position):
401 Use Time, not unsigned long, for user-interface timestamps.
402 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
403 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
404 * keyboard.h (last_event_timestamp): Likewise.
405 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
406 * menu.h (xmenu_show): Likewise.
407 * term.c (term_mouse_position): Likewise.
408 * termhooks.h (struct input_event.timestamp): Likewise.
409 (struct terminal.mouse_position_hook): Likewise.
410 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
411 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
412 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
413 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
414 what it was before.
415 * menu.h, termhooks.h: Include "systime.h", for Time.
416
8e55734a
PE
417 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
418 Don't assume that the difference between two unsigned long values
419 can fit into an integer. At this point, we know button_down_time
420 <= event->timestamp, so the difference must be nonnegative, so
421 there's no need to cast the result if double-click-time is
422 nonnegative, as it should be; check that it's nonnegative, just in
423 case. This bug is triggered when events are more than 2**31 ms
86db42d2 424 apart (about 25 days). (Bug#8664)
8e55734a 425
841f1b75 426 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 427 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 428
3e26f69c
PE
429 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
430 that always fit in int. Use a sentinel instead of a counter, to
431 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
432 * frame.h (struct frame): Use int for menu_bar_items_used
433 instead of EMACS_INT, since it always fits in int.
3e26f69c 434
5cc152c0
PE
435 * menu.c (grow_menu_items): Check for int overflow.
436
d89eb65e
PE
437 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
438
5235bd3e
PE
439 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
440 Before, the code was not consistent. These values cannot exceed
441 2**31 - 1 so there's no need to make them unsigned.
442 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
443 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
444 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
445 as modifiers.
446 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
447
bc827e23
PE
448 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
449 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
450 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
451 presumably because the widths might not match.
452
78eb494e
PE
453 * window.c (size_window): Avoid needless test at loop start.
454
04f2d78b
CB
4552011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
456
457 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
458
d2fc7e3d 4592011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
460
461 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
462
d2fc7e3d 4632011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
464
465 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
466 `width' to `bar_area_x' and `bar_area_width', respectively.
467 (x_scroll_run): Take account of fringe background extension.
468
04f2d78b
CB
469 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
470 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
471 `bar_area_width', respectively.
472 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
473 background extension.
474
79b70037
GM
4752011-05-10 Jim Meyering <meyering@redhat.com>
476
477 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
478
2f142cc5
JB
4792011-05-10 Juanma Barranquero <lekktu@gmail.com>
480
481 * image.c (Finit_image_library): Return t for built-in image types,
482 like pbm and xbm. (Bug#8640)
483
57679c86
AS
4842011-05-09 Andreas Schwab <schwab@linux-m68k.org>
485
486 * w32menu.c (set_frame_menubar): Fix submenu allocation.
487
888c9e86
EZ
4882011-05-07 Eli Zaretskii <eliz@gnu.org>
489
b0512a1d
EZ
490 * w32console.c (Fset_screen_color): Doc fix.
491 (Fget_screen_color): New function.
492 (syms_of_ntterm): Defsubr it.
493
7285dc67
EZ
494 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
495 unlink the temporary file if Fcall_process didn't create it in the
496 first place.
497 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
498 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
499 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
500 cue to call_process_cleanup not to close that handle.
501
4d3fcc8e
BK
5022011-05-07 Ben Key <bkey76@gmail.com>
503
504 * makefile.w32-in: The bootstrap-temacs rule now makes use of
505 one of two shell specific rules, either bootstrap-temacs-CMD or
506 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
507 to the previous implementation of the bootstrap-temacs rule.
508 The bootstrap-temacs-CMD rule is similar to the previous
509 implementation of the bootstrap-temacs rule except that it
510 makes use of the ESC_CFLAGS variable instead of the CFLAGS
511 variable.
512
513 These changes, along with some changes to nt/configure.bat,
514 nt/gmake.defs, and nt/nmake.defs, are required to extend my
515 earlier fix to add support for --cflags and --ldflags options
516 that include quotes so that it works whether make uses cmd or
517 sh as the shell.
518
b4289b64
MA
5192011-05-06 Michael Albinus <michael.albinus@gmx.de>
520
521 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
522 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
523 is a constant.
524 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
525 a string. Handle both cases.
526 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
527 (Fdbus_register_method): Use Qinvalid_function.
528
af4c0e28
JB
5292011-05-06 Juanma Barranquero <lekktu@gmail.com>
530
531 * makefile.w32-in: Update dependencies.
532 (LISP_H): Add inttypes.h and stdin.h.
533 (PROCESS_H): Add unistd.h.
534
c51453d9
EZ
5352011-05-06 Eli Zaretskii <eliz@gnu.org>
536
537 * lread.c: Include limits.h (fixes the MS-Windows build broken by
538 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
539
8ff0ac3c 5402011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 541
4c4b566b
PE
542 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
543
aab2b9b5
PE
544 * term.c (vfatal): Remove stray call to va_end.
545 It's not needed and the C Standard doesn't allow it here anyway.
546
c378da0b
PE
547 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
548 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
549
288b08c7
PE
550 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
551 bytes.
552
e3601888
PE
553 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
554
db6c0e74
PE
555 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
556
dd5963ea
PE
557 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
558
88c9450f
PE
559 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
560
2f9442b8
PE
561 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
562
c032b5f8
PE
563 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
564 * charset.c (Fdefine_charset_internal): Don't initialize
565 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 566 32-bit int (Bug#8600).
a108c10b
PE
567
568 * lread.c (read_integer): Be more consistent with string-to-number.
569 Use string_to_number to do the actual conversion; this avoids
570 rounding errors and fixes some other screwups. Without this fix,
571 for example, #x1fffffffffffffff was misread as -2305843009213693952.
572 (digit_to_number): Move earlier, for benefit of read_integer.
573 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 574 not a digit in any supported base. (Bug#8602)
a108c10b 575
ad5f9eea
PE
576 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
577
aec1708a
PE
578 * dispnew.c (scrolling_window): Return 1 if we scrolled,
579 to match comment at start of function. This also removes a
580 GCC warning about overflow in a 32+64-bit port.
581
47be4ab5
PE
582 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
583
371cac43
PE
584 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
585 Reported by Stefan Monnier in
586 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
587 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
588 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 589
d01a7826
PE
590 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
591 (EMACS_UINTPTR): Likewise, with uintptr_t.
592
7fd47d5c
PE
593 * lisp.h: Prefer 64-bit EMACS_INT if available.
594 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
595 on 32-bit hosts that have 64-bit int, so that they can access
596 large files.
122b0c86
PE
597 However, temporarily disable this change unless the temporary
598 symbol WIDE_EMACS_INT is defined.
7fd47d5c 599
8727937b
PE
600 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
601
8ac068ac
PE
602 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
603 This removes an assumption that EMACS_INT and long are the same
604 width as pointers. The assumption is true for Emacs porting targets
605 now, but we want to make other targets possible.
606 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
607 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
608 In the rest of the code, change types of integers that hold casted
609 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
610 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
611 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
612 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
613 No need to cast type when ORing.
614 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
615 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
616 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
617 assume EMACS_INT is the same width as char *.
618 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
619 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
620 Remove no-longer-needed casts.
621 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
622 (xg_tool_bar_help_callback, xg_make_tool_item):
623 Use EMACS_INTPTR to hold an integer
624 that will be cast to void *; this can avoid a GCC warning
625 if EMACS_INT is not the same width as void *.
626 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
627 * xdisp.c (display_echo_area_1, resize_mini_window_1):
628 (current_message_1, set_message_1):
629 Use a local to convert to proper width without a cast.
630 * xmenu.c (dialog_selection_callback): Likewise.
631
ede49d71
PE
632 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
633 Also, don't assume VALBITS / RAND_BITS is less than 5,
634 and don't rely on undefined behavior when shifting a 1 left into
635 the sign bit.
636 * lisp.h (get_random): Change signature to match.
637
2f30ecd0
PE
638 * lread.c (hash_string): Use size_t, not int, for hash computation.
639 Normally we prefer signed values; but hashing is special, because
640 it's better to use unsigned division on hash table sizes so that
641 the remainder is nonnegative. Also, size_t is the natural width
642 for hashing into memory. The previous code used 'int', which doesn't
643 retain enough info to hash well into very large tables.
644 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
645
2a866e7b
PE
646 * dbusbind.c: Don't possibly lose pointer info when converting.
647 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
648 Use XPNTR rather than XHASH, so that the high-order bits of
649 the pointer aren't lost when converting through void *.
650
51639eac
PE
651 * eval.c (Fautoload): Don't double-shift a pointer.
652
92394119
PE
653 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
654
dbdb9a7c
JB
6552011-05-06 Juanma Barranquero <lekktu@gmail.com>
656
657 * gnutls.c (DEF_GNUTLS_FN):
658 * image.c (DEF_IMGLIB_FN): Make function pointers static.
659
db7a0b4f
AS
6602011-05-05 Andreas Schwab <schwab@linux-m68k.org>
661
662 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
663 marker. (Bug#8610)
664
f7ff1b0f 6652011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
666
667 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
668 New version that can reserve upto 2GB of heap space.
669
f7ff1b0f 6702011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
671
672 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
673
639c109b
TZ
6742011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
675
676 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
677 `gnutls_certificate_set_x509_key_file'.
678
d2127135
JB
6792011-05-05 Juanma Barranquero <lekktu@gmail.com>
680
681 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
682 Update dependencies.
683
e968f4f3
JB
6842011-05-04 Juanma Barranquero <lekktu@gmail.com>
685
686 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
687 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
688 Remove unused parameter `fildes'.
689 * process.c (read_process_output, send_process): Don't pass it.
690
84d358f0
JB
6912011-05-04 Juanma Barranquero <lekktu@gmail.com>
692
693 Fix previous change: the library cache is defined in w32.c.
694 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
695 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
696
0898ca10
JB
6972011-05-04 Juanma Barranquero <lekktu@gmail.com>
698
699 Implement dynamic loading of GnuTLS on Windows.
700
701 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
702 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
703 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
704 Declare.
705
706 * gnutls.c (Qgnutls_dll): Define.
707 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
708 (gnutls_*): Declare function pointers.
709 (init_gnutls_functions): New function to initialize function pointers.
710 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
711 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
712 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
713 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
714 (emacs_gnutls_write, emacs_gnutls_read)
715 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
716 (Fgnutls_available_p): New function.
717 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
718 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
719 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
720
721 * image.c: Include w32.h.
722 (Vimage_type_cache): Delete.
723 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
724 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
725 (w32_delayed_load): Move to w32.c.
726
727 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
728
729 * w32.c (QCloaded_from, Vlibrary_cache): Define.
730 (w32_delayed_load): Move from image.c. When loading a library, record
731 its filename in the :loaded-from property of the library id.
732 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
733 Initialize and staticpro them.
734 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
735
736 * process.c: Include lisp.h before w32.h, not after.
737 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
738 instead of gnutls_record_check_pending.
739
740 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
741
ff4de4aa
TZ
7422011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
743
744 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
745 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
746 as passed in.
747
abe95abb
JD
7482011-05-03 Jan Djärv <jan.h.d@swipnet.se>
749
750 * xterm.c (x_set_frame_alpha): Do not set property on anything
751 else than FRAME_X_OUTER_WINDOW (Bug#8608).
752
e16e55d4
JB
7532011-05-02 Juanma Barranquero <lekktu@gmail.com>
754
755 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
756
bafcf6a5
JB
7572011-05-02 Juanma Barranquero <lekktu@gmail.com>
758
759 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
760 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
761 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
762 (gnutls_global_initialized, Qgnutls_bootprop_priority)
763 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
764 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
765 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
766 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
767 (Qgnutls_bootprop_callbacks_verify): Make static.
768
e7a6747f
AS
7692011-05-01 Andreas Schwab <schwab@linux-m68k.org>
770
19ed11ba
AS
771 * callproc.c: Indentation fixup.
772
e7a6747f 773 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
774 (wait_for_termination, interruptible_wait_for_termination):
775 Move after wait_for_termination_1.
e7a6747f 776
1ef14cb4
LMI
7772011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
778
779 * sysdep.c (interruptible_wait_for_termination): New function
780 which is like wait_for_termination, but allows keyboard
781 interruptions.
782
783 * callproc.c (Fcall_process): Add (:file "file") as an option for
784 the STDOUT buffer.
785 (Fcall_process_region): Ditto.
786
330d880c
EZ
7872011-04-30 Eli Zaretskii <eliz@gnu.org>
788
8db90b73
EZ
789 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
790 rather than `XVECTOR (FOO)->size'.
791
330d880c
EZ
792 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
793 inttypes.h, as a gnulib replacement is used if it not available in
794 system headers.
795
15cbd324
EZ
7962011-04-21 Eli Zaretskii <eliz@gnu.org>
797
798 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
799 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
800 of MOST_POSITIVE_FIXNUM. (Bug#8528)
801
802 * coding.c (coding_alloc_by_realloc): Error out if destination
803 will grow beyond MOST_POSITIVE_FIXNUM.
804 (decode_coding_emacs_mule): Abort if there isn't enough place in
805 charbuf for the composition carryover bytes. Reserve an extra
806 space for up to 2 characters produced in a loop.
807 (decode_coding_iso_2022): Abort if there isn't enough place in
808 charbuf for the composition carryover bytes.
809
8102011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 811
ae940cca
EZ
812 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
813 aborting when %lld or %lll format is passed.
814 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
815 %llo or %llx format is passed. (Bug#8545)
816
03ab8921
EZ
817 * window.c (window_scroll_line_based): Use a marker instead of
818 simple variables to record original value of point. (Bug#7952)
819
afda1437
EZ
820 * doprnt.c (doprnt): Fix the case where a multibyte sequence
821 produced by %s or %c overflows available buffer space. (Bug#8545)
822
f76dee0c
PE
8232011-04-28 Paul Eggert <eggert@cs.ucla.edu>
824
825 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 826 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 827
fdc5744d
JB
8282011-04-28 Juanma Barranquero <lekktu@gmail.com>
829
830 * w32.c (init_environment): Warn about defaulting HOME to C:\.
831
638f053a
JB
8322011-04-28 Juanma Barranquero <lekktu@gmail.com>
833
834 * keyboard.c (Qdelayed_warnings_hook): Define.
835 (command_loop_1): Run `delayed-warnings-hook'
836 if Vdelayed_warnings_list is non-nil.
837 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
838 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
839
d178f871
EZ
8402011-04-28 Eli Zaretskii <eliz@gnu.org>
841
842 * doprnt.c (doprnt): Don't return value smaller than the buffer
843 size if the message was truncated. (Bug#8545).
844
b124fd93
JB
8452011-04-28 Juanma Barranquero <lekktu@gmail.com>
846
847 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
848 (Fx_window_property): #if-0 the whole functions, not just the bodies.
849
e810457d
PE
8502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
851
852 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
853
ea51cceb
JB
8542011-04-27 Juanma Barranquero <lekktu@gmail.com>
855
856 * makefile.w32-in: Update dependencies.
857
94dcfacf
EZ
8582011-04-27 Eli Zaretskii <eliz@gnu.org>
859
860 Improve `doprnt' and its usage. (Bug#8545)
861 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
862 `format_end'. Remove support for %l as a conversion specifier.
863 Don't use xrealloc. Improve diagnostics when the %l size modifier
864 is used. Update the commentary.
865
866 * eval.c (verror): Simplify calculation of size_t.
867
868 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
869 messages.
870
f61f41d7
PE
8712011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
872
873 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
874 change.
875
96fb4434
PE
8762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
877
878 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
879 This makes this file independent of the recent pseudovector change.
880
671875da 8812011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 882
69e9b5a3
PE
883 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
884
b5f869a7 885 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 886 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 887 Remove unused local.
c8926152 888 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 889
841a1577 890 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
891 GCC 4.6.0 optimizes based on type-based alias analysis.
892 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
893 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
894 != &v->size, and therefore "v->size = 1; b->size = 2; return
895 v->size;" must therefore return 1. This assumption is incorrect
896 for Emacs, since it type-puns struct Lisp_Vector * with many other
897 types. To fix this problem, this patch adds a new type struct
f904488f 898 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
899 and pseudovectors, and helps optimizing compilers not get fooled
900 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
901 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
902 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
903 the size member.
eab3844f
PE
904 (XSETPVECTYPE): Rewrite in terms of new macro.
905 (XSETPVECTYPESIZE): New macro, specifying both type and size.
906 This is a bit clearer, and further avoids the possibility of
907 undesirable aliasing.
908 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 909 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
910 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
911 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
912 (ASIZE): Now uses header.size rather than size.
913 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
914 to avoid the hassle of writing XVECTOR (foo)->header.size.
915 (struct vectorlike_header): New type.
eab3844f
PE
916 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
917 object, to help avoid aliasing.
918 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
919 (SUBRP): Likewise, since Lisp_Subr is a special case.
920 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
921 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
922 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 923 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
924 changed to be "header.size" and "header.next".
925 * buffer.h (struct buffer): Likewise.
926 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
927 * frame.h (struct frame): Likewise.
928 * process.h (struct Lisp_Process): Likewise.
929 * termhooks.h (struct terminal): Likewise.
930 * window.c (struct save_window_data, struct saved_window): Likewise.
931 * window.h (struct window): Likewise.
932 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
933 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
934 * buffer.c (init_buffer_once): Likewise.
935 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
936 special case.
937 * process.c (Fformat_network_address): Use local var for size,
938 for brevity.
939
0df1eac5
PE
940 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
941
847ab9d1 942 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
943 * data.c (atof): Remove decl; no longer used or needed.
944 (digit_to_number): Move to lread.c.
945 (Fstring_to_number): Use new string_to_number function, to be
946 consistent with how the Lisp reader treats infinities and NaNs.
947 Do not assume that floating-point numbers represent EMACS_INT
948 without losing information; this is not true on most 64-bit hosts.
949 Avoid double-rounding errors, by insisting on integers when
950 parsing non-base-10 numbers, as the documentation specifies.
951 * lisp.h (string_to_number): New decl, replacing ...
952 (isfloat_string): Remove.
bc0a5c13 953 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 954 (read1): Do not accept +. and -. as integers; this
452f4150
PE
955 appears to have been a coding error. Similarly, do not accept
956 strings like +-1e0 as floating point numbers. Do not report
957 overflow for integer overflows unless the base is not 10 which
958 means we have no simple and reliable way to continue.
959 Break out the floating-point parsing into a new
960 function string_to_number, so that Fstring_to_number parses
961 floating point numbers consistently with the Lisp reader.
04f2d78b 962 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
963 (E_CHAR, EXP_INT): Remove, replacing with ...
964 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
965 (string_to_number): New function, replacing isfloat_string.
966 This function checks for valid syntax and produces the resulting
967 Lisp float number too. Rework it so that string-to-number
bc0a5c13 968 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
969 so that overflow for non-base-10 numbers is reported only when
970 there's no portable and simple way to convert to floating point.
452f4150 971
67769ffc
PE
972 * textprop.c (set_text_properties_1): Rewrite for clarity,
973 and to avoid GCC warning about integer overflow.
974
c20db43f
PE
975 * intervals.h (struct interval): Use EMACS_INT for members
976 where EMACS_UINT might cause problems. See
977 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
978 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
979 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
980 All uses changed.
37aa2f85
PE
981 (offset_intervals): Tell GCC not to worry about length overflow
982 when negating a negative length.
c20db43f 983
2538aa2f
PE
984 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
985 (overrun_check_free): Likewise.
986
f2d3008d
PE
987 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
988 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
989 word size.
990
ec8df744
PE
991 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
992 (gnutls_make_error): Rename local to avoid shadowing.
993 (gnutls_emacs_global_deinit): ifdef out; not used.
994 (Fgnutls_boot): Use const for pointer to readonly storage.
995 Comment out unused local. Fix pointer signedness problems.
996
640ee02d
PE
997 * lread.c (openp): Don't stuff size_t into an 'int'.
998 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
999 about possible signed overflow.
1000
6048fb2a
PE
1001 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1002 (GDK_KEY_g): Don't define if already defined.
1003 (xg_prepare_tooltip): Avoid pointer signedness problem.
1004 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1005
fa3c87e1
PE
1006 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1007 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1008
2172544b
PE
1009 * xfns.c (Fx_window_property): Simplify a bit,
1010 to make a bit faster and to avoid GCC 4.6.0 warning.
1011 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1012
9b821a21
PE
1013 * fns.c (internal_equal): Don't assume size_t fits in int.
1014
3c616cfa
PE
1015 * alloc.c (compact_small_strings): Tighten assertion a little.
1016
c2982e87
PE
1017 Replace pEd with more-general pI, and fix some printf arg casts.
1018 * lisp.h (pI): New macro, generalizing old pEd macro to other
1019 conversion specifiers. For example, use "...%"pI"d..." rather
1020 than "...%"pEd"...".
1021 (pEd): Remove. All uses replaced with similar uses of pI.
1022 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1023 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1024 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1025 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1026 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1027 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1028 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1029 64-bit hosts.
1030 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1031 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1032 * print.c (safe_debug_print, print_object): Likewise.
1033 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1034 to int.
6f04d126
PE
1035 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1036 avoiding the 0 flag, which is not portable.
c2982e87
PE
1037 * process.c (Fmake_network_process): Use pI to avoid cast.
1038 * region-cache.c (pp_cache): Likewise.
1039 * xdisp.c (decode_mode_spec): Likewise.
1040 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1041 behavior on 64-bit hosts with printf arg.
6f04d126 1042 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1043 (x_stop_queuing_selection_requests): Likewise.
1044 (x_get_window_property): Don't truncate byte count to an 'int'
1045 when tracing.
0b432f21 1046
5e073ec7
PE
1047 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1048 here, since it parses constructs like leading '-' and spaces,
1049 which are not wanted; and it overflows with large numbers.
1050 Instead, simply match F[0-9]+, which is what is wanted anyway.
1051
36372bf9
PE
1052 * alloc.c: Remove unportable assumptions about struct layout.
1053 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1054 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1055 (allocate_vectorlike, make_pure_vector): Use the new macros,
1056 plus offsetof, to remove unportable assumptions about struct layout.
1057 These assumptions hold on all porting targets that I know of, but
1058 they are not guaranteed, they're easy to remove, and removing them
1059 makes further changes easier.
1060
0b432f21
PE
1061 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1062 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1063 (string_overrun_cookie): Now const. Use initializers that
1064 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1065 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1066 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1067 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1068 multiple of sizeof (EMACS_INT); it need not be, if
1069 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1070 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1071
895009e1
JB
10722011-04-26 Juanma Barranquero <lekktu@gmail.com>
1073
1074 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1075
6a7a1b0b
TZ
10762011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1077
1078 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1079 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1080 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1081
841a1577 10822011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1083
1084 * lisp.h (Qdebug): List symbol.
895009e1 1085 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1086 * keyboard.c (debug-on-event): New variable.
1087 (handle_user_signal): Break into debugger when debug-on-event
1088 matches the current signal symbol.
1089
f2d3ba6f
DN
10902011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1091
1092 * alloc.c (check_sblock, check_string_bytes)
1093 (check_string_free_list): Convert to standard C.
1094
42ce4c63
TZ
10952011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1096
1097 * w32.c (emacs_gnutls_push): Fix typo.
1098
825cd63c
EZ
10992011-04-25 Eli Zaretskii <eliz@gnu.org>
1100
fb11d64d
EZ
1101 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1102 "cast to pointer from integer of different size".
1103
825cd63c
EZ
1104 Improve doprnt and its use in verror. (Bug#8545)
1105 * doprnt.c (doprnt): Document the set of format control sequences
1106 supported by the function. Use SAFE_ALLOCA instead of always
1107 using `alloca'.
1108
1109 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1110 is one byte too soon. Don't use xrealloc; instead xfree and
1111 xmalloc anew.
1112
e061a11b
TZ
11132011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1114
1115 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1116 callbacks stage.
1117
1118 * gnutls.c: Renamed global_initialized to
1119 gnutls_global_initialized. Added internals for the
1120 :verify-hostname-error, :verify-error, and :verify-flags
1121 parameters of `gnutls-boot' and documented those parameters in the
1122 docstring. Start callback support.
1123 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1124 unless a fatal error occured. Call gnutls_alert_send_appropriate
1125 on error. Return error code.
1126 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1127 (emacs_gnutls_read): Likewise.
1128 (Fgnutls_boot): Return handshake error code.
1129 (emacs_gnutls_handle_error): New function.
1130 (wsaerror_to_errno): Likewise.
1131
1132 * w32.h (emacs_gnutls_pull): Add prototype.
1133 (emacs_gnutls_push): Likewise.
1134
1135 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1136 (emacs_gnutls_push): Likewise.
1137
11382011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1139
1140 * process.c (wait_reading_process_output): Check if GnuTLS
1141 buffered some data internally if no FDs are set for TLS
1142 connections.
1143
1144 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1145 (LIBS): Link to USER_LIBS.
1146 ($(BLD)/gnutls.$(0)): New target.
1147
fa6996bc
EZ
11482011-04-24 Eli Zaretskii <eliz@gnu.org>
1149
eb35682e
EZ
1150 * xdisp.c (handle_single_display_spec): Rename the
1151 display_replaced_before_p argument into display_replaced_p, to
1152 make it consistent with the commentary. Fix typos in the
1153 commentary.
1154
e2ad650c
EZ
1155 * textprop.c (syms_of_textprop): Remove dead code.
1156 (copy_text_properties): Delete obsolete commentary about an
1157 interface that was deleted long ago. Fix typos in the description
1158 of arguments.
1159
1b2de274
EZ
1160 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1161 to changes in oldXMenu/XMenu.h from 2011-04-16.
1162 <menu_help_message, prev_menu_help_message>: Constify.
1163 (IT_menu_make_room): menu->help_text is now `const char **';
1164 adjust.
1165
1166 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1167 to changes in oldXMenu/XMenu.h from 2011-04-16.
1168 (struct XMenu): Declare `help_text' `const char **'.
1169
1170 * xfaces.c <Qunspecified>: Make extern again.
1171
1172 * syntax.c: Include sys/types.h before including regex.h, as
1173 required by Posix.
1174
762b15be
EZ
1175 * doc.c (get_doc_string): Improve the format passed to `error'.
1176
1177 * doprnt.c (doprnt): Improve commentary.
1178
1179 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1180
1181 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1182 them with etags.
1183
f1052e5d
EZ
1184 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1185 changes in globals.h immediately force recompilation.
762b15be
EZ
1186 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1187 $(CURDIR)/s/ms-w32.h.
1188 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1189
fa6996bc
EZ
1190 * character.c (Fchar_direction): Function deleted.
1191 (syms_of_character): Don't defsubr it.
1192 <char-direction-table>: Deleted.
1193
e6c3da20
EZ
11942011-04-23 Eli Zaretskii <eliz@gnu.org>
1195
1196 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1197 * doprnt.c: Include limits.h.
1198 (SIZE_MAX): New macro.
04f2d78b
CB
1199 (doprnt): Return a size_t value. 2nd arg is now size_t.
1200 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1201 Improve overflow protection. Support `l' modifier for integer
1202 conversions. Support %l conversion. Don't assume an EMACS_INT
1203 argument for integer conversions and for %c.
1204
1205 * lisp.h (doprnt): Restore prototype.
1206
1207 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1208 $(SRC)/character.h.
1209
1210 * Makefile.in (base_obj): Add back doprnt.o.
1211
1212 * deps.mk (doprnt.o): Add back prerequisites.
1213 (callint.o): Depend on character.h.
1214
1215 * eval.c (internal_lisp_condition_case): Include the handler
1216 representation in the error message.
1217 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1218 when breaking from the loop.
1219
1220 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1221
1222 * callint.c (Fcall_interactively): When displaying error message
1223 about invalid control letter, pass the character's codepoint, not
1224 a pointer to its multibyte form. Improve display of the character
1225 in octal and display also its hex code.
1226
1227 * character.c (char_string): Use %x to display the (unsigned)
1228 codepoint of an invalid character, to avoid displaying a bogus
1229 negative value.
1230
1231 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1232 `error', not SYMBOL_NAME itself.
1233
1234 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1235 character arguments to `error'.
1236
1237 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1238 to `error' in error message about FINAL_CHAR argument. Make sure
1239 FINAL_CHAR is a character, and use %c when it is passed as
1240 argument to `error'.
1241
4ffd0d6b 12422011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1243
1244 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1245
1246 * w32.c: Include <time.h>.
1247 (sys_localtime): New function.
1248
4ffd0d6b 12492011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1250
1251 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1252
4ffd0d6b 1253 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1254
4ffd0d6b 12552011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1256
4ffd0d6b
GM
1257 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1258 zombies (Bug#8467).
aac0c6e3 1259
04c56954
EZ
12602011-04-19 Eli Zaretskii <eliz@gnu.org>
1261
1262 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1263 gl_state.e_property when gl_state.object is Qt.
1264
1265 * insdel.c (make_gap_larger): Remove limitation of buffer size
1266 to <= INT_MAX.
1267
16a43933
CY
12682011-04-18 Chong Yidong <cyd@stupidchicken.com>
1269
1270 * xdisp.c (lookup_glyphless_char_display)
1271 (produce_glyphless_glyph): Handle cons cell entry in
1272 glyphless-char-display.
1273 (Vglyphless_char_display): Document it.
1274
1275 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1276 glyphless-char-display.
1277
4581706e
CY
12782011-04-17 Chong Yidong <cyd@stupidchicken.com>
1279
1280 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1281
1282 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1283
1284 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1285 definition for no-X builds.
1286
4887c6e2 12872011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1288
fd35b6f9
PE
1289 Static checks with GCC 4.6.0 and non-default toolkits.
1290
5c1ccb01
PE
1291 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1292
006c5daa
PE
1293 * process.c (keyboard_bit_set): Define only if SIGIO.
1294 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1295 (send_process): Repair possible setjmp clobbering.
1296
efc736d3
PE
1297 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1298
4e2fe2e6
PE
1299 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1300
f97334a2
PE
1301 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1302
4e75f29d
PE
1303 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1304 Define only if needed.
1305
90efadd1
PE
1306 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1307 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1308 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1309
3c647824
PE
1310 * dispextern.h (struct redisplay_interface): Rename param
1311 to avoid shadowing.
e264f262 1312 * termhooks.h (struct terminal): Likewise.
761383f4 1313 * xterm.c (xembed_send_message): Likewise.
3c647824 1314
b58c5c4a
PE
1315 * insdel.c (make_gap_smaller): Define only if
1316 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1317
cad59032
PE
1318 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1319 it.
1320
c339dc2e
PE
1321 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1322 so that we aren't warned about unused symbols.
1323
91a3e27b
PE
1324 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1325
399c71d3 1326 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1327
8ffc96f5
PE
1328 * xfns.c (x_real_positions): Mark locals as initialized.
1329
eef9bc79
PE
1330 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1331
098db9dd
PE
1332 * xterm.c: Fix problems found by static analysis with other toolkits.
1333 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1334 (x_dispatch_event): Declare static if USE_GTK, and
1335 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1336 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1337 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1338 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1339 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1340
eb18f6cc
PE
1341 * xmenu.c (menu_help_callback): Pointer type fixes.
1342 Use const pointers when pointing at readonly data. Avoid pointer
1343 signedness clashes.
1344 (FALSE): Remove unused macro.
1345 (update_frame_menubar): Remove unused decl.
1346
1fe72bf8
PE
1347 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1348
60d9e1db
PE
1349 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1350 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1351 (single_menu_item): Rename local to avoid shadowing.
1352
39261c26
PE
1353 * keyboard.c (make_lispy_event): Remove unused local var.
1354
018c5e19
PE
1355 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1356 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1357
63d2b86e
PE
1358 * bitmaps: Change bitmaps from unsigned char back to the X11
1359 compatible char. Avoid the old compiler warnings about
1360 out-of-range initializers by using, for example, '\xab' rather
1361 than 0xab.
1362
aefd87e1
PE
1363 * xgselect.c (xgselect_initialize): Check vs interface
1364 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1365
bf501fb9
PE
1366 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1367
e9829fdf
PE
1368 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1369 to read-only memory.
1370
1086c095
PE
1371 * fns.c (vector): Remove; this old hack is no longer needed.
1372
2baccd04 1373 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1374 Remove unused var.
dde42981 1375 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1376
72391843 1377 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1378
436c16df 1379 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1380 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1381 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1382
92bb796d 1383 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1384 (x_term_init): Remove local to avoid shadowing.
92bb796d 1385
764430a3 1386 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1387
1388 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1389 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1390
d1dfb56c
EZ
13912011-04-16 Eli Zaretskii <eliz@gnu.org>
1392
c4354cb4
EZ
1393 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1394
d1dfb56c
EZ
1395 Fix regex.c, syntax.c and friends for buffers > 2GB.
1396 * syntax.h (struct gl_state_s): Declare character position members
1397 EMACS_INT.
1398
1399 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1400
04f2d78b
CB
1401 * textprop.c (verify_interval_modification, interval_of):
1402 Declare arguments EMACS_INT.
d1dfb56c
EZ
1403
1404 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1405 EMACS_INT.
1406
1407 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1408
1409 * indent.c (Fvertical_motion): Local variable it_start is now
1410 EMACS_INT.
1411
1412 * regex.c (re_match, re_match_2, re_match_2_internal)
1413 (bcmp_translate, regcomp, regexec, print_double_string)
1414 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1415 (re_compile_pattern, re_exec): Declare arguments and local
1416 variables `size_t' and `ssize_t' and return values `regoff_t', as
1417 appropriate.
1418 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1419 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1420 <compile_stack_type>: `size' and `avail' are now `size_t'.
1421
1422 * regex.h <regoff_t>: Use ssize_t, not int.
1423 (re_search, re_search_2, re_match, re_match_2): Arguments that
1424 specify buffer/string position and length are now ssize_t and
1425 size_t. Return type is regoff_t.
1426
613052cd
BK
14272011-04-16 Ben Key <bkey76@gmail.com>
1428
1429 * nsfont.m: Fixed bugs in ns_get_family and
1430 ns_descriptor_to_entity that were caused by using free to
1431 deallocate memory blocks that were allocated by xmalloc (via
1432 xstrdup). This caused Emacs to crash when compiled with
1433 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1434 --enable-checking=xmallocoverrun). xfree is now used to
1435 deallocate these memory blocks.
1436
4170f62f 14372011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1438
71b41406
PE
1439 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1440
9587a89d
PE
1441 emacs_write: Accept and return EMACS_INT for sizes.
1442 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1443 et seq.
1444 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1445 Accept and return EMACS_INT.
1446 (emacs_gnutls_write): Return the number of bytes written on
1447 partial writes.
1448 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1449 (emacs_read, emacs_write): Remove check for negative size, as the
1450 Emacs source code has been audited now.
9587a89d
PE
1451 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1452 (emacs_read, emacs_write): Use it.
273a5f82
PE
1453 * process.c (send_process): Adjust to the new signatures of
1454 emacs_write and emacs_gnutls_write. Do not attempt to store
1455 a byte offset into an 'int'; it might overflow.
9587a89d 1456 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1457
3e047f51
PE
1458 * sound.c: Don't assume sizes fit in 'int'.
1459 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1460 Return EMACS_INT, not int.
3e047f51 1461 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1462 Accept EMACS_INT, not int.
1463 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1464 record read return values.
1465
cc39a9db
BK
14662011-04-15 Ben Key <bkey76@gmail.com>
1467
c9d0ec6d
JB
1468 * keyboard.c (Qundefined): Don't declare static since it is used
1469 in nsfns.m.
1470 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1471 static since they are used in nsfont.m.
cc39a9db 1472
6c60eb9f
SM
14732011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1474
1475 * process.c (Qprocessp): Don't declare static.
1476 * lisp.h (Qprocessp): Declare again.
1477
7990b61a
JB
14782011-04-15 Juanma Barranquero <lekktu@gmail.com>
1479
1480 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1481
5d4cb038
PE
14822011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1483
8bd7b830 1484 Improve C-level modularity by making more things 'static'.
cd64ea1d 1485
e3b27b31
PE
1486 Don't publish debugger-only interfaces to other modules.
1487 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1488 (verify_bytepos, count_markers): Move decls to the only modules
1489 that need them.
1490 * region-cache.h (pp_cache): Likewise.
1491 * window.h (check_all_windows): Likewise.
1492 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1493
5d4cb038
PE
1494 * sysdep.c (croak): Now static, if
1495 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1496 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1497
1498 * alloc.c (refill_memory_reserve): Now static if
1499 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1500 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1501
e87b6180
PE
1502 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1503 Define only if USE_LUCID.
1504
ac64929e
PE
1505 * xrdb.c (x_customization_string, x_rm_string): Now static.
1506
6f37259d
PE
1507 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1508 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1509
1683e3ab
PE
1510 * xdisp.c (draw_row_with_mouse_face): Now static.
1511 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1512
de9c2632
PE
1513 * window.h (check_all_windows): Mark externally visible.
1514
2b96acb7
PE
1515 * window.c (window_deletion_count): Now static.
1516
1517 * undo.c: Make symbols static if they're not exported.
1518 (last_undo_buffer, last_boundary_position, pending_boundary):
1519 Now static.
1520
50436f33
PE
1521 * textprop.c (interval_insert_behind_hooks): Now static.
1522 (interval_insert_in_front_hooks): Likewise.
1523
64520e5c
PE
1524 * term.c: Make symbols static if they're not exported.
1525 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1526 (max_frame_lines, tty_set_terminal_modes):
1527 (tty_reset_terminal_modes, tty_turn_off_highlight):
1528 (get_tty_terminal): Now static.
1529 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1530 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1531 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1532 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1533 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1534
1fa53021
PE
1535 * sysdep.c: Make symbols static if they're not exported.
1536 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1537 Now static.
1538 (sigprocmask_set, full_mask): Remove; unused.
1539 (wait_debugging): Mark as visible.
1540 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1541 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1542
d4b43b22
PE
1543 * syntax.c (syntax_temp): Define only if !__GNUC__.
1544
b7c513d0
PE
1545 * sound.c (current_sound_device, current_sound): Now static.
1546
989b29ad
PE
1547 * search.c (searchbufs, searchbuf_head): Now static.
1548
13a55a78
PE
1549 * scroll.c (scroll_cost): Remove; unused.
1550 * dispextern.h (scroll_cost): Remove decl.
1551
de68a1fc
PE
1552 * region-cache.h (pp_cache): Mark as externally visible.
1553
40ccffa6
PE
1554 * process.c: Make symbols static if they're not exported.
1555 (process_tick, update_tick, create_process, chan_process):
1556 (Vprocess_alist, proc_buffered_char, datagram_access):
1557 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1558 (deactivate_process): Mark defn as static, as well as decl.
1559 * lisp.h (create_process): Remove decl.
1560 * process.h (chan_process, Vprocess_alist): Remove decls.
1561
ad64fc97
PE
1562 * print.c: Make symbols static if they're not exported.
1563 (print_depth, new_backquote_output, being_printed, print_buffer):
1564 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1565 (print_interval, print_number_index, initial_stderr_stream):
1566 Now static.
1567 * lisp.h (Fprinc): Remove decl.
1568 (debug_output_compilation_hack): Mark as externally visible.
1569
adddb265
PE
1570 * sysdep.c (croak): Move decl from here to syssignal.h.
1571 * syssignal.h (croak): Put it here, so the API can be checked when
1572 'croak' is called from dissociate_if_controlling_tty.
1573
1717ede2
PE
1574 * minibuf.c: Make symbols static if they're not exported.
1575 (minibuf_save_list, choose_minibuf_frame): Now static.
1576 * lisp.h (choose_minibuf_frame): Remove decl.
1577
fa5fb2bc
PE
1578 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1579
1e3890d1
PE
1580 * lread.c: Make symbols static if they're not exported.
1581 (read_objects, initial_obarray, oblookup_last_bucket_number):
1582 Now static.
1583 (make_symbol): Remove; unused.
1584 * lisp.h (initial_obarray, make_symbol): Remove decls.
1585
8a1414fa
PE
1586 * keyboard.c: Make symbols static if they're not exported.
1587 (single_kboard, recent_keys_index, total_keys, recent_keys):
1588 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1589 (this_single_command_key_start, echoing, last_auto_save):
1590 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1591 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1592 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1593 (Vlispy_mouse_stem, double_click_count):
1594 Now static.
1595 (force_auto_save_soon): Define only if SIGDANGER.
1596 (ignore_mouse_drag_p): Now static if
1597 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1598 (print_help): Remove; unused.
1599 (stop_character, last_timer_event): Mark as externally visible.
1600 * keyboard.h (ignore_mouse_drag_p): Declare only if
1601 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1602 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1603 * lisp.h (echoing): Remove decl.
1604 (force_auto_save_soon): Declare only if SIGDANGER.
1605 * xdisp.c (redisplay_window): Simplify code, to make it more
1606 obvious that ignore_mouse_drag_p is not accessed if !defined
1607 USE_GTK && !defined HAVE_NS.
1608
93ea6e8f
PE
1609 * intervals.c: Make symbols static if they're not exported.
1610 (merge_properties_sticky, merge_interval_right, delete_interval):
1611 Now static.
1612 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1613
77382fcc
PE
1614 * insdel.c: Make symbols static if they're not exported.
1615 However, leave prepare_to_modify_buffer alone. It's never
1616 called from outside this function, but that appears to be a bug.
1617 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1618 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1619 (adjust_after_replace_noundo): Remove; unused.
1620 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1621 (signal_before_change): Remove decls.
77382fcc 1622
9306c32e
PE
1623 * indent.c (val_compute_motion, val_vmotion): Now static.
1624
cd44d2eb
PE
1625 * image.c: Make symbols static if they're not exported.
1626 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1627 if USE_GTK.
1628 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1629 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1630
ad9a7a06
PE
1631 * fringe.c (standard_bitmaps): Now static.
1632 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1633
81626931
PE
1634 * frame.c: Make symbols static if they're not exported.
1635 (x_report_frame_params, make_terminal_frame): Now static.
1636 (get_frame_param): Now static, unless HAVE_NS.
1637 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1638 (x_get_resource_string): Remove; not used.
1639 * frame.h (make_terminal_frame, x_report_frame_params):
1640 (x_get_resource_string); Remove decls.
1641 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1642 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1643
239f9db9
PE
1644 * font.c, fontset.c: Make symbols static if they're not exported.
1645 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1646 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1647 * font.c (font_close_object): Now static.
1648 * font.h (font_close_object): Remove.
1649 * fontset.c (FONTSET_OBJLIST): Remove.
1650 (free_realized_fontset) #if-0 the body, which does nothing.
1651 (face_suitable_for_char_p): #if-0, as it's never called.
1652 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1653 * xfaces.c (face_at_string_position):
1654 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1655 since 0 is always ASCII.
1656
dfcf3579
PE
1657 * fns.c (weak_hash_tables): Now static.
1658
5045092b
PE
1659 * fileio.c: Make symbols static if they're not exported.
1660 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1661 (Vwrite_region_annotation_buffers): Now static.
1662
57a96f5c
PE
1663 * eval.c: Make symbols static if they're not exported.
1664 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1665 * lisp.h (backtrace_list): Remove decl.
1666
35f08c38
PE
1667 * emacs.c: Make symbols static if they're not exported.
1668 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1669 (fatal_error_code, fatal_error_signal_hook, standard_args):
1670 Now static.
1671 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1672 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1673 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1674 * lisp.h (fatal_error_signal_hook): Remove decl.
1675 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1676
f44bd759
PE
1677 * editfns.c: Move a (normally-unused) function to its only use.
1678 * editfns.c, lisp.h (get_operating_system_release): Remove.
1679 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1680 worth the hassle of breaking this out.
1681
b532497d
PE
1682 * xterm.c: Make symbols static if they're not exported.
1683 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1684 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1685 (x_destroy_window, x_delete_display):
1686 Now static.
1687 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1688 (x_mouse_leave): Remove; unused.
1689 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1690 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1691 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1692 Remove decls.
1693 (x_mouse_leave): Declare only if WINDOWSNT.
1694 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1695 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1696 USE_X_TOOLKIT.
1697
1675728f
PE
1698 * ftxfont.c: Make symbols static if they're not exported.
1699 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1700 HAVE_FREETYPE.
1701 * font.h (ftxfont_driver): Likewise.
1702
e4cebfca
PE
1703 * xfns.c: Make symbols static if they're not exported.
1704 (x_last_font_name, x_display_info_for_name):
1705 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1706 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1707 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1708 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1709 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1710 (last_show_tip_args): Now static.
1711 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1712 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1713 (x_screen_planes): Remove; unused.
1714 * dispextern.h (x_screen_planes): Remove decl.
1715
5bf46f05
PE
1716 * dispnew.c: Make symbols static if they're not exported.
1717 * dispextern.h (redraw_garbaged_frames, scrolling):
1718 (increment_row_positions): Remove.
1719 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1720 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1721 Now static.
1722 (redraw_garbaged_frames): Remove; unused.
1723
435f4c28
PE
1724 * xfaces.c: Make symbols static if they're not exported.
1725 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1726 Remove decls.
1727 * xterm.h (defined_color): Remove decls.
1728 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1729 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1730 (menu_face_changed_default, defined_color, free_realized_face):
1731 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1732 (ascii_face_of_lisp_face): Remove; unused.
1733
8524aef3
PE
1734 * xdisp.c: Make symbols static if they're not exported.
1735 * dispextern.h (scratch_glyph_row, window_box_edges):
1736 (glyph_to_pixel_coords, set_cursor_from_row):
1737 (get_next_display_element, set_iterator_to_next):
1738 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1739 (show_mouse_face): Remove decls
1740 * frame.h (message_buf_print): Likewise.
1741 * lisp.h (pop_message, set_message, check_point_in_composition):
1742 Likewise.
1743 * xterm.h (set_vertical_scroll_bar): Likewise.
1744 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1745 (message_buf_print, scratch_glyph_row, displayed_buffer):
1746 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1747 (get_next_display_element, show_mouse_face, window_box_edges):
1748 (frame_to_window_pixel_xy, check_point_in_composition):
1749 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1750 (glyph_to_pixel_coords): Remove; unused.
1751
16390cd2
PE
1752 * dired.c (file_name_completion): Now static.
1753
1754 * dbusbind.c (xd_in_read_queued_messages): Now static.
1755
a25f4dfa
PE
1756 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1757 * data.c (circular_list_error): Remove.
1758
14a9c8df
PE
1759 * commands.h (last_point_position, last_point_position_buffer):
1760 (last_point_position_window): Remove decls.
1761 * keyboard.c: Make these variables static.
1762
04f2d78b
CB
1763 * coding.h (coding, code_convert_region, encode_coding_gap):
1764 Remove decls.
74ab6df5
PE
1765 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1766 (iso_code_class, detect_coding, code_convert_region): Now static.
1767 (encode_coding_gap): Remove; unused.
1768
38dfbee1
PE
1769 * chartab.c (chartab_chars, chartab_bits): Now static.
1770
a2cb4e63
PE
1771 * charset.h (charset_iso_8859_1): Remove decl.
1772 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1773 Now static.
1774
127198fd
PE
1775 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1776 * ccl.c (Vccl_program_table): Now static.
1777 (check_ccl_update): Remove; unused.
1778
d85b608f
PE
1779 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1780 * category.h: ... from here.
1781 * category.c (check_category_table, set_category_set): Now static.
1782
31cd66f3
PE
1783 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1784 * lisp.h: Remove these decls.
1785
c358e587
PE
1786 * buffer.c (buffer_count): Remove unused var.
1787
e78aecca
PE
1788 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1789 so that it's not optimized away.
1790 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1791 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1792 exported only to the debugger.
1793
e192d7d3 1794 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1795 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1796
92470028
PE
1797 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1798 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1799 was inaccessible from Lisp.
1800 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1801 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1802
244ed907
PE
1803 alloc.c: Import and export fewer symbols, and remove unused items.
1804 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1805 is defined.
1806 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1807 it's not optimized away by whole-program optimization.
1808 (message_enable_multibyte, free_misc): Remove.
1809 (catchlist, handlerlist, mark_backtrace):
1810 Declare only if BYTE_MARK_STACK.
1811 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1812 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1813 (message_enable_multibyte): Remove decl.
1814 (free_misc, interval_free_list, float_block, float_block_index):
1815 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1816 (cons_free_list, last_marked_index):
1817 Now static.
1818 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1819 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1820 (mark_backtrace): Define only if BYTE_MARK_STACK.
1821 * xdisp.c (message_enable_multibyte): Now static.
1822
61c2b50e 1823 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1824 This makes it easier for human readers (and static analyzers)
1825 to see whether these variables are used from other modules.
1826 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1827 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1828 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1829 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1830 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1831 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1832 * xmenu.c, xselect.c:
1833 Declare Q* vars static if they are not used in other modules.
1834 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1835 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1836 Remove decls of unexported vars.
1837 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1838
95c82688
PE
1839 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1840
16a97296
PE
1841 Make Emacs functions such as Fatom 'static' by default.
1842 This makes it easier for human readers (and static analyzers)
1843 to see whether these functions can be called from other modules.
1844 DEFUN now defines a static function. To make the function external
1845 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1846 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1847 (Finit_image_library):
16a97296
PE
1848 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1849 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1850 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1851 Remove decls, since these functions are now static.
1852 (Funintern, Fget_internal_run_time): New decls, since these functions
1853 were already external.
95c82688 1854
16a97296
PE
1855 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1856 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1857 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1858 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1859 * keyboard.c, keymap.c, lread.c:
1860 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1861 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1862 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1863 Mark functions with DEFUE instead of DEFUN,
1864 if they are used in other modules.
1865 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1866 decls for now-static functions.
1867 * buffer.h (Fdelete_overlay): Remove decl.
1868 * callproc.c (Fgetenv_internal): Mark as internal.
1869 * composite.c (Fremove_list_of_text_properties): Remove decl.
1870 (Fcomposition_get_gstring): New forward static decl.
1871 * composite.h (Fcomposite_get_gstring): Remove decl.
1872 * dired.c (Ffile_attributes): New forward static decl.
1873 * doc.c (Fdocumntation_property): New forward static decl.
1874 * eval.c (Ffetch_bytecode): New forward static decl.
1875 (Funintern): Remove extern decl; now in .h file where it belongs.
1876 * fileio.c (Fmake_symbolic_link): New forward static decl.
1877 * image.c (Finit_image_library): New forward static decl.
1878 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1879 * intervals.h (Fprevious_property_change):
1880 (Fremove_list_of_text_properties): Remove decls.
1881 * keyboard.c (Fthis_command_keys): Remove decl.
1882 (Fcommand_execute): New forward static decl.
1883 * keymap.c (Flookup_key): New forward static decl.
1884 (Fcopy_keymap): Now static.
1885 * keymap.h (Flookup_key): Remove decl.
1886 * process.c (Fget_process): New forward static decl.
1887 (Fprocess_datagram_address): Mark as internal.
1888 * syntax.c (Fsyntax_table_p): New forward static decl.
1889 (skip_chars): Remove duplicate decl.
1890 * textprop.c (Fprevious_property_change): New forward static decl.
1891 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1892 Now internal.
1893 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1894 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1895
785bbd42
PE
1896 * editfns.c (Fformat): Remove unreachable code.
1897
8b913b57
AS
18982011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1899
1900 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1901 change. (Bug#8496)
1902
a6744a35
EZ
19032011-04-13 Eli Zaretskii <eliz@gnu.org>
1904
1905 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1906 when at ZV. (Bug#8487)
1907
e7974947
AS
19082011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1909
baad03f0
AS
1910 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1911 (Bug#8437)
1912 * keyboard.c (parse_tool_bar_item): Likewise.
1913 * sound.c (sound_cleanup, alsa_close): Likewise.
1914 * termcap.c (tgetent): Likewise.
1915 * xfns.c (x_default_font_parameter): Likewise.
1916 * xsettings.c (read_and_apply_settings): Likewise.
1917
e7974947
AS
1918 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1919 (overrun_check_free): Protoize.
1920
28272684
PE
19212011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1922
1923 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1924 since callers should never pass a negative size.
1925 Change the signature to match that of plain 'read' and 'write'; see
1926 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1927 * lisp.h: Update prototypes of emacs_write and emacs_read.
1928
11997c76
EZ
19292011-04-11 Eli Zaretskii <eliz@gnu.org>
1930
1931 * xdisp.c (redisplay_window): Don't try to determine the character
1932 position of the scroll margin if the window start point w->startp
e896f03c 1933 is outside the buffer's accessible region. (Bug#8468)
11997c76 1934
8a2cbd72
EZ
19352011-04-10 Eli Zaretskii <eliz@gnu.org>
1936
1937 Fix write-region and its subroutines for buffers > 2GB.
1938 * fileio.c (a_write, e_write): Modify declaration of arguments and
1939 local variables to support buffers larger than 2GB.
1940 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1941
1942 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1943 argument, local variables, and return value.
1944
1945 * lisp.h: Update prototypes of emacs_write and emacs_read.
1946
1947 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1948
4073e537 19492011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1950
1ebfdcb6
PE
1951 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1952
b2ded58d
PE
1953 Fix more problems found by GCC 4.6.0's static checks.
1954
7d66342c
PE
1955 * xdisp.c (vmessage): Use a better test for character truncation.
1956
bbf47d44
PE
1957 * charset.c (load_charset_map): <, not <=, for optimization,
1958 and to avoid potential problems with integer overflow.
9248994d 1959 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1960 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1961 * editfns.c (Fformat): Likewise.
1e69125e 1962 * syntax.c (skip_chars): Likewise.
3befa583 1963
e3019616
PE
1964 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1965 This also lets GCC 4.6.0 generate slightly better loop code.
1966
becfa255
PE
1967 * callint.c (Fcall_interactively): <, not <=, for optimization.
1968 (Fcall_interactively): Count the number of arguments produced,
1969 not the number of arguments given. This is simpler and lets GCC
1970 4.6.0 generate slightly better code.
1971
dae0cd48
PE
1972 * ftfont.c: Distingish more carefully between FcChar8 and char.
1973 The previous code passed unsigned char * to a functions like
1974 strlen and xstrcasecmp that expect char *, which does not
1975 conform to the C standard.
1976 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1977 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1978 char * when the C standard requires it.
1979
76032d70
PE
1980 * keyboard.c (read_char): Remove unused var.
1981
eb3f1cc8
PE
1982 * eval.c: Port to Windows vsnprintf (Bug#8435).
1983 Include <limits.h>.
1984 (SIZE_MAX): Define if the headers do not.
1985 (verror): Do not give up if vsnprintf returns a negative count.
1986 Instead, grow the buffer. This ports to Windows vsnprintf, which
1987 does not conform to C99. Problem reported by Eli Zaretskii.
1988 Also, simplify the allocation scheme, by avoiding the need for
1989 calling realloc, and removing the ALLOCATED variable.
1990
70476b54
PE
1991 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1992
12020a9e
PE
1993 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1994 But keep the doprint source code for now, as we might revamp it
1995 and use it again (Bug#8435).
ea6c7ae6
PE
1996 * lisp.h (doprnt): Remove.
1997 * Makefile.in (base_obj): Remove doprnt.o.
1998 * deps.mk (doprnt.o): Remove.
1999
5fdb398c
PE
2000 error: Print 32- and 64-bit integers portably (Bug#8435).
2001 Without this change, on typical 64-bit hosts error ("...%d...", N)
2002 was used to print both 32- and 64-bit integers N, which relied on
2003 undefined behavior.
2004 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2005 New macro.
2006 * lisp.h (error, verror): Mark as printf-like functions.
2007 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2008 Report overflow in size calculations when allocating printf buffer.
2009 Do not truncate output string at its first null byte.
2010 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2011 Truncate the output at a character boundary, since vsnprintf does not
2012 do that.
2013 * charset.c (check_iso_charset_parameter): Convert internal
2014 character to string before calling 'error', since %c now has the
2015 printf meaning.
2016 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2017 overflow when computing char to be passed to 'error'. Do not
2018 pass Lisp_Object to 'error'; pass the integer instead.
2019 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2020 formatted with plain %d.
2021
b189fa66
PE
2022 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2023
bff87ef0
PE
2024 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2025
7e2cac20
PE
2026 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2027
ce4d90b5
PE
2028 * xterm.c (x_catch_errors): Remove duplicate declaration.
2029
266c9547
PE
2030 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2031
79c49ad2
PE
2032 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2033
368f4090
JM
20342011-04-10 Jim Meyering <meyering@redhat.com>
2035
2036 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2037 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2038 return ssize_t not "int", and use size_t as the buffer length.
2039 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2040 * gnutls.h: Update declarations.
2041 * process.c (read_process_output): Use ssize_t, to match.
2042 (send_process): Likewise.
2043
a32d4040
CY
20442011-04-09 Chong Yidong <cyd@stupidchicken.com>
2045
2046 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2047
8546720e 20482011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2049
04f2d78b
CB
2050 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2051 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2052
8546720e
GM
2053 * xterm.c (handle_one_xevent):
2054 * xmenu.c (create_and_show_popup_menu):
2055 * xselect.c (x_decline_selection_request)
2056 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2057
0a2f5c1a 20582011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2059
2060 Fix some uses of `int' instead of EMACS_INT.
2061 * search.c (string_match_1, fast_string_match)
2062 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2063 (scan_buffer, find_next_newline_no_quit)
2064 (find_before_next_newline, search_command, Freplace_match)
2065 (Fmatch_data): Make some `int' variables be EMACS_INT.
2066
2067 * xdisp.c (display_count_lines): 3rd argument and return value now
2068 EMACS_INT. All callers changed.
2069 (pint2hrstr): Last argument is now EMACS_INT.
2070
2071 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2072 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2073 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2074 (decode_coding_utf_16, decode_coding_emacs_mule)
2075 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2076 (decode_coding_ccl, decode_coding_charset)
2077 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2078 (decode_coding_iso_2022, decode_coding_emacs_mule)
2079 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2080 <char_offset, last_offset>: Declare EMACS_INT.
2081 (encode_coding_utf_8, encode_coding_utf_16)
2082 (encode_coding_emacs_mule, encode_invocation_designation)
2083 (encode_designation_at_bol, encode_coding_iso_2022)
2084 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2085 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2086 Declare EMACS_INT.
2087 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2088 (encode_invocation_designation): Last argument P_NCHARS is now
2089 EMACS_INT.
2090 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2091 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2092
2093 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2094 All users changed.
2095
2096 * ccl.c (Fccl_execute_on_string): Declare some variables
2097 EMACS_INT.
2098
8546720e 20992011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2100
2101 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2102
4e19a977
CS
21032011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2104
2105 * process.c (Fformat_network_address): Doc fix.
2106
87302331
R
21072011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2108
2109 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2110
cbb59342
CY
21112011-04-08 Chong Yidong <cyd@stupidchicken.com>
2112
2113 * keyboard.c (read_char): Call Lisp function help-form-show,
2114 instead of using internal_with_output_to_temp_buffer.
2115 (Qhelp_form_show): New var.
e0d38eeb 2116 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2117
2118 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2119
2120 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2121
e67a13ab
CY
21222011-04-06 Chong Yidong <cyd@stupidchicken.com>
2123
04f2d78b
CB
2124 * process.c (Flist_processes): Remove to Lisp.
2125 (list_processes_1): Delete.
e67a13ab 2126
973f782d
EZ
21272011-04-06 Eli Zaretskii <eliz@gnu.org>
2128
7c106b1e
EZ
2129 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2130
973f782d
EZ
2131 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2132
41cf7d1a 21332011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2134
ca23cc88
PE
2135 Fix more problems found by GCC 4.6.0's static checks.
2136
f390e2d5
PE
2137 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2138
42eea0d0
PE
2139 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2140
b69769da 2141 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2142
f9541e84
PE
2143 * xdisp.c (vmessage): Mark as a printf-like function.
2144
13841b55
PE
2145 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2146
c136c10f
PE
2147 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2148
5e2d4a30
PE
2149 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2150 printf-like functions.
2151 (tiff_load): Add casts to remove these marks before passing them
2152 to system-supplied API.
2153
583f48b9
PE
2154 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2155
b25d760e
PE
2156 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2157 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2158 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2159 directly, rather than having caller test rule sign. This avoids
2160 some unnecessary tests.
2161 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2162 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2163 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2164
bc7b6697 2165 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2166 (xfont_open): Avoid unnecessary tests.
bc7b6697 2167
27ccc379
PE
2168 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2169
dcd5c89a
PE
2170 * composite.h, composite.c (composition_gstring_put_cache):
2171 Use EMACS_INT, not int, for length.
2172
b13a45c6
PE
2173 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2174 breaking out part of COMPOSITION_DECODE_RULE.
2175 (COMPOSITION_DECODE_RULE): Use it.
2176 * composite.c (get_composition_id): Remove unused local vars,
2177 by using the new macro.
2178
1e792e4d
PE
2179 * textprop.c (set_text_properties_1): Change while to do-while,
2180 since the condition is always true at first.
2181
dc6c6455 2182 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2183 (interval_deletion_adjustment): Return unsigned value.
2184 All uses changed.
dc6c6455 2185
aba7731a
PE
2186 * process.c (list_processes_1, create_pty, read_process_output):
2187 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2188 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2189 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2190 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2191 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2192
fdfc4bf3
PE
2193 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2194
fca8fe46 2195 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2196 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2197
06a0259a 2198 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2199 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2200 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2201
e7b9e80f
PE
2202 * print.c (print_error_message): Avoid int overflow.
2203
56201685
PE
2204 * font.c (font_list_entities): Redo for clarity,
2205 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2206
78834453 2207 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2208 (font_score): Avoid potential overflow in diff calculation.
78834453 2209
0bc0b309 2210 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2211 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2212
e610eaca
PE
2213 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2214
b895abce
PE
2215 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2216 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2217 can always succeed if overflow has undefined behavior.
2218
1f1d9321 2219 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2220 (wordify): Omit three unnecessary tests.
1f1d9321 2221
c59478bc
PE
2222 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2223 All callers changed. This avoids the need for an unused var.
2224
79b73827
PE
2225 * casefiddle.c (casify_region): Remove var that is set but not used.
2226
a4db5dfe
PE
2227 * dired.c (file_name_completion): Remove var that is set but not used.
2228
43aae36e
PE
2229 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2230
2a47c44d 2231 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2232 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2233
a37c69bf
PE
2234 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2235 Check for integer overflow on size calculations.
2236
328ab8e7
PE
2237 * buffer.c (Fprevious_overlay_change): Remove var that is set
2238 but not used.
2239
e5a2a5cb
PE
2240 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2241 Remove vars that are set but not used.
8d84a6eb 2242 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2243 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2244
a60e5f68
PE
2245 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2246
f661cb61 2247 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2248 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2249
f0397f5a
PE
2250 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2251 that are set but not used.
2252
8664db06 2253 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2254 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2255
6abdaa4a
PE
2256 * xselect.c (x_get_local_selection, x_handle_property_notify):
2257 Remove vars that are set but not used.
2258
0ce7538d 2259 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2260 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2261
9ae848fc
PE
2262 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2263 Remove var that is set but not used.
0b918413
PE
2264 (scroll_bar_windows_size): Now size_t, not int.
2265 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2266 Check for overflow.
9ae848fc 2267
a5a62657
PE
2268 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2269 (map_tty_color) [!defined MSDOS]: Likewise.
2270
5c5cdd39
PE
2271 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2272
66ebf983
PE
2273 * coding.c: Remove vars that are set but not used.
2274 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2275 All callers changed.
2276 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2277 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2278 (decode_coding_charset): Remove vars that are set but not used.
2279
1be4d761
PE
2280 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2281 that is set but not used.
2282
47553fa8
PE
2283 * print.c (print_object): Remove var that is set but not used.
2284
1f7196bf 2285 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2286 The gnulib version avoids calling malloc in the usual case,
2287 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2288 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2289 * filelock.c (current_lock_owner): Likewise.
2290 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2291 * sysdep.c: Include allocator.h, careadlinkat.h.
2292 (emacs_no_realloc_allocator): New static constant.
2293 (emacs_readlink): New function.
fdb61804
PE
2294 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2295 ../lib/careadlinkat.h.
d1fdcab7 2296
f84c17c7
SM
22972011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2298
2299 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2300 first non-nil return value).
2301
ef3862ad
JD
23022011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2303
2304 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2305 if not defined (Bug#8403).
2306
376a7006
JB
23072011-04-02 Juanma Barranquero <lekktu@gmail.com>
2308
2309 * xdisp.c (display_count_lines): Remove parameter `start',
2310 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2311 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2312 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2313 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2314 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2315 and thereabouts. All callers changed.
2316 (get_per_char_metric): Remove parameter `f', unused since
2317 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2318
6ca3801d
JM
23192011-04-02 Jim Meyering <meyering@redhat.com>
2320
2321 do not dereference NULL upon failed strdup
2322 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2323 (ns_get_family): Likewise.
2324
d8e2b5ba
JB
23252011-04-02 Juanma Barranquero <lekktu@gmail.com>
2326
2327 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2328
8c74fcbd
JD
23292011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2330
2331 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2332 later (Bug#8403).
2333
7200d79c
SM
23342011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2335
03408648 2336 Add lexical binding.
7200d79c 2337
03408648
SM
2338 * window.c (Ftemp_output_buffer_show): New fun.
2339 (Fsave_window_excursion):
2340 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2341
2342 * lread.c (lisp_file_lexically_bound_p): New function.
2343 (Fload): Bind Qlexical_binding.
2344 (readevalloop): Remove `evalfun' arg.
2345 Bind Qinternal_interpreter_environment.
2346 (Feval_buffer): Bind Qlexical_binding.
2347 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2348 Mark as dynamic.
2349 (syms_of_lread): Declare `lexical-binding'.
2350
2351 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2352
2353 * keyboard.c (eval_dyn): New fun.
2354 (menu_item_eval_property): Use it.
ca105506
SM
2355
2356 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2357
03408648
SM
2358 * fns.c (concat, mapcar1): Accept byte-code-functions.
2359
2360 * eval.c (Fsetq): Handle lexical vars.
2361 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2362 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2363 (FletX, Flet): Obey lexical binding.
2364 (Fcommandp): Handle closures.
2365 (Feval): New `lexical' arg.
2366 (eval_sub): New function extracted from Feval. Use it almost
2367 everywhere where Feval was used. Look up vars in lexical env.
2368 Handle closures.
2369 (Ffunctionp): Move from subr.el.
2370 (Ffuncall): Handle closures.
2371 (apply_lambda): Remove `eval_flags'.
2372 (funcall_lambda): Handle closures and new byte-code-functions.
2373 (Fspecial_variable_p): New function.
2374 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2375 but without exporting it to Lisp.
23aba0ea 2376
23aba0ea 2377 * doc.c (Fdocumentation, store_function_docstring):
03408648 2378 * data.c (Finteractive_form): Handle closures.
23aba0ea 2379
03408648
SM
2380 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2381 interactive spec.
ba83908c 2382
04f2d78b
CB
2383 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2384 New byte-codes.
03408648
SM
2385 (exec_byte_code): New function extracted from Fbyte_code to handle new
2386 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2387
03408648 2388 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2389
03408648 2390 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2391
e2abce01
JB
23922011-03-31 Juanma Barranquero <lekktu@gmail.com>
2393
2394 * xdisp.c (redisplay_internal): Fix prototype.
2395
63696a73 23962011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2397
63696a73 2398 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2399 (try_scrolling): Use it when setting scroll_limit.
2400 Limit scrolling to 100 screen lines.
63696a73
EZ
2401 (redisplay_window): Even when falling back on "recentering",
2402 position point in the window according to scroll-conservatively,
2403 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2404
2405 (try_scrolling): When point is above the window, allow searching
2406 as far as scroll_max, or one screenful, to compute vertical
2407 distance from PT to the scroll margin position. This prevents
2408 try_scrolling from unnecessarily failing when
2409 scroll-conservatively is set to a value slightly larger than the
2410 window height. Clean up the case of PT below the margin at bottom
2411 of window: scroll_max can no longer be INT_MAX. When aggressive
2412 scrolling is in use, don't let point enter the opposite scroll
2413 margin as result of the scroll.
2414 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2415 threshold of 100 lines for never-recentering scrolling.
2416
e4cc2dfc
JB
24172011-03-31 Juanma Barranquero <lekktu@gmail.com>
2418
2419 * dispextern.h (move_it_by_lines):
2420 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2421 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2422 (message_log_check_duplicate): Remove parameters `prev_bol' and
2423 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2424 (redisplay_internal): Remove parameter `preserve_echo_area',
2425 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2426
2427 * indent.c (Fvertical_motion):
2428 * window.c (window_scroll_pixel_based, Frecenter):
2429 Don't pass `need_y_p' to `move_it_by_lines'.
2430
1c470562
SM
24312011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2432
44f230aa
SM
2433 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2434 steal a few bits to be more compact.
2435 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2436 Remove unneeded casts.
2437
1c470562
SM
2438 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2439
888adce9
ZK
24402011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2441
2442 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2443 binding" message (bug#7967).
2444
f838ed7b
PE
24452011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2446
77861b95
PE
2447 Fix more problems found by GCC 4.6.0's static checks.
2448
de6dbc14
PE
2449 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2450 Remove unused local var.
2451
f838ed7b
PE
2452 * editfns.c (Fmessage_box): Remove unused local var.
2453
792c7b2b
PE
2454 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2455 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2456 Omit unused local vars.
c499e557 2457 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2458 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2459 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2460 Omit unused local var.
2461
ba0165e1
PE
2462 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2463 Don't assume string length fits in int.
32ad8845 2464 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2465 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2466
3c59b4c9
PE
2467 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2468 instead of alloca (Bug#8344).
2469
a3eed478 2470 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2471 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2472
eb4d412d
PE
2473 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2474
1658b401
PE
2475 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2476 concerns.
2477
2478 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2479
2480 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2481
9a2c6e05
PE
2482 * keyboard.c (syms_of_keyboard): Use the same style as later
2483 in this function when indexing through an array. This also
2484 works around GCC bug 48267.
2485
03d0a109
PE
2486 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2487
44f730c8
PE
2488 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2489
fe75f926
PE
2490 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2491 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2492
ffa8c828
PE
2493 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2494 This avoids undefined behavior on integer overflow, and is a bit
2495 more convenient anyway since it is compared to a size_t variable.
2496
c5101a77
PE
2497 Variadic C functions now count arguments with size_t, not int.
2498 This avoids an unnecessary limitation on 64-bit machines, which
2499 caused (substring ...) to crash on large vectors (Bug#8344).
2500 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2501 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2502 All variadic functions and their callers changed accordingly.
c5101a77
PE
2503 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2504 * data.c (arith_driver, float_arith_driver): Likewise.
2505 * editfns.c (general_insert_function): Likewise.
2506 * eval.c (struct backtrace.nargs, interactive_p)
2507 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2508 (funcall_lambda, mark_backtrace): Likewise.
2509 * fns.c (concat): Likewise.
2510 * frame.c (x_set_frame_parameters): Likewise.
2511 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2512 0 if not found, not -1. All callers changed.
2513
dd3f25f7
PE
2514 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2515 (stack_copy_size): Now size_t, not int.
2516 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2517
461c2ab9
JB
25182011-03-28 Juanma Barranquero <lekktu@gmail.com>
2519
2520 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2521 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2522 All callers changed.
2523
2524 * lisp.h (multibyte_char_to_unibyte):
2525 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2526 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2527 * character.h (CHAR_TO_BYTE8):
2528 * cmds.c (internal_self_insert):
2529 * editfns.c (general_insert_function):
2530 * keymap.c (push_key_description):
2531 * search.c (Freplace_match):
2532 * xdisp.c (message_dolog, set_message_1): All callers changed.
2533
f6d62986
SM
25342011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2535
2536 * keyboard.c (safe_run_hook_funcall): New function.
2537 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2538 don't set the hook to nil, but remove the offending function instead.
2539 (Qcommand_hook_internal): Remove, unused.
2540 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2541 Vcommand_hook_internal.
2542
2543 * eval.c (enum run_hooks_condition): Remove.
2544 (funcall_nil, funcall_not): New functions.
2545 (run_hook_with_args): Call each function through a `funcall' argument.
2546 Remove `cond' argument, now redundant.
2547 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2548 (Frun_hook_with_args_until_failure): Adjust accordingly.
2549 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2550
1db5b1ad
JB
25512011-03-28 Juanma Barranquero <lekktu@gmail.com>
2552
2553 * dispextern.h (string_buffer_position): Remove declaration.
2554
2555 * print.c (strout): Remove parameter `multibyte', unused since
2556 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2557
2558 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2559 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2560 All callers changed.
2561
2562 * w32.c (_wsa_errlist): Use braces for struct initializers.
2563
2564 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2565 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2566 All callers changed.
2567 (string_buffer_position): Likewise. Also, make static (it's never
2568 used outside xdisp.c).
2569 (cursor_row_p): Remove parameter `w', unused since
2570 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2571 (decode_mode_spec): Remove parameter `precision', introduced during
2572 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2573 All callers changed.
2574
5ffb62aa
JD
25752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2576
2577 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2578
461c2ab9 25792011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2580
2581 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2582 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2583 (ns_update_auto_hide_menu_bar): New functions.
2584 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2585 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2586 ns_constrain_all_frames.
2587 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2588 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2589
5c380ffb
JD
25902011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2591
2592 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2593
9af30bdf
GM
25942011-03-27 Glenn Morris <rgm@gnu.org>
2595
2596 * syssignal.h: Replace RETSIGTYPE with void.
2597 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2598 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2599 Replace SIGTYPE with void everywhere.
2600 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2601 * s/template.h (SIGTYPE): Remove commented out definition.
2602
e2abce01
JB
26032011-03-26 Eli Zaretskii <eliz@gnu.org>
2604
2605 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2606 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2607
f868cd8a
JB
26082011-03-26 Juanma Barranquero <lekktu@gmail.com>
2609
59eb0929
JB
2610 * w32.c (read_unc_volume): Use parameter `henum', instead of
2611 global variable `wget_enum_handle'.
2612
2613 * keymap.c (describe_vector): Remove parameters `indices' and
2614 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2615 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2616
f868cd8a
JB
2617 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2618
2619 * keyboard.c (timer_check): Remove parameter `do_it_now',
2620 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2621 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2622 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2623
2624 * keyboard.c (read_char):
2625 * w32menu.c (w32_menu_display_help):
2626 * xmenu.c (show_help_event, menu_help_callback):
2627 Adjust calls to `show_help_echo'.
2628
2629 * gtkutil.c (xg_maybe_add_timer):
2630 * keyboard.c (readable_events):
2631 * process.c (wait_reading_process_output):
2632 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2633
2634 * insdel.c (adjust_markers_gap_motion):
2635 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2636 (gap_left, gap_right): Don't call it.
2637
2ecf6fdb
CY
26382011-03-25 Chong Yidong <cyd@stupidchicken.com>
2639
2640 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2641 incurred during fontification.
2642
6b1f9ba4
JB
26432011-03-25 Juanma Barranquero <lekktu@gmail.com>
2644
2645 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2646 (DEFVAR_PER_BUFFER): Don't pass it.
2647
2648 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2649 (scrolling_window): Don't pass it.
2650
0f4a96b5
JB
26512011-03-25 Juanma Barranquero <lekktu@gmail.com>
2652
2653 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2654
2655 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2656 and `suffix'.
2657 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2658 of variables specific to SELinux and computation of `encoded_absname'.
2659
2660 * image.c (XPutPixel): Remove unused variable `height'.
2661
2662 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2663
2664 * unexw32.c (get_section_info): Remove unused variable `section'.
2665
2666 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2667 (system_process_attributes): Remove unused variable `sess'.
2668 (sys_read): Remove unused variable `err'.
2669
2670 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2671 (w32_wnd_proc): Remove unused variable `isdead'.
2672 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2673 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2674 (x_create_tip_frame): Remove unused variable `tem'.
2675
2676 * w32inevt.c (w32_console_read_socket):
2677 Remove unused variable `no_events'.
2678
2679 * w32term.c (x_draw_composite_glyph_string_foreground):
2680 Remove unused variable `width'.
2681
1149507c
JB
26822011-03-24 Juanma Barranquero <lekktu@gmail.com>
2683
2684 * w32term.c (x_set_glyph_string_clipping):
2685 Don't pass uninitialized region to CombineRgn.
2686
9c88f339
JB
26872011-03-23 Juanma Barranquero <lekktu@gmail.com>
2688
2689 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2690 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2691 (Fx_close_connection): Remove unused variable `i'.
2692
2693 * w32font.c (w32font_draw): Return number of glyphs.
2694 (w32font_open_internal): Remove unused variable `i'.
2695 (w32font_driver): Add missing initializer.
2696
2697 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2698 (fill_in_menu): Remove unused variable `items_added'.
2699
2700 * w32term.c (last_mouse_press_frame): Remove static global variable.
2701 (w32_clip_to_row): Remove unused variable `f'.
2702 (x_delete_terminal): Remove unused variable `i'.
2703
2704 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2705 (NOTHING): Remove unused static global variable.
2706 (uniscribe_check_otf): Remove unused variable `table'.
2707 (uniscribe_font_driver): Add missing initializers.
2708
dee091a3
JD
27092011-03-23 Julien Danjou <julien@danjou.info>
2710
2711 * term.c (Fsuspend_tty, Fresume_tty):
2712 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2713 * window.c (temp_output_buffer_show):
2714 * insdel.c (signal_before_change):
2715 * frame.c (Fhandle_switch_frame):
2716 * fileio.c (Fdo_auto_save):
2717 * emacs.c (Fkill_emacs):
2718 * editfns.c (save_excursion_restore):
2719 * cmds.c (internal_self_insert):
2720 * callint.c (Fcall_interactively):
2721 * buffer.c (Fkill_all_local_variables):
2722 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2723 Use Frun_hooks.
0f4a96b5 2724 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2725 unconditionnaly since it does the check itself.
2726
2c520ab5 27272011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2728
c9c49752
PE
2729 Fix more problems found by GCC 4.5.2's static checks.
2730
8abc3f12
PE
2731 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2732 the first time through the loop, since we know p0 < p1 then.
2733 This also avoids a gcc -Wstrict-overflow warning.
2734
a2d26660
PE
2735 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2736 leading to a memory leak, possible in functions like
2737 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2738 of objects (Bug#8318).
a2d26660 2739
916c72e9
PE
2740 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2741 that could (at least in theory) be that large.
2742
19ab8a18
PE
2743 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2744 This is less likely to overflow, and avoids undefined behavior if
2745 overflow does occur. All callers changed. Use strtoul to scan
2746 for the unsigned long integer.
b7cbbd6f
PE
2747 (pint2hrstr): Simplify and tune code slightly.
2748 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2749
f0641eff
PE
2750 * scroll.c (do_scrolling): Work around GCC bug 48228.
2751 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2752
7f650bb9
PE
2753 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2754 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2755 (validate_x_resource_name): Simplify count usage.
2756 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2757
37dd57d1
PE
2758 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2759 fail (Bug#8306).
81e56e61 2760
699979fc 2761 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2762
401bf9b4
PE
2763 * process.c (Fmake_network_process): Use socklen_t, not int,
2764 where POSIX says socklen_t is required in portable programs.
2765 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2766 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2767 (Fmake_network_process, server_accept_connection):
2768 (wait_reading_process_output, read_process_output):
2769 Likewise.
2770
b93aacde
PE
2771 * process.c: Rename or move locals to avoid shadowing.
2772 (list_processes_1, Fmake_network_process):
2773 (read_process_output_error_handler, exec_sentinel_error_handler):
2774 Rename or move locals.
4dc343ee 2775 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2776 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2777 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2778 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2779 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2780
af8a867c 2781 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2782 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2783 Include tparam.h instead, since it declares them.
af8a867c
PE
2784 * cm.h (PC): Remove extern decl; tparam.h now does this.
2785 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2786 * terminfo.c: Include tparam.h, to check interfaces.
2787 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2788 (tparam): Adjust signature to match interface in tparam.h;
2789 this removes some undefined behavior. Check that outstring and len
2790 are zero, which they always are with Emacs.
2791 * tparam.h (PC, BC, UP): New extern decls.
2792
0248044d 2793 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2794 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2795
8ff096c1 2796 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2797 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2798 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2799 (ftfont_list): Remove unused local.
49eaafba
PE
2800 (get_adstyle_property, ftfont_pattern_entity):
2801 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2802 Rename locals to avoid shadowing.
8ff096c1 2803
e2be39f6
PE
2804 * xfont.c (xfont_list_family): Mark var as initialized.
2805
c9735e30
PE
2806 * xml.c (make_dom): Now static.
2807
8f5201ae
PE
2808 * composite.c (composition_compute_stop_pos): Rename local to
2809 avoid shadowing.
b246f932
PE
2810 (composition_reseat_it): Remove unused locals.
2811 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2812 (composition_update_it): Mark var as initialized.
11b61122
PE
2813 (find_automatic_composition): Mark vars as initialized,
2814 with a FIXME (Bug#8290).
8f5201ae 2815
760fbc2c
PE
2816 character.h: Rename locals to avoid shadowing.
2817 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2818 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2819 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2820 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2821 to avoid shadowing.
2822
ff08eb85
PE
2823 * textprop.c (property_change_between_p): Remove; unused.
2824
fc7bf025
PE
2825 * intervals.c (interval_start_pos): Now static.
2826
235d7abc
PE
2827 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2828
44f230aa
SM
2829 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2830 Rename locals to avoid shadowing.
3e7d6594 2831
50060332
PE
2832 * sound.c (wav_play, au_play, Fplay_sound_internal):
2833 Fix pointer signedness.
d01f234b 2834 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2835 (wav_play): Initialize a variable to 0, to prevent undefined
2836 behavior (Bug#8278).
50060332 2837
c4fc4e30
PE
2838 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2839
918436ed
PE
2840 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2841
c939f91b
PE
2842 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2843 clobbering (Bug#8298).
b9c7f648
PE
2844 * sysdep.c (sys_subshell): Likewise.
2845 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2846
6bd8c144
PE
2847 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2848 This should get cleaned up, so that child_setup has the
2849 same signature on all platforms.
2850
7710357c 2851 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2852 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2853
c59da222
CY
28542011-03-22 Chong Yidong <cyd@stupidchicken.com>
2855
2856 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2857 not to be necessary, and produces flickering.
2858
66b87493
GM
28592011-03-20 Glenn Morris <rgm@gnu.org>
2860
2861 * config.in: Remove file.
2862
45b6f6d5
JB
28632011-03-20 Juanma Barranquero <lekktu@gmail.com>
2864
2865 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2866 are now in src/globals.h.
2867 (syms_of_minibuf): Remove spurious & from previous change.
2868
3ec03f7e
LL
28692011-03-20 Leo <sdl.web@gmail.com>
2870
2871 * minibuf.c (completing-read-function): New variable.
2872 (completing-read-default): Rename from completing-read.
2873 (completing-read): Call completing-read-function.
2874
b14e3e21
CY
28752011-03-19 Juanma Barranquero <lekktu@gmail.com>
2876
2877 * xfaces.c (Fx_load_color_file):
2878 Read color file from absolute filename (bug#8250).
2879
f2b726e6
JB
28802011-03-19 Juanma Barranquero <lekktu@gmail.com>
2881
2882 * makefile.w32-in: Update dependencies.
2883
09f6ff02
EZ
28842011-03-17 Eli Zaretskii <eliz@gnu.org>
2885
2886 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2887
29a6015a
PE
28882011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2889
a3a6c54e
PE
2890 Fix more problems found by GCC 4.5.2's static checks.
2891
b766f867
PE
2892 * process.c (make_serial_process_unwind, send_process_trap):
2893 (sigchld_handler): Now static.
2894
be02381c
PE
2895 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2896 That way, the code declares only the vars that it needs.
2897 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2898 * s/cygwin.h (PTY_ITERATION): Likewise.
2899 * s/darwin.h (PTY_ITERATION): Likewise.
2900 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2901
57048744
PE
2902 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2903 * process.c (allocate_pty): Don't declare stb unless it's needed.
2904
7914961c 2905 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2906 (CONSTANTLIM): Remove; unused.
2907 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2908 Define only if needed.
7914961c 2909
b3967b18
PE
2910 * unexelf.c (unexec): Name an expression,
2911 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2912 Use a different way to cause a compilation error if anyone uses
2913 n rather than nn, a way that does not involve shadowing.
73366a00 2914 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2915
29a6015a
PE
2916 * deps.mk (unexalpha.o): Remove; unused.
2917
43cfc33e 2918 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2919 * unexec.h: New file.
ce701a33
PE
2920 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2921 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2922 Depend on unexec.h.
2923 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2924 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2925 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2926 Change as necessary to match prototype in unexec.h.
ce701a33 2927
01f44d5a
PE
2928 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2929 shadowing.
4f63c6bb 2930 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2931
a6670b0b
PE
2932 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2933 Rename locals to avoid shadowing.
2934
cef2010d 2935 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2936 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2937
d4d7173a
PE
2938 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2939
f08b802a
PE
2940 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2941 warning when compiling print.c.
2942
3ddb0639
PE
2943 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2944 instead of using an uninitialized var.
5ad03b97 2945 (font_sort_entities): Mark var as initialized.
3ddb0639 2946
170a2692
PE
2947 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2948
e663c700
PE
2949 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2950 pointers to constants.
89bc529a 2951 (font_parse_fcname): Remove unused vars.
7b81e2d0 2952 (font_delete_unmatched): Now static.
ea838e10 2953 (font_get_spec): Remove; unused.
13a547c6
PE
2954 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2955 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2956 Rename or move locals to avoid shadowing.
e663c700 2957
2a80c887 2958 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2959 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2960
1384fa33 2961 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2962 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2963
8b2c52e9
PE
2964 * alloc.c (mark_backtrace): Move decl from here ...
2965 * lisp.h: ... to here, so that it can be checked.
2966
475545b5 2967 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2968 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2969 (lisp_indirect_variable): Name an expression,
2970 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2971 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2972
b1349114 2973 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2974 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2975 Use const pointer when appropriate.
b1349114 2976
a2928364
PE
2977 * lisp.h (get_system_name, get_operating_system_release):
2978 Move decls here, to check interfaces.
2979 * process.c (get_operating_system_release): Move decl to lisp.h.
2980 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2981 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2982 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2983 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2984 (Fformat_time_string, Fencode_time, Finsert_char):
2985 (Ftranslate_region_internal, Fformat):
2986 Rename or remove local vars to avoid shadowing.
9710023e 2987 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2988
a415e694
PE
2989 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2990 avoid shadowing.
2991
8ef4622d
PE
2992 * lisp.h (eassert): Check that the argument compiles, even if
2993 ENABLE_CHECKING is not defined.
2994
946f9a5b
PE
2995 * data.c (Findirect_variable): Name an expression, to avoid
2996 gcc -Wbad-function-cast warning.
112396d6 2997 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2998 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2999 (Fmake_variable_buffer_local, Fmake_local_variable):
3000 Mark variables as initialized.
52746918 3001 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3002
e5aab7e7 3003 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3004 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3005 Rename locals to avoid shadowing.
dff45157
PE
3006 (mark_stack): Move local variables into the #ifdef region where
3007 they're used.
7bc26fdb
PE
3008 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3009 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3010 needed otherwise.
3011 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3012 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3013 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3014
e5aab7e7
PE
3015 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3016 avoids undefined behavior in theory.
3017
4da60324
PE
3018 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3019
88043301
PE
3020 Use functions, not macros, for up- and down-casing (Bug#8254).
3021 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3022 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3023 to use the following functions instead of these macros.
3024 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3025 EMACS_INT, since callers assume the returned value fits in int.
3026 (upcase1): Likewise, for UPCASE_TABLE.
3027 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3028 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3029 the race-condition problem in the old DOWNCASE.
88043301 3030
19ed5445
PE
3031 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3032 Rename locals to avoid shadowing.
3033 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3034 (regex_compile, re_search_2, re_match_2_internal):
3035 Remove unused local vars.
952db0d7
PE
3036 (FREE_VAR): Rewrite so as not to use empty "else",
3037 which gcc can warn about.
da053e48 3038 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3039 (RETALLOC_IF): Define only if needed.
3040 (WORDCHAR_P): Likewise. This one is never needed, but is used
3041 only in a comment talking about a compiler bug, so put inside
3042 the #if 0 of that comment.
3043 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3044 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3045 Remove; unused.
19ed5445 3046
1f3561e4 3047 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3048 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3049 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3050
ded6f8f7
PE
3051 * search.c (simple_search): Remove unused var.
3052
dbd37a95
PE
3053 * dired.c (compile_pattern): Move decl from here ...
3054 * lisp.h: ... to here, so that it can be checked.
3055 (struct re_registers): New forward decl.
3056
7e47afad
PE
3057 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3058
85f24f61
PE
3059 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3060 All uses changed.
3061 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3062 Rename locals to avoid shadowing.
5671df8f 3063 (Fvertical_motion): Mark locals as initialized.
85f24f61 3064
181aa2be 3065 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3066 (casify_region): Mark local as initialized.
181aa2be 3067
930d429c
PE
3068 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3069
7082eac6
PE
3070 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3071 New macros, so that the caller can use some names other than
3072 gcpro1, gcpro2, etc.
3073 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3074 of the new macros.
3075 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3076 argument, for consistency with GCPRO2_VAR, etc: it is now the
3077 prefix of the variable, not the variable itself. All uses
3078 changed.
38b2c076
PE
3079 * dired.c (directory_files_internal, file_name_completion):
3080 Rename locals to avoid shadowing.
3081
15206ed9
PE
3082 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3083 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3084 dired.c's scmp function, had undefined behavior.
3085 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3086 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3087 * buffer.h: ... to here, because these macros use current_buffer,
3088 and the new implementation with inline functions needs to have
3089 current_buffer in scope now, rather than later when the macros
3090 are used.
3091 (downcase, upcase1): New static inline functions.
3092 (DOWNCASE, UPCASE1): Reimplement using these functions.
3093 This avoids undefined behavior in expressions like
3094 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3095 from race conditions in accessing the global variables
3096 case_temp1 and case_temp2.
3097 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3098 * lisp.h (case_temp1, case_temp2): Remove their decls.
3099 * character.h (ASCII_CHAR_P): Move from here ...
3100 * lisp.h: ... to here, so that the inline functions mentioned
3101 above can use them.
3102
4a6bea26
PE
3103 * dired.c (directory_files_internal_unwind): Now static.
3104
f14b7e14
PE
3105 * fileio.c (file_name_as_directory, directory_file_name):
3106 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3107 Now static.
2893f146
PE
3108 (file_name_as_directory): Use const pointers when appropriate.
3109 (Fexpand_file_name): Likewise. In particular, newdir might
3110 point at constant storage, so make it a const pointer.
fd4ead52 3111 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3112 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3113 signedness issues.
f839df0c
PE
3114 (Fset_file_times, Finsert_file_contents, auto_save_error):
3115 Rename locals to avoid shadowing.
f14b7e14 3116
5716756e 3117 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3118 (Ftry_completion, Fall_completions): Rename or remove locals
3119 to avoid shadowing.
5716756e 3120
b4c3046a
PE
3121 * marker.c (bytepos_to_charpos): Remove; unused.
3122
b45db522
PE
3123 * lisp.h (verify_bytepos, count_markers): New decls,
3124 so that gcc does not warn that these functions aren't declared.
3125
85876d07
PE
3126 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3127 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3128 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3129 (copy_text): Remove unused local var.
85876d07 3130
03d78a21 3131 * filelock.c (within_one_second): Now static.
b3dd38ab 3132 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3133
5df8f01b
PE
3134 * buffer.c (fix_overlays_before): Mark locals as initialized.
3135 (fix_start_end_in_overlays): Likewise. This function should be
3136 simplified by using pointers-to-pointers, but that's a different
3137 matter.
b1d876f1 3138 (switch_to_buffer_1): Now static.
8f54f30a
PE
3139 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3140 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3141
a70072c9 3142 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3143 Fix pointer signedness issue.
edced198
PE
3144 (sys_subshell): Mark local as volatile if checking for lint,
3145 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3146 (MAXPATHLEN): Define only if needed.
a70072c9 3147
a0977c44
PE
3148 * process.c (serial_open, serial_configure): Move decls from here ...
3149 * systty.h: ... to here, so that they can be checked.
3150
a884fdcc
PE
3151 * fns.c (get_random, seed_random): Move extern decls from here ...
3152 * lisp.h: ... to here, so that they can be checked.
3153
604efe86 3154 * sysdep.c (reset_io): Now static.
b8950c94 3155 (wait_for_termination_signal): Remove; unused.
604efe86 3156
38fc62d9
PE
3157 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3158 (copy_keymap_item, append_key, push_text_char_description):
3159 Now static.
1004a21a 3160 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3161 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3162 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3163 (describe_map_tree):
3164 Rename locals to avoid shadowing.
38fc62d9 3165
2f2650da
PE
3166 * keyboard.c: Declare functions static if they are not used elsewhere.
3167 (echo_char, echo_dash, cmd_error, top_level_2):
3168 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3169 (read_char, kbd_buffer_get_event, make_lispy_position):
3170 (make_lispy_event, make_lispy_movement, apply_modifiers):
3171 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3172 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3173 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3174 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3175 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3176
a053e86c 3177 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3178 (mark_kboards): Move decl here ...
3179 * alloc.c (mark_kboards): ... from here.
a053e86c 3180
4752793e
PE
3181 * lisp.h (force_auto_save_soon): New decl.
3182
74f10ca7 3183 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3184 (DEFINE_DUMMY_FUNCTION): New macro.
3185 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3186 Use it.
c03cd23f
PE
3187 (main): Add casts to avoid warnings
3188 if GCC considers string literals to be constants.
74f10ca7 3189
022e70d4
PE
3190 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3191
59d6fe83
PE
3192 * dbusbind.c: Pointer signedness fixes.
3193 (xd_signature, xd_append_arg, xd_initialize):
3194 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3195 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3196 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3197 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3198
78320123
PE
3199 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3200 if GCC considers string literals to be constants.
49cebcca 3201 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3202
35ac2a97
SM
32032011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3204
fb103ca9
SM
3205 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3206 (print_preprocess, print_object): New macro to fix last change.
3207
35ac2a97
SM
3208 * print.c (print_preprocess): Don't forget font objects.
3209
62973b41
JB
32102011-03-16 Juanma Barranquero <lekktu@gmail.com>
3211
3212 * emacs.c (USAGE3): Doc fixes.
3213
0e48bb22
AS
32142011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3215
3216 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3217 structure.
3218
7684e57b
JB
32192011-03-14 Juanma Barranquero <lekktu@gmail.com>
3220
3221 * lisp.h (VWindow_system, Qfile_name_history):
3222 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3223 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3224 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3225
3226 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3227 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3228
3229 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3230 * w32console.c (detect_input_pending, read_input_pending)
3231 (encode_terminal_code):
3232 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3233 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3234 (w32_system_caret_y, Qfile_name_history):
3235 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3236 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3237 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3238 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3239 * w32proc.c (Qlocal, report_file_error):
3240 * w32term.c (Vwindow_system, updating_frame):
3241 * w32uniscribe.c (initialized, uniscribe_font_driver):
3242 Remove unneeded extern declarations.
3243
2aa46d6c
CY
32442011-03-14 Chong Yidong <cyd@stupidchicken.com>
3245
c96bbc66 3246 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3247
cffc6f3b
CY
32482011-03-13 Chong Yidong <cyd@stupidchicken.com>
3249
3250 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3251 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3252 These macros can no longer be used for assignment.
3253
44f230aa
SM
3254 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3255 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3256 (record_buffer_markers, fetch_buffer_markers): New functions for
3257 recording and fetching special buffer markers.
3258 (set_buffer_internal_1, set_buffer_temp): Use them.
3259
3260 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3261
3262 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3263
3264 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3265 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3266
3267 * xdisp.c (hscroll_window_tree):
3268 (reconsider_clip_changes): Use PT instead of BUF_PT.
3269
d251f04b
EZ
32702011-03-13 Eli Zaretskii <eliz@gnu.org>
3271
3272 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3273 $(EMACS_ROOT)/lib/intprops.h.
3274
f0c77cd1
PE
32752011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3276
3eca4629
PE
3277 Fix more problems found by GCC 4.5.2's static checks.
3278
7c86ee98
PE
3279 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3280 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3281 (xg_free_frame_widgets): Make it clear that a local variable is
3282 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3283 (gdk_window_get_screen): Make it clear that this macro is needed
3284 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3285 (int_gtk_range_get_value): New function, which avoids a diagnostic
3286 from gcc -Wbad-function-cast.
3287 (xg_set_toolkit_scroll_bar_thumb): Use it.
3288 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3289 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3290 (get_utf8_string, xg_get_file_with_chooser):
3291 Rename locals to avoid shadowing.
3292 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3293
41729b81
PE
3294 * xgselect.c (xg_select): Remove unused var.
3295
f0c77cd1
PE
3296 * image.c (four_corners_best): Mark locals as initialized.
3297 (gif_load): Initialize transparent_p to zero (Bug#8238).
3298 Mark another local as initialized.
ec6cf4c6 3299 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3300
ce0ad53d 3301 * image.c (clear_image_cache): Now static.
d5d5a617 3302 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3303 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3304 (x_edge_detection): Remove unnecessary cast that
3305 gcc -Wbad-function-cast diagnoses.
2037898d 3306 (gif_load): Fix pointer signedness.
6ae141d6
PE
3307 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3308 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3309
33383987 33102011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3311
d32df629
PE
3312 Improve quality of tests for time stamp overflow.
3313 For example, without this patch (encode-time 0 0 0 1 1
3314 1152921504606846976) returns the obviously-bogus value (-948597
3315 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3316 reports time overflow. See
3317 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3318 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3319 * editfns.c: Include limits.h and intprops.h.
3320 (TIME_T_MIN, TIME_T_MAX): New macros.
3321 (time_overflow): Move earlier, to before first use.
3322 (hi_time, lo_time): New functions, for an accurate test for
3323 out-of-range times.
3324 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3325 (Fget_internal_run_time): Don't assume time_t fits in int.
3326 (make_time): Use list2 instead of Fcons twice.
3327 (Fdecode_time): More accurate test for out-of-range times.
3328 (check_tm_member): New function.
3329 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3330 (lisp_time_argument): Don't rely on undefined left-shift and
3331 right-shift behavior when checking for time stamp overflow.
8be6f318 3332
fe31d94c
PE
3333 * editfns.c (time_overflow): New function, refactoring common code.
3334 (Fformat_time_string, Fdecode_time, Fencode_time):
3335 (Fcurrent_time_string): Use it.
3336
8be6f318
PE
3337 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3338 * dired.c (make_time): Move to ...
3339 * editfns.c (make_time): ... here.
3340 * systime.h: Note the move.
3341
09d9db2c 33422011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3343
126bc0dc
YM
3344 * fringe.c (update_window_fringes): Remove unused variables.
3345
c47cbdfd
YM
3346 * unexmacosx.c (copy_data_segment): Also copy __got section.
3347 (Bug#8223)
3348
7ac80be9
EZ
33492011-03-12 Eli Zaretskii <eliz@gnu.org>
3350
c96bbc66 3351 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3352 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3353 Constify `char *' arguments and their references according to
3354 prototypes in tparam.h.
3355
ecb0f94d 3356 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3357
7ac80be9
EZ
3358 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3359 Adapt all references accordingly.
3360
3361 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3362
ef1fd07e
TT
33632011-03-11 Tom Tromey <tromey@redhat.com>
3364
3365 * buffer.c (syms_of_buffer): Remove obsolete comment.
3366
7ef4b50c
EZ
33672011-03-11 Eli Zaretskii <eliz@gnu.org>
3368
3369 * termhooks.h (encode_terminal_code): Declare prototype.
3370
3371 * msdos.c (encode_terminal_code): Don't declare prototype.
3372
3373 * term.c (encode_terminal_code): Now external again, used by
3374 w32console.c and msdos.c.
3375
44f230aa
SM
3376 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3377 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3378
4b1ec863 33792011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3380
1714f52b 3381 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3382
4b1ec863
PE
3383 * fringe.c (update_window_fringes): Mark locals as initialized
3384 (Bug#8227).
3385 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3386
524c7aa6
PE
3387 * alloc.c (mark_fringe_data): Move decl from here ...
3388 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3389 to check its interface.
3390 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3391
a5c0af81 3392 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3393 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3394 (fontset_font): Mark local as initialized.
a9a06e0b 3395 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3396
b4716021
PE
3397 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3398
811e9bac 3399 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3400 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3401 (x_own_selection, Fx_disown_selection_internal): Rename locals
3402 to avoid shadowing.
3403 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3404
7e3ab302
PE
3405 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3406 so that the caller can use some name other than gcpro1.
3407 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3408 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3409 (Fx_backspace_delete_keys_p):
3410 Use them to avoid shadowing, and rename vars to avoid shadowing.
3411 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3412 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3413 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3414 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3415 Remove unused locals.
7e3ab302
PE
3416 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3417 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3418 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3419 macros.
f78faa98 3420
e2b13473
PE
3421 * xterm.h (x_mouse_leave): New decl.
3422
77f23912
PE
3423 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3424 Remove unused functions.
cdf4ba58
PE
3425 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3426 (x_calc_absolute_position): Now static.
7411c686 3427 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3428 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3429 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3430 unless they are used.
38d0b34a
PE
3431 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3432 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3433 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3434 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3435 (x_error_catcher, x_connection_closed, x_error_handler):
3436 (x_error_quitter, xembed_send_message, x_iconify_frame):
3437 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3438 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3439 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3440
44f230aa
SM
3441 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3442 Rename or move locals to avoid shadowing.
6b463e58 3443 (tty_defined_color, merge_face_heights): Now static.
5967d051 3444 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3445 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3446 does not deduce is never used uninitialized.
73719eba
PE
3447 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3448 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3449
426994c3 3450 * terminal.c (store_terminal_param): Now static.
5489860b 3451
032f1620 3452 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3453 (set_frame_menubar): Remove unused local.
d4323972 3454 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3455 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3456 since they might point to immutable storage.
281585b0
PE
3457 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3458 since it's unused otherwise.
032f1620 3459
367c19e5 3460 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3461 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3462 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3463 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3464 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3465 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3466 does not deduce are never used uninitialized.
70739cbe 3467
07b48fa9
PE
3468 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3469
8868a238 3470 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3471 * window.c (window_loop, size_window):
3472 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3473
7e5cf297 3474 * window.c (display_buffer): Now static.
d6550a9f
PE
3475 (size_window): Mark variables that gcc -Wuninitialized
3476 does not deduce are never used uninitialized.
a586633d
PE
3477 * window.h (check_all_windows): New decl, to forestall
3478 gcc -Wmissing-prototypes diagnostic.
5b555da1 3479 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3480
f6095868
PE
3481 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3482 shadowing.
3483 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3484 Include <limits.h>.
3485 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3486 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3487 (load_charset_map): Mark variables that gcc -Wuninitialized
3488 does not deduce are never used uninitialized.
53df7c11 3489 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3490
f38b440c
PE
3491 * coding.c (coding_set_source, coding_set_destination):
3492 Use "else { /* comment */ }" rather than "else /* comment */;"
3493 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3494 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3495 a block, when the outer 'i' will do.
3496 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3497 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3498 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3499 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3500 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3501 Rename locals to avoid shadowing.
3502 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3503 * coding.c (emacs_mule_char, encode_invocation_designation):
3504 Now static, since they're not used elsewhere.
413bb2db 3505 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3506 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3507 (decode_coding_emacs_mule): Mark variables that gcc
3508 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3509 (detect_coding_iso_2022): Initialize a local variable that might
3510 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3511 this initialization is needed. (Bug#8211)
5f58e762
PE
3512 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3513 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3514 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3515 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3516 Remove unused macros.
f38b440c 3517
232b38b9 3518 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3519 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3520 * character.c (string_count_byte8): Likewise.
232b38b9 3521
fb90da1b
PE
3522 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3523 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3524
fb93dbc2
PE
3525 * chartab.c (copy_sub_char_table): Now static, since it's not used
3526 elsewhere.
5c156ace
PE
3527 (sub_char_table_ref_and_range, char_table_ref_and_range):
3528 Rename locals to avoid shadowing.
bbcd0949 3529 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3530
7d3b3862 3531 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3532 (BIDI_BOB): Remove unused macro.
7d3b3862 3533
6be7d3da
PE
3534 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3535 deduce are never used uninitialized.
c2ed9c8b 3536 * term.c (encode_terminal_code): Likewise.
6be7d3da 3537
75f8807f 3538 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3539
50938595
PE
3540 * tparam.h: New file.
3541 * term.c, tparam.h: Include it.
3542 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3543 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3544 Move these decls to tparam.h, and make them agree with what
3545 is actually in tparam.c. The previous trick of using incompatible
3546 decls in different modules does not conform to the C standard.
3547 All callers of tparam changed to use tparam's actual API.
3548 * tparam.c (tparam1, tparam, tgoto):
3549 Use const pointers where appropriate.
3550
fbceeba2
PE
3551 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3552 * cm.h (struct cm): Likewise.
3553 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3554 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3555 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3556 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3557 (turn_on_face, init_tty): Likewise.
3558 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3559
7f3f1250
PE
3560 * term.c (term_mouse_position): Rename local to avoid shadowing.
3561
e6ca6543
PE
3562 * alloc.c (mark_ttys): Move decl from here ...
3563 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3564
c40f8d15
AS
35652011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3566
3567 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3568
cfe0661d
JB
35692011-03-09 Juanma Barranquero <lekktu@gmail.com>
3570
3571 * search.c (compile_pattern_1): Remove argument regp, unused since
3572 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3573 (compile_pattern): Don't pass it.
3574
0afb4571
J
35752011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3576
3577 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3578 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3579 for ! HAVE_GTK3.
3580 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3581
3582 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3583
3584 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3585 gdk_window_get_screen, gdk_window_get_geometry,
3586 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3587 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3588 (xg_get_pixbuf_from_pixmap): New function.
3589 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3590 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3591 Call xg_get_pixbuf_from_pixmap instead of
3592 gdk_pixbuf_get_from_drawable.
3593 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3594 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3595 (xg_check_special_colors): Use GtkStyleContext and its functions
3596 for HAVE_GTK3.
3597 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3598 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3599 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3600 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3601 Call gtk_widget_get_preferred_size.
0afb4571
J
3602 (xg_frame_resized): gdk_window_get_geometry only takes 5
3603 parameters.
44f230aa
SM
3604 (xg_win_to_widget, xg_event_is_for_menubar):
3605 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3606 (xg_set_widget_bg): New function.
3607 (delete_cb): New function.
895009e1 3608 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3609 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3610 (xg_set_background_color): Call xg_set_widget_bg.
3611 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3612 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3613 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3614 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3615 if ! HAVE_GTK3.
3616 (update_frame_tool_bar): Call gtk_widget_hide.
3617 (xg_initialize): Use GDK_KEY_g.
3618
3619 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3620 if ! HAVE_GTK3
3621 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3622
3623 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3624 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3625 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3626
1c2cc4ef
JB
36272011-03-08 Juanma Barranquero <lekktu@gmail.com>
3628
3629 * w32xfns.c (select_palette): Check success of RealizePalette against
3630 GDI_ERROR, not zero.
3631
33383987 3632See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3633
3634;; Local Variables:
3635;; coding: utf-8
aac0c6e3
MR
3636;; End:
3637
33383987 3638 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3639
3640 This file is part of GNU Emacs.
3641
3642 GNU Emacs is free software: you can redistribute it and/or modify
3643 it under the terms of the GNU General Public License as published by
3644 the Free Software Foundation, either version 3 of the License, or
3645 (at your option) any later version.
3646
3647 GNU Emacs is distributed in the hope that it will be useful,
3648 but WITHOUT ANY WARRANTY; without even the implied warranty of
3649 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3650 GNU General Public License for more details.
3651
3652 You should have received a copy of the GNU General Public License
3653 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.