* gtkutil.h: Tiny cleanups.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7a6136fd
DA
12012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * gtkutil.h: Tiny cleanups.
4 (use_old_gtk_file_dialog): Remove useless declaration.
5 (xg_uses_old_file_dialog): Add suggested const attribute.
6
ce811ad9
EZ
72012-07-15 Eli Zaretskii <eliz@gnu.org>
8
9 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
10 (bidi_paragraph_init): Use it to limit search forward for a strong
11 directional character in abnormally large paragraphs full of
12 neutral or weak characters. (Bug#11943)
13
c9adfeaa
SF
142012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
15
16 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
17 the toolbar (Bug#9451).
18 (xg_make_tool_item): Give the widget event box a transparent
19 background.
20
fff62aa9
DA
212012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
22
23 Cleanup basic allocation variables and functions.
24 * alloc.c (ignore_warnings, init_intervals, init_float)
25 (init_cons, init_symbol, init_marker): Remove.
26 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
27 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
28 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
29 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
30 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
31 (staticidx, init_alloc_once, init_strings, free_ablock):
32 Remove redundant initialization.
33 * fns.c (init_weak_hash_tables): Remove.
34 * lisp.h (init_weak_hash_tables): Remove prototype.
35
9730daca
DA
362012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
37
38 Use zero_vector where appropriate.
39 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
40 accordingly.
41 * lisp.h (zero_vector): New declaration.
42 * font.c (null_vector): Remove.
43 (syms_of_font): Remove initialization and staticpro.
44 (font_list_entities, font_find_for_lface): Change to use zero_vector.
45 * keymap.c (Faccessible_keymaps): Likewise.
46
2e2d2a13
LL
472012-07-15 Leo Liu <sdl.web@gmail.com>
48
49 * fringe.c: Fix typo in comments.
50
cd276f6e
LL
512012-07-14 Leo Liu <sdl.web@gmail.com>
52
53 * fringe.c: Add a new bitmap exclamation-mark.
54
5a1131d9
EZ
552012-07-14 Eli Zaretskii <eliz@gnu.org>
56
57 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
58
59 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
60 (HAVE_MENUS): Don't define, defined by editing config.in with
61 msdos/sed2v2.inp.
62 (GMALLOC_INHIBIT_VALLOC): Don't define.
63 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
64
22e983b7
JB
652012-07-14 Juanma Barranquero <lekktu@gmail.com>
66
67 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
68
5b3f250f
GM
692012-07-14 Glenn Morris <rgm@gnu.org>
70
71 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
72 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
73 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
74
33d63ff4
GM
752012-07-13 Glenn Morris <rgm@gnu.org>
76
5b633342
GM
77 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
78
33d63ff4
GM
79 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
80 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
81
b55b9f85
JD
822012-07-13 Jan Djärv <jan.h.d@swipnet.se>
83
0dc8cf50
JD
84 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
85 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
86 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
87 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
88 where appropriate.
89 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
90 as boolean expression.
91 (x_set_window_size): Remove unused variable toolbar.
92 (ns_get_color_default, ns_mod_to_lisp): Remove.
93 (ns_mouse_position): Remove unused variables xchar and ychar.
94 (ns_compute_glyph_string_overhangs): Remove unused variable face.
95 (ns_set_vertical_scroll_bar): Remove unused variable count.
96 (ns_delete_terminal): Remove unused variable i.
97 (ns_term_init): Remove unused variables r, g and b.
98 (mouseDown): Remove unused variable window.
99 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
100 (initFrameFromEmacs): Remove unused variable vbextra.
101 (mouseEntered): Remove unused variables p and dpyinfo.
102 (mouseExited): Remove unused variables p and r.
103 (ns_define_frame_cursor, ns_clear_frame_area)
104 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
105 (menuDown): Assign [sender tag] to variable and cast the variable.
106
107 * nsterm.h (menuDown): Add id as type to argument sender.
108 (ns_display_info_for_name): Add Lisp_Object argument.
109 (ns_term_init): Add Lisp_Object argument.
110 (ns_map_event_to_object): Add void argument.
111 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
112 prototype with arguments and only declare if __OBJC__.
113 (nxatoms_of_nsselect): Add void argument.
114 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
115 (ns_alloc_autorelease_pool): Add void argument.
116 (ns_release_autorelease_pool): Add void* argument.
117 (ns_get_defaults_value): Add const char* argument.
118
119 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
120 (initFromContents): Use SSDATA where appropriate.
121 (ns_update_menubar): Add braces to ambigous if-else.
122 (initWithTitle): Put () around assignment in if statement.
123 (ns_menu_show): Remove unused variables window and keymap.
124 (update_frame_tool_bar): Remove unused variable selected_p.
125 (initWithContentRect): Remove unused variable this_cmd_name.
126
127 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
128 appropriate.
129 (setXBMColor): Remove unused variable len.
130 (setPixmapData): Put () around assignment in loop statement.
131
132 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
133 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
134 where appropriate.
135 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
136 around assignment in loop statement.
137 (nsfont_open): Remove unused variable i.
138 (nsfont_open): Remove unused variable len.
139 (nsfont_draw): Remove unused variable cs.
140
141 * nsfns.m (x_set_icon_name, ns_set_name_internal)
142 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
143 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
144 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
145 (Fns_font_name, Fns_perform_service)
146 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
147 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
148 (ns_set_name): Remove unused variable view.
149 (x_set_menu_bar_lines): Remove unused variable olines.
150 (x_set_tool_bar_lines): Remove unused variable root_window.
151 (Fns_list_colors): Put () around assignment in while statement.
152 (Fns_perform_service): Remove unused variable len.
153 (Fns_display_usable_bounds): Remove unused variable top.
154 (syms_of_nsfns): Remove unused variable i.
155
b55b9f85
JD
156 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
157 memcpy (Bug#11907).
158
ed9265fc 1592012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
160
161 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
162 and free it with DestroyExceptionInfo (Bug#11558).
163
ef099b57
JB
1642012-07-13 Juanma Barranquero <lekktu@gmail.com>
165
166 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
167 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
168 Set here, not in nt/config.nt.
169
ea814a5d
EZ
1702012-07-13 Eli Zaretskii <eliz@gnu.org>
171
172 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
173 cursor overflow into the last glyph on display line when the right
174 fringe is off. (Bug#11832)
175
1a952767
PE
1762012-07-13 Paul Eggert <eggert@cs.ucla.edu>
177
178 * xdisp.c (produce_special_glyphs): Now static.
179 * dispextern.h (produce_special_glyphs): Remove decl.
180
983188fd
GM
1812012-07-13 Glenn Morris <rgm@gnu.org>
182
32fb4bb6
GM
183 * s/bsd-common, s/cygwin.h: Remove empty files.
184 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
185
983188fd
GM
186 * s/usg5-4-common.h (USG, USG5):
187 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
188 * s/sol2-6.h (SOLARIS2):
189 * s/irix6-5.h (IRIX6_5):
190 * s/hpux10-20.h (USG, USG5, HPUX):
191 * s/gnu-linux.h (USG, GNU_LINUX):
192 * s/freebsd.h (BSD_SYSTEM):
193 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
194 * s/cygwin.h (CYGWIN):
195 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
196 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
197
d1e68667 1982012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
199
200 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 201
6de0e799
GM
2022012-07-13 Glenn Morris <rgm@gnu.org>
203
739ae010
GM
204 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
205
dbee5793
GM
206 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
207
6de0e799
GM
208 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
209 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
210
b82da769
GM
2112012-07-12 Glenn Morris <rgm@gnu.org>
212
4fae5a7a 213 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
214
215 * process.c (init_process_emacs): Rename from init_process.
216 The old name is also the name of a Mach system call.
217 * lisp.h, emacs.c: Update for this name change.
218 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
219 longer needed.
220
5a979817
EZ
2212012-07-12 Eli Zaretskii <eliz@gnu.org>
222
223 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
224 memmove call that removes glyphs covered by the left truncation
225 glyph. Improve commentary.
226 (display_line): Fix display of continuation glyphs on GUI frames
227 when the right fringe is turned off and variable-size fonts are
228 used in the window. Move the code that appends a stretch glyph to
229 produce_special_glyphs, so that it could be used for truncation
230 and continuation glyphs alike.
231 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
232 glyph of a suitably computed width, to align the special glyphs at
233 the window margin. Code moved from display_line. (Bug#11832)
234
3e91a053
GM
2352012-07-12 Glenn Morris <rgm@gnu.org>
236
ba9e4b84
GM
237 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
238
239 * s/gnu-linux.h, s/hpux10-20.h:
240 Do not unconditionally define HAVE_XRMSETDATABASE.
241
3e91a053
GM
242 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
243
b300b1f4
PE
2442012-07-12 Paul Eggert <eggert@cs.ucla.edu>
245
246 Fix typos that broke OS X build.
247 Reported by Randal L. Schwartz in
248 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
249 * nsterm.m (ns_timeout): Add missing local decl.
250 (ns_get_color): snprintf -> sprintf, to fix typo.
251
6e777848
GM
2522012-07-12 Glenn Morris <rgm@gnu.org>
253
3f922c37
GM
254 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
255 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
256 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
257 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
258
0ab7b23a
GM
259 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
260 Move PTY_OPEN to configure.
261
6e777848
GM
262 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
263 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
264 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
265
4a7edc24
DA
2662012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
267
268 Use empty_unibyte_string where applicable.
269 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
270 * lread.c (read1): Likewise.
271 * xsettings.c (syms_of_xsettings): Likewise.
272
308aab79
GM
2732012-07-12 Glenn Morris <rgm@gnu.org>
274
42bd1719
GM
275 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
276 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
277 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
278 * s/hpux10-20.h (RUN_TIME_REMAP):
279 * s/bsd-common.h (TABDLY): Move to configure.
280
281 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
282
283 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
284
ea0bbd17 285 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 286 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
287
288 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 289
308aab79
GM
290 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
291 * s/template.h: Move NARROWPROTO to configure.
292
ee1cf5cf
GM
2932012-07-11 Glenn Morris <rgm@gnu.org>
294
30fe9bf4
GM
295 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
296 unused since 2011-01-17 change to systty.h.
297
ee1cf5cf
GM
298 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
299 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
300 Move HAVE_PTYS and HAVE_SOCKETS to configure.
301
63e47e07
PE
3022012-07-11 Paul Eggert <eggert@cs.ucla.edu>
303
304 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
305
c43fb4c3
GM
3062012-07-11 Glenn Morris <rgm@gnu.org>
307
308 * s/darwin.h, s/gnu-linux.h, s/template.h:
309 Move INTERRUPT_INPUT to configure.
310
e8df9267
DA
3112012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
312
313 Minor adjustments to interning code.
314 * lisp.h (intern, intern_c_string): Redefine as static inline
315 wrappers for intern_1 and intern_c_string_1, respectively.
316 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
317 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
318 Vobarray checking.
e8df9267
DA
319 * font.c (font_intern_prop): Likewise. Adjust comment.
320 * w32font.c (intern_font_name): Likewise.
321
34348bd4
AS
3222012-07-11 Andreas Schwab <schwab@linux-m68k.org>
323
d96a1e0c
AS
324 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
325
34348bd4
AS
326 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
327 of Fcar/Fcdr if possible.
328 * font.c (check_otf_features): Likewise.
329 * fontset.c (Fnew_fontset): Likewise.
330 * gnutls.c (Fgnutls_boot): Likewise.
331 * minibuf.c (read_minibuf): Likewise.
332 * msdos.c (IT_set_frame_parameters): Likewise.
333 * xmenu.c (Fx_popup_dialog): Likewise.
334 * w32menu.c (Fx_popup_dialog): Likewise.
335
c8add24e
GM
3362012-07-11 Glenn Morris <rgm@gnu.org>
337
4b575b3c
GM
338 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
339 since nothing has defined it on these platforms.
340
09f4e3b0
GM
341 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
342 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
343
172bedef
GM
344 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
345 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
346 Move CLASH_DETECTION to configure.
347
249685df
GM
348 * s/gnu.h: Remove file, which is now empty.
349
c8add24e
GM
350 * s/gnu.h, s/gnu-linux.h:
351 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
352
b41253a3
JW
3532012-07-11 John Wiegley <johnw@newartisans.com>
354
355 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
356 function attribute, so we only use it if it exists in the
357 compiler.
358
d923b542
DA
3592012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
360
361 Avoid call to strlen in fast_c_string_match_ignore_case.
362 * search.c (fast_c_string_match_ignore_case): Change to use
363 length argument. Adjust users accordingly.
364 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
365
5ebbef1d
PE
3662012-07-11 Paul Eggert <eggert@cs.ucla.edu>
367
bb352260
PE
368 Assume mkdir, rmdir.
369 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
370 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
371
57054ddd
PE
372 Assume rename.
373 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
374
b747d3f7
PE
375 Assume perror.
376 * s/hpux10-20.h (HAVE_PERROR): Remove.
377 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
378 Remove dummy definition, as this problem was obsolete long ago.
379
5ebbef1d
PE
380 Assume strerror.
381 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
382
984e7f30
DA
3832012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
384
385 Avoid calls to strlen in font processing functions.
386 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 387 (font_open_by_name): Change to use length argument. Adjust
984e7f30 388 users accordingly.
d923b542
DA
389 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
390 Adjust prototypes.
391 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
392 Change to return ptrdiff_t.
984e7f30
DA
393 (xfont_list_pattern, xfont_match): Use length returned by
394 xfont_decode_coding_xlfd.
395 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
396
20e94fdd
GM
3972012-07-11 Glenn Morris <rgm@gnu.org>
398
9d596af3
GM
399 * s/darwin.h, s/freebsd.h, s/netbsd.h:
400 Move DONT_REOPEN_PTY to configure.
401
20e94fdd
GM
402 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
403 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
404
e99a530f
PE
4052012-07-10 Paul Eggert <eggert@cs.ucla.edu>
406
22ffb973
PE
407 Remove "#define unix" that is no longer needed (Bug#11905).
408 * s/aix4-2.h (unix): Remove; no longer needed.
409
e9a9ae03
PE
410 EMACS_TIME simplification (Bug#11875).
411 This replaces macros (which typically do not work in GDB)
412 with functions, typedefs and enums, making the code easier to debug.
413 The functional style also makes code easier to read and maintain.
414 * systime.h: Include <sys/time.h> on all hosts, not just if
415 WINDOWSNT, since 'struct timeval' is needed in general.
416 (EMACS_TIME): Now a typedef, not a macro.
417 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
418 not macros.
419 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
420 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
421 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
422 (EMACS_TIME_LE): Now functions, not macros.
423 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
424 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
425 which are not functions. All uses rewritten to use:
426 (make_emacs_time): New function.
427 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
428 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
429 not functions. All uses rewritten to use the following, respectively:
430 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
431 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 432 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
433 * fileio.c (Fcopy_file):
434 * xterm.c (XTflash): Get the current time closer to when it's used.
435 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
436
ffacb126
PE
437 * bytecode.c (targets): Suppress -Woverride-init warnings.
438
e99a530f
PE
439 Simplify by avoiding confusing use of strncpy etc.
440 * doc.c (Fsnarf_documentation):
441 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
442 * frame.c (Fmake_terminal_frame):
443 * gtkutil.c (get_utf8_string):
444 * lread.c (openp):
445 * nsmenu.m (ns_update_menubar):
446 * regex.c (regerror):
447 Prefer memcpy to strncpy and strncat when either will do.
448 * fileio.c (Fsubstitute_in_file_name):
449 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
450 (menu_separator_name_p):
451 * nsmenu.m (ns_update_menubar):
452 Prefer memcmp to strncmp when either will do.
453 * nsterm.m: Include <ftoastr.h>.
454 (ns_get_color):
455 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
456 Prefer snprintf to strncpy.
457 * nsterm.m (ns_term_init):
458 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
459 * nsterm.m (ns_term_init):
460 Avoid the need for strncpy, by using build_string or
461 make_unibyte_string directly. Use dtoastr, not snprintf.
462 * process.c (Fmake_network_process): Diagnose service names that
463 are too long, rather than silently truncating them or creating
464 non-null-terminated names.
465 (Fnetwork_interface_info): Likewise, for interface names.
466 * sysdep.c (system_process_attributes) [GNU_LINUX]:
467 Prefer sprintf to strncat.
468 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
469 Prefer vsnprintf to vsprintf + strncpy.
470
c59592b3
GM
4712012-07-10 Glenn Morris <rgm@gnu.org>
472
473 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
474 Clarify fallback case.
475
7d7bbefd
DA
4762012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
477
478 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
479 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
480 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 481 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
482 where argument type is known to be a Lisp_Cons.
483
3a4c8000
TT
4842012-07-10 Tom Tromey <tromey@redhat.com>
485
486 * bytecode.c (BYTE_CODE_THREADED): New macro.
487 (BYTE_CODES): New macro. Replaces all old byte-code defines.
488 (enum byte_code_op): New type.
489 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
490 (exec_byte_code): Use them. Use token threading when applicable.
491
2a0213a6
DA
4922012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
493
494 Optimize pure C strings initialization.
495 * lisp.h (make_pure_string): Fix prototype.
496 (build_pure_c_string): New function, defined as static inline. This
497 provides a better opportunity to optimize away calls to strlen when
498 the function is called with compile-time constant argument.
499 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
500 argument, adjust users accordingly. Use build_pure_c_string where
501 appropriate.
502 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
503 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
504 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
505
cb1caeaf
DA
5062012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
507
508 Avoid calls to strlen in miscellaneous functions.
509 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
510 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
511 * lread.c (openp): Likewise.
512
c293e30c
DA
5132012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
514
515 Avoid calls to strlen in path processing functions.
516 * fileio.c (file_name_as_directory): Add comment. Change to add
517 srclen argument and return the length of result. Adjust users
518 accordingly.
519 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 520 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
521 users accordingly.
522 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
523
9e059e3f
GM
5242012-07-10 Glenn Morris <rgm@gnu.org>
525
d02eb359
GM
526 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
527 Move PENDING_OUTPUT_COUNT definition to configure.
528
882cf227
GM
529 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
530 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
531 * s/gnu.h (DATA_START): Move definitions to configure.
532
af6e839f
GM
533 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
534 We include usg5-4-common.h, which defines them both.
535
40289a12
GM
536 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
537 O_RDONLY already includes it).
538
9e059e3f
GM
539 Stop ns builds setting the EMACSLOADPATH environment variable.
540 * nsterm.m (ns_load_path): Rename from ns_init_paths.
541 Now it does not set EMACSLOADPATH, just returns the load-path string.
542 * nsterm.h: Update accordingly.
543 * lread.c [HAVE_NS]: Include nsterm.h.
544 (init_lread) [HAVE_NS]: Use ns_load_path.
545 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
546
7c4e8ec0
GM
5472012-07-09 Glenn Morris <rgm@gnu.org>
548
d4f600ff
GM
549 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
550 since the included bsd-common.h does so.
551
cbb31951
GM
552 Stop ns builds setting the EMACSPATH environment variable.
553 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
554 (ns_init_paths): Do not set EMACSPATH.
555 * nsterm.h (ns_exec_path): Add it.
556 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
557 Use ns_exec_path.
558
7c4e8ec0
GM
559 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
560
26bccfae
PE
5612012-07-09 Paul Eggert <eggert@cs.ucla.edu>
562
a0bee46f
PE
563 * process.c (wait_reading_process_output): 'waitchannels' was unset
564 when read_kbd || !NILP (wait_for_cell); fix this.
565
5994c183
PE
566 Add GCC-style 'const' attribute to functions that can use it.
567 * character.h (char_resolve_modifier_mask):
568 * keyboard.h (make_ctrl_char):
569 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
570 (init_character_once, next_almost_prime, init_fns, init_image)
571 (flush_pending_output, init_sound):
572 * mem-limits.h (start_of_data):
573 * menu.h (finish_menu_items):
574 Add ATTRIBUTE_CONST.
575 * emacs.c (DEFINE_DUMMY_FUNCTION):
576 Declare the dummy function with ATTRIBUTE_CONST.
577 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
578 Add decls with ATTRIBUTE_CONST.
579
26bccfae
PE
580 Minor improvements to make_formatted_string.
581 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
582 where int is good enough, as vsprintf returns an int.
583 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
584
a8290ec3
DA
5852012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
586
587 Use make_formatted_string to avoid double length calculation.
588 * lisp.h (make_formatted_string): New prototype.
589 * alloc.c (make_formatted_string): New function.
590 * buffer.c (Fgenerate_new_buffer_name): Use it.
591 * dbus.c (syms_of_dbusbind): Likewise.
592 * editfns.c (Fcurrent_time_zone): Likewise.
593 * filelock.c (get_boot_time): Likewise.
594 * frame.c (make_terminal_frame, set_term_frame_name)
595 (x_report_frame_params): Likewise.
596 * image.c (gs_load): Likewise.
597 * minibuf.c (get_minibuffer): Likewise.
598 * msdos.c (dos_set_window_size): Likewise.
599 * process.c (make_process): Likewise.
600 * xdisp.c (ensure_echo_area_buffers): Likewise.
601 * xsettings.c (apply_xft_settings): Likewise.
602
d01ba2f1
GM
6032012-07-09 Glenn Morris <rgm@gnu.org>
604
605 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
606 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
607 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
608 * nsterm.h (ns_etc_directory): Add it.
609 * callproc.c [HAVE_NS]: Include nsterm.h.
610 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
611
f1f924b6
DA
6122012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
613
614 Move marker debugging code under MARKER_DEBUG.
615 * marker.c (MARKER_DEBUG): Move marker debugging code under
616 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
617 for bootstrap with --enable-checking (~3x slowdown reported
618 by Juanma Barranquero <lekktu@gmail.com>).
619 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
620
ab531b66
PE
6212012-07-08 Paul Eggert <eggert@cs.ucla.edu>
622
623 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
624 See <http://bugs.gnu.org/11825#29>.
625
c4b3bc8a
EZ
6262012-07-08 Eli Zaretskii <eliz@gnu.org>
627
628 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
629 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
630 (display_line): Add commentary about displaying truncation glyphs
631 on GUI frames.
632 (produce_special_glyphs): Move here from term.c.
633
634 * term.c (produce_special_glyphs): Move to xdisp.c.
635
636 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
637 section.
c4b3bc8a 638
b676b881
AS
6392012-07-07 Andreas Schwab <schwab@linux-m68k.org>
640
f17c5273
AS
641 * xdisp.c (display_line): Avoid warning about implicit declaration
642 of FRAME_FONT.
643
298819b9
AS
644 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
645
b676b881
AS
646 * lisp.h: Remove empty conditional.
647
6045c4fd
PE
6482012-07-07 Paul Eggert <eggert@cs.ucla.edu>
649
b3350bf9
PE
650 * lread.c (load_path_check): Now static.
651
6045c4fd
PE
652 Fix some minor --with-ns problems found by static checking.
653 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
654 (x_set_font) [!HAVE_X_WINDOWS]:
655 * image.c (xpm_load_image) [HAVE_NS]:
656 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
657 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
658 Remove unused local.
659 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
660 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
661 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
662 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
663 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
664 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
665 Fix pointer signedness problem.
666 * xfaces.c (FRAME_X_FONT_TABLE):
667 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
668
929e7845
GM
6692012-07-07 Glenn Morris <rgm@gnu.org>
670
671 * lread.c (load_path_check): New function, split from init_lread.
672 (init_lread): Reorganize. Motivation:
673 If EMACSLOADPATH is set, check/warn about that rather than the
674 defaults, which we are not going to use. Hence we can remove
675 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
676 Don't warn if site-lisp directories are missing.
677 If not installed, start from a blank load-path, since
678 PATH_LOADSEARCH refers to the eventual installation directories.
679
58dd0aa4
EZ
6802012-07-07 Eli Zaretskii <eliz@gnu.org>
681
682 Support truncation and continuation glyphs on GUI frames, when
683 fringes are disabled. (Bug#11832)
684 * xdisp.c (init_iterator): Get dimensions of truncation and
685 continuation glyphs even if on GUI frames. Adjust
686 it->last_visible_x on GUI frames when the left or right fringes,
687 or both, are absent.
688 (start_display, move_it_in_display_line_to): Handle the case of a
689 GUI frame without a fringe to display continuation or truncation
690 glyphs.
691 (insert_left_trunc_glyphs): Support GUI frames: make sure
692 truncation glyphs overwrite enough glyphs from the current line to
693 have sufficient space in pixels.
694 (display_line): Support truncation and continuation glyphs on GUI
695 frames. If some spare pixels are left on the line after inserting
696 the truncation glyphs, fill that space with a stretch glyph of a
697 suitably computed width.
698
699 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
700 produce_glyphs, to support GUI sessions.
701
31571fd7
PE
7022012-07-07 Paul Eggert <eggert@cs.ucla.edu>
703
5a16b9bc
PE
704 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
705
f3047c75
PE
706 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
707
31571fd7
PE
708 Do not require float-time's arg to fit in time_t (Bug#11825).
709 This works better on hosts where time_t is unsigned, and where
710 float-time is applied to the (negative) difference between two times.
711 * editfns.c (decode_time_components): Last arg is now double *,
712 not int *, and means to store all the result as a double, without
713 worrying about whether the seconds part fits in time_t.
714 All callers changed.
715 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
716 All callers changed.
717 (Ffloat_time): Do not fail merely because the specified time falls
718 outside of time_t range.
719
4516fbef
GM
7202012-07-07 Glenn Morris <rgm@gnu.org>
721
722 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
723 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
724 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
725
07adc2c6
JB
7262012-07-07 Juanma Barranquero <lekktu@gmail.com>
727
728 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
729 Update dependencies.
730
731 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
732
fd573f31
PE
7332012-07-06 Paul Eggert <eggert@cs.ucla.edu>
734
fee5959d
PE
735 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
736 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
737 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
738 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
739 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
740 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
741
fd573f31
PE
742 * xfont.c (compare_font_names): Redo to omit the need for casts.
743
ddadbc0e
AS
7442012-07-06 Andreas Schwab <schwab@linux-m68k.org>
745
fca8d6b6
AS
746 * xfns.c (Fx_change_window_property): Doc fix.
747 * w32fns.c (Fx_change_window_property): Doc fix.
748
ddadbc0e
AS
749 * w32fns.c (Fx_window_property): Accept the same arguments as the
750 X Windows version. Doc fix.
751 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
752
ed9265fc 7532012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
754 Eli Zaretskii <eliz@gnu.org>
755
756 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
757 Windows-specific code from nt/config.nt moved here.
758 Obsolete settings removed.
759
216ee680
PE
7602012-07-06 Paul Eggert <eggert@cs.ucla.edu>
761
762 * process.c: Avoid unnecessary calls to gettime.
763 (wait_reading_process_output): Don't get the time of day
764 when gobbling data immediately and not waiting, as there's no need
765 for it in that case. This removes a FIXME.
766
bdd091e4
JD
7672012-07-06 Jan Djärv <jan.h.d@swipnet.se>
768
769 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
770 is defined (Bug#11768).
771
9d44f8ce
DA
7722012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
773
774 Fix marker debugging code.
775 * marker.c (byte_char_debug_check): Do not perform the check
776 if buffer is not multibyte.
090bd7cb
JB
777 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
778 Call byte_char_debug_check with correct arguments.
9d44f8ce 779
90fc4786
DA
7802012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
781
782 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
783 * marker.c (byte_char_debug_check, count_markers):
784 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
785 (byte_debug_flag): Remove.
786 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
787 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
788
7b7ae965
DA
7892012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
790
4e57b342
DA
791 Avoid code repetition in marker-related functions.
792 * marker.c (attach_marker): New function.
793 (Fset_marker, set_marker_restricted, set_marker_both)
794 (set_marker_restricted_both): Use it.
795 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
796 Consistently rename charno to charpos.
797 (marker_position): Add eassert.
798 (marker_byte_position): Convert to eassert.
799
8002012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
801
802 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 803 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 804 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 805
657924ff
DA
8062012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
807
808 Introduce fast path for the widely used marker operation.
809 * alloc.c (build_marker): New function.
810 * lisp.h (build_marker): New prototype.
811 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
812 * composite.c (autocmp_chars): Likewise.
813 * editfns.c (buildmark): Remove.
814 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
815 (save_restriction_save): Use build_marker.
816 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
817 * window.c (save_window_save): Likewise.
818
041a49a6
DA
8192012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
820
821 Do not use Fdelete_overlay in delete_all_overlays
822 to avoid redundant calls to unchain_overlay.
823 * buffer.c (drop_overlay): New function.
824 (delete_all_overlays, Fdelete_overlay): Use it.
825 * minibuf.c (get_minibuffer): Fix comment.
826
7dca65a4
PE
8272012-07-06 Paul Eggert <eggert@cs.ucla.edu>
828
829 Port to OpenBSD 5.1 amd64.
830 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
831 This is needed for OpenBSD, and should be harmless on all BSD systems.
832 Also, include <sys/sysctl.h>, as it should be available on all
833 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
834 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
835 use p_pid member, not kp_proc.pid.
836
8eb876e2
GM
8372012-07-06 Glenn Morris <rgm@gnu.org>
838
839 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
840
38182d90
PE
8412012-07-05 Paul Eggert <eggert@cs.ucla.edu>
842
843 More xmalloc and related cleanup.
844 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
845 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
846 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
847 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
848 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
849 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
850 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
851 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
852 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
853 * xterm.c:
854 Omit needless casts involving void * pointers and allocation.
855 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
856 as the former is more robust if P's type is changed.
857 Prefer xzalloc to xmalloc + memset 0.
858 Simplify malloc-or-realloc to realloc.
859 Don't worry about xmalloc returning a null pointer.
860 Prefer xstrdup to xmalloc + strcpy.
861 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
862 growing it.
863 * keyboard.c (apply_modifiers_uncached): Prefer local array to
864 alloca of a constant.
865
6dd5a677
EZ
8662012-07-05 Eli Zaretskii <eliz@gnu.org>
867
868 * xdisp.c (display_line): Fix horizontal pixel coordinates when
869 hscroll is larger than the line width. Fixes long and futile
870 looping inside extend_face_to_end_of_line (on a TTY) producing
871 glyphs that are not needed and thrown away.
872
6b312f0f
DA
8732012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
874
875 * marker.c (set_marker_restricted_both): Simplify by using
876 clip_to_bounds.
877
f520ef9b
PE
8782012-07-05 Paul Eggert <eggert@cs.ucla.edu>
879
880 * editfns.c (region_limit): Simplify by using clip_to_bounds.
881
383b7c95
JD
8822012-07-05 Jan Djärv <jan.h.d@swipnet.se>
883
884 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
885 not defined (Bug#11768).
886 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
887 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
888 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
889 followed by gtk_box_set_homogeneous (Bug#11768).
890 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
891 (update_theme_scrollbar_width, xg_create_scroll_bar):
892 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
893 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
894 (is_box_type): New function (Bug#11768).
895 (xg_tool_item_stale_p): Call is_box_type.
5293d758 896 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
897 with default display (Bug#11768).
898
d6e7bf45
EZ
8992012-07-05 Eli Zaretskii <eliz@gnu.org>
900
901 * xdisp.c (window_hscroll_limited): New function.
902 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
903 coordinates when window's hscroll is set to insanely large
904 values. (Bug#11857)
905
431391ec
JB
9062012-07-05 Juanma Barranquero <lekktu@gmail.com>
907
908 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
909 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
910
23f86fce
DA
9112012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
912
913 Cleanup xmalloc.
914 * lisp.h (xzalloc): New prototype. Omit needless casts.
915 * alloc.c (xzalloc): New function. Omit needless casts.
916 * charset.c: Omit needless casts. Convert all calls to
917 xmalloc with following memset to xzalloc.
918 * dispnew.c: Likewise.
919 * fringe.c: Likewise.
920 * image.c: Likewise.
921 * sound.c: Likewise.
922 * term.c: Likewise.
923 * w32fns.c: Likewise.
924 * w32font.c: Likewise.
925 * w32term.c: Likewise.
926 * xfaces.c: Likewise.
927 * xfns.c: Likewise.
928 * xterm.c: Likewise.
929 * atimer.c: Omit needless casts.
930 * buffer.c: Likewise.
931 * callproc.c: Likewise.
932 * ccl.c: Likewise.
933 * coding.c: Likewise.
934 * composite.c: Likewise.
935 * doc.c: Likewise.
936 * doprnt.c: Likewise.
937 * editfns.c: Likewise.
938 * emacs.c: Likewise.
939 * eval.c: Likewise.
940 * filelock.c: Likewise.
941 * fns.c: Likewise.
942 * gtkutil.c: Likewise.
943 * keyboard.c: Likewise.
944 * lisp.h: Likewise.
945 * lread.c: Likewise.
946 * minibuf.c: Likewise.
947 * msdos.c: Likewise.
948 * print.c: Likewise.
949 * process.c: Likewise.
950 * region-cache.c: Likewise.
951 * search.c: Likewise.
952 * sysdep.c: Likewise.
953 * termcap.c: Likewise.
954 * terminal.c: Likewise.
955 * tparam.c: Likewise.
956 * w16select.c: Likewise.
957 * w32.c: Likewise.
958 * w32reg.c: Likewise.
959 * w32select.c: Likewise.
960 * w32uniscribe.c: Likewise.
961 * widget.c: Likewise.
962 * xdisp.c: Likewise.
963 * xmenu.c: Likewise.
964 * xrdb.c: Likewise.
965 * xselect.c: Likewise.
966
0497dc44
PE
9672012-07-05 Paul Eggert <eggert@cs.ucla.edu>
968
969 * fileio.c (time_error_value): Check the right error number.
970 Problem reported by Troels Nielsen in
971 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
972
356e7178
PE
9732012-07-04 Paul Eggert <eggert@cs.ucla.edu>
974
4e71fd89
PE
975 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
976 This should be fixed in a better way; see Eli Zaretskii in
977 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
978 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
979
f0941253
PE
980 * fileio.c (time_error_value): Rename from special_mtime.
981 The old name's problems were noted by Eli Zaretskii in
982 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
983
065c9eb4
PE
984 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
985 This variable's comment says Emacs needs at least one GDB-visible
986 symbol of type enum pvec_type, to work around GDB problems.
987 The symbol's value doesn't matter.
988
356e7178
PE
989 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
990 that causes compilation to fail on pre-C99 compilers.
991
ed9265fc 9922012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
993
994 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
995 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
996
3884d954
DA
9972012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
998
d209e2fb 999 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1000 headers for buffer_defaults and buffer_local_symbols.
1001 Reported by Juanma Barranquero <lekktu@gmail.com>.
1002
ee28be33
SM
10032012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1004
1005 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1006 * lisp.h (enum pvec_type): Use fewer bits.
1007 (PSEUDOVECTOR_SIZE_BITS): New constant.
1008 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1009 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1010 change in pvec_type.
1011 (PSEUDOVECTOR_TYPEP): New macro.
1012 (TYPED_PSEUDOVECTORP): Use it.
1013 * fns.c (internal_equal): Adapt code to extract pvectype.
1014 * emacs.c (gdb_pvec_type): Update type.
1015 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1016 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1017 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1018 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1019 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1020 abusing vector->header.next.nbytes.
1021 (live_vector_p): Use PVEC_TYPE.
1022 (mark_object): Adapt code to extract pvectype. Use switch.
1023
c7f2cd7f
PE
10242012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1027 Tighten new eassert a bit.
1028
8ce70ed2
DA
10292012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1030
1031 Fix compilation with --enable-gcc-warnings and -O1
1032 optimization level.
1033 * doprnt.c (doprnt): Change type of tem to int, initialize
1034 to avoid compiler warning. Add eassert.
1035 * search.c (simple_search): Initialize match_byte to avoid
1036 compiler warning. Add eassert.
1037
dea7f1e5
PE
10382012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1039
24a212eb
PE
1040 Avoid weird behavior with large horizontal scrolls.
1041 Without this change, for example, large hscroll values would
1042 mess up Emacs's display on Fedora 15 x86, presumably due to
1043 overflows in int calculations in the display code.
1044 Also, if buffers had long lines, Emacs would freeze.
1045 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1046 (set_window_hscroll): New function, containing the old guts of
1047 Fset_window_hscroll. Return the clipped value.
1048 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1049 This avoids the need to check against PTRDIFF_MAX.
1050
dea7f1e5
PE
1051 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1052
76046526
DA
10532012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1054
1055 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1056
39adff0d
PE
10572012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1058
63807d47
PE
1059 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1060 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1061 since GCC 4.4.6 issues a bogus warning for them.
1062
39adff0d
PE
1063 Fix bugs in file timestamp newness comparisons.
1064 * fileio.c (Ffile_newer_than_file_p):
1065 * lread.c (Fload): Use full timestamp resolution of files,
1066 not just the 1-second resolution, so that files that are only
1067 slightly newer still count as newer.
1068 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1069 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1070
dbeed9a6
PE
10712012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1072
1073 * fileio.c: Improve handling of file time marker. (Bug#11852)
1074 (special_mtime): New function.
1075 (Finsert_file_contents, Fverify_visited_file_modtime):
1076 Use it to set special mtime values consistently.
1077
636334d6
AS
10782012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1079
1080 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1081 marker for non-existing file. (Bug#11852)
1082
e2017fe2
GM
10832012-07-03 Glenn Morris <rgm@gnu.org>
1084
1085 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1086 and did not make it into globals.h).
1087
404dbd37
TT
10882012-07-03 Tom Tromey <tromey@redhat.com>
1089
1090 * window.c (Fset_window_margins, Fset_window_fringes)
1091 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1092 * textprop.c (Fprevious_property_change): No longer static.
1093 * syntax.c (Fsyntax_table_p): No longer static.
1094 * process.c (Fget_process, Fprocess_datagram_address): No longer
1095 static.
1096 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1097 * keyboard.c (Fcommand_execute): No longer static.
1098 Remove EXFUN.
1099 * insdel.c (Fcombine_after_change_execute): No longer static.
1100 * image.c (Finit_image_library): No longer static.
1101 * fileio.c (Fmake_symbolic_link): No longer static.
1102 * eval.c (Ffetch_bytecode): No longer static.
1103 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1104 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1105 No longer static.
404dbd37
TT
1106 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1107 static.
1108 * dired.c (Ffile_attributes): No longer static.
1109 * composite.c (Fcomposition_get_gstring): No longer static.
1110 * callproc.c (Fgetenv_internal): No longer static.
1111
1112 * ccl.h: Remove EXFUNs.
1113 * buffer.h: Remove EXFUNs.
1114 * dispextern.h: Remove EXFUNs.
1115 * intervals.h: Remove EXFUNs.
1116 * fontset.h: Remove EXFUN.
1117 * font.h: Remove EXFUNs.
1118 * dosfns.c (system_process_attributes): Remove EXFUN.
1119 * keymap.h: Remove EXFUNs.
1120 * lisp.h: Remove EXFUNs.
1121 * w32term.h: Remove EXFUNs.
1122 * window.h: Remove EXFUNs.
1123 * xsettings.h: Remove EXFUN.
1124 * xterm.h: Remove EXFUN.
1125
8e4fd1e1
GM
11262012-07-03 Glenn Morris <rgm@gnu.org>
1127
1128 * lisp.h (Frandom): Make it visible to C.
1129 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1130 buffer for invisible buffers. (Bug#1229)
1131
ca95b3eb
DA
11322012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1133
1134 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1135 values which aren't power of 2.
1136 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1137 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1138 accordingly.
1139
7555c33f
SM
11402012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1141
1142 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1143
1144 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1145
d12e8f5a
DA
11462012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1147
1148 * alloc.c (allocate_vector_block): Remove redundant
1149 calls to mallopt if DOUG_LEA_MALLOC is defined.
1150 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1151 avoid calls to mallopt if zero_vector is returned.
1152
296094c3
DA
11532012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1154
1155 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1156 is enabled, avoid dereferencing NULL current_sblock if
1157 running undumped.
1158
36429c89
DA
11592012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1160
1161 Cleanup basic buffer management.
1162 * buffer.h (struct buffer): Change layout to use generic vector
1163 marking code. Fix some comments. Change type of 'clip_changed'
1164 to bitfield. Remove unused #ifndef old.
1165 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1166 (GET_OVERLAYS_AT): Fix indentation.
1167 (for_each_per_buffer_object_at): New macro.
1168 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1169 (Fbuffer_local_variables): Use it.
1170 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1171 * alloc.c (allocate_buffer): Adjust to match new layout of
1172 struct buffer. Fix comment.
1173 (mark_overlay): New function.
1174 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1175 Lisp area of struct buffer.
1176 (mark_object): Use it. Adjust marking of misc objects
1177 and related comments.
1178
3b3e4cac
PE
11792012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1180
1181 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1182 wrapper that is not needed because the wrapped code is a no-op (zero
1183 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1184 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1185
cf5c0175
DA
11862012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1187
1188 * alloc.c (mark_buffer): Simplify. Remove prototype.
1189 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1190 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1191 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1192 redundant calls to mark_vectorlike for bool vectors.
1193
ca26824c
GM
11942012-06-30 Glenn Morris <rgm@gnu.org>
1195
2e4c5312
GM
1196 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1197
ca26824c
GM
1198 * epaths.in (PATH_SITELOADSEARCH): New.
1199 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1200 This is rather than relying on --enable-locallisppath elements
1201 having "site-lisp" in their names. (Bug#10208#25, 11658)
1202
0d23c240
EZ
12032012-06-30 Eli Zaretskii <eliz@gnu.org>
1204
c9240d7a
EZ
1205 * w32proc.c (sys_select): Accept and ignore one more argument.
1206
1207 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1208
0d23c240 1209 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1210 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1211
1212 * sysdep.c: Don't include dos.h and dosfns.h.
1213
1214 * process.c (sys_select):
1215 * msdos.c (sys_select): Accept one more argument and ignore it.
1216
1217 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1218 adapt data types and code to that.
1219
1220 * dosfns.c:
1221 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1222 which clashes with the gnulib function of the same name.
1223
af5a5a98
AS
12242012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1225
c5e4379c
AS
1226 * font.c (font_style_to_value, font_style_symbolic)
1227 (font_prop_validate_style): Add type checks for values in
1228 font_style_table.
1229
af5a5a98
AS
1230 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1231 argument.
1232 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1233 uses.
1234
8d38f461
EZ
12352012-06-29 Eli Zaretskii <eliz@gnu.org>
1236
2e5a6631
EZ
1237 * xdisp.c (try_window_id): Undo last change.
1238
8d38f461
EZ
1239 * w32.c (getwd): Adjust commentary about startup_dir.
1240 (init_environment): Always call sys_access, even in non-MSVC
1241 builds. Don't chdir to the directory of the Emacs executable.
1242 This undoes code from 1997 which was justified by the need to
1243 "avoid conflicts when removing and renaming directories". But its
1244 downside was that every relative file name was being interpreted
1245 relative to the directory of the Emacs executable, which can never
1246 be TRT. In particular, it broke sys_access when called with
1247 relative file names.
1248 (sys_access): Map GetLastError to errno.
1249
2af3565e
DA
12502012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1251
1252 * window.h (struct window): Change type of 'fringes_outside_margins'
1253 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1254 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1255 Adjust comment.
1256 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1257 to ptrdiff_t.
1258
c8d3a25c 12592012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1260
c8d3a25c
GM
1261 * gnutls.c (emacs_gnutls_handshake):
1262 Add QUIT to make the loop interruptible.
57570cd3 1263
c8d3a25c 12642012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1265
c8d3a25c
GM
1266 * charset.c (init_charset): Make lack of etc/charsets fatal.
1267
3e984ee8
DA
12682012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1269
1270 * editfns.c (region_limit): Fix type mismatch.
1271
ef884f23
DA
12722012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1273
1274 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1275 undefined. Convert from xassert to eassert.
1276 * nsmenu.m: Convert from xassert to eassert.
1277 * nsterm.m: Likewise.
1278
7d7e0027
SM
12792012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1280
1281 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1282
aa754e6a
PE
12832012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1284
1285 Avoid integer overflow on scroll-left and scroll-right.
1286 * window.c (HSCROLL_MAX): New macro.
1287 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1288 overflow when requested scroll falls outside ptrdiff_t range.
1289
80b00b08
DA
12902012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1291
1292 * window.h (struct window): Change type of 'hscroll',
1293 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1294 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1295 Adjust users accordingly.
1296 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1297 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1298 from EMACS_INT to ptrdiff_t.
1299 (make_window): Omit redundant initialization.
1300
62b2bcf6
JB
13012012-06-28 Juanma Barranquero <lekktu@gmail.com>
1302
1303 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1304
45942c7d
DA
13052012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1306
1307 * window.h (struct window): Change type of 'use_time' and
1308 'sequence_number' from Lisp_Object to int.
1309 * frame.c (make_frame): Adjust users accordingly.
1310 * print.c (print_object): Likewise.
1311 * window.c (select_window, Fwindow_use_time, make_parent_window)
1312 (make_window): Likewise.
1313
e509cfa6
DA
13142012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1315
1316 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1317 enabled with --enable-checking=[all,glyphs] configure option.
1318 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1319 adjust comments accordingly.
1320 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1321 undefined, adjust comments accordingly.
1322 * image.c: Likewise.
1323 * scroll.c: Likewise.
1324 * w32fns.c: Likewise.
1325 * w32term.c: Likewise.
1326 * xdisp.c: Likewise.
1327 * xfaces.c: Likewise.
1328 * xfns.c: Likewise.
1329 * xterm.c: Likewise.
1330
a54e2c05
DA
13312012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1332
1333 Generalize run-time debugging checks.
1334 * dispextern.h (XASSERTS): Remove.
1335 * fontset.c (xassert): Remove.
1336 Convert from xassert to eassert.
1337 * alloc.c: Convert from xassert to eassert.
1338 * bidi.c: Likewise.
1339 * dispnew.c: Likewise.
1340 * fns.c: Likewise.
1341 * fringe.c: Likewise.
1342 * ftfont.c: Likewise.
1343 * gtkutil.c: Likewise.
1344 * image.c: Likewise.
1345 * keyboard.c: Likewise.
1346 * menu.c: Likewise.
1347 * process.c: Likewise.
1348 * scroll.c: Likewise.
1349 * sound.c: Likewise.
1350 * term.c: Likewise.
1351 * w32console.c: Likewise.
1352 * w32fns.c: Likewise.
1353 * w32term.c: Likewise.
1354 * window.c: Likewise.
1355 * xdisp.c: Likewise.
1356 * xfaces.c: Likewise.
1357 * xfns.c: Likewise.
1358 * xselect.c: Likewise.
1359 * xterm.c: Likewise.
1360
1ec4b7b2
SM
13612012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1362
1363 * fns.c (maybe_resize_hash_table): Output message when growing the
1364 purify-hashtable.
1365
2014308a
DA
13662012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1367
1368 * alloc.c (allocate_string_data): Remove dead code.
1369 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1370 avoid GCC warning about unused macro.
1371
246155eb
DA
13722012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1373
1374 * alloc.c (allocate_string): Omit intervals initialization.
1375 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1376 as in make_pure_string and make_pure_c_string.
1377
43184b7b
DA
13782012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1379
d209e2fb 1380 * alloc.c (allocate_string): Fix last change.
43184b7b 1381
3fe6dd74
DA
13822012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1383
d209e2fb 1384 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1385 to memset, add explicit initialization where appropriate.
1386
1ba6038a
GM
13872012-06-27 Glenn Morris <rgm@gnu.org>
1388
1389 * lisp.mk (lisp): Remove paths.elc.
1390
c89926a5
CY
13912012-06-27 Chong Yidong <cyd@gnu.org>
1392
1393 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1394
ed6b3510
JW
13952012-06-26 John Wiegley <johnw@newartisans.com>
1396
1ec4b7b2 1397 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1398 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1399
ed6b3510
JW
1400 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1401 when building with Clang.
1402
8edd4a2b
SM
14032012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1404
1405 * eval.c (Fapply): Allow calling it with a single argument.
1406
f6f62d1b
EZ
14072012-06-26 Eli Zaretskii <eliz@gnu.org>
1408
1409 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1410 _stricmp and _strnicmp.
1411 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1412
62efea5e
DA
14132012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1414
1415 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1416 allocated window.
1417 (allocate_process): Likewise for new process.
8edd4a2b 1418 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1419 (allocate_frame): Likewise.
1420 * frame.c (make_frame): Omit redundant initialization.
1421 * window.c (make_parent_window): Use memset.
1422 (make_window): Omit redundant initialization.
1423 * process.c (make_process): Omit redundant initialization.
1424 * terminal.c (create_terminal): Likewise.
1425
42997f4d
DA
14262012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1427
1428 * term.c (delete_tty): Remove redundant call to memset.
1429
1130ecfc
DA
14302012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1431
1432 * alloc.c: Remove build_string.
1433 * lisp.h: Define build_string as static inline. This provides
1434 a better opportunity to optimize away calls to strlen when the
1435 function is called with compile-time constant argument.
1436 * image.c (imagemagick_error): Convert to build_string.
1437 * w32proc.c (sys_spawnve): Likewise.
1438 * xterm.c (x_term_init): Likewise.
1439
cf38a720
PE
14402012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1441
99027bdd
PE
1442 Use sprintf return value instead of invoking strlen on result.
1443 In the old days this wasn't portable, since some sprintf
1444 implementations returned char *. But they died out years ago and
1445 Emacs already assumes sprintf returns int.
1446 Similarly for float_to_string.
1447 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1448 * ccl.c (ccl_driver):
1449 * character.c (string_escape_byte8):
1450 * data.c (Fnumber_to_string):
1451 * doprnt.c (doprnt):
1452 * print.c (print_object):
1453 * xdisp.c (message_dolog):
1454 * xfns.c (syms_of_xfns):
1455 Use sprintf or float_to_string result to avoid need to call strlen.
1456 * data.c (Fnumber_to_string):
1457 Use make_unibyte_string, since the string must be ASCII.
1458 * lisp.h, print.c (float_to_string): Now returns int length.
1459 * term.c (produce_glyphless_glyph):
1460 Use sprintf result rather than recomputing it.
1461
cf38a720
PE
1462 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1463 * Makefile.in (ALL_CFLAGS):
1464 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1465 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1466
3511c784
DA
14672012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1468
0a08eb21 1469 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1470 strcasecmp if available.
1471 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1472
fb7da12e
AS
14732012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1474
1475 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1476 Avoid comma operator.
1477 * menu.c (push_submenu_start, push_submenu_end)
1478 (push_left_right_boundary, push_menu_pane): Likewise.
1479 * msdos.c (dos_rawgetc): Likewise.
1480
afa2ffd8
DA
14812012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1482
1483 * xfns.c (xic_create_fontsetname): Remove redundant calls
1484 to memset.
1485
b3b4476b
PE
14862012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1487
4495ff38
PE
1488 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1489 sprintf already null-terminates its output.
1490
b3b4476b
PE
1491 * xfns.c (x_window): Remove redundant cast.
1492
b00876c9
DA
14932012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1494
1495 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1496 `const char *' to `char *' to avoid compiler warning.
1497
d188e26b
PE
14982012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1499
885d1d74
PE
1500 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1501 instead of truncating it to 63 (admittedly a generous limit).
1502
d188e26b
PE
1503 * process.c: Fix spelling and caps in comments.
1504
e2f560b1
DN
15052012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1506
e86db54b 1507 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1508 * sysdep.c (setpgrp): Remove definition, not used in this file.
1509
7583a3a1
JB
15102012-06-24 Juanma Barranquero <lekktu@gmail.com>
1511
1512 * makefile.w32-in: Update dependencies.
1513
696056c2
EZ
15142012-06-24 Eli Zaretskii <eliz@gnu.org>
1515
1516 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1517 (SYSTIME_H): Add nt/inc/sys/time.h.
1518
1519 * systime.h [WINDOWSNT]: Include sys/time.h.
1520
1521 * s/ms-w32.h (struct timespec): Definition moved from
1522 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1523
845ca893
PE
15242012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1525
1526 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1527 * buffer.h (buffer_slot_type_mismatch):
1528 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1529 * eval.c (unwind_to_catch):
1530 * image.c (my_png_error, my_error_exit):
1531 * keyboard.c (quit_throw_to_read_char, user_error)
1532 (Fexit_recursive_edit, Fabort_recursive_edit):
1533 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1534 (wrong_type_argument, buffer_overflow, __executable_start)
1535 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1536 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1537 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1538 (fatal):
1539 (child_setup) [!DOS_NT]:
1540 * lread.c (end_of_file_error, invalid_syntax):
1541 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1542 * puresize.h (pure_write_error):
1543 * search.c (matcher_overflow):
1544 * sound.c (sound_perror, alsa_sound_perror):
1545 * sysdep.c, syssignal.h (croak):
1546 * term.c (maybe_fatal, vfatal):
1547 * textprop.c (text_read_only):
1548 * undo.c (user_error):
1549 * unexmacosx.c (unexec_error):
1550 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1551 Use _Noreturn rather than NO_RETURN.
1552 No need for separate decl merely because of _Noreturn.
1553 * sound.c (sound_warning, parse_sound):
1554 Remove unnecessary forward decls.
1555
f1dd8073
PE
15562012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1557
1558 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1559 * lisp.h (WAIT_READING_MAX): New macro.
1560 * dispnew.c (Fsleep_for, sit_for):
1561 * keyboard.c (kbd_buffer_get_event):
1562 * process.c (Faccept_process_output):
1563 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1564 This improves on the previous patch, which introduced a bug
1565 when time_t is unsigned and as wide as intmax_t.
1566 See <http://bugs.gnu.org/9000#51>.
1567
b82c1755
EZ
15682012-06-23 Eli Zaretskii <eliz@gnu.org>
1569
1570 * dispnew.c (sit_for, Fsleep_for):
1571 * keyboard.c (kbd_buffer_get_event):
1572 * process.c (Faccept_process_output): Avoid compiler warnings when
1573 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1574
ca300656
JB
15752012-06-23 Juanma Barranquero <lekktu@gmail.com>
1576
049ec95b
JB
1577 * makefile.w32-in: Update dependencies.
1578
ca300656
JB
1579 * w32.c (ltime): Add return type and declare static.
1580 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1581
db7b8d06
PE
15822012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1583
1584 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1585 Privately reported by Herbert J. Skuhra.
1586 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1587 All uses changed.
1588 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1589 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1590
0bd8297f
EZ
15912012-06-23 Eli Zaretskii <eliz@gnu.org>
1592
96512555
EZ
1593 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1594 last argument of make_unibyte_string.
1595
0bd8297f
EZ
1596 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1597 language ID in the event parameters.
1598
1599 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1600 event.code, not the obscure "character set ID".
1601
63def6b6
CY
16022012-06-23 Chong Yidong <cyd@gnu.org>
1603
1604 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1605
e8a02204
EZ
16062012-06-23 Eli Zaretskii <eliz@gnu.org>
1607
388cdec0
EZ
1608 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1609 * w32.c (fdutimens): New function.
1610
1611 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1612
1613 * s/ms-w32.h (pselect): Redirect to sys_select.
1614
1615 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1616
e8a02204
EZ
1617 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1618 in the logic of incrementing and decrementing the value of
1619 use_relocatable_buffers.
1620
d054f3fb
PE
16212012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1622
1623 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1624 Privately reported by Herbert J. Skuhra.
1625 [__FreeBSD__]: Remove "*/" typo after "#include".
1626 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1627 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1628 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1629 Don't assume EMACS_TIME and struct timeval are the same type.
1630
d35af63c
PE
16312012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1632
1633 Support higher-resolution time stamps (Bug#9000).
1634 The time stamps are only nanosecond-resolution at the C level,
1635 since that's the best that any real-world system supports now.
1636 But they are picosecond-resolution at the Lisp level, as that's
1637 easy, and leaves room for future OS improvements.
1638
1639 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1640 (LIBES): Use it.
1641
1642 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1643 Don't get current time unless it's needed.
1644
1645 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1646 now provides it if it's absent.
1647 (start_atimer): Port to higher-res time stamps.
1648 Check for time stamp overflow. Don't get current time more
1649 often than is needed.
1650
1651 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1652 Include systime.h, not time.h.
1653 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1654
1655 * dired.c: Include stat-time.h.
1656 (Ffile-attributes): File times now have higher resolution.
1657
1658 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1659 (struct image): Timestamp now has higher resolution.
1660
1661 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1662 has at least microseconds now. All uses removed.
1663 (update_frame, update_single_window, update_window, update_frame_1)
1664 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1665
1666 * editfns.c (time_overflow): Now extern.
1667 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1668 (float-time, Fformat_time_string, Fcurrent_time_string)
1669 (Fcurrent_time_zone): Accept and generate higher-resolution
1670 time stamps.
1671 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1672 (decode_time_components, lisp_seconds_argument): New functions.
1673 (make_time): Now static.
1674 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1675 Report an error if the time is invalid, rather than having the caller
1676 do that.
1677
1678 * fileio.c: Include <stat-time.h>
1679 (Fcopy_file): Copy higher-resolution time stamps.
1680 Prefer to set the time stamp via a file descriptor if that works.
1681 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1682 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1683 (Fvisited_file_modtime, Fset_visited_file_modtime):
1684 Support higher-resolution time stamps.
1685
1686 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1687
1688 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1689
1690 * image.c (prepare_image_for_display, clear_image_cache)
1691 (lookup_image): Port to higer-resolution time stamps.
1692
1693 * keyboard.c (start_polling, bind_polling_period):
1694 Check for time stamp overflow.
1695 (read_char, kbd_buffer_get_event, timer_start_idle)
1696 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1697 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1698 Port to higher-resolution time stamps. Do not assume time_t is signed.
1699 (decode_timer): New function. Timers are now vectors of length 9,
1700 not 8, to accommodate the picosecond component.
1701 (timer_check_2): Use it.
1702
1703 * nsterm.m (select_timeout, timeval_subtract): Remove.
1704 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1705 as they're a bit more accurate and handle overflow better.
1706 (ns_select): Change prototype to be compatible with pselect.
1707 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1708 * nsterm.h (ns_select): Adjust prototype.
1709
1710 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1711 us-resolution time stamps.
1712 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1713
1714 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1715
1716 * lisp.h (time_overflow): New decl.
1717 (wait_reading_process_output): First arg is now intmax_t, not int,
1718 to accommodate larger waits.
1719
1720 * process.h (struct Lisp_Process.read_output_delay):
1721 Now counts nanoseconds, not microseconds.
1722 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1723 EMACS_HAS_USECS.
1724 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1725 (wait_reading_process_output):
1726 Port to ns-resolution time stamps.
1727 (Faccept_process_output, wait_reading_process_output):
1728 Check for time stamp overflow. Do not assume time_t is signed.
1729 (select_wrapper): Remove; we now use pselect.
1730 (Fprocess_attributes): Now generates ns-resolution time stamps.
1731
1732 * sysdep.c: Include utimens.h. Don't include utime.h
1733 or worry about struct utimbuf; gnulib does that for us now.
1734 (gettimeofday): Remove; gnulib provides a substitute.
1735 (make_timeval): New function.
1736 (set_file_times): Now sets ns-resolution time stamps.
1737 New arg FD; all uses changed.
1738 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1739 (system_process_attributes):
1740 Now returns ns-resolution time stamp. All uses changed.
1741 Check for time stamp overflow.
1742
1743 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1744 provides a substitute now.
1745
1746 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1747 since it guarantees struct timespec.
1748 (EMACS_TIME): Now struct timespec, so that we can support
1749 ns-resolution time stamps.
1750 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1751 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1752 (EMACS_USECS): Remove.
1753 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1754 so multiply the arg by 1000 before storing it.
1755 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1756 New macros.
1757 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1758 Port to ns-resolution time stamps.
1759 (EMACS_TIME_NEG_P): Remove; replaced by....
1760 (EMACS_TIME_SIGN): New macro.
1761 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1762 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1763 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1764 (make_timeval, make_lisp_time, decode_time_components): New decls.
1765 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1766 that it mishandled time_t overflow. You can't compare by subtracting!
1767 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1768 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1769
1770 * term.c: Include <sys/time.h>.
1771 (timeval_to_Time): New function, for proper overflow wraparound.
1772 (term_mouse_position, term_mouse_click): Use it.
1773
1774 * undo.c (record_first_change): Support higher-resolution time stamps
1775 in the undo buffer.
1776 (Fprimitive_undo): Use them when restoring time stamps.
1777
1778 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1779 (w32_get_internal_run_time):
1780 Port to higher-resolution Emacs time stamps.
1781 (ltime): Now accepts single 64-bit integer, as that's more convenient
1782 for callers.
1783
1784 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1785
1786 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1787 for compatibility with pselect. Support ns-resolution time stamps.
1788
1789 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1790
1791 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1792 Check for time stamp overflow, and support ns-resolution time stamps.
1793
1794 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1795 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1796 (timeval_subtract): Remove; no longer needed.
1797 (XTflash, XTring_bell, x_wait_for_event):
1798 Port to ns-resolution time stamps. Don't assume time_t is signed.
1799
b6a92dfe
CY
18002012-06-22 Chong Yidong <cyd@gnu.org>
1801
1802 * xdisp.c (x_consider_frame_title): Revert last change.
1803
d251c37c
EZ
18042012-06-22 Eli Zaretskii <eliz@gnu.org>
1805
1806 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1807 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1808 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1809 staticidx goes up to 1597 out of 1600 = 0x640.)
1810
f10deafb
PE
18112012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1812
1813 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1814 Otherwise, the umask might be mistakenly 0 while handling input signals.
1815
ec6de1e2
SM
18162012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1817
1818 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1819
28be1ada
DA
18202012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1821
1822 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1823 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1824 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1825 access to `contents' member of Lisp_Vector objects with AREF and ASET
1826 where appropriate.
1827
c6bf3022
CY
18282012-06-19 Chong Yidong <cyd@gnu.org>
1829
1830 * frame.c (delete_frame): When selecting a frame on a different
1831 text terminal, do not alter the terminal's top-frame.
1832
1833 * xdisp.c (format_mode_line_unwind_data): Record the target
1834 frame's selected window and its terminal's top-frame.
1835 (unwind_format_mode_line): Restore them.
1836 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1837 Callers changed.
1838 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1839 since tty frames can be explicitly named.
1840 (prepare_menu_bars): Likewise.
1841
1842 * term.c (Ftty_top_frame): New function.
1843
defd4196
PE
18442012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1845
1846 Port byte-code-meter to modern targets.
1847 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1848 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1849 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1850 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1851 (METER_1, METER_2): Simplify.
1852
1053a871
SM
18532012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1854
1855 * data.c (Fdefalias): Return `symbol' (bug#11686).
1856
b7e8d081
MR
18572012-06-18 Martin Rudalics <rudalics@gmx.at>
1858
1859 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1860 gets killed during executing of this function (Bug#11665).
1861 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1862 (Vkill_buffer_query_functions): In doc-string say that functions
1863 run by this hook should not change the current buffer.
1864
7ea2b339
PE
18652012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 Fix recently-introduced process.c problems found by static checking.
1868 * process.c (write_queue_push, write_queue_pop, send_process):
1869 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1870 (write_queue_pop): Fix pointer signedness problem.
1871 (send_process): Remove unused local.
1872
96a313a1
CY
18732012-06-17 Chong Yidong <cyd@gnu.org>
1874
1875 * xdisp.c (redisplay_internal): No need to redisplay terminal
1876 frames that are not on top.
1877
20ca2e94
TN
18782012-06-17 Troels Nielsen <bn.troels@gmail.com>
1879
1880 * process.c (make_process): Initialize write_queue.
1881 (write_queue_push, write_queue_pop): New functions.
1882 (send_process): Use them to maintain correct ordering of process
1883 writes (Bug#10815).
1884
9a900ca9
PE
18852012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1886
310fbfa8
PE
1887 * lisp.h (eassert): Assume C89 or later.
1888 This removes the need for CHECK.
1889 (CHECK): Remove. Its comments about always evaluating its
1890 argument were confusing, as 'eassert' typically does not evaluate
1891 its argument.
1892
27bb1ca4
PE
1893 * coding.c (produce_chars): Use ptrdiff_t, not int.
1894
9a900ca9
PE
1895 * xterm.c (x_draw_underwave): Check for integer overflow.
1896 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1897
41b7f8bc 18982012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1899
1900 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1901 referenced (Bug#11583).
1902
9b0e3eba
AA
19032012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1904
1905 Implement wave-style variant of underlining.
1906 * dispextern.h (face_underline_type): New enum.
1907 (face): Add field for underline type.
1908 * nsterm.m (ns_draw_underwave): New function.
1909 (ns_draw_text_decoration): Use it.
1910 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1911 New functions.
1912 (x_draw_glyph_string): Use them.
1913 * xfaces.c (Qline, Qwave): New Lisp objects.
1914 (check_lface_attrs, merge_face_ref)
1053a871
SM
1915 (Finternal_set_lisp_face_attribute, realize_x_face):
1916 Handle wave-style underline face attributes.
9b0e3eba
AA
1917 * xterm.c (x_draw_underwave): New function.
1918 (x_draw_glyph_string): Use it.
1919
0fb52f11
JB
19202012-06-16 Juanma Barranquero <lekktu@gmail.com>
1921
1922 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1923 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1924 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1925 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1926 ($(BLD)/w32select.$(O)): Update dependencies.
1927
e5560ff7
AS
19282012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1929
1930 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1931 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1932 * character.c (_fetch_multibyte_char_p): Remove.
1933 * alloc.c: Include "character.h" before "buffer.h".
1934 * bidi.c: Likewise.
1935 * buffer.c: Likewise.
1936 * bytecode.c: Likewise.
1937 * callint.c: Likewise.
1938 * callproc.c: Likewise.
1939 * casefiddle.c: Likewise.
1940 * casetab.c: Likewise.
1941 * category.c: Likewise.
1942 * cmds.c: Likewise.
1943 * coding.c: Likewise.
1944 * composite.c: Likewise.
1945 * dired.c: Likewise.
1946 * dispnew.c: Likewise.
1947 * doc.c: Likewise.
1948 * dosfns.c: Likewise.
1949 * editfns.c: Likewise.
1950 * emacs.c: Likewise.
1951 * fileio.c: Likewise.
1952 * filelock.c: Likewise.
1953 * font.c: Likewise.
1954 * fontset.c: Likewise.
1955 * fringe.c: Likewise.
1956 * indent.c: Likewise.
1957 * insdel.c: Likewise.
1958 * intervals.c: Likewise.
1959 * keyboard.c: Likewise.
1960 * keymap.c: Likewise.
1961 * lread.c: Likewise.
1962 * macros.c: Likewise.
1963 * marker.c: Likewise.
1964 * minibuf.c: Likewise.
1965 * nsfns.m: Likewise.
1966 * nsmenu.m: Likewise.
1967 * print.c: Likewise.
1968 * process.c: Likewise.
1969 * regex.c: Likewise.
1970 * region-cache.c: Likewise.
1971 * search.c: Likewise.
1972 * syntax.c: Likewise.
1973 * term.c: Likewise.
1974 * textprop.c: Likewise.
1975 * undo.c: Likewise.
1976 * unexsol.c: Likewise.
1977 * w16select.c: Likewise.
1978 * w32fns.c: Likewise.
1979 * w32menu.c: Likewise.
1980 * window.c: Likewise.
1981 * xdisp.c: Likewise.
1982 * xfns.c: Likewise.
1983 * xmenu.c: Likewise.
1984 * xml.c: Likewise.
1985 * xselect.c: Likewise.
1986
2f07e6af
EZ
19872012-06-16 Eli Zaretskii <eliz@gnu.org>
1988
1053a871
SM
1989 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1990 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1991 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1992 row.
1993 (handle_face_prop): Use chunk-relative overlay string index when
1994 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1995 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1996 the rightmost. (Bug#11720)
2f07e6af 1997
29b83cec
AS
19982012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1999
2000 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2001 (CATEGORY_MEMBER): Enforce 1/0 value.
2002 * category.c (_temp_category_set): Remove.
2003
4c5501e9
EZ
20042012-06-16 Eli Zaretskii <eliz@gnu.org>
2005
2006 * window.c (Fdelete_other_windows_internal)
2007 (Fdelete_window_internal): Don't access frame's mouse highlight
2008 info of the initial frame. (Bug#11677)
2009
2b570124
PE
20102012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2011
e93864f9
PE
2012 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2013 Assume USE_2_TAGS_FOR_INTS.
2014 (xreload): Adjust $tagmask width to match recent lisp.h change.
2015
2b570124
PE
2016 Simplify lisp.h in minor ways that should not affect code.
2017 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2018 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2019 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2020 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2021 (INTTYPEBITS): New macro, for clarity.
2022 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2023 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2024 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2025 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2026 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2027
81755f69
JB
20282012-06-13 Juanma Barranquero <lekktu@gmail.com>
2029
2030 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2031
16192a57
GM
20322012-06-13 Glenn Morris <rgm@gnu.org>
2033
2034 * s/bsd-common.h (BSD4_3):
2035 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2036
646b5f55
AS
20372012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2038
2039 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2040 instead of union.
2041 (XLI, XIL): Define.
1053a871
SM
2042 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2043 Use them.
2044 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2045 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2046 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2047 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2048 * frame.c (delete_frame): Remove outdated comment.
2049 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2050 USE_LISP_UNION_TYPE.
2051 (Fw32_unregister_hot_key): Likewise.
2052 (Fw32_toggle_lock_key): Likewise.
2053 * w32menu.c (add_menu_item): Likewise.
2054 (w32_menu_display_help): Use XIL instead of checking
2055 USE_LISP_UNION_TYPE.
2056 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2057 (init_heap): Likewise.
2058 * w32term.c (w32_read_socket): Update comment.
2059
1d3823c9
GM
20602012-06-13 Glenn Morris <rgm@gnu.org>
2061
c62ff706
GM
2062 * s/usg5-4-common.h, src/s/unixware.h:
2063 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2064
1d3823c9
GM
2065 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2066
bfe3e0a2
PE
20672012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2068
2069 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2070 * alloc.c (make_number) [!defined make_number]:
2071 Remove, as lisp.h always defines this now.
2072 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2073 (roundup_size): Verify that it is a power of 2.
2074 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2075 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2076 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2077 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2078 USE_LSB_TAG now is always defined to be either 0 or 1.
2079 All uses changed.
2080 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2081 code works fine either way, and efficiency is not a concern here,
2082 as the union type is for debugging, not for production.
2083 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2084 Use an inline function on all platforms when using the union type,
2085 since this is simpler and 'static inline' can be used portably
2086 within Emacs now.
2087 (LISP_INITIALLY_ZERO): New macro.
2088 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2089 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2090
45fa9c0f
GM
20912012-06-12 Glenn Morris <rgm@gnu.org>
2092
b4492cba
GM
2093 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2094
2095 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2096
45fa9c0f
GM
2097 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2098 Move BROKEN_SIGIO to configure.
2099
2100 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2101 Move NO_TERMIO to configure.
2102
0e25d334
CY
21032012-06-12 Chong Yidong <cyd@gnu.org>
2104
2105 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2106 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2107 MagickExportImagePixels is undefined.
2108
43682bb6
PE
21092012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2110
2111 * image.c (imagemagick_load_image): Remove unused label.
2112
a9be7d2b
GM
21132012-06-11 Glenn Morris <rgm@gnu.org>
2114
2115 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2116 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2117 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2118 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2119
3017f87f
SM
21202012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2121
2122 * alloc.c (make_byte_code): New function.
2123 (Fmake_byte_code): Use it. Don't purify here.
2124 * lread.c (read1): Use it as well to avoid extra allocation.
2125
1b9b4cf4
CY
21262012-06-11 Chong Yidong <cyd@gnu.org>
2127
2128 * image.c (imagemagick_load_image): Implement transparency.
2129
95988fcf
AS
21302012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2131
2132 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2133 account for preceding backslashes. (Bug#11663)
2134
cd4eb164
CY
21352012-06-09 Chong Yidong <cyd@gnu.org>
2136
2137 * term.c: Support italics in capable terminals (Bug#9652).
2138 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2139 (turn_on_face): Output using TS_enter_italic_mode if available.
2140 Don't handle unused blinking and alt-charset cases.
2141 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2142 and tty_alt_charset_p cases.
2143 (tty_capable_p, init_tty): Support italics.
2144
2145 * termchar.h (struct tty_display_info): Add field for italics.
2146 Remove unused blink field.
2147
2148 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2149 Handle slant.
2150
2151 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2152 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2153 tty_alt_charset_p. Add tty_italic_p.
2154
ff88beb8
MA
21552012-06-09 Michael Albinus <michael.albinus@gmx.de>
2156
2157 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2158 dbus_type_is_basic if available.
2159 (xd_extract_signed, xd_extract_unsigned): Rename from
2160 extract_signed and extract_unsigned, respectively. Adapt callers.
2161
44286096
CY
21622012-06-09 Chong Yidong <cyd@gnu.org>
2163
1682701f
CY
2164 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2165
44286096
CY
2166 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2167 case (Bug#9752).
2168
d86feb17
PE
21692012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2170
2171 * xdisp.c (vmessage): Treat frame message as multibyte.
2172 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2173 would generate the diagnostic "Making \302\247 buffer-local while
2174 let-bound!".
2175
d5c20fe8
EZ
21762012-06-08 Eli Zaretskii <eliz@gnu.org>
2177
2178 * dispnew.c (showing_window_margins_p): Undo last change, which
2179 was done due to an inadvertent commit.
2180 (adjust_frame_glyphs_for_frame_redisplay): Do call
2181 showing_window_margins_p.
2182
513749ee
SM
21832012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2184
2185 * eval.c (Fmake_var_non_special): New primitive.
2186 (syms_of_eval): Defsubr it.
2187 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2188
d4a8f5c1
JB
21892012-06-08 Juanma Barranquero <lekktu@gmail.com>
2190
2191 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2192 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2193
8bbbc977
EZ
21942012-06-08 Eli Zaretskii <eliz@gnu.org>
2195
2196 * alloc.c (allocate_vectorlike): Fix last change.
2197
f3372c87
DA
21982012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2199
2200 Block-based vector allocation of small vectors.
2201 * lisp.h (struct vectorlike_header): New field `nbytes',
2202 adjust comment accordingly.
2203 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2204 to denote vector blocks. Adjust users (live_vector_p,
2205 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2206 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2207 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2208 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2209 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2210 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2211 (roundup_size): New constant.
2212 (struct vector_block): New data type.
2213 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2214 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2215 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2216 (sweep_vectors): New functions.
2217 (allocate_vectorlike): Return `zero_vector' as the only vector of
2218 0 items. Allocate new vector from block if vector size is less than
2219 or equal to VBLOCK_BYTES_MAX.
2220 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2221 (init_alloc_once): Add call to init_vectors.
2222
4f18a4ed
SM
22232012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2224
2225 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2226
86f158bc
PE
22272012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2228
2229 * doprnt.c (doprnt): Truncate multibyte char correctly.
2230 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2231 would mishandle a string argument "Xc" if X was a multibyte
2232 character of length 2: it would truncate after X's first byte
2233 rather than including all of X.
2234
c5cfcbe0
CY
22352012-06-06 Chong Yidong <cyd@gnu.org>
2236
2237 * buffer.c (word_wrap): Doc fix.
2238
c05cf390
PE
22392012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2240
2241 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2242
0c3461de
GM
22432012-06-03 Glenn Morris <rgm@gnu.org>
2244
2245 * xdisp.c (tool-bar-style): Doc fix.
2246
c71232db
UM
22472012-06-03 Ulrich Müller <ulm@gentoo.org>
2248
2249 * Makefile.in (PAXCTL): Define.
2250 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2251 binary via PaX flags if the paxctl utility is available.
2252 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2253 Restore PaX flags to their default. (Bug#11398)
2254
383f7350
CY
22552012-06-03 Chong Yidong <cyd@gnu.org>
2256
2257 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2258 buffer (Bug#11226).
2259
5f2c76c6
CY
22602012-06-03 Chong Yidong <cyd@gnu.org>
2261
2262 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2263 (note_mode_line_or_margin_highlight): If there is no help echo,
2264 use mode-line-default-help-echo. Handle the case where the mouse
2265 position is past the end of the mode line string.
2266
2267 * buffer.c (buffer_local_value_1): New function, split from
2268 Fbuffer_local_value; can return Qunbound.
2269 (Fbuffer_local_value): Use it.
2270 (Vmode_line_format): Docstring tweaks.
2271
773d47f6
PE
22722012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2273
2274 * sysdep.c (system_process_attributes): Improve comment.
2275
f2d6a3df
SM
22762012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2277
2278 * keyboard.c: Export real-this-command to Elisp.
2279 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2280 and DEFVAR it. Update all users.
2281
63810350
PE
22822012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2283
7bd5c1f4
PE
2284 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2285
63810350
PE
2286 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2287 Convert pctcpu and pctmem to Lisp float properly.
2288 Let the compiler fold better, as 100.0/0x8000 is exact.
2289
a2821611
AS
22902012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2291
2292 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2293 cons_block.
2294
5fceba1d
PE
22952012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2296
2297 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2298
c98ff5dd
DA
22992012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2300
2301 For a 'struct window', replace some Lisp_Object fields to
2302 bitfields where appropriate, remove unused fields.
2303 * window.h (struct window): Remove unused 'last_mark_x' and
2304 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2305 change it's type from Lisp_Object to bitfield.
2306 Change type of 'force_start', 'optional_new_start',
2307 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2308 fields from Lisp_Object to bitfield. Adjust users accordingly.
2309
ca34e0be
PE
23102012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2311
2312 Pacify gcc -Wdouble-precision when using Xaw.
2313 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2314 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2315 Use 'float' consistently, rather than 'float' in most places
2316 and 'double' in a couple of places.
2317
efc00ab1 23182012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2319
2320 * xdisp.c (handle_stop): Detect whether we have overlay strings
2321 loaded by testing it->current.overlay_string_index to be
2322 non-negative, instead of checking whether n_overlay_strings is
2323 positive. (Bug#11587)
2324
efc00ab1 23252012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2326
2327 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2328
2329 * doc.c (Fsubstitute_command_keys): Doc fix.
2330
efc00ab1 23312012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2332
2333 * search.c (search_buffer): Remove calls to
2334 r_alloc_inhibit_buffer_relocation, as it is now called by
2335 maybe_unify_char, which was the cause of relocation of buffer text
2336 in bug#11519.
2337
efc00ab1 23382012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2339
2340 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2341 for the duration of call to load_charset, to avoid problems with
2342 callers of maybe_unify_char that access buffer text through C
2343 pointers.
2344
2345 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2346 decrement the inhibition flag, instead of just setting or
2347 resetting it.
2348
ba93a187
PE
23492012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2350
2351 Remove obsolete '#define static' cruft.
2352 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2353 This #undef was "temporary" in 2000; it is no longer needed
2354 now that '#define static' has gone away.
2355 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2356 (gray_bitmap_bits): Remove; no longer needed.
2357 All uses replaced with definiens.
2358 * xterm.c: Include "bitmaps/gray.xbm".
2359
9e4bf381
PE
23602012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2361
2362 Clean up __executable_start, monstartup when --enable-profiling.
2363 The following changes affect the code only when profiling.
2364 * dispnew.c (__executable_start): Rename from safe_bcopy.
2365 Define only on platforms that need it.
2366 * emacs.c: Include <sys/gmon.h> when profiling.
2367 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2368 (__executable_start): Remove decl, since lisp.h does it now.
2369 (safe_bcopy): Remove decl; no longer has that name.
2370 (main): Coalesce #if into single bit of code, for simplicity.
2371 Cast pointers to uintptr_t, since standard libraries want integers
2372 and not pointers.
2373 * lisp.h (__executable_start): New decl.
2374
32d72c2f
GM
23752012-05-31 Glenn Morris <rgm@gnu.org>
2376
2377 * image.c (Fimagemagick_types): Doc fix.
2378
baac5bc7
JM
23792012-05-30 Jim Meyering <meyering@redhat.com>
2380
2381 * callproc.c (Fcall_process_region): Include directory component
2382 in mkstemp error message (Bug#11586).
2383
72cb32cf
PE
23842012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2385
2386 * alloc.c, lisp.h (make_pure_vector): Now static.
2387
61b108cc
SM
23882012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2389
2390 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2391 Move to byte-run.el.
2392 (Fautoload): Do the hash-doc more carefully.
2393 * data.c (Fdefalias): Purify definition, except for keymaps.
2394 (Qdefun): Move from eval.c.
2395 * lisp.h (Qdefun): Remove.
2396 * lread.c (read1): Tiny simplification.
2397
471fe23d
TN
23982012-05-29 Troels Nielsen <bn.troels@gmail.com>
2399
934f3f58 2400 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2401 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2402 Bug#9642, but explicitly check that the buffer the overlay would
2403 be moved to is live and rearrange lines to make sure that errors
2404 will not put the overlay in an inconsistent state.
2405 (Fdelete_overlay): Cosmetics.
2406
85d0efd1
EZ
24072012-05-28 Eli Zaretskii <eliz@gnu.org>
2408
2409 * w32term.c (my_bring_window_to_top): New function.
2410 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2411 could be different from the original one.
2412 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2413 (Bug#11513)
2414
2415 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2416 by calling BringWindowToTop.
2417
2418 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2419 (WM_EMACS_END): Increase by one.
2420
da92a98c
PE
24212012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2424 This avoids undefined behavior that might cause the eassert
2425 to not catch an out-of-range value.
2426
74d1f848
JB
24272012-05-28 Juanma Barranquero <lekktu@gmail.com>
2428
2429 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2430 Update dependencies.
2431
9e1a06fc
EZ
24322012-05-27 Eli Zaretskii <eliz@gnu.org>
2433
2434 * bidi.c (bidi_mirror_char): Fix last change.
2435
f3dd7312
AS
24362012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2437
2438 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2439 when referring to sectname field in printf format.
2440
81899c91
PE
24412012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2442
57b81a9f
PE
2443 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2444 Only r_alloc_inhibit_buffer_relocation needed to be added;
2445 the others were already declared.
2446
81899c91
PE
2447 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2448 before checking whether it's out of range. Put the check inside
2449 eassert. See
2450 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2451
33017faf 24522012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2453
2454 * callproc.c (Fcall_process): Restore a line that was accidentally
2455 commented out in the 2011-02-13 change (bug#11547).
2456
33017faf 24572012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2458
2459 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2460 defined on ralloc.c.
2461
2462 * buffer.c [REL_ALLOC]: Remove prototypes of
2463 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2464 they are now on lisp.h.
2465
2466 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2467
2468 * search.c (search_buffer): Use it to inhibit relocation of buffer
2469 text while re_search_2 is doing its job, because re_search_2 is
2470 passed C pointers to buffer text. (Bug#11519)
2471
23415acf
EZ
2472 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2473 Update value to 24.
2474
44e27368
EZ
2475 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2476 state after an additional call to move_it_in_display_line_to, keep
2477 the values of it->max_ascent and it->max_descent found for the
2478 entire line.
2479 (pos_visible_p): Revert the comparison against bottom_y to what it
2480 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2481 (Bug#11464)
2482
c1892f11
PE
24832012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 Fix coding-related core dumps with gcc -ftrapv.
2486 The code was computing A - B, where A and B are pointers, and B is
2487 random garbage. This can lead to core dumps on platforms that
2488 have special pointer registers, and it also leads to core dumps on
2489 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2490 A - B only when B is initialized properly.
2491 * coding.c (coding_set_source, coding_set_destination): Return void.
2492 (coding_change_source, coding_change_destinations): New functions,
2493 with the old behaviors of coding_set_source and coding_set_destination.
2494 All callers that need an offset changed to use these new functions.
2495
eb7afdad
GM
24962012-05-26 Glenn Morris <rgm@gnu.org>
2497
2498 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2499
f12fdf02
EZ
25002012-05-26 Eli Zaretskii <eliz@gnu.org>
2501
53a63be6 2502 Extend mouse support on W32 text-mode console.
61b108cc
SM
2503 * xdisp.c (draw_row_with_mouse_face):
2504 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2505
eb3f6f01 2506 * w32console.c: Include window.h.
61b108cc
SM
2507 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2508 New functions.
eb3f6f01
EZ
2509 (initialize_w32_display): Initialize mouse-highlight data.
2510
53a63be6
EZ
2511 * w32inevt.c: Include termchar.h and window.h.
2512 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2513 moves, call note_mouse_highlight. If help_echo changed, call
2514 gen_help_event to produce help-echo message in the echo area.
2515 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2516 highlight info.
2517
4cfd81f6
PE
25182012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2519
2520 * lread.c (read1): Simplify slightly to avoid an overflow warning
2521 with GCC 4.7.0 on x86-64.
2522
4446092a
EZ
25232012-05-26 Eli Zaretskii <eliz@gnu.org>
2524
2525 * bidi.c (bidi_mirror_char): Revert last change: an int is
2526 definitely wide enough here.
2527
42b2a986 25282012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2529
42b2a986 2530 Fix integer width and related bugs (Bug#9874).
eb106a49 2531 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2532 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2533 (string_bytes, check_sblock, allocate_string_data):
2534 (compact_small_strings, Fmake_bool_vector, make_string)
2535 (make_unibyte_string, make_multibyte_string)
2536 (make_string_from_bytes, make_specified_string)
2537 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2538 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2539 (mark_vectorlike):
2540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2541 (allocate_pseudovector):
2542 Use int, not EMACS_INT, where int is wide enough.
2543 (inhibit_garbage_collection, Fgarbage_collect):
2544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2545 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2546 int might not be wide enough.
2547 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2548 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2549 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2550 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2551 (bidi_level_of_next_char, bidi_move_to_visually_next):
2552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2553 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2554 (Fkill_buffer, Fset_buffer_major_mode)
2555 (advance_to_char_boundary, Fbuffer_swap_text)
2556 (Fset_buffer_multibyte, overlays_at, overlays_in)
2557 (overlay_touches_p, struct sortvec, record_overlay_string)
2558 (overlay_strings, recenter_overlay_lists)
2559 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2560 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2561 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2562 (Foverlay_recenter, last_overlay_modification_hooks_used)
2563 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2565 (validate_region): Omit unnecessary test for b <= e,
2566 since that's guaranteed by the previous test.
d311d28c
PE
2567 (adjust_overlays_for_delete): Avoid pos + length overflow.
2568 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2569 (report_overlay_modification):
2570 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2571 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2572 Omit pointer cast, which isn't needed anyway, and doesn't work
2573 after the EMACS_INT -> ptrdiff_t change.
02481186 2574 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2575 * buffer.h: Adjust decls to match defn changes elsewhere.
2576 (struct buffer_text, struct buffer):
2577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2578 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2579 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2580 not int, to avoid needless 32-bit limit on 64-bit hosts.
2581 (exec_byte_code): Use tighter memory-full test, one that checks
2582 for alloca overflow. Don't compute the address of the object just
2583 before an array, as that's not portable. Use EMACS_INT, not
2584 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2585 * callint.c (Fcall_interactively):
2586 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2587 * callproc.c (call_process_kill, Fcall_process):
2588 Don't assume pid_t fits into an Emacs fixnum.
2589 (call_process_cleanup, Fcall_process, child_setup):
2590 Don't assume pid_t fits into int.
2591 (call_process_cleanup, Fcall_process, delete_temp_file)
2592 (Fcall_process_region):
2593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2594 (Fcall_process): Simplify handling of volatile integers.
2595 Use int, not EMACS_INT, where int will do.
2596 * casefiddle.c (casify_object, casify_region, operate_on_word)
2597 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2599 (casify_object): Avoid integer overflow when overallocating buffer.
2600 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2601 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2602 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2603 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2604 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2605 integers are now checked earlier. All uses replaced with XINT.
2606 (ccl_driver):
2607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2608 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2609 (ccl_driver, Fregister_code_conversion_map):
2610 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2611 (resolve_symbol_ccl_program): Check that vector header is in range.
2612 Always copy the vector, so that we can check its contents reliably
2613 now rather than having to recheck each instruction as it's being
2614 executed. Check that vector words fit in 'int'.
2615 (ccl_get_compiled_code, Fregister_ccl_program)
2616 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2617 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2618 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2619 contents are in range.
2620 (Fccl_execute_on_string): Check that status is in range.
2621 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2622 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2623 Accept and return EMACS_INT, not int, because callers can pass values
2624 out of 'int' range.
2625 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2626 (multibyte_chars_in_text, parse_str_as_multibyte)
2627 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2628 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2629 (string_escape_byte8, Fget_byte):
2630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2631 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2632 avoid mishandling large integers.
2633 * character.h: Adjust decls to match defn changes elsewhere.
2634 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2635 (Ffind_charset_region):
2636 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2637 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2638 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2639 Don't assume fixnum fits in int.
d311d28c
PE
2640 (load_charset_map_from_vector, Fmap_charset_chars):
2641 Remove now-unnecessary CHECK_NATNUMs.
2642 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2643 Don't rely on undefined behavior with signed left shift overflow.
2644 Don't assume unsigned int fits into fixnum, or that fixnum fits
2645 into unsigned int. Don't require max_code to be a valid fixnum;
2646 that's not true for gb10830 4-byte on a 32-bit host. Allow
2647 invalid_code to be a cons, for the same reason. Require code_offset
2648 to be a character. Avoid int overflow if max_char is close
2649 to INT_MAX.
2650 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2651 this is intended anyway and avoids some undefined behavior.
2652 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2653 INDEX_TO_CODE_POINT, as that's what it expects.
2654 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2655 * charset.h (DECODE_CHAR): Return int, not unsigned;
2656 this is what was intended anyway, and it avoids undefined behavior.
2657 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2658 integer-overflow issues.
2659 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2660 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2661 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2662 * chartab.c (Fmake_char_table, Fset_char_table_range)
2663 (uniprop_get_decoder, uniprop_get_encoder):
2664 Don't assume fixnum fits in int.
2665 * cmds.c (move_point): New function, that does the gist of
2666 Fforward_char and Fbackward_char, but does so while checking
2667 for integer overflow more accurately.
c96e5d6a 2668 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2669 (Fforward_line, Fend_of_line, internal_self_insert)
2670 (internal_self_insert):
2671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2672 Fix a FIXME, by checking for integer overflow when calculating
2673 target_clm and actual_clm.
2674 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2675 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2676 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2677 (coding_alloc_by_making_gap, alloc_destination)
2678 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2679 (encode_coding_utf_16, detect_coding_emacs_mule)
2680 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2681 (detect_coding_iso_2022, decode_coding_iso_2022)
2682 (encode_invocation_designation, encode_designation_at_bol)
2683 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2684 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2685 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2686 (encode_coding_ccl, encode_coding_raw_text)
2687 (detect_coding_charset, decode_coding_charset)
2688 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2689 (produce_composition, produce_charset, produce_annotation)
2690 (decode_coding, handle_composition_annotation)
2691 (handle_charset_annotation, consume_chars, decode_coding_gap)
2692 (decode_coding_object, encode_coding_object, detect_coding_system)
2693 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2694 (code_convert_region, code_convert_string)
8f50130c
PE
2695 (Fdefine_coding_system_internal)
2696 (coding_set_source, coding_set_destination):
d311d28c
PE
2697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2698 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2699 (Fdefine_coding_system_internal):
2700 Don't assume fixnums fit in int.
2701 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2702 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2703 (Funencodable_char_position, Fcheck_coding_systems_region)
2704 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2706 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2707 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2708 Don't access memory outside of the args array.
d311d28c 2709 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2710 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2711 result of ENCODE_CHAR.
d311d28c
PE
2712 * coding.h: Adjust decls to match defn changes elsewhere.
2713 (struct coding_system):
2714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2715 * composite.c (get_composition_id, find_composition)
2716 (run_composition_function, update_compositions)
2717 (compose_text, composition_gstring_put_cache)
2718 (composition_gstring_p, composition_gstring_width)
2719 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2720 (composition_compute_stop_pos, composition_reseat_it)
2721 (composition_update_it, struct position_record)
2722 (find_automatic_composition, composition_adjust_point)
2723 (Fcomposition_get_gstring, Ffind_composition_internal):
2724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2725 (update_compositions):
2726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2727 * composite.h: Adjust decls to match defn changes elsewhere.
2728 (struct composition):
2729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2730 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2731 Do not attempt to compute the address of the object just before a
2732 buffer; this is not portable.
2733 (Faref, Faset):
2734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2735 (Faset): Use int, not EMACS_INT, where int is wide enough.
2736 (Fstring_to_number): Don't assume fixnums fit in int.
2737 (Frem): Don't assume arg is nonnegative.
2738 * dbusbind.c (xd_append_arg): Check for integers out of range.
2739 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2740 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2741 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2742 (xd_get_connection_references): Return ptrdiff_t, not int.
2743 All uses changed.
2744 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2745 (xd_read_message_1):
2746 Use int, not unsigned, where the dbus API uses int.
2747 (Fdbus_message_internal): Don't overflow mtype.
2748 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2749 * dired.c (directory_files_internal, file_name_completion, scmp)
2750 (file_name_completion_stat):
2751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2752 (file_name_completion): Don't overflow matchcount.
2753 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2754 * dispextern.h: Adjust decls to match defn changes elsewhere.
2755 (struct text_pos, struct glyph, struct bidi_saved_info)
2756 (struct bidi_string_data, struct bidi_it, struct composition_it)
2757 (struct it):
2758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2759 (struct display_pos, struct composition_it, struct it):
2760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2761 * dispnew.c (increment_matrix_positions)
2762 (increment_row_positions, mode_line_string)
2763 (marginal_area_string):
2764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2765 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2767 (duration_to_sec_usec): New function, to check for overflow better.
2768 (Fsleep_for, sit_for): Use it.
2769 * doc.c (get_doc_string, store_function_docstring):
2770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2771 (get_doc_string, Fsnarf_documentation):
2772 Use int, not EMACS_INT, where int is wide enough.
2773 (get_doc_string):
2774 Use SAFE_ALLOCA, not alloca.
2775 Check for overflow when converting EMACS_INT to off_t.
2776 * doprnt.c (doprnt):
2777 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2778 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2779 Don't assume uid_t fits into fixnum.
2780 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2781 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2782 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2783 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2784 (general_insert_function)
2785 (Finsert_char, make_buffer_string, make_buffer_string_both)
2786 (update_buffer_properties, Fbuffer_substring)
2787 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2788 (Fsubst_char_in_region, check_translation)
2789 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2790 (transpose_markers, Ftranspose_regions):
2791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2792 (clip_to_bounds): Move to lisp.h as an inline function).
2793 (Fconstrain_to_field): Don't assume integers are nonnegative.
2794 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2795 (Fsubst_char_in_region, Fsave_restriction):
2796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2797 (Femacs_pid): Don't assume pid_t fits into fixnum.
2798 (lo_time): Use int, not EMACS_INT, when int suffices.
2799 (lisp_time_argument): Check for usec out of range.
2800 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2801 (Fuser_login_name, Fuser_full_name): Signal an error
2802 if a uid argument is out of range, rather than relying on
2803 undefined behavior.
c8d5c857
PE
2804 (Fformat_time_string): Remove now-unnecessary check.
2805 lisp_time_argument checks for out-of-range usec now.
243e0530 2806 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2807 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2808 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2809 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2810 (init_cmdargs, Fdump_emacs):
2811 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2812 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2813 the bottom (typically) 32 bits of the fixnum.
2814 * eval.c (specpdl_size, call_debugger):
2815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2816 (when_entered_debugger, Fbacktrace_debug):
2817 Don't assume fixnum can fit in int.
2818 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2819 the object just before a buffer; this is not portable.
2820 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2821 (grow_specpdl, unbind_to):
2822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2823 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2824 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2825 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2826 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2827 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2829 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2830 (a_write, e_write):
2831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2832 (Fcopy_file, non_regular_nbytes, read_non_regular)
2833 (Finsert_file_contents):
2834 Use int, not EMACS_INT, where int is wide enough.
2835 (READ_BUF_SIZE): Verify that it fits in int.
2836 (Finsert_file_contents): Check that counts are in proper range,
2837 rather than assuming fixnums fit into ptrdiff_t etc.
2838 Don't assume fixnums fit into int.
125b3835 2839 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2840 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2841 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2842 (string_char_to_byte, string_byte_to_char)
2843 (string_make_multibyte, string_to_multibyte)
2844 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2845 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2846 (substring_both, Fdelete, internal_equal, Ffillarray)
2847 (Fclear_string, mapcar1)
2848 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2849 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2850 (larger_vector, make_hash_table, maybe_resize_hash_table)
2851 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2852 (Fmaphash, secure_hash):
2853 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2854 (concat): Check for string index and length overflow.
2855 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2856 (Frequire):
2857 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2858 (larger_vector): New API (vec, incr_min, size_max) replaces old
2859 one (vec, new_size, init). This catches size overflow.
2860 INIT was removed because it was always Qnil.
2861 All callers changed.
2862 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2863 the upper bound on a hash table index size.
2864 (make_hash_table, maybe_resize_hash_table): Use it.
2865 (secure_hash): Computer start_byte and end_byte only after
2866 they're known to be in ptrdiff_t range.
2867 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2868 (Ffont_get_glyphs, Ffont_at):
2869 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2870 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2871 (Flist_fonts, Fopen_font):
2872 Don't assume fixnum can fit in int.
2873 (check_gstring): Don't assume index can fit in int.
2874 (font_match_p): Check that fixnum is a character, not a nonnegative
2875 fixnum, since the later code needs to stuff it into an int.
2876 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2877 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2878 conversion overflow issues.
2879 (Fopen_font): Check for integer out of range.
2880 (Ffont_get_glyphs): Don't assume index can fit in int.
2881 * font.h: Adjust decls to match defn changes elsewhere.
2882 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2883 integer overflow.
2884 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2885 printmax_t, where ptrdiff_t is wide enough.
2886 (Finternal_char_font):
2887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2888 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2889 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2890 (Fset_frame_position, x_set_frame_parameters)
2891 (x_set_line_spacing, x_set_border_width)
2892 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2893 Check that fixnums are in proper range for system types.
2894 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2896 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2897 Use SAFE_ALLOCA_LISP, not alloca.
2898 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2899 intptr_t is wide enough.
2900 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2901 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2902 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2903 Check for fixnum out of range.
2904 * ftfont.c (ftfont_list): Don't assume index fits in int.
2905 Check that fixnums are in proper range for system types.
2906 (ftfont_shape_by_flt):
2907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2908 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2909 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2910 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2911 Check that fixnums are in proper range for system types.
2912 * gnutls.h: Adjust decls to match defn changes elsewhere.
2913 * gtkutil.c (xg_dialog_run):
2914 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2915 (update_frame_tool_bar):
2916 Check that fixnums are in proper range for system types.
2917 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2918 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2919 * indent.c (last_known_column, last_known_column_point):
2920 (current_column_bol_cache):
2921 (skip_invisible, current_column, check_display_width):
2922 (check_display_width, scan_for_column, current_column_1)
2923 (Findent_to, Fcurrent_indentation, position_indentation)
2924 (indented_beyond_p, Fmove_to_column, compute_motion):
2925 (Fcompute_motion, Fvertical_motion):
2926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2927 (last_known_column_modified): Use EMACS_INT, not int.
2928 (check_display_width):
2929 (Fcompute_motion):
2930 Check that fixnums and floats are in proper range for system types.
2931 (compute_motion): Don't assume index or fixnum fits in int.
2932 (compute_motion, Fcompute_motion):
2933 Use int, not EMACS_INT, when it is wide enough.
2934 (vmotion): Omit local var start_hpos that is always 0; that way
2935 we don't need to worry about overflow in expressions involving it.
2936 * indent.h: Adjust decls to match defn changes elsewhere.
2937 (struct position):
2938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2939 Use int, not EMACS_INT, where int is wide enough.
2940 Remove unused members ovstring_chars_done and tab_offset;
2941 all uses removed.
2942 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2943 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2944 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2945 (make_gap, copy_text, insert, insert_and_inherit)
2946 (insert_before_markers, insert_before_markers_and_inherit)
2947 (insert_1, count_combining_before, count_combining_after)
2948 (insert_1_both, insert_from_string)
2949 (insert_from_string_before_markers, insert_from_string_1)
2950 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2951 (adjust_after_replace, adjust_after_insert, replace_range)
2952 (replace_range_2, del_range, del_range_1, del_range_byte)
2953 (del_range_both, del_range_2, modify_region)
2954 (prepare_to_modify_buffer, signal_before_change)
2955 (signal_after_change, Fcombine_after_change_execute):
2956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2957 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2958 (balance_an_interval, split_interval_right, split_interval_left)
2959 (find_interval, next_interval, update_interval)
2960 (adjust_intervals_for_insertion, delete_node, delete_interval)
2961 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2962 (static_offset_intervals, offset_intervals)
2963 (merge_interval_right, merge_interval_left, make_new_interval)
2964 (graft_intervals_into_buffer, temp_set_point_both)
2965 (temp_set_point, set_point, adjust_for_invis_intang)
2966 (set_point_both, move_if_not_intangible, get_property_and_range)
2967 (get_local_map, copy_intervals, copy_intervals_to_string)
2968 (compare_string_intervals, set_intervals_multibyte_1):
2969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2970 * intervals.h: Adjust decls to match defn changes elsewhere.
2971 (struct interval):
2972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2973 * keyboard.c (this_command_key_count, this_single_command_key_start)
2974 (before_command_key_count, before_command_echo_length, echo_now)
2975 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2976 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2977 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2978 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2980 (last_non_minibuf_size, last_point_position, echo_truncate)
2981 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2982 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2983 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2984 (stuff_buffered_input):
2985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2986 (last_auto_save, command_loop_1, read_char):
2987 Use EMACS_INT, not int, to avoid integer overflow.
2988 (record_char): Avoid overflow in total_keys computation.
2989 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2990 * keyboard.h: Adjust decls to match defn changes elsewhere.
2991 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2992 (Fkey_description, Fdescribe_vector, Flookup_key):
2993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2994 (click_position): New function, to check that positions are in range.
2995 (Fcurrent_active_maps):
2996 (describe_command):
2997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2998 (Faccessible_keymaps, Fkey_description):
2999 (preferred_sequence_p):
3000 Don't assume fixnum can fit into int.
3001 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3002 Check for integer overflow in size calculations.
3003 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3004 avoid mishandling large integers.
3005 * lisp.h: Adjust decls to match defn changes elsewhere.
3006 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3007 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3008 (struct Lisp_Marker):
3009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3010 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3011 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3012 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3013 All callers changed.
3014 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3015 Assume the arg has valid form, since it always does.
3016 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3017 unsigned integer system type.
3018 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3019 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3020 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3021 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3022 (duration_to_sec_usec): New decl.
3023 * lread.c (read_from_string_index, read_from_string_index_byte)
3024 (read_from_string_limit, readchar, unreadchar, openp)
3025 (read_internal_start, read1, oblookup):
3026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3027 (Fload, readevalloop, Feval_buffer, Feval_region):
3028 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3029 (openp): Check for out-of-range argument to 'access'.
3030 (read1): Use int, not EMACS_INT, where int is wide enough.
3031 Don't assume fixnum fits into int.
6efdadfd 3032 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3033 (read_filtered_event): Use duration_to_sec_usec
3034 to do proper overflow checking on durations.
d311d28c
PE
3035 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3036 in size calculation.
3037 (Fexecute_kbd_macro):
3038 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3039 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3040 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3041 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3042 (set_marker_both, set_marker_restricted_both, marker_position)
3043 (marker_byte_position, Fbuffer_has_markers_at):
3044 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3045 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3046 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3047 It now merely ensures that the menu is large enough, without
3048 necessarily growing it, as this avoids some integer overflow issues.
3049 All callers changed.
3050 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3052 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3053 Use SAFE_ALLOCA_LISP, not alloca.
3054 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3055 to EMACS_INT. Check that fixnums are in proper range for system types.
3056 * minibuf.c (minibuf_prompt_width, string_to_object)
3057 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3058 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3060 (get_minibuffer, read_minibuf_unwind):
3061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3062 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3063 this simplifies overflow checking. All callers changed.
3064 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3065 (Ftest_completion):
3066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3067 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3068 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3069 Check that fixnums are in proper range for system types.
3070 (Fx_create_frame, Fx_show_tip):
3071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3072 * nsfont.m (ns_findfonts, nsfont_list_family):
3073 Don't assume fixnum fits in long.
3074 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3075 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3076 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3077 wide enough.
17fdb222 3078 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3079 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3080 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3081 (PRINTDECLARE, PRINTPREPARE):
3082 (strout, print_string):
3083 (print, print_preprocess, print_check_string_charset_prop)
3084 (print_object):
3085 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3086 (PRINTDECLARE):
3087 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3088 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3089 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3090 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3091 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3092 (print_error_message): Use SAFE_ALLOCA, not alloca.
3093 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3094 (print_depth, new_backquote_output, print_number_index):
3095 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3096 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3097 (Fset_process_window_size, Fformat_network_address)
3098 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3099 (sigchld_handler):
d311d28c 3100 Check that fixnums are in proper range for system types.
d44287d4 3101 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3102 Check for process-ids out of pid_t range rather than relying on
3103 undefined behavior.
e4d81efc 3104 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3105 (Fformat_network_address, read_process_output, send_process)
3106 (Fprocess_send_region, status_notify):
3107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3108 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3109 (wait_reading_process_output, read_process_output, exec_sentinel):
3110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3111 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3112 (Faccept_process_output): Use duration_to_sec_usec to do proper
3113 overflow checking on durations.
dde14581
PE
3114 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3115 Don't assume pid_t fits in int.
02481186
PE
3116 * process.h (struct Lisp_Process): Members tick and update_tick
3117 are now of type EMACS_INT, not int.
b62b53e8
PE
3118 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3119 configured --with-wide-int.
d311d28c
PE
3120 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3121 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3122 * search.c (looking_at_1, string_match_1):
3123 (fast_string_match, fast_c_string_match_ignore_case)
3124 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3125 (scan_newline, find_before_next_newline, search_command)
3126 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3127 (set_search_regs, wordify):
3128 (Freplace_match):
3129 (Fmatch_data):
3130 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3131 (string_match_1, search_buffer, set_search_regs):
3132 (Fmatch_data):
3133 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3134 (wordify): Check for overflow in size calculation.
3135 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3136 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3137 Check that fixnums are in proper range for system types.
3138 * sound.c (struct sound_device)
3139 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3141 (Fplay_sound_internal):
3142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3143 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3144 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3145 (Fparse_partial_sexp):
3146 Don't assume fixnums can fit in int.
3147 (struct lisp_parse_state, find_start_pos, find_start_value)
3148 (find_start_value_byte, find_start_begv)
3149 (update_syntax_table, char_quoted, dec_bytepos)
3150 (find_defun_start, prev_char_comend_first, back_comment):
3151 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3152 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3153 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3154 (Finternal_describe_syntax_value): Check that match_lisp is a
3155 character, not an integer, since the code stuffs it into int.
3156 (scan_words, scan_sexps_forward):
3157 Check that fixnums are in proper range for system types.
3158 (Fforward_word):
3159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3160 (scan_sexps_forward):
3161 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3162 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3163 * syntax.h: Adjust decls to match defn changes elsewhere.
3164 (struct gl_state_s):
3165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3166 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3167 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3168 * sysdep.c (wait_for_termination_1, wait_for_termination)
3169 (interruptible_wait_for_termination, mkdir):
3170 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3171 (emacs_read, emacs_write):
3172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3173 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3174 and double all fit in int.
d311d28c
PE
3175 * term.c (set_tty_color_mode):
3176 Check that fixnums are in proper range for system types.
3177 * termhooks.h (struct input_event):
3178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3179 * textprop.c (validate_interval_range, interval_of)
3180 (Fadd_text_properties, set_text_properties_1)
3181 (Fremove_text_properties, Fremove_list_of_text_properties)
3182 (Ftext_property_any, Ftext_property_not_all)
3183 (copy_text_properties, text_property_list, extend_property_ranges)
3184 (verify_interval_modification):
3185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3186 (Fnext_single_char_property_change)
3187 (Fprevious_single_char_property_change):
3188 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3189 (copy_text_properties):
3190 Check for integer overflow in index calculation.
d311d28c
PE
3191 * undo.c (last_boundary_position, record_point, record_insert)
3192 (record_delete, record_marker_adjustment, record_change)
3193 (record_property_change):
3194 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3195 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3197 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3198 (Fx_hide_tip, Fx_file_dialog):
3199 * w32menu.c (set_frame_menubar):
3200 Use ptrdiff_t, not int, for consistency with rest of code.
3201 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3202 (select_window, Fdelete_other_windows_internal)
3203 (window_scroll_pixel_based, window_scroll_line_based)
3204 (Frecenter, Fset_window_configuration):
3205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3206 (Fset_window_hscroll, run_window_configuration_change_hook)
3207 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3208 (Fscroll_other_window, Frecenter):
d311d28c
PE
3209 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3210 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3211 Don't assume fixnum fits in int.
3212 (Fset_window_scroll_bars):
3213 Check that fixnums are in proper range for system types.
3214 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3215 (string_pos, c_string_pos, number_of_chars, init_iterator)
3216 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3217 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3218 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3219 (face_before_or_after_it_pos, handle_invisible_prop)
3220 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3221 (display_prop_intangible_p, string_buffer_position_lim)
3222 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3223 (get_overlay_strings_1, get_overlay_strings)
3224 (iterate_out_of_display_property, forward_to_next_line_start)
3225 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3226 (get_next_display_element, set_iterator_to_next)
3227 (get_visually_first_element, compute_stop_pos_backwards)
3228 (handle_stop_backwards, next_element_from_buffer)
3229 (move_it_in_display_line_to, move_it_in_display_line)
3230 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3231 (add_to_log, message_dolog, message_log_check_duplicate)
3232 (message2, message2_nolog, message3, message3_nolog
3233 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3234 (current_message_1, truncate_echo_area, truncate_message_1)
3235 (set_message, set_message_1, store_mode_line_noprop)
3236 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3237 (text_outside_line_unchanged_p, check_point_in_composition)
3238 (reconsider_clip_changes)
3239 (redisplay_internal, set_cursor_from_row, try_scrolling)
3240 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3241 (redisplay_window, find_last_unchanged_at_beg_row)
3242 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3243 (trailing_whitespace_p, find_row_edges, display_line)
3244 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3245 (display_mode_element, store_mode_line_string)
3246 (pint2str, pint2hrstr, decode_mode_spec)
3247 (display_count_lines, display_string, draw_glyphs)
3248 (x_produce_glyphs, x_insert_glyphs)
3249 (rows_from_pos_range, mouse_face_from_buffer_pos)
3250 (fast_find_string_pos, mouse_face_from_string_pos)
3251 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3252 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3253 (safe_call, init_from_display_pos, handle_fontified_prop)
3254 (handle_single_display_spec, load_overlay_strings)
3255 (with_echo_area_buffer, setup_echo_area_for_printing)
3256 (display_echo_area, echo_area_display)
3257 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3258 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3259 (redisplay_window, dump_glyph_row, display_mode_line)
3260 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3261 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3263 (handle_single_display_spec, build_desired_tool_bar_string)
3264 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3265 (get_specified_cursor_type):
3266 Check that fixnums are in proper range for system types.
3267 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3268 (Flookup_image_map):
3269 Don't assume fixnums fit in int.
3270 (compare_overlay_entries):
3271 Avoid mishandling comparisons due to subtraction overflow.
3272 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3273 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3274 (handle_tool_bar_click):
3275 Use int, not unsigned, since we prefer signed and the signedness
3276 doesn't matter here.
3277 (get_next_display_element, next_element_from_display_vector):
3278 Use int, not EMACS_INT, when int is wide enough.
3279 (start_hourglass): Use duration_to_sec_usec to do proper
3280 overflow checking on durations.
3281 * xfaces.c (Fbitmap_spec_p):
3282 Check that fixnums are in proper range for system types.
3283 (compare_fonts_by_sort_order):
3284 Avoid mishandling comparisons due to subtraction overflow.
3285 (Fx_family_fonts, realize_basic_faces):
3286 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3287 (Fx_family_fonts):
3288 Don't assume fixnum fits in int.
3289 Use SAFE_ALLOCA_LISP, not alloca.
3290 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3291 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3292 (face_at_buffer_position, face_for_overlay_string)
3293 (face_at_string_position):
3294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3295 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3296 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3297 (Fx_show_tip):
3298 Check that fixnums are in proper range for system types.
3299 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3300 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3302 (Fx_change_window_property): Don't assume fixnums fit in int.
3303 * xfont.c (xfont_chars_supported):
3304 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3305 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3306 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3307 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3308 * xml.c (parse_region):
3309 * xrdb.c (magic_file_p):
3310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3311 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3312 (x_get_local_selection, x_reply_selection_request)
3313 (x_handle_selection_request, wait_for_property_change):
3314 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3315 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3316 short is wide enough.
3317 (x_send_client_event): Don't assume fixnum fits in int.
3318 * xterm.c (x_x_to_emacs_modifiers):
3319 Don't assume EMACS_INT overflows nicely into int.
3320 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3321 may come from Lisp.
3322 (handle_one_xevent): NATNUMP can eval its arg twice.
3323 (x_connection_closed):
3324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3325 * xterm.h: Adjust decls to match defn changes elsewhere.
3326 (struct scroll_bar): Use struct vectorlike_header
3327 rather than rolling our own approximation.
3328 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3329
c6574eb5
GM
33302012-05-25 Glenn Morris <rgm@gnu.org>
3331
3332 * lisp.mk (lisp): Update for more files being compiled now.
3333
e8d32c7e
SM
33342012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3335
48def666
SM
3336 * lread.c: Remove `read_pure' which makes no difference.
3337 (read_pure): Remove var.
3338 (unreadpure): Remove function.
3339 (readevalloop): Don't call read_list with -1 flag.
3340 (read1, read_vector): Don't test read_pure any more.
3341 (read_list): Simplify.
3342
e8d32c7e
SM
3343 * fileio.c, character.h: Minor style tweaks.
3344
4b2addb7
DA
33452012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3346
3347 * window.h (clip_changed): Remove useless declaration.
3348
584461b2
JB
33492012-05-22 Juanma Barranquero <lekktu@gmail.com>
3350
3351 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3352 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3353
34374650
PE
33542012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3355
3356 Remove src/m/*.
3357 This directory predates autoconf and is no longer needed nowadays.
3358 Move its few remaining bits of functionality to where they're needed.
3359 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3360 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3361 * m/template.h: Remove.
3362 * Makefile.in (M_FILE): Remove. All uses removed.
3363 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3364 * lisp.h (USE_LSB_TAG):
3365 * mem-limits.h (EXCEEDS_LISP_PTR):
3366 Use VAL_MAX, not VALBITS, in #if.
3367 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3368 (EMACS_UINT): Define unconditionally now.
3369 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3370 (BITS_PER_EMACS_INT): New constants, replacing
3371 what used to be in config.h, but not useful in #if.
3372 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3373 define them any more.
3374 (VAL_MAX): New macro.
3375 (VALMASK): Use it.
3376 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3377 BITS_PER_EMACS_INT, in #if.
3378 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3379 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3380 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3381 * s/ms-w32.h (DATA_START):
3382 Move here from removed file m/intel386.h.
3383 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3384 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3385
261cb4bb
PE
33862012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3387
3388 Assume C89 or later.
3389 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3390 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3391 (xrealloc):
3392 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3393 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3394 * textprop.c, tparam.c (NULL): Remove.
3395 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3396 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3397 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3398 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3399 * xterm.c (input_signal_count): Assume volatile works.
3400
ff23cd9f
KB
34012012-05-21 Ken Brown <kbrown@cornell.edu>
3402
3403 * xgselect.c (xg_select): Fix first argument in call to 'select'
3404 (bug#11508).
3405
1b170bc6
KB
34062012-05-20 Ken Brown <kbrown@cornell.edu>
3407
3408 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3409 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3410
b2f4d39f
KB
34112012-05-19 Ken Brown <kbrown@cornell.edu>
3412
3413 * xfns.c (x_in_use): Remove `static' qualifier.
3414 * xterm.h (x_in_use): Declare.
3415 * xgselect.c: Include xterm.h.
3416 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3417 and `display_arg' (bug#9754).
3418
003fdae2
PE
34192012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3420
9232a6d9
PE
3421 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3422
003fdae2
PE
3423 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3424 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3425
784b56e2
EZ
34262012-05-18 Eli Zaretskii <eliz@gnu.org>
3427
3428 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3429
3430 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3431 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3432
3433 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3434 reference to image_cache->refcount.
3435 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3436
a0a79cde
JL
34372012-05-17 Juri Linkov <juri@jurta.org>
3438
3439 * search.c (Fword_search_regexp, Fword_search_backward)
3440 (Fword_search_forward, Fword_search_backward_lax)
3441 (Fword_search_forward_lax): Move functions to isearch.el
3442 (bug#10145, bug#11381).
3443
b0572523
PE
34442012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3445
3446 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3447
9660f5fc
SM
34482012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3449
3450 * lread.c (init_obarray): Declare Qt and Qnil as special.
3451
4374de83
GM
34522012-05-14 Glenn Morris <rgm@gnu.org>
3453
3454 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3455 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3456
dc44c39a
PE
34572012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3458
078c97cb
PE
3459 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3460
dc44c39a
PE
3461 * unexaix.c: Port to more-recent AIX compilers.
3462 (report_error, report_error_1, make_hdr, copy_sym)
3463 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3464 Make arguments const char *, not char *, to avoid violations of C
3465 standard and to fix some AIX warnings reported by Gilles Pion.
3466
e18afed7 34672012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3468
3469 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3470 already have overlays loaded.
3471 (handle_single_display_spec): Before returning without displaying
3472 fringe bitmap, synchronize the bidi iterator with the main display
3473 iterator, by calling iterate_out_of_display_property.
3474 (iterate_out_of_display_property): Detect buffer iteration by
3475 testing that it->string is a Lisp string.
3476 (get_next_display_element): When the current object is exhausted,
3477 and there's something on it->stack, call set_iterator_to_next to
3478 proceed with what's on the stack, instead of returning zero.
3479 (set_iterator_to_next): If called at the end of a Lisp string,
3480 proceed to consider_string_end without incrementing string
3481 position. Don't increment display vector index past the end of
3482 the display vector. (Bug#11417)
c8fb9dc6
EZ
3483 (pos_visible_p): Don't report a position visible when move_it_to
3484 stopped at the last line of window, which happens to be scanned
3485 backwards by the bidi iteration. (Bug#11464)
ac268e67 3486
e18afed7 34872012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3488
3489 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3490 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3491 are on a TTY, and thus unable to display on the fringes.
3492 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3493 so we need to signal to the caller that this is a "replacing"
3494 display spec. This fixes display when the spec is invalid or we
3495 are on a TTY.
3496
e18afed7 34972012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3498
3499 * unexaix.c (make_hdr): Fix typo in prototype.
3500 This bug broke the build on AIX. Problem reported by Gilles Pion.
3501
9d0a235a
MA
35022012-05-14 Michael Albinus <michael.albinus@gmx.de>
3503
3504 * keyboard.c (kbd_buffer_get_event): Read special events also in
3505 batch mode. (Bug#11415)
3506
9e6b06ed
GM
35072012-05-12 Glenn Morris <rgm@gnu.org>
3508
3509 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3510
c1a1d7a3
EZ
35112012-05-12 Eli Zaretskii <eliz@gnu.org>
3512
3513 * lisp.mk (lisp): Add newcomment.elc.
3514
3fe7cdc8
GM
35152012-05-12 Glenn Morris <rgm@gnu.org>
3516
3517 * Makefile.in (MKDIR_P): New, set by configure.
3518 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3519
53f7d2c0
PE
35202012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3521
3522 Remove unused function hourglass_started.
3523 * dispextern.h (hourglass_started):
3524 * w32fns.c (hourglass_started):
3525 * xdisp.c (hourglass_started): Remove.
3526
75aafb17
JB
35272012-05-10 Juanma Barranquero <lekktu@gmail.com>
3528
3529 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3530 Update dependencies.
3531
12959e8e
PE
35322012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3533
97107e2e
PE
3534 * xgselect.c (xg_select): Put maxfds+1 into a var.
3535 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3536
12959e8e
PE
3537 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3538
836d29b3
DA
35392012-05-10 Dave Abrahams <dave@boostpro.com>
3540
3541 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3542 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3543
5cb67954
MA
35442012-05-09 Michael Albinus <michael.albinus@gmx.de>
3545
3546 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3547 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3548 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3549 Initialize xd_registered_buses.
3550
3478ec45
PE
35512012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3552
b263a6b0
PE
3553 Untag more efficiently if USE_LSB_TAG.
3554 This is based on a proposal by YAMAMOTO Mitsuharu in
3555 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3556 For an admittedly artificial (nth 8000 longlist) benchmark on
3557 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3558 Emacs's overall text size by 1%.
3559 * lisp.h (XUNTAG): New macro.
3560 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3561 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3562 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3563 * eval.c (Fautoload):
3564 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3565 * frame.h (XFRAME): Use XUNTAG.
3566
3478ec45
PE
3567 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3568 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3569 Remove unportable assumptions about print widths of types like
3570 dbus_uint32_t.
3571 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3572 intptr_t when converting between pointer and integer, to avoid GCC
3573 warnings about wrong width.
3574
666b903b 35752012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3576
3577 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3578 stack for each reader_thread, instead of defaulting to 8MB
3579 determined by the linker. This avoids failures in creating
3580 subprocesses on Windows 7, see the discussion in this thread:
3581 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3582
b120cc17
JC
35832012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3584
3585 Fix up display of the *Minibuf-0* buffer in the mini window.
3586 * keyboard.c (read_char): Don't clear the echo area if there's no
3587 message to clear.
3588 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3589 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3590
9a4b36f8
MA
35912012-05-07 Michael Albinus <michael.albinus@gmx.de>
3592
3593 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3594 batch mode.
3595
e5f9458f
CY
35962012-05-06 Chong Yidong <cyd@gnu.org>
3597
3598 * lisp.mk (lisp): Update.
3599
eceeb5fc 36002012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3601
3602 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3603
71873e2b
SM
36042012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3605
3606 * data.c (PUT_ERROR): New macro.
3607 (syms_of_data): Use it. Add new error type `user-error'.
3608 * undo.c (user_error): New function.
3609 (Fprimitive_undo): Use it.
3610 * print.c (print_error_message): Adjust print style for `user-error'.
3611 * keyboard.c (user_error): New function.
3612 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3613
ab0fa4e4
PE
36142012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3615
3616 Do not limit current-time-string to years 1000..9999.
3617 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3618 (Fcurrent_time_string): Support any year that is supported by the
3619 underlying localtime representation. Don't use asctime, as it
3620 has undefined behavior for years outside the range -999..9999.
3621
7ed806a7
PE
36222012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3623
3624 Fix race conditions involving setenv, gmtime, localtime, asctime.
3625 Without this fix, interrupts could mess up code that uses these
3626 nonreentrant functions, since setting TZ invalidates existing
3627 tm_zone or tzname values, and since most of these functions return
3628 pointers to static storage.
3629 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3630 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3631 Grow the critical sections to include not just invoking
3632 localtime/gmtime, but also accessing these functions' results
3633 including their tm_zone values if any, and any related TZ setting.
3634 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3635 so that the struct tm is saved in the critical section.
3636 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3637 motivated by the fact that memory allocation needs to be outside
3638 the critical section.
3639
0c16dfed
DA
36402012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3641
3642 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3643 with RESET_INTERVAL.
3644
3645 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3646 Remove duplicated buffer name initialization.
3647
3f83ace8
JM
36482012-05-02 Jim Meyering <jim@meyering.net>
3649
3650 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3651
c7b8541e
JM
3652 * xfns.c (x_window): Use xstrdup (Bug#11375).
3653
90207a15 36542012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3655
3656 * xdisp.c (pos_visible_p): If already at a newline from the
3657 display string before the 'while' loop, don't walk back the glyphs
3658 from it3.glyph_row. Solves assertion violation when the display
3659 string begins with a newline (egg.el). (Bug#11367)
3660
b593d6a9
AH
36612012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3662
3663 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3664 Move to simple.el.
3665
4737362e
GM
36662012-05-01 Glenn Morris <rgm@gnu.org>
3667
99cf43f9
GM
3668 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3669 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3670 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3671 All were removed before 23.1.
3672
9311dcff
GM
3673 * dispnew.c: Remove HAVE_LIBNCURSES test;
3674 it is always true on relevant platforms.
3675
4d5c6349
GM
3676 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3677 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3678
4737362e
GM
3679 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3680
74dd3a6b
AS
36812012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3682
3683 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3684 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3685 Remove.
3686
13c379ee
PE
36872012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3688
3689 Do not avoid creating empty evaporating overlays (Bug#9642).
3690 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3691 That is, do not delete an evaporating overlay if it becomes
3692 empty after its bounds are adjusted to fit within its buffer.
3693 This fix caused other problems, and I'm reverting it until we get
3694 to the bottom of them.
3695
a8e7d6d7 36962012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3697
3698 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3699
a8e7d6d7 37002012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3701
3702 * xdisp.c (pos_visible_p): If the window start position is beyond
3703 ZV, start the display from buffer beginning. Prevents assertion
3704 violation in init_iterator when the minibuffer window is scrolled
3705 via the scroll bar.
3706
3707 * window.c (window_scroll_pixel_based): Likewise.
3708
a8e7d6d7 37092012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3710
3711 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3712
a8e7d6d7 37132012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3714
3715 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3716 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3717
a8e7d6d7 37182012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3719
b593d6a9
AH
3720 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3721 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3722
1c6900d9
EZ
37232012-04-26 Eli Zaretskii <eliz@gnu.org>
3724
4c3fa1d9
EZ
3725 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3726 display element, check also the underlying string or buffer
3727 character. (Bug#11341)
3728
1c6900d9
EZ
3729 * w32menu.c: Include w32heap.h.
3730 (add_menu_item): If the call to AppendMenuW (via
3731 unicode_append_menu) fails, disable Unicode menus only if we are
3732 running on Windows 9X/Me.
3733
42bf8205
AS
37342012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3735
3736 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3737 (xgetint): Add missing shift for LSB tags.
3738
b1bac16e
MR
37392012-04-24 Martin Rudalics <rudalics@gmx.at>
3740
3741 * keyboard.c (read_char): Don't wipe echo area for select window
3742 events: These might get delayed via `mouse-autoselect-window'
3743 (Bug#11304).
3744
d69621cc
JB
37452012-04-24 Juanma Barranquero <lekktu@gmail.com>
3746
3747 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3748 manipulation of :loaded-from data.
3749
02fd101b
JB
37502012-04-23 Juanma Barranquero <lekktu@gmail.com>
3751
3752 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3753 now a cons (bug#11311).
3754
888bec30
PE
37552012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3756
89a438bd
PE
3757 Do not create empty overlays with the evaporate property (Bug#9642).
3758 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3759 if it becomes empty after its bounds are adjusted to fit within
3760 its buffer. Without this fix, in a nonempty buffer (let ((o
3761 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3762 yields an empty overlay that has the evaporate property, which is
3763 not supposed to happen.
3764
1068fe4d
PE
3765 Fix minor GTK3 problems found by static checking.
3766 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3767 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3768 (struct _EmacsFixedClass, emacs_fixed_get_type):
3769 Move decls here from emacsgtkfixed.h, since they needn't be public.
3770 (emacs_fixed_get_type): Now static.
3771 (emacs_fixed_class_init): Omit unused local.
3772 (emacs_fixed_child_type): Remove; unused.
3773 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3774 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3775 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3776 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3777 (EMACS_FIXED_GET_CLASS): Remove; unused.
3778 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3779
888bec30
PE
3780 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3781 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3782
de85e130
PE
37832012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3784
d0baac98 3785 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3786 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3787 (__malloc_size_t, __malloc_ptrdiff_t):
3788 Remove. All uses removed, replaced by the definiens if needed,
3789 since we can assume C89 or better now.
3790 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3791 (protect_malloc_state, align, get_contiguous_space)
3792 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3793 (malloc_atfork_handler_child, malloc_enable_thread)
3794 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3795 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3796 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3797 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3798 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3799 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3800 Define using prototypes, not old style.
3801 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3802 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3803 (align): Don't assume that signed integer overflow wraps around.
3804 Omit unused local var.
3805 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3806 (_free_internal_nolock, memalign, mallochook, reallochook):
3807 Omit no-longer-needed casts.
3808 (valloc): Use getpagesize, not __getpagesize.
3809 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3810 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3811
de85e130
PE
3812 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3813
dcbf5805
MA
38142012-04-22 Michael Albinus <michael.albinus@gmx.de>
3815
3816 Move functions from C to Lisp. Make non-blocking method calls
3817 the default. Implement further D-Bus standard interfaces.
3818
3819 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3820 (QCdbus_request_name_allow_replacement)
3821 (QCdbus_request_name_replace_existing)
3822 (QCdbus_request_name_do_not_queue)
3823 (QCdbus_request_name_reply_primary_owner)
3824 (QCdbus_request_name_reply_in_queue)
3825 (QCdbus_request_name_reply_exists)
3826 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3827 (QCdbus_registered_serial, QCdbus_registered_method)
3828 (QCdbus_registered_signal): New Lisp objects.
3829 (XD_DEBUG_MESSAGE): Use sizeof.
3830 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3831 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3832 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3833 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3834 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3835 (xd_signature, xd_append_arg): Allow float for integer types.
3836 (xd_get_connection_references): New function.
b593d6a9
AH
3837 (xd_get_connection_address): Rename from xd_initialize.
3838 Return cached address.
dcbf5805
MA
3839 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3840 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3841 level.
3842 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3843 Return number of refcounts.
dcbf5805
MA
3844 (Fdbus_get_unique_name): Make stronger parameter check.
3845 (Fdbus_message_internal): New defun.
3846 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3847 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3848 (Fdbus_send_signal, Fdbus_register_service)
3849 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3850 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3851 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3852 (Vdbus_compiled_version, Vdbus_runtime_version)
3853 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3854 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3855 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3856 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3857 Adapt docstring.
dcbf5805 3858
52828e02
PE
38592012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3860
da05bc4c
PE
3861 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3862 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3863 Do not assume ptrdiff_t is the same width as 'int'.
3864
52828e02
PE
3865 * alloc.c: Handle unusual debugging option combinations.
3866 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3867 since the two debugging options are incompatible.
3868 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3869 is defined.
3870 (mem_init, mem_insert, mem_insert_fixup):
3871 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3872 (NEED_MEM_INSERT): Remove; no longer needed.
3873
f01769f9
LL
38742012-04-22 Leo Liu <sdl.web@gmail.com>
3875
3876 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3877
5790543d
PE
38782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3879
3880 * sysdep.c [__FreeBSD__]: Minor cleanups.
3881 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3882 Use Emacs indenting style more consistently. Avoid some casts.
3883 Use 'double' consistently rather than mixing 'float' and 'double'.
3884
b91b7e4d
EW
38852012-04-21 Eduard Wiebe <usenet@pusto.de>
3886
b593d6a9
AH
3887 * sysdep.c (list_system_processes, system_process_attributes):
3888 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3889
6114eb15
AS
38902012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3891
3892 * lisp.mk (lisp): Update.
3893
2f38dff7
PE
38942012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3895
3896 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3897 It is never used otherwise.
3898
4ae29f89
SM
38992012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3900
3901 * print.c (print_preprocess): Only check print_depth if print-circle
3902 is nil.
3903 (print_object): Check for cycles even when print-circle is nil and
3904 print-gensym is t, but only check print_depth if print-circle is nil.
3905
f30d612a
CY
39062012-04-20 Chong Yidong <cyd@gnu.org>
3907
3908 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3909 set the status to "failed" and ensure that sentinel is run.
3910
c07a4c0b 39112012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3912
3913 * process.c (Fset_process_inherit_coding_system_flag)
3914 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3915 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3916
c07a4c0b 39172012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3918
3919 * xdisp.c (string_buffer_position_lim): Limit starting position to
3920 BEGV.
3921 (set_cursor_from_row): If called for a mode-line or header-line
3922 row, return zero immediately.
3923 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3924 farther than the first row after the header line, if any.
3925 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3926 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3927
c07a4c0b 39282012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3929
4ae29f89
SM
3930 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3931 (bug#11238).
ad3a2b41 3932
c07a4c0b 39332012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 39342012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3935
3936 configure: new option --enable-gcc-warnings (Bug#11207)
3937 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3938 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3939 (ALL_CFLAGS): Use new macros rather than old.
3940 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3941 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3942 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3943 -Wunused-result, -Wunused-variable. This should go away once
3944 the Emacs and Gnulib regex code is merged.
3945 (xmalloc, xrealloc): Now static.
3946
aba027e8
PE
39472012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3948
3949 * dired.c (Fsystem_groups): Remove unused local.
3950
e5a36063
GM
39512012-04-17 Glenn Morris <rgm@gnu.org>
3952
3953 * dired.c (Fsystem_users): Doc fix.
3954
316411f0
DA
39552012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3956
3957 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3958 (syms_of_dired): Add them.
3959
9426aba4
PE
39602012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3961
b62a57be
PE
3962 Fix minor alloc.c problems found by static checking.
3963 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3964 New extern decls, to avoid calling undeclared functions.
3965 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3966 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3967 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3968 (NEED_MEM_INSERT): New macro.
3969 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3970 Remove one incorrect comment and fix another.
b62a57be 3971
3539f31f
PE
3972 Fix minor ralloc.c problems found by static checking.
3973 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3974 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3975 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3976 (r_alloc_sbrk): Now static.
3977
a041960a
PE
3978 Improve ralloc.c interface checking.
3979 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3980 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3981 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3982 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3983 [REL_ALLOC]: ... to here, to check interface.
3984 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3985 Remove decls. This fixes an "It stinks!".
3986
9426aba4
PE
3987 * alloc.c (which_symbols): Fix alignment issue / type clash.
3988
d55c12ed
AS
39892012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3990
3991 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3992 (struct Lisp_Misc_Any): Likewise.
3993 (struct Lisp_Free): Likewise.
3994 * alloc.c (union aligned_Lisp_Symbol): Define.
3995 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3996 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3997 (union aligned_Lisp_Misc): Define.
3998 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3999 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4000 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4001
b948ce8b
PE
40022012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4003
4004 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4005 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4006 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4007 * s/netbsd.h, s/sol2-6.h:
4008 Remove definition of GC_MARK_STACK, since the default now works.
4009 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4010 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4011 no longer the default.
4012 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4013
35dc09a1 40142012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4015
35dc09a1
GM
4016 * lread.c (lisp_file_lexically_bound_p):
4017 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4018
35dc09a1
GM
40192012-04-14 Eli Zaretskii <eliz@gnu.org>
4020
4021 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4022 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4023
40242012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4025
4026 * nsterm.m (constrainFrameRect): Always constrain when there is only
4027 one screen (Bug#10962).
4028
bcd86815
KB
40292012-04-13 Ken Brown <kbrown@cornell.edu>
4030
4031 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4032
c25df26e
RT
40332012-04-13 Reuben Thomas <rrt@sc3d.org>
4034
4035 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4036
0fc59f1e
DC
40372012-04-11 Daniel Colascione <dancol@dancol.org>
4038
4039 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4040 against is gone. It's better to use vfork now so that when Cygwin
4041 gains a new, working vfork, we use it automatically (bug#10398).
4042
de8c03dc
SM
40432012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4044
4045 * window.c (save_window_save): Obey window-point-insertion-type.
4046
2f097256
GM
40472012-04-11 Glenn Morris <rgm@gnu.org>
4048
4049 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4050
453b951e
SM
40512012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4052
4053 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4054
75f1671a 40552012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4056
4057 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4058 (force_quit_count): New var.
4059 (handle_interrupt): Use it.
4060
2a8ce227
JB
40612012-04-10 Juanma Barranquero <lekktu@gmail.com>
4062
4063 * w32.c (w32_delayed_load): Record the full path of the library
4064 being loaded (bug#10424).
4065
935396c0
GM
40662012-04-09 Glenn Morris <rgm@gnu.org>
4067
05920a43
GM
4068 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4069 not just in the obarray, before snarfing them. (Bug#11036)
4070
935396c0
GM
4071 * Makefile.in ($(leimdir)/leim-list.el):
4072 Pass EMACS rather than BUILT_EMACS.
4073
a18ecafa
TZ
40742012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4075
4076 * process.c (make_process):
4077 * process.h: Add integer `gnutls_handshakes_tried' member to
4078 process struct.
4079
6bbef4e5
JC
4080 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4081 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4082
4083 * gnutls.c (gnutls_log_function2i): Convenience log function.
4084 (emacs_gnutls_read): Use new log functions,
4085 `gnutls_handshakes_tried' process member, and
4086 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4087 attempts per process (connection).
4088
b4d3bc10
CY
40892012-04-09 Chong Yidong <cyd@gnu.org>
4090
4091 * eval.c (Fuser_variable_p, user_variable_p_eh)
4092 (lisp_indirect_variable): Functions deleted.
4093 (Fdefvar): Caller changed.
4094
4095 * callint.c (Finteractive, Fcall_interactively):
4096 * minibuf.c (Fread_variable): Callers changed.
4097
70f4d973
EZ
40982012-04-09 Eli Zaretskii <eliz@gnu.org>
4099
4100 * xdisp.c (set_cursor_from_row): If the display string appears in
4101 the buffer at position that is closer to point than the position
4102 after the display string, display the cursor on the first glyph of
4103 the display string. Fixes cursor display when a 'display' text
4104 property immediately follows invisible text. (Bug#11094)
4105
cb3c2e3e
PE
41062012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4107
4108 composite.c: use 'double' consistently
4109 * composite.c (get_composition_id): Use 'double' consistently
4110 instead of converting 'float' to 'double' and vice versa; this is
4111 easier to understand and avoids a GCC warning.
4112
fd06db5d
GM
41132012-04-09 Glenn Morris <rgm@gnu.org>
4114
50fe702a
GM
4115 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4116 preparation for dumping it with emacs. (Bug#4789)
4117 (leimdir): New variable.
4118 ($(leimdir)/leim-list.el): New rule.
4119 (emacs$(EXEEXT)): Depend on leim-list.el.
4120
fd06db5d
GM
4121 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4122 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4123 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4124
55c131ee
AS
41252012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4126
4127 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4128 proper alignment.
4129
9209588f
JB
41302012-04-07 Juanma Barranquero <lekktu@gmail.com>
4131
4132 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4133 Remove unused local variable.
4134
e3fb2efb
PE
41352012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4136
4137 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4138 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4139 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4140 objects, as mark_maybe_pointer will catch them otherwise.
4141 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4142 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4143
b5385551
PE
41442012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4145
4146 Fix typo that broke non-Windows builds.
4147 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4148
9078ead6
EZ
41492012-04-07 Eli Zaretskii <eliz@gnu.org>
4150
4151 Support building on MS-Windows with libxml2.
4152
4153 * makefile.w32-in (OBJ2): Add xml.$(O).
4154 (GLOBAL_SOURCES): Add xml.c.
4155 ($(BLD)/xml.$(O)): New dependency list.
4156
4157 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4158 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4159 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4160 [!WINDOWSNT]: New macros.
4161 (init_libxml2_functions, libxml2_loaded_p): New functions.
4162 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4163 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4164 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4165 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4166 linked in).
6bbef4e5
JC
4167 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4168 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4169 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4170
4171 * emacs.c: Don't include libxml/parser.h.
4172 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4173 xmlCleanupParser directly.
4174
4175 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4176
3811fdf3
EZ
41772012-04-07 Eli Zaretskii <eliz@gnu.org>
4178
4179 * indent.c (Fvertical_motion): If there is a display string at
4180 point, use it.vpos to compute how many lines to backtrack after
4181 move_it_to point. (Bug#11133)
4182
2f8e16b2
EZ
41832012-04-06 Eli Zaretskii <eliz@gnu.org>
4184
4185 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4186 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4187 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4188 macros related to unification of CJK characters. For the details,
4189 see the discussion following the message here:
4190 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4191
3d439cd1
CY
41922012-04-04 Chong Yidong <cyd@gnu.org>
4193
4194 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4195
8bc53d00
EZ
41962012-04-01 Eli Zaretskii <eliz@gnu.org>
4197
4198 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4199 instead of alloca. (Bug#11138)
4200
3b0512a3
AS
42012012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4202
4203 * w32menu.c (is_simple_dialog): Properly check lisp types.
4204 (Bug#11141)
4205
8427ddd2
EZ
42062012-03-31 Eli Zaretskii <eliz@gnu.org>
4207
979022ef
EZ
4208 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4209 position we get to after a call to move_it_to fails the
4210 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4211 only if we wind up in a string from display property. (Bug#11063)
4212
a6b1c7cc
EZ
4213 * window.c (Fdelete_other_windows_internal): Invalidate the row
4214 and column information about mouse highlight, so that redisplay
4215 restores it after reallocating the glyph matrices. (Bug#7464)
4216
8427ddd2
EZ
4217 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4218 string comes from a `display' text property, use the buffer
4219 position of that property as if we actually saw that position in
4220 the row's glyphs.
697ba24b
EZ
4221 (move_it_by_lines): Remove the assertion that
4222 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4223 violated when there's a before-string at the beginning of a line.
4224 (Bug#11063)
8427ddd2 4225
65a0a738
EZ
42262012-03-30 Eli Zaretskii <eliz@gnu.org>
4227
4228 * xdisp.c (append_space_for_newline): If the default face was
4229 remapped, use the remapped face for the appended newline.
4230 (extend_face_to_end_of_line): Use the remapped default face for
4231 extending the face to the end of the line.
4232 (display_line): Call extend_face_to_end_of_line when the default
4233 face was remapped. (Bug#11068)
4234
581355cc
EZ
42352012-03-29 Eli Zaretskii <eliz@gnu.org>
4236
4237 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4238
e8fc049f
SM
42392012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4240
4241 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4242
4fb9a543
GM
42432012-03-27 Glenn Morris <rgm@gnu.org>
4244
4245 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4246 Doc fixes.
4247
679910f1
KH
42482012-03-26 Kenichi Handa <handa@m17n.org>
4249
4250 * dispextern.h (struct glyph): Fix previous change. Change the
4251 bit length of glyphless.ch to 25 (Bug#11082).
4252
90d49b7f
CY
42532012-03-26 Chong Yidong <cyd@gnu.org>
4254
4255 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4256 (command_loop_1): Use it; inhibit selection update for
4257 handle-select-window too (Bug#8996).
4258
f514f6f0
FP
42592012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4260
e8fc049f 4261 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4262
bf43fa51
KH
42632012-03-25 Kenichi Handa <handa@m17n.org>
4264
4265 * dispextern.h (struct glyph): Change the bit length of
4266 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4267
8a0c01dd
EZ
42682012-03-24 Eli Zaretskii <eliz@gnu.org>
4269
4270 * s/ms-w32.h (tzname): Include time.h before redirecting to
4271 _tzname. Fixes the MSVC build. (Bug#9960)
4272
7d1c3a76
AS
42732012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4274
8ed79523
AS
4275 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4276 characters.
4277
7d1c3a76
AS
4278 * xterm.c (XTread_socket): Only modify handling_signal if
4279 !SYNC_INPUT. (Bug#11080)
4280
e99a9b8b
EZ
42812012-03-23 Eli Zaretskii <eliz@gnu.org>
4282
4283 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4284 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4285 when fetching a multibyte character consumes more bytes than
4286 CHAR_BYTES returns, due to unification of CJK characters in
4287 string_char. (Bug#11073)
4288
5063c0e1
TN
42892012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4290
4291 * process.c (wait_reading_process_output): Handle pty disconnect
4292 by refraining from sending oneself a SIGCHLD (bug#10933).
4293
9f851fbd
CY
42942012-03-22 Chong Yidong <cyd@gnu.org>
4295
4296 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4297
5063c0e1 4298 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4299 Mark string as coming from a prefix property.
4300 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4301 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4302
fb5b8aca
CY
43032012-03-21 Chong Yidong <cyd@gnu.org>
4304
4305 * xfaces.c (Vface_remapping_alist): Doc fix.
4306
62356a1b
EZ
43072012-03-20 Eli Zaretskii <eliz@gnu.org>
4308
4309 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4310 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4311 Doc fixes.
62356a1b 4312
025de85b
CY
43132012-03-20 Chong Yidong <cyd@gnu.org>
4314
4315 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4316 to reflect default non-nil value of redisplay-dont-pause.
4317
4827f94e
KH
43182012-03-19 Kenichi Handa <handa@m17n.org>
4319
4320 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4321 it fit in a valid range (Bug#11003).
4322
e50a24a2
EZ
43232012-03-18 Eli Zaretskii <eliz@gnu.org>
4324
4325 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4326 that is not from display property, accept the row as a "cursor
4327 row" if one of the string's character has a non-nil `cursor'
4328 property. Fixes cursor positioning when there are newlines in
4329 overlay strings, e.g. in icomplete.el. (Bug#11035)
4330
9af5ed87
PE
43312012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4332
4333 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4334
d1f55f16
CY
43352012-03-12 Chong Yidong <cyd@gnu.org>
4336
4337 * eval.c (inhibit_lisp_code): Rename from
4338 inhibit_window_configuration_change_hook; move from window.c.
4339
4340 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4341 * window.c (run_window_configuration_change_hook)
4342 (syms_of_window): Callers changed.
4343
66c5eebd
CY
43442012-03-11 Chong Yidong <cyd@gnu.org>
4345
413df973
CY
4346 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4347
66c5eebd
CY
4348 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4349
1de11f56
CY
43502012-03-10 Chong Yidong <cyd@gnu.org>
4351
4352 * frame.c (other_visible_frames): Don't assume the selected frame
4353 is visible (Bug#10955).
4354
cae07000
SM
43552012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4356
4357 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4358
89c94350
JD
43592012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4360
4361 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4362 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4363 zero (Bug#10954).
4364
999dd333
GM
43652012-03-03 Glenn Morris <rgm@gnu.org>
4366
01a6dcc8 4367 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4368
de0100f2
EZ
43692012-03-02 Eli Zaretskii <eliz@gnu.org>
4370
4371 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4372 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4373 (redisplay_window, next_element_from_string): Fix typos in
4374 comments.
3e441275
EZ
4375 (redisplay_window): Pass to move_it_vertically the margin in
4376 pixels, not in screen lines.
de0100f2 4377
96a72ee9
GM
43782012-03-02 Glenn Morris <rgm@gnu.org>
4379
4380 * buffer.c (buffer-list-update-hook): Doc fix.
4381
312508d7
EZ
43822012-02-29 Eli Zaretskii <eliz@gnu.org>
4383
4384 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4385 push_it before setting up the iterator for the first overlay
4386 string, even if we have an empty string loaded.
4387 (next_overlay_string): If there's an empty string on the iterator
4388 stack, pop the stack. (Bug#10903)
4389
27f3c637
PE
43902012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4391
4392 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4393 Suggested by Stefan Monnier in
4394 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4395 * alloc.c (widen_to_Lisp_Object): New static function.
4396 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4397 and widening them to Lisp_Objects. This would work even if
4398 USE_LSB_TAG is defined and wide integers are used, which might
4399 happen in a future version of Emacs.
4400
3c9dfce6
CY
44012012-02-25 Chong Yidong <cyd@gnu.org>
4402
fa74b241
CY
4403 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4404 Doc fix.
4405
3c9dfce6
CY
4406 * xselect.c (Fx_selection_exists_p): Doc fix.
4407 (x_clipboard_manager_save_all): Print an informative message
4408 before saving to clipboard manager.
4409
9486df08
CY
44102012-02-24 Chong Yidong <cyd@gnu.org>
4411
4412 * keyboard.c (process_special_events): Handle all X selection
4413 requests in kbd_buffer, not just the next one (Bug#8869).
4414
f01d3321
CY
44152012-02-23 Chong Yidong <cyd@gnu.org>
4416
4417 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4418 call when setting menu-bar-lines and tool-bar-lines parameters.
4419 (unwind_create_frame_1): New helper function.
4420
4421 * window.c (inhibit_window_configuration_change_hook): New var.
4422 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4423 (syms_of_window): Initialize it.
f01d3321 4424
86b847b6
CY
44252012-02-22 Chong Yidong <cyd@gnu.org>
4426
4427 * xterm.c (x_draw_image_relief): Add missing type check for
4428 Vtool_bar_button_margin (Bug#10743).
4429
a59225b1
CY
44302012-02-21 Chong Yidong <cyd@gnu.org>
4431
4432 * fileio.c (Vfile_name_handler_alist): Doc fix.
4433
4434 * buffer.c (Fget_file_buffer): Protect against invalid file
4435 handler return value.
4436
310f5bd4
PE
44372012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4438
cb3a28cc
PE
4439 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4440 when computing $valmask.
4441
310f5bd4
PE
4442 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4443 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4444 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4445 It's useless in that case, and it can cause problems on hosts
4446 that allocate halves of EMACS_INT values separately.
4447 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4448 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4449 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4450 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4451 it avoids undefined behavior on hosts where shifting right by more
4452 than the word width has undefined behavior.
4453
2375c96a
CY
44542012-02-19 Chong Yidong <cyd@gnu.org>
4455
4456 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4457 (Funhandled_file_name_directory, Ffile_name_as_directory)
4458 (Fdirectory_file_name, Fexpand_file_name)
4459 (Fsubstitute_in_file_name): Protect against invalid file handler
4460 return values (Bug#10845).
4461
3eb49e71
EZ
44622012-02-18 Eli Zaretskii <eliz@gnu.org>
4463
4464 * .gdbinit (pitx): Fix incorrect references to fields of the
4465 iterator stack.
4466
7b926f3f
CY
44672012-02-17 Chong Yidong <cyd@gnu.org>
4468
4469 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4470
11273115
PE
44712012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4472
4473 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4474 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4475
c3a70e2b
CY
44762012-02-15 Chong Yidong <cyd@gnu.org>
4477
4478 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4479 marked as special. Also, starting docstrings with * is obsolete.
4480
0ca43699
AS
44812012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4482
4483 * gnutls.c (emacs_gnutls_write): Fix last change.
4484
2e8f3c56
LI
44852012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4486
4487 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4488 send_process.
4489
af70074f
SM
44902012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4491
4492 * keymap.c (Fsingle_key_description): Handle char ranges.
4493
95986d52
CY
44942012-02-12 Chong Yidong <cyd@gnu.org>
4495
afd83bd1
CY
4496 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4497 as that creates a dangerous corner case.
4498
95986d52
CY
4499 * window.c (Fdelete_window_internal): Invalidate the mouse
4500 highlight (Bug#9904).
4501
bd7da63e
GM
45022012-02-12 Glenn Morris <rgm@gnu.org>
4503
4504 * xselect.c (Fx_own_selection_internal)
4505 (Fx_get_selection_internal, Fx_disown_selection_internal)
4506 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4507 * nsselect.m (Fx_own_selection_internal)
4508 (Fx_disown_selection_internal, Fx_selection_exists_p)
4509 (Fx_selection_owner_p, Fx_get_selection_internal):
4510 Sync docs and argument specs with the xselect.c versions.
4511
77abcbc2
LI
45122012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4513
4514 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4515
90b671e2
EZ
45162012-02-11 Eli Zaretskii <eliz@gnu.org>
4517
1c0ca0b7
EZ
4518 * w32select.c (Fx_selection_exists_p): Sync doc string and
4519 argument list with xselect.c. (Bug#10783)
4520
4521 * w16select.c (Fx_selection_exists_p): Sync doc string and
4522 argument list with xselect.c. (Bug#10783)
90b671e2 4523
49241268
GM
45242012-02-10 Glenn Morris <rgm@gnu.org>
4525
4526 * fns.c (Fsecure_hash): Doc fix.
4527
f998bbe7 45282012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4529
4530 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4531
0992bd9c
CY
45322012-02-07 Chong Yidong <cyd@gnu.org>
4533
4534 * buffer.c (Fbuffer_local_variables)
4535 (buffer_lisp_local_variables): Handle unbound vars correctly;
4536 don't let Qunbound leak into Lisp.
4537
af008560
GM
45382012-02-07 Glenn Morris <rgm@gnu.org>
4539
dd605cc4
GM
4540 * image.c (Fimagemagick_types): Doc fix.
4541
af008560
GM
4542 * image.c (imagemagick-render-type): Change it from a lisp object
4543 to an integer. Move the doc here from the lisp manual.
4544 Treat all values not equal to 0 the same.
4545
1449fa1d
CY
45462012-02-06 Chong Yidong <cyd@gnu.org>
4547
4548 * doc.c (store_function_docstring): Avoid applying docstring of
4549 alias to base function (Bug#2603).
4550
3723ec07
AS
45512012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4552
4553 * .gdbinit (pp1, pv1): Remove redundant defines.
4554 (pr): Use pp.
4555
79c1cc1e
CY
45562012-02-04 Chong Yidong <cyd@gnu.org>
4557
4558 * nsterm.m: Declare a global (Bug#10694).
4559
d7f29f8e
EZ
45602012-02-04 Eli Zaretskii <eliz@gnu.org>
4561
cae07000
SM
4562 * w32.c (get_emacs_configuration_options):
4563 Include --enable-checking, if specified, in the return value.
d7f29f8e 4564
3b95a6f9
MR
45652012-02-04 Martin Rudalics <rudalics@gmx.at>
4566
4567 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4568 after rounding frame sizes. (Bug#9723)
4569
d6fa96a6
EZ
45702012-02-04 Eli Zaretskii <eliz@gnu.org>
4571
4572 * keyboard.c (adjust_point_for_property): Don't position point
4573 before BEGV. (Bug#10696)
4574
df0b2940
PE
45752012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4576
4577 Handle overflow when computing char display width (Bug#9496).
4578 * character.c (char_width): Return EMACS_INT, not int.
4579 (char_width, c_string_width): Check for overflow when
4580 computing the width; this is possible now that individual
4581 characters can have unbounded width. Problem introduced
4582 by merge from Emacs 23 on 2012-01-19.
4583
6bee44d6
MA
45842012-02-02 Michael Albinus <michael.albinus@gmx.de>
4585
4586 * dbusbind.c (Fdbus_register_method): Mention the return value
4587 :ignore in the docstring.
4588
44f92739
GM
45892012-02-02 Glenn Morris <rgm@gnu.org>
4590
1b9f60cc
GM
4591 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4592
44f92739
GM
4593 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4594 Unconditionally set to t. (Bug#10673)
4595 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4596 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4597 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4598
c5d3843c
KH
45992012-02-02 Kenichi Handa <handa@m17n.org>
4600
4601 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4602 0, do not call append_composite_glyph.
4603
159462d4 46042012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4605
4606 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4607 NULL (Bug#6988).
4608 (x_produce_glyphs): If the component of a composition is a null
4609 string, set it->pixel_width to 1 to avoid zero-width glyph.
4610
78cef877
EZ
46112012-02-01 Eli Zaretskii <eliz@gnu.org>
4612
4613 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4614 first 2 arguments are identical. This makes inserting large
4615 output from a subprocess an order of magnitude faster on
4616 MS-Windows, where all sbrk'ed memory is always contiguous.
4617
97897668
GM
46182012-01-31 Glenn Morris <rgm@gnu.org>
4619
4620 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4621 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4622 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4623
31fd3586
GM
46242012-01-29 Glenn Morris <rgm@gnu.org>
4625
4626 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4627
0e24a8b2
CY
46282012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4629
4630 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4631
cc0adcb0
CY
46322012-01-28 Chong Yidong <cyd@gnu.org>
4633
4634 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4635
acc28cb9
CY
46362012-01-26 Chong Yidong <cyd@gnu.org>
4637
9c69cfb7
CY
4638 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4639
acc28cb9
CY
4640 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4641 repeat counts (Bug#10507).
4642
48da7392
GM
46432012-01-26 Glenn Morris <rgm@gnu.org>
4644
4645 * lread.c (syms_of_lread): Doc fix.
4646
14af5f7f
CY
46472012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4648
4649 * coding.c (encode_designation_at_bol): Change return value to
4650 EMACS_INT.
4651
0b21c100
CY
46522012-01-25 Chong Yidong <cyd@gnu.org>
4653
4654 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4655
3c2907f7
CY
46562012-01-21 Chong Yidong <cyd@gnu.org>
4657
4658 * floatfns.c (Fcopysign): Make the second argument non-optional,
4659 since nil is not allowed anyway.
4660
959ad23f
AS
46612012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4662
4663 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4664 (send_process): Likewise.
4665
34a02f46
MR
46662012-01-19 Martin Rudalics <rudalics@gmx.at>
4667
4668 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4669 (Vwindow_persistent_parameters): Do not use Qstate.
4670 Rewrite doc-strings.
34a02f46 4671
1259009a 46722012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4673
4674 * character.c (char_width): New function.
70d4fdf6
GM
4675 (Fchar_width, c_string_width, lisp_string_width):
4676 Use char_width (Bug#9496).
25ed9e61 4677
6a6ee00d
MR
46782012-01-16 Martin Rudalics <rudalics@gmx.at>
4679
4680 * window.c (Vwindow_persistent_parameters): New variable.
4681 (Fset_window_configuration, save_window_save): Handle persistent
4682 window parameters.
4683
c85efaf7
EZ
46842012-01-14 Eli Zaretskii <eliz@gnu.org>
4685
4686 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4687 thrashing the stack of the thread. (Bug#9087)
4688
5944709e
PE
46892012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4690
4691 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4692
e71f5d99
EZ
46932012-01-11 Eli Zaretskii <eliz@gnu.org>
4694
4695 * xdisp.c (rows_from_pos_range): Handle the case where the
4696 highlight ends on a newline. (Bug#10464)
4697 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4698 he end column for display of highlight that ends on a newline
4699 before a R2L line.
4700
ce316182
GM
47012012-01-11 Glenn Morris <rgm@gnu.org>
4702
4703 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4704 from load-path also when installation-directory is nil. (Bug#10208)
4705
5b43da69
GM
47062012-01-10 Glenn Morris <rgm@gnu.org>
4707
74cc8ff9
GM
4708 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4709
7d8d6e4e
GM
4710 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4711 Update template values to be closer to their typical values these days.
5b43da69 4712
a0db8d43
EZ
47132012-01-09 Eli Zaretskii <eliz@gnu.org>
4714
4715 * xdisp.c (rows_from_pos_range): Accept additional argument
4716 DISP_STRING, and accept any glyph in a row whose object is that
4717 string as eligible for mouse highlight. Fixes mouse highlight of
4718 display strings from overlays. (Bug#10464)
4719
9a0115ab 47202012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4721
b9110d6a 4722 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4723 * fileio.c (auto_saving_dir_umask): New static var.
4724 (Fmake_directory_internal): Use it.
4725 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4726 creating the directory. The old code temporarily assigns
4727 too-generous permissions to the directory.
4728 (do_auto_save_eh): Clear it.
b9110d6a 4729 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4730 that the var is always cleared.
4731
6c1bd3f3
EZ
47322012-01-07 Eli Zaretskii <eliz@gnu.org>
4733
4734 * search.c (scan_buffer): Pass character positions to
4735 know_region_cache, not byte positions. (Bug#6540)
4736
069d2b50
L
47372012-01-07 LynX <_LynX@bk.ru> (tiny change)
4738
4739 * w32.c (sys_rename): Report EXDEV when rename of a directory
4740 fails because the target is on another logical disk. (Bug#10284)
4741
75bf0d33
DB
47422012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4743
4744 * xterm.c (x_embed_request_focus): New function.
4745
4746 * xterm.h: Add prototype.
4747
4748 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4749
1c6e5a32
GM
47502012-01-05 Glenn Morris <rgm@gnu.org>
4751
4752 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4753
651e947e
EZ
47542012-01-01 Eli Zaretskii <eliz@gnu.org>
4755
4756 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4757 Load gnutls_transport_set_lowat only if GnuTLS version is below
4758 2.11.1.
4759 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4760 GnuTLS versions below 2.11.1.
4761
3778cdd8
AL
47622011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4763
4764 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4765 to the doc string advising against its use for altering the way
4766 windows are scrolled.
4767
0e5317f7
KH
47682011-12-28 Kenichi Handa <handa@m17n.org>
4769
4770 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4771 coding-system ASCII compatible only when it does not produce BOM
4772 on encoding (Bug#10383).
4773
93d5ca1f
JD
47742011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4775
4776 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4777 can scroll.
4778 (create_and_show_popup_menu): Always use menu_position_func for
4779 Gtk3 (Bug#10361).
4780
ca22b785
AS
47812011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4782
4783 * callint.c (Fcall_interactively): Don't truncate prompt string.
4784
d048e1e6
EZ
47852011-12-23 Eli Zaretskii <eliz@gnu.org>
4786
4787 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4788 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4789 resumed from there (after widening). (Bug#10360)
d048e1e6 4790
5ccaba1f
JD
47912011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4792
4793 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4794
204ee57f
JD
47952011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4796
b81d40f0
JB
4797 * nsterm.m (x_free_frame_resources):
4798 Release f->output_data.ns->miniimage.
204ee57f
JD
4799 (ns_index_color): Fix indentation. Do not retain
4800 color_table->colors[i].
4801
4802 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4803 before returning.
4804
4805 * nsfns.m (x_set_background_color): Assign return value from
4806 ns_index_color to face-background instead of NSColor*.
4807 (ns_implicitly_set_icon_type): Fix indentation.
4808 Change assignment in for loop to comparison.
4809
4810 * emacs.c (ns_pool): New variable.
4811 (main): Assign ns_pool.
4812 (Fkill_emacs): Call ns_release_autorelease_pool.
4813
4814 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4815 autorelease fdesc, release fdAttrs and tdict.
4816 (ns_get_covering_families): Release charset.
4817 (ns_findfonts): Release NSFontDescriptor created with new.
4818 (ns_uni_to_glyphs): Fix indentation.
4819 (setString): Release attrStr before assigning new value.
4820
c803b2b7
JD
48212011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4822
678f4426
JD
4823 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4824 and NS_IMPL_COCOA.
4825 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4826 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4827
cd394be1 48282011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4829
5fecd5fc
JD
4830 * nsterm.m (ns_term_init): Subscribe for notifications
4831 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4832 to method trackingNotification in EmacsMenu.
4833
4834 * nsmenu.m (trackingMenu): New variable.
3771cb17 4835 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4836 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4837 from Aquamacs (Bug#7030).
678f4426
JD
4838
48392011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4840
c803b2b7
JD
4841 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4842 (symbol_to_nsstring): Fix indentation.
4843 (ns_symbol_to_pb): New function.
cae07000
SM
4844 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4845 (Fns_rotate_cut_buffers_internal): Remove.
4846 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4847 Fns_store_cut_buffer_internal.
4848 (ns_get_foreign_selection, Fx_own_selection_internal)
4849 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4850 (Fns_get_selection_internal, Fns_store_selection_internal):
4851 Use ns_symbol_to_pb and check if return value is nil.
4852 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4853 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4854 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4855 renamed to Sns_store_selection_internal.
4856 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4857 and remove this function.
4858 (ns_handle_selection_clear): Remove, never used.
4859 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4860 here.
4861
e1b01a3a
KB
48622011-12-17 Ken Brown <kbrown@cornell.edu>
4863
4864 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4865 GID is unknown (Bug#10257).
4866
2adb6e85
PE
48672011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4868
4869 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4870 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4871 which caused a build failure on GNU/Linux IA-64. This problem was
4872 introduced by my 2011-10-07 patch.
4873
d1d7b339
JL
48742011-12-15 Juri Linkov <juri@jurta.org>
4875
4876 * image.c (imagemagick_error): New function. (Bug#10112)
4877 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4878 Use `imagemagick_error' where ImageMagick functions return
4879 `MagickFalse'.
4880 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4881 proper order.
4882
100d5755
KH
48832011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4884
4885 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4886 fill background (Bug#8992).
4887
454592a6
MR
48882011-12-13 Martin Rudalics <rudalics@gmx.at>
4889
4890 * window.c (Vwindow_combination_resize)
4891 (Vwindow_combination_limit): Use t instead of non-nil in
4892 doc-strings.
61d4b438
MR
4893 (Vrecenter_redisplay): Add first sentence of doc-string on
4894 separate line.
53524d93 4895 (Frecenter): Fix doc-string typo.
454592a6 4896
3633e3aa
KH
48972011-12-11 Kenichi Handa <handa@m17n.org>
4898
4899 * coding.c (Funencodable_char_position): Pay attention to the
4900 buffer text relocation (Bug#9389).
4901
7b9d523a 49022011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4903
7b9d523a
JD
4904 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4905 gtk_init (Bug#10100).
4906
b73189c6
EZ
49072011-12-10 Eli Zaretskii <eliz@gnu.org>
4908
4909 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4910 IT->string is nil. (Bug#10263)
4911
f7dfe5d6
JD
49122011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4913
83faebb4
JD
4914 * nsterm.h (x_free_frame_resources): Declare.
4915
f7dfe5d6
JD
4916 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4917 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4918
4919 * nsterm.h (ns_get_defaults_value): Declare.
4920
4921 * nsterm.m (ns_default): Call ns_get_defaults_value.
4922
7cd4e72c
EZ
49232011-12-09 Eli Zaretskii <eliz@gnu.org>
4924
4925 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4926 (Bug#10170)
4927
b34d7317
YM
49282011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4929
4930 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4931 that where the value of an _OBJC_* symbol points to is in the .bss
4932 section (Bug#10240).
4933
76470ad1
KH
49342011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4935
4936 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4937 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4938
745fff94
KH
49392011-12-08 Kenichi Handa <handa@m17n.org>
4940
4941 * ftfont.c (get_adstyle_property): Fix previous change
4942 (Bug#10233).
4943
6e44397c
JB
49442011-12-07 Juanma Barranquero <lekktu@gmail.com>
4945
4946 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4947 dirs from the default value of EMACSLOADPATH (bug#10208).
4948
7efa6272
GM
49492011-12-07 Glenn Morris <rgm@gnu.org>
4950
4951 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4952 installation and source directories as well. (Bug#10208)
4953
f6fc4d87
CY
49542011-12-06 Chong Yidong <cyd@gnu.org>
4955
4956 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4957
2bf26180
GM
49582011-12-06 Glenn Morris <rgm@gnu.org>
4959
4960 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4961 as an error, not just -1. (Bug#10217)
4962
3a6ad4f0
CY
49632011-12-05 Chong Yidong <cyd@gnu.org>
4964
4965 * keyboard.c (process_special_events): New function.
4966 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4967
75a3b399
PE
49682011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4969
4970 * coding.c (encode_designation_at_bol): Don't use uninitialized
4971 local variable (Bug#9318).
4972
c3c9e25e
KH
49732011-12-05 Kenichi Handa <handa@m17n.org>
4974
4975 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4976 return Qnil (Bug#8046, Bug#10193).
4977
5eb05ea3
KH
49782011-12-05 Kenichi Handa <handa@m17n.org>
4979
4980 * coding.c (encode_designation_at_bol): New args charbuf_end and
4981 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4982 (coding_set_source): Return how many bytes coding->source was
4983 relocated.
4984 (coding_set_destination): Return how many bytes
4985 coding->destination was relocated.
4986 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4987 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4988
49892011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4990
4991 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4992 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4993 macro (Bug#9318).
4994
49952011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4996
4997 The following changes are to fix Bug#9318.
4998
a79703f5 4999 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5000 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5001 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5002 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5003
7dbda6df
JB
50042011-12-05 Juanma Barranquero <lekktu@gmail.com>
5005
5006 * lisp.h (process_quit_flag): Fix external declaration.
5007
6d5eb5b0
SM
50082011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5009
5010 Don't macro-inline non-performance-critical code.
5011 * eval.c (process_quit_flag): New function.
5012 * lisp.h (QUIT): Use it.
5013
a0c3fad0
JD
50142011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5015
5016 * nsfns.m (get_geometry_from_preferences): New function.
5017 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5018
6c07aac2
AS
50192011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5020
5021 * emacs.c (Qkill_emacs): Define.
5022 (syms_of_emacs): Initialize it.
5023 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5024 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5025 (quit_throw_to_read_char): Add parameter `from_signal'.
5026 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5027 * lisp.h (QUIT): Call Fkill_emacs if requested.
5028
c052ead4
JD
50292011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5030
5031 * widget.c (update_wm_hints): Return if wmshell is null.
5032 (widget_update_wm_size_hints): New function.
5033
5034 * widget.h (widget_update_wm_size_hints): Declare.
5035
5036 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5037 widget_update_wm_size_hints (Bug#10104).
5038
9e49252b
EZ
50392011-12-03 Eli Zaretskii <eliz@gnu.org>
5040
5041 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5042 before a newline, prepare the bidi iterator for consuming the
5043 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5044 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5045
02b16839
JL
50462011-12-02 Juri Linkov <juri@jurta.org>
5047
5048 * search.c (Fword_search_regexp): New Lisp function created from
5049 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5050 (Fword_search_backward, Fword_search_forward)
5051 (Fword_search_backward_lax, Fword_search_forward_lax):
5052 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5053 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5054
0068070e
SM
50552011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5056
5057 * fileio.c (Finsert_file_contents): Move after-change-function call
5058 to before the "handled:" label, since all "goto handled" appear in
5059 cases where the *-change-functions have already been properly called
5060 (bug#10117).
5061
3360a3fc
AS
50622011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5063
5064 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5065 waiting for input. (Bug#10169)
5066
73d6c093
EZ
50672011-11-30 Eli Zaretskii <eliz@gnu.org>
5068
5069 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5070 verifies glyph row's hash code--we have just reallocated the
5071 glyphs, so their contents can be complete garbage. (Bug#10164)
5072
febe6bea
JB
50732011-11-30 Juanma Barranquero <lekktu@gmail.com>
5074
5075 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5076
801a4313
EZ
50772011-11-30 Eli Zaretskii <eliz@gnu.org>
5078
5079 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5080 attributes are tested _before_ calling verify_row_hash, to protect
5081 against GCC re-ordering of the tests. (Bug#10164)
5082
2b56b87e
JD
50832011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5084
5085 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5086
5087 * xterm.c (handle_one_xevent): Only set async_visible and friends
5088 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5089 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5090 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5091
dbf31225
PE
50922011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5093
5094 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5095 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5096 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5097 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5098 All uses changed to use GCPRO1 etc.
5099 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5100 Revert to old implementation (i.e., before 2011-03-11).
5101
1305621b
YM
51022011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5103
5104 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5105 of scroll runs so as to avoid assigning disabled bogus rows and
5106 unnecessary graphics copy operations.
5107
8c9afb46
EZ
51082011-11-27 Eli Zaretskii <eliz@gnu.org>
5109
5110 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5111 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5112 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5113 (malloc, free, realloc, calloc): Redirect to e_* only when
5114 compiling Emacs.
5115
5116 * lisp.h (GCTYPEBITS): Move before first use.
5117 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5118 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5119 this macro definition.
5120
5121 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5122 _MSC_VER.
5123
54e9e3bf
JD
51242011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5125
6d5eb5b0
SM
5126 * gtkutil.c (xg_create_frame_widgets):
5127 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5128 present with Gtk+ 2.0.
5129
83aca1cb
PE
51302011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5131
5132 * fileio.c (Finsert_file_contents): Undo previous change; see
5133 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5134
5b76caa4
PE
51352011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5136
5137 Rename locals to avoid shadowing.
5138 * fileio.c (Finsert_file_contents):
5139 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5140 * process.c (wait_reading_process_output):
5141 Rename inner 'proc' to 'p' to avoid shadowing.
5142 Indent for consistency with usual Emacs style.
5143
8c535114
EZ
51442011-11-25 Eli Zaretskii <eliz@gnu.org>
5145
5146 * xdisp.c (redisplay_window): If cursor row is not fully visible
5147 after recentering, and scroll-conservatively is set to a large
5148 number, scroll window by a few more lines to make the cursor fully
5149 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5150 (start_display): Don't move to the next line if the display should
5151 start at a newline that is part of a display vector or an overlay
5152 string. (Bug#10119)
8c535114 5153
fa4fdb5c
JL
51542011-11-24 Juri Linkov <juri@jurta.org>
5155
5156 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5157 after the `MagickPingImage' call. (Bug#10112)
5158
90ec88df
CY
51592011-11-23 Chong Yidong <cyd@gnu.org>
5160
5161 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5162
56e2e794
MR
51632011-11-23 Martin Rudalics <rudalics@gmx.at>
5164
5165 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5166 making another buffer current. (Bug#10114)
5167
b6e64c41
GM
51682011-11-23 Glenn Morris <rgm@gnu.org>
5169
5170 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5171
6b21de18
CY
51722011-11-23 Chong Yidong <cyd@gnu.org>
5173
5174 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5175 using it (Bug#5984).
5176
b12cd789
EZ
51772011-11-22 Eli Zaretskii <eliz@gnu.org>
5178
5179 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5180 and header-lines, as they don't have one computed for them.
5181 (Bug#10098)
5182
5183 * .gdbinit (prow): Make displayed values more self-explaining.
5184 Add row's hash code.
5185
261b6fd4
LMI
51862011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5187
5188 * process.c (wait_reading_process_output): Fix asynchrounous
5189 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5190 (wait_reading_process_output): Add comment and URL.
261b6fd4 5191
e7cfd277
JD
51922011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5193
5194 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5195
a9b9b7f5
CY
51962011-11-21 Chong Yidong <cyd@gnu.org>
5197
5198 * window.c (Fnext_window, Fprevious_window): Doc fix.
5199
b0d15b4f
SM
52002011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5201
5202 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5203
fe7a3057
JB
52042011-11-20 Juanma Barranquero <lekktu@gmail.com>
5205
5206 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5207
d2999b1a
MR
52082011-11-20 Martin Rudalics <rudalics@gmx.at>
5209
5210 * window.c (Fset_window_combination_limit): Rename argument
5211 STATUS to LIMIT.
5212 (Vwindow_combination_limit): Remove "status" from doc-string.
5213
d5ff9cd0
AS
52142011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5215
5216 * m/ibms390.h: Remove.
5217 * m/ibms390x.h: Don't include "ibms390.h".
5218
a5bb9bd3
SM
52192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5220
5221 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5222 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5223
cd1181db
JB
52242011-11-20 Juanma Barranquero <lekktu@gmail.com>
5225
5226 * casetab.c (Fset_case_table):
5227 * charset.c (Fcharset_after): Fix typos.
5228
615a3b8d 52292011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5230
17e845af
PE
5231 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5232 Otherwise, valgrind does not work on some platforms.
5233 Problem reported by Andreas Schwab in
6a0bf43d
PE
5234 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5235 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5236 is set, removing the need for VIRT_ADDRESS_VARIES.
5237 (PURE_P): Use a more-efficient implementation that needs just one
5238 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5239 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5240 to 4 (xorl, subq, cmpq, setbe).
5241 * alloc.c (pure): Always extern now, since that's the
5242 VIRT_ADDR_VARIES behavior.
5243 (PURE_POINTER_P): Use a single comparison, not two, for
5244 consistency with the new puresize.h.
5245 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5246 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5247 Remove VIRT_ADDR_VARIES no longer needed.
5248
f8fe6f96
EZ
52492011-11-19 Eli Zaretskii <eliz@gnu.org>
5250
5251 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5252 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5253 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5254 behave as if the cursor position were at the window margin.
5255
5256 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5257 and the cursor position is out of bounds, behave as if the cursor
5258 position were at the window margin. (Bug#10075)
5259
df05a53c
CY
52602011-11-18 Chong Yidong <cyd@gnu.org>
5261
5262 * window.c (Fwindow_combination_limit): Make first argument
5263 non-optional, since it is meaningless for live windows like the
5264 selected window.
61ccba97 5265
2071918e
DA
52662011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5267
5268 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5269
b50a28de
SM
52702011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5271
5272 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5273 (graft_intervals_into_buffer): Simplify.
5274
015137db
EZ
52752011-11-18 Eli Zaretskii <eliz@gnu.org>
5276
5277 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5278 hash values of the two rows.
5279 (copy_row_except_pointers): Preserve the used[] arrays and the
5280 hash values of the two rows. (Bug#10035)
68c95424 5281 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5282
5283 * xdisp.c (row_hash): New function, body extracted from
5284 compute_line_metrics.
5285 (compute_line_metrics): Call row_hash, instead of computing the
5286 hash code inline.
5287
5288 * dispnew.c (verify_row_hash): Call row_hash for computing the
5289 hash code of a row, instead of duplicating code from xdisp.c.
5290
5291 * dispextern.h (row_hash): Add prototype.
5292
a2addb04
TH
52932011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5294
5295 * frame.c (delete_frame): Don't delete the terminal when the last
5296 X frame is closed if emacs is built with GTK toolkit.
5297
df85d315
JB
52982011-11-17 Juanma Barranquero <lekktu@gmail.com>
5299
5300 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5301
a0c2d0ae
MR
53022011-11-17 Martin Rudalics <rudalics@gmx.at>
5303
5304 * window.c (Vwindow_splits): Rename to
5305 Vwindow_combination_resize. Suggested by Juri Linkov.
5306 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5307 of Vwindow_splits.
5308
58179cce
JB
53092011-11-16 Juanma Barranquero <lekktu@gmail.com>
5310
7877f373
JB
5311 * nsfns.m (Fns_font_name):
5312 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5313
b6f67890
MR
53142011-11-16 Martin Rudalics <rudalics@gmx.at>
5315
5316 * window.h (window): Rename slot "nest" to "combination_limit".
5317 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5318 (Fset_window_nest): Rename to Fset_window_combination_limit.
5319 (Vwindow_nest): Rename to Vwindow_combination_limit.
5320 (recombine_windows, make_parent_window, make_window)
5321 (Fsplit_window_internal, saved_window)
5322 (Fset_window_configuration, save_window_save): Rename all
5323 occurrences of window_nest to window_combination_limit.
5324
c7015153
JB
53252011-11-15 Juanma Barranquero <lekktu@gmail.com>
5326
5327 * image.c (imagemagick_load_image): Fix typo.
5328
322ad6ec
EZ
53292011-11-14 Eli Zaretskii <eliz@gnu.org>
5330
5331 * xdisp.c (display_line): Move the call to
5332 highlight_trailing_whitespace before the call to
5333 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5334 faces of all the glyphs to compute ROW's hash value.
5335 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5336
f067b8ec
JB
53372011-11-14 Juanma Barranquero <lekktu@gmail.com>
5338
5339 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5340 just return (bug#10044).
5341
1e5b2111
EZ
53422011-11-12 Eli Zaretskii <eliz@gnu.org>
5343
7ef3cbd5
EZ
5344 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5345 with user-defined heap size. Bump the default size of the temacs
5346 heap to 27MB, to avoid memory warning when running temacs.
5347 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5348
1e5b2111
EZ
5349 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5350 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5351 (verify_row_hash) [XASSERTS]: New function.
5352 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5353 that the hash value of glyph rows is correct.
1e5b2111 5354
89d61221
MR
53552011-11-12 Martin Rudalics <rudalics@gmx.at>
5356
5357 * window.h (window): Remove splits slot.
5358 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5359 (Fdelete_other_windows_internal, make_parent_window)
5360 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5361 (Fset_window_configuration, save_window_save): Don't deal with
5362 split status of windows.
5363 (saved_window): Remove splits slot.
5364 (Vwindow_splits): Rewrite doc-string.
5365
97f18cc8
JD
53662011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5367
5368 * xfns.c (unwind_create_frame):
5369 * nsfns.m (unwind_create_frame):
5370 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5371 Vframe_list (Bug#9999).
5372
22a648b4
DA
53732011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5374
0b381c7e 5375 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5376
659afede
KH
53772011-11-11 Kenichi Handa <handa@m17n.org>
5378
5379 * callproc.c (Fcall_process): Set the member dst_multibyte of
5380 process_coding.
5381
9ac0394b
KH
53822011-11-11 Johan Bockgård <bojohan@gnu.org>
5383
5384 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5385 avoid a crash (bug#9496).
5386
2fbdc249
CY
53872011-11-09 Chong Yidong <cyd@gnu.org>
5388
5389 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5390 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5391
ac6b1f81
PE
53922011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5393
5394 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5395
09db192c
PE
53962011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5397
5398 Avoid some portability problems by eschewing 'extern inline' functions.
5399 The trivial performance wins aren't worth the portability hassles; see
5400 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5401 et seq.
5402 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5403 (window_box_width, window_box_left, window_box_left_offset)
5404 (window_box_right, window_box_right_offset): Undo previous change,
5405 by removing the "extern"s.
5406 * intervals.c (adjust_intervals_for_insertion)
5407 (adjust_intervals_for_deletion): Undo previous change,
5408 making these static again.
5409 (offset_intervals, temp_set_point_both, temp_set_point)
5410 (copy_intervals_to_string): No longer inline.
5411 * xdisp.c (window_text_bottom_y, window_box_width)
5412 (window_box_height, window_box_left_offset)
5413 (window_box_right_offset, window_box_left, window_box_right)
5414 (window_box): No longer inline.
5415
105216ed
CY
54162011-11-08 Chong Yidong <cyd@gnu.org>
5417
5418 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5419 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5420 Signal an error if not a live window.
105216ed
CY
5421 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5422 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5423
ae9e237f
JB
54242011-11-07 Juanma Barranquero <lekktu@gmail.com>
5425
5426 * lisp.h (syms_of_abbrev): Remove declaration.
5427 Reported by CHENG Gao <chenggao@royau.me>.
5428
c7aa8333
EZ
54292011-11-07 Eli Zaretskii <eliz@gnu.org>
5430
5431 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5432 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5433 of temacs in GUI mode.
5434
be7f5545
MR
54352011-11-07 Martin Rudalics <rudalics@gmx.at>
5436
5437 * window.h: Declare delete_all_child_windows instead of
5438 delete_all_subwindows.
5439 * window.c (Fwindow_nest, Fset_window_nest)
5440 (Fset_window_new_total, Fset_window_new_normal)
5441 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5442 (delete_all_subwindows): Rename to delete_all_child_windows.
5443 (Fdelete_other_windows_internal, Fset_window_configuration):
5444 Call delete_all_child_windows instead of delete_all_subwindows.
5445 * frame.c (delete_frame): Call delete_all_child_windows instead
5446 of delete_all_subwindows.
5447
ca78dc43
PE
54482011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5449
5450 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5451 This is also needed for porting to any host where GC_MARK_STACK is
5452 not GC_MAKE_GCPROS_NOOPS.
5453 (which_symbols): Use it.
5454
a0241d01
KH
54552011-11-07 Kenichi Handa <handa@m17n.org>
5456
5457 * coding.c (coding_set_destination): Check coding->src_pos only
5458 when coding->src_object is a buffer (bug#9910).
5459
5460 * process.c (send_process): Set the member src_multibyte of coding
5461 to 0 (bug#9911) when sending a unibyte text.
5462
5463 * callproc.c (Fcall_process): Set the member src_multibyte of
5464 process_coding to 0 (bug#9912).
5465
a64bfdfa 54662011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5467
5468 * xmenu.c (cleanup_widget_value_tree): New function.
5469 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5470 calling free_menubar_widget_value_tree directly (Bug#9830).
5471
cb41b32a
PE
54722011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5473
5474 Fix some portability problems with 'inline'.
5475 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5476 (window_box_width, window_box_left, window_box_left_offset)
5477 (window_box_right, window_box_right_offset): Declare extern.
5478 Otherwise, these inline functions do not conform to C99 and
5479 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5480 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5481 * intervals.c (adjust_intervals_for_insertion)
5482 (adjust_intervals_for_deletion): Now extern, because otherwise the
5483 extern inline functions 'offset_intervals' couldn't refer to it.
5484 (static_offset_intervals): Remove.
5485 (offset_intervals): Rewrite using the old contents of
5486 static_offset_intervals. The old version didn't conform to C99
5487 because an extern inline function contained a reference to an
5488 identifier with static linkage.
5489
b7041366
AS
54902011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5491
5492 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5493 GC.
5494
88a37c4d
EZ
54952011-11-06 Eli Zaretskii <eliz@gnu.org>
5496
5497 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5498 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5499 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5500 return Qleft_to_right.
5501
49745b39
CY
55022011-11-06 Chong Yidong <cyd@gnu.org>
5503
5504 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5505 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5506 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5507 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5508 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5509 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5510 (Fwindow_vscroll): Doc fix.
5511 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5512 argument, since it makes no sense to pass a live window and for
5513 consistency with window-child.
5514
1f05cd82
CS
55152011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5516
5517 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5518 support MSVC.
5519
22610910
JR
55202011-11-05 Jason Rumney <jasonr@gnu.org>
5521
5522 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5523 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5524 fonts (Bug#6029).
5525 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5526 bitwise arithmetic preventing use of unicode-sip and non-truetype
5527 opentype fonts.
5528
a06776b2
EZ
55292011-11-05 Eli Zaretskii <eliz@gnu.org>
5530
3ad924ba
EZ
5531 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5532 "emacs"-only part.
5533
a06776b2
EZ
5534 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5535 initialization code to keep similarity to xfns.c after changes
5536 from 2011-11-05.
5537
c9e7db78
JD
55382011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5539
a97f8f3f
JD
5540 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5541 (unwind_create_frame): New function (Bug#9943).
5542 (Fx_create_frame): Restructure code to be more similar to the one in
5543 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5544 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5545 Move terminal->reference_count++ just before making the frame official
5546 (Bug#9943).
5547
5548 * nsterm.m (x_free_frame_resources): New function.
5549 (x_destroy_window): Move code to x_free_frame_resources.
5550
c9e7db78 5551 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5552 (Fx_create_frame, x_create_tip_frame):
5553 Move terminal->reference_count++ just before making the frame
75f1671a 5554 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5555 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5556
a6fc3b5c
EZ
55572011-11-05 Eli Zaretskii <eliz@gnu.org>
5558
5559 Support MSVC build with newer versions of Visual Studio.
5560 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5561 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5562 nt/gmake.defs.
5563
5564 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5565 which are not supported by MSVC.
5566 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5567 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5568 bitfields.
5569 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5570 types in bitfields.
5571 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5572
5573 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5574
58179cce 55752011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5576
5577 Support MSVC build with newer versions of Visual Studio.
5578 * w32.c: Don't include w32api.h for MSVC.
5579 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5580
5581 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5582 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5583 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5584 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5585 e_* cousins.
5586 (alloca) [_MSC_VER]: Define to _alloca.
5587
5588 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5589
5590 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5591
a58c13ed
EZ
55922011-11-04 Eli Zaretskii <eliz@gnu.org>
5593
5594 * xdisp.c (note_mouse_highlight): If either of
5595 previous/next-single-property-change returns nil, treat that as
5596 the beginning or the end of the buffer. (Bug#9955)
5597
fe0b6370
JD
55982011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5599
a58c13ed 5600 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5601 label is not null (Bug#9951).
5602 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5603 may be NULL.
5604
89bd5ee1
EZ
56052011-11-04 Eli Zaretskii <eliz@gnu.org>
5606
5607 * window.c (Fwindow_body_size): Mention in the doc string that the
5608 return value is in frame's canonical units. (Bug#9949)
5609
84c3edb9
EZ
56102011-11-03 Eli Zaretskii <eliz@gnu.org>
5611
4e2fb5c7
EZ
5612 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5613
84c3edb9 5614 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5615 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5616 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5617
bc17a887
EZ
56182011-11-01 Eli Zaretskii <eliz@gnu.org>
5619
5620 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5621 Don't stop backward scan on the continuation glyph, even though
5622 its CHARPOS is positive.
6d5eb5b0
SM
5623 (mouse_face_from_buffer_pos, note_mouse_highlight):
5624 Rename cover_string to disp_string.
bc17a887 5625
4ee88440
MR
56262011-11-01 Martin Rudalics <rudalics@gmx.at>
5627
5628 * window.c (temp_output_buffer_show): Don't use
5629 Vtemp_buffer_show_specifiers.
5630 (Vtemp_buffer_show_specifiers): Remove unused variable.
5631
c2ff3c02
EZ
56322011-10-30 Eli Zaretskii <eliz@gnu.org>
5633
5634 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5635 past the beginning of the current glyph matrix.
5636
58179cce 56372011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5638
5639 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5640 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5641 HAVE_GTK3 (Bug#9869).
b77a6a7f 5642
3b574623
JD
5643 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5644 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5645
b77a6a7f
JD
5646 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5647
5648 * xterm.c: Declare x_handle_net_wm_state to return int.
5649 (handle_one_xevent): Check if we are iconified but don't have
5650 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5651 (get_current_wm_state): Return non-zero if not hidden,
5652 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5653 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5654 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5655 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5656
196e41e4
PE
56572011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5658
5659 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5660 so that this new function doesn't get optimized away by a
5661 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5662
021f2e1a
AS
56632011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5664
5665 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5666
8b058d44
EZ
56672011-10-29 Eli Zaretskii <eliz@gnu.org>
5668
5669 Fix the `xbytecode' command.
5670 * .gdbinit (xprintbytestr): New command.
b50a28de 5671 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5672 (xbytecode): Print the byte-code string as well.
5673
4452fb80
EZ
56742011-10-29 Kim Storm <storm@cua.dk>
5675
8b058d44
EZ
5676 * alloc.c (which_symbols): New function.
5677
21b72067
AS
56782011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5679
5680 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5681 line. (Bug#9903)
5682
83ed7b5c
GM
56832011-10-29 Glenn Morris <rgm@gnu.org>
5684
5685 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5686 Not clear what it was for, and it causes various bugs. (Bug#9839)
5687
5a7a728b
EZ
56882011-10-28 Eli Zaretskii <eliz@gnu.org>
5689
5690 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5691 possible random value that matches one of those tested as
5692 condition to clear the mouse face.
5693
d3d0842f
CY
56942011-10-28 Chong Yidong <cyd@gnu.org>
5695
5696 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5697
31b39d13
DN
56982011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5699
5700 * window.c (make_window): Initialize phys_cursor_on_p.
5701
9aba6043
SM
57022011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5703
5704 * lisp.h (struct Lisp_Symbol): Update comments.
5705
c20992f4
JB
57062011-10-28 Juanma Barranquero <lekktu@gmail.com>
5707
5708 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5709
db4f02f2
EZ
57102011-10-28 Eli Zaretskii <eliz@gnu.org>
5711
5712 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5713 <oslsachem@gmail.com> for helping to debug this.
5714
5715 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5716 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5717 (g_b_init_get_glyph_outline_w): New static variables.
5718 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5719 (GetGlyphOutlineW_Proc): New typedefs.
5720 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5721 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5722 New functions.
5723 (w32font_open_internal, compute_metrics):
5724 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5725 instead of calling the "wide" APIs directly.
5726
5727 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5728
5729 * w32.h (syms_of_w32font): Add prototype.
5730
87e68db4
JB
57312011-10-27 Juanma Barranquero <lekktu@gmail.com>
5732
5733 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5734 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5735 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5736 (Fmove_to_window_line): Doc fix.
5737
435c1d67
CY
57382011-10-27 Chong Yidong <cyd@gnu.org>
5739
5740 * process.c (make_process): Set gnutls_state to NULL.
5741
5742 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5743 non-NULL, regardless of GNUTLS_INITSTAGE.
5744 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5745 an error. Set process slots as soon as we allocate them.
5746
5747 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5748
9c6c6f49
CY
57492011-10-27 Chong Yidong <cyd@gnu.org>
5750
9aba6043
SM
5751 * gnutls.c (emacs_gnutls_deinit): New function.
5752 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5753 (Fgnutls_deinit, Fgnutls_boot): Use it.
5754
5755 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5756 (deactivate_process): Call emacs_gnutls_deinit.
5757
657d08d3
JB
57582011-10-27 Juanma Barranquero <lekktu@gmail.com>
5759
5760 * image.c (x_create_x_image_and_pixmap):
5761 * w32.c (sys_rename, w32_delayed_load):
5762 * w32font.c (fill_in_logfont):
5763 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5764
5430d399
JB
57652011-10-26 Juanma Barranquero <lekktu@gmail.com>
5766
5767 * w32fns.c (w32_default_color_map): New function,
5768 extracted from Fw32_default_color_map.
a7ef684b 5769 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5770
fe0055fa
PE
57712011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5772
5773 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5774
e6346438
SM
57752011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5776
5777 * keyboard.c (test_undefined): New function (bug#9751).
5778 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5779
e112cc37
ET
57802011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5781
5782 * sysdep.c (init_sys_modes): Fix the check for the controlling
5783 terminal (Bug#6649).
5784
7b5d6677
EZ
57852011-10-20 Eli Zaretskii <eliz@gnu.org>
5786
5787 * dispextern.h (struct bidi_it): New member next_en_type.
5788
5789 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5790 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5791 current character, check also for next_en_type being WEAK_EN.
5792 (bidi_resolve_weak): Don't enter the expensive loop if the current
5793 position is before next_en_pos. Record the bidi type of the first
5794 non-ET, non-BN character we find, in addition to its position.
5795 (bidi_level_of_next_char): Invalidate next_en_type when
5796 next_en_pos is over-stepped.
5797
7da0b018
PE
57982011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5799
5800 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5801 * editfns.c: Rewrite current-time-zone so that it invokes
5802 the equivalent of (format-time-string "%Z") to get the time zone name.
5803 This fixes a bug when the time zone name contains characters that
5804 need converting from the system time locale to Emacs internal format.
5805 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5806 that patch fixed format-time-string to do the conversion, but
5807 I forgot to fix current-time-zone.
5808 (format_time_string): New function, containing most of
5809 what Fformat_time_string used to contain.
5810 (Fformat_time_string): Rewrite in terms of format_time_string.
5811 This doesn't change this function's behavior.
5812 (current-time-zone): Rewrite to use format_time_string.
5813 This fixes the bug reported by Michael Schierl in
5814 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5815 Jason Rumney's 2007-06-07 change worked around this bug, but
5816 didn't fix it.
5817 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5818
8547b010
EZ
58192011-10-19 Eli Zaretskii <eliz@gnu.org>
5820
5821 * xdisp.c (start_display): If the character at POS is displayed
5822 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5823 (try_window_reusing_current_matrix): If a line ends in a display
5824 vector or the next line starts in a display vector, continue
5825 redrawing the window even though the character position of
5826 start_row was reached.
8547b010
EZ
5827 (Bug#9771, part 2)
5828
4e948d15
CY
58292011-10-18 Chong Yidong <cyd@gnu.org>
5830
5831 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5832 with nobreak-char-display too.
5833
4787455f
EZ
58342011-10-18 Eli Zaretskii <eliz@gnu.org>
5835
5836 Fix part 3 of bug#9771.
5837 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5838 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5839 non-neutral characters if the current character is a paragraph
5840 separator (a.k.a. Newline). This avoids running the same
5841 expensive loop twice, once when we consume the preceding newline
5842 and the other time when the line actually needs to be displayed.
5843 Avoid the loop when we see neutrals on the base embedding level
5844 following a character whose directionality is the same as the
5845 paragraph's. This avoids running the expensive loop when a line
5846 ends in a long sequence of neutrals, like control characters.
5847 Add assertion against STRONG_AL type. Slightly rearrange code
5848 that determines the type of a neutral given the first non-neutral
5849 that follows it.
5850 (bidi_level_of_next_char): Set next_en_pos to zero when
5851 invalidating its info.
5852
2c91f553
EZ
58532011-10-17 Eli Zaretskii <eliz@gnu.org>
5854
5855 * xdisp.c (push_display_prop): Determine whether to record string
5856 or buffer position by IT->string, not by IT->method. Allow
5857 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5858 (move_it_vertically_backward): Don't look for character position
5859 immediately after the newline when in a continuation line.
5860 (Bug#9771, part 1)
2c91f553 5861
c7b08b0d
MR
58622011-10-15 Martin Rudalics <rudalics@gmx.at>
5863
5864 * window.c (coordinates_in_window): Rewrite and delabelize
5865 vertical border check. (Bug#5357) (Bug#9618)
5866
6b02f655
SM
58672011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5868
5869 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5870 errors in XSetWindowBorder (bug#9310).
5871
81d40c92
DA
58722011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5873
5874 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5875 avoid crash when xmalloc overrun checking is enabled.
5876
d4172c3b
EZ
58772011-10-13 Eli Zaretskii <eliz@gnu.org>
5878
5879 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5880 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5881 cursor motion with <left> and <right> arrow keys.
5882
5883 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5884 some callers set that themselves.
5885
b00eea75
EZ
58862011-10-12 Eli Zaretskii <eliz@gnu.org>
5887
5888 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5889 display string and the previous row comes from the same string and
5890 is empty. (Bug#9739) (Bug#9738)
5891
8fe012c4
SM
58922011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5893
5894 * doc.c (get_doc_string): Encode file name (bug#9735).
5895
0074aef2
EZ
58962011-10-12 Eli Zaretskii <eliz@gnu.org>
5897
79beb178
EZ
5898 * bidi.c (bidi_level_of_next_char):
5899 * xdisp.c (get_visually_first_element): Remove old incorrect
5900 comments regarding the Unicode Line Separator character.
5901
0074aef2
EZ
5902 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5903
6e4b3fbe
DA
59042011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5905
5906 * alloc.c (Fgc_status): Do not access beyond zombies array
5907 boundary if nzombies > MAX_ZOMBIES.
5908 * alloc.c (dump_zombies): Add missing format specifier.
5909
0324f3af
PE
59102011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5911
b5525cac
PE
5912 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5913 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5914
0324f3af
PE
5915 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5916 Some packages use them to denote characters with modifiers.
5917
e9b5f888
AS
59182011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5919
5920 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5921 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5922 matching a pp-number. Rename parameter var to var1.
5923
127827c0
SM
59242011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5925
5926 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5927
c8fd3bd0
GM
59282011-10-08 Glenn Morris <rgm@gnu.org>
5929
5930 * callint.c (Fcall_interactively): Give a more explicit error for the
5931 'c' case with a non-character input. (Bug#8479)
5932
352ec8ff
EZ
59332011-10-08 Eli Zaretskii <eliz@gnu.org>
5934
03669ccb
EZ
5935 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5936 lines.
7061c986
EZ
5937 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5938 lines that are hscrolled on the left.
03669ccb 5939
352ec8ff
EZ
5940 * dispnew.c (buffer_posn_from_coords): Account for a possible
5941 presence of header-line. (Bug#4426)
5942
a66cfb1c
SM
59432011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5944
6b02f655
SM
5945 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5946 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5947
7c5ee88e
PE
59482011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5949
5950 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5951 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5952 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5953 this makes Emacs dump core during garbage collection on rare
5954 occasions. sizeof is obviously inferior to offsetof here, so
5955 stick with offsetof.
5956 (GC_POINTER_ALIGNMENT): New macro.
5957 (mark_memory): Omit 3rd (offset) arg; caller changed.
5958 Don't assume EMACS_INT alignment is the same as pointer alignment.
5959
df1bbe5b
SM
59602011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5961
5962 * keyboard.c (read_key_sequence_remapped): New var.
5963 (read_key_sequence): Compute remapping in the right buffer.
5964 (command_loop_1): Use read_key_sequence's remapping directly.
5965
51553db6
SM
59662011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5967
32c1fffd
SM
5968 * dired.c (file_name_completion): Don't expand file name.
5969 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5970 before checking file name handler.
5971
51553db6
SM
5972 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5973 they've been requested explicitly (bug#9591).
5974
b6bd1599 59752011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5976
5977 * keymap.c (Fsingle_key_description): Use make_specified_string
5978 instead of build_string to build string from push_key_description.
5979 (Bug#5193)
5980
f701dc2a
PE
59812011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5982
4222c55d
PE
5983 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5984 This fixes a Y2038 bug on 64-bit hosts.
5985 * buffer.c (reset_buffer):
5986 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5987 (Fclear_buffer_auto_save_failure):
5988 Use 0, not -1, to represent an unset failure time, since time_t
5989 might not be signed.
5990
f701dc2a
PE
5991 Remove dependency on glibc malloc internals.
5992 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5993 Move back here from lisp.h, but with their new implementations.
5994 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5995 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5996 * charset.c (charset_table_init): New static var.
5997 (syms_of_charset): Use it instead of xmalloc. This removes a
5998 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5999 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6000 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6001 Move back to alloc.c.
6002 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6003 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6004
9ceebf39
JD
60052011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6006
6007 * nsterm.m (windowDidResize): Call x_set_window_size only when
6008 ns_in_resize is true. Otherwise set pixelwidth/height and
6009 call change_frame_size (Bug#9628).
6010
cb993c58
PE
60112011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6012
3930c88b
PE
6013 Port --enable-checking=all to Fedora 14 x86-64.
6014 * charset.c (syms_of_charset): Also account for glibc malloc's
6015 internal overhead when calculating the initial malloc maximum.
6016
cb993c58
PE
6017 Port --enable-checking=all to Fedora 14 x86.
6018 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6019 Move to lisp.h.
6020 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6021 (overrun_check_realloc, overrun_check_free):
6022 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6023 That way, xmalloc returns a properly-aligned pointer even if
6024 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6025 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6026 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6027 into account when calculating the initial malloc maximum.
6028 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6029 Move here from alloc.c, so that charset.c can use it too.
6030 Properly align; the old code wasn't right for common 32-bit hosts
6031 when configured with --enable-checking=all.
6032 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6033 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6034
31bed486
EZ
60352011-09-29 Eli Zaretskii <eliz@gnu.org>
6036
04c70788 6037 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6038 use EDOM.
6039
fbcaa2f3
EZ
60402011-09-28 Eli Zaretskii <eliz@gnu.org>
6041
6042 * xdisp.c (compute_display_string_end): If there's no display
6043 string at CHARPOS, return -1.
6044
6045 * bidi.c (bidi_fetch_char): When compute_display_string_end
6046 returns a negative value, treat the character as a normal
6047 character not covered by a display string. (Bug#9624)
6048
a239d4e9
JB
60492011-09-28 Juanma Barranquero <lekktu@gmail.com>
6050
6051 * lread.c (Fread_from_string): Fix typo in docstring.
6052
88652fd5
EZ
60532011-09-27 Eli Zaretskii <eliz@gnu.org>
6054
6055 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6056 newline, reseat the iterator instead of bidi-iterating there one
6057 character at a time. (Bug#9610)
32c1fffd
SM
6058 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6059 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6060
ed497dd4
AS
60612011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6062
6063 * lread.c (readevalloop): Use correct code for NBSP.
6064 (read1): Likewise. (Bug#9608)
6065
b2bf61aa
MA
60662011-09-25 Michael Albinus <michael.albinus@gmx.de>
6067
6068 * dbusbind.c (Fdbus_register_signal): When service is not
6069 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6070
32bbb17c
GM
60712011-09-25 Glenn Morris <rgm@gnu.org>
6072
6073 * buffer.c (truncate-lines): Doc fix.
6074
94e0933e
CY
60752011-09-24 Chong Yidong <cyd@stupidchicken.com>
6076
6077 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6078 (Fset_window_next_buffers): Doc fix.
6079
cddde921
GM
60802011-09-24 Glenn Morris <rgm@gnu.org>
6081
6082 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6083
1260aef1
PE
60842011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6085
25b4bfa0
PE
6086 Fix minor problems found by static checking.
6087 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6088 * indent.c (Fvertical_motion): Fix == vs = typo.
6089
e3cbd34b
EZ
60902011-09-24 Eli Zaretskii <eliz@gnu.org>
6091
a66cfb1c
SM
6092 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6093 Default value is now t. Doc fix.
6bf7006f 6094
e3cbd34b 6095 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6096 logic when moving up, not only when moving down. Fix the
e3cbd34b 6097 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6098 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6099
6100 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6101 CHARPOS is covered by a display string which includes newlines.
6102 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6103 is covered by a display string with embedded newlines.
6104
a3de0cbd
MA
61052011-09-24 Michael Albinus <michael.albinus@gmx.de>
6106
6107 * dbusbind.c (Fdbus_register_signal): Add match rule to
6108 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6109 (Fdbus_register_method, Vdbus_registered_objects_table):
6110 Fix docstring.
a3de0cbd 6111
b260039d
JM
61122011-09-24 Jim Meyering <meyering@redhat.com>
6113
32c1fffd 6114 do not ignore write error for any output size
b260039d
JM
6115 The previous change was incomplete.
6116 While it makes emacs --batch detect the vast majority of stdout
6117 write failures, errors were still ignored whenever the output size is
6118 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6119 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6120 && echo FAIL: ignored write error
6121 FAIL: ignored write error
6122 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6123 && echo FAIL: ignored write error
6124 FAIL: ignored write error
6125 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6126
8eca8a7c
AS
61272011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6128
6129 * emacs.c (Fkill_emacs): In noninteractive mode exit
6130 non-successfully if a write error occurred on stdout. (Bug#9574)
6131
3341db62
EZ
61322011-09-21 Eli Zaretskii <eliz@gnu.org>
6133
6134 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6135 the xassert test.
6136
6137 * dispextern.h (struct it): Update the comment documenting what
6138 can it->OBJECT be.
6139
8c203dbf
EZ
61402011-09-20 Eli Zaretskii <eliz@gnu.org>
6141
6142 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6143 a display string, extend search for cursor position to end of row.
6144 (find_row_edges): If the row ends in a newline from a display
6145 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6146 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6147 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6148 non-empty line. Fixes confusing cursor motion with arrow keys at
6149 the beginning of a line that starts with whitespace.
8c203dbf 6150
a4824228
LMI
61512011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6152
6153 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6154 (bug#9493).
6155
33ed493b
CY
61562011-09-18 Chong Yidong <cyd@stupidchicken.com>
6157
6158 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6159 boolean (Bug#9154).
6160
56cd55c8
EZ
61612011-09-18 Eli Zaretskii <eliz@gnu.org>
6162
6163 * xdisp.c (display_line): Record maximum and minimum buffer
6164 positions even if no glyphs were produced (e.g., by a zero-width
6165 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6166 buffer positions that will be removed from the glyph row because
6167 they don't fit.
c02dcedf
EZ
6168 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6169 column is beyond frame width: don't subtract 1 "pixel" when
6170 computing width of the stretch.
3e62b7e0
EZ
6171 (reseat_at_next_visible_line_start): Undo the change made on
6172 2011-09-17 that saved paragraph information and restored it after
6173 the call to `reseat'. (Bug#9545)
56cd55c8 6174
5ed99d36 61752011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6176
6177 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6178 and turn window cursor on if cleared (Bug#9415).
6179
5ed99d36 61802011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6181
6182 * search.c (boyer_moore): Take unibyte characters from pattern
6183 literally. (Bug#9458)
6184
9bade7b2
EZ
61852011-09-18 Eli Zaretskii <eliz@gnu.org>
6186
6187 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6188
e5e9d610
PE
61892011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6190
87e4427a
PE
6191 Fix minor problem found by static checking.
6192 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6193 initialized, to pacify gcc -Wuninitialized.
6194
e5e9d610
PE
6195 * fileio.c: Report proper errno when syscall falls.
6196 (Finsert_file_contents): Save and restore errno,
6197 so that report_file_error outputs the correct diagnostic.
6198 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6199
a1674f0b
EZ
62002011-09-18 Eli Zaretskii <eliz@gnu.org>
6201
6202 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6203
fbfb6dd4
EZ
62042011-09-17 Eli Zaretskii <eliz@gnu.org>
6205
6206 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6207 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6208
bb187662
EZ
62092011-09-17 Eli Zaretskii <eliz@gnu.org>
6210
1137e8b8 6211 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6212 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6213
6214 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6215 (bidi_find_paragraph_start): Search back for paragraph beginning
6216 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6217 (bidi_move_to_visually_next): Only trigger paragraph-related
6218 computations when the last character is a newline or at EOB, not
6219 just any NEUTRAL_B. (Bug#9470)
6220
bb187662
EZ
6221 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6222 truncated lines if point is covered by a display string. (Bug#9524)
6223
2e621251
PE
62242011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6225
6226 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6227 (cons_to_x_long): New function.
6228 (lisp_data_to_selection_data): Use it. Correct the test for
6229 short-versus-long data; it was negated. Break out of vector
6230 loop, for efficiency, when a long datum is discovered.
6231
91a15bc6
SM
62322011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6233
6234 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6235
b41c3a35
EZ
62362011-09-16 Eli Zaretskii <eliz@gnu.org>
6237
6238 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6239 GCC PR/17406) by declaring this function with external scope.
6240
7812ba2d
PE
62412011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6242
6243 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6244 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6245
cf7edc2a
AS
62462011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6247
6248 * editfns.c (Fformat): Correctly handle text properties on "%%".
6249
bd01620e
EZ
62502011-09-15 Eli Zaretskii <eliz@gnu.org>
6251
6252 * xterm.c (x_draw_composite_glyph_string_foreground):
6253 * w32term.c (x_draw_composite_glyph_string_foreground):
6254 * term.c (encode_terminal_code):
6255 * composite.c (composition_update_it, get_composition_id):
6256 * xdisp.c (get_next_display_element)
6257 (fill_composite_glyph_string): Add comments about special meaning
6258 of TAB characters in a composition.
6259
a02719a3
PE
62602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6261
6262 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6263 This occurs when processing a multibyte format.
6264 Problem reported by Wolfgang Jenker.
a02719a3 6265
72589a3c
JB
62662011-09-15 Johan Bockgård <bojohan@gnu.org>
6267
6268 * xdisp.c (try_cursor_movement): Only check for exact match if
6269 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6270
1c14176c
PE
62712011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6272
6273 Remove unused external symbols.
6274 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6275 * xdisp.c (calc_pixel_width_or_height): Now static.
6276 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6277 * indent.c (check_display_width):
6278 * w32term.c: Fix comment to match code.
6279 * xterm.c, xterm.h (x_catching_errors): Remove.
6280
d2eea5b5
PE
62812011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6282
6283 * xselect.c: Use signed conversions more consistently (Bug#9498).
6284 (selection_data_to_lisp_data): Assume incoming selection data are
6285 signed integers, not unsigned. This is to be consistent with
6286 outgoing selection data, which was modified to use signed integers
6287 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6288 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6289 expects long, not unsigned long.
6290
46888499
EZ
62912011-09-14 Eli Zaretskii <eliz@gnu.org>
6292
6293 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6294 computation of loop end. Reported by Johan Bockgård
6295 <bojohan@gnu.org>.
6296
ef8ef9fb
CY
62972011-09-13 Chong Yidong <cyd@stupidchicken.com>
6298
6299 * frame.c (Fother_visible_frames_p): Function deleted.
6300
fa819fed
EZ
63012011-09-12 Eli Zaretskii <eliz@gnu.org>
6302
6303 * indent.c (compute_motion): Process display vector front to back
6304 rather than the other way around. (Bug#2496)
6305
2ba8e008
SM
63062011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6307
6308 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6309
20f53c69
CY
63102011-09-11 Chong Yidong <cyd@stupidchicken.com>
6311
6312 * minibuf.c (Fread_from_minibuffer): Doc fix.
6313
d562d7a4
EZ
63142011-09-11 Eli Zaretskii <eliz@gnu.org>
6315
6316 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6317 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6318
1c4d7f3d
LMI
63192011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6320
6321 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6322 value for non-existent files.
6323
b885bf36
EZ
63242011-09-11 Eli Zaretskii <eliz@gnu.org>
6325
6326 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6327 set its "size" to -1. This will set the modtime_size field of
6328 the corresponding buffer to -1, which is what
6329 verify-visited-file-modtime expects for files that do not exist.
6330 (Bug#9139)
6331
6612f0bf
PE
63322011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6333
6334 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6335 here ...
6336 * lisp.h: ... from here. push_key_description is no longer
6337 defined in keyboard.c, so its declaration should not be in
6338 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6339 logically belongs with push_key_description.
6340
dfb3f755
PE
63412011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6342
6343 * buffer.h: Include <sys/types.h> instead of <time.h>.
6344 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6345 Problem reported by Herbert J. Skuhra.
6346
3134906c
LMI
63472011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6348
6349 * xml.c (parse_region): Make the parsing work for
6350 non-comment-starting XML files again (bug#9144).
6351
8d903f4e
AS
63522011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6353
6354 * image.c (gif_load): Fix calculation of bottom and right corner.
6355 (Bug#9468)
6356
80ad64f4
EZ
63572011-09-10 Eli Zaretskii <eliz@gnu.org>
6358
6359 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6360 redisplay in small windows.
6361
208a048d
EZ
63622011-09-09 Eli Zaretskii <eliz@gnu.org>
6363
6364 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6365
9b1c252e
MR
63662011-09-08 Martin Rudalics <rudalics@gmx.at>
6367
6368 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6369 Operate on live windows only.
6370
2949f33b
JB
63712011-09-08 Juanma Barranquero <lekktu@gmail.com>
6372
6373 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6374
e08dcafd
EZ
63752011-09-07 Eli Zaretskii <eliz@gnu.org>
6376
6377 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6378 only under bidi iteration.
6379
115b96bd
JD
63802011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6381
6382 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6383
c8199d0f
PE
63842011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6385
6386 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6387 Without this fix, the command to link temacs failed due to an
6388 undefined symbol __builtin_isnan. This is because
6389 /usr/include/iso/math_c99.h #defines isnan(x) to
6390 __builtin_isnan(x), but the bundled gcc, which identifies itself
6391 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6392 a __builtin_isnan.
6393 * floatfns.c (isnan): #undef, and then #define to a clone of
6394 what's in data.c.
6395 (Fisnan): Always define, since it's always available now.
6396 (syms_of_floatfns): Always define isnan at the Lisp level.
6397
e39b275c 63982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6399
6400 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6401
b2db44d9 64022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6403
f4af5137 6404 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6405 The previous code assumed that file offsets (off_t values) fit in
6406 EMACS_INT variables, which is not true on typical 32-bit hosts.
6407 The code messed up by falsely reporting buffer overflow in cases
6408 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6409 when "big" contains more than 2**29 bytes, even though this
6410 inserts just one byte and does not overflow the buffer.
6411 (Finsert_file_contents): Store file offsets as off_t
6412 values, not as EMACS_INT values. Check for overflow when
6413 converting between EMACS_INT and off_t. When checking for
6414 buffer overflow or for overlap, take the offsets into account.
6415 Don't use EMACS_INT for small values where int suffices.
6416 When checking for overlap, fix a typo: ZV was used where
6417 ZV_BYTE was intended.
6418 (Fwrite_region): Don't assume off_t fits into 'long'.
6419 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6420
ecfc0a49
MA
64212011-09-05 Michael Albinus <michael.albinus@gmx.de>
6422
6423 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6424
6511acf2 64252011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6426
0999621a 6427 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6428
6429 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6430 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6431 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6432 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6433 (modify_event_symbol): Do not assume that the length of
6434 name_alist_or_stem is safe to alloca and fits in int.
6435 (Fexecute_extended_command): Likewise for function name and binding.
6436 (Frecursion_depth): Wrap around reliably on integer overflow.
6437 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6438 since some callers pass EMACS_INT values.
6439 (Fsingle_key_description): Don't crash if symbol name contains more
6440 than MAX_ALLOCA bytes.
6441 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6442 (get_minibuffer): Arg is now EMACS_INT, not int.
6443 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6444 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6445 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6446
2be7d702
PE
6447 * dbusbind.c (signature_cat): New function.
6448 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6449 Do not overrun buffer; instead, report string overflow.
6450
9d1df220
PE
6451 * dispnew.c (add_window_display_history): Don't overrun buffer.
6452 Truncate instead; this is OK since it's just a log.
6453
33ef5c64
PE
6454 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6455 even if the time zone offset is outlandishly large.
6456 Don't mishandle offset == INT_MIN.
6457
66c6fdd5
PE
6458 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6459 when creating daemon; the previous buffer-overflow check was incorrect.
6460
d749b01b
PE
6461 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6462 which has the guts of the old verror function.
6463
b5cd1905
PE
6464 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6465 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6466
6e1a67fb
PE
6467 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6468 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6469 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6470 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6471 length of string rather than counting it via multiple sprintfs;
6472 that's simpler and more reliable.
c21721cc
PE
6473 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6474 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6475 sprintf, in case result does not fit in int.
6476
c57b67fc
PE
6477 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6478 (fontset_from_font): Print it.
6479
8a401434
PE
6480 * frame.c (tty_frame_count): Now printmax_t, not int.
6481 (make_terminal_frame, set_term_frame_name): Print it.
6482 (x_report_frame_params): In X, window IDs are unsigned long,
6483 not signed long, so print them as unsigned.
6484 (validate_x_resource_name): Check for implausibly long names,
6485 and don't assume name length fits in 'int'.
6486 (x_get_resource_string): Don't blindly alloca invocation name;
6487 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6488 not fit in int.
6489
6e1a67fb
PE
6490 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6491 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6492 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6493
0df02bf3
PE
6494 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6495 Use esprintf, not sprintf, in case result does not fit in int.
6496
48e30793
PE
6497 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6498 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6499 it as a large positive number.
6500 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6501 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6502
a66ff6d8
PE
6503 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6504 in case result does not fit in int.
6505
aca216ff
PE
6506 * print.c (float_to_string): Detect width overflow more reliably.
6507 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6508 buffer overrun. Don't assume list length fits in 'int'. Treat
6509 print length of 0 as 0, not as infinity; to be consistent with other
6510 uses of print length in this function. Don't overflow print length
6511 index. Don't assume hash table size fits in 'long', or that
6512 vectorlike size fits in 'unsigned long'.
6513
31c286f7
PE
6514 * process.c (make_process): Use printmax_t, not int, to format
6515 process-name gensyms.
6516
55e5faa1
PE
6517 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6518
80f2e268
PE
6519 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6520 to avoid potential buffer overrun.
6521
670741ab
PE
6522 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6523 if X resource line is longer than 512 bytes.
6524
b7163a50
PE
6525 * xfns.c (x_window): Make sprintf buffer a bit bigger
6526 to avoid potential buffer overrun.
6527
ae58ff1f
PE
6528 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6529
c43c8a6a
PE
6530 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6531
3f8236f4
PE
65322011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6533
53e9fe90 6534 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6535 Without these, Emacs silently mishandles large integers sometimes.
6536 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6537 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6538
6511acf2
PE
6539 * xdisp.c (try_window_id): Check Emacs fixnum range before
6540 converting to 'int'.
806add1d 6541
6511acf2 6542 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6543 Check that an Emacs fixnum is in range before assigning it to 'int'.
6544 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6545 values converted from Emacs fixnums.
6546 (Frecenter): Don't wrap around a line count if it is out of 'int'
6547 range; instead, treat it as an extreme value.
6548 (Fset_window_configuration, compare_window_configurations):
6549 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6550
6511acf2
PE
6551 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6552 that can exceed INT_MAX. Check that EMACS_INT value is in range
6553 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6554 (match_limit): Don't assume that a fixnum can fit in 'int'.
6555
6511acf2 6556 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6557 exceed INT_MAX.
6558
6511acf2 6559 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6560 (Fvertical_motion): Don't wrap around LINES values that don't fit
6561 in 'int'. Instead, treat them as extreme values. This is good
6562 enough for windows, which can't have more than INT_MAX lines anyway.
6563
fcb901a7
LMI
65642011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6565
0f2f6b6d
LMI
6566 * Require libxml/parser.h to avoid compilation warning.
6567
fcb901a7
LMI
6568 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6569
6570 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6571 since this reportedly can destroy thread storage.
6572
6e20a0d4
CY
65732011-08-30 Chong Yidong <cyd@stupidchicken.com>
6574
6575 * syntax.c (find_defun_start): Update all cache variables if
6576 exiting early (Bug#9401).
6577
148ae00e
EZ
65782011-08-30 Eli Zaretskii <eliz@gnu.org>
6579
f6cfbd8f
EZ
6580 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6581
148ae00e
EZ
6582 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6583 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6584 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6585
6586 * term.c (tty_append_glyph): New function.
6587 (produce_stretch_glyph): Static function and its prototype deleted.
6588
a66cfb1c
SM
6589 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6590 Add prototypes.
148ae00e 6591
c4a07a4c
PE
65922011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6593
6594 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6595 when checking :margin (Bug#9390).
6596 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6597 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6598 so that the name doesn't mislead. All uses changed.
6599
6bc8cd65
JB
66002011-08-28 Johan Bockgård <bojohan@gnu.org>
6601
6602 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6603 set_tty_hooks.
6604
dca4927e
EZ
66052011-08-27 Eli Zaretskii <eliz@gnu.org>
6606
6607 * xdisp.c (move_it_to): Don't bail out early when reaching
6608 position beyond to_charpos, if we are scanning backwards.
6609 (move_it_vertically_backward): When DY == 0, make sure we get to
6610 the first character in the line after the newline.
6611
f2cad773
PE
66122011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6613
6614 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6615 (ccl_driver): Do not generate an out-of-range pointer.
6616 (Fccl_execute_on_string): Remove unnecessary check for
6617 integer overflow, noted by Stefan Monnier in
6618 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6619 Remove a FIXME that didn't need fixing.
6620 Simplify the newly-introduced buffer reallocation code.
6621
0cae2cdb
JB
66222011-08-27 Juanma Barranquero <lekktu@gmail.com>
6623
6624 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6625
5fc295a4 66262011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6627
70c60eb2 6628 Integer and memory overflow issues (Bug#9196).
726e0ab1 6629
d31850da
PE
6630 * doc.c (get_doc_string): Rework so that
6631 get_doc_string_buffer_size is the actual buffer size, rather than
6632 being 1 less than the actual buffer size; this makes xpalloc more
6633 convenient.
6634
a69fbedb
PE
6635 * image.c (x_allocate_bitmap_record, cache_image):
6636 * xselect.c (Fx_register_dnd_atom):
6637 Simplify previous changes by using xpalloc.
6638
fe5c5d37
PE
6639 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6640 since either will do and ptrdiff_t is convenient with xpalloc.
6641
0065d054
PE
6642 * charset.c (charset_table_size)
6643 (struct charset_sort_data.priority): Now ptrdiff_t.
6644 (charset_compare): Don't overflow if priorities differ greatly.
6645 (Fsort_charsets): Don't assume list length fits in int.
6646 Check for size-calculation overflow when allocating sort data.
6647 (syms_of_charset): Allocate an initial charset table that is
6648 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6649
6650 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6651
6652 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6653 The actual value is always <= INT_MAX, and leaving it unsigned made
6654 overflow checking harder.
6655
6656 * dispextern.h (struct glyph_matrix.rows_allocated)
6657 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6658 with xpalloc. The values are still always <= INT_MAX.
6659
6660 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6661
6662 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6663 (SAFE_NALLOCA): New macro.
6664
6665 * region-cache.c (struct boundary.pos, find_cache_boundary)
6666 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6667 (set_cache_region, invalidate_region_cache)
6668 (revalidate_region_cache, know_region_cache, region_cache_forward)
6669 (region_cache_backward, pp_cache):
6670 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6671 so that ptrdiff_t * can be passed to xpalloc.
6672 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6673 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6674 (pp_cache): Don't assume cache_len fits in int.
6675 * region-cache.h: Adjust extern decls to match.
6676
6677 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6678 EMACS_INT, since either will do, for xpalloc.
6679
6680 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6681 (xnmalloc, xnrealloc, xpalloc): New functions.
6682
726e0ab1
PE
6683 * bidi.c (bidi_shelve_header_size): New constant.
6684 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6685 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6686
51f30bc5 6687 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6688 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6689 (overlay_strings):
6690 Don't update size of array until after memory allocation succeeds,
6691 because xmalloc/xrealloc may not return.
0065d054
PE
6692 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6693 now that we have proper integer overflow checking.
6694 (record_overlay_string, overlay_strings): Catch overflows when
6695 calculating size of overlay_str_buf.
726e0ab1 6696
0065d054
PE
6697 * callproc.c (Fcall_process): Check for size overflow when
6698 calculating size of args2.
6699 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6700 Normally we prefer signed values, but sticking with ptrdiff_t would
6701 require adding more-complicated checks.
726e0ab1
PE
6702
6703 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6704 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6705 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6706 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6707
6708 * character.c (Fstring): Check for size-calculation overflow.
6709
6710 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6711 unnecessary integer overflow. Check for size overflow.
6712 (encode_coding_object): Don't update size until xmalloc succeeds.
6713
6714 * composite.c (get_composition_id): Check for overflow in glyph
6715 length calculations.
6716
6717 Integer and memory overflow fixes for display code.
6718 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6719 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6720 (scrolling_window): Check for overflow in size calculations.
6721 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6722 Don't assume glyph table len fits in int.
6723 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6724 (row_table_size): Now ptrdiff_t, not int.
6725 (scrolling_window): Avoid overflow in size calculations.
6726 Don't update size until allocation succeeds.
6727 * fns.c (concat): Check for overflow in size calculations.
6728 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6729 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6730 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6731
6732 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6733 (get_doc_string): Check for size calculation overflow.
6734 Don't update size until allocation succeeds.
6735 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6736 EMACS_INT, where ptrdiff_t will do.
6737 (Fsubstitute_command_keys): Check for string overflow.
6738
6739 * editfns.c (set_time_zone_rule): Don't assume environment length
6740 fits in int.
6741 (message_length): Now ptrdiff_t, not int.
6742 (Fmessage_box): Don't update size until allocation succeeds.
6743 Don't assume message length fits in int.
6744 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6745
0065d054
PE
6746 * emacs.c (main): Do not reallocate argv, since there is a null at
6747 the end that can be overwritten, and this way there's no need to
6748 worry about size-calculation overflow.
6749 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6750
6751 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6752 alloc succeeds.
6753 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6754
6755 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6756 (x_set_scroll_bar_width, x_figure_window_size):
6757 Check for integer overflow.
6758 (x_set_alpha): Do not assume XINT fits in int.
6759
6760 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6761 This is for the members text_lines, text_cols, total_lines, total_cols,
6762 where the system imposes an 'int' limit.
6763
6764 * fringe.c (Fdefine_fringe_bitmap):
6765 Don't update size until alloc works.
6766
6767 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6768 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6769
6770 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6771 Check for size-calculation overflow.
6772 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6773 do, as we prefer signed integers.
6774 (id_to_widget.max_size, id_to_widget.used)
6775 (xg_store_widget_in_map, xg_remove_widget_from_map)
6776 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6777 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6778 Use and return ptrdiff_t, not int.
6779 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6780 * gtkutil.h: Change prototypes to match the above.
6781
6782 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6783 are duplicate now that they've been promoted to lisp.h.
6784 (x_allocate_bitmap_record, x_alloc_image_color)
6785 (make_image_cache, cache_image, xpm_load):
6786 Don't update size until alloc is done.
6787 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6788 (x_detect_edges):
3256efce 6789 Check for size calculation overflow.
726e0ab1
PE
6790 (ct_colors_allocated_max): New constant.
6791 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6792 overflow.
3256efce 6793
726e0ab1
PE
6794 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6795 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6796 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6797 Use ptrdiff_t, not int, to count maps.
6798 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6799 calculations. Don't update size until allocation succeeds.
6800 Redo calculations to avoid overflow.
726e0ab1
PE
6801 * keyboard.h: Change prototypes to match the above.
6802
6803 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6804 to count maps.
6805 (current_minor_maps): Check for size calculation overflow.
6806 * keymap.h: Change prototypes to match the above.
6807
6808 * lread.c (read1, init_obarray): Don't update size until alloc done.
6809
6810 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6811 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6812
726e0ab1
PE
6813 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6814 Now ptrdiff_t, not int.
6815 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6816 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6817
6818 * process.c (Fnetwork_interface_list): Check for overflow
6819 in size calculation.
6820
6821 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6822
6823 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6824 overflow. Don't bother calling xmalloc when xrealloc will do.
6825
6826 * search.c (Freplace_match): Check for size calculation overflow.
6827 (Fset_match_data): Don't assume list lengths fit in 'int'.
6828
6829 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6830 for command line length. Do not attempt to address one before the
6831 beginning of an array, as that's not portable.
6832
6833 * term.c (max_frame_lines): Remove; unused.
6834 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6835 not int.
6836 (encode_terminal_code, calculate_costs): Check for size
6837 calculation overflow.
6838 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6839 table lengths and related sizes. Don't update size until alloc
6840 done. Redo calculations to avoid overflow.
6841 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6842
6843 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6844 subtracting pointers.
6845 (gobble_line): Check for overflow more carefully. Don't update size
6846 until alloc done.
6847
6848 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6849 Don't update size until alloc done.
6850 Redo size calculations to avoid overflow.
6851 Check for size calculation overflow.
0065d054 6852 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6853
6854 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6855 Use ptrdiff_t, not int, for sizes.
6856 (store_mode_line_noprop_char): Don't update size until alloc done.
6857
0065d054
PE
6858 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6859 Use ptrdiff_t, not int, for sizes.
6860 (Finternal_make_lisp_face, cache_face):
6861 Check for size calculation overflow.
6862 (cache_face): Treat size calculation overflows as if they were
6863 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6864
6865 * xfns.c (x_encode_text, x_set_name_internal)
6866 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6867 sizes, since they can exceed INT_MAX in size. Check for size
6868 calculation overflow.
6869
0065d054
PE
6870 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6871 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6872 Don't update size until alloc done.
6873
0065d054 6874 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6875 as sprintf is limited to int lengths.
1d526e2f 6876
252c5ee1
PE
6877 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6878 (X_LONG_MIN): New macros.
864d7ce7
PE
6879 Use them to make the following changes clearer.
6880 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6881 This change doesn't affect the value now, but it may help remind
6882 future maintainers not to raise the value too much later.
6883 (SELECTION_QUANTUM): Remove, replacing with ...
6884 (selection_quantum): ... new function, which avoids overflow.
6885 All uses changed.
6886 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6887 assumption that selection length fits in 'int'.
6888 (x_reply_selection_request, x_handle_selection_request)
6889 (x_get_window_property, receive_incremental_selection)
6890 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6891 (lisp_data_to_selection_data, clean_local_selection_data):
6892 Use ptrdiff_t, not int, to record length of selection.
6893 (x_reply_selection_request, x_get_window_property)
6894 (receive_incremental_selection, x_property_data_to_lisp):
6895 Redo calculations to avoid overflow.
6896 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6897 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6898 something.
6899 (x_get_window_property, receive_incremental_selection)
6900 (lisp_data_to_selection_data, x_property_data_to_lisp):
6901 Check for size-calculation overflow.
6902 (x_get_window_property, receive_incremental_selection)
6903 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6904 Don't store size until memory allocation succeeds.
6905 (x_get_window_property): Plug memory leak on memory exhaustion.
6906 Don't double-block input; malloc is safe here. Don't assume 2**34
6907 - 4 fits in unsigned long. Add an xassert to check
6908 XGetWindowProperty overflow. Be more careful about overflow
6909 calculations, and distinguish size from memory overflow better.
6910 (receive_incremental_selection): When tracing, don't assume
6911 unsigned int is less than INT_MAX.
6912 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6913 harmful) conversions of unsigned short to int.
6914 (lisp_data_to_selection_data): Don't assume that integers
6915 in the range -65535 through -1 fit in an X unsigned short.
6916 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6917 result parameters unless successful. Rely on cons_to_unsigned
6918 to report problems with elements; the old code wasn't right anyway.
6919 (x_check_property_data): Check for int overflow; we cannot use
6920 a wider type due to X limits.
6921 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6922
726e0ab1 6923 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6924
0065d054
PE
6925 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6926 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6927 (x_color_cells): Don't store size until memory allocation succeeds.
6928 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6929 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6930 (x_term_init): Don't assume length fits in int (sprintf is limited
6931 to int size).
bc18e09d 6932
ebfa62c0
PE
6933 Use ptrdiff_t for composition IDs.
6934 * character.c (lisp_string_width):
6935 * composite.c (composition_table_size, n_compositions)
6936 (get_composition_id, composition_gstring_from_id):
6937 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6938 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6939 * window.c (Frecenter):
6940 Use ptrdiff_t, not int, for composition IDs.
6941 * composite.c (get_composition_id): Check for integer overflow.
6942 * composite.h: Adjust prototypes to match the above changes.
6943
d3411f89
PE
6944 Use ptrdiff_t for hash table indexes.
6945 * category.c (hash_get_category_set):
6946 * ccl.c (ccl_driver):
6947 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6948 * coding.c (coding_system_charset_list, detect_coding_system):
6949 * coding.h (struct coding_system.id):
6950 * composite.c (get_composition_id, gstring_lookup_cache):
6951 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6952 * image.c (xpm_get_color_table_h):
6953 * lisp.h (hash_lookup, hash_put):
6954 * minibuf.c (Ftest_completion):
6955 Use ptrdiff_t for hash table indexes, not int (which is too
6956 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6957 32-bit --with-wide-int hosts).
6958
e097a6fa
PE
6959 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6960 Add a FIXME comment about memory leaks.
6961 (syms_of_charset): Don't assume xmalloc returns.
6962
5637687f
PE
6963 Don't assume that stated character widths fit in int.
6964 * character.c (Fchar_width, c_string_width, lisp_string_width):
6965 * character.h (CHAR_WIDTH):
6966 * indent.c (MULTIBYTE_BYTES_WIDTH):
6967 Use sanitize_char_width to avoid undefined and/or bad behavior
6968 with outlandish widths.
a66cfb1c 6969 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6970 now that we have two such functions. All uses changed.
6971 (sanitize_char_width): New inline function.
6972
a2271ba2
PE
6973 Don't assume that tab-width fits in int.
6974 * character.h (sanitize_width): New inline function.
6975 (SANE_TAB_WIDTH): New macro.
6976 (ASCII_CHAR_WIDTH): Use it.
6977 * indent.c (sane_tab_width): Remove. All uses replaced by
6978 SANE_TAB_WIDTH (current_buffer).
6979 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6980
18c52557
PE
6981 * fileio.c: Integer overflow issues with file modes.
6982 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6983
caeeedc1
PE
6984 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6985 Remove unreachable code.
6986 (read_hex, load_charset_map_from_file): Check for integer overflow.
6987
6df6ae42 6988 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6989 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6990 (x_send_scroll_bar_event): Likewise. Check that the size does not
6991 exceed limits imposed by XClientMessageEvent, as well as the usual
6992 ptrdiff_t and size_t limits.
6993
b13995db
PE
6994 * keyboard.c: Overflow, signedness and related fixes.
6995 (make_lispy_movement): Use same integer type in forward decl
6996 that is used in the definition.
6997 (read_key_sequence, keyremap_step):
6998 Change bufsize argument back to int, undoing my 2011-03-30 change.
6999 We prefer signed types, and int is wide enough here.
7000 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7001 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7002 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7003 length, not size_t. Use ptrdiff_t for index, not int.
7004 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7005 possibility of integer overflow.
7006
13464394
PE
7007 Overflow, signedness and related fixes for images.
7008
7009 * dispextern.h (struct it.stack[0].u.image.image_id)
7010 (struct_it.image_id, struct image.id, struct image_cache.size)
7011 (struct image_cache.used, struct image_cache.ref_count):
7012 * gtkutil.c (update_frame_tool_bar):
7013 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7014 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7015 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7016 * nsmenu.m (update_frame_tool_bar):
7017 * xdisp.c (calc_pixel_width_or_height):
7018 * xfns.c (image_cache_refcount):
7019 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7020 on typical 64-bit hosts.
7021
7022 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7023 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7024 Omit unnecessary casts to int.
7025 (parse_image_spec): Check that integers fall into 'int' range
7026 when the callers expect that.
7027 (image_ascent): Redo ascent calculation to avoid int overflow.
7028 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7029 (lookup_image): Remove unnecessary tests.
7030 (xbm_image_p): Locals are now of int, not EMACS_INT,
7031 since parse_image_check makes sure they fit into int.
7032 (png_load, gif_load, svg_load_image):
7033 Prefer int to unsigned where either will do.
7034 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7035 old tiff_error_handler and tiff_warning_handler.
7036 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7037 stack buffer overflows. It uses only the features of vsnprintf
7038 that are common to both POSIX and native Microsoft.
7039 (tiff_error_handler, tiff_warning_handler): Use it.
7040 (tiff_load, gif_load, imagemagick_load_image):
7041 Don't assume :index value fits in 'int'.
7042 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7043 (imagemagick_load_image): Check that crop parameters fit into
7044 the integer types that MagickCropImage accepts. Don't assume
7045 Vimagemagick_render_type has a nonnegative value. Don't assume
7046 size_t fits in 'long'.
7047 (gs_load): Use printmax_t to print the widest integers possible.
7048 Check for integer overflow when computing image height and width.
7049
c11821d4
EZ
70502011-08-26 Eli Zaretskii <eliz@gnu.org>
7051
7052 * xdisp.c (redisplay_window): Don't force window start if point
7053 will be invisible in the resulting window. (Bug#9324)
7054
0c95fcf7
EZ
70552011-08-25 Eli Zaretskii <eliz@gnu.org>
7056
7057 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7058 the display spec is of the form `(space ...)'.
7059 (handle_display_spec): Return the value returned by
7060 handle_single_display_spec, not just 1 or zero.
7061 (handle_single_display_spec): If the display spec is of the form
7062 `(space ...)', and specifies display in the text area, return 2
7063 rather than 1.
fee65a97 7064 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7065 accurately, and prefer exact match for point under bidi.
7066 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7067
7068 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7069 into disp_prop; all users changed.
7070
7071 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7072 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7073 for the text covered by the display property.
7074
e4ed06f1
CY
70752011-08-25 Chong Yidong <cyd@stupidchicken.com>
7076
7077 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7078 Change return value to nil.
7079 (Frecord_buffer): Delete unused function.
7080
f67cdd7f
EZ
70812011-08-24 Eli Zaretskii <eliz@gnu.org>
7082
5980d4c6
EZ
7083 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7084 buffers, return left-to-right.
8610fe8b
EZ
7085 (set_cursor_from_row): Consider candidate row a win if its glyph
7086 represents a newline and point is on that newline. Fixes cursor
7087 positioning on the newline at EOL of R2L text within L2R
7088 paragraph, and vice versa.
7089 (try_cursor_movement): Check continued rows, in addition to
7090 continuation rows. Fixes unwarranted scroll when point enters a
7091 continued line of R2L text within an L2R paragraph, or vice versa.
7092 (cursor_row_p): Consider the case of point being equal to
7093 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7094 from the end of a short line to the beginning of a continued line
7095 of R2L text within L2R paragraph.
7096 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7097 composed characters.
5980d4c6 7098
f67cdd7f
EZ
7099 * bidi.c (bidi_check_type): Use xassert.
7100 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7101 members.
7102
bca633fb
EZ
71032011-08-23 Eli Zaretskii <eliz@gnu.org>
7104
7105 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7106 a character.
7107
4a5885a7
CY
71082011-08-23 Chong Yidong <cyd@stupidchicken.com>
7109
7110 * nsfont.m (ns_otf_to_script): Fix typo.
7111
0902a04e
KH
71122011-08-22 Kenichi Handa <handa@m17n.org>
7113
7114 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7115 extra slot even if the purpose is char-code-property-table.
7116
1a2e6670
EZ
71172011-08-23 Eli Zaretskii <eliz@gnu.org>
7118
8ddde651
EZ
7119 * xdisp.c (redisplay_window): When computing centering_position,
7120 account for the height of the header line. (Bug#8874)
7121
425cc014
EZ
7122 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7123 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7124 candidate is selected by the mouse, and that candidate has a
7125 composed character under the mouse.
7126
1a2e6670
EZ
7127 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7128 coordinates reported by pos-visible-in-window-p for a composed
7129 character in column zero.
7130
8b76d6f8
SM
71312011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7132
7133 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7134
dac347dd
EZ
71352011-08-22 Eli Zaretskii <eliz@gnu.org>
7136
7137 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7138 consider it a hit if to_charpos is anywhere in the range of the
7139 composed buffer positions.
7140
e013fb34
CY
71412011-08-22 Chong Yidong <cyd@stupidchicken.com>
7142
7143 * image.c (gif_load): Don't assume that each subimage has the same
7144 dimensions as the base image. Handle disposal method that is
7145 "undefined" by the gif spec (Bug#9335).
7146
bd1ba3e8
CY
71472011-08-20 Chong Yidong <cyd@stupidchicken.com>
7148
7149 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7150 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7151
54a1215b
EZ
71522011-08-19 Eli Zaretskii <eliz@gnu.org>
7153
823564e5
EZ
7154 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7155 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7156 from an Org mode buffer to a Speedbar frame.
7157
54a1215b
EZ
7158 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7159 a composition, take its buffer position from IT->cmp_it.charpos.
7160 Fixes cursor positioning at the beginning of a line that begins
7161 with a composed character.
7162
9778ebcc
EZ
71632011-08-18 Eli Zaretskii <eliz@gnu.org>
7164
0be6ee06
EZ
7165 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7166 character bidirectional type, use STRONG_L instead. Fixes crashes
7167 in a buffer produced by `describe-categories'.
7168
9778ebcc
EZ
7169 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7170 members before the level stack, so they would be saved and
7171 restored when copying iterator state. Fixes incorrect reordering
7172 around TABs covered by display properties.
7173
156bffbe
AS
71742011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7175
6b02f655 7176 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7177
72ad093b
CY
71782011-08-17 Chong Yidong <cyd@stupidchicken.com>
7179
7180 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7181 (internal_condition_case_2, internal_condition_case_n):
7182 Remove unnecessary aborts (Bug#9081).
72ad093b 7183
35774242
EZ
71842011-08-17 Eli Zaretskii <eliz@gnu.org>
7185
7186 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7187 has no `load' handler, try opening the file locally. (Bug#9311)
7188
db76dd85
KB
71892011-08-16 Ken Brown <kbrown@cornell.edu>
7190
7191 * gmalloc.c: Expand comment.
7192
b215eee5
EZ
71932011-08-16 Eli Zaretskii <eliz@gnu.org>
7194
7195 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7196 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7197
a4579d33
KB
71982011-08-16 Ken Brown <kbrown@cornell.edu>
7199
7200 Fix memory allocation problems in Cygwin build (Bug#9273).
7201
7202 * unexcw.c ( __malloc_initialized): Declare external variable.
7203 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7204
8b76d6f8
SM
7205 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7206 New variables.
a4579d33
KB
7207 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7208 dumped emacs.
7209 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7210 in the static heap.
7211 [CYGWIN] (special_realloc): New function.
7212 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7213 requests to realloc storage in the static heap.
7214
3ebec551
PE
72152011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7216
7217 * bidi.c (bidi_initialize): Remove unused local.
7218
9fd8be00
EZ
72192011-08-15 Eli Zaretskii <eliz@gnu.org>
7220
6b02f655
SM
7221 * bidimirror.h:
7222 * biditype.h: Remove file.
7223 * makefile.w32-in ($(BLD)/bidi.$(O)):
7224 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7225
7226 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7227
7228 * chartab.c: Improve commentary for the uniprop_table API.
7229
32413314
EZ
7230 * bidi.c (bidi_paragraph_init): Support zero value of
7231 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7232 (bidi_initialize): Use uniprop_table instead of including
7233 biditype.h and bidimirror.h.
32413314 7234
9fd8be00
EZ
7235 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7236 coordinates of the iterator when restoring from ppos_it.
7237 (Bug#9296)
7238
5cf2b69b
KH
72392011-08-14 Kenichi Handa <handa@m17n.org>
7240
7241 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7242 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7243
daf17d00
EZ
72442011-08-14 Eli Zaretskii <eliz@gnu.org>
7245
7246 * xdisp.c (move_it_in_display_line_to): Don't invoke
7247 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7248 ppos_it. Fixes vertical cursor motion when line beginning is
7249 covered by an image. (Bug#9296)
7250
08e3161a
JD
72512011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7252
7253 * nsterm.h (ns_run_ascript): Declare.
7254 (NSAPP_DATA2_RUNASSCRIPT): Define.
7255
7256 * nsfns.m (as_script, as_result, as_status): New static variables.
7257 (ns_run_ascript): New function.
5e617bc2 7258 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7259 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7260 the event loop. Get status from as_status (Bug#7276).
7261
7262 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7263 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7264 the event loop (Bug#7276).
7265
a3720aa2
AS
72662011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7267
7268 * gnutls.c (QCgnutls_bootprop_priority)
7269 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7270 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7271 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7272 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7273 (QCgnutls_bootprop_verify_hostname_error)
7274 (QCgnutls_bootprop_callbacks_verify): Rename from
7275 Qgnutls_bootprop_..., all uses changed.
7276
7277 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7278 uses changed.
7279
0a0d27fb
PE
72802011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7281
19d5c50c
PE
7282 * xfaces.c (Qframe_set_background_mode): Now static.
7283 * dispextern.h (Qframe_set_background_mode): Remove decl.
7284
0a0d27fb
PE
7285 * process.c (Fnetwork_interface_info): Declare local only if needed.
7286
377538cb
JD
72872011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7288
7289 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7290 (Fnetwork_interface_list): Allocate in increments of bytes instead
7291 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7292 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7293 sockaddr.
7294 (struct ifflag_def): notrailers is smart on OSX.
7295 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7296 Get hardware address with getifaddrs if available.
7297
08fff70c
EZ
72982011-08-12 Eli Zaretskii <eliz@gnu.org>
7299
7300 * xdisp.c (iterate_out_of_display_property): xassert that
7301 IT->position is set to within IT->object's boundaries. Break from
7302 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7303 when IT->position is set up wrongly due to some bug.
7304 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7305 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7306 entry. Force push_it to save on the stack the current
7307 buffer/string position, to be restored by pop_it. Fix flags in
7308 the iterator structure wrt the object coming from a display
7309 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7310 properties. (Bug#9284)
7311
7be1c708 73122011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7313
7be1c708
CY
7314 * fontset.c (fontset_get_font_group): Add proper type checks.
7315 (Bug#9172)
aac0c6e3 7316
7be1c708 73172011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7318
7be1c708
CY
7319 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7320 and LC_VERSION_MIN_MACOSX.
7321 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7322 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7323
97bb72a6
EZ
73242011-08-08 Eli Zaretskii <eliz@gnu.org>
7325
7326 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7327 no-display-properties-and-no-overlays under bidi display.
7328 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7329 properties and overlays.
97bb72a6 7330
d5617611
CY
73312011-08-08 Chong Yidong <cyd@stupidchicken.com>
7332
37e11a63
CY
7333 * editfns.c (Fset_time_zone_rule): Document relationship with the
7334 setenv function.
7335
d5617611
CY
7336 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7337 the font entity extracted from the cache (Bug#8109).
7338
58872834
CY
73392011-08-07 Chong Yidong <cyd@stupidchicken.com>
7340
7341 * composite.c (autocmp_chars): Don't reset point. That is done by
7342 restore_point_unwind (Bug#5984).
7343
75bfc667
JL
73442011-08-07 Juri Linkov <juri@jurta.org>
7345
7346 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7347 to show the arg `TIME' instead of `TIMEVAL'.
7348
d1410150
EZ
73492011-08-06 Eli Zaretskii <eliz@gnu.org>
7350
7351 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7352 display property strides EOL and includes a newline, as in
7353 longlines-mode. (Bug#9254)
75b771e4
EZ
7354 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7355 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7356
7357 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7358 is non-zero, even if the data buffer is NULL. Fixes a crash in
7359 vertical-motion with longlines-mode. (Bug#9254)
7360
35928349
EZ
73612011-08-05 Eli Zaretskii <eliz@gnu.org>
7362
ec7cc85b
EZ
7363 * bidi.c <bidi_cache_total_alloc>: Now static.
7364 (bidi_initialize): Initialize bidi_cache_total_alloc.
7365
8b76d6f8 7366 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7367 cache. (Bug#9221)
7368
7369 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7370 amount allocated this far in `bidi_cache_total_alloc'.
7371 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7372 non-zero, only free the data buffer without restoring the cache
7373 contents. All callers changed.
7374
7375 * dispextern.h (bidi_unshelve_cache): Update prototype.
7376
7377 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7378 (move_it_in_display_line, move_it_to)
7379 (move_it_vertically_backward, move_it_by_lines): Replace the call
7380 to xfree to an equivalent call to bidi_unshelve_cache.
7381 (move_it_in_display_line_to): Fix logic of returning
412b6358 7382 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7383
e2e2423b
EZ
73842011-08-05 Eli Zaretskii <eliz@gnu.org>
7385
7386 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7387 came from a string character with a `cursor' property. (Bug#9229)
7388
ae9e757a
JD
73892011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7390
7391 * Makefile.in (LIB_PTHREAD): New variable.
7392 (LIBES): Add LIB_PTHREAD (Bug#9216).
7393
7394 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7395 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7396
213bd7f2
AS
73972011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7398
6b02f655 7399 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7400
99aaf75f
JD
74012011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7402
7403 * xterm.c (x_find_topmost_parent): New function.
7404 (x_set_frame_alpha): Find topmost parent window with
7405 x_find_topmost_parent and set the property there also (bug#9181).
7406 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7407
c74e9d86
PE
74082011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7409
7410 * callproc.c (Fcall_process): Avoid vfork clobbering
7411 the local vars buffer, coding_systems, current_dir.
7412
640c8776
SM
74132011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7414
7415 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7416
f26d0e4c
PE
74172011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7418
8a10d76c
PE
7419 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7420 so that it is not optimized away.
7421
f26d0e4c
PE
7422 * xdisp.c (compute_display_string_pos): Remove unused local.
7423
55439c61
EZ
74242011-08-02 Eli Zaretskii <eliz@gnu.org>
7425
7426 Fix slow cursor motion and scrolling in large buffers with
7427 selective display, like Org Mode buffers. (Bug#9218)
7428
7429 * dispextern.h (struct bidi_it): New member disp_prop_p.
7430
7431 * xdisp.c: Remove one-slot cache of display string positions.
7432 (compute_display_string_pos): Accept an additional argument
5e617bc2 7433 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7434 for a display string or property. If found, set DISP_PROP_P
7435 non-zero.
7436
7437 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7438 DISP_PROP_P, and pass it to compute_display_string_pos.
7439 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7440 non-zero. All callers of bidi_fetch_char changed.
7441
fb33fa43
SM
74422011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7443
7444 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7445
b099e063
DM
74462010-12-03 Don March <don@ohspite.net>
7447
7448 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7449 last character M-[char] is translated to ESC [char] (bug#7541).
7450
5cc7f7af
KH
74512011-08-02 Kenichi Handa <handa@m17n.org>
7452
d0fffa3f 7453 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7454
7455 * chartab.c (uniprop_table): Make it non-static.
7456
525d5e6e
EZ
74572011-08-01 Eli Zaretskii <eliz@gnu.org>
7458
7459 * xdisp.c (forward_to_next_line_start): Accept additional argument
7460 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7461 on the newline.
7462 (reseat_at_next_visible_line_start): Use the bidi iterator state
7463 returned by forward_to_next_line_start to restore the state of
7464 it->bidi_it after backing up to previous newline. (Bug#9212)
7465
31011111
AS
74662011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7467
7468 * regex.c (re_comp): Protoize.
7469 (re_exec): Fix return type.
7470 (regexec): Fix type of `ret'. (Bug#9203)
7471
476371c4
PE
74722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7473
e5d76069
PE
7474 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7475 This is needed if max-image-size is a floating-point number.
7476
9a79b20c
AS
74772011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7478
7479 * print.c (print_object): Print empty symbol as ##.
7480
7481 * lread.c (read1): Read ## as empty symbol.
7482
d8c2fa78
AA
74832011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7484
7485 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7486 setting frame foreground color (Bug#9175).
7487 (x_set_background_color): Likewise.
7488
ffe57a7a
AA
7489 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7490 contents (Bug#9176).
7491 (EmacsTooltip -init): Remove bezels and add shadows to
7492 tooltip windows.
7493
bf3492a5
AA
7494 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7495 or scroll bar (Bug#8470).
7496
d55e9c53
AA
7497 * nsfont.m (nsfont_open): Remove assignment to voffset and
7498 unnecessary vars hshink, expand, hd, full_height, min_height.
7499 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7500
7501 * nsterm.h (nsfont_info): Remove voffset field.
7502
d8c2fa78 75032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7504
7505 Implement strike-through and overline on NextStep (Bug#8863).
7506
7507 * nsfont.m (nsfont_open): Use underline position provided by font,
7508 instead of hard-coded value of 2.
7509 (nsfont_draw): Call ns_draw_text_decoration instead.
7510
7511 * nsterm.h: Add declaration for ns_draw_text_decoration.
7512
7513 * nsterm.m (ns_draw_text_decoration): New function for drawing
7514 underline, overline, and strike-through.
7515 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7516 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7517 accommodate underlining, etc.
4843aac3 7518
4cc60b9b
EZ
75192011-07-28 Eli Zaretskii <eliz@gnu.org>
7520
bc7ece87
EZ
7521 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7522 default.
4cc60b9b 7523
476371c4
PE
75242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7525
66606eea
PE
7526 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7527 Without this fix, if a signal arrives just after memory fills up,
7528 'malloc' might be invoked reentrantly.
7529
476371c4
PE
7530 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7531 In other words, assume that every image size is allowed, on non-X
7532 hosts. This assumption is probably wrong, but it lets Emacs compile.
7533
f3fcc40d
AS
75342011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7535
7536 * regex.c (re_iswctype): Convert return values to boolean.
7537
350c992f
EZ
75382011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7539
7540 * xdisp.c (compute_display_string_pos): Don't use cached display
7541 string position if the buffer had its restriction changed.
7542 (Bug#9184)
7543
5266b4bb
PE
75442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7545
7546 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7547
2573a837 75482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7549
41f55ccd 7550 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7551
39e378da
PE
7552 * bidi.c: Integer size and overflow fixes.
7553 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7554 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7555 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7556 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7557 (bidi_find_other_level_edge):
7558 Use ptrdiff_t instead of EMACS_INT where either will do.
7559 This works better on 32-bit hosts configured --with-wide-int.
7560 (bidi_cache_ensure_space): Check for size-calculation overflow.
7561 Use % rather than repeated addition, for better worst-case speed.
7562 Don't set bidi_cache_size until after xrealloc returns, because it
7563 might not return.
7564 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7565 (bidi_cache_ensure_space): Also check that the bidi cache size
7566 does not exceed that of the largest Lisp string or buffer. See Eli
7567 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7568
5e927815
PE
7569 * alloc.c (__malloc_size_t): Remove.
7570 All uses replaced by size_t. See Andreas Schwab's note
7571 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7572
ca4aa935
PE
7573 * image.c: Improve checking for integer overflow.
7574 (check_image_size): Assume that f is nonnull, since
7575 it is always nonnull in practice. This is one less thing to
7576 worry about when checking for integer overflow later.
7577 (x_check_image_size): New function, which checks for integer
7578 overflow issues inside X.
7579 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7580 This removes the need for a memory_full check.
7581 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7582 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7583 (xbm_read_bitmap_data): Change locals back to 'int', since
7584 their values must fit in 'int'.
7585 (xpm_load_image, png_load, tiff_load):
7586 Invoke x_create_x_image_and_pixmap earlier,
7587 to avoid much needless work if the image is too large.
7588 (tiff_load): Treat overly large images as if
7589 x_create_x_image_and_pixmap failed, not as malloc failures.
7590 (gs_load): Use x_check_image_size.
7591
5f8f9cc2
PE
7592 * gtkutil.c: Omit integer casts.
7593 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7594 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7595
5adf60bc
PE
7596 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7597
c8907a93
PE
7598 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7599 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7600 would wrongly return t on a 64-bit host.
7601
e3c25c68
PE
7602 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7603 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7604 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7605 and therefore cause GCC to emit a bogus diagnostic in some cases.
7606
3f791afe
PE
7607 * image.c: Integer signedness and overflow and related fixes.
7608 This is not an exhaustive set of fixes, but it's time to
7609 record what I've got.
7610 (lookup_pixel_color, check_image_size): Remove redundant decls.
7611 (check_image_size): Don't assume that arbitrary EMACS_INT values
7612 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7613 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7614 (tiff_load, imagemagick_load_image):
7615 Check for overflow in size calculations.
7616 (x_create_x_image_and_pixmap): Remove unnecessary test for
7617 xmalloc returning NULL; that can't happen.
7618 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7619 (xpm_color_bucket): Use better integer hashing function.
7620 (xpm_cache_color): Don't possibly over-allocate memory.
7621 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7622 (gif_memory_source):
7623 Use ptrdiff_t, not int or size_t, to record sizes.
7624 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7625 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7626 either works, as we prefer signed integers.
7627 (tiff_read_from_memory, tiff_write_from_memory):
7628 Return tsize_t, not size_t, since that's what the TIFF API wants.
7629 (tiff_read_from_memory): Don't fail simply because the read would
7630 go past EOF; instead, return a short read.
7631 (tiff_load): Omit no-longer-needed casts.
7632 (Fimagemagick_types): Don't assume size fits into 'int'.
7633
3cc5a532
PE
7634 Improve hashing quality when configured --with-wide-int.
7635 * fns.c (hash_string): New function, taken from sxhash_string.
7636 Do not discard information about ASCII character case; this
7637 discarding is no longer needed.
7638 (sxhash-string): Use it. Change sig to match it. Caller changed.
7639 * lisp.h: Declare it.
7640 * lread.c (hash_string): Remove, since we now use fns.c's version.
7641 The fns.c version returns a wider integer if --with-wide-int is
7642 specified, so this should help the quality of the hashing a bit.
7643
b312a492
PE
7644 * emacs.c: Integer overflow minor fix.
7645 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7646 Define only if GNU_LINUX.
7647 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7648
dfd153ae
PE
7649 * dispnew.c: Integer signedness and overflow fixes.
7650 Remove unnecessary forward decls, that were a maintenance hassle.
7651 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7652 All uses changed.
7653 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7654 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7655 (prepare_desired_row, line_draw_cost):
7656 Use int, not unsigned, where either works.
7657 (save_current_matrix, restore_current_matrix):
7658 Use ptrdiff_t, not size_t, where either works.
7659 (init_display): Check for overflow more accurately, and without
7660 relying on undefined behavior.
7661
a81d11a3
PE
7662 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7663 Remove, replacing with the new symbols in lisp.h. All uses changed.
7664 * fileio.c (make_temp_name):
7665 * filelock.c (lock_file_1, lock_file):
7666 * xdisp.c (message_dolog):
7667 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7668 Use pMd etc. instead.
7669 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7670 replacing the pWIDE etc. symbols removed from editfns.c.
7671
3300e6fd
PE
7672 * keyboard.h (num_input_events): Now uintmax_t.
7673 This is (very slightly) less likely to mess up due to wraparound.
7674 All uses changed.
7675
fd05c7e9
PE
7676 * buffer.c: Integer signedness fixes.
7677 (alloc_buffer_text, enlarge_buffer_text):
7678 Use ptrdiff_t rather than size_t when either will do, as we prefer
7679 signed integers.
7680
903fe15d
PE
7681 * alloc.c: Integer signedness and overflow fixes.
7682 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7683 (__malloc_size_t): Default to size_t, not to int.
7684 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7685 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7686 Prefer ptrdiff_t to size_t when either would do, as we prefer
7687 signed integers.
7688 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7689 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7690 Now const. Initialize with values that are in range even if char
7691 is signed.
7692 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7693 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7694 These functions do the right thing with sizes > 2**32.
7695 (check_depth): Now ptrdiff_t, not int.
7696 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7697 Adjust to new way of storing sizes. Check for size overflow bugs
7698 in rest of code.
7699 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7700 slightly wrong anyway, as it missed one instance of
7701 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7702 (refill_memory_reserve): Omit needless cast to size_t.
7703 (mark_object_loop_halt): Mark as externally visible.
7704
ac82cc6a
PE
7705 * xselect.c: Integer signedness and overflow fixes.
7706 (Fx_register_dnd_atom, x_handle_dnd_message):
7707 Use ptrdiff_t, not size_t, since we prefer signed.
7708 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7709 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7710 x_dnd_atoms_size and x_dnd_atoms_length.
7711
c2d1e36d
PE
7712 * doprnt.c: Prefer signed to unsigned when either works.
7713 * eval.c (verror):
7714 * doprnt.c (doprnt):
7715 * lisp.h (doprnt):
7716 * xdisp.c (vmessage):
7717 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7718 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7719 prefer signed arithmetic to avoid comparison confusion.
7720 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7721 but is a bit tricky.
7722
0e926e56
PE
7723 Assume freestanding C89 headers, string.h, stdlib.h.
7724 * data.c, doprnt.c, floatfns.c, print.c:
7725 Include float.h unconditionally.
7726 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7727 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7728 * regex.c: Likewise for stddef.h, string.h.
7729 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7730 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7731 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7732 (STDC_HEADERS): Remove obsolete defines.
7733 * sysdep.c: Include limits.h unconditionally.
7734
9cfdb3ec
PE
7735 Assume support for memcmp, memcpy, memmove, memset.
7736 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7737 * regex.c (memcmp, memcpy):
7738 Remove; we assume C89 now.
7739
7740 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7741 (__malloc_safe_bcopy): Remove; no longer needed.
7742
cf950e6b 7743 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7744 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7745 well either way, and we prefer signed to unsigned.
7746
dbf38e02
LMI
77472011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7748
7749 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7750 closes the connection while we're reading (bug#9182).
7751
d6f0886c 77522011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7753
d6f0886c
JD
7754 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7755 are specified (Bug#9168).
24e0f6b1 7756
2eb1f9e6
PE
77572011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7758
7759 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7760 Found by GCC static checking and --with-wide-int on a 32-bit host.
7761
22381272 77622011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7763
7764 * xdisp.c (compute_display_string_pos): Fix logic of caching
7765 previous display string position. Initialize cached_prev_pos to
7766 -1. Fixes slow-down at the beginning of a buffer.
7767
f25e39b4
EZ
77682011-07-24 Eli Zaretskii <eliz@gnu.org>
7769
7770 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7771 for attrs[LFACE_FONTSET_INDEX].
7772
04c4b52e
PE
77732011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7774
7775 * xml.c (parse_region): Remove unused local
7776 that was recently introduced.
7777
c1734fbd
EZ
77782011-07-23 Eli Zaretskii <eliz@gnu.org>
7779
be18c5a5
EZ
7780 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7781 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7782
c1734fbd
EZ
7783 * xdisp.c (move_it_in_display_line_to): Record the best matching
7784 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7785 exit if none of the characters scanned was an exact match.
7786 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7787 when exact match is impossible due to invisible text, and the
7788 lines are truncated.
7789
a258d627
JD
77902011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7791
7792 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7793 for OSX >= 10.7.
7794
b6d5a689
EZ
77952011-07-22 Eli Zaretskii <eliz@gnu.org>
7796
0f74f785
EZ
7797 Fix a significant slow-down of cursor motion with C-n, C-p,
7798 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7799 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7800 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7801 (next_element_from_buffer): Call compute_stop_pos_backwards to
7802 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7803 base_level_stop.
7804 (reseat): Don't look for prev_stop, as that could mean a very long
7805 run.
7806 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7807 <cached_disp_overlay_modiff>: Cache for last found display string
7808 position.
551918c1 7809 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7810 about the same buffer in the same area of character positions, and
7811 the buffer wasn't changed since the time the display string
7812 position was cached.
551918c1 7813
b2d0c91a
EZ
78142011-07-22 Eli Zaretskii <eliz@gnu.org>
7815
7816 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7817 is an integer, which is important for empty lines. (Bug#9149)
7818
043604ee
CY
78192011-07-22 Chong Yidong <cyd@stupidchicken.com>
7820
7821 * frame.c (Fmodify_frame_parameters): In tty case, update the
7822 default face if necessary (Bug#4238).
7823
da4adb04
CY
78242011-07-21 Chong Yidong <cyd@stupidchicken.com>
7825
7826 * editfns.c (Fstring_to_char): No need to explain what a character
7827 is in the docstring (Bug#6576).
7828
9abd0532
LMI
78292011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7830
7831 * xml.c (parse_region): Make sure we always return a tree.
7832
36881d16
HK
78332011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7834
7835 * xml.c (parse_region): If a document contains only comments,
7836 return that, too.
7837
1e98674d
LMI
78382011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7839
7840 * xml.c (make_dom): Return comments, too.
7841
590bd467
PE
78422011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7843
7844 Port to OpenBSD.
7845 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7846 and the surrounding thread.
7847 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7848 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7849 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7850 timer goes off.
7851 * s/openbsd.h (BROKEN_SIGIO): Define.
7852 * unexelf.c (unexec) [__OpenBSD__]:
7853 Don't update the .mdebug section of the Alpha COFF symbol table.
7854
f41628b2
LMI
78552011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7856
7857 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7858 (bug#8460).
7859
b59b67c5
PE
78602011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7861
15e3a074
PE
7862 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7863 This fixes some race conditions on the permissions of any newly
7864 created file.
7865
41bed37d
PE
7866 * alloc.c (valid_pointer_p): Use pipe, not open.
7867 This fixes some permissions issues when debugging.
7868
b59b67c5
PE
7869 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7870 If fchown fails to set both uid and gid, try to set just gid,
7871 as that is sometimes allowed. Adjust the file's mode to eliminate
7872 setuid or setgid bits that are inappropriate if fchown fails.
7873
925a6be7
SM
78742011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7875
7876 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7877 to compare Lisp_Objects.
7878 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7879 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7880 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7881
52968808
AS
78822011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7883
0a6a104b
AS
7884 * lread.c (read_integer): Unread even EOF character.
7885 (read1): Likewise. Properly record start position of symbol.
7886
52968808
AS
7887 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7888 symbol character follows.
7889
9e381cdd
PE
78902011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7891
7892 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7893 This works around a problem with the previous change to Fcopy_file.
7894 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7895 and without this change, GCC might complain about discarding
7896 fchown's return value.
7897
b5641435
JB
78982011-07-16 Juanma Barranquero <lekktu@gmail.com>
7899
7900 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7901
a8031457
PE
79022011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7903
7904 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7905
dd889327
LMI
79062011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7907
750c33f7
LMI
7908 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7909 it's used from the C level.
7910
dd889327
LMI
7911 * process.c: Use the same condition for POLL_FOR_INPUT in both
7912 keyboard.c and process.c (bug#1858).
7913
87e86684
LM
79142011-07-09 Lawrence Mitchell <wence@gmx.li>
7915
7916 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7917 (Fgnutls_boot): Use it.
7918
64348f40
AS
79192011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7920
7921 * doc.c (Fsubstitute_command_keys): Revert last change.
7922
1d698799
LMI
79232011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7924
f863868c
LMI
7925 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7926 quotes the next character, and doesn't affect other longer
7927 sequences (bug#8935).
7928
1d698799
LMI
7929 * lread.c (syms_of_lread): Clarify that is isn't only
7930 `eval-buffer' and `eval-defun' that's affected by
7931 `lexical-binding' (bug#8460).
7932
aa4b6df6
EZ
79332011-07-15 Eli Zaretskii <eliz@gnu.org>
7934
7935 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7936 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7937
5d856da6
PE
79382011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7939
ad6042bb
PE
7940 Fix minor problems found by static checking.
7941 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7942 (elsz): Now a signed constant, not a size_t var. We prefer signed
7943 types to unsigned, to avoid integer comparison confusion. Without
7944 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7945 "cannot optimize loop, the loop counter may overflow", a symptom
7946 of the confusion.
f00bbb22 7947 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7948 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7949
6468f31c
LMI
79502011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7951
49080b10
LMI
7952 * search.c (Fre_search_backward): Mention `case-fold-search' in
7953 all the re_search_* functions (bug#8138).
7954
6468f31c
LMI
7955 * keyboard.c (Fopen_dribble_file): Document when the file is
7956 closed (bug#8056).
7957
c965adc5
EZ
79582011-07-14 Eli Zaretskii <eliz@gnu.org>
7959
df9733bf
EZ
7960 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7961 bidi_cache_idx.
7962
0bb23927
EZ
7963 Support bidi reordering of display and overlay strings.
7964 * xdisp.c (compute_display_string_pos)
7965 (compute_display_string_end): Accept additional argument STRING.
7966 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7967 (reseat_to_string): Initialize bidi_it->string.s and
7968 bidi_it->string.schars.
7969 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7970 NULL (avoids a crash in bidi_paragraph_init).
7971 Initialize itb.string.lstring.
0bb23927
EZ
7972 (init_iterator): Call bidi_init_it only of a valid
7973 buffer position was specified. Initialize paragraph_embedding to
7974 L2R.
7975 (reseat_to_string): Initialize the bidi iterator.
7976 (display_string): If we need to ignore text properties of
7977 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7978 original value of -1 will not work with bidi.)
7979 (compute_display_string_pos): First arg is now struct
7980 `text_pos *'; all callers changed. Support display properties on
7981 Lisp strings.
7982 (compute_display_string_end): Support display properties on Lisp
7983 strings.
7984 (init_iterator, reseat_1, reseat_to_string): Initialize the
7985 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7986 when iterating on a string not from display properties).
640c8776
SM
7987 (compute_display_string_pos, compute_display_string_end):
7988 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7989 arrow keys.
7990 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7991 base_level_stop; instead, set base_level_stop to BEGV.
7992 Fixes crashes in vertical-motion.
0bb23927
EZ
7993 (next_element_from_buffer): Improve commentary for when
7994 the iterator is before prev_stop.
7995 (init_iterator): Initialize bidi_p from the default value of
7996 bidi-display-reordering, not from buffer-local value. Use the
7997 buffer-local value only if initializing for buffer iteration.
7998 (handle_invisible_prop): Support invisible properties on strings
7999 that are being bidi-reordered.
8000 (set_iterator_to_next): Support bidi reordering of C strings and
8001 Lisp strings.
8002 (next_element_from_string): Support bidi reordering of Lisp
8003 strings.
8004 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8005 (display_string): Support display of R2L glyph rows.
8006 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8007 (init_iterator): Don't initialize it->bidi_p for strings
8008 here.
8009 (reseat_to_string): Initialize it->bidi_p for strings here.
8010 (next_element_from_string, next_element_from_c_string)
8011 (next_element_from_buffer): Add xassert's for correspondence
8012 between IT's object being iterated and it->bidi_it.string
8013 structure.
8014 (face_before_or_after_it_pos): Support bidi iteration.
8015 (next_element_from_c_string): Handle the case of the first string
8016 character that is not the first one in the visual order.
8017 (get_visually_first_element): New function, refactored from common
8018 parts of next_element_from_buffer, next_element_from_string, and
8019 next_element_from_c_string.
8020 (tool_bar_lines_needed, redisplay_tool_bar)
8021 (display_menu_bar): Force left-to-right direction. Add a FIXME
8022 comment for making that be controlled by a user option.
8023 (push_it, pop_it): Save and restore the state of the
8024 bidi iterator. Save and restore the bidi_p flag.
8025 (pop_it): Iterate out of display property for string iteration as
8026 well.
8027 (iterate_out_of_display_property): Support iteration over strings.
8028 (handle_single_display_spec): Set up it->bidi_it for iteration
8029 over a display string, and call bidi_init_it.
8030 (handle_single_display_spec, next_overlay_string)
8031 (get_overlay_strings_1, push_display_prop): Set up the bidi
8032 iterator for displaying display or overlay strings.
8033 (forward_to_next_line_start): Don't use the shortcut if
8034 bidi-iterating.
8035 (back_to_previous_visible_line_start): If handle_display_prop
8036 pushed the iterator stack, restore the internal state of the bidi
8037 iterator by calling bidi_pop_it same number of times.
8038 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8039 and we are bidi-iterating, don't decrement the iterator position;
8040 instead, set the first_elt flag in the bidi iterator, to produce
8041 the same effect.
8042 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8043 (push_display_prop): xassert that we are iterating a buffer.
8044 (push_it, pop_it): Save and restore paragraph_embedding member.
8045 (handle_single_display_spec, next_overlay_string)
8046 (get_overlay_strings_1, reseat_1, reseat_to_string)
8047 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8048 correctly. Don't assume unibyte strings are not bidi-reordered.
8049 (compute_display_string_pos)
8050 (compute_display_string_end): Fix handling the case of C string.
8051 (push_it, pop_it): Save and restore from_disp_prop_p.
8052 (handle_single_display_spec, push_display_prop): Set the
8053 from_disp_prop_p flag.
8054 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8055 (pop_it): Call iterate_out_of_display_property only if we are
8056 popping after iteration over a string that came from a display
8057 property. Fix a typo in popping stretch info. Add an assertion
8058 for verifying that the iterator position is in sync with the bidi
8059 iterator.
8060 (handle_single_display_spec, get_overlay_strings_1)
8061 (push_display_prop): Fix initialization of paragraph direction for
8062 string when that of the parent object is not yet determined.
8063 (reseat_1): Call bidi_init_it to resync the bidi
8064 iterator with IT's position. (Bug#7616)
8065 (find_row_edges): If ROW->start.pos gives position
8066 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8067 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8068 Reset the from_disp_prop_p flag.
8069 (SAVE_IT, RESTORE_IT): New macros.
8070 (pos_visible_p, face_before_or_after_it_pos)
8071 (back_to_previous_visible_line_start)
8072 (move_it_in_display_line_to, move_it_in_display_line)
8073 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8074 (try_scrolling, redisplay_window, display_line): Use them when
8075 saving a temporary copy of the iterator and restoring it back.
8076 (back_to_previous_visible_line_start, reseat_1)
8077 (init_iterator): Empty the bidi cache "stack".
8078 (move_it_in_display_line_to): If iterator ended up at
8079 EOL, but we never saw any buffer positions smaller than
8080 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8081 motion in bidi-reordered lines.
8082 (move_it_in_display_line_to): Record prev_method and prev_pos
8083 immediately before the call to set_iterator_to_next. Fixes cursor
8084 motion in bidi-reordered lines with stretch glyphs and strings
8085 displayed in margins. (Bug#8133) (Bug#8867)
8086 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8087 TO_CHARPOS.
640c8776
SM
8088 (pos_visible_p): Support positions in bidi-reordered lines.
8089 Save and restore bidi cache.
0bb23927
EZ
8090
8091 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8092 (bidi_paragraph_info): Delete unused struct.
8093 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8094 (bidi_cache_start): New variable.
8095 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8096 to zero.
8097 (bidi_cache_fetch_state, bidi_cache_search)
8098 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8099 (bidi_cache_find, bidi_peek_at_next_level)
8100 (bidi_level_of_next_char, bidi_find_other_level_edge)
8101 (bidi_move_to_visually_next): Compare cache index with
8102 bidi_cache_start rather than with zero.
8103 (bidi_fetch_char): Accept new argument STRING; all callers
8104 changed. Support iteration over a string. Support strings with
8105 display properties. Support unibyte strings. Fix the type of
8106 `len' according to what STRING_CHAR_AND_LENGTH expects.
8107 (bidi_paragraph_init, bidi_resolve_explicit_1)
8108 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8109 (bidi_level_of_next_char, bidi_move_to_visually_next):
8110 Support iteration over a string.
0bb23927
EZ
8111 (bidi_set_sor_type, bidi_resolve_explicit_1)
8112 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8113 can now be zero (for strings); special values 0 and -1 were
8114 changed to -1 and -2, respectively.
8115 (bidi_char_at_pos): New function.
8116 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8117 Call it instead of FETCH_MULTIBYTE_CHAR.
8118 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8119 initialized to valid values.
8120 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8121 values.
8122 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8123 the test for valid cached positions. Fix the logic for looking up
8124 the sentinel state in the cache. GCPRO the Lisp string we are
8125 iterating.
8126 (bidi_push_it, bidi_pop_it): New functions.
8127 (bidi_initialize): Initialize the bidi cache start stack pointer.
8128 (bidi_cache_ensure_space): New function, refactored from part of
8129 bidi_cache_iterator_state. Don't assume the required size is just
8130 one BIDI_CACHE_CHUNK away.
8131 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8132 (bidi_count_bytes, bidi_char_at_pos): New functions.
8133 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8134 always valid if bidi_cache_idx is valid.
8135 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8136 is valid if it's going to be used.
8137 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8138 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8139 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8140 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8141 (bidi_find_other_level_edge, bidi_cache_start_stack):
8142 All variables related to cache indices are now EMACS_INT.
c965adc5 8143
0bb23927
EZ
8144 * dispextern.h (struct bidi_string_data): New structure.
8145 (struct bidi_it): New member `string'. Make flag members be 1-bit
8146 fields, and put them last in the struct.
640c8776
SM
8147 (compute_display_string_pos, compute_display_string_end):
8148 Update prototypes.
0bb23927
EZ
8149 (bidi_push_it, bidi_pop_it): Add prototypes.
8150 (struct iterator_stack_entry): New members bidi_p,
8151 paragraph_embedding, and from_disp_prop_p.
8152 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8153 (bidi_shelve_cache, bidi_unshelve_cache):
8154 Declare prototypes.
0bb23927
EZ
8155
8156 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8157 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8158 and vector-like objects.
8159
8160 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8161 cache around display iteration.
8162
8163 * window.c (Fwindow_end, window_scroll_pixel_based)
8164 (displayed_window_lines, Frecenter): Save and restore the bidi
8165 cache around display iteration.
8166
3bbd2265
LMI
81672011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8168
8169 * editfns.c (Fdelete_region): Clarify the use of the named
8170 parameters (bug#6788).
8171
adc47434
MR
81722011-07-14 Martin Rudalics <rudalics@gmx.at>
8173
8174 * indent.c (Fvertical_motion): Set and restore w->pointm when
8175 saving and restoring the window's buffer (Bug#9006).
8176
837c31f8
LMI
81772011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8178
8179 * editfns.c (Fstring_to_char): Clarify just what is returned
8180 (bug#6576). Text by Eli Zaretskii.
8181
ac389d0c
JB
81822011-07-13 Juanma Barranquero <lekktu@gmail.com>
8183
8184 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8185
0be0ce47
EZ
81862011-07-13 Eli Zaretskii <eliz@gnu.org>
8187
8188 * buffer.c (mmap_find): Fix a typo.
8189
cd18e7e3
JB
81902011-07-13 Johan Bockgård <bojohan@gnu.org>
8191
8192 Fix execution of x selection hooks.
8193 * xselect.c (Qx_lost_selection_functions)
8194 (Qx_sent_selection_functions): New vars.
8195 (syms_of_xselect): DEFSYM them.
8196 (x_handle_selection_request): Pass Qx_sent_selection_functions
8197 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8198 (x_handle_selection_clear,x_clear_frame_selections):
8199 Pass Qx_lost_selection_functions rather than
8200 Vx_lost_selection_functions to Frun_hook_with_args.
8201
47ea7f44
PE
82022011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8203
ac389d0c 8204 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8205 The old code sometimes used this field without initializing it.
8206
47ea7f44
PE
8207 * alloc.c (gc_sweep): Don't read past end of array.
8208 In theory, the old code could also have corrupted Emacs internals,
8209 though it'd be very unlikely.
8210
bc985c87
AS
82112011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8212
8213 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8214 argument. (Bug#4026)
bc985c87 8215
0cf34688
LMI
82162011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8217
b3dadd76
LMI
8218 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8219 key" (bug#4257).
8220
0cf34688
LMI
8221 * window.c (Fset_window_start): Doc fix (bug#4199).
8222 (Fset_window_hscroll): Ditto.
8223
270768cd
PE
82242011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8225
077e3dda 8226 Fix minor new problems caught by GCC 4.6.1.
270768cd 8227 * term.c (init_tty): Remove unused local.
490011a6 8228 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8229 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8230 not used otherwise.
270768cd 8231
b1f58454
CY
82322011-07-12 Chong Yidong <cyd@stupidchicken.com>
8233
8234 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8235
22b9578d
LMI
82362011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8237
6e70ab07
LMI
8238 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8239 are the mini-buffer and the echo area (bug#3320).
8240
22b9578d
LMI
8241 * term.c (init_tty): Remove support for supdup, c10 and perq
8242 terminals, which are no longer supported (bug#1482).
8243
8974cc9f
JB
82442011-07-10 Johan Bockgård <bojohan@gnu.org>
8245
8246 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8247
a560d974
JD
82482011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8249
8250 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8251 for non-popups (Bug#3642).
8252
1dae0f0a
AS
82532011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8254
268c2c36 8255 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8256 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8257 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8258 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8259 * data.c (fmod): Likewise.
8260 * dispnew.c (swap_glyphs_in_rows): Likewise.
8261 * emacs.c (memory_warning_signal): Likewise.
8262 * floatfns.c (float_error): Likewise.
8263 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8264 (otf_open, font_otf_capability, generate_otf_features)
8265 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8266 Likewise.
8267 * image.c (pbm_read_file): Likewise.
8268 * indent.c (string_display_width): Likewise.
8269 * intervals.c (check_for_interval, search_for_interval)
8270 (inc_interval_count, count_intervals, root_interval)
8271 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8272 * lread.c (defalias): Likewise.
268c2c36 8273 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8274 * regex.c (set_image_of_range_1, set_image_of_range)
8275 (regex_grow_registers): Likewise.
8276 * sysdep.c (strerror): Likewise.
8277 * termcap.c (valid_filename_p, tprint, main): Likewise.
8278 * tparam.c (main): Likewise.
8279 * unexhp9k800.c (run_time_remap, save_data_space)
8280 (update_file_ptrs, read_header, write_header, calculate_checksum)
8281 (copy_file, copy_rest, display_header): Likewise.
8282 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8283 Likewise.
8284 * xdisp.c (check_it): Likewise.
8285 * xfaces.c (register_color, unregister_color, unregister_colors):
8286 Likewise.
8287 * xfns.c (print_fontset_result): Likewise.
8288 * xrdb.c (member, fatal, main): Likewise.
8289
99033785
PE
82902011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8291
8292 Fix minor problems found by static checking (Bug#9031).
8293 * chartab.c (char_table_set_range, map_sub_char_table):
8294 Remove unused locals.
8295 (uniprop_table): Now static.
8296 * composite.c (_work_char): Remove unused static var.
8297
9cb2ac56
JB
82982011-07-09 Juanma Barranquero <lekktu@gmail.com>
8299
8300 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8301
f25661f0
JD
83022011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8303
8304 * gtkutil.c (qttip_cb): Remove code without function.
8305
8278c4fe
EZ
83062011-07-09 Eli Zaretskii <eliz@gnu.org>
8307
8308 * w32.c (pthread_sigmask): New stub.
8309
1692ae2d 83102011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8311
8a6ebd58 8312 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8313 sigprocmask is portable only for single-threaded applications, and
8314 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8315 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8316 (LIBES): Use it.
8317 * callproc.c (Fcall_process):
8318 * process.c (create_process):
8319 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8320 Use pthread_sigmask, not sigprocmask.
123403e4 8321
1b854618
JD
83222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8323
8324 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8325 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8326 wrong (Bug#8591).
8327
3fe4b549
JD
83282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8329
0ce7e563
JD
8330 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8331 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8332 (xg_hide_tooltip): Fix comment.
8333
3fe4b549
JD
8334 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8335 in registerServicesMenuSendTypes.
8336 (validRequestorForSendType): Don't check ns_return_types.
8337
8338 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8339 ns_return_type.
8340
5df75e47
JR
83412011-07-08 Jason Rumney <jasonr@gnu.org>
8342
22610910
JR
8343 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8344 SH_SHOW for hidden windows (Bug#5482).
8345
5df75e47
JR
8346 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8347 frame struct members of non-existent frames (Bug#6284).
8348
699c10bd
JD
83492011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8350
4393663b
JD
8351 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8352 variable firstTime not needed on OSX >= 10.6.
8353 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8354 >= 10.5. Use setKnobProportion, setDoubleValue.
8355
8356 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8357 (MAC_OS_X_VERSION_10_5): Define if not defined.
8358 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8359 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8360 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8361
8362 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8363 cString and lossyCString on OSX >= 10.4.
4393663b 8364
58179cce 8365 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8366 sizeToFit on OSX >= 10.2.
8367
8368 * nsimage.m (allocInitFromFile): Don't use deprecated method
8369 bestRepresentationForDevice on OSX >= 10.6.
8370
8371 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8372 to avoid warning.
8373
8374 * emacs.c: Declare unexec_init_emacs_zone.
8375
a63e0781
JD
8376 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8377
699c10bd
JD
8378 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8379
8380 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8381 on svcsMenu (Bug#8842).
8382
8383 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8384 ns_return_types.
8385 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8386
8387 * nsterm.m (QUTF8_STRING): Declare.
8388 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8389 (validRequestorForSendType): Return type is (id).
8390 Change indexOfObjectIdenticalTo to indexOfObject.
8391 Check if we have local selection before returning self (Bug#8842).
8392 (writeSelectionToPasteboard): Put local selection into paste board
8393 if we have a local selection (Bug#8842).
8394 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8395
8396 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8397 (ns_get_local_selection): Declare.
8398
54e10184
LMI
83992011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8400
9888ff71
LMI
8401 * keymap.c (describe_map_tree): Don't insert a double newline at
8402 the end of the buffer (bug#1169) and return whether we inserted
8403 something.
8404
54e10184
LMI
8405 * callint.c (Fcall_interactively): Change "reading args" to
8406 "providing args" to try to clarify what it does (bug#1010).
8407
15fa4783
KH
84082011-07-07 Kenichi Handa <handa@m17n.org>
8409
8410 * composite.c (composition_compute_stop_pos): Ignore a static
8411 composition starting before CHARPOS (Bug#8915).
8412
8413 * xdisp.c (handle_composition_prop): Likewise.
8414
a8815b00
EZ
84152011-07-07 Eli Zaretskii <eliz@gnu.org>
8416
8417 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8418 (Bug#9015)
8419
ef7b981d 84202011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8421
8422 * character.h (unicode_category_t): New enum type.
8423
8424 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8425 (Qchar_code_property_table): New variable.
8426 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8427 (UNIPROP_COMPRESSED_FORM_P): New macros.
8428 (char_table_ascii): Uncompress the compressed values.
8429 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8430 Uncompress the compressed values.
ac389d0c 8431 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8432 (char_table_ref_and_range): Uncompress the compressed values.
8433 (sub_char_table_set): New arg is_uniprop. Callers changed.
8434 Uncompress the compressed values.
8435 (sub_char_table_set_range): Args changed. Callers changed.
8436 (char_table_set_range): Adjuted for the above change.
8437 (map_sub_char_table): Delete args default_val and parent. Add arg
8438 top. Give decoded values to a Lisp function.
640c8776 8439 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8440 values to a Lisp function. Gcpro more variables.
8441 (uniprop_table_uncompress)
8442 (uniprop_decode_value_run_length): New functions.
8443 (uniprop_decoder, uniprop_decoder_count): New variables.
8444 (uniprop_get_decoder, uniprop_encode_value_character)
8445 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8446 New functions.
8447 (uniprop_encoder, uniprop_encoder_count): New variables.
8448 (uniprop_get_encoder, uniprop_table)
8449 (Funicode_property_table_internal, Fget_unicode_property_internal)
8450 (Fput_unicode_property_internal): New functions.
8451 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8452 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8453 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8454 char-code-property-alist.
8455
640c8776 8456 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8457 Vunicode_category_table.
8458
640c8776 8459 * font.c (font_range): Adjust for the change of
c805dec0
KH
8460 Vunicode_category_table.
8461
76b397fb
DN
84622011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8463
8464 * m/iris4d.h: Remove file, move contents ...
8465 * s/irix6-5.h: ... here.
8466
22b4128e
PE
84672011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8468
8469 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8470 * alloc.c (mark_buffer):
8471 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8472 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8473 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8474 This isn't true in general, and it's particularly not true
8475 if Emacs is configured with --with-wide-int.
8476 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8477 New macros, used in the buffer.c change.
8478
869795d6
JD
84792011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8480
8481 * xsettings.c: Use both GConf and GSettings if both are available.
8482 (store_config_changed_event): Add comment.
8483 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8484 (store_tool_bar_style_changed): New functions.
5e617bc2 8485 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8486 (struct xsettings): Move font inside HAVE_XFT.
8487 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8488 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8489 Move inside HAVE_XFT.
640c8776 8490 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8491 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8492 also.
8493 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8494 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8495 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8496 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8497 (parse_settings): Move check for font inside HAVE_XFT.
8498 (read_settings, apply_xft_settings): Add comment.
8499 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8500 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8501 call store_font_name_changed.
8502 (xft_settings_event): Add comment.
8503 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8504 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8505 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8506 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8507 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8508 (xsettings_get_system_font, xsettings_get_system_normal_font):
8509 Add comment.
869795d6 8510
d8ed26bd
PE
85112011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8512
8513 Random fixes. E.g., (random) never returned negative values.
8514 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8515 subseconds part to the entropy, as that's a bit more random.
8516 Prefer signed to unsigned, since the signedness doesn't matter and
8517 in general we prefer signed. When given a limit, use a
8518 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8519 latter isn't right if USE_2_TAGS_FOR_INTS.
8520 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8521 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8522
cabf1cac
SM
85232011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8524
8525 * textprop.c (text_property_stickiness):
8526 Obey Vtext_property_default_nonsticky.
8527 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8528 * w32fns.c (syms_of_w32fns):
8529 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8530
6e9b2be9
PE
85312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8532
8533 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8534 This is more efficient than Ffile_directory_p and avoids a minor race.
8535
90186c68
LMI
85362011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8537
7c301272
LMI
8538 * buffer.c (Foverlay_put): Say what the return value is
8539 (bug#7835).
8540
c4f2d8d4
LMI
8541 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8542 is a directory before asking whether to use the file name
8543 (bug#7564).
ad637907
LMI
8544 (barf_or_query_if_file_exists): Make the "File is a directory"
8545 error be more correct.
c4f2d8d4 8546
90186c68
LMI
8547 * fns.c (Frequire): Remove the mention of the .gz files, since
8548 that's installation-specific, but keep the mention of
8549 `get-load-suffixes'.
8550
da64016e
PE
85512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8552
8553 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8554 Report string overflow if the output is too long.
8555
7d47b580
JB
85562011-07-04 Juanma Barranquero <lekktu@gmail.com>
8557
a555cb87
JB
8558 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8559 (syms_of_gnutls): Remove duplicate DEFSYM for
8560 Qgnutls_bootprop_verify_hostname_error, an error for
8561 Qgnutls_bootprop_verify_error (which is no longer used).
8562
7d47b580
JB
8563 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8564 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8565 Also (re)move comments that are misplaced or no longer relevant.
8566
1e49bfab
LMI
85672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8568
8569 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8570
1485f4c0
CY
85712011-07-03 Chong Yidong <cyd@stupidchicken.com>
8572
8573 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8574 and background color parameters if they have been changed.
8575
a9ab721e
LMI
85762011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8577
8578 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8579
cf7cff57
PE
85802011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8581
2e13213d
PE
8582 * xsettings.c (SYSTEM_FONT): Define only when used.
8583 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8584
cf7cff57
PE
8585 * keymap.c (access_keymap_1): Now static.
8586
7a8e04f7
CY
85872011-07-02 Chong Yidong <cyd@stupidchicken.com>
8588
8589 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8590 leave any prefix arg for the up event (Bug#1586).
8591
61352f62
LMI
85922011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8593
69bb1ef7
LMI
8594 * lread.c (syms_of_lread): Mention single symbols defined by
8595 `defvar' or `defconst' (bug#7154).
8596
61352f62 8597 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8598 (Frequire): Mention get-load-suffixes.
61352f62 8599
28545e04
MR
86002011-07-02 Martin Rudalics <rudalics@gmx.at>
8601
8602 * window.h (window): Remove clone_number slot.
8603 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8604 Remove.
8605 (make_parent_window, make_window, saved_window)
8606 (Fset_window_configuration, save_window_save): Don't deal with
8607 clone numbers.
8608 * buffer.c (Qclone_number): Remove declaration.
8609 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8610
3349e122
SM
86112011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8612
8613 Add multiple inheritance to keymaps.
8614 * keymap.c (Fmake_composed_keymap): New function.
8615 (Fset_keymap_parent): Simplify.
8616 (fix_submap_inheritance): Remove.
8617 (access_keymap_1): New function extracted from access_keymap to handle
8618 embedded parents and handle lists of maps.
8619 (access_keymap): Use it.
8620 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8621 (Fcopy_keymap): Handle embedded parents.
8622 (Fcommand_remapping, define_as_prefix): Simplify.
8623 (Fkey_binding): Simplify.
8624 (syms_of_keymap): Move minibuffer-local-completion-map,
8625 minibuffer-local-filename-completion-map,
8626 minibuffer-local-must-match-map, and
8627 minibuffer-local-filename-must-match-map to Elisp.
8628 (syms_of_keymap): Defsubr make-composed-keymap.
8629 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8630 (parse_menu_item): Trivial simplification.
8631
3279eb87
GM
86322011-07-01 Glenn Morris <rgm@gnu.org>
8633
8634 * Makefile.in (SETTINGS_LIBS): Fix typo.
8635
4550efdf
KI
86362011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8637
8638 * coding.c (Fencode_coding_string): Record the last coding system
8639 used, as the function doc string says (bug#8738).
8640
0949d2b6
JD
86412011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8642
8643 * xsettings.c (store_monospaced_changed): Take new font as arg and
8644 check for change against current_mono_font.
8645 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8646 (emacs_settings_constructor, emacs_settings_get_property)
8647 (emacs_settings_set_property, emacs_settings_class_init)
8648 (emacs_settings_init, gsettings_obj): Remove.
8649 (something_changedCB): New function for HAVE_GSETTINGS.
8650 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8651 with value as argument.
8652 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8653 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8654 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8655 "changed".
8656
8657 * xgselect.c: Add defined (HAVE_GSETTINGS).
8658 (xgselect_initialize): Ditto.
8659
8660 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8661 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8662 xg_select.
8663
bbc6b304
PE
86642011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8665
8666 * eval.c (struct backtrace): Simplify and port the data structure.
8667 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8668 signed bit field, as this assumption is not portable and it makes
8669 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8670 "char debug_on_exit : 1" as this is not portable either; instead,
8671 use the portable "unsigned int debug_on_exit : 1". Remove unused
8672 member evalargs. Remove obsolete comments about cc bombing out.
8673
9851bfc5
JD
86742011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8675
51bb811f 8676 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8677 Let HAVE_GSETTINGS override HAVE_GCONF.
8678 (store_monospaced_changed): New function.
8679 (EMACS_SETTINGS): A new type derived from GObject to handle
8680 GSettings notifications.
8681 (emacs_settings_constructor, emacs_settings_get_property)
8682 (emacs_settings_set_property, emacs_settings_class_init):
8683 New functions.
8684 (gsettings_client, gsettings_obj): New variables.
8685 (GSETTINGS_SCHEMA): New define.
8686 (something_changedCB): Call store_monospaced_changed.
8687 (init_gsettings): New function.
8688 (xsettings_initialize): Call init_gsettings.
8689 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8690 to NULL.
8691
640c8776 8692 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8693 GCONF_CFLAGS/LIBS.
8694
5386012d
MR
86952011-06-29 Martin Rudalics <rudalics@gmx.at>
8696
8697 * window.c (resize_root_window, grow_mini_window)
8698 (shrink_mini_window): Rename Qresize_root_window to
8699 Qwindow_resize_root_window and Qresize_root_window_vertically to
8700 Qwindow_resize_root_window_vertically.
8701
f13e0b08
PE
87022011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8703
8704 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8705
94515237
JB
87062011-06-27 Juanma Barranquero <lekktu@gmail.com>
8707
8708 * makefile.w32-in: Redesign dependencies so they reflect more
8709 clearly which files are directly included by each source file,
8710 and not through other includes.
8711
e43b6e43
MR
87122011-06-27 Martin Rudalics <rudalics@gmx.at>
8713
8714 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8715 (sort_overlays, overlay_strings): When an overlay's clone number
8716 matches the window's clone number process the overlay even if
8717 the overlay's window property doesn't match the current window.
8718
d68443dc
MR
8719 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8720 (Fwindow_hchild): Rename to Fwindow_left_child.
8721 (Fwindow_next): Rename to Fwindow_next_sibling.
8722 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8723 (resize_window_check): Rename to window_resize_check.
8724 (resize_window_apply): Rename to window_resize_apply.
8725 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8726 (Fdelete_other_windows_internal, resize_frame_windows)
8727 (Fsplit_window_internal, Fdelete_window_internal)
8728 (grow_mini_window, shrink_mini_window)
8729 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8730
c7e73be5
JD
87312011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8732
8733 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8734 (emacs_fixed_set_min_size): Remove.
8735 (emacs_fixed_new): Take frame as argument.
8736
8737 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8738 (_EmacsFixedPrivate): Remove minwidth/height.
8739 Add struct frame *f.
8740 (emacs_fixed_init): Initialize priv->f.
8741 (get_parent_class, emacs_fixed_set_min_size): Remove.
8742 (emacs_fixed_new): Set priv->f to argument.
8743 (emacs_fixed_get_preferred_width)
8744 (emacs_fixed_get_preferred_height): Use min_width/height from
8745 frames size_hint to set minimum and natural (Bug#8919).
8746 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8747 and use min_width/height from frames size_hint to set
8748 min_width/height (Bug#8919).
8749
8750 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8751 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8752 Fix indentation.
c7e73be5 8753
cf99dcf8
EZ
87542011-06-26 Eli Zaretskii <eliz@gnu.org>
8755
8756 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8757 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8758 called at ZV.
8759
029529ac
CY
87602011-06-26 Chong Yidong <cyd@stupidchicken.com>
8761
8762 * process.c (wait_reading_process_output): Bypass select if
8763 waiting for a cell while ignoring keyboard input, and input is
8764 pending. Suggested by Jan Djärv (Bug#8869).
8765
7a7ef429
PE
87662011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8767
8768 Use gnulib's dup2 module instead of rolling our own.
8769 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8770
11fdef7d 87712011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8772
8773 * dispnew.c (scrolling_window): Before scrolling, turn off a
8774 mouse-highlight in the window being scrolled.
8775
cd3520a4
JB
87762011-06-24 Juanma Barranquero <lekktu@gmail.com>
8777
8778 Move DEFSYM to lisp.h and use everywhere.
8779
8780 * character.h (DEFSYM): Move declaration...
8781 * lisp.h (DEFSYM): ...here.
8782
8783 * gnutls.c:
8784 * minibuf.c:
8785 * w32menu.c:
8786 * w32proc.c:
8787 * w32select.c: Don't include character.h.
8788
8789 * alloc.c (syms_of_alloc):
8790 * buffer.c (syms_of_buffer):
8791 * bytecode.c (syms_of_bytecode):
8792 * callint.c (syms_of_callint):
8793 * casefiddle.c (syms_of_casefiddle):
8794 * casetab.c (init_casetab_once):
8795 * category.c (init_category_once, syms_of_category):
8796 * ccl.c (syms_of_ccl):
8797 * cmds.c (syms_of_cmds):
8798 * composite.c (syms_of_composite):
8799 * dbusbind.c (syms_of_dbusbind):
8800 * dired.c (syms_of_dired):
8801 * dispnew.c (syms_of_display):
8802 * doc.c (syms_of_doc):
8803 * editfns.c (syms_of_editfns):
8804 * emacs.c (syms_of_emacs):
8805 * eval.c (syms_of_eval):
8806 * fileio.c (syms_of_fileio):
8807 * fns.c (syms_of_fns):
8808 * frame.c (syms_of_frame):
8809 * fringe.c (syms_of_fringe):
8810 * insdel.c (syms_of_insdel):
8811 * keymap.c (syms_of_keymap):
8812 * lread.c (init_obarray, syms_of_lread):
8813 * macros.c (syms_of_macros):
8814 * msdos.c (syms_of_msdos):
8815 * print.c (syms_of_print):
8816 * process.c (syms_of_process):
8817 * search.c (syms_of_search):
8818 * sound.c (syms_of_sound):
8819 * syntax.c (init_syntax_once, syms_of_syntax):
8820 * terminal.c (syms_of_terminal):
8821 * textprop.c (syms_of_textprop):
8822 * undo.c (syms_of_undo):
8823 * w32.c (globals_of_w32):
8824 * window.c (syms_of_window):
8825 * xdisp.c (syms_of_xdisp):
8826 * xfaces.c (syms_of_xfaces):
8827 * xfns.c (syms_of_xfns):
8828 * xmenu.c (syms_of_xmenu):
8829 * xsettings.c (syms_of_xsettings):
8830 * xterm.c (syms_of_xterm): Use DEFSYM.
8831
4228cf16
TZ
88322011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8833
cd3520a4 8834 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8835
7fcccf1e
PE
88362011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8837
7efb4e0e
PE
8838 Integer and buffer overflow fixes (Bug#8873).
8839
ff5844ad
PE
8840 * print.c (printchar, strout): Check for string overflow.
8841 (PRINTPREPARE, printchar, strout):
8842 Don't set size unless allocation succeeds.
8843
90532f02
PE
8844 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8845 for sizes. Check for string overflow more accurately.
8846 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8847
6d84508d
PE
8848 * macros.c: Integer and buffer overflow fixes.
8849 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8850 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8851 Use ptrdiff_t, not int, for sizes.
8852 Don't increment bufsize until after realloc succeeds.
8853 Check for size-calculation overflow.
8854 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8855
437b2cb4
PE
8856 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8857
8b9ac8b4
PE
8858 * lread.c: Integer overflow fixes.
8859 (read_integer): Radix is now EMACS_INT, not int,
8860 to improve quality of diagnostics for out-of-range radices.
8861 Calculate buffer size correctly for out-of-range radices.
8862 (read1): Check for integer overflow in radices, and in
8863 read-circle numbers.
82cb60d3
PE
8864 (read_escape): Avoid int overflow.
8865 (Fload, openp, read_buffer_size, read1)
8866 (substitute_object_recurse, read_vector, read_list, map_obarray):
8867 Use ptrdiff_t, not int, for sizes.
8868 (read1): Use EMACS_INT, not int, for sizes.
20270765 8869 Check for size overflow.
8b9ac8b4 8870
7fcccf1e
PE
8871 * image.c (cache_image): Check for size arithmetic overflow.
8872
bfbbd7e7
PE
8873 * lread.c: Integer overflow issues.
8874 (saved_doc_string_size, saved_doc_string_length)
8875 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8876 Now ptrdiff_t, not int.
8877 (read1): Don't assume doc string length fits in int. Check for
8878 out-of-range doc string lengths.
8879 (read_list): Don't assume file position fits in int.
39019e54 8880 (read_escape): Check for hex character overflow.
bfbbd7e7 8881
4e323265
LL
88822011-06-22 Leo Liu <sdl.web@gmail.com>
8883
8884 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8885 Move to minibuffer.el.
8886
85fece3e
PE
88872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8888
20b84ce9 8889 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8890 The following patches are for when GLYPH_DEBUG && !XASSERT.
8891 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8892 * dispnew.c (flush_stdout):
8893 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8894 Mark as externally visible.
8895 * dispnew.c (check_window_matrix_pointers): Now static.
8896 * dispnew.c (window_to_frame_vpos):
8897 * xfns.c (unwind_create_frame):
8898 * xterm.c (x_check_font): Remove unused local.
8899 * scroll.c (CHECK_BOUNDS):
8900 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8901 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8902 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8903 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8904 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8905 Now static.
8906 (debug_method_add): Use va_list and vsprintf rather than relying
8907 on undefined behavior with wrong number of arguments.
8908 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8909 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8910 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8911 since we're not interested in debugging glyphs with old libraries.
8912 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8913 GCC 4.6.0's static checking.
8914
0766b489
PE
89152011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8916
31fd4b32
PE
8917 Integer overflow and signedness fixes (Bug#8873).
8918 A few related buffer overrun fixes, too.
8919
b79e8648
PE
8920 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8921
0766b489
PE
8922 * dispextern.h (struct face.stipple):
8923 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8924 (x_bitmap_mask, x_allocate_bitmap_record)
8925 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8926 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8927 (x_create_bitmap_from_xpm_data):
8928 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8929 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8930 (.bitmaps_last):
8931 * xfaces.c (load_pixmap):
8932 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8933 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8934 (.bitmaps_last, struct x_output.icon_bitmap):
8935 Use ptrdiff_t, not int, for bitmap indexes.
8936 (x_allocate_bitmap_record): Check for size overflow.
8937 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8938
b081724f
PE
8939 Use ptrdiff_t, not int, for overlay counts.
8940 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8941 * editfns.c (overlays_around, get_pos_property):
8942 * textprop.c (get_char_property_and_overlay):
8943 * xdisp.c (next_overlay_change, note_mouse_highlight):
8944 * xfaces.c (face_at_buffer_position):
21514da7
PE
8945 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8946 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8947 (Fnext_overlay_change, Fprevious_overlay_change)
8948 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8949 Use ptrdiff_t, not int, for sizes.
21514da7 8950 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8951
3de73e5e
PE
8952 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8953
2606c57b
PE
8954 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8955 (x_session_initialize): Do not assume string length fits in int.
8956
aaafe47a
PE
8957 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8958 This is unlikely, but can occur if DPI is outlandish.
8959
2674ddc8 8960 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8961 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8962
28154962
PE
8963 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8964 * xrdb.c (magic_file_p, search_magic_path):
8965 Omit last arg SUFFIX; it was always 0. All callers changed.
8966 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8967
7de51af5
PE
8968 * xfont.c (xfont_match): Avoid need for strlen.
8969
25ed6cc3
PE
8970 * xfns.c: Don't assume strlen fits in int.
8971 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8972
4eab31dd
PE
8973 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8974 not unsigned long, as we prefer signed integers. All callers changed.
8975 Detect integer overflow in repeat count.
8976 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8977 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8978
171e2a58
PE
8979 * termcap.c: Don't assume sizes fit in int and never overflow.
8980 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8981 (gobble_line): Check for size-calculation overflow.
8982
ad39faca 8983 * minibuf.c (Fread_buffer):
6e5bb2dc 8984 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8985 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8986 Don't assume string length fits in int.
8987
52c61c22 8988 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8989 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8990
b5b8c9e5
PE
8991 * font.c: Don't assume string length fits in int.
8992 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8993 Use ptrdiff_t, not int.
ccd6111c
PE
8994 (font_intern_prop): Don't assume string length fits in int.
8995 Don't assume integer property fits in fixnum.
8996 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8997
882f0d81 8998 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8999 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9000 Reformulate so as not to need the command string.
9001 Invoke gzip -cd rather than gunzip, as it's more portable.
9002 (lock_info_type, lock_file_1, lock_file):
9003 Don't assume pid_t and time_t fit in unsigned long.
9004 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9005 (current_lock_owner): Prefer signed type for sizes.
9006 Use memcpy, not strncpy, where memcpy is what is really wanted.
9007 Don't assume (via atoi) that time_t and pid_t fit in int.
9008 Check for time_t and/or pid_t out of range, e.g., via a network share.
9009 Don't alloca where an auto var works fine.
9010
93f4cf88
PE
9011 * fileio.c: Fix some integer overflow issues.
9012 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9013 Don't assume string length fits in int.
9014 (directory_file_name): Don't assume string length fits in long.
9015 (make_temp_name): Don't assume pid fits in int, or that its print
9016 length is less than 20.
9017
f3e92b69
PE
9018 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9019
1bfdaf10
PE
9020 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9021
35016e9a
PE
9022 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9023
3d1e65a1
PE
9024 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9025 We prefer signed integers, even for size calculations.
9026
0b963a93
PE
9027 * emacs.c: Don't assume string length fits in 'int'.
9028 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9029 (main): Don't invoke strlen when not needed.
9030
573f4b54
PE
9031 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9032 (XD_DEBUG_MESSAGE): Don't waste a byte.
9033
989f33ba
PE
9034 * callproc.c (getenv_internal_1, getenv_internal)
9035 (Fgetenv_internal):
965d34eb
PE
9036 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9037
e4d29b33
PE
9038 * lread.c (invalid_syntax): Omit length argument.
9039 All uses changed. This doesn't fix a bug, but it simplifies the
9040 code away from its former Hollerith-constant appearance, and it's
9041 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9042 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9043
eb49b136
PE
9044 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9045 This didn't break anything, but it didn't help either.
9046 It's confusing to put a bogus integer in a place where the actual
9047 value does not matter.
9f62aeb1 9048 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9049 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9050
15375a22
PE
9051 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9052 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9053 implementation.
b61cc01c
PE
9054 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9055 We prefer signed types, and the value cannot exceed the EMACS_INT
9056 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9057 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9058 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9059 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9060
53b2623d
PE
9061 * indent.c (sane_tab_width): New function.
9062 (current_column, scan_for_column, Findent_to, position_indentation)
9063 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9064 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9065
51cab52b 9066 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9067
f2ed8a70
PE
9068 * lisp.h (lint_assume): New macro.
9069 * composite.c (composition_gstring_put_cache):
9070 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9071
abe80cc6
PE
9072 * editfns.c, insdel.c:
9073 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9074
b02c740e
PE
9075 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9076
ebc96716
PE
9077 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9078
b4e50fa0 9079 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9080 Use much-faster test for byte-length change.
311d5d7c 9081 Don't assume string byte-length fits in 'int'.
a4cf38e4 9082 Check that character arg fits in 'int'.
85461888 9083 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9084
c0c1ee9f
PE
9085 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9086
a498d7f4
PE
9087 * fns.c (concat): Catch string overflow earlier.
9088 Do not rely on integer wraparound.
9089
51cab52b
PE
9090 * dispextern.h (struct it.overlay_strings_charpos)
9091 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9092 * xdisp.c (forward_to_next_line_start)
9093 (back_to_previous_visible_line_start)
9094 (reseat_at_next_visible_line_start, next_element_from_buffer):
9095 Don't arbitrarily truncate the value of 'selective' to int.
9096
76031fad
PE
9097 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9098
5eb55db9
PE
9099 * composite.c: Don't truncate sizes to 'int'.
9100 (composition_gstring_p, composition_reseat_it)
9101 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9102 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9103 not EMACS_UINT, for indexes.
5eb55db9 9104
0703a717
PE
9105 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9106
d6202519
PE
9107 * buffer.c: Include <verify.h>.
9108 (struct sortvec.priority, struct sortstr.priority):
8961a454 9109 Now EMACS_INT, not int.
c20998a7 9110 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9111 (struct sortstr.size, record_overlay_string)
9112 (struct sortstrlist.size, struct sortlist.used):
9113 Don't truncate size to int.
9114 (record_overlay_string): Check for size-calculation overflow.
d6202519 9115 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9116
d5a19415
JM
91172011-06-22 Jim Meyering <meyering@redhat.com>
9118
029529ac 9119 Don't leak an XBM-image-sized buffer
d5a19415
JM
9120 * image.c (xbm_load): Free the image buffer after using it.
9121
a9041e6c
PE
91222011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9123
9124 Port to Sun C.
9125 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9126 that Sun C diagnosed.
9127 * fns.c (secure_hash): Fix pointer signedness issue.
9128 * intervals.c (static_offset_intervals): New function.
9129 (offset_intervals): Use it.
9130
7f3f739f
LL
91312011-06-21 Leo Liu <sdl.web@gmail.com>
9132
9133 * deps.mk (fns.o):
9134 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9135 sha512.h.
9136
9137 * fns.c (secure_hash): Rename from crypto_hash_function and change
9138 the first arg to accept symbols.
5b66d427 9139 (Fsecure_hash): New primitive.
7f3f739f
LL
9140 (syms_of_fns): New symbols.
9141
76147d94
DD
91422011-06-20 Deniz Dogan <deniz@dogan.se>
9143
9144 * process.c (Fset_process_buffer): Clarify return value in
9145 docstring.
9146
7d7d0045
CY
91472011-06-18 Chong Yidong <cyd@stupidchicken.com>
9148
9149 * dispnew.c (add_window_display_history): Use BVAR.
9150
9151 * xdisp.c (debug_method_add): Use BVAR.
9152 (check_window_end, dump_glyph_matrix, dump_glyph)
9153 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9154
9155 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9156 Likewise.
9157
9158 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9159 check till after the cache is created in init_frame_faces.
9160
ff2bc410
SM
91612011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9162
9163 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9164
28177add
PE
91652011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9166
dd3482fe
PE
9167 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9168 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9169 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9170
393d71f3 9171 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9172 * fileio.c (Finsert_file_contents):
9173 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9174 Remove the old (too-loose) buffer overflow checks.
9175 They weren't needed, since make_gap checks for buffer overflow.
9176 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9177 The old code merely checked for Emacs fixnum overflow, and relied
9178 on undefined (wraparound) behavior. The new code avoids undefined
9179 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9180
2e6813b0 9181 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9182 Tune. Don't use wider integers than needed. Don't use alloca.
9183 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9184
599a9e4f
PE
9185 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9186
99561444
PE
9187 * insdel.c, lisp.h (buffer_overflow): New function.
9188 (insert_from_buffer_1, replace_range, replace_range_2):
9189 * insdel.c (make_gap_larger):
9190 * editfns.c (Finsert_char):
9191 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9192
28177add
PE
9193 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9194
e69dafad
PE
91952011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9196
4baa020d 9197 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9198
b1c46f02
PE
9199 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9200 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9201
e69dafad
PE
9202 * fileio.c: Don't assume EMACS_INT fits in off_t.
9203 (emacs_lseek): New static function.
9204 (Finsert_file_contents, Fwrite_region): Use it.
9205 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9206
566684ea
PE
9207 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9208
e6966cd6
PE
9209 * fns.c: Don't overflow int when computing a list length.
9210 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9211 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9212 truncation on 64-bit hosts. Check for QUIT every
9213 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9214 faster and is responsive enough.
9215 (Flength): Report an error instead of overflowing an integer.
9216 (Fsafe_length): Return a float if the value is not representable
9217 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9218 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9219 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9220
dd0b0efb
PE
9221 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9222 (header_size, word_size): New constants.
9223 (allocate_vectorlike): Don't check size overflow here.
9224 (allocate_vector): Check it here instead, since this is the only
9225 caller of allocate_vectorlike that could cause overflow.
9226 Check that the new vector's length is representable as a fixnum.
9227
86fe5cfe
PE
9228 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9229 The previous code was bogus. For example, next_almost_prime (32)
9230 returned 39, which is undesirable as it is a multiple of 3; and
9231 next_almost_prime (24) returned 25, which is a multiple of 5 so
9232 why was the code bothering to check for multiples of 7?
9233
80e88859
PE
9234 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9235
4a2f0ad6
PE
9236 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9237
f66c7cf8
PE
9238 Variadic C functions now count arguments with ptrdiff_t.
9239 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9240 Back then I didn't know that the Emacs coding style prefers signed int.
9241 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9242 were being counted with int, which may truncate counts on 64-bit
9243 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9244 * lisp.h (struct Lisp_Subr.function.aMANY)
9245 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9246 Arg counts are now ptrdiff_t, not size_t.
9247 All variadic functions and their callers changed accordingly.
9248 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9249 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9250 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9251 * callint.c (Fcall_interactively): Check arg count for overflow,
9252 to avoid potential buffer overrun. Use signed char, not 'int',
9253 for 'varies' array, so that we needn't bother to check its size
9254 calculation for overflow.
9255 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9256 * eval.c (apply_lambda):
9257 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9258 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9259 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9260
a1759b76
PE
9261 * callint.c (Fcall_interactively): Don't use index var as event count.
9262
d96be9fc
PE
9263 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9264 * mem-limits.h (SIZE): Remove; no longer used.
9265
a690a978 9266 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9267
578c21e6
PE
9268 Remove unnecessary casts.
9269 * xterm.c (x_term_init):
9270 * xfns.c (x_set_border_pixel):
9271 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9272 These aren't needed now that we assume ANSI C.
9273
96f53c6c
PE
9274 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9275 It's more likely to cause problems (due to unsigned overflow)
9276 than to cure them.
9277
83c77d31
PE
9278 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9279
ee2079f1
PE
9280 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9281
6da65536
PE
9282 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9283
7147c4a4
PE
9284 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9285
193e32d9
PE
9286 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9287
e5533da6
PE
9288 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9289
9910e595
PE
9290 GLYPH_CODE_FACE returns EMACS_INT, not int.
9291 * dispextern.h (merge_faces):
9292 * xfaces.c (merge_faces):
01103c44
PE
9293 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9294 Don't assume EMACS_INT fits in int.
9910e595 9295
2638320e
PE
9296 * character.h (CHAR_VALID_P): Remove unused parameter.
9297 * fontset.c, lisp.h, xdisp.c: All uses changed.
9298
045eb8d9
PE
9299 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9300
c1f134b5
PE
9301 * fns.c (concat): Minor tuning based on overflow analysis.
9302 This doesn't fix any bugs. Use int to hold character, instead
9303 of constantly refetching from Emacs object. Use XFASTINT, not
9304 XINT, for value known to be a character. Don't bother comparing
9305 a single byte to 0400, as it's always less.
9306
395fcb93 9307 * floatfns.c (Fexpt):
327eeec8
PE
9308 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9309
abbd3d23
PE
9310 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9311 for characters.
9312
684a03ef
PE
9313 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9314
0fed43f3
PE
9315 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9316 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9317 incorrectly succeed when S was a string, because 4294967386 was
9318 truncated before it was used.
9319
8fd02eb7
PE
9320 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9321 Otherwise, an out-of-range integer could cause undefined behavior
9322 on a 64-bit host.
9323
f8c86b69
PE
9324 * composite.c: Use int, not EMACS_INT, for characters.
9325 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9326 EMACS_INT, for values that are known to be in character range.
9327 This doesn't fix any bugs but is the usual style inside Emacs and
9328 may generate better code on 32-bit machines.
9329
34206dd2
PE
9330 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9331 This is for reasons similar to the recent CHAR_STRING fix.
9332 * charset.c (Fencode_char): Check that character arg is actually
9333 a character. Pass an int to ENCODE_CHAR.
9334 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9335 wider than 'int', as a compile-time check to prevent future regressions
9336 in this area.
9337
c5958d4c 9338 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9339
9340 Make sure a 64-bit char is never passed to CHAR_STRING.
9341 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9342 by silently ignoring the top 32 bits, allowing some values
9343 that were far too large to be valid characters.
9344 * character.h: Include <verify.h>.
9345 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9346 arguments are no wider than unsigned, as a compile-time check
9347 to prevent future regressions in this area.
9348 * data.c (Faset):
01103c44 9349 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9350 (Fsubst_char_in_region):
9351 * fns.c (concat):
9352 * xdisp.c (decode_mode_spec_coding):
9353 Adjust to CHAR_STRING's new requirement.
9354 * editfns.c (Finsert_char, Fsubst_char_in_region):
9355 * fns.c (concat): Check that character args are actually
9356 characters. Without this test, these functions did the wrong
9357 thing with wildly out-of-range values on 64-bit hosts.
9358
d37ca623
PE
9359 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9360 These casts should not be needed on 32-bit hosts, either.
9361 * keyboard.c (read_char):
9362 * lread.c (Fload): Remove casts to unsigned.
9363
ea204efb
PE
9364 * lisp.h (UNSIGNED_CMP): New macro.
9365 This fixes comparison bugs on 64-bit hosts.
9366 (ASCII_CHAR_P): Use it.
9367 * casefiddle.c (casify_object):
01103c44 9368 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9369 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9370 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9371 * dispextern.h (FACE_FROM_ID):
9372 * keyboard.c (read_char): Use UNSIGNED_CMP.
9373
41cb286c
PE
9374 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9375 not to EMACS_INT, to avoid GCC warning.
9376
4a1b9832
PE
9377 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9378
55daad71
PE
9379 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9380 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9381 isn't needed on 32-bit machines.
8f95c75c 9382
01103c44
PE
9383 * buffer.c (Fgenerate_new_buffer_name):
9384 Use EMACS_INT for count, not int.
0ceccced 9385 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9386
9387 * data.c (Qcompiled_function): Now static.
9388
c6f072e7
PE
9389 * window.c (window_body_lines): Now static.
9390
20ce5912
PE
9391 * image.c (gif_load): Rename local to avoid shadowing.
9392
9c4c5f81
PE
9393 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9394 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9395 * alloc.c (make_save_value): Integer argument is now of type
9396 ptrdiff_t, not int.
9397 (mark_object): Use ptrdiff_t, not int.
9398 * lisp.h (pD): New macro.
9399 * print.c (print_object): Use it.
9400
c0c5c8ae
PE
9401 * alloc.c: Use EMACS_INT, not int, to count objects.
9402 (total_conses, total_markers, total_symbols, total_vector_size)
9403 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9404 (total_free_floats, total_floats, total_free_intervals)
9405 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9406 Now EMACS_INT, not int. All uses changed.
9407 (Fgarbage_collect): Compute overall total using a double, so that
9408 integer overflow is less likely to be a problem. Check for overflow
9409 when converting back to an integer.
5a25e253
PE
9410 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9411 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9412 These were 'int' variables that could overflow on 64-bit hosts;
9413 they were never used, so remove them instead of repairing them.
211a0b2a 9414 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9415 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9416 Previously, this ceilinged at INT_MAX, but that doesn't work on
9417 64-bit machines.
e46bb31a 9418 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9419
c78baabf 9420 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9421 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9422 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9423 when a (possibly-narrower) signed value would do just as well.
9424 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9425
c9d624c6
PE
9426 * alloc.c: Catch some string size overflows that we were missing.
9427 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9428 for convenience in STRING_BYTES_MAX.
9429 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9430 The definition here is exact; the one in lisp.h was approximate.
9431 (allocate_string_data): Check for string overflow. This catches
9432 some instances we weren't catching before. Also, it catches
9433 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9434 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9435 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9436
c9d624c6
PE
9437 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9438 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9439 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9440
353032ce
PE
9441 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9442
2bccce07
PE
9443 * alloc.c (Fmake_string): Check for out-of-range init.
9444
0ac30604
SM
94452011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9446
9447 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9448
c195f2de
JD
94492011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9450
9451 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9452 xg_get_default_scrollbar_width.
9453
9454 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9455 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9456 (style_changed_cb): Call update_theme_scrollbar_width and call
9457 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9458 all frames (Bug#8505).
9459 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9460 Call gtk_window_set_resizable if HAVE_GTK3.
9461 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9462 and height if HAVE_GTK3 (Bug#8505).
9463 (scroll_bar_width_for_theme): New variable.
9464 (update_theme_scrollbar_width): New function.
9465 (xg_get_default_scrollbar_width): Move code to
9466 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9467 (xg_initialize): Call update_theme_scrollbar_width.
9468
9469 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9470
9471 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9472
e10ac9f1
MR
94732011-06-12 Martin Rudalics <rudalics@gmx.at>
9474
9475 * frame.c (make_frame): Call other_buffer_safely instead of
9476 other_buffer.
9477
9478 * window.c (temp_output_buffer_show): Call display_buffer with
9479 second argument Vtemp_buffer_show_specifiers and reset latter
9480 immediately after the call.
9481 (Vtemp_buffer_show_specifiers): New variable.
9482 (auto_window_vscroll_p, next_screen_context_lines)
9483 (Vscroll_preserve_screen_position): Remove leading asterisks from
9484 doc-strings.
9485
2d3c217e 94862011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9487
7b7f97e8 9488 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9489 * buffer.c (Qclone_number): Remove for now, as it's unused.
9490 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9491 (record_buffer): Remove unused local.
9492 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9493 (set_frame_buffer_list): Remove; unused.
9494 * frame.h (other_visible_frames): Remove decl.
9495 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9496 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9497 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9498 if HAVE_GPM.
9499 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9500 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9501 Define only if HAVE_GPM.
9502 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9503 (update_hints_inhibit): Remove; never set. All uses removed.
9504 * widgetprv.h (emacsFrameClassRec): Remove decl.
9505 * window.c (delete_deletable_window): Now returns void, since it
9506 wasn't returning anything.
9507 (compare_window_configurations): Remove unused locals.
9508 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9509 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9510 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9511 the same widths as pointers. This follows up on the 2011-05-06 patch.
9512 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9513 * xterm.h: Likewise.
9514 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9515
1384b89e
JB
95162011-06-12 Juanma Barranquero <lekktu@gmail.com>
9517
9518 * makefile.w32-in: Update dependencies.
9519 (LISP_H): Add lib/intprops.h.
9520
1100a63c
CY
95212011-06-11 Chong Yidong <cyd@stupidchicken.com>
9522
9523 * image.c (gif_load): Add animation frame delay to the metadata.
9524 (syms_of_image): Use DEFSYM. New symbol `delay'.
9525
6198ccd0
MR
95262011-06-11 Martin Rudalics <rudalics@gmx.at>
9527
9528 * window.c (delete_deletable_window): Re-add.
9529 (Fset_window_configuration): Rewrite to handle dead buffers and
9530 consequently deletable windows.
9531 (window_tree, Fwindow_tree): Remove. Supply functionality in
9532 window.el.
9533 (compare_window_configurations): Simplify code.
9534
b6e3633c
AS
95352011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9536
1ab0dee5
AS
9537 * image.c (imagemagick_load_image): Fix type mismatch.
9538 (Fimagemagick_types): Likewise.
9539
b6e3633c
AS
9540 * window.h (replace_buffer_in_windows): Declare.
9541
9397e56f
MR
95422011-06-11 Martin Rudalics <rudalics@gmx.at>
9543
9544 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9545 Qclone_number. Remove external declaration of Qdelete_window.
9546 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9547 code.
640c8776
SM
9548 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9549 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9550 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9551 buffer list implementation.
9552 (other_buffer_safely): New function.
9553 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9554 calls to replace_buffer_in_windows and
9555 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9556 if allowed.
9557 (record_buffer): Inhibit quitting and rewrite using quittable
9558 functions. Run Qbuffer_list_update_hook if allowed.
9559 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9560 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9561 Move switch-to-buffer to window.el.
9397e56f
MR
9562 (bury-buffer): Move to window.el.
9563 (Vbuffer_list_update_hook): New variable.
9564
9565 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9566 section.
9567
9568 * window.h (resize_frame_windows): Move up in code.
9569 (Fwindow_frame): Remove EXFUN.
9570 (replace_buffer_in_all_windows): Remove prototype.
9571 (replace_buffer_in_windows_safely): Add prototype.
9572
9573 * window.c: Declare Qdelete_window static again. Move down
9574 declaration of select_count.
9575 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9576 (Fother_window): Move to window.el.
9577 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9578 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9579 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9580 window.el.
9581 (replace_buffer_in_windows): Implement by calling
9582 Qreplace_buffer_in_windows.
9583 (replace_buffer_in_all_windows): Remove with some functionality
9584 moved into replace_buffer_in_windows_safely.
9585 (replace_buffer_in_windows_safely): New function.
9586 (select_window_norecord, select_frame_norecord): Move in front
9587 of run_window_configuration_change_hook. Remove now obsolete
9588 declarations.
640c8776
SM
9589 (Fset_window_buffer): Rewrite doc-string.
9590 Call Qrecord_window_buffer.
9397e56f
MR
9591 (keys_of_window): Move binding for other-window to window.el.
9592
b50691aa
CY
95932011-06-11 Chong Yidong <cyd@stupidchicken.com>
9594
9595 * dispextern.h (struct image): Replace data member, whose int_val
9596 and ptr_val fields were not used by anything, with a single
9597 lisp_val object.
9598
9599 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9600 (gif_clear_image, gif_load, imagemagick_load_image)
9601 (gs_clear_image, gs_load): Callers changed.
9602
3f754b86
PE
96032011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9604
cca69397
PE
9605 * buffer.h: Include <time.h>, for time_t.
9606 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9607
109e28d0
PE
9608 Fix minor problems found by static checking.
9609
60737f02
PE
9610 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9611
4b66faf3
PE
9612 Make identifiers static if they are not used in other modules.
9613 * data.c (Qcompiled_function, Qframe, Qvector):
9614 * image.c (QimageMagick, Qsvg):
9615 * minibuf.c (Qmetadata):
9616 * window.c (resize_window_check, resize_root_window): Now static.
9617 * window.h (resize_window_check, resize_root_window): Remove decls.
9618
109e28d0
PE
9619 * window.c (window_deletion_count, delete_deletable_window):
9620 Remove; unused.
46a4ce9e
PE
9621 (window_body_lines): Now static.
9622 (Fdelete_other_windows_internal): Mark vars as initialized.
9623 Make sure 'resize_failed' is initialized.
9624 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9625 (resize_window_apply): Remove unused local.
9626 * window.h (delete_deletable_window): Remove decl.
9627
109e28d0 9628 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9629 (imagemagick_load_image): Fix pointer signedness problem by changing
9630 last arg from unsigned char * to char *. All uses changed.
9631 Also, fix a local for similar reasons.
9632 Remove unused locals. Remove locals to avoid shadowing.
9633 (fn_rsvg_handle_free): Remove; unused.
9634 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9635 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9636
3f754b86
PE
9637 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9638
2547adb1
CY
96392011-06-10 Chong Yidong <cyd@stupidchicken.com>
9640
9641 * image.c (gif_load): Fix omitted cast error introduced by
9642 2011-06-06 change.
9643
2c8e37d4
MR
96442011-06-10 Martin Rudalics <rudalics@gmx.at>
9645
9646 * window.h (resize_proportionally, orig_total_lines)
9647 (orig_top_line): Remove from window structure.
9648 (set_window_height, set_window_width, change_window_heights)
9649 (Fdelete_window): Remove prototypes.
9650 (resize_frame_windows): Remove duplicate declaration.
9651
440a42e3
EZ
96522011-06-10 Eli Zaretskii <eliz@gnu.org>
9653
9654 * window.h (resize_frame_windows, resize_window_check)
9655 (delete_deletable_window, resize_root_window)
9656 (resize_frame_windows): Declare prototypes.
9657
9658 * window.c (resize_window_apply): Make definition be "static" to
9659 match the prototype.
9660
562dd5e9
MR
96612011-06-10 Martin Rudalics <rudalics@gmx.at>
9662
9663 * window.c: Remove declarations of Qwindow_size_fixed,
9664 window_min_size_1, window_min_size_2, window_min_size,
9665 size_window, window_fixed_size_p, enlarge_window, delete_window.
9666 Remove static from declaration of Qdelete_window, it's
9667 temporarily needed by Fbury_buffer.
9668 (replace_window): Don't assign orig_top_line and
9669 orig_total_lines.
9670 (Fdelete_window, delete_window): Remove. Window deletion is
9671 handled by window.el.
640c8776
SM
9672 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9673 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9674 (Fdelete_other_windows): Remove. Deleting other windows is
9675 handled by window.el.
9676 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9677 handled in window.el.
9678 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9679 Window minimum sizes are handled in window.el.
9680 (shrink_windows, size_window, set_window_height)
9681 (set_window_width, change_window_heights, window_height)
9682 (window_width, CURBEG, CURSIZE, enlarge_window)
9683 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9684 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9685 handled in window.el.
9686 (make_dummy_parent): Rename to make_parent_window and give it a
9687 second argument horflag.
9688 (make_window): Don't set resize_proportionally any more.
9689 (Fsplit_window): Remove. Windows are split in window.el.
9690 (save_restore_action, save_restore_orig_size)
9691 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9692 Resize mini windows in window.el.
9693 (grow_mini_window, shrink_mini_window): Implement by calling
9694 Qresize_root_window_vertically, resize_window_check and
9695 resize_window_apply.
640c8776
SM
9696 (saved_window, Fset_window_configuration, save_window_save):
9697 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9698 resize_proportionally.
9699 (window_min_height, window_min_width): Move to window.el.
9700 (keys_of_window): Move bindings for delete-other-windows,
9701 split-window, delete-window and enlarge-window to window.el.
9702
9703 * buffer.c: Temporarily extern Qdelete_window.
9704 (Fbury_buffer): Temporarily call Qdelete_window instead of
9705 Fdelete_window (Fbury_buffer will move to window.el soon).
9706
9707 * frame.c (set_menu_bar_lines_1): Remove code handling
9708 orig_top_line and orig_total_lines.
9709
9710 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9711 set_window_height but set heights directly.
9712 (change_frame_size_1): Use resize_frame_windows.
9713
9714 * xdisp.c (init_xdisp): Don't use set_window_height but set
9715 heights directly.
9716
640c8776
SM
9717 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9718 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9719 run_window_configuration_change_hook.
9720
9721 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9722 instead of change_window_heights and run
9723 run_window_configuration_change_hook.
9724
1a13852e
MR
97252011-06-09 Martin Rudalics <rudalics@gmx.at>
9726
9727 * window.c (replace_window): Rename second argument REPLACEMENT to
9728 NEW. New third argument SETFLAG. Rewrite.
9729 (delete_window, make_dummy_parent): Call replace_window with
9730 third argument 1.
9731 (window_list_1): Move down in code.
9732 (run_window_configuration_change_hook): Move set_buffer part
9733 before select_frame_norecord part in order to unwind correctly.
9734 Rename count1 to count.
9735 (recombine_windows, delete_deletable_window, resize_root_window)
9736 (Fdelete_other_windows_internal)
9737 (Frun_window_configuration_change_hook, make_parent_window)
9738 (resize_window_check, resize_window_apply, Fresize_window_apply)
9739 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9740 (Fdelete_window_internal, Fresize_mini_window_internal):
9741 New functions.
1a13852e
MR
9742 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9743
f3d1777e
MR
97442011-06-08 Martin Rudalics <rudalics@gmx.at>
9745
496e208e
MR
9746 * window.h (window): Add some new members to window structure -
9747 normal_lines, normal_cols, new_total, new_normal, clone_number,
9748 splits, nest, prev_buffers, next_buffers.
9749 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9750 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9751
f3d1777e
MR
9752 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9753 Remove.
496e208e
MR
9754 (make_dummy_parent): Set new members of windows structure.
9755 (make_window): Move down in code. Handle new members of window
9756 structure.
9757 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9758 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9759 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9760 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9761 (Fset_window_next_buffers, Fset_window_clone_number):
9762 New functions.
496e208e
MR
9763 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9764 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9765 Doc-string fixes.
9766 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9767 Argument WINDOW can be now internal window too.
9768 (Fwindow_use_time): Move up in code.
9769 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9770 Rewrite doc-string.
9771 (Fset_window_configuration, saved_window)
9772 (Fcurrent_window_configuration, save_window_save): Handle new
9773 members of window structure.
b9e809c2
MR
9774 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9775 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9776 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9777 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9778 Qget_mru_window, Qresize_root_window,
9779 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9780 Qauto_buffer_name; staticpro them.
f3d1777e 9781
abde8f8c
MR
97822011-06-07 Martin Rudalics <rudalics@gmx.at>
9783
9784 * window.c (Fwindow_total_size, Fwindow_left_column)
9785 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9786 (Fwindow_list_1): New functions.
9787 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9788 (Fwindow_width, Fscroll_left, Fscroll_right):
9789 Use window_body_cols instead of window_box_text_cols.
9790 (delete_window, Fset_window_configuration):
9791 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9792 (delete_all_subwindows): Take a window as argument and not a
9793 structure. Rewrite.
190b47e6
MR
9794 (window_loop): Remove handling of GET_LRU_WINDOW and
9795 GET_LARGEST_WINDOW.
9796 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9797
9798 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9799 window_box_text_cols. delete_all_subwindows now takes a
9800 Lisp_Object as argument.
abde8f8c 9801
640c8776
SM
9802 * indent.c (compute_motion, Fcompute_motion):
9803 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9804
fa8a67e6
MR
9805 * frame.c (delete_frame): Call delete_all_subwindows with root
9806 window as argument.
9807
a54e3482
DC
98082011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9809
9810 * fns.c (Fputhash): Document return value.
9811
60002bf5
CY
98122011-06-06 Chong Yidong <cyd@stupidchicken.com>
9813
9814 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9815
0c671da6 98162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9817
b862a52a 9818 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9819
be44ca6c
PE
9820 Check for overflow when converting integer to cons and back.
9821 * charset.c (Fdefine_charset_internal, Fdecode_char):
9822 Use cons_to_unsigned to catch overflow.
9823 (Fencode_char): Use INTEGER_TO_CONS.
9824 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9825 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9826 * data.c (long_to_cons, cons_to_long): Remove.
9827 (cons_to_unsigned, cons_to_signed): New functions.
9828 These signal an error for invalid or out-of-range values.
9829 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9830 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9831 * font.c (Ffont_variation_glyphs):
9832 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9833 * lisp.h: Include <intprops.h>.
9834 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9835 (cons_to_signed, cons_to_unsigned): New decls.
9836 (long_to_cons, cons_to_long): Remove decls.
9837 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9838 (Fprimitive_undo): Use CONS_TO_INTEGER.
9839 * xfns.c (Fx_window_property): Likewise.
9840 * xselect.c: Include <limits.h>.
9841 (x_own_selection, selection_data_to_lisp_data):
9842 Use INTEGER_TO_CONS.
9843 (x_handle_selection_request, x_handle_selection_clear)
9844 (x_get_foreign_selection, Fx_disown_selection_internal)
9845 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9846 (lisp_data_to_selection_data): Use cons_to_unsigned.
9847 (x_fill_property_data): Use cons_to_signed.
9848 Report values out of range.
9849
d1f3d2af
PE
9850 Check for buffer and string overflow more precisely.
9851 * buffer.h (BUF_BYTES_MAX): New macro.
9852 * lisp.h (STRING_BYTES_MAX): New macro.
9853 * alloc.c (Fmake_string):
9854 * character.c (string_escape_byte8):
9855 * coding.c (coding_alloc_by_realloc):
9856 * doprnt.c (doprnt):
9857 * editfns.c (Fformat):
9858 * eval.c (verror):
9859 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9860 since they may not be the same number.
9861 * editfns.c (Finsert_char):
9862 * fileio.c (Finsert_file_contents):
9863 Likewise for BUF_BYTES_MAX.
9864
dd52fcea
PE
9865 * image.c: Use ptrdiff_t, not int, for sizes.
9866 (slurp_file): Switch from int to ptrdiff_t.
9867 All uses changed.
9868 (slurp_file): Check that file size fits in both size_t (for
9869 malloc) and ptrdiff_t (for sanity and safety).
9870
7f9bbdbb
PE
9871 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9872 if b->modtime has its maximal value.
9873
dfe18f82
PE
9874 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9875
84acfcf0
PE
9876 Don't assume time_t can fit into int.
9877 * buffer.h (struct buffer.modtime): Now time_t, not int.
9878 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9879 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9880
ccd9a01a
PE
9881 Minor fixes for signed vs unsigned integers.
9882 * character.h (MAYBE_UNIFY_CHAR):
9883 * charset.c (maybe_unify_char):
9884 * keyboard.c (read_char, reorder_modifiers):
9885 XINT -> XFASTINT, since the integer must be nonnegative.
9886 * ftfont.c (ftfont_spec_pattern):
9887 * keymap.c (access_keymap, silly_event_symbol_error):
9888 XUINT -> XFASTINT, since the integer must be nonnegative.
9889 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9890 since it makes no difference and we prefer signed.
9891 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9892 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9893 nonnegative.
9894
d6d100dd
SM
98952011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9896
9897 * window.h (Fwindow_frame): Declare.
9898
2b6148e4
PE
98992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9900
9901 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9902 (SPARE_MEMORY): Always define.
9903 (LARGE_REQUEST): Remove.
9904 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9905
f230ecc9
MR
99062011-06-06 Martin Rudalics <rudalics@gmx.at>
9907
727e958e
MR
9908 * lisp.h: Move EXFUNS for Fframe_root_window,
9909 Fframe_first_window and Fset_frame_selected_window to window.h.
9910
9911 * window.h: Move EXFUNS for Fframe_root_window,
9912 Fframe_first_window and Fset_frame_selected_window here from
9913 lisp.h.
9914
9915 * frame.c (Fwindow_frame, Fframe_first_window)
9916 (Fframe_root_window, Fframe_selected_window)
9917 (Fset_frame_selected_window): Move to window.c.
9918 (Factive_minibuffer_window): Move to minibuf.c.
9919 (Fother_visible_frames_p): New function.
9920
9921 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9922
f230ecc9
MR
9923 * window.c (decode_window, decode_any_window): Move up in code.
9924 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9925 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9926 (Fwindow_buffer): Move up and rewrite doc-string.
9927 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9928 (Fwindow_prev): New functions.
727e958e
MR
9929 (Fwindow_frame): Move here from frame.c. Accept any window as
9930 argument.
9931 (Fframe_root_window, Fframe_first_window)
9932 (Fframe_selected_window): Move here from frame.c. Accept frame
9933 or arbitrary window as argument. Update doc-strings.
9934 (Fminibuffer_window): Move up in code.
9935 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9936 (Fset_frame_selected_window): Move here from frame.c.
9937 Marginal rewrite.
727e958e
MR
9938 (Fselected_window, select_window, Fselect_window): Move up in
9939 code. Minor doc-string fixes.
f230ecc9 9940
4d09bcf6
PE
99412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9942
9943 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9944 Do not assume that spare memory exists; that assumption is valid
9945 only if SYSTEM_MALLOC.
9946 (LARGE_REQUEST): New macro, so that the issue of large requests
9947 is separated from the issue of spare memory.
9948
810928a2
AS
99492011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9950
172418ad
AS
9951 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9952 format. (Bug#8806)
9953
43f862f7
AS
9954 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9955
810928a2
AS
9956 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9957 before statements.
9958
a059fe24
JD
99592011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9960
9961 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9962
9963 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9964
9965 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9966 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9967
989bf368
JB
99682011-06-05 Juanma Barranquero <lekktu@gmail.com>
9969
9970 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9971
4b80f674
CY
99722011-06-04 Chong Yidong <cyd@stupidchicken.com>
9973
9974 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9975 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9976 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9977 New error handlers.
4b80f674
CY
9978 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9979 Obey Vx_select_enable_clipboard_manager. Catch errors in
9980 x_clipboard_manager_save (Bug#8779).
9981 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9982 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9983
99a33b77 99842011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9985
9986 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9987
99a33b77 99882011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9989
9990 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9991 in the current matrix if keep_current_p is non-zero.
9992
8264569d
EZ
99932011-06-04 Eli Zaretskii <eliz@gnu.org>
9994
9995 * bidi.c (bidi_level_of_next_char): Fix last change.
9996
57f97249
EZ
99972011-06-03 Eli Zaretskii <eliz@gnu.org>
9998
fec2107c 9999 Support bidi reordering of text covered by display properties.
57f97249 10000
fec2107c
EZ
10001 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10002 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10003 (bidi_cache_search, bidi_cache_iterator_state)
10004 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10005 (bidi_level_of_next_char, bidi_move_to_visually_next):
10006 Support character positions inside a run of characters covered by a
fec2107c
EZ
10007 display string.
10008 (bidi_paragraph_init, bidi_resolve_explicit_1)
10009 (bidi_level_of_next_char): Call bidi_fetch_char and
10010 bidi_fetch_char_advance instead of FETCH_CHAR and
10011 FETCH_CHAR_ADVANCE.
10012 (bidi_init_it): Initialize new members.
10013 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10014 definitions.
10015 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10016 instead of using explicit *_CHAR codes.
d6d100dd
SM
10017 (bidi_resolve_explicit, bidi_resolve_weak):
10018 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10019 bidirectional text is supported only in multibyte buffers.
10020 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10021 it to initialize the frame_window_p member of struct bidi_it.
10022 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10023 (bidi_resolve_explicit, bidi_resolve_weak)
10024 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10025 bidi_it->nchars is non-positive.
10026 (bidi_level_of_next_char): Don't try to lookup the cache for the
10027 next/previous character if nothing is cached there yet, or if we
10028 were just reseat()'ed to a new position.
c40e2fb2 10029
0e14fe90
EZ
10030 * xdisp.c (set_cursor_from_row): Set start and stop points
10031 according to the row's direction when priming the loop that looks
10032 for the glyph on which to display cursor.
10033 (single_display_spec_intangible_p): Function deleted.
10034 (display_prop_intangible_p): Reimplement to call
10035 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10036 Accept 3 additional arguments needed by handle_display_spec.
10037 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10038 values: lists, `(when COND...)' forms, etc.
10039 (single_display_spec_string_p): Support property values that are
10040 lists with the argument STRING its top-level element.
10041 (display_prop_string_p): Fix the condition for processing a
10042 property that is a list to be consistent with handle_display_spec.
fec2107c 10043 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10044 last portion of handle_display_prop.
10045 (compute_display_string_pos): Accept additional argument
10046 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10047 value of a `display' property is a "replacing spec".
10048 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10049 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10050 the display property, but just return a value indicating whether
10051 the display property will replace the characters it covers.
10052 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10053 frame_window_p members of struct bidi_it.
d6d100dd
SM
10054 (compute_display_string_pos, compute_display_string_end):
10055 New functions.
fec2107c
EZ
10056 (push_it): Accept second argument POSITION, where pop_it should
10057 jump to continue iteration.
10058 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10059
fec2107c
EZ
10060 * keyboard.c (adjust_point_for_property): Adjust the call to
10061 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10062
10063 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10064 (bidi_init_it): Update prototypes.
10065 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10066 (compute_display_string_pos, compute_display_string_end):
10067 Declare prototypes.
fec2107c
EZ
10068 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10069 EMACS_INT.
fc6f18ce 10070
40087514 100712011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10072
57f53182
PE
10073 Malloc failure behavior now depends on size of allocation.
10074 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10075 * lisp.h: Change signatures accordingly.
10076 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10077 All callers changed. (Bug#8762)
10078
10079 * gnutls.c: Use Emacs's memory allocators.
10080 Without this change, the gnutls library would invoke malloc etc.
10081 directly, which causes problems on non-SYNC_INPUT hosts, and which
10082 runs afoul of improving memory_full behavior. (Bug#8761)
10083 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10084 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10085 xfree instead of the default malloc, realloc, free.
10086 (Fgnutls_boot): No need to check for memory allocation failure,
10087 since xmalloc does that for us.
10088
ac32cd99 10089 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10090 * category.c (hash_get_category_set):
10091 * ccl.c (ccl_driver):
10092 * charset.c (Fdefine_charset_internal):
10093 * charset.h (struct charset.hash_index):
10094 * composite.c (get_composition_id, gstring_lookup_cache)
10095 (composition_gstring_put_cache):
10096 * composite.h (struct composition.hash_index):
10097 * dispextern.h (struct image.hash):
10098 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10099 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10100 (hashfn_equal, hashfn_user_defined, make_hash_table)
10101 (maybe_resize_hash_table, hash_lookup, hash_put)
10102 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10103 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10104 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10105 * image.c (make_image, search_image_cache, lookup_image)
10106 (xpm_put_color_table_h):
10107 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10108 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10109 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10110 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10111 * alloc.c (allocate_vectorlike):
10112 Check for overflow in vector size calculations.
10113 * ccl.c (ccl_driver):
10114 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10115 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10116 need to be updated by these changes.
40087514
PE
10117 * fns.c (make_hash_table, maybe_resize_hash_table):
10118 Check for integer overflow with large hash tables.
0de4bb68
PE
10119 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10120 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10121 (SXHASH_REDUCE): New macro.
10122 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10123 Use it instead of discarding useful hash info with large hash values.
10124 (sxhash_float): New function.
10125 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10126 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10127 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10128 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10129 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10130 Adjust signatures to match updated version of code.
10131 (consing_since_gc): Now EMACS_INT, since a single hash table can
10132 use more than INT_MAX bytes.
10133
698d32e2
DN
101342011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10135
10136 Make it possible to build with GCC-4.6+ -O2 -flto.
10137
10138 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10139
fd6fa53f
SM
101402011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10141
10142 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10143 Call minibuffer-inactive-mode.
10144
864db017
JB
101452011-05-31 Juanma Barranquero <lekktu@gmail.com>
10146
10147 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10148 Update dependencies.
10149
2ad0baf4
DN
101502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10151
10152 * data.c (init_data): Remove code for UTS, this system is not
10153 supported anymore.
10154
4fcc2638
DN
101552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10156
10157 Don't force ./temacs to start in terminal mode.
10158
10159 * frame.c (make_initial_frame): Initialize faces in all cases, not
10160 only when CANNOT_DUMP is defined.
10161 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10162
c56e0fd5
DN
101632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10164
10165 * dispnew.c (add_window_display_history): Use const for the string
10166 pointer. Remove declaration, not needed.
10167
333d54da 101682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10169
55d4c1b2 10170 Use 'inline', not 'INLINE'.
333d54da 10171 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10172 * alloc.c, fontset.c (INLINE): Remove.
10173 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10174 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10175 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10176 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10177 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10178
738db178
DN
101792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10180
10181 Make it possible to run ./temacs.
10182
10183 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10184 syms_of_callproc does the same thing. Remove test for
10185 "initialized", do it in the caller.
10186 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10187
620c53a6
SM
101882011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10189
10190 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10191 (read_minibuf): Use get_minibuffer.
10192 (syms_of_minibuf): Use DEFSYM.
10193 (Qmetadata): New var.
10194 * data.c (Qbuffer): Don't make it static.
10195 (syms_of_data): Use DEFSYM.
10196
e003a292
PE
101972011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10198
10199 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10200 (CCL_CODE_MIN): New macro.
10201
ed008a6d
PE
102022011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10203
3687c2ef
PE
10204 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10205
ed008a6d
PE
10206 * eval.c (Qdebug): Now static.
10207 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10208 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10209 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10210
d66c4c7c
CY
102112011-05-29 Chong Yidong <cyd@stupidchicken.com>
10212
10213 * image.c: Various fixes to ImageMagick code comments.
10214 (Fimagemagick_types): Doc fix.
10215
5fbc2025
PE
102162011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10217
0196f88a
PE
10218 Minor fixes prompted by GCC 4.6.0 warnings.
10219
10220 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10221
5fbc2025
PE
10222 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10223 (x_clipboard_manager_save_all): Move extern decl to ...
10224 * xterm.h: ... here, so that it can be checked for consistency.
10225
1dd3c2d9
CY
102262011-05-29 Chong Yidong <cyd@stupidchicken.com>
10227
10228 * xselect.c (x_clipboard_manager_save_frame)
10229 (x_clipboard_manager_save_all): New functions.
10230 (Fx_clipboard_manager_save): Lisp function deleted.
10231
10232 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10233 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10234
10235 * xterm.h: Update prototype.
10236
5ba6571d
WX
102372011-05-28 William Xu <william.xwl@gmail.com>
10238
10239 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10240 exiting (Bug#8239).
10241
3eaff834
JM
102422011-05-28 Jim Meyering <meyering@redhat.com>
10243
e1900994 10244 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10245 * fns.c (to_uchar): Define.
10246 (crypto_hash_function): Use it to convert some newly-signed
10247 variables to unsigned, to avoid sign-extension bugs. For example,
10248 without this change, (md5 "truc") would evaluate to
10249 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10250 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10251 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10252
0f6990a7
PE
102532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10254
10255 Integer overflow fixes.
c8a9ca5a 10256
08686060
PE
10257 * dbusbind.c: Serial number integer overflow fixes.
10258 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10259 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10260 to hold a serial number that is too large for a fixnum.
10261 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10262 Check for serial numbers out of range. Decode any serial number
59568bf0 10263 that was so large that it became a float. (Bug#8722)
08686060 10264
2d1fc3c7
PE
10265 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10266 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10267 Use XFASTINT rather than XUINT when numbers are nonnegative.
10268 (xd_append_arg, Fdbus_method_return_internal):
10269 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10270 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10271 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10272 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10273 (Bug#8722)
2d1fc3c7 10274
c8a9ca5a
PE
10275 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10276
519e1d69
PE
10277 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10278
6df6ae42 10279 ccl: Add integer overflow checks.
30569699
PE
10280 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10281 (IN_INT_RANGE): New macros.
10282 (ccl_driver): Use them to check for integer overflow when
10283 decoding a CCL program. Many of the new checks are whether XINT (x)
10284 fits in int; it doesn't always, on 64-bit hosts. The new version
10285 doesn't catch all possible integer overflows, but it's an
847044ea 10286 improvement. (Bug#8719)
30569699 10287
c11285dc
PE
10288 * alloc.c (make_event_array): Use XINT, not XUINT.
10289 There's no need for unsigned here.
10290
fdccd48e
PE
10291 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10292 This follows up to the 2011-05-06 change that substituted uintptr_t
10293 for EMACS_INT. This case wasn't caught back then.
10294
37910ab2
PE
10295 Rework Fformat to avoid integer overflow issues.
10296 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10297 now (part of C89). Include <verify.h>.
10298 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10299 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10300 (Fformat): Avoid the prepass trying to compute sizes; it was only
10301 approximate and thus did not catch overflow reliably. Instead, walk
10302 through the format just once, formatting and computing sizes as we go,
10303 checking for integer overflow at every step, and allocating a larger
10304 buffer as needed. Keep track separately whether the format is
10305 multibyte. Keep only the most-recently calculated precision, rather
10306 than them all. Record whether each argument has been converted to
10307 string. Use EMACS_INT, not int, for byte and char and arg counts.
10308 Support field widths and precisions larger than INT_MAX. Avoid
10309 sprintf's undefined behavior with conversion specifications such as %#d
10310 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10311 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10312 formatting out-of-range floating point numbers with int
9173deec 10313 formats. (Bug#8668)
37910ab2 10314
2e6578fb
PE
10315 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10316
0ae6bdee
PE
10317 * data.c: Avoid integer truncation in expressions involving floats.
10318 * data.c: Include <intprops.h>.
10319 (arith_driver): When there's an integer overflow in an expression
10320 involving floating point, convert the integers to floating point
10321 so that the resulting value does not suffer from catastrophic
10322 integer truncation. For example, on a 64-bit host (* 4
10323 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10324 Do not rely on undefined behavior after integer overflow.
10325
de883a70
PE
10326 merge count_size_as_multibyte, parse_str_to_multibyte
10327 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10328 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10329 Check for integer overflow.
10330 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10331 since it's now a duplicate of the other. This is more of
10332 a character than a buffer op, so better that it's in character.c.
10333 * fns.c, print.c: Adjust to above changes.
10334
2ff916cb
PE
103352011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10336
10337 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10338
f1b54466
PE
103392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10340
fb1ac845
PE
10341 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10342 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10343 (x_clipboard_manager_save): Now static.
10344 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10345
f1b54466
PE
10346 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10347 (crypto_hash_function): Now static.
10348 Fix pointer signedness problems. Avoid unnecessary initializations.
10349
a9f737ee
CY
103502011-05-27 Chong Yidong <cyd@stupidchicken.com>
10351
10352 * termhooks.h (Vselection_alist): Make it terminal-local.
10353
10354 * terminal.c (create_terminal): Initialize it.
10355
10356 * xselect.c: Support for clipboard managers.
10357 (Vselection_alist): Move to termhooks.h as terminal-local var.
10358 (LOCAL_SELECTION): New macro.
10359 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10360 (symbol_to_x_atom): Remove gratuitous arg.
10361 (x_handle_selection_request, lisp_data_to_selection_data)
10362 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10363 (x_own_selection, x_get_local_selection, x_convert_selection):
10364 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10365 (some_frame_on_display): Delete unused function.
10366 (Fx_own_selection_internal, Fx_get_selection_internal)
10367 (Fx_disown_selection_internal, Fx_selection_owner_p)
10368 (Fx_selection_exists_p): New optional frame arg.
10369 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10370 (x_handle_selection_clear): Don't treat other terminals with the
10371 same keyboard specially. Use the terminal-local Vselection_alist.
10372 (x_clear_frame_selections): Use Frun_hook_with_args.
10373
10374 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10375
10376 * xterm.h: Add support for those atoms.
10377
e067f0c1
CY
103782011-05-26 Chong Yidong <cyd@stupidchicken.com>
10379
10380 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10381 (converted_selections, conversion_fail_tag): New global variables.
10382 (x_selection_request_lisp_error): Free the above.
10383 (x_get_local_selection): Remove unnecessary code.
10384 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10385 of converted selections stored in converted_selections.
10386 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10387 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10388 (x_convert_selection): New function.
10389 (x_handle_selection_event): Simplify.
10390 (x_get_foreign_selection): Don't ignore incoming requests while
10391 waiting for an answer; this will fail when we implement
10392 SAVE_TARGETS, and seems unnecessary anyway.
10393 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10394 (Vx_sent_selection_functions): Doc fix.
10395
0f4aebc0
LL
103962011-05-26 Leo Liu <sdl.web@gmail.com>
10397
10398 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10399
e61124cd
YM
104002011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10401
10402 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10403
10404 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10405 for fringe update if it has periodic bitmap.
ac389d0c 10406 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10407 and fringe_bitmap_periodic_p.
10408
10409 * fringe.c (get_fringe_bitmap_data): New function.
10410 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10411 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10412 row. Mark glyph row for fringe update if periodicity changed.
10413
10414 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10415 for fringe update unless it has periodic bitmap.
10416
f16d9837
KH
104172011-05-25 Kenichi Handa <handa@m17n.org>
10418
10419 * xdisp.c (get_next_display_element): Set correct it->face_id for
10420 a static composition.
10421
e1b90ef6
LL
104222011-05-24 Leo Liu <sdl.web@gmail.com>
10423
10424 * deps.mk (fns.o):
10425 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10426
10427 * fns.c (crypto_hash_function, Fsha1): New function.
10428 (Fmd5): Use crypto_hash_function.
10429 (syms_of_fns): Add Ssha1.
10430
7400048f
PE
104312011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10432
10433 * gnutls.c: Remove unused macros.
10434 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10435 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10436 Remove macros that are defined and never used.
10437 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10438
abb71cf4
CY
104392011-05-22 Chong Yidong <cyd@stupidchicken.com>
10440
10441 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10442 (Fx_get_selection_internal): Minor cleanup.
10443 (Fx_own_selection_internal): Rename arguments for consistency with
10444 select.el.
10445
6307db39
PE
104462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10447
10448 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10449
f3d4e0a4
CY
104502011-05-22 Chong Yidong <cyd@stupidchicken.com>
10451
10452 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10453
4d8ade89
YM
104542011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10455
10456 * dispnew.c (scrolling_window): Don't exclude the case that the
10457 last enabled row in the desired matrix touches the bottom boundary.
10458
32078c8d
GM
104592011-05-21 Glenn Morris <rgm@gnu.org>
10460
10461 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10462 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10463 and add some more files.
32078c8d 10464
7285dc67
EZ
104652011-05-20 Eli Zaretskii <eliz@gnu.org>
10466
10467 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10468 report_file_error introduced by the change from 2011-05-07.
10469
89d1bd22
PE
104702011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10471
10472 * systime.h (Time): Define only if emacs is defined.
10473 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10474 where the include path doesn't have X11/X.h by default. See
10475 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10476
cd394be1 104772011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10478
10479 * composite.c (find_automatic_composition): Fix previous change.
10480
b9704ad9
GM
104812011-05-20 Glenn Morris <rgm@gnu.org>
10482
10483 * lisp.mk: New file, split from Makefile.in.
10484 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10485 (shortlisp): Remove.
10486 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10487
4a720484
GM
104882011-05-19 Glenn Morris <rgm@gnu.org>
10489
10490 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10491 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10492 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10493 (lisp): Set the order to that of loadup.el.
10494 (shortlisp): Make it a copy of $lisp.
10495 (SOME_MACHINE_LISP): Remove.
10496 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10497 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10498
a28d4396
KH
104992011-05-18 Kenichi Handa <handa@m17n.org>
10500
10501 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10502 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10503 (find_automatic_composition): Mostly rewrite for efficiency.
10504
a2b1fa8e
JB
105052011-05-18 Juanma Barranquero <lekktu@gmail.com>
10506
10507 * makefile.w32-in: Update dependencies.
10508
8e1f5610
CS
105092011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10510
10511 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10512 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10513
7025ee00 105142011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10515
cdfa6eab
PE
10516 Fix some integer overflow issues, such as string length overflow.
10517
06d6db33
PE
10518 * insdel.c (count_size_as_multibyte): Check for string overflow.
10519
2b4560a8
PE
10520 * character.c (lisp_string_width): Check for string overflow.
10521 Use EMACS_INT, not int, for string indexes and lengths; in
10522 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10523 the resulting string length overflows an EMACS_INT; instead,
10524 report a string overflow if no precision given. When checking for
10525 precision exhaustion, use a check that cannot possibly have
10526 integer overflow. (Bug#8675)
10527 * character.h (lisp_string_width): Adjust to new signature.
10528
cb93f9be
PE
10529 * alloc.c (string_overflow): New function.
10530 (Fmake_string): Use it. This doesn't change behavior, but saves
10531 a few bytes and will simplify future changes.
10532 * character.c (string_escape_byte8): Likewise.
10533 * lisp.h (string_overflow): New decl.
10534
1a1f3366
PE
10535 Fixups, following up to the user-interface timestamp change.
10536 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10537 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10538 * msdos.c (mouse_get_pos): Likewise.
10539 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10540 * w32gui.h (Time): Define by including "systime.h" rather than by
10541 declaring it ourselves. (Bug#8664)
10542
d4e3e4d3
PE
10543 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10544 * image.c (clear_image_cache): Likewise.
10545
f6a24d19
PE
10546 * term.c (term_mouse_position): Don't assume time_t wraparound.
10547
08dc5ae6
PE
10548 Be more systematic about user-interface timestamps.
10549 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10550 and sometimes 'EMACS_UINT', to represent these timestamps.
10551 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10552 This makes the code easier to follow, and makes it easier to catch
10553 integer overflow bugs such as Bug#8664.
10554 * frame.c (Fmouse_position, Fmouse_pixel_position):
10555 Use Time, not unsigned long, for user-interface timestamps.
10556 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10557 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10558 * keyboard.h (last_event_timestamp): Likewise.
10559 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10560 * menu.h (xmenu_show): Likewise.
10561 * term.c (term_mouse_position): Likewise.
10562 * termhooks.h (struct input_event.timestamp): Likewise.
10563 (struct terminal.mouse_position_hook): Likewise.
10564 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10565 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10566 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10567 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10568 what it was before.
10569 * menu.h, termhooks.h: Include "systime.h", for Time.
10570
8e55734a
PE
10571 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10572 Don't assume that the difference between two unsigned long values
10573 can fit into an integer. At this point, we know button_down_time
10574 <= event->timestamp, so the difference must be nonnegative, so
10575 there's no need to cast the result if double-click-time is
10576 nonnegative, as it should be; check that it's nonnegative, just in
10577 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10578 apart (about 25 days). (Bug#8664)
8e55734a 10579
841f1b75 10580 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10581 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10582
3e26f69c
PE
10583 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10584 that always fit in int. Use a sentinel instead of a counter, to
10585 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10586 * frame.h (struct frame): Use int for menu_bar_items_used
10587 instead of EMACS_INT, since it always fits in int.
3e26f69c 10588
5cc152c0
PE
10589 * menu.c (grow_menu_items): Check for int overflow.
10590
d89eb65e
PE
10591 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10592
5235bd3e
PE
10593 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10594 Before, the code was not consistent. These values cannot exceed
10595 2**31 - 1 so there's no need to make them unsigned.
10596 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10597 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10598 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10599 as modifiers.
10600 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10601
bc827e23
PE
10602 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10603 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10604 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10605 presumably because the widths might not match.
10606
78eb494e
PE
10607 * window.c (size_window): Avoid needless test at loop start.
10608
04f2d78b
CB
106092011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10610
10611 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10612
d2fc7e3d 106132011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10614
10615 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10616
d2fc7e3d 106172011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10618
10619 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10620 `width' to `bar_area_x' and `bar_area_width', respectively.
10621 (x_scroll_run): Take account of fringe background extension.
10622
04f2d78b
CB
10623 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10624 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10625 `bar_area_width', respectively.
10626 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10627 background extension.
10628
79b70037
GM
106292011-05-10 Jim Meyering <meyering@redhat.com>
10630
10631 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10632
2f142cc5
JB
106332011-05-10 Juanma Barranquero <lekktu@gmail.com>
10634
10635 * image.c (Finit_image_library): Return t for built-in image types,
10636 like pbm and xbm. (Bug#8640)
10637
57679c86
AS
106382011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10639
10640 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10641
888c9e86
EZ
106422011-05-07 Eli Zaretskii <eliz@gnu.org>
10643
b0512a1d
EZ
10644 * w32console.c (Fset_screen_color): Doc fix.
10645 (Fget_screen_color): New function.
10646 (syms_of_ntterm): Defsubr it.
10647
7285dc67
EZ
10648 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10649 unlink the temporary file if Fcall_process didn't create it in the
10650 first place.
10651 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10652 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10653 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10654 cue to call_process_cleanup not to close that handle.
10655
4d3fcc8e
BK
106562011-05-07 Ben Key <bkey76@gmail.com>
10657
10658 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10659 one of two shell specific rules, either bootstrap-temacs-CMD or
10660 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10661 to the previous implementation of the bootstrap-temacs rule.
10662 The bootstrap-temacs-CMD rule is similar to the previous
10663 implementation of the bootstrap-temacs rule except that it
10664 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10665 variable.
10666
10667 These changes, along with some changes to nt/configure.bat,
10668 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10669 earlier fix to add support for --cflags and --ldflags options
10670 that include quotes so that it works whether make uses cmd or
10671 sh as the shell.
10672
b4289b64
MA
106732011-05-06 Michael Albinus <michael.albinus@gmx.de>
10674
10675 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10676 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10677 is a constant.
10678 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10679 a string. Handle both cases.
10680 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10681 (Fdbus_register_method): Use Qinvalid_function.
10682
af4c0e28
JB
106832011-05-06 Juanma Barranquero <lekktu@gmail.com>
10684
10685 * makefile.w32-in: Update dependencies.
10686 (LISP_H): Add inttypes.h and stdin.h.
10687 (PROCESS_H): Add unistd.h.
10688
c51453d9
EZ
106892011-05-06 Eli Zaretskii <eliz@gnu.org>
10690
10691 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10692 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10693
8ff0ac3c 106942011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10695
4c4b566b
PE
10696 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10697
aab2b9b5
PE
10698 * term.c (vfatal): Remove stray call to va_end.
10699 It's not needed and the C Standard doesn't allow it here anyway.
10700
c378da0b
PE
10701 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10702 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10703
288b08c7
PE
10704 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10705 bytes.
10706
e3601888
PE
10707 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10708
db6c0e74
PE
10709 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10710
dd5963ea
PE
10711 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10712
88c9450f
PE
10713 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10714
2f9442b8
PE
10715 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10716
c032b5f8
PE
10717 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10718 * charset.c (Fdefine_charset_internal): Don't initialize
10719 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10720 32-bit int (Bug#8600).
a108c10b
PE
10721
10722 * lread.c (read_integer): Be more consistent with string-to-number.
10723 Use string_to_number to do the actual conversion; this avoids
10724 rounding errors and fixes some other screwups. Without this fix,
10725 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10726 (digit_to_number): Move earlier, for benefit of read_integer.
10727 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10728 not a digit in any supported base. (Bug#8602)
a108c10b 10729
ad5f9eea
PE
10730 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10731
aec1708a
PE
10732 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10733 to match comment at start of function. This also removes a
10734 GCC warning about overflow in a 32+64-bit port.
10735
47be4ab5
PE
10736 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10737
371cac43
PE
10738 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10739 Reported by Stefan Monnier in
10740 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10741 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10742 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10743
d01a7826
PE
10744 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10745 (EMACS_UINTPTR): Likewise, with uintptr_t.
10746
7fd47d5c
PE
10747 * lisp.h: Prefer 64-bit EMACS_INT if available.
10748 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10749 on 32-bit hosts that have 64-bit int, so that they can access
10750 large files.
122b0c86
PE
10751 However, temporarily disable this change unless the temporary
10752 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10753
8727937b
PE
10754 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10755
8ac068ac
PE
10756 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10757 This removes an assumption that EMACS_INT and long are the same
10758 width as pointers. The assumption is true for Emacs porting targets
10759 now, but we want to make other targets possible.
10760 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10761 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10762 In the rest of the code, change types of integers that hold casted
10763 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10764 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10765 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10766 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10767 No need to cast type when ORing.
10768 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10769 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10770 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10771 assume EMACS_INT is the same width as char *.
10772 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10773 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10774 Remove no-longer-needed casts.
10775 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10776 (xg_tool_bar_help_callback, xg_make_tool_item):
10777 Use EMACS_INTPTR to hold an integer
10778 that will be cast to void *; this can avoid a GCC warning
10779 if EMACS_INT is not the same width as void *.
10780 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10781 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10782 (current_message_1, set_message_1):
10783 Use a local to convert to proper width without a cast.
10784 * xmenu.c (dialog_selection_callback): Likewise.
10785
ede49d71
PE
10786 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10787 Also, don't assume VALBITS / RAND_BITS is less than 5,
10788 and don't rely on undefined behavior when shifting a 1 left into
10789 the sign bit.
10790 * lisp.h (get_random): Change signature to match.
10791
2f30ecd0
PE
10792 * lread.c (hash_string): Use size_t, not int, for hash computation.
10793 Normally we prefer signed values; but hashing is special, because
10794 it's better to use unsigned division on hash table sizes so that
10795 the remainder is nonnegative. Also, size_t is the natural width
10796 for hashing into memory. The previous code used 'int', which doesn't
10797 retain enough info to hash well into very large tables.
10798 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10799
2a866e7b
PE
10800 * dbusbind.c: Don't possibly lose pointer info when converting.
10801 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10802 Use XPNTR rather than XHASH, so that the high-order bits of
10803 the pointer aren't lost when converting through void *.
10804
51639eac
PE
10805 * eval.c (Fautoload): Don't double-shift a pointer.
10806
92394119
PE
10807 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10808
dbdb9a7c
JB
108092011-05-06 Juanma Barranquero <lekktu@gmail.com>
10810
10811 * gnutls.c (DEF_GNUTLS_FN):
10812 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10813
db7a0b4f
AS
108142011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10815
10816 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10817 marker. (Bug#8610)
10818
cd394be1 108192011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10820
10821 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10822 New version that can reserve upto 2GB of heap space.
10823
f7ff1b0f 108242011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10825
10826 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10827
639c109b
TZ
108282011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10829
10830 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10831 `gnutls_certificate_set_x509_key_file'.
10832
d2127135
JB
108332011-05-05 Juanma Barranquero <lekktu@gmail.com>
10834
10835 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10836 Update dependencies.
10837
e968f4f3
JB
108382011-05-04 Juanma Barranquero <lekktu@gmail.com>
10839
10840 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10841 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10842 Remove unused parameter `fildes'.
10843 * process.c (read_process_output, send_process): Don't pass it.
10844
84d358f0
JB
108452011-05-04 Juanma Barranquero <lekktu@gmail.com>
10846
10847 Fix previous change: the library cache is defined in w32.c.
10848 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10849 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10850
0898ca10
JB
108512011-05-04 Juanma Barranquero <lekktu@gmail.com>
10852
10853 Implement dynamic loading of GnuTLS on Windows.
10854
10855 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10856 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10857 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10858 Declare.
10859
10860 * gnutls.c (Qgnutls_dll): Define.
10861 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10862 (gnutls_*): Declare function pointers.
10863 (init_gnutls_functions): New function to initialize function pointers.
10864 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10865 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10866 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10867 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10868 (emacs_gnutls_write, emacs_gnutls_read)
10869 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10870 (Fgnutls_available_p): New function.
10871 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10872 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10873 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10874
10875 * image.c: Include w32.h.
10876 (Vimage_type_cache): Delete.
10877 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10878 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10879 (w32_delayed_load): Move to w32.c.
10880
10881 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10882
10883 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10884 (w32_delayed_load): Move from image.c. When loading a library, record
10885 its filename in the :loaded-from property of the library id.
10886 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10887 Initialize and staticpro them.
10888 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10889
10890 * process.c: Include lisp.h before w32.h, not after.
10891 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10892 instead of gnutls_record_check_pending.
10893
10894 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10895
ff4de4aa
TZ
108962011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10897
10898 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10899 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10900 as passed in.
10901
abe95abb
JD
109022011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10903
10904 * xterm.c (x_set_frame_alpha): Do not set property on anything
10905 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10906
e16e55d4
JB
109072011-05-02 Juanma Barranquero <lekktu@gmail.com>
10908
10909 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10910
bafcf6a5
JB
109112011-05-02 Juanma Barranquero <lekktu@gmail.com>
10912
10913 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10914 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10915 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10916 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10917 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10918 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10919 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10920 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10921 (Qgnutls_bootprop_callbacks_verify): Make static.
10922
e7a6747f
AS
109232011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10924
19ed11ba
AS
10925 * callproc.c: Indentation fixup.
10926
e7a6747f 10927 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10928 (wait_for_termination, interruptible_wait_for_termination):
10929 Move after wait_for_termination_1.
e7a6747f 10930
1ef14cb4
LMI
109312011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10932
10933 * sysdep.c (interruptible_wait_for_termination): New function
10934 which is like wait_for_termination, but allows keyboard
10935 interruptions.
10936
10937 * callproc.c (Fcall_process): Add (:file "file") as an option for
10938 the STDOUT buffer.
10939 (Fcall_process_region): Ditto.
10940
330d880c
EZ
109412011-04-30 Eli Zaretskii <eliz@gnu.org>
10942
8db90b73
EZ
10943 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10944 rather than `XVECTOR (FOO)->size'.
10945
330d880c
EZ
10946 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10947 inttypes.h, as a gnulib replacement is used if it not available in
10948 system headers.
10949
15cbd324
EZ
109502011-04-21 Eli Zaretskii <eliz@gnu.org>
10951
10952 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10953 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10954 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10955
10956 * coding.c (coding_alloc_by_realloc): Error out if destination
10957 will grow beyond MOST_POSITIVE_FIXNUM.
10958 (decode_coding_emacs_mule): Abort if there isn't enough place in
10959 charbuf for the composition carryover bytes. Reserve an extra
10960 space for up to 2 characters produced in a loop.
10961 (decode_coding_iso_2022): Abort if there isn't enough place in
10962 charbuf for the composition carryover bytes.
10963
109642011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10965
ae940cca
EZ
10966 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10967 aborting when %lld or %lll format is passed.
10968 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10969 %llo or %llx format is passed. (Bug#8545)
10970
03ab8921
EZ
10971 * window.c (window_scroll_line_based): Use a marker instead of
10972 simple variables to record original value of point. (Bug#7952)
10973
afda1437
EZ
10974 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10975 produced by %s or %c overflows available buffer space. (Bug#8545)
10976
f76dee0c
PE
109772011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10978
10979 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10980 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10981
fdc5744d
JB
109822011-04-28 Juanma Barranquero <lekktu@gmail.com>
10983
10984 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10985
638f053a
JB
109862011-04-28 Juanma Barranquero <lekktu@gmail.com>
10987
10988 * keyboard.c (Qdelayed_warnings_hook): Define.
10989 (command_loop_1): Run `delayed-warnings-hook'
10990 if Vdelayed_warnings_list is non-nil.
10991 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10992 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10993
d178f871
EZ
109942011-04-28 Eli Zaretskii <eliz@gnu.org>
10995
10996 * doprnt.c (doprnt): Don't return value smaller than the buffer
10997 size if the message was truncated. (Bug#8545).
10998
b124fd93
JB
109992011-04-28 Juanma Barranquero <lekktu@gmail.com>
11000
11001 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11002 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11003
e810457d
PE
110042011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11005
11006 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11007
ea51cceb
JB
110082011-04-27 Juanma Barranquero <lekktu@gmail.com>
11009
11010 * makefile.w32-in: Update dependencies.
11011
94dcfacf
EZ
110122011-04-27 Eli Zaretskii <eliz@gnu.org>
11013
11014 Improve `doprnt' and its usage. (Bug#8545)
11015 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11016 `format_end'. Remove support for %l as a conversion specifier.
11017 Don't use xrealloc. Improve diagnostics when the %l size modifier
11018 is used. Update the commentary.
11019
11020 * eval.c (verror): Simplify calculation of size_t.
11021
11022 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11023 messages.
11024
f61f41d7
PE
110252011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11026
11027 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11028 change.
11029
96fb4434
PE
110302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11031
11032 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11033 This makes this file independent of the recent pseudovector change.
11034
671875da 110352011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11036
69e9b5a3
PE
11037 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11038
b5f869a7 11039 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11040 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11041 Remove unused local.
c8926152 11042 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11043
841a1577 11044 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11045 GCC 4.6.0 optimizes based on type-based alias analysis.
11046 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11047 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11048 != &v->size, and therefore "v->size = 1; b->size = 2; return
11049 v->size;" must therefore return 1. This assumption is incorrect
11050 for Emacs, since it type-puns struct Lisp_Vector * with many other
11051 types. To fix this problem, this patch adds a new type struct
f904488f 11052 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11053 and pseudovectors, and helps optimizing compilers not get fooled
11054 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11055 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11056 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11057 the size member.
eab3844f
PE
11058 (XSETPVECTYPE): Rewrite in terms of new macro.
11059 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11060 This is a bit clearer, and further avoids the possibility of
11061 undesirable aliasing.
11062 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11063 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11064 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11065 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11066 (ASIZE): Now uses header.size rather than size.
11067 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11068 to avoid the hassle of writing XVECTOR (foo)->header.size.
11069 (struct vectorlike_header): New type.
eab3844f
PE
11070 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11071 object, to help avoid aliasing.
11072 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11073 (SUBRP): Likewise, since Lisp_Subr is a special case.
11074 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11075 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11076 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11077 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11078 changed to be "header.size" and "header.next".
11079 * buffer.h (struct buffer): Likewise.
11080 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11081 * frame.h (struct frame): Likewise.
11082 * process.h (struct Lisp_Process): Likewise.
11083 * termhooks.h (struct terminal): Likewise.
11084 * window.c (struct save_window_data, struct saved_window): Likewise.
11085 * window.h (struct window): Likewise.
11086 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11087 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11088 * buffer.c (init_buffer_once): Likewise.
11089 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11090 special case.
11091 * process.c (Fformat_network_address): Use local var for size,
11092 for brevity.
11093
0df1eac5
PE
11094 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11095
847ab9d1 11096 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11097 * data.c (atof): Remove decl; no longer used or needed.
11098 (digit_to_number): Move to lread.c.
11099 (Fstring_to_number): Use new string_to_number function, to be
11100 consistent with how the Lisp reader treats infinities and NaNs.
11101 Do not assume that floating-point numbers represent EMACS_INT
11102 without losing information; this is not true on most 64-bit hosts.
11103 Avoid double-rounding errors, by insisting on integers when
11104 parsing non-base-10 numbers, as the documentation specifies.
11105 * lisp.h (string_to_number): New decl, replacing ...
11106 (isfloat_string): Remove.
bc0a5c13 11107 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11108 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11109 appears to have been a coding error. Similarly, do not accept
11110 strings like +-1e0 as floating point numbers. Do not report
11111 overflow for integer overflows unless the base is not 10 which
11112 means we have no simple and reliable way to continue.
11113 Break out the floating-point parsing into a new
11114 function string_to_number, so that Fstring_to_number parses
11115 floating point numbers consistently with the Lisp reader.
04f2d78b 11116 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11117 (E_CHAR, EXP_INT): Remove, replacing with ...
11118 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11119 (string_to_number): New function, replacing isfloat_string.
11120 This function checks for valid syntax and produces the resulting
11121 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11122 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11123 so that overflow for non-base-10 numbers is reported only when
11124 there's no portable and simple way to convert to floating point.
452f4150 11125
67769ffc
PE
11126 * textprop.c (set_text_properties_1): Rewrite for clarity,
11127 and to avoid GCC warning about integer overflow.
11128
c20db43f
PE
11129 * intervals.h (struct interval): Use EMACS_INT for members
11130 where EMACS_UINT might cause problems. See
11131 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11132 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11133 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11134 All uses changed.
37aa2f85
PE
11135 (offset_intervals): Tell GCC not to worry about length overflow
11136 when negating a negative length.
c20db43f 11137
2538aa2f
PE
11138 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11139 (overrun_check_free): Likewise.
11140
f2d3008d
PE
11141 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11142 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11143 word size.
11144
ec8df744
PE
11145 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11146 (gnutls_make_error): Rename local to avoid shadowing.
11147 (gnutls_emacs_global_deinit): ifdef out; not used.
11148 (Fgnutls_boot): Use const for pointer to readonly storage.
11149 Comment out unused local. Fix pointer signedness problems.
11150
640ee02d
PE
11151 * lread.c (openp): Don't stuff size_t into an 'int'.
11152 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11153 about possible signed overflow.
11154
6048fb2a
PE
11155 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11156 (GDK_KEY_g): Don't define if already defined.
11157 (xg_prepare_tooltip): Avoid pointer signedness problem.
11158 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11159
fa3c87e1
PE
11160 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11161 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11162
2172544b
PE
11163 * xfns.c (Fx_window_property): Simplify a bit,
11164 to make a bit faster and to avoid GCC 4.6.0 warning.
11165 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11166
9b821a21
PE
11167 * fns.c (internal_equal): Don't assume size_t fits in int.
11168
3c616cfa
PE
11169 * alloc.c (compact_small_strings): Tighten assertion a little.
11170
c2982e87
PE
11171 Replace pEd with more-general pI, and fix some printf arg casts.
11172 * lisp.h (pI): New macro, generalizing old pEd macro to other
11173 conversion specifiers. For example, use "...%"pI"d..." rather
11174 than "...%"pEd"...".
11175 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11176 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11177 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11178 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11179 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11180 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11181 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11182 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11183 64-bit hosts.
11184 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11185 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11186 * print.c (safe_debug_print, print_object): Likewise.
11187 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11188 to int.
6f04d126
PE
11189 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11190 avoiding the 0 flag, which is not portable.
c2982e87
PE
11191 * process.c (Fmake_network_process): Use pI to avoid cast.
11192 * region-cache.c (pp_cache): Likewise.
11193 * xdisp.c (decode_mode_spec): Likewise.
11194 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11195 behavior on 64-bit hosts with printf arg.
6f04d126 11196 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11197 (x_stop_queuing_selection_requests): Likewise.
11198 (x_get_window_property): Don't truncate byte count to an 'int'
11199 when tracing.
0b432f21 11200
5e073ec7
PE
11201 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11202 here, since it parses constructs like leading '-' and spaces,
11203 which are not wanted; and it overflows with large numbers.
11204 Instead, simply match F[0-9]+, which is what is wanted anyway.
11205
36372bf9
PE
11206 * alloc.c: Remove unportable assumptions about struct layout.
11207 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11208 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11209 (allocate_vectorlike, make_pure_vector): Use the new macros,
11210 plus offsetof, to remove unportable assumptions about struct layout.
11211 These assumptions hold on all porting targets that I know of, but
11212 they are not guaranteed, they're easy to remove, and removing them
11213 makes further changes easier.
11214
0b432f21
PE
11215 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11216 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11217 (string_overrun_cookie): Now const. Use initializers that
11218 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11219 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11220 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11221 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11222 multiple of sizeof (EMACS_INT); it need not be, if
11223 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11224 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11225
895009e1
JB
112262011-04-26 Juanma Barranquero <lekktu@gmail.com>
11227
11228 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11229
6a7a1b0b
TZ
112302011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11231
11232 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11233 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11234 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11235
841a1577 112362011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11237
11238 * lisp.h (Qdebug): List symbol.
895009e1 11239 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11240 * keyboard.c (debug-on-event): New variable.
11241 (handle_user_signal): Break into debugger when debug-on-event
11242 matches the current signal symbol.
11243
f2d3ba6f
DN
112442011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11245
11246 * alloc.c (check_sblock, check_string_bytes)
11247 (check_string_free_list): Convert to standard C.
11248
42ce4c63
TZ
112492011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11250
11251 * w32.c (emacs_gnutls_push): Fix typo.
11252
825cd63c
EZ
112532011-04-25 Eli Zaretskii <eliz@gnu.org>
11254
fb11d64d
EZ
11255 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11256 "cast to pointer from integer of different size".
11257
825cd63c
EZ
11258 Improve doprnt and its use in verror. (Bug#8545)
11259 * doprnt.c (doprnt): Document the set of format control sequences
11260 supported by the function. Use SAFE_ALLOCA instead of always
11261 using `alloca'.
11262
11263 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11264 is one byte too soon. Don't use xrealloc; instead xfree and
11265 xmalloc anew.
11266
e061a11b
TZ
112672011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11268
11269 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11270 callbacks stage.
11271
11272 * gnutls.c: Renamed global_initialized to
11273 gnutls_global_initialized. Added internals for the
11274 :verify-hostname-error, :verify-error, and :verify-flags
11275 parameters of `gnutls-boot' and documented those parameters in the
11276 docstring. Start callback support.
9173deec
JB
11277 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11278 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11279 on error. Return error code.
e061a11b
TZ
11280 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11281 (emacs_gnutls_read): Likewise.
11282 (Fgnutls_boot): Return handshake error code.
11283 (emacs_gnutls_handle_error): New function.
11284 (wsaerror_to_errno): Likewise.
11285
11286 * w32.h (emacs_gnutls_pull): Add prototype.
11287 (emacs_gnutls_push): Likewise.
11288
11289 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11290 (emacs_gnutls_push): Likewise.
11291
112922011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11293
11294 * process.c (wait_reading_process_output): Check if GnuTLS
11295 buffered some data internally if no FDs are set for TLS
11296 connections.
11297
11298 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11299 (LIBS): Link to USER_LIBS.
11300 ($(BLD)/gnutls.$(0)): New target.
11301
fa6996bc
EZ
113022011-04-24 Eli Zaretskii <eliz@gnu.org>
11303
eb35682e
EZ
11304 * xdisp.c (handle_single_display_spec): Rename the
11305 display_replaced_before_p argument into display_replaced_p, to
11306 make it consistent with the commentary. Fix typos in the
11307 commentary.
11308
e2ad650c
EZ
11309 * textprop.c (syms_of_textprop): Remove dead code.
11310 (copy_text_properties): Delete obsolete commentary about an
11311 interface that was deleted long ago. Fix typos in the description
11312 of arguments.
11313
1b2de274
EZ
11314 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11315 to changes in oldXMenu/XMenu.h from 2011-04-16.
11316 <menu_help_message, prev_menu_help_message>: Constify.
11317 (IT_menu_make_room): menu->help_text is now `const char **';
11318 adjust.
11319
11320 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11321 to changes in oldXMenu/XMenu.h from 2011-04-16.
11322 (struct XMenu): Declare `help_text' `const char **'.
11323
11324 * xfaces.c <Qunspecified>: Make extern again.
11325
11326 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11327 required by POSIX.
1b2de274 11328
762b15be
EZ
11329 * doc.c (get_doc_string): Improve the format passed to `error'.
11330
11331 * doprnt.c (doprnt): Improve commentary.
11332
11333 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11334
11335 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11336 them with etags.
11337
f1052e5d
EZ
11338 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11339 changes in globals.h immediately force recompilation.
762b15be
EZ
11340 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11341 $(CURDIR)/s/ms-w32.h.
11342 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11343
fa6996bc
EZ
11344 * character.c (Fchar_direction): Function deleted.
11345 (syms_of_character): Don't defsubr it.
11346 <char-direction-table>: Deleted.
11347
e6c3da20
EZ
113482011-04-23 Eli Zaretskii <eliz@gnu.org>
11349
11350 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11351 * doprnt.c: Include limits.h.
11352 (SIZE_MAX): New macro.
04f2d78b
CB
11353 (doprnt): Return a size_t value. 2nd arg is now size_t.
11354 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11355 Improve overflow protection. Support `l' modifier for integer
11356 conversions. Support %l conversion. Don't assume an EMACS_INT
11357 argument for integer conversions and for %c.
11358
11359 * lisp.h (doprnt): Restore prototype.
11360
11361 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11362 $(SRC)/character.h.
11363
11364 * Makefile.in (base_obj): Add back doprnt.o.
11365
11366 * deps.mk (doprnt.o): Add back prerequisites.
11367 (callint.o): Depend on character.h.
11368
11369 * eval.c (internal_lisp_condition_case): Include the handler
11370 representation in the error message.
11371 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11372 when breaking from the loop.
11373
11374 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11375
11376 * callint.c (Fcall_interactively): When displaying error message
11377 about invalid control letter, pass the character's codepoint, not
11378 a pointer to its multibyte form. Improve display of the character
11379 in octal and display also its hex code.
11380
11381 * character.c (char_string): Use %x to display the (unsigned)
11382 codepoint of an invalid character, to avoid displaying a bogus
11383 negative value.
11384
11385 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11386 `error', not SYMBOL_NAME itself.
11387
11388 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11389 character arguments to `error'.
11390
11391 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11392 to `error' in error message about FINAL_CHAR argument. Make sure
11393 FINAL_CHAR is a character, and use %c when it is passed as
11394 argument to `error'.
11395
4ffd0d6b 113962011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11397
11398 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11399
11400 * w32.c: Include <time.h>.
11401 (sys_localtime): New function.
11402
4ffd0d6b 114032011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11404
11405 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11406
4ffd0d6b 11407 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11408
4ffd0d6b 114092011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11410
4ffd0d6b
GM
11411 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11412 zombies (Bug#8467).
aac0c6e3 11413
04c56954
EZ
114142011-04-19 Eli Zaretskii <eliz@gnu.org>
11415
11416 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11417 gl_state.e_property when gl_state.object is Qt.
11418
11419 * insdel.c (make_gap_larger): Remove limitation of buffer size
11420 to <= INT_MAX.
11421
16a43933
CY
114222011-04-18 Chong Yidong <cyd@stupidchicken.com>
11423
11424 * xdisp.c (lookup_glyphless_char_display)
11425 (produce_glyphless_glyph): Handle cons cell entry in
11426 glyphless-char-display.
11427 (Vglyphless_char_display): Document it.
11428
11429 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11430 glyphless-char-display.
11431
4581706e
CY
114322011-04-17 Chong Yidong <cyd@stupidchicken.com>
11433
11434 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11435
11436 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11437
11438 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11439 definition for no-X builds.
11440
4887c6e2 114412011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11442
fd35b6f9
PE
11443 Static checks with GCC 4.6.0 and non-default toolkits.
11444
5c1ccb01
PE
11445 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11446
006c5daa
PE
11447 * process.c (keyboard_bit_set): Define only if SIGIO.
11448 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11449 (send_process): Repair possible setjmp clobbering.
11450
efc736d3
PE
11451 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11452
4e2fe2e6
PE
11453 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11454
f97334a2
PE
11455 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11456
4e75f29d
PE
11457 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11458 Define only if needed.
11459
90efadd1
PE
11460 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11461 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11462 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11463
3c647824
PE
11464 * dispextern.h (struct redisplay_interface): Rename param
11465 to avoid shadowing.
e264f262 11466 * termhooks.h (struct terminal): Likewise.
761383f4 11467 * xterm.c (xembed_send_message): Likewise.
3c647824 11468
b58c5c4a
PE
11469 * insdel.c (make_gap_smaller): Define only if
11470 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11471
cad59032
PE
11472 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11473 it.
11474
c339dc2e
PE
11475 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11476 so that we aren't warned about unused symbols.
11477
91a3e27b
PE
11478 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11479
399c71d3 11480 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11481
8ffc96f5
PE
11482 * xfns.c (x_real_positions): Mark locals as initialized.
11483
eef9bc79
PE
11484 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11485
098db9dd
PE
11486 * xterm.c: Fix problems found by static analysis with other toolkits.
11487 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11488 (x_dispatch_event): Declare static if USE_GTK, and
11489 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11490 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11491 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11492 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11493 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11494
eb18f6cc
PE
11495 * xmenu.c (menu_help_callback): Pointer type fixes.
11496 Use const pointers when pointing at readonly data. Avoid pointer
11497 signedness clashes.
11498 (FALSE): Remove unused macro.
11499 (update_frame_menubar): Remove unused decl.
11500
1fe72bf8
PE
11501 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11502
60d9e1db
PE
11503 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11504 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11505 (single_menu_item): Rename local to avoid shadowing.
11506
39261c26
PE
11507 * keyboard.c (make_lispy_event): Remove unused local var.
11508
018c5e19
PE
11509 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11510 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11511
63d2b86e
PE
11512 * bitmaps: Change bitmaps from unsigned char back to the X11
11513 compatible char. Avoid the old compiler warnings about
11514 out-of-range initializers by using, for example, '\xab' rather
11515 than 0xab.
11516
aefd87e1
PE
11517 * xgselect.c (xgselect_initialize): Check vs interface
11518 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11519
bf501fb9
PE
11520 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11521
e9829fdf
PE
11522 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11523 to read-only memory.
11524
1086c095
PE
11525 * fns.c (vector): Remove; this old hack is no longer needed.
11526
2baccd04 11527 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11528 Remove unused var.
dde42981 11529 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11530
72391843 11531 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11532
436c16df 11533 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11534 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11535 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11536
92bb796d 11537 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11538 (x_term_init): Remove local to avoid shadowing.
92bb796d 11539
764430a3 11540 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11541
11542 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11543 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11544
d1dfb56c
EZ
115452011-04-16 Eli Zaretskii <eliz@gnu.org>
11546
c4354cb4
EZ
11547 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11548
d1dfb56c
EZ
11549 Fix regex.c, syntax.c and friends for buffers > 2GB.
11550 * syntax.h (struct gl_state_s): Declare character position members
11551 EMACS_INT.
11552
11553 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11554
04f2d78b
CB
11555 * textprop.c (verify_interval_modification, interval_of):
11556 Declare arguments EMACS_INT.
d1dfb56c
EZ
11557
11558 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11559 EMACS_INT.
11560
11561 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11562
11563 * indent.c (Fvertical_motion): Local variable it_start is now
11564 EMACS_INT.
11565
11566 * regex.c (re_match, re_match_2, re_match_2_internal)
11567 (bcmp_translate, regcomp, regexec, print_double_string)
11568 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11569 (re_compile_pattern, re_exec): Declare arguments and local
11570 variables `size_t' and `ssize_t' and return values `regoff_t', as
11571 appropriate.
11572 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11573 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11574 <compile_stack_type>: `size' and `avail' are now `size_t'.
11575
11576 * regex.h <regoff_t>: Use ssize_t, not int.
11577 (re_search, re_search_2, re_match, re_match_2): Arguments that
11578 specify buffer/string position and length are now ssize_t and
11579 size_t. Return type is regoff_t.
11580
613052cd
BK
115812011-04-16 Ben Key <bkey76@gmail.com>
11582
11583 * nsfont.m: Fixed bugs in ns_get_family and
11584 ns_descriptor_to_entity that were caused by using free to
11585 deallocate memory blocks that were allocated by xmalloc (via
11586 xstrdup). This caused Emacs to crash when compiled with
11587 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11588 --enable-checking=xmallocoverrun). xfree is now used to
11589 deallocate these memory blocks.
11590
4170f62f 115912011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11592
71b41406
PE
11593 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11594
9587a89d
PE
11595 emacs_write: Accept and return EMACS_INT for sizes.
11596 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11597 et seq.
11598 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11599 Accept and return EMACS_INT.
11600 (emacs_gnutls_write): Return the number of bytes written on
11601 partial writes.
11602 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11603 (emacs_read, emacs_write): Remove check for negative size, as the
11604 Emacs source code has been audited now.
9587a89d
PE
11605 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11606 (emacs_read, emacs_write): Use it.
273a5f82
PE
11607 * process.c (send_process): Adjust to the new signatures of
11608 emacs_write and emacs_gnutls_write. Do not attempt to store
11609 a byte offset into an 'int'; it might overflow.
9587a89d 11610 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11611
3e047f51
PE
11612 * sound.c: Don't assume sizes fit in 'int'.
11613 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11614 Return EMACS_INT, not int.
3e047f51 11615 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11616 Accept EMACS_INT, not int.
11617 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11618 record read return values.
11619
cc39a9db
BK
116202011-04-15 Ben Key <bkey76@gmail.com>
11621
c9d0ec6d
JB
11622 * keyboard.c (Qundefined): Don't declare static since it is used
11623 in nsfns.m.
11624 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11625 static since they are used in nsfont.m.
cc39a9db 11626
6c60eb9f
SM
116272011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11628
11629 * process.c (Qprocessp): Don't declare static.
11630 * lisp.h (Qprocessp): Declare again.
11631
7990b61a
JB
116322011-04-15 Juanma Barranquero <lekktu@gmail.com>
11633
11634 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11635
5d4cb038
PE
116362011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11637
8bd7b830 11638 Improve C-level modularity by making more things 'static'.
cd64ea1d 11639
e3b27b31
PE
11640 Don't publish debugger-only interfaces to other modules.
11641 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11642 (verify_bytepos, count_markers): Move decls to the only modules
11643 that need them.
11644 * region-cache.h (pp_cache): Likewise.
11645 * window.h (check_all_windows): Likewise.
11646 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11647
5d4cb038
PE
11648 * sysdep.c (croak): Now static, if
11649 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11650 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11651
11652 * alloc.c (refill_memory_reserve): Now static if
11653 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11654 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11655
e87b6180
PE
11656 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11657 Define only if USE_LUCID.
11658
ac64929e
PE
11659 * xrdb.c (x_customization_string, x_rm_string): Now static.
11660
6f37259d
PE
11661 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11662 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11663
1683e3ab
PE
11664 * xdisp.c (draw_row_with_mouse_face): Now static.
11665 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11666
de9c2632
PE
11667 * window.h (check_all_windows): Mark externally visible.
11668
2b96acb7
PE
11669 * window.c (window_deletion_count): Now static.
11670
11671 * undo.c: Make symbols static if they're not exported.
11672 (last_undo_buffer, last_boundary_position, pending_boundary):
11673 Now static.
11674
50436f33
PE
11675 * textprop.c (interval_insert_behind_hooks): Now static.
11676 (interval_insert_in_front_hooks): Likewise.
11677
64520e5c
PE
11678 * term.c: Make symbols static if they're not exported.
11679 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11680 (max_frame_lines, tty_set_terminal_modes):
11681 (tty_reset_terminal_modes, tty_turn_off_highlight):
11682 (get_tty_terminal): Now static.
11683 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11684 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11685 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11686 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11687 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11688
1fa53021
PE
11689 * sysdep.c: Make symbols static if they're not exported.
11690 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11691 Now static.
11692 (sigprocmask_set, full_mask): Remove; unused.
11693 (wait_debugging): Mark as visible.
11694 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11695 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11696
d4b43b22
PE
11697 * syntax.c (syntax_temp): Define only if !__GNUC__.
11698
b7c513d0
PE
11699 * sound.c (current_sound_device, current_sound): Now static.
11700
989b29ad
PE
11701 * search.c (searchbufs, searchbuf_head): Now static.
11702
13a55a78
PE
11703 * scroll.c (scroll_cost): Remove; unused.
11704 * dispextern.h (scroll_cost): Remove decl.
11705
de68a1fc
PE
11706 * region-cache.h (pp_cache): Mark as externally visible.
11707
40ccffa6
PE
11708 * process.c: Make symbols static if they're not exported.
11709 (process_tick, update_tick, create_process, chan_process):
11710 (Vprocess_alist, proc_buffered_char, datagram_access):
11711 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11712 (deactivate_process): Mark defn as static, as well as decl.
11713 * lisp.h (create_process): Remove decl.
11714 * process.h (chan_process, Vprocess_alist): Remove decls.
11715
ad64fc97
PE
11716 * print.c: Make symbols static if they're not exported.
11717 (print_depth, new_backquote_output, being_printed, print_buffer):
11718 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11719 (print_interval, print_number_index, initial_stderr_stream):
11720 Now static.
11721 * lisp.h (Fprinc): Remove decl.
11722 (debug_output_compilation_hack): Mark as externally visible.
11723
adddb265
PE
11724 * sysdep.c (croak): Move decl from here to syssignal.h.
11725 * syssignal.h (croak): Put it here, so the API can be checked when
11726 'croak' is called from dissociate_if_controlling_tty.
11727
1717ede2
PE
11728 * minibuf.c: Make symbols static if they're not exported.
11729 (minibuf_save_list, choose_minibuf_frame): Now static.
11730 * lisp.h (choose_minibuf_frame): Remove decl.
11731
fa5fb2bc
PE
11732 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11733
1e3890d1
PE
11734 * lread.c: Make symbols static if they're not exported.
11735 (read_objects, initial_obarray, oblookup_last_bucket_number):
11736 Now static.
11737 (make_symbol): Remove; unused.
11738 * lisp.h (initial_obarray, make_symbol): Remove decls.
11739
8a1414fa
PE
11740 * keyboard.c: Make symbols static if they're not exported.
11741 (single_kboard, recent_keys_index, total_keys, recent_keys):
11742 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11743 (this_single_command_key_start, echoing, last_auto_save):
11744 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11745 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11746 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11747 (Vlispy_mouse_stem, double_click_count):
11748 Now static.
11749 (force_auto_save_soon): Define only if SIGDANGER.
11750 (ignore_mouse_drag_p): Now static if
11751 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11752 (print_help): Remove; unused.
11753 (stop_character, last_timer_event): Mark as externally visible.
11754 * keyboard.h (ignore_mouse_drag_p): Declare only if
11755 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11756 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11757 * lisp.h (echoing): Remove decl.
11758 (force_auto_save_soon): Declare only if SIGDANGER.
11759 * xdisp.c (redisplay_window): Simplify code, to make it more
11760 obvious that ignore_mouse_drag_p is not accessed if !defined
11761 USE_GTK && !defined HAVE_NS.
11762
93ea6e8f
PE
11763 * intervals.c: Make symbols static if they're not exported.
11764 (merge_properties_sticky, merge_interval_right, delete_interval):
11765 Now static.
11766 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11767
77382fcc
PE
11768 * insdel.c: Make symbols static if they're not exported.
11769 However, leave prepare_to_modify_buffer alone. It's never
11770 called from outside this function, but that appears to be a bug.
11771 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11772 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11773 (adjust_after_replace_noundo): Remove; unused.
11774 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11775 (signal_before_change): Remove decls.
77382fcc 11776
9306c32e
PE
11777 * indent.c (val_compute_motion, val_vmotion): Now static.
11778
cd44d2eb
PE
11779 * image.c: Make symbols static if they're not exported.
11780 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11781 if USE_GTK.
11782 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11783 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11784
ad9a7a06
PE
11785 * fringe.c (standard_bitmaps): Now static.
11786 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11787
81626931
PE
11788 * frame.c: Make symbols static if they're not exported.
11789 (x_report_frame_params, make_terminal_frame): Now static.
11790 (get_frame_param): Now static, unless HAVE_NS.
11791 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11792 (x_get_resource_string): Remove; not used.
11793 * frame.h (make_terminal_frame, x_report_frame_params):
11794 (x_get_resource_string); Remove decls.
11795 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11796 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11797
239f9db9
PE
11798 * font.c, fontset.c: Make symbols static if they're not exported.
11799 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11800 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11801 * font.c (font_close_object): Now static.
11802 * font.h (font_close_object): Remove.
11803 * fontset.c (FONTSET_OBJLIST): Remove.
11804 (free_realized_fontset) #if-0 the body, which does nothing.
11805 (face_suitable_for_char_p): #if-0, as it's never called.
11806 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11807 * xfaces.c (face_at_string_position):
11808 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11809 since 0 is always ASCII.
11810
dfcf3579
PE
11811 * fns.c (weak_hash_tables): Now static.
11812
5045092b
PE
11813 * fileio.c: Make symbols static if they're not exported.
11814 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11815 (Vwrite_region_annotation_buffers): Now static.
11816
57a96f5c
PE
11817 * eval.c: Make symbols static if they're not exported.
11818 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11819 * lisp.h (backtrace_list): Remove decl.
11820
35f08c38
PE
11821 * emacs.c: Make symbols static if they're not exported.
11822 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11823 (fatal_error_code, fatal_error_signal_hook, standard_args):
11824 Now static.
11825 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11826 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11827 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11828 * lisp.h (fatal_error_signal_hook): Remove decl.
11829 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11830
f44bd759
PE
11831 * editfns.c: Move a (normally-unused) function to its only use.
11832 * editfns.c, lisp.h (get_operating_system_release): Remove.
11833 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11834 worth the hassle of breaking this out.
11835
b532497d
PE
11836 * xterm.c: Make symbols static if they're not exported.
11837 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11838 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11839 (x_destroy_window, x_delete_display):
11840 Now static.
11841 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11842 (x_mouse_leave): Remove; unused.
11843 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11844 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11845 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11846 Remove decls.
11847 (x_mouse_leave): Declare only if WINDOWSNT.
11848 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11849 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11850 USE_X_TOOLKIT.
11851
1675728f
PE
11852 * ftxfont.c: Make symbols static if they're not exported.
11853 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11854 HAVE_FREETYPE.
11855 * font.h (ftxfont_driver): Likewise.
11856
e4cebfca
PE
11857 * xfns.c: Make symbols static if they're not exported.
11858 (x_last_font_name, x_display_info_for_name):
11859 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11860 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11861 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11862 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11863 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11864 (last_show_tip_args): Now static.
11865 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11866 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11867 (x_screen_planes): Remove; unused.
11868 * dispextern.h (x_screen_planes): Remove decl.
11869
5bf46f05
PE
11870 * dispnew.c: Make symbols static if they're not exported.
11871 * dispextern.h (redraw_garbaged_frames, scrolling):
11872 (increment_row_positions): Remove.
11873 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11874 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11875 Now static.
11876 (redraw_garbaged_frames): Remove; unused.
11877
435f4c28
PE
11878 * xfaces.c: Make symbols static if they're not exported.
11879 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11880 Remove decls.
11881 * xterm.h (defined_color): Remove decls.
11882 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11883 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11884 (menu_face_changed_default, defined_color, free_realized_face):
11885 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11886 (ascii_face_of_lisp_face): Remove; unused.
11887
8524aef3
PE
11888 * xdisp.c: Make symbols static if they're not exported.
11889 * dispextern.h (scratch_glyph_row, window_box_edges):
11890 (glyph_to_pixel_coords, set_cursor_from_row):
11891 (get_next_display_element, set_iterator_to_next):
11892 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11893 (show_mouse_face): Remove decls
11894 * frame.h (message_buf_print): Likewise.
11895 * lisp.h (pop_message, set_message, check_point_in_composition):
11896 Likewise.
11897 * xterm.h (set_vertical_scroll_bar): Likewise.
11898 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11899 (message_buf_print, scratch_glyph_row, displayed_buffer):
11900 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11901 (get_next_display_element, show_mouse_face, window_box_edges):
11902 (frame_to_window_pixel_xy, check_point_in_composition):
11903 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11904 (glyph_to_pixel_coords): Remove; unused.
11905
16390cd2
PE
11906 * dired.c (file_name_completion): Now static.
11907
11908 * dbusbind.c (xd_in_read_queued_messages): Now static.
11909
a25f4dfa
PE
11910 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11911 * data.c (circular_list_error): Remove.
11912
14a9c8df
PE
11913 * commands.h (last_point_position, last_point_position_buffer):
11914 (last_point_position_window): Remove decls.
11915 * keyboard.c: Make these variables static.
11916
04f2d78b
CB
11917 * coding.h (coding, code_convert_region, encode_coding_gap):
11918 Remove decls.
74ab6df5
PE
11919 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11920 (iso_code_class, detect_coding, code_convert_region): Now static.
11921 (encode_coding_gap): Remove; unused.
11922
38dfbee1
PE
11923 * chartab.c (chartab_chars, chartab_bits): Now static.
11924
a2cb4e63
PE
11925 * charset.h (charset_iso_8859_1): Remove decl.
11926 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11927 Now static.
11928
127198fd
PE
11929 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11930 * ccl.c (Vccl_program_table): Now static.
11931 (check_ccl_update): Remove; unused.
11932
d85b608f
PE
11933 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11934 * category.h: ... from here.
11935 * category.c (check_category_table, set_category_set): Now static.
11936
31cd66f3
PE
11937 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11938 * lisp.h: Remove these decls.
11939
c358e587
PE
11940 * buffer.c (buffer_count): Remove unused var.
11941
e78aecca
PE
11942 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11943 so that it's not optimized away.
11944 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11945 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11946 exported only to the debugger.
11947
e192d7d3 11948 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11949 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11950
92470028
PE
11951 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11952 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11953 was inaccessible from Lisp.
11954 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11955 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11956
244ed907
PE
11957 alloc.c: Import and export fewer symbols, and remove unused items.
11958 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11959 is defined.
11960 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11961 it's not optimized away by whole-program optimization.
11962 (message_enable_multibyte, free_misc): Remove.
11963 (catchlist, handlerlist, mark_backtrace):
11964 Declare only if BYTE_MARK_STACK.
11965 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11966 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11967 (message_enable_multibyte): Remove decl.
11968 (free_misc, interval_free_list, float_block, float_block_index):
11969 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11970 (cons_free_list, last_marked_index):
11971 Now static.
11972 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11973 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11974 (mark_backtrace): Define only if BYTE_MARK_STACK.
11975 * xdisp.c (message_enable_multibyte): Now static.
11976
61c2b50e 11977 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11978 This makes it easier for human readers (and static analyzers)
11979 to see whether these variables are used from other modules.
11980 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11981 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11982 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11983 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11984 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11985 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11986 * xmenu.c, xselect.c:
11987 Declare Q* vars static if they are not used in other modules.
11988 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11989 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11990 Remove decls of unexported vars.
11991 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11992
95c82688
PE
11993 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11994
16a97296
PE
11995 Make Emacs functions such as Fatom 'static' by default.
11996 This makes it easier for human readers (and static analyzers)
11997 to see whether these functions can be called from other modules.
11998 DEFUN now defines a static function. To make the function external
11999 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12000 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12001 (Finit_image_library):
16a97296
PE
12002 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12003 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12004 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12005 Remove decls, since these functions are now static.
12006 (Funintern, Fget_internal_run_time): New decls, since these functions
12007 were already external.
95c82688 12008
16a97296
PE
12009 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12010 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12011 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12012 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12013 * keyboard.c, keymap.c, lread.c:
12014 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12015 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12016 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12017 Mark functions with DEFUE instead of DEFUN,
12018 if they are used in other modules.
12019 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12020 decls for now-static functions.
12021 * buffer.h (Fdelete_overlay): Remove decl.
12022 * callproc.c (Fgetenv_internal): Mark as internal.
12023 * composite.c (Fremove_list_of_text_properties): Remove decl.
12024 (Fcomposition_get_gstring): New forward static decl.
12025 * composite.h (Fcomposite_get_gstring): Remove decl.
12026 * dired.c (Ffile_attributes): New forward static decl.
12027 * doc.c (Fdocumntation_property): New forward static decl.
12028 * eval.c (Ffetch_bytecode): New forward static decl.
12029 (Funintern): Remove extern decl; now in .h file where it belongs.
12030 * fileio.c (Fmake_symbolic_link): New forward static decl.
12031 * image.c (Finit_image_library): New forward static decl.
12032 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12033 * intervals.h (Fprevious_property_change):
12034 (Fremove_list_of_text_properties): Remove decls.
12035 * keyboard.c (Fthis_command_keys): Remove decl.
12036 (Fcommand_execute): New forward static decl.
12037 * keymap.c (Flookup_key): New forward static decl.
12038 (Fcopy_keymap): Now static.
12039 * keymap.h (Flookup_key): Remove decl.
12040 * process.c (Fget_process): New forward static decl.
12041 (Fprocess_datagram_address): Mark as internal.
12042 * syntax.c (Fsyntax_table_p): New forward static decl.
12043 (skip_chars): Remove duplicate decl.
12044 * textprop.c (Fprevious_property_change): New forward static decl.
12045 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12046 Now internal.
12047 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12048 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12049
785bbd42
PE
12050 * editfns.c (Fformat): Remove unreachable code.
12051
8b913b57
AS
120522011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12053
12054 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12055 change. (Bug#8496)
12056
a6744a35
EZ
120572011-04-13 Eli Zaretskii <eliz@gnu.org>
12058
12059 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12060 when at ZV. (Bug#8487)
12061
e7974947
AS
120622011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12063
baad03f0
AS
12064 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12065 (Bug#8437)
12066 * keyboard.c (parse_tool_bar_item): Likewise.
12067 * sound.c (sound_cleanup, alsa_close): Likewise.
12068 * termcap.c (tgetent): Likewise.
12069 * xfns.c (x_default_font_parameter): Likewise.
12070 * xsettings.c (read_and_apply_settings): Likewise.
12071
e7974947
AS
12072 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12073 (overrun_check_free): Protoize.
12074
28272684
PE
120752011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12076
12077 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12078 since callers should never pass a negative size.
12079 Change the signature to match that of plain 'read' and 'write'; see
12080 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12081 * lisp.h: Update prototypes of emacs_write and emacs_read.
12082
11997c76
EZ
120832011-04-11 Eli Zaretskii <eliz@gnu.org>
12084
12085 * xdisp.c (redisplay_window): Don't try to determine the character
12086 position of the scroll margin if the window start point w->startp
e896f03c 12087 is outside the buffer's accessible region. (Bug#8468)
11997c76 12088
8a2cbd72
EZ
120892011-04-10 Eli Zaretskii <eliz@gnu.org>
12090
12091 Fix write-region and its subroutines for buffers > 2GB.
12092 * fileio.c (a_write, e_write): Modify declaration of arguments and
12093 local variables to support buffers larger than 2GB.
12094 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12095
12096 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12097 argument, local variables, and return value.
12098
12099 * lisp.h: Update prototypes of emacs_write and emacs_read.
12100
12101 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12102
4073e537 121032011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12104
1ebfdcb6
PE
12105 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12106
b2ded58d
PE
12107 Fix more problems found by GCC 4.6.0's static checks.
12108
7d66342c
PE
12109 * xdisp.c (vmessage): Use a better test for character truncation.
12110
bbf47d44
PE
12111 * charset.c (load_charset_map): <, not <=, for optimization,
12112 and to avoid potential problems with integer overflow.
9248994d 12113 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12114 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12115 * editfns.c (Fformat): Likewise.
1e69125e 12116 * syntax.c (skip_chars): Likewise.
3befa583 12117
e3019616
PE
12118 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12119 This also lets GCC 4.6.0 generate slightly better loop code.
12120
becfa255
PE
12121 * callint.c (Fcall_interactively): <, not <=, for optimization.
12122 (Fcall_interactively): Count the number of arguments produced,
12123 not the number of arguments given. This is simpler and lets GCC
12124 4.6.0 generate slightly better code.
12125
dae0cd48
PE
12126 * ftfont.c: Distingish more carefully between FcChar8 and char.
12127 The previous code passed unsigned char * to a functions like
12128 strlen and xstrcasecmp that expect char *, which does not
12129 conform to the C standard.
12130 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12131 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12132 char * when the C standard requires it.
12133
76032d70
PE
12134 * keyboard.c (read_char): Remove unused var.
12135
eb3f1cc8
PE
12136 * eval.c: Port to Windows vsnprintf (Bug#8435).
12137 Include <limits.h>.
12138 (SIZE_MAX): Define if the headers do not.
12139 (verror): Do not give up if vsnprintf returns a negative count.
12140 Instead, grow the buffer. This ports to Windows vsnprintf, which
12141 does not conform to C99. Problem reported by Eli Zaretskii.
12142 Also, simplify the allocation scheme, by avoiding the need for
12143 calling realloc, and removing the ALLOCATED variable.
12144
70476b54
PE
12145 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12146
12020a9e
PE
12147 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12148 But keep the doprint source code for now, as we might revamp it
12149 and use it again (Bug#8435).
ea6c7ae6
PE
12150 * lisp.h (doprnt): Remove.
12151 * Makefile.in (base_obj): Remove doprnt.o.
12152 * deps.mk (doprnt.o): Remove.
12153
5fdb398c
PE
12154 error: Print 32- and 64-bit integers portably (Bug#8435).
12155 Without this change, on typical 64-bit hosts error ("...%d...", N)
12156 was used to print both 32- and 64-bit integers N, which relied on
12157 undefined behavior.
61bdb816 12158 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12159 * lisp.h (error, verror): Mark as printf-like functions.
12160 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12161 Report overflow in size calculations when allocating printf buffer.
12162 Do not truncate output string at its first null byte.
12163 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12164 Truncate the output at a character boundary, since vsnprintf does not
12165 do that.
12166 * charset.c (check_iso_charset_parameter): Convert internal
12167 character to string before calling 'error', since %c now has the
12168 printf meaning.
12169 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12170 overflow when computing char to be passed to 'error'. Do not
12171 pass Lisp_Object to 'error'; pass the integer instead.
12172 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12173 formatted with plain %d.
12174
b189fa66
PE
12175 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12176
bff87ef0
PE
12177 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12178
7e2cac20
PE
12179 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12180
ce4d90b5
PE
12181 * xterm.c (x_catch_errors): Remove duplicate declaration.
12182
266c9547
PE
12183 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12184
79c49ad2
PE
12185 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12186
368f4090
JM
121872011-04-10 Jim Meyering <meyering@redhat.com>
12188
12189 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12190 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12191 return ssize_t not "int", and use size_t as the buffer length.
12192 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12193 * gnutls.h: Update declarations.
12194 * process.c (read_process_output): Use ssize_t, to match.
12195 (send_process): Likewise.
12196
a32d4040
CY
121972011-04-09 Chong Yidong <cyd@stupidchicken.com>
12198
12199 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12200
8546720e 122012011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12202
04f2d78b
CB
12203 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12204 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12205
8546720e
GM
12206 * xterm.c (handle_one_xevent):
12207 * xmenu.c (create_and_show_popup_menu):
12208 * xselect.c (x_decline_selection_request)
12209 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12210
0a2f5c1a 122112011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12212
12213 Fix some uses of `int' instead of EMACS_INT.
12214 * search.c (string_match_1, fast_string_match)
12215 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12216 (scan_buffer, find_next_newline_no_quit)
12217 (find_before_next_newline, search_command, Freplace_match)
12218 (Fmatch_data): Make some `int' variables be EMACS_INT.
12219
12220 * xdisp.c (display_count_lines): 3rd argument and return value now
12221 EMACS_INT. All callers changed.
12222 (pint2hrstr): Last argument is now EMACS_INT.
12223
12224 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12225 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12226 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12227 (decode_coding_utf_16, decode_coding_emacs_mule)
12228 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12229 (decode_coding_ccl, decode_coding_charset)
12230 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12231 (decode_coding_iso_2022, decode_coding_emacs_mule)
12232 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12233 <char_offset, last_offset>: Declare EMACS_INT.
12234 (encode_coding_utf_8, encode_coding_utf_16)
12235 (encode_coding_emacs_mule, encode_invocation_designation)
12236 (encode_designation_at_bol, encode_coding_iso_2022)
12237 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12238 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12239 Declare EMACS_INT.
12240 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12241 (encode_invocation_designation): Last argument P_NCHARS is now
12242 EMACS_INT.
12243 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12244 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12245
12246 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12247 All users changed.
12248
12249 * ccl.c (Fccl_execute_on_string): Declare some variables
12250 EMACS_INT.
12251
8546720e 122522011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12253
12254 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12255
4e19a977
CS
122562011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12257
12258 * process.c (Fformat_network_address): Doc fix.
12259
87302331
R
122602011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12261
ee7683eb 12262 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12263
cbb59342
CY
122642011-04-08 Chong Yidong <cyd@stupidchicken.com>
12265
12266 * keyboard.c (read_char): Call Lisp function help-form-show,
12267 instead of using internal_with_output_to_temp_buffer.
12268 (Qhelp_form_show): New var.
e0d38eeb 12269 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12270
12271 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12272
12273 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12274
e67a13ab
CY
122752011-04-06 Chong Yidong <cyd@stupidchicken.com>
12276
04f2d78b
CB
12277 * process.c (Flist_processes): Remove to Lisp.
12278 (list_processes_1): Delete.
e67a13ab 12279
973f782d
EZ
122802011-04-06 Eli Zaretskii <eliz@gnu.org>
12281
7c106b1e
EZ
12282 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12283
973f782d
EZ
12284 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12285
41cf7d1a 122862011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12287
ca23cc88
PE
12288 Fix more problems found by GCC 4.6.0's static checks.
12289
f390e2d5
PE
12290 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12291
42eea0d0
PE
12292 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12293
b69769da 12294 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12295
f9541e84
PE
12296 * xdisp.c (vmessage): Mark as a printf-like function.
12297
13841b55
PE
12298 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12299
c136c10f
PE
12300 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12301
5e2d4a30
PE
12302 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12303 printf-like functions.
12304 (tiff_load): Add casts to remove these marks before passing them
12305 to system-supplied API.
12306
583f48b9
PE
12307 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12308
b25d760e
PE
12309 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12310 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12311 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12312 directly, rather than having caller test rule sign. This avoids
12313 some unnecessary tests.
12314 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12315 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12316 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12317
bc7b6697 12318 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12319 (xfont_open): Avoid unnecessary tests.
bc7b6697 12320
27ccc379
PE
12321 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12322
dcd5c89a
PE
12323 * composite.h, composite.c (composition_gstring_put_cache):
12324 Use EMACS_INT, not int, for length.
12325
b13a45c6
PE
12326 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12327 breaking out part of COMPOSITION_DECODE_RULE.
12328 (COMPOSITION_DECODE_RULE): Use it.
12329 * composite.c (get_composition_id): Remove unused local vars,
12330 by using the new macro.
12331
1e792e4d
PE
12332 * textprop.c (set_text_properties_1): Change while to do-while,
12333 since the condition is always true at first.
12334
dc6c6455 12335 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12336 (interval_deletion_adjustment): Return unsigned value.
12337 All uses changed.
dc6c6455 12338
aba7731a
PE
12339 * process.c (list_processes_1, create_pty, read_process_output):
12340 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12341 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12342 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12343 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12344 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12345
fdfc4bf3
PE
12346 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12347
fca8fe46 12348 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12349 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12350
06a0259a 12351 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12352 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12353 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12354
e7b9e80f
PE
12355 * print.c (print_error_message): Avoid int overflow.
12356
56201685
PE
12357 * font.c (font_list_entities): Redo for clarity,
12358 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12359
78834453 12360 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12361 (font_score): Avoid potential overflow in diff calculation.
78834453 12362
0bc0b309 12363 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12364 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12365
e610eaca
PE
12366 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12367
b895abce
PE
12368 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12369 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12370 can always succeed if overflow has undefined behavior.
12371
1f1d9321 12372 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12373 (wordify): Omit three unnecessary tests.
1f1d9321 12374
c59478bc
PE
12375 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12376 All callers changed. This avoids the need for an unused var.
12377
79b73827
PE
12378 * casefiddle.c (casify_region): Remove var that is set but not used.
12379
a4db5dfe
PE
12380 * dired.c (file_name_completion): Remove var that is set but not used.
12381
43aae36e
PE
12382 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12383
2a47c44d 12384 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12385 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12386
a37c69bf
PE
12387 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12388 Check for integer overflow on size calculations.
12389
328ab8e7
PE
12390 * buffer.c (Fprevious_overlay_change): Remove var that is set
12391 but not used.
12392
e5a2a5cb
PE
12393 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12394 Remove vars that are set but not used.
8d84a6eb 12395 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12396 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12397
a60e5f68
PE
12398 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12399
f661cb61 12400 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12401 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12402
f0397f5a
PE
12403 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12404 that are set but not used.
12405
8664db06 12406 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12407 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12408
6abdaa4a
PE
12409 * xselect.c (x_get_local_selection, x_handle_property_notify):
12410 Remove vars that are set but not used.
12411
0ce7538d 12412 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12413 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12414
9ae848fc
PE
12415 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12416 Remove var that is set but not used.
0b918413
PE
12417 (scroll_bar_windows_size): Now size_t, not int.
12418 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12419 Check for overflow.
9ae848fc 12420
a5a62657
PE
12421 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12422 (map_tty_color) [!defined MSDOS]: Likewise.
12423
5c5cdd39
PE
12424 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12425
66ebf983
PE
12426 * coding.c: Remove vars that are set but not used.
12427 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12428 All callers changed.
12429 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12430 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12431 (decode_coding_charset): Remove vars that are set but not used.
12432
1be4d761
PE
12433 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12434 that is set but not used.
12435
47553fa8
PE
12436 * print.c (print_object): Remove var that is set but not used.
12437
1f7196bf 12438 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12439 The gnulib version avoids calling malloc in the usual case,
12440 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12441 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12442 * filelock.c (current_lock_owner): Likewise.
12443 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12444 * sysdep.c: Include allocator.h, careadlinkat.h.
12445 (emacs_no_realloc_allocator): New static constant.
12446 (emacs_readlink): New function.
fdb61804
PE
12447 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12448 ../lib/careadlinkat.h.
d1fdcab7 12449
f84c17c7
SM
124502011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12451
12452 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12453 first non-nil return value).
12454
ef3862ad
JD
124552011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12456
12457 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12458 if not defined (Bug#8403).
12459
376a7006
JB
124602011-04-02 Juanma Barranquero <lekktu@gmail.com>
12461
12462 * xdisp.c (display_count_lines): Remove parameter `start',
12463 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12464 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12465 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12466 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12467 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12468 and thereabouts. All callers changed.
12469 (get_per_char_metric): Remove parameter `f', unused since
12470 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12471
6ca3801d
JM
124722011-04-02 Jim Meyering <meyering@redhat.com>
12473
12474 do not dereference NULL upon failed strdup
12475 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12476 (ns_get_family): Likewise.
12477
d8e2b5ba
JB
124782011-04-02 Juanma Barranquero <lekktu@gmail.com>
12479
12480 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12481
8c74fcbd
JD
124822011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12483
12484 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12485 later (Bug#8403).
12486
7200d79c
SM
124872011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12488
03408648 12489 Add lexical binding.
7200d79c 12490
03408648
SM
12491 * window.c (Ftemp_output_buffer_show): New fun.
12492 (Fsave_window_excursion):
12493 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12494
12495 * lread.c (lisp_file_lexically_bound_p): New function.
12496 (Fload): Bind Qlexical_binding.
12497 (readevalloop): Remove `evalfun' arg.
12498 Bind Qinternal_interpreter_environment.
12499 (Feval_buffer): Bind Qlexical_binding.
12500 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12501 Mark as dynamic.
12502 (syms_of_lread): Declare `lexical-binding'.
12503
12504 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12505
12506 * keyboard.c (eval_dyn): New fun.
12507 (menu_item_eval_property): Use it.
ca105506
SM
12508
12509 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12510
03408648
SM
12511 * fns.c (concat, mapcar1): Accept byte-code-functions.
12512
12513 * eval.c (Fsetq): Handle lexical vars.
12514 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12515 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12516 (FletX, Flet): Obey lexical binding.
12517 (Fcommandp): Handle closures.
12518 (Feval): New `lexical' arg.
12519 (eval_sub): New function extracted from Feval. Use it almost
12520 everywhere where Feval was used. Look up vars in lexical env.
12521 Handle closures.
12522 (Ffunctionp): Move from subr.el.
12523 (Ffuncall): Handle closures.
12524 (apply_lambda): Remove `eval_flags'.
12525 (funcall_lambda): Handle closures and new byte-code-functions.
12526 (Fspecial_variable_p): New function.
12527 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12528 but without exporting it to Lisp.
23aba0ea 12529
23aba0ea 12530 * doc.c (Fdocumentation, store_function_docstring):
03408648 12531 * data.c (Finteractive_form): Handle closures.
23aba0ea 12532
03408648
SM
12533 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12534 interactive spec.
ba83908c 12535
04f2d78b
CB
12536 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12537 New byte-codes.
03408648
SM
12538 (exec_byte_code): New function extracted from Fbyte_code to handle new
12539 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12540
03408648 12541 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12542
03408648 12543 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12544
e2abce01
JB
125452011-03-31 Juanma Barranquero <lekktu@gmail.com>
12546
12547 * xdisp.c (redisplay_internal): Fix prototype.
12548
63696a73 125492011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12550
63696a73 12551 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12552 (try_scrolling): Use it when setting scroll_limit.
12553 Limit scrolling to 100 screen lines.
63696a73
EZ
12554 (redisplay_window): Even when falling back on "recentering",
12555 position point in the window according to scroll-conservatively,
12556 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12557
12558 (try_scrolling): When point is above the window, allow searching
12559 as far as scroll_max, or one screenful, to compute vertical
12560 distance from PT to the scroll margin position. This prevents
12561 try_scrolling from unnecessarily failing when
12562 scroll-conservatively is set to a value slightly larger than the
12563 window height. Clean up the case of PT below the margin at bottom
12564 of window: scroll_max can no longer be INT_MAX. When aggressive
12565 scrolling is in use, don't let point enter the opposite scroll
12566 margin as result of the scroll.
12567 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12568 threshold of 100 lines for never-recentering scrolling.
12569
e4cc2dfc
JB
125702011-03-31 Juanma Barranquero <lekktu@gmail.com>
12571
12572 * dispextern.h (move_it_by_lines):
12573 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12574 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12575 (message_log_check_duplicate): Remove parameters `prev_bol' and
12576 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12577 (redisplay_internal): Remove parameter `preserve_echo_area',
12578 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12579
12580 * indent.c (Fvertical_motion):
12581 * window.c (window_scroll_pixel_based, Frecenter):
12582 Don't pass `need_y_p' to `move_it_by_lines'.
12583
1c470562
SM
125842011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12585
44f230aa
SM
12586 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12587 steal a few bits to be more compact.
12588 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12589 Remove unneeded casts.
12590
1c470562
SM
12591 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12592
888adce9
ZK
125932011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12594
12595 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12596 binding" message (bug#7967).
12597
f838ed7b
PE
125982011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12599
77861b95
PE
12600 Fix more problems found by GCC 4.6.0's static checks.
12601
de6dbc14
PE
12602 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12603 Remove unused local var.
12604
f838ed7b
PE
12605 * editfns.c (Fmessage_box): Remove unused local var.
12606
792c7b2b
PE
12607 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12608 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12609 Omit unused local vars.
c499e557 12610 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12611 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12612 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12613 Omit unused local var.
12614
ba0165e1
PE
12615 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12616 Don't assume string length fits in int.
32ad8845 12617 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12618 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12619
3c59b4c9
PE
12620 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12621 instead of alloca (Bug#8344).
12622
a3eed478 12623 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12624 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12625
eb4d412d
PE
12626 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12627
1658b401
PE
12628 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12629 concerns.
12630
12631 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12632
12633 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12634
9a2c6e05
PE
12635 * keyboard.c (syms_of_keyboard): Use the same style as later
12636 in this function when indexing through an array. This also
12637 works around GCC bug 48267.
12638
03d0a109
PE
12639 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12640
44f730c8
PE
12641 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12642
fe75f926
PE
12643 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12644 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12645
ffa8c828
PE
12646 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12647 This avoids undefined behavior on integer overflow, and is a bit
12648 more convenient anyway since it is compared to a size_t variable.
12649
c5101a77
PE
12650 Variadic C functions now count arguments with size_t, not int.
12651 This avoids an unnecessary limitation on 64-bit machines, which
12652 caused (substring ...) to crash on large vectors (Bug#8344).
12653 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12654 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12655 All variadic functions and their callers changed accordingly.
c5101a77
PE
12656 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12657 * data.c (arith_driver, float_arith_driver): Likewise.
12658 * editfns.c (general_insert_function): Likewise.
12659 * eval.c (struct backtrace.nargs, interactive_p)
12660 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12661 (funcall_lambda, mark_backtrace): Likewise.
12662 * fns.c (concat): Likewise.
12663 * frame.c (x_set_frame_parameters): Likewise.
12664 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12665 0 if not found, not -1. All callers changed.
12666
dd3f25f7
PE
12667 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12668 (stack_copy_size): Now size_t, not int.
12669 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12670
461c2ab9
JB
126712011-03-28 Juanma Barranquero <lekktu@gmail.com>
12672
12673 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12674 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12675 All callers changed.
12676
12677 * lisp.h (multibyte_char_to_unibyte):
12678 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12679 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12680 * character.h (CHAR_TO_BYTE8):
12681 * cmds.c (internal_self_insert):
12682 * editfns.c (general_insert_function):
12683 * keymap.c (push_key_description):
12684 * search.c (Freplace_match):
12685 * xdisp.c (message_dolog, set_message_1): All callers changed.
12686
f6d62986
SM
126872011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12688
12689 * keyboard.c (safe_run_hook_funcall): New function.
12690 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12691 don't set the hook to nil, but remove the offending function instead.
12692 (Qcommand_hook_internal): Remove, unused.
12693 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12694 Vcommand_hook_internal.
12695
12696 * eval.c (enum run_hooks_condition): Remove.
12697 (funcall_nil, funcall_not): New functions.
12698 (run_hook_with_args): Call each function through a `funcall' argument.
12699 Remove `cond' argument, now redundant.
12700 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12701 (Frun_hook_with_args_until_failure): Adjust accordingly.
12702 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12703
1db5b1ad
JB
127042011-03-28 Juanma Barranquero <lekktu@gmail.com>
12705
12706 * dispextern.h (string_buffer_position): Remove declaration.
12707
12708 * print.c (strout): Remove parameter `multibyte', unused since
12709 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12710
12711 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12712 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12713 All callers changed.
12714
12715 * w32.c (_wsa_errlist): Use braces for struct initializers.
12716
12717 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12718 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12719 All callers changed.
12720 (string_buffer_position): Likewise. Also, make static (it's never
12721 used outside xdisp.c).
12722 (cursor_row_p): Remove parameter `w', unused since
12723 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12724 (decode_mode_spec): Remove parameter `precision', introduced during
12725 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12726 All callers changed.
12727
5ffb62aa
JD
127282011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12729
12730 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12731
461c2ab9 127322011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12733
12734 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12735 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12736 (ns_update_auto_hide_menu_bar): New functions.
12737 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12738 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12739 ns_constrain_all_frames.
12740 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12741 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12742
5c380ffb
JD
127432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12744
12745 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12746
9af30bdf
GM
127472011-03-27 Glenn Morris <rgm@gnu.org>
12748
12749 * syssignal.h: Replace RETSIGTYPE with void.
12750 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12751 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12752 Replace SIGTYPE with void everywhere.
12753 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12754 * s/template.h (SIGTYPE): Remove commented out definition.
12755
e2abce01
JB
127562011-03-26 Eli Zaretskii <eliz@gnu.org>
12757
12758 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12759 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12760
f868cd8a
JB
127612011-03-26 Juanma Barranquero <lekktu@gmail.com>
12762
59eb0929
JB
12763 * w32.c (read_unc_volume): Use parameter `henum', instead of
12764 global variable `wget_enum_handle'.
12765
12766 * keymap.c (describe_vector): Remove parameters `indices' and
12767 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12768 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12769
f868cd8a
JB
12770 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12771
12772 * keyboard.c (timer_check): Remove parameter `do_it_now',
12773 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12774 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12775 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12776
12777 * keyboard.c (read_char):
12778 * w32menu.c (w32_menu_display_help):
12779 * xmenu.c (show_help_event, menu_help_callback):
12780 Adjust calls to `show_help_echo'.
12781
12782 * gtkutil.c (xg_maybe_add_timer):
12783 * keyboard.c (readable_events):
12784 * process.c (wait_reading_process_output):
12785 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12786
12787 * insdel.c (adjust_markers_gap_motion):
12788 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12789 (gap_left, gap_right): Don't call it.
12790
2ecf6fdb
CY
127912011-03-25 Chong Yidong <cyd@stupidchicken.com>
12792
12793 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12794 incurred during fontification.
12795
6b1f9ba4
JB
127962011-03-25 Juanma Barranquero <lekktu@gmail.com>
12797
12798 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12799 (DEFVAR_PER_BUFFER): Don't pass it.
12800
12801 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12802 (scrolling_window): Don't pass it.
12803
0f4a96b5
JB
128042011-03-25 Juanma Barranquero <lekktu@gmail.com>
12805
12806 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12807
12808 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12809 and `suffix'.
12810 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12811 of variables specific to SELinux and computation of `encoded_absname'.
12812
12813 * image.c (XPutPixel): Remove unused variable `height'.
12814
12815 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12816
12817 * unexw32.c (get_section_info): Remove unused variable `section'.
12818
12819 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12820 (system_process_attributes): Remove unused variable `sess'.
12821 (sys_read): Remove unused variable `err'.
12822
12823 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12824 (w32_wnd_proc): Remove unused variable `isdead'.
12825 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12826 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12827 (x_create_tip_frame): Remove unused variable `tem'.
12828
12829 * w32inevt.c (w32_console_read_socket):
12830 Remove unused variable `no_events'.
12831
12832 * w32term.c (x_draw_composite_glyph_string_foreground):
12833 Remove unused variable `width'.
12834
1149507c
JB
128352011-03-24 Juanma Barranquero <lekktu@gmail.com>
12836
12837 * w32term.c (x_set_glyph_string_clipping):
12838 Don't pass uninitialized region to CombineRgn.
12839
9c88f339
JB
128402011-03-23 Juanma Barranquero <lekktu@gmail.com>
12841
12842 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12843 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12844 (Fx_close_connection): Remove unused variable `i'.
12845
12846 * w32font.c (w32font_draw): Return number of glyphs.
12847 (w32font_open_internal): Remove unused variable `i'.
12848 (w32font_driver): Add missing initializer.
12849
12850 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12851 (fill_in_menu): Remove unused variable `items_added'.
12852
12853 * w32term.c (last_mouse_press_frame): Remove static global variable.
12854 (w32_clip_to_row): Remove unused variable `f'.
12855 (x_delete_terminal): Remove unused variable `i'.
12856
12857 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12858 (NOTHING): Remove unused static global variable.
12859 (uniscribe_check_otf): Remove unused variable `table'.
12860 (uniscribe_font_driver): Add missing initializers.
12861
dee091a3
JD
128622011-03-23 Julien Danjou <julien@danjou.info>
12863
12864 * term.c (Fsuspend_tty, Fresume_tty):
12865 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12866 * window.c (temp_output_buffer_show):
12867 * insdel.c (signal_before_change):
12868 * frame.c (Fhandle_switch_frame):
12869 * fileio.c (Fdo_auto_save):
12870 * emacs.c (Fkill_emacs):
12871 * editfns.c (save_excursion_restore):
12872 * cmds.c (internal_self_insert):
12873 * callint.c (Fcall_interactively):
12874 * buffer.c (Fkill_all_local_variables):
12875 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12876 Use Frun_hooks.
0f4a96b5 12877 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12878 unconditionally since it does the check itself.
dee091a3 12879
2c520ab5 128802011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12881
c9c49752
PE
12882 Fix more problems found by GCC 4.5.2's static checks.
12883
8abc3f12
PE
12884 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12885 the first time through the loop, since we know p0 < p1 then.
12886 This also avoids a gcc -Wstrict-overflow warning.
12887
a2d26660
PE
12888 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12889 leading to a memory leak, possible in functions like
12890 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12891 of objects (Bug#8318).
a2d26660 12892
916c72e9
PE
12893 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12894 that could (at least in theory) be that large.
12895
19ab8a18
PE
12896 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12897 This is less likely to overflow, and avoids undefined behavior if
12898 overflow does occur. All callers changed. Use strtoul to scan
12899 for the unsigned long integer.
b7cbbd6f
PE
12900 (pint2hrstr): Simplify and tune code slightly.
12901 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12902
f0641eff
PE
12903 * scroll.c (do_scrolling): Work around GCC bug 48228.
12904 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12905
7f650bb9
PE
12906 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12907 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12908 (validate_x_resource_name): Simplify count usage.
12909 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12910
37dd57d1
PE
12911 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12912 fail (Bug#8306).
81e56e61 12913
699979fc 12914 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12915
401bf9b4
PE
12916 * process.c (Fmake_network_process): Use socklen_t, not int,
12917 where POSIX says socklen_t is required in portable programs.
12918 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12919 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12920 (Fmake_network_process, server_accept_connection):
12921 (wait_reading_process_output, read_process_output):
12922 Likewise.
12923
b93aacde
PE
12924 * process.c: Rename or move locals to avoid shadowing.
12925 (list_processes_1, Fmake_network_process):
12926 (read_process_output_error_handler, exec_sentinel_error_handler):
12927 Rename or move locals.
4dc343ee 12928 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12929 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12930 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12931 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12932 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12933
af8a867c 12934 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12935 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12936 Include tparam.h instead, since it declares them.
af8a867c
PE
12937 * cm.h (PC): Remove extern decl; tparam.h now does this.
12938 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12939 * terminfo.c: Include tparam.h, to check interfaces.
12940 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12941 (tparam): Adjust signature to match interface in tparam.h;
12942 this removes some undefined behavior. Check that outstring and len
12943 are zero, which they always are with Emacs.
12944 * tparam.h (PC, BC, UP): New extern decls.
12945
0248044d 12946 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12947 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12948
8ff096c1 12949 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12950 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12951 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12952 (ftfont_list): Remove unused local.
49eaafba
PE
12953 (get_adstyle_property, ftfont_pattern_entity):
12954 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12955 Rename locals to avoid shadowing.
8ff096c1 12956
e2be39f6
PE
12957 * xfont.c (xfont_list_family): Mark var as initialized.
12958
c9735e30
PE
12959 * xml.c (make_dom): Now static.
12960
8f5201ae
PE
12961 * composite.c (composition_compute_stop_pos): Rename local to
12962 avoid shadowing.
b246f932
PE
12963 (composition_reseat_it): Remove unused locals.
12964 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12965 (composition_update_it): Mark var as initialized.
11b61122
PE
12966 (find_automatic_composition): Mark vars as initialized,
12967 with a FIXME (Bug#8290).
8f5201ae 12968
760fbc2c
PE
12969 character.h: Rename locals to avoid shadowing.
12970 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12971 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12972 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12973 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12974 to avoid shadowing.
12975
ff08eb85
PE
12976 * textprop.c (property_change_between_p): Remove; unused.
12977
fc7bf025
PE
12978 * intervals.c (interval_start_pos): Now static.
12979
235d7abc
PE
12980 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12981
44f230aa
SM
12982 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12983 Rename locals to avoid shadowing.
3e7d6594 12984
50060332
PE
12985 * sound.c (wav_play, au_play, Fplay_sound_internal):
12986 Fix pointer signedness.
d01f234b 12987 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12988 (wav_play): Initialize a variable to 0, to prevent undefined
12989 behavior (Bug#8278).
50060332 12990
c4fc4e30
PE
12991 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12992
918436ed
PE
12993 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12994
c939f91b
PE
12995 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12996 clobbering (Bug#8298).
b9c7f648
PE
12997 * sysdep.c (sys_subshell): Likewise.
12998 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12999
6bd8c144
PE
13000 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13001 This should get cleaned up, so that child_setup has the
13002 same signature on all platforms.
13003
7710357c 13004 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13005 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13006
c59da222
CY
130072011-03-22 Chong Yidong <cyd@stupidchicken.com>
13008
13009 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13010 not to be necessary, and produces flickering.
13011
66b87493
GM
130122011-03-20 Glenn Morris <rgm@gnu.org>
13013
13014 * config.in: Remove file.
13015
45b6f6d5
JB
130162011-03-20 Juanma Barranquero <lekktu@gmail.com>
13017
13018 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13019 are now in src/globals.h.
13020 (syms_of_minibuf): Remove spurious & from previous change.
13021
cd394be1 130222011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13023
13024 * minibuf.c (completing-read-function): New variable.
13025 (completing-read-default): Rename from completing-read.
13026 (completing-read): Call completing-read-function.
13027
b14e3e21
CY
130282011-03-19 Juanma Barranquero <lekktu@gmail.com>
13029
13030 * xfaces.c (Fx_load_color_file):
13031 Read color file from absolute filename (bug#8250).
13032
f2b726e6
JB
130332011-03-19 Juanma Barranquero <lekktu@gmail.com>
13034
13035 * makefile.w32-in: Update dependencies.
13036
09f6ff02
EZ
130372011-03-17 Eli Zaretskii <eliz@gnu.org>
13038
13039 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13040
29a6015a
PE
130412011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13042
a3a6c54e
PE
13043 Fix more problems found by GCC 4.5.2's static checks.
13044
b766f867
PE
13045 * process.c (make_serial_process_unwind, send_process_trap):
13046 (sigchld_handler): Now static.
13047
be02381c
PE
13048 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13049 That way, the code declares only the vars that it needs.
13050 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13051 * s/cygwin.h (PTY_ITERATION): Likewise.
13052 * s/darwin.h (PTY_ITERATION): Likewise.
13053 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13054
57048744
PE
13055 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13056 * process.c (allocate_pty): Don't declare stb unless it's needed.
13057
7914961c 13058 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13059 (CONSTANTLIM): Remove; unused.
13060 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13061 Define only if needed.
7914961c 13062
b3967b18
PE
13063 * unexelf.c (unexec): Name an expression,
13064 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13065 Use a different way to cause a compilation error if anyone uses
13066 n rather than nn, a way that does not involve shadowing.
73366a00 13067 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13068
29a6015a
PE
13069 * deps.mk (unexalpha.o): Remove; unused.
13070
43cfc33e 13071 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13072 * unexec.h: New file.
ce701a33
PE
13073 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13074 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13075 Depend on unexec.h.
13076 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13077 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13078 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13079 Change as necessary to match prototype in unexec.h.
ce701a33 13080
01f44d5a
PE
13081 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13082 shadowing.
4f63c6bb 13083 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13084
a6670b0b
PE
13085 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13086 Rename locals to avoid shadowing.
13087
cef2010d 13088 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13089 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13090
d4d7173a
PE
13091 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13092
f08b802a
PE
13093 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13094 warning when compiling print.c.
13095
3ddb0639
PE
13096 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13097 instead of using an uninitialized var.
5ad03b97 13098 (font_sort_entities): Mark var as initialized.
3ddb0639 13099
170a2692
PE
13100 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13101
e663c700
PE
13102 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13103 pointers to constants.
89bc529a 13104 (font_parse_fcname): Remove unused vars.
7b81e2d0 13105 (font_delete_unmatched): Now static.
ea838e10 13106 (font_get_spec): Remove; unused.
13a547c6
PE
13107 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13108 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13109 Rename or move locals to avoid shadowing.
e663c700 13110
2a80c887 13111 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13112 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13113
1384fa33 13114 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13115 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13116
8b2c52e9
PE
13117 * alloc.c (mark_backtrace): Move decl from here ...
13118 * lisp.h: ... to here, so that it can be checked.
13119
475545b5 13120 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13121 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13122 (lisp_indirect_variable): Name an expression,
13123 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13124 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13125
b1349114 13126 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13127 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13128 Use const pointer when appropriate.
b1349114 13129
a2928364
PE
13130 * lisp.h (get_system_name, get_operating_system_release):
13131 Move decls here, to check interfaces.
13132 * process.c (get_operating_system_release): Move decl to lisp.h.
13133 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13134 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13135 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13136 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13137 (Fformat_time_string, Fencode_time, Finsert_char):
13138 (Ftranslate_region_internal, Fformat):
13139 Rename or remove local vars to avoid shadowing.
9710023e 13140 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13141
a415e694
PE
13142 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13143 avoid shadowing.
13144
8ef4622d
PE
13145 * lisp.h (eassert): Check that the argument compiles, even if
13146 ENABLE_CHECKING is not defined.
13147
946f9a5b
PE
13148 * data.c (Findirect_variable): Name an expression, to avoid
13149 gcc -Wbad-function-cast warning.
112396d6 13150 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13151 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13152 (Fmake_variable_buffer_local, Fmake_local_variable):
13153 Mark variables as initialized.
52746918 13154 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13155
e5aab7e7 13156 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13157 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13158 Rename locals to avoid shadowing.
dff45157
PE
13159 (mark_stack): Move local variables into the #ifdef region where
13160 they're used.
7bc26fdb
PE
13161 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13162 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13163 needed otherwise.
13164 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13165 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13166 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13167
e5aab7e7
PE
13168 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13169 avoids undefined behavior in theory.
13170
4da60324
PE
13171 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13172
88043301
PE
13173 Use functions, not macros, for up- and down-casing (Bug#8254).
13174 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13175 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13176 to use the following functions instead of these macros.
13177 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13178 EMACS_INT, since callers assume the returned value fits in int.
13179 (upcase1): Likewise, for UPCASE_TABLE.
13180 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13181 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13182 the race-condition problem in the old DOWNCASE.
88043301 13183
19ed5445
PE
13184 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13185 Rename locals to avoid shadowing.
13186 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13187 (regex_compile, re_search_2, re_match_2_internal):
13188 Remove unused local vars.
952db0d7
PE
13189 (FREE_VAR): Rewrite so as not to use empty "else",
13190 which gcc can warn about.
da053e48 13191 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13192 (RETALLOC_IF): Define only if needed.
13193 (WORDCHAR_P): Likewise. This one is never needed, but is used
13194 only in a comment talking about a compiler bug, so put inside
13195 the #if 0 of that comment.
13196 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13197 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13198 Remove; unused.
19ed5445 13199
1f3561e4 13200 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13201 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13202 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13203
ded6f8f7
PE
13204 * search.c (simple_search): Remove unused var.
13205
dbd37a95
PE
13206 * dired.c (compile_pattern): Move decl from here ...
13207 * lisp.h: ... to here, so that it can be checked.
13208 (struct re_registers): New forward decl.
13209
7e47afad
PE
13210 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13211
85f24f61
PE
13212 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13213 All uses changed.
13214 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13215 Rename locals to avoid shadowing.
5671df8f 13216 (Fvertical_motion): Mark locals as initialized.
85f24f61 13217
181aa2be 13218 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13219 (casify_region): Mark local as initialized.
181aa2be 13220
930d429c
PE
13221 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13222
7082eac6
PE
13223 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13224 New macros, so that the caller can use some names other than
13225 gcpro1, gcpro2, etc.
13226 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13227 of the new macros.
13228 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13229 argument, for consistency with GCPRO2_VAR, etc: it is now the
13230 prefix of the variable, not the variable itself. All uses
13231 changed.
38b2c076
PE
13232 * dired.c (directory_files_internal, file_name_completion):
13233 Rename locals to avoid shadowing.
13234
15206ed9
PE
13235 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13236 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13237 dired.c's scmp function, had undefined behavior.
13238 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13239 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13240 * buffer.h: ... to here, because these macros use current_buffer,
13241 and the new implementation with inline functions needs to have
13242 current_buffer in scope now, rather than later when the macros
13243 are used.
13244 (downcase, upcase1): New static inline functions.
13245 (DOWNCASE, UPCASE1): Reimplement using these functions.
13246 This avoids undefined behavior in expressions like
13247 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13248 from race conditions in accessing the global variables
13249 case_temp1 and case_temp2.
13250 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13251 * lisp.h (case_temp1, case_temp2): Remove their decls.
13252 * character.h (ASCII_CHAR_P): Move from here ...
13253 * lisp.h: ... to here, so that the inline functions mentioned
13254 above can use them.
13255
4a6bea26
PE
13256 * dired.c (directory_files_internal_unwind): Now static.
13257
f14b7e14
PE
13258 * fileio.c (file_name_as_directory, directory_file_name):
13259 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13260 Now static.
2893f146
PE
13261 (file_name_as_directory): Use const pointers when appropriate.
13262 (Fexpand_file_name): Likewise. In particular, newdir might
13263 point at constant storage, so make it a const pointer.
fd4ead52 13264 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13265 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13266 signedness issues.
f839df0c
PE
13267 (Fset_file_times, Finsert_file_contents, auto_save_error):
13268 Rename locals to avoid shadowing.
f14b7e14 13269
5716756e 13270 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13271 (Ftry_completion, Fall_completions): Rename or remove locals
13272 to avoid shadowing.
5716756e 13273
b4c3046a
PE
13274 * marker.c (bytepos_to_charpos): Remove; unused.
13275
b45db522
PE
13276 * lisp.h (verify_bytepos, count_markers): New decls,
13277 so that gcc does not warn that these functions aren't declared.
13278
85876d07
PE
13279 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13280 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13281 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13282 (copy_text): Remove unused local var.
85876d07 13283
03d78a21 13284 * filelock.c (within_one_second): Now static.
b3dd38ab 13285 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13286
5df8f01b
PE
13287 * buffer.c (fix_overlays_before): Mark locals as initialized.
13288 (fix_start_end_in_overlays): Likewise. This function should be
13289 simplified by using pointers-to-pointers, but that's a different
13290 matter.
b1d876f1 13291 (switch_to_buffer_1): Now static.
8f54f30a
PE
13292 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13293 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13294
a70072c9 13295 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13296 Fix pointer signedness issue.
edced198
PE
13297 (sys_subshell): Mark local as volatile if checking for lint,
13298 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13299 (MAXPATHLEN): Define only if needed.
a70072c9 13300
a0977c44
PE
13301 * process.c (serial_open, serial_configure): Move decls from here ...
13302 * systty.h: ... to here, so that they can be checked.
13303
a884fdcc
PE
13304 * fns.c (get_random, seed_random): Move extern decls from here ...
13305 * lisp.h: ... to here, so that they can be checked.
13306
604efe86 13307 * sysdep.c (reset_io): Now static.
b8950c94 13308 (wait_for_termination_signal): Remove; unused.
604efe86 13309
38fc62d9
PE
13310 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13311 (copy_keymap_item, append_key, push_text_char_description):
13312 Now static.
1004a21a 13313 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13314 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13315 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13316 (describe_map_tree):
13317 Rename locals to avoid shadowing.
38fc62d9 13318
2f2650da
PE
13319 * keyboard.c: Declare functions static if they are not used elsewhere.
13320 (echo_char, echo_dash, cmd_error, top_level_2):
13321 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13322 (read_char, kbd_buffer_get_event, make_lispy_position):
13323 (make_lispy_event, make_lispy_movement, apply_modifiers):
13324 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13325 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13326 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13327 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13328 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13329
a053e86c 13330 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13331 (mark_kboards): Move decl here ...
13332 * alloc.c (mark_kboards): ... from here.
a053e86c 13333
4752793e
PE
13334 * lisp.h (force_auto_save_soon): New decl.
13335
74f10ca7 13336 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13337 (DEFINE_DUMMY_FUNCTION): New macro.
13338 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13339 Use it.
c03cd23f
PE
13340 (main): Add casts to avoid warnings
13341 if GCC considers string literals to be constants.
74f10ca7 13342
022e70d4
PE
13343 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13344
59d6fe83
PE
13345 * dbusbind.c: Pointer signedness fixes.
13346 (xd_signature, xd_append_arg, xd_initialize):
13347 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13348 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13349 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13350 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13351
78320123
PE
13352 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13353 if GCC considers string literals to be constants.
49cebcca 13354 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13355
35ac2a97
SM
133562011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13357
fb103ca9
SM
13358 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13359 (print_preprocess, print_object): New macro to fix last change.
13360
35ac2a97
SM
13361 * print.c (print_preprocess): Don't forget font objects.
13362
62973b41
JB
133632011-03-16 Juanma Barranquero <lekktu@gmail.com>
13364
13365 * emacs.c (USAGE3): Doc fixes.
13366
0e48bb22
AS
133672011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13368
13369 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13370 structure.
13371
7684e57b
JB
133722011-03-14 Juanma Barranquero <lekktu@gmail.com>
13373
13374 * lisp.h (VWindow_system, Qfile_name_history):
13375 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13376 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13377 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13378
13379 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13380 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13381
13382 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13383 * w32console.c (detect_input_pending, read_input_pending)
13384 (encode_terminal_code):
13385 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13386 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13387 (w32_system_caret_y, Qfile_name_history):
13388 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13389 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13390 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13391 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13392 * w32proc.c (Qlocal, report_file_error):
13393 * w32term.c (Vwindow_system, updating_frame):
13394 * w32uniscribe.c (initialized, uniscribe_font_driver):
13395 Remove unneeded extern declarations.
13396
2aa46d6c
CY
133972011-03-14 Chong Yidong <cyd@stupidchicken.com>
13398
c96bbc66 13399 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13400
cffc6f3b
CY
134012011-03-13 Chong Yidong <cyd@stupidchicken.com>
13402
13403 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13404 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13405 These macros can no longer be used for assignment.
13406
44f230aa
SM
13407 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13408 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13409 (record_buffer_markers, fetch_buffer_markers): New functions for
13410 recording and fetching special buffer markers.
13411 (set_buffer_internal_1, set_buffer_temp): Use them.
13412
13413 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13414
13415 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13416
13417 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13418 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13419
13420 * xdisp.c (hscroll_window_tree):
13421 (reconsider_clip_changes): Use PT instead of BUF_PT.
13422
d251f04b
EZ
134232011-03-13 Eli Zaretskii <eliz@gnu.org>
13424
13425 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13426 $(EMACS_ROOT)/lib/intprops.h.
13427
f0c77cd1
PE
134282011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13429
3eca4629
PE
13430 Fix more problems found by GCC 4.5.2's static checks.
13431
7c86ee98
PE
13432 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13433 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13434 (xg_free_frame_widgets): Make it clear that a local variable is
13435 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13436 (gdk_window_get_screen): Make it clear that this macro is needed
13437 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13438 (int_gtk_range_get_value): New function, which avoids a diagnostic
13439 from gcc -Wbad-function-cast.
13440 (xg_set_toolkit_scroll_bar_thumb): Use it.
13441 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13442 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13443 (get_utf8_string, xg_get_file_with_chooser):
13444 Rename locals to avoid shadowing.
13445 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13446
41729b81
PE
13447 * xgselect.c (xg_select): Remove unused var.
13448
f0c77cd1
PE
13449 * image.c (four_corners_best): Mark locals as initialized.
13450 (gif_load): Initialize transparent_p to zero (Bug#8238).
13451 Mark another local as initialized.
ec6cf4c6 13452 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13453
ce0ad53d 13454 * image.c (clear_image_cache): Now static.
d5d5a617 13455 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13456 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13457 (x_edge_detection): Remove unnecessary cast that
13458 gcc -Wbad-function-cast diagnoses.
2037898d 13459 (gif_load): Fix pointer signedness.
6ae141d6
PE
13460 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13461 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13462
33383987 134632011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13464
d32df629
PE
13465 Improve quality of tests for time stamp overflow.
13466 For example, without this patch (encode-time 0 0 0 1 1
13467 1152921504606846976) returns the obviously-bogus value (-948597
13468 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13469 reports time overflow. See
13470 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13471 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13472 * editfns.c: Include limits.h and intprops.h.
13473 (TIME_T_MIN, TIME_T_MAX): New macros.
13474 (time_overflow): Move earlier, to before first use.
13475 (hi_time, lo_time): New functions, for an accurate test for
13476 out-of-range times.
13477 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13478 (Fget_internal_run_time): Don't assume time_t fits in int.
13479 (make_time): Use list2 instead of Fcons twice.
13480 (Fdecode_time): More accurate test for out-of-range times.
13481 (check_tm_member): New function.
13482 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13483 (lisp_time_argument): Don't rely on undefined left-shift and
13484 right-shift behavior when checking for time stamp overflow.
8be6f318 13485
fe31d94c
PE
13486 * editfns.c (time_overflow): New function, refactoring common code.
13487 (Fformat_time_string, Fdecode_time, Fencode_time):
13488 (Fcurrent_time_string): Use it.
13489
8be6f318
PE
13490 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13491 * dired.c (make_time): Move to ...
13492 * editfns.c (make_time): ... here.
13493 * systime.h: Note the move.
13494
09d9db2c 134952011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13496
126bc0dc
YM
13497 * fringe.c (update_window_fringes): Remove unused variables.
13498
c47cbdfd
YM
13499 * unexmacosx.c (copy_data_segment): Also copy __got section.
13500 (Bug#8223)
13501
7ac80be9
EZ
135022011-03-12 Eli Zaretskii <eliz@gnu.org>
13503
c96bbc66 13504 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13505 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13506 Constify `char *' arguments and their references according to
13507 prototypes in tparam.h.
13508
ecb0f94d 13509 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13510
7ac80be9
EZ
13511 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13512 Adapt all references accordingly.
13513
13514 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13515
ef1fd07e
TT
135162011-03-11 Tom Tromey <tromey@redhat.com>
13517
13518 * buffer.c (syms_of_buffer): Remove obsolete comment.
13519
7ef4b50c
EZ
135202011-03-11 Eli Zaretskii <eliz@gnu.org>
13521
13522 * termhooks.h (encode_terminal_code): Declare prototype.
13523
13524 * msdos.c (encode_terminal_code): Don't declare prototype.
13525
13526 * term.c (encode_terminal_code): Now external again, used by
13527 w32console.c and msdos.c.
13528
44f230aa
SM
13529 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13530 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13531
4b1ec863 135322011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13533
1714f52b 13534 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13535
4b1ec863
PE
13536 * fringe.c (update_window_fringes): Mark locals as initialized
13537 (Bug#8227).
13538 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13539
524c7aa6
PE
13540 * alloc.c (mark_fringe_data): Move decl from here ...
13541 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13542 to check its interface.
13543 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13544
a5c0af81 13545 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13546 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13547 (fontset_font): Mark local as initialized.
a9a06e0b 13548 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13549
b4716021
PE
13550 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13551
811e9bac 13552 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13553 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13554 (x_own_selection, Fx_disown_selection_internal): Rename locals
13555 to avoid shadowing.
13556 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13557
7e3ab302
PE
13558 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13559 so that the caller can use some name other than gcpro1.
13560 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13561 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13562 (Fx_backspace_delete_keys_p):
13563 Use them to avoid shadowing, and rename vars to avoid shadowing.
13564 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13565 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13566 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13567 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13568 Remove unused locals.
7e3ab302
PE
13569 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13570 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13571 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13572 macros.
f78faa98 13573
e2b13473
PE
13574 * xterm.h (x_mouse_leave): New decl.
13575
77f23912
PE
13576 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13577 Remove unused functions.
cdf4ba58
PE
13578 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13579 (x_calc_absolute_position): Now static.
7411c686 13580 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13581 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13582 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13583 unless they are used.
38d0b34a
PE
13584 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13585 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13586 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13587 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13588 (x_error_catcher, x_connection_closed, x_error_handler):
13589 (x_error_quitter, xembed_send_message, x_iconify_frame):
13590 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13591 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13592 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13593
44f230aa
SM
13594 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13595 Rename or move locals to avoid shadowing.
6b463e58 13596 (tty_defined_color, merge_face_heights): Now static.
5967d051 13597 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13598 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13599 does not deduce is never used uninitialized.
73719eba
PE
13600 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13601 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13602
426994c3 13603 * terminal.c (store_terminal_param): Now static.
5489860b 13604
032f1620 13605 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13606 (set_frame_menubar): Remove unused local.
d4323972 13607 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13608 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13609 since they might point to immutable storage.
281585b0
PE
13610 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13611 since it's unused otherwise.
032f1620 13612
367c19e5 13613 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13614 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13615 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13616 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13617 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13618 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13619 does not deduce are never used uninitialized.
70739cbe 13620
07b48fa9
PE
13621 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13622
8868a238 13623 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13624 * window.c (window_loop, size_window):
13625 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13626
7e5cf297 13627 * window.c (display_buffer): Now static.
d6550a9f
PE
13628 (size_window): Mark variables that gcc -Wuninitialized
13629 does not deduce are never used uninitialized.
a586633d
PE
13630 * window.h (check_all_windows): New decl, to forestall
13631 gcc -Wmissing-prototypes diagnostic.
5b555da1 13632 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13633
f6095868
PE
13634 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13635 shadowing.
13636 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13637 Include <limits.h>.
13638 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13639 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13640 (load_charset_map): Mark variables that gcc -Wuninitialized
13641 does not deduce are never used uninitialized.
53df7c11 13642 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13643
f38b440c
PE
13644 * coding.c (coding_set_source, coding_set_destination):
13645 Use "else { /* comment */ }" rather than "else /* comment */;"
13646 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13647 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13648 a block, when the outer 'i' will do.
13649 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13650 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13651 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13652 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13653 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13654 Rename locals to avoid shadowing.
13655 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13656 * coding.c (emacs_mule_char, encode_invocation_designation):
13657 Now static, since they're not used elsewhere.
413bb2db 13658 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13659 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13660 (decode_coding_emacs_mule): Mark variables that gcc
13661 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13662 (detect_coding_iso_2022): Initialize a local variable that might
13663 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13664 this initialization is needed. (Bug#8211)
5f58e762
PE
13665 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13666 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13667 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13668 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13669 Remove unused macros.
f38b440c 13670
232b38b9 13671 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13672 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13673 * character.c (string_count_byte8): Likewise.
232b38b9 13674
fb90da1b
PE
13675 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13676 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13677
fb93dbc2
PE
13678 * chartab.c (copy_sub_char_table): Now static, since it's not used
13679 elsewhere.
5c156ace
PE
13680 (sub_char_table_ref_and_range, char_table_ref_and_range):
13681 Rename locals to avoid shadowing.
bbcd0949 13682 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13683
7d3b3862 13684 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13685 (BIDI_BOB): Remove unused macro.
7d3b3862 13686
6be7d3da
PE
13687 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13688 deduce are never used uninitialized.
c2ed9c8b 13689 * term.c (encode_terminal_code): Likewise.
6be7d3da 13690
75f8807f 13691 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13692
50938595
PE
13693 * tparam.h: New file.
13694 * term.c, tparam.h: Include it.
13695 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13696 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13697 Move these decls to tparam.h, and make them agree with what
13698 is actually in tparam.c. The previous trick of using incompatible
13699 decls in different modules does not conform to the C standard.
13700 All callers of tparam changed to use tparam's actual API.
13701 * tparam.c (tparam1, tparam, tgoto):
13702 Use const pointers where appropriate.
13703
fbceeba2
PE
13704 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13705 * cm.h (struct cm): Likewise.
13706 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13707 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13708 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13709 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13710 (turn_on_face, init_tty): Likewise.
13711 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13712
7f3f1250
PE
13713 * term.c (term_mouse_position): Rename local to avoid shadowing.
13714
e6ca6543
PE
13715 * alloc.c (mark_ttys): Move decl from here ...
13716 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13717
c40f8d15
AS
137182011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13719
13720 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13721
cfe0661d
JB
137222011-03-09 Juanma Barranquero <lekktu@gmail.com>
13723
13724 * search.c (compile_pattern_1): Remove argument regp, unused since
13725 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13726 (compile_pattern): Don't pass it.
13727
0afb4571
J
137282011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13729
13730 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13731 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13732 for ! HAVE_GTK3.
13733 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13734
13735 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13736
13737 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13738 gdk_window_get_screen, gdk_window_get_geometry,
13739 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13740 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13741 (xg_get_pixbuf_from_pixmap): New function.
13742 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13743 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13744 Call xg_get_pixbuf_from_pixmap instead of
13745 gdk_pixbuf_get_from_drawable.
13746 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13747 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13748 (xg_check_special_colors): Use GtkStyleContext and its functions
13749 for HAVE_GTK3.
13750 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13751 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13752 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13753 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13754 Call gtk_widget_get_preferred_size.
0afb4571
J
13755 (xg_frame_resized): gdk_window_get_geometry only takes 5
13756 parameters.
44f230aa
SM
13757 (xg_win_to_widget, xg_event_is_for_menubar):
13758 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13759 (xg_set_widget_bg): New function.
13760 (delete_cb): New function.
895009e1 13761 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13762 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13763 (xg_set_background_color): Call xg_set_widget_bg.
13764 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13765 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13766 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13767 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13768 if ! HAVE_GTK3.
13769 (update_frame_tool_bar): Call gtk_widget_hide.
13770 (xg_initialize): Use GDK_KEY_g.
13771
13772 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13773 if ! HAVE_GTK3
13774 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13775
13776 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13777 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13778 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13779
1c2cc4ef
JB
137802011-03-08 Juanma Barranquero <lekktu@gmail.com>
13781
13782 * w32xfns.c (select_palette): Check success of RealizePalette against
13783 GDI_ERROR, not zero.
13784
33383987 13785See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13786
13787;; Local Variables:
13788;; coding: utf-8
aac0c6e3
MR
13789;; End:
13790
2f097256 13791 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13792
13793 This file is part of GNU Emacs.
13794
13795 GNU Emacs is free software: you can redistribute it and/or modify
13796 it under the terms of the GNU General Public License as published by
13797 the Free Software Foundation, either version 3 of the License, or
13798 (at your option) any later version.
13799
13800 GNU Emacs is distributed in the hope that it will be useful,
13801 but WITHOUT ANY WARRANTY; without even the implied warranty of
13802 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13803 GNU General Public License for more details.
13804
13805 You should have received a copy of the GNU General Public License
13806 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.