* fns.c (mapcar1): Declare byte as byte, for clarity.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e39e811e
PE
12011-06-18 Paul Eggert <eggert@cs.ucla.edu>
2
b4e50fa0 3 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4 Use much-faster test for byte-length change.
311d5d7c 5 Don't assume string byte-length fits in 'int'.
a4cf38e4 6 Check that character arg fits in 'int'.
85461888 7 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8
c0c1ee9f
PE
9 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10
a498d7f4
PE
11 * fns.c (concat): Catch string overflow earlier.
12 Do not rely on integer wraparound.
13
e39e811e
PE
14 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
15
fadf4e30
PE
162011-06-17 Paul Eggert <eggert@cs.ucla.edu>
17
87830974
PE
18 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
19 * xdisp.c (forward_to_next_line_start)
20 (back_to_previous_visible_line_start)
21 (reseat_at_next_visible_line_start, next_element_from_buffer):
22 Don't arbitrarily truncate the value of 'selective' to int.
23
76031fad
PE
24 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
25
5eb55db9
PE
26 * composite.c: Don't truncate sizes to 'int'.
27 (composition_gstring_p, composition_reseat_it)
28 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
29 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
30 not EMACS_UINT, for indexes.
5eb55db9 31
0703a717
PE
32 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
33
d6202519
PE
34 * buffer.c: Include <verify.h>.
35 (struct sortvec.priority, struct sortstr.priority):
8961a454 36 Now EMACS_INT, not int.
c20998a7 37 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
38 (struct sortstr.size, record_overlay_string)
39 (struct sortstrlist.size, struct sortlist.used):
40 Don't truncate size to int.
41 (record_overlay_string): Check for size-calculation overflow.
d6202519 42 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 43
28177add
PE
442011-06-16 Paul Eggert <eggert@cs.ucla.edu>
45
dd3482fe
PE
46 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
47 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
48 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
49
393d71f3 50 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
51 * fileio.c (Finsert_file_contents):
52 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
53 Remove the old (too-loose) buffer overflow checks.
54 They weren't needed, since make_gap checks for buffer overflow.
55 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
56 The old code merely checked for Emacs fixnum overflow, and relied
57 on undefined (wraparound) behavior. The new code avoids undefined
58 behavior, and also checks for ptrdiff_t and/or size_t overflow.
59
2e6813b0 60 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
61 Tune. Don't use wider integers than needed. Don't use alloca.
62 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 63
599a9e4f
PE
64 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
65
99561444
PE
66 * insdel.c, lisp.h (buffer_overflow): New function.
67 (insert_from_buffer_1, replace_range, replace_range_2):
68 * insdel.c (make_gap_larger):
69 * editfns.c (Finsert_char):
70 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
71
28177add
PE
72 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
73
e69dafad
PE
742011-06-15 Paul Eggert <eggert@cs.ucla.edu>
75
a7af7fde 76 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 77
b1c46f02
PE
78 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
79 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
80
e69dafad
PE
81 * fileio.c: Don't assume EMACS_INT fits in off_t.
82 (emacs_lseek): New static function.
83 (Finsert_file_contents, Fwrite_region): Use it.
84 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
85
566684ea
PE
86 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
87
e6966cd6
PE
88 * fns.c: Don't overflow int when computing a list length.
89 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
90 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
91 truncation on 64-bit hosts. Check for QUIT every
92 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
93 faster and is responsive enough.
94 (Flength): Report an error instead of overflowing an integer.
95 (Fsafe_length): Return a float if the value is not representable
96 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 97 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 98 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 99
dd0b0efb
PE
100 * alloc.c: Check that resized vectors' lengths fit in fixnums.
101 (header_size, word_size): New constants.
102 (allocate_vectorlike): Don't check size overflow here.
103 (allocate_vector): Check it here instead, since this is the only
104 caller of allocate_vectorlike that could cause overflow.
105 Check that the new vector's length is representable as a fixnum.
106
86fe5cfe
PE
107 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
108 The previous code was bogus. For example, next_almost_prime (32)
109 returned 39, which is undesirable as it is a multiple of 3; and
110 next_almost_prime (24) returned 25, which is a multiple of 5 so
111 why was the code bothering to check for multiples of 7?
112
80e88859
PE
113 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
114
4a2f0ad6
PE
115 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
116
f66c7cf8
PE
117 Variadic C functions now count arguments with ptrdiff_t.
118 This partly undoes my 2011-03-30 change, which replaced int with size_t.
119 Back then I didn't know that the Emacs coding style prefers signed int.
120 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
121 were being counted with int, which may truncate counts on 64-bit
122 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
123 * lisp.h (struct Lisp_Subr.function.aMANY)
124 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
125 Arg counts are now ptrdiff_t, not size_t.
126 All variadic functions and their callers changed accordingly.
127 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
128 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
129 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
130 * callint.c (Fcall_interactively): Check arg count for overflow,
131 to avoid potential buffer overrun. Use signed char, not 'int',
132 for 'varies' array, so that we needn't bother to check its size
133 calculation for overflow.
134 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
135 * eval.c (apply_lambda):
136 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
137 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
138 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
139
a1759b76
PE
140 * callint.c (Fcall_interactively): Don't use index var as event count.
141
d96be9fc
PE
142 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
143 * mem-limits.h (SIZE): Remove; no longer used.
144
a690a978 145 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 146
578c21e6
PE
147 Remove unnecessary casts.
148 * xterm.c (x_term_init):
149 * xfns.c (x_set_border_pixel):
150 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
151 These aren't needed now that we assume ANSI C.
152
96f53c6c
PE
153 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
154 It's more likely to cause problems (due to unsigned overflow)
155 than to cure them.
156
83c77d31
PE
157 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
158
ee2079f1
PE
159 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
160
6da65536
PE
161 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
162
7147c4a4
PE
163 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
164
193e32d9
PE
165 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
166
e5533da6
PE
167 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
168
9910e595
PE
169 GLYPH_CODE_FACE returns EMACS_INT, not int.
170 * dispextern.h (merge_faces):
171 * xfaces.c (merge_faces):
01103c44
PE
172 * xdisp.c (get_next_display_element, next_element_from_display_vector):
173 Don't assume EMACS_INT fits in int.
9910e595 174
2638320e
PE
175 * character.h (CHAR_VALID_P): Remove unused parameter.
176 * fontset.c, lisp.h, xdisp.c: All uses changed.
177
045eb8d9
PE
178 * editfns.c (Ftranslate_region_internal): Omit redundant test.
179
c1f134b5
PE
180 * fns.c (concat): Minor tuning based on overflow analysis.
181 This doesn't fix any bugs. Use int to hold character, instead
182 of constantly refetching from Emacs object. Use XFASTINT, not
183 XINT, for value known to be a character. Don't bother comparing
184 a single byte to 0400, as it's always less.
185
395fcb93 186 * floatfns.c (Fexpt):
327eeec8
PE
187 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
188
abbd3d23
PE
189 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
190 for characters.
191
684a03ef
PE
192 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
193
0fed43f3
PE
194 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
195 Without this fix, on a 64-bit host (aset S 0 4294967386) would
196 incorrectly succeed when S was a string, because 4294967386 was
197 truncated before it was used.
198
8fd02eb7
PE
199 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
200 Otherwise, an out-of-range integer could cause undefined behavior
201 on a 64-bit host.
202
f8c86b69
PE
203 * composite.c: Use int, not EMACS_INT, for characters.
204 (fill_gstring_body, composition_compute_stop_pos): Use int, not
205 EMACS_INT, for values that are known to be in character range.
206 This doesn't fix any bugs but is the usual style inside Emacs and
207 may generate better code on 32-bit machines.
208
34206dd2
PE
209 Make sure a 64-bit char is never passed to ENCODE_CHAR.
210 This is for reasons similar to the recent CHAR_STRING fix.
211 * charset.c (Fencode_char): Check that character arg is actually
212 a character. Pass an int to ENCODE_CHAR.
213 * charset.h (ENCODE_CHAR): Verify that the character argument is no
214 wider than 'int', as a compile-time check to prevent future regressions
215 in this area.
216
c5958d4c 217 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
218
219 Make sure a 64-bit char is never passed to CHAR_STRING.
220 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
221 by silently ignoring the top 32 bits, allowing some values
222 that were far too large to be valid characters.
223 * character.h: Include <verify.h>.
224 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
225 arguments are no wider than unsigned, as a compile-time check
226 to prevent future regressions in this area.
227 * data.c (Faset):
01103c44 228 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
229 (Fsubst_char_in_region):
230 * fns.c (concat):
231 * xdisp.c (decode_mode_spec_coding):
232 Adjust to CHAR_STRING's new requirement.
233 * editfns.c (Finsert_char, Fsubst_char_in_region):
234 * fns.c (concat): Check that character args are actually
235 characters. Without this test, these functions did the wrong
236 thing with wildly out-of-range values on 64-bit hosts.
237
d37ca623
PE
238 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
239 These casts should not be needed on 32-bit hosts, either.
240 * keyboard.c (read_char):
241 * lread.c (Fload): Remove casts to unsigned.
242
ea204efb
PE
243 * lisp.h (UNSIGNED_CMP): New macro.
244 This fixes comparison bugs on 64-bit hosts.
245 (ASCII_CHAR_P): Use it.
246 * casefiddle.c (casify_object):
01103c44 247 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
248 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
249 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
250 * dispextern.h (FACE_FROM_ID):
251 * keyboard.c (read_char): Use UNSIGNED_CMP.
252
41cb286c
PE
253 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
254 not to EMACS_INT, to avoid GCC warning.
255
4a1b9832
PE
256 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
257
55daad71
PE
258 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
259 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
260 isn't needed on 32-bit machines.
8f95c75c 261
01103c44
PE
262 * buffer.c (Fgenerate_new_buffer_name):
263 Use EMACS_INT for count, not int.
0ceccced 264 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
265
266 * data.c (Qcompiled_function): Now static.
267
c6f072e7
PE
268 * window.c (window_body_lines): Now static.
269
20ce5912
PE
270 * image.c (gif_load): Rename local to avoid shadowing.
271
9c4c5f81
PE
272 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
273 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
274 * alloc.c (make_save_value): Integer argument is now of type
275 ptrdiff_t, not int.
276 (mark_object): Use ptrdiff_t, not int.
277 * lisp.h (pD): New macro.
278 * print.c (print_object): Use it.
279
c0c5c8ae
PE
280 * alloc.c: Use EMACS_INT, not int, to count objects.
281 (total_conses, total_markers, total_symbols, total_vector_size)
282 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
283 (total_free_floats, total_floats, total_free_intervals)
284 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
285 Now EMACS_INT, not int. All uses changed.
286 (Fgarbage_collect): Compute overall total using a double, so that
287 integer overflow is less likely to be a problem. Check for overflow
288 when converting back to an integer.
5a25e253
PE
289 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
290 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
291 These were 'int' variables that could overflow on 64-bit hosts;
292 they were never used, so remove them instead of repairing them.
211a0b2a 293 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
294 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
295 Previously, this ceilinged at INT_MAX, but that doesn't work on
296 64-bit machines.
e46bb31a 297 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 298
c78baabf 299 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 300 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
301 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
302 when a (possibly-narrower) signed value would do just as well.
303 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 304
c9d624c6
PE
305 * alloc.c: Catch some string size overflows that we were missing.
306 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
307 for convenience in STRING_BYTES_MAX.
308 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
309 The definition here is exact; the one in lisp.h was approximate.
310 (allocate_string_data): Check for string overflow. This catches
311 some instances we weren't catching before. Also, it catches
312 size_t overflow on (unusual) hosts where SIZE_MAX <= min
313 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
314 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 315
c9d624c6
PE
316 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
317 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
318 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
319
353032ce
PE
320 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
321
2bccce07
PE
322 * alloc.c (Fmake_string): Check for out-of-range init.
323
0ac30604
SM
3242011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
325
326 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
327
c195f2de
JD
3282011-06-14 Jan Djärv <jan.h.d@swipnet.se>
329
330 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
331 xg_get_default_scrollbar_width.
332
333 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
334 (int_gtk_range_get_value): Move to the scroll bar part of the file.
335 (style_changed_cb): Call update_theme_scrollbar_width and call
336 x_set_scroll_bar_default_width and xg_frame_set_char_size for
337 all frames (Bug#8505).
338 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
339 Call gtk_window_set_resizable if HAVE_GTK3.
340 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
341 and height if HAVE_GTK3 (Bug#8505).
342 (scroll_bar_width_for_theme): New variable.
343 (update_theme_scrollbar_width): New function.
344 (xg_get_default_scrollbar_width): Move code to
345 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
346 (xg_initialize): Call update_theme_scrollbar_width.
347
348 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
349
350 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
351
e10ac9f1
MR
3522011-06-12 Martin Rudalics <rudalics@gmx.at>
353
354 * frame.c (make_frame): Call other_buffer_safely instead of
355 other_buffer.
356
357 * window.c (temp_output_buffer_show): Call display_buffer with
358 second argument Vtemp_buffer_show_specifiers and reset latter
359 immediately after the call.
360 (Vtemp_buffer_show_specifiers): New variable.
361 (auto_window_vscroll_p, next_screen_context_lines)
362 (Vscroll_preserve_screen_position): Remove leading asterisks from
363 doc-strings.
364
2d3c217e 3652011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 366
7b7f97e8 367 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
368 * buffer.c (Qclone_number): Remove for now, as it's unused.
369 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
370 (record_buffer): Remove unused local.
371 * frame.c (other_visible_frames, frame_buffer_list): Now static.
372 (set_frame_buffer_list): Remove; unused.
373 * frame.h (other_visible_frames): Remove decl.
374 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
375 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
376 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
377 if HAVE_GPM.
378 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
379 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
380 Define only if HAVE_GPM.
381 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
382 (update_hints_inhibit): Remove; never set. All uses removed.
383 * widgetprv.h (emacsFrameClassRec): Remove decl.
384 * window.c (delete_deletable_window): Now returns void, since it
385 wasn't returning anything.
386 (compare_window_configurations): Remove unused locals.
387 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
388 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
389 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
390 the same widths as pointers. This follows up on the 2011-05-06 patch.
391 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
392 * xterm.h: Likewise.
393 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
394
1384b89e
JB
3952011-06-12 Juanma Barranquero <lekktu@gmail.com>
396
397 * makefile.w32-in: Update dependencies.
398 (LISP_H): Add lib/intprops.h.
399
1100a63c
CY
4002011-06-11 Chong Yidong <cyd@stupidchicken.com>
401
402 * image.c (gif_load): Add animation frame delay to the metadata.
403 (syms_of_image): Use DEFSYM. New symbol `delay'.
404
6198ccd0
MR
4052011-06-11 Martin Rudalics <rudalics@gmx.at>
406
407 * window.c (delete_deletable_window): Re-add.
408 (Fset_window_configuration): Rewrite to handle dead buffers and
409 consequently deletable windows.
410 (window_tree, Fwindow_tree): Remove. Supply functionality in
411 window.el.
412 (compare_window_configurations): Simplify code.
413
b6e3633c
AS
4142011-06-11 Andreas Schwab <schwab@linux-m68k.org>
415
1ab0dee5
AS
416 * image.c (imagemagick_load_image): Fix type mismatch.
417 (Fimagemagick_types): Likewise.
418
b6e3633c
AS
419 * window.h (replace_buffer_in_windows): Declare.
420
9397e56f
MR
4212011-06-11 Martin Rudalics <rudalics@gmx.at>
422
423 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
424 Qclone_number. Remove external declaration of Qdelete_window.
425 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
426 code.
427 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
428 Qbuffer_list_update_hook if allowed.
429 (Fother_buffer): Rewrite doc-string. Major rewrite for new
430 buffer list implementation.
431 (other_buffer_safely): New function.
432 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
433 calls to replace_buffer_in_windows and
434 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
435 if allowed.
436 (record_buffer): Inhibit quitting and rewrite using quittable
437 functions. Run Qbuffer_list_update_hook if allowed.
438 (Frecord_buffer, Funrecord_buffer): New functions.
439 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
440 switch-to-buffer to window.el.
441 (bury-buffer): Move to window.el.
442 (Vbuffer_list_update_hook): New variable.
443
444 * lisp.h (other_buffer_safely): Add prototype in buffer.c
445 section.
446
447 * window.h (resize_frame_windows): Move up in code.
448 (Fwindow_frame): Remove EXFUN.
449 (replace_buffer_in_all_windows): Remove prototype.
450 (replace_buffer_in_windows_safely): Add prototype.
451
452 * window.c: Declare Qdelete_window static again. Move down
453 declaration of select_count.
454 (Fnext_window, Fprevious_window): Rewrite doc-strings.
455 (Fother_window): Move to window.el.
456 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
457 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
458 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
459 window.el.
460 (replace_buffer_in_windows): Implement by calling
461 Qreplace_buffer_in_windows.
462 (replace_buffer_in_all_windows): Remove with some functionality
463 moved into replace_buffer_in_windows_safely.
464 (replace_buffer_in_windows_safely): New function.
465 (select_window_norecord, select_frame_norecord): Move in front
466 of run_window_configuration_change_hook. Remove now obsolete
467 declarations.
468 (Fset_window_buffer): Rewrite doc-string. Call
469 Qrecord_window_buffer.
470 (keys_of_window): Move binding for other-window to window.el.
471
b50691aa
CY
4722011-06-11 Chong Yidong <cyd@stupidchicken.com>
473
474 * dispextern.h (struct image): Replace data member, whose int_val
475 and ptr_val fields were not used by anything, with a single
476 lisp_val object.
477
478 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
479 (gif_clear_image, gif_load, imagemagick_load_image)
480 (gs_clear_image, gs_load): Callers changed.
481
3f754b86
PE
4822011-06-10 Paul Eggert <eggert@cs.ucla.edu>
483
cca69397
PE
484 * buffer.h: Include <time.h>, for time_t.
485 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
486
109e28d0
PE
487 Fix minor problems found by static checking.
488
60737f02
PE
489 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
490
4b66faf3
PE
491 Make identifiers static if they are not used in other modules.
492 * data.c (Qcompiled_function, Qframe, Qvector):
493 * image.c (QimageMagick, Qsvg):
494 * minibuf.c (Qmetadata):
495 * window.c (resize_window_check, resize_root_window): Now static.
496 * window.h (resize_window_check, resize_root_window): Remove decls.
497
109e28d0
PE
498 * window.c (window_deletion_count, delete_deletable_window):
499 Remove; unused.
46a4ce9e
PE
500 (window_body_lines): Now static.
501 (Fdelete_other_windows_internal): Mark vars as initialized.
502 Make sure 'resize_failed' is initialized.
503 (run_window_configuration_change_hook): Rename local to avoid shadowing.
504 (resize_window_apply): Remove unused local.
505 * window.h (delete_deletable_window): Remove decl.
506
109e28d0 507 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
508 (imagemagick_load_image): Fix pointer signedness problem by changing
509 last arg from unsigned char * to char *. All uses changed.
510 Also, fix a local for similar reasons.
511 Remove unused locals. Remove locals to avoid shadowing.
512 (fn_rsvg_handle_free): Remove; unused.
513 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 514 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 515
3f754b86
PE
516 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
517
2547adb1
CY
5182011-06-10 Chong Yidong <cyd@stupidchicken.com>
519
520 * image.c (gif_load): Fix omitted cast error introduced by
521 2011-06-06 change.
522
2c8e37d4
MR
5232011-06-10 Martin Rudalics <rudalics@gmx.at>
524
525 * window.h (resize_proportionally, orig_total_lines)
526 (orig_top_line): Remove from window structure.
527 (set_window_height, set_window_width, change_window_heights)
528 (Fdelete_window): Remove prototypes.
529 (resize_frame_windows): Remove duplicate declaration.
530
440a42e3
EZ
5312011-06-10 Eli Zaretskii <eliz@gnu.org>
532
533 * window.h (resize_frame_windows, resize_window_check)
534 (delete_deletable_window, resize_root_window)
535 (resize_frame_windows): Declare prototypes.
536
537 * window.c (resize_window_apply): Make definition be "static" to
538 match the prototype.
539
562dd5e9
MR
5402011-06-10 Martin Rudalics <rudalics@gmx.at>
541
542 * window.c: Remove declarations of Qwindow_size_fixed,
543 window_min_size_1, window_min_size_2, window_min_size,
544 size_window, window_fixed_size_p, enlarge_window, delete_window.
545 Remove static from declaration of Qdelete_window, it's
546 temporarily needed by Fbury_buffer.
547 (replace_window): Don't assign orig_top_line and
548 orig_total_lines.
549 (Fdelete_window, delete_window): Remove. Window deletion is
550 handled by window.el.
551 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
552 Fdelete_window calls with calls to Qdelete_window.
553 (Fdelete_other_windows): Remove. Deleting other windows is
554 handled by window.el.
555 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
556 handled in window.el.
557 (window_min_size_2, window_min_size_1, window_min_size): Remove.
558 Window minimum sizes are handled in window.el.
559 (shrink_windows, size_window, set_window_height)
560 (set_window_width, change_window_heights, window_height)
561 (window_width, CURBEG, CURSIZE, enlarge_window)
562 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
563 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
564 handled in window.el.
565 (make_dummy_parent): Rename to make_parent_window and give it a
566 second argument horflag.
567 (make_window): Don't set resize_proportionally any more.
568 (Fsplit_window): Remove. Windows are split in window.el.
569 (save_restore_action, save_restore_orig_size)
570 (shrink_window_lowest_first, save_restore_orig_size): Remove.
571 Resize mini windows in window.el.
572 (grow_mini_window, shrink_mini_window): Implement by calling
573 Qresize_root_window_vertically, resize_window_check and
574 resize_window_apply.
575 (saved_window, Fset_window_configuration, save_window_save): Do
576 not handle orig_top_line, orig_total_lines, and
577 resize_proportionally.
578 (window_min_height, window_min_width): Move to window.el.
579 (keys_of_window): Move bindings for delete-other-windows,
580 split-window, delete-window and enlarge-window to window.el.
581
582 * buffer.c: Temporarily extern Qdelete_window.
583 (Fbury_buffer): Temporarily call Qdelete_window instead of
584 Fdelete_window (Fbury_buffer will move to window.el soon).
585
586 * frame.c (set_menu_bar_lines_1): Remove code handling
587 orig_top_line and orig_total_lines.
588
589 * dispnew.c (adjust_frame_glyphs_initially): Don't use
590 set_window_height but set heights directly.
591 (change_frame_size_1): Use resize_frame_windows.
592
593 * xdisp.c (init_xdisp): Don't use set_window_height but set
594 heights directly.
595
596 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
597 resize_frame_windows instead of change_window_heights and run
598 run_window_configuration_change_hook.
599
600 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
601 instead of change_window_heights and run
602 run_window_configuration_change_hook.
603
1a13852e
MR
6042011-06-09 Martin Rudalics <rudalics@gmx.at>
605
606 * window.c (replace_window): Rename second argument REPLACEMENT to
607 NEW. New third argument SETFLAG. Rewrite.
608 (delete_window, make_dummy_parent): Call replace_window with
609 third argument 1.
610 (window_list_1): Move down in code.
611 (run_window_configuration_change_hook): Move set_buffer part
612 before select_frame_norecord part in order to unwind correctly.
613 Rename count1 to count.
614 (recombine_windows, delete_deletable_window, resize_root_window)
615 (Fdelete_other_windows_internal)
616 (Frun_window_configuration_change_hook, make_parent_window)
617 (resize_window_check, resize_window_apply, Fresize_window_apply)
618 (resize_frame_windows, Fsplit_window_internal)
619 (Fdelete_window_internal, Fresize_mini_window_internal): New
620 functions.
621 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
622
f3d1777e
MR
6232011-06-08 Martin Rudalics <rudalics@gmx.at>
624
496e208e
MR
625 * window.h (window): Add some new members to window structure -
626 normal_lines, normal_cols, new_total, new_normal, clone_number,
627 splits, nest, prev_buffers, next_buffers.
628 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 629 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 630
f3d1777e
MR
631 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
632 Remove.
496e208e
MR
633 (make_dummy_parent): Set new members of windows structure.
634 (make_window): Move down in code. Handle new members of window
635 structure.
636 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
637 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
638 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
639 (Fset_window_prev_buffers, Fwindow_next_buffers)
640 (Fset_window_next_buffers, Fset_window_clone_number): New
641 functions.
642 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
643 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
644 Doc-string fixes.
645 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
646 Argument WINDOW can be now internal window too.
647 (Fwindow_use_time): Move up in code.
648 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
649 Rewrite doc-string.
650 (Fset_window_configuration, saved_window)
651 (Fcurrent_window_configuration, save_window_save): Handle new
652 members of window structure.
b9e809c2
MR
653 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
654 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
655 (syms_of_window): New Lisp objects Qrecord_window_buffer,
656 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
657 Qget_mru_window, Qresize_root_window,
658 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
659 Qauto_buffer_name; staticpro them.
f3d1777e 660
abde8f8c
MR
6612011-06-07 Martin Rudalics <rudalics@gmx.at>
662
663 * window.c (Fwindow_total_size, Fwindow_left_column)
664 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
665 (Fwindow_list_1): New functions.
666 (window_box_text_cols): Replace with window_body_cols.
667 (Fwindow_width, Fscroll_left, Fscroll_right): Use
668 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
669 (delete_window, Fset_window_configuration): Call
670 delete_all_subwindows with window as argument.
671 (delete_all_subwindows): Take a window as argument and not a
672 structure. Rewrite.
190b47e6
MR
673 (window_loop): Remove handling of GET_LRU_WINDOW and
674 GET_LARGEST_WINDOW.
675 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
676
677 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
678 window_box_text_cols. delete_all_subwindows now takes a
679 Lisp_Object as argument.
abde8f8c
MR
680
681 * indent.c (compute_motion, Fcompute_motion): Use
682 window_body_cols instead of window_box_text_cols.
683
fa8a67e6
MR
684 * frame.c (delete_frame): Call delete_all_subwindows with root
685 window as argument.
686
a54e3482
DC
6872011-06-07 Daniel Colascione <dan.colascione@gmail.com>
688
689 * fns.c (Fputhash): Document return value.
690
60002bf5
CY
6912011-06-06 Chong Yidong <cyd@stupidchicken.com>
692
693 * image.c (gif_load): Implement gif89a spec "no disposal" method.
694
0c671da6 6952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 696
b862a52a 697 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 698
be44ca6c
PE
699 Check for overflow when converting integer to cons and back.
700 * charset.c (Fdefine_charset_internal, Fdecode_char):
701 Use cons_to_unsigned to catch overflow.
702 (Fencode_char): Use INTEGER_TO_CONS.
703 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
704 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
705 * data.c (long_to_cons, cons_to_long): Remove.
706 (cons_to_unsigned, cons_to_signed): New functions.
707 These signal an error for invalid or out-of-range values.
708 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
709 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
710 * font.c (Ffont_variation_glyphs):
711 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
712 * lisp.h: Include <intprops.h>.
713 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
714 (cons_to_signed, cons_to_unsigned): New decls.
715 (long_to_cons, cons_to_long): Remove decls.
716 * undo.c (record_first_change): Use INTEGER_TO_CONS.
717 (Fprimitive_undo): Use CONS_TO_INTEGER.
718 * xfns.c (Fx_window_property): Likewise.
719 * xselect.c: Include <limits.h>.
720 (x_own_selection, selection_data_to_lisp_data):
721 Use INTEGER_TO_CONS.
722 (x_handle_selection_request, x_handle_selection_clear)
723 (x_get_foreign_selection, Fx_disown_selection_internal)
724 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
725 (lisp_data_to_selection_data): Use cons_to_unsigned.
726 (x_fill_property_data): Use cons_to_signed.
727 Report values out of range.
728
d1f3d2af
PE
729 Check for buffer and string overflow more precisely.
730 * buffer.h (BUF_BYTES_MAX): New macro.
731 * lisp.h (STRING_BYTES_MAX): New macro.
732 * alloc.c (Fmake_string):
733 * character.c (string_escape_byte8):
734 * coding.c (coding_alloc_by_realloc):
735 * doprnt.c (doprnt):
736 * editfns.c (Fformat):
737 * eval.c (verror):
738 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
739 since they may not be the same number.
740 * editfns.c (Finsert_char):
741 * fileio.c (Finsert_file_contents):
742 Likewise for BUF_BYTES_MAX.
743
dd52fcea
PE
744 * image.c: Use ptrdiff_t, not int, for sizes.
745 (slurp_file): Switch from int to ptrdiff_t.
746 All uses changed.
747 (slurp_file): Check that file size fits in both size_t (for
748 malloc) and ptrdiff_t (for sanity and safety).
749
7f9bbdbb
PE
750 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
751 if b->modtime has its maximal value.
752
dfe18f82
PE
753 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
754
84acfcf0
PE
755 Don't assume time_t can fit into int.
756 * buffer.h (struct buffer.modtime): Now time_t, not int.
757 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
758 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
759
ccd9a01a
PE
760 Minor fixes for signed vs unsigned integers.
761 * character.h (MAYBE_UNIFY_CHAR):
762 * charset.c (maybe_unify_char):
763 * keyboard.c (read_char, reorder_modifiers):
764 XINT -> XFASTINT, since the integer must be nonnegative.
765 * ftfont.c (ftfont_spec_pattern):
766 * keymap.c (access_keymap, silly_event_symbol_error):
767 XUINT -> XFASTINT, since the integer must be nonnegative.
768 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
769 since it makes no difference and we prefer signed.
770 * keyboard.c (record_char): Use XUINT when all the neighbors do.
771 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
772 nonnegative.
773
d6d100dd
SM
7742011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
775
776 * window.h (Fwindow_frame): Declare.
777
2b6148e4
PE
7782011-06-06 Paul Eggert <eggert@cs.ucla.edu>
779
780 * alloc.c: Simplify handling of large-request failures (Bug#8800).
781 (SPARE_MEMORY): Always define.
782 (LARGE_REQUEST): Remove.
783 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
784
f230ecc9
MR
7852011-06-06 Martin Rudalics <rudalics@gmx.at>
786
727e958e
MR
787 * lisp.h: Move EXFUNS for Fframe_root_window,
788 Fframe_first_window and Fset_frame_selected_window to window.h.
789
790 * window.h: Move EXFUNS for Fframe_root_window,
791 Fframe_first_window and Fset_frame_selected_window here from
792 lisp.h.
793
794 * frame.c (Fwindow_frame, Fframe_first_window)
795 (Fframe_root_window, Fframe_selected_window)
796 (Fset_frame_selected_window): Move to window.c.
797 (Factive_minibuffer_window): Move to minibuf.c.
798 (Fother_visible_frames_p): New function.
799
800 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
801
f230ecc9
MR
802 * window.c (decode_window, decode_any_window): Move up in code.
803 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
804 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
805 (Fwindow_buffer): Move up and rewrite doc-string.
806 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
807 (Fwindow_prev): New functions.
727e958e
MR
808 (Fwindow_frame): Move here from frame.c. Accept any window as
809 argument.
810 (Fframe_root_window, Fframe_first_window)
811 (Fframe_selected_window): Move here from frame.c. Accept frame
812 or arbitrary window as argument. Update doc-strings.
813 (Fminibuffer_window): Move up in code.
814 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
815 (Fset_frame_selected_window): Move here from frame.c.
816 Marginal rewrite.
727e958e
MR
817 (Fselected_window, select_window, Fselect_window): Move up in
818 code. Minor doc-string fixes.
f230ecc9 819
4d09bcf6
PE
8202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
821
822 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
823 Do not assume that spare memory exists; that assumption is valid
824 only if SYSTEM_MALLOC.
825 (LARGE_REQUEST): New macro, so that the issue of large requests
826 is separated from the issue of spare memory.
827
810928a2
AS
8282011-06-05 Andreas Schwab <schwab@linux-m68k.org>
829
172418ad
AS
830 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
831 format. (Bug#8806)
832
43f862f7
AS
833 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
834
810928a2
AS
835 * xfns.c (x_set_scroll_bar_default_width): Move declarations
836 before statements.
837
a059fe24
JD
8382011-06-05 Jan Djärv <jan.h.d@swipnet.se>
839
840 * gtkutil.c (xg_get_default_scrollbar_width): New function.
841
842 * gtkutil.h: Declare xg_get_default_scrollbar_width.
843
844 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
845 min width by calling x_set_scroll_bar_default_width (Bug#8505).
846
989bf368
JB
8472011-06-05 Juanma Barranquero <lekktu@gmail.com>
848
849 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
850
4b80f674
CY
8512011-06-04 Chong Yidong <cyd@stupidchicken.com>
852
853 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
854 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
855 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
856 New error handlers.
4b80f674
CY
857 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
858 Obey Vx_select_enable_clipboard_manager. Catch errors in
859 x_clipboard_manager_save (Bug#8779).
860 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 861 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 862
99a33b77 8632011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
864
865 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
866
99a33b77 8672011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
868
869 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
870 in the current matrix if keep_current_p is non-zero.
871
8264569d
EZ
8722011-06-04 Eli Zaretskii <eliz@gnu.org>
873
874 * bidi.c (bidi_level_of_next_char): Fix last change.
875
57f97249
EZ
8762011-06-03 Eli Zaretskii <eliz@gnu.org>
877
fec2107c 878 Support bidi reordering of text covered by display properties.
57f97249 879
fec2107c
EZ
880 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
881 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
882 (bidi_cache_search, bidi_cache_iterator_state)
883 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
884 (bidi_level_of_next_char, bidi_move_to_visually_next):
885 Support character positions inside a run of characters covered by a
fec2107c
EZ
886 display string.
887 (bidi_paragraph_init, bidi_resolve_explicit_1)
888 (bidi_level_of_next_char): Call bidi_fetch_char and
889 bidi_fetch_char_advance instead of FETCH_CHAR and
890 FETCH_CHAR_ADVANCE.
891 (bidi_init_it): Initialize new members.
892 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
893 definitions.
894 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
895 instead of using explicit *_CHAR codes.
d6d100dd
SM
896 (bidi_resolve_explicit, bidi_resolve_weak):
897 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
898 bidirectional text is supported only in multibyte buffers.
899 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
900 it to initialize the frame_window_p member of struct bidi_it.
901 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
902 (bidi_resolve_explicit, bidi_resolve_weak)
903 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
904 bidi_it->nchars is non-positive.
905 (bidi_level_of_next_char): Don't try to lookup the cache for the
906 next/previous character if nothing is cached there yet, or if we
907 were just reseat()'ed to a new position.
c40e2fb2 908
0e14fe90
EZ
909 * xdisp.c (set_cursor_from_row): Set start and stop points
910 according to the row's direction when priming the loop that looks
911 for the glyph on which to display cursor.
912 (single_display_spec_intangible_p): Function deleted.
913 (display_prop_intangible_p): Reimplement to call
914 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
915 Accept 3 additional arguments needed by handle_display_spec.
916 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
917 values: lists, `(when COND...)' forms, etc.
918 (single_display_spec_string_p): Support property values that are
919 lists with the argument STRING its top-level element.
920 (display_prop_string_p): Fix the condition for processing a
921 property that is a list to be consistent with handle_display_spec.
fec2107c 922 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
923 last portion of handle_display_prop.
924 (compute_display_string_pos): Accept additional argument
925 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
926 value of a `display' property is a "replacing spec".
927 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
928 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
929 the display property, but just return a value indicating whether
930 the display property will replace the characters it covers.
931 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
932 frame_window_p members of struct bidi_it.
d6d100dd
SM
933 (compute_display_string_pos, compute_display_string_end):
934 New functions.
fec2107c
EZ
935 (push_it): Accept second argument POSITION, where pop_it should
936 jump to continue iteration.
937 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 938
fec2107c
EZ
939 * keyboard.c (adjust_point_for_property): Adjust the call to
940 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
941
942 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
943 (bidi_init_it): Update prototypes.
944 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
945 (compute_display_string_pos, compute_display_string_end):
946 Declare prototypes.
fec2107c
EZ
947 (struct bidi_it): New members nchars and disp_pos. ch_len is now
948 EMACS_INT.
fc6f18ce 949
40087514 9502011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 951
57f53182
PE
952 Malloc failure behavior now depends on size of allocation.
953 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
954 * lisp.h: Change signatures accordingly.
955 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
956 All callers changed. (Bug#8762)
957
958 * gnutls.c: Use Emacs's memory allocators.
959 Without this change, the gnutls library would invoke malloc etc.
960 directly, which causes problems on non-SYNC_INPUT hosts, and which
961 runs afoul of improving memory_full behavior. (Bug#8761)
962 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
963 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
964 xfree instead of the default malloc, realloc, free.
965 (Fgnutls_boot): No need to check for memory allocation failure,
966 since xmalloc does that for us.
967
ac32cd99 968 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
969 * category.c (hash_get_category_set):
970 * ccl.c (ccl_driver):
971 * charset.c (Fdefine_charset_internal):
972 * charset.h (struct charset.hash_index):
973 * composite.c (get_composition_id, gstring_lookup_cache)
974 (composition_gstring_put_cache):
975 * composite.h (struct composition.hash_index):
976 * dispextern.h (struct image.hash):
977 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
978 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
979 (hashfn_equal, hashfn_user_defined, make_hash_table)
980 (maybe_resize_hash_table, hash_lookup, hash_put)
981 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
982 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
983 (Fsxhash, Fgethash, Fputhash, Fmaphash):
984 * image.c (make_image, search_image_cache, lookup_image)
985 (xpm_put_color_table_h):
986 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 987 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
988 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
989 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
990 * alloc.c (allocate_vectorlike):
991 Check for overflow in vector size calculations.
992 * ccl.c (ccl_driver):
993 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
994 * fns.c, image.c: Remove unnecessary static decls that would otherwise
995 need to be updated by these changes.
40087514
PE
996 * fns.c (make_hash_table, maybe_resize_hash_table):
997 Check for integer overflow with large hash tables.
0de4bb68
PE
998 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
999 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1000 (SXHASH_REDUCE): New macro.
1001 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1002 Use it instead of discarding useful hash info with large hash values.
1003 (sxhash_float): New function.
1004 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1005 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1006 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1007 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1008 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1009 Adjust signatures to match updated version of code.
1010 (consing_since_gc): Now EMACS_INT, since a single hash table can
1011 use more than INT_MAX bytes.
1012
698d32e2
DN
10132011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1014
1015 Make it possible to build with GCC-4.6+ -O2 -flto.
1016
1017 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1018
fd6fa53f
SM
10192011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1020
1021 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1022 Call minibuffer-inactive-mode.
1023
864db017
JB
10242011-05-31 Juanma Barranquero <lekktu@gmail.com>
1025
1026 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1027 Update dependencies.
1028
2ad0baf4
DN
10292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1030
1031 * data.c (init_data): Remove code for UTS, this system is not
1032 supported anymore.
1033
4fcc2638
DN
10342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1035
1036 Don't force ./temacs to start in terminal mode.
1037
1038 * frame.c (make_initial_frame): Initialize faces in all cases, not
1039 only when CANNOT_DUMP is defined.
1040 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1041
c56e0fd5
DN
10422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1043
1044 * dispnew.c (add_window_display_history): Use const for the string
1045 pointer. Remove declaration, not needed.
1046
333d54da 10472011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1048
55d4c1b2 1049 Use 'inline', not 'INLINE'.
333d54da 1050 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1051 * alloc.c, fontset.c (INLINE): Remove.
1052 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1053 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1054 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1055 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1056 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1057
738db178
DN
10582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1059
1060 Make it possible to run ./temacs.
1061
1062 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1063 syms_of_callproc does the same thing. Remove test for
1064 "initialized", do it in the caller.
1065 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1066
620c53a6
SM
10672011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1068
1069 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1070 (read_minibuf): Use get_minibuffer.
1071 (syms_of_minibuf): Use DEFSYM.
1072 (Qmetadata): New var.
1073 * data.c (Qbuffer): Don't make it static.
1074 (syms_of_data): Use DEFSYM.
1075
e003a292
PE
10762011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1077
1078 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1079 (CCL_CODE_MIN): New macro.
1080
ed008a6d
PE
10812011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1082
3687c2ef
PE
1083 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1084
ed008a6d
PE
1085 * eval.c (Qdebug): Now static.
1086 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1087 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1088 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1089
d66c4c7c
CY
10902011-05-29 Chong Yidong <cyd@stupidchicken.com>
1091
1092 * image.c: Various fixes to ImageMagick code comments.
1093 (Fimagemagick_types): Doc fix.
1094
5fbc2025
PE
10952011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1096
0196f88a
PE
1097 Minor fixes prompted by GCC 4.6.0 warnings.
1098
1099 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1100
5fbc2025
PE
1101 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1102 (x_clipboard_manager_save_all): Move extern decl to ...
1103 * xterm.h: ... here, so that it can be checked for consistency.
1104
1dd3c2d9
CY
11052011-05-29 Chong Yidong <cyd@stupidchicken.com>
1106
1107 * xselect.c (x_clipboard_manager_save_frame)
1108 (x_clipboard_manager_save_all): New functions.
1109 (Fx_clipboard_manager_save): Lisp function deleted.
1110
1111 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1112 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1113
1114 * xterm.h: Update prototype.
1115
5ba6571d
WX
11162011-05-28 William Xu <william.xwl@gmail.com>
1117
1118 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1119 exiting (Bug#8239).
1120
3eaff834
JM
11212011-05-28 Jim Meyering <meyering@redhat.com>
1122
e1900994 1123 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1124 * fns.c (to_uchar): Define.
1125 (crypto_hash_function): Use it to convert some newly-signed
1126 variables to unsigned, to avoid sign-extension bugs. For example,
1127 without this change, (md5 "truc") would evaluate to
1128 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1129 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1130 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1131
0f6990a7
PE
11322011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1133
1134 Integer overflow fixes.
c8a9ca5a 1135
08686060
PE
1136 * dbusbind.c: Serial number integer overflow fixes.
1137 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1138 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1139 to hold a serial number that is too large for a fixnum.
1140 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1141 Check for serial numbers out of range. Decode any serial number
59568bf0 1142 that was so large that it became a float. (Bug#8722)
08686060 1143
2d1fc3c7
PE
1144 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1145 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1146 Use XFASTINT rather than XUINT when numbers are nonnegative.
1147 (xd_append_arg, Fdbus_method_return_internal):
1148 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1149 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1150 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1151 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1152 (Bug#8722)
2d1fc3c7 1153
c8a9ca5a
PE
1154 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1155
519e1d69
PE
1156 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1157
30569699
PE
1158 ccl: add integer overflow checks
1159 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1160 (IN_INT_RANGE): New macros.
1161 (ccl_driver): Use them to check for integer overflow when
1162 decoding a CCL program. Many of the new checks are whether XINT (x)
1163 fits in int; it doesn't always, on 64-bit hosts. The new version
1164 doesn't catch all possible integer overflows, but it's an
847044ea 1165 improvement. (Bug#8719)
30569699 1166
c11285dc
PE
1167 * alloc.c (make_event_array): Use XINT, not XUINT.
1168 There's no need for unsigned here.
1169
fdccd48e
PE
1170 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1171 This follows up to the 2011-05-06 change that substituted uintptr_t
1172 for EMACS_INT. This case wasn't caught back then.
1173
37910ab2
PE
1174 Rework Fformat to avoid integer overflow issues.
1175 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1176 now (part of C89). Include <verify.h>.
1177 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1178 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1179 (Fformat): Avoid the prepass trying to compute sizes; it was only
1180 approximate and thus did not catch overflow reliably. Instead, walk
1181 through the format just once, formatting and computing sizes as we go,
1182 checking for integer overflow at every step, and allocating a larger
1183 buffer as needed. Keep track separately whether the format is
1184 multibyte. Keep only the most-recently calculated precision, rather
1185 than them all. Record whether each argument has been converted to
1186 string. Use EMACS_INT, not int, for byte and char and arg counts.
1187 Support field widths and precisions larger than INT_MAX. Avoid
1188 sprintf's undefined behavior with conversion specifications such as %#d
1189 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1190 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1191 formatting out-of-range floating point numbers with int
1192 formats. (Bug#8668)
1193
2e6578fb
PE
1194 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1195
0ae6bdee
PE
1196 * data.c: Avoid integer truncation in expressions involving floats.
1197 * data.c: Include <intprops.h>.
1198 (arith_driver): When there's an integer overflow in an expression
1199 involving floating point, convert the integers to floating point
1200 so that the resulting value does not suffer from catastrophic
1201 integer truncation. For example, on a 64-bit host (* 4
1202 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1203 Do not rely on undefined behavior after integer overflow.
1204
de883a70
PE
1205 merge count_size_as_multibyte, parse_str_to_multibyte
1206 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1207 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1208 Check for integer overflow.
1209 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1210 since it's now a duplicate of the other. This is more of
1211 a character than a buffer op, so better that it's in character.c.
1212 * fns.c, print.c: Adjust to above changes.
1213
2ff916cb
PE
12142011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1215
1216 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1217
f1b54466
PE
12182011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1219
fb1ac845
PE
1220 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1221 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1222 (x_clipboard_manager_save): Now static.
1223 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1224
f1b54466
PE
1225 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1226 (crypto_hash_function): Now static.
1227 Fix pointer signedness problems. Avoid unnecessary initializations.
1228
a9f737ee
CY
12292011-05-27 Chong Yidong <cyd@stupidchicken.com>
1230
1231 * termhooks.h (Vselection_alist): Make it terminal-local.
1232
1233 * terminal.c (create_terminal): Initialize it.
1234
1235 * xselect.c: Support for clipboard managers.
1236 (Vselection_alist): Move to termhooks.h as terminal-local var.
1237 (LOCAL_SELECTION): New macro.
1238 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1239 (symbol_to_x_atom): Remove gratuitous arg.
1240 (x_handle_selection_request, lisp_data_to_selection_data)
1241 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1242 (x_own_selection, x_get_local_selection, x_convert_selection):
1243 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1244 (some_frame_on_display): Delete unused function.
1245 (Fx_own_selection_internal, Fx_get_selection_internal)
1246 (Fx_disown_selection_internal, Fx_selection_owner_p)
1247 (Fx_selection_exists_p): New optional frame arg.
1248 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1249 (x_handle_selection_clear): Don't treat other terminals with the
1250 same keyboard specially. Use the terminal-local Vselection_alist.
1251 (x_clear_frame_selections): Use Frun_hook_with_args.
1252
1253 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1254
1255 * xterm.h: Add support for those atoms.
1256
e067f0c1
CY
12572011-05-26 Chong Yidong <cyd@stupidchicken.com>
1258
1259 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1260 (converted_selections, conversion_fail_tag): New global variables.
1261 (x_selection_request_lisp_error): Free the above.
1262 (x_get_local_selection): Remove unnecessary code.
1263 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1264 of converted selections stored in converted_selections.
1265 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1266 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1267 (x_convert_selection): New function.
1268 (x_handle_selection_event): Simplify.
1269 (x_get_foreign_selection): Don't ignore incoming requests while
1270 waiting for an answer; this will fail when we implement
1271 SAVE_TARGETS, and seems unnecessary anyway.
1272 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1273 (Vx_sent_selection_functions): Doc fix.
1274
0f4aebc0
LL
12752011-05-26 Leo Liu <sdl.web@gmail.com>
1276
1277 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1278
e61124cd
YM
12792011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1280
1281 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1282
1283 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1284 for fringe update if it has periodic bitmap.
1285 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1286 and fringe_bitmap_periodic_p.
1287
1288 * fringe.c (get_fringe_bitmap_data): New function.
1289 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1290 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1291 row. Mark glyph row for fringe update if periodicity changed.
1292
1293 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1294 for fringe update unless it has periodic bitmap.
1295
f16d9837
KH
12962011-05-25 Kenichi Handa <handa@m17n.org>
1297
1298 * xdisp.c (get_next_display_element): Set correct it->face_id for
1299 a static composition.
1300
e1b90ef6
LL
13012011-05-24 Leo Liu <sdl.web@gmail.com>
1302
1303 * deps.mk (fns.o):
1304 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1305
1306 * fns.c (crypto_hash_function, Fsha1): New function.
1307 (Fmd5): Use crypto_hash_function.
1308 (syms_of_fns): Add Ssha1.
1309
7400048f
PE
13102011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1311
1312 * gnutls.c: Remove unused macros.
1313 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1314 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1315 Remove macros that are defined and never used.
1316 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1317
abb71cf4
CY
13182011-05-22 Chong Yidong <cyd@stupidchicken.com>
1319
1320 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1321 (Fx_get_selection_internal): Minor cleanup.
1322 (Fx_own_selection_internal): Rename arguments for consistency with
1323 select.el.
1324
6307db39
PE
13252011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1326
1327 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1328
f3d4e0a4
CY
13292011-05-22 Chong Yidong <cyd@stupidchicken.com>
1330
1331 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1332
4d8ade89
YM
13332011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1334
1335 * dispnew.c (scrolling_window): Don't exclude the case that the
1336 last enabled row in the desired matrix touches the bottom boundary.
1337
32078c8d
GM
13382011-05-21 Glenn Morris <rgm@gnu.org>
1339
1340 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1341 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1342 and add some more files.
32078c8d 1343
7285dc67
EZ
13442011-05-20 Eli Zaretskii <eliz@gnu.org>
1345
1346 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1347 report_file_error introduced by the change from 2011-05-07.
1348
89d1bd22
PE
13492011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1350
1351 * systime.h (Time): Define only if emacs is defined.
1352 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1353 where the include path doesn't have X11/X.h by default. See
1354 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1355
e23640bb 13562011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1357
1358 * composite.c (find_automatic_composition): Fix previous change.
1359
b9704ad9
GM
13602011-05-20 Glenn Morris <rgm@gnu.org>
1361
1362 * lisp.mk: New file, split from Makefile.in.
1363 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1364 (shortlisp): Remove.
1365 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1366
4a720484
GM
13672011-05-19 Glenn Morris <rgm@gnu.org>
1368
1369 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1370 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1371 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1372 (lisp): Set the order to that of loadup.el.
1373 (shortlisp): Make it a copy of $lisp.
1374 (SOME_MACHINE_LISP): Remove.
1375 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1376 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1377
a28d4396
KH
13782011-05-18 Kenichi Handa <handa@m17n.org>
1379
1380 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1381 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1382 (find_automatic_composition): Mostly rewrite for efficiency.
1383
a2b1fa8e
JB
13842011-05-18 Juanma Barranquero <lekktu@gmail.com>
1385
1386 * makefile.w32-in: Update dependencies.
1387
8e1f5610
CS
13882011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1389
1390 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1391 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1392
7025ee00 13932011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1394
cdfa6eab
PE
1395 Fix some integer overflow issues, such as string length overflow.
1396
06d6db33
PE
1397 * insdel.c (count_size_as_multibyte): Check for string overflow.
1398
2b4560a8
PE
1399 * character.c (lisp_string_width): Check for string overflow.
1400 Use EMACS_INT, not int, for string indexes and lengths; in
1401 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1402 the resulting string length overflows an EMACS_INT; instead,
1403 report a string overflow if no precision given. When checking for
1404 precision exhaustion, use a check that cannot possibly have
1405 integer overflow. (Bug#8675)
1406 * character.h (lisp_string_width): Adjust to new signature.
1407
cb93f9be
PE
1408 * alloc.c (string_overflow): New function.
1409 (Fmake_string): Use it. This doesn't change behavior, but saves
1410 a few bytes and will simplify future changes.
1411 * character.c (string_escape_byte8): Likewise.
1412 * lisp.h (string_overflow): New decl.
1413
1a1f3366
PE
1414 Fixups, following up to the user-interface timestamp change.
1415 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1416 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1417 * msdos.c (mouse_get_pos): Likewise.
1418 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1419 * w32gui.h (Time): Define by including "systime.h" rather than by
1420 declaring it ourselves. (Bug#8664)
1421
d4e3e4d3
PE
1422 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1423 * image.c (clear_image_cache): Likewise.
1424
f6a24d19
PE
1425 * term.c (term_mouse_position): Don't assume time_t wraparound.
1426
08dc5ae6
PE
1427 Be more systematic about user-interface timestamps.
1428 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1429 and sometimes 'EMACS_UINT', to represent these timestamps.
1430 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1431 This makes the code easier to follow, and makes it easier to catch
1432 integer overflow bugs such as Bug#8664.
1433 * frame.c (Fmouse_position, Fmouse_pixel_position):
1434 Use Time, not unsigned long, for user-interface timestamps.
1435 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1436 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1437 * keyboard.h (last_event_timestamp): Likewise.
1438 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1439 * menu.h (xmenu_show): Likewise.
1440 * term.c (term_mouse_position): Likewise.
1441 * termhooks.h (struct input_event.timestamp): Likewise.
1442 (struct terminal.mouse_position_hook): Likewise.
1443 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1444 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1445 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1446 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1447 what it was before.
1448 * menu.h, termhooks.h: Include "systime.h", for Time.
1449
8e55734a
PE
1450 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1451 Don't assume that the difference between two unsigned long values
1452 can fit into an integer. At this point, we know button_down_time
1453 <= event->timestamp, so the difference must be nonnegative, so
1454 there's no need to cast the result if double-click-time is
1455 nonnegative, as it should be; check that it's nonnegative, just in
1456 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1457 apart (about 25 days). (Bug#8664)
8e55734a 1458
841f1b75 1459 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1460 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1461
3e26f69c
PE
1462 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1463 that always fit in int. Use a sentinel instead of a counter, to
1464 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1465 * frame.h (struct frame): Use int for menu_bar_items_used
1466 instead of EMACS_INT, since it always fits in int.
3e26f69c 1467
5cc152c0
PE
1468 * menu.c (grow_menu_items): Check for int overflow.
1469
d89eb65e
PE
1470 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1471
5235bd3e
PE
1472 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1473 Before, the code was not consistent. These values cannot exceed
1474 2**31 - 1 so there's no need to make them unsigned.
1475 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1476 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1477 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1478 as modifiers.
1479 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1480
bc827e23
PE
1481 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1482 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1483 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1484 presumably because the widths might not match.
1485
78eb494e
PE
1486 * window.c (size_window): Avoid needless test at loop start.
1487
04f2d78b
CB
14882011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1489
1490 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1491
d2fc7e3d 14922011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1493
1494 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1495
d2fc7e3d 14962011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1497
1498 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1499 `width' to `bar_area_x' and `bar_area_width', respectively.
1500 (x_scroll_run): Take account of fringe background extension.
1501
04f2d78b
CB
1502 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1503 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1504 `bar_area_width', respectively.
1505 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1506 background extension.
1507
79b70037
GM
15082011-05-10 Jim Meyering <meyering@redhat.com>
1509
1510 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1511
2f142cc5
JB
15122011-05-10 Juanma Barranquero <lekktu@gmail.com>
1513
1514 * image.c (Finit_image_library): Return t for built-in image types,
1515 like pbm and xbm. (Bug#8640)
1516
57679c86
AS
15172011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1518
1519 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1520
888c9e86
EZ
15212011-05-07 Eli Zaretskii <eliz@gnu.org>
1522
b0512a1d
EZ
1523 * w32console.c (Fset_screen_color): Doc fix.
1524 (Fget_screen_color): New function.
1525 (syms_of_ntterm): Defsubr it.
1526
7285dc67
EZ
1527 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1528 unlink the temporary file if Fcall_process didn't create it in the
1529 first place.
1530 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1531 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1532 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1533 cue to call_process_cleanup not to close that handle.
1534
4d3fcc8e
BK
15352011-05-07 Ben Key <bkey76@gmail.com>
1536
1537 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1538 one of two shell specific rules, either bootstrap-temacs-CMD or
1539 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1540 to the previous implementation of the bootstrap-temacs rule.
1541 The bootstrap-temacs-CMD rule is similar to the previous
1542 implementation of the bootstrap-temacs rule except that it
1543 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1544 variable.
1545
1546 These changes, along with some changes to nt/configure.bat,
1547 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1548 earlier fix to add support for --cflags and --ldflags options
1549 that include quotes so that it works whether make uses cmd or
1550 sh as the shell.
1551
b4289b64
MA
15522011-05-06 Michael Albinus <michael.albinus@gmx.de>
1553
1554 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1555 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1556 is a constant.
1557 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1558 a string. Handle both cases.
1559 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1560 (Fdbus_register_method): Use Qinvalid_function.
1561
af4c0e28
JB
15622011-05-06 Juanma Barranquero <lekktu@gmail.com>
1563
1564 * makefile.w32-in: Update dependencies.
1565 (LISP_H): Add inttypes.h and stdin.h.
1566 (PROCESS_H): Add unistd.h.
1567
c51453d9
EZ
15682011-05-06 Eli Zaretskii <eliz@gnu.org>
1569
1570 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1571 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1572
8ff0ac3c 15732011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1574
4c4b566b
PE
1575 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1576
aab2b9b5
PE
1577 * term.c (vfatal): Remove stray call to va_end.
1578 It's not needed and the C Standard doesn't allow it here anyway.
1579
c378da0b
PE
1580 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1581 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1582
288b08c7
PE
1583 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1584 bytes.
1585
e3601888
PE
1586 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1587
db6c0e74
PE
1588 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1589
dd5963ea
PE
1590 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1591
88c9450f
PE
1592 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1593
2f9442b8
PE
1594 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1595
c032b5f8
PE
1596 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1597 * charset.c (Fdefine_charset_internal): Don't initialize
1598 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1599 32-bit int (Bug#8600).
a108c10b
PE
1600
1601 * lread.c (read_integer): Be more consistent with string-to-number.
1602 Use string_to_number to do the actual conversion; this avoids
1603 rounding errors and fixes some other screwups. Without this fix,
1604 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1605 (digit_to_number): Move earlier, for benefit of read_integer.
1606 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1607 not a digit in any supported base. (Bug#8602)
a108c10b 1608
ad5f9eea
PE
1609 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1610
aec1708a
PE
1611 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1612 to match comment at start of function. This also removes a
1613 GCC warning about overflow in a 32+64-bit port.
1614
47be4ab5
PE
1615 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1616
371cac43
PE
1617 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1618 Reported by Stefan Monnier in
1619 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1620 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1621 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1622
d01a7826
PE
1623 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1624 (EMACS_UINTPTR): Likewise, with uintptr_t.
1625
7fd47d5c
PE
1626 * lisp.h: Prefer 64-bit EMACS_INT if available.
1627 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1628 on 32-bit hosts that have 64-bit int, so that they can access
1629 large files.
122b0c86
PE
1630 However, temporarily disable this change unless the temporary
1631 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1632
8727937b
PE
1633 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1634
8ac068ac
PE
1635 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1636 This removes an assumption that EMACS_INT and long are the same
1637 width as pointers. The assumption is true for Emacs porting targets
1638 now, but we want to make other targets possible.
1639 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1640 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1641 In the rest of the code, change types of integers that hold casted
1642 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1643 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1644 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1645 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1646 No need to cast type when ORing.
1647 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1648 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1649 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1650 assume EMACS_INT is the same width as char *.
1651 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1652 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1653 Remove no-longer-needed casts.
1654 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1655 (xg_tool_bar_help_callback, xg_make_tool_item):
1656 Use EMACS_INTPTR to hold an integer
1657 that will be cast to void *; this can avoid a GCC warning
1658 if EMACS_INT is not the same width as void *.
1659 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1660 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1661 (current_message_1, set_message_1):
1662 Use a local to convert to proper width without a cast.
1663 * xmenu.c (dialog_selection_callback): Likewise.
1664
ede49d71
PE
1665 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1666 Also, don't assume VALBITS / RAND_BITS is less than 5,
1667 and don't rely on undefined behavior when shifting a 1 left into
1668 the sign bit.
1669 * lisp.h (get_random): Change signature to match.
1670
2f30ecd0
PE
1671 * lread.c (hash_string): Use size_t, not int, for hash computation.
1672 Normally we prefer signed values; but hashing is special, because
1673 it's better to use unsigned division on hash table sizes so that
1674 the remainder is nonnegative. Also, size_t is the natural width
1675 for hashing into memory. The previous code used 'int', which doesn't
1676 retain enough info to hash well into very large tables.
1677 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1678
2a866e7b
PE
1679 * dbusbind.c: Don't possibly lose pointer info when converting.
1680 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1681 Use XPNTR rather than XHASH, so that the high-order bits of
1682 the pointer aren't lost when converting through void *.
1683
51639eac
PE
1684 * eval.c (Fautoload): Don't double-shift a pointer.
1685
92394119
PE
1686 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1687
dbdb9a7c
JB
16882011-05-06 Juanma Barranquero <lekktu@gmail.com>
1689
1690 * gnutls.c (DEF_GNUTLS_FN):
1691 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1692
db7a0b4f
AS
16932011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1694
1695 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1696 marker. (Bug#8610)
1697
f7ff1b0f 16982011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1699
1700 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1701 New version that can reserve upto 2GB of heap space.
1702
f7ff1b0f 17032011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1704
1705 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1706
639c109b
TZ
17072011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1708
1709 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1710 `gnutls_certificate_set_x509_key_file'.
1711
d2127135
JB
17122011-05-05 Juanma Barranquero <lekktu@gmail.com>
1713
1714 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1715 Update dependencies.
1716
e968f4f3
JB
17172011-05-04 Juanma Barranquero <lekktu@gmail.com>
1718
1719 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1720 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1721 Remove unused parameter `fildes'.
1722 * process.c (read_process_output, send_process): Don't pass it.
1723
84d358f0
JB
17242011-05-04 Juanma Barranquero <lekktu@gmail.com>
1725
1726 Fix previous change: the library cache is defined in w32.c.
1727 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1728 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1729
0898ca10
JB
17302011-05-04 Juanma Barranquero <lekktu@gmail.com>
1731
1732 Implement dynamic loading of GnuTLS on Windows.
1733
1734 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1735 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1736 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1737 Declare.
1738
1739 * gnutls.c (Qgnutls_dll): Define.
1740 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1741 (gnutls_*): Declare function pointers.
1742 (init_gnutls_functions): New function to initialize function pointers.
1743 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1744 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1745 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1746 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1747 (emacs_gnutls_write, emacs_gnutls_read)
1748 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1749 (Fgnutls_available_p): New function.
1750 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1751 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1752 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1753
1754 * image.c: Include w32.h.
1755 (Vimage_type_cache): Delete.
1756 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1757 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1758 (w32_delayed_load): Move to w32.c.
1759
1760 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1761
1762 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1763 (w32_delayed_load): Move from image.c. When loading a library, record
1764 its filename in the :loaded-from property of the library id.
1765 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1766 Initialize and staticpro them.
1767 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1768
1769 * process.c: Include lisp.h before w32.h, not after.
1770 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1771 instead of gnutls_record_check_pending.
1772
1773 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1774
ff4de4aa
TZ
17752011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1776
1777 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1778 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1779 as passed in.
1780
abe95abb
JD
17812011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1782
1783 * xterm.c (x_set_frame_alpha): Do not set property on anything
1784 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1785
e16e55d4
JB
17862011-05-02 Juanma Barranquero <lekktu@gmail.com>
1787
1788 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1789
bafcf6a5
JB
17902011-05-02 Juanma Barranquero <lekktu@gmail.com>
1791
1792 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1793 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1794 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1795 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1796 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1797 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1798 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1799 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1800 (Qgnutls_bootprop_callbacks_verify): Make static.
1801
e7a6747f
AS
18022011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1803
19ed11ba
AS
1804 * callproc.c: Indentation fixup.
1805
e7a6747f 1806 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1807 (wait_for_termination, interruptible_wait_for_termination):
1808 Move after wait_for_termination_1.
e7a6747f 1809
1ef14cb4
LMI
18102011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1811
1812 * sysdep.c (interruptible_wait_for_termination): New function
1813 which is like wait_for_termination, but allows keyboard
1814 interruptions.
1815
1816 * callproc.c (Fcall_process): Add (:file "file") as an option for
1817 the STDOUT buffer.
1818 (Fcall_process_region): Ditto.
1819
330d880c
EZ
18202011-04-30 Eli Zaretskii <eliz@gnu.org>
1821
8db90b73
EZ
1822 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1823 rather than `XVECTOR (FOO)->size'.
1824
330d880c
EZ
1825 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1826 inttypes.h, as a gnulib replacement is used if it not available in
1827 system headers.
1828
15cbd324
EZ
18292011-04-21 Eli Zaretskii <eliz@gnu.org>
1830
1831 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1832 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1833 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1834
1835 * coding.c (coding_alloc_by_realloc): Error out if destination
1836 will grow beyond MOST_POSITIVE_FIXNUM.
1837 (decode_coding_emacs_mule): Abort if there isn't enough place in
1838 charbuf for the composition carryover bytes. Reserve an extra
1839 space for up to 2 characters produced in a loop.
1840 (decode_coding_iso_2022): Abort if there isn't enough place in
1841 charbuf for the composition carryover bytes.
1842
18432011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1844
ae940cca
EZ
1845 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1846 aborting when %lld or %lll format is passed.
1847 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1848 %llo or %llx format is passed. (Bug#8545)
1849
03ab8921
EZ
1850 * window.c (window_scroll_line_based): Use a marker instead of
1851 simple variables to record original value of point. (Bug#7952)
1852
afda1437
EZ
1853 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1854 produced by %s or %c overflows available buffer space. (Bug#8545)
1855
f76dee0c
PE
18562011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1857
1858 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1859 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1860
fdc5744d
JB
18612011-04-28 Juanma Barranquero <lekktu@gmail.com>
1862
1863 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1864
638f053a
JB
18652011-04-28 Juanma Barranquero <lekktu@gmail.com>
1866
1867 * keyboard.c (Qdelayed_warnings_hook): Define.
1868 (command_loop_1): Run `delayed-warnings-hook'
1869 if Vdelayed_warnings_list is non-nil.
1870 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1871 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1872
d178f871
EZ
18732011-04-28 Eli Zaretskii <eliz@gnu.org>
1874
1875 * doprnt.c (doprnt): Don't return value smaller than the buffer
1876 size if the message was truncated. (Bug#8545).
1877
b124fd93
JB
18782011-04-28 Juanma Barranquero <lekktu@gmail.com>
1879
1880 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1881 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1882
e810457d
PE
18832011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1884
1885 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1886
ea51cceb
JB
18872011-04-27 Juanma Barranquero <lekktu@gmail.com>
1888
1889 * makefile.w32-in: Update dependencies.
1890
94dcfacf
EZ
18912011-04-27 Eli Zaretskii <eliz@gnu.org>
1892
1893 Improve `doprnt' and its usage. (Bug#8545)
1894 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1895 `format_end'. Remove support for %l as a conversion specifier.
1896 Don't use xrealloc. Improve diagnostics when the %l size modifier
1897 is used. Update the commentary.
1898
1899 * eval.c (verror): Simplify calculation of size_t.
1900
1901 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1902 messages.
1903
f61f41d7
PE
19042011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1905
1906 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1907 change.
1908
96fb4434
PE
19092011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1910
1911 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1912 This makes this file independent of the recent pseudovector change.
1913
671875da 19142011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1915
69e9b5a3
PE
1916 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1917
b5f869a7 1918 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1919 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1920 Remove unused local.
c8926152 1921 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1922
841a1577 1923 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1924 GCC 4.6.0 optimizes based on type-based alias analysis.
1925 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1926 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1927 != &v->size, and therefore "v->size = 1; b->size = 2; return
1928 v->size;" must therefore return 1. This assumption is incorrect
1929 for Emacs, since it type-puns struct Lisp_Vector * with many other
1930 types. To fix this problem, this patch adds a new type struct
f904488f 1931 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1932 and pseudovectors, and helps optimizing compilers not get fooled
1933 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1934 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1935 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1936 the size member.
eab3844f
PE
1937 (XSETPVECTYPE): Rewrite in terms of new macro.
1938 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1939 This is a bit clearer, and further avoids the possibility of
1940 undesirable aliasing.
1941 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1942 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1943 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1944 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1945 (ASIZE): Now uses header.size rather than size.
1946 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1947 to avoid the hassle of writing XVECTOR (foo)->header.size.
1948 (struct vectorlike_header): New type.
eab3844f
PE
1949 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1950 object, to help avoid aliasing.
1951 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1952 (SUBRP): Likewise, since Lisp_Subr is a special case.
1953 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1954 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1955 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1956 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1957 changed to be "header.size" and "header.next".
1958 * buffer.h (struct buffer): Likewise.
1959 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1960 * frame.h (struct frame): Likewise.
1961 * process.h (struct Lisp_Process): Likewise.
1962 * termhooks.h (struct terminal): Likewise.
1963 * window.c (struct save_window_data, struct saved_window): Likewise.
1964 * window.h (struct window): Likewise.
1965 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1966 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1967 * buffer.c (init_buffer_once): Likewise.
1968 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1969 special case.
1970 * process.c (Fformat_network_address): Use local var for size,
1971 for brevity.
1972
0df1eac5
PE
1973 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1974
847ab9d1 1975 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1976 * data.c (atof): Remove decl; no longer used or needed.
1977 (digit_to_number): Move to lread.c.
1978 (Fstring_to_number): Use new string_to_number function, to be
1979 consistent with how the Lisp reader treats infinities and NaNs.
1980 Do not assume that floating-point numbers represent EMACS_INT
1981 without losing information; this is not true on most 64-bit hosts.
1982 Avoid double-rounding errors, by insisting on integers when
1983 parsing non-base-10 numbers, as the documentation specifies.
1984 * lisp.h (string_to_number): New decl, replacing ...
1985 (isfloat_string): Remove.
bc0a5c13 1986 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1987 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1988 appears to have been a coding error. Similarly, do not accept
1989 strings like +-1e0 as floating point numbers. Do not report
1990 overflow for integer overflows unless the base is not 10 which
1991 means we have no simple and reliable way to continue.
1992 Break out the floating-point parsing into a new
1993 function string_to_number, so that Fstring_to_number parses
1994 floating point numbers consistently with the Lisp reader.
04f2d78b 1995 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1996 (E_CHAR, EXP_INT): Remove, replacing with ...
1997 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1998 (string_to_number): New function, replacing isfloat_string.
1999 This function checks for valid syntax and produces the resulting
2000 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2001 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2002 so that overflow for non-base-10 numbers is reported only when
2003 there's no portable and simple way to convert to floating point.
452f4150 2004
67769ffc
PE
2005 * textprop.c (set_text_properties_1): Rewrite for clarity,
2006 and to avoid GCC warning about integer overflow.
2007
c20db43f
PE
2008 * intervals.h (struct interval): Use EMACS_INT for members
2009 where EMACS_UINT might cause problems. See
2010 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2011 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2012 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2013 All uses changed.
37aa2f85
PE
2014 (offset_intervals): Tell GCC not to worry about length overflow
2015 when negating a negative length.
c20db43f 2016
2538aa2f
PE
2017 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2018 (overrun_check_free): Likewise.
2019
f2d3008d
PE
2020 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2021 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2022 word size.
2023
ec8df744
PE
2024 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2025 (gnutls_make_error): Rename local to avoid shadowing.
2026 (gnutls_emacs_global_deinit): ifdef out; not used.
2027 (Fgnutls_boot): Use const for pointer to readonly storage.
2028 Comment out unused local. Fix pointer signedness problems.
2029
640ee02d
PE
2030 * lread.c (openp): Don't stuff size_t into an 'int'.
2031 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2032 about possible signed overflow.
2033
6048fb2a
PE
2034 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2035 (GDK_KEY_g): Don't define if already defined.
2036 (xg_prepare_tooltip): Avoid pointer signedness problem.
2037 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2038
fa3c87e1
PE
2039 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2040 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2041
2172544b
PE
2042 * xfns.c (Fx_window_property): Simplify a bit,
2043 to make a bit faster and to avoid GCC 4.6.0 warning.
2044 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2045
9b821a21
PE
2046 * fns.c (internal_equal): Don't assume size_t fits in int.
2047
3c616cfa
PE
2048 * alloc.c (compact_small_strings): Tighten assertion a little.
2049
c2982e87
PE
2050 Replace pEd with more-general pI, and fix some printf arg casts.
2051 * lisp.h (pI): New macro, generalizing old pEd macro to other
2052 conversion specifiers. For example, use "...%"pI"d..." rather
2053 than "...%"pEd"...".
2054 (pEd): Remove. All uses replaced with similar uses of pI.
2055 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2056 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2057 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2058 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2059 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2060 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2061 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2062 64-bit hosts.
2063 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2064 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2065 * print.c (safe_debug_print, print_object): Likewise.
2066 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2067 to int.
6f04d126
PE
2068 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2069 avoiding the 0 flag, which is not portable.
c2982e87
PE
2070 * process.c (Fmake_network_process): Use pI to avoid cast.
2071 * region-cache.c (pp_cache): Likewise.
2072 * xdisp.c (decode_mode_spec): Likewise.
2073 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2074 behavior on 64-bit hosts with printf arg.
6f04d126 2075 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2076 (x_stop_queuing_selection_requests): Likewise.
2077 (x_get_window_property): Don't truncate byte count to an 'int'
2078 when tracing.
0b432f21 2079
5e073ec7
PE
2080 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2081 here, since it parses constructs like leading '-' and spaces,
2082 which are not wanted; and it overflows with large numbers.
2083 Instead, simply match F[0-9]+, which is what is wanted anyway.
2084
36372bf9
PE
2085 * alloc.c: Remove unportable assumptions about struct layout.
2086 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2087 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2088 (allocate_vectorlike, make_pure_vector): Use the new macros,
2089 plus offsetof, to remove unportable assumptions about struct layout.
2090 These assumptions hold on all porting targets that I know of, but
2091 they are not guaranteed, they're easy to remove, and removing them
2092 makes further changes easier.
2093
0b432f21
PE
2094 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2095 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2096 (string_overrun_cookie): Now const. Use initializers that
2097 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2098 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2099 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2100 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2101 multiple of sizeof (EMACS_INT); it need not be, if
2102 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2103 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2104
895009e1
JB
21052011-04-26 Juanma Barranquero <lekktu@gmail.com>
2106
2107 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2108
6a7a1b0b
TZ
21092011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2110
2111 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2112 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2113 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2114
841a1577 21152011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2116
2117 * lisp.h (Qdebug): List symbol.
895009e1 2118 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2119 * keyboard.c (debug-on-event): New variable.
2120 (handle_user_signal): Break into debugger when debug-on-event
2121 matches the current signal symbol.
2122
f2d3ba6f
DN
21232011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2124
2125 * alloc.c (check_sblock, check_string_bytes)
2126 (check_string_free_list): Convert to standard C.
2127
42ce4c63
TZ
21282011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2129
2130 * w32.c (emacs_gnutls_push): Fix typo.
2131
825cd63c
EZ
21322011-04-25 Eli Zaretskii <eliz@gnu.org>
2133
fb11d64d
EZ
2134 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2135 "cast to pointer from integer of different size".
2136
825cd63c
EZ
2137 Improve doprnt and its use in verror. (Bug#8545)
2138 * doprnt.c (doprnt): Document the set of format control sequences
2139 supported by the function. Use SAFE_ALLOCA instead of always
2140 using `alloca'.
2141
2142 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2143 is one byte too soon. Don't use xrealloc; instead xfree and
2144 xmalloc anew.
2145
e061a11b
TZ
21462011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2147
2148 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2149 callbacks stage.
2150
2151 * gnutls.c: Renamed global_initialized to
2152 gnutls_global_initialized. Added internals for the
2153 :verify-hostname-error, :verify-error, and :verify-flags
2154 parameters of `gnutls-boot' and documented those parameters in the
2155 docstring. Start callback support.
2156 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2157 unless a fatal error occured. Call gnutls_alert_send_appropriate
2158 on error. Return error code.
2159 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2160 (emacs_gnutls_read): Likewise.
2161 (Fgnutls_boot): Return handshake error code.
2162 (emacs_gnutls_handle_error): New function.
2163 (wsaerror_to_errno): Likewise.
2164
2165 * w32.h (emacs_gnutls_pull): Add prototype.
2166 (emacs_gnutls_push): Likewise.
2167
2168 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2169 (emacs_gnutls_push): Likewise.
2170
21712011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2172
2173 * process.c (wait_reading_process_output): Check if GnuTLS
2174 buffered some data internally if no FDs are set for TLS
2175 connections.
2176
2177 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2178 (LIBS): Link to USER_LIBS.
2179 ($(BLD)/gnutls.$(0)): New target.
2180
fa6996bc
EZ
21812011-04-24 Eli Zaretskii <eliz@gnu.org>
2182
eb35682e
EZ
2183 * xdisp.c (handle_single_display_spec): Rename the
2184 display_replaced_before_p argument into display_replaced_p, to
2185 make it consistent with the commentary. Fix typos in the
2186 commentary.
2187
e2ad650c
EZ
2188 * textprop.c (syms_of_textprop): Remove dead code.
2189 (copy_text_properties): Delete obsolete commentary about an
2190 interface that was deleted long ago. Fix typos in the description
2191 of arguments.
2192
1b2de274
EZ
2193 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2194 to changes in oldXMenu/XMenu.h from 2011-04-16.
2195 <menu_help_message, prev_menu_help_message>: Constify.
2196 (IT_menu_make_room): menu->help_text is now `const char **';
2197 adjust.
2198
2199 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2200 to changes in oldXMenu/XMenu.h from 2011-04-16.
2201 (struct XMenu): Declare `help_text' `const char **'.
2202
2203 * xfaces.c <Qunspecified>: Make extern again.
2204
2205 * syntax.c: Include sys/types.h before including regex.h, as
2206 required by Posix.
2207
762b15be
EZ
2208 * doc.c (get_doc_string): Improve the format passed to `error'.
2209
2210 * doprnt.c (doprnt): Improve commentary.
2211
2212 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2213
2214 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2215 them with etags.
2216
f1052e5d
EZ
2217 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2218 changes in globals.h immediately force recompilation.
762b15be
EZ
2219 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2220 $(CURDIR)/s/ms-w32.h.
2221 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2222
fa6996bc
EZ
2223 * character.c (Fchar_direction): Function deleted.
2224 (syms_of_character): Don't defsubr it.
2225 <char-direction-table>: Deleted.
2226
e6c3da20
EZ
22272011-04-23 Eli Zaretskii <eliz@gnu.org>
2228
2229 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2230 * doprnt.c: Include limits.h.
2231 (SIZE_MAX): New macro.
04f2d78b
CB
2232 (doprnt): Return a size_t value. 2nd arg is now size_t.
2233 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2234 Improve overflow protection. Support `l' modifier for integer
2235 conversions. Support %l conversion. Don't assume an EMACS_INT
2236 argument for integer conversions and for %c.
2237
2238 * lisp.h (doprnt): Restore prototype.
2239
2240 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2241 $(SRC)/character.h.
2242
2243 * Makefile.in (base_obj): Add back doprnt.o.
2244
2245 * deps.mk (doprnt.o): Add back prerequisites.
2246 (callint.o): Depend on character.h.
2247
2248 * eval.c (internal_lisp_condition_case): Include the handler
2249 representation in the error message.
2250 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2251 when breaking from the loop.
2252
2253 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2254
2255 * callint.c (Fcall_interactively): When displaying error message
2256 about invalid control letter, pass the character's codepoint, not
2257 a pointer to its multibyte form. Improve display of the character
2258 in octal and display also its hex code.
2259
2260 * character.c (char_string): Use %x to display the (unsigned)
2261 codepoint of an invalid character, to avoid displaying a bogus
2262 negative value.
2263
2264 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2265 `error', not SYMBOL_NAME itself.
2266
2267 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2268 character arguments to `error'.
2269
2270 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2271 to `error' in error message about FINAL_CHAR argument. Make sure
2272 FINAL_CHAR is a character, and use %c when it is passed as
2273 argument to `error'.
2274
4ffd0d6b 22752011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2276
2277 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2278
2279 * w32.c: Include <time.h>.
2280 (sys_localtime): New function.
2281
4ffd0d6b 22822011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2283
2284 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2285
4ffd0d6b 2286 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2287
4ffd0d6b 22882011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2289
4ffd0d6b
GM
2290 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2291 zombies (Bug#8467).
aac0c6e3 2292
04c56954
EZ
22932011-04-19 Eli Zaretskii <eliz@gnu.org>
2294
2295 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2296 gl_state.e_property when gl_state.object is Qt.
2297
2298 * insdel.c (make_gap_larger): Remove limitation of buffer size
2299 to <= INT_MAX.
2300
16a43933
CY
23012011-04-18 Chong Yidong <cyd@stupidchicken.com>
2302
2303 * xdisp.c (lookup_glyphless_char_display)
2304 (produce_glyphless_glyph): Handle cons cell entry in
2305 glyphless-char-display.
2306 (Vglyphless_char_display): Document it.
2307
2308 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2309 glyphless-char-display.
2310
4581706e
CY
23112011-04-17 Chong Yidong <cyd@stupidchicken.com>
2312
2313 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2314
2315 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2316
2317 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2318 definition for no-X builds.
2319
4887c6e2 23202011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2321
fd35b6f9
PE
2322 Static checks with GCC 4.6.0 and non-default toolkits.
2323
5c1ccb01
PE
2324 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2325
006c5daa
PE
2326 * process.c (keyboard_bit_set): Define only if SIGIO.
2327 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2328 (send_process): Repair possible setjmp clobbering.
2329
efc736d3
PE
2330 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2331
4e2fe2e6
PE
2332 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2333
f97334a2
PE
2334 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2335
4e75f29d
PE
2336 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2337 Define only if needed.
2338
90efadd1
PE
2339 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2340 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2341 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2342
3c647824
PE
2343 * dispextern.h (struct redisplay_interface): Rename param
2344 to avoid shadowing.
e264f262 2345 * termhooks.h (struct terminal): Likewise.
761383f4 2346 * xterm.c (xembed_send_message): Likewise.
3c647824 2347
b58c5c4a
PE
2348 * insdel.c (make_gap_smaller): Define only if
2349 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2350
cad59032
PE
2351 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2352 it.
2353
c339dc2e
PE
2354 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2355 so that we aren't warned about unused symbols.
2356
91a3e27b
PE
2357 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2358
399c71d3 2359 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2360
8ffc96f5
PE
2361 * xfns.c (x_real_positions): Mark locals as initialized.
2362
eef9bc79
PE
2363 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2364
098db9dd
PE
2365 * xterm.c: Fix problems found by static analysis with other toolkits.
2366 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2367 (x_dispatch_event): Declare static if USE_GTK, and
2368 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2369 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2370 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2371 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2372 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2373
eb18f6cc
PE
2374 * xmenu.c (menu_help_callback): Pointer type fixes.
2375 Use const pointers when pointing at readonly data. Avoid pointer
2376 signedness clashes.
2377 (FALSE): Remove unused macro.
2378 (update_frame_menubar): Remove unused decl.
2379
1fe72bf8
PE
2380 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2381
60d9e1db
PE
2382 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2383 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2384 (single_menu_item): Rename local to avoid shadowing.
2385
39261c26
PE
2386 * keyboard.c (make_lispy_event): Remove unused local var.
2387
018c5e19
PE
2388 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2389 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2390
63d2b86e
PE
2391 * bitmaps: Change bitmaps from unsigned char back to the X11
2392 compatible char. Avoid the old compiler warnings about
2393 out-of-range initializers by using, for example, '\xab' rather
2394 than 0xab.
2395
aefd87e1
PE
2396 * xgselect.c (xgselect_initialize): Check vs interface
2397 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2398
bf501fb9
PE
2399 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2400
e9829fdf
PE
2401 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2402 to read-only memory.
2403
1086c095
PE
2404 * fns.c (vector): Remove; this old hack is no longer needed.
2405
2baccd04 2406 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2407 Remove unused var.
dde42981 2408 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2409
72391843 2410 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2411
436c16df 2412 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2413 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2414 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2415
92bb796d 2416 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2417 (x_term_init): Remove local to avoid shadowing.
92bb796d 2418
764430a3 2419 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2420
2421 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2422 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2423
d1dfb56c
EZ
24242011-04-16 Eli Zaretskii <eliz@gnu.org>
2425
c4354cb4
EZ
2426 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2427
d1dfb56c
EZ
2428 Fix regex.c, syntax.c and friends for buffers > 2GB.
2429 * syntax.h (struct gl_state_s): Declare character position members
2430 EMACS_INT.
2431
2432 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2433
04f2d78b
CB
2434 * textprop.c (verify_interval_modification, interval_of):
2435 Declare arguments EMACS_INT.
d1dfb56c
EZ
2436
2437 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2438 EMACS_INT.
2439
2440 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2441
2442 * indent.c (Fvertical_motion): Local variable it_start is now
2443 EMACS_INT.
2444
2445 * regex.c (re_match, re_match_2, re_match_2_internal)
2446 (bcmp_translate, regcomp, regexec, print_double_string)
2447 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2448 (re_compile_pattern, re_exec): Declare arguments and local
2449 variables `size_t' and `ssize_t' and return values `regoff_t', as
2450 appropriate.
2451 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2452 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2453 <compile_stack_type>: `size' and `avail' are now `size_t'.
2454
2455 * regex.h <regoff_t>: Use ssize_t, not int.
2456 (re_search, re_search_2, re_match, re_match_2): Arguments that
2457 specify buffer/string position and length are now ssize_t and
2458 size_t. Return type is regoff_t.
2459
613052cd
BK
24602011-04-16 Ben Key <bkey76@gmail.com>
2461
2462 * nsfont.m: Fixed bugs in ns_get_family and
2463 ns_descriptor_to_entity that were caused by using free to
2464 deallocate memory blocks that were allocated by xmalloc (via
2465 xstrdup). This caused Emacs to crash when compiled with
2466 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2467 --enable-checking=xmallocoverrun). xfree is now used to
2468 deallocate these memory blocks.
2469
4170f62f 24702011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2471
71b41406
PE
2472 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2473
9587a89d
PE
2474 emacs_write: Accept and return EMACS_INT for sizes.
2475 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2476 et seq.
2477 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2478 Accept and return EMACS_INT.
2479 (emacs_gnutls_write): Return the number of bytes written on
2480 partial writes.
2481 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2482 (emacs_read, emacs_write): Remove check for negative size, as the
2483 Emacs source code has been audited now.
9587a89d
PE
2484 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2485 (emacs_read, emacs_write): Use it.
273a5f82
PE
2486 * process.c (send_process): Adjust to the new signatures of
2487 emacs_write and emacs_gnutls_write. Do not attempt to store
2488 a byte offset into an 'int'; it might overflow.
9587a89d 2489 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2490
3e047f51
PE
2491 * sound.c: Don't assume sizes fit in 'int'.
2492 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2493 Return EMACS_INT, not int.
3e047f51 2494 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2495 Accept EMACS_INT, not int.
2496 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2497 record read return values.
2498
cc39a9db
BK
24992011-04-15 Ben Key <bkey76@gmail.com>
2500
c9d0ec6d
JB
2501 * keyboard.c (Qundefined): Don't declare static since it is used
2502 in nsfns.m.
2503 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2504 static since they are used in nsfont.m.
cc39a9db 2505
6c60eb9f
SM
25062011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2507
2508 * process.c (Qprocessp): Don't declare static.
2509 * lisp.h (Qprocessp): Declare again.
2510
7990b61a
JB
25112011-04-15 Juanma Barranquero <lekktu@gmail.com>
2512
2513 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2514
5d4cb038
PE
25152011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2516
8bd7b830 2517 Improve C-level modularity by making more things 'static'.
cd64ea1d 2518
e3b27b31
PE
2519 Don't publish debugger-only interfaces to other modules.
2520 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2521 (verify_bytepos, count_markers): Move decls to the only modules
2522 that need them.
2523 * region-cache.h (pp_cache): Likewise.
2524 * window.h (check_all_windows): Likewise.
2525 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2526
5d4cb038
PE
2527 * sysdep.c (croak): Now static, if
2528 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2529 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2530
2531 * alloc.c (refill_memory_reserve): Now static if
2532 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2533 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2534
e87b6180
PE
2535 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2536 Define only if USE_LUCID.
2537
ac64929e
PE
2538 * xrdb.c (x_customization_string, x_rm_string): Now static.
2539
6f37259d
PE
2540 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2541 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2542
1683e3ab
PE
2543 * xdisp.c (draw_row_with_mouse_face): Now static.
2544 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2545
de9c2632
PE
2546 * window.h (check_all_windows): Mark externally visible.
2547
2b96acb7
PE
2548 * window.c (window_deletion_count): Now static.
2549
2550 * undo.c: Make symbols static if they're not exported.
2551 (last_undo_buffer, last_boundary_position, pending_boundary):
2552 Now static.
2553
50436f33
PE
2554 * textprop.c (interval_insert_behind_hooks): Now static.
2555 (interval_insert_in_front_hooks): Likewise.
2556
64520e5c
PE
2557 * term.c: Make symbols static if they're not exported.
2558 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2559 (max_frame_lines, tty_set_terminal_modes):
2560 (tty_reset_terminal_modes, tty_turn_off_highlight):
2561 (get_tty_terminal): Now static.
2562 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2563 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2564 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2565 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2566 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2567
1fa53021
PE
2568 * sysdep.c: Make symbols static if they're not exported.
2569 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2570 Now static.
2571 (sigprocmask_set, full_mask): Remove; unused.
2572 (wait_debugging): Mark as visible.
2573 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2574 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2575
d4b43b22
PE
2576 * syntax.c (syntax_temp): Define only if !__GNUC__.
2577
b7c513d0
PE
2578 * sound.c (current_sound_device, current_sound): Now static.
2579
989b29ad
PE
2580 * search.c (searchbufs, searchbuf_head): Now static.
2581
13a55a78
PE
2582 * scroll.c (scroll_cost): Remove; unused.
2583 * dispextern.h (scroll_cost): Remove decl.
2584
de68a1fc
PE
2585 * region-cache.h (pp_cache): Mark as externally visible.
2586
40ccffa6
PE
2587 * process.c: Make symbols static if they're not exported.
2588 (process_tick, update_tick, create_process, chan_process):
2589 (Vprocess_alist, proc_buffered_char, datagram_access):
2590 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2591 (deactivate_process): Mark defn as static, as well as decl.
2592 * lisp.h (create_process): Remove decl.
2593 * process.h (chan_process, Vprocess_alist): Remove decls.
2594
ad64fc97
PE
2595 * print.c: Make symbols static if they're not exported.
2596 (print_depth, new_backquote_output, being_printed, print_buffer):
2597 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2598 (print_interval, print_number_index, initial_stderr_stream):
2599 Now static.
2600 * lisp.h (Fprinc): Remove decl.
2601 (debug_output_compilation_hack): Mark as externally visible.
2602
adddb265
PE
2603 * sysdep.c (croak): Move decl from here to syssignal.h.
2604 * syssignal.h (croak): Put it here, so the API can be checked when
2605 'croak' is called from dissociate_if_controlling_tty.
2606
1717ede2
PE
2607 * minibuf.c: Make symbols static if they're not exported.
2608 (minibuf_save_list, choose_minibuf_frame): Now static.
2609 * lisp.h (choose_minibuf_frame): Remove decl.
2610
fa5fb2bc
PE
2611 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2612
1e3890d1
PE
2613 * lread.c: Make symbols static if they're not exported.
2614 (read_objects, initial_obarray, oblookup_last_bucket_number):
2615 Now static.
2616 (make_symbol): Remove; unused.
2617 * lisp.h (initial_obarray, make_symbol): Remove decls.
2618
8a1414fa
PE
2619 * keyboard.c: Make symbols static if they're not exported.
2620 (single_kboard, recent_keys_index, total_keys, recent_keys):
2621 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2622 (this_single_command_key_start, echoing, last_auto_save):
2623 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2624 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2625 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2626 (Vlispy_mouse_stem, double_click_count):
2627 Now static.
2628 (force_auto_save_soon): Define only if SIGDANGER.
2629 (ignore_mouse_drag_p): Now static if
2630 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2631 (print_help): Remove; unused.
2632 (stop_character, last_timer_event): Mark as externally visible.
2633 * keyboard.h (ignore_mouse_drag_p): Declare only if
2634 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2635 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2636 * lisp.h (echoing): Remove decl.
2637 (force_auto_save_soon): Declare only if SIGDANGER.
2638 * xdisp.c (redisplay_window): Simplify code, to make it more
2639 obvious that ignore_mouse_drag_p is not accessed if !defined
2640 USE_GTK && !defined HAVE_NS.
2641
93ea6e8f
PE
2642 * intervals.c: Make symbols static if they're not exported.
2643 (merge_properties_sticky, merge_interval_right, delete_interval):
2644 Now static.
2645 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2646
77382fcc
PE
2647 * insdel.c: Make symbols static if they're not exported.
2648 However, leave prepare_to_modify_buffer alone. It's never
2649 called from outside this function, but that appears to be a bug.
2650 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2651 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2652 (adjust_after_replace_noundo): Remove; unused.
2653 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2654 (signal_before_change): Remove decls.
77382fcc 2655
9306c32e
PE
2656 * indent.c (val_compute_motion, val_vmotion): Now static.
2657
cd44d2eb
PE
2658 * image.c: Make symbols static if they're not exported.
2659 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2660 if USE_GTK.
2661 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2662 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2663
ad9a7a06
PE
2664 * fringe.c (standard_bitmaps): Now static.
2665 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2666
81626931
PE
2667 * frame.c: Make symbols static if they're not exported.
2668 (x_report_frame_params, make_terminal_frame): Now static.
2669 (get_frame_param): Now static, unless HAVE_NS.
2670 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2671 (x_get_resource_string): Remove; not used.
2672 * frame.h (make_terminal_frame, x_report_frame_params):
2673 (x_get_resource_string); Remove decls.
2674 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2675 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2676
239f9db9
PE
2677 * font.c, fontset.c: Make symbols static if they're not exported.
2678 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2679 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2680 * font.c (font_close_object): Now static.
2681 * font.h (font_close_object): Remove.
2682 * fontset.c (FONTSET_OBJLIST): Remove.
2683 (free_realized_fontset) #if-0 the body, which does nothing.
2684 (face_suitable_for_char_p): #if-0, as it's never called.
2685 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2686 * xfaces.c (face_at_string_position):
2687 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2688 since 0 is always ASCII.
2689
dfcf3579
PE
2690 * fns.c (weak_hash_tables): Now static.
2691
5045092b
PE
2692 * fileio.c: Make symbols static if they're not exported.
2693 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2694 (Vwrite_region_annotation_buffers): Now static.
2695
57a96f5c
PE
2696 * eval.c: Make symbols static if they're not exported.
2697 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2698 * lisp.h (backtrace_list): Remove decl.
2699
35f08c38
PE
2700 * emacs.c: Make symbols static if they're not exported.
2701 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2702 (fatal_error_code, fatal_error_signal_hook, standard_args):
2703 Now static.
2704 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2705 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2706 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2707 * lisp.h (fatal_error_signal_hook): Remove decl.
2708 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2709
f44bd759
PE
2710 * editfns.c: Move a (normally-unused) function to its only use.
2711 * editfns.c, lisp.h (get_operating_system_release): Remove.
2712 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2713 worth the hassle of breaking this out.
2714
b532497d
PE
2715 * xterm.c: Make symbols static if they're not exported.
2716 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2717 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2718 (x_destroy_window, x_delete_display):
2719 Now static.
2720 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2721 (x_mouse_leave): Remove; unused.
2722 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2723 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2724 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2725 Remove decls.
2726 (x_mouse_leave): Declare only if WINDOWSNT.
2727 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2728 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2729 USE_X_TOOLKIT.
2730
1675728f
PE
2731 * ftxfont.c: Make symbols static if they're not exported.
2732 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2733 HAVE_FREETYPE.
2734 * font.h (ftxfont_driver): Likewise.
2735
e4cebfca
PE
2736 * xfns.c: Make symbols static if they're not exported.
2737 (x_last_font_name, x_display_info_for_name):
2738 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2739 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2740 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2741 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2742 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2743 (last_show_tip_args): Now static.
2744 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2745 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2746 (x_screen_planes): Remove; unused.
2747 * dispextern.h (x_screen_planes): Remove decl.
2748
5bf46f05
PE
2749 * dispnew.c: Make symbols static if they're not exported.
2750 * dispextern.h (redraw_garbaged_frames, scrolling):
2751 (increment_row_positions): Remove.
2752 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2753 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2754 Now static.
2755 (redraw_garbaged_frames): Remove; unused.
2756
435f4c28
PE
2757 * xfaces.c: Make symbols static if they're not exported.
2758 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2759 Remove decls.
2760 * xterm.h (defined_color): Remove decls.
2761 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2762 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2763 (menu_face_changed_default, defined_color, free_realized_face):
2764 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2765 (ascii_face_of_lisp_face): Remove; unused.
2766
8524aef3
PE
2767 * xdisp.c: Make symbols static if they're not exported.
2768 * dispextern.h (scratch_glyph_row, window_box_edges):
2769 (glyph_to_pixel_coords, set_cursor_from_row):
2770 (get_next_display_element, set_iterator_to_next):
2771 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2772 (show_mouse_face): Remove decls
2773 * frame.h (message_buf_print): Likewise.
2774 * lisp.h (pop_message, set_message, check_point_in_composition):
2775 Likewise.
2776 * xterm.h (set_vertical_scroll_bar): Likewise.
2777 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2778 (message_buf_print, scratch_glyph_row, displayed_buffer):
2779 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2780 (get_next_display_element, show_mouse_face, window_box_edges):
2781 (frame_to_window_pixel_xy, check_point_in_composition):
2782 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2783 (glyph_to_pixel_coords): Remove; unused.
2784
16390cd2
PE
2785 * dired.c (file_name_completion): Now static.
2786
2787 * dbusbind.c (xd_in_read_queued_messages): Now static.
2788
a25f4dfa
PE
2789 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2790 * data.c (circular_list_error): Remove.
2791
14a9c8df
PE
2792 * commands.h (last_point_position, last_point_position_buffer):
2793 (last_point_position_window): Remove decls.
2794 * keyboard.c: Make these variables static.
2795
04f2d78b
CB
2796 * coding.h (coding, code_convert_region, encode_coding_gap):
2797 Remove decls.
74ab6df5
PE
2798 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2799 (iso_code_class, detect_coding, code_convert_region): Now static.
2800 (encode_coding_gap): Remove; unused.
2801
38dfbee1
PE
2802 * chartab.c (chartab_chars, chartab_bits): Now static.
2803
a2cb4e63
PE
2804 * charset.h (charset_iso_8859_1): Remove decl.
2805 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2806 Now static.
2807
127198fd
PE
2808 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2809 * ccl.c (Vccl_program_table): Now static.
2810 (check_ccl_update): Remove; unused.
2811
d85b608f
PE
2812 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2813 * category.h: ... from here.
2814 * category.c (check_category_table, set_category_set): Now static.
2815
31cd66f3
PE
2816 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2817 * lisp.h: Remove these decls.
2818
c358e587
PE
2819 * buffer.c (buffer_count): Remove unused var.
2820
e78aecca
PE
2821 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2822 so that it's not optimized away.
2823 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2824 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2825 exported only to the debugger.
2826
e192d7d3 2827 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2828 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2829
92470028
PE
2830 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2831 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2832 was inaccessible from Lisp.
2833 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2834 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2835
244ed907
PE
2836 alloc.c: Import and export fewer symbols, and remove unused items.
2837 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2838 is defined.
2839 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2840 it's not optimized away by whole-program optimization.
2841 (message_enable_multibyte, free_misc): Remove.
2842 (catchlist, handlerlist, mark_backtrace):
2843 Declare only if BYTE_MARK_STACK.
2844 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2845 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2846 (message_enable_multibyte): Remove decl.
2847 (free_misc, interval_free_list, float_block, float_block_index):
2848 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2849 (cons_free_list, last_marked_index):
2850 Now static.
2851 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2852 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2853 (mark_backtrace): Define only if BYTE_MARK_STACK.
2854 * xdisp.c (message_enable_multibyte): Now static.
2855
61c2b50e 2856 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2857 This makes it easier for human readers (and static analyzers)
2858 to see whether these variables are used from other modules.
2859 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2860 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2861 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2862 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2863 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2864 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2865 * xmenu.c, xselect.c:
2866 Declare Q* vars static if they are not used in other modules.
2867 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2868 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2869 Remove decls of unexported vars.
2870 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2871
95c82688
PE
2872 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2873
16a97296
PE
2874 Make Emacs functions such as Fatom 'static' by default.
2875 This makes it easier for human readers (and static analyzers)
2876 to see whether these functions can be called from other modules.
2877 DEFUN now defines a static function. To make the function external
2878 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2879 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2880 (Finit_image_library):
16a97296
PE
2881 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2882 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2883 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2884 Remove decls, since these functions are now static.
2885 (Funintern, Fget_internal_run_time): New decls, since these functions
2886 were already external.
95c82688 2887
16a97296
PE
2888 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2889 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2890 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2891 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2892 * keyboard.c, keymap.c, lread.c:
2893 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2894 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2895 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2896 Mark functions with DEFUE instead of DEFUN,
2897 if they are used in other modules.
2898 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2899 decls for now-static functions.
2900 * buffer.h (Fdelete_overlay): Remove decl.
2901 * callproc.c (Fgetenv_internal): Mark as internal.
2902 * composite.c (Fremove_list_of_text_properties): Remove decl.
2903 (Fcomposition_get_gstring): New forward static decl.
2904 * composite.h (Fcomposite_get_gstring): Remove decl.
2905 * dired.c (Ffile_attributes): New forward static decl.
2906 * doc.c (Fdocumntation_property): New forward static decl.
2907 * eval.c (Ffetch_bytecode): New forward static decl.
2908 (Funintern): Remove extern decl; now in .h file where it belongs.
2909 * fileio.c (Fmake_symbolic_link): New forward static decl.
2910 * image.c (Finit_image_library): New forward static decl.
2911 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2912 * intervals.h (Fprevious_property_change):
2913 (Fremove_list_of_text_properties): Remove decls.
2914 * keyboard.c (Fthis_command_keys): Remove decl.
2915 (Fcommand_execute): New forward static decl.
2916 * keymap.c (Flookup_key): New forward static decl.
2917 (Fcopy_keymap): Now static.
2918 * keymap.h (Flookup_key): Remove decl.
2919 * process.c (Fget_process): New forward static decl.
2920 (Fprocess_datagram_address): Mark as internal.
2921 * syntax.c (Fsyntax_table_p): New forward static decl.
2922 (skip_chars): Remove duplicate decl.
2923 * textprop.c (Fprevious_property_change): New forward static decl.
2924 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2925 Now internal.
2926 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2927 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2928
785bbd42
PE
2929 * editfns.c (Fformat): Remove unreachable code.
2930
8b913b57
AS
29312011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2932
2933 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2934 change. (Bug#8496)
2935
a6744a35
EZ
29362011-04-13 Eli Zaretskii <eliz@gnu.org>
2937
2938 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2939 when at ZV. (Bug#8487)
2940
e7974947
AS
29412011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2942
baad03f0
AS
2943 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2944 (Bug#8437)
2945 * keyboard.c (parse_tool_bar_item): Likewise.
2946 * sound.c (sound_cleanup, alsa_close): Likewise.
2947 * termcap.c (tgetent): Likewise.
2948 * xfns.c (x_default_font_parameter): Likewise.
2949 * xsettings.c (read_and_apply_settings): Likewise.
2950
e7974947
AS
2951 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2952 (overrun_check_free): Protoize.
2953
28272684
PE
29542011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2955
2956 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2957 since callers should never pass a negative size.
2958 Change the signature to match that of plain 'read' and 'write'; see
2959 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2960 * lisp.h: Update prototypes of emacs_write and emacs_read.
2961
11997c76
EZ
29622011-04-11 Eli Zaretskii <eliz@gnu.org>
2963
2964 * xdisp.c (redisplay_window): Don't try to determine the character
2965 position of the scroll margin if the window start point w->startp
e896f03c 2966 is outside the buffer's accessible region. (Bug#8468)
11997c76 2967
8a2cbd72
EZ
29682011-04-10 Eli Zaretskii <eliz@gnu.org>
2969
2970 Fix write-region and its subroutines for buffers > 2GB.
2971 * fileio.c (a_write, e_write): Modify declaration of arguments and
2972 local variables to support buffers larger than 2GB.
2973 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2974
2975 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2976 argument, local variables, and return value.
2977
2978 * lisp.h: Update prototypes of emacs_write and emacs_read.
2979
2980 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2981
4073e537 29822011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2983
1ebfdcb6
PE
2984 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2985
b2ded58d
PE
2986 Fix more problems found by GCC 4.6.0's static checks.
2987
7d66342c
PE
2988 * xdisp.c (vmessage): Use a better test for character truncation.
2989
bbf47d44
PE
2990 * charset.c (load_charset_map): <, not <=, for optimization,
2991 and to avoid potential problems with integer overflow.
9248994d 2992 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2993 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2994 * editfns.c (Fformat): Likewise.
1e69125e 2995 * syntax.c (skip_chars): Likewise.
3befa583 2996
e3019616
PE
2997 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2998 This also lets GCC 4.6.0 generate slightly better loop code.
2999
becfa255
PE
3000 * callint.c (Fcall_interactively): <, not <=, for optimization.
3001 (Fcall_interactively): Count the number of arguments produced,
3002 not the number of arguments given. This is simpler and lets GCC
3003 4.6.0 generate slightly better code.
3004
dae0cd48
PE
3005 * ftfont.c: Distingish more carefully between FcChar8 and char.
3006 The previous code passed unsigned char * to a functions like
3007 strlen and xstrcasecmp that expect char *, which does not
3008 conform to the C standard.
3009 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3010 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3011 char * when the C standard requires it.
3012
76032d70
PE
3013 * keyboard.c (read_char): Remove unused var.
3014
eb3f1cc8
PE
3015 * eval.c: Port to Windows vsnprintf (Bug#8435).
3016 Include <limits.h>.
3017 (SIZE_MAX): Define if the headers do not.
3018 (verror): Do not give up if vsnprintf returns a negative count.
3019 Instead, grow the buffer. This ports to Windows vsnprintf, which
3020 does not conform to C99. Problem reported by Eli Zaretskii.
3021 Also, simplify the allocation scheme, by avoiding the need for
3022 calling realloc, and removing the ALLOCATED variable.
3023
70476b54
PE
3024 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3025
12020a9e
PE
3026 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3027 But keep the doprint source code for now, as we might revamp it
3028 and use it again (Bug#8435).
ea6c7ae6
PE
3029 * lisp.h (doprnt): Remove.
3030 * Makefile.in (base_obj): Remove doprnt.o.
3031 * deps.mk (doprnt.o): Remove.
3032
5fdb398c
PE
3033 error: Print 32- and 64-bit integers portably (Bug#8435).
3034 Without this change, on typical 64-bit hosts error ("...%d...", N)
3035 was used to print both 32- and 64-bit integers N, which relied on
3036 undefined behavior.
3037 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3038 New macro.
3039 * lisp.h (error, verror): Mark as printf-like functions.
3040 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3041 Report overflow in size calculations when allocating printf buffer.
3042 Do not truncate output string at its first null byte.
3043 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3044 Truncate the output at a character boundary, since vsnprintf does not
3045 do that.
3046 * charset.c (check_iso_charset_parameter): Convert internal
3047 character to string before calling 'error', since %c now has the
3048 printf meaning.
3049 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3050 overflow when computing char to be passed to 'error'. Do not
3051 pass Lisp_Object to 'error'; pass the integer instead.
3052 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3053 formatted with plain %d.
3054
b189fa66
PE
3055 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3056
bff87ef0
PE
3057 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3058
7e2cac20
PE
3059 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3060
ce4d90b5
PE
3061 * xterm.c (x_catch_errors): Remove duplicate declaration.
3062
266c9547
PE
3063 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3064
79c49ad2
PE
3065 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3066
368f4090
JM
30672011-04-10 Jim Meyering <meyering@redhat.com>
3068
3069 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3070 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3071 return ssize_t not "int", and use size_t as the buffer length.
3072 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3073 * gnutls.h: Update declarations.
3074 * process.c (read_process_output): Use ssize_t, to match.
3075 (send_process): Likewise.
3076
a32d4040
CY
30772011-04-09 Chong Yidong <cyd@stupidchicken.com>
3078
3079 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3080
8546720e 30812011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3082
04f2d78b
CB
3083 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3084 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3085
8546720e
GM
3086 * xterm.c (handle_one_xevent):
3087 * xmenu.c (create_and_show_popup_menu):
3088 * xselect.c (x_decline_selection_request)
3089 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3090
0a2f5c1a 30912011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3092
3093 Fix some uses of `int' instead of EMACS_INT.
3094 * search.c (string_match_1, fast_string_match)
3095 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3096 (scan_buffer, find_next_newline_no_quit)
3097 (find_before_next_newline, search_command, Freplace_match)
3098 (Fmatch_data): Make some `int' variables be EMACS_INT.
3099
3100 * xdisp.c (display_count_lines): 3rd argument and return value now
3101 EMACS_INT. All callers changed.
3102 (pint2hrstr): Last argument is now EMACS_INT.
3103
3104 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3105 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3106 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3107 (decode_coding_utf_16, decode_coding_emacs_mule)
3108 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3109 (decode_coding_ccl, decode_coding_charset)
3110 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3111 (decode_coding_iso_2022, decode_coding_emacs_mule)
3112 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3113 <char_offset, last_offset>: Declare EMACS_INT.
3114 (encode_coding_utf_8, encode_coding_utf_16)
3115 (encode_coding_emacs_mule, encode_invocation_designation)
3116 (encode_designation_at_bol, encode_coding_iso_2022)
3117 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3118 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3119 Declare EMACS_INT.
3120 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3121 (encode_invocation_designation): Last argument P_NCHARS is now
3122 EMACS_INT.
3123 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3124 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3125
3126 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3127 All users changed.
3128
3129 * ccl.c (Fccl_execute_on_string): Declare some variables
3130 EMACS_INT.
3131
8546720e 31322011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3133
3134 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3135
4e19a977
CS
31362011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3137
3138 * process.c (Fformat_network_address): Doc fix.
3139
87302331
R
31402011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3141
3142 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3143
cbb59342
CY
31442011-04-08 Chong Yidong <cyd@stupidchicken.com>
3145
3146 * keyboard.c (read_char): Call Lisp function help-form-show,
3147 instead of using internal_with_output_to_temp_buffer.
3148 (Qhelp_form_show): New var.
e0d38eeb 3149 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3150
3151 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3152
3153 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3154
e67a13ab
CY
31552011-04-06 Chong Yidong <cyd@stupidchicken.com>
3156
04f2d78b
CB
3157 * process.c (Flist_processes): Remove to Lisp.
3158 (list_processes_1): Delete.
e67a13ab 3159
973f782d
EZ
31602011-04-06 Eli Zaretskii <eliz@gnu.org>
3161
7c106b1e
EZ
3162 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3163
973f782d
EZ
3164 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3165
41cf7d1a 31662011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3167
ca23cc88
PE
3168 Fix more problems found by GCC 4.6.0's static checks.
3169
f390e2d5
PE
3170 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3171
42eea0d0
PE
3172 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3173
b69769da 3174 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3175
f9541e84
PE
3176 * xdisp.c (vmessage): Mark as a printf-like function.
3177
13841b55
PE
3178 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3179
c136c10f
PE
3180 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3181
5e2d4a30
PE
3182 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3183 printf-like functions.
3184 (tiff_load): Add casts to remove these marks before passing them
3185 to system-supplied API.
3186
583f48b9
PE
3187 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3188
b25d760e
PE
3189 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3190 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3191 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3192 directly, rather than having caller test rule sign. This avoids
3193 some unnecessary tests.
3194 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3195 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3196 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3197
bc7b6697 3198 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3199 (xfont_open): Avoid unnecessary tests.
bc7b6697 3200
27ccc379
PE
3201 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3202
dcd5c89a
PE
3203 * composite.h, composite.c (composition_gstring_put_cache):
3204 Use EMACS_INT, not int, for length.
3205
b13a45c6
PE
3206 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3207 breaking out part of COMPOSITION_DECODE_RULE.
3208 (COMPOSITION_DECODE_RULE): Use it.
3209 * composite.c (get_composition_id): Remove unused local vars,
3210 by using the new macro.
3211
1e792e4d
PE
3212 * textprop.c (set_text_properties_1): Change while to do-while,
3213 since the condition is always true at first.
3214
dc6c6455 3215 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3216 (interval_deletion_adjustment): Return unsigned value.
3217 All uses changed.
dc6c6455 3218
aba7731a
PE
3219 * process.c (list_processes_1, create_pty, read_process_output):
3220 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3221 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3222 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3223 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3224 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3225
fdfc4bf3
PE
3226 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3227
fca8fe46 3228 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3229 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3230
06a0259a 3231 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3232 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3233 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3234
e7b9e80f
PE
3235 * print.c (print_error_message): Avoid int overflow.
3236
56201685
PE
3237 * font.c (font_list_entities): Redo for clarity,
3238 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3239
78834453 3240 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3241 (font_score): Avoid potential overflow in diff calculation.
78834453 3242
0bc0b309 3243 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3244 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3245
e610eaca
PE
3246 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3247
b895abce
PE
3248 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3249 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3250 can always succeed if overflow has undefined behavior.
3251
1f1d9321 3252 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3253 (wordify): Omit three unnecessary tests.
1f1d9321 3254
c59478bc
PE
3255 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3256 All callers changed. This avoids the need for an unused var.
3257
79b73827
PE
3258 * casefiddle.c (casify_region): Remove var that is set but not used.
3259
a4db5dfe
PE
3260 * dired.c (file_name_completion): Remove var that is set but not used.
3261
43aae36e
PE
3262 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3263
2a47c44d 3264 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3265 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3266
a37c69bf
PE
3267 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3268 Check for integer overflow on size calculations.
3269
328ab8e7
PE
3270 * buffer.c (Fprevious_overlay_change): Remove var that is set
3271 but not used.
3272
e5a2a5cb
PE
3273 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3274 Remove vars that are set but not used.
8d84a6eb 3275 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3276 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3277
a60e5f68
PE
3278 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3279
f661cb61 3280 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3281 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3282
f0397f5a
PE
3283 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3284 that are set but not used.
3285
8664db06 3286 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3287 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3288
6abdaa4a
PE
3289 * xselect.c (x_get_local_selection, x_handle_property_notify):
3290 Remove vars that are set but not used.
3291
0ce7538d 3292 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3293 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3294
9ae848fc
PE
3295 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3296 Remove var that is set but not used.
0b918413
PE
3297 (scroll_bar_windows_size): Now size_t, not int.
3298 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3299 Check for overflow.
9ae848fc 3300
a5a62657
PE
3301 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3302 (map_tty_color) [!defined MSDOS]: Likewise.
3303
5c5cdd39
PE
3304 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3305
66ebf983
PE
3306 * coding.c: Remove vars that are set but not used.
3307 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3308 All callers changed.
3309 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3310 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3311 (decode_coding_charset): Remove vars that are set but not used.
3312
1be4d761
PE
3313 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3314 that is set but not used.
3315
47553fa8
PE
3316 * print.c (print_object): Remove var that is set but not used.
3317
1f7196bf 3318 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3319 The gnulib version avoids calling malloc in the usual case,
3320 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3321 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3322 * filelock.c (current_lock_owner): Likewise.
3323 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3324 * sysdep.c: Include allocator.h, careadlinkat.h.
3325 (emacs_no_realloc_allocator): New static constant.
3326 (emacs_readlink): New function.
fdb61804
PE
3327 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3328 ../lib/careadlinkat.h.
d1fdcab7 3329
f84c17c7
SM
33302011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3331
3332 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3333 first non-nil return value).
3334
ef3862ad
JD
33352011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3336
3337 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3338 if not defined (Bug#8403).
3339
376a7006
JB
33402011-04-02 Juanma Barranquero <lekktu@gmail.com>
3341
3342 * xdisp.c (display_count_lines): Remove parameter `start',
3343 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3344 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3345 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3346 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3347 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3348 and thereabouts. All callers changed.
3349 (get_per_char_metric): Remove parameter `f', unused since
3350 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3351
6ca3801d
JM
33522011-04-02 Jim Meyering <meyering@redhat.com>
3353
3354 do not dereference NULL upon failed strdup
3355 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3356 (ns_get_family): Likewise.
3357
d8e2b5ba
JB
33582011-04-02 Juanma Barranquero <lekktu@gmail.com>
3359
3360 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3361
8c74fcbd
JD
33622011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3363
3364 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3365 later (Bug#8403).
3366
7200d79c
SM
33672011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3368
03408648 3369 Add lexical binding.
7200d79c 3370
03408648
SM
3371 * window.c (Ftemp_output_buffer_show): New fun.
3372 (Fsave_window_excursion):
3373 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3374
3375 * lread.c (lisp_file_lexically_bound_p): New function.
3376 (Fload): Bind Qlexical_binding.
3377 (readevalloop): Remove `evalfun' arg.
3378 Bind Qinternal_interpreter_environment.
3379 (Feval_buffer): Bind Qlexical_binding.
3380 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3381 Mark as dynamic.
3382 (syms_of_lread): Declare `lexical-binding'.
3383
3384 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3385
3386 * keyboard.c (eval_dyn): New fun.
3387 (menu_item_eval_property): Use it.
ca105506
SM
3388
3389 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3390
03408648
SM
3391 * fns.c (concat, mapcar1): Accept byte-code-functions.
3392
3393 * eval.c (Fsetq): Handle lexical vars.
3394 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3395 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3396 (FletX, Flet): Obey lexical binding.
3397 (Fcommandp): Handle closures.
3398 (Feval): New `lexical' arg.
3399 (eval_sub): New function extracted from Feval. Use it almost
3400 everywhere where Feval was used. Look up vars in lexical env.
3401 Handle closures.
3402 (Ffunctionp): Move from subr.el.
3403 (Ffuncall): Handle closures.
3404 (apply_lambda): Remove `eval_flags'.
3405 (funcall_lambda): Handle closures and new byte-code-functions.
3406 (Fspecial_variable_p): New function.
3407 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3408 but without exporting it to Lisp.
23aba0ea 3409
23aba0ea 3410 * doc.c (Fdocumentation, store_function_docstring):
03408648 3411 * data.c (Finteractive_form): Handle closures.
23aba0ea 3412
03408648
SM
3413 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3414 interactive spec.
ba83908c 3415
04f2d78b
CB
3416 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3417 New byte-codes.
03408648
SM
3418 (exec_byte_code): New function extracted from Fbyte_code to handle new
3419 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3420
03408648 3421 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3422
03408648 3423 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3424
e2abce01
JB
34252011-03-31 Juanma Barranquero <lekktu@gmail.com>
3426
3427 * xdisp.c (redisplay_internal): Fix prototype.
3428
63696a73 34292011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3430
63696a73 3431 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3432 (try_scrolling): Use it when setting scroll_limit.
3433 Limit scrolling to 100 screen lines.
63696a73
EZ
3434 (redisplay_window): Even when falling back on "recentering",
3435 position point in the window according to scroll-conservatively,
3436 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3437
3438 (try_scrolling): When point is above the window, allow searching
3439 as far as scroll_max, or one screenful, to compute vertical
3440 distance from PT to the scroll margin position. This prevents
3441 try_scrolling from unnecessarily failing when
3442 scroll-conservatively is set to a value slightly larger than the
3443 window height. Clean up the case of PT below the margin at bottom
3444 of window: scroll_max can no longer be INT_MAX. When aggressive
3445 scrolling is in use, don't let point enter the opposite scroll
3446 margin as result of the scroll.
3447 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3448 threshold of 100 lines for never-recentering scrolling.
3449
e4cc2dfc
JB
34502011-03-31 Juanma Barranquero <lekktu@gmail.com>
3451
3452 * dispextern.h (move_it_by_lines):
3453 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3454 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3455 (message_log_check_duplicate): Remove parameters `prev_bol' and
3456 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3457 (redisplay_internal): Remove parameter `preserve_echo_area',
3458 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3459
3460 * indent.c (Fvertical_motion):
3461 * window.c (window_scroll_pixel_based, Frecenter):
3462 Don't pass `need_y_p' to `move_it_by_lines'.
3463
1c470562
SM
34642011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3465
44f230aa
SM
3466 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3467 steal a few bits to be more compact.
3468 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3469 Remove unneeded casts.
3470
1c470562
SM
3471 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3472
888adce9
ZK
34732011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3474
3475 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3476 binding" message (bug#7967).
3477
f838ed7b
PE
34782011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3479
77861b95
PE
3480 Fix more problems found by GCC 4.6.0's static checks.
3481
de6dbc14
PE
3482 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3483 Remove unused local var.
3484
f838ed7b
PE
3485 * editfns.c (Fmessage_box): Remove unused local var.
3486
792c7b2b
PE
3487 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3488 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3489 Omit unused local vars.
c499e557 3490 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3491 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3492 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3493 Omit unused local var.
3494
ba0165e1
PE
3495 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3496 Don't assume string length fits in int.
32ad8845 3497 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3498 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3499
3c59b4c9
PE
3500 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3501 instead of alloca (Bug#8344).
3502
a3eed478 3503 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3504 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3505
eb4d412d
PE
3506 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3507
1658b401
PE
3508 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3509 concerns.
3510
3511 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3512
3513 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3514
9a2c6e05
PE
3515 * keyboard.c (syms_of_keyboard): Use the same style as later
3516 in this function when indexing through an array. This also
3517 works around GCC bug 48267.
3518
03d0a109
PE
3519 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3520
44f730c8
PE
3521 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3522
fe75f926
PE
3523 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3524 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3525
ffa8c828
PE
3526 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3527 This avoids undefined behavior on integer overflow, and is a bit
3528 more convenient anyway since it is compared to a size_t variable.
3529
c5101a77
PE
3530 Variadic C functions now count arguments with size_t, not int.
3531 This avoids an unnecessary limitation on 64-bit machines, which
3532 caused (substring ...) to crash on large vectors (Bug#8344).
3533 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3534 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3535 All variadic functions and their callers changed accordingly.
c5101a77
PE
3536 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3537 * data.c (arith_driver, float_arith_driver): Likewise.
3538 * editfns.c (general_insert_function): Likewise.
3539 * eval.c (struct backtrace.nargs, interactive_p)
3540 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3541 (funcall_lambda, mark_backtrace): Likewise.
3542 * fns.c (concat): Likewise.
3543 * frame.c (x_set_frame_parameters): Likewise.
3544 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3545 0 if not found, not -1. All callers changed.
3546
dd3f25f7
PE
3547 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3548 (stack_copy_size): Now size_t, not int.
3549 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3550
461c2ab9
JB
35512011-03-28 Juanma Barranquero <lekktu@gmail.com>
3552
3553 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3554 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3555 All callers changed.
3556
3557 * lisp.h (multibyte_char_to_unibyte):
3558 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3559 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3560 * character.h (CHAR_TO_BYTE8):
3561 * cmds.c (internal_self_insert):
3562 * editfns.c (general_insert_function):
3563 * keymap.c (push_key_description):
3564 * search.c (Freplace_match):
3565 * xdisp.c (message_dolog, set_message_1): All callers changed.
3566
f6d62986
SM
35672011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3568
3569 * keyboard.c (safe_run_hook_funcall): New function.
3570 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3571 don't set the hook to nil, but remove the offending function instead.
3572 (Qcommand_hook_internal): Remove, unused.
3573 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3574 Vcommand_hook_internal.
3575
3576 * eval.c (enum run_hooks_condition): Remove.
3577 (funcall_nil, funcall_not): New functions.
3578 (run_hook_with_args): Call each function through a `funcall' argument.
3579 Remove `cond' argument, now redundant.
3580 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3581 (Frun_hook_with_args_until_failure): Adjust accordingly.
3582 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3583
1db5b1ad
JB
35842011-03-28 Juanma Barranquero <lekktu@gmail.com>
3585
3586 * dispextern.h (string_buffer_position): Remove declaration.
3587
3588 * print.c (strout): Remove parameter `multibyte', unused since
3589 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3590
3591 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3592 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3593 All callers changed.
3594
3595 * w32.c (_wsa_errlist): Use braces for struct initializers.
3596
3597 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3598 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3599 All callers changed.
3600 (string_buffer_position): Likewise. Also, make static (it's never
3601 used outside xdisp.c).
3602 (cursor_row_p): Remove parameter `w', unused since
3603 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3604 (decode_mode_spec): Remove parameter `precision', introduced during
3605 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3606 All callers changed.
3607
5ffb62aa
JD
36082011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3609
3610 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3611
461c2ab9 36122011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3613
3614 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3615 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3616 (ns_update_auto_hide_menu_bar): New functions.
3617 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3618 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3619 ns_constrain_all_frames.
3620 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3621 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3622
5c380ffb
JD
36232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3624
3625 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3626
9af30bdf
GM
36272011-03-27 Glenn Morris <rgm@gnu.org>
3628
3629 * syssignal.h: Replace RETSIGTYPE with void.
3630 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3631 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3632 Replace SIGTYPE with void everywhere.
3633 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3634 * s/template.h (SIGTYPE): Remove commented out definition.
3635
e2abce01
JB
36362011-03-26 Eli Zaretskii <eliz@gnu.org>
3637
3638 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3639 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3640
f868cd8a
JB
36412011-03-26 Juanma Barranquero <lekktu@gmail.com>
3642
59eb0929
JB
3643 * w32.c (read_unc_volume): Use parameter `henum', instead of
3644 global variable `wget_enum_handle'.
3645
3646 * keymap.c (describe_vector): Remove parameters `indices' and
3647 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3648 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3649
f868cd8a
JB
3650 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3651
3652 * keyboard.c (timer_check): Remove parameter `do_it_now',
3653 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3654 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3655 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3656
3657 * keyboard.c (read_char):
3658 * w32menu.c (w32_menu_display_help):
3659 * xmenu.c (show_help_event, menu_help_callback):
3660 Adjust calls to `show_help_echo'.
3661
3662 * gtkutil.c (xg_maybe_add_timer):
3663 * keyboard.c (readable_events):
3664 * process.c (wait_reading_process_output):
3665 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3666
3667 * insdel.c (adjust_markers_gap_motion):
3668 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3669 (gap_left, gap_right): Don't call it.
3670
2ecf6fdb
CY
36712011-03-25 Chong Yidong <cyd@stupidchicken.com>
3672
3673 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3674 incurred during fontification.
3675
6b1f9ba4
JB
36762011-03-25 Juanma Barranquero <lekktu@gmail.com>
3677
3678 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3679 (DEFVAR_PER_BUFFER): Don't pass it.
3680
3681 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3682 (scrolling_window): Don't pass it.
3683
0f4a96b5
JB
36842011-03-25 Juanma Barranquero <lekktu@gmail.com>
3685
3686 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3687
3688 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3689 and `suffix'.
3690 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3691 of variables specific to SELinux and computation of `encoded_absname'.
3692
3693 * image.c (XPutPixel): Remove unused variable `height'.
3694
3695 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3696
3697 * unexw32.c (get_section_info): Remove unused variable `section'.
3698
3699 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3700 (system_process_attributes): Remove unused variable `sess'.
3701 (sys_read): Remove unused variable `err'.
3702
3703 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3704 (w32_wnd_proc): Remove unused variable `isdead'.
3705 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3706 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3707 (x_create_tip_frame): Remove unused variable `tem'.
3708
3709 * w32inevt.c (w32_console_read_socket):
3710 Remove unused variable `no_events'.
3711
3712 * w32term.c (x_draw_composite_glyph_string_foreground):
3713 Remove unused variable `width'.
3714
1149507c
JB
37152011-03-24 Juanma Barranquero <lekktu@gmail.com>
3716
3717 * w32term.c (x_set_glyph_string_clipping):
3718 Don't pass uninitialized region to CombineRgn.
3719
9c88f339
JB
37202011-03-23 Juanma Barranquero <lekktu@gmail.com>
3721
3722 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3723 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3724 (Fx_close_connection): Remove unused variable `i'.
3725
3726 * w32font.c (w32font_draw): Return number of glyphs.
3727 (w32font_open_internal): Remove unused variable `i'.
3728 (w32font_driver): Add missing initializer.
3729
3730 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3731 (fill_in_menu): Remove unused variable `items_added'.
3732
3733 * w32term.c (last_mouse_press_frame): Remove static global variable.
3734 (w32_clip_to_row): Remove unused variable `f'.
3735 (x_delete_terminal): Remove unused variable `i'.
3736
3737 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3738 (NOTHING): Remove unused static global variable.
3739 (uniscribe_check_otf): Remove unused variable `table'.
3740 (uniscribe_font_driver): Add missing initializers.
3741
dee091a3
JD
37422011-03-23 Julien Danjou <julien@danjou.info>
3743
3744 * term.c (Fsuspend_tty, Fresume_tty):
3745 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3746 * window.c (temp_output_buffer_show):
3747 * insdel.c (signal_before_change):
3748 * frame.c (Fhandle_switch_frame):
3749 * fileio.c (Fdo_auto_save):
3750 * emacs.c (Fkill_emacs):
3751 * editfns.c (save_excursion_restore):
3752 * cmds.c (internal_self_insert):
3753 * callint.c (Fcall_interactively):
3754 * buffer.c (Fkill_all_local_variables):
3755 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3756 Use Frun_hooks.
0f4a96b5 3757 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3758 unconditionnaly since it does the check itself.
3759
2c520ab5 37602011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3761
c9c49752
PE
3762 Fix more problems found by GCC 4.5.2's static checks.
3763
8abc3f12
PE
3764 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3765 the first time through the loop, since we know p0 < p1 then.
3766 This also avoids a gcc -Wstrict-overflow warning.
3767
a2d26660
PE
3768 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3769 leading to a memory leak, possible in functions like
3770 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3771 of objects (Bug#8318).
a2d26660 3772
916c72e9
PE
3773 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3774 that could (at least in theory) be that large.
3775
19ab8a18
PE
3776 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3777 This is less likely to overflow, and avoids undefined behavior if
3778 overflow does occur. All callers changed. Use strtoul to scan
3779 for the unsigned long integer.
b7cbbd6f
PE
3780 (pint2hrstr): Simplify and tune code slightly.
3781 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3782
f0641eff
PE
3783 * scroll.c (do_scrolling): Work around GCC bug 48228.
3784 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3785
7f650bb9
PE
3786 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3787 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3788 (validate_x_resource_name): Simplify count usage.
3789 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3790
37dd57d1
PE
3791 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3792 fail (Bug#8306).
81e56e61 3793
699979fc 3794 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3795
401bf9b4
PE
3796 * process.c (Fmake_network_process): Use socklen_t, not int,
3797 where POSIX says socklen_t is required in portable programs.
3798 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3799 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3800 (Fmake_network_process, server_accept_connection):
3801 (wait_reading_process_output, read_process_output):
3802 Likewise.
3803
b93aacde
PE
3804 * process.c: Rename or move locals to avoid shadowing.
3805 (list_processes_1, Fmake_network_process):
3806 (read_process_output_error_handler, exec_sentinel_error_handler):
3807 Rename or move locals.
4dc343ee 3808 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3809 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3810 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3811 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3812 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3813
af8a867c 3814 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3815 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3816 Include tparam.h instead, since it declares them.
af8a867c
PE
3817 * cm.h (PC): Remove extern decl; tparam.h now does this.
3818 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3819 * terminfo.c: Include tparam.h, to check interfaces.
3820 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3821 (tparam): Adjust signature to match interface in tparam.h;
3822 this removes some undefined behavior. Check that outstring and len
3823 are zero, which they always are with Emacs.
3824 * tparam.h (PC, BC, UP): New extern decls.
3825
0248044d 3826 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3827 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3828
8ff096c1 3829 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3830 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3831 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3832 (ftfont_list): Remove unused local.
49eaafba
PE
3833 (get_adstyle_property, ftfont_pattern_entity):
3834 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3835 Rename locals to avoid shadowing.
8ff096c1 3836
e2be39f6
PE
3837 * xfont.c (xfont_list_family): Mark var as initialized.
3838
c9735e30
PE
3839 * xml.c (make_dom): Now static.
3840
8f5201ae
PE
3841 * composite.c (composition_compute_stop_pos): Rename local to
3842 avoid shadowing.
b246f932
PE
3843 (composition_reseat_it): Remove unused locals.
3844 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3845 (composition_update_it): Mark var as initialized.
11b61122
PE
3846 (find_automatic_composition): Mark vars as initialized,
3847 with a FIXME (Bug#8290).
8f5201ae 3848
760fbc2c
PE
3849 character.h: Rename locals to avoid shadowing.
3850 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3851 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3852 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3853 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3854 to avoid shadowing.
3855
ff08eb85
PE
3856 * textprop.c (property_change_between_p): Remove; unused.
3857
fc7bf025
PE
3858 * intervals.c (interval_start_pos): Now static.
3859
235d7abc
PE
3860 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3861
44f230aa
SM
3862 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3863 Rename locals to avoid shadowing.
3e7d6594 3864
50060332
PE
3865 * sound.c (wav_play, au_play, Fplay_sound_internal):
3866 Fix pointer signedness.
d01f234b 3867 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3868 (wav_play): Initialize a variable to 0, to prevent undefined
3869 behavior (Bug#8278).
50060332 3870
c4fc4e30
PE
3871 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3872
918436ed
PE
3873 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3874
c939f91b
PE
3875 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3876 clobbering (Bug#8298).
b9c7f648
PE
3877 * sysdep.c (sys_subshell): Likewise.
3878 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3879
6bd8c144
PE
3880 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3881 This should get cleaned up, so that child_setup has the
3882 same signature on all platforms.
3883
7710357c 3884 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3885 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3886
c59da222
CY
38872011-03-22 Chong Yidong <cyd@stupidchicken.com>
3888
3889 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3890 not to be necessary, and produces flickering.
3891
66b87493
GM
38922011-03-20 Glenn Morris <rgm@gnu.org>
3893
3894 * config.in: Remove file.
3895
45b6f6d5
JB
38962011-03-20 Juanma Barranquero <lekktu@gmail.com>
3897
3898 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3899 are now in src/globals.h.
3900 (syms_of_minibuf): Remove spurious & from previous change.
3901
3ec03f7e
LL
39022011-03-20 Leo <sdl.web@gmail.com>
3903
3904 * minibuf.c (completing-read-function): New variable.
3905 (completing-read-default): Rename from completing-read.
3906 (completing-read): Call completing-read-function.
3907
b14e3e21
CY
39082011-03-19 Juanma Barranquero <lekktu@gmail.com>
3909
3910 * xfaces.c (Fx_load_color_file):
3911 Read color file from absolute filename (bug#8250).
3912
f2b726e6
JB
39132011-03-19 Juanma Barranquero <lekktu@gmail.com>
3914
3915 * makefile.w32-in: Update dependencies.
3916
09f6ff02
EZ
39172011-03-17 Eli Zaretskii <eliz@gnu.org>
3918
3919 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3920
29a6015a
PE
39212011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3922
a3a6c54e
PE
3923 Fix more problems found by GCC 4.5.2's static checks.
3924
b766f867
PE
3925 * process.c (make_serial_process_unwind, send_process_trap):
3926 (sigchld_handler): Now static.
3927
be02381c
PE
3928 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3929 That way, the code declares only the vars that it needs.
3930 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3931 * s/cygwin.h (PTY_ITERATION): Likewise.
3932 * s/darwin.h (PTY_ITERATION): Likewise.
3933 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3934
57048744
PE
3935 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3936 * process.c (allocate_pty): Don't declare stb unless it's needed.
3937
7914961c 3938 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3939 (CONSTANTLIM): Remove; unused.
3940 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3941 Define only if needed.
7914961c 3942
b3967b18
PE
3943 * unexelf.c (unexec): Name an expression,
3944 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3945 Use a different way to cause a compilation error if anyone uses
3946 n rather than nn, a way that does not involve shadowing.
73366a00 3947 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3948
29a6015a
PE
3949 * deps.mk (unexalpha.o): Remove; unused.
3950
43cfc33e 3951 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3952 * unexec.h: New file.
ce701a33
PE
3953 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3954 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3955 Depend on unexec.h.
3956 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3957 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3958 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3959 Change as necessary to match prototype in unexec.h.
ce701a33 3960
01f44d5a
PE
3961 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3962 shadowing.
4f63c6bb 3963 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3964
a6670b0b
PE
3965 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3966 Rename locals to avoid shadowing.
3967
cef2010d 3968 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3969 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3970
d4d7173a
PE
3971 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3972
f08b802a
PE
3973 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3974 warning when compiling print.c.
3975
3ddb0639
PE
3976 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3977 instead of using an uninitialized var.
5ad03b97 3978 (font_sort_entities): Mark var as initialized.
3ddb0639 3979
170a2692
PE
3980 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3981
e663c700
PE
3982 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3983 pointers to constants.
89bc529a 3984 (font_parse_fcname): Remove unused vars.
7b81e2d0 3985 (font_delete_unmatched): Now static.
ea838e10 3986 (font_get_spec): Remove; unused.
13a547c6
PE
3987 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3988 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3989 Rename or move locals to avoid shadowing.
e663c700 3990
2a80c887 3991 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3992 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3993
1384fa33 3994 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3995 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3996
8b2c52e9
PE
3997 * alloc.c (mark_backtrace): Move decl from here ...
3998 * lisp.h: ... to here, so that it can be checked.
3999
475545b5 4000 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4001 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4002 (lisp_indirect_variable): Name an expression,
4003 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4004 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4005
b1349114 4006 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4007 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4008 Use const pointer when appropriate.
b1349114 4009
a2928364
PE
4010 * lisp.h (get_system_name, get_operating_system_release):
4011 Move decls here, to check interfaces.
4012 * process.c (get_operating_system_release): Move decl to lisp.h.
4013 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4014 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4015 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4016 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4017 (Fformat_time_string, Fencode_time, Finsert_char):
4018 (Ftranslate_region_internal, Fformat):
4019 Rename or remove local vars to avoid shadowing.
9710023e 4020 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4021
a415e694
PE
4022 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4023 avoid shadowing.
4024
8ef4622d
PE
4025 * lisp.h (eassert): Check that the argument compiles, even if
4026 ENABLE_CHECKING is not defined.
4027
946f9a5b
PE
4028 * data.c (Findirect_variable): Name an expression, to avoid
4029 gcc -Wbad-function-cast warning.
112396d6 4030 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4031 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4032 (Fmake_variable_buffer_local, Fmake_local_variable):
4033 Mark variables as initialized.
52746918 4034 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4035
e5aab7e7 4036 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4037 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4038 Rename locals to avoid shadowing.
dff45157
PE
4039 (mark_stack): Move local variables into the #ifdef region where
4040 they're used.
7bc26fdb
PE
4041 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4042 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4043 needed otherwise.
4044 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4045 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4046 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4047
e5aab7e7
PE
4048 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4049 avoids undefined behavior in theory.
4050
4da60324
PE
4051 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4052
88043301
PE
4053 Use functions, not macros, for up- and down-casing (Bug#8254).
4054 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4055 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4056 to use the following functions instead of these macros.
4057 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4058 EMACS_INT, since callers assume the returned value fits in int.
4059 (upcase1): Likewise, for UPCASE_TABLE.
4060 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4061 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4062 the race-condition problem in the old DOWNCASE.
88043301 4063
19ed5445
PE
4064 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4065 Rename locals to avoid shadowing.
4066 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4067 (regex_compile, re_search_2, re_match_2_internal):
4068 Remove unused local vars.
952db0d7
PE
4069 (FREE_VAR): Rewrite so as not to use empty "else",
4070 which gcc can warn about.
da053e48 4071 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4072 (RETALLOC_IF): Define only if needed.
4073 (WORDCHAR_P): Likewise. This one is never needed, but is used
4074 only in a comment talking about a compiler bug, so put inside
4075 the #if 0 of that comment.
4076 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4077 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4078 Remove; unused.
19ed5445 4079
1f3561e4 4080 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4081 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4082 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4083
ded6f8f7
PE
4084 * search.c (simple_search): Remove unused var.
4085
dbd37a95
PE
4086 * dired.c (compile_pattern): Move decl from here ...
4087 * lisp.h: ... to here, so that it can be checked.
4088 (struct re_registers): New forward decl.
4089
7e47afad
PE
4090 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4091
85f24f61
PE
4092 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4093 All uses changed.
4094 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4095 Rename locals to avoid shadowing.
5671df8f 4096 (Fvertical_motion): Mark locals as initialized.
85f24f61 4097
181aa2be 4098 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4099 (casify_region): Mark local as initialized.
181aa2be 4100
930d429c
PE
4101 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4102
7082eac6
PE
4103 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4104 New macros, so that the caller can use some names other than
4105 gcpro1, gcpro2, etc.
4106 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4107 of the new macros.
4108 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4109 argument, for consistency with GCPRO2_VAR, etc: it is now the
4110 prefix of the variable, not the variable itself. All uses
4111 changed.
38b2c076
PE
4112 * dired.c (directory_files_internal, file_name_completion):
4113 Rename locals to avoid shadowing.
4114
15206ed9
PE
4115 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4116 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4117 dired.c's scmp function, had undefined behavior.
4118 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4119 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4120 * buffer.h: ... to here, because these macros use current_buffer,
4121 and the new implementation with inline functions needs to have
4122 current_buffer in scope now, rather than later when the macros
4123 are used.
4124 (downcase, upcase1): New static inline functions.
4125 (DOWNCASE, UPCASE1): Reimplement using these functions.
4126 This avoids undefined behavior in expressions like
4127 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4128 from race conditions in accessing the global variables
4129 case_temp1 and case_temp2.
4130 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4131 * lisp.h (case_temp1, case_temp2): Remove their decls.
4132 * character.h (ASCII_CHAR_P): Move from here ...
4133 * lisp.h: ... to here, so that the inline functions mentioned
4134 above can use them.
4135
4a6bea26
PE
4136 * dired.c (directory_files_internal_unwind): Now static.
4137
f14b7e14
PE
4138 * fileio.c (file_name_as_directory, directory_file_name):
4139 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4140 Now static.
2893f146
PE
4141 (file_name_as_directory): Use const pointers when appropriate.
4142 (Fexpand_file_name): Likewise. In particular, newdir might
4143 point at constant storage, so make it a const pointer.
fd4ead52 4144 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4145 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4146 signedness issues.
f839df0c
PE
4147 (Fset_file_times, Finsert_file_contents, auto_save_error):
4148 Rename locals to avoid shadowing.
f14b7e14 4149
5716756e 4150 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4151 (Ftry_completion, Fall_completions): Rename or remove locals
4152 to avoid shadowing.
5716756e 4153
b4c3046a
PE
4154 * marker.c (bytepos_to_charpos): Remove; unused.
4155
b45db522
PE
4156 * lisp.h (verify_bytepos, count_markers): New decls,
4157 so that gcc does not warn that these functions aren't declared.
4158
85876d07
PE
4159 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4160 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4161 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4162 (copy_text): Remove unused local var.
85876d07 4163
03d78a21 4164 * filelock.c (within_one_second): Now static.
b3dd38ab 4165 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4166
5df8f01b
PE
4167 * buffer.c (fix_overlays_before): Mark locals as initialized.
4168 (fix_start_end_in_overlays): Likewise. This function should be
4169 simplified by using pointers-to-pointers, but that's a different
4170 matter.
b1d876f1 4171 (switch_to_buffer_1): Now static.
8f54f30a
PE
4172 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4173 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4174
a70072c9 4175 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4176 Fix pointer signedness issue.
edced198
PE
4177 (sys_subshell): Mark local as volatile if checking for lint,
4178 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4179 (MAXPATHLEN): Define only if needed.
a70072c9 4180
a0977c44
PE
4181 * process.c (serial_open, serial_configure): Move decls from here ...
4182 * systty.h: ... to here, so that they can be checked.
4183
a884fdcc
PE
4184 * fns.c (get_random, seed_random): Move extern decls from here ...
4185 * lisp.h: ... to here, so that they can be checked.
4186
604efe86 4187 * sysdep.c (reset_io): Now static.
b8950c94 4188 (wait_for_termination_signal): Remove; unused.
604efe86 4189
38fc62d9
PE
4190 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4191 (copy_keymap_item, append_key, push_text_char_description):
4192 Now static.
1004a21a 4193 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4194 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4195 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4196 (describe_map_tree):
4197 Rename locals to avoid shadowing.
38fc62d9 4198
2f2650da
PE
4199 * keyboard.c: Declare functions static if they are not used elsewhere.
4200 (echo_char, echo_dash, cmd_error, top_level_2):
4201 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4202 (read_char, kbd_buffer_get_event, make_lispy_position):
4203 (make_lispy_event, make_lispy_movement, apply_modifiers):
4204 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4205 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4206 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4207 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4208 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4209
a053e86c 4210 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4211 (mark_kboards): Move decl here ...
4212 * alloc.c (mark_kboards): ... from here.
a053e86c 4213
4752793e
PE
4214 * lisp.h (force_auto_save_soon): New decl.
4215
74f10ca7 4216 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4217 (DEFINE_DUMMY_FUNCTION): New macro.
4218 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4219 Use it.
c03cd23f
PE
4220 (main): Add casts to avoid warnings
4221 if GCC considers string literals to be constants.
74f10ca7 4222
022e70d4
PE
4223 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4224
59d6fe83
PE
4225 * dbusbind.c: Pointer signedness fixes.
4226 (xd_signature, xd_append_arg, xd_initialize):
4227 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4228 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4229 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4230 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4231
78320123
PE
4232 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4233 if GCC considers string literals to be constants.
49cebcca 4234 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4235
35ac2a97
SM
42362011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4237
fb103ca9
SM
4238 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4239 (print_preprocess, print_object): New macro to fix last change.
4240
35ac2a97
SM
4241 * print.c (print_preprocess): Don't forget font objects.
4242
62973b41
JB
42432011-03-16 Juanma Barranquero <lekktu@gmail.com>
4244
4245 * emacs.c (USAGE3): Doc fixes.
4246
0e48bb22
AS
42472011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4248
4249 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4250 structure.
4251
7684e57b
JB
42522011-03-14 Juanma Barranquero <lekktu@gmail.com>
4253
4254 * lisp.h (VWindow_system, Qfile_name_history):
4255 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4256 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4257 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4258
4259 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4260 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4261
4262 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4263 * w32console.c (detect_input_pending, read_input_pending)
4264 (encode_terminal_code):
4265 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4266 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4267 (w32_system_caret_y, Qfile_name_history):
4268 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4269 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4270 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4271 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4272 * w32proc.c (Qlocal, report_file_error):
4273 * w32term.c (Vwindow_system, updating_frame):
4274 * w32uniscribe.c (initialized, uniscribe_font_driver):
4275 Remove unneeded extern declarations.
4276
2aa46d6c
CY
42772011-03-14 Chong Yidong <cyd@stupidchicken.com>
4278
c96bbc66 4279 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4280
cffc6f3b
CY
42812011-03-13 Chong Yidong <cyd@stupidchicken.com>
4282
4283 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4284 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4285 These macros can no longer be used for assignment.
4286
44f230aa
SM
4287 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4288 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4289 (record_buffer_markers, fetch_buffer_markers): New functions for
4290 recording and fetching special buffer markers.
4291 (set_buffer_internal_1, set_buffer_temp): Use them.
4292
4293 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4294
4295 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4296
4297 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4298 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4299
4300 * xdisp.c (hscroll_window_tree):
4301 (reconsider_clip_changes): Use PT instead of BUF_PT.
4302
d251f04b
EZ
43032011-03-13 Eli Zaretskii <eliz@gnu.org>
4304
4305 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4306 $(EMACS_ROOT)/lib/intprops.h.
4307
f0c77cd1
PE
43082011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4309
3eca4629
PE
4310 Fix more problems found by GCC 4.5.2's static checks.
4311
7c86ee98
PE
4312 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4313 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4314 (xg_free_frame_widgets): Make it clear that a local variable is
4315 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4316 (gdk_window_get_screen): Make it clear that this macro is needed
4317 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4318 (int_gtk_range_get_value): New function, which avoids a diagnostic
4319 from gcc -Wbad-function-cast.
4320 (xg_set_toolkit_scroll_bar_thumb): Use it.
4321 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4322 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4323 (get_utf8_string, xg_get_file_with_chooser):
4324 Rename locals to avoid shadowing.
4325 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4326
41729b81
PE
4327 * xgselect.c (xg_select): Remove unused var.
4328
f0c77cd1
PE
4329 * image.c (four_corners_best): Mark locals as initialized.
4330 (gif_load): Initialize transparent_p to zero (Bug#8238).
4331 Mark another local as initialized.
ec6cf4c6 4332 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4333
ce0ad53d 4334 * image.c (clear_image_cache): Now static.
d5d5a617 4335 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4336 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4337 (x_edge_detection): Remove unnecessary cast that
4338 gcc -Wbad-function-cast diagnoses.
2037898d 4339 (gif_load): Fix pointer signedness.
6ae141d6
PE
4340 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4341 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4342
33383987 43432011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4344
d32df629
PE
4345 Improve quality of tests for time stamp overflow.
4346 For example, without this patch (encode-time 0 0 0 1 1
4347 1152921504606846976) returns the obviously-bogus value (-948597
4348 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4349 reports time overflow. See
4350 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4351 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4352 * editfns.c: Include limits.h and intprops.h.
4353 (TIME_T_MIN, TIME_T_MAX): New macros.
4354 (time_overflow): Move earlier, to before first use.
4355 (hi_time, lo_time): New functions, for an accurate test for
4356 out-of-range times.
4357 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4358 (Fget_internal_run_time): Don't assume time_t fits in int.
4359 (make_time): Use list2 instead of Fcons twice.
4360 (Fdecode_time): More accurate test for out-of-range times.
4361 (check_tm_member): New function.
4362 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4363 (lisp_time_argument): Don't rely on undefined left-shift and
4364 right-shift behavior when checking for time stamp overflow.
8be6f318 4365
fe31d94c
PE
4366 * editfns.c (time_overflow): New function, refactoring common code.
4367 (Fformat_time_string, Fdecode_time, Fencode_time):
4368 (Fcurrent_time_string): Use it.
4369
8be6f318
PE
4370 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4371 * dired.c (make_time): Move to ...
4372 * editfns.c (make_time): ... here.
4373 * systime.h: Note the move.
4374
09d9db2c 43752011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4376
126bc0dc
YM
4377 * fringe.c (update_window_fringes): Remove unused variables.
4378
c47cbdfd
YM
4379 * unexmacosx.c (copy_data_segment): Also copy __got section.
4380 (Bug#8223)
4381
7ac80be9
EZ
43822011-03-12 Eli Zaretskii <eliz@gnu.org>
4383
c96bbc66 4384 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4385 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4386 Constify `char *' arguments and their references according to
4387 prototypes in tparam.h.
4388
ecb0f94d 4389 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4390
7ac80be9
EZ
4391 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4392 Adapt all references accordingly.
4393
4394 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4395
ef1fd07e
TT
43962011-03-11 Tom Tromey <tromey@redhat.com>
4397
4398 * buffer.c (syms_of_buffer): Remove obsolete comment.
4399
7ef4b50c
EZ
44002011-03-11 Eli Zaretskii <eliz@gnu.org>
4401
4402 * termhooks.h (encode_terminal_code): Declare prototype.
4403
4404 * msdos.c (encode_terminal_code): Don't declare prototype.
4405
4406 * term.c (encode_terminal_code): Now external again, used by
4407 w32console.c and msdos.c.
4408
44f230aa
SM
4409 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4410 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4411
4b1ec863 44122011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4413
1714f52b 4414 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4415
4b1ec863
PE
4416 * fringe.c (update_window_fringes): Mark locals as initialized
4417 (Bug#8227).
4418 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4419
524c7aa6
PE
4420 * alloc.c (mark_fringe_data): Move decl from here ...
4421 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4422 to check its interface.
4423 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4424
a5c0af81 4425 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4426 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4427 (fontset_font): Mark local as initialized.
a9a06e0b 4428 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4429
b4716021
PE
4430 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4431
811e9bac 4432 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4433 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4434 (x_own_selection, Fx_disown_selection_internal): Rename locals
4435 to avoid shadowing.
4436 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4437
7e3ab302
PE
4438 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4439 so that the caller can use some name other than gcpro1.
4440 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4441 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4442 (Fx_backspace_delete_keys_p):
4443 Use them to avoid shadowing, and rename vars to avoid shadowing.
4444 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4445 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4446 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4447 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4448 Remove unused locals.
7e3ab302
PE
4449 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4450 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4451 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4452 macros.
f78faa98 4453
e2b13473
PE
4454 * xterm.h (x_mouse_leave): New decl.
4455
77f23912
PE
4456 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4457 Remove unused functions.
cdf4ba58
PE
4458 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4459 (x_calc_absolute_position): Now static.
7411c686 4460 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4461 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4462 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4463 unless they are used.
38d0b34a
PE
4464 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4465 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4466 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4467 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4468 (x_error_catcher, x_connection_closed, x_error_handler):
4469 (x_error_quitter, xembed_send_message, x_iconify_frame):
4470 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4471 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4472 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4473
44f230aa
SM
4474 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4475 Rename or move locals to avoid shadowing.
6b463e58 4476 (tty_defined_color, merge_face_heights): Now static.
5967d051 4477 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4478 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4479 does not deduce is never used uninitialized.
73719eba
PE
4480 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4481 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4482
426994c3 4483 * terminal.c (store_terminal_param): Now static.
5489860b 4484
032f1620 4485 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4486 (set_frame_menubar): Remove unused local.
d4323972 4487 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4488 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4489 since they might point to immutable storage.
281585b0
PE
4490 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4491 since it's unused otherwise.
032f1620 4492
367c19e5 4493 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4494 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4495 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4496 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4497 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4498 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4499 does not deduce are never used uninitialized.
70739cbe 4500
07b48fa9
PE
4501 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4502
8868a238 4503 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4504 * window.c (window_loop, size_window):
4505 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4506
7e5cf297 4507 * window.c (display_buffer): Now static.
d6550a9f
PE
4508 (size_window): Mark variables that gcc -Wuninitialized
4509 does not deduce are never used uninitialized.
a586633d
PE
4510 * window.h (check_all_windows): New decl, to forestall
4511 gcc -Wmissing-prototypes diagnostic.
5b555da1 4512 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4513
f6095868
PE
4514 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4515 shadowing.
4516 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4517 Include <limits.h>.
4518 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4519 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4520 (load_charset_map): Mark variables that gcc -Wuninitialized
4521 does not deduce are never used uninitialized.
53df7c11 4522 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4523
f38b440c
PE
4524 * coding.c (coding_set_source, coding_set_destination):
4525 Use "else { /* comment */ }" rather than "else /* comment */;"
4526 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4527 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4528 a block, when the outer 'i' will do.
4529 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4530 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4531 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4532 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4533 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4534 Rename locals to avoid shadowing.
4535 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4536 * coding.c (emacs_mule_char, encode_invocation_designation):
4537 Now static, since they're not used elsewhere.
413bb2db 4538 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4539 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4540 (decode_coding_emacs_mule): Mark variables that gcc
4541 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4542 (detect_coding_iso_2022): Initialize a local variable that might
4543 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4544 this initialization is needed. (Bug#8211)
5f58e762
PE
4545 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4546 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4547 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4548 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4549 Remove unused macros.
f38b440c 4550
232b38b9 4551 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4552 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4553 * character.c (string_count_byte8): Likewise.
232b38b9 4554
fb90da1b
PE
4555 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4556 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4557
fb93dbc2
PE
4558 * chartab.c (copy_sub_char_table): Now static, since it's not used
4559 elsewhere.
5c156ace
PE
4560 (sub_char_table_ref_and_range, char_table_ref_and_range):
4561 Rename locals to avoid shadowing.
bbcd0949 4562 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4563
7d3b3862 4564 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4565 (BIDI_BOB): Remove unused macro.
7d3b3862 4566
6be7d3da
PE
4567 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4568 deduce are never used uninitialized.
c2ed9c8b 4569 * term.c (encode_terminal_code): Likewise.
6be7d3da 4570
75f8807f 4571 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4572
50938595
PE
4573 * tparam.h: New file.
4574 * term.c, tparam.h: Include it.
4575 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4576 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4577 Move these decls to tparam.h, and make them agree with what
4578 is actually in tparam.c. The previous trick of using incompatible
4579 decls in different modules does not conform to the C standard.
4580 All callers of tparam changed to use tparam's actual API.
4581 * tparam.c (tparam1, tparam, tgoto):
4582 Use const pointers where appropriate.
4583
fbceeba2
PE
4584 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4585 * cm.h (struct cm): Likewise.
4586 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4587 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4588 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4589 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4590 (turn_on_face, init_tty): Likewise.
4591 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4592
7f3f1250
PE
4593 * term.c (term_mouse_position): Rename local to avoid shadowing.
4594
e6ca6543
PE
4595 * alloc.c (mark_ttys): Move decl from here ...
4596 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4597
c40f8d15
AS
45982011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4599
4600 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4601
cfe0661d
JB
46022011-03-09 Juanma Barranquero <lekktu@gmail.com>
4603
4604 * search.c (compile_pattern_1): Remove argument regp, unused since
4605 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4606 (compile_pattern): Don't pass it.
4607
0afb4571
J
46082011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4609
4610 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4611 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4612 for ! HAVE_GTK3.
4613 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4614
4615 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4616
4617 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4618 gdk_window_get_screen, gdk_window_get_geometry,
4619 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4620 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4621 (xg_get_pixbuf_from_pixmap): New function.
4622 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4623 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4624 Call xg_get_pixbuf_from_pixmap instead of
4625 gdk_pixbuf_get_from_drawable.
4626 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4627 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4628 (xg_check_special_colors): Use GtkStyleContext and its functions
4629 for HAVE_GTK3.
4630 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4631 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4632 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4633 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4634 Call gtk_widget_get_preferred_size.
0afb4571
J
4635 (xg_frame_resized): gdk_window_get_geometry only takes 5
4636 parameters.
44f230aa
SM
4637 (xg_win_to_widget, xg_event_is_for_menubar):
4638 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4639 (xg_set_widget_bg): New function.
4640 (delete_cb): New function.
895009e1 4641 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4642 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4643 (xg_set_background_color): Call xg_set_widget_bg.
4644 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4645 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4646 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4647 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4648 if ! HAVE_GTK3.
4649 (update_frame_tool_bar): Call gtk_widget_hide.
4650 (xg_initialize): Use GDK_KEY_g.
4651
4652 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4653 if ! HAVE_GTK3
4654 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4655
4656 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4657 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4658 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4659
1c2cc4ef
JB
46602011-03-08 Juanma Barranquero <lekktu@gmail.com>
4661
4662 * w32xfns.c (select_palette): Check success of RealizePalette against
4663 GDI_ERROR, not zero.
4664
33383987 4665See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4666
4667;; Local Variables:
4668;; coding: utf-8
aac0c6e3
MR
4669;; End:
4670
33383987 4671 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4672
4673 This file is part of GNU Emacs.
4674
4675 GNU Emacs is free software: you can redistribute it and/or modify
4676 it under the terms of the GNU General Public License as published by
4677 the Free Software Foundation, either version 3 of the License, or
4678 (at your option) any later version.
4679
4680 GNU Emacs is distributed in the hope that it will be useful,
4681 but WITHOUT ANY WARRANTY; without even the implied warranty of
4682 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4683 GNU General Public License for more details.
4684
4685 You should have received a copy of the GNU General Public License
4686 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.