nt/config.nt: Sync with autogen/config.in.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ffd817eb
JD
12012-07-29 Jan Djärv <jan.h.d@swipnet.se>
2
3 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
4 setting sitelisp (Bug#12010).
5
417a7a0e
EZ
62012-07-29 Eli Zaretskii <eliz@gnu.org>
7
8 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
9
10 * w32heap.c (cache_system_info):
11 * w32.c (sys_rename):
12 * w32proc.c (find_child_console, sys_kill): All users changed.
13
387d4d92
PE
142012-07-29 Paul Eggert <eggert@cs.ucla.edu>
15
16 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
17
55a6cca6
EZ
182012-07-29 Eli Zaretskii <eliz@gnu.org>
19
20 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
21
dbcf001c
DA
222012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
23
24 Cleanup statistics calculation in Fgarbage_collect.
25 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
26 zombies percentage calculation. Simplify elapsed time calculation.
27
e2688e4a
DA
282012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
29
30 Generalize marker debugging code under MARKER_DEBUG and use eassert.
31 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
32 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
33 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
34 (replace_range, replace_range_2, del_range_2): Change to eassert.
35 * marker.c (byte_char_debug_check): Adjust style.
36
b46a6a83
PE
372012-07-29 Paul Eggert <eggert@cs.ucla.edu>
38
39 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
40 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
41 long-ago-commented-out code that talks about "WIN32".
42 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
43 All uses changed.
44
e32a5799
PE
452012-07-28 Paul Eggert <eggert@cs.ucla.edu>
46
47 Use Gnulib stdalign module (Bug#9772, Bug#9960).
48 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
49 Simplify by using alignof.
50 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
51 * lisp.h: Include <stdalign.h>.
52 (GCALIGNMENT): New macro and constant.
53 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
54 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
55 (stdalign): New macro, if not already defined.
56
df81cd29
EZ
572012-07-28 Eli Zaretskii <eliz@gnu.org>
58
01bd1b0d
EZ
59 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
60 * w32inevt.c: Include w32inevt.h.
61 (w32_read_console_input): New inline function, calls either
62 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
63 w32_console_unicode_input.
64 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
65 (w32_kbd_patch_key, key_event): Use the codepage returned by
66 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
67 (key_event): use uChar.UnicodeChar only if
68 w32_console_unicode_input is non-zero.
69
70 * w32console.c: Include w32heap.h.
71 <w32_console_unicode_input>: New global variable.
72 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
73 family of Windows, zero otherwise.
74
75 * w32inevt.h: Declare w32_console_unicode_input.
76
df81cd29
EZ
77 * xdisp.c (init_iterator): Don't reference tip_frame in a build
78 --without-x. (Bug#11742)
79
c20fdd9e
PE
802012-07-27 Paul Eggert <eggert@cs.ucla.edu>
81
82 Adjust GDB to reflect pvec_type changes (Bug#12036).
83 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
84 2012-07-04 changes to pseudovector representation. Problem
85 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
86
32770973 872012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
88
89 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
90 bus address.
91 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
92
3438fe21
EZ
932012-07-27 Eli Zaretskii <eliz@gnu.org>
94
bcfbc9de
EZ
95 * alloc.c (listn): Fix the order the arguments are consed onto the
96 list.
97
3438fe21
EZ
98 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
99 enumeration constants, as PURE and HEAP are too general, and clash
100 with other headers and sources, such as gmalloc.c and the
101 MS-Windows system headers. All users changed.
102
eeaea515
DA
1032012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
104
105 Revert last save_excursion_save and save_excursion_restore changes.
106 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
107 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
108
073c88c2
DA
1092012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
110
111 Fix recently-introduced typos in Windows port.
112 Reported by Martin Rudalics <rudalics@gmx.at>.
113 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 114 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 115
4706125e
PE
1162012-07-27 Paul Eggert <eggert@cs.ucla.edu>
117
118 Improve GDB symbol export (Bug#12036).
119 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
120 arms of an 'if', not using conditional expressions; otherwise GDB
121 complains about the types in the unevaluated arm when the argument
122 is an integer literal.
123 (xgetint): Simplify expression.
124 * alloc.c (gdb_make_enums_visible): New constant. This ports to
125 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
126 Zaretskii in <http://bugs.gnu.org/12036#13>.
127 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
128 needed now that we have gdb_make_enums_visible.
129 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
130 (enum enum_USE_LSB_TAG):
131 New enum types, packaging up enums that need to be exported to GDB.
132
694b6c97
DA
1332012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
134
135 Utility function to make a list from specified amount of objects.
136 * lisp.h (enum constype): New datatype.
137 (listn): New prototype.
138 * alloc.c (listn): New function.
139 (Fmemory_use_count, syms_of_alloc): Use it.
140 * buffer.c (syms_of_buffer): Likewise.
141 * callint.c (syms_of_callint): Likewise.
142 * charset.c (define_charset_internal): Likewise.
143 * coding.c (syms_of_coding): Likewise.
144 * keymap.c (syms_of_keymap): Likewise.
145 * search.c (syms_of_search): Likewise.
146 * syntax.c (syms_of_syntax): Likewise.
147 * w32.c (init_environment): Likewise.
148 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
149 * xdisp.c (syms_of_xdisp): Likewise.
150 * xfns.c (syms_of_xfns): Likewise.
151
6195f384
DA
1522012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
153
154 Fast save_excursion_save and save_excursion_restore.
155 * lisp.h (struct Lisp_Excursion): New data type.
156 (PVEC_EXCURSION): New pseudovector type.
157 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
158 to deal with it. Adjust comments.
159 (init_marker, attach_marker): New prototype.
160 (unchain_marker): Adjust prototype.
161 * marker.c (attach_marker): Change to global.
162 (init_marker): New function.
163 * alloc.c (Fmake_marker, build_marker): Use it.
164 (build_marker): More easserts.
165 (mark_object): Handle struct Lisp_Excursion.
166 * editfns.c (save_excursion_save, save_excursion_restore):
167 Reimplement to use struct Lisp_Excursion. Add comments.
168
5eceb8fb
PE
1692012-07-26 Paul Eggert <eggert@cs.ucla.edu>
170
171 Fix export of symbols to GDB (Bug#12036).
172 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
173 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
174 emacs.c, as this is a more-suitable home. Had this been done earlier
175 the fix for 12036 would have avoided some of the problems noted in
176 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
177 would have been more obvious.
562157c8
PE
178 * emacs.c: Do not include <verify.h>; no longer needed.
179 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
180 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
181 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
182 Remove; now done in lisp.h.
183 * lisp.h (PUBLISH_TO_GDB): New macro.
184 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
185 (DATA_SEG_BITS): Use it.
186 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
187 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
188 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
189 not be usable in #if. This simplifies things.
190
d6749401
JB
1912012-07-26 Juanma Barranquero <lekktu@gmail.com>
192
193 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
194
1781b9e9
PE
1952012-07-26 Paul Eggert <eggert@cs.ucla.edu>
196
d89518db 197 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
198 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
199 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
200 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
201 Adjust to changes in lisp.h and emacs.c, by using
202 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
203 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
204 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
205 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
206 instead of gdb_valbits.
207 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
208 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
209 instead of gdb_array_mark_flag.
210 (xboolvector): Get size from $->size, not $->header.size.
211 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
212 (xreload, hook-run, hookpost-run): Remove.
213 * emacs.c: Include <verify.h>.
214 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
215 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
216 Remove.
217 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
218 (gdb_USE_LSB_TAG): New enum constants.
219 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
220 Also define these as enum constants, so they're visible to GDB.
221 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
222 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
223 as constants, so they're visible to GDB.
224 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
225 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
226 Now enum constants, not macros, so they're visible to GDB.
227 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
228 more convenient now. All uses changed.
229 (VALMASK) [USE_LSB_TAG]: Also define in this case.
230 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
231
3628596a
DA
2322012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
233
234 Explicitly free restriction data that are not needed anymore.
235 * editfns.c (save_restriction_restore): Free restriction data.
236
7abaf5cc
SM
2372012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
238
239 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
240 add argument, tune behavior, and adjust all callers.
241
71f88e00
PE
2422012-07-25 Paul Eggert <eggert@cs.ucla.edu>
243
244 Use typedef for EMACS_INT, EMACS_UINT.
245 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
246 than macros. This simplifies debugging in the usual case, since
247 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
248 and it allows expressions involving EMACS_INT casts.
249 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
250
57ec3034
JD
2512012-07-25 Jan Djärv <jan.h.d@swipnet.se>
252
253 * nsterm.m (ns_read_socket): Return early if there is a modal
254 window (Bug#12043).
255
8137e7b3
MR
2562012-07-25 Martin Rudalics <rudalics@gmx.at>
257
258 * frame.c (Fredirect_frame_focus): In doc-string don't mention
259 that FOCUS-FRAME can be omitted.
260
04e9897c
DA
2612012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
262
263 Adjust buffer text indirection counters at the end of Fkill_buffer.
264 * buffer.c (Fkill_buffer): Adjust indirection counters when the
265 buffer is definitely dead. This should really fix an issue reported
266 by Christoph Scholtes again. (Bug#12007).
267 (init_buffer_once): Initialize indirection counters of
268 buffer_defaults and buffer_local_symbols (for sanity and safety).
269
8a0484e1
EZ
2702012-07-24 Eli Zaretskii <eliz@gnu.org>
271
272 * xdisp.c (init_iterator): Don't compute dimensions of truncation
273 and continuation glyphs on tooltip frames, leave them at zero.
274 Avoids continued lines in tooltips. (Bug#11832)
275
fa691a83
DA
2762012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
277
278 Simplify copy_overlay.
04e9897c 279 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
280 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
281
436bc8e0
EZ
2822012-07-23 Eli Zaretskii <eliz@gnu.org>
283
284 * print.c (print_object): Don't crash when a frame's name is nil
285 or invalid. (Bug#12025)
286
287 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
288 it signals an error when a tooltip frame is being created.
289
d7a7fda3
DA
2902012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
291
292 Cleanup miscellaneous objects allocation and initialization.
293 * alloc.c (allocate_misc): Change to static. Add argument to
294 specify the subtype. Adjust comment and users.
295 (build_overlay): New function.
296 * buffer.c (copy_overlays, Fmake_overlay): Use it.
297 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
298 (allocate_misc): Remove prototype.
299 (build_overlay): Add prototype.
300
3012012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
302
303 Swap buffer text indirection counters in Fbuffer_swap_text.
304 * buffer.c (Fbuffer_swap_text): Swap indirections too.
305 This avoids crash reported by Christoph Scholtes at
306 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
307
9d7fa573
JD
3082012-07-22 Jan Djärv <jan.h.d@swipnet.se>
309
310 * nsmenu.m (Popdown_data): New struct.
311 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
312 free Popdown_data.
313 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
314 (initWithContentRect): Make imgView and contentView non-static
315 and autorelease them. Also autorelease img and matrix (Bug#12005).
316 (dealloc): Remove (Bug#12005).
317
0dd6d66d
DA
3182012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
319
320 Adjust consing_since_gc when objects are explicitly freed.
321 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
322 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
323 (free_cons, free_misc): Subtract object size from consing_since_gc.
324
d36d71df
DA
3252012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
326
327 Simplify and cleanup markers positioning code.
328 * marker.c (attach_marker): More useful eassert.
329 (live_buffer, set_marker_internal): New function.
330 (Fset_marker, set_marker_restricted): Use set_marker_internal.
331 (set_marker_both, set_marker_restricted_both): Use live_buffer.
332
fb9ea40f
PE
3332012-07-22 Paul Eggert <eggert@cs.ucla.edu>
334
335 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
336 as it's limited by the amount of memory, not by INT_MAX.
337
2d5c5f7d
EZ
3382012-07-21 Eli Zaretskii <eliz@gnu.org>
339
07fb592e
EZ
340 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
341 in special-event-map. See the discussion at
342 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
343 for the reasons.
344
37a9eac8 345 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
346 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
347 Fabrice Popineau <fabrice.popineau@supelec.fr>.
348
c4328746
JD
3492012-07-21 Jan Djärv <jan.h.d@swipnet.se>
350
351 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 352 (conversationIdentifier): Return value is NSInteger.
784051c4 353 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 354
6e5d1c12
CY
3552012-07-21 Chong Yidong <cyd@gnu.org>
356
357 * window.c (decode_any_window): Signal an error if the window is
358 on a dead frame (Bug#11984).
359
9928463d
DA
3602012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
361
362 Add indirection counting to speed up Fkill_buffer.
363 * buffer.h (struct buffer): New member.
364 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
365 (Fmake_indirect_buffer): Set indirection counter to -1, increment
366 base buffer indirection counter.
367 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
368 (Fkill_buffer): Adjust indirection counters as needed, don't walk
369 through buffer list if indirection counter is 0.
370
f8643a6b
DA
3712012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
372
373 Extend the value returned by Fgarbage_collect with heap statistics.
374 * alloc.c (Qheap): New symbol.
375 (syms_of_alloc): DEFSYM it.
376 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
377 (Fmemory_free): Remove.
378 (syms_of_alloc): Don't defsubr it.
379 * buffer.c (Fcompact_buffer): Remove.
380 (syms_of_buffer): Don't defsubr it.
381
dac616ff
DA
3822012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
383
384 Make maybe_gc inline.
385 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
386 * lisp.h (consing_since_gc, gc_relative_threshold)
387 (memory_full_cons_threshold): Revert declaration.
388 (maybe_gc): Remove prototype, define as inline.
389 * alloc.c: Remove old commented-out code.
390 (consing_since_gc, gc_relative_threshold)
391 (memory_full_cons_threshold): Revert to global.
392 (maybe_gc): Remove.
393
d7ea76b4
DA
3942012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
395
396 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
397 * lisp.h (build_unibyte_string): New function.
398 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
399 * sysdep.c, w32fns.c, xfns.c: Use it.
400 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
401 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
402 Adjust users accordingly.
403 * font.h (font_open_by_name): Adjust prototype.
404
765e61e3
DA
4052012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
406
407 Cleanup calls to Fgarbage_collect.
408 * lisp.h (maybe_gc): New prototype.
409 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
410 Remove declarations.
411 * alloc.c (maybe_gc): New function.
412 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
413 Make them static.
414 * bytecode.c (MAYBE_GC): Use maybe_gc.
415 * eval.c (eval_sub, Ffuncall): Likewise.
416 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
417 to avoid dependency from auto-save feature.
418
52b852c7
PE
4192012-07-19 Paul Eggert <eggert@cs.ucla.edu>
420
421 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
422 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
423 'for_each_per_buffer_object_at'.
424 All uses changed. It's better to use upper-case for macros that
425 cannot be implemented as functions, to give the reader a clue
426 that they're special.
427
5db81e33
SM
4282012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
429
430 * alloc.c (Fgarbage_collect): Tweak docstring.
431
5b835e1d
DA
4322012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
433
434 Tweak the value returned from Fgarbage_collect again.
435 * alloc.c (Fgarbage_collect): New return value, as confirmed in
436 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
437 Adjust documentation.
438 (total_vector_bytes): Rename to total_vector_slots, adjust
439 accounting.
440 (total_free_vector_bytes): Rename to total_free_vector_slots,
441 adjust accounting.
442 (Qstring_bytes, Qvector_slots): New symbols.
443 (syms_of_alloc): DEFSYM them.
444
9cd47b72
DA
4452012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
446
447 Buffer compaction primitive which may be used from Lisp.
448 * buffer.c (compact_buffer, Fcompact_buffer): New function.
449 (syms_of_buffer): Register Fcompact_buffer.
450 * alloc.c (Fgarbage_collect): Use compact_buffer.
451 * buffer.h (compact_buffer): New prototype.
452 (struct buffer_text): New member.
453
d17337e5
DA
4542012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
455
456 New macro to iterate over all buffers, miscellaneous cleanups.
457 * lisp.h (all_buffers): Remove declaration.
458 * buffer.h (all_buffers): Add declaration, with comment.
459 (for_each_buffer): New macro.
460 * alloc.c (Fgarbage_collect, mark_object): Use it.
461 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
462 (init_buffer): Likewise.
463 * data.c (Fset_default): Likewise.
464 * coding.c (code_conversion_restore): Remove redundant check
465 for dead buffer.
466 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
467
60cfd278
AS
4682012-07-18 Andreas Schwab <schwab@linux-m68k.org>
469
470 Fix bug that created negative-length intervals.
471 * intervals.c (merge_interval_right, merge_interval_left):
472 Do not zero out this interval if it is absorbed by its children,
473 as this interval's total length doesn't change in that case. See
474 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
475
d06714cb
PE
4762012-07-18 Paul Eggert <eggert@cs.ucla.edu>
477
83713154
PE
478 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
479 when invoking (make-bool-vector N t) and N is a positive
480 multiple of 8 -- the last 8 bits were mistakenly cleared.
481
d06714cb
PE
482 Remove some struct layout assumptions in bool vectors.
483 * alloc.c (bool_header_size): New constant.
484 (header_size, word_size): Move earlier, as they're now used earlier.
485 Use 'word_size' in a few more places, where it's appropriate.
486 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
487 padding before the data member of a bool vector.
488 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
489 than doing the check by hand with an abort ().
490
464d5a5e
SM
4912012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
492
5fbc0409
SM
493 * eval.c (Fdefvar): Don't check constants since we only set the var if
494 it's not yet defined anyway (bug#11904).
495
464d5a5e
SM
496 * lisp.h (last_undo_boundary): Declare new var.
497 * keyboard.c (command_loop_1): Set it.
498 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
499 were auto-added by the command loop (bug#11774).
500
8dc2e44a
AS
5012012-07-18 Andreas Schwab <schwab@linux-m68k.org>
502
503 * w32font.c (Qsymbol): Remove local definition.
504 (syms_of_w32font): Don't DEFSYM it.
505
169925ec
DA
5062012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
507
508 Fix sweep_vectors to handle large bool vectors correctly.
509 * alloc.c (sweep_vectors): Account total_vector_bytes for
510 bool vectors larger than VBLOCK_BYTES_MAX.
511
5fbfb018
CY
5122012-07-18 Chong Yidong <cyd@gnu.org>
513
514 * frame.c (x_set_frame_parameters): Revert bogus change introduced
515 in 2012-05-25 commit by Paul Eggert (Bug#11738).
516
3ab6e069
DA
5172012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
518
519 Return more descriptive data from Fgarbage_collect.
520 Suggested by Stefan Monnier in
521 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
522 * alloc.c (bounded_number): New function.
523 (total_buffers, total_vectors): New variable.
524 (total_string_size): Rename to total_string_bytes, adjust users.
525 (total_vector_size): Rename to total_vector_bytes, adjust users.
526 (sweep_vectors): Account total_vectors and total_vector_bytes.
527 (Fgarbage_collect): New return value. Adjust documentation.
528 (gc_sweep): Account total_buffers.
529 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
530 (VECTOR_SIZE): Remove.
531 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
532 (Qinterval, Qmisc): New symbols.
533 (syms_of_data): Initialize them.
534 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
535 (Qcons, Qbuffer): New declarations.
536
6d02fe5b
PE
5372012-07-17 Paul Eggert <eggert@cs.ucla.edu>
538
539 * alloc.c (Fmemory_free): Account for memory-free's own storage.
540 Round up, not down. Improve doc.
541
b7ffe040
DA
5422012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
543
544 Restore old code in allocate_string_data to avoid Faset breakage.
545 Reported by Julien Danjou <julien@danjou.info> in
546 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
547 * alloc.c (allocate_string_data): Restore old code with minor
548 adjustments, fix comment to explain this subtle issue.
549
4dc7c8d5
SM
5502012-07-17 Eli Zaretskii <eliz@gnu.org>
551
552 Remove FILE_SYSTEM_CASE.
553 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
554
555 * fileio.c (FILE_SYSTEM_CASE): Don't define.
556 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
557 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
558 call-process-region passes it through expand-file-name.
559
560 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
561
5622012-07-17 Andreas Schwab <schwab@linux-m68k.org>
563
564 Fix crash when creating indirect buffer (Bug#11917)
565 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
566 Don't handle unbound variables specially if non-zero.
567 (Fbuffer_local_variables): Pass zero.
568 (clone_per_buffer_values): Pass non-zero.
569
5702012-07-17 Andreas Schwab <schwab@linux-m68k.org>
571
572 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
573 to make the loop interruptible.
574
5752012-07-17 Andreas Schwab <schwab@linux-m68k.org>
576
577 * gnutls.c (emacs_gnutls_handshake): Only retry if
578 GNUTLS_E_INTERRUPTED.
579
cce7fefc
DA
5802012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
581
582 Cleanup and convert miscellaneous checks to eassert.
583 * alloc.c (mark_interval): Fix comment, partially rephrase
584 old comment from intervals.h (see below).
585 * intervals.c (find_interval, adjust_intervals_for_insertion)
586 (delete_interval, adjust_intervals_for_deletion)
587 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
588 Convert to eassert.
589 (adjust_intervals_for_insertion, make_new_interval):
590 Remove obsolete and unused code.
591 * intervals.h (struct interval): Remove obsolete comment.
592 * textprotp.c (erase_properties): Remove unused code.
593 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
594 (Fremove_list_of_text_properties): Convert to eassert.
595
9ea10cc3
CY
5962012-07-17 Chong Yidong <cyd@gnu.org>
597
598 * editfns.c (Finsert_char): Doc fix.
599
3900d5de
DA
6002012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
601
602 Fix previous change to make Fmemory_free always accurate.
603 * alloc.c (make_interval): Update total_free_intervals.
604 (make_float): Likewise for total_free_floats.
605 (free_cons, Fcons): Likewise for total_free_conses.
606 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
607 Likewise for total_free_vector_bytes.
608 (Fmake_symbol): Likewise for total_free_symbols.
609 (bytes_free): Remove.
610
7098646f
DA
6112012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
612
613 Simple free memory accounting feature.
614 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
615 (sweep_vectors): Accumulate size of free vectors.
616 (Fgarbage_collect): Setup bytes_free.
617 (Fmemory_free): New function.
618 (syms_of_alloc): Register it.
619
22657b40
DA
6202012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
621
622 Cleanup overlays checking.
623 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
624 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
625 eassert and OVERLAYP.
626 (sort_overlays): Change to use OVERLAYP.
627
ddfc8813
RK
6282012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
629
630 * editfns.c (Finsert_char): Make it interactive, and make the
631 second arg optional. Copy interactive spec and docstring from
632 ucs-insert.
633
7c26cf3c
PE
6342012-07-17 Paul Eggert <eggert@cs.ucla.edu>
635
636 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
637 Unlike the other wrapped functions, fabs has an unspecified
638 effect on errno.
639
5d127af9
JD
6402012-07-16 Jan Djärv <jan.h.d@swipnet.se>
641
642 * nsterm.m (keyDown): Interpret flags without left/right bits
643 as the left key (Bug#11670).
644
6a0dd1d7
DA
6452012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
646
647 Remove empty and useless init functions.
648 * lisp.h (init_character_once, init_fns, init_image)
649 (init_filelock, init_sound): Remove prototype.
650 * character.c (init_character_once): Remove.
651 * filelock.c (init_filelock): Likewise.
652 * fns.c (init_fns): Likewise.
653 * image.c (init_image): Likewise.
654 * sound.c (init_sound): Likewise.
655 * emacs.c (main): Adjust accordingly.
656
7a6136fd
DA
6572012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
658
659 * gtkutil.h: Tiny cleanups.
660 (use_old_gtk_file_dialog): Remove useless declaration.
661 (xg_uses_old_file_dialog): Add suggested const attribute.
662
ce811ad9
EZ
6632012-07-15 Eli Zaretskii <eliz@gnu.org>
664
665 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
666 (bidi_paragraph_init): Use it to limit search forward for a strong
667 directional character in abnormally large paragraphs full of
668 neutral or weak characters. (Bug#11943)
669
c9adfeaa
SF
6702012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
671
672 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
673 the toolbar (Bug#9451).
674 (xg_make_tool_item): Give the widget event box a transparent
675 background.
676
fff62aa9
DA
6772012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
678
679 Cleanup basic allocation variables and functions.
680 * alloc.c (ignore_warnings, init_intervals, init_float)
681 (init_cons, init_symbol, init_marker): Remove.
682 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
683 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
684 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
685 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
686 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
687 (staticidx, init_alloc_once, init_strings, free_ablock):
688 Remove redundant initialization.
689 * fns.c (init_weak_hash_tables): Remove.
690 * lisp.h (init_weak_hash_tables): Remove prototype.
691
9730daca
DA
6922012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
693
694 Use zero_vector where appropriate.
695 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
696 accordingly.
697 * lisp.h (zero_vector): New declaration.
698 * font.c (null_vector): Remove.
699 (syms_of_font): Remove initialization and staticpro.
700 (font_list_entities, font_find_for_lface): Change to use zero_vector.
701 * keymap.c (Faccessible_keymaps): Likewise.
702
2e2d2a13
LL
7032012-07-15 Leo Liu <sdl.web@gmail.com>
704
705 * fringe.c: Fix typo in comments.
706
cd276f6e
LL
7072012-07-14 Leo Liu <sdl.web@gmail.com>
708
709 * fringe.c: Add a new bitmap exclamation-mark.
710
5a1131d9
EZ
7112012-07-14 Eli Zaretskii <eliz@gnu.org>
712
713 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
714
715 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
716 (HAVE_MENUS): Don't define, defined by editing config.in with
717 msdos/sed2v2.inp.
718 (GMALLOC_INHIBIT_VALLOC): Don't define.
719 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
720
22e983b7
JB
7212012-07-14 Juanma Barranquero <lekktu@gmail.com>
722
723 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
724
5b3f250f
GM
7252012-07-14 Glenn Morris <rgm@gnu.org>
726
727 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
728 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
729 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
730
33d63ff4
GM
7312012-07-13 Glenn Morris <rgm@gnu.org>
732
5b633342
GM
733 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
734
33d63ff4
GM
735 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
736 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
737
b55b9f85
JD
7382012-07-13 Jan Djärv <jan.h.d@swipnet.se>
739
0dc8cf50
JD
740 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
741 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
742 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
743 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
744 where appropriate.
745 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
746 as boolean expression.
747 (x_set_window_size): Remove unused variable toolbar.
748 (ns_get_color_default, ns_mod_to_lisp): Remove.
749 (ns_mouse_position): Remove unused variables xchar and ychar.
750 (ns_compute_glyph_string_overhangs): Remove unused variable face.
751 (ns_set_vertical_scroll_bar): Remove unused variable count.
752 (ns_delete_terminal): Remove unused variable i.
753 (ns_term_init): Remove unused variables r, g and b.
754 (mouseDown): Remove unused variable window.
755 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
756 (initFrameFromEmacs): Remove unused variable vbextra.
757 (mouseEntered): Remove unused variables p and dpyinfo.
758 (mouseExited): Remove unused variables p and r.
759 (ns_define_frame_cursor, ns_clear_frame_area)
760 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
761 (menuDown): Assign [sender tag] to variable and cast the variable.
762
763 * nsterm.h (menuDown): Add id as type to argument sender.
764 (ns_display_info_for_name): Add Lisp_Object argument.
765 (ns_term_init): Add Lisp_Object argument.
766 (ns_map_event_to_object): Add void argument.
767 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
768 prototype with arguments and only declare if __OBJC__.
769 (nxatoms_of_nsselect): Add void argument.
770 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
771 (ns_alloc_autorelease_pool): Add void argument.
772 (ns_release_autorelease_pool): Add void* argument.
773 (ns_get_defaults_value): Add const char* argument.
774
775 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
776 (initFromContents): Use SSDATA where appropriate.
777 (ns_update_menubar): Add braces to ambigous if-else.
778 (initWithTitle): Put () around assignment in if statement.
779 (ns_menu_show): Remove unused variables window and keymap.
780 (update_frame_tool_bar): Remove unused variable selected_p.
781 (initWithContentRect): Remove unused variable this_cmd_name.
782
783 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
784 appropriate.
785 (setXBMColor): Remove unused variable len.
786 (setPixmapData): Put () around assignment in loop statement.
787
788 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
789 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
790 where appropriate.
791 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
792 around assignment in loop statement.
793 (nsfont_open): Remove unused variable i.
794 (nsfont_open): Remove unused variable len.
795 (nsfont_draw): Remove unused variable cs.
796
797 * nsfns.m (x_set_icon_name, ns_set_name_internal)
798 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
799 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
800 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
801 (Fns_font_name, Fns_perform_service)
802 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
803 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
804 (ns_set_name): Remove unused variable view.
805 (x_set_menu_bar_lines): Remove unused variable olines.
806 (x_set_tool_bar_lines): Remove unused variable root_window.
807 (Fns_list_colors): Put () around assignment in while statement.
808 (Fns_perform_service): Remove unused variable len.
809 (Fns_display_usable_bounds): Remove unused variable top.
810 (syms_of_nsfns): Remove unused variable i.
811
b55b9f85
JD
812 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
813 memcpy (Bug#11907).
814
ed9265fc 8152012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
816
817 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
818 and free it with DestroyExceptionInfo (Bug#11558).
819
ef099b57
JB
8202012-07-13 Juanma Barranquero <lekktu@gmail.com>
821
822 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
823 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
824 Set here, not in nt/config.nt.
825
ea814a5d
EZ
8262012-07-13 Eli Zaretskii <eliz@gnu.org>
827
828 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
829 cursor overflow into the last glyph on display line when the right
830 fringe is off. (Bug#11832)
831
1a952767
PE
8322012-07-13 Paul Eggert <eggert@cs.ucla.edu>
833
834 * xdisp.c (produce_special_glyphs): Now static.
835 * dispextern.h (produce_special_glyphs): Remove decl.
836
983188fd
GM
8372012-07-13 Glenn Morris <rgm@gnu.org>
838
32fb4bb6
GM
839 * s/bsd-common, s/cygwin.h: Remove empty files.
840 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
841
983188fd
GM
842 * s/usg5-4-common.h (USG, USG5):
843 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
844 * s/sol2-6.h (SOLARIS2):
845 * s/irix6-5.h (IRIX6_5):
846 * s/hpux10-20.h (USG, USG5, HPUX):
847 * s/gnu-linux.h (USG, GNU_LINUX):
848 * s/freebsd.h (BSD_SYSTEM):
849 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
850 * s/cygwin.h (CYGWIN):
851 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
852 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
853
d1e68667 8542012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
855
856 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 857
6de0e799
GM
8582012-07-13 Glenn Morris <rgm@gnu.org>
859
739ae010
GM
860 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
861
dbee5793
GM
862 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
863
6de0e799
GM
864 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
865 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
866
b82da769
GM
8672012-07-12 Glenn Morris <rgm@gnu.org>
868
4fae5a7a 869 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
870
871 * process.c (init_process_emacs): Rename from init_process.
872 The old name is also the name of a Mach system call.
873 * lisp.h, emacs.c: Update for this name change.
874 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
875 longer needed.
876
5a979817
EZ
8772012-07-12 Eli Zaretskii <eliz@gnu.org>
878
879 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
880 memmove call that removes glyphs covered by the left truncation
881 glyph. Improve commentary.
882 (display_line): Fix display of continuation glyphs on GUI frames
883 when the right fringe is turned off and variable-size fonts are
884 used in the window. Move the code that appends a stretch glyph to
885 produce_special_glyphs, so that it could be used for truncation
886 and continuation glyphs alike.
887 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
888 glyph of a suitably computed width, to align the special glyphs at
889 the window margin. Code moved from display_line. (Bug#11832)
890
3e91a053
GM
8912012-07-12 Glenn Morris <rgm@gnu.org>
892
ba9e4b84
GM
893 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
894
895 * s/gnu-linux.h, s/hpux10-20.h:
896 Do not unconditionally define HAVE_XRMSETDATABASE.
897
3e91a053
GM
898 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
899
b300b1f4
PE
9002012-07-12 Paul Eggert <eggert@cs.ucla.edu>
901
902 Fix typos that broke OS X build.
903 Reported by Randal L. Schwartz in
904 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
905 * nsterm.m (ns_timeout): Add missing local decl.
906 (ns_get_color): snprintf -> sprintf, to fix typo.
907
6e777848
GM
9082012-07-12 Glenn Morris <rgm@gnu.org>
909
3f922c37
GM
910 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
911 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
912 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
913 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
914
0ab7b23a
GM
915 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
916 Move PTY_OPEN to configure.
917
6e777848
GM
918 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
919 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
920 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
921
4a7edc24
DA
9222012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
923
924 Use empty_unibyte_string where applicable.
925 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
926 * lread.c (read1): Likewise.
927 * xsettings.c (syms_of_xsettings): Likewise.
928
308aab79
GM
9292012-07-12 Glenn Morris <rgm@gnu.org>
930
42bd1719
GM
931 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
932 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
933 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
934 * s/hpux10-20.h (RUN_TIME_REMAP):
935 * s/bsd-common.h (TABDLY): Move to configure.
936
937 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
938
939 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
940
ea0bbd17 941 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 942 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
943
944 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 945
308aab79
GM
946 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
947 * s/template.h: Move NARROWPROTO to configure.
948
ee1cf5cf
GM
9492012-07-11 Glenn Morris <rgm@gnu.org>
950
30fe9bf4
GM
951 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
952 unused since 2011-01-17 change to systty.h.
953
ee1cf5cf
GM
954 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
955 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
956 Move HAVE_PTYS and HAVE_SOCKETS to configure.
957
63e47e07
PE
9582012-07-11 Paul Eggert <eggert@cs.ucla.edu>
959
960 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
961
c43fb4c3
GM
9622012-07-11 Glenn Morris <rgm@gnu.org>
963
964 * s/darwin.h, s/gnu-linux.h, s/template.h:
965 Move INTERRUPT_INPUT to configure.
966
e8df9267
DA
9672012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
968
969 Minor adjustments to interning code.
970 * lisp.h (intern, intern_c_string): Redefine as static inline
971 wrappers for intern_1 and intern_c_string_1, respectively.
972 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
973 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
974 Vobarray checking.
e8df9267
DA
975 * font.c (font_intern_prop): Likewise. Adjust comment.
976 * w32font.c (intern_font_name): Likewise.
977
34348bd4
AS
9782012-07-11 Andreas Schwab <schwab@linux-m68k.org>
979
d96a1e0c
AS
980 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
981
34348bd4
AS
982 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
983 of Fcar/Fcdr if possible.
984 * font.c (check_otf_features): Likewise.
985 * fontset.c (Fnew_fontset): Likewise.
986 * gnutls.c (Fgnutls_boot): Likewise.
987 * minibuf.c (read_minibuf): Likewise.
988 * msdos.c (IT_set_frame_parameters): Likewise.
989 * xmenu.c (Fx_popup_dialog): Likewise.
990 * w32menu.c (Fx_popup_dialog): Likewise.
991
c8add24e
GM
9922012-07-11 Glenn Morris <rgm@gnu.org>
993
4b575b3c
GM
994 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
995 since nothing has defined it on these platforms.
996
09f4e3b0
GM
997 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
998 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
999
172bedef
GM
1000 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1001 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1002 Move CLASH_DETECTION to configure.
1003
249685df
GM
1004 * s/gnu.h: Remove file, which is now empty.
1005
c8add24e
GM
1006 * s/gnu.h, s/gnu-linux.h:
1007 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1008
b41253a3
JW
10092012-07-11 John Wiegley <johnw@newartisans.com>
1010
1011 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1012 function attribute, so we only use it if it exists in the
1013 compiler.
1014
d923b542
DA
10152012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1016
1017 Avoid call to strlen in fast_c_string_match_ignore_case.
1018 * search.c (fast_c_string_match_ignore_case): Change to use
1019 length argument. Adjust users accordingly.
1020 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1021
5ebbef1d
PE
10222012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1023
bb352260
PE
1024 Assume mkdir, rmdir.
1025 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1026 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1027
57054ddd
PE
1028 Assume rename.
1029 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1030
b747d3f7
PE
1031 Assume perror.
1032 * s/hpux10-20.h (HAVE_PERROR): Remove.
1033 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1034 Remove dummy definition, as this problem was obsolete long ago.
1035
5ebbef1d
PE
1036 Assume strerror.
1037 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1038
984e7f30
DA
10392012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1040
1041 Avoid calls to strlen in font processing functions.
1042 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1043 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1044 users accordingly.
d923b542
DA
1045 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1046 Adjust prototypes.
1047 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1048 Change to return ptrdiff_t.
984e7f30
DA
1049 (xfont_list_pattern, xfont_match): Use length returned by
1050 xfont_decode_coding_xlfd.
1051 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1052
20e94fdd
GM
10532012-07-11 Glenn Morris <rgm@gnu.org>
1054
9d596af3
GM
1055 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1056 Move DONT_REOPEN_PTY to configure.
1057
20e94fdd
GM
1058 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1059 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1060
e99a530f
PE
10612012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1062
22ffb973
PE
1063 Remove "#define unix" that is no longer needed (Bug#11905).
1064 * s/aix4-2.h (unix): Remove; no longer needed.
1065
e9a9ae03
PE
1066 EMACS_TIME simplification (Bug#11875).
1067 This replaces macros (which typically do not work in GDB)
1068 with functions, typedefs and enums, making the code easier to debug.
1069 The functional style also makes code easier to read and maintain.
1070 * systime.h: Include <sys/time.h> on all hosts, not just if
1071 WINDOWSNT, since 'struct timeval' is needed in general.
1072 (EMACS_TIME): Now a typedef, not a macro.
1073 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1074 not macros.
1075 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1076 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1077 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1078 (EMACS_TIME_LE): Now functions, not macros.
1079 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1080 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1081 which are not functions. All uses rewritten to use:
1082 (make_emacs_time): New function.
1083 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1084 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1085 not functions. All uses rewritten to use the following, respectively:
1086 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1087 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1088 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1089 * fileio.c (Fcopy_file):
1090 * xterm.c (XTflash): Get the current time closer to when it's used.
1091 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1092
ffacb126
PE
1093 * bytecode.c (targets): Suppress -Woverride-init warnings.
1094
e99a530f
PE
1095 Simplify by avoiding confusing use of strncpy etc.
1096 * doc.c (Fsnarf_documentation):
1097 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1098 * frame.c (Fmake_terminal_frame):
1099 * gtkutil.c (get_utf8_string):
1100 * lread.c (openp):
1101 * nsmenu.m (ns_update_menubar):
1102 * regex.c (regerror):
1103 Prefer memcpy to strncpy and strncat when either will do.
1104 * fileio.c (Fsubstitute_in_file_name):
1105 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1106 (menu_separator_name_p):
1107 * nsmenu.m (ns_update_menubar):
1108 Prefer memcmp to strncmp when either will do.
1109 * nsterm.m: Include <ftoastr.h>.
1110 (ns_get_color):
1111 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1112 Prefer snprintf to strncpy.
1113 * nsterm.m (ns_term_init):
1114 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1115 * nsterm.m (ns_term_init):
1116 Avoid the need for strncpy, by using build_string or
1117 make_unibyte_string directly. Use dtoastr, not snprintf.
1118 * process.c (Fmake_network_process): Diagnose service names that
1119 are too long, rather than silently truncating them or creating
1120 non-null-terminated names.
1121 (Fnetwork_interface_info): Likewise, for interface names.
1122 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1123 Prefer sprintf to strncat.
1124 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1125 Prefer vsnprintf to vsprintf + strncpy.
1126
c59592b3
GM
11272012-07-10 Glenn Morris <rgm@gnu.org>
1128
1129 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1130 Clarify fallback case.
1131
7d7bbefd
DA
11322012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1133
1134 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1135 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1136 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1137 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1138 where argument type is known to be a Lisp_Cons.
1139
3a4c8000
TT
11402012-07-10 Tom Tromey <tromey@redhat.com>
1141
1142 * bytecode.c (BYTE_CODE_THREADED): New macro.
1143 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1144 (enum byte_code_op): New type.
1145 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1146 (exec_byte_code): Use them. Use token threading when applicable.
1147
2a0213a6
DA
11482012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1149
1150 Optimize pure C strings initialization.
1151 * lisp.h (make_pure_string): Fix prototype.
1152 (build_pure_c_string): New function, defined as static inline. This
1153 provides a better opportunity to optimize away calls to strlen when
1154 the function is called with compile-time constant argument.
1155 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1156 argument, adjust users accordingly. Use build_pure_c_string where
1157 appropriate.
1158 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1159 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1160 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1161
cb1caeaf
DA
11622012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1163
1164 Avoid calls to strlen in miscellaneous functions.
1165 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1166 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1167 * lread.c (openp): Likewise.
1168
c293e30c
DA
11692012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1170
1171 Avoid calls to strlen in path processing functions.
1172 * fileio.c (file_name_as_directory): Add comment. Change to add
1173 srclen argument and return the length of result. Adjust users
1174 accordingly.
1175 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1176 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1177 users accordingly.
1178 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1179
9e059e3f
GM
11802012-07-10 Glenn Morris <rgm@gnu.org>
1181
d02eb359
GM
1182 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1183 Move PENDING_OUTPUT_COUNT definition to configure.
1184
882cf227
GM
1185 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1186 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1187 * s/gnu.h (DATA_START): Move definitions to configure.
1188
af6e839f
GM
1189 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1190 We include usg5-4-common.h, which defines them both.
1191
40289a12
GM
1192 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1193 O_RDONLY already includes it).
1194
9e059e3f
GM
1195 Stop ns builds setting the EMACSLOADPATH environment variable.
1196 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1197 Now it does not set EMACSLOADPATH, just returns the load-path string.
1198 * nsterm.h: Update accordingly.
1199 * lread.c [HAVE_NS]: Include nsterm.h.
1200 (init_lread) [HAVE_NS]: Use ns_load_path.
1201 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1202
7c4e8ec0
GM
12032012-07-09 Glenn Morris <rgm@gnu.org>
1204
d4f600ff
GM
1205 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1206 since the included bsd-common.h does so.
1207
cbb31951
GM
1208 Stop ns builds setting the EMACSPATH environment variable.
1209 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1210 (ns_init_paths): Do not set EMACSPATH.
1211 * nsterm.h (ns_exec_path): Add it.
1212 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1213 Use ns_exec_path.
1214
7c4e8ec0
GM
1215 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1216
26bccfae
PE
12172012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1218
a0bee46f
PE
1219 * process.c (wait_reading_process_output): 'waitchannels' was unset
1220 when read_kbd || !NILP (wait_for_cell); fix this.
1221
5994c183
PE
1222 Add GCC-style 'const' attribute to functions that can use it.
1223 * character.h (char_resolve_modifier_mask):
1224 * keyboard.h (make_ctrl_char):
1225 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1226 (init_character_once, next_almost_prime, init_fns, init_image)
1227 (flush_pending_output, init_sound):
1228 * mem-limits.h (start_of_data):
1229 * menu.h (finish_menu_items):
1230 Add ATTRIBUTE_CONST.
1231 * emacs.c (DEFINE_DUMMY_FUNCTION):
1232 Declare the dummy function with ATTRIBUTE_CONST.
1233 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1234 Add decls with ATTRIBUTE_CONST.
1235
26bccfae
PE
1236 Minor improvements to make_formatted_string.
1237 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1238 where int is good enough, as vsprintf returns an int.
1239 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1240
a8290ec3
DA
12412012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1242
1243 Use make_formatted_string to avoid double length calculation.
1244 * lisp.h (make_formatted_string): New prototype.
1245 * alloc.c (make_formatted_string): New function.
1246 * buffer.c (Fgenerate_new_buffer_name): Use it.
1247 * dbus.c (syms_of_dbusbind): Likewise.
1248 * editfns.c (Fcurrent_time_zone): Likewise.
1249 * filelock.c (get_boot_time): Likewise.
1250 * frame.c (make_terminal_frame, set_term_frame_name)
1251 (x_report_frame_params): Likewise.
1252 * image.c (gs_load): Likewise.
1253 * minibuf.c (get_minibuffer): Likewise.
1254 * msdos.c (dos_set_window_size): Likewise.
1255 * process.c (make_process): Likewise.
1256 * xdisp.c (ensure_echo_area_buffers): Likewise.
1257 * xsettings.c (apply_xft_settings): Likewise.
1258
d01ba2f1
GM
12592012-07-09 Glenn Morris <rgm@gnu.org>
1260
1261 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1262 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1263 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1264 * nsterm.h (ns_etc_directory): Add it.
1265 * callproc.c [HAVE_NS]: Include nsterm.h.
1266 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1267
f1f924b6
DA
12682012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1269
1270 Move marker debugging code under MARKER_DEBUG.
1271 * marker.c (MARKER_DEBUG): Move marker debugging code under
1272 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1273 for bootstrap with --enable-checking (~3x slowdown reported
1274 by Juanma Barranquero <lekktu@gmail.com>).
1275 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1276
ab531b66
PE
12772012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1278
1279 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1280 See <http://bugs.gnu.org/11825#29>.
1281
c4b3bc8a
EZ
12822012-07-08 Eli Zaretskii <eliz@gnu.org>
1283
1284 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1285 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1286 (display_line): Add commentary about displaying truncation glyphs
1287 on GUI frames.
1288 (produce_special_glyphs): Move here from term.c.
1289
1290 * term.c (produce_special_glyphs): Move to xdisp.c.
1291
1292 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1293 section.
c4b3bc8a 1294
b676b881
AS
12952012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1296
f17c5273
AS
1297 * xdisp.c (display_line): Avoid warning about implicit declaration
1298 of FRAME_FONT.
1299
298819b9
AS
1300 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1301
b676b881
AS
1302 * lisp.h: Remove empty conditional.
1303
6045c4fd
PE
13042012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1305
b3350bf9
PE
1306 * lread.c (load_path_check): Now static.
1307
6045c4fd
PE
1308 Fix some minor --with-ns problems found by static checking.
1309 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1310 (x_set_font) [!HAVE_X_WINDOWS]:
1311 * image.c (xpm_load_image) [HAVE_NS]:
1312 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1313 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1314 Remove unused local.
1315 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1316 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1317 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1318 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1319 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1320 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1321 Fix pointer signedness problem.
1322 * xfaces.c (FRAME_X_FONT_TABLE):
1323 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1324
929e7845
GM
13252012-07-07 Glenn Morris <rgm@gnu.org>
1326
1327 * lread.c (load_path_check): New function, split from init_lread.
1328 (init_lread): Reorganize. Motivation:
1329 If EMACSLOADPATH is set, check/warn about that rather than the
1330 defaults, which we are not going to use. Hence we can remove
1331 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1332 Don't warn if site-lisp directories are missing.
1333 If not installed, start from a blank load-path, since
1334 PATH_LOADSEARCH refers to the eventual installation directories.
1335
58dd0aa4
EZ
13362012-07-07 Eli Zaretskii <eliz@gnu.org>
1337
1338 Support truncation and continuation glyphs on GUI frames, when
1339 fringes are disabled. (Bug#11832)
1340 * xdisp.c (init_iterator): Get dimensions of truncation and
1341 continuation glyphs even if on GUI frames. Adjust
1342 it->last_visible_x on GUI frames when the left or right fringes,
1343 or both, are absent.
1344 (start_display, move_it_in_display_line_to): Handle the case of a
1345 GUI frame without a fringe to display continuation or truncation
1346 glyphs.
1347 (insert_left_trunc_glyphs): Support GUI frames: make sure
1348 truncation glyphs overwrite enough glyphs from the current line to
1349 have sufficient space in pixels.
1350 (display_line): Support truncation and continuation glyphs on GUI
1351 frames. If some spare pixels are left on the line after inserting
1352 the truncation glyphs, fill that space with a stretch glyph of a
1353 suitably computed width.
1354
1355 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1356 produce_glyphs, to support GUI sessions.
1357
31571fd7
PE
13582012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1359
5a16b9bc
PE
1360 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1361
f3047c75
PE
1362 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1363
31571fd7
PE
1364 Do not require float-time's arg to fit in time_t (Bug#11825).
1365 This works better on hosts where time_t is unsigned, and where
1366 float-time is applied to the (negative) difference between two times.
1367 * editfns.c (decode_time_components): Last arg is now double *,
1368 not int *, and means to store all the result as a double, without
1369 worrying about whether the seconds part fits in time_t.
1370 All callers changed.
1371 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1372 All callers changed.
1373 (Ffloat_time): Do not fail merely because the specified time falls
1374 outside of time_t range.
1375
4516fbef
GM
13762012-07-07 Glenn Morris <rgm@gnu.org>
1377
1378 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1379 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1380 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1381
07adc2c6
JB
13822012-07-07 Juanma Barranquero <lekktu@gmail.com>
1383
1384 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1385 Update dependencies.
1386
1387 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1388
fd573f31
PE
13892012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1390
fee5959d
PE
1391 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1392 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1393 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1394 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1395 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1396 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1397
fd573f31
PE
1398 * xfont.c (compare_font_names): Redo to omit the need for casts.
1399
ddadbc0e
AS
14002012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1401
fca8d6b6
AS
1402 * xfns.c (Fx_change_window_property): Doc fix.
1403 * w32fns.c (Fx_change_window_property): Doc fix.
1404
ddadbc0e
AS
1405 * w32fns.c (Fx_window_property): Accept the same arguments as the
1406 X Windows version. Doc fix.
1407 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1408
ed9265fc 14092012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1410 Eli Zaretskii <eliz@gnu.org>
1411
1412 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1413 Windows-specific code from nt/config.nt moved here.
1414 Obsolete settings removed.
1415
216ee680
PE
14162012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1417
1418 * process.c: Avoid unnecessary calls to gettime.
1419 (wait_reading_process_output): Don't get the time of day
1420 when gobbling data immediately and not waiting, as there's no need
1421 for it in that case. This removes a FIXME.
1422
bdd091e4
JD
14232012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1424
1425 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1426 is defined (Bug#11768).
1427
9d44f8ce
DA
14282012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1429
1430 Fix marker debugging code.
1431 * marker.c (byte_char_debug_check): Do not perform the check
1432 if buffer is not multibyte.
090bd7cb
JB
1433 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1434 Call byte_char_debug_check with correct arguments.
9d44f8ce 1435
90fc4786
DA
14362012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1437
1438 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1439 * marker.c (byte_char_debug_check, count_markers):
1440 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1441 (byte_debug_flag): Remove.
1442 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1443 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1444
7b7ae965
DA
14452012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1446
4e57b342
DA
1447 Avoid code repetition in marker-related functions.
1448 * marker.c (attach_marker): New function.
1449 (Fset_marker, set_marker_restricted, set_marker_both)
1450 (set_marker_restricted_both): Use it.
1451 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1452 Consistently rename charno to charpos.
1453 (marker_position): Add eassert.
1454 (marker_byte_position): Convert to eassert.
1455
14562012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1457
1458 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1459 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1460 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1461
657924ff
DA
14622012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1463
1464 Introduce fast path for the widely used marker operation.
1465 * alloc.c (build_marker): New function.
1466 * lisp.h (build_marker): New prototype.
1467 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1468 * composite.c (autocmp_chars): Likewise.
1469 * editfns.c (buildmark): Remove.
1470 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1471 (save_restriction_save): Use build_marker.
1472 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1473 * window.c (save_window_save): Likewise.
1474
041a49a6
DA
14752012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1476
1477 Do not use Fdelete_overlay in delete_all_overlays
1478 to avoid redundant calls to unchain_overlay.
1479 * buffer.c (drop_overlay): New function.
1480 (delete_all_overlays, Fdelete_overlay): Use it.
1481 * minibuf.c (get_minibuffer): Fix comment.
1482
7dca65a4
PE
14832012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1484
1485 Port to OpenBSD 5.1 amd64.
1486 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1487 This is needed for OpenBSD, and should be harmless on all BSD systems.
1488 Also, include <sys/sysctl.h>, as it should be available on all
1489 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1490 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1491 use p_pid member, not kp_proc.pid.
1492
8eb876e2
GM
14932012-07-06 Glenn Morris <rgm@gnu.org>
1494
1495 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1496
38182d90
PE
14972012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1498
1499 More xmalloc and related cleanup.
1500 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1501 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1502 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1503 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1504 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1505 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1506 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1507 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1508 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1509 * xterm.c:
1510 Omit needless casts involving void * pointers and allocation.
1511 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1512 as the former is more robust if P's type is changed.
1513 Prefer xzalloc to xmalloc + memset 0.
1514 Simplify malloc-or-realloc to realloc.
1515 Don't worry about xmalloc returning a null pointer.
1516 Prefer xstrdup to xmalloc + strcpy.
1517 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1518 growing it.
1519 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1520 alloca of a constant.
1521
6dd5a677
EZ
15222012-07-05 Eli Zaretskii <eliz@gnu.org>
1523
1524 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1525 hscroll is larger than the line width. Fixes long and futile
1526 looping inside extend_face_to_end_of_line (on a TTY) producing
1527 glyphs that are not needed and thrown away.
1528
6b312f0f
DA
15292012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1530
1531 * marker.c (set_marker_restricted_both): Simplify by using
1532 clip_to_bounds.
1533
f520ef9b
PE
15342012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1537
383b7c95
JD
15382012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1539
1540 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1541 not defined (Bug#11768).
1542 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1543 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1544 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1545 followed by gtk_box_set_homogeneous (Bug#11768).
1546 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1547 (update_theme_scrollbar_width, xg_create_scroll_bar):
1548 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1549 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1550 (is_box_type): New function (Bug#11768).
1551 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1552 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1553 with default display (Bug#11768).
1554
d6e7bf45
EZ
15552012-07-05 Eli Zaretskii <eliz@gnu.org>
1556
1557 * xdisp.c (window_hscroll_limited): New function.
1558 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1559 coordinates when window's hscroll is set to insanely large
1560 values. (Bug#11857)
1561
431391ec
JB
15622012-07-05 Juanma Barranquero <lekktu@gmail.com>
1563
1564 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1565 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1566
23f86fce
DA
15672012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1568
1569 Cleanup xmalloc.
1570 * lisp.h (xzalloc): New prototype. Omit needless casts.
1571 * alloc.c (xzalloc): New function. Omit needless casts.
1572 * charset.c: Omit needless casts. Convert all calls to
1573 xmalloc with following memset to xzalloc.
1574 * dispnew.c: Likewise.
1575 * fringe.c: Likewise.
1576 * image.c: Likewise.
1577 * sound.c: Likewise.
1578 * term.c: Likewise.
1579 * w32fns.c: Likewise.
1580 * w32font.c: Likewise.
1581 * w32term.c: Likewise.
1582 * xfaces.c: Likewise.
1583 * xfns.c: Likewise.
1584 * xterm.c: Likewise.
1585 * atimer.c: Omit needless casts.
1586 * buffer.c: Likewise.
1587 * callproc.c: Likewise.
1588 * ccl.c: Likewise.
1589 * coding.c: Likewise.
1590 * composite.c: Likewise.
1591 * doc.c: Likewise.
1592 * doprnt.c: Likewise.
1593 * editfns.c: Likewise.
1594 * emacs.c: Likewise.
1595 * eval.c: Likewise.
1596 * filelock.c: Likewise.
1597 * fns.c: Likewise.
1598 * gtkutil.c: Likewise.
1599 * keyboard.c: Likewise.
1600 * lisp.h: Likewise.
1601 * lread.c: Likewise.
1602 * minibuf.c: Likewise.
1603 * msdos.c: Likewise.
1604 * print.c: Likewise.
1605 * process.c: Likewise.
1606 * region-cache.c: Likewise.
1607 * search.c: Likewise.
1608 * sysdep.c: Likewise.
1609 * termcap.c: Likewise.
1610 * terminal.c: Likewise.
1611 * tparam.c: Likewise.
1612 * w16select.c: Likewise.
1613 * w32.c: Likewise.
1614 * w32reg.c: Likewise.
1615 * w32select.c: Likewise.
1616 * w32uniscribe.c: Likewise.
1617 * widget.c: Likewise.
1618 * xdisp.c: Likewise.
1619 * xmenu.c: Likewise.
1620 * xrdb.c: Likewise.
1621 * xselect.c: Likewise.
1622
0497dc44
PE
16232012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1624
1625 * fileio.c (time_error_value): Check the right error number.
1626 Problem reported by Troels Nielsen in
1627 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1628
356e7178
PE
16292012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1630
4e71fd89
PE
1631 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1632 This should be fixed in a better way; see Eli Zaretskii in
1633 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1634 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1635
f0941253
PE
1636 * fileio.c (time_error_value): Rename from special_mtime.
1637 The old name's problems were noted by Eli Zaretskii in
1638 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1639
065c9eb4
PE
1640 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1641 This variable's comment says Emacs needs at least one GDB-visible
1642 symbol of type enum pvec_type, to work around GDB problems.
1643 The symbol's value doesn't matter.
1644
356e7178
PE
1645 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1646 that causes compilation to fail on pre-C99 compilers.
1647
ed9265fc 16482012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1649
1650 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1651 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1652
3884d954
DA
16532012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1654
d209e2fb 1655 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1656 headers for buffer_defaults and buffer_local_symbols.
1657 Reported by Juanma Barranquero <lekktu@gmail.com>.
1658
ee28be33
SM
16592012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1660
1661 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1662 * lisp.h (enum pvec_type): Use fewer bits.
1663 (PSEUDOVECTOR_SIZE_BITS): New constant.
1664 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1665 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1666 change in pvec_type.
1667 (PSEUDOVECTOR_TYPEP): New macro.
1668 (TYPED_PSEUDOVECTORP): Use it.
1669 * fns.c (internal_equal): Adapt code to extract pvectype.
1670 * emacs.c (gdb_pvec_type): Update type.
1671 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1672 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1673 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1674 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1675 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1676 abusing vector->header.next.nbytes.
1677 (live_vector_p): Use PVEC_TYPE.
1678 (mark_object): Adapt code to extract pvectype. Use switch.
1679
c7f2cd7f
PE
16802012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1681
1682 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1683 Tighten new eassert a bit.
1684
8ce70ed2
DA
16852012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1686
1687 Fix compilation with --enable-gcc-warnings and -O1
1688 optimization level.
1689 * doprnt.c (doprnt): Change type of tem to int, initialize
1690 to avoid compiler warning. Add eassert.
1691 * search.c (simple_search): Initialize match_byte to avoid
1692 compiler warning. Add eassert.
1693
dea7f1e5
PE
16942012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1695
24a212eb
PE
1696 Avoid weird behavior with large horizontal scrolls.
1697 Without this change, for example, large hscroll values would
1698 mess up Emacs's display on Fedora 15 x86, presumably due to
1699 overflows in int calculations in the display code.
1700 Also, if buffers had long lines, Emacs would freeze.
1701 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1702 (set_window_hscroll): New function, containing the old guts of
1703 Fset_window_hscroll. Return the clipped value.
1704 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1705 This avoids the need to check against PTRDIFF_MAX.
1706
dea7f1e5
PE
1707 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1708
76046526
DA
17092012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1710
1711 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1712
39adff0d
PE
17132012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1714
63807d47
PE
1715 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1716 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1717 since GCC 4.4.6 issues a bogus warning for them.
1718
39adff0d
PE
1719 Fix bugs in file timestamp newness comparisons.
1720 * fileio.c (Ffile_newer_than_file_p):
1721 * lread.c (Fload): Use full timestamp resolution of files,
1722 not just the 1-second resolution, so that files that are only
1723 slightly newer still count as newer.
1724 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1725 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1726
dbeed9a6
PE
17272012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1728
1729 * fileio.c: Improve handling of file time marker. (Bug#11852)
1730 (special_mtime): New function.
1731 (Finsert_file_contents, Fverify_visited_file_modtime):
1732 Use it to set special mtime values consistently.
1733
636334d6
AS
17342012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1735
1736 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1737 marker for non-existing file. (Bug#11852)
1738
e2017fe2
GM
17392012-07-03 Glenn Morris <rgm@gnu.org>
1740
1741 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1742 and did not make it into globals.h).
1743
404dbd37
TT
17442012-07-03 Tom Tromey <tromey@redhat.com>
1745
1746 * window.c (Fset_window_margins, Fset_window_fringes)
1747 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1748 * textprop.c (Fprevious_property_change): No longer static.
1749 * syntax.c (Fsyntax_table_p): No longer static.
1750 * process.c (Fget_process, Fprocess_datagram_address): No longer
1751 static.
1752 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1753 * keyboard.c (Fcommand_execute): No longer static.
1754 Remove EXFUN.
1755 * insdel.c (Fcombine_after_change_execute): No longer static.
1756 * image.c (Finit_image_library): No longer static.
1757 * fileio.c (Fmake_symbolic_link): No longer static.
1758 * eval.c (Ffetch_bytecode): No longer static.
1759 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1760 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1761 No longer static.
404dbd37
TT
1762 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1763 static.
1764 * dired.c (Ffile_attributes): No longer static.
1765 * composite.c (Fcomposition_get_gstring): No longer static.
1766 * callproc.c (Fgetenv_internal): No longer static.
1767
1768 * ccl.h: Remove EXFUNs.
1769 * buffer.h: Remove EXFUNs.
1770 * dispextern.h: Remove EXFUNs.
1771 * intervals.h: Remove EXFUNs.
1772 * fontset.h: Remove EXFUN.
1773 * font.h: Remove EXFUNs.
1774 * dosfns.c (system_process_attributes): Remove EXFUN.
1775 * keymap.h: Remove EXFUNs.
1776 * lisp.h: Remove EXFUNs.
1777 * w32term.h: Remove EXFUNs.
1778 * window.h: Remove EXFUNs.
1779 * xsettings.h: Remove EXFUN.
1780 * xterm.h: Remove EXFUN.
1781
8e4fd1e1
GM
17822012-07-03 Glenn Morris <rgm@gnu.org>
1783
1784 * lisp.h (Frandom): Make it visible to C.
1785 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1786 buffer for invisible buffers. (Bug#1229)
1787
ca95b3eb
DA
17882012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1789
1790 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1791 values which aren't power of 2.
1792 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1793 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1794 accordingly.
1795
7555c33f
SM
17962012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1797
1798 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1799
1800 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1801
d12e8f5a
DA
18022012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1803
1804 * alloc.c (allocate_vector_block): Remove redundant
1805 calls to mallopt if DOUG_LEA_MALLOC is defined.
1806 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1807 avoid calls to mallopt if zero_vector is returned.
1808
296094c3
DA
18092012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1810
1811 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1812 is enabled, avoid dereferencing NULL current_sblock if
1813 running undumped.
1814
36429c89
DA
18152012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1816
1817 Cleanup basic buffer management.
1818 * buffer.h (struct buffer): Change layout to use generic vector
1819 marking code. Fix some comments. Change type of 'clip_changed'
1820 to bitfield. Remove unused #ifndef old.
1821 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1822 (GET_OVERLAYS_AT): Fix indentation.
1823 (for_each_per_buffer_object_at): New macro.
1824 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1825 (Fbuffer_local_variables): Use it.
1826 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1827 * alloc.c (allocate_buffer): Adjust to match new layout of
1828 struct buffer. Fix comment.
1829 (mark_overlay): New function.
1830 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1831 Lisp area of struct buffer.
1832 (mark_object): Use it. Adjust marking of misc objects
1833 and related comments.
1834
3b3e4cac
PE
18352012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1838 wrapper that is not needed because the wrapped code is a no-op (zero
1839 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1840 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1841
cf5c0175
DA
18422012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1843
1844 * alloc.c (mark_buffer): Simplify. Remove prototype.
1845 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1846 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1847 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1848 redundant calls to mark_vectorlike for bool vectors.
1849
ca26824c
GM
18502012-06-30 Glenn Morris <rgm@gnu.org>
1851
2e4c5312
GM
1852 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1853
ca26824c
GM
1854 * epaths.in (PATH_SITELOADSEARCH): New.
1855 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1856 This is rather than relying on --enable-locallisppath elements
1857 having "site-lisp" in their names. (Bug#10208#25, 11658)
1858
0d23c240
EZ
18592012-06-30 Eli Zaretskii <eliz@gnu.org>
1860
c9240d7a
EZ
1861 * w32proc.c (sys_select): Accept and ignore one more argument.
1862
1863 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1864
0d23c240 1865 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1866 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1867
1868 * sysdep.c: Don't include dos.h and dosfns.h.
1869
1870 * process.c (sys_select):
1871 * msdos.c (sys_select): Accept one more argument and ignore it.
1872
1873 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1874 adapt data types and code to that.
1875
1876 * dosfns.c:
1877 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1878 which clashes with the gnulib function of the same name.
1879
af5a5a98
AS
18802012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1881
c5e4379c
AS
1882 * font.c (font_style_to_value, font_style_symbolic)
1883 (font_prop_validate_style): Add type checks for values in
1884 font_style_table.
1885
af5a5a98
AS
1886 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1887 argument.
1888 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1889 uses.
1890
8d38f461
EZ
18912012-06-29 Eli Zaretskii <eliz@gnu.org>
1892
2e5a6631
EZ
1893 * xdisp.c (try_window_id): Undo last change.
1894
8d38f461
EZ
1895 * w32.c (getwd): Adjust commentary about startup_dir.
1896 (init_environment): Always call sys_access, even in non-MSVC
1897 builds. Don't chdir to the directory of the Emacs executable.
1898 This undoes code from 1997 which was justified by the need to
1899 "avoid conflicts when removing and renaming directories". But its
1900 downside was that every relative file name was being interpreted
1901 relative to the directory of the Emacs executable, which can never
1902 be TRT. In particular, it broke sys_access when called with
1903 relative file names.
1904 (sys_access): Map GetLastError to errno.
1905
2af3565e
DA
19062012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1907
1908 * window.h (struct window): Change type of 'fringes_outside_margins'
1909 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1910 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1911 Adjust comment.
1912 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1913 to ptrdiff_t.
1914
c8d3a25c 19152012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1916
c8d3a25c
GM
1917 * gnutls.c (emacs_gnutls_handshake):
1918 Add QUIT to make the loop interruptible.
57570cd3 1919
c8d3a25c 19202012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1921
c8d3a25c
GM
1922 * charset.c (init_charset): Make lack of etc/charsets fatal.
1923
3e984ee8
DA
19242012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1925
1926 * editfns.c (region_limit): Fix type mismatch.
1927
ef884f23
DA
19282012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1929
1930 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1931 undefined. Convert from xassert to eassert.
1932 * nsmenu.m: Convert from xassert to eassert.
1933 * nsterm.m: Likewise.
1934
7d7e0027
SM
19352012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1936
1937 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1938
aa754e6a
PE
19392012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1940
1941 Avoid integer overflow on scroll-left and scroll-right.
1942 * window.c (HSCROLL_MAX): New macro.
1943 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1944 overflow when requested scroll falls outside ptrdiff_t range.
1945
80b00b08
DA
19462012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1947
1948 * window.h (struct window): Change type of 'hscroll',
1949 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1950 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1951 Adjust users accordingly.
1952 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1953 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1954 from EMACS_INT to ptrdiff_t.
1955 (make_window): Omit redundant initialization.
1956
62b2bcf6
JB
19572012-06-28 Juanma Barranquero <lekktu@gmail.com>
1958
1959 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1960
45942c7d
DA
19612012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1962
1963 * window.h (struct window): Change type of 'use_time' and
1964 'sequence_number' from Lisp_Object to int.
1965 * frame.c (make_frame): Adjust users accordingly.
1966 * print.c (print_object): Likewise.
1967 * window.c (select_window, Fwindow_use_time, make_parent_window)
1968 (make_window): Likewise.
1969
e509cfa6
DA
19702012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1971
1972 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1973 enabled with --enable-checking=[all,glyphs] configure option.
1974 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1975 adjust comments accordingly.
1976 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1977 undefined, adjust comments accordingly.
1978 * image.c: Likewise.
1979 * scroll.c: Likewise.
1980 * w32fns.c: Likewise.
1981 * w32term.c: Likewise.
1982 * xdisp.c: Likewise.
1983 * xfaces.c: Likewise.
1984 * xfns.c: Likewise.
1985 * xterm.c: Likewise.
1986
a54e2c05
DA
19872012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1988
1989 Generalize run-time debugging checks.
1990 * dispextern.h (XASSERTS): Remove.
1991 * fontset.c (xassert): Remove.
1992 Convert from xassert to eassert.
1993 * alloc.c: Convert from xassert to eassert.
1994 * bidi.c: Likewise.
1995 * dispnew.c: Likewise.
1996 * fns.c: Likewise.
1997 * fringe.c: Likewise.
1998 * ftfont.c: Likewise.
1999 * gtkutil.c: Likewise.
2000 * image.c: Likewise.
2001 * keyboard.c: Likewise.
2002 * menu.c: Likewise.
2003 * process.c: Likewise.
2004 * scroll.c: Likewise.
2005 * sound.c: Likewise.
2006 * term.c: Likewise.
2007 * w32console.c: Likewise.
2008 * w32fns.c: Likewise.
2009 * w32term.c: Likewise.
2010 * window.c: Likewise.
2011 * xdisp.c: Likewise.
2012 * xfaces.c: Likewise.
2013 * xfns.c: Likewise.
2014 * xselect.c: Likewise.
2015 * xterm.c: Likewise.
2016
1ec4b7b2
SM
20172012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2018
2019 * fns.c (maybe_resize_hash_table): Output message when growing the
2020 purify-hashtable.
2021
2014308a
DA
20222012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2023
2024 * alloc.c (allocate_string_data): Remove dead code.
2025 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2026 avoid GCC warning about unused macro.
2027
246155eb
DA
20282012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2029
2030 * alloc.c (allocate_string): Omit intervals initialization.
2031 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2032 as in make_pure_string and make_pure_c_string.
2033
43184b7b
DA
20342012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2035
d209e2fb 2036 * alloc.c (allocate_string): Fix last change.
43184b7b 2037
3fe6dd74
DA
20382012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2039
d209e2fb 2040 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2041 to memset, add explicit initialization where appropriate.
2042
1ba6038a
GM
20432012-06-27 Glenn Morris <rgm@gnu.org>
2044
2045 * lisp.mk (lisp): Remove paths.elc.
2046
c89926a5
CY
20472012-06-27 Chong Yidong <cyd@gnu.org>
2048
2049 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2050
ed6b3510
JW
20512012-06-26 John Wiegley <johnw@newartisans.com>
2052
1ec4b7b2 2053 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2054 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2055
ed6b3510
JW
2056 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2057 when building with Clang.
2058
8edd4a2b
SM
20592012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2060
2061 * eval.c (Fapply): Allow calling it with a single argument.
2062
f6f62d1b
EZ
20632012-06-26 Eli Zaretskii <eliz@gnu.org>
2064
2065 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2066 _stricmp and _strnicmp.
2067 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2068
62efea5e
DA
20692012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2070
2071 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2072 allocated window.
2073 (allocate_process): Likewise for new process.
8edd4a2b 2074 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2075 (allocate_frame): Likewise.
2076 * frame.c (make_frame): Omit redundant initialization.
2077 * window.c (make_parent_window): Use memset.
2078 (make_window): Omit redundant initialization.
2079 * process.c (make_process): Omit redundant initialization.
2080 * terminal.c (create_terminal): Likewise.
2081
42997f4d
DA
20822012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2083
2084 * term.c (delete_tty): Remove redundant call to memset.
2085
1130ecfc
DA
20862012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2087
2088 * alloc.c: Remove build_string.
2089 * lisp.h: Define build_string as static inline. This provides
2090 a better opportunity to optimize away calls to strlen when the
2091 function is called with compile-time constant argument.
2092 * image.c (imagemagick_error): Convert to build_string.
2093 * w32proc.c (sys_spawnve): Likewise.
2094 * xterm.c (x_term_init): Likewise.
2095
cf38a720
PE
20962012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2097
99027bdd
PE
2098 Use sprintf return value instead of invoking strlen on result.
2099 In the old days this wasn't portable, since some sprintf
2100 implementations returned char *. But they died out years ago and
2101 Emacs already assumes sprintf returns int.
2102 Similarly for float_to_string.
2103 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2104 * ccl.c (ccl_driver):
2105 * character.c (string_escape_byte8):
2106 * data.c (Fnumber_to_string):
2107 * doprnt.c (doprnt):
2108 * print.c (print_object):
2109 * xdisp.c (message_dolog):
2110 * xfns.c (syms_of_xfns):
2111 Use sprintf or float_to_string result to avoid need to call strlen.
2112 * data.c (Fnumber_to_string):
2113 Use make_unibyte_string, since the string must be ASCII.
2114 * lisp.h, print.c (float_to_string): Now returns int length.
2115 * term.c (produce_glyphless_glyph):
2116 Use sprintf result rather than recomputing it.
2117
cf38a720
PE
2118 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2119 * Makefile.in (ALL_CFLAGS):
2120 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2121 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2122
3511c784
DA
21232012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2124
0a08eb21 2125 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2126 strcasecmp if available.
2127 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2128
fb7da12e
AS
21292012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2130
2131 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2132 Avoid comma operator.
2133 * menu.c (push_submenu_start, push_submenu_end)
2134 (push_left_right_boundary, push_menu_pane): Likewise.
2135 * msdos.c (dos_rawgetc): Likewise.
2136
afa2ffd8
DA
21372012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2138
2139 * xfns.c (xic_create_fontsetname): Remove redundant calls
2140 to memset.
2141
b3b4476b
PE
21422012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2143
4495ff38
PE
2144 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2145 sprintf already null-terminates its output.
2146
b3b4476b
PE
2147 * xfns.c (x_window): Remove redundant cast.
2148
b00876c9
DA
21492012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2150
2151 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2152 `const char *' to `char *' to avoid compiler warning.
2153
d188e26b
PE
21542012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2155
885d1d74
PE
2156 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2157 instead of truncating it to 63 (admittedly a generous limit).
2158
d188e26b
PE
2159 * process.c: Fix spelling and caps in comments.
2160
e2f560b1
DN
21612012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2162
e86db54b 2163 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2164 * sysdep.c (setpgrp): Remove definition, not used in this file.
2165
7583a3a1
JB
21662012-06-24 Juanma Barranquero <lekktu@gmail.com>
2167
2168 * makefile.w32-in: Update dependencies.
2169
696056c2
EZ
21702012-06-24 Eli Zaretskii <eliz@gnu.org>
2171
2172 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2173 (SYSTIME_H): Add nt/inc/sys/time.h.
2174
2175 * systime.h [WINDOWSNT]: Include sys/time.h.
2176
2177 * s/ms-w32.h (struct timespec): Definition moved from
2178 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2179
845ca893
PE
21802012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2181
2182 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2183 * buffer.h (buffer_slot_type_mismatch):
2184 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2185 * eval.c (unwind_to_catch):
2186 * image.c (my_png_error, my_error_exit):
2187 * keyboard.c (quit_throw_to_read_char, user_error)
2188 (Fexit_recursive_edit, Fabort_recursive_edit):
2189 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2190 (wrong_type_argument, buffer_overflow, __executable_start)
2191 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2192 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2193 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2194 (fatal):
2195 (child_setup) [!DOS_NT]:
2196 * lread.c (end_of_file_error, invalid_syntax):
2197 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2198 * puresize.h (pure_write_error):
2199 * search.c (matcher_overflow):
2200 * sound.c (sound_perror, alsa_sound_perror):
2201 * sysdep.c, syssignal.h (croak):
2202 * term.c (maybe_fatal, vfatal):
2203 * textprop.c (text_read_only):
2204 * undo.c (user_error):
2205 * unexmacosx.c (unexec_error):
2206 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2207 Use _Noreturn rather than NO_RETURN.
2208 No need for separate decl merely because of _Noreturn.
2209 * sound.c (sound_warning, parse_sound):
2210 Remove unnecessary forward decls.
2211
f1dd8073
PE
22122012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2213
2214 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2215 * lisp.h (WAIT_READING_MAX): New macro.
2216 * dispnew.c (Fsleep_for, sit_for):
2217 * keyboard.c (kbd_buffer_get_event):
2218 * process.c (Faccept_process_output):
2219 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2220 This improves on the previous patch, which introduced a bug
2221 when time_t is unsigned and as wide as intmax_t.
2222 See <http://bugs.gnu.org/9000#51>.
2223
b82c1755
EZ
22242012-06-23 Eli Zaretskii <eliz@gnu.org>
2225
2226 * dispnew.c (sit_for, Fsleep_for):
2227 * keyboard.c (kbd_buffer_get_event):
2228 * process.c (Faccept_process_output): Avoid compiler warnings when
2229 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2230
ca300656
JB
22312012-06-23 Juanma Barranquero <lekktu@gmail.com>
2232
049ec95b
JB
2233 * makefile.w32-in: Update dependencies.
2234
ca300656
JB
2235 * w32.c (ltime): Add return type and declare static.
2236 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2237
db7b8d06
PE
22382012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2239
2240 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2241 Privately reported by Herbert J. Skuhra.
2242 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2243 All uses changed.
2244 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2245 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2246
0bd8297f
EZ
22472012-06-23 Eli Zaretskii <eliz@gnu.org>
2248
96512555
EZ
2249 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2250 last argument of make_unibyte_string.
2251
0bd8297f
EZ
2252 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2253 language ID in the event parameters.
2254
2255 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2256 event.code, not the obscure "character set ID".
2257
63def6b6
CY
22582012-06-23 Chong Yidong <cyd@gnu.org>
2259
2260 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2261
e8a02204
EZ
22622012-06-23 Eli Zaretskii <eliz@gnu.org>
2263
388cdec0
EZ
2264 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2265 * w32.c (fdutimens): New function.
2266
2267 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2268
2269 * s/ms-w32.h (pselect): Redirect to sys_select.
2270
2271 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2272
e8a02204
EZ
2273 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2274 in the logic of incrementing and decrementing the value of
2275 use_relocatable_buffers.
2276
d054f3fb
PE
22772012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2278
2279 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2280 Privately reported by Herbert J. Skuhra.
2281 [__FreeBSD__]: Remove "*/" typo after "#include".
2282 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2283 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2284 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2285 Don't assume EMACS_TIME and struct timeval are the same type.
2286
d35af63c
PE
22872012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2288
2289 Support higher-resolution time stamps (Bug#9000).
2290 The time stamps are only nanosecond-resolution at the C level,
2291 since that's the best that any real-world system supports now.
2292 But they are picosecond-resolution at the Lisp level, as that's
2293 easy, and leaves room for future OS improvements.
2294
2295 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2296 (LIBES): Use it.
2297
2298 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2299 Don't get current time unless it's needed.
2300
2301 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2302 now provides it if it's absent.
2303 (start_atimer): Port to higher-res time stamps.
2304 Check for time stamp overflow. Don't get current time more
2305 often than is needed.
2306
2307 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2308 Include systime.h, not time.h.
2309 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2310
2311 * dired.c: Include stat-time.h.
2312 (Ffile-attributes): File times now have higher resolution.
2313
2314 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2315 (struct image): Timestamp now has higher resolution.
2316
2317 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2318 has at least microseconds now. All uses removed.
2319 (update_frame, update_single_window, update_window, update_frame_1)
2320 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2321
2322 * editfns.c (time_overflow): Now extern.
2323 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2324 (float-time, Fformat_time_string, Fcurrent_time_string)
2325 (Fcurrent_time_zone): Accept and generate higher-resolution
2326 time stamps.
2327 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2328 (decode_time_components, lisp_seconds_argument): New functions.
2329 (make_time): Now static.
2330 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2331 Report an error if the time is invalid, rather than having the caller
2332 do that.
2333
2334 * fileio.c: Include <stat-time.h>
2335 (Fcopy_file): Copy higher-resolution time stamps.
2336 Prefer to set the time stamp via a file descriptor if that works.
2337 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2338 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2339 (Fvisited_file_modtime, Fset_visited_file_modtime):
2340 Support higher-resolution time stamps.
2341
2342 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2343
2344 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2345
2346 * image.c (prepare_image_for_display, clear_image_cache)
2347 (lookup_image): Port to higer-resolution time stamps.
2348
2349 * keyboard.c (start_polling, bind_polling_period):
2350 Check for time stamp overflow.
2351 (read_char, kbd_buffer_get_event, timer_start_idle)
2352 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2353 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2354 Port to higher-resolution time stamps. Do not assume time_t is signed.
2355 (decode_timer): New function. Timers are now vectors of length 9,
2356 not 8, to accommodate the picosecond component.
2357 (timer_check_2): Use it.
2358
2359 * nsterm.m (select_timeout, timeval_subtract): Remove.
2360 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2361 as they're a bit more accurate and handle overflow better.
2362 (ns_select): Change prototype to be compatible with pselect.
2363 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2364 * nsterm.h (ns_select): Adjust prototype.
2365
2366 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2367 us-resolution time stamps.
2368 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2369
2370 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2371
2372 * lisp.h (time_overflow): New decl.
2373 (wait_reading_process_output): First arg is now intmax_t, not int,
2374 to accommodate larger waits.
2375
2376 * process.h (struct Lisp_Process.read_output_delay):
2377 Now counts nanoseconds, not microseconds.
2378 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2379 EMACS_HAS_USECS.
2380 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2381 (wait_reading_process_output):
2382 Port to ns-resolution time stamps.
2383 (Faccept_process_output, wait_reading_process_output):
2384 Check for time stamp overflow. Do not assume time_t is signed.
2385 (select_wrapper): Remove; we now use pselect.
2386 (Fprocess_attributes): Now generates ns-resolution time stamps.
2387
2388 * sysdep.c: Include utimens.h. Don't include utime.h
2389 or worry about struct utimbuf; gnulib does that for us now.
2390 (gettimeofday): Remove; gnulib provides a substitute.
2391 (make_timeval): New function.
2392 (set_file_times): Now sets ns-resolution time stamps.
2393 New arg FD; all uses changed.
2394 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2395 (system_process_attributes):
2396 Now returns ns-resolution time stamp. All uses changed.
2397 Check for time stamp overflow.
2398
2399 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2400 provides a substitute now.
2401
2402 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2403 since it guarantees struct timespec.
2404 (EMACS_TIME): Now struct timespec, so that we can support
2405 ns-resolution time stamps.
2406 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2407 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2408 (EMACS_USECS): Remove.
2409 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2410 so multiply the arg by 1000 before storing it.
2411 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2412 New macros.
2413 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2414 Port to ns-resolution time stamps.
2415 (EMACS_TIME_NEG_P): Remove; replaced by....
2416 (EMACS_TIME_SIGN): New macro.
2417 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2418 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2419 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2420 (make_timeval, make_lisp_time, decode_time_components): New decls.
2421 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2422 that it mishandled time_t overflow. You can't compare by subtracting!
2423 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2424 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2425
2426 * term.c: Include <sys/time.h>.
2427 (timeval_to_Time): New function, for proper overflow wraparound.
2428 (term_mouse_position, term_mouse_click): Use it.
2429
2430 * undo.c (record_first_change): Support higher-resolution time stamps
2431 in the undo buffer.
2432 (Fprimitive_undo): Use them when restoring time stamps.
2433
2434 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2435 (w32_get_internal_run_time):
2436 Port to higher-resolution Emacs time stamps.
2437 (ltime): Now accepts single 64-bit integer, as that's more convenient
2438 for callers.
2439
2440 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2441
2442 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2443 for compatibility with pselect. Support ns-resolution time stamps.
2444
2445 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2446
2447 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2448 Check for time stamp overflow, and support ns-resolution time stamps.
2449
2450 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2451 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2452 (timeval_subtract): Remove; no longer needed.
2453 (XTflash, XTring_bell, x_wait_for_event):
2454 Port to ns-resolution time stamps. Don't assume time_t is signed.
2455
b6a92dfe
CY
24562012-06-22 Chong Yidong <cyd@gnu.org>
2457
2458 * xdisp.c (x_consider_frame_title): Revert last change.
2459
d251c37c
EZ
24602012-06-22 Eli Zaretskii <eliz@gnu.org>
2461
2462 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2463 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2464 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2465 staticidx goes up to 1597 out of 1600 = 0x640.)
2466
f10deafb
PE
24672012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2468
2469 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2470 Otherwise, the umask might be mistakenly 0 while handling input signals.
2471
ec6de1e2
SM
24722012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2473
2474 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2475
28be1ada
DA
24762012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2477
2478 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2479 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2480 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2481 access to `contents' member of Lisp_Vector objects with AREF and ASET
2482 where appropriate.
2483
c6bf3022
CY
24842012-06-19 Chong Yidong <cyd@gnu.org>
2485
2486 * frame.c (delete_frame): When selecting a frame on a different
2487 text terminal, do not alter the terminal's top-frame.
2488
2489 * xdisp.c (format_mode_line_unwind_data): Record the target
2490 frame's selected window and its terminal's top-frame.
2491 (unwind_format_mode_line): Restore them.
2492 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2493 Callers changed.
2494 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2495 since tty frames can be explicitly named.
2496 (prepare_menu_bars): Likewise.
2497
2498 * term.c (Ftty_top_frame): New function.
2499
defd4196
PE
25002012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2501
2502 Port byte-code-meter to modern targets.
2503 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2504 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2505 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2506 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2507 (METER_1, METER_2): Simplify.
2508
1053a871
SM
25092012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2510
2511 * data.c (Fdefalias): Return `symbol' (bug#11686).
2512
b7e8d081
MR
25132012-06-18 Martin Rudalics <rudalics@gmx.at>
2514
2515 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2516 gets killed during executing of this function (Bug#11665).
2517 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2518 (Vkill_buffer_query_functions): In doc-string say that functions
2519 run by this hook should not change the current buffer.
2520
7ea2b339
PE
25212012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2522
2523 Fix recently-introduced process.c problems found by static checking.
2524 * process.c (write_queue_push, write_queue_pop, send_process):
2525 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2526 (write_queue_pop): Fix pointer signedness problem.
2527 (send_process): Remove unused local.
2528
96a313a1
CY
25292012-06-17 Chong Yidong <cyd@gnu.org>
2530
2531 * xdisp.c (redisplay_internal): No need to redisplay terminal
2532 frames that are not on top.
2533
20ca2e94
TN
25342012-06-17 Troels Nielsen <bn.troels@gmail.com>
2535
2536 * process.c (make_process): Initialize write_queue.
2537 (write_queue_push, write_queue_pop): New functions.
2538 (send_process): Use them to maintain correct ordering of process
2539 writes (Bug#10815).
2540
9a900ca9
PE
25412012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2542
310fbfa8
PE
2543 * lisp.h (eassert): Assume C89 or later.
2544 This removes the need for CHECK.
2545 (CHECK): Remove. Its comments about always evaluating its
2546 argument were confusing, as 'eassert' typically does not evaluate
2547 its argument.
2548
27bb1ca4
PE
2549 * coding.c (produce_chars): Use ptrdiff_t, not int.
2550
9a900ca9
PE
2551 * xterm.c (x_draw_underwave): Check for integer overflow.
2552 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2553
41b7f8bc 25542012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2555
2556 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2557 referenced (Bug#11583).
2558
9b0e3eba
AA
25592012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2560
2561 Implement wave-style variant of underlining.
2562 * dispextern.h (face_underline_type): New enum.
2563 (face): Add field for underline type.
2564 * nsterm.m (ns_draw_underwave): New function.
2565 (ns_draw_text_decoration): Use it.
2566 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2567 New functions.
2568 (x_draw_glyph_string): Use them.
2569 * xfaces.c (Qline, Qwave): New Lisp objects.
2570 (check_lface_attrs, merge_face_ref)
1053a871
SM
2571 (Finternal_set_lisp_face_attribute, realize_x_face):
2572 Handle wave-style underline face attributes.
9b0e3eba
AA
2573 * xterm.c (x_draw_underwave): New function.
2574 (x_draw_glyph_string): Use it.
2575
0fb52f11
JB
25762012-06-16 Juanma Barranquero <lekktu@gmail.com>
2577
2578 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2579 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2580 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2581 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2582 ($(BLD)/w32select.$(O)): Update dependencies.
2583
e5560ff7
AS
25842012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2585
2586 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2587 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2588 * character.c (_fetch_multibyte_char_p): Remove.
2589 * alloc.c: Include "character.h" before "buffer.h".
2590 * bidi.c: Likewise.
2591 * buffer.c: Likewise.
2592 * bytecode.c: Likewise.
2593 * callint.c: Likewise.
2594 * callproc.c: Likewise.
2595 * casefiddle.c: Likewise.
2596 * casetab.c: Likewise.
2597 * category.c: Likewise.
2598 * cmds.c: Likewise.
2599 * coding.c: Likewise.
2600 * composite.c: Likewise.
2601 * dired.c: Likewise.
2602 * dispnew.c: Likewise.
2603 * doc.c: Likewise.
2604 * dosfns.c: Likewise.
2605 * editfns.c: Likewise.
2606 * emacs.c: Likewise.
2607 * fileio.c: Likewise.
2608 * filelock.c: Likewise.
2609 * font.c: Likewise.
2610 * fontset.c: Likewise.
2611 * fringe.c: Likewise.
2612 * indent.c: Likewise.
2613 * insdel.c: Likewise.
2614 * intervals.c: Likewise.
2615 * keyboard.c: Likewise.
2616 * keymap.c: Likewise.
2617 * lread.c: Likewise.
2618 * macros.c: Likewise.
2619 * marker.c: Likewise.
2620 * minibuf.c: Likewise.
2621 * nsfns.m: Likewise.
2622 * nsmenu.m: Likewise.
2623 * print.c: Likewise.
2624 * process.c: Likewise.
2625 * regex.c: Likewise.
2626 * region-cache.c: Likewise.
2627 * search.c: Likewise.
2628 * syntax.c: Likewise.
2629 * term.c: Likewise.
2630 * textprop.c: Likewise.
2631 * undo.c: Likewise.
2632 * unexsol.c: Likewise.
2633 * w16select.c: Likewise.
2634 * w32fns.c: Likewise.
2635 * w32menu.c: Likewise.
2636 * window.c: Likewise.
2637 * xdisp.c: Likewise.
2638 * xfns.c: Likewise.
2639 * xmenu.c: Likewise.
2640 * xml.c: Likewise.
2641 * xselect.c: Likewise.
2642
2f07e6af
EZ
26432012-06-16 Eli Zaretskii <eliz@gnu.org>
2644
1053a871
SM
2645 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2646 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2647 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2648 row.
2649 (handle_face_prop): Use chunk-relative overlay string index when
2650 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2651 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2652 the rightmost. (Bug#11720)
2f07e6af 2653
29b83cec
AS
26542012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2655
2656 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2657 (CATEGORY_MEMBER): Enforce 1/0 value.
2658 * category.c (_temp_category_set): Remove.
2659
4c5501e9
EZ
26602012-06-16 Eli Zaretskii <eliz@gnu.org>
2661
2662 * window.c (Fdelete_other_windows_internal)
2663 (Fdelete_window_internal): Don't access frame's mouse highlight
2664 info of the initial frame. (Bug#11677)
2665
2b570124
PE
26662012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2667
e93864f9
PE
2668 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2669 Assume USE_2_TAGS_FOR_INTS.
2670 (xreload): Adjust $tagmask width to match recent lisp.h change.
2671
2b570124
PE
2672 Simplify lisp.h in minor ways that should not affect code.
2673 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2674 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2675 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2676 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2677 (INTTYPEBITS): New macro, for clarity.
2678 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2679 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2680 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2681 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2682 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2683
81755f69
JB
26842012-06-13 Juanma Barranquero <lekktu@gmail.com>
2685
2686 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2687
16192a57
GM
26882012-06-13 Glenn Morris <rgm@gnu.org>
2689
2690 * s/bsd-common.h (BSD4_3):
2691 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2692
646b5f55
AS
26932012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2694
2695 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2696 instead of union.
2697 (XLI, XIL): Define.
1053a871
SM
2698 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2699 Use them.
2700 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2701 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2702 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2703 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2704 * frame.c (delete_frame): Remove outdated comment.
2705 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2706 USE_LISP_UNION_TYPE.
2707 (Fw32_unregister_hot_key): Likewise.
2708 (Fw32_toggle_lock_key): Likewise.
2709 * w32menu.c (add_menu_item): Likewise.
2710 (w32_menu_display_help): Use XIL instead of checking
2711 USE_LISP_UNION_TYPE.
2712 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2713 (init_heap): Likewise.
2714 * w32term.c (w32_read_socket): Update comment.
2715
1d3823c9
GM
27162012-06-13 Glenn Morris <rgm@gnu.org>
2717
c62ff706
GM
2718 * s/usg5-4-common.h, src/s/unixware.h:
2719 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2720
1d3823c9
GM
2721 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2722
bfe3e0a2
PE
27232012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2724
2725 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2726 * alloc.c (make_number) [!defined make_number]:
2727 Remove, as lisp.h always defines this now.
2728 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2729 (roundup_size): Verify that it is a power of 2.
2730 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2731 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2732 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2733 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2734 USE_LSB_TAG now is always defined to be either 0 or 1.
2735 All uses changed.
2736 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2737 code works fine either way, and efficiency is not a concern here,
2738 as the union type is for debugging, not for production.
2739 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2740 Use an inline function on all platforms when using the union type,
2741 since this is simpler and 'static inline' can be used portably
2742 within Emacs now.
2743 (LISP_INITIALLY_ZERO): New macro.
2744 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2745 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2746
45fa9c0f
GM
27472012-06-12 Glenn Morris <rgm@gnu.org>
2748
b4492cba
GM
2749 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2750
2751 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2752
45fa9c0f
GM
2753 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2754 Move BROKEN_SIGIO to configure.
2755
2756 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2757 Move NO_TERMIO to configure.
2758
0e25d334
CY
27592012-06-12 Chong Yidong <cyd@gnu.org>
2760
2761 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2762 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2763 MagickExportImagePixels is undefined.
2764
43682bb6
PE
27652012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2766
2767 * image.c (imagemagick_load_image): Remove unused label.
2768
a9be7d2b
GM
27692012-06-11 Glenn Morris <rgm@gnu.org>
2770
2771 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2772 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2773 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2774 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2775
3017f87f
SM
27762012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2777
2778 * alloc.c (make_byte_code): New function.
2779 (Fmake_byte_code): Use it. Don't purify here.
2780 * lread.c (read1): Use it as well to avoid extra allocation.
2781
1b9b4cf4
CY
27822012-06-11 Chong Yidong <cyd@gnu.org>
2783
2784 * image.c (imagemagick_load_image): Implement transparency.
2785
95988fcf
AS
27862012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2787
2788 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2789 account for preceding backslashes. (Bug#11663)
2790
cd4eb164
CY
27912012-06-09 Chong Yidong <cyd@gnu.org>
2792
2793 * term.c: Support italics in capable terminals (Bug#9652).
2794 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2795 (turn_on_face): Output using TS_enter_italic_mode if available.
2796 Don't handle unused blinking and alt-charset cases.
2797 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2798 and tty_alt_charset_p cases.
2799 (tty_capable_p, init_tty): Support italics.
2800
2801 * termchar.h (struct tty_display_info): Add field for italics.
2802 Remove unused blink field.
2803
2804 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2805 Handle slant.
2806
2807 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2808 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2809 tty_alt_charset_p. Add tty_italic_p.
2810
ff88beb8
MA
28112012-06-09 Michael Albinus <michael.albinus@gmx.de>
2812
2813 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2814 dbus_type_is_basic if available.
2815 (xd_extract_signed, xd_extract_unsigned): Rename from
2816 extract_signed and extract_unsigned, respectively. Adapt callers.
2817
44286096
CY
28182012-06-09 Chong Yidong <cyd@gnu.org>
2819
1682701f
CY
2820 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2821
44286096
CY
2822 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2823 case (Bug#9752).
2824
d86feb17
PE
28252012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2826
2827 * xdisp.c (vmessage): Treat frame message as multibyte.
2828 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2829 would generate the diagnostic "Making \302\247 buffer-local while
2830 let-bound!".
2831
d5c20fe8
EZ
28322012-06-08 Eli Zaretskii <eliz@gnu.org>
2833
2834 * dispnew.c (showing_window_margins_p): Undo last change, which
2835 was done due to an inadvertent commit.
2836 (adjust_frame_glyphs_for_frame_redisplay): Do call
2837 showing_window_margins_p.
2838
513749ee
SM
28392012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2840
2841 * eval.c (Fmake_var_non_special): New primitive.
2842 (syms_of_eval): Defsubr it.
2843 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2844
d4a8f5c1
JB
28452012-06-08 Juanma Barranquero <lekktu@gmail.com>
2846
2847 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2848 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2849
8bbbc977
EZ
28502012-06-08 Eli Zaretskii <eliz@gnu.org>
2851
2852 * alloc.c (allocate_vectorlike): Fix last change.
2853
f3372c87
DA
28542012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2855
2856 Block-based vector allocation of small vectors.
2857 * lisp.h (struct vectorlike_header): New field `nbytes',
2858 adjust comment accordingly.
2859 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2860 to denote vector blocks. Adjust users (live_vector_p,
2861 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2862 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2863 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2864 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2865 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2866 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2867 (roundup_size): New constant.
2868 (struct vector_block): New data type.
2869 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2870 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2871 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2872 (sweep_vectors): New functions.
2873 (allocate_vectorlike): Return `zero_vector' as the only vector of
2874 0 items. Allocate new vector from block if vector size is less than
2875 or equal to VBLOCK_BYTES_MAX.
2876 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2877 (init_alloc_once): Add call to init_vectors.
2878
4f18a4ed
SM
28792012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2880
2881 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2882
86f158bc
PE
28832012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2884
2885 * doprnt.c (doprnt): Truncate multibyte char correctly.
2886 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2887 would mishandle a string argument "Xc" if X was a multibyte
2888 character of length 2: it would truncate after X's first byte
2889 rather than including all of X.
2890
c5cfcbe0
CY
28912012-06-06 Chong Yidong <cyd@gnu.org>
2892
2893 * buffer.c (word_wrap): Doc fix.
2894
c05cf390
PE
28952012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2896
2897 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2898
0c3461de
GM
28992012-06-03 Glenn Morris <rgm@gnu.org>
2900
2901 * xdisp.c (tool-bar-style): Doc fix.
2902
c71232db
UM
29032012-06-03 Ulrich Müller <ulm@gentoo.org>
2904
2905 * Makefile.in (PAXCTL): Define.
2906 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2907 binary via PaX flags if the paxctl utility is available.
2908 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2909 Restore PaX flags to their default. (Bug#11398)
2910
383f7350
CY
29112012-06-03 Chong Yidong <cyd@gnu.org>
2912
2913 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2914 buffer (Bug#11226).
2915
5f2c76c6
CY
29162012-06-03 Chong Yidong <cyd@gnu.org>
2917
2918 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2919 (note_mode_line_or_margin_highlight): If there is no help echo,
2920 use mode-line-default-help-echo. Handle the case where the mouse
2921 position is past the end of the mode line string.
2922
2923 * buffer.c (buffer_local_value_1): New function, split from
2924 Fbuffer_local_value; can return Qunbound.
2925 (Fbuffer_local_value): Use it.
2926 (Vmode_line_format): Docstring tweaks.
2927
773d47f6
PE
29282012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2929
2930 * sysdep.c (system_process_attributes): Improve comment.
2931
f2d6a3df
SM
29322012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2933
2934 * keyboard.c: Export real-this-command to Elisp.
2935 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2936 and DEFVAR it. Update all users.
2937
63810350
PE
29382012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2939
7bd5c1f4
PE
2940 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2941
63810350
PE
2942 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2943 Convert pctcpu and pctmem to Lisp float properly.
2944 Let the compiler fold better, as 100.0/0x8000 is exact.
2945
a2821611
AS
29462012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2947
2948 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2949 cons_block.
2950
5fceba1d
PE
29512012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2952
2953 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2954
c98ff5dd
DA
29552012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2956
2957 For a 'struct window', replace some Lisp_Object fields to
2958 bitfields where appropriate, remove unused fields.
2959 * window.h (struct window): Remove unused 'last_mark_x' and
2960 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2961 change it's type from Lisp_Object to bitfield.
2962 Change type of 'force_start', 'optional_new_start',
2963 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2964 fields from Lisp_Object to bitfield. Adjust users accordingly.
2965
ca34e0be
PE
29662012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2967
2968 Pacify gcc -Wdouble-precision when using Xaw.
2969 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2970 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2971 Use 'float' consistently, rather than 'float' in most places
2972 and 'double' in a couple of places.
2973
efc00ab1 29742012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2975
2976 * xdisp.c (handle_stop): Detect whether we have overlay strings
2977 loaded by testing it->current.overlay_string_index to be
2978 non-negative, instead of checking whether n_overlay_strings is
2979 positive. (Bug#11587)
2980
efc00ab1 29812012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2982
2983 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2984
2985 * doc.c (Fsubstitute_command_keys): Doc fix.
2986
efc00ab1 29872012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2988
2989 * search.c (search_buffer): Remove calls to
2990 r_alloc_inhibit_buffer_relocation, as it is now called by
2991 maybe_unify_char, which was the cause of relocation of buffer text
2992 in bug#11519.
2993
efc00ab1 29942012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2995
2996 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2997 for the duration of call to load_charset, to avoid problems with
2998 callers of maybe_unify_char that access buffer text through C
2999 pointers.
3000
3001 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3002 decrement the inhibition flag, instead of just setting or
3003 resetting it.
3004
ba93a187
PE
30052012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3006
3007 Remove obsolete '#define static' cruft.
3008 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3009 This #undef was "temporary" in 2000; it is no longer needed
3010 now that '#define static' has gone away.
3011 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3012 (gray_bitmap_bits): Remove; no longer needed.
3013 All uses replaced with definiens.
3014 * xterm.c: Include "bitmaps/gray.xbm".
3015
9e4bf381
PE
30162012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3017
3018 Clean up __executable_start, monstartup when --enable-profiling.
3019 The following changes affect the code only when profiling.
3020 * dispnew.c (__executable_start): Rename from safe_bcopy.
3021 Define only on platforms that need it.
3022 * emacs.c: Include <sys/gmon.h> when profiling.
3023 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3024 (__executable_start): Remove decl, since lisp.h does it now.
3025 (safe_bcopy): Remove decl; no longer has that name.
3026 (main): Coalesce #if into single bit of code, for simplicity.
3027 Cast pointers to uintptr_t, since standard libraries want integers
3028 and not pointers.
3029 * lisp.h (__executable_start): New decl.
3030
32d72c2f
GM
30312012-05-31 Glenn Morris <rgm@gnu.org>
3032
3033 * image.c (Fimagemagick_types): Doc fix.
3034
baac5bc7
JM
30352012-05-30 Jim Meyering <meyering@redhat.com>
3036
3037 * callproc.c (Fcall_process_region): Include directory component
3038 in mkstemp error message (Bug#11586).
3039
72cb32cf
PE
30402012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3041
3042 * alloc.c, lisp.h (make_pure_vector): Now static.
3043
61b108cc
SM
30442012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3045
3046 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3047 Move to byte-run.el.
3048 (Fautoload): Do the hash-doc more carefully.
3049 * data.c (Fdefalias): Purify definition, except for keymaps.
3050 (Qdefun): Move from eval.c.
3051 * lisp.h (Qdefun): Remove.
3052 * lread.c (read1): Tiny simplification.
3053
471fe23d
TN
30542012-05-29 Troels Nielsen <bn.troels@gmail.com>
3055
934f3f58 3056 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3057 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3058 Bug#9642, but explicitly check that the buffer the overlay would
3059 be moved to is live and rearrange lines to make sure that errors
3060 will not put the overlay in an inconsistent state.
3061 (Fdelete_overlay): Cosmetics.
3062
85d0efd1
EZ
30632012-05-28 Eli Zaretskii <eliz@gnu.org>
3064
3065 * w32term.c (my_bring_window_to_top): New function.
3066 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3067 could be different from the original one.
3068 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3069 (Bug#11513)
3070
3071 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3072 by calling BringWindowToTop.
3073
3074 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3075 (WM_EMACS_END): Increase by one.
3076
da92a98c
PE
30772012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3078
3079 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3080 This avoids undefined behavior that might cause the eassert
3081 to not catch an out-of-range value.
3082
74d1f848
JB
30832012-05-28 Juanma Barranquero <lekktu@gmail.com>
3084
3085 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3086 Update dependencies.
3087
9e1a06fc
EZ
30882012-05-27 Eli Zaretskii <eliz@gnu.org>
3089
3090 * bidi.c (bidi_mirror_char): Fix last change.
3091
f3dd7312
AS
30922012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3093
3094 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3095 when referring to sectname field in printf format.
3096
81899c91
PE
30972012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3098
57b81a9f
PE
3099 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3100 Only r_alloc_inhibit_buffer_relocation needed to be added;
3101 the others were already declared.
3102
81899c91
PE
3103 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3104 before checking whether it's out of range. Put the check inside
3105 eassert. See
3106 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3107
33017faf 31082012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3109
3110 * callproc.c (Fcall_process): Restore a line that was accidentally
3111 commented out in the 2011-02-13 change (bug#11547).
3112
33017faf 31132012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3114
3115 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3116 defined on ralloc.c.
3117
3118 * buffer.c [REL_ALLOC]: Remove prototypes of
3119 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3120 they are now on lisp.h.
3121
3122 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3123
3124 * search.c (search_buffer): Use it to inhibit relocation of buffer
3125 text while re_search_2 is doing its job, because re_search_2 is
3126 passed C pointers to buffer text. (Bug#11519)
3127
23415acf
EZ
3128 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3129 Update value to 24.
3130
44e27368
EZ
3131 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3132 state after an additional call to move_it_in_display_line_to, keep
3133 the values of it->max_ascent and it->max_descent found for the
3134 entire line.
3135 (pos_visible_p): Revert the comparison against bottom_y to what it
3136 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3137 (Bug#11464)
3138
c1892f11
PE
31392012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3140
3141 Fix coding-related core dumps with gcc -ftrapv.
3142 The code was computing A - B, where A and B are pointers, and B is
3143 random garbage. This can lead to core dumps on platforms that
3144 have special pointer registers, and it also leads to core dumps on
3145 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3146 A - B only when B is initialized properly.
3147 * coding.c (coding_set_source, coding_set_destination): Return void.
3148 (coding_change_source, coding_change_destinations): New functions,
3149 with the old behaviors of coding_set_source and coding_set_destination.
3150 All callers that need an offset changed to use these new functions.
3151
eb7afdad
GM
31522012-05-26 Glenn Morris <rgm@gnu.org>
3153
3154 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3155
f12fdf02
EZ
31562012-05-26 Eli Zaretskii <eliz@gnu.org>
3157
53a63be6 3158 Extend mouse support on W32 text-mode console.
61b108cc
SM
3159 * xdisp.c (draw_row_with_mouse_face):
3160 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3161
eb3f6f01 3162 * w32console.c: Include window.h.
61b108cc
SM
3163 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3164 New functions.
eb3f6f01
EZ
3165 (initialize_w32_display): Initialize mouse-highlight data.
3166
53a63be6
EZ
3167 * w32inevt.c: Include termchar.h and window.h.
3168 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3169 moves, call note_mouse_highlight. If help_echo changed, call
3170 gen_help_event to produce help-echo message in the echo area.
3171 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3172 highlight info.
3173
4cfd81f6
PE
31742012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3175
3176 * lread.c (read1): Simplify slightly to avoid an overflow warning
3177 with GCC 4.7.0 on x86-64.
3178
4446092a
EZ
31792012-05-26 Eli Zaretskii <eliz@gnu.org>
3180
3181 * bidi.c (bidi_mirror_char): Revert last change: an int is
3182 definitely wide enough here.
3183
42b2a986 31842012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3185
42b2a986 3186 Fix integer width and related bugs (Bug#9874).
eb106a49 3187 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3188 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3189 (string_bytes, check_sblock, allocate_string_data):
3190 (compact_small_strings, Fmake_bool_vector, make_string)
3191 (make_unibyte_string, make_multibyte_string)
3192 (make_string_from_bytes, make_specified_string)
3193 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3194 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3195 (mark_vectorlike):
3196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3197 (allocate_pseudovector):
3198 Use int, not EMACS_INT, where int is wide enough.
3199 (inhibit_garbage_collection, Fgarbage_collect):
3200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3201 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3202 int might not be wide enough.
3203 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3204 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3205 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3206 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3207 (bidi_level_of_next_char, bidi_move_to_visually_next):
3208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3209 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3210 (Fkill_buffer, Fset_buffer_major_mode)
3211 (advance_to_char_boundary, Fbuffer_swap_text)
3212 (Fset_buffer_multibyte, overlays_at, overlays_in)
3213 (overlay_touches_p, struct sortvec, record_overlay_string)
3214 (overlay_strings, recenter_overlay_lists)
3215 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3216 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3217 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3218 (Foverlay_recenter, last_overlay_modification_hooks_used)
3219 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3220 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3221 (validate_region): Omit unnecessary test for b <= e,
3222 since that's guaranteed by the previous test.
d311d28c
PE
3223 (adjust_overlays_for_delete): Avoid pos + length overflow.
3224 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3225 (report_overlay_modification):
3226 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3227 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3228 Omit pointer cast, which isn't needed anyway, and doesn't work
3229 after the EMACS_INT -> ptrdiff_t change.
02481186 3230 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3231 * buffer.h: Adjust decls to match defn changes elsewhere.
3232 (struct buffer_text, struct buffer):
3233 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3234 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3235 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3236 not int, to avoid needless 32-bit limit on 64-bit hosts.
3237 (exec_byte_code): Use tighter memory-full test, one that checks
3238 for alloca overflow. Don't compute the address of the object just
3239 before an array, as that's not portable. Use EMACS_INT, not
3240 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3241 * callint.c (Fcall_interactively):
3242 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3243 * callproc.c (call_process_kill, Fcall_process):
3244 Don't assume pid_t fits into an Emacs fixnum.
3245 (call_process_cleanup, Fcall_process, child_setup):
3246 Don't assume pid_t fits into int.
3247 (call_process_cleanup, Fcall_process, delete_temp_file)
3248 (Fcall_process_region):
3249 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3250 (Fcall_process): Simplify handling of volatile integers.
3251 Use int, not EMACS_INT, where int will do.
3252 * casefiddle.c (casify_object, casify_region, operate_on_word)
3253 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3254 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3255 (casify_object): Avoid integer overflow when overallocating buffer.
3256 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3257 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3258 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3259 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3260 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3261 integers are now checked earlier. All uses replaced with XINT.
3262 (ccl_driver):
3263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3264 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3265 (ccl_driver, Fregister_code_conversion_map):
3266 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3267 (resolve_symbol_ccl_program): Check that vector header is in range.
3268 Always copy the vector, so that we can check its contents reliably
3269 now rather than having to recheck each instruction as it's being
3270 executed. Check that vector words fit in 'int'.
3271 (ccl_get_compiled_code, Fregister_ccl_program)
3272 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3273 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3274 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3275 contents are in range.
3276 (Fccl_execute_on_string): Check that status is in range.
3277 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3278 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3279 Accept and return EMACS_INT, not int, because callers can pass values
3280 out of 'int' range.
3281 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3282 (multibyte_chars_in_text, parse_str_as_multibyte)
3283 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3284 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3285 (string_escape_byte8, Fget_byte):
3286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3287 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3288 avoid mishandling large integers.
3289 * character.h: Adjust decls to match defn changes elsewhere.
3290 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3291 (Ffind_charset_region):
3292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3293 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3294 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3295 Don't assume fixnum fits in int.
d311d28c
PE
3296 (load_charset_map_from_vector, Fmap_charset_chars):
3297 Remove now-unnecessary CHECK_NATNUMs.
3298 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3299 Don't rely on undefined behavior with signed left shift overflow.
3300 Don't assume unsigned int fits into fixnum, or that fixnum fits
3301 into unsigned int. Don't require max_code to be a valid fixnum;
3302 that's not true for gb10830 4-byte on a 32-bit host. Allow
3303 invalid_code to be a cons, for the same reason. Require code_offset
3304 to be a character. Avoid int overflow if max_char is close
3305 to INT_MAX.
3306 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3307 this is intended anyway and avoids some undefined behavior.
3308 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3309 INDEX_TO_CODE_POINT, as that's what it expects.
3310 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3311 * charset.h (DECODE_CHAR): Return int, not unsigned;
3312 this is what was intended anyway, and it avoids undefined behavior.
3313 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3314 integer-overflow issues.
3315 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3316 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3317 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3318 * chartab.c (Fmake_char_table, Fset_char_table_range)
3319 (uniprop_get_decoder, uniprop_get_encoder):
3320 Don't assume fixnum fits in int.
3321 * cmds.c (move_point): New function, that does the gist of
3322 Fforward_char and Fbackward_char, but does so while checking
3323 for integer overflow more accurately.
c96e5d6a 3324 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3325 (Fforward_line, Fend_of_line, internal_self_insert)
3326 (internal_self_insert):
3327 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3328 Fix a FIXME, by checking for integer overflow when calculating
3329 target_clm and actual_clm.
3330 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3331 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3332 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3333 (coding_alloc_by_making_gap, alloc_destination)
3334 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3335 (encode_coding_utf_16, detect_coding_emacs_mule)
3336 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3337 (detect_coding_iso_2022, decode_coding_iso_2022)
3338 (encode_invocation_designation, encode_designation_at_bol)
3339 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3340 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3341 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3342 (encode_coding_ccl, encode_coding_raw_text)
3343 (detect_coding_charset, decode_coding_charset)
3344 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3345 (produce_composition, produce_charset, produce_annotation)
3346 (decode_coding, handle_composition_annotation)
3347 (handle_charset_annotation, consume_chars, decode_coding_gap)
3348 (decode_coding_object, encode_coding_object, detect_coding_system)
3349 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3350 (code_convert_region, code_convert_string)
8f50130c
PE
3351 (Fdefine_coding_system_internal)
3352 (coding_set_source, coding_set_destination):
d311d28c
PE
3353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3354 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3355 (Fdefine_coding_system_internal):
3356 Don't assume fixnums fit in int.
3357 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3358 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3359 (Funencodable_char_position, Fcheck_coding_systems_region)
3360 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3361 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3362 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3363 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3364 Don't access memory outside of the args array.
d311d28c 3365 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3366 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3367 result of ENCODE_CHAR.
d311d28c
PE
3368 * coding.h: Adjust decls to match defn changes elsewhere.
3369 (struct coding_system):
3370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3371 * composite.c (get_composition_id, find_composition)
3372 (run_composition_function, update_compositions)
3373 (compose_text, composition_gstring_put_cache)
3374 (composition_gstring_p, composition_gstring_width)
3375 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3376 (composition_compute_stop_pos, composition_reseat_it)
3377 (composition_update_it, struct position_record)
3378 (find_automatic_composition, composition_adjust_point)
3379 (Fcomposition_get_gstring, Ffind_composition_internal):
3380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3381 (update_compositions):
3382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3383 * composite.h: Adjust decls to match defn changes elsewhere.
3384 (struct composition):
3385 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3386 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3387 Do not attempt to compute the address of the object just before a
3388 buffer; this is not portable.
3389 (Faref, Faset):
3390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3391 (Faset): Use int, not EMACS_INT, where int is wide enough.
3392 (Fstring_to_number): Don't assume fixnums fit in int.
3393 (Frem): Don't assume arg is nonnegative.
3394 * dbusbind.c (xd_append_arg): Check for integers out of range.
3395 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3396 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3397 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3398 (xd_get_connection_references): Return ptrdiff_t, not int.
3399 All uses changed.
3400 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3401 (xd_read_message_1):
3402 Use int, not unsigned, where the dbus API uses int.
3403 (Fdbus_message_internal): Don't overflow mtype.
3404 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3405 * dired.c (directory_files_internal, file_name_completion, scmp)
3406 (file_name_completion_stat):
3407 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3408 (file_name_completion): Don't overflow matchcount.
3409 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3410 * dispextern.h: Adjust decls to match defn changes elsewhere.
3411 (struct text_pos, struct glyph, struct bidi_saved_info)
3412 (struct bidi_string_data, struct bidi_it, struct composition_it)
3413 (struct it):
3414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3415 (struct display_pos, struct composition_it, struct it):
3416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3417 * dispnew.c (increment_matrix_positions)
3418 (increment_row_positions, mode_line_string)
3419 (marginal_area_string):
3420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3421 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3423 (duration_to_sec_usec): New function, to check for overflow better.
3424 (Fsleep_for, sit_for): Use it.
3425 * doc.c (get_doc_string, store_function_docstring):
3426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3427 (get_doc_string, Fsnarf_documentation):
3428 Use int, not EMACS_INT, where int is wide enough.
3429 (get_doc_string):
3430 Use SAFE_ALLOCA, not alloca.
3431 Check for overflow when converting EMACS_INT to off_t.
3432 * doprnt.c (doprnt):
3433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3434 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3435 Don't assume uid_t fits into fixnum.
3436 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3437 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3438 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3439 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3440 (general_insert_function)
3441 (Finsert_char, make_buffer_string, make_buffer_string_both)
3442 (update_buffer_properties, Fbuffer_substring)
3443 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3444 (Fsubst_char_in_region, check_translation)
3445 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3446 (transpose_markers, Ftranspose_regions):
3447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3448 (clip_to_bounds): Move to lisp.h as an inline function).
3449 (Fconstrain_to_field): Don't assume integers are nonnegative.
3450 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3451 (Fsubst_char_in_region, Fsave_restriction):
3452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3453 (Femacs_pid): Don't assume pid_t fits into fixnum.
3454 (lo_time): Use int, not EMACS_INT, when int suffices.
3455 (lisp_time_argument): Check for usec out of range.
3456 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3457 (Fuser_login_name, Fuser_full_name): Signal an error
3458 if a uid argument is out of range, rather than relying on
3459 undefined behavior.
c8d5c857
PE
3460 (Fformat_time_string): Remove now-unnecessary check.
3461 lisp_time_argument checks for out-of-range usec now.
243e0530 3462 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3463 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3464 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3465 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3466 (init_cmdargs, Fdump_emacs):
3467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3468 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3469 the bottom (typically) 32 bits of the fixnum.
3470 * eval.c (specpdl_size, call_debugger):
3471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3472 (when_entered_debugger, Fbacktrace_debug):
3473 Don't assume fixnum can fit in int.
3474 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3475 the object just before a buffer; this is not portable.
3476 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3477 (grow_specpdl, unbind_to):
3478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3479 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3480 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3481 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3482 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3483 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3484 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3485 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3486 (a_write, e_write):
3487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3488 (Fcopy_file, non_regular_nbytes, read_non_regular)
3489 (Finsert_file_contents):
3490 Use int, not EMACS_INT, where int is wide enough.
3491 (READ_BUF_SIZE): Verify that it fits in int.
3492 (Finsert_file_contents): Check that counts are in proper range,
3493 rather than assuming fixnums fit into ptrdiff_t etc.
3494 Don't assume fixnums fit into int.
125b3835 3495 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3496 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3497 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3498 (string_char_to_byte, string_byte_to_char)
3499 (string_make_multibyte, string_to_multibyte)
3500 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3501 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3502 (substring_both, Fdelete, internal_equal, Ffillarray)
3503 (Fclear_string, mapcar1)
3504 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3505 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3506 (larger_vector, make_hash_table, maybe_resize_hash_table)
3507 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3508 (Fmaphash, secure_hash):
3509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3510 (concat): Check for string index and length overflow.
3511 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3512 (Frequire):
3513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3514 (larger_vector): New API (vec, incr_min, size_max) replaces old
3515 one (vec, new_size, init). This catches size overflow.
3516 INIT was removed because it was always Qnil.
3517 All callers changed.
3518 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3519 the upper bound on a hash table index size.
3520 (make_hash_table, maybe_resize_hash_table): Use it.
3521 (secure_hash): Computer start_byte and end_byte only after
3522 they're known to be in ptrdiff_t range.
3523 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3524 (Ffont_get_glyphs, Ffont_at):
3525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3526 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3527 (Flist_fonts, Fopen_font):
3528 Don't assume fixnum can fit in int.
3529 (check_gstring): Don't assume index can fit in int.
3530 (font_match_p): Check that fixnum is a character, not a nonnegative
3531 fixnum, since the later code needs to stuff it into an int.
3532 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3533 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3534 conversion overflow issues.
3535 (Fopen_font): Check for integer out of range.
3536 (Ffont_get_glyphs): Don't assume index can fit in int.
3537 * font.h: Adjust decls to match defn changes elsewhere.
3538 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3539 integer overflow.
3540 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3541 printmax_t, where ptrdiff_t is wide enough.
3542 (Finternal_char_font):
3543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3544 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3545 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3546 (Fset_frame_position, x_set_frame_parameters)
3547 (x_set_line_spacing, x_set_border_width)
3548 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3549 Check that fixnums are in proper range for system types.
3550 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3552 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3553 Use SAFE_ALLOCA_LISP, not alloca.
3554 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3555 intptr_t is wide enough.
3556 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3557 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3558 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3559 Check for fixnum out of range.
3560 * ftfont.c (ftfont_list): Don't assume index fits in int.
3561 Check that fixnums are in proper range for system types.
3562 (ftfont_shape_by_flt):
3563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3564 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3566 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3567 Check that fixnums are in proper range for system types.
3568 * gnutls.h: Adjust decls to match defn changes elsewhere.
3569 * gtkutil.c (xg_dialog_run):
3570 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3571 (update_frame_tool_bar):
3572 Check that fixnums are in proper range for system types.
3573 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3574 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3575 * indent.c (last_known_column, last_known_column_point):
3576 (current_column_bol_cache):
3577 (skip_invisible, current_column, check_display_width):
3578 (check_display_width, scan_for_column, current_column_1)
3579 (Findent_to, Fcurrent_indentation, position_indentation)
3580 (indented_beyond_p, Fmove_to_column, compute_motion):
3581 (Fcompute_motion, Fvertical_motion):
3582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3583 (last_known_column_modified): Use EMACS_INT, not int.
3584 (check_display_width):
3585 (Fcompute_motion):
3586 Check that fixnums and floats are in proper range for system types.
3587 (compute_motion): Don't assume index or fixnum fits in int.
3588 (compute_motion, Fcompute_motion):
3589 Use int, not EMACS_INT, when it is wide enough.
3590 (vmotion): Omit local var start_hpos that is always 0; that way
3591 we don't need to worry about overflow in expressions involving it.
3592 * indent.h: Adjust decls to match defn changes elsewhere.
3593 (struct position):
3594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3595 Use int, not EMACS_INT, where int is wide enough.
3596 Remove unused members ovstring_chars_done and tab_offset;
3597 all uses removed.
3598 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3599 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3600 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3601 (make_gap, copy_text, insert, insert_and_inherit)
3602 (insert_before_markers, insert_before_markers_and_inherit)
3603 (insert_1, count_combining_before, count_combining_after)
3604 (insert_1_both, insert_from_string)
3605 (insert_from_string_before_markers, insert_from_string_1)
3606 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3607 (adjust_after_replace, adjust_after_insert, replace_range)
3608 (replace_range_2, del_range, del_range_1, del_range_byte)
3609 (del_range_both, del_range_2, modify_region)
3610 (prepare_to_modify_buffer, signal_before_change)
3611 (signal_after_change, Fcombine_after_change_execute):
3612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3613 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3614 (balance_an_interval, split_interval_right, split_interval_left)
3615 (find_interval, next_interval, update_interval)
3616 (adjust_intervals_for_insertion, delete_node, delete_interval)
3617 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3618 (static_offset_intervals, offset_intervals)
3619 (merge_interval_right, merge_interval_left, make_new_interval)
3620 (graft_intervals_into_buffer, temp_set_point_both)
3621 (temp_set_point, set_point, adjust_for_invis_intang)
3622 (set_point_both, move_if_not_intangible, get_property_and_range)
3623 (get_local_map, copy_intervals, copy_intervals_to_string)
3624 (compare_string_intervals, set_intervals_multibyte_1):
3625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3626 * intervals.h: Adjust decls to match defn changes elsewhere.
3627 (struct interval):
3628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3629 * keyboard.c (this_command_key_count, this_single_command_key_start)
3630 (before_command_key_count, before_command_echo_length, echo_now)
3631 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3632 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3633 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3634 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3635 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3636 (last_non_minibuf_size, last_point_position, echo_truncate)
3637 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3638 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3639 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3640 (stuff_buffered_input):
3641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3642 (last_auto_save, command_loop_1, read_char):
3643 Use EMACS_INT, not int, to avoid integer overflow.
3644 (record_char): Avoid overflow in total_keys computation.
3645 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3646 * keyboard.h: Adjust decls to match defn changes elsewhere.
3647 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3648 (Fkey_description, Fdescribe_vector, Flookup_key):
3649 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3650 (click_position): New function, to check that positions are in range.
3651 (Fcurrent_active_maps):
3652 (describe_command):
3653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3654 (Faccessible_keymaps, Fkey_description):
3655 (preferred_sequence_p):
3656 Don't assume fixnum can fit into int.
3657 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3658 Check for integer overflow in size calculations.
3659 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3660 avoid mishandling large integers.
3661 * lisp.h: Adjust decls to match defn changes elsewhere.
3662 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3663 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3664 (struct Lisp_Marker):
3665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3666 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3667 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3668 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3669 All callers changed.
3670 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3671 Assume the arg has valid form, since it always does.
3672 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3673 unsigned integer system type.
3674 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3675 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3677 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3678 (duration_to_sec_usec): New decl.
3679 * lread.c (read_from_string_index, read_from_string_index_byte)
3680 (read_from_string_limit, readchar, unreadchar, openp)
3681 (read_internal_start, read1, oblookup):
3682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3683 (Fload, readevalloop, Feval_buffer, Feval_region):
3684 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3685 (openp): Check for out-of-range argument to 'access'.
3686 (read1): Use int, not EMACS_INT, where int is wide enough.
3687 Don't assume fixnum fits into int.
6efdadfd 3688 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3689 (read_filtered_event): Use duration_to_sec_usec
3690 to do proper overflow checking on durations.
d311d28c
PE
3691 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3692 in size calculation.
3693 (Fexecute_kbd_macro):
3694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3695 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3696 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3697 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3698 (set_marker_both, set_marker_restricted_both, marker_position)
3699 (marker_byte_position, Fbuffer_has_markers_at):
3700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3701 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3702 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3703 It now merely ensures that the menu is large enough, without
3704 necessarily growing it, as this avoids some integer overflow issues.
3705 All callers changed.
3706 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3707 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3708 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3709 Use SAFE_ALLOCA_LISP, not alloca.
3710 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3711 to EMACS_INT. Check that fixnums are in proper range for system types.
3712 * minibuf.c (minibuf_prompt_width, string_to_object)
3713 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3714 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3716 (get_minibuffer, read_minibuf_unwind):
3717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3718 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3719 this simplifies overflow checking. All callers changed.
3720 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3721 (Ftest_completion):
3722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3723 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3724 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3725 Check that fixnums are in proper range for system types.
3726 (Fx_create_frame, Fx_show_tip):
3727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3728 * nsfont.m (ns_findfonts, nsfont_list_family):
3729 Don't assume fixnum fits in long.
3730 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3731 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3732 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3733 wide enough.
17fdb222 3734 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3735 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3736 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3737 (PRINTDECLARE, PRINTPREPARE):
3738 (strout, print_string):
3739 (print, print_preprocess, print_check_string_charset_prop)
3740 (print_object):
3741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3742 (PRINTDECLARE):
3743 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3744 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3745 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3746 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3747 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3748 (print_error_message): Use SAFE_ALLOCA, not alloca.
3749 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3750 (print_depth, new_backquote_output, print_number_index):
3751 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3752 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3753 (Fset_process_window_size, Fformat_network_address)
3754 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3755 (sigchld_handler):
d311d28c 3756 Check that fixnums are in proper range for system types.
d44287d4 3757 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3758 Check for process-ids out of pid_t range rather than relying on
3759 undefined behavior.
e4d81efc 3760 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3761 (Fformat_network_address, read_process_output, send_process)
3762 (Fprocess_send_region, status_notify):
3763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3764 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3765 (wait_reading_process_output, read_process_output, exec_sentinel):
3766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3767 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3768 (Faccept_process_output): Use duration_to_sec_usec to do proper
3769 overflow checking on durations.
dde14581
PE
3770 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3771 Don't assume pid_t fits in int.
02481186
PE
3772 * process.h (struct Lisp_Process): Members tick and update_tick
3773 are now of type EMACS_INT, not int.
b62b53e8
PE
3774 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3775 configured --with-wide-int.
d311d28c
PE
3776 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3777 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3778 * search.c (looking_at_1, string_match_1):
3779 (fast_string_match, fast_c_string_match_ignore_case)
3780 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3781 (scan_newline, find_before_next_newline, search_command)
3782 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3783 (set_search_regs, wordify):
3784 (Freplace_match):
3785 (Fmatch_data):
3786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3787 (string_match_1, search_buffer, set_search_regs):
3788 (Fmatch_data):
3789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3790 (wordify): Check for overflow in size calculation.
3791 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3792 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3793 Check that fixnums are in proper range for system types.
3794 * sound.c (struct sound_device)
3795 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3796 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3797 (Fplay_sound_internal):
3798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3799 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3800 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3801 (Fparse_partial_sexp):
3802 Don't assume fixnums can fit in int.
3803 (struct lisp_parse_state, find_start_pos, find_start_value)
3804 (find_start_value_byte, find_start_begv)
3805 (update_syntax_table, char_quoted, dec_bytepos)
3806 (find_defun_start, prev_char_comend_first, back_comment):
3807 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3808 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3810 (Finternal_describe_syntax_value): Check that match_lisp is a
3811 character, not an integer, since the code stuffs it into int.
3812 (scan_words, scan_sexps_forward):
3813 Check that fixnums are in proper range for system types.
3814 (Fforward_word):
3815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3816 (scan_sexps_forward):
3817 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3818 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3819 * syntax.h: Adjust decls to match defn changes elsewhere.
3820 (struct gl_state_s):
3821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3822 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3823 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3824 * sysdep.c (wait_for_termination_1, wait_for_termination)
3825 (interruptible_wait_for_termination, mkdir):
3826 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3827 (emacs_read, emacs_write):
3828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3829 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3830 and double all fit in int.
d311d28c
PE
3831 * term.c (set_tty_color_mode):
3832 Check that fixnums are in proper range for system types.
3833 * termhooks.h (struct input_event):
3834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3835 * textprop.c (validate_interval_range, interval_of)
3836 (Fadd_text_properties, set_text_properties_1)
3837 (Fremove_text_properties, Fremove_list_of_text_properties)
3838 (Ftext_property_any, Ftext_property_not_all)
3839 (copy_text_properties, text_property_list, extend_property_ranges)
3840 (verify_interval_modification):
3841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3842 (Fnext_single_char_property_change)
3843 (Fprevious_single_char_property_change):
3844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3845 (copy_text_properties):
3846 Check for integer overflow in index calculation.
d311d28c
PE
3847 * undo.c (last_boundary_position, record_point, record_insert)
3848 (record_delete, record_marker_adjustment, record_change)
3849 (record_property_change):
3850 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3851 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3853 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3854 (Fx_hide_tip, Fx_file_dialog):
3855 * w32menu.c (set_frame_menubar):
3856 Use ptrdiff_t, not int, for consistency with rest of code.
3857 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3858 (select_window, Fdelete_other_windows_internal)
3859 (window_scroll_pixel_based, window_scroll_line_based)
3860 (Frecenter, Fset_window_configuration):
3861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3862 (Fset_window_hscroll, run_window_configuration_change_hook)
3863 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3864 (Fscroll_other_window, Frecenter):
d311d28c
PE
3865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3866 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3867 Don't assume fixnum fits in int.
3868 (Fset_window_scroll_bars):
3869 Check that fixnums are in proper range for system types.
3870 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3871 (string_pos, c_string_pos, number_of_chars, init_iterator)
3872 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3873 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3874 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3875 (face_before_or_after_it_pos, handle_invisible_prop)
3876 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3877 (display_prop_intangible_p, string_buffer_position_lim)
3878 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3879 (get_overlay_strings_1, get_overlay_strings)
3880 (iterate_out_of_display_property, forward_to_next_line_start)
3881 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3882 (get_next_display_element, set_iterator_to_next)
3883 (get_visually_first_element, compute_stop_pos_backwards)
3884 (handle_stop_backwards, next_element_from_buffer)
3885 (move_it_in_display_line_to, move_it_in_display_line)
3886 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3887 (add_to_log, message_dolog, message_log_check_duplicate)
3888 (message2, message2_nolog, message3, message3_nolog
3889 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3890 (current_message_1, truncate_echo_area, truncate_message_1)
3891 (set_message, set_message_1, store_mode_line_noprop)
3892 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3893 (text_outside_line_unchanged_p, check_point_in_composition)
3894 (reconsider_clip_changes)
3895 (redisplay_internal, set_cursor_from_row, try_scrolling)
3896 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3897 (redisplay_window, find_last_unchanged_at_beg_row)
3898 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3899 (trailing_whitespace_p, find_row_edges, display_line)
3900 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3901 (display_mode_element, store_mode_line_string)
3902 (pint2str, pint2hrstr, decode_mode_spec)
3903 (display_count_lines, display_string, draw_glyphs)
3904 (x_produce_glyphs, x_insert_glyphs)
3905 (rows_from_pos_range, mouse_face_from_buffer_pos)
3906 (fast_find_string_pos, mouse_face_from_string_pos)
3907 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3908 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3909 (safe_call, init_from_display_pos, handle_fontified_prop)
3910 (handle_single_display_spec, load_overlay_strings)
3911 (with_echo_area_buffer, setup_echo_area_for_printing)
3912 (display_echo_area, echo_area_display)
3913 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3914 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3915 (redisplay_window, dump_glyph_row, display_mode_line)
3916 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3917 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3918 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3919 (handle_single_display_spec, build_desired_tool_bar_string)
3920 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3921 (get_specified_cursor_type):
3922 Check that fixnums are in proper range for system types.
3923 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3924 (Flookup_image_map):
3925 Don't assume fixnums fit in int.
3926 (compare_overlay_entries):
3927 Avoid mishandling comparisons due to subtraction overflow.
3928 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3929 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3930 (handle_tool_bar_click):
3931 Use int, not unsigned, since we prefer signed and the signedness
3932 doesn't matter here.
3933 (get_next_display_element, next_element_from_display_vector):
3934 Use int, not EMACS_INT, when int is wide enough.
3935 (start_hourglass): Use duration_to_sec_usec to do proper
3936 overflow checking on durations.
3937 * xfaces.c (Fbitmap_spec_p):
3938 Check that fixnums are in proper range for system types.
3939 (compare_fonts_by_sort_order):
3940 Avoid mishandling comparisons due to subtraction overflow.
3941 (Fx_family_fonts, realize_basic_faces):
3942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3943 (Fx_family_fonts):
3944 Don't assume fixnum fits in int.
3945 Use SAFE_ALLOCA_LISP, not alloca.
3946 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3947 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3948 (face_at_buffer_position, face_for_overlay_string)
3949 (face_at_string_position):
3950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3951 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3952 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3953 (Fx_show_tip):
3954 Check that fixnums are in proper range for system types.
3955 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3956 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3958 (Fx_change_window_property): Don't assume fixnums fit in int.
3959 * xfont.c (xfont_chars_supported):
3960 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3961 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3962 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3964 * xml.c (parse_region):
3965 * xrdb.c (magic_file_p):
3966 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3967 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3968 (x_get_local_selection, x_reply_selection_request)
3969 (x_handle_selection_request, wait_for_property_change):
3970 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3971 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3972 short is wide enough.
3973 (x_send_client_event): Don't assume fixnum fits in int.
3974 * xterm.c (x_x_to_emacs_modifiers):
3975 Don't assume EMACS_INT overflows nicely into int.
3976 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3977 may come from Lisp.
3978 (handle_one_xevent): NATNUMP can eval its arg twice.
3979 (x_connection_closed):
3980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3981 * xterm.h: Adjust decls to match defn changes elsewhere.
3982 (struct scroll_bar): Use struct vectorlike_header
3983 rather than rolling our own approximation.
3984 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3985
c6574eb5
GM
39862012-05-25 Glenn Morris <rgm@gnu.org>
3987
3988 * lisp.mk (lisp): Update for more files being compiled now.
3989
e8d32c7e
SM
39902012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3991
48def666
SM
3992 * lread.c: Remove `read_pure' which makes no difference.
3993 (read_pure): Remove var.
3994 (unreadpure): Remove function.
3995 (readevalloop): Don't call read_list with -1 flag.
3996 (read1, read_vector): Don't test read_pure any more.
3997 (read_list): Simplify.
3998
e8d32c7e
SM
3999 * fileio.c, character.h: Minor style tweaks.
4000
4b2addb7
DA
40012012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4002
4003 * window.h (clip_changed): Remove useless declaration.
4004
584461b2
JB
40052012-05-22 Juanma Barranquero <lekktu@gmail.com>
4006
4007 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4008 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4009
34374650
PE
40102012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4011
4012 Remove src/m/*.
4013 This directory predates autoconf and is no longer needed nowadays.
4014 Move its few remaining bits of functionality to where they're needed.
4015 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4016 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4017 * m/template.h: Remove.
4018 * Makefile.in (M_FILE): Remove. All uses removed.
4019 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4020 * lisp.h (USE_LSB_TAG):
4021 * mem-limits.h (EXCEEDS_LISP_PTR):
4022 Use VAL_MAX, not VALBITS, in #if.
4023 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4024 (EMACS_UINT): Define unconditionally now.
4025 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4026 (BITS_PER_EMACS_INT): New constants, replacing
4027 what used to be in config.h, but not useful in #if.
4028 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4029 define them any more.
4030 (VAL_MAX): New macro.
4031 (VALMASK): Use it.
4032 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4033 BITS_PER_EMACS_INT, in #if.
4034 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4035 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4036 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4037 * s/ms-w32.h (DATA_START):
4038 Move here from removed file m/intel386.h.
4039 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4040 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4041
261cb4bb
PE
40422012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4043
4044 Assume C89 or later.
4045 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4046 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4047 (xrealloc):
4048 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4049 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4050 * textprop.c, tparam.c (NULL): Remove.
4051 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4052 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4053 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4054 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4055 * xterm.c (input_signal_count): Assume volatile works.
4056
ff23cd9f
KB
40572012-05-21 Ken Brown <kbrown@cornell.edu>
4058
4059 * xgselect.c (xg_select): Fix first argument in call to 'select'
4060 (bug#11508).
4061
1b170bc6
KB
40622012-05-20 Ken Brown <kbrown@cornell.edu>
4063
4064 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4065 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4066
b2f4d39f
KB
40672012-05-19 Ken Brown <kbrown@cornell.edu>
4068
4069 * xfns.c (x_in_use): Remove `static' qualifier.
4070 * xterm.h (x_in_use): Declare.
4071 * xgselect.c: Include xterm.h.
4072 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4073 and `display_arg' (bug#9754).
4074
003fdae2
PE
40752012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4076
9232a6d9
PE
4077 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4078
003fdae2
PE
4079 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4080 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4081
784b56e2
EZ
40822012-05-18 Eli Zaretskii <eliz@gnu.org>
4083
4084 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4085
4086 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4087 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4088
4089 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4090 reference to image_cache->refcount.
4091 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4092
a0a79cde
JL
40932012-05-17 Juri Linkov <juri@jurta.org>
4094
4095 * search.c (Fword_search_regexp, Fword_search_backward)
4096 (Fword_search_forward, Fword_search_backward_lax)
4097 (Fword_search_forward_lax): Move functions to isearch.el
4098 (bug#10145, bug#11381).
4099
b0572523
PE
41002012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4101
4102 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4103
9660f5fc
SM
41042012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4105
4106 * lread.c (init_obarray): Declare Qt and Qnil as special.
4107
4374de83
GM
41082012-05-14 Glenn Morris <rgm@gnu.org>
4109
4110 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4111 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4112
dc44c39a
PE
41132012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4114
078c97cb
PE
4115 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4116
dc44c39a
PE
4117 * unexaix.c: Port to more-recent AIX compilers.
4118 (report_error, report_error_1, make_hdr, copy_sym)
4119 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4120 Make arguments const char *, not char *, to avoid violations of C
4121 standard and to fix some AIX warnings reported by Gilles Pion.
4122
e18afed7 41232012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4124
4125 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4126 already have overlays loaded.
4127 (handle_single_display_spec): Before returning without displaying
4128 fringe bitmap, synchronize the bidi iterator with the main display
4129 iterator, by calling iterate_out_of_display_property.
4130 (iterate_out_of_display_property): Detect buffer iteration by
4131 testing that it->string is a Lisp string.
4132 (get_next_display_element): When the current object is exhausted,
4133 and there's something on it->stack, call set_iterator_to_next to
4134 proceed with what's on the stack, instead of returning zero.
4135 (set_iterator_to_next): If called at the end of a Lisp string,
4136 proceed to consider_string_end without incrementing string
4137 position. Don't increment display vector index past the end of
4138 the display vector. (Bug#11417)
c8fb9dc6
EZ
4139 (pos_visible_p): Don't report a position visible when move_it_to
4140 stopped at the last line of window, which happens to be scanned
4141 backwards by the bidi iteration. (Bug#11464)
ac268e67 4142
e18afed7 41432012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4144
4145 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4146 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4147 are on a TTY, and thus unable to display on the fringes.
4148 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4149 so we need to signal to the caller that this is a "replacing"
4150 display spec. This fixes display when the spec is invalid or we
4151 are on a TTY.
4152
e18afed7 41532012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4154
4155 * unexaix.c (make_hdr): Fix typo in prototype.
4156 This bug broke the build on AIX. Problem reported by Gilles Pion.
4157
9d0a235a
MA
41582012-05-14 Michael Albinus <michael.albinus@gmx.de>
4159
4160 * keyboard.c (kbd_buffer_get_event): Read special events also in
4161 batch mode. (Bug#11415)
4162
9e6b06ed
GM
41632012-05-12 Glenn Morris <rgm@gnu.org>
4164
4165 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4166
c1a1d7a3
EZ
41672012-05-12 Eli Zaretskii <eliz@gnu.org>
4168
4169 * lisp.mk (lisp): Add newcomment.elc.
4170
3fe7cdc8
GM
41712012-05-12 Glenn Morris <rgm@gnu.org>
4172
4173 * Makefile.in (MKDIR_P): New, set by configure.
4174 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4175
53f7d2c0
PE
41762012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4177
4178 Remove unused function hourglass_started.
4179 * dispextern.h (hourglass_started):
4180 * w32fns.c (hourglass_started):
4181 * xdisp.c (hourglass_started): Remove.
4182
75aafb17
JB
41832012-05-10 Juanma Barranquero <lekktu@gmail.com>
4184
4185 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4186 Update dependencies.
4187
12959e8e
PE
41882012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4189
97107e2e
PE
4190 * xgselect.c (xg_select): Put maxfds+1 into a var.
4191 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4192
12959e8e
PE
4193 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4194
836d29b3
DA
41952012-05-10 Dave Abrahams <dave@boostpro.com>
4196
4197 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4198 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4199
5cb67954
MA
42002012-05-09 Michael Albinus <michael.albinus@gmx.de>
4201
4202 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4203 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4204 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4205 Initialize xd_registered_buses.
4206
3478ec45
PE
42072012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4208
b263a6b0
PE
4209 Untag more efficiently if USE_LSB_TAG.
4210 This is based on a proposal by YAMAMOTO Mitsuharu in
4211 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4212 For an admittedly artificial (nth 8000 longlist) benchmark on
4213 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4214 Emacs's overall text size by 1%.
4215 * lisp.h (XUNTAG): New macro.
4216 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4217 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4218 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4219 * eval.c (Fautoload):
4220 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4221 * frame.h (XFRAME): Use XUNTAG.
4222
3478ec45
PE
4223 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4224 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4225 Remove unportable assumptions about print widths of types like
4226 dbus_uint32_t.
4227 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4228 intptr_t when converting between pointer and integer, to avoid GCC
4229 warnings about wrong width.
4230
666b903b 42312012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4232
4233 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4234 stack for each reader_thread, instead of defaulting to 8MB
4235 determined by the linker. This avoids failures in creating
4236 subprocesses on Windows 7, see the discussion in this thread:
4237 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4238
b120cc17
JC
42392012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4240
4241 Fix up display of the *Minibuf-0* buffer in the mini window.
4242 * keyboard.c (read_char): Don't clear the echo area if there's no
4243 message to clear.
4244 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4245 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4246
9a4b36f8
MA
42472012-05-07 Michael Albinus <michael.albinus@gmx.de>
4248
4249 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4250 batch mode.
4251
e5f9458f
CY
42522012-05-06 Chong Yidong <cyd@gnu.org>
4253
4254 * lisp.mk (lisp): Update.
4255
eceeb5fc 42562012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4257
4258 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4259
71873e2b
SM
42602012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4261
4262 * data.c (PUT_ERROR): New macro.
4263 (syms_of_data): Use it. Add new error type `user-error'.
4264 * undo.c (user_error): New function.
4265 (Fprimitive_undo): Use it.
4266 * print.c (print_error_message): Adjust print style for `user-error'.
4267 * keyboard.c (user_error): New function.
4268 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4269
ab0fa4e4
PE
42702012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4271
4272 Do not limit current-time-string to years 1000..9999.
4273 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4274 (Fcurrent_time_string): Support any year that is supported by the
4275 underlying localtime representation. Don't use asctime, as it
4276 has undefined behavior for years outside the range -999..9999.
4277
7ed806a7
PE
42782012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4279
4280 Fix race conditions involving setenv, gmtime, localtime, asctime.
4281 Without this fix, interrupts could mess up code that uses these
4282 nonreentrant functions, since setting TZ invalidates existing
4283 tm_zone or tzname values, and since most of these functions return
4284 pointers to static storage.
4285 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4286 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4287 Grow the critical sections to include not just invoking
4288 localtime/gmtime, but also accessing these functions' results
4289 including their tm_zone values if any, and any related TZ setting.
4290 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4291 so that the struct tm is saved in the critical section.
4292 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4293 motivated by the fact that memory allocation needs to be outside
4294 the critical section.
4295
0c16dfed
DA
42962012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4297
4298 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4299 with RESET_INTERVAL.
4300
4301 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4302 Remove duplicated buffer name initialization.
4303
3f83ace8
JM
43042012-05-02 Jim Meyering <jim@meyering.net>
4305
4306 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4307
c7b8541e
JM
4308 * xfns.c (x_window): Use xstrdup (Bug#11375).
4309
90207a15 43102012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4311
4312 * xdisp.c (pos_visible_p): If already at a newline from the
4313 display string before the 'while' loop, don't walk back the glyphs
4314 from it3.glyph_row. Solves assertion violation when the display
4315 string begins with a newline (egg.el). (Bug#11367)
4316
b593d6a9
AH
43172012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4318
4319 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4320 Move to simple.el.
4321
4737362e
GM
43222012-05-01 Glenn Morris <rgm@gnu.org>
4323
99cf43f9
GM
4324 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4325 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4326 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4327 All were removed before 23.1.
4328
9311dcff
GM
4329 * dispnew.c: Remove HAVE_LIBNCURSES test;
4330 it is always true on relevant platforms.
4331
4d5c6349
GM
4332 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4333 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4334
4737362e
GM
4335 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4336
74dd3a6b
AS
43372012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4338
4339 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4340 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4341 Remove.
4342
13c379ee
PE
43432012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4344
4345 Do not avoid creating empty evaporating overlays (Bug#9642).
4346 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4347 That is, do not delete an evaporating overlay if it becomes
4348 empty after its bounds are adjusted to fit within its buffer.
4349 This fix caused other problems, and I'm reverting it until we get
4350 to the bottom of them.
4351
a8e7d6d7 43522012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4353
4354 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4355
a8e7d6d7 43562012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4357
4358 * xdisp.c (pos_visible_p): If the window start position is beyond
4359 ZV, start the display from buffer beginning. Prevents assertion
4360 violation in init_iterator when the minibuffer window is scrolled
4361 via the scroll bar.
4362
4363 * window.c (window_scroll_pixel_based): Likewise.
4364
a8e7d6d7 43652012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4366
4367 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4368
a8e7d6d7 43692012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4370
4371 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4372 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4373
a8e7d6d7 43742012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4375
b593d6a9
AH
4376 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4377 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4378
1c6900d9
EZ
43792012-04-26 Eli Zaretskii <eliz@gnu.org>
4380
4c3fa1d9
EZ
4381 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4382 display element, check also the underlying string or buffer
4383 character. (Bug#11341)
4384
1c6900d9
EZ
4385 * w32menu.c: Include w32heap.h.
4386 (add_menu_item): If the call to AppendMenuW (via
4387 unicode_append_menu) fails, disable Unicode menus only if we are
4388 running on Windows 9X/Me.
4389
42bf8205
AS
43902012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4391
4392 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4393 (xgetint): Add missing shift for LSB tags.
4394
b1bac16e
MR
43952012-04-24 Martin Rudalics <rudalics@gmx.at>
4396
4397 * keyboard.c (read_char): Don't wipe echo area for select window
4398 events: These might get delayed via `mouse-autoselect-window'
4399 (Bug#11304).
4400
d69621cc
JB
44012012-04-24 Juanma Barranquero <lekktu@gmail.com>
4402
4403 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4404 manipulation of :loaded-from data.
4405
02fd101b
JB
44062012-04-23 Juanma Barranquero <lekktu@gmail.com>
4407
4408 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4409 now a cons (bug#11311).
4410
888bec30
PE
44112012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4412
89a438bd
PE
4413 Do not create empty overlays with the evaporate property (Bug#9642).
4414 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4415 if it becomes empty after its bounds are adjusted to fit within
4416 its buffer. Without this fix, in a nonempty buffer (let ((o
4417 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4418 yields an empty overlay that has the evaporate property, which is
4419 not supposed to happen.
4420
1068fe4d
PE
4421 Fix minor GTK3 problems found by static checking.
4422 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4423 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4424 (struct _EmacsFixedClass, emacs_fixed_get_type):
4425 Move decls here from emacsgtkfixed.h, since they needn't be public.
4426 (emacs_fixed_get_type): Now static.
4427 (emacs_fixed_class_init): Omit unused local.
4428 (emacs_fixed_child_type): Remove; unused.
4429 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4430 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4431 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4432 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4433 (EMACS_FIXED_GET_CLASS): Remove; unused.
4434 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4435
888bec30
PE
4436 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4437 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4438
de85e130
PE
44392012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4440
d0baac98 4441 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4442 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4443 (__malloc_size_t, __malloc_ptrdiff_t):
4444 Remove. All uses removed, replaced by the definiens if needed,
4445 since we can assume C89 or better now.
4446 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4447 (protect_malloc_state, align, get_contiguous_space)
4448 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4449 (malloc_atfork_handler_child, malloc_enable_thread)
4450 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4451 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4452 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4453 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4454 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4455 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4456 Define using prototypes, not old style.
4457 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4458 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4459 (align): Don't assume that signed integer overflow wraps around.
4460 Omit unused local var.
4461 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4462 (_free_internal_nolock, memalign, mallochook, reallochook):
4463 Omit no-longer-needed casts.
4464 (valloc): Use getpagesize, not __getpagesize.
4465 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4466 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4467
de85e130
PE
4468 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4469
dcbf5805
MA
44702012-04-22 Michael Albinus <michael.albinus@gmx.de>
4471
4472 Move functions from C to Lisp. Make non-blocking method calls
4473 the default. Implement further D-Bus standard interfaces.
4474
4475 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4476 (QCdbus_request_name_allow_replacement)
4477 (QCdbus_request_name_replace_existing)
4478 (QCdbus_request_name_do_not_queue)
4479 (QCdbus_request_name_reply_primary_owner)
4480 (QCdbus_request_name_reply_in_queue)
4481 (QCdbus_request_name_reply_exists)
4482 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4483 (QCdbus_registered_serial, QCdbus_registered_method)
4484 (QCdbus_registered_signal): New Lisp objects.
4485 (XD_DEBUG_MESSAGE): Use sizeof.
4486 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4487 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4488 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4489 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4490 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4491 (xd_signature, xd_append_arg): Allow float for integer types.
4492 (xd_get_connection_references): New function.
b593d6a9
AH
4493 (xd_get_connection_address): Rename from xd_initialize.
4494 Return cached address.
dcbf5805
MA
4495 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4496 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4497 level.
4498 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4499 Return number of refcounts.
dcbf5805
MA
4500 (Fdbus_get_unique_name): Make stronger parameter check.
4501 (Fdbus_message_internal): New defun.
4502 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4503 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4504 (Fdbus_send_signal, Fdbus_register_service)
4505 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4506 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4507 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4508 (Vdbus_compiled_version, Vdbus_runtime_version)
4509 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4510 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4511 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4512 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4513 Adapt docstring.
dcbf5805 4514
52828e02
PE
45152012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4516
da05bc4c
PE
4517 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4518 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4519 Do not assume ptrdiff_t is the same width as 'int'.
4520
52828e02
PE
4521 * alloc.c: Handle unusual debugging option combinations.
4522 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4523 since the two debugging options are incompatible.
4524 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4525 is defined.
4526 (mem_init, mem_insert, mem_insert_fixup):
4527 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4528 (NEED_MEM_INSERT): Remove; no longer needed.
4529
f01769f9
LL
45302012-04-22 Leo Liu <sdl.web@gmail.com>
4531
4532 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4533
5790543d
PE
45342012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4535
4536 * sysdep.c [__FreeBSD__]: Minor cleanups.
4537 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4538 Use Emacs indenting style more consistently. Avoid some casts.
4539 Use 'double' consistently rather than mixing 'float' and 'double'.
4540
b91b7e4d
EW
45412012-04-21 Eduard Wiebe <usenet@pusto.de>
4542
b593d6a9
AH
4543 * sysdep.c (list_system_processes, system_process_attributes):
4544 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4545
6114eb15
AS
45462012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4547
4548 * lisp.mk (lisp): Update.
4549
2f38dff7
PE
45502012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4551
4552 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4553 It is never used otherwise.
4554
4ae29f89
SM
45552012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4556
4557 * print.c (print_preprocess): Only check print_depth if print-circle
4558 is nil.
4559 (print_object): Check for cycles even when print-circle is nil and
4560 print-gensym is t, but only check print_depth if print-circle is nil.
4561
f30d612a
CY
45622012-04-20 Chong Yidong <cyd@gnu.org>
4563
4564 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4565 set the status to "failed" and ensure that sentinel is run.
4566
c07a4c0b 45672012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4568
4569 * process.c (Fset_process_inherit_coding_system_flag)
4570 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4571 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4572
c07a4c0b 45732012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4574
4575 * xdisp.c (string_buffer_position_lim): Limit starting position to
4576 BEGV.
4577 (set_cursor_from_row): If called for a mode-line or header-line
4578 row, return zero immediately.
4579 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4580 farther than the first row after the header line, if any.
4581 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4582 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4583
c07a4c0b 45842012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4585
4ae29f89
SM
4586 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4587 (bug#11238).
ad3a2b41 4588
c07a4c0b 45892012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 45902012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4591
4592 configure: new option --enable-gcc-warnings (Bug#11207)
4593 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4594 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4595 (ALL_CFLAGS): Use new macros rather than old.
4596 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4597 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4598 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4599 -Wunused-result, -Wunused-variable. This should go away once
4600 the Emacs and Gnulib regex code is merged.
4601 (xmalloc, xrealloc): Now static.
4602
aba027e8
PE
46032012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4604
4605 * dired.c (Fsystem_groups): Remove unused local.
4606
e5a36063
GM
46072012-04-17 Glenn Morris <rgm@gnu.org>
4608
4609 * dired.c (Fsystem_users): Doc fix.
4610
316411f0
DA
46112012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4612
4613 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4614 (syms_of_dired): Add them.
4615
9426aba4
PE
46162012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4617
b62a57be
PE
4618 Fix minor alloc.c problems found by static checking.
4619 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4620 New extern decls, to avoid calling undeclared functions.
4621 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4622 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4623 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4624 (NEED_MEM_INSERT): New macro.
4625 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4626 Remove one incorrect comment and fix another.
b62a57be 4627
3539f31f
PE
4628 Fix minor ralloc.c problems found by static checking.
4629 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4630 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4631 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4632 (r_alloc_sbrk): Now static.
4633
a041960a
PE
4634 Improve ralloc.c interface checking.
4635 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4636 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4637 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4638 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4639 [REL_ALLOC]: ... to here, to check interface.
4640 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4641 Remove decls. This fixes an "It stinks!".
4642
9426aba4
PE
4643 * alloc.c (which_symbols): Fix alignment issue / type clash.
4644
d55c12ed
AS
46452012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4646
4647 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4648 (struct Lisp_Misc_Any): Likewise.
4649 (struct Lisp_Free): Likewise.
4650 * alloc.c (union aligned_Lisp_Symbol): Define.
4651 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4652 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4653 (union aligned_Lisp_Misc): Define.
4654 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4655 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4656 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4657
b948ce8b
PE
46582012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4659
4660 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4661 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4662 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4663 * s/netbsd.h, s/sol2-6.h:
4664 Remove definition of GC_MARK_STACK, since the default now works.
4665 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4666 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4667 no longer the default.
4668 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4669
35dc09a1 46702012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4671
35dc09a1
GM
4672 * lread.c (lisp_file_lexically_bound_p):
4673 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4674
35dc09a1
GM
46752012-04-14 Eli Zaretskii <eliz@gnu.org>
4676
4677 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4678 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4679
46802012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4681
4682 * nsterm.m (constrainFrameRect): Always constrain when there is only
4683 one screen (Bug#10962).
4684
bcd86815
KB
46852012-04-13 Ken Brown <kbrown@cornell.edu>
4686
4687 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4688
c25df26e
RT
46892012-04-13 Reuben Thomas <rrt@sc3d.org>
4690
4691 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4692
0fc59f1e
DC
46932012-04-11 Daniel Colascione <dancol@dancol.org>
4694
4695 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4696 against is gone. It's better to use vfork now so that when Cygwin
4697 gains a new, working vfork, we use it automatically (bug#10398).
4698
de8c03dc
SM
46992012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4700
4701 * window.c (save_window_save): Obey window-point-insertion-type.
4702
2f097256
GM
47032012-04-11 Glenn Morris <rgm@gnu.org>
4704
4705 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4706
453b951e
SM
47072012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4708
4709 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4710
75f1671a 47112012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4712
4713 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4714 (force_quit_count): New var.
4715 (handle_interrupt): Use it.
4716
2a8ce227
JB
47172012-04-10 Juanma Barranquero <lekktu@gmail.com>
4718
4719 * w32.c (w32_delayed_load): Record the full path of the library
4720 being loaded (bug#10424).
4721
935396c0
GM
47222012-04-09 Glenn Morris <rgm@gnu.org>
4723
05920a43
GM
4724 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4725 not just in the obarray, before snarfing them. (Bug#11036)
4726
935396c0
GM
4727 * Makefile.in ($(leimdir)/leim-list.el):
4728 Pass EMACS rather than BUILT_EMACS.
4729
a18ecafa
TZ
47302012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4731
4732 * process.c (make_process):
4733 * process.h: Add integer `gnutls_handshakes_tried' member to
4734 process struct.
4735
6bbef4e5
JC
4736 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4737 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4738
4739 * gnutls.c (gnutls_log_function2i): Convenience log function.
4740 (emacs_gnutls_read): Use new log functions,
4741 `gnutls_handshakes_tried' process member, and
4742 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4743 attempts per process (connection).
4744
b4d3bc10
CY
47452012-04-09 Chong Yidong <cyd@gnu.org>
4746
4747 * eval.c (Fuser_variable_p, user_variable_p_eh)
4748 (lisp_indirect_variable): Functions deleted.
4749 (Fdefvar): Caller changed.
4750
4751 * callint.c (Finteractive, Fcall_interactively):
4752 * minibuf.c (Fread_variable): Callers changed.
4753
70f4d973
EZ
47542012-04-09 Eli Zaretskii <eliz@gnu.org>
4755
4756 * xdisp.c (set_cursor_from_row): If the display string appears in
4757 the buffer at position that is closer to point than the position
4758 after the display string, display the cursor on the first glyph of
4759 the display string. Fixes cursor display when a 'display' text
4760 property immediately follows invisible text. (Bug#11094)
4761
cb3c2e3e
PE
47622012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4763
4764 composite.c: use 'double' consistently
4765 * composite.c (get_composition_id): Use 'double' consistently
4766 instead of converting 'float' to 'double' and vice versa; this is
4767 easier to understand and avoids a GCC warning.
4768
fd06db5d
GM
47692012-04-09 Glenn Morris <rgm@gnu.org>
4770
50fe702a
GM
4771 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4772 preparation for dumping it with emacs. (Bug#4789)
4773 (leimdir): New variable.
4774 ($(leimdir)/leim-list.el): New rule.
4775 (emacs$(EXEEXT)): Depend on leim-list.el.
4776
fd06db5d
GM
4777 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4778 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4779 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4780
55c131ee
AS
47812012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4782
4783 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4784 proper alignment.
4785
9209588f
JB
47862012-04-07 Juanma Barranquero <lekktu@gmail.com>
4787
4788 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4789 Remove unused local variable.
4790
e3fb2efb
PE
47912012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4792
4793 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4794 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4795 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4796 objects, as mark_maybe_pointer will catch them otherwise.
4797 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4798 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4799
b5385551
PE
48002012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4801
4802 Fix typo that broke non-Windows builds.
4803 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4804
9078ead6
EZ
48052012-04-07 Eli Zaretskii <eliz@gnu.org>
4806
4807 Support building on MS-Windows with libxml2.
4808
4809 * makefile.w32-in (OBJ2): Add xml.$(O).
4810 (GLOBAL_SOURCES): Add xml.c.
4811 ($(BLD)/xml.$(O)): New dependency list.
4812
4813 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4814 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4815 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4816 [!WINDOWSNT]: New macros.
4817 (init_libxml2_functions, libxml2_loaded_p): New functions.
4818 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4819 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4820 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4821 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4822 linked in).
6bbef4e5
JC
4823 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4824 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4825 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4826
4827 * emacs.c: Don't include libxml/parser.h.
4828 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4829 xmlCleanupParser directly.
4830
4831 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4832
3811fdf3
EZ
48332012-04-07 Eli Zaretskii <eliz@gnu.org>
4834
4835 * indent.c (Fvertical_motion): If there is a display string at
4836 point, use it.vpos to compute how many lines to backtrack after
4837 move_it_to point. (Bug#11133)
4838
2f8e16b2
EZ
48392012-04-06 Eli Zaretskii <eliz@gnu.org>
4840
4841 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4842 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4843 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4844 macros related to unification of CJK characters. For the details,
4845 see the discussion following the message here:
4846 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4847
3d439cd1
CY
48482012-04-04 Chong Yidong <cyd@gnu.org>
4849
4850 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4851
8bc53d00
EZ
48522012-04-01 Eli Zaretskii <eliz@gnu.org>
4853
4854 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4855 instead of alloca. (Bug#11138)
4856
3b0512a3
AS
48572012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4858
4859 * w32menu.c (is_simple_dialog): Properly check lisp types.
4860 (Bug#11141)
4861
8427ddd2
EZ
48622012-03-31 Eli Zaretskii <eliz@gnu.org>
4863
979022ef
EZ
4864 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4865 position we get to after a call to move_it_to fails the
4866 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4867 only if we wind up in a string from display property. (Bug#11063)
4868
a6b1c7cc
EZ
4869 * window.c (Fdelete_other_windows_internal): Invalidate the row
4870 and column information about mouse highlight, so that redisplay
4871 restores it after reallocating the glyph matrices. (Bug#7464)
4872
8427ddd2
EZ
4873 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4874 string comes from a `display' text property, use the buffer
4875 position of that property as if we actually saw that position in
4876 the row's glyphs.
697ba24b
EZ
4877 (move_it_by_lines): Remove the assertion that
4878 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4879 violated when there's a before-string at the beginning of a line.
4880 (Bug#11063)
8427ddd2 4881
65a0a738
EZ
48822012-03-30 Eli Zaretskii <eliz@gnu.org>
4883
4884 * xdisp.c (append_space_for_newline): If the default face was
4885 remapped, use the remapped face for the appended newline.
4886 (extend_face_to_end_of_line): Use the remapped default face for
4887 extending the face to the end of the line.
4888 (display_line): Call extend_face_to_end_of_line when the default
4889 face was remapped. (Bug#11068)
4890
581355cc
EZ
48912012-03-29 Eli Zaretskii <eliz@gnu.org>
4892
4893 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4894
e8fc049f
SM
48952012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4896
4897 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4898
4fb9a543
GM
48992012-03-27 Glenn Morris <rgm@gnu.org>
4900
4901 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4902 Doc fixes.
4903
679910f1
KH
49042012-03-26 Kenichi Handa <handa@m17n.org>
4905
4906 * dispextern.h (struct glyph): Fix previous change. Change the
4907 bit length of glyphless.ch to 25 (Bug#11082).
4908
90d49b7f
CY
49092012-03-26 Chong Yidong <cyd@gnu.org>
4910
4911 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4912 (command_loop_1): Use it; inhibit selection update for
4913 handle-select-window too (Bug#8996).
4914
f514f6f0
FP
49152012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4916
e8fc049f 4917 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4918
bf43fa51
KH
49192012-03-25 Kenichi Handa <handa@m17n.org>
4920
4921 * dispextern.h (struct glyph): Change the bit length of
4922 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4923
8a0c01dd
EZ
49242012-03-24 Eli Zaretskii <eliz@gnu.org>
4925
4926 * s/ms-w32.h (tzname): Include time.h before redirecting to
4927 _tzname. Fixes the MSVC build. (Bug#9960)
4928
7d1c3a76
AS
49292012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4930
8ed79523
AS
4931 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4932 characters.
4933
7d1c3a76
AS
4934 * xterm.c (XTread_socket): Only modify handling_signal if
4935 !SYNC_INPUT. (Bug#11080)
4936
e99a9b8b
EZ
49372012-03-23 Eli Zaretskii <eliz@gnu.org>
4938
4939 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4940 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4941 when fetching a multibyte character consumes more bytes than
4942 CHAR_BYTES returns, due to unification of CJK characters in
4943 string_char. (Bug#11073)
4944
5063c0e1
TN
49452012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4946
4947 * process.c (wait_reading_process_output): Handle pty disconnect
4948 by refraining from sending oneself a SIGCHLD (bug#10933).
4949
9f851fbd
CY
49502012-03-22 Chong Yidong <cyd@gnu.org>
4951
4952 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4953
5063c0e1 4954 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4955 Mark string as coming from a prefix property.
4956 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4957 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4958
fb5b8aca
CY
49592012-03-21 Chong Yidong <cyd@gnu.org>
4960
4961 * xfaces.c (Vface_remapping_alist): Doc fix.
4962
62356a1b
EZ
49632012-03-20 Eli Zaretskii <eliz@gnu.org>
4964
4965 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4966 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4967 Doc fixes.
62356a1b 4968
025de85b
CY
49692012-03-20 Chong Yidong <cyd@gnu.org>
4970
4971 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4972 to reflect default non-nil value of redisplay-dont-pause.
4973
4827f94e
KH
49742012-03-19 Kenichi Handa <handa@m17n.org>
4975
4976 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4977 it fit in a valid range (Bug#11003).
4978
e50a24a2
EZ
49792012-03-18 Eli Zaretskii <eliz@gnu.org>
4980
4981 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4982 that is not from display property, accept the row as a "cursor
4983 row" if one of the string's character has a non-nil `cursor'
4984 property. Fixes cursor positioning when there are newlines in
4985 overlay strings, e.g. in icomplete.el. (Bug#11035)
4986
9af5ed87
PE
49872012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4988
4989 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4990
d1f55f16
CY
49912012-03-12 Chong Yidong <cyd@gnu.org>
4992
4993 * eval.c (inhibit_lisp_code): Rename from
4994 inhibit_window_configuration_change_hook; move from window.c.
4995
4996 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4997 * window.c (run_window_configuration_change_hook)
4998 (syms_of_window): Callers changed.
4999
66c5eebd
CY
50002012-03-11 Chong Yidong <cyd@gnu.org>
5001
413df973
CY
5002 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5003
66c5eebd
CY
5004 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5005
1de11f56
CY
50062012-03-10 Chong Yidong <cyd@gnu.org>
5007
5008 * frame.c (other_visible_frames): Don't assume the selected frame
5009 is visible (Bug#10955).
5010
cae07000
SM
50112012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5012
5013 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5014
89c94350
JD
50152012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5016
5017 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5018 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5019 zero (Bug#10954).
5020
999dd333
GM
50212012-03-03 Glenn Morris <rgm@gnu.org>
5022
01a6dcc8 5023 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5024
de0100f2
EZ
50252012-03-02 Eli Zaretskii <eliz@gnu.org>
5026
5027 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5028 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5029 (redisplay_window, next_element_from_string): Fix typos in
5030 comments.
3e441275
EZ
5031 (redisplay_window): Pass to move_it_vertically the margin in
5032 pixels, not in screen lines.
de0100f2 5033
96a72ee9
GM
50342012-03-02 Glenn Morris <rgm@gnu.org>
5035
5036 * buffer.c (buffer-list-update-hook): Doc fix.
5037
312508d7
EZ
50382012-02-29 Eli Zaretskii <eliz@gnu.org>
5039
5040 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5041 push_it before setting up the iterator for the first overlay
5042 string, even if we have an empty string loaded.
5043 (next_overlay_string): If there's an empty string on the iterator
5044 stack, pop the stack. (Bug#10903)
5045
27f3c637
PE
50462012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5047
5048 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5049 Suggested by Stefan Monnier in
5050 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5051 * alloc.c (widen_to_Lisp_Object): New static function.
5052 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5053 and widening them to Lisp_Objects. This would work even if
5054 USE_LSB_TAG is defined and wide integers are used, which might
5055 happen in a future version of Emacs.
5056
3c9dfce6
CY
50572012-02-25 Chong Yidong <cyd@gnu.org>
5058
fa74b241
CY
5059 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5060 Doc fix.
5061
3c9dfce6
CY
5062 * xselect.c (Fx_selection_exists_p): Doc fix.
5063 (x_clipboard_manager_save_all): Print an informative message
5064 before saving to clipboard manager.
5065
9486df08
CY
50662012-02-24 Chong Yidong <cyd@gnu.org>
5067
5068 * keyboard.c (process_special_events): Handle all X selection
5069 requests in kbd_buffer, not just the next one (Bug#8869).
5070
f01d3321
CY
50712012-02-23 Chong Yidong <cyd@gnu.org>
5072
5073 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5074 call when setting menu-bar-lines and tool-bar-lines parameters.
5075 (unwind_create_frame_1): New helper function.
5076
5077 * window.c (inhibit_window_configuration_change_hook): New var.
5078 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5079 (syms_of_window): Initialize it.
f01d3321 5080
86b847b6
CY
50812012-02-22 Chong Yidong <cyd@gnu.org>
5082
5083 * xterm.c (x_draw_image_relief): Add missing type check for
5084 Vtool_bar_button_margin (Bug#10743).
5085
a59225b1
CY
50862012-02-21 Chong Yidong <cyd@gnu.org>
5087
5088 * fileio.c (Vfile_name_handler_alist): Doc fix.
5089
5090 * buffer.c (Fget_file_buffer): Protect against invalid file
5091 handler return value.
5092
310f5bd4
PE
50932012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5094
cb3a28cc
PE
5095 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5096 when computing $valmask.
5097
310f5bd4
PE
5098 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5099 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5100 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5101 It's useless in that case, and it can cause problems on hosts
5102 that allocate halves of EMACS_INT values separately.
5103 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5104 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5105 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5106 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5107 it avoids undefined behavior on hosts where shifting right by more
5108 than the word width has undefined behavior.
5109
2375c96a
CY
51102012-02-19 Chong Yidong <cyd@gnu.org>
5111
5112 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5113 (Funhandled_file_name_directory, Ffile_name_as_directory)
5114 (Fdirectory_file_name, Fexpand_file_name)
5115 (Fsubstitute_in_file_name): Protect against invalid file handler
5116 return values (Bug#10845).
5117
3eb49e71
EZ
51182012-02-18 Eli Zaretskii <eliz@gnu.org>
5119
5120 * .gdbinit (pitx): Fix incorrect references to fields of the
5121 iterator stack.
5122
7b926f3f
CY
51232012-02-17 Chong Yidong <cyd@gnu.org>
5124
5125 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5126
11273115
PE
51272012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5128
5129 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5130 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5131
c3a70e2b
CY
51322012-02-15 Chong Yidong <cyd@gnu.org>
5133
5134 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5135 marked as special. Also, starting docstrings with * is obsolete.
5136
0ca43699
AS
51372012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5138
5139 * gnutls.c (emacs_gnutls_write): Fix last change.
5140
2e8f3c56
LI
51412012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5142
5143 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5144 send_process.
5145
af70074f
SM
51462012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5147
5148 * keymap.c (Fsingle_key_description): Handle char ranges.
5149
95986d52
CY
51502012-02-12 Chong Yidong <cyd@gnu.org>
5151
afd83bd1
CY
5152 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5153 as that creates a dangerous corner case.
5154
95986d52
CY
5155 * window.c (Fdelete_window_internal): Invalidate the mouse
5156 highlight (Bug#9904).
5157
bd7da63e
GM
51582012-02-12 Glenn Morris <rgm@gnu.org>
5159
5160 * xselect.c (Fx_own_selection_internal)
5161 (Fx_get_selection_internal, Fx_disown_selection_internal)
5162 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5163 * nsselect.m (Fx_own_selection_internal)
5164 (Fx_disown_selection_internal, Fx_selection_exists_p)
5165 (Fx_selection_owner_p, Fx_get_selection_internal):
5166 Sync docs and argument specs with the xselect.c versions.
5167
77abcbc2
LI
51682012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5169
5170 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5171
90b671e2
EZ
51722012-02-11 Eli Zaretskii <eliz@gnu.org>
5173
1c0ca0b7
EZ
5174 * w32select.c (Fx_selection_exists_p): Sync doc string and
5175 argument list with xselect.c. (Bug#10783)
5176
5177 * w16select.c (Fx_selection_exists_p): Sync doc string and
5178 argument list with xselect.c. (Bug#10783)
90b671e2 5179
49241268
GM
51802012-02-10 Glenn Morris <rgm@gnu.org>
5181
5182 * fns.c (Fsecure_hash): Doc fix.
5183
f998bbe7 51842012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5185
5186 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5187
0992bd9c
CY
51882012-02-07 Chong Yidong <cyd@gnu.org>
5189
5190 * buffer.c (Fbuffer_local_variables)
5191 (buffer_lisp_local_variables): Handle unbound vars correctly;
5192 don't let Qunbound leak into Lisp.
5193
af008560
GM
51942012-02-07 Glenn Morris <rgm@gnu.org>
5195
dd605cc4
GM
5196 * image.c (Fimagemagick_types): Doc fix.
5197
af008560
GM
5198 * image.c (imagemagick-render-type): Change it from a lisp object
5199 to an integer. Move the doc here from the lisp manual.
5200 Treat all values not equal to 0 the same.
5201
1449fa1d
CY
52022012-02-06 Chong Yidong <cyd@gnu.org>
5203
5204 * doc.c (store_function_docstring): Avoid applying docstring of
5205 alias to base function (Bug#2603).
5206
3723ec07
AS
52072012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5208
5209 * .gdbinit (pp1, pv1): Remove redundant defines.
5210 (pr): Use pp.
5211
79c1cc1e
CY
52122012-02-04 Chong Yidong <cyd@gnu.org>
5213
5214 * nsterm.m: Declare a global (Bug#10694).
5215
d7f29f8e
EZ
52162012-02-04 Eli Zaretskii <eliz@gnu.org>
5217
cae07000
SM
5218 * w32.c (get_emacs_configuration_options):
5219 Include --enable-checking, if specified, in the return value.
d7f29f8e 5220
3b95a6f9
MR
52212012-02-04 Martin Rudalics <rudalics@gmx.at>
5222
5223 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5224 after rounding frame sizes. (Bug#9723)
5225
d6fa96a6
EZ
52262012-02-04 Eli Zaretskii <eliz@gnu.org>
5227
5228 * keyboard.c (adjust_point_for_property): Don't position point
5229 before BEGV. (Bug#10696)
5230
df0b2940
PE
52312012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5232
5233 Handle overflow when computing char display width (Bug#9496).
5234 * character.c (char_width): Return EMACS_INT, not int.
5235 (char_width, c_string_width): Check for overflow when
5236 computing the width; this is possible now that individual
5237 characters can have unbounded width. Problem introduced
5238 by merge from Emacs 23 on 2012-01-19.
5239
6bee44d6
MA
52402012-02-02 Michael Albinus <michael.albinus@gmx.de>
5241
5242 * dbusbind.c (Fdbus_register_method): Mention the return value
5243 :ignore in the docstring.
5244
44f92739
GM
52452012-02-02 Glenn Morris <rgm@gnu.org>
5246
1b9f60cc
GM
5247 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5248
44f92739
GM
5249 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5250 Unconditionally set to t. (Bug#10673)
5251 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5252 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5253 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5254
c5d3843c
KH
52552012-02-02 Kenichi Handa <handa@m17n.org>
5256
5257 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5258 0, do not call append_composite_glyph.
5259
159462d4 52602012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5261
5262 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5263 NULL (Bug#6988).
5264 (x_produce_glyphs): If the component of a composition is a null
5265 string, set it->pixel_width to 1 to avoid zero-width glyph.
5266
78cef877
EZ
52672012-02-01 Eli Zaretskii <eliz@gnu.org>
5268
5269 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5270 first 2 arguments are identical. This makes inserting large
5271 output from a subprocess an order of magnitude faster on
5272 MS-Windows, where all sbrk'ed memory is always contiguous.
5273
97897668
GM
52742012-01-31 Glenn Morris <rgm@gnu.org>
5275
5276 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5277 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5278 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5279
31fd3586
GM
52802012-01-29 Glenn Morris <rgm@gnu.org>
5281
5282 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5283
0e24a8b2
CY
52842012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5285
5286 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5287
cc0adcb0
CY
52882012-01-28 Chong Yidong <cyd@gnu.org>
5289
5290 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5291
acc28cb9
CY
52922012-01-26 Chong Yidong <cyd@gnu.org>
5293
9c69cfb7
CY
5294 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5295
acc28cb9
CY
5296 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5297 repeat counts (Bug#10507).
5298
48da7392
GM
52992012-01-26 Glenn Morris <rgm@gnu.org>
5300
5301 * lread.c (syms_of_lread): Doc fix.
5302
14af5f7f
CY
53032012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5304
5305 * coding.c (encode_designation_at_bol): Change return value to
5306 EMACS_INT.
5307
0b21c100
CY
53082012-01-25 Chong Yidong <cyd@gnu.org>
5309
5310 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5311
3c2907f7
CY
53122012-01-21 Chong Yidong <cyd@gnu.org>
5313
5314 * floatfns.c (Fcopysign): Make the second argument non-optional,
5315 since nil is not allowed anyway.
5316
959ad23f
AS
53172012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5318
5319 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5320 (send_process): Likewise.
5321
34a02f46
MR
53222012-01-19 Martin Rudalics <rudalics@gmx.at>
5323
5324 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5325 (Vwindow_persistent_parameters): Do not use Qstate.
5326 Rewrite doc-strings.
34a02f46 5327
1259009a 53282012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5329
5330 * character.c (char_width): New function.
70d4fdf6
GM
5331 (Fchar_width, c_string_width, lisp_string_width):
5332 Use char_width (Bug#9496).
25ed9e61 5333
6a6ee00d
MR
53342012-01-16 Martin Rudalics <rudalics@gmx.at>
5335
5336 * window.c (Vwindow_persistent_parameters): New variable.
5337 (Fset_window_configuration, save_window_save): Handle persistent
5338 window parameters.
5339
c85efaf7
EZ
53402012-01-14 Eli Zaretskii <eliz@gnu.org>
5341
5342 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5343 thrashing the stack of the thread. (Bug#9087)
5344
5944709e
PE
53452012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5346
5347 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5348
e71f5d99
EZ
53492012-01-11 Eli Zaretskii <eliz@gnu.org>
5350
5351 * xdisp.c (rows_from_pos_range): Handle the case where the
5352 highlight ends on a newline. (Bug#10464)
5353 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5354 he end column for display of highlight that ends on a newline
5355 before a R2L line.
5356
ce316182
GM
53572012-01-11 Glenn Morris <rgm@gnu.org>
5358
5359 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5360 from load-path also when installation-directory is nil. (Bug#10208)
5361
5b43da69
GM
53622012-01-10 Glenn Morris <rgm@gnu.org>
5363
74cc8ff9
GM
5364 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5365
7d8d6e4e
GM
5366 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5367 Update template values to be closer to their typical values these days.
5b43da69 5368
a0db8d43
EZ
53692012-01-09 Eli Zaretskii <eliz@gnu.org>
5370
5371 * xdisp.c (rows_from_pos_range): Accept additional argument
5372 DISP_STRING, and accept any glyph in a row whose object is that
5373 string as eligible for mouse highlight. Fixes mouse highlight of
5374 display strings from overlays. (Bug#10464)
5375
9a0115ab 53762012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5377
b9110d6a 5378 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5379 * fileio.c (auto_saving_dir_umask): New static var.
5380 (Fmake_directory_internal): Use it.
5381 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5382 creating the directory. The old code temporarily assigns
5383 too-generous permissions to the directory.
5384 (do_auto_save_eh): Clear it.
b9110d6a 5385 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5386 that the var is always cleared.
5387
6c1bd3f3
EZ
53882012-01-07 Eli Zaretskii <eliz@gnu.org>
5389
5390 * search.c (scan_buffer): Pass character positions to
5391 know_region_cache, not byte positions. (Bug#6540)
5392
069d2b50
L
53932012-01-07 LynX <_LynX@bk.ru> (tiny change)
5394
5395 * w32.c (sys_rename): Report EXDEV when rename of a directory
5396 fails because the target is on another logical disk. (Bug#10284)
5397
75bf0d33
DB
53982012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5399
5400 * xterm.c (x_embed_request_focus): New function.
5401
5402 * xterm.h: Add prototype.
5403
5404 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5405
1c6e5a32
GM
54062012-01-05 Glenn Morris <rgm@gnu.org>
5407
5408 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5409
651e947e
EZ
54102012-01-01 Eli Zaretskii <eliz@gnu.org>
5411
5412 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5413 Load gnutls_transport_set_lowat only if GnuTLS version is below
5414 2.11.1.
5415 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5416 GnuTLS versions below 2.11.1.
5417
3778cdd8
AL
54182011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5419
5420 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5421 to the doc string advising against its use for altering the way
5422 windows are scrolled.
5423
0e5317f7
KH
54242011-12-28 Kenichi Handa <handa@m17n.org>
5425
5426 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5427 coding-system ASCII compatible only when it does not produce BOM
5428 on encoding (Bug#10383).
5429
93d5ca1f
JD
54302011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5431
5432 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5433 can scroll.
5434 (create_and_show_popup_menu): Always use menu_position_func for
5435 Gtk3 (Bug#10361).
5436
ca22b785
AS
54372011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5438
5439 * callint.c (Fcall_interactively): Don't truncate prompt string.
5440
d048e1e6
EZ
54412011-12-23 Eli Zaretskii <eliz@gnu.org>
5442
5443 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5444 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5445 resumed from there (after widening). (Bug#10360)
d048e1e6 5446
5ccaba1f
JD
54472011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5448
5449 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5450
204ee57f
JD
54512011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5452
b81d40f0
JB
5453 * nsterm.m (x_free_frame_resources):
5454 Release f->output_data.ns->miniimage.
204ee57f
JD
5455 (ns_index_color): Fix indentation. Do not retain
5456 color_table->colors[i].
5457
5458 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5459 before returning.
5460
5461 * nsfns.m (x_set_background_color): Assign return value from
5462 ns_index_color to face-background instead of NSColor*.
5463 (ns_implicitly_set_icon_type): Fix indentation.
5464 Change assignment in for loop to comparison.
5465
5466 * emacs.c (ns_pool): New variable.
5467 (main): Assign ns_pool.
5468 (Fkill_emacs): Call ns_release_autorelease_pool.
5469
5470 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5471 autorelease fdesc, release fdAttrs and tdict.
5472 (ns_get_covering_families): Release charset.
5473 (ns_findfonts): Release NSFontDescriptor created with new.
5474 (ns_uni_to_glyphs): Fix indentation.
5475 (setString): Release attrStr before assigning new value.
5476
c803b2b7
JD
54772011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5478
678f4426
JD
5479 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5480 and NS_IMPL_COCOA.
5481 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5482 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5483
cd394be1 54842011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5485
5fecd5fc
JD
5486 * nsterm.m (ns_term_init): Subscribe for notifications
5487 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5488 to method trackingNotification in EmacsMenu.
5489
5490 * nsmenu.m (trackingMenu): New variable.
3771cb17 5491 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5492 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5493 from Aquamacs (Bug#7030).
678f4426
JD
5494
54952011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5496
c803b2b7
JD
5497 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5498 (symbol_to_nsstring): Fix indentation.
5499 (ns_symbol_to_pb): New function.
cae07000
SM
5500 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5501 (Fns_rotate_cut_buffers_internal): Remove.
5502 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5503 Fns_store_cut_buffer_internal.
5504 (ns_get_foreign_selection, Fx_own_selection_internal)
5505 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5506 (Fns_get_selection_internal, Fns_store_selection_internal):
5507 Use ns_symbol_to_pb and check if return value is nil.
5508 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5509 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5510 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5511 renamed to Sns_store_selection_internal.
5512 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5513 and remove this function.
5514 (ns_handle_selection_clear): Remove, never used.
5515 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5516 here.
5517
e1b01a3a
KB
55182011-12-17 Ken Brown <kbrown@cornell.edu>
5519
5520 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5521 GID is unknown (Bug#10257).
5522
2adb6e85
PE
55232011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5524
5525 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5526 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5527 which caused a build failure on GNU/Linux IA-64. This problem was
5528 introduced by my 2011-10-07 patch.
5529
d1d7b339
JL
55302011-12-15 Juri Linkov <juri@jurta.org>
5531
5532 * image.c (imagemagick_error): New function. (Bug#10112)
5533 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5534 Use `imagemagick_error' where ImageMagick functions return
5535 `MagickFalse'.
5536 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5537 proper order.
5538
100d5755
KH
55392011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5540
5541 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5542 fill background (Bug#8992).
5543
454592a6
MR
55442011-12-13 Martin Rudalics <rudalics@gmx.at>
5545
5546 * window.c (Vwindow_combination_resize)
5547 (Vwindow_combination_limit): Use t instead of non-nil in
5548 doc-strings.
61d4b438
MR
5549 (Vrecenter_redisplay): Add first sentence of doc-string on
5550 separate line.
53524d93 5551 (Frecenter): Fix doc-string typo.
454592a6 5552
3633e3aa
KH
55532011-12-11 Kenichi Handa <handa@m17n.org>
5554
5555 * coding.c (Funencodable_char_position): Pay attention to the
5556 buffer text relocation (Bug#9389).
5557
7b9d523a 55582011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5559
7b9d523a
JD
5560 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5561 gtk_init (Bug#10100).
5562
b73189c6
EZ
55632011-12-10 Eli Zaretskii <eliz@gnu.org>
5564
5565 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5566 IT->string is nil. (Bug#10263)
5567
f7dfe5d6
JD
55682011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5569
83faebb4
JD
5570 * nsterm.h (x_free_frame_resources): Declare.
5571
f7dfe5d6
JD
5572 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5573 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5574
5575 * nsterm.h (ns_get_defaults_value): Declare.
5576
5577 * nsterm.m (ns_default): Call ns_get_defaults_value.
5578
7cd4e72c
EZ
55792011-12-09 Eli Zaretskii <eliz@gnu.org>
5580
5581 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5582 (Bug#10170)
5583
b34d7317
YM
55842011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5585
5586 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5587 that where the value of an _OBJC_* symbol points to is in the .bss
5588 section (Bug#10240).
5589
76470ad1
KH
55902011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5591
5592 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5593 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5594
745fff94
KH
55952011-12-08 Kenichi Handa <handa@m17n.org>
5596
5597 * ftfont.c (get_adstyle_property): Fix previous change
5598 (Bug#10233).
5599
6e44397c
JB
56002011-12-07 Juanma Barranquero <lekktu@gmail.com>
5601
5602 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5603 dirs from the default value of EMACSLOADPATH (bug#10208).
5604
7efa6272
GM
56052011-12-07 Glenn Morris <rgm@gnu.org>
5606
5607 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5608 installation and source directories as well. (Bug#10208)
5609
f6fc4d87
CY
56102011-12-06 Chong Yidong <cyd@gnu.org>
5611
5612 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5613
2bf26180
GM
56142011-12-06 Glenn Morris <rgm@gnu.org>
5615
5616 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5617 as an error, not just -1. (Bug#10217)
5618
3a6ad4f0
CY
56192011-12-05 Chong Yidong <cyd@gnu.org>
5620
5621 * keyboard.c (process_special_events): New function.
5622 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5623
75a3b399
PE
56242011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5625
5626 * coding.c (encode_designation_at_bol): Don't use uninitialized
5627 local variable (Bug#9318).
5628
c3c9e25e
KH
56292011-12-05 Kenichi Handa <handa@m17n.org>
5630
5631 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5632 return Qnil (Bug#8046, Bug#10193).
5633
5eb05ea3
KH
56342011-12-05 Kenichi Handa <handa@m17n.org>
5635
5636 * coding.c (encode_designation_at_bol): New args charbuf_end and
5637 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5638 (coding_set_source): Return how many bytes coding->source was
5639 relocated.
5640 (coding_set_destination): Return how many bytes
5641 coding->destination was relocated.
5642 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5643 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5644
56452011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5646
5647 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5648 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5649 macro (Bug#9318).
5650
56512011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5652
5653 The following changes are to fix Bug#9318.
5654
a79703f5 5655 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5656 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5657 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5658 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5659
7dbda6df
JB
56602011-12-05 Juanma Barranquero <lekktu@gmail.com>
5661
5662 * lisp.h (process_quit_flag): Fix external declaration.
5663
6d5eb5b0
SM
56642011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5665
5666 Don't macro-inline non-performance-critical code.
5667 * eval.c (process_quit_flag): New function.
5668 * lisp.h (QUIT): Use it.
5669
a0c3fad0
JD
56702011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5671
5672 * nsfns.m (get_geometry_from_preferences): New function.
5673 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5674
6c07aac2
AS
56752011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5676
5677 * emacs.c (Qkill_emacs): Define.
5678 (syms_of_emacs): Initialize it.
5679 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5680 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5681 (quit_throw_to_read_char): Add parameter `from_signal'.
5682 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5683 * lisp.h (QUIT): Call Fkill_emacs if requested.
5684
c052ead4
JD
56852011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5686
5687 * widget.c (update_wm_hints): Return if wmshell is null.
5688 (widget_update_wm_size_hints): New function.
5689
5690 * widget.h (widget_update_wm_size_hints): Declare.
5691
5692 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5693 widget_update_wm_size_hints (Bug#10104).
5694
9e49252b
EZ
56952011-12-03 Eli Zaretskii <eliz@gnu.org>
5696
5697 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5698 before a newline, prepare the bidi iterator for consuming the
5699 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5700 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5701
02b16839
JL
57022011-12-02 Juri Linkov <juri@jurta.org>
5703
5704 * search.c (Fword_search_regexp): New Lisp function created from
5705 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5706 (Fword_search_backward, Fword_search_forward)
5707 (Fword_search_backward_lax, Fword_search_forward_lax):
5708 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5709 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5710
0068070e
SM
57112011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5712
5713 * fileio.c (Finsert_file_contents): Move after-change-function call
5714 to before the "handled:" label, since all "goto handled" appear in
5715 cases where the *-change-functions have already been properly called
5716 (bug#10117).
5717
3360a3fc
AS
57182011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5719
5720 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5721 waiting for input. (Bug#10169)
5722
73d6c093
EZ
57232011-11-30 Eli Zaretskii <eliz@gnu.org>
5724
5725 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5726 verifies glyph row's hash code--we have just reallocated the
5727 glyphs, so their contents can be complete garbage. (Bug#10164)
5728
febe6bea
JB
57292011-11-30 Juanma Barranquero <lekktu@gmail.com>
5730
5731 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5732
801a4313
EZ
57332011-11-30 Eli Zaretskii <eliz@gnu.org>
5734
5735 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5736 attributes are tested _before_ calling verify_row_hash, to protect
5737 against GCC re-ordering of the tests. (Bug#10164)
5738
2b56b87e
JD
57392011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5740
5741 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5742
5743 * xterm.c (handle_one_xevent): Only set async_visible and friends
5744 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5745 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5746 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5747
dbf31225
PE
57482011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5749
5750 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5751 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5752 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5753 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5754 All uses changed to use GCPRO1 etc.
5755 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5756 Revert to old implementation (i.e., before 2011-03-11).
5757
1305621b
YM
57582011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5759
5760 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5761 of scroll runs so as to avoid assigning disabled bogus rows and
5762 unnecessary graphics copy operations.
5763
8c9afb46
EZ
57642011-11-27 Eli Zaretskii <eliz@gnu.org>
5765
5766 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5767 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5768 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5769 (malloc, free, realloc, calloc): Redirect to e_* only when
5770 compiling Emacs.
5771
5772 * lisp.h (GCTYPEBITS): Move before first use.
5773 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5774 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5775 this macro definition.
5776
5777 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5778 _MSC_VER.
5779
54e9e3bf
JD
57802011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5781
6d5eb5b0
SM
5782 * gtkutil.c (xg_create_frame_widgets):
5783 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5784 present with Gtk+ 2.0.
5785
83aca1cb
PE
57862011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5787
5788 * fileio.c (Finsert_file_contents): Undo previous change; see
5789 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5790
5b76caa4
PE
57912011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5792
5793 Rename locals to avoid shadowing.
5794 * fileio.c (Finsert_file_contents):
5795 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5796 * process.c (wait_reading_process_output):
5797 Rename inner 'proc' to 'p' to avoid shadowing.
5798 Indent for consistency with usual Emacs style.
5799
8c535114
EZ
58002011-11-25 Eli Zaretskii <eliz@gnu.org>
5801
5802 * xdisp.c (redisplay_window): If cursor row is not fully visible
5803 after recentering, and scroll-conservatively is set to a large
5804 number, scroll window by a few more lines to make the cursor fully
5805 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5806 (start_display): Don't move to the next line if the display should
5807 start at a newline that is part of a display vector or an overlay
5808 string. (Bug#10119)
8c535114 5809
fa4fdb5c
JL
58102011-11-24 Juri Linkov <juri@jurta.org>
5811
5812 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5813 after the `MagickPingImage' call. (Bug#10112)
5814
90ec88df
CY
58152011-11-23 Chong Yidong <cyd@gnu.org>
5816
5817 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5818
56e2e794
MR
58192011-11-23 Martin Rudalics <rudalics@gmx.at>
5820
5821 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5822 making another buffer current. (Bug#10114)
5823
b6e64c41
GM
58242011-11-23 Glenn Morris <rgm@gnu.org>
5825
5826 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5827
6b21de18
CY
58282011-11-23 Chong Yidong <cyd@gnu.org>
5829
5830 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5831 using it (Bug#5984).
5832
b12cd789
EZ
58332011-11-22 Eli Zaretskii <eliz@gnu.org>
5834
5835 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5836 and header-lines, as they don't have one computed for them.
5837 (Bug#10098)
5838
5839 * .gdbinit (prow): Make displayed values more self-explaining.
5840 Add row's hash code.
5841
261b6fd4
LMI
58422011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5843
5844 * process.c (wait_reading_process_output): Fix asynchrounous
5845 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5846 (wait_reading_process_output): Add comment and URL.
261b6fd4 5847
e7cfd277
JD
58482011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5849
5850 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5851
a9b9b7f5
CY
58522011-11-21 Chong Yidong <cyd@gnu.org>
5853
5854 * window.c (Fnext_window, Fprevious_window): Doc fix.
5855
b0d15b4f
SM
58562011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5857
5858 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5859
fe7a3057
JB
58602011-11-20 Juanma Barranquero <lekktu@gmail.com>
5861
5862 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5863
d2999b1a
MR
58642011-11-20 Martin Rudalics <rudalics@gmx.at>
5865
5866 * window.c (Fset_window_combination_limit): Rename argument
5867 STATUS to LIMIT.
5868 (Vwindow_combination_limit): Remove "status" from doc-string.
5869
d5ff9cd0
AS
58702011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5871
5872 * m/ibms390.h: Remove.
5873 * m/ibms390x.h: Don't include "ibms390.h".
5874
a5bb9bd3
SM
58752011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5876
5877 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5878 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5879
cd1181db
JB
58802011-11-20 Juanma Barranquero <lekktu@gmail.com>
5881
5882 * casetab.c (Fset_case_table):
5883 * charset.c (Fcharset_after): Fix typos.
5884
615a3b8d 58852011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5886
17e845af
PE
5887 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5888 Otherwise, valgrind does not work on some platforms.
5889 Problem reported by Andreas Schwab in
6a0bf43d
PE
5890 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5891 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5892 is set, removing the need for VIRT_ADDRESS_VARIES.
5893 (PURE_P): Use a more-efficient implementation that needs just one
5894 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5895 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5896 to 4 (xorl, subq, cmpq, setbe).
5897 * alloc.c (pure): Always extern now, since that's the
5898 VIRT_ADDR_VARIES behavior.
5899 (PURE_POINTER_P): Use a single comparison, not two, for
5900 consistency with the new puresize.h.
5901 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5902 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5903 Remove VIRT_ADDR_VARIES no longer needed.
5904
f8fe6f96
EZ
59052011-11-19 Eli Zaretskii <eliz@gnu.org>
5906
5907 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5908 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5909 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5910 behave as if the cursor position were at the window margin.
5911
5912 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5913 and the cursor position is out of bounds, behave as if the cursor
5914 position were at the window margin. (Bug#10075)
5915
df05a53c
CY
59162011-11-18 Chong Yidong <cyd@gnu.org>
5917
5918 * window.c (Fwindow_combination_limit): Make first argument
5919 non-optional, since it is meaningless for live windows like the
5920 selected window.
61ccba97 5921
2071918e
DA
59222011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5923
5924 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5925
b50a28de
SM
59262011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5927
5928 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5929 (graft_intervals_into_buffer): Simplify.
5930
015137db
EZ
59312011-11-18 Eli Zaretskii <eliz@gnu.org>
5932
5933 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5934 hash values of the two rows.
5935 (copy_row_except_pointers): Preserve the used[] arrays and the
5936 hash values of the two rows. (Bug#10035)
68c95424 5937 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5938
5939 * xdisp.c (row_hash): New function, body extracted from
5940 compute_line_metrics.
5941 (compute_line_metrics): Call row_hash, instead of computing the
5942 hash code inline.
5943
5944 * dispnew.c (verify_row_hash): Call row_hash for computing the
5945 hash code of a row, instead of duplicating code from xdisp.c.
5946
5947 * dispextern.h (row_hash): Add prototype.
5948
a2addb04
TH
59492011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5950
5951 * frame.c (delete_frame): Don't delete the terminal when the last
5952 X frame is closed if emacs is built with GTK toolkit.
5953
df85d315
JB
59542011-11-17 Juanma Barranquero <lekktu@gmail.com>
5955
5956 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5957
a0c2d0ae
MR
59582011-11-17 Martin Rudalics <rudalics@gmx.at>
5959
5960 * window.c (Vwindow_splits): Rename to
5961 Vwindow_combination_resize. Suggested by Juri Linkov.
5962 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5963 of Vwindow_splits.
5964
58179cce
JB
59652011-11-16 Juanma Barranquero <lekktu@gmail.com>
5966
7877f373
JB
5967 * nsfns.m (Fns_font_name):
5968 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5969
b6f67890
MR
59702011-11-16 Martin Rudalics <rudalics@gmx.at>
5971
5972 * window.h (window): Rename slot "nest" to "combination_limit".
5973 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5974 (Fset_window_nest): Rename to Fset_window_combination_limit.
5975 (Vwindow_nest): Rename to Vwindow_combination_limit.
5976 (recombine_windows, make_parent_window, make_window)
5977 (Fsplit_window_internal, saved_window)
5978 (Fset_window_configuration, save_window_save): Rename all
5979 occurrences of window_nest to window_combination_limit.
5980
c7015153
JB
59812011-11-15 Juanma Barranquero <lekktu@gmail.com>
5982
5983 * image.c (imagemagick_load_image): Fix typo.
5984
322ad6ec
EZ
59852011-11-14 Eli Zaretskii <eliz@gnu.org>
5986
5987 * xdisp.c (display_line): Move the call to
5988 highlight_trailing_whitespace before the call to
5989 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5990 faces of all the glyphs to compute ROW's hash value.
5991 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5992
f067b8ec
JB
59932011-11-14 Juanma Barranquero <lekktu@gmail.com>
5994
5995 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5996 just return (bug#10044).
5997
1e5b2111
EZ
59982011-11-12 Eli Zaretskii <eliz@gnu.org>
5999
7ef3cbd5
EZ
6000 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6001 with user-defined heap size. Bump the default size of the temacs
6002 heap to 27MB, to avoid memory warning when running temacs.
6003 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6004
1e5b2111
EZ
6005 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6006 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6007 (verify_row_hash) [XASSERTS]: New function.
6008 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6009 that the hash value of glyph rows is correct.
1e5b2111 6010
89d61221
MR
60112011-11-12 Martin Rudalics <rudalics@gmx.at>
6012
6013 * window.h (window): Remove splits slot.
6014 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6015 (Fdelete_other_windows_internal, make_parent_window)
6016 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6017 (Fset_window_configuration, save_window_save): Don't deal with
6018 split status of windows.
6019 (saved_window): Remove splits slot.
6020 (Vwindow_splits): Rewrite doc-string.
6021
97f18cc8
JD
60222011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6023
6024 * xfns.c (unwind_create_frame):
6025 * nsfns.m (unwind_create_frame):
6026 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6027 Vframe_list (Bug#9999).
6028
22a648b4
DA
60292011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6030
0b381c7e 6031 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6032
659afede
KH
60332011-11-11 Kenichi Handa <handa@m17n.org>
6034
6035 * callproc.c (Fcall_process): Set the member dst_multibyte of
6036 process_coding.
6037
9ac0394b
KH
60382011-11-11 Johan Bockgård <bojohan@gnu.org>
6039
6040 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6041 avoid a crash (bug#9496).
6042
2fbdc249
CY
60432011-11-09 Chong Yidong <cyd@gnu.org>
6044
6045 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6046 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6047
ac6b1f81
PE
60482011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6049
6050 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6051
09db192c
PE
60522011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6053
6054 Avoid some portability problems by eschewing 'extern inline' functions.
6055 The trivial performance wins aren't worth the portability hassles; see
6056 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6057 et seq.
6058 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6059 (window_box_width, window_box_left, window_box_left_offset)
6060 (window_box_right, window_box_right_offset): Undo previous change,
6061 by removing the "extern"s.
6062 * intervals.c (adjust_intervals_for_insertion)
6063 (adjust_intervals_for_deletion): Undo previous change,
6064 making these static again.
6065 (offset_intervals, temp_set_point_both, temp_set_point)
6066 (copy_intervals_to_string): No longer inline.
6067 * xdisp.c (window_text_bottom_y, window_box_width)
6068 (window_box_height, window_box_left_offset)
6069 (window_box_right_offset, window_box_left, window_box_right)
6070 (window_box): No longer inline.
6071
105216ed
CY
60722011-11-08 Chong Yidong <cyd@gnu.org>
6073
6074 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6075 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6076 Signal an error if not a live window.
105216ed
CY
6077 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6078 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6079
ae9e237f
JB
60802011-11-07 Juanma Barranquero <lekktu@gmail.com>
6081
6082 * lisp.h (syms_of_abbrev): Remove declaration.
6083 Reported by CHENG Gao <chenggao@royau.me>.
6084
c7aa8333
EZ
60852011-11-07 Eli Zaretskii <eliz@gnu.org>
6086
6087 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6088 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6089 of temacs in GUI mode.
6090
be7f5545
MR
60912011-11-07 Martin Rudalics <rudalics@gmx.at>
6092
6093 * window.h: Declare delete_all_child_windows instead of
6094 delete_all_subwindows.
6095 * window.c (Fwindow_nest, Fset_window_nest)
6096 (Fset_window_new_total, Fset_window_new_normal)
6097 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6098 (delete_all_subwindows): Rename to delete_all_child_windows.
6099 (Fdelete_other_windows_internal, Fset_window_configuration):
6100 Call delete_all_child_windows instead of delete_all_subwindows.
6101 * frame.c (delete_frame): Call delete_all_child_windows instead
6102 of delete_all_subwindows.
6103
ca78dc43
PE
61042011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6105
6106 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6107 This is also needed for porting to any host where GC_MARK_STACK is
6108 not GC_MAKE_GCPROS_NOOPS.
6109 (which_symbols): Use it.
6110
a0241d01
KH
61112011-11-07 Kenichi Handa <handa@m17n.org>
6112
6113 * coding.c (coding_set_destination): Check coding->src_pos only
6114 when coding->src_object is a buffer (bug#9910).
6115
6116 * process.c (send_process): Set the member src_multibyte of coding
6117 to 0 (bug#9911) when sending a unibyte text.
6118
6119 * callproc.c (Fcall_process): Set the member src_multibyte of
6120 process_coding to 0 (bug#9912).
6121
a64bfdfa 61222011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6123
6124 * xmenu.c (cleanup_widget_value_tree): New function.
6125 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6126 calling free_menubar_widget_value_tree directly (Bug#9830).
6127
cb41b32a
PE
61282011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6129
6130 Fix some portability problems with 'inline'.
6131 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6132 (window_box_width, window_box_left, window_box_left_offset)
6133 (window_box_right, window_box_right_offset): Declare extern.
6134 Otherwise, these inline functions do not conform to C99 and
6135 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6136 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6137 * intervals.c (adjust_intervals_for_insertion)
6138 (adjust_intervals_for_deletion): Now extern, because otherwise the
6139 extern inline functions 'offset_intervals' couldn't refer to it.
6140 (static_offset_intervals): Remove.
6141 (offset_intervals): Rewrite using the old contents of
6142 static_offset_intervals. The old version didn't conform to C99
6143 because an extern inline function contained a reference to an
6144 identifier with static linkage.
6145
b7041366
AS
61462011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6147
6148 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6149 GC.
6150
88a37c4d
EZ
61512011-11-06 Eli Zaretskii <eliz@gnu.org>
6152
6153 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6154 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6155 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6156 return Qleft_to_right.
6157
49745b39
CY
61582011-11-06 Chong Yidong <cyd@gnu.org>
6159
6160 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6161 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6162 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6163 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6164 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6165 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6166 (Fwindow_vscroll): Doc fix.
6167 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6168 argument, since it makes no sense to pass a live window and for
6169 consistency with window-child.
6170
1f05cd82
CS
61712011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6172
6173 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6174 support MSVC.
6175
22610910
JR
61762011-11-05 Jason Rumney <jasonr@gnu.org>
6177
6178 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6179 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6180 fonts (Bug#6029).
6181 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6182 bitwise arithmetic preventing use of unicode-sip and non-truetype
6183 opentype fonts.
6184
a06776b2
EZ
61852011-11-05 Eli Zaretskii <eliz@gnu.org>
6186
3ad924ba
EZ
6187 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6188 "emacs"-only part.
6189
a06776b2
EZ
6190 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6191 initialization code to keep similarity to xfns.c after changes
6192 from 2011-11-05.
6193
c9e7db78
JD
61942011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6195
a97f8f3f
JD
6196 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6197 (unwind_create_frame): New function (Bug#9943).
6198 (Fx_create_frame): Restructure code to be more similar to the one in
6199 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6200 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6201 Move terminal->reference_count++ just before making the frame official
6202 (Bug#9943).
6203
6204 * nsterm.m (x_free_frame_resources): New function.
6205 (x_destroy_window): Move code to x_free_frame_resources.
6206
c9e7db78 6207 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6208 (Fx_create_frame, x_create_tip_frame):
6209 Move terminal->reference_count++ just before making the frame
75f1671a 6210 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6211 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6212
a6fc3b5c
EZ
62132011-11-05 Eli Zaretskii <eliz@gnu.org>
6214
6215 Support MSVC build with newer versions of Visual Studio.
6216 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6217 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6218 nt/gmake.defs.
6219
6220 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6221 which are not supported by MSVC.
6222 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6223 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6224 bitfields.
6225 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6226 types in bitfields.
6227 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6228
6229 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6230
58179cce 62312011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6232
6233 Support MSVC build with newer versions of Visual Studio.
6234 * w32.c: Don't include w32api.h for MSVC.
6235 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6236
6237 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6238 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6239 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6240 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6241 e_* cousins.
6242 (alloca) [_MSC_VER]: Define to _alloca.
6243
6244 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6245
6246 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6247
a58c13ed
EZ
62482011-11-04 Eli Zaretskii <eliz@gnu.org>
6249
6250 * xdisp.c (note_mouse_highlight): If either of
6251 previous/next-single-property-change returns nil, treat that as
6252 the beginning or the end of the buffer. (Bug#9955)
6253
fe0b6370
JD
62542011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6255
a58c13ed 6256 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6257 label is not null (Bug#9951).
6258 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6259 may be NULL.
6260
89bd5ee1
EZ
62612011-11-04 Eli Zaretskii <eliz@gnu.org>
6262
6263 * window.c (Fwindow_body_size): Mention in the doc string that the
6264 return value is in frame's canonical units. (Bug#9949)
6265
84c3edb9
EZ
62662011-11-03 Eli Zaretskii <eliz@gnu.org>
6267
4e2fb5c7
EZ
6268 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6269
84c3edb9 6270 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6271 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6272 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6273
bc17a887
EZ
62742011-11-01 Eli Zaretskii <eliz@gnu.org>
6275
6276 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6277 Don't stop backward scan on the continuation glyph, even though
6278 its CHARPOS is positive.
6d5eb5b0
SM
6279 (mouse_face_from_buffer_pos, note_mouse_highlight):
6280 Rename cover_string to disp_string.
bc17a887 6281
4ee88440
MR
62822011-11-01 Martin Rudalics <rudalics@gmx.at>
6283
6284 * window.c (temp_output_buffer_show): Don't use
6285 Vtemp_buffer_show_specifiers.
6286 (Vtemp_buffer_show_specifiers): Remove unused variable.
6287
c2ff3c02
EZ
62882011-10-30 Eli Zaretskii <eliz@gnu.org>
6289
6290 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6291 past the beginning of the current glyph matrix.
6292
58179cce 62932011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6294
6295 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6296 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6297 HAVE_GTK3 (Bug#9869).
b77a6a7f 6298
3b574623
JD
6299 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6300 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6301
b77a6a7f
JD
6302 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6303
6304 * xterm.c: Declare x_handle_net_wm_state to return int.
6305 (handle_one_xevent): Check if we are iconified but don't have
6306 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6307 (get_current_wm_state): Return non-zero if not hidden,
6308 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6309 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6310 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6311 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6312
196e41e4
PE
63132011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6314
6315 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6316 so that this new function doesn't get optimized away by a
6317 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6318
021f2e1a
AS
63192011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6320
6321 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6322
8b058d44
EZ
63232011-10-29 Eli Zaretskii <eliz@gnu.org>
6324
6325 Fix the `xbytecode' command.
6326 * .gdbinit (xprintbytestr): New command.
b50a28de 6327 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6328 (xbytecode): Print the byte-code string as well.
6329
4452fb80
EZ
63302011-10-29 Kim Storm <storm@cua.dk>
6331
8b058d44
EZ
6332 * alloc.c (which_symbols): New function.
6333
21b72067
AS
63342011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6335
6336 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6337 line. (Bug#9903)
6338
83ed7b5c
GM
63392011-10-29 Glenn Morris <rgm@gnu.org>
6340
6341 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6342 Not clear what it was for, and it causes various bugs. (Bug#9839)
6343
5a7a728b
EZ
63442011-10-28 Eli Zaretskii <eliz@gnu.org>
6345
6346 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6347 possible random value that matches one of those tested as
6348 condition to clear the mouse face.
6349
d3d0842f
CY
63502011-10-28 Chong Yidong <cyd@gnu.org>
6351
6352 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6353
31b39d13
DN
63542011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6355
6356 * window.c (make_window): Initialize phys_cursor_on_p.
6357
9aba6043
SM
63582011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6359
6360 * lisp.h (struct Lisp_Symbol): Update comments.
6361
c20992f4
JB
63622011-10-28 Juanma Barranquero <lekktu@gmail.com>
6363
6364 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6365
db4f02f2
EZ
63662011-10-28 Eli Zaretskii <eliz@gnu.org>
6367
6368 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6369 <oslsachem@gmail.com> for helping to debug this.
6370
6371 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6372 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6373 (g_b_init_get_glyph_outline_w): New static variables.
6374 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6375 (GetGlyphOutlineW_Proc): New typedefs.
6376 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6377 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6378 New functions.
6379 (w32font_open_internal, compute_metrics):
6380 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6381 instead of calling the "wide" APIs directly.
6382
6383 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6384
6385 * w32.h (syms_of_w32font): Add prototype.
6386
87e68db4
JB
63872011-10-27 Juanma Barranquero <lekktu@gmail.com>
6388
6389 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6390 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6391 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6392 (Fmove_to_window_line): Doc fix.
6393
435c1d67
CY
63942011-10-27 Chong Yidong <cyd@gnu.org>
6395
6396 * process.c (make_process): Set gnutls_state to NULL.
6397
6398 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6399 non-NULL, regardless of GNUTLS_INITSTAGE.
6400 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6401 an error. Set process slots as soon as we allocate them.
6402
6403 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6404
9c6c6f49
CY
64052011-10-27 Chong Yidong <cyd@gnu.org>
6406
9aba6043
SM
6407 * gnutls.c (emacs_gnutls_deinit): New function.
6408 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6409 (Fgnutls_deinit, Fgnutls_boot): Use it.
6410
6411 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6412 (deactivate_process): Call emacs_gnutls_deinit.
6413
657d08d3
JB
64142011-10-27 Juanma Barranquero <lekktu@gmail.com>
6415
6416 * image.c (x_create_x_image_and_pixmap):
6417 * w32.c (sys_rename, w32_delayed_load):
6418 * w32font.c (fill_in_logfont):
6419 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6420
5430d399
JB
64212011-10-26 Juanma Barranquero <lekktu@gmail.com>
6422
6423 * w32fns.c (w32_default_color_map): New function,
6424 extracted from Fw32_default_color_map.
a7ef684b 6425 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6426
fe0055fa
PE
64272011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6428
6429 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6430
e6346438
SM
64312011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6432
6433 * keyboard.c (test_undefined): New function (bug#9751).
6434 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6435
e112cc37
ET
64362011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6437
6438 * sysdep.c (init_sys_modes): Fix the check for the controlling
6439 terminal (Bug#6649).
6440
7b5d6677
EZ
64412011-10-20 Eli Zaretskii <eliz@gnu.org>
6442
6443 * dispextern.h (struct bidi_it): New member next_en_type.
6444
6445 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6446 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6447 current character, check also for next_en_type being WEAK_EN.
6448 (bidi_resolve_weak): Don't enter the expensive loop if the current
6449 position is before next_en_pos. Record the bidi type of the first
6450 non-ET, non-BN character we find, in addition to its position.
6451 (bidi_level_of_next_char): Invalidate next_en_type when
6452 next_en_pos is over-stepped.
6453
7da0b018
PE
64542011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6455
6456 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6457 * editfns.c: Rewrite current-time-zone so that it invokes
6458 the equivalent of (format-time-string "%Z") to get the time zone name.
6459 This fixes a bug when the time zone name contains characters that
6460 need converting from the system time locale to Emacs internal format.
6461 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6462 that patch fixed format-time-string to do the conversion, but
6463 I forgot to fix current-time-zone.
6464 (format_time_string): New function, containing most of
6465 what Fformat_time_string used to contain.
6466 (Fformat_time_string): Rewrite in terms of format_time_string.
6467 This doesn't change this function's behavior.
6468 (current-time-zone): Rewrite to use format_time_string.
6469 This fixes the bug reported by Michael Schierl in
6470 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6471 Jason Rumney's 2007-06-07 change worked around this bug, but
6472 didn't fix it.
6473 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6474
8547b010
EZ
64752011-10-19 Eli Zaretskii <eliz@gnu.org>
6476
6477 * xdisp.c (start_display): If the character at POS is displayed
6478 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6479 (try_window_reusing_current_matrix): If a line ends in a display
6480 vector or the next line starts in a display vector, continue
6481 redrawing the window even though the character position of
6482 start_row was reached.
8547b010
EZ
6483 (Bug#9771, part 2)
6484
4e948d15
CY
64852011-10-18 Chong Yidong <cyd@gnu.org>
6486
6487 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6488 with nobreak-char-display too.
6489
4787455f
EZ
64902011-10-18 Eli Zaretskii <eliz@gnu.org>
6491
6492 Fix part 3 of bug#9771.
6493 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6494 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6495 non-neutral characters if the current character is a paragraph
6496 separator (a.k.a. Newline). This avoids running the same
6497 expensive loop twice, once when we consume the preceding newline
6498 and the other time when the line actually needs to be displayed.
6499 Avoid the loop when we see neutrals on the base embedding level
6500 following a character whose directionality is the same as the
6501 paragraph's. This avoids running the expensive loop when a line
6502 ends in a long sequence of neutrals, like control characters.
6503 Add assertion against STRONG_AL type. Slightly rearrange code
6504 that determines the type of a neutral given the first non-neutral
6505 that follows it.
6506 (bidi_level_of_next_char): Set next_en_pos to zero when
6507 invalidating its info.
6508
2c91f553
EZ
65092011-10-17 Eli Zaretskii <eliz@gnu.org>
6510
6511 * xdisp.c (push_display_prop): Determine whether to record string
6512 or buffer position by IT->string, not by IT->method. Allow
6513 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6514 (move_it_vertically_backward): Don't look for character position
6515 immediately after the newline when in a continuation line.
6516 (Bug#9771, part 1)
2c91f553 6517
c7b08b0d
MR
65182011-10-15 Martin Rudalics <rudalics@gmx.at>
6519
6520 * window.c (coordinates_in_window): Rewrite and delabelize
6521 vertical border check. (Bug#5357) (Bug#9618)
6522
6b02f655
SM
65232011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6524
6525 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6526 errors in XSetWindowBorder (bug#9310).
6527
81d40c92
DA
65282011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6529
6530 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6531 avoid crash when xmalloc overrun checking is enabled.
6532
d4172c3b
EZ
65332011-10-13 Eli Zaretskii <eliz@gnu.org>
6534
6535 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6536 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6537 cursor motion with <left> and <right> arrow keys.
6538
6539 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6540 some callers set that themselves.
6541
b00eea75
EZ
65422011-10-12 Eli Zaretskii <eliz@gnu.org>
6543
6544 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6545 display string and the previous row comes from the same string and
6546 is empty. (Bug#9739) (Bug#9738)
6547
8fe012c4
SM
65482011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6549
6550 * doc.c (get_doc_string): Encode file name (bug#9735).
6551
0074aef2
EZ
65522011-10-12 Eli Zaretskii <eliz@gnu.org>
6553
79beb178
EZ
6554 * bidi.c (bidi_level_of_next_char):
6555 * xdisp.c (get_visually_first_element): Remove old incorrect
6556 comments regarding the Unicode Line Separator character.
6557
0074aef2
EZ
6558 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6559
6e4b3fbe
DA
65602011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6561
6562 * alloc.c (Fgc_status): Do not access beyond zombies array
6563 boundary if nzombies > MAX_ZOMBIES.
6564 * alloc.c (dump_zombies): Add missing format specifier.
6565
0324f3af
PE
65662011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6567
b5525cac
PE
6568 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6569 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6570
0324f3af
PE
6571 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6572 Some packages use them to denote characters with modifiers.
6573
e9b5f888
AS
65742011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6575
6576 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6577 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6578 matching a pp-number. Rename parameter var to var1.
6579
127827c0
SM
65802011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6581
6582 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6583
c8fd3bd0
GM
65842011-10-08 Glenn Morris <rgm@gnu.org>
6585
6586 * callint.c (Fcall_interactively): Give a more explicit error for the
6587 'c' case with a non-character input. (Bug#8479)
6588
352ec8ff
EZ
65892011-10-08 Eli Zaretskii <eliz@gnu.org>
6590
03669ccb
EZ
6591 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6592 lines.
7061c986
EZ
6593 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6594 lines that are hscrolled on the left.
03669ccb 6595
352ec8ff
EZ
6596 * dispnew.c (buffer_posn_from_coords): Account for a possible
6597 presence of header-line. (Bug#4426)
6598
a66cfb1c
SM
65992011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6600
6b02f655
SM
6601 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6602 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6603
7c5ee88e
PE
66042011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6605
6606 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6607 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6608 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6609 this makes Emacs dump core during garbage collection on rare
6610 occasions. sizeof is obviously inferior to offsetof here, so
6611 stick with offsetof.
6612 (GC_POINTER_ALIGNMENT): New macro.
6613 (mark_memory): Omit 3rd (offset) arg; caller changed.
6614 Don't assume EMACS_INT alignment is the same as pointer alignment.
6615
df1bbe5b
SM
66162011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6617
6618 * keyboard.c (read_key_sequence_remapped): New var.
6619 (read_key_sequence): Compute remapping in the right buffer.
6620 (command_loop_1): Use read_key_sequence's remapping directly.
6621
51553db6
SM
66222011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6623
32c1fffd
SM
6624 * dired.c (file_name_completion): Don't expand file name.
6625 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6626 before checking file name handler.
6627
51553db6
SM
6628 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6629 they've been requested explicitly (bug#9591).
6630
b6bd1599 66312011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6632
6633 * keymap.c (Fsingle_key_description): Use make_specified_string
6634 instead of build_string to build string from push_key_description.
6635 (Bug#5193)
6636
f701dc2a
PE
66372011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6638
4222c55d
PE
6639 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6640 This fixes a Y2038 bug on 64-bit hosts.
6641 * buffer.c (reset_buffer):
6642 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6643 (Fclear_buffer_auto_save_failure):
6644 Use 0, not -1, to represent an unset failure time, since time_t
6645 might not be signed.
6646
f701dc2a
PE
6647 Remove dependency on glibc malloc internals.
6648 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6649 Move back here from lisp.h, but with their new implementations.
6650 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6651 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6652 * charset.c (charset_table_init): New static var.
6653 (syms_of_charset): Use it instead of xmalloc. This removes a
6654 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6655 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6656 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6657 Move back to alloc.c.
6658 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6659 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6660
9ceebf39
JD
66612011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6662
6663 * nsterm.m (windowDidResize): Call x_set_window_size only when
6664 ns_in_resize is true. Otherwise set pixelwidth/height and
6665 call change_frame_size (Bug#9628).
6666
cb993c58
PE
66672011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6668
3930c88b
PE
6669 Port --enable-checking=all to Fedora 14 x86-64.
6670 * charset.c (syms_of_charset): Also account for glibc malloc's
6671 internal overhead when calculating the initial malloc maximum.
6672
cb993c58
PE
6673 Port --enable-checking=all to Fedora 14 x86.
6674 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6675 Move to lisp.h.
6676 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6677 (overrun_check_realloc, overrun_check_free):
6678 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6679 That way, xmalloc returns a properly-aligned pointer even if
6680 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6681 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6682 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6683 into account when calculating the initial malloc maximum.
6684 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6685 Move here from alloc.c, so that charset.c can use it too.
6686 Properly align; the old code wasn't right for common 32-bit hosts
6687 when configured with --enable-checking=all.
6688 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6689 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6690
31bed486
EZ
66912011-09-29 Eli Zaretskii <eliz@gnu.org>
6692
04c70788 6693 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6694 use EDOM.
6695
fbcaa2f3
EZ
66962011-09-28 Eli Zaretskii <eliz@gnu.org>
6697
6698 * xdisp.c (compute_display_string_end): If there's no display
6699 string at CHARPOS, return -1.
6700
6701 * bidi.c (bidi_fetch_char): When compute_display_string_end
6702 returns a negative value, treat the character as a normal
6703 character not covered by a display string. (Bug#9624)
6704
a239d4e9
JB
67052011-09-28 Juanma Barranquero <lekktu@gmail.com>
6706
6707 * lread.c (Fread_from_string): Fix typo in docstring.
6708
88652fd5
EZ
67092011-09-27 Eli Zaretskii <eliz@gnu.org>
6710
6711 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6712 newline, reseat the iterator instead of bidi-iterating there one
6713 character at a time. (Bug#9610)
32c1fffd
SM
6714 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6715 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6716
ed497dd4
AS
67172011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6718
6719 * lread.c (readevalloop): Use correct code for NBSP.
6720 (read1): Likewise. (Bug#9608)
6721
b2bf61aa
MA
67222011-09-25 Michael Albinus <michael.albinus@gmx.de>
6723
6724 * dbusbind.c (Fdbus_register_signal): When service is not
6725 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6726
32bbb17c
GM
67272011-09-25 Glenn Morris <rgm@gnu.org>
6728
6729 * buffer.c (truncate-lines): Doc fix.
6730
94e0933e
CY
67312011-09-24 Chong Yidong <cyd@stupidchicken.com>
6732
6733 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6734 (Fset_window_next_buffers): Doc fix.
6735
cddde921
GM
67362011-09-24 Glenn Morris <rgm@gnu.org>
6737
6738 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6739
1260aef1
PE
67402011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6741
25b4bfa0
PE
6742 Fix minor problems found by static checking.
6743 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6744 * indent.c (Fvertical_motion): Fix == vs = typo.
6745
e3cbd34b
EZ
67462011-09-24 Eli Zaretskii <eliz@gnu.org>
6747
a66cfb1c
SM
6748 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6749 Default value is now t. Doc fix.
6bf7006f 6750
e3cbd34b 6751 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6752 logic when moving up, not only when moving down. Fix the
e3cbd34b 6753 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6754 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6755
6756 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6757 CHARPOS is covered by a display string which includes newlines.
6758 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6759 is covered by a display string with embedded newlines.
6760
a3de0cbd
MA
67612011-09-24 Michael Albinus <michael.albinus@gmx.de>
6762
6763 * dbusbind.c (Fdbus_register_signal): Add match rule to
6764 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6765 (Fdbus_register_method, Vdbus_registered_objects_table):
6766 Fix docstring.
a3de0cbd 6767
b260039d
JM
67682011-09-24 Jim Meyering <meyering@redhat.com>
6769
32c1fffd 6770 do not ignore write error for any output size
b260039d
JM
6771 The previous change was incomplete.
6772 While it makes emacs --batch detect the vast majority of stdout
6773 write failures, errors were still ignored whenever the output size is
6774 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6775 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6776 && echo FAIL: ignored write error
6777 FAIL: ignored write error
6778 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6779 && echo FAIL: ignored write error
6780 FAIL: ignored write error
6781 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6782
8eca8a7c
AS
67832011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6784
6785 * emacs.c (Fkill_emacs): In noninteractive mode exit
6786 non-successfully if a write error occurred on stdout. (Bug#9574)
6787
3341db62
EZ
67882011-09-21 Eli Zaretskii <eliz@gnu.org>
6789
6790 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6791 the xassert test.
6792
6793 * dispextern.h (struct it): Update the comment documenting what
6794 can it->OBJECT be.
6795
8c203dbf
EZ
67962011-09-20 Eli Zaretskii <eliz@gnu.org>
6797
6798 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6799 a display string, extend search for cursor position to end of row.
6800 (find_row_edges): If the row ends in a newline from a display
6801 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6802 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6803 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6804 non-empty line. Fixes confusing cursor motion with arrow keys at
6805 the beginning of a line that starts with whitespace.
8c203dbf 6806
a4824228
LMI
68072011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6808
6809 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6810 (bug#9493).
6811
33ed493b
CY
68122011-09-18 Chong Yidong <cyd@stupidchicken.com>
6813
6814 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6815 boolean (Bug#9154).
6816
56cd55c8
EZ
68172011-09-18 Eli Zaretskii <eliz@gnu.org>
6818
6819 * xdisp.c (display_line): Record maximum and minimum buffer
6820 positions even if no glyphs were produced (e.g., by a zero-width
6821 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6822 buffer positions that will be removed from the glyph row because
6823 they don't fit.
c02dcedf
EZ
6824 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6825 column is beyond frame width: don't subtract 1 "pixel" when
6826 computing width of the stretch.
3e62b7e0
EZ
6827 (reseat_at_next_visible_line_start): Undo the change made on
6828 2011-09-17 that saved paragraph information and restored it after
6829 the call to `reseat'. (Bug#9545)
56cd55c8 6830
5ed99d36 68312011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6832
6833 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6834 and turn window cursor on if cleared (Bug#9415).
6835
5ed99d36 68362011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6837
6838 * search.c (boyer_moore): Take unibyte characters from pattern
6839 literally. (Bug#9458)
6840
9bade7b2
EZ
68412011-09-18 Eli Zaretskii <eliz@gnu.org>
6842
6843 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6844
e5e9d610
PE
68452011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6846
87e4427a
PE
6847 Fix minor problem found by static checking.
6848 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6849 initialized, to pacify gcc -Wuninitialized.
6850
e5e9d610
PE
6851 * fileio.c: Report proper errno when syscall falls.
6852 (Finsert_file_contents): Save and restore errno,
6853 so that report_file_error outputs the correct diagnostic.
6854 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6855
a1674f0b
EZ
68562011-09-18 Eli Zaretskii <eliz@gnu.org>
6857
6858 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6859
fbfb6dd4
EZ
68602011-09-17 Eli Zaretskii <eliz@gnu.org>
6861
6862 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6863 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6864
bb187662
EZ
68652011-09-17 Eli Zaretskii <eliz@gnu.org>
6866
1137e8b8 6867 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6868 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6869
6870 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6871 (bidi_find_paragraph_start): Search back for paragraph beginning
6872 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6873 (bidi_move_to_visually_next): Only trigger paragraph-related
6874 computations when the last character is a newline or at EOB, not
6875 just any NEUTRAL_B. (Bug#9470)
6876
bb187662
EZ
6877 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6878 truncated lines if point is covered by a display string. (Bug#9524)
6879
2e621251
PE
68802011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6881
6882 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6883 (cons_to_x_long): New function.
6884 (lisp_data_to_selection_data): Use it. Correct the test for
6885 short-versus-long data; it was negated. Break out of vector
6886 loop, for efficiency, when a long datum is discovered.
6887
91a15bc6
SM
68882011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6889
6890 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6891
b41c3a35
EZ
68922011-09-16 Eli Zaretskii <eliz@gnu.org>
6893
6894 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6895 GCC PR/17406) by declaring this function with external scope.
6896
7812ba2d
PE
68972011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6898
6899 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6900 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6901
cf7edc2a
AS
69022011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6903
6904 * editfns.c (Fformat): Correctly handle text properties on "%%".
6905
bd01620e
EZ
69062011-09-15 Eli Zaretskii <eliz@gnu.org>
6907
6908 * xterm.c (x_draw_composite_glyph_string_foreground):
6909 * w32term.c (x_draw_composite_glyph_string_foreground):
6910 * term.c (encode_terminal_code):
6911 * composite.c (composition_update_it, get_composition_id):
6912 * xdisp.c (get_next_display_element)
6913 (fill_composite_glyph_string): Add comments about special meaning
6914 of TAB characters in a composition.
6915
a02719a3
PE
69162011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6917
6918 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6919 This occurs when processing a multibyte format.
6920 Problem reported by Wolfgang Jenker.
a02719a3 6921
72589a3c
JB
69222011-09-15 Johan Bockgård <bojohan@gnu.org>
6923
6924 * xdisp.c (try_cursor_movement): Only check for exact match if
6925 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6926
1c14176c
PE
69272011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6928
6929 Remove unused external symbols.
6930 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6931 * xdisp.c (calc_pixel_width_or_height): Now static.
6932 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6933 * indent.c (check_display_width):
6934 * w32term.c: Fix comment to match code.
6935 * xterm.c, xterm.h (x_catching_errors): Remove.
6936
d2eea5b5
PE
69372011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6938
6939 * xselect.c: Use signed conversions more consistently (Bug#9498).
6940 (selection_data_to_lisp_data): Assume incoming selection data are
6941 signed integers, not unsigned. This is to be consistent with
6942 outgoing selection data, which was modified to use signed integers
6943 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6944 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6945 expects long, not unsigned long.
6946
46888499
EZ
69472011-09-14 Eli Zaretskii <eliz@gnu.org>
6948
6949 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6950 computation of loop end. Reported by Johan Bockgård
6951 <bojohan@gnu.org>.
6952
ef8ef9fb
CY
69532011-09-13 Chong Yidong <cyd@stupidchicken.com>
6954
6955 * frame.c (Fother_visible_frames_p): Function deleted.
6956
fa819fed
EZ
69572011-09-12 Eli Zaretskii <eliz@gnu.org>
6958
6959 * indent.c (compute_motion): Process display vector front to back
6960 rather than the other way around. (Bug#2496)
6961
2ba8e008
SM
69622011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6963
6964 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6965
20f53c69
CY
69662011-09-11 Chong Yidong <cyd@stupidchicken.com>
6967
6968 * minibuf.c (Fread_from_minibuffer): Doc fix.
6969
d562d7a4
EZ
69702011-09-11 Eli Zaretskii <eliz@gnu.org>
6971
6972 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6973 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6974
1c4d7f3d
LMI
69752011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6976
6977 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6978 value for non-existent files.
6979
b885bf36
EZ
69802011-09-11 Eli Zaretskii <eliz@gnu.org>
6981
6982 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6983 set its "size" to -1. This will set the modtime_size field of
6984 the corresponding buffer to -1, which is what
6985 verify-visited-file-modtime expects for files that do not exist.
6986 (Bug#9139)
6987
6612f0bf
PE
69882011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6989
6990 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6991 here ...
6992 * lisp.h: ... from here. push_key_description is no longer
6993 defined in keyboard.c, so its declaration should not be in
6994 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6995 logically belongs with push_key_description.
6996
dfb3f755
PE
69972011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6998
6999 * buffer.h: Include <sys/types.h> instead of <time.h>.
7000 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7001 Problem reported by Herbert J. Skuhra.
7002
3134906c
LMI
70032011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7004
7005 * xml.c (parse_region): Make the parsing work for
7006 non-comment-starting XML files again (bug#9144).
7007
8d903f4e
AS
70082011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7009
7010 * image.c (gif_load): Fix calculation of bottom and right corner.
7011 (Bug#9468)
7012
80ad64f4
EZ
70132011-09-10 Eli Zaretskii <eliz@gnu.org>
7014
7015 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7016 redisplay in small windows.
7017
208a048d
EZ
70182011-09-09 Eli Zaretskii <eliz@gnu.org>
7019
7020 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7021
9b1c252e
MR
70222011-09-08 Martin Rudalics <rudalics@gmx.at>
7023
7024 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7025 Operate on live windows only.
7026
2949f33b
JB
70272011-09-08 Juanma Barranquero <lekktu@gmail.com>
7028
7029 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7030
e08dcafd
EZ
70312011-09-07 Eli Zaretskii <eliz@gnu.org>
7032
7033 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7034 only under bidi iteration.
7035
115b96bd
JD
70362011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7037
7038 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7039
c8199d0f
PE
70402011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7041
7042 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7043 Without this fix, the command to link temacs failed due to an
7044 undefined symbol __builtin_isnan. This is because
7045 /usr/include/iso/math_c99.h #defines isnan(x) to
7046 __builtin_isnan(x), but the bundled gcc, which identifies itself
7047 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7048 a __builtin_isnan.
7049 * floatfns.c (isnan): #undef, and then #define to a clone of
7050 what's in data.c.
7051 (Fisnan): Always define, since it's always available now.
7052 (syms_of_floatfns): Always define isnan at the Lisp level.
7053
e39b275c 70542011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7055
7056 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7057
b2db44d9 70582011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7059
f4af5137 7060 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7061 The previous code assumed that file offsets (off_t values) fit in
7062 EMACS_INT variables, which is not true on typical 32-bit hosts.
7063 The code messed up by falsely reporting buffer overflow in cases
7064 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7065 when "big" contains more than 2**29 bytes, even though this
7066 inserts just one byte and does not overflow the buffer.
7067 (Finsert_file_contents): Store file offsets as off_t
7068 values, not as EMACS_INT values. Check for overflow when
7069 converting between EMACS_INT and off_t. When checking for
7070 buffer overflow or for overlap, take the offsets into account.
7071 Don't use EMACS_INT for small values where int suffices.
7072 When checking for overlap, fix a typo: ZV was used where
7073 ZV_BYTE was intended.
7074 (Fwrite_region): Don't assume off_t fits into 'long'.
7075 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7076
ecfc0a49
MA
70772011-09-05 Michael Albinus <michael.albinus@gmx.de>
7078
7079 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7080
6511acf2 70812011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7082
0999621a 7083 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7084
7085 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7086 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7087 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7088 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7089 (modify_event_symbol): Do not assume that the length of
7090 name_alist_or_stem is safe to alloca and fits in int.
7091 (Fexecute_extended_command): Likewise for function name and binding.
7092 (Frecursion_depth): Wrap around reliably on integer overflow.
7093 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7094 since some callers pass EMACS_INT values.
7095 (Fsingle_key_description): Don't crash if symbol name contains more
7096 than MAX_ALLOCA bytes.
7097 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7098 (get_minibuffer): Arg is now EMACS_INT, not int.
7099 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7100 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7101 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7102
2be7d702
PE
7103 * dbusbind.c (signature_cat): New function.
7104 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7105 Do not overrun buffer; instead, report string overflow.
7106
9d1df220
PE
7107 * dispnew.c (add_window_display_history): Don't overrun buffer.
7108 Truncate instead; this is OK since it's just a log.
7109
33ef5c64
PE
7110 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7111 even if the time zone offset is outlandishly large.
7112 Don't mishandle offset == INT_MIN.
7113
66c6fdd5
PE
7114 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7115 when creating daemon; the previous buffer-overflow check was incorrect.
7116
d749b01b
PE
7117 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7118 which has the guts of the old verror function.
7119
b5cd1905
PE
7120 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7121 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7122
6e1a67fb
PE
7123 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7124 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7125 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7126 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7127 length of string rather than counting it via multiple sprintfs;
7128 that's simpler and more reliable.
c21721cc
PE
7129 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7130 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7131 sprintf, in case result does not fit in int.
7132
c57b67fc
PE
7133 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7134 (fontset_from_font): Print it.
7135
8a401434
PE
7136 * frame.c (tty_frame_count): Now printmax_t, not int.
7137 (make_terminal_frame, set_term_frame_name): Print it.
7138 (x_report_frame_params): In X, window IDs are unsigned long,
7139 not signed long, so print them as unsigned.
7140 (validate_x_resource_name): Check for implausibly long names,
7141 and don't assume name length fits in 'int'.
7142 (x_get_resource_string): Don't blindly alloca invocation name;
7143 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7144 not fit in int.
7145
6e1a67fb
PE
7146 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7147 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7148 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7149
0df02bf3
PE
7150 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7151 Use esprintf, not sprintf, in case result does not fit in int.
7152
48e30793
PE
7153 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7154 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7155 it as a large positive number.
7156 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7157 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7158
a66ff6d8
PE
7159 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7160 in case result does not fit in int.
7161
aca216ff
PE
7162 * print.c (float_to_string): Detect width overflow more reliably.
7163 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7164 buffer overrun. Don't assume list length fits in 'int'. Treat
7165 print length of 0 as 0, not as infinity; to be consistent with other
7166 uses of print length in this function. Don't overflow print length
7167 index. Don't assume hash table size fits in 'long', or that
7168 vectorlike size fits in 'unsigned long'.
7169
31c286f7
PE
7170 * process.c (make_process): Use printmax_t, not int, to format
7171 process-name gensyms.
7172
55e5faa1
PE
7173 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7174
80f2e268
PE
7175 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7176 to avoid potential buffer overrun.
7177
670741ab
PE
7178 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7179 if X resource line is longer than 512 bytes.
7180
b7163a50
PE
7181 * xfns.c (x_window): Make sprintf buffer a bit bigger
7182 to avoid potential buffer overrun.
7183
ae58ff1f
PE
7184 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7185
c43c8a6a
PE
7186 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7187
3f8236f4
PE
71882011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7189
53e9fe90 7190 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7191 Without these, Emacs silently mishandles large integers sometimes.
7192 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7193 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7194
6511acf2
PE
7195 * xdisp.c (try_window_id): Check Emacs fixnum range before
7196 converting to 'int'.
806add1d 7197
6511acf2 7198 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7199 Check that an Emacs fixnum is in range before assigning it to 'int'.
7200 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7201 values converted from Emacs fixnums.
7202 (Frecenter): Don't wrap around a line count if it is out of 'int'
7203 range; instead, treat it as an extreme value.
7204 (Fset_window_configuration, compare_window_configurations):
7205 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7206
6511acf2
PE
7207 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7208 that can exceed INT_MAX. Check that EMACS_INT value is in range
7209 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7210 (match_limit): Don't assume that a fixnum can fit in 'int'.
7211
6511acf2 7212 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7213 exceed INT_MAX.
7214
6511acf2 7215 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7216 (Fvertical_motion): Don't wrap around LINES values that don't fit
7217 in 'int'. Instead, treat them as extreme values. This is good
7218 enough for windows, which can't have more than INT_MAX lines anyway.
7219
fcb901a7
LMI
72202011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7221
0f2f6b6d
LMI
7222 * Require libxml/parser.h to avoid compilation warning.
7223
fcb901a7
LMI
7224 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7225
7226 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7227 since this reportedly can destroy thread storage.
7228
6e20a0d4
CY
72292011-08-30 Chong Yidong <cyd@stupidchicken.com>
7230
7231 * syntax.c (find_defun_start): Update all cache variables if
7232 exiting early (Bug#9401).
7233
148ae00e
EZ
72342011-08-30 Eli Zaretskii <eliz@gnu.org>
7235
f6cfbd8f
EZ
7236 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7237
148ae00e
EZ
7238 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7239 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7240 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7241
7242 * term.c (tty_append_glyph): New function.
7243 (produce_stretch_glyph): Static function and its prototype deleted.
7244
a66cfb1c
SM
7245 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7246 Add prototypes.
148ae00e 7247
c4a07a4c
PE
72482011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7249
7250 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7251 when checking :margin (Bug#9390).
7252 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7253 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7254 so that the name doesn't mislead. All uses changed.
7255
6bc8cd65
JB
72562011-08-28 Johan Bockgård <bojohan@gnu.org>
7257
7258 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7259 set_tty_hooks.
7260
dca4927e
EZ
72612011-08-27 Eli Zaretskii <eliz@gnu.org>
7262
7263 * xdisp.c (move_it_to): Don't bail out early when reaching
7264 position beyond to_charpos, if we are scanning backwards.
7265 (move_it_vertically_backward): When DY == 0, make sure we get to
7266 the first character in the line after the newline.
7267
f2cad773
PE
72682011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7269
7270 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7271 (ccl_driver): Do not generate an out-of-range pointer.
7272 (Fccl_execute_on_string): Remove unnecessary check for
7273 integer overflow, noted by Stefan Monnier in
7274 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7275 Remove a FIXME that didn't need fixing.
7276 Simplify the newly-introduced buffer reallocation code.
7277
0cae2cdb
JB
72782011-08-27 Juanma Barranquero <lekktu@gmail.com>
7279
7280 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7281
5fc295a4 72822011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7283
70c60eb2 7284 Integer and memory overflow issues (Bug#9196).
726e0ab1 7285
d31850da
PE
7286 * doc.c (get_doc_string): Rework so that
7287 get_doc_string_buffer_size is the actual buffer size, rather than
7288 being 1 less than the actual buffer size; this makes xpalloc more
7289 convenient.
7290
a69fbedb
PE
7291 * image.c (x_allocate_bitmap_record, cache_image):
7292 * xselect.c (Fx_register_dnd_atom):
7293 Simplify previous changes by using xpalloc.
7294
fe5c5d37
PE
7295 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7296 since either will do and ptrdiff_t is convenient with xpalloc.
7297
0065d054
PE
7298 * charset.c (charset_table_size)
7299 (struct charset_sort_data.priority): Now ptrdiff_t.
7300 (charset_compare): Don't overflow if priorities differ greatly.
7301 (Fsort_charsets): Don't assume list length fits in int.
7302 Check for size-calculation overflow when allocating sort data.
7303 (syms_of_charset): Allocate an initial charset table that is
7304 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7305
7306 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7307
7308 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7309 The actual value is always <= INT_MAX, and leaving it unsigned made
7310 overflow checking harder.
7311
7312 * dispextern.h (struct glyph_matrix.rows_allocated)
7313 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7314 with xpalloc. The values are still always <= INT_MAX.
7315
7316 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7317
7318 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7319 (SAFE_NALLOCA): New macro.
7320
7321 * region-cache.c (struct boundary.pos, find_cache_boundary)
7322 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7323 (set_cache_region, invalidate_region_cache)
7324 (revalidate_region_cache, know_region_cache, region_cache_forward)
7325 (region_cache_backward, pp_cache):
7326 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7327 so that ptrdiff_t * can be passed to xpalloc.
7328 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7329 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7330 (pp_cache): Don't assume cache_len fits in int.
7331 * region-cache.h: Adjust extern decls to match.
7332
7333 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7334 EMACS_INT, since either will do, for xpalloc.
7335
7336 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7337 (xnmalloc, xnrealloc, xpalloc): New functions.
7338
726e0ab1
PE
7339 * bidi.c (bidi_shelve_header_size): New constant.
7340 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7341 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7342
51f30bc5 7343 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7344 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7345 (overlay_strings):
7346 Don't update size of array until after memory allocation succeeds,
7347 because xmalloc/xrealloc may not return.
0065d054
PE
7348 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7349 now that we have proper integer overflow checking.
7350 (record_overlay_string, overlay_strings): Catch overflows when
7351 calculating size of overlay_str_buf.
726e0ab1 7352
0065d054
PE
7353 * callproc.c (Fcall_process): Check for size overflow when
7354 calculating size of args2.
7355 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7356 Normally we prefer signed values, but sticking with ptrdiff_t would
7357 require adding more-complicated checks.
726e0ab1
PE
7358
7359 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7360 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7361 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7362 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7363
7364 * character.c (Fstring): Check for size-calculation overflow.
7365
7366 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7367 unnecessary integer overflow. Check for size overflow.
7368 (encode_coding_object): Don't update size until xmalloc succeeds.
7369
7370 * composite.c (get_composition_id): Check for overflow in glyph
7371 length calculations.
7372
7373 Integer and memory overflow fixes for display code.
7374 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7375 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7376 (scrolling_window): Check for overflow in size calculations.
7377 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7378 Don't assume glyph table len fits in int.
7379 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7380 (row_table_size): Now ptrdiff_t, not int.
7381 (scrolling_window): Avoid overflow in size calculations.
7382 Don't update size until allocation succeeds.
7383 * fns.c (concat): Check for overflow in size calculations.
7384 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7385 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7386 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7387
7388 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7389 (get_doc_string): Check for size calculation overflow.
7390 Don't update size until allocation succeeds.
7391 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7392 EMACS_INT, where ptrdiff_t will do.
7393 (Fsubstitute_command_keys): Check for string overflow.
7394
7395 * editfns.c (set_time_zone_rule): Don't assume environment length
7396 fits in int.
7397 (message_length): Now ptrdiff_t, not int.
7398 (Fmessage_box): Don't update size until allocation succeeds.
7399 Don't assume message length fits in int.
7400 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7401
0065d054
PE
7402 * emacs.c (main): Do not reallocate argv, since there is a null at
7403 the end that can be overwritten, and this way there's no need to
7404 worry about size-calculation overflow.
7405 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7406
7407 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7408 alloc succeeds.
7409 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7410
7411 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7412 (x_set_scroll_bar_width, x_figure_window_size):
7413 Check for integer overflow.
7414 (x_set_alpha): Do not assume XINT fits in int.
7415
7416 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7417 This is for the members text_lines, text_cols, total_lines, total_cols,
7418 where the system imposes an 'int' limit.
7419
7420 * fringe.c (Fdefine_fringe_bitmap):
7421 Don't update size until alloc works.
7422
7423 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7424 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7425
7426 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7427 Check for size-calculation overflow.
7428 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7429 do, as we prefer signed integers.
7430 (id_to_widget.max_size, id_to_widget.used)
7431 (xg_store_widget_in_map, xg_remove_widget_from_map)
7432 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7433 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7434 Use and return ptrdiff_t, not int.
7435 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7436 * gtkutil.h: Change prototypes to match the above.
7437
7438 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7439 are duplicate now that they've been promoted to lisp.h.
7440 (x_allocate_bitmap_record, x_alloc_image_color)
7441 (make_image_cache, cache_image, xpm_load):
7442 Don't update size until alloc is done.
7443 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7444 (x_detect_edges):
3256efce 7445 Check for size calculation overflow.
726e0ab1
PE
7446 (ct_colors_allocated_max): New constant.
7447 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7448 overflow.
3256efce 7449
726e0ab1
PE
7450 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7451 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7452 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7453 Use ptrdiff_t, not int, to count maps.
7454 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7455 calculations. Don't update size until allocation succeeds.
7456 Redo calculations to avoid overflow.
726e0ab1
PE
7457 * keyboard.h: Change prototypes to match the above.
7458
7459 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7460 to count maps.
7461 (current_minor_maps): Check for size calculation overflow.
7462 * keymap.h: Change prototypes to match the above.
7463
7464 * lread.c (read1, init_obarray): Don't update size until alloc done.
7465
7466 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7467 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7468
726e0ab1
PE
7469 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7470 Now ptrdiff_t, not int.
7471 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7472 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7473
7474 * process.c (Fnetwork_interface_list): Check for overflow
7475 in size calculation.
7476
7477 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7478
7479 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7480 overflow. Don't bother calling xmalloc when xrealloc will do.
7481
7482 * search.c (Freplace_match): Check for size calculation overflow.
7483 (Fset_match_data): Don't assume list lengths fit in 'int'.
7484
7485 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7486 for command line length. Do not attempt to address one before the
7487 beginning of an array, as that's not portable.
7488
7489 * term.c (max_frame_lines): Remove; unused.
7490 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7491 not int.
7492 (encode_terminal_code, calculate_costs): Check for size
7493 calculation overflow.
7494 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7495 table lengths and related sizes. Don't update size until alloc
7496 done. Redo calculations to avoid overflow.
7497 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7498
7499 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7500 subtracting pointers.
7501 (gobble_line): Check for overflow more carefully. Don't update size
7502 until alloc done.
7503
7504 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7505 Don't update size until alloc done.
7506 Redo size calculations to avoid overflow.
7507 Check for size calculation overflow.
0065d054 7508 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7509
7510 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7511 Use ptrdiff_t, not int, for sizes.
7512 (store_mode_line_noprop_char): Don't update size until alloc done.
7513
0065d054
PE
7514 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7515 Use ptrdiff_t, not int, for sizes.
7516 (Finternal_make_lisp_face, cache_face):
7517 Check for size calculation overflow.
7518 (cache_face): Treat size calculation overflows as if they were
7519 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7520
7521 * xfns.c (x_encode_text, x_set_name_internal)
7522 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7523 sizes, since they can exceed INT_MAX in size. Check for size
7524 calculation overflow.
7525
0065d054
PE
7526 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7527 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7528 Don't update size until alloc done.
7529
0065d054 7530 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7531 as sprintf is limited to int lengths.
1d526e2f 7532
252c5ee1
PE
7533 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7534 (X_LONG_MIN): New macros.
864d7ce7
PE
7535 Use them to make the following changes clearer.
7536 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7537 This change doesn't affect the value now, but it may help remind
7538 future maintainers not to raise the value too much later.
7539 (SELECTION_QUANTUM): Remove, replacing with ...
7540 (selection_quantum): ... new function, which avoids overflow.
7541 All uses changed.
7542 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7543 assumption that selection length fits in 'int'.
7544 (x_reply_selection_request, x_handle_selection_request)
7545 (x_get_window_property, receive_incremental_selection)
7546 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7547 (lisp_data_to_selection_data, clean_local_selection_data):
7548 Use ptrdiff_t, not int, to record length of selection.
7549 (x_reply_selection_request, x_get_window_property)
7550 (receive_incremental_selection, x_property_data_to_lisp):
7551 Redo calculations to avoid overflow.
7552 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7553 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7554 something.
7555 (x_get_window_property, receive_incremental_selection)
7556 (lisp_data_to_selection_data, x_property_data_to_lisp):
7557 Check for size-calculation overflow.
7558 (x_get_window_property, receive_incremental_selection)
7559 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7560 Don't store size until memory allocation succeeds.
7561 (x_get_window_property): Plug memory leak on memory exhaustion.
7562 Don't double-block input; malloc is safe here. Don't assume 2**34
7563 - 4 fits in unsigned long. Add an xassert to check
7564 XGetWindowProperty overflow. Be more careful about overflow
7565 calculations, and distinguish size from memory overflow better.
7566 (receive_incremental_selection): When tracing, don't assume
7567 unsigned int is less than INT_MAX.
7568 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7569 harmful) conversions of unsigned short to int.
7570 (lisp_data_to_selection_data): Don't assume that integers
7571 in the range -65535 through -1 fit in an X unsigned short.
7572 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7573 result parameters unless successful. Rely on cons_to_unsigned
7574 to report problems with elements; the old code wasn't right anyway.
7575 (x_check_property_data): Check for int overflow; we cannot use
7576 a wider type due to X limits.
7577 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7578
726e0ab1 7579 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7580
0065d054
PE
7581 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7582 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7583 (x_color_cells): Don't store size until memory allocation succeeds.
7584 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7585 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7586 (x_term_init): Don't assume length fits in int (sprintf is limited
7587 to int size).
bc18e09d 7588
ebfa62c0
PE
7589 Use ptrdiff_t for composition IDs.
7590 * character.c (lisp_string_width):
7591 * composite.c (composition_table_size, n_compositions)
7592 (get_composition_id, composition_gstring_from_id):
7593 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7594 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7595 * window.c (Frecenter):
7596 Use ptrdiff_t, not int, for composition IDs.
7597 * composite.c (get_composition_id): Check for integer overflow.
7598 * composite.h: Adjust prototypes to match the above changes.
7599
d3411f89
PE
7600 Use ptrdiff_t for hash table indexes.
7601 * category.c (hash_get_category_set):
7602 * ccl.c (ccl_driver):
7603 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7604 * coding.c (coding_system_charset_list, detect_coding_system):
7605 * coding.h (struct coding_system.id):
7606 * composite.c (get_composition_id, gstring_lookup_cache):
7607 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7608 * image.c (xpm_get_color_table_h):
7609 * lisp.h (hash_lookup, hash_put):
7610 * minibuf.c (Ftest_completion):
7611 Use ptrdiff_t for hash table indexes, not int (which is too
7612 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7613 32-bit --with-wide-int hosts).
7614
e097a6fa
PE
7615 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7616 Add a FIXME comment about memory leaks.
7617 (syms_of_charset): Don't assume xmalloc returns.
7618
5637687f
PE
7619 Don't assume that stated character widths fit in int.
7620 * character.c (Fchar_width, c_string_width, lisp_string_width):
7621 * character.h (CHAR_WIDTH):
7622 * indent.c (MULTIBYTE_BYTES_WIDTH):
7623 Use sanitize_char_width to avoid undefined and/or bad behavior
7624 with outlandish widths.
a66cfb1c 7625 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7626 now that we have two such functions. All uses changed.
7627 (sanitize_char_width): New inline function.
7628
a2271ba2
PE
7629 Don't assume that tab-width fits in int.
7630 * character.h (sanitize_width): New inline function.
7631 (SANE_TAB_WIDTH): New macro.
7632 (ASCII_CHAR_WIDTH): Use it.
7633 * indent.c (sane_tab_width): Remove. All uses replaced by
7634 SANE_TAB_WIDTH (current_buffer).
7635 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7636
18c52557
PE
7637 * fileio.c: Integer overflow issues with file modes.
7638 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7639
caeeedc1
PE
7640 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7641 Remove unreachable code.
7642 (read_hex, load_charset_map_from_file): Check for integer overflow.
7643
6df6ae42 7644 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7645 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7646 (x_send_scroll_bar_event): Likewise. Check that the size does not
7647 exceed limits imposed by XClientMessageEvent, as well as the usual
7648 ptrdiff_t and size_t limits.
7649
b13995db
PE
7650 * keyboard.c: Overflow, signedness and related fixes.
7651 (make_lispy_movement): Use same integer type in forward decl
7652 that is used in the definition.
7653 (read_key_sequence, keyremap_step):
7654 Change bufsize argument back to int, undoing my 2011-03-30 change.
7655 We prefer signed types, and int is wide enough here.
7656 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7657 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7658 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7659 length, not size_t. Use ptrdiff_t for index, not int.
7660 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7661 possibility of integer overflow.
7662
13464394
PE
7663 Overflow, signedness and related fixes for images.
7664
7665 * dispextern.h (struct it.stack[0].u.image.image_id)
7666 (struct_it.image_id, struct image.id, struct image_cache.size)
7667 (struct image_cache.used, struct image_cache.ref_count):
7668 * gtkutil.c (update_frame_tool_bar):
7669 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7670 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7671 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7672 * nsmenu.m (update_frame_tool_bar):
7673 * xdisp.c (calc_pixel_width_or_height):
7674 * xfns.c (image_cache_refcount):
7675 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7676 on typical 64-bit hosts.
7677
7678 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7679 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7680 Omit unnecessary casts to int.
7681 (parse_image_spec): Check that integers fall into 'int' range
7682 when the callers expect that.
7683 (image_ascent): Redo ascent calculation to avoid int overflow.
7684 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7685 (lookup_image): Remove unnecessary tests.
7686 (xbm_image_p): Locals are now of int, not EMACS_INT,
7687 since parse_image_check makes sure they fit into int.
7688 (png_load, gif_load, svg_load_image):
7689 Prefer int to unsigned where either will do.
7690 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7691 old tiff_error_handler and tiff_warning_handler.
7692 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7693 stack buffer overflows. It uses only the features of vsnprintf
7694 that are common to both POSIX and native Microsoft.
7695 (tiff_error_handler, tiff_warning_handler): Use it.
7696 (tiff_load, gif_load, imagemagick_load_image):
7697 Don't assume :index value fits in 'int'.
7698 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7699 (imagemagick_load_image): Check that crop parameters fit into
7700 the integer types that MagickCropImage accepts. Don't assume
7701 Vimagemagick_render_type has a nonnegative value. Don't assume
7702 size_t fits in 'long'.
7703 (gs_load): Use printmax_t to print the widest integers possible.
7704 Check for integer overflow when computing image height and width.
7705
c11821d4
EZ
77062011-08-26 Eli Zaretskii <eliz@gnu.org>
7707
7708 * xdisp.c (redisplay_window): Don't force window start if point
7709 will be invisible in the resulting window. (Bug#9324)
7710
0c95fcf7
EZ
77112011-08-25 Eli Zaretskii <eliz@gnu.org>
7712
7713 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7714 the display spec is of the form `(space ...)'.
7715 (handle_display_spec): Return the value returned by
7716 handle_single_display_spec, not just 1 or zero.
7717 (handle_single_display_spec): If the display spec is of the form
7718 `(space ...)', and specifies display in the text area, return 2
7719 rather than 1.
fee65a97 7720 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7721 accurately, and prefer exact match for point under bidi.
7722 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7723
7724 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7725 into disp_prop; all users changed.
7726
7727 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7728 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7729 for the text covered by the display property.
7730
e4ed06f1
CY
77312011-08-25 Chong Yidong <cyd@stupidchicken.com>
7732
7733 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7734 Change return value to nil.
7735 (Frecord_buffer): Delete unused function.
7736
f67cdd7f
EZ
77372011-08-24 Eli Zaretskii <eliz@gnu.org>
7738
5980d4c6
EZ
7739 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7740 buffers, return left-to-right.
8610fe8b
EZ
7741 (set_cursor_from_row): Consider candidate row a win if its glyph
7742 represents a newline and point is on that newline. Fixes cursor
7743 positioning on the newline at EOL of R2L text within L2R
7744 paragraph, and vice versa.
7745 (try_cursor_movement): Check continued rows, in addition to
7746 continuation rows. Fixes unwarranted scroll when point enters a
7747 continued line of R2L text within an L2R paragraph, or vice versa.
7748 (cursor_row_p): Consider the case of point being equal to
7749 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7750 from the end of a short line to the beginning of a continued line
7751 of R2L text within L2R paragraph.
7752 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7753 composed characters.
5980d4c6 7754
f67cdd7f
EZ
7755 * bidi.c (bidi_check_type): Use xassert.
7756 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7757 members.
7758
bca633fb
EZ
77592011-08-23 Eli Zaretskii <eliz@gnu.org>
7760
7761 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7762 a character.
7763
4a5885a7
CY
77642011-08-23 Chong Yidong <cyd@stupidchicken.com>
7765
7766 * nsfont.m (ns_otf_to_script): Fix typo.
7767
0902a04e
KH
77682011-08-22 Kenichi Handa <handa@m17n.org>
7769
7770 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7771 extra slot even if the purpose is char-code-property-table.
7772
1a2e6670
EZ
77732011-08-23 Eli Zaretskii <eliz@gnu.org>
7774
8ddde651
EZ
7775 * xdisp.c (redisplay_window): When computing centering_position,
7776 account for the height of the header line. (Bug#8874)
7777
425cc014
EZ
7778 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7779 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7780 candidate is selected by the mouse, and that candidate has a
7781 composed character under the mouse.
7782
1a2e6670
EZ
7783 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7784 coordinates reported by pos-visible-in-window-p for a composed
7785 character in column zero.
7786
8b76d6f8
SM
77872011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7788
7789 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7790
dac347dd
EZ
77912011-08-22 Eli Zaretskii <eliz@gnu.org>
7792
7793 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7794 consider it a hit if to_charpos is anywhere in the range of the
7795 composed buffer positions.
7796
e013fb34
CY
77972011-08-22 Chong Yidong <cyd@stupidchicken.com>
7798
7799 * image.c (gif_load): Don't assume that each subimage has the same
7800 dimensions as the base image. Handle disposal method that is
7801 "undefined" by the gif spec (Bug#9335).
7802
bd1ba3e8
CY
78032011-08-20 Chong Yidong <cyd@stupidchicken.com>
7804
7805 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7806 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7807
54a1215b
EZ
78082011-08-19 Eli Zaretskii <eliz@gnu.org>
7809
823564e5
EZ
7810 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7811 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7812 from an Org mode buffer to a Speedbar frame.
7813
54a1215b
EZ
7814 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7815 a composition, take its buffer position from IT->cmp_it.charpos.
7816 Fixes cursor positioning at the beginning of a line that begins
7817 with a composed character.
7818
9778ebcc
EZ
78192011-08-18 Eli Zaretskii <eliz@gnu.org>
7820
0be6ee06
EZ
7821 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7822 character bidirectional type, use STRONG_L instead. Fixes crashes
7823 in a buffer produced by `describe-categories'.
7824
9778ebcc
EZ
7825 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7826 members before the level stack, so they would be saved and
7827 restored when copying iterator state. Fixes incorrect reordering
7828 around TABs covered by display properties.
7829
156bffbe
AS
78302011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7831
6b02f655 7832 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7833
72ad093b
CY
78342011-08-17 Chong Yidong <cyd@stupidchicken.com>
7835
7836 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7837 (internal_condition_case_2, internal_condition_case_n):
7838 Remove unnecessary aborts (Bug#9081).
72ad093b 7839
35774242
EZ
78402011-08-17 Eli Zaretskii <eliz@gnu.org>
7841
7842 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7843 has no `load' handler, try opening the file locally. (Bug#9311)
7844
db76dd85
KB
78452011-08-16 Ken Brown <kbrown@cornell.edu>
7846
7847 * gmalloc.c: Expand comment.
7848
b215eee5
EZ
78492011-08-16 Eli Zaretskii <eliz@gnu.org>
7850
7851 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7852 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7853
a4579d33
KB
78542011-08-16 Ken Brown <kbrown@cornell.edu>
7855
7856 Fix memory allocation problems in Cygwin build (Bug#9273).
7857
7858 * unexcw.c ( __malloc_initialized): Declare external variable.
7859 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7860
8b76d6f8
SM
7861 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7862 New variables.
a4579d33
KB
7863 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7864 dumped emacs.
7865 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7866 in the static heap.
7867 [CYGWIN] (special_realloc): New function.
7868 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7869 requests to realloc storage in the static heap.
7870
3ebec551
PE
78712011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7872
7873 * bidi.c (bidi_initialize): Remove unused local.
7874
9fd8be00
EZ
78752011-08-15 Eli Zaretskii <eliz@gnu.org>
7876
6b02f655
SM
7877 * bidimirror.h:
7878 * biditype.h: Remove file.
7879 * makefile.w32-in ($(BLD)/bidi.$(O)):
7880 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7881
7882 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7883
7884 * chartab.c: Improve commentary for the uniprop_table API.
7885
32413314
EZ
7886 * bidi.c (bidi_paragraph_init): Support zero value of
7887 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7888 (bidi_initialize): Use uniprop_table instead of including
7889 biditype.h and bidimirror.h.
32413314 7890
9fd8be00
EZ
7891 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7892 coordinates of the iterator when restoring from ppos_it.
7893 (Bug#9296)
7894
5cf2b69b
KH
78952011-08-14 Kenichi Handa <handa@m17n.org>
7896
7897 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7898 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7899
daf17d00
EZ
79002011-08-14 Eli Zaretskii <eliz@gnu.org>
7901
7902 * xdisp.c (move_it_in_display_line_to): Don't invoke
7903 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7904 ppos_it. Fixes vertical cursor motion when line beginning is
7905 covered by an image. (Bug#9296)
7906
08e3161a
JD
79072011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7908
7909 * nsterm.h (ns_run_ascript): Declare.
7910 (NSAPP_DATA2_RUNASSCRIPT): Define.
7911
7912 * nsfns.m (as_script, as_result, as_status): New static variables.
7913 (ns_run_ascript): New function.
5e617bc2 7914 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7915 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7916 the event loop. Get status from as_status (Bug#7276).
7917
7918 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7919 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7920 the event loop (Bug#7276).
7921
a3720aa2
AS
79222011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7923
7924 * gnutls.c (QCgnutls_bootprop_priority)
7925 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7926 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7927 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7928 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7929 (QCgnutls_bootprop_verify_hostname_error)
7930 (QCgnutls_bootprop_callbacks_verify): Rename from
7931 Qgnutls_bootprop_..., all uses changed.
7932
7933 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7934 uses changed.
7935
0a0d27fb
PE
79362011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7937
19d5c50c
PE
7938 * xfaces.c (Qframe_set_background_mode): Now static.
7939 * dispextern.h (Qframe_set_background_mode): Remove decl.
7940
0a0d27fb
PE
7941 * process.c (Fnetwork_interface_info): Declare local only if needed.
7942
377538cb
JD
79432011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7944
7945 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7946 (Fnetwork_interface_list): Allocate in increments of bytes instead
7947 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7948 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7949 sockaddr.
7950 (struct ifflag_def): notrailers is smart on OSX.
7951 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7952 Get hardware address with getifaddrs if available.
7953
08fff70c
EZ
79542011-08-12 Eli Zaretskii <eliz@gnu.org>
7955
7956 * xdisp.c (iterate_out_of_display_property): xassert that
7957 IT->position is set to within IT->object's boundaries. Break from
7958 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7959 when IT->position is set up wrongly due to some bug.
7960 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7961 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7962 entry. Force push_it to save on the stack the current
7963 buffer/string position, to be restored by pop_it. Fix flags in
7964 the iterator structure wrt the object coming from a display
7965 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7966 properties. (Bug#9284)
7967
7be1c708 79682011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7969
7be1c708
CY
7970 * fontset.c (fontset_get_font_group): Add proper type checks.
7971 (Bug#9172)
aac0c6e3 7972
7be1c708 79732011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7974
7be1c708
CY
7975 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7976 and LC_VERSION_MIN_MACOSX.
7977 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7978 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7979
97bb72a6
EZ
79802011-08-08 Eli Zaretskii <eliz@gnu.org>
7981
7982 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7983 no-display-properties-and-no-overlays under bidi display.
7984 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7985 properties and overlays.
97bb72a6 7986
d5617611
CY
79872011-08-08 Chong Yidong <cyd@stupidchicken.com>
7988
37e11a63
CY
7989 * editfns.c (Fset_time_zone_rule): Document relationship with the
7990 setenv function.
7991
d5617611
CY
7992 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7993 the font entity extracted from the cache (Bug#8109).
7994
58872834
CY
79952011-08-07 Chong Yidong <cyd@stupidchicken.com>
7996
7997 * composite.c (autocmp_chars): Don't reset point. That is done by
7998 restore_point_unwind (Bug#5984).
7999
75bfc667
JL
80002011-08-07 Juri Linkov <juri@jurta.org>
8001
8002 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8003 to show the arg `TIME' instead of `TIMEVAL'.
8004
d1410150
EZ
80052011-08-06 Eli Zaretskii <eliz@gnu.org>
8006
8007 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8008 display property strides EOL and includes a newline, as in
8009 longlines-mode. (Bug#9254)
75b771e4
EZ
8010 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8011 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8012
8013 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8014 is non-zero, even if the data buffer is NULL. Fixes a crash in
8015 vertical-motion with longlines-mode. (Bug#9254)
8016
35928349
EZ
80172011-08-05 Eli Zaretskii <eliz@gnu.org>
8018
ec7cc85b
EZ
8019 * bidi.c <bidi_cache_total_alloc>: Now static.
8020 (bidi_initialize): Initialize bidi_cache_total_alloc.
8021
8b76d6f8 8022 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8023 cache. (Bug#9221)
8024
8025 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8026 amount allocated this far in `bidi_cache_total_alloc'.
8027 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8028 non-zero, only free the data buffer without restoring the cache
8029 contents. All callers changed.
8030
8031 * dispextern.h (bidi_unshelve_cache): Update prototype.
8032
8033 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8034 (move_it_in_display_line, move_it_to)
8035 (move_it_vertically_backward, move_it_by_lines): Replace the call
8036 to xfree to an equivalent call to bidi_unshelve_cache.
8037 (move_it_in_display_line_to): Fix logic of returning
412b6358 8038 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8039
e2e2423b
EZ
80402011-08-05 Eli Zaretskii <eliz@gnu.org>
8041
8042 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8043 came from a string character with a `cursor' property. (Bug#9229)
8044
ae9e757a
JD
80452011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8046
8047 * Makefile.in (LIB_PTHREAD): New variable.
8048 (LIBES): Add LIB_PTHREAD (Bug#9216).
8049
8050 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8051 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8052
213bd7f2
AS
80532011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8054
6b02f655 8055 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8056
99aaf75f
JD
80572011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8058
8059 * xterm.c (x_find_topmost_parent): New function.
8060 (x_set_frame_alpha): Find topmost parent window with
8061 x_find_topmost_parent and set the property there also (bug#9181).
8062 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8063
c74e9d86
PE
80642011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8065
8066 * callproc.c (Fcall_process): Avoid vfork clobbering
8067 the local vars buffer, coding_systems, current_dir.
8068
640c8776
SM
80692011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8070
8071 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8072
f26d0e4c
PE
80732011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8074
8a10d76c
PE
8075 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8076 so that it is not optimized away.
8077
f26d0e4c
PE
8078 * xdisp.c (compute_display_string_pos): Remove unused local.
8079
55439c61
EZ
80802011-08-02 Eli Zaretskii <eliz@gnu.org>
8081
8082 Fix slow cursor motion and scrolling in large buffers with
8083 selective display, like Org Mode buffers. (Bug#9218)
8084
8085 * dispextern.h (struct bidi_it): New member disp_prop_p.
8086
8087 * xdisp.c: Remove one-slot cache of display string positions.
8088 (compute_display_string_pos): Accept an additional argument
5e617bc2 8089 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8090 for a display string or property. If found, set DISP_PROP_P
8091 non-zero.
8092
8093 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8094 DISP_PROP_P, and pass it to compute_display_string_pos.
8095 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8096 non-zero. All callers of bidi_fetch_char changed.
8097
fb33fa43
SM
80982011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8099
8100 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8101
b099e063
DM
81022010-12-03 Don March <don@ohspite.net>
8103
8104 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8105 last character M-[char] is translated to ESC [char] (bug#7541).
8106
5cc7f7af
KH
81072011-08-02 Kenichi Handa <handa@m17n.org>
8108
d0fffa3f 8109 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8110
8111 * chartab.c (uniprop_table): Make it non-static.
8112
525d5e6e
EZ
81132011-08-01 Eli Zaretskii <eliz@gnu.org>
8114
8115 * xdisp.c (forward_to_next_line_start): Accept additional argument
8116 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8117 on the newline.
8118 (reseat_at_next_visible_line_start): Use the bidi iterator state
8119 returned by forward_to_next_line_start to restore the state of
8120 it->bidi_it after backing up to previous newline. (Bug#9212)
8121
31011111
AS
81222011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8123
8124 * regex.c (re_comp): Protoize.
8125 (re_exec): Fix return type.
8126 (regexec): Fix type of `ret'. (Bug#9203)
8127
476371c4
PE
81282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8129
e5d76069
PE
8130 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8131 This is needed if max-image-size is a floating-point number.
8132
9a79b20c
AS
81332011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8134
8135 * print.c (print_object): Print empty symbol as ##.
8136
8137 * lread.c (read1): Read ## as empty symbol.
8138
d8c2fa78
AA
81392011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8140
8141 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8142 setting frame foreground color (Bug#9175).
8143 (x_set_background_color): Likewise.
8144
ffe57a7a
AA
8145 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8146 contents (Bug#9176).
8147 (EmacsTooltip -init): Remove bezels and add shadows to
8148 tooltip windows.
8149
bf3492a5
AA
8150 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8151 or scroll bar (Bug#8470).
8152
d55e9c53
AA
8153 * nsfont.m (nsfont_open): Remove assignment to voffset and
8154 unnecessary vars hshink, expand, hd, full_height, min_height.
8155 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8156
8157 * nsterm.h (nsfont_info): Remove voffset field.
8158
d8c2fa78 81592011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8160
8161 Implement strike-through and overline on NextStep (Bug#8863).
8162
8163 * nsfont.m (nsfont_open): Use underline position provided by font,
8164 instead of hard-coded value of 2.
8165 (nsfont_draw): Call ns_draw_text_decoration instead.
8166
8167 * nsterm.h: Add declaration for ns_draw_text_decoration.
8168
8169 * nsterm.m (ns_draw_text_decoration): New function for drawing
8170 underline, overline, and strike-through.
8171 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8172 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8173 accommodate underlining, etc.
4843aac3 8174
4cc60b9b
EZ
81752011-07-28 Eli Zaretskii <eliz@gnu.org>
8176
bc7ece87
EZ
8177 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8178 default.
4cc60b9b 8179
476371c4
PE
81802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8181
66606eea
PE
8182 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8183 Without this fix, if a signal arrives just after memory fills up,
8184 'malloc' might be invoked reentrantly.
8185
476371c4
PE
8186 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8187 In other words, assume that every image size is allowed, on non-X
8188 hosts. This assumption is probably wrong, but it lets Emacs compile.
8189
f3fcc40d
AS
81902011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8191
8192 * regex.c (re_iswctype): Convert return values to boolean.
8193
350c992f
EZ
81942011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8195
8196 * xdisp.c (compute_display_string_pos): Don't use cached display
8197 string position if the buffer had its restriction changed.
8198 (Bug#9184)
8199
5266b4bb
PE
82002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8201
8202 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8203
2573a837 82042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8205
41f55ccd 8206 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8207
39e378da
PE
8208 * bidi.c: Integer size and overflow fixes.
8209 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8210 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8211 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8212 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8213 (bidi_find_other_level_edge):
8214 Use ptrdiff_t instead of EMACS_INT where either will do.
8215 This works better on 32-bit hosts configured --with-wide-int.
8216 (bidi_cache_ensure_space): Check for size-calculation overflow.
8217 Use % rather than repeated addition, for better worst-case speed.
8218 Don't set bidi_cache_size until after xrealloc returns, because it
8219 might not return.
8220 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8221 (bidi_cache_ensure_space): Also check that the bidi cache size
8222 does not exceed that of the largest Lisp string or buffer. See Eli
8223 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8224
5e927815
PE
8225 * alloc.c (__malloc_size_t): Remove.
8226 All uses replaced by size_t. See Andreas Schwab's note
8227 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8228
ca4aa935
PE
8229 * image.c: Improve checking for integer overflow.
8230 (check_image_size): Assume that f is nonnull, since
8231 it is always nonnull in practice. This is one less thing to
8232 worry about when checking for integer overflow later.
8233 (x_check_image_size): New function, which checks for integer
8234 overflow issues inside X.
8235 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8236 This removes the need for a memory_full check.
8237 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8238 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8239 (xbm_read_bitmap_data): Change locals back to 'int', since
8240 their values must fit in 'int'.
8241 (xpm_load_image, png_load, tiff_load):
8242 Invoke x_create_x_image_and_pixmap earlier,
8243 to avoid much needless work if the image is too large.
8244 (tiff_load): Treat overly large images as if
8245 x_create_x_image_and_pixmap failed, not as malloc failures.
8246 (gs_load): Use x_check_image_size.
8247
5f8f9cc2
PE
8248 * gtkutil.c: Omit integer casts.
8249 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8250 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8251
5adf60bc
PE
8252 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8253
c8907a93
PE
8254 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8255 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8256 would wrongly return t on a 64-bit host.
8257
e3c25c68
PE
8258 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8259 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8260 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8261 and therefore cause GCC to emit a bogus diagnostic in some cases.
8262
3f791afe
PE
8263 * image.c: Integer signedness and overflow and related fixes.
8264 This is not an exhaustive set of fixes, but it's time to
8265 record what I've got.
8266 (lookup_pixel_color, check_image_size): Remove redundant decls.
8267 (check_image_size): Don't assume that arbitrary EMACS_INT values
8268 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8269 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8270 (tiff_load, imagemagick_load_image):
8271 Check for overflow in size calculations.
8272 (x_create_x_image_and_pixmap): Remove unnecessary test for
8273 xmalloc returning NULL; that can't happen.
8274 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8275 (xpm_color_bucket): Use better integer hashing function.
8276 (xpm_cache_color): Don't possibly over-allocate memory.
8277 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8278 (gif_memory_source):
8279 Use ptrdiff_t, not int or size_t, to record sizes.
8280 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8281 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8282 either works, as we prefer signed integers.
8283 (tiff_read_from_memory, tiff_write_from_memory):
8284 Return tsize_t, not size_t, since that's what the TIFF API wants.
8285 (tiff_read_from_memory): Don't fail simply because the read would
8286 go past EOF; instead, return a short read.
8287 (tiff_load): Omit no-longer-needed casts.
8288 (Fimagemagick_types): Don't assume size fits into 'int'.
8289
3cc5a532
PE
8290 Improve hashing quality when configured --with-wide-int.
8291 * fns.c (hash_string): New function, taken from sxhash_string.
8292 Do not discard information about ASCII character case; this
8293 discarding is no longer needed.
8294 (sxhash-string): Use it. Change sig to match it. Caller changed.
8295 * lisp.h: Declare it.
8296 * lread.c (hash_string): Remove, since we now use fns.c's version.
8297 The fns.c version returns a wider integer if --with-wide-int is
8298 specified, so this should help the quality of the hashing a bit.
8299
b312a492
PE
8300 * emacs.c: Integer overflow minor fix.
8301 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8302 Define only if GNU_LINUX.
8303 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8304
dfd153ae
PE
8305 * dispnew.c: Integer signedness and overflow fixes.
8306 Remove unnecessary forward decls, that were a maintenance hassle.
8307 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8308 All uses changed.
8309 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8310 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8311 (prepare_desired_row, line_draw_cost):
8312 Use int, not unsigned, where either works.
8313 (save_current_matrix, restore_current_matrix):
8314 Use ptrdiff_t, not size_t, where either works.
8315 (init_display): Check for overflow more accurately, and without
8316 relying on undefined behavior.
8317
a81d11a3
PE
8318 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8319 Remove, replacing with the new symbols in lisp.h. All uses changed.
8320 * fileio.c (make_temp_name):
8321 * filelock.c (lock_file_1, lock_file):
8322 * xdisp.c (message_dolog):
8323 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8324 Use pMd etc. instead.
8325 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8326 replacing the pWIDE etc. symbols removed from editfns.c.
8327
3300e6fd
PE
8328 * keyboard.h (num_input_events): Now uintmax_t.
8329 This is (very slightly) less likely to mess up due to wraparound.
8330 All uses changed.
8331
fd05c7e9
PE
8332 * buffer.c: Integer signedness fixes.
8333 (alloc_buffer_text, enlarge_buffer_text):
8334 Use ptrdiff_t rather than size_t when either will do, as we prefer
8335 signed integers.
8336
903fe15d
PE
8337 * alloc.c: Integer signedness and overflow fixes.
8338 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8339 (__malloc_size_t): Default to size_t, not to int.
8340 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8341 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8342 Prefer ptrdiff_t to size_t when either would do, as we prefer
8343 signed integers.
8344 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8345 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8346 Now const. Initialize with values that are in range even if char
8347 is signed.
8348 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8349 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8350 These functions do the right thing with sizes > 2**32.
8351 (check_depth): Now ptrdiff_t, not int.
8352 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8353 Adjust to new way of storing sizes. Check for size overflow bugs
8354 in rest of code.
8355 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8356 slightly wrong anyway, as it missed one instance of
8357 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8358 (refill_memory_reserve): Omit needless cast to size_t.
8359 (mark_object_loop_halt): Mark as externally visible.
8360
ac82cc6a
PE
8361 * xselect.c: Integer signedness and overflow fixes.
8362 (Fx_register_dnd_atom, x_handle_dnd_message):
8363 Use ptrdiff_t, not size_t, since we prefer signed.
8364 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8365 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8366 x_dnd_atoms_size and x_dnd_atoms_length.
8367
c2d1e36d
PE
8368 * doprnt.c: Prefer signed to unsigned when either works.
8369 * eval.c (verror):
8370 * doprnt.c (doprnt):
8371 * lisp.h (doprnt):
8372 * xdisp.c (vmessage):
8373 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8374 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8375 prefer signed arithmetic to avoid comparison confusion.
8376 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8377 but is a bit tricky.
8378
0e926e56
PE
8379 Assume freestanding C89 headers, string.h, stdlib.h.
8380 * data.c, doprnt.c, floatfns.c, print.c:
8381 Include float.h unconditionally.
8382 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8383 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8384 * regex.c: Likewise for stddef.h, string.h.
8385 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8386 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8387 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8388 (STDC_HEADERS): Remove obsolete defines.
8389 * sysdep.c: Include limits.h unconditionally.
8390
9cfdb3ec
PE
8391 Assume support for memcmp, memcpy, memmove, memset.
8392 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8393 * regex.c (memcmp, memcpy):
8394 Remove; we assume C89 now.
8395
8396 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8397 (__malloc_safe_bcopy): Remove; no longer needed.
8398
cf950e6b 8399 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8400 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8401 well either way, and we prefer signed to unsigned.
8402
dbf38e02
LMI
84032011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8404
8405 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8406 closes the connection while we're reading (bug#9182).
8407
d6f0886c 84082011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8409
d6f0886c
JD
8410 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8411 are specified (Bug#9168).
24e0f6b1 8412
2eb1f9e6
PE
84132011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8414
8415 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8416 Found by GCC static checking and --with-wide-int on a 32-bit host.
8417
22381272 84182011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8419
8420 * xdisp.c (compute_display_string_pos): Fix logic of caching
8421 previous display string position. Initialize cached_prev_pos to
8422 -1. Fixes slow-down at the beginning of a buffer.
8423
f25e39b4
EZ
84242011-07-24 Eli Zaretskii <eliz@gnu.org>
8425
8426 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8427 for attrs[LFACE_FONTSET_INDEX].
8428
04c4b52e
PE
84292011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8430
8431 * xml.c (parse_region): Remove unused local
8432 that was recently introduced.
8433
c1734fbd
EZ
84342011-07-23 Eli Zaretskii <eliz@gnu.org>
8435
be18c5a5
EZ
8436 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8437 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8438
c1734fbd
EZ
8439 * xdisp.c (move_it_in_display_line_to): Record the best matching
8440 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8441 exit if none of the characters scanned was an exact match.
8442 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8443 when exact match is impossible due to invisible text, and the
8444 lines are truncated.
8445
a258d627
JD
84462011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8447
8448 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8449 for OSX >= 10.7.
8450
b6d5a689
EZ
84512011-07-22 Eli Zaretskii <eliz@gnu.org>
8452
0f74f785
EZ
8453 Fix a significant slow-down of cursor motion with C-n, C-p,
8454 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8455 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8456 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8457 (next_element_from_buffer): Call compute_stop_pos_backwards to
8458 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8459 base_level_stop.
8460 (reseat): Don't look for prev_stop, as that could mean a very long
8461 run.
8462 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8463 <cached_disp_overlay_modiff>: Cache for last found display string
8464 position.
551918c1 8465 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8466 about the same buffer in the same area of character positions, and
8467 the buffer wasn't changed since the time the display string
8468 position was cached.
551918c1 8469
b2d0c91a
EZ
84702011-07-22 Eli Zaretskii <eliz@gnu.org>
8471
8472 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8473 is an integer, which is important for empty lines. (Bug#9149)
8474
043604ee
CY
84752011-07-22 Chong Yidong <cyd@stupidchicken.com>
8476
8477 * frame.c (Fmodify_frame_parameters): In tty case, update the
8478 default face if necessary (Bug#4238).
8479
da4adb04
CY
84802011-07-21 Chong Yidong <cyd@stupidchicken.com>
8481
8482 * editfns.c (Fstring_to_char): No need to explain what a character
8483 is in the docstring (Bug#6576).
8484
9abd0532
LMI
84852011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8486
8487 * xml.c (parse_region): Make sure we always return a tree.
8488
36881d16
HK
84892011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8490
8491 * xml.c (parse_region): If a document contains only comments,
8492 return that, too.
8493
1e98674d
LMI
84942011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8495
8496 * xml.c (make_dom): Return comments, too.
8497
590bd467
PE
84982011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8499
8500 Port to OpenBSD.
8501 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8502 and the surrounding thread.
8503 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8504 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8505 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8506 timer goes off.
8507 * s/openbsd.h (BROKEN_SIGIO): Define.
8508 * unexelf.c (unexec) [__OpenBSD__]:
8509 Don't update the .mdebug section of the Alpha COFF symbol table.
8510
f41628b2
LMI
85112011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8512
8513 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8514 (bug#8460).
8515
b59b67c5
PE
85162011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8517
15e3a074
PE
8518 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8519 This fixes some race conditions on the permissions of any newly
8520 created file.
8521
41bed37d
PE
8522 * alloc.c (valid_pointer_p): Use pipe, not open.
8523 This fixes some permissions issues when debugging.
8524
b59b67c5
PE
8525 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8526 If fchown fails to set both uid and gid, try to set just gid,
8527 as that is sometimes allowed. Adjust the file's mode to eliminate
8528 setuid or setgid bits that are inappropriate if fchown fails.
8529
925a6be7
SM
85302011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8531
8532 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8533 to compare Lisp_Objects.
8534 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8535 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8536 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8537
52968808
AS
85382011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8539
0a6a104b
AS
8540 * lread.c (read_integer): Unread even EOF character.
8541 (read1): Likewise. Properly record start position of symbol.
8542
52968808
AS
8543 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8544 symbol character follows.
8545
9e381cdd
PE
85462011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8547
8548 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8549 This works around a problem with the previous change to Fcopy_file.
8550 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8551 and without this change, GCC might complain about discarding
8552 fchown's return value.
8553
b5641435
JB
85542011-07-16 Juanma Barranquero <lekktu@gmail.com>
8555
8556 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8557
a8031457
PE
85582011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8559
8560 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8561
dd889327
LMI
85622011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8563
750c33f7
LMI
8564 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8565 it's used from the C level.
8566
dd889327
LMI
8567 * process.c: Use the same condition for POLL_FOR_INPUT in both
8568 keyboard.c and process.c (bug#1858).
8569
87e86684
LM
85702011-07-09 Lawrence Mitchell <wence@gmx.li>
8571
8572 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8573 (Fgnutls_boot): Use it.
8574
64348f40
AS
85752011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8576
8577 * doc.c (Fsubstitute_command_keys): Revert last change.
8578
1d698799
LMI
85792011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8580
f863868c
LMI
8581 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8582 quotes the next character, and doesn't affect other longer
8583 sequences (bug#8935).
8584
1d698799
LMI
8585 * lread.c (syms_of_lread): Clarify that is isn't only
8586 `eval-buffer' and `eval-defun' that's affected by
8587 `lexical-binding' (bug#8460).
8588
aa4b6df6
EZ
85892011-07-15 Eli Zaretskii <eliz@gnu.org>
8590
8591 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8592 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8593
5d856da6
PE
85942011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8595
ad6042bb
PE
8596 Fix minor problems found by static checking.
8597 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8598 (elsz): Now a signed constant, not a size_t var. We prefer signed
8599 types to unsigned, to avoid integer comparison confusion. Without
8600 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8601 "cannot optimize loop, the loop counter may overflow", a symptom
8602 of the confusion.
f00bbb22 8603 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8604 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8605
6468f31c
LMI
86062011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8607
49080b10
LMI
8608 * search.c (Fre_search_backward): Mention `case-fold-search' in
8609 all the re_search_* functions (bug#8138).
8610
6468f31c
LMI
8611 * keyboard.c (Fopen_dribble_file): Document when the file is
8612 closed (bug#8056).
8613
c965adc5
EZ
86142011-07-14 Eli Zaretskii <eliz@gnu.org>
8615
df9733bf
EZ
8616 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8617 bidi_cache_idx.
8618
0bb23927
EZ
8619 Support bidi reordering of display and overlay strings.
8620 * xdisp.c (compute_display_string_pos)
8621 (compute_display_string_end): Accept additional argument STRING.
8622 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8623 (reseat_to_string): Initialize bidi_it->string.s and
8624 bidi_it->string.schars.
8625 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8626 NULL (avoids a crash in bidi_paragraph_init).
8627 Initialize itb.string.lstring.
0bb23927
EZ
8628 (init_iterator): Call bidi_init_it only of a valid
8629 buffer position was specified. Initialize paragraph_embedding to
8630 L2R.
8631 (reseat_to_string): Initialize the bidi iterator.
8632 (display_string): If we need to ignore text properties of
8633 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8634 original value of -1 will not work with bidi.)
8635 (compute_display_string_pos): First arg is now struct
8636 `text_pos *'; all callers changed. Support display properties on
8637 Lisp strings.
8638 (compute_display_string_end): Support display properties on Lisp
8639 strings.
8640 (init_iterator, reseat_1, reseat_to_string): Initialize the
8641 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8642 when iterating on a string not from display properties).
640c8776
SM
8643 (compute_display_string_pos, compute_display_string_end):
8644 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8645 arrow keys.
8646 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8647 base_level_stop; instead, set base_level_stop to BEGV.
8648 Fixes crashes in vertical-motion.
0bb23927
EZ
8649 (next_element_from_buffer): Improve commentary for when
8650 the iterator is before prev_stop.
8651 (init_iterator): Initialize bidi_p from the default value of
8652 bidi-display-reordering, not from buffer-local value. Use the
8653 buffer-local value only if initializing for buffer iteration.
8654 (handle_invisible_prop): Support invisible properties on strings
8655 that are being bidi-reordered.
8656 (set_iterator_to_next): Support bidi reordering of C strings and
8657 Lisp strings.
8658 (next_element_from_string): Support bidi reordering of Lisp
8659 strings.
8660 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8661 (display_string): Support display of R2L glyph rows.
8662 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8663 (init_iterator): Don't initialize it->bidi_p for strings
8664 here.
8665 (reseat_to_string): Initialize it->bidi_p for strings here.
8666 (next_element_from_string, next_element_from_c_string)
8667 (next_element_from_buffer): Add xassert's for correspondence
8668 between IT's object being iterated and it->bidi_it.string
8669 structure.
8670 (face_before_or_after_it_pos): Support bidi iteration.
8671 (next_element_from_c_string): Handle the case of the first string
8672 character that is not the first one in the visual order.
8673 (get_visually_first_element): New function, refactored from common
8674 parts of next_element_from_buffer, next_element_from_string, and
8675 next_element_from_c_string.
8676 (tool_bar_lines_needed, redisplay_tool_bar)
8677 (display_menu_bar): Force left-to-right direction. Add a FIXME
8678 comment for making that be controlled by a user option.
8679 (push_it, pop_it): Save and restore the state of the
8680 bidi iterator. Save and restore the bidi_p flag.
8681 (pop_it): Iterate out of display property for string iteration as
8682 well.
8683 (iterate_out_of_display_property): Support iteration over strings.
8684 (handle_single_display_spec): Set up it->bidi_it for iteration
8685 over a display string, and call bidi_init_it.
8686 (handle_single_display_spec, next_overlay_string)
8687 (get_overlay_strings_1, push_display_prop): Set up the bidi
8688 iterator for displaying display or overlay strings.
8689 (forward_to_next_line_start): Don't use the shortcut if
8690 bidi-iterating.
8691 (back_to_previous_visible_line_start): If handle_display_prop
8692 pushed the iterator stack, restore the internal state of the bidi
8693 iterator by calling bidi_pop_it same number of times.
8694 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8695 and we are bidi-iterating, don't decrement the iterator position;
8696 instead, set the first_elt flag in the bidi iterator, to produce
8697 the same effect.
8698 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8699 (push_display_prop): xassert that we are iterating a buffer.
8700 (push_it, pop_it): Save and restore paragraph_embedding member.
8701 (handle_single_display_spec, next_overlay_string)
8702 (get_overlay_strings_1, reseat_1, reseat_to_string)
8703 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8704 correctly. Don't assume unibyte strings are not bidi-reordered.
8705 (compute_display_string_pos)
8706 (compute_display_string_end): Fix handling the case of C string.
8707 (push_it, pop_it): Save and restore from_disp_prop_p.
8708 (handle_single_display_spec, push_display_prop): Set the
8709 from_disp_prop_p flag.
8710 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8711 (pop_it): Call iterate_out_of_display_property only if we are
8712 popping after iteration over a string that came from a display
8713 property. Fix a typo in popping stretch info. Add an assertion
8714 for verifying that the iterator position is in sync with the bidi
8715 iterator.
8716 (handle_single_display_spec, get_overlay_strings_1)
8717 (push_display_prop): Fix initialization of paragraph direction for
8718 string when that of the parent object is not yet determined.
8719 (reseat_1): Call bidi_init_it to resync the bidi
8720 iterator with IT's position. (Bug#7616)
8721 (find_row_edges): If ROW->start.pos gives position
8722 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8723 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8724 Reset the from_disp_prop_p flag.
8725 (SAVE_IT, RESTORE_IT): New macros.
8726 (pos_visible_p, face_before_or_after_it_pos)
8727 (back_to_previous_visible_line_start)
8728 (move_it_in_display_line_to, move_it_in_display_line)
8729 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8730 (try_scrolling, redisplay_window, display_line): Use them when
8731 saving a temporary copy of the iterator and restoring it back.
8732 (back_to_previous_visible_line_start, reseat_1)
8733 (init_iterator): Empty the bidi cache "stack".
8734 (move_it_in_display_line_to): If iterator ended up at
8735 EOL, but we never saw any buffer positions smaller than
8736 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8737 motion in bidi-reordered lines.
8738 (move_it_in_display_line_to): Record prev_method and prev_pos
8739 immediately before the call to set_iterator_to_next. Fixes cursor
8740 motion in bidi-reordered lines with stretch glyphs and strings
8741 displayed in margins. (Bug#8133) (Bug#8867)
8742 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8743 TO_CHARPOS.
640c8776
SM
8744 (pos_visible_p): Support positions in bidi-reordered lines.
8745 Save and restore bidi cache.
0bb23927
EZ
8746
8747 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8748 (bidi_paragraph_info): Delete unused struct.
8749 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8750 (bidi_cache_start): New variable.
8751 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8752 to zero.
8753 (bidi_cache_fetch_state, bidi_cache_search)
8754 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8755 (bidi_cache_find, bidi_peek_at_next_level)
8756 (bidi_level_of_next_char, bidi_find_other_level_edge)
8757 (bidi_move_to_visually_next): Compare cache index with
8758 bidi_cache_start rather than with zero.
8759 (bidi_fetch_char): Accept new argument STRING; all callers
8760 changed. Support iteration over a string. Support strings with
8761 display properties. Support unibyte strings. Fix the type of
8762 `len' according to what STRING_CHAR_AND_LENGTH expects.
8763 (bidi_paragraph_init, bidi_resolve_explicit_1)
8764 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8765 (bidi_level_of_next_char, bidi_move_to_visually_next):
8766 Support iteration over a string.
0bb23927
EZ
8767 (bidi_set_sor_type, bidi_resolve_explicit_1)
8768 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8769 can now be zero (for strings); special values 0 and -1 were
8770 changed to -1 and -2, respectively.
8771 (bidi_char_at_pos): New function.
8772 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8773 Call it instead of FETCH_MULTIBYTE_CHAR.
8774 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8775 initialized to valid values.
8776 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8777 values.
8778 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8779 the test for valid cached positions. Fix the logic for looking up
8780 the sentinel state in the cache. GCPRO the Lisp string we are
8781 iterating.
8782 (bidi_push_it, bidi_pop_it): New functions.
8783 (bidi_initialize): Initialize the bidi cache start stack pointer.
8784 (bidi_cache_ensure_space): New function, refactored from part of
8785 bidi_cache_iterator_state. Don't assume the required size is just
8786 one BIDI_CACHE_CHUNK away.
8787 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8788 (bidi_count_bytes, bidi_char_at_pos): New functions.
8789 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8790 always valid if bidi_cache_idx is valid.
8791 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8792 is valid if it's going to be used.
8793 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8794 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8795 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8796 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8797 (bidi_find_other_level_edge, bidi_cache_start_stack):
8798 All variables related to cache indices are now EMACS_INT.
c965adc5 8799
0bb23927
EZ
8800 * dispextern.h (struct bidi_string_data): New structure.
8801 (struct bidi_it): New member `string'. Make flag members be 1-bit
8802 fields, and put them last in the struct.
640c8776
SM
8803 (compute_display_string_pos, compute_display_string_end):
8804 Update prototypes.
0bb23927
EZ
8805 (bidi_push_it, bidi_pop_it): Add prototypes.
8806 (struct iterator_stack_entry): New members bidi_p,
8807 paragraph_embedding, and from_disp_prop_p.
8808 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8809 (bidi_shelve_cache, bidi_unshelve_cache):
8810 Declare prototypes.
0bb23927
EZ
8811
8812 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8813 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8814 and vector-like objects.
8815
8816 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8817 cache around display iteration.
8818
8819 * window.c (Fwindow_end, window_scroll_pixel_based)
8820 (displayed_window_lines, Frecenter): Save and restore the bidi
8821 cache around display iteration.
8822
3bbd2265
LMI
88232011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8824
8825 * editfns.c (Fdelete_region): Clarify the use of the named
8826 parameters (bug#6788).
8827
adc47434
MR
88282011-07-14 Martin Rudalics <rudalics@gmx.at>
8829
8830 * indent.c (Fvertical_motion): Set and restore w->pointm when
8831 saving and restoring the window's buffer (Bug#9006).
8832
837c31f8
LMI
88332011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8834
8835 * editfns.c (Fstring_to_char): Clarify just what is returned
8836 (bug#6576). Text by Eli Zaretskii.
8837
ac389d0c
JB
88382011-07-13 Juanma Barranquero <lekktu@gmail.com>
8839
8840 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8841
0be0ce47
EZ
88422011-07-13 Eli Zaretskii <eliz@gnu.org>
8843
8844 * buffer.c (mmap_find): Fix a typo.
8845
cd18e7e3
JB
88462011-07-13 Johan Bockgård <bojohan@gnu.org>
8847
8848 Fix execution of x selection hooks.
8849 * xselect.c (Qx_lost_selection_functions)
8850 (Qx_sent_selection_functions): New vars.
8851 (syms_of_xselect): DEFSYM them.
8852 (x_handle_selection_request): Pass Qx_sent_selection_functions
8853 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8854 (x_handle_selection_clear,x_clear_frame_selections):
8855 Pass Qx_lost_selection_functions rather than
8856 Vx_lost_selection_functions to Frun_hook_with_args.
8857
47ea7f44
PE
88582011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8859
ac389d0c 8860 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8861 The old code sometimes used this field without initializing it.
8862
47ea7f44
PE
8863 * alloc.c (gc_sweep): Don't read past end of array.
8864 In theory, the old code could also have corrupted Emacs internals,
8865 though it'd be very unlikely.
8866
bc985c87
AS
88672011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8868
8869 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8870 argument. (Bug#4026)
bc985c87 8871
0cf34688
LMI
88722011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8873
b3dadd76
LMI
8874 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8875 key" (bug#4257).
8876
0cf34688
LMI
8877 * window.c (Fset_window_start): Doc fix (bug#4199).
8878 (Fset_window_hscroll): Ditto.
8879
270768cd
PE
88802011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8881
077e3dda 8882 Fix minor new problems caught by GCC 4.6.1.
270768cd 8883 * term.c (init_tty): Remove unused local.
490011a6 8884 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8885 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8886 not used otherwise.
270768cd 8887
b1f58454
CY
88882011-07-12 Chong Yidong <cyd@stupidchicken.com>
8889
8890 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8891
22b9578d
LMI
88922011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8893
6e70ab07
LMI
8894 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8895 are the mini-buffer and the echo area (bug#3320).
8896
22b9578d
LMI
8897 * term.c (init_tty): Remove support for supdup, c10 and perq
8898 terminals, which are no longer supported (bug#1482).
8899
8974cc9f
JB
89002011-07-10 Johan Bockgård <bojohan@gnu.org>
8901
8902 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8903
a560d974
JD
89042011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8905
8906 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8907 for non-popups (Bug#3642).
8908
1dae0f0a
AS
89092011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8910
268c2c36 8911 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8912 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8913 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8914 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8915 * data.c (fmod): Likewise.
8916 * dispnew.c (swap_glyphs_in_rows): Likewise.
8917 * emacs.c (memory_warning_signal): Likewise.
8918 * floatfns.c (float_error): Likewise.
8919 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8920 (otf_open, font_otf_capability, generate_otf_features)
8921 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8922 Likewise.
8923 * image.c (pbm_read_file): Likewise.
8924 * indent.c (string_display_width): Likewise.
8925 * intervals.c (check_for_interval, search_for_interval)
8926 (inc_interval_count, count_intervals, root_interval)
8927 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8928 * lread.c (defalias): Likewise.
268c2c36 8929 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8930 * regex.c (set_image_of_range_1, set_image_of_range)
8931 (regex_grow_registers): Likewise.
8932 * sysdep.c (strerror): Likewise.
8933 * termcap.c (valid_filename_p, tprint, main): Likewise.
8934 * tparam.c (main): Likewise.
8935 * unexhp9k800.c (run_time_remap, save_data_space)
8936 (update_file_ptrs, read_header, write_header, calculate_checksum)
8937 (copy_file, copy_rest, display_header): Likewise.
8938 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8939 Likewise.
8940 * xdisp.c (check_it): Likewise.
8941 * xfaces.c (register_color, unregister_color, unregister_colors):
8942 Likewise.
8943 * xfns.c (print_fontset_result): Likewise.
8944 * xrdb.c (member, fatal, main): Likewise.
8945
99033785
PE
89462011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8947
8948 Fix minor problems found by static checking (Bug#9031).
8949 * chartab.c (char_table_set_range, map_sub_char_table):
8950 Remove unused locals.
8951 (uniprop_table): Now static.
8952 * composite.c (_work_char): Remove unused static var.
8953
9cb2ac56
JB
89542011-07-09 Juanma Barranquero <lekktu@gmail.com>
8955
8956 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8957
f25661f0
JD
89582011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8959
8960 * gtkutil.c (qttip_cb): Remove code without function.
8961
8278c4fe
EZ
89622011-07-09 Eli Zaretskii <eliz@gnu.org>
8963
8964 * w32.c (pthread_sigmask): New stub.
8965
1692ae2d 89662011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8967
8a6ebd58 8968 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8969 sigprocmask is portable only for single-threaded applications, and
8970 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8971 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8972 (LIBES): Use it.
8973 * callproc.c (Fcall_process):
8974 * process.c (create_process):
8975 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8976 Use pthread_sigmask, not sigprocmask.
123403e4 8977
1b854618
JD
89782011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8979
8980 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8981 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8982 wrong (Bug#8591).
8983
3fe4b549
JD
89842011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8985
0ce7e563
JD
8986 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8987 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8988 (xg_hide_tooltip): Fix comment.
8989
3fe4b549
JD
8990 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8991 in registerServicesMenuSendTypes.
8992 (validRequestorForSendType): Don't check ns_return_types.
8993
8994 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8995 ns_return_type.
8996
5df75e47
JR
89972011-07-08 Jason Rumney <jasonr@gnu.org>
8998
22610910
JR
8999 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9000 SH_SHOW for hidden windows (Bug#5482).
9001
5df75e47
JR
9002 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9003 frame struct members of non-existent frames (Bug#6284).
9004
699c10bd
JD
90052011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9006
4393663b
JD
9007 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9008 variable firstTime not needed on OSX >= 10.6.
9009 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9010 >= 10.5. Use setKnobProportion, setDoubleValue.
9011
9012 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9013 (MAC_OS_X_VERSION_10_5): Define if not defined.
9014 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9015 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9016 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9017
9018 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9019 cString and lossyCString on OSX >= 10.4.
4393663b 9020
58179cce 9021 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9022 sizeToFit on OSX >= 10.2.
9023
9024 * nsimage.m (allocInitFromFile): Don't use deprecated method
9025 bestRepresentationForDevice on OSX >= 10.6.
9026
9027 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9028 to avoid warning.
9029
9030 * emacs.c: Declare unexec_init_emacs_zone.
9031
a63e0781
JD
9032 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9033
699c10bd
JD
9034 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9035
9036 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9037 on svcsMenu (Bug#8842).
9038
9039 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9040 ns_return_types.
9041 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9042
9043 * nsterm.m (QUTF8_STRING): Declare.
9044 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9045 (validRequestorForSendType): Return type is (id).
9046 Change indexOfObjectIdenticalTo to indexOfObject.
9047 Check if we have local selection before returning self (Bug#8842).
9048 (writeSelectionToPasteboard): Put local selection into paste board
9049 if we have a local selection (Bug#8842).
9050 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9051
9052 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9053 (ns_get_local_selection): Declare.
9054
54e10184
LMI
90552011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9056
9888ff71
LMI
9057 * keymap.c (describe_map_tree): Don't insert a double newline at
9058 the end of the buffer (bug#1169) and return whether we inserted
9059 something.
9060
54e10184
LMI
9061 * callint.c (Fcall_interactively): Change "reading args" to
9062 "providing args" to try to clarify what it does (bug#1010).
9063
15fa4783
KH
90642011-07-07 Kenichi Handa <handa@m17n.org>
9065
9066 * composite.c (composition_compute_stop_pos): Ignore a static
9067 composition starting before CHARPOS (Bug#8915).
9068
9069 * xdisp.c (handle_composition_prop): Likewise.
9070
a8815b00
EZ
90712011-07-07 Eli Zaretskii <eliz@gnu.org>
9072
9073 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9074 (Bug#9015)
9075
ef7b981d 90762011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9077
9078 * character.h (unicode_category_t): New enum type.
9079
9080 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9081 (Qchar_code_property_table): New variable.
9082 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9083 (UNIPROP_COMPRESSED_FORM_P): New macros.
9084 (char_table_ascii): Uncompress the compressed values.
9085 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9086 Uncompress the compressed values.
ac389d0c 9087 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9088 (char_table_ref_and_range): Uncompress the compressed values.
9089 (sub_char_table_set): New arg is_uniprop. Callers changed.
9090 Uncompress the compressed values.
9091 (sub_char_table_set_range): Args changed. Callers changed.
9092 (char_table_set_range): Adjuted for the above change.
9093 (map_sub_char_table): Delete args default_val and parent. Add arg
9094 top. Give decoded values to a Lisp function.
640c8776 9095 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9096 values to a Lisp function. Gcpro more variables.
9097 (uniprop_table_uncompress)
9098 (uniprop_decode_value_run_length): New functions.
9099 (uniprop_decoder, uniprop_decoder_count): New variables.
9100 (uniprop_get_decoder, uniprop_encode_value_character)
9101 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9102 New functions.
9103 (uniprop_encoder, uniprop_encoder_count): New variables.
9104 (uniprop_get_encoder, uniprop_table)
9105 (Funicode_property_table_internal, Fget_unicode_property_internal)
9106 (Fput_unicode_property_internal): New functions.
9107 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9108 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9109 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9110 char-code-property-alist.
9111
640c8776 9112 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9113 Vunicode_category_table.
9114
640c8776 9115 * font.c (font_range): Adjust for the change of
c805dec0
KH
9116 Vunicode_category_table.
9117
76b397fb
DN
91182011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9119
9120 * m/iris4d.h: Remove file, move contents ...
9121 * s/irix6-5.h: ... here.
9122
22b4128e
PE
91232011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9124
9125 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9126 * alloc.c (mark_buffer):
9127 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9128 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9129 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9130 This isn't true in general, and it's particularly not true
9131 if Emacs is configured with --with-wide-int.
9132 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9133 New macros, used in the buffer.c change.
9134
869795d6
JD
91352011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9136
9137 * xsettings.c: Use both GConf and GSettings if both are available.
9138 (store_config_changed_event): Add comment.
9139 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9140 (store_tool_bar_style_changed): New functions.
5e617bc2 9141 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9142 (struct xsettings): Move font inside HAVE_XFT.
9143 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9144 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9145 Move inside HAVE_XFT.
640c8776 9146 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9147 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9148 also.
9149 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9150 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9151 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9152 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9153 (parse_settings): Move check for font inside HAVE_XFT.
9154 (read_settings, apply_xft_settings): Add comment.
9155 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9156 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9157 call store_font_name_changed.
9158 (xft_settings_event): Add comment.
9159 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9160 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9161 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9162 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9163 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9164 (xsettings_get_system_font, xsettings_get_system_normal_font):
9165 Add comment.
869795d6 9166
d8ed26bd
PE
91672011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9168
9169 Random fixes. E.g., (random) never returned negative values.
9170 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9171 subseconds part to the entropy, as that's a bit more random.
9172 Prefer signed to unsigned, since the signedness doesn't matter and
9173 in general we prefer signed. When given a limit, use a
9174 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9175 latter isn't right if USE_2_TAGS_FOR_INTS.
9176 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9177 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9178
cabf1cac
SM
91792011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9180
9181 * textprop.c (text_property_stickiness):
9182 Obey Vtext_property_default_nonsticky.
9183 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9184 * w32fns.c (syms_of_w32fns):
9185 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9186
6e9b2be9
PE
91872011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9188
9189 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9190 This is more efficient than Ffile_directory_p and avoids a minor race.
9191
90186c68
LMI
91922011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9193
7c301272
LMI
9194 * buffer.c (Foverlay_put): Say what the return value is
9195 (bug#7835).
9196
c4f2d8d4
LMI
9197 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9198 is a directory before asking whether to use the file name
9199 (bug#7564).
ad637907
LMI
9200 (barf_or_query_if_file_exists): Make the "File is a directory"
9201 error be more correct.
c4f2d8d4 9202
90186c68
LMI
9203 * fns.c (Frequire): Remove the mention of the .gz files, since
9204 that's installation-specific, but keep the mention of
9205 `get-load-suffixes'.
9206
da64016e
PE
92072011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9208
9209 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9210 Report string overflow if the output is too long.
9211
7d47b580
JB
92122011-07-04 Juanma Barranquero <lekktu@gmail.com>
9213
a555cb87
JB
9214 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9215 (syms_of_gnutls): Remove duplicate DEFSYM for
9216 Qgnutls_bootprop_verify_hostname_error, an error for
9217 Qgnutls_bootprop_verify_error (which is no longer used).
9218
7d47b580
JB
9219 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9220 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9221 Also (re)move comments that are misplaced or no longer relevant.
9222
1e49bfab
LMI
92232011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9224
9225 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9226
1485f4c0
CY
92272011-07-03 Chong Yidong <cyd@stupidchicken.com>
9228
9229 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9230 and background color parameters if they have been changed.
9231
a9ab721e
LMI
92322011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9233
9234 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9235
cf7cff57
PE
92362011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9237
2e13213d
PE
9238 * xsettings.c (SYSTEM_FONT): Define only when used.
9239 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9240
cf7cff57
PE
9241 * keymap.c (access_keymap_1): Now static.
9242
7a8e04f7
CY
92432011-07-02 Chong Yidong <cyd@stupidchicken.com>
9244
9245 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9246 leave any prefix arg for the up event (Bug#1586).
9247
61352f62
LMI
92482011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9249
69bb1ef7
LMI
9250 * lread.c (syms_of_lread): Mention single symbols defined by
9251 `defvar' or `defconst' (bug#7154).
9252
61352f62 9253 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9254 (Frequire): Mention get-load-suffixes.
61352f62 9255
28545e04
MR
92562011-07-02 Martin Rudalics <rudalics@gmx.at>
9257
9258 * window.h (window): Remove clone_number slot.
9259 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9260 Remove.
9261 (make_parent_window, make_window, saved_window)
9262 (Fset_window_configuration, save_window_save): Don't deal with
9263 clone numbers.
9264 * buffer.c (Qclone_number): Remove declaration.
9265 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9266
3349e122
SM
92672011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9268
9269 Add multiple inheritance to keymaps.
9270 * keymap.c (Fmake_composed_keymap): New function.
9271 (Fset_keymap_parent): Simplify.
9272 (fix_submap_inheritance): Remove.
9273 (access_keymap_1): New function extracted from access_keymap to handle
9274 embedded parents and handle lists of maps.
9275 (access_keymap): Use it.
9276 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9277 (Fcopy_keymap): Handle embedded parents.
9278 (Fcommand_remapping, define_as_prefix): Simplify.
9279 (Fkey_binding): Simplify.
9280 (syms_of_keymap): Move minibuffer-local-completion-map,
9281 minibuffer-local-filename-completion-map,
9282 minibuffer-local-must-match-map, and
9283 minibuffer-local-filename-must-match-map to Elisp.
9284 (syms_of_keymap): Defsubr make-composed-keymap.
9285 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9286 (parse_menu_item): Trivial simplification.
9287
3279eb87
GM
92882011-07-01 Glenn Morris <rgm@gnu.org>
9289
9290 * Makefile.in (SETTINGS_LIBS): Fix typo.
9291
4550efdf
KI
92922011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9293
9294 * coding.c (Fencode_coding_string): Record the last coding system
9295 used, as the function doc string says (bug#8738).
9296
0949d2b6
JD
92972011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9298
9299 * xsettings.c (store_monospaced_changed): Take new font as arg and
9300 check for change against current_mono_font.
9301 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9302 (emacs_settings_constructor, emacs_settings_get_property)
9303 (emacs_settings_set_property, emacs_settings_class_init)
9304 (emacs_settings_init, gsettings_obj): Remove.
9305 (something_changedCB): New function for HAVE_GSETTINGS.
9306 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9307 with value as argument.
9308 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9309 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9310 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9311 "changed".
9312
9313 * xgselect.c: Add defined (HAVE_GSETTINGS).
9314 (xgselect_initialize): Ditto.
9315
9316 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9317 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9318 xg_select.
9319
bbc6b304
PE
93202011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9321
9322 * eval.c (struct backtrace): Simplify and port the data structure.
9323 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9324 signed bit field, as this assumption is not portable and it makes
9325 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9326 "char debug_on_exit : 1" as this is not portable either; instead,
9327 use the portable "unsigned int debug_on_exit : 1". Remove unused
9328 member evalargs. Remove obsolete comments about cc bombing out.
9329
9851bfc5
JD
93302011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9331
51bb811f 9332 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9333 Let HAVE_GSETTINGS override HAVE_GCONF.
9334 (store_monospaced_changed): New function.
9335 (EMACS_SETTINGS): A new type derived from GObject to handle
9336 GSettings notifications.
9337 (emacs_settings_constructor, emacs_settings_get_property)
9338 (emacs_settings_set_property, emacs_settings_class_init):
9339 New functions.
9340 (gsettings_client, gsettings_obj): New variables.
9341 (GSETTINGS_SCHEMA): New define.
9342 (something_changedCB): Call store_monospaced_changed.
9343 (init_gsettings): New function.
9344 (xsettings_initialize): Call init_gsettings.
9345 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9346 to NULL.
9347
640c8776 9348 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9349 GCONF_CFLAGS/LIBS.
9350
5386012d
MR
93512011-06-29 Martin Rudalics <rudalics@gmx.at>
9352
9353 * window.c (resize_root_window, grow_mini_window)
9354 (shrink_mini_window): Rename Qresize_root_window to
9355 Qwindow_resize_root_window and Qresize_root_window_vertically to
9356 Qwindow_resize_root_window_vertically.
9357
f13e0b08
PE
93582011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9359
9360 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9361
94515237
JB
93622011-06-27 Juanma Barranquero <lekktu@gmail.com>
9363
9364 * makefile.w32-in: Redesign dependencies so they reflect more
9365 clearly which files are directly included by each source file,
9366 and not through other includes.
9367
e43b6e43
MR
93682011-06-27 Martin Rudalics <rudalics@gmx.at>
9369
9370 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9371 (sort_overlays, overlay_strings): When an overlay's clone number
9372 matches the window's clone number process the overlay even if
9373 the overlay's window property doesn't match the current window.
9374
d68443dc
MR
9375 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9376 (Fwindow_hchild): Rename to Fwindow_left_child.
9377 (Fwindow_next): Rename to Fwindow_next_sibling.
9378 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9379 (resize_window_check): Rename to window_resize_check.
9380 (resize_window_apply): Rename to window_resize_apply.
9381 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9382 (Fdelete_other_windows_internal, resize_frame_windows)
9383 (Fsplit_window_internal, Fdelete_window_internal)
9384 (grow_mini_window, shrink_mini_window)
9385 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9386
c7e73be5
JD
93872011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9388
9389 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9390 (emacs_fixed_set_min_size): Remove.
9391 (emacs_fixed_new): Take frame as argument.
9392
9393 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9394 (_EmacsFixedPrivate): Remove minwidth/height.
9395 Add struct frame *f.
9396 (emacs_fixed_init): Initialize priv->f.
9397 (get_parent_class, emacs_fixed_set_min_size): Remove.
9398 (emacs_fixed_new): Set priv->f to argument.
9399 (emacs_fixed_get_preferred_width)
9400 (emacs_fixed_get_preferred_height): Use min_width/height from
9401 frames size_hint to set minimum and natural (Bug#8919).
9402 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9403 and use min_width/height from frames size_hint to set
9404 min_width/height (Bug#8919).
9405
9406 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9407 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9408 Fix indentation.
c7e73be5 9409
cf99dcf8
EZ
94102011-06-26 Eli Zaretskii <eliz@gnu.org>
9411
9412 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9413 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9414 called at ZV.
9415
029529ac
CY
94162011-06-26 Chong Yidong <cyd@stupidchicken.com>
9417
9418 * process.c (wait_reading_process_output): Bypass select if
9419 waiting for a cell while ignoring keyboard input, and input is
9420 pending. Suggested by Jan Djärv (Bug#8869).
9421
7a7ef429
PE
94222011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9423
9424 Use gnulib's dup2 module instead of rolling our own.
9425 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9426
11fdef7d 94272011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9428
9429 * dispnew.c (scrolling_window): Before scrolling, turn off a
9430 mouse-highlight in the window being scrolled.
9431
cd3520a4
JB
94322011-06-24 Juanma Barranquero <lekktu@gmail.com>
9433
9434 Move DEFSYM to lisp.h and use everywhere.
9435
9436 * character.h (DEFSYM): Move declaration...
9437 * lisp.h (DEFSYM): ...here.
9438
9439 * gnutls.c:
9440 * minibuf.c:
9441 * w32menu.c:
9442 * w32proc.c:
9443 * w32select.c: Don't include character.h.
9444
9445 * alloc.c (syms_of_alloc):
9446 * buffer.c (syms_of_buffer):
9447 * bytecode.c (syms_of_bytecode):
9448 * callint.c (syms_of_callint):
9449 * casefiddle.c (syms_of_casefiddle):
9450 * casetab.c (init_casetab_once):
9451 * category.c (init_category_once, syms_of_category):
9452 * ccl.c (syms_of_ccl):
9453 * cmds.c (syms_of_cmds):
9454 * composite.c (syms_of_composite):
9455 * dbusbind.c (syms_of_dbusbind):
9456 * dired.c (syms_of_dired):
9457 * dispnew.c (syms_of_display):
9458 * doc.c (syms_of_doc):
9459 * editfns.c (syms_of_editfns):
9460 * emacs.c (syms_of_emacs):
9461 * eval.c (syms_of_eval):
9462 * fileio.c (syms_of_fileio):
9463 * fns.c (syms_of_fns):
9464 * frame.c (syms_of_frame):
9465 * fringe.c (syms_of_fringe):
9466 * insdel.c (syms_of_insdel):
9467 * keymap.c (syms_of_keymap):
9468 * lread.c (init_obarray, syms_of_lread):
9469 * macros.c (syms_of_macros):
9470 * msdos.c (syms_of_msdos):
9471 * print.c (syms_of_print):
9472 * process.c (syms_of_process):
9473 * search.c (syms_of_search):
9474 * sound.c (syms_of_sound):
9475 * syntax.c (init_syntax_once, syms_of_syntax):
9476 * terminal.c (syms_of_terminal):
9477 * textprop.c (syms_of_textprop):
9478 * undo.c (syms_of_undo):
9479 * w32.c (globals_of_w32):
9480 * window.c (syms_of_window):
9481 * xdisp.c (syms_of_xdisp):
9482 * xfaces.c (syms_of_xfaces):
9483 * xfns.c (syms_of_xfns):
9484 * xmenu.c (syms_of_xmenu):
9485 * xsettings.c (syms_of_xsettings):
9486 * xterm.c (syms_of_xterm): Use DEFSYM.
9487
4228cf16
TZ
94882011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9489
cd3520a4 9490 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9491
7fcccf1e
PE
94922011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9493
7efb4e0e
PE
9494 Integer and buffer overflow fixes (Bug#8873).
9495
ff5844ad
PE
9496 * print.c (printchar, strout): Check for string overflow.
9497 (PRINTPREPARE, printchar, strout):
9498 Don't set size unless allocation succeeds.
9499
90532f02
PE
9500 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9501 for sizes. Check for string overflow more accurately.
9502 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9503
6d84508d
PE
9504 * macros.c: Integer and buffer overflow fixes.
9505 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9506 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9507 Use ptrdiff_t, not int, for sizes.
9508 Don't increment bufsize until after realloc succeeds.
9509 Check for size-calculation overflow.
9510 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9511
437b2cb4
PE
9512 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9513
8b9ac8b4
PE
9514 * lread.c: Integer overflow fixes.
9515 (read_integer): Radix is now EMACS_INT, not int,
9516 to improve quality of diagnostics for out-of-range radices.
9517 Calculate buffer size correctly for out-of-range radices.
9518 (read1): Check for integer overflow in radices, and in
9519 read-circle numbers.
82cb60d3
PE
9520 (read_escape): Avoid int overflow.
9521 (Fload, openp, read_buffer_size, read1)
9522 (substitute_object_recurse, read_vector, read_list, map_obarray):
9523 Use ptrdiff_t, not int, for sizes.
9524 (read1): Use EMACS_INT, not int, for sizes.
20270765 9525 Check for size overflow.
8b9ac8b4 9526
7fcccf1e
PE
9527 * image.c (cache_image): Check for size arithmetic overflow.
9528
bfbbd7e7
PE
9529 * lread.c: Integer overflow issues.
9530 (saved_doc_string_size, saved_doc_string_length)
9531 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9532 Now ptrdiff_t, not int.
9533 (read1): Don't assume doc string length fits in int. Check for
9534 out-of-range doc string lengths.
9535 (read_list): Don't assume file position fits in int.
39019e54 9536 (read_escape): Check for hex character overflow.
bfbbd7e7 9537
4e323265
LL
95382011-06-22 Leo Liu <sdl.web@gmail.com>
9539
9540 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9541 Move to minibuffer.el.
9542
85fece3e
PE
95432011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9544
20b84ce9 9545 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9546 The following patches are for when GLYPH_DEBUG && !XASSERT.
9547 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9548 * dispnew.c (flush_stdout):
9549 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9550 Mark as externally visible.
9551 * dispnew.c (check_window_matrix_pointers): Now static.
9552 * dispnew.c (window_to_frame_vpos):
9553 * xfns.c (unwind_create_frame):
9554 * xterm.c (x_check_font): Remove unused local.
9555 * scroll.c (CHECK_BOUNDS):
9556 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9557 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9558 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9559 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9560 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9561 Now static.
9562 (debug_method_add): Use va_list and vsprintf rather than relying
9563 on undefined behavior with wrong number of arguments.
9564 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9565 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9566 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9567 since we're not interested in debugging glyphs with old libraries.
9568 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9569 GCC 4.6.0's static checking.
9570
0766b489
PE
95712011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9572
31fd4b32
PE
9573 Integer overflow and signedness fixes (Bug#8873).
9574 A few related buffer overrun fixes, too.
9575
b79e8648
PE
9576 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9577
0766b489
PE
9578 * dispextern.h (struct face.stipple):
9579 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9580 (x_bitmap_mask, x_allocate_bitmap_record)
9581 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9582 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9583 (x_create_bitmap_from_xpm_data):
9584 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9585 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9586 (.bitmaps_last):
9587 * xfaces.c (load_pixmap):
9588 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9589 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9590 (.bitmaps_last, struct x_output.icon_bitmap):
9591 Use ptrdiff_t, not int, for bitmap indexes.
9592 (x_allocate_bitmap_record): Check for size overflow.
9593 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9594
b081724f
PE
9595 Use ptrdiff_t, not int, for overlay counts.
9596 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9597 * editfns.c (overlays_around, get_pos_property):
9598 * textprop.c (get_char_property_and_overlay):
9599 * xdisp.c (next_overlay_change, note_mouse_highlight):
9600 * xfaces.c (face_at_buffer_position):
21514da7
PE
9601 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9602 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9603 (Fnext_overlay_change, Fprevious_overlay_change)
9604 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9605 Use ptrdiff_t, not int, for sizes.
21514da7 9606 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9607
3de73e5e
PE
9608 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9609
2606c57b
PE
9610 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9611 (x_session_initialize): Do not assume string length fits in int.
9612
aaafe47a
PE
9613 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9614 This is unlikely, but can occur if DPI is outlandish.
9615
2674ddc8 9616 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9617 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9618
28154962
PE
9619 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9620 * xrdb.c (magic_file_p, search_magic_path):
9621 Omit last arg SUFFIX; it was always 0. All callers changed.
9622 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9623
7de51af5
PE
9624 * xfont.c (xfont_match): Avoid need for strlen.
9625
25ed6cc3
PE
9626 * xfns.c: Don't assume strlen fits in int.
9627 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9628
4eab31dd
PE
9629 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9630 not unsigned long, as we prefer signed integers. All callers changed.
9631 Detect integer overflow in repeat count.
9632 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9633 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9634
171e2a58
PE
9635 * termcap.c: Don't assume sizes fit in int and never overflow.
9636 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9637 (gobble_line): Check for size-calculation overflow.
9638
ad39faca 9639 * minibuf.c (Fread_buffer):
6e5bb2dc 9640 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9641 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9642 Don't assume string length fits in int.
9643
52c61c22 9644 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9645 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9646
b5b8c9e5
PE
9647 * font.c: Don't assume string length fits in int.
9648 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9649 Use ptrdiff_t, not int.
ccd6111c
PE
9650 (font_intern_prop): Don't assume string length fits in int.
9651 Don't assume integer property fits in fixnum.
9652 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9653
882f0d81 9654 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9655 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9656 Reformulate so as not to need the command string.
9657 Invoke gzip -cd rather than gunzip, as it's more portable.
9658 (lock_info_type, lock_file_1, lock_file):
9659 Don't assume pid_t and time_t fit in unsigned long.
9660 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9661 (current_lock_owner): Prefer signed type for sizes.
9662 Use memcpy, not strncpy, where memcpy is what is really wanted.
9663 Don't assume (via atoi) that time_t and pid_t fit in int.
9664 Check for time_t and/or pid_t out of range, e.g., via a network share.
9665 Don't alloca where an auto var works fine.
9666
93f4cf88
PE
9667 * fileio.c: Fix some integer overflow issues.
9668 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9669 Don't assume string length fits in int.
9670 (directory_file_name): Don't assume string length fits in long.
9671 (make_temp_name): Don't assume pid fits in int, or that its print
9672 length is less than 20.
9673
f3e92b69
PE
9674 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9675
1bfdaf10
PE
9676 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9677
35016e9a
PE
9678 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9679
3d1e65a1
PE
9680 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9681 We prefer signed integers, even for size calculations.
9682
0b963a93
PE
9683 * emacs.c: Don't assume string length fits in 'int'.
9684 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9685 (main): Don't invoke strlen when not needed.
9686
573f4b54
PE
9687 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9688 (XD_DEBUG_MESSAGE): Don't waste a byte.
9689
989f33ba
PE
9690 * callproc.c (getenv_internal_1, getenv_internal)
9691 (Fgetenv_internal):
965d34eb
PE
9692 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9693
e4d29b33
PE
9694 * lread.c (invalid_syntax): Omit length argument.
9695 All uses changed. This doesn't fix a bug, but it simplifies the
9696 code away from its former Hollerith-constant appearance, and it's
9697 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9698 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9699
eb49b136
PE
9700 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9701 This didn't break anything, but it didn't help either.
9702 It's confusing to put a bogus integer in a place where the actual
9703 value does not matter.
9f62aeb1 9704 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9705 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9706
15375a22
PE
9707 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9708 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9709 implementation.
b61cc01c
PE
9710 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9711 We prefer signed types, and the value cannot exceed the EMACS_INT
9712 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9713 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9714 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9715 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9716
53b2623d
PE
9717 * indent.c (sane_tab_width): New function.
9718 (current_column, scan_for_column, Findent_to, position_indentation)
9719 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9720 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9721
51cab52b 9722 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9723
f2ed8a70
PE
9724 * lisp.h (lint_assume): New macro.
9725 * composite.c (composition_gstring_put_cache):
9726 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9727
abe80cc6
PE
9728 * editfns.c, insdel.c:
9729 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9730
b02c740e
PE
9731 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9732
ebc96716
PE
9733 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9734
b4e50fa0 9735 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9736 Use much-faster test for byte-length change.
311d5d7c 9737 Don't assume string byte-length fits in 'int'.
a4cf38e4 9738 Check that character arg fits in 'int'.
85461888 9739 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9740
c0c1ee9f
PE
9741 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9742
a498d7f4
PE
9743 * fns.c (concat): Catch string overflow earlier.
9744 Do not rely on integer wraparound.
9745
51cab52b
PE
9746 * dispextern.h (struct it.overlay_strings_charpos)
9747 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9748 * xdisp.c (forward_to_next_line_start)
9749 (back_to_previous_visible_line_start)
9750 (reseat_at_next_visible_line_start, next_element_from_buffer):
9751 Don't arbitrarily truncate the value of 'selective' to int.
9752
76031fad
PE
9753 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9754
5eb55db9
PE
9755 * composite.c: Don't truncate sizes to 'int'.
9756 (composition_gstring_p, composition_reseat_it)
9757 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9758 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9759 not EMACS_UINT, for indexes.
5eb55db9 9760
0703a717
PE
9761 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9762
d6202519
PE
9763 * buffer.c: Include <verify.h>.
9764 (struct sortvec.priority, struct sortstr.priority):
8961a454 9765 Now EMACS_INT, not int.
c20998a7 9766 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9767 (struct sortstr.size, record_overlay_string)
9768 (struct sortstrlist.size, struct sortlist.used):
9769 Don't truncate size to int.
9770 (record_overlay_string): Check for size-calculation overflow.
d6202519 9771 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9772
d5a19415
JM
97732011-06-22 Jim Meyering <meyering@redhat.com>
9774
029529ac 9775 Don't leak an XBM-image-sized buffer
d5a19415
JM
9776 * image.c (xbm_load): Free the image buffer after using it.
9777
a9041e6c
PE
97782011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9779
9780 Port to Sun C.
9781 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9782 that Sun C diagnosed.
9783 * fns.c (secure_hash): Fix pointer signedness issue.
9784 * intervals.c (static_offset_intervals): New function.
9785 (offset_intervals): Use it.
9786
7f3f739f
LL
97872011-06-21 Leo Liu <sdl.web@gmail.com>
9788
9789 * deps.mk (fns.o):
9790 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9791 sha512.h.
9792
9793 * fns.c (secure_hash): Rename from crypto_hash_function and change
9794 the first arg to accept symbols.
5b66d427 9795 (Fsecure_hash): New primitive.
7f3f739f
LL
9796 (syms_of_fns): New symbols.
9797
76147d94
DD
97982011-06-20 Deniz Dogan <deniz@dogan.se>
9799
9800 * process.c (Fset_process_buffer): Clarify return value in
9801 docstring.
9802
7d7d0045
CY
98032011-06-18 Chong Yidong <cyd@stupidchicken.com>
9804
9805 * dispnew.c (add_window_display_history): Use BVAR.
9806
9807 * xdisp.c (debug_method_add): Use BVAR.
9808 (check_window_end, dump_glyph_matrix, dump_glyph)
9809 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9810
9811 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9812 Likewise.
9813
9814 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9815 check till after the cache is created in init_frame_faces.
9816
ff2bc410
SM
98172011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9818
9819 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9820
28177add
PE
98212011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9822
dd3482fe
PE
9823 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9824 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9825 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9826
393d71f3 9827 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9828 * fileio.c (Finsert_file_contents):
9829 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9830 Remove the old (too-loose) buffer overflow checks.
9831 They weren't needed, since make_gap checks for buffer overflow.
9832 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9833 The old code merely checked for Emacs fixnum overflow, and relied
9834 on undefined (wraparound) behavior. The new code avoids undefined
9835 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9836
2e6813b0 9837 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9838 Tune. Don't use wider integers than needed. Don't use alloca.
9839 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9840
599a9e4f
PE
9841 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9842
99561444
PE
9843 * insdel.c, lisp.h (buffer_overflow): New function.
9844 (insert_from_buffer_1, replace_range, replace_range_2):
9845 * insdel.c (make_gap_larger):
9846 * editfns.c (Finsert_char):
9847 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9848
28177add
PE
9849 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9850
e69dafad
PE
98512011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9852
4baa020d 9853 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9854
b1c46f02
PE
9855 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9856 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9857
e69dafad
PE
9858 * fileio.c: Don't assume EMACS_INT fits in off_t.
9859 (emacs_lseek): New static function.
9860 (Finsert_file_contents, Fwrite_region): Use it.
9861 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9862
566684ea
PE
9863 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9864
e6966cd6
PE
9865 * fns.c: Don't overflow int when computing a list length.
9866 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9867 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9868 truncation on 64-bit hosts. Check for QUIT every
9869 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9870 faster and is responsive enough.
9871 (Flength): Report an error instead of overflowing an integer.
9872 (Fsafe_length): Return a float if the value is not representable
9873 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9874 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9875 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9876
dd0b0efb
PE
9877 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9878 (header_size, word_size): New constants.
9879 (allocate_vectorlike): Don't check size overflow here.
9880 (allocate_vector): Check it here instead, since this is the only
9881 caller of allocate_vectorlike that could cause overflow.
9882 Check that the new vector's length is representable as a fixnum.
9883
86fe5cfe
PE
9884 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9885 The previous code was bogus. For example, next_almost_prime (32)
9886 returned 39, which is undesirable as it is a multiple of 3; and
9887 next_almost_prime (24) returned 25, which is a multiple of 5 so
9888 why was the code bothering to check for multiples of 7?
9889
80e88859
PE
9890 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9891
4a2f0ad6
PE
9892 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9893
f66c7cf8
PE
9894 Variadic C functions now count arguments with ptrdiff_t.
9895 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9896 Back then I didn't know that the Emacs coding style prefers signed int.
9897 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9898 were being counted with int, which may truncate counts on 64-bit
9899 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9900 * lisp.h (struct Lisp_Subr.function.aMANY)
9901 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9902 Arg counts are now ptrdiff_t, not size_t.
9903 All variadic functions and their callers changed accordingly.
9904 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9905 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9906 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9907 * callint.c (Fcall_interactively): Check arg count for overflow,
9908 to avoid potential buffer overrun. Use signed char, not 'int',
9909 for 'varies' array, so that we needn't bother to check its size
9910 calculation for overflow.
9911 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9912 * eval.c (apply_lambda):
9913 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9914 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9915 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9916
a1759b76
PE
9917 * callint.c (Fcall_interactively): Don't use index var as event count.
9918
d96be9fc
PE
9919 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9920 * mem-limits.h (SIZE): Remove; no longer used.
9921
a690a978 9922 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9923
578c21e6
PE
9924 Remove unnecessary casts.
9925 * xterm.c (x_term_init):
9926 * xfns.c (x_set_border_pixel):
9927 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9928 These aren't needed now that we assume ANSI C.
9929
96f53c6c
PE
9930 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9931 It's more likely to cause problems (due to unsigned overflow)
9932 than to cure them.
9933
83c77d31
PE
9934 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9935
ee2079f1
PE
9936 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9937
6da65536
PE
9938 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9939
7147c4a4
PE
9940 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9941
193e32d9
PE
9942 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9943
e5533da6
PE
9944 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9945
9910e595
PE
9946 GLYPH_CODE_FACE returns EMACS_INT, not int.
9947 * dispextern.h (merge_faces):
9948 * xfaces.c (merge_faces):
01103c44
PE
9949 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9950 Don't assume EMACS_INT fits in int.
9910e595 9951
2638320e
PE
9952 * character.h (CHAR_VALID_P): Remove unused parameter.
9953 * fontset.c, lisp.h, xdisp.c: All uses changed.
9954
045eb8d9
PE
9955 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9956
c1f134b5
PE
9957 * fns.c (concat): Minor tuning based on overflow analysis.
9958 This doesn't fix any bugs. Use int to hold character, instead
9959 of constantly refetching from Emacs object. Use XFASTINT, not
9960 XINT, for value known to be a character. Don't bother comparing
9961 a single byte to 0400, as it's always less.
9962
395fcb93 9963 * floatfns.c (Fexpt):
327eeec8
PE
9964 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9965
abbd3d23
PE
9966 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9967 for characters.
9968
684a03ef
PE
9969 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9970
0fed43f3
PE
9971 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9972 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9973 incorrectly succeed when S was a string, because 4294967386 was
9974 truncated before it was used.
9975
8fd02eb7
PE
9976 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9977 Otherwise, an out-of-range integer could cause undefined behavior
9978 on a 64-bit host.
9979
f8c86b69
PE
9980 * composite.c: Use int, not EMACS_INT, for characters.
9981 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9982 EMACS_INT, for values that are known to be in character range.
9983 This doesn't fix any bugs but is the usual style inside Emacs and
9984 may generate better code on 32-bit machines.
9985
34206dd2
PE
9986 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9987 This is for reasons similar to the recent CHAR_STRING fix.
9988 * charset.c (Fencode_char): Check that character arg is actually
9989 a character. Pass an int to ENCODE_CHAR.
9990 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9991 wider than 'int', as a compile-time check to prevent future regressions
9992 in this area.
9993
c5958d4c 9994 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9995
9996 Make sure a 64-bit char is never passed to CHAR_STRING.
9997 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9998 by silently ignoring the top 32 bits, allowing some values
9999 that were far too large to be valid characters.
10000 * character.h: Include <verify.h>.
10001 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10002 arguments are no wider than unsigned, as a compile-time check
10003 to prevent future regressions in this area.
10004 * data.c (Faset):
01103c44 10005 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10006 (Fsubst_char_in_region):
10007 * fns.c (concat):
10008 * xdisp.c (decode_mode_spec_coding):
10009 Adjust to CHAR_STRING's new requirement.
10010 * editfns.c (Finsert_char, Fsubst_char_in_region):
10011 * fns.c (concat): Check that character args are actually
10012 characters. Without this test, these functions did the wrong
10013 thing with wildly out-of-range values on 64-bit hosts.
10014
d37ca623
PE
10015 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10016 These casts should not be needed on 32-bit hosts, either.
10017 * keyboard.c (read_char):
10018 * lread.c (Fload): Remove casts to unsigned.
10019
ea204efb
PE
10020 * lisp.h (UNSIGNED_CMP): New macro.
10021 This fixes comparison bugs on 64-bit hosts.
10022 (ASCII_CHAR_P): Use it.
10023 * casefiddle.c (casify_object):
01103c44 10024 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10025 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10026 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10027 * dispextern.h (FACE_FROM_ID):
10028 * keyboard.c (read_char): Use UNSIGNED_CMP.
10029
41cb286c
PE
10030 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10031 not to EMACS_INT, to avoid GCC warning.
10032
4a1b9832
PE
10033 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10034
55daad71
PE
10035 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10036 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10037 isn't needed on 32-bit machines.
8f95c75c 10038
01103c44
PE
10039 * buffer.c (Fgenerate_new_buffer_name):
10040 Use EMACS_INT for count, not int.
0ceccced 10041 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10042
10043 * data.c (Qcompiled_function): Now static.
10044
c6f072e7
PE
10045 * window.c (window_body_lines): Now static.
10046
20ce5912
PE
10047 * image.c (gif_load): Rename local to avoid shadowing.
10048
9c4c5f81
PE
10049 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10050 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10051 * alloc.c (make_save_value): Integer argument is now of type
10052 ptrdiff_t, not int.
10053 (mark_object): Use ptrdiff_t, not int.
10054 * lisp.h (pD): New macro.
10055 * print.c (print_object): Use it.
10056
c0c5c8ae
PE
10057 * alloc.c: Use EMACS_INT, not int, to count objects.
10058 (total_conses, total_markers, total_symbols, total_vector_size)
10059 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10060 (total_free_floats, total_floats, total_free_intervals)
10061 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10062 Now EMACS_INT, not int. All uses changed.
10063 (Fgarbage_collect): Compute overall total using a double, so that
10064 integer overflow is less likely to be a problem. Check for overflow
10065 when converting back to an integer.
5a25e253
PE
10066 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10067 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10068 These were 'int' variables that could overflow on 64-bit hosts;
10069 they were never used, so remove them instead of repairing them.
211a0b2a 10070 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10071 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10072 Previously, this ceilinged at INT_MAX, but that doesn't work on
10073 64-bit machines.
e46bb31a 10074 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10075
c78baabf 10076 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10077 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10078 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10079 when a (possibly-narrower) signed value would do just as well.
10080 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10081
c9d624c6
PE
10082 * alloc.c: Catch some string size overflows that we were missing.
10083 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10084 for convenience in STRING_BYTES_MAX.
10085 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10086 The definition here is exact; the one in lisp.h was approximate.
10087 (allocate_string_data): Check for string overflow. This catches
10088 some instances we weren't catching before. Also, it catches
10089 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10090 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10091 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10092
c9d624c6
PE
10093 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10094 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10095 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10096
353032ce
PE
10097 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10098
2bccce07
PE
10099 * alloc.c (Fmake_string): Check for out-of-range init.
10100
0ac30604
SM
101012011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10102
10103 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10104
c195f2de
JD
101052011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10106
10107 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10108 xg_get_default_scrollbar_width.
10109
10110 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10111 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10112 (style_changed_cb): Call update_theme_scrollbar_width and call
10113 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10114 all frames (Bug#8505).
10115 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10116 Call gtk_window_set_resizable if HAVE_GTK3.
10117 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10118 and height if HAVE_GTK3 (Bug#8505).
10119 (scroll_bar_width_for_theme): New variable.
10120 (update_theme_scrollbar_width): New function.
10121 (xg_get_default_scrollbar_width): Move code to
10122 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10123 (xg_initialize): Call update_theme_scrollbar_width.
10124
10125 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10126
10127 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10128
e10ac9f1
MR
101292011-06-12 Martin Rudalics <rudalics@gmx.at>
10130
10131 * frame.c (make_frame): Call other_buffer_safely instead of
10132 other_buffer.
10133
10134 * window.c (temp_output_buffer_show): Call display_buffer with
10135 second argument Vtemp_buffer_show_specifiers and reset latter
10136 immediately after the call.
10137 (Vtemp_buffer_show_specifiers): New variable.
10138 (auto_window_vscroll_p, next_screen_context_lines)
10139 (Vscroll_preserve_screen_position): Remove leading asterisks from
10140 doc-strings.
10141
2d3c217e 101422011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10143
7b7f97e8 10144 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10145 * buffer.c (Qclone_number): Remove for now, as it's unused.
10146 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10147 (record_buffer): Remove unused local.
10148 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10149 (set_frame_buffer_list): Remove; unused.
10150 * frame.h (other_visible_frames): Remove decl.
10151 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10152 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10153 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10154 if HAVE_GPM.
10155 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10156 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10157 Define only if HAVE_GPM.
10158 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10159 (update_hints_inhibit): Remove; never set. All uses removed.
10160 * widgetprv.h (emacsFrameClassRec): Remove decl.
10161 * window.c (delete_deletable_window): Now returns void, since it
10162 wasn't returning anything.
10163 (compare_window_configurations): Remove unused locals.
10164 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10165 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10166 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10167 the same widths as pointers. This follows up on the 2011-05-06 patch.
10168 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10169 * xterm.h: Likewise.
10170 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10171
1384b89e
JB
101722011-06-12 Juanma Barranquero <lekktu@gmail.com>
10173
10174 * makefile.w32-in: Update dependencies.
10175 (LISP_H): Add lib/intprops.h.
10176
1100a63c
CY
101772011-06-11 Chong Yidong <cyd@stupidchicken.com>
10178
10179 * image.c (gif_load): Add animation frame delay to the metadata.
10180 (syms_of_image): Use DEFSYM. New symbol `delay'.
10181
6198ccd0
MR
101822011-06-11 Martin Rudalics <rudalics@gmx.at>
10183
10184 * window.c (delete_deletable_window): Re-add.
10185 (Fset_window_configuration): Rewrite to handle dead buffers and
10186 consequently deletable windows.
10187 (window_tree, Fwindow_tree): Remove. Supply functionality in
10188 window.el.
10189 (compare_window_configurations): Simplify code.
10190
b6e3633c
AS
101912011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10192
1ab0dee5
AS
10193 * image.c (imagemagick_load_image): Fix type mismatch.
10194 (Fimagemagick_types): Likewise.
10195
b6e3633c
AS
10196 * window.h (replace_buffer_in_windows): Declare.
10197
9397e56f
MR
101982011-06-11 Martin Rudalics <rudalics@gmx.at>
10199
10200 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10201 Qclone_number. Remove external declaration of Qdelete_window.
10202 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10203 code.
640c8776
SM
10204 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10205 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10206 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10207 buffer list implementation.
10208 (other_buffer_safely): New function.
10209 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10210 calls to replace_buffer_in_windows and
10211 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10212 if allowed.
10213 (record_buffer): Inhibit quitting and rewrite using quittable
10214 functions. Run Qbuffer_list_update_hook if allowed.
10215 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10216 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10217 Move switch-to-buffer to window.el.
9397e56f
MR
10218 (bury-buffer): Move to window.el.
10219 (Vbuffer_list_update_hook): New variable.
10220
10221 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10222 section.
10223
10224 * window.h (resize_frame_windows): Move up in code.
10225 (Fwindow_frame): Remove EXFUN.
10226 (replace_buffer_in_all_windows): Remove prototype.
10227 (replace_buffer_in_windows_safely): Add prototype.
10228
10229 * window.c: Declare Qdelete_window static again. Move down
10230 declaration of select_count.
10231 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10232 (Fother_window): Move to window.el.
10233 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10234 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10235 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10236 window.el.
10237 (replace_buffer_in_windows): Implement by calling
10238 Qreplace_buffer_in_windows.
10239 (replace_buffer_in_all_windows): Remove with some functionality
10240 moved into replace_buffer_in_windows_safely.
10241 (replace_buffer_in_windows_safely): New function.
10242 (select_window_norecord, select_frame_norecord): Move in front
10243 of run_window_configuration_change_hook. Remove now obsolete
10244 declarations.
640c8776
SM
10245 (Fset_window_buffer): Rewrite doc-string.
10246 Call Qrecord_window_buffer.
9397e56f
MR
10247 (keys_of_window): Move binding for other-window to window.el.
10248
b50691aa
CY
102492011-06-11 Chong Yidong <cyd@stupidchicken.com>
10250
10251 * dispextern.h (struct image): Replace data member, whose int_val
10252 and ptr_val fields were not used by anything, with a single
10253 lisp_val object.
10254
10255 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10256 (gif_clear_image, gif_load, imagemagick_load_image)
10257 (gs_clear_image, gs_load): Callers changed.
10258
3f754b86
PE
102592011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10260
cca69397
PE
10261 * buffer.h: Include <time.h>, for time_t.
10262 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10263
109e28d0
PE
10264 Fix minor problems found by static checking.
10265
60737f02
PE
10266 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10267
4b66faf3
PE
10268 Make identifiers static if they are not used in other modules.
10269 * data.c (Qcompiled_function, Qframe, Qvector):
10270 * image.c (QimageMagick, Qsvg):
10271 * minibuf.c (Qmetadata):
10272 * window.c (resize_window_check, resize_root_window): Now static.
10273 * window.h (resize_window_check, resize_root_window): Remove decls.
10274
109e28d0
PE
10275 * window.c (window_deletion_count, delete_deletable_window):
10276 Remove; unused.
46a4ce9e
PE
10277 (window_body_lines): Now static.
10278 (Fdelete_other_windows_internal): Mark vars as initialized.
10279 Make sure 'resize_failed' is initialized.
10280 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10281 (resize_window_apply): Remove unused local.
10282 * window.h (delete_deletable_window): Remove decl.
10283
109e28d0 10284 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10285 (imagemagick_load_image): Fix pointer signedness problem by changing
10286 last arg from unsigned char * to char *. All uses changed.
10287 Also, fix a local for similar reasons.
10288 Remove unused locals. Remove locals to avoid shadowing.
10289 (fn_rsvg_handle_free): Remove; unused.
10290 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10291 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10292
3f754b86
PE
10293 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10294
2547adb1
CY
102952011-06-10 Chong Yidong <cyd@stupidchicken.com>
10296
10297 * image.c (gif_load): Fix omitted cast error introduced by
10298 2011-06-06 change.
10299
2c8e37d4
MR
103002011-06-10 Martin Rudalics <rudalics@gmx.at>
10301
10302 * window.h (resize_proportionally, orig_total_lines)
10303 (orig_top_line): Remove from window structure.
10304 (set_window_height, set_window_width, change_window_heights)
10305 (Fdelete_window): Remove prototypes.
10306 (resize_frame_windows): Remove duplicate declaration.
10307
440a42e3
EZ
103082011-06-10 Eli Zaretskii <eliz@gnu.org>
10309
10310 * window.h (resize_frame_windows, resize_window_check)
10311 (delete_deletable_window, resize_root_window)
10312 (resize_frame_windows): Declare prototypes.
10313
10314 * window.c (resize_window_apply): Make definition be "static" to
10315 match the prototype.
10316
562dd5e9
MR
103172011-06-10 Martin Rudalics <rudalics@gmx.at>
10318
10319 * window.c: Remove declarations of Qwindow_size_fixed,
10320 window_min_size_1, window_min_size_2, window_min_size,
10321 size_window, window_fixed_size_p, enlarge_window, delete_window.
10322 Remove static from declaration of Qdelete_window, it's
10323 temporarily needed by Fbury_buffer.
10324 (replace_window): Don't assign orig_top_line and
10325 orig_total_lines.
10326 (Fdelete_window, delete_window): Remove. Window deletion is
10327 handled by window.el.
640c8776
SM
10328 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10329 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10330 (Fdelete_other_windows): Remove. Deleting other windows is
10331 handled by window.el.
10332 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10333 handled in window.el.
10334 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10335 Window minimum sizes are handled in window.el.
10336 (shrink_windows, size_window, set_window_height)
10337 (set_window_width, change_window_heights, window_height)
10338 (window_width, CURBEG, CURSIZE, enlarge_window)
10339 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10340 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10341 handled in window.el.
10342 (make_dummy_parent): Rename to make_parent_window and give it a
10343 second argument horflag.
10344 (make_window): Don't set resize_proportionally any more.
10345 (Fsplit_window): Remove. Windows are split in window.el.
10346 (save_restore_action, save_restore_orig_size)
10347 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10348 Resize mini windows in window.el.
10349 (grow_mini_window, shrink_mini_window): Implement by calling
10350 Qresize_root_window_vertically, resize_window_check and
10351 resize_window_apply.
640c8776
SM
10352 (saved_window, Fset_window_configuration, save_window_save):
10353 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10354 resize_proportionally.
10355 (window_min_height, window_min_width): Move to window.el.
10356 (keys_of_window): Move bindings for delete-other-windows,
10357 split-window, delete-window and enlarge-window to window.el.
10358
10359 * buffer.c: Temporarily extern Qdelete_window.
10360 (Fbury_buffer): Temporarily call Qdelete_window instead of
10361 Fdelete_window (Fbury_buffer will move to window.el soon).
10362
10363 * frame.c (set_menu_bar_lines_1): Remove code handling
10364 orig_top_line and orig_total_lines.
10365
10366 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10367 set_window_height but set heights directly.
10368 (change_frame_size_1): Use resize_frame_windows.
10369
10370 * xdisp.c (init_xdisp): Don't use set_window_height but set
10371 heights directly.
10372
640c8776
SM
10373 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10374 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10375 run_window_configuration_change_hook.
10376
10377 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10378 instead of change_window_heights and run
10379 run_window_configuration_change_hook.
10380
1a13852e
MR
103812011-06-09 Martin Rudalics <rudalics@gmx.at>
10382
10383 * window.c (replace_window): Rename second argument REPLACEMENT to
10384 NEW. New third argument SETFLAG. Rewrite.
10385 (delete_window, make_dummy_parent): Call replace_window with
10386 third argument 1.
10387 (window_list_1): Move down in code.
10388 (run_window_configuration_change_hook): Move set_buffer part
10389 before select_frame_norecord part in order to unwind correctly.
10390 Rename count1 to count.
10391 (recombine_windows, delete_deletable_window, resize_root_window)
10392 (Fdelete_other_windows_internal)
10393 (Frun_window_configuration_change_hook, make_parent_window)
10394 (resize_window_check, resize_window_apply, Fresize_window_apply)
10395 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10396 (Fdelete_window_internal, Fresize_mini_window_internal):
10397 New functions.
1a13852e
MR
10398 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10399
f3d1777e
MR
104002011-06-08 Martin Rudalics <rudalics@gmx.at>
10401
496e208e
MR
10402 * window.h (window): Add some new members to window structure -
10403 normal_lines, normal_cols, new_total, new_normal, clone_number,
10404 splits, nest, prev_buffers, next_buffers.
10405 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10406 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10407
f3d1777e
MR
10408 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10409 Remove.
496e208e
MR
10410 (make_dummy_parent): Set new members of windows structure.
10411 (make_window): Move down in code. Handle new members of window
10412 structure.
10413 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10414 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10415 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10416 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10417 (Fset_window_next_buffers, Fset_window_clone_number):
10418 New functions.
496e208e
MR
10419 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10420 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10421 Doc-string fixes.
10422 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10423 Argument WINDOW can be now internal window too.
10424 (Fwindow_use_time): Move up in code.
10425 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10426 Rewrite doc-string.
10427 (Fset_window_configuration, saved_window)
10428 (Fcurrent_window_configuration, save_window_save): Handle new
10429 members of window structure.
b9e809c2
MR
10430 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10431 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10432 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10433 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10434 Qget_mru_window, Qresize_root_window,
10435 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10436 Qauto_buffer_name; staticpro them.
f3d1777e 10437
abde8f8c
MR
104382011-06-07 Martin Rudalics <rudalics@gmx.at>
10439
10440 * window.c (Fwindow_total_size, Fwindow_left_column)
10441 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10442 (Fwindow_list_1): New functions.
10443 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10444 (Fwindow_width, Fscroll_left, Fscroll_right):
10445 Use window_body_cols instead of window_box_text_cols.
10446 (delete_window, Fset_window_configuration):
10447 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10448 (delete_all_subwindows): Take a window as argument and not a
10449 structure. Rewrite.
190b47e6
MR
10450 (window_loop): Remove handling of GET_LRU_WINDOW and
10451 GET_LARGEST_WINDOW.
10452 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10453
10454 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10455 window_box_text_cols. delete_all_subwindows now takes a
10456 Lisp_Object as argument.
abde8f8c 10457
640c8776
SM
10458 * indent.c (compute_motion, Fcompute_motion):
10459 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10460
fa8a67e6
MR
10461 * frame.c (delete_frame): Call delete_all_subwindows with root
10462 window as argument.
10463
a54e3482
DC
104642011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10465
10466 * fns.c (Fputhash): Document return value.
10467
60002bf5
CY
104682011-06-06 Chong Yidong <cyd@stupidchicken.com>
10469
10470 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10471
0c671da6 104722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10473
b862a52a 10474 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10475
be44ca6c
PE
10476 Check for overflow when converting integer to cons and back.
10477 * charset.c (Fdefine_charset_internal, Fdecode_char):
10478 Use cons_to_unsigned to catch overflow.
10479 (Fencode_char): Use INTEGER_TO_CONS.
10480 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10481 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10482 * data.c (long_to_cons, cons_to_long): Remove.
10483 (cons_to_unsigned, cons_to_signed): New functions.
10484 These signal an error for invalid or out-of-range values.
10485 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10486 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10487 * font.c (Ffont_variation_glyphs):
10488 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10489 * lisp.h: Include <intprops.h>.
10490 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10491 (cons_to_signed, cons_to_unsigned): New decls.
10492 (long_to_cons, cons_to_long): Remove decls.
10493 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10494 (Fprimitive_undo): Use CONS_TO_INTEGER.
10495 * xfns.c (Fx_window_property): Likewise.
10496 * xselect.c: Include <limits.h>.
10497 (x_own_selection, selection_data_to_lisp_data):
10498 Use INTEGER_TO_CONS.
10499 (x_handle_selection_request, x_handle_selection_clear)
10500 (x_get_foreign_selection, Fx_disown_selection_internal)
10501 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10502 (lisp_data_to_selection_data): Use cons_to_unsigned.
10503 (x_fill_property_data): Use cons_to_signed.
10504 Report values out of range.
10505
d1f3d2af
PE
10506 Check for buffer and string overflow more precisely.
10507 * buffer.h (BUF_BYTES_MAX): New macro.
10508 * lisp.h (STRING_BYTES_MAX): New macro.
10509 * alloc.c (Fmake_string):
10510 * character.c (string_escape_byte8):
10511 * coding.c (coding_alloc_by_realloc):
10512 * doprnt.c (doprnt):
10513 * editfns.c (Fformat):
10514 * eval.c (verror):
10515 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10516 since they may not be the same number.
10517 * editfns.c (Finsert_char):
10518 * fileio.c (Finsert_file_contents):
10519 Likewise for BUF_BYTES_MAX.
10520
dd52fcea
PE
10521 * image.c: Use ptrdiff_t, not int, for sizes.
10522 (slurp_file): Switch from int to ptrdiff_t.
10523 All uses changed.
10524 (slurp_file): Check that file size fits in both size_t (for
10525 malloc) and ptrdiff_t (for sanity and safety).
10526
7f9bbdbb
PE
10527 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10528 if b->modtime has its maximal value.
10529
dfe18f82
PE
10530 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10531
84acfcf0
PE
10532 Don't assume time_t can fit into int.
10533 * buffer.h (struct buffer.modtime): Now time_t, not int.
10534 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10535 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10536
ccd9a01a
PE
10537 Minor fixes for signed vs unsigned integers.
10538 * character.h (MAYBE_UNIFY_CHAR):
10539 * charset.c (maybe_unify_char):
10540 * keyboard.c (read_char, reorder_modifiers):
10541 XINT -> XFASTINT, since the integer must be nonnegative.
10542 * ftfont.c (ftfont_spec_pattern):
10543 * keymap.c (access_keymap, silly_event_symbol_error):
10544 XUINT -> XFASTINT, since the integer must be nonnegative.
10545 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10546 since it makes no difference and we prefer signed.
10547 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10548 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10549 nonnegative.
10550
d6d100dd
SM
105512011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10552
10553 * window.h (Fwindow_frame): Declare.
10554
2b6148e4
PE
105552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10556
10557 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10558 (SPARE_MEMORY): Always define.
10559 (LARGE_REQUEST): Remove.
10560 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10561
f230ecc9
MR
105622011-06-06 Martin Rudalics <rudalics@gmx.at>
10563
727e958e
MR
10564 * lisp.h: Move EXFUNS for Fframe_root_window,
10565 Fframe_first_window and Fset_frame_selected_window to window.h.
10566
10567 * window.h: Move EXFUNS for Fframe_root_window,
10568 Fframe_first_window and Fset_frame_selected_window here from
10569 lisp.h.
10570
10571 * frame.c (Fwindow_frame, Fframe_first_window)
10572 (Fframe_root_window, Fframe_selected_window)
10573 (Fset_frame_selected_window): Move to window.c.
10574 (Factive_minibuffer_window): Move to minibuf.c.
10575 (Fother_visible_frames_p): New function.
10576
10577 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10578
f230ecc9
MR
10579 * window.c (decode_window, decode_any_window): Move up in code.
10580 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10581 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10582 (Fwindow_buffer): Move up and rewrite doc-string.
10583 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10584 (Fwindow_prev): New functions.
727e958e
MR
10585 (Fwindow_frame): Move here from frame.c. Accept any window as
10586 argument.
10587 (Fframe_root_window, Fframe_first_window)
10588 (Fframe_selected_window): Move here from frame.c. Accept frame
10589 or arbitrary window as argument. Update doc-strings.
10590 (Fminibuffer_window): Move up in code.
10591 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10592 (Fset_frame_selected_window): Move here from frame.c.
10593 Marginal rewrite.
727e958e
MR
10594 (Fselected_window, select_window, Fselect_window): Move up in
10595 code. Minor doc-string fixes.
f230ecc9 10596
4d09bcf6
PE
105972011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10598
10599 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10600 Do not assume that spare memory exists; that assumption is valid
10601 only if SYSTEM_MALLOC.
10602 (LARGE_REQUEST): New macro, so that the issue of large requests
10603 is separated from the issue of spare memory.
10604
810928a2
AS
106052011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10606
172418ad
AS
10607 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10608 format. (Bug#8806)
10609
43f862f7
AS
10610 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10611
810928a2
AS
10612 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10613 before statements.
10614
a059fe24
JD
106152011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10616
10617 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10618
10619 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10620
10621 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10622 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10623
989bf368
JB
106242011-06-05 Juanma Barranquero <lekktu@gmail.com>
10625
10626 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10627
4b80f674
CY
106282011-06-04 Chong Yidong <cyd@stupidchicken.com>
10629
10630 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10631 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10632 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10633 New error handlers.
4b80f674
CY
10634 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10635 Obey Vx_select_enable_clipboard_manager. Catch errors in
10636 x_clipboard_manager_save (Bug#8779).
10637 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10638 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10639
99a33b77 106402011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10641
10642 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10643
99a33b77 106442011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10645
10646 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10647 in the current matrix if keep_current_p is non-zero.
10648
8264569d
EZ
106492011-06-04 Eli Zaretskii <eliz@gnu.org>
10650
10651 * bidi.c (bidi_level_of_next_char): Fix last change.
10652
57f97249
EZ
106532011-06-03 Eli Zaretskii <eliz@gnu.org>
10654
fec2107c 10655 Support bidi reordering of text covered by display properties.
57f97249 10656
fec2107c
EZ
10657 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10658 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10659 (bidi_cache_search, bidi_cache_iterator_state)
10660 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10661 (bidi_level_of_next_char, bidi_move_to_visually_next):
10662 Support character positions inside a run of characters covered by a
fec2107c
EZ
10663 display string.
10664 (bidi_paragraph_init, bidi_resolve_explicit_1)
10665 (bidi_level_of_next_char): Call bidi_fetch_char and
10666 bidi_fetch_char_advance instead of FETCH_CHAR and
10667 FETCH_CHAR_ADVANCE.
10668 (bidi_init_it): Initialize new members.
10669 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10670 definitions.
10671 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10672 instead of using explicit *_CHAR codes.
d6d100dd
SM
10673 (bidi_resolve_explicit, bidi_resolve_weak):
10674 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10675 bidirectional text is supported only in multibyte buffers.
10676 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10677 it to initialize the frame_window_p member of struct bidi_it.
10678 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10679 (bidi_resolve_explicit, bidi_resolve_weak)
10680 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10681 bidi_it->nchars is non-positive.
10682 (bidi_level_of_next_char): Don't try to lookup the cache for the
10683 next/previous character if nothing is cached there yet, or if we
10684 were just reseat()'ed to a new position.
c40e2fb2 10685
0e14fe90
EZ
10686 * xdisp.c (set_cursor_from_row): Set start and stop points
10687 according to the row's direction when priming the loop that looks
10688 for the glyph on which to display cursor.
10689 (single_display_spec_intangible_p): Function deleted.
10690 (display_prop_intangible_p): Reimplement to call
10691 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10692 Accept 3 additional arguments needed by handle_display_spec.
10693 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10694 values: lists, `(when COND...)' forms, etc.
10695 (single_display_spec_string_p): Support property values that are
10696 lists with the argument STRING its top-level element.
10697 (display_prop_string_p): Fix the condition for processing a
10698 property that is a list to be consistent with handle_display_spec.
fec2107c 10699 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10700 last portion of handle_display_prop.
10701 (compute_display_string_pos): Accept additional argument
10702 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10703 value of a `display' property is a "replacing spec".
10704 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10705 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10706 the display property, but just return a value indicating whether
10707 the display property will replace the characters it covers.
10708 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10709 frame_window_p members of struct bidi_it.
d6d100dd
SM
10710 (compute_display_string_pos, compute_display_string_end):
10711 New functions.
fec2107c
EZ
10712 (push_it): Accept second argument POSITION, where pop_it should
10713 jump to continue iteration.
10714 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10715
fec2107c
EZ
10716 * keyboard.c (adjust_point_for_property): Adjust the call to
10717 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10718
10719 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10720 (bidi_init_it): Update prototypes.
10721 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10722 (compute_display_string_pos, compute_display_string_end):
10723 Declare prototypes.
fec2107c
EZ
10724 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10725 EMACS_INT.
fc6f18ce 10726
40087514 107272011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10728
57f53182
PE
10729 Malloc failure behavior now depends on size of allocation.
10730 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10731 * lisp.h: Change signatures accordingly.
10732 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10733 All callers changed. (Bug#8762)
10734
10735 * gnutls.c: Use Emacs's memory allocators.
10736 Without this change, the gnutls library would invoke malloc etc.
10737 directly, which causes problems on non-SYNC_INPUT hosts, and which
10738 runs afoul of improving memory_full behavior. (Bug#8761)
10739 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10740 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10741 xfree instead of the default malloc, realloc, free.
10742 (Fgnutls_boot): No need to check for memory allocation failure,
10743 since xmalloc does that for us.
10744
ac32cd99 10745 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10746 * category.c (hash_get_category_set):
10747 * ccl.c (ccl_driver):
10748 * charset.c (Fdefine_charset_internal):
10749 * charset.h (struct charset.hash_index):
10750 * composite.c (get_composition_id, gstring_lookup_cache)
10751 (composition_gstring_put_cache):
10752 * composite.h (struct composition.hash_index):
10753 * dispextern.h (struct image.hash):
10754 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10755 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10756 (hashfn_equal, hashfn_user_defined, make_hash_table)
10757 (maybe_resize_hash_table, hash_lookup, hash_put)
10758 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10759 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10760 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10761 * image.c (make_image, search_image_cache, lookup_image)
10762 (xpm_put_color_table_h):
10763 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10764 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10765 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10766 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10767 * alloc.c (allocate_vectorlike):
10768 Check for overflow in vector size calculations.
10769 * ccl.c (ccl_driver):
10770 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10771 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10772 need to be updated by these changes.
40087514
PE
10773 * fns.c (make_hash_table, maybe_resize_hash_table):
10774 Check for integer overflow with large hash tables.
0de4bb68
PE
10775 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10776 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10777 (SXHASH_REDUCE): New macro.
10778 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10779 Use it instead of discarding useful hash info with large hash values.
10780 (sxhash_float): New function.
10781 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10782 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10783 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10784 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10785 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10786 Adjust signatures to match updated version of code.
10787 (consing_since_gc): Now EMACS_INT, since a single hash table can
10788 use more than INT_MAX bytes.
10789
698d32e2
DN
107902011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10791
10792 Make it possible to build with GCC-4.6+ -O2 -flto.
10793
10794 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10795
fd6fa53f
SM
107962011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10797
10798 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10799 Call minibuffer-inactive-mode.
10800
864db017
JB
108012011-05-31 Juanma Barranquero <lekktu@gmail.com>
10802
10803 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10804 Update dependencies.
10805
2ad0baf4
DN
108062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10807
10808 * data.c (init_data): Remove code for UTS, this system is not
10809 supported anymore.
10810
4fcc2638
DN
108112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10812
10813 Don't force ./temacs to start in terminal mode.
10814
10815 * frame.c (make_initial_frame): Initialize faces in all cases, not
10816 only when CANNOT_DUMP is defined.
10817 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10818
c56e0fd5
DN
108192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10820
10821 * dispnew.c (add_window_display_history): Use const for the string
10822 pointer. Remove declaration, not needed.
10823
333d54da 108242011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10825
55d4c1b2 10826 Use 'inline', not 'INLINE'.
333d54da 10827 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10828 * alloc.c, fontset.c (INLINE): Remove.
10829 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10830 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10831 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10832 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10833 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10834
738db178
DN
108352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10836
10837 Make it possible to run ./temacs.
10838
10839 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10840 syms_of_callproc does the same thing. Remove test for
10841 "initialized", do it in the caller.
10842 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10843
620c53a6
SM
108442011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10845
10846 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10847 (read_minibuf): Use get_minibuffer.
10848 (syms_of_minibuf): Use DEFSYM.
10849 (Qmetadata): New var.
10850 * data.c (Qbuffer): Don't make it static.
10851 (syms_of_data): Use DEFSYM.
10852
e003a292
PE
108532011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10854
10855 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10856 (CCL_CODE_MIN): New macro.
10857
ed008a6d
PE
108582011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10859
3687c2ef
PE
10860 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10861
ed008a6d
PE
10862 * eval.c (Qdebug): Now static.
10863 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10864 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10865 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10866
d66c4c7c
CY
108672011-05-29 Chong Yidong <cyd@stupidchicken.com>
10868
10869 * image.c: Various fixes to ImageMagick code comments.
10870 (Fimagemagick_types): Doc fix.
10871
5fbc2025
PE
108722011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10873
0196f88a
PE
10874 Minor fixes prompted by GCC 4.6.0 warnings.
10875
10876 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10877
5fbc2025
PE
10878 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10879 (x_clipboard_manager_save_all): Move extern decl to ...
10880 * xterm.h: ... here, so that it can be checked for consistency.
10881
1dd3c2d9
CY
108822011-05-29 Chong Yidong <cyd@stupidchicken.com>
10883
10884 * xselect.c (x_clipboard_manager_save_frame)
10885 (x_clipboard_manager_save_all): New functions.
10886 (Fx_clipboard_manager_save): Lisp function deleted.
10887
10888 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10889 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10890
10891 * xterm.h: Update prototype.
10892
5ba6571d
WX
108932011-05-28 William Xu <william.xwl@gmail.com>
10894
10895 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10896 exiting (Bug#8239).
10897
3eaff834
JM
108982011-05-28 Jim Meyering <meyering@redhat.com>
10899
e1900994 10900 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10901 * fns.c (to_uchar): Define.
10902 (crypto_hash_function): Use it to convert some newly-signed
10903 variables to unsigned, to avoid sign-extension bugs. For example,
10904 without this change, (md5 "truc") would evaluate to
10905 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10906 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10907 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10908
0f6990a7
PE
109092011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10910
10911 Integer overflow fixes.
c8a9ca5a 10912
08686060
PE
10913 * dbusbind.c: Serial number integer overflow fixes.
10914 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10915 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10916 to hold a serial number that is too large for a fixnum.
10917 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10918 Check for serial numbers out of range. Decode any serial number
59568bf0 10919 that was so large that it became a float. (Bug#8722)
08686060 10920
2d1fc3c7
PE
10921 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10922 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10923 Use XFASTINT rather than XUINT when numbers are nonnegative.
10924 (xd_append_arg, Fdbus_method_return_internal):
10925 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10926 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10927 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10928 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10929 (Bug#8722)
2d1fc3c7 10930
c8a9ca5a
PE
10931 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10932
519e1d69
PE
10933 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10934
6df6ae42 10935 ccl: Add integer overflow checks.
30569699
PE
10936 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10937 (IN_INT_RANGE): New macros.
10938 (ccl_driver): Use them to check for integer overflow when
10939 decoding a CCL program. Many of the new checks are whether XINT (x)
10940 fits in int; it doesn't always, on 64-bit hosts. The new version
10941 doesn't catch all possible integer overflows, but it's an
847044ea 10942 improvement. (Bug#8719)
30569699 10943
c11285dc
PE
10944 * alloc.c (make_event_array): Use XINT, not XUINT.
10945 There's no need for unsigned here.
10946
fdccd48e
PE
10947 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10948 This follows up to the 2011-05-06 change that substituted uintptr_t
10949 for EMACS_INT. This case wasn't caught back then.
10950
37910ab2
PE
10951 Rework Fformat to avoid integer overflow issues.
10952 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10953 now (part of C89). Include <verify.h>.
10954 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10955 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10956 (Fformat): Avoid the prepass trying to compute sizes; it was only
10957 approximate and thus did not catch overflow reliably. Instead, walk
10958 through the format just once, formatting and computing sizes as we go,
10959 checking for integer overflow at every step, and allocating a larger
10960 buffer as needed. Keep track separately whether the format is
10961 multibyte. Keep only the most-recently calculated precision, rather
10962 than them all. Record whether each argument has been converted to
10963 string. Use EMACS_INT, not int, for byte and char and arg counts.
10964 Support field widths and precisions larger than INT_MAX. Avoid
10965 sprintf's undefined behavior with conversion specifications such as %#d
10966 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10967 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10968 formatting out-of-range floating point numbers with int
9173deec 10969 formats. (Bug#8668)
37910ab2 10970
2e6578fb
PE
10971 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10972
0ae6bdee
PE
10973 * data.c: Avoid integer truncation in expressions involving floats.
10974 * data.c: Include <intprops.h>.
10975 (arith_driver): When there's an integer overflow in an expression
10976 involving floating point, convert the integers to floating point
10977 so that the resulting value does not suffer from catastrophic
10978 integer truncation. For example, on a 64-bit host (* 4
10979 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10980 Do not rely on undefined behavior after integer overflow.
10981
de883a70
PE
10982 merge count_size_as_multibyte, parse_str_to_multibyte
10983 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10984 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10985 Check for integer overflow.
10986 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10987 since it's now a duplicate of the other. This is more of
10988 a character than a buffer op, so better that it's in character.c.
10989 * fns.c, print.c: Adjust to above changes.
10990
2ff916cb
PE
109912011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10992
10993 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10994
f1b54466
PE
109952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10996
fb1ac845
PE
10997 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10998 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10999 (x_clipboard_manager_save): Now static.
11000 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11001
f1b54466
PE
11002 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11003 (crypto_hash_function): Now static.
11004 Fix pointer signedness problems. Avoid unnecessary initializations.
11005
a9f737ee
CY
110062011-05-27 Chong Yidong <cyd@stupidchicken.com>
11007
11008 * termhooks.h (Vselection_alist): Make it terminal-local.
11009
11010 * terminal.c (create_terminal): Initialize it.
11011
11012 * xselect.c: Support for clipboard managers.
11013 (Vselection_alist): Move to termhooks.h as terminal-local var.
11014 (LOCAL_SELECTION): New macro.
11015 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11016 (symbol_to_x_atom): Remove gratuitous arg.
11017 (x_handle_selection_request, lisp_data_to_selection_data)
11018 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11019 (x_own_selection, x_get_local_selection, x_convert_selection):
11020 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11021 (some_frame_on_display): Delete unused function.
11022 (Fx_own_selection_internal, Fx_get_selection_internal)
11023 (Fx_disown_selection_internal, Fx_selection_owner_p)
11024 (Fx_selection_exists_p): New optional frame arg.
11025 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11026 (x_handle_selection_clear): Don't treat other terminals with the
11027 same keyboard specially. Use the terminal-local Vselection_alist.
11028 (x_clear_frame_selections): Use Frun_hook_with_args.
11029
11030 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11031
11032 * xterm.h: Add support for those atoms.
11033
e067f0c1
CY
110342011-05-26 Chong Yidong <cyd@stupidchicken.com>
11035
11036 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11037 (converted_selections, conversion_fail_tag): New global variables.
11038 (x_selection_request_lisp_error): Free the above.
11039 (x_get_local_selection): Remove unnecessary code.
11040 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11041 of converted selections stored in converted_selections.
11042 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11043 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11044 (x_convert_selection): New function.
11045 (x_handle_selection_event): Simplify.
11046 (x_get_foreign_selection): Don't ignore incoming requests while
11047 waiting for an answer; this will fail when we implement
11048 SAVE_TARGETS, and seems unnecessary anyway.
11049 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11050 (Vx_sent_selection_functions): Doc fix.
11051
0f4aebc0
LL
110522011-05-26 Leo Liu <sdl.web@gmail.com>
11053
11054 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11055
e61124cd
YM
110562011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11057
11058 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11059
11060 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11061 for fringe update if it has periodic bitmap.
ac389d0c 11062 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11063 and fringe_bitmap_periodic_p.
11064
11065 * fringe.c (get_fringe_bitmap_data): New function.
11066 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11067 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11068 row. Mark glyph row for fringe update if periodicity changed.
11069
11070 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11071 for fringe update unless it has periodic bitmap.
11072
f16d9837
KH
110732011-05-25 Kenichi Handa <handa@m17n.org>
11074
11075 * xdisp.c (get_next_display_element): Set correct it->face_id for
11076 a static composition.
11077
e1b90ef6
LL
110782011-05-24 Leo Liu <sdl.web@gmail.com>
11079
11080 * deps.mk (fns.o):
11081 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11082
11083 * fns.c (crypto_hash_function, Fsha1): New function.
11084 (Fmd5): Use crypto_hash_function.
11085 (syms_of_fns): Add Ssha1.
11086
7400048f
PE
110872011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11088
11089 * gnutls.c: Remove unused macros.
11090 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11091 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11092 Remove macros that are defined and never used.
11093 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11094
abb71cf4
CY
110952011-05-22 Chong Yidong <cyd@stupidchicken.com>
11096
11097 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11098 (Fx_get_selection_internal): Minor cleanup.
11099 (Fx_own_selection_internal): Rename arguments for consistency with
11100 select.el.
11101
6307db39
PE
111022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11103
11104 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11105
f3d4e0a4
CY
111062011-05-22 Chong Yidong <cyd@stupidchicken.com>
11107
11108 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11109
4d8ade89
YM
111102011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11111
11112 * dispnew.c (scrolling_window): Don't exclude the case that the
11113 last enabled row in the desired matrix touches the bottom boundary.
11114
32078c8d
GM
111152011-05-21 Glenn Morris <rgm@gnu.org>
11116
11117 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11118 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11119 and add some more files.
32078c8d 11120
7285dc67
EZ
111212011-05-20 Eli Zaretskii <eliz@gnu.org>
11122
11123 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11124 report_file_error introduced by the change from 2011-05-07.
11125
89d1bd22
PE
111262011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11127
11128 * systime.h (Time): Define only if emacs is defined.
11129 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11130 where the include path doesn't have X11/X.h by default. See
11131 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11132
cd394be1 111332011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11134
11135 * composite.c (find_automatic_composition): Fix previous change.
11136
b9704ad9
GM
111372011-05-20 Glenn Morris <rgm@gnu.org>
11138
11139 * lisp.mk: New file, split from Makefile.in.
11140 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11141 (shortlisp): Remove.
11142 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11143
4a720484
GM
111442011-05-19 Glenn Morris <rgm@gnu.org>
11145
11146 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11147 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11148 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11149 (lisp): Set the order to that of loadup.el.
11150 (shortlisp): Make it a copy of $lisp.
11151 (SOME_MACHINE_LISP): Remove.
11152 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11153 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11154
a28d4396
KH
111552011-05-18 Kenichi Handa <handa@m17n.org>
11156
11157 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11158 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11159 (find_automatic_composition): Mostly rewrite for efficiency.
11160
a2b1fa8e
JB
111612011-05-18 Juanma Barranquero <lekktu@gmail.com>
11162
11163 * makefile.w32-in: Update dependencies.
11164
8e1f5610
CS
111652011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11166
11167 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11168 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11169
7025ee00 111702011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11171
cdfa6eab
PE
11172 Fix some integer overflow issues, such as string length overflow.
11173
06d6db33
PE
11174 * insdel.c (count_size_as_multibyte): Check for string overflow.
11175
2b4560a8
PE
11176 * character.c (lisp_string_width): Check for string overflow.
11177 Use EMACS_INT, not int, for string indexes and lengths; in
11178 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11179 the resulting string length overflows an EMACS_INT; instead,
11180 report a string overflow if no precision given. When checking for
11181 precision exhaustion, use a check that cannot possibly have
11182 integer overflow. (Bug#8675)
11183 * character.h (lisp_string_width): Adjust to new signature.
11184
cb93f9be
PE
11185 * alloc.c (string_overflow): New function.
11186 (Fmake_string): Use it. This doesn't change behavior, but saves
11187 a few bytes and will simplify future changes.
11188 * character.c (string_escape_byte8): Likewise.
11189 * lisp.h (string_overflow): New decl.
11190
1a1f3366
PE
11191 Fixups, following up to the user-interface timestamp change.
11192 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11193 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11194 * msdos.c (mouse_get_pos): Likewise.
11195 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11196 * w32gui.h (Time): Define by including "systime.h" rather than by
11197 declaring it ourselves. (Bug#8664)
11198
d4e3e4d3
PE
11199 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11200 * image.c (clear_image_cache): Likewise.
11201
f6a24d19
PE
11202 * term.c (term_mouse_position): Don't assume time_t wraparound.
11203
08dc5ae6
PE
11204 Be more systematic about user-interface timestamps.
11205 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11206 and sometimes 'EMACS_UINT', to represent these timestamps.
11207 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11208 This makes the code easier to follow, and makes it easier to catch
11209 integer overflow bugs such as Bug#8664.
11210 * frame.c (Fmouse_position, Fmouse_pixel_position):
11211 Use Time, not unsigned long, for user-interface timestamps.
11212 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11213 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11214 * keyboard.h (last_event_timestamp): Likewise.
11215 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11216 * menu.h (xmenu_show): Likewise.
11217 * term.c (term_mouse_position): Likewise.
11218 * termhooks.h (struct input_event.timestamp): Likewise.
11219 (struct terminal.mouse_position_hook): Likewise.
11220 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11221 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11222 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11223 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11224 what it was before.
11225 * menu.h, termhooks.h: Include "systime.h", for Time.
11226
8e55734a
PE
11227 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11228 Don't assume that the difference between two unsigned long values
11229 can fit into an integer. At this point, we know button_down_time
11230 <= event->timestamp, so the difference must be nonnegative, so
11231 there's no need to cast the result if double-click-time is
11232 nonnegative, as it should be; check that it's nonnegative, just in
11233 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11234 apart (about 25 days). (Bug#8664)
8e55734a 11235
841f1b75 11236 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11237 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11238
3e26f69c
PE
11239 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11240 that always fit in int. Use a sentinel instead of a counter, to
11241 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11242 * frame.h (struct frame): Use int for menu_bar_items_used
11243 instead of EMACS_INT, since it always fits in int.
3e26f69c 11244
5cc152c0
PE
11245 * menu.c (grow_menu_items): Check for int overflow.
11246
d89eb65e
PE
11247 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11248
5235bd3e
PE
11249 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11250 Before, the code was not consistent. These values cannot exceed
11251 2**31 - 1 so there's no need to make them unsigned.
11252 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11253 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11254 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11255 as modifiers.
11256 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11257
bc827e23
PE
11258 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11259 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11260 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11261 presumably because the widths might not match.
11262
78eb494e
PE
11263 * window.c (size_window): Avoid needless test at loop start.
11264
04f2d78b
CB
112652011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11266
11267 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11268
d2fc7e3d 112692011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11270
11271 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11272
d2fc7e3d 112732011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11274
11275 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11276 `width' to `bar_area_x' and `bar_area_width', respectively.
11277 (x_scroll_run): Take account of fringe background extension.
11278
04f2d78b
CB
11279 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11280 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11281 `bar_area_width', respectively.
11282 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11283 background extension.
11284
79b70037
GM
112852011-05-10 Jim Meyering <meyering@redhat.com>
11286
11287 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11288
2f142cc5
JB
112892011-05-10 Juanma Barranquero <lekktu@gmail.com>
11290
11291 * image.c (Finit_image_library): Return t for built-in image types,
11292 like pbm and xbm. (Bug#8640)
11293
57679c86
AS
112942011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11295
11296 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11297
888c9e86
EZ
112982011-05-07 Eli Zaretskii <eliz@gnu.org>
11299
b0512a1d
EZ
11300 * w32console.c (Fset_screen_color): Doc fix.
11301 (Fget_screen_color): New function.
11302 (syms_of_ntterm): Defsubr it.
11303
7285dc67
EZ
11304 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11305 unlink the temporary file if Fcall_process didn't create it in the
11306 first place.
11307 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11308 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11309 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11310 cue to call_process_cleanup not to close that handle.
11311
4d3fcc8e
BK
113122011-05-07 Ben Key <bkey76@gmail.com>
11313
11314 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11315 one of two shell specific rules, either bootstrap-temacs-CMD or
11316 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11317 to the previous implementation of the bootstrap-temacs rule.
11318 The bootstrap-temacs-CMD rule is similar to the previous
11319 implementation of the bootstrap-temacs rule except that it
11320 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11321 variable.
11322
11323 These changes, along with some changes to nt/configure.bat,
11324 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11325 earlier fix to add support for --cflags and --ldflags options
11326 that include quotes so that it works whether make uses cmd or
11327 sh as the shell.
11328
b4289b64
MA
113292011-05-06 Michael Albinus <michael.albinus@gmx.de>
11330
11331 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11332 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11333 is a constant.
11334 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11335 a string. Handle both cases.
11336 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11337 (Fdbus_register_method): Use Qinvalid_function.
11338
af4c0e28
JB
113392011-05-06 Juanma Barranquero <lekktu@gmail.com>
11340
11341 * makefile.w32-in: Update dependencies.
11342 (LISP_H): Add inttypes.h and stdin.h.
11343 (PROCESS_H): Add unistd.h.
11344
c51453d9
EZ
113452011-05-06 Eli Zaretskii <eliz@gnu.org>
11346
11347 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11348 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11349
8ff0ac3c 113502011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11351
4c4b566b
PE
11352 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11353
aab2b9b5
PE
11354 * term.c (vfatal): Remove stray call to va_end.
11355 It's not needed and the C Standard doesn't allow it here anyway.
11356
c378da0b
PE
11357 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11358 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11359
288b08c7
PE
11360 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11361 bytes.
11362
e3601888
PE
11363 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11364
db6c0e74
PE
11365 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11366
dd5963ea
PE
11367 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11368
88c9450f
PE
11369 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11370
2f9442b8
PE
11371 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11372
c032b5f8
PE
11373 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11374 * charset.c (Fdefine_charset_internal): Don't initialize
11375 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11376 32-bit int (Bug#8600).
a108c10b
PE
11377
11378 * lread.c (read_integer): Be more consistent with string-to-number.
11379 Use string_to_number to do the actual conversion; this avoids
11380 rounding errors and fixes some other screwups. Without this fix,
11381 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11382 (digit_to_number): Move earlier, for benefit of read_integer.
11383 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11384 not a digit in any supported base. (Bug#8602)
a108c10b 11385
ad5f9eea
PE
11386 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11387
aec1708a
PE
11388 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11389 to match comment at start of function. This also removes a
11390 GCC warning about overflow in a 32+64-bit port.
11391
47be4ab5
PE
11392 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11393
371cac43
PE
11394 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11395 Reported by Stefan Monnier in
11396 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11397 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11398 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11399
d01a7826
PE
11400 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11401 (EMACS_UINTPTR): Likewise, with uintptr_t.
11402
7fd47d5c
PE
11403 * lisp.h: Prefer 64-bit EMACS_INT if available.
11404 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11405 on 32-bit hosts that have 64-bit int, so that they can access
11406 large files.
122b0c86
PE
11407 However, temporarily disable this change unless the temporary
11408 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11409
8727937b
PE
11410 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11411
8ac068ac
PE
11412 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11413 This removes an assumption that EMACS_INT and long are the same
11414 width as pointers. The assumption is true for Emacs porting targets
11415 now, but we want to make other targets possible.
11416 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11417 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11418 In the rest of the code, change types of integers that hold casted
11419 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11420 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11421 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11422 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11423 No need to cast type when ORing.
11424 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11425 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11426 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11427 assume EMACS_INT is the same width as char *.
11428 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11429 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11430 Remove no-longer-needed casts.
11431 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11432 (xg_tool_bar_help_callback, xg_make_tool_item):
11433 Use EMACS_INTPTR to hold an integer
11434 that will be cast to void *; this can avoid a GCC warning
11435 if EMACS_INT is not the same width as void *.
11436 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11437 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11438 (current_message_1, set_message_1):
11439 Use a local to convert to proper width without a cast.
11440 * xmenu.c (dialog_selection_callback): Likewise.
11441
ede49d71
PE
11442 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11443 Also, don't assume VALBITS / RAND_BITS is less than 5,
11444 and don't rely on undefined behavior when shifting a 1 left into
11445 the sign bit.
11446 * lisp.h (get_random): Change signature to match.
11447
2f30ecd0
PE
11448 * lread.c (hash_string): Use size_t, not int, for hash computation.
11449 Normally we prefer signed values; but hashing is special, because
11450 it's better to use unsigned division on hash table sizes so that
11451 the remainder is nonnegative. Also, size_t is the natural width
11452 for hashing into memory. The previous code used 'int', which doesn't
11453 retain enough info to hash well into very large tables.
11454 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11455
2a866e7b
PE
11456 * dbusbind.c: Don't possibly lose pointer info when converting.
11457 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11458 Use XPNTR rather than XHASH, so that the high-order bits of
11459 the pointer aren't lost when converting through void *.
11460
51639eac
PE
11461 * eval.c (Fautoload): Don't double-shift a pointer.
11462
92394119
PE
11463 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11464
dbdb9a7c
JB
114652011-05-06 Juanma Barranquero <lekktu@gmail.com>
11466
11467 * gnutls.c (DEF_GNUTLS_FN):
11468 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11469
db7a0b4f
AS
114702011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11471
11472 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11473 marker. (Bug#8610)
11474
cd394be1 114752011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11476
11477 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11478 New version that can reserve upto 2GB of heap space.
11479
f7ff1b0f 114802011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11481
11482 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11483
639c109b
TZ
114842011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11485
11486 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11487 `gnutls_certificate_set_x509_key_file'.
11488
d2127135
JB
114892011-05-05 Juanma Barranquero <lekktu@gmail.com>
11490
11491 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11492 Update dependencies.
11493
e968f4f3
JB
114942011-05-04 Juanma Barranquero <lekktu@gmail.com>
11495
11496 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11497 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11498 Remove unused parameter `fildes'.
11499 * process.c (read_process_output, send_process): Don't pass it.
11500
84d358f0
JB
115012011-05-04 Juanma Barranquero <lekktu@gmail.com>
11502
11503 Fix previous change: the library cache is defined in w32.c.
11504 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11505 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11506
0898ca10
JB
115072011-05-04 Juanma Barranquero <lekktu@gmail.com>
11508
11509 Implement dynamic loading of GnuTLS on Windows.
11510
11511 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11512 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11513 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11514 Declare.
11515
11516 * gnutls.c (Qgnutls_dll): Define.
11517 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11518 (gnutls_*): Declare function pointers.
11519 (init_gnutls_functions): New function to initialize function pointers.
11520 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11521 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11522 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11523 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11524 (emacs_gnutls_write, emacs_gnutls_read)
11525 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11526 (Fgnutls_available_p): New function.
11527 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11528 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11529 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11530
11531 * image.c: Include w32.h.
11532 (Vimage_type_cache): Delete.
11533 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11534 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11535 (w32_delayed_load): Move to w32.c.
11536
11537 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11538
11539 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11540 (w32_delayed_load): Move from image.c. When loading a library, record
11541 its filename in the :loaded-from property of the library id.
11542 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11543 Initialize and staticpro them.
11544 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11545
11546 * process.c: Include lisp.h before w32.h, not after.
11547 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11548 instead of gnutls_record_check_pending.
11549
11550 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11551
ff4de4aa
TZ
115522011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11553
11554 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11555 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11556 as passed in.
11557
abe95abb
JD
115582011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11559
11560 * xterm.c (x_set_frame_alpha): Do not set property on anything
11561 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11562
e16e55d4
JB
115632011-05-02 Juanma Barranquero <lekktu@gmail.com>
11564
11565 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11566
bafcf6a5
JB
115672011-05-02 Juanma Barranquero <lekktu@gmail.com>
11568
11569 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11570 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11571 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11572 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11573 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11574 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11575 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11576 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11577 (Qgnutls_bootprop_callbacks_verify): Make static.
11578
e7a6747f
AS
115792011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11580
19ed11ba
AS
11581 * callproc.c: Indentation fixup.
11582
e7a6747f 11583 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11584 (wait_for_termination, interruptible_wait_for_termination):
11585 Move after wait_for_termination_1.
e7a6747f 11586
1ef14cb4
LMI
115872011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11588
11589 * sysdep.c (interruptible_wait_for_termination): New function
11590 which is like wait_for_termination, but allows keyboard
11591 interruptions.
11592
11593 * callproc.c (Fcall_process): Add (:file "file") as an option for
11594 the STDOUT buffer.
11595 (Fcall_process_region): Ditto.
11596
330d880c
EZ
115972011-04-30 Eli Zaretskii <eliz@gnu.org>
11598
8db90b73
EZ
11599 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11600 rather than `XVECTOR (FOO)->size'.
11601
330d880c
EZ
11602 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11603 inttypes.h, as a gnulib replacement is used if it not available in
11604 system headers.
11605
15cbd324
EZ
116062011-04-21 Eli Zaretskii <eliz@gnu.org>
11607
11608 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11609 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11610 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11611
11612 * coding.c (coding_alloc_by_realloc): Error out if destination
11613 will grow beyond MOST_POSITIVE_FIXNUM.
11614 (decode_coding_emacs_mule): Abort if there isn't enough place in
11615 charbuf for the composition carryover bytes. Reserve an extra
11616 space for up to 2 characters produced in a loop.
11617 (decode_coding_iso_2022): Abort if there isn't enough place in
11618 charbuf for the composition carryover bytes.
11619
116202011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11621
ae940cca
EZ
11622 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11623 aborting when %lld or %lll format is passed.
11624 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11625 %llo or %llx format is passed. (Bug#8545)
11626
03ab8921
EZ
11627 * window.c (window_scroll_line_based): Use a marker instead of
11628 simple variables to record original value of point. (Bug#7952)
11629
afda1437
EZ
11630 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11631 produced by %s or %c overflows available buffer space. (Bug#8545)
11632
f76dee0c
PE
116332011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11634
11635 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11636 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11637
fdc5744d
JB
116382011-04-28 Juanma Barranquero <lekktu@gmail.com>
11639
11640 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11641
638f053a
JB
116422011-04-28 Juanma Barranquero <lekktu@gmail.com>
11643
11644 * keyboard.c (Qdelayed_warnings_hook): Define.
11645 (command_loop_1): Run `delayed-warnings-hook'
11646 if Vdelayed_warnings_list is non-nil.
11647 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11648 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11649
d178f871
EZ
116502011-04-28 Eli Zaretskii <eliz@gnu.org>
11651
11652 * doprnt.c (doprnt): Don't return value smaller than the buffer
11653 size if the message was truncated. (Bug#8545).
11654
b124fd93
JB
116552011-04-28 Juanma Barranquero <lekktu@gmail.com>
11656
11657 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11658 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11659
e810457d
PE
116602011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11661
11662 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11663
ea51cceb
JB
116642011-04-27 Juanma Barranquero <lekktu@gmail.com>
11665
11666 * makefile.w32-in: Update dependencies.
11667
94dcfacf
EZ
116682011-04-27 Eli Zaretskii <eliz@gnu.org>
11669
11670 Improve `doprnt' and its usage. (Bug#8545)
11671 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11672 `format_end'. Remove support for %l as a conversion specifier.
11673 Don't use xrealloc. Improve diagnostics when the %l size modifier
11674 is used. Update the commentary.
11675
11676 * eval.c (verror): Simplify calculation of size_t.
11677
11678 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11679 messages.
11680
f61f41d7
PE
116812011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11682
11683 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11684 change.
11685
96fb4434
PE
116862011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11687
11688 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11689 This makes this file independent of the recent pseudovector change.
11690
671875da 116912011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11692
69e9b5a3
PE
11693 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11694
b5f869a7 11695 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11696 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11697 Remove unused local.
c8926152 11698 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11699
841a1577 11700 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11701 GCC 4.6.0 optimizes based on type-based alias analysis.
11702 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11703 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11704 != &v->size, and therefore "v->size = 1; b->size = 2; return
11705 v->size;" must therefore return 1. This assumption is incorrect
11706 for Emacs, since it type-puns struct Lisp_Vector * with many other
11707 types. To fix this problem, this patch adds a new type struct
f904488f 11708 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11709 and pseudovectors, and helps optimizing compilers not get fooled
11710 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11711 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11712 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11713 the size member.
eab3844f
PE
11714 (XSETPVECTYPE): Rewrite in terms of new macro.
11715 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11716 This is a bit clearer, and further avoids the possibility of
11717 undesirable aliasing.
11718 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11719 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11720 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11721 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11722 (ASIZE): Now uses header.size rather than size.
11723 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11724 to avoid the hassle of writing XVECTOR (foo)->header.size.
11725 (struct vectorlike_header): New type.
eab3844f
PE
11726 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11727 object, to help avoid aliasing.
11728 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11729 (SUBRP): Likewise, since Lisp_Subr is a special case.
11730 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11731 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11732 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11733 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11734 changed to be "header.size" and "header.next".
11735 * buffer.h (struct buffer): Likewise.
11736 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11737 * frame.h (struct frame): Likewise.
11738 * process.h (struct Lisp_Process): Likewise.
11739 * termhooks.h (struct terminal): Likewise.
11740 * window.c (struct save_window_data, struct saved_window): Likewise.
11741 * window.h (struct window): Likewise.
11742 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11743 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11744 * buffer.c (init_buffer_once): Likewise.
11745 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11746 special case.
11747 * process.c (Fformat_network_address): Use local var for size,
11748 for brevity.
11749
0df1eac5
PE
11750 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11751
847ab9d1 11752 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11753 * data.c (atof): Remove decl; no longer used or needed.
11754 (digit_to_number): Move to lread.c.
11755 (Fstring_to_number): Use new string_to_number function, to be
11756 consistent with how the Lisp reader treats infinities and NaNs.
11757 Do not assume that floating-point numbers represent EMACS_INT
11758 without losing information; this is not true on most 64-bit hosts.
11759 Avoid double-rounding errors, by insisting on integers when
11760 parsing non-base-10 numbers, as the documentation specifies.
11761 * lisp.h (string_to_number): New decl, replacing ...
11762 (isfloat_string): Remove.
bc0a5c13 11763 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11764 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11765 appears to have been a coding error. Similarly, do not accept
11766 strings like +-1e0 as floating point numbers. Do not report
11767 overflow for integer overflows unless the base is not 10 which
11768 means we have no simple and reliable way to continue.
11769 Break out the floating-point parsing into a new
11770 function string_to_number, so that Fstring_to_number parses
11771 floating point numbers consistently with the Lisp reader.
04f2d78b 11772 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11773 (E_CHAR, EXP_INT): Remove, replacing with ...
11774 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11775 (string_to_number): New function, replacing isfloat_string.
11776 This function checks for valid syntax and produces the resulting
11777 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11778 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11779 so that overflow for non-base-10 numbers is reported only when
11780 there's no portable and simple way to convert to floating point.
452f4150 11781
67769ffc
PE
11782 * textprop.c (set_text_properties_1): Rewrite for clarity,
11783 and to avoid GCC warning about integer overflow.
11784
c20db43f
PE
11785 * intervals.h (struct interval): Use EMACS_INT for members
11786 where EMACS_UINT might cause problems. See
11787 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11788 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11789 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11790 All uses changed.
37aa2f85
PE
11791 (offset_intervals): Tell GCC not to worry about length overflow
11792 when negating a negative length.
c20db43f 11793
2538aa2f
PE
11794 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11795 (overrun_check_free): Likewise.
11796
f2d3008d
PE
11797 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11798 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11799 word size.
11800
ec8df744
PE
11801 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11802 (gnutls_make_error): Rename local to avoid shadowing.
11803 (gnutls_emacs_global_deinit): ifdef out; not used.
11804 (Fgnutls_boot): Use const for pointer to readonly storage.
11805 Comment out unused local. Fix pointer signedness problems.
11806
640ee02d
PE
11807 * lread.c (openp): Don't stuff size_t into an 'int'.
11808 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11809 about possible signed overflow.
11810
6048fb2a
PE
11811 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11812 (GDK_KEY_g): Don't define if already defined.
11813 (xg_prepare_tooltip): Avoid pointer signedness problem.
11814 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11815
fa3c87e1
PE
11816 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11817 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11818
2172544b
PE
11819 * xfns.c (Fx_window_property): Simplify a bit,
11820 to make a bit faster and to avoid GCC 4.6.0 warning.
11821 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11822
9b821a21
PE
11823 * fns.c (internal_equal): Don't assume size_t fits in int.
11824
3c616cfa
PE
11825 * alloc.c (compact_small_strings): Tighten assertion a little.
11826
c2982e87
PE
11827 Replace pEd with more-general pI, and fix some printf arg casts.
11828 * lisp.h (pI): New macro, generalizing old pEd macro to other
11829 conversion specifiers. For example, use "...%"pI"d..." rather
11830 than "...%"pEd"...".
11831 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11832 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11833 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11834 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11835 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11836 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11837 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11838 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11839 64-bit hosts.
11840 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11841 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11842 * print.c (safe_debug_print, print_object): Likewise.
11843 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11844 to int.
6f04d126
PE
11845 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11846 avoiding the 0 flag, which is not portable.
c2982e87
PE
11847 * process.c (Fmake_network_process): Use pI to avoid cast.
11848 * region-cache.c (pp_cache): Likewise.
11849 * xdisp.c (decode_mode_spec): Likewise.
11850 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11851 behavior on 64-bit hosts with printf arg.
6f04d126 11852 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11853 (x_stop_queuing_selection_requests): Likewise.
11854 (x_get_window_property): Don't truncate byte count to an 'int'
11855 when tracing.
0b432f21 11856
5e073ec7
PE
11857 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11858 here, since it parses constructs like leading '-' and spaces,
11859 which are not wanted; and it overflows with large numbers.
11860 Instead, simply match F[0-9]+, which is what is wanted anyway.
11861
36372bf9
PE
11862 * alloc.c: Remove unportable assumptions about struct layout.
11863 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11864 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11865 (allocate_vectorlike, make_pure_vector): Use the new macros,
11866 plus offsetof, to remove unportable assumptions about struct layout.
11867 These assumptions hold on all porting targets that I know of, but
11868 they are not guaranteed, they're easy to remove, and removing them
11869 makes further changes easier.
11870
0b432f21
PE
11871 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11872 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11873 (string_overrun_cookie): Now const. Use initializers that
11874 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11875 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11876 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11877 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11878 multiple of sizeof (EMACS_INT); it need not be, if
11879 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11880 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11881
895009e1
JB
118822011-04-26 Juanma Barranquero <lekktu@gmail.com>
11883
11884 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11885
6a7a1b0b
TZ
118862011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11887
11888 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11889 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11890 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11891
841a1577 118922011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11893
11894 * lisp.h (Qdebug): List symbol.
895009e1 11895 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11896 * keyboard.c (debug-on-event): New variable.
11897 (handle_user_signal): Break into debugger when debug-on-event
11898 matches the current signal symbol.
11899
f2d3ba6f
DN
119002011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11901
11902 * alloc.c (check_sblock, check_string_bytes)
11903 (check_string_free_list): Convert to standard C.
11904
42ce4c63
TZ
119052011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11906
11907 * w32.c (emacs_gnutls_push): Fix typo.
11908
825cd63c
EZ
119092011-04-25 Eli Zaretskii <eliz@gnu.org>
11910
fb11d64d
EZ
11911 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11912 "cast to pointer from integer of different size".
11913
825cd63c
EZ
11914 Improve doprnt and its use in verror. (Bug#8545)
11915 * doprnt.c (doprnt): Document the set of format control sequences
11916 supported by the function. Use SAFE_ALLOCA instead of always
11917 using `alloca'.
11918
11919 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11920 is one byte too soon. Don't use xrealloc; instead xfree and
11921 xmalloc anew.
11922
e061a11b
TZ
119232011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11924
11925 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11926 callbacks stage.
11927
11928 * gnutls.c: Renamed global_initialized to
11929 gnutls_global_initialized. Added internals for the
11930 :verify-hostname-error, :verify-error, and :verify-flags
11931 parameters of `gnutls-boot' and documented those parameters in the
11932 docstring. Start callback support.
9173deec
JB
11933 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11934 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11935 on error. Return error code.
e061a11b
TZ
11936 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11937 (emacs_gnutls_read): Likewise.
11938 (Fgnutls_boot): Return handshake error code.
11939 (emacs_gnutls_handle_error): New function.
11940 (wsaerror_to_errno): Likewise.
11941
11942 * w32.h (emacs_gnutls_pull): Add prototype.
11943 (emacs_gnutls_push): Likewise.
11944
11945 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11946 (emacs_gnutls_push): Likewise.
11947
119482011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11949
11950 * process.c (wait_reading_process_output): Check if GnuTLS
11951 buffered some data internally if no FDs are set for TLS
11952 connections.
11953
11954 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11955 (LIBS): Link to USER_LIBS.
11956 ($(BLD)/gnutls.$(0)): New target.
11957
fa6996bc
EZ
119582011-04-24 Eli Zaretskii <eliz@gnu.org>
11959
eb35682e
EZ
11960 * xdisp.c (handle_single_display_spec): Rename the
11961 display_replaced_before_p argument into display_replaced_p, to
11962 make it consistent with the commentary. Fix typos in the
11963 commentary.
11964
e2ad650c
EZ
11965 * textprop.c (syms_of_textprop): Remove dead code.
11966 (copy_text_properties): Delete obsolete commentary about an
11967 interface that was deleted long ago. Fix typos in the description
11968 of arguments.
11969
1b2de274
EZ
11970 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11971 to changes in oldXMenu/XMenu.h from 2011-04-16.
11972 <menu_help_message, prev_menu_help_message>: Constify.
11973 (IT_menu_make_room): menu->help_text is now `const char **';
11974 adjust.
11975
11976 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11977 to changes in oldXMenu/XMenu.h from 2011-04-16.
11978 (struct XMenu): Declare `help_text' `const char **'.
11979
11980 * xfaces.c <Qunspecified>: Make extern again.
11981
11982 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11983 required by POSIX.
1b2de274 11984
762b15be
EZ
11985 * doc.c (get_doc_string): Improve the format passed to `error'.
11986
11987 * doprnt.c (doprnt): Improve commentary.
11988
11989 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11990
11991 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11992 them with etags.
11993
f1052e5d
EZ
11994 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11995 changes in globals.h immediately force recompilation.
762b15be
EZ
11996 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11997 $(CURDIR)/s/ms-w32.h.
11998 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11999
fa6996bc
EZ
12000 * character.c (Fchar_direction): Function deleted.
12001 (syms_of_character): Don't defsubr it.
12002 <char-direction-table>: Deleted.
12003
e6c3da20
EZ
120042011-04-23 Eli Zaretskii <eliz@gnu.org>
12005
12006 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12007 * doprnt.c: Include limits.h.
12008 (SIZE_MAX): New macro.
04f2d78b
CB
12009 (doprnt): Return a size_t value. 2nd arg is now size_t.
12010 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12011 Improve overflow protection. Support `l' modifier for integer
12012 conversions. Support %l conversion. Don't assume an EMACS_INT
12013 argument for integer conversions and for %c.
12014
12015 * lisp.h (doprnt): Restore prototype.
12016
12017 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12018 $(SRC)/character.h.
12019
12020 * Makefile.in (base_obj): Add back doprnt.o.
12021
12022 * deps.mk (doprnt.o): Add back prerequisites.
12023 (callint.o): Depend on character.h.
12024
12025 * eval.c (internal_lisp_condition_case): Include the handler
12026 representation in the error message.
12027 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12028 when breaking from the loop.
12029
12030 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12031
12032 * callint.c (Fcall_interactively): When displaying error message
12033 about invalid control letter, pass the character's codepoint, not
12034 a pointer to its multibyte form. Improve display of the character
12035 in octal and display also its hex code.
12036
12037 * character.c (char_string): Use %x to display the (unsigned)
12038 codepoint of an invalid character, to avoid displaying a bogus
12039 negative value.
12040
12041 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12042 `error', not SYMBOL_NAME itself.
12043
12044 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12045 character arguments to `error'.
12046
12047 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12048 to `error' in error message about FINAL_CHAR argument. Make sure
12049 FINAL_CHAR is a character, and use %c when it is passed as
12050 argument to `error'.
12051
4ffd0d6b 120522011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12053
12054 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12055
12056 * w32.c: Include <time.h>.
12057 (sys_localtime): New function.
12058
4ffd0d6b 120592011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12060
12061 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12062
4ffd0d6b 12063 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12064
4ffd0d6b 120652011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12066
4ffd0d6b
GM
12067 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12068 zombies (Bug#8467).
aac0c6e3 12069
04c56954
EZ
120702011-04-19 Eli Zaretskii <eliz@gnu.org>
12071
12072 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12073 gl_state.e_property when gl_state.object is Qt.
12074
12075 * insdel.c (make_gap_larger): Remove limitation of buffer size
12076 to <= INT_MAX.
12077
16a43933
CY
120782011-04-18 Chong Yidong <cyd@stupidchicken.com>
12079
12080 * xdisp.c (lookup_glyphless_char_display)
12081 (produce_glyphless_glyph): Handle cons cell entry in
12082 glyphless-char-display.
12083 (Vglyphless_char_display): Document it.
12084
12085 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12086 glyphless-char-display.
12087
4581706e
CY
120882011-04-17 Chong Yidong <cyd@stupidchicken.com>
12089
12090 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12091
12092 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12093
12094 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12095 definition for no-X builds.
12096
4887c6e2 120972011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12098
fd35b6f9
PE
12099 Static checks with GCC 4.6.0 and non-default toolkits.
12100
5c1ccb01
PE
12101 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12102
006c5daa
PE
12103 * process.c (keyboard_bit_set): Define only if SIGIO.
12104 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12105 (send_process): Repair possible setjmp clobbering.
12106
efc736d3
PE
12107 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12108
4e2fe2e6
PE
12109 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12110
f97334a2
PE
12111 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12112
4e75f29d
PE
12113 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12114 Define only if needed.
12115
90efadd1
PE
12116 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12117 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12118 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12119
3c647824
PE
12120 * dispextern.h (struct redisplay_interface): Rename param
12121 to avoid shadowing.
e264f262 12122 * termhooks.h (struct terminal): Likewise.
761383f4 12123 * xterm.c (xembed_send_message): Likewise.
3c647824 12124
b58c5c4a
PE
12125 * insdel.c (make_gap_smaller): Define only if
12126 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12127
cad59032
PE
12128 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12129 it.
12130
c339dc2e
PE
12131 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12132 so that we aren't warned about unused symbols.
12133
91a3e27b
PE
12134 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12135
399c71d3 12136 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12137
8ffc96f5
PE
12138 * xfns.c (x_real_positions): Mark locals as initialized.
12139
eef9bc79
PE
12140 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12141
098db9dd
PE
12142 * xterm.c: Fix problems found by static analysis with other toolkits.
12143 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12144 (x_dispatch_event): Declare static if USE_GTK, and
12145 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12146 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12147 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12148 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12149 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12150
eb18f6cc
PE
12151 * xmenu.c (menu_help_callback): Pointer type fixes.
12152 Use const pointers when pointing at readonly data. Avoid pointer
12153 signedness clashes.
12154 (FALSE): Remove unused macro.
12155 (update_frame_menubar): Remove unused decl.
12156
1fe72bf8
PE
12157 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12158
60d9e1db
PE
12159 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12160 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12161 (single_menu_item): Rename local to avoid shadowing.
12162
39261c26
PE
12163 * keyboard.c (make_lispy_event): Remove unused local var.
12164
018c5e19
PE
12165 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12166 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12167
63d2b86e
PE
12168 * bitmaps: Change bitmaps from unsigned char back to the X11
12169 compatible char. Avoid the old compiler warnings about
12170 out-of-range initializers by using, for example, '\xab' rather
12171 than 0xab.
12172
aefd87e1
PE
12173 * xgselect.c (xgselect_initialize): Check vs interface
12174 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12175
bf501fb9
PE
12176 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12177
e9829fdf
PE
12178 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12179 to read-only memory.
12180
1086c095
PE
12181 * fns.c (vector): Remove; this old hack is no longer needed.
12182
2baccd04 12183 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12184 Remove unused var.
dde42981 12185 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12186
72391843 12187 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12188
436c16df 12189 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12190 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12191 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12192
92bb796d 12193 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12194 (x_term_init): Remove local to avoid shadowing.
92bb796d 12195
764430a3 12196 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12197
12198 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12199 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12200
d1dfb56c
EZ
122012011-04-16 Eli Zaretskii <eliz@gnu.org>
12202
c4354cb4
EZ
12203 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12204
d1dfb56c
EZ
12205 Fix regex.c, syntax.c and friends for buffers > 2GB.
12206 * syntax.h (struct gl_state_s): Declare character position members
12207 EMACS_INT.
12208
12209 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12210
04f2d78b
CB
12211 * textprop.c (verify_interval_modification, interval_of):
12212 Declare arguments EMACS_INT.
d1dfb56c
EZ
12213
12214 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12215 EMACS_INT.
12216
12217 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12218
12219 * indent.c (Fvertical_motion): Local variable it_start is now
12220 EMACS_INT.
12221
12222 * regex.c (re_match, re_match_2, re_match_2_internal)
12223 (bcmp_translate, regcomp, regexec, print_double_string)
12224 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12225 (re_compile_pattern, re_exec): Declare arguments and local
12226 variables `size_t' and `ssize_t' and return values `regoff_t', as
12227 appropriate.
12228 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12229 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12230 <compile_stack_type>: `size' and `avail' are now `size_t'.
12231
12232 * regex.h <regoff_t>: Use ssize_t, not int.
12233 (re_search, re_search_2, re_match, re_match_2): Arguments that
12234 specify buffer/string position and length are now ssize_t and
12235 size_t. Return type is regoff_t.
12236
613052cd
BK
122372011-04-16 Ben Key <bkey76@gmail.com>
12238
12239 * nsfont.m: Fixed bugs in ns_get_family and
12240 ns_descriptor_to_entity that were caused by using free to
12241 deallocate memory blocks that were allocated by xmalloc (via
12242 xstrdup). This caused Emacs to crash when compiled with
12243 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12244 --enable-checking=xmallocoverrun). xfree is now used to
12245 deallocate these memory blocks.
12246
4170f62f 122472011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12248
71b41406
PE
12249 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12250
9587a89d
PE
12251 emacs_write: Accept and return EMACS_INT for sizes.
12252 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12253 et seq.
12254 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12255 Accept and return EMACS_INT.
12256 (emacs_gnutls_write): Return the number of bytes written on
12257 partial writes.
12258 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12259 (emacs_read, emacs_write): Remove check for negative size, as the
12260 Emacs source code has been audited now.
9587a89d
PE
12261 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12262 (emacs_read, emacs_write): Use it.
273a5f82
PE
12263 * process.c (send_process): Adjust to the new signatures of
12264 emacs_write and emacs_gnutls_write. Do not attempt to store
12265 a byte offset into an 'int'; it might overflow.
9587a89d 12266 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12267
3e047f51
PE
12268 * sound.c: Don't assume sizes fit in 'int'.
12269 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12270 Return EMACS_INT, not int.
3e047f51 12271 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12272 Accept EMACS_INT, not int.
12273 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12274 record read return values.
12275
cc39a9db
BK
122762011-04-15 Ben Key <bkey76@gmail.com>
12277
c9d0ec6d
JB
12278 * keyboard.c (Qundefined): Don't declare static since it is used
12279 in nsfns.m.
12280 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12281 static since they are used in nsfont.m.
cc39a9db 12282
6c60eb9f
SM
122832011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12284
12285 * process.c (Qprocessp): Don't declare static.
12286 * lisp.h (Qprocessp): Declare again.
12287
7990b61a
JB
122882011-04-15 Juanma Barranquero <lekktu@gmail.com>
12289
12290 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12291
5d4cb038
PE
122922011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12293
8bd7b830 12294 Improve C-level modularity by making more things 'static'.
cd64ea1d 12295
e3b27b31
PE
12296 Don't publish debugger-only interfaces to other modules.
12297 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12298 (verify_bytepos, count_markers): Move decls to the only modules
12299 that need them.
12300 * region-cache.h (pp_cache): Likewise.
12301 * window.h (check_all_windows): Likewise.
12302 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12303
5d4cb038
PE
12304 * sysdep.c (croak): Now static, if
12305 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12306 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12307
12308 * alloc.c (refill_memory_reserve): Now static if
12309 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12310 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12311
e87b6180
PE
12312 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12313 Define only if USE_LUCID.
12314
ac64929e
PE
12315 * xrdb.c (x_customization_string, x_rm_string): Now static.
12316
6f37259d
PE
12317 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12318 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12319
1683e3ab
PE
12320 * xdisp.c (draw_row_with_mouse_face): Now static.
12321 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12322
de9c2632
PE
12323 * window.h (check_all_windows): Mark externally visible.
12324
2b96acb7
PE
12325 * window.c (window_deletion_count): Now static.
12326
12327 * undo.c: Make symbols static if they're not exported.
12328 (last_undo_buffer, last_boundary_position, pending_boundary):
12329 Now static.
12330
50436f33
PE
12331 * textprop.c (interval_insert_behind_hooks): Now static.
12332 (interval_insert_in_front_hooks): Likewise.
12333
64520e5c
PE
12334 * term.c: Make symbols static if they're not exported.
12335 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12336 (max_frame_lines, tty_set_terminal_modes):
12337 (tty_reset_terminal_modes, tty_turn_off_highlight):
12338 (get_tty_terminal): Now static.
12339 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12340 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12341 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12342 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12343 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12344
1fa53021
PE
12345 * sysdep.c: Make symbols static if they're not exported.
12346 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12347 Now static.
12348 (sigprocmask_set, full_mask): Remove; unused.
12349 (wait_debugging): Mark as visible.
12350 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12351 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12352
d4b43b22
PE
12353 * syntax.c (syntax_temp): Define only if !__GNUC__.
12354
b7c513d0
PE
12355 * sound.c (current_sound_device, current_sound): Now static.
12356
989b29ad
PE
12357 * search.c (searchbufs, searchbuf_head): Now static.
12358
13a55a78
PE
12359 * scroll.c (scroll_cost): Remove; unused.
12360 * dispextern.h (scroll_cost): Remove decl.
12361
de68a1fc
PE
12362 * region-cache.h (pp_cache): Mark as externally visible.
12363
40ccffa6
PE
12364 * process.c: Make symbols static if they're not exported.
12365 (process_tick, update_tick, create_process, chan_process):
12366 (Vprocess_alist, proc_buffered_char, datagram_access):
12367 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12368 (deactivate_process): Mark defn as static, as well as decl.
12369 * lisp.h (create_process): Remove decl.
12370 * process.h (chan_process, Vprocess_alist): Remove decls.
12371
ad64fc97
PE
12372 * print.c: Make symbols static if they're not exported.
12373 (print_depth, new_backquote_output, being_printed, print_buffer):
12374 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12375 (print_interval, print_number_index, initial_stderr_stream):
12376 Now static.
12377 * lisp.h (Fprinc): Remove decl.
12378 (debug_output_compilation_hack): Mark as externally visible.
12379
adddb265
PE
12380 * sysdep.c (croak): Move decl from here to syssignal.h.
12381 * syssignal.h (croak): Put it here, so the API can be checked when
12382 'croak' is called from dissociate_if_controlling_tty.
12383
1717ede2
PE
12384 * minibuf.c: Make symbols static if they're not exported.
12385 (minibuf_save_list, choose_minibuf_frame): Now static.
12386 * lisp.h (choose_minibuf_frame): Remove decl.
12387
fa5fb2bc
PE
12388 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12389
1e3890d1
PE
12390 * lread.c: Make symbols static if they're not exported.
12391 (read_objects, initial_obarray, oblookup_last_bucket_number):
12392 Now static.
12393 (make_symbol): Remove; unused.
12394 * lisp.h (initial_obarray, make_symbol): Remove decls.
12395
8a1414fa
PE
12396 * keyboard.c: Make symbols static if they're not exported.
12397 (single_kboard, recent_keys_index, total_keys, recent_keys):
12398 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12399 (this_single_command_key_start, echoing, last_auto_save):
12400 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12401 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12402 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12403 (Vlispy_mouse_stem, double_click_count):
12404 Now static.
12405 (force_auto_save_soon): Define only if SIGDANGER.
12406 (ignore_mouse_drag_p): Now static if
12407 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12408 (print_help): Remove; unused.
12409 (stop_character, last_timer_event): Mark as externally visible.
12410 * keyboard.h (ignore_mouse_drag_p): Declare only if
12411 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12412 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12413 * lisp.h (echoing): Remove decl.
12414 (force_auto_save_soon): Declare only if SIGDANGER.
12415 * xdisp.c (redisplay_window): Simplify code, to make it more
12416 obvious that ignore_mouse_drag_p is not accessed if !defined
12417 USE_GTK && !defined HAVE_NS.
12418
93ea6e8f
PE
12419 * intervals.c: Make symbols static if they're not exported.
12420 (merge_properties_sticky, merge_interval_right, delete_interval):
12421 Now static.
12422 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12423
77382fcc
PE
12424 * insdel.c: Make symbols static if they're not exported.
12425 However, leave prepare_to_modify_buffer alone. It's never
12426 called from outside this function, but that appears to be a bug.
12427 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12428 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12429 (adjust_after_replace_noundo): Remove; unused.
12430 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12431 (signal_before_change): Remove decls.
77382fcc 12432
9306c32e
PE
12433 * indent.c (val_compute_motion, val_vmotion): Now static.
12434
cd44d2eb
PE
12435 * image.c: Make symbols static if they're not exported.
12436 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12437 if USE_GTK.
12438 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12439 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12440
ad9a7a06
PE
12441 * fringe.c (standard_bitmaps): Now static.
12442 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12443
81626931
PE
12444 * frame.c: Make symbols static if they're not exported.
12445 (x_report_frame_params, make_terminal_frame): Now static.
12446 (get_frame_param): Now static, unless HAVE_NS.
12447 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12448 (x_get_resource_string): Remove; not used.
12449 * frame.h (make_terminal_frame, x_report_frame_params):
12450 (x_get_resource_string); Remove decls.
12451 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12452 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12453
239f9db9
PE
12454 * font.c, fontset.c: Make symbols static if they're not exported.
12455 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12456 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12457 * font.c (font_close_object): Now static.
12458 * font.h (font_close_object): Remove.
12459 * fontset.c (FONTSET_OBJLIST): Remove.
12460 (free_realized_fontset) #if-0 the body, which does nothing.
12461 (face_suitable_for_char_p): #if-0, as it's never called.
12462 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12463 * xfaces.c (face_at_string_position):
12464 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12465 since 0 is always ASCII.
12466
dfcf3579
PE
12467 * fns.c (weak_hash_tables): Now static.
12468
5045092b
PE
12469 * fileio.c: Make symbols static if they're not exported.
12470 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12471 (Vwrite_region_annotation_buffers): Now static.
12472
57a96f5c
PE
12473 * eval.c: Make symbols static if they're not exported.
12474 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12475 * lisp.h (backtrace_list): Remove decl.
12476
35f08c38
PE
12477 * emacs.c: Make symbols static if they're not exported.
12478 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12479 (fatal_error_code, fatal_error_signal_hook, standard_args):
12480 Now static.
12481 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12482 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12483 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12484 * lisp.h (fatal_error_signal_hook): Remove decl.
12485 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12486
f44bd759
PE
12487 * editfns.c: Move a (normally-unused) function to its only use.
12488 * editfns.c, lisp.h (get_operating_system_release): Remove.
12489 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12490 worth the hassle of breaking this out.
12491
b532497d
PE
12492 * xterm.c: Make symbols static if they're not exported.
12493 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12494 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12495 (x_destroy_window, x_delete_display):
12496 Now static.
12497 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12498 (x_mouse_leave): Remove; unused.
12499 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12500 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12501 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12502 Remove decls.
12503 (x_mouse_leave): Declare only if WINDOWSNT.
12504 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12505 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12506 USE_X_TOOLKIT.
12507
1675728f
PE
12508 * ftxfont.c: Make symbols static if they're not exported.
12509 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12510 HAVE_FREETYPE.
12511 * font.h (ftxfont_driver): Likewise.
12512
e4cebfca
PE
12513 * xfns.c: Make symbols static if they're not exported.
12514 (x_last_font_name, x_display_info_for_name):
12515 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12516 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12517 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12518 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12519 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12520 (last_show_tip_args): Now static.
12521 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12522 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12523 (x_screen_planes): Remove; unused.
12524 * dispextern.h (x_screen_planes): Remove decl.
12525
5bf46f05
PE
12526 * dispnew.c: Make symbols static if they're not exported.
12527 * dispextern.h (redraw_garbaged_frames, scrolling):
12528 (increment_row_positions): Remove.
12529 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12530 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12531 Now static.
12532 (redraw_garbaged_frames): Remove; unused.
12533
435f4c28
PE
12534 * xfaces.c: Make symbols static if they're not exported.
12535 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12536 Remove decls.
12537 * xterm.h (defined_color): Remove decls.
12538 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12539 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12540 (menu_face_changed_default, defined_color, free_realized_face):
12541 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12542 (ascii_face_of_lisp_face): Remove; unused.
12543
8524aef3
PE
12544 * xdisp.c: Make symbols static if they're not exported.
12545 * dispextern.h (scratch_glyph_row, window_box_edges):
12546 (glyph_to_pixel_coords, set_cursor_from_row):
12547 (get_next_display_element, set_iterator_to_next):
12548 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12549 (show_mouse_face): Remove decls
12550 * frame.h (message_buf_print): Likewise.
12551 * lisp.h (pop_message, set_message, check_point_in_composition):
12552 Likewise.
12553 * xterm.h (set_vertical_scroll_bar): Likewise.
12554 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12555 (message_buf_print, scratch_glyph_row, displayed_buffer):
12556 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12557 (get_next_display_element, show_mouse_face, window_box_edges):
12558 (frame_to_window_pixel_xy, check_point_in_composition):
12559 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12560 (glyph_to_pixel_coords): Remove; unused.
12561
16390cd2
PE
12562 * dired.c (file_name_completion): Now static.
12563
12564 * dbusbind.c (xd_in_read_queued_messages): Now static.
12565
a25f4dfa
PE
12566 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12567 * data.c (circular_list_error): Remove.
12568
14a9c8df
PE
12569 * commands.h (last_point_position, last_point_position_buffer):
12570 (last_point_position_window): Remove decls.
12571 * keyboard.c: Make these variables static.
12572
04f2d78b
CB
12573 * coding.h (coding, code_convert_region, encode_coding_gap):
12574 Remove decls.
74ab6df5
PE
12575 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12576 (iso_code_class, detect_coding, code_convert_region): Now static.
12577 (encode_coding_gap): Remove; unused.
12578
38dfbee1
PE
12579 * chartab.c (chartab_chars, chartab_bits): Now static.
12580
a2cb4e63
PE
12581 * charset.h (charset_iso_8859_1): Remove decl.
12582 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12583 Now static.
12584
127198fd
PE
12585 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12586 * ccl.c (Vccl_program_table): Now static.
12587 (check_ccl_update): Remove; unused.
12588
d85b608f
PE
12589 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12590 * category.h: ... from here.
12591 * category.c (check_category_table, set_category_set): Now static.
12592
31cd66f3
PE
12593 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12594 * lisp.h: Remove these decls.
12595
c358e587
PE
12596 * buffer.c (buffer_count): Remove unused var.
12597
e78aecca
PE
12598 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12599 so that it's not optimized away.
12600 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12601 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12602 exported only to the debugger.
12603
e192d7d3 12604 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12605 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12606
92470028
PE
12607 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12608 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12609 was inaccessible from Lisp.
12610 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12611 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12612
244ed907
PE
12613 alloc.c: Import and export fewer symbols, and remove unused items.
12614 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12615 is defined.
12616 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12617 it's not optimized away by whole-program optimization.
12618 (message_enable_multibyte, free_misc): Remove.
12619 (catchlist, handlerlist, mark_backtrace):
12620 Declare only if BYTE_MARK_STACK.
12621 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12622 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12623 (message_enable_multibyte): Remove decl.
12624 (free_misc, interval_free_list, float_block, float_block_index):
12625 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12626 (cons_free_list, last_marked_index):
12627 Now static.
12628 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12629 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12630 (mark_backtrace): Define only if BYTE_MARK_STACK.
12631 * xdisp.c (message_enable_multibyte): Now static.
12632
61c2b50e 12633 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12634 This makes it easier for human readers (and static analyzers)
12635 to see whether these variables are used from other modules.
12636 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12637 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12638 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12639 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12640 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12641 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12642 * xmenu.c, xselect.c:
12643 Declare Q* vars static if they are not used in other modules.
12644 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12645 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12646 Remove decls of unexported vars.
12647 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12648
95c82688
PE
12649 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12650
16a97296
PE
12651 Make Emacs functions such as Fatom 'static' by default.
12652 This makes it easier for human readers (and static analyzers)
12653 to see whether these functions can be called from other modules.
12654 DEFUN now defines a static function. To make the function external
12655 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12656 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12657 (Finit_image_library):
16a97296
PE
12658 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12659 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12660 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12661 Remove decls, since these functions are now static.
12662 (Funintern, Fget_internal_run_time): New decls, since these functions
12663 were already external.
95c82688 12664
16a97296
PE
12665 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12666 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12667 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12668 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12669 * keyboard.c, keymap.c, lread.c:
12670 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12671 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12672 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12673 Mark functions with DEFUE instead of DEFUN,
12674 if they are used in other modules.
12675 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12676 decls for now-static functions.
12677 * buffer.h (Fdelete_overlay): Remove decl.
12678 * callproc.c (Fgetenv_internal): Mark as internal.
12679 * composite.c (Fremove_list_of_text_properties): Remove decl.
12680 (Fcomposition_get_gstring): New forward static decl.
12681 * composite.h (Fcomposite_get_gstring): Remove decl.
12682 * dired.c (Ffile_attributes): New forward static decl.
12683 * doc.c (Fdocumntation_property): New forward static decl.
12684 * eval.c (Ffetch_bytecode): New forward static decl.
12685 (Funintern): Remove extern decl; now in .h file where it belongs.
12686 * fileio.c (Fmake_symbolic_link): New forward static decl.
12687 * image.c (Finit_image_library): New forward static decl.
12688 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12689 * intervals.h (Fprevious_property_change):
12690 (Fremove_list_of_text_properties): Remove decls.
12691 * keyboard.c (Fthis_command_keys): Remove decl.
12692 (Fcommand_execute): New forward static decl.
12693 * keymap.c (Flookup_key): New forward static decl.
12694 (Fcopy_keymap): Now static.
12695 * keymap.h (Flookup_key): Remove decl.
12696 * process.c (Fget_process): New forward static decl.
12697 (Fprocess_datagram_address): Mark as internal.
12698 * syntax.c (Fsyntax_table_p): New forward static decl.
12699 (skip_chars): Remove duplicate decl.
12700 * textprop.c (Fprevious_property_change): New forward static decl.
12701 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12702 Now internal.
12703 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12704 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12705
785bbd42
PE
12706 * editfns.c (Fformat): Remove unreachable code.
12707
8b913b57
AS
127082011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12709
12710 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12711 change. (Bug#8496)
12712
a6744a35
EZ
127132011-04-13 Eli Zaretskii <eliz@gnu.org>
12714
12715 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12716 when at ZV. (Bug#8487)
12717
e7974947
AS
127182011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12719
baad03f0
AS
12720 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12721 (Bug#8437)
12722 * keyboard.c (parse_tool_bar_item): Likewise.
12723 * sound.c (sound_cleanup, alsa_close): Likewise.
12724 * termcap.c (tgetent): Likewise.
12725 * xfns.c (x_default_font_parameter): Likewise.
12726 * xsettings.c (read_and_apply_settings): Likewise.
12727
e7974947
AS
12728 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12729 (overrun_check_free): Protoize.
12730
28272684
PE
127312011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12732
12733 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12734 since callers should never pass a negative size.
12735 Change the signature to match that of plain 'read' and 'write'; see
12736 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12737 * lisp.h: Update prototypes of emacs_write and emacs_read.
12738
11997c76
EZ
127392011-04-11 Eli Zaretskii <eliz@gnu.org>
12740
12741 * xdisp.c (redisplay_window): Don't try to determine the character
12742 position of the scroll margin if the window start point w->startp
e896f03c 12743 is outside the buffer's accessible region. (Bug#8468)
11997c76 12744
8a2cbd72
EZ
127452011-04-10 Eli Zaretskii <eliz@gnu.org>
12746
12747 Fix write-region and its subroutines for buffers > 2GB.
12748 * fileio.c (a_write, e_write): Modify declaration of arguments and
12749 local variables to support buffers larger than 2GB.
12750 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12751
12752 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12753 argument, local variables, and return value.
12754
12755 * lisp.h: Update prototypes of emacs_write and emacs_read.
12756
12757 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12758
4073e537 127592011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12760
1ebfdcb6
PE
12761 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12762
b2ded58d
PE
12763 Fix more problems found by GCC 4.6.0's static checks.
12764
7d66342c
PE
12765 * xdisp.c (vmessage): Use a better test for character truncation.
12766
bbf47d44
PE
12767 * charset.c (load_charset_map): <, not <=, for optimization,
12768 and to avoid potential problems with integer overflow.
9248994d 12769 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12770 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12771 * editfns.c (Fformat): Likewise.
1e69125e 12772 * syntax.c (skip_chars): Likewise.
3befa583 12773
e3019616
PE
12774 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12775 This also lets GCC 4.6.0 generate slightly better loop code.
12776
becfa255
PE
12777 * callint.c (Fcall_interactively): <, not <=, for optimization.
12778 (Fcall_interactively): Count the number of arguments produced,
12779 not the number of arguments given. This is simpler and lets GCC
12780 4.6.0 generate slightly better code.
12781
dae0cd48
PE
12782 * ftfont.c: Distingish more carefully between FcChar8 and char.
12783 The previous code passed unsigned char * to a functions like
12784 strlen and xstrcasecmp that expect char *, which does not
12785 conform to the C standard.
12786 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12787 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12788 char * when the C standard requires it.
12789
76032d70
PE
12790 * keyboard.c (read_char): Remove unused var.
12791
eb3f1cc8
PE
12792 * eval.c: Port to Windows vsnprintf (Bug#8435).
12793 Include <limits.h>.
12794 (SIZE_MAX): Define if the headers do not.
12795 (verror): Do not give up if vsnprintf returns a negative count.
12796 Instead, grow the buffer. This ports to Windows vsnprintf, which
12797 does not conform to C99. Problem reported by Eli Zaretskii.
12798 Also, simplify the allocation scheme, by avoiding the need for
12799 calling realloc, and removing the ALLOCATED variable.
12800
70476b54
PE
12801 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12802
12020a9e
PE
12803 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12804 But keep the doprint source code for now, as we might revamp it
12805 and use it again (Bug#8435).
ea6c7ae6
PE
12806 * lisp.h (doprnt): Remove.
12807 * Makefile.in (base_obj): Remove doprnt.o.
12808 * deps.mk (doprnt.o): Remove.
12809
5fdb398c
PE
12810 error: Print 32- and 64-bit integers portably (Bug#8435).
12811 Without this change, on typical 64-bit hosts error ("...%d...", N)
12812 was used to print both 32- and 64-bit integers N, which relied on
12813 undefined behavior.
61bdb816 12814 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12815 * lisp.h (error, verror): Mark as printf-like functions.
12816 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12817 Report overflow in size calculations when allocating printf buffer.
12818 Do not truncate output string at its first null byte.
12819 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12820 Truncate the output at a character boundary, since vsnprintf does not
12821 do that.
12822 * charset.c (check_iso_charset_parameter): Convert internal
12823 character to string before calling 'error', since %c now has the
12824 printf meaning.
12825 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12826 overflow when computing char to be passed to 'error'. Do not
12827 pass Lisp_Object to 'error'; pass the integer instead.
12828 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12829 formatted with plain %d.
12830
b189fa66
PE
12831 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12832
bff87ef0
PE
12833 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12834
7e2cac20
PE
12835 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12836
ce4d90b5
PE
12837 * xterm.c (x_catch_errors): Remove duplicate declaration.
12838
266c9547
PE
12839 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12840
79c49ad2
PE
12841 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12842
368f4090
JM
128432011-04-10 Jim Meyering <meyering@redhat.com>
12844
12845 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12846 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12847 return ssize_t not "int", and use size_t as the buffer length.
12848 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12849 * gnutls.h: Update declarations.
12850 * process.c (read_process_output): Use ssize_t, to match.
12851 (send_process): Likewise.
12852
a32d4040
CY
128532011-04-09 Chong Yidong <cyd@stupidchicken.com>
12854
12855 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12856
8546720e 128572011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12858
04f2d78b
CB
12859 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12860 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12861
8546720e
GM
12862 * xterm.c (handle_one_xevent):
12863 * xmenu.c (create_and_show_popup_menu):
12864 * xselect.c (x_decline_selection_request)
12865 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12866
0a2f5c1a 128672011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12868
12869 Fix some uses of `int' instead of EMACS_INT.
12870 * search.c (string_match_1, fast_string_match)
12871 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12872 (scan_buffer, find_next_newline_no_quit)
12873 (find_before_next_newline, search_command, Freplace_match)
12874 (Fmatch_data): Make some `int' variables be EMACS_INT.
12875
12876 * xdisp.c (display_count_lines): 3rd argument and return value now
12877 EMACS_INT. All callers changed.
12878 (pint2hrstr): Last argument is now EMACS_INT.
12879
12880 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12881 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12882 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12883 (decode_coding_utf_16, decode_coding_emacs_mule)
12884 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12885 (decode_coding_ccl, decode_coding_charset)
12886 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12887 (decode_coding_iso_2022, decode_coding_emacs_mule)
12888 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12889 <char_offset, last_offset>: Declare EMACS_INT.
12890 (encode_coding_utf_8, encode_coding_utf_16)
12891 (encode_coding_emacs_mule, encode_invocation_designation)
12892 (encode_designation_at_bol, encode_coding_iso_2022)
12893 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12894 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12895 Declare EMACS_INT.
12896 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12897 (encode_invocation_designation): Last argument P_NCHARS is now
12898 EMACS_INT.
12899 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12900 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12901
12902 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12903 All users changed.
12904
12905 * ccl.c (Fccl_execute_on_string): Declare some variables
12906 EMACS_INT.
12907
8546720e 129082011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12909
12910 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12911
4e19a977
CS
129122011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12913
12914 * process.c (Fformat_network_address): Doc fix.
12915
87302331
R
129162011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12917
ee7683eb 12918 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12919
cbb59342
CY
129202011-04-08 Chong Yidong <cyd@stupidchicken.com>
12921
12922 * keyboard.c (read_char): Call Lisp function help-form-show,
12923 instead of using internal_with_output_to_temp_buffer.
12924 (Qhelp_form_show): New var.
e0d38eeb 12925 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12926
12927 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12928
12929 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12930
e67a13ab
CY
129312011-04-06 Chong Yidong <cyd@stupidchicken.com>
12932
04f2d78b
CB
12933 * process.c (Flist_processes): Remove to Lisp.
12934 (list_processes_1): Delete.
e67a13ab 12935
973f782d
EZ
129362011-04-06 Eli Zaretskii <eliz@gnu.org>
12937
7c106b1e
EZ
12938 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12939
973f782d
EZ
12940 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12941
41cf7d1a 129422011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12943
ca23cc88
PE
12944 Fix more problems found by GCC 4.6.0's static checks.
12945
f390e2d5
PE
12946 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12947
42eea0d0
PE
12948 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12949
b69769da 12950 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12951
f9541e84
PE
12952 * xdisp.c (vmessage): Mark as a printf-like function.
12953
13841b55
PE
12954 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12955
c136c10f
PE
12956 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12957
5e2d4a30
PE
12958 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12959 printf-like functions.
12960 (tiff_load): Add casts to remove these marks before passing them
12961 to system-supplied API.
12962
583f48b9
PE
12963 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12964
b25d760e
PE
12965 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12966 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12967 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12968 directly, rather than having caller test rule sign. This avoids
12969 some unnecessary tests.
12970 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12971 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12972 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12973
bc7b6697 12974 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12975 (xfont_open): Avoid unnecessary tests.
bc7b6697 12976
27ccc379
PE
12977 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12978
dcd5c89a
PE
12979 * composite.h, composite.c (composition_gstring_put_cache):
12980 Use EMACS_INT, not int, for length.
12981
b13a45c6
PE
12982 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12983 breaking out part of COMPOSITION_DECODE_RULE.
12984 (COMPOSITION_DECODE_RULE): Use it.
12985 * composite.c (get_composition_id): Remove unused local vars,
12986 by using the new macro.
12987
1e792e4d
PE
12988 * textprop.c (set_text_properties_1): Change while to do-while,
12989 since the condition is always true at first.
12990
dc6c6455 12991 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12992 (interval_deletion_adjustment): Return unsigned value.
12993 All uses changed.
dc6c6455 12994
aba7731a
PE
12995 * process.c (list_processes_1, create_pty, read_process_output):
12996 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12997 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12998 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12999 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13000 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13001
fdfc4bf3
PE
13002 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13003
fca8fe46 13004 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13005 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13006
06a0259a 13007 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13008 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13009 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13010
e7b9e80f
PE
13011 * print.c (print_error_message): Avoid int overflow.
13012
56201685
PE
13013 * font.c (font_list_entities): Redo for clarity,
13014 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13015
78834453 13016 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13017 (font_score): Avoid potential overflow in diff calculation.
78834453 13018
0bc0b309 13019 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13020 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13021
e610eaca
PE
13022 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13023
b895abce
PE
13024 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13025 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13026 can always succeed if overflow has undefined behavior.
13027
1f1d9321 13028 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13029 (wordify): Omit three unnecessary tests.
1f1d9321 13030
c59478bc
PE
13031 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13032 All callers changed. This avoids the need for an unused var.
13033
79b73827
PE
13034 * casefiddle.c (casify_region): Remove var that is set but not used.
13035
a4db5dfe
PE
13036 * dired.c (file_name_completion): Remove var that is set but not used.
13037
43aae36e
PE
13038 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13039
2a47c44d 13040 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13041 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13042
a37c69bf
PE
13043 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13044 Check for integer overflow on size calculations.
13045
328ab8e7
PE
13046 * buffer.c (Fprevious_overlay_change): Remove var that is set
13047 but not used.
13048
e5a2a5cb
PE
13049 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13050 Remove vars that are set but not used.
8d84a6eb 13051 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13052 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13053
a60e5f68
PE
13054 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13055
f661cb61 13056 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13057 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13058
f0397f5a
PE
13059 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13060 that are set but not used.
13061
8664db06 13062 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13063 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13064
6abdaa4a
PE
13065 * xselect.c (x_get_local_selection, x_handle_property_notify):
13066 Remove vars that are set but not used.
13067
0ce7538d 13068 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13069 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13070
9ae848fc
PE
13071 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13072 Remove var that is set but not used.
0b918413
PE
13073 (scroll_bar_windows_size): Now size_t, not int.
13074 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13075 Check for overflow.
9ae848fc 13076
a5a62657
PE
13077 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13078 (map_tty_color) [!defined MSDOS]: Likewise.
13079
5c5cdd39
PE
13080 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13081
66ebf983
PE
13082 * coding.c: Remove vars that are set but not used.
13083 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13084 All callers changed.
13085 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13086 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13087 (decode_coding_charset): Remove vars that are set but not used.
13088
1be4d761
PE
13089 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13090 that is set but not used.
13091
47553fa8
PE
13092 * print.c (print_object): Remove var that is set but not used.
13093
1f7196bf 13094 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13095 The gnulib version avoids calling malloc in the usual case,
13096 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13097 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13098 * filelock.c (current_lock_owner): Likewise.
13099 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13100 * sysdep.c: Include allocator.h, careadlinkat.h.
13101 (emacs_no_realloc_allocator): New static constant.
13102 (emacs_readlink): New function.
fdb61804
PE
13103 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13104 ../lib/careadlinkat.h.
d1fdcab7 13105
f84c17c7
SM
131062011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13107
13108 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13109 first non-nil return value).
13110
ef3862ad
JD
131112011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13112
13113 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13114 if not defined (Bug#8403).
13115
376a7006
JB
131162011-04-02 Juanma Barranquero <lekktu@gmail.com>
13117
13118 * xdisp.c (display_count_lines): Remove parameter `start',
13119 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13120 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13121 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13122 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13123 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13124 and thereabouts. All callers changed.
13125 (get_per_char_metric): Remove parameter `f', unused since
13126 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13127
6ca3801d
JM
131282011-04-02 Jim Meyering <meyering@redhat.com>
13129
13130 do not dereference NULL upon failed strdup
13131 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13132 (ns_get_family): Likewise.
13133
d8e2b5ba
JB
131342011-04-02 Juanma Barranquero <lekktu@gmail.com>
13135
13136 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13137
8c74fcbd
JD
131382011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13139
13140 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13141 later (Bug#8403).
13142
7200d79c
SM
131432011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13144
03408648 13145 Add lexical binding.
7200d79c 13146
03408648
SM
13147 * window.c (Ftemp_output_buffer_show): New fun.
13148 (Fsave_window_excursion):
13149 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13150
13151 * lread.c (lisp_file_lexically_bound_p): New function.
13152 (Fload): Bind Qlexical_binding.
13153 (readevalloop): Remove `evalfun' arg.
13154 Bind Qinternal_interpreter_environment.
13155 (Feval_buffer): Bind Qlexical_binding.
13156 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13157 Mark as dynamic.
13158 (syms_of_lread): Declare `lexical-binding'.
13159
13160 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13161
13162 * keyboard.c (eval_dyn): New fun.
13163 (menu_item_eval_property): Use it.
ca105506
SM
13164
13165 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13166
03408648
SM
13167 * fns.c (concat, mapcar1): Accept byte-code-functions.
13168
13169 * eval.c (Fsetq): Handle lexical vars.
13170 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13171 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13172 (FletX, Flet): Obey lexical binding.
13173 (Fcommandp): Handle closures.
13174 (Feval): New `lexical' arg.
13175 (eval_sub): New function extracted from Feval. Use it almost
13176 everywhere where Feval was used. Look up vars in lexical env.
13177 Handle closures.
13178 (Ffunctionp): Move from subr.el.
13179 (Ffuncall): Handle closures.
13180 (apply_lambda): Remove `eval_flags'.
13181 (funcall_lambda): Handle closures and new byte-code-functions.
13182 (Fspecial_variable_p): New function.
13183 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13184 but without exporting it to Lisp.
23aba0ea 13185
23aba0ea 13186 * doc.c (Fdocumentation, store_function_docstring):
03408648 13187 * data.c (Finteractive_form): Handle closures.
23aba0ea 13188
03408648
SM
13189 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13190 interactive spec.
ba83908c 13191
04f2d78b
CB
13192 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13193 New byte-codes.
03408648
SM
13194 (exec_byte_code): New function extracted from Fbyte_code to handle new
13195 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13196
03408648 13197 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13198
03408648 13199 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13200
e2abce01
JB
132012011-03-31 Juanma Barranquero <lekktu@gmail.com>
13202
13203 * xdisp.c (redisplay_internal): Fix prototype.
13204
63696a73 132052011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13206
63696a73 13207 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13208 (try_scrolling): Use it when setting scroll_limit.
13209 Limit scrolling to 100 screen lines.
63696a73
EZ
13210 (redisplay_window): Even when falling back on "recentering",
13211 position point in the window according to scroll-conservatively,
13212 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13213
13214 (try_scrolling): When point is above the window, allow searching
13215 as far as scroll_max, or one screenful, to compute vertical
13216 distance from PT to the scroll margin position. This prevents
13217 try_scrolling from unnecessarily failing when
13218 scroll-conservatively is set to a value slightly larger than the
13219 window height. Clean up the case of PT below the margin at bottom
13220 of window: scroll_max can no longer be INT_MAX. When aggressive
13221 scrolling is in use, don't let point enter the opposite scroll
13222 margin as result of the scroll.
13223 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13224 threshold of 100 lines for never-recentering scrolling.
13225
e4cc2dfc
JB
132262011-03-31 Juanma Barranquero <lekktu@gmail.com>
13227
13228 * dispextern.h (move_it_by_lines):
13229 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13230 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13231 (message_log_check_duplicate): Remove parameters `prev_bol' and
13232 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13233 (redisplay_internal): Remove parameter `preserve_echo_area',
13234 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13235
13236 * indent.c (Fvertical_motion):
13237 * window.c (window_scroll_pixel_based, Frecenter):
13238 Don't pass `need_y_p' to `move_it_by_lines'.
13239
1c470562
SM
132402011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13241
44f230aa
SM
13242 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13243 steal a few bits to be more compact.
13244 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13245 Remove unneeded casts.
13246
1c470562
SM
13247 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13248
888adce9
ZK
132492011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13250
13251 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13252 binding" message (bug#7967).
13253
f838ed7b
PE
132542011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13255
77861b95
PE
13256 Fix more problems found by GCC 4.6.0's static checks.
13257
de6dbc14
PE
13258 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13259 Remove unused local var.
13260
f838ed7b
PE
13261 * editfns.c (Fmessage_box): Remove unused local var.
13262
792c7b2b
PE
13263 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13264 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13265 Omit unused local vars.
c499e557 13266 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13267 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13268 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13269 Omit unused local var.
13270
ba0165e1
PE
13271 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13272 Don't assume string length fits in int.
32ad8845 13273 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13274 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13275
3c59b4c9
PE
13276 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13277 instead of alloca (Bug#8344).
13278
a3eed478 13279 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13280 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13281
eb4d412d
PE
13282 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13283
1658b401
PE
13284 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13285 concerns.
13286
13287 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13288
13289 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13290
9a2c6e05
PE
13291 * keyboard.c (syms_of_keyboard): Use the same style as later
13292 in this function when indexing through an array. This also
13293 works around GCC bug 48267.
13294
03d0a109
PE
13295 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13296
44f730c8
PE
13297 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13298
fe75f926
PE
13299 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13300 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13301
ffa8c828
PE
13302 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13303 This avoids undefined behavior on integer overflow, and is a bit
13304 more convenient anyway since it is compared to a size_t variable.
13305
c5101a77
PE
13306 Variadic C functions now count arguments with size_t, not int.
13307 This avoids an unnecessary limitation on 64-bit machines, which
13308 caused (substring ...) to crash on large vectors (Bug#8344).
13309 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13310 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13311 All variadic functions and their callers changed accordingly.
c5101a77
PE
13312 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13313 * data.c (arith_driver, float_arith_driver): Likewise.
13314 * editfns.c (general_insert_function): Likewise.
13315 * eval.c (struct backtrace.nargs, interactive_p)
13316 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13317 (funcall_lambda, mark_backtrace): Likewise.
13318 * fns.c (concat): Likewise.
13319 * frame.c (x_set_frame_parameters): Likewise.
13320 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13321 0 if not found, not -1. All callers changed.
13322
dd3f25f7
PE
13323 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13324 (stack_copy_size): Now size_t, not int.
13325 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13326
461c2ab9
JB
133272011-03-28 Juanma Barranquero <lekktu@gmail.com>
13328
13329 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13330 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13331 All callers changed.
13332
13333 * lisp.h (multibyte_char_to_unibyte):
13334 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13335 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13336 * character.h (CHAR_TO_BYTE8):
13337 * cmds.c (internal_self_insert):
13338 * editfns.c (general_insert_function):
13339 * keymap.c (push_key_description):
13340 * search.c (Freplace_match):
13341 * xdisp.c (message_dolog, set_message_1): All callers changed.
13342
f6d62986
SM
133432011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13344
13345 * keyboard.c (safe_run_hook_funcall): New function.
13346 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13347 don't set the hook to nil, but remove the offending function instead.
13348 (Qcommand_hook_internal): Remove, unused.
13349 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13350 Vcommand_hook_internal.
13351
13352 * eval.c (enum run_hooks_condition): Remove.
13353 (funcall_nil, funcall_not): New functions.
13354 (run_hook_with_args): Call each function through a `funcall' argument.
13355 Remove `cond' argument, now redundant.
13356 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13357 (Frun_hook_with_args_until_failure): Adjust accordingly.
13358 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13359
1db5b1ad
JB
133602011-03-28 Juanma Barranquero <lekktu@gmail.com>
13361
13362 * dispextern.h (string_buffer_position): Remove declaration.
13363
13364 * print.c (strout): Remove parameter `multibyte', unused since
13365 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13366
13367 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13368 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13369 All callers changed.
13370
13371 * w32.c (_wsa_errlist): Use braces for struct initializers.
13372
13373 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13374 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13375 All callers changed.
13376 (string_buffer_position): Likewise. Also, make static (it's never
13377 used outside xdisp.c).
13378 (cursor_row_p): Remove parameter `w', unused since
13379 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13380 (decode_mode_spec): Remove parameter `precision', introduced during
13381 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13382 All callers changed.
13383
5ffb62aa
JD
133842011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13385
13386 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13387
461c2ab9 133882011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13389
13390 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13391 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13392 (ns_update_auto_hide_menu_bar): New functions.
13393 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13394 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13395 ns_constrain_all_frames.
13396 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13397 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13398
5c380ffb
JD
133992011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13400
13401 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13402
9af30bdf
GM
134032011-03-27 Glenn Morris <rgm@gnu.org>
13404
13405 * syssignal.h: Replace RETSIGTYPE with void.
13406 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13407 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13408 Replace SIGTYPE with void everywhere.
13409 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13410 * s/template.h (SIGTYPE): Remove commented out definition.
13411
e2abce01
JB
134122011-03-26 Eli Zaretskii <eliz@gnu.org>
13413
13414 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13415 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13416
f868cd8a
JB
134172011-03-26 Juanma Barranquero <lekktu@gmail.com>
13418
59eb0929
JB
13419 * w32.c (read_unc_volume): Use parameter `henum', instead of
13420 global variable `wget_enum_handle'.
13421
13422 * keymap.c (describe_vector): Remove parameters `indices' and
13423 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13424 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13425
f868cd8a
JB
13426 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13427
13428 * keyboard.c (timer_check): Remove parameter `do_it_now',
13429 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13430 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13431 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13432
13433 * keyboard.c (read_char):
13434 * w32menu.c (w32_menu_display_help):
13435 * xmenu.c (show_help_event, menu_help_callback):
13436 Adjust calls to `show_help_echo'.
13437
13438 * gtkutil.c (xg_maybe_add_timer):
13439 * keyboard.c (readable_events):
13440 * process.c (wait_reading_process_output):
13441 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13442
13443 * insdel.c (adjust_markers_gap_motion):
13444 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13445 (gap_left, gap_right): Don't call it.
13446
2ecf6fdb
CY
134472011-03-25 Chong Yidong <cyd@stupidchicken.com>
13448
13449 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13450 incurred during fontification.
13451
6b1f9ba4
JB
134522011-03-25 Juanma Barranquero <lekktu@gmail.com>
13453
13454 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13455 (DEFVAR_PER_BUFFER): Don't pass it.
13456
13457 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13458 (scrolling_window): Don't pass it.
13459
0f4a96b5
JB
134602011-03-25 Juanma Barranquero <lekktu@gmail.com>
13461
13462 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13463
13464 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13465 and `suffix'.
13466 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13467 of variables specific to SELinux and computation of `encoded_absname'.
13468
13469 * image.c (XPutPixel): Remove unused variable `height'.
13470
13471 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13472
13473 * unexw32.c (get_section_info): Remove unused variable `section'.
13474
13475 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13476 (system_process_attributes): Remove unused variable `sess'.
13477 (sys_read): Remove unused variable `err'.
13478
13479 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13480 (w32_wnd_proc): Remove unused variable `isdead'.
13481 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13482 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13483 (x_create_tip_frame): Remove unused variable `tem'.
13484
13485 * w32inevt.c (w32_console_read_socket):
13486 Remove unused variable `no_events'.
13487
13488 * w32term.c (x_draw_composite_glyph_string_foreground):
13489 Remove unused variable `width'.
13490
1149507c
JB
134912011-03-24 Juanma Barranquero <lekktu@gmail.com>
13492
13493 * w32term.c (x_set_glyph_string_clipping):
13494 Don't pass uninitialized region to CombineRgn.
13495
9c88f339
JB
134962011-03-23 Juanma Barranquero <lekktu@gmail.com>
13497
13498 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13499 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13500 (Fx_close_connection): Remove unused variable `i'.
13501
13502 * w32font.c (w32font_draw): Return number of glyphs.
13503 (w32font_open_internal): Remove unused variable `i'.
13504 (w32font_driver): Add missing initializer.
13505
13506 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13507 (fill_in_menu): Remove unused variable `items_added'.
13508
13509 * w32term.c (last_mouse_press_frame): Remove static global variable.
13510 (w32_clip_to_row): Remove unused variable `f'.
13511 (x_delete_terminal): Remove unused variable `i'.
13512
13513 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13514 (NOTHING): Remove unused static global variable.
13515 (uniscribe_check_otf): Remove unused variable `table'.
13516 (uniscribe_font_driver): Add missing initializers.
13517
dee091a3
JD
135182011-03-23 Julien Danjou <julien@danjou.info>
13519
13520 * term.c (Fsuspend_tty, Fresume_tty):
13521 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13522 * window.c (temp_output_buffer_show):
13523 * insdel.c (signal_before_change):
13524 * frame.c (Fhandle_switch_frame):
13525 * fileio.c (Fdo_auto_save):
13526 * emacs.c (Fkill_emacs):
13527 * editfns.c (save_excursion_restore):
13528 * cmds.c (internal_self_insert):
13529 * callint.c (Fcall_interactively):
13530 * buffer.c (Fkill_all_local_variables):
13531 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13532 Use Frun_hooks.
0f4a96b5 13533 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13534 unconditionally since it does the check itself.
dee091a3 13535
2c520ab5 135362011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13537
c9c49752
PE
13538 Fix more problems found by GCC 4.5.2's static checks.
13539
8abc3f12
PE
13540 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13541 the first time through the loop, since we know p0 < p1 then.
13542 This also avoids a gcc -Wstrict-overflow warning.
13543
a2d26660
PE
13544 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13545 leading to a memory leak, possible in functions like
13546 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13547 of objects (Bug#8318).
a2d26660 13548
916c72e9
PE
13549 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13550 that could (at least in theory) be that large.
13551
19ab8a18
PE
13552 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13553 This is less likely to overflow, and avoids undefined behavior if
13554 overflow does occur. All callers changed. Use strtoul to scan
13555 for the unsigned long integer.
b7cbbd6f
PE
13556 (pint2hrstr): Simplify and tune code slightly.
13557 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13558
f0641eff
PE
13559 * scroll.c (do_scrolling): Work around GCC bug 48228.
13560 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13561
7f650bb9
PE
13562 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13563 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13564 (validate_x_resource_name): Simplify count usage.
13565 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13566
37dd57d1
PE
13567 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13568 fail (Bug#8306).
81e56e61 13569
699979fc 13570 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13571
401bf9b4
PE
13572 * process.c (Fmake_network_process): Use socklen_t, not int,
13573 where POSIX says socklen_t is required in portable programs.
13574 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13575 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13576 (Fmake_network_process, server_accept_connection):
13577 (wait_reading_process_output, read_process_output):
13578 Likewise.
13579
b93aacde
PE
13580 * process.c: Rename or move locals to avoid shadowing.
13581 (list_processes_1, Fmake_network_process):
13582 (read_process_output_error_handler, exec_sentinel_error_handler):
13583 Rename or move locals.
4dc343ee 13584 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13585 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13586 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13587 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13588 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13589
af8a867c 13590 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13591 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13592 Include tparam.h instead, since it declares them.
af8a867c
PE
13593 * cm.h (PC): Remove extern decl; tparam.h now does this.
13594 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13595 * terminfo.c: Include tparam.h, to check interfaces.
13596 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13597 (tparam): Adjust signature to match interface in tparam.h;
13598 this removes some undefined behavior. Check that outstring and len
13599 are zero, which they always are with Emacs.
13600 * tparam.h (PC, BC, UP): New extern decls.
13601
0248044d 13602 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13603 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13604
8ff096c1 13605 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13606 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13607 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13608 (ftfont_list): Remove unused local.
49eaafba
PE
13609 (get_adstyle_property, ftfont_pattern_entity):
13610 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13611 Rename locals to avoid shadowing.
8ff096c1 13612
e2be39f6
PE
13613 * xfont.c (xfont_list_family): Mark var as initialized.
13614
c9735e30
PE
13615 * xml.c (make_dom): Now static.
13616
8f5201ae
PE
13617 * composite.c (composition_compute_stop_pos): Rename local to
13618 avoid shadowing.
b246f932
PE
13619 (composition_reseat_it): Remove unused locals.
13620 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13621 (composition_update_it): Mark var as initialized.
11b61122
PE
13622 (find_automatic_composition): Mark vars as initialized,
13623 with a FIXME (Bug#8290).
8f5201ae 13624
760fbc2c
PE
13625 character.h: Rename locals to avoid shadowing.
13626 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13627 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13628 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13629 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13630 to avoid shadowing.
13631
ff08eb85
PE
13632 * textprop.c (property_change_between_p): Remove; unused.
13633
fc7bf025
PE
13634 * intervals.c (interval_start_pos): Now static.
13635
235d7abc
PE
13636 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13637
44f230aa
SM
13638 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13639 Rename locals to avoid shadowing.
3e7d6594 13640
50060332
PE
13641 * sound.c (wav_play, au_play, Fplay_sound_internal):
13642 Fix pointer signedness.
d01f234b 13643 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13644 (wav_play): Initialize a variable to 0, to prevent undefined
13645 behavior (Bug#8278).
50060332 13646
c4fc4e30
PE
13647 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13648
918436ed
PE
13649 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13650
c939f91b
PE
13651 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13652 clobbering (Bug#8298).
b9c7f648
PE
13653 * sysdep.c (sys_subshell): Likewise.
13654 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13655
6bd8c144
PE
13656 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13657 This should get cleaned up, so that child_setup has the
13658 same signature on all platforms.
13659
7710357c 13660 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13661 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13662
c59da222
CY
136632011-03-22 Chong Yidong <cyd@stupidchicken.com>
13664
13665 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13666 not to be necessary, and produces flickering.
13667
66b87493
GM
136682011-03-20 Glenn Morris <rgm@gnu.org>
13669
13670 * config.in: Remove file.
13671
45b6f6d5
JB
136722011-03-20 Juanma Barranquero <lekktu@gmail.com>
13673
13674 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13675 are now in src/globals.h.
13676 (syms_of_minibuf): Remove spurious & from previous change.
13677
cd394be1 136782011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13679
13680 * minibuf.c (completing-read-function): New variable.
13681 (completing-read-default): Rename from completing-read.
13682 (completing-read): Call completing-read-function.
13683
b14e3e21
CY
136842011-03-19 Juanma Barranquero <lekktu@gmail.com>
13685
13686 * xfaces.c (Fx_load_color_file):
13687 Read color file from absolute filename (bug#8250).
13688
f2b726e6
JB
136892011-03-19 Juanma Barranquero <lekktu@gmail.com>
13690
13691 * makefile.w32-in: Update dependencies.
13692
09f6ff02
EZ
136932011-03-17 Eli Zaretskii <eliz@gnu.org>
13694
13695 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13696
29a6015a
PE
136972011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13698
a3a6c54e
PE
13699 Fix more problems found by GCC 4.5.2's static checks.
13700
b766f867
PE
13701 * process.c (make_serial_process_unwind, send_process_trap):
13702 (sigchld_handler): Now static.
13703
be02381c
PE
13704 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13705 That way, the code declares only the vars that it needs.
13706 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13707 * s/cygwin.h (PTY_ITERATION): Likewise.
13708 * s/darwin.h (PTY_ITERATION): Likewise.
13709 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13710
57048744
PE
13711 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13712 * process.c (allocate_pty): Don't declare stb unless it's needed.
13713
7914961c 13714 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13715 (CONSTANTLIM): Remove; unused.
13716 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13717 Define only if needed.
7914961c 13718
b3967b18
PE
13719 * unexelf.c (unexec): Name an expression,
13720 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13721 Use a different way to cause a compilation error if anyone uses
13722 n rather than nn, a way that does not involve shadowing.
73366a00 13723 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13724
29a6015a
PE
13725 * deps.mk (unexalpha.o): Remove; unused.
13726
43cfc33e 13727 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13728 * unexec.h: New file.
ce701a33
PE
13729 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13730 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13731 Depend on unexec.h.
13732 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13733 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13734 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13735 Change as necessary to match prototype in unexec.h.
ce701a33 13736
01f44d5a
PE
13737 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13738 shadowing.
4f63c6bb 13739 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13740
a6670b0b
PE
13741 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13742 Rename locals to avoid shadowing.
13743
cef2010d 13744 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13745 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13746
d4d7173a
PE
13747 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13748
f08b802a
PE
13749 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13750 warning when compiling print.c.
13751
3ddb0639
PE
13752 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13753 instead of using an uninitialized var.
5ad03b97 13754 (font_sort_entities): Mark var as initialized.
3ddb0639 13755
170a2692
PE
13756 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13757
e663c700
PE
13758 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13759 pointers to constants.
89bc529a 13760 (font_parse_fcname): Remove unused vars.
7b81e2d0 13761 (font_delete_unmatched): Now static.
ea838e10 13762 (font_get_spec): Remove; unused.
13a547c6
PE
13763 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13764 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13765 Rename or move locals to avoid shadowing.
e663c700 13766
2a80c887 13767 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13768 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13769
1384fa33 13770 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13771 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13772
8b2c52e9
PE
13773 * alloc.c (mark_backtrace): Move decl from here ...
13774 * lisp.h: ... to here, so that it can be checked.
13775
475545b5 13776 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13777 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13778 (lisp_indirect_variable): Name an expression,
13779 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13780 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13781
b1349114 13782 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13783 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13784 Use const pointer when appropriate.
b1349114 13785
a2928364
PE
13786 * lisp.h (get_system_name, get_operating_system_release):
13787 Move decls here, to check interfaces.
13788 * process.c (get_operating_system_release): Move decl to lisp.h.
13789 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13790 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13791 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13792 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13793 (Fformat_time_string, Fencode_time, Finsert_char):
13794 (Ftranslate_region_internal, Fformat):
13795 Rename or remove local vars to avoid shadowing.
9710023e 13796 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13797
a415e694
PE
13798 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13799 avoid shadowing.
13800
8ef4622d
PE
13801 * lisp.h (eassert): Check that the argument compiles, even if
13802 ENABLE_CHECKING is not defined.
13803
946f9a5b
PE
13804 * data.c (Findirect_variable): Name an expression, to avoid
13805 gcc -Wbad-function-cast warning.
112396d6 13806 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13807 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13808 (Fmake_variable_buffer_local, Fmake_local_variable):
13809 Mark variables as initialized.
52746918 13810 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13811
e5aab7e7 13812 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13813 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13814 Rename locals to avoid shadowing.
dff45157
PE
13815 (mark_stack): Move local variables into the #ifdef region where
13816 they're used.
7bc26fdb
PE
13817 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13818 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13819 needed otherwise.
13820 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13821 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13822 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13823
e5aab7e7
PE
13824 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13825 avoids undefined behavior in theory.
13826
4da60324
PE
13827 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13828
88043301
PE
13829 Use functions, not macros, for up- and down-casing (Bug#8254).
13830 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13831 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13832 to use the following functions instead of these macros.
13833 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13834 EMACS_INT, since callers assume the returned value fits in int.
13835 (upcase1): Likewise, for UPCASE_TABLE.
13836 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13837 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13838 the race-condition problem in the old DOWNCASE.
88043301 13839
19ed5445
PE
13840 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13841 Rename locals to avoid shadowing.
13842 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13843 (regex_compile, re_search_2, re_match_2_internal):
13844 Remove unused local vars.
952db0d7
PE
13845 (FREE_VAR): Rewrite so as not to use empty "else",
13846 which gcc can warn about.
da053e48 13847 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13848 (RETALLOC_IF): Define only if needed.
13849 (WORDCHAR_P): Likewise. This one is never needed, but is used
13850 only in a comment talking about a compiler bug, so put inside
13851 the #if 0 of that comment.
13852 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13853 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13854 Remove; unused.
19ed5445 13855
1f3561e4 13856 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13857 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13858 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13859
ded6f8f7
PE
13860 * search.c (simple_search): Remove unused var.
13861
dbd37a95
PE
13862 * dired.c (compile_pattern): Move decl from here ...
13863 * lisp.h: ... to here, so that it can be checked.
13864 (struct re_registers): New forward decl.
13865
7e47afad
PE
13866 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13867
85f24f61
PE
13868 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13869 All uses changed.
13870 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13871 Rename locals to avoid shadowing.
5671df8f 13872 (Fvertical_motion): Mark locals as initialized.
85f24f61 13873
181aa2be 13874 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13875 (casify_region): Mark local as initialized.
181aa2be 13876
930d429c
PE
13877 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13878
7082eac6
PE
13879 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13880 New macros, so that the caller can use some names other than
13881 gcpro1, gcpro2, etc.
13882 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13883 of the new macros.
13884 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13885 argument, for consistency with GCPRO2_VAR, etc: it is now the
13886 prefix of the variable, not the variable itself. All uses
13887 changed.
38b2c076
PE
13888 * dired.c (directory_files_internal, file_name_completion):
13889 Rename locals to avoid shadowing.
13890
15206ed9
PE
13891 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13892 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13893 dired.c's scmp function, had undefined behavior.
13894 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13895 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13896 * buffer.h: ... to here, because these macros use current_buffer,
13897 and the new implementation with inline functions needs to have
13898 current_buffer in scope now, rather than later when the macros
13899 are used.
13900 (downcase, upcase1): New static inline functions.
13901 (DOWNCASE, UPCASE1): Reimplement using these functions.
13902 This avoids undefined behavior in expressions like
13903 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13904 from race conditions in accessing the global variables
13905 case_temp1 and case_temp2.
13906 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13907 * lisp.h (case_temp1, case_temp2): Remove their decls.
13908 * character.h (ASCII_CHAR_P): Move from here ...
13909 * lisp.h: ... to here, so that the inline functions mentioned
13910 above can use them.
13911
4a6bea26
PE
13912 * dired.c (directory_files_internal_unwind): Now static.
13913
f14b7e14
PE
13914 * fileio.c (file_name_as_directory, directory_file_name):
13915 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13916 Now static.
2893f146
PE
13917 (file_name_as_directory): Use const pointers when appropriate.
13918 (Fexpand_file_name): Likewise. In particular, newdir might
13919 point at constant storage, so make it a const pointer.
fd4ead52 13920 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13921 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13922 signedness issues.
f839df0c
PE
13923 (Fset_file_times, Finsert_file_contents, auto_save_error):
13924 Rename locals to avoid shadowing.
f14b7e14 13925
5716756e 13926 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13927 (Ftry_completion, Fall_completions): Rename or remove locals
13928 to avoid shadowing.
5716756e 13929
b4c3046a
PE
13930 * marker.c (bytepos_to_charpos): Remove; unused.
13931
b45db522
PE
13932 * lisp.h (verify_bytepos, count_markers): New decls,
13933 so that gcc does not warn that these functions aren't declared.
13934
85876d07
PE
13935 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13936 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13937 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13938 (copy_text): Remove unused local var.
85876d07 13939
03d78a21 13940 * filelock.c (within_one_second): Now static.
b3dd38ab 13941 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13942
5df8f01b
PE
13943 * buffer.c (fix_overlays_before): Mark locals as initialized.
13944 (fix_start_end_in_overlays): Likewise. This function should be
13945 simplified by using pointers-to-pointers, but that's a different
13946 matter.
b1d876f1 13947 (switch_to_buffer_1): Now static.
8f54f30a
PE
13948 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13949 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13950
a70072c9 13951 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13952 Fix pointer signedness issue.
edced198
PE
13953 (sys_subshell): Mark local as volatile if checking for lint,
13954 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13955 (MAXPATHLEN): Define only if needed.
a70072c9 13956
a0977c44
PE
13957 * process.c (serial_open, serial_configure): Move decls from here ...
13958 * systty.h: ... to here, so that they can be checked.
13959
a884fdcc
PE
13960 * fns.c (get_random, seed_random): Move extern decls from here ...
13961 * lisp.h: ... to here, so that they can be checked.
13962
604efe86 13963 * sysdep.c (reset_io): Now static.
b8950c94 13964 (wait_for_termination_signal): Remove; unused.
604efe86 13965
38fc62d9
PE
13966 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13967 (copy_keymap_item, append_key, push_text_char_description):
13968 Now static.
1004a21a 13969 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13970 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13971 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13972 (describe_map_tree):
13973 Rename locals to avoid shadowing.
38fc62d9 13974
2f2650da
PE
13975 * keyboard.c: Declare functions static if they are not used elsewhere.
13976 (echo_char, echo_dash, cmd_error, top_level_2):
13977 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13978 (read_char, kbd_buffer_get_event, make_lispy_position):
13979 (make_lispy_event, make_lispy_movement, apply_modifiers):
13980 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13981 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13982 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13983 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13984 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13985
a053e86c 13986 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13987 (mark_kboards): Move decl here ...
13988 * alloc.c (mark_kboards): ... from here.
a053e86c 13989
4752793e
PE
13990 * lisp.h (force_auto_save_soon): New decl.
13991
74f10ca7 13992 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13993 (DEFINE_DUMMY_FUNCTION): New macro.
13994 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13995 Use it.
c03cd23f
PE
13996 (main): Add casts to avoid warnings
13997 if GCC considers string literals to be constants.
74f10ca7 13998
022e70d4
PE
13999 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14000
59d6fe83
PE
14001 * dbusbind.c: Pointer signedness fixes.
14002 (xd_signature, xd_append_arg, xd_initialize):
14003 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14004 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14005 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14006 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14007
78320123
PE
14008 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14009 if GCC considers string literals to be constants.
49cebcca 14010 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14011
35ac2a97
SM
140122011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14013
fb103ca9
SM
14014 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14015 (print_preprocess, print_object): New macro to fix last change.
14016
35ac2a97
SM
14017 * print.c (print_preprocess): Don't forget font objects.
14018
62973b41
JB
140192011-03-16 Juanma Barranquero <lekktu@gmail.com>
14020
14021 * emacs.c (USAGE3): Doc fixes.
14022
0e48bb22
AS
140232011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14024
14025 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14026 structure.
14027
7684e57b
JB
140282011-03-14 Juanma Barranquero <lekktu@gmail.com>
14029
14030 * lisp.h (VWindow_system, Qfile_name_history):
14031 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14032 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14033 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14034
14035 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14036 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14037
14038 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14039 * w32console.c (detect_input_pending, read_input_pending)
14040 (encode_terminal_code):
14041 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14042 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14043 (w32_system_caret_y, Qfile_name_history):
14044 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14045 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14046 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14047 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14048 * w32proc.c (Qlocal, report_file_error):
14049 * w32term.c (Vwindow_system, updating_frame):
14050 * w32uniscribe.c (initialized, uniscribe_font_driver):
14051 Remove unneeded extern declarations.
14052
2aa46d6c
CY
140532011-03-14 Chong Yidong <cyd@stupidchicken.com>
14054
c96bbc66 14055 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14056
cffc6f3b
CY
140572011-03-13 Chong Yidong <cyd@stupidchicken.com>
14058
14059 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14060 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14061 These macros can no longer be used for assignment.
14062
44f230aa
SM
14063 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14064 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14065 (record_buffer_markers, fetch_buffer_markers): New functions for
14066 recording and fetching special buffer markers.
14067 (set_buffer_internal_1, set_buffer_temp): Use them.
14068
14069 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14070
14071 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14072
14073 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14074 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14075
14076 * xdisp.c (hscroll_window_tree):
14077 (reconsider_clip_changes): Use PT instead of BUF_PT.
14078
d251f04b
EZ
140792011-03-13 Eli Zaretskii <eliz@gnu.org>
14080
14081 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14082 $(EMACS_ROOT)/lib/intprops.h.
14083
f0c77cd1
PE
140842011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14085
3eca4629
PE
14086 Fix more problems found by GCC 4.5.2's static checks.
14087
7c86ee98
PE
14088 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14089 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14090 (xg_free_frame_widgets): Make it clear that a local variable is
14091 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14092 (gdk_window_get_screen): Make it clear that this macro is needed
14093 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14094 (int_gtk_range_get_value): New function, which avoids a diagnostic
14095 from gcc -Wbad-function-cast.
14096 (xg_set_toolkit_scroll_bar_thumb): Use it.
14097 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14098 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14099 (get_utf8_string, xg_get_file_with_chooser):
14100 Rename locals to avoid shadowing.
14101 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14102
41729b81
PE
14103 * xgselect.c (xg_select): Remove unused var.
14104
f0c77cd1
PE
14105 * image.c (four_corners_best): Mark locals as initialized.
14106 (gif_load): Initialize transparent_p to zero (Bug#8238).
14107 Mark another local as initialized.
ec6cf4c6 14108 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14109
ce0ad53d 14110 * image.c (clear_image_cache): Now static.
d5d5a617 14111 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14112 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14113 (x_edge_detection): Remove unnecessary cast that
14114 gcc -Wbad-function-cast diagnoses.
2037898d 14115 (gif_load): Fix pointer signedness.
6ae141d6
PE
14116 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14117 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14118
33383987 141192011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14120
d32df629
PE
14121 Improve quality of tests for time stamp overflow.
14122 For example, without this patch (encode-time 0 0 0 1 1
14123 1152921504606846976) returns the obviously-bogus value (-948597
14124 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14125 reports time overflow. See
14126 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14127 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14128 * editfns.c: Include limits.h and intprops.h.
14129 (TIME_T_MIN, TIME_T_MAX): New macros.
14130 (time_overflow): Move earlier, to before first use.
14131 (hi_time, lo_time): New functions, for an accurate test for
14132 out-of-range times.
14133 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14134 (Fget_internal_run_time): Don't assume time_t fits in int.
14135 (make_time): Use list2 instead of Fcons twice.
14136 (Fdecode_time): More accurate test for out-of-range times.
14137 (check_tm_member): New function.
14138 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14139 (lisp_time_argument): Don't rely on undefined left-shift and
14140 right-shift behavior when checking for time stamp overflow.
8be6f318 14141
fe31d94c
PE
14142 * editfns.c (time_overflow): New function, refactoring common code.
14143 (Fformat_time_string, Fdecode_time, Fencode_time):
14144 (Fcurrent_time_string): Use it.
14145
8be6f318
PE
14146 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14147 * dired.c (make_time): Move to ...
14148 * editfns.c (make_time): ... here.
14149 * systime.h: Note the move.
14150
09d9db2c 141512011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14152
126bc0dc
YM
14153 * fringe.c (update_window_fringes): Remove unused variables.
14154
c47cbdfd
YM
14155 * unexmacosx.c (copy_data_segment): Also copy __got section.
14156 (Bug#8223)
14157
7ac80be9
EZ
141582011-03-12 Eli Zaretskii <eliz@gnu.org>
14159
c96bbc66 14160 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14161 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14162 Constify `char *' arguments and their references according to
14163 prototypes in tparam.h.
14164
ecb0f94d 14165 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14166
7ac80be9
EZ
14167 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14168 Adapt all references accordingly.
14169
14170 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14171
ef1fd07e
TT
141722011-03-11 Tom Tromey <tromey@redhat.com>
14173
14174 * buffer.c (syms_of_buffer): Remove obsolete comment.
14175
7ef4b50c
EZ
141762011-03-11 Eli Zaretskii <eliz@gnu.org>
14177
14178 * termhooks.h (encode_terminal_code): Declare prototype.
14179
14180 * msdos.c (encode_terminal_code): Don't declare prototype.
14181
14182 * term.c (encode_terminal_code): Now external again, used by
14183 w32console.c and msdos.c.
14184
44f230aa
SM
14185 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14186 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14187
4b1ec863 141882011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14189
1714f52b 14190 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14191
4b1ec863
PE
14192 * fringe.c (update_window_fringes): Mark locals as initialized
14193 (Bug#8227).
14194 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14195
524c7aa6
PE
14196 * alloc.c (mark_fringe_data): Move decl from here ...
14197 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14198 to check its interface.
14199 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14200
a5c0af81 14201 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14202 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14203 (fontset_font): Mark local as initialized.
a9a06e0b 14204 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14205
b4716021
PE
14206 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14207
811e9bac 14208 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14209 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14210 (x_own_selection, Fx_disown_selection_internal): Rename locals
14211 to avoid shadowing.
14212 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14213
7e3ab302
PE
14214 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14215 so that the caller can use some name other than gcpro1.
14216 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14217 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14218 (Fx_backspace_delete_keys_p):
14219 Use them to avoid shadowing, and rename vars to avoid shadowing.
14220 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14221 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14222 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14223 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14224 Remove unused locals.
7e3ab302
PE
14225 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14226 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14227 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14228 macros.
f78faa98 14229
e2b13473
PE
14230 * xterm.h (x_mouse_leave): New decl.
14231
77f23912
PE
14232 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14233 Remove unused functions.
cdf4ba58
PE
14234 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14235 (x_calc_absolute_position): Now static.
7411c686 14236 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14237 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14238 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14239 unless they are used.
38d0b34a
PE
14240 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14241 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14242 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14243 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14244 (x_error_catcher, x_connection_closed, x_error_handler):
14245 (x_error_quitter, xembed_send_message, x_iconify_frame):
14246 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14247 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14248 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14249
44f230aa
SM
14250 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14251 Rename or move locals to avoid shadowing.
6b463e58 14252 (tty_defined_color, merge_face_heights): Now static.
5967d051 14253 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14254 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14255 does not deduce is never used uninitialized.
73719eba
PE
14256 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14257 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14258
426994c3 14259 * terminal.c (store_terminal_param): Now static.
5489860b 14260
032f1620 14261 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14262 (set_frame_menubar): Remove unused local.
d4323972 14263 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14264 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14265 since they might point to immutable storage.
281585b0
PE
14266 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14267 since it's unused otherwise.
032f1620 14268
367c19e5 14269 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14270 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14271 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14272 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14273 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14274 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14275 does not deduce are never used uninitialized.
70739cbe 14276
07b48fa9
PE
14277 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14278
8868a238 14279 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14280 * window.c (window_loop, size_window):
14281 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14282
7e5cf297 14283 * window.c (display_buffer): Now static.
d6550a9f
PE
14284 (size_window): Mark variables that gcc -Wuninitialized
14285 does not deduce are never used uninitialized.
a586633d
PE
14286 * window.h (check_all_windows): New decl, to forestall
14287 gcc -Wmissing-prototypes diagnostic.
5b555da1 14288 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14289
f6095868
PE
14290 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14291 shadowing.
14292 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14293 Include <limits.h>.
14294 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14295 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14296 (load_charset_map): Mark variables that gcc -Wuninitialized
14297 does not deduce are never used uninitialized.
53df7c11 14298 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14299
f38b440c
PE
14300 * coding.c (coding_set_source, coding_set_destination):
14301 Use "else { /* comment */ }" rather than "else /* comment */;"
14302 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14303 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14304 a block, when the outer 'i' will do.
14305 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14306 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14307 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14308 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14309 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14310 Rename locals to avoid shadowing.
14311 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14312 * coding.c (emacs_mule_char, encode_invocation_designation):
14313 Now static, since they're not used elsewhere.
413bb2db 14314 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14315 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14316 (decode_coding_emacs_mule): Mark variables that gcc
14317 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14318 (detect_coding_iso_2022): Initialize a local variable that might
14319 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14320 this initialization is needed. (Bug#8211)
5f58e762
PE
14321 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14322 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14323 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14324 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14325 Remove unused macros.
f38b440c 14326
232b38b9 14327 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14328 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14329 * character.c (string_count_byte8): Likewise.
232b38b9 14330
fb90da1b
PE
14331 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14332 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14333
fb93dbc2
PE
14334 * chartab.c (copy_sub_char_table): Now static, since it's not used
14335 elsewhere.
5c156ace
PE
14336 (sub_char_table_ref_and_range, char_table_ref_and_range):
14337 Rename locals to avoid shadowing.
bbcd0949 14338 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14339
7d3b3862 14340 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14341 (BIDI_BOB): Remove unused macro.
7d3b3862 14342
6be7d3da
PE
14343 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14344 deduce are never used uninitialized.
c2ed9c8b 14345 * term.c (encode_terminal_code): Likewise.
6be7d3da 14346
75f8807f 14347 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14348
50938595
PE
14349 * tparam.h: New file.
14350 * term.c, tparam.h: Include it.
14351 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14352 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14353 Move these decls to tparam.h, and make them agree with what
14354 is actually in tparam.c. The previous trick of using incompatible
14355 decls in different modules does not conform to the C standard.
14356 All callers of tparam changed to use tparam's actual API.
14357 * tparam.c (tparam1, tparam, tgoto):
14358 Use const pointers where appropriate.
14359
fbceeba2
PE
14360 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14361 * cm.h (struct cm): Likewise.
14362 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14363 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14364 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14365 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14366 (turn_on_face, init_tty): Likewise.
14367 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14368
7f3f1250
PE
14369 * term.c (term_mouse_position): Rename local to avoid shadowing.
14370
e6ca6543
PE
14371 * alloc.c (mark_ttys): Move decl from here ...
14372 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14373
c40f8d15
AS
143742011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14375
14376 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14377
cfe0661d
JB
143782011-03-09 Juanma Barranquero <lekktu@gmail.com>
14379
14380 * search.c (compile_pattern_1): Remove argument regp, unused since
14381 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14382 (compile_pattern): Don't pass it.
14383
0afb4571
J
143842011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14385
14386 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14387 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14388 for ! HAVE_GTK3.
14389 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14390
14391 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14392
14393 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14394 gdk_window_get_screen, gdk_window_get_geometry,
14395 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14396 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14397 (xg_get_pixbuf_from_pixmap): New function.
14398 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14399 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14400 Call xg_get_pixbuf_from_pixmap instead of
14401 gdk_pixbuf_get_from_drawable.
14402 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14403 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14404 (xg_check_special_colors): Use GtkStyleContext and its functions
14405 for HAVE_GTK3.
14406 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14407 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14408 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14409 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14410 Call gtk_widget_get_preferred_size.
0afb4571
J
14411 (xg_frame_resized): gdk_window_get_geometry only takes 5
14412 parameters.
44f230aa
SM
14413 (xg_win_to_widget, xg_event_is_for_menubar):
14414 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14415 (xg_set_widget_bg): New function.
14416 (delete_cb): New function.
895009e1 14417 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14418 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14419 (xg_set_background_color): Call xg_set_widget_bg.
14420 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14421 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14422 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14423 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14424 if ! HAVE_GTK3.
14425 (update_frame_tool_bar): Call gtk_widget_hide.
14426 (xg_initialize): Use GDK_KEY_g.
14427
14428 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14429 if ! HAVE_GTK3
14430 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14431
14432 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14433 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14434 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14435
1c2cc4ef
JB
144362011-03-08 Juanma Barranquero <lekktu@gmail.com>
14437
14438 * w32xfns.c (select_palette): Check success of RealizePalette against
14439 GDI_ERROR, not zero.
14440
33383987 14441See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14442
14443;; Local Variables:
14444;; coding: utf-8
aac0c6e3
MR
14445;; End:
14446
2f097256 14447 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14448
14449 This file is part of GNU Emacs.
14450
14451 GNU Emacs is free software: you can redistribute it and/or modify
14452 it under the terms of the GNU General Public License as published by
14453 the Free Software Foundation, either version 3 of the License, or
14454 (at your option) any later version.
14455
14456 GNU Emacs is distributed in the hope that it will be useful,
14457 but WITHOUT ANY WARRANTY; without even the implied warranty of
14458 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14459 GNU General Public License for more details.
14460
14461 You should have received a copy of the GNU General Public License
14462 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.