Fixes: debbugs:11285
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2f38dff7
PE
12012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2
3 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4 It is never used otherwise.
5
4ae29f89
SM
62012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
7
8 * print.c (print_preprocess): Only check print_depth if print-circle
9 is nil.
10 (print_object): Check for cycles even when print-circle is nil and
11 print-gensym is t, but only check print_depth if print-circle is nil.
12
f30d612a
CY
132012-04-20 Chong Yidong <cyd@gnu.org>
14
15 * process.c (wait_reading_process_output): If EIO occurs on a pty,
16 set the status to "failed" and ensure that sentinel is run.
17
c07a4c0b 182012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
19
20 * process.c (Fset_process_inherit_coding_system_flag)
21 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 22 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 23
c07a4c0b 242012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
25
26 * xdisp.c (string_buffer_position_lim): Limit starting position to
27 BEGV.
28 (set_cursor_from_row): If called for a mode-line or header-line
29 row, return zero immediately.
30 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
31 farther than the first row after the header line, if any.
32 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
33 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
34
c07a4c0b 352012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 36
4ae29f89
SM
37 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
38 (bug#11238).
ad3a2b41 39
c07a4c0b 402012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 412012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
42
43 configure: new option --enable-gcc-warnings (Bug#11207)
44 * Makefile.in (C_WARNINGS_SWITCH): Remove.
45 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
46 (ALL_CFLAGS): Use new macros rather than old.
47 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
48 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
49 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
50 -Wunused-result, -Wunused-variable. This should go away once
51 the Emacs and Gnulib regex code is merged.
52 (xmalloc, xrealloc): Now static.
53
aba027e8
PE
542012-04-17 Paul Eggert <eggert@cs.ucla.edu>
55
56 * dired.c (Fsystem_groups): Remove unused local.
57
e5a36063
GM
582012-04-17 Glenn Morris <rgm@gnu.org>
59
60 * dired.c (Fsystem_users): Doc fix.
61
316411f0
DA
622012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
63
64 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
65 (syms_of_dired): Add them.
66
9426aba4
PE
672012-04-16 Paul Eggert <eggert@cs.ucla.edu>
68
b62a57be
PE
69 Fix minor alloc.c problems found by static checking.
70 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
71 New extern decls, to avoid calling undeclared functions.
72 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
73 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
74 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
75 (NEED_MEM_INSERT): New macro.
76 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 77 Remove one incorrect comment and fix another.
b62a57be 78
3539f31f
PE
79 Fix minor ralloc.c problems found by static checking.
80 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
81 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
82 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
83 (r_alloc_sbrk): Now static.
84
a041960a
PE
85 Improve ralloc.c interface checking.
86 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
87 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
88 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
89 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
90 [REL_ALLOC]: ... to here, to check interface.
91 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
92 Remove decls. This fixes an "It stinks!".
93
9426aba4
PE
94 * alloc.c (which_symbols): Fix alignment issue / type clash.
95
d55c12ed
AS
962012-04-15 Andreas Schwab <schwab@linux-m68k.org>
97
98 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
99 (struct Lisp_Misc_Any): Likewise.
100 (struct Lisp_Free): Likewise.
101 * alloc.c (union aligned_Lisp_Symbol): Define.
102 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
103 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
104 (union aligned_Lisp_Misc): Define.
105 (MARKER_BLOCK_SIZE, struct marker_block): Use union
106 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 107 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 108
b948ce8b
PE
1092012-04-14 Paul Eggert <eggert@cs.ucla.edu>
110
111 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
112 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
113 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
114 * s/netbsd.h, s/sol2-6.h:
115 Remove definition of GC_MARK_STACK, since the default now works.
116 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
117 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
118 no longer the default.
119 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
120
35dc09a1 1212012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 122
35dc09a1
GM
123 * lread.c (lisp_file_lexically_bound_p):
124 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 125
35dc09a1
GM
1262012-04-14 Eli Zaretskii <eliz@gnu.org>
127
128 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
129 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
130
1312012-04-14 Jan Djärv <jan.h.d@swipnet.se>
132
133 * nsterm.m (constrainFrameRect): Always constrain when there is only
134 one screen (Bug#10962).
135
bcd86815
KB
1362012-04-13 Ken Brown <kbrown@cornell.edu>
137
138 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
139
c25df26e
RT
1402012-04-13 Reuben Thomas <rrt@sc3d.org>
141
142 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
143
0fc59f1e
DC
1442012-04-11 Daniel Colascione <dancol@dancol.org>
145
146 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
147 against is gone. It's better to use vfork now so that when Cygwin
148 gains a new, working vfork, we use it automatically (bug#10398).
149
de8c03dc
SM
1502012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
151
152 * window.c (save_window_save): Obey window-point-insertion-type.
153
2f097256
GM
1542012-04-11 Glenn Morris <rgm@gnu.org>
155
156 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
157
453b951e
SM
1582012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
159
160 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
161
75f1671a 1622012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
163
164 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
165 (force_quit_count): New var.
166 (handle_interrupt): Use it.
167
2a8ce227
JB
1682012-04-10 Juanma Barranquero <lekktu@gmail.com>
169
170 * w32.c (w32_delayed_load): Record the full path of the library
171 being loaded (bug#10424).
172
935396c0
GM
1732012-04-09 Glenn Morris <rgm@gnu.org>
174
05920a43
GM
175 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
176 not just in the obarray, before snarfing them. (Bug#11036)
177
935396c0
GM
178 * Makefile.in ($(leimdir)/leim-list.el):
179 Pass EMACS rather than BUILT_EMACS.
180
a18ecafa
TZ
1812012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
182
183 * process.c (make_process):
184 * process.h: Add integer `gnutls_handshakes_tried' member to
185 process struct.
186
6bbef4e5
JC
187 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
188 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
189
190 * gnutls.c (gnutls_log_function2i): Convenience log function.
191 (emacs_gnutls_read): Use new log functions,
192 `gnutls_handshakes_tried' process member, and
193 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
194 attempts per process (connection).
195
b4d3bc10
CY
1962012-04-09 Chong Yidong <cyd@gnu.org>
197
198 * eval.c (Fuser_variable_p, user_variable_p_eh)
199 (lisp_indirect_variable): Functions deleted.
200 (Fdefvar): Caller changed.
201
202 * callint.c (Finteractive, Fcall_interactively):
203 * minibuf.c (Fread_variable): Callers changed.
204
70f4d973
EZ
2052012-04-09 Eli Zaretskii <eliz@gnu.org>
206
207 * xdisp.c (set_cursor_from_row): If the display string appears in
208 the buffer at position that is closer to point than the position
209 after the display string, display the cursor on the first glyph of
210 the display string. Fixes cursor display when a 'display' text
211 property immediately follows invisible text. (Bug#11094)
212
cb3c2e3e
PE
2132012-04-09 Paul Eggert <eggert@cs.ucla.edu>
214
215 composite.c: use 'double' consistently
216 * composite.c (get_composition_id): Use 'double' consistently
217 instead of converting 'float' to 'double' and vice versa; this is
218 easier to understand and avoids a GCC warning.
219
fd06db5d
GM
2202012-04-09 Glenn Morris <rgm@gnu.org>
221
50fe702a
GM
222 * Makefile.in: Generate leim-list with bootstrap-emacs, in
223 preparation for dumping it with emacs. (Bug#4789)
224 (leimdir): New variable.
225 ($(leimdir)/leim-list.el): New rule.
226 (emacs$(EXEEXT)): Depend on leim-list.el.
227
fd06db5d
GM
228 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
229 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
230 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
231
55c131ee
AS
2322012-04-08 Andreas Schwab <schwab@linux-m68k.org>
233
234 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
235 proper alignment.
236
9209588f
JB
2372012-04-07 Juanma Barranquero <lekktu@gmail.com>
238
239 * xml.c (init_libxml2_functions) [WINDOWSNT]:
240 Remove unused local variable.
241
e3fb2efb
PE
2422012-04-07 Paul Eggert <eggert@cs.ucla.edu>
243
244 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
245 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
246 (mark_memory): Mark Lisp_Objects only if pointers might hide in
247 objects, as mark_maybe_pointer will catch them otherwise.
248 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
249 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
250
b5385551
PE
2512012-04-07 Paul Eggert <eggert@cs.ucla.edu>
252
253 Fix typo that broke non-Windows builds.
254 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
255
9078ead6
EZ
2562012-04-07 Eli Zaretskii <eliz@gnu.org>
257
258 Support building on MS-Windows with libxml2.
259
260 * makefile.w32-in (OBJ2): Add xml.$(O).
261 (GLOBAL_SOURCES): Add xml.c.
262 ($(BLD)/xml.$(O)): New dependency list.
263
264 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
265 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
266 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
267 [!WINDOWSNT]: New macros.
268 (init_libxml2_functions, libxml2_loaded_p): New functions.
269 (parse_region): Call fn_xmlCheckVersion instead of using the macro
270 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
271 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
272 Calls xmlCleanupParser only if libxml2 was loaded (or statically
273 linked in).
6bbef4e5
JC
274 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
275 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
276 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
277
278 * emacs.c: Don't include libxml/parser.h.
279 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
280 xmlCleanupParser directly.
281
282 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
283
3811fdf3
EZ
2842012-04-07 Eli Zaretskii <eliz@gnu.org>
285
286 * indent.c (Fvertical_motion): If there is a display string at
287 point, use it.vpos to compute how many lines to backtrack after
288 move_it_to point. (Bug#11133)
289
2f8e16b2
EZ
2902012-04-06 Eli Zaretskii <eliz@gnu.org>
291
292 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
293 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
294 about subtle differences between FETCH_CHAR* and STRING_CHAR*
295 macros related to unification of CJK characters. For the details,
296 see the discussion following the message here:
297 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
298
3d439cd1
CY
2992012-04-04 Chong Yidong <cyd@gnu.org>
300
301 * keyboard.c (Vdelayed_warnings_list): Doc fix.
302
8bc53d00
EZ
3032012-04-01 Eli Zaretskii <eliz@gnu.org>
304
305 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
306 instead of alloca. (Bug#11138)
307
3b0512a3
AS
3082012-04-01 Andreas Schwab <schwab@linux-m68k.org>
309
310 * w32menu.c (is_simple_dialog): Properly check lisp types.
311 (Bug#11141)
312
8427ddd2
EZ
3132012-03-31 Eli Zaretskii <eliz@gnu.org>
314
979022ef
EZ
315 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
316 position we get to after a call to move_it_to fails the
317 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
318 only if we wind up in a string from display property. (Bug#11063)
319
a6b1c7cc
EZ
320 * window.c (Fdelete_other_windows_internal): Invalidate the row
321 and column information about mouse highlight, so that redisplay
322 restores it after reallocating the glyph matrices. (Bug#7464)
323
8427ddd2
EZ
324 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
325 string comes from a `display' text property, use the buffer
326 position of that property as if we actually saw that position in
327 the row's glyphs.
697ba24b
EZ
328 (move_it_by_lines): Remove the assertion that
329 "it->current_x == 0 && it->hpos == 0" which can be legitimately
330 violated when there's a before-string at the beginning of a line.
331 (Bug#11063)
8427ddd2 332
65a0a738
EZ
3332012-03-30 Eli Zaretskii <eliz@gnu.org>
334
335 * xdisp.c (append_space_for_newline): If the default face was
336 remapped, use the remapped face for the appended newline.
337 (extend_face_to_end_of_line): Use the remapped default face for
338 extending the face to the end of the line.
339 (display_line): Call extend_face_to_end_of_line when the default
340 face was remapped. (Bug#11068)
341
581355cc
EZ
3422012-03-29 Eli Zaretskii <eliz@gnu.org>
343
344 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
345
e8fc049f
SM
3462012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
347
348 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
349
4fb9a543
GM
3502012-03-27 Glenn Morris <rgm@gnu.org>
351
352 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
353 Doc fixes.
354
679910f1
KH
3552012-03-26 Kenichi Handa <handa@m17n.org>
356
357 * dispextern.h (struct glyph): Fix previous change. Change the
358 bit length of glyphless.ch to 25 (Bug#11082).
359
90d49b7f
CY
3602012-03-26 Chong Yidong <cyd@gnu.org>
361
362 * keyboard.c (Vselection_inhibit_update_commands): New variable.
363 (command_loop_1): Use it; inhibit selection update for
364 handle-select-window too (Bug#8996).
365
f514f6f0
FP
3662012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
367
e8fc049f 368 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 369
bf43fa51
KH
3702012-03-25 Kenichi Handa <handa@m17n.org>
371
372 * dispextern.h (struct glyph): Change the bit length of
373 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
374
8a0c01dd
EZ
3752012-03-24 Eli Zaretskii <eliz@gnu.org>
376
377 * s/ms-w32.h (tzname): Include time.h before redirecting to
378 _tzname. Fixes the MSVC build. (Bug#9960)
379
7d1c3a76
AS
3802012-03-24 Andreas Schwab <schwab@linux-m68k.org>
381
8ed79523
AS
382 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
383 characters.
384
7d1c3a76
AS
385 * xterm.c (XTread_socket): Only modify handling_signal if
386 !SYNC_INPUT. (Bug#11080)
387
e99a9b8b
EZ
3882012-03-23 Eli Zaretskii <eliz@gnu.org>
389
390 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
391 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
392 when fetching a multibyte character consumes more bytes than
393 CHAR_BYTES returns, due to unification of CJK characters in
394 string_char. (Bug#11073)
395
5063c0e1
TN
3962012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
397
398 * process.c (wait_reading_process_output): Handle pty disconnect
399 by refraining from sending oneself a SIGCHLD (bug#10933).
400
9f851fbd
CY
4012012-03-22 Chong Yidong <cyd@gnu.org>
402
403 * dispextern.h (struct it): New member string_from_prefix_prop_p.
404
5063c0e1 405 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
406 Mark string as coming from a prefix property.
407 (handle_face_prop): Use default face for prefix strings (Bug#4281).
408 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
409
fb5b8aca
CY
4102012-03-21 Chong Yidong <cyd@gnu.org>
411
412 * xfaces.c (Vface_remapping_alist): Doc fix.
413
62356a1b
EZ
4142012-03-20 Eli Zaretskii <eliz@gnu.org>
415
416 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
417 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
418 Doc fixes.
62356a1b 419
025de85b
CY
4202012-03-20 Chong Yidong <cyd@gnu.org>
421
422 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
423 to reflect default non-nil value of redisplay-dont-pause.
424
4827f94e
KH
4252012-03-19 Kenichi Handa <handa@m17n.org>
426
427 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
428 it fit in a valid range (Bug#11003).
429
e50a24a2
EZ
4302012-03-18 Eli Zaretskii <eliz@gnu.org>
431
432 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
433 that is not from display property, accept the row as a "cursor
434 row" if one of the string's character has a non-nil `cursor'
435 property. Fixes cursor positioning when there are newlines in
436 overlay strings, e.g. in icomplete.el. (Bug#11035)
437
9af5ed87
PE
4382012-03-12 Paul Eggert <eggert@cs.ucla.edu>
439
440 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
441
d1f55f16
CY
4422012-03-12 Chong Yidong <cyd@gnu.org>
443
444 * eval.c (inhibit_lisp_code): Rename from
445 inhibit_window_configuration_change_hook; move from window.c.
446
447 * xfns.c (unwind_create_frame_1, Fx_create_frame):
448 * window.c (run_window_configuration_change_hook)
449 (syms_of_window): Callers changed.
450
66c5eebd
CY
4512012-03-11 Chong Yidong <cyd@gnu.org>
452
413df973
CY
453 * keymap.c (Fkey_description): Doc fix (Bug#9700).
454
66c5eebd
CY
455 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
456
1de11f56
CY
4572012-03-10 Chong Yidong <cyd@gnu.org>
458
459 * frame.c (other_visible_frames): Don't assume the selected frame
460 is visible (Bug#10955).
461
cae07000
SM
4622012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
463
464 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
465
89c94350
JD
4662012-03-08 Jan Djärv <jan.h.d@swipnet.se>
467
468 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
469 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
470 zero (Bug#10954).
471
999dd333
GM
4722012-03-03 Glenn Morris <rgm@gnu.org>
473
01a6dcc8 474 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 475
de0100f2
EZ
4762012-03-02 Eli Zaretskii <eliz@gnu.org>
477
478 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
479 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
480 (redisplay_window, next_element_from_string): Fix typos in
481 comments.
3e441275
EZ
482 (redisplay_window): Pass to move_it_vertically the margin in
483 pixels, not in screen lines.
de0100f2 484
96a72ee9
GM
4852012-03-02 Glenn Morris <rgm@gnu.org>
486
487 * buffer.c (buffer-list-update-hook): Doc fix.
488
312508d7
EZ
4892012-02-29 Eli Zaretskii <eliz@gnu.org>
490
491 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
492 push_it before setting up the iterator for the first overlay
493 string, even if we have an empty string loaded.
494 (next_overlay_string): If there's an empty string on the iterator
495 stack, pop the stack. (Bug#10903)
496
27f3c637
PE
4972012-02-25 Paul Eggert <eggert@cs.ucla.edu>
498
499 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
500 Suggested by Stefan Monnier in
501 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
502 * alloc.c (widen_to_Lisp_Object): New static function.
503 (mark_memory): Also mark Lisp_Objects by fetching pointer words
504 and widening them to Lisp_Objects. This would work even if
505 USE_LSB_TAG is defined and wide integers are used, which might
506 happen in a future version of Emacs.
507
3c9dfce6
CY
5082012-02-25 Chong Yidong <cyd@gnu.org>
509
fa74b241
CY
510 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
511 Doc fix.
512
3c9dfce6
CY
513 * xselect.c (Fx_selection_exists_p): Doc fix.
514 (x_clipboard_manager_save_all): Print an informative message
515 before saving to clipboard manager.
516
9486df08
CY
5172012-02-24 Chong Yidong <cyd@gnu.org>
518
519 * keyboard.c (process_special_events): Handle all X selection
520 requests in kbd_buffer, not just the next one (Bug#8869).
521
f01d3321
CY
5222012-02-23 Chong Yidong <cyd@gnu.org>
523
524 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
525 call when setting menu-bar-lines and tool-bar-lines parameters.
526 (unwind_create_frame_1): New helper function.
527
528 * window.c (inhibit_window_configuration_change_hook): New var.
529 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 530 (syms_of_window): Initialize it.
f01d3321 531
86b847b6
CY
5322012-02-22 Chong Yidong <cyd@gnu.org>
533
534 * xterm.c (x_draw_image_relief): Add missing type check for
535 Vtool_bar_button_margin (Bug#10743).
536
a59225b1
CY
5372012-02-21 Chong Yidong <cyd@gnu.org>
538
539 * fileio.c (Vfile_name_handler_alist): Doc fix.
540
541 * buffer.c (Fget_file_buffer): Protect against invalid file
542 handler return value.
543
310f5bd4
PE
5442012-02-20 Paul Eggert <eggert@cs.ucla.edu>
545
cb3a28cc
PE
546 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
547 when computing $valmask.
548
310f5bd4
PE
549 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
550 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
551 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
552 It's useless in that case, and it can cause problems on hosts
553 that allocate halves of EMACS_INT values separately.
554 Reported by Dan Horák. Diagnosed by Andreas Schwab in
555 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
556 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
557 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
558 it avoids undefined behavior on hosts where shifting right by more
559 than the word width has undefined behavior.
560
2375c96a
CY
5612012-02-19 Chong Yidong <cyd@gnu.org>
562
563 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
564 (Funhandled_file_name_directory, Ffile_name_as_directory)
565 (Fdirectory_file_name, Fexpand_file_name)
566 (Fsubstitute_in_file_name): Protect against invalid file handler
567 return values (Bug#10845).
568
3eb49e71
EZ
5692012-02-18 Eli Zaretskii <eliz@gnu.org>
570
571 * .gdbinit (pitx): Fix incorrect references to fields of the
572 iterator stack.
573
7b926f3f
CY
5742012-02-17 Chong Yidong <cyd@gnu.org>
575
576 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
577
11273115
PE
5782012-02-15 Paul Eggert <eggert@cs.ucla.edu>
579
580 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
581 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
582
c3a70e2b
CY
5832012-02-15 Chong Yidong <cyd@gnu.org>
584
585 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
586 marked as special. Also, starting docstrings with * is obsolete.
587
0ca43699
AS
5882012-02-13 Andreas Schwab <schwab@linux-m68k.org>
589
590 * gnutls.c (emacs_gnutls_write): Fix last change.
591
2e8f3c56
LI
5922012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
593
594 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
595 send_process.
596
af70074f
SM
5972012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
598
599 * keymap.c (Fsingle_key_description): Handle char ranges.
600
95986d52
CY
6012012-02-12 Chong Yidong <cyd@gnu.org>
602
afd83bd1
CY
603 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
604 as that creates a dangerous corner case.
605
95986d52
CY
606 * window.c (Fdelete_window_internal): Invalidate the mouse
607 highlight (Bug#9904).
608
bd7da63e
GM
6092012-02-12 Glenn Morris <rgm@gnu.org>
610
611 * xselect.c (Fx_own_selection_internal)
612 (Fx_get_selection_internal, Fx_disown_selection_internal)
613 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
614 * nsselect.m (Fx_own_selection_internal)
615 (Fx_disown_selection_internal, Fx_selection_exists_p)
616 (Fx_selection_owner_p, Fx_get_selection_internal):
617 Sync docs and argument specs with the xselect.c versions.
618
77abcbc2
LI
6192012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
620
621 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
622
90b671e2
EZ
6232012-02-11 Eli Zaretskii <eliz@gnu.org>
624
1c0ca0b7
EZ
625 * w32select.c (Fx_selection_exists_p): Sync doc string and
626 argument list with xselect.c. (Bug#10783)
627
628 * w16select.c (Fx_selection_exists_p): Sync doc string and
629 argument list with xselect.c. (Bug#10783)
90b671e2 630
49241268
GM
6312012-02-10 Glenn Morris <rgm@gnu.org>
632
633 * fns.c (Fsecure_hash): Doc fix.
634
f998bbe7 6352012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
636
637 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
638
0992bd9c
CY
6392012-02-07 Chong Yidong <cyd@gnu.org>
640
641 * buffer.c (Fbuffer_local_variables)
642 (buffer_lisp_local_variables): Handle unbound vars correctly;
643 don't let Qunbound leak into Lisp.
644
af008560
GM
6452012-02-07 Glenn Morris <rgm@gnu.org>
646
dd605cc4
GM
647 * image.c (Fimagemagick_types): Doc fix.
648
af008560
GM
649 * image.c (imagemagick-render-type): Change it from a lisp object
650 to an integer. Move the doc here from the lisp manual.
651 Treat all values not equal to 0 the same.
652
1449fa1d
CY
6532012-02-06 Chong Yidong <cyd@gnu.org>
654
655 * doc.c (store_function_docstring): Avoid applying docstring of
656 alias to base function (Bug#2603).
657
3723ec07
AS
6582012-02-04 Andreas Schwab <schwab@linux-m68k.org>
659
660 * .gdbinit (pp1, pv1): Remove redundant defines.
661 (pr): Use pp.
662
79c1cc1e
CY
6632012-02-04 Chong Yidong <cyd@gnu.org>
664
665 * nsterm.m: Declare a global (Bug#10694).
666
d7f29f8e
EZ
6672012-02-04 Eli Zaretskii <eliz@gnu.org>
668
cae07000
SM
669 * w32.c (get_emacs_configuration_options):
670 Include --enable-checking, if specified, in the return value.
d7f29f8e 671
3b95a6f9
MR
6722012-02-04 Martin Rudalics <rudalics@gmx.at>
673
674 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
675 after rounding frame sizes. (Bug#9723)
676
d6fa96a6
EZ
6772012-02-04 Eli Zaretskii <eliz@gnu.org>
678
679 * keyboard.c (adjust_point_for_property): Don't position point
680 before BEGV. (Bug#10696)
681
df0b2940
PE
6822012-02-03 Paul Eggert <eggert@cs.ucla.edu>
683
684 Handle overflow when computing char display width (Bug#9496).
685 * character.c (char_width): Return EMACS_INT, not int.
686 (char_width, c_string_width): Check for overflow when
687 computing the width; this is possible now that individual
688 characters can have unbounded width. Problem introduced
689 by merge from Emacs 23 on 2012-01-19.
690
6bee44d6
MA
6912012-02-02 Michael Albinus <michael.albinus@gmx.de>
692
693 * dbusbind.c (Fdbus_register_method): Mention the return value
694 :ignore in the docstring.
695
44f92739
GM
6962012-02-02 Glenn Morris <rgm@gnu.org>
697
1b9f60cc
GM
698 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
699
44f92739
GM
700 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
701 Unconditionally set to t. (Bug#10673)
702 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
703 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
704 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
705
c5d3843c
KH
7062012-02-02 Kenichi Handa <handa@m17n.org>
707
708 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
709 0, do not call append_composite_glyph.
710
159462d4 7112012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
712
713 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
714 NULL (Bug#6988).
715 (x_produce_glyphs): If the component of a composition is a null
716 string, set it->pixel_width to 1 to avoid zero-width glyph.
717
78cef877
EZ
7182012-02-01 Eli Zaretskii <eliz@gnu.org>
719
720 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
721 first 2 arguments are identical. This makes inserting large
722 output from a subprocess an order of magnitude faster on
723 MS-Windows, where all sbrk'ed memory is always contiguous.
724
97897668
GM
7252012-01-31 Glenn Morris <rgm@gnu.org>
726
727 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 728 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
729 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
730
31fd3586
GM
7312012-01-29 Glenn Morris <rgm@gnu.org>
732
733 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
734
0e24a8b2
CY
7352012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
736
737 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
738
cc0adcb0
CY
7392012-01-28 Chong Yidong <cyd@gnu.org>
740
741 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
742
acc28cb9
CY
7432012-01-26 Chong Yidong <cyd@gnu.org>
744
9c69cfb7
CY
745 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
746
acc28cb9
CY
747 * search.c (Fsearch_forward, Fsearch_backward): Document negative
748 repeat counts (Bug#10507).
749
48da7392
GM
7502012-01-26 Glenn Morris <rgm@gnu.org>
751
752 * lread.c (syms_of_lread): Doc fix.
753
14af5f7f
CY
7542012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
755
756 * coding.c (encode_designation_at_bol): Change return value to
757 EMACS_INT.
758
0b21c100
CY
7592012-01-25 Chong Yidong <cyd@gnu.org>
760
761 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
762
3c2907f7
CY
7632012-01-21 Chong Yidong <cyd@gnu.org>
764
765 * floatfns.c (Fcopysign): Make the second argument non-optional,
766 since nil is not allowed anyway.
767
959ad23f
AS
7682012-01-21 Andreas Schwab <schwab@linux-m68k.org>
769
770 * process.c (read_process_output): Use p instead of XPROCESS (proc).
771 (send_process): Likewise.
772
34a02f46
MR
7732012-01-19 Martin Rudalics <rudalics@gmx.at>
774
775 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
776 (Vwindow_persistent_parameters): Do not use Qstate.
777 Rewrite doc-strings.
34a02f46 778
1259009a 7792012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
780
781 * character.c (char_width): New function.
70d4fdf6
GM
782 (Fchar_width, c_string_width, lisp_string_width):
783 Use char_width (Bug#9496).
25ed9e61 784
6a6ee00d
MR
7852012-01-16 Martin Rudalics <rudalics@gmx.at>
786
787 * window.c (Vwindow_persistent_parameters): New variable.
788 (Fset_window_configuration, save_window_save): Handle persistent
789 window parameters.
790
c85efaf7
EZ
7912012-01-14 Eli Zaretskii <eliz@gnu.org>
792
793 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
794 thrashing the stack of the thread. (Bug#9087)
795
5944709e
PE
7962012-01-12 Paul Eggert <eggert@cs.ucla.edu>
797
798 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
799
e71f5d99
EZ
8002012-01-11 Eli Zaretskii <eliz@gnu.org>
801
802 * xdisp.c (rows_from_pos_range): Handle the case where the
803 highlight ends on a newline. (Bug#10464)
804 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
805 he end column for display of highlight that ends on a newline
806 before a R2L line.
807
ce316182
GM
8082012-01-11 Glenn Morris <rgm@gnu.org>
809
810 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
811 from load-path also when installation-directory is nil. (Bug#10208)
812
5b43da69
GM
8132012-01-10 Glenn Morris <rgm@gnu.org>
814
74cc8ff9
GM
815 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
816
7d8d6e4e
GM
817 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
818 Update template values to be closer to their typical values these days.
5b43da69 819
a0db8d43
EZ
8202012-01-09 Eli Zaretskii <eliz@gnu.org>
821
822 * xdisp.c (rows_from_pos_range): Accept additional argument
823 DISP_STRING, and accept any glyph in a row whose object is that
824 string as eligible for mouse highlight. Fixes mouse highlight of
825 display strings from overlays. (Bug#10464)
826
9a0115ab 8272012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 828
b9110d6a 829 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
830 * fileio.c (auto_saving_dir_umask): New static var.
831 (Fmake_directory_internal): Use it.
832 (do_auto_save_make_dir): Set it, instead of invoking chmod after
833 creating the directory. The old code temporarily assigns
834 too-generous permissions to the directory.
835 (do_auto_save_eh): Clear it.
b9110d6a 836 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
837 that the var is always cleared.
838
6c1bd3f3
EZ
8392012-01-07 Eli Zaretskii <eliz@gnu.org>
840
841 * search.c (scan_buffer): Pass character positions to
842 know_region_cache, not byte positions. (Bug#6540)
843
069d2b50
L
8442012-01-07 LynX <_LynX@bk.ru> (tiny change)
845
846 * w32.c (sys_rename): Report EXDEV when rename of a directory
847 fails because the target is on another logical disk. (Bug#10284)
848
75bf0d33
DB
8492012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
850
851 * xterm.c (x_embed_request_focus): New function.
852
853 * xterm.h: Add prototype.
854
855 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
856
1c6e5a32
GM
8572012-01-05 Glenn Morris <rgm@gnu.org>
858
859 * emacs.c (emacs_copyright): Update short copyright year to 2012.
860
651e947e
EZ
8612012-01-01 Eli Zaretskii <eliz@gnu.org>
862
863 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
864 Load gnutls_transport_set_lowat only if GnuTLS version is below
865 2.11.1.
866 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
867 GnuTLS versions below 2.11.1.
868
3778cdd8
AL
8692011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
870
871 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
872 to the doc string advising against its use for altering the way
873 windows are scrolled.
874
0e5317f7
KH
8752011-12-28 Kenichi Handa <handa@m17n.org>
876
877 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
878 coding-system ASCII compatible only when it does not produce BOM
879 on encoding (Bug#10383).
880
93d5ca1f
JD
8812011-12-26 Jan Djärv <jan.h.d@swipnet.se>
882
883 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
884 can scroll.
885 (create_and_show_popup_menu): Always use menu_position_func for
886 Gtk3 (Bug#10361).
887
ca22b785
AS
8882011-12-24 Andreas Schwab <schwab@linux-m68k.org>
889
890 * callint.c (Fcall_interactively): Don't truncate prompt string.
891
d048e1e6
EZ
8922011-12-23 Eli Zaretskii <eliz@gnu.org>
893
894 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
895 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 896 resumed from there (after widening). (Bug#10360)
d048e1e6 897
5ccaba1f
JD
8982011-12-22 Jan Djärv <jan.h.d@swipnet.se>
899
900 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
901
204ee57f
JD
9022011-12-21 Jan Djärv <jan.h.d@swipnet.se>
903
b81d40f0
JB
904 * nsterm.m (x_free_frame_resources):
905 Release f->output_data.ns->miniimage.
204ee57f
JD
906 (ns_index_color): Fix indentation. Do not retain
907 color_table->colors[i].
908
909 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
910 before returning.
911
912 * nsfns.m (x_set_background_color): Assign return value from
913 ns_index_color to face-background instead of NSColor*.
914 (ns_implicitly_set_icon_type): Fix indentation.
915 Change assignment in for loop to comparison.
916
917 * emacs.c (ns_pool): New variable.
918 (main): Assign ns_pool.
919 (Fkill_emacs): Call ns_release_autorelease_pool.
920
921 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
922 autorelease fdesc, release fdAttrs and tdict.
923 (ns_get_covering_families): Release charset.
924 (ns_findfonts): Release NSFontDescriptor created with new.
925 (ns_uni_to_glyphs): Fix indentation.
926 (setString): Release attrStr before assigning new value.
927
c803b2b7
JD
9282011-12-18 Jan Djärv <jan.h.d@swipnet.se>
929
678f4426
JD
930 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
931 and NS_IMPL_COCOA.
932 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
933 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
934
cd394be1 9352011-12-18 David Reitter <reitter@cmu.edu>
678f4426 936
5fecd5fc
JD
937 * nsterm.m (ns_term_init): Subscribe for notifications
938 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
939 to method trackingNotification in EmacsMenu.
940
941 * nsmenu.m (trackingMenu): New variable.
3771cb17 942 (trackingNotification): New method (from Aquamacs).
5fecd5fc 943 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 944 from Aquamacs (Bug#7030).
678f4426
JD
945
9462011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 947
c803b2b7
JD
948 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
949 (symbol_to_nsstring): Fix indentation.
950 (ns_symbol_to_pb): New function.
cae07000
SM
951 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
952 (Fns_rotate_cut_buffers_internal): Remove.
953 (Fns_store_selection_internal): Rename from
c803b2b7
JD
954 Fns_store_cut_buffer_internal.
955 (ns_get_foreign_selection, Fx_own_selection_internal)
956 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
957 (Fns_get_selection_internal, Fns_store_selection_internal):
958 Use ns_symbol_to_pb and check if return value is nil.
959 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
960 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
961 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
962 renamed to Sns_store_selection_internal.
963 (ns_handle_selection_request): Move code to Fx_own_selection_internal
964 and remove this function.
965 (ns_handle_selection_clear): Remove, never used.
966 (Fx_own_selection_internal): Move code from ns_handle_selection_request
967 here.
968
e1b01a3a
KB
9692011-12-17 Ken Brown <kbrown@cornell.edu>
970
971 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
972 GID is unknown (Bug#10257).
973
2adb6e85
PE
9742011-12-17 Paul Eggert <eggert@cs.ucla.edu>
975
976 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
977 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
978 which caused a build failure on GNU/Linux IA-64. This problem was
979 introduced by my 2011-10-07 patch.
980
d1d7b339
JL
9812011-12-15 Juri Linkov <juri@jurta.org>
982
983 * image.c (imagemagick_error): New function. (Bug#10112)
984 (imagemagick_load_image): Comment out `MagickSetResolution' call.
985 Use `imagemagick_error' where ImageMagick functions return
986 `MagickFalse'.
987 (Fimagemagick_types): Add `Fnreverse' to return the list in the
988 proper order.
989
100d5755
KH
9902011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
991
992 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
993 fill background (Bug#8992).
994
454592a6
MR
9952011-12-13 Martin Rudalics <rudalics@gmx.at>
996
997 * window.c (Vwindow_combination_resize)
998 (Vwindow_combination_limit): Use t instead of non-nil in
999 doc-strings.
61d4b438
MR
1000 (Vrecenter_redisplay): Add first sentence of doc-string on
1001 separate line.
53524d93 1002 (Frecenter): Fix doc-string typo.
454592a6 1003
3633e3aa
KH
10042011-12-11 Kenichi Handa <handa@m17n.org>
1005
1006 * coding.c (Funencodable_char_position): Pay attention to the
1007 buffer text relocation (Bug#9389).
1008
7b9d523a
JD
10092011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1010
1011 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1012 gtk_init (Bug#10100).
1013
b73189c6
EZ
10142011-12-10 Eli Zaretskii <eliz@gnu.org>
1015
1016 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1017 IT->string is nil. (Bug#10263)
1018
f7dfe5d6
JD
10192011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1020
83faebb4
JD
1021 * nsterm.h (x_free_frame_resources): Declare.
1022
f7dfe5d6
JD
1023 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1024 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1025
1026 * nsterm.h (ns_get_defaults_value): Declare.
1027
1028 * nsterm.m (ns_default): Call ns_get_defaults_value.
1029
7cd4e72c
EZ
10302011-12-09 Eli Zaretskii <eliz@gnu.org>
1031
1032 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1033 (Bug#10170)
1034
b34d7317
YM
10352011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1036
1037 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1038 that where the value of an _OBJC_* symbol points to is in the .bss
1039 section (Bug#10240).
1040
76470ad1
KH
10412011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1042
1043 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1044 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1045
745fff94
KH
10462011-12-08 Kenichi Handa <handa@m17n.org>
1047
1048 * ftfont.c (get_adstyle_property): Fix previous change
1049 (Bug#10233).
1050
6e44397c
JB
10512011-12-07 Juanma Barranquero <lekktu@gmail.com>
1052
1053 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1054 dirs from the default value of EMACSLOADPATH (bug#10208).
1055
7efa6272
GM
10562011-12-07 Glenn Morris <rgm@gnu.org>
1057
1058 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1059 installation and source directories as well. (Bug#10208)
1060
f6fc4d87
CY
10612011-12-06 Chong Yidong <cyd@gnu.org>
1062
1063 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1064
2bf26180
GM
10652011-12-06 Glenn Morris <rgm@gnu.org>
1066
1067 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1068 as an error, not just -1. (Bug#10217)
1069
3a6ad4f0
CY
10702011-12-05 Chong Yidong <cyd@gnu.org>
1071
1072 * keyboard.c (process_special_events): New function.
1073 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1074
75a3b399
PE
10752011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 * coding.c (encode_designation_at_bol): Don't use uninitialized
1078 local variable (Bug#9318).
1079
c3c9e25e
KH
10802011-12-05 Kenichi Handa <handa@m17n.org>
1081
1082 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1083 return Qnil (Bug#8046, Bug#10193).
1084
5eb05ea3
KH
10852011-12-05 Kenichi Handa <handa@m17n.org>
1086
1087 * coding.c (encode_designation_at_bol): New args charbuf_end and
1088 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1089 (coding_set_source): Return how many bytes coding->source was
1090 relocated.
1091 (coding_set_destination): Return how many bytes
1092 coding->destination was relocated.
1093 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1094 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1095
10962011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1097
1098 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1099 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1100 macro (Bug#9318).
1101
11022011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1103
1104 The following changes are to fix Bug#9318.
1105
a79703f5 1106 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1107 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1108 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1109 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1110
7dbda6df
JB
11112011-12-05 Juanma Barranquero <lekktu@gmail.com>
1112
1113 * lisp.h (process_quit_flag): Fix external declaration.
1114
6d5eb5b0
SM
11152011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1116
1117 Don't macro-inline non-performance-critical code.
1118 * eval.c (process_quit_flag): New function.
1119 * lisp.h (QUIT): Use it.
1120
a0c3fad0
JD
11212011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1122
1123 * nsfns.m (get_geometry_from_preferences): New function.
1124 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1125
6c07aac2
AS
11262011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1127
1128 * emacs.c (Qkill_emacs): Define.
1129 (syms_of_emacs): Initialize it.
1130 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1131 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1132 (quit_throw_to_read_char): Add parameter `from_signal'.
1133 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1134 * lisp.h (QUIT): Call Fkill_emacs if requested.
1135
c052ead4
JD
11362011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1137
1138 * widget.c (update_wm_hints): Return if wmshell is null.
1139 (widget_update_wm_size_hints): New function.
1140
1141 * widget.h (widget_update_wm_size_hints): Declare.
1142
1143 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1144 widget_update_wm_size_hints (Bug#10104).
1145
9e49252b
EZ
11462011-12-03 Eli Zaretskii <eliz@gnu.org>
1147
1148 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1149 before a newline, prepare the bidi iterator for consuming the
1150 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1151 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1152
02b16839
JL
11532011-12-02 Juri Linkov <juri@jurta.org>
1154
1155 * search.c (Fword_search_regexp): New Lisp function created from
1156 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1157 (Fword_search_backward, Fword_search_forward)
1158 (Fword_search_backward_lax, Fword_search_forward_lax):
1159 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1160 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1161
0068070e
SM
11622011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1163
1164 * fileio.c (Finsert_file_contents): Move after-change-function call
1165 to before the "handled:" label, since all "goto handled" appear in
1166 cases where the *-change-functions have already been properly called
1167 (bug#10117).
1168
3360a3fc
AS
11692011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1170
1171 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1172 waiting for input. (Bug#10169)
1173
73d6c093
EZ
11742011-11-30 Eli Zaretskii <eliz@gnu.org>
1175
1176 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1177 verifies glyph row's hash code--we have just reallocated the
1178 glyphs, so their contents can be complete garbage. (Bug#10164)
1179
febe6bea
JB
11802011-11-30 Juanma Barranquero <lekktu@gmail.com>
1181
1182 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1183
801a4313
EZ
11842011-11-30 Eli Zaretskii <eliz@gnu.org>
1185
1186 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1187 attributes are tested _before_ calling verify_row_hash, to protect
1188 against GCC re-ordering of the tests. (Bug#10164)
1189
2b56b87e
JD
11902011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1191
1192 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1193
1194 * xterm.c (handle_one_xevent): Only set async_visible and friends
1195 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1196 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1197 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1198
dbf31225
PE
11992011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1202 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1203 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1204 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1205 All uses changed to use GCPRO1 etc.
1206 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1207 Revert to old implementation (i.e., before 2011-03-11).
1208
1305621b
YM
12092011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1210
1211 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1212 of scroll runs so as to avoid assigning disabled bogus rows and
1213 unnecessary graphics copy operations.
1214
8c9afb46
EZ
12152011-11-27 Eli Zaretskii <eliz@gnu.org>
1216
1217 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1218 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1219 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1220 (malloc, free, realloc, calloc): Redirect to e_* only when
1221 compiling Emacs.
1222
1223 * lisp.h (GCTYPEBITS): Move before first use.
1224 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1225 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1226 this macro definition.
1227
1228 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1229 _MSC_VER.
1230
54e9e3bf
JD
12312011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1232
6d5eb5b0
SM
1233 * gtkutil.c (xg_create_frame_widgets):
1234 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1235 present with Gtk+ 2.0.
1236
83aca1cb
PE
12372011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1238
1239 * fileio.c (Finsert_file_contents): Undo previous change; see
1240 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1241
5b76caa4
PE
12422011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1243
1244 Rename locals to avoid shadowing.
1245 * fileio.c (Finsert_file_contents):
1246 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1247 * process.c (wait_reading_process_output):
1248 Rename inner 'proc' to 'p' to avoid shadowing.
1249 Indent for consistency with usual Emacs style.
1250
8c535114
EZ
12512011-11-25 Eli Zaretskii <eliz@gnu.org>
1252
1253 * xdisp.c (redisplay_window): If cursor row is not fully visible
1254 after recentering, and scroll-conservatively is set to a large
1255 number, scroll window by a few more lines to make the cursor fully
1256 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1257 (start_display): Don't move to the next line if the display should
1258 start at a newline that is part of a display vector or an overlay
1259 string. (Bug#10119)
8c535114 1260
fa4fdb5c
JL
12612011-11-24 Juri Linkov <juri@jurta.org>
1262
1263 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1264 after the `MagickPingImage' call. (Bug#10112)
1265
90ec88df
CY
12662011-11-23 Chong Yidong <cyd@gnu.org>
1267
1268 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1269
56e2e794
MR
12702011-11-23 Martin Rudalics <rudalics@gmx.at>
1271
1272 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1273 making another buffer current. (Bug#10114)
1274
b6e64c41
GM
12752011-11-23 Glenn Morris <rgm@gnu.org>
1276
1277 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1278
6b21de18
CY
12792011-11-23 Chong Yidong <cyd@gnu.org>
1280
1281 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1282 using it (Bug#5984).
1283
b12cd789
EZ
12842011-11-22 Eli Zaretskii <eliz@gnu.org>
1285
1286 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1287 and header-lines, as they don't have one computed for them.
1288 (Bug#10098)
1289
1290 * .gdbinit (prow): Make displayed values more self-explaining.
1291 Add row's hash code.
1292
261b6fd4
LMI
12932011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1294
1295 * process.c (wait_reading_process_output): Fix asynchrounous
1296 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1297 (wait_reading_process_output): Add comment and URL.
261b6fd4 1298
e7cfd277
JD
12992011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1300
1301 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1302
a9b9b7f5
CY
13032011-11-21 Chong Yidong <cyd@gnu.org>
1304
1305 * window.c (Fnext_window, Fprevious_window): Doc fix.
1306
b0d15b4f
SM
13072011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1308
1309 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1310
fe7a3057
JB
13112011-11-20 Juanma Barranquero <lekktu@gmail.com>
1312
1313 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1314
d2999b1a
MR
13152011-11-20 Martin Rudalics <rudalics@gmx.at>
1316
1317 * window.c (Fset_window_combination_limit): Rename argument
1318 STATUS to LIMIT.
1319 (Vwindow_combination_limit): Remove "status" from doc-string.
1320
d5ff9cd0
AS
13212011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1322
1323 * m/ibms390.h: Remove.
1324 * m/ibms390x.h: Don't include "ibms390.h".
1325
a5bb9bd3
SM
13262011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1327
1328 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1329 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1330
cd1181db
JB
13312011-11-20 Juanma Barranquero <lekktu@gmail.com>
1332
1333 * casetab.c (Fset_case_table):
1334 * charset.c (Fcharset_after): Fix typos.
1335
615a3b8d 13362011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1337
17e845af
PE
1338 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1339 Otherwise, valgrind does not work on some platforms.
1340 Problem reported by Andreas Schwab in
6a0bf43d
PE
1341 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1342 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1343 is set, removing the need for VIRT_ADDRESS_VARIES.
1344 (PURE_P): Use a more-efficient implementation that needs just one
1345 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1346 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1347 to 4 (xorl, subq, cmpq, setbe).
1348 * alloc.c (pure): Always extern now, since that's the
1349 VIRT_ADDR_VARIES behavior.
1350 (PURE_POINTER_P): Use a single comparison, not two, for
1351 consistency with the new puresize.h.
1352 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1353 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1354 Remove VIRT_ADDR_VARIES no longer needed.
1355
f8fe6f96
EZ
13562011-11-19 Eli Zaretskii <eliz@gnu.org>
1357
1358 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1359 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1360 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1361 behave as if the cursor position were at the window margin.
1362
1363 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1364 and the cursor position is out of bounds, behave as if the cursor
1365 position were at the window margin. (Bug#10075)
1366
df05a53c
CY
13672011-11-18 Chong Yidong <cyd@gnu.org>
1368
1369 * window.c (Fwindow_combination_limit): Make first argument
1370 non-optional, since it is meaningless for live windows like the
1371 selected window.
1372
2071918e
DA
13732011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1374
1375 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1376
b50a28de
SM
13772011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1378
1379 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1380 (graft_intervals_into_buffer): Simplify.
1381
015137db
EZ
13822011-11-18 Eli Zaretskii <eliz@gnu.org>
1383
1384 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1385 hash values of the two rows.
1386 (copy_row_except_pointers): Preserve the used[] arrays and the
1387 hash values of the two rows. (Bug#10035)
68c95424 1388 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1389
1390 * xdisp.c (row_hash): New function, body extracted from
1391 compute_line_metrics.
1392 (compute_line_metrics): Call row_hash, instead of computing the
1393 hash code inline.
1394
1395 * dispnew.c (verify_row_hash): Call row_hash for computing the
1396 hash code of a row, instead of duplicating code from xdisp.c.
1397
1398 * dispextern.h (row_hash): Add prototype.
1399
a2addb04
TH
14002011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1401
1402 * frame.c (delete_frame): Don't delete the terminal when the last
1403 X frame is closed if emacs is built with GTK toolkit.
1404
df85d315
JB
14052011-11-17 Juanma Barranquero <lekktu@gmail.com>
1406
1407 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1408
a0c2d0ae
MR
14092011-11-17 Martin Rudalics <rudalics@gmx.at>
1410
1411 * window.c (Vwindow_splits): Rename to
1412 Vwindow_combination_resize. Suggested by Juri Linkov.
1413 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1414 of Vwindow_splits.
1415
58179cce
JB
14162011-11-16 Juanma Barranquero <lekktu@gmail.com>
1417
7877f373
JB
1418 * nsfns.m (Fns_font_name):
1419 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1420
b6f67890
MR
14212011-11-16 Martin Rudalics <rudalics@gmx.at>
1422
1423 * window.h (window): Rename slot "nest" to "combination_limit".
1424 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1425 (Fset_window_nest): Rename to Fset_window_combination_limit.
1426 (Vwindow_nest): Rename to Vwindow_combination_limit.
1427 (recombine_windows, make_parent_window, make_window)
1428 (Fsplit_window_internal, saved_window)
1429 (Fset_window_configuration, save_window_save): Rename all
1430 occurrences of window_nest to window_combination_limit.
1431
c7015153
JB
14322011-11-15 Juanma Barranquero <lekktu@gmail.com>
1433
1434 * image.c (imagemagick_load_image): Fix typo.
1435
322ad6ec
EZ
14362011-11-14 Eli Zaretskii <eliz@gnu.org>
1437
1438 * xdisp.c (display_line): Move the call to
1439 highlight_trailing_whitespace before the call to
1440 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1441 faces of all the glyphs to compute ROW's hash value.
1442 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1443
f067b8ec
JB
14442011-11-14 Juanma Barranquero <lekktu@gmail.com>
1445
1446 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1447 just return (bug#10044).
1448
1e5b2111
EZ
14492011-11-12 Eli Zaretskii <eliz@gnu.org>
1450
7ef3cbd5
EZ
1451 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1452 with user-defined heap size. Bump the default size of the temacs
1453 heap to 27MB, to avoid memory warning when running temacs.
1454 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1455
1e5b2111
EZ
1456 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1457 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1458 (verify_row_hash) [XASSERTS]: New function.
1459 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1460 that the hash value of glyph rows is correct.
1e5b2111 1461
89d61221
MR
14622011-11-12 Martin Rudalics <rudalics@gmx.at>
1463
1464 * window.h (window): Remove splits slot.
1465 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1466 (Fdelete_other_windows_internal, make_parent_window)
1467 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1468 (Fset_window_configuration, save_window_save): Don't deal with
1469 split status of windows.
1470 (saved_window): Remove splits slot.
1471 (Vwindow_splits): Rewrite doc-string.
1472
97f18cc8
JD
14732011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1474
1475 * xfns.c (unwind_create_frame):
1476 * nsfns.m (unwind_create_frame):
1477 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1478 Vframe_list (Bug#9999).
1479
22a648b4
DA
14802011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1481
0b381c7e 1482 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1483
659afede
KH
14842011-11-11 Kenichi Handa <handa@m17n.org>
1485
1486 * callproc.c (Fcall_process): Set the member dst_multibyte of
1487 process_coding.
1488
9ac0394b
KH
14892011-11-11 Johan Bockgård <bojohan@gnu.org>
1490
1491 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1492 avoid a crash (bug#9496).
1493
2fbdc249
CY
14942011-11-09 Chong Yidong <cyd@gnu.org>
1495
1496 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1497 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1498
ac6b1f81
PE
14992011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1500
1501 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1502
09db192c
PE
15032011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1504
1505 Avoid some portability problems by eschewing 'extern inline' functions.
1506 The trivial performance wins aren't worth the portability hassles; see
1507 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1508 et seq.
1509 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1510 (window_box_width, window_box_left, window_box_left_offset)
1511 (window_box_right, window_box_right_offset): Undo previous change,
1512 by removing the "extern"s.
1513 * intervals.c (adjust_intervals_for_insertion)
1514 (adjust_intervals_for_deletion): Undo previous change,
1515 making these static again.
1516 (offset_intervals, temp_set_point_both, temp_set_point)
1517 (copy_intervals_to_string): No longer inline.
1518 * xdisp.c (window_text_bottom_y, window_box_width)
1519 (window_box_height, window_box_left_offset)
1520 (window_box_right_offset, window_box_left, window_box_right)
1521 (window_box): No longer inline.
1522
105216ed
CY
15232011-11-08 Chong Yidong <cyd@gnu.org>
1524
1525 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1526 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1527 Signal an error if not a live window.
105216ed
CY
1528 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1529 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1530
ae9e237f
JB
15312011-11-07 Juanma Barranquero <lekktu@gmail.com>
1532
1533 * lisp.h (syms_of_abbrev): Remove declaration.
1534 Reported by CHENG Gao <chenggao@royau.me>.
1535
c7aa8333
EZ
15362011-11-07 Eli Zaretskii <eliz@gnu.org>
1537
1538 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1539 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1540 of temacs in GUI mode.
1541
be7f5545
MR
15422011-11-07 Martin Rudalics <rudalics@gmx.at>
1543
1544 * window.h: Declare delete_all_child_windows instead of
1545 delete_all_subwindows.
1546 * window.c (Fwindow_nest, Fset_window_nest)
1547 (Fset_window_new_total, Fset_window_new_normal)
1548 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1549 (delete_all_subwindows): Rename to delete_all_child_windows.
1550 (Fdelete_other_windows_internal, Fset_window_configuration):
1551 Call delete_all_child_windows instead of delete_all_subwindows.
1552 * frame.c (delete_frame): Call delete_all_child_windows instead
1553 of delete_all_subwindows.
1554
ca78dc43
PE
15552011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1556
1557 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1558 This is also needed for porting to any host where GC_MARK_STACK is
1559 not GC_MAKE_GCPROS_NOOPS.
1560 (which_symbols): Use it.
1561
a0241d01
KH
15622011-11-07 Kenichi Handa <handa@m17n.org>
1563
1564 * coding.c (coding_set_destination): Check coding->src_pos only
1565 when coding->src_object is a buffer (bug#9910).
1566
1567 * process.c (send_process): Set the member src_multibyte of coding
1568 to 0 (bug#9911) when sending a unibyte text.
1569
1570 * callproc.c (Fcall_process): Set the member src_multibyte of
1571 process_coding to 0 (bug#9912).
1572
a64bfdfa 15732011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1574
1575 * xmenu.c (cleanup_widget_value_tree): New function.
1576 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1577 calling free_menubar_widget_value_tree directly (Bug#9830).
1578
cb41b32a
PE
15792011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1580
1581 Fix some portability problems with 'inline'.
1582 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1583 (window_box_width, window_box_left, window_box_left_offset)
1584 (window_box_right, window_box_right_offset): Declare extern.
1585 Otherwise, these inline functions do not conform to C99 and
1586 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1587 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1588 * intervals.c (adjust_intervals_for_insertion)
1589 (adjust_intervals_for_deletion): Now extern, because otherwise the
1590 extern inline functions 'offset_intervals' couldn't refer to it.
1591 (static_offset_intervals): Remove.
1592 (offset_intervals): Rewrite using the old contents of
1593 static_offset_intervals. The old version didn't conform to C99
1594 because an extern inline function contained a reference to an
1595 identifier with static linkage.
1596
b7041366
AS
15972011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1598
1599 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1600 GC.
1601
88a37c4d
EZ
16022011-11-06 Eli Zaretskii <eliz@gnu.org>
1603
1604 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1605 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1606 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1607 return Qleft_to_right.
1608
49745b39
CY
16092011-11-06 Chong Yidong <cyd@gnu.org>
1610
1611 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1612 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1613 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1614 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1615 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1616 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1617 (Fwindow_vscroll): Doc fix.
1618 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1619 argument, since it makes no sense to pass a live window and for
1620 consistency with window-child.
1621
1f05cd82
CS
16222011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1623
1624 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1625 support MSVC.
1626
22610910
JR
16272011-11-05 Jason Rumney <jasonr@gnu.org>
1628
1629 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1630 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1631 fonts (Bug#6029).
1632 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1633 bitwise arithmetic preventing use of unicode-sip and non-truetype
1634 opentype fonts.
1635
a06776b2
EZ
16362011-11-05 Eli Zaretskii <eliz@gnu.org>
1637
3ad924ba
EZ
1638 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1639 "emacs"-only part.
1640
a06776b2
EZ
1641 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1642 initialization code to keep similarity to xfns.c after changes
1643 from 2011-11-05.
1644
c9e7db78
JD
16452011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1646
a97f8f3f
JD
1647 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1648 (unwind_create_frame): New function (Bug#9943).
1649 (Fx_create_frame): Restructure code to be more similar to the one in
1650 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1651 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1652 Move terminal->reference_count++ just before making the frame official
1653 (Bug#9943).
1654
1655 * nsterm.m (x_free_frame_resources): New function.
1656 (x_destroy_window): Move code to x_free_frame_resources.
1657
c9e7db78 1658 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1659 (Fx_create_frame, x_create_tip_frame):
1660 Move terminal->reference_count++ just before making the frame
75f1671a 1661 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1662 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1663
a6fc3b5c
EZ
16642011-11-05 Eli Zaretskii <eliz@gnu.org>
1665
1666 Support MSVC build with newer versions of Visual Studio.
1667 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1668 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1669 nt/gmake.defs.
1670
1671 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1672 which are not supported by MSVC.
1673 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1674 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1675 bitfields.
1676 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1677 types in bitfields.
1678 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1679
1680 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1681
58179cce 16822011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1683
1684 Support MSVC build with newer versions of Visual Studio.
1685 * w32.c: Don't include w32api.h for MSVC.
1686 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1687
1688 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1689 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1690 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1691 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1692 e_* cousins.
1693 (alloca) [_MSC_VER]: Define to _alloca.
1694
1695 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1696
1697 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1698
a58c13ed
EZ
16992011-11-04 Eli Zaretskii <eliz@gnu.org>
1700
1701 * xdisp.c (note_mouse_highlight): If either of
1702 previous/next-single-property-change returns nil, treat that as
1703 the beginning or the end of the buffer. (Bug#9955)
1704
fe0b6370
JD
17052011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1706
a58c13ed 1707 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1708 label is not null (Bug#9951).
1709 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1710 may be NULL.
1711
89bd5ee1
EZ
17122011-11-04 Eli Zaretskii <eliz@gnu.org>
1713
1714 * window.c (Fwindow_body_size): Mention in the doc string that the
1715 return value is in frame's canonical units. (Bug#9949)
1716
84c3edb9
EZ
17172011-11-03 Eli Zaretskii <eliz@gnu.org>
1718
4e2fb5c7
EZ
1719 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1720
84c3edb9 1721 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1722 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1723 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1724
bc17a887
EZ
17252011-11-01 Eli Zaretskii <eliz@gnu.org>
1726
1727 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1728 Don't stop backward scan on the continuation glyph, even though
1729 its CHARPOS is positive.
6d5eb5b0
SM
1730 (mouse_face_from_buffer_pos, note_mouse_highlight):
1731 Rename cover_string to disp_string.
bc17a887 1732
4ee88440
MR
17332011-11-01 Martin Rudalics <rudalics@gmx.at>
1734
1735 * window.c (temp_output_buffer_show): Don't use
1736 Vtemp_buffer_show_specifiers.
1737 (Vtemp_buffer_show_specifiers): Remove unused variable.
1738
c2ff3c02
EZ
17392011-10-30 Eli Zaretskii <eliz@gnu.org>
1740
1741 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1742 past the beginning of the current glyph matrix.
1743
58179cce 17442011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1745
1746 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1747 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1748 HAVE_GTK3 (Bug#9869).
b77a6a7f 1749
3b574623
JD
1750 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1751 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1752
b77a6a7f
JD
1753 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1754
1755 * xterm.c: Declare x_handle_net_wm_state to return int.
1756 (handle_one_xevent): Check if we are iconified but don't have
1757 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1758 (get_current_wm_state): Return non-zero if not hidden,
1759 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1760 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1761 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1762 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1763
196e41e4
PE
17642011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1765
1766 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1767 so that this new function doesn't get optimized away by a
1768 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1769
021f2e1a
AS
17702011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1771
1772 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1773
8b058d44
EZ
17742011-10-29 Eli Zaretskii <eliz@gnu.org>
1775
1776 Fix the `xbytecode' command.
1777 * .gdbinit (xprintbytestr): New command.
b50a28de 1778 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1779 (xbytecode): Print the byte-code string as well.
1780
4452fb80
EZ
17812011-10-29 Kim Storm <storm@cua.dk>
1782
8b058d44
EZ
1783 * alloc.c (which_symbols): New function.
1784
21b72067
AS
17852011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1786
1787 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1788 line. (Bug#9903)
1789
83ed7b5c
GM
17902011-10-29 Glenn Morris <rgm@gnu.org>
1791
1792 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1793 Not clear what it was for, and it causes various bugs. (Bug#9839)
1794
5a7a728b
EZ
17952011-10-28 Eli Zaretskii <eliz@gnu.org>
1796
1797 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1798 possible random value that matches one of those tested as
1799 condition to clear the mouse face.
1800
d3d0842f
CY
18012011-10-28 Chong Yidong <cyd@gnu.org>
1802
1803 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1804
31b39d13
DN
18052011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1806
1807 * window.c (make_window): Initialize phys_cursor_on_p.
1808
9aba6043
SM
18092011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1810
1811 * lisp.h (struct Lisp_Symbol): Update comments.
1812
c20992f4
JB
18132011-10-28 Juanma Barranquero <lekktu@gmail.com>
1814
1815 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1816
db4f02f2
EZ
18172011-10-28 Eli Zaretskii <eliz@gnu.org>
1818
1819 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1820 <oslsachem@gmail.com> for helping to debug this.
1821
1822 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1823 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1824 (g_b_init_get_glyph_outline_w): New static variables.
1825 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1826 (GetGlyphOutlineW_Proc): New typedefs.
1827 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1828 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1829 New functions.
1830 (w32font_open_internal, compute_metrics):
1831 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1832 instead of calling the "wide" APIs directly.
1833
1834 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1835
1836 * w32.h (syms_of_w32font): Add prototype.
1837
87e68db4
JB
18382011-10-27 Juanma Barranquero <lekktu@gmail.com>
1839
1840 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1841 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1842 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1843 (Fmove_to_window_line): Doc fix.
1844
435c1d67
CY
18452011-10-27 Chong Yidong <cyd@gnu.org>
1846
1847 * process.c (make_process): Set gnutls_state to NULL.
1848
1849 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1850 non-NULL, regardless of GNUTLS_INITSTAGE.
1851 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1852 an error. Set process slots as soon as we allocate them.
1853
1854 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1855
9c6c6f49
CY
18562011-10-27 Chong Yidong <cyd@gnu.org>
1857
9aba6043
SM
1858 * gnutls.c (emacs_gnutls_deinit): New function.
1859 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1860 (Fgnutls_deinit, Fgnutls_boot): Use it.
1861
1862 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1863 (deactivate_process): Call emacs_gnutls_deinit.
1864
657d08d3
JB
18652011-10-27 Juanma Barranquero <lekktu@gmail.com>
1866
1867 * image.c (x_create_x_image_and_pixmap):
1868 * w32.c (sys_rename, w32_delayed_load):
1869 * w32font.c (fill_in_logfont):
1870 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1871
5430d399
JB
18722011-10-26 Juanma Barranquero <lekktu@gmail.com>
1873
1874 * w32fns.c (w32_default_color_map): New function,
1875 extracted from Fw32_default_color_map.
a7ef684b 1876 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1877
fe0055fa
PE
18782011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1879
1880 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1881
e6346438
SM
18822011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1883
1884 * keyboard.c (test_undefined): New function (bug#9751).
1885 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1886
e112cc37
ET
18872011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1888
1889 * sysdep.c (init_sys_modes): Fix the check for the controlling
1890 terminal (Bug#6649).
1891
7b5d6677
EZ
18922011-10-20 Eli Zaretskii <eliz@gnu.org>
1893
1894 * dispextern.h (struct bidi_it): New member next_en_type.
1895
1896 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1897 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1898 current character, check also for next_en_type being WEAK_EN.
1899 (bidi_resolve_weak): Don't enter the expensive loop if the current
1900 position is before next_en_pos. Record the bidi type of the first
1901 non-ET, non-BN character we find, in addition to its position.
1902 (bidi_level_of_next_char): Invalidate next_en_type when
1903 next_en_pos is over-stepped.
1904
7da0b018
PE
19052011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1906
1907 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1908 * editfns.c: Rewrite current-time-zone so that it invokes
1909 the equivalent of (format-time-string "%Z") to get the time zone name.
1910 This fixes a bug when the time zone name contains characters that
1911 need converting from the system time locale to Emacs internal format.
1912 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1913 that patch fixed format-time-string to do the conversion, but
1914 I forgot to fix current-time-zone.
1915 (format_time_string): New function, containing most of
1916 what Fformat_time_string used to contain.
1917 (Fformat_time_string): Rewrite in terms of format_time_string.
1918 This doesn't change this function's behavior.
1919 (current-time-zone): Rewrite to use format_time_string.
1920 This fixes the bug reported by Michael Schierl in
1921 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1922 Jason Rumney's 2007-06-07 change worked around this bug, but
1923 didn't fix it.
1924 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1925
8547b010
EZ
19262011-10-19 Eli Zaretskii <eliz@gnu.org>
1927
1928 * xdisp.c (start_display): If the character at POS is displayed
1929 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1930 (try_window_reusing_current_matrix): If a line ends in a display
1931 vector or the next line starts in a display vector, continue
1932 redrawing the window even though the character position of
1933 start_row was reached.
8547b010
EZ
1934 (Bug#9771, part 2)
1935
4e948d15
CY
19362011-10-18 Chong Yidong <cyd@gnu.org>
1937
1938 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1939 with nobreak-char-display too.
1940
4787455f
EZ
19412011-10-18 Eli Zaretskii <eliz@gnu.org>
1942
1943 Fix part 3 of bug#9771.
1944 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1945 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1946 non-neutral characters if the current character is a paragraph
1947 separator (a.k.a. Newline). This avoids running the same
1948 expensive loop twice, once when we consume the preceding newline
1949 and the other time when the line actually needs to be displayed.
1950 Avoid the loop when we see neutrals on the base embedding level
1951 following a character whose directionality is the same as the
1952 paragraph's. This avoids running the expensive loop when a line
1953 ends in a long sequence of neutrals, like control characters.
1954 Add assertion against STRONG_AL type. Slightly rearrange code
1955 that determines the type of a neutral given the first non-neutral
1956 that follows it.
1957 (bidi_level_of_next_char): Set next_en_pos to zero when
1958 invalidating its info.
1959
2c91f553
EZ
19602011-10-17 Eli Zaretskii <eliz@gnu.org>
1961
1962 * xdisp.c (push_display_prop): Determine whether to record string
1963 or buffer position by IT->string, not by IT->method. Allow
1964 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1965 (move_it_vertically_backward): Don't look for character position
1966 immediately after the newline when in a continuation line.
1967 (Bug#9771, part 1)
2c91f553 1968
c7b08b0d
MR
19692011-10-15 Martin Rudalics <rudalics@gmx.at>
1970
1971 * window.c (coordinates_in_window): Rewrite and delabelize
1972 vertical border check. (Bug#5357) (Bug#9618)
1973
6b02f655
SM
19742011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1975
1976 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1977 errors in XSetWindowBorder (bug#9310).
1978
81d40c92
DA
19792011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1980
1981 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1982 avoid crash when xmalloc overrun checking is enabled.
1983
d4172c3b
EZ
19842011-10-13 Eli Zaretskii <eliz@gnu.org>
1985
1986 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1987 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1988 cursor motion with <left> and <right> arrow keys.
1989
1990 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1991 some callers set that themselves.
1992
b00eea75
EZ
19932011-10-12 Eli Zaretskii <eliz@gnu.org>
1994
1995 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1996 display string and the previous row comes from the same string and
1997 is empty. (Bug#9739) (Bug#9738)
1998
8fe012c4
SM
19992011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2000
2001 * doc.c (get_doc_string): Encode file name (bug#9735).
2002
0074aef2
EZ
20032011-10-12 Eli Zaretskii <eliz@gnu.org>
2004
79beb178
EZ
2005 * bidi.c (bidi_level_of_next_char):
2006 * xdisp.c (get_visually_first_element): Remove old incorrect
2007 comments regarding the Unicode Line Separator character.
2008
0074aef2
EZ
2009 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2010
6e4b3fbe
DA
20112011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2012
2013 * alloc.c (Fgc_status): Do not access beyond zombies array
2014 boundary if nzombies > MAX_ZOMBIES.
2015 * alloc.c (dump_zombies): Add missing format specifier.
2016
0324f3af
PE
20172011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2018
b5525cac
PE
2019 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2020 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2021
0324f3af
PE
2022 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2023 Some packages use them to denote characters with modifiers.
2024
e9b5f888
AS
20252011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2026
2027 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2028 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2029 matching a pp-number. Rename parameter var to var1.
2030
127827c0
SM
20312011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2032
2033 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2034
c8fd3bd0
GM
20352011-10-08 Glenn Morris <rgm@gnu.org>
2036
2037 * callint.c (Fcall_interactively): Give a more explicit error for the
2038 'c' case with a non-character input. (Bug#8479)
2039
352ec8ff
EZ
20402011-10-08 Eli Zaretskii <eliz@gnu.org>
2041
03669ccb
EZ
2042 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2043 lines.
7061c986
EZ
2044 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2045 lines that are hscrolled on the left.
03669ccb 2046
352ec8ff
EZ
2047 * dispnew.c (buffer_posn_from_coords): Account for a possible
2048 presence of header-line. (Bug#4426)
2049
a66cfb1c
SM
20502011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2051
6b02f655
SM
2052 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2053 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2054
7c5ee88e
PE
20552011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2056
2057 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2058 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2059 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2060 this makes Emacs dump core during garbage collection on rare
2061 occasions. sizeof is obviously inferior to offsetof here, so
2062 stick with offsetof.
2063 (GC_POINTER_ALIGNMENT): New macro.
2064 (mark_memory): Omit 3rd (offset) arg; caller changed.
2065 Don't assume EMACS_INT alignment is the same as pointer alignment.
2066
df1bbe5b
SM
20672011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2068
2069 * keyboard.c (read_key_sequence_remapped): New var.
2070 (read_key_sequence): Compute remapping in the right buffer.
2071 (command_loop_1): Use read_key_sequence's remapping directly.
2072
51553db6
SM
20732011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2074
32c1fffd
SM
2075 * dired.c (file_name_completion): Don't expand file name.
2076 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2077 before checking file name handler.
2078
51553db6
SM
2079 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2080 they've been requested explicitly (bug#9591).
2081
b6bd1599 20822011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2083
2084 * keymap.c (Fsingle_key_description): Use make_specified_string
2085 instead of build_string to build string from push_key_description.
2086 (Bug#5193)
2087
f701dc2a
PE
20882011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2089
4222c55d
PE
2090 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2091 This fixes a Y2038 bug on 64-bit hosts.
2092 * buffer.c (reset_buffer):
2093 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2094 (Fclear_buffer_auto_save_failure):
2095 Use 0, not -1, to represent an unset failure time, since time_t
2096 might not be signed.
2097
f701dc2a
PE
2098 Remove dependency on glibc malloc internals.
2099 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2100 Move back here from lisp.h, but with their new implementations.
2101 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2102 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2103 * charset.c (charset_table_init): New static var.
2104 (syms_of_charset): Use it instead of xmalloc. This removes a
2105 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2106 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2107 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2108 Move back to alloc.c.
2109 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2110 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2111
9ceebf39
JD
21122011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2113
2114 * nsterm.m (windowDidResize): Call x_set_window_size only when
2115 ns_in_resize is true. Otherwise set pixelwidth/height and
2116 call change_frame_size (Bug#9628).
2117
cb993c58
PE
21182011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2119
3930c88b
PE
2120 Port --enable-checking=all to Fedora 14 x86-64.
2121 * charset.c (syms_of_charset): Also account for glibc malloc's
2122 internal overhead when calculating the initial malloc maximum.
2123
cb993c58
PE
2124 Port --enable-checking=all to Fedora 14 x86.
2125 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2126 Move to lisp.h.
2127 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2128 (overrun_check_realloc, overrun_check_free):
2129 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2130 That way, xmalloc returns a properly-aligned pointer even if
2131 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2132 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2133 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2134 into account when calculating the initial malloc maximum.
2135 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2136 Move here from alloc.c, so that charset.c can use it too.
2137 Properly align; the old code wasn't right for common 32-bit hosts
2138 when configured with --enable-checking=all.
2139 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2140 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2141
31bed486
EZ
21422011-09-29 Eli Zaretskii <eliz@gnu.org>
2143
04c70788 2144 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2145 use EDOM.
2146
fbcaa2f3
EZ
21472011-09-28 Eli Zaretskii <eliz@gnu.org>
2148
2149 * xdisp.c (compute_display_string_end): If there's no display
2150 string at CHARPOS, return -1.
2151
2152 * bidi.c (bidi_fetch_char): When compute_display_string_end
2153 returns a negative value, treat the character as a normal
2154 character not covered by a display string. (Bug#9624)
2155
a239d4e9
JB
21562011-09-28 Juanma Barranquero <lekktu@gmail.com>
2157
2158 * lread.c (Fread_from_string): Fix typo in docstring.
2159
88652fd5
EZ
21602011-09-27 Eli Zaretskii <eliz@gnu.org>
2161
2162 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2163 newline, reseat the iterator instead of bidi-iterating there one
2164 character at a time. (Bug#9610)
32c1fffd
SM
2165 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2166 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2167
ed497dd4
AS
21682011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2169
2170 * lread.c (readevalloop): Use correct code for NBSP.
2171 (read1): Likewise. (Bug#9608)
2172
b2bf61aa
MA
21732011-09-25 Michael Albinus <michael.albinus@gmx.de>
2174
2175 * dbusbind.c (Fdbus_register_signal): When service is not
2176 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2177
32bbb17c
GM
21782011-09-25 Glenn Morris <rgm@gnu.org>
2179
2180 * buffer.c (truncate-lines): Doc fix.
2181
94e0933e
CY
21822011-09-24 Chong Yidong <cyd@stupidchicken.com>
2183
2184 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2185 (Fset_window_next_buffers): Doc fix.
2186
cddde921
GM
21872011-09-24 Glenn Morris <rgm@gnu.org>
2188
2189 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2190
1260aef1
PE
21912011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2192
25b4bfa0
PE
2193 Fix minor problems found by static checking.
2194 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2195 * indent.c (Fvertical_motion): Fix == vs = typo.
2196
e3cbd34b
EZ
21972011-09-24 Eli Zaretskii <eliz@gnu.org>
2198
a66cfb1c
SM
2199 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2200 Default value is now t. Doc fix.
6bf7006f 2201
e3cbd34b 2202 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2203 logic when moving up, not only when moving down. Fix the
e3cbd34b 2204 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2205 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2206
2207 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2208 CHARPOS is covered by a display string which includes newlines.
2209 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2210 is covered by a display string with embedded newlines.
2211
a3de0cbd
MA
22122011-09-24 Michael Albinus <michael.albinus@gmx.de>
2213
2214 * dbusbind.c (Fdbus_register_signal): Add match rule to
2215 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2216 (Fdbus_register_method, Vdbus_registered_objects_table):
2217 Fix docstring.
a3de0cbd 2218
b260039d
JM
22192011-09-24 Jim Meyering <meyering@redhat.com>
2220
32c1fffd 2221 do not ignore write error for any output size
b260039d
JM
2222 The previous change was incomplete.
2223 While it makes emacs --batch detect the vast majority of stdout
2224 write failures, errors were still ignored whenever the output size is
2225 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2226 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2227 && echo FAIL: ignored write error
2228 FAIL: ignored write error
2229 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2230 && echo FAIL: ignored write error
2231 FAIL: ignored write error
2232 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2233
8eca8a7c
AS
22342011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2235
2236 * emacs.c (Fkill_emacs): In noninteractive mode exit
2237 non-successfully if a write error occurred on stdout. (Bug#9574)
2238
3341db62
EZ
22392011-09-21 Eli Zaretskii <eliz@gnu.org>
2240
2241 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2242 the xassert test.
2243
2244 * dispextern.h (struct it): Update the comment documenting what
2245 can it->OBJECT be.
2246
8c203dbf
EZ
22472011-09-20 Eli Zaretskii <eliz@gnu.org>
2248
2249 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2250 a display string, extend search for cursor position to end of row.
2251 (find_row_edges): If the row ends in a newline from a display
2252 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2253 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2254 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2255 non-empty line. Fixes confusing cursor motion with arrow keys at
2256 the beginning of a line that starts with whitespace.
8c203dbf 2257
a4824228
LMI
22582011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2259
2260 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2261 (bug#9493).
2262
33ed493b
CY
22632011-09-18 Chong Yidong <cyd@stupidchicken.com>
2264
2265 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2266 boolean (Bug#9154).
2267
56cd55c8
EZ
22682011-09-18 Eli Zaretskii <eliz@gnu.org>
2269
2270 * xdisp.c (display_line): Record maximum and minimum buffer
2271 positions even if no glyphs were produced (e.g., by a zero-width
2272 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2273 buffer positions that will be removed from the glyph row because
2274 they don't fit.
c02dcedf
EZ
2275 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2276 column is beyond frame width: don't subtract 1 "pixel" when
2277 computing width of the stretch.
3e62b7e0
EZ
2278 (reseat_at_next_visible_line_start): Undo the change made on
2279 2011-09-17 that saved paragraph information and restored it after
2280 the call to `reseat'. (Bug#9545)
56cd55c8 2281
5ed99d36 22822011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2283
2284 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2285 and turn window cursor on if cleared (Bug#9415).
2286
5ed99d36 22872011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2288
2289 * search.c (boyer_moore): Take unibyte characters from pattern
2290 literally. (Bug#9458)
2291
9bade7b2
EZ
22922011-09-18 Eli Zaretskii <eliz@gnu.org>
2293
2294 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2295
e5e9d610
PE
22962011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2297
87e4427a
PE
2298 Fix minor problem found by static checking.
2299 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2300 initialized, to pacify gcc -Wuninitialized.
2301
e5e9d610
PE
2302 * fileio.c: Report proper errno when syscall falls.
2303 (Finsert_file_contents): Save and restore errno,
2304 so that report_file_error outputs the correct diagnostic.
2305 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2306
a1674f0b
EZ
23072011-09-18 Eli Zaretskii <eliz@gnu.org>
2308
2309 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2310
fbfb6dd4
EZ
23112011-09-17 Eli Zaretskii <eliz@gnu.org>
2312
2313 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2314 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2315
bb187662
EZ
23162011-09-17 Eli Zaretskii <eliz@gnu.org>
2317
1137e8b8 2318 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2319 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2320
2321 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2322 (bidi_find_paragraph_start): Search back for paragraph beginning
2323 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2324 (bidi_move_to_visually_next): Only trigger paragraph-related
2325 computations when the last character is a newline or at EOB, not
2326 just any NEUTRAL_B. (Bug#9470)
2327
bb187662
EZ
2328 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2329 truncated lines if point is covered by a display string. (Bug#9524)
2330
2e621251
PE
23312011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2332
2333 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2334 (cons_to_x_long): New function.
2335 (lisp_data_to_selection_data): Use it. Correct the test for
2336 short-versus-long data; it was negated. Break out of vector
2337 loop, for efficiency, when a long datum is discovered.
2338
91a15bc6
SM
23392011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2340
2341 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2342
b41c3a35
EZ
23432011-09-16 Eli Zaretskii <eliz@gnu.org>
2344
2345 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2346 GCC PR/17406) by declaring this function with external scope.
2347
7812ba2d
PE
23482011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2349
2350 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2351 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2352
cf7edc2a
AS
23532011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2354
2355 * editfns.c (Fformat): Correctly handle text properties on "%%".
2356
bd01620e
EZ
23572011-09-15 Eli Zaretskii <eliz@gnu.org>
2358
2359 * xterm.c (x_draw_composite_glyph_string_foreground):
2360 * w32term.c (x_draw_composite_glyph_string_foreground):
2361 * term.c (encode_terminal_code):
2362 * composite.c (composition_update_it, get_composition_id):
2363 * xdisp.c (get_next_display_element)
2364 (fill_composite_glyph_string): Add comments about special meaning
2365 of TAB characters in a composition.
2366
a02719a3
PE
23672011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2368
2369 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2370 This occurs when processing a multibyte format.
2371 Problem reported by Wolfgang Jenker.
a02719a3 2372
72589a3c
JB
23732011-09-15 Johan Bockgård <bojohan@gnu.org>
2374
2375 * xdisp.c (try_cursor_movement): Only check for exact match if
2376 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2377
1c14176c
PE
23782011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 Remove unused external symbols.
2381 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2382 * xdisp.c (calc_pixel_width_or_height): Now static.
2383 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2384 * indent.c (check_display_width):
2385 * w32term.c: Fix comment to match code.
2386 * xterm.c, xterm.h (x_catching_errors): Remove.
2387
d2eea5b5
PE
23882011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2389
2390 * xselect.c: Use signed conversions more consistently (Bug#9498).
2391 (selection_data_to_lisp_data): Assume incoming selection data are
2392 signed integers, not unsigned. This is to be consistent with
2393 outgoing selection data, which was modified to use signed integers
2394 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2395 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2396 expects long, not unsigned long.
2397
46888499
EZ
23982011-09-14 Eli Zaretskii <eliz@gnu.org>
2399
2400 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2401 computation of loop end. Reported by Johan Bockgård
2402 <bojohan@gnu.org>.
2403
ef8ef9fb
CY
24042011-09-13 Chong Yidong <cyd@stupidchicken.com>
2405
2406 * frame.c (Fother_visible_frames_p): Function deleted.
2407
fa819fed
EZ
24082011-09-12 Eli Zaretskii <eliz@gnu.org>
2409
2410 * indent.c (compute_motion): Process display vector front to back
2411 rather than the other way around. (Bug#2496)
2412
2ba8e008
SM
24132011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2414
2415 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2416
20f53c69
CY
24172011-09-11 Chong Yidong <cyd@stupidchicken.com>
2418
2419 * minibuf.c (Fread_from_minibuffer): Doc fix.
2420
d562d7a4
EZ
24212011-09-11 Eli Zaretskii <eliz@gnu.org>
2422
2423 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2424 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2425
1c4d7f3d
LMI
24262011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2427
2428 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2429 value for non-existent files.
2430
b885bf36
EZ
24312011-09-11 Eli Zaretskii <eliz@gnu.org>
2432
2433 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2434 set its "size" to -1. This will set the modtime_size field of
2435 the corresponding buffer to -1, which is what
2436 verify-visited-file-modtime expects for files that do not exist.
2437 (Bug#9139)
2438
6612f0bf
PE
24392011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2440
2441 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2442 here ...
2443 * lisp.h: ... from here. push_key_description is no longer
2444 defined in keyboard.c, so its declaration should not be in
2445 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2446 logically belongs with push_key_description.
2447
dfb3f755
PE
24482011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2449
2450 * buffer.h: Include <sys/types.h> instead of <time.h>.
2451 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2452 Problem reported by Herbert J. Skuhra.
2453
3134906c
LMI
24542011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2455
2456 * xml.c (parse_region): Make the parsing work for
2457 non-comment-starting XML files again (bug#9144).
2458
8d903f4e
AS
24592011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2460
2461 * image.c (gif_load): Fix calculation of bottom and right corner.
2462 (Bug#9468)
2463
80ad64f4
EZ
24642011-09-10 Eli Zaretskii <eliz@gnu.org>
2465
2466 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2467 redisplay in small windows.
2468
208a048d
EZ
24692011-09-09 Eli Zaretskii <eliz@gnu.org>
2470
2471 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2472
9b1c252e
MR
24732011-09-08 Martin Rudalics <rudalics@gmx.at>
2474
2475 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2476 Operate on live windows only.
2477
2949f33b
JB
24782011-09-08 Juanma Barranquero <lekktu@gmail.com>
2479
2480 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2481
e08dcafd
EZ
24822011-09-07 Eli Zaretskii <eliz@gnu.org>
2483
2484 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2485 only under bidi iteration.
2486
115b96bd
JD
24872011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2488
2489 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2490
c8199d0f
PE
24912011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2492
2493 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2494 Without this fix, the command to link temacs failed due to an
2495 undefined symbol __builtin_isnan. This is because
2496 /usr/include/iso/math_c99.h #defines isnan(x) to
2497 __builtin_isnan(x), but the bundled gcc, which identifies itself
2498 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2499 a __builtin_isnan.
2500 * floatfns.c (isnan): #undef, and then #define to a clone of
2501 what's in data.c.
2502 (Fisnan): Always define, since it's always available now.
2503 (syms_of_floatfns): Always define isnan at the Lisp level.
2504
e39b275c 25052011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2506
2507 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2508
b2db44d9 25092011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2510
f4af5137 2511 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2512 The previous code assumed that file offsets (off_t values) fit in
2513 EMACS_INT variables, which is not true on typical 32-bit hosts.
2514 The code messed up by falsely reporting buffer overflow in cases
2515 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2516 when "big" contains more than 2**29 bytes, even though this
2517 inserts just one byte and does not overflow the buffer.
2518 (Finsert_file_contents): Store file offsets as off_t
2519 values, not as EMACS_INT values. Check for overflow when
2520 converting between EMACS_INT and off_t. When checking for
2521 buffer overflow or for overlap, take the offsets into account.
2522 Don't use EMACS_INT for small values where int suffices.
2523 When checking for overlap, fix a typo: ZV was used where
2524 ZV_BYTE was intended.
2525 (Fwrite_region): Don't assume off_t fits into 'long'.
2526 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2527
ecfc0a49
MA
25282011-09-05 Michael Albinus <michael.albinus@gmx.de>
2529
2530 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2531
6511acf2 25322011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2533
0999621a 2534 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2535
2536 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2537 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2538 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2539 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2540 (modify_event_symbol): Do not assume that the length of
2541 name_alist_or_stem is safe to alloca and fits in int.
2542 (Fexecute_extended_command): Likewise for function name and binding.
2543 (Frecursion_depth): Wrap around reliably on integer overflow.
2544 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2545 since some callers pass EMACS_INT values.
2546 (Fsingle_key_description): Don't crash if symbol name contains more
2547 than MAX_ALLOCA bytes.
2548 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2549 (get_minibuffer): Arg is now EMACS_INT, not int.
2550 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2551 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2552 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2553
2be7d702
PE
2554 * dbusbind.c (signature_cat): New function.
2555 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2556 Do not overrun buffer; instead, report string overflow.
2557
9d1df220
PE
2558 * dispnew.c (add_window_display_history): Don't overrun buffer.
2559 Truncate instead; this is OK since it's just a log.
2560
33ef5c64
PE
2561 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2562 even if the time zone offset is outlandishly large.
2563 Don't mishandle offset == INT_MIN.
2564
66c6fdd5
PE
2565 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2566 when creating daemon; the previous buffer-overflow check was incorrect.
2567
d749b01b
PE
2568 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2569 which has the guts of the old verror function.
2570
b5cd1905
PE
2571 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2572 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2573
6e1a67fb
PE
2574 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2575 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2576 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2577 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2578 length of string rather than counting it via multiple sprintfs;
2579 that's simpler and more reliable.
c21721cc
PE
2580 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2581 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2582 sprintf, in case result does not fit in int.
2583
c57b67fc
PE
2584 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2585 (fontset_from_font): Print it.
2586
8a401434
PE
2587 * frame.c (tty_frame_count): Now printmax_t, not int.
2588 (make_terminal_frame, set_term_frame_name): Print it.
2589 (x_report_frame_params): In X, window IDs are unsigned long,
2590 not signed long, so print them as unsigned.
2591 (validate_x_resource_name): Check for implausibly long names,
2592 and don't assume name length fits in 'int'.
2593 (x_get_resource_string): Don't blindly alloca invocation name;
2594 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2595 not fit in int.
2596
6e1a67fb
PE
2597 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2598 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2599 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2600
0df02bf3
PE
2601 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2602 Use esprintf, not sprintf, in case result does not fit in int.
2603
48e30793
PE
2604 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2605 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2606 it as a large positive number.
2607 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2608 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2609
a66ff6d8
PE
2610 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2611 in case result does not fit in int.
2612
aca216ff
PE
2613 * print.c (float_to_string): Detect width overflow more reliably.
2614 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2615 buffer overrun. Don't assume list length fits in 'int'. Treat
2616 print length of 0 as 0, not as infinity; to be consistent with other
2617 uses of print length in this function. Don't overflow print length
2618 index. Don't assume hash table size fits in 'long', or that
2619 vectorlike size fits in 'unsigned long'.
2620
31c286f7
PE
2621 * process.c (make_process): Use printmax_t, not int, to format
2622 process-name gensyms.
2623
55e5faa1
PE
2624 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2625
80f2e268
PE
2626 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2627 to avoid potential buffer overrun.
2628
670741ab
PE
2629 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2630 if X resource line is longer than 512 bytes.
2631
b7163a50
PE
2632 * xfns.c (x_window): Make sprintf buffer a bit bigger
2633 to avoid potential buffer overrun.
2634
ae58ff1f
PE
2635 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2636
c43c8a6a
PE
2637 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2638
3f8236f4
PE
26392011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2640
53e9fe90 2641 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2642 Without these, Emacs silently mishandles large integers sometimes.
2643 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2644 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2645
6511acf2
PE
2646 * xdisp.c (try_window_id): Check Emacs fixnum range before
2647 converting to 'int'.
806add1d 2648
6511acf2 2649 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2650 Check that an Emacs fixnum is in range before assigning it to 'int'.
2651 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2652 values converted from Emacs fixnums.
2653 (Frecenter): Don't wrap around a line count if it is out of 'int'
2654 range; instead, treat it as an extreme value.
2655 (Fset_window_configuration, compare_window_configurations):
2656 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2657
6511acf2
PE
2658 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2659 that can exceed INT_MAX. Check that EMACS_INT value is in range
2660 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2661 (match_limit): Don't assume that a fixnum can fit in 'int'.
2662
6511acf2 2663 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2664 exceed INT_MAX.
2665
6511acf2 2666 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2667 (Fvertical_motion): Don't wrap around LINES values that don't fit
2668 in 'int'. Instead, treat them as extreme values. This is good
2669 enough for windows, which can't have more than INT_MAX lines anyway.
2670
fcb901a7
LMI
26712011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2672
0f2f6b6d
LMI
2673 * Require libxml/parser.h to avoid compilation warning.
2674
fcb901a7
LMI
2675 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2676
2677 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2678 since this reportedly can destroy thread storage.
2679
6e20a0d4
CY
26802011-08-30 Chong Yidong <cyd@stupidchicken.com>
2681
2682 * syntax.c (find_defun_start): Update all cache variables if
2683 exiting early (Bug#9401).
2684
148ae00e
EZ
26852011-08-30 Eli Zaretskii <eliz@gnu.org>
2686
f6cfbd8f
EZ
2687 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2688
148ae00e
EZ
2689 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2690 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2691 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2692
2693 * term.c (tty_append_glyph): New function.
2694 (produce_stretch_glyph): Static function and its prototype deleted.
2695
a66cfb1c
SM
2696 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2697 Add prototypes.
148ae00e 2698
c4a07a4c
PE
26992011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2700
2701 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2702 when checking :margin (Bug#9390).
2703 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2704 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2705 so that the name doesn't mislead. All uses changed.
2706
6bc8cd65
JB
27072011-08-28 Johan Bockgård <bojohan@gnu.org>
2708
2709 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2710 set_tty_hooks.
2711
dca4927e
EZ
27122011-08-27 Eli Zaretskii <eliz@gnu.org>
2713
2714 * xdisp.c (move_it_to): Don't bail out early when reaching
2715 position beyond to_charpos, if we are scanning backwards.
2716 (move_it_vertically_backward): When DY == 0, make sure we get to
2717 the first character in the line after the newline.
2718
f2cad773
PE
27192011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2720
2721 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2722 (ccl_driver): Do not generate an out-of-range pointer.
2723 (Fccl_execute_on_string): Remove unnecessary check for
2724 integer overflow, noted by Stefan Monnier in
2725 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2726 Remove a FIXME that didn't need fixing.
2727 Simplify the newly-introduced buffer reallocation code.
2728
0cae2cdb
JB
27292011-08-27 Juanma Barranquero <lekktu@gmail.com>
2730
2731 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2732
5fc295a4 27332011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2734
70c60eb2 2735 Integer and memory overflow issues (Bug#9196).
726e0ab1 2736
d31850da
PE
2737 * doc.c (get_doc_string): Rework so that
2738 get_doc_string_buffer_size is the actual buffer size, rather than
2739 being 1 less than the actual buffer size; this makes xpalloc more
2740 convenient.
2741
a69fbedb
PE
2742 * image.c (x_allocate_bitmap_record, cache_image):
2743 * xselect.c (Fx_register_dnd_atom):
2744 Simplify previous changes by using xpalloc.
2745
fe5c5d37
PE
2746 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2747 since either will do and ptrdiff_t is convenient with xpalloc.
2748
0065d054
PE
2749 * charset.c (charset_table_size)
2750 (struct charset_sort_data.priority): Now ptrdiff_t.
2751 (charset_compare): Don't overflow if priorities differ greatly.
2752 (Fsort_charsets): Don't assume list length fits in int.
2753 Check for size-calculation overflow when allocating sort data.
2754 (syms_of_charset): Allocate an initial charset table that is
2755 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2756
2757 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2758
2759 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2760 The actual value is always <= INT_MAX, and leaving it unsigned made
2761 overflow checking harder.
2762
2763 * dispextern.h (struct glyph_matrix.rows_allocated)
2764 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2765 with xpalloc. The values are still always <= INT_MAX.
2766
2767 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2768
2769 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2770 (SAFE_NALLOCA): New macro.
2771
2772 * region-cache.c (struct boundary.pos, find_cache_boundary)
2773 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2774 (set_cache_region, invalidate_region_cache)
2775 (revalidate_region_cache, know_region_cache, region_cache_forward)
2776 (region_cache_backward, pp_cache):
2777 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2778 so that ptrdiff_t * can be passed to xpalloc.
2779 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2780 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2781 (pp_cache): Don't assume cache_len fits in int.
2782 * region-cache.h: Adjust extern decls to match.
2783
2784 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2785 EMACS_INT, since either will do, for xpalloc.
2786
2787 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2788 (xnmalloc, xnrealloc, xpalloc): New functions.
2789
726e0ab1
PE
2790 * bidi.c (bidi_shelve_header_size): New constant.
2791 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2792 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2793
51f30bc5 2794 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2795 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2796 (overlay_strings):
2797 Don't update size of array until after memory allocation succeeds,
2798 because xmalloc/xrealloc may not return.
0065d054
PE
2799 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2800 now that we have proper integer overflow checking.
2801 (record_overlay_string, overlay_strings): Catch overflows when
2802 calculating size of overlay_str_buf.
726e0ab1 2803
0065d054
PE
2804 * callproc.c (Fcall_process): Check for size overflow when
2805 calculating size of args2.
2806 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2807 Normally we prefer signed values, but sticking with ptrdiff_t would
2808 require adding more-complicated checks.
726e0ab1
PE
2809
2810 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2811 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2812 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2813 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2814
2815 * character.c (Fstring): Check for size-calculation overflow.
2816
2817 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2818 unnecessary integer overflow. Check for size overflow.
2819 (encode_coding_object): Don't update size until xmalloc succeeds.
2820
2821 * composite.c (get_composition_id): Check for overflow in glyph
2822 length calculations.
2823
2824 Integer and memory overflow fixes for display code.
2825 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2826 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2827 (scrolling_window): Check for overflow in size calculations.
2828 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2829 Don't assume glyph table len fits in int.
2830 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2831 (row_table_size): Now ptrdiff_t, not int.
2832 (scrolling_window): Avoid overflow in size calculations.
2833 Don't update size until allocation succeeds.
2834 * fns.c (concat): Check for overflow in size calculations.
2835 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2836 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2837 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2838
2839 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2840 (get_doc_string): Check for size calculation overflow.
2841 Don't update size until allocation succeeds.
2842 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2843 EMACS_INT, where ptrdiff_t will do.
2844 (Fsubstitute_command_keys): Check for string overflow.
2845
2846 * editfns.c (set_time_zone_rule): Don't assume environment length
2847 fits in int.
2848 (message_length): Now ptrdiff_t, not int.
2849 (Fmessage_box): Don't update size until allocation succeeds.
2850 Don't assume message length fits in int.
2851 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2852
0065d054
PE
2853 * emacs.c (main): Do not reallocate argv, since there is a null at
2854 the end that can be overwritten, and this way there's no need to
2855 worry about size-calculation overflow.
2856 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2857
2858 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2859 alloc succeeds.
2860 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2861
2862 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2863 (x_set_scroll_bar_width, x_figure_window_size):
2864 Check for integer overflow.
2865 (x_set_alpha): Do not assume XINT fits in int.
2866
2867 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2868 This is for the members text_lines, text_cols, total_lines, total_cols,
2869 where the system imposes an 'int' limit.
2870
2871 * fringe.c (Fdefine_fringe_bitmap):
2872 Don't update size until alloc works.
2873
2874 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2875 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2876
2877 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2878 Check for size-calculation overflow.
2879 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2880 do, as we prefer signed integers.
2881 (id_to_widget.max_size, id_to_widget.used)
2882 (xg_store_widget_in_map, xg_remove_widget_from_map)
2883 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2884 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2885 Use and return ptrdiff_t, not int.
2886 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2887 * gtkutil.h: Change prototypes to match the above.
2888
2889 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2890 are duplicate now that they've been promoted to lisp.h.
2891 (x_allocate_bitmap_record, x_alloc_image_color)
2892 (make_image_cache, cache_image, xpm_load):
2893 Don't update size until alloc is done.
2894 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2895 (x_detect_edges):
3256efce 2896 Check for size calculation overflow.
726e0ab1
PE
2897 (ct_colors_allocated_max): New constant.
2898 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2899 overflow.
3256efce 2900
726e0ab1
PE
2901 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2902 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2903 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2904 Use ptrdiff_t, not int, to count maps.
2905 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2906 calculations. Don't update size until allocation succeeds.
2907 Redo calculations to avoid overflow.
726e0ab1
PE
2908 * keyboard.h: Change prototypes to match the above.
2909
2910 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2911 to count maps.
2912 (current_minor_maps): Check for size calculation overflow.
2913 * keymap.h: Change prototypes to match the above.
2914
2915 * lread.c (read1, init_obarray): Don't update size until alloc done.
2916
2917 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2918 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2919
726e0ab1
PE
2920 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2921 Now ptrdiff_t, not int.
2922 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2923 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2924
2925 * process.c (Fnetwork_interface_list): Check for overflow
2926 in size calculation.
2927
2928 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2929
2930 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2931 overflow. Don't bother calling xmalloc when xrealloc will do.
2932
2933 * search.c (Freplace_match): Check for size calculation overflow.
2934 (Fset_match_data): Don't assume list lengths fit in 'int'.
2935
2936 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2937 for command line length. Do not attempt to address one before the
2938 beginning of an array, as that's not portable.
2939
2940 * term.c (max_frame_lines): Remove; unused.
2941 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2942 not int.
2943 (encode_terminal_code, calculate_costs): Check for size
2944 calculation overflow.
2945 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2946 table lengths and related sizes. Don't update size until alloc
2947 done. Redo calculations to avoid overflow.
2948 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2949
2950 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2951 subtracting pointers.
2952 (gobble_line): Check for overflow more carefully. Don't update size
2953 until alloc done.
2954
2955 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2956 Don't update size until alloc done.
2957 Redo size calculations to avoid overflow.
2958 Check for size calculation overflow.
0065d054 2959 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2960
2961 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2962 Use ptrdiff_t, not int, for sizes.
2963 (store_mode_line_noprop_char): Don't update size until alloc done.
2964
0065d054
PE
2965 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2966 Use ptrdiff_t, not int, for sizes.
2967 (Finternal_make_lisp_face, cache_face):
2968 Check for size calculation overflow.
2969 (cache_face): Treat size calculation overflows as if they were
2970 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2971
2972 * xfns.c (x_encode_text, x_set_name_internal)
2973 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2974 sizes, since they can exceed INT_MAX in size. Check for size
2975 calculation overflow.
2976
0065d054
PE
2977 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2978 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2979 Don't update size until alloc done.
2980
0065d054 2981 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2982 as sprintf is limited to int lengths.
1d526e2f 2983
252c5ee1
PE
2984 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2985 (X_LONG_MIN): New macros.
864d7ce7
PE
2986 Use them to make the following changes clearer.
2987 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2988 This change doesn't affect the value now, but it may help remind
2989 future maintainers not to raise the value too much later.
2990 (SELECTION_QUANTUM): Remove, replacing with ...
2991 (selection_quantum): ... new function, which avoids overflow.
2992 All uses changed.
2993 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2994 assumption that selection length fits in 'int'.
2995 (x_reply_selection_request, x_handle_selection_request)
2996 (x_get_window_property, receive_incremental_selection)
2997 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2998 (lisp_data_to_selection_data, clean_local_selection_data):
2999 Use ptrdiff_t, not int, to record length of selection.
3000 (x_reply_selection_request, x_get_window_property)
3001 (receive_incremental_selection, x_property_data_to_lisp):
3002 Redo calculations to avoid overflow.
3003 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3004 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3005 something.
3006 (x_get_window_property, receive_incremental_selection)
3007 (lisp_data_to_selection_data, x_property_data_to_lisp):
3008 Check for size-calculation overflow.
3009 (x_get_window_property, receive_incremental_selection)
3010 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3011 Don't store size until memory allocation succeeds.
3012 (x_get_window_property): Plug memory leak on memory exhaustion.
3013 Don't double-block input; malloc is safe here. Don't assume 2**34
3014 - 4 fits in unsigned long. Add an xassert to check
3015 XGetWindowProperty overflow. Be more careful about overflow
3016 calculations, and distinguish size from memory overflow better.
3017 (receive_incremental_selection): When tracing, don't assume
3018 unsigned int is less than INT_MAX.
3019 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3020 harmful) conversions of unsigned short to int.
3021 (lisp_data_to_selection_data): Don't assume that integers
3022 in the range -65535 through -1 fit in an X unsigned short.
3023 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3024 result parameters unless successful. Rely on cons_to_unsigned
3025 to report problems with elements; the old code wasn't right anyway.
3026 (x_check_property_data): Check for int overflow; we cannot use
3027 a wider type due to X limits.
3028 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3029
726e0ab1 3030 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3031
0065d054
PE
3032 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3033 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3034 (x_color_cells): Don't store size until memory allocation succeeds.
3035 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3036 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3037 (x_term_init): Don't assume length fits in int (sprintf is limited
3038 to int size).
bc18e09d 3039
ebfa62c0
PE
3040 Use ptrdiff_t for composition IDs.
3041 * character.c (lisp_string_width):
3042 * composite.c (composition_table_size, n_compositions)
3043 (get_composition_id, composition_gstring_from_id):
3044 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3045 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3046 * window.c (Frecenter):
3047 Use ptrdiff_t, not int, for composition IDs.
3048 * composite.c (get_composition_id): Check for integer overflow.
3049 * composite.h: Adjust prototypes to match the above changes.
3050
d3411f89
PE
3051 Use ptrdiff_t for hash table indexes.
3052 * category.c (hash_get_category_set):
3053 * ccl.c (ccl_driver):
3054 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3055 * coding.c (coding_system_charset_list, detect_coding_system):
3056 * coding.h (struct coding_system.id):
3057 * composite.c (get_composition_id, gstring_lookup_cache):
3058 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3059 * image.c (xpm_get_color_table_h):
3060 * lisp.h (hash_lookup, hash_put):
3061 * minibuf.c (Ftest_completion):
3062 Use ptrdiff_t for hash table indexes, not int (which is too
3063 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3064 32-bit --with-wide-int hosts).
3065
e097a6fa
PE
3066 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3067 Add a FIXME comment about memory leaks.
3068 (syms_of_charset): Don't assume xmalloc returns.
3069
5637687f
PE
3070 Don't assume that stated character widths fit in int.
3071 * character.c (Fchar_width, c_string_width, lisp_string_width):
3072 * character.h (CHAR_WIDTH):
3073 * indent.c (MULTIBYTE_BYTES_WIDTH):
3074 Use sanitize_char_width to avoid undefined and/or bad behavior
3075 with outlandish widths.
a66cfb1c 3076 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3077 now that we have two such functions. All uses changed.
3078 (sanitize_char_width): New inline function.
3079
a2271ba2
PE
3080 Don't assume that tab-width fits in int.
3081 * character.h (sanitize_width): New inline function.
3082 (SANE_TAB_WIDTH): New macro.
3083 (ASCII_CHAR_WIDTH): Use it.
3084 * indent.c (sane_tab_width): Remove. All uses replaced by
3085 SANE_TAB_WIDTH (current_buffer).
3086 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3087
18c52557
PE
3088 * fileio.c: Integer overflow issues with file modes.
3089 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3090
caeeedc1
PE
3091 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3092 Remove unreachable code.
3093 (read_hex, load_charset_map_from_file): Check for integer overflow.
3094
6df6ae42 3095 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3096 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3097 (x_send_scroll_bar_event): Likewise. Check that the size does not
3098 exceed limits imposed by XClientMessageEvent, as well as the usual
3099 ptrdiff_t and size_t limits.
3100
b13995db
PE
3101 * keyboard.c: Overflow, signedness and related fixes.
3102 (make_lispy_movement): Use same integer type in forward decl
3103 that is used in the definition.
3104 (read_key_sequence, keyremap_step):
3105 Change bufsize argument back to int, undoing my 2011-03-30 change.
3106 We prefer signed types, and int is wide enough here.
3107 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3108 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3109 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3110 length, not size_t. Use ptrdiff_t for index, not int.
3111 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3112 possibility of integer overflow.
3113
13464394
PE
3114 Overflow, signedness and related fixes for images.
3115
3116 * dispextern.h (struct it.stack[0].u.image.image_id)
3117 (struct_it.image_id, struct image.id, struct image_cache.size)
3118 (struct image_cache.used, struct image_cache.ref_count):
3119 * gtkutil.c (update_frame_tool_bar):
3120 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3121 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3122 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3123 * nsmenu.m (update_frame_tool_bar):
3124 * xdisp.c (calc_pixel_width_or_height):
3125 * xfns.c (image_cache_refcount):
3126 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3127 on typical 64-bit hosts.
3128
3129 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3130 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3131 Omit unnecessary casts to int.
3132 (parse_image_spec): Check that integers fall into 'int' range
3133 when the callers expect that.
3134 (image_ascent): Redo ascent calculation to avoid int overflow.
3135 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3136 (lookup_image): Remove unnecessary tests.
3137 (xbm_image_p): Locals are now of int, not EMACS_INT,
3138 since parse_image_check makes sure they fit into int.
3139 (png_load, gif_load, svg_load_image):
3140 Prefer int to unsigned where either will do.
3141 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3142 old tiff_error_handler and tiff_warning_handler.
3143 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3144 stack buffer overflows. It uses only the features of vsnprintf
3145 that are common to both POSIX and native Microsoft.
3146 (tiff_error_handler, tiff_warning_handler): Use it.
3147 (tiff_load, gif_load, imagemagick_load_image):
3148 Don't assume :index value fits in 'int'.
3149 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3150 (imagemagick_load_image): Check that crop parameters fit into
3151 the integer types that MagickCropImage accepts. Don't assume
3152 Vimagemagick_render_type has a nonnegative value. Don't assume
3153 size_t fits in 'long'.
3154 (gs_load): Use printmax_t to print the widest integers possible.
3155 Check for integer overflow when computing image height and width.
3156
c11821d4
EZ
31572011-08-26 Eli Zaretskii <eliz@gnu.org>
3158
3159 * xdisp.c (redisplay_window): Don't force window start if point
3160 will be invisible in the resulting window. (Bug#9324)
3161
0c95fcf7
EZ
31622011-08-25 Eli Zaretskii <eliz@gnu.org>
3163
3164 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3165 the display spec is of the form `(space ...)'.
3166 (handle_display_spec): Return the value returned by
3167 handle_single_display_spec, not just 1 or zero.
3168 (handle_single_display_spec): If the display spec is of the form
3169 `(space ...)', and specifies display in the text area, return 2
3170 rather than 1.
fee65a97 3171 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3172 accurately, and prefer exact match for point under bidi.
3173 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3174
3175 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3176 into disp_prop; all users changed.
3177
3178 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3179 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3180 for the text covered by the display property.
3181
e4ed06f1
CY
31822011-08-25 Chong Yidong <cyd@stupidchicken.com>
3183
3184 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3185 Change return value to nil.
3186 (Frecord_buffer): Delete unused function.
3187
f67cdd7f
EZ
31882011-08-24 Eli Zaretskii <eliz@gnu.org>
3189
5980d4c6
EZ
3190 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3191 buffers, return left-to-right.
8610fe8b
EZ
3192 (set_cursor_from_row): Consider candidate row a win if its glyph
3193 represents a newline and point is on that newline. Fixes cursor
3194 positioning on the newline at EOL of R2L text within L2R
3195 paragraph, and vice versa.
3196 (try_cursor_movement): Check continued rows, in addition to
3197 continuation rows. Fixes unwarranted scroll when point enters a
3198 continued line of R2L text within an L2R paragraph, or vice versa.
3199 (cursor_row_p): Consider the case of point being equal to
3200 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3201 from the end of a short line to the beginning of a continued line
3202 of R2L text within L2R paragraph.
3203 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3204 composed characters.
5980d4c6 3205
f67cdd7f
EZ
3206 * bidi.c (bidi_check_type): Use xassert.
3207 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3208 members.
3209
bca633fb
EZ
32102011-08-23 Eli Zaretskii <eliz@gnu.org>
3211
3212 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3213 a character.
3214
4a5885a7
CY
32152011-08-23 Chong Yidong <cyd@stupidchicken.com>
3216
3217 * nsfont.m (ns_otf_to_script): Fix typo.
3218
0902a04e
KH
32192011-08-22 Kenichi Handa <handa@m17n.org>
3220
3221 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3222 extra slot even if the purpose is char-code-property-table.
3223
1a2e6670
EZ
32242011-08-23 Eli Zaretskii <eliz@gnu.org>
3225
8ddde651
EZ
3226 * xdisp.c (redisplay_window): When computing centering_position,
3227 account for the height of the header line. (Bug#8874)
3228
425cc014
EZ
3229 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3230 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3231 candidate is selected by the mouse, and that candidate has a
3232 composed character under the mouse.
3233
1a2e6670
EZ
3234 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3235 coordinates reported by pos-visible-in-window-p for a composed
3236 character in column zero.
3237
8b76d6f8
SM
32382011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3239
3240 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3241
dac347dd
EZ
32422011-08-22 Eli Zaretskii <eliz@gnu.org>
3243
3244 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3245 consider it a hit if to_charpos is anywhere in the range of the
3246 composed buffer positions.
3247
e013fb34
CY
32482011-08-22 Chong Yidong <cyd@stupidchicken.com>
3249
3250 * image.c (gif_load): Don't assume that each subimage has the same
3251 dimensions as the base image. Handle disposal method that is
3252 "undefined" by the gif spec (Bug#9335).
3253
bd1ba3e8
CY
32542011-08-20 Chong Yidong <cyd@stupidchicken.com>
3255
3256 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3257 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3258
54a1215b
EZ
32592011-08-19 Eli Zaretskii <eliz@gnu.org>
3260
823564e5
EZ
3261 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3262 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3263 from an Org mode buffer to a Speedbar frame.
3264
54a1215b
EZ
3265 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3266 a composition, take its buffer position from IT->cmp_it.charpos.
3267 Fixes cursor positioning at the beginning of a line that begins
3268 with a composed character.
3269
9778ebcc
EZ
32702011-08-18 Eli Zaretskii <eliz@gnu.org>
3271
0be6ee06
EZ
3272 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3273 character bidirectional type, use STRONG_L instead. Fixes crashes
3274 in a buffer produced by `describe-categories'.
3275
9778ebcc
EZ
3276 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3277 members before the level stack, so they would be saved and
3278 restored when copying iterator state. Fixes incorrect reordering
3279 around TABs covered by display properties.
3280
156bffbe
AS
32812011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3282
6b02f655 3283 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3284
72ad093b
CY
32852011-08-17 Chong Yidong <cyd@stupidchicken.com>
3286
3287 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3288 (internal_condition_case_2, internal_condition_case_n):
3289 Remove unnecessary aborts (Bug#9081).
72ad093b 3290
35774242
EZ
32912011-08-17 Eli Zaretskii <eliz@gnu.org>
3292
3293 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3294 has no `load' handler, try opening the file locally. (Bug#9311)
3295
db76dd85
KB
32962011-08-16 Ken Brown <kbrown@cornell.edu>
3297
3298 * gmalloc.c: Expand comment.
3299
b215eee5
EZ
33002011-08-16 Eli Zaretskii <eliz@gnu.org>
3301
3302 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3303 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3304
a4579d33
KB
33052011-08-16 Ken Brown <kbrown@cornell.edu>
3306
3307 Fix memory allocation problems in Cygwin build (Bug#9273).
3308
3309 * unexcw.c ( __malloc_initialized): Declare external variable.
3310 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3311
8b76d6f8
SM
3312 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3313 New variables.
a4579d33
KB
3314 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3315 dumped emacs.
3316 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3317 in the static heap.
3318 [CYGWIN] (special_realloc): New function.
3319 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3320 requests to realloc storage in the static heap.
3321
3ebec551
PE
33222011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3323
3324 * bidi.c (bidi_initialize): Remove unused local.
3325
9fd8be00
EZ
33262011-08-15 Eli Zaretskii <eliz@gnu.org>
3327
6b02f655
SM
3328 * bidimirror.h:
3329 * biditype.h: Remove file.
3330 * makefile.w32-in ($(BLD)/bidi.$(O)):
3331 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3332
3333 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3334
3335 * chartab.c: Improve commentary for the uniprop_table API.
3336
32413314
EZ
3337 * bidi.c (bidi_paragraph_init): Support zero value of
3338 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3339 (bidi_initialize): Use uniprop_table instead of including
3340 biditype.h and bidimirror.h.
32413314 3341
9fd8be00
EZ
3342 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3343 coordinates of the iterator when restoring from ppos_it.
3344 (Bug#9296)
3345
5cf2b69b
KH
33462011-08-14 Kenichi Handa <handa@m17n.org>
3347
3348 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3349 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3350
daf17d00
EZ
33512011-08-14 Eli Zaretskii <eliz@gnu.org>
3352
3353 * xdisp.c (move_it_in_display_line_to): Don't invoke
3354 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3355 ppos_it. Fixes vertical cursor motion when line beginning is
3356 covered by an image. (Bug#9296)
3357
08e3161a
JD
33582011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3359
3360 * nsterm.h (ns_run_ascript): Declare.
3361 (NSAPP_DATA2_RUNASSCRIPT): Define.
3362
3363 * nsfns.m (as_script, as_result, as_status): New static variables.
3364 (ns_run_ascript): New function.
5e617bc2 3365 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3366 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3367 the event loop. Get status from as_status (Bug#7276).
3368
3369 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3370 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3371 the event loop (Bug#7276).
3372
a3720aa2
AS
33732011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3374
3375 * gnutls.c (QCgnutls_bootprop_priority)
3376 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3377 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3378 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3379 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3380 (QCgnutls_bootprop_verify_hostname_error)
3381 (QCgnutls_bootprop_callbacks_verify): Rename from
3382 Qgnutls_bootprop_..., all uses changed.
3383
3384 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3385 uses changed.
3386
0a0d27fb
PE
33872011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3388
19d5c50c
PE
3389 * xfaces.c (Qframe_set_background_mode): Now static.
3390 * dispextern.h (Qframe_set_background_mode): Remove decl.
3391
0a0d27fb
PE
3392 * process.c (Fnetwork_interface_info): Declare local only if needed.
3393
377538cb
JD
33942011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3395
3396 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3397 (Fnetwork_interface_list): Allocate in increments of bytes instead
3398 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3399 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3400 sockaddr.
3401 (struct ifflag_def): notrailers is smart on OSX.
3402 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3403 Get hardware address with getifaddrs if available.
3404
08fff70c
EZ
34052011-08-12 Eli Zaretskii <eliz@gnu.org>
3406
3407 * xdisp.c (iterate_out_of_display_property): xassert that
3408 IT->position is set to within IT->object's boundaries. Break from
3409 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3410 when IT->position is set up wrongly due to some bug.
3411 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3412 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3413 entry. Force push_it to save on the stack the current
3414 buffer/string position, to be restored by pop_it. Fix flags in
3415 the iterator structure wrt the object coming from a display
3416 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3417 properties. (Bug#9284)
3418
7be1c708 34192011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3420
7be1c708
CY
3421 * fontset.c (fontset_get_font_group): Add proper type checks.
3422 (Bug#9172)
aac0c6e3 3423
7be1c708 34242011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3425
7be1c708
CY
3426 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3427 and LC_VERSION_MIN_MACOSX.
3428 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3429 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3430
97bb72a6
EZ
34312011-08-08 Eli Zaretskii <eliz@gnu.org>
3432
3433 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3434 no-display-properties-and-no-overlays under bidi display.
3435 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3436 properties and overlays.
97bb72a6 3437
d5617611
CY
34382011-08-08 Chong Yidong <cyd@stupidchicken.com>
3439
37e11a63
CY
3440 * editfns.c (Fset_time_zone_rule): Document relationship with the
3441 setenv function.
3442
d5617611
CY
3443 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3444 the font entity extracted from the cache (Bug#8109).
3445
58872834
CY
34462011-08-07 Chong Yidong <cyd@stupidchicken.com>
3447
3448 * composite.c (autocmp_chars): Don't reset point. That is done by
3449 restore_point_unwind (Bug#5984).
3450
75bfc667
JL
34512011-08-07 Juri Linkov <juri@jurta.org>
3452
3453 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3454 to show the arg `TIME' instead of `TIMEVAL'.
3455
d1410150
EZ
34562011-08-06 Eli Zaretskii <eliz@gnu.org>
3457
3458 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3459 display property strides EOL and includes a newline, as in
3460 longlines-mode. (Bug#9254)
75b771e4
EZ
3461 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3462 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3463
3464 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3465 is non-zero, even if the data buffer is NULL. Fixes a crash in
3466 vertical-motion with longlines-mode. (Bug#9254)
3467
35928349
EZ
34682011-08-05 Eli Zaretskii <eliz@gnu.org>
3469
ec7cc85b
EZ
3470 * bidi.c <bidi_cache_total_alloc>: Now static.
3471 (bidi_initialize): Initialize bidi_cache_total_alloc.
3472
8b76d6f8 3473 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3474 cache. (Bug#9221)
3475
3476 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3477 amount allocated this far in `bidi_cache_total_alloc'.
3478 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3479 non-zero, only free the data buffer without restoring the cache
3480 contents. All callers changed.
3481
3482 * dispextern.h (bidi_unshelve_cache): Update prototype.
3483
3484 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3485 (move_it_in_display_line, move_it_to)
3486 (move_it_vertically_backward, move_it_by_lines): Replace the call
3487 to xfree to an equivalent call to bidi_unshelve_cache.
3488 (move_it_in_display_line_to): Fix logic of returning
412b6358 3489 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3490
e2e2423b
EZ
34912011-08-05 Eli Zaretskii <eliz@gnu.org>
3492
3493 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3494 came from a string character with a `cursor' property. (Bug#9229)
3495
ae9e757a
JD
34962011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3497
3498 * Makefile.in (LIB_PTHREAD): New variable.
3499 (LIBES): Add LIB_PTHREAD (Bug#9216).
3500
3501 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3502 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3503
213bd7f2
AS
35042011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3505
6b02f655 3506 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3507
99aaf75f
JD
35082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3509
3510 * xterm.c (x_find_topmost_parent): New function.
3511 (x_set_frame_alpha): Find topmost parent window with
3512 x_find_topmost_parent and set the property there also (bug#9181).
3513 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3514
c74e9d86
PE
35152011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3516
3517 * callproc.c (Fcall_process): Avoid vfork clobbering
3518 the local vars buffer, coding_systems, current_dir.
3519
640c8776
SM
35202011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3521
3522 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3523
f26d0e4c
PE
35242011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3525
8a10d76c
PE
3526 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3527 so that it is not optimized away.
3528
f26d0e4c
PE
3529 * xdisp.c (compute_display_string_pos): Remove unused local.
3530
55439c61
EZ
35312011-08-02 Eli Zaretskii <eliz@gnu.org>
3532
3533 Fix slow cursor motion and scrolling in large buffers with
3534 selective display, like Org Mode buffers. (Bug#9218)
3535
3536 * dispextern.h (struct bidi_it): New member disp_prop_p.
3537
3538 * xdisp.c: Remove one-slot cache of display string positions.
3539 (compute_display_string_pos): Accept an additional argument
5e617bc2 3540 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3541 for a display string or property. If found, set DISP_PROP_P
3542 non-zero.
3543
3544 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3545 DISP_PROP_P, and pass it to compute_display_string_pos.
3546 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3547 non-zero. All callers of bidi_fetch_char changed.
3548
fb33fa43
SM
35492011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3550
3551 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3552
b099e063
DM
35532010-12-03 Don March <don@ohspite.net>
3554
3555 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3556 last character M-[char] is translated to ESC [char] (bug#7541).
3557
5cc7f7af
KH
35582011-08-02 Kenichi Handa <handa@m17n.org>
3559
d0fffa3f 3560 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3561
3562 * chartab.c (uniprop_table): Make it non-static.
3563
525d5e6e
EZ
35642011-08-01 Eli Zaretskii <eliz@gnu.org>
3565
3566 * xdisp.c (forward_to_next_line_start): Accept additional argument
3567 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3568 on the newline.
3569 (reseat_at_next_visible_line_start): Use the bidi iterator state
3570 returned by forward_to_next_line_start to restore the state of
3571 it->bidi_it after backing up to previous newline. (Bug#9212)
3572
31011111
AS
35732011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3574
3575 * regex.c (re_comp): Protoize.
3576 (re_exec): Fix return type.
3577 (regexec): Fix type of `ret'. (Bug#9203)
3578
476371c4
PE
35792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3580
e5d76069
PE
3581 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3582 This is needed if max-image-size is a floating-point number.
3583
9a79b20c
AS
35842011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3585
3586 * print.c (print_object): Print empty symbol as ##.
3587
3588 * lread.c (read1): Read ## as empty symbol.
3589
d8c2fa78
AA
35902011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3591
3592 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3593 setting frame foreground color (Bug#9175).
3594 (x_set_background_color): Likewise.
3595
ffe57a7a
AA
3596 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3597 contents (Bug#9176).
3598 (EmacsTooltip -init): Remove bezels and add shadows to
3599 tooltip windows.
3600
bf3492a5
AA
3601 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3602 or scroll bar (Bug#8470).
3603
d55e9c53
AA
3604 * nsfont.m (nsfont_open): Remove assignment to voffset and
3605 unnecessary vars hshink, expand, hd, full_height, min_height.
3606 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3607
3608 * nsterm.h (nsfont_info): Remove voffset field.
3609
d8c2fa78 36102011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3611
3612 Implement strike-through and overline on NextStep (Bug#8863).
3613
3614 * nsfont.m (nsfont_open): Use underline position provided by font,
3615 instead of hard-coded value of 2.
3616 (nsfont_draw): Call ns_draw_text_decoration instead.
3617
3618 * nsterm.h: Add declaration for ns_draw_text_decoration.
3619
3620 * nsterm.m (ns_draw_text_decoration): New function for drawing
3621 underline, overline, and strike-through.
3622 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3623 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3624 accommodate underlining, etc.
4843aac3 3625
4cc60b9b
EZ
36262011-07-28 Eli Zaretskii <eliz@gnu.org>
3627
bc7ece87
EZ
3628 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3629 default.
4cc60b9b 3630
476371c4
PE
36312011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3632
66606eea
PE
3633 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3634 Without this fix, if a signal arrives just after memory fills up,
3635 'malloc' might be invoked reentrantly.
3636
476371c4
PE
3637 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3638 In other words, assume that every image size is allowed, on non-X
3639 hosts. This assumption is probably wrong, but it lets Emacs compile.
3640
f3fcc40d
AS
36412011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3642
3643 * regex.c (re_iswctype): Convert return values to boolean.
3644
350c992f
EZ
36452011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3646
3647 * xdisp.c (compute_display_string_pos): Don't use cached display
3648 string position if the buffer had its restriction changed.
3649 (Bug#9184)
3650
5266b4bb
PE
36512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3652
3653 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3654
2573a837 36552011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3656
41f55ccd 3657 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3658
39e378da
PE
3659 * bidi.c: Integer size and overflow fixes.
3660 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3661 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3662 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3663 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3664 (bidi_find_other_level_edge):
3665 Use ptrdiff_t instead of EMACS_INT where either will do.
3666 This works better on 32-bit hosts configured --with-wide-int.
3667 (bidi_cache_ensure_space): Check for size-calculation overflow.
3668 Use % rather than repeated addition, for better worst-case speed.
3669 Don't set bidi_cache_size until after xrealloc returns, because it
3670 might not return.
3671 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3672 (bidi_cache_ensure_space): Also check that the bidi cache size
3673 does not exceed that of the largest Lisp string or buffer. See Eli
3674 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3675
5e927815
PE
3676 * alloc.c (__malloc_size_t): Remove.
3677 All uses replaced by size_t. See Andreas Schwab's note
3678 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3679
ca4aa935
PE
3680 * image.c: Improve checking for integer overflow.
3681 (check_image_size): Assume that f is nonnull, since
3682 it is always nonnull in practice. This is one less thing to
3683 worry about when checking for integer overflow later.
3684 (x_check_image_size): New function, which checks for integer
3685 overflow issues inside X.
3686 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3687 This removes the need for a memory_full check.
3688 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3689 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3690 (xbm_read_bitmap_data): Change locals back to 'int', since
3691 their values must fit in 'int'.
3692 (xpm_load_image, png_load, tiff_load):
3693 Invoke x_create_x_image_and_pixmap earlier,
3694 to avoid much needless work if the image is too large.
3695 (tiff_load): Treat overly large images as if
3696 x_create_x_image_and_pixmap failed, not as malloc failures.
3697 (gs_load): Use x_check_image_size.
3698
5f8f9cc2
PE
3699 * gtkutil.c: Omit integer casts.
3700 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3701 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3702
5adf60bc
PE
3703 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3704
c8907a93
PE
3705 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3706 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3707 would wrongly return t on a 64-bit host.
3708
e3c25c68
PE
3709 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3710 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3711 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3712 and therefore cause GCC to emit a bogus diagnostic in some cases.
3713
3f791afe
PE
3714 * image.c: Integer signedness and overflow and related fixes.
3715 This is not an exhaustive set of fixes, but it's time to
3716 record what I've got.
3717 (lookup_pixel_color, check_image_size): Remove redundant decls.
3718 (check_image_size): Don't assume that arbitrary EMACS_INT values
3719 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3720 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3721 (tiff_load, imagemagick_load_image):
3722 Check for overflow in size calculations.
3723 (x_create_x_image_and_pixmap): Remove unnecessary test for
3724 xmalloc returning NULL; that can't happen.
3725 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3726 (xpm_color_bucket): Use better integer hashing function.
3727 (xpm_cache_color): Don't possibly over-allocate memory.
3728 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3729 (gif_memory_source):
3730 Use ptrdiff_t, not int or size_t, to record sizes.
3731 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3732 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3733 either works, as we prefer signed integers.
3734 (tiff_read_from_memory, tiff_write_from_memory):
3735 Return tsize_t, not size_t, since that's what the TIFF API wants.
3736 (tiff_read_from_memory): Don't fail simply because the read would
3737 go past EOF; instead, return a short read.
3738 (tiff_load): Omit no-longer-needed casts.
3739 (Fimagemagick_types): Don't assume size fits into 'int'.
3740
3cc5a532
PE
3741 Improve hashing quality when configured --with-wide-int.
3742 * fns.c (hash_string): New function, taken from sxhash_string.
3743 Do not discard information about ASCII character case; this
3744 discarding is no longer needed.
3745 (sxhash-string): Use it. Change sig to match it. Caller changed.
3746 * lisp.h: Declare it.
3747 * lread.c (hash_string): Remove, since we now use fns.c's version.
3748 The fns.c version returns a wider integer if --with-wide-int is
3749 specified, so this should help the quality of the hashing a bit.
3750
b312a492
PE
3751 * emacs.c: Integer overflow minor fix.
3752 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3753 Define only if GNU_LINUX.
3754 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3755
dfd153ae
PE
3756 * dispnew.c: Integer signedness and overflow fixes.
3757 Remove unnecessary forward decls, that were a maintenance hassle.
3758 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3759 All uses changed.
3760 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3761 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3762 (prepare_desired_row, line_draw_cost):
3763 Use int, not unsigned, where either works.
3764 (save_current_matrix, restore_current_matrix):
3765 Use ptrdiff_t, not size_t, where either works.
3766 (init_display): Check for overflow more accurately, and without
3767 relying on undefined behavior.
3768
a81d11a3
PE
3769 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3770 Remove, replacing with the new symbols in lisp.h. All uses changed.
3771 * fileio.c (make_temp_name):
3772 * filelock.c (lock_file_1, lock_file):
3773 * xdisp.c (message_dolog):
3774 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3775 Use pMd etc. instead.
3776 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3777 replacing the pWIDE etc. symbols removed from editfns.c.
3778
3300e6fd
PE
3779 * keyboard.h (num_input_events): Now uintmax_t.
3780 This is (very slightly) less likely to mess up due to wraparound.
3781 All uses changed.
3782
fd05c7e9
PE
3783 * buffer.c: Integer signedness fixes.
3784 (alloc_buffer_text, enlarge_buffer_text):
3785 Use ptrdiff_t rather than size_t when either will do, as we prefer
3786 signed integers.
3787
903fe15d
PE
3788 * alloc.c: Integer signedness and overflow fixes.
3789 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3790 (__malloc_size_t): Default to size_t, not to int.
3791 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3792 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3793 Prefer ptrdiff_t to size_t when either would do, as we prefer
3794 signed integers.
3795 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3796 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3797 Now const. Initialize with values that are in range even if char
3798 is signed.
3799 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3800 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3801 These functions do the right thing with sizes > 2**32.
3802 (check_depth): Now ptrdiff_t, not int.
3803 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3804 Adjust to new way of storing sizes. Check for size overflow bugs
3805 in rest of code.
3806 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3807 slightly wrong anyway, as it missed one instance of
3808 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3809 (refill_memory_reserve): Omit needless cast to size_t.
3810 (mark_object_loop_halt): Mark as externally visible.
3811
ac82cc6a
PE
3812 * xselect.c: Integer signedness and overflow fixes.
3813 (Fx_register_dnd_atom, x_handle_dnd_message):
3814 Use ptrdiff_t, not size_t, since we prefer signed.
3815 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3816 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3817 x_dnd_atoms_size and x_dnd_atoms_length.
3818
c2d1e36d
PE
3819 * doprnt.c: Prefer signed to unsigned when either works.
3820 * eval.c (verror):
3821 * doprnt.c (doprnt):
3822 * lisp.h (doprnt):
3823 * xdisp.c (vmessage):
3824 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3825 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3826 prefer signed arithmetic to avoid comparison confusion.
3827 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3828 but is a bit tricky.
3829
0e926e56
PE
3830 Assume freestanding C89 headers, string.h, stdlib.h.
3831 * data.c, doprnt.c, floatfns.c, print.c:
3832 Include float.h unconditionally.
3833 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3834 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3835 * regex.c: Likewise for stddef.h, string.h.
3836 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3837 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3838 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3839 (STDC_HEADERS): Remove obsolete defines.
3840 * sysdep.c: Include limits.h unconditionally.
3841
9cfdb3ec
PE
3842 Assume support for memcmp, memcpy, memmove, memset.
3843 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3844 * regex.c (memcmp, memcpy):
3845 Remove; we assume C89 now.
3846
3847 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3848 (__malloc_safe_bcopy): Remove; no longer needed.
3849
cf950e6b 3850 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3851 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3852 well either way, and we prefer signed to unsigned.
3853
dbf38e02
LMI
38542011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3855
3856 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3857 closes the connection while we're reading (bug#9182).
3858
d6f0886c 38592011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3860
d6f0886c
JD
3861 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3862 are specified (Bug#9168).
24e0f6b1 3863
2eb1f9e6
PE
38642011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3865
3866 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3867 Found by GCC static checking and --with-wide-int on a 32-bit host.
3868
22381272 38692011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3870
3871 * xdisp.c (compute_display_string_pos): Fix logic of caching
3872 previous display string position. Initialize cached_prev_pos to
3873 -1. Fixes slow-down at the beginning of a buffer.
3874
f25e39b4
EZ
38752011-07-24 Eli Zaretskii <eliz@gnu.org>
3876
3877 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3878 for attrs[LFACE_FONTSET_INDEX].
3879
04c4b52e
PE
38802011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3881
3882 * xml.c (parse_region): Remove unused local
3883 that was recently introduced.
3884
c1734fbd
EZ
38852011-07-23 Eli Zaretskii <eliz@gnu.org>
3886
be18c5a5
EZ
3887 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3888 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3889
c1734fbd
EZ
3890 * xdisp.c (move_it_in_display_line_to): Record the best matching
3891 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3892 exit if none of the characters scanned was an exact match.
3893 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3894 when exact match is impossible due to invisible text, and the
3895 lines are truncated.
3896
a258d627
JD
38972011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3898
3899 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3900 for OSX >= 10.7.
3901
b6d5a689
EZ
39022011-07-22 Eli Zaretskii <eliz@gnu.org>
3903
0f74f785
EZ
3904 Fix a significant slow-down of cursor motion with C-n, C-p,
3905 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3906 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3907 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3908 (next_element_from_buffer): Call compute_stop_pos_backwards to
3909 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3910 base_level_stop.
3911 (reseat): Don't look for prev_stop, as that could mean a very long
3912 run.
3913 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3914 <cached_disp_overlay_modiff>: Cache for last found display string
3915 position.
551918c1 3916 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3917 about the same buffer in the same area of character positions, and
3918 the buffer wasn't changed since the time the display string
3919 position was cached.
551918c1 3920
b2d0c91a
EZ
39212011-07-22 Eli Zaretskii <eliz@gnu.org>
3922
3923 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3924 is an integer, which is important for empty lines. (Bug#9149)
3925
043604ee
CY
39262011-07-22 Chong Yidong <cyd@stupidchicken.com>
3927
3928 * frame.c (Fmodify_frame_parameters): In tty case, update the
3929 default face if necessary (Bug#4238).
3930
da4adb04
CY
39312011-07-21 Chong Yidong <cyd@stupidchicken.com>
3932
3933 * editfns.c (Fstring_to_char): No need to explain what a character
3934 is in the docstring (Bug#6576).
3935
9abd0532
LMI
39362011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3937
3938 * xml.c (parse_region): Make sure we always return a tree.
3939
36881d16
HK
39402011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3941
3942 * xml.c (parse_region): If a document contains only comments,
3943 return that, too.
3944
1e98674d
LMI
39452011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3946
3947 * xml.c (make_dom): Return comments, too.
3948
590bd467
PE
39492011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3950
3951 Port to OpenBSD.
3952 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3953 and the surrounding thread.
3954 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3955 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3956 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3957 timer goes off.
3958 * s/openbsd.h (BROKEN_SIGIO): Define.
3959 * unexelf.c (unexec) [__OpenBSD__]:
3960 Don't update the .mdebug section of the Alpha COFF symbol table.
3961
f41628b2
LMI
39622011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3963
3964 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3965 (bug#8460).
3966
b59b67c5
PE
39672011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3968
15e3a074
PE
3969 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3970 This fixes some race conditions on the permissions of any newly
3971 created file.
3972
41bed37d
PE
3973 * alloc.c (valid_pointer_p): Use pipe, not open.
3974 This fixes some permissions issues when debugging.
3975
b59b67c5
PE
3976 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3977 If fchown fails to set both uid and gid, try to set just gid,
3978 as that is sometimes allowed. Adjust the file's mode to eliminate
3979 setuid or setgid bits that are inappropriate if fchown fails.
3980
925a6be7
SM
39812011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3982
3983 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3984 to compare Lisp_Objects.
3985 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3986 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3987 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3988
52968808
AS
39892011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3990
0a6a104b
AS
3991 * lread.c (read_integer): Unread even EOF character.
3992 (read1): Likewise. Properly record start position of symbol.
3993
52968808
AS
3994 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3995 symbol character follows.
3996
9e381cdd
PE
39972011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3998
3999 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4000 This works around a problem with the previous change to Fcopy_file.
4001 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4002 and without this change, GCC might complain about discarding
4003 fchown's return value.
4004
b5641435
JB
40052011-07-16 Juanma Barranquero <lekktu@gmail.com>
4006
4007 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4008
a8031457
PE
40092011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4010
4011 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4012
dd889327
LMI
40132011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4014
750c33f7
LMI
4015 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4016 it's used from the C level.
4017
dd889327
LMI
4018 * process.c: Use the same condition for POLL_FOR_INPUT in both
4019 keyboard.c and process.c (bug#1858).
4020
87e86684
LM
40212011-07-09 Lawrence Mitchell <wence@gmx.li>
4022
4023 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4024 (Fgnutls_boot): Use it.
4025
64348f40
AS
40262011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4027
4028 * doc.c (Fsubstitute_command_keys): Revert last change.
4029
1d698799
LMI
40302011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4031
f863868c
LMI
4032 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4033 quotes the next character, and doesn't affect other longer
4034 sequences (bug#8935).
4035
1d698799
LMI
4036 * lread.c (syms_of_lread): Clarify that is isn't only
4037 `eval-buffer' and `eval-defun' that's affected by
4038 `lexical-binding' (bug#8460).
4039
aa4b6df6
EZ
40402011-07-15 Eli Zaretskii <eliz@gnu.org>
4041
4042 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4043 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4044
5d856da6
PE
40452011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4046
ad6042bb
PE
4047 Fix minor problems found by static checking.
4048 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4049 (elsz): Now a signed constant, not a size_t var. We prefer signed
4050 types to unsigned, to avoid integer comparison confusion. Without
4051 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4052 "cannot optimize loop, the loop counter may overflow", a symptom
4053 of the confusion.
f00bbb22 4054 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4055 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4056
6468f31c
LMI
40572011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4058
49080b10
LMI
4059 * search.c (Fre_search_backward): Mention `case-fold-search' in
4060 all the re_search_* functions (bug#8138).
4061
6468f31c
LMI
4062 * keyboard.c (Fopen_dribble_file): Document when the file is
4063 closed (bug#8056).
4064
c965adc5
EZ
40652011-07-14 Eli Zaretskii <eliz@gnu.org>
4066
df9733bf
EZ
4067 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4068 bidi_cache_idx.
4069
0bb23927
EZ
4070 Support bidi reordering of display and overlay strings.
4071 * xdisp.c (compute_display_string_pos)
4072 (compute_display_string_end): Accept additional argument STRING.
4073 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4074 (reseat_to_string): Initialize bidi_it->string.s and
4075 bidi_it->string.schars.
4076 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4077 NULL (avoids a crash in bidi_paragraph_init).
4078 Initialize itb.string.lstring.
0bb23927
EZ
4079 (init_iterator): Call bidi_init_it only of a valid
4080 buffer position was specified. Initialize paragraph_embedding to
4081 L2R.
4082 (reseat_to_string): Initialize the bidi iterator.
4083 (display_string): If we need to ignore text properties of
4084 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4085 original value of -1 will not work with bidi.)
4086 (compute_display_string_pos): First arg is now struct
4087 `text_pos *'; all callers changed. Support display properties on
4088 Lisp strings.
4089 (compute_display_string_end): Support display properties on Lisp
4090 strings.
4091 (init_iterator, reseat_1, reseat_to_string): Initialize the
4092 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4093 when iterating on a string not from display properties).
640c8776
SM
4094 (compute_display_string_pos, compute_display_string_end):
4095 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4096 arrow keys.
4097 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4098 base_level_stop; instead, set base_level_stop to BEGV.
4099 Fixes crashes in vertical-motion.
0bb23927
EZ
4100 (next_element_from_buffer): Improve commentary for when
4101 the iterator is before prev_stop.
4102 (init_iterator): Initialize bidi_p from the default value of
4103 bidi-display-reordering, not from buffer-local value. Use the
4104 buffer-local value only if initializing for buffer iteration.
4105 (handle_invisible_prop): Support invisible properties on strings
4106 that are being bidi-reordered.
4107 (set_iterator_to_next): Support bidi reordering of C strings and
4108 Lisp strings.
4109 (next_element_from_string): Support bidi reordering of Lisp
4110 strings.
4111 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4112 (display_string): Support display of R2L glyph rows.
4113 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4114 (init_iterator): Don't initialize it->bidi_p for strings
4115 here.
4116 (reseat_to_string): Initialize it->bidi_p for strings here.
4117 (next_element_from_string, next_element_from_c_string)
4118 (next_element_from_buffer): Add xassert's for correspondence
4119 between IT's object being iterated and it->bidi_it.string
4120 structure.
4121 (face_before_or_after_it_pos): Support bidi iteration.
4122 (next_element_from_c_string): Handle the case of the first string
4123 character that is not the first one in the visual order.
4124 (get_visually_first_element): New function, refactored from common
4125 parts of next_element_from_buffer, next_element_from_string, and
4126 next_element_from_c_string.
4127 (tool_bar_lines_needed, redisplay_tool_bar)
4128 (display_menu_bar): Force left-to-right direction. Add a FIXME
4129 comment for making that be controlled by a user option.
4130 (push_it, pop_it): Save and restore the state of the
4131 bidi iterator. Save and restore the bidi_p flag.
4132 (pop_it): Iterate out of display property for string iteration as
4133 well.
4134 (iterate_out_of_display_property): Support iteration over strings.
4135 (handle_single_display_spec): Set up it->bidi_it for iteration
4136 over a display string, and call bidi_init_it.
4137 (handle_single_display_spec, next_overlay_string)
4138 (get_overlay_strings_1, push_display_prop): Set up the bidi
4139 iterator for displaying display or overlay strings.
4140 (forward_to_next_line_start): Don't use the shortcut if
4141 bidi-iterating.
4142 (back_to_previous_visible_line_start): If handle_display_prop
4143 pushed the iterator stack, restore the internal state of the bidi
4144 iterator by calling bidi_pop_it same number of times.
4145 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4146 and we are bidi-iterating, don't decrement the iterator position;
4147 instead, set the first_elt flag in the bidi iterator, to produce
4148 the same effect.
4149 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4150 (push_display_prop): xassert that we are iterating a buffer.
4151 (push_it, pop_it): Save and restore paragraph_embedding member.
4152 (handle_single_display_spec, next_overlay_string)
4153 (get_overlay_strings_1, reseat_1, reseat_to_string)
4154 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4155 correctly. Don't assume unibyte strings are not bidi-reordered.
4156 (compute_display_string_pos)
4157 (compute_display_string_end): Fix handling the case of C string.
4158 (push_it, pop_it): Save and restore from_disp_prop_p.
4159 (handle_single_display_spec, push_display_prop): Set the
4160 from_disp_prop_p flag.
4161 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4162 (pop_it): Call iterate_out_of_display_property only if we are
4163 popping after iteration over a string that came from a display
4164 property. Fix a typo in popping stretch info. Add an assertion
4165 for verifying that the iterator position is in sync with the bidi
4166 iterator.
4167 (handle_single_display_spec, get_overlay_strings_1)
4168 (push_display_prop): Fix initialization of paragraph direction for
4169 string when that of the parent object is not yet determined.
4170 (reseat_1): Call bidi_init_it to resync the bidi
4171 iterator with IT's position. (Bug#7616)
4172 (find_row_edges): If ROW->start.pos gives position
4173 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4174 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4175 Reset the from_disp_prop_p flag.
4176 (SAVE_IT, RESTORE_IT): New macros.
4177 (pos_visible_p, face_before_or_after_it_pos)
4178 (back_to_previous_visible_line_start)
4179 (move_it_in_display_line_to, move_it_in_display_line)
4180 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4181 (try_scrolling, redisplay_window, display_line): Use them when
4182 saving a temporary copy of the iterator and restoring it back.
4183 (back_to_previous_visible_line_start, reseat_1)
4184 (init_iterator): Empty the bidi cache "stack".
4185 (move_it_in_display_line_to): If iterator ended up at
4186 EOL, but we never saw any buffer positions smaller than
4187 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4188 motion in bidi-reordered lines.
4189 (move_it_in_display_line_to): Record prev_method and prev_pos
4190 immediately before the call to set_iterator_to_next. Fixes cursor
4191 motion in bidi-reordered lines with stretch glyphs and strings
4192 displayed in margins. (Bug#8133) (Bug#8867)
4193 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4194 TO_CHARPOS.
640c8776
SM
4195 (pos_visible_p): Support positions in bidi-reordered lines.
4196 Save and restore bidi cache.
0bb23927
EZ
4197
4198 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4199 (bidi_paragraph_info): Delete unused struct.
4200 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4201 (bidi_cache_start): New variable.
4202 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4203 to zero.
4204 (bidi_cache_fetch_state, bidi_cache_search)
4205 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4206 (bidi_cache_find, bidi_peek_at_next_level)
4207 (bidi_level_of_next_char, bidi_find_other_level_edge)
4208 (bidi_move_to_visually_next): Compare cache index with
4209 bidi_cache_start rather than with zero.
4210 (bidi_fetch_char): Accept new argument STRING; all callers
4211 changed. Support iteration over a string. Support strings with
4212 display properties. Support unibyte strings. Fix the type of
4213 `len' according to what STRING_CHAR_AND_LENGTH expects.
4214 (bidi_paragraph_init, bidi_resolve_explicit_1)
4215 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4216 (bidi_level_of_next_char, bidi_move_to_visually_next):
4217 Support iteration over a string.
0bb23927
EZ
4218 (bidi_set_sor_type, bidi_resolve_explicit_1)
4219 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4220 can now be zero (for strings); special values 0 and -1 were
4221 changed to -1 and -2, respectively.
4222 (bidi_char_at_pos): New function.
4223 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4224 Call it instead of FETCH_MULTIBYTE_CHAR.
4225 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4226 initialized to valid values.
4227 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4228 values.
4229 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4230 the test for valid cached positions. Fix the logic for looking up
4231 the sentinel state in the cache. GCPRO the Lisp string we are
4232 iterating.
4233 (bidi_push_it, bidi_pop_it): New functions.
4234 (bidi_initialize): Initialize the bidi cache start stack pointer.
4235 (bidi_cache_ensure_space): New function, refactored from part of
4236 bidi_cache_iterator_state. Don't assume the required size is just
4237 one BIDI_CACHE_CHUNK away.
4238 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4239 (bidi_count_bytes, bidi_char_at_pos): New functions.
4240 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4241 always valid if bidi_cache_idx is valid.
4242 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4243 is valid if it's going to be used.
4244 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4245 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4246 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4247 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4248 (bidi_find_other_level_edge, bidi_cache_start_stack):
4249 All variables related to cache indices are now EMACS_INT.
c965adc5 4250
0bb23927
EZ
4251 * dispextern.h (struct bidi_string_data): New structure.
4252 (struct bidi_it): New member `string'. Make flag members be 1-bit
4253 fields, and put them last in the struct.
640c8776
SM
4254 (compute_display_string_pos, compute_display_string_end):
4255 Update prototypes.
0bb23927
EZ
4256 (bidi_push_it, bidi_pop_it): Add prototypes.
4257 (struct iterator_stack_entry): New members bidi_p,
4258 paragraph_embedding, and from_disp_prop_p.
4259 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4260 (bidi_shelve_cache, bidi_unshelve_cache):
4261 Declare prototypes.
0bb23927
EZ
4262
4263 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4264 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4265 and vector-like objects.
4266
4267 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4268 cache around display iteration.
4269
4270 * window.c (Fwindow_end, window_scroll_pixel_based)
4271 (displayed_window_lines, Frecenter): Save and restore the bidi
4272 cache around display iteration.
4273
3bbd2265
LMI
42742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4275
4276 * editfns.c (Fdelete_region): Clarify the use of the named
4277 parameters (bug#6788).
4278
adc47434
MR
42792011-07-14 Martin Rudalics <rudalics@gmx.at>
4280
4281 * indent.c (Fvertical_motion): Set and restore w->pointm when
4282 saving and restoring the window's buffer (Bug#9006).
4283
837c31f8
LMI
42842011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4285
4286 * editfns.c (Fstring_to_char): Clarify just what is returned
4287 (bug#6576). Text by Eli Zaretskii.
4288
ac389d0c
JB
42892011-07-13 Juanma Barranquero <lekktu@gmail.com>
4290
4291 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4292
0be0ce47
EZ
42932011-07-13 Eli Zaretskii <eliz@gnu.org>
4294
4295 * buffer.c (mmap_find): Fix a typo.
4296
cd18e7e3
JB
42972011-07-13 Johan Bockgård <bojohan@gnu.org>
4298
4299 Fix execution of x selection hooks.
4300 * xselect.c (Qx_lost_selection_functions)
4301 (Qx_sent_selection_functions): New vars.
4302 (syms_of_xselect): DEFSYM them.
4303 (x_handle_selection_request): Pass Qx_sent_selection_functions
4304 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4305 (x_handle_selection_clear,x_clear_frame_selections):
4306 Pass Qx_lost_selection_functions rather than
4307 Vx_lost_selection_functions to Frun_hook_with_args.
4308
47ea7f44
PE
43092011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4310
ac389d0c 4311 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4312 The old code sometimes used this field without initializing it.
4313
47ea7f44
PE
4314 * alloc.c (gc_sweep): Don't read past end of array.
4315 In theory, the old code could also have corrupted Emacs internals,
4316 though it'd be very unlikely.
4317
bc985c87
AS
43182011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4319
4320 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4321 argument. (Bug#4026)
bc985c87 4322
0cf34688
LMI
43232011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4324
b3dadd76
LMI
4325 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4326 key" (bug#4257).
4327
0cf34688
LMI
4328 * window.c (Fset_window_start): Doc fix (bug#4199).
4329 (Fset_window_hscroll): Ditto.
4330
270768cd
PE
43312011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4332
077e3dda 4333 Fix minor new problems caught by GCC 4.6.1.
270768cd 4334 * term.c (init_tty): Remove unused local.
490011a6 4335 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4336 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4337 not used otherwise.
270768cd 4338
b1f58454
CY
43392011-07-12 Chong Yidong <cyd@stupidchicken.com>
4340
4341 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4342
22b9578d
LMI
43432011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4344
6e70ab07
LMI
4345 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4346 are the mini-buffer and the echo area (bug#3320).
4347
22b9578d
LMI
4348 * term.c (init_tty): Remove support for supdup, c10 and perq
4349 terminals, which are no longer supported (bug#1482).
4350
8974cc9f
JB
43512011-07-10 Johan Bockgård <bojohan@gnu.org>
4352
4353 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4354
a560d974
JD
43552011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4356
4357 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4358 for non-popups (Bug#3642).
4359
1dae0f0a
AS
43602011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4361
268c2c36 4362 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4363 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4364 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4365 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4366 * data.c (fmod): Likewise.
4367 * dispnew.c (swap_glyphs_in_rows): Likewise.
4368 * emacs.c (memory_warning_signal): Likewise.
4369 * floatfns.c (float_error): Likewise.
4370 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4371 (otf_open, font_otf_capability, generate_otf_features)
4372 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4373 Likewise.
4374 * image.c (pbm_read_file): Likewise.
4375 * indent.c (string_display_width): Likewise.
4376 * intervals.c (check_for_interval, search_for_interval)
4377 (inc_interval_count, count_intervals, root_interval)
4378 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4379 * lread.c (defalias): Likewise.
268c2c36 4380 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4381 * regex.c (set_image_of_range_1, set_image_of_range)
4382 (regex_grow_registers): Likewise.
4383 * sysdep.c (strerror): Likewise.
4384 * termcap.c (valid_filename_p, tprint, main): Likewise.
4385 * tparam.c (main): Likewise.
4386 * unexhp9k800.c (run_time_remap, save_data_space)
4387 (update_file_ptrs, read_header, write_header, calculate_checksum)
4388 (copy_file, copy_rest, display_header): Likewise.
4389 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4390 Likewise.
4391 * xdisp.c (check_it): Likewise.
4392 * xfaces.c (register_color, unregister_color, unregister_colors):
4393 Likewise.
4394 * xfns.c (print_fontset_result): Likewise.
4395 * xrdb.c (member, fatal, main): Likewise.
4396
99033785
PE
43972011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4398
4399 Fix minor problems found by static checking (Bug#9031).
4400 * chartab.c (char_table_set_range, map_sub_char_table):
4401 Remove unused locals.
4402 (uniprop_table): Now static.
4403 * composite.c (_work_char): Remove unused static var.
4404
9cb2ac56
JB
44052011-07-09 Juanma Barranquero <lekktu@gmail.com>
4406
4407 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4408
f25661f0
JD
44092011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4410
4411 * gtkutil.c (qttip_cb): Remove code without function.
4412
8278c4fe
EZ
44132011-07-09 Eli Zaretskii <eliz@gnu.org>
4414
4415 * w32.c (pthread_sigmask): New stub.
4416
1692ae2d 44172011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4418
8a6ebd58 4419 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4420 sigprocmask is portable only for single-threaded applications, and
4421 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4422 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4423 (LIBES): Use it.
4424 * callproc.c (Fcall_process):
4425 * process.c (create_process):
4426 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4427 Use pthread_sigmask, not sigprocmask.
123403e4 4428
1b854618
JD
44292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4430
4431 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4432 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4433 wrong (Bug#8591).
4434
3fe4b549
JD
44352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4436
0ce7e563
JD
4437 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4438 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4439 (xg_hide_tooltip): Fix comment.
4440
3fe4b549
JD
4441 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4442 in registerServicesMenuSendTypes.
4443 (validRequestorForSendType): Don't check ns_return_types.
4444
4445 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4446 ns_return_type.
4447
5df75e47
JR
44482011-07-08 Jason Rumney <jasonr@gnu.org>
4449
22610910
JR
4450 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4451 SH_SHOW for hidden windows (Bug#5482).
4452
5df75e47
JR
4453 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4454 frame struct members of non-existent frames (Bug#6284).
4455
699c10bd
JD
44562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4457
4393663b
JD
4458 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4459 variable firstTime not needed on OSX >= 10.6.
4460 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4461 >= 10.5. Use setKnobProportion, setDoubleValue.
4462
4463 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4464 (MAC_OS_X_VERSION_10_5): Define if not defined.
4465 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4466 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4467 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4468
4469 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4470 cString and lossyCString on OSX >= 10.4
4471
58179cce 4472 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4473 sizeToFit on OSX >= 10.2.
4474
4475 * nsimage.m (allocInitFromFile): Don't use deprecated method
4476 bestRepresentationForDevice on OSX >= 10.6.
4477
4478 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4479 to avoid warning.
4480
4481 * emacs.c: Declare unexec_init_emacs_zone.
4482
a63e0781
JD
4483 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4484
699c10bd
JD
4485 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4486
4487 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4488 on svcsMenu (Bug#8842).
4489
4490 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4491 ns_return_types.
4492 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4493
4494 * nsterm.m (QUTF8_STRING): Declare.
4495 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4496 (validRequestorForSendType): Return type is (id).
4497 Change indexOfObjectIdenticalTo to indexOfObject.
4498 Check if we have local selection before returning self (Bug#8842).
4499 (writeSelectionToPasteboard): Put local selection into paste board
4500 if we have a local selection (Bug#8842).
4501 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4502
4503 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4504 (ns_get_local_selection): Declare.
4505
54e10184
LMI
45062011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4507
9888ff71
LMI
4508 * keymap.c (describe_map_tree): Don't insert a double newline at
4509 the end of the buffer (bug#1169) and return whether we inserted
4510 something.
4511
54e10184
LMI
4512 * callint.c (Fcall_interactively): Change "reading args" to
4513 "providing args" to try to clarify what it does (bug#1010).
4514
15fa4783
KH
45152011-07-07 Kenichi Handa <handa@m17n.org>
4516
4517 * composite.c (composition_compute_stop_pos): Ignore a static
4518 composition starting before CHARPOS (Bug#8915).
4519
4520 * xdisp.c (handle_composition_prop): Likewise.
4521
a8815b00
EZ
45222011-07-07 Eli Zaretskii <eliz@gnu.org>
4523
4524 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4525 (Bug#9015)
4526
ef7b981d 45272011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4528
4529 * character.h (unicode_category_t): New enum type.
4530
4531 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4532 (Qchar_code_property_table): New variable.
4533 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4534 (UNIPROP_COMPRESSED_FORM_P): New macros.
4535 (char_table_ascii): Uncompress the compressed values.
4536 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4537 Uncompress the compressed values.
ac389d0c 4538 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4539 (char_table_ref_and_range): Uncompress the compressed values.
4540 (sub_char_table_set): New arg is_uniprop. Callers changed.
4541 Uncompress the compressed values.
4542 (sub_char_table_set_range): Args changed. Callers changed.
4543 (char_table_set_range): Adjuted for the above change.
4544 (map_sub_char_table): Delete args default_val and parent. Add arg
4545 top. Give decoded values to a Lisp function.
640c8776 4546 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4547 values to a Lisp function. Gcpro more variables.
4548 (uniprop_table_uncompress)
4549 (uniprop_decode_value_run_length): New functions.
4550 (uniprop_decoder, uniprop_decoder_count): New variables.
4551 (uniprop_get_decoder, uniprop_encode_value_character)
4552 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4553 New functions.
4554 (uniprop_encoder, uniprop_encoder_count): New variables.
4555 (uniprop_get_encoder, uniprop_table)
4556 (Funicode_property_table_internal, Fget_unicode_property_internal)
4557 (Fput_unicode_property_internal): New functions.
4558 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4559 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4560 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4561 char-code-property-alist.
4562
640c8776 4563 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4564 Vunicode_category_table.
4565
640c8776 4566 * font.c (font_range): Adjust for the change of
c805dec0
KH
4567 Vunicode_category_table.
4568
76b397fb
DN
45692011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4570
4571 * m/iris4d.h: Remove file, move contents ...
4572 * s/irix6-5.h: ... here.
4573
22b4128e
PE
45742011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4575
4576 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4577 * alloc.c (mark_buffer):
4578 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4579 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4580 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4581 This isn't true in general, and it's particularly not true
4582 if Emacs is configured with --with-wide-int.
4583 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4584 New macros, used in the buffer.c change.
4585
869795d6
JD
45862011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4587
4588 * xsettings.c: Use both GConf and GSettings if both are available.
4589 (store_config_changed_event): Add comment.
4590 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4591 (store_tool_bar_style_changed): New functions.
5e617bc2 4592 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4593 (struct xsettings): Move font inside HAVE_XFT.
4594 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4595 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4596 Move inside HAVE_XFT.
640c8776 4597 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4598 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4599 also.
4600 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4601 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4602 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4603 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4604 (parse_settings): Move check for font inside HAVE_XFT.
4605 (read_settings, apply_xft_settings): Add comment.
4606 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4607 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4608 call store_font_name_changed.
4609 (xft_settings_event): Add comment.
4610 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4611 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4612 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4613 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4614 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4615 (xsettings_get_system_font, xsettings_get_system_normal_font):
4616 Add comment.
869795d6 4617
d8ed26bd
PE
46182011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4619
4620 Random fixes. E.g., (random) never returned negative values.
4621 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4622 subseconds part to the entropy, as that's a bit more random.
4623 Prefer signed to unsigned, since the signedness doesn't matter and
4624 in general we prefer signed. When given a limit, use a
4625 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4626 latter isn't right if USE_2_TAGS_FOR_INTS.
4627 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4628 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4629
cabf1cac
SM
46302011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4631
4632 * textprop.c (text_property_stickiness):
4633 Obey Vtext_property_default_nonsticky.
4634 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4635 * w32fns.c (syms_of_w32fns):
4636 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4637
6e9b2be9
PE
46382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4639
4640 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4641 This is more efficient than Ffile_directory_p and avoids a minor race.
4642
90186c68
LMI
46432011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4644
7c301272
LMI
4645 * buffer.c (Foverlay_put): Say what the return value is
4646 (bug#7835).
4647
c4f2d8d4
LMI
4648 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4649 is a directory before asking whether to use the file name
4650 (bug#7564).
ad637907
LMI
4651 (barf_or_query_if_file_exists): Make the "File is a directory"
4652 error be more correct.
c4f2d8d4 4653
90186c68
LMI
4654 * fns.c (Frequire): Remove the mention of the .gz files, since
4655 that's installation-specific, but keep the mention of
4656 `get-load-suffixes'.
4657
da64016e
PE
46582011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4659
4660 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4661 Report string overflow if the output is too long.
4662
7d47b580
JB
46632011-07-04 Juanma Barranquero <lekktu@gmail.com>
4664
a555cb87
JB
4665 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4666 (syms_of_gnutls): Remove duplicate DEFSYM for
4667 Qgnutls_bootprop_verify_hostname_error, an error for
4668 Qgnutls_bootprop_verify_error (which is no longer used).
4669
7d47b580
JB
4670 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4671 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4672 Also (re)move comments that are misplaced or no longer relevant.
4673
1e49bfab
LMI
46742011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4675
4676 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4677
1485f4c0
CY
46782011-07-03 Chong Yidong <cyd@stupidchicken.com>
4679
4680 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4681 and background color parameters if they have been changed.
4682
a9ab721e
LMI
46832011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4684
4685 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4686
cf7cff57
PE
46872011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4688
2e13213d
PE
4689 * xsettings.c (SYSTEM_FONT): Define only when used.
4690 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4691
cf7cff57
PE
4692 * keymap.c (access_keymap_1): Now static.
4693
7a8e04f7
CY
46942011-07-02 Chong Yidong <cyd@stupidchicken.com>
4695
4696 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4697 leave any prefix arg for the up event (Bug#1586).
4698
61352f62
LMI
46992011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4700
69bb1ef7
LMI
4701 * lread.c (syms_of_lread): Mention single symbols defined by
4702 `defvar' or `defconst' (bug#7154).
4703
61352f62 4704 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4705 (Frequire): Mention get-load-suffixes.
61352f62 4706
28545e04
MR
47072011-07-02 Martin Rudalics <rudalics@gmx.at>
4708
4709 * window.h (window): Remove clone_number slot.
4710 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4711 Remove.
4712 (make_parent_window, make_window, saved_window)
4713 (Fset_window_configuration, save_window_save): Don't deal with
4714 clone numbers.
4715 * buffer.c (Qclone_number): Remove declaration.
4716 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4717
3349e122
SM
47182011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4719
4720 Add multiple inheritance to keymaps.
4721 * keymap.c (Fmake_composed_keymap): New function.
4722 (Fset_keymap_parent): Simplify.
4723 (fix_submap_inheritance): Remove.
4724 (access_keymap_1): New function extracted from access_keymap to handle
4725 embedded parents and handle lists of maps.
4726 (access_keymap): Use it.
4727 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4728 (Fcopy_keymap): Handle embedded parents.
4729 (Fcommand_remapping, define_as_prefix): Simplify.
4730 (Fkey_binding): Simplify.
4731 (syms_of_keymap): Move minibuffer-local-completion-map,
4732 minibuffer-local-filename-completion-map,
4733 minibuffer-local-must-match-map, and
4734 minibuffer-local-filename-must-match-map to Elisp.
4735 (syms_of_keymap): Defsubr make-composed-keymap.
4736 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4737 (parse_menu_item): Trivial simplification.
4738
3279eb87
GM
47392011-07-01 Glenn Morris <rgm@gnu.org>
4740
4741 * Makefile.in (SETTINGS_LIBS): Fix typo.
4742
4550efdf
KI
47432011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4744
4745 * coding.c (Fencode_coding_string): Record the last coding system
4746 used, as the function doc string says (bug#8738).
4747
0949d2b6
JD
47482011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4749
4750 * xsettings.c (store_monospaced_changed): Take new font as arg and
4751 check for change against current_mono_font.
4752 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4753 (emacs_settings_constructor, emacs_settings_get_property)
4754 (emacs_settings_set_property, emacs_settings_class_init)
4755 (emacs_settings_init, gsettings_obj): Remove.
4756 (something_changedCB): New function for HAVE_GSETTINGS.
4757 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4758 with value as argument.
4759 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4760 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4761 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4762 "changed".
4763
4764 * xgselect.c: Add defined (HAVE_GSETTINGS).
4765 (xgselect_initialize): Ditto.
4766
4767 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4768 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4769 xg_select.
4770
bbc6b304
PE
47712011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4772
4773 * eval.c (struct backtrace): Simplify and port the data structure.
4774 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4775 signed bit field, as this assumption is not portable and it makes
4776 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4777 "char debug_on_exit : 1" as this is not portable either; instead,
4778 use the portable "unsigned int debug_on_exit : 1". Remove unused
4779 member evalargs. Remove obsolete comments about cc bombing out.
4780
9851bfc5
JD
47812011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4782
51bb811f 4783 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4784 Let HAVE_GSETTINGS override HAVE_GCONF.
4785 (store_monospaced_changed): New function.
4786 (EMACS_SETTINGS): A new type derived from GObject to handle
4787 GSettings notifications.
4788 (emacs_settings_constructor, emacs_settings_get_property)
4789 (emacs_settings_set_property, emacs_settings_class_init):
4790 New functions.
4791 (gsettings_client, gsettings_obj): New variables.
4792 (GSETTINGS_SCHEMA): New define.
4793 (something_changedCB): Call store_monospaced_changed.
4794 (init_gsettings): New function.
4795 (xsettings_initialize): Call init_gsettings.
4796 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4797 to NULL.
4798
640c8776 4799 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4800 GCONF_CFLAGS/LIBS.
4801
5386012d
MR
48022011-06-29 Martin Rudalics <rudalics@gmx.at>
4803
4804 * window.c (resize_root_window, grow_mini_window)
4805 (shrink_mini_window): Rename Qresize_root_window to
4806 Qwindow_resize_root_window and Qresize_root_window_vertically to
4807 Qwindow_resize_root_window_vertically.
4808
f13e0b08
PE
48092011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4810
4811 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4812
94515237
JB
48132011-06-27 Juanma Barranquero <lekktu@gmail.com>
4814
4815 * makefile.w32-in: Redesign dependencies so they reflect more
4816 clearly which files are directly included by each source file,
4817 and not through other includes.
4818
e43b6e43
MR
48192011-06-27 Martin Rudalics <rudalics@gmx.at>
4820
4821 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4822 (sort_overlays, overlay_strings): When an overlay's clone number
4823 matches the window's clone number process the overlay even if
4824 the overlay's window property doesn't match the current window.
4825
d68443dc
MR
4826 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4827 (Fwindow_hchild): Rename to Fwindow_left_child.
4828 (Fwindow_next): Rename to Fwindow_next_sibling.
4829 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4830 (resize_window_check): Rename to window_resize_check.
4831 (resize_window_apply): Rename to window_resize_apply.
4832 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4833 (Fdelete_other_windows_internal, resize_frame_windows)
4834 (Fsplit_window_internal, Fdelete_window_internal)
4835 (grow_mini_window, shrink_mini_window)
4836 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4837
c7e73be5
JD
48382011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4839
4840 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4841 (emacs_fixed_set_min_size): Remove.
4842 (emacs_fixed_new): Take frame as argument.
4843
4844 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4845 (_EmacsFixedPrivate): Remove minwidth/height.
4846 Add struct frame *f.
4847 (emacs_fixed_init): Initialize priv->f.
4848 (get_parent_class, emacs_fixed_set_min_size): Remove.
4849 (emacs_fixed_new): Set priv->f to argument.
4850 (emacs_fixed_get_preferred_width)
4851 (emacs_fixed_get_preferred_height): Use min_width/height from
4852 frames size_hint to set minimum and natural (Bug#8919).
4853 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4854 and use min_width/height from frames size_hint to set
4855 min_width/height (Bug#8919).
4856
4857 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4858 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4859 Fix indentation.
c7e73be5 4860
cf99dcf8
EZ
48612011-06-26 Eli Zaretskii <eliz@gnu.org>
4862
4863 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4864 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4865 called at ZV.
4866
029529ac
CY
48672011-06-26 Chong Yidong <cyd@stupidchicken.com>
4868
4869 * process.c (wait_reading_process_output): Bypass select if
4870 waiting for a cell while ignoring keyboard input, and input is
4871 pending. Suggested by Jan Djärv (Bug#8869).
4872
7a7ef429
PE
48732011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4874
4875 Use gnulib's dup2 module instead of rolling our own.
4876 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4877
11fdef7d 48782011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4879
4880 * dispnew.c (scrolling_window): Before scrolling, turn off a
4881 mouse-highlight in the window being scrolled.
4882
cd3520a4
JB
48832011-06-24 Juanma Barranquero <lekktu@gmail.com>
4884
4885 Move DEFSYM to lisp.h and use everywhere.
4886
4887 * character.h (DEFSYM): Move declaration...
4888 * lisp.h (DEFSYM): ...here.
4889
4890 * gnutls.c:
4891 * minibuf.c:
4892 * w32menu.c:
4893 * w32proc.c:
4894 * w32select.c: Don't include character.h.
4895
4896 * alloc.c (syms_of_alloc):
4897 * buffer.c (syms_of_buffer):
4898 * bytecode.c (syms_of_bytecode):
4899 * callint.c (syms_of_callint):
4900 * casefiddle.c (syms_of_casefiddle):
4901 * casetab.c (init_casetab_once):
4902 * category.c (init_category_once, syms_of_category):
4903 * ccl.c (syms_of_ccl):
4904 * cmds.c (syms_of_cmds):
4905 * composite.c (syms_of_composite):
4906 * dbusbind.c (syms_of_dbusbind):
4907 * dired.c (syms_of_dired):
4908 * dispnew.c (syms_of_display):
4909 * doc.c (syms_of_doc):
4910 * editfns.c (syms_of_editfns):
4911 * emacs.c (syms_of_emacs):
4912 * eval.c (syms_of_eval):
4913 * fileio.c (syms_of_fileio):
4914 * fns.c (syms_of_fns):
4915 * frame.c (syms_of_frame):
4916 * fringe.c (syms_of_fringe):
4917 * insdel.c (syms_of_insdel):
4918 * keymap.c (syms_of_keymap):
4919 * lread.c (init_obarray, syms_of_lread):
4920 * macros.c (syms_of_macros):
4921 * msdos.c (syms_of_msdos):
4922 * print.c (syms_of_print):
4923 * process.c (syms_of_process):
4924 * search.c (syms_of_search):
4925 * sound.c (syms_of_sound):
4926 * syntax.c (init_syntax_once, syms_of_syntax):
4927 * terminal.c (syms_of_terminal):
4928 * textprop.c (syms_of_textprop):
4929 * undo.c (syms_of_undo):
4930 * w32.c (globals_of_w32):
4931 * window.c (syms_of_window):
4932 * xdisp.c (syms_of_xdisp):
4933 * xfaces.c (syms_of_xfaces):
4934 * xfns.c (syms_of_xfns):
4935 * xmenu.c (syms_of_xmenu):
4936 * xsettings.c (syms_of_xsettings):
4937 * xterm.c (syms_of_xterm): Use DEFSYM.
4938
4228cf16
TZ
49392011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4940
cd3520a4 4941 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4942
7fcccf1e
PE
49432011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4944
7efb4e0e
PE
4945 Integer and buffer overflow fixes (Bug#8873).
4946
ff5844ad
PE
4947 * print.c (printchar, strout): Check for string overflow.
4948 (PRINTPREPARE, printchar, strout):
4949 Don't set size unless allocation succeeds.
4950
90532f02
PE
4951 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4952 for sizes. Check for string overflow more accurately.
4953 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4954
6d84508d
PE
4955 * macros.c: Integer and buffer overflow fixes.
4956 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4957 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4958 Use ptrdiff_t, not int, for sizes.
4959 Don't increment bufsize until after realloc succeeds.
4960 Check for size-calculation overflow.
4961 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4962
437b2cb4
PE
4963 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4964
8b9ac8b4
PE
4965 * lread.c: Integer overflow fixes.
4966 (read_integer): Radix is now EMACS_INT, not int,
4967 to improve quality of diagnostics for out-of-range radices.
4968 Calculate buffer size correctly for out-of-range radices.
4969 (read1): Check for integer overflow in radices, and in
4970 read-circle numbers.
82cb60d3
PE
4971 (read_escape): Avoid int overflow.
4972 (Fload, openp, read_buffer_size, read1)
4973 (substitute_object_recurse, read_vector, read_list, map_obarray):
4974 Use ptrdiff_t, not int, for sizes.
4975 (read1): Use EMACS_INT, not int, for sizes.
20270765 4976 Check for size overflow.
8b9ac8b4 4977
7fcccf1e
PE
4978 * image.c (cache_image): Check for size arithmetic overflow.
4979
bfbbd7e7
PE
4980 * lread.c: Integer overflow issues.
4981 (saved_doc_string_size, saved_doc_string_length)
4982 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4983 Now ptrdiff_t, not int.
4984 (read1): Don't assume doc string length fits in int. Check for
4985 out-of-range doc string lengths.
4986 (read_list): Don't assume file position fits in int.
39019e54 4987 (read_escape): Check for hex character overflow.
bfbbd7e7 4988
4e323265
LL
49892011-06-22 Leo Liu <sdl.web@gmail.com>
4990
4991 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4992 Move to minibuffer.el.
4993
85fece3e
PE
49942011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4995
20b84ce9 4996 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4997 The following patches are for when GLYPH_DEBUG && !XASSERT.
4998 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4999 * dispnew.c (flush_stdout):
5000 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5001 Mark as externally visible.
5002 * dispnew.c (check_window_matrix_pointers): Now static.
5003 * dispnew.c (window_to_frame_vpos):
5004 * xfns.c (unwind_create_frame):
5005 * xterm.c (x_check_font): Remove unused local.
5006 * scroll.c (CHECK_BOUNDS):
5007 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5008 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5009 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5010 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5011 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5012 Now static.
5013 (debug_method_add): Use va_list and vsprintf rather than relying
5014 on undefined behavior with wrong number of arguments.
5015 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5016 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5017 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5018 since we're not interested in debugging glyphs with old libraries.
5019 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5020 GCC 4.6.0's static checking.
5021
0766b489
PE
50222011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5023
31fd4b32
PE
5024 Integer overflow and signedness fixes (Bug#8873).
5025 A few related buffer overrun fixes, too.
5026
b79e8648
PE
5027 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5028
0766b489
PE
5029 * dispextern.h (struct face.stipple):
5030 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5031 (x_bitmap_mask, x_allocate_bitmap_record)
5032 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5033 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5034 (x_create_bitmap_from_xpm_data):
5035 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5036 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5037 (.bitmaps_last):
5038 * xfaces.c (load_pixmap):
5039 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5040 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5041 (.bitmaps_last, struct x_output.icon_bitmap):
5042 Use ptrdiff_t, not int, for bitmap indexes.
5043 (x_allocate_bitmap_record): Check for size overflow.
5044 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5045
b081724f
PE
5046 Use ptrdiff_t, not int, for overlay counts.
5047 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5048 * editfns.c (overlays_around, get_pos_property):
5049 * textprop.c (get_char_property_and_overlay):
5050 * xdisp.c (next_overlay_change, note_mouse_highlight):
5051 * xfaces.c (face_at_buffer_position):
21514da7
PE
5052 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5053 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5054 (Fnext_overlay_change, Fprevious_overlay_change)
5055 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5056 Use ptrdiff_t, not int, for sizes.
21514da7 5057 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5058
3de73e5e
PE
5059 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5060
2606c57b
PE
5061 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5062 (x_session_initialize): Do not assume string length fits in int.
5063
aaafe47a
PE
5064 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5065 This is unlikely, but can occur if DPI is outlandish.
5066
2674ddc8 5067 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5068 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5069
28154962
PE
5070 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5071 * xrdb.c (magic_file_p, search_magic_path):
5072 Omit last arg SUFFIX; it was always 0. All callers changed.
5073 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5074
7de51af5
PE
5075 * xfont.c (xfont_match): Avoid need for strlen.
5076
25ed6cc3
PE
5077 * xfns.c: Don't assume strlen fits in int.
5078 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5079
4eab31dd
PE
5080 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5081 not unsigned long, as we prefer signed integers. All callers changed.
5082 Detect integer overflow in repeat count.
5083 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5084 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5085
171e2a58
PE
5086 * termcap.c: Don't assume sizes fit in int and never overflow.
5087 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5088 (gobble_line): Check for size-calculation overflow.
5089
ad39faca 5090 * minibuf.c (Fread_buffer):
6e5bb2dc 5091 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5092 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5093 Don't assume string length fits in int.
5094
52c61c22 5095 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5096 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5097
b5b8c9e5
PE
5098 * font.c: Don't assume string length fits in int.
5099 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5100 Use ptrdiff_t, not int.
ccd6111c
PE
5101 (font_intern_prop): Don't assume string length fits in int.
5102 Don't assume integer property fits in fixnum.
5103 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5104
882f0d81 5105 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5106 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5107 Reformulate so as not to need the command string.
5108 Invoke gzip -cd rather than gunzip, as it's more portable.
5109 (lock_info_type, lock_file_1, lock_file):
5110 Don't assume pid_t and time_t fit in unsigned long.
5111 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5112 (current_lock_owner): Prefer signed type for sizes.
5113 Use memcpy, not strncpy, where memcpy is what is really wanted.
5114 Don't assume (via atoi) that time_t and pid_t fit in int.
5115 Check for time_t and/or pid_t out of range, e.g., via a network share.
5116 Don't alloca where an auto var works fine.
5117
93f4cf88
PE
5118 * fileio.c: Fix some integer overflow issues.
5119 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5120 Don't assume string length fits in int.
5121 (directory_file_name): Don't assume string length fits in long.
5122 (make_temp_name): Don't assume pid fits in int, or that its print
5123 length is less than 20.
5124
f3e92b69
PE
5125 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5126
1bfdaf10
PE
5127 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5128
35016e9a
PE
5129 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5130
3d1e65a1
PE
5131 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5132 We prefer signed integers, even for size calculations.
5133
0b963a93
PE
5134 * emacs.c: Don't assume string length fits in 'int'.
5135 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5136 (main): Don't invoke strlen when not needed.
5137
573f4b54
PE
5138 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5139 (XD_DEBUG_MESSAGE): Don't waste a byte.
5140
989f33ba
PE
5141 * callproc.c (getenv_internal_1, getenv_internal)
5142 (Fgetenv_internal):
965d34eb
PE
5143 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5144
e4d29b33
PE
5145 * lread.c (invalid_syntax): Omit length argument.
5146 All uses changed. This doesn't fix a bug, but it simplifies the
5147 code away from its former Hollerith-constant appearance, and it's
5148 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5149 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5150
eb49b136
PE
5151 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5152 This didn't break anything, but it didn't help either.
5153 It's confusing to put a bogus integer in a place where the actual
5154 value does not matter.
9f62aeb1 5155 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5156 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5157
15375a22
PE
5158 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5159 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5160 implementation.
b61cc01c
PE
5161 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5162 We prefer signed types, and the value cannot exceed the EMACS_INT
5163 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5164 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5165 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5166 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5167
53b2623d
PE
5168 * indent.c (sane_tab_width): New function.
5169 (current_column, scan_for_column, Findent_to, position_indentation)
5170 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5171 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5172
51cab52b 5173 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5174
f2ed8a70
PE
5175 * lisp.h (lint_assume): New macro.
5176 * composite.c (composition_gstring_put_cache):
5177 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5178
abe80cc6
PE
5179 * editfns.c, insdel.c:
5180 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5181
b02c740e
PE
5182 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5183
ebc96716
PE
5184 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5185
b4e50fa0 5186 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5187 Use much-faster test for byte-length change.
311d5d7c 5188 Don't assume string byte-length fits in 'int'.
a4cf38e4 5189 Check that character arg fits in 'int'.
85461888 5190 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5191
c0c1ee9f
PE
5192 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5193
a498d7f4
PE
5194 * fns.c (concat): Catch string overflow earlier.
5195 Do not rely on integer wraparound.
5196
51cab52b
PE
5197 * dispextern.h (struct it.overlay_strings_charpos)
5198 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5199 * xdisp.c (forward_to_next_line_start)
5200 (back_to_previous_visible_line_start)
5201 (reseat_at_next_visible_line_start, next_element_from_buffer):
5202 Don't arbitrarily truncate the value of 'selective' to int.
5203
76031fad
PE
5204 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5205
5eb55db9
PE
5206 * composite.c: Don't truncate sizes to 'int'.
5207 (composition_gstring_p, composition_reseat_it)
5208 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5209 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5210 not EMACS_UINT, for indexes.
5eb55db9 5211
0703a717
PE
5212 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5213
d6202519
PE
5214 * buffer.c: Include <verify.h>.
5215 (struct sortvec.priority, struct sortstr.priority):
8961a454 5216 Now EMACS_INT, not int.
c20998a7 5217 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5218 (struct sortstr.size, record_overlay_string)
5219 (struct sortstrlist.size, struct sortlist.used):
5220 Don't truncate size to int.
5221 (record_overlay_string): Check for size-calculation overflow.
d6202519 5222 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5223
d5a19415
JM
52242011-06-22 Jim Meyering <meyering@redhat.com>
5225
029529ac 5226 Don't leak an XBM-image-sized buffer
d5a19415
JM
5227 * image.c (xbm_load): Free the image buffer after using it.
5228
a9041e6c
PE
52292011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5230
5231 Port to Sun C.
5232 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5233 that Sun C diagnosed.
5234 * fns.c (secure_hash): Fix pointer signedness issue.
5235 * intervals.c (static_offset_intervals): New function.
5236 (offset_intervals): Use it.
5237
7f3f739f
LL
52382011-06-21 Leo Liu <sdl.web@gmail.com>
5239
5240 * deps.mk (fns.o):
5241 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5242 sha512.h.
5243
5244 * fns.c (secure_hash): Rename from crypto_hash_function and change
5245 the first arg to accept symbols.
5b66d427 5246 (Fsecure_hash): New primitive.
7f3f739f
LL
5247 (syms_of_fns): New symbols.
5248
76147d94
DD
52492011-06-20 Deniz Dogan <deniz@dogan.se>
5250
5251 * process.c (Fset_process_buffer): Clarify return value in
5252 docstring.
5253
7d7d0045
CY
52542011-06-18 Chong Yidong <cyd@stupidchicken.com>
5255
5256 * dispnew.c (add_window_display_history): Use BVAR.
5257
5258 * xdisp.c (debug_method_add): Use BVAR.
5259 (check_window_end, dump_glyph_matrix, dump_glyph)
5260 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5261
5262 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5263 Likewise.
5264
5265 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5266 check till after the cache is created in init_frame_faces.
5267
ff2bc410
SM
52682011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5269
5270 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5271
28177add
PE
52722011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5273
dd3482fe
PE
5274 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5275 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5276 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5277
393d71f3 5278 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5279 * fileio.c (Finsert_file_contents):
5280 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5281 Remove the old (too-loose) buffer overflow checks.
5282 They weren't needed, since make_gap checks for buffer overflow.
5283 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5284 The old code merely checked for Emacs fixnum overflow, and relied
5285 on undefined (wraparound) behavior. The new code avoids undefined
5286 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5287
2e6813b0 5288 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5289 Tune. Don't use wider integers than needed. Don't use alloca.
5290 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5291
599a9e4f
PE
5292 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5293
99561444
PE
5294 * insdel.c, lisp.h (buffer_overflow): New function.
5295 (insert_from_buffer_1, replace_range, replace_range_2):
5296 * insdel.c (make_gap_larger):
5297 * editfns.c (Finsert_char):
5298 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5299
28177add
PE
5300 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5301
e69dafad
PE
53022011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5303
4baa020d 5304 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5305
b1c46f02
PE
5306 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5307 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5308
e69dafad
PE
5309 * fileio.c: Don't assume EMACS_INT fits in off_t.
5310 (emacs_lseek): New static function.
5311 (Finsert_file_contents, Fwrite_region): Use it.
5312 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5313
566684ea
PE
5314 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5315
e6966cd6
PE
5316 * fns.c: Don't overflow int when computing a list length.
5317 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5318 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5319 truncation on 64-bit hosts. Check for QUIT every
5320 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5321 faster and is responsive enough.
5322 (Flength): Report an error instead of overflowing an integer.
5323 (Fsafe_length): Return a float if the value is not representable
5324 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5325 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5326 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5327
dd0b0efb
PE
5328 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5329 (header_size, word_size): New constants.
5330 (allocate_vectorlike): Don't check size overflow here.
5331 (allocate_vector): Check it here instead, since this is the only
5332 caller of allocate_vectorlike that could cause overflow.
5333 Check that the new vector's length is representable as a fixnum.
5334
86fe5cfe
PE
5335 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5336 The previous code was bogus. For example, next_almost_prime (32)
5337 returned 39, which is undesirable as it is a multiple of 3; and
5338 next_almost_prime (24) returned 25, which is a multiple of 5 so
5339 why was the code bothering to check for multiples of 7?
5340
80e88859
PE
5341 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5342
4a2f0ad6
PE
5343 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5344
f66c7cf8
PE
5345 Variadic C functions now count arguments with ptrdiff_t.
5346 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5347 Back then I didn't know that the Emacs coding style prefers signed int.
5348 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5349 were being counted with int, which may truncate counts on 64-bit
5350 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5351 * lisp.h (struct Lisp_Subr.function.aMANY)
5352 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5353 Arg counts are now ptrdiff_t, not size_t.
5354 All variadic functions and their callers changed accordingly.
5355 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5356 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5357 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5358 * callint.c (Fcall_interactively): Check arg count for overflow,
5359 to avoid potential buffer overrun. Use signed char, not 'int',
5360 for 'varies' array, so that we needn't bother to check its size
5361 calculation for overflow.
5362 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5363 * eval.c (apply_lambda):
5364 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5365 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5366 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5367
a1759b76
PE
5368 * callint.c (Fcall_interactively): Don't use index var as event count.
5369
d96be9fc
PE
5370 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5371 * mem-limits.h (SIZE): Remove; no longer used.
5372
a690a978 5373 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5374
578c21e6
PE
5375 Remove unnecessary casts.
5376 * xterm.c (x_term_init):
5377 * xfns.c (x_set_border_pixel):
5378 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5379 These aren't needed now that we assume ANSI C.
5380
96f53c6c
PE
5381 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5382 It's more likely to cause problems (due to unsigned overflow)
5383 than to cure them.
5384
83c77d31
PE
5385 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5386
ee2079f1
PE
5387 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5388
6da65536
PE
5389 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5390
7147c4a4
PE
5391 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5392
193e32d9
PE
5393 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5394
e5533da6
PE
5395 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5396
9910e595
PE
5397 GLYPH_CODE_FACE returns EMACS_INT, not int.
5398 * dispextern.h (merge_faces):
5399 * xfaces.c (merge_faces):
01103c44
PE
5400 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5401 Don't assume EMACS_INT fits in int.
9910e595 5402
2638320e
PE
5403 * character.h (CHAR_VALID_P): Remove unused parameter.
5404 * fontset.c, lisp.h, xdisp.c: All uses changed.
5405
045eb8d9
PE
5406 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5407
c1f134b5
PE
5408 * fns.c (concat): Minor tuning based on overflow analysis.
5409 This doesn't fix any bugs. Use int to hold character, instead
5410 of constantly refetching from Emacs object. Use XFASTINT, not
5411 XINT, for value known to be a character. Don't bother comparing
5412 a single byte to 0400, as it's always less.
5413
395fcb93 5414 * floatfns.c (Fexpt):
327eeec8
PE
5415 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5416
abbd3d23
PE
5417 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5418 for characters.
5419
684a03ef
PE
5420 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5421
0fed43f3
PE
5422 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5423 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5424 incorrectly succeed when S was a string, because 4294967386 was
5425 truncated before it was used.
5426
8fd02eb7
PE
5427 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5428 Otherwise, an out-of-range integer could cause undefined behavior
5429 on a 64-bit host.
5430
f8c86b69
PE
5431 * composite.c: Use int, not EMACS_INT, for characters.
5432 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5433 EMACS_INT, for values that are known to be in character range.
5434 This doesn't fix any bugs but is the usual style inside Emacs and
5435 may generate better code on 32-bit machines.
5436
34206dd2
PE
5437 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5438 This is for reasons similar to the recent CHAR_STRING fix.
5439 * charset.c (Fencode_char): Check that character arg is actually
5440 a character. Pass an int to ENCODE_CHAR.
5441 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5442 wider than 'int', as a compile-time check to prevent future regressions
5443 in this area.
5444
c5958d4c 5445 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5446
5447 Make sure a 64-bit char is never passed to CHAR_STRING.
5448 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5449 by silently ignoring the top 32 bits, allowing some values
5450 that were far too large to be valid characters.
5451 * character.h: Include <verify.h>.
5452 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5453 arguments are no wider than unsigned, as a compile-time check
5454 to prevent future regressions in this area.
5455 * data.c (Faset):
01103c44 5456 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5457 (Fsubst_char_in_region):
5458 * fns.c (concat):
5459 * xdisp.c (decode_mode_spec_coding):
5460 Adjust to CHAR_STRING's new requirement.
5461 * editfns.c (Finsert_char, Fsubst_char_in_region):
5462 * fns.c (concat): Check that character args are actually
5463 characters. Without this test, these functions did the wrong
5464 thing with wildly out-of-range values on 64-bit hosts.
5465
d37ca623
PE
5466 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5467 These casts should not be needed on 32-bit hosts, either.
5468 * keyboard.c (read_char):
5469 * lread.c (Fload): Remove casts to unsigned.
5470
ea204efb
PE
5471 * lisp.h (UNSIGNED_CMP): New macro.
5472 This fixes comparison bugs on 64-bit hosts.
5473 (ASCII_CHAR_P): Use it.
5474 * casefiddle.c (casify_object):
01103c44 5475 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5476 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5477 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5478 * dispextern.h (FACE_FROM_ID):
5479 * keyboard.c (read_char): Use UNSIGNED_CMP.
5480
41cb286c
PE
5481 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5482 not to EMACS_INT, to avoid GCC warning.
5483
4a1b9832
PE
5484 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5485
55daad71
PE
5486 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5487 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5488 isn't needed on 32-bit machines.
8f95c75c 5489
01103c44
PE
5490 * buffer.c (Fgenerate_new_buffer_name):
5491 Use EMACS_INT for count, not int.
0ceccced 5492 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5493
5494 * data.c (Qcompiled_function): Now static.
5495
c6f072e7
PE
5496 * window.c (window_body_lines): Now static.
5497
20ce5912
PE
5498 * image.c (gif_load): Rename local to avoid shadowing.
5499
9c4c5f81
PE
5500 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5501 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5502 * alloc.c (make_save_value): Integer argument is now of type
5503 ptrdiff_t, not int.
5504 (mark_object): Use ptrdiff_t, not int.
5505 * lisp.h (pD): New macro.
5506 * print.c (print_object): Use it.
5507
c0c5c8ae
PE
5508 * alloc.c: Use EMACS_INT, not int, to count objects.
5509 (total_conses, total_markers, total_symbols, total_vector_size)
5510 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5511 (total_free_floats, total_floats, total_free_intervals)
5512 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5513 Now EMACS_INT, not int. All uses changed.
5514 (Fgarbage_collect): Compute overall total using a double, so that
5515 integer overflow is less likely to be a problem. Check for overflow
5516 when converting back to an integer.
5a25e253
PE
5517 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5518 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5519 These were 'int' variables that could overflow on 64-bit hosts;
5520 they were never used, so remove them instead of repairing them.
211a0b2a 5521 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5522 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5523 Previously, this ceilinged at INT_MAX, but that doesn't work on
5524 64-bit machines.
e46bb31a 5525 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5526
c78baabf 5527 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5528 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5529 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5530 when a (possibly-narrower) signed value would do just as well.
5531 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5532
c9d624c6
PE
5533 * alloc.c: Catch some string size overflows that we were missing.
5534 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5535 for convenience in STRING_BYTES_MAX.
5536 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5537 The definition here is exact; the one in lisp.h was approximate.
5538 (allocate_string_data): Check for string overflow. This catches
5539 some instances we weren't catching before. Also, it catches
5540 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5541 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5542 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5543
c9d624c6
PE
5544 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5545 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5546 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5547
353032ce
PE
5548 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5549
2bccce07
PE
5550 * alloc.c (Fmake_string): Check for out-of-range init.
5551
0ac30604
SM
55522011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5553
5554 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5555
c195f2de
JD
55562011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5557
5558 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5559 xg_get_default_scrollbar_width.
5560
5561 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5562 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5563 (style_changed_cb): Call update_theme_scrollbar_width and call
5564 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5565 all frames (Bug#8505).
5566 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5567 Call gtk_window_set_resizable if HAVE_GTK3.
5568 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5569 and height if HAVE_GTK3 (Bug#8505).
5570 (scroll_bar_width_for_theme): New variable.
5571 (update_theme_scrollbar_width): New function.
5572 (xg_get_default_scrollbar_width): Move code to
5573 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5574 (xg_initialize): Call update_theme_scrollbar_width.
5575
5576 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5577
5578 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5579
e10ac9f1
MR
55802011-06-12 Martin Rudalics <rudalics@gmx.at>
5581
5582 * frame.c (make_frame): Call other_buffer_safely instead of
5583 other_buffer.
5584
5585 * window.c (temp_output_buffer_show): Call display_buffer with
5586 second argument Vtemp_buffer_show_specifiers and reset latter
5587 immediately after the call.
5588 (Vtemp_buffer_show_specifiers): New variable.
5589 (auto_window_vscroll_p, next_screen_context_lines)
5590 (Vscroll_preserve_screen_position): Remove leading asterisks from
5591 doc-strings.
5592
2d3c217e 55932011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5594
7b7f97e8 5595 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5596 * buffer.c (Qclone_number): Remove for now, as it's unused.
5597 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5598 (record_buffer): Remove unused local.
5599 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5600 (set_frame_buffer_list): Remove; unused.
5601 * frame.h (other_visible_frames): Remove decl.
5602 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5603 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5604 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5605 if HAVE_GPM.
5606 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5607 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5608 Define only if HAVE_GPM.
5609 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5610 (update_hints_inhibit): Remove; never set. All uses removed.
5611 * widgetprv.h (emacsFrameClassRec): Remove decl.
5612 * window.c (delete_deletable_window): Now returns void, since it
5613 wasn't returning anything.
5614 (compare_window_configurations): Remove unused locals.
5615 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5616 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5617 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5618 the same widths as pointers. This follows up on the 2011-05-06 patch.
5619 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5620 * xterm.h: Likewise.
5621 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5622
1384b89e
JB
56232011-06-12 Juanma Barranquero <lekktu@gmail.com>
5624
5625 * makefile.w32-in: Update dependencies.
5626 (LISP_H): Add lib/intprops.h.
5627
1100a63c
CY
56282011-06-11 Chong Yidong <cyd@stupidchicken.com>
5629
5630 * image.c (gif_load): Add animation frame delay to the metadata.
5631 (syms_of_image): Use DEFSYM. New symbol `delay'.
5632
6198ccd0
MR
56332011-06-11 Martin Rudalics <rudalics@gmx.at>
5634
5635 * window.c (delete_deletable_window): Re-add.
5636 (Fset_window_configuration): Rewrite to handle dead buffers and
5637 consequently deletable windows.
5638 (window_tree, Fwindow_tree): Remove. Supply functionality in
5639 window.el.
5640 (compare_window_configurations): Simplify code.
5641
b6e3633c
AS
56422011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5643
1ab0dee5
AS
5644 * image.c (imagemagick_load_image): Fix type mismatch.
5645 (Fimagemagick_types): Likewise.
5646
b6e3633c
AS
5647 * window.h (replace_buffer_in_windows): Declare.
5648
9397e56f
MR
56492011-06-11 Martin Rudalics <rudalics@gmx.at>
5650
5651 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5652 Qclone_number. Remove external declaration of Qdelete_window.
5653 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5654 code.
640c8776
SM
5655 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5656 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5657 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5658 buffer list implementation.
5659 (other_buffer_safely): New function.
5660 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5661 calls to replace_buffer_in_windows and
5662 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5663 if allowed.
5664 (record_buffer): Inhibit quitting and rewrite using quittable
5665 functions. Run Qbuffer_list_update_hook if allowed.
5666 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5667 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5668 Move switch-to-buffer to window.el.
9397e56f
MR
5669 (bury-buffer): Move to window.el.
5670 (Vbuffer_list_update_hook): New variable.
5671
5672 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5673 section.
5674
5675 * window.h (resize_frame_windows): Move up in code.
5676 (Fwindow_frame): Remove EXFUN.
5677 (replace_buffer_in_all_windows): Remove prototype.
5678 (replace_buffer_in_windows_safely): Add prototype.
5679
5680 * window.c: Declare Qdelete_window static again. Move down
5681 declaration of select_count.
5682 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5683 (Fother_window): Move to window.el.
5684 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5685 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5686 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5687 window.el.
5688 (replace_buffer_in_windows): Implement by calling
5689 Qreplace_buffer_in_windows.
5690 (replace_buffer_in_all_windows): Remove with some functionality
5691 moved into replace_buffer_in_windows_safely.
5692 (replace_buffer_in_windows_safely): New function.
5693 (select_window_norecord, select_frame_norecord): Move in front
5694 of run_window_configuration_change_hook. Remove now obsolete
5695 declarations.
640c8776
SM
5696 (Fset_window_buffer): Rewrite doc-string.
5697 Call Qrecord_window_buffer.
9397e56f
MR
5698 (keys_of_window): Move binding for other-window to window.el.
5699
b50691aa
CY
57002011-06-11 Chong Yidong <cyd@stupidchicken.com>
5701
5702 * dispextern.h (struct image): Replace data member, whose int_val
5703 and ptr_val fields were not used by anything, with a single
5704 lisp_val object.
5705
5706 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5707 (gif_clear_image, gif_load, imagemagick_load_image)
5708 (gs_clear_image, gs_load): Callers changed.
5709
3f754b86
PE
57102011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5711
cca69397
PE
5712 * buffer.h: Include <time.h>, for time_t.
5713 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5714
109e28d0
PE
5715 Fix minor problems found by static checking.
5716
60737f02
PE
5717 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5718
4b66faf3
PE
5719 Make identifiers static if they are not used in other modules.
5720 * data.c (Qcompiled_function, Qframe, Qvector):
5721 * image.c (QimageMagick, Qsvg):
5722 * minibuf.c (Qmetadata):
5723 * window.c (resize_window_check, resize_root_window): Now static.
5724 * window.h (resize_window_check, resize_root_window): Remove decls.
5725
109e28d0
PE
5726 * window.c (window_deletion_count, delete_deletable_window):
5727 Remove; unused.
46a4ce9e
PE
5728 (window_body_lines): Now static.
5729 (Fdelete_other_windows_internal): Mark vars as initialized.
5730 Make sure 'resize_failed' is initialized.
5731 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5732 (resize_window_apply): Remove unused local.
5733 * window.h (delete_deletable_window): Remove decl.
5734
109e28d0 5735 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5736 (imagemagick_load_image): Fix pointer signedness problem by changing
5737 last arg from unsigned char * to char *. All uses changed.
5738 Also, fix a local for similar reasons.
5739 Remove unused locals. Remove locals to avoid shadowing.
5740 (fn_rsvg_handle_free): Remove; unused.
5741 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5742 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5743
3f754b86
PE
5744 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5745
2547adb1
CY
57462011-06-10 Chong Yidong <cyd@stupidchicken.com>
5747
5748 * image.c (gif_load): Fix omitted cast error introduced by
5749 2011-06-06 change.
5750
2c8e37d4
MR
57512011-06-10 Martin Rudalics <rudalics@gmx.at>
5752
5753 * window.h (resize_proportionally, orig_total_lines)
5754 (orig_top_line): Remove from window structure.
5755 (set_window_height, set_window_width, change_window_heights)
5756 (Fdelete_window): Remove prototypes.
5757 (resize_frame_windows): Remove duplicate declaration.
5758
440a42e3
EZ
57592011-06-10 Eli Zaretskii <eliz@gnu.org>
5760
5761 * window.h (resize_frame_windows, resize_window_check)
5762 (delete_deletable_window, resize_root_window)
5763 (resize_frame_windows): Declare prototypes.
5764
5765 * window.c (resize_window_apply): Make definition be "static" to
5766 match the prototype.
5767
562dd5e9
MR
57682011-06-10 Martin Rudalics <rudalics@gmx.at>
5769
5770 * window.c: Remove declarations of Qwindow_size_fixed,
5771 window_min_size_1, window_min_size_2, window_min_size,
5772 size_window, window_fixed_size_p, enlarge_window, delete_window.
5773 Remove static from declaration of Qdelete_window, it's
5774 temporarily needed by Fbury_buffer.
5775 (replace_window): Don't assign orig_top_line and
5776 orig_total_lines.
5777 (Fdelete_window, delete_window): Remove. Window deletion is
5778 handled by window.el.
640c8776
SM
5779 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5780 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5781 (Fdelete_other_windows): Remove. Deleting other windows is
5782 handled by window.el.
5783 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5784 handled in window.el.
5785 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5786 Window minimum sizes are handled in window.el.
5787 (shrink_windows, size_window, set_window_height)
5788 (set_window_width, change_window_heights, window_height)
5789 (window_width, CURBEG, CURSIZE, enlarge_window)
5790 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5791 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5792 handled in window.el.
5793 (make_dummy_parent): Rename to make_parent_window and give it a
5794 second argument horflag.
5795 (make_window): Don't set resize_proportionally any more.
5796 (Fsplit_window): Remove. Windows are split in window.el.
5797 (save_restore_action, save_restore_orig_size)
5798 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5799 Resize mini windows in window.el.
5800 (grow_mini_window, shrink_mini_window): Implement by calling
5801 Qresize_root_window_vertically, resize_window_check and
5802 resize_window_apply.
640c8776
SM
5803 (saved_window, Fset_window_configuration, save_window_save):
5804 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5805 resize_proportionally.
5806 (window_min_height, window_min_width): Move to window.el.
5807 (keys_of_window): Move bindings for delete-other-windows,
5808 split-window, delete-window and enlarge-window to window.el.
5809
5810 * buffer.c: Temporarily extern Qdelete_window.
5811 (Fbury_buffer): Temporarily call Qdelete_window instead of
5812 Fdelete_window (Fbury_buffer will move to window.el soon).
5813
5814 * frame.c (set_menu_bar_lines_1): Remove code handling
5815 orig_top_line and orig_total_lines.
5816
5817 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5818 set_window_height but set heights directly.
5819 (change_frame_size_1): Use resize_frame_windows.
5820
5821 * xdisp.c (init_xdisp): Don't use set_window_height but set
5822 heights directly.
5823
640c8776
SM
5824 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5825 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5826 run_window_configuration_change_hook.
5827
5828 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5829 instead of change_window_heights and run
5830 run_window_configuration_change_hook.
5831
1a13852e
MR
58322011-06-09 Martin Rudalics <rudalics@gmx.at>
5833
5834 * window.c (replace_window): Rename second argument REPLACEMENT to
5835 NEW. New third argument SETFLAG. Rewrite.
5836 (delete_window, make_dummy_parent): Call replace_window with
5837 third argument 1.
5838 (window_list_1): Move down in code.
5839 (run_window_configuration_change_hook): Move set_buffer part
5840 before select_frame_norecord part in order to unwind correctly.
5841 Rename count1 to count.
5842 (recombine_windows, delete_deletable_window, resize_root_window)
5843 (Fdelete_other_windows_internal)
5844 (Frun_window_configuration_change_hook, make_parent_window)
5845 (resize_window_check, resize_window_apply, Fresize_window_apply)
5846 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5847 (Fdelete_window_internal, Fresize_mini_window_internal):
5848 New functions.
1a13852e
MR
5849 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5850
f3d1777e
MR
58512011-06-08 Martin Rudalics <rudalics@gmx.at>
5852
496e208e
MR
5853 * window.h (window): Add some new members to window structure -
5854 normal_lines, normal_cols, new_total, new_normal, clone_number,
5855 splits, nest, prev_buffers, next_buffers.
5856 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5857 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5858
f3d1777e
MR
5859 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5860 Remove.
496e208e
MR
5861 (make_dummy_parent): Set new members of windows structure.
5862 (make_window): Move down in code. Handle new members of window
5863 structure.
5864 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5865 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5866 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5867 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5868 (Fset_window_next_buffers, Fset_window_clone_number):
5869 New functions.
496e208e
MR
5870 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5871 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5872 Doc-string fixes.
5873 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5874 Argument WINDOW can be now internal window too.
5875 (Fwindow_use_time): Move up in code.
5876 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5877 Rewrite doc-string.
5878 (Fset_window_configuration, saved_window)
5879 (Fcurrent_window_configuration, save_window_save): Handle new
5880 members of window structure.
b9e809c2
MR
5881 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5882 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5883 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5884 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5885 Qget_mru_window, Qresize_root_window,
5886 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5887 Qauto_buffer_name; staticpro them.
f3d1777e 5888
abde8f8c
MR
58892011-06-07 Martin Rudalics <rudalics@gmx.at>
5890
5891 * window.c (Fwindow_total_size, Fwindow_left_column)
5892 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5893 (Fwindow_list_1): New functions.
5894 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5895 (Fwindow_width, Fscroll_left, Fscroll_right):
5896 Use window_body_cols instead of window_box_text_cols.
5897 (delete_window, Fset_window_configuration):
5898 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5899 (delete_all_subwindows): Take a window as argument and not a
5900 structure. Rewrite.
190b47e6
MR
5901 (window_loop): Remove handling of GET_LRU_WINDOW and
5902 GET_LARGEST_WINDOW.
5903 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5904
5905 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5906 window_box_text_cols. delete_all_subwindows now takes a
5907 Lisp_Object as argument.
abde8f8c 5908
640c8776
SM
5909 * indent.c (compute_motion, Fcompute_motion):
5910 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5911
fa8a67e6
MR
5912 * frame.c (delete_frame): Call delete_all_subwindows with root
5913 window as argument.
5914
a54e3482
DC
59152011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5916
5917 * fns.c (Fputhash): Document return value.
5918
60002bf5
CY
59192011-06-06 Chong Yidong <cyd@stupidchicken.com>
5920
5921 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5922
0c671da6 59232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5924
b862a52a 5925 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5926
be44ca6c
PE
5927 Check for overflow when converting integer to cons and back.
5928 * charset.c (Fdefine_charset_internal, Fdecode_char):
5929 Use cons_to_unsigned to catch overflow.
5930 (Fencode_char): Use INTEGER_TO_CONS.
5931 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5932 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5933 * data.c (long_to_cons, cons_to_long): Remove.
5934 (cons_to_unsigned, cons_to_signed): New functions.
5935 These signal an error for invalid or out-of-range values.
5936 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5937 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5938 * font.c (Ffont_variation_glyphs):
5939 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5940 * lisp.h: Include <intprops.h>.
5941 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5942 (cons_to_signed, cons_to_unsigned): New decls.
5943 (long_to_cons, cons_to_long): Remove decls.
5944 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5945 (Fprimitive_undo): Use CONS_TO_INTEGER.
5946 * xfns.c (Fx_window_property): Likewise.
5947 * xselect.c: Include <limits.h>.
5948 (x_own_selection, selection_data_to_lisp_data):
5949 Use INTEGER_TO_CONS.
5950 (x_handle_selection_request, x_handle_selection_clear)
5951 (x_get_foreign_selection, Fx_disown_selection_internal)
5952 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5953 (lisp_data_to_selection_data): Use cons_to_unsigned.
5954 (x_fill_property_data): Use cons_to_signed.
5955 Report values out of range.
5956
d1f3d2af
PE
5957 Check for buffer and string overflow more precisely.
5958 * buffer.h (BUF_BYTES_MAX): New macro.
5959 * lisp.h (STRING_BYTES_MAX): New macro.
5960 * alloc.c (Fmake_string):
5961 * character.c (string_escape_byte8):
5962 * coding.c (coding_alloc_by_realloc):
5963 * doprnt.c (doprnt):
5964 * editfns.c (Fformat):
5965 * eval.c (verror):
5966 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5967 since they may not be the same number.
5968 * editfns.c (Finsert_char):
5969 * fileio.c (Finsert_file_contents):
5970 Likewise for BUF_BYTES_MAX.
5971
dd52fcea
PE
5972 * image.c: Use ptrdiff_t, not int, for sizes.
5973 (slurp_file): Switch from int to ptrdiff_t.
5974 All uses changed.
5975 (slurp_file): Check that file size fits in both size_t (for
5976 malloc) and ptrdiff_t (for sanity and safety).
5977
7f9bbdbb
PE
5978 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5979 if b->modtime has its maximal value.
5980
dfe18f82
PE
5981 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5982
84acfcf0
PE
5983 Don't assume time_t can fit into int.
5984 * buffer.h (struct buffer.modtime): Now time_t, not int.
5985 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5986 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5987
ccd9a01a
PE
5988 Minor fixes for signed vs unsigned integers.
5989 * character.h (MAYBE_UNIFY_CHAR):
5990 * charset.c (maybe_unify_char):
5991 * keyboard.c (read_char, reorder_modifiers):
5992 XINT -> XFASTINT, since the integer must be nonnegative.
5993 * ftfont.c (ftfont_spec_pattern):
5994 * keymap.c (access_keymap, silly_event_symbol_error):
5995 XUINT -> XFASTINT, since the integer must be nonnegative.
5996 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5997 since it makes no difference and we prefer signed.
5998 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5999 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6000 nonnegative.
6001
d6d100dd
SM
60022011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6003
6004 * window.h (Fwindow_frame): Declare.
6005
2b6148e4
PE
60062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6007
6008 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6009 (SPARE_MEMORY): Always define.
6010 (LARGE_REQUEST): Remove.
6011 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6012
f230ecc9
MR
60132011-06-06 Martin Rudalics <rudalics@gmx.at>
6014
727e958e
MR
6015 * lisp.h: Move EXFUNS for Fframe_root_window,
6016 Fframe_first_window and Fset_frame_selected_window to window.h.
6017
6018 * window.h: Move EXFUNS for Fframe_root_window,
6019 Fframe_first_window and Fset_frame_selected_window here from
6020 lisp.h.
6021
6022 * frame.c (Fwindow_frame, Fframe_first_window)
6023 (Fframe_root_window, Fframe_selected_window)
6024 (Fset_frame_selected_window): Move to window.c.
6025 (Factive_minibuffer_window): Move to minibuf.c.
6026 (Fother_visible_frames_p): New function.
6027
6028 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6029
f230ecc9
MR
6030 * window.c (decode_window, decode_any_window): Move up in code.
6031 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6032 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6033 (Fwindow_buffer): Move up and rewrite doc-string.
6034 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6035 (Fwindow_prev): New functions.
727e958e
MR
6036 (Fwindow_frame): Move here from frame.c. Accept any window as
6037 argument.
6038 (Fframe_root_window, Fframe_first_window)
6039 (Fframe_selected_window): Move here from frame.c. Accept frame
6040 or arbitrary window as argument. Update doc-strings.
6041 (Fminibuffer_window): Move up in code.
6042 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6043 (Fset_frame_selected_window): Move here from frame.c.
6044 Marginal rewrite.
727e958e
MR
6045 (Fselected_window, select_window, Fselect_window): Move up in
6046 code. Minor doc-string fixes.
f230ecc9 6047
4d09bcf6
PE
60482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6049
6050 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6051 Do not assume that spare memory exists; that assumption is valid
6052 only if SYSTEM_MALLOC.
6053 (LARGE_REQUEST): New macro, so that the issue of large requests
6054 is separated from the issue of spare memory.
6055
810928a2
AS
60562011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6057
172418ad
AS
6058 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6059 format. (Bug#8806)
6060
43f862f7
AS
6061 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6062
810928a2
AS
6063 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6064 before statements.
6065
a059fe24
JD
60662011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6067
6068 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6069
6070 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6071
6072 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6073 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6074
989bf368
JB
60752011-06-05 Juanma Barranquero <lekktu@gmail.com>
6076
6077 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6078
4b80f674
CY
60792011-06-04 Chong Yidong <cyd@stupidchicken.com>
6080
6081 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6082 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6083 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6084 New error handlers.
4b80f674
CY
6085 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6086 Obey Vx_select_enable_clipboard_manager. Catch errors in
6087 x_clipboard_manager_save (Bug#8779).
6088 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6089 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6090
99a33b77 60912011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6092
6093 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6094
99a33b77 60952011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6096
6097 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6098 in the current matrix if keep_current_p is non-zero.
6099
8264569d
EZ
61002011-06-04 Eli Zaretskii <eliz@gnu.org>
6101
6102 * bidi.c (bidi_level_of_next_char): Fix last change.
6103
57f97249
EZ
61042011-06-03 Eli Zaretskii <eliz@gnu.org>
6105
fec2107c 6106 Support bidi reordering of text covered by display properties.
57f97249 6107
fec2107c
EZ
6108 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6109 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6110 (bidi_cache_search, bidi_cache_iterator_state)
6111 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6112 (bidi_level_of_next_char, bidi_move_to_visually_next):
6113 Support character positions inside a run of characters covered by a
fec2107c
EZ
6114 display string.
6115 (bidi_paragraph_init, bidi_resolve_explicit_1)
6116 (bidi_level_of_next_char): Call bidi_fetch_char and
6117 bidi_fetch_char_advance instead of FETCH_CHAR and
6118 FETCH_CHAR_ADVANCE.
6119 (bidi_init_it): Initialize new members.
6120 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6121 definitions.
6122 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6123 instead of using explicit *_CHAR codes.
d6d100dd
SM
6124 (bidi_resolve_explicit, bidi_resolve_weak):
6125 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6126 bidirectional text is supported only in multibyte buffers.
6127 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6128 it to initialize the frame_window_p member of struct bidi_it.
6129 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6130 (bidi_resolve_explicit, bidi_resolve_weak)
6131 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6132 bidi_it->nchars is non-positive.
6133 (bidi_level_of_next_char): Don't try to lookup the cache for the
6134 next/previous character if nothing is cached there yet, or if we
6135 were just reseat()'ed to a new position.
c40e2fb2 6136
0e14fe90
EZ
6137 * xdisp.c (set_cursor_from_row): Set start and stop points
6138 according to the row's direction when priming the loop that looks
6139 for the glyph on which to display cursor.
6140 (single_display_spec_intangible_p): Function deleted.
6141 (display_prop_intangible_p): Reimplement to call
6142 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6143 Accept 3 additional arguments needed by handle_display_spec.
6144 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6145 values: lists, `(when COND...)' forms, etc.
6146 (single_display_spec_string_p): Support property values that are
6147 lists with the argument STRING its top-level element.
6148 (display_prop_string_p): Fix the condition for processing a
6149 property that is a list to be consistent with handle_display_spec.
fec2107c 6150 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6151 last portion of handle_display_prop.
6152 (compute_display_string_pos): Accept additional argument
6153 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6154 value of a `display' property is a "replacing spec".
6155 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6156 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6157 the display property, but just return a value indicating whether
6158 the display property will replace the characters it covers.
6159 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6160 frame_window_p members of struct bidi_it.
d6d100dd
SM
6161 (compute_display_string_pos, compute_display_string_end):
6162 New functions.
fec2107c
EZ
6163 (push_it): Accept second argument POSITION, where pop_it should
6164 jump to continue iteration.
6165 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6166
fec2107c
EZ
6167 * keyboard.c (adjust_point_for_property): Adjust the call to
6168 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6169
6170 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6171 (bidi_init_it): Update prototypes.
6172 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6173 (compute_display_string_pos, compute_display_string_end):
6174 Declare prototypes.
fec2107c
EZ
6175 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6176 EMACS_INT.
fc6f18ce 6177
40087514 61782011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6179
57f53182
PE
6180 Malloc failure behavior now depends on size of allocation.
6181 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6182 * lisp.h: Change signatures accordingly.
6183 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6184 All callers changed. (Bug#8762)
6185
6186 * gnutls.c: Use Emacs's memory allocators.
6187 Without this change, the gnutls library would invoke malloc etc.
6188 directly, which causes problems on non-SYNC_INPUT hosts, and which
6189 runs afoul of improving memory_full behavior. (Bug#8761)
6190 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6191 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6192 xfree instead of the default malloc, realloc, free.
6193 (Fgnutls_boot): No need to check for memory allocation failure,
6194 since xmalloc does that for us.
6195
ac32cd99 6196 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6197 * category.c (hash_get_category_set):
6198 * ccl.c (ccl_driver):
6199 * charset.c (Fdefine_charset_internal):
6200 * charset.h (struct charset.hash_index):
6201 * composite.c (get_composition_id, gstring_lookup_cache)
6202 (composition_gstring_put_cache):
6203 * composite.h (struct composition.hash_index):
6204 * dispextern.h (struct image.hash):
6205 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6206 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6207 (hashfn_equal, hashfn_user_defined, make_hash_table)
6208 (maybe_resize_hash_table, hash_lookup, hash_put)
6209 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6210 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6211 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6212 * image.c (make_image, search_image_cache, lookup_image)
6213 (xpm_put_color_table_h):
6214 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6215 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6216 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6217 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6218 * alloc.c (allocate_vectorlike):
6219 Check for overflow in vector size calculations.
6220 * ccl.c (ccl_driver):
6221 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6222 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6223 need to be updated by these changes.
40087514
PE
6224 * fns.c (make_hash_table, maybe_resize_hash_table):
6225 Check for integer overflow with large hash tables.
0de4bb68
PE
6226 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6227 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6228 (SXHASH_REDUCE): New macro.
6229 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6230 Use it instead of discarding useful hash info with large hash values.
6231 (sxhash_float): New function.
6232 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6233 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6234 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6235 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6236 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6237 Adjust signatures to match updated version of code.
6238 (consing_since_gc): Now EMACS_INT, since a single hash table can
6239 use more than INT_MAX bytes.
6240
698d32e2
DN
62412011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6242
6243 Make it possible to build with GCC-4.6+ -O2 -flto.
6244
6245 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6246
fd6fa53f
SM
62472011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6248
6249 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6250 Call minibuffer-inactive-mode.
6251
864db017
JB
62522011-05-31 Juanma Barranquero <lekktu@gmail.com>
6253
6254 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6255 Update dependencies.
6256
2ad0baf4
DN
62572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6258
6259 * data.c (init_data): Remove code for UTS, this system is not
6260 supported anymore.
6261
4fcc2638
DN
62622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6263
6264 Don't force ./temacs to start in terminal mode.
6265
6266 * frame.c (make_initial_frame): Initialize faces in all cases, not
6267 only when CANNOT_DUMP is defined.
6268 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6269
c56e0fd5
DN
62702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6271
6272 * dispnew.c (add_window_display_history): Use const for the string
6273 pointer. Remove declaration, not needed.
6274
333d54da 62752011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6276
55d4c1b2 6277 Use 'inline', not 'INLINE'.
333d54da 6278 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6279 * alloc.c, fontset.c (INLINE): Remove.
6280 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6281 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6282 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6283 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6284 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6285
738db178
DN
62862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6287
6288 Make it possible to run ./temacs.
6289
6290 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6291 syms_of_callproc does the same thing. Remove test for
6292 "initialized", do it in the caller.
6293 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6294
620c53a6
SM
62952011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6296
6297 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6298 (read_minibuf): Use get_minibuffer.
6299 (syms_of_minibuf): Use DEFSYM.
6300 (Qmetadata): New var.
6301 * data.c (Qbuffer): Don't make it static.
6302 (syms_of_data): Use DEFSYM.
6303
e003a292
PE
63042011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6305
6306 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6307 (CCL_CODE_MIN): New macro.
6308
ed008a6d
PE
63092011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6310
3687c2ef
PE
6311 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6312
ed008a6d
PE
6313 * eval.c (Qdebug): Now static.
6314 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6315 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6316 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6317
d66c4c7c
CY
63182011-05-29 Chong Yidong <cyd@stupidchicken.com>
6319
6320 * image.c: Various fixes to ImageMagick code comments.
6321 (Fimagemagick_types): Doc fix.
6322
5fbc2025
PE
63232011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6324
0196f88a
PE
6325 Minor fixes prompted by GCC 4.6.0 warnings.
6326
6327 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6328
5fbc2025
PE
6329 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6330 (x_clipboard_manager_save_all): Move extern decl to ...
6331 * xterm.h: ... here, so that it can be checked for consistency.
6332
1dd3c2d9
CY
63332011-05-29 Chong Yidong <cyd@stupidchicken.com>
6334
6335 * xselect.c (x_clipboard_manager_save_frame)
6336 (x_clipboard_manager_save_all): New functions.
6337 (Fx_clipboard_manager_save): Lisp function deleted.
6338
6339 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6340 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6341
6342 * xterm.h: Update prototype.
6343
5ba6571d
WX
63442011-05-28 William Xu <william.xwl@gmail.com>
6345
6346 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6347 exiting (Bug#8239).
6348
3eaff834
JM
63492011-05-28 Jim Meyering <meyering@redhat.com>
6350
e1900994 6351 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6352 * fns.c (to_uchar): Define.
6353 (crypto_hash_function): Use it to convert some newly-signed
6354 variables to unsigned, to avoid sign-extension bugs. For example,
6355 without this change, (md5 "truc") would evaluate to
6356 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6357 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6358 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6359
0f6990a7
PE
63602011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6361
6362 Integer overflow fixes.
c8a9ca5a 6363
08686060
PE
6364 * dbusbind.c: Serial number integer overflow fixes.
6365 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6366 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6367 to hold a serial number that is too large for a fixnum.
6368 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6369 Check for serial numbers out of range. Decode any serial number
59568bf0 6370 that was so large that it became a float. (Bug#8722)
08686060 6371
2d1fc3c7
PE
6372 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6373 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6374 Use XFASTINT rather than XUINT when numbers are nonnegative.
6375 (xd_append_arg, Fdbus_method_return_internal):
6376 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6377 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6378 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6379 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6380 (Bug#8722)
2d1fc3c7 6381
c8a9ca5a
PE
6382 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6383
519e1d69
PE
6384 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6385
6df6ae42 6386 ccl: Add integer overflow checks.
30569699
PE
6387 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6388 (IN_INT_RANGE): New macros.
6389 (ccl_driver): Use them to check for integer overflow when
6390 decoding a CCL program. Many of the new checks are whether XINT (x)
6391 fits in int; it doesn't always, on 64-bit hosts. The new version
6392 doesn't catch all possible integer overflows, but it's an
847044ea 6393 improvement. (Bug#8719)
30569699 6394
c11285dc
PE
6395 * alloc.c (make_event_array): Use XINT, not XUINT.
6396 There's no need for unsigned here.
6397
fdccd48e
PE
6398 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6399 This follows up to the 2011-05-06 change that substituted uintptr_t
6400 for EMACS_INT. This case wasn't caught back then.
6401
37910ab2
PE
6402 Rework Fformat to avoid integer overflow issues.
6403 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6404 now (part of C89). Include <verify.h>.
6405 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6406 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6407 (Fformat): Avoid the prepass trying to compute sizes; it was only
6408 approximate and thus did not catch overflow reliably. Instead, walk
6409 through the format just once, formatting and computing sizes as we go,
6410 checking for integer overflow at every step, and allocating a larger
6411 buffer as needed. Keep track separately whether the format is
6412 multibyte. Keep only the most-recently calculated precision, rather
6413 than them all. Record whether each argument has been converted to
6414 string. Use EMACS_INT, not int, for byte and char and arg counts.
6415 Support field widths and precisions larger than INT_MAX. Avoid
6416 sprintf's undefined behavior with conversion specifications such as %#d
6417 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6418 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6419 formatting out-of-range floating point numbers with int
9173deec 6420 formats. (Bug#8668)
37910ab2 6421
2e6578fb
PE
6422 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6423
0ae6bdee
PE
6424 * data.c: Avoid integer truncation in expressions involving floats.
6425 * data.c: Include <intprops.h>.
6426 (arith_driver): When there's an integer overflow in an expression
6427 involving floating point, convert the integers to floating point
6428 so that the resulting value does not suffer from catastrophic
6429 integer truncation. For example, on a 64-bit host (* 4
6430 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6431 Do not rely on undefined behavior after integer overflow.
6432
de883a70
PE
6433 merge count_size_as_multibyte, parse_str_to_multibyte
6434 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6435 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6436 Check for integer overflow.
6437 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6438 since it's now a duplicate of the other. This is more of
6439 a character than a buffer op, so better that it's in character.c.
6440 * fns.c, print.c: Adjust to above changes.
6441
2ff916cb
PE
64422011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6443
6444 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6445
f1b54466
PE
64462011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6447
fb1ac845
PE
6448 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6449 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6450 (x_clipboard_manager_save): Now static.
6451 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6452
f1b54466
PE
6453 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6454 (crypto_hash_function): Now static.
6455 Fix pointer signedness problems. Avoid unnecessary initializations.
6456
a9f737ee
CY
64572011-05-27 Chong Yidong <cyd@stupidchicken.com>
6458
6459 * termhooks.h (Vselection_alist): Make it terminal-local.
6460
6461 * terminal.c (create_terminal): Initialize it.
6462
6463 * xselect.c: Support for clipboard managers.
6464 (Vselection_alist): Move to termhooks.h as terminal-local var.
6465 (LOCAL_SELECTION): New macro.
6466 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6467 (symbol_to_x_atom): Remove gratuitous arg.
6468 (x_handle_selection_request, lisp_data_to_selection_data)
6469 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6470 (x_own_selection, x_get_local_selection, x_convert_selection):
6471 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6472 (some_frame_on_display): Delete unused function.
6473 (Fx_own_selection_internal, Fx_get_selection_internal)
6474 (Fx_disown_selection_internal, Fx_selection_owner_p)
6475 (Fx_selection_exists_p): New optional frame arg.
6476 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6477 (x_handle_selection_clear): Don't treat other terminals with the
6478 same keyboard specially. Use the terminal-local Vselection_alist.
6479 (x_clear_frame_selections): Use Frun_hook_with_args.
6480
6481 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6482
6483 * xterm.h: Add support for those atoms.
6484
e067f0c1
CY
64852011-05-26 Chong Yidong <cyd@stupidchicken.com>
6486
6487 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6488 (converted_selections, conversion_fail_tag): New global variables.
6489 (x_selection_request_lisp_error): Free the above.
6490 (x_get_local_selection): Remove unnecessary code.
6491 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6492 of converted selections stored in converted_selections.
6493 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6494 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6495 (x_convert_selection): New function.
6496 (x_handle_selection_event): Simplify.
6497 (x_get_foreign_selection): Don't ignore incoming requests while
6498 waiting for an answer; this will fail when we implement
6499 SAVE_TARGETS, and seems unnecessary anyway.
6500 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6501 (Vx_sent_selection_functions): Doc fix.
6502
0f4aebc0
LL
65032011-05-26 Leo Liu <sdl.web@gmail.com>
6504
6505 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6506
e61124cd
YM
65072011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6508
6509 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6510
6511 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6512 for fringe update if it has periodic bitmap.
ac389d0c 6513 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6514 and fringe_bitmap_periodic_p.
6515
6516 * fringe.c (get_fringe_bitmap_data): New function.
6517 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6518 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6519 row. Mark glyph row for fringe update if periodicity changed.
6520
6521 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6522 for fringe update unless it has periodic bitmap.
6523
f16d9837
KH
65242011-05-25 Kenichi Handa <handa@m17n.org>
6525
6526 * xdisp.c (get_next_display_element): Set correct it->face_id for
6527 a static composition.
6528
e1b90ef6
LL
65292011-05-24 Leo Liu <sdl.web@gmail.com>
6530
6531 * deps.mk (fns.o):
6532 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6533
6534 * fns.c (crypto_hash_function, Fsha1): New function.
6535 (Fmd5): Use crypto_hash_function.
6536 (syms_of_fns): Add Ssha1.
6537
7400048f
PE
65382011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6539
6540 * gnutls.c: Remove unused macros.
6541 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6542 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6543 Remove macros that are defined and never used.
6544 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6545
abb71cf4
CY
65462011-05-22 Chong Yidong <cyd@stupidchicken.com>
6547
6548 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6549 (Fx_get_selection_internal): Minor cleanup.
6550 (Fx_own_selection_internal): Rename arguments for consistency with
6551 select.el.
6552
6307db39
PE
65532011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6554
6555 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6556
f3d4e0a4
CY
65572011-05-22 Chong Yidong <cyd@stupidchicken.com>
6558
6559 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6560
4d8ade89
YM
65612011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6562
6563 * dispnew.c (scrolling_window): Don't exclude the case that the
6564 last enabled row in the desired matrix touches the bottom boundary.
6565
32078c8d
GM
65662011-05-21 Glenn Morris <rgm@gnu.org>
6567
6568 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6569 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6570 and add some more files.
32078c8d 6571
7285dc67
EZ
65722011-05-20 Eli Zaretskii <eliz@gnu.org>
6573
6574 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6575 report_file_error introduced by the change from 2011-05-07.
6576
89d1bd22
PE
65772011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6578
6579 * systime.h (Time): Define only if emacs is defined.
6580 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6581 where the include path doesn't have X11/X.h by default. See
6582 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6583
cd394be1 65842011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6585
6586 * composite.c (find_automatic_composition): Fix previous change.
6587
b9704ad9
GM
65882011-05-20 Glenn Morris <rgm@gnu.org>
6589
6590 * lisp.mk: New file, split from Makefile.in.
6591 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6592 (shortlisp): Remove.
6593 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6594
4a720484
GM
65952011-05-19 Glenn Morris <rgm@gnu.org>
6596
6597 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6598 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6599 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6600 (lisp): Set the order to that of loadup.el.
6601 (shortlisp): Make it a copy of $lisp.
6602 (SOME_MACHINE_LISP): Remove.
6603 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6604 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6605
a28d4396
KH
66062011-05-18 Kenichi Handa <handa@m17n.org>
6607
6608 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6609 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6610 (find_automatic_composition): Mostly rewrite for efficiency.
6611
a2b1fa8e
JB
66122011-05-18 Juanma Barranquero <lekktu@gmail.com>
6613
6614 * makefile.w32-in: Update dependencies.
6615
8e1f5610
CS
66162011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6617
6618 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6619 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6620
7025ee00 66212011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6622
cdfa6eab
PE
6623 Fix some integer overflow issues, such as string length overflow.
6624
06d6db33
PE
6625 * insdel.c (count_size_as_multibyte): Check for string overflow.
6626
2b4560a8
PE
6627 * character.c (lisp_string_width): Check for string overflow.
6628 Use EMACS_INT, not int, for string indexes and lengths; in
6629 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6630 the resulting string length overflows an EMACS_INT; instead,
6631 report a string overflow if no precision given. When checking for
6632 precision exhaustion, use a check that cannot possibly have
6633 integer overflow. (Bug#8675)
6634 * character.h (lisp_string_width): Adjust to new signature.
6635
cb93f9be
PE
6636 * alloc.c (string_overflow): New function.
6637 (Fmake_string): Use it. This doesn't change behavior, but saves
6638 a few bytes and will simplify future changes.
6639 * character.c (string_escape_byte8): Likewise.
6640 * lisp.h (string_overflow): New decl.
6641
1a1f3366
PE
6642 Fixups, following up to the user-interface timestamp change.
6643 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6644 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6645 * msdos.c (mouse_get_pos): Likewise.
6646 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6647 * w32gui.h (Time): Define by including "systime.h" rather than by
6648 declaring it ourselves. (Bug#8664)
6649
d4e3e4d3
PE
6650 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6651 * image.c (clear_image_cache): Likewise.
6652
f6a24d19
PE
6653 * term.c (term_mouse_position): Don't assume time_t wraparound.
6654
08dc5ae6
PE
6655 Be more systematic about user-interface timestamps.
6656 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6657 and sometimes 'EMACS_UINT', to represent these timestamps.
6658 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6659 This makes the code easier to follow, and makes it easier to catch
6660 integer overflow bugs such as Bug#8664.
6661 * frame.c (Fmouse_position, Fmouse_pixel_position):
6662 Use Time, not unsigned long, for user-interface timestamps.
6663 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6664 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6665 * keyboard.h (last_event_timestamp): Likewise.
6666 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6667 * menu.h (xmenu_show): Likewise.
6668 * term.c (term_mouse_position): Likewise.
6669 * termhooks.h (struct input_event.timestamp): Likewise.
6670 (struct terminal.mouse_position_hook): Likewise.
6671 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6672 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6673 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6674 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6675 what it was before.
6676 * menu.h, termhooks.h: Include "systime.h", for Time.
6677
8e55734a
PE
6678 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6679 Don't assume that the difference between two unsigned long values
6680 can fit into an integer. At this point, we know button_down_time
6681 <= event->timestamp, so the difference must be nonnegative, so
6682 there's no need to cast the result if double-click-time is
6683 nonnegative, as it should be; check that it's nonnegative, just in
6684 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6685 apart (about 25 days). (Bug#8664)
8e55734a 6686
841f1b75 6687 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6688 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6689
3e26f69c
PE
6690 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6691 that always fit in int. Use a sentinel instead of a counter, to
6692 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6693 * frame.h (struct frame): Use int for menu_bar_items_used
6694 instead of EMACS_INT, since it always fits in int.
3e26f69c 6695
5cc152c0
PE
6696 * menu.c (grow_menu_items): Check for int overflow.
6697
d89eb65e
PE
6698 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6699
5235bd3e
PE
6700 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6701 Before, the code was not consistent. These values cannot exceed
6702 2**31 - 1 so there's no need to make them unsigned.
6703 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6704 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6705 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6706 as modifiers.
6707 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6708
bc827e23
PE
6709 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6710 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6711 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6712 presumably because the widths might not match.
6713
78eb494e
PE
6714 * window.c (size_window): Avoid needless test at loop start.
6715
04f2d78b
CB
67162011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6717
6718 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6719
d2fc7e3d 67202011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6721
6722 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6723
d2fc7e3d 67242011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6725
6726 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6727 `width' to `bar_area_x' and `bar_area_width', respectively.
6728 (x_scroll_run): Take account of fringe background extension.
6729
04f2d78b
CB
6730 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6731 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6732 `bar_area_width', respectively.
6733 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6734 background extension.
6735
79b70037
GM
67362011-05-10 Jim Meyering <meyering@redhat.com>
6737
6738 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6739
2f142cc5
JB
67402011-05-10 Juanma Barranquero <lekktu@gmail.com>
6741
6742 * image.c (Finit_image_library): Return t for built-in image types,
6743 like pbm and xbm. (Bug#8640)
6744
57679c86
AS
67452011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6746
6747 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6748
888c9e86
EZ
67492011-05-07 Eli Zaretskii <eliz@gnu.org>
6750
b0512a1d
EZ
6751 * w32console.c (Fset_screen_color): Doc fix.
6752 (Fget_screen_color): New function.
6753 (syms_of_ntterm): Defsubr it.
6754
7285dc67
EZ
6755 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6756 unlink the temporary file if Fcall_process didn't create it in the
6757 first place.
6758 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6759 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6760 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6761 cue to call_process_cleanup not to close that handle.
6762
4d3fcc8e
BK
67632011-05-07 Ben Key <bkey76@gmail.com>
6764
6765 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6766 one of two shell specific rules, either bootstrap-temacs-CMD or
6767 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6768 to the previous implementation of the bootstrap-temacs rule.
6769 The bootstrap-temacs-CMD rule is similar to the previous
6770 implementation of the bootstrap-temacs rule except that it
6771 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6772 variable.
6773
6774 These changes, along with some changes to nt/configure.bat,
6775 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6776 earlier fix to add support for --cflags and --ldflags options
6777 that include quotes so that it works whether make uses cmd or
6778 sh as the shell.
6779
b4289b64
MA
67802011-05-06 Michael Albinus <michael.albinus@gmx.de>
6781
6782 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6783 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6784 is a constant.
6785 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6786 a string. Handle both cases.
6787 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6788 (Fdbus_register_method): Use Qinvalid_function.
6789
af4c0e28
JB
67902011-05-06 Juanma Barranquero <lekktu@gmail.com>
6791
6792 * makefile.w32-in: Update dependencies.
6793 (LISP_H): Add inttypes.h and stdin.h.
6794 (PROCESS_H): Add unistd.h.
6795
c51453d9
EZ
67962011-05-06 Eli Zaretskii <eliz@gnu.org>
6797
6798 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6799 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6800
8ff0ac3c 68012011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6802
4c4b566b
PE
6803 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6804
aab2b9b5
PE
6805 * term.c (vfatal): Remove stray call to va_end.
6806 It's not needed and the C Standard doesn't allow it here anyway.
6807
c378da0b
PE
6808 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6809 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6810
288b08c7
PE
6811 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6812 bytes.
6813
e3601888
PE
6814 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6815
db6c0e74
PE
6816 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6817
dd5963ea
PE
6818 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6819
88c9450f
PE
6820 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6821
2f9442b8
PE
6822 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6823
c032b5f8
PE
6824 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6825 * charset.c (Fdefine_charset_internal): Don't initialize
6826 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6827 32-bit int (Bug#8600).
a108c10b
PE
6828
6829 * lread.c (read_integer): Be more consistent with string-to-number.
6830 Use string_to_number to do the actual conversion; this avoids
6831 rounding errors and fixes some other screwups. Without this fix,
6832 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6833 (digit_to_number): Move earlier, for benefit of read_integer.
6834 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6835 not a digit in any supported base. (Bug#8602)
a108c10b 6836
ad5f9eea
PE
6837 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6838
aec1708a
PE
6839 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6840 to match comment at start of function. This also removes a
6841 GCC warning about overflow in a 32+64-bit port.
6842
47be4ab5
PE
6843 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6844
371cac43
PE
6845 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6846 Reported by Stefan Monnier in
6847 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6848 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6849 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6850
d01a7826
PE
6851 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6852 (EMACS_UINTPTR): Likewise, with uintptr_t.
6853
7fd47d5c
PE
6854 * lisp.h: Prefer 64-bit EMACS_INT if available.
6855 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6856 on 32-bit hosts that have 64-bit int, so that they can access
6857 large files.
122b0c86
PE
6858 However, temporarily disable this change unless the temporary
6859 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6860
8727937b
PE
6861 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6862
8ac068ac
PE
6863 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6864 This removes an assumption that EMACS_INT and long are the same
6865 width as pointers. The assumption is true for Emacs porting targets
6866 now, but we want to make other targets possible.
6867 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6868 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6869 In the rest of the code, change types of integers that hold casted
6870 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6871 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6872 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6873 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6874 No need to cast type when ORing.
6875 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6876 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6877 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6878 assume EMACS_INT is the same width as char *.
6879 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6880 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6881 Remove no-longer-needed casts.
6882 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6883 (xg_tool_bar_help_callback, xg_make_tool_item):
6884 Use EMACS_INTPTR to hold an integer
6885 that will be cast to void *; this can avoid a GCC warning
6886 if EMACS_INT is not the same width as void *.
6887 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6888 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6889 (current_message_1, set_message_1):
6890 Use a local to convert to proper width without a cast.
6891 * xmenu.c (dialog_selection_callback): Likewise.
6892
ede49d71
PE
6893 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6894 Also, don't assume VALBITS / RAND_BITS is less than 5,
6895 and don't rely on undefined behavior when shifting a 1 left into
6896 the sign bit.
6897 * lisp.h (get_random): Change signature to match.
6898
2f30ecd0
PE
6899 * lread.c (hash_string): Use size_t, not int, for hash computation.
6900 Normally we prefer signed values; but hashing is special, because
6901 it's better to use unsigned division on hash table sizes so that
6902 the remainder is nonnegative. Also, size_t is the natural width
6903 for hashing into memory. The previous code used 'int', which doesn't
6904 retain enough info to hash well into very large tables.
6905 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6906
2a866e7b
PE
6907 * dbusbind.c: Don't possibly lose pointer info when converting.
6908 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6909 Use XPNTR rather than XHASH, so that the high-order bits of
6910 the pointer aren't lost when converting through void *.
6911
51639eac
PE
6912 * eval.c (Fautoload): Don't double-shift a pointer.
6913
92394119
PE
6914 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6915
dbdb9a7c
JB
69162011-05-06 Juanma Barranquero <lekktu@gmail.com>
6917
6918 * gnutls.c (DEF_GNUTLS_FN):
6919 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6920
db7a0b4f
AS
69212011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6922
6923 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6924 marker. (Bug#8610)
6925
cd394be1 69262011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6927
6928 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6929 New version that can reserve upto 2GB of heap space.
6930
f7ff1b0f 69312011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6932
6933 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6934
639c109b
TZ
69352011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6936
6937 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6938 `gnutls_certificate_set_x509_key_file'.
6939
d2127135
JB
69402011-05-05 Juanma Barranquero <lekktu@gmail.com>
6941
6942 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6943 Update dependencies.
6944
e968f4f3
JB
69452011-05-04 Juanma Barranquero <lekktu@gmail.com>
6946
6947 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6948 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6949 Remove unused parameter `fildes'.
6950 * process.c (read_process_output, send_process): Don't pass it.
6951
84d358f0
JB
69522011-05-04 Juanma Barranquero <lekktu@gmail.com>
6953
6954 Fix previous change: the library cache is defined in w32.c.
6955 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6956 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6957
0898ca10
JB
69582011-05-04 Juanma Barranquero <lekktu@gmail.com>
6959
6960 Implement dynamic loading of GnuTLS on Windows.
6961
6962 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6963 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6964 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6965 Declare.
6966
6967 * gnutls.c (Qgnutls_dll): Define.
6968 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6969 (gnutls_*): Declare function pointers.
6970 (init_gnutls_functions): New function to initialize function pointers.
6971 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6972 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6973 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6974 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6975 (emacs_gnutls_write, emacs_gnutls_read)
6976 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6977 (Fgnutls_available_p): New function.
6978 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6979 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6980 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6981
6982 * image.c: Include w32.h.
6983 (Vimage_type_cache): Delete.
6984 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6985 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6986 (w32_delayed_load): Move to w32.c.
6987
6988 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6989
6990 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6991 (w32_delayed_load): Move from image.c. When loading a library, record
6992 its filename in the :loaded-from property of the library id.
6993 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6994 Initialize and staticpro them.
6995 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6996
6997 * process.c: Include lisp.h before w32.h, not after.
6998 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6999 instead of gnutls_record_check_pending.
7000
7001 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7002
ff4de4aa
TZ
70032011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7004
7005 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7006 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7007 as passed in.
7008
abe95abb
JD
70092011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7010
7011 * xterm.c (x_set_frame_alpha): Do not set property on anything
7012 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7013
e16e55d4
JB
70142011-05-02 Juanma Barranquero <lekktu@gmail.com>
7015
7016 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7017
bafcf6a5
JB
70182011-05-02 Juanma Barranquero <lekktu@gmail.com>
7019
7020 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7021 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7022 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7023 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7024 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7025 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7026 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7027 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7028 (Qgnutls_bootprop_callbacks_verify): Make static.
7029
e7a6747f
AS
70302011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7031
19ed11ba
AS
7032 * callproc.c: Indentation fixup.
7033
e7a6747f 7034 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7035 (wait_for_termination, interruptible_wait_for_termination):
7036 Move after wait_for_termination_1.
e7a6747f 7037
1ef14cb4
LMI
70382011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7039
7040 * sysdep.c (interruptible_wait_for_termination): New function
7041 which is like wait_for_termination, but allows keyboard
7042 interruptions.
7043
7044 * callproc.c (Fcall_process): Add (:file "file") as an option for
7045 the STDOUT buffer.
7046 (Fcall_process_region): Ditto.
7047
330d880c
EZ
70482011-04-30 Eli Zaretskii <eliz@gnu.org>
7049
8db90b73
EZ
7050 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7051 rather than `XVECTOR (FOO)->size'.
7052
330d880c
EZ
7053 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7054 inttypes.h, as a gnulib replacement is used if it not available in
7055 system headers.
7056
15cbd324
EZ
70572011-04-21 Eli Zaretskii <eliz@gnu.org>
7058
7059 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7060 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7061 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7062
7063 * coding.c (coding_alloc_by_realloc): Error out if destination
7064 will grow beyond MOST_POSITIVE_FIXNUM.
7065 (decode_coding_emacs_mule): Abort if there isn't enough place in
7066 charbuf for the composition carryover bytes. Reserve an extra
7067 space for up to 2 characters produced in a loop.
7068 (decode_coding_iso_2022): Abort if there isn't enough place in
7069 charbuf for the composition carryover bytes.
7070
70712011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7072
ae940cca
EZ
7073 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7074 aborting when %lld or %lll format is passed.
7075 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7076 %llo or %llx format is passed. (Bug#8545)
7077
03ab8921
EZ
7078 * window.c (window_scroll_line_based): Use a marker instead of
7079 simple variables to record original value of point. (Bug#7952)
7080
afda1437
EZ
7081 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7082 produced by %s or %c overflows available buffer space. (Bug#8545)
7083
f76dee0c
PE
70842011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7085
7086 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7087 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7088
fdc5744d
JB
70892011-04-28 Juanma Barranquero <lekktu@gmail.com>
7090
7091 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7092
638f053a
JB
70932011-04-28 Juanma Barranquero <lekktu@gmail.com>
7094
7095 * keyboard.c (Qdelayed_warnings_hook): Define.
7096 (command_loop_1): Run `delayed-warnings-hook'
7097 if Vdelayed_warnings_list is non-nil.
7098 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7099 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7100
d178f871
EZ
71012011-04-28 Eli Zaretskii <eliz@gnu.org>
7102
7103 * doprnt.c (doprnt): Don't return value smaller than the buffer
7104 size if the message was truncated. (Bug#8545).
7105
b124fd93
JB
71062011-04-28 Juanma Barranquero <lekktu@gmail.com>
7107
7108 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7109 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7110
e810457d
PE
71112011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7112
7113 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7114
ea51cceb
JB
71152011-04-27 Juanma Barranquero <lekktu@gmail.com>
7116
7117 * makefile.w32-in: Update dependencies.
7118
94dcfacf
EZ
71192011-04-27 Eli Zaretskii <eliz@gnu.org>
7120
7121 Improve `doprnt' and its usage. (Bug#8545)
7122 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7123 `format_end'. Remove support for %l as a conversion specifier.
7124 Don't use xrealloc. Improve diagnostics when the %l size modifier
7125 is used. Update the commentary.
7126
7127 * eval.c (verror): Simplify calculation of size_t.
7128
7129 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7130 messages.
7131
f61f41d7
PE
71322011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7133
7134 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7135 change.
7136
96fb4434
PE
71372011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7138
7139 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7140 This makes this file independent of the recent pseudovector change.
7141
671875da 71422011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7143
69e9b5a3
PE
7144 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7145
b5f869a7 7146 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7147 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7148 Remove unused local.
c8926152 7149 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7150
841a1577 7151 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7152 GCC 4.6.0 optimizes based on type-based alias analysis.
7153 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7154 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7155 != &v->size, and therefore "v->size = 1; b->size = 2; return
7156 v->size;" must therefore return 1. This assumption is incorrect
7157 for Emacs, since it type-puns struct Lisp_Vector * with many other
7158 types. To fix this problem, this patch adds a new type struct
f904488f 7159 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7160 and pseudovectors, and helps optimizing compilers not get fooled
7161 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7162 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7163 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7164 the size member.
eab3844f
PE
7165 (XSETPVECTYPE): Rewrite in terms of new macro.
7166 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7167 This is a bit clearer, and further avoids the possibility of
7168 undesirable aliasing.
7169 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7170 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7171 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7172 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7173 (ASIZE): Now uses header.size rather than size.
7174 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7175 to avoid the hassle of writing XVECTOR (foo)->header.size.
7176 (struct vectorlike_header): New type.
eab3844f
PE
7177 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7178 object, to help avoid aliasing.
7179 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7180 (SUBRP): Likewise, since Lisp_Subr is a special case.
7181 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7182 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7183 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7184 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7185 changed to be "header.size" and "header.next".
7186 * buffer.h (struct buffer): Likewise.
7187 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7188 * frame.h (struct frame): Likewise.
7189 * process.h (struct Lisp_Process): Likewise.
7190 * termhooks.h (struct terminal): Likewise.
7191 * window.c (struct save_window_data, struct saved_window): Likewise.
7192 * window.h (struct window): Likewise.
7193 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7194 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7195 * buffer.c (init_buffer_once): Likewise.
7196 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7197 special case.
7198 * process.c (Fformat_network_address): Use local var for size,
7199 for brevity.
7200
0df1eac5
PE
7201 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7202
847ab9d1 7203 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7204 * data.c (atof): Remove decl; no longer used or needed.
7205 (digit_to_number): Move to lread.c.
7206 (Fstring_to_number): Use new string_to_number function, to be
7207 consistent with how the Lisp reader treats infinities and NaNs.
7208 Do not assume that floating-point numbers represent EMACS_INT
7209 without losing information; this is not true on most 64-bit hosts.
7210 Avoid double-rounding errors, by insisting on integers when
7211 parsing non-base-10 numbers, as the documentation specifies.
7212 * lisp.h (string_to_number): New decl, replacing ...
7213 (isfloat_string): Remove.
bc0a5c13 7214 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7215 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7216 appears to have been a coding error. Similarly, do not accept
7217 strings like +-1e0 as floating point numbers. Do not report
7218 overflow for integer overflows unless the base is not 10 which
7219 means we have no simple and reliable way to continue.
7220 Break out the floating-point parsing into a new
7221 function string_to_number, so that Fstring_to_number parses
7222 floating point numbers consistently with the Lisp reader.
04f2d78b 7223 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7224 (E_CHAR, EXP_INT): Remove, replacing with ...
7225 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7226 (string_to_number): New function, replacing isfloat_string.
7227 This function checks for valid syntax and produces the resulting
7228 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7229 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7230 so that overflow for non-base-10 numbers is reported only when
7231 there's no portable and simple way to convert to floating point.
452f4150 7232
67769ffc
PE
7233 * textprop.c (set_text_properties_1): Rewrite for clarity,
7234 and to avoid GCC warning about integer overflow.
7235
c20db43f
PE
7236 * intervals.h (struct interval): Use EMACS_INT for members
7237 where EMACS_UINT might cause problems. See
7238 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7239 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7240 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7241 All uses changed.
37aa2f85
PE
7242 (offset_intervals): Tell GCC not to worry about length overflow
7243 when negating a negative length.
c20db43f 7244
2538aa2f
PE
7245 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7246 (overrun_check_free): Likewise.
7247
f2d3008d
PE
7248 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7249 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7250 word size.
7251
ec8df744
PE
7252 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7253 (gnutls_make_error): Rename local to avoid shadowing.
7254 (gnutls_emacs_global_deinit): ifdef out; not used.
7255 (Fgnutls_boot): Use const for pointer to readonly storage.
7256 Comment out unused local. Fix pointer signedness problems.
7257
640ee02d
PE
7258 * lread.c (openp): Don't stuff size_t into an 'int'.
7259 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7260 about possible signed overflow.
7261
6048fb2a
PE
7262 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7263 (GDK_KEY_g): Don't define if already defined.
7264 (xg_prepare_tooltip): Avoid pointer signedness problem.
7265 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7266
fa3c87e1
PE
7267 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7268 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7269
2172544b
PE
7270 * xfns.c (Fx_window_property): Simplify a bit,
7271 to make a bit faster and to avoid GCC 4.6.0 warning.
7272 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7273
9b821a21
PE
7274 * fns.c (internal_equal): Don't assume size_t fits in int.
7275
3c616cfa
PE
7276 * alloc.c (compact_small_strings): Tighten assertion a little.
7277
c2982e87
PE
7278 Replace pEd with more-general pI, and fix some printf arg casts.
7279 * lisp.h (pI): New macro, generalizing old pEd macro to other
7280 conversion specifiers. For example, use "...%"pI"d..." rather
7281 than "...%"pEd"...".
7282 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7283 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7284 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7285 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7286 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7287 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7288 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7289 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7290 64-bit hosts.
7291 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7292 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7293 * print.c (safe_debug_print, print_object): Likewise.
7294 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7295 to int.
6f04d126
PE
7296 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7297 avoiding the 0 flag, which is not portable.
c2982e87
PE
7298 * process.c (Fmake_network_process): Use pI to avoid cast.
7299 * region-cache.c (pp_cache): Likewise.
7300 * xdisp.c (decode_mode_spec): Likewise.
7301 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7302 behavior on 64-bit hosts with printf arg.
6f04d126 7303 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7304 (x_stop_queuing_selection_requests): Likewise.
7305 (x_get_window_property): Don't truncate byte count to an 'int'
7306 when tracing.
0b432f21 7307
5e073ec7
PE
7308 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7309 here, since it parses constructs like leading '-' and spaces,
7310 which are not wanted; and it overflows with large numbers.
7311 Instead, simply match F[0-9]+, which is what is wanted anyway.
7312
36372bf9
PE
7313 * alloc.c: Remove unportable assumptions about struct layout.
7314 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7315 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7316 (allocate_vectorlike, make_pure_vector): Use the new macros,
7317 plus offsetof, to remove unportable assumptions about struct layout.
7318 These assumptions hold on all porting targets that I know of, but
7319 they are not guaranteed, they're easy to remove, and removing them
7320 makes further changes easier.
7321
0b432f21
PE
7322 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7323 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7324 (string_overrun_cookie): Now const. Use initializers that
7325 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7326 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7327 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7328 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7329 multiple of sizeof (EMACS_INT); it need not be, if
7330 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7331 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7332
895009e1
JB
73332011-04-26 Juanma Barranquero <lekktu@gmail.com>
7334
7335 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7336
6a7a1b0b
TZ
73372011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7338
7339 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7340 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7341 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7342
841a1577 73432011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7344
7345 * lisp.h (Qdebug): List symbol.
895009e1 7346 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7347 * keyboard.c (debug-on-event): New variable.
7348 (handle_user_signal): Break into debugger when debug-on-event
7349 matches the current signal symbol.
7350
f2d3ba6f
DN
73512011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7352
7353 * alloc.c (check_sblock, check_string_bytes)
7354 (check_string_free_list): Convert to standard C.
7355
42ce4c63
TZ
73562011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7357
7358 * w32.c (emacs_gnutls_push): Fix typo.
7359
825cd63c
EZ
73602011-04-25 Eli Zaretskii <eliz@gnu.org>
7361
fb11d64d
EZ
7362 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7363 "cast to pointer from integer of different size".
7364
825cd63c
EZ
7365 Improve doprnt and its use in verror. (Bug#8545)
7366 * doprnt.c (doprnt): Document the set of format control sequences
7367 supported by the function. Use SAFE_ALLOCA instead of always
7368 using `alloca'.
7369
7370 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7371 is one byte too soon. Don't use xrealloc; instead xfree and
7372 xmalloc anew.
7373
e061a11b
TZ
73742011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7375
7376 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7377 callbacks stage.
7378
7379 * gnutls.c: Renamed global_initialized to
7380 gnutls_global_initialized. Added internals for the
7381 :verify-hostname-error, :verify-error, and :verify-flags
7382 parameters of `gnutls-boot' and documented those parameters in the
7383 docstring. Start callback support.
9173deec
JB
7384 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7385 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7386 on error. Return error code.
e061a11b
TZ
7387 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7388 (emacs_gnutls_read): Likewise.
7389 (Fgnutls_boot): Return handshake error code.
7390 (emacs_gnutls_handle_error): New function.
7391 (wsaerror_to_errno): Likewise.
7392
7393 * w32.h (emacs_gnutls_pull): Add prototype.
7394 (emacs_gnutls_push): Likewise.
7395
7396 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7397 (emacs_gnutls_push): Likewise.
7398
73992011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7400
7401 * process.c (wait_reading_process_output): Check if GnuTLS
7402 buffered some data internally if no FDs are set for TLS
7403 connections.
7404
7405 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7406 (LIBS): Link to USER_LIBS.
7407 ($(BLD)/gnutls.$(0)): New target.
7408
fa6996bc
EZ
74092011-04-24 Eli Zaretskii <eliz@gnu.org>
7410
eb35682e
EZ
7411 * xdisp.c (handle_single_display_spec): Rename the
7412 display_replaced_before_p argument into display_replaced_p, to
7413 make it consistent with the commentary. Fix typos in the
7414 commentary.
7415
e2ad650c
EZ
7416 * textprop.c (syms_of_textprop): Remove dead code.
7417 (copy_text_properties): Delete obsolete commentary about an
7418 interface that was deleted long ago. Fix typos in the description
7419 of arguments.
7420
1b2de274
EZ
7421 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7422 to changes in oldXMenu/XMenu.h from 2011-04-16.
7423 <menu_help_message, prev_menu_help_message>: Constify.
7424 (IT_menu_make_room): menu->help_text is now `const char **';
7425 adjust.
7426
7427 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7428 to changes in oldXMenu/XMenu.h from 2011-04-16.
7429 (struct XMenu): Declare `help_text' `const char **'.
7430
7431 * xfaces.c <Qunspecified>: Make extern again.
7432
7433 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7434 required by POSIX.
1b2de274 7435
762b15be
EZ
7436 * doc.c (get_doc_string): Improve the format passed to `error'.
7437
7438 * doprnt.c (doprnt): Improve commentary.
7439
7440 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7441
7442 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7443 them with etags.
7444
f1052e5d
EZ
7445 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7446 changes in globals.h immediately force recompilation.
762b15be
EZ
7447 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7448 $(CURDIR)/s/ms-w32.h.
7449 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7450
fa6996bc
EZ
7451 * character.c (Fchar_direction): Function deleted.
7452 (syms_of_character): Don't defsubr it.
7453 <char-direction-table>: Deleted.
7454
e6c3da20
EZ
74552011-04-23 Eli Zaretskii <eliz@gnu.org>
7456
7457 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7458 * doprnt.c: Include limits.h.
7459 (SIZE_MAX): New macro.
04f2d78b
CB
7460 (doprnt): Return a size_t value. 2nd arg is now size_t.
7461 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7462 Improve overflow protection. Support `l' modifier for integer
7463 conversions. Support %l conversion. Don't assume an EMACS_INT
7464 argument for integer conversions and for %c.
7465
7466 * lisp.h (doprnt): Restore prototype.
7467
7468 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7469 $(SRC)/character.h.
7470
7471 * Makefile.in (base_obj): Add back doprnt.o.
7472
7473 * deps.mk (doprnt.o): Add back prerequisites.
7474 (callint.o): Depend on character.h.
7475
7476 * eval.c (internal_lisp_condition_case): Include the handler
7477 representation in the error message.
7478 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7479 when breaking from the loop.
7480
7481 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7482
7483 * callint.c (Fcall_interactively): When displaying error message
7484 about invalid control letter, pass the character's codepoint, not
7485 a pointer to its multibyte form. Improve display of the character
7486 in octal and display also its hex code.
7487
7488 * character.c (char_string): Use %x to display the (unsigned)
7489 codepoint of an invalid character, to avoid displaying a bogus
7490 negative value.
7491
7492 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7493 `error', not SYMBOL_NAME itself.
7494
7495 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7496 character arguments to `error'.
7497
7498 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7499 to `error' in error message about FINAL_CHAR argument. Make sure
7500 FINAL_CHAR is a character, and use %c when it is passed as
7501 argument to `error'.
7502
4ffd0d6b 75032011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7504
7505 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7506
7507 * w32.c: Include <time.h>.
7508 (sys_localtime): New function.
7509
4ffd0d6b 75102011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7511
7512 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7513
4ffd0d6b 7514 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7515
4ffd0d6b 75162011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7517
4ffd0d6b
GM
7518 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7519 zombies (Bug#8467).
aac0c6e3 7520
04c56954
EZ
75212011-04-19 Eli Zaretskii <eliz@gnu.org>
7522
7523 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7524 gl_state.e_property when gl_state.object is Qt.
7525
7526 * insdel.c (make_gap_larger): Remove limitation of buffer size
7527 to <= INT_MAX.
7528
16a43933
CY
75292011-04-18 Chong Yidong <cyd@stupidchicken.com>
7530
7531 * xdisp.c (lookup_glyphless_char_display)
7532 (produce_glyphless_glyph): Handle cons cell entry in
7533 glyphless-char-display.
7534 (Vglyphless_char_display): Document it.
7535
7536 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7537 glyphless-char-display.
7538
4581706e
CY
75392011-04-17 Chong Yidong <cyd@stupidchicken.com>
7540
7541 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7542
7543 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7544
7545 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7546 definition for no-X builds.
7547
4887c6e2 75482011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7549
fd35b6f9
PE
7550 Static checks with GCC 4.6.0 and non-default toolkits.
7551
5c1ccb01
PE
7552 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7553
006c5daa
PE
7554 * process.c (keyboard_bit_set): Define only if SIGIO.
7555 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7556 (send_process): Repair possible setjmp clobbering.
7557
efc736d3
PE
7558 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7559
4e2fe2e6
PE
7560 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7561
f97334a2
PE
7562 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7563
4e75f29d
PE
7564 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7565 Define only if needed.
7566
90efadd1
PE
7567 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7568 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7569 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7570
3c647824
PE
7571 * dispextern.h (struct redisplay_interface): Rename param
7572 to avoid shadowing.
e264f262 7573 * termhooks.h (struct terminal): Likewise.
761383f4 7574 * xterm.c (xembed_send_message): Likewise.
3c647824 7575
b58c5c4a
PE
7576 * insdel.c (make_gap_smaller): Define only if
7577 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7578
cad59032
PE
7579 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7580 it.
7581
c339dc2e
PE
7582 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7583 so that we aren't warned about unused symbols.
7584
91a3e27b
PE
7585 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7586
399c71d3 7587 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7588
8ffc96f5
PE
7589 * xfns.c (x_real_positions): Mark locals as initialized.
7590
eef9bc79
PE
7591 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7592
098db9dd
PE
7593 * xterm.c: Fix problems found by static analysis with other toolkits.
7594 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7595 (x_dispatch_event): Declare static if USE_GTK, and
7596 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7597 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7598 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7599 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7600 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7601
eb18f6cc
PE
7602 * xmenu.c (menu_help_callback): Pointer type fixes.
7603 Use const pointers when pointing at readonly data. Avoid pointer
7604 signedness clashes.
7605 (FALSE): Remove unused macro.
7606 (update_frame_menubar): Remove unused decl.
7607
1fe72bf8
PE
7608 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7609
60d9e1db
PE
7610 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7611 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7612 (single_menu_item): Rename local to avoid shadowing.
7613
39261c26
PE
7614 * keyboard.c (make_lispy_event): Remove unused local var.
7615
018c5e19
PE
7616 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7617 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7618
63d2b86e
PE
7619 * bitmaps: Change bitmaps from unsigned char back to the X11
7620 compatible char. Avoid the old compiler warnings about
7621 out-of-range initializers by using, for example, '\xab' rather
7622 than 0xab.
7623
aefd87e1
PE
7624 * xgselect.c (xgselect_initialize): Check vs interface
7625 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7626
bf501fb9
PE
7627 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7628
e9829fdf
PE
7629 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7630 to read-only memory.
7631
1086c095
PE
7632 * fns.c (vector): Remove; this old hack is no longer needed.
7633
2baccd04 7634 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7635 Remove unused var.
dde42981 7636 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7637
72391843 7638 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7639
436c16df 7640 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7641 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7642 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7643
92bb796d 7644 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7645 (x_term_init): Remove local to avoid shadowing.
92bb796d 7646
764430a3 7647 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7648
7649 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7650 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7651
d1dfb56c
EZ
76522011-04-16 Eli Zaretskii <eliz@gnu.org>
7653
c4354cb4
EZ
7654 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7655
d1dfb56c
EZ
7656 Fix regex.c, syntax.c and friends for buffers > 2GB.
7657 * syntax.h (struct gl_state_s): Declare character position members
7658 EMACS_INT.
7659
7660 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7661
04f2d78b
CB
7662 * textprop.c (verify_interval_modification, interval_of):
7663 Declare arguments EMACS_INT.
d1dfb56c
EZ
7664
7665 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7666 EMACS_INT.
7667
7668 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7669
7670 * indent.c (Fvertical_motion): Local variable it_start is now
7671 EMACS_INT.
7672
7673 * regex.c (re_match, re_match_2, re_match_2_internal)
7674 (bcmp_translate, regcomp, regexec, print_double_string)
7675 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7676 (re_compile_pattern, re_exec): Declare arguments and local
7677 variables `size_t' and `ssize_t' and return values `regoff_t', as
7678 appropriate.
7679 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7680 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7681 <compile_stack_type>: `size' and `avail' are now `size_t'.
7682
7683 * regex.h <regoff_t>: Use ssize_t, not int.
7684 (re_search, re_search_2, re_match, re_match_2): Arguments that
7685 specify buffer/string position and length are now ssize_t and
7686 size_t. Return type is regoff_t.
7687
613052cd
BK
76882011-04-16 Ben Key <bkey76@gmail.com>
7689
7690 * nsfont.m: Fixed bugs in ns_get_family and
7691 ns_descriptor_to_entity that were caused by using free to
7692 deallocate memory blocks that were allocated by xmalloc (via
7693 xstrdup). This caused Emacs to crash when compiled with
7694 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7695 --enable-checking=xmallocoverrun). xfree is now used to
7696 deallocate these memory blocks.
7697
4170f62f 76982011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7699
71b41406
PE
7700 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7701
9587a89d
PE
7702 emacs_write: Accept and return EMACS_INT for sizes.
7703 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7704 et seq.
7705 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7706 Accept and return EMACS_INT.
7707 (emacs_gnutls_write): Return the number of bytes written on
7708 partial writes.
7709 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7710 (emacs_read, emacs_write): Remove check for negative size, as the
7711 Emacs source code has been audited now.
9587a89d
PE
7712 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7713 (emacs_read, emacs_write): Use it.
273a5f82
PE
7714 * process.c (send_process): Adjust to the new signatures of
7715 emacs_write and emacs_gnutls_write. Do not attempt to store
7716 a byte offset into an 'int'; it might overflow.
9587a89d 7717 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7718
3e047f51
PE
7719 * sound.c: Don't assume sizes fit in 'int'.
7720 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7721 Return EMACS_INT, not int.
3e047f51 7722 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7723 Accept EMACS_INT, not int.
7724 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7725 record read return values.
7726
cc39a9db
BK
77272011-04-15 Ben Key <bkey76@gmail.com>
7728
c9d0ec6d
JB
7729 * keyboard.c (Qundefined): Don't declare static since it is used
7730 in nsfns.m.
7731 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7732 static since they are used in nsfont.m.
cc39a9db 7733
6c60eb9f
SM
77342011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7735
7736 * process.c (Qprocessp): Don't declare static.
7737 * lisp.h (Qprocessp): Declare again.
7738
7990b61a
JB
77392011-04-15 Juanma Barranquero <lekktu@gmail.com>
7740
7741 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7742
5d4cb038
PE
77432011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7744
8bd7b830 7745 Improve C-level modularity by making more things 'static'.
cd64ea1d 7746
e3b27b31
PE
7747 Don't publish debugger-only interfaces to other modules.
7748 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7749 (verify_bytepos, count_markers): Move decls to the only modules
7750 that need them.
7751 * region-cache.h (pp_cache): Likewise.
7752 * window.h (check_all_windows): Likewise.
7753 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7754
5d4cb038
PE
7755 * sysdep.c (croak): Now static, if
7756 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7757 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7758
7759 * alloc.c (refill_memory_reserve): Now static if
7760 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7761 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7762
e87b6180
PE
7763 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7764 Define only if USE_LUCID.
7765
ac64929e
PE
7766 * xrdb.c (x_customization_string, x_rm_string): Now static.
7767
6f37259d
PE
7768 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7769 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7770
1683e3ab
PE
7771 * xdisp.c (draw_row_with_mouse_face): Now static.
7772 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7773
de9c2632
PE
7774 * window.h (check_all_windows): Mark externally visible.
7775
2b96acb7
PE
7776 * window.c (window_deletion_count): Now static.
7777
7778 * undo.c: Make symbols static if they're not exported.
7779 (last_undo_buffer, last_boundary_position, pending_boundary):
7780 Now static.
7781
50436f33
PE
7782 * textprop.c (interval_insert_behind_hooks): Now static.
7783 (interval_insert_in_front_hooks): Likewise.
7784
64520e5c
PE
7785 * term.c: Make symbols static if they're not exported.
7786 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7787 (max_frame_lines, tty_set_terminal_modes):
7788 (tty_reset_terminal_modes, tty_turn_off_highlight):
7789 (get_tty_terminal): Now static.
7790 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7791 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7792 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7793 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7794 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7795
1fa53021
PE
7796 * sysdep.c: Make symbols static if they're not exported.
7797 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7798 Now static.
7799 (sigprocmask_set, full_mask): Remove; unused.
7800 (wait_debugging): Mark as visible.
7801 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7802 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7803
d4b43b22
PE
7804 * syntax.c (syntax_temp): Define only if !__GNUC__.
7805
b7c513d0
PE
7806 * sound.c (current_sound_device, current_sound): Now static.
7807
989b29ad
PE
7808 * search.c (searchbufs, searchbuf_head): Now static.
7809
13a55a78
PE
7810 * scroll.c (scroll_cost): Remove; unused.
7811 * dispextern.h (scroll_cost): Remove decl.
7812
de68a1fc
PE
7813 * region-cache.h (pp_cache): Mark as externally visible.
7814
40ccffa6
PE
7815 * process.c: Make symbols static if they're not exported.
7816 (process_tick, update_tick, create_process, chan_process):
7817 (Vprocess_alist, proc_buffered_char, datagram_access):
7818 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7819 (deactivate_process): Mark defn as static, as well as decl.
7820 * lisp.h (create_process): Remove decl.
7821 * process.h (chan_process, Vprocess_alist): Remove decls.
7822
ad64fc97
PE
7823 * print.c: Make symbols static if they're not exported.
7824 (print_depth, new_backquote_output, being_printed, print_buffer):
7825 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7826 (print_interval, print_number_index, initial_stderr_stream):
7827 Now static.
7828 * lisp.h (Fprinc): Remove decl.
7829 (debug_output_compilation_hack): Mark as externally visible.
7830
adddb265
PE
7831 * sysdep.c (croak): Move decl from here to syssignal.h.
7832 * syssignal.h (croak): Put it here, so the API can be checked when
7833 'croak' is called from dissociate_if_controlling_tty.
7834
1717ede2
PE
7835 * minibuf.c: Make symbols static if they're not exported.
7836 (minibuf_save_list, choose_minibuf_frame): Now static.
7837 * lisp.h (choose_minibuf_frame): Remove decl.
7838
fa5fb2bc
PE
7839 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7840
1e3890d1
PE
7841 * lread.c: Make symbols static if they're not exported.
7842 (read_objects, initial_obarray, oblookup_last_bucket_number):
7843 Now static.
7844 (make_symbol): Remove; unused.
7845 * lisp.h (initial_obarray, make_symbol): Remove decls.
7846
8a1414fa
PE
7847 * keyboard.c: Make symbols static if they're not exported.
7848 (single_kboard, recent_keys_index, total_keys, recent_keys):
7849 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7850 (this_single_command_key_start, echoing, last_auto_save):
7851 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7852 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7853 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7854 (Vlispy_mouse_stem, double_click_count):
7855 Now static.
7856 (force_auto_save_soon): Define only if SIGDANGER.
7857 (ignore_mouse_drag_p): Now static if
7858 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7859 (print_help): Remove; unused.
7860 (stop_character, last_timer_event): Mark as externally visible.
7861 * keyboard.h (ignore_mouse_drag_p): Declare only if
7862 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7863 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7864 * lisp.h (echoing): Remove decl.
7865 (force_auto_save_soon): Declare only if SIGDANGER.
7866 * xdisp.c (redisplay_window): Simplify code, to make it more
7867 obvious that ignore_mouse_drag_p is not accessed if !defined
7868 USE_GTK && !defined HAVE_NS.
7869
93ea6e8f
PE
7870 * intervals.c: Make symbols static if they're not exported.
7871 (merge_properties_sticky, merge_interval_right, delete_interval):
7872 Now static.
7873 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7874
77382fcc
PE
7875 * insdel.c: Make symbols static if they're not exported.
7876 However, leave prepare_to_modify_buffer alone. It's never
7877 called from outside this function, but that appears to be a bug.
7878 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7879 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7880 (adjust_after_replace_noundo): Remove; unused.
7881 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7882 (signal_before_change): Remove decls.
77382fcc 7883
9306c32e
PE
7884 * indent.c (val_compute_motion, val_vmotion): Now static.
7885
cd44d2eb
PE
7886 * image.c: Make symbols static if they're not exported.
7887 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7888 if USE_GTK.
7889 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7890 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7891
ad9a7a06
PE
7892 * fringe.c (standard_bitmaps): Now static.
7893 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7894
81626931
PE
7895 * frame.c: Make symbols static if they're not exported.
7896 (x_report_frame_params, make_terminal_frame): Now static.
7897 (get_frame_param): Now static, unless HAVE_NS.
7898 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7899 (x_get_resource_string): Remove; not used.
7900 * frame.h (make_terminal_frame, x_report_frame_params):
7901 (x_get_resource_string); Remove decls.
7902 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7903 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7904
239f9db9
PE
7905 * font.c, fontset.c: Make symbols static if they're not exported.
7906 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7907 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7908 * font.c (font_close_object): Now static.
7909 * font.h (font_close_object): Remove.
7910 * fontset.c (FONTSET_OBJLIST): Remove.
7911 (free_realized_fontset) #if-0 the body, which does nothing.
7912 (face_suitable_for_char_p): #if-0, as it's never called.
7913 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7914 * xfaces.c (face_at_string_position):
7915 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7916 since 0 is always ASCII.
7917
dfcf3579
PE
7918 * fns.c (weak_hash_tables): Now static.
7919
5045092b
PE
7920 * fileio.c: Make symbols static if they're not exported.
7921 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7922 (Vwrite_region_annotation_buffers): Now static.
7923
57a96f5c
PE
7924 * eval.c: Make symbols static if they're not exported.
7925 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7926 * lisp.h (backtrace_list): Remove decl.
7927
35f08c38
PE
7928 * emacs.c: Make symbols static if they're not exported.
7929 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7930 (fatal_error_code, fatal_error_signal_hook, standard_args):
7931 Now static.
7932 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7933 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7934 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7935 * lisp.h (fatal_error_signal_hook): Remove decl.
7936 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7937
f44bd759
PE
7938 * editfns.c: Move a (normally-unused) function to its only use.
7939 * editfns.c, lisp.h (get_operating_system_release): Remove.
7940 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7941 worth the hassle of breaking this out.
7942
b532497d
PE
7943 * xterm.c: Make symbols static if they're not exported.
7944 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7945 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7946 (x_destroy_window, x_delete_display):
7947 Now static.
7948 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7949 (x_mouse_leave): Remove; unused.
7950 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7951 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7952 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7953 Remove decls.
7954 (x_mouse_leave): Declare only if WINDOWSNT.
7955 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7956 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7957 USE_X_TOOLKIT.
7958
1675728f
PE
7959 * ftxfont.c: Make symbols static if they're not exported.
7960 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7961 HAVE_FREETYPE.
7962 * font.h (ftxfont_driver): Likewise.
7963
e4cebfca
PE
7964 * xfns.c: Make symbols static if they're not exported.
7965 (x_last_font_name, x_display_info_for_name):
7966 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7967 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7968 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7969 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7970 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7971 (last_show_tip_args): Now static.
7972 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7973 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7974 (x_screen_planes): Remove; unused.
7975 * dispextern.h (x_screen_planes): Remove decl.
7976
5bf46f05
PE
7977 * dispnew.c: Make symbols static if they're not exported.
7978 * dispextern.h (redraw_garbaged_frames, scrolling):
7979 (increment_row_positions): Remove.
7980 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7981 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7982 Now static.
7983 (redraw_garbaged_frames): Remove; unused.
7984
435f4c28
PE
7985 * xfaces.c: Make symbols static if they're not exported.
7986 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7987 Remove decls.
7988 * xterm.h (defined_color): Remove decls.
7989 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7990 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7991 (menu_face_changed_default, defined_color, free_realized_face):
7992 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7993 (ascii_face_of_lisp_face): Remove; unused.
7994
8524aef3
PE
7995 * xdisp.c: Make symbols static if they're not exported.
7996 * dispextern.h (scratch_glyph_row, window_box_edges):
7997 (glyph_to_pixel_coords, set_cursor_from_row):
7998 (get_next_display_element, set_iterator_to_next):
7999 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8000 (show_mouse_face): Remove decls
8001 * frame.h (message_buf_print): Likewise.
8002 * lisp.h (pop_message, set_message, check_point_in_composition):
8003 Likewise.
8004 * xterm.h (set_vertical_scroll_bar): Likewise.
8005 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8006 (message_buf_print, scratch_glyph_row, displayed_buffer):
8007 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8008 (get_next_display_element, show_mouse_face, window_box_edges):
8009 (frame_to_window_pixel_xy, check_point_in_composition):
8010 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8011 (glyph_to_pixel_coords): Remove; unused.
8012
16390cd2
PE
8013 * dired.c (file_name_completion): Now static.
8014
8015 * dbusbind.c (xd_in_read_queued_messages): Now static.
8016
a25f4dfa
PE
8017 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8018 * data.c (circular_list_error): Remove.
8019
14a9c8df
PE
8020 * commands.h (last_point_position, last_point_position_buffer):
8021 (last_point_position_window): Remove decls.
8022 * keyboard.c: Make these variables static.
8023
04f2d78b
CB
8024 * coding.h (coding, code_convert_region, encode_coding_gap):
8025 Remove decls.
74ab6df5
PE
8026 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8027 (iso_code_class, detect_coding, code_convert_region): Now static.
8028 (encode_coding_gap): Remove; unused.
8029
38dfbee1
PE
8030 * chartab.c (chartab_chars, chartab_bits): Now static.
8031
a2cb4e63
PE
8032 * charset.h (charset_iso_8859_1): Remove decl.
8033 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8034 Now static.
8035
127198fd
PE
8036 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8037 * ccl.c (Vccl_program_table): Now static.
8038 (check_ccl_update): Remove; unused.
8039
d85b608f
PE
8040 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8041 * category.h: ... from here.
8042 * category.c (check_category_table, set_category_set): Now static.
8043
31cd66f3
PE
8044 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8045 * lisp.h: Remove these decls.
8046
c358e587
PE
8047 * buffer.c (buffer_count): Remove unused var.
8048
e78aecca
PE
8049 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8050 so that it's not optimized away.
8051 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8052 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8053 exported only to the debugger.
8054
e192d7d3 8055 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8056 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8057
92470028
PE
8058 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8059 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8060 was inaccessible from Lisp.
8061 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8062 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8063
244ed907
PE
8064 alloc.c: Import and export fewer symbols, and remove unused items.
8065 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8066 is defined.
8067 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8068 it's not optimized away by whole-program optimization.
8069 (message_enable_multibyte, free_misc): Remove.
8070 (catchlist, handlerlist, mark_backtrace):
8071 Declare only if BYTE_MARK_STACK.
8072 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8073 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8074 (message_enable_multibyte): Remove decl.
8075 (free_misc, interval_free_list, float_block, float_block_index):
8076 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8077 (cons_free_list, last_marked_index):
8078 Now static.
8079 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8080 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8081 (mark_backtrace): Define only if BYTE_MARK_STACK.
8082 * xdisp.c (message_enable_multibyte): Now static.
8083
61c2b50e 8084 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8085 This makes it easier for human readers (and static analyzers)
8086 to see whether these variables are used from other modules.
8087 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8088 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8089 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8090 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8091 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8092 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8093 * xmenu.c, xselect.c:
8094 Declare Q* vars static if they are not used in other modules.
8095 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8096 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8097 Remove decls of unexported vars.
8098 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8099
95c82688
PE
8100 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8101
16a97296
PE
8102 Make Emacs functions such as Fatom 'static' by default.
8103 This makes it easier for human readers (and static analyzers)
8104 to see whether these functions can be called from other modules.
8105 DEFUN now defines a static function. To make the function external
8106 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8107 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8108 (Finit_image_library):
16a97296
PE
8109 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8110 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8111 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8112 Remove decls, since these functions are now static.
8113 (Funintern, Fget_internal_run_time): New decls, since these functions
8114 were already external.
95c82688 8115
16a97296
PE
8116 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8117 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8118 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8119 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8120 * keyboard.c, keymap.c, lread.c:
8121 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8122 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8123 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8124 Mark functions with DEFUE instead of DEFUN,
8125 if they are used in other modules.
8126 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8127 decls for now-static functions.
8128 * buffer.h (Fdelete_overlay): Remove decl.
8129 * callproc.c (Fgetenv_internal): Mark as internal.
8130 * composite.c (Fremove_list_of_text_properties): Remove decl.
8131 (Fcomposition_get_gstring): New forward static decl.
8132 * composite.h (Fcomposite_get_gstring): Remove decl.
8133 * dired.c (Ffile_attributes): New forward static decl.
8134 * doc.c (Fdocumntation_property): New forward static decl.
8135 * eval.c (Ffetch_bytecode): New forward static decl.
8136 (Funintern): Remove extern decl; now in .h file where it belongs.
8137 * fileio.c (Fmake_symbolic_link): New forward static decl.
8138 * image.c (Finit_image_library): New forward static decl.
8139 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8140 * intervals.h (Fprevious_property_change):
8141 (Fremove_list_of_text_properties): Remove decls.
8142 * keyboard.c (Fthis_command_keys): Remove decl.
8143 (Fcommand_execute): New forward static decl.
8144 * keymap.c (Flookup_key): New forward static decl.
8145 (Fcopy_keymap): Now static.
8146 * keymap.h (Flookup_key): Remove decl.
8147 * process.c (Fget_process): New forward static decl.
8148 (Fprocess_datagram_address): Mark as internal.
8149 * syntax.c (Fsyntax_table_p): New forward static decl.
8150 (skip_chars): Remove duplicate decl.
8151 * textprop.c (Fprevious_property_change): New forward static decl.
8152 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8153 Now internal.
8154 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8155 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8156
785bbd42
PE
8157 * editfns.c (Fformat): Remove unreachable code.
8158
8b913b57
AS
81592011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8160
8161 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8162 change. (Bug#8496)
8163
a6744a35
EZ
81642011-04-13 Eli Zaretskii <eliz@gnu.org>
8165
8166 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8167 when at ZV. (Bug#8487)
8168
e7974947
AS
81692011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8170
baad03f0
AS
8171 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8172 (Bug#8437)
8173 * keyboard.c (parse_tool_bar_item): Likewise.
8174 * sound.c (sound_cleanup, alsa_close): Likewise.
8175 * termcap.c (tgetent): Likewise.
8176 * xfns.c (x_default_font_parameter): Likewise.
8177 * xsettings.c (read_and_apply_settings): Likewise.
8178
e7974947
AS
8179 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8180 (overrun_check_free): Protoize.
8181
28272684
PE
81822011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8183
8184 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8185 since callers should never pass a negative size.
8186 Change the signature to match that of plain 'read' and 'write'; see
8187 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8188 * lisp.h: Update prototypes of emacs_write and emacs_read.
8189
11997c76
EZ
81902011-04-11 Eli Zaretskii <eliz@gnu.org>
8191
8192 * xdisp.c (redisplay_window): Don't try to determine the character
8193 position of the scroll margin if the window start point w->startp
e896f03c 8194 is outside the buffer's accessible region. (Bug#8468)
11997c76 8195
8a2cbd72
EZ
81962011-04-10 Eli Zaretskii <eliz@gnu.org>
8197
8198 Fix write-region and its subroutines for buffers > 2GB.
8199 * fileio.c (a_write, e_write): Modify declaration of arguments and
8200 local variables to support buffers larger than 2GB.
8201 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8202
8203 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8204 argument, local variables, and return value.
8205
8206 * lisp.h: Update prototypes of emacs_write and emacs_read.
8207
8208 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8209
4073e537 82102011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8211
1ebfdcb6
PE
8212 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8213
b2ded58d
PE
8214 Fix more problems found by GCC 4.6.0's static checks.
8215
7d66342c
PE
8216 * xdisp.c (vmessage): Use a better test for character truncation.
8217
bbf47d44
PE
8218 * charset.c (load_charset_map): <, not <=, for optimization,
8219 and to avoid potential problems with integer overflow.
9248994d 8220 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8221 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8222 * editfns.c (Fformat): Likewise.
1e69125e 8223 * syntax.c (skip_chars): Likewise.
3befa583 8224
e3019616
PE
8225 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8226 This also lets GCC 4.6.0 generate slightly better loop code.
8227
becfa255
PE
8228 * callint.c (Fcall_interactively): <, not <=, for optimization.
8229 (Fcall_interactively): Count the number of arguments produced,
8230 not the number of arguments given. This is simpler and lets GCC
8231 4.6.0 generate slightly better code.
8232
dae0cd48
PE
8233 * ftfont.c: Distingish more carefully between FcChar8 and char.
8234 The previous code passed unsigned char * to a functions like
8235 strlen and xstrcasecmp that expect char *, which does not
8236 conform to the C standard.
8237 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8238 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8239 char * when the C standard requires it.
8240
76032d70
PE
8241 * keyboard.c (read_char): Remove unused var.
8242
eb3f1cc8
PE
8243 * eval.c: Port to Windows vsnprintf (Bug#8435).
8244 Include <limits.h>.
8245 (SIZE_MAX): Define if the headers do not.
8246 (verror): Do not give up if vsnprintf returns a negative count.
8247 Instead, grow the buffer. This ports to Windows vsnprintf, which
8248 does not conform to C99. Problem reported by Eli Zaretskii.
8249 Also, simplify the allocation scheme, by avoiding the need for
8250 calling realloc, and removing the ALLOCATED variable.
8251
70476b54
PE
8252 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8253
12020a9e
PE
8254 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8255 But keep the doprint source code for now, as we might revamp it
8256 and use it again (Bug#8435).
ea6c7ae6
PE
8257 * lisp.h (doprnt): Remove.
8258 * Makefile.in (base_obj): Remove doprnt.o.
8259 * deps.mk (doprnt.o): Remove.
8260
5fdb398c
PE
8261 error: Print 32- and 64-bit integers portably (Bug#8435).
8262 Without this change, on typical 64-bit hosts error ("...%d...", N)
8263 was used to print both 32- and 64-bit integers N, which relied on
8264 undefined behavior.
61bdb816 8265 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8266 * lisp.h (error, verror): Mark as printf-like functions.
8267 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8268 Report overflow in size calculations when allocating printf buffer.
8269 Do not truncate output string at its first null byte.
8270 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8271 Truncate the output at a character boundary, since vsnprintf does not
8272 do that.
8273 * charset.c (check_iso_charset_parameter): Convert internal
8274 character to string before calling 'error', since %c now has the
8275 printf meaning.
8276 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8277 overflow when computing char to be passed to 'error'. Do not
8278 pass Lisp_Object to 'error'; pass the integer instead.
8279 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8280 formatted with plain %d.
8281
b189fa66
PE
8282 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8283
bff87ef0
PE
8284 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8285
7e2cac20
PE
8286 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8287
ce4d90b5
PE
8288 * xterm.c (x_catch_errors): Remove duplicate declaration.
8289
266c9547
PE
8290 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8291
79c49ad2
PE
8292 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8293
368f4090
JM
82942011-04-10 Jim Meyering <meyering@redhat.com>
8295
8296 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8297 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8298 return ssize_t not "int", and use size_t as the buffer length.
8299 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8300 * gnutls.h: Update declarations.
8301 * process.c (read_process_output): Use ssize_t, to match.
8302 (send_process): Likewise.
8303
a32d4040
CY
83042011-04-09 Chong Yidong <cyd@stupidchicken.com>
8305
8306 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8307
8546720e 83082011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8309
04f2d78b
CB
8310 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8311 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8312
8546720e
GM
8313 * xterm.c (handle_one_xevent):
8314 * xmenu.c (create_and_show_popup_menu):
8315 * xselect.c (x_decline_selection_request)
8316 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8317
0a2f5c1a 83182011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8319
8320 Fix some uses of `int' instead of EMACS_INT.
8321 * search.c (string_match_1, fast_string_match)
8322 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8323 (scan_buffer, find_next_newline_no_quit)
8324 (find_before_next_newline, search_command, Freplace_match)
8325 (Fmatch_data): Make some `int' variables be EMACS_INT.
8326
8327 * xdisp.c (display_count_lines): 3rd argument and return value now
8328 EMACS_INT. All callers changed.
8329 (pint2hrstr): Last argument is now EMACS_INT.
8330
8331 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8332 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8333 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8334 (decode_coding_utf_16, decode_coding_emacs_mule)
8335 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8336 (decode_coding_ccl, decode_coding_charset)
8337 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8338 (decode_coding_iso_2022, decode_coding_emacs_mule)
8339 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8340 <char_offset, last_offset>: Declare EMACS_INT.
8341 (encode_coding_utf_8, encode_coding_utf_16)
8342 (encode_coding_emacs_mule, encode_invocation_designation)
8343 (encode_designation_at_bol, encode_coding_iso_2022)
8344 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8345 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8346 Declare EMACS_INT.
8347 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8348 (encode_invocation_designation): Last argument P_NCHARS is now
8349 EMACS_INT.
8350 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8351 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8352
8353 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8354 All users changed.
8355
8356 * ccl.c (Fccl_execute_on_string): Declare some variables
8357 EMACS_INT.
8358
8546720e 83592011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8360
8361 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8362
4e19a977
CS
83632011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8364
8365 * process.c (Fformat_network_address): Doc fix.
8366
87302331
R
83672011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8368
ee7683eb 8369 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8370
cbb59342
CY
83712011-04-08 Chong Yidong <cyd@stupidchicken.com>
8372
8373 * keyboard.c (read_char): Call Lisp function help-form-show,
8374 instead of using internal_with_output_to_temp_buffer.
8375 (Qhelp_form_show): New var.
e0d38eeb 8376 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8377
8378 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8379
8380 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8381
e67a13ab
CY
83822011-04-06 Chong Yidong <cyd@stupidchicken.com>
8383
04f2d78b
CB
8384 * process.c (Flist_processes): Remove to Lisp.
8385 (list_processes_1): Delete.
e67a13ab 8386
973f782d
EZ
83872011-04-06 Eli Zaretskii <eliz@gnu.org>
8388
7c106b1e
EZ
8389 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8390
973f782d
EZ
8391 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8392
41cf7d1a 83932011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8394
ca23cc88
PE
8395 Fix more problems found by GCC 4.6.0's static checks.
8396
f390e2d5
PE
8397 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8398
42eea0d0
PE
8399 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8400
b69769da 8401 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8402
f9541e84
PE
8403 * xdisp.c (vmessage): Mark as a printf-like function.
8404
13841b55
PE
8405 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8406
c136c10f
PE
8407 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8408
5e2d4a30
PE
8409 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8410 printf-like functions.
8411 (tiff_load): Add casts to remove these marks before passing them
8412 to system-supplied API.
8413
583f48b9
PE
8414 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8415
b25d760e
PE
8416 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8417 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8418 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8419 directly, rather than having caller test rule sign. This avoids
8420 some unnecessary tests.
8421 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8422 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8423 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8424
bc7b6697 8425 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8426 (xfont_open): Avoid unnecessary tests.
bc7b6697 8427
27ccc379
PE
8428 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8429
dcd5c89a
PE
8430 * composite.h, composite.c (composition_gstring_put_cache):
8431 Use EMACS_INT, not int, for length.
8432
b13a45c6
PE
8433 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8434 breaking out part of COMPOSITION_DECODE_RULE.
8435 (COMPOSITION_DECODE_RULE): Use it.
8436 * composite.c (get_composition_id): Remove unused local vars,
8437 by using the new macro.
8438
1e792e4d
PE
8439 * textprop.c (set_text_properties_1): Change while to do-while,
8440 since the condition is always true at first.
8441
dc6c6455 8442 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8443 (interval_deletion_adjustment): Return unsigned value.
8444 All uses changed.
dc6c6455 8445
aba7731a
PE
8446 * process.c (list_processes_1, create_pty, read_process_output):
8447 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8448 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8449 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8450 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8451 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8452
fdfc4bf3
PE
8453 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8454
fca8fe46 8455 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8456 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8457
06a0259a 8458 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8459 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8460 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8461
e7b9e80f
PE
8462 * print.c (print_error_message): Avoid int overflow.
8463
56201685
PE
8464 * font.c (font_list_entities): Redo for clarity,
8465 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8466
78834453 8467 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8468 (font_score): Avoid potential overflow in diff calculation.
78834453 8469
0bc0b309 8470 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8471 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8472
e610eaca
PE
8473 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8474
b895abce
PE
8475 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8476 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8477 can always succeed if overflow has undefined behavior.
8478
1f1d9321 8479 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8480 (wordify): Omit three unnecessary tests.
1f1d9321 8481
c59478bc
PE
8482 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8483 All callers changed. This avoids the need for an unused var.
8484
79b73827
PE
8485 * casefiddle.c (casify_region): Remove var that is set but not used.
8486
a4db5dfe
PE
8487 * dired.c (file_name_completion): Remove var that is set but not used.
8488
43aae36e
PE
8489 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8490
2a47c44d 8491 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8492 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8493
a37c69bf
PE
8494 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8495 Check for integer overflow on size calculations.
8496
328ab8e7
PE
8497 * buffer.c (Fprevious_overlay_change): Remove var that is set
8498 but not used.
8499
e5a2a5cb
PE
8500 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8501 Remove vars that are set but not used.
8d84a6eb 8502 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8503 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8504
a60e5f68
PE
8505 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8506
f661cb61 8507 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8508 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8509
f0397f5a
PE
8510 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8511 that are set but not used.
8512
8664db06 8513 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8514 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8515
6abdaa4a
PE
8516 * xselect.c (x_get_local_selection, x_handle_property_notify):
8517 Remove vars that are set but not used.
8518
0ce7538d 8519 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8520 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8521
9ae848fc
PE
8522 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8523 Remove var that is set but not used.
0b918413
PE
8524 (scroll_bar_windows_size): Now size_t, not int.
8525 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8526 Check for overflow.
9ae848fc 8527
a5a62657
PE
8528 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8529 (map_tty_color) [!defined MSDOS]: Likewise.
8530
5c5cdd39
PE
8531 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8532
66ebf983
PE
8533 * coding.c: Remove vars that are set but not used.
8534 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8535 All callers changed.
8536 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8537 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8538 (decode_coding_charset): Remove vars that are set but not used.
8539
1be4d761
PE
8540 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8541 that is set but not used.
8542
47553fa8
PE
8543 * print.c (print_object): Remove var that is set but not used.
8544
1f7196bf 8545 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8546 The gnulib version avoids calling malloc in the usual case,
8547 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8548 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8549 * filelock.c (current_lock_owner): Likewise.
8550 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8551 * sysdep.c: Include allocator.h, careadlinkat.h.
8552 (emacs_no_realloc_allocator): New static constant.
8553 (emacs_readlink): New function.
fdb61804
PE
8554 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8555 ../lib/careadlinkat.h.
d1fdcab7 8556
f84c17c7
SM
85572011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8558
8559 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8560 first non-nil return value).
8561
ef3862ad
JD
85622011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8563
8564 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8565 if not defined (Bug#8403).
8566
376a7006
JB
85672011-04-02 Juanma Barranquero <lekktu@gmail.com>
8568
8569 * xdisp.c (display_count_lines): Remove parameter `start',
8570 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8571 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8572 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8573 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8574 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8575 and thereabouts. All callers changed.
8576 (get_per_char_metric): Remove parameter `f', unused since
8577 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8578
6ca3801d
JM
85792011-04-02 Jim Meyering <meyering@redhat.com>
8580
8581 do not dereference NULL upon failed strdup
8582 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8583 (ns_get_family): Likewise.
8584
d8e2b5ba
JB
85852011-04-02 Juanma Barranquero <lekktu@gmail.com>
8586
8587 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8588
8c74fcbd
JD
85892011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8590
8591 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8592 later (Bug#8403).
8593
7200d79c
SM
85942011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8595
03408648 8596 Add lexical binding.
7200d79c 8597
03408648
SM
8598 * window.c (Ftemp_output_buffer_show): New fun.
8599 (Fsave_window_excursion):
8600 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8601
8602 * lread.c (lisp_file_lexically_bound_p): New function.
8603 (Fload): Bind Qlexical_binding.
8604 (readevalloop): Remove `evalfun' arg.
8605 Bind Qinternal_interpreter_environment.
8606 (Feval_buffer): Bind Qlexical_binding.
8607 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8608 Mark as dynamic.
8609 (syms_of_lread): Declare `lexical-binding'.
8610
8611 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8612
8613 * keyboard.c (eval_dyn): New fun.
8614 (menu_item_eval_property): Use it.
ca105506
SM
8615
8616 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8617
03408648
SM
8618 * fns.c (concat, mapcar1): Accept byte-code-functions.
8619
8620 * eval.c (Fsetq): Handle lexical vars.
8621 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8622 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8623 (FletX, Flet): Obey lexical binding.
8624 (Fcommandp): Handle closures.
8625 (Feval): New `lexical' arg.
8626 (eval_sub): New function extracted from Feval. Use it almost
8627 everywhere where Feval was used. Look up vars in lexical env.
8628 Handle closures.
8629 (Ffunctionp): Move from subr.el.
8630 (Ffuncall): Handle closures.
8631 (apply_lambda): Remove `eval_flags'.
8632 (funcall_lambda): Handle closures and new byte-code-functions.
8633 (Fspecial_variable_p): New function.
8634 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8635 but without exporting it to Lisp.
23aba0ea 8636
23aba0ea 8637 * doc.c (Fdocumentation, store_function_docstring):
03408648 8638 * data.c (Finteractive_form): Handle closures.
23aba0ea 8639
03408648
SM
8640 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8641 interactive spec.
ba83908c 8642
04f2d78b
CB
8643 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8644 New byte-codes.
03408648
SM
8645 (exec_byte_code): New function extracted from Fbyte_code to handle new
8646 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8647
03408648 8648 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8649
03408648 8650 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8651
e2abce01
JB
86522011-03-31 Juanma Barranquero <lekktu@gmail.com>
8653
8654 * xdisp.c (redisplay_internal): Fix prototype.
8655
63696a73 86562011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8657
63696a73 8658 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8659 (try_scrolling): Use it when setting scroll_limit.
8660 Limit scrolling to 100 screen lines.
63696a73
EZ
8661 (redisplay_window): Even when falling back on "recentering",
8662 position point in the window according to scroll-conservatively,
8663 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8664
8665 (try_scrolling): When point is above the window, allow searching
8666 as far as scroll_max, or one screenful, to compute vertical
8667 distance from PT to the scroll margin position. This prevents
8668 try_scrolling from unnecessarily failing when
8669 scroll-conservatively is set to a value slightly larger than the
8670 window height. Clean up the case of PT below the margin at bottom
8671 of window: scroll_max can no longer be INT_MAX. When aggressive
8672 scrolling is in use, don't let point enter the opposite scroll
8673 margin as result of the scroll.
8674 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8675 threshold of 100 lines for never-recentering scrolling.
8676
e4cc2dfc
JB
86772011-03-31 Juanma Barranquero <lekktu@gmail.com>
8678
8679 * dispextern.h (move_it_by_lines):
8680 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8681 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8682 (message_log_check_duplicate): Remove parameters `prev_bol' and
8683 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8684 (redisplay_internal): Remove parameter `preserve_echo_area',
8685 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8686
8687 * indent.c (Fvertical_motion):
8688 * window.c (window_scroll_pixel_based, Frecenter):
8689 Don't pass `need_y_p' to `move_it_by_lines'.
8690
1c470562
SM
86912011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8692
44f230aa
SM
8693 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8694 steal a few bits to be more compact.
8695 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8696 Remove unneeded casts.
8697
1c470562
SM
8698 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8699
888adce9
ZK
87002011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8701
8702 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8703 binding" message (bug#7967).
8704
f838ed7b
PE
87052011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8706
77861b95
PE
8707 Fix more problems found by GCC 4.6.0's static checks.
8708
de6dbc14
PE
8709 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8710 Remove unused local var.
8711
f838ed7b
PE
8712 * editfns.c (Fmessage_box): Remove unused local var.
8713
792c7b2b
PE
8714 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8715 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8716 Omit unused local vars.
c499e557 8717 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8718 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8719 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8720 Omit unused local var.
8721
ba0165e1
PE
8722 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8723 Don't assume string length fits in int.
32ad8845 8724 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8725 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8726
3c59b4c9
PE
8727 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8728 instead of alloca (Bug#8344).
8729
a3eed478 8730 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8731 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8732
eb4d412d
PE
8733 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8734
1658b401
PE
8735 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8736 concerns.
8737
8738 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8739
8740 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8741
9a2c6e05
PE
8742 * keyboard.c (syms_of_keyboard): Use the same style as later
8743 in this function when indexing through an array. This also
8744 works around GCC bug 48267.
8745
03d0a109
PE
8746 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8747
44f730c8
PE
8748 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8749
fe75f926
PE
8750 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8751 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8752
ffa8c828
PE
8753 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8754 This avoids undefined behavior on integer overflow, and is a bit
8755 more convenient anyway since it is compared to a size_t variable.
8756
c5101a77
PE
8757 Variadic C functions now count arguments with size_t, not int.
8758 This avoids an unnecessary limitation on 64-bit machines, which
8759 caused (substring ...) to crash on large vectors (Bug#8344).
8760 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8761 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8762 All variadic functions and their callers changed accordingly.
c5101a77
PE
8763 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8764 * data.c (arith_driver, float_arith_driver): Likewise.
8765 * editfns.c (general_insert_function): Likewise.
8766 * eval.c (struct backtrace.nargs, interactive_p)
8767 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8768 (funcall_lambda, mark_backtrace): Likewise.
8769 * fns.c (concat): Likewise.
8770 * frame.c (x_set_frame_parameters): Likewise.
8771 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8772 0 if not found, not -1. All callers changed.
8773
dd3f25f7
PE
8774 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8775 (stack_copy_size): Now size_t, not int.
8776 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8777
461c2ab9
JB
87782011-03-28 Juanma Barranquero <lekktu@gmail.com>
8779
8780 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8781 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8782 All callers changed.
8783
8784 * lisp.h (multibyte_char_to_unibyte):
8785 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8786 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8787 * character.h (CHAR_TO_BYTE8):
8788 * cmds.c (internal_self_insert):
8789 * editfns.c (general_insert_function):
8790 * keymap.c (push_key_description):
8791 * search.c (Freplace_match):
8792 * xdisp.c (message_dolog, set_message_1): All callers changed.
8793
f6d62986
SM
87942011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8795
8796 * keyboard.c (safe_run_hook_funcall): New function.
8797 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8798 don't set the hook to nil, but remove the offending function instead.
8799 (Qcommand_hook_internal): Remove, unused.
8800 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8801 Vcommand_hook_internal.
8802
8803 * eval.c (enum run_hooks_condition): Remove.
8804 (funcall_nil, funcall_not): New functions.
8805 (run_hook_with_args): Call each function through a `funcall' argument.
8806 Remove `cond' argument, now redundant.
8807 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8808 (Frun_hook_with_args_until_failure): Adjust accordingly.
8809 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8810
1db5b1ad
JB
88112011-03-28 Juanma Barranquero <lekktu@gmail.com>
8812
8813 * dispextern.h (string_buffer_position): Remove declaration.
8814
8815 * print.c (strout): Remove parameter `multibyte', unused since
8816 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8817
8818 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8819 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8820 All callers changed.
8821
8822 * w32.c (_wsa_errlist): Use braces for struct initializers.
8823
8824 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8825 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8826 All callers changed.
8827 (string_buffer_position): Likewise. Also, make static (it's never
8828 used outside xdisp.c).
8829 (cursor_row_p): Remove parameter `w', unused since
8830 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8831 (decode_mode_spec): Remove parameter `precision', introduced during
8832 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8833 All callers changed.
8834
5ffb62aa
JD
88352011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8836
8837 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8838
461c2ab9 88392011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8840
8841 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8842 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8843 (ns_update_auto_hide_menu_bar): New functions.
8844 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8845 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8846 ns_constrain_all_frames.
8847 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8848 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8849
5c380ffb
JD
88502011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8851
8852 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8853
9af30bdf
GM
88542011-03-27 Glenn Morris <rgm@gnu.org>
8855
8856 * syssignal.h: Replace RETSIGTYPE with void.
8857 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8858 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8859 Replace SIGTYPE with void everywhere.
8860 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8861 * s/template.h (SIGTYPE): Remove commented out definition.
8862
e2abce01
JB
88632011-03-26 Eli Zaretskii <eliz@gnu.org>
8864
8865 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8866 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8867
f868cd8a
JB
88682011-03-26 Juanma Barranquero <lekktu@gmail.com>
8869
59eb0929
JB
8870 * w32.c (read_unc_volume): Use parameter `henum', instead of
8871 global variable `wget_enum_handle'.
8872
8873 * keymap.c (describe_vector): Remove parameters `indices' and
8874 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8875 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8876
f868cd8a
JB
8877 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8878
8879 * keyboard.c (timer_check): Remove parameter `do_it_now',
8880 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8881 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8882 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8883
8884 * keyboard.c (read_char):
8885 * w32menu.c (w32_menu_display_help):
8886 * xmenu.c (show_help_event, menu_help_callback):
8887 Adjust calls to `show_help_echo'.
8888
8889 * gtkutil.c (xg_maybe_add_timer):
8890 * keyboard.c (readable_events):
8891 * process.c (wait_reading_process_output):
8892 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8893
8894 * insdel.c (adjust_markers_gap_motion):
8895 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8896 (gap_left, gap_right): Don't call it.
8897
2ecf6fdb
CY
88982011-03-25 Chong Yidong <cyd@stupidchicken.com>
8899
8900 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8901 incurred during fontification.
8902
6b1f9ba4
JB
89032011-03-25 Juanma Barranquero <lekktu@gmail.com>
8904
8905 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8906 (DEFVAR_PER_BUFFER): Don't pass it.
8907
8908 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8909 (scrolling_window): Don't pass it.
8910
0f4a96b5
JB
89112011-03-25 Juanma Barranquero <lekktu@gmail.com>
8912
8913 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8914
8915 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8916 and `suffix'.
8917 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8918 of variables specific to SELinux and computation of `encoded_absname'.
8919
8920 * image.c (XPutPixel): Remove unused variable `height'.
8921
8922 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8923
8924 * unexw32.c (get_section_info): Remove unused variable `section'.
8925
8926 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8927 (system_process_attributes): Remove unused variable `sess'.
8928 (sys_read): Remove unused variable `err'.
8929
8930 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8931 (w32_wnd_proc): Remove unused variable `isdead'.
8932 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8933 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8934 (x_create_tip_frame): Remove unused variable `tem'.
8935
8936 * w32inevt.c (w32_console_read_socket):
8937 Remove unused variable `no_events'.
8938
8939 * w32term.c (x_draw_composite_glyph_string_foreground):
8940 Remove unused variable `width'.
8941
1149507c
JB
89422011-03-24 Juanma Barranquero <lekktu@gmail.com>
8943
8944 * w32term.c (x_set_glyph_string_clipping):
8945 Don't pass uninitialized region to CombineRgn.
8946
9c88f339
JB
89472011-03-23 Juanma Barranquero <lekktu@gmail.com>
8948
8949 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8950 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8951 (Fx_close_connection): Remove unused variable `i'.
8952
8953 * w32font.c (w32font_draw): Return number of glyphs.
8954 (w32font_open_internal): Remove unused variable `i'.
8955 (w32font_driver): Add missing initializer.
8956
8957 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8958 (fill_in_menu): Remove unused variable `items_added'.
8959
8960 * w32term.c (last_mouse_press_frame): Remove static global variable.
8961 (w32_clip_to_row): Remove unused variable `f'.
8962 (x_delete_terminal): Remove unused variable `i'.
8963
8964 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8965 (NOTHING): Remove unused static global variable.
8966 (uniscribe_check_otf): Remove unused variable `table'.
8967 (uniscribe_font_driver): Add missing initializers.
8968
dee091a3
JD
89692011-03-23 Julien Danjou <julien@danjou.info>
8970
8971 * term.c (Fsuspend_tty, Fresume_tty):
8972 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8973 * window.c (temp_output_buffer_show):
8974 * insdel.c (signal_before_change):
8975 * frame.c (Fhandle_switch_frame):
8976 * fileio.c (Fdo_auto_save):
8977 * emacs.c (Fkill_emacs):
8978 * editfns.c (save_excursion_restore):
8979 * cmds.c (internal_self_insert):
8980 * callint.c (Fcall_interactively):
8981 * buffer.c (Fkill_all_local_variables):
8982 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8983 Use Frun_hooks.
0f4a96b5 8984 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8985 unconditionally since it does the check itself.
dee091a3 8986
2c520ab5 89872011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8988
c9c49752
PE
8989 Fix more problems found by GCC 4.5.2's static checks.
8990
8abc3f12
PE
8991 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8992 the first time through the loop, since we know p0 < p1 then.
8993 This also avoids a gcc -Wstrict-overflow warning.
8994
a2d26660
PE
8995 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8996 leading to a memory leak, possible in functions like
8997 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8998 of objects (Bug#8318).
a2d26660 8999
916c72e9
PE
9000 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9001 that could (at least in theory) be that large.
9002
19ab8a18
PE
9003 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9004 This is less likely to overflow, and avoids undefined behavior if
9005 overflow does occur. All callers changed. Use strtoul to scan
9006 for the unsigned long integer.
b7cbbd6f
PE
9007 (pint2hrstr): Simplify and tune code slightly.
9008 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9009
f0641eff
PE
9010 * scroll.c (do_scrolling): Work around GCC bug 48228.
9011 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9012
7f650bb9
PE
9013 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9014 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9015 (validate_x_resource_name): Simplify count usage.
9016 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9017
37dd57d1
PE
9018 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9019 fail (Bug#8306).
81e56e61 9020
699979fc 9021 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9022
401bf9b4
PE
9023 * process.c (Fmake_network_process): Use socklen_t, not int,
9024 where POSIX says socklen_t is required in portable programs.
9025 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9026 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9027 (Fmake_network_process, server_accept_connection):
9028 (wait_reading_process_output, read_process_output):
9029 Likewise.
9030
b93aacde
PE
9031 * process.c: Rename or move locals to avoid shadowing.
9032 (list_processes_1, Fmake_network_process):
9033 (read_process_output_error_handler, exec_sentinel_error_handler):
9034 Rename or move locals.
4dc343ee 9035 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9036 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9037 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9038 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9039 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9040
af8a867c 9041 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9042 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9043 Include tparam.h instead, since it declares them.
af8a867c
PE
9044 * cm.h (PC): Remove extern decl; tparam.h now does this.
9045 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9046 * terminfo.c: Include tparam.h, to check interfaces.
9047 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9048 (tparam): Adjust signature to match interface in tparam.h;
9049 this removes some undefined behavior. Check that outstring and len
9050 are zero, which they always are with Emacs.
9051 * tparam.h (PC, BC, UP): New extern decls.
9052
0248044d 9053 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9054 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9055
8ff096c1 9056 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9057 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9058 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9059 (ftfont_list): Remove unused local.
49eaafba
PE
9060 (get_adstyle_property, ftfont_pattern_entity):
9061 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9062 Rename locals to avoid shadowing.
8ff096c1 9063
e2be39f6
PE
9064 * xfont.c (xfont_list_family): Mark var as initialized.
9065
c9735e30
PE
9066 * xml.c (make_dom): Now static.
9067
8f5201ae
PE
9068 * composite.c (composition_compute_stop_pos): Rename local to
9069 avoid shadowing.
b246f932
PE
9070 (composition_reseat_it): Remove unused locals.
9071 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9072 (composition_update_it): Mark var as initialized.
11b61122
PE
9073 (find_automatic_composition): Mark vars as initialized,
9074 with a FIXME (Bug#8290).
8f5201ae 9075
760fbc2c
PE
9076 character.h: Rename locals to avoid shadowing.
9077 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9078 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9079 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9080 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9081 to avoid shadowing.
9082
ff08eb85
PE
9083 * textprop.c (property_change_between_p): Remove; unused.
9084
fc7bf025
PE
9085 * intervals.c (interval_start_pos): Now static.
9086
235d7abc
PE
9087 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9088
44f230aa
SM
9089 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9090 Rename locals to avoid shadowing.
3e7d6594 9091
50060332
PE
9092 * sound.c (wav_play, au_play, Fplay_sound_internal):
9093 Fix pointer signedness.
d01f234b 9094 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9095 (wav_play): Initialize a variable to 0, to prevent undefined
9096 behavior (Bug#8278).
50060332 9097
c4fc4e30
PE
9098 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9099
918436ed
PE
9100 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9101
c939f91b
PE
9102 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9103 clobbering (Bug#8298).
b9c7f648
PE
9104 * sysdep.c (sys_subshell): Likewise.
9105 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9106
6bd8c144
PE
9107 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9108 This should get cleaned up, so that child_setup has the
9109 same signature on all platforms.
9110
7710357c 9111 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9112 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9113
c59da222
CY
91142011-03-22 Chong Yidong <cyd@stupidchicken.com>
9115
9116 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9117 not to be necessary, and produces flickering.
9118
66b87493
GM
91192011-03-20 Glenn Morris <rgm@gnu.org>
9120
9121 * config.in: Remove file.
9122
45b6f6d5
JB
91232011-03-20 Juanma Barranquero <lekktu@gmail.com>
9124
9125 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9126 are now in src/globals.h.
9127 (syms_of_minibuf): Remove spurious & from previous change.
9128
cd394be1 91292011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9130
9131 * minibuf.c (completing-read-function): New variable.
9132 (completing-read-default): Rename from completing-read.
9133 (completing-read): Call completing-read-function.
9134
b14e3e21
CY
91352011-03-19 Juanma Barranquero <lekktu@gmail.com>
9136
9137 * xfaces.c (Fx_load_color_file):
9138 Read color file from absolute filename (bug#8250).
9139
f2b726e6
JB
91402011-03-19 Juanma Barranquero <lekktu@gmail.com>
9141
9142 * makefile.w32-in: Update dependencies.
9143
09f6ff02
EZ
91442011-03-17 Eli Zaretskii <eliz@gnu.org>
9145
9146 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9147
29a6015a
PE
91482011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9149
a3a6c54e
PE
9150 Fix more problems found by GCC 4.5.2's static checks.
9151
b766f867
PE
9152 * process.c (make_serial_process_unwind, send_process_trap):
9153 (sigchld_handler): Now static.
9154
be02381c
PE
9155 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9156 That way, the code declares only the vars that it needs.
9157 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9158 * s/cygwin.h (PTY_ITERATION): Likewise.
9159 * s/darwin.h (PTY_ITERATION): Likewise.
9160 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9161
57048744
PE
9162 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9163 * process.c (allocate_pty): Don't declare stb unless it's needed.
9164
7914961c 9165 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9166 (CONSTANTLIM): Remove; unused.
9167 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9168 Define only if needed.
7914961c 9169
b3967b18
PE
9170 * unexelf.c (unexec): Name an expression,
9171 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9172 Use a different way to cause a compilation error if anyone uses
9173 n rather than nn, a way that does not involve shadowing.
73366a00 9174 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9175
29a6015a
PE
9176 * deps.mk (unexalpha.o): Remove; unused.
9177
43cfc33e 9178 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9179 * unexec.h: New file.
ce701a33
PE
9180 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9181 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9182 Depend on unexec.h.
9183 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9184 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9185 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9186 Change as necessary to match prototype in unexec.h.
ce701a33 9187
01f44d5a
PE
9188 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9189 shadowing.
4f63c6bb 9190 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9191
a6670b0b
PE
9192 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9193 Rename locals to avoid shadowing.
9194
cef2010d 9195 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9196 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9197
d4d7173a
PE
9198 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9199
f08b802a
PE
9200 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9201 warning when compiling print.c.
9202
3ddb0639
PE
9203 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9204 instead of using an uninitialized var.
5ad03b97 9205 (font_sort_entities): Mark var as initialized.
3ddb0639 9206
170a2692
PE
9207 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9208
e663c700
PE
9209 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9210 pointers to constants.
89bc529a 9211 (font_parse_fcname): Remove unused vars.
7b81e2d0 9212 (font_delete_unmatched): Now static.
ea838e10 9213 (font_get_spec): Remove; unused.
13a547c6
PE
9214 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9215 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9216 Rename or move locals to avoid shadowing.
e663c700 9217
2a80c887 9218 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9219 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9220
1384fa33 9221 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9222 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9223
8b2c52e9
PE
9224 * alloc.c (mark_backtrace): Move decl from here ...
9225 * lisp.h: ... to here, so that it can be checked.
9226
475545b5 9227 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9228 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9229 (lisp_indirect_variable): Name an expression,
9230 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9231 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9232
b1349114 9233 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9234 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9235 Use const pointer when appropriate.
b1349114 9236
a2928364
PE
9237 * lisp.h (get_system_name, get_operating_system_release):
9238 Move decls here, to check interfaces.
9239 * process.c (get_operating_system_release): Move decl to lisp.h.
9240 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9241 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9242 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9243 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9244 (Fformat_time_string, Fencode_time, Finsert_char):
9245 (Ftranslate_region_internal, Fformat):
9246 Rename or remove local vars to avoid shadowing.
9710023e 9247 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9248
a415e694
PE
9249 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9250 avoid shadowing.
9251
8ef4622d
PE
9252 * lisp.h (eassert): Check that the argument compiles, even if
9253 ENABLE_CHECKING is not defined.
9254
946f9a5b
PE
9255 * data.c (Findirect_variable): Name an expression, to avoid
9256 gcc -Wbad-function-cast warning.
112396d6 9257 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9258 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9259 (Fmake_variable_buffer_local, Fmake_local_variable):
9260 Mark variables as initialized.
52746918 9261 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9262
e5aab7e7 9263 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9264 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9265 Rename locals to avoid shadowing.
dff45157
PE
9266 (mark_stack): Move local variables into the #ifdef region where
9267 they're used.
7bc26fdb
PE
9268 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9269 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9270 needed otherwise.
9271 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9272 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9273 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9274
e5aab7e7
PE
9275 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9276 avoids undefined behavior in theory.
9277
4da60324
PE
9278 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9279
88043301
PE
9280 Use functions, not macros, for up- and down-casing (Bug#8254).
9281 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9282 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9283 to use the following functions instead of these macros.
9284 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9285 EMACS_INT, since callers assume the returned value fits in int.
9286 (upcase1): Likewise, for UPCASE_TABLE.
9287 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9288 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9289 the race-condition problem in the old DOWNCASE.
88043301 9290
19ed5445
PE
9291 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9292 Rename locals to avoid shadowing.
9293 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9294 (regex_compile, re_search_2, re_match_2_internal):
9295 Remove unused local vars.
952db0d7
PE
9296 (FREE_VAR): Rewrite so as not to use empty "else",
9297 which gcc can warn about.
da053e48 9298 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9299 (RETALLOC_IF): Define only if needed.
9300 (WORDCHAR_P): Likewise. This one is never needed, but is used
9301 only in a comment talking about a compiler bug, so put inside
9302 the #if 0 of that comment.
9303 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9304 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9305 Remove; unused.
19ed5445 9306
1f3561e4 9307 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9308 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9309 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9310
ded6f8f7
PE
9311 * search.c (simple_search): Remove unused var.
9312
dbd37a95
PE
9313 * dired.c (compile_pattern): Move decl from here ...
9314 * lisp.h: ... to here, so that it can be checked.
9315 (struct re_registers): New forward decl.
9316
7e47afad
PE
9317 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9318
85f24f61
PE
9319 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9320 All uses changed.
9321 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9322 Rename locals to avoid shadowing.
5671df8f 9323 (Fvertical_motion): Mark locals as initialized.
85f24f61 9324
181aa2be 9325 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9326 (casify_region): Mark local as initialized.
181aa2be 9327
930d429c
PE
9328 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9329
7082eac6
PE
9330 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9331 New macros, so that the caller can use some names other than
9332 gcpro1, gcpro2, etc.
9333 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9334 of the new macros.
9335 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9336 argument, for consistency with GCPRO2_VAR, etc: it is now the
9337 prefix of the variable, not the variable itself. All uses
9338 changed.
38b2c076
PE
9339 * dired.c (directory_files_internal, file_name_completion):
9340 Rename locals to avoid shadowing.
9341
15206ed9
PE
9342 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9343 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9344 dired.c's scmp function, had undefined behavior.
9345 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9346 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9347 * buffer.h: ... to here, because these macros use current_buffer,
9348 and the new implementation with inline functions needs to have
9349 current_buffer in scope now, rather than later when the macros
9350 are used.
9351 (downcase, upcase1): New static inline functions.
9352 (DOWNCASE, UPCASE1): Reimplement using these functions.
9353 This avoids undefined behavior in expressions like
9354 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9355 from race conditions in accessing the global variables
9356 case_temp1 and case_temp2.
9357 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9358 * lisp.h (case_temp1, case_temp2): Remove their decls.
9359 * character.h (ASCII_CHAR_P): Move from here ...
9360 * lisp.h: ... to here, so that the inline functions mentioned
9361 above can use them.
9362
4a6bea26
PE
9363 * dired.c (directory_files_internal_unwind): Now static.
9364
f14b7e14
PE
9365 * fileio.c (file_name_as_directory, directory_file_name):
9366 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9367 Now static.
2893f146
PE
9368 (file_name_as_directory): Use const pointers when appropriate.
9369 (Fexpand_file_name): Likewise. In particular, newdir might
9370 point at constant storage, so make it a const pointer.
fd4ead52 9371 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9372 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9373 signedness issues.
f839df0c
PE
9374 (Fset_file_times, Finsert_file_contents, auto_save_error):
9375 Rename locals to avoid shadowing.
f14b7e14 9376
5716756e 9377 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9378 (Ftry_completion, Fall_completions): Rename or remove locals
9379 to avoid shadowing.
5716756e 9380
b4c3046a
PE
9381 * marker.c (bytepos_to_charpos): Remove; unused.
9382
b45db522
PE
9383 * lisp.h (verify_bytepos, count_markers): New decls,
9384 so that gcc does not warn that these functions aren't declared.
9385
85876d07
PE
9386 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9387 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9388 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9389 (copy_text): Remove unused local var.
85876d07 9390
03d78a21 9391 * filelock.c (within_one_second): Now static.
b3dd38ab 9392 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9393
5df8f01b
PE
9394 * buffer.c (fix_overlays_before): Mark locals as initialized.
9395 (fix_start_end_in_overlays): Likewise. This function should be
9396 simplified by using pointers-to-pointers, but that's a different
9397 matter.
b1d876f1 9398 (switch_to_buffer_1): Now static.
8f54f30a
PE
9399 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9400 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9401
a70072c9 9402 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9403 Fix pointer signedness issue.
edced198
PE
9404 (sys_subshell): Mark local as volatile if checking for lint,
9405 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9406 (MAXPATHLEN): Define only if needed.
a70072c9 9407
a0977c44
PE
9408 * process.c (serial_open, serial_configure): Move decls from here ...
9409 * systty.h: ... to here, so that they can be checked.
9410
a884fdcc
PE
9411 * fns.c (get_random, seed_random): Move extern decls from here ...
9412 * lisp.h: ... to here, so that they can be checked.
9413
604efe86 9414 * sysdep.c (reset_io): Now static.
b8950c94 9415 (wait_for_termination_signal): Remove; unused.
604efe86 9416
38fc62d9
PE
9417 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9418 (copy_keymap_item, append_key, push_text_char_description):
9419 Now static.
1004a21a 9420 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9421 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9422 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9423 (describe_map_tree):
9424 Rename locals to avoid shadowing.
38fc62d9 9425
2f2650da
PE
9426 * keyboard.c: Declare functions static if they are not used elsewhere.
9427 (echo_char, echo_dash, cmd_error, top_level_2):
9428 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9429 (read_char, kbd_buffer_get_event, make_lispy_position):
9430 (make_lispy_event, make_lispy_movement, apply_modifiers):
9431 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9432 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9433 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9434 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9435 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9436
a053e86c 9437 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9438 (mark_kboards): Move decl here ...
9439 * alloc.c (mark_kboards): ... from here.
a053e86c 9440
4752793e
PE
9441 * lisp.h (force_auto_save_soon): New decl.
9442
74f10ca7 9443 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9444 (DEFINE_DUMMY_FUNCTION): New macro.
9445 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9446 Use it.
c03cd23f
PE
9447 (main): Add casts to avoid warnings
9448 if GCC considers string literals to be constants.
74f10ca7 9449
022e70d4
PE
9450 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9451
59d6fe83
PE
9452 * dbusbind.c: Pointer signedness fixes.
9453 (xd_signature, xd_append_arg, xd_initialize):
9454 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9455 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9456 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9457 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9458
78320123
PE
9459 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9460 if GCC considers string literals to be constants.
49cebcca 9461 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9462
35ac2a97
SM
94632011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9464
fb103ca9
SM
9465 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9466 (print_preprocess, print_object): New macro to fix last change.
9467
35ac2a97
SM
9468 * print.c (print_preprocess): Don't forget font objects.
9469
62973b41
JB
94702011-03-16 Juanma Barranquero <lekktu@gmail.com>
9471
9472 * emacs.c (USAGE3): Doc fixes.
9473
0e48bb22
AS
94742011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9475
9476 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9477 structure.
9478
7684e57b
JB
94792011-03-14 Juanma Barranquero <lekktu@gmail.com>
9480
9481 * lisp.h (VWindow_system, Qfile_name_history):
9482 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9483 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9484 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9485
9486 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9487 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9488
9489 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9490 * w32console.c (detect_input_pending, read_input_pending)
9491 (encode_terminal_code):
9492 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9493 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9494 (w32_system_caret_y, Qfile_name_history):
9495 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9496 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9497 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9498 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9499 * w32proc.c (Qlocal, report_file_error):
9500 * w32term.c (Vwindow_system, updating_frame):
9501 * w32uniscribe.c (initialized, uniscribe_font_driver):
9502 Remove unneeded extern declarations.
9503
2aa46d6c
CY
95042011-03-14 Chong Yidong <cyd@stupidchicken.com>
9505
c96bbc66 9506 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9507
cffc6f3b
CY
95082011-03-13 Chong Yidong <cyd@stupidchicken.com>
9509
9510 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9511 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9512 These macros can no longer be used for assignment.
9513
44f230aa
SM
9514 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9515 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9516 (record_buffer_markers, fetch_buffer_markers): New functions for
9517 recording and fetching special buffer markers.
9518 (set_buffer_internal_1, set_buffer_temp): Use them.
9519
9520 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9521
9522 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9523
9524 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9525 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9526
9527 * xdisp.c (hscroll_window_tree):
9528 (reconsider_clip_changes): Use PT instead of BUF_PT.
9529
d251f04b
EZ
95302011-03-13 Eli Zaretskii <eliz@gnu.org>
9531
9532 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9533 $(EMACS_ROOT)/lib/intprops.h.
9534
f0c77cd1
PE
95352011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9536
3eca4629
PE
9537 Fix more problems found by GCC 4.5.2's static checks.
9538
7c86ee98
PE
9539 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9540 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9541 (xg_free_frame_widgets): Make it clear that a local variable is
9542 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9543 (gdk_window_get_screen): Make it clear that this macro is needed
9544 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9545 (int_gtk_range_get_value): New function, which avoids a diagnostic
9546 from gcc -Wbad-function-cast.
9547 (xg_set_toolkit_scroll_bar_thumb): Use it.
9548 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9549 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9550 (get_utf8_string, xg_get_file_with_chooser):
9551 Rename locals to avoid shadowing.
9552 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9553
41729b81
PE
9554 * xgselect.c (xg_select): Remove unused var.
9555
f0c77cd1
PE
9556 * image.c (four_corners_best): Mark locals as initialized.
9557 (gif_load): Initialize transparent_p to zero (Bug#8238).
9558 Mark another local as initialized.
ec6cf4c6 9559 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9560
ce0ad53d 9561 * image.c (clear_image_cache): Now static.
d5d5a617 9562 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9563 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9564 (x_edge_detection): Remove unnecessary cast that
9565 gcc -Wbad-function-cast diagnoses.
2037898d 9566 (gif_load): Fix pointer signedness.
6ae141d6
PE
9567 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9568 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9569
33383987 95702011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9571
d32df629
PE
9572 Improve quality of tests for time stamp overflow.
9573 For example, without this patch (encode-time 0 0 0 1 1
9574 1152921504606846976) returns the obviously-bogus value (-948597
9575 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9576 reports time overflow. See
9577 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9578 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9579 * editfns.c: Include limits.h and intprops.h.
9580 (TIME_T_MIN, TIME_T_MAX): New macros.
9581 (time_overflow): Move earlier, to before first use.
9582 (hi_time, lo_time): New functions, for an accurate test for
9583 out-of-range times.
9584 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9585 (Fget_internal_run_time): Don't assume time_t fits in int.
9586 (make_time): Use list2 instead of Fcons twice.
9587 (Fdecode_time): More accurate test for out-of-range times.
9588 (check_tm_member): New function.
9589 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9590 (lisp_time_argument): Don't rely on undefined left-shift and
9591 right-shift behavior when checking for time stamp overflow.
8be6f318 9592
fe31d94c
PE
9593 * editfns.c (time_overflow): New function, refactoring common code.
9594 (Fformat_time_string, Fdecode_time, Fencode_time):
9595 (Fcurrent_time_string): Use it.
9596
8be6f318
PE
9597 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9598 * dired.c (make_time): Move to ...
9599 * editfns.c (make_time): ... here.
9600 * systime.h: Note the move.
9601
09d9db2c 96022011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9603
126bc0dc
YM
9604 * fringe.c (update_window_fringes): Remove unused variables.
9605
c47cbdfd
YM
9606 * unexmacosx.c (copy_data_segment): Also copy __got section.
9607 (Bug#8223)
9608
7ac80be9
EZ
96092011-03-12 Eli Zaretskii <eliz@gnu.org>
9610
c96bbc66 9611 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9612 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9613 Constify `char *' arguments and their references according to
9614 prototypes in tparam.h.
9615
ecb0f94d 9616 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9617
7ac80be9
EZ
9618 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9619 Adapt all references accordingly.
9620
9621 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9622
ef1fd07e
TT
96232011-03-11 Tom Tromey <tromey@redhat.com>
9624
9625 * buffer.c (syms_of_buffer): Remove obsolete comment.
9626
7ef4b50c
EZ
96272011-03-11 Eli Zaretskii <eliz@gnu.org>
9628
9629 * termhooks.h (encode_terminal_code): Declare prototype.
9630
9631 * msdos.c (encode_terminal_code): Don't declare prototype.
9632
9633 * term.c (encode_terminal_code): Now external again, used by
9634 w32console.c and msdos.c.
9635
44f230aa
SM
9636 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9637 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9638
4b1ec863 96392011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9640
1714f52b 9641 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9642
4b1ec863
PE
9643 * fringe.c (update_window_fringes): Mark locals as initialized
9644 (Bug#8227).
9645 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9646
524c7aa6
PE
9647 * alloc.c (mark_fringe_data): Move decl from here ...
9648 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9649 to check its interface.
9650 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9651
a5c0af81 9652 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9653 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9654 (fontset_font): Mark local as initialized.
a9a06e0b 9655 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9656
b4716021
PE
9657 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9658
811e9bac 9659 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9660 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9661 (x_own_selection, Fx_disown_selection_internal): Rename locals
9662 to avoid shadowing.
9663 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9664
7e3ab302
PE
9665 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9666 so that the caller can use some name other than gcpro1.
9667 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9668 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9669 (Fx_backspace_delete_keys_p):
9670 Use them to avoid shadowing, and rename vars to avoid shadowing.
9671 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9672 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9673 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9674 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9675 Remove unused locals.
7e3ab302
PE
9676 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9677 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9678 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9679 macros.
f78faa98 9680
e2b13473
PE
9681 * xterm.h (x_mouse_leave): New decl.
9682
77f23912
PE
9683 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9684 Remove unused functions.
cdf4ba58
PE
9685 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9686 (x_calc_absolute_position): Now static.
7411c686 9687 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9688 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9689 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9690 unless they are used.
38d0b34a
PE
9691 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9692 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9693 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9694 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9695 (x_error_catcher, x_connection_closed, x_error_handler):
9696 (x_error_quitter, xembed_send_message, x_iconify_frame):
9697 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9698 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9699 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9700
44f230aa
SM
9701 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9702 Rename or move locals to avoid shadowing.
6b463e58 9703 (tty_defined_color, merge_face_heights): Now static.
5967d051 9704 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9705 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9706 does not deduce is never used uninitialized.
73719eba
PE
9707 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9708 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9709
426994c3 9710 * terminal.c (store_terminal_param): Now static.
5489860b 9711
032f1620 9712 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9713 (set_frame_menubar): Remove unused local.
d4323972 9714 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9715 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9716 since they might point to immutable storage.
281585b0
PE
9717 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9718 since it's unused otherwise.
032f1620 9719
367c19e5 9720 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9721 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9722 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9723 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9724 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9725 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9726 does not deduce are never used uninitialized.
70739cbe 9727
07b48fa9
PE
9728 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9729
8868a238 9730 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9731 * window.c (window_loop, size_window):
9732 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9733
7e5cf297 9734 * window.c (display_buffer): Now static.
d6550a9f
PE
9735 (size_window): Mark variables that gcc -Wuninitialized
9736 does not deduce are never used uninitialized.
a586633d
PE
9737 * window.h (check_all_windows): New decl, to forestall
9738 gcc -Wmissing-prototypes diagnostic.
5b555da1 9739 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9740
f6095868
PE
9741 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9742 shadowing.
9743 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9744 Include <limits.h>.
9745 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9746 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9747 (load_charset_map): Mark variables that gcc -Wuninitialized
9748 does not deduce are never used uninitialized.
53df7c11 9749 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9750
f38b440c
PE
9751 * coding.c (coding_set_source, coding_set_destination):
9752 Use "else { /* comment */ }" rather than "else /* comment */;"
9753 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9754 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9755 a block, when the outer 'i' will do.
9756 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9757 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9758 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9759 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9760 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9761 Rename locals to avoid shadowing.
9762 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9763 * coding.c (emacs_mule_char, encode_invocation_designation):
9764 Now static, since they're not used elsewhere.
413bb2db 9765 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9766 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9767 (decode_coding_emacs_mule): Mark variables that gcc
9768 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9769 (detect_coding_iso_2022): Initialize a local variable that might
9770 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9771 this initialization is needed. (Bug#8211)
5f58e762
PE
9772 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9773 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9774 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9775 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9776 Remove unused macros.
f38b440c 9777
232b38b9 9778 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9779 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9780 * character.c (string_count_byte8): Likewise.
232b38b9 9781
fb90da1b
PE
9782 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9783 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9784
fb93dbc2
PE
9785 * chartab.c (copy_sub_char_table): Now static, since it's not used
9786 elsewhere.
5c156ace
PE
9787 (sub_char_table_ref_and_range, char_table_ref_and_range):
9788 Rename locals to avoid shadowing.
bbcd0949 9789 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9790
7d3b3862 9791 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9792 (BIDI_BOB): Remove unused macro.
7d3b3862 9793
6be7d3da
PE
9794 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9795 deduce are never used uninitialized.
c2ed9c8b 9796 * term.c (encode_terminal_code): Likewise.
6be7d3da 9797
75f8807f 9798 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9799
50938595
PE
9800 * tparam.h: New file.
9801 * term.c, tparam.h: Include it.
9802 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9803 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9804 Move these decls to tparam.h, and make them agree with what
9805 is actually in tparam.c. The previous trick of using incompatible
9806 decls in different modules does not conform to the C standard.
9807 All callers of tparam changed to use tparam's actual API.
9808 * tparam.c (tparam1, tparam, tgoto):
9809 Use const pointers where appropriate.
9810
fbceeba2
PE
9811 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9812 * cm.h (struct cm): Likewise.
9813 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9814 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9815 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9816 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9817 (turn_on_face, init_tty): Likewise.
9818 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9819
7f3f1250
PE
9820 * term.c (term_mouse_position): Rename local to avoid shadowing.
9821
e6ca6543
PE
9822 * alloc.c (mark_ttys): Move decl from here ...
9823 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9824
c40f8d15
AS
98252011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9826
9827 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9828
cfe0661d
JB
98292011-03-09 Juanma Barranquero <lekktu@gmail.com>
9830
9831 * search.c (compile_pattern_1): Remove argument regp, unused since
9832 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9833 (compile_pattern): Don't pass it.
9834
0afb4571
J
98352011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9836
9837 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9838 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9839 for ! HAVE_GTK3.
9840 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9841
9842 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9843
9844 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9845 gdk_window_get_screen, gdk_window_get_geometry,
9846 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9847 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9848 (xg_get_pixbuf_from_pixmap): New function.
9849 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9850 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9851 Call xg_get_pixbuf_from_pixmap instead of
9852 gdk_pixbuf_get_from_drawable.
9853 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9854 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9855 (xg_check_special_colors): Use GtkStyleContext and its functions
9856 for HAVE_GTK3.
9857 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9858 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9859 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9860 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9861 Call gtk_widget_get_preferred_size.
0afb4571
J
9862 (xg_frame_resized): gdk_window_get_geometry only takes 5
9863 parameters.
44f230aa
SM
9864 (xg_win_to_widget, xg_event_is_for_menubar):
9865 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9866 (xg_set_widget_bg): New function.
9867 (delete_cb): New function.
895009e1 9868 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9869 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9870 (xg_set_background_color): Call xg_set_widget_bg.
9871 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9872 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9873 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9874 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9875 if ! HAVE_GTK3.
9876 (update_frame_tool_bar): Call gtk_widget_hide.
9877 (xg_initialize): Use GDK_KEY_g.
9878
9879 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9880 if ! HAVE_GTK3
9881 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9882
9883 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9884 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9885 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9886
1c2cc4ef
JB
98872011-03-08 Juanma Barranquero <lekktu@gmail.com>
9888
9889 * w32xfns.c (select_palette): Check success of RealizePalette against
9890 GDI_ERROR, not zero.
9891
33383987 9892See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9893
9894;; Local Variables:
9895;; coding: utf-8
aac0c6e3
MR
9896;; End:
9897
2f097256 9898 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9899
9900 This file is part of GNU Emacs.
9901
9902 GNU Emacs is free software: you can redistribute it and/or modify
9903 it under the terms of the GNU General Public License as published by
9904 the Free Software Foundation, either version 3 of the License, or
9905 (at your option) any later version.
9906
9907 GNU Emacs is distributed in the hope that it will be useful,
9908 but WITHOUT ANY WARRANTY; without even the implied warranty of
9909 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9910 GNU General Public License for more details.
9911
9912 You should have received a copy of the GNU General Public License
9913 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.