* lisp/pcomplete.el (pcomplete-completions-at-point):
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e810457d
PE
12011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2
3 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4
ea51cceb
JB
52011-04-27 Juanma Barranquero <lekktu@gmail.com>
6
7 * makefile.w32-in: Update dependencies.
8
94dcfacf
EZ
92011-04-27 Eli Zaretskii <eliz@gnu.org>
10
11 Improve `doprnt' and its usage. (Bug#8545)
12 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
13 `format_end'. Remove support for %l as a conversion specifier.
14 Don't use xrealloc. Improve diagnostics when the %l size modifier
15 is used. Update the commentary.
16
17 * eval.c (verror): Simplify calculation of size_t.
18
19 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
20 messages.
21
f61f41d7
PE
222011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
23
24 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
25 change.
26
96fb4434
PE
272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
28
29 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
30 This makes this file independent of the recent pseudovector change.
31
671875da 322011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 33
69e9b5a3
PE
34 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
35
b5f869a7 36 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 37 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 38 Remove unused local.
c8926152 39 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 40
841a1577 41 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
42 GCC 4.6.0 optimizes based on type-based alias analysis. For
43 example, if b is of type struct buffer * and v of type struct
44 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
45 != &v->size, and therefore "v->size = 1; b->size = 2; return
46 v->size;" must therefore return 1. This assumption is incorrect
47 for Emacs, since it type-puns struct Lisp_Vector * with many other
48 types. To fix this problem, this patch adds a new type struct
f904488f 49 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
50 and pseudovectors, and helps optimizing compilers not get fooled
51 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
52 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
53 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
54 the size member.
eab3844f
PE
55 (XSETPVECTYPE): Rewrite in terms of new macro.
56 (XSETPVECTYPESIZE): New macro, specifying both type and size.
57 This is a bit clearer, and further avoids the possibility of
58 undesirable aliasing.
59 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 60 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
61 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
62 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
63 (ASIZE): Now uses header.size rather than size. All
64 previous uses of XVECTOR (foo)->size replaced to use this macro,
65 to avoid the hassle of writing XVECTOR (foo)->header.size.
66 (struct vectorlike_header): New type.
eab3844f
PE
67 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
68 object, to help avoid aliasing.
69 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
70 (SUBRP): Likewise, since Lisp_Subr is a special case.
71 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
72 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
73 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 74 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
75 changed to be "header.size" and "header.next".
76 * buffer.h (struct buffer): Likewise.
77 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
78 * frame.h (struct frame): Likewise.
79 * process.h (struct Lisp_Process): Likewise.
80 * termhooks.h (struct terminal): Likewise.
81 * window.c (struct save_window_data, struct saved_window): Likewise.
82 * window.h (struct window): Likewise.
83 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
84 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
85 * buffer.c (init_buffer_once): Likewise.
86 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
87 special case.
88 * process.c (Fformat_network_address): Use local var for size,
89 for brevity.
90
0df1eac5
PE
91 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
92
847ab9d1 93 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
94 * data.c (atof): Remove decl; no longer used or needed.
95 (digit_to_number): Move to lread.c.
96 (Fstring_to_number): Use new string_to_number function, to be
97 consistent with how the Lisp reader treats infinities and NaNs.
98 Do not assume that floating-point numbers represent EMACS_INT
99 without losing information; this is not true on most 64-bit hosts.
100 Avoid double-rounding errors, by insisting on integers when
101 parsing non-base-10 numbers, as the documentation specifies.
102 * lisp.h (string_to_number): New decl, replacing ...
103 (isfloat_string): Remove.
bc0a5c13 104 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 105 (read1): Do not accept +. and -. as integers; this
452f4150
PE
106 appears to have been a coding error. Similarly, do not accept
107 strings like +-1e0 as floating point numbers. Do not report
108 overflow for integer overflows unless the base is not 10 which
109 means we have no simple and reliable way to continue.
110 Break out the floating-point parsing into a new
111 function string_to_number, so that Fstring_to_number parses
112 floating point numbers consistently with the Lisp reader.
113 (digit_to_number): Moved here from data.c. Make it static inline.
114 (E_CHAR, EXP_INT): Remove, replacing with ...
115 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
116 (string_to_number): New function, replacing isfloat_string.
117 This function checks for valid syntax and produces the resulting
118 Lisp float number too. Rework it so that string-to-number
bc0a5c13 119 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
120 so that overflow for non-base-10 numbers is reported only when
121 there's no portable and simple way to convert to floating point.
452f4150 122
67769ffc
PE
123 * textprop.c (set_text_properties_1): Rewrite for clarity,
124 and to avoid GCC warning about integer overflow.
125
c20db43f
PE
126 * intervals.h (struct interval): Use EMACS_INT for members
127 where EMACS_UINT might cause problems. See
128 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
129 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
130 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
131 All uses changed.
37aa2f85
PE
132 (offset_intervals): Tell GCC not to worry about length overflow
133 when negating a negative length.
c20db43f 134
2538aa2f
PE
135 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
136 (overrun_check_free): Likewise.
137
f2d3008d
PE
138 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
139 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
140 word size.
141
ec8df744
PE
142 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
143 (gnutls_make_error): Rename local to avoid shadowing.
144 (gnutls_emacs_global_deinit): ifdef out; not used.
145 (Fgnutls_boot): Use const for pointer to readonly storage.
146 Comment out unused local. Fix pointer signedness problems.
147
640ee02d
PE
148 * lread.c (openp): Don't stuff size_t into an 'int'.
149 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
150 about possible signed overflow.
151
6048fb2a
PE
152 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
153 (GDK_KEY_g): Don't define if already defined.
154 (xg_prepare_tooltip): Avoid pointer signedness problem.
155 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
156
fa3c87e1
PE
157 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
158 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
159
2172544b
PE
160 * xfns.c (Fx_window_property): Simplify a bit,
161 to make a bit faster and to avoid GCC 4.6.0 warning.
162 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
163
9b821a21
PE
164 * fns.c (internal_equal): Don't assume size_t fits in int.
165
3c616cfa
PE
166 * alloc.c (compact_small_strings): Tighten assertion a little.
167
c2982e87
PE
168 Replace pEd with more-general pI, and fix some printf arg casts.
169 * lisp.h (pI): New macro, generalizing old pEd macro to other
170 conversion specifiers. For example, use "...%"pI"d..." rather
171 than "...%"pEd"...".
172 (pEd): Remove. All uses replaced with similar uses of pI.
173 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
174 * alloc.c (check_pure_size): Don't overflow by converting size to int.
175 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
176 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
177 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
178 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
179 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
180 64-bit hosts.
181 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
182 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
183 * print.c (safe_debug_print, print_object): Likewise.
184 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
185 to int.
6f04d126
PE
186 Use pI instead of if-then-else-abort. Use %p to avoid casts,
187 avoiding the 0 flag, which is not portable.
c2982e87
PE
188 * process.c (Fmake_network_process): Use pI to avoid cast.
189 * region-cache.c (pp_cache): Likewise.
190 * xdisp.c (decode_mode_spec): Likewise.
191 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
192 behavior on 64-bit hosts with printf arg.
6f04d126 193 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
194 (x_stop_queuing_selection_requests): Likewise.
195 (x_get_window_property): Don't truncate byte count to an 'int'
196 when tracing.
0b432f21 197
5e073ec7
PE
198 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
199 here, since it parses constructs like leading '-' and spaces,
200 which are not wanted; and it overflows with large numbers.
201 Instead, simply match F[0-9]+, which is what is wanted anyway.
202
36372bf9
PE
203 * alloc.c: Remove unportable assumptions about struct layout.
204 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
205 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
206 (allocate_vectorlike, make_pure_vector): Use the new macros,
207 plus offsetof, to remove unportable assumptions about struct layout.
208 These assumptions hold on all porting targets that I know of, but
209 they are not guaranteed, they're easy to remove, and removing them
210 makes further changes easier.
211
0b432f21
PE
212 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
213 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
214 (string_overrun_cookie): Now const. Use initializers that
215 don't formally overflow signed char, to avoid warnings.
000098c1
PE
216 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
217 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
218 (allocate_buffer): Don't assume sizeof (struct buffer) is a
219 multiple of sizeof (EMACS_INT); it need not be, if
220 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 221 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 222
895009e1
JB
2232011-04-26 Juanma Barranquero <lekktu@gmail.com>
224
225 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
226
6a7a1b0b
TZ
2272011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
228
229 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 230 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
231 Reported by Paul Eggert <eggert@cs.ucla.edu>.
232
841a1577 2332011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
234
235 * lisp.h (Qdebug): List symbol.
895009e1 236 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
237 * keyboard.c (debug-on-event): New variable.
238 (handle_user_signal): Break into debugger when debug-on-event
239 matches the current signal symbol.
240
f2d3ba6f
DN
2412011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
242
243 * alloc.c (check_sblock, check_string_bytes)
244 (check_string_free_list): Convert to standard C.
245
42ce4c63
TZ
2462011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
247
248 * w32.c (emacs_gnutls_push): Fix typo.
249
825cd63c
EZ
2502011-04-25 Eli Zaretskii <eliz@gnu.org>
251
fb11d64d
EZ
252 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
253 "cast to pointer from integer of different size".
254
825cd63c
EZ
255 Improve doprnt and its use in verror. (Bug#8545)
256 * doprnt.c (doprnt): Document the set of format control sequences
257 supported by the function. Use SAFE_ALLOCA instead of always
258 using `alloca'.
259
260 * eval.c (verror): Don't limit the buffer size at size_max-1, that
261 is one byte too soon. Don't use xrealloc; instead xfree and
262 xmalloc anew.
263
e061a11b
TZ
2642011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
265
266 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
267 callbacks stage.
268
269 * gnutls.c: Renamed global_initialized to
270 gnutls_global_initialized. Added internals for the
271 :verify-hostname-error, :verify-error, and :verify-flags
272 parameters of `gnutls-boot' and documented those parameters in the
273 docstring. Start callback support.
274 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
275 unless a fatal error occured. Call gnutls_alert_send_appropriate
276 on error. Return error code.
277 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
278 (emacs_gnutls_read): Likewise.
279 (Fgnutls_boot): Return handshake error code.
280 (emacs_gnutls_handle_error): New function.
281 (wsaerror_to_errno): Likewise.
282
283 * w32.h (emacs_gnutls_pull): Add prototype.
284 (emacs_gnutls_push): Likewise.
285
286 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
287 (emacs_gnutls_push): Likewise.
288
2892011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
290
291 * process.c (wait_reading_process_output): Check if GnuTLS
292 buffered some data internally if no FDs are set for TLS
293 connections.
294
295 * makefile.w32-in (OBJ2): Add gnutls.$(O).
296 (LIBS): Link to USER_LIBS.
297 ($(BLD)/gnutls.$(0)): New target.
298
fa6996bc
EZ
2992011-04-24 Eli Zaretskii <eliz@gnu.org>
300
eb35682e
EZ
301 * xdisp.c (handle_single_display_spec): Rename the
302 display_replaced_before_p argument into display_replaced_p, to
303 make it consistent with the commentary. Fix typos in the
304 commentary.
305
e2ad650c
EZ
306 * textprop.c (syms_of_textprop): Remove dead code.
307 (copy_text_properties): Delete obsolete commentary about an
308 interface that was deleted long ago. Fix typos in the description
309 of arguments.
310
1b2de274
EZ
311 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
312 to changes in oldXMenu/XMenu.h from 2011-04-16.
313 <menu_help_message, prev_menu_help_message>: Constify.
314 (IT_menu_make_room): menu->help_text is now `const char **';
315 adjust.
316
317 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
318 to changes in oldXMenu/XMenu.h from 2011-04-16.
319 (struct XMenu): Declare `help_text' `const char **'.
320
321 * xfaces.c <Qunspecified>: Make extern again.
322
323 * syntax.c: Include sys/types.h before including regex.h, as
324 required by Posix.
325
762b15be
EZ
326 * doc.c (get_doc_string): Improve the format passed to `error'.
327
328 * doprnt.c (doprnt): Improve commentary.
329
330 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
331
332 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
333 them with etags.
334
f1052e5d
EZ
335 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
336 changes in globals.h immediately force recompilation.
762b15be
EZ
337 (TAGS): Depend on $(CURDIR)/m/intel386.h and
338 $(CURDIR)/s/ms-w32.h.
339 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 340
fa6996bc
EZ
341 * character.c (Fchar_direction): Function deleted.
342 (syms_of_character): Don't defsubr it.
343 <char-direction-table>: Deleted.
344
e6c3da20
EZ
3452011-04-23 Eli Zaretskii <eliz@gnu.org>
346
347 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
348 * doprnt.c: Include limits.h.
349 (SIZE_MAX): New macro.
350 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
351 local variables are now size_t instead of int or unsigned.
352 Improve overflow protection. Support `l' modifier for integer
353 conversions. Support %l conversion. Don't assume an EMACS_INT
354 argument for integer conversions and for %c.
355
356 * lisp.h (doprnt): Restore prototype.
357
358 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
359 $(SRC)/character.h.
360
361 * Makefile.in (base_obj): Add back doprnt.o.
362
363 * deps.mk (doprnt.o): Add back prerequisites.
364 (callint.o): Depend on character.h.
365
366 * eval.c (internal_lisp_condition_case): Include the handler
367 representation in the error message.
368 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
369 when breaking from the loop.
370
371 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
372
373 * callint.c (Fcall_interactively): When displaying error message
374 about invalid control letter, pass the character's codepoint, not
375 a pointer to its multibyte form. Improve display of the character
376 in octal and display also its hex code.
377
378 * character.c (char_string): Use %x to display the (unsigned)
379 codepoint of an invalid character, to avoid displaying a bogus
380 negative value.
381
382 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
383 `error', not SYMBOL_NAME itself.
384
385 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
386 character arguments to `error'.
387
388 * charset.c (check_iso_charset_parameter): Fix incorrect argument
389 to `error' in error message about FINAL_CHAR argument. Make sure
390 FINAL_CHAR is a character, and use %c when it is passed as
391 argument to `error'.
392
4ffd0d6b 3932011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
394
395 * s/ms-w32.h (localtime): Redirect to sys_localtime.
396
397 * w32.c: Include <time.h>.
398 (sys_localtime): New function.
399
4ffd0d6b 4002011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
401
402 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
403
4ffd0d6b 404 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 405
4ffd0d6b 4062011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 407
4ffd0d6b
GM
408 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
409 zombies (Bug#8467).
aac0c6e3 410
04c56954
EZ
4112011-04-19 Eli Zaretskii <eliz@gnu.org>
412
413 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
414 gl_state.e_property when gl_state.object is Qt.
415
416 * insdel.c (make_gap_larger): Remove limitation of buffer size
417 to <= INT_MAX.
418
16a43933
CY
4192011-04-18 Chong Yidong <cyd@stupidchicken.com>
420
421 * xdisp.c (lookup_glyphless_char_display)
422 (produce_glyphless_glyph): Handle cons cell entry in
423 glyphless-char-display.
424 (Vglyphless_char_display): Document it.
425
426 * term.c (produce_glyphless_glyph): Handle cons cell entry in
427 glyphless-char-display.
428
4581706e
CY
4292011-04-17 Chong Yidong <cyd@stupidchicken.com>
430
431 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
432
433 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
434
435 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
436 definition for no-X builds.
437
4887c6e2 4382011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 439
fd35b6f9
PE
440 Static checks with GCC 4.6.0 and non-default toolkits.
441
5c1ccb01
PE
442 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
443
006c5daa
PE
444 * process.c (keyboard_bit_set): Define only if SIGIO.
445 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
446 (send_process): Repair possible setjmp clobbering.
447
efc736d3
PE
448 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
449
4e2fe2e6
PE
450 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
451
f97334a2
PE
452 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
453
4e75f29d
PE
454 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
455 Define only if needed.
456
90efadd1
PE
457 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
458 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 459 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 460
3c647824
PE
461 * dispextern.h (struct redisplay_interface): Rename param
462 to avoid shadowing.
e264f262 463 * termhooks.h (struct terminal): Likewise.
761383f4 464 * xterm.c (xembed_send_message): Likewise.
3c647824 465
b58c5c4a
PE
466 * insdel.c (make_gap_smaller): Define only if
467 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
468
cad59032
PE
469 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
470 it.
471
c339dc2e
PE
472 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
473 so that we aren't warned about unused symbols.
474
91a3e27b
PE
475 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
476
399c71d3 477 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 478
8ffc96f5
PE
479 * xfns.c (x_real_positions): Mark locals as initialized.
480
eef9bc79
PE
481 * xmenu.c (xmenu_show): Don't use uninitialized vars.
482
098db9dd
PE
483 * xterm.c: Fix problems found by static analysis with other toolkits.
484 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
485 (x_dispatch_event): Declare static if USE_GTK, and
486 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 487 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 488 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
489 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
490 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 491
eb18f6cc
PE
492 * xmenu.c (menu_help_callback): Pointer type fixes.
493 Use const pointers when pointing at readonly data. Avoid pointer
494 signedness clashes.
495 (FALSE): Remove unused macro.
496 (update_frame_menubar): Remove unused decl.
497
1fe72bf8
PE
498 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
499
60d9e1db
PE
500 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
501 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
502 (single_menu_item): Rename local to avoid shadowing.
503
39261c26
PE
504 * keyboard.c (make_lispy_event): Remove unused local var.
505
018c5e19
PE
506 * frame.c, frame.h (x_get_resource_string): Bring this back, but
507 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
508
63d2b86e
PE
509 * bitmaps: Change bitmaps from unsigned char back to the X11
510 compatible char. Avoid the old compiler warnings about
511 out-of-range initializers by using, for example, '\xab' rather
512 than 0xab.
513
aefd87e1
PE
514 * xgselect.c (xgselect_initialize): Check vs interface
515 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
516
bf501fb9
PE
517 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
518
e9829fdf
PE
519 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
520 to read-only memory.
521
1086c095
PE
522 * fns.c (vector): Remove; this old hack is no longer needed.
523
2baccd04 524 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 525 Remove unused var.
dde42981 526 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 527
72391843 528 * xrdb.c (x_load_resources): Omit unused local.
3565b346 529
436c16df 530 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 531 (x_window): Rename locals to avoid shadowing.
dc5ddd85 532 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 533
92bb796d 534 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 535 (x_term_init): Remove local to avoid shadowing.
92bb796d 536
764430a3 537 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
538
539 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
540 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
541
d1dfb56c
EZ
5422011-04-16 Eli Zaretskii <eliz@gnu.org>
543
c4354cb4
EZ
544 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
545
d1dfb56c
EZ
546 Fix regex.c, syntax.c and friends for buffers > 2GB.
547 * syntax.h (struct gl_state_s): Declare character position members
548 EMACS_INT.
549
550 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
551
552 * textprop.c (verify_interval_modification, interval_of): Declare
553 arguments EMACS_INT.
554
555 * intervals.c (adjust_intervals_for_insertion): Declare arguments
556 EMACS_INT.
557
558 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
559
560 * indent.c (Fvertical_motion): Local variable it_start is now
561 EMACS_INT.
562
563 * regex.c (re_match, re_match_2, re_match_2_internal)
564 (bcmp_translate, regcomp, regexec, print_double_string)
565 (group_in_compile_stack, re_search, re_search_2, regex_compile)
566 (re_compile_pattern, re_exec): Declare arguments and local
567 variables `size_t' and `ssize_t' and return values `regoff_t', as
568 appropriate.
569 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
570 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
571 <compile_stack_type>: `size' and `avail' are now `size_t'.
572
573 * regex.h <regoff_t>: Use ssize_t, not int.
574 (re_search, re_search_2, re_match, re_match_2): Arguments that
575 specify buffer/string position and length are now ssize_t and
576 size_t. Return type is regoff_t.
577
613052cd
BK
5782011-04-16 Ben Key <bkey76@gmail.com>
579
580 * nsfont.m: Fixed bugs in ns_get_family and
581 ns_descriptor_to_entity that were caused by using free to
582 deallocate memory blocks that were allocated by xmalloc (via
583 xstrdup). This caused Emacs to crash when compiled with
584 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
585 --enable-checking=xmallocoverrun). xfree is now used to
586 deallocate these memory blocks.
587
4170f62f 5882011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 589
71b41406
PE
590 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
591
9587a89d
PE
592 emacs_write: Accept and return EMACS_INT for sizes.
593 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
594 et seq.
595 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
596 Accept and return EMACS_INT.
597 (emacs_gnutls_write): Return the number of bytes written on
598 partial writes.
599 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
600 (emacs_read, emacs_write): Remove check for negative size, as the
601 Emacs source code has been audited now.
9587a89d
PE
602 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
603 (emacs_read, emacs_write): Use it.
273a5f82
PE
604 * process.c (send_process): Adjust to the new signatures of
605 emacs_write and emacs_gnutls_write. Do not attempt to store
606 a byte offset into an 'int'; it might overflow.
9587a89d 607 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 608
3e047f51
PE
609 * sound.c: Don't assume sizes fit in 'int'.
610 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 611 Return EMACS_INT, not int.
3e047f51 612 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
613 Accept EMACS_INT, not int.
614 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
615 record read return values.
616
cc39a9db
BK
6172011-04-15 Ben Key <bkey76@gmail.com>
618
c9d0ec6d
JB
619 * keyboard.c (Qundefined): Don't declare static since it is used
620 in nsfns.m.
621 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
622 static since they are used in nsfont.m.
cc39a9db 623
6c60eb9f
SM
6242011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
625
626 * process.c (Qprocessp): Don't declare static.
627 * lisp.h (Qprocessp): Declare again.
628
7990b61a
JB
6292011-04-15 Juanma Barranquero <lekktu@gmail.com>
630
631 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
632
5d4cb038
PE
6332011-04-14 Paul Eggert <eggert@cs.ucla.edu>
634
8bd7b830 635 Improve C-level modularity by making more things 'static'.
cd64ea1d 636
e3b27b31
PE
637 Don't publish debugger-only interfaces to other modules.
638 * lisp.h (safe_debug_print, debug_output_compilation_hack):
639 (verify_bytepos, count_markers): Move decls to the only modules
640 that need them.
641 * region-cache.h (pp_cache): Likewise.
642 * window.h (check_all_windows): Likewise.
643 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
644
5d4cb038
PE
645 * sysdep.c (croak): Now static, if
646 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
647 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
648
649 * alloc.c (refill_memory_reserve): Now static if
650 !defined REL_ALLOC || defined SYSTEM_MALLOC.
651 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 652
e87b6180
PE
653 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
654 Define only if USE_LUCID.
655
ac64929e
PE
656 * xrdb.c (x_customization_string, x_rm_string): Now static.
657
6f37259d
PE
658 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
659 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
660
1683e3ab
PE
661 * xdisp.c (draw_row_with_mouse_face): Now static.
662 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
663
de9c2632
PE
664 * window.h (check_all_windows): Mark externally visible.
665
2b96acb7
PE
666 * window.c (window_deletion_count): Now static.
667
668 * undo.c: Make symbols static if they're not exported.
669 (last_undo_buffer, last_boundary_position, pending_boundary):
670 Now static.
671
50436f33
PE
672 * textprop.c (interval_insert_behind_hooks): Now static.
673 (interval_insert_in_front_hooks): Likewise.
674
64520e5c
PE
675 * term.c: Make symbols static if they're not exported.
676 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
677 (max_frame_lines, tty_set_terminal_modes):
678 (tty_reset_terminal_modes, tty_turn_off_highlight):
679 (get_tty_terminal): Now static.
680 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
681 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 682 HAVE_WINDOW_SYSTEM.
64520e5c
PE
683 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
684 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
685
1fa53021
PE
686 * sysdep.c: Make symbols static if they're not exported.
687 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
688 Now static.
689 (sigprocmask_set, full_mask): Remove; unused.
690 (wait_debugging): Mark as visible.
691 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
692 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
693
d4b43b22
PE
694 * syntax.c (syntax_temp): Define only if !__GNUC__.
695
b7c513d0
PE
696 * sound.c (current_sound_device, current_sound): Now static.
697
989b29ad
PE
698 * search.c (searchbufs, searchbuf_head): Now static.
699
13a55a78
PE
700 * scroll.c (scroll_cost): Remove; unused.
701 * dispextern.h (scroll_cost): Remove decl.
702
de68a1fc
PE
703 * region-cache.h (pp_cache): Mark as externally visible.
704
40ccffa6
PE
705 * process.c: Make symbols static if they're not exported.
706 (process_tick, update_tick, create_process, chan_process):
707 (Vprocess_alist, proc_buffered_char, datagram_access):
708 (fd_callback_data, send_process_frame, process_sent_to): Now static.
709 (deactivate_process): Mark defn as static, as well as decl.
710 * lisp.h (create_process): Remove decl.
711 * process.h (chan_process, Vprocess_alist): Remove decls.
712
ad64fc97
PE
713 * print.c: Make symbols static if they're not exported.
714 (print_depth, new_backquote_output, being_printed, print_buffer):
715 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
716 (print_interval, print_number_index, initial_stderr_stream):
717 Now static.
718 * lisp.h (Fprinc): Remove decl.
719 (debug_output_compilation_hack): Mark as externally visible.
720
adddb265
PE
721 * sysdep.c (croak): Move decl from here to syssignal.h.
722 * syssignal.h (croak): Put it here, so the API can be checked when
723 'croak' is called from dissociate_if_controlling_tty.
724
1717ede2
PE
725 * minibuf.c: Make symbols static if they're not exported.
726 (minibuf_save_list, choose_minibuf_frame): Now static.
727 * lisp.h (choose_minibuf_frame): Remove decl.
728
fa5fb2bc
PE
729 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
730
1e3890d1
PE
731 * lread.c: Make symbols static if they're not exported.
732 (read_objects, initial_obarray, oblookup_last_bucket_number):
733 Now static.
734 (make_symbol): Remove; unused.
735 * lisp.h (initial_obarray, make_symbol): Remove decls.
736
8a1414fa
PE
737 * keyboard.c: Make symbols static if they're not exported.
738 (single_kboard, recent_keys_index, total_keys, recent_keys):
739 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
740 (this_single_command_key_start, echoing, last_auto_save):
741 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
742 (command_loop, echo_now, keyboard_init_hook, help_char_p):
743 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
744 (Vlispy_mouse_stem, double_click_count):
745 Now static.
746 (force_auto_save_soon): Define only if SIGDANGER.
747 (ignore_mouse_drag_p): Now static if
748 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
749 (print_help): Remove; unused.
750 (stop_character, last_timer_event): Mark as externally visible.
751 * keyboard.h (ignore_mouse_drag_p): Declare only if
752 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
753 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
754 * lisp.h (echoing): Remove decl.
755 (force_auto_save_soon): Declare only if SIGDANGER.
756 * xdisp.c (redisplay_window): Simplify code, to make it more
757 obvious that ignore_mouse_drag_p is not accessed if !defined
758 USE_GTK && !defined HAVE_NS.
759
93ea6e8f
PE
760 * intervals.c: Make symbols static if they're not exported.
761 (merge_properties_sticky, merge_interval_right, delete_interval):
762 Now static.
763 * intervals.h (merge_interval_right, delete_interval): Remove decls.
764
77382fcc
PE
765 * insdel.c: Make symbols static if they're not exported.
766 However, leave prepare_to_modify_buffer alone. It's never
767 called from outside this function, but that appears to be a bug.
768 (combine_after_change_list, combine_after_change_buffer):
4889fc82 769 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
770 (adjust_after_replace_noundo): Remove; unused.
771 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 772 (signal_before_change): Remove decls.
77382fcc 773
9306c32e
PE
774 * indent.c (val_compute_motion, val_vmotion): Now static.
775
cd44d2eb
PE
776 * image.c: Make symbols static if they're not exported.
777 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
778 if USE_GTK.
779 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
780 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
781
ad9a7a06
PE
782 * fringe.c (standard_bitmaps): Now static.
783 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
784
81626931
PE
785 * frame.c: Make symbols static if they're not exported.
786 (x_report_frame_params, make_terminal_frame): Now static.
787 (get_frame_param): Now static, unless HAVE_NS.
788 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
789 (x_get_resource_string): Remove; not used.
790 * frame.h (make_terminal_frame, x_report_frame_params):
791 (x_get_resource_string); Remove decls.
792 (x_fullscreen_adjust): Declare only if WINDOWSNT.
793 * lisp.h (get_frame_param): Declare only if HAVE_NS.
794
239f9db9
PE
795 * font.c, fontset.c: Make symbols static if they're not exported.
796 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
797 (FACE_SUITABLE_FOR_CHAR_P): Use it.
798 * font.c (font_close_object): Now static.
799 * font.h (font_close_object): Remove.
800 * fontset.c (FONTSET_OBJLIST): Remove.
801 (free_realized_fontset) #if-0 the body, which does nothing.
802 (face_suitable_for_char_p): #if-0, as it's never called.
803 * fontset.h (face_suitable_for_char_p): Remove decl.
804 * xfaces.c (face_at_string_position): Use
805 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
806 since 0 is always ASCII.
807
dfcf3579
PE
808 * fns.c (weak_hash_tables): Now static.
809
5045092b
PE
810 * fileio.c: Make symbols static if they're not exported.
811 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
812 (Vwrite_region_annotation_buffers): Now static.
813
57a96f5c
PE
814 * eval.c: Make symbols static if they're not exported.
815 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
816 * lisp.h (backtrace_list): Remove decl.
817
35f08c38
PE
818 * emacs.c: Make symbols static if they're not exported.
819 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
820 (fatal_error_code, fatal_error_signal_hook, standard_args):
821 Now static.
822 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
823 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
824 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
825 * lisp.h (fatal_error_signal_hook): Remove decl.
826 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
827
f44bd759
PE
828 * editfns.c: Move a (normally-unused) function to its only use.
829 * editfns.c, lisp.h (get_operating_system_release): Remove.
830 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
831 worth the hassle of breaking this out.
832
b532497d
PE
833 * xterm.c: Make symbols static if they're not exported.
834 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
835 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
836 (x_destroy_window, x_delete_display):
837 Now static.
838 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
839 (x_mouse_leave): Remove; unused.
840 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
841 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
842 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
843 Remove decls.
844 (x_mouse_leave): Declare only if WINDOWSNT.
845 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
846 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
847 USE_X_TOOLKIT.
848
1675728f
PE
849 * ftxfont.c: Make symbols static if they're not exported.
850 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
851 HAVE_FREETYPE.
852 * font.h (ftxfont_driver): Likewise.
853
e4cebfca
PE
854 * xfns.c: Make symbols static if they're not exported.
855 (x_last_font_name, x_display_info_for_name):
856 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
857 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
858 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
859 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
860 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
861 (last_show_tip_args): Now static.
862 (xic_defaut_fontset, xic_create_fontsetname): Define only if
863 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
864 (x_screen_planes): Remove; unused.
865 * dispextern.h (x_screen_planes): Remove decl.
866
5bf46f05
PE
867 * dispnew.c: Make symbols static if they're not exported.
868 * dispextern.h (redraw_garbaged_frames, scrolling):
869 (increment_row_positions): Remove.
870 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
871 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
872 Now static.
873 (redraw_garbaged_frames): Remove; unused.
874
435f4c28
PE
875 * xfaces.c: Make symbols static if they're not exported.
876 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
877 Remove decls.
878 * xterm.h (defined_color): Remove decls.
879 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
880 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
881 (menu_face_changed_default, defined_color, free_realized_face):
882 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
883 (ascii_face_of_lisp_face): Remove; unused.
884
8524aef3
PE
885 * xdisp.c: Make symbols static if they're not exported.
886 * dispextern.h (scratch_glyph_row, window_box_edges):
887 (glyph_to_pixel_coords, set_cursor_from_row):
888 (get_next_display_element, set_iterator_to_next):
889 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
890 (show_mouse_face): Remove decls
891 * frame.h (message_buf_print): Likewise.
892 * lisp.h (pop_message, set_message, check_point_in_composition):
893 Likewise.
894 * xterm.h (set_vertical_scroll_bar): Likewise.
895 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
896 (message_buf_print, scratch_glyph_row, displayed_buffer):
897 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
898 (get_next_display_element, show_mouse_face, window_box_edges):
899 (frame_to_window_pixel_xy, check_point_in_composition):
900 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
901 (glyph_to_pixel_coords): Remove; unused.
902
16390cd2
PE
903 * dired.c (file_name_completion): Now static.
904
905 * dbusbind.c (xd_in_read_queued_messages): Now static.
906
a25f4dfa
PE
907 * lisp.h (circular_list_error, FOREACH): Remove; unused.
908 * data.c (circular_list_error): Remove.
909
14a9c8df
PE
910 * commands.h (last_point_position, last_point_position_buffer):
911 (last_point_position_window): Remove decls.
912 * keyboard.c: Make these variables static.
913
74ab6df5
PE
914 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
915 decls.
916 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
917 (iso_code_class, detect_coding, code_convert_region): Now static.
918 (encode_coding_gap): Remove; unused.
919
38dfbee1
PE
920 * chartab.c (chartab_chars, chartab_bits): Now static.
921
a2cb4e63
PE
922 * charset.h (charset_iso_8859_1): Remove decl.
923 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
924 Now static.
925
127198fd
PE
926 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
927 * ccl.c (Vccl_program_table): Now static.
928 (check_ccl_update): Remove; unused.
929
d85b608f
PE
930 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
931 * category.h: ... from here.
932 * category.c (check_category_table, set_category_set): Now static.
933
31cd66f3
PE
934 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
935 * lisp.h: Remove these decls.
936
c358e587
PE
937 * buffer.c (buffer_count): Remove unused var.
938
e78aecca
PE
939 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
940 so that it's not optimized away.
941 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
942 * dispextern.h (bidi_dump_cached_states): Remove, since it's
943 exported only to the debugger.
944
e192d7d3
PE
945 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
946 * atimer.h (run_all_atimers): Removed; not exported.
947
92470028
PE
948 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
949 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
950 was inaccessible from Lisp.
951 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
952 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
953
244ed907
PE
954 alloc.c: Import and export fewer symbols, and remove unused items.
955 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
956 is defined.
957 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
958 it's not optimized away by whole-program optimization.
959 (message_enable_multibyte, free_misc): Remove.
960 (catchlist, handlerlist, mark_backtrace):
961 Declare only if BYTE_MARK_STACK.
962 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
963 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
964 (message_enable_multibyte): Remove decl.
965 (free_misc, interval_free_list, float_block, float_block_index):
966 (n_float_blocks, float_free_list, cons_block, cons_block_index):
967 (cons_free_list, last_marked_index):
968 Now static.
969 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
970 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
971 (mark_backtrace): Define only if BYTE_MARK_STACK.
972 * xdisp.c (message_enable_multibyte): Now static.
973
61c2b50e 974 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
975 This makes it easier for human readers (and static analyzers)
976 to see whether these variables are used from other modules.
977 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
978 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
979 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
980 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
981 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
982 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
983 * xmenu.c, xselect.c:
984 Declare Q* vars static if they are not used in other modules.
985 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
986 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
987 Remove decls of unexported vars.
988 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
989
95c82688
PE
990 * lisp.h (DEFINE_FUNC): Make sname 'static'.
991
16a97296
PE
992 Make Emacs functions such as Fatom 'static' by default.
993 This makes it easier for human readers (and static analyzers)
994 to see whether these functions can be called from other modules.
995 DEFUN now defines a static function. To make the function external
996 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
997 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
998 (Finit_image_library):
16a97296
PE
999 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1000 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1001 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1002 Remove decls, since these functions are now static.
1003 (Funintern, Fget_internal_run_time): New decls, since these functions
1004 were already external.
95c82688 1005
16a97296
PE
1006 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1007 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1008 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1009 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1010 * keyboard.c, keymap.c, lread.c:
1011 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1012 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1013 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1014 Mark functions with DEFUE instead of DEFUN,
1015 if they are used in other modules.
1016 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1017 decls for now-static functions.
1018 * buffer.h (Fdelete_overlay): Remove decl.
1019 * callproc.c (Fgetenv_internal): Mark as internal.
1020 * composite.c (Fremove_list_of_text_properties): Remove decl.
1021 (Fcomposition_get_gstring): New forward static decl.
1022 * composite.h (Fcomposite_get_gstring): Remove decl.
1023 * dired.c (Ffile_attributes): New forward static decl.
1024 * doc.c (Fdocumntation_property): New forward static decl.
1025 * eval.c (Ffetch_bytecode): New forward static decl.
1026 (Funintern): Remove extern decl; now in .h file where it belongs.
1027 * fileio.c (Fmake_symbolic_link): New forward static decl.
1028 * image.c (Finit_image_library): New forward static decl.
1029 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1030 * intervals.h (Fprevious_property_change):
1031 (Fremove_list_of_text_properties): Remove decls.
1032 * keyboard.c (Fthis_command_keys): Remove decl.
1033 (Fcommand_execute): New forward static decl.
1034 * keymap.c (Flookup_key): New forward static decl.
1035 (Fcopy_keymap): Now static.
1036 * keymap.h (Flookup_key): Remove decl.
1037 * process.c (Fget_process): New forward static decl.
1038 (Fprocess_datagram_address): Mark as internal.
1039 * syntax.c (Fsyntax_table_p): New forward static decl.
1040 (skip_chars): Remove duplicate decl.
1041 * textprop.c (Fprevious_property_change): New forward static decl.
1042 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1043 Now internal.
1044 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1045 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1046
785bbd42
PE
1047 * editfns.c (Fformat): Remove unreachable code.
1048
8b913b57
AS
10492011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1050
1051 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1052 change. (Bug#8496)
1053
a6744a35
EZ
10542011-04-13 Eli Zaretskii <eliz@gnu.org>
1055
1056 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1057 when at ZV. (Bug#8487)
1058
e7974947
AS
10592011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1060
baad03f0
AS
1061 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1062 (Bug#8437)
1063 * keyboard.c (parse_tool_bar_item): Likewise.
1064 * sound.c (sound_cleanup, alsa_close): Likewise.
1065 * termcap.c (tgetent): Likewise.
1066 * xfns.c (x_default_font_parameter): Likewise.
1067 * xsettings.c (read_and_apply_settings): Likewise.
1068
e7974947
AS
1069 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1070 (overrun_check_free): Protoize.
1071
28272684
PE
10722011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1073
1074 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1075 since callers should never pass a negative size.
1076 Change the signature to match that of plain 'read' and 'write'; see
1077 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1078 * lisp.h: Update prototypes of emacs_write and emacs_read.
1079
11997c76
EZ
10802011-04-11 Eli Zaretskii <eliz@gnu.org>
1081
1082 * xdisp.c (redisplay_window): Don't try to determine the character
1083 position of the scroll margin if the window start point w->startp
e896f03c 1084 is outside the buffer's accessible region. (Bug#8468)
11997c76 1085
8a2cbd72
EZ
10862011-04-10 Eli Zaretskii <eliz@gnu.org>
1087
1088 Fix write-region and its subroutines for buffers > 2GB.
1089 * fileio.c (a_write, e_write): Modify declaration of arguments and
1090 local variables to support buffers larger than 2GB.
1091 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1092
1093 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1094 argument, local variables, and return value.
1095
1096 * lisp.h: Update prototypes of emacs_write and emacs_read.
1097
1098 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1099
4073e537 11002011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1101
1ebfdcb6
PE
1102 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1103
b2ded58d
PE
1104 Fix more problems found by GCC 4.6.0's static checks.
1105
7d66342c
PE
1106 * xdisp.c (vmessage): Use a better test for character truncation.
1107
bbf47d44
PE
1108 * charset.c (load_charset_map): <, not <=, for optimization,
1109 and to avoid potential problems with integer overflow.
9248994d 1110 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1111 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1112 * editfns.c (Fformat): Likewise.
1e69125e 1113 * syntax.c (skip_chars): Likewise.
3befa583 1114
e3019616
PE
1115 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1116 This also lets GCC 4.6.0 generate slightly better loop code.
1117
becfa255
PE
1118 * callint.c (Fcall_interactively): <, not <=, for optimization.
1119 (Fcall_interactively): Count the number of arguments produced,
1120 not the number of arguments given. This is simpler and lets GCC
1121 4.6.0 generate slightly better code.
1122
dae0cd48
PE
1123 * ftfont.c: Distingish more carefully between FcChar8 and char.
1124 The previous code passed unsigned char * to a functions like
1125 strlen and xstrcasecmp that expect char *, which does not
1126 conform to the C standard.
1127 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1128 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1129 char * when the C standard requires it.
1130
76032d70
PE
1131 * keyboard.c (read_char): Remove unused var.
1132
eb3f1cc8
PE
1133 * eval.c: Port to Windows vsnprintf (Bug#8435).
1134 Include <limits.h>.
1135 (SIZE_MAX): Define if the headers do not.
1136 (verror): Do not give up if vsnprintf returns a negative count.
1137 Instead, grow the buffer. This ports to Windows vsnprintf, which
1138 does not conform to C99. Problem reported by Eli Zaretskii.
1139 Also, simplify the allocation scheme, by avoiding the need for
1140 calling realloc, and removing the ALLOCATED variable.
1141
70476b54
PE
1142 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1143
12020a9e
PE
1144 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1145 But keep the doprint source code for now, as we might revamp it
1146 and use it again (Bug#8435).
ea6c7ae6
PE
1147 * lisp.h (doprnt): Remove.
1148 * Makefile.in (base_obj): Remove doprnt.o.
1149 * deps.mk (doprnt.o): Remove.
1150
5fdb398c
PE
1151 error: Print 32- and 64-bit integers portably (Bug#8435).
1152 Without this change, on typical 64-bit hosts error ("...%d...", N)
1153 was used to print both 32- and 64-bit integers N, which relied on
1154 undefined behavior.
1155 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1156 New macro.
1157 * lisp.h (error, verror): Mark as printf-like functions.
1158 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1159 Report overflow in size calculations when allocating printf buffer.
1160 Do not truncate output string at its first null byte.
1161 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1162 Truncate the output at a character boundary, since vsnprintf does not
1163 do that.
1164 * charset.c (check_iso_charset_parameter): Convert internal
1165 character to string before calling 'error', since %c now has the
1166 printf meaning.
1167 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1168 overflow when computing char to be passed to 'error'. Do not
1169 pass Lisp_Object to 'error'; pass the integer instead.
1170 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1171 formatted with plain %d.
1172
b189fa66
PE
1173 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1174
bff87ef0
PE
1175 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1176
7e2cac20
PE
1177 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1178
ce4d90b5
PE
1179 * xterm.c (x_catch_errors): Remove duplicate declaration.
1180
266c9547
PE
1181 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1182
79c49ad2
PE
1183 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1184
368f4090
JM
11852011-04-10 Jim Meyering <meyering@redhat.com>
1186
1187 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1188 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1189 return ssize_t not "int", and use size_t as the buffer length.
1190 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1191 * gnutls.h: Update declarations.
1192 * process.c (read_process_output): Use ssize_t, to match.
1193 (send_process): Likewise.
1194
a32d4040
CY
11952011-04-09 Chong Yidong <cyd@stupidchicken.com>
1196
1197 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1198
8546720e 11992011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1200
8546720e
GM
1201 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1202 unsigned char, to match FcChar8 type definition.
aac0c6e3 1203
8546720e
GM
1204 * xterm.c (handle_one_xevent):
1205 * xmenu.c (create_and_show_popup_menu):
1206 * xselect.c (x_decline_selection_request)
1207 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1208
0a2f5c1a 12092011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1210
1211 Fix some uses of `int' instead of EMACS_INT.
1212 * search.c (string_match_1, fast_string_match)
1213 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1214 (scan_buffer, find_next_newline_no_quit)
1215 (find_before_next_newline, search_command, Freplace_match)
1216 (Fmatch_data): Make some `int' variables be EMACS_INT.
1217
1218 * xdisp.c (display_count_lines): 3rd argument and return value now
1219 EMACS_INT. All callers changed.
1220 (pint2hrstr): Last argument is now EMACS_INT.
1221
1222 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1223 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1224 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1225 (decode_coding_utf_16, decode_coding_emacs_mule)
1226 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1227 (decode_coding_ccl, decode_coding_charset)
1228 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1229 (decode_coding_iso_2022, decode_coding_emacs_mule)
1230 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1231 <char_offset, last_offset>: Declare EMACS_INT.
1232 (encode_coding_utf_8, encode_coding_utf_16)
1233 (encode_coding_emacs_mule, encode_invocation_designation)
1234 (encode_designation_at_bol, encode_coding_iso_2022)
1235 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1236 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1237 Declare EMACS_INT.
1238 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1239 (encode_invocation_designation): Last argument P_NCHARS is now
1240 EMACS_INT.
1241 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1242 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1243
1244 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1245 All users changed.
1246
1247 * ccl.c (Fccl_execute_on_string): Declare some variables
1248 EMACS_INT.
1249
8546720e 12502011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1251
1252 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1253
4e19a977
CS
12542011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1255
1256 * process.c (Fformat_network_address): Doc fix.
1257
87302331
R
12582011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1259
1260 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1261
cbb59342
CY
12622011-04-08 Chong Yidong <cyd@stupidchicken.com>
1263
1264 * keyboard.c (read_char): Call Lisp function help-form-show,
1265 instead of using internal_with_output_to_temp_buffer.
1266 (Qhelp_form_show): New var.
e0d38eeb 1267 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1268
1269 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1270
1271 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1272
e67a13ab
CY
12732011-04-06 Chong Yidong <cyd@stupidchicken.com>
1274
1275 * process.c (Flist_processes): Removed to Lisp.
1276 (list_processes_1): Deleted.
1277
973f782d
EZ
12782011-04-06 Eli Zaretskii <eliz@gnu.org>
1279
7c106b1e
EZ
1280 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1281
973f782d
EZ
1282 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1283
41cf7d1a 12842011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1285
ca23cc88
PE
1286 Fix more problems found by GCC 4.6.0's static checks.
1287
f390e2d5
PE
1288 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1289
42eea0d0
PE
1290 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1291
b69769da 1292 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1293
f9541e84
PE
1294 * xdisp.c (vmessage): Mark as a printf-like function.
1295
13841b55
PE
1296 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1297
c136c10f
PE
1298 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1299
5e2d4a30
PE
1300 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1301 printf-like functions.
1302 (tiff_load): Add casts to remove these marks before passing them
1303 to system-supplied API.
1304
583f48b9
PE
1305 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1306
b25d760e
PE
1307 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1308 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1309 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1310 directly, rather than having caller test rule sign. This avoids
1311 some unnecessary tests.
1312 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1313 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1314 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1315
bc7b6697 1316 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1317 (xfont_open): Avoid unnecessary tests.
bc7b6697 1318
27ccc379
PE
1319 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1320
dcd5c89a
PE
1321 * composite.h, composite.c (composition_gstring_put_cache):
1322 Use EMACS_INT, not int, for length.
1323
b13a45c6
PE
1324 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1325 breaking out part of COMPOSITION_DECODE_RULE.
1326 (COMPOSITION_DECODE_RULE): Use it.
1327 * composite.c (get_composition_id): Remove unused local vars,
1328 by using the new macro.
1329
1e792e4d
PE
1330 * textprop.c (set_text_properties_1): Change while to do-while,
1331 since the condition is always true at first.
1332
dc6c6455 1333 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1334 (interval_deletion_adjustment): Return unsigned value.
1335 All uses changed.
dc6c6455 1336
aba7731a
PE
1337 * process.c (list_processes_1, create_pty, read_process_output):
1338 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1339 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1340 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1341 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1342 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1343
fdfc4bf3
PE
1344 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1345
fca8fe46 1346 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1347 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1348
06a0259a 1349 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1350 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1351 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1352
e7b9e80f
PE
1353 * print.c (print_error_message): Avoid int overflow.
1354
56201685
PE
1355 * font.c (font_list_entities): Redo for clarity,
1356 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1357
78834453 1358 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1359 (font_score): Avoid potential overflow in diff calculation.
78834453 1360
0bc0b309 1361 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1362 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1363
e610eaca
PE
1364 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1365
b895abce
PE
1366 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1367 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1368 can always succeed if overflow has undefined behavior.
1369
1f1d9321 1370 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1371 (wordify): Omit three unnecessary tests.
1f1d9321 1372
c59478bc
PE
1373 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1374 All callers changed. This avoids the need for an unused var.
1375
79b73827
PE
1376 * casefiddle.c (casify_region): Remove var that is set but not used.
1377
a4db5dfe
PE
1378 * dired.c (file_name_completion): Remove var that is set but not used.
1379
43aae36e
PE
1380 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1381
2a47c44d 1382 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1383 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1384
a37c69bf
PE
1385 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1386 Check for integer overflow on size calculations.
1387
328ab8e7
PE
1388 * buffer.c (Fprevious_overlay_change): Remove var that is set
1389 but not used.
1390
e5a2a5cb
PE
1391 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1392 Remove vars that are set but not used.
8d84a6eb 1393 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1394 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1395
a60e5f68
PE
1396 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1397
f661cb61 1398 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1399 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1400
f0397f5a
PE
1401 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1402 that are set but not used.
1403
8664db06 1404 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1405 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1406
6abdaa4a
PE
1407 * xselect.c (x_get_local_selection, x_handle_property_notify):
1408 Remove vars that are set but not used.
1409
0ce7538d 1410 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1411 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1412
9ae848fc
PE
1413 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1414 Remove var that is set but not used.
0b918413
PE
1415 (scroll_bar_windows_size): Now size_t, not int.
1416 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1417 Check for overflow.
9ae848fc 1418
a5a62657
PE
1419 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1420 (map_tty_color) [!defined MSDOS]: Likewise.
1421
5c5cdd39
PE
1422 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1423
66ebf983
PE
1424 * coding.c: Remove vars that are set but not used.
1425 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1426 All callers changed.
1427 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1428 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1429 (decode_coding_charset): Remove vars that are set but not used.
1430
1be4d761
PE
1431 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1432 that is set but not used.
1433
47553fa8
PE
1434 * print.c (print_object): Remove var that is set but not used.
1435
1f7196bf 1436 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1437 The gnulib version avoids calling malloc in the usual case,
1438 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1439 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1440 * filelock.c (current_lock_owner): Likewise.
1441 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1442 * sysdep.c: Include allocator.h, careadlinkat.h.
1443 (emacs_no_realloc_allocator): New static constant.
1444 (emacs_readlink): New function.
fdb61804
PE
1445 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1446 ../lib/careadlinkat.h.
d1fdcab7 1447
f84c17c7
SM
14482011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1449
1450 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1451 first non-nil return value).
1452
ef3862ad
JD
14532011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1454
1455 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1456 if not defined (Bug#8403).
1457
376a7006
JB
14582011-04-02 Juanma Barranquero <lekktu@gmail.com>
1459
1460 * xdisp.c (display_count_lines): Remove parameter `start',
1461 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1462 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1463 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1464 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1465 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1466 and thereabouts. All callers changed.
1467 (get_per_char_metric): Remove parameter `f', unused since
1468 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1469
6ca3801d
JM
14702011-04-02 Jim Meyering <meyering@redhat.com>
1471
1472 do not dereference NULL upon failed strdup
1473 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1474 (ns_get_family): Likewise.
1475
d8e2b5ba
JB
14762011-04-02 Juanma Barranquero <lekktu@gmail.com>
1477
1478 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1479
8c74fcbd
JD
14802011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1481
1482 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1483 later (Bug#8403).
1484
7200d79c
SM
14852011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1486
03408648 1487 Add lexical binding.
7200d79c 1488
03408648
SM
1489 * window.c (Ftemp_output_buffer_show): New fun.
1490 (Fsave_window_excursion):
1491 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1492
1493 * lread.c (lisp_file_lexically_bound_p): New function.
1494 (Fload): Bind Qlexical_binding.
1495 (readevalloop): Remove `evalfun' arg.
1496 Bind Qinternal_interpreter_environment.
1497 (Feval_buffer): Bind Qlexical_binding.
1498 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1499 Mark as dynamic.
1500 (syms_of_lread): Declare `lexical-binding'.
1501
1502 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1503
1504 * keyboard.c (eval_dyn): New fun.
1505 (menu_item_eval_property): Use it.
ca105506
SM
1506
1507 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1508
03408648
SM
1509 * fns.c (concat, mapcar1): Accept byte-code-functions.
1510
1511 * eval.c (Fsetq): Handle lexical vars.
1512 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1513 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1514 (FletX, Flet): Obey lexical binding.
1515 (Fcommandp): Handle closures.
1516 (Feval): New `lexical' arg.
1517 (eval_sub): New function extracted from Feval. Use it almost
1518 everywhere where Feval was used. Look up vars in lexical env.
1519 Handle closures.
1520 (Ffunctionp): Move from subr.el.
1521 (Ffuncall): Handle closures.
1522 (apply_lambda): Remove `eval_flags'.
1523 (funcall_lambda): Handle closures and new byte-code-functions.
1524 (Fspecial_variable_p): New function.
1525 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1526 but without exporting it to Lisp.
23aba0ea 1527
23aba0ea 1528 * doc.c (Fdocumentation, store_function_docstring):
03408648 1529 * data.c (Finteractive_form): Handle closures.
23aba0ea 1530
03408648
SM
1531 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1532 interactive spec.
ba83908c 1533
03408648
SM
1534 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1535 byte-codes.
1536 (exec_byte_code): New function extracted from Fbyte_code to handle new
1537 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1538
03408648 1539 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1540
03408648 1541 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1542
e2abce01
JB
15432011-03-31 Juanma Barranquero <lekktu@gmail.com>
1544
1545 * xdisp.c (redisplay_internal): Fix prototype.
1546
63696a73 15472011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1548
63696a73
EZ
1549 * xdisp.c (SCROLL_LIMIT): New macro.
1550 (try_scrolling): Use it when setting scroll_limit. Limit
1551 scrolling to 100 screen lines.
1552 (redisplay_window): Even when falling back on "recentering",
1553 position point in the window according to scroll-conservatively,
1554 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1555
1556 (try_scrolling): When point is above the window, allow searching
1557 as far as scroll_max, or one screenful, to compute vertical
1558 distance from PT to the scroll margin position. This prevents
1559 try_scrolling from unnecessarily failing when
1560 scroll-conservatively is set to a value slightly larger than the
1561 window height. Clean up the case of PT below the margin at bottom
1562 of window: scroll_max can no longer be INT_MAX. When aggressive
1563 scrolling is in use, don't let point enter the opposite scroll
1564 margin as result of the scroll.
1565 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1566 threshold of 100 lines for never-recentering scrolling.
1567
e4cc2dfc
JB
15682011-03-31 Juanma Barranquero <lekktu@gmail.com>
1569
1570 * dispextern.h (move_it_by_lines):
1571 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1572 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1573 (message_log_check_duplicate): Remove parameters `prev_bol' and
1574 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1575 (redisplay_internal): Remove parameter `preserve_echo_area',
1576 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1577
1578 * indent.c (Fvertical_motion):
1579 * window.c (window_scroll_pixel_based, Frecenter):
1580 Don't pass `need_y_p' to `move_it_by_lines'.
1581
1c470562
SM
15822011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1583
44f230aa
SM
1584 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1585 steal a few bits to be more compact.
1586 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1587 Remove unneeded casts.
1588
1c470562
SM
1589 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1590
888adce9
ZK
15912011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1592
1593 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1594 binding" message (bug#7967).
1595
f838ed7b
PE
15962011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1597
77861b95
PE
1598 Fix more problems found by GCC 4.6.0's static checks.
1599
de6dbc14
PE
1600 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1601 Remove unused local var.
1602
f838ed7b
PE
1603 * editfns.c (Fmessage_box): Remove unused local var.
1604
792c7b2b
PE
1605 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1606 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1607 Omit unused local vars.
c499e557 1608 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1609 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1610 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1611 Omit unused local var.
1612
ba0165e1
PE
1613 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1614 Don't assume string length fits in int.
32ad8845 1615 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1616 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1617
3c59b4c9
PE
1618 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1619 instead of alloca (Bug#8344).
1620
a3eed478 1621 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1622 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1623
eb4d412d
PE
1624 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1625
1658b401
PE
1626 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1627 concerns.
1628
1629 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1630
1631 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1632
9a2c6e05
PE
1633 * keyboard.c (syms_of_keyboard): Use the same style as later
1634 in this function when indexing through an array. This also
1635 works around GCC bug 48267.
1636
03d0a109
PE
1637 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1638
44f730c8
PE
1639 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1640
fe75f926
PE
1641 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1642 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1643
ffa8c828
PE
1644 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1645 This avoids undefined behavior on integer overflow, and is a bit
1646 more convenient anyway since it is compared to a size_t variable.
1647
c5101a77
PE
1648 Variadic C functions now count arguments with size_t, not int.
1649 This avoids an unnecessary limitation on 64-bit machines, which
1650 caused (substring ...) to crash on large vectors (Bug#8344).
1651 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1652 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1653 All variadic functions and their callers changed accordingly.
c5101a77
PE
1654 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1655 * data.c (arith_driver, float_arith_driver): Likewise.
1656 * editfns.c (general_insert_function): Likewise.
1657 * eval.c (struct backtrace.nargs, interactive_p)
1658 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1659 (funcall_lambda, mark_backtrace): Likewise.
1660 * fns.c (concat): Likewise.
1661 * frame.c (x_set_frame_parameters): Likewise.
1662 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1663 0 if not found, not -1. All callers changed.
1664
dd3f25f7
PE
1665 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1666 (stack_copy_size): Now size_t, not int.
1667 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1668
461c2ab9
JB
16692011-03-28 Juanma Barranquero <lekktu@gmail.com>
1670
1671 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1672 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1673 All callers changed.
1674
1675 * lisp.h (multibyte_char_to_unibyte):
1676 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1677 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1678 * character.h (CHAR_TO_BYTE8):
1679 * cmds.c (internal_self_insert):
1680 * editfns.c (general_insert_function):
1681 * keymap.c (push_key_description):
1682 * search.c (Freplace_match):
1683 * xdisp.c (message_dolog, set_message_1): All callers changed.
1684
f6d62986
SM
16852011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1686
1687 * keyboard.c (safe_run_hook_funcall): New function.
1688 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1689 don't set the hook to nil, but remove the offending function instead.
1690 (Qcommand_hook_internal): Remove, unused.
1691 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1692 Vcommand_hook_internal.
1693
1694 * eval.c (enum run_hooks_condition): Remove.
1695 (funcall_nil, funcall_not): New functions.
1696 (run_hook_with_args): Call each function through a `funcall' argument.
1697 Remove `cond' argument, now redundant.
1698 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1699 (Frun_hook_with_args_until_failure): Adjust accordingly.
1700 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1701
1db5b1ad
JB
17022011-03-28 Juanma Barranquero <lekktu@gmail.com>
1703
1704 * dispextern.h (string_buffer_position): Remove declaration.
1705
1706 * print.c (strout): Remove parameter `multibyte', unused since
1707 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1708
1709 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1710 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1711 All callers changed.
1712
1713 * w32.c (_wsa_errlist): Use braces for struct initializers.
1714
1715 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1716 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1717 All callers changed.
1718 (string_buffer_position): Likewise. Also, make static (it's never
1719 used outside xdisp.c).
1720 (cursor_row_p): Remove parameter `w', unused since
1721 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1722 (decode_mode_spec): Remove parameter `precision', introduced during
1723 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1724 All callers changed.
1725
5ffb62aa
JD
17262011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1727
1728 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1729
461c2ab9 17302011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1731
1732 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1733 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1734 (ns_update_auto_hide_menu_bar): New functions.
1735 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1736 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1737 ns_constrain_all_frames.
1738 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1739 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1740
5c380ffb
JD
17412011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1742
1743 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1744
9af30bdf
GM
17452011-03-27 Glenn Morris <rgm@gnu.org>
1746
1747 * syssignal.h: Replace RETSIGTYPE with void.
1748 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1749 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1750 Replace SIGTYPE with void everywhere.
1751 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1752 * s/template.h (SIGTYPE): Remove commented out definition.
1753
e2abce01
JB
17542011-03-26 Eli Zaretskii <eliz@gnu.org>
1755
1756 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1757 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1758
f868cd8a
JB
17592011-03-26 Juanma Barranquero <lekktu@gmail.com>
1760
59eb0929
JB
1761 * w32.c (read_unc_volume): Use parameter `henum', instead of
1762 global variable `wget_enum_handle'.
1763
1764 * keymap.c (describe_vector): Remove parameters `indices' and
1765 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1766 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1767
f868cd8a
JB
1768 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1769
1770 * keyboard.c (timer_check): Remove parameter `do_it_now',
1771 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1772 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1773 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1774
1775 * keyboard.c (read_char):
1776 * w32menu.c (w32_menu_display_help):
1777 * xmenu.c (show_help_event, menu_help_callback):
1778 Adjust calls to `show_help_echo'.
1779
1780 * gtkutil.c (xg_maybe_add_timer):
1781 * keyboard.c (readable_events):
1782 * process.c (wait_reading_process_output):
1783 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1784
1785 * insdel.c (adjust_markers_gap_motion):
1786 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1787 (gap_left, gap_right): Don't call it.
1788
2ecf6fdb
CY
17892011-03-25 Chong Yidong <cyd@stupidchicken.com>
1790
1791 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1792 incurred during fontification.
1793
6b1f9ba4
JB
17942011-03-25 Juanma Barranquero <lekktu@gmail.com>
1795
1796 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1797 (DEFVAR_PER_BUFFER): Don't pass it.
1798
1799 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1800 (scrolling_window): Don't pass it.
1801
0f4a96b5
JB
18022011-03-25 Juanma Barranquero <lekktu@gmail.com>
1803
1804 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1805
1806 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1807 and `suffix'.
1808 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1809 of variables specific to SELinux and computation of `encoded_absname'.
1810
1811 * image.c (XPutPixel): Remove unused variable `height'.
1812
1813 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1814
1815 * unexw32.c (get_section_info): Remove unused variable `section'.
1816
1817 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1818 (system_process_attributes): Remove unused variable `sess'.
1819 (sys_read): Remove unused variable `err'.
1820
1821 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1822 (w32_wnd_proc): Remove unused variable `isdead'.
1823 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1824 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1825 (x_create_tip_frame): Remove unused variable `tem'.
1826
1827 * w32inevt.c (w32_console_read_socket):
1828 Remove unused variable `no_events'.
1829
1830 * w32term.c (x_draw_composite_glyph_string_foreground):
1831 Remove unused variable `width'.
1832
1149507c
JB
18332011-03-24 Juanma Barranquero <lekktu@gmail.com>
1834
1835 * w32term.c (x_set_glyph_string_clipping):
1836 Don't pass uninitialized region to CombineRgn.
1837
9c88f339
JB
18382011-03-23 Juanma Barranquero <lekktu@gmail.com>
1839
1840 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1841 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1842 (Fx_close_connection): Remove unused variable `i'.
1843
1844 * w32font.c (w32font_draw): Return number of glyphs.
1845 (w32font_open_internal): Remove unused variable `i'.
1846 (w32font_driver): Add missing initializer.
1847
1848 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1849 (fill_in_menu): Remove unused variable `items_added'.
1850
1851 * w32term.c (last_mouse_press_frame): Remove static global variable.
1852 (w32_clip_to_row): Remove unused variable `f'.
1853 (x_delete_terminal): Remove unused variable `i'.
1854
1855 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1856 (NOTHING): Remove unused static global variable.
1857 (uniscribe_check_otf): Remove unused variable `table'.
1858 (uniscribe_font_driver): Add missing initializers.
1859
dee091a3
JD
18602011-03-23 Julien Danjou <julien@danjou.info>
1861
1862 * term.c (Fsuspend_tty, Fresume_tty):
1863 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1864 * window.c (temp_output_buffer_show):
1865 * insdel.c (signal_before_change):
1866 * frame.c (Fhandle_switch_frame):
1867 * fileio.c (Fdo_auto_save):
1868 * emacs.c (Fkill_emacs):
1869 * editfns.c (save_excursion_restore):
1870 * cmds.c (internal_self_insert):
1871 * callint.c (Fcall_interactively):
1872 * buffer.c (Fkill_all_local_variables):
1873 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1874 Use Frun_hooks.
0f4a96b5 1875 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1876 unconditionnaly since it does the check itself.
1877
2c520ab5 18782011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1879
c9c49752
PE
1880 Fix more problems found by GCC 4.5.2's static checks.
1881
8abc3f12
PE
1882 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1883 the first time through the loop, since we know p0 < p1 then.
1884 This also avoids a gcc -Wstrict-overflow warning.
1885
a2d26660
PE
1886 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1887 leading to a memory leak, possible in functions like
1888 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1889 of objects (Bug#8318).
a2d26660 1890
916c72e9
PE
1891 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1892 that could (at least in theory) be that large.
1893
19ab8a18
PE
1894 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1895 This is less likely to overflow, and avoids undefined behavior if
1896 overflow does occur. All callers changed. Use strtoul to scan
1897 for the unsigned long integer.
b7cbbd6f
PE
1898 (pint2hrstr): Simplify and tune code slightly.
1899 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1900
f0641eff
PE
1901 * scroll.c (do_scrolling): Work around GCC bug 48228.
1902 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1903
7f650bb9
PE
1904 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1905 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1906 (validate_x_resource_name): Simplify count usage.
1907 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1908
37dd57d1
PE
1909 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1910 fail (Bug#8306).
81e56e61 1911
699979fc 1912 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1913
401bf9b4
PE
1914 * process.c (Fmake_network_process): Use socklen_t, not int,
1915 where POSIX says socklen_t is required in portable programs.
1916 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1917 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1918 (Fmake_network_process, server_accept_connection):
1919 (wait_reading_process_output, read_process_output):
1920 Likewise.
1921
b93aacde
PE
1922 * process.c: Rename or move locals to avoid shadowing.
1923 (list_processes_1, Fmake_network_process):
1924 (read_process_output_error_handler, exec_sentinel_error_handler):
1925 Rename or move locals.
4dc343ee 1926 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1927 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1928 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1929 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1930 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1931
af8a867c 1932 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1933 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1934 Include tparam.h instead, since it declares them.
af8a867c
PE
1935 * cm.h (PC): Remove extern decl; tparam.h now does this.
1936 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1937 * terminfo.c: Include tparam.h, to check interfaces.
1938 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1939 (tparam): Adjust signature to match interface in tparam.h;
1940 this removes some undefined behavior. Check that outstring and len
1941 are zero, which they always are with Emacs.
1942 * tparam.h (PC, BC, UP): New extern decls.
1943
0248044d 1944 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1945 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1946
8ff096c1 1947 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1948 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1949 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1950 (ftfont_list): Remove unused local.
49eaafba
PE
1951 (get_adstyle_property, ftfont_pattern_entity):
1952 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1953 Rename locals to avoid shadowing.
8ff096c1 1954
e2be39f6
PE
1955 * xfont.c (xfont_list_family): Mark var as initialized.
1956
c9735e30
PE
1957 * xml.c (make_dom): Now static.
1958
8f5201ae
PE
1959 * composite.c (composition_compute_stop_pos): Rename local to
1960 avoid shadowing.
b246f932
PE
1961 (composition_reseat_it): Remove unused locals.
1962 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1963 (composition_update_it): Mark var as initialized.
11b61122
PE
1964 (find_automatic_composition): Mark vars as initialized,
1965 with a FIXME (Bug#8290).
8f5201ae 1966
760fbc2c
PE
1967 character.h: Rename locals to avoid shadowing.
1968 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1969 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1970 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1971 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1972 to avoid shadowing.
1973
ff08eb85
PE
1974 * textprop.c (property_change_between_p): Remove; unused.
1975
fc7bf025
PE
1976 * intervals.c (interval_start_pos): Now static.
1977
235d7abc
PE
1978 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1979
44f230aa
SM
1980 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1981 Rename locals to avoid shadowing.
3e7d6594 1982
50060332
PE
1983 * sound.c (wav_play, au_play, Fplay_sound_internal):
1984 Fix pointer signedness.
d01f234b 1985 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1986 (wav_play): Initialize a variable to 0, to prevent undefined
1987 behavior (Bug#8278).
50060332 1988
c4fc4e30
PE
1989 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1990
918436ed
PE
1991 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1992
c939f91b
PE
1993 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1994 clobbering (Bug#8298).
b9c7f648
PE
1995 * sysdep.c (sys_subshell): Likewise.
1996 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1997
6bd8c144
PE
1998 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1999 This should get cleaned up, so that child_setup has the
2000 same signature on all platforms.
2001
7710357c 2002 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2003 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2004
c59da222
CY
20052011-03-22 Chong Yidong <cyd@stupidchicken.com>
2006
2007 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2008 not to be necessary, and produces flickering.
2009
66b87493
GM
20102011-03-20 Glenn Morris <rgm@gnu.org>
2011
2012 * config.in: Remove file.
2013
45b6f6d5
JB
20142011-03-20 Juanma Barranquero <lekktu@gmail.com>
2015
2016 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2017 are now in src/globals.h.
2018 (syms_of_minibuf): Remove spurious & from previous change.
2019
3ec03f7e
LL
20202011-03-20 Leo <sdl.web@gmail.com>
2021
2022 * minibuf.c (completing-read-function): New variable.
2023 (completing-read-default): Rename from completing-read.
2024 (completing-read): Call completing-read-function.
2025
b14e3e21
CY
20262011-03-19 Juanma Barranquero <lekktu@gmail.com>
2027
2028 * xfaces.c (Fx_load_color_file):
2029 Read color file from absolute filename (bug#8250).
2030
f2b726e6
JB
20312011-03-19 Juanma Barranquero <lekktu@gmail.com>
2032
2033 * makefile.w32-in: Update dependencies.
2034
09f6ff02
EZ
20352011-03-17 Eli Zaretskii <eliz@gnu.org>
2036
2037 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2038
29a6015a
PE
20392011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2040
a3a6c54e
PE
2041 Fix more problems found by GCC 4.5.2's static checks.
2042
b766f867
PE
2043 * process.c (make_serial_process_unwind, send_process_trap):
2044 (sigchld_handler): Now static.
2045
be02381c
PE
2046 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2047 That way, the code declares only the vars that it needs.
2048 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2049 * s/cygwin.h (PTY_ITERATION): Likewise.
2050 * s/darwin.h (PTY_ITERATION): Likewise.
2051 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2052
57048744
PE
2053 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2054 * process.c (allocate_pty): Don't declare stb unless it's needed.
2055
7914961c 2056 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2057 (CONSTANTLIM): Remove; unused.
2058 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2059 Define only if needed.
7914961c 2060
b3967b18
PE
2061 * unexelf.c (unexec): Name an expression,
2062 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2063 Use a different way to cause a compilation error if anyone uses
2064 n rather than nn, a way that does not involve shadowing.
73366a00 2065 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2066
29a6015a
PE
2067 * deps.mk (unexalpha.o): Remove; unused.
2068
43cfc33e 2069 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2070 * unexec.h: New file.
ce701a33
PE
2071 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2072 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2073 Depend on unexec.h.
2074 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2075 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2076 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2077 Change as necessary to match prototype in unexec.h.
ce701a33 2078
01f44d5a
PE
2079 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2080 shadowing.
4f63c6bb 2081 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2082
a6670b0b
PE
2083 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2084 Rename locals to avoid shadowing.
2085
cef2010d 2086 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2087 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2088
d4d7173a
PE
2089 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2090
f08b802a
PE
2091 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2092 warning when compiling print.c.
2093
3ddb0639
PE
2094 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2095 instead of using an uninitialized var.
5ad03b97 2096 (font_sort_entities): Mark var as initialized.
3ddb0639 2097
170a2692
PE
2098 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2099
e663c700
PE
2100 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2101 pointers to constants.
89bc529a 2102 (font_parse_fcname): Remove unused vars.
7b81e2d0 2103 (font_delete_unmatched): Now static.
ea838e10 2104 (font_get_spec): Remove; unused.
13a547c6
PE
2105 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2106 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2107 Rename or move locals to avoid shadowing.
e663c700 2108
2a80c887 2109 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2110 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2111
1384fa33 2112 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2113 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2114
8b2c52e9
PE
2115 * alloc.c (mark_backtrace): Move decl from here ...
2116 * lisp.h: ... to here, so that it can be checked.
2117
475545b5 2118 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2119 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2120 (lisp_indirect_variable): Name an expression,
2121 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2122 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2123
b1349114 2124 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2125 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2126 Use const pointer when appropriate.
b1349114 2127
a2928364
PE
2128 * lisp.h (get_system_name, get_operating_system_release):
2129 Move decls here, to check interfaces.
2130 * process.c (get_operating_system_release): Move decl to lisp.h.
2131 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2132 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2133 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2134 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2135 (Fformat_time_string, Fencode_time, Finsert_char):
2136 (Ftranslate_region_internal, Fformat):
2137 Rename or remove local vars to avoid shadowing.
9710023e 2138 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2139
a415e694
PE
2140 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2141 avoid shadowing.
2142
8ef4622d
PE
2143 * lisp.h (eassert): Check that the argument compiles, even if
2144 ENABLE_CHECKING is not defined.
2145
946f9a5b
PE
2146 * data.c (Findirect_variable): Name an expression, to avoid
2147 gcc -Wbad-function-cast warning.
112396d6 2148 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2149 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2150 (Fmake_variable_buffer_local, Fmake_local_variable):
2151 Mark variables as initialized.
52746918 2152 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2153
e5aab7e7 2154 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2155 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2156 Rename locals to avoid shadowing.
dff45157
PE
2157 (mark_stack): Move local variables into the #ifdef region where
2158 they're used.
7bc26fdb
PE
2159 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2160 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2161 needed otherwise.
2162 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2163 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2164 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2165
e5aab7e7
PE
2166 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2167 avoids undefined behavior in theory.
2168
4da60324
PE
2169 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2170
88043301
PE
2171 Use functions, not macros, for up- and down-casing (Bug#8254).
2172 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2173 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2174 to use the following functions instead of these macros.
2175 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2176 EMACS_INT, since callers assume the returned value fits in int.
2177 (upcase1): Likewise, for UPCASE_TABLE.
2178 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2179 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2180 the race-condition problem in the old DOWNCASE.
88043301 2181
19ed5445
PE
2182 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2183 Rename locals to avoid shadowing.
2184 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2185 (regex_compile, re_search_2, re_match_2_internal):
2186 Remove unused local vars.
952db0d7
PE
2187 (FREE_VAR): Rewrite so as not to use empty "else",
2188 which gcc can warn about.
da053e48 2189 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2190 (RETALLOC_IF): Define only if needed.
2191 (WORDCHAR_P): Likewise. This one is never needed, but is used
2192 only in a comment talking about a compiler bug, so put inside
2193 the #if 0 of that comment.
2194 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2195 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2196 Remove; unused.
19ed5445 2197
1f3561e4 2198 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2199 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2200 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2201
ded6f8f7
PE
2202 * search.c (simple_search): Remove unused var.
2203
dbd37a95
PE
2204 * dired.c (compile_pattern): Move decl from here ...
2205 * lisp.h: ... to here, so that it can be checked.
2206 (struct re_registers): New forward decl.
2207
7e47afad
PE
2208 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2209
85f24f61
PE
2210 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2211 All uses changed.
2212 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2213 Rename locals to avoid shadowing.
5671df8f 2214 (Fvertical_motion): Mark locals as initialized.
85f24f61 2215
181aa2be 2216 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2217 (casify_region): Mark local as initialized.
181aa2be 2218
930d429c
PE
2219 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2220
7082eac6
PE
2221 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2222 New macros, so that the caller can use some names other than
2223 gcpro1, gcpro2, etc.
2224 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2225 of the new macros.
2226 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2227 argument, for consistency with GCPRO2_VAR, etc: it is now the
2228 prefix of the variable, not the variable itself. All uses
2229 changed.
38b2c076
PE
2230 * dired.c (directory_files_internal, file_name_completion):
2231 Rename locals to avoid shadowing.
2232
15206ed9
PE
2233 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2234 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2235 dired.c's scmp function, had undefined behavior.
2236 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2237 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2238 * buffer.h: ... to here, because these macros use current_buffer,
2239 and the new implementation with inline functions needs to have
2240 current_buffer in scope now, rather than later when the macros
2241 are used.
2242 (downcase, upcase1): New static inline functions.
2243 (DOWNCASE, UPCASE1): Reimplement using these functions.
2244 This avoids undefined behavior in expressions like
2245 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2246 from race conditions in accessing the global variables
2247 case_temp1 and case_temp2.
2248 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2249 * lisp.h (case_temp1, case_temp2): Remove their decls.
2250 * character.h (ASCII_CHAR_P): Move from here ...
2251 * lisp.h: ... to here, so that the inline functions mentioned
2252 above can use them.
2253
4a6bea26
PE
2254 * dired.c (directory_files_internal_unwind): Now static.
2255
f14b7e14
PE
2256 * fileio.c (file_name_as_directory, directory_file_name):
2257 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2258 Now static.
2893f146
PE
2259 (file_name_as_directory): Use const pointers when appropriate.
2260 (Fexpand_file_name): Likewise. In particular, newdir might
2261 point at constant storage, so make it a const pointer.
fd4ead52 2262 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2263 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2264 signedness issues.
f839df0c
PE
2265 (Fset_file_times, Finsert_file_contents, auto_save_error):
2266 Rename locals to avoid shadowing.
f14b7e14 2267
5716756e 2268 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2269 (Ftry_completion, Fall_completions): Rename or remove locals
2270 to avoid shadowing.
5716756e 2271
b4c3046a
PE
2272 * marker.c (bytepos_to_charpos): Remove; unused.
2273
b45db522
PE
2274 * lisp.h (verify_bytepos, count_markers): New decls,
2275 so that gcc does not warn that these functions aren't declared.
2276
85876d07
PE
2277 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2278 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2279 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2280 (copy_text): Remove unused local var.
85876d07 2281
03d78a21 2282 * filelock.c (within_one_second): Now static.
b3dd38ab 2283 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2284
5df8f01b
PE
2285 * buffer.c (fix_overlays_before): Mark locals as initialized.
2286 (fix_start_end_in_overlays): Likewise. This function should be
2287 simplified by using pointers-to-pointers, but that's a different
2288 matter.
b1d876f1 2289 (switch_to_buffer_1): Now static.
8f54f30a
PE
2290 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2291 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2292
a70072c9 2293 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2294 Fix pointer signedness issue.
edced198
PE
2295 (sys_subshell): Mark local as volatile if checking for lint,
2296 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2297 (MAXPATHLEN): Define only if needed.
a70072c9 2298
a0977c44
PE
2299 * process.c (serial_open, serial_configure): Move decls from here ...
2300 * systty.h: ... to here, so that they can be checked.
2301
a884fdcc
PE
2302 * fns.c (get_random, seed_random): Move extern decls from here ...
2303 * lisp.h: ... to here, so that they can be checked.
2304
604efe86 2305 * sysdep.c (reset_io): Now static.
b8950c94 2306 (wait_for_termination_signal): Remove; unused.
604efe86 2307
38fc62d9
PE
2308 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2309 (copy_keymap_item, append_key, push_text_char_description):
2310 Now static.
1004a21a 2311 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2312 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2313 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2314 (describe_map_tree):
2315 Rename locals to avoid shadowing.
38fc62d9 2316
2f2650da
PE
2317 * keyboard.c: Declare functions static if they are not used elsewhere.
2318 (echo_char, echo_dash, cmd_error, top_level_2):
2319 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2320 (read_char, kbd_buffer_get_event, make_lispy_position):
2321 (make_lispy_event, make_lispy_movement, apply_modifiers):
2322 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2323 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2324 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2325 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2326 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2327
a053e86c 2328 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2329 (mark_kboards): Move decl here ...
2330 * alloc.c (mark_kboards): ... from here.
a053e86c 2331
4752793e
PE
2332 * lisp.h (force_auto_save_soon): New decl.
2333
74f10ca7 2334 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2335 (DEFINE_DUMMY_FUNCTION): New macro.
2336 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2337 Use it.
c03cd23f
PE
2338 (main): Add casts to avoid warnings
2339 if GCC considers string literals to be constants.
74f10ca7 2340
022e70d4
PE
2341 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2342
59d6fe83
PE
2343 * dbusbind.c: Pointer signedness fixes.
2344 (xd_signature, xd_append_arg, xd_initialize):
2345 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2346 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2347 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2348 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2349
78320123
PE
2350 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2351 if GCC considers string literals to be constants.
49cebcca 2352 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2353
35ac2a97
SM
23542011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2355
fb103ca9
SM
2356 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2357 (print_preprocess, print_object): New macro to fix last change.
2358
35ac2a97
SM
2359 * print.c (print_preprocess): Don't forget font objects.
2360
62973b41
JB
23612011-03-16 Juanma Barranquero <lekktu@gmail.com>
2362
2363 * emacs.c (USAGE3): Doc fixes.
2364
0e48bb22
AS
23652011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2366
2367 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2368 structure.
2369
7684e57b
JB
23702011-03-14 Juanma Barranquero <lekktu@gmail.com>
2371
2372 * lisp.h (VWindow_system, Qfile_name_history):
2373 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2374 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2375 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2376
2377 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2378 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2379
2380 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2381 * w32console.c (detect_input_pending, read_input_pending)
2382 (encode_terminal_code):
2383 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2384 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2385 (w32_system_caret_y, Qfile_name_history):
2386 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2387 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2388 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2389 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2390 * w32proc.c (Qlocal, report_file_error):
2391 * w32term.c (Vwindow_system, updating_frame):
2392 * w32uniscribe.c (initialized, uniscribe_font_driver):
2393 Remove unneeded extern declarations.
2394
2aa46d6c
CY
23952011-03-14 Chong Yidong <cyd@stupidchicken.com>
2396
c96bbc66 2397 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2398
cffc6f3b
CY
23992011-03-13 Chong Yidong <cyd@stupidchicken.com>
2400
2401 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2402 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2403 These macros can no longer be used for assignment.
2404
44f230aa
SM
2405 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2406 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2407 (record_buffer_markers, fetch_buffer_markers): New functions for
2408 recording and fetching special buffer markers.
2409 (set_buffer_internal_1, set_buffer_temp): Use them.
2410
2411 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2412
2413 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2414
2415 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2416 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2417
2418 * xdisp.c (hscroll_window_tree):
2419 (reconsider_clip_changes): Use PT instead of BUF_PT.
2420
d251f04b
EZ
24212011-03-13 Eli Zaretskii <eliz@gnu.org>
2422
2423 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2424 $(EMACS_ROOT)/lib/intprops.h.
2425
f0c77cd1
PE
24262011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2427
3eca4629
PE
2428 Fix more problems found by GCC 4.5.2's static checks.
2429
7c86ee98
PE
2430 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2431 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2432 (xg_free_frame_widgets): Make it clear that a local variable is
2433 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2434 (gdk_window_get_screen): Make it clear that this macro is needed
2435 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2436 (int_gtk_range_get_value): New function, which avoids a diagnostic
2437 from gcc -Wbad-function-cast.
2438 (xg_set_toolkit_scroll_bar_thumb): Use it.
2439 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2440 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2441 (get_utf8_string, xg_get_file_with_chooser):
2442 Rename locals to avoid shadowing.
2443 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2444
41729b81
PE
2445 * xgselect.c (xg_select): Remove unused var.
2446
f0c77cd1
PE
2447 * image.c (four_corners_best): Mark locals as initialized.
2448 (gif_load): Initialize transparent_p to zero (Bug#8238).
2449 Mark another local as initialized.
ec6cf4c6 2450 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2451
ce0ad53d 2452 * image.c (clear_image_cache): Now static.
d5d5a617 2453 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2454 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2455 (x_edge_detection): Remove unnecessary cast that
2456 gcc -Wbad-function-cast diagnoses.
2037898d 2457 (gif_load): Fix pointer signedness.
6ae141d6
PE
2458 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2459 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2460
33383987 24612011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2462
d32df629
PE
2463 Improve quality of tests for time stamp overflow.
2464 For example, without this patch (encode-time 0 0 0 1 1
2465 1152921504606846976) returns the obviously-bogus value (-948597
2466 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2467 reports time overflow. See
2468 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2469 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2470 * editfns.c: Include limits.h and intprops.h.
2471 (TIME_T_MIN, TIME_T_MAX): New macros.
2472 (time_overflow): Move earlier, to before first use.
2473 (hi_time, lo_time): New functions, for an accurate test for
2474 out-of-range times.
2475 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2476 (Fget_internal_run_time): Don't assume time_t fits in int.
2477 (make_time): Use list2 instead of Fcons twice.
2478 (Fdecode_time): More accurate test for out-of-range times.
2479 (check_tm_member): New function.
2480 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2481 (lisp_time_argument): Don't rely on undefined left-shift and
2482 right-shift behavior when checking for time stamp overflow.
8be6f318 2483
fe31d94c
PE
2484 * editfns.c (time_overflow): New function, refactoring common code.
2485 (Fformat_time_string, Fdecode_time, Fencode_time):
2486 (Fcurrent_time_string): Use it.
2487
8be6f318
PE
2488 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2489 * dired.c (make_time): Move to ...
2490 * editfns.c (make_time): ... here.
2491 * systime.h: Note the move.
2492
09d9db2c 24932011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2494
126bc0dc
YM
2495 * fringe.c (update_window_fringes): Remove unused variables.
2496
c47cbdfd
YM
2497 * unexmacosx.c (copy_data_segment): Also copy __got section.
2498 (Bug#8223)
2499
7ac80be9
EZ
25002011-03-12 Eli Zaretskii <eliz@gnu.org>
2501
c96bbc66 2502 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2503 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2504 Constify `char *' arguments and their references according to
2505 prototypes in tparam.h.
2506
ecb0f94d 2507 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2508
7ac80be9
EZ
2509 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2510 Adapt all references accordingly.
2511
2512 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2513
ef1fd07e
TT
25142011-03-11 Tom Tromey <tromey@redhat.com>
2515
2516 * buffer.c (syms_of_buffer): Remove obsolete comment.
2517
7ef4b50c
EZ
25182011-03-11 Eli Zaretskii <eliz@gnu.org>
2519
2520 * termhooks.h (encode_terminal_code): Declare prototype.
2521
2522 * msdos.c (encode_terminal_code): Don't declare prototype.
2523
2524 * term.c (encode_terminal_code): Now external again, used by
2525 w32console.c and msdos.c.
2526
44f230aa
SM
2527 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2528 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2529
4b1ec863 25302011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2531
1714f52b 2532 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2533
4b1ec863
PE
2534 * fringe.c (update_window_fringes): Mark locals as initialized
2535 (Bug#8227).
2536 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2537
524c7aa6
PE
2538 * alloc.c (mark_fringe_data): Move decl from here ...
2539 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2540 to check its interface.
2541 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2542
a5c0af81 2543 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2544 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2545 (fontset_font): Mark local as initialized.
a9a06e0b 2546 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2547
b4716021
PE
2548 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2549
811e9bac 2550 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2551 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2552 (x_own_selection, Fx_disown_selection_internal): Rename locals
2553 to avoid shadowing.
2554 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2555
7e3ab302
PE
2556 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2557 so that the caller can use some name other than gcpro1.
2558 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2559 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2560 (Fx_backspace_delete_keys_p):
2561 Use them to avoid shadowing, and rename vars to avoid shadowing.
2562 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2563 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2564 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2565 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2566 Remove unused locals.
7e3ab302
PE
2567 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2568 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2569 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2570 macros.
f78faa98 2571
e2b13473
PE
2572 * xterm.h (x_mouse_leave): New decl.
2573
77f23912
PE
2574 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2575 Remove unused functions.
cdf4ba58
PE
2576 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2577 (x_calc_absolute_position): Now static.
7411c686 2578 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2579 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2580 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2581 unless they are used.
38d0b34a
PE
2582 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2583 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2584 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2585 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2586 (x_error_catcher, x_connection_closed, x_error_handler):
2587 (x_error_quitter, xembed_send_message, x_iconify_frame):
2588 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2589 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2590 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2591
44f230aa
SM
2592 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2593 Rename or move locals to avoid shadowing.
6b463e58 2594 (tty_defined_color, merge_face_heights): Now static.
5967d051 2595 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2596 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2597 does not deduce is never used uninitialized.
73719eba
PE
2598 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2599 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2600
426994c3 2601 * terminal.c (store_terminal_param): Now static.
5489860b 2602
032f1620 2603 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2604 (set_frame_menubar): Remove unused local.
d4323972 2605 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2606 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2607 since they might point to immutable storage.
281585b0
PE
2608 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2609 since it's unused otherwise.
032f1620 2610
367c19e5 2611 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2612 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2613 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2614 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2615 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2616 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2617 does not deduce are never used uninitialized.
70739cbe 2618
07b48fa9
PE
2619 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2620
8868a238 2621 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2622 * window.c (window_loop, size_window):
2623 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2624
7e5cf297 2625 * window.c (display_buffer): Now static.
d6550a9f
PE
2626 (size_window): Mark variables that gcc -Wuninitialized
2627 does not deduce are never used uninitialized.
a586633d
PE
2628 * window.h (check_all_windows): New decl, to forestall
2629 gcc -Wmissing-prototypes diagnostic.
5b555da1 2630 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2631
f6095868
PE
2632 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2633 shadowing.
2634 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2635 Include <limits.h>.
2636 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2637 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2638 (load_charset_map): Mark variables that gcc -Wuninitialized
2639 does not deduce are never used uninitialized.
53df7c11 2640 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2641
f38b440c
PE
2642 * coding.c (coding_set_source, coding_set_destination):
2643 Use "else { /* comment */ }" rather than "else /* comment */;"
2644 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2645 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2646 a block, when the outer 'i' will do.
2647 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2648 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2649 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2650 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2651 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2652 Rename locals to avoid shadowing.
2653 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2654 * coding.c (emacs_mule_char, encode_invocation_designation):
2655 Now static, since they're not used elsewhere.
413bb2db 2656 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2657 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2658 (decode_coding_emacs_mule): Mark variables that gcc
2659 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2660 (detect_coding_iso_2022): Initialize a local variable that might
2661 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2662 this initialization is needed. (Bug#8211)
5f58e762
PE
2663 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2664 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2665 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2666 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2667 Remove unused macros.
f38b440c 2668
232b38b9 2669 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2670 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2671 * character.c (string_count_byte8): Likewise.
232b38b9 2672
fb90da1b
PE
2673 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2674 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2675
fb93dbc2
PE
2676 * chartab.c (copy_sub_char_table): Now static, since it's not used
2677 elsewhere.
5c156ace
PE
2678 (sub_char_table_ref_and_range, char_table_ref_and_range):
2679 Rename locals to avoid shadowing.
bbcd0949 2680 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2681
7d3b3862 2682 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2683 (BIDI_BOB): Remove unused macro.
7d3b3862 2684
6be7d3da
PE
2685 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2686 deduce are never used uninitialized.
c2ed9c8b 2687 * term.c (encode_terminal_code): Likewise.
6be7d3da 2688
75f8807f 2689 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2690
50938595
PE
2691 * tparam.h: New file.
2692 * term.c, tparam.h: Include it.
2693 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2694 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2695 Move these decls to tparam.h, and make them agree with what
2696 is actually in tparam.c. The previous trick of using incompatible
2697 decls in different modules does not conform to the C standard.
2698 All callers of tparam changed to use tparam's actual API.
2699 * tparam.c (tparam1, tparam, tgoto):
2700 Use const pointers where appropriate.
2701
fbceeba2
PE
2702 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2703 * cm.h (struct cm): Likewise.
2704 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2705 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2706 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2707 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2708 (turn_on_face, init_tty): Likewise.
2709 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2710
7f3f1250
PE
2711 * term.c (term_mouse_position): Rename local to avoid shadowing.
2712
e6ca6543
PE
2713 * alloc.c (mark_ttys): Move decl from here ...
2714 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2715
c40f8d15
AS
27162011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2717
2718 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2719
cfe0661d
JB
27202011-03-09 Juanma Barranquero <lekktu@gmail.com>
2721
2722 * search.c (compile_pattern_1): Remove argument regp, unused since
2723 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2724 (compile_pattern): Don't pass it.
2725
0afb4571
J
27262011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2727
2728 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2729 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2730 for ! HAVE_GTK3.
2731 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2732
2733 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2734
2735 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2736 gdk_window_get_screen, gdk_window_get_geometry,
2737 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2738 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2739 (xg_get_pixbuf_from_pixmap): New function.
2740 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2741 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2742 Call xg_get_pixbuf_from_pixmap instead of
2743 gdk_pixbuf_get_from_drawable.
2744 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2745 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2746 (xg_check_special_colors): Use GtkStyleContext and its functions
2747 for HAVE_GTK3.
2748 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2749 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2750 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2751 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2752 Call gtk_widget_get_preferred_size.
0afb4571
J
2753 (xg_frame_resized): gdk_window_get_geometry only takes 5
2754 parameters.
44f230aa
SM
2755 (xg_win_to_widget, xg_event_is_for_menubar):
2756 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2757 (xg_set_widget_bg): New function.
2758 (delete_cb): New function.
895009e1 2759 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
2760 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2761 (xg_set_background_color): Call xg_set_widget_bg.
2762 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2763 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2764 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2765 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2766 if ! HAVE_GTK3.
2767 (update_frame_tool_bar): Call gtk_widget_hide.
2768 (xg_initialize): Use GDK_KEY_g.
2769
2770 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2771 if ! HAVE_GTK3
2772 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2773
2774 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2775 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2776 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2777
1c2cc4ef
JB
27782011-03-08 Juanma Barranquero <lekktu@gmail.com>
2779
2780 * w32xfns.c (select_palette): Check success of RealizePalette against
2781 GDI_ERROR, not zero.
2782
33383987 2783See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2784
2785;; Local Variables:
2786;; coding: utf-8
aac0c6e3
MR
2787;; End:
2788
33383987 2789 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2790
2791 This file is part of GNU Emacs.
2792
2793 GNU Emacs is free software: you can redistribute it and/or modify
2794 it under the terms of the GNU General Public License as published by
2795 the Free Software Foundation, either version 3 of the License, or
2796 (at your option) any later version.
2797
2798 GNU Emacs is distributed in the hope that it will be useful,
2799 but WITHOUT ANY WARRANTY; without even the implied warranty of
2800 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2801 GNU General Public License for more details.
2802
2803 You should have received a copy of the GNU General Public License
2804 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.