Export DEFAULT_REHASH_* to GDB.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
185ee146
PE
12012-08-04 Paul Eggert <eggert@cs.ucla.edu>
2
3 Export DEFAULT_REHASH_* to GDB.
4 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
5 Now constants, not macros.
6
8834c57a
PE
72012-08-03 Paul Eggert <eggert@cs.ucla.edu>
8
98c6f1e3
PE
9 Remove unnecessary casts involving pointers.
10 These casts are no longer needed now that we assume C89 or later,
11 since they involve casting to or from void *.
12 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
13 (make_pure_float, make_pure_vector):
14 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
15 * macros.c (Fstart_kbd_macro):
16 * menu.c (find_and_return_menu_selection):
17 * minibuf.c (read_minibuf_noninteractive):
18 * sysdep.c (closedir):
19 * xdisp.c (x_produce_glyphs):
20 * xfaces.c (compare_fonts_by_sort_order):
21 * xfns.c (x_real_positions, select_visual):
22 * xselect.c (x_stop_queuing_selection_requests)
23 (x_get_window_property, x_get_window_property_as_lisp_data):
24 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
25 Remove unnecessary pointer casts.
26 * alloc.c (record_xmalloc): New function.
27 * lisp.h (record_xmalloc): New decl.
28 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
29 more like a function. This is because the pointer cast is not
30 needed. All uses changed.
31 * print.c (print_string, print_error_message): Avoid length recalc.
32
8834c57a
PE
33 Improve fix for macroexp crash with debugging (Bug#12118).
34 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
35 ARRAY_MARK_FLAG when checking subscripts, because ASET is
36 not supposed to be invoked from the garbage collector.
37 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
38 (gc_aset): New function, which is like ASET but can be
39 used in the garbage collector.
40 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
41 (set_hash_index): Use it instead of ASET.
42
6dad7178
EZ
432012-08-03 Eli Zaretskii <eliz@gnu.org>
44
45 Support symlinks on latest versions of MS-Windows.
46 * w32.c: Include winioctl.h and aclapi.h.
47 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
48 (revert_to_self): Forward declarations of static functions.
49 <static BOOL g_b_init_get_security_info>:
50 <g_b_init_create_symbolic_link>: New static flags.
51 (globals_of_w32): Initialize them to zero.
52 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
53 (map_w32_filename): Improve commentary. Simplify switch.
54 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
55 headers (most versions of MinGW w32api don't).
56 (get_security_info, create_symbolic_link)
57 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
58 New functions.
59 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
60 in the argument file name.
61 (sys_access): Call unc_volume_file_attributes only if
62 GetFileAttributes fails with network-related error codes.
63 (sys_rename): Diagnose renaming of a symlink when the user doesn't
64 have the required privileges.
65 (get_file_security_desc_by_name): Renamed from
66 get_file_security_desc.
67 (stat_worker): New function, with most of the guts of 'stat', and
68 with addition of handling of symlinks and support for 'lstat'. If
69 possible, get file's attributes and security information by
70 handle, not by name. Produce S_IFLNK bit for symlinks, when
71 called from 'lstat'.
72 (stat, lstat): New functions, call 'stat_worker'.
73 (symlink, readlink, careadlinkat): Rewritten to create and resolve
74 symlinks when the underlying filesystem supports them.
75
f162bcc3
PE
762012-08-02 Paul Eggert <eggert@cs.ucla.edu>
77
79ea6c20
PE
78 Fix macroexp crash on Windows with debugging (Bug#12118).
79 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
80 checking subscripts; problem introduced with the recent
81 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
82 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
83 since it's used in non-static inline functions now.
84
c0ce93fd
PE
85 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
86 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 87
f162bcc3
PE
88 Use C99-style 'extern inline' if available.
89 * buffer.h (BUFFER_INLINE):
90 * category.h (CATEGORY_INLINE):
91 * character.h (CHARACTER_INLINE):
92 * charset.h (CHARSET_INLINE):
93 * composite.h (COMPOSITE_INLINE):
94 * dispextern.h (DISPEXTERN_INLINE):
95 * lisp.h (LISP_INLINE):
96 * systime.h (SYSTIME_INLINE):
97 New macro, replacing 'static inline' in this header.
98 * buffer.h, category.h, character.h, charset.h, composite.h:
99 * dispextern.h, lisp.h, systime.h:
100 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
101 * alloc.c (LISP_INLINE):
102 * buffer.c (BUFFER_INLINE):
103 * category.c (CATEGORY_INLINE):
104 * character.c (CHARACTER_INLINE):
105 * charset.c (CHARSET_INLINE):
106 * composite.c (COMPOSITE_INLINE):
107 * dispnew.c (DISPEXTERN_INLINE):
108 * sysdep.c (SYSTIME_INLINE):
109 Define to EXTERN_INLINE, so that the corresponding functions
110 are compiled into code.
111 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
112 (INLINE_HEADER_END): New macros.
113 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
114 since it's used in non-static inline functions now.
a8333d03 115 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 116
837b365b
GM
1172012-08-02 Glenn Morris <rgm@gnu.org>
118
d66b744d
GM
119 * s/: Remove empty directory.
120
837b365b
GM
121 * s/ms-w32.h: Move to ../nt/inc.
122 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
123 Update for new ms-w32.h location.
124
13294f95
PE
1252012-08-02 Paul Eggert <eggert@cs.ucla.edu>
126
127 Port to Solaris 8.
128 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
129
90df0db3
GM
1302012-08-02 Glenn Morris <rgm@gnu.org>
131
132 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
133 hard-coding the path separator.
134
4939150c
PE
1352012-08-01 Paul Eggert <eggert@cs.ucla.edu>
136
137 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
138 This how ASET and AREF are supposed to work, and makes
139 it easier to think about future improvements. See
140 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
141 * charset.h (set_charset_attr): New function.
142 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
143 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
144 (aref_addr): New function. All uses of &AREF(...) changed.
145 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
146 (set_hash_index): New functions. All lvalue-style uses of
147 HASH_KEY etc. changed.
148 * keyboard.c (set_prop): New function. All lvalue-style uses
149 of PROP changed.
150
947b2afd
AA
1512012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
152
153 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
154 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
155 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
156 * nsfns.m (ns_set_name_as_filename): Likewise.
157 * nsmenu.m (ns_update_menubar): Likewise.
158 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
159
4f5d0325
EZ
1602012-08-01 Eli Zaretskii <eliz@gnu.org>
161
2008beae
EZ
162 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
163 Adapt to latest changes in field names of the corresponding Lisp
288479f6 164 objects.
2008beae 165
4f5d0325
EZ
166 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
167
fe3cc771
GM
1682012-08-01 Glenn Morris <rgm@gnu.org>
169
170 * s/msdos.h: Remove file.
171 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
172 * Makefile.in (S_FILE): Remove.
173 (config_h): Remove S_FILE.
174
c90acc54
JB
1752012-08-01 Juanma Barranquero <lekktu@gmail.com>
176
177 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
178 Remove; moved to nt/config.nt.
179
d8a05828
DA
1802012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
181
182 Use INTERNAL_FIELD for conses and overlays.
183 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
184 Remove obsolete comment.
185 (MVAR): New macro.
186 (struct Lisp_Overlay): Use INTERNAL_FIELD.
187 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
188
8271d590
DA
1892012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
190
191 Use INTERNAL_FIELD for symbols.
192 * lisp.h (SVAR): New macro. Adjust users.
193 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
194 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
195
3193acd2
DA
1962012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
197
198 Use INTERNAL_FIELD for processes.
199 * process.h (PVAR): New macro. Adjust style.
200 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
201 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
202
3a45383a
DA
2032012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
204
205 Use INTERNAL_FIELD for windows.
206 * window.h (WVAR): New macro.
207 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
208 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
209 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
210 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
211 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
212 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
213
c1dbc63c
PE
2142012-08-01 Paul Eggert <eggert@cs.ucla.edu>
215
216 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
217
5c0c0e8a
GM
2182012-08-01 Glenn Morris <rgm@gnu.org>
219
220 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
221 Move to configure.ac.
222
552a99b4
JB
2232012-08-01 Juanma Barranquero <lekktu@gmail.com>
224
225 * makefile.w32-in (CONFIG_H): Update dependencies.
226 (CONF_POST_H): New macro.
227
228 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
229
8d8e2dfe
GM
2302012-07-31 Glenn Morris <rgm@gnu.org>
231
bc96620a
GM
232 * Makefile.in (S_FILE): No longer set by configure.
233
476b1b2d
GM
234 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
235 is available.
236 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
237
b2c7a106
GM
238 * process.h (NULL_DEVICE):
239 * emacs.c (SEPCHAR):
240 * editfns.c (USER_FULL_NAME): Let configure set them.
241
d53d062a
GM
242 * s/README, s/template.h: Remove files.
243
4515017f
GM
244 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
245
8d8e2dfe
GM
246 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
247 Move to configure.ac.
248
5b20b3cc
EZ
2492012-07-31 Eli Zaretskii <eliz@gnu.org>
250
1e0afd9a
EZ
251 * .gdbinit (xframe): Adapt to introduction of FVAR and the
252 resulting renaming of 'struct frame' members.
253
5b20b3cc
EZ
254 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
255
256 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
257 after introduction of FVAR.
258
f1310128
JD
2592012-07-31 Jan Djärv <jan.h.d@swipnet.se>
260
79e721e0
JD
261 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
262
263 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
264 instead of compositeToPoint.
265 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
266
8d7c7eed 267 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 268
e34f7f79
DA
2692012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
270
271 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
272 * lisp.h (INTERNAL_FIELD): New macro.
273 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
274 (BVAR): Change to use INTERNAL_FIELD.
275 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
276 (KVAR): Change to use INTERNAL_FIELD.
277 * frame.h (FVAR): New macro.
278 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
279 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
280 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
281 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
282 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
283
c09bfb2f
DA
2842012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
285
286 Miscellaneous fixes for non-default X toolkits.
287 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
288 * xterm.c (x_frame_of_widget): Remove redundant prototype.
289 Move under #ifdef USE_LUCID.
290 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
291 definition and usage to avoid warnings.
292
14c114ae
JD
2932012-07-31 Jan Djärv <jan.h.d@swipnet.se>
294
295 * nsterm.m (openFiles): Fix previous checkin.
296
3bd21e82
PE
2972012-07-31 Paul Eggert <eggert@cs.ucla.edu>
298
299 * indent.c (compute_motion): Remove unused local.
300
c1529ded
GM
3012012-07-31 Glenn Morris <rgm@gnu.org>
302
400d5621
GM
303 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
304
268e2432
GM
305 * conf_post.h [USG5_4]:
306 Move remaining contents of s/usg5-4-common.h here.
307 * s/usg5-4-common.h: Remove file.
308
7552f3ee
GM
309 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
310 * s/irix6-5.h: Remove file.
311
6a381852
GM
312 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
313 * s/darwin.h: Remove file.
314
c1529ded
GM
315 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
316 * s/hpux10-20.h: Remove file, which is now empty.
317
b429a4ee
GM
3182012-07-30 Glenn Morris <rgm@gnu.org>
319
320 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
321 * Makefile.in (config_h): Add conf_post.h.
322 * makefile.w32-in (CONFIG_H): Add conf_post.h.
323
adff3182
JD
3242012-07-30 Jan Djärv <jan.h.d@swipnet.se>
325
326 * nsterm.m (ns_do_open_file): New variable.
b9031d69 327 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
328 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
329 files only if ns_do_open_file.
330
c32af1e4
PE
3312012-07-30 Paul Eggert <eggert@cs.ucla.edu>
332
7393bcbb
PE
333 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
334 This no-op macro hasn't been needed for many years.
335 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
336
c32af1e4
PE
337 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
338 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
339 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
340 gdb_make_enums_visible.
341 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
342 (DIRECTORY_SEP): Now a constant, not a macro.
343
302fc036
EZ
3442012-07-30 Eli Zaretskii <eliz@gnu.org>
345
346 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
347 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
348
349 * w32term.c <w32_keyboard_codepage>: Renamed from
350 keyboard_codepage and now external. All users changed.
351
352 * w32term.h: Add declaration of w32_keyboard_codepage.
353
354 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
355 the codepage to translate keys to Unicode. If this argument is
356 -1, use the value returned by GetConsoleCP. All callers changed.
357
88fb40b4
PE
3582012-07-30 Paul Eggert <eggert@cs.ucla.edu>
359
0aee6912
PE
360 Update .PHONY listings in makefiles.
361 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
362 bootstrap-clean, distclean, maintainer-clean, versioclean,
363 extraclean, frc.
364
88fb40b4
PE
365 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
366 This is a bit clearer. Fix some commentary typos.
367
0a763bd1
GM
3682012-07-30 Glenn Morris <rgm@gnu.org>
369
32bac6d6
GM
370 * s/netbsd.h: Let configure include signal.h if needed.
371 Remove file, which is now empty.
372
b65e7c46
GM
373 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
374 Let configure set them.
375 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
376 No more need to undefine.
0a763bd1 377
169304bd
AS
3782012-07-30 Andreas Schwab <schwab@linux-m68k.org>
379
380 * keymap.c (Fkey_description): Don't remove 0x80 bit from
381 non-single-byte char when adding meta modifier. (Bug#12090)
382
6cd7a139
DA
3832012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
384
385 Convert safe_call to use variable number of arguments.
386 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
387 (safe_call2): Fix comment.
388 * lisp.h (safe_call): Adjust prototype.
389 * coding.c (encode_coding_object): Change to use safe_call2.
390 * xfaces.c (merge_face_heights): Change to use safe_call1.
391
d34d6ffc
GM
3922012-07-30 Glenn Morris <rgm@gnu.org>
393
7b8a48e4 394 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 395 does that unconditionally. Remove file, which is now empty.
7b8a48e4 396
d34d6ffc
GM
397 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
398 Remove empty files.
399
03a660a6
PE
4002012-07-30 Paul Eggert <eggert@cs.ucla.edu>
401
402 Export to GDB most of lisp.h's remaining object-like macros.
403 * lisp.h (min, max): Move earlier, because they're used earlier now.
404 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
405 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
406 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
407 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
408 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
409 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
410 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
411 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
412 Now constants, for GDB. They need not be macros.
413 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
414 Now constants, for GDB, as well as macros, for static initializers.
415 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
416 Move to after the definition of struct Lisp_Char_Table,
417 since the former now needs that type defined.
418 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
419 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
420 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
421 New enums, for gdb_make_enums_visible.
422 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 423 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
424 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
425 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
426 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
427 enum maxargs, enum MAX_ALLOCA.
428 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
429 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
430 no longer needed, now that they are done in lisp.h.
431
e499d0ee
DA
4322012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
433
434 Cleanup string bytes checking.
435 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
436 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
437 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
438 (check_sblock, compact_small_strings): Simplify.
439
d5040d2d
PE
4402012-07-29 Paul Eggert <eggert@cs.ucla.edu>
441
442 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
443 These macros are confusing and no longer need to be defined, as
444 the enum values now suffice. All uses replaced with definiens.
445 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
446
7f259ae6
JB
4472012-07-29 Juanma Barranquero <lekktu@gmail.com>
448
449 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
450 ($(BLD)/w32console.$(O)): Update dependencies.
451
7e63e0c3
DA
4522012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
453
454 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
455 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
456 time. Adjust users.
457 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
458
ffd817eb
JD
4592012-07-29 Jan Djärv <jan.h.d@swipnet.se>
460
461 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
462 setting sitelisp (Bug#12010).
463
417a7a0e
EZ
4642012-07-29 Eli Zaretskii <eliz@gnu.org>
465
466 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
467
468 * w32heap.c (cache_system_info):
469 * w32.c (sys_rename):
470 * w32proc.c (find_child_console, sys_kill): All users changed.
471
387d4d92
PE
4722012-07-29 Paul Eggert <eggert@cs.ucla.edu>
473
474 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
475
55a6cca6
EZ
4762012-07-29 Eli Zaretskii <eliz@gnu.org>
477
478 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
479
dbcf001c
DA
4802012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
481
482 Cleanup statistics calculation in Fgarbage_collect.
483 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
484 zombies percentage calculation. Simplify elapsed time calculation.
485
e2688e4a
DA
4862012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
487
488 Generalize marker debugging code under MARKER_DEBUG and use eassert.
489 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
490 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
491 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
492 (replace_range, replace_range_2, del_range_2): Change to eassert.
493 * marker.c (byte_char_debug_check): Adjust style.
494
b46a6a83
PE
4952012-07-29 Paul Eggert <eggert@cs.ucla.edu>
496
497 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
498 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
499 long-ago-commented-out code that talks about "WIN32".
500 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
501 All uses changed.
502
e32a5799
PE
5032012-07-28 Paul Eggert <eggert@cs.ucla.edu>
504
505 Use Gnulib stdalign module (Bug#9772, Bug#9960).
506 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
507 Simplify by using alignof.
508 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
509 * lisp.h: Include <stdalign.h>.
510 (GCALIGNMENT): New macro and constant.
511 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
512 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
513 (stdalign): New macro, if not already defined.
514
df81cd29
EZ
5152012-07-28 Eli Zaretskii <eliz@gnu.org>
516
01bd1b0d
EZ
517 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
518 * w32inevt.c: Include w32inevt.h.
519 (w32_read_console_input): New inline function, calls either
520 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
521 w32_console_unicode_input.
522 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
523 (w32_kbd_patch_key, key_event): Use the codepage returned by
524 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
525 (key_event): use uChar.UnicodeChar only if
526 w32_console_unicode_input is non-zero.
527
528 * w32console.c: Include w32heap.h.
529 <w32_console_unicode_input>: New global variable.
530 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
531 family of Windows, zero otherwise.
532
533 * w32inevt.h: Declare w32_console_unicode_input.
534
df81cd29
EZ
535 * xdisp.c (init_iterator): Don't reference tip_frame in a build
536 --without-x. (Bug#11742)
537
c20fdd9e
PE
5382012-07-27 Paul Eggert <eggert@cs.ucla.edu>
539
540 Adjust GDB to reflect pvec_type changes (Bug#12036).
541 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
542 2012-07-04 changes to pseudovector representation. Problem
543 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
544
32770973 5452012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
546
547 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
548 bus address.
549 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
550
3438fe21
EZ
5512012-07-27 Eli Zaretskii <eliz@gnu.org>
552
bcfbc9de
EZ
553 * alloc.c (listn): Fix the order the arguments are consed onto the
554 list.
555
3438fe21
EZ
556 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
557 enumeration constants, as PURE and HEAP are too general, and clash
558 with other headers and sources, such as gmalloc.c and the
559 MS-Windows system headers. All users changed.
560
eeaea515
DA
5612012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
562
563 Revert last save_excursion_save and save_excursion_restore changes.
564 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
565 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
566
073c88c2
DA
5672012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
568
569 Fix recently-introduced typos in Windows port.
570 Reported by Martin Rudalics <rudalics@gmx.at>.
571 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 572 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 573
4706125e
PE
5742012-07-27 Paul Eggert <eggert@cs.ucla.edu>
575
576 Improve GDB symbol export (Bug#12036).
577 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
578 arms of an 'if', not using conditional expressions; otherwise GDB
579 complains about the types in the unevaluated arm when the argument
580 is an integer literal.
581 (xgetint): Simplify expression.
582 * alloc.c (gdb_make_enums_visible): New constant. This ports to
583 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
584 Zaretskii in <http://bugs.gnu.org/12036#13>.
585 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
586 needed now that we have gdb_make_enums_visible.
587 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
588 (enum enum_USE_LSB_TAG):
589 New enum types, packaging up enums that need to be exported to GDB.
590
694b6c97
DA
5912012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
592
593 Utility function to make a list from specified amount of objects.
594 * lisp.h (enum constype): New datatype.
595 (listn): New prototype.
596 * alloc.c (listn): New function.
597 (Fmemory_use_count, syms_of_alloc): Use it.
598 * buffer.c (syms_of_buffer): Likewise.
599 * callint.c (syms_of_callint): Likewise.
600 * charset.c (define_charset_internal): Likewise.
601 * coding.c (syms_of_coding): Likewise.
602 * keymap.c (syms_of_keymap): Likewise.
603 * search.c (syms_of_search): Likewise.
604 * syntax.c (syms_of_syntax): Likewise.
605 * w32.c (init_environment): Likewise.
606 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
607 * xdisp.c (syms_of_xdisp): Likewise.
608 * xfns.c (syms_of_xfns): Likewise.
609
6195f384
DA
6102012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
611
612 Fast save_excursion_save and save_excursion_restore.
613 * lisp.h (struct Lisp_Excursion): New data type.
614 (PVEC_EXCURSION): New pseudovector type.
615 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
616 to deal with it. Adjust comments.
617 (init_marker, attach_marker): New prototype.
618 (unchain_marker): Adjust prototype.
619 * marker.c (attach_marker): Change to global.
620 (init_marker): New function.
621 * alloc.c (Fmake_marker, build_marker): Use it.
622 (build_marker): More easserts.
623 (mark_object): Handle struct Lisp_Excursion.
624 * editfns.c (save_excursion_save, save_excursion_restore):
625 Reimplement to use struct Lisp_Excursion. Add comments.
626
5eceb8fb
PE
6272012-07-26 Paul Eggert <eggert@cs.ucla.edu>
628
629 Fix export of symbols to GDB (Bug#12036).
630 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
631 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
632 emacs.c, as this is a more-suitable home. Had this been done earlier
633 the fix for 12036 would have avoided some of the problems noted in
634 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
635 would have been more obvious.
562157c8
PE
636 * emacs.c: Do not include <verify.h>; no longer needed.
637 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
638 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
639 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
640 Remove; now done in lisp.h.
641 * lisp.h (PUBLISH_TO_GDB): New macro.
642 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
643 (DATA_SEG_BITS): Use it.
644 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
645 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
646 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
647 not be usable in #if. This simplifies things.
648
d6749401
JB
6492012-07-26 Juanma Barranquero <lekktu@gmail.com>
650
651 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
652
1781b9e9
PE
6532012-07-26 Paul Eggert <eggert@cs.ucla.edu>
654
d89518db 655 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
656 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
657 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
658 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
659 Adjust to changes in lisp.h and emacs.c, by using
660 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
661 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
662 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
663 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
664 instead of gdb_valbits.
665 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
666 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
667 instead of gdb_array_mark_flag.
668 (xboolvector): Get size from $->size, not $->header.size.
669 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
670 (xreload, hook-run, hookpost-run): Remove.
671 * emacs.c: Include <verify.h>.
672 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
673 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
674 Remove.
675 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
676 (gdb_USE_LSB_TAG): New enum constants.
677 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
678 Also define these as enum constants, so they're visible to GDB.
679 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
680 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
681 as constants, so they're visible to GDB.
682 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
683 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
684 Now enum constants, not macros, so they're visible to GDB.
685 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
686 more convenient now. All uses changed.
687 (VALMASK) [USE_LSB_TAG]: Also define in this case.
688 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
689
3628596a
DA
6902012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
691
692 Explicitly free restriction data that are not needed anymore.
693 * editfns.c (save_restriction_restore): Free restriction data.
694
7abaf5cc
SM
6952012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
696
697 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
698 add argument, tune behavior, and adjust all callers.
699
71f88e00
PE
7002012-07-25 Paul Eggert <eggert@cs.ucla.edu>
701
702 Use typedef for EMACS_INT, EMACS_UINT.
703 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
704 than macros. This simplifies debugging in the usual case, since
705 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
706 and it allows expressions involving EMACS_INT casts.
707 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
708
57ec3034
JD
7092012-07-25 Jan Djärv <jan.h.d@swipnet.se>
710
711 * nsterm.m (ns_read_socket): Return early if there is a modal
712 window (Bug#12043).
713
8137e7b3
MR
7142012-07-25 Martin Rudalics <rudalics@gmx.at>
715
716 * frame.c (Fredirect_frame_focus): In doc-string don't mention
717 that FOCUS-FRAME can be omitted.
718
04e9897c
DA
7192012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
720
721 Adjust buffer text indirection counters at the end of Fkill_buffer.
722 * buffer.c (Fkill_buffer): Adjust indirection counters when the
723 buffer is definitely dead. This should really fix an issue reported
724 by Christoph Scholtes again. (Bug#12007).
725 (init_buffer_once): Initialize indirection counters of
726 buffer_defaults and buffer_local_symbols (for sanity and safety).
727
8a0484e1
EZ
7282012-07-24 Eli Zaretskii <eliz@gnu.org>
729
730 * xdisp.c (init_iterator): Don't compute dimensions of truncation
731 and continuation glyphs on tooltip frames, leave them at zero.
732 Avoids continued lines in tooltips. (Bug#11832)
733
fa691a83
DA
7342012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
735
736 Simplify copy_overlay.
04e9897c 737 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
738 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
739
436bc8e0
EZ
7402012-07-23 Eli Zaretskii <eliz@gnu.org>
741
742 * print.c (print_object): Don't crash when a frame's name is nil
743 or invalid. (Bug#12025)
744
745 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
746 it signals an error when a tooltip frame is being created.
747
d7a7fda3
DA
7482012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
749
750 Cleanup miscellaneous objects allocation and initialization.
751 * alloc.c (allocate_misc): Change to static. Add argument to
752 specify the subtype. Adjust comment and users.
753 (build_overlay): New function.
754 * buffer.c (copy_overlays, Fmake_overlay): Use it.
755 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
756 (allocate_misc): Remove prototype.
757 (build_overlay): Add prototype.
758
7592012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
760
761 Swap buffer text indirection counters in Fbuffer_swap_text.
762 * buffer.c (Fbuffer_swap_text): Swap indirections too.
763 This avoids crash reported by Christoph Scholtes at
764 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
765
9d7fa573
JD
7662012-07-22 Jan Djärv <jan.h.d@swipnet.se>
767
768 * nsmenu.m (Popdown_data): New struct.
769 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
770 free Popdown_data.
771 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
772 (initWithContentRect): Make imgView and contentView non-static
773 and autorelease them. Also autorelease img and matrix (Bug#12005).
774 (dealloc): Remove (Bug#12005).
775
0dd6d66d
DA
7762012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
777
778 Adjust consing_since_gc when objects are explicitly freed.
779 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
780 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
781 (free_cons, free_misc): Subtract object size from consing_since_gc.
782
d36d71df
DA
7832012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
784
785 Simplify and cleanup markers positioning code.
786 * marker.c (attach_marker): More useful eassert.
787 (live_buffer, set_marker_internal): New function.
788 (Fset_marker, set_marker_restricted): Use set_marker_internal.
789 (set_marker_both, set_marker_restricted_both): Use live_buffer.
790
fb9ea40f
PE
7912012-07-22 Paul Eggert <eggert@cs.ucla.edu>
792
793 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
794 as it's limited by the amount of memory, not by INT_MAX.
795
2d5c5f7d
EZ
7962012-07-21 Eli Zaretskii <eliz@gnu.org>
797
07fb592e
EZ
798 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
799 in special-event-map. See the discussion at
800 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
801 for the reasons.
802
37a9eac8 803 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
804 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
805 Fabrice Popineau <fabrice.popineau@supelec.fr>.
806
c4328746
JD
8072012-07-21 Jan Djärv <jan.h.d@swipnet.se>
808
809 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 810 (conversationIdentifier): Return value is NSInteger.
784051c4 811 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 812
6e5d1c12
CY
8132012-07-21 Chong Yidong <cyd@gnu.org>
814
815 * window.c (decode_any_window): Signal an error if the window is
816 on a dead frame (Bug#11984).
817
9928463d
DA
8182012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
819
820 Add indirection counting to speed up Fkill_buffer.
821 * buffer.h (struct buffer): New member.
822 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
823 (Fmake_indirect_buffer): Set indirection counter to -1, increment
824 base buffer indirection counter.
825 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
826 (Fkill_buffer): Adjust indirection counters as needed, don't walk
827 through buffer list if indirection counter is 0.
828
f8643a6b
DA
8292012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
830
831 Extend the value returned by Fgarbage_collect with heap statistics.
832 * alloc.c (Qheap): New symbol.
833 (syms_of_alloc): DEFSYM it.
834 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
835 (Fmemory_free): Remove.
836 (syms_of_alloc): Don't defsubr it.
837 * buffer.c (Fcompact_buffer): Remove.
838 (syms_of_buffer): Don't defsubr it.
839
dac616ff
DA
8402012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
841
842 Make maybe_gc inline.
843 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
844 * lisp.h (consing_since_gc, gc_relative_threshold)
845 (memory_full_cons_threshold): Revert declaration.
846 (maybe_gc): Remove prototype, define as inline.
847 * alloc.c: Remove old commented-out code.
848 (consing_since_gc, gc_relative_threshold)
849 (memory_full_cons_threshold): Revert to global.
850 (maybe_gc): Remove.
851
d7ea76b4
DA
8522012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
853
854 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
855 * lisp.h (build_unibyte_string): New function.
856 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
857 * sysdep.c, w32fns.c, xfns.c: Use it.
858 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
859 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
860 Adjust users accordingly.
861 * font.h (font_open_by_name): Adjust prototype.
862
765e61e3
DA
8632012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
864
865 Cleanup calls to Fgarbage_collect.
866 * lisp.h (maybe_gc): New prototype.
867 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
868 Remove declarations.
869 * alloc.c (maybe_gc): New function.
870 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
871 Make them static.
872 * bytecode.c (MAYBE_GC): Use maybe_gc.
873 * eval.c (eval_sub, Ffuncall): Likewise.
874 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
875 to avoid dependency from auto-save feature.
876
52b852c7
PE
8772012-07-19 Paul Eggert <eggert@cs.ucla.edu>
878
879 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
880 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
881 'for_each_per_buffer_object_at'.
882 All uses changed. It's better to use upper-case for macros that
883 cannot be implemented as functions, to give the reader a clue
884 that they're special.
885
5db81e33
SM
8862012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
887
888 * alloc.c (Fgarbage_collect): Tweak docstring.
889
5b835e1d
DA
8902012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
891
892 Tweak the value returned from Fgarbage_collect again.
893 * alloc.c (Fgarbage_collect): New return value, as confirmed in
894 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
895 Adjust documentation.
896 (total_vector_bytes): Rename to total_vector_slots, adjust
897 accounting.
898 (total_free_vector_bytes): Rename to total_free_vector_slots,
899 adjust accounting.
900 (Qstring_bytes, Qvector_slots): New symbols.
901 (syms_of_alloc): DEFSYM them.
902
9cd47b72
DA
9032012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
904
905 Buffer compaction primitive which may be used from Lisp.
906 * buffer.c (compact_buffer, Fcompact_buffer): New function.
907 (syms_of_buffer): Register Fcompact_buffer.
908 * alloc.c (Fgarbage_collect): Use compact_buffer.
909 * buffer.h (compact_buffer): New prototype.
910 (struct buffer_text): New member.
911
d17337e5
DA
9122012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
913
914 New macro to iterate over all buffers, miscellaneous cleanups.
915 * lisp.h (all_buffers): Remove declaration.
916 * buffer.h (all_buffers): Add declaration, with comment.
917 (for_each_buffer): New macro.
918 * alloc.c (Fgarbage_collect, mark_object): Use it.
919 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
920 (init_buffer): Likewise.
921 * data.c (Fset_default): Likewise.
922 * coding.c (code_conversion_restore): Remove redundant check
923 for dead buffer.
924 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
925
60cfd278
AS
9262012-07-18 Andreas Schwab <schwab@linux-m68k.org>
927
928 Fix bug that created negative-length intervals.
929 * intervals.c (merge_interval_right, merge_interval_left):
930 Do not zero out this interval if it is absorbed by its children,
931 as this interval's total length doesn't change in that case. See
932 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
933
d06714cb
PE
9342012-07-18 Paul Eggert <eggert@cs.ucla.edu>
935
83713154
PE
936 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
937 when invoking (make-bool-vector N t) and N is a positive
938 multiple of 8 -- the last 8 bits were mistakenly cleared.
939
d06714cb
PE
940 Remove some struct layout assumptions in bool vectors.
941 * alloc.c (bool_header_size): New constant.
942 (header_size, word_size): Move earlier, as they're now used earlier.
943 Use 'word_size' in a few more places, where it's appropriate.
944 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
945 padding before the data member of a bool vector.
946 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
947 than doing the check by hand with an abort ().
948
464d5a5e
SM
9492012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
950
5fbc0409
SM
951 * eval.c (Fdefvar): Don't check constants since we only set the var if
952 it's not yet defined anyway (bug#11904).
953
464d5a5e
SM
954 * lisp.h (last_undo_boundary): Declare new var.
955 * keyboard.c (command_loop_1): Set it.
956 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
957 were auto-added by the command loop (bug#11774).
958
8dc2e44a
AS
9592012-07-18 Andreas Schwab <schwab@linux-m68k.org>
960
961 * w32font.c (Qsymbol): Remove local definition.
962 (syms_of_w32font): Don't DEFSYM it.
963
169925ec
DA
9642012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
965
966 Fix sweep_vectors to handle large bool vectors correctly.
967 * alloc.c (sweep_vectors): Account total_vector_bytes for
968 bool vectors larger than VBLOCK_BYTES_MAX.
969
5fbfb018
CY
9702012-07-18 Chong Yidong <cyd@gnu.org>
971
972 * frame.c (x_set_frame_parameters): Revert bogus change introduced
973 in 2012-05-25 commit by Paul Eggert (Bug#11738).
974
3ab6e069
DA
9752012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
976
977 Return more descriptive data from Fgarbage_collect.
978 Suggested by Stefan Monnier in
979 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
980 * alloc.c (bounded_number): New function.
981 (total_buffers, total_vectors): New variable.
982 (total_string_size): Rename to total_string_bytes, adjust users.
983 (total_vector_size): Rename to total_vector_bytes, adjust users.
984 (sweep_vectors): Account total_vectors and total_vector_bytes.
985 (Fgarbage_collect): New return value. Adjust documentation.
986 (gc_sweep): Account total_buffers.
987 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
988 (VECTOR_SIZE): Remove.
989 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
990 (Qinterval, Qmisc): New symbols.
991 (syms_of_data): Initialize them.
992 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
993 (Qcons, Qbuffer): New declarations.
994
6d02fe5b
PE
9952012-07-17 Paul Eggert <eggert@cs.ucla.edu>
996
997 * alloc.c (Fmemory_free): Account for memory-free's own storage.
998 Round up, not down. Improve doc.
999
b7ffe040
DA
10002012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1001
1002 Restore old code in allocate_string_data to avoid Faset breakage.
1003 Reported by Julien Danjou <julien@danjou.info> in
1004 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1005 * alloc.c (allocate_string_data): Restore old code with minor
1006 adjustments, fix comment to explain this subtle issue.
1007
4dc7c8d5
SM
10082012-07-17 Eli Zaretskii <eliz@gnu.org>
1009
1010 Remove FILE_SYSTEM_CASE.
1011 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1012
1013 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1014 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1015 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1016 call-process-region passes it through expand-file-name.
1017
1018 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1019
10202012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1021
1022 Fix crash when creating indirect buffer (Bug#11917)
1023 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1024 Don't handle unbound variables specially if non-zero.
1025 (Fbuffer_local_variables): Pass zero.
1026 (clone_per_buffer_values): Pass non-zero.
1027
10282012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1029
1030 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1031 to make the loop interruptible.
1032
10332012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1034
1035 * gnutls.c (emacs_gnutls_handshake): Only retry if
1036 GNUTLS_E_INTERRUPTED.
1037
cce7fefc
DA
10382012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1039
1040 Cleanup and convert miscellaneous checks to eassert.
1041 * alloc.c (mark_interval): Fix comment, partially rephrase
1042 old comment from intervals.h (see below).
1043 * intervals.c (find_interval, adjust_intervals_for_insertion)
1044 (delete_interval, adjust_intervals_for_deletion)
1045 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1046 Convert to eassert.
1047 (adjust_intervals_for_insertion, make_new_interval):
1048 Remove obsolete and unused code.
1049 * intervals.h (struct interval): Remove obsolete comment.
1050 * textprotp.c (erase_properties): Remove unused code.
1051 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1052 (Fremove_list_of_text_properties): Convert to eassert.
1053
9ea10cc3
CY
10542012-07-17 Chong Yidong <cyd@gnu.org>
1055
1056 * editfns.c (Finsert_char): Doc fix.
1057
3900d5de
DA
10582012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1059
1060 Fix previous change to make Fmemory_free always accurate.
1061 * alloc.c (make_interval): Update total_free_intervals.
1062 (make_float): Likewise for total_free_floats.
1063 (free_cons, Fcons): Likewise for total_free_conses.
1064 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1065 Likewise for total_free_vector_bytes.
1066 (Fmake_symbol): Likewise for total_free_symbols.
1067 (bytes_free): Remove.
1068
7098646f
DA
10692012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1070
1071 Simple free memory accounting feature.
1072 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1073 (sweep_vectors): Accumulate size of free vectors.
1074 (Fgarbage_collect): Setup bytes_free.
1075 (Fmemory_free): New function.
1076 (syms_of_alloc): Register it.
1077
22657b40
DA
10782012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1079
1080 Cleanup overlays checking.
1081 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1082 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1083 eassert and OVERLAYP.
1084 (sort_overlays): Change to use OVERLAYP.
1085
ddfc8813
RK
10862012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1087
1088 * editfns.c (Finsert_char): Make it interactive, and make the
1089 second arg optional. Copy interactive spec and docstring from
1090 ucs-insert.
1091
7c26cf3c
PE
10922012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1093
1094 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1095 Unlike the other wrapped functions, fabs has an unspecified
1096 effect on errno.
1097
5d127af9
JD
10982012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1099
1100 * nsterm.m (keyDown): Interpret flags without left/right bits
1101 as the left key (Bug#11670).
1102
6a0dd1d7
DA
11032012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1104
1105 Remove empty and useless init functions.
1106 * lisp.h (init_character_once, init_fns, init_image)
1107 (init_filelock, init_sound): Remove prototype.
1108 * character.c (init_character_once): Remove.
1109 * filelock.c (init_filelock): Likewise.
1110 * fns.c (init_fns): Likewise.
1111 * image.c (init_image): Likewise.
1112 * sound.c (init_sound): Likewise.
1113 * emacs.c (main): Adjust accordingly.
1114
7a6136fd
DA
11152012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1116
1117 * gtkutil.h: Tiny cleanups.
1118 (use_old_gtk_file_dialog): Remove useless declaration.
1119 (xg_uses_old_file_dialog): Add suggested const attribute.
1120
ce811ad9
EZ
11212012-07-15 Eli Zaretskii <eliz@gnu.org>
1122
1123 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1124 (bidi_paragraph_init): Use it to limit search forward for a strong
1125 directional character in abnormally large paragraphs full of
1126 neutral or weak characters. (Bug#11943)
1127
c9adfeaa
SF
11282012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1129
1130 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1131 the toolbar (Bug#9451).
1132 (xg_make_tool_item): Give the widget event box a transparent
1133 background.
1134
fff62aa9
DA
11352012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1136
1137 Cleanup basic allocation variables and functions.
1138 * alloc.c (ignore_warnings, init_intervals, init_float)
1139 (init_cons, init_symbol, init_marker): Remove.
1140 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1141 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1142 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1143 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1144 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1145 (staticidx, init_alloc_once, init_strings, free_ablock):
1146 Remove redundant initialization.
1147 * fns.c (init_weak_hash_tables): Remove.
1148 * lisp.h (init_weak_hash_tables): Remove prototype.
1149
9730daca
DA
11502012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1151
1152 Use zero_vector where appropriate.
1153 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1154 accordingly.
1155 * lisp.h (zero_vector): New declaration.
1156 * font.c (null_vector): Remove.
1157 (syms_of_font): Remove initialization and staticpro.
1158 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1159 * keymap.c (Faccessible_keymaps): Likewise.
1160
2e2d2a13
LL
11612012-07-15 Leo Liu <sdl.web@gmail.com>
1162
1163 * fringe.c: Fix typo in comments.
1164
cd276f6e
LL
11652012-07-14 Leo Liu <sdl.web@gmail.com>
1166
1167 * fringe.c: Add a new bitmap exclamation-mark.
1168
5a1131d9
EZ
11692012-07-14 Eli Zaretskii <eliz@gnu.org>
1170
1171 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1172
1173 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1174 (HAVE_MENUS): Don't define, defined by editing config.in with
1175 msdos/sed2v2.inp.
1176 (GMALLOC_INHIBIT_VALLOC): Don't define.
1177 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1178
22e983b7
JB
11792012-07-14 Juanma Barranquero <lekktu@gmail.com>
1180
1181 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1182
5b3f250f
GM
11832012-07-14 Glenn Morris <rgm@gnu.org>
1184
1185 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1186 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1187 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1188
33d63ff4
GM
11892012-07-13 Glenn Morris <rgm@gnu.org>
1190
5b633342
GM
1191 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1192
33d63ff4
GM
1193 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1194 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1195
b55b9f85
JD
11962012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1197
0dc8cf50
JD
1198 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1199 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1200 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1201 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1202 where appropriate.
1203 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1204 as boolean expression.
1205 (x_set_window_size): Remove unused variable toolbar.
1206 (ns_get_color_default, ns_mod_to_lisp): Remove.
1207 (ns_mouse_position): Remove unused variables xchar and ychar.
1208 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1209 (ns_set_vertical_scroll_bar): Remove unused variable count.
1210 (ns_delete_terminal): Remove unused variable i.
1211 (ns_term_init): Remove unused variables r, g and b.
1212 (mouseDown): Remove unused variable window.
1213 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1214 (initFrameFromEmacs): Remove unused variable vbextra.
1215 (mouseEntered): Remove unused variables p and dpyinfo.
1216 (mouseExited): Remove unused variables p and r.
1217 (ns_define_frame_cursor, ns_clear_frame_area)
1218 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1219 (menuDown): Assign [sender tag] to variable and cast the variable.
1220
1221 * nsterm.h (menuDown): Add id as type to argument sender.
1222 (ns_display_info_for_name): Add Lisp_Object argument.
1223 (ns_term_init): Add Lisp_Object argument.
1224 (ns_map_event_to_object): Add void argument.
1225 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1226 prototype with arguments and only declare if __OBJC__.
1227 (nxatoms_of_nsselect): Add void argument.
1228 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1229 (ns_alloc_autorelease_pool): Add void argument.
1230 (ns_release_autorelease_pool): Add void* argument.
1231 (ns_get_defaults_value): Add const char* argument.
1232
1233 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1234 (initFromContents): Use SSDATA where appropriate.
1235 (ns_update_menubar): Add braces to ambigous if-else.
1236 (initWithTitle): Put () around assignment in if statement.
1237 (ns_menu_show): Remove unused variables window and keymap.
1238 (update_frame_tool_bar): Remove unused variable selected_p.
1239 (initWithContentRect): Remove unused variable this_cmd_name.
1240
1241 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1242 appropriate.
1243 (setXBMColor): Remove unused variable len.
1244 (setPixmapData): Put () around assignment in loop statement.
1245
1246 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1247 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1248 where appropriate.
1249 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1250 around assignment in loop statement.
1251 (nsfont_open): Remove unused variable i.
1252 (nsfont_open): Remove unused variable len.
1253 (nsfont_draw): Remove unused variable cs.
1254
1255 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1256 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1257 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1258 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1259 (Fns_font_name, Fns_perform_service)
1260 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1261 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1262 (ns_set_name): Remove unused variable view.
1263 (x_set_menu_bar_lines): Remove unused variable olines.
1264 (x_set_tool_bar_lines): Remove unused variable root_window.
1265 (Fns_list_colors): Put () around assignment in while statement.
1266 (Fns_perform_service): Remove unused variable len.
1267 (Fns_display_usable_bounds): Remove unused variable top.
1268 (syms_of_nsfns): Remove unused variable i.
1269
b55b9f85
JD
1270 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1271 memcpy (Bug#11907).
1272
ed9265fc 12732012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1274
1275 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1276 and free it with DestroyExceptionInfo (Bug#11558).
1277
ef099b57
JB
12782012-07-13 Juanma Barranquero <lekktu@gmail.com>
1279
1280 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1281 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1282 Set here, not in nt/config.nt.
1283
ea814a5d
EZ
12842012-07-13 Eli Zaretskii <eliz@gnu.org>
1285
1286 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1287 cursor overflow into the last glyph on display line when the right
1288 fringe is off. (Bug#11832)
1289
1a952767
PE
12902012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1291
1292 * xdisp.c (produce_special_glyphs): Now static.
1293 * dispextern.h (produce_special_glyphs): Remove decl.
1294
983188fd
GM
12952012-07-13 Glenn Morris <rgm@gnu.org>
1296
8d7c7eed 1297 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1298 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1299
983188fd
GM
1300 * s/usg5-4-common.h (USG, USG5):
1301 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1302 * s/sol2-6.h (SOLARIS2):
1303 * s/irix6-5.h (IRIX6_5):
1304 * s/hpux10-20.h (USG, USG5, HPUX):
1305 * s/gnu-linux.h (USG, GNU_LINUX):
1306 * s/freebsd.h (BSD_SYSTEM):
1307 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1308 * s/cygwin.h (CYGWIN):
1309 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1310 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1311
d1e68667 13122012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1313
1314 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1315
6de0e799
GM
13162012-07-13 Glenn Morris <rgm@gnu.org>
1317
739ae010
GM
1318 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1319
dbee5793
GM
1320 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1321
6de0e799
GM
1322 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1323 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1324
b82da769
GM
13252012-07-12 Glenn Morris <rgm@gnu.org>
1326
4fae5a7a 1327 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1328
1329 * process.c (init_process_emacs): Rename from init_process.
1330 The old name is also the name of a Mach system call.
1331 * lisp.h, emacs.c: Update for this name change.
1332 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1333 longer needed.
1334
5a979817
EZ
13352012-07-12 Eli Zaretskii <eliz@gnu.org>
1336
1337 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1338 memmove call that removes glyphs covered by the left truncation
1339 glyph. Improve commentary.
1340 (display_line): Fix display of continuation glyphs on GUI frames
1341 when the right fringe is turned off and variable-size fonts are
1342 used in the window. Move the code that appends a stretch glyph to
1343 produce_special_glyphs, so that it could be used for truncation
1344 and continuation glyphs alike.
1345 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1346 glyph of a suitably computed width, to align the special glyphs at
1347 the window margin. Code moved from display_line. (Bug#11832)
1348
3e91a053
GM
13492012-07-12 Glenn Morris <rgm@gnu.org>
1350
ba9e4b84
GM
1351 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1352
1353 * s/gnu-linux.h, s/hpux10-20.h:
1354 Do not unconditionally define HAVE_XRMSETDATABASE.
1355
3e91a053
GM
1356 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1357
b300b1f4
PE
13582012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1359
1360 Fix typos that broke OS X build.
1361 Reported by Randal L. Schwartz in
1362 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1363 * nsterm.m (ns_timeout): Add missing local decl.
1364 (ns_get_color): snprintf -> sprintf, to fix typo.
1365
6e777848
GM
13662012-07-12 Glenn Morris <rgm@gnu.org>
1367
3f922c37
GM
1368 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1369 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1370 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1371 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1372
0ab7b23a
GM
1373 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1374 Move PTY_OPEN to configure.
1375
6e777848
GM
1376 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1377 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1378 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1379
4a7edc24
DA
13802012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1381
1382 Use empty_unibyte_string where applicable.
1383 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1384 * lread.c (read1): Likewise.
1385 * xsettings.c (syms_of_xsettings): Likewise.
1386
308aab79
GM
13872012-07-12 Glenn Morris <rgm@gnu.org>
1388
42bd1719
GM
1389 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1390 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1391 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1392 * s/hpux10-20.h (RUN_TIME_REMAP):
1393 * s/bsd-common.h (TABDLY): Move to configure.
1394
1395 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1396
1397 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1398
ea0bbd17 1399 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1400 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1401
1402 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1403
308aab79
GM
1404 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1405 * s/template.h: Move NARROWPROTO to configure.
1406
ee1cf5cf
GM
14072012-07-11 Glenn Morris <rgm@gnu.org>
1408
30fe9bf4
GM
1409 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1410 unused since 2011-01-17 change to systty.h.
1411
ee1cf5cf
GM
1412 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1413 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1414 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1415
63e47e07
PE
14162012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1417
1418 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1419
c43fb4c3
GM
14202012-07-11 Glenn Morris <rgm@gnu.org>
1421
1422 * s/darwin.h, s/gnu-linux.h, s/template.h:
1423 Move INTERRUPT_INPUT to configure.
1424
e8df9267
DA
14252012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1426
1427 Minor adjustments to interning code.
1428 * lisp.h (intern, intern_c_string): Redefine as static inline
1429 wrappers for intern_1 and intern_c_string_1, respectively.
1430 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1431 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1432 Vobarray checking.
e8df9267
DA
1433 * font.c (font_intern_prop): Likewise. Adjust comment.
1434 * w32font.c (intern_font_name): Likewise.
1435
34348bd4
AS
14362012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1437
d96a1e0c
AS
1438 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1439
34348bd4
AS
1440 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1441 of Fcar/Fcdr if possible.
1442 * font.c (check_otf_features): Likewise.
1443 * fontset.c (Fnew_fontset): Likewise.
1444 * gnutls.c (Fgnutls_boot): Likewise.
1445 * minibuf.c (read_minibuf): Likewise.
1446 * msdos.c (IT_set_frame_parameters): Likewise.
1447 * xmenu.c (Fx_popup_dialog): Likewise.
1448 * w32menu.c (Fx_popup_dialog): Likewise.
1449
c8add24e
GM
14502012-07-11 Glenn Morris <rgm@gnu.org>
1451
4b575b3c
GM
1452 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1453 since nothing has defined it on these platforms.
1454
09f4e3b0
GM
1455 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1456 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1457
172bedef
GM
1458 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1459 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1460 Move CLASH_DETECTION to configure.
1461
249685df
GM
1462 * s/gnu.h: Remove file, which is now empty.
1463
c8add24e
GM
1464 * s/gnu.h, s/gnu-linux.h:
1465 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1466
b41253a3
JW
14672012-07-11 John Wiegley <johnw@newartisans.com>
1468
1469 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1470 function attribute, so we only use it if it exists in the
1471 compiler.
1472
d923b542
DA
14732012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1474
1475 Avoid call to strlen in fast_c_string_match_ignore_case.
1476 * search.c (fast_c_string_match_ignore_case): Change to use
1477 length argument. Adjust users accordingly.
1478 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1479
5ebbef1d
PE
14802012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1481
bb352260
PE
1482 Assume mkdir, rmdir.
1483 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1484 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1485
57054ddd
PE
1486 Assume rename.
1487 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1488
b747d3f7
PE
1489 Assume perror.
1490 * s/hpux10-20.h (HAVE_PERROR): Remove.
1491 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1492 Remove dummy definition, as this problem was obsolete long ago.
1493
5ebbef1d
PE
1494 Assume strerror.
1495 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1496
984e7f30
DA
14972012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1498
1499 Avoid calls to strlen in font processing functions.
1500 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1501 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1502 users accordingly.
d923b542
DA
1503 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1504 Adjust prototypes.
1505 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1506 Change to return ptrdiff_t.
984e7f30
DA
1507 (xfont_list_pattern, xfont_match): Use length returned by
1508 xfont_decode_coding_xlfd.
1509 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1510
20e94fdd
GM
15112012-07-11 Glenn Morris <rgm@gnu.org>
1512
9d596af3
GM
1513 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1514 Move DONT_REOPEN_PTY to configure.
1515
20e94fdd
GM
1516 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1517 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1518
e99a530f
PE
15192012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1520
22ffb973
PE
1521 Remove "#define unix" that is no longer needed (Bug#11905).
1522 * s/aix4-2.h (unix): Remove; no longer needed.
1523
e9a9ae03
PE
1524 EMACS_TIME simplification (Bug#11875).
1525 This replaces macros (which typically do not work in GDB)
1526 with functions, typedefs and enums, making the code easier to debug.
1527 The functional style also makes code easier to read and maintain.
1528 * systime.h: Include <sys/time.h> on all hosts, not just if
1529 WINDOWSNT, since 'struct timeval' is needed in general.
1530 (EMACS_TIME): Now a typedef, not a macro.
1531 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1532 not macros.
1533 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1534 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1535 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1536 (EMACS_TIME_LE): Now functions, not macros.
1537 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1538 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1539 which are not functions. All uses rewritten to use:
1540 (make_emacs_time): New function.
1541 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1542 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1543 not functions. All uses rewritten to use the following, respectively:
1544 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1545 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1546 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1547 * fileio.c (Fcopy_file):
1548 * xterm.c (XTflash): Get the current time closer to when it's used.
1549 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1550
ffacb126
PE
1551 * bytecode.c (targets): Suppress -Woverride-init warnings.
1552
e99a530f
PE
1553 Simplify by avoiding confusing use of strncpy etc.
1554 * doc.c (Fsnarf_documentation):
1555 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1556 * frame.c (Fmake_terminal_frame):
1557 * gtkutil.c (get_utf8_string):
1558 * lread.c (openp):
1559 * nsmenu.m (ns_update_menubar):
1560 * regex.c (regerror):
1561 Prefer memcpy to strncpy and strncat when either will do.
1562 * fileio.c (Fsubstitute_in_file_name):
1563 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1564 (menu_separator_name_p):
1565 * nsmenu.m (ns_update_menubar):
1566 Prefer memcmp to strncmp when either will do.
1567 * nsterm.m: Include <ftoastr.h>.
1568 (ns_get_color):
1569 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1570 Prefer snprintf to strncpy.
1571 * nsterm.m (ns_term_init):
1572 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1573 * nsterm.m (ns_term_init):
1574 Avoid the need for strncpy, by using build_string or
1575 make_unibyte_string directly. Use dtoastr, not snprintf.
1576 * process.c (Fmake_network_process): Diagnose service names that
1577 are too long, rather than silently truncating them or creating
1578 non-null-terminated names.
1579 (Fnetwork_interface_info): Likewise, for interface names.
1580 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1581 Prefer sprintf to strncat.
1582 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1583 Prefer vsnprintf to vsprintf + strncpy.
1584
c59592b3
GM
15852012-07-10 Glenn Morris <rgm@gnu.org>
1586
1587 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1588 Clarify fallback case.
1589
7d7bbefd
DA
15902012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1591
1592 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1593 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1594 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1595 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1596 where argument type is known to be a Lisp_Cons.
1597
3a4c8000
TT
15982012-07-10 Tom Tromey <tromey@redhat.com>
1599
1600 * bytecode.c (BYTE_CODE_THREADED): New macro.
1601 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1602 (enum byte_code_op): New type.
1603 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1604 (exec_byte_code): Use them. Use token threading when applicable.
1605
2a0213a6
DA
16062012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1607
1608 Optimize pure C strings initialization.
1609 * lisp.h (make_pure_string): Fix prototype.
1610 (build_pure_c_string): New function, defined as static inline. This
1611 provides a better opportunity to optimize away calls to strlen when
1612 the function is called with compile-time constant argument.
1613 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1614 argument, adjust users accordingly. Use build_pure_c_string where
1615 appropriate.
1616 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1617 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1618 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1619
cb1caeaf
DA
16202012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1621
1622 Avoid calls to strlen in miscellaneous functions.
1623 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1624 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1625 * lread.c (openp): Likewise.
1626
c293e30c
DA
16272012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1628
1629 Avoid calls to strlen in path processing functions.
1630 * fileio.c (file_name_as_directory): Add comment. Change to add
1631 srclen argument and return the length of result. Adjust users
1632 accordingly.
1633 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1634 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1635 users accordingly.
1636 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1637
9e059e3f
GM
16382012-07-10 Glenn Morris <rgm@gnu.org>
1639
d02eb359
GM
1640 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1641 Move PENDING_OUTPUT_COUNT definition to configure.
1642
882cf227
GM
1643 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1644 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1645 * s/gnu.h (DATA_START): Move definitions to configure.
1646
af6e839f
GM
1647 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1648 We include usg5-4-common.h, which defines them both.
1649
40289a12
GM
1650 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1651 O_RDONLY already includes it).
1652
9e059e3f
GM
1653 Stop ns builds setting the EMACSLOADPATH environment variable.
1654 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1655 Now it does not set EMACSLOADPATH, just returns the load-path string.
1656 * nsterm.h: Update accordingly.
1657 * lread.c [HAVE_NS]: Include nsterm.h.
1658 (init_lread) [HAVE_NS]: Use ns_load_path.
1659 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1660
7c4e8ec0
GM
16612012-07-09 Glenn Morris <rgm@gnu.org>
1662
d4f600ff
GM
1663 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1664 since the included bsd-common.h does so.
1665
cbb31951
GM
1666 Stop ns builds setting the EMACSPATH environment variable.
1667 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1668 (ns_init_paths): Do not set EMACSPATH.
1669 * nsterm.h (ns_exec_path): Add it.
1670 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1671 Use ns_exec_path.
1672
7c4e8ec0
GM
1673 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1674
26bccfae
PE
16752012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1676
a0bee46f
PE
1677 * process.c (wait_reading_process_output): 'waitchannels' was unset
1678 when read_kbd || !NILP (wait_for_cell); fix this.
1679
5994c183
PE
1680 Add GCC-style 'const' attribute to functions that can use it.
1681 * character.h (char_resolve_modifier_mask):
1682 * keyboard.h (make_ctrl_char):
1683 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1684 (init_character_once, next_almost_prime, init_fns, init_image)
1685 (flush_pending_output, init_sound):
1686 * mem-limits.h (start_of_data):
1687 * menu.h (finish_menu_items):
1688 Add ATTRIBUTE_CONST.
1689 * emacs.c (DEFINE_DUMMY_FUNCTION):
1690 Declare the dummy function with ATTRIBUTE_CONST.
1691 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1692 Add decls with ATTRIBUTE_CONST.
1693
26bccfae
PE
1694 Minor improvements to make_formatted_string.
1695 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1696 where int is good enough, as vsprintf returns an int.
1697 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1698
a8290ec3
DA
16992012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1700
1701 Use make_formatted_string to avoid double length calculation.
1702 * lisp.h (make_formatted_string): New prototype.
1703 * alloc.c (make_formatted_string): New function.
1704 * buffer.c (Fgenerate_new_buffer_name): Use it.
1705 * dbus.c (syms_of_dbusbind): Likewise.
1706 * editfns.c (Fcurrent_time_zone): Likewise.
1707 * filelock.c (get_boot_time): Likewise.
1708 * frame.c (make_terminal_frame, set_term_frame_name)
1709 (x_report_frame_params): Likewise.
1710 * image.c (gs_load): Likewise.
1711 * minibuf.c (get_minibuffer): Likewise.
1712 * msdos.c (dos_set_window_size): Likewise.
1713 * process.c (make_process): Likewise.
1714 * xdisp.c (ensure_echo_area_buffers): Likewise.
1715 * xsettings.c (apply_xft_settings): Likewise.
1716
d01ba2f1
GM
17172012-07-09 Glenn Morris <rgm@gnu.org>
1718
1719 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1720 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1721 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1722 * nsterm.h (ns_etc_directory): Add it.
1723 * callproc.c [HAVE_NS]: Include nsterm.h.
1724 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1725
f1f924b6
DA
17262012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1727
1728 Move marker debugging code under MARKER_DEBUG.
1729 * marker.c (MARKER_DEBUG): Move marker debugging code under
1730 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1731 for bootstrap with --enable-checking (~3x slowdown reported
1732 by Juanma Barranquero <lekktu@gmail.com>).
1733 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1734
ab531b66
PE
17352012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1736
1737 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1738 See <http://bugs.gnu.org/11825#29>.
1739
c4b3bc8a
EZ
17402012-07-08 Eli Zaretskii <eliz@gnu.org>
1741
1742 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1743 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1744 (display_line): Add commentary about displaying truncation glyphs
1745 on GUI frames.
1746 (produce_special_glyphs): Move here from term.c.
1747
1748 * term.c (produce_special_glyphs): Move to xdisp.c.
1749
1750 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1751 section.
c4b3bc8a 1752
b676b881
AS
17532012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1754
f17c5273
AS
1755 * xdisp.c (display_line): Avoid warning about implicit declaration
1756 of FRAME_FONT.
1757
298819b9
AS
1758 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1759
b676b881
AS
1760 * lisp.h: Remove empty conditional.
1761
6045c4fd
PE
17622012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1763
b3350bf9
PE
1764 * lread.c (load_path_check): Now static.
1765
6045c4fd
PE
1766 Fix some minor --with-ns problems found by static checking.
1767 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1768 (x_set_font) [!HAVE_X_WINDOWS]:
1769 * image.c (xpm_load_image) [HAVE_NS]:
1770 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1771 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1772 Remove unused local.
1773 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1774 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1775 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1776 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1777 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1778 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1779 Fix pointer signedness problem.
1780 * xfaces.c (FRAME_X_FONT_TABLE):
1781 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1782
929e7845
GM
17832012-07-07 Glenn Morris <rgm@gnu.org>
1784
1785 * lread.c (load_path_check): New function, split from init_lread.
1786 (init_lread): Reorganize. Motivation:
1787 If EMACSLOADPATH is set, check/warn about that rather than the
1788 defaults, which we are not going to use. Hence we can remove
1789 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1790 Don't warn if site-lisp directories are missing.
1791 If not installed, start from a blank load-path, since
1792 PATH_LOADSEARCH refers to the eventual installation directories.
1793
58dd0aa4
EZ
17942012-07-07 Eli Zaretskii <eliz@gnu.org>
1795
1796 Support truncation and continuation glyphs on GUI frames, when
1797 fringes are disabled. (Bug#11832)
1798 * xdisp.c (init_iterator): Get dimensions of truncation and
1799 continuation glyphs even if on GUI frames. Adjust
1800 it->last_visible_x on GUI frames when the left or right fringes,
1801 or both, are absent.
1802 (start_display, move_it_in_display_line_to): Handle the case of a
1803 GUI frame without a fringe to display continuation or truncation
1804 glyphs.
1805 (insert_left_trunc_glyphs): Support GUI frames: make sure
1806 truncation glyphs overwrite enough glyphs from the current line to
1807 have sufficient space in pixels.
1808 (display_line): Support truncation and continuation glyphs on GUI
1809 frames. If some spare pixels are left on the line after inserting
1810 the truncation glyphs, fill that space with a stretch glyph of a
1811 suitably computed width.
1812
1813 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1814 produce_glyphs, to support GUI sessions.
1815
31571fd7
PE
18162012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1817
5a16b9bc
PE
1818 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1819
f3047c75
PE
1820 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1821
31571fd7
PE
1822 Do not require float-time's arg to fit in time_t (Bug#11825).
1823 This works better on hosts where time_t is unsigned, and where
1824 float-time is applied to the (negative) difference between two times.
1825 * editfns.c (decode_time_components): Last arg is now double *,
1826 not int *, and means to store all the result as a double, without
1827 worrying about whether the seconds part fits in time_t.
1828 All callers changed.
1829 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1830 All callers changed.
1831 (Ffloat_time): Do not fail merely because the specified time falls
1832 outside of time_t range.
1833
4516fbef
GM
18342012-07-07 Glenn Morris <rgm@gnu.org>
1835
1836 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1837 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1838 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1839
07adc2c6
JB
18402012-07-07 Juanma Barranquero <lekktu@gmail.com>
1841
1842 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1843 Update dependencies.
1844
1845 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1846
fd573f31
PE
18472012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1848
fee5959d
PE
1849 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1850 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1851 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1852 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1853 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1854 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1855
fd573f31
PE
1856 * xfont.c (compare_font_names): Redo to omit the need for casts.
1857
ddadbc0e
AS
18582012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1859
fca8d6b6
AS
1860 * xfns.c (Fx_change_window_property): Doc fix.
1861 * w32fns.c (Fx_change_window_property): Doc fix.
1862
ddadbc0e
AS
1863 * w32fns.c (Fx_window_property): Accept the same arguments as the
1864 X Windows version. Doc fix.
1865 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1866
ed9265fc 18672012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1868 Eli Zaretskii <eliz@gnu.org>
1869
1870 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1871 Windows-specific code from nt/config.nt moved here.
1872 Obsolete settings removed.
1873
216ee680
PE
18742012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1875
1876 * process.c: Avoid unnecessary calls to gettime.
1877 (wait_reading_process_output): Don't get the time of day
1878 when gobbling data immediately and not waiting, as there's no need
1879 for it in that case. This removes a FIXME.
1880
bdd091e4
JD
18812012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1882
1883 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1884 is defined (Bug#11768).
1885
9d44f8ce
DA
18862012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1887
1888 Fix marker debugging code.
1889 * marker.c (byte_char_debug_check): Do not perform the check
1890 if buffer is not multibyte.
090bd7cb
JB
1891 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1892 Call byte_char_debug_check with correct arguments.
9d44f8ce 1893
90fc4786
DA
18942012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1895
1896 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1897 * marker.c (byte_char_debug_check, count_markers):
1898 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1899 (byte_debug_flag): Remove.
1900 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1901 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1902
7b7ae965
DA
19032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1904
4e57b342
DA
1905 Avoid code repetition in marker-related functions.
1906 * marker.c (attach_marker): New function.
1907 (Fset_marker, set_marker_restricted, set_marker_both)
1908 (set_marker_restricted_both): Use it.
1909 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1910 Consistently rename charno to charpos.
1911 (marker_position): Add eassert.
1912 (marker_byte_position): Convert to eassert.
1913
19142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1915
1916 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1917 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1918 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1919
657924ff
DA
19202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1921
1922 Introduce fast path for the widely used marker operation.
1923 * alloc.c (build_marker): New function.
1924 * lisp.h (build_marker): New prototype.
1925 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1926 * composite.c (autocmp_chars): Likewise.
1927 * editfns.c (buildmark): Remove.
1928 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1929 (save_restriction_save): Use build_marker.
1930 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1931 * window.c (save_window_save): Likewise.
1932
041a49a6
DA
19332012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1934
1935 Do not use Fdelete_overlay in delete_all_overlays
1936 to avoid redundant calls to unchain_overlay.
1937 * buffer.c (drop_overlay): New function.
1938 (delete_all_overlays, Fdelete_overlay): Use it.
1939 * minibuf.c (get_minibuffer): Fix comment.
1940
7dca65a4
PE
19412012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1942
1943 Port to OpenBSD 5.1 amd64.
1944 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1945 This is needed for OpenBSD, and should be harmless on all BSD systems.
1946 Also, include <sys/sysctl.h>, as it should be available on all
1947 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1948 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1949 use p_pid member, not kp_proc.pid.
1950
8eb876e2
GM
19512012-07-06 Glenn Morris <rgm@gnu.org>
1952
1953 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1954
38182d90
PE
19552012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1956
1957 More xmalloc and related cleanup.
1958 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1959 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1960 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1961 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1962 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1963 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1964 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1965 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1966 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1967 * xterm.c:
1968 Omit needless casts involving void * pointers and allocation.
1969 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1970 as the former is more robust if P's type is changed.
1971 Prefer xzalloc to xmalloc + memset 0.
1972 Simplify malloc-or-realloc to realloc.
1973 Don't worry about xmalloc returning a null pointer.
1974 Prefer xstrdup to xmalloc + strcpy.
1975 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1976 growing it.
1977 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1978 alloca of a constant.
1979
6dd5a677
EZ
19802012-07-05 Eli Zaretskii <eliz@gnu.org>
1981
1982 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1983 hscroll is larger than the line width. Fixes long and futile
1984 looping inside extend_face_to_end_of_line (on a TTY) producing
1985 glyphs that are not needed and thrown away.
1986
6b312f0f
DA
19872012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1988
1989 * marker.c (set_marker_restricted_both): Simplify by using
1990 clip_to_bounds.
1991
f520ef9b
PE
19922012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1993
1994 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1995
383b7c95
JD
19962012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1997
1998 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1999 not defined (Bug#11768).
2000 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2001 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2002 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2003 followed by gtk_box_set_homogeneous (Bug#11768).
2004 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2005 (update_theme_scrollbar_width, xg_create_scroll_bar):
2006 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2007 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2008 (is_box_type): New function (Bug#11768).
2009 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2010 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2011 with default display (Bug#11768).
2012
d6e7bf45
EZ
20132012-07-05 Eli Zaretskii <eliz@gnu.org>
2014
2015 * xdisp.c (window_hscroll_limited): New function.
2016 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2017 coordinates when window's hscroll is set to insanely large
2018 values. (Bug#11857)
2019
431391ec
JB
20202012-07-05 Juanma Barranquero <lekktu@gmail.com>
2021
2022 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2023 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2024
23f86fce
DA
20252012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2026
2027 Cleanup xmalloc.
2028 * lisp.h (xzalloc): New prototype. Omit needless casts.
2029 * alloc.c (xzalloc): New function. Omit needless casts.
2030 * charset.c: Omit needless casts. Convert all calls to
2031 xmalloc with following memset to xzalloc.
2032 * dispnew.c: Likewise.
2033 * fringe.c: Likewise.
2034 * image.c: Likewise.
2035 * sound.c: Likewise.
2036 * term.c: Likewise.
2037 * w32fns.c: Likewise.
2038 * w32font.c: Likewise.
2039 * w32term.c: Likewise.
2040 * xfaces.c: Likewise.
2041 * xfns.c: Likewise.
2042 * xterm.c: Likewise.
2043 * atimer.c: Omit needless casts.
2044 * buffer.c: Likewise.
2045 * callproc.c: Likewise.
2046 * ccl.c: Likewise.
2047 * coding.c: Likewise.
2048 * composite.c: Likewise.
2049 * doc.c: Likewise.
2050 * doprnt.c: Likewise.
2051 * editfns.c: Likewise.
2052 * emacs.c: Likewise.
2053 * eval.c: Likewise.
2054 * filelock.c: Likewise.
2055 * fns.c: Likewise.
2056 * gtkutil.c: Likewise.
2057 * keyboard.c: Likewise.
2058 * lisp.h: Likewise.
2059 * lread.c: Likewise.
2060 * minibuf.c: Likewise.
2061 * msdos.c: Likewise.
2062 * print.c: Likewise.
2063 * process.c: Likewise.
2064 * region-cache.c: Likewise.
2065 * search.c: Likewise.
2066 * sysdep.c: Likewise.
2067 * termcap.c: Likewise.
2068 * terminal.c: Likewise.
2069 * tparam.c: Likewise.
2070 * w16select.c: Likewise.
2071 * w32.c: Likewise.
2072 * w32reg.c: Likewise.
2073 * w32select.c: Likewise.
2074 * w32uniscribe.c: Likewise.
2075 * widget.c: Likewise.
2076 * xdisp.c: Likewise.
2077 * xmenu.c: Likewise.
2078 * xrdb.c: Likewise.
2079 * xselect.c: Likewise.
2080
0497dc44
PE
20812012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2082
2083 * fileio.c (time_error_value): Check the right error number.
2084 Problem reported by Troels Nielsen in
2085 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2086
356e7178
PE
20872012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2088
4e71fd89
PE
2089 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2090 This should be fixed in a better way; see Eli Zaretskii in
2091 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2092 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2093
f0941253
PE
2094 * fileio.c (time_error_value): Rename from special_mtime.
2095 The old name's problems were noted by Eli Zaretskii in
2096 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2097
065c9eb4
PE
2098 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2099 This variable's comment says Emacs needs at least one GDB-visible
2100 symbol of type enum pvec_type, to work around GDB problems.
2101 The symbol's value doesn't matter.
2102
356e7178
PE
2103 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2104 that causes compilation to fail on pre-C99 compilers.
2105
ed9265fc 21062012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2107
2108 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2109 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2110
3884d954
DA
21112012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2112
d209e2fb 2113 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2114 headers for buffer_defaults and buffer_local_symbols.
2115 Reported by Juanma Barranquero <lekktu@gmail.com>.
2116
ee28be33
SM
21172012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2118
2119 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2120 * lisp.h (enum pvec_type): Use fewer bits.
2121 (PSEUDOVECTOR_SIZE_BITS): New constant.
2122 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2123 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2124 change in pvec_type.
2125 (PSEUDOVECTOR_TYPEP): New macro.
2126 (TYPED_PSEUDOVECTORP): Use it.
2127 * fns.c (internal_equal): Adapt code to extract pvectype.
2128 * emacs.c (gdb_pvec_type): Update type.
2129 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2130 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2131 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2132 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2133 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2134 abusing vector->header.next.nbytes.
2135 (live_vector_p): Use PVEC_TYPE.
2136 (mark_object): Adapt code to extract pvectype. Use switch.
2137
c7f2cd7f
PE
21382012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2139
2140 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2141 Tighten new eassert a bit.
2142
8ce70ed2
DA
21432012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2144
2145 Fix compilation with --enable-gcc-warnings and -O1
2146 optimization level.
2147 * doprnt.c (doprnt): Change type of tem to int, initialize
2148 to avoid compiler warning. Add eassert.
2149 * search.c (simple_search): Initialize match_byte to avoid
2150 compiler warning. Add eassert.
2151
dea7f1e5
PE
21522012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2153
24a212eb
PE
2154 Avoid weird behavior with large horizontal scrolls.
2155 Without this change, for example, large hscroll values would
2156 mess up Emacs's display on Fedora 15 x86, presumably due to
2157 overflows in int calculations in the display code.
2158 Also, if buffers had long lines, Emacs would freeze.
2159 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2160 (set_window_hscroll): New function, containing the old guts of
2161 Fset_window_hscroll. Return the clipped value.
2162 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2163 This avoids the need to check against PTRDIFF_MAX.
2164
dea7f1e5
PE
2165 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2166
76046526
DA
21672012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2168
2169 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2170
39adff0d
PE
21712012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2172
63807d47
PE
2173 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2174 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2175 since GCC 4.4.6 issues a bogus warning for them.
2176
39adff0d
PE
2177 Fix bugs in file timestamp newness comparisons.
2178 * fileio.c (Ffile_newer_than_file_p):
2179 * lread.c (Fload): Use full timestamp resolution of files,
2180 not just the 1-second resolution, so that files that are only
2181 slightly newer still count as newer.
2182 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2183 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2184
dbeed9a6
PE
21852012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2186
2187 * fileio.c: Improve handling of file time marker. (Bug#11852)
2188 (special_mtime): New function.
2189 (Finsert_file_contents, Fverify_visited_file_modtime):
2190 Use it to set special mtime values consistently.
2191
636334d6
AS
21922012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2193
2194 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2195 marker for non-existing file. (Bug#11852)
2196
e2017fe2
GM
21972012-07-03 Glenn Morris <rgm@gnu.org>
2198
2199 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2200 and did not make it into globals.h).
2201
404dbd37
TT
22022012-07-03 Tom Tromey <tromey@redhat.com>
2203
2204 * window.c (Fset_window_margins, Fset_window_fringes)
2205 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2206 * textprop.c (Fprevious_property_change): No longer static.
2207 * syntax.c (Fsyntax_table_p): No longer static.
2208 * process.c (Fget_process, Fprocess_datagram_address): No longer
2209 static.
2210 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2211 * keyboard.c (Fcommand_execute): No longer static.
2212 Remove EXFUN.
2213 * insdel.c (Fcombine_after_change_execute): No longer static.
2214 * image.c (Finit_image_library): No longer static.
2215 * fileio.c (Fmake_symbolic_link): No longer static.
2216 * eval.c (Ffetch_bytecode): No longer static.
2217 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2218 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2219 No longer static.
404dbd37
TT
2220 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2221 static.
2222 * dired.c (Ffile_attributes): No longer static.
2223 * composite.c (Fcomposition_get_gstring): No longer static.
2224 * callproc.c (Fgetenv_internal): No longer static.
2225
2226 * ccl.h: Remove EXFUNs.
2227 * buffer.h: Remove EXFUNs.
2228 * dispextern.h: Remove EXFUNs.
2229 * intervals.h: Remove EXFUNs.
2230 * fontset.h: Remove EXFUN.
2231 * font.h: Remove EXFUNs.
2232 * dosfns.c (system_process_attributes): Remove EXFUN.
2233 * keymap.h: Remove EXFUNs.
2234 * lisp.h: Remove EXFUNs.
2235 * w32term.h: Remove EXFUNs.
2236 * window.h: Remove EXFUNs.
2237 * xsettings.h: Remove EXFUN.
2238 * xterm.h: Remove EXFUN.
2239
8e4fd1e1
GM
22402012-07-03 Glenn Morris <rgm@gnu.org>
2241
2242 * lisp.h (Frandom): Make it visible to C.
2243 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2244 buffer for invisible buffers. (Bug#1229)
2245
ca95b3eb
DA
22462012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2247
2248 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2249 values which aren't power of 2.
2250 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2251 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2252 accordingly.
2253
7555c33f
SM
22542012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2255
2256 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2257
2258 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2259
d12e8f5a
DA
22602012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2261
2262 * alloc.c (allocate_vector_block): Remove redundant
2263 calls to mallopt if DOUG_LEA_MALLOC is defined.
2264 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2265 avoid calls to mallopt if zero_vector is returned.
2266
296094c3
DA
22672012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2268
2269 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2270 is enabled, avoid dereferencing NULL current_sblock if
2271 running undumped.
2272
36429c89
DA
22732012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2274
2275 Cleanup basic buffer management.
2276 * buffer.h (struct buffer): Change layout to use generic vector
2277 marking code. Fix some comments. Change type of 'clip_changed'
2278 to bitfield. Remove unused #ifndef old.
2279 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2280 (GET_OVERLAYS_AT): Fix indentation.
2281 (for_each_per_buffer_object_at): New macro.
2282 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2283 (Fbuffer_local_variables): Use it.
2284 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2285 * alloc.c (allocate_buffer): Adjust to match new layout of
2286 struct buffer. Fix comment.
2287 (mark_overlay): New function.
2288 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2289 Lisp area of struct buffer.
2290 (mark_object): Use it. Adjust marking of misc objects
2291 and related comments.
2292
3b3e4cac
PE
22932012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2294
2295 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2296 wrapper that is not needed because the wrapped code is a no-op (zero
2297 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2298 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2299
cf5c0175
DA
23002012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2301
2302 * alloc.c (mark_buffer): Simplify. Remove prototype.
2303 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2304 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2305 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2306 redundant calls to mark_vectorlike for bool vectors.
2307
ca26824c
GM
23082012-06-30 Glenn Morris <rgm@gnu.org>
2309
2e4c5312
GM
2310 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2311
ca26824c
GM
2312 * epaths.in (PATH_SITELOADSEARCH): New.
2313 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2314 This is rather than relying on --enable-locallisppath elements
2315 having "site-lisp" in their names. (Bug#10208#25, 11658)
2316
0d23c240
EZ
23172012-06-30 Eli Zaretskii <eliz@gnu.org>
2318
c9240d7a
EZ
2319 * w32proc.c (sys_select): Accept and ignore one more argument.
2320
2321 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2322
0d23c240 2323 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2324 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2325
2326 * sysdep.c: Don't include dos.h and dosfns.h.
2327
2328 * process.c (sys_select):
2329 * msdos.c (sys_select): Accept one more argument and ignore it.
2330
2331 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2332 adapt data types and code to that.
2333
2334 * dosfns.c:
2335 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2336 which clashes with the gnulib function of the same name.
2337
af5a5a98
AS
23382012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2339
c5e4379c
AS
2340 * font.c (font_style_to_value, font_style_symbolic)
2341 (font_prop_validate_style): Add type checks for values in
2342 font_style_table.
2343
af5a5a98
AS
2344 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2345 argument.
2346 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2347 uses.
2348
8d38f461
EZ
23492012-06-29 Eli Zaretskii <eliz@gnu.org>
2350
2e5a6631
EZ
2351 * xdisp.c (try_window_id): Undo last change.
2352
8d38f461
EZ
2353 * w32.c (getwd): Adjust commentary about startup_dir.
2354 (init_environment): Always call sys_access, even in non-MSVC
2355 builds. Don't chdir to the directory of the Emacs executable.
2356 This undoes code from 1997 which was justified by the need to
2357 "avoid conflicts when removing and renaming directories". But its
2358 downside was that every relative file name was being interpreted
2359 relative to the directory of the Emacs executable, which can never
2360 be TRT. In particular, it broke sys_access when called with
2361 relative file names.
2362 (sys_access): Map GetLastError to errno.
2363
2af3565e
DA
23642012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2365
2366 * window.h (struct window): Change type of 'fringes_outside_margins'
2367 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2368 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2369 Adjust comment.
2370 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2371 to ptrdiff_t.
2372
c8d3a25c 23732012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2374
c8d3a25c
GM
2375 * gnutls.c (emacs_gnutls_handshake):
2376 Add QUIT to make the loop interruptible.
57570cd3 2377
c8d3a25c 23782012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2379
c8d3a25c
GM
2380 * charset.c (init_charset): Make lack of etc/charsets fatal.
2381
3e984ee8
DA
23822012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2383
2384 * editfns.c (region_limit): Fix type mismatch.
2385
ef884f23
DA
23862012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2387
2388 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2389 undefined. Convert from xassert to eassert.
2390 * nsmenu.m: Convert from xassert to eassert.
2391 * nsterm.m: Likewise.
2392
7d7e0027
SM
23932012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2394
2395 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2396
aa754e6a
PE
23972012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2398
2399 Avoid integer overflow on scroll-left and scroll-right.
2400 * window.c (HSCROLL_MAX): New macro.
2401 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2402 overflow when requested scroll falls outside ptrdiff_t range.
2403
80b00b08
DA
24042012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2405
2406 * window.h (struct window): Change type of 'hscroll',
2407 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2408 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2409 Adjust users accordingly.
2410 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2411 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2412 from EMACS_INT to ptrdiff_t.
2413 (make_window): Omit redundant initialization.
2414
62b2bcf6
JB
24152012-06-28 Juanma Barranquero <lekktu@gmail.com>
2416
2417 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2418
45942c7d
DA
24192012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2420
2421 * window.h (struct window): Change type of 'use_time' and
2422 'sequence_number' from Lisp_Object to int.
2423 * frame.c (make_frame): Adjust users accordingly.
2424 * print.c (print_object): Likewise.
2425 * window.c (select_window, Fwindow_use_time, make_parent_window)
2426 (make_window): Likewise.
2427
e509cfa6
DA
24282012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2429
2430 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2431 enabled with --enable-checking=[all,glyphs] configure option.
2432 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2433 adjust comments accordingly.
2434 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2435 undefined, adjust comments accordingly.
2436 * image.c: Likewise.
2437 * scroll.c: Likewise.
2438 * w32fns.c: Likewise.
2439 * w32term.c: Likewise.
2440 * xdisp.c: Likewise.
2441 * xfaces.c: Likewise.
2442 * xfns.c: Likewise.
2443 * xterm.c: Likewise.
2444
a54e2c05
DA
24452012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2446
2447 Generalize run-time debugging checks.
2448 * dispextern.h (XASSERTS): Remove.
2449 * fontset.c (xassert): Remove.
2450 Convert from xassert to eassert.
2451 * alloc.c: Convert from xassert to eassert.
2452 * bidi.c: Likewise.
2453 * dispnew.c: Likewise.
2454 * fns.c: Likewise.
2455 * fringe.c: Likewise.
2456 * ftfont.c: Likewise.
2457 * gtkutil.c: Likewise.
2458 * image.c: Likewise.
2459 * keyboard.c: Likewise.
2460 * menu.c: Likewise.
2461 * process.c: Likewise.
2462 * scroll.c: Likewise.
2463 * sound.c: Likewise.
2464 * term.c: Likewise.
2465 * w32console.c: Likewise.
2466 * w32fns.c: Likewise.
2467 * w32term.c: Likewise.
2468 * window.c: Likewise.
2469 * xdisp.c: Likewise.
2470 * xfaces.c: Likewise.
2471 * xfns.c: Likewise.
2472 * xselect.c: Likewise.
2473 * xterm.c: Likewise.
2474
1ec4b7b2
SM
24752012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2476
2477 * fns.c (maybe_resize_hash_table): Output message when growing the
2478 purify-hashtable.
2479
2014308a
DA
24802012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2481
2482 * alloc.c (allocate_string_data): Remove dead code.
2483 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2484 avoid GCC warning about unused macro.
2485
246155eb
DA
24862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2487
2488 * alloc.c (allocate_string): Omit intervals initialization.
2489 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2490 as in make_pure_string and make_pure_c_string.
2491
43184b7b
DA
24922012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2493
d209e2fb 2494 * alloc.c (allocate_string): Fix last change.
43184b7b 2495
3fe6dd74
DA
24962012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2497
d209e2fb 2498 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2499 to memset, add explicit initialization where appropriate.
2500
1ba6038a
GM
25012012-06-27 Glenn Morris <rgm@gnu.org>
2502
2503 * lisp.mk (lisp): Remove paths.elc.
2504
c89926a5
CY
25052012-06-27 Chong Yidong <cyd@gnu.org>
2506
2507 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2508
ed6b3510
JW
25092012-06-26 John Wiegley <johnw@newartisans.com>
2510
1ec4b7b2 2511 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2512 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2513
ed6b3510
JW
2514 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2515 when building with Clang.
2516
8edd4a2b
SM
25172012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2518
2519 * eval.c (Fapply): Allow calling it with a single argument.
2520
f6f62d1b
EZ
25212012-06-26 Eli Zaretskii <eliz@gnu.org>
2522
2523 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2524 _stricmp and _strnicmp.
2525 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2526
62efea5e
DA
25272012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2528
2529 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2530 allocated window.
2531 (allocate_process): Likewise for new process.
8edd4a2b 2532 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2533 (allocate_frame): Likewise.
2534 * frame.c (make_frame): Omit redundant initialization.
2535 * window.c (make_parent_window): Use memset.
2536 (make_window): Omit redundant initialization.
2537 * process.c (make_process): Omit redundant initialization.
2538 * terminal.c (create_terminal): Likewise.
2539
42997f4d
DA
25402012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2541
2542 * term.c (delete_tty): Remove redundant call to memset.
2543
1130ecfc
DA
25442012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2545
2546 * alloc.c: Remove build_string.
2547 * lisp.h: Define build_string as static inline. This provides
2548 a better opportunity to optimize away calls to strlen when the
2549 function is called with compile-time constant argument.
2550 * image.c (imagemagick_error): Convert to build_string.
2551 * w32proc.c (sys_spawnve): Likewise.
2552 * xterm.c (x_term_init): Likewise.
2553
cf38a720
PE
25542012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2555
99027bdd
PE
2556 Use sprintf return value instead of invoking strlen on result.
2557 In the old days this wasn't portable, since some sprintf
2558 implementations returned char *. But they died out years ago and
2559 Emacs already assumes sprintf returns int.
2560 Similarly for float_to_string.
2561 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2562 * ccl.c (ccl_driver):
2563 * character.c (string_escape_byte8):
2564 * data.c (Fnumber_to_string):
2565 * doprnt.c (doprnt):
2566 * print.c (print_object):
2567 * xdisp.c (message_dolog):
2568 * xfns.c (syms_of_xfns):
2569 Use sprintf or float_to_string result to avoid need to call strlen.
2570 * data.c (Fnumber_to_string):
2571 Use make_unibyte_string, since the string must be ASCII.
2572 * lisp.h, print.c (float_to_string): Now returns int length.
2573 * term.c (produce_glyphless_glyph):
2574 Use sprintf result rather than recomputing it.
2575
cf38a720
PE
2576 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2577 * Makefile.in (ALL_CFLAGS):
2578 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2579 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2580
3511c784
DA
25812012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2582
0a08eb21 2583 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2584 strcasecmp if available.
2585 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2586
fb7da12e
AS
25872012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2588
2589 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2590 Avoid comma operator.
2591 * menu.c (push_submenu_start, push_submenu_end)
2592 (push_left_right_boundary, push_menu_pane): Likewise.
2593 * msdos.c (dos_rawgetc): Likewise.
2594
afa2ffd8
DA
25952012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2596
2597 * xfns.c (xic_create_fontsetname): Remove redundant calls
2598 to memset.
2599
b3b4476b
PE
26002012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2601
4495ff38
PE
2602 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2603 sprintf already null-terminates its output.
2604
b3b4476b
PE
2605 * xfns.c (x_window): Remove redundant cast.
2606
b00876c9
DA
26072012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2608
2609 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2610 `const char *' to `char *' to avoid compiler warning.
2611
d188e26b
PE
26122012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2613
885d1d74
PE
2614 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2615 instead of truncating it to 63 (admittedly a generous limit).
2616
d188e26b
PE
2617 * process.c: Fix spelling and caps in comments.
2618
e2f560b1
DN
26192012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2620
e86db54b 2621 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2622 * sysdep.c (setpgrp): Remove definition, not used in this file.
2623
7583a3a1
JB
26242012-06-24 Juanma Barranquero <lekktu@gmail.com>
2625
2626 * makefile.w32-in: Update dependencies.
2627
696056c2
EZ
26282012-06-24 Eli Zaretskii <eliz@gnu.org>
2629
2630 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2631 (SYSTIME_H): Add nt/inc/sys/time.h.
2632
2633 * systime.h [WINDOWSNT]: Include sys/time.h.
2634
2635 * s/ms-w32.h (struct timespec): Definition moved from
2636 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2637
845ca893
PE
26382012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2639
2640 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2641 * buffer.h (buffer_slot_type_mismatch):
2642 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2643 * eval.c (unwind_to_catch):
2644 * image.c (my_png_error, my_error_exit):
2645 * keyboard.c (quit_throw_to_read_char, user_error)
2646 (Fexit_recursive_edit, Fabort_recursive_edit):
2647 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2648 (wrong_type_argument, buffer_overflow, __executable_start)
2649 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2650 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2651 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2652 (fatal):
2653 (child_setup) [!DOS_NT]:
2654 * lread.c (end_of_file_error, invalid_syntax):
2655 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2656 * puresize.h (pure_write_error):
2657 * search.c (matcher_overflow):
2658 * sound.c (sound_perror, alsa_sound_perror):
2659 * sysdep.c, syssignal.h (croak):
2660 * term.c (maybe_fatal, vfatal):
2661 * textprop.c (text_read_only):
2662 * undo.c (user_error):
2663 * unexmacosx.c (unexec_error):
2664 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2665 Use _Noreturn rather than NO_RETURN.
2666 No need for separate decl merely because of _Noreturn.
2667 * sound.c (sound_warning, parse_sound):
2668 Remove unnecessary forward decls.
2669
f1dd8073
PE
26702012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2671
2672 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2673 * lisp.h (WAIT_READING_MAX): New macro.
2674 * dispnew.c (Fsleep_for, sit_for):
2675 * keyboard.c (kbd_buffer_get_event):
2676 * process.c (Faccept_process_output):
2677 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2678 This improves on the previous patch, which introduced a bug
2679 when time_t is unsigned and as wide as intmax_t.
2680 See <http://bugs.gnu.org/9000#51>.
2681
b82c1755
EZ
26822012-06-23 Eli Zaretskii <eliz@gnu.org>
2683
2684 * dispnew.c (sit_for, Fsleep_for):
2685 * keyboard.c (kbd_buffer_get_event):
2686 * process.c (Faccept_process_output): Avoid compiler warnings when
2687 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2688
ca300656
JB
26892012-06-23 Juanma Barranquero <lekktu@gmail.com>
2690
049ec95b
JB
2691 * makefile.w32-in: Update dependencies.
2692
ca300656
JB
2693 * w32.c (ltime): Add return type and declare static.
2694 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2695
db7b8d06
PE
26962012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2697
2698 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2699 Privately reported by Herbert J. Skuhra.
2700 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2701 All uses changed.
2702 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2703 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2704
0bd8297f
EZ
27052012-06-23 Eli Zaretskii <eliz@gnu.org>
2706
96512555
EZ
2707 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2708 last argument of make_unibyte_string.
2709
0bd8297f
EZ
2710 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2711 language ID in the event parameters.
2712
2713 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2714 event.code, not the obscure "character set ID".
2715
63def6b6
CY
27162012-06-23 Chong Yidong <cyd@gnu.org>
2717
2718 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2719
e8a02204
EZ
27202012-06-23 Eli Zaretskii <eliz@gnu.org>
2721
388cdec0
EZ
2722 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2723 * w32.c (fdutimens): New function.
2724
2725 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2726
2727 * s/ms-w32.h (pselect): Redirect to sys_select.
2728
2729 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2730
e8a02204
EZ
2731 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2732 in the logic of incrementing and decrementing the value of
2733 use_relocatable_buffers.
2734
d054f3fb
PE
27352012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2736
2737 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2738 Privately reported by Herbert J. Skuhra.
2739 [__FreeBSD__]: Remove "*/" typo after "#include".
2740 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2741 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2742 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2743 Don't assume EMACS_TIME and struct timeval are the same type.
2744
d35af63c
PE
27452012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2746
2747 Support higher-resolution time stamps (Bug#9000).
2748 The time stamps are only nanosecond-resolution at the C level,
2749 since that's the best that any real-world system supports now.
2750 But they are picosecond-resolution at the Lisp level, as that's
2751 easy, and leaves room for future OS improvements.
2752
2753 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2754 (LIBES): Use it.
2755
2756 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2757 Don't get current time unless it's needed.
2758
2759 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2760 now provides it if it's absent.
2761 (start_atimer): Port to higher-res time stamps.
2762 Check for time stamp overflow. Don't get current time more
2763 often than is needed.
2764
2765 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2766 Include systime.h, not time.h.
2767 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2768
2769 * dired.c: Include stat-time.h.
2770 (Ffile-attributes): File times now have higher resolution.
2771
2772 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2773 (struct image): Timestamp now has higher resolution.
2774
2775 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2776 has at least microseconds now. All uses removed.
2777 (update_frame, update_single_window, update_window, update_frame_1)
2778 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2779
2780 * editfns.c (time_overflow): Now extern.
2781 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2782 (float-time, Fformat_time_string, Fcurrent_time_string)
2783 (Fcurrent_time_zone): Accept and generate higher-resolution
2784 time stamps.
2785 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2786 (decode_time_components, lisp_seconds_argument): New functions.
2787 (make_time): Now static.
2788 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2789 Report an error if the time is invalid, rather than having the caller
2790 do that.
2791
2792 * fileio.c: Include <stat-time.h>
2793 (Fcopy_file): Copy higher-resolution time stamps.
2794 Prefer to set the time stamp via a file descriptor if that works.
2795 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2796 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2797 (Fvisited_file_modtime, Fset_visited_file_modtime):
2798 Support higher-resolution time stamps.
2799
2800 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2801
2802 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2803
2804 * image.c (prepare_image_for_display, clear_image_cache)
2805 (lookup_image): Port to higer-resolution time stamps.
2806
2807 * keyboard.c (start_polling, bind_polling_period):
2808 Check for time stamp overflow.
2809 (read_char, kbd_buffer_get_event, timer_start_idle)
2810 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2811 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2812 Port to higher-resolution time stamps. Do not assume time_t is signed.
2813 (decode_timer): New function. Timers are now vectors of length 9,
2814 not 8, to accommodate the picosecond component.
2815 (timer_check_2): Use it.
2816
2817 * nsterm.m (select_timeout, timeval_subtract): Remove.
2818 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2819 as they're a bit more accurate and handle overflow better.
2820 (ns_select): Change prototype to be compatible with pselect.
2821 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2822 * nsterm.h (ns_select): Adjust prototype.
2823
2824 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2825 us-resolution time stamps.
2826 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2827
2828 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2829
2830 * lisp.h (time_overflow): New decl.
2831 (wait_reading_process_output): First arg is now intmax_t, not int,
2832 to accommodate larger waits.
2833
2834 * process.h (struct Lisp_Process.read_output_delay):
2835 Now counts nanoseconds, not microseconds.
2836 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2837 EMACS_HAS_USECS.
2838 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2839 (wait_reading_process_output):
2840 Port to ns-resolution time stamps.
2841 (Faccept_process_output, wait_reading_process_output):
2842 Check for time stamp overflow. Do not assume time_t is signed.
2843 (select_wrapper): Remove; we now use pselect.
2844 (Fprocess_attributes): Now generates ns-resolution time stamps.
2845
2846 * sysdep.c: Include utimens.h. Don't include utime.h
2847 or worry about struct utimbuf; gnulib does that for us now.
2848 (gettimeofday): Remove; gnulib provides a substitute.
2849 (make_timeval): New function.
2850 (set_file_times): Now sets ns-resolution time stamps.
2851 New arg FD; all uses changed.
2852 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2853 (system_process_attributes):
2854 Now returns ns-resolution time stamp. All uses changed.
2855 Check for time stamp overflow.
2856
2857 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2858 provides a substitute now.
2859
2860 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2861 since it guarantees struct timespec.
2862 (EMACS_TIME): Now struct timespec, so that we can support
2863 ns-resolution time stamps.
2864 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2865 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2866 (EMACS_USECS): Remove.
2867 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2868 so multiply the arg by 1000 before storing it.
2869 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2870 New macros.
2871 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2872 Port to ns-resolution time stamps.
2873 (EMACS_TIME_NEG_P): Remove; replaced by....
2874 (EMACS_TIME_SIGN): New macro.
2875 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2876 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2877 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2878 (make_timeval, make_lisp_time, decode_time_components): New decls.
2879 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2880 that it mishandled time_t overflow. You can't compare by subtracting!
2881 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2882 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2883
2884 * term.c: Include <sys/time.h>.
2885 (timeval_to_Time): New function, for proper overflow wraparound.
2886 (term_mouse_position, term_mouse_click): Use it.
2887
2888 * undo.c (record_first_change): Support higher-resolution time stamps
2889 in the undo buffer.
2890 (Fprimitive_undo): Use them when restoring time stamps.
2891
2892 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2893 (w32_get_internal_run_time):
2894 Port to higher-resolution Emacs time stamps.
2895 (ltime): Now accepts single 64-bit integer, as that's more convenient
2896 for callers.
2897
2898 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2899
2900 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2901 for compatibility with pselect. Support ns-resolution time stamps.
2902
2903 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2904
2905 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2906 Check for time stamp overflow, and support ns-resolution time stamps.
2907
2908 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2909 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2910 (timeval_subtract): Remove; no longer needed.
2911 (XTflash, XTring_bell, x_wait_for_event):
2912 Port to ns-resolution time stamps. Don't assume time_t is signed.
2913
b6a92dfe
CY
29142012-06-22 Chong Yidong <cyd@gnu.org>
2915
2916 * xdisp.c (x_consider_frame_title): Revert last change.
2917
d251c37c
EZ
29182012-06-22 Eli Zaretskii <eliz@gnu.org>
2919
2920 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2921 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2922 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2923 staticidx goes up to 1597 out of 1600 = 0x640.)
2924
f10deafb
PE
29252012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2926
2927 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2928 Otherwise, the umask might be mistakenly 0 while handling input signals.
2929
ec6de1e2
SM
29302012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2931
2932 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2933
28be1ada
DA
29342012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2935
2936 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2937 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2938 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2939 access to `contents' member of Lisp_Vector objects with AREF and ASET
2940 where appropriate.
2941
c6bf3022
CY
29422012-06-19 Chong Yidong <cyd@gnu.org>
2943
2944 * frame.c (delete_frame): When selecting a frame on a different
2945 text terminal, do not alter the terminal's top-frame.
2946
2947 * xdisp.c (format_mode_line_unwind_data): Record the target
2948 frame's selected window and its terminal's top-frame.
2949 (unwind_format_mode_line): Restore them.
2950 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2951 Callers changed.
2952 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2953 since tty frames can be explicitly named.
2954 (prepare_menu_bars): Likewise.
2955
2956 * term.c (Ftty_top_frame): New function.
2957
defd4196
PE
29582012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2959
2960 Port byte-code-meter to modern targets.
2961 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2962 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2963 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2964 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2965 (METER_1, METER_2): Simplify.
2966
1053a871
SM
29672012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2968
2969 * data.c (Fdefalias): Return `symbol' (bug#11686).
2970
b7e8d081
MR
29712012-06-18 Martin Rudalics <rudalics@gmx.at>
2972
2973 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2974 gets killed during executing of this function (Bug#11665).
2975 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2976 (Vkill_buffer_query_functions): In doc-string say that functions
2977 run by this hook should not change the current buffer.
2978
7ea2b339
PE
29792012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2980
2981 Fix recently-introduced process.c problems found by static checking.
2982 * process.c (write_queue_push, write_queue_pop, send_process):
2983 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2984 (write_queue_pop): Fix pointer signedness problem.
2985 (send_process): Remove unused local.
2986
96a313a1
CY
29872012-06-17 Chong Yidong <cyd@gnu.org>
2988
2989 * xdisp.c (redisplay_internal): No need to redisplay terminal
2990 frames that are not on top.
2991
20ca2e94
TN
29922012-06-17 Troels Nielsen <bn.troels@gmail.com>
2993
2994 * process.c (make_process): Initialize write_queue.
2995 (write_queue_push, write_queue_pop): New functions.
2996 (send_process): Use them to maintain correct ordering of process
2997 writes (Bug#10815).
2998
9a900ca9
PE
29992012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3000
310fbfa8
PE
3001 * lisp.h (eassert): Assume C89 or later.
3002 This removes the need for CHECK.
3003 (CHECK): Remove. Its comments about always evaluating its
3004 argument were confusing, as 'eassert' typically does not evaluate
3005 its argument.
3006
27bb1ca4
PE
3007 * coding.c (produce_chars): Use ptrdiff_t, not int.
3008
9a900ca9
PE
3009 * xterm.c (x_draw_underwave): Check for integer overflow.
3010 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3011
41b7f8bc 30122012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3013
3014 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3015 referenced (Bug#11583).
3016
9b0e3eba
AA
30172012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3018
3019 Implement wave-style variant of underlining.
3020 * dispextern.h (face_underline_type): New enum.
3021 (face): Add field for underline type.
3022 * nsterm.m (ns_draw_underwave): New function.
3023 (ns_draw_text_decoration): Use it.
3024 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3025 New functions.
3026 (x_draw_glyph_string): Use them.
3027 * xfaces.c (Qline, Qwave): New Lisp objects.
3028 (check_lface_attrs, merge_face_ref)
1053a871
SM
3029 (Finternal_set_lisp_face_attribute, realize_x_face):
3030 Handle wave-style underline face attributes.
9b0e3eba
AA
3031 * xterm.c (x_draw_underwave): New function.
3032 (x_draw_glyph_string): Use it.
3033
0fb52f11
JB
30342012-06-16 Juanma Barranquero <lekktu@gmail.com>
3035
3036 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3037 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3038 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3039 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3040 ($(BLD)/w32select.$(O)): Update dependencies.
3041
e5560ff7
AS
30422012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3043
3044 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3045 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3046 * character.c (_fetch_multibyte_char_p): Remove.
3047 * alloc.c: Include "character.h" before "buffer.h".
3048 * bidi.c: Likewise.
3049 * buffer.c: Likewise.
3050 * bytecode.c: Likewise.
3051 * callint.c: Likewise.
3052 * callproc.c: Likewise.
3053 * casefiddle.c: Likewise.
3054 * casetab.c: Likewise.
3055 * category.c: Likewise.
3056 * cmds.c: Likewise.
3057 * coding.c: Likewise.
3058 * composite.c: Likewise.
3059 * dired.c: Likewise.
3060 * dispnew.c: Likewise.
3061 * doc.c: Likewise.
3062 * dosfns.c: Likewise.
3063 * editfns.c: Likewise.
3064 * emacs.c: Likewise.
3065 * fileio.c: Likewise.
3066 * filelock.c: Likewise.
3067 * font.c: Likewise.
3068 * fontset.c: Likewise.
3069 * fringe.c: Likewise.
3070 * indent.c: Likewise.
3071 * insdel.c: Likewise.
3072 * intervals.c: Likewise.
3073 * keyboard.c: Likewise.
3074 * keymap.c: Likewise.
3075 * lread.c: Likewise.
3076 * macros.c: Likewise.
3077 * marker.c: Likewise.
3078 * minibuf.c: Likewise.
3079 * nsfns.m: Likewise.
3080 * nsmenu.m: Likewise.
3081 * print.c: Likewise.
3082 * process.c: Likewise.
3083 * regex.c: Likewise.
3084 * region-cache.c: Likewise.
3085 * search.c: Likewise.
3086 * syntax.c: Likewise.
3087 * term.c: Likewise.
3088 * textprop.c: Likewise.
3089 * undo.c: Likewise.
3090 * unexsol.c: Likewise.
3091 * w16select.c: Likewise.
3092 * w32fns.c: Likewise.
3093 * w32menu.c: Likewise.
3094 * window.c: Likewise.
3095 * xdisp.c: Likewise.
3096 * xfns.c: Likewise.
3097 * xmenu.c: Likewise.
3098 * xml.c: Likewise.
3099 * xselect.c: Likewise.
3100
2f07e6af
EZ
31012012-06-16 Eli Zaretskii <eliz@gnu.org>
3102
1053a871
SM
3103 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3104 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3105 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3106 row.
3107 (handle_face_prop): Use chunk-relative overlay string index when
3108 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3109 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3110 the rightmost. (Bug#11720)
2f07e6af 3111
29b83cec
AS
31122012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3113
3114 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3115 (CATEGORY_MEMBER): Enforce 1/0 value.
3116 * category.c (_temp_category_set): Remove.
3117
4c5501e9
EZ
31182012-06-16 Eli Zaretskii <eliz@gnu.org>
3119
3120 * window.c (Fdelete_other_windows_internal)
3121 (Fdelete_window_internal): Don't access frame's mouse highlight
3122 info of the initial frame. (Bug#11677)
3123
2b570124
PE
31242012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3125
e93864f9
PE
3126 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3127 Assume USE_2_TAGS_FOR_INTS.
3128 (xreload): Adjust $tagmask width to match recent lisp.h change.
3129
2b570124
PE
3130 Simplify lisp.h in minor ways that should not affect code.
3131 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3132 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3133 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3134 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3135 (INTTYPEBITS): New macro, for clarity.
3136 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3137 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3138 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3139 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3140 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3141
81755f69
JB
31422012-06-13 Juanma Barranquero <lekktu@gmail.com>
3143
3144 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3145
16192a57
GM
31462012-06-13 Glenn Morris <rgm@gnu.org>
3147
3148 * s/bsd-common.h (BSD4_3):
3149 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3150
646b5f55
AS
31512012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3152
3153 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3154 instead of union.
3155 (XLI, XIL): Define.
1053a871
SM
3156 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3157 Use them.
3158 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3159 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3160 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3161 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3162 * frame.c (delete_frame): Remove outdated comment.
3163 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3164 USE_LISP_UNION_TYPE.
3165 (Fw32_unregister_hot_key): Likewise.
3166 (Fw32_toggle_lock_key): Likewise.
3167 * w32menu.c (add_menu_item): Likewise.
3168 (w32_menu_display_help): Use XIL instead of checking
3169 USE_LISP_UNION_TYPE.
3170 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3171 (init_heap): Likewise.
3172 * w32term.c (w32_read_socket): Update comment.
3173
1d3823c9
GM
31742012-06-13 Glenn Morris <rgm@gnu.org>
3175
c62ff706
GM
3176 * s/usg5-4-common.h, src/s/unixware.h:
3177 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3178
1d3823c9
GM
3179 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3180
bfe3e0a2
PE
31812012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3182
3183 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3184 * alloc.c (make_number) [!defined make_number]:
3185 Remove, as lisp.h always defines this now.
3186 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3187 (roundup_size): Verify that it is a power of 2.
3188 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3189 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3190 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3191 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3192 USE_LSB_TAG now is always defined to be either 0 or 1.
3193 All uses changed.
3194 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3195 code works fine either way, and efficiency is not a concern here,
3196 as the union type is for debugging, not for production.
3197 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3198 Use an inline function on all platforms when using the union type,
3199 since this is simpler and 'static inline' can be used portably
3200 within Emacs now.
3201 (LISP_INITIALLY_ZERO): New macro.
3202 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3203 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3204
45fa9c0f
GM
32052012-06-12 Glenn Morris <rgm@gnu.org>
3206
b4492cba
GM
3207 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3208
3209 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3210
45fa9c0f
GM
3211 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3212 Move BROKEN_SIGIO to configure.
3213
3214 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3215 Move NO_TERMIO to configure.
3216
0e25d334
CY
32172012-06-12 Chong Yidong <cyd@gnu.org>
3218
3219 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3220 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3221 MagickExportImagePixels is undefined.
3222
43682bb6
PE
32232012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3224
3225 * image.c (imagemagick_load_image): Remove unused label.
3226
a9be7d2b
GM
32272012-06-11 Glenn Morris <rgm@gnu.org>
3228
3229 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3230 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3231 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3232 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3233
3017f87f
SM
32342012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3235
3236 * alloc.c (make_byte_code): New function.
3237 (Fmake_byte_code): Use it. Don't purify here.
3238 * lread.c (read1): Use it as well to avoid extra allocation.
3239
1b9b4cf4
CY
32402012-06-11 Chong Yidong <cyd@gnu.org>
3241
3242 * image.c (imagemagick_load_image): Implement transparency.
3243
95988fcf
AS
32442012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3245
3246 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3247 account for preceding backslashes. (Bug#11663)
3248
cd4eb164
CY
32492012-06-09 Chong Yidong <cyd@gnu.org>
3250
3251 * term.c: Support italics in capable terminals (Bug#9652).
3252 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3253 (turn_on_face): Output using TS_enter_italic_mode if available.
3254 Don't handle unused blinking and alt-charset cases.
3255 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3256 and tty_alt_charset_p cases.
3257 (tty_capable_p, init_tty): Support italics.
3258
3259 * termchar.h (struct tty_display_info): Add field for italics.
3260 Remove unused blink field.
3261
3262 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3263 Handle slant.
3264
3265 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3266 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3267 tty_alt_charset_p. Add tty_italic_p.
3268
ff88beb8
MA
32692012-06-09 Michael Albinus <michael.albinus@gmx.de>
3270
3271 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3272 dbus_type_is_basic if available.
3273 (xd_extract_signed, xd_extract_unsigned): Rename from
3274 extract_signed and extract_unsigned, respectively. Adapt callers.
3275
44286096
CY
32762012-06-09 Chong Yidong <cyd@gnu.org>
3277
1682701f
CY
3278 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3279
44286096
CY
3280 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3281 case (Bug#9752).
3282
d86feb17
PE
32832012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3284
3285 * xdisp.c (vmessage): Treat frame message as multibyte.
3286 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3287 would generate the diagnostic "Making \302\247 buffer-local while
3288 let-bound!".
3289
d5c20fe8
EZ
32902012-06-08 Eli Zaretskii <eliz@gnu.org>
3291
3292 * dispnew.c (showing_window_margins_p): Undo last change, which
3293 was done due to an inadvertent commit.
3294 (adjust_frame_glyphs_for_frame_redisplay): Do call
3295 showing_window_margins_p.
3296
513749ee
SM
32972012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3298
3299 * eval.c (Fmake_var_non_special): New primitive.
3300 (syms_of_eval): Defsubr it.
3301 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3302
d4a8f5c1
JB
33032012-06-08 Juanma Barranquero <lekktu@gmail.com>
3304
3305 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3306 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3307
8bbbc977
EZ
33082012-06-08 Eli Zaretskii <eliz@gnu.org>
3309
3310 * alloc.c (allocate_vectorlike): Fix last change.
3311
f3372c87
DA
33122012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3313
3314 Block-based vector allocation of small vectors.
3315 * lisp.h (struct vectorlike_header): New field `nbytes',
3316 adjust comment accordingly.
3317 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3318 to denote vector blocks. Adjust users (live_vector_p,
3319 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3320 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3321 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3322 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3323 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3324 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3325 (roundup_size): New constant.
3326 (struct vector_block): New data type.
3327 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3328 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3329 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3330 (sweep_vectors): New functions.
3331 (allocate_vectorlike): Return `zero_vector' as the only vector of
3332 0 items. Allocate new vector from block if vector size is less than
3333 or equal to VBLOCK_BYTES_MAX.
3334 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3335 (init_alloc_once): Add call to init_vectors.
3336
4f18a4ed
SM
33372012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3338
3339 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3340
86f158bc
PE
33412012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3342
3343 * doprnt.c (doprnt): Truncate multibyte char correctly.
3344 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3345 would mishandle a string argument "Xc" if X was a multibyte
3346 character of length 2: it would truncate after X's first byte
3347 rather than including all of X.
3348
c5cfcbe0
CY
33492012-06-06 Chong Yidong <cyd@gnu.org>
3350
3351 * buffer.c (word_wrap): Doc fix.
3352
c05cf390
PE
33532012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3354
3355 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3356
0c3461de
GM
33572012-06-03 Glenn Morris <rgm@gnu.org>
3358
3359 * xdisp.c (tool-bar-style): Doc fix.
3360
c71232db
UM
33612012-06-03 Ulrich Müller <ulm@gentoo.org>
3362
3363 * Makefile.in (PAXCTL): Define.
3364 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3365 binary via PaX flags if the paxctl utility is available.
3366 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3367 Restore PaX flags to their default. (Bug#11398)
3368
383f7350
CY
33692012-06-03 Chong Yidong <cyd@gnu.org>
3370
3371 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3372 buffer (Bug#11226).
3373
5f2c76c6
CY
33742012-06-03 Chong Yidong <cyd@gnu.org>
3375
3376 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3377 (note_mode_line_or_margin_highlight): If there is no help echo,
3378 use mode-line-default-help-echo. Handle the case where the mouse
3379 position is past the end of the mode line string.
3380
3381 * buffer.c (buffer_local_value_1): New function, split from
3382 Fbuffer_local_value; can return Qunbound.
3383 (Fbuffer_local_value): Use it.
3384 (Vmode_line_format): Docstring tweaks.
3385
773d47f6
PE
33862012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3387
3388 * sysdep.c (system_process_attributes): Improve comment.
3389
f2d6a3df
SM
33902012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3391
3392 * keyboard.c: Export real-this-command to Elisp.
3393 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3394 and DEFVAR it. Update all users.
3395
63810350
PE
33962012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3397
7bd5c1f4
PE
3398 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3399
63810350
PE
3400 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3401 Convert pctcpu and pctmem to Lisp float properly.
3402 Let the compiler fold better, as 100.0/0x8000 is exact.
3403
a2821611
AS
34042012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3405
3406 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3407 cons_block.
3408
5fceba1d
PE
34092012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3410
3411 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3412
c98ff5dd
DA
34132012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3414
3415 For a 'struct window', replace some Lisp_Object fields to
3416 bitfields where appropriate, remove unused fields.
3417 * window.h (struct window): Remove unused 'last_mark_x' and
3418 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3419 change it's type from Lisp_Object to bitfield.
3420 Change type of 'force_start', 'optional_new_start',
3421 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3422 fields from Lisp_Object to bitfield. Adjust users accordingly.
3423
ca34e0be
PE
34242012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3425
3426 Pacify gcc -Wdouble-precision when using Xaw.
3427 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3428 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3429 Use 'float' consistently, rather than 'float' in most places
3430 and 'double' in a couple of places.
3431
efc00ab1 34322012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3433
3434 * xdisp.c (handle_stop): Detect whether we have overlay strings
3435 loaded by testing it->current.overlay_string_index to be
3436 non-negative, instead of checking whether n_overlay_strings is
3437 positive. (Bug#11587)
3438
efc00ab1 34392012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3440
3441 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3442
3443 * doc.c (Fsubstitute_command_keys): Doc fix.
3444
efc00ab1 34452012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3446
3447 * search.c (search_buffer): Remove calls to
3448 r_alloc_inhibit_buffer_relocation, as it is now called by
3449 maybe_unify_char, which was the cause of relocation of buffer text
3450 in bug#11519.
3451
efc00ab1 34522012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3453
3454 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3455 for the duration of call to load_charset, to avoid problems with
3456 callers of maybe_unify_char that access buffer text through C
3457 pointers.
3458
3459 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3460 decrement the inhibition flag, instead of just setting or
3461 resetting it.
3462
ba93a187
PE
34632012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3464
3465 Remove obsolete '#define static' cruft.
3466 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3467 This #undef was "temporary" in 2000; it is no longer needed
3468 now that '#define static' has gone away.
3469 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3470 (gray_bitmap_bits): Remove; no longer needed.
3471 All uses replaced with definiens.
3472 * xterm.c: Include "bitmaps/gray.xbm".
3473
9e4bf381
PE
34742012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3475
3476 Clean up __executable_start, monstartup when --enable-profiling.
3477 The following changes affect the code only when profiling.
3478 * dispnew.c (__executable_start): Rename from safe_bcopy.
3479 Define only on platforms that need it.
3480 * emacs.c: Include <sys/gmon.h> when profiling.
3481 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3482 (__executable_start): Remove decl, since lisp.h does it now.
3483 (safe_bcopy): Remove decl; no longer has that name.
3484 (main): Coalesce #if into single bit of code, for simplicity.
3485 Cast pointers to uintptr_t, since standard libraries want integers
3486 and not pointers.
3487 * lisp.h (__executable_start): New decl.
3488
32d72c2f
GM
34892012-05-31 Glenn Morris <rgm@gnu.org>
3490
3491 * image.c (Fimagemagick_types): Doc fix.
3492
baac5bc7
JM
34932012-05-30 Jim Meyering <meyering@redhat.com>
3494
3495 * callproc.c (Fcall_process_region): Include directory component
3496 in mkstemp error message (Bug#11586).
3497
72cb32cf
PE
34982012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3499
3500 * alloc.c, lisp.h (make_pure_vector): Now static.
3501
61b108cc
SM
35022012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3503
3504 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3505 Move to byte-run.el.
3506 (Fautoload): Do the hash-doc more carefully.
3507 * data.c (Fdefalias): Purify definition, except for keymaps.
3508 (Qdefun): Move from eval.c.
3509 * lisp.h (Qdefun): Remove.
3510 * lread.c (read1): Tiny simplification.
3511
471fe23d
TN
35122012-05-29 Troels Nielsen <bn.troels@gmail.com>
3513
934f3f58 3514 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3515 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3516 Bug#9642, but explicitly check that the buffer the overlay would
3517 be moved to is live and rearrange lines to make sure that errors
3518 will not put the overlay in an inconsistent state.
3519 (Fdelete_overlay): Cosmetics.
3520
85d0efd1
EZ
35212012-05-28 Eli Zaretskii <eliz@gnu.org>
3522
3523 * w32term.c (my_bring_window_to_top): New function.
3524 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3525 could be different from the original one.
3526 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3527 (Bug#11513)
3528
3529 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3530 by calling BringWindowToTop.
3531
3532 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3533 (WM_EMACS_END): Increase by one.
3534
da92a98c
PE
35352012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3536
3537 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3538 This avoids undefined behavior that might cause the eassert
3539 to not catch an out-of-range value.
3540
74d1f848
JB
35412012-05-28 Juanma Barranquero <lekktu@gmail.com>
3542
3543 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3544 Update dependencies.
3545
9e1a06fc
EZ
35462012-05-27 Eli Zaretskii <eliz@gnu.org>
3547
3548 * bidi.c (bidi_mirror_char): Fix last change.
3549
f3dd7312
AS
35502012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3551
3552 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3553 when referring to sectname field in printf format.
3554
81899c91
PE
35552012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3556
57b81a9f
PE
3557 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3558 Only r_alloc_inhibit_buffer_relocation needed to be added;
3559 the others were already declared.
3560
81899c91
PE
3561 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3562 before checking whether it's out of range. Put the check inside
3563 eassert. See
3564 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3565
33017faf 35662012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3567
3568 * callproc.c (Fcall_process): Restore a line that was accidentally
3569 commented out in the 2011-02-13 change (bug#11547).
3570
33017faf 35712012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3572
3573 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3574 defined on ralloc.c.
3575
3576 * buffer.c [REL_ALLOC]: Remove prototypes of
3577 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3578 they are now on lisp.h.
3579
3580 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3581
3582 * search.c (search_buffer): Use it to inhibit relocation of buffer
3583 text while re_search_2 is doing its job, because re_search_2 is
3584 passed C pointers to buffer text. (Bug#11519)
3585
23415acf
EZ
3586 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3587 Update value to 24.
3588
44e27368
EZ
3589 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3590 state after an additional call to move_it_in_display_line_to, keep
3591 the values of it->max_ascent and it->max_descent found for the
3592 entire line.
3593 (pos_visible_p): Revert the comparison against bottom_y to what it
3594 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3595 (Bug#11464)
3596
c1892f11
PE
35972012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3598
3599 Fix coding-related core dumps with gcc -ftrapv.
3600 The code was computing A - B, where A and B are pointers, and B is
3601 random garbage. This can lead to core dumps on platforms that
3602 have special pointer registers, and it also leads to core dumps on
3603 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3604 A - B only when B is initialized properly.
3605 * coding.c (coding_set_source, coding_set_destination): Return void.
3606 (coding_change_source, coding_change_destinations): New functions,
3607 with the old behaviors of coding_set_source and coding_set_destination.
3608 All callers that need an offset changed to use these new functions.
3609
eb7afdad
GM
36102012-05-26 Glenn Morris <rgm@gnu.org>
3611
3612 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3613
f12fdf02
EZ
36142012-05-26 Eli Zaretskii <eliz@gnu.org>
3615
53a63be6 3616 Extend mouse support on W32 text-mode console.
61b108cc
SM
3617 * xdisp.c (draw_row_with_mouse_face):
3618 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3619
eb3f6f01 3620 * w32console.c: Include window.h.
61b108cc
SM
3621 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3622 New functions.
eb3f6f01
EZ
3623 (initialize_w32_display): Initialize mouse-highlight data.
3624
53a63be6
EZ
3625 * w32inevt.c: Include termchar.h and window.h.
3626 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3627 moves, call note_mouse_highlight. If help_echo changed, call
3628 gen_help_event to produce help-echo message in the echo area.
3629 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3630 highlight info.
3631
4cfd81f6
PE
36322012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3633
3634 * lread.c (read1): Simplify slightly to avoid an overflow warning
3635 with GCC 4.7.0 on x86-64.
3636
4446092a
EZ
36372012-05-26 Eli Zaretskii <eliz@gnu.org>
3638
3639 * bidi.c (bidi_mirror_char): Revert last change: an int is
3640 definitely wide enough here.
3641
42b2a986 36422012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3643
42b2a986 3644 Fix integer width and related bugs (Bug#9874).
eb106a49 3645 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3646 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3647 (string_bytes, check_sblock, allocate_string_data):
3648 (compact_small_strings, Fmake_bool_vector, make_string)
3649 (make_unibyte_string, make_multibyte_string)
3650 (make_string_from_bytes, make_specified_string)
3651 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3652 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3653 (mark_vectorlike):
3654 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3655 (allocate_pseudovector):
3656 Use int, not EMACS_INT, where int is wide enough.
3657 (inhibit_garbage_collection, Fgarbage_collect):
3658 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3659 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3660 int might not be wide enough.
3661 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3662 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3663 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3664 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3665 (bidi_level_of_next_char, bidi_move_to_visually_next):
3666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3667 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3668 (Fkill_buffer, Fset_buffer_major_mode)
3669 (advance_to_char_boundary, Fbuffer_swap_text)
3670 (Fset_buffer_multibyte, overlays_at, overlays_in)
3671 (overlay_touches_p, struct sortvec, record_overlay_string)
3672 (overlay_strings, recenter_overlay_lists)
3673 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3674 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3675 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3676 (Foverlay_recenter, last_overlay_modification_hooks_used)
3677 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3679 (validate_region): Omit unnecessary test for b <= e,
3680 since that's guaranteed by the previous test.
d311d28c
PE
3681 (adjust_overlays_for_delete): Avoid pos + length overflow.
3682 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3683 (report_overlay_modification):
3684 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3685 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3686 Omit pointer cast, which isn't needed anyway, and doesn't work
3687 after the EMACS_INT -> ptrdiff_t change.
02481186 3688 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3689 * buffer.h: Adjust decls to match defn changes elsewhere.
3690 (struct buffer_text, struct buffer):
3691 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3692 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3693 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3694 not int, to avoid needless 32-bit limit on 64-bit hosts.
3695 (exec_byte_code): Use tighter memory-full test, one that checks
3696 for alloca overflow. Don't compute the address of the object just
3697 before an array, as that's not portable. Use EMACS_INT, not
3698 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3699 * callint.c (Fcall_interactively):
3700 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3701 * callproc.c (call_process_kill, Fcall_process):
3702 Don't assume pid_t fits into an Emacs fixnum.
3703 (call_process_cleanup, Fcall_process, child_setup):
3704 Don't assume pid_t fits into int.
3705 (call_process_cleanup, Fcall_process, delete_temp_file)
3706 (Fcall_process_region):
3707 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3708 (Fcall_process): Simplify handling of volatile integers.
3709 Use int, not EMACS_INT, where int will do.
3710 * casefiddle.c (casify_object, casify_region, operate_on_word)
3711 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3713 (casify_object): Avoid integer overflow when overallocating buffer.
3714 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3715 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3716 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3717 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3718 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3719 integers are now checked earlier. All uses replaced with XINT.
3720 (ccl_driver):
3721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3722 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3723 (ccl_driver, Fregister_code_conversion_map):
3724 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3725 (resolve_symbol_ccl_program): Check that vector header is in range.
3726 Always copy the vector, so that we can check its contents reliably
3727 now rather than having to recheck each instruction as it's being
3728 executed. Check that vector words fit in 'int'.
3729 (ccl_get_compiled_code, Fregister_ccl_program)
3730 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3731 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3732 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3733 contents are in range.
3734 (Fccl_execute_on_string): Check that status is in range.
3735 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3736 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3737 Accept and return EMACS_INT, not int, because callers can pass values
3738 out of 'int' range.
3739 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3740 (multibyte_chars_in_text, parse_str_as_multibyte)
3741 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3742 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3743 (string_escape_byte8, Fget_byte):
3744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3745 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3746 avoid mishandling large integers.
3747 * character.h: Adjust decls to match defn changes elsewhere.
3748 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3749 (Ffind_charset_region):
3750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3751 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3752 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3753 Don't assume fixnum fits in int.
d311d28c
PE
3754 (load_charset_map_from_vector, Fmap_charset_chars):
3755 Remove now-unnecessary CHECK_NATNUMs.
3756 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3757 Don't rely on undefined behavior with signed left shift overflow.
3758 Don't assume unsigned int fits into fixnum, or that fixnum fits
3759 into unsigned int. Don't require max_code to be a valid fixnum;
3760 that's not true for gb10830 4-byte on a 32-bit host. Allow
3761 invalid_code to be a cons, for the same reason. Require code_offset
3762 to be a character. Avoid int overflow if max_char is close
3763 to INT_MAX.
3764 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3765 this is intended anyway and avoids some undefined behavior.
3766 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3767 INDEX_TO_CODE_POINT, as that's what it expects.
3768 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3769 * charset.h (DECODE_CHAR): Return int, not unsigned;
3770 this is what was intended anyway, and it avoids undefined behavior.
3771 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3772 integer-overflow issues.
3773 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3774 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3775 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3776 * chartab.c (Fmake_char_table, Fset_char_table_range)
3777 (uniprop_get_decoder, uniprop_get_encoder):
3778 Don't assume fixnum fits in int.
3779 * cmds.c (move_point): New function, that does the gist of
3780 Fforward_char and Fbackward_char, but does so while checking
3781 for integer overflow more accurately.
c96e5d6a 3782 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3783 (Fforward_line, Fend_of_line, internal_self_insert)
3784 (internal_self_insert):
3785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3786 Fix a FIXME, by checking for integer overflow when calculating
3787 target_clm and actual_clm.
3788 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3789 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3790 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3791 (coding_alloc_by_making_gap, alloc_destination)
3792 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3793 (encode_coding_utf_16, detect_coding_emacs_mule)
3794 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3795 (detect_coding_iso_2022, decode_coding_iso_2022)
3796 (encode_invocation_designation, encode_designation_at_bol)
3797 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3798 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3799 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3800 (encode_coding_ccl, encode_coding_raw_text)
3801 (detect_coding_charset, decode_coding_charset)
3802 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3803 (produce_composition, produce_charset, produce_annotation)
3804 (decode_coding, handle_composition_annotation)
3805 (handle_charset_annotation, consume_chars, decode_coding_gap)
3806 (decode_coding_object, encode_coding_object, detect_coding_system)
3807 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3808 (code_convert_region, code_convert_string)
8f50130c
PE
3809 (Fdefine_coding_system_internal)
3810 (coding_set_source, coding_set_destination):
d311d28c
PE
3811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3812 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3813 (Fdefine_coding_system_internal):
3814 Don't assume fixnums fit in int.
3815 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3816 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3817 (Funencodable_char_position, Fcheck_coding_systems_region)
3818 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3820 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3821 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3822 Don't access memory outside of the args array.
d311d28c 3823 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3824 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3825 result of ENCODE_CHAR.
d311d28c
PE
3826 * coding.h: Adjust decls to match defn changes elsewhere.
3827 (struct coding_system):
3828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3829 * composite.c (get_composition_id, find_composition)
3830 (run_composition_function, update_compositions)
3831 (compose_text, composition_gstring_put_cache)
3832 (composition_gstring_p, composition_gstring_width)
3833 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3834 (composition_compute_stop_pos, composition_reseat_it)
3835 (composition_update_it, struct position_record)
3836 (find_automatic_composition, composition_adjust_point)
3837 (Fcomposition_get_gstring, Ffind_composition_internal):
3838 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3839 (update_compositions):
3840 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3841 * composite.h: Adjust decls to match defn changes elsewhere.
3842 (struct composition):
3843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3844 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3845 Do not attempt to compute the address of the object just before a
3846 buffer; this is not portable.
3847 (Faref, Faset):
3848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3849 (Faset): Use int, not EMACS_INT, where int is wide enough.
3850 (Fstring_to_number): Don't assume fixnums fit in int.
3851 (Frem): Don't assume arg is nonnegative.
3852 * dbusbind.c (xd_append_arg): Check for integers out of range.
3853 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3854 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3855 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3856 (xd_get_connection_references): Return ptrdiff_t, not int.
3857 All uses changed.
3858 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3859 (xd_read_message_1):
3860 Use int, not unsigned, where the dbus API uses int.
3861 (Fdbus_message_internal): Don't overflow mtype.
3862 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3863 * dired.c (directory_files_internal, file_name_completion, scmp)
3864 (file_name_completion_stat):
3865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3866 (file_name_completion): Don't overflow matchcount.
3867 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3868 * dispextern.h: Adjust decls to match defn changes elsewhere.
3869 (struct text_pos, struct glyph, struct bidi_saved_info)
3870 (struct bidi_string_data, struct bidi_it, struct composition_it)
3871 (struct it):
3872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3873 (struct display_pos, struct composition_it, struct it):
3874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3875 * dispnew.c (increment_matrix_positions)
3876 (increment_row_positions, mode_line_string)
3877 (marginal_area_string):
3878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3879 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3881 (duration_to_sec_usec): New function, to check for overflow better.
3882 (Fsleep_for, sit_for): Use it.
3883 * doc.c (get_doc_string, store_function_docstring):
3884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3885 (get_doc_string, Fsnarf_documentation):
3886 Use int, not EMACS_INT, where int is wide enough.
3887 (get_doc_string):
3888 Use SAFE_ALLOCA, not alloca.
3889 Check for overflow when converting EMACS_INT to off_t.
3890 * doprnt.c (doprnt):
3891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3892 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3893 Don't assume uid_t fits into fixnum.
3894 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3895 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3896 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3897 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3898 (general_insert_function)
3899 (Finsert_char, make_buffer_string, make_buffer_string_both)
3900 (update_buffer_properties, Fbuffer_substring)
3901 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3902 (Fsubst_char_in_region, check_translation)
3903 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3904 (transpose_markers, Ftranspose_regions):
3905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3906 (clip_to_bounds): Move to lisp.h as an inline function).
3907 (Fconstrain_to_field): Don't assume integers are nonnegative.
3908 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3909 (Fsubst_char_in_region, Fsave_restriction):
3910 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3911 (Femacs_pid): Don't assume pid_t fits into fixnum.
3912 (lo_time): Use int, not EMACS_INT, when int suffices.
3913 (lisp_time_argument): Check for usec out of range.
3914 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3915 (Fuser_login_name, Fuser_full_name): Signal an error
3916 if a uid argument is out of range, rather than relying on
3917 undefined behavior.
c8d5c857
PE
3918 (Fformat_time_string): Remove now-unnecessary check.
3919 lisp_time_argument checks for out-of-range usec now.
243e0530 3920 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3921 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3922 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3923 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3924 (init_cmdargs, Fdump_emacs):
3925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3926 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3927 the bottom (typically) 32 bits of the fixnum.
3928 * eval.c (specpdl_size, call_debugger):
3929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3930 (when_entered_debugger, Fbacktrace_debug):
3931 Don't assume fixnum can fit in int.
3932 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3933 the object just before a buffer; this is not portable.
3934 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3935 (grow_specpdl, unbind_to):
3936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3937 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3938 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3939 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3940 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3941 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3943 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3944 (a_write, e_write):
3945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3946 (Fcopy_file, non_regular_nbytes, read_non_regular)
3947 (Finsert_file_contents):
3948 Use int, not EMACS_INT, where int is wide enough.
3949 (READ_BUF_SIZE): Verify that it fits in int.
3950 (Finsert_file_contents): Check that counts are in proper range,
3951 rather than assuming fixnums fit into ptrdiff_t etc.
3952 Don't assume fixnums fit into int.
125b3835 3953 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3954 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3955 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3956 (string_char_to_byte, string_byte_to_char)
3957 (string_make_multibyte, string_to_multibyte)
3958 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3959 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3960 (substring_both, Fdelete, internal_equal, Ffillarray)
3961 (Fclear_string, mapcar1)
3962 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3963 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3964 (larger_vector, make_hash_table, maybe_resize_hash_table)
3965 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3966 (Fmaphash, secure_hash):
3967 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3968 (concat): Check for string index and length overflow.
3969 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3970 (Frequire):
3971 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3972 (larger_vector): New API (vec, incr_min, size_max) replaces old
3973 one (vec, new_size, init). This catches size overflow.
3974 INIT was removed because it was always Qnil.
3975 All callers changed.
3976 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3977 the upper bound on a hash table index size.
3978 (make_hash_table, maybe_resize_hash_table): Use it.
3979 (secure_hash): Computer start_byte and end_byte only after
3980 they're known to be in ptrdiff_t range.
3981 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3982 (Ffont_get_glyphs, Ffont_at):
3983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3984 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3985 (Flist_fonts, Fopen_font):
3986 Don't assume fixnum can fit in int.
3987 (check_gstring): Don't assume index can fit in int.
3988 (font_match_p): Check that fixnum is a character, not a nonnegative
3989 fixnum, since the later code needs to stuff it into an int.
3990 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3991 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3992 conversion overflow issues.
3993 (Fopen_font): Check for integer out of range.
3994 (Ffont_get_glyphs): Don't assume index can fit in int.
3995 * font.h: Adjust decls to match defn changes elsewhere.
3996 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3997 integer overflow.
3998 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3999 printmax_t, where ptrdiff_t is wide enough.
4000 (Finternal_char_font):
4001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4002 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4003 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4004 (Fset_frame_position, x_set_frame_parameters)
4005 (x_set_line_spacing, x_set_border_width)
4006 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4007 Check that fixnums are in proper range for system types.
4008 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4010 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4011 Use SAFE_ALLOCA_LISP, not alloca.
4012 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4013 intptr_t is wide enough.
4014 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4015 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4016 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4017 Check for fixnum out of range.
4018 * ftfont.c (ftfont_list): Don't assume index fits in int.
4019 Check that fixnums are in proper range for system types.
4020 (ftfont_shape_by_flt):
4021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4022 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4024 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4025 Check that fixnums are in proper range for system types.
4026 * gnutls.h: Adjust decls to match defn changes elsewhere.
4027 * gtkutil.c (xg_dialog_run):
4028 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4029 (update_frame_tool_bar):
4030 Check that fixnums are in proper range for system types.
4031 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4032 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4033 * indent.c (last_known_column, last_known_column_point):
4034 (current_column_bol_cache):
4035 (skip_invisible, current_column, check_display_width):
4036 (check_display_width, scan_for_column, current_column_1)
4037 (Findent_to, Fcurrent_indentation, position_indentation)
4038 (indented_beyond_p, Fmove_to_column, compute_motion):
4039 (Fcompute_motion, Fvertical_motion):
4040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4041 (last_known_column_modified): Use EMACS_INT, not int.
4042 (check_display_width):
4043 (Fcompute_motion):
4044 Check that fixnums and floats are in proper range for system types.
4045 (compute_motion): Don't assume index or fixnum fits in int.
4046 (compute_motion, Fcompute_motion):
4047 Use int, not EMACS_INT, when it is wide enough.
4048 (vmotion): Omit local var start_hpos that is always 0; that way
4049 we don't need to worry about overflow in expressions involving it.
4050 * indent.h: Adjust decls to match defn changes elsewhere.
4051 (struct position):
4052 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4053 Use int, not EMACS_INT, where int is wide enough.
4054 Remove unused members ovstring_chars_done and tab_offset;
4055 all uses removed.
4056 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4057 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4058 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4059 (make_gap, copy_text, insert, insert_and_inherit)
4060 (insert_before_markers, insert_before_markers_and_inherit)
4061 (insert_1, count_combining_before, count_combining_after)
4062 (insert_1_both, insert_from_string)
4063 (insert_from_string_before_markers, insert_from_string_1)
4064 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4065 (adjust_after_replace, adjust_after_insert, replace_range)
4066 (replace_range_2, del_range, del_range_1, del_range_byte)
4067 (del_range_both, del_range_2, modify_region)
4068 (prepare_to_modify_buffer, signal_before_change)
4069 (signal_after_change, Fcombine_after_change_execute):
4070 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4071 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4072 (balance_an_interval, split_interval_right, split_interval_left)
4073 (find_interval, next_interval, update_interval)
4074 (adjust_intervals_for_insertion, delete_node, delete_interval)
4075 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4076 (static_offset_intervals, offset_intervals)
4077 (merge_interval_right, merge_interval_left, make_new_interval)
4078 (graft_intervals_into_buffer, temp_set_point_both)
4079 (temp_set_point, set_point, adjust_for_invis_intang)
4080 (set_point_both, move_if_not_intangible, get_property_and_range)
4081 (get_local_map, copy_intervals, copy_intervals_to_string)
4082 (compare_string_intervals, set_intervals_multibyte_1):
4083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4084 * intervals.h: Adjust decls to match defn changes elsewhere.
4085 (struct interval):
4086 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4087 * keyboard.c (this_command_key_count, this_single_command_key_start)
4088 (before_command_key_count, before_command_echo_length, echo_now)
4089 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4090 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4091 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4092 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4094 (last_non_minibuf_size, last_point_position, echo_truncate)
4095 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4096 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4097 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4098 (stuff_buffered_input):
4099 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4100 (last_auto_save, command_loop_1, read_char):
4101 Use EMACS_INT, not int, to avoid integer overflow.
4102 (record_char): Avoid overflow in total_keys computation.
4103 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4104 * keyboard.h: Adjust decls to match defn changes elsewhere.
4105 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4106 (Fkey_description, Fdescribe_vector, Flookup_key):
4107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4108 (click_position): New function, to check that positions are in range.
4109 (Fcurrent_active_maps):
4110 (describe_command):
4111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4112 (Faccessible_keymaps, Fkey_description):
4113 (preferred_sequence_p):
4114 Don't assume fixnum can fit into int.
4115 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4116 Check for integer overflow in size calculations.
4117 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4118 avoid mishandling large integers.
4119 * lisp.h: Adjust decls to match defn changes elsewhere.
4120 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4121 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4122 (struct Lisp_Marker):
4123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4124 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4125 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4126 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4127 All callers changed.
4128 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4129 Assume the arg has valid form, since it always does.
4130 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4131 unsigned integer system type.
4132 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4133 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4134 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4135 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4136 (duration_to_sec_usec): New decl.
4137 * lread.c (read_from_string_index, read_from_string_index_byte)
4138 (read_from_string_limit, readchar, unreadchar, openp)
4139 (read_internal_start, read1, oblookup):
4140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4141 (Fload, readevalloop, Feval_buffer, Feval_region):
4142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4143 (openp): Check for out-of-range argument to 'access'.
4144 (read1): Use int, not EMACS_INT, where int is wide enough.
4145 Don't assume fixnum fits into int.
6efdadfd 4146 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4147 (read_filtered_event): Use duration_to_sec_usec
4148 to do proper overflow checking on durations.
d311d28c
PE
4149 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4150 in size calculation.
4151 (Fexecute_kbd_macro):
4152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4153 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4154 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4155 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4156 (set_marker_both, set_marker_restricted_both, marker_position)
4157 (marker_byte_position, Fbuffer_has_markers_at):
4158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4159 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4160 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4161 It now merely ensures that the menu is large enough, without
4162 necessarily growing it, as this avoids some integer overflow issues.
4163 All callers changed.
4164 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4165 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4166 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4167 Use SAFE_ALLOCA_LISP, not alloca.
4168 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4169 to EMACS_INT. Check that fixnums are in proper range for system types.
4170 * minibuf.c (minibuf_prompt_width, string_to_object)
4171 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4172 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4174 (get_minibuffer, read_minibuf_unwind):
4175 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4176 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4177 this simplifies overflow checking. All callers changed.
4178 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4179 (Ftest_completion):
4180 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4181 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4182 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4183 Check that fixnums are in proper range for system types.
4184 (Fx_create_frame, Fx_show_tip):
4185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4186 * nsfont.m (ns_findfonts, nsfont_list_family):
4187 Don't assume fixnum fits in long.
4188 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4190 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4191 wide enough.
17fdb222 4192 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4193 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4194 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4195 (PRINTDECLARE, PRINTPREPARE):
4196 (strout, print_string):
4197 (print, print_preprocess, print_check_string_charset_prop)
4198 (print_object):
4199 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4200 (PRINTDECLARE):
4201 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4203 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4204 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4205 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4206 (print_error_message): Use SAFE_ALLOCA, not alloca.
4207 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4208 (print_depth, new_backquote_output, print_number_index):
4209 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4210 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4211 (Fset_process_window_size, Fformat_network_address)
4212 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4213 (sigchld_handler):
d311d28c 4214 Check that fixnums are in proper range for system types.
d44287d4 4215 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4216 Check for process-ids out of pid_t range rather than relying on
4217 undefined behavior.
e4d81efc 4218 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4219 (Fformat_network_address, read_process_output, send_process)
4220 (Fprocess_send_region, status_notify):
4221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4222 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4223 (wait_reading_process_output, read_process_output, exec_sentinel):
4224 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4225 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4226 (Faccept_process_output): Use duration_to_sec_usec to do proper
4227 overflow checking on durations.
dde14581
PE
4228 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4229 Don't assume pid_t fits in int.
02481186
PE
4230 * process.h (struct Lisp_Process): Members tick and update_tick
4231 are now of type EMACS_INT, not int.
b62b53e8
PE
4232 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4233 configured --with-wide-int.
d311d28c
PE
4234 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4235 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4236 * search.c (looking_at_1, string_match_1):
4237 (fast_string_match, fast_c_string_match_ignore_case)
4238 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4239 (scan_newline, find_before_next_newline, search_command)
4240 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4241 (set_search_regs, wordify):
4242 (Freplace_match):
4243 (Fmatch_data):
4244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4245 (string_match_1, search_buffer, set_search_regs):
4246 (Fmatch_data):
4247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4248 (wordify): Check for overflow in size calculation.
4249 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4250 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4251 Check that fixnums are in proper range for system types.
4252 * sound.c (struct sound_device)
4253 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4254 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4255 (Fplay_sound_internal):
4256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4257 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4258 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4259 (Fparse_partial_sexp):
4260 Don't assume fixnums can fit in int.
4261 (struct lisp_parse_state, find_start_pos, find_start_value)
4262 (find_start_value_byte, find_start_begv)
4263 (update_syntax_table, char_quoted, dec_bytepos)
4264 (find_defun_start, prev_char_comend_first, back_comment):
4265 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4266 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4267 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4268 (Finternal_describe_syntax_value): Check that match_lisp is a
4269 character, not an integer, since the code stuffs it into int.
4270 (scan_words, scan_sexps_forward):
4271 Check that fixnums are in proper range for system types.
4272 (Fforward_word):
4273 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4274 (scan_sexps_forward):
4275 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4276 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4277 * syntax.h: Adjust decls to match defn changes elsewhere.
4278 (struct gl_state_s):
4279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4280 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4281 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4282 * sysdep.c (wait_for_termination_1, wait_for_termination)
4283 (interruptible_wait_for_termination, mkdir):
4284 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4285 (emacs_read, emacs_write):
4286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4287 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4288 and double all fit in int.
d311d28c
PE
4289 * term.c (set_tty_color_mode):
4290 Check that fixnums are in proper range for system types.
4291 * termhooks.h (struct input_event):
4292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4293 * textprop.c (validate_interval_range, interval_of)
4294 (Fadd_text_properties, set_text_properties_1)
4295 (Fremove_text_properties, Fremove_list_of_text_properties)
4296 (Ftext_property_any, Ftext_property_not_all)
4297 (copy_text_properties, text_property_list, extend_property_ranges)
4298 (verify_interval_modification):
4299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4300 (Fnext_single_char_property_change)
4301 (Fprevious_single_char_property_change):
4302 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4303 (copy_text_properties):
4304 Check for integer overflow in index calculation.
d311d28c
PE
4305 * undo.c (last_boundary_position, record_point, record_insert)
4306 (record_delete, record_marker_adjustment, record_change)
4307 (record_property_change):
4308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4309 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4310 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4311 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4312 (Fx_hide_tip, Fx_file_dialog):
4313 * w32menu.c (set_frame_menubar):
4314 Use ptrdiff_t, not int, for consistency with rest of code.
4315 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4316 (select_window, Fdelete_other_windows_internal)
4317 (window_scroll_pixel_based, window_scroll_line_based)
4318 (Frecenter, Fset_window_configuration):
4319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4320 (Fset_window_hscroll, run_window_configuration_change_hook)
4321 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4322 (Fscroll_other_window, Frecenter):
d311d28c
PE
4323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4324 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4325 Don't assume fixnum fits in int.
4326 (Fset_window_scroll_bars):
4327 Check that fixnums are in proper range for system types.
4328 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4329 (string_pos, c_string_pos, number_of_chars, init_iterator)
4330 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4331 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4332 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4333 (face_before_or_after_it_pos, handle_invisible_prop)
4334 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4335 (display_prop_intangible_p, string_buffer_position_lim)
4336 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4337 (get_overlay_strings_1, get_overlay_strings)
4338 (iterate_out_of_display_property, forward_to_next_line_start)
4339 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4340 (get_next_display_element, set_iterator_to_next)
4341 (get_visually_first_element, compute_stop_pos_backwards)
4342 (handle_stop_backwards, next_element_from_buffer)
4343 (move_it_in_display_line_to, move_it_in_display_line)
4344 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4345 (add_to_log, message_dolog, message_log_check_duplicate)
4346 (message2, message2_nolog, message3, message3_nolog
4347 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4348 (current_message_1, truncate_echo_area, truncate_message_1)
4349 (set_message, set_message_1, store_mode_line_noprop)
4350 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4351 (text_outside_line_unchanged_p, check_point_in_composition)
4352 (reconsider_clip_changes)
4353 (redisplay_internal, set_cursor_from_row, try_scrolling)
4354 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4355 (redisplay_window, find_last_unchanged_at_beg_row)
4356 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4357 (trailing_whitespace_p, find_row_edges, display_line)
4358 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4359 (display_mode_element, store_mode_line_string)
4360 (pint2str, pint2hrstr, decode_mode_spec)
4361 (display_count_lines, display_string, draw_glyphs)
4362 (x_produce_glyphs, x_insert_glyphs)
4363 (rows_from_pos_range, mouse_face_from_buffer_pos)
4364 (fast_find_string_pos, mouse_face_from_string_pos)
4365 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4366 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4367 (safe_call, init_from_display_pos, handle_fontified_prop)
4368 (handle_single_display_spec, load_overlay_strings)
4369 (with_echo_area_buffer, setup_echo_area_for_printing)
4370 (display_echo_area, echo_area_display)
4371 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4372 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4373 (redisplay_window, dump_glyph_row, display_mode_line)
4374 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4375 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4377 (handle_single_display_spec, build_desired_tool_bar_string)
4378 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4379 (get_specified_cursor_type):
4380 Check that fixnums are in proper range for system types.
4381 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4382 (Flookup_image_map):
4383 Don't assume fixnums fit in int.
4384 (compare_overlay_entries):
4385 Avoid mishandling comparisons due to subtraction overflow.
4386 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4387 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4388 (handle_tool_bar_click):
4389 Use int, not unsigned, since we prefer signed and the signedness
4390 doesn't matter here.
4391 (get_next_display_element, next_element_from_display_vector):
4392 Use int, not EMACS_INT, when int is wide enough.
4393 (start_hourglass): Use duration_to_sec_usec to do proper
4394 overflow checking on durations.
4395 * xfaces.c (Fbitmap_spec_p):
4396 Check that fixnums are in proper range for system types.
4397 (compare_fonts_by_sort_order):
4398 Avoid mishandling comparisons due to subtraction overflow.
4399 (Fx_family_fonts, realize_basic_faces):
4400 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4401 (Fx_family_fonts):
4402 Don't assume fixnum fits in int.
4403 Use SAFE_ALLOCA_LISP, not alloca.
4404 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4405 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4406 (face_at_buffer_position, face_for_overlay_string)
4407 (face_at_string_position):
4408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4409 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4410 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4411 (Fx_show_tip):
4412 Check that fixnums are in proper range for system types.
4413 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4414 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4416 (Fx_change_window_property): Don't assume fixnums fit in int.
4417 * xfont.c (xfont_chars_supported):
4418 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4419 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4420 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4421 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4422 * xml.c (parse_region):
4423 * xrdb.c (magic_file_p):
4424 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4425 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4426 (x_get_local_selection, x_reply_selection_request)
4427 (x_handle_selection_request, wait_for_property_change):
4428 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4429 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4430 short is wide enough.
4431 (x_send_client_event): Don't assume fixnum fits in int.
4432 * xterm.c (x_x_to_emacs_modifiers):
4433 Don't assume EMACS_INT overflows nicely into int.
4434 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4435 may come from Lisp.
4436 (handle_one_xevent): NATNUMP can eval its arg twice.
4437 (x_connection_closed):
4438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4439 * xterm.h: Adjust decls to match defn changes elsewhere.
4440 (struct scroll_bar): Use struct vectorlike_header
4441 rather than rolling our own approximation.
4442 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4443
c6574eb5
GM
44442012-05-25 Glenn Morris <rgm@gnu.org>
4445
4446 * lisp.mk (lisp): Update for more files being compiled now.
4447
e8d32c7e
SM
44482012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4449
48def666
SM
4450 * lread.c: Remove `read_pure' which makes no difference.
4451 (read_pure): Remove var.
4452 (unreadpure): Remove function.
4453 (readevalloop): Don't call read_list with -1 flag.
4454 (read1, read_vector): Don't test read_pure any more.
4455 (read_list): Simplify.
4456
e8d32c7e
SM
4457 * fileio.c, character.h: Minor style tweaks.
4458
4b2addb7
DA
44592012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4460
4461 * window.h (clip_changed): Remove useless declaration.
4462
584461b2
JB
44632012-05-22 Juanma Barranquero <lekktu@gmail.com>
4464
4465 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4466 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4467
34374650
PE
44682012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4469
4470 Remove src/m/*.
4471 This directory predates autoconf and is no longer needed nowadays.
4472 Move its few remaining bits of functionality to where they're needed.
4473 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4474 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4475 * m/template.h: Remove.
4476 * Makefile.in (M_FILE): Remove. All uses removed.
4477 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4478 * lisp.h (USE_LSB_TAG):
4479 * mem-limits.h (EXCEEDS_LISP_PTR):
4480 Use VAL_MAX, not VALBITS, in #if.
4481 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4482 (EMACS_UINT): Define unconditionally now.
4483 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4484 (BITS_PER_EMACS_INT): New constants, replacing
4485 what used to be in config.h, but not useful in #if.
4486 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4487 define them any more.
4488 (VAL_MAX): New macro.
4489 (VALMASK): Use it.
4490 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4491 BITS_PER_EMACS_INT, in #if.
4492 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4493 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4494 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4495 * s/ms-w32.h (DATA_START):
4496 Move here from removed file m/intel386.h.
4497 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4498 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4499
261cb4bb
PE
45002012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4501
4502 Assume C89 or later.
4503 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4504 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4505 (xrealloc):
4506 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4507 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4508 * textprop.c, tparam.c (NULL): Remove.
4509 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4510 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4511 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4512 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4513 * xterm.c (input_signal_count): Assume volatile works.
4514
ff23cd9f
KB
45152012-05-21 Ken Brown <kbrown@cornell.edu>
4516
4517 * xgselect.c (xg_select): Fix first argument in call to 'select'
4518 (bug#11508).
4519
1b170bc6
KB
45202012-05-20 Ken Brown <kbrown@cornell.edu>
4521
4522 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4523 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4524
b2f4d39f
KB
45252012-05-19 Ken Brown <kbrown@cornell.edu>
4526
4527 * xfns.c (x_in_use): Remove `static' qualifier.
4528 * xterm.h (x_in_use): Declare.
4529 * xgselect.c: Include xterm.h.
4530 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4531 and `display_arg' (bug#9754).
4532
003fdae2
PE
45332012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4534
9232a6d9
PE
4535 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4536
003fdae2
PE
4537 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4538 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4539
784b56e2
EZ
45402012-05-18 Eli Zaretskii <eliz@gnu.org>
4541
4542 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4543
4544 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4545 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4546
4547 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4548 reference to image_cache->refcount.
4549 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4550
a0a79cde
JL
45512012-05-17 Juri Linkov <juri@jurta.org>
4552
4553 * search.c (Fword_search_regexp, Fword_search_backward)
4554 (Fword_search_forward, Fword_search_backward_lax)
4555 (Fword_search_forward_lax): Move functions to isearch.el
4556 (bug#10145, bug#11381).
4557
b0572523
PE
45582012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4559
4560 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4561
9660f5fc
SM
45622012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4563
4564 * lread.c (init_obarray): Declare Qt and Qnil as special.
4565
4374de83
GM
45662012-05-14 Glenn Morris <rgm@gnu.org>
4567
4568 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4569 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4570
dc44c39a
PE
45712012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4572
078c97cb
PE
4573 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4574
dc44c39a
PE
4575 * unexaix.c: Port to more-recent AIX compilers.
4576 (report_error, report_error_1, make_hdr, copy_sym)
4577 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4578 Make arguments const char *, not char *, to avoid violations of C
4579 standard and to fix some AIX warnings reported by Gilles Pion.
4580
e18afed7 45812012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4582
4583 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4584 already have overlays loaded.
4585 (handle_single_display_spec): Before returning without displaying
4586 fringe bitmap, synchronize the bidi iterator with the main display
4587 iterator, by calling iterate_out_of_display_property.
4588 (iterate_out_of_display_property): Detect buffer iteration by
4589 testing that it->string is a Lisp string.
4590 (get_next_display_element): When the current object is exhausted,
4591 and there's something on it->stack, call set_iterator_to_next to
4592 proceed with what's on the stack, instead of returning zero.
4593 (set_iterator_to_next): If called at the end of a Lisp string,
4594 proceed to consider_string_end without incrementing string
4595 position. Don't increment display vector index past the end of
4596 the display vector. (Bug#11417)
c8fb9dc6
EZ
4597 (pos_visible_p): Don't report a position visible when move_it_to
4598 stopped at the last line of window, which happens to be scanned
4599 backwards by the bidi iteration. (Bug#11464)
ac268e67 4600
e18afed7 46012012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4602
4603 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4604 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4605 are on a TTY, and thus unable to display on the fringes.
4606 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4607 so we need to signal to the caller that this is a "replacing"
4608 display spec. This fixes display when the spec is invalid or we
4609 are on a TTY.
4610
e18afed7 46112012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4612
4613 * unexaix.c (make_hdr): Fix typo in prototype.
4614 This bug broke the build on AIX. Problem reported by Gilles Pion.
4615
9d0a235a
MA
46162012-05-14 Michael Albinus <michael.albinus@gmx.de>
4617
4618 * keyboard.c (kbd_buffer_get_event): Read special events also in
4619 batch mode. (Bug#11415)
4620
9e6b06ed
GM
46212012-05-12 Glenn Morris <rgm@gnu.org>
4622
4623 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4624
c1a1d7a3
EZ
46252012-05-12 Eli Zaretskii <eliz@gnu.org>
4626
4627 * lisp.mk (lisp): Add newcomment.elc.
4628
3fe7cdc8
GM
46292012-05-12 Glenn Morris <rgm@gnu.org>
4630
4631 * Makefile.in (MKDIR_P): New, set by configure.
4632 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4633
53f7d2c0
PE
46342012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4635
4636 Remove unused function hourglass_started.
4637 * dispextern.h (hourglass_started):
4638 * w32fns.c (hourglass_started):
4639 * xdisp.c (hourglass_started): Remove.
4640
75aafb17
JB
46412012-05-10 Juanma Barranquero <lekktu@gmail.com>
4642
4643 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4644 Update dependencies.
4645
12959e8e
PE
46462012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4647
97107e2e
PE
4648 * xgselect.c (xg_select): Put maxfds+1 into a var.
4649 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4650
12959e8e
PE
4651 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4652
836d29b3
DA
46532012-05-10 Dave Abrahams <dave@boostpro.com>
4654
4655 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4656 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4657
5cb67954
MA
46582012-05-09 Michael Albinus <michael.albinus@gmx.de>
4659
4660 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4661 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4662 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4663 Initialize xd_registered_buses.
4664
3478ec45
PE
46652012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4666
b263a6b0
PE
4667 Untag more efficiently if USE_LSB_TAG.
4668 This is based on a proposal by YAMAMOTO Mitsuharu in
4669 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4670 For an admittedly artificial (nth 8000 longlist) benchmark on
4671 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4672 Emacs's overall text size by 1%.
4673 * lisp.h (XUNTAG): New macro.
4674 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4675 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4676 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4677 * eval.c (Fautoload):
4678 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4679 * frame.h (XFRAME): Use XUNTAG.
4680
3478ec45
PE
4681 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4682 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4683 Remove unportable assumptions about print widths of types like
4684 dbus_uint32_t.
4685 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4686 intptr_t when converting between pointer and integer, to avoid GCC
4687 warnings about wrong width.
4688
666b903b 46892012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4690
4691 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4692 stack for each reader_thread, instead of defaulting to 8MB
4693 determined by the linker. This avoids failures in creating
4694 subprocesses on Windows 7, see the discussion in this thread:
4695 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4696
b120cc17
JC
46972012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4698
4699 Fix up display of the *Minibuf-0* buffer in the mini window.
4700 * keyboard.c (read_char): Don't clear the echo area if there's no
4701 message to clear.
4702 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4703 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4704
9a4b36f8
MA
47052012-05-07 Michael Albinus <michael.albinus@gmx.de>
4706
4707 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4708 batch mode.
4709
e5f9458f
CY
47102012-05-06 Chong Yidong <cyd@gnu.org>
4711
4712 * lisp.mk (lisp): Update.
4713
eceeb5fc 47142012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4715
4716 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4717
71873e2b
SM
47182012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4719
4720 * data.c (PUT_ERROR): New macro.
4721 (syms_of_data): Use it. Add new error type `user-error'.
4722 * undo.c (user_error): New function.
4723 (Fprimitive_undo): Use it.
4724 * print.c (print_error_message): Adjust print style for `user-error'.
4725 * keyboard.c (user_error): New function.
4726 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4727
ab0fa4e4
PE
47282012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4729
4730 Do not limit current-time-string to years 1000..9999.
4731 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4732 (Fcurrent_time_string): Support any year that is supported by the
4733 underlying localtime representation. Don't use asctime, as it
4734 has undefined behavior for years outside the range -999..9999.
4735
7ed806a7
PE
47362012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4737
4738 Fix race conditions involving setenv, gmtime, localtime, asctime.
4739 Without this fix, interrupts could mess up code that uses these
4740 nonreentrant functions, since setting TZ invalidates existing
4741 tm_zone or tzname values, and since most of these functions return
4742 pointers to static storage.
4743 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4744 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4745 Grow the critical sections to include not just invoking
4746 localtime/gmtime, but also accessing these functions' results
4747 including their tm_zone values if any, and any related TZ setting.
4748 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4749 so that the struct tm is saved in the critical section.
4750 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4751 motivated by the fact that memory allocation needs to be outside
4752 the critical section.
4753
0c16dfed
DA
47542012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4755
4756 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4757 with RESET_INTERVAL.
4758
4759 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4760 Remove duplicated buffer name initialization.
4761
3f83ace8
JM
47622012-05-02 Jim Meyering <jim@meyering.net>
4763
4764 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4765
c7b8541e
JM
4766 * xfns.c (x_window): Use xstrdup (Bug#11375).
4767
90207a15 47682012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4769
4770 * xdisp.c (pos_visible_p): If already at a newline from the
4771 display string before the 'while' loop, don't walk back the glyphs
4772 from it3.glyph_row. Solves assertion violation when the display
4773 string begins with a newline (egg.el). (Bug#11367)
4774
b593d6a9
AH
47752012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4776
4777 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4778 Move to simple.el.
4779
4737362e
GM
47802012-05-01 Glenn Morris <rgm@gnu.org>
4781
99cf43f9
GM
4782 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4783 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4784 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4785 All were removed before 23.1.
4786
9311dcff
GM
4787 * dispnew.c: Remove HAVE_LIBNCURSES test;
4788 it is always true on relevant platforms.
4789
4d5c6349
GM
4790 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4791 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4792
4737362e
GM
4793 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4794
74dd3a6b
AS
47952012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4796
4797 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4798 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4799 Remove.
4800
13c379ee
PE
48012012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4802
4803 Do not avoid creating empty evaporating overlays (Bug#9642).
4804 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4805 That is, do not delete an evaporating overlay if it becomes
4806 empty after its bounds are adjusted to fit within its buffer.
4807 This fix caused other problems, and I'm reverting it until we get
4808 to the bottom of them.
4809
a8e7d6d7 48102012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4811
4812 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4813
a8e7d6d7 48142012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4815
4816 * xdisp.c (pos_visible_p): If the window start position is beyond
4817 ZV, start the display from buffer beginning. Prevents assertion
4818 violation in init_iterator when the minibuffer window is scrolled
4819 via the scroll bar.
4820
4821 * window.c (window_scroll_pixel_based): Likewise.
4822
a8e7d6d7 48232012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4824
4825 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4826
a8e7d6d7 48272012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4828
4829 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4830 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4831
a8e7d6d7 48322012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4833
b593d6a9
AH
4834 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4835 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4836
1c6900d9
EZ
48372012-04-26 Eli Zaretskii <eliz@gnu.org>
4838
4c3fa1d9
EZ
4839 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4840 display element, check also the underlying string or buffer
4841 character. (Bug#11341)
4842
1c6900d9
EZ
4843 * w32menu.c: Include w32heap.h.
4844 (add_menu_item): If the call to AppendMenuW (via
4845 unicode_append_menu) fails, disable Unicode menus only if we are
4846 running on Windows 9X/Me.
4847
42bf8205
AS
48482012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4849
4850 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4851 (xgetint): Add missing shift for LSB tags.
4852
b1bac16e
MR
48532012-04-24 Martin Rudalics <rudalics@gmx.at>
4854
4855 * keyboard.c (read_char): Don't wipe echo area for select window
4856 events: These might get delayed via `mouse-autoselect-window'
4857 (Bug#11304).
4858
d69621cc
JB
48592012-04-24 Juanma Barranquero <lekktu@gmail.com>
4860
4861 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4862 manipulation of :loaded-from data.
4863
02fd101b
JB
48642012-04-23 Juanma Barranquero <lekktu@gmail.com>
4865
4866 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4867 now a cons (bug#11311).
4868
888bec30
PE
48692012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4870
89a438bd
PE
4871 Do not create empty overlays with the evaporate property (Bug#9642).
4872 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4873 if it becomes empty after its bounds are adjusted to fit within
4874 its buffer. Without this fix, in a nonempty buffer (let ((o
4875 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4876 yields an empty overlay that has the evaporate property, which is
4877 not supposed to happen.
4878
1068fe4d
PE
4879 Fix minor GTK3 problems found by static checking.
4880 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4881 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4882 (struct _EmacsFixedClass, emacs_fixed_get_type):
4883 Move decls here from emacsgtkfixed.h, since they needn't be public.
4884 (emacs_fixed_get_type): Now static.
4885 (emacs_fixed_class_init): Omit unused local.
4886 (emacs_fixed_child_type): Remove; unused.
4887 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4888 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4889 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4890 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4891 (EMACS_FIXED_GET_CLASS): Remove; unused.
4892 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4893
888bec30
PE
4894 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4895 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4896
de85e130
PE
48972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4898
d0baac98 4899 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4900 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4901 (__malloc_size_t, __malloc_ptrdiff_t):
4902 Remove. All uses removed, replaced by the definiens if needed,
4903 since we can assume C89 or better now.
4904 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4905 (protect_malloc_state, align, get_contiguous_space)
4906 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4907 (malloc_atfork_handler_child, malloc_enable_thread)
4908 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4909 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4910 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4911 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4912 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4913 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4914 Define using prototypes, not old style.
4915 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4916 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4917 (align): Don't assume that signed integer overflow wraps around.
4918 Omit unused local var.
4919 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4920 (_free_internal_nolock, memalign, mallochook, reallochook):
4921 Omit no-longer-needed casts.
4922 (valloc): Use getpagesize, not __getpagesize.
4923 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4924 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4925
de85e130
PE
4926 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4927
dcbf5805
MA
49282012-04-22 Michael Albinus <michael.albinus@gmx.de>
4929
4930 Move functions from C to Lisp. Make non-blocking method calls
4931 the default. Implement further D-Bus standard interfaces.
4932
4933 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4934 (QCdbus_request_name_allow_replacement)
4935 (QCdbus_request_name_replace_existing)
4936 (QCdbus_request_name_do_not_queue)
4937 (QCdbus_request_name_reply_primary_owner)
4938 (QCdbus_request_name_reply_in_queue)
4939 (QCdbus_request_name_reply_exists)
4940 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4941 (QCdbus_registered_serial, QCdbus_registered_method)
4942 (QCdbus_registered_signal): New Lisp objects.
4943 (XD_DEBUG_MESSAGE): Use sizeof.
4944 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4945 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4946 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4947 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4948 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4949 (xd_signature, xd_append_arg): Allow float for integer types.
4950 (xd_get_connection_references): New function.
b593d6a9
AH
4951 (xd_get_connection_address): Rename from xd_initialize.
4952 Return cached address.
dcbf5805
MA
4953 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4954 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4955 level.
4956 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4957 Return number of refcounts.
dcbf5805
MA
4958 (Fdbus_get_unique_name): Make stronger parameter check.
4959 (Fdbus_message_internal): New defun.
4960 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4961 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4962 (Fdbus_send_signal, Fdbus_register_service)
4963 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4964 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4965 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4966 (Vdbus_compiled_version, Vdbus_runtime_version)
4967 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4968 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4969 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4970 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4971 Adapt docstring.
dcbf5805 4972
52828e02
PE
49732012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4974
da05bc4c
PE
4975 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4976 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4977 Do not assume ptrdiff_t is the same width as 'int'.
4978
52828e02
PE
4979 * alloc.c: Handle unusual debugging option combinations.
4980 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4981 since the two debugging options are incompatible.
4982 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4983 is defined.
4984 (mem_init, mem_insert, mem_insert_fixup):
4985 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4986 (NEED_MEM_INSERT): Remove; no longer needed.
4987
f01769f9
LL
49882012-04-22 Leo Liu <sdl.web@gmail.com>
4989
4990 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4991
5790543d
PE
49922012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4993
4994 * sysdep.c [__FreeBSD__]: Minor cleanups.
4995 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4996 Use Emacs indenting style more consistently. Avoid some casts.
4997 Use 'double' consistently rather than mixing 'float' and 'double'.
4998
b91b7e4d
EW
49992012-04-21 Eduard Wiebe <usenet@pusto.de>
5000
b593d6a9
AH
5001 * sysdep.c (list_system_processes, system_process_attributes):
5002 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5003
6114eb15
AS
50042012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5005
5006 * lisp.mk (lisp): Update.
5007
2f38dff7
PE
50082012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5009
5010 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5011 It is never used otherwise.
5012
4ae29f89
SM
50132012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5014
5015 * print.c (print_preprocess): Only check print_depth if print-circle
5016 is nil.
5017 (print_object): Check for cycles even when print-circle is nil and
5018 print-gensym is t, but only check print_depth if print-circle is nil.
5019
f30d612a
CY
50202012-04-20 Chong Yidong <cyd@gnu.org>
5021
5022 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5023 set the status to "failed" and ensure that sentinel is run.
5024
c07a4c0b 50252012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5026
5027 * process.c (Fset_process_inherit_coding_system_flag)
5028 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5029 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5030
c07a4c0b 50312012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5032
5033 * xdisp.c (string_buffer_position_lim): Limit starting position to
5034 BEGV.
5035 (set_cursor_from_row): If called for a mode-line or header-line
5036 row, return zero immediately.
5037 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5038 farther than the first row after the header line, if any.
5039 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5040 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5041
c07a4c0b 50422012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5043
4ae29f89
SM
5044 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5045 (bug#11238).
ad3a2b41 5046
c07a4c0b 50472012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 50482012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5049
5050 configure: new option --enable-gcc-warnings (Bug#11207)
5051 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5052 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5053 (ALL_CFLAGS): Use new macros rather than old.
5054 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5055 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5056 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5057 -Wunused-result, -Wunused-variable. This should go away once
5058 the Emacs and Gnulib regex code is merged.
5059 (xmalloc, xrealloc): Now static.
5060
aba027e8
PE
50612012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5062
5063 * dired.c (Fsystem_groups): Remove unused local.
5064
e5a36063
GM
50652012-04-17 Glenn Morris <rgm@gnu.org>
5066
5067 * dired.c (Fsystem_users): Doc fix.
5068
316411f0
DA
50692012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5070
5071 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5072 (syms_of_dired): Add them.
5073
9426aba4
PE
50742012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5075
b62a57be
PE
5076 Fix minor alloc.c problems found by static checking.
5077 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5078 New extern decls, to avoid calling undeclared functions.
5079 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5080 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5081 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5082 (NEED_MEM_INSERT): New macro.
5083 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5084 Remove one incorrect comment and fix another.
b62a57be 5085
3539f31f
PE
5086 Fix minor ralloc.c problems found by static checking.
5087 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5088 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5089 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5090 (r_alloc_sbrk): Now static.
5091
a041960a
PE
5092 Improve ralloc.c interface checking.
5093 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5094 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5095 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5096 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5097 [REL_ALLOC]: ... to here, to check interface.
5098 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5099 Remove decls. This fixes an "It stinks!".
5100
9426aba4
PE
5101 * alloc.c (which_symbols): Fix alignment issue / type clash.
5102
d55c12ed
AS
51032012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5104
5105 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5106 (struct Lisp_Misc_Any): Likewise.
5107 (struct Lisp_Free): Likewise.
5108 * alloc.c (union aligned_Lisp_Symbol): Define.
5109 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5110 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5111 (union aligned_Lisp_Misc): Define.
5112 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5113 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5114 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5115
b948ce8b
PE
51162012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5117
5118 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5119 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5120 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5121 * s/netbsd.h, s/sol2-6.h:
5122 Remove definition of GC_MARK_STACK, since the default now works.
5123 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5124 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5125 no longer the default.
5126 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5127
35dc09a1 51282012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5129
35dc09a1
GM
5130 * lread.c (lisp_file_lexically_bound_p):
5131 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5132
35dc09a1
GM
51332012-04-14 Eli Zaretskii <eliz@gnu.org>
5134
5135 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5136 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5137
51382012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5139
5140 * nsterm.m (constrainFrameRect): Always constrain when there is only
5141 one screen (Bug#10962).
5142
bcd86815
KB
51432012-04-13 Ken Brown <kbrown@cornell.edu>
5144
5145 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5146
c25df26e
RT
51472012-04-13 Reuben Thomas <rrt@sc3d.org>
5148
5149 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5150
0fc59f1e
DC
51512012-04-11 Daniel Colascione <dancol@dancol.org>
5152
5153 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5154 against is gone. It's better to use vfork now so that when Cygwin
5155 gains a new, working vfork, we use it automatically (bug#10398).
5156
de8c03dc
SM
51572012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5158
5159 * window.c (save_window_save): Obey window-point-insertion-type.
5160
2f097256
GM
51612012-04-11 Glenn Morris <rgm@gnu.org>
5162
5163 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5164
453b951e
SM
51652012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5166
5167 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5168
75f1671a 51692012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5170
5171 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5172 (force_quit_count): New var.
5173 (handle_interrupt): Use it.
5174
2a8ce227
JB
51752012-04-10 Juanma Barranquero <lekktu@gmail.com>
5176
5177 * w32.c (w32_delayed_load): Record the full path of the library
5178 being loaded (bug#10424).
5179
935396c0
GM
51802012-04-09 Glenn Morris <rgm@gnu.org>
5181
05920a43
GM
5182 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5183 not just in the obarray, before snarfing them. (Bug#11036)
5184
935396c0
GM
5185 * Makefile.in ($(leimdir)/leim-list.el):
5186 Pass EMACS rather than BUILT_EMACS.
5187
a18ecafa
TZ
51882012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5189
5190 * process.c (make_process):
5191 * process.h: Add integer `gnutls_handshakes_tried' member to
5192 process struct.
5193
6bbef4e5
JC
5194 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5195 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5196
5197 * gnutls.c (gnutls_log_function2i): Convenience log function.
5198 (emacs_gnutls_read): Use new log functions,
5199 `gnutls_handshakes_tried' process member, and
5200 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5201 attempts per process (connection).
5202
b4d3bc10
CY
52032012-04-09 Chong Yidong <cyd@gnu.org>
5204
5205 * eval.c (Fuser_variable_p, user_variable_p_eh)
5206 (lisp_indirect_variable): Functions deleted.
5207 (Fdefvar): Caller changed.
5208
5209 * callint.c (Finteractive, Fcall_interactively):
5210 * minibuf.c (Fread_variable): Callers changed.
5211
70f4d973
EZ
52122012-04-09 Eli Zaretskii <eliz@gnu.org>
5213
5214 * xdisp.c (set_cursor_from_row): If the display string appears in
5215 the buffer at position that is closer to point than the position
5216 after the display string, display the cursor on the first glyph of
5217 the display string. Fixes cursor display when a 'display' text
5218 property immediately follows invisible text. (Bug#11094)
5219
cb3c2e3e
PE
52202012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5221
5222 composite.c: use 'double' consistently
5223 * composite.c (get_composition_id): Use 'double' consistently
5224 instead of converting 'float' to 'double' and vice versa; this is
5225 easier to understand and avoids a GCC warning.
5226
fd06db5d
GM
52272012-04-09 Glenn Morris <rgm@gnu.org>
5228
50fe702a
GM
5229 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5230 preparation for dumping it with emacs. (Bug#4789)
5231 (leimdir): New variable.
5232 ($(leimdir)/leim-list.el): New rule.
5233 (emacs$(EXEEXT)): Depend on leim-list.el.
5234
fd06db5d
GM
5235 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5236 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5237 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5238
55c131ee
AS
52392012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5240
5241 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5242 proper alignment.
5243
9209588f
JB
52442012-04-07 Juanma Barranquero <lekktu@gmail.com>
5245
5246 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5247 Remove unused local variable.
5248
e3fb2efb
PE
52492012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5250
5251 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5252 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5253 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5254 objects, as mark_maybe_pointer will catch them otherwise.
5255 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5256 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5257
b5385551
PE
52582012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5259
5260 Fix typo that broke non-Windows builds.
5261 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5262
9078ead6
EZ
52632012-04-07 Eli Zaretskii <eliz@gnu.org>
5264
5265 Support building on MS-Windows with libxml2.
5266
5267 * makefile.w32-in (OBJ2): Add xml.$(O).
5268 (GLOBAL_SOURCES): Add xml.c.
5269 ($(BLD)/xml.$(O)): New dependency list.
5270
5271 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5272 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5273 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5274 [!WINDOWSNT]: New macros.
5275 (init_libxml2_functions, libxml2_loaded_p): New functions.
5276 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5277 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5278 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5279 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5280 linked in).
6bbef4e5
JC
5281 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5282 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5283 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5284
5285 * emacs.c: Don't include libxml/parser.h.
5286 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5287 xmlCleanupParser directly.
5288
5289 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5290
3811fdf3
EZ
52912012-04-07 Eli Zaretskii <eliz@gnu.org>
5292
5293 * indent.c (Fvertical_motion): If there is a display string at
5294 point, use it.vpos to compute how many lines to backtrack after
5295 move_it_to point. (Bug#11133)
5296
2f8e16b2
EZ
52972012-04-06 Eli Zaretskii <eliz@gnu.org>
5298
5299 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5300 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5301 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5302 macros related to unification of CJK characters. For the details,
5303 see the discussion following the message here:
5304 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5305
3d439cd1
CY
53062012-04-04 Chong Yidong <cyd@gnu.org>
5307
5308 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5309
8bc53d00
EZ
53102012-04-01 Eli Zaretskii <eliz@gnu.org>
5311
5312 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5313 instead of alloca. (Bug#11138)
5314
3b0512a3
AS
53152012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5316
5317 * w32menu.c (is_simple_dialog): Properly check lisp types.
5318 (Bug#11141)
5319
8427ddd2
EZ
53202012-03-31 Eli Zaretskii <eliz@gnu.org>
5321
979022ef
EZ
5322 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5323 position we get to after a call to move_it_to fails the
5324 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5325 only if we wind up in a string from display property. (Bug#11063)
5326
a6b1c7cc
EZ
5327 * window.c (Fdelete_other_windows_internal): Invalidate the row
5328 and column information about mouse highlight, so that redisplay
5329 restores it after reallocating the glyph matrices. (Bug#7464)
5330
8427ddd2
EZ
5331 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5332 string comes from a `display' text property, use the buffer
5333 position of that property as if we actually saw that position in
5334 the row's glyphs.
697ba24b
EZ
5335 (move_it_by_lines): Remove the assertion that
5336 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5337 violated when there's a before-string at the beginning of a line.
5338 (Bug#11063)
8427ddd2 5339
65a0a738
EZ
53402012-03-30 Eli Zaretskii <eliz@gnu.org>
5341
5342 * xdisp.c (append_space_for_newline): If the default face was
5343 remapped, use the remapped face for the appended newline.
5344 (extend_face_to_end_of_line): Use the remapped default face for
5345 extending the face to the end of the line.
5346 (display_line): Call extend_face_to_end_of_line when the default
5347 face was remapped. (Bug#11068)
5348
581355cc
EZ
53492012-03-29 Eli Zaretskii <eliz@gnu.org>
5350
5351 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5352
e8fc049f
SM
53532012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5354
5355 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5356
4fb9a543
GM
53572012-03-27 Glenn Morris <rgm@gnu.org>
5358
5359 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5360 Doc fixes.
5361
679910f1
KH
53622012-03-26 Kenichi Handa <handa@m17n.org>
5363
5364 * dispextern.h (struct glyph): Fix previous change. Change the
5365 bit length of glyphless.ch to 25 (Bug#11082).
5366
90d49b7f
CY
53672012-03-26 Chong Yidong <cyd@gnu.org>
5368
5369 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5370 (command_loop_1): Use it; inhibit selection update for
5371 handle-select-window too (Bug#8996).
5372
f514f6f0
FP
53732012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5374
e8fc049f 5375 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5376
bf43fa51
KH
53772012-03-25 Kenichi Handa <handa@m17n.org>
5378
5379 * dispextern.h (struct glyph): Change the bit length of
5380 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5381
8a0c01dd
EZ
53822012-03-24 Eli Zaretskii <eliz@gnu.org>
5383
5384 * s/ms-w32.h (tzname): Include time.h before redirecting to
5385 _tzname. Fixes the MSVC build. (Bug#9960)
5386
7d1c3a76
AS
53872012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5388
8ed79523
AS
5389 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5390 characters.
5391
7d1c3a76
AS
5392 * xterm.c (XTread_socket): Only modify handling_signal if
5393 !SYNC_INPUT. (Bug#11080)
5394
e99a9b8b
EZ
53952012-03-23 Eli Zaretskii <eliz@gnu.org>
5396
5397 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5398 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5399 when fetching a multibyte character consumes more bytes than
5400 CHAR_BYTES returns, due to unification of CJK characters in
5401 string_char. (Bug#11073)
5402
5063c0e1
TN
54032012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5404
5405 * process.c (wait_reading_process_output): Handle pty disconnect
5406 by refraining from sending oneself a SIGCHLD (bug#10933).
5407
9f851fbd
CY
54082012-03-22 Chong Yidong <cyd@gnu.org>
5409
5410 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5411
5063c0e1 5412 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5413 Mark string as coming from a prefix property.
5414 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5415 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5416
fb5b8aca
CY
54172012-03-21 Chong Yidong <cyd@gnu.org>
5418
5419 * xfaces.c (Vface_remapping_alist): Doc fix.
5420
62356a1b
EZ
54212012-03-20 Eli Zaretskii <eliz@gnu.org>
5422
5423 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5424 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5425 Doc fixes.
62356a1b 5426
025de85b
CY
54272012-03-20 Chong Yidong <cyd@gnu.org>
5428
5429 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5430 to reflect default non-nil value of redisplay-dont-pause.
5431
4827f94e
KH
54322012-03-19 Kenichi Handa <handa@m17n.org>
5433
5434 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5435 it fit in a valid range (Bug#11003).
5436
e50a24a2
EZ
54372012-03-18 Eli Zaretskii <eliz@gnu.org>
5438
5439 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5440 that is not from display property, accept the row as a "cursor
5441 row" if one of the string's character has a non-nil `cursor'
5442 property. Fixes cursor positioning when there are newlines in
5443 overlay strings, e.g. in icomplete.el. (Bug#11035)
5444
9af5ed87
PE
54452012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5446
5447 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5448
d1f55f16
CY
54492012-03-12 Chong Yidong <cyd@gnu.org>
5450
5451 * eval.c (inhibit_lisp_code): Rename from
5452 inhibit_window_configuration_change_hook; move from window.c.
5453
5454 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5455 * window.c (run_window_configuration_change_hook)
5456 (syms_of_window): Callers changed.
5457
66c5eebd
CY
54582012-03-11 Chong Yidong <cyd@gnu.org>
5459
413df973
CY
5460 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5461
66c5eebd
CY
5462 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5463
1de11f56
CY
54642012-03-10 Chong Yidong <cyd@gnu.org>
5465
5466 * frame.c (other_visible_frames): Don't assume the selected frame
5467 is visible (Bug#10955).
5468
cae07000
SM
54692012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5470
5471 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5472
89c94350
JD
54732012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5474
5475 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5476 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5477 zero (Bug#10954).
5478
999dd333
GM
54792012-03-03 Glenn Morris <rgm@gnu.org>
5480
01a6dcc8 5481 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5482
de0100f2
EZ
54832012-03-02 Eli Zaretskii <eliz@gnu.org>
5484
5485 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5486 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5487 (redisplay_window, next_element_from_string): Fix typos in
5488 comments.
3e441275
EZ
5489 (redisplay_window): Pass to move_it_vertically the margin in
5490 pixels, not in screen lines.
de0100f2 5491
96a72ee9
GM
54922012-03-02 Glenn Morris <rgm@gnu.org>
5493
5494 * buffer.c (buffer-list-update-hook): Doc fix.
5495
312508d7
EZ
54962012-02-29 Eli Zaretskii <eliz@gnu.org>
5497
5498 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5499 push_it before setting up the iterator for the first overlay
5500 string, even if we have an empty string loaded.
5501 (next_overlay_string): If there's an empty string on the iterator
5502 stack, pop the stack. (Bug#10903)
5503
27f3c637
PE
55042012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5505
5506 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5507 Suggested by Stefan Monnier in
5508 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5509 * alloc.c (widen_to_Lisp_Object): New static function.
5510 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5511 and widening them to Lisp_Objects. This would work even if
5512 USE_LSB_TAG is defined and wide integers are used, which might
5513 happen in a future version of Emacs.
5514
3c9dfce6
CY
55152012-02-25 Chong Yidong <cyd@gnu.org>
5516
fa74b241
CY
5517 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5518 Doc fix.
5519
3c9dfce6
CY
5520 * xselect.c (Fx_selection_exists_p): Doc fix.
5521 (x_clipboard_manager_save_all): Print an informative message
5522 before saving to clipboard manager.
5523
9486df08
CY
55242012-02-24 Chong Yidong <cyd@gnu.org>
5525
5526 * keyboard.c (process_special_events): Handle all X selection
5527 requests in kbd_buffer, not just the next one (Bug#8869).
5528
f01d3321
CY
55292012-02-23 Chong Yidong <cyd@gnu.org>
5530
5531 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5532 call when setting menu-bar-lines and tool-bar-lines parameters.
5533 (unwind_create_frame_1): New helper function.
5534
5535 * window.c (inhibit_window_configuration_change_hook): New var.
5536 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5537 (syms_of_window): Initialize it.
f01d3321 5538
86b847b6
CY
55392012-02-22 Chong Yidong <cyd@gnu.org>
5540
5541 * xterm.c (x_draw_image_relief): Add missing type check for
5542 Vtool_bar_button_margin (Bug#10743).
5543
a59225b1
CY
55442012-02-21 Chong Yidong <cyd@gnu.org>
5545
5546 * fileio.c (Vfile_name_handler_alist): Doc fix.
5547
5548 * buffer.c (Fget_file_buffer): Protect against invalid file
5549 handler return value.
5550
310f5bd4
PE
55512012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5552
cb3a28cc
PE
5553 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5554 when computing $valmask.
5555
310f5bd4
PE
5556 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5557 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5558 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5559 It's useless in that case, and it can cause problems on hosts
5560 that allocate halves of EMACS_INT values separately.
5561 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5562 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5563 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5564 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5565 it avoids undefined behavior on hosts where shifting right by more
5566 than the word width has undefined behavior.
5567
2375c96a
CY
55682012-02-19 Chong Yidong <cyd@gnu.org>
5569
5570 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5571 (Funhandled_file_name_directory, Ffile_name_as_directory)
5572 (Fdirectory_file_name, Fexpand_file_name)
5573 (Fsubstitute_in_file_name): Protect against invalid file handler
5574 return values (Bug#10845).
5575
3eb49e71
EZ
55762012-02-18 Eli Zaretskii <eliz@gnu.org>
5577
5578 * .gdbinit (pitx): Fix incorrect references to fields of the
5579 iterator stack.
5580
7b926f3f
CY
55812012-02-17 Chong Yidong <cyd@gnu.org>
5582
5583 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5584
11273115
PE
55852012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5586
5587 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5588 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5589
c3a70e2b
CY
55902012-02-15 Chong Yidong <cyd@gnu.org>
5591
5592 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5593 marked as special. Also, starting docstrings with * is obsolete.
5594
0ca43699
AS
55952012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5596
5597 * gnutls.c (emacs_gnutls_write): Fix last change.
5598
2e8f3c56
LI
55992012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5600
5601 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5602 send_process.
5603
af70074f
SM
56042012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5605
5606 * keymap.c (Fsingle_key_description): Handle char ranges.
5607
95986d52
CY
56082012-02-12 Chong Yidong <cyd@gnu.org>
5609
afd83bd1
CY
5610 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5611 as that creates a dangerous corner case.
5612
95986d52
CY
5613 * window.c (Fdelete_window_internal): Invalidate the mouse
5614 highlight (Bug#9904).
5615
bd7da63e
GM
56162012-02-12 Glenn Morris <rgm@gnu.org>
5617
5618 * xselect.c (Fx_own_selection_internal)
5619 (Fx_get_selection_internal, Fx_disown_selection_internal)
5620 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5621 * nsselect.m (Fx_own_selection_internal)
5622 (Fx_disown_selection_internal, Fx_selection_exists_p)
5623 (Fx_selection_owner_p, Fx_get_selection_internal):
5624 Sync docs and argument specs with the xselect.c versions.
5625
77abcbc2
LI
56262012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5627
5628 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5629
90b671e2
EZ
56302012-02-11 Eli Zaretskii <eliz@gnu.org>
5631
1c0ca0b7
EZ
5632 * w32select.c (Fx_selection_exists_p): Sync doc string and
5633 argument list with xselect.c. (Bug#10783)
5634
5635 * w16select.c (Fx_selection_exists_p): Sync doc string and
5636 argument list with xselect.c. (Bug#10783)
90b671e2 5637
49241268
GM
56382012-02-10 Glenn Morris <rgm@gnu.org>
5639
5640 * fns.c (Fsecure_hash): Doc fix.
5641
f998bbe7 56422012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5643
5644 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5645
0992bd9c
CY
56462012-02-07 Chong Yidong <cyd@gnu.org>
5647
5648 * buffer.c (Fbuffer_local_variables)
5649 (buffer_lisp_local_variables): Handle unbound vars correctly;
5650 don't let Qunbound leak into Lisp.
5651
af008560
GM
56522012-02-07 Glenn Morris <rgm@gnu.org>
5653
dd605cc4
GM
5654 * image.c (Fimagemagick_types): Doc fix.
5655
af008560
GM
5656 * image.c (imagemagick-render-type): Change it from a lisp object
5657 to an integer. Move the doc here from the lisp manual.
5658 Treat all values not equal to 0 the same.
5659
1449fa1d
CY
56602012-02-06 Chong Yidong <cyd@gnu.org>
5661
5662 * doc.c (store_function_docstring): Avoid applying docstring of
5663 alias to base function (Bug#2603).
5664
3723ec07
AS
56652012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5666
5667 * .gdbinit (pp1, pv1): Remove redundant defines.
5668 (pr): Use pp.
5669
79c1cc1e
CY
56702012-02-04 Chong Yidong <cyd@gnu.org>
5671
5672 * nsterm.m: Declare a global (Bug#10694).
5673
d7f29f8e
EZ
56742012-02-04 Eli Zaretskii <eliz@gnu.org>
5675
cae07000
SM
5676 * w32.c (get_emacs_configuration_options):
5677 Include --enable-checking, if specified, in the return value.
d7f29f8e 5678
3b95a6f9
MR
56792012-02-04 Martin Rudalics <rudalics@gmx.at>
5680
5681 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5682 after rounding frame sizes. (Bug#9723)
5683
d6fa96a6
EZ
56842012-02-04 Eli Zaretskii <eliz@gnu.org>
5685
5686 * keyboard.c (adjust_point_for_property): Don't position point
5687 before BEGV. (Bug#10696)
5688
df0b2940
PE
56892012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5690
5691 Handle overflow when computing char display width (Bug#9496).
5692 * character.c (char_width): Return EMACS_INT, not int.
5693 (char_width, c_string_width): Check for overflow when
5694 computing the width; this is possible now that individual
5695 characters can have unbounded width. Problem introduced
5696 by merge from Emacs 23 on 2012-01-19.
5697
6bee44d6
MA
56982012-02-02 Michael Albinus <michael.albinus@gmx.de>
5699
5700 * dbusbind.c (Fdbus_register_method): Mention the return value
5701 :ignore in the docstring.
5702
44f92739
GM
57032012-02-02 Glenn Morris <rgm@gnu.org>
5704
1b9f60cc
GM
5705 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5706
44f92739
GM
5707 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5708 Unconditionally set to t. (Bug#10673)
5709 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5710 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5711 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5712
c5d3843c
KH
57132012-02-02 Kenichi Handa <handa@m17n.org>
5714
5715 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5716 0, do not call append_composite_glyph.
5717
159462d4 57182012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5719
5720 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5721 NULL (Bug#6988).
5722 (x_produce_glyphs): If the component of a composition is a null
5723 string, set it->pixel_width to 1 to avoid zero-width glyph.
5724
78cef877
EZ
57252012-02-01 Eli Zaretskii <eliz@gnu.org>
5726
5727 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5728 first 2 arguments are identical. This makes inserting large
5729 output from a subprocess an order of magnitude faster on
5730 MS-Windows, where all sbrk'ed memory is always contiguous.
5731
97897668
GM
57322012-01-31 Glenn Morris <rgm@gnu.org>
5733
5734 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5735 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5736 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5737
31fd3586
GM
57382012-01-29 Glenn Morris <rgm@gnu.org>
5739
5740 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5741
0e24a8b2
CY
57422012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5743
5744 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5745
cc0adcb0
CY
57462012-01-28 Chong Yidong <cyd@gnu.org>
5747
5748 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5749
acc28cb9
CY
57502012-01-26 Chong Yidong <cyd@gnu.org>
5751
9c69cfb7
CY
5752 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5753
acc28cb9
CY
5754 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5755 repeat counts (Bug#10507).
5756
48da7392
GM
57572012-01-26 Glenn Morris <rgm@gnu.org>
5758
5759 * lread.c (syms_of_lread): Doc fix.
5760
14af5f7f
CY
57612012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5762
5763 * coding.c (encode_designation_at_bol): Change return value to
5764 EMACS_INT.
5765
0b21c100
CY
57662012-01-25 Chong Yidong <cyd@gnu.org>
5767
5768 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5769
3c2907f7
CY
57702012-01-21 Chong Yidong <cyd@gnu.org>
5771
5772 * floatfns.c (Fcopysign): Make the second argument non-optional,
5773 since nil is not allowed anyway.
5774
959ad23f
AS
57752012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5776
5777 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5778 (send_process): Likewise.
5779
34a02f46
MR
57802012-01-19 Martin Rudalics <rudalics@gmx.at>
5781
5782 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5783 (Vwindow_persistent_parameters): Do not use Qstate.
5784 Rewrite doc-strings.
34a02f46 5785
1259009a 57862012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5787
5788 * character.c (char_width): New function.
70d4fdf6
GM
5789 (Fchar_width, c_string_width, lisp_string_width):
5790 Use char_width (Bug#9496).
25ed9e61 5791
6a6ee00d
MR
57922012-01-16 Martin Rudalics <rudalics@gmx.at>
5793
5794 * window.c (Vwindow_persistent_parameters): New variable.
5795 (Fset_window_configuration, save_window_save): Handle persistent
5796 window parameters.
5797
c85efaf7
EZ
57982012-01-14 Eli Zaretskii <eliz@gnu.org>
5799
5800 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5801 thrashing the stack of the thread. (Bug#9087)
5802
5944709e
PE
58032012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5804
5805 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5806
e71f5d99
EZ
58072012-01-11 Eli Zaretskii <eliz@gnu.org>
5808
5809 * xdisp.c (rows_from_pos_range): Handle the case where the
5810 highlight ends on a newline. (Bug#10464)
5811 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5812 he end column for display of highlight that ends on a newline
5813 before a R2L line.
5814
ce316182
GM
58152012-01-11 Glenn Morris <rgm@gnu.org>
5816
5817 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5818 from load-path also when installation-directory is nil. (Bug#10208)
5819
5b43da69
GM
58202012-01-10 Glenn Morris <rgm@gnu.org>
5821
74cc8ff9
GM
5822 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5823
7d8d6e4e
GM
5824 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5825 Update template values to be closer to their typical values these days.
5b43da69 5826
a0db8d43
EZ
58272012-01-09 Eli Zaretskii <eliz@gnu.org>
5828
5829 * xdisp.c (rows_from_pos_range): Accept additional argument
5830 DISP_STRING, and accept any glyph in a row whose object is that
5831 string as eligible for mouse highlight. Fixes mouse highlight of
5832 display strings from overlays. (Bug#10464)
5833
9a0115ab 58342012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5835
b9110d6a 5836 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5837 * fileio.c (auto_saving_dir_umask): New static var.
5838 (Fmake_directory_internal): Use it.
5839 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5840 creating the directory. The old code temporarily assigns
5841 too-generous permissions to the directory.
5842 (do_auto_save_eh): Clear it.
b9110d6a 5843 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5844 that the var is always cleared.
5845
6c1bd3f3
EZ
58462012-01-07 Eli Zaretskii <eliz@gnu.org>
5847
5848 * search.c (scan_buffer): Pass character positions to
5849 know_region_cache, not byte positions. (Bug#6540)
5850
069d2b50
L
58512012-01-07 LynX <_LynX@bk.ru> (tiny change)
5852
5853 * w32.c (sys_rename): Report EXDEV when rename of a directory
5854 fails because the target is on another logical disk. (Bug#10284)
5855
75bf0d33
DB
58562012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5857
5858 * xterm.c (x_embed_request_focus): New function.
5859
5860 * xterm.h: Add prototype.
5861
5862 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5863
1c6e5a32
GM
58642012-01-05 Glenn Morris <rgm@gnu.org>
5865
5866 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5867
651e947e
EZ
58682012-01-01 Eli Zaretskii <eliz@gnu.org>
5869
5870 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5871 Load gnutls_transport_set_lowat only if GnuTLS version is below
5872 2.11.1.
5873 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5874 GnuTLS versions below 2.11.1.
5875
3778cdd8
AL
58762011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5877
5878 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5879 to the doc string advising against its use for altering the way
5880 windows are scrolled.
5881
0e5317f7
KH
58822011-12-28 Kenichi Handa <handa@m17n.org>
5883
5884 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5885 coding-system ASCII compatible only when it does not produce BOM
5886 on encoding (Bug#10383).
5887
93d5ca1f
JD
58882011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5889
5890 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5891 can scroll.
5892 (create_and_show_popup_menu): Always use menu_position_func for
5893 Gtk3 (Bug#10361).
5894
ca22b785
AS
58952011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5896
5897 * callint.c (Fcall_interactively): Don't truncate prompt string.
5898
d048e1e6
EZ
58992011-12-23 Eli Zaretskii <eliz@gnu.org>
5900
5901 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5902 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5903 resumed from there (after widening). (Bug#10360)
d048e1e6 5904
5ccaba1f
JD
59052011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5906
5907 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5908
204ee57f
JD
59092011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5910
b81d40f0
JB
5911 * nsterm.m (x_free_frame_resources):
5912 Release f->output_data.ns->miniimage.
204ee57f
JD
5913 (ns_index_color): Fix indentation. Do not retain
5914 color_table->colors[i].
5915
5916 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5917 before returning.
5918
5919 * nsfns.m (x_set_background_color): Assign return value from
5920 ns_index_color to face-background instead of NSColor*.
5921 (ns_implicitly_set_icon_type): Fix indentation.
5922 Change assignment in for loop to comparison.
5923
5924 * emacs.c (ns_pool): New variable.
5925 (main): Assign ns_pool.
5926 (Fkill_emacs): Call ns_release_autorelease_pool.
5927
5928 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5929 autorelease fdesc, release fdAttrs and tdict.
5930 (ns_get_covering_families): Release charset.
5931 (ns_findfonts): Release NSFontDescriptor created with new.
5932 (ns_uni_to_glyphs): Fix indentation.
5933 (setString): Release attrStr before assigning new value.
5934
c803b2b7
JD
59352011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5936
678f4426
JD
5937 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5938 and NS_IMPL_COCOA.
5939 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5940 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5941
cd394be1 59422011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5943
5fecd5fc
JD
5944 * nsterm.m (ns_term_init): Subscribe for notifications
5945 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5946 to method trackingNotification in EmacsMenu.
5947
5948 * nsmenu.m (trackingMenu): New variable.
3771cb17 5949 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5950 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5951 from Aquamacs (Bug#7030).
678f4426
JD
5952
59532011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5954
c803b2b7
JD
5955 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5956 (symbol_to_nsstring): Fix indentation.
5957 (ns_symbol_to_pb): New function.
cae07000
SM
5958 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5959 (Fns_rotate_cut_buffers_internal): Remove.
5960 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5961 Fns_store_cut_buffer_internal.
5962 (ns_get_foreign_selection, Fx_own_selection_internal)
5963 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5964 (Fns_get_selection_internal, Fns_store_selection_internal):
5965 Use ns_symbol_to_pb and check if return value is nil.
5966 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5967 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5968 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5969 renamed to Sns_store_selection_internal.
5970 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5971 and remove this function.
5972 (ns_handle_selection_clear): Remove, never used.
5973 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5974 here.
5975
e1b01a3a
KB
59762011-12-17 Ken Brown <kbrown@cornell.edu>
5977
5978 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5979 GID is unknown (Bug#10257).
5980
2adb6e85
PE
59812011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5982
5983 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5984 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5985 which caused a build failure on GNU/Linux IA-64. This problem was
5986 introduced by my 2011-10-07 patch.
5987
d1d7b339
JL
59882011-12-15 Juri Linkov <juri@jurta.org>
5989
5990 * image.c (imagemagick_error): New function. (Bug#10112)
5991 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5992 Use `imagemagick_error' where ImageMagick functions return
5993 `MagickFalse'.
5994 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5995 proper order.
5996
100d5755
KH
59972011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5998
5999 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6000 fill background (Bug#8992).
6001
454592a6
MR
60022011-12-13 Martin Rudalics <rudalics@gmx.at>
6003
6004 * window.c (Vwindow_combination_resize)
6005 (Vwindow_combination_limit): Use t instead of non-nil in
6006 doc-strings.
61d4b438
MR
6007 (Vrecenter_redisplay): Add first sentence of doc-string on
6008 separate line.
53524d93 6009 (Frecenter): Fix doc-string typo.
454592a6 6010
3633e3aa
KH
60112011-12-11 Kenichi Handa <handa@m17n.org>
6012
6013 * coding.c (Funencodable_char_position): Pay attention to the
6014 buffer text relocation (Bug#9389).
6015
7b9d523a 60162011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6017
7b9d523a
JD
6018 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6019 gtk_init (Bug#10100).
6020
b73189c6
EZ
60212011-12-10 Eli Zaretskii <eliz@gnu.org>
6022
6023 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6024 IT->string is nil. (Bug#10263)
6025
f7dfe5d6
JD
60262011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6027
83faebb4
JD
6028 * nsterm.h (x_free_frame_resources): Declare.
6029
f7dfe5d6
JD
6030 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6031 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6032
6033 * nsterm.h (ns_get_defaults_value): Declare.
6034
6035 * nsterm.m (ns_default): Call ns_get_defaults_value.
6036
7cd4e72c
EZ
60372011-12-09 Eli Zaretskii <eliz@gnu.org>
6038
6039 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6040 (Bug#10170)
6041
b34d7317
YM
60422011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6043
6044 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6045 that where the value of an _OBJC_* symbol points to is in the .bss
6046 section (Bug#10240).
6047
76470ad1
KH
60482011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6049
6050 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6051 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6052
745fff94
KH
60532011-12-08 Kenichi Handa <handa@m17n.org>
6054
6055 * ftfont.c (get_adstyle_property): Fix previous change
6056 (Bug#10233).
6057
6e44397c
JB
60582011-12-07 Juanma Barranquero <lekktu@gmail.com>
6059
6060 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6061 dirs from the default value of EMACSLOADPATH (bug#10208).
6062
7efa6272
GM
60632011-12-07 Glenn Morris <rgm@gnu.org>
6064
6065 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6066 installation and source directories as well. (Bug#10208)
6067
f6fc4d87
CY
60682011-12-06 Chong Yidong <cyd@gnu.org>
6069
6070 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6071
2bf26180
GM
60722011-12-06 Glenn Morris <rgm@gnu.org>
6073
6074 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6075 as an error, not just -1. (Bug#10217)
6076
3a6ad4f0
CY
60772011-12-05 Chong Yidong <cyd@gnu.org>
6078
6079 * keyboard.c (process_special_events): New function.
6080 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6081
75a3b399
PE
60822011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6083
6084 * coding.c (encode_designation_at_bol): Don't use uninitialized
6085 local variable (Bug#9318).
6086
c3c9e25e
KH
60872011-12-05 Kenichi Handa <handa@m17n.org>
6088
6089 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6090 return Qnil (Bug#8046, Bug#10193).
6091
5eb05ea3
KH
60922011-12-05 Kenichi Handa <handa@m17n.org>
6093
6094 * coding.c (encode_designation_at_bol): New args charbuf_end and
6095 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6096 (coding_set_source): Return how many bytes coding->source was
6097 relocated.
6098 (coding_set_destination): Return how many bytes
6099 coding->destination was relocated.
6100 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6101 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6102
61032011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6104
6105 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6106 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6107 macro (Bug#9318).
6108
61092011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6110
6111 The following changes are to fix Bug#9318.
6112
a79703f5 6113 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6114 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6115 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6116 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6117
7dbda6df
JB
61182011-12-05 Juanma Barranquero <lekktu@gmail.com>
6119
6120 * lisp.h (process_quit_flag): Fix external declaration.
6121
6d5eb5b0
SM
61222011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6123
6124 Don't macro-inline non-performance-critical code.
6125 * eval.c (process_quit_flag): New function.
6126 * lisp.h (QUIT): Use it.
6127
a0c3fad0
JD
61282011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6129
6130 * nsfns.m (get_geometry_from_preferences): New function.
6131 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6132
6c07aac2
AS
61332011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6134
6135 * emacs.c (Qkill_emacs): Define.
6136 (syms_of_emacs): Initialize it.
6137 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6138 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6139 (quit_throw_to_read_char): Add parameter `from_signal'.
6140 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6141 * lisp.h (QUIT): Call Fkill_emacs if requested.
6142
c052ead4
JD
61432011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6144
6145 * widget.c (update_wm_hints): Return if wmshell is null.
6146 (widget_update_wm_size_hints): New function.
6147
6148 * widget.h (widget_update_wm_size_hints): Declare.
6149
6150 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6151 widget_update_wm_size_hints (Bug#10104).
6152
9e49252b
EZ
61532011-12-03 Eli Zaretskii <eliz@gnu.org>
6154
6155 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6156 before a newline, prepare the bidi iterator for consuming the
6157 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6158 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6159
02b16839
JL
61602011-12-02 Juri Linkov <juri@jurta.org>
6161
6162 * search.c (Fword_search_regexp): New Lisp function created from
6163 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6164 (Fword_search_backward, Fword_search_forward)
6165 (Fword_search_backward_lax, Fword_search_forward_lax):
6166 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6167 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6168
0068070e
SM
61692011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6170
6171 * fileio.c (Finsert_file_contents): Move after-change-function call
6172 to before the "handled:" label, since all "goto handled" appear in
6173 cases where the *-change-functions have already been properly called
6174 (bug#10117).
6175
3360a3fc
AS
61762011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6177
6178 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6179 waiting for input. (Bug#10169)
6180
73d6c093
EZ
61812011-11-30 Eli Zaretskii <eliz@gnu.org>
6182
6183 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6184 verifies glyph row's hash code--we have just reallocated the
6185 glyphs, so their contents can be complete garbage. (Bug#10164)
6186
febe6bea
JB
61872011-11-30 Juanma Barranquero <lekktu@gmail.com>
6188
6189 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6190
801a4313
EZ
61912011-11-30 Eli Zaretskii <eliz@gnu.org>
6192
6193 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6194 attributes are tested _before_ calling verify_row_hash, to protect
6195 against GCC re-ordering of the tests. (Bug#10164)
6196
2b56b87e
JD
61972011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6198
6199 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6200
6201 * xterm.c (handle_one_xevent): Only set async_visible and friends
6202 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6203 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6204 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6205
dbf31225
PE
62062011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6207
6208 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6209 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6210 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6211 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6212 All uses changed to use GCPRO1 etc.
6213 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6214 Revert to old implementation (i.e., before 2011-03-11).
6215
1305621b
YM
62162011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6217
6218 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6219 of scroll runs so as to avoid assigning disabled bogus rows and
6220 unnecessary graphics copy operations.
6221
8c9afb46
EZ
62222011-11-27 Eli Zaretskii <eliz@gnu.org>
6223
6224 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6225 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6226 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6227 (malloc, free, realloc, calloc): Redirect to e_* only when
6228 compiling Emacs.
6229
6230 * lisp.h (GCTYPEBITS): Move before first use.
6231 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6232 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6233 this macro definition.
6234
6235 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6236 _MSC_VER.
6237
54e9e3bf
JD
62382011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6239
6d5eb5b0
SM
6240 * gtkutil.c (xg_create_frame_widgets):
6241 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6242 present with Gtk+ 2.0.
6243
83aca1cb
PE
62442011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6245
6246 * fileio.c (Finsert_file_contents): Undo previous change; see
6247 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6248
5b76caa4
PE
62492011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6250
6251 Rename locals to avoid shadowing.
6252 * fileio.c (Finsert_file_contents):
6253 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6254 * process.c (wait_reading_process_output):
6255 Rename inner 'proc' to 'p' to avoid shadowing.
6256 Indent for consistency with usual Emacs style.
6257
8c535114
EZ
62582011-11-25 Eli Zaretskii <eliz@gnu.org>
6259
6260 * xdisp.c (redisplay_window): If cursor row is not fully visible
6261 after recentering, and scroll-conservatively is set to a large
6262 number, scroll window by a few more lines to make the cursor fully
6263 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6264 (start_display): Don't move to the next line if the display should
6265 start at a newline that is part of a display vector or an overlay
6266 string. (Bug#10119)
8c535114 6267
fa4fdb5c
JL
62682011-11-24 Juri Linkov <juri@jurta.org>
6269
6270 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6271 after the `MagickPingImage' call. (Bug#10112)
6272
90ec88df
CY
62732011-11-23 Chong Yidong <cyd@gnu.org>
6274
6275 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6276
56e2e794
MR
62772011-11-23 Martin Rudalics <rudalics@gmx.at>
6278
6279 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6280 making another buffer current. (Bug#10114)
6281
b6e64c41
GM
62822011-11-23 Glenn Morris <rgm@gnu.org>
6283
6284 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6285
6b21de18
CY
62862011-11-23 Chong Yidong <cyd@gnu.org>
6287
6288 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6289 using it (Bug#5984).
6290
b12cd789
EZ
62912011-11-22 Eli Zaretskii <eliz@gnu.org>
6292
6293 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6294 and header-lines, as they don't have one computed for them.
6295 (Bug#10098)
6296
6297 * .gdbinit (prow): Make displayed values more self-explaining.
6298 Add row's hash code.
6299
261b6fd4
LMI
63002011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6301
6302 * process.c (wait_reading_process_output): Fix asynchrounous
6303 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6304 (wait_reading_process_output): Add comment and URL.
261b6fd4 6305
e7cfd277
JD
63062011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6307
6308 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6309
a9b9b7f5
CY
63102011-11-21 Chong Yidong <cyd@gnu.org>
6311
6312 * window.c (Fnext_window, Fprevious_window): Doc fix.
6313
b0d15b4f
SM
63142011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6315
6316 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6317
fe7a3057
JB
63182011-11-20 Juanma Barranquero <lekktu@gmail.com>
6319
6320 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6321
d2999b1a
MR
63222011-11-20 Martin Rudalics <rudalics@gmx.at>
6323
6324 * window.c (Fset_window_combination_limit): Rename argument
6325 STATUS to LIMIT.
6326 (Vwindow_combination_limit): Remove "status" from doc-string.
6327
d5ff9cd0
AS
63282011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6329
6330 * m/ibms390.h: Remove.
6331 * m/ibms390x.h: Don't include "ibms390.h".
6332
a5bb9bd3
SM
63332011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6334
6335 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6336 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6337
cd1181db
JB
63382011-11-20 Juanma Barranquero <lekktu@gmail.com>
6339
6340 * casetab.c (Fset_case_table):
6341 * charset.c (Fcharset_after): Fix typos.
6342
615a3b8d 63432011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6344
17e845af
PE
6345 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6346 Otherwise, valgrind does not work on some platforms.
6347 Problem reported by Andreas Schwab in
6a0bf43d
PE
6348 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6349 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6350 is set, removing the need for VIRT_ADDRESS_VARIES.
6351 (PURE_P): Use a more-efficient implementation that needs just one
6352 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6353 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6354 to 4 (xorl, subq, cmpq, setbe).
6355 * alloc.c (pure): Always extern now, since that's the
6356 VIRT_ADDR_VARIES behavior.
6357 (PURE_POINTER_P): Use a single comparison, not two, for
6358 consistency with the new puresize.h.
6359 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6360 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6361 Remove VIRT_ADDR_VARIES no longer needed.
6362
f8fe6f96
EZ
63632011-11-19 Eli Zaretskii <eliz@gnu.org>
6364
6365 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6366 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6367 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6368 behave as if the cursor position were at the window margin.
6369
6370 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6371 and the cursor position is out of bounds, behave as if the cursor
6372 position were at the window margin. (Bug#10075)
6373
df05a53c
CY
63742011-11-18 Chong Yidong <cyd@gnu.org>
6375
6376 * window.c (Fwindow_combination_limit): Make first argument
6377 non-optional, since it is meaningless for live windows like the
6378 selected window.
61ccba97 6379
2071918e
DA
63802011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6381
6382 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6383
b50a28de
SM
63842011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6385
6386 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6387 (graft_intervals_into_buffer): Simplify.
6388
015137db
EZ
63892011-11-18 Eli Zaretskii <eliz@gnu.org>
6390
6391 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6392 hash values of the two rows.
6393 (copy_row_except_pointers): Preserve the used[] arrays and the
6394 hash values of the two rows. (Bug#10035)
68c95424 6395 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6396
6397 * xdisp.c (row_hash): New function, body extracted from
6398 compute_line_metrics.
6399 (compute_line_metrics): Call row_hash, instead of computing the
6400 hash code inline.
6401
6402 * dispnew.c (verify_row_hash): Call row_hash for computing the
6403 hash code of a row, instead of duplicating code from xdisp.c.
6404
6405 * dispextern.h (row_hash): Add prototype.
6406
a2addb04
TH
64072011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6408
6409 * frame.c (delete_frame): Don't delete the terminal when the last
6410 X frame is closed if emacs is built with GTK toolkit.
6411
df85d315
JB
64122011-11-17 Juanma Barranquero <lekktu@gmail.com>
6413
6414 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6415
a0c2d0ae
MR
64162011-11-17 Martin Rudalics <rudalics@gmx.at>
6417
6418 * window.c (Vwindow_splits): Rename to
6419 Vwindow_combination_resize. Suggested by Juri Linkov.
6420 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6421 of Vwindow_splits.
6422
58179cce
JB
64232011-11-16 Juanma Barranquero <lekktu@gmail.com>
6424
7877f373
JB
6425 * nsfns.m (Fns_font_name):
6426 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6427
b6f67890
MR
64282011-11-16 Martin Rudalics <rudalics@gmx.at>
6429
6430 * window.h (window): Rename slot "nest" to "combination_limit".
6431 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6432 (Fset_window_nest): Rename to Fset_window_combination_limit.
6433 (Vwindow_nest): Rename to Vwindow_combination_limit.
6434 (recombine_windows, make_parent_window, make_window)
6435 (Fsplit_window_internal, saved_window)
6436 (Fset_window_configuration, save_window_save): Rename all
6437 occurrences of window_nest to window_combination_limit.
6438
c7015153
JB
64392011-11-15 Juanma Barranquero <lekktu@gmail.com>
6440
6441 * image.c (imagemagick_load_image): Fix typo.
6442
322ad6ec
EZ
64432011-11-14 Eli Zaretskii <eliz@gnu.org>
6444
6445 * xdisp.c (display_line): Move the call to
6446 highlight_trailing_whitespace before the call to
6447 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6448 faces of all the glyphs to compute ROW's hash value.
6449 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6450
f067b8ec
JB
64512011-11-14 Juanma Barranquero <lekktu@gmail.com>
6452
6453 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6454 just return (bug#10044).
6455
1e5b2111
EZ
64562011-11-12 Eli Zaretskii <eliz@gnu.org>
6457
7ef3cbd5
EZ
6458 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6459 with user-defined heap size. Bump the default size of the temacs
6460 heap to 27MB, to avoid memory warning when running temacs.
6461 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6462
1e5b2111
EZ
6463 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6464 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6465 (verify_row_hash) [XASSERTS]: New function.
6466 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6467 that the hash value of glyph rows is correct.
1e5b2111 6468
89d61221
MR
64692011-11-12 Martin Rudalics <rudalics@gmx.at>
6470
6471 * window.h (window): Remove splits slot.
6472 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6473 (Fdelete_other_windows_internal, make_parent_window)
6474 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6475 (Fset_window_configuration, save_window_save): Don't deal with
6476 split status of windows.
6477 (saved_window): Remove splits slot.
6478 (Vwindow_splits): Rewrite doc-string.
6479
97f18cc8
JD
64802011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6481
6482 * xfns.c (unwind_create_frame):
6483 * nsfns.m (unwind_create_frame):
6484 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6485 Vframe_list (Bug#9999).
6486
22a648b4
DA
64872011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6488
0b381c7e 6489 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6490
659afede
KH
64912011-11-11 Kenichi Handa <handa@m17n.org>
6492
6493 * callproc.c (Fcall_process): Set the member dst_multibyte of
6494 process_coding.
6495
9ac0394b
KH
64962011-11-11 Johan Bockgård <bojohan@gnu.org>
6497
6498 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6499 avoid a crash (bug#9496).
6500
2fbdc249
CY
65012011-11-09 Chong Yidong <cyd@gnu.org>
6502
6503 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6504 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6505
ac6b1f81
PE
65062011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6507
6508 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6509
09db192c
PE
65102011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6511
6512 Avoid some portability problems by eschewing 'extern inline' functions.
6513 The trivial performance wins aren't worth the portability hassles; see
6514 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6515 et seq.
6516 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6517 (window_box_width, window_box_left, window_box_left_offset)
6518 (window_box_right, window_box_right_offset): Undo previous change,
6519 by removing the "extern"s.
6520 * intervals.c (adjust_intervals_for_insertion)
6521 (adjust_intervals_for_deletion): Undo previous change,
6522 making these static again.
6523 (offset_intervals, temp_set_point_both, temp_set_point)
6524 (copy_intervals_to_string): No longer inline.
6525 * xdisp.c (window_text_bottom_y, window_box_width)
6526 (window_box_height, window_box_left_offset)
6527 (window_box_right_offset, window_box_left, window_box_right)
6528 (window_box): No longer inline.
6529
105216ed
CY
65302011-11-08 Chong Yidong <cyd@gnu.org>
6531
6532 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6533 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6534 Signal an error if not a live window.
105216ed
CY
6535 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6536 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6537
ae9e237f
JB
65382011-11-07 Juanma Barranquero <lekktu@gmail.com>
6539
6540 * lisp.h (syms_of_abbrev): Remove declaration.
6541 Reported by CHENG Gao <chenggao@royau.me>.
6542
c7aa8333
EZ
65432011-11-07 Eli Zaretskii <eliz@gnu.org>
6544
6545 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6546 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6547 of temacs in GUI mode.
6548
be7f5545
MR
65492011-11-07 Martin Rudalics <rudalics@gmx.at>
6550
6551 * window.h: Declare delete_all_child_windows instead of
6552 delete_all_subwindows.
6553 * window.c (Fwindow_nest, Fset_window_nest)
6554 (Fset_window_new_total, Fset_window_new_normal)
6555 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6556 (delete_all_subwindows): Rename to delete_all_child_windows.
6557 (Fdelete_other_windows_internal, Fset_window_configuration):
6558 Call delete_all_child_windows instead of delete_all_subwindows.
6559 * frame.c (delete_frame): Call delete_all_child_windows instead
6560 of delete_all_subwindows.
6561
ca78dc43
PE
65622011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6563
6564 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6565 This is also needed for porting to any host where GC_MARK_STACK is
6566 not GC_MAKE_GCPROS_NOOPS.
6567 (which_symbols): Use it.
6568
a0241d01
KH
65692011-11-07 Kenichi Handa <handa@m17n.org>
6570
6571 * coding.c (coding_set_destination): Check coding->src_pos only
6572 when coding->src_object is a buffer (bug#9910).
6573
6574 * process.c (send_process): Set the member src_multibyte of coding
6575 to 0 (bug#9911) when sending a unibyte text.
6576
6577 * callproc.c (Fcall_process): Set the member src_multibyte of
6578 process_coding to 0 (bug#9912).
6579
a64bfdfa 65802011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6581
6582 * xmenu.c (cleanup_widget_value_tree): New function.
6583 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6584 calling free_menubar_widget_value_tree directly (Bug#9830).
6585
cb41b32a
PE
65862011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6587
6588 Fix some portability problems with 'inline'.
6589 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6590 (window_box_width, window_box_left, window_box_left_offset)
6591 (window_box_right, window_box_right_offset): Declare extern.
6592 Otherwise, these inline functions do not conform to C99 and
6593 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6594 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6595 * intervals.c (adjust_intervals_for_insertion)
6596 (adjust_intervals_for_deletion): Now extern, because otherwise the
6597 extern inline functions 'offset_intervals' couldn't refer to it.
6598 (static_offset_intervals): Remove.
6599 (offset_intervals): Rewrite using the old contents of
6600 static_offset_intervals. The old version didn't conform to C99
6601 because an extern inline function contained a reference to an
6602 identifier with static linkage.
6603
b7041366
AS
66042011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6605
6606 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6607 GC.
6608
88a37c4d
EZ
66092011-11-06 Eli Zaretskii <eliz@gnu.org>
6610
6611 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6612 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6613 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6614 return Qleft_to_right.
6615
49745b39
CY
66162011-11-06 Chong Yidong <cyd@gnu.org>
6617
6618 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6619 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6620 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6621 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6622 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6623 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6624 (Fwindow_vscroll): Doc fix.
6625 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6626 argument, since it makes no sense to pass a live window and for
6627 consistency with window-child.
6628
1f05cd82
CS
66292011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6630
6631 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6632 support MSVC.
6633
22610910
JR
66342011-11-05 Jason Rumney <jasonr@gnu.org>
6635
6636 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6637 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6638 fonts (Bug#6029).
6639 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6640 bitwise arithmetic preventing use of unicode-sip and non-truetype
6641 opentype fonts.
6642
a06776b2
EZ
66432011-11-05 Eli Zaretskii <eliz@gnu.org>
6644
3ad924ba
EZ
6645 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6646 "emacs"-only part.
6647
a06776b2
EZ
6648 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6649 initialization code to keep similarity to xfns.c after changes
6650 from 2011-11-05.
6651
c9e7db78
JD
66522011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6653
a97f8f3f
JD
6654 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6655 (unwind_create_frame): New function (Bug#9943).
6656 (Fx_create_frame): Restructure code to be more similar to the one in
6657 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6658 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6659 Move terminal->reference_count++ just before making the frame official
6660 (Bug#9943).
6661
6662 * nsterm.m (x_free_frame_resources): New function.
6663 (x_destroy_window): Move code to x_free_frame_resources.
6664
c9e7db78 6665 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6666 (Fx_create_frame, x_create_tip_frame):
6667 Move terminal->reference_count++ just before making the frame
75f1671a 6668 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6669 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6670
a6fc3b5c
EZ
66712011-11-05 Eli Zaretskii <eliz@gnu.org>
6672
6673 Support MSVC build with newer versions of Visual Studio.
6674 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6675 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6676 nt/gmake.defs.
6677
6678 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6679 which are not supported by MSVC.
6680 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6681 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6682 bitfields.
6683 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6684 types in bitfields.
6685 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6686
6687 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6688
58179cce 66892011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6690
6691 Support MSVC build with newer versions of Visual Studio.
6692 * w32.c: Don't include w32api.h for MSVC.
6693 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6694
6695 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6696 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6697 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6698 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6699 e_* cousins.
6700 (alloca) [_MSC_VER]: Define to _alloca.
6701
6702 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6703
6704 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6705
a58c13ed
EZ
67062011-11-04 Eli Zaretskii <eliz@gnu.org>
6707
6708 * xdisp.c (note_mouse_highlight): If either of
6709 previous/next-single-property-change returns nil, treat that as
6710 the beginning or the end of the buffer. (Bug#9955)
6711
fe0b6370
JD
67122011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6713
a58c13ed 6714 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6715 label is not null (Bug#9951).
6716 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6717 may be NULL.
6718
89bd5ee1
EZ
67192011-11-04 Eli Zaretskii <eliz@gnu.org>
6720
6721 * window.c (Fwindow_body_size): Mention in the doc string that the
6722 return value is in frame's canonical units. (Bug#9949)
6723
84c3edb9
EZ
67242011-11-03 Eli Zaretskii <eliz@gnu.org>
6725
4e2fb5c7
EZ
6726 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6727
84c3edb9 6728 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6729 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6730 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6731
bc17a887
EZ
67322011-11-01 Eli Zaretskii <eliz@gnu.org>
6733
6734 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6735 Don't stop backward scan on the continuation glyph, even though
6736 its CHARPOS is positive.
6d5eb5b0
SM
6737 (mouse_face_from_buffer_pos, note_mouse_highlight):
6738 Rename cover_string to disp_string.
bc17a887 6739
4ee88440
MR
67402011-11-01 Martin Rudalics <rudalics@gmx.at>
6741
6742 * window.c (temp_output_buffer_show): Don't use
6743 Vtemp_buffer_show_specifiers.
6744 (Vtemp_buffer_show_specifiers): Remove unused variable.
6745
c2ff3c02
EZ
67462011-10-30 Eli Zaretskii <eliz@gnu.org>
6747
6748 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6749 past the beginning of the current glyph matrix.
6750
58179cce 67512011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6752
6753 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6754 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6755 HAVE_GTK3 (Bug#9869).
b77a6a7f 6756
3b574623
JD
6757 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6758 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6759
b77a6a7f
JD
6760 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6761
6762 * xterm.c: Declare x_handle_net_wm_state to return int.
6763 (handle_one_xevent): Check if we are iconified but don't have
6764 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6765 (get_current_wm_state): Return non-zero if not hidden,
6766 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6767 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6768 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6769 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6770
196e41e4
PE
67712011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6772
6773 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6774 so that this new function doesn't get optimized away by a
6775 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6776
021f2e1a
AS
67772011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6778
6779 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6780
8b058d44
EZ
67812011-10-29 Eli Zaretskii <eliz@gnu.org>
6782
6783 Fix the `xbytecode' command.
6784 * .gdbinit (xprintbytestr): New command.
b50a28de 6785 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6786 (xbytecode): Print the byte-code string as well.
6787
4452fb80
EZ
67882011-10-29 Kim Storm <storm@cua.dk>
6789
8b058d44
EZ
6790 * alloc.c (which_symbols): New function.
6791
21b72067
AS
67922011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6793
6794 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6795 line. (Bug#9903)
6796
83ed7b5c
GM
67972011-10-29 Glenn Morris <rgm@gnu.org>
6798
6799 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6800 Not clear what it was for, and it causes various bugs. (Bug#9839)
6801
5a7a728b
EZ
68022011-10-28 Eli Zaretskii <eliz@gnu.org>
6803
6804 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6805 possible random value that matches one of those tested as
6806 condition to clear the mouse face.
6807
d3d0842f
CY
68082011-10-28 Chong Yidong <cyd@gnu.org>
6809
6810 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6811
31b39d13
DN
68122011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6813
6814 * window.c (make_window): Initialize phys_cursor_on_p.
6815
9aba6043
SM
68162011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6817
6818 * lisp.h (struct Lisp_Symbol): Update comments.
6819
c20992f4
JB
68202011-10-28 Juanma Barranquero <lekktu@gmail.com>
6821
6822 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6823
db4f02f2
EZ
68242011-10-28 Eli Zaretskii <eliz@gnu.org>
6825
6826 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6827 <oslsachem@gmail.com> for helping to debug this.
6828
6829 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6830 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6831 (g_b_init_get_glyph_outline_w): New static variables.
6832 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6833 (GetGlyphOutlineW_Proc): New typedefs.
6834 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6835 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6836 New functions.
6837 (w32font_open_internal, compute_metrics):
6838 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6839 instead of calling the "wide" APIs directly.
6840
6841 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6842
6843 * w32.h (syms_of_w32font): Add prototype.
6844
87e68db4
JB
68452011-10-27 Juanma Barranquero <lekktu@gmail.com>
6846
6847 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6848 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6849 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6850 (Fmove_to_window_line): Doc fix.
6851
435c1d67
CY
68522011-10-27 Chong Yidong <cyd@gnu.org>
6853
6854 * process.c (make_process): Set gnutls_state to NULL.
6855
6856 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6857 non-NULL, regardless of GNUTLS_INITSTAGE.
6858 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6859 an error. Set process slots as soon as we allocate them.
6860
6861 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6862
9c6c6f49
CY
68632011-10-27 Chong Yidong <cyd@gnu.org>
6864
9aba6043
SM
6865 * gnutls.c (emacs_gnutls_deinit): New function.
6866 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6867 (Fgnutls_deinit, Fgnutls_boot): Use it.
6868
6869 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6870 (deactivate_process): Call emacs_gnutls_deinit.
6871
657d08d3
JB
68722011-10-27 Juanma Barranquero <lekktu@gmail.com>
6873
6874 * image.c (x_create_x_image_and_pixmap):
6875 * w32.c (sys_rename, w32_delayed_load):
6876 * w32font.c (fill_in_logfont):
6877 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6878
5430d399
JB
68792011-10-26 Juanma Barranquero <lekktu@gmail.com>
6880
6881 * w32fns.c (w32_default_color_map): New function,
6882 extracted from Fw32_default_color_map.
a7ef684b 6883 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6884
fe0055fa
PE
68852011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6886
6887 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6888
e6346438
SM
68892011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6890
6891 * keyboard.c (test_undefined): New function (bug#9751).
6892 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6893
e112cc37
ET
68942011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6895
6896 * sysdep.c (init_sys_modes): Fix the check for the controlling
6897 terminal (Bug#6649).
6898
7b5d6677
EZ
68992011-10-20 Eli Zaretskii <eliz@gnu.org>
6900
6901 * dispextern.h (struct bidi_it): New member next_en_type.
6902
6903 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6904 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6905 current character, check also for next_en_type being WEAK_EN.
6906 (bidi_resolve_weak): Don't enter the expensive loop if the current
6907 position is before next_en_pos. Record the bidi type of the first
6908 non-ET, non-BN character we find, in addition to its position.
6909 (bidi_level_of_next_char): Invalidate next_en_type when
6910 next_en_pos is over-stepped.
6911
7da0b018
PE
69122011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6913
6914 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6915 * editfns.c: Rewrite current-time-zone so that it invokes
6916 the equivalent of (format-time-string "%Z") to get the time zone name.
6917 This fixes a bug when the time zone name contains characters that
6918 need converting from the system time locale to Emacs internal format.
6919 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6920 that patch fixed format-time-string to do the conversion, but
6921 I forgot to fix current-time-zone.
6922 (format_time_string): New function, containing most of
6923 what Fformat_time_string used to contain.
6924 (Fformat_time_string): Rewrite in terms of format_time_string.
6925 This doesn't change this function's behavior.
6926 (current-time-zone): Rewrite to use format_time_string.
6927 This fixes the bug reported by Michael Schierl in
6928 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6929 Jason Rumney's 2007-06-07 change worked around this bug, but
6930 didn't fix it.
6931 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6932
8547b010
EZ
69332011-10-19 Eli Zaretskii <eliz@gnu.org>
6934
6935 * xdisp.c (start_display): If the character at POS is displayed
6936 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6937 (try_window_reusing_current_matrix): If a line ends in a display
6938 vector or the next line starts in a display vector, continue
6939 redrawing the window even though the character position of
6940 start_row was reached.
8547b010
EZ
6941 (Bug#9771, part 2)
6942
4e948d15
CY
69432011-10-18 Chong Yidong <cyd@gnu.org>
6944
6945 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6946 with nobreak-char-display too.
6947
4787455f
EZ
69482011-10-18 Eli Zaretskii <eliz@gnu.org>
6949
6950 Fix part 3 of bug#9771.
6951 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6952 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6953 non-neutral characters if the current character is a paragraph
6954 separator (a.k.a. Newline). This avoids running the same
6955 expensive loop twice, once when we consume the preceding newline
6956 and the other time when the line actually needs to be displayed.
6957 Avoid the loop when we see neutrals on the base embedding level
6958 following a character whose directionality is the same as the
6959 paragraph's. This avoids running the expensive loop when a line
6960 ends in a long sequence of neutrals, like control characters.
6961 Add assertion against STRONG_AL type. Slightly rearrange code
6962 that determines the type of a neutral given the first non-neutral
6963 that follows it.
6964 (bidi_level_of_next_char): Set next_en_pos to zero when
6965 invalidating its info.
6966
2c91f553
EZ
69672011-10-17 Eli Zaretskii <eliz@gnu.org>
6968
6969 * xdisp.c (push_display_prop): Determine whether to record string
6970 or buffer position by IT->string, not by IT->method. Allow
6971 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6972 (move_it_vertically_backward): Don't look for character position
6973 immediately after the newline when in a continuation line.
6974 (Bug#9771, part 1)
2c91f553 6975
c7b08b0d
MR
69762011-10-15 Martin Rudalics <rudalics@gmx.at>
6977
6978 * window.c (coordinates_in_window): Rewrite and delabelize
6979 vertical border check. (Bug#5357) (Bug#9618)
6980
6b02f655
SM
69812011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6982
6983 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6984 errors in XSetWindowBorder (bug#9310).
6985
81d40c92
DA
69862011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6987
6988 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6989 avoid crash when xmalloc overrun checking is enabled.
6990
d4172c3b
EZ
69912011-10-13 Eli Zaretskii <eliz@gnu.org>
6992
6993 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6994 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6995 cursor motion with <left> and <right> arrow keys.
6996
6997 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6998 some callers set that themselves.
6999
b00eea75
EZ
70002011-10-12 Eli Zaretskii <eliz@gnu.org>
7001
7002 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7003 display string and the previous row comes from the same string and
7004 is empty. (Bug#9739) (Bug#9738)
7005
8fe012c4
SM
70062011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7007
7008 * doc.c (get_doc_string): Encode file name (bug#9735).
7009
0074aef2
EZ
70102011-10-12 Eli Zaretskii <eliz@gnu.org>
7011
79beb178
EZ
7012 * bidi.c (bidi_level_of_next_char):
7013 * xdisp.c (get_visually_first_element): Remove old incorrect
7014 comments regarding the Unicode Line Separator character.
7015
0074aef2
EZ
7016 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7017
6e4b3fbe
DA
70182011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7019
7020 * alloc.c (Fgc_status): Do not access beyond zombies array
7021 boundary if nzombies > MAX_ZOMBIES.
7022 * alloc.c (dump_zombies): Add missing format specifier.
7023
0324f3af
PE
70242011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7025
b5525cac
PE
7026 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7027 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7028
0324f3af
PE
7029 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7030 Some packages use them to denote characters with modifiers.
7031
e9b5f888
AS
70322011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7033
7034 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7035 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7036 matching a pp-number. Rename parameter var to var1.
7037
127827c0
SM
70382011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7039
7040 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7041
c8fd3bd0
GM
70422011-10-08 Glenn Morris <rgm@gnu.org>
7043
7044 * callint.c (Fcall_interactively): Give a more explicit error for the
7045 'c' case with a non-character input. (Bug#8479)
7046
352ec8ff
EZ
70472011-10-08 Eli Zaretskii <eliz@gnu.org>
7048
03669ccb
EZ
7049 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7050 lines.
7061c986
EZ
7051 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7052 lines that are hscrolled on the left.
03669ccb 7053
352ec8ff
EZ
7054 * dispnew.c (buffer_posn_from_coords): Account for a possible
7055 presence of header-line. (Bug#4426)
7056
a66cfb1c
SM
70572011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7058
6b02f655
SM
7059 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7060 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7061
7c5ee88e
PE
70622011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7063
7064 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7065 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7066 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7067 this makes Emacs dump core during garbage collection on rare
7068 occasions. sizeof is obviously inferior to offsetof here, so
7069 stick with offsetof.
7070 (GC_POINTER_ALIGNMENT): New macro.
7071 (mark_memory): Omit 3rd (offset) arg; caller changed.
7072 Don't assume EMACS_INT alignment is the same as pointer alignment.
7073
df1bbe5b
SM
70742011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7075
7076 * keyboard.c (read_key_sequence_remapped): New var.
7077 (read_key_sequence): Compute remapping in the right buffer.
7078 (command_loop_1): Use read_key_sequence's remapping directly.
7079
51553db6
SM
70802011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7081
32c1fffd
SM
7082 * dired.c (file_name_completion): Don't expand file name.
7083 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7084 before checking file name handler.
7085
51553db6
SM
7086 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7087 they've been requested explicitly (bug#9591).
7088
b6bd1599 70892011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7090
7091 * keymap.c (Fsingle_key_description): Use make_specified_string
7092 instead of build_string to build string from push_key_description.
7093 (Bug#5193)
7094
f701dc2a
PE
70952011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7096
4222c55d
PE
7097 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7098 This fixes a Y2038 bug on 64-bit hosts.
7099 * buffer.c (reset_buffer):
7100 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7101 (Fclear_buffer_auto_save_failure):
7102 Use 0, not -1, to represent an unset failure time, since time_t
7103 might not be signed.
7104
f701dc2a
PE
7105 Remove dependency on glibc malloc internals.
7106 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7107 Move back here from lisp.h, but with their new implementations.
7108 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7109 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7110 * charset.c (charset_table_init): New static var.
7111 (syms_of_charset): Use it instead of xmalloc. This removes a
7112 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7113 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7114 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7115 Move back to alloc.c.
7116 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7117 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7118
9ceebf39
JD
71192011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7120
7121 * nsterm.m (windowDidResize): Call x_set_window_size only when
7122 ns_in_resize is true. Otherwise set pixelwidth/height and
7123 call change_frame_size (Bug#9628).
7124
cb993c58
PE
71252011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7126
3930c88b
PE
7127 Port --enable-checking=all to Fedora 14 x86-64.
7128 * charset.c (syms_of_charset): Also account for glibc malloc's
7129 internal overhead when calculating the initial malloc maximum.
7130
cb993c58
PE
7131 Port --enable-checking=all to Fedora 14 x86.
7132 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7133 Move to lisp.h.
7134 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7135 (overrun_check_realloc, overrun_check_free):
7136 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7137 That way, xmalloc returns a properly-aligned pointer even if
7138 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7139 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7140 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7141 into account when calculating the initial malloc maximum.
7142 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7143 Move here from alloc.c, so that charset.c can use it too.
7144 Properly align; the old code wasn't right for common 32-bit hosts
7145 when configured with --enable-checking=all.
7146 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7147 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7148
31bed486
EZ
71492011-09-29 Eli Zaretskii <eliz@gnu.org>
7150
04c70788 7151 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7152 use EDOM.
7153
fbcaa2f3
EZ
71542011-09-28 Eli Zaretskii <eliz@gnu.org>
7155
7156 * xdisp.c (compute_display_string_end): If there's no display
7157 string at CHARPOS, return -1.
7158
7159 * bidi.c (bidi_fetch_char): When compute_display_string_end
7160 returns a negative value, treat the character as a normal
7161 character not covered by a display string. (Bug#9624)
7162
a239d4e9
JB
71632011-09-28 Juanma Barranquero <lekktu@gmail.com>
7164
7165 * lread.c (Fread_from_string): Fix typo in docstring.
7166
88652fd5
EZ
71672011-09-27 Eli Zaretskii <eliz@gnu.org>
7168
7169 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7170 newline, reseat the iterator instead of bidi-iterating there one
7171 character at a time. (Bug#9610)
32c1fffd
SM
7172 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7173 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7174
ed497dd4
AS
71752011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7176
7177 * lread.c (readevalloop): Use correct code for NBSP.
7178 (read1): Likewise. (Bug#9608)
7179
b2bf61aa
MA
71802011-09-25 Michael Albinus <michael.albinus@gmx.de>
7181
7182 * dbusbind.c (Fdbus_register_signal): When service is not
7183 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7184
32bbb17c
GM
71852011-09-25 Glenn Morris <rgm@gnu.org>
7186
7187 * buffer.c (truncate-lines): Doc fix.
7188
94e0933e
CY
71892011-09-24 Chong Yidong <cyd@stupidchicken.com>
7190
7191 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7192 (Fset_window_next_buffers): Doc fix.
7193
cddde921
GM
71942011-09-24 Glenn Morris <rgm@gnu.org>
7195
7196 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7197
1260aef1
PE
71982011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7199
25b4bfa0
PE
7200 Fix minor problems found by static checking.
7201 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7202 * indent.c (Fvertical_motion): Fix == vs = typo.
7203
e3cbd34b
EZ
72042011-09-24 Eli Zaretskii <eliz@gnu.org>
7205
a66cfb1c
SM
7206 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7207 Default value is now t. Doc fix.
6bf7006f 7208
e3cbd34b 7209 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7210 logic when moving up, not only when moving down. Fix the
e3cbd34b 7211 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7212 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7213
7214 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7215 CHARPOS is covered by a display string which includes newlines.
7216 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7217 is covered by a display string with embedded newlines.
7218
a3de0cbd
MA
72192011-09-24 Michael Albinus <michael.albinus@gmx.de>
7220
7221 * dbusbind.c (Fdbus_register_signal): Add match rule to
7222 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7223 (Fdbus_register_method, Vdbus_registered_objects_table):
7224 Fix docstring.
a3de0cbd 7225
b260039d
JM
72262011-09-24 Jim Meyering <meyering@redhat.com>
7227
32c1fffd 7228 do not ignore write error for any output size
b260039d
JM
7229 The previous change was incomplete.
7230 While it makes emacs --batch detect the vast majority of stdout
7231 write failures, errors were still ignored whenever the output size is
7232 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7233 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7234 && echo FAIL: ignored write error
7235 FAIL: ignored write error
7236 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7237 && echo FAIL: ignored write error
7238 FAIL: ignored write error
7239 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7240
8eca8a7c
AS
72412011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7242
7243 * emacs.c (Fkill_emacs): In noninteractive mode exit
7244 non-successfully if a write error occurred on stdout. (Bug#9574)
7245
3341db62
EZ
72462011-09-21 Eli Zaretskii <eliz@gnu.org>
7247
7248 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7249 the xassert test.
7250
7251 * dispextern.h (struct it): Update the comment documenting what
7252 can it->OBJECT be.
7253
8c203dbf
EZ
72542011-09-20 Eli Zaretskii <eliz@gnu.org>
7255
7256 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7257 a display string, extend search for cursor position to end of row.
7258 (find_row_edges): If the row ends in a newline from a display
7259 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7260 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7261 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7262 non-empty line. Fixes confusing cursor motion with arrow keys at
7263 the beginning of a line that starts with whitespace.
8c203dbf 7264
a4824228
LMI
72652011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7266
7267 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7268 (bug#9493).
7269
33ed493b
CY
72702011-09-18 Chong Yidong <cyd@stupidchicken.com>
7271
7272 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7273 boolean (Bug#9154).
7274
56cd55c8
EZ
72752011-09-18 Eli Zaretskii <eliz@gnu.org>
7276
7277 * xdisp.c (display_line): Record maximum and minimum buffer
7278 positions even if no glyphs were produced (e.g., by a zero-width
7279 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7280 buffer positions that will be removed from the glyph row because
7281 they don't fit.
c02dcedf
EZ
7282 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7283 column is beyond frame width: don't subtract 1 "pixel" when
7284 computing width of the stretch.
3e62b7e0
EZ
7285 (reseat_at_next_visible_line_start): Undo the change made on
7286 2011-09-17 that saved paragraph information and restored it after
7287 the call to `reseat'. (Bug#9545)
56cd55c8 7288
5ed99d36 72892011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7290
7291 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7292 and turn window cursor on if cleared (Bug#9415).
7293
5ed99d36 72942011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7295
7296 * search.c (boyer_moore): Take unibyte characters from pattern
7297 literally. (Bug#9458)
7298
9bade7b2
EZ
72992011-09-18 Eli Zaretskii <eliz@gnu.org>
7300
7301 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7302
e5e9d610
PE
73032011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7304
87e4427a
PE
7305 Fix minor problem found by static checking.
7306 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7307 initialized, to pacify gcc -Wuninitialized.
7308
e5e9d610
PE
7309 * fileio.c: Report proper errno when syscall falls.
7310 (Finsert_file_contents): Save and restore errno,
7311 so that report_file_error outputs the correct diagnostic.
7312 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7313
a1674f0b
EZ
73142011-09-18 Eli Zaretskii <eliz@gnu.org>
7315
7316 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7317
fbfb6dd4
EZ
73182011-09-17 Eli Zaretskii <eliz@gnu.org>
7319
7320 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7321 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7322
bb187662
EZ
73232011-09-17 Eli Zaretskii <eliz@gnu.org>
7324
1137e8b8 7325 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7326 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7327
7328 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7329 (bidi_find_paragraph_start): Search back for paragraph beginning
7330 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7331 (bidi_move_to_visually_next): Only trigger paragraph-related
7332 computations when the last character is a newline or at EOB, not
7333 just any NEUTRAL_B. (Bug#9470)
7334
bb187662
EZ
7335 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7336 truncated lines if point is covered by a display string. (Bug#9524)
7337
2e621251
PE
73382011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7339
7340 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7341 (cons_to_x_long): New function.
7342 (lisp_data_to_selection_data): Use it. Correct the test for
7343 short-versus-long data; it was negated. Break out of vector
7344 loop, for efficiency, when a long datum is discovered.
7345
91a15bc6
SM
73462011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7347
7348 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7349
b41c3a35
EZ
73502011-09-16 Eli Zaretskii <eliz@gnu.org>
7351
7352 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7353 GCC PR/17406) by declaring this function with external scope.
7354
7812ba2d
PE
73552011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7356
7357 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7358 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7359
cf7edc2a
AS
73602011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7361
7362 * editfns.c (Fformat): Correctly handle text properties on "%%".
7363
bd01620e
EZ
73642011-09-15 Eli Zaretskii <eliz@gnu.org>
7365
7366 * xterm.c (x_draw_composite_glyph_string_foreground):
7367 * w32term.c (x_draw_composite_glyph_string_foreground):
7368 * term.c (encode_terminal_code):
7369 * composite.c (composition_update_it, get_composition_id):
7370 * xdisp.c (get_next_display_element)
7371 (fill_composite_glyph_string): Add comments about special meaning
7372 of TAB characters in a composition.
7373
a02719a3
PE
73742011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7375
7376 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7377 This occurs when processing a multibyte format.
7378 Problem reported by Wolfgang Jenker.
a02719a3 7379
72589a3c
JB
73802011-09-15 Johan Bockgård <bojohan@gnu.org>
7381
7382 * xdisp.c (try_cursor_movement): Only check for exact match if
7383 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7384
1c14176c
PE
73852011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7386
7387 Remove unused external symbols.
7388 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7389 * xdisp.c (calc_pixel_width_or_height): Now static.
7390 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7391 * indent.c (check_display_width):
7392 * w32term.c: Fix comment to match code.
7393 * xterm.c, xterm.h (x_catching_errors): Remove.
7394
d2eea5b5
PE
73952011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7396
7397 * xselect.c: Use signed conversions more consistently (Bug#9498).
7398 (selection_data_to_lisp_data): Assume incoming selection data are
7399 signed integers, not unsigned. This is to be consistent with
7400 outgoing selection data, which was modified to use signed integers
7401 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7402 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7403 expects long, not unsigned long.
7404
46888499
EZ
74052011-09-14 Eli Zaretskii <eliz@gnu.org>
7406
7407 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7408 computation of loop end. Reported by Johan Bockgård
7409 <bojohan@gnu.org>.
7410
ef8ef9fb
CY
74112011-09-13 Chong Yidong <cyd@stupidchicken.com>
7412
7413 * frame.c (Fother_visible_frames_p): Function deleted.
7414
fa819fed
EZ
74152011-09-12 Eli Zaretskii <eliz@gnu.org>
7416
7417 * indent.c (compute_motion): Process display vector front to back
7418 rather than the other way around. (Bug#2496)
7419
2ba8e008
SM
74202011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7421
7422 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7423
20f53c69
CY
74242011-09-11 Chong Yidong <cyd@stupidchicken.com>
7425
7426 * minibuf.c (Fread_from_minibuffer): Doc fix.
7427
d562d7a4
EZ
74282011-09-11 Eli Zaretskii <eliz@gnu.org>
7429
7430 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7431 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7432
1c4d7f3d
LMI
74332011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7434
7435 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7436 value for non-existent files.
7437
b885bf36
EZ
74382011-09-11 Eli Zaretskii <eliz@gnu.org>
7439
7440 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7441 set its "size" to -1. This will set the modtime_size field of
7442 the corresponding buffer to -1, which is what
7443 verify-visited-file-modtime expects for files that do not exist.
7444 (Bug#9139)
7445
6612f0bf
PE
74462011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7447
7448 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7449 here ...
7450 * lisp.h: ... from here. push_key_description is no longer
7451 defined in keyboard.c, so its declaration should not be in
7452 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7453 logically belongs with push_key_description.
7454
dfb3f755
PE
74552011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7456
7457 * buffer.h: Include <sys/types.h> instead of <time.h>.
7458 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7459 Problem reported by Herbert J. Skuhra.
7460
3134906c
LMI
74612011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7462
7463 * xml.c (parse_region): Make the parsing work for
7464 non-comment-starting XML files again (bug#9144).
7465
8d903f4e
AS
74662011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7467
7468 * image.c (gif_load): Fix calculation of bottom and right corner.
7469 (Bug#9468)
7470
80ad64f4
EZ
74712011-09-10 Eli Zaretskii <eliz@gnu.org>
7472
7473 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7474 redisplay in small windows.
7475
208a048d
EZ
74762011-09-09 Eli Zaretskii <eliz@gnu.org>
7477
7478 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7479
9b1c252e
MR
74802011-09-08 Martin Rudalics <rudalics@gmx.at>
7481
7482 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7483 Operate on live windows only.
7484
2949f33b
JB
74852011-09-08 Juanma Barranquero <lekktu@gmail.com>
7486
7487 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7488
e08dcafd
EZ
74892011-09-07 Eli Zaretskii <eliz@gnu.org>
7490
7491 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7492 only under bidi iteration.
7493
115b96bd
JD
74942011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7495
7496 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7497
c8199d0f
PE
74982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7499
7500 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7501 Without this fix, the command to link temacs failed due to an
7502 undefined symbol __builtin_isnan. This is because
7503 /usr/include/iso/math_c99.h #defines isnan(x) to
7504 __builtin_isnan(x), but the bundled gcc, which identifies itself
7505 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7506 a __builtin_isnan.
7507 * floatfns.c (isnan): #undef, and then #define to a clone of
7508 what's in data.c.
7509 (Fisnan): Always define, since it's always available now.
7510 (syms_of_floatfns): Always define isnan at the Lisp level.
7511
e39b275c 75122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7513
7514 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7515
b2db44d9 75162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7517
f4af5137 7518 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7519 The previous code assumed that file offsets (off_t values) fit in
7520 EMACS_INT variables, which is not true on typical 32-bit hosts.
7521 The code messed up by falsely reporting buffer overflow in cases
7522 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7523 when "big" contains more than 2**29 bytes, even though this
7524 inserts just one byte and does not overflow the buffer.
7525 (Finsert_file_contents): Store file offsets as off_t
7526 values, not as EMACS_INT values. Check for overflow when
7527 converting between EMACS_INT and off_t. When checking for
7528 buffer overflow or for overlap, take the offsets into account.
7529 Don't use EMACS_INT for small values where int suffices.
7530 When checking for overlap, fix a typo: ZV was used where
7531 ZV_BYTE was intended.
7532 (Fwrite_region): Don't assume off_t fits into 'long'.
7533 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7534
ecfc0a49
MA
75352011-09-05 Michael Albinus <michael.albinus@gmx.de>
7536
7537 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7538
6511acf2 75392011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7540
0999621a 7541 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7542
7543 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7544 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7545 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7546 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7547 (modify_event_symbol): Do not assume that the length of
7548 name_alist_or_stem is safe to alloca and fits in int.
7549 (Fexecute_extended_command): Likewise for function name and binding.
7550 (Frecursion_depth): Wrap around reliably on integer overflow.
7551 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7552 since some callers pass EMACS_INT values.
7553 (Fsingle_key_description): Don't crash if symbol name contains more
7554 than MAX_ALLOCA bytes.
7555 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7556 (get_minibuffer): Arg is now EMACS_INT, not int.
7557 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7558 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7559 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7560
2be7d702
PE
7561 * dbusbind.c (signature_cat): New function.
7562 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7563 Do not overrun buffer; instead, report string overflow.
7564
9d1df220
PE
7565 * dispnew.c (add_window_display_history): Don't overrun buffer.
7566 Truncate instead; this is OK since it's just a log.
7567
33ef5c64
PE
7568 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7569 even if the time zone offset is outlandishly large.
7570 Don't mishandle offset == INT_MIN.
7571
66c6fdd5
PE
7572 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7573 when creating daemon; the previous buffer-overflow check was incorrect.
7574
d749b01b
PE
7575 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7576 which has the guts of the old verror function.
7577
b5cd1905
PE
7578 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7579 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7580
6e1a67fb
PE
7581 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7582 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7583 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7584 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7585 length of string rather than counting it via multiple sprintfs;
7586 that's simpler and more reliable.
c21721cc
PE
7587 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7588 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7589 sprintf, in case result does not fit in int.
7590
c57b67fc
PE
7591 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7592 (fontset_from_font): Print it.
7593
8a401434
PE
7594 * frame.c (tty_frame_count): Now printmax_t, not int.
7595 (make_terminal_frame, set_term_frame_name): Print it.
7596 (x_report_frame_params): In X, window IDs are unsigned long,
7597 not signed long, so print them as unsigned.
7598 (validate_x_resource_name): Check for implausibly long names,
7599 and don't assume name length fits in 'int'.
7600 (x_get_resource_string): Don't blindly alloca invocation name;
7601 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7602 not fit in int.
7603
6e1a67fb
PE
7604 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7605 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7606 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7607
0df02bf3
PE
7608 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7609 Use esprintf, not sprintf, in case result does not fit in int.
7610
48e30793
PE
7611 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7612 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7613 it as a large positive number.
7614 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7615 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7616
a66ff6d8
PE
7617 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7618 in case result does not fit in int.
7619
aca216ff
PE
7620 * print.c (float_to_string): Detect width overflow more reliably.
7621 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7622 buffer overrun. Don't assume list length fits in 'int'. Treat
7623 print length of 0 as 0, not as infinity; to be consistent with other
7624 uses of print length in this function. Don't overflow print length
7625 index. Don't assume hash table size fits in 'long', or that
7626 vectorlike size fits in 'unsigned long'.
7627
31c286f7
PE
7628 * process.c (make_process): Use printmax_t, not int, to format
7629 process-name gensyms.
7630
55e5faa1
PE
7631 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7632
80f2e268
PE
7633 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7634 to avoid potential buffer overrun.
7635
670741ab
PE
7636 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7637 if X resource line is longer than 512 bytes.
7638
b7163a50
PE
7639 * xfns.c (x_window): Make sprintf buffer a bit bigger
7640 to avoid potential buffer overrun.
7641
ae58ff1f
PE
7642 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7643
c43c8a6a
PE
7644 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7645
3f8236f4
PE
76462011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7647
53e9fe90 7648 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7649 Without these, Emacs silently mishandles large integers sometimes.
7650 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7651 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7652
6511acf2
PE
7653 * xdisp.c (try_window_id): Check Emacs fixnum range before
7654 converting to 'int'.
806add1d 7655
6511acf2 7656 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7657 Check that an Emacs fixnum is in range before assigning it to 'int'.
7658 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7659 values converted from Emacs fixnums.
7660 (Frecenter): Don't wrap around a line count if it is out of 'int'
7661 range; instead, treat it as an extreme value.
7662 (Fset_window_configuration, compare_window_configurations):
7663 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7664
6511acf2
PE
7665 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7666 that can exceed INT_MAX. Check that EMACS_INT value is in range
7667 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7668 (match_limit): Don't assume that a fixnum can fit in 'int'.
7669
6511acf2 7670 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7671 exceed INT_MAX.
7672
6511acf2 7673 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7674 (Fvertical_motion): Don't wrap around LINES values that don't fit
7675 in 'int'. Instead, treat them as extreme values. This is good
7676 enough for windows, which can't have more than INT_MAX lines anyway.
7677
fcb901a7
LMI
76782011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7679
0f2f6b6d
LMI
7680 * Require libxml/parser.h to avoid compilation warning.
7681
fcb901a7
LMI
7682 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7683
7684 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7685 since this reportedly can destroy thread storage.
7686
6e20a0d4
CY
76872011-08-30 Chong Yidong <cyd@stupidchicken.com>
7688
7689 * syntax.c (find_defun_start): Update all cache variables if
7690 exiting early (Bug#9401).
7691
148ae00e
EZ
76922011-08-30 Eli Zaretskii <eliz@gnu.org>
7693
f6cfbd8f
EZ
7694 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7695
148ae00e
EZ
7696 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7697 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7698 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7699
7700 * term.c (tty_append_glyph): New function.
7701 (produce_stretch_glyph): Static function and its prototype deleted.
7702
a66cfb1c
SM
7703 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7704 Add prototypes.
148ae00e 7705
c4a07a4c
PE
77062011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7707
7708 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7709 when checking :margin (Bug#9390).
7710 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7711 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7712 so that the name doesn't mislead. All uses changed.
7713
6bc8cd65
JB
77142011-08-28 Johan Bockgård <bojohan@gnu.org>
7715
7716 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7717 set_tty_hooks.
7718
dca4927e
EZ
77192011-08-27 Eli Zaretskii <eliz@gnu.org>
7720
7721 * xdisp.c (move_it_to): Don't bail out early when reaching
7722 position beyond to_charpos, if we are scanning backwards.
7723 (move_it_vertically_backward): When DY == 0, make sure we get to
7724 the first character in the line after the newline.
7725
f2cad773
PE
77262011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7727
7728 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7729 (ccl_driver): Do not generate an out-of-range pointer.
7730 (Fccl_execute_on_string): Remove unnecessary check for
7731 integer overflow, noted by Stefan Monnier in
7732 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7733 Remove a FIXME that didn't need fixing.
7734 Simplify the newly-introduced buffer reallocation code.
7735
0cae2cdb
JB
77362011-08-27 Juanma Barranquero <lekktu@gmail.com>
7737
7738 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7739
5fc295a4 77402011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7741
70c60eb2 7742 Integer and memory overflow issues (Bug#9196).
726e0ab1 7743
d31850da
PE
7744 * doc.c (get_doc_string): Rework so that
7745 get_doc_string_buffer_size is the actual buffer size, rather than
7746 being 1 less than the actual buffer size; this makes xpalloc more
7747 convenient.
7748
a69fbedb
PE
7749 * image.c (x_allocate_bitmap_record, cache_image):
7750 * xselect.c (Fx_register_dnd_atom):
7751 Simplify previous changes by using xpalloc.
7752
fe5c5d37
PE
7753 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7754 since either will do and ptrdiff_t is convenient with xpalloc.
7755
0065d054
PE
7756 * charset.c (charset_table_size)
7757 (struct charset_sort_data.priority): Now ptrdiff_t.
7758 (charset_compare): Don't overflow if priorities differ greatly.
7759 (Fsort_charsets): Don't assume list length fits in int.
7760 Check for size-calculation overflow when allocating sort data.
7761 (syms_of_charset): Allocate an initial charset table that is
7762 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7763
7764 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7765
7766 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7767 The actual value is always <= INT_MAX, and leaving it unsigned made
7768 overflow checking harder.
7769
7770 * dispextern.h (struct glyph_matrix.rows_allocated)
7771 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7772 with xpalloc. The values are still always <= INT_MAX.
7773
7774 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7775
7776 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7777 (SAFE_NALLOCA): New macro.
7778
7779 * region-cache.c (struct boundary.pos, find_cache_boundary)
7780 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7781 (set_cache_region, invalidate_region_cache)
7782 (revalidate_region_cache, know_region_cache, region_cache_forward)
7783 (region_cache_backward, pp_cache):
7784 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7785 so that ptrdiff_t * can be passed to xpalloc.
7786 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7787 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7788 (pp_cache): Don't assume cache_len fits in int.
7789 * region-cache.h: Adjust extern decls to match.
7790
7791 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7792 EMACS_INT, since either will do, for xpalloc.
7793
7794 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7795 (xnmalloc, xnrealloc, xpalloc): New functions.
7796
726e0ab1
PE
7797 * bidi.c (bidi_shelve_header_size): New constant.
7798 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7799 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7800
51f30bc5 7801 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7802 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7803 (overlay_strings):
7804 Don't update size of array until after memory allocation succeeds,
7805 because xmalloc/xrealloc may not return.
0065d054
PE
7806 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7807 now that we have proper integer overflow checking.
7808 (record_overlay_string, overlay_strings): Catch overflows when
7809 calculating size of overlay_str_buf.
726e0ab1 7810
0065d054
PE
7811 * callproc.c (Fcall_process): Check for size overflow when
7812 calculating size of args2.
7813 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7814 Normally we prefer signed values, but sticking with ptrdiff_t would
7815 require adding more-complicated checks.
726e0ab1
PE
7816
7817 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7818 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7819 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7820 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7821
7822 * character.c (Fstring): Check for size-calculation overflow.
7823
7824 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7825 unnecessary integer overflow. Check for size overflow.
7826 (encode_coding_object): Don't update size until xmalloc succeeds.
7827
7828 * composite.c (get_composition_id): Check for overflow in glyph
7829 length calculations.
7830
7831 Integer and memory overflow fixes for display code.
7832 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7833 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7834 (scrolling_window): Check for overflow in size calculations.
7835 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7836 Don't assume glyph table len fits in int.
7837 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7838 (row_table_size): Now ptrdiff_t, not int.
7839 (scrolling_window): Avoid overflow in size calculations.
7840 Don't update size until allocation succeeds.
7841 * fns.c (concat): Check for overflow in size calculations.
7842 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7843 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7844 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7845
7846 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7847 (get_doc_string): Check for size calculation overflow.
7848 Don't update size until allocation succeeds.
7849 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7850 EMACS_INT, where ptrdiff_t will do.
7851 (Fsubstitute_command_keys): Check for string overflow.
7852
7853 * editfns.c (set_time_zone_rule): Don't assume environment length
7854 fits in int.
7855 (message_length): Now ptrdiff_t, not int.
7856 (Fmessage_box): Don't update size until allocation succeeds.
7857 Don't assume message length fits in int.
7858 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7859
0065d054
PE
7860 * emacs.c (main): Do not reallocate argv, since there is a null at
7861 the end that can be overwritten, and this way there's no need to
7862 worry about size-calculation overflow.
7863 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7864
7865 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7866 alloc succeeds.
7867 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7868
7869 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7870 (x_set_scroll_bar_width, x_figure_window_size):
7871 Check for integer overflow.
7872 (x_set_alpha): Do not assume XINT fits in int.
7873
7874 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7875 This is for the members text_lines, text_cols, total_lines, total_cols,
7876 where the system imposes an 'int' limit.
7877
7878 * fringe.c (Fdefine_fringe_bitmap):
7879 Don't update size until alloc works.
7880
7881 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7882 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7883
7884 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7885 Check for size-calculation overflow.
7886 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7887 do, as we prefer signed integers.
7888 (id_to_widget.max_size, id_to_widget.used)
7889 (xg_store_widget_in_map, xg_remove_widget_from_map)
7890 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7891 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7892 Use and return ptrdiff_t, not int.
7893 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7894 * gtkutil.h: Change prototypes to match the above.
7895
7896 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7897 are duplicate now that they've been promoted to lisp.h.
7898 (x_allocate_bitmap_record, x_alloc_image_color)
7899 (make_image_cache, cache_image, xpm_load):
7900 Don't update size until alloc is done.
7901 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7902 (x_detect_edges):
3256efce 7903 Check for size calculation overflow.
726e0ab1
PE
7904 (ct_colors_allocated_max): New constant.
7905 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7906 overflow.
3256efce 7907
726e0ab1
PE
7908 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7909 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7910 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7911 Use ptrdiff_t, not int, to count maps.
7912 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7913 calculations. Don't update size until allocation succeeds.
7914 Redo calculations to avoid overflow.
726e0ab1
PE
7915 * keyboard.h: Change prototypes to match the above.
7916
7917 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7918 to count maps.
7919 (current_minor_maps): Check for size calculation overflow.
7920 * keymap.h: Change prototypes to match the above.
7921
7922 * lread.c (read1, init_obarray): Don't update size until alloc done.
7923
7924 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7925 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7926
726e0ab1
PE
7927 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7928 Now ptrdiff_t, not int.
7929 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7930 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7931
7932 * process.c (Fnetwork_interface_list): Check for overflow
7933 in size calculation.
7934
7935 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7936
7937 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7938 overflow. Don't bother calling xmalloc when xrealloc will do.
7939
7940 * search.c (Freplace_match): Check for size calculation overflow.
7941 (Fset_match_data): Don't assume list lengths fit in 'int'.
7942
7943 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7944 for command line length. Do not attempt to address one before the
7945 beginning of an array, as that's not portable.
7946
7947 * term.c (max_frame_lines): Remove; unused.
7948 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7949 not int.
7950 (encode_terminal_code, calculate_costs): Check for size
7951 calculation overflow.
7952 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7953 table lengths and related sizes. Don't update size until alloc
7954 done. Redo calculations to avoid overflow.
7955 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7956
7957 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7958 subtracting pointers.
7959 (gobble_line): Check for overflow more carefully. Don't update size
7960 until alloc done.
7961
7962 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7963 Don't update size until alloc done.
7964 Redo size calculations to avoid overflow.
7965 Check for size calculation overflow.
0065d054 7966 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7967
7968 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7969 Use ptrdiff_t, not int, for sizes.
7970 (store_mode_line_noprop_char): Don't update size until alloc done.
7971
0065d054
PE
7972 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7973 Use ptrdiff_t, not int, for sizes.
7974 (Finternal_make_lisp_face, cache_face):
7975 Check for size calculation overflow.
7976 (cache_face): Treat size calculation overflows as if they were
7977 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7978
7979 * xfns.c (x_encode_text, x_set_name_internal)
7980 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7981 sizes, since they can exceed INT_MAX in size. Check for size
7982 calculation overflow.
7983
0065d054
PE
7984 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7985 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7986 Don't update size until alloc done.
7987
0065d054 7988 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7989 as sprintf is limited to int lengths.
1d526e2f 7990
252c5ee1
PE
7991 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7992 (X_LONG_MIN): New macros.
864d7ce7
PE
7993 Use them to make the following changes clearer.
7994 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7995 This change doesn't affect the value now, but it may help remind
7996 future maintainers not to raise the value too much later.
7997 (SELECTION_QUANTUM): Remove, replacing with ...
7998 (selection_quantum): ... new function, which avoids overflow.
7999 All uses changed.
8000 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8001 assumption that selection length fits in 'int'.
8002 (x_reply_selection_request, x_handle_selection_request)
8003 (x_get_window_property, receive_incremental_selection)
8004 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8005 (lisp_data_to_selection_data, clean_local_selection_data):
8006 Use ptrdiff_t, not int, to record length of selection.
8007 (x_reply_selection_request, x_get_window_property)
8008 (receive_incremental_selection, x_property_data_to_lisp):
8009 Redo calculations to avoid overflow.
8010 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8011 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8012 something.
8013 (x_get_window_property, receive_incremental_selection)
8014 (lisp_data_to_selection_data, x_property_data_to_lisp):
8015 Check for size-calculation overflow.
8016 (x_get_window_property, receive_incremental_selection)
8017 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8018 Don't store size until memory allocation succeeds.
8019 (x_get_window_property): Plug memory leak on memory exhaustion.
8020 Don't double-block input; malloc is safe here. Don't assume 2**34
8021 - 4 fits in unsigned long. Add an xassert to check
8022 XGetWindowProperty overflow. Be more careful about overflow
8023 calculations, and distinguish size from memory overflow better.
8024 (receive_incremental_selection): When tracing, don't assume
8025 unsigned int is less than INT_MAX.
8026 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8027 harmful) conversions of unsigned short to int.
8028 (lisp_data_to_selection_data): Don't assume that integers
8029 in the range -65535 through -1 fit in an X unsigned short.
8030 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8031 result parameters unless successful. Rely on cons_to_unsigned
8032 to report problems with elements; the old code wasn't right anyway.
8033 (x_check_property_data): Check for int overflow; we cannot use
8034 a wider type due to X limits.
8035 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8036
726e0ab1 8037 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8038
0065d054
PE
8039 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8040 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8041 (x_color_cells): Don't store size until memory allocation succeeds.
8042 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8043 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8044 (x_term_init): Don't assume length fits in int (sprintf is limited
8045 to int size).
bc18e09d 8046
ebfa62c0
PE
8047 Use ptrdiff_t for composition IDs.
8048 * character.c (lisp_string_width):
8049 * composite.c (composition_table_size, n_compositions)
8050 (get_composition_id, composition_gstring_from_id):
8051 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8052 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8053 * window.c (Frecenter):
8054 Use ptrdiff_t, not int, for composition IDs.
8055 * composite.c (get_composition_id): Check for integer overflow.
8056 * composite.h: Adjust prototypes to match the above changes.
8057
d3411f89
PE
8058 Use ptrdiff_t for hash table indexes.
8059 * category.c (hash_get_category_set):
8060 * ccl.c (ccl_driver):
8061 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8062 * coding.c (coding_system_charset_list, detect_coding_system):
8063 * coding.h (struct coding_system.id):
8064 * composite.c (get_composition_id, gstring_lookup_cache):
8065 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8066 * image.c (xpm_get_color_table_h):
8067 * lisp.h (hash_lookup, hash_put):
8068 * minibuf.c (Ftest_completion):
8069 Use ptrdiff_t for hash table indexes, not int (which is too
8070 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8071 32-bit --with-wide-int hosts).
8072
e097a6fa
PE
8073 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8074 Add a FIXME comment about memory leaks.
8075 (syms_of_charset): Don't assume xmalloc returns.
8076
5637687f
PE
8077 Don't assume that stated character widths fit in int.
8078 * character.c (Fchar_width, c_string_width, lisp_string_width):
8079 * character.h (CHAR_WIDTH):
8080 * indent.c (MULTIBYTE_BYTES_WIDTH):
8081 Use sanitize_char_width to avoid undefined and/or bad behavior
8082 with outlandish widths.
a66cfb1c 8083 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8084 now that we have two such functions. All uses changed.
8085 (sanitize_char_width): New inline function.
8086
a2271ba2
PE
8087 Don't assume that tab-width fits in int.
8088 * character.h (sanitize_width): New inline function.
8089 (SANE_TAB_WIDTH): New macro.
8090 (ASCII_CHAR_WIDTH): Use it.
8091 * indent.c (sane_tab_width): Remove. All uses replaced by
8092 SANE_TAB_WIDTH (current_buffer).
8093 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8094
18c52557
PE
8095 * fileio.c: Integer overflow issues with file modes.
8096 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8097
caeeedc1
PE
8098 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8099 Remove unreachable code.
8100 (read_hex, load_charset_map_from_file): Check for integer overflow.
8101
6df6ae42 8102 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8103 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8104 (x_send_scroll_bar_event): Likewise. Check that the size does not
8105 exceed limits imposed by XClientMessageEvent, as well as the usual
8106 ptrdiff_t and size_t limits.
8107
b13995db
PE
8108 * keyboard.c: Overflow, signedness and related fixes.
8109 (make_lispy_movement): Use same integer type in forward decl
8110 that is used in the definition.
8111 (read_key_sequence, keyremap_step):
8112 Change bufsize argument back to int, undoing my 2011-03-30 change.
8113 We prefer signed types, and int is wide enough here.
8114 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8115 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8116 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8117 length, not size_t. Use ptrdiff_t for index, not int.
8118 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8119 possibility of integer overflow.
8120
13464394
PE
8121 Overflow, signedness and related fixes for images.
8122
8123 * dispextern.h (struct it.stack[0].u.image.image_id)
8124 (struct_it.image_id, struct image.id, struct image_cache.size)
8125 (struct image_cache.used, struct image_cache.ref_count):
8126 * gtkutil.c (update_frame_tool_bar):
8127 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8128 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8129 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8130 * nsmenu.m (update_frame_tool_bar):
8131 * xdisp.c (calc_pixel_width_or_height):
8132 * xfns.c (image_cache_refcount):
8133 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8134 on typical 64-bit hosts.
8135
8136 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8137 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8138 Omit unnecessary casts to int.
8139 (parse_image_spec): Check that integers fall into 'int' range
8140 when the callers expect that.
8141 (image_ascent): Redo ascent calculation to avoid int overflow.
8142 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8143 (lookup_image): Remove unnecessary tests.
8144 (xbm_image_p): Locals are now of int, not EMACS_INT,
8145 since parse_image_check makes sure they fit into int.
8146 (png_load, gif_load, svg_load_image):
8147 Prefer int to unsigned where either will do.
8148 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8149 old tiff_error_handler and tiff_warning_handler.
8150 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8151 stack buffer overflows. It uses only the features of vsnprintf
8152 that are common to both POSIX and native Microsoft.
8153 (tiff_error_handler, tiff_warning_handler): Use it.
8154 (tiff_load, gif_load, imagemagick_load_image):
8155 Don't assume :index value fits in 'int'.
8156 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8157 (imagemagick_load_image): Check that crop parameters fit into
8158 the integer types that MagickCropImage accepts. Don't assume
8159 Vimagemagick_render_type has a nonnegative value. Don't assume
8160 size_t fits in 'long'.
8161 (gs_load): Use printmax_t to print the widest integers possible.
8162 Check for integer overflow when computing image height and width.
8163
c11821d4
EZ
81642011-08-26 Eli Zaretskii <eliz@gnu.org>
8165
8166 * xdisp.c (redisplay_window): Don't force window start if point
8167 will be invisible in the resulting window. (Bug#9324)
8168
0c95fcf7
EZ
81692011-08-25 Eli Zaretskii <eliz@gnu.org>
8170
8171 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8172 the display spec is of the form `(space ...)'.
8173 (handle_display_spec): Return the value returned by
8174 handle_single_display_spec, not just 1 or zero.
8175 (handle_single_display_spec): If the display spec is of the form
8176 `(space ...)', and specifies display in the text area, return 2
8177 rather than 1.
fee65a97 8178 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8179 accurately, and prefer exact match for point under bidi.
8180 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8181
8182 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8183 into disp_prop; all users changed.
8184
8185 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8186 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8187 for the text covered by the display property.
8188
e4ed06f1
CY
81892011-08-25 Chong Yidong <cyd@stupidchicken.com>
8190
8191 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8192 Change return value to nil.
8193 (Frecord_buffer): Delete unused function.
8194
f67cdd7f
EZ
81952011-08-24 Eli Zaretskii <eliz@gnu.org>
8196
5980d4c6
EZ
8197 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8198 buffers, return left-to-right.
8610fe8b
EZ
8199 (set_cursor_from_row): Consider candidate row a win if its glyph
8200 represents a newline and point is on that newline. Fixes cursor
8201 positioning on the newline at EOL of R2L text within L2R
8202 paragraph, and vice versa.
8203 (try_cursor_movement): Check continued rows, in addition to
8204 continuation rows. Fixes unwarranted scroll when point enters a
8205 continued line of R2L text within an L2R paragraph, or vice versa.
8206 (cursor_row_p): Consider the case of point being equal to
8207 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8208 from the end of a short line to the beginning of a continued line
8209 of R2L text within L2R paragraph.
8210 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8211 composed characters.
5980d4c6 8212
f67cdd7f
EZ
8213 * bidi.c (bidi_check_type): Use xassert.
8214 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8215 members.
8216
bca633fb
EZ
82172011-08-23 Eli Zaretskii <eliz@gnu.org>
8218
8219 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8220 a character.
8221
4a5885a7
CY
82222011-08-23 Chong Yidong <cyd@stupidchicken.com>
8223
8224 * nsfont.m (ns_otf_to_script): Fix typo.
8225
0902a04e
KH
82262011-08-22 Kenichi Handa <handa@m17n.org>
8227
8228 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8229 extra slot even if the purpose is char-code-property-table.
8230
1a2e6670
EZ
82312011-08-23 Eli Zaretskii <eliz@gnu.org>
8232
8ddde651
EZ
8233 * xdisp.c (redisplay_window): When computing centering_position,
8234 account for the height of the header line. (Bug#8874)
8235
425cc014
EZ
8236 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8237 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8238 candidate is selected by the mouse, and that candidate has a
8239 composed character under the mouse.
8240
1a2e6670
EZ
8241 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8242 coordinates reported by pos-visible-in-window-p for a composed
8243 character in column zero.
8244
8b76d6f8
SM
82452011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8246
8247 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8248
dac347dd
EZ
82492011-08-22 Eli Zaretskii <eliz@gnu.org>
8250
8251 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8252 consider it a hit if to_charpos is anywhere in the range of the
8253 composed buffer positions.
8254
e013fb34
CY
82552011-08-22 Chong Yidong <cyd@stupidchicken.com>
8256
8257 * image.c (gif_load): Don't assume that each subimage has the same
8258 dimensions as the base image. Handle disposal method that is
8259 "undefined" by the gif spec (Bug#9335).
8260
bd1ba3e8
CY
82612011-08-20 Chong Yidong <cyd@stupidchicken.com>
8262
8263 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8264 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8265
54a1215b
EZ
82662011-08-19 Eli Zaretskii <eliz@gnu.org>
8267
823564e5
EZ
8268 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8269 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8270 from an Org mode buffer to a Speedbar frame.
8271
54a1215b
EZ
8272 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8273 a composition, take its buffer position from IT->cmp_it.charpos.
8274 Fixes cursor positioning at the beginning of a line that begins
8275 with a composed character.
8276
9778ebcc
EZ
82772011-08-18 Eli Zaretskii <eliz@gnu.org>
8278
0be6ee06
EZ
8279 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8280 character bidirectional type, use STRONG_L instead. Fixes crashes
8281 in a buffer produced by `describe-categories'.
8282
9778ebcc
EZ
8283 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8284 members before the level stack, so they would be saved and
8285 restored when copying iterator state. Fixes incorrect reordering
8286 around TABs covered by display properties.
8287
156bffbe
AS
82882011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8289
6b02f655 8290 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8291
72ad093b
CY
82922011-08-17 Chong Yidong <cyd@stupidchicken.com>
8293
8294 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8295 (internal_condition_case_2, internal_condition_case_n):
8296 Remove unnecessary aborts (Bug#9081).
72ad093b 8297
35774242
EZ
82982011-08-17 Eli Zaretskii <eliz@gnu.org>
8299
8300 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8301 has no `load' handler, try opening the file locally. (Bug#9311)
8302
db76dd85
KB
83032011-08-16 Ken Brown <kbrown@cornell.edu>
8304
8305 * gmalloc.c: Expand comment.
8306
b215eee5
EZ
83072011-08-16 Eli Zaretskii <eliz@gnu.org>
8308
8309 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8310 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8311
a4579d33
KB
83122011-08-16 Ken Brown <kbrown@cornell.edu>
8313
8314 Fix memory allocation problems in Cygwin build (Bug#9273).
8315
8316 * unexcw.c ( __malloc_initialized): Declare external variable.
8317 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8318
8b76d6f8
SM
8319 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8320 New variables.
a4579d33
KB
8321 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8322 dumped emacs.
8323 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8324 in the static heap.
8325 [CYGWIN] (special_realloc): New function.
8326 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8327 requests to realloc storage in the static heap.
8328
3ebec551
PE
83292011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8330
8331 * bidi.c (bidi_initialize): Remove unused local.
8332
9fd8be00
EZ
83332011-08-15 Eli Zaretskii <eliz@gnu.org>
8334
6b02f655
SM
8335 * bidimirror.h:
8336 * biditype.h: Remove file.
8337 * makefile.w32-in ($(BLD)/bidi.$(O)):
8338 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8339
8340 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8341
8342 * chartab.c: Improve commentary for the uniprop_table API.
8343
32413314
EZ
8344 * bidi.c (bidi_paragraph_init): Support zero value of
8345 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8346 (bidi_initialize): Use uniprop_table instead of including
8347 biditype.h and bidimirror.h.
32413314 8348
9fd8be00
EZ
8349 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8350 coordinates of the iterator when restoring from ppos_it.
8351 (Bug#9296)
8352
5cf2b69b
KH
83532011-08-14 Kenichi Handa <handa@m17n.org>
8354
8355 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8356 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8357
daf17d00
EZ
83582011-08-14 Eli Zaretskii <eliz@gnu.org>
8359
8360 * xdisp.c (move_it_in_display_line_to): Don't invoke
8361 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8362 ppos_it. Fixes vertical cursor motion when line beginning is
8363 covered by an image. (Bug#9296)
8364
08e3161a
JD
83652011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8366
8367 * nsterm.h (ns_run_ascript): Declare.
8368 (NSAPP_DATA2_RUNASSCRIPT): Define.
8369
8370 * nsfns.m (as_script, as_result, as_status): New static variables.
8371 (ns_run_ascript): New function.
5e617bc2 8372 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8373 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8374 the event loop. Get status from as_status (Bug#7276).
8375
8376 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8377 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8378 the event loop (Bug#7276).
8379
a3720aa2
AS
83802011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8381
8382 * gnutls.c (QCgnutls_bootprop_priority)
8383 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8384 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8385 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8386 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8387 (QCgnutls_bootprop_verify_hostname_error)
8388 (QCgnutls_bootprop_callbacks_verify): Rename from
8389 Qgnutls_bootprop_..., all uses changed.
8390
8391 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8392 uses changed.
8393
0a0d27fb
PE
83942011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8395
19d5c50c
PE
8396 * xfaces.c (Qframe_set_background_mode): Now static.
8397 * dispextern.h (Qframe_set_background_mode): Remove decl.
8398
0a0d27fb
PE
8399 * process.c (Fnetwork_interface_info): Declare local only if needed.
8400
377538cb
JD
84012011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8402
8403 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8404 (Fnetwork_interface_list): Allocate in increments of bytes instead
8405 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8406 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8407 sockaddr.
8408 (struct ifflag_def): notrailers is smart on OSX.
8409 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8410 Get hardware address with getifaddrs if available.
8411
08fff70c
EZ
84122011-08-12 Eli Zaretskii <eliz@gnu.org>
8413
8414 * xdisp.c (iterate_out_of_display_property): xassert that
8415 IT->position is set to within IT->object's boundaries. Break from
8416 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8417 when IT->position is set up wrongly due to some bug.
8418 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8419 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8420 entry. Force push_it to save on the stack the current
8421 buffer/string position, to be restored by pop_it. Fix flags in
8422 the iterator structure wrt the object coming from a display
8423 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8424 properties. (Bug#9284)
8425
7be1c708 84262011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8427
7be1c708
CY
8428 * fontset.c (fontset_get_font_group): Add proper type checks.
8429 (Bug#9172)
aac0c6e3 8430
7be1c708 84312011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8432
7be1c708
CY
8433 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8434 and LC_VERSION_MIN_MACOSX.
8435 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8436 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8437
97bb72a6
EZ
84382011-08-08 Eli Zaretskii <eliz@gnu.org>
8439
8440 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8441 no-display-properties-and-no-overlays under bidi display.
8442 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8443 properties and overlays.
97bb72a6 8444
d5617611
CY
84452011-08-08 Chong Yidong <cyd@stupidchicken.com>
8446
37e11a63
CY
8447 * editfns.c (Fset_time_zone_rule): Document relationship with the
8448 setenv function.
8449
d5617611
CY
8450 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8451 the font entity extracted from the cache (Bug#8109).
8452
58872834
CY
84532011-08-07 Chong Yidong <cyd@stupidchicken.com>
8454
8455 * composite.c (autocmp_chars): Don't reset point. That is done by
8456 restore_point_unwind (Bug#5984).
8457
75bfc667
JL
84582011-08-07 Juri Linkov <juri@jurta.org>
8459
8460 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8461 to show the arg `TIME' instead of `TIMEVAL'.
8462
d1410150
EZ
84632011-08-06 Eli Zaretskii <eliz@gnu.org>
8464
8465 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8466 display property strides EOL and includes a newline, as in
8467 longlines-mode. (Bug#9254)
75b771e4
EZ
8468 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8469 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8470
8471 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8472 is non-zero, even if the data buffer is NULL. Fixes a crash in
8473 vertical-motion with longlines-mode. (Bug#9254)
8474
35928349
EZ
84752011-08-05 Eli Zaretskii <eliz@gnu.org>
8476
ec7cc85b
EZ
8477 * bidi.c <bidi_cache_total_alloc>: Now static.
8478 (bidi_initialize): Initialize bidi_cache_total_alloc.
8479
8b76d6f8 8480 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8481 cache. (Bug#9221)
8482
8483 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8484 amount allocated this far in `bidi_cache_total_alloc'.
8485 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8486 non-zero, only free the data buffer without restoring the cache
8487 contents. All callers changed.
8488
8489 * dispextern.h (bidi_unshelve_cache): Update prototype.
8490
8491 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8492 (move_it_in_display_line, move_it_to)
8493 (move_it_vertically_backward, move_it_by_lines): Replace the call
8494 to xfree to an equivalent call to bidi_unshelve_cache.
8495 (move_it_in_display_line_to): Fix logic of returning
412b6358 8496 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8497
e2e2423b
EZ
84982011-08-05 Eli Zaretskii <eliz@gnu.org>
8499
8500 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8501 came from a string character with a `cursor' property. (Bug#9229)
8502
ae9e757a
JD
85032011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8504
8505 * Makefile.in (LIB_PTHREAD): New variable.
8506 (LIBES): Add LIB_PTHREAD (Bug#9216).
8507
8508 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8509 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8510
213bd7f2
AS
85112011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8512
6b02f655 8513 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8514
99aaf75f
JD
85152011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8516
8517 * xterm.c (x_find_topmost_parent): New function.
8518 (x_set_frame_alpha): Find topmost parent window with
8519 x_find_topmost_parent and set the property there also (bug#9181).
8520 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8521
c74e9d86
PE
85222011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8523
8524 * callproc.c (Fcall_process): Avoid vfork clobbering
8525 the local vars buffer, coding_systems, current_dir.
8526
640c8776
SM
85272011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8528
8529 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8530
f26d0e4c
PE
85312011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8532
8a10d76c
PE
8533 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8534 so that it is not optimized away.
8535
f26d0e4c
PE
8536 * xdisp.c (compute_display_string_pos): Remove unused local.
8537
55439c61
EZ
85382011-08-02 Eli Zaretskii <eliz@gnu.org>
8539
8540 Fix slow cursor motion and scrolling in large buffers with
8541 selective display, like Org Mode buffers. (Bug#9218)
8542
8543 * dispextern.h (struct bidi_it): New member disp_prop_p.
8544
8545 * xdisp.c: Remove one-slot cache of display string positions.
8546 (compute_display_string_pos): Accept an additional argument
5e617bc2 8547 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8548 for a display string or property. If found, set DISP_PROP_P
8549 non-zero.
8550
8551 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8552 DISP_PROP_P, and pass it to compute_display_string_pos.
8553 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8554 non-zero. All callers of bidi_fetch_char changed.
8555
fb33fa43
SM
85562011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8557
8558 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8559
b099e063
DM
85602010-12-03 Don March <don@ohspite.net>
8561
8562 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8563 last character M-[char] is translated to ESC [char] (bug#7541).
8564
5cc7f7af
KH
85652011-08-02 Kenichi Handa <handa@m17n.org>
8566
d0fffa3f 8567 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8568
8569 * chartab.c (uniprop_table): Make it non-static.
8570
525d5e6e
EZ
85712011-08-01 Eli Zaretskii <eliz@gnu.org>
8572
8573 * xdisp.c (forward_to_next_line_start): Accept additional argument
8574 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8575 on the newline.
8576 (reseat_at_next_visible_line_start): Use the bidi iterator state
8577 returned by forward_to_next_line_start to restore the state of
8578 it->bidi_it after backing up to previous newline. (Bug#9212)
8579
31011111
AS
85802011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8581
8582 * regex.c (re_comp): Protoize.
8583 (re_exec): Fix return type.
8584 (regexec): Fix type of `ret'. (Bug#9203)
8585
476371c4
PE
85862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8587
e5d76069
PE
8588 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8589 This is needed if max-image-size is a floating-point number.
8590
9a79b20c
AS
85912011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8592
8593 * print.c (print_object): Print empty symbol as ##.
8594
8595 * lread.c (read1): Read ## as empty symbol.
8596
d8c2fa78
AA
85972011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8598
8599 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8600 setting frame foreground color (Bug#9175).
8601 (x_set_background_color): Likewise.
8602
ffe57a7a
AA
8603 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8604 contents (Bug#9176).
8605 (EmacsTooltip -init): Remove bezels and add shadows to
8606 tooltip windows.
8607
bf3492a5
AA
8608 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8609 or scroll bar (Bug#8470).
8610
d55e9c53
AA
8611 * nsfont.m (nsfont_open): Remove assignment to voffset and
8612 unnecessary vars hshink, expand, hd, full_height, min_height.
8613 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8614
8615 * nsterm.h (nsfont_info): Remove voffset field.
8616
d8c2fa78 86172011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8618
8619 Implement strike-through and overline on NextStep (Bug#8863).
8620
8621 * nsfont.m (nsfont_open): Use underline position provided by font,
8622 instead of hard-coded value of 2.
8623 (nsfont_draw): Call ns_draw_text_decoration instead.
8624
8625 * nsterm.h: Add declaration for ns_draw_text_decoration.
8626
8627 * nsterm.m (ns_draw_text_decoration): New function for drawing
8628 underline, overline, and strike-through.
8629 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8630 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8631 accommodate underlining, etc.
4843aac3 8632
4cc60b9b
EZ
86332011-07-28 Eli Zaretskii <eliz@gnu.org>
8634
bc7ece87
EZ
8635 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8636 default.
4cc60b9b 8637
476371c4
PE
86382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8639
66606eea
PE
8640 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8641 Without this fix, if a signal arrives just after memory fills up,
8642 'malloc' might be invoked reentrantly.
8643
476371c4
PE
8644 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8645 In other words, assume that every image size is allowed, on non-X
8646 hosts. This assumption is probably wrong, but it lets Emacs compile.
8647
f3fcc40d
AS
86482011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8649
8650 * regex.c (re_iswctype): Convert return values to boolean.
8651
350c992f
EZ
86522011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8653
8654 * xdisp.c (compute_display_string_pos): Don't use cached display
8655 string position if the buffer had its restriction changed.
8656 (Bug#9184)
8657
5266b4bb
PE
86582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8659
8660 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8661
2573a837 86622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8663
41f55ccd 8664 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8665
39e378da
PE
8666 * bidi.c: Integer size and overflow fixes.
8667 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8668 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8669 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8670 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8671 (bidi_find_other_level_edge):
8672 Use ptrdiff_t instead of EMACS_INT where either will do.
8673 This works better on 32-bit hosts configured --with-wide-int.
8674 (bidi_cache_ensure_space): Check for size-calculation overflow.
8675 Use % rather than repeated addition, for better worst-case speed.
8676 Don't set bidi_cache_size until after xrealloc returns, because it
8677 might not return.
8678 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8679 (bidi_cache_ensure_space): Also check that the bidi cache size
8680 does not exceed that of the largest Lisp string or buffer. See Eli
8681 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8682
5e927815
PE
8683 * alloc.c (__malloc_size_t): Remove.
8684 All uses replaced by size_t. See Andreas Schwab's note
8685 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8686
ca4aa935
PE
8687 * image.c: Improve checking for integer overflow.
8688 (check_image_size): Assume that f is nonnull, since
8689 it is always nonnull in practice. This is one less thing to
8690 worry about when checking for integer overflow later.
8691 (x_check_image_size): New function, which checks for integer
8692 overflow issues inside X.
8693 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8694 This removes the need for a memory_full check.
8695 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8696 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8697 (xbm_read_bitmap_data): Change locals back to 'int', since
8698 their values must fit in 'int'.
8699 (xpm_load_image, png_load, tiff_load):
8700 Invoke x_create_x_image_and_pixmap earlier,
8701 to avoid much needless work if the image is too large.
8702 (tiff_load): Treat overly large images as if
8703 x_create_x_image_and_pixmap failed, not as malloc failures.
8704 (gs_load): Use x_check_image_size.
8705
5f8f9cc2
PE
8706 * gtkutil.c: Omit integer casts.
8707 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8708 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8709
5adf60bc
PE
8710 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8711
c8907a93
PE
8712 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8713 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8714 would wrongly return t on a 64-bit host.
8715
e3c25c68
PE
8716 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8717 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8718 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8719 and therefore cause GCC to emit a bogus diagnostic in some cases.
8720
3f791afe
PE
8721 * image.c: Integer signedness and overflow and related fixes.
8722 This is not an exhaustive set of fixes, but it's time to
8723 record what I've got.
8724 (lookup_pixel_color, check_image_size): Remove redundant decls.
8725 (check_image_size): Don't assume that arbitrary EMACS_INT values
8726 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8727 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8728 (tiff_load, imagemagick_load_image):
8729 Check for overflow in size calculations.
8730 (x_create_x_image_and_pixmap): Remove unnecessary test for
8731 xmalloc returning NULL; that can't happen.
8732 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8733 (xpm_color_bucket): Use better integer hashing function.
8734 (xpm_cache_color): Don't possibly over-allocate memory.
8735 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8736 (gif_memory_source):
8737 Use ptrdiff_t, not int or size_t, to record sizes.
8738 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8739 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8740 either works, as we prefer signed integers.
8741 (tiff_read_from_memory, tiff_write_from_memory):
8742 Return tsize_t, not size_t, since that's what the TIFF API wants.
8743 (tiff_read_from_memory): Don't fail simply because the read would
8744 go past EOF; instead, return a short read.
8745 (tiff_load): Omit no-longer-needed casts.
8746 (Fimagemagick_types): Don't assume size fits into 'int'.
8747
3cc5a532
PE
8748 Improve hashing quality when configured --with-wide-int.
8749 * fns.c (hash_string): New function, taken from sxhash_string.
8750 Do not discard information about ASCII character case; this
8751 discarding is no longer needed.
8752 (sxhash-string): Use it. Change sig to match it. Caller changed.
8753 * lisp.h: Declare it.
8754 * lread.c (hash_string): Remove, since we now use fns.c's version.
8755 The fns.c version returns a wider integer if --with-wide-int is
8756 specified, so this should help the quality of the hashing a bit.
8757
b312a492
PE
8758 * emacs.c: Integer overflow minor fix.
8759 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8760 Define only if GNU_LINUX.
8761 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8762
dfd153ae
PE
8763 * dispnew.c: Integer signedness and overflow fixes.
8764 Remove unnecessary forward decls, that were a maintenance hassle.
8765 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8766 All uses changed.
8767 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8768 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8769 (prepare_desired_row, line_draw_cost):
8770 Use int, not unsigned, where either works.
8771 (save_current_matrix, restore_current_matrix):
8772 Use ptrdiff_t, not size_t, where either works.
8773 (init_display): Check for overflow more accurately, and without
8774 relying on undefined behavior.
8775
a81d11a3
PE
8776 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8777 Remove, replacing with the new symbols in lisp.h. All uses changed.
8778 * fileio.c (make_temp_name):
8779 * filelock.c (lock_file_1, lock_file):
8780 * xdisp.c (message_dolog):
8781 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8782 Use pMd etc. instead.
8783 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8784 replacing the pWIDE etc. symbols removed from editfns.c.
8785
3300e6fd
PE
8786 * keyboard.h (num_input_events): Now uintmax_t.
8787 This is (very slightly) less likely to mess up due to wraparound.
8788 All uses changed.
8789
fd05c7e9
PE
8790 * buffer.c: Integer signedness fixes.
8791 (alloc_buffer_text, enlarge_buffer_text):
8792 Use ptrdiff_t rather than size_t when either will do, as we prefer
8793 signed integers.
8794
903fe15d
PE
8795 * alloc.c: Integer signedness and overflow fixes.
8796 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8797 (__malloc_size_t): Default to size_t, not to int.
8798 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8799 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8800 Prefer ptrdiff_t to size_t when either would do, as we prefer
8801 signed integers.
8802 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8803 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8804 Now const. Initialize with values that are in range even if char
8805 is signed.
8806 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8807 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8808 These functions do the right thing with sizes > 2**32.
8809 (check_depth): Now ptrdiff_t, not int.
8810 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8811 Adjust to new way of storing sizes. Check for size overflow bugs
8812 in rest of code.
8813 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8814 slightly wrong anyway, as it missed one instance of
8815 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8816 (refill_memory_reserve): Omit needless cast to size_t.
8817 (mark_object_loop_halt): Mark as externally visible.
8818
ac82cc6a
PE
8819 * xselect.c: Integer signedness and overflow fixes.
8820 (Fx_register_dnd_atom, x_handle_dnd_message):
8821 Use ptrdiff_t, not size_t, since we prefer signed.
8822 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8823 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8824 x_dnd_atoms_size and x_dnd_atoms_length.
8825
c2d1e36d
PE
8826 * doprnt.c: Prefer signed to unsigned when either works.
8827 * eval.c (verror):
8828 * doprnt.c (doprnt):
8829 * lisp.h (doprnt):
8830 * xdisp.c (vmessage):
8831 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8832 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8833 prefer signed arithmetic to avoid comparison confusion.
8834 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8835 but is a bit tricky.
8836
0e926e56
PE
8837 Assume freestanding C89 headers, string.h, stdlib.h.
8838 * data.c, doprnt.c, floatfns.c, print.c:
8839 Include float.h unconditionally.
8840 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8841 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8842 * regex.c: Likewise for stddef.h, string.h.
8843 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8844 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8845 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8846 (STDC_HEADERS): Remove obsolete defines.
8847 * sysdep.c: Include limits.h unconditionally.
8848
9cfdb3ec
PE
8849 Assume support for memcmp, memcpy, memmove, memset.
8850 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8851 * regex.c (memcmp, memcpy):
8852 Remove; we assume C89 now.
8853
8854 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8855 (__malloc_safe_bcopy): Remove; no longer needed.
8856
cf950e6b 8857 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8858 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8859 well either way, and we prefer signed to unsigned.
8860
dbf38e02
LMI
88612011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8862
8863 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8864 closes the connection while we're reading (bug#9182).
8865
d6f0886c 88662011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8867
d6f0886c
JD
8868 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8869 are specified (Bug#9168).
24e0f6b1 8870
2eb1f9e6
PE
88712011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8872
8873 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8874 Found by GCC static checking and --with-wide-int on a 32-bit host.
8875
22381272 88762011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8877
8878 * xdisp.c (compute_display_string_pos): Fix logic of caching
8879 previous display string position. Initialize cached_prev_pos to
8880 -1. Fixes slow-down at the beginning of a buffer.
8881
f25e39b4
EZ
88822011-07-24 Eli Zaretskii <eliz@gnu.org>
8883
8884 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8885 for attrs[LFACE_FONTSET_INDEX].
8886
04c4b52e
PE
88872011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8888
8889 * xml.c (parse_region): Remove unused local
8890 that was recently introduced.
8891
c1734fbd
EZ
88922011-07-23 Eli Zaretskii <eliz@gnu.org>
8893
be18c5a5
EZ
8894 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8895 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8896
c1734fbd
EZ
8897 * xdisp.c (move_it_in_display_line_to): Record the best matching
8898 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8899 exit if none of the characters scanned was an exact match.
8900 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8901 when exact match is impossible due to invisible text, and the
8902 lines are truncated.
8903
a258d627
JD
89042011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8905
8906 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8907 for OSX >= 10.7.
8908
b6d5a689
EZ
89092011-07-22 Eli Zaretskii <eliz@gnu.org>
8910
0f74f785
EZ
8911 Fix a significant slow-down of cursor motion with C-n, C-p,
8912 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8913 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8914 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8915 (next_element_from_buffer): Call compute_stop_pos_backwards to
8916 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8917 base_level_stop.
8918 (reseat): Don't look for prev_stop, as that could mean a very long
8919 run.
8920 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8921 <cached_disp_overlay_modiff>: Cache for last found display string
8922 position.
551918c1 8923 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8924 about the same buffer in the same area of character positions, and
8925 the buffer wasn't changed since the time the display string
8926 position was cached.
551918c1 8927
b2d0c91a
EZ
89282011-07-22 Eli Zaretskii <eliz@gnu.org>
8929
8930 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8931 is an integer, which is important for empty lines. (Bug#9149)
8932
043604ee
CY
89332011-07-22 Chong Yidong <cyd@stupidchicken.com>
8934
8935 * frame.c (Fmodify_frame_parameters): In tty case, update the
8936 default face if necessary (Bug#4238).
8937
da4adb04
CY
89382011-07-21 Chong Yidong <cyd@stupidchicken.com>
8939
8940 * editfns.c (Fstring_to_char): No need to explain what a character
8941 is in the docstring (Bug#6576).
8942
9abd0532
LMI
89432011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8944
8945 * xml.c (parse_region): Make sure we always return a tree.
8946
36881d16
HK
89472011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8948
8949 * xml.c (parse_region): If a document contains only comments,
8950 return that, too.
8951
1e98674d
LMI
89522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8953
8954 * xml.c (make_dom): Return comments, too.
8955
590bd467
PE
89562011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8957
8958 Port to OpenBSD.
8959 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8960 and the surrounding thread.
8961 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8962 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8963 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8964 timer goes off.
8965 * s/openbsd.h (BROKEN_SIGIO): Define.
8966 * unexelf.c (unexec) [__OpenBSD__]:
8967 Don't update the .mdebug section of the Alpha COFF symbol table.
8968
f41628b2
LMI
89692011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8970
8971 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8972 (bug#8460).
8973
b59b67c5
PE
89742011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8975
15e3a074
PE
8976 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8977 This fixes some race conditions on the permissions of any newly
8978 created file.
8979
41bed37d
PE
8980 * alloc.c (valid_pointer_p): Use pipe, not open.
8981 This fixes some permissions issues when debugging.
8982
b59b67c5
PE
8983 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8984 If fchown fails to set both uid and gid, try to set just gid,
8985 as that is sometimes allowed. Adjust the file's mode to eliminate
8986 setuid or setgid bits that are inappropriate if fchown fails.
8987
925a6be7
SM
89882011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8989
8990 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8991 to compare Lisp_Objects.
8992 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8993 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8994 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8995
52968808
AS
89962011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8997
0a6a104b
AS
8998 * lread.c (read_integer): Unread even EOF character.
8999 (read1): Likewise. Properly record start position of symbol.
9000
52968808
AS
9001 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9002 symbol character follows.
9003
9e381cdd
PE
90042011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9005
9006 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9007 This works around a problem with the previous change to Fcopy_file.
9008 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9009 and without this change, GCC might complain about discarding
9010 fchown's return value.
9011
b5641435
JB
90122011-07-16 Juanma Barranquero <lekktu@gmail.com>
9013
9014 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9015
a8031457
PE
90162011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9017
9018 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9019
dd889327
LMI
90202011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9021
750c33f7
LMI
9022 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9023 it's used from the C level.
9024
dd889327
LMI
9025 * process.c: Use the same condition for POLL_FOR_INPUT in both
9026 keyboard.c and process.c (bug#1858).
9027
87e86684
LM
90282011-07-09 Lawrence Mitchell <wence@gmx.li>
9029
9030 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9031 (Fgnutls_boot): Use it.
9032
64348f40
AS
90332011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9034
9035 * doc.c (Fsubstitute_command_keys): Revert last change.
9036
1d698799
LMI
90372011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9038
f863868c
LMI
9039 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9040 quotes the next character, and doesn't affect other longer
9041 sequences (bug#8935).
9042
1d698799
LMI
9043 * lread.c (syms_of_lread): Clarify that is isn't only
9044 `eval-buffer' and `eval-defun' that's affected by
9045 `lexical-binding' (bug#8460).
9046
aa4b6df6
EZ
90472011-07-15 Eli Zaretskii <eliz@gnu.org>
9048
9049 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9050 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9051
5d856da6
PE
90522011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9053
ad6042bb
PE
9054 Fix minor problems found by static checking.
9055 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9056 (elsz): Now a signed constant, not a size_t var. We prefer signed
9057 types to unsigned, to avoid integer comparison confusion. Without
9058 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9059 "cannot optimize loop, the loop counter may overflow", a symptom
9060 of the confusion.
f00bbb22 9061 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9062 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9063
6468f31c
LMI
90642011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9065
49080b10
LMI
9066 * search.c (Fre_search_backward): Mention `case-fold-search' in
9067 all the re_search_* functions (bug#8138).
9068
6468f31c
LMI
9069 * keyboard.c (Fopen_dribble_file): Document when the file is
9070 closed (bug#8056).
9071
c965adc5
EZ
90722011-07-14 Eli Zaretskii <eliz@gnu.org>
9073
df9733bf
EZ
9074 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9075 bidi_cache_idx.
9076
0bb23927
EZ
9077 Support bidi reordering of display and overlay strings.
9078 * xdisp.c (compute_display_string_pos)
9079 (compute_display_string_end): Accept additional argument STRING.
9080 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9081 (reseat_to_string): Initialize bidi_it->string.s and
9082 bidi_it->string.schars.
9083 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9084 NULL (avoids a crash in bidi_paragraph_init).
9085 Initialize itb.string.lstring.
0bb23927
EZ
9086 (init_iterator): Call bidi_init_it only of a valid
9087 buffer position was specified. Initialize paragraph_embedding to
9088 L2R.
9089 (reseat_to_string): Initialize the bidi iterator.
9090 (display_string): If we need to ignore text properties of
9091 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9092 original value of -1 will not work with bidi.)
9093 (compute_display_string_pos): First arg is now struct
9094 `text_pos *'; all callers changed. Support display properties on
9095 Lisp strings.
9096 (compute_display_string_end): Support display properties on Lisp
9097 strings.
9098 (init_iterator, reseat_1, reseat_to_string): Initialize the
9099 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9100 when iterating on a string not from display properties).
640c8776
SM
9101 (compute_display_string_pos, compute_display_string_end):
9102 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9103 arrow keys.
9104 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9105 base_level_stop; instead, set base_level_stop to BEGV.
9106 Fixes crashes in vertical-motion.
0bb23927
EZ
9107 (next_element_from_buffer): Improve commentary for when
9108 the iterator is before prev_stop.
9109 (init_iterator): Initialize bidi_p from the default value of
9110 bidi-display-reordering, not from buffer-local value. Use the
9111 buffer-local value only if initializing for buffer iteration.
9112 (handle_invisible_prop): Support invisible properties on strings
9113 that are being bidi-reordered.
9114 (set_iterator_to_next): Support bidi reordering of C strings and
9115 Lisp strings.
9116 (next_element_from_string): Support bidi reordering of Lisp
9117 strings.
9118 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9119 (display_string): Support display of R2L glyph rows.
9120 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9121 (init_iterator): Don't initialize it->bidi_p for strings
9122 here.
9123 (reseat_to_string): Initialize it->bidi_p for strings here.
9124 (next_element_from_string, next_element_from_c_string)
9125 (next_element_from_buffer): Add xassert's for correspondence
9126 between IT's object being iterated and it->bidi_it.string
9127 structure.
9128 (face_before_or_after_it_pos): Support bidi iteration.
9129 (next_element_from_c_string): Handle the case of the first string
9130 character that is not the first one in the visual order.
9131 (get_visually_first_element): New function, refactored from common
9132 parts of next_element_from_buffer, next_element_from_string, and
9133 next_element_from_c_string.
9134 (tool_bar_lines_needed, redisplay_tool_bar)
9135 (display_menu_bar): Force left-to-right direction. Add a FIXME
9136 comment for making that be controlled by a user option.
9137 (push_it, pop_it): Save and restore the state of the
9138 bidi iterator. Save and restore the bidi_p flag.
9139 (pop_it): Iterate out of display property for string iteration as
9140 well.
9141 (iterate_out_of_display_property): Support iteration over strings.
9142 (handle_single_display_spec): Set up it->bidi_it for iteration
9143 over a display string, and call bidi_init_it.
9144 (handle_single_display_spec, next_overlay_string)
9145 (get_overlay_strings_1, push_display_prop): Set up the bidi
9146 iterator for displaying display or overlay strings.
9147 (forward_to_next_line_start): Don't use the shortcut if
9148 bidi-iterating.
9149 (back_to_previous_visible_line_start): If handle_display_prop
9150 pushed the iterator stack, restore the internal state of the bidi
9151 iterator by calling bidi_pop_it same number of times.
9152 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9153 and we are bidi-iterating, don't decrement the iterator position;
9154 instead, set the first_elt flag in the bidi iterator, to produce
9155 the same effect.
9156 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9157 (push_display_prop): xassert that we are iterating a buffer.
9158 (push_it, pop_it): Save and restore paragraph_embedding member.
9159 (handle_single_display_spec, next_overlay_string)
9160 (get_overlay_strings_1, reseat_1, reseat_to_string)
9161 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9162 correctly. Don't assume unibyte strings are not bidi-reordered.
9163 (compute_display_string_pos)
9164 (compute_display_string_end): Fix handling the case of C string.
9165 (push_it, pop_it): Save and restore from_disp_prop_p.
9166 (handle_single_display_spec, push_display_prop): Set the
9167 from_disp_prop_p flag.
9168 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9169 (pop_it): Call iterate_out_of_display_property only if we are
9170 popping after iteration over a string that came from a display
9171 property. Fix a typo in popping stretch info. Add an assertion
9172 for verifying that the iterator position is in sync with the bidi
9173 iterator.
9174 (handle_single_display_spec, get_overlay_strings_1)
9175 (push_display_prop): Fix initialization of paragraph direction for
9176 string when that of the parent object is not yet determined.
9177 (reseat_1): Call bidi_init_it to resync the bidi
9178 iterator with IT's position. (Bug#7616)
9179 (find_row_edges): If ROW->start.pos gives position
9180 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9181 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9182 Reset the from_disp_prop_p flag.
9183 (SAVE_IT, RESTORE_IT): New macros.
9184 (pos_visible_p, face_before_or_after_it_pos)
9185 (back_to_previous_visible_line_start)
9186 (move_it_in_display_line_to, move_it_in_display_line)
9187 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9188 (try_scrolling, redisplay_window, display_line): Use them when
9189 saving a temporary copy of the iterator and restoring it back.
9190 (back_to_previous_visible_line_start, reseat_1)
9191 (init_iterator): Empty the bidi cache "stack".
9192 (move_it_in_display_line_to): If iterator ended up at
9193 EOL, but we never saw any buffer positions smaller than
9194 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9195 motion in bidi-reordered lines.
9196 (move_it_in_display_line_to): Record prev_method and prev_pos
9197 immediately before the call to set_iterator_to_next. Fixes cursor
9198 motion in bidi-reordered lines with stretch glyphs and strings
9199 displayed in margins. (Bug#8133) (Bug#8867)
9200 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9201 TO_CHARPOS.
640c8776
SM
9202 (pos_visible_p): Support positions in bidi-reordered lines.
9203 Save and restore bidi cache.
0bb23927
EZ
9204
9205 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9206 (bidi_paragraph_info): Delete unused struct.
9207 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9208 (bidi_cache_start): New variable.
9209 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9210 to zero.
9211 (bidi_cache_fetch_state, bidi_cache_search)
9212 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9213 (bidi_cache_find, bidi_peek_at_next_level)
9214 (bidi_level_of_next_char, bidi_find_other_level_edge)
9215 (bidi_move_to_visually_next): Compare cache index with
9216 bidi_cache_start rather than with zero.
9217 (bidi_fetch_char): Accept new argument STRING; all callers
9218 changed. Support iteration over a string. Support strings with
9219 display properties. Support unibyte strings. Fix the type of
9220 `len' according to what STRING_CHAR_AND_LENGTH expects.
9221 (bidi_paragraph_init, bidi_resolve_explicit_1)
9222 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9223 (bidi_level_of_next_char, bidi_move_to_visually_next):
9224 Support iteration over a string.
0bb23927
EZ
9225 (bidi_set_sor_type, bidi_resolve_explicit_1)
9226 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9227 can now be zero (for strings); special values 0 and -1 were
9228 changed to -1 and -2, respectively.
9229 (bidi_char_at_pos): New function.
9230 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9231 Call it instead of FETCH_MULTIBYTE_CHAR.
9232 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9233 initialized to valid values.
9234 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9235 values.
9236 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9237 the test for valid cached positions. Fix the logic for looking up
9238 the sentinel state in the cache. GCPRO the Lisp string we are
9239 iterating.
9240 (bidi_push_it, bidi_pop_it): New functions.
9241 (bidi_initialize): Initialize the bidi cache start stack pointer.
9242 (bidi_cache_ensure_space): New function, refactored from part of
9243 bidi_cache_iterator_state. Don't assume the required size is just
9244 one BIDI_CACHE_CHUNK away.
9245 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9246 (bidi_count_bytes, bidi_char_at_pos): New functions.
9247 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9248 always valid if bidi_cache_idx is valid.
9249 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9250 is valid if it's going to be used.
9251 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9252 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9253 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9254 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9255 (bidi_find_other_level_edge, bidi_cache_start_stack):
9256 All variables related to cache indices are now EMACS_INT.
c965adc5 9257
0bb23927
EZ
9258 * dispextern.h (struct bidi_string_data): New structure.
9259 (struct bidi_it): New member `string'. Make flag members be 1-bit
9260 fields, and put them last in the struct.
640c8776
SM
9261 (compute_display_string_pos, compute_display_string_end):
9262 Update prototypes.
0bb23927
EZ
9263 (bidi_push_it, bidi_pop_it): Add prototypes.
9264 (struct iterator_stack_entry): New members bidi_p,
9265 paragraph_embedding, and from_disp_prop_p.
9266 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9267 (bidi_shelve_cache, bidi_unshelve_cache):
9268 Declare prototypes.
0bb23927
EZ
9269
9270 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9271 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9272 and vector-like objects.
9273
9274 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9275 cache around display iteration.
9276
9277 * window.c (Fwindow_end, window_scroll_pixel_based)
9278 (displayed_window_lines, Frecenter): Save and restore the bidi
9279 cache around display iteration.
9280
3bbd2265
LMI
92812011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9282
9283 * editfns.c (Fdelete_region): Clarify the use of the named
9284 parameters (bug#6788).
9285
adc47434
MR
92862011-07-14 Martin Rudalics <rudalics@gmx.at>
9287
9288 * indent.c (Fvertical_motion): Set and restore w->pointm when
9289 saving and restoring the window's buffer (Bug#9006).
9290
837c31f8
LMI
92912011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9292
9293 * editfns.c (Fstring_to_char): Clarify just what is returned
9294 (bug#6576). Text by Eli Zaretskii.
9295
ac389d0c
JB
92962011-07-13 Juanma Barranquero <lekktu@gmail.com>
9297
9298 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9299
0be0ce47
EZ
93002011-07-13 Eli Zaretskii <eliz@gnu.org>
9301
9302 * buffer.c (mmap_find): Fix a typo.
9303
cd18e7e3
JB
93042011-07-13 Johan Bockgård <bojohan@gnu.org>
9305
9306 Fix execution of x selection hooks.
9307 * xselect.c (Qx_lost_selection_functions)
9308 (Qx_sent_selection_functions): New vars.
9309 (syms_of_xselect): DEFSYM them.
9310 (x_handle_selection_request): Pass Qx_sent_selection_functions
9311 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9312 (x_handle_selection_clear,x_clear_frame_selections):
9313 Pass Qx_lost_selection_functions rather than
9314 Vx_lost_selection_functions to Frun_hook_with_args.
9315
47ea7f44
PE
93162011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9317
ac389d0c 9318 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9319 The old code sometimes used this field without initializing it.
9320
47ea7f44
PE
9321 * alloc.c (gc_sweep): Don't read past end of array.
9322 In theory, the old code could also have corrupted Emacs internals,
9323 though it'd be very unlikely.
9324
bc985c87
AS
93252011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9326
9327 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9328 argument. (Bug#4026)
bc985c87 9329
0cf34688
LMI
93302011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9331
b3dadd76
LMI
9332 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9333 key" (bug#4257).
9334
0cf34688
LMI
9335 * window.c (Fset_window_start): Doc fix (bug#4199).
9336 (Fset_window_hscroll): Ditto.
9337
270768cd
PE
93382011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9339
077e3dda 9340 Fix minor new problems caught by GCC 4.6.1.
270768cd 9341 * term.c (init_tty): Remove unused local.
490011a6 9342 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9343 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9344 not used otherwise.
270768cd 9345
b1f58454
CY
93462011-07-12 Chong Yidong <cyd@stupidchicken.com>
9347
9348 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9349
22b9578d
LMI
93502011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9351
6e70ab07
LMI
9352 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9353 are the mini-buffer and the echo area (bug#3320).
9354
22b9578d
LMI
9355 * term.c (init_tty): Remove support for supdup, c10 and perq
9356 terminals, which are no longer supported (bug#1482).
9357
8974cc9f
JB
93582011-07-10 Johan Bockgård <bojohan@gnu.org>
9359
9360 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9361
a560d974
JD
93622011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9363
9364 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9365 for non-popups (Bug#3642).
9366
1dae0f0a
AS
93672011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9368
268c2c36 9369 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9370 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9371 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9372 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9373 * data.c (fmod): Likewise.
9374 * dispnew.c (swap_glyphs_in_rows): Likewise.
9375 * emacs.c (memory_warning_signal): Likewise.
9376 * floatfns.c (float_error): Likewise.
9377 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9378 (otf_open, font_otf_capability, generate_otf_features)
9379 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9380 Likewise.
9381 * image.c (pbm_read_file): Likewise.
9382 * indent.c (string_display_width): Likewise.
9383 * intervals.c (check_for_interval, search_for_interval)
9384 (inc_interval_count, count_intervals, root_interval)
9385 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9386 * lread.c (defalias): Likewise.
268c2c36 9387 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9388 * regex.c (set_image_of_range_1, set_image_of_range)
9389 (regex_grow_registers): Likewise.
9390 * sysdep.c (strerror): Likewise.
9391 * termcap.c (valid_filename_p, tprint, main): Likewise.
9392 * tparam.c (main): Likewise.
9393 * unexhp9k800.c (run_time_remap, save_data_space)
9394 (update_file_ptrs, read_header, write_header, calculate_checksum)
9395 (copy_file, copy_rest, display_header): Likewise.
9396 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9397 Likewise.
9398 * xdisp.c (check_it): Likewise.
9399 * xfaces.c (register_color, unregister_color, unregister_colors):
9400 Likewise.
9401 * xfns.c (print_fontset_result): Likewise.
9402 * xrdb.c (member, fatal, main): Likewise.
9403
99033785
PE
94042011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9405
9406 Fix minor problems found by static checking (Bug#9031).
9407 * chartab.c (char_table_set_range, map_sub_char_table):
9408 Remove unused locals.
9409 (uniprop_table): Now static.
9410 * composite.c (_work_char): Remove unused static var.
9411
9cb2ac56
JB
94122011-07-09 Juanma Barranquero <lekktu@gmail.com>
9413
9414 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9415
f25661f0
JD
94162011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9417
9418 * gtkutil.c (qttip_cb): Remove code without function.
9419
8278c4fe
EZ
94202011-07-09 Eli Zaretskii <eliz@gnu.org>
9421
9422 * w32.c (pthread_sigmask): New stub.
9423
1692ae2d 94242011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9425
8a6ebd58 9426 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9427 sigprocmask is portable only for single-threaded applications, and
9428 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9429 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9430 (LIBES): Use it.
9431 * callproc.c (Fcall_process):
9432 * process.c (create_process):
9433 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9434 Use pthread_sigmask, not sigprocmask.
123403e4 9435
1b854618
JD
94362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9437
9438 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9439 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9440 wrong (Bug#8591).
9441
3fe4b549
JD
94422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9443
0ce7e563
JD
9444 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9445 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9446 (xg_hide_tooltip): Fix comment.
9447
3fe4b549
JD
9448 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9449 in registerServicesMenuSendTypes.
9450 (validRequestorForSendType): Don't check ns_return_types.
9451
9452 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9453 ns_return_type.
9454
5df75e47
JR
94552011-07-08 Jason Rumney <jasonr@gnu.org>
9456
22610910
JR
9457 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9458 SH_SHOW for hidden windows (Bug#5482).
9459
5df75e47
JR
9460 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9461 frame struct members of non-existent frames (Bug#6284).
9462
699c10bd
JD
94632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9464
4393663b
JD
9465 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9466 variable firstTime not needed on OSX >= 10.6.
9467 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9468 >= 10.5. Use setKnobProportion, setDoubleValue.
9469
9470 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9471 (MAC_OS_X_VERSION_10_5): Define if not defined.
9472 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9473 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9474 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9475
9476 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9477 cString and lossyCString on OSX >= 10.4.
4393663b 9478
58179cce 9479 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9480 sizeToFit on OSX >= 10.2.
9481
9482 * nsimage.m (allocInitFromFile): Don't use deprecated method
9483 bestRepresentationForDevice on OSX >= 10.6.
9484
9485 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9486 to avoid warning.
9487
9488 * emacs.c: Declare unexec_init_emacs_zone.
9489
a63e0781
JD
9490 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9491
699c10bd
JD
9492 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9493
9494 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9495 on svcsMenu (Bug#8842).
9496
9497 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9498 ns_return_types.
9499 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9500
9501 * nsterm.m (QUTF8_STRING): Declare.
9502 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9503 (validRequestorForSendType): Return type is (id).
9504 Change indexOfObjectIdenticalTo to indexOfObject.
9505 Check if we have local selection before returning self (Bug#8842).
9506 (writeSelectionToPasteboard): Put local selection into paste board
9507 if we have a local selection (Bug#8842).
9508 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9509
9510 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9511 (ns_get_local_selection): Declare.
9512
54e10184
LMI
95132011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9514
9888ff71
LMI
9515 * keymap.c (describe_map_tree): Don't insert a double newline at
9516 the end of the buffer (bug#1169) and return whether we inserted
9517 something.
9518
54e10184
LMI
9519 * callint.c (Fcall_interactively): Change "reading args" to
9520 "providing args" to try to clarify what it does (bug#1010).
9521
15fa4783
KH
95222011-07-07 Kenichi Handa <handa@m17n.org>
9523
9524 * composite.c (composition_compute_stop_pos): Ignore a static
9525 composition starting before CHARPOS (Bug#8915).
9526
9527 * xdisp.c (handle_composition_prop): Likewise.
9528
a8815b00
EZ
95292011-07-07 Eli Zaretskii <eliz@gnu.org>
9530
9531 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9532 (Bug#9015)
9533
ef7b981d 95342011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9535
9536 * character.h (unicode_category_t): New enum type.
9537
9538 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9539 (Qchar_code_property_table): New variable.
9540 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9541 (UNIPROP_COMPRESSED_FORM_P): New macros.
9542 (char_table_ascii): Uncompress the compressed values.
9543 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9544 Uncompress the compressed values.
ac389d0c 9545 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9546 (char_table_ref_and_range): Uncompress the compressed values.
9547 (sub_char_table_set): New arg is_uniprop. Callers changed.
9548 Uncompress the compressed values.
9549 (sub_char_table_set_range): Args changed. Callers changed.
9550 (char_table_set_range): Adjuted for the above change.
9551 (map_sub_char_table): Delete args default_val and parent. Add arg
9552 top. Give decoded values to a Lisp function.
640c8776 9553 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9554 values to a Lisp function. Gcpro more variables.
9555 (uniprop_table_uncompress)
9556 (uniprop_decode_value_run_length): New functions.
9557 (uniprop_decoder, uniprop_decoder_count): New variables.
9558 (uniprop_get_decoder, uniprop_encode_value_character)
9559 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9560 New functions.
9561 (uniprop_encoder, uniprop_encoder_count): New variables.
9562 (uniprop_get_encoder, uniprop_table)
9563 (Funicode_property_table_internal, Fget_unicode_property_internal)
9564 (Fput_unicode_property_internal): New functions.
9565 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9566 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9567 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9568 char-code-property-alist.
9569
640c8776 9570 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9571 Vunicode_category_table.
9572
640c8776 9573 * font.c (font_range): Adjust for the change of
c805dec0
KH
9574 Vunicode_category_table.
9575
76b397fb
DN
95762011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9577
9578 * m/iris4d.h: Remove file, move contents ...
9579 * s/irix6-5.h: ... here.
9580
22b4128e
PE
95812011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9582
9583 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9584 * alloc.c (mark_buffer):
9585 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9586 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9587 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9588 This isn't true in general, and it's particularly not true
9589 if Emacs is configured with --with-wide-int.
9590 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9591 New macros, used in the buffer.c change.
9592
869795d6
JD
95932011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9594
9595 * xsettings.c: Use both GConf and GSettings if both are available.
9596 (store_config_changed_event): Add comment.
9597 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9598 (store_tool_bar_style_changed): New functions.
5e617bc2 9599 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9600 (struct xsettings): Move font inside HAVE_XFT.
9601 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9602 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9603 Move inside HAVE_XFT.
640c8776 9604 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9605 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9606 also.
9607 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9608 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9609 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9610 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9611 (parse_settings): Move check for font inside HAVE_XFT.
9612 (read_settings, apply_xft_settings): Add comment.
9613 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9614 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9615 call store_font_name_changed.
9616 (xft_settings_event): Add comment.
9617 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9618 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9619 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9620 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9621 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9622 (xsettings_get_system_font, xsettings_get_system_normal_font):
9623 Add comment.
869795d6 9624
d8ed26bd
PE
96252011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9626
9627 Random fixes. E.g., (random) never returned negative values.
9628 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9629 subseconds part to the entropy, as that's a bit more random.
9630 Prefer signed to unsigned, since the signedness doesn't matter and
9631 in general we prefer signed. When given a limit, use a
9632 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9633 latter isn't right if USE_2_TAGS_FOR_INTS.
9634 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9635 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9636
cabf1cac
SM
96372011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9638
9639 * textprop.c (text_property_stickiness):
9640 Obey Vtext_property_default_nonsticky.
9641 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9642 * w32fns.c (syms_of_w32fns):
9643 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9644
6e9b2be9
PE
96452011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9646
9647 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9648 This is more efficient than Ffile_directory_p and avoids a minor race.
9649
90186c68
LMI
96502011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9651
7c301272
LMI
9652 * buffer.c (Foverlay_put): Say what the return value is
9653 (bug#7835).
9654
c4f2d8d4
LMI
9655 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9656 is a directory before asking whether to use the file name
9657 (bug#7564).
ad637907
LMI
9658 (barf_or_query_if_file_exists): Make the "File is a directory"
9659 error be more correct.
c4f2d8d4 9660
90186c68
LMI
9661 * fns.c (Frequire): Remove the mention of the .gz files, since
9662 that's installation-specific, but keep the mention of
9663 `get-load-suffixes'.
9664
da64016e
PE
96652011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9666
9667 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9668 Report string overflow if the output is too long.
9669
7d47b580
JB
96702011-07-04 Juanma Barranquero <lekktu@gmail.com>
9671
a555cb87
JB
9672 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9673 (syms_of_gnutls): Remove duplicate DEFSYM for
9674 Qgnutls_bootprop_verify_hostname_error, an error for
9675 Qgnutls_bootprop_verify_error (which is no longer used).
9676
7d47b580
JB
9677 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9678 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9679 Also (re)move comments that are misplaced or no longer relevant.
9680
1e49bfab
LMI
96812011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9682
9683 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9684
1485f4c0
CY
96852011-07-03 Chong Yidong <cyd@stupidchicken.com>
9686
9687 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9688 and background color parameters if they have been changed.
9689
a9ab721e
LMI
96902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9691
9692 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9693
cf7cff57
PE
96942011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9695
2e13213d
PE
9696 * xsettings.c (SYSTEM_FONT): Define only when used.
9697 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9698
cf7cff57
PE
9699 * keymap.c (access_keymap_1): Now static.
9700
7a8e04f7
CY
97012011-07-02 Chong Yidong <cyd@stupidchicken.com>
9702
9703 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9704 leave any prefix arg for the up event (Bug#1586).
9705
61352f62
LMI
97062011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9707
69bb1ef7
LMI
9708 * lread.c (syms_of_lread): Mention single symbols defined by
9709 `defvar' or `defconst' (bug#7154).
9710
61352f62 9711 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9712 (Frequire): Mention get-load-suffixes.
61352f62 9713
28545e04
MR
97142011-07-02 Martin Rudalics <rudalics@gmx.at>
9715
9716 * window.h (window): Remove clone_number slot.
9717 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9718 Remove.
9719 (make_parent_window, make_window, saved_window)
9720 (Fset_window_configuration, save_window_save): Don't deal with
9721 clone numbers.
9722 * buffer.c (Qclone_number): Remove declaration.
9723 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9724
3349e122
SM
97252011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9726
9727 Add multiple inheritance to keymaps.
9728 * keymap.c (Fmake_composed_keymap): New function.
9729 (Fset_keymap_parent): Simplify.
9730 (fix_submap_inheritance): Remove.
9731 (access_keymap_1): New function extracted from access_keymap to handle
9732 embedded parents and handle lists of maps.
9733 (access_keymap): Use it.
9734 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9735 (Fcopy_keymap): Handle embedded parents.
9736 (Fcommand_remapping, define_as_prefix): Simplify.
9737 (Fkey_binding): Simplify.
9738 (syms_of_keymap): Move minibuffer-local-completion-map,
9739 minibuffer-local-filename-completion-map,
9740 minibuffer-local-must-match-map, and
9741 minibuffer-local-filename-must-match-map to Elisp.
9742 (syms_of_keymap): Defsubr make-composed-keymap.
9743 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9744 (parse_menu_item): Trivial simplification.
9745
3279eb87
GM
97462011-07-01 Glenn Morris <rgm@gnu.org>
9747
9748 * Makefile.in (SETTINGS_LIBS): Fix typo.
9749
4550efdf
KI
97502011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9751
9752 * coding.c (Fencode_coding_string): Record the last coding system
9753 used, as the function doc string says (bug#8738).
9754
0949d2b6
JD
97552011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9756
9757 * xsettings.c (store_monospaced_changed): Take new font as arg and
9758 check for change against current_mono_font.
9759 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9760 (emacs_settings_constructor, emacs_settings_get_property)
9761 (emacs_settings_set_property, emacs_settings_class_init)
9762 (emacs_settings_init, gsettings_obj): Remove.
9763 (something_changedCB): New function for HAVE_GSETTINGS.
9764 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9765 with value as argument.
9766 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9767 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9768 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9769 "changed".
9770
9771 * xgselect.c: Add defined (HAVE_GSETTINGS).
9772 (xgselect_initialize): Ditto.
9773
9774 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9775 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9776 xg_select.
9777
bbc6b304
PE
97782011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9779
9780 * eval.c (struct backtrace): Simplify and port the data structure.
9781 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9782 signed bit field, as this assumption is not portable and it makes
9783 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9784 "char debug_on_exit : 1" as this is not portable either; instead,
9785 use the portable "unsigned int debug_on_exit : 1". Remove unused
9786 member evalargs. Remove obsolete comments about cc bombing out.
9787
9851bfc5
JD
97882011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9789
51bb811f 9790 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9791 Let HAVE_GSETTINGS override HAVE_GCONF.
9792 (store_monospaced_changed): New function.
9793 (EMACS_SETTINGS): A new type derived from GObject to handle
9794 GSettings notifications.
9795 (emacs_settings_constructor, emacs_settings_get_property)
9796 (emacs_settings_set_property, emacs_settings_class_init):
9797 New functions.
9798 (gsettings_client, gsettings_obj): New variables.
9799 (GSETTINGS_SCHEMA): New define.
9800 (something_changedCB): Call store_monospaced_changed.
9801 (init_gsettings): New function.
9802 (xsettings_initialize): Call init_gsettings.
9803 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9804 to NULL.
9805
640c8776 9806 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9807 GCONF_CFLAGS/LIBS.
9808
5386012d
MR
98092011-06-29 Martin Rudalics <rudalics@gmx.at>
9810
9811 * window.c (resize_root_window, grow_mini_window)
9812 (shrink_mini_window): Rename Qresize_root_window to
9813 Qwindow_resize_root_window and Qresize_root_window_vertically to
9814 Qwindow_resize_root_window_vertically.
9815
f13e0b08
PE
98162011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9817
9818 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9819
94515237
JB
98202011-06-27 Juanma Barranquero <lekktu@gmail.com>
9821
9822 * makefile.w32-in: Redesign dependencies so they reflect more
9823 clearly which files are directly included by each source file,
9824 and not through other includes.
9825
e43b6e43
MR
98262011-06-27 Martin Rudalics <rudalics@gmx.at>
9827
9828 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9829 (sort_overlays, overlay_strings): When an overlay's clone number
9830 matches the window's clone number process the overlay even if
9831 the overlay's window property doesn't match the current window.
9832
d68443dc
MR
9833 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9834 (Fwindow_hchild): Rename to Fwindow_left_child.
9835 (Fwindow_next): Rename to Fwindow_next_sibling.
9836 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9837 (resize_window_check): Rename to window_resize_check.
9838 (resize_window_apply): Rename to window_resize_apply.
9839 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9840 (Fdelete_other_windows_internal, resize_frame_windows)
9841 (Fsplit_window_internal, Fdelete_window_internal)
9842 (grow_mini_window, shrink_mini_window)
9843 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9844
c7e73be5
JD
98452011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9846
9847 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9848 (emacs_fixed_set_min_size): Remove.
9849 (emacs_fixed_new): Take frame as argument.
9850
9851 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9852 (_EmacsFixedPrivate): Remove minwidth/height.
9853 Add struct frame *f.
9854 (emacs_fixed_init): Initialize priv->f.
9855 (get_parent_class, emacs_fixed_set_min_size): Remove.
9856 (emacs_fixed_new): Set priv->f to argument.
9857 (emacs_fixed_get_preferred_width)
9858 (emacs_fixed_get_preferred_height): Use min_width/height from
9859 frames size_hint to set minimum and natural (Bug#8919).
9860 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9861 and use min_width/height from frames size_hint to set
9862 min_width/height (Bug#8919).
9863
9864 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9865 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9866 Fix indentation.
c7e73be5 9867
cf99dcf8
EZ
98682011-06-26 Eli Zaretskii <eliz@gnu.org>
9869
9870 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9871 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9872 called at ZV.
9873
029529ac
CY
98742011-06-26 Chong Yidong <cyd@stupidchicken.com>
9875
9876 * process.c (wait_reading_process_output): Bypass select if
9877 waiting for a cell while ignoring keyboard input, and input is
9878 pending. Suggested by Jan Djärv (Bug#8869).
9879
7a7ef429
PE
98802011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9881
9882 Use gnulib's dup2 module instead of rolling our own.
9883 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9884
11fdef7d 98852011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9886
9887 * dispnew.c (scrolling_window): Before scrolling, turn off a
9888 mouse-highlight in the window being scrolled.
9889
cd3520a4
JB
98902011-06-24 Juanma Barranquero <lekktu@gmail.com>
9891
9892 Move DEFSYM to lisp.h and use everywhere.
9893
9894 * character.h (DEFSYM): Move declaration...
9895 * lisp.h (DEFSYM): ...here.
9896
9897 * gnutls.c:
9898 * minibuf.c:
9899 * w32menu.c:
9900 * w32proc.c:
9901 * w32select.c: Don't include character.h.
9902
9903 * alloc.c (syms_of_alloc):
9904 * buffer.c (syms_of_buffer):
9905 * bytecode.c (syms_of_bytecode):
9906 * callint.c (syms_of_callint):
9907 * casefiddle.c (syms_of_casefiddle):
9908 * casetab.c (init_casetab_once):
9909 * category.c (init_category_once, syms_of_category):
9910 * ccl.c (syms_of_ccl):
9911 * cmds.c (syms_of_cmds):
9912 * composite.c (syms_of_composite):
9913 * dbusbind.c (syms_of_dbusbind):
9914 * dired.c (syms_of_dired):
9915 * dispnew.c (syms_of_display):
9916 * doc.c (syms_of_doc):
9917 * editfns.c (syms_of_editfns):
9918 * emacs.c (syms_of_emacs):
9919 * eval.c (syms_of_eval):
9920 * fileio.c (syms_of_fileio):
9921 * fns.c (syms_of_fns):
9922 * frame.c (syms_of_frame):
9923 * fringe.c (syms_of_fringe):
9924 * insdel.c (syms_of_insdel):
9925 * keymap.c (syms_of_keymap):
9926 * lread.c (init_obarray, syms_of_lread):
9927 * macros.c (syms_of_macros):
9928 * msdos.c (syms_of_msdos):
9929 * print.c (syms_of_print):
9930 * process.c (syms_of_process):
9931 * search.c (syms_of_search):
9932 * sound.c (syms_of_sound):
9933 * syntax.c (init_syntax_once, syms_of_syntax):
9934 * terminal.c (syms_of_terminal):
9935 * textprop.c (syms_of_textprop):
9936 * undo.c (syms_of_undo):
9937 * w32.c (globals_of_w32):
9938 * window.c (syms_of_window):
9939 * xdisp.c (syms_of_xdisp):
9940 * xfaces.c (syms_of_xfaces):
9941 * xfns.c (syms_of_xfns):
9942 * xmenu.c (syms_of_xmenu):
9943 * xsettings.c (syms_of_xsettings):
9944 * xterm.c (syms_of_xterm): Use DEFSYM.
9945
4228cf16
TZ
99462011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9947
cd3520a4 9948 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9949
7fcccf1e
PE
99502011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9951
7efb4e0e
PE
9952 Integer and buffer overflow fixes (Bug#8873).
9953
ff5844ad
PE
9954 * print.c (printchar, strout): Check for string overflow.
9955 (PRINTPREPARE, printchar, strout):
9956 Don't set size unless allocation succeeds.
9957
90532f02
PE
9958 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9959 for sizes. Check for string overflow more accurately.
9960 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9961
6d84508d
PE
9962 * macros.c: Integer and buffer overflow fixes.
9963 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9964 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9965 Use ptrdiff_t, not int, for sizes.
9966 Don't increment bufsize until after realloc succeeds.
9967 Check for size-calculation overflow.
9968 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9969
437b2cb4
PE
9970 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9971
8b9ac8b4
PE
9972 * lread.c: Integer overflow fixes.
9973 (read_integer): Radix is now EMACS_INT, not int,
9974 to improve quality of diagnostics for out-of-range radices.
9975 Calculate buffer size correctly for out-of-range radices.
9976 (read1): Check for integer overflow in radices, and in
9977 read-circle numbers.
82cb60d3
PE
9978 (read_escape): Avoid int overflow.
9979 (Fload, openp, read_buffer_size, read1)
9980 (substitute_object_recurse, read_vector, read_list, map_obarray):
9981 Use ptrdiff_t, not int, for sizes.
9982 (read1): Use EMACS_INT, not int, for sizes.
20270765 9983 Check for size overflow.
8b9ac8b4 9984
7fcccf1e
PE
9985 * image.c (cache_image): Check for size arithmetic overflow.
9986
bfbbd7e7
PE
9987 * lread.c: Integer overflow issues.
9988 (saved_doc_string_size, saved_doc_string_length)
9989 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9990 Now ptrdiff_t, not int.
9991 (read1): Don't assume doc string length fits in int. Check for
9992 out-of-range doc string lengths.
9993 (read_list): Don't assume file position fits in int.
39019e54 9994 (read_escape): Check for hex character overflow.
bfbbd7e7 9995
4e323265
LL
99962011-06-22 Leo Liu <sdl.web@gmail.com>
9997
9998 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9999 Move to minibuffer.el.
10000
85fece3e
PE
100012011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10002
20b84ce9 10003 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10004 The following patches are for when GLYPH_DEBUG && !XASSERT.
10005 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10006 * dispnew.c (flush_stdout):
10007 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10008 Mark as externally visible.
10009 * dispnew.c (check_window_matrix_pointers): Now static.
10010 * dispnew.c (window_to_frame_vpos):
10011 * xfns.c (unwind_create_frame):
10012 * xterm.c (x_check_font): Remove unused local.
10013 * scroll.c (CHECK_BOUNDS):
10014 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10015 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10016 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10017 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10018 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10019 Now static.
10020 (debug_method_add): Use va_list and vsprintf rather than relying
10021 on undefined behavior with wrong number of arguments.
10022 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10023 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10024 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10025 since we're not interested in debugging glyphs with old libraries.
10026 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10027 GCC 4.6.0's static checking.
10028
0766b489
PE
100292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10030
31fd4b32
PE
10031 Integer overflow and signedness fixes (Bug#8873).
10032 A few related buffer overrun fixes, too.
10033
b79e8648
PE
10034 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10035
0766b489
PE
10036 * dispextern.h (struct face.stipple):
10037 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10038 (x_bitmap_mask, x_allocate_bitmap_record)
10039 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10040 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10041 (x_create_bitmap_from_xpm_data):
10042 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10043 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10044 (.bitmaps_last):
10045 * xfaces.c (load_pixmap):
10046 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10047 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10048 (.bitmaps_last, struct x_output.icon_bitmap):
10049 Use ptrdiff_t, not int, for bitmap indexes.
10050 (x_allocate_bitmap_record): Check for size overflow.
10051 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10052
b081724f
PE
10053 Use ptrdiff_t, not int, for overlay counts.
10054 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10055 * editfns.c (overlays_around, get_pos_property):
10056 * textprop.c (get_char_property_and_overlay):
10057 * xdisp.c (next_overlay_change, note_mouse_highlight):
10058 * xfaces.c (face_at_buffer_position):
21514da7
PE
10059 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10060 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10061 (Fnext_overlay_change, Fprevious_overlay_change)
10062 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10063 Use ptrdiff_t, not int, for sizes.
21514da7 10064 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10065
3de73e5e
PE
10066 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10067
2606c57b
PE
10068 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10069 (x_session_initialize): Do not assume string length fits in int.
10070
aaafe47a
PE
10071 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10072 This is unlikely, but can occur if DPI is outlandish.
10073
2674ddc8 10074 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10075 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10076
28154962
PE
10077 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10078 * xrdb.c (magic_file_p, search_magic_path):
10079 Omit last arg SUFFIX; it was always 0. All callers changed.
10080 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10081
7de51af5
PE
10082 * xfont.c (xfont_match): Avoid need for strlen.
10083
25ed6cc3
PE
10084 * xfns.c: Don't assume strlen fits in int.
10085 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10086
4eab31dd
PE
10087 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10088 not unsigned long, as we prefer signed integers. All callers changed.
10089 Detect integer overflow in repeat count.
10090 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10091 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10092
171e2a58
PE
10093 * termcap.c: Don't assume sizes fit in int and never overflow.
10094 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10095 (gobble_line): Check for size-calculation overflow.
10096
ad39faca 10097 * minibuf.c (Fread_buffer):
6e5bb2dc 10098 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10099 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10100 Don't assume string length fits in int.
10101
52c61c22 10102 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10103 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10104
b5b8c9e5
PE
10105 * font.c: Don't assume string length fits in int.
10106 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10107 Use ptrdiff_t, not int.
ccd6111c
PE
10108 (font_intern_prop): Don't assume string length fits in int.
10109 Don't assume integer property fits in fixnum.
10110 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10111
882f0d81 10112 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10113 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10114 Reformulate so as not to need the command string.
10115 Invoke gzip -cd rather than gunzip, as it's more portable.
10116 (lock_info_type, lock_file_1, lock_file):
10117 Don't assume pid_t and time_t fit in unsigned long.
10118 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10119 (current_lock_owner): Prefer signed type for sizes.
10120 Use memcpy, not strncpy, where memcpy is what is really wanted.
10121 Don't assume (via atoi) that time_t and pid_t fit in int.
10122 Check for time_t and/or pid_t out of range, e.g., via a network share.
10123 Don't alloca where an auto var works fine.
10124
93f4cf88
PE
10125 * fileio.c: Fix some integer overflow issues.
10126 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10127 Don't assume string length fits in int.
10128 (directory_file_name): Don't assume string length fits in long.
10129 (make_temp_name): Don't assume pid fits in int, or that its print
10130 length is less than 20.
10131
f3e92b69
PE
10132 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10133
1bfdaf10
PE
10134 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10135
35016e9a
PE
10136 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10137
3d1e65a1
PE
10138 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10139 We prefer signed integers, even for size calculations.
10140
0b963a93
PE
10141 * emacs.c: Don't assume string length fits in 'int'.
10142 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10143 (main): Don't invoke strlen when not needed.
10144
573f4b54
PE
10145 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10146 (XD_DEBUG_MESSAGE): Don't waste a byte.
10147
989f33ba
PE
10148 * callproc.c (getenv_internal_1, getenv_internal)
10149 (Fgetenv_internal):
965d34eb
PE
10150 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10151
e4d29b33
PE
10152 * lread.c (invalid_syntax): Omit length argument.
10153 All uses changed. This doesn't fix a bug, but it simplifies the
10154 code away from its former Hollerith-constant appearance, and it's
10155 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10156 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10157
eb49b136
PE
10158 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10159 This didn't break anything, but it didn't help either.
10160 It's confusing to put a bogus integer in a place where the actual
10161 value does not matter.
9f62aeb1 10162 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10163 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10164
15375a22
PE
10165 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10166 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10167 implementation.
b61cc01c
PE
10168 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10169 We prefer signed types, and the value cannot exceed the EMACS_INT
10170 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10171 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10172 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10173 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10174
53b2623d
PE
10175 * indent.c (sane_tab_width): New function.
10176 (current_column, scan_for_column, Findent_to, position_indentation)
10177 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10178 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10179
51cab52b 10180 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10181
f2ed8a70
PE
10182 * lisp.h (lint_assume): New macro.
10183 * composite.c (composition_gstring_put_cache):
10184 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10185
abe80cc6
PE
10186 * editfns.c, insdel.c:
10187 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10188
b02c740e
PE
10189 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10190
ebc96716
PE
10191 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10192
b4e50fa0 10193 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10194 Use much-faster test for byte-length change.
311d5d7c 10195 Don't assume string byte-length fits in 'int'.
a4cf38e4 10196 Check that character arg fits in 'int'.
85461888 10197 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10198
c0c1ee9f
PE
10199 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10200
a498d7f4
PE
10201 * fns.c (concat): Catch string overflow earlier.
10202 Do not rely on integer wraparound.
10203
51cab52b
PE
10204 * dispextern.h (struct it.overlay_strings_charpos)
10205 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10206 * xdisp.c (forward_to_next_line_start)
10207 (back_to_previous_visible_line_start)
10208 (reseat_at_next_visible_line_start, next_element_from_buffer):
10209 Don't arbitrarily truncate the value of 'selective' to int.
10210
76031fad
PE
10211 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10212
5eb55db9
PE
10213 * composite.c: Don't truncate sizes to 'int'.
10214 (composition_gstring_p, composition_reseat_it)
10215 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10216 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10217 not EMACS_UINT, for indexes.
5eb55db9 10218
0703a717
PE
10219 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10220
d6202519
PE
10221 * buffer.c: Include <verify.h>.
10222 (struct sortvec.priority, struct sortstr.priority):
8961a454 10223 Now EMACS_INT, not int.
c20998a7 10224 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10225 (struct sortstr.size, record_overlay_string)
10226 (struct sortstrlist.size, struct sortlist.used):
10227 Don't truncate size to int.
10228 (record_overlay_string): Check for size-calculation overflow.
d6202519 10229 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10230
d5a19415
JM
102312011-06-22 Jim Meyering <meyering@redhat.com>
10232
029529ac 10233 Don't leak an XBM-image-sized buffer
d5a19415
JM
10234 * image.c (xbm_load): Free the image buffer after using it.
10235
a9041e6c
PE
102362011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10237
10238 Port to Sun C.
10239 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10240 that Sun C diagnosed.
10241 * fns.c (secure_hash): Fix pointer signedness issue.
10242 * intervals.c (static_offset_intervals): New function.
10243 (offset_intervals): Use it.
10244
7f3f739f
LL
102452011-06-21 Leo Liu <sdl.web@gmail.com>
10246
10247 * deps.mk (fns.o):
10248 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10249 sha512.h.
10250
10251 * fns.c (secure_hash): Rename from crypto_hash_function and change
10252 the first arg to accept symbols.
5b66d427 10253 (Fsecure_hash): New primitive.
7f3f739f
LL
10254 (syms_of_fns): New symbols.
10255
76147d94
DD
102562011-06-20 Deniz Dogan <deniz@dogan.se>
10257
10258 * process.c (Fset_process_buffer): Clarify return value in
10259 docstring.
10260
7d7d0045
CY
102612011-06-18 Chong Yidong <cyd@stupidchicken.com>
10262
10263 * dispnew.c (add_window_display_history): Use BVAR.
10264
10265 * xdisp.c (debug_method_add): Use BVAR.
10266 (check_window_end, dump_glyph_matrix, dump_glyph)
10267 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10268
10269 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10270 Likewise.
10271
10272 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10273 check till after the cache is created in init_frame_faces.
10274
ff2bc410
SM
102752011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10276
10277 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10278
28177add
PE
102792011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10280
dd3482fe
PE
10281 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10282 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10283 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10284
393d71f3 10285 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10286 * fileio.c (Finsert_file_contents):
10287 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10288 Remove the old (too-loose) buffer overflow checks.
10289 They weren't needed, since make_gap checks for buffer overflow.
10290 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10291 The old code merely checked for Emacs fixnum overflow, and relied
10292 on undefined (wraparound) behavior. The new code avoids undefined
10293 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10294
2e6813b0 10295 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10296 Tune. Don't use wider integers than needed. Don't use alloca.
10297 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10298
599a9e4f
PE
10299 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10300
99561444
PE
10301 * insdel.c, lisp.h (buffer_overflow): New function.
10302 (insert_from_buffer_1, replace_range, replace_range_2):
10303 * insdel.c (make_gap_larger):
10304 * editfns.c (Finsert_char):
10305 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10306
28177add
PE
10307 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10308
e69dafad
PE
103092011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10310
4baa020d 10311 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10312
b1c46f02
PE
10313 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10314 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10315
e69dafad
PE
10316 * fileio.c: Don't assume EMACS_INT fits in off_t.
10317 (emacs_lseek): New static function.
10318 (Finsert_file_contents, Fwrite_region): Use it.
10319 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10320
566684ea
PE
10321 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10322
e6966cd6
PE
10323 * fns.c: Don't overflow int when computing a list length.
10324 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10325 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10326 truncation on 64-bit hosts. Check for QUIT every
10327 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10328 faster and is responsive enough.
10329 (Flength): Report an error instead of overflowing an integer.
10330 (Fsafe_length): Return a float if the value is not representable
10331 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10332 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10333 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10334
dd0b0efb
PE
10335 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10336 (header_size, word_size): New constants.
10337 (allocate_vectorlike): Don't check size overflow here.
10338 (allocate_vector): Check it here instead, since this is the only
10339 caller of allocate_vectorlike that could cause overflow.
10340 Check that the new vector's length is representable as a fixnum.
10341
86fe5cfe
PE
10342 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10343 The previous code was bogus. For example, next_almost_prime (32)
10344 returned 39, which is undesirable as it is a multiple of 3; and
10345 next_almost_prime (24) returned 25, which is a multiple of 5 so
10346 why was the code bothering to check for multiples of 7?
10347
80e88859
PE
10348 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10349
4a2f0ad6
PE
10350 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10351
f66c7cf8
PE
10352 Variadic C functions now count arguments with ptrdiff_t.
10353 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10354 Back then I didn't know that the Emacs coding style prefers signed int.
10355 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10356 were being counted with int, which may truncate counts on 64-bit
10357 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10358 * lisp.h (struct Lisp_Subr.function.aMANY)
10359 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10360 Arg counts are now ptrdiff_t, not size_t.
10361 All variadic functions and their callers changed accordingly.
10362 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10363 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10364 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10365 * callint.c (Fcall_interactively): Check arg count for overflow,
10366 to avoid potential buffer overrun. Use signed char, not 'int',
10367 for 'varies' array, so that we needn't bother to check its size
10368 calculation for overflow.
10369 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10370 * eval.c (apply_lambda):
10371 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10372 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10373 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10374
a1759b76
PE
10375 * callint.c (Fcall_interactively): Don't use index var as event count.
10376
d96be9fc
PE
10377 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10378 * mem-limits.h (SIZE): Remove; no longer used.
10379
a690a978 10380 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10381
578c21e6
PE
10382 Remove unnecessary casts.
10383 * xterm.c (x_term_init):
10384 * xfns.c (x_set_border_pixel):
10385 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10386 These aren't needed now that we assume ANSI C.
10387
96f53c6c
PE
10388 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10389 It's more likely to cause problems (due to unsigned overflow)
10390 than to cure them.
10391
83c77d31
PE
10392 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10393
ee2079f1
PE
10394 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10395
6da65536
PE
10396 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10397
7147c4a4
PE
10398 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10399
193e32d9
PE
10400 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10401
e5533da6
PE
10402 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10403
9910e595
PE
10404 GLYPH_CODE_FACE returns EMACS_INT, not int.
10405 * dispextern.h (merge_faces):
10406 * xfaces.c (merge_faces):
01103c44
PE
10407 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10408 Don't assume EMACS_INT fits in int.
9910e595 10409
2638320e
PE
10410 * character.h (CHAR_VALID_P): Remove unused parameter.
10411 * fontset.c, lisp.h, xdisp.c: All uses changed.
10412
045eb8d9
PE
10413 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10414
c1f134b5
PE
10415 * fns.c (concat): Minor tuning based on overflow analysis.
10416 This doesn't fix any bugs. Use int to hold character, instead
10417 of constantly refetching from Emacs object. Use XFASTINT, not
10418 XINT, for value known to be a character. Don't bother comparing
10419 a single byte to 0400, as it's always less.
10420
395fcb93 10421 * floatfns.c (Fexpt):
327eeec8
PE
10422 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10423
abbd3d23
PE
10424 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10425 for characters.
10426
684a03ef
PE
10427 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10428
0fed43f3
PE
10429 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10430 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10431 incorrectly succeed when S was a string, because 4294967386 was
10432 truncated before it was used.
10433
8fd02eb7
PE
10434 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10435 Otherwise, an out-of-range integer could cause undefined behavior
10436 on a 64-bit host.
10437
f8c86b69
PE
10438 * composite.c: Use int, not EMACS_INT, for characters.
10439 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10440 EMACS_INT, for values that are known to be in character range.
10441 This doesn't fix any bugs but is the usual style inside Emacs and
10442 may generate better code on 32-bit machines.
10443
34206dd2
PE
10444 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10445 This is for reasons similar to the recent CHAR_STRING fix.
10446 * charset.c (Fencode_char): Check that character arg is actually
10447 a character. Pass an int to ENCODE_CHAR.
10448 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10449 wider than 'int', as a compile-time check to prevent future regressions
10450 in this area.
10451
c5958d4c 10452 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10453
10454 Make sure a 64-bit char is never passed to CHAR_STRING.
10455 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10456 by silently ignoring the top 32 bits, allowing some values
10457 that were far too large to be valid characters.
10458 * character.h: Include <verify.h>.
10459 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10460 arguments are no wider than unsigned, as a compile-time check
10461 to prevent future regressions in this area.
10462 * data.c (Faset):
01103c44 10463 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10464 (Fsubst_char_in_region):
10465 * fns.c (concat):
10466 * xdisp.c (decode_mode_spec_coding):
10467 Adjust to CHAR_STRING's new requirement.
10468 * editfns.c (Finsert_char, Fsubst_char_in_region):
10469 * fns.c (concat): Check that character args are actually
10470 characters. Without this test, these functions did the wrong
10471 thing with wildly out-of-range values on 64-bit hosts.
10472
d37ca623
PE
10473 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10474 These casts should not be needed on 32-bit hosts, either.
10475 * keyboard.c (read_char):
10476 * lread.c (Fload): Remove casts to unsigned.
10477
ea204efb
PE
10478 * lisp.h (UNSIGNED_CMP): New macro.
10479 This fixes comparison bugs on 64-bit hosts.
10480 (ASCII_CHAR_P): Use it.
10481 * casefiddle.c (casify_object):
01103c44 10482 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10483 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10484 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10485 * dispextern.h (FACE_FROM_ID):
10486 * keyboard.c (read_char): Use UNSIGNED_CMP.
10487
41cb286c
PE
10488 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10489 not to EMACS_INT, to avoid GCC warning.
10490
4a1b9832
PE
10491 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10492
55daad71
PE
10493 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10494 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10495 isn't needed on 32-bit machines.
8f95c75c 10496
01103c44
PE
10497 * buffer.c (Fgenerate_new_buffer_name):
10498 Use EMACS_INT for count, not int.
0ceccced 10499 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10500
10501 * data.c (Qcompiled_function): Now static.
10502
c6f072e7
PE
10503 * window.c (window_body_lines): Now static.
10504
20ce5912
PE
10505 * image.c (gif_load): Rename local to avoid shadowing.
10506
9c4c5f81
PE
10507 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10508 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10509 * alloc.c (make_save_value): Integer argument is now of type
10510 ptrdiff_t, not int.
10511 (mark_object): Use ptrdiff_t, not int.
10512 * lisp.h (pD): New macro.
10513 * print.c (print_object): Use it.
10514
c0c5c8ae
PE
10515 * alloc.c: Use EMACS_INT, not int, to count objects.
10516 (total_conses, total_markers, total_symbols, total_vector_size)
10517 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10518 (total_free_floats, total_floats, total_free_intervals)
10519 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10520 Now EMACS_INT, not int. All uses changed.
10521 (Fgarbage_collect): Compute overall total using a double, so that
10522 integer overflow is less likely to be a problem. Check for overflow
10523 when converting back to an integer.
5a25e253
PE
10524 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10525 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10526 These were 'int' variables that could overflow on 64-bit hosts;
10527 they were never used, so remove them instead of repairing them.
211a0b2a 10528 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10529 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10530 Previously, this ceilinged at INT_MAX, but that doesn't work on
10531 64-bit machines.
e46bb31a 10532 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10533
c78baabf 10534 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10535 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10536 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10537 when a (possibly-narrower) signed value would do just as well.
10538 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10539
c9d624c6
PE
10540 * alloc.c: Catch some string size overflows that we were missing.
10541 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10542 for convenience in STRING_BYTES_MAX.
10543 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10544 The definition here is exact; the one in lisp.h was approximate.
10545 (allocate_string_data): Check for string overflow. This catches
10546 some instances we weren't catching before. Also, it catches
10547 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10548 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10549 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10550
c9d624c6
PE
10551 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10552 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10553 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10554
353032ce
PE
10555 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10556
2bccce07
PE
10557 * alloc.c (Fmake_string): Check for out-of-range init.
10558
0ac30604
SM
105592011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10560
10561 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10562
c195f2de
JD
105632011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10564
10565 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10566 xg_get_default_scrollbar_width.
10567
10568 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10569 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10570 (style_changed_cb): Call update_theme_scrollbar_width and call
10571 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10572 all frames (Bug#8505).
10573 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10574 Call gtk_window_set_resizable if HAVE_GTK3.
10575 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10576 and height if HAVE_GTK3 (Bug#8505).
10577 (scroll_bar_width_for_theme): New variable.
10578 (update_theme_scrollbar_width): New function.
10579 (xg_get_default_scrollbar_width): Move code to
10580 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10581 (xg_initialize): Call update_theme_scrollbar_width.
10582
10583 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10584
10585 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10586
e10ac9f1
MR
105872011-06-12 Martin Rudalics <rudalics@gmx.at>
10588
10589 * frame.c (make_frame): Call other_buffer_safely instead of
10590 other_buffer.
10591
10592 * window.c (temp_output_buffer_show): Call display_buffer with
10593 second argument Vtemp_buffer_show_specifiers and reset latter
10594 immediately after the call.
10595 (Vtemp_buffer_show_specifiers): New variable.
10596 (auto_window_vscroll_p, next_screen_context_lines)
10597 (Vscroll_preserve_screen_position): Remove leading asterisks from
10598 doc-strings.
10599
2d3c217e 106002011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10601
7b7f97e8 10602 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10603 * buffer.c (Qclone_number): Remove for now, as it's unused.
10604 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10605 (record_buffer): Remove unused local.
10606 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10607 (set_frame_buffer_list): Remove; unused.
10608 * frame.h (other_visible_frames): Remove decl.
10609 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10610 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10611 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10612 if HAVE_GPM.
10613 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10614 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10615 Define only if HAVE_GPM.
10616 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10617 (update_hints_inhibit): Remove; never set. All uses removed.
10618 * widgetprv.h (emacsFrameClassRec): Remove decl.
10619 * window.c (delete_deletable_window): Now returns void, since it
10620 wasn't returning anything.
10621 (compare_window_configurations): Remove unused locals.
10622 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10623 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10624 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10625 the same widths as pointers. This follows up on the 2011-05-06 patch.
10626 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10627 * xterm.h: Likewise.
10628 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10629
1384b89e
JB
106302011-06-12 Juanma Barranquero <lekktu@gmail.com>
10631
10632 * makefile.w32-in: Update dependencies.
10633 (LISP_H): Add lib/intprops.h.
10634
1100a63c
CY
106352011-06-11 Chong Yidong <cyd@stupidchicken.com>
10636
10637 * image.c (gif_load): Add animation frame delay to the metadata.
10638 (syms_of_image): Use DEFSYM. New symbol `delay'.
10639
6198ccd0
MR
106402011-06-11 Martin Rudalics <rudalics@gmx.at>
10641
10642 * window.c (delete_deletable_window): Re-add.
10643 (Fset_window_configuration): Rewrite to handle dead buffers and
10644 consequently deletable windows.
10645 (window_tree, Fwindow_tree): Remove. Supply functionality in
10646 window.el.
10647 (compare_window_configurations): Simplify code.
10648
b6e3633c
AS
106492011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10650
1ab0dee5
AS
10651 * image.c (imagemagick_load_image): Fix type mismatch.
10652 (Fimagemagick_types): Likewise.
10653
b6e3633c
AS
10654 * window.h (replace_buffer_in_windows): Declare.
10655
9397e56f
MR
106562011-06-11 Martin Rudalics <rudalics@gmx.at>
10657
10658 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10659 Qclone_number. Remove external declaration of Qdelete_window.
10660 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10661 code.
640c8776
SM
10662 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10663 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10664 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10665 buffer list implementation.
10666 (other_buffer_safely): New function.
10667 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10668 calls to replace_buffer_in_windows and
10669 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10670 if allowed.
10671 (record_buffer): Inhibit quitting and rewrite using quittable
10672 functions. Run Qbuffer_list_update_hook if allowed.
10673 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10674 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10675 Move switch-to-buffer to window.el.
9397e56f
MR
10676 (bury-buffer): Move to window.el.
10677 (Vbuffer_list_update_hook): New variable.
10678
10679 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10680 section.
10681
10682 * window.h (resize_frame_windows): Move up in code.
10683 (Fwindow_frame): Remove EXFUN.
10684 (replace_buffer_in_all_windows): Remove prototype.
10685 (replace_buffer_in_windows_safely): Add prototype.
10686
10687 * window.c: Declare Qdelete_window static again. Move down
10688 declaration of select_count.
10689 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10690 (Fother_window): Move to window.el.
10691 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10692 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10693 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10694 window.el.
10695 (replace_buffer_in_windows): Implement by calling
10696 Qreplace_buffer_in_windows.
10697 (replace_buffer_in_all_windows): Remove with some functionality
10698 moved into replace_buffer_in_windows_safely.
10699 (replace_buffer_in_windows_safely): New function.
10700 (select_window_norecord, select_frame_norecord): Move in front
10701 of run_window_configuration_change_hook. Remove now obsolete
10702 declarations.
640c8776
SM
10703 (Fset_window_buffer): Rewrite doc-string.
10704 Call Qrecord_window_buffer.
9397e56f
MR
10705 (keys_of_window): Move binding for other-window to window.el.
10706
b50691aa
CY
107072011-06-11 Chong Yidong <cyd@stupidchicken.com>
10708
10709 * dispextern.h (struct image): Replace data member, whose int_val
10710 and ptr_val fields were not used by anything, with a single
10711 lisp_val object.
10712
10713 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10714 (gif_clear_image, gif_load, imagemagick_load_image)
10715 (gs_clear_image, gs_load): Callers changed.
10716
3f754b86
PE
107172011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10718
cca69397
PE
10719 * buffer.h: Include <time.h>, for time_t.
10720 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10721
109e28d0
PE
10722 Fix minor problems found by static checking.
10723
60737f02
PE
10724 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10725
4b66faf3
PE
10726 Make identifiers static if they are not used in other modules.
10727 * data.c (Qcompiled_function, Qframe, Qvector):
10728 * image.c (QimageMagick, Qsvg):
10729 * minibuf.c (Qmetadata):
10730 * window.c (resize_window_check, resize_root_window): Now static.
10731 * window.h (resize_window_check, resize_root_window): Remove decls.
10732
109e28d0
PE
10733 * window.c (window_deletion_count, delete_deletable_window):
10734 Remove; unused.
46a4ce9e
PE
10735 (window_body_lines): Now static.
10736 (Fdelete_other_windows_internal): Mark vars as initialized.
10737 Make sure 'resize_failed' is initialized.
10738 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10739 (resize_window_apply): Remove unused local.
10740 * window.h (delete_deletable_window): Remove decl.
10741
109e28d0 10742 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10743 (imagemagick_load_image): Fix pointer signedness problem by changing
10744 last arg from unsigned char * to char *. All uses changed.
10745 Also, fix a local for similar reasons.
10746 Remove unused locals. Remove locals to avoid shadowing.
10747 (fn_rsvg_handle_free): Remove; unused.
10748 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10749 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10750
3f754b86
PE
10751 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10752
2547adb1
CY
107532011-06-10 Chong Yidong <cyd@stupidchicken.com>
10754
10755 * image.c (gif_load): Fix omitted cast error introduced by
10756 2011-06-06 change.
10757
2c8e37d4
MR
107582011-06-10 Martin Rudalics <rudalics@gmx.at>
10759
10760 * window.h (resize_proportionally, orig_total_lines)
10761 (orig_top_line): Remove from window structure.
10762 (set_window_height, set_window_width, change_window_heights)
10763 (Fdelete_window): Remove prototypes.
10764 (resize_frame_windows): Remove duplicate declaration.
10765
440a42e3
EZ
107662011-06-10 Eli Zaretskii <eliz@gnu.org>
10767
10768 * window.h (resize_frame_windows, resize_window_check)
10769 (delete_deletable_window, resize_root_window)
10770 (resize_frame_windows): Declare prototypes.
10771
10772 * window.c (resize_window_apply): Make definition be "static" to
10773 match the prototype.
10774
562dd5e9
MR
107752011-06-10 Martin Rudalics <rudalics@gmx.at>
10776
10777 * window.c: Remove declarations of Qwindow_size_fixed,
10778 window_min_size_1, window_min_size_2, window_min_size,
10779 size_window, window_fixed_size_p, enlarge_window, delete_window.
10780 Remove static from declaration of Qdelete_window, it's
10781 temporarily needed by Fbury_buffer.
10782 (replace_window): Don't assign orig_top_line and
10783 orig_total_lines.
10784 (Fdelete_window, delete_window): Remove. Window deletion is
10785 handled by window.el.
640c8776
SM
10786 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10787 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10788 (Fdelete_other_windows): Remove. Deleting other windows is
10789 handled by window.el.
10790 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10791 handled in window.el.
10792 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10793 Window minimum sizes are handled in window.el.
10794 (shrink_windows, size_window, set_window_height)
10795 (set_window_width, change_window_heights, window_height)
10796 (window_width, CURBEG, CURSIZE, enlarge_window)
10797 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10798 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10799 handled in window.el.
10800 (make_dummy_parent): Rename to make_parent_window and give it a
10801 second argument horflag.
10802 (make_window): Don't set resize_proportionally any more.
10803 (Fsplit_window): Remove. Windows are split in window.el.
10804 (save_restore_action, save_restore_orig_size)
10805 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10806 Resize mini windows in window.el.
10807 (grow_mini_window, shrink_mini_window): Implement by calling
10808 Qresize_root_window_vertically, resize_window_check and
10809 resize_window_apply.
640c8776
SM
10810 (saved_window, Fset_window_configuration, save_window_save):
10811 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10812 resize_proportionally.
10813 (window_min_height, window_min_width): Move to window.el.
10814 (keys_of_window): Move bindings for delete-other-windows,
10815 split-window, delete-window and enlarge-window to window.el.
10816
10817 * buffer.c: Temporarily extern Qdelete_window.
10818 (Fbury_buffer): Temporarily call Qdelete_window instead of
10819 Fdelete_window (Fbury_buffer will move to window.el soon).
10820
10821 * frame.c (set_menu_bar_lines_1): Remove code handling
10822 orig_top_line and orig_total_lines.
10823
10824 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10825 set_window_height but set heights directly.
10826 (change_frame_size_1): Use resize_frame_windows.
10827
10828 * xdisp.c (init_xdisp): Don't use set_window_height but set
10829 heights directly.
10830
640c8776
SM
10831 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10832 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10833 run_window_configuration_change_hook.
10834
10835 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10836 instead of change_window_heights and run
10837 run_window_configuration_change_hook.
10838
1a13852e
MR
108392011-06-09 Martin Rudalics <rudalics@gmx.at>
10840
10841 * window.c (replace_window): Rename second argument REPLACEMENT to
10842 NEW. New third argument SETFLAG. Rewrite.
10843 (delete_window, make_dummy_parent): Call replace_window with
10844 third argument 1.
10845 (window_list_1): Move down in code.
10846 (run_window_configuration_change_hook): Move set_buffer part
10847 before select_frame_norecord part in order to unwind correctly.
10848 Rename count1 to count.
10849 (recombine_windows, delete_deletable_window, resize_root_window)
10850 (Fdelete_other_windows_internal)
10851 (Frun_window_configuration_change_hook, make_parent_window)
10852 (resize_window_check, resize_window_apply, Fresize_window_apply)
10853 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10854 (Fdelete_window_internal, Fresize_mini_window_internal):
10855 New functions.
1a13852e
MR
10856 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10857
f3d1777e
MR
108582011-06-08 Martin Rudalics <rudalics@gmx.at>
10859
496e208e
MR
10860 * window.h (window): Add some new members to window structure -
10861 normal_lines, normal_cols, new_total, new_normal, clone_number,
10862 splits, nest, prev_buffers, next_buffers.
10863 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10864 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10865
f3d1777e
MR
10866 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10867 Remove.
496e208e
MR
10868 (make_dummy_parent): Set new members of windows structure.
10869 (make_window): Move down in code. Handle new members of window
10870 structure.
10871 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10872 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10873 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10874 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10875 (Fset_window_next_buffers, Fset_window_clone_number):
10876 New functions.
496e208e
MR
10877 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10878 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10879 Doc-string fixes.
10880 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10881 Argument WINDOW can be now internal window too.
10882 (Fwindow_use_time): Move up in code.
10883 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10884 Rewrite doc-string.
10885 (Fset_window_configuration, saved_window)
10886 (Fcurrent_window_configuration, save_window_save): Handle new
10887 members of window structure.
b9e809c2
MR
10888 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10889 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10890 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10891 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10892 Qget_mru_window, Qresize_root_window,
10893 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10894 Qauto_buffer_name; staticpro them.
f3d1777e 10895
abde8f8c
MR
108962011-06-07 Martin Rudalics <rudalics@gmx.at>
10897
10898 * window.c (Fwindow_total_size, Fwindow_left_column)
10899 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10900 (Fwindow_list_1): New functions.
10901 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10902 (Fwindow_width, Fscroll_left, Fscroll_right):
10903 Use window_body_cols instead of window_box_text_cols.
10904 (delete_window, Fset_window_configuration):
10905 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10906 (delete_all_subwindows): Take a window as argument and not a
10907 structure. Rewrite.
190b47e6
MR
10908 (window_loop): Remove handling of GET_LRU_WINDOW and
10909 GET_LARGEST_WINDOW.
10910 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10911
10912 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10913 window_box_text_cols. delete_all_subwindows now takes a
10914 Lisp_Object as argument.
abde8f8c 10915
640c8776
SM
10916 * indent.c (compute_motion, Fcompute_motion):
10917 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10918
fa8a67e6
MR
10919 * frame.c (delete_frame): Call delete_all_subwindows with root
10920 window as argument.
10921
a54e3482
DC
109222011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10923
10924 * fns.c (Fputhash): Document return value.
10925
60002bf5
CY
109262011-06-06 Chong Yidong <cyd@stupidchicken.com>
10927
10928 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10929
0c671da6 109302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10931
b862a52a 10932 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10933
be44ca6c
PE
10934 Check for overflow when converting integer to cons and back.
10935 * charset.c (Fdefine_charset_internal, Fdecode_char):
10936 Use cons_to_unsigned to catch overflow.
10937 (Fencode_char): Use INTEGER_TO_CONS.
10938 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10939 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10940 * data.c (long_to_cons, cons_to_long): Remove.
10941 (cons_to_unsigned, cons_to_signed): New functions.
10942 These signal an error for invalid or out-of-range values.
10943 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10944 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10945 * font.c (Ffont_variation_glyphs):
10946 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10947 * lisp.h: Include <intprops.h>.
10948 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10949 (cons_to_signed, cons_to_unsigned): New decls.
10950 (long_to_cons, cons_to_long): Remove decls.
10951 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10952 (Fprimitive_undo): Use CONS_TO_INTEGER.
10953 * xfns.c (Fx_window_property): Likewise.
10954 * xselect.c: Include <limits.h>.
10955 (x_own_selection, selection_data_to_lisp_data):
10956 Use INTEGER_TO_CONS.
10957 (x_handle_selection_request, x_handle_selection_clear)
10958 (x_get_foreign_selection, Fx_disown_selection_internal)
10959 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10960 (lisp_data_to_selection_data): Use cons_to_unsigned.
10961 (x_fill_property_data): Use cons_to_signed.
10962 Report values out of range.
10963
d1f3d2af
PE
10964 Check for buffer and string overflow more precisely.
10965 * buffer.h (BUF_BYTES_MAX): New macro.
10966 * lisp.h (STRING_BYTES_MAX): New macro.
10967 * alloc.c (Fmake_string):
10968 * character.c (string_escape_byte8):
10969 * coding.c (coding_alloc_by_realloc):
10970 * doprnt.c (doprnt):
10971 * editfns.c (Fformat):
10972 * eval.c (verror):
10973 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10974 since they may not be the same number.
10975 * editfns.c (Finsert_char):
10976 * fileio.c (Finsert_file_contents):
10977 Likewise for BUF_BYTES_MAX.
10978
dd52fcea
PE
10979 * image.c: Use ptrdiff_t, not int, for sizes.
10980 (slurp_file): Switch from int to ptrdiff_t.
10981 All uses changed.
10982 (slurp_file): Check that file size fits in both size_t (for
10983 malloc) and ptrdiff_t (for sanity and safety).
10984
7f9bbdbb
PE
10985 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10986 if b->modtime has its maximal value.
10987
dfe18f82
PE
10988 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10989
84acfcf0
PE
10990 Don't assume time_t can fit into int.
10991 * buffer.h (struct buffer.modtime): Now time_t, not int.
10992 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10993 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10994
ccd9a01a
PE
10995 Minor fixes for signed vs unsigned integers.
10996 * character.h (MAYBE_UNIFY_CHAR):
10997 * charset.c (maybe_unify_char):
10998 * keyboard.c (read_char, reorder_modifiers):
10999 XINT -> XFASTINT, since the integer must be nonnegative.
11000 * ftfont.c (ftfont_spec_pattern):
11001 * keymap.c (access_keymap, silly_event_symbol_error):
11002 XUINT -> XFASTINT, since the integer must be nonnegative.
11003 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11004 since it makes no difference and we prefer signed.
11005 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11006 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11007 nonnegative.
11008
d6d100dd
SM
110092011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11010
11011 * window.h (Fwindow_frame): Declare.
11012
2b6148e4
PE
110132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11014
11015 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11016 (SPARE_MEMORY): Always define.
11017 (LARGE_REQUEST): Remove.
11018 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11019
f230ecc9
MR
110202011-06-06 Martin Rudalics <rudalics@gmx.at>
11021
727e958e
MR
11022 * lisp.h: Move EXFUNS for Fframe_root_window,
11023 Fframe_first_window and Fset_frame_selected_window to window.h.
11024
11025 * window.h: Move EXFUNS for Fframe_root_window,
11026 Fframe_first_window and Fset_frame_selected_window here from
11027 lisp.h.
11028
11029 * frame.c (Fwindow_frame, Fframe_first_window)
11030 (Fframe_root_window, Fframe_selected_window)
11031 (Fset_frame_selected_window): Move to window.c.
11032 (Factive_minibuffer_window): Move to minibuf.c.
11033 (Fother_visible_frames_p): New function.
11034
11035 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11036
f230ecc9
MR
11037 * window.c (decode_window, decode_any_window): Move up in code.
11038 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11039 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11040 (Fwindow_buffer): Move up and rewrite doc-string.
11041 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11042 (Fwindow_prev): New functions.
727e958e
MR
11043 (Fwindow_frame): Move here from frame.c. Accept any window as
11044 argument.
11045 (Fframe_root_window, Fframe_first_window)
11046 (Fframe_selected_window): Move here from frame.c. Accept frame
11047 or arbitrary window as argument. Update doc-strings.
11048 (Fminibuffer_window): Move up in code.
11049 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11050 (Fset_frame_selected_window): Move here from frame.c.
11051 Marginal rewrite.
727e958e
MR
11052 (Fselected_window, select_window, Fselect_window): Move up in
11053 code. Minor doc-string fixes.
f230ecc9 11054
4d09bcf6
PE
110552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11056
11057 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11058 Do not assume that spare memory exists; that assumption is valid
11059 only if SYSTEM_MALLOC.
11060 (LARGE_REQUEST): New macro, so that the issue of large requests
11061 is separated from the issue of spare memory.
11062
810928a2
AS
110632011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11064
172418ad
AS
11065 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11066 format. (Bug#8806)
11067
43f862f7
AS
11068 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11069
810928a2
AS
11070 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11071 before statements.
11072
a059fe24
JD
110732011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11074
11075 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11076
11077 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11078
11079 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11080 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11081
989bf368
JB
110822011-06-05 Juanma Barranquero <lekktu@gmail.com>
11083
11084 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11085
4b80f674
CY
110862011-06-04 Chong Yidong <cyd@stupidchicken.com>
11087
11088 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11089 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11090 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11091 New error handlers.
4b80f674
CY
11092 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11093 Obey Vx_select_enable_clipboard_manager. Catch errors in
11094 x_clipboard_manager_save (Bug#8779).
11095 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11096 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11097
99a33b77 110982011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11099
11100 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11101
99a33b77 111022011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11103
11104 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11105 in the current matrix if keep_current_p is non-zero.
11106
8264569d
EZ
111072011-06-04 Eli Zaretskii <eliz@gnu.org>
11108
11109 * bidi.c (bidi_level_of_next_char): Fix last change.
11110
57f97249
EZ
111112011-06-03 Eli Zaretskii <eliz@gnu.org>
11112
fec2107c 11113 Support bidi reordering of text covered by display properties.
57f97249 11114
fec2107c
EZ
11115 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11116 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11117 (bidi_cache_search, bidi_cache_iterator_state)
11118 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11119 (bidi_level_of_next_char, bidi_move_to_visually_next):
11120 Support character positions inside a run of characters covered by a
fec2107c
EZ
11121 display string.
11122 (bidi_paragraph_init, bidi_resolve_explicit_1)
11123 (bidi_level_of_next_char): Call bidi_fetch_char and
11124 bidi_fetch_char_advance instead of FETCH_CHAR and
11125 FETCH_CHAR_ADVANCE.
11126 (bidi_init_it): Initialize new members.
11127 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11128 definitions.
11129 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11130 instead of using explicit *_CHAR codes.
d6d100dd
SM
11131 (bidi_resolve_explicit, bidi_resolve_weak):
11132 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11133 bidirectional text is supported only in multibyte buffers.
11134 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11135 it to initialize the frame_window_p member of struct bidi_it.
11136 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11137 (bidi_resolve_explicit, bidi_resolve_weak)
11138 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11139 bidi_it->nchars is non-positive.
11140 (bidi_level_of_next_char): Don't try to lookup the cache for the
11141 next/previous character if nothing is cached there yet, or if we
11142 were just reseat()'ed to a new position.
c40e2fb2 11143
0e14fe90
EZ
11144 * xdisp.c (set_cursor_from_row): Set start and stop points
11145 according to the row's direction when priming the loop that looks
11146 for the glyph on which to display cursor.
11147 (single_display_spec_intangible_p): Function deleted.
11148 (display_prop_intangible_p): Reimplement to call
11149 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11150 Accept 3 additional arguments needed by handle_display_spec.
11151 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11152 values: lists, `(when COND...)' forms, etc.
11153 (single_display_spec_string_p): Support property values that are
11154 lists with the argument STRING its top-level element.
11155 (display_prop_string_p): Fix the condition for processing a
11156 property that is a list to be consistent with handle_display_spec.
fec2107c 11157 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11158 last portion of handle_display_prop.
11159 (compute_display_string_pos): Accept additional argument
11160 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11161 value of a `display' property is a "replacing spec".
11162 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11163 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11164 the display property, but just return a value indicating whether
11165 the display property will replace the characters it covers.
11166 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11167 frame_window_p members of struct bidi_it.
d6d100dd
SM
11168 (compute_display_string_pos, compute_display_string_end):
11169 New functions.
fec2107c
EZ
11170 (push_it): Accept second argument POSITION, where pop_it should
11171 jump to continue iteration.
11172 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11173
fec2107c
EZ
11174 * keyboard.c (adjust_point_for_property): Adjust the call to
11175 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11176
11177 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11178 (bidi_init_it): Update prototypes.
11179 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11180 (compute_display_string_pos, compute_display_string_end):
11181 Declare prototypes.
fec2107c
EZ
11182 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11183 EMACS_INT.
fc6f18ce 11184
40087514 111852011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11186
57f53182
PE
11187 Malloc failure behavior now depends on size of allocation.
11188 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11189 * lisp.h: Change signatures accordingly.
11190 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11191 All callers changed. (Bug#8762)
11192
11193 * gnutls.c: Use Emacs's memory allocators.
11194 Without this change, the gnutls library would invoke malloc etc.
11195 directly, which causes problems on non-SYNC_INPUT hosts, and which
11196 runs afoul of improving memory_full behavior. (Bug#8761)
11197 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11198 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11199 xfree instead of the default malloc, realloc, free.
11200 (Fgnutls_boot): No need to check for memory allocation failure,
11201 since xmalloc does that for us.
11202
ac32cd99 11203 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11204 * category.c (hash_get_category_set):
11205 * ccl.c (ccl_driver):
11206 * charset.c (Fdefine_charset_internal):
11207 * charset.h (struct charset.hash_index):
11208 * composite.c (get_composition_id, gstring_lookup_cache)
11209 (composition_gstring_put_cache):
11210 * composite.h (struct composition.hash_index):
11211 * dispextern.h (struct image.hash):
11212 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11213 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11214 (hashfn_equal, hashfn_user_defined, make_hash_table)
11215 (maybe_resize_hash_table, hash_lookup, hash_put)
11216 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11217 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11218 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11219 * image.c (make_image, search_image_cache, lookup_image)
11220 (xpm_put_color_table_h):
11221 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11222 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11223 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11224 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11225 * alloc.c (allocate_vectorlike):
11226 Check for overflow in vector size calculations.
11227 * ccl.c (ccl_driver):
11228 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11229 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11230 need to be updated by these changes.
40087514
PE
11231 * fns.c (make_hash_table, maybe_resize_hash_table):
11232 Check for integer overflow with large hash tables.
0de4bb68
PE
11233 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11234 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11235 (SXHASH_REDUCE): New macro.
11236 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11237 Use it instead of discarding useful hash info with large hash values.
11238 (sxhash_float): New function.
11239 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11240 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11241 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11242 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11243 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11244 Adjust signatures to match updated version of code.
11245 (consing_since_gc): Now EMACS_INT, since a single hash table can
11246 use more than INT_MAX bytes.
11247
698d32e2
DN
112482011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11249
11250 Make it possible to build with GCC-4.6+ -O2 -flto.
11251
11252 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11253
fd6fa53f
SM
112542011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11255
11256 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11257 Call minibuffer-inactive-mode.
11258
864db017
JB
112592011-05-31 Juanma Barranquero <lekktu@gmail.com>
11260
11261 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11262 Update dependencies.
11263
2ad0baf4
DN
112642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11265
11266 * data.c (init_data): Remove code for UTS, this system is not
11267 supported anymore.
11268
4fcc2638
DN
112692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11270
11271 Don't force ./temacs to start in terminal mode.
11272
11273 * frame.c (make_initial_frame): Initialize faces in all cases, not
11274 only when CANNOT_DUMP is defined.
11275 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11276
c56e0fd5
DN
112772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11278
11279 * dispnew.c (add_window_display_history): Use const for the string
11280 pointer. Remove declaration, not needed.
11281
333d54da 112822011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11283
55d4c1b2 11284 Use 'inline', not 'INLINE'.
333d54da 11285 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11286 * alloc.c, fontset.c (INLINE): Remove.
11287 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11288 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11289 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11290 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11291 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11292
738db178
DN
112932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11294
11295 Make it possible to run ./temacs.
11296
11297 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11298 syms_of_callproc does the same thing. Remove test for
11299 "initialized", do it in the caller.
11300 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11301
620c53a6
SM
113022011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11303
11304 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11305 (read_minibuf): Use get_minibuffer.
11306 (syms_of_minibuf): Use DEFSYM.
11307 (Qmetadata): New var.
11308 * data.c (Qbuffer): Don't make it static.
11309 (syms_of_data): Use DEFSYM.
11310
e003a292
PE
113112011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11312
11313 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11314 (CCL_CODE_MIN): New macro.
11315
ed008a6d
PE
113162011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11317
3687c2ef
PE
11318 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11319
ed008a6d
PE
11320 * eval.c (Qdebug): Now static.
11321 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11322 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11323 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11324
d66c4c7c
CY
113252011-05-29 Chong Yidong <cyd@stupidchicken.com>
11326
11327 * image.c: Various fixes to ImageMagick code comments.
11328 (Fimagemagick_types): Doc fix.
11329
5fbc2025
PE
113302011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11331
0196f88a
PE
11332 Minor fixes prompted by GCC 4.6.0 warnings.
11333
11334 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11335
5fbc2025
PE
11336 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11337 (x_clipboard_manager_save_all): Move extern decl to ...
11338 * xterm.h: ... here, so that it can be checked for consistency.
11339
1dd3c2d9
CY
113402011-05-29 Chong Yidong <cyd@stupidchicken.com>
11341
11342 * xselect.c (x_clipboard_manager_save_frame)
11343 (x_clipboard_manager_save_all): New functions.
11344 (Fx_clipboard_manager_save): Lisp function deleted.
11345
11346 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11347 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11348
11349 * xterm.h: Update prototype.
11350
5ba6571d
WX
113512011-05-28 William Xu <william.xwl@gmail.com>
11352
11353 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11354 exiting (Bug#8239).
11355
3eaff834
JM
113562011-05-28 Jim Meyering <meyering@redhat.com>
11357
e1900994 11358 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11359 * fns.c (to_uchar): Define.
11360 (crypto_hash_function): Use it to convert some newly-signed
11361 variables to unsigned, to avoid sign-extension bugs. For example,
11362 without this change, (md5 "truc") would evaluate to
11363 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11364 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11365 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11366
0f6990a7
PE
113672011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11368
11369 Integer overflow fixes.
c8a9ca5a 11370
08686060
PE
11371 * dbusbind.c: Serial number integer overflow fixes.
11372 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11373 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11374 to hold a serial number that is too large for a fixnum.
11375 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11376 Check for serial numbers out of range. Decode any serial number
59568bf0 11377 that was so large that it became a float. (Bug#8722)
08686060 11378
2d1fc3c7
PE
11379 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11380 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11381 Use XFASTINT rather than XUINT when numbers are nonnegative.
11382 (xd_append_arg, Fdbus_method_return_internal):
11383 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11384 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11385 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11386 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11387 (Bug#8722)
2d1fc3c7 11388
c8a9ca5a
PE
11389 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11390
519e1d69
PE
11391 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11392
6df6ae42 11393 ccl: Add integer overflow checks.
30569699
PE
11394 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11395 (IN_INT_RANGE): New macros.
11396 (ccl_driver): Use them to check for integer overflow when
11397 decoding a CCL program. Many of the new checks are whether XINT (x)
11398 fits in int; it doesn't always, on 64-bit hosts. The new version
11399 doesn't catch all possible integer overflows, but it's an
847044ea 11400 improvement. (Bug#8719)
30569699 11401
c11285dc
PE
11402 * alloc.c (make_event_array): Use XINT, not XUINT.
11403 There's no need for unsigned here.
11404
fdccd48e
PE
11405 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11406 This follows up to the 2011-05-06 change that substituted uintptr_t
11407 for EMACS_INT. This case wasn't caught back then.
11408
37910ab2
PE
11409 Rework Fformat to avoid integer overflow issues.
11410 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11411 now (part of C89). Include <verify.h>.
11412 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11413 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11414 (Fformat): Avoid the prepass trying to compute sizes; it was only
11415 approximate and thus did not catch overflow reliably. Instead, walk
11416 through the format just once, formatting and computing sizes as we go,
11417 checking for integer overflow at every step, and allocating a larger
11418 buffer as needed. Keep track separately whether the format is
11419 multibyte. Keep only the most-recently calculated precision, rather
11420 than them all. Record whether each argument has been converted to
11421 string. Use EMACS_INT, not int, for byte and char and arg counts.
11422 Support field widths and precisions larger than INT_MAX. Avoid
11423 sprintf's undefined behavior with conversion specifications such as %#d
11424 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11425 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11426 formatting out-of-range floating point numbers with int
9173deec 11427 formats. (Bug#8668)
37910ab2 11428
2e6578fb
PE
11429 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11430
0ae6bdee
PE
11431 * data.c: Avoid integer truncation in expressions involving floats.
11432 * data.c: Include <intprops.h>.
11433 (arith_driver): When there's an integer overflow in an expression
11434 involving floating point, convert the integers to floating point
11435 so that the resulting value does not suffer from catastrophic
11436 integer truncation. For example, on a 64-bit host (* 4
11437 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11438 Do not rely on undefined behavior after integer overflow.
11439
de883a70
PE
11440 merge count_size_as_multibyte, parse_str_to_multibyte
11441 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11442 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11443 Check for integer overflow.
11444 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11445 since it's now a duplicate of the other. This is more of
11446 a character than a buffer op, so better that it's in character.c.
11447 * fns.c, print.c: Adjust to above changes.
11448
2ff916cb
PE
114492011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11450
11451 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11452
f1b54466
PE
114532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11454
fb1ac845
PE
11455 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11456 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11457 (x_clipboard_manager_save): Now static.
11458 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11459
f1b54466
PE
11460 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11461 (crypto_hash_function): Now static.
11462 Fix pointer signedness problems. Avoid unnecessary initializations.
11463
a9f737ee
CY
114642011-05-27 Chong Yidong <cyd@stupidchicken.com>
11465
11466 * termhooks.h (Vselection_alist): Make it terminal-local.
11467
11468 * terminal.c (create_terminal): Initialize it.
11469
11470 * xselect.c: Support for clipboard managers.
11471 (Vselection_alist): Move to termhooks.h as terminal-local var.
11472 (LOCAL_SELECTION): New macro.
11473 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11474 (symbol_to_x_atom): Remove gratuitous arg.
11475 (x_handle_selection_request, lisp_data_to_selection_data)
11476 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11477 (x_own_selection, x_get_local_selection, x_convert_selection):
11478 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11479 (some_frame_on_display): Delete unused function.
11480 (Fx_own_selection_internal, Fx_get_selection_internal)
11481 (Fx_disown_selection_internal, Fx_selection_owner_p)
11482 (Fx_selection_exists_p): New optional frame arg.
11483 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11484 (x_handle_selection_clear): Don't treat other terminals with the
11485 same keyboard specially. Use the terminal-local Vselection_alist.
11486 (x_clear_frame_selections): Use Frun_hook_with_args.
11487
11488 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11489
11490 * xterm.h: Add support for those atoms.
11491
e067f0c1
CY
114922011-05-26 Chong Yidong <cyd@stupidchicken.com>
11493
11494 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11495 (converted_selections, conversion_fail_tag): New global variables.
11496 (x_selection_request_lisp_error): Free the above.
11497 (x_get_local_selection): Remove unnecessary code.
11498 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11499 of converted selections stored in converted_selections.
11500 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11501 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11502 (x_convert_selection): New function.
11503 (x_handle_selection_event): Simplify.
11504 (x_get_foreign_selection): Don't ignore incoming requests while
11505 waiting for an answer; this will fail when we implement
11506 SAVE_TARGETS, and seems unnecessary anyway.
11507 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11508 (Vx_sent_selection_functions): Doc fix.
11509
0f4aebc0
LL
115102011-05-26 Leo Liu <sdl.web@gmail.com>
11511
11512 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11513
e61124cd
YM
115142011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11515
11516 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11517
11518 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11519 for fringe update if it has periodic bitmap.
ac389d0c 11520 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11521 and fringe_bitmap_periodic_p.
11522
11523 * fringe.c (get_fringe_bitmap_data): New function.
11524 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11525 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11526 row. Mark glyph row for fringe update if periodicity changed.
11527
11528 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11529 for fringe update unless it has periodic bitmap.
11530
f16d9837
KH
115312011-05-25 Kenichi Handa <handa@m17n.org>
11532
11533 * xdisp.c (get_next_display_element): Set correct it->face_id for
11534 a static composition.
11535
e1b90ef6
LL
115362011-05-24 Leo Liu <sdl.web@gmail.com>
11537
11538 * deps.mk (fns.o):
11539 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11540
11541 * fns.c (crypto_hash_function, Fsha1): New function.
11542 (Fmd5): Use crypto_hash_function.
11543 (syms_of_fns): Add Ssha1.
11544
7400048f
PE
115452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11546
11547 * gnutls.c: Remove unused macros.
11548 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11549 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11550 Remove macros that are defined and never used.
11551 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11552
abb71cf4
CY
115532011-05-22 Chong Yidong <cyd@stupidchicken.com>
11554
11555 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11556 (Fx_get_selection_internal): Minor cleanup.
11557 (Fx_own_selection_internal): Rename arguments for consistency with
11558 select.el.
11559
6307db39
PE
115602011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11561
11562 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11563
f3d4e0a4
CY
115642011-05-22 Chong Yidong <cyd@stupidchicken.com>
11565
11566 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11567
4d8ade89
YM
115682011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11569
11570 * dispnew.c (scrolling_window): Don't exclude the case that the
11571 last enabled row in the desired matrix touches the bottom boundary.
11572
32078c8d
GM
115732011-05-21 Glenn Morris <rgm@gnu.org>
11574
11575 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11576 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11577 and add some more files.
32078c8d 11578
7285dc67
EZ
115792011-05-20 Eli Zaretskii <eliz@gnu.org>
11580
11581 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11582 report_file_error introduced by the change from 2011-05-07.
11583
89d1bd22
PE
115842011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11585
11586 * systime.h (Time): Define only if emacs is defined.
11587 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11588 where the include path doesn't have X11/X.h by default. See
11589 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11590
cd394be1 115912011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11592
11593 * composite.c (find_automatic_composition): Fix previous change.
11594
b9704ad9
GM
115952011-05-20 Glenn Morris <rgm@gnu.org>
11596
11597 * lisp.mk: New file, split from Makefile.in.
11598 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11599 (shortlisp): Remove.
11600 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11601
4a720484
GM
116022011-05-19 Glenn Morris <rgm@gnu.org>
11603
11604 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11605 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11606 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11607 (lisp): Set the order to that of loadup.el.
11608 (shortlisp): Make it a copy of $lisp.
11609 (SOME_MACHINE_LISP): Remove.
11610 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11611 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11612
a28d4396
KH
116132011-05-18 Kenichi Handa <handa@m17n.org>
11614
11615 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11616 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11617 (find_automatic_composition): Mostly rewrite for efficiency.
11618
a2b1fa8e
JB
116192011-05-18 Juanma Barranquero <lekktu@gmail.com>
11620
11621 * makefile.w32-in: Update dependencies.
11622
8e1f5610
CS
116232011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11624
11625 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11626 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11627
7025ee00 116282011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11629
cdfa6eab
PE
11630 Fix some integer overflow issues, such as string length overflow.
11631
06d6db33
PE
11632 * insdel.c (count_size_as_multibyte): Check for string overflow.
11633
2b4560a8
PE
11634 * character.c (lisp_string_width): Check for string overflow.
11635 Use EMACS_INT, not int, for string indexes and lengths; in
11636 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11637 the resulting string length overflows an EMACS_INT; instead,
11638 report a string overflow if no precision given. When checking for
11639 precision exhaustion, use a check that cannot possibly have
11640 integer overflow. (Bug#8675)
11641 * character.h (lisp_string_width): Adjust to new signature.
11642
cb93f9be
PE
11643 * alloc.c (string_overflow): New function.
11644 (Fmake_string): Use it. This doesn't change behavior, but saves
11645 a few bytes and will simplify future changes.
11646 * character.c (string_escape_byte8): Likewise.
11647 * lisp.h (string_overflow): New decl.
11648
1a1f3366
PE
11649 Fixups, following up to the user-interface timestamp change.
11650 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11651 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11652 * msdos.c (mouse_get_pos): Likewise.
11653 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11654 * w32gui.h (Time): Define by including "systime.h" rather than by
11655 declaring it ourselves. (Bug#8664)
11656
d4e3e4d3
PE
11657 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11658 * image.c (clear_image_cache): Likewise.
11659
f6a24d19
PE
11660 * term.c (term_mouse_position): Don't assume time_t wraparound.
11661
08dc5ae6
PE
11662 Be more systematic about user-interface timestamps.
11663 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11664 and sometimes 'EMACS_UINT', to represent these timestamps.
11665 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11666 This makes the code easier to follow, and makes it easier to catch
11667 integer overflow bugs such as Bug#8664.
11668 * frame.c (Fmouse_position, Fmouse_pixel_position):
11669 Use Time, not unsigned long, for user-interface timestamps.
11670 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11671 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11672 * keyboard.h (last_event_timestamp): Likewise.
11673 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11674 * menu.h (xmenu_show): Likewise.
11675 * term.c (term_mouse_position): Likewise.
11676 * termhooks.h (struct input_event.timestamp): Likewise.
11677 (struct terminal.mouse_position_hook): Likewise.
11678 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11679 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11680 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11681 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11682 what it was before.
11683 * menu.h, termhooks.h: Include "systime.h", for Time.
11684
8e55734a
PE
11685 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11686 Don't assume that the difference between two unsigned long values
11687 can fit into an integer. At this point, we know button_down_time
11688 <= event->timestamp, so the difference must be nonnegative, so
11689 there's no need to cast the result if double-click-time is
11690 nonnegative, as it should be; check that it's nonnegative, just in
11691 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11692 apart (about 25 days). (Bug#8664)
8e55734a 11693
841f1b75 11694 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11695 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11696
3e26f69c
PE
11697 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11698 that always fit in int. Use a sentinel instead of a counter, to
11699 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11700 * frame.h (struct frame): Use int for menu_bar_items_used
11701 instead of EMACS_INT, since it always fits in int.
3e26f69c 11702
5cc152c0
PE
11703 * menu.c (grow_menu_items): Check for int overflow.
11704
d89eb65e
PE
11705 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11706
5235bd3e
PE
11707 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11708 Before, the code was not consistent. These values cannot exceed
11709 2**31 - 1 so there's no need to make them unsigned.
11710 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11711 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11712 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11713 as modifiers.
11714 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11715
bc827e23
PE
11716 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11717 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11718 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11719 presumably because the widths might not match.
11720
78eb494e
PE
11721 * window.c (size_window): Avoid needless test at loop start.
11722
04f2d78b
CB
117232011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11724
11725 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11726
d2fc7e3d 117272011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11728
11729 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11730
d2fc7e3d 117312011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11732
11733 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11734 `width' to `bar_area_x' and `bar_area_width', respectively.
11735 (x_scroll_run): Take account of fringe background extension.
11736
04f2d78b
CB
11737 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11738 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11739 `bar_area_width', respectively.
11740 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11741 background extension.
11742
79b70037
GM
117432011-05-10 Jim Meyering <meyering@redhat.com>
11744
11745 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11746
2f142cc5
JB
117472011-05-10 Juanma Barranquero <lekktu@gmail.com>
11748
11749 * image.c (Finit_image_library): Return t for built-in image types,
11750 like pbm and xbm. (Bug#8640)
11751
57679c86
AS
117522011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11753
11754 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11755
888c9e86
EZ
117562011-05-07 Eli Zaretskii <eliz@gnu.org>
11757
b0512a1d
EZ
11758 * w32console.c (Fset_screen_color): Doc fix.
11759 (Fget_screen_color): New function.
11760 (syms_of_ntterm): Defsubr it.
11761
7285dc67
EZ
11762 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11763 unlink the temporary file if Fcall_process didn't create it in the
11764 first place.
11765 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11766 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11767 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11768 cue to call_process_cleanup not to close that handle.
11769
4d3fcc8e
BK
117702011-05-07 Ben Key <bkey76@gmail.com>
11771
11772 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11773 one of two shell specific rules, either bootstrap-temacs-CMD or
11774 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11775 to the previous implementation of the bootstrap-temacs rule.
11776 The bootstrap-temacs-CMD rule is similar to the previous
11777 implementation of the bootstrap-temacs rule except that it
11778 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11779 variable.
11780
11781 These changes, along with some changes to nt/configure.bat,
11782 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11783 earlier fix to add support for --cflags and --ldflags options
11784 that include quotes so that it works whether make uses cmd or
11785 sh as the shell.
11786
b4289b64
MA
117872011-05-06 Michael Albinus <michael.albinus@gmx.de>
11788
11789 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11790 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11791 is a constant.
11792 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11793 a string. Handle both cases.
11794 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11795 (Fdbus_register_method): Use Qinvalid_function.
11796
af4c0e28
JB
117972011-05-06 Juanma Barranquero <lekktu@gmail.com>
11798
11799 * makefile.w32-in: Update dependencies.
11800 (LISP_H): Add inttypes.h and stdin.h.
11801 (PROCESS_H): Add unistd.h.
11802
c51453d9
EZ
118032011-05-06 Eli Zaretskii <eliz@gnu.org>
11804
11805 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11806 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11807
8ff0ac3c 118082011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11809
4c4b566b
PE
11810 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11811
aab2b9b5
PE
11812 * term.c (vfatal): Remove stray call to va_end.
11813 It's not needed and the C Standard doesn't allow it here anyway.
11814
c378da0b
PE
11815 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11816 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11817
288b08c7
PE
11818 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11819 bytes.
11820
e3601888
PE
11821 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11822
db6c0e74
PE
11823 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11824
dd5963ea
PE
11825 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11826
88c9450f
PE
11827 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11828
2f9442b8
PE
11829 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11830
c032b5f8
PE
11831 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11832 * charset.c (Fdefine_charset_internal): Don't initialize
11833 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11834 32-bit int (Bug#8600).
a108c10b
PE
11835
11836 * lread.c (read_integer): Be more consistent with string-to-number.
11837 Use string_to_number to do the actual conversion; this avoids
11838 rounding errors and fixes some other screwups. Without this fix,
11839 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11840 (digit_to_number): Move earlier, for benefit of read_integer.
11841 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11842 not a digit in any supported base. (Bug#8602)
a108c10b 11843
ad5f9eea
PE
11844 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11845
aec1708a
PE
11846 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11847 to match comment at start of function. This also removes a
11848 GCC warning about overflow in a 32+64-bit port.
11849
47be4ab5
PE
11850 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11851
371cac43
PE
11852 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11853 Reported by Stefan Monnier in
11854 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11855 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11856 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11857
d01a7826
PE
11858 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11859 (EMACS_UINTPTR): Likewise, with uintptr_t.
11860
7fd47d5c
PE
11861 * lisp.h: Prefer 64-bit EMACS_INT if available.
11862 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11863 on 32-bit hosts that have 64-bit int, so that they can access
11864 large files.
122b0c86
PE
11865 However, temporarily disable this change unless the temporary
11866 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11867
8727937b
PE
11868 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11869
8ac068ac
PE
11870 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11871 This removes an assumption that EMACS_INT and long are the same
11872 width as pointers. The assumption is true for Emacs porting targets
11873 now, but we want to make other targets possible.
11874 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11875 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11876 In the rest of the code, change types of integers that hold casted
11877 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11878 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11879 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11880 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11881 No need to cast type when ORing.
11882 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11883 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11884 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11885 assume EMACS_INT is the same width as char *.
11886 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11887 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11888 Remove no-longer-needed casts.
11889 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11890 (xg_tool_bar_help_callback, xg_make_tool_item):
11891 Use EMACS_INTPTR to hold an integer
11892 that will be cast to void *; this can avoid a GCC warning
11893 if EMACS_INT is not the same width as void *.
11894 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11895 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11896 (current_message_1, set_message_1):
11897 Use a local to convert to proper width without a cast.
11898 * xmenu.c (dialog_selection_callback): Likewise.
11899
ede49d71
PE
11900 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11901 Also, don't assume VALBITS / RAND_BITS is less than 5,
11902 and don't rely on undefined behavior when shifting a 1 left into
11903 the sign bit.
11904 * lisp.h (get_random): Change signature to match.
11905
2f30ecd0
PE
11906 * lread.c (hash_string): Use size_t, not int, for hash computation.
11907 Normally we prefer signed values; but hashing is special, because
11908 it's better to use unsigned division on hash table sizes so that
11909 the remainder is nonnegative. Also, size_t is the natural width
11910 for hashing into memory. The previous code used 'int', which doesn't
11911 retain enough info to hash well into very large tables.
11912 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11913
2a866e7b
PE
11914 * dbusbind.c: Don't possibly lose pointer info when converting.
11915 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11916 Use XPNTR rather than XHASH, so that the high-order bits of
11917 the pointer aren't lost when converting through void *.
11918
51639eac
PE
11919 * eval.c (Fautoload): Don't double-shift a pointer.
11920
92394119
PE
11921 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11922
dbdb9a7c
JB
119232011-05-06 Juanma Barranquero <lekktu@gmail.com>
11924
11925 * gnutls.c (DEF_GNUTLS_FN):
11926 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11927
db7a0b4f
AS
119282011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11929
11930 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11931 marker. (Bug#8610)
11932
cd394be1 119332011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11934
11935 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11936 New version that can reserve upto 2GB of heap space.
11937
f7ff1b0f 119382011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11939
11940 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11941
639c109b
TZ
119422011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11943
11944 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11945 `gnutls_certificate_set_x509_key_file'.
11946
d2127135
JB
119472011-05-05 Juanma Barranquero <lekktu@gmail.com>
11948
11949 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11950 Update dependencies.
11951
e968f4f3
JB
119522011-05-04 Juanma Barranquero <lekktu@gmail.com>
11953
11954 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11955 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11956 Remove unused parameter `fildes'.
11957 * process.c (read_process_output, send_process): Don't pass it.
11958
84d358f0
JB
119592011-05-04 Juanma Barranquero <lekktu@gmail.com>
11960
11961 Fix previous change: the library cache is defined in w32.c.
11962 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11963 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11964
0898ca10
JB
119652011-05-04 Juanma Barranquero <lekktu@gmail.com>
11966
11967 Implement dynamic loading of GnuTLS on Windows.
11968
11969 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11970 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11971 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11972 Declare.
11973
11974 * gnutls.c (Qgnutls_dll): Define.
11975 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11976 (gnutls_*): Declare function pointers.
11977 (init_gnutls_functions): New function to initialize function pointers.
11978 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11979 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11980 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11981 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11982 (emacs_gnutls_write, emacs_gnutls_read)
11983 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11984 (Fgnutls_available_p): New function.
11985 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11986 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11987 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11988
11989 * image.c: Include w32.h.
11990 (Vimage_type_cache): Delete.
11991 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11992 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11993 (w32_delayed_load): Move to w32.c.
11994
11995 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11996
11997 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11998 (w32_delayed_load): Move from image.c. When loading a library, record
11999 its filename in the :loaded-from property of the library id.
12000 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12001 Initialize and staticpro them.
12002 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12003
12004 * process.c: Include lisp.h before w32.h, not after.
12005 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12006 instead of gnutls_record_check_pending.
12007
12008 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12009
ff4de4aa
TZ
120102011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12011
12012 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12013 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12014 as passed in.
12015
abe95abb
JD
120162011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12017
12018 * xterm.c (x_set_frame_alpha): Do not set property on anything
12019 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12020
e16e55d4
JB
120212011-05-02 Juanma Barranquero <lekktu@gmail.com>
12022
12023 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12024
bafcf6a5
JB
120252011-05-02 Juanma Barranquero <lekktu@gmail.com>
12026
12027 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12028 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12029 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12030 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12031 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12032 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12033 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12034 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12035 (Qgnutls_bootprop_callbacks_verify): Make static.
12036
e7a6747f
AS
120372011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12038
19ed11ba
AS
12039 * callproc.c: Indentation fixup.
12040
e7a6747f 12041 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12042 (wait_for_termination, interruptible_wait_for_termination):
12043 Move after wait_for_termination_1.
e7a6747f 12044
1ef14cb4
LMI
120452011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12046
12047 * sysdep.c (interruptible_wait_for_termination): New function
12048 which is like wait_for_termination, but allows keyboard
12049 interruptions.
12050
12051 * callproc.c (Fcall_process): Add (:file "file") as an option for
12052 the STDOUT buffer.
12053 (Fcall_process_region): Ditto.
12054
330d880c
EZ
120552011-04-30 Eli Zaretskii <eliz@gnu.org>
12056
8db90b73
EZ
12057 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12058 rather than `XVECTOR (FOO)->size'.
12059
330d880c
EZ
12060 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12061 inttypes.h, as a gnulib replacement is used if it not available in
12062 system headers.
12063
15cbd324
EZ
120642011-04-21 Eli Zaretskii <eliz@gnu.org>
12065
12066 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12067 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12068 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12069
12070 * coding.c (coding_alloc_by_realloc): Error out if destination
12071 will grow beyond MOST_POSITIVE_FIXNUM.
12072 (decode_coding_emacs_mule): Abort if there isn't enough place in
12073 charbuf for the composition carryover bytes. Reserve an extra
12074 space for up to 2 characters produced in a loop.
12075 (decode_coding_iso_2022): Abort if there isn't enough place in
12076 charbuf for the composition carryover bytes.
12077
120782011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12079
ae940cca
EZ
12080 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12081 aborting when %lld or %lll format is passed.
12082 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12083 %llo or %llx format is passed. (Bug#8545)
12084
03ab8921
EZ
12085 * window.c (window_scroll_line_based): Use a marker instead of
12086 simple variables to record original value of point. (Bug#7952)
12087
afda1437
EZ
12088 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12089 produced by %s or %c overflows available buffer space. (Bug#8545)
12090
f76dee0c
PE
120912011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12092
12093 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12094 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12095
fdc5744d
JB
120962011-04-28 Juanma Barranquero <lekktu@gmail.com>
12097
12098 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12099
638f053a
JB
121002011-04-28 Juanma Barranquero <lekktu@gmail.com>
12101
12102 * keyboard.c (Qdelayed_warnings_hook): Define.
12103 (command_loop_1): Run `delayed-warnings-hook'
12104 if Vdelayed_warnings_list is non-nil.
12105 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12106 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12107
d178f871
EZ
121082011-04-28 Eli Zaretskii <eliz@gnu.org>
12109
12110 * doprnt.c (doprnt): Don't return value smaller than the buffer
12111 size if the message was truncated. (Bug#8545).
12112
b124fd93
JB
121132011-04-28 Juanma Barranquero <lekktu@gmail.com>
12114
12115 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12116 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12117
e810457d
PE
121182011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12119
12120 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12121
ea51cceb
JB
121222011-04-27 Juanma Barranquero <lekktu@gmail.com>
12123
12124 * makefile.w32-in: Update dependencies.
12125
94dcfacf
EZ
121262011-04-27 Eli Zaretskii <eliz@gnu.org>
12127
12128 Improve `doprnt' and its usage. (Bug#8545)
12129 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12130 `format_end'. Remove support for %l as a conversion specifier.
12131 Don't use xrealloc. Improve diagnostics when the %l size modifier
12132 is used. Update the commentary.
12133
12134 * eval.c (verror): Simplify calculation of size_t.
12135
12136 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12137 messages.
12138
f61f41d7
PE
121392011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12140
12141 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12142 change.
12143
96fb4434
PE
121442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12145
12146 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12147 This makes this file independent of the recent pseudovector change.
12148
671875da 121492011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12150
69e9b5a3
PE
12151 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12152
b5f869a7 12153 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12154 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12155 Remove unused local.
c8926152 12156 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12157
841a1577 12158 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12159 GCC 4.6.0 optimizes based on type-based alias analysis.
12160 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12161 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12162 != &v->size, and therefore "v->size = 1; b->size = 2; return
12163 v->size;" must therefore return 1. This assumption is incorrect
12164 for Emacs, since it type-puns struct Lisp_Vector * with many other
12165 types. To fix this problem, this patch adds a new type struct
f904488f 12166 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12167 and pseudovectors, and helps optimizing compilers not get fooled
12168 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12169 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12170 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12171 the size member.
eab3844f
PE
12172 (XSETPVECTYPE): Rewrite in terms of new macro.
12173 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12174 This is a bit clearer, and further avoids the possibility of
12175 undesirable aliasing.
12176 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12177 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12178 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12179 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12180 (ASIZE): Now uses header.size rather than size.
12181 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12182 to avoid the hassle of writing XVECTOR (foo)->header.size.
12183 (struct vectorlike_header): New type.
eab3844f
PE
12184 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12185 object, to help avoid aliasing.
12186 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12187 (SUBRP): Likewise, since Lisp_Subr is a special case.
12188 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12189 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12190 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12191 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12192 changed to be "header.size" and "header.next".
12193 * buffer.h (struct buffer): Likewise.
12194 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12195 * frame.h (struct frame): Likewise.
12196 * process.h (struct Lisp_Process): Likewise.
12197 * termhooks.h (struct terminal): Likewise.
12198 * window.c (struct save_window_data, struct saved_window): Likewise.
12199 * window.h (struct window): Likewise.
12200 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12201 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12202 * buffer.c (init_buffer_once): Likewise.
12203 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12204 special case.
12205 * process.c (Fformat_network_address): Use local var for size,
12206 for brevity.
12207
0df1eac5
PE
12208 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12209
847ab9d1 12210 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12211 * data.c (atof): Remove decl; no longer used or needed.
12212 (digit_to_number): Move to lread.c.
12213 (Fstring_to_number): Use new string_to_number function, to be
12214 consistent with how the Lisp reader treats infinities and NaNs.
12215 Do not assume that floating-point numbers represent EMACS_INT
12216 without losing information; this is not true on most 64-bit hosts.
12217 Avoid double-rounding errors, by insisting on integers when
12218 parsing non-base-10 numbers, as the documentation specifies.
12219 * lisp.h (string_to_number): New decl, replacing ...
12220 (isfloat_string): Remove.
bc0a5c13 12221 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12222 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12223 appears to have been a coding error. Similarly, do not accept
12224 strings like +-1e0 as floating point numbers. Do not report
12225 overflow for integer overflows unless the base is not 10 which
12226 means we have no simple and reliable way to continue.
12227 Break out the floating-point parsing into a new
12228 function string_to_number, so that Fstring_to_number parses
12229 floating point numbers consistently with the Lisp reader.
04f2d78b 12230 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12231 (E_CHAR, EXP_INT): Remove, replacing with ...
12232 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12233 (string_to_number): New function, replacing isfloat_string.
12234 This function checks for valid syntax and produces the resulting
12235 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12236 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12237 so that overflow for non-base-10 numbers is reported only when
12238 there's no portable and simple way to convert to floating point.
452f4150 12239
67769ffc
PE
12240 * textprop.c (set_text_properties_1): Rewrite for clarity,
12241 and to avoid GCC warning about integer overflow.
12242
c20db43f
PE
12243 * intervals.h (struct interval): Use EMACS_INT for members
12244 where EMACS_UINT might cause problems. See
12245 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12246 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12247 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12248 All uses changed.
37aa2f85
PE
12249 (offset_intervals): Tell GCC not to worry about length overflow
12250 when negating a negative length.
c20db43f 12251
2538aa2f
PE
12252 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12253 (overrun_check_free): Likewise.
12254
f2d3008d
PE
12255 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12256 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12257 word size.
12258
ec8df744
PE
12259 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12260 (gnutls_make_error): Rename local to avoid shadowing.
12261 (gnutls_emacs_global_deinit): ifdef out; not used.
12262 (Fgnutls_boot): Use const for pointer to readonly storage.
12263 Comment out unused local. Fix pointer signedness problems.
12264
640ee02d
PE
12265 * lread.c (openp): Don't stuff size_t into an 'int'.
12266 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12267 about possible signed overflow.
12268
6048fb2a
PE
12269 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12270 (GDK_KEY_g): Don't define if already defined.
12271 (xg_prepare_tooltip): Avoid pointer signedness problem.
12272 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12273
fa3c87e1
PE
12274 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12275 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12276
2172544b
PE
12277 * xfns.c (Fx_window_property): Simplify a bit,
12278 to make a bit faster and to avoid GCC 4.6.0 warning.
12279 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12280
9b821a21
PE
12281 * fns.c (internal_equal): Don't assume size_t fits in int.
12282
3c616cfa
PE
12283 * alloc.c (compact_small_strings): Tighten assertion a little.
12284
c2982e87
PE
12285 Replace pEd with more-general pI, and fix some printf arg casts.
12286 * lisp.h (pI): New macro, generalizing old pEd macro to other
12287 conversion specifiers. For example, use "...%"pI"d..." rather
12288 than "...%"pEd"...".
12289 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12290 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12291 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12292 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12293 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12294 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12295 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12296 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12297 64-bit hosts.
12298 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12299 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12300 * print.c (safe_debug_print, print_object): Likewise.
12301 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12302 to int.
6f04d126
PE
12303 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12304 avoiding the 0 flag, which is not portable.
c2982e87
PE
12305 * process.c (Fmake_network_process): Use pI to avoid cast.
12306 * region-cache.c (pp_cache): Likewise.
12307 * xdisp.c (decode_mode_spec): Likewise.
12308 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12309 behavior on 64-bit hosts with printf arg.
6f04d126 12310 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12311 (x_stop_queuing_selection_requests): Likewise.
12312 (x_get_window_property): Don't truncate byte count to an 'int'
12313 when tracing.
0b432f21 12314
5e073ec7
PE
12315 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12316 here, since it parses constructs like leading '-' and spaces,
12317 which are not wanted; and it overflows with large numbers.
12318 Instead, simply match F[0-9]+, which is what is wanted anyway.
12319
36372bf9
PE
12320 * alloc.c: Remove unportable assumptions about struct layout.
12321 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12322 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12323 (allocate_vectorlike, make_pure_vector): Use the new macros,
12324 plus offsetof, to remove unportable assumptions about struct layout.
12325 These assumptions hold on all porting targets that I know of, but
12326 they are not guaranteed, they're easy to remove, and removing them
12327 makes further changes easier.
12328
0b432f21
PE
12329 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12330 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12331 (string_overrun_cookie): Now const. Use initializers that
12332 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12333 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12334 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12335 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12336 multiple of sizeof (EMACS_INT); it need not be, if
12337 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12338 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12339
895009e1
JB
123402011-04-26 Juanma Barranquero <lekktu@gmail.com>
12341
12342 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12343
6a7a1b0b
TZ
123442011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12345
12346 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12347 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12348 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12349
841a1577 123502011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12351
12352 * lisp.h (Qdebug): List symbol.
895009e1 12353 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12354 * keyboard.c (debug-on-event): New variable.
12355 (handle_user_signal): Break into debugger when debug-on-event
12356 matches the current signal symbol.
12357
f2d3ba6f
DN
123582011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12359
12360 * alloc.c (check_sblock, check_string_bytes)
12361 (check_string_free_list): Convert to standard C.
12362
42ce4c63
TZ
123632011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12364
12365 * w32.c (emacs_gnutls_push): Fix typo.
12366
825cd63c
EZ
123672011-04-25 Eli Zaretskii <eliz@gnu.org>
12368
fb11d64d
EZ
12369 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12370 "cast to pointer from integer of different size".
12371
825cd63c
EZ
12372 Improve doprnt and its use in verror. (Bug#8545)
12373 * doprnt.c (doprnt): Document the set of format control sequences
12374 supported by the function. Use SAFE_ALLOCA instead of always
12375 using `alloca'.
12376
12377 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12378 is one byte too soon. Don't use xrealloc; instead xfree and
12379 xmalloc anew.
12380
e061a11b
TZ
123812011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12382
12383 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12384 callbacks stage.
12385
12386 * gnutls.c: Renamed global_initialized to
12387 gnutls_global_initialized. Added internals for the
12388 :verify-hostname-error, :verify-error, and :verify-flags
12389 parameters of `gnutls-boot' and documented those parameters in the
12390 docstring. Start callback support.
9173deec
JB
12391 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12392 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12393 on error. Return error code.
e061a11b
TZ
12394 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12395 (emacs_gnutls_read): Likewise.
12396 (Fgnutls_boot): Return handshake error code.
12397 (emacs_gnutls_handle_error): New function.
12398 (wsaerror_to_errno): Likewise.
12399
12400 * w32.h (emacs_gnutls_pull): Add prototype.
12401 (emacs_gnutls_push): Likewise.
12402
12403 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12404 (emacs_gnutls_push): Likewise.
12405
124062011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12407
12408 * process.c (wait_reading_process_output): Check if GnuTLS
12409 buffered some data internally if no FDs are set for TLS
12410 connections.
12411
12412 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12413 (LIBS): Link to USER_LIBS.
12414 ($(BLD)/gnutls.$(0)): New target.
12415
fa6996bc
EZ
124162011-04-24 Eli Zaretskii <eliz@gnu.org>
12417
eb35682e
EZ
12418 * xdisp.c (handle_single_display_spec): Rename the
12419 display_replaced_before_p argument into display_replaced_p, to
12420 make it consistent with the commentary. Fix typos in the
12421 commentary.
12422
e2ad650c
EZ
12423 * textprop.c (syms_of_textprop): Remove dead code.
12424 (copy_text_properties): Delete obsolete commentary about an
12425 interface that was deleted long ago. Fix typos in the description
12426 of arguments.
12427
1b2de274
EZ
12428 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12429 to changes in oldXMenu/XMenu.h from 2011-04-16.
12430 <menu_help_message, prev_menu_help_message>: Constify.
12431 (IT_menu_make_room): menu->help_text is now `const char **';
12432 adjust.
12433
12434 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12435 to changes in oldXMenu/XMenu.h from 2011-04-16.
12436 (struct XMenu): Declare `help_text' `const char **'.
12437
12438 * xfaces.c <Qunspecified>: Make extern again.
12439
12440 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12441 required by POSIX.
1b2de274 12442
762b15be
EZ
12443 * doc.c (get_doc_string): Improve the format passed to `error'.
12444
12445 * doprnt.c (doprnt): Improve commentary.
12446
12447 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12448
12449 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12450 them with etags.
12451
f1052e5d
EZ
12452 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12453 changes in globals.h immediately force recompilation.
762b15be
EZ
12454 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12455 $(CURDIR)/s/ms-w32.h.
12456 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12457
fa6996bc
EZ
12458 * character.c (Fchar_direction): Function deleted.
12459 (syms_of_character): Don't defsubr it.
12460 <char-direction-table>: Deleted.
12461
e6c3da20
EZ
124622011-04-23 Eli Zaretskii <eliz@gnu.org>
12463
12464 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12465 * doprnt.c: Include limits.h.
12466 (SIZE_MAX): New macro.
04f2d78b
CB
12467 (doprnt): Return a size_t value. 2nd arg is now size_t.
12468 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12469 Improve overflow protection. Support `l' modifier for integer
12470 conversions. Support %l conversion. Don't assume an EMACS_INT
12471 argument for integer conversions and for %c.
12472
12473 * lisp.h (doprnt): Restore prototype.
12474
12475 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12476 $(SRC)/character.h.
12477
12478 * Makefile.in (base_obj): Add back doprnt.o.
12479
12480 * deps.mk (doprnt.o): Add back prerequisites.
12481 (callint.o): Depend on character.h.
12482
12483 * eval.c (internal_lisp_condition_case): Include the handler
12484 representation in the error message.
12485 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12486 when breaking from the loop.
12487
12488 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12489
12490 * callint.c (Fcall_interactively): When displaying error message
12491 about invalid control letter, pass the character's codepoint, not
12492 a pointer to its multibyte form. Improve display of the character
12493 in octal and display also its hex code.
12494
12495 * character.c (char_string): Use %x to display the (unsigned)
12496 codepoint of an invalid character, to avoid displaying a bogus
12497 negative value.
12498
12499 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12500 `error', not SYMBOL_NAME itself.
12501
12502 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12503 character arguments to `error'.
12504
12505 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12506 to `error' in error message about FINAL_CHAR argument. Make sure
12507 FINAL_CHAR is a character, and use %c when it is passed as
12508 argument to `error'.
12509
4ffd0d6b 125102011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12511
12512 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12513
12514 * w32.c: Include <time.h>.
12515 (sys_localtime): New function.
12516
4ffd0d6b 125172011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12518
12519 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12520
4ffd0d6b 12521 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12522
4ffd0d6b 125232011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12524
4ffd0d6b
GM
12525 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12526 zombies (Bug#8467).
aac0c6e3 12527
04c56954
EZ
125282011-04-19 Eli Zaretskii <eliz@gnu.org>
12529
12530 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12531 gl_state.e_property when gl_state.object is Qt.
12532
12533 * insdel.c (make_gap_larger): Remove limitation of buffer size
12534 to <= INT_MAX.
12535
16a43933
CY
125362011-04-18 Chong Yidong <cyd@stupidchicken.com>
12537
12538 * xdisp.c (lookup_glyphless_char_display)
12539 (produce_glyphless_glyph): Handle cons cell entry in
12540 glyphless-char-display.
12541 (Vglyphless_char_display): Document it.
12542
12543 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12544 glyphless-char-display.
12545
4581706e
CY
125462011-04-17 Chong Yidong <cyd@stupidchicken.com>
12547
12548 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12549
12550 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12551
12552 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12553 definition for no-X builds.
12554
4887c6e2 125552011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12556
fd35b6f9
PE
12557 Static checks with GCC 4.6.0 and non-default toolkits.
12558
5c1ccb01
PE
12559 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12560
006c5daa
PE
12561 * process.c (keyboard_bit_set): Define only if SIGIO.
12562 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12563 (send_process): Repair possible setjmp clobbering.
12564
efc736d3
PE
12565 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12566
4e2fe2e6
PE
12567 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12568
f97334a2
PE
12569 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12570
4e75f29d
PE
12571 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12572 Define only if needed.
12573
90efadd1
PE
12574 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12575 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12576 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12577
3c647824
PE
12578 * dispextern.h (struct redisplay_interface): Rename param
12579 to avoid shadowing.
e264f262 12580 * termhooks.h (struct terminal): Likewise.
761383f4 12581 * xterm.c (xembed_send_message): Likewise.
3c647824 12582
b58c5c4a
PE
12583 * insdel.c (make_gap_smaller): Define only if
12584 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12585
cad59032
PE
12586 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12587 it.
12588
c339dc2e
PE
12589 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12590 so that we aren't warned about unused symbols.
12591
91a3e27b
PE
12592 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12593
399c71d3 12594 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12595
8ffc96f5
PE
12596 * xfns.c (x_real_positions): Mark locals as initialized.
12597
eef9bc79
PE
12598 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12599
098db9dd
PE
12600 * xterm.c: Fix problems found by static analysis with other toolkits.
12601 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12602 (x_dispatch_event): Declare static if USE_GTK, and
12603 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12604 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12605 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12606 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12607 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12608
eb18f6cc
PE
12609 * xmenu.c (menu_help_callback): Pointer type fixes.
12610 Use const pointers when pointing at readonly data. Avoid pointer
12611 signedness clashes.
12612 (FALSE): Remove unused macro.
12613 (update_frame_menubar): Remove unused decl.
12614
1fe72bf8
PE
12615 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12616
60d9e1db
PE
12617 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12618 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12619 (single_menu_item): Rename local to avoid shadowing.
12620
39261c26
PE
12621 * keyboard.c (make_lispy_event): Remove unused local var.
12622
018c5e19
PE
12623 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12624 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12625
63d2b86e
PE
12626 * bitmaps: Change bitmaps from unsigned char back to the X11
12627 compatible char. Avoid the old compiler warnings about
12628 out-of-range initializers by using, for example, '\xab' rather
12629 than 0xab.
12630
aefd87e1
PE
12631 * xgselect.c (xgselect_initialize): Check vs interface
12632 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12633
bf501fb9
PE
12634 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12635
e9829fdf
PE
12636 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12637 to read-only memory.
12638
1086c095
PE
12639 * fns.c (vector): Remove; this old hack is no longer needed.
12640
2baccd04 12641 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12642 Remove unused var.
dde42981 12643 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12644
72391843 12645 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12646
436c16df 12647 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12648 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12649 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12650
92bb796d 12651 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12652 (x_term_init): Remove local to avoid shadowing.
92bb796d 12653
764430a3 12654 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12655
12656 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12657 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12658
d1dfb56c
EZ
126592011-04-16 Eli Zaretskii <eliz@gnu.org>
12660
c4354cb4
EZ
12661 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12662
d1dfb56c
EZ
12663 Fix regex.c, syntax.c and friends for buffers > 2GB.
12664 * syntax.h (struct gl_state_s): Declare character position members
12665 EMACS_INT.
12666
12667 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12668
04f2d78b
CB
12669 * textprop.c (verify_interval_modification, interval_of):
12670 Declare arguments EMACS_INT.
d1dfb56c
EZ
12671
12672 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12673 EMACS_INT.
12674
12675 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12676
12677 * indent.c (Fvertical_motion): Local variable it_start is now
12678 EMACS_INT.
12679
12680 * regex.c (re_match, re_match_2, re_match_2_internal)
12681 (bcmp_translate, regcomp, regexec, print_double_string)
12682 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12683 (re_compile_pattern, re_exec): Declare arguments and local
12684 variables `size_t' and `ssize_t' and return values `regoff_t', as
12685 appropriate.
12686 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12687 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12688 <compile_stack_type>: `size' and `avail' are now `size_t'.
12689
12690 * regex.h <regoff_t>: Use ssize_t, not int.
12691 (re_search, re_search_2, re_match, re_match_2): Arguments that
12692 specify buffer/string position and length are now ssize_t and
12693 size_t. Return type is regoff_t.
12694
613052cd
BK
126952011-04-16 Ben Key <bkey76@gmail.com>
12696
12697 * nsfont.m: Fixed bugs in ns_get_family and
12698 ns_descriptor_to_entity that were caused by using free to
12699 deallocate memory blocks that were allocated by xmalloc (via
12700 xstrdup). This caused Emacs to crash when compiled with
12701 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12702 --enable-checking=xmallocoverrun). xfree is now used to
12703 deallocate these memory blocks.
12704
4170f62f 127052011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12706
71b41406
PE
12707 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12708
9587a89d
PE
12709 emacs_write: Accept and return EMACS_INT for sizes.
12710 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12711 et seq.
12712 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12713 Accept and return EMACS_INT.
12714 (emacs_gnutls_write): Return the number of bytes written on
12715 partial writes.
12716 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12717 (emacs_read, emacs_write): Remove check for negative size, as the
12718 Emacs source code has been audited now.
9587a89d
PE
12719 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12720 (emacs_read, emacs_write): Use it.
273a5f82
PE
12721 * process.c (send_process): Adjust to the new signatures of
12722 emacs_write and emacs_gnutls_write. Do not attempt to store
12723 a byte offset into an 'int'; it might overflow.
9587a89d 12724 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12725
3e047f51
PE
12726 * sound.c: Don't assume sizes fit in 'int'.
12727 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12728 Return EMACS_INT, not int.
3e047f51 12729 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12730 Accept EMACS_INT, not int.
12731 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12732 record read return values.
12733
cc39a9db
BK
127342011-04-15 Ben Key <bkey76@gmail.com>
12735
c9d0ec6d
JB
12736 * keyboard.c (Qundefined): Don't declare static since it is used
12737 in nsfns.m.
12738 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12739 static since they are used in nsfont.m.
cc39a9db 12740
6c60eb9f
SM
127412011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12742
12743 * process.c (Qprocessp): Don't declare static.
12744 * lisp.h (Qprocessp): Declare again.
12745
7990b61a
JB
127462011-04-15 Juanma Barranquero <lekktu@gmail.com>
12747
12748 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12749
5d4cb038
PE
127502011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12751
8bd7b830 12752 Improve C-level modularity by making more things 'static'.
cd64ea1d 12753
e3b27b31
PE
12754 Don't publish debugger-only interfaces to other modules.
12755 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12756 (verify_bytepos, count_markers): Move decls to the only modules
12757 that need them.
12758 * region-cache.h (pp_cache): Likewise.
12759 * window.h (check_all_windows): Likewise.
12760 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12761
5d4cb038
PE
12762 * sysdep.c (croak): Now static, if
12763 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12764 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12765
12766 * alloc.c (refill_memory_reserve): Now static if
12767 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12768 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12769
e87b6180
PE
12770 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12771 Define only if USE_LUCID.
12772
ac64929e
PE
12773 * xrdb.c (x_customization_string, x_rm_string): Now static.
12774
6f37259d
PE
12775 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12776 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12777
1683e3ab
PE
12778 * xdisp.c (draw_row_with_mouse_face): Now static.
12779 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12780
de9c2632
PE
12781 * window.h (check_all_windows): Mark externally visible.
12782
2b96acb7
PE
12783 * window.c (window_deletion_count): Now static.
12784
12785 * undo.c: Make symbols static if they're not exported.
12786 (last_undo_buffer, last_boundary_position, pending_boundary):
12787 Now static.
12788
50436f33
PE
12789 * textprop.c (interval_insert_behind_hooks): Now static.
12790 (interval_insert_in_front_hooks): Likewise.
12791
64520e5c
PE
12792 * term.c: Make symbols static if they're not exported.
12793 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12794 (max_frame_lines, tty_set_terminal_modes):
12795 (tty_reset_terminal_modes, tty_turn_off_highlight):
12796 (get_tty_terminal): Now static.
12797 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12798 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12799 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12800 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12801 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12802
1fa53021
PE
12803 * sysdep.c: Make symbols static if they're not exported.
12804 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12805 Now static.
12806 (sigprocmask_set, full_mask): Remove; unused.
12807 (wait_debugging): Mark as visible.
12808 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12809 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12810
d4b43b22
PE
12811 * syntax.c (syntax_temp): Define only if !__GNUC__.
12812
b7c513d0
PE
12813 * sound.c (current_sound_device, current_sound): Now static.
12814
989b29ad
PE
12815 * search.c (searchbufs, searchbuf_head): Now static.
12816
13a55a78
PE
12817 * scroll.c (scroll_cost): Remove; unused.
12818 * dispextern.h (scroll_cost): Remove decl.
12819
de68a1fc
PE
12820 * region-cache.h (pp_cache): Mark as externally visible.
12821
40ccffa6
PE
12822 * process.c: Make symbols static if they're not exported.
12823 (process_tick, update_tick, create_process, chan_process):
12824 (Vprocess_alist, proc_buffered_char, datagram_access):
12825 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12826 (deactivate_process): Mark defn as static, as well as decl.
12827 * lisp.h (create_process): Remove decl.
12828 * process.h (chan_process, Vprocess_alist): Remove decls.
12829
ad64fc97
PE
12830 * print.c: Make symbols static if they're not exported.
12831 (print_depth, new_backquote_output, being_printed, print_buffer):
12832 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12833 (print_interval, print_number_index, initial_stderr_stream):
12834 Now static.
12835 * lisp.h (Fprinc): Remove decl.
12836 (debug_output_compilation_hack): Mark as externally visible.
12837
adddb265
PE
12838 * sysdep.c (croak): Move decl from here to syssignal.h.
12839 * syssignal.h (croak): Put it here, so the API can be checked when
12840 'croak' is called from dissociate_if_controlling_tty.
12841
1717ede2
PE
12842 * minibuf.c: Make symbols static if they're not exported.
12843 (minibuf_save_list, choose_minibuf_frame): Now static.
12844 * lisp.h (choose_minibuf_frame): Remove decl.
12845
fa5fb2bc
PE
12846 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12847
1e3890d1
PE
12848 * lread.c: Make symbols static if they're not exported.
12849 (read_objects, initial_obarray, oblookup_last_bucket_number):
12850 Now static.
12851 (make_symbol): Remove; unused.
12852 * lisp.h (initial_obarray, make_symbol): Remove decls.
12853
8a1414fa
PE
12854 * keyboard.c: Make symbols static if they're not exported.
12855 (single_kboard, recent_keys_index, total_keys, recent_keys):
12856 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12857 (this_single_command_key_start, echoing, last_auto_save):
12858 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12859 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12860 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12861 (Vlispy_mouse_stem, double_click_count):
12862 Now static.
12863 (force_auto_save_soon): Define only if SIGDANGER.
12864 (ignore_mouse_drag_p): Now static if
12865 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12866 (print_help): Remove; unused.
12867 (stop_character, last_timer_event): Mark as externally visible.
12868 * keyboard.h (ignore_mouse_drag_p): Declare only if
12869 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12870 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12871 * lisp.h (echoing): Remove decl.
12872 (force_auto_save_soon): Declare only if SIGDANGER.
12873 * xdisp.c (redisplay_window): Simplify code, to make it more
12874 obvious that ignore_mouse_drag_p is not accessed if !defined
12875 USE_GTK && !defined HAVE_NS.
12876
93ea6e8f
PE
12877 * intervals.c: Make symbols static if they're not exported.
12878 (merge_properties_sticky, merge_interval_right, delete_interval):
12879 Now static.
12880 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12881
77382fcc
PE
12882 * insdel.c: Make symbols static if they're not exported.
12883 However, leave prepare_to_modify_buffer alone. It's never
12884 called from outside this function, but that appears to be a bug.
12885 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12886 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12887 (adjust_after_replace_noundo): Remove; unused.
12888 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12889 (signal_before_change): Remove decls.
77382fcc 12890
9306c32e
PE
12891 * indent.c (val_compute_motion, val_vmotion): Now static.
12892
cd44d2eb
PE
12893 * image.c: Make symbols static if they're not exported.
12894 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12895 if USE_GTK.
12896 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12897 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12898
ad9a7a06
PE
12899 * fringe.c (standard_bitmaps): Now static.
12900 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12901
81626931
PE
12902 * frame.c: Make symbols static if they're not exported.
12903 (x_report_frame_params, make_terminal_frame): Now static.
12904 (get_frame_param): Now static, unless HAVE_NS.
12905 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12906 (x_get_resource_string): Remove; not used.
12907 * frame.h (make_terminal_frame, x_report_frame_params):
12908 (x_get_resource_string); Remove decls.
12909 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12910 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12911
239f9db9
PE
12912 * font.c, fontset.c: Make symbols static if they're not exported.
12913 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12914 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12915 * font.c (font_close_object): Now static.
12916 * font.h (font_close_object): Remove.
12917 * fontset.c (FONTSET_OBJLIST): Remove.
12918 (free_realized_fontset) #if-0 the body, which does nothing.
12919 (face_suitable_for_char_p): #if-0, as it's never called.
12920 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12921 * xfaces.c (face_at_string_position):
12922 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12923 since 0 is always ASCII.
12924
dfcf3579
PE
12925 * fns.c (weak_hash_tables): Now static.
12926
5045092b
PE
12927 * fileio.c: Make symbols static if they're not exported.
12928 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12929 (Vwrite_region_annotation_buffers): Now static.
12930
57a96f5c
PE
12931 * eval.c: Make symbols static if they're not exported.
12932 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12933 * lisp.h (backtrace_list): Remove decl.
12934
35f08c38
PE
12935 * emacs.c: Make symbols static if they're not exported.
12936 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12937 (fatal_error_code, fatal_error_signal_hook, standard_args):
12938 Now static.
12939 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12940 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12941 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12942 * lisp.h (fatal_error_signal_hook): Remove decl.
12943 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12944
f44bd759
PE
12945 * editfns.c: Move a (normally-unused) function to its only use.
12946 * editfns.c, lisp.h (get_operating_system_release): Remove.
12947 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12948 worth the hassle of breaking this out.
12949
b532497d
PE
12950 * xterm.c: Make symbols static if they're not exported.
12951 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12952 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12953 (x_destroy_window, x_delete_display):
12954 Now static.
12955 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12956 (x_mouse_leave): Remove; unused.
12957 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12958 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12959 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12960 Remove decls.
12961 (x_mouse_leave): Declare only if WINDOWSNT.
12962 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12963 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12964 USE_X_TOOLKIT.
12965
1675728f
PE
12966 * ftxfont.c: Make symbols static if they're not exported.
12967 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12968 HAVE_FREETYPE.
12969 * font.h (ftxfont_driver): Likewise.
12970
e4cebfca
PE
12971 * xfns.c: Make symbols static if they're not exported.
12972 (x_last_font_name, x_display_info_for_name):
12973 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12974 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12975 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12976 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12977 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12978 (last_show_tip_args): Now static.
12979 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12980 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12981 (x_screen_planes): Remove; unused.
12982 * dispextern.h (x_screen_planes): Remove decl.
12983
5bf46f05
PE
12984 * dispnew.c: Make symbols static if they're not exported.
12985 * dispextern.h (redraw_garbaged_frames, scrolling):
12986 (increment_row_positions): Remove.
12987 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12988 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12989 Now static.
12990 (redraw_garbaged_frames): Remove; unused.
12991
435f4c28
PE
12992 * xfaces.c: Make symbols static if they're not exported.
12993 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12994 Remove decls.
12995 * xterm.h (defined_color): Remove decls.
12996 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12997 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12998 (menu_face_changed_default, defined_color, free_realized_face):
12999 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13000 (ascii_face_of_lisp_face): Remove; unused.
13001
8524aef3
PE
13002 * xdisp.c: Make symbols static if they're not exported.
13003 * dispextern.h (scratch_glyph_row, window_box_edges):
13004 (glyph_to_pixel_coords, set_cursor_from_row):
13005 (get_next_display_element, set_iterator_to_next):
13006 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13007 (show_mouse_face): Remove decls
13008 * frame.h (message_buf_print): Likewise.
13009 * lisp.h (pop_message, set_message, check_point_in_composition):
13010 Likewise.
13011 * xterm.h (set_vertical_scroll_bar): Likewise.
13012 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13013 (message_buf_print, scratch_glyph_row, displayed_buffer):
13014 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13015 (get_next_display_element, show_mouse_face, window_box_edges):
13016 (frame_to_window_pixel_xy, check_point_in_composition):
13017 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13018 (glyph_to_pixel_coords): Remove; unused.
13019
16390cd2
PE
13020 * dired.c (file_name_completion): Now static.
13021
13022 * dbusbind.c (xd_in_read_queued_messages): Now static.
13023
a25f4dfa
PE
13024 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13025 * data.c (circular_list_error): Remove.
13026
14a9c8df
PE
13027 * commands.h (last_point_position, last_point_position_buffer):
13028 (last_point_position_window): Remove decls.
13029 * keyboard.c: Make these variables static.
13030
04f2d78b
CB
13031 * coding.h (coding, code_convert_region, encode_coding_gap):
13032 Remove decls.
74ab6df5
PE
13033 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13034 (iso_code_class, detect_coding, code_convert_region): Now static.
13035 (encode_coding_gap): Remove; unused.
13036
38dfbee1
PE
13037 * chartab.c (chartab_chars, chartab_bits): Now static.
13038
a2cb4e63
PE
13039 * charset.h (charset_iso_8859_1): Remove decl.
13040 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13041 Now static.
13042
127198fd
PE
13043 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13044 * ccl.c (Vccl_program_table): Now static.
13045 (check_ccl_update): Remove; unused.
13046
d85b608f
PE
13047 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13048 * category.h: ... from here.
13049 * category.c (check_category_table, set_category_set): Now static.
13050
31cd66f3
PE
13051 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13052 * lisp.h: Remove these decls.
13053
c358e587
PE
13054 * buffer.c (buffer_count): Remove unused var.
13055
e78aecca
PE
13056 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13057 so that it's not optimized away.
13058 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13059 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13060 exported only to the debugger.
13061
e192d7d3 13062 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13063 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13064
92470028
PE
13065 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13066 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13067 was inaccessible from Lisp.
13068 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13069 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13070
244ed907
PE
13071 alloc.c: Import and export fewer symbols, and remove unused items.
13072 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13073 is defined.
13074 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13075 it's not optimized away by whole-program optimization.
13076 (message_enable_multibyte, free_misc): Remove.
13077 (catchlist, handlerlist, mark_backtrace):
13078 Declare only if BYTE_MARK_STACK.
13079 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13080 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13081 (message_enable_multibyte): Remove decl.
13082 (free_misc, interval_free_list, float_block, float_block_index):
13083 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13084 (cons_free_list, last_marked_index):
13085 Now static.
13086 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13087 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13088 (mark_backtrace): Define only if BYTE_MARK_STACK.
13089 * xdisp.c (message_enable_multibyte): Now static.
13090
61c2b50e 13091 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13092 This makes it easier for human readers (and static analyzers)
13093 to see whether these variables are used from other modules.
13094 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13095 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13096 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13097 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13098 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13099 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13100 * xmenu.c, xselect.c:
13101 Declare Q* vars static if they are not used in other modules.
13102 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13103 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13104 Remove decls of unexported vars.
13105 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13106
95c82688
PE
13107 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13108
16a97296
PE
13109 Make Emacs functions such as Fatom 'static' by default.
13110 This makes it easier for human readers (and static analyzers)
13111 to see whether these functions can be called from other modules.
13112 DEFUN now defines a static function. To make the function external
13113 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13114 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13115 (Finit_image_library):
16a97296
PE
13116 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13117 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13118 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13119 Remove decls, since these functions are now static.
13120 (Funintern, Fget_internal_run_time): New decls, since these functions
13121 were already external.
95c82688 13122
16a97296
PE
13123 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13124 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13125 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13126 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13127 * keyboard.c, keymap.c, lread.c:
13128 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13129 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13130 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13131 Mark functions with DEFUE instead of DEFUN,
13132 if they are used in other modules.
13133 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13134 decls for now-static functions.
13135 * buffer.h (Fdelete_overlay): Remove decl.
13136 * callproc.c (Fgetenv_internal): Mark as internal.
13137 * composite.c (Fremove_list_of_text_properties): Remove decl.
13138 (Fcomposition_get_gstring): New forward static decl.
13139 * composite.h (Fcomposite_get_gstring): Remove decl.
13140 * dired.c (Ffile_attributes): New forward static decl.
13141 * doc.c (Fdocumntation_property): New forward static decl.
13142 * eval.c (Ffetch_bytecode): New forward static decl.
13143 (Funintern): Remove extern decl; now in .h file where it belongs.
13144 * fileio.c (Fmake_symbolic_link): New forward static decl.
13145 * image.c (Finit_image_library): New forward static decl.
13146 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13147 * intervals.h (Fprevious_property_change):
13148 (Fremove_list_of_text_properties): Remove decls.
13149 * keyboard.c (Fthis_command_keys): Remove decl.
13150 (Fcommand_execute): New forward static decl.
13151 * keymap.c (Flookup_key): New forward static decl.
13152 (Fcopy_keymap): Now static.
13153 * keymap.h (Flookup_key): Remove decl.
13154 * process.c (Fget_process): New forward static decl.
13155 (Fprocess_datagram_address): Mark as internal.
13156 * syntax.c (Fsyntax_table_p): New forward static decl.
13157 (skip_chars): Remove duplicate decl.
13158 * textprop.c (Fprevious_property_change): New forward static decl.
13159 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13160 Now internal.
13161 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13162 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13163
785bbd42
PE
13164 * editfns.c (Fformat): Remove unreachable code.
13165
8b913b57
AS
131662011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13167
13168 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13169 change. (Bug#8496)
13170
a6744a35
EZ
131712011-04-13 Eli Zaretskii <eliz@gnu.org>
13172
13173 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13174 when at ZV. (Bug#8487)
13175
e7974947
AS
131762011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13177
baad03f0
AS
13178 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13179 (Bug#8437)
13180 * keyboard.c (parse_tool_bar_item): Likewise.
13181 * sound.c (sound_cleanup, alsa_close): Likewise.
13182 * termcap.c (tgetent): Likewise.
13183 * xfns.c (x_default_font_parameter): Likewise.
13184 * xsettings.c (read_and_apply_settings): Likewise.
13185
e7974947
AS
13186 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13187 (overrun_check_free): Protoize.
13188
28272684
PE
131892011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13190
13191 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13192 since callers should never pass a negative size.
13193 Change the signature to match that of plain 'read' and 'write'; see
13194 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13195 * lisp.h: Update prototypes of emacs_write and emacs_read.
13196
11997c76
EZ
131972011-04-11 Eli Zaretskii <eliz@gnu.org>
13198
13199 * xdisp.c (redisplay_window): Don't try to determine the character
13200 position of the scroll margin if the window start point w->startp
e896f03c 13201 is outside the buffer's accessible region. (Bug#8468)
11997c76 13202
8a2cbd72
EZ
132032011-04-10 Eli Zaretskii <eliz@gnu.org>
13204
13205 Fix write-region and its subroutines for buffers > 2GB.
13206 * fileio.c (a_write, e_write): Modify declaration of arguments and
13207 local variables to support buffers larger than 2GB.
13208 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13209
13210 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13211 argument, local variables, and return value.
13212
13213 * lisp.h: Update prototypes of emacs_write and emacs_read.
13214
13215 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13216
4073e537 132172011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13218
1ebfdcb6
PE
13219 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13220
b2ded58d
PE
13221 Fix more problems found by GCC 4.6.0's static checks.
13222
7d66342c
PE
13223 * xdisp.c (vmessage): Use a better test for character truncation.
13224
bbf47d44
PE
13225 * charset.c (load_charset_map): <, not <=, for optimization,
13226 and to avoid potential problems with integer overflow.
9248994d 13227 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13228 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13229 * editfns.c (Fformat): Likewise.
1e69125e 13230 * syntax.c (skip_chars): Likewise.
3befa583 13231
e3019616
PE
13232 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13233 This also lets GCC 4.6.0 generate slightly better loop code.
13234
becfa255
PE
13235 * callint.c (Fcall_interactively): <, not <=, for optimization.
13236 (Fcall_interactively): Count the number of arguments produced,
13237 not the number of arguments given. This is simpler and lets GCC
13238 4.6.0 generate slightly better code.
13239
dae0cd48
PE
13240 * ftfont.c: Distingish more carefully between FcChar8 and char.
13241 The previous code passed unsigned char * to a functions like
13242 strlen and xstrcasecmp that expect char *, which does not
13243 conform to the C standard.
13244 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13245 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13246 char * when the C standard requires it.
13247
76032d70
PE
13248 * keyboard.c (read_char): Remove unused var.
13249
eb3f1cc8
PE
13250 * eval.c: Port to Windows vsnprintf (Bug#8435).
13251 Include <limits.h>.
13252 (SIZE_MAX): Define if the headers do not.
13253 (verror): Do not give up if vsnprintf returns a negative count.
13254 Instead, grow the buffer. This ports to Windows vsnprintf, which
13255 does not conform to C99. Problem reported by Eli Zaretskii.
13256 Also, simplify the allocation scheme, by avoiding the need for
13257 calling realloc, and removing the ALLOCATED variable.
13258
70476b54
PE
13259 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13260
12020a9e
PE
13261 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13262 But keep the doprint source code for now, as we might revamp it
13263 and use it again (Bug#8435).
ea6c7ae6
PE
13264 * lisp.h (doprnt): Remove.
13265 * Makefile.in (base_obj): Remove doprnt.o.
13266 * deps.mk (doprnt.o): Remove.
13267
5fdb398c
PE
13268 error: Print 32- and 64-bit integers portably (Bug#8435).
13269 Without this change, on typical 64-bit hosts error ("...%d...", N)
13270 was used to print both 32- and 64-bit integers N, which relied on
13271 undefined behavior.
61bdb816 13272 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13273 * lisp.h (error, verror): Mark as printf-like functions.
13274 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13275 Report overflow in size calculations when allocating printf buffer.
13276 Do not truncate output string at its first null byte.
13277 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13278 Truncate the output at a character boundary, since vsnprintf does not
13279 do that.
13280 * charset.c (check_iso_charset_parameter): Convert internal
13281 character to string before calling 'error', since %c now has the
13282 printf meaning.
13283 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13284 overflow when computing char to be passed to 'error'. Do not
13285 pass Lisp_Object to 'error'; pass the integer instead.
13286 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13287 formatted with plain %d.
13288
b189fa66
PE
13289 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13290
bff87ef0
PE
13291 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13292
7e2cac20
PE
13293 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13294
ce4d90b5
PE
13295 * xterm.c (x_catch_errors): Remove duplicate declaration.
13296
266c9547
PE
13297 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13298
79c49ad2
PE
13299 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13300
368f4090
JM
133012011-04-10 Jim Meyering <meyering@redhat.com>
13302
13303 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13304 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13305 return ssize_t not "int", and use size_t as the buffer length.
13306 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13307 * gnutls.h: Update declarations.
13308 * process.c (read_process_output): Use ssize_t, to match.
13309 (send_process): Likewise.
13310
a32d4040
CY
133112011-04-09 Chong Yidong <cyd@stupidchicken.com>
13312
13313 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13314
8546720e 133152011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13316
04f2d78b
CB
13317 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13318 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13319
8546720e
GM
13320 * xterm.c (handle_one_xevent):
13321 * xmenu.c (create_and_show_popup_menu):
13322 * xselect.c (x_decline_selection_request)
13323 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13324
0a2f5c1a 133252011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13326
13327 Fix some uses of `int' instead of EMACS_INT.
13328 * search.c (string_match_1, fast_string_match)
13329 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13330 (scan_buffer, find_next_newline_no_quit)
13331 (find_before_next_newline, search_command, Freplace_match)
13332 (Fmatch_data): Make some `int' variables be EMACS_INT.
13333
13334 * xdisp.c (display_count_lines): 3rd argument and return value now
13335 EMACS_INT. All callers changed.
13336 (pint2hrstr): Last argument is now EMACS_INT.
13337
13338 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13339 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13340 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13341 (decode_coding_utf_16, decode_coding_emacs_mule)
13342 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13343 (decode_coding_ccl, decode_coding_charset)
13344 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13345 (decode_coding_iso_2022, decode_coding_emacs_mule)
13346 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13347 <char_offset, last_offset>: Declare EMACS_INT.
13348 (encode_coding_utf_8, encode_coding_utf_16)
13349 (encode_coding_emacs_mule, encode_invocation_designation)
13350 (encode_designation_at_bol, encode_coding_iso_2022)
13351 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13352 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13353 Declare EMACS_INT.
13354 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13355 (encode_invocation_designation): Last argument P_NCHARS is now
13356 EMACS_INT.
13357 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13358 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13359
13360 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13361 All users changed.
13362
13363 * ccl.c (Fccl_execute_on_string): Declare some variables
13364 EMACS_INT.
13365
8546720e 133662011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13367
13368 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13369
4e19a977
CS
133702011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13371
13372 * process.c (Fformat_network_address): Doc fix.
13373
87302331
R
133742011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13375
ee7683eb 13376 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13377
cbb59342
CY
133782011-04-08 Chong Yidong <cyd@stupidchicken.com>
13379
13380 * keyboard.c (read_char): Call Lisp function help-form-show,
13381 instead of using internal_with_output_to_temp_buffer.
13382 (Qhelp_form_show): New var.
e0d38eeb 13383 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13384
13385 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13386
13387 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13388
e67a13ab
CY
133892011-04-06 Chong Yidong <cyd@stupidchicken.com>
13390
04f2d78b
CB
13391 * process.c (Flist_processes): Remove to Lisp.
13392 (list_processes_1): Delete.
e67a13ab 13393
973f782d
EZ
133942011-04-06 Eli Zaretskii <eliz@gnu.org>
13395
7c106b1e
EZ
13396 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13397
973f782d
EZ
13398 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13399
41cf7d1a 134002011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13401
ca23cc88
PE
13402 Fix more problems found by GCC 4.6.0's static checks.
13403
f390e2d5
PE
13404 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13405
42eea0d0
PE
13406 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13407
b69769da 13408 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13409
f9541e84
PE
13410 * xdisp.c (vmessage): Mark as a printf-like function.
13411
13841b55
PE
13412 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13413
c136c10f
PE
13414 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13415
5e2d4a30
PE
13416 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13417 printf-like functions.
13418 (tiff_load): Add casts to remove these marks before passing them
13419 to system-supplied API.
13420
583f48b9
PE
13421 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13422
b25d760e
PE
13423 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13424 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13425 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13426 directly, rather than having caller test rule sign. This avoids
13427 some unnecessary tests.
13428 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13429 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13430 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13431
bc7b6697 13432 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13433 (xfont_open): Avoid unnecessary tests.
bc7b6697 13434
27ccc379
PE
13435 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13436
dcd5c89a
PE
13437 * composite.h, composite.c (composition_gstring_put_cache):
13438 Use EMACS_INT, not int, for length.
13439
b13a45c6
PE
13440 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13441 breaking out part of COMPOSITION_DECODE_RULE.
13442 (COMPOSITION_DECODE_RULE): Use it.
13443 * composite.c (get_composition_id): Remove unused local vars,
13444 by using the new macro.
13445
1e792e4d
PE
13446 * textprop.c (set_text_properties_1): Change while to do-while,
13447 since the condition is always true at first.
13448
dc6c6455 13449 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13450 (interval_deletion_adjustment): Return unsigned value.
13451 All uses changed.
dc6c6455 13452
aba7731a
PE
13453 * process.c (list_processes_1, create_pty, read_process_output):
13454 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13455 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13456 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13457 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13458 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13459
fdfc4bf3
PE
13460 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13461
fca8fe46 13462 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13463 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13464
06a0259a 13465 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13466 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13467 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13468
e7b9e80f
PE
13469 * print.c (print_error_message): Avoid int overflow.
13470
56201685
PE
13471 * font.c (font_list_entities): Redo for clarity,
13472 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13473
78834453 13474 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13475 (font_score): Avoid potential overflow in diff calculation.
78834453 13476
0bc0b309 13477 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13478 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13479
e610eaca
PE
13480 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13481
b895abce
PE
13482 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13483 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13484 can always succeed if overflow has undefined behavior.
13485
1f1d9321 13486 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13487 (wordify): Omit three unnecessary tests.
1f1d9321 13488
c59478bc
PE
13489 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13490 All callers changed. This avoids the need for an unused var.
13491
79b73827
PE
13492 * casefiddle.c (casify_region): Remove var that is set but not used.
13493
a4db5dfe
PE
13494 * dired.c (file_name_completion): Remove var that is set but not used.
13495
43aae36e
PE
13496 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13497
2a47c44d 13498 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13499 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13500
a37c69bf
PE
13501 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13502 Check for integer overflow on size calculations.
13503
328ab8e7
PE
13504 * buffer.c (Fprevious_overlay_change): Remove var that is set
13505 but not used.
13506
e5a2a5cb
PE
13507 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13508 Remove vars that are set but not used.
8d84a6eb 13509 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13510 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13511
a60e5f68
PE
13512 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13513
f661cb61 13514 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13515 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13516
f0397f5a
PE
13517 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13518 that are set but not used.
13519
8664db06 13520 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13521 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13522
6abdaa4a
PE
13523 * xselect.c (x_get_local_selection, x_handle_property_notify):
13524 Remove vars that are set but not used.
13525
0ce7538d 13526 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13527 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13528
9ae848fc
PE
13529 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13530 Remove var that is set but not used.
0b918413
PE
13531 (scroll_bar_windows_size): Now size_t, not int.
13532 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13533 Check for overflow.
9ae848fc 13534
a5a62657
PE
13535 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13536 (map_tty_color) [!defined MSDOS]: Likewise.
13537
5c5cdd39
PE
13538 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13539
66ebf983
PE
13540 * coding.c: Remove vars that are set but not used.
13541 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13542 All callers changed.
13543 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13544 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13545 (decode_coding_charset): Remove vars that are set but not used.
13546
1be4d761
PE
13547 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13548 that is set but not used.
13549
47553fa8
PE
13550 * print.c (print_object): Remove var that is set but not used.
13551
1f7196bf 13552 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13553 The gnulib version avoids calling malloc in the usual case,
13554 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13555 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13556 * filelock.c (current_lock_owner): Likewise.
13557 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13558 * sysdep.c: Include allocator.h, careadlinkat.h.
13559 (emacs_no_realloc_allocator): New static constant.
13560 (emacs_readlink): New function.
fdb61804
PE
13561 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13562 ../lib/careadlinkat.h.
d1fdcab7 13563
f84c17c7
SM
135642011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13565
13566 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13567 first non-nil return value).
13568
ef3862ad
JD
135692011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13570
13571 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13572 if not defined (Bug#8403).
13573
376a7006
JB
135742011-04-02 Juanma Barranquero <lekktu@gmail.com>
13575
13576 * xdisp.c (display_count_lines): Remove parameter `start',
13577 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13578 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13579 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13580 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13581 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13582 and thereabouts. All callers changed.
13583 (get_per_char_metric): Remove parameter `f', unused since
13584 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13585
6ca3801d
JM
135862011-04-02 Jim Meyering <meyering@redhat.com>
13587
13588 do not dereference NULL upon failed strdup
13589 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13590 (ns_get_family): Likewise.
13591
d8e2b5ba
JB
135922011-04-02 Juanma Barranquero <lekktu@gmail.com>
13593
13594 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13595
8c74fcbd
JD
135962011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13597
13598 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13599 later (Bug#8403).
13600
7200d79c
SM
136012011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13602
03408648 13603 Add lexical binding.
7200d79c 13604
03408648
SM
13605 * window.c (Ftemp_output_buffer_show): New fun.
13606 (Fsave_window_excursion):
13607 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13608
13609 * lread.c (lisp_file_lexically_bound_p): New function.
13610 (Fload): Bind Qlexical_binding.
13611 (readevalloop): Remove `evalfun' arg.
13612 Bind Qinternal_interpreter_environment.
13613 (Feval_buffer): Bind Qlexical_binding.
13614 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13615 Mark as dynamic.
13616 (syms_of_lread): Declare `lexical-binding'.
13617
13618 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13619
13620 * keyboard.c (eval_dyn): New fun.
13621 (menu_item_eval_property): Use it.
ca105506
SM
13622
13623 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13624
03408648
SM
13625 * fns.c (concat, mapcar1): Accept byte-code-functions.
13626
13627 * eval.c (Fsetq): Handle lexical vars.
13628 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13629 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13630 (FletX, Flet): Obey lexical binding.
13631 (Fcommandp): Handle closures.
13632 (Feval): New `lexical' arg.
13633 (eval_sub): New function extracted from Feval. Use it almost
13634 everywhere where Feval was used. Look up vars in lexical env.
13635 Handle closures.
13636 (Ffunctionp): Move from subr.el.
13637 (Ffuncall): Handle closures.
13638 (apply_lambda): Remove `eval_flags'.
13639 (funcall_lambda): Handle closures and new byte-code-functions.
13640 (Fspecial_variable_p): New function.
13641 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13642 but without exporting it to Lisp.
23aba0ea 13643
23aba0ea 13644 * doc.c (Fdocumentation, store_function_docstring):
03408648 13645 * data.c (Finteractive_form): Handle closures.
23aba0ea 13646
03408648
SM
13647 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13648 interactive spec.
ba83908c 13649
04f2d78b
CB
13650 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13651 New byte-codes.
03408648
SM
13652 (exec_byte_code): New function extracted from Fbyte_code to handle new
13653 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13654
03408648 13655 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13656
03408648 13657 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13658
e2abce01
JB
136592011-03-31 Juanma Barranquero <lekktu@gmail.com>
13660
13661 * xdisp.c (redisplay_internal): Fix prototype.
13662
63696a73 136632011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13664
63696a73 13665 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13666 (try_scrolling): Use it when setting scroll_limit.
13667 Limit scrolling to 100 screen lines.
63696a73
EZ
13668 (redisplay_window): Even when falling back on "recentering",
13669 position point in the window according to scroll-conservatively,
13670 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13671
13672 (try_scrolling): When point is above the window, allow searching
13673 as far as scroll_max, or one screenful, to compute vertical
13674 distance from PT to the scroll margin position. This prevents
13675 try_scrolling from unnecessarily failing when
13676 scroll-conservatively is set to a value slightly larger than the
13677 window height. Clean up the case of PT below the margin at bottom
13678 of window: scroll_max can no longer be INT_MAX. When aggressive
13679 scrolling is in use, don't let point enter the opposite scroll
13680 margin as result of the scroll.
13681 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13682 threshold of 100 lines for never-recentering scrolling.
13683
e4cc2dfc
JB
136842011-03-31 Juanma Barranquero <lekktu@gmail.com>
13685
13686 * dispextern.h (move_it_by_lines):
13687 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13688 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13689 (message_log_check_duplicate): Remove parameters `prev_bol' and
13690 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13691 (redisplay_internal): Remove parameter `preserve_echo_area',
13692 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13693
13694 * indent.c (Fvertical_motion):
13695 * window.c (window_scroll_pixel_based, Frecenter):
13696 Don't pass `need_y_p' to `move_it_by_lines'.
13697
1c470562
SM
136982011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13699
44f230aa
SM
13700 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13701 steal a few bits to be more compact.
13702 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13703 Remove unneeded casts.
13704
1c470562
SM
13705 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13706
888adce9
ZK
137072011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13708
13709 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13710 binding" message (bug#7967).
13711
f838ed7b
PE
137122011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13713
77861b95
PE
13714 Fix more problems found by GCC 4.6.0's static checks.
13715
de6dbc14
PE
13716 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13717 Remove unused local var.
13718
f838ed7b
PE
13719 * editfns.c (Fmessage_box): Remove unused local var.
13720
792c7b2b
PE
13721 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13722 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13723 Omit unused local vars.
c499e557 13724 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13725 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13726 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13727 Omit unused local var.
13728
ba0165e1
PE
13729 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13730 Don't assume string length fits in int.
32ad8845 13731 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13732 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13733
3c59b4c9
PE
13734 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13735 instead of alloca (Bug#8344).
13736
a3eed478 13737 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13738 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13739
eb4d412d
PE
13740 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13741
1658b401
PE
13742 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13743 concerns.
13744
13745 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13746
13747 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13748
9a2c6e05
PE
13749 * keyboard.c (syms_of_keyboard): Use the same style as later
13750 in this function when indexing through an array. This also
13751 works around GCC bug 48267.
13752
03d0a109
PE
13753 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13754
44f730c8
PE
13755 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13756
fe75f926
PE
13757 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13758 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13759
ffa8c828
PE
13760 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13761 This avoids undefined behavior on integer overflow, and is a bit
13762 more convenient anyway since it is compared to a size_t variable.
13763
c5101a77
PE
13764 Variadic C functions now count arguments with size_t, not int.
13765 This avoids an unnecessary limitation on 64-bit machines, which
13766 caused (substring ...) to crash on large vectors (Bug#8344).
13767 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13768 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13769 All variadic functions and their callers changed accordingly.
c5101a77
PE
13770 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13771 * data.c (arith_driver, float_arith_driver): Likewise.
13772 * editfns.c (general_insert_function): Likewise.
13773 * eval.c (struct backtrace.nargs, interactive_p)
13774 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13775 (funcall_lambda, mark_backtrace): Likewise.
13776 * fns.c (concat): Likewise.
13777 * frame.c (x_set_frame_parameters): Likewise.
13778 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13779 0 if not found, not -1. All callers changed.
13780
dd3f25f7
PE
13781 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13782 (stack_copy_size): Now size_t, not int.
13783 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13784
461c2ab9
JB
137852011-03-28 Juanma Barranquero <lekktu@gmail.com>
13786
13787 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13788 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13789 All callers changed.
13790
13791 * lisp.h (multibyte_char_to_unibyte):
13792 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13793 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13794 * character.h (CHAR_TO_BYTE8):
13795 * cmds.c (internal_self_insert):
13796 * editfns.c (general_insert_function):
13797 * keymap.c (push_key_description):
13798 * search.c (Freplace_match):
13799 * xdisp.c (message_dolog, set_message_1): All callers changed.
13800
f6d62986
SM
138012011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13802
13803 * keyboard.c (safe_run_hook_funcall): New function.
13804 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13805 don't set the hook to nil, but remove the offending function instead.
13806 (Qcommand_hook_internal): Remove, unused.
13807 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13808 Vcommand_hook_internal.
13809
13810 * eval.c (enum run_hooks_condition): Remove.
13811 (funcall_nil, funcall_not): New functions.
13812 (run_hook_with_args): Call each function through a `funcall' argument.
13813 Remove `cond' argument, now redundant.
13814 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13815 (Frun_hook_with_args_until_failure): Adjust accordingly.
13816 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13817
1db5b1ad
JB
138182011-03-28 Juanma Barranquero <lekktu@gmail.com>
13819
13820 * dispextern.h (string_buffer_position): Remove declaration.
13821
13822 * print.c (strout): Remove parameter `multibyte', unused since
13823 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13824
13825 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13826 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13827 All callers changed.
13828
13829 * w32.c (_wsa_errlist): Use braces for struct initializers.
13830
13831 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13832 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13833 All callers changed.
13834 (string_buffer_position): Likewise. Also, make static (it's never
13835 used outside xdisp.c).
13836 (cursor_row_p): Remove parameter `w', unused since
13837 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13838 (decode_mode_spec): Remove parameter `precision', introduced during
13839 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13840 All callers changed.
13841
5ffb62aa
JD
138422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13843
13844 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13845
461c2ab9 138462011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13847
13848 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13849 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13850 (ns_update_auto_hide_menu_bar): New functions.
13851 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13852 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13853 ns_constrain_all_frames.
13854 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13855 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13856
5c380ffb
JD
138572011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13858
13859 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13860
9af30bdf
GM
138612011-03-27 Glenn Morris <rgm@gnu.org>
13862
13863 * syssignal.h: Replace RETSIGTYPE with void.
13864 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13865 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13866 Replace SIGTYPE with void everywhere.
13867 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13868 * s/template.h (SIGTYPE): Remove commented out definition.
13869
e2abce01
JB
138702011-03-26 Eli Zaretskii <eliz@gnu.org>
13871
13872 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13873 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13874
f868cd8a
JB
138752011-03-26 Juanma Barranquero <lekktu@gmail.com>
13876
59eb0929
JB
13877 * w32.c (read_unc_volume): Use parameter `henum', instead of
13878 global variable `wget_enum_handle'.
13879
13880 * keymap.c (describe_vector): Remove parameters `indices' and
13881 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13882 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13883
f868cd8a
JB
13884 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13885
13886 * keyboard.c (timer_check): Remove parameter `do_it_now',
13887 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13888 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13889 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13890
13891 * keyboard.c (read_char):
13892 * w32menu.c (w32_menu_display_help):
13893 * xmenu.c (show_help_event, menu_help_callback):
13894 Adjust calls to `show_help_echo'.
13895
13896 * gtkutil.c (xg_maybe_add_timer):
13897 * keyboard.c (readable_events):
13898 * process.c (wait_reading_process_output):
13899 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13900
13901 * insdel.c (adjust_markers_gap_motion):
13902 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13903 (gap_left, gap_right): Don't call it.
13904
2ecf6fdb
CY
139052011-03-25 Chong Yidong <cyd@stupidchicken.com>
13906
13907 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13908 incurred during fontification.
13909
6b1f9ba4
JB
139102011-03-25 Juanma Barranquero <lekktu@gmail.com>
13911
13912 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13913 (DEFVAR_PER_BUFFER): Don't pass it.
13914
13915 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13916 (scrolling_window): Don't pass it.
13917
0f4a96b5
JB
139182011-03-25 Juanma Barranquero <lekktu@gmail.com>
13919
13920 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13921
13922 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13923 and `suffix'.
13924 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13925 of variables specific to SELinux and computation of `encoded_absname'.
13926
13927 * image.c (XPutPixel): Remove unused variable `height'.
13928
13929 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13930
13931 * unexw32.c (get_section_info): Remove unused variable `section'.
13932
13933 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13934 (system_process_attributes): Remove unused variable `sess'.
13935 (sys_read): Remove unused variable `err'.
13936
13937 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13938 (w32_wnd_proc): Remove unused variable `isdead'.
13939 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13940 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13941 (x_create_tip_frame): Remove unused variable `tem'.
13942
13943 * w32inevt.c (w32_console_read_socket):
13944 Remove unused variable `no_events'.
13945
13946 * w32term.c (x_draw_composite_glyph_string_foreground):
13947 Remove unused variable `width'.
13948
1149507c
JB
139492011-03-24 Juanma Barranquero <lekktu@gmail.com>
13950
13951 * w32term.c (x_set_glyph_string_clipping):
13952 Don't pass uninitialized region to CombineRgn.
13953
9c88f339
JB
139542011-03-23 Juanma Barranquero <lekktu@gmail.com>
13955
13956 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13957 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13958 (Fx_close_connection): Remove unused variable `i'.
13959
13960 * w32font.c (w32font_draw): Return number of glyphs.
13961 (w32font_open_internal): Remove unused variable `i'.
13962 (w32font_driver): Add missing initializer.
13963
13964 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13965 (fill_in_menu): Remove unused variable `items_added'.
13966
13967 * w32term.c (last_mouse_press_frame): Remove static global variable.
13968 (w32_clip_to_row): Remove unused variable `f'.
13969 (x_delete_terminal): Remove unused variable `i'.
13970
13971 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13972 (NOTHING): Remove unused static global variable.
13973 (uniscribe_check_otf): Remove unused variable `table'.
13974 (uniscribe_font_driver): Add missing initializers.
13975
dee091a3
JD
139762011-03-23 Julien Danjou <julien@danjou.info>
13977
13978 * term.c (Fsuspend_tty, Fresume_tty):
13979 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13980 * window.c (temp_output_buffer_show):
13981 * insdel.c (signal_before_change):
13982 * frame.c (Fhandle_switch_frame):
13983 * fileio.c (Fdo_auto_save):
13984 * emacs.c (Fkill_emacs):
13985 * editfns.c (save_excursion_restore):
13986 * cmds.c (internal_self_insert):
13987 * callint.c (Fcall_interactively):
13988 * buffer.c (Fkill_all_local_variables):
13989 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13990 Use Frun_hooks.
0f4a96b5 13991 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13992 unconditionally since it does the check itself.
dee091a3 13993
2c520ab5 139942011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13995
c9c49752
PE
13996 Fix more problems found by GCC 4.5.2's static checks.
13997
8abc3f12
PE
13998 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13999 the first time through the loop, since we know p0 < p1 then.
14000 This also avoids a gcc -Wstrict-overflow warning.
14001
a2d26660
PE
14002 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14003 leading to a memory leak, possible in functions like
14004 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14005 of objects (Bug#8318).
a2d26660 14006
916c72e9
PE
14007 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14008 that could (at least in theory) be that large.
14009
19ab8a18
PE
14010 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14011 This is less likely to overflow, and avoids undefined behavior if
14012 overflow does occur. All callers changed. Use strtoul to scan
14013 for the unsigned long integer.
b7cbbd6f
PE
14014 (pint2hrstr): Simplify and tune code slightly.
14015 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14016
f0641eff
PE
14017 * scroll.c (do_scrolling): Work around GCC bug 48228.
14018 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14019
7f650bb9
PE
14020 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14021 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14022 (validate_x_resource_name): Simplify count usage.
14023 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14024
37dd57d1
PE
14025 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14026 fail (Bug#8306).
81e56e61 14027
699979fc 14028 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14029
401bf9b4
PE
14030 * process.c (Fmake_network_process): Use socklen_t, not int,
14031 where POSIX says socklen_t is required in portable programs.
14032 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14033 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14034 (Fmake_network_process, server_accept_connection):
14035 (wait_reading_process_output, read_process_output):
14036 Likewise.
14037
b93aacde
PE
14038 * process.c: Rename or move locals to avoid shadowing.
14039 (list_processes_1, Fmake_network_process):
14040 (read_process_output_error_handler, exec_sentinel_error_handler):
14041 Rename or move locals.
4dc343ee 14042 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14043 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14044 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14045 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14046 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14047
af8a867c 14048 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14049 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14050 Include tparam.h instead, since it declares them.
af8a867c
PE
14051 * cm.h (PC): Remove extern decl; tparam.h now does this.
14052 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14053 * terminfo.c: Include tparam.h, to check interfaces.
14054 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14055 (tparam): Adjust signature to match interface in tparam.h;
14056 this removes some undefined behavior. Check that outstring and len
14057 are zero, which they always are with Emacs.
14058 * tparam.h (PC, BC, UP): New extern decls.
14059
0248044d 14060 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14061 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14062
8ff096c1 14063 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14064 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14065 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14066 (ftfont_list): Remove unused local.
49eaafba
PE
14067 (get_adstyle_property, ftfont_pattern_entity):
14068 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14069 Rename locals to avoid shadowing.
8ff096c1 14070
e2be39f6
PE
14071 * xfont.c (xfont_list_family): Mark var as initialized.
14072
c9735e30
PE
14073 * xml.c (make_dom): Now static.
14074
8f5201ae
PE
14075 * composite.c (composition_compute_stop_pos): Rename local to
14076 avoid shadowing.
b246f932
PE
14077 (composition_reseat_it): Remove unused locals.
14078 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14079 (composition_update_it): Mark var as initialized.
11b61122
PE
14080 (find_automatic_composition): Mark vars as initialized,
14081 with a FIXME (Bug#8290).
8f5201ae 14082
760fbc2c
PE
14083 character.h: Rename locals to avoid shadowing.
14084 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14085 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14086 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14087 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14088 to avoid shadowing.
14089
ff08eb85
PE
14090 * textprop.c (property_change_between_p): Remove; unused.
14091
fc7bf025
PE
14092 * intervals.c (interval_start_pos): Now static.
14093
235d7abc
PE
14094 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14095
44f230aa
SM
14096 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14097 Rename locals to avoid shadowing.
3e7d6594 14098
50060332
PE
14099 * sound.c (wav_play, au_play, Fplay_sound_internal):
14100 Fix pointer signedness.
d01f234b 14101 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14102 (wav_play): Initialize a variable to 0, to prevent undefined
14103 behavior (Bug#8278).
50060332 14104
c4fc4e30
PE
14105 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14106
918436ed
PE
14107 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14108
c939f91b
PE
14109 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14110 clobbering (Bug#8298).
b9c7f648
PE
14111 * sysdep.c (sys_subshell): Likewise.
14112 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14113
6bd8c144
PE
14114 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14115 This should get cleaned up, so that child_setup has the
14116 same signature on all platforms.
14117
7710357c 14118 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14119 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14120
c59da222
CY
141212011-03-22 Chong Yidong <cyd@stupidchicken.com>
14122
14123 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14124 not to be necessary, and produces flickering.
14125
66b87493
GM
141262011-03-20 Glenn Morris <rgm@gnu.org>
14127
14128 * config.in: Remove file.
14129
45b6f6d5
JB
141302011-03-20 Juanma Barranquero <lekktu@gmail.com>
14131
14132 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14133 are now in src/globals.h.
14134 (syms_of_minibuf): Remove spurious & from previous change.
14135
cd394be1 141362011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14137
14138 * minibuf.c (completing-read-function): New variable.
14139 (completing-read-default): Rename from completing-read.
14140 (completing-read): Call completing-read-function.
14141
b14e3e21
CY
141422011-03-19 Juanma Barranquero <lekktu@gmail.com>
14143
14144 * xfaces.c (Fx_load_color_file):
14145 Read color file from absolute filename (bug#8250).
14146
f2b726e6
JB
141472011-03-19 Juanma Barranquero <lekktu@gmail.com>
14148
14149 * makefile.w32-in: Update dependencies.
14150
09f6ff02
EZ
141512011-03-17 Eli Zaretskii <eliz@gnu.org>
14152
14153 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14154
29a6015a
PE
141552011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14156
a3a6c54e
PE
14157 Fix more problems found by GCC 4.5.2's static checks.
14158
b766f867
PE
14159 * process.c (make_serial_process_unwind, send_process_trap):
14160 (sigchld_handler): Now static.
14161
be02381c
PE
14162 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14163 That way, the code declares only the vars that it needs.
14164 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14165 * s/cygwin.h (PTY_ITERATION): Likewise.
14166 * s/darwin.h (PTY_ITERATION): Likewise.
14167 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14168
57048744
PE
14169 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14170 * process.c (allocate_pty): Don't declare stb unless it's needed.
14171
7914961c 14172 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14173 (CONSTANTLIM): Remove; unused.
14174 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14175 Define only if needed.
7914961c 14176
b3967b18
PE
14177 * unexelf.c (unexec): Name an expression,
14178 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14179 Use a different way to cause a compilation error if anyone uses
14180 n rather than nn, a way that does not involve shadowing.
73366a00 14181 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14182
29a6015a
PE
14183 * deps.mk (unexalpha.o): Remove; unused.
14184
43cfc33e 14185 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14186 * unexec.h: New file.
ce701a33
PE
14187 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14188 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14189 Depend on unexec.h.
14190 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14191 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14192 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14193 Change as necessary to match prototype in unexec.h.
ce701a33 14194
01f44d5a
PE
14195 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14196 shadowing.
4f63c6bb 14197 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14198
a6670b0b
PE
14199 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14200 Rename locals to avoid shadowing.
14201
cef2010d 14202 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14203 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14204
d4d7173a
PE
14205 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14206
f08b802a
PE
14207 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14208 warning when compiling print.c.
14209
3ddb0639
PE
14210 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14211 instead of using an uninitialized var.
5ad03b97 14212 (font_sort_entities): Mark var as initialized.
3ddb0639 14213
170a2692
PE
14214 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14215
e663c700
PE
14216 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14217 pointers to constants.
89bc529a 14218 (font_parse_fcname): Remove unused vars.
7b81e2d0 14219 (font_delete_unmatched): Now static.
ea838e10 14220 (font_get_spec): Remove; unused.
13a547c6
PE
14221 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14222 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14223 Rename or move locals to avoid shadowing.
e663c700 14224
2a80c887 14225 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14226 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14227
1384fa33 14228 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14229 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14230
8b2c52e9
PE
14231 * alloc.c (mark_backtrace): Move decl from here ...
14232 * lisp.h: ... to here, so that it can be checked.
14233
475545b5 14234 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14235 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14236 (lisp_indirect_variable): Name an expression,
14237 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14238 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14239
b1349114 14240 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14241 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14242 Use const pointer when appropriate.
b1349114 14243
a2928364
PE
14244 * lisp.h (get_system_name, get_operating_system_release):
14245 Move decls here, to check interfaces.
14246 * process.c (get_operating_system_release): Move decl to lisp.h.
14247 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14248 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14249 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14250 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14251 (Fformat_time_string, Fencode_time, Finsert_char):
14252 (Ftranslate_region_internal, Fformat):
14253 Rename or remove local vars to avoid shadowing.
9710023e 14254 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14255
a415e694
PE
14256 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14257 avoid shadowing.
14258
8ef4622d
PE
14259 * lisp.h (eassert): Check that the argument compiles, even if
14260 ENABLE_CHECKING is not defined.
14261
946f9a5b
PE
14262 * data.c (Findirect_variable): Name an expression, to avoid
14263 gcc -Wbad-function-cast warning.
112396d6 14264 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14265 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14266 (Fmake_variable_buffer_local, Fmake_local_variable):
14267 Mark variables as initialized.
52746918 14268 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14269
e5aab7e7 14270 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14271 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14272 Rename locals to avoid shadowing.
dff45157
PE
14273 (mark_stack): Move local variables into the #ifdef region where
14274 they're used.
7bc26fdb
PE
14275 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14276 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14277 needed otherwise.
14278 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14279 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14280 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14281
e5aab7e7
PE
14282 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14283 avoids undefined behavior in theory.
14284
4da60324
PE
14285 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14286
88043301
PE
14287 Use functions, not macros, for up- and down-casing (Bug#8254).
14288 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14289 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14290 to use the following functions instead of these macros.
14291 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14292 EMACS_INT, since callers assume the returned value fits in int.
14293 (upcase1): Likewise, for UPCASE_TABLE.
14294 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14295 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14296 the race-condition problem in the old DOWNCASE.
88043301 14297
19ed5445
PE
14298 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14299 Rename locals to avoid shadowing.
14300 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14301 (regex_compile, re_search_2, re_match_2_internal):
14302 Remove unused local vars.
952db0d7
PE
14303 (FREE_VAR): Rewrite so as not to use empty "else",
14304 which gcc can warn about.
da053e48 14305 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14306 (RETALLOC_IF): Define only if needed.
14307 (WORDCHAR_P): Likewise. This one is never needed, but is used
14308 only in a comment talking about a compiler bug, so put inside
14309 the #if 0 of that comment.
14310 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14311 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14312 Remove; unused.
19ed5445 14313
1f3561e4 14314 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14315 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14316 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14317
ded6f8f7
PE
14318 * search.c (simple_search): Remove unused var.
14319
dbd37a95
PE
14320 * dired.c (compile_pattern): Move decl from here ...
14321 * lisp.h: ... to here, so that it can be checked.
14322 (struct re_registers): New forward decl.
14323
7e47afad
PE
14324 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14325
85f24f61
PE
14326 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14327 All uses changed.
14328 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14329 Rename locals to avoid shadowing.
5671df8f 14330 (Fvertical_motion): Mark locals as initialized.
85f24f61 14331
181aa2be 14332 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14333 (casify_region): Mark local as initialized.
181aa2be 14334
930d429c
PE
14335 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14336
7082eac6
PE
14337 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14338 New macros, so that the caller can use some names other than
14339 gcpro1, gcpro2, etc.
14340 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14341 of the new macros.
14342 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14343 argument, for consistency with GCPRO2_VAR, etc: it is now the
14344 prefix of the variable, not the variable itself. All uses
14345 changed.
38b2c076
PE
14346 * dired.c (directory_files_internal, file_name_completion):
14347 Rename locals to avoid shadowing.
14348
15206ed9
PE
14349 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14350 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14351 dired.c's scmp function, had undefined behavior.
14352 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14353 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14354 * buffer.h: ... to here, because these macros use current_buffer,
14355 and the new implementation with inline functions needs to have
14356 current_buffer in scope now, rather than later when the macros
14357 are used.
14358 (downcase, upcase1): New static inline functions.
14359 (DOWNCASE, UPCASE1): Reimplement using these functions.
14360 This avoids undefined behavior in expressions like
14361 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14362 from race conditions in accessing the global variables
14363 case_temp1 and case_temp2.
14364 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14365 * lisp.h (case_temp1, case_temp2): Remove their decls.
14366 * character.h (ASCII_CHAR_P): Move from here ...
14367 * lisp.h: ... to here, so that the inline functions mentioned
14368 above can use them.
14369
4a6bea26
PE
14370 * dired.c (directory_files_internal_unwind): Now static.
14371
f14b7e14
PE
14372 * fileio.c (file_name_as_directory, directory_file_name):
14373 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14374 Now static.
2893f146
PE
14375 (file_name_as_directory): Use const pointers when appropriate.
14376 (Fexpand_file_name): Likewise. In particular, newdir might
14377 point at constant storage, so make it a const pointer.
fd4ead52 14378 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14379 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14380 signedness issues.
f839df0c
PE
14381 (Fset_file_times, Finsert_file_contents, auto_save_error):
14382 Rename locals to avoid shadowing.
f14b7e14 14383
5716756e 14384 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14385 (Ftry_completion, Fall_completions): Rename or remove locals
14386 to avoid shadowing.
5716756e 14387
b4c3046a
PE
14388 * marker.c (bytepos_to_charpos): Remove; unused.
14389
b45db522
PE
14390 * lisp.h (verify_bytepos, count_markers): New decls,
14391 so that gcc does not warn that these functions aren't declared.
14392
85876d07
PE
14393 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14394 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14395 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14396 (copy_text): Remove unused local var.
85876d07 14397
03d78a21 14398 * filelock.c (within_one_second): Now static.
b3dd38ab 14399 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14400
5df8f01b
PE
14401 * buffer.c (fix_overlays_before): Mark locals as initialized.
14402 (fix_start_end_in_overlays): Likewise. This function should be
14403 simplified by using pointers-to-pointers, but that's a different
14404 matter.
b1d876f1 14405 (switch_to_buffer_1): Now static.
8f54f30a
PE
14406 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14407 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14408
a70072c9 14409 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14410 Fix pointer signedness issue.
edced198
PE
14411 (sys_subshell): Mark local as volatile if checking for lint,
14412 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14413 (MAXPATHLEN): Define only if needed.
a70072c9 14414
a0977c44
PE
14415 * process.c (serial_open, serial_configure): Move decls from here ...
14416 * systty.h: ... to here, so that they can be checked.
14417
a884fdcc
PE
14418 * fns.c (get_random, seed_random): Move extern decls from here ...
14419 * lisp.h: ... to here, so that they can be checked.
14420
604efe86 14421 * sysdep.c (reset_io): Now static.
b8950c94 14422 (wait_for_termination_signal): Remove; unused.
604efe86 14423
38fc62d9
PE
14424 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14425 (copy_keymap_item, append_key, push_text_char_description):
14426 Now static.
1004a21a 14427 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14428 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14429 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14430 (describe_map_tree):
14431 Rename locals to avoid shadowing.
38fc62d9 14432
2f2650da
PE
14433 * keyboard.c: Declare functions static if they are not used elsewhere.
14434 (echo_char, echo_dash, cmd_error, top_level_2):
14435 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14436 (read_char, kbd_buffer_get_event, make_lispy_position):
14437 (make_lispy_event, make_lispy_movement, apply_modifiers):
14438 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14439 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14440 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14441 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14442 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14443
a053e86c 14444 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14445 (mark_kboards): Move decl here ...
14446 * alloc.c (mark_kboards): ... from here.
a053e86c 14447
4752793e
PE
14448 * lisp.h (force_auto_save_soon): New decl.
14449
74f10ca7 14450 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14451 (DEFINE_DUMMY_FUNCTION): New macro.
14452 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14453 Use it.
c03cd23f
PE
14454 (main): Add casts to avoid warnings
14455 if GCC considers string literals to be constants.
74f10ca7 14456
022e70d4
PE
14457 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14458
59d6fe83
PE
14459 * dbusbind.c: Pointer signedness fixes.
14460 (xd_signature, xd_append_arg, xd_initialize):
14461 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14462 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14463 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14464 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14465
78320123
PE
14466 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14467 if GCC considers string literals to be constants.
49cebcca 14468 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14469
35ac2a97
SM
144702011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14471
fb103ca9
SM
14472 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14473 (print_preprocess, print_object): New macro to fix last change.
14474
35ac2a97
SM
14475 * print.c (print_preprocess): Don't forget font objects.
14476
62973b41
JB
144772011-03-16 Juanma Barranquero <lekktu@gmail.com>
14478
14479 * emacs.c (USAGE3): Doc fixes.
14480
0e48bb22
AS
144812011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14482
14483 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14484 structure.
14485
7684e57b
JB
144862011-03-14 Juanma Barranquero <lekktu@gmail.com>
14487
14488 * lisp.h (VWindow_system, Qfile_name_history):
14489 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14490 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14491 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14492
14493 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14494 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14495
14496 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14497 * w32console.c (detect_input_pending, read_input_pending)
14498 (encode_terminal_code):
14499 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14500 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14501 (w32_system_caret_y, Qfile_name_history):
14502 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14503 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14504 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14505 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14506 * w32proc.c (Qlocal, report_file_error):
14507 * w32term.c (Vwindow_system, updating_frame):
14508 * w32uniscribe.c (initialized, uniscribe_font_driver):
14509 Remove unneeded extern declarations.
14510
2aa46d6c
CY
145112011-03-14 Chong Yidong <cyd@stupidchicken.com>
14512
c96bbc66 14513 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14514
cffc6f3b
CY
145152011-03-13 Chong Yidong <cyd@stupidchicken.com>
14516
14517 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14518 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14519 These macros can no longer be used for assignment.
14520
44f230aa
SM
14521 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14522 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14523 (record_buffer_markers, fetch_buffer_markers): New functions for
14524 recording and fetching special buffer markers.
14525 (set_buffer_internal_1, set_buffer_temp): Use them.
14526
14527 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14528
14529 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14530
14531 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14532 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14533
14534 * xdisp.c (hscroll_window_tree):
14535 (reconsider_clip_changes): Use PT instead of BUF_PT.
14536
d251f04b
EZ
145372011-03-13 Eli Zaretskii <eliz@gnu.org>
14538
14539 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14540 $(EMACS_ROOT)/lib/intprops.h.
14541
f0c77cd1
PE
145422011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14543
3eca4629
PE
14544 Fix more problems found by GCC 4.5.2's static checks.
14545
7c86ee98
PE
14546 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14547 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14548 (xg_free_frame_widgets): Make it clear that a local variable is
14549 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14550 (gdk_window_get_screen): Make it clear that this macro is needed
14551 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14552 (int_gtk_range_get_value): New function, which avoids a diagnostic
14553 from gcc -Wbad-function-cast.
14554 (xg_set_toolkit_scroll_bar_thumb): Use it.
14555 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14556 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14557 (get_utf8_string, xg_get_file_with_chooser):
14558 Rename locals to avoid shadowing.
14559 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14560
41729b81
PE
14561 * xgselect.c (xg_select): Remove unused var.
14562
f0c77cd1
PE
14563 * image.c (four_corners_best): Mark locals as initialized.
14564 (gif_load): Initialize transparent_p to zero (Bug#8238).
14565 Mark another local as initialized.
ec6cf4c6 14566 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14567
ce0ad53d 14568 * image.c (clear_image_cache): Now static.
d5d5a617 14569 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14570 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14571 (x_edge_detection): Remove unnecessary cast that
14572 gcc -Wbad-function-cast diagnoses.
2037898d 14573 (gif_load): Fix pointer signedness.
6ae141d6
PE
14574 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14575 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14576
33383987 145772011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14578
d32df629
PE
14579 Improve quality of tests for time stamp overflow.
14580 For example, without this patch (encode-time 0 0 0 1 1
14581 1152921504606846976) returns the obviously-bogus value (-948597
14582 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14583 reports time overflow. See
14584 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14585 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14586 * editfns.c: Include limits.h and intprops.h.
14587 (TIME_T_MIN, TIME_T_MAX): New macros.
14588 (time_overflow): Move earlier, to before first use.
14589 (hi_time, lo_time): New functions, for an accurate test for
14590 out-of-range times.
14591 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14592 (Fget_internal_run_time): Don't assume time_t fits in int.
14593 (make_time): Use list2 instead of Fcons twice.
14594 (Fdecode_time): More accurate test for out-of-range times.
14595 (check_tm_member): New function.
14596 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14597 (lisp_time_argument): Don't rely on undefined left-shift and
14598 right-shift behavior when checking for time stamp overflow.
8be6f318 14599
fe31d94c
PE
14600 * editfns.c (time_overflow): New function, refactoring common code.
14601 (Fformat_time_string, Fdecode_time, Fencode_time):
14602 (Fcurrent_time_string): Use it.
14603
8be6f318
PE
14604 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14605 * dired.c (make_time): Move to ...
14606 * editfns.c (make_time): ... here.
14607 * systime.h: Note the move.
14608
09d9db2c 146092011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14610
126bc0dc
YM
14611 * fringe.c (update_window_fringes): Remove unused variables.
14612
c47cbdfd
YM
14613 * unexmacosx.c (copy_data_segment): Also copy __got section.
14614 (Bug#8223)
14615
7ac80be9
EZ
146162011-03-12 Eli Zaretskii <eliz@gnu.org>
14617
c96bbc66 14618 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14619 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14620 Constify `char *' arguments and their references according to
14621 prototypes in tparam.h.
14622
ecb0f94d 14623 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14624
7ac80be9
EZ
14625 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14626 Adapt all references accordingly.
14627
14628 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14629
ef1fd07e
TT
146302011-03-11 Tom Tromey <tromey@redhat.com>
14631
14632 * buffer.c (syms_of_buffer): Remove obsolete comment.
14633
7ef4b50c
EZ
146342011-03-11 Eli Zaretskii <eliz@gnu.org>
14635
14636 * termhooks.h (encode_terminal_code): Declare prototype.
14637
14638 * msdos.c (encode_terminal_code): Don't declare prototype.
14639
14640 * term.c (encode_terminal_code): Now external again, used by
14641 w32console.c and msdos.c.
14642
44f230aa
SM
14643 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14644 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14645
4b1ec863 146462011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14647
1714f52b 14648 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14649
4b1ec863
PE
14650 * fringe.c (update_window_fringes): Mark locals as initialized
14651 (Bug#8227).
14652 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14653
524c7aa6
PE
14654 * alloc.c (mark_fringe_data): Move decl from here ...
14655 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14656 to check its interface.
14657 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14658
a5c0af81 14659 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14660 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14661 (fontset_font): Mark local as initialized.
a9a06e0b 14662 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14663
b4716021
PE
14664 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14665
811e9bac 14666 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14667 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14668 (x_own_selection, Fx_disown_selection_internal): Rename locals
14669 to avoid shadowing.
14670 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14671
7e3ab302
PE
14672 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14673 so that the caller can use some name other than gcpro1.
14674 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14675 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14676 (Fx_backspace_delete_keys_p):
14677 Use them to avoid shadowing, and rename vars to avoid shadowing.
14678 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14679 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14680 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14681 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14682 Remove unused locals.
7e3ab302
PE
14683 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14684 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14685 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14686 macros.
f78faa98 14687
e2b13473
PE
14688 * xterm.h (x_mouse_leave): New decl.
14689
77f23912
PE
14690 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14691 Remove unused functions.
cdf4ba58
PE
14692 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14693 (x_calc_absolute_position): Now static.
7411c686 14694 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14695 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14696 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14697 unless they are used.
38d0b34a
PE
14698 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14699 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14700 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14701 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14702 (x_error_catcher, x_connection_closed, x_error_handler):
14703 (x_error_quitter, xembed_send_message, x_iconify_frame):
14704 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14705 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14706 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14707
44f230aa
SM
14708 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14709 Rename or move locals to avoid shadowing.
6b463e58 14710 (tty_defined_color, merge_face_heights): Now static.
5967d051 14711 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14712 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14713 does not deduce is never used uninitialized.
73719eba
PE
14714 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14715 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14716
426994c3 14717 * terminal.c (store_terminal_param): Now static.
5489860b 14718
032f1620 14719 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14720 (set_frame_menubar): Remove unused local.
d4323972 14721 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14722 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14723 since they might point to immutable storage.
281585b0
PE
14724 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14725 since it's unused otherwise.
032f1620 14726
367c19e5 14727 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14728 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14729 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14730 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14731 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14732 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14733 does not deduce are never used uninitialized.
70739cbe 14734
07b48fa9
PE
14735 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14736
8868a238 14737 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14738 * window.c (window_loop, size_window):
14739 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14740
7e5cf297 14741 * window.c (display_buffer): Now static.
d6550a9f
PE
14742 (size_window): Mark variables that gcc -Wuninitialized
14743 does not deduce are never used uninitialized.
a586633d
PE
14744 * window.h (check_all_windows): New decl, to forestall
14745 gcc -Wmissing-prototypes diagnostic.
5b555da1 14746 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14747
f6095868
PE
14748 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14749 shadowing.
14750 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14751 Include <limits.h>.
14752 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14753 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14754 (load_charset_map): Mark variables that gcc -Wuninitialized
14755 does not deduce are never used uninitialized.
53df7c11 14756 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14757
f38b440c
PE
14758 * coding.c (coding_set_source, coding_set_destination):
14759 Use "else { /* comment */ }" rather than "else /* comment */;"
14760 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14761 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14762 a block, when the outer 'i' will do.
14763 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14764 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14765 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14766 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14767 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14768 Rename locals to avoid shadowing.
14769 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14770 * coding.c (emacs_mule_char, encode_invocation_designation):
14771 Now static, since they're not used elsewhere.
413bb2db 14772 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14773 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14774 (decode_coding_emacs_mule): Mark variables that gcc
14775 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14776 (detect_coding_iso_2022): Initialize a local variable that might
14777 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14778 this initialization is needed. (Bug#8211)
5f58e762
PE
14779 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14780 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14781 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14782 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14783 Remove unused macros.
f38b440c 14784
232b38b9 14785 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14786 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14787 * character.c (string_count_byte8): Likewise.
232b38b9 14788
fb90da1b
PE
14789 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14790 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14791
fb93dbc2
PE
14792 * chartab.c (copy_sub_char_table): Now static, since it's not used
14793 elsewhere.
5c156ace
PE
14794 (sub_char_table_ref_and_range, char_table_ref_and_range):
14795 Rename locals to avoid shadowing.
bbcd0949 14796 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14797
7d3b3862 14798 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14799 (BIDI_BOB): Remove unused macro.
7d3b3862 14800
6be7d3da
PE
14801 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14802 deduce are never used uninitialized.
c2ed9c8b 14803 * term.c (encode_terminal_code): Likewise.
6be7d3da 14804
75f8807f 14805 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14806
50938595
PE
14807 * tparam.h: New file.
14808 * term.c, tparam.h: Include it.
14809 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14810 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14811 Move these decls to tparam.h, and make them agree with what
14812 is actually in tparam.c. The previous trick of using incompatible
14813 decls in different modules does not conform to the C standard.
14814 All callers of tparam changed to use tparam's actual API.
14815 * tparam.c (tparam1, tparam, tgoto):
14816 Use const pointers where appropriate.
14817
fbceeba2
PE
14818 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14819 * cm.h (struct cm): Likewise.
14820 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14821 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14822 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14823 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14824 (turn_on_face, init_tty): Likewise.
14825 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14826
7f3f1250
PE
14827 * term.c (term_mouse_position): Rename local to avoid shadowing.
14828
e6ca6543
PE
14829 * alloc.c (mark_ttys): Move decl from here ...
14830 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14831
c40f8d15
AS
148322011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14833
14834 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14835
cfe0661d
JB
148362011-03-09 Juanma Barranquero <lekktu@gmail.com>
14837
14838 * search.c (compile_pattern_1): Remove argument regp, unused since
14839 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14840 (compile_pattern): Don't pass it.
14841
0afb4571
J
148422011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14843
14844 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14845 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14846 for ! HAVE_GTK3.
14847 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14848
14849 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14850
14851 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14852 gdk_window_get_screen, gdk_window_get_geometry,
14853 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14854 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14855 (xg_get_pixbuf_from_pixmap): New function.
14856 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14857 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14858 Call xg_get_pixbuf_from_pixmap instead of
14859 gdk_pixbuf_get_from_drawable.
14860 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14861 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14862 (xg_check_special_colors): Use GtkStyleContext and its functions
14863 for HAVE_GTK3.
14864 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14865 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14866 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14867 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14868 Call gtk_widget_get_preferred_size.
0afb4571
J
14869 (xg_frame_resized): gdk_window_get_geometry only takes 5
14870 parameters.
44f230aa
SM
14871 (xg_win_to_widget, xg_event_is_for_menubar):
14872 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14873 (xg_set_widget_bg): New function.
14874 (delete_cb): New function.
895009e1 14875 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14876 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14877 (xg_set_background_color): Call xg_set_widget_bg.
14878 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14879 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14880 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14881 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14882 if ! HAVE_GTK3.
14883 (update_frame_tool_bar): Call gtk_widget_hide.
14884 (xg_initialize): Use GDK_KEY_g.
14885
14886 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14887 if ! HAVE_GTK3
14888 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14889
14890 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14891 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14892 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14893
1c2cc4ef
JB
148942011-03-08 Juanma Barranquero <lekktu@gmail.com>
14895
14896 * w32xfns.c (select_palette): Check success of RealizePalette against
14897 GDI_ERROR, not zero.
14898
33383987 14899See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14900
14901;; Local Variables:
14902;; coding: utf-8
aac0c6e3
MR
14903;; End:
14904
2f097256 14905 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14906
14907 This file is part of GNU Emacs.
14908
14909 GNU Emacs is free software: you can redistribute it and/or modify
14910 it under the terms of the GNU General Public License as published by
14911 the Free Software Foundation, either version 3 of the License, or
14912 (at your option) any later version.
14913
14914 GNU Emacs is distributed in the hope that it will be useful,
14915 but WITHOUT ANY WARRANTY; without even the implied warranty of
14916 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14917 GNU General Public License for more details.
14918
14919 You should have received a copy of the GNU General Public License
14920 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.