* frame.h (struct frame): Use int for menu_bar_items_used
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d89eb65e
PE
12011-05-12 Paul Eggert <eggert@cs.ucla.edu>
2
3e26f69c
PE
3 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4 that always fit in int. Use a sentinel instead of a counter, to
5 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6 * frame.h (struct frame): Use int for menu_bar_items_used
7 instead of EMACS_INT, since it always fits in int.
3e26f69c 8
5cc152c0
PE
9 * menu.c (grow_menu_items): Check for int overflow.
10
d89eb65e
PE
11 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12
78eb494e
PE
132011-05-11 Paul Eggert <eggert@cs.ucla.edu>
14
5235bd3e
PE
15 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
16 Before, the code was not consistent. These values cannot exceed
17 2**31 - 1 so there's no need to make them unsigned.
18 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
19 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
20 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
21 as modifiers.
22 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
23
bc827e23
PE
24 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
25 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
26 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
27 presumably because the widths might not match.
28
78eb494e
PE
29 * window.c (size_window): Avoid needless test at loop start.
30
2f142cc5
JB
312011-05-10 Juanma Barranquero <lekktu@gmail.com>
32
33 * image.c (Finit_image_library): Return t for built-in image types,
34 like pbm and xbm. (Bug#8640)
35
57679c86
AS
362011-05-09 Andreas Schwab <schwab@linux-m68k.org>
37
38 * w32menu.c (set_frame_menubar): Fix submenu allocation.
39
888c9e86
EZ
402011-05-07 Eli Zaretskii <eliz@gnu.org>
41
b0512a1d
EZ
42 * w32console.c (Fset_screen_color): Doc fix.
43 (Fget_screen_color): New function.
44 (syms_of_ntterm): Defsubr it.
45
888c9e86
EZ
46 * callproc.c (call_process_cleanup): Don't close and unlink the
47 temporary file if Fcall_process didn't create it in the first
48 place.
49 (Fcall_process): Don't create tempfile if stdout of the child
50 process will be redirected to a file specified with `:file'.
51 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
52 cue to call_process_cleanup not to close that handle.
53
4d3fcc8e
BK
542011-05-07 Ben Key <bkey76@gmail.com>
55
56 * makefile.w32-in: The bootstrap-temacs rule now makes use of
57 one of two shell specific rules, either bootstrap-temacs-CMD or
58 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
59 to the previous implementation of the bootstrap-temacs rule.
60 The bootstrap-temacs-CMD rule is similar to the previous
61 implementation of the bootstrap-temacs rule except that it
62 makes use of the ESC_CFLAGS variable instead of the CFLAGS
63 variable.
64
65 These changes, along with some changes to nt/configure.bat,
66 nt/gmake.defs, and nt/nmake.defs, are required to extend my
67 earlier fix to add support for --cflags and --ldflags options
68 that include quotes so that it works whether make uses cmd or
69 sh as the shell.
70
b4289b64
MA
712011-05-06 Michael Albinus <michael.albinus@gmx.de>
72
73 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
74 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
75 is a constant.
76 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
77 a string. Handle both cases.
78 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
79 (Fdbus_register_method): Use Qinvalid_function.
80
af4c0e28
JB
812011-05-06 Juanma Barranquero <lekktu@gmail.com>
82
83 * makefile.w32-in: Update dependencies.
84 (LISP_H): Add inttypes.h and stdin.h.
85 (PROCESS_H): Add unistd.h.
86
c51453d9
EZ
872011-05-06 Eli Zaretskii <eliz@gnu.org>
88
89 * lread.c: Include limits.h (fixes the MS-Windows build broken by
90 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
91
8ff0ac3c 922011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 93
4c4b566b
PE
94 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
95
aab2b9b5
PE
96 * term.c (vfatal): Remove stray call to va_end.
97 It's not needed and the C Standard doesn't allow it here anyway.
98
c378da0b
PE
99 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
100 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
101
288b08c7
PE
102 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
103 bytes.
104
e3601888
PE
105 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
106
db6c0e74
PE
107 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
108
dd5963ea
PE
109 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
110
88c9450f
PE
111 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
112
2f9442b8
PE
113 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
114
c032b5f8
PE
115 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
116 * charset.c (Fdefine_charset_internal): Don't initialize
117 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 118 32-bit int (Bug#8600).
a108c10b
PE
119
120 * lread.c (read_integer): Be more consistent with string-to-number.
121 Use string_to_number to do the actual conversion; this avoids
122 rounding errors and fixes some other screwups. Without this fix,
123 for example, #x1fffffffffffffff was misread as -2305843009213693952.
124 (digit_to_number): Move earlier, for benefit of read_integer.
125 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 126 not a digit in any supported base. (Bug#8602)
a108c10b 127
ad5f9eea
PE
128 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
129
aec1708a
PE
130 * dispnew.c (scrolling_window): Return 1 if we scrolled,
131 to match comment at start of function. This also removes a
132 GCC warning about overflow in a 32+64-bit port.
133
47be4ab5
PE
134 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
135
371cac43
PE
136 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
137 Reported by Stefan Monnier in
138 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
139 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
140 SYMBOLP-guarded XSYMBOL, not XPNTR.
141
d01a7826
PE
142 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
143 (EMACS_UINTPTR): Likewise, with uintptr_t.
144
7fd47d5c
PE
145 * lisp.h: Prefer 64-bit EMACS_INT if available.
146 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
147 on 32-bit hosts that have 64-bit int, so that they can access
148 large files.
122b0c86
PE
149 However, temporarily disable this change unless the temporary
150 symbol WIDE_EMACS_INT is defined.
7fd47d5c 151
8727937b
PE
152 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
153
8ac068ac
PE
154 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
155 This removes an assumption that EMACS_INT and long are the same
156 width as pointers. The assumption is true for Emacs porting targets
157 now, but we want to make other targets possible.
158 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
159 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
160 In the rest of the code, change types of integers that hold casted
161 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
162 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
163 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
164 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
165 No need to cast type when ORing.
166 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
167 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
168 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
169 assume EMACS_INT is the same width as char *.
170 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
171 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
172 Remove no-longer-needed casts.
173 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
174 (xg_tool_bar_help_callback, xg_make_tool_item):
175 Use EMACS_INTPTR to hold an integer
176 that will be cast to void *; this can avoid a GCC warning
177 if EMACS_INT is not the same width as void *.
178 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
179 * xdisp.c (display_echo_area_1, resize_mini_window_1):
180 (current_message_1, set_message_1):
181 Use a local to convert to proper width without a cast.
182 * xmenu.c (dialog_selection_callback): Likewise.
183
ede49d71
PE
184 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
185 Also, don't assume VALBITS / RAND_BITS is less than 5,
186 and don't rely on undefined behavior when shifting a 1 left into
187 the sign bit.
188 * lisp.h (get_random): Change signature to match.
189
2f30ecd0
PE
190 * lread.c (hash_string): Use size_t, not int, for hash computation.
191 Normally we prefer signed values; but hashing is special, because
192 it's better to use unsigned division on hash table sizes so that
193 the remainder is nonnegative. Also, size_t is the natural width
194 for hashing into memory. The previous code used 'int', which doesn't
195 retain enough info to hash well into very large tables.
196 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
197
2a866e7b
PE
198 * dbusbind.c: Don't possibly lose pointer info when converting.
199 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
200 Use XPNTR rather than XHASH, so that the high-order bits of
201 the pointer aren't lost when converting through void *.
202
51639eac
PE
203 * eval.c (Fautoload): Don't double-shift a pointer.
204
92394119
PE
205 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
206
dbdb9a7c
JB
2072011-05-06 Juanma Barranquero <lekktu@gmail.com>
208
209 * gnutls.c (DEF_GNUTLS_FN):
210 * image.c (DEF_IMGLIB_FN): Make function pointers static.
211
db7a0b4f
AS
2122011-05-05 Andreas Schwab <schwab@linux-m68k.org>
213
214 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
215 marker. (Bug#8610)
216
f7ff1b0f 2172011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
218
219 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
220 New version that can reserve upto 2GB of heap space.
221
f7ff1b0f 2222011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
223
224 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
225
639c109b
TZ
2262011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
227
228 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
229 `gnutls_certificate_set_x509_key_file'.
230
d2127135
JB
2312011-05-05 Juanma Barranquero <lekktu@gmail.com>
232
233 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
234 Update dependencies.
235
e968f4f3
JB
2362011-05-04 Juanma Barranquero <lekktu@gmail.com>
237
238 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
239 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
240 Remove unused parameter `fildes'.
241 * process.c (read_process_output, send_process): Don't pass it.
242
84d358f0
JB
2432011-05-04 Juanma Barranquero <lekktu@gmail.com>
244
245 Fix previous change: the library cache is defined in w32.c.
246 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
247 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
248
0898ca10
JB
2492011-05-04 Juanma Barranquero <lekktu@gmail.com>
250
251 Implement dynamic loading of GnuTLS on Windows.
252
253 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
254 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
255 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
256 Declare.
257
258 * gnutls.c (Qgnutls_dll): Define.
259 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
260 (gnutls_*): Declare function pointers.
261 (init_gnutls_functions): New function to initialize function pointers.
262 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
263 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
264 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
265 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
266 (emacs_gnutls_write, emacs_gnutls_read)
267 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
268 (Fgnutls_available_p): New function.
269 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
270 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
271 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
272
273 * image.c: Include w32.h.
274 (Vimage_type_cache): Delete.
275 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
276 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
277 (w32_delayed_load): Move to w32.c.
278
279 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
280
281 * w32.c (QCloaded_from, Vlibrary_cache): Define.
282 (w32_delayed_load): Move from image.c. When loading a library, record
283 its filename in the :loaded-from property of the library id.
284 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
285 Initialize and staticpro them.
286 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
287
288 * process.c: Include lisp.h before w32.h, not after.
289 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
290 instead of gnutls_record_check_pending.
291
292 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
293
ff4de4aa
TZ
2942011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
295
296 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
297 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
298 as passed in.
299
abe95abb
JD
3002011-05-03 Jan Djärv <jan.h.d@swipnet.se>
301
302 * xterm.c (x_set_frame_alpha): Do not set property on anything
303 else than FRAME_X_OUTER_WINDOW (Bug#8608).
304
e16e55d4
JB
3052011-05-02 Juanma Barranquero <lekktu@gmail.com>
306
307 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
308
bafcf6a5
JB
3092011-05-02 Juanma Barranquero <lekktu@gmail.com>
310
311 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
312 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
313 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
314 (gnutls_global_initialized, Qgnutls_bootprop_priority)
315 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
316 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
317 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
318 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
319 (Qgnutls_bootprop_callbacks_verify): Make static.
320
e7a6747f
AS
3212011-05-01 Andreas Schwab <schwab@linux-m68k.org>
322
19ed11ba
AS
323 * callproc.c: Indentation fixup.
324
e7a6747f
AS
325 * sysdep.c (wait_for_termination_1): Make static.
326 (wait_for_termination, interruptible_wait_for_termination): Move
327 after wait_for_termination_1.
328
1ef14cb4
LMI
3292011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
330
331 * sysdep.c (interruptible_wait_for_termination): New function
332 which is like wait_for_termination, but allows keyboard
333 interruptions.
334
335 * callproc.c (Fcall_process): Add (:file "file") as an option for
336 the STDOUT buffer.
337 (Fcall_process_region): Ditto.
338
330d880c
EZ
3392011-04-30 Eli Zaretskii <eliz@gnu.org>
340
8db90b73
EZ
341 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
342 rather than `XVECTOR (FOO)->size'.
343
330d880c
EZ
344 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
345 inttypes.h, as a gnulib replacement is used if it not available in
346 system headers.
347
15cbd324
EZ
3482011-04-21 Eli Zaretskii <eliz@gnu.org>
349
350 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
351 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
352 of MOST_POSITIVE_FIXNUM. (Bug#8528)
353
354 * coding.c (coding_alloc_by_realloc): Error out if destination
355 will grow beyond MOST_POSITIVE_FIXNUM.
356 (decode_coding_emacs_mule): Abort if there isn't enough place in
357 charbuf for the composition carryover bytes. Reserve an extra
358 space for up to 2 characters produced in a loop.
359 (decode_coding_iso_2022): Abort if there isn't enough place in
360 charbuf for the composition carryover bytes.
361
3622011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 363
ae940cca
EZ
364 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
365 aborting when %lld or %lll format is passed.
366 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
367 %llo or %llx format is passed. (Bug#8545)
368
03ab8921
EZ
369 * window.c (window_scroll_line_based): Use a marker instead of
370 simple variables to record original value of point. (Bug#7952)
371
afda1437
EZ
372 * doprnt.c (doprnt): Fix the case where a multibyte sequence
373 produced by %s or %c overflows available buffer space. (Bug#8545)
374
f76dee0c
PE
3752011-04-28 Paul Eggert <eggert@cs.ucla.edu>
376
377 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 378 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 379
fdc5744d
JB
3802011-04-28 Juanma Barranquero <lekktu@gmail.com>
381
382 * w32.c (init_environment): Warn about defaulting HOME to C:\.
383
638f053a
JB
3842011-04-28 Juanma Barranquero <lekktu@gmail.com>
385
386 * keyboard.c (Qdelayed_warnings_hook): Define.
387 (command_loop_1): Run `delayed-warnings-hook'
388 if Vdelayed_warnings_list is non-nil.
389 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
390 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
391
d178f871
EZ
3922011-04-28 Eli Zaretskii <eliz@gnu.org>
393
394 * doprnt.c (doprnt): Don't return value smaller than the buffer
395 size if the message was truncated. (Bug#8545).
396
b124fd93
JB
3972011-04-28 Juanma Barranquero <lekktu@gmail.com>
398
399 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
400 (Fx_window_property): #if-0 the whole functions, not just the bodies.
401
e810457d
PE
4022011-04-27 Paul Eggert <eggert@cs.ucla.edu>
403
404 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
405
ea51cceb
JB
4062011-04-27 Juanma Barranquero <lekktu@gmail.com>
407
408 * makefile.w32-in: Update dependencies.
409
94dcfacf
EZ
4102011-04-27 Eli Zaretskii <eliz@gnu.org>
411
412 Improve `doprnt' and its usage. (Bug#8545)
413 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
414 `format_end'. Remove support for %l as a conversion specifier.
415 Don't use xrealloc. Improve diagnostics when the %l size modifier
416 is used. Update the commentary.
417
418 * eval.c (verror): Simplify calculation of size_t.
419
420 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
421 messages.
422
f61f41d7
PE
4232011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
424
425 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
426 change.
427
96fb4434
PE
4282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
429
430 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
431 This makes this file independent of the recent pseudovector change.
432
671875da 4332011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 434
69e9b5a3
PE
435 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
436
b5f869a7 437 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 438 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 439 Remove unused local.
c8926152 440 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 441
841a1577 442 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
443 GCC 4.6.0 optimizes based on type-based alias analysis. For
444 example, if b is of type struct buffer * and v of type struct
445 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
446 != &v->size, and therefore "v->size = 1; b->size = 2; return
447 v->size;" must therefore return 1. This assumption is incorrect
448 for Emacs, since it type-puns struct Lisp_Vector * with many other
449 types. To fix this problem, this patch adds a new type struct
f904488f 450 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
451 and pseudovectors, and helps optimizing compilers not get fooled
452 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
453 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
454 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
455 the size member.
eab3844f
PE
456 (XSETPVECTYPE): Rewrite in terms of new macro.
457 (XSETPVECTYPESIZE): New macro, specifying both type and size.
458 This is a bit clearer, and further avoids the possibility of
459 undesirable aliasing.
460 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 461 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
462 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
463 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
464 (ASIZE): Now uses header.size rather than size. All
465 previous uses of XVECTOR (foo)->size replaced to use this macro,
466 to avoid the hassle of writing XVECTOR (foo)->header.size.
467 (struct vectorlike_header): New type.
eab3844f
PE
468 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
469 object, to help avoid aliasing.
470 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
471 (SUBRP): Likewise, since Lisp_Subr is a special case.
472 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
473 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
474 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 475 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
476 changed to be "header.size" and "header.next".
477 * buffer.h (struct buffer): Likewise.
478 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
479 * frame.h (struct frame): Likewise.
480 * process.h (struct Lisp_Process): Likewise.
481 * termhooks.h (struct terminal): Likewise.
482 * window.c (struct save_window_data, struct saved_window): Likewise.
483 * window.h (struct window): Likewise.
484 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
485 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
486 * buffer.c (init_buffer_once): Likewise.
487 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
488 special case.
489 * process.c (Fformat_network_address): Use local var for size,
490 for brevity.
491
0df1eac5
PE
492 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
493
847ab9d1 494 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
495 * data.c (atof): Remove decl; no longer used or needed.
496 (digit_to_number): Move to lread.c.
497 (Fstring_to_number): Use new string_to_number function, to be
498 consistent with how the Lisp reader treats infinities and NaNs.
499 Do not assume that floating-point numbers represent EMACS_INT
500 without losing information; this is not true on most 64-bit hosts.
501 Avoid double-rounding errors, by insisting on integers when
502 parsing non-base-10 numbers, as the documentation specifies.
503 * lisp.h (string_to_number): New decl, replacing ...
504 (isfloat_string): Remove.
bc0a5c13 505 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 506 (read1): Do not accept +. and -. as integers; this
452f4150
PE
507 appears to have been a coding error. Similarly, do not accept
508 strings like +-1e0 as floating point numbers. Do not report
509 overflow for integer overflows unless the base is not 10 which
510 means we have no simple and reliable way to continue.
511 Break out the floating-point parsing into a new
512 function string_to_number, so that Fstring_to_number parses
513 floating point numbers consistently with the Lisp reader.
514 (digit_to_number): Moved here from data.c. Make it static inline.
515 (E_CHAR, EXP_INT): Remove, replacing with ...
516 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
517 (string_to_number): New function, replacing isfloat_string.
518 This function checks for valid syntax and produces the resulting
519 Lisp float number too. Rework it so that string-to-number
bc0a5c13 520 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
521 so that overflow for non-base-10 numbers is reported only when
522 there's no portable and simple way to convert to floating point.
452f4150 523
67769ffc
PE
524 * textprop.c (set_text_properties_1): Rewrite for clarity,
525 and to avoid GCC warning about integer overflow.
526
c20db43f
PE
527 * intervals.h (struct interval): Use EMACS_INT for members
528 where EMACS_UINT might cause problems. See
529 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
530 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
531 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
532 All uses changed.
37aa2f85
PE
533 (offset_intervals): Tell GCC not to worry about length overflow
534 when negating a negative length.
c20db43f 535
2538aa2f
PE
536 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
537 (overrun_check_free): Likewise.
538
f2d3008d
PE
539 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
540 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
541 word size.
542
ec8df744
PE
543 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
544 (gnutls_make_error): Rename local to avoid shadowing.
545 (gnutls_emacs_global_deinit): ifdef out; not used.
546 (Fgnutls_boot): Use const for pointer to readonly storage.
547 Comment out unused local. Fix pointer signedness problems.
548
640ee02d
PE
549 * lread.c (openp): Don't stuff size_t into an 'int'.
550 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
551 about possible signed overflow.
552
6048fb2a
PE
553 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
554 (GDK_KEY_g): Don't define if already defined.
555 (xg_prepare_tooltip): Avoid pointer signedness problem.
556 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
557
fa3c87e1
PE
558 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
559 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
560
2172544b
PE
561 * xfns.c (Fx_window_property): Simplify a bit,
562 to make a bit faster and to avoid GCC 4.6.0 warning.
563 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
564
9b821a21
PE
565 * fns.c (internal_equal): Don't assume size_t fits in int.
566
3c616cfa
PE
567 * alloc.c (compact_small_strings): Tighten assertion a little.
568
c2982e87
PE
569 Replace pEd with more-general pI, and fix some printf arg casts.
570 * lisp.h (pI): New macro, generalizing old pEd macro to other
571 conversion specifiers. For example, use "...%"pI"d..." rather
572 than "...%"pEd"...".
573 (pEd): Remove. All uses replaced with similar uses of pI.
574 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
575 * alloc.c (check_pure_size): Don't overflow by converting size to int.
576 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
577 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
578 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
579 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
580 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
581 64-bit hosts.
582 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
583 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
584 * print.c (safe_debug_print, print_object): Likewise.
585 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
586 to int.
6f04d126
PE
587 Use pI instead of if-then-else-abort. Use %p to avoid casts,
588 avoiding the 0 flag, which is not portable.
c2982e87
PE
589 * process.c (Fmake_network_process): Use pI to avoid cast.
590 * region-cache.c (pp_cache): Likewise.
591 * xdisp.c (decode_mode_spec): Likewise.
592 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
593 behavior on 64-bit hosts with printf arg.
6f04d126 594 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
595 (x_stop_queuing_selection_requests): Likewise.
596 (x_get_window_property): Don't truncate byte count to an 'int'
597 when tracing.
0b432f21 598
5e073ec7
PE
599 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
600 here, since it parses constructs like leading '-' and spaces,
601 which are not wanted; and it overflows with large numbers.
602 Instead, simply match F[0-9]+, which is what is wanted anyway.
603
36372bf9
PE
604 * alloc.c: Remove unportable assumptions about struct layout.
605 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
606 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
607 (allocate_vectorlike, make_pure_vector): Use the new macros,
608 plus offsetof, to remove unportable assumptions about struct layout.
609 These assumptions hold on all porting targets that I know of, but
610 they are not guaranteed, they're easy to remove, and removing them
611 makes further changes easier.
612
0b432f21
PE
613 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
614 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
615 (string_overrun_cookie): Now const. Use initializers that
616 don't formally overflow signed char, to avoid warnings.
000098c1
PE
617 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
618 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
619 (allocate_buffer): Don't assume sizeof (struct buffer) is a
620 multiple of sizeof (EMACS_INT); it need not be, if
621 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 622 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 623
895009e1
JB
6242011-04-26 Juanma Barranquero <lekktu@gmail.com>
625
626 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
627
6a7a1b0b
TZ
6282011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
629
630 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 631 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
632 Reported by Paul Eggert <eggert@cs.ucla.edu>.
633
841a1577 6342011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
635
636 * lisp.h (Qdebug): List symbol.
895009e1 637 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
638 * keyboard.c (debug-on-event): New variable.
639 (handle_user_signal): Break into debugger when debug-on-event
640 matches the current signal symbol.
641
f2d3ba6f
DN
6422011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
643
644 * alloc.c (check_sblock, check_string_bytes)
645 (check_string_free_list): Convert to standard C.
646
42ce4c63
TZ
6472011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
648
649 * w32.c (emacs_gnutls_push): Fix typo.
650
825cd63c
EZ
6512011-04-25 Eli Zaretskii <eliz@gnu.org>
652
fb11d64d
EZ
653 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
654 "cast to pointer from integer of different size".
655
825cd63c
EZ
656 Improve doprnt and its use in verror. (Bug#8545)
657 * doprnt.c (doprnt): Document the set of format control sequences
658 supported by the function. Use SAFE_ALLOCA instead of always
659 using `alloca'.
660
661 * eval.c (verror): Don't limit the buffer size at size_max-1, that
662 is one byte too soon. Don't use xrealloc; instead xfree and
663 xmalloc anew.
664
e061a11b
TZ
6652011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
666
667 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
668 callbacks stage.
669
670 * gnutls.c: Renamed global_initialized to
671 gnutls_global_initialized. Added internals for the
672 :verify-hostname-error, :verify-error, and :verify-flags
673 parameters of `gnutls-boot' and documented those parameters in the
674 docstring. Start callback support.
675 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
676 unless a fatal error occured. Call gnutls_alert_send_appropriate
677 on error. Return error code.
678 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
679 (emacs_gnutls_read): Likewise.
680 (Fgnutls_boot): Return handshake error code.
681 (emacs_gnutls_handle_error): New function.
682 (wsaerror_to_errno): Likewise.
683
684 * w32.h (emacs_gnutls_pull): Add prototype.
685 (emacs_gnutls_push): Likewise.
686
687 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
688 (emacs_gnutls_push): Likewise.
689
6902011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
691
692 * process.c (wait_reading_process_output): Check if GnuTLS
693 buffered some data internally if no FDs are set for TLS
694 connections.
695
696 * makefile.w32-in (OBJ2): Add gnutls.$(O).
697 (LIBS): Link to USER_LIBS.
698 ($(BLD)/gnutls.$(0)): New target.
699
fa6996bc
EZ
7002011-04-24 Eli Zaretskii <eliz@gnu.org>
701
eb35682e
EZ
702 * xdisp.c (handle_single_display_spec): Rename the
703 display_replaced_before_p argument into display_replaced_p, to
704 make it consistent with the commentary. Fix typos in the
705 commentary.
706
e2ad650c
EZ
707 * textprop.c (syms_of_textprop): Remove dead code.
708 (copy_text_properties): Delete obsolete commentary about an
709 interface that was deleted long ago. Fix typos in the description
710 of arguments.
711
1b2de274
EZ
712 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
713 to changes in oldXMenu/XMenu.h from 2011-04-16.
714 <menu_help_message, prev_menu_help_message>: Constify.
715 (IT_menu_make_room): menu->help_text is now `const char **';
716 adjust.
717
718 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
719 to changes in oldXMenu/XMenu.h from 2011-04-16.
720 (struct XMenu): Declare `help_text' `const char **'.
721
722 * xfaces.c <Qunspecified>: Make extern again.
723
724 * syntax.c: Include sys/types.h before including regex.h, as
725 required by Posix.
726
762b15be
EZ
727 * doc.c (get_doc_string): Improve the format passed to `error'.
728
729 * doprnt.c (doprnt): Improve commentary.
730
731 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
732
733 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
734 them with etags.
735
f1052e5d
EZ
736 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
737 changes in globals.h immediately force recompilation.
762b15be
EZ
738 (TAGS): Depend on $(CURDIR)/m/intel386.h and
739 $(CURDIR)/s/ms-w32.h.
740 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 741
fa6996bc
EZ
742 * character.c (Fchar_direction): Function deleted.
743 (syms_of_character): Don't defsubr it.
744 <char-direction-table>: Deleted.
745
e6c3da20
EZ
7462011-04-23 Eli Zaretskii <eliz@gnu.org>
747
748 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
749 * doprnt.c: Include limits.h.
750 (SIZE_MAX): New macro.
751 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
752 local variables are now size_t instead of int or unsigned.
753 Improve overflow protection. Support `l' modifier for integer
754 conversions. Support %l conversion. Don't assume an EMACS_INT
755 argument for integer conversions and for %c.
756
757 * lisp.h (doprnt): Restore prototype.
758
759 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
760 $(SRC)/character.h.
761
762 * Makefile.in (base_obj): Add back doprnt.o.
763
764 * deps.mk (doprnt.o): Add back prerequisites.
765 (callint.o): Depend on character.h.
766
767 * eval.c (internal_lisp_condition_case): Include the handler
768 representation in the error message.
769 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
770 when breaking from the loop.
771
772 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
773
774 * callint.c (Fcall_interactively): When displaying error message
775 about invalid control letter, pass the character's codepoint, not
776 a pointer to its multibyte form. Improve display of the character
777 in octal and display also its hex code.
778
779 * character.c (char_string): Use %x to display the (unsigned)
780 codepoint of an invalid character, to avoid displaying a bogus
781 negative value.
782
783 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
784 `error', not SYMBOL_NAME itself.
785
786 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
787 character arguments to `error'.
788
789 * charset.c (check_iso_charset_parameter): Fix incorrect argument
790 to `error' in error message about FINAL_CHAR argument. Make sure
791 FINAL_CHAR is a character, and use %c when it is passed as
792 argument to `error'.
793
4ffd0d6b 7942011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
795
796 * s/ms-w32.h (localtime): Redirect to sys_localtime.
797
798 * w32.c: Include <time.h>.
799 (sys_localtime): New function.
800
4ffd0d6b 8012011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
802
803 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
804
4ffd0d6b 805 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 806
4ffd0d6b 8072011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 808
4ffd0d6b
GM
809 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
810 zombies (Bug#8467).
aac0c6e3 811
04c56954
EZ
8122011-04-19 Eli Zaretskii <eliz@gnu.org>
813
814 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
815 gl_state.e_property when gl_state.object is Qt.
816
817 * insdel.c (make_gap_larger): Remove limitation of buffer size
818 to <= INT_MAX.
819
16a43933
CY
8202011-04-18 Chong Yidong <cyd@stupidchicken.com>
821
822 * xdisp.c (lookup_glyphless_char_display)
823 (produce_glyphless_glyph): Handle cons cell entry in
824 glyphless-char-display.
825 (Vglyphless_char_display): Document it.
826
827 * term.c (produce_glyphless_glyph): Handle cons cell entry in
828 glyphless-char-display.
829
4581706e
CY
8302011-04-17 Chong Yidong <cyd@stupidchicken.com>
831
832 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
833
834 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
835
836 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
837 definition for no-X builds.
838
4887c6e2 8392011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 840
fd35b6f9
PE
841 Static checks with GCC 4.6.0 and non-default toolkits.
842
5c1ccb01
PE
843 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
844
006c5daa
PE
845 * process.c (keyboard_bit_set): Define only if SIGIO.
846 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
847 (send_process): Repair possible setjmp clobbering.
848
efc736d3
PE
849 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
850
4e2fe2e6
PE
851 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
852
f97334a2
PE
853 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
854
4e75f29d
PE
855 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
856 Define only if needed.
857
90efadd1
PE
858 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
859 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 860 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 861
3c647824
PE
862 * dispextern.h (struct redisplay_interface): Rename param
863 to avoid shadowing.
e264f262 864 * termhooks.h (struct terminal): Likewise.
761383f4 865 * xterm.c (xembed_send_message): Likewise.
3c647824 866
b58c5c4a
PE
867 * insdel.c (make_gap_smaller): Define only if
868 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
869
cad59032
PE
870 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
871 it.
872
c339dc2e
PE
873 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
874 so that we aren't warned about unused symbols.
875
91a3e27b
PE
876 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
877
399c71d3 878 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 879
8ffc96f5
PE
880 * xfns.c (x_real_positions): Mark locals as initialized.
881
eef9bc79
PE
882 * xmenu.c (xmenu_show): Don't use uninitialized vars.
883
098db9dd
PE
884 * xterm.c: Fix problems found by static analysis with other toolkits.
885 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
886 (x_dispatch_event): Declare static if USE_GTK, and
887 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 888 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 889 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
890 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
891 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 892
eb18f6cc
PE
893 * xmenu.c (menu_help_callback): Pointer type fixes.
894 Use const pointers when pointing at readonly data. Avoid pointer
895 signedness clashes.
896 (FALSE): Remove unused macro.
897 (update_frame_menubar): Remove unused decl.
898
1fe72bf8
PE
899 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
900
60d9e1db
PE
901 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
902 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
903 (single_menu_item): Rename local to avoid shadowing.
904
39261c26
PE
905 * keyboard.c (make_lispy_event): Remove unused local var.
906
018c5e19
PE
907 * frame.c, frame.h (x_get_resource_string): Bring this back, but
908 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
909
63d2b86e
PE
910 * bitmaps: Change bitmaps from unsigned char back to the X11
911 compatible char. Avoid the old compiler warnings about
912 out-of-range initializers by using, for example, '\xab' rather
913 than 0xab.
914
aefd87e1
PE
915 * xgselect.c (xgselect_initialize): Check vs interface
916 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
917
bf501fb9
PE
918 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
919
e9829fdf
PE
920 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
921 to read-only memory.
922
1086c095
PE
923 * fns.c (vector): Remove; this old hack is no longer needed.
924
2baccd04 925 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 926 Remove unused var.
dde42981 927 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 928
72391843 929 * xrdb.c (x_load_resources): Omit unused local.
3565b346 930
436c16df 931 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 932 (x_window): Rename locals to avoid shadowing.
dc5ddd85 933 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 934
92bb796d 935 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 936 (x_term_init): Remove local to avoid shadowing.
92bb796d 937
764430a3 938 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
939
940 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
941 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
942
d1dfb56c
EZ
9432011-04-16 Eli Zaretskii <eliz@gnu.org>
944
c4354cb4
EZ
945 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
946
d1dfb56c
EZ
947 Fix regex.c, syntax.c and friends for buffers > 2GB.
948 * syntax.h (struct gl_state_s): Declare character position members
949 EMACS_INT.
950
951 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
952
953 * textprop.c (verify_interval_modification, interval_of): Declare
954 arguments EMACS_INT.
955
956 * intervals.c (adjust_intervals_for_insertion): Declare arguments
957 EMACS_INT.
958
959 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
960
961 * indent.c (Fvertical_motion): Local variable it_start is now
962 EMACS_INT.
963
964 * regex.c (re_match, re_match_2, re_match_2_internal)
965 (bcmp_translate, regcomp, regexec, print_double_string)
966 (group_in_compile_stack, re_search, re_search_2, regex_compile)
967 (re_compile_pattern, re_exec): Declare arguments and local
968 variables `size_t' and `ssize_t' and return values `regoff_t', as
969 appropriate.
970 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
971 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
972 <compile_stack_type>: `size' and `avail' are now `size_t'.
973
974 * regex.h <regoff_t>: Use ssize_t, not int.
975 (re_search, re_search_2, re_match, re_match_2): Arguments that
976 specify buffer/string position and length are now ssize_t and
977 size_t. Return type is regoff_t.
978
613052cd
BK
9792011-04-16 Ben Key <bkey76@gmail.com>
980
981 * nsfont.m: Fixed bugs in ns_get_family and
982 ns_descriptor_to_entity that were caused by using free to
983 deallocate memory blocks that were allocated by xmalloc (via
984 xstrdup). This caused Emacs to crash when compiled with
985 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
986 --enable-checking=xmallocoverrun). xfree is now used to
987 deallocate these memory blocks.
988
4170f62f 9892011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 990
71b41406
PE
991 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
992
9587a89d
PE
993 emacs_write: Accept and return EMACS_INT for sizes.
994 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
995 et seq.
996 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
997 Accept and return EMACS_INT.
998 (emacs_gnutls_write): Return the number of bytes written on
999 partial writes.
1000 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1001 (emacs_read, emacs_write): Remove check for negative size, as the
1002 Emacs source code has been audited now.
9587a89d
PE
1003 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1004 (emacs_read, emacs_write): Use it.
273a5f82
PE
1005 * process.c (send_process): Adjust to the new signatures of
1006 emacs_write and emacs_gnutls_write. Do not attempt to store
1007 a byte offset into an 'int'; it might overflow.
9587a89d 1008 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1009
3e047f51
PE
1010 * sound.c: Don't assume sizes fit in 'int'.
1011 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1012 Return EMACS_INT, not int.
3e047f51 1013 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1014 Accept EMACS_INT, not int.
1015 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1016 record read return values.
1017
cc39a9db
BK
10182011-04-15 Ben Key <bkey76@gmail.com>
1019
c9d0ec6d
JB
1020 * keyboard.c (Qundefined): Don't declare static since it is used
1021 in nsfns.m.
1022 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1023 static since they are used in nsfont.m.
cc39a9db 1024
6c60eb9f
SM
10252011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1026
1027 * process.c (Qprocessp): Don't declare static.
1028 * lisp.h (Qprocessp): Declare again.
1029
7990b61a
JB
10302011-04-15 Juanma Barranquero <lekktu@gmail.com>
1031
1032 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1033
5d4cb038
PE
10342011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1035
8bd7b830 1036 Improve C-level modularity by making more things 'static'.
cd64ea1d 1037
e3b27b31
PE
1038 Don't publish debugger-only interfaces to other modules.
1039 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1040 (verify_bytepos, count_markers): Move decls to the only modules
1041 that need them.
1042 * region-cache.h (pp_cache): Likewise.
1043 * window.h (check_all_windows): Likewise.
1044 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1045
5d4cb038
PE
1046 * sysdep.c (croak): Now static, if
1047 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1048 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1049
1050 * alloc.c (refill_memory_reserve): Now static if
1051 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1052 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1053
e87b6180
PE
1054 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1055 Define only if USE_LUCID.
1056
ac64929e
PE
1057 * xrdb.c (x_customization_string, x_rm_string): Now static.
1058
6f37259d
PE
1059 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1060 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1061
1683e3ab
PE
1062 * xdisp.c (draw_row_with_mouse_face): Now static.
1063 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1064
de9c2632
PE
1065 * window.h (check_all_windows): Mark externally visible.
1066
2b96acb7
PE
1067 * window.c (window_deletion_count): Now static.
1068
1069 * undo.c: Make symbols static if they're not exported.
1070 (last_undo_buffer, last_boundary_position, pending_boundary):
1071 Now static.
1072
50436f33
PE
1073 * textprop.c (interval_insert_behind_hooks): Now static.
1074 (interval_insert_in_front_hooks): Likewise.
1075
64520e5c
PE
1076 * term.c: Make symbols static if they're not exported.
1077 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1078 (max_frame_lines, tty_set_terminal_modes):
1079 (tty_reset_terminal_modes, tty_turn_off_highlight):
1080 (get_tty_terminal): Now static.
1081 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1082 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1083 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1084 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1085 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1086
1fa53021
PE
1087 * sysdep.c: Make symbols static if they're not exported.
1088 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1089 Now static.
1090 (sigprocmask_set, full_mask): Remove; unused.
1091 (wait_debugging): Mark as visible.
1092 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1093 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1094
d4b43b22
PE
1095 * syntax.c (syntax_temp): Define only if !__GNUC__.
1096
b7c513d0
PE
1097 * sound.c (current_sound_device, current_sound): Now static.
1098
989b29ad
PE
1099 * search.c (searchbufs, searchbuf_head): Now static.
1100
13a55a78
PE
1101 * scroll.c (scroll_cost): Remove; unused.
1102 * dispextern.h (scroll_cost): Remove decl.
1103
de68a1fc
PE
1104 * region-cache.h (pp_cache): Mark as externally visible.
1105
40ccffa6
PE
1106 * process.c: Make symbols static if they're not exported.
1107 (process_tick, update_tick, create_process, chan_process):
1108 (Vprocess_alist, proc_buffered_char, datagram_access):
1109 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1110 (deactivate_process): Mark defn as static, as well as decl.
1111 * lisp.h (create_process): Remove decl.
1112 * process.h (chan_process, Vprocess_alist): Remove decls.
1113
ad64fc97
PE
1114 * print.c: Make symbols static if they're not exported.
1115 (print_depth, new_backquote_output, being_printed, print_buffer):
1116 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1117 (print_interval, print_number_index, initial_stderr_stream):
1118 Now static.
1119 * lisp.h (Fprinc): Remove decl.
1120 (debug_output_compilation_hack): Mark as externally visible.
1121
adddb265
PE
1122 * sysdep.c (croak): Move decl from here to syssignal.h.
1123 * syssignal.h (croak): Put it here, so the API can be checked when
1124 'croak' is called from dissociate_if_controlling_tty.
1125
1717ede2
PE
1126 * minibuf.c: Make symbols static if they're not exported.
1127 (minibuf_save_list, choose_minibuf_frame): Now static.
1128 * lisp.h (choose_minibuf_frame): Remove decl.
1129
fa5fb2bc
PE
1130 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1131
1e3890d1
PE
1132 * lread.c: Make symbols static if they're not exported.
1133 (read_objects, initial_obarray, oblookup_last_bucket_number):
1134 Now static.
1135 (make_symbol): Remove; unused.
1136 * lisp.h (initial_obarray, make_symbol): Remove decls.
1137
8a1414fa
PE
1138 * keyboard.c: Make symbols static if they're not exported.
1139 (single_kboard, recent_keys_index, total_keys, recent_keys):
1140 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1141 (this_single_command_key_start, echoing, last_auto_save):
1142 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1143 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1144 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1145 (Vlispy_mouse_stem, double_click_count):
1146 Now static.
1147 (force_auto_save_soon): Define only if SIGDANGER.
1148 (ignore_mouse_drag_p): Now static if
1149 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1150 (print_help): Remove; unused.
1151 (stop_character, last_timer_event): Mark as externally visible.
1152 * keyboard.h (ignore_mouse_drag_p): Declare only if
1153 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1154 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1155 * lisp.h (echoing): Remove decl.
1156 (force_auto_save_soon): Declare only if SIGDANGER.
1157 * xdisp.c (redisplay_window): Simplify code, to make it more
1158 obvious that ignore_mouse_drag_p is not accessed if !defined
1159 USE_GTK && !defined HAVE_NS.
1160
93ea6e8f
PE
1161 * intervals.c: Make symbols static if they're not exported.
1162 (merge_properties_sticky, merge_interval_right, delete_interval):
1163 Now static.
1164 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1165
77382fcc
PE
1166 * insdel.c: Make symbols static if they're not exported.
1167 However, leave prepare_to_modify_buffer alone. It's never
1168 called from outside this function, but that appears to be a bug.
1169 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1170 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1171 (adjust_after_replace_noundo): Remove; unused.
1172 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1173 (signal_before_change): Remove decls.
77382fcc 1174
9306c32e
PE
1175 * indent.c (val_compute_motion, val_vmotion): Now static.
1176
cd44d2eb
PE
1177 * image.c: Make symbols static if they're not exported.
1178 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1179 if USE_GTK.
1180 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1181 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1182
ad9a7a06
PE
1183 * fringe.c (standard_bitmaps): Now static.
1184 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1185
81626931
PE
1186 * frame.c: Make symbols static if they're not exported.
1187 (x_report_frame_params, make_terminal_frame): Now static.
1188 (get_frame_param): Now static, unless HAVE_NS.
1189 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1190 (x_get_resource_string): Remove; not used.
1191 * frame.h (make_terminal_frame, x_report_frame_params):
1192 (x_get_resource_string); Remove decls.
1193 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1194 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1195
239f9db9
PE
1196 * font.c, fontset.c: Make symbols static if they're not exported.
1197 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1198 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1199 * font.c (font_close_object): Now static.
1200 * font.h (font_close_object): Remove.
1201 * fontset.c (FONTSET_OBJLIST): Remove.
1202 (free_realized_fontset) #if-0 the body, which does nothing.
1203 (face_suitable_for_char_p): #if-0, as it's never called.
1204 * fontset.h (face_suitable_for_char_p): Remove decl.
1205 * xfaces.c (face_at_string_position): Use
1206 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1207 since 0 is always ASCII.
1208
dfcf3579
PE
1209 * fns.c (weak_hash_tables): Now static.
1210
5045092b
PE
1211 * fileio.c: Make symbols static if they're not exported.
1212 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1213 (Vwrite_region_annotation_buffers): Now static.
1214
57a96f5c
PE
1215 * eval.c: Make symbols static if they're not exported.
1216 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1217 * lisp.h (backtrace_list): Remove decl.
1218
35f08c38
PE
1219 * emacs.c: Make symbols static if they're not exported.
1220 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1221 (fatal_error_code, fatal_error_signal_hook, standard_args):
1222 Now static.
1223 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1224 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1225 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1226 * lisp.h (fatal_error_signal_hook): Remove decl.
1227 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1228
f44bd759
PE
1229 * editfns.c: Move a (normally-unused) function to its only use.
1230 * editfns.c, lisp.h (get_operating_system_release): Remove.
1231 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1232 worth the hassle of breaking this out.
1233
b532497d
PE
1234 * xterm.c: Make symbols static if they're not exported.
1235 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1236 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1237 (x_destroy_window, x_delete_display):
1238 Now static.
1239 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1240 (x_mouse_leave): Remove; unused.
1241 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1242 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1243 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1244 Remove decls.
1245 (x_mouse_leave): Declare only if WINDOWSNT.
1246 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1247 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1248 USE_X_TOOLKIT.
1249
1675728f
PE
1250 * ftxfont.c: Make symbols static if they're not exported.
1251 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1252 HAVE_FREETYPE.
1253 * font.h (ftxfont_driver): Likewise.
1254
e4cebfca
PE
1255 * xfns.c: Make symbols static if they're not exported.
1256 (x_last_font_name, x_display_info_for_name):
1257 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1258 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1259 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1260 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1261 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1262 (last_show_tip_args): Now static.
1263 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1264 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1265 (x_screen_planes): Remove; unused.
1266 * dispextern.h (x_screen_planes): Remove decl.
1267
5bf46f05
PE
1268 * dispnew.c: Make symbols static if they're not exported.
1269 * dispextern.h (redraw_garbaged_frames, scrolling):
1270 (increment_row_positions): Remove.
1271 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1272 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1273 Now static.
1274 (redraw_garbaged_frames): Remove; unused.
1275
435f4c28
PE
1276 * xfaces.c: Make symbols static if they're not exported.
1277 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1278 Remove decls.
1279 * xterm.h (defined_color): Remove decls.
1280 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1281 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1282 (menu_face_changed_default, defined_color, free_realized_face):
1283 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1284 (ascii_face_of_lisp_face): Remove; unused.
1285
8524aef3
PE
1286 * xdisp.c: Make symbols static if they're not exported.
1287 * dispextern.h (scratch_glyph_row, window_box_edges):
1288 (glyph_to_pixel_coords, set_cursor_from_row):
1289 (get_next_display_element, set_iterator_to_next):
1290 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1291 (show_mouse_face): Remove decls
1292 * frame.h (message_buf_print): Likewise.
1293 * lisp.h (pop_message, set_message, check_point_in_composition):
1294 Likewise.
1295 * xterm.h (set_vertical_scroll_bar): Likewise.
1296 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1297 (message_buf_print, scratch_glyph_row, displayed_buffer):
1298 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1299 (get_next_display_element, show_mouse_face, window_box_edges):
1300 (frame_to_window_pixel_xy, check_point_in_composition):
1301 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1302 (glyph_to_pixel_coords): Remove; unused.
1303
16390cd2
PE
1304 * dired.c (file_name_completion): Now static.
1305
1306 * dbusbind.c (xd_in_read_queued_messages): Now static.
1307
a25f4dfa
PE
1308 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1309 * data.c (circular_list_error): Remove.
1310
14a9c8df
PE
1311 * commands.h (last_point_position, last_point_position_buffer):
1312 (last_point_position_window): Remove decls.
1313 * keyboard.c: Make these variables static.
1314
74ab6df5
PE
1315 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1316 decls.
1317 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1318 (iso_code_class, detect_coding, code_convert_region): Now static.
1319 (encode_coding_gap): Remove; unused.
1320
38dfbee1
PE
1321 * chartab.c (chartab_chars, chartab_bits): Now static.
1322
a2cb4e63
PE
1323 * charset.h (charset_iso_8859_1): Remove decl.
1324 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1325 Now static.
1326
127198fd
PE
1327 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1328 * ccl.c (Vccl_program_table): Now static.
1329 (check_ccl_update): Remove; unused.
1330
d85b608f
PE
1331 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1332 * category.h: ... from here.
1333 * category.c (check_category_table, set_category_set): Now static.
1334
31cd66f3
PE
1335 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1336 * lisp.h: Remove these decls.
1337
c358e587
PE
1338 * buffer.c (buffer_count): Remove unused var.
1339
e78aecca
PE
1340 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1341 so that it's not optimized away.
1342 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1343 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1344 exported only to the debugger.
1345
e192d7d3
PE
1346 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1347 * atimer.h (run_all_atimers): Removed; not exported.
1348
92470028
PE
1349 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1350 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1351 was inaccessible from Lisp.
1352 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1353 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1354
244ed907
PE
1355 alloc.c: Import and export fewer symbols, and remove unused items.
1356 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1357 is defined.
1358 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1359 it's not optimized away by whole-program optimization.
1360 (message_enable_multibyte, free_misc): Remove.
1361 (catchlist, handlerlist, mark_backtrace):
1362 Declare only if BYTE_MARK_STACK.
1363 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1364 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1365 (message_enable_multibyte): Remove decl.
1366 (free_misc, interval_free_list, float_block, float_block_index):
1367 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1368 (cons_free_list, last_marked_index):
1369 Now static.
1370 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1371 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1372 (mark_backtrace): Define only if BYTE_MARK_STACK.
1373 * xdisp.c (message_enable_multibyte): Now static.
1374
61c2b50e 1375 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1376 This makes it easier for human readers (and static analyzers)
1377 to see whether these variables are used from other modules.
1378 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1379 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1380 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1381 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1382 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1383 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1384 * xmenu.c, xselect.c:
1385 Declare Q* vars static if they are not used in other modules.
1386 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1387 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1388 Remove decls of unexported vars.
1389 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1390
95c82688
PE
1391 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1392
16a97296
PE
1393 Make Emacs functions such as Fatom 'static' by default.
1394 This makes it easier for human readers (and static analyzers)
1395 to see whether these functions can be called from other modules.
1396 DEFUN now defines a static function. To make the function external
1397 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1398 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1399 (Finit_image_library):
16a97296
PE
1400 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1401 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1402 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1403 Remove decls, since these functions are now static.
1404 (Funintern, Fget_internal_run_time): New decls, since these functions
1405 were already external.
95c82688 1406
16a97296
PE
1407 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1408 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1409 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1410 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1411 * keyboard.c, keymap.c, lread.c:
1412 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1413 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1414 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1415 Mark functions with DEFUE instead of DEFUN,
1416 if they are used in other modules.
1417 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1418 decls for now-static functions.
1419 * buffer.h (Fdelete_overlay): Remove decl.
1420 * callproc.c (Fgetenv_internal): Mark as internal.
1421 * composite.c (Fremove_list_of_text_properties): Remove decl.
1422 (Fcomposition_get_gstring): New forward static decl.
1423 * composite.h (Fcomposite_get_gstring): Remove decl.
1424 * dired.c (Ffile_attributes): New forward static decl.
1425 * doc.c (Fdocumntation_property): New forward static decl.
1426 * eval.c (Ffetch_bytecode): New forward static decl.
1427 (Funintern): Remove extern decl; now in .h file where it belongs.
1428 * fileio.c (Fmake_symbolic_link): New forward static decl.
1429 * image.c (Finit_image_library): New forward static decl.
1430 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1431 * intervals.h (Fprevious_property_change):
1432 (Fremove_list_of_text_properties): Remove decls.
1433 * keyboard.c (Fthis_command_keys): Remove decl.
1434 (Fcommand_execute): New forward static decl.
1435 * keymap.c (Flookup_key): New forward static decl.
1436 (Fcopy_keymap): Now static.
1437 * keymap.h (Flookup_key): Remove decl.
1438 * process.c (Fget_process): New forward static decl.
1439 (Fprocess_datagram_address): Mark as internal.
1440 * syntax.c (Fsyntax_table_p): New forward static decl.
1441 (skip_chars): Remove duplicate decl.
1442 * textprop.c (Fprevious_property_change): New forward static decl.
1443 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1444 Now internal.
1445 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1446 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1447
785bbd42
PE
1448 * editfns.c (Fformat): Remove unreachable code.
1449
8b913b57
AS
14502011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1451
1452 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1453 change. (Bug#8496)
1454
a6744a35
EZ
14552011-04-13 Eli Zaretskii <eliz@gnu.org>
1456
1457 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1458 when at ZV. (Bug#8487)
1459
e7974947
AS
14602011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1461
baad03f0
AS
1462 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1463 (Bug#8437)
1464 * keyboard.c (parse_tool_bar_item): Likewise.
1465 * sound.c (sound_cleanup, alsa_close): Likewise.
1466 * termcap.c (tgetent): Likewise.
1467 * xfns.c (x_default_font_parameter): Likewise.
1468 * xsettings.c (read_and_apply_settings): Likewise.
1469
e7974947
AS
1470 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1471 (overrun_check_free): Protoize.
1472
28272684
PE
14732011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1474
1475 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1476 since callers should never pass a negative size.
1477 Change the signature to match that of plain 'read' and 'write'; see
1478 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1479 * lisp.h: Update prototypes of emacs_write and emacs_read.
1480
11997c76
EZ
14812011-04-11 Eli Zaretskii <eliz@gnu.org>
1482
1483 * xdisp.c (redisplay_window): Don't try to determine the character
1484 position of the scroll margin if the window start point w->startp
e896f03c 1485 is outside the buffer's accessible region. (Bug#8468)
11997c76 1486
8a2cbd72
EZ
14872011-04-10 Eli Zaretskii <eliz@gnu.org>
1488
1489 Fix write-region and its subroutines for buffers > 2GB.
1490 * fileio.c (a_write, e_write): Modify declaration of arguments and
1491 local variables to support buffers larger than 2GB.
1492 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1493
1494 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1495 argument, local variables, and return value.
1496
1497 * lisp.h: Update prototypes of emacs_write and emacs_read.
1498
1499 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1500
4073e537 15012011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1502
1ebfdcb6
PE
1503 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1504
b2ded58d
PE
1505 Fix more problems found by GCC 4.6.0's static checks.
1506
7d66342c
PE
1507 * xdisp.c (vmessage): Use a better test for character truncation.
1508
bbf47d44
PE
1509 * charset.c (load_charset_map): <, not <=, for optimization,
1510 and to avoid potential problems with integer overflow.
9248994d 1511 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1512 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1513 * editfns.c (Fformat): Likewise.
1e69125e 1514 * syntax.c (skip_chars): Likewise.
3befa583 1515
e3019616
PE
1516 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1517 This also lets GCC 4.6.0 generate slightly better loop code.
1518
becfa255
PE
1519 * callint.c (Fcall_interactively): <, not <=, for optimization.
1520 (Fcall_interactively): Count the number of arguments produced,
1521 not the number of arguments given. This is simpler and lets GCC
1522 4.6.0 generate slightly better code.
1523
dae0cd48
PE
1524 * ftfont.c: Distingish more carefully between FcChar8 and char.
1525 The previous code passed unsigned char * to a functions like
1526 strlen and xstrcasecmp that expect char *, which does not
1527 conform to the C standard.
1528 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1529 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1530 char * when the C standard requires it.
1531
76032d70
PE
1532 * keyboard.c (read_char): Remove unused var.
1533
eb3f1cc8
PE
1534 * eval.c: Port to Windows vsnprintf (Bug#8435).
1535 Include <limits.h>.
1536 (SIZE_MAX): Define if the headers do not.
1537 (verror): Do not give up if vsnprintf returns a negative count.
1538 Instead, grow the buffer. This ports to Windows vsnprintf, which
1539 does not conform to C99. Problem reported by Eli Zaretskii.
1540 Also, simplify the allocation scheme, by avoiding the need for
1541 calling realloc, and removing the ALLOCATED variable.
1542
70476b54
PE
1543 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1544
12020a9e
PE
1545 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1546 But keep the doprint source code for now, as we might revamp it
1547 and use it again (Bug#8435).
ea6c7ae6
PE
1548 * lisp.h (doprnt): Remove.
1549 * Makefile.in (base_obj): Remove doprnt.o.
1550 * deps.mk (doprnt.o): Remove.
1551
5fdb398c
PE
1552 error: Print 32- and 64-bit integers portably (Bug#8435).
1553 Without this change, on typical 64-bit hosts error ("...%d...", N)
1554 was used to print both 32- and 64-bit integers N, which relied on
1555 undefined behavior.
1556 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1557 New macro.
1558 * lisp.h (error, verror): Mark as printf-like functions.
1559 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1560 Report overflow in size calculations when allocating printf buffer.
1561 Do not truncate output string at its first null byte.
1562 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1563 Truncate the output at a character boundary, since vsnprintf does not
1564 do that.
1565 * charset.c (check_iso_charset_parameter): Convert internal
1566 character to string before calling 'error', since %c now has the
1567 printf meaning.
1568 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1569 overflow when computing char to be passed to 'error'. Do not
1570 pass Lisp_Object to 'error'; pass the integer instead.
1571 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1572 formatted with plain %d.
1573
b189fa66
PE
1574 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1575
bff87ef0
PE
1576 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1577
7e2cac20
PE
1578 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1579
ce4d90b5
PE
1580 * xterm.c (x_catch_errors): Remove duplicate declaration.
1581
266c9547
PE
1582 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1583
79c49ad2
PE
1584 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1585
368f4090
JM
15862011-04-10 Jim Meyering <meyering@redhat.com>
1587
1588 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1589 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1590 return ssize_t not "int", and use size_t as the buffer length.
1591 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1592 * gnutls.h: Update declarations.
1593 * process.c (read_process_output): Use ssize_t, to match.
1594 (send_process): Likewise.
1595
a32d4040
CY
15962011-04-09 Chong Yidong <cyd@stupidchicken.com>
1597
1598 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1599
8546720e 16002011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1601
8546720e
GM
1602 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1603 unsigned char, to match FcChar8 type definition.
aac0c6e3 1604
8546720e
GM
1605 * xterm.c (handle_one_xevent):
1606 * xmenu.c (create_and_show_popup_menu):
1607 * xselect.c (x_decline_selection_request)
1608 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1609
0a2f5c1a 16102011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1611
1612 Fix some uses of `int' instead of EMACS_INT.
1613 * search.c (string_match_1, fast_string_match)
1614 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1615 (scan_buffer, find_next_newline_no_quit)
1616 (find_before_next_newline, search_command, Freplace_match)
1617 (Fmatch_data): Make some `int' variables be EMACS_INT.
1618
1619 * xdisp.c (display_count_lines): 3rd argument and return value now
1620 EMACS_INT. All callers changed.
1621 (pint2hrstr): Last argument is now EMACS_INT.
1622
1623 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1624 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1625 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1626 (decode_coding_utf_16, decode_coding_emacs_mule)
1627 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1628 (decode_coding_ccl, decode_coding_charset)
1629 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1630 (decode_coding_iso_2022, decode_coding_emacs_mule)
1631 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1632 <char_offset, last_offset>: Declare EMACS_INT.
1633 (encode_coding_utf_8, encode_coding_utf_16)
1634 (encode_coding_emacs_mule, encode_invocation_designation)
1635 (encode_designation_at_bol, encode_coding_iso_2022)
1636 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1637 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1638 Declare EMACS_INT.
1639 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1640 (encode_invocation_designation): Last argument P_NCHARS is now
1641 EMACS_INT.
1642 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1643 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1644
1645 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1646 All users changed.
1647
1648 * ccl.c (Fccl_execute_on_string): Declare some variables
1649 EMACS_INT.
1650
8546720e 16512011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1652
1653 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1654
4e19a977
CS
16552011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1656
1657 * process.c (Fformat_network_address): Doc fix.
1658
87302331
R
16592011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1660
1661 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1662
cbb59342
CY
16632011-04-08 Chong Yidong <cyd@stupidchicken.com>
1664
1665 * keyboard.c (read_char): Call Lisp function help-form-show,
1666 instead of using internal_with_output_to_temp_buffer.
1667 (Qhelp_form_show): New var.
e0d38eeb 1668 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1669
1670 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1671
1672 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1673
e67a13ab
CY
16742011-04-06 Chong Yidong <cyd@stupidchicken.com>
1675
1676 * process.c (Flist_processes): Removed to Lisp.
1677 (list_processes_1): Deleted.
1678
973f782d
EZ
16792011-04-06 Eli Zaretskii <eliz@gnu.org>
1680
7c106b1e
EZ
1681 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1682
973f782d
EZ
1683 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1684
41cf7d1a 16852011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1686
ca23cc88
PE
1687 Fix more problems found by GCC 4.6.0's static checks.
1688
f390e2d5
PE
1689 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1690
42eea0d0
PE
1691 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1692
b69769da 1693 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1694
f9541e84
PE
1695 * xdisp.c (vmessage): Mark as a printf-like function.
1696
13841b55
PE
1697 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1698
c136c10f
PE
1699 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1700
5e2d4a30
PE
1701 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1702 printf-like functions.
1703 (tiff_load): Add casts to remove these marks before passing them
1704 to system-supplied API.
1705
583f48b9
PE
1706 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1707
b25d760e
PE
1708 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1709 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1710 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1711 directly, rather than having caller test rule sign. This avoids
1712 some unnecessary tests.
1713 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1714 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1715 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1716
bc7b6697 1717 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1718 (xfont_open): Avoid unnecessary tests.
bc7b6697 1719
27ccc379
PE
1720 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1721
dcd5c89a
PE
1722 * composite.h, composite.c (composition_gstring_put_cache):
1723 Use EMACS_INT, not int, for length.
1724
b13a45c6
PE
1725 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1726 breaking out part of COMPOSITION_DECODE_RULE.
1727 (COMPOSITION_DECODE_RULE): Use it.
1728 * composite.c (get_composition_id): Remove unused local vars,
1729 by using the new macro.
1730
1e792e4d
PE
1731 * textprop.c (set_text_properties_1): Change while to do-while,
1732 since the condition is always true at first.
1733
dc6c6455 1734 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1735 (interval_deletion_adjustment): Return unsigned value.
1736 All uses changed.
dc6c6455 1737
aba7731a
PE
1738 * process.c (list_processes_1, create_pty, read_process_output):
1739 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1740 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1741 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1742 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1743 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1744
fdfc4bf3
PE
1745 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1746
fca8fe46 1747 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1748 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1749
06a0259a 1750 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1751 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1752 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1753
e7b9e80f
PE
1754 * print.c (print_error_message): Avoid int overflow.
1755
56201685
PE
1756 * font.c (font_list_entities): Redo for clarity,
1757 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1758
78834453 1759 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1760 (font_score): Avoid potential overflow in diff calculation.
78834453 1761
0bc0b309 1762 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1763 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1764
e610eaca
PE
1765 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1766
b895abce
PE
1767 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1768 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1769 can always succeed if overflow has undefined behavior.
1770
1f1d9321 1771 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1772 (wordify): Omit three unnecessary tests.
1f1d9321 1773
c59478bc
PE
1774 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1775 All callers changed. This avoids the need for an unused var.
1776
79b73827
PE
1777 * casefiddle.c (casify_region): Remove var that is set but not used.
1778
a4db5dfe
PE
1779 * dired.c (file_name_completion): Remove var that is set but not used.
1780
43aae36e
PE
1781 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1782
2a47c44d 1783 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1784 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1785
a37c69bf
PE
1786 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1787 Check for integer overflow on size calculations.
1788
328ab8e7
PE
1789 * buffer.c (Fprevious_overlay_change): Remove var that is set
1790 but not used.
1791
e5a2a5cb
PE
1792 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1793 Remove vars that are set but not used.
8d84a6eb 1794 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1795 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1796
a60e5f68
PE
1797 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1798
f661cb61 1799 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1800 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1801
f0397f5a
PE
1802 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1803 that are set but not used.
1804
8664db06 1805 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1806 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1807
6abdaa4a
PE
1808 * xselect.c (x_get_local_selection, x_handle_property_notify):
1809 Remove vars that are set but not used.
1810
0ce7538d 1811 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1812 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1813
9ae848fc
PE
1814 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1815 Remove var that is set but not used.
0b918413
PE
1816 (scroll_bar_windows_size): Now size_t, not int.
1817 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1818 Check for overflow.
9ae848fc 1819
a5a62657
PE
1820 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1821 (map_tty_color) [!defined MSDOS]: Likewise.
1822
5c5cdd39
PE
1823 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1824
66ebf983
PE
1825 * coding.c: Remove vars that are set but not used.
1826 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1827 All callers changed.
1828 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1829 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1830 (decode_coding_charset): Remove vars that are set but not used.
1831
1be4d761
PE
1832 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1833 that is set but not used.
1834
47553fa8
PE
1835 * print.c (print_object): Remove var that is set but not used.
1836
1f7196bf 1837 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1838 The gnulib version avoids calling malloc in the usual case,
1839 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1840 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1841 * filelock.c (current_lock_owner): Likewise.
1842 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1843 * sysdep.c: Include allocator.h, careadlinkat.h.
1844 (emacs_no_realloc_allocator): New static constant.
1845 (emacs_readlink): New function.
fdb61804
PE
1846 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1847 ../lib/careadlinkat.h.
d1fdcab7 1848
f84c17c7
SM
18492011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1850
1851 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1852 first non-nil return value).
1853
ef3862ad
JD
18542011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1855
1856 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1857 if not defined (Bug#8403).
1858
376a7006
JB
18592011-04-02 Juanma Barranquero <lekktu@gmail.com>
1860
1861 * xdisp.c (display_count_lines): Remove parameter `start',
1862 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1863 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1864 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1865 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1866 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1867 and thereabouts. All callers changed.
1868 (get_per_char_metric): Remove parameter `f', unused since
1869 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1870
6ca3801d
JM
18712011-04-02 Jim Meyering <meyering@redhat.com>
1872
1873 do not dereference NULL upon failed strdup
1874 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1875 (ns_get_family): Likewise.
1876
d8e2b5ba
JB
18772011-04-02 Juanma Barranquero <lekktu@gmail.com>
1878
1879 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1880
8c74fcbd
JD
18812011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1882
1883 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1884 later (Bug#8403).
1885
7200d79c
SM
18862011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1887
03408648 1888 Add lexical binding.
7200d79c 1889
03408648
SM
1890 * window.c (Ftemp_output_buffer_show): New fun.
1891 (Fsave_window_excursion):
1892 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1893
1894 * lread.c (lisp_file_lexically_bound_p): New function.
1895 (Fload): Bind Qlexical_binding.
1896 (readevalloop): Remove `evalfun' arg.
1897 Bind Qinternal_interpreter_environment.
1898 (Feval_buffer): Bind Qlexical_binding.
1899 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1900 Mark as dynamic.
1901 (syms_of_lread): Declare `lexical-binding'.
1902
1903 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1904
1905 * keyboard.c (eval_dyn): New fun.
1906 (menu_item_eval_property): Use it.
ca105506
SM
1907
1908 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1909
03408648
SM
1910 * fns.c (concat, mapcar1): Accept byte-code-functions.
1911
1912 * eval.c (Fsetq): Handle lexical vars.
1913 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1914 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1915 (FletX, Flet): Obey lexical binding.
1916 (Fcommandp): Handle closures.
1917 (Feval): New `lexical' arg.
1918 (eval_sub): New function extracted from Feval. Use it almost
1919 everywhere where Feval was used. Look up vars in lexical env.
1920 Handle closures.
1921 (Ffunctionp): Move from subr.el.
1922 (Ffuncall): Handle closures.
1923 (apply_lambda): Remove `eval_flags'.
1924 (funcall_lambda): Handle closures and new byte-code-functions.
1925 (Fspecial_variable_p): New function.
1926 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1927 but without exporting it to Lisp.
23aba0ea 1928
23aba0ea 1929 * doc.c (Fdocumentation, store_function_docstring):
03408648 1930 * data.c (Finteractive_form): Handle closures.
23aba0ea 1931
03408648
SM
1932 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1933 interactive spec.
ba83908c 1934
03408648
SM
1935 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1936 byte-codes.
1937 (exec_byte_code): New function extracted from Fbyte_code to handle new
1938 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1939
03408648 1940 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1941
03408648 1942 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1943
e2abce01
JB
19442011-03-31 Juanma Barranquero <lekktu@gmail.com>
1945
1946 * xdisp.c (redisplay_internal): Fix prototype.
1947
63696a73 19482011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1949
63696a73
EZ
1950 * xdisp.c (SCROLL_LIMIT): New macro.
1951 (try_scrolling): Use it when setting scroll_limit. Limit
1952 scrolling to 100 screen lines.
1953 (redisplay_window): Even when falling back on "recentering",
1954 position point in the window according to scroll-conservatively,
1955 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1956
1957 (try_scrolling): When point is above the window, allow searching
1958 as far as scroll_max, or one screenful, to compute vertical
1959 distance from PT to the scroll margin position. This prevents
1960 try_scrolling from unnecessarily failing when
1961 scroll-conservatively is set to a value slightly larger than the
1962 window height. Clean up the case of PT below the margin at bottom
1963 of window: scroll_max can no longer be INT_MAX. When aggressive
1964 scrolling is in use, don't let point enter the opposite scroll
1965 margin as result of the scroll.
1966 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1967 threshold of 100 lines for never-recentering scrolling.
1968
e4cc2dfc
JB
19692011-03-31 Juanma Barranquero <lekktu@gmail.com>
1970
1971 * dispextern.h (move_it_by_lines):
1972 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1973 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1974 (message_log_check_duplicate): Remove parameters `prev_bol' and
1975 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1976 (redisplay_internal): Remove parameter `preserve_echo_area',
1977 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1978
1979 * indent.c (Fvertical_motion):
1980 * window.c (window_scroll_pixel_based, Frecenter):
1981 Don't pass `need_y_p' to `move_it_by_lines'.
1982
1c470562
SM
19832011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1984
44f230aa
SM
1985 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1986 steal a few bits to be more compact.
1987 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1988 Remove unneeded casts.
1989
1c470562
SM
1990 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1991
888adce9
ZK
19922011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1993
1994 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1995 binding" message (bug#7967).
1996
f838ed7b
PE
19972011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1998
77861b95
PE
1999 Fix more problems found by GCC 4.6.0's static checks.
2000
de6dbc14
PE
2001 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2002 Remove unused local var.
2003
f838ed7b
PE
2004 * editfns.c (Fmessage_box): Remove unused local var.
2005
792c7b2b
PE
2006 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2007 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2008 Omit unused local vars.
c499e557 2009 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2010 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2011 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2012 Omit unused local var.
2013
ba0165e1
PE
2014 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2015 Don't assume string length fits in int.
32ad8845 2016 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2017 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2018
3c59b4c9
PE
2019 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2020 instead of alloca (Bug#8344).
2021
a3eed478 2022 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2023 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2024
eb4d412d
PE
2025 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2026
1658b401
PE
2027 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2028 concerns.
2029
2030 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2031
2032 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2033
9a2c6e05
PE
2034 * keyboard.c (syms_of_keyboard): Use the same style as later
2035 in this function when indexing through an array. This also
2036 works around GCC bug 48267.
2037
03d0a109
PE
2038 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2039
44f730c8
PE
2040 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2041
fe75f926
PE
2042 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2043 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2044
ffa8c828
PE
2045 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2046 This avoids undefined behavior on integer overflow, and is a bit
2047 more convenient anyway since it is compared to a size_t variable.
2048
c5101a77
PE
2049 Variadic C functions now count arguments with size_t, not int.
2050 This avoids an unnecessary limitation on 64-bit machines, which
2051 caused (substring ...) to crash on large vectors (Bug#8344).
2052 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2053 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2054 All variadic functions and their callers changed accordingly.
c5101a77
PE
2055 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2056 * data.c (arith_driver, float_arith_driver): Likewise.
2057 * editfns.c (general_insert_function): Likewise.
2058 * eval.c (struct backtrace.nargs, interactive_p)
2059 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2060 (funcall_lambda, mark_backtrace): Likewise.
2061 * fns.c (concat): Likewise.
2062 * frame.c (x_set_frame_parameters): Likewise.
2063 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2064 0 if not found, not -1. All callers changed.
2065
dd3f25f7
PE
2066 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2067 (stack_copy_size): Now size_t, not int.
2068 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2069
461c2ab9
JB
20702011-03-28 Juanma Barranquero <lekktu@gmail.com>
2071
2072 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2073 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2074 All callers changed.
2075
2076 * lisp.h (multibyte_char_to_unibyte):
2077 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2078 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2079 * character.h (CHAR_TO_BYTE8):
2080 * cmds.c (internal_self_insert):
2081 * editfns.c (general_insert_function):
2082 * keymap.c (push_key_description):
2083 * search.c (Freplace_match):
2084 * xdisp.c (message_dolog, set_message_1): All callers changed.
2085
f6d62986
SM
20862011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2087
2088 * keyboard.c (safe_run_hook_funcall): New function.
2089 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2090 don't set the hook to nil, but remove the offending function instead.
2091 (Qcommand_hook_internal): Remove, unused.
2092 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2093 Vcommand_hook_internal.
2094
2095 * eval.c (enum run_hooks_condition): Remove.
2096 (funcall_nil, funcall_not): New functions.
2097 (run_hook_with_args): Call each function through a `funcall' argument.
2098 Remove `cond' argument, now redundant.
2099 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2100 (Frun_hook_with_args_until_failure): Adjust accordingly.
2101 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2102
1db5b1ad
JB
21032011-03-28 Juanma Barranquero <lekktu@gmail.com>
2104
2105 * dispextern.h (string_buffer_position): Remove declaration.
2106
2107 * print.c (strout): Remove parameter `multibyte', unused since
2108 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2109
2110 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2111 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2112 All callers changed.
2113
2114 * w32.c (_wsa_errlist): Use braces for struct initializers.
2115
2116 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2117 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2118 All callers changed.
2119 (string_buffer_position): Likewise. Also, make static (it's never
2120 used outside xdisp.c).
2121 (cursor_row_p): Remove parameter `w', unused since
2122 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2123 (decode_mode_spec): Remove parameter `precision', introduced during
2124 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2125 All callers changed.
2126
5ffb62aa
JD
21272011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2128
2129 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2130
461c2ab9 21312011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2132
2133 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2134 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2135 (ns_update_auto_hide_menu_bar): New functions.
2136 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2137 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2138 ns_constrain_all_frames.
2139 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2140 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2141
5c380ffb
JD
21422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2143
2144 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2145
9af30bdf
GM
21462011-03-27 Glenn Morris <rgm@gnu.org>
2147
2148 * syssignal.h: Replace RETSIGTYPE with void.
2149 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2150 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2151 Replace SIGTYPE with void everywhere.
2152 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2153 * s/template.h (SIGTYPE): Remove commented out definition.
2154
e2abce01
JB
21552011-03-26 Eli Zaretskii <eliz@gnu.org>
2156
2157 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2158 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2159
f868cd8a
JB
21602011-03-26 Juanma Barranquero <lekktu@gmail.com>
2161
59eb0929
JB
2162 * w32.c (read_unc_volume): Use parameter `henum', instead of
2163 global variable `wget_enum_handle'.
2164
2165 * keymap.c (describe_vector): Remove parameters `indices' and
2166 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2167 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2168
f868cd8a
JB
2169 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2170
2171 * keyboard.c (timer_check): Remove parameter `do_it_now',
2172 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2173 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2174 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2175
2176 * keyboard.c (read_char):
2177 * w32menu.c (w32_menu_display_help):
2178 * xmenu.c (show_help_event, menu_help_callback):
2179 Adjust calls to `show_help_echo'.
2180
2181 * gtkutil.c (xg_maybe_add_timer):
2182 * keyboard.c (readable_events):
2183 * process.c (wait_reading_process_output):
2184 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2185
2186 * insdel.c (adjust_markers_gap_motion):
2187 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2188 (gap_left, gap_right): Don't call it.
2189
2ecf6fdb
CY
21902011-03-25 Chong Yidong <cyd@stupidchicken.com>
2191
2192 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2193 incurred during fontification.
2194
6b1f9ba4
JB
21952011-03-25 Juanma Barranquero <lekktu@gmail.com>
2196
2197 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2198 (DEFVAR_PER_BUFFER): Don't pass it.
2199
2200 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2201 (scrolling_window): Don't pass it.
2202
0f4a96b5
JB
22032011-03-25 Juanma Barranquero <lekktu@gmail.com>
2204
2205 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2206
2207 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2208 and `suffix'.
2209 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2210 of variables specific to SELinux and computation of `encoded_absname'.
2211
2212 * image.c (XPutPixel): Remove unused variable `height'.
2213
2214 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2215
2216 * unexw32.c (get_section_info): Remove unused variable `section'.
2217
2218 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2219 (system_process_attributes): Remove unused variable `sess'.
2220 (sys_read): Remove unused variable `err'.
2221
2222 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2223 (w32_wnd_proc): Remove unused variable `isdead'.
2224 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2225 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2226 (x_create_tip_frame): Remove unused variable `tem'.
2227
2228 * w32inevt.c (w32_console_read_socket):
2229 Remove unused variable `no_events'.
2230
2231 * w32term.c (x_draw_composite_glyph_string_foreground):
2232 Remove unused variable `width'.
2233
1149507c
JB
22342011-03-24 Juanma Barranquero <lekktu@gmail.com>
2235
2236 * w32term.c (x_set_glyph_string_clipping):
2237 Don't pass uninitialized region to CombineRgn.
2238
9c88f339
JB
22392011-03-23 Juanma Barranquero <lekktu@gmail.com>
2240
2241 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2242 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2243 (Fx_close_connection): Remove unused variable `i'.
2244
2245 * w32font.c (w32font_draw): Return number of glyphs.
2246 (w32font_open_internal): Remove unused variable `i'.
2247 (w32font_driver): Add missing initializer.
2248
2249 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2250 (fill_in_menu): Remove unused variable `items_added'.
2251
2252 * w32term.c (last_mouse_press_frame): Remove static global variable.
2253 (w32_clip_to_row): Remove unused variable `f'.
2254 (x_delete_terminal): Remove unused variable `i'.
2255
2256 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2257 (NOTHING): Remove unused static global variable.
2258 (uniscribe_check_otf): Remove unused variable `table'.
2259 (uniscribe_font_driver): Add missing initializers.
2260
dee091a3
JD
22612011-03-23 Julien Danjou <julien@danjou.info>
2262
2263 * term.c (Fsuspend_tty, Fresume_tty):
2264 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2265 * window.c (temp_output_buffer_show):
2266 * insdel.c (signal_before_change):
2267 * frame.c (Fhandle_switch_frame):
2268 * fileio.c (Fdo_auto_save):
2269 * emacs.c (Fkill_emacs):
2270 * editfns.c (save_excursion_restore):
2271 * cmds.c (internal_self_insert):
2272 * callint.c (Fcall_interactively):
2273 * buffer.c (Fkill_all_local_variables):
2274 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2275 Use Frun_hooks.
0f4a96b5 2276 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2277 unconditionnaly since it does the check itself.
2278
2c520ab5 22792011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2280
c9c49752
PE
2281 Fix more problems found by GCC 4.5.2's static checks.
2282
8abc3f12
PE
2283 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2284 the first time through the loop, since we know p0 < p1 then.
2285 This also avoids a gcc -Wstrict-overflow warning.
2286
a2d26660
PE
2287 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2288 leading to a memory leak, possible in functions like
2289 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2290 of objects (Bug#8318).
a2d26660 2291
916c72e9
PE
2292 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2293 that could (at least in theory) be that large.
2294
19ab8a18
PE
2295 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2296 This is less likely to overflow, and avoids undefined behavior if
2297 overflow does occur. All callers changed. Use strtoul to scan
2298 for the unsigned long integer.
b7cbbd6f
PE
2299 (pint2hrstr): Simplify and tune code slightly.
2300 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2301
f0641eff
PE
2302 * scroll.c (do_scrolling): Work around GCC bug 48228.
2303 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2304
7f650bb9
PE
2305 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2306 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2307 (validate_x_resource_name): Simplify count usage.
2308 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2309
37dd57d1
PE
2310 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2311 fail (Bug#8306).
81e56e61 2312
699979fc 2313 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2314
401bf9b4
PE
2315 * process.c (Fmake_network_process): Use socklen_t, not int,
2316 where POSIX says socklen_t is required in portable programs.
2317 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2318 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2319 (Fmake_network_process, server_accept_connection):
2320 (wait_reading_process_output, read_process_output):
2321 Likewise.
2322
b93aacde
PE
2323 * process.c: Rename or move locals to avoid shadowing.
2324 (list_processes_1, Fmake_network_process):
2325 (read_process_output_error_handler, exec_sentinel_error_handler):
2326 Rename or move locals.
4dc343ee 2327 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2328 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2329 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2330 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2331 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2332
af8a867c 2333 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2334 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2335 Include tparam.h instead, since it declares them.
af8a867c
PE
2336 * cm.h (PC): Remove extern decl; tparam.h now does this.
2337 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2338 * terminfo.c: Include tparam.h, to check interfaces.
2339 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2340 (tparam): Adjust signature to match interface in tparam.h;
2341 this removes some undefined behavior. Check that outstring and len
2342 are zero, which they always are with Emacs.
2343 * tparam.h (PC, BC, UP): New extern decls.
2344
0248044d 2345 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2346 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2347
8ff096c1 2348 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2349 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2350 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2351 (ftfont_list): Remove unused local.
49eaafba
PE
2352 (get_adstyle_property, ftfont_pattern_entity):
2353 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2354 Rename locals to avoid shadowing.
8ff096c1 2355
e2be39f6
PE
2356 * xfont.c (xfont_list_family): Mark var as initialized.
2357
c9735e30
PE
2358 * xml.c (make_dom): Now static.
2359
8f5201ae
PE
2360 * composite.c (composition_compute_stop_pos): Rename local to
2361 avoid shadowing.
b246f932
PE
2362 (composition_reseat_it): Remove unused locals.
2363 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2364 (composition_update_it): Mark var as initialized.
11b61122
PE
2365 (find_automatic_composition): Mark vars as initialized,
2366 with a FIXME (Bug#8290).
8f5201ae 2367
760fbc2c
PE
2368 character.h: Rename locals to avoid shadowing.
2369 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2370 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2371 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2372 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2373 to avoid shadowing.
2374
ff08eb85
PE
2375 * textprop.c (property_change_between_p): Remove; unused.
2376
fc7bf025
PE
2377 * intervals.c (interval_start_pos): Now static.
2378
235d7abc
PE
2379 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2380
44f230aa
SM
2381 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2382 Rename locals to avoid shadowing.
3e7d6594 2383
50060332
PE
2384 * sound.c (wav_play, au_play, Fplay_sound_internal):
2385 Fix pointer signedness.
d01f234b 2386 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2387 (wav_play): Initialize a variable to 0, to prevent undefined
2388 behavior (Bug#8278).
50060332 2389
c4fc4e30
PE
2390 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2391
918436ed
PE
2392 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2393
c939f91b
PE
2394 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2395 clobbering (Bug#8298).
b9c7f648
PE
2396 * sysdep.c (sys_subshell): Likewise.
2397 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2398
6bd8c144
PE
2399 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2400 This should get cleaned up, so that child_setup has the
2401 same signature on all platforms.
2402
7710357c 2403 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2404 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2405
c59da222
CY
24062011-03-22 Chong Yidong <cyd@stupidchicken.com>
2407
2408 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2409 not to be necessary, and produces flickering.
2410
66b87493
GM
24112011-03-20 Glenn Morris <rgm@gnu.org>
2412
2413 * config.in: Remove file.
2414
45b6f6d5
JB
24152011-03-20 Juanma Barranquero <lekktu@gmail.com>
2416
2417 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2418 are now in src/globals.h.
2419 (syms_of_minibuf): Remove spurious & from previous change.
2420
3ec03f7e
LL
24212011-03-20 Leo <sdl.web@gmail.com>
2422
2423 * minibuf.c (completing-read-function): New variable.
2424 (completing-read-default): Rename from completing-read.
2425 (completing-read): Call completing-read-function.
2426
b14e3e21
CY
24272011-03-19 Juanma Barranquero <lekktu@gmail.com>
2428
2429 * xfaces.c (Fx_load_color_file):
2430 Read color file from absolute filename (bug#8250).
2431
f2b726e6
JB
24322011-03-19 Juanma Barranquero <lekktu@gmail.com>
2433
2434 * makefile.w32-in: Update dependencies.
2435
09f6ff02
EZ
24362011-03-17 Eli Zaretskii <eliz@gnu.org>
2437
2438 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2439
29a6015a
PE
24402011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2441
a3a6c54e
PE
2442 Fix more problems found by GCC 4.5.2's static checks.
2443
b766f867
PE
2444 * process.c (make_serial_process_unwind, send_process_trap):
2445 (sigchld_handler): Now static.
2446
be02381c
PE
2447 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2448 That way, the code declares only the vars that it needs.
2449 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2450 * s/cygwin.h (PTY_ITERATION): Likewise.
2451 * s/darwin.h (PTY_ITERATION): Likewise.
2452 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2453
57048744
PE
2454 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2455 * process.c (allocate_pty): Don't declare stb unless it's needed.
2456
7914961c 2457 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2458 (CONSTANTLIM): Remove; unused.
2459 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2460 Define only if needed.
7914961c 2461
b3967b18
PE
2462 * unexelf.c (unexec): Name an expression,
2463 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2464 Use a different way to cause a compilation error if anyone uses
2465 n rather than nn, a way that does not involve shadowing.
73366a00 2466 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2467
29a6015a
PE
2468 * deps.mk (unexalpha.o): Remove; unused.
2469
43cfc33e 2470 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2471 * unexec.h: New file.
ce701a33
PE
2472 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2473 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2474 Depend on unexec.h.
2475 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2476 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2477 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2478 Change as necessary to match prototype in unexec.h.
ce701a33 2479
01f44d5a
PE
2480 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2481 shadowing.
4f63c6bb 2482 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2483
a6670b0b
PE
2484 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2485 Rename locals to avoid shadowing.
2486
cef2010d 2487 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2488 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2489
d4d7173a
PE
2490 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2491
f08b802a
PE
2492 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2493 warning when compiling print.c.
2494
3ddb0639
PE
2495 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2496 instead of using an uninitialized var.
5ad03b97 2497 (font_sort_entities): Mark var as initialized.
3ddb0639 2498
170a2692
PE
2499 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2500
e663c700
PE
2501 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2502 pointers to constants.
89bc529a 2503 (font_parse_fcname): Remove unused vars.
7b81e2d0 2504 (font_delete_unmatched): Now static.
ea838e10 2505 (font_get_spec): Remove; unused.
13a547c6
PE
2506 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2507 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2508 Rename or move locals to avoid shadowing.
e663c700 2509
2a80c887 2510 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2511 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2512
1384fa33 2513 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2514 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2515
8b2c52e9
PE
2516 * alloc.c (mark_backtrace): Move decl from here ...
2517 * lisp.h: ... to here, so that it can be checked.
2518
475545b5 2519 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2520 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2521 (lisp_indirect_variable): Name an expression,
2522 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2523 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2524
b1349114 2525 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2526 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2527 Use const pointer when appropriate.
b1349114 2528
a2928364
PE
2529 * lisp.h (get_system_name, get_operating_system_release):
2530 Move decls here, to check interfaces.
2531 * process.c (get_operating_system_release): Move decl to lisp.h.
2532 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2533 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2534 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2535 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2536 (Fformat_time_string, Fencode_time, Finsert_char):
2537 (Ftranslate_region_internal, Fformat):
2538 Rename or remove local vars to avoid shadowing.
9710023e 2539 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2540
a415e694
PE
2541 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2542 avoid shadowing.
2543
8ef4622d
PE
2544 * lisp.h (eassert): Check that the argument compiles, even if
2545 ENABLE_CHECKING is not defined.
2546
946f9a5b
PE
2547 * data.c (Findirect_variable): Name an expression, to avoid
2548 gcc -Wbad-function-cast warning.
112396d6 2549 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2550 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2551 (Fmake_variable_buffer_local, Fmake_local_variable):
2552 Mark variables as initialized.
52746918 2553 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2554
e5aab7e7 2555 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2556 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2557 Rename locals to avoid shadowing.
dff45157
PE
2558 (mark_stack): Move local variables into the #ifdef region where
2559 they're used.
7bc26fdb
PE
2560 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2561 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2562 needed otherwise.
2563 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2564 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2565 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2566
e5aab7e7
PE
2567 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2568 avoids undefined behavior in theory.
2569
4da60324
PE
2570 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2571
88043301
PE
2572 Use functions, not macros, for up- and down-casing (Bug#8254).
2573 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2574 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2575 to use the following functions instead of these macros.
2576 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2577 EMACS_INT, since callers assume the returned value fits in int.
2578 (upcase1): Likewise, for UPCASE_TABLE.
2579 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2580 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2581 the race-condition problem in the old DOWNCASE.
88043301 2582
19ed5445
PE
2583 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2584 Rename locals to avoid shadowing.
2585 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2586 (regex_compile, re_search_2, re_match_2_internal):
2587 Remove unused local vars.
952db0d7
PE
2588 (FREE_VAR): Rewrite so as not to use empty "else",
2589 which gcc can warn about.
da053e48 2590 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2591 (RETALLOC_IF): Define only if needed.
2592 (WORDCHAR_P): Likewise. This one is never needed, but is used
2593 only in a comment talking about a compiler bug, so put inside
2594 the #if 0 of that comment.
2595 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2596 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2597 Remove; unused.
19ed5445 2598
1f3561e4 2599 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2600 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2601 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2602
ded6f8f7
PE
2603 * search.c (simple_search): Remove unused var.
2604
dbd37a95
PE
2605 * dired.c (compile_pattern): Move decl from here ...
2606 * lisp.h: ... to here, so that it can be checked.
2607 (struct re_registers): New forward decl.
2608
7e47afad
PE
2609 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2610
85f24f61
PE
2611 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2612 All uses changed.
2613 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2614 Rename locals to avoid shadowing.
5671df8f 2615 (Fvertical_motion): Mark locals as initialized.
85f24f61 2616
181aa2be 2617 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2618 (casify_region): Mark local as initialized.
181aa2be 2619
930d429c
PE
2620 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2621
7082eac6
PE
2622 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2623 New macros, so that the caller can use some names other than
2624 gcpro1, gcpro2, etc.
2625 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2626 of the new macros.
2627 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2628 argument, for consistency with GCPRO2_VAR, etc: it is now the
2629 prefix of the variable, not the variable itself. All uses
2630 changed.
38b2c076
PE
2631 * dired.c (directory_files_internal, file_name_completion):
2632 Rename locals to avoid shadowing.
2633
15206ed9
PE
2634 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2635 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2636 dired.c's scmp function, had undefined behavior.
2637 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2638 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2639 * buffer.h: ... to here, because these macros use current_buffer,
2640 and the new implementation with inline functions needs to have
2641 current_buffer in scope now, rather than later when the macros
2642 are used.
2643 (downcase, upcase1): New static inline functions.
2644 (DOWNCASE, UPCASE1): Reimplement using these functions.
2645 This avoids undefined behavior in expressions like
2646 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2647 from race conditions in accessing the global variables
2648 case_temp1 and case_temp2.
2649 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2650 * lisp.h (case_temp1, case_temp2): Remove their decls.
2651 * character.h (ASCII_CHAR_P): Move from here ...
2652 * lisp.h: ... to here, so that the inline functions mentioned
2653 above can use them.
2654
4a6bea26
PE
2655 * dired.c (directory_files_internal_unwind): Now static.
2656
f14b7e14
PE
2657 * fileio.c (file_name_as_directory, directory_file_name):
2658 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2659 Now static.
2893f146
PE
2660 (file_name_as_directory): Use const pointers when appropriate.
2661 (Fexpand_file_name): Likewise. In particular, newdir might
2662 point at constant storage, so make it a const pointer.
fd4ead52 2663 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2664 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2665 signedness issues.
f839df0c
PE
2666 (Fset_file_times, Finsert_file_contents, auto_save_error):
2667 Rename locals to avoid shadowing.
f14b7e14 2668
5716756e 2669 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2670 (Ftry_completion, Fall_completions): Rename or remove locals
2671 to avoid shadowing.
5716756e 2672
b4c3046a
PE
2673 * marker.c (bytepos_to_charpos): Remove; unused.
2674
b45db522
PE
2675 * lisp.h (verify_bytepos, count_markers): New decls,
2676 so that gcc does not warn that these functions aren't declared.
2677
85876d07
PE
2678 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2679 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2680 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2681 (copy_text): Remove unused local var.
85876d07 2682
03d78a21 2683 * filelock.c (within_one_second): Now static.
b3dd38ab 2684 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2685
5df8f01b
PE
2686 * buffer.c (fix_overlays_before): Mark locals as initialized.
2687 (fix_start_end_in_overlays): Likewise. This function should be
2688 simplified by using pointers-to-pointers, but that's a different
2689 matter.
b1d876f1 2690 (switch_to_buffer_1): Now static.
8f54f30a
PE
2691 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2692 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2693
a70072c9 2694 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2695 Fix pointer signedness issue.
edced198
PE
2696 (sys_subshell): Mark local as volatile if checking for lint,
2697 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2698 (MAXPATHLEN): Define only if needed.
a70072c9 2699
a0977c44
PE
2700 * process.c (serial_open, serial_configure): Move decls from here ...
2701 * systty.h: ... to here, so that they can be checked.
2702
a884fdcc
PE
2703 * fns.c (get_random, seed_random): Move extern decls from here ...
2704 * lisp.h: ... to here, so that they can be checked.
2705
604efe86 2706 * sysdep.c (reset_io): Now static.
b8950c94 2707 (wait_for_termination_signal): Remove; unused.
604efe86 2708
38fc62d9
PE
2709 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2710 (copy_keymap_item, append_key, push_text_char_description):
2711 Now static.
1004a21a 2712 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2713 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2714 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2715 (describe_map_tree):
2716 Rename locals to avoid shadowing.
38fc62d9 2717
2f2650da
PE
2718 * keyboard.c: Declare functions static if they are not used elsewhere.
2719 (echo_char, echo_dash, cmd_error, top_level_2):
2720 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2721 (read_char, kbd_buffer_get_event, make_lispy_position):
2722 (make_lispy_event, make_lispy_movement, apply_modifiers):
2723 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2724 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2725 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2726 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2727 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2728
a053e86c 2729 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2730 (mark_kboards): Move decl here ...
2731 * alloc.c (mark_kboards): ... from here.
a053e86c 2732
4752793e
PE
2733 * lisp.h (force_auto_save_soon): New decl.
2734
74f10ca7 2735 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2736 (DEFINE_DUMMY_FUNCTION): New macro.
2737 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2738 Use it.
c03cd23f
PE
2739 (main): Add casts to avoid warnings
2740 if GCC considers string literals to be constants.
74f10ca7 2741
022e70d4
PE
2742 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2743
59d6fe83
PE
2744 * dbusbind.c: Pointer signedness fixes.
2745 (xd_signature, xd_append_arg, xd_initialize):
2746 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2747 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2748 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2749 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2750
78320123
PE
2751 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2752 if GCC considers string literals to be constants.
49cebcca 2753 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2754
35ac2a97
SM
27552011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2756
fb103ca9
SM
2757 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2758 (print_preprocess, print_object): New macro to fix last change.
2759
35ac2a97
SM
2760 * print.c (print_preprocess): Don't forget font objects.
2761
62973b41
JB
27622011-03-16 Juanma Barranquero <lekktu@gmail.com>
2763
2764 * emacs.c (USAGE3): Doc fixes.
2765
0e48bb22
AS
27662011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2767
2768 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2769 structure.
2770
7684e57b
JB
27712011-03-14 Juanma Barranquero <lekktu@gmail.com>
2772
2773 * lisp.h (VWindow_system, Qfile_name_history):
2774 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2775 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2776 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2777
2778 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2779 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2780
2781 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2782 * w32console.c (detect_input_pending, read_input_pending)
2783 (encode_terminal_code):
2784 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2785 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2786 (w32_system_caret_y, Qfile_name_history):
2787 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2788 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2789 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2790 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2791 * w32proc.c (Qlocal, report_file_error):
2792 * w32term.c (Vwindow_system, updating_frame):
2793 * w32uniscribe.c (initialized, uniscribe_font_driver):
2794 Remove unneeded extern declarations.
2795
2aa46d6c
CY
27962011-03-14 Chong Yidong <cyd@stupidchicken.com>
2797
c96bbc66 2798 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2799
cffc6f3b
CY
28002011-03-13 Chong Yidong <cyd@stupidchicken.com>
2801
2802 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2803 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2804 These macros can no longer be used for assignment.
2805
44f230aa
SM
2806 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2807 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2808 (record_buffer_markers, fetch_buffer_markers): New functions for
2809 recording and fetching special buffer markers.
2810 (set_buffer_internal_1, set_buffer_temp): Use them.
2811
2812 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2813
2814 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2815
2816 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2817 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2818
2819 * xdisp.c (hscroll_window_tree):
2820 (reconsider_clip_changes): Use PT instead of BUF_PT.
2821
d251f04b
EZ
28222011-03-13 Eli Zaretskii <eliz@gnu.org>
2823
2824 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2825 $(EMACS_ROOT)/lib/intprops.h.
2826
f0c77cd1
PE
28272011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2828
3eca4629
PE
2829 Fix more problems found by GCC 4.5.2's static checks.
2830
7c86ee98
PE
2831 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2832 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2833 (xg_free_frame_widgets): Make it clear that a local variable is
2834 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2835 (gdk_window_get_screen): Make it clear that this macro is needed
2836 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2837 (int_gtk_range_get_value): New function, which avoids a diagnostic
2838 from gcc -Wbad-function-cast.
2839 (xg_set_toolkit_scroll_bar_thumb): Use it.
2840 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2841 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2842 (get_utf8_string, xg_get_file_with_chooser):
2843 Rename locals to avoid shadowing.
2844 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2845
41729b81
PE
2846 * xgselect.c (xg_select): Remove unused var.
2847
f0c77cd1
PE
2848 * image.c (four_corners_best): Mark locals as initialized.
2849 (gif_load): Initialize transparent_p to zero (Bug#8238).
2850 Mark another local as initialized.
ec6cf4c6 2851 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2852
ce0ad53d 2853 * image.c (clear_image_cache): Now static.
d5d5a617 2854 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2855 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2856 (x_edge_detection): Remove unnecessary cast that
2857 gcc -Wbad-function-cast diagnoses.
2037898d 2858 (gif_load): Fix pointer signedness.
6ae141d6
PE
2859 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2860 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2861
33383987 28622011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2863
d32df629
PE
2864 Improve quality of tests for time stamp overflow.
2865 For example, without this patch (encode-time 0 0 0 1 1
2866 1152921504606846976) returns the obviously-bogus value (-948597
2867 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2868 reports time overflow. See
2869 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2870 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2871 * editfns.c: Include limits.h and intprops.h.
2872 (TIME_T_MIN, TIME_T_MAX): New macros.
2873 (time_overflow): Move earlier, to before first use.
2874 (hi_time, lo_time): New functions, for an accurate test for
2875 out-of-range times.
2876 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2877 (Fget_internal_run_time): Don't assume time_t fits in int.
2878 (make_time): Use list2 instead of Fcons twice.
2879 (Fdecode_time): More accurate test for out-of-range times.
2880 (check_tm_member): New function.
2881 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2882 (lisp_time_argument): Don't rely on undefined left-shift and
2883 right-shift behavior when checking for time stamp overflow.
8be6f318 2884
fe31d94c
PE
2885 * editfns.c (time_overflow): New function, refactoring common code.
2886 (Fformat_time_string, Fdecode_time, Fencode_time):
2887 (Fcurrent_time_string): Use it.
2888
8be6f318
PE
2889 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2890 * dired.c (make_time): Move to ...
2891 * editfns.c (make_time): ... here.
2892 * systime.h: Note the move.
2893
09d9db2c 28942011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2895
126bc0dc
YM
2896 * fringe.c (update_window_fringes): Remove unused variables.
2897
c47cbdfd
YM
2898 * unexmacosx.c (copy_data_segment): Also copy __got section.
2899 (Bug#8223)
2900
7ac80be9
EZ
29012011-03-12 Eli Zaretskii <eliz@gnu.org>
2902
c96bbc66 2903 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2904 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2905 Constify `char *' arguments and their references according to
2906 prototypes in tparam.h.
2907
ecb0f94d 2908 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2909
7ac80be9
EZ
2910 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2911 Adapt all references accordingly.
2912
2913 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2914
ef1fd07e
TT
29152011-03-11 Tom Tromey <tromey@redhat.com>
2916
2917 * buffer.c (syms_of_buffer): Remove obsolete comment.
2918
7ef4b50c
EZ
29192011-03-11 Eli Zaretskii <eliz@gnu.org>
2920
2921 * termhooks.h (encode_terminal_code): Declare prototype.
2922
2923 * msdos.c (encode_terminal_code): Don't declare prototype.
2924
2925 * term.c (encode_terminal_code): Now external again, used by
2926 w32console.c and msdos.c.
2927
44f230aa
SM
2928 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2929 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2930
4b1ec863 29312011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2932
1714f52b 2933 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2934
4b1ec863
PE
2935 * fringe.c (update_window_fringes): Mark locals as initialized
2936 (Bug#8227).
2937 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2938
524c7aa6
PE
2939 * alloc.c (mark_fringe_data): Move decl from here ...
2940 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2941 to check its interface.
2942 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2943
a5c0af81 2944 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2945 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2946 (fontset_font): Mark local as initialized.
a9a06e0b 2947 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2948
b4716021
PE
2949 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2950
811e9bac 2951 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2952 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2953 (x_own_selection, Fx_disown_selection_internal): Rename locals
2954 to avoid shadowing.
2955 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2956
7e3ab302
PE
2957 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2958 so that the caller can use some name other than gcpro1.
2959 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2960 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2961 (Fx_backspace_delete_keys_p):
2962 Use them to avoid shadowing, and rename vars to avoid shadowing.
2963 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2964 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2965 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2966 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2967 Remove unused locals.
7e3ab302
PE
2968 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2969 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2970 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2971 macros.
f78faa98 2972
e2b13473
PE
2973 * xterm.h (x_mouse_leave): New decl.
2974
77f23912
PE
2975 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2976 Remove unused functions.
cdf4ba58
PE
2977 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2978 (x_calc_absolute_position): Now static.
7411c686 2979 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2980 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2981 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2982 unless they are used.
38d0b34a
PE
2983 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2984 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2985 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2986 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2987 (x_error_catcher, x_connection_closed, x_error_handler):
2988 (x_error_quitter, xembed_send_message, x_iconify_frame):
2989 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2990 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2991 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2992
44f230aa
SM
2993 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2994 Rename or move locals to avoid shadowing.
6b463e58 2995 (tty_defined_color, merge_face_heights): Now static.
5967d051 2996 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2997 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2998 does not deduce is never used uninitialized.
73719eba
PE
2999 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3000 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3001
426994c3 3002 * terminal.c (store_terminal_param): Now static.
5489860b 3003
032f1620 3004 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3005 (set_frame_menubar): Remove unused local.
d4323972 3006 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3007 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3008 since they might point to immutable storage.
281585b0
PE
3009 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3010 since it's unused otherwise.
032f1620 3011
367c19e5 3012 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3013 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3014 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3015 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3016 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3017 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3018 does not deduce are never used uninitialized.
70739cbe 3019
07b48fa9
PE
3020 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3021
8868a238 3022 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3023 * window.c (window_loop, size_window):
3024 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3025
7e5cf297 3026 * window.c (display_buffer): Now static.
d6550a9f
PE
3027 (size_window): Mark variables that gcc -Wuninitialized
3028 does not deduce are never used uninitialized.
a586633d
PE
3029 * window.h (check_all_windows): New decl, to forestall
3030 gcc -Wmissing-prototypes diagnostic.
5b555da1 3031 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3032
f6095868
PE
3033 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3034 shadowing.
3035 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3036 Include <limits.h>.
3037 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3038 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3039 (load_charset_map): Mark variables that gcc -Wuninitialized
3040 does not deduce are never used uninitialized.
53df7c11 3041 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3042
f38b440c
PE
3043 * coding.c (coding_set_source, coding_set_destination):
3044 Use "else { /* comment */ }" rather than "else /* comment */;"
3045 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3046 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3047 a block, when the outer 'i' will do.
3048 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3049 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3050 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3051 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3052 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3053 Rename locals to avoid shadowing.
3054 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3055 * coding.c (emacs_mule_char, encode_invocation_designation):
3056 Now static, since they're not used elsewhere.
413bb2db 3057 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3058 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3059 (decode_coding_emacs_mule): Mark variables that gcc
3060 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3061 (detect_coding_iso_2022): Initialize a local variable that might
3062 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3063 this initialization is needed. (Bug#8211)
5f58e762
PE
3064 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3065 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3066 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3067 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3068 Remove unused macros.
f38b440c 3069
232b38b9 3070 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3071 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3072 * character.c (string_count_byte8): Likewise.
232b38b9 3073
fb90da1b
PE
3074 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3075 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3076
fb93dbc2
PE
3077 * chartab.c (copy_sub_char_table): Now static, since it's not used
3078 elsewhere.
5c156ace
PE
3079 (sub_char_table_ref_and_range, char_table_ref_and_range):
3080 Rename locals to avoid shadowing.
bbcd0949 3081 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3082
7d3b3862 3083 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3084 (BIDI_BOB): Remove unused macro.
7d3b3862 3085
6be7d3da
PE
3086 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3087 deduce are never used uninitialized.
c2ed9c8b 3088 * term.c (encode_terminal_code): Likewise.
6be7d3da 3089
75f8807f 3090 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3091
50938595
PE
3092 * tparam.h: New file.
3093 * term.c, tparam.h: Include it.
3094 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3095 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3096 Move these decls to tparam.h, and make them agree with what
3097 is actually in tparam.c. The previous trick of using incompatible
3098 decls in different modules does not conform to the C standard.
3099 All callers of tparam changed to use tparam's actual API.
3100 * tparam.c (tparam1, tparam, tgoto):
3101 Use const pointers where appropriate.
3102
fbceeba2
PE
3103 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3104 * cm.h (struct cm): Likewise.
3105 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3106 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3107 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3108 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3109 (turn_on_face, init_tty): Likewise.
3110 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3111
7f3f1250
PE
3112 * term.c (term_mouse_position): Rename local to avoid shadowing.
3113
e6ca6543
PE
3114 * alloc.c (mark_ttys): Move decl from here ...
3115 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3116
c40f8d15
AS
31172011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3118
3119 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3120
cfe0661d
JB
31212011-03-09 Juanma Barranquero <lekktu@gmail.com>
3122
3123 * search.c (compile_pattern_1): Remove argument regp, unused since
3124 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3125 (compile_pattern): Don't pass it.
3126
0afb4571
J
31272011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3128
3129 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3130 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3131 for ! HAVE_GTK3.
3132 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3133
3134 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3135
3136 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3137 gdk_window_get_screen, gdk_window_get_geometry,
3138 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3139 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3140 (xg_get_pixbuf_from_pixmap): New function.
3141 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3142 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3143 Call xg_get_pixbuf_from_pixmap instead of
3144 gdk_pixbuf_get_from_drawable.
3145 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3146 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3147 (xg_check_special_colors): Use GtkStyleContext and its functions
3148 for HAVE_GTK3.
3149 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3150 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3151 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3152 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3153 Call gtk_widget_get_preferred_size.
0afb4571
J
3154 (xg_frame_resized): gdk_window_get_geometry only takes 5
3155 parameters.
44f230aa
SM
3156 (xg_win_to_widget, xg_event_is_for_menubar):
3157 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3158 (xg_set_widget_bg): New function.
3159 (delete_cb): New function.
895009e1 3160 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3161 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3162 (xg_set_background_color): Call xg_set_widget_bg.
3163 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3164 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3165 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3166 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3167 if ! HAVE_GTK3.
3168 (update_frame_tool_bar): Call gtk_widget_hide.
3169 (xg_initialize): Use GDK_KEY_g.
3170
3171 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3172 if ! HAVE_GTK3
3173 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3174
3175 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3176 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3177 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3178
1c2cc4ef
JB
31792011-03-08 Juanma Barranquero <lekktu@gmail.com>
3180
3181 * w32xfns.c (select_palette): Check success of RealizePalette against
3182 GDI_ERROR, not zero.
3183
33383987 3184See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3185
3186;; Local Variables:
3187;; coding: utf-8
aac0c6e3
MR
3188;; End:
3189
33383987 3190 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3191
3192 This file is part of GNU Emacs.
3193
3194 GNU Emacs is free software: you can redistribute it and/or modify
3195 it under the terms of the GNU General Public License as published by
3196 the Free Software Foundation, either version 3 of the License, or
3197 (at your option) any later version.
3198
3199 GNU Emacs is distributed in the hope that it will be useful,
3200 but WITHOUT ANY WARRANTY; without even the implied warranty of
3201 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3202 GNU General Public License for more details.
3203
3204 You should have received a copy of the GNU General Public License
3205 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.