* frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0b432f21
PE
12011-04-18 Paul Eggert <eggert@cs.ucla.edu>
2
5e073ec7
PE
3 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4 here, since it parses constructs like leading '-' and spaces,
5 which are not wanted; and it overflows with large numbers.
6 Instead, simply match F[0-9]+, which is what is wanted anyway.
7
36372bf9
PE
8 * alloc.c: Remove unportable assumptions about struct layout.
9 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11 (allocate_vectorlike, make_pure_vector): Use the new macros,
12 plus offsetof, to remove unportable assumptions about struct layout.
13 These assumptions hold on all porting targets that I know of, but
14 they are not guaranteed, they're easy to remove, and removing them
15 makes further changes easier.
16
0b432f21
PE
17 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
18 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
19 (string_overrun_cookie): Now const. Use initializers that
20 don't formally overflow signed char, to avoid warnings.
000098c1
PE
21 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
22 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
23 (allocate_buffer): Don't assume sizeof (struct buffer) is a
24 multiple of sizeof (EMACS_INT); it need not be, if
25 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 26 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 27
4581706e
CY
282011-04-17 Chong Yidong <cyd@stupidchicken.com>
29
30 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
31
32 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
33
34 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
35 definition for no-X builds.
36
4887c6e2 372011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 38
fd35b6f9
PE
39 Static checks with GCC 4.6.0 and non-default toolkits.
40
5c1ccb01
PE
41 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
42
006c5daa
PE
43 * process.c (keyboard_bit_set): Define only if SIGIO.
44 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
45 (send_process): Repair possible setjmp clobbering.
46
efc736d3
PE
47 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
48
4e2fe2e6
PE
49 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
50
f97334a2
PE
51 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
52
4e75f29d
PE
53 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
54 Define only if needed.
55
90efadd1
PE
56 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
57 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 58 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 59
3c647824
PE
60 * dispextern.h (struct redisplay_interface): Rename param
61 to avoid shadowing.
e264f262 62 * termhooks.h (struct terminal): Likewise.
761383f4 63 * xterm.c (xembed_send_message): Likewise.
3c647824 64
b58c5c4a
PE
65 * insdel.c (make_gap_smaller): Define only if
66 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
67
cad59032
PE
68 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
69 it.
70
c339dc2e
PE
71 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
72 so that we aren't warned about unused symbols.
73
91a3e27b
PE
74 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
75
399c71d3 76 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 77
8ffc96f5
PE
78 * xfns.c (x_real_positions): Mark locals as initialized.
79
eef9bc79
PE
80 * xmenu.c (xmenu_show): Don't use uninitialized vars.
81
098db9dd
PE
82 * xterm.c: Fix problems found by static analysis with other toolkits.
83 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
84 (x_dispatch_event): Declare static if USE_GTK, and
85 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 86 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 87 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
098db9dd
PE
88 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
89 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
90
eb18f6cc
PE
91 * xmenu.c (menu_help_callback): Pointer type fixes.
92 Use const pointers when pointing at readonly data. Avoid pointer
93 signedness clashes.
94 (FALSE): Remove unused macro.
95 (update_frame_menubar): Remove unused decl.
96
1fe72bf8
PE
97 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
98
60d9e1db
PE
99 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
100 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
101 (single_menu_item): Rename local to avoid shadowing.
102
39261c26
PE
103 * keyboard.c (make_lispy_event): Remove unused local var.
104
018c5e19
PE
105 * frame.c, frame.h (x_get_resource_string): Bring this back, but
106 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
107
63d2b86e
PE
108 * bitmaps: Change bitmaps from unsigned char back to the X11
109 compatible char. Avoid the old compiler warnings about
110 out-of-range initializers by using, for example, '\xab' rather
111 than 0xab.
112
aefd87e1
PE
113 * xgselect.c (xgselect_initialize): Check vs interface
114 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
115
bf501fb9
PE
116 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
117
e9829fdf
PE
118 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
119 to read-only memory.
120
1086c095
PE
121 * fns.c (vector): Remove; this old hack is no longer needed.
122
2baccd04 123 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 124 Remove unused var.
dde42981 125 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 126
72391843 127 * xrdb.c (x_load_resources): Omit unused local.
3565b346 128
436c16df 129 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 130 (x_window): Rename locals to avoid shadowing.
dc5ddd85 131 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 132
92bb796d 133 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 134 (x_term_init): Remove local to avoid shadowing.
92bb796d 135
764430a3 136 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
137
138 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
139 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
140
d1dfb56c
EZ
1412011-04-16 Eli Zaretskii <eliz@gnu.org>
142
c4354cb4
EZ
143 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
144
d1dfb56c
EZ
145 Fix regex.c, syntax.c and friends for buffers > 2GB.
146 * syntax.h (struct gl_state_s): Declare character position members
147 EMACS_INT.
148
149 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
150
151 * textprop.c (verify_interval_modification, interval_of): Declare
152 arguments EMACS_INT.
153
154 * intervals.c (adjust_intervals_for_insertion): Declare arguments
155 EMACS_INT.
156
157 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
158
159 * indent.c (Fvertical_motion): Local variable it_start is now
160 EMACS_INT.
161
162 * regex.c (re_match, re_match_2, re_match_2_internal)
163 (bcmp_translate, regcomp, regexec, print_double_string)
164 (group_in_compile_stack, re_search, re_search_2, regex_compile)
165 (re_compile_pattern, re_exec): Declare arguments and local
166 variables `size_t' and `ssize_t' and return values `regoff_t', as
167 appropriate.
168 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
169 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
170 <compile_stack_type>: `size' and `avail' are now `size_t'.
171
172 * regex.h <regoff_t>: Use ssize_t, not int.
173 (re_search, re_search_2, re_match, re_match_2): Arguments that
174 specify buffer/string position and length are now ssize_t and
175 size_t. Return type is regoff_t.
176
613052cd
BK
1772011-04-16 Ben Key <bkey76@gmail.com>
178
179 * nsfont.m: Fixed bugs in ns_get_family and
180 ns_descriptor_to_entity that were caused by using free to
181 deallocate memory blocks that were allocated by xmalloc (via
182 xstrdup). This caused Emacs to crash when compiled with
183 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
184 --enable-checking=xmallocoverrun). xfree is now used to
185 deallocate these memory blocks.
186
4170f62f 1872011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 188
71b41406
PE
189 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
190
9587a89d
PE
191 emacs_write: Accept and return EMACS_INT for sizes.
192 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
193 et seq.
194 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
195 Accept and return EMACS_INT.
196 (emacs_gnutls_write): Return the number of bytes written on
197 partial writes.
198 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
199 (emacs_read, emacs_write): Remove check for negative size, as the
200 Emacs source code has been audited now.
9587a89d
PE
201 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
202 (emacs_read, emacs_write): Use it.
273a5f82
PE
203 * process.c (send_process): Adjust to the new signatures of
204 emacs_write and emacs_gnutls_write. Do not attempt to store
205 a byte offset into an 'int'; it might overflow.
9587a89d 206 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 207
3e047f51
PE
208 * sound.c: Don't assume sizes fit in 'int'.
209 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 210 Return EMACS_INT, not int.
3e047f51 211 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
212 Accept EMACS_INT, not int.
213 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
214 record read return values.
215
cc39a9db
BK
2162011-04-15 Ben Key <bkey76@gmail.com>
217
c9d0ec6d
JB
218 * keyboard.c (Qundefined): Don't declare static since it is used
219 in nsfns.m.
220 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
221 static since they are used in nsfont.m.
cc39a9db 222
6c60eb9f
SM
2232011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
224
225 * process.c (Qprocessp): Don't declare static.
226 * lisp.h (Qprocessp): Declare again.
227
7990b61a
JB
2282011-04-15 Juanma Barranquero <lekktu@gmail.com>
229
230 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
231
5d4cb038
PE
2322011-04-14 Paul Eggert <eggert@cs.ucla.edu>
233
8bd7b830 234 Improve C-level modularity by making more things 'static'.
cd64ea1d 235
e3b27b31
PE
236 Don't publish debugger-only interfaces to other modules.
237 * lisp.h (safe_debug_print, debug_output_compilation_hack):
238 (verify_bytepos, count_markers): Move decls to the only modules
239 that need them.
240 * region-cache.h (pp_cache): Likewise.
241 * window.h (check_all_windows): Likewise.
242 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
243
5d4cb038
PE
244 * sysdep.c (croak): Now static, if
245 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
246 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
247
248 * alloc.c (refill_memory_reserve): Now static if
249 !defined REL_ALLOC || defined SYSTEM_MALLOC.
250 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 251
e87b6180
PE
252 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
253 Define only if USE_LUCID.
254
ac64929e
PE
255 * xrdb.c (x_customization_string, x_rm_string): Now static.
256
6f37259d
PE
257 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
258 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
259
1683e3ab
PE
260 * xdisp.c (draw_row_with_mouse_face): Now static.
261 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
262
de9c2632
PE
263 * window.h (check_all_windows): Mark externally visible.
264
2b96acb7
PE
265 * window.c (window_deletion_count): Now static.
266
267 * undo.c: Make symbols static if they're not exported.
268 (last_undo_buffer, last_boundary_position, pending_boundary):
269 Now static.
270
50436f33
PE
271 * textprop.c (interval_insert_behind_hooks): Now static.
272 (interval_insert_in_front_hooks): Likewise.
273
64520e5c
PE
274 * term.c: Make symbols static if they're not exported.
275 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
276 (max_frame_lines, tty_set_terminal_modes):
277 (tty_reset_terminal_modes, tty_turn_off_highlight):
278 (get_tty_terminal): Now static.
279 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
280 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 281 HAVE_WINDOW_SYSTEM.
64520e5c
PE
282 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
283 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
284
1fa53021
PE
285 * sysdep.c: Make symbols static if they're not exported.
286 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
287 Now static.
288 (sigprocmask_set, full_mask): Remove; unused.
289 (wait_debugging): Mark as visible.
290 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
291 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
292
d4b43b22
PE
293 * syntax.c (syntax_temp): Define only if !__GNUC__.
294
b7c513d0
PE
295 * sound.c (current_sound_device, current_sound): Now static.
296
989b29ad
PE
297 * search.c (searchbufs, searchbuf_head): Now static.
298
13a55a78
PE
299 * scroll.c (scroll_cost): Remove; unused.
300 * dispextern.h (scroll_cost): Remove decl.
301
de68a1fc
PE
302 * region-cache.h (pp_cache): Mark as externally visible.
303
40ccffa6
PE
304 * process.c: Make symbols static if they're not exported.
305 (process_tick, update_tick, create_process, chan_process):
306 (Vprocess_alist, proc_buffered_char, datagram_access):
307 (fd_callback_data, send_process_frame, process_sent_to): Now static.
308 (deactivate_process): Mark defn as static, as well as decl.
309 * lisp.h (create_process): Remove decl.
310 * process.h (chan_process, Vprocess_alist): Remove decls.
311
ad64fc97
PE
312 * print.c: Make symbols static if they're not exported.
313 (print_depth, new_backquote_output, being_printed, print_buffer):
314 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
315 (print_interval, print_number_index, initial_stderr_stream):
316 Now static.
317 * lisp.h (Fprinc): Remove decl.
318 (debug_output_compilation_hack): Mark as externally visible.
319
adddb265
PE
320 * sysdep.c (croak): Move decl from here to syssignal.h.
321 * syssignal.h (croak): Put it here, so the API can be checked when
322 'croak' is called from dissociate_if_controlling_tty.
323
1717ede2
PE
324 * minibuf.c: Make symbols static if they're not exported.
325 (minibuf_save_list, choose_minibuf_frame): Now static.
326 * lisp.h (choose_minibuf_frame): Remove decl.
327
fa5fb2bc
PE
328 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
329
1e3890d1
PE
330 * lread.c: Make symbols static if they're not exported.
331 (read_objects, initial_obarray, oblookup_last_bucket_number):
332 Now static.
333 (make_symbol): Remove; unused.
334 * lisp.h (initial_obarray, make_symbol): Remove decls.
335
8a1414fa
PE
336 * keyboard.c: Make symbols static if they're not exported.
337 (single_kboard, recent_keys_index, total_keys, recent_keys):
338 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
339 (this_single_command_key_start, echoing, last_auto_save):
340 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
341 (command_loop, echo_now, keyboard_init_hook, help_char_p):
342 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
343 (Vlispy_mouse_stem, double_click_count):
344 Now static.
345 (force_auto_save_soon): Define only if SIGDANGER.
346 (ignore_mouse_drag_p): Now static if
347 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
348 (print_help): Remove; unused.
349 (stop_character, last_timer_event): Mark as externally visible.
350 * keyboard.h (ignore_mouse_drag_p): Declare only if
351 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
352 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
353 * lisp.h (echoing): Remove decl.
354 (force_auto_save_soon): Declare only if SIGDANGER.
355 * xdisp.c (redisplay_window): Simplify code, to make it more
356 obvious that ignore_mouse_drag_p is not accessed if !defined
357 USE_GTK && !defined HAVE_NS.
358
93ea6e8f
PE
359 * intervals.c: Make symbols static if they're not exported.
360 (merge_properties_sticky, merge_interval_right, delete_interval):
361 Now static.
362 * intervals.h (merge_interval_right, delete_interval): Remove decls.
363
77382fcc
PE
364 * insdel.c: Make symbols static if they're not exported.
365 However, leave prepare_to_modify_buffer alone. It's never
366 called from outside this function, but that appears to be a bug.
367 (combine_after_change_list, combine_after_change_buffer):
4889fc82 368 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
369 (adjust_after_replace_noundo): Remove; unused.
370 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 371 (signal_before_change): Remove decls.
77382fcc 372
9306c32e
PE
373 * indent.c (val_compute_motion, val_vmotion): Now static.
374
cd44d2eb
PE
375 * image.c: Make symbols static if they're not exported.
376 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
377 if USE_GTK.
378 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
379 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
380
ad9a7a06
PE
381 * fringe.c (standard_bitmaps): Now static.
382 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
383
81626931
PE
384 * frame.c: Make symbols static if they're not exported.
385 (x_report_frame_params, make_terminal_frame): Now static.
386 (get_frame_param): Now static, unless HAVE_NS.
387 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
388 (x_get_resource_string): Remove; not used.
389 * frame.h (make_terminal_frame, x_report_frame_params):
390 (x_get_resource_string); Remove decls.
391 (x_fullscreen_adjust): Declare only if WINDOWSNT.
392 * lisp.h (get_frame_param): Declare only if HAVE_NS.
393
239f9db9
PE
394 * font.c, fontset.c: Make symbols static if they're not exported.
395 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
396 (FACE_SUITABLE_FOR_CHAR_P): Use it.
397 * font.c (font_close_object): Now static.
398 * font.h (font_close_object): Remove.
399 * fontset.c (FONTSET_OBJLIST): Remove.
400 (free_realized_fontset) #if-0 the body, which does nothing.
401 (face_suitable_for_char_p): #if-0, as it's never called.
402 * fontset.h (face_suitable_for_char_p): Remove decl.
403 * xfaces.c (face_at_string_position): Use
404 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
405 since 0 is always ASCII.
406
dfcf3579
PE
407 * fns.c (weak_hash_tables): Now static.
408
5045092b
PE
409 * fileio.c: Make symbols static if they're not exported.
410 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
411 (Vwrite_region_annotation_buffers): Now static.
412
57a96f5c
PE
413 * eval.c: Make symbols static if they're not exported.
414 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
415 * lisp.h (backtrace_list): Remove decl.
416
35f08c38
PE
417 * emacs.c: Make symbols static if they're not exported.
418 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
419 (fatal_error_code, fatal_error_signal_hook, standard_args):
420 Now static.
421 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
422 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
423 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
424 * lisp.h (fatal_error_signal_hook): Remove decl.
425 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
426
f44bd759
PE
427 * editfns.c: Move a (normally-unused) function to its only use.
428 * editfns.c, lisp.h (get_operating_system_release): Remove.
429 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
430 worth the hassle of breaking this out.
431
b532497d
PE
432 * xterm.c: Make symbols static if they're not exported.
433 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
434 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
435 (x_destroy_window, x_delete_display):
436 Now static.
437 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
438 (x_mouse_leave): Remove; unused.
439 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
440 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
441 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
442 Remove decls.
443 (x_mouse_leave): Declare only if WINDOWSNT.
444 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
445 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
446 USE_X_TOOLKIT.
447
1675728f
PE
448 * ftxfont.c: Make symbols static if they're not exported.
449 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
450 HAVE_FREETYPE.
451 * font.h (ftxfont_driver): Likewise.
452
e4cebfca
PE
453 * xfns.c: Make symbols static if they're not exported.
454 (x_last_font_name, x_display_info_for_name):
455 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
456 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
457 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
458 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
459 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
460 (last_show_tip_args): Now static.
461 (xic_defaut_fontset, xic_create_fontsetname): Define only if
462 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
463 (x_screen_planes): Remove; unused.
464 * dispextern.h (x_screen_planes): Remove decl.
465
5bf46f05
PE
466 * dispnew.c: Make symbols static if they're not exported.
467 * dispextern.h (redraw_garbaged_frames, scrolling):
468 (increment_row_positions): Remove.
469 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
470 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
471 Now static.
472 (redraw_garbaged_frames): Remove; unused.
473
435f4c28
PE
474 * xfaces.c: Make symbols static if they're not exported.
475 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
476 Remove decls.
477 * xterm.h (defined_color): Remove decls.
478 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
479 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
480 (menu_face_changed_default, defined_color, free_realized_face):
481 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
482 (ascii_face_of_lisp_face): Remove; unused.
483
8524aef3
PE
484 * xdisp.c: Make symbols static if they're not exported.
485 * dispextern.h (scratch_glyph_row, window_box_edges):
486 (glyph_to_pixel_coords, set_cursor_from_row):
487 (get_next_display_element, set_iterator_to_next):
488 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
489 (show_mouse_face): Remove decls
490 * frame.h (message_buf_print): Likewise.
491 * lisp.h (pop_message, set_message, check_point_in_composition):
492 Likewise.
493 * xterm.h (set_vertical_scroll_bar): Likewise.
494 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
495 (message_buf_print, scratch_glyph_row, displayed_buffer):
496 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
497 (get_next_display_element, show_mouse_face, window_box_edges):
498 (frame_to_window_pixel_xy, check_point_in_composition):
499 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
500 (glyph_to_pixel_coords): Remove; unused.
501
16390cd2
PE
502 * dired.c (file_name_completion): Now static.
503
504 * dbusbind.c (xd_in_read_queued_messages): Now static.
505
a25f4dfa
PE
506 * lisp.h (circular_list_error, FOREACH): Remove; unused.
507 * data.c (circular_list_error): Remove.
508
14a9c8df
PE
509 * commands.h (last_point_position, last_point_position_buffer):
510 (last_point_position_window): Remove decls.
511 * keyboard.c: Make these variables static.
512
74ab6df5
PE
513 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
514 decls.
515 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
516 (iso_code_class, detect_coding, code_convert_region): Now static.
517 (encode_coding_gap): Remove; unused.
518
38dfbee1
PE
519 * chartab.c (chartab_chars, chartab_bits): Now static.
520
a2cb4e63
PE
521 * charset.h (charset_iso_8859_1): Remove decl.
522 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
523 Now static.
524
127198fd
PE
525 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
526 * ccl.c (Vccl_program_table): Now static.
527 (check_ccl_update): Remove; unused.
528
d85b608f
PE
529 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
530 * category.h: ... from here.
531 * category.c (check_category_table, set_category_set): Now static.
532
31cd66f3
PE
533 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
534 * lisp.h: Remove these decls.
535
c358e587
PE
536 * buffer.c (buffer_count): Remove unused var.
537
e78aecca
PE
538 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
539 so that it's not optimized away.
540 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
541 * dispextern.h (bidi_dump_cached_states): Remove, since it's
542 exported only to the debugger.
543
e192d7d3
PE
544 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
545 * atimer.h (run_all_atimers): Removed; not exported.
546
92470028
PE
547 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
548 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
549 was inaccessible from Lisp.
550 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
551 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
552
244ed907
PE
553 alloc.c: Import and export fewer symbols, and remove unused items.
554 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
555 is defined.
556 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
557 it's not optimized away by whole-program optimization.
558 (message_enable_multibyte, free_misc): Remove.
559 (catchlist, handlerlist, mark_backtrace):
560 Declare only if BYTE_MARK_STACK.
561 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
562 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
563 (message_enable_multibyte): Remove decl.
564 (free_misc, interval_free_list, float_block, float_block_index):
565 (n_float_blocks, float_free_list, cons_block, cons_block_index):
566 (cons_free_list, last_marked_index):
567 Now static.
568 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
569 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
570 (mark_backtrace): Define only if BYTE_MARK_STACK.
571 * xdisp.c (message_enable_multibyte): Now static.
572
61c2b50e 573 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
574 This makes it easier for human readers (and static analyzers)
575 to see whether these variables are used from other modules.
576 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
577 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
578 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
579 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
580 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
581 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
582 * xmenu.c, xselect.c:
583 Declare Q* vars static if they are not used in other modules.
584 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
585 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
586 Remove decls of unexported vars.
587 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
588
95c82688
PE
589 * lisp.h (DEFINE_FUNC): Make sname 'static'.
590
16a97296
PE
591 Make Emacs functions such as Fatom 'static' by default.
592 This makes it easier for human readers (and static analyzers)
593 to see whether these functions can be called from other modules.
594 DEFUN now defines a static function. To make the function external
595 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
596 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
597 (Finit_image_library):
16a97296
PE
598 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
599 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
600 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
601 Remove decls, since these functions are now static.
602 (Funintern, Fget_internal_run_time): New decls, since these functions
603 were already external.
95c82688 604
16a97296
PE
605 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
606 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
607 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
608 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
609 * keyboard.c, keymap.c, lread.c:
610 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
611 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
612 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
613 Mark functions with DEFUE instead of DEFUN,
614 if they are used in other modules.
615 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
616 decls for now-static functions.
617 * buffer.h (Fdelete_overlay): Remove decl.
618 * callproc.c (Fgetenv_internal): Mark as internal.
619 * composite.c (Fremove_list_of_text_properties): Remove decl.
620 (Fcomposition_get_gstring): New forward static decl.
621 * composite.h (Fcomposite_get_gstring): Remove decl.
622 * dired.c (Ffile_attributes): New forward static decl.
623 * doc.c (Fdocumntation_property): New forward static decl.
624 * eval.c (Ffetch_bytecode): New forward static decl.
625 (Funintern): Remove extern decl; now in .h file where it belongs.
626 * fileio.c (Fmake_symbolic_link): New forward static decl.
627 * image.c (Finit_image_library): New forward static decl.
628 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
629 * intervals.h (Fprevious_property_change):
630 (Fremove_list_of_text_properties): Remove decls.
631 * keyboard.c (Fthis_command_keys): Remove decl.
632 (Fcommand_execute): New forward static decl.
633 * keymap.c (Flookup_key): New forward static decl.
634 (Fcopy_keymap): Now static.
635 * keymap.h (Flookup_key): Remove decl.
636 * process.c (Fget_process): New forward static decl.
637 (Fprocess_datagram_address): Mark as internal.
638 * syntax.c (Fsyntax_table_p): New forward static decl.
639 (skip_chars): Remove duplicate decl.
640 * textprop.c (Fprevious_property_change): New forward static decl.
641 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
642 Now internal.
643 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
644 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
645
785bbd42
PE
646 * editfns.c (Fformat): Remove unreachable code.
647
8b913b57
AS
6482011-04-14 Andreas Schwab <schwab@linux-m68k.org>
649
650 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
651 change. (Bug#8496)
652
a6744a35
EZ
6532011-04-13 Eli Zaretskii <eliz@gnu.org>
654
655 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
656 when at ZV. (Bug#8487)
657
e7974947
AS
6582011-04-12 Andreas Schwab <schwab@linux-m68k.org>
659
baad03f0
AS
660 * charset.c (Fclear_charset_maps): Use xfree instead of free.
661 (Bug#8437)
662 * keyboard.c (parse_tool_bar_item): Likewise.
663 * sound.c (sound_cleanup, alsa_close): Likewise.
664 * termcap.c (tgetent): Likewise.
665 * xfns.c (x_default_font_parameter): Likewise.
666 * xsettings.c (read_and_apply_settings): Likewise.
667
e7974947
AS
668 * alloc.c (overrun_check_malloc, overrun_check_realloc)
669 (overrun_check_free): Protoize.
670
28272684
PE
6712011-04-12 Paul Eggert <eggert@cs.ucla.edu>
672
673 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
674 since callers should never pass a negative size.
675 Change the signature to match that of plain 'read' and 'write'; see
676 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
677 * lisp.h: Update prototypes of emacs_write and emacs_read.
678
11997c76
EZ
6792011-04-11 Eli Zaretskii <eliz@gnu.org>
680
681 * xdisp.c (redisplay_window): Don't try to determine the character
682 position of the scroll margin if the window start point w->startp
e896f03c 683 is outside the buffer's accessible region. (Bug#8468)
11997c76 684
8a2cbd72
EZ
6852011-04-10 Eli Zaretskii <eliz@gnu.org>
686
687 Fix write-region and its subroutines for buffers > 2GB.
688 * fileio.c (a_write, e_write): Modify declaration of arguments and
689 local variables to support buffers larger than 2GB.
690 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
691
692 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
693 argument, local variables, and return value.
694
695 * lisp.h: Update prototypes of emacs_write and emacs_read.
696
697 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
698
4073e537 6992011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 700
1ebfdcb6
PE
701 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
702
b2ded58d
PE
703 Fix more problems found by GCC 4.6.0's static checks.
704
7d66342c
PE
705 * xdisp.c (vmessage): Use a better test for character truncation.
706
bbf47d44
PE
707 * charset.c (load_charset_map): <, not <=, for optimization,
708 and to avoid potential problems with integer overflow.
9248994d 709 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 710 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 711 * editfns.c (Fformat): Likewise.
1e69125e 712 * syntax.c (skip_chars): Likewise.
3befa583 713
e3019616
PE
714 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
715 This also lets GCC 4.6.0 generate slightly better loop code.
716
becfa255
PE
717 * callint.c (Fcall_interactively): <, not <=, for optimization.
718 (Fcall_interactively): Count the number of arguments produced,
719 not the number of arguments given. This is simpler and lets GCC
720 4.6.0 generate slightly better code.
721
dae0cd48
PE
722 * ftfont.c: Distingish more carefully between FcChar8 and char.
723 The previous code passed unsigned char * to a functions like
724 strlen and xstrcasecmp that expect char *, which does not
725 conform to the C standard.
726 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
727 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
728 char * when the C standard requires it.
729
76032d70
PE
730 * keyboard.c (read_char): Remove unused var.
731
eb3f1cc8
PE
732 * eval.c: Port to Windows vsnprintf (Bug#8435).
733 Include <limits.h>.
734 (SIZE_MAX): Define if the headers do not.
735 (verror): Do not give up if vsnprintf returns a negative count.
736 Instead, grow the buffer. This ports to Windows vsnprintf, which
737 does not conform to C99. Problem reported by Eli Zaretskii.
738 Also, simplify the allocation scheme, by avoiding the need for
739 calling realloc, and removing the ALLOCATED variable.
740
70476b54
PE
741 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
742
12020a9e
PE
743 Remove invocations of doprnt, as Emacs now uses vsnprintf.
744 But keep the doprint source code for now, as we might revamp it
745 and use it again (Bug#8435).
ea6c7ae6
PE
746 * lisp.h (doprnt): Remove.
747 * Makefile.in (base_obj): Remove doprnt.o.
748 * deps.mk (doprnt.o): Remove.
749
5fdb398c
PE
750 error: Print 32- and 64-bit integers portably (Bug#8435).
751 Without this change, on typical 64-bit hosts error ("...%d...", N)
752 was used to print both 32- and 64-bit integers N, which relied on
753 undefined behavior.
754 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
755 New macro.
756 * lisp.h (error, verror): Mark as printf-like functions.
757 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
758 Report overflow in size calculations when allocating printf buffer.
759 Do not truncate output string at its first null byte.
760 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
761 Truncate the output at a character boundary, since vsnprintf does not
762 do that.
763 * charset.c (check_iso_charset_parameter): Convert internal
764 character to string before calling 'error', since %c now has the
765 printf meaning.
766 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
767 overflow when computing char to be passed to 'error'. Do not
768 pass Lisp_Object to 'error'; pass the integer instead.
769 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
770 formatted with plain %d.
771
b189fa66
PE
772 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
773
bff87ef0
PE
774 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
775
7e2cac20
PE
776 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
777
ce4d90b5
PE
778 * xterm.c (x_catch_errors): Remove duplicate declaration.
779
266c9547
PE
780 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
781
79c49ad2
PE
782 * xdisp.c, lisp.h (message_nolog): Remove; unused.
783
368f4090
JM
7842011-04-10 Jim Meyering <meyering@redhat.com>
785
786 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
787 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
788 return ssize_t not "int", and use size_t as the buffer length.
789 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
790 * gnutls.h: Update declarations.
791 * process.c (read_process_output): Use ssize_t, to match.
792 (send_process): Likewise.
793
a32d4040
CY
7942011-04-09 Chong Yidong <cyd@stupidchicken.com>
795
796 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
797
8546720e 7982011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 799
8546720e
GM
800 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
801 unsigned char, to match FcChar8 type definition.
aac0c6e3 802
8546720e
GM
803 * xterm.c (handle_one_xevent):
804 * xmenu.c (create_and_show_popup_menu):
805 * xselect.c (x_decline_selection_request)
806 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 807
0a2f5c1a 8082011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
809
810 Fix some uses of `int' instead of EMACS_INT.
811 * search.c (string_match_1, fast_string_match)
812 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
813 (scan_buffer, find_next_newline_no_quit)
814 (find_before_next_newline, search_command, Freplace_match)
815 (Fmatch_data): Make some `int' variables be EMACS_INT.
816
817 * xdisp.c (display_count_lines): 3rd argument and return value now
818 EMACS_INT. All callers changed.
819 (pint2hrstr): Last argument is now EMACS_INT.
820
821 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
822 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
823 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
824 (decode_coding_utf_16, decode_coding_emacs_mule)
825 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
826 (decode_coding_ccl, decode_coding_charset)
827 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
828 (decode_coding_iso_2022, decode_coding_emacs_mule)
829 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
830 <char_offset, last_offset>: Declare EMACS_INT.
831 (encode_coding_utf_8, encode_coding_utf_16)
832 (encode_coding_emacs_mule, encode_invocation_designation)
833 (encode_designation_at_bol, encode_coding_iso_2022)
834 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
835 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
836 Declare EMACS_INT.
837 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
838 (encode_invocation_designation): Last argument P_NCHARS is now
839 EMACS_INT.
840 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
841 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
842
843 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
844 All users changed.
845
846 * ccl.c (Fccl_execute_on_string): Declare some variables
847 EMACS_INT.
848
8546720e 8492011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
850
851 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
852
4e19a977
CS
8532011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
854
855 * process.c (Fformat_network_address): Doc fix.
856
87302331
R
8572011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
858
859 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
860
cbb59342
CY
8612011-04-08 Chong Yidong <cyd@stupidchicken.com>
862
863 * keyboard.c (read_char): Call Lisp function help-form-show,
864 instead of using internal_with_output_to_temp_buffer.
865 (Qhelp_form_show): New var.
e0d38eeb 866 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
867
868 * print.c (internal_with_output_to_temp_buffer): Function deleted.
869
870 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
871
e67a13ab
CY
8722011-04-06 Chong Yidong <cyd@stupidchicken.com>
873
874 * process.c (Flist_processes): Removed to Lisp.
875 (list_processes_1): Deleted.
876
973f782d
EZ
8772011-04-06 Eli Zaretskii <eliz@gnu.org>
878
7c106b1e
EZ
879 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
880
973f782d
EZ
881 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
882
41cf7d1a 8832011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 884
ca23cc88
PE
885 Fix more problems found by GCC 4.6.0's static checks.
886
f390e2d5
PE
887 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
888
42eea0d0
PE
889 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
890
b69769da 891 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 892
f9541e84
PE
893 * xdisp.c (vmessage): Mark as a printf-like function.
894
13841b55
PE
895 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
896
c136c10f
PE
897 * sound.c (sound_warning): Don't crash if arg contains a printf format.
898
5e2d4a30
PE
899 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
900 printf-like functions.
901 (tiff_load): Add casts to remove these marks before passing them
902 to system-supplied API.
903
583f48b9
PE
904 * eval.c (Fsignal): Remove excess argument to 'fatal'.
905
b25d760e
PE
906 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
907 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
908 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
909 directly, rather than having caller test rule sign. This avoids
910 some unnecessary tests.
911 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
912 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
913 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 914
bc7b6697 915 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 916 (xfont_open): Avoid unnecessary tests.
bc7b6697 917
27ccc379
PE
918 * composite.c (composition_gstring_put_cache): Use unsigned integer.
919
dcd5c89a
PE
920 * composite.h, composite.c (composition_gstring_put_cache):
921 Use EMACS_INT, not int, for length.
922
b13a45c6
PE
923 * composite.h (COMPOSITION_DECODE_REFS): New macro,
924 breaking out part of COMPOSITION_DECODE_RULE.
925 (COMPOSITION_DECODE_RULE): Use it.
926 * composite.c (get_composition_id): Remove unused local vars,
927 by using the new macro.
928
1e792e4d
PE
929 * textprop.c (set_text_properties_1): Change while to do-while,
930 since the condition is always true at first.
931
dc6c6455 932 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
933 (interval_deletion_adjustment): Return unsigned value.
934 All uses changed.
dc6c6455 935
aba7731a
PE
936 * process.c (list_processes_1, create_pty, read_process_output):
937 (exec_sentinel): Remove vars that were set but not used.
afd4052b 938 (create_pty): Remove unnecessary "volatile"s.
bc57d757 939 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 940 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 941 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 942
fdfc4bf3
PE
943 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
944
fca8fe46 945 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 946 (update_syntax_table): Use unsigned instead of int.
fca8fe46 947
06a0259a 948 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 949 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 950 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 951
e7b9e80f
PE
952 * print.c (print_error_message): Avoid int overflow.
953
56201685
PE
954 * font.c (font_list_entities): Redo for clarity,
955 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
956
78834453 957 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 958 (font_score): Avoid potential overflow in diff calculation.
78834453 959
0bc0b309 960 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 961 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 962
e610eaca
PE
963 * eval.c (funcall_lambda): Rename local to avoid shadowing.
964
b895abce
PE
965 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
966 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
967 can always succeed if overflow has undefined behavior.
968
1f1d9321 969 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 970 (wordify): Omit three unnecessary tests.
1f1d9321 971
c59478bc
PE
972 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
973 All callers changed. This avoids the need for an unused var.
974
79b73827
PE
975 * casefiddle.c (casify_region): Remove var that is set but not used.
976
a4db5dfe
PE
977 * dired.c (file_name_completion): Remove var that is set but not used.
978
43aae36e
PE
979 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
980
2a47c44d 981 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 982 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 983
a37c69bf
PE
984 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
985 Check for integer overflow on size calculations.
986
328ab8e7
PE
987 * buffer.c (Fprevious_overlay_change): Remove var that is set
988 but not used.
989
e5a2a5cb
PE
990 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
991 Remove vars that are set but not used.
8d84a6eb 992 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 993 (timer_check_2): Mark vars as initialized.
e5a2a5cb 994
a60e5f68
PE
995 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
996
f661cb61 997 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 998 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 999
f0397f5a
PE
1000 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1001 that are set but not used.
1002
8664db06 1003 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1004 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1005
6abdaa4a
PE
1006 * xselect.c (x_get_local_selection, x_handle_property_notify):
1007 Remove vars that are set but not used.
1008
0ce7538d 1009 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1010 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1011
9ae848fc
PE
1012 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1013 Remove var that is set but not used.
0b918413
PE
1014 (scroll_bar_windows_size): Now size_t, not int.
1015 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1016 Check for overflow.
9ae848fc 1017
a5a62657
PE
1018 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1019 (map_tty_color) [!defined MSDOS]: Likewise.
1020
5c5cdd39
PE
1021 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1022
66ebf983
PE
1023 * coding.c: Remove vars that are set but not used.
1024 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1025 All callers changed.
1026 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1027 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1028 (decode_coding_charset): Remove vars that are set but not used.
1029
1be4d761
PE
1030 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1031 that is set but not used.
1032
47553fa8
PE
1033 * print.c (print_object): Remove var that is set but not used.
1034
1f7196bf 1035 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1036 The gnulib version avoids calling malloc in the usual case,
1037 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1038 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1039 * filelock.c (current_lock_owner): Likewise.
1040 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1041 * sysdep.c: Include allocator.h, careadlinkat.h.
1042 (emacs_no_realloc_allocator): New static constant.
1043 (emacs_readlink): New function.
fdb61804
PE
1044 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1045 ../lib/careadlinkat.h.
d1fdcab7 1046
f84c17c7
SM
10472011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1048
1049 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1050 first non-nil return value).
1051
ef3862ad
JD
10522011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1053
1054 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1055 if not defined (Bug#8403).
1056
376a7006
JB
10572011-04-02 Juanma Barranquero <lekktu@gmail.com>
1058
1059 * xdisp.c (display_count_lines): Remove parameter `start',
1060 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1061 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1062 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1063 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1064 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1065 and thereabouts. All callers changed.
1066 (get_per_char_metric): Remove parameter `f', unused since
1067 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1068
6ca3801d
JM
10692011-04-02 Jim Meyering <meyering@redhat.com>
1070
1071 do not dereference NULL upon failed strdup
1072 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1073 (ns_get_family): Likewise.
1074
d8e2b5ba
JB
10752011-04-02 Juanma Barranquero <lekktu@gmail.com>
1076
1077 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1078
8c74fcbd
JD
10792011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1080
1081 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1082 later (Bug#8403).
1083
7200d79c
SM
10842011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1085
03408648 1086 Add lexical binding.
7200d79c 1087
03408648
SM
1088 * window.c (Ftemp_output_buffer_show): New fun.
1089 (Fsave_window_excursion):
1090 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1091
1092 * lread.c (lisp_file_lexically_bound_p): New function.
1093 (Fload): Bind Qlexical_binding.
1094 (readevalloop): Remove `evalfun' arg.
1095 Bind Qinternal_interpreter_environment.
1096 (Feval_buffer): Bind Qlexical_binding.
1097 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1098 Mark as dynamic.
1099 (syms_of_lread): Declare `lexical-binding'.
1100
1101 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1102
1103 * keyboard.c (eval_dyn): New fun.
1104 (menu_item_eval_property): Use it.
ca105506
SM
1105
1106 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1107
03408648
SM
1108 * fns.c (concat, mapcar1): Accept byte-code-functions.
1109
1110 * eval.c (Fsetq): Handle lexical vars.
1111 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1112 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1113 (FletX, Flet): Obey lexical binding.
1114 (Fcommandp): Handle closures.
1115 (Feval): New `lexical' arg.
1116 (eval_sub): New function extracted from Feval. Use it almost
1117 everywhere where Feval was used. Look up vars in lexical env.
1118 Handle closures.
1119 (Ffunctionp): Move from subr.el.
1120 (Ffuncall): Handle closures.
1121 (apply_lambda): Remove `eval_flags'.
1122 (funcall_lambda): Handle closures and new byte-code-functions.
1123 (Fspecial_variable_p): New function.
1124 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1125 but without exporting it to Lisp.
23aba0ea 1126
23aba0ea 1127 * doc.c (Fdocumentation, store_function_docstring):
03408648 1128 * data.c (Finteractive_form): Handle closures.
23aba0ea 1129
03408648
SM
1130 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1131 interactive spec.
ba83908c 1132
03408648
SM
1133 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1134 byte-codes.
1135 (exec_byte_code): New function extracted from Fbyte_code to handle new
1136 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1137
03408648 1138 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1139
03408648 1140 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1141
e2abce01
JB
11422011-03-31 Juanma Barranquero <lekktu@gmail.com>
1143
1144 * xdisp.c (redisplay_internal): Fix prototype.
1145
63696a73 11462011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1147
63696a73
EZ
1148 * xdisp.c (SCROLL_LIMIT): New macro.
1149 (try_scrolling): Use it when setting scroll_limit. Limit
1150 scrolling to 100 screen lines.
1151 (redisplay_window): Even when falling back on "recentering",
1152 position point in the window according to scroll-conservatively,
1153 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1154
1155 (try_scrolling): When point is above the window, allow searching
1156 as far as scroll_max, or one screenful, to compute vertical
1157 distance from PT to the scroll margin position. This prevents
1158 try_scrolling from unnecessarily failing when
1159 scroll-conservatively is set to a value slightly larger than the
1160 window height. Clean up the case of PT below the margin at bottom
1161 of window: scroll_max can no longer be INT_MAX. When aggressive
1162 scrolling is in use, don't let point enter the opposite scroll
1163 margin as result of the scroll.
1164 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1165 threshold of 100 lines for never-recentering scrolling.
1166
e4cc2dfc
JB
11672011-03-31 Juanma Barranquero <lekktu@gmail.com>
1168
1169 * dispextern.h (move_it_by_lines):
1170 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1171 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1172 (message_log_check_duplicate): Remove parameters `prev_bol' and
1173 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1174 (redisplay_internal): Remove parameter `preserve_echo_area',
1175 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1176
1177 * indent.c (Fvertical_motion):
1178 * window.c (window_scroll_pixel_based, Frecenter):
1179 Don't pass `need_y_p' to `move_it_by_lines'.
1180
1c470562
SM
11812011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1182
44f230aa
SM
1183 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1184 steal a few bits to be more compact.
1185 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1186 Remove unneeded casts.
1187
1c470562
SM
1188 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1189
888adce9
ZK
11902011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1191
1192 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1193 binding" message (bug#7967).
1194
f838ed7b
PE
11952011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1196
77861b95
PE
1197 Fix more problems found by GCC 4.6.0's static checks.
1198
de6dbc14
PE
1199 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1200 Remove unused local var.
1201
f838ed7b
PE
1202 * editfns.c (Fmessage_box): Remove unused local var.
1203
792c7b2b
PE
1204 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1205 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1206 Omit unused local vars.
c499e557 1207 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1208 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1209 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1210 Omit unused local var.
1211
ba0165e1
PE
1212 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1213 Don't assume string length fits in int.
32ad8845 1214 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1215 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1216
3c59b4c9
PE
1217 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1218 instead of alloca (Bug#8344).
1219
a3eed478 1220 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1221 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1222
eb4d412d
PE
1223 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1224
1658b401
PE
1225 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1226 concerns.
1227
1228 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1229
1230 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1231
9a2c6e05
PE
1232 * keyboard.c (syms_of_keyboard): Use the same style as later
1233 in this function when indexing through an array. This also
1234 works around GCC bug 48267.
1235
03d0a109
PE
1236 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1237
44f730c8
PE
1238 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1239
fe75f926
PE
1240 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1241 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1242
ffa8c828
PE
1243 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1244 This avoids undefined behavior on integer overflow, and is a bit
1245 more convenient anyway since it is compared to a size_t variable.
1246
c5101a77
PE
1247 Variadic C functions now count arguments with size_t, not int.
1248 This avoids an unnecessary limitation on 64-bit machines, which
1249 caused (substring ...) to crash on large vectors (Bug#8344).
1250 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1251 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1252 All variadic functions and their callers changed accordingly.
c5101a77
PE
1253 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1254 * data.c (arith_driver, float_arith_driver): Likewise.
1255 * editfns.c (general_insert_function): Likewise.
1256 * eval.c (struct backtrace.nargs, interactive_p)
1257 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1258 (funcall_lambda, mark_backtrace): Likewise.
1259 * fns.c (concat): Likewise.
1260 * frame.c (x_set_frame_parameters): Likewise.
1261 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1262 0 if not found, not -1. All callers changed.
1263
dd3f25f7
PE
1264 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1265 (stack_copy_size): Now size_t, not int.
1266 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1267
461c2ab9
JB
12682011-03-28 Juanma Barranquero <lekktu@gmail.com>
1269
1270 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1271 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1272 All callers changed.
1273
1274 * lisp.h (multibyte_char_to_unibyte):
1275 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1276 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1277 * character.h (CHAR_TO_BYTE8):
1278 * cmds.c (internal_self_insert):
1279 * editfns.c (general_insert_function):
1280 * keymap.c (push_key_description):
1281 * search.c (Freplace_match):
1282 * xdisp.c (message_dolog, set_message_1): All callers changed.
1283
f6d62986
SM
12842011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1285
1286 * keyboard.c (safe_run_hook_funcall): New function.
1287 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1288 don't set the hook to nil, but remove the offending function instead.
1289 (Qcommand_hook_internal): Remove, unused.
1290 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1291 Vcommand_hook_internal.
1292
1293 * eval.c (enum run_hooks_condition): Remove.
1294 (funcall_nil, funcall_not): New functions.
1295 (run_hook_with_args): Call each function through a `funcall' argument.
1296 Remove `cond' argument, now redundant.
1297 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1298 (Frun_hook_with_args_until_failure): Adjust accordingly.
1299 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1300
1db5b1ad
JB
13012011-03-28 Juanma Barranquero <lekktu@gmail.com>
1302
1303 * dispextern.h (string_buffer_position): Remove declaration.
1304
1305 * print.c (strout): Remove parameter `multibyte', unused since
1306 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1307
1308 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1309 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1310 All callers changed.
1311
1312 * w32.c (_wsa_errlist): Use braces for struct initializers.
1313
1314 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1315 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1316 All callers changed.
1317 (string_buffer_position): Likewise. Also, make static (it's never
1318 used outside xdisp.c).
1319 (cursor_row_p): Remove parameter `w', unused since
1320 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1321 (decode_mode_spec): Remove parameter `precision', introduced during
1322 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1323 All callers changed.
1324
5ffb62aa
JD
13252011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1326
1327 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1328
461c2ab9 13292011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1330
1331 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1332 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1333 (ns_update_auto_hide_menu_bar): New functions.
1334 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1335 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1336 ns_constrain_all_frames.
1337 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1338 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1339
5c380ffb
JD
13402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1341
1342 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1343
9af30bdf
GM
13442011-03-27 Glenn Morris <rgm@gnu.org>
1345
1346 * syssignal.h: Replace RETSIGTYPE with void.
1347 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1348 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1349 Replace SIGTYPE with void everywhere.
1350 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1351 * s/template.h (SIGTYPE): Remove commented out definition.
1352
e2abce01
JB
13532011-03-26 Eli Zaretskii <eliz@gnu.org>
1354
1355 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1356 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1357
f868cd8a
JB
13582011-03-26 Juanma Barranquero <lekktu@gmail.com>
1359
59eb0929
JB
1360 * w32.c (read_unc_volume): Use parameter `henum', instead of
1361 global variable `wget_enum_handle'.
1362
1363 * keymap.c (describe_vector): Remove parameters `indices' and
1364 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1365 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1366
f868cd8a
JB
1367 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1368
1369 * keyboard.c (timer_check): Remove parameter `do_it_now',
1370 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1371 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1372 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1373
1374 * keyboard.c (read_char):
1375 * w32menu.c (w32_menu_display_help):
1376 * xmenu.c (show_help_event, menu_help_callback):
1377 Adjust calls to `show_help_echo'.
1378
1379 * gtkutil.c (xg_maybe_add_timer):
1380 * keyboard.c (readable_events):
1381 * process.c (wait_reading_process_output):
1382 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1383
1384 * insdel.c (adjust_markers_gap_motion):
1385 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1386 (gap_left, gap_right): Don't call it.
1387
2ecf6fdb
CY
13882011-03-25 Chong Yidong <cyd@stupidchicken.com>
1389
1390 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1391 incurred during fontification.
1392
6b1f9ba4
JB
13932011-03-25 Juanma Barranquero <lekktu@gmail.com>
1394
1395 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1396 (DEFVAR_PER_BUFFER): Don't pass it.
1397
1398 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1399 (scrolling_window): Don't pass it.
1400
0f4a96b5
JB
14012011-03-25 Juanma Barranquero <lekktu@gmail.com>
1402
1403 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1404
1405 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1406 and `suffix'.
1407 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1408 of variables specific to SELinux and computation of `encoded_absname'.
1409
1410 * image.c (XPutPixel): Remove unused variable `height'.
1411
1412 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1413
1414 * unexw32.c (get_section_info): Remove unused variable `section'.
1415
1416 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1417 (system_process_attributes): Remove unused variable `sess'.
1418 (sys_read): Remove unused variable `err'.
1419
1420 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1421 (w32_wnd_proc): Remove unused variable `isdead'.
1422 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1423 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1424 (x_create_tip_frame): Remove unused variable `tem'.
1425
1426 * w32inevt.c (w32_console_read_socket):
1427 Remove unused variable `no_events'.
1428
1429 * w32term.c (x_draw_composite_glyph_string_foreground):
1430 Remove unused variable `width'.
1431
1149507c
JB
14322011-03-24 Juanma Barranquero <lekktu@gmail.com>
1433
1434 * w32term.c (x_set_glyph_string_clipping):
1435 Don't pass uninitialized region to CombineRgn.
1436
9c88f339
JB
14372011-03-23 Juanma Barranquero <lekktu@gmail.com>
1438
1439 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1440 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1441 (Fx_close_connection): Remove unused variable `i'.
1442
1443 * w32font.c (w32font_draw): Return number of glyphs.
1444 (w32font_open_internal): Remove unused variable `i'.
1445 (w32font_driver): Add missing initializer.
1446
1447 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1448 (fill_in_menu): Remove unused variable `items_added'.
1449
1450 * w32term.c (last_mouse_press_frame): Remove static global variable.
1451 (w32_clip_to_row): Remove unused variable `f'.
1452 (x_delete_terminal): Remove unused variable `i'.
1453
1454 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1455 (NOTHING): Remove unused static global variable.
1456 (uniscribe_check_otf): Remove unused variable `table'.
1457 (uniscribe_font_driver): Add missing initializers.
1458
dee091a3
JD
14592011-03-23 Julien Danjou <julien@danjou.info>
1460
1461 * term.c (Fsuspend_tty, Fresume_tty):
1462 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1463 * window.c (temp_output_buffer_show):
1464 * insdel.c (signal_before_change):
1465 * frame.c (Fhandle_switch_frame):
1466 * fileio.c (Fdo_auto_save):
1467 * emacs.c (Fkill_emacs):
1468 * editfns.c (save_excursion_restore):
1469 * cmds.c (internal_self_insert):
1470 * callint.c (Fcall_interactively):
1471 * buffer.c (Fkill_all_local_variables):
1472 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1473 Use Frun_hooks.
0f4a96b5 1474 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1475 unconditionnaly since it does the check itself.
1476
2c520ab5 14772011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1478
c9c49752
PE
1479 Fix more problems found by GCC 4.5.2's static checks.
1480
8abc3f12
PE
1481 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1482 the first time through the loop, since we know p0 < p1 then.
1483 This also avoids a gcc -Wstrict-overflow warning.
1484
a2d26660
PE
1485 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1486 leading to a memory leak, possible in functions like
1487 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1488 of objects (Bug#8318).
a2d26660 1489
916c72e9
PE
1490 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1491 that could (at least in theory) be that large.
1492
19ab8a18
PE
1493 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1494 This is less likely to overflow, and avoids undefined behavior if
1495 overflow does occur. All callers changed. Use strtoul to scan
1496 for the unsigned long integer.
b7cbbd6f
PE
1497 (pint2hrstr): Simplify and tune code slightly.
1498 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1499
f0641eff
PE
1500 * scroll.c (do_scrolling): Work around GCC bug 48228.
1501 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1502
7f650bb9
PE
1503 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1504 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1505 (validate_x_resource_name): Simplify count usage.
1506 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1507
37dd57d1
PE
1508 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1509 fail (Bug#8306).
81e56e61 1510
699979fc 1511 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1512
401bf9b4
PE
1513 * process.c (Fmake_network_process): Use socklen_t, not int,
1514 where POSIX says socklen_t is required in portable programs.
1515 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1516 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1517 (Fmake_network_process, server_accept_connection):
1518 (wait_reading_process_output, read_process_output):
1519 Likewise.
1520
b93aacde
PE
1521 * process.c: Rename or move locals to avoid shadowing.
1522 (list_processes_1, Fmake_network_process):
1523 (read_process_output_error_handler, exec_sentinel_error_handler):
1524 Rename or move locals.
4dc343ee 1525 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1526 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1527 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1528 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1529 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1530
af8a867c 1531 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1532 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1533 Include tparam.h instead, since it declares them.
af8a867c
PE
1534 * cm.h (PC): Remove extern decl; tparam.h now does this.
1535 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1536 * terminfo.c: Include tparam.h, to check interfaces.
1537 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1538 (tparam): Adjust signature to match interface in tparam.h;
1539 this removes some undefined behavior. Check that outstring and len
1540 are zero, which they always are with Emacs.
1541 * tparam.h (PC, BC, UP): New extern decls.
1542
0248044d 1543 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1544 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1545
8ff096c1 1546 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1547 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1548 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1549 (ftfont_list): Remove unused local.
49eaafba
PE
1550 (get_adstyle_property, ftfont_pattern_entity):
1551 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1552 Rename locals to avoid shadowing.
8ff096c1 1553
e2be39f6
PE
1554 * xfont.c (xfont_list_family): Mark var as initialized.
1555
c9735e30
PE
1556 * xml.c (make_dom): Now static.
1557
8f5201ae
PE
1558 * composite.c (composition_compute_stop_pos): Rename local to
1559 avoid shadowing.
b246f932
PE
1560 (composition_reseat_it): Remove unused locals.
1561 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1562 (composition_update_it): Mark var as initialized.
11b61122
PE
1563 (find_automatic_composition): Mark vars as initialized,
1564 with a FIXME (Bug#8290).
8f5201ae 1565
760fbc2c
PE
1566 character.h: Rename locals to avoid shadowing.
1567 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1568 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1569 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1570 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1571 to avoid shadowing.
1572
ff08eb85
PE
1573 * textprop.c (property_change_between_p): Remove; unused.
1574
fc7bf025
PE
1575 * intervals.c (interval_start_pos): Now static.
1576
235d7abc
PE
1577 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1578
44f230aa
SM
1579 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1580 Rename locals to avoid shadowing.
3e7d6594 1581
50060332
PE
1582 * sound.c (wav_play, au_play, Fplay_sound_internal):
1583 Fix pointer signedness.
d01f234b 1584 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1585 (wav_play): Initialize a variable to 0, to prevent undefined
1586 behavior (Bug#8278).
50060332 1587
c4fc4e30
PE
1588 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1589
918436ed
PE
1590 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1591
c939f91b
PE
1592 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1593 clobbering (Bug#8298).
b9c7f648
PE
1594 * sysdep.c (sys_subshell): Likewise.
1595 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1596
6bd8c144
PE
1597 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1598 This should get cleaned up, so that child_setup has the
1599 same signature on all platforms.
1600
7710357c 1601 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1602 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1603
c59da222
CY
16042011-03-22 Chong Yidong <cyd@stupidchicken.com>
1605
1606 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1607 not to be necessary, and produces flickering.
1608
66b87493
GM
16092011-03-20 Glenn Morris <rgm@gnu.org>
1610
1611 * config.in: Remove file.
1612
45b6f6d5
JB
16132011-03-20 Juanma Barranquero <lekktu@gmail.com>
1614
1615 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1616 are now in src/globals.h.
1617 (syms_of_minibuf): Remove spurious & from previous change.
1618
3ec03f7e
LL
16192011-03-20 Leo <sdl.web@gmail.com>
1620
1621 * minibuf.c (completing-read-function): New variable.
1622 (completing-read-default): Rename from completing-read.
1623 (completing-read): Call completing-read-function.
1624
b14e3e21
CY
16252011-03-19 Juanma Barranquero <lekktu@gmail.com>
1626
1627 * xfaces.c (Fx_load_color_file):
1628 Read color file from absolute filename (bug#8250).
1629
f2b726e6
JB
16302011-03-19 Juanma Barranquero <lekktu@gmail.com>
1631
1632 * makefile.w32-in: Update dependencies.
1633
09f6ff02
EZ
16342011-03-17 Eli Zaretskii <eliz@gnu.org>
1635
1636 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1637
29a6015a
PE
16382011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1639
a3a6c54e
PE
1640 Fix more problems found by GCC 4.5.2's static checks.
1641
b766f867
PE
1642 * process.c (make_serial_process_unwind, send_process_trap):
1643 (sigchld_handler): Now static.
1644
be02381c
PE
1645 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1646 That way, the code declares only the vars that it needs.
1647 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1648 * s/cygwin.h (PTY_ITERATION): Likewise.
1649 * s/darwin.h (PTY_ITERATION): Likewise.
1650 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1651
57048744
PE
1652 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1653 * process.c (allocate_pty): Don't declare stb unless it's needed.
1654
7914961c 1655 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1656 (CONSTANTLIM): Remove; unused.
1657 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1658 Define only if needed.
7914961c 1659
b3967b18
PE
1660 * unexelf.c (unexec): Name an expression,
1661 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1662 Use a different way to cause a compilation error if anyone uses
1663 n rather than nn, a way that does not involve shadowing.
73366a00 1664 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1665
29a6015a
PE
1666 * deps.mk (unexalpha.o): Remove; unused.
1667
43cfc33e 1668 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1669 * unexec.h: New file.
ce701a33
PE
1670 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1671 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1672 Depend on unexec.h.
1673 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1674 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1675 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1676 Change as necessary to match prototype in unexec.h.
ce701a33 1677
01f44d5a
PE
1678 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1679 shadowing.
4f63c6bb 1680 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1681
a6670b0b
PE
1682 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1683 Rename locals to avoid shadowing.
1684
cef2010d 1685 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1686 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1687
d4d7173a
PE
1688 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1689
f08b802a
PE
1690 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1691 warning when compiling print.c.
1692
3ddb0639
PE
1693 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1694 instead of using an uninitialized var.
5ad03b97 1695 (font_sort_entities): Mark var as initialized.
3ddb0639 1696
170a2692
PE
1697 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1698
e663c700
PE
1699 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1700 pointers to constants.
89bc529a 1701 (font_parse_fcname): Remove unused vars.
7b81e2d0 1702 (font_delete_unmatched): Now static.
ea838e10 1703 (font_get_spec): Remove; unused.
13a547c6
PE
1704 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1705 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1706 Rename or move locals to avoid shadowing.
e663c700 1707
2a80c887 1708 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1709 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1710
1384fa33 1711 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1712 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1713
8b2c52e9
PE
1714 * alloc.c (mark_backtrace): Move decl from here ...
1715 * lisp.h: ... to here, so that it can be checked.
1716
475545b5 1717 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1718 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1719 (lisp_indirect_variable): Name an expression,
1720 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1721 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1722
b1349114 1723 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1724 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1725 Use const pointer when appropriate.
b1349114 1726
a2928364
PE
1727 * lisp.h (get_system_name, get_operating_system_release):
1728 Move decls here, to check interfaces.
1729 * process.c (get_operating_system_release): Move decl to lisp.h.
1730 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1731 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1732 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1733 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1734 (Fformat_time_string, Fencode_time, Finsert_char):
1735 (Ftranslate_region_internal, Fformat):
1736 Rename or remove local vars to avoid shadowing.
9710023e 1737 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1738
a415e694
PE
1739 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1740 avoid shadowing.
1741
8ef4622d
PE
1742 * lisp.h (eassert): Check that the argument compiles, even if
1743 ENABLE_CHECKING is not defined.
1744
946f9a5b
PE
1745 * data.c (Findirect_variable): Name an expression, to avoid
1746 gcc -Wbad-function-cast warning.
112396d6 1747 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1748 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1749 (Fmake_variable_buffer_local, Fmake_local_variable):
1750 Mark variables as initialized.
52746918 1751 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1752
e5aab7e7 1753 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1754 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1755 Rename locals to avoid shadowing.
dff45157
PE
1756 (mark_stack): Move local variables into the #ifdef region where
1757 they're used.
7bc26fdb
PE
1758 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1759 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1760 needed otherwise.
1761 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1762 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1763 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1764
e5aab7e7
PE
1765 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1766 avoids undefined behavior in theory.
1767
4da60324
PE
1768 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1769
88043301
PE
1770 Use functions, not macros, for up- and down-casing (Bug#8254).
1771 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1772 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1773 to use the following functions instead of these macros.
1774 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1775 EMACS_INT, since callers assume the returned value fits in int.
1776 (upcase1): Likewise, for UPCASE_TABLE.
1777 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1778 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1779 the race-condition problem in the old DOWNCASE.
88043301 1780
19ed5445
PE
1781 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1782 Rename locals to avoid shadowing.
1783 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1784 (regex_compile, re_search_2, re_match_2_internal):
1785 Remove unused local vars.
952db0d7
PE
1786 (FREE_VAR): Rewrite so as not to use empty "else",
1787 which gcc can warn about.
da053e48 1788 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1789 (RETALLOC_IF): Define only if needed.
1790 (WORDCHAR_P): Likewise. This one is never needed, but is used
1791 only in a comment talking about a compiler bug, so put inside
1792 the #if 0 of that comment.
1793 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1794 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1795 Remove; unused.
19ed5445 1796
1f3561e4 1797 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1798 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1799 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1800
ded6f8f7
PE
1801 * search.c (simple_search): Remove unused var.
1802
dbd37a95
PE
1803 * dired.c (compile_pattern): Move decl from here ...
1804 * lisp.h: ... to here, so that it can be checked.
1805 (struct re_registers): New forward decl.
1806
7e47afad
PE
1807 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1808
85f24f61
PE
1809 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1810 All uses changed.
1811 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1812 Rename locals to avoid shadowing.
5671df8f 1813 (Fvertical_motion): Mark locals as initialized.
85f24f61 1814
181aa2be 1815 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1816 (casify_region): Mark local as initialized.
181aa2be 1817
930d429c
PE
1818 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1819
7082eac6
PE
1820 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1821 New macros, so that the caller can use some names other than
1822 gcpro1, gcpro2, etc.
1823 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1824 of the new macros.
1825 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1826 argument, for consistency with GCPRO2_VAR, etc: it is now the
1827 prefix of the variable, not the variable itself. All uses
1828 changed.
38b2c076
PE
1829 * dired.c (directory_files_internal, file_name_completion):
1830 Rename locals to avoid shadowing.
1831
15206ed9
PE
1832 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1833 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1834 dired.c's scmp function, had undefined behavior.
1835 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1836 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1837 * buffer.h: ... to here, because these macros use current_buffer,
1838 and the new implementation with inline functions needs to have
1839 current_buffer in scope now, rather than later when the macros
1840 are used.
1841 (downcase, upcase1): New static inline functions.
1842 (DOWNCASE, UPCASE1): Reimplement using these functions.
1843 This avoids undefined behavior in expressions like
1844 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1845 from race conditions in accessing the global variables
1846 case_temp1 and case_temp2.
1847 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1848 * lisp.h (case_temp1, case_temp2): Remove their decls.
1849 * character.h (ASCII_CHAR_P): Move from here ...
1850 * lisp.h: ... to here, so that the inline functions mentioned
1851 above can use them.
1852
4a6bea26
PE
1853 * dired.c (directory_files_internal_unwind): Now static.
1854
f14b7e14
PE
1855 * fileio.c (file_name_as_directory, directory_file_name):
1856 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1857 Now static.
2893f146
PE
1858 (file_name_as_directory): Use const pointers when appropriate.
1859 (Fexpand_file_name): Likewise. In particular, newdir might
1860 point at constant storage, so make it a const pointer.
fd4ead52 1861 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1862 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1863 signedness issues.
f839df0c
PE
1864 (Fset_file_times, Finsert_file_contents, auto_save_error):
1865 Rename locals to avoid shadowing.
f14b7e14 1866
5716756e 1867 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1868 (Ftry_completion, Fall_completions): Rename or remove locals
1869 to avoid shadowing.
5716756e 1870
b4c3046a
PE
1871 * marker.c (bytepos_to_charpos): Remove; unused.
1872
b45db522
PE
1873 * lisp.h (verify_bytepos, count_markers): New decls,
1874 so that gcc does not warn that these functions aren't declared.
1875
85876d07
PE
1876 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1877 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1878 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1879 (copy_text): Remove unused local var.
85876d07 1880
03d78a21 1881 * filelock.c (within_one_second): Now static.
b3dd38ab 1882 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1883
5df8f01b
PE
1884 * buffer.c (fix_overlays_before): Mark locals as initialized.
1885 (fix_start_end_in_overlays): Likewise. This function should be
1886 simplified by using pointers-to-pointers, but that's a different
1887 matter.
b1d876f1 1888 (switch_to_buffer_1): Now static.
8f54f30a
PE
1889 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1890 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1891
a70072c9 1892 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1893 Fix pointer signedness issue.
edced198
PE
1894 (sys_subshell): Mark local as volatile if checking for lint,
1895 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1896 (MAXPATHLEN): Define only if needed.
a70072c9 1897
a0977c44
PE
1898 * process.c (serial_open, serial_configure): Move decls from here ...
1899 * systty.h: ... to here, so that they can be checked.
1900
a884fdcc
PE
1901 * fns.c (get_random, seed_random): Move extern decls from here ...
1902 * lisp.h: ... to here, so that they can be checked.
1903
604efe86 1904 * sysdep.c (reset_io): Now static.
b8950c94 1905 (wait_for_termination_signal): Remove; unused.
604efe86 1906
38fc62d9
PE
1907 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1908 (copy_keymap_item, append_key, push_text_char_description):
1909 Now static.
1004a21a 1910 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1911 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1912 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1913 (describe_map_tree):
1914 Rename locals to avoid shadowing.
38fc62d9 1915
2f2650da
PE
1916 * keyboard.c: Declare functions static if they are not used elsewhere.
1917 (echo_char, echo_dash, cmd_error, top_level_2):
1918 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1919 (read_char, kbd_buffer_get_event, make_lispy_position):
1920 (make_lispy_event, make_lispy_movement, apply_modifiers):
1921 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1922 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1923 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1924 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1925 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1926
a053e86c 1927 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1928 (mark_kboards): Move decl here ...
1929 * alloc.c (mark_kboards): ... from here.
a053e86c 1930
4752793e
PE
1931 * lisp.h (force_auto_save_soon): New decl.
1932
74f10ca7 1933 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1934 (DEFINE_DUMMY_FUNCTION): New macro.
1935 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1936 Use it.
c03cd23f
PE
1937 (main): Add casts to avoid warnings
1938 if GCC considers string literals to be constants.
74f10ca7 1939
022e70d4
PE
1940 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1941
59d6fe83
PE
1942 * dbusbind.c: Pointer signedness fixes.
1943 (xd_signature, xd_append_arg, xd_initialize):
1944 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1945 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1946 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1947 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1948
78320123
PE
1949 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1950 if GCC considers string literals to be constants.
49cebcca 1951 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1952
35ac2a97
SM
19532011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1954
fb103ca9
SM
1955 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1956 (print_preprocess, print_object): New macro to fix last change.
1957
35ac2a97
SM
1958 * print.c (print_preprocess): Don't forget font objects.
1959
62973b41
JB
19602011-03-16 Juanma Barranquero <lekktu@gmail.com>
1961
1962 * emacs.c (USAGE3): Doc fixes.
1963
0e48bb22
AS
19642011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1965
1966 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1967 structure.
1968
7684e57b
JB
19692011-03-14 Juanma Barranquero <lekktu@gmail.com>
1970
1971 * lisp.h (VWindow_system, Qfile_name_history):
1972 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1973 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1974 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1975
1976 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1977 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1978
1979 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1980 * w32console.c (detect_input_pending, read_input_pending)
1981 (encode_terminal_code):
1982 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1983 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1984 (w32_system_caret_y, Qfile_name_history):
1985 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1986 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1987 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1988 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1989 * w32proc.c (Qlocal, report_file_error):
1990 * w32term.c (Vwindow_system, updating_frame):
1991 * w32uniscribe.c (initialized, uniscribe_font_driver):
1992 Remove unneeded extern declarations.
1993
2aa46d6c
CY
19942011-03-14 Chong Yidong <cyd@stupidchicken.com>
1995
c96bbc66 1996 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1997
cffc6f3b
CY
19982011-03-13 Chong Yidong <cyd@stupidchicken.com>
1999
2000 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2001 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2002 These macros can no longer be used for assignment.
2003
44f230aa
SM
2004 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2005 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2006 (record_buffer_markers, fetch_buffer_markers): New functions for
2007 recording and fetching special buffer markers.
2008 (set_buffer_internal_1, set_buffer_temp): Use them.
2009
2010 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2011
2012 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2013
2014 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2015 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2016
2017 * xdisp.c (hscroll_window_tree):
2018 (reconsider_clip_changes): Use PT instead of BUF_PT.
2019
d251f04b
EZ
20202011-03-13 Eli Zaretskii <eliz@gnu.org>
2021
2022 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2023 $(EMACS_ROOT)/lib/intprops.h.
2024
f0c77cd1
PE
20252011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2026
3eca4629
PE
2027 Fix more problems found by GCC 4.5.2's static checks.
2028
7c86ee98
PE
2029 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2030 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2031 (xg_free_frame_widgets): Make it clear that a local variable is
2032 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2033 (gdk_window_get_screen): Make it clear that this macro is needed
2034 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2035 (int_gtk_range_get_value): New function, which avoids a diagnostic
2036 from gcc -Wbad-function-cast.
2037 (xg_set_toolkit_scroll_bar_thumb): Use it.
2038 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2039 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2040 (get_utf8_string, xg_get_file_with_chooser):
2041 Rename locals to avoid shadowing.
2042 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2043
41729b81
PE
2044 * xgselect.c (xg_select): Remove unused var.
2045
f0c77cd1
PE
2046 * image.c (four_corners_best): Mark locals as initialized.
2047 (gif_load): Initialize transparent_p to zero (Bug#8238).
2048 Mark another local as initialized.
ec6cf4c6 2049 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2050
ce0ad53d 2051 * image.c (clear_image_cache): Now static.
d5d5a617 2052 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2053 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2054 (x_edge_detection): Remove unnecessary cast that
2055 gcc -Wbad-function-cast diagnoses.
2037898d 2056 (gif_load): Fix pointer signedness.
6ae141d6
PE
2057 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2058 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2059
33383987 20602011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2061
d32df629
PE
2062 Improve quality of tests for time stamp overflow.
2063 For example, without this patch (encode-time 0 0 0 1 1
2064 1152921504606846976) returns the obviously-bogus value (-948597
2065 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2066 reports time overflow. See
2067 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2068 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2069 * editfns.c: Include limits.h and intprops.h.
2070 (TIME_T_MIN, TIME_T_MAX): New macros.
2071 (time_overflow): Move earlier, to before first use.
2072 (hi_time, lo_time): New functions, for an accurate test for
2073 out-of-range times.
2074 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2075 (Fget_internal_run_time): Don't assume time_t fits in int.
2076 (make_time): Use list2 instead of Fcons twice.
2077 (Fdecode_time): More accurate test for out-of-range times.
2078 (check_tm_member): New function.
2079 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2080 (lisp_time_argument): Don't rely on undefined left-shift and
2081 right-shift behavior when checking for time stamp overflow.
8be6f318 2082
fe31d94c
PE
2083 * editfns.c (time_overflow): New function, refactoring common code.
2084 (Fformat_time_string, Fdecode_time, Fencode_time):
2085 (Fcurrent_time_string): Use it.
2086
8be6f318
PE
2087 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2088 * dired.c (make_time): Move to ...
2089 * editfns.c (make_time): ... here.
2090 * systime.h: Note the move.
2091
09d9db2c 20922011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2093
126bc0dc
YM
2094 * fringe.c (update_window_fringes): Remove unused variables.
2095
c47cbdfd
YM
2096 * unexmacosx.c (copy_data_segment): Also copy __got section.
2097 (Bug#8223)
2098
7ac80be9
EZ
20992011-03-12 Eli Zaretskii <eliz@gnu.org>
2100
c96bbc66 2101 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2102 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2103 Constify `char *' arguments and their references according to
2104 prototypes in tparam.h.
2105
ecb0f94d 2106 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2107
7ac80be9
EZ
2108 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2109 Adapt all references accordingly.
2110
2111 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2112
ef1fd07e
TT
21132011-03-11 Tom Tromey <tromey@redhat.com>
2114
2115 * buffer.c (syms_of_buffer): Remove obsolete comment.
2116
7ef4b50c
EZ
21172011-03-11 Eli Zaretskii <eliz@gnu.org>
2118
2119 * termhooks.h (encode_terminal_code): Declare prototype.
2120
2121 * msdos.c (encode_terminal_code): Don't declare prototype.
2122
2123 * term.c (encode_terminal_code): Now external again, used by
2124 w32console.c and msdos.c.
2125
44f230aa
SM
2126 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2127 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2128
4b1ec863 21292011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2130
1714f52b 2131 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2132
4b1ec863
PE
2133 * fringe.c (update_window_fringes): Mark locals as initialized
2134 (Bug#8227).
2135 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2136
524c7aa6
PE
2137 * alloc.c (mark_fringe_data): Move decl from here ...
2138 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2139 to check its interface.
2140 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2141
a5c0af81 2142 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2143 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2144 (fontset_font): Mark local as initialized.
a9a06e0b 2145 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2146
b4716021
PE
2147 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2148
811e9bac 2149 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2150 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2151 (x_own_selection, Fx_disown_selection_internal): Rename locals
2152 to avoid shadowing.
2153 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2154
7e3ab302
PE
2155 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2156 so that the caller can use some name other than gcpro1.
2157 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2158 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2159 (Fx_backspace_delete_keys_p):
2160 Use them to avoid shadowing, and rename vars to avoid shadowing.
2161 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2162 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2163 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2164 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2165 Remove unused locals.
7e3ab302
PE
2166 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2167 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2168 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2169 macros.
f78faa98 2170
e2b13473
PE
2171 * xterm.h (x_mouse_leave): New decl.
2172
77f23912
PE
2173 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2174 Remove unused functions.
cdf4ba58
PE
2175 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2176 (x_calc_absolute_position): Now static.
7411c686 2177 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2178 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2179 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2180 unless they are used.
38d0b34a
PE
2181 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2182 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2183 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2184 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2185 (x_error_catcher, x_connection_closed, x_error_handler):
2186 (x_error_quitter, xembed_send_message, x_iconify_frame):
2187 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2188 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2189 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2190
44f230aa
SM
2191 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2192 Rename or move locals to avoid shadowing.
6b463e58 2193 (tty_defined_color, merge_face_heights): Now static.
5967d051 2194 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2195 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2196 does not deduce is never used uninitialized.
73719eba
PE
2197 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2198 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2199
426994c3 2200 * terminal.c (store_terminal_param): Now static.
5489860b 2201
032f1620 2202 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2203 (set_frame_menubar): Remove unused local.
d4323972 2204 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2205 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2206 since they might point to immutable storage.
281585b0
PE
2207 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2208 since it's unused otherwise.
032f1620 2209
367c19e5 2210 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2211 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2212 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2213 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2214 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2215 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2216 does not deduce are never used uninitialized.
70739cbe 2217
07b48fa9
PE
2218 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2219
8868a238 2220 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2221 * window.c (window_loop, size_window):
2222 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2223
7e5cf297 2224 * window.c (display_buffer): Now static.
d6550a9f
PE
2225 (size_window): Mark variables that gcc -Wuninitialized
2226 does not deduce are never used uninitialized.
a586633d
PE
2227 * window.h (check_all_windows): New decl, to forestall
2228 gcc -Wmissing-prototypes diagnostic.
5b555da1 2229 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2230
f6095868
PE
2231 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2232 shadowing.
2233 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2234 Include <limits.h>.
2235 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2236 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2237 (load_charset_map): Mark variables that gcc -Wuninitialized
2238 does not deduce are never used uninitialized.
53df7c11 2239 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2240
f38b440c
PE
2241 * coding.c (coding_set_source, coding_set_destination):
2242 Use "else { /* comment */ }" rather than "else /* comment */;"
2243 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2244 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2245 a block, when the outer 'i' will do.
2246 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2247 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2248 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2249 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2250 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2251 Rename locals to avoid shadowing.
2252 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2253 * coding.c (emacs_mule_char, encode_invocation_designation):
2254 Now static, since they're not used elsewhere.
413bb2db 2255 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2256 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2257 (decode_coding_emacs_mule): Mark variables that gcc
2258 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2259 (detect_coding_iso_2022): Initialize a local variable that might
2260 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2261 this initialization is needed. (Bug#8211)
5f58e762
PE
2262 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2263 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2264 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2265 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2266 Remove unused macros.
f38b440c 2267
232b38b9 2268 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2269 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2270 * character.c (string_count_byte8): Likewise.
232b38b9 2271
fb90da1b
PE
2272 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2273 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2274
fb93dbc2
PE
2275 * chartab.c (copy_sub_char_table): Now static, since it's not used
2276 elsewhere.
5c156ace
PE
2277 (sub_char_table_ref_and_range, char_table_ref_and_range):
2278 Rename locals to avoid shadowing.
bbcd0949 2279 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2280
7d3b3862 2281 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2282 (BIDI_BOB): Remove unused macro.
7d3b3862 2283
6be7d3da
PE
2284 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2285 deduce are never used uninitialized.
c2ed9c8b 2286 * term.c (encode_terminal_code): Likewise.
6be7d3da 2287
75f8807f 2288 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2289
50938595
PE
2290 * tparam.h: New file.
2291 * term.c, tparam.h: Include it.
2292 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2293 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2294 Move these decls to tparam.h, and make them agree with what
2295 is actually in tparam.c. The previous trick of using incompatible
2296 decls in different modules does not conform to the C standard.
2297 All callers of tparam changed to use tparam's actual API.
2298 * tparam.c (tparam1, tparam, tgoto):
2299 Use const pointers where appropriate.
2300
fbceeba2
PE
2301 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2302 * cm.h (struct cm): Likewise.
2303 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2304 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2305 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2306 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2307 (turn_on_face, init_tty): Likewise.
2308 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2309
7f3f1250
PE
2310 * term.c (term_mouse_position): Rename local to avoid shadowing.
2311
e6ca6543
PE
2312 * alloc.c (mark_ttys): Move decl from here ...
2313 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2314
c40f8d15
AS
23152011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2316
2317 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2318
cfe0661d
JB
23192011-03-09 Juanma Barranquero <lekktu@gmail.com>
2320
2321 * search.c (compile_pattern_1): Remove argument regp, unused since
2322 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2323 (compile_pattern): Don't pass it.
2324
0afb4571
J
23252011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2326
2327 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2328 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2329 for ! HAVE_GTK3.
2330 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2331
2332 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2333
2334 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2335 gdk_window_get_screen, gdk_window_get_geometry,
2336 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2337 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2338 (xg_get_pixbuf_from_pixmap): New function.
2339 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2340 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2341 Call xg_get_pixbuf_from_pixmap instead of
2342 gdk_pixbuf_get_from_drawable.
2343 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2344 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2345 (xg_check_special_colors): Use GtkStyleContext and its functions
2346 for HAVE_GTK3.
2347 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2348 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2349 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2350 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2351 Call gtk_widget_get_preferred_size.
0afb4571
J
2352 (xg_frame_resized): gdk_window_get_geometry only takes 5
2353 parameters.
44f230aa
SM
2354 (xg_win_to_widget, xg_event_is_for_menubar):
2355 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2356 (xg_set_widget_bg): New function.
2357 (delete_cb): New function.
2358 (xg_create_frame_widgets): connect delete-event to delete_cb.
2359 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2360 (xg_set_background_color): Call xg_set_widget_bg.
2361 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2362 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2363 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2364 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2365 if ! HAVE_GTK3.
2366 (update_frame_tool_bar): Call gtk_widget_hide.
2367 (xg_initialize): Use GDK_KEY_g.
2368
2369 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2370 if ! HAVE_GTK3
2371 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2372
2373 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2374 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2375 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2376
1c2cc4ef
JB
23772011-03-08 Juanma Barranquero <lekktu@gmail.com>
2378
2379 * w32xfns.c (select_palette): Check success of RealizePalette against
2380 GDI_ERROR, not zero.
2381
33383987 2382See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2383
2384;; Local Variables:
2385;; coding: utf-8
aac0c6e3
MR
2386;; End:
2387
33383987 2388 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2389
2390 This file is part of GNU Emacs.
2391
2392 GNU Emacs is free software: you can redistribute it and/or modify
2393 it under the terms of the GNU General Public License as published by
2394 the Free Software Foundation, either version 3 of the License, or
2395 (at your option) any later version.
2396
2397 GNU Emacs is distributed in the hope that it will be useful,
2398 but WITHOUT ANY WARRANTY; without even the implied warranty of
2399 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2400 GNU General Public License for more details.
2401
2402 You should have received a copy of the GNU General Public License
2403 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.