Auto-commit of loaddefs files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3349e122
SM
12011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 Add multiple inheritance to keymaps.
4 * keymap.c (Fmake_composed_keymap): New function.
5 (Fset_keymap_parent): Simplify.
6 (fix_submap_inheritance): Remove.
7 (access_keymap_1): New function extracted from access_keymap to handle
8 embedded parents and handle lists of maps.
9 (access_keymap): Use it.
10 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
11 (Fcopy_keymap): Handle embedded parents.
12 (Fcommand_remapping, define_as_prefix): Simplify.
13 (Fkey_binding): Simplify.
14 (syms_of_keymap): Move minibuffer-local-completion-map,
15 minibuffer-local-filename-completion-map,
16 minibuffer-local-must-match-map, and
17 minibuffer-local-filename-must-match-map to Elisp.
18 (syms_of_keymap): Defsubr make-composed-keymap.
19 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
20 (parse_menu_item): Trivial simplification.
21
3279eb87
GM
222011-07-01 Glenn Morris <rgm@gnu.org>
23
24 * Makefile.in (SETTINGS_LIBS): Fix typo.
25
4550efdf
KI
262011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
27
28 * coding.c (Fencode_coding_string): Record the last coding system
29 used, as the function doc string says (bug#8738).
30
0949d2b6
JD
312011-07-01 Jan Djärv <jan.h.d@swipnet.se>
32
33 * xsettings.c (store_monospaced_changed): Take new font as arg and
34 check for change against current_mono_font.
35 (EMACS_TYPE_SETTINGS): Remove this and related defines.
36 (emacs_settings_constructor, emacs_settings_get_property)
37 (emacs_settings_set_property, emacs_settings_class_init)
38 (emacs_settings_init, gsettings_obj): Remove.
39 (something_changedCB): New function for HAVE_GSETTINGS.
40 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
41 with value as argument.
42 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
43 g_settings_new (Bug#8967). Do not create gsettings_obj.
44 Remove calls to g_settings_bind. Connect something_changedCB to
45 "changed".
46
47 * xgselect.c: Add defined (HAVE_GSETTINGS).
48 (xgselect_initialize): Ditto.
49
50 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
51 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
52 xg_select.
53
bbc6b304
PE
542011-07-01 Paul Eggert <eggert@cs.ucla.edu>
55
56 * eval.c (struct backtrace): Simplify and port the data structure.
57 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
58 signed bit field, as this assumption is not portable and it makes
59 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
60 "char debug_on_exit : 1" as this is not portable either; instead,
61 use the portable "unsigned int debug_on_exit : 1". Remove unused
62 member evalargs. Remove obsolete comments about cc bombing out.
63
9851bfc5
JD
642011-06-30 Jan Djärv <jan.h.d@swipnet.se>
65
51bb811f 66 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
67 Let HAVE_GSETTINGS override HAVE_GCONF.
68 (store_monospaced_changed): New function.
69 (EMACS_SETTINGS): A new type derived from GObject to handle
70 GSettings notifications.
71 (emacs_settings_constructor, emacs_settings_get_property)
72 (emacs_settings_set_property, emacs_settings_class_init):
73 New functions.
74 (gsettings_client, gsettings_obj): New variables.
75 (GSETTINGS_SCHEMA): New define.
76 (something_changedCB): Call store_monospaced_changed.
77 (init_gsettings): New function.
78 (xsettings_initialize): Call init_gsettings.
79 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
80 to NULL.
81
82 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
83 GCONF_CFLAGS/LIBS.
84
5386012d
MR
852011-06-29 Martin Rudalics <rudalics@gmx.at>
86
87 * window.c (resize_root_window, grow_mini_window)
88 (shrink_mini_window): Rename Qresize_root_window to
89 Qwindow_resize_root_window and Qresize_root_window_vertically to
90 Qwindow_resize_root_window_vertically.
91
f13e0b08
PE
922011-06-28 Paul Eggert <eggert@cs.ucla.edu>
93
94 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
95
94515237
JB
962011-06-27 Juanma Barranquero <lekktu@gmail.com>
97
98 * makefile.w32-in: Redesign dependencies so they reflect more
99 clearly which files are directly included by each source file,
100 and not through other includes.
101
e43b6e43
MR
1022011-06-27 Martin Rudalics <rudalics@gmx.at>
103
104 * buffer.c (Qclone_number): Declare static and DEFSYM it.
105 (sort_overlays, overlay_strings): When an overlay's clone number
106 matches the window's clone number process the overlay even if
107 the overlay's window property doesn't match the current window.
108
d68443dc
MR
109 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
110 (Fwindow_hchild): Rename to Fwindow_left_child.
111 (Fwindow_next): Rename to Fwindow_next_sibling.
112 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
113 (resize_window_check): Rename to window_resize_check.
114 (resize_window_apply): Rename to window_resize_apply.
115 (Fresize_window_apply): Rename to Fwindow_resize_apply.
116 (Fdelete_other_windows_internal, resize_frame_windows)
117 (Fsplit_window_internal, Fdelete_window_internal)
118 (grow_mini_window, shrink_mini_window)
119 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 120
c7e73be5
JD
1212011-06-26 Jan Djärv <jan.h.d@swipnet.se>
122
123 * emacsgtkfixed.h: State that this is only used with Gtk+3.
124 (emacs_fixed_set_min_size): Remove.
125 (emacs_fixed_new): Take frame as argument.
126
127 * emacsgtkfixed.c: State that this is only used with Gtk+3.
128 (_EmacsFixedPrivate): Remove minwidth/height.
129 Add struct frame *f.
130 (emacs_fixed_init): Initialize priv->f.
131 (get_parent_class, emacs_fixed_set_min_size): Remove.
132 (emacs_fixed_new): Set priv->f to argument.
133 (emacs_fixed_get_preferred_width)
134 (emacs_fixed_get_preferred_height): Use min_width/height from
135 frames size_hint to set minimum and natural (Bug#8919).
136 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
137 and use min_width/height from frames size_hint to set
138 min_width/height (Bug#8919).
139
140 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
141 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
142 indentation.
143
cf99dcf8
EZ
1442011-06-26 Eli Zaretskii <eliz@gnu.org>
145
146 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
147 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
148 called at ZV.
149
029529ac
CY
1502011-06-26 Chong Yidong <cyd@stupidchicken.com>
151
152 * process.c (wait_reading_process_output): Bypass select if
153 waiting for a cell while ignoring keyboard input, and input is
154 pending. Suggested by Jan Djärv (Bug#8869).
155
7a7ef429
PE
1562011-06-25 Paul Eggert <eggert@cs.ucla.edu>
157
158 Use gnulib's dup2 module instead of rolling our own.
159 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
160
11fdef7d 1612011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
162
163 * dispnew.c (scrolling_window): Before scrolling, turn off a
164 mouse-highlight in the window being scrolled.
165
cd3520a4
JB
1662011-06-24 Juanma Barranquero <lekktu@gmail.com>
167
168 Move DEFSYM to lisp.h and use everywhere.
169
170 * character.h (DEFSYM): Move declaration...
171 * lisp.h (DEFSYM): ...here.
172
173 * gnutls.c:
174 * minibuf.c:
175 * w32menu.c:
176 * w32proc.c:
177 * w32select.c: Don't include character.h.
178
179 * alloc.c (syms_of_alloc):
180 * buffer.c (syms_of_buffer):
181 * bytecode.c (syms_of_bytecode):
182 * callint.c (syms_of_callint):
183 * casefiddle.c (syms_of_casefiddle):
184 * casetab.c (init_casetab_once):
185 * category.c (init_category_once, syms_of_category):
186 * ccl.c (syms_of_ccl):
187 * cmds.c (syms_of_cmds):
188 * composite.c (syms_of_composite):
189 * dbusbind.c (syms_of_dbusbind):
190 * dired.c (syms_of_dired):
191 * dispnew.c (syms_of_display):
192 * doc.c (syms_of_doc):
193 * editfns.c (syms_of_editfns):
194 * emacs.c (syms_of_emacs):
195 * eval.c (syms_of_eval):
196 * fileio.c (syms_of_fileio):
197 * fns.c (syms_of_fns):
198 * frame.c (syms_of_frame):
199 * fringe.c (syms_of_fringe):
200 * insdel.c (syms_of_insdel):
201 * keymap.c (syms_of_keymap):
202 * lread.c (init_obarray, syms_of_lread):
203 * macros.c (syms_of_macros):
204 * msdos.c (syms_of_msdos):
205 * print.c (syms_of_print):
206 * process.c (syms_of_process):
207 * search.c (syms_of_search):
208 * sound.c (syms_of_sound):
209 * syntax.c (init_syntax_once, syms_of_syntax):
210 * terminal.c (syms_of_terminal):
211 * textprop.c (syms_of_textprop):
212 * undo.c (syms_of_undo):
213 * w32.c (globals_of_w32):
214 * window.c (syms_of_window):
215 * xdisp.c (syms_of_xdisp):
216 * xfaces.c (syms_of_xfaces):
217 * xfns.c (syms_of_xfns):
218 * xmenu.c (syms_of_xmenu):
219 * xsettings.c (syms_of_xsettings):
220 * xterm.c (syms_of_xterm): Use DEFSYM.
221
4228cf16
TZ
2222011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
223
cd3520a4 224 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 225
7fcccf1e
PE
2262011-06-23 Paul Eggert <eggert@cs.ucla.edu>
227
7efb4e0e
PE
228 Integer and buffer overflow fixes (Bug#8873).
229
ff5844ad
PE
230 * print.c (printchar, strout): Check for string overflow.
231 (PRINTPREPARE, printchar, strout):
232 Don't set size unless allocation succeeds.
233
90532f02
PE
234 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
235 for sizes. Check for string overflow more accurately.
236 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
237
6d84508d
PE
238 * macros.c: Integer and buffer overflow fixes.
239 * keyboard.h (struct keyboard.kbd_macro_bufsize):
240 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
241 Use ptrdiff_t, not int, for sizes.
242 Don't increment bufsize until after realloc succeeds.
243 Check for size-calculation overflow.
244 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
245
437b2cb4
PE
246 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
247
8b9ac8b4
PE
248 * lread.c: Integer overflow fixes.
249 (read_integer): Radix is now EMACS_INT, not int,
250 to improve quality of diagnostics for out-of-range radices.
251 Calculate buffer size correctly for out-of-range radices.
252 (read1): Check for integer overflow in radices, and in
253 read-circle numbers.
82cb60d3
PE
254 (read_escape): Avoid int overflow.
255 (Fload, openp, read_buffer_size, read1)
256 (substitute_object_recurse, read_vector, read_list, map_obarray):
257 Use ptrdiff_t, not int, for sizes.
258 (read1): Use EMACS_INT, not int, for sizes.
20270765 259 Check for size overflow.
8b9ac8b4 260
7fcccf1e
PE
261 * image.c (cache_image): Check for size arithmetic overflow.
262
bfbbd7e7
PE
263 * lread.c: Integer overflow issues.
264 (saved_doc_string_size, saved_doc_string_length)
265 (prev_saved_doc_string_size, prev_saved_doc_string_length):
266 Now ptrdiff_t, not int.
267 (read1): Don't assume doc string length fits in int. Check for
268 out-of-range doc string lengths.
269 (read_list): Don't assume file position fits in int.
39019e54 270 (read_escape): Check for hex character overflow.
bfbbd7e7 271
4e323265
LL
2722011-06-22 Leo Liu <sdl.web@gmail.com>
273
274 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
275 Move to minibuffer.el.
276
85fece3e
PE
2772011-06-22 Paul Eggert <eggert@cs.ucla.edu>
278
20b84ce9 279 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
280 The following patches are for when GLYPH_DEBUG && !XASSERT.
281 * dispextern.h (trace_redisplay_p, dump_glyph_string):
282 * dispnew.c (flush_stdout):
283 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
284 Mark as externally visible.
285 * dispnew.c (check_window_matrix_pointers): Now static.
286 * dispnew.c (window_to_frame_vpos):
287 * xfns.c (unwind_create_frame):
288 * xterm.c (x_check_font): Remove unused local.
289 * scroll.c (CHECK_BOUNDS):
290 * xfaces.c (cache_fache): Rename local to avoid shadowing.
291 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
292 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
293 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
294 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
295 Now static.
296 (debug_method_add): Use va_list and vsprintf rather than relying
297 on undefined behavior with wrong number of arguments.
298 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
299 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
300 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
301 since we're not interested in debugging glyphs with old libraries.
302 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
303 GCC 4.6.0's static checking.
304
0766b489
PE
3052011-06-22 Paul Eggert <eggert@cs.ucla.edu>
306
31fd4b32
PE
307 Integer overflow and signedness fixes (Bug#8873).
308 A few related buffer overrun fixes, too.
309
b79e8648
PE
310 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
311
0766b489
PE
312 * dispextern.h (struct face.stipple):
313 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
314 (x_bitmap_mask, x_allocate_bitmap_record)
315 (x_create_bitmap_from_data, x_create_bitmap_from_file)
316 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
317 (x_create_bitmap_from_xpm_data):
318 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
319 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
320 (.bitmaps_last):
321 * xfaces.c (load_pixmap):
322 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
323 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
324 (.bitmaps_last, struct x_output.icon_bitmap):
325 Use ptrdiff_t, not int, for bitmap indexes.
326 (x_allocate_bitmap_record): Check for size overflow.
327 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
328
b081724f
PE
329 Use ptrdiff_t, not int, for overlay counts.
330 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
331 * editfns.c (overlays_around, get_pos_property):
332 * textprop.c (get_char_property_and_overlay):
333 * xdisp.c (next_overlay_change, note_mouse_highlight):
334 * xfaces.c (face_at_buffer_position):
21514da7
PE
335 * buffer.c (OVERLAY_COUNT_MAX): New macro.
336 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
337 (Fnext_overlay_change, Fprevious_overlay_change)
338 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 339 Use ptrdiff_t, not int, for sizes.
21514da7 340 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 341
3de73e5e
PE
342 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
343
2606c57b
PE
344 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
345 (x_session_initialize): Do not assume string length fits in int.
346
aaafe47a
PE
347 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
348 This is unlikely, but can occur if DPI is outlandish.
349
2674ddc8 350 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
351 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
352
28154962
PE
353 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
354 * xrdb.c (magic_file_p, search_magic_path):
355 Omit last arg SUFFIX; it was always 0. All callers changed.
356 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
357
7de51af5
PE
358 * xfont.c (xfont_match): Avoid need for strlen.
359
25ed6cc3
PE
360 * xfns.c: Don't assume strlen fits in int.
361 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
362
4eab31dd
PE
363 * xdisp.c (message_log_check_duplicate): Return intmax_t,
364 not unsigned long, as we prefer signed integers. All callers changed.
365 Detect integer overflow in repeat count.
366 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 367 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 368
171e2a58
PE
369 * termcap.c: Don't assume sizes fit in int and never overflow.
370 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
371 (gobble_line): Check for size-calculation overflow.
372
ad39faca 373 * minibuf.c (Fread_buffer):
6e5bb2dc 374 * lread.c (intern, intern_c_string):
74ca2eb3
PE
375 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
376 Don't assume string length fits in int.
377
52c61c22 378 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
379 * gtkutil.c (style_changed_cb): Avoid need for strlen.
380
b5b8c9e5
PE
381 * font.c: Don't assume string length fits in int.
382 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
383 Use ptrdiff_t, not int.
ccd6111c
PE
384 (font_intern_prop): Don't assume string length fits in int.
385 Don't assume integer property fits in fixnum.
386 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 387
882f0d81 388 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 389 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
390 Reformulate so as not to need the command string.
391 Invoke gzip -cd rather than gunzip, as it's more portable.
392 (lock_info_type, lock_file_1, lock_file):
393 Don't assume pid_t and time_t fit in unsigned long.
394 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
395 (current_lock_owner): Prefer signed type for sizes.
396 Use memcpy, not strncpy, where memcpy is what is really wanted.
397 Don't assume (via atoi) that time_t and pid_t fit in int.
398 Check for time_t and/or pid_t out of range, e.g., via a network share.
399 Don't alloca where an auto var works fine.
400
93f4cf88
PE
401 * fileio.c: Fix some integer overflow issues.
402 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
403 Don't assume string length fits in int.
404 (directory_file_name): Don't assume string length fits in long.
405 (make_temp_name): Don't assume pid fits in int, or that its print
406 length is less than 20.
407
f3e92b69
PE
408 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
409
1bfdaf10
PE
410 * coding.c (make_subsidiaries): Don't assume string length fits in int.
411
35016e9a
PE
412 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
413
3d1e65a1
PE
414 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
415 We prefer signed integers, even for size calculations.
416
0b963a93
PE
417 * emacs.c: Don't assume string length fits in 'int'.
418 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
419 (main): Don't invoke strlen when not needed.
420
573f4b54
PE
421 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
422 (XD_DEBUG_MESSAGE): Don't waste a byte.
423
989f33ba
PE
424 * callproc.c (getenv_internal_1, getenv_internal)
425 (Fgetenv_internal):
965d34eb
PE
426 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
427
e4d29b33
PE
428 * lread.c (invalid_syntax): Omit length argument.
429 All uses changed. This doesn't fix a bug, but it simplifies the
430 code away from its former Hollerith-constant appearance, and it's
431 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 432 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 433
eb49b136
PE
434 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
435 This didn't break anything, but it didn't help either.
436 It's confusing to put a bogus integer in a place where the actual
437 value does not matter.
9f62aeb1 438 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 439 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 440
15375a22
PE
441 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
442 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
443 implementation.
b61cc01c
PE
444 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
445 We prefer signed types, and the value cannot exceed the EMACS_INT
446 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
447 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
448 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
449 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 450
53b2623d
PE
451 * indent.c (sane_tab_width): New function.
452 (current_column, scan_for_column, Findent_to, position_indentation)
453 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 454 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 455
51cab52b 456 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 457
f2ed8a70
PE
458 * lisp.h (lint_assume): New macro.
459 * composite.c (composition_gstring_put_cache):
460 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
461
abe80cc6
PE
462 * editfns.c, insdel.c:
463 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 464
b02c740e
PE
465 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
466
ebc96716
PE
467 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
468
b4e50fa0 469 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 470 Use much-faster test for byte-length change.
311d5d7c 471 Don't assume string byte-length fits in 'int'.
a4cf38e4 472 Check that character arg fits in 'int'.
85461888 473 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 474
c0c1ee9f
PE
475 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
476
a498d7f4
PE
477 * fns.c (concat): Catch string overflow earlier.
478 Do not rely on integer wraparound.
479
51cab52b
PE
480 * dispextern.h (struct it.overlay_strings_charpos)
481 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
482 * xdisp.c (forward_to_next_line_start)
483 (back_to_previous_visible_line_start)
484 (reseat_at_next_visible_line_start, next_element_from_buffer):
485 Don't arbitrarily truncate the value of 'selective' to int.
486
76031fad
PE
487 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
488
5eb55db9
PE
489 * composite.c: Don't truncate sizes to 'int'.
490 (composition_gstring_p, composition_reseat_it)
491 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
492 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
493 not EMACS_UINT, for indexes.
5eb55db9 494
0703a717
PE
495 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
496
d6202519
PE
497 * buffer.c: Include <verify.h>.
498 (struct sortvec.priority, struct sortstr.priority):
8961a454 499 Now EMACS_INT, not int.
c20998a7 500 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
501 (struct sortstr.size, record_overlay_string)
502 (struct sortstrlist.size, struct sortlist.used):
503 Don't truncate size to int.
504 (record_overlay_string): Check for size-calculation overflow.
d6202519 505 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 506
d5a19415
JM
5072011-06-22 Jim Meyering <meyering@redhat.com>
508
029529ac 509 Don't leak an XBM-image-sized buffer
d5a19415
JM
510 * image.c (xbm_load): Free the image buffer after using it.
511
a9041e6c
PE
5122011-06-21 Paul Eggert <eggert@cs.ucla.edu>
513
514 Port to Sun C.
515 * composite.c (find_automatic_composition): Omit needless 'return 0;'
516 that Sun C diagnosed.
517 * fns.c (secure_hash): Fix pointer signedness issue.
518 * intervals.c (static_offset_intervals): New function.
519 (offset_intervals): Use it.
520
7f3f739f
LL
5212011-06-21 Leo Liu <sdl.web@gmail.com>
522
523 * deps.mk (fns.o):
524 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
525 sha512.h.
526
527 * fns.c (secure_hash): Rename from crypto_hash_function and change
528 the first arg to accept symbols.
5b66d427 529 (Fsecure_hash): New primitive.
7f3f739f
LL
530 (syms_of_fns): New symbols.
531
76147d94
DD
5322011-06-20 Deniz Dogan <deniz@dogan.se>
533
534 * process.c (Fset_process_buffer): Clarify return value in
535 docstring.
536
7d7d0045
CY
5372011-06-18 Chong Yidong <cyd@stupidchicken.com>
538
539 * dispnew.c (add_window_display_history): Use BVAR.
540
541 * xdisp.c (debug_method_add): Use BVAR.
542 (check_window_end, dump_glyph_matrix, dump_glyph)
543 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
544
545 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
546 Likewise.
547
548 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
549 check till after the cache is created in init_frame_faces.
550
ff2bc410
SM
5512011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
552
553 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
554
28177add
PE
5552011-06-16 Paul Eggert <eggert@cs.ucla.edu>
556
dd3482fe
PE
557 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
558 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
559 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
560
393d71f3 561 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
562 * fileio.c (Finsert_file_contents):
563 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
564 Remove the old (too-loose) buffer overflow checks.
565 They weren't needed, since make_gap checks for buffer overflow.
566 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
567 The old code merely checked for Emacs fixnum overflow, and relied
568 on undefined (wraparound) behavior. The new code avoids undefined
569 behavior, and also checks for ptrdiff_t and/or size_t overflow.
570
2e6813b0 571 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
572 Tune. Don't use wider integers than needed. Don't use alloca.
573 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 574
599a9e4f
PE
575 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
576
99561444
PE
577 * insdel.c, lisp.h (buffer_overflow): New function.
578 (insert_from_buffer_1, replace_range, replace_range_2):
579 * insdel.c (make_gap_larger):
580 * editfns.c (Finsert_char):
581 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
582
28177add
PE
583 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
584
e69dafad
PE
5852011-06-15 Paul Eggert <eggert@cs.ucla.edu>
586
a7af7fde 587 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 588
b1c46f02
PE
589 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
590 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
591
e69dafad
PE
592 * fileio.c: Don't assume EMACS_INT fits in off_t.
593 (emacs_lseek): New static function.
594 (Finsert_file_contents, Fwrite_region): Use it.
595 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
596
566684ea
PE
597 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
598
e6966cd6
PE
599 * fns.c: Don't overflow int when computing a list length.
600 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
601 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
602 truncation on 64-bit hosts. Check for QUIT every
603 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
604 faster and is responsive enough.
605 (Flength): Report an error instead of overflowing an integer.
606 (Fsafe_length): Return a float if the value is not representable
607 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 608 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 609 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 610
dd0b0efb
PE
611 * alloc.c: Check that resized vectors' lengths fit in fixnums.
612 (header_size, word_size): New constants.
613 (allocate_vectorlike): Don't check size overflow here.
614 (allocate_vector): Check it here instead, since this is the only
615 caller of allocate_vectorlike that could cause overflow.
616 Check that the new vector's length is representable as a fixnum.
617
86fe5cfe
PE
618 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
619 The previous code was bogus. For example, next_almost_prime (32)
620 returned 39, which is undesirable as it is a multiple of 3; and
621 next_almost_prime (24) returned 25, which is a multiple of 5 so
622 why was the code bothering to check for multiples of 7?
623
80e88859
PE
624 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
625
4a2f0ad6
PE
626 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
627
f66c7cf8
PE
628 Variadic C functions now count arguments with ptrdiff_t.
629 This partly undoes my 2011-03-30 change, which replaced int with size_t.
630 Back then I didn't know that the Emacs coding style prefers signed int.
631 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
632 were being counted with int, which may truncate counts on 64-bit
633 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
634 * lisp.h (struct Lisp_Subr.function.aMANY)
635 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
636 Arg counts are now ptrdiff_t, not size_t.
637 All variadic functions and their callers changed accordingly.
638 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
639 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
640 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
641 * callint.c (Fcall_interactively): Check arg count for overflow,
642 to avoid potential buffer overrun. Use signed char, not 'int',
643 for 'varies' array, so that we needn't bother to check its size
644 calculation for overflow.
645 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
646 * eval.c (apply_lambda):
647 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
648 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
649 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
650
a1759b76
PE
651 * callint.c (Fcall_interactively): Don't use index var as event count.
652
d96be9fc
PE
653 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
654 * mem-limits.h (SIZE): Remove; no longer used.
655
a690a978 656 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 657
578c21e6
PE
658 Remove unnecessary casts.
659 * xterm.c (x_term_init):
660 * xfns.c (x_set_border_pixel):
661 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
662 These aren't needed now that we assume ANSI C.
663
96f53c6c
PE
664 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
665 It's more likely to cause problems (due to unsigned overflow)
666 than to cure them.
667
83c77d31
PE
668 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
669
ee2079f1
PE
670 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
671
6da65536
PE
672 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
673
7147c4a4
PE
674 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
675
193e32d9
PE
676 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
677
e5533da6
PE
678 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
679
9910e595
PE
680 GLYPH_CODE_FACE returns EMACS_INT, not int.
681 * dispextern.h (merge_faces):
682 * xfaces.c (merge_faces):
01103c44
PE
683 * xdisp.c (get_next_display_element, next_element_from_display_vector):
684 Don't assume EMACS_INT fits in int.
9910e595 685
2638320e
PE
686 * character.h (CHAR_VALID_P): Remove unused parameter.
687 * fontset.c, lisp.h, xdisp.c: All uses changed.
688
045eb8d9
PE
689 * editfns.c (Ftranslate_region_internal): Omit redundant test.
690
c1f134b5
PE
691 * fns.c (concat): Minor tuning based on overflow analysis.
692 This doesn't fix any bugs. Use int to hold character, instead
693 of constantly refetching from Emacs object. Use XFASTINT, not
694 XINT, for value known to be a character. Don't bother comparing
695 a single byte to 0400, as it's always less.
696
395fcb93 697 * floatfns.c (Fexpt):
327eeec8
PE
698 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
699
abbd3d23
PE
700 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
701 for characters.
702
684a03ef
PE
703 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
704
0fed43f3
PE
705 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
706 Without this fix, on a 64-bit host (aset S 0 4294967386) would
707 incorrectly succeed when S was a string, because 4294967386 was
708 truncated before it was used.
709
8fd02eb7
PE
710 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
711 Otherwise, an out-of-range integer could cause undefined behavior
712 on a 64-bit host.
713
f8c86b69
PE
714 * composite.c: Use int, not EMACS_INT, for characters.
715 (fill_gstring_body, composition_compute_stop_pos): Use int, not
716 EMACS_INT, for values that are known to be in character range.
717 This doesn't fix any bugs but is the usual style inside Emacs and
718 may generate better code on 32-bit machines.
719
34206dd2
PE
720 Make sure a 64-bit char is never passed to ENCODE_CHAR.
721 This is for reasons similar to the recent CHAR_STRING fix.
722 * charset.c (Fencode_char): Check that character arg is actually
723 a character. Pass an int to ENCODE_CHAR.
724 * charset.h (ENCODE_CHAR): Verify that the character argument is no
725 wider than 'int', as a compile-time check to prevent future regressions
726 in this area.
727
c5958d4c 728 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
729
730 Make sure a 64-bit char is never passed to CHAR_STRING.
731 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
732 by silently ignoring the top 32 bits, allowing some values
733 that were far too large to be valid characters.
734 * character.h: Include <verify.h>.
735 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
736 arguments are no wider than unsigned, as a compile-time check
737 to prevent future regressions in this area.
738 * data.c (Faset):
01103c44 739 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
740 (Fsubst_char_in_region):
741 * fns.c (concat):
742 * xdisp.c (decode_mode_spec_coding):
743 Adjust to CHAR_STRING's new requirement.
744 * editfns.c (Finsert_char, Fsubst_char_in_region):
745 * fns.c (concat): Check that character args are actually
746 characters. Without this test, these functions did the wrong
747 thing with wildly out-of-range values on 64-bit hosts.
748
d37ca623
PE
749 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
750 These casts should not be needed on 32-bit hosts, either.
751 * keyboard.c (read_char):
752 * lread.c (Fload): Remove casts to unsigned.
753
ea204efb
PE
754 * lisp.h (UNSIGNED_CMP): New macro.
755 This fixes comparison bugs on 64-bit hosts.
756 (ASCII_CHAR_P): Use it.
757 * casefiddle.c (casify_object):
01103c44 758 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
759 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
760 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
761 * dispextern.h (FACE_FROM_ID):
762 * keyboard.c (read_char): Use UNSIGNED_CMP.
763
41cb286c
PE
764 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
765 not to EMACS_INT, to avoid GCC warning.
766
4a1b9832
PE
767 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
768
55daad71
PE
769 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
770 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
771 isn't needed on 32-bit machines.
8f95c75c 772
01103c44
PE
773 * buffer.c (Fgenerate_new_buffer_name):
774 Use EMACS_INT for count, not int.
0ceccced 775 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
776
777 * data.c (Qcompiled_function): Now static.
778
c6f072e7
PE
779 * window.c (window_body_lines): Now static.
780
20ce5912
PE
781 * image.c (gif_load): Rename local to avoid shadowing.
782
9c4c5f81
PE
783 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
784 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
785 * alloc.c (make_save_value): Integer argument is now of type
786 ptrdiff_t, not int.
787 (mark_object): Use ptrdiff_t, not int.
788 * lisp.h (pD): New macro.
789 * print.c (print_object): Use it.
790
c0c5c8ae
PE
791 * alloc.c: Use EMACS_INT, not int, to count objects.
792 (total_conses, total_markers, total_symbols, total_vector_size)
793 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
794 (total_free_floats, total_floats, total_free_intervals)
795 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
796 Now EMACS_INT, not int. All uses changed.
797 (Fgarbage_collect): Compute overall total using a double, so that
798 integer overflow is less likely to be a problem. Check for overflow
799 when converting back to an integer.
5a25e253
PE
800 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
801 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
802 These were 'int' variables that could overflow on 64-bit hosts;
803 they were never used, so remove them instead of repairing them.
211a0b2a 804 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
805 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
806 Previously, this ceilinged at INT_MAX, but that doesn't work on
807 64-bit machines.
e46bb31a 808 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 809
c78baabf 810 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 811 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
812 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
813 when a (possibly-narrower) signed value would do just as well.
814 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 815
c9d624c6
PE
816 * alloc.c: Catch some string size overflows that we were missing.
817 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
818 for convenience in STRING_BYTES_MAX.
819 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
820 The definition here is exact; the one in lisp.h was approximate.
821 (allocate_string_data): Check for string overflow. This catches
822 some instances we weren't catching before. Also, it catches
823 size_t overflow on (unusual) hosts where SIZE_MAX <= min
824 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
825 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 826
c9d624c6
PE
827 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
828 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
829 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
830
353032ce
PE
831 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
832
2bccce07
PE
833 * alloc.c (Fmake_string): Check for out-of-range init.
834
0ac30604
SM
8352011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
836
837 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
838
c195f2de
JD
8392011-06-14 Jan Djärv <jan.h.d@swipnet.se>
840
841 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
842 xg_get_default_scrollbar_width.
843
844 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
845 (int_gtk_range_get_value): Move to the scroll bar part of the file.
846 (style_changed_cb): Call update_theme_scrollbar_width and call
847 x_set_scroll_bar_default_width and xg_frame_set_char_size for
848 all frames (Bug#8505).
849 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
850 Call gtk_window_set_resizable if HAVE_GTK3.
851 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
852 and height if HAVE_GTK3 (Bug#8505).
853 (scroll_bar_width_for_theme): New variable.
854 (update_theme_scrollbar_width): New function.
855 (xg_get_default_scrollbar_width): Move code to
856 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
857 (xg_initialize): Call update_theme_scrollbar_width.
858
859 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
860
861 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
862
e10ac9f1
MR
8632011-06-12 Martin Rudalics <rudalics@gmx.at>
864
865 * frame.c (make_frame): Call other_buffer_safely instead of
866 other_buffer.
867
868 * window.c (temp_output_buffer_show): Call display_buffer with
869 second argument Vtemp_buffer_show_specifiers and reset latter
870 immediately after the call.
871 (Vtemp_buffer_show_specifiers): New variable.
872 (auto_window_vscroll_p, next_screen_context_lines)
873 (Vscroll_preserve_screen_position): Remove leading asterisks from
874 doc-strings.
875
2d3c217e 8762011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 877
7b7f97e8 878 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
879 * buffer.c (Qclone_number): Remove for now, as it's unused.
880 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
881 (record_buffer): Remove unused local.
882 * frame.c (other_visible_frames, frame_buffer_list): Now static.
883 (set_frame_buffer_list): Remove; unused.
884 * frame.h (other_visible_frames): Remove decl.
885 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
886 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
887 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
888 if HAVE_GPM.
889 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
890 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
891 Define only if HAVE_GPM.
892 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
893 (update_hints_inhibit): Remove; never set. All uses removed.
894 * widgetprv.h (emacsFrameClassRec): Remove decl.
895 * window.c (delete_deletable_window): Now returns void, since it
896 wasn't returning anything.
897 (compare_window_configurations): Remove unused locals.
898 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
899 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
900 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
901 the same widths as pointers. This follows up on the 2011-05-06 patch.
902 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
903 * xterm.h: Likewise.
904 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
905
1384b89e
JB
9062011-06-12 Juanma Barranquero <lekktu@gmail.com>
907
908 * makefile.w32-in: Update dependencies.
909 (LISP_H): Add lib/intprops.h.
910
1100a63c
CY
9112011-06-11 Chong Yidong <cyd@stupidchicken.com>
912
913 * image.c (gif_load): Add animation frame delay to the metadata.
914 (syms_of_image): Use DEFSYM. New symbol `delay'.
915
6198ccd0
MR
9162011-06-11 Martin Rudalics <rudalics@gmx.at>
917
918 * window.c (delete_deletable_window): Re-add.
919 (Fset_window_configuration): Rewrite to handle dead buffers and
920 consequently deletable windows.
921 (window_tree, Fwindow_tree): Remove. Supply functionality in
922 window.el.
923 (compare_window_configurations): Simplify code.
924
b6e3633c
AS
9252011-06-11 Andreas Schwab <schwab@linux-m68k.org>
926
1ab0dee5
AS
927 * image.c (imagemagick_load_image): Fix type mismatch.
928 (Fimagemagick_types): Likewise.
929
b6e3633c
AS
930 * window.h (replace_buffer_in_windows): Declare.
931
9397e56f
MR
9322011-06-11 Martin Rudalics <rudalics@gmx.at>
933
934 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
935 Qclone_number. Remove external declaration of Qdelete_window.
936 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
937 code.
938 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
939 Qbuffer_list_update_hook if allowed.
940 (Fother_buffer): Rewrite doc-string. Major rewrite for new
941 buffer list implementation.
942 (other_buffer_safely): New function.
943 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
944 calls to replace_buffer_in_windows and
945 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
946 if allowed.
947 (record_buffer): Inhibit quitting and rewrite using quittable
948 functions. Run Qbuffer_list_update_hook if allowed.
949 (Frecord_buffer, Funrecord_buffer): New functions.
950 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
951 switch-to-buffer to window.el.
952 (bury-buffer): Move to window.el.
953 (Vbuffer_list_update_hook): New variable.
954
955 * lisp.h (other_buffer_safely): Add prototype in buffer.c
956 section.
957
958 * window.h (resize_frame_windows): Move up in code.
959 (Fwindow_frame): Remove EXFUN.
960 (replace_buffer_in_all_windows): Remove prototype.
961 (replace_buffer_in_windows_safely): Add prototype.
962
963 * window.c: Declare Qdelete_window static again. Move down
964 declaration of select_count.
965 (Fnext_window, Fprevious_window): Rewrite doc-strings.
966 (Fother_window): Move to window.el.
967 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
968 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
969 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
970 window.el.
971 (replace_buffer_in_windows): Implement by calling
972 Qreplace_buffer_in_windows.
973 (replace_buffer_in_all_windows): Remove with some functionality
974 moved into replace_buffer_in_windows_safely.
975 (replace_buffer_in_windows_safely): New function.
976 (select_window_norecord, select_frame_norecord): Move in front
977 of run_window_configuration_change_hook. Remove now obsolete
978 declarations.
979 (Fset_window_buffer): Rewrite doc-string. Call
980 Qrecord_window_buffer.
981 (keys_of_window): Move binding for other-window to window.el.
982
b50691aa
CY
9832011-06-11 Chong Yidong <cyd@stupidchicken.com>
984
985 * dispextern.h (struct image): Replace data member, whose int_val
986 and ptr_val fields were not used by anything, with a single
987 lisp_val object.
988
989 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
990 (gif_clear_image, gif_load, imagemagick_load_image)
991 (gs_clear_image, gs_load): Callers changed.
992
3f754b86
PE
9932011-06-10 Paul Eggert <eggert@cs.ucla.edu>
994
cca69397
PE
995 * buffer.h: Include <time.h>, for time_t.
996 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
997
109e28d0
PE
998 Fix minor problems found by static checking.
999
60737f02
PE
1000 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1001
4b66faf3
PE
1002 Make identifiers static if they are not used in other modules.
1003 * data.c (Qcompiled_function, Qframe, Qvector):
1004 * image.c (QimageMagick, Qsvg):
1005 * minibuf.c (Qmetadata):
1006 * window.c (resize_window_check, resize_root_window): Now static.
1007 * window.h (resize_window_check, resize_root_window): Remove decls.
1008
109e28d0
PE
1009 * window.c (window_deletion_count, delete_deletable_window):
1010 Remove; unused.
46a4ce9e
PE
1011 (window_body_lines): Now static.
1012 (Fdelete_other_windows_internal): Mark vars as initialized.
1013 Make sure 'resize_failed' is initialized.
1014 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1015 (resize_window_apply): Remove unused local.
1016 * window.h (delete_deletable_window): Remove decl.
1017
109e28d0 1018 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1019 (imagemagick_load_image): Fix pointer signedness problem by changing
1020 last arg from unsigned char * to char *. All uses changed.
1021 Also, fix a local for similar reasons.
1022 Remove unused locals. Remove locals to avoid shadowing.
1023 (fn_rsvg_handle_free): Remove; unused.
1024 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1025 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1026
3f754b86
PE
1027 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1028
2547adb1
CY
10292011-06-10 Chong Yidong <cyd@stupidchicken.com>
1030
1031 * image.c (gif_load): Fix omitted cast error introduced by
1032 2011-06-06 change.
1033
2c8e37d4
MR
10342011-06-10 Martin Rudalics <rudalics@gmx.at>
1035
1036 * window.h (resize_proportionally, orig_total_lines)
1037 (orig_top_line): Remove from window structure.
1038 (set_window_height, set_window_width, change_window_heights)
1039 (Fdelete_window): Remove prototypes.
1040 (resize_frame_windows): Remove duplicate declaration.
1041
440a42e3
EZ
10422011-06-10 Eli Zaretskii <eliz@gnu.org>
1043
1044 * window.h (resize_frame_windows, resize_window_check)
1045 (delete_deletable_window, resize_root_window)
1046 (resize_frame_windows): Declare prototypes.
1047
1048 * window.c (resize_window_apply): Make definition be "static" to
1049 match the prototype.
1050
562dd5e9
MR
10512011-06-10 Martin Rudalics <rudalics@gmx.at>
1052
1053 * window.c: Remove declarations of Qwindow_size_fixed,
1054 window_min_size_1, window_min_size_2, window_min_size,
1055 size_window, window_fixed_size_p, enlarge_window, delete_window.
1056 Remove static from declaration of Qdelete_window, it's
1057 temporarily needed by Fbury_buffer.
1058 (replace_window): Don't assign orig_top_line and
1059 orig_total_lines.
1060 (Fdelete_window, delete_window): Remove. Window deletion is
1061 handled by window.el.
1062 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1063 Fdelete_window calls with calls to Qdelete_window.
1064 (Fdelete_other_windows): Remove. Deleting other windows is
1065 handled by window.el.
1066 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1067 handled in window.el.
1068 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1069 Window minimum sizes are handled in window.el.
1070 (shrink_windows, size_window, set_window_height)
1071 (set_window_width, change_window_heights, window_height)
1072 (window_width, CURBEG, CURSIZE, enlarge_window)
1073 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1074 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1075 handled in window.el.
1076 (make_dummy_parent): Rename to make_parent_window and give it a
1077 second argument horflag.
1078 (make_window): Don't set resize_proportionally any more.
1079 (Fsplit_window): Remove. Windows are split in window.el.
1080 (save_restore_action, save_restore_orig_size)
1081 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1082 Resize mini windows in window.el.
1083 (grow_mini_window, shrink_mini_window): Implement by calling
1084 Qresize_root_window_vertically, resize_window_check and
1085 resize_window_apply.
1086 (saved_window, Fset_window_configuration, save_window_save): Do
1087 not handle orig_top_line, orig_total_lines, and
1088 resize_proportionally.
1089 (window_min_height, window_min_width): Move to window.el.
1090 (keys_of_window): Move bindings for delete-other-windows,
1091 split-window, delete-window and enlarge-window to window.el.
1092
1093 * buffer.c: Temporarily extern Qdelete_window.
1094 (Fbury_buffer): Temporarily call Qdelete_window instead of
1095 Fdelete_window (Fbury_buffer will move to window.el soon).
1096
1097 * frame.c (set_menu_bar_lines_1): Remove code handling
1098 orig_top_line and orig_total_lines.
1099
1100 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1101 set_window_height but set heights directly.
1102 (change_frame_size_1): Use resize_frame_windows.
1103
1104 * xdisp.c (init_xdisp): Don't use set_window_height but set
1105 heights directly.
1106
1107 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1108 resize_frame_windows instead of change_window_heights and run
1109 run_window_configuration_change_hook.
1110
1111 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1112 instead of change_window_heights and run
1113 run_window_configuration_change_hook.
1114
1a13852e
MR
11152011-06-09 Martin Rudalics <rudalics@gmx.at>
1116
1117 * window.c (replace_window): Rename second argument REPLACEMENT to
1118 NEW. New third argument SETFLAG. Rewrite.
1119 (delete_window, make_dummy_parent): Call replace_window with
1120 third argument 1.
1121 (window_list_1): Move down in code.
1122 (run_window_configuration_change_hook): Move set_buffer part
1123 before select_frame_norecord part in order to unwind correctly.
1124 Rename count1 to count.
1125 (recombine_windows, delete_deletable_window, resize_root_window)
1126 (Fdelete_other_windows_internal)
1127 (Frun_window_configuration_change_hook, make_parent_window)
1128 (resize_window_check, resize_window_apply, Fresize_window_apply)
1129 (resize_frame_windows, Fsplit_window_internal)
1130 (Fdelete_window_internal, Fresize_mini_window_internal): New
1131 functions.
1132 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1133
f3d1777e
MR
11342011-06-08 Martin Rudalics <rudalics@gmx.at>
1135
496e208e
MR
1136 * window.h (window): Add some new members to window structure -
1137 normal_lines, normal_cols, new_total, new_normal, clone_number,
1138 splits, nest, prev_buffers, next_buffers.
1139 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1140 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1141
f3d1777e
MR
1142 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1143 Remove.
496e208e
MR
1144 (make_dummy_parent): Set new members of windows structure.
1145 (make_window): Move down in code. Handle new members of window
1146 structure.
1147 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1148 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1149 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1150 (Fset_window_prev_buffers, Fwindow_next_buffers)
1151 (Fset_window_next_buffers, Fset_window_clone_number): New
1152 functions.
1153 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1154 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1155 Doc-string fixes.
1156 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1157 Argument WINDOW can be now internal window too.
1158 (Fwindow_use_time): Move up in code.
1159 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1160 Rewrite doc-string.
1161 (Fset_window_configuration, saved_window)
1162 (Fcurrent_window_configuration, save_window_save): Handle new
1163 members of window structure.
b9e809c2
MR
1164 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1165 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1166 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1167 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1168 Qget_mru_window, Qresize_root_window,
1169 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1170 Qauto_buffer_name; staticpro them.
f3d1777e 1171
abde8f8c
MR
11722011-06-07 Martin Rudalics <rudalics@gmx.at>
1173
1174 * window.c (Fwindow_total_size, Fwindow_left_column)
1175 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1176 (Fwindow_list_1): New functions.
1177 (window_box_text_cols): Replace with window_body_cols.
1178 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1179 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1180 (delete_window, Fset_window_configuration): Call
1181 delete_all_subwindows with window as argument.
1182 (delete_all_subwindows): Take a window as argument and not a
1183 structure. Rewrite.
190b47e6
MR
1184 (window_loop): Remove handling of GET_LRU_WINDOW and
1185 GET_LARGEST_WINDOW.
1186 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1187
1188 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1189 window_box_text_cols. delete_all_subwindows now takes a
1190 Lisp_Object as argument.
abde8f8c
MR
1191
1192 * indent.c (compute_motion, Fcompute_motion): Use
1193 window_body_cols instead of window_box_text_cols.
1194
fa8a67e6
MR
1195 * frame.c (delete_frame): Call delete_all_subwindows with root
1196 window as argument.
1197
a54e3482
DC
11982011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1199
1200 * fns.c (Fputhash): Document return value.
1201
60002bf5
CY
12022011-06-06 Chong Yidong <cyd@stupidchicken.com>
1203
1204 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1205
0c671da6 12062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1207
b862a52a 1208 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1209
be44ca6c
PE
1210 Check for overflow when converting integer to cons and back.
1211 * charset.c (Fdefine_charset_internal, Fdecode_char):
1212 Use cons_to_unsigned to catch overflow.
1213 (Fencode_char): Use INTEGER_TO_CONS.
1214 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1215 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1216 * data.c (long_to_cons, cons_to_long): Remove.
1217 (cons_to_unsigned, cons_to_signed): New functions.
1218 These signal an error for invalid or out-of-range values.
1219 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1220 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1221 * font.c (Ffont_variation_glyphs):
1222 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1223 * lisp.h: Include <intprops.h>.
1224 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1225 (cons_to_signed, cons_to_unsigned): New decls.
1226 (long_to_cons, cons_to_long): Remove decls.
1227 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1228 (Fprimitive_undo): Use CONS_TO_INTEGER.
1229 * xfns.c (Fx_window_property): Likewise.
1230 * xselect.c: Include <limits.h>.
1231 (x_own_selection, selection_data_to_lisp_data):
1232 Use INTEGER_TO_CONS.
1233 (x_handle_selection_request, x_handle_selection_clear)
1234 (x_get_foreign_selection, Fx_disown_selection_internal)
1235 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1236 (lisp_data_to_selection_data): Use cons_to_unsigned.
1237 (x_fill_property_data): Use cons_to_signed.
1238 Report values out of range.
1239
d1f3d2af
PE
1240 Check for buffer and string overflow more precisely.
1241 * buffer.h (BUF_BYTES_MAX): New macro.
1242 * lisp.h (STRING_BYTES_MAX): New macro.
1243 * alloc.c (Fmake_string):
1244 * character.c (string_escape_byte8):
1245 * coding.c (coding_alloc_by_realloc):
1246 * doprnt.c (doprnt):
1247 * editfns.c (Fformat):
1248 * eval.c (verror):
1249 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1250 since they may not be the same number.
1251 * editfns.c (Finsert_char):
1252 * fileio.c (Finsert_file_contents):
1253 Likewise for BUF_BYTES_MAX.
1254
dd52fcea
PE
1255 * image.c: Use ptrdiff_t, not int, for sizes.
1256 (slurp_file): Switch from int to ptrdiff_t.
1257 All uses changed.
1258 (slurp_file): Check that file size fits in both size_t (for
1259 malloc) and ptrdiff_t (for sanity and safety).
1260
7f9bbdbb
PE
1261 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1262 if b->modtime has its maximal value.
1263
dfe18f82
PE
1264 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1265
84acfcf0
PE
1266 Don't assume time_t can fit into int.
1267 * buffer.h (struct buffer.modtime): Now time_t, not int.
1268 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1269 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1270
ccd9a01a
PE
1271 Minor fixes for signed vs unsigned integers.
1272 * character.h (MAYBE_UNIFY_CHAR):
1273 * charset.c (maybe_unify_char):
1274 * keyboard.c (read_char, reorder_modifiers):
1275 XINT -> XFASTINT, since the integer must be nonnegative.
1276 * ftfont.c (ftfont_spec_pattern):
1277 * keymap.c (access_keymap, silly_event_symbol_error):
1278 XUINT -> XFASTINT, since the integer must be nonnegative.
1279 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1280 since it makes no difference and we prefer signed.
1281 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1282 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1283 nonnegative.
1284
d6d100dd
SM
12852011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1286
1287 * window.h (Fwindow_frame): Declare.
1288
2b6148e4
PE
12892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1290
1291 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1292 (SPARE_MEMORY): Always define.
1293 (LARGE_REQUEST): Remove.
1294 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1295
f230ecc9
MR
12962011-06-06 Martin Rudalics <rudalics@gmx.at>
1297
727e958e
MR
1298 * lisp.h: Move EXFUNS for Fframe_root_window,
1299 Fframe_first_window and Fset_frame_selected_window to window.h.
1300
1301 * window.h: Move EXFUNS for Fframe_root_window,
1302 Fframe_first_window and Fset_frame_selected_window here from
1303 lisp.h.
1304
1305 * frame.c (Fwindow_frame, Fframe_first_window)
1306 (Fframe_root_window, Fframe_selected_window)
1307 (Fset_frame_selected_window): Move to window.c.
1308 (Factive_minibuffer_window): Move to minibuf.c.
1309 (Fother_visible_frames_p): New function.
1310
1311 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1312
f230ecc9
MR
1313 * window.c (decode_window, decode_any_window): Move up in code.
1314 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1315 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1316 (Fwindow_buffer): Move up and rewrite doc-string.
1317 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1318 (Fwindow_prev): New functions.
727e958e
MR
1319 (Fwindow_frame): Move here from frame.c. Accept any window as
1320 argument.
1321 (Fframe_root_window, Fframe_first_window)
1322 (Fframe_selected_window): Move here from frame.c. Accept frame
1323 or arbitrary window as argument. Update doc-strings.
1324 (Fminibuffer_window): Move up in code.
1325 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1326 (Fset_frame_selected_window): Move here from frame.c.
1327 Marginal rewrite.
727e958e
MR
1328 (Fselected_window, select_window, Fselect_window): Move up in
1329 code. Minor doc-string fixes.
f230ecc9 1330
4d09bcf6
PE
13312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1332
1333 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1334 Do not assume that spare memory exists; that assumption is valid
1335 only if SYSTEM_MALLOC.
1336 (LARGE_REQUEST): New macro, so that the issue of large requests
1337 is separated from the issue of spare memory.
1338
810928a2
AS
13392011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1340
172418ad
AS
1341 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1342 format. (Bug#8806)
1343
43f862f7
AS
1344 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1345
810928a2
AS
1346 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1347 before statements.
1348
a059fe24
JD
13492011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1350
1351 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1352
1353 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1354
1355 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1356 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1357
989bf368
JB
13582011-06-05 Juanma Barranquero <lekktu@gmail.com>
1359
1360 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1361
4b80f674
CY
13622011-06-04 Chong Yidong <cyd@stupidchicken.com>
1363
1364 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1365 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1366 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1367 New error handlers.
4b80f674
CY
1368 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1369 Obey Vx_select_enable_clipboard_manager. Catch errors in
1370 x_clipboard_manager_save (Bug#8779).
1371 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1372 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1373
99a33b77 13742011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1375
1376 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1377
99a33b77 13782011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1379
1380 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1381 in the current matrix if keep_current_p is non-zero.
1382
8264569d
EZ
13832011-06-04 Eli Zaretskii <eliz@gnu.org>
1384
1385 * bidi.c (bidi_level_of_next_char): Fix last change.
1386
57f97249
EZ
13872011-06-03 Eli Zaretskii <eliz@gnu.org>
1388
fec2107c 1389 Support bidi reordering of text covered by display properties.
57f97249 1390
fec2107c
EZ
1391 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1392 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1393 (bidi_cache_search, bidi_cache_iterator_state)
1394 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1395 (bidi_level_of_next_char, bidi_move_to_visually_next):
1396 Support character positions inside a run of characters covered by a
fec2107c
EZ
1397 display string.
1398 (bidi_paragraph_init, bidi_resolve_explicit_1)
1399 (bidi_level_of_next_char): Call bidi_fetch_char and
1400 bidi_fetch_char_advance instead of FETCH_CHAR and
1401 FETCH_CHAR_ADVANCE.
1402 (bidi_init_it): Initialize new members.
1403 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1404 definitions.
1405 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1406 instead of using explicit *_CHAR codes.
d6d100dd
SM
1407 (bidi_resolve_explicit, bidi_resolve_weak):
1408 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1409 bidirectional text is supported only in multibyte buffers.
1410 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1411 it to initialize the frame_window_p member of struct bidi_it.
1412 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1413 (bidi_resolve_explicit, bidi_resolve_weak)
1414 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1415 bidi_it->nchars is non-positive.
1416 (bidi_level_of_next_char): Don't try to lookup the cache for the
1417 next/previous character if nothing is cached there yet, or if we
1418 were just reseat()'ed to a new position.
c40e2fb2 1419
0e14fe90
EZ
1420 * xdisp.c (set_cursor_from_row): Set start and stop points
1421 according to the row's direction when priming the loop that looks
1422 for the glyph on which to display cursor.
1423 (single_display_spec_intangible_p): Function deleted.
1424 (display_prop_intangible_p): Reimplement to call
1425 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1426 Accept 3 additional arguments needed by handle_display_spec.
1427 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1428 values: lists, `(when COND...)' forms, etc.
1429 (single_display_spec_string_p): Support property values that are
1430 lists with the argument STRING its top-level element.
1431 (display_prop_string_p): Fix the condition for processing a
1432 property that is a list to be consistent with handle_display_spec.
fec2107c 1433 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1434 last portion of handle_display_prop.
1435 (compute_display_string_pos): Accept additional argument
1436 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1437 value of a `display' property is a "replacing spec".
1438 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1439 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1440 the display property, but just return a value indicating whether
1441 the display property will replace the characters it covers.
1442 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1443 frame_window_p members of struct bidi_it.
d6d100dd
SM
1444 (compute_display_string_pos, compute_display_string_end):
1445 New functions.
fec2107c
EZ
1446 (push_it): Accept second argument POSITION, where pop_it should
1447 jump to continue iteration.
1448 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1449
fec2107c
EZ
1450 * keyboard.c (adjust_point_for_property): Adjust the call to
1451 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1452
1453 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1454 (bidi_init_it): Update prototypes.
1455 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1456 (compute_display_string_pos, compute_display_string_end):
1457 Declare prototypes.
fec2107c
EZ
1458 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1459 EMACS_INT.
fc6f18ce 1460
40087514 14612011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1462
57f53182
PE
1463 Malloc failure behavior now depends on size of allocation.
1464 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1465 * lisp.h: Change signatures accordingly.
1466 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1467 All callers changed. (Bug#8762)
1468
1469 * gnutls.c: Use Emacs's memory allocators.
1470 Without this change, the gnutls library would invoke malloc etc.
1471 directly, which causes problems on non-SYNC_INPUT hosts, and which
1472 runs afoul of improving memory_full behavior. (Bug#8761)
1473 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1474 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1475 xfree instead of the default malloc, realloc, free.
1476 (Fgnutls_boot): No need to check for memory allocation failure,
1477 since xmalloc does that for us.
1478
ac32cd99 1479 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1480 * category.c (hash_get_category_set):
1481 * ccl.c (ccl_driver):
1482 * charset.c (Fdefine_charset_internal):
1483 * charset.h (struct charset.hash_index):
1484 * composite.c (get_composition_id, gstring_lookup_cache)
1485 (composition_gstring_put_cache):
1486 * composite.h (struct composition.hash_index):
1487 * dispextern.h (struct image.hash):
1488 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1489 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1490 (hashfn_equal, hashfn_user_defined, make_hash_table)
1491 (maybe_resize_hash_table, hash_lookup, hash_put)
1492 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1493 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1494 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1495 * image.c (make_image, search_image_cache, lookup_image)
1496 (xpm_put_color_table_h):
1497 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1498 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1499 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1500 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1501 * alloc.c (allocate_vectorlike):
1502 Check for overflow in vector size calculations.
1503 * ccl.c (ccl_driver):
1504 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1505 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1506 need to be updated by these changes.
40087514
PE
1507 * fns.c (make_hash_table, maybe_resize_hash_table):
1508 Check for integer overflow with large hash tables.
0de4bb68
PE
1509 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1510 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1511 (SXHASH_REDUCE): New macro.
1512 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1513 Use it instead of discarding useful hash info with large hash values.
1514 (sxhash_float): New function.
1515 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1516 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1517 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1518 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1519 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1520 Adjust signatures to match updated version of code.
1521 (consing_since_gc): Now EMACS_INT, since a single hash table can
1522 use more than INT_MAX bytes.
1523
698d32e2
DN
15242011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1525
1526 Make it possible to build with GCC-4.6+ -O2 -flto.
1527
1528 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1529
fd6fa53f
SM
15302011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1531
1532 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1533 Call minibuffer-inactive-mode.
1534
864db017
JB
15352011-05-31 Juanma Barranquero <lekktu@gmail.com>
1536
1537 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1538 Update dependencies.
1539
2ad0baf4
DN
15402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1541
1542 * data.c (init_data): Remove code for UTS, this system is not
1543 supported anymore.
1544
4fcc2638
DN
15452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1546
1547 Don't force ./temacs to start in terminal mode.
1548
1549 * frame.c (make_initial_frame): Initialize faces in all cases, not
1550 only when CANNOT_DUMP is defined.
1551 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1552
c56e0fd5
DN
15532011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1554
1555 * dispnew.c (add_window_display_history): Use const for the string
1556 pointer. Remove declaration, not needed.
1557
333d54da 15582011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1559
55d4c1b2 1560 Use 'inline', not 'INLINE'.
333d54da 1561 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1562 * alloc.c, fontset.c (INLINE): Remove.
1563 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1564 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1565 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1566 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1567 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1568
738db178
DN
15692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1570
1571 Make it possible to run ./temacs.
1572
1573 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1574 syms_of_callproc does the same thing. Remove test for
1575 "initialized", do it in the caller.
1576 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1577
620c53a6
SM
15782011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1579
1580 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1581 (read_minibuf): Use get_minibuffer.
1582 (syms_of_minibuf): Use DEFSYM.
1583 (Qmetadata): New var.
1584 * data.c (Qbuffer): Don't make it static.
1585 (syms_of_data): Use DEFSYM.
1586
e003a292
PE
15872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1588
1589 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1590 (CCL_CODE_MIN): New macro.
1591
ed008a6d
PE
15922011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1593
3687c2ef
PE
1594 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1595
ed008a6d
PE
1596 * eval.c (Qdebug): Now static.
1597 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1598 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1599 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1600
d66c4c7c
CY
16012011-05-29 Chong Yidong <cyd@stupidchicken.com>
1602
1603 * image.c: Various fixes to ImageMagick code comments.
1604 (Fimagemagick_types): Doc fix.
1605
5fbc2025
PE
16062011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1607
0196f88a
PE
1608 Minor fixes prompted by GCC 4.6.0 warnings.
1609
1610 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1611
5fbc2025
PE
1612 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1613 (x_clipboard_manager_save_all): Move extern decl to ...
1614 * xterm.h: ... here, so that it can be checked for consistency.
1615
1dd3c2d9
CY
16162011-05-29 Chong Yidong <cyd@stupidchicken.com>
1617
1618 * xselect.c (x_clipboard_manager_save_frame)
1619 (x_clipboard_manager_save_all): New functions.
1620 (Fx_clipboard_manager_save): Lisp function deleted.
1621
1622 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1623 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1624
1625 * xterm.h: Update prototype.
1626
5ba6571d
WX
16272011-05-28 William Xu <william.xwl@gmail.com>
1628
1629 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1630 exiting (Bug#8239).
1631
3eaff834
JM
16322011-05-28 Jim Meyering <meyering@redhat.com>
1633
e1900994 1634 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1635 * fns.c (to_uchar): Define.
1636 (crypto_hash_function): Use it to convert some newly-signed
1637 variables to unsigned, to avoid sign-extension bugs. For example,
1638 without this change, (md5 "truc") would evaluate to
1639 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1640 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1641 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1642
0f6990a7
PE
16432011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1644
1645 Integer overflow fixes.
c8a9ca5a 1646
08686060
PE
1647 * dbusbind.c: Serial number integer overflow fixes.
1648 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1649 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1650 to hold a serial number that is too large for a fixnum.
1651 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1652 Check for serial numbers out of range. Decode any serial number
59568bf0 1653 that was so large that it became a float. (Bug#8722)
08686060 1654
2d1fc3c7
PE
1655 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1656 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1657 Use XFASTINT rather than XUINT when numbers are nonnegative.
1658 (xd_append_arg, Fdbus_method_return_internal):
1659 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1660 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1661 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1662 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1663 (Bug#8722)
2d1fc3c7 1664
c8a9ca5a
PE
1665 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1666
519e1d69
PE
1667 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1668
30569699
PE
1669 ccl: add integer overflow checks
1670 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1671 (IN_INT_RANGE): New macros.
1672 (ccl_driver): Use them to check for integer overflow when
1673 decoding a CCL program. Many of the new checks are whether XINT (x)
1674 fits in int; it doesn't always, on 64-bit hosts. The new version
1675 doesn't catch all possible integer overflows, but it's an
847044ea 1676 improvement. (Bug#8719)
30569699 1677
c11285dc
PE
1678 * alloc.c (make_event_array): Use XINT, not XUINT.
1679 There's no need for unsigned here.
1680
fdccd48e
PE
1681 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1682 This follows up to the 2011-05-06 change that substituted uintptr_t
1683 for EMACS_INT. This case wasn't caught back then.
1684
37910ab2
PE
1685 Rework Fformat to avoid integer overflow issues.
1686 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1687 now (part of C89). Include <verify.h>.
1688 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1689 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1690 (Fformat): Avoid the prepass trying to compute sizes; it was only
1691 approximate and thus did not catch overflow reliably. Instead, walk
1692 through the format just once, formatting and computing sizes as we go,
1693 checking for integer overflow at every step, and allocating a larger
1694 buffer as needed. Keep track separately whether the format is
1695 multibyte. Keep only the most-recently calculated precision, rather
1696 than them all. Record whether each argument has been converted to
1697 string. Use EMACS_INT, not int, for byte and char and arg counts.
1698 Support field widths and precisions larger than INT_MAX. Avoid
1699 sprintf's undefined behavior with conversion specifications such as %#d
1700 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1701 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1702 formatting out-of-range floating point numbers with int
1703 formats. (Bug#8668)
1704
2e6578fb
PE
1705 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1706
0ae6bdee
PE
1707 * data.c: Avoid integer truncation in expressions involving floats.
1708 * data.c: Include <intprops.h>.
1709 (arith_driver): When there's an integer overflow in an expression
1710 involving floating point, convert the integers to floating point
1711 so that the resulting value does not suffer from catastrophic
1712 integer truncation. For example, on a 64-bit host (* 4
1713 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1714 Do not rely on undefined behavior after integer overflow.
1715
de883a70
PE
1716 merge count_size_as_multibyte, parse_str_to_multibyte
1717 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1718 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1719 Check for integer overflow.
1720 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1721 since it's now a duplicate of the other. This is more of
1722 a character than a buffer op, so better that it's in character.c.
1723 * fns.c, print.c: Adjust to above changes.
1724
2ff916cb
PE
17252011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1726
1727 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1728
f1b54466
PE
17292011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1730
fb1ac845
PE
1731 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1732 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1733 (x_clipboard_manager_save): Now static.
1734 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1735
f1b54466
PE
1736 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1737 (crypto_hash_function): Now static.
1738 Fix pointer signedness problems. Avoid unnecessary initializations.
1739
a9f737ee
CY
17402011-05-27 Chong Yidong <cyd@stupidchicken.com>
1741
1742 * termhooks.h (Vselection_alist): Make it terminal-local.
1743
1744 * terminal.c (create_terminal): Initialize it.
1745
1746 * xselect.c: Support for clipboard managers.
1747 (Vselection_alist): Move to termhooks.h as terminal-local var.
1748 (LOCAL_SELECTION): New macro.
1749 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1750 (symbol_to_x_atom): Remove gratuitous arg.
1751 (x_handle_selection_request, lisp_data_to_selection_data)
1752 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1753 (x_own_selection, x_get_local_selection, x_convert_selection):
1754 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1755 (some_frame_on_display): Delete unused function.
1756 (Fx_own_selection_internal, Fx_get_selection_internal)
1757 (Fx_disown_selection_internal, Fx_selection_owner_p)
1758 (Fx_selection_exists_p): New optional frame arg.
1759 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1760 (x_handle_selection_clear): Don't treat other terminals with the
1761 same keyboard specially. Use the terminal-local Vselection_alist.
1762 (x_clear_frame_selections): Use Frun_hook_with_args.
1763
1764 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1765
1766 * xterm.h: Add support for those atoms.
1767
e067f0c1
CY
17682011-05-26 Chong Yidong <cyd@stupidchicken.com>
1769
1770 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1771 (converted_selections, conversion_fail_tag): New global variables.
1772 (x_selection_request_lisp_error): Free the above.
1773 (x_get_local_selection): Remove unnecessary code.
1774 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1775 of converted selections stored in converted_selections.
1776 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1777 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1778 (x_convert_selection): New function.
1779 (x_handle_selection_event): Simplify.
1780 (x_get_foreign_selection): Don't ignore incoming requests while
1781 waiting for an answer; this will fail when we implement
1782 SAVE_TARGETS, and seems unnecessary anyway.
1783 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1784 (Vx_sent_selection_functions): Doc fix.
1785
0f4aebc0
LL
17862011-05-26 Leo Liu <sdl.web@gmail.com>
1787
1788 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1789
e61124cd
YM
17902011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1791
1792 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1793
1794 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1795 for fringe update if it has periodic bitmap.
1796 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1797 and fringe_bitmap_periodic_p.
1798
1799 * fringe.c (get_fringe_bitmap_data): New function.
1800 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1801 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1802 row. Mark glyph row for fringe update if periodicity changed.
1803
1804 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1805 for fringe update unless it has periodic bitmap.
1806
f16d9837
KH
18072011-05-25 Kenichi Handa <handa@m17n.org>
1808
1809 * xdisp.c (get_next_display_element): Set correct it->face_id for
1810 a static composition.
1811
e1b90ef6
LL
18122011-05-24 Leo Liu <sdl.web@gmail.com>
1813
1814 * deps.mk (fns.o):
1815 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1816
1817 * fns.c (crypto_hash_function, Fsha1): New function.
1818 (Fmd5): Use crypto_hash_function.
1819 (syms_of_fns): Add Ssha1.
1820
7400048f
PE
18212011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1822
1823 * gnutls.c: Remove unused macros.
1824 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1825 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1826 Remove macros that are defined and never used.
1827 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1828
abb71cf4
CY
18292011-05-22 Chong Yidong <cyd@stupidchicken.com>
1830
1831 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1832 (Fx_get_selection_internal): Minor cleanup.
1833 (Fx_own_selection_internal): Rename arguments for consistency with
1834 select.el.
1835
6307db39
PE
18362011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1837
1838 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1839
f3d4e0a4
CY
18402011-05-22 Chong Yidong <cyd@stupidchicken.com>
1841
1842 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1843
4d8ade89
YM
18442011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1845
1846 * dispnew.c (scrolling_window): Don't exclude the case that the
1847 last enabled row in the desired matrix touches the bottom boundary.
1848
32078c8d
GM
18492011-05-21 Glenn Morris <rgm@gnu.org>
1850
1851 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1852 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1853 and add some more files.
32078c8d 1854
7285dc67
EZ
18552011-05-20 Eli Zaretskii <eliz@gnu.org>
1856
1857 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1858 report_file_error introduced by the change from 2011-05-07.
1859
89d1bd22
PE
18602011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1861
1862 * systime.h (Time): Define only if emacs is defined.
1863 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1864 where the include path doesn't have X11/X.h by default. See
1865 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1866
e23640bb 18672011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1868
1869 * composite.c (find_automatic_composition): Fix previous change.
1870
b9704ad9
GM
18712011-05-20 Glenn Morris <rgm@gnu.org>
1872
1873 * lisp.mk: New file, split from Makefile.in.
1874 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1875 (shortlisp): Remove.
1876 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1877
4a720484
GM
18782011-05-19 Glenn Morris <rgm@gnu.org>
1879
1880 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1881 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1882 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1883 (lisp): Set the order to that of loadup.el.
1884 (shortlisp): Make it a copy of $lisp.
1885 (SOME_MACHINE_LISP): Remove.
1886 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1887 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1888
a28d4396
KH
18892011-05-18 Kenichi Handa <handa@m17n.org>
1890
1891 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1892 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1893 (find_automatic_composition): Mostly rewrite for efficiency.
1894
a2b1fa8e
JB
18952011-05-18 Juanma Barranquero <lekktu@gmail.com>
1896
1897 * makefile.w32-in: Update dependencies.
1898
8e1f5610
CS
18992011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1900
1901 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1902 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1903
7025ee00 19042011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1905
cdfa6eab
PE
1906 Fix some integer overflow issues, such as string length overflow.
1907
06d6db33
PE
1908 * insdel.c (count_size_as_multibyte): Check for string overflow.
1909
2b4560a8
PE
1910 * character.c (lisp_string_width): Check for string overflow.
1911 Use EMACS_INT, not int, for string indexes and lengths; in
1912 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1913 the resulting string length overflows an EMACS_INT; instead,
1914 report a string overflow if no precision given. When checking for
1915 precision exhaustion, use a check that cannot possibly have
1916 integer overflow. (Bug#8675)
1917 * character.h (lisp_string_width): Adjust to new signature.
1918
cb93f9be
PE
1919 * alloc.c (string_overflow): New function.
1920 (Fmake_string): Use it. This doesn't change behavior, but saves
1921 a few bytes and will simplify future changes.
1922 * character.c (string_escape_byte8): Likewise.
1923 * lisp.h (string_overflow): New decl.
1924
1a1f3366
PE
1925 Fixups, following up to the user-interface timestamp change.
1926 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1927 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1928 * msdos.c (mouse_get_pos): Likewise.
1929 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1930 * w32gui.h (Time): Define by including "systime.h" rather than by
1931 declaring it ourselves. (Bug#8664)
1932
d4e3e4d3
PE
1933 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1934 * image.c (clear_image_cache): Likewise.
1935
f6a24d19
PE
1936 * term.c (term_mouse_position): Don't assume time_t wraparound.
1937
08dc5ae6
PE
1938 Be more systematic about user-interface timestamps.
1939 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1940 and sometimes 'EMACS_UINT', to represent these timestamps.
1941 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1942 This makes the code easier to follow, and makes it easier to catch
1943 integer overflow bugs such as Bug#8664.
1944 * frame.c (Fmouse_position, Fmouse_pixel_position):
1945 Use Time, not unsigned long, for user-interface timestamps.
1946 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1947 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1948 * keyboard.h (last_event_timestamp): Likewise.
1949 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1950 * menu.h (xmenu_show): Likewise.
1951 * term.c (term_mouse_position): Likewise.
1952 * termhooks.h (struct input_event.timestamp): Likewise.
1953 (struct terminal.mouse_position_hook): Likewise.
1954 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1955 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1956 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1957 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1958 what it was before.
1959 * menu.h, termhooks.h: Include "systime.h", for Time.
1960
8e55734a
PE
1961 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1962 Don't assume that the difference between two unsigned long values
1963 can fit into an integer. At this point, we know button_down_time
1964 <= event->timestamp, so the difference must be nonnegative, so
1965 there's no need to cast the result if double-click-time is
1966 nonnegative, as it should be; check that it's nonnegative, just in
1967 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1968 apart (about 25 days). (Bug#8664)
8e55734a 1969
841f1b75 1970 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1971 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1972
3e26f69c
PE
1973 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1974 that always fit in int. Use a sentinel instead of a counter, to
1975 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1976 * frame.h (struct frame): Use int for menu_bar_items_used
1977 instead of EMACS_INT, since it always fits in int.
3e26f69c 1978
5cc152c0
PE
1979 * menu.c (grow_menu_items): Check for int overflow.
1980
d89eb65e
PE
1981 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1982
5235bd3e
PE
1983 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1984 Before, the code was not consistent. These values cannot exceed
1985 2**31 - 1 so there's no need to make them unsigned.
1986 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1987 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1988 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1989 as modifiers.
1990 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1991
bc827e23
PE
1992 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1993 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1994 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1995 presumably because the widths might not match.
1996
78eb494e
PE
1997 * window.c (size_window): Avoid needless test at loop start.
1998
04f2d78b
CB
19992011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2000
2001 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2002
d2fc7e3d 20032011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2004
2005 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2006
d2fc7e3d 20072011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2008
2009 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2010 `width' to `bar_area_x' and `bar_area_width', respectively.
2011 (x_scroll_run): Take account of fringe background extension.
2012
04f2d78b
CB
2013 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2014 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2015 `bar_area_width', respectively.
2016 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2017 background extension.
2018
79b70037
GM
20192011-05-10 Jim Meyering <meyering@redhat.com>
2020
2021 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2022
2f142cc5
JB
20232011-05-10 Juanma Barranquero <lekktu@gmail.com>
2024
2025 * image.c (Finit_image_library): Return t for built-in image types,
2026 like pbm and xbm. (Bug#8640)
2027
57679c86
AS
20282011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2029
2030 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2031
888c9e86
EZ
20322011-05-07 Eli Zaretskii <eliz@gnu.org>
2033
b0512a1d
EZ
2034 * w32console.c (Fset_screen_color): Doc fix.
2035 (Fget_screen_color): New function.
2036 (syms_of_ntterm): Defsubr it.
2037
7285dc67
EZ
2038 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2039 unlink the temporary file if Fcall_process didn't create it in the
2040 first place.
2041 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2042 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2043 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2044 cue to call_process_cleanup not to close that handle.
2045
4d3fcc8e
BK
20462011-05-07 Ben Key <bkey76@gmail.com>
2047
2048 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2049 one of two shell specific rules, either bootstrap-temacs-CMD or
2050 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2051 to the previous implementation of the bootstrap-temacs rule.
2052 The bootstrap-temacs-CMD rule is similar to the previous
2053 implementation of the bootstrap-temacs rule except that it
2054 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2055 variable.
2056
2057 These changes, along with some changes to nt/configure.bat,
2058 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2059 earlier fix to add support for --cflags and --ldflags options
2060 that include quotes so that it works whether make uses cmd or
2061 sh as the shell.
2062
b4289b64
MA
20632011-05-06 Michael Albinus <michael.albinus@gmx.de>
2064
2065 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2066 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2067 is a constant.
2068 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2069 a string. Handle both cases.
2070 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2071 (Fdbus_register_method): Use Qinvalid_function.
2072
af4c0e28
JB
20732011-05-06 Juanma Barranquero <lekktu@gmail.com>
2074
2075 * makefile.w32-in: Update dependencies.
2076 (LISP_H): Add inttypes.h and stdin.h.
2077 (PROCESS_H): Add unistd.h.
2078
c51453d9
EZ
20792011-05-06 Eli Zaretskii <eliz@gnu.org>
2080
2081 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2082 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2083
8ff0ac3c 20842011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2085
4c4b566b
PE
2086 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2087
aab2b9b5
PE
2088 * term.c (vfatal): Remove stray call to va_end.
2089 It's not needed and the C Standard doesn't allow it here anyway.
2090
c378da0b
PE
2091 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2092 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2093
288b08c7
PE
2094 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2095 bytes.
2096
e3601888
PE
2097 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2098
db6c0e74
PE
2099 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2100
dd5963ea
PE
2101 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2102
88c9450f
PE
2103 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2104
2f9442b8
PE
2105 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2106
c032b5f8
PE
2107 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2108 * charset.c (Fdefine_charset_internal): Don't initialize
2109 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2110 32-bit int (Bug#8600).
a108c10b
PE
2111
2112 * lread.c (read_integer): Be more consistent with string-to-number.
2113 Use string_to_number to do the actual conversion; this avoids
2114 rounding errors and fixes some other screwups. Without this fix,
2115 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2116 (digit_to_number): Move earlier, for benefit of read_integer.
2117 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2118 not a digit in any supported base. (Bug#8602)
a108c10b 2119
ad5f9eea
PE
2120 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2121
aec1708a
PE
2122 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2123 to match comment at start of function. This also removes a
2124 GCC warning about overflow in a 32+64-bit port.
2125
47be4ab5
PE
2126 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2127
371cac43
PE
2128 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2129 Reported by Stefan Monnier in
2130 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2131 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2132 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2133
d01a7826
PE
2134 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2135 (EMACS_UINTPTR): Likewise, with uintptr_t.
2136
7fd47d5c
PE
2137 * lisp.h: Prefer 64-bit EMACS_INT if available.
2138 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2139 on 32-bit hosts that have 64-bit int, so that they can access
2140 large files.
122b0c86
PE
2141 However, temporarily disable this change unless the temporary
2142 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2143
8727937b
PE
2144 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2145
8ac068ac
PE
2146 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2147 This removes an assumption that EMACS_INT and long are the same
2148 width as pointers. The assumption is true for Emacs porting targets
2149 now, but we want to make other targets possible.
2150 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2151 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2152 In the rest of the code, change types of integers that hold casted
2153 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2154 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2155 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2156 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2157 No need to cast type when ORing.
2158 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2159 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2160 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2161 assume EMACS_INT is the same width as char *.
2162 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2163 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2164 Remove no-longer-needed casts.
2165 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2166 (xg_tool_bar_help_callback, xg_make_tool_item):
2167 Use EMACS_INTPTR to hold an integer
2168 that will be cast to void *; this can avoid a GCC warning
2169 if EMACS_INT is not the same width as void *.
2170 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2171 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2172 (current_message_1, set_message_1):
2173 Use a local to convert to proper width without a cast.
2174 * xmenu.c (dialog_selection_callback): Likewise.
2175
ede49d71
PE
2176 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2177 Also, don't assume VALBITS / RAND_BITS is less than 5,
2178 and don't rely on undefined behavior when shifting a 1 left into
2179 the sign bit.
2180 * lisp.h (get_random): Change signature to match.
2181
2f30ecd0
PE
2182 * lread.c (hash_string): Use size_t, not int, for hash computation.
2183 Normally we prefer signed values; but hashing is special, because
2184 it's better to use unsigned division on hash table sizes so that
2185 the remainder is nonnegative. Also, size_t is the natural width
2186 for hashing into memory. The previous code used 'int', which doesn't
2187 retain enough info to hash well into very large tables.
2188 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2189
2a866e7b
PE
2190 * dbusbind.c: Don't possibly lose pointer info when converting.
2191 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2192 Use XPNTR rather than XHASH, so that the high-order bits of
2193 the pointer aren't lost when converting through void *.
2194
51639eac
PE
2195 * eval.c (Fautoload): Don't double-shift a pointer.
2196
92394119
PE
2197 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2198
dbdb9a7c
JB
21992011-05-06 Juanma Barranquero <lekktu@gmail.com>
2200
2201 * gnutls.c (DEF_GNUTLS_FN):
2202 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2203
db7a0b4f
AS
22042011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2205
2206 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2207 marker. (Bug#8610)
2208
f7ff1b0f 22092011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2210
2211 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2212 New version that can reserve upto 2GB of heap space.
2213
f7ff1b0f 22142011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2215
2216 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2217
639c109b
TZ
22182011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2219
2220 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2221 `gnutls_certificate_set_x509_key_file'.
2222
d2127135
JB
22232011-05-05 Juanma Barranquero <lekktu@gmail.com>
2224
2225 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2226 Update dependencies.
2227
e968f4f3
JB
22282011-05-04 Juanma Barranquero <lekktu@gmail.com>
2229
2230 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2231 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2232 Remove unused parameter `fildes'.
2233 * process.c (read_process_output, send_process): Don't pass it.
2234
84d358f0
JB
22352011-05-04 Juanma Barranquero <lekktu@gmail.com>
2236
2237 Fix previous change: the library cache is defined in w32.c.
2238 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2239 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2240
0898ca10
JB
22412011-05-04 Juanma Barranquero <lekktu@gmail.com>
2242
2243 Implement dynamic loading of GnuTLS on Windows.
2244
2245 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2246 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2247 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2248 Declare.
2249
2250 * gnutls.c (Qgnutls_dll): Define.
2251 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2252 (gnutls_*): Declare function pointers.
2253 (init_gnutls_functions): New function to initialize function pointers.
2254 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2255 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2256 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2257 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2258 (emacs_gnutls_write, emacs_gnutls_read)
2259 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2260 (Fgnutls_available_p): New function.
2261 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2262 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2263 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2264
2265 * image.c: Include w32.h.
2266 (Vimage_type_cache): Delete.
2267 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2268 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2269 (w32_delayed_load): Move to w32.c.
2270
2271 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2272
2273 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2274 (w32_delayed_load): Move from image.c. When loading a library, record
2275 its filename in the :loaded-from property of the library id.
2276 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2277 Initialize and staticpro them.
2278 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2279
2280 * process.c: Include lisp.h before w32.h, not after.
2281 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2282 instead of gnutls_record_check_pending.
2283
2284 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2285
ff4de4aa
TZ
22862011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2287
2288 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2289 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2290 as passed in.
2291
abe95abb
JD
22922011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2293
2294 * xterm.c (x_set_frame_alpha): Do not set property on anything
2295 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2296
e16e55d4
JB
22972011-05-02 Juanma Barranquero <lekktu@gmail.com>
2298
2299 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2300
bafcf6a5
JB
23012011-05-02 Juanma Barranquero <lekktu@gmail.com>
2302
2303 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2304 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2305 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2306 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2307 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2308 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2309 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2310 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2311 (Qgnutls_bootprop_callbacks_verify): Make static.
2312
e7a6747f
AS
23132011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2314
19ed11ba
AS
2315 * callproc.c: Indentation fixup.
2316
e7a6747f 2317 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2318 (wait_for_termination, interruptible_wait_for_termination):
2319 Move after wait_for_termination_1.
e7a6747f 2320
1ef14cb4
LMI
23212011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2322
2323 * sysdep.c (interruptible_wait_for_termination): New function
2324 which is like wait_for_termination, but allows keyboard
2325 interruptions.
2326
2327 * callproc.c (Fcall_process): Add (:file "file") as an option for
2328 the STDOUT buffer.
2329 (Fcall_process_region): Ditto.
2330
330d880c
EZ
23312011-04-30 Eli Zaretskii <eliz@gnu.org>
2332
8db90b73
EZ
2333 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2334 rather than `XVECTOR (FOO)->size'.
2335
330d880c
EZ
2336 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2337 inttypes.h, as a gnulib replacement is used if it not available in
2338 system headers.
2339
15cbd324
EZ
23402011-04-21 Eli Zaretskii <eliz@gnu.org>
2341
2342 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2343 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2344 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2345
2346 * coding.c (coding_alloc_by_realloc): Error out if destination
2347 will grow beyond MOST_POSITIVE_FIXNUM.
2348 (decode_coding_emacs_mule): Abort if there isn't enough place in
2349 charbuf for the composition carryover bytes. Reserve an extra
2350 space for up to 2 characters produced in a loop.
2351 (decode_coding_iso_2022): Abort if there isn't enough place in
2352 charbuf for the composition carryover bytes.
2353
23542011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2355
ae940cca
EZ
2356 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2357 aborting when %lld or %lll format is passed.
2358 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2359 %llo or %llx format is passed. (Bug#8545)
2360
03ab8921
EZ
2361 * window.c (window_scroll_line_based): Use a marker instead of
2362 simple variables to record original value of point. (Bug#7952)
2363
afda1437
EZ
2364 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2365 produced by %s or %c overflows available buffer space. (Bug#8545)
2366
f76dee0c
PE
23672011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2368
2369 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2370 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2371
fdc5744d
JB
23722011-04-28 Juanma Barranquero <lekktu@gmail.com>
2373
2374 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2375
638f053a
JB
23762011-04-28 Juanma Barranquero <lekktu@gmail.com>
2377
2378 * keyboard.c (Qdelayed_warnings_hook): Define.
2379 (command_loop_1): Run `delayed-warnings-hook'
2380 if Vdelayed_warnings_list is non-nil.
2381 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2382 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2383
d178f871
EZ
23842011-04-28 Eli Zaretskii <eliz@gnu.org>
2385
2386 * doprnt.c (doprnt): Don't return value smaller than the buffer
2387 size if the message was truncated. (Bug#8545).
2388
b124fd93
JB
23892011-04-28 Juanma Barranquero <lekktu@gmail.com>
2390
2391 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2392 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2393
e810457d
PE
23942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2395
2396 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2397
ea51cceb
JB
23982011-04-27 Juanma Barranquero <lekktu@gmail.com>
2399
2400 * makefile.w32-in: Update dependencies.
2401
94dcfacf
EZ
24022011-04-27 Eli Zaretskii <eliz@gnu.org>
2403
2404 Improve `doprnt' and its usage. (Bug#8545)
2405 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2406 `format_end'. Remove support for %l as a conversion specifier.
2407 Don't use xrealloc. Improve diagnostics when the %l size modifier
2408 is used. Update the commentary.
2409
2410 * eval.c (verror): Simplify calculation of size_t.
2411
2412 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2413 messages.
2414
f61f41d7
PE
24152011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2416
2417 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2418 change.
2419
96fb4434
PE
24202011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2421
2422 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2423 This makes this file independent of the recent pseudovector change.
2424
671875da 24252011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2426
69e9b5a3
PE
2427 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2428
b5f869a7 2429 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2430 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2431 Remove unused local.
c8926152 2432 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2433
841a1577 2434 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2435 GCC 4.6.0 optimizes based on type-based alias analysis.
2436 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2437 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2438 != &v->size, and therefore "v->size = 1; b->size = 2; return
2439 v->size;" must therefore return 1. This assumption is incorrect
2440 for Emacs, since it type-puns struct Lisp_Vector * with many other
2441 types. To fix this problem, this patch adds a new type struct
f904488f 2442 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2443 and pseudovectors, and helps optimizing compilers not get fooled
2444 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2445 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2446 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2447 the size member.
eab3844f
PE
2448 (XSETPVECTYPE): Rewrite in terms of new macro.
2449 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2450 This is a bit clearer, and further avoids the possibility of
2451 undesirable aliasing.
2452 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2453 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2454 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2455 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2456 (ASIZE): Now uses header.size rather than size.
2457 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2458 to avoid the hassle of writing XVECTOR (foo)->header.size.
2459 (struct vectorlike_header): New type.
eab3844f
PE
2460 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2461 object, to help avoid aliasing.
2462 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2463 (SUBRP): Likewise, since Lisp_Subr is a special case.
2464 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2465 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2466 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2467 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2468 changed to be "header.size" and "header.next".
2469 * buffer.h (struct buffer): Likewise.
2470 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2471 * frame.h (struct frame): Likewise.
2472 * process.h (struct Lisp_Process): Likewise.
2473 * termhooks.h (struct terminal): Likewise.
2474 * window.c (struct save_window_data, struct saved_window): Likewise.
2475 * window.h (struct window): Likewise.
2476 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2477 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2478 * buffer.c (init_buffer_once): Likewise.
2479 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2480 special case.
2481 * process.c (Fformat_network_address): Use local var for size,
2482 for brevity.
2483
0df1eac5
PE
2484 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2485
847ab9d1 2486 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2487 * data.c (atof): Remove decl; no longer used or needed.
2488 (digit_to_number): Move to lread.c.
2489 (Fstring_to_number): Use new string_to_number function, to be
2490 consistent with how the Lisp reader treats infinities and NaNs.
2491 Do not assume that floating-point numbers represent EMACS_INT
2492 without losing information; this is not true on most 64-bit hosts.
2493 Avoid double-rounding errors, by insisting on integers when
2494 parsing non-base-10 numbers, as the documentation specifies.
2495 * lisp.h (string_to_number): New decl, replacing ...
2496 (isfloat_string): Remove.
bc0a5c13 2497 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2498 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2499 appears to have been a coding error. Similarly, do not accept
2500 strings like +-1e0 as floating point numbers. Do not report
2501 overflow for integer overflows unless the base is not 10 which
2502 means we have no simple and reliable way to continue.
2503 Break out the floating-point parsing into a new
2504 function string_to_number, so that Fstring_to_number parses
2505 floating point numbers consistently with the Lisp reader.
04f2d78b 2506 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2507 (E_CHAR, EXP_INT): Remove, replacing with ...
2508 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2509 (string_to_number): New function, replacing isfloat_string.
2510 This function checks for valid syntax and produces the resulting
2511 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2512 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2513 so that overflow for non-base-10 numbers is reported only when
2514 there's no portable and simple way to convert to floating point.
452f4150 2515
67769ffc
PE
2516 * textprop.c (set_text_properties_1): Rewrite for clarity,
2517 and to avoid GCC warning about integer overflow.
2518
c20db43f
PE
2519 * intervals.h (struct interval): Use EMACS_INT for members
2520 where EMACS_UINT might cause problems. See
2521 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2522 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2523 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2524 All uses changed.
37aa2f85
PE
2525 (offset_intervals): Tell GCC not to worry about length overflow
2526 when negating a negative length.
c20db43f 2527
2538aa2f
PE
2528 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2529 (overrun_check_free): Likewise.
2530
f2d3008d
PE
2531 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2532 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2533 word size.
2534
ec8df744
PE
2535 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2536 (gnutls_make_error): Rename local to avoid shadowing.
2537 (gnutls_emacs_global_deinit): ifdef out; not used.
2538 (Fgnutls_boot): Use const for pointer to readonly storage.
2539 Comment out unused local. Fix pointer signedness problems.
2540
640ee02d
PE
2541 * lread.c (openp): Don't stuff size_t into an 'int'.
2542 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2543 about possible signed overflow.
2544
6048fb2a
PE
2545 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2546 (GDK_KEY_g): Don't define if already defined.
2547 (xg_prepare_tooltip): Avoid pointer signedness problem.
2548 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2549
fa3c87e1
PE
2550 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2551 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2552
2172544b
PE
2553 * xfns.c (Fx_window_property): Simplify a bit,
2554 to make a bit faster and to avoid GCC 4.6.0 warning.
2555 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2556
9b821a21
PE
2557 * fns.c (internal_equal): Don't assume size_t fits in int.
2558
3c616cfa
PE
2559 * alloc.c (compact_small_strings): Tighten assertion a little.
2560
c2982e87
PE
2561 Replace pEd with more-general pI, and fix some printf arg casts.
2562 * lisp.h (pI): New macro, generalizing old pEd macro to other
2563 conversion specifiers. For example, use "...%"pI"d..." rather
2564 than "...%"pEd"...".
2565 (pEd): Remove. All uses replaced with similar uses of pI.
2566 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2567 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2568 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2569 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2570 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2571 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2572 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2573 64-bit hosts.
2574 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2575 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2576 * print.c (safe_debug_print, print_object): Likewise.
2577 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2578 to int.
6f04d126
PE
2579 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2580 avoiding the 0 flag, which is not portable.
c2982e87
PE
2581 * process.c (Fmake_network_process): Use pI to avoid cast.
2582 * region-cache.c (pp_cache): Likewise.
2583 * xdisp.c (decode_mode_spec): Likewise.
2584 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2585 behavior on 64-bit hosts with printf arg.
6f04d126 2586 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2587 (x_stop_queuing_selection_requests): Likewise.
2588 (x_get_window_property): Don't truncate byte count to an 'int'
2589 when tracing.
0b432f21 2590
5e073ec7
PE
2591 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2592 here, since it parses constructs like leading '-' and spaces,
2593 which are not wanted; and it overflows with large numbers.
2594 Instead, simply match F[0-9]+, which is what is wanted anyway.
2595
36372bf9
PE
2596 * alloc.c: Remove unportable assumptions about struct layout.
2597 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2598 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2599 (allocate_vectorlike, make_pure_vector): Use the new macros,
2600 plus offsetof, to remove unportable assumptions about struct layout.
2601 These assumptions hold on all porting targets that I know of, but
2602 they are not guaranteed, they're easy to remove, and removing them
2603 makes further changes easier.
2604
0b432f21
PE
2605 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2606 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2607 (string_overrun_cookie): Now const. Use initializers that
2608 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2609 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2610 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2611 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2612 multiple of sizeof (EMACS_INT); it need not be, if
2613 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2614 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2615
895009e1
JB
26162011-04-26 Juanma Barranquero <lekktu@gmail.com>
2617
2618 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2619
6a7a1b0b
TZ
26202011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2621
2622 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2623 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2624 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2625
841a1577 26262011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2627
2628 * lisp.h (Qdebug): List symbol.
895009e1 2629 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2630 * keyboard.c (debug-on-event): New variable.
2631 (handle_user_signal): Break into debugger when debug-on-event
2632 matches the current signal symbol.
2633
f2d3ba6f
DN
26342011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2635
2636 * alloc.c (check_sblock, check_string_bytes)
2637 (check_string_free_list): Convert to standard C.
2638
42ce4c63
TZ
26392011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2640
2641 * w32.c (emacs_gnutls_push): Fix typo.
2642
825cd63c
EZ
26432011-04-25 Eli Zaretskii <eliz@gnu.org>
2644
fb11d64d
EZ
2645 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2646 "cast to pointer from integer of different size".
2647
825cd63c
EZ
2648 Improve doprnt and its use in verror. (Bug#8545)
2649 * doprnt.c (doprnt): Document the set of format control sequences
2650 supported by the function. Use SAFE_ALLOCA instead of always
2651 using `alloca'.
2652
2653 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2654 is one byte too soon. Don't use xrealloc; instead xfree and
2655 xmalloc anew.
2656
e061a11b
TZ
26572011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2658
2659 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2660 callbacks stage.
2661
2662 * gnutls.c: Renamed global_initialized to
2663 gnutls_global_initialized. Added internals for the
2664 :verify-hostname-error, :verify-error, and :verify-flags
2665 parameters of `gnutls-boot' and documented those parameters in the
2666 docstring. Start callback support.
2667 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2668 unless a fatal error occured. Call gnutls_alert_send_appropriate
2669 on error. Return error code.
2670 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2671 (emacs_gnutls_read): Likewise.
2672 (Fgnutls_boot): Return handshake error code.
2673 (emacs_gnutls_handle_error): New function.
2674 (wsaerror_to_errno): Likewise.
2675
2676 * w32.h (emacs_gnutls_pull): Add prototype.
2677 (emacs_gnutls_push): Likewise.
2678
2679 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2680 (emacs_gnutls_push): Likewise.
2681
26822011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2683
2684 * process.c (wait_reading_process_output): Check if GnuTLS
2685 buffered some data internally if no FDs are set for TLS
2686 connections.
2687
2688 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2689 (LIBS): Link to USER_LIBS.
2690 ($(BLD)/gnutls.$(0)): New target.
2691
fa6996bc
EZ
26922011-04-24 Eli Zaretskii <eliz@gnu.org>
2693
eb35682e
EZ
2694 * xdisp.c (handle_single_display_spec): Rename the
2695 display_replaced_before_p argument into display_replaced_p, to
2696 make it consistent with the commentary. Fix typos in the
2697 commentary.
2698
e2ad650c
EZ
2699 * textprop.c (syms_of_textprop): Remove dead code.
2700 (copy_text_properties): Delete obsolete commentary about an
2701 interface that was deleted long ago. Fix typos in the description
2702 of arguments.
2703
1b2de274
EZ
2704 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2705 to changes in oldXMenu/XMenu.h from 2011-04-16.
2706 <menu_help_message, prev_menu_help_message>: Constify.
2707 (IT_menu_make_room): menu->help_text is now `const char **';
2708 adjust.
2709
2710 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2711 to changes in oldXMenu/XMenu.h from 2011-04-16.
2712 (struct XMenu): Declare `help_text' `const char **'.
2713
2714 * xfaces.c <Qunspecified>: Make extern again.
2715
2716 * syntax.c: Include sys/types.h before including regex.h, as
2717 required by Posix.
2718
762b15be
EZ
2719 * doc.c (get_doc_string): Improve the format passed to `error'.
2720
2721 * doprnt.c (doprnt): Improve commentary.
2722
2723 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2724
2725 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2726 them with etags.
2727
f1052e5d
EZ
2728 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2729 changes in globals.h immediately force recompilation.
762b15be
EZ
2730 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2731 $(CURDIR)/s/ms-w32.h.
2732 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2733
fa6996bc
EZ
2734 * character.c (Fchar_direction): Function deleted.
2735 (syms_of_character): Don't defsubr it.
2736 <char-direction-table>: Deleted.
2737
e6c3da20
EZ
27382011-04-23 Eli Zaretskii <eliz@gnu.org>
2739
2740 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2741 * doprnt.c: Include limits.h.
2742 (SIZE_MAX): New macro.
04f2d78b
CB
2743 (doprnt): Return a size_t value. 2nd arg is now size_t.
2744 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2745 Improve overflow protection. Support `l' modifier for integer
2746 conversions. Support %l conversion. Don't assume an EMACS_INT
2747 argument for integer conversions and for %c.
2748
2749 * lisp.h (doprnt): Restore prototype.
2750
2751 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2752 $(SRC)/character.h.
2753
2754 * Makefile.in (base_obj): Add back doprnt.o.
2755
2756 * deps.mk (doprnt.o): Add back prerequisites.
2757 (callint.o): Depend on character.h.
2758
2759 * eval.c (internal_lisp_condition_case): Include the handler
2760 representation in the error message.
2761 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2762 when breaking from the loop.
2763
2764 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2765
2766 * callint.c (Fcall_interactively): When displaying error message
2767 about invalid control letter, pass the character's codepoint, not
2768 a pointer to its multibyte form. Improve display of the character
2769 in octal and display also its hex code.
2770
2771 * character.c (char_string): Use %x to display the (unsigned)
2772 codepoint of an invalid character, to avoid displaying a bogus
2773 negative value.
2774
2775 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2776 `error', not SYMBOL_NAME itself.
2777
2778 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2779 character arguments to `error'.
2780
2781 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2782 to `error' in error message about FINAL_CHAR argument. Make sure
2783 FINAL_CHAR is a character, and use %c when it is passed as
2784 argument to `error'.
2785
4ffd0d6b 27862011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2787
2788 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2789
2790 * w32.c: Include <time.h>.
2791 (sys_localtime): New function.
2792
4ffd0d6b 27932011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2794
2795 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2796
4ffd0d6b 2797 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2798
4ffd0d6b 27992011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2800
4ffd0d6b
GM
2801 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2802 zombies (Bug#8467).
aac0c6e3 2803
04c56954
EZ
28042011-04-19 Eli Zaretskii <eliz@gnu.org>
2805
2806 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2807 gl_state.e_property when gl_state.object is Qt.
2808
2809 * insdel.c (make_gap_larger): Remove limitation of buffer size
2810 to <= INT_MAX.
2811
16a43933
CY
28122011-04-18 Chong Yidong <cyd@stupidchicken.com>
2813
2814 * xdisp.c (lookup_glyphless_char_display)
2815 (produce_glyphless_glyph): Handle cons cell entry in
2816 glyphless-char-display.
2817 (Vglyphless_char_display): Document it.
2818
2819 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2820 glyphless-char-display.
2821
4581706e
CY
28222011-04-17 Chong Yidong <cyd@stupidchicken.com>
2823
2824 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2825
2826 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2827
2828 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2829 definition for no-X builds.
2830
4887c6e2 28312011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2832
fd35b6f9
PE
2833 Static checks with GCC 4.6.0 and non-default toolkits.
2834
5c1ccb01
PE
2835 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2836
006c5daa
PE
2837 * process.c (keyboard_bit_set): Define only if SIGIO.
2838 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2839 (send_process): Repair possible setjmp clobbering.
2840
efc736d3
PE
2841 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2842
4e2fe2e6
PE
2843 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2844
f97334a2
PE
2845 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2846
4e75f29d
PE
2847 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2848 Define only if needed.
2849
90efadd1
PE
2850 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2851 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2852 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2853
3c647824
PE
2854 * dispextern.h (struct redisplay_interface): Rename param
2855 to avoid shadowing.
e264f262 2856 * termhooks.h (struct terminal): Likewise.
761383f4 2857 * xterm.c (xembed_send_message): Likewise.
3c647824 2858
b58c5c4a
PE
2859 * insdel.c (make_gap_smaller): Define only if
2860 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2861
cad59032
PE
2862 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2863 it.
2864
c339dc2e
PE
2865 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2866 so that we aren't warned about unused symbols.
2867
91a3e27b
PE
2868 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2869
399c71d3 2870 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2871
8ffc96f5
PE
2872 * xfns.c (x_real_positions): Mark locals as initialized.
2873
eef9bc79
PE
2874 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2875
098db9dd
PE
2876 * xterm.c: Fix problems found by static analysis with other toolkits.
2877 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2878 (x_dispatch_event): Declare static if USE_GTK, and
2879 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2880 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2881 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2882 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2883 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2884
eb18f6cc
PE
2885 * xmenu.c (menu_help_callback): Pointer type fixes.
2886 Use const pointers when pointing at readonly data. Avoid pointer
2887 signedness clashes.
2888 (FALSE): Remove unused macro.
2889 (update_frame_menubar): Remove unused decl.
2890
1fe72bf8
PE
2891 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2892
60d9e1db
PE
2893 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2894 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2895 (single_menu_item): Rename local to avoid shadowing.
2896
39261c26
PE
2897 * keyboard.c (make_lispy_event): Remove unused local var.
2898
018c5e19
PE
2899 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2900 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2901
63d2b86e
PE
2902 * bitmaps: Change bitmaps from unsigned char back to the X11
2903 compatible char. Avoid the old compiler warnings about
2904 out-of-range initializers by using, for example, '\xab' rather
2905 than 0xab.
2906
aefd87e1
PE
2907 * xgselect.c (xgselect_initialize): Check vs interface
2908 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2909
bf501fb9
PE
2910 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2911
e9829fdf
PE
2912 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2913 to read-only memory.
2914
1086c095
PE
2915 * fns.c (vector): Remove; this old hack is no longer needed.
2916
2baccd04 2917 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2918 Remove unused var.
dde42981 2919 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2920
72391843 2921 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2922
436c16df 2923 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2924 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2925 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2926
92bb796d 2927 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2928 (x_term_init): Remove local to avoid shadowing.
92bb796d 2929
764430a3 2930 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2931
2932 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2933 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2934
d1dfb56c
EZ
29352011-04-16 Eli Zaretskii <eliz@gnu.org>
2936
c4354cb4
EZ
2937 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2938
d1dfb56c
EZ
2939 Fix regex.c, syntax.c and friends for buffers > 2GB.
2940 * syntax.h (struct gl_state_s): Declare character position members
2941 EMACS_INT.
2942
2943 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2944
04f2d78b
CB
2945 * textprop.c (verify_interval_modification, interval_of):
2946 Declare arguments EMACS_INT.
d1dfb56c
EZ
2947
2948 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2949 EMACS_INT.
2950
2951 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2952
2953 * indent.c (Fvertical_motion): Local variable it_start is now
2954 EMACS_INT.
2955
2956 * regex.c (re_match, re_match_2, re_match_2_internal)
2957 (bcmp_translate, regcomp, regexec, print_double_string)
2958 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2959 (re_compile_pattern, re_exec): Declare arguments and local
2960 variables `size_t' and `ssize_t' and return values `regoff_t', as
2961 appropriate.
2962 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2963 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2964 <compile_stack_type>: `size' and `avail' are now `size_t'.
2965
2966 * regex.h <regoff_t>: Use ssize_t, not int.
2967 (re_search, re_search_2, re_match, re_match_2): Arguments that
2968 specify buffer/string position and length are now ssize_t and
2969 size_t. Return type is regoff_t.
2970
613052cd
BK
29712011-04-16 Ben Key <bkey76@gmail.com>
2972
2973 * nsfont.m: Fixed bugs in ns_get_family and
2974 ns_descriptor_to_entity that were caused by using free to
2975 deallocate memory blocks that were allocated by xmalloc (via
2976 xstrdup). This caused Emacs to crash when compiled with
2977 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2978 --enable-checking=xmallocoverrun). xfree is now used to
2979 deallocate these memory blocks.
2980
4170f62f 29812011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2982
71b41406
PE
2983 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2984
9587a89d
PE
2985 emacs_write: Accept and return EMACS_INT for sizes.
2986 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2987 et seq.
2988 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2989 Accept and return EMACS_INT.
2990 (emacs_gnutls_write): Return the number of bytes written on
2991 partial writes.
2992 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2993 (emacs_read, emacs_write): Remove check for negative size, as the
2994 Emacs source code has been audited now.
9587a89d
PE
2995 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2996 (emacs_read, emacs_write): Use it.
273a5f82
PE
2997 * process.c (send_process): Adjust to the new signatures of
2998 emacs_write and emacs_gnutls_write. Do not attempt to store
2999 a byte offset into an 'int'; it might overflow.
9587a89d 3000 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3001
3e047f51
PE
3002 * sound.c: Don't assume sizes fit in 'int'.
3003 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3004 Return EMACS_INT, not int.
3e047f51 3005 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3006 Accept EMACS_INT, not int.
3007 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3008 record read return values.
3009
cc39a9db
BK
30102011-04-15 Ben Key <bkey76@gmail.com>
3011
c9d0ec6d
JB
3012 * keyboard.c (Qundefined): Don't declare static since it is used
3013 in nsfns.m.
3014 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3015 static since they are used in nsfont.m.
cc39a9db 3016
6c60eb9f
SM
30172011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3018
3019 * process.c (Qprocessp): Don't declare static.
3020 * lisp.h (Qprocessp): Declare again.
3021
7990b61a
JB
30222011-04-15 Juanma Barranquero <lekktu@gmail.com>
3023
3024 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3025
5d4cb038
PE
30262011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3027
8bd7b830 3028 Improve C-level modularity by making more things 'static'.
cd64ea1d 3029
e3b27b31
PE
3030 Don't publish debugger-only interfaces to other modules.
3031 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3032 (verify_bytepos, count_markers): Move decls to the only modules
3033 that need them.
3034 * region-cache.h (pp_cache): Likewise.
3035 * window.h (check_all_windows): Likewise.
3036 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3037
5d4cb038
PE
3038 * sysdep.c (croak): Now static, if
3039 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3040 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3041
3042 * alloc.c (refill_memory_reserve): Now static if
3043 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3044 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3045
e87b6180
PE
3046 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3047 Define only if USE_LUCID.
3048
ac64929e
PE
3049 * xrdb.c (x_customization_string, x_rm_string): Now static.
3050
6f37259d
PE
3051 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3052 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3053
1683e3ab
PE
3054 * xdisp.c (draw_row_with_mouse_face): Now static.
3055 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3056
de9c2632
PE
3057 * window.h (check_all_windows): Mark externally visible.
3058
2b96acb7
PE
3059 * window.c (window_deletion_count): Now static.
3060
3061 * undo.c: Make symbols static if they're not exported.
3062 (last_undo_buffer, last_boundary_position, pending_boundary):
3063 Now static.
3064
50436f33
PE
3065 * textprop.c (interval_insert_behind_hooks): Now static.
3066 (interval_insert_in_front_hooks): Likewise.
3067
64520e5c
PE
3068 * term.c: Make symbols static if they're not exported.
3069 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3070 (max_frame_lines, tty_set_terminal_modes):
3071 (tty_reset_terminal_modes, tty_turn_off_highlight):
3072 (get_tty_terminal): Now static.
3073 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3074 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3075 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3076 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3077 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3078
1fa53021
PE
3079 * sysdep.c: Make symbols static if they're not exported.
3080 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3081 Now static.
3082 (sigprocmask_set, full_mask): Remove; unused.
3083 (wait_debugging): Mark as visible.
3084 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3085 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3086
d4b43b22
PE
3087 * syntax.c (syntax_temp): Define only if !__GNUC__.
3088
b7c513d0
PE
3089 * sound.c (current_sound_device, current_sound): Now static.
3090
989b29ad
PE
3091 * search.c (searchbufs, searchbuf_head): Now static.
3092
13a55a78
PE
3093 * scroll.c (scroll_cost): Remove; unused.
3094 * dispextern.h (scroll_cost): Remove decl.
3095
de68a1fc
PE
3096 * region-cache.h (pp_cache): Mark as externally visible.
3097
40ccffa6
PE
3098 * process.c: Make symbols static if they're not exported.
3099 (process_tick, update_tick, create_process, chan_process):
3100 (Vprocess_alist, proc_buffered_char, datagram_access):
3101 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3102 (deactivate_process): Mark defn as static, as well as decl.
3103 * lisp.h (create_process): Remove decl.
3104 * process.h (chan_process, Vprocess_alist): Remove decls.
3105
ad64fc97
PE
3106 * print.c: Make symbols static if they're not exported.
3107 (print_depth, new_backquote_output, being_printed, print_buffer):
3108 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3109 (print_interval, print_number_index, initial_stderr_stream):
3110 Now static.
3111 * lisp.h (Fprinc): Remove decl.
3112 (debug_output_compilation_hack): Mark as externally visible.
3113
adddb265
PE
3114 * sysdep.c (croak): Move decl from here to syssignal.h.
3115 * syssignal.h (croak): Put it here, so the API can be checked when
3116 'croak' is called from dissociate_if_controlling_tty.
3117
1717ede2
PE
3118 * minibuf.c: Make symbols static if they're not exported.
3119 (minibuf_save_list, choose_minibuf_frame): Now static.
3120 * lisp.h (choose_minibuf_frame): Remove decl.
3121
fa5fb2bc
PE
3122 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3123
1e3890d1
PE
3124 * lread.c: Make symbols static if they're not exported.
3125 (read_objects, initial_obarray, oblookup_last_bucket_number):
3126 Now static.
3127 (make_symbol): Remove; unused.
3128 * lisp.h (initial_obarray, make_symbol): Remove decls.
3129
8a1414fa
PE
3130 * keyboard.c: Make symbols static if they're not exported.
3131 (single_kboard, recent_keys_index, total_keys, recent_keys):
3132 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3133 (this_single_command_key_start, echoing, last_auto_save):
3134 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3135 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3136 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3137 (Vlispy_mouse_stem, double_click_count):
3138 Now static.
3139 (force_auto_save_soon): Define only if SIGDANGER.
3140 (ignore_mouse_drag_p): Now static if
3141 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3142 (print_help): Remove; unused.
3143 (stop_character, last_timer_event): Mark as externally visible.
3144 * keyboard.h (ignore_mouse_drag_p): Declare only if
3145 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3146 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3147 * lisp.h (echoing): Remove decl.
3148 (force_auto_save_soon): Declare only if SIGDANGER.
3149 * xdisp.c (redisplay_window): Simplify code, to make it more
3150 obvious that ignore_mouse_drag_p is not accessed if !defined
3151 USE_GTK && !defined HAVE_NS.
3152
93ea6e8f
PE
3153 * intervals.c: Make symbols static if they're not exported.
3154 (merge_properties_sticky, merge_interval_right, delete_interval):
3155 Now static.
3156 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3157
77382fcc
PE
3158 * insdel.c: Make symbols static if they're not exported.
3159 However, leave prepare_to_modify_buffer alone. It's never
3160 called from outside this function, but that appears to be a bug.
3161 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3162 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3163 (adjust_after_replace_noundo): Remove; unused.
3164 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3165 (signal_before_change): Remove decls.
77382fcc 3166
9306c32e
PE
3167 * indent.c (val_compute_motion, val_vmotion): Now static.
3168
cd44d2eb
PE
3169 * image.c: Make symbols static if they're not exported.
3170 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3171 if USE_GTK.
3172 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3173 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3174
ad9a7a06
PE
3175 * fringe.c (standard_bitmaps): Now static.
3176 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3177
81626931
PE
3178 * frame.c: Make symbols static if they're not exported.
3179 (x_report_frame_params, make_terminal_frame): Now static.
3180 (get_frame_param): Now static, unless HAVE_NS.
3181 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3182 (x_get_resource_string): Remove; not used.
3183 * frame.h (make_terminal_frame, x_report_frame_params):
3184 (x_get_resource_string); Remove decls.
3185 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3186 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3187
239f9db9
PE
3188 * font.c, fontset.c: Make symbols static if they're not exported.
3189 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3190 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3191 * font.c (font_close_object): Now static.
3192 * font.h (font_close_object): Remove.
3193 * fontset.c (FONTSET_OBJLIST): Remove.
3194 (free_realized_fontset) #if-0 the body, which does nothing.
3195 (face_suitable_for_char_p): #if-0, as it's never called.
3196 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3197 * xfaces.c (face_at_string_position):
3198 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3199 since 0 is always ASCII.
3200
dfcf3579
PE
3201 * fns.c (weak_hash_tables): Now static.
3202
5045092b
PE
3203 * fileio.c: Make symbols static if they're not exported.
3204 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3205 (Vwrite_region_annotation_buffers): Now static.
3206
57a96f5c
PE
3207 * eval.c: Make symbols static if they're not exported.
3208 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3209 * lisp.h (backtrace_list): Remove decl.
3210
35f08c38
PE
3211 * emacs.c: Make symbols static if they're not exported.
3212 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3213 (fatal_error_code, fatal_error_signal_hook, standard_args):
3214 Now static.
3215 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3216 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3217 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3218 * lisp.h (fatal_error_signal_hook): Remove decl.
3219 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3220
f44bd759
PE
3221 * editfns.c: Move a (normally-unused) function to its only use.
3222 * editfns.c, lisp.h (get_operating_system_release): Remove.
3223 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3224 worth the hassle of breaking this out.
3225
b532497d
PE
3226 * xterm.c: Make symbols static if they're not exported.
3227 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3228 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3229 (x_destroy_window, x_delete_display):
3230 Now static.
3231 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3232 (x_mouse_leave): Remove; unused.
3233 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3234 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3235 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3236 Remove decls.
3237 (x_mouse_leave): Declare only if WINDOWSNT.
3238 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3239 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3240 USE_X_TOOLKIT.
3241
1675728f
PE
3242 * ftxfont.c: Make symbols static if they're not exported.
3243 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3244 HAVE_FREETYPE.
3245 * font.h (ftxfont_driver): Likewise.
3246
e4cebfca
PE
3247 * xfns.c: Make symbols static if they're not exported.
3248 (x_last_font_name, x_display_info_for_name):
3249 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3250 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3251 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3252 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3253 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3254 (last_show_tip_args): Now static.
3255 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3256 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3257 (x_screen_planes): Remove; unused.
3258 * dispextern.h (x_screen_planes): Remove decl.
3259
5bf46f05
PE
3260 * dispnew.c: Make symbols static if they're not exported.
3261 * dispextern.h (redraw_garbaged_frames, scrolling):
3262 (increment_row_positions): Remove.
3263 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3264 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3265 Now static.
3266 (redraw_garbaged_frames): Remove; unused.
3267
435f4c28
PE
3268 * xfaces.c: Make symbols static if they're not exported.
3269 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3270 Remove decls.
3271 * xterm.h (defined_color): Remove decls.
3272 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3273 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3274 (menu_face_changed_default, defined_color, free_realized_face):
3275 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3276 (ascii_face_of_lisp_face): Remove; unused.
3277
8524aef3
PE
3278 * xdisp.c: Make symbols static if they're not exported.
3279 * dispextern.h (scratch_glyph_row, window_box_edges):
3280 (glyph_to_pixel_coords, set_cursor_from_row):
3281 (get_next_display_element, set_iterator_to_next):
3282 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3283 (show_mouse_face): Remove decls
3284 * frame.h (message_buf_print): Likewise.
3285 * lisp.h (pop_message, set_message, check_point_in_composition):
3286 Likewise.
3287 * xterm.h (set_vertical_scroll_bar): Likewise.
3288 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3289 (message_buf_print, scratch_glyph_row, displayed_buffer):
3290 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3291 (get_next_display_element, show_mouse_face, window_box_edges):
3292 (frame_to_window_pixel_xy, check_point_in_composition):
3293 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3294 (glyph_to_pixel_coords): Remove; unused.
3295
16390cd2
PE
3296 * dired.c (file_name_completion): Now static.
3297
3298 * dbusbind.c (xd_in_read_queued_messages): Now static.
3299
a25f4dfa
PE
3300 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3301 * data.c (circular_list_error): Remove.
3302
14a9c8df
PE
3303 * commands.h (last_point_position, last_point_position_buffer):
3304 (last_point_position_window): Remove decls.
3305 * keyboard.c: Make these variables static.
3306
04f2d78b
CB
3307 * coding.h (coding, code_convert_region, encode_coding_gap):
3308 Remove decls.
74ab6df5
PE
3309 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3310 (iso_code_class, detect_coding, code_convert_region): Now static.
3311 (encode_coding_gap): Remove; unused.
3312
38dfbee1
PE
3313 * chartab.c (chartab_chars, chartab_bits): Now static.
3314
a2cb4e63
PE
3315 * charset.h (charset_iso_8859_1): Remove decl.
3316 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3317 Now static.
3318
127198fd
PE
3319 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3320 * ccl.c (Vccl_program_table): Now static.
3321 (check_ccl_update): Remove; unused.
3322
d85b608f
PE
3323 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3324 * category.h: ... from here.
3325 * category.c (check_category_table, set_category_set): Now static.
3326
31cd66f3
PE
3327 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3328 * lisp.h: Remove these decls.
3329
c358e587
PE
3330 * buffer.c (buffer_count): Remove unused var.
3331
e78aecca
PE
3332 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3333 so that it's not optimized away.
3334 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3335 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3336 exported only to the debugger.
3337
e192d7d3 3338 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3339 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3340
92470028
PE
3341 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3342 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3343 was inaccessible from Lisp.
3344 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3345 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3346
244ed907
PE
3347 alloc.c: Import and export fewer symbols, and remove unused items.
3348 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3349 is defined.
3350 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3351 it's not optimized away by whole-program optimization.
3352 (message_enable_multibyte, free_misc): Remove.
3353 (catchlist, handlerlist, mark_backtrace):
3354 Declare only if BYTE_MARK_STACK.
3355 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3356 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3357 (message_enable_multibyte): Remove decl.
3358 (free_misc, interval_free_list, float_block, float_block_index):
3359 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3360 (cons_free_list, last_marked_index):
3361 Now static.
3362 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3363 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3364 (mark_backtrace): Define only if BYTE_MARK_STACK.
3365 * xdisp.c (message_enable_multibyte): Now static.
3366
61c2b50e 3367 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3368 This makes it easier for human readers (and static analyzers)
3369 to see whether these variables are used from other modules.
3370 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3371 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3372 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3373 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3374 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3375 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3376 * xmenu.c, xselect.c:
3377 Declare Q* vars static if they are not used in other modules.
3378 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3379 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3380 Remove decls of unexported vars.
3381 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3382
95c82688
PE
3383 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3384
16a97296
PE
3385 Make Emacs functions such as Fatom 'static' by default.
3386 This makes it easier for human readers (and static analyzers)
3387 to see whether these functions can be called from other modules.
3388 DEFUN now defines a static function. To make the function external
3389 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3390 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3391 (Finit_image_library):
16a97296
PE
3392 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3393 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3394 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3395 Remove decls, since these functions are now static.
3396 (Funintern, Fget_internal_run_time): New decls, since these functions
3397 were already external.
95c82688 3398
16a97296
PE
3399 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3400 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3401 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3402 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3403 * keyboard.c, keymap.c, lread.c:
3404 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3405 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3406 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3407 Mark functions with DEFUE instead of DEFUN,
3408 if they are used in other modules.
3409 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3410 decls for now-static functions.
3411 * buffer.h (Fdelete_overlay): Remove decl.
3412 * callproc.c (Fgetenv_internal): Mark as internal.
3413 * composite.c (Fremove_list_of_text_properties): Remove decl.
3414 (Fcomposition_get_gstring): New forward static decl.
3415 * composite.h (Fcomposite_get_gstring): Remove decl.
3416 * dired.c (Ffile_attributes): New forward static decl.
3417 * doc.c (Fdocumntation_property): New forward static decl.
3418 * eval.c (Ffetch_bytecode): New forward static decl.
3419 (Funintern): Remove extern decl; now in .h file where it belongs.
3420 * fileio.c (Fmake_symbolic_link): New forward static decl.
3421 * image.c (Finit_image_library): New forward static decl.
3422 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3423 * intervals.h (Fprevious_property_change):
3424 (Fremove_list_of_text_properties): Remove decls.
3425 * keyboard.c (Fthis_command_keys): Remove decl.
3426 (Fcommand_execute): New forward static decl.
3427 * keymap.c (Flookup_key): New forward static decl.
3428 (Fcopy_keymap): Now static.
3429 * keymap.h (Flookup_key): Remove decl.
3430 * process.c (Fget_process): New forward static decl.
3431 (Fprocess_datagram_address): Mark as internal.
3432 * syntax.c (Fsyntax_table_p): New forward static decl.
3433 (skip_chars): Remove duplicate decl.
3434 * textprop.c (Fprevious_property_change): New forward static decl.
3435 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3436 Now internal.
3437 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3438 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3439
785bbd42
PE
3440 * editfns.c (Fformat): Remove unreachable code.
3441
8b913b57
AS
34422011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3443
3444 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3445 change. (Bug#8496)
3446
a6744a35
EZ
34472011-04-13 Eli Zaretskii <eliz@gnu.org>
3448
3449 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3450 when at ZV. (Bug#8487)
3451
e7974947
AS
34522011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3453
baad03f0
AS
3454 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3455 (Bug#8437)
3456 * keyboard.c (parse_tool_bar_item): Likewise.
3457 * sound.c (sound_cleanup, alsa_close): Likewise.
3458 * termcap.c (tgetent): Likewise.
3459 * xfns.c (x_default_font_parameter): Likewise.
3460 * xsettings.c (read_and_apply_settings): Likewise.
3461
e7974947
AS
3462 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3463 (overrun_check_free): Protoize.
3464
28272684
PE
34652011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3466
3467 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3468 since callers should never pass a negative size.
3469 Change the signature to match that of plain 'read' and 'write'; see
3470 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3471 * lisp.h: Update prototypes of emacs_write and emacs_read.
3472
11997c76
EZ
34732011-04-11 Eli Zaretskii <eliz@gnu.org>
3474
3475 * xdisp.c (redisplay_window): Don't try to determine the character
3476 position of the scroll margin if the window start point w->startp
e896f03c 3477 is outside the buffer's accessible region. (Bug#8468)
11997c76 3478
8a2cbd72
EZ
34792011-04-10 Eli Zaretskii <eliz@gnu.org>
3480
3481 Fix write-region and its subroutines for buffers > 2GB.
3482 * fileio.c (a_write, e_write): Modify declaration of arguments and
3483 local variables to support buffers larger than 2GB.
3484 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3485
3486 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3487 argument, local variables, and return value.
3488
3489 * lisp.h: Update prototypes of emacs_write and emacs_read.
3490
3491 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3492
4073e537 34932011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3494
1ebfdcb6
PE
3495 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3496
b2ded58d
PE
3497 Fix more problems found by GCC 4.6.0's static checks.
3498
7d66342c
PE
3499 * xdisp.c (vmessage): Use a better test for character truncation.
3500
bbf47d44
PE
3501 * charset.c (load_charset_map): <, not <=, for optimization,
3502 and to avoid potential problems with integer overflow.
9248994d 3503 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3504 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3505 * editfns.c (Fformat): Likewise.
1e69125e 3506 * syntax.c (skip_chars): Likewise.
3befa583 3507
e3019616
PE
3508 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3509 This also lets GCC 4.6.0 generate slightly better loop code.
3510
becfa255
PE
3511 * callint.c (Fcall_interactively): <, not <=, for optimization.
3512 (Fcall_interactively): Count the number of arguments produced,
3513 not the number of arguments given. This is simpler and lets GCC
3514 4.6.0 generate slightly better code.
3515
dae0cd48
PE
3516 * ftfont.c: Distingish more carefully between FcChar8 and char.
3517 The previous code passed unsigned char * to a functions like
3518 strlen and xstrcasecmp that expect char *, which does not
3519 conform to the C standard.
3520 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3521 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3522 char * when the C standard requires it.
3523
76032d70
PE
3524 * keyboard.c (read_char): Remove unused var.
3525
eb3f1cc8
PE
3526 * eval.c: Port to Windows vsnprintf (Bug#8435).
3527 Include <limits.h>.
3528 (SIZE_MAX): Define if the headers do not.
3529 (verror): Do not give up if vsnprintf returns a negative count.
3530 Instead, grow the buffer. This ports to Windows vsnprintf, which
3531 does not conform to C99. Problem reported by Eli Zaretskii.
3532 Also, simplify the allocation scheme, by avoiding the need for
3533 calling realloc, and removing the ALLOCATED variable.
3534
70476b54
PE
3535 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3536
12020a9e
PE
3537 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3538 But keep the doprint source code for now, as we might revamp it
3539 and use it again (Bug#8435).
ea6c7ae6
PE
3540 * lisp.h (doprnt): Remove.
3541 * Makefile.in (base_obj): Remove doprnt.o.
3542 * deps.mk (doprnt.o): Remove.
3543
5fdb398c
PE
3544 error: Print 32- and 64-bit integers portably (Bug#8435).
3545 Without this change, on typical 64-bit hosts error ("...%d...", N)
3546 was used to print both 32- and 64-bit integers N, which relied on
3547 undefined behavior.
3548 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3549 New macro.
3550 * lisp.h (error, verror): Mark as printf-like functions.
3551 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3552 Report overflow in size calculations when allocating printf buffer.
3553 Do not truncate output string at its first null byte.
3554 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3555 Truncate the output at a character boundary, since vsnprintf does not
3556 do that.
3557 * charset.c (check_iso_charset_parameter): Convert internal
3558 character to string before calling 'error', since %c now has the
3559 printf meaning.
3560 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3561 overflow when computing char to be passed to 'error'. Do not
3562 pass Lisp_Object to 'error'; pass the integer instead.
3563 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3564 formatted with plain %d.
3565
b189fa66
PE
3566 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3567
bff87ef0
PE
3568 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3569
7e2cac20
PE
3570 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3571
ce4d90b5
PE
3572 * xterm.c (x_catch_errors): Remove duplicate declaration.
3573
266c9547
PE
3574 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3575
79c49ad2
PE
3576 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3577
368f4090
JM
35782011-04-10 Jim Meyering <meyering@redhat.com>
3579
3580 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3581 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3582 return ssize_t not "int", and use size_t as the buffer length.
3583 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3584 * gnutls.h: Update declarations.
3585 * process.c (read_process_output): Use ssize_t, to match.
3586 (send_process): Likewise.
3587
a32d4040
CY
35882011-04-09 Chong Yidong <cyd@stupidchicken.com>
3589
3590 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3591
8546720e 35922011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3593
04f2d78b
CB
3594 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3595 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3596
8546720e
GM
3597 * xterm.c (handle_one_xevent):
3598 * xmenu.c (create_and_show_popup_menu):
3599 * xselect.c (x_decline_selection_request)
3600 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3601
0a2f5c1a 36022011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3603
3604 Fix some uses of `int' instead of EMACS_INT.
3605 * search.c (string_match_1, fast_string_match)
3606 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3607 (scan_buffer, find_next_newline_no_quit)
3608 (find_before_next_newline, search_command, Freplace_match)
3609 (Fmatch_data): Make some `int' variables be EMACS_INT.
3610
3611 * xdisp.c (display_count_lines): 3rd argument and return value now
3612 EMACS_INT. All callers changed.
3613 (pint2hrstr): Last argument is now EMACS_INT.
3614
3615 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3616 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3617 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3618 (decode_coding_utf_16, decode_coding_emacs_mule)
3619 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3620 (decode_coding_ccl, decode_coding_charset)
3621 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3622 (decode_coding_iso_2022, decode_coding_emacs_mule)
3623 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3624 <char_offset, last_offset>: Declare EMACS_INT.
3625 (encode_coding_utf_8, encode_coding_utf_16)
3626 (encode_coding_emacs_mule, encode_invocation_designation)
3627 (encode_designation_at_bol, encode_coding_iso_2022)
3628 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3629 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3630 Declare EMACS_INT.
3631 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3632 (encode_invocation_designation): Last argument P_NCHARS is now
3633 EMACS_INT.
3634 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3635 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3636
3637 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3638 All users changed.
3639
3640 * ccl.c (Fccl_execute_on_string): Declare some variables
3641 EMACS_INT.
3642
8546720e 36432011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3644
3645 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3646
4e19a977
CS
36472011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3648
3649 * process.c (Fformat_network_address): Doc fix.
3650
87302331
R
36512011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3652
3653 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3654
cbb59342
CY
36552011-04-08 Chong Yidong <cyd@stupidchicken.com>
3656
3657 * keyboard.c (read_char): Call Lisp function help-form-show,
3658 instead of using internal_with_output_to_temp_buffer.
3659 (Qhelp_form_show): New var.
e0d38eeb 3660 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3661
3662 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3663
3664 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3665
e67a13ab
CY
36662011-04-06 Chong Yidong <cyd@stupidchicken.com>
3667
04f2d78b
CB
3668 * process.c (Flist_processes): Remove to Lisp.
3669 (list_processes_1): Delete.
e67a13ab 3670
973f782d
EZ
36712011-04-06 Eli Zaretskii <eliz@gnu.org>
3672
7c106b1e
EZ
3673 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3674
973f782d
EZ
3675 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3676
41cf7d1a 36772011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3678
ca23cc88
PE
3679 Fix more problems found by GCC 4.6.0's static checks.
3680
f390e2d5
PE
3681 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3682
42eea0d0
PE
3683 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3684
b69769da 3685 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3686
f9541e84
PE
3687 * xdisp.c (vmessage): Mark as a printf-like function.
3688
13841b55
PE
3689 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3690
c136c10f
PE
3691 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3692
5e2d4a30
PE
3693 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3694 printf-like functions.
3695 (tiff_load): Add casts to remove these marks before passing them
3696 to system-supplied API.
3697
583f48b9
PE
3698 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3699
b25d760e
PE
3700 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3701 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3702 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3703 directly, rather than having caller test rule sign. This avoids
3704 some unnecessary tests.
3705 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3706 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3707 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3708
bc7b6697 3709 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3710 (xfont_open): Avoid unnecessary tests.
bc7b6697 3711
27ccc379
PE
3712 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3713
dcd5c89a
PE
3714 * composite.h, composite.c (composition_gstring_put_cache):
3715 Use EMACS_INT, not int, for length.
3716
b13a45c6
PE
3717 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3718 breaking out part of COMPOSITION_DECODE_RULE.
3719 (COMPOSITION_DECODE_RULE): Use it.
3720 * composite.c (get_composition_id): Remove unused local vars,
3721 by using the new macro.
3722
1e792e4d
PE
3723 * textprop.c (set_text_properties_1): Change while to do-while,
3724 since the condition is always true at first.
3725
dc6c6455 3726 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3727 (interval_deletion_adjustment): Return unsigned value.
3728 All uses changed.
dc6c6455 3729
aba7731a
PE
3730 * process.c (list_processes_1, create_pty, read_process_output):
3731 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3732 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3733 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3734 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3735 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3736
fdfc4bf3
PE
3737 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3738
fca8fe46 3739 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3740 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3741
06a0259a 3742 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3743 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3744 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3745
e7b9e80f
PE
3746 * print.c (print_error_message): Avoid int overflow.
3747
56201685
PE
3748 * font.c (font_list_entities): Redo for clarity,
3749 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3750
78834453 3751 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3752 (font_score): Avoid potential overflow in diff calculation.
78834453 3753
0bc0b309 3754 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3755 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3756
e610eaca
PE
3757 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3758
b895abce
PE
3759 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3760 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3761 can always succeed if overflow has undefined behavior.
3762
1f1d9321 3763 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3764 (wordify): Omit three unnecessary tests.
1f1d9321 3765
c59478bc
PE
3766 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3767 All callers changed. This avoids the need for an unused var.
3768
79b73827
PE
3769 * casefiddle.c (casify_region): Remove var that is set but not used.
3770
a4db5dfe
PE
3771 * dired.c (file_name_completion): Remove var that is set but not used.
3772
43aae36e
PE
3773 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3774
2a47c44d 3775 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3776 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3777
a37c69bf
PE
3778 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3779 Check for integer overflow on size calculations.
3780
328ab8e7
PE
3781 * buffer.c (Fprevious_overlay_change): Remove var that is set
3782 but not used.
3783
e5a2a5cb
PE
3784 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3785 Remove vars that are set but not used.
8d84a6eb 3786 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3787 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3788
a60e5f68
PE
3789 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3790
f661cb61 3791 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3792 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3793
f0397f5a
PE
3794 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3795 that are set but not used.
3796
8664db06 3797 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3798 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3799
6abdaa4a
PE
3800 * xselect.c (x_get_local_selection, x_handle_property_notify):
3801 Remove vars that are set but not used.
3802
0ce7538d 3803 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3804 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3805
9ae848fc
PE
3806 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3807 Remove var that is set but not used.
0b918413
PE
3808 (scroll_bar_windows_size): Now size_t, not int.
3809 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3810 Check for overflow.
9ae848fc 3811
a5a62657
PE
3812 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3813 (map_tty_color) [!defined MSDOS]: Likewise.
3814
5c5cdd39
PE
3815 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3816
66ebf983
PE
3817 * coding.c: Remove vars that are set but not used.
3818 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3819 All callers changed.
3820 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3821 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3822 (decode_coding_charset): Remove vars that are set but not used.
3823
1be4d761
PE
3824 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3825 that is set but not used.
3826
47553fa8
PE
3827 * print.c (print_object): Remove var that is set but not used.
3828
1f7196bf 3829 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3830 The gnulib version avoids calling malloc in the usual case,
3831 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3832 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3833 * filelock.c (current_lock_owner): Likewise.
3834 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3835 * sysdep.c: Include allocator.h, careadlinkat.h.
3836 (emacs_no_realloc_allocator): New static constant.
3837 (emacs_readlink): New function.
fdb61804
PE
3838 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3839 ../lib/careadlinkat.h.
d1fdcab7 3840
f84c17c7
SM
38412011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3842
3843 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3844 first non-nil return value).
3845
ef3862ad
JD
38462011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3847
3848 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3849 if not defined (Bug#8403).
3850
376a7006
JB
38512011-04-02 Juanma Barranquero <lekktu@gmail.com>
3852
3853 * xdisp.c (display_count_lines): Remove parameter `start',
3854 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3855 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3856 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3857 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3858 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3859 and thereabouts. All callers changed.
3860 (get_per_char_metric): Remove parameter `f', unused since
3861 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3862
6ca3801d
JM
38632011-04-02 Jim Meyering <meyering@redhat.com>
3864
3865 do not dereference NULL upon failed strdup
3866 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3867 (ns_get_family): Likewise.
3868
d8e2b5ba
JB
38692011-04-02 Juanma Barranquero <lekktu@gmail.com>
3870
3871 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3872
8c74fcbd
JD
38732011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3874
3875 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3876 later (Bug#8403).
3877
7200d79c
SM
38782011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3879
03408648 3880 Add lexical binding.
7200d79c 3881
03408648
SM
3882 * window.c (Ftemp_output_buffer_show): New fun.
3883 (Fsave_window_excursion):
3884 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3885
3886 * lread.c (lisp_file_lexically_bound_p): New function.
3887 (Fload): Bind Qlexical_binding.
3888 (readevalloop): Remove `evalfun' arg.
3889 Bind Qinternal_interpreter_environment.
3890 (Feval_buffer): Bind Qlexical_binding.
3891 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3892 Mark as dynamic.
3893 (syms_of_lread): Declare `lexical-binding'.
3894
3895 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3896
3897 * keyboard.c (eval_dyn): New fun.
3898 (menu_item_eval_property): Use it.
ca105506
SM
3899
3900 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3901
03408648
SM
3902 * fns.c (concat, mapcar1): Accept byte-code-functions.
3903
3904 * eval.c (Fsetq): Handle lexical vars.
3905 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3906 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3907 (FletX, Flet): Obey lexical binding.
3908 (Fcommandp): Handle closures.
3909 (Feval): New `lexical' arg.
3910 (eval_sub): New function extracted from Feval. Use it almost
3911 everywhere where Feval was used. Look up vars in lexical env.
3912 Handle closures.
3913 (Ffunctionp): Move from subr.el.
3914 (Ffuncall): Handle closures.
3915 (apply_lambda): Remove `eval_flags'.
3916 (funcall_lambda): Handle closures and new byte-code-functions.
3917 (Fspecial_variable_p): New function.
3918 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3919 but without exporting it to Lisp.
23aba0ea 3920
23aba0ea 3921 * doc.c (Fdocumentation, store_function_docstring):
03408648 3922 * data.c (Finteractive_form): Handle closures.
23aba0ea 3923
03408648
SM
3924 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3925 interactive spec.
ba83908c 3926
04f2d78b
CB
3927 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3928 New byte-codes.
03408648
SM
3929 (exec_byte_code): New function extracted from Fbyte_code to handle new
3930 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3931
03408648 3932 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3933
03408648 3934 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3935
e2abce01
JB
39362011-03-31 Juanma Barranquero <lekktu@gmail.com>
3937
3938 * xdisp.c (redisplay_internal): Fix prototype.
3939
63696a73 39402011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3941
63696a73 3942 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3943 (try_scrolling): Use it when setting scroll_limit.
3944 Limit scrolling to 100 screen lines.
63696a73
EZ
3945 (redisplay_window): Even when falling back on "recentering",
3946 position point in the window according to scroll-conservatively,
3947 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3948
3949 (try_scrolling): When point is above the window, allow searching
3950 as far as scroll_max, or one screenful, to compute vertical
3951 distance from PT to the scroll margin position. This prevents
3952 try_scrolling from unnecessarily failing when
3953 scroll-conservatively is set to a value slightly larger than the
3954 window height. Clean up the case of PT below the margin at bottom
3955 of window: scroll_max can no longer be INT_MAX. When aggressive
3956 scrolling is in use, don't let point enter the opposite scroll
3957 margin as result of the scroll.
3958 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3959 threshold of 100 lines for never-recentering scrolling.
3960
e4cc2dfc
JB
39612011-03-31 Juanma Barranquero <lekktu@gmail.com>
3962
3963 * dispextern.h (move_it_by_lines):
3964 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3965 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3966 (message_log_check_duplicate): Remove parameters `prev_bol' and
3967 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3968 (redisplay_internal): Remove parameter `preserve_echo_area',
3969 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3970
3971 * indent.c (Fvertical_motion):
3972 * window.c (window_scroll_pixel_based, Frecenter):
3973 Don't pass `need_y_p' to `move_it_by_lines'.
3974
1c470562
SM
39752011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3976
44f230aa
SM
3977 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3978 steal a few bits to be more compact.
3979 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3980 Remove unneeded casts.
3981
1c470562
SM
3982 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3983
888adce9
ZK
39842011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3985
3986 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3987 binding" message (bug#7967).
3988
f838ed7b
PE
39892011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3990
77861b95
PE
3991 Fix more problems found by GCC 4.6.0's static checks.
3992
de6dbc14
PE
3993 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3994 Remove unused local var.
3995
f838ed7b
PE
3996 * editfns.c (Fmessage_box): Remove unused local var.
3997
792c7b2b
PE
3998 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3999 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4000 Omit unused local vars.
c499e557 4001 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4002 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4003 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4004 Omit unused local var.
4005
ba0165e1
PE
4006 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4007 Don't assume string length fits in int.
32ad8845 4008 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4009 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4010
3c59b4c9
PE
4011 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4012 instead of alloca (Bug#8344).
4013
a3eed478 4014 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4015 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4016
eb4d412d
PE
4017 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4018
1658b401
PE
4019 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4020 concerns.
4021
4022 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4023
4024 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4025
9a2c6e05
PE
4026 * keyboard.c (syms_of_keyboard): Use the same style as later
4027 in this function when indexing through an array. This also
4028 works around GCC bug 48267.
4029
03d0a109
PE
4030 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4031
44f730c8
PE
4032 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4033
fe75f926
PE
4034 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4035 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4036
ffa8c828
PE
4037 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4038 This avoids undefined behavior on integer overflow, and is a bit
4039 more convenient anyway since it is compared to a size_t variable.
4040
c5101a77
PE
4041 Variadic C functions now count arguments with size_t, not int.
4042 This avoids an unnecessary limitation on 64-bit machines, which
4043 caused (substring ...) to crash on large vectors (Bug#8344).
4044 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4045 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4046 All variadic functions and their callers changed accordingly.
c5101a77
PE
4047 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4048 * data.c (arith_driver, float_arith_driver): Likewise.
4049 * editfns.c (general_insert_function): Likewise.
4050 * eval.c (struct backtrace.nargs, interactive_p)
4051 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4052 (funcall_lambda, mark_backtrace): Likewise.
4053 * fns.c (concat): Likewise.
4054 * frame.c (x_set_frame_parameters): Likewise.
4055 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4056 0 if not found, not -1. All callers changed.
4057
dd3f25f7
PE
4058 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4059 (stack_copy_size): Now size_t, not int.
4060 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4061
461c2ab9
JB
40622011-03-28 Juanma Barranquero <lekktu@gmail.com>
4063
4064 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4065 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4066 All callers changed.
4067
4068 * lisp.h (multibyte_char_to_unibyte):
4069 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4070 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4071 * character.h (CHAR_TO_BYTE8):
4072 * cmds.c (internal_self_insert):
4073 * editfns.c (general_insert_function):
4074 * keymap.c (push_key_description):
4075 * search.c (Freplace_match):
4076 * xdisp.c (message_dolog, set_message_1): All callers changed.
4077
f6d62986
SM
40782011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4079
4080 * keyboard.c (safe_run_hook_funcall): New function.
4081 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4082 don't set the hook to nil, but remove the offending function instead.
4083 (Qcommand_hook_internal): Remove, unused.
4084 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4085 Vcommand_hook_internal.
4086
4087 * eval.c (enum run_hooks_condition): Remove.
4088 (funcall_nil, funcall_not): New functions.
4089 (run_hook_with_args): Call each function through a `funcall' argument.
4090 Remove `cond' argument, now redundant.
4091 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4092 (Frun_hook_with_args_until_failure): Adjust accordingly.
4093 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4094
1db5b1ad
JB
40952011-03-28 Juanma Barranquero <lekktu@gmail.com>
4096
4097 * dispextern.h (string_buffer_position): Remove declaration.
4098
4099 * print.c (strout): Remove parameter `multibyte', unused since
4100 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4101
4102 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4103 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4104 All callers changed.
4105
4106 * w32.c (_wsa_errlist): Use braces for struct initializers.
4107
4108 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4109 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4110 All callers changed.
4111 (string_buffer_position): Likewise. Also, make static (it's never
4112 used outside xdisp.c).
4113 (cursor_row_p): Remove parameter `w', unused since
4114 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4115 (decode_mode_spec): Remove parameter `precision', introduced during
4116 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4117 All callers changed.
4118
5ffb62aa
JD
41192011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4120
4121 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4122
461c2ab9 41232011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4124
4125 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4126 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4127 (ns_update_auto_hide_menu_bar): New functions.
4128 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4129 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4130 ns_constrain_all_frames.
4131 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4132 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4133
5c380ffb
JD
41342011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4135
4136 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4137
9af30bdf
GM
41382011-03-27 Glenn Morris <rgm@gnu.org>
4139
4140 * syssignal.h: Replace RETSIGTYPE with void.
4141 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4142 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4143 Replace SIGTYPE with void everywhere.
4144 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4145 * s/template.h (SIGTYPE): Remove commented out definition.
4146
e2abce01
JB
41472011-03-26 Eli Zaretskii <eliz@gnu.org>
4148
4149 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4150 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4151
f868cd8a
JB
41522011-03-26 Juanma Barranquero <lekktu@gmail.com>
4153
59eb0929
JB
4154 * w32.c (read_unc_volume): Use parameter `henum', instead of
4155 global variable `wget_enum_handle'.
4156
4157 * keymap.c (describe_vector): Remove parameters `indices' and
4158 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4159 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4160
f868cd8a
JB
4161 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4162
4163 * keyboard.c (timer_check): Remove parameter `do_it_now',
4164 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4165 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4166 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4167
4168 * keyboard.c (read_char):
4169 * w32menu.c (w32_menu_display_help):
4170 * xmenu.c (show_help_event, menu_help_callback):
4171 Adjust calls to `show_help_echo'.
4172
4173 * gtkutil.c (xg_maybe_add_timer):
4174 * keyboard.c (readable_events):
4175 * process.c (wait_reading_process_output):
4176 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4177
4178 * insdel.c (adjust_markers_gap_motion):
4179 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4180 (gap_left, gap_right): Don't call it.
4181
2ecf6fdb
CY
41822011-03-25 Chong Yidong <cyd@stupidchicken.com>
4183
4184 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4185 incurred during fontification.
4186
6b1f9ba4
JB
41872011-03-25 Juanma Barranquero <lekktu@gmail.com>
4188
4189 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4190 (DEFVAR_PER_BUFFER): Don't pass it.
4191
4192 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4193 (scrolling_window): Don't pass it.
4194
0f4a96b5
JB
41952011-03-25 Juanma Barranquero <lekktu@gmail.com>
4196
4197 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4198
4199 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4200 and `suffix'.
4201 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4202 of variables specific to SELinux and computation of `encoded_absname'.
4203
4204 * image.c (XPutPixel): Remove unused variable `height'.
4205
4206 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4207
4208 * unexw32.c (get_section_info): Remove unused variable `section'.
4209
4210 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4211 (system_process_attributes): Remove unused variable `sess'.
4212 (sys_read): Remove unused variable `err'.
4213
4214 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4215 (w32_wnd_proc): Remove unused variable `isdead'.
4216 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4217 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4218 (x_create_tip_frame): Remove unused variable `tem'.
4219
4220 * w32inevt.c (w32_console_read_socket):
4221 Remove unused variable `no_events'.
4222
4223 * w32term.c (x_draw_composite_glyph_string_foreground):
4224 Remove unused variable `width'.
4225
1149507c
JB
42262011-03-24 Juanma Barranquero <lekktu@gmail.com>
4227
4228 * w32term.c (x_set_glyph_string_clipping):
4229 Don't pass uninitialized region to CombineRgn.
4230
9c88f339
JB
42312011-03-23 Juanma Barranquero <lekktu@gmail.com>
4232
4233 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4234 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4235 (Fx_close_connection): Remove unused variable `i'.
4236
4237 * w32font.c (w32font_draw): Return number of glyphs.
4238 (w32font_open_internal): Remove unused variable `i'.
4239 (w32font_driver): Add missing initializer.
4240
4241 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4242 (fill_in_menu): Remove unused variable `items_added'.
4243
4244 * w32term.c (last_mouse_press_frame): Remove static global variable.
4245 (w32_clip_to_row): Remove unused variable `f'.
4246 (x_delete_terminal): Remove unused variable `i'.
4247
4248 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4249 (NOTHING): Remove unused static global variable.
4250 (uniscribe_check_otf): Remove unused variable `table'.
4251 (uniscribe_font_driver): Add missing initializers.
4252
dee091a3
JD
42532011-03-23 Julien Danjou <julien@danjou.info>
4254
4255 * term.c (Fsuspend_tty, Fresume_tty):
4256 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4257 * window.c (temp_output_buffer_show):
4258 * insdel.c (signal_before_change):
4259 * frame.c (Fhandle_switch_frame):
4260 * fileio.c (Fdo_auto_save):
4261 * emacs.c (Fkill_emacs):
4262 * editfns.c (save_excursion_restore):
4263 * cmds.c (internal_self_insert):
4264 * callint.c (Fcall_interactively):
4265 * buffer.c (Fkill_all_local_variables):
4266 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4267 Use Frun_hooks.
0f4a96b5 4268 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4269 unconditionnaly since it does the check itself.
4270
2c520ab5 42712011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4272
c9c49752
PE
4273 Fix more problems found by GCC 4.5.2's static checks.
4274
8abc3f12
PE
4275 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4276 the first time through the loop, since we know p0 < p1 then.
4277 This also avoids a gcc -Wstrict-overflow warning.
4278
a2d26660
PE
4279 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4280 leading to a memory leak, possible in functions like
4281 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4282 of objects (Bug#8318).
a2d26660 4283
916c72e9
PE
4284 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4285 that could (at least in theory) be that large.
4286
19ab8a18
PE
4287 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4288 This is less likely to overflow, and avoids undefined behavior if
4289 overflow does occur. All callers changed. Use strtoul to scan
4290 for the unsigned long integer.
b7cbbd6f
PE
4291 (pint2hrstr): Simplify and tune code slightly.
4292 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4293
f0641eff
PE
4294 * scroll.c (do_scrolling): Work around GCC bug 48228.
4295 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4296
7f650bb9
PE
4297 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4298 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4299 (validate_x_resource_name): Simplify count usage.
4300 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4301
37dd57d1
PE
4302 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4303 fail (Bug#8306).
81e56e61 4304
699979fc 4305 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4306
401bf9b4
PE
4307 * process.c (Fmake_network_process): Use socklen_t, not int,
4308 where POSIX says socklen_t is required in portable programs.
4309 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4310 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4311 (Fmake_network_process, server_accept_connection):
4312 (wait_reading_process_output, read_process_output):
4313 Likewise.
4314
b93aacde
PE
4315 * process.c: Rename or move locals to avoid shadowing.
4316 (list_processes_1, Fmake_network_process):
4317 (read_process_output_error_handler, exec_sentinel_error_handler):
4318 Rename or move locals.
4dc343ee 4319 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4320 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4321 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4322 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4323 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4324
af8a867c 4325 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4326 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4327 Include tparam.h instead, since it declares them.
af8a867c
PE
4328 * cm.h (PC): Remove extern decl; tparam.h now does this.
4329 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4330 * terminfo.c: Include tparam.h, to check interfaces.
4331 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4332 (tparam): Adjust signature to match interface in tparam.h;
4333 this removes some undefined behavior. Check that outstring and len
4334 are zero, which they always are with Emacs.
4335 * tparam.h (PC, BC, UP): New extern decls.
4336
0248044d 4337 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4338 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4339
8ff096c1 4340 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4341 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4342 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4343 (ftfont_list): Remove unused local.
49eaafba
PE
4344 (get_adstyle_property, ftfont_pattern_entity):
4345 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4346 Rename locals to avoid shadowing.
8ff096c1 4347
e2be39f6
PE
4348 * xfont.c (xfont_list_family): Mark var as initialized.
4349
c9735e30
PE
4350 * xml.c (make_dom): Now static.
4351
8f5201ae
PE
4352 * composite.c (composition_compute_stop_pos): Rename local to
4353 avoid shadowing.
b246f932
PE
4354 (composition_reseat_it): Remove unused locals.
4355 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4356 (composition_update_it): Mark var as initialized.
11b61122
PE
4357 (find_automatic_composition): Mark vars as initialized,
4358 with a FIXME (Bug#8290).
8f5201ae 4359
760fbc2c
PE
4360 character.h: Rename locals to avoid shadowing.
4361 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4362 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4363 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4364 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4365 to avoid shadowing.
4366
ff08eb85
PE
4367 * textprop.c (property_change_between_p): Remove; unused.
4368
fc7bf025
PE
4369 * intervals.c (interval_start_pos): Now static.
4370
235d7abc
PE
4371 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4372
44f230aa
SM
4373 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4374 Rename locals to avoid shadowing.
3e7d6594 4375
50060332
PE
4376 * sound.c (wav_play, au_play, Fplay_sound_internal):
4377 Fix pointer signedness.
d01f234b 4378 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4379 (wav_play): Initialize a variable to 0, to prevent undefined
4380 behavior (Bug#8278).
50060332 4381
c4fc4e30
PE
4382 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4383
918436ed
PE
4384 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4385
c939f91b
PE
4386 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4387 clobbering (Bug#8298).
b9c7f648
PE
4388 * sysdep.c (sys_subshell): Likewise.
4389 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4390
6bd8c144
PE
4391 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4392 This should get cleaned up, so that child_setup has the
4393 same signature on all platforms.
4394
7710357c 4395 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4396 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4397
c59da222
CY
43982011-03-22 Chong Yidong <cyd@stupidchicken.com>
4399
4400 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4401 not to be necessary, and produces flickering.
4402
66b87493
GM
44032011-03-20 Glenn Morris <rgm@gnu.org>
4404
4405 * config.in: Remove file.
4406
45b6f6d5
JB
44072011-03-20 Juanma Barranquero <lekktu@gmail.com>
4408
4409 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4410 are now in src/globals.h.
4411 (syms_of_minibuf): Remove spurious & from previous change.
4412
3ec03f7e
LL
44132011-03-20 Leo <sdl.web@gmail.com>
4414
4415 * minibuf.c (completing-read-function): New variable.
4416 (completing-read-default): Rename from completing-read.
4417 (completing-read): Call completing-read-function.
4418
b14e3e21
CY
44192011-03-19 Juanma Barranquero <lekktu@gmail.com>
4420
4421 * xfaces.c (Fx_load_color_file):
4422 Read color file from absolute filename (bug#8250).
4423
f2b726e6
JB
44242011-03-19 Juanma Barranquero <lekktu@gmail.com>
4425
4426 * makefile.w32-in: Update dependencies.
4427
09f6ff02
EZ
44282011-03-17 Eli Zaretskii <eliz@gnu.org>
4429
4430 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4431
29a6015a
PE
44322011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4433
a3a6c54e
PE
4434 Fix more problems found by GCC 4.5.2's static checks.
4435
b766f867
PE
4436 * process.c (make_serial_process_unwind, send_process_trap):
4437 (sigchld_handler): Now static.
4438
be02381c
PE
4439 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4440 That way, the code declares only the vars that it needs.
4441 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4442 * s/cygwin.h (PTY_ITERATION): Likewise.
4443 * s/darwin.h (PTY_ITERATION): Likewise.
4444 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4445
57048744
PE
4446 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4447 * process.c (allocate_pty): Don't declare stb unless it's needed.
4448
7914961c 4449 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4450 (CONSTANTLIM): Remove; unused.
4451 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4452 Define only if needed.
7914961c 4453
b3967b18
PE
4454 * unexelf.c (unexec): Name an expression,
4455 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4456 Use a different way to cause a compilation error if anyone uses
4457 n rather than nn, a way that does not involve shadowing.
73366a00 4458 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4459
29a6015a
PE
4460 * deps.mk (unexalpha.o): Remove; unused.
4461
43cfc33e 4462 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4463 * unexec.h: New file.
ce701a33
PE
4464 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4465 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4466 Depend on unexec.h.
4467 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4468 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4469 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4470 Change as necessary to match prototype in unexec.h.
ce701a33 4471
01f44d5a
PE
4472 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4473 shadowing.
4f63c6bb 4474 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4475
a6670b0b
PE
4476 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4477 Rename locals to avoid shadowing.
4478
cef2010d 4479 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4480 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4481
d4d7173a
PE
4482 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4483
f08b802a
PE
4484 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4485 warning when compiling print.c.
4486
3ddb0639
PE
4487 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4488 instead of using an uninitialized var.
5ad03b97 4489 (font_sort_entities): Mark var as initialized.
3ddb0639 4490
170a2692
PE
4491 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4492
e663c700
PE
4493 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4494 pointers to constants.
89bc529a 4495 (font_parse_fcname): Remove unused vars.
7b81e2d0 4496 (font_delete_unmatched): Now static.
ea838e10 4497 (font_get_spec): Remove; unused.
13a547c6
PE
4498 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4499 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4500 Rename or move locals to avoid shadowing.
e663c700 4501
2a80c887 4502 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4503 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4504
1384fa33 4505 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4506 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4507
8b2c52e9
PE
4508 * alloc.c (mark_backtrace): Move decl from here ...
4509 * lisp.h: ... to here, so that it can be checked.
4510
475545b5 4511 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4512 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4513 (lisp_indirect_variable): Name an expression,
4514 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4515 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4516
b1349114 4517 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4518 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4519 Use const pointer when appropriate.
b1349114 4520
a2928364
PE
4521 * lisp.h (get_system_name, get_operating_system_release):
4522 Move decls here, to check interfaces.
4523 * process.c (get_operating_system_release): Move decl to lisp.h.
4524 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4525 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4526 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4527 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4528 (Fformat_time_string, Fencode_time, Finsert_char):
4529 (Ftranslate_region_internal, Fformat):
4530 Rename or remove local vars to avoid shadowing.
9710023e 4531 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4532
a415e694
PE
4533 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4534 avoid shadowing.
4535
8ef4622d
PE
4536 * lisp.h (eassert): Check that the argument compiles, even if
4537 ENABLE_CHECKING is not defined.
4538
946f9a5b
PE
4539 * data.c (Findirect_variable): Name an expression, to avoid
4540 gcc -Wbad-function-cast warning.
112396d6 4541 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4542 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4543 (Fmake_variable_buffer_local, Fmake_local_variable):
4544 Mark variables as initialized.
52746918 4545 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4546
e5aab7e7 4547 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4548 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4549 Rename locals to avoid shadowing.
dff45157
PE
4550 (mark_stack): Move local variables into the #ifdef region where
4551 they're used.
7bc26fdb
PE
4552 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4553 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4554 needed otherwise.
4555 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4556 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4557 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4558
e5aab7e7
PE
4559 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4560 avoids undefined behavior in theory.
4561
4da60324
PE
4562 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4563
88043301
PE
4564 Use functions, not macros, for up- and down-casing (Bug#8254).
4565 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4566 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4567 to use the following functions instead of these macros.
4568 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4569 EMACS_INT, since callers assume the returned value fits in int.
4570 (upcase1): Likewise, for UPCASE_TABLE.
4571 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4572 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4573 the race-condition problem in the old DOWNCASE.
88043301 4574
19ed5445
PE
4575 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4576 Rename locals to avoid shadowing.
4577 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4578 (regex_compile, re_search_2, re_match_2_internal):
4579 Remove unused local vars.
952db0d7
PE
4580 (FREE_VAR): Rewrite so as not to use empty "else",
4581 which gcc can warn about.
da053e48 4582 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4583 (RETALLOC_IF): Define only if needed.
4584 (WORDCHAR_P): Likewise. This one is never needed, but is used
4585 only in a comment talking about a compiler bug, so put inside
4586 the #if 0 of that comment.
4587 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4588 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4589 Remove; unused.
19ed5445 4590
1f3561e4 4591 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4592 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4593 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4594
ded6f8f7
PE
4595 * search.c (simple_search): Remove unused var.
4596
dbd37a95
PE
4597 * dired.c (compile_pattern): Move decl from here ...
4598 * lisp.h: ... to here, so that it can be checked.
4599 (struct re_registers): New forward decl.
4600
7e47afad
PE
4601 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4602
85f24f61
PE
4603 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4604 All uses changed.
4605 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4606 Rename locals to avoid shadowing.
5671df8f 4607 (Fvertical_motion): Mark locals as initialized.
85f24f61 4608
181aa2be 4609 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4610 (casify_region): Mark local as initialized.
181aa2be 4611
930d429c
PE
4612 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4613
7082eac6
PE
4614 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4615 New macros, so that the caller can use some names other than
4616 gcpro1, gcpro2, etc.
4617 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4618 of the new macros.
4619 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4620 argument, for consistency with GCPRO2_VAR, etc: it is now the
4621 prefix of the variable, not the variable itself. All uses
4622 changed.
38b2c076
PE
4623 * dired.c (directory_files_internal, file_name_completion):
4624 Rename locals to avoid shadowing.
4625
15206ed9
PE
4626 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4627 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4628 dired.c's scmp function, had undefined behavior.
4629 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4630 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4631 * buffer.h: ... to here, because these macros use current_buffer,
4632 and the new implementation with inline functions needs to have
4633 current_buffer in scope now, rather than later when the macros
4634 are used.
4635 (downcase, upcase1): New static inline functions.
4636 (DOWNCASE, UPCASE1): Reimplement using these functions.
4637 This avoids undefined behavior in expressions like
4638 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4639 from race conditions in accessing the global variables
4640 case_temp1 and case_temp2.
4641 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4642 * lisp.h (case_temp1, case_temp2): Remove their decls.
4643 * character.h (ASCII_CHAR_P): Move from here ...
4644 * lisp.h: ... to here, so that the inline functions mentioned
4645 above can use them.
4646
4a6bea26
PE
4647 * dired.c (directory_files_internal_unwind): Now static.
4648
f14b7e14
PE
4649 * fileio.c (file_name_as_directory, directory_file_name):
4650 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4651 Now static.
2893f146
PE
4652 (file_name_as_directory): Use const pointers when appropriate.
4653 (Fexpand_file_name): Likewise. In particular, newdir might
4654 point at constant storage, so make it a const pointer.
fd4ead52 4655 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4656 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4657 signedness issues.
f839df0c
PE
4658 (Fset_file_times, Finsert_file_contents, auto_save_error):
4659 Rename locals to avoid shadowing.
f14b7e14 4660
5716756e 4661 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4662 (Ftry_completion, Fall_completions): Rename or remove locals
4663 to avoid shadowing.
5716756e 4664
b4c3046a
PE
4665 * marker.c (bytepos_to_charpos): Remove; unused.
4666
b45db522
PE
4667 * lisp.h (verify_bytepos, count_markers): New decls,
4668 so that gcc does not warn that these functions aren't declared.
4669
85876d07
PE
4670 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4671 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4672 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4673 (copy_text): Remove unused local var.
85876d07 4674
03d78a21 4675 * filelock.c (within_one_second): Now static.
b3dd38ab 4676 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4677
5df8f01b
PE
4678 * buffer.c (fix_overlays_before): Mark locals as initialized.
4679 (fix_start_end_in_overlays): Likewise. This function should be
4680 simplified by using pointers-to-pointers, but that's a different
4681 matter.
b1d876f1 4682 (switch_to_buffer_1): Now static.
8f54f30a
PE
4683 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4684 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4685
a70072c9 4686 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4687 Fix pointer signedness issue.
edced198
PE
4688 (sys_subshell): Mark local as volatile if checking for lint,
4689 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4690 (MAXPATHLEN): Define only if needed.
a70072c9 4691
a0977c44
PE
4692 * process.c (serial_open, serial_configure): Move decls from here ...
4693 * systty.h: ... to here, so that they can be checked.
4694
a884fdcc
PE
4695 * fns.c (get_random, seed_random): Move extern decls from here ...
4696 * lisp.h: ... to here, so that they can be checked.
4697
604efe86 4698 * sysdep.c (reset_io): Now static.
b8950c94 4699 (wait_for_termination_signal): Remove; unused.
604efe86 4700
38fc62d9
PE
4701 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4702 (copy_keymap_item, append_key, push_text_char_description):
4703 Now static.
1004a21a 4704 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4705 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4706 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4707 (describe_map_tree):
4708 Rename locals to avoid shadowing.
38fc62d9 4709
2f2650da
PE
4710 * keyboard.c: Declare functions static if they are not used elsewhere.
4711 (echo_char, echo_dash, cmd_error, top_level_2):
4712 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4713 (read_char, kbd_buffer_get_event, make_lispy_position):
4714 (make_lispy_event, make_lispy_movement, apply_modifiers):
4715 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4716 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4717 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4718 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4719 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4720
a053e86c 4721 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4722 (mark_kboards): Move decl here ...
4723 * alloc.c (mark_kboards): ... from here.
a053e86c 4724
4752793e
PE
4725 * lisp.h (force_auto_save_soon): New decl.
4726
74f10ca7 4727 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4728 (DEFINE_DUMMY_FUNCTION): New macro.
4729 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4730 Use it.
c03cd23f
PE
4731 (main): Add casts to avoid warnings
4732 if GCC considers string literals to be constants.
74f10ca7 4733
022e70d4
PE
4734 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4735
59d6fe83
PE
4736 * dbusbind.c: Pointer signedness fixes.
4737 (xd_signature, xd_append_arg, xd_initialize):
4738 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4739 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4740 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4741 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4742
78320123
PE
4743 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4744 if GCC considers string literals to be constants.
49cebcca 4745 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4746
35ac2a97
SM
47472011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4748
fb103ca9
SM
4749 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4750 (print_preprocess, print_object): New macro to fix last change.
4751
35ac2a97
SM
4752 * print.c (print_preprocess): Don't forget font objects.
4753
62973b41
JB
47542011-03-16 Juanma Barranquero <lekktu@gmail.com>
4755
4756 * emacs.c (USAGE3): Doc fixes.
4757
0e48bb22
AS
47582011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4759
4760 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4761 structure.
4762
7684e57b
JB
47632011-03-14 Juanma Barranquero <lekktu@gmail.com>
4764
4765 * lisp.h (VWindow_system, Qfile_name_history):
4766 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4767 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4768 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4769
4770 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4771 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4772
4773 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4774 * w32console.c (detect_input_pending, read_input_pending)
4775 (encode_terminal_code):
4776 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4777 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4778 (w32_system_caret_y, Qfile_name_history):
4779 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4780 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4781 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4782 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4783 * w32proc.c (Qlocal, report_file_error):
4784 * w32term.c (Vwindow_system, updating_frame):
4785 * w32uniscribe.c (initialized, uniscribe_font_driver):
4786 Remove unneeded extern declarations.
4787
2aa46d6c
CY
47882011-03-14 Chong Yidong <cyd@stupidchicken.com>
4789
c96bbc66 4790 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4791
cffc6f3b
CY
47922011-03-13 Chong Yidong <cyd@stupidchicken.com>
4793
4794 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4795 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4796 These macros can no longer be used for assignment.
4797
44f230aa
SM
4798 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4799 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4800 (record_buffer_markers, fetch_buffer_markers): New functions for
4801 recording and fetching special buffer markers.
4802 (set_buffer_internal_1, set_buffer_temp): Use them.
4803
4804 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4805
4806 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4807
4808 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4809 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4810
4811 * xdisp.c (hscroll_window_tree):
4812 (reconsider_clip_changes): Use PT instead of BUF_PT.
4813
d251f04b
EZ
48142011-03-13 Eli Zaretskii <eliz@gnu.org>
4815
4816 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4817 $(EMACS_ROOT)/lib/intprops.h.
4818
f0c77cd1
PE
48192011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4820
3eca4629
PE
4821 Fix more problems found by GCC 4.5.2's static checks.
4822
7c86ee98
PE
4823 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4824 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4825 (xg_free_frame_widgets): Make it clear that a local variable is
4826 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4827 (gdk_window_get_screen): Make it clear that this macro is needed
4828 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4829 (int_gtk_range_get_value): New function, which avoids a diagnostic
4830 from gcc -Wbad-function-cast.
4831 (xg_set_toolkit_scroll_bar_thumb): Use it.
4832 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4833 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4834 (get_utf8_string, xg_get_file_with_chooser):
4835 Rename locals to avoid shadowing.
4836 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4837
41729b81
PE
4838 * xgselect.c (xg_select): Remove unused var.
4839
f0c77cd1
PE
4840 * image.c (four_corners_best): Mark locals as initialized.
4841 (gif_load): Initialize transparent_p to zero (Bug#8238).
4842 Mark another local as initialized.
ec6cf4c6 4843 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4844
ce0ad53d 4845 * image.c (clear_image_cache): Now static.
d5d5a617 4846 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4847 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4848 (x_edge_detection): Remove unnecessary cast that
4849 gcc -Wbad-function-cast diagnoses.
2037898d 4850 (gif_load): Fix pointer signedness.
6ae141d6
PE
4851 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4852 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4853
33383987 48542011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4855
d32df629
PE
4856 Improve quality of tests for time stamp overflow.
4857 For example, without this patch (encode-time 0 0 0 1 1
4858 1152921504606846976) returns the obviously-bogus value (-948597
4859 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4860 reports time overflow. See
4861 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4862 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4863 * editfns.c: Include limits.h and intprops.h.
4864 (TIME_T_MIN, TIME_T_MAX): New macros.
4865 (time_overflow): Move earlier, to before first use.
4866 (hi_time, lo_time): New functions, for an accurate test for
4867 out-of-range times.
4868 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4869 (Fget_internal_run_time): Don't assume time_t fits in int.
4870 (make_time): Use list2 instead of Fcons twice.
4871 (Fdecode_time): More accurate test for out-of-range times.
4872 (check_tm_member): New function.
4873 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4874 (lisp_time_argument): Don't rely on undefined left-shift and
4875 right-shift behavior when checking for time stamp overflow.
8be6f318 4876
fe31d94c
PE
4877 * editfns.c (time_overflow): New function, refactoring common code.
4878 (Fformat_time_string, Fdecode_time, Fencode_time):
4879 (Fcurrent_time_string): Use it.
4880
8be6f318
PE
4881 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4882 * dired.c (make_time): Move to ...
4883 * editfns.c (make_time): ... here.
4884 * systime.h: Note the move.
4885
09d9db2c 48862011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4887
126bc0dc
YM
4888 * fringe.c (update_window_fringes): Remove unused variables.
4889
c47cbdfd
YM
4890 * unexmacosx.c (copy_data_segment): Also copy __got section.
4891 (Bug#8223)
4892
7ac80be9
EZ
48932011-03-12 Eli Zaretskii <eliz@gnu.org>
4894
c96bbc66 4895 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4896 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4897 Constify `char *' arguments and their references according to
4898 prototypes in tparam.h.
4899
ecb0f94d 4900 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4901
7ac80be9
EZ
4902 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4903 Adapt all references accordingly.
4904
4905 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4906
ef1fd07e
TT
49072011-03-11 Tom Tromey <tromey@redhat.com>
4908
4909 * buffer.c (syms_of_buffer): Remove obsolete comment.
4910
7ef4b50c
EZ
49112011-03-11 Eli Zaretskii <eliz@gnu.org>
4912
4913 * termhooks.h (encode_terminal_code): Declare prototype.
4914
4915 * msdos.c (encode_terminal_code): Don't declare prototype.
4916
4917 * term.c (encode_terminal_code): Now external again, used by
4918 w32console.c and msdos.c.
4919
44f230aa
SM
4920 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4921 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4922
4b1ec863 49232011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4924
1714f52b 4925 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4926
4b1ec863
PE
4927 * fringe.c (update_window_fringes): Mark locals as initialized
4928 (Bug#8227).
4929 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4930
524c7aa6
PE
4931 * alloc.c (mark_fringe_data): Move decl from here ...
4932 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4933 to check its interface.
4934 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4935
a5c0af81 4936 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4937 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4938 (fontset_font): Mark local as initialized.
a9a06e0b 4939 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4940
b4716021
PE
4941 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4942
811e9bac 4943 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4944 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4945 (x_own_selection, Fx_disown_selection_internal): Rename locals
4946 to avoid shadowing.
4947 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4948
7e3ab302
PE
4949 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4950 so that the caller can use some name other than gcpro1.
4951 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4952 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4953 (Fx_backspace_delete_keys_p):
4954 Use them to avoid shadowing, and rename vars to avoid shadowing.
4955 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4956 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4957 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4958 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4959 Remove unused locals.
7e3ab302
PE
4960 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4961 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4962 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4963 macros.
f78faa98 4964
e2b13473
PE
4965 * xterm.h (x_mouse_leave): New decl.
4966
77f23912
PE
4967 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4968 Remove unused functions.
cdf4ba58
PE
4969 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4970 (x_calc_absolute_position): Now static.
7411c686 4971 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4972 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4973 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4974 unless they are used.
38d0b34a
PE
4975 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4976 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4977 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4978 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4979 (x_error_catcher, x_connection_closed, x_error_handler):
4980 (x_error_quitter, xembed_send_message, x_iconify_frame):
4981 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4982 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4983 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4984
44f230aa
SM
4985 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4986 Rename or move locals to avoid shadowing.
6b463e58 4987 (tty_defined_color, merge_face_heights): Now static.
5967d051 4988 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4989 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4990 does not deduce is never used uninitialized.
73719eba
PE
4991 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4992 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4993
426994c3 4994 * terminal.c (store_terminal_param): Now static.
5489860b 4995
032f1620 4996 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4997 (set_frame_menubar): Remove unused local.
d4323972 4998 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4999 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5000 since they might point to immutable storage.
281585b0
PE
5001 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5002 since it's unused otherwise.
032f1620 5003
367c19e5 5004 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5005 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5006 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5007 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5008 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5009 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5010 does not deduce are never used uninitialized.
70739cbe 5011
07b48fa9
PE
5012 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5013
8868a238 5014 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5015 * window.c (window_loop, size_window):
5016 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5017
7e5cf297 5018 * window.c (display_buffer): Now static.
d6550a9f
PE
5019 (size_window): Mark variables that gcc -Wuninitialized
5020 does not deduce are never used uninitialized.
a586633d
PE
5021 * window.h (check_all_windows): New decl, to forestall
5022 gcc -Wmissing-prototypes diagnostic.
5b555da1 5023 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5024
f6095868
PE
5025 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5026 shadowing.
5027 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5028 Include <limits.h>.
5029 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5030 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5031 (load_charset_map): Mark variables that gcc -Wuninitialized
5032 does not deduce are never used uninitialized.
53df7c11 5033 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5034
f38b440c
PE
5035 * coding.c (coding_set_source, coding_set_destination):
5036 Use "else { /* comment */ }" rather than "else /* comment */;"
5037 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5038 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5039 a block, when the outer 'i' will do.
5040 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5041 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5042 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5043 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5044 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5045 Rename locals to avoid shadowing.
5046 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5047 * coding.c (emacs_mule_char, encode_invocation_designation):
5048 Now static, since they're not used elsewhere.
413bb2db 5049 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5050 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5051 (decode_coding_emacs_mule): Mark variables that gcc
5052 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5053 (detect_coding_iso_2022): Initialize a local variable that might
5054 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5055 this initialization is needed. (Bug#8211)
5f58e762
PE
5056 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5057 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5058 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5059 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5060 Remove unused macros.
f38b440c 5061
232b38b9 5062 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5063 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5064 * character.c (string_count_byte8): Likewise.
232b38b9 5065
fb90da1b
PE
5066 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5067 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5068
fb93dbc2
PE
5069 * chartab.c (copy_sub_char_table): Now static, since it's not used
5070 elsewhere.
5c156ace
PE
5071 (sub_char_table_ref_and_range, char_table_ref_and_range):
5072 Rename locals to avoid shadowing.
bbcd0949 5073 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5074
7d3b3862 5075 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5076 (BIDI_BOB): Remove unused macro.
7d3b3862 5077
6be7d3da
PE
5078 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5079 deduce are never used uninitialized.
c2ed9c8b 5080 * term.c (encode_terminal_code): Likewise.
6be7d3da 5081
75f8807f 5082 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5083
50938595
PE
5084 * tparam.h: New file.
5085 * term.c, tparam.h: Include it.
5086 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5087 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5088 Move these decls to tparam.h, and make them agree with what
5089 is actually in tparam.c. The previous trick of using incompatible
5090 decls in different modules does not conform to the C standard.
5091 All callers of tparam changed to use tparam's actual API.
5092 * tparam.c (tparam1, tparam, tgoto):
5093 Use const pointers where appropriate.
5094
fbceeba2
PE
5095 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5096 * cm.h (struct cm): Likewise.
5097 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5098 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5099 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5100 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5101 (turn_on_face, init_tty): Likewise.
5102 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5103
7f3f1250
PE
5104 * term.c (term_mouse_position): Rename local to avoid shadowing.
5105
e6ca6543
PE
5106 * alloc.c (mark_ttys): Move decl from here ...
5107 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5108
c40f8d15
AS
51092011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5110
5111 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5112
cfe0661d
JB
51132011-03-09 Juanma Barranquero <lekktu@gmail.com>
5114
5115 * search.c (compile_pattern_1): Remove argument regp, unused since
5116 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5117 (compile_pattern): Don't pass it.
5118
0afb4571
J
51192011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5120
5121 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5122 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5123 for ! HAVE_GTK3.
5124 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5125
5126 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5127
5128 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5129 gdk_window_get_screen, gdk_window_get_geometry,
5130 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5131 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5132 (xg_get_pixbuf_from_pixmap): New function.
5133 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5134 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5135 Call xg_get_pixbuf_from_pixmap instead of
5136 gdk_pixbuf_get_from_drawable.
5137 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5138 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5139 (xg_check_special_colors): Use GtkStyleContext and its functions
5140 for HAVE_GTK3.
5141 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5142 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5143 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5144 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5145 Call gtk_widget_get_preferred_size.
0afb4571
J
5146 (xg_frame_resized): gdk_window_get_geometry only takes 5
5147 parameters.
44f230aa
SM
5148 (xg_win_to_widget, xg_event_is_for_menubar):
5149 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5150 (xg_set_widget_bg): New function.
5151 (delete_cb): New function.
895009e1 5152 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5153 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5154 (xg_set_background_color): Call xg_set_widget_bg.
5155 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5156 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5157 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5158 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5159 if ! HAVE_GTK3.
5160 (update_frame_tool_bar): Call gtk_widget_hide.
5161 (xg_initialize): Use GDK_KEY_g.
5162
5163 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5164 if ! HAVE_GTK3
5165 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5166
5167 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5168 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5169 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5170
1c2cc4ef
JB
51712011-03-08 Juanma Barranquero <lekktu@gmail.com>
5172
5173 * w32xfns.c (select_palette): Check success of RealizePalette against
5174 GDI_ERROR, not zero.
5175
33383987 5176See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5177
5178;; Local Variables:
5179;; coding: utf-8
aac0c6e3
MR
5180;; End:
5181
33383987 5182 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5183
5184 This file is part of GNU Emacs.
5185
5186 GNU Emacs is free software: you can redistribute it and/or modify
5187 it under the terms of the GNU General Public License as published by
5188 the Free Software Foundation, either version 3 of the License, or
5189 (at your option) any later version.
5190
5191 GNU Emacs is distributed in the hope that it will be useful,
5192 but WITHOUT ANY WARRANTY; without even the implied warranty of
5193 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5194 GNU General Public License for more details.
5195
5196 You should have received a copy of the GNU General Public License
5197 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.