* fns.c (concat): Minor tuning based on overflow analysis.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13bdea59
PE
12011-06-13 Paul Eggert <eggert@cs.ucla.edu>
2
c1f134b5
PE
3 * fns.c (concat): Minor tuning based on overflow analysis.
4 This doesn't fix any bugs. Use int to hold character, instead
5 of constantly refetching from Emacs object. Use XFASTINT, not
6 XINT, for value known to be a character. Don't bother comparing
7 a single byte to 0400, as it's always less.
8
395fcb93 9 * floatfns.c (Fexpt):
327eeec8
PE
10 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
11
abbd3d23
PE
12 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
13 for characters.
14
684a03ef
PE
15 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
16
0fed43f3
PE
17 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
18 Without this fix, on a 64-bit host (aset S 0 4294967386) would
19 incorrectly succeed when S was a string, because 4294967386 was
20 truncated before it was used.
21
8fd02eb7
PE
22 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
23 Otherwise, an out-of-range integer could cause undefined behavior
24 on a 64-bit host.
25
f8c86b69
PE
26 * composite.c: Use int, not EMACS_INT, for characters.
27 (fill_gstring_body, composition_compute_stop_pos): Use int, not
28 EMACS_INT, for values that are known to be in character range.
29 This doesn't fix any bugs but is the usual style inside Emacs and
30 may generate better code on 32-bit machines.
31
34206dd2
PE
32 Make sure a 64-bit char is never passed to ENCODE_CHAR.
33 This is for reasons similar to the recent CHAR_STRING fix.
34 * charset.c (Fencode_char): Check that character arg is actually
35 a character. Pass an int to ENCODE_CHAR.
36 * charset.h (ENCODE_CHAR): Verify that the character argument is no
37 wider than 'int', as a compile-time check to prevent future regressions
38 in this area.
39
c5958d4c 40 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
41
42 Make sure a 64-bit char is never passed to CHAR_STRING.
43 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
44 by silently ignoring the top 32 bits, allowing some values
45 that were far too large to be valid characters.
46 * character.h: Include <verify.h>.
47 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
48 arguments are no wider than unsigned, as a compile-time check
49 to prevent future regressions in this area.
50 * data.c (Faset):
51 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char):
52 (Fsubst_char_in_region):
53 * fns.c (concat):
54 * xdisp.c (decode_mode_spec_coding):
55 Adjust to CHAR_STRING's new requirement.
56 * editfns.c (Finsert_char, Fsubst_char_in_region):
57 * fns.c (concat): Check that character args are actually
58 characters. Without this test, these functions did the wrong
59 thing with wildly out-of-range values on 64-bit hosts.
60
ea204efb
PE
612011-06-12 Paul Eggert <eggert@cs.ucla.edu>
62
d37ca623
PE
63 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
64 These casts should not be needed on 32-bit hosts, either.
65 * keyboard.c (read_char):
66 * lread.c (Fload): Remove casts to unsigned.
67
ea204efb
PE
68 * lisp.h (UNSIGNED_CMP): New macro.
69 This fixes comparison bugs on 64-bit hosts.
70 (ASCII_CHAR_P): Use it.
71 * casefiddle.c (casify_object):
72 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
73 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
74 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
75 * dispextern.h (FACE_FROM_ID):
76 * keyboard.c (read_char): Use UNSIGNED_CMP.
77
fc83f7d3 782011-06-11 Paul Eggert <eggert@cs.ucla.edu>
666398f3 79
41cb286c
PE
80 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
81 not to EMACS_INT, to avoid GCC warning.
82
4a1b9832
PE
83 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
84
55daad71
PE
85 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
86 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
87 isn't needed on 32-bit machines.
8f95c75c 88
666398f3 89 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 90 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
91
92 * data.c (Qcompiled_function): Now static.
93
c6f072e7
PE
94 * window.c (window_body_lines): Now static.
95
20ce5912
PE
96 * image.c (gif_load): Rename local to avoid shadowing.
97
9c4c5f81
PE
98 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
99 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
100 * alloc.c (make_save_value): Integer argument is now of type
101 ptrdiff_t, not int.
102 (mark_object): Use ptrdiff_t, not int.
103 * lisp.h (pD): New macro.
104 * print.c (print_object): Use it.
105
c0c5c8ae
PE
106 * alloc.c: Use EMACS_INT, not int, to count objects.
107 (total_conses, total_markers, total_symbols, total_vector_size)
108 (total_free_conses, total_free_markers, total_free_symbols)
109 (total_free_floats, total_floats, total_free_intervals, total_intervals)
110 (total_strings, total_free_strings):
111 Now EMACS_INT, not int. All uses changed.
112 (Fgarbage_collect): Compute overall total using a double, so that
113 integer overflow is less likely to be a problem. Check for overflow
114 when converting back to an integer.
5a25e253
PE
115 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
116 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
117 These were 'int' variables that could overflow on 64-bit hosts;
118 they were never used, so remove them instead of repairing them.
211a0b2a 119 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
120 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
121 Previously, this ceilinged at INT_MAX, but that doesn't work on
122 64-bit machines.
e46bb31a 123 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 124
c78baabf 125 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 126 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
127 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
128 when a (possibly-narrower) signed value would do just as well.
129 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 130
c9d624c6
PE
131 * alloc.c: Catch some string size overflows that we were missing.
132 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
133 for convenience in STRING_BYTES_MAX.
134 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
135 The definition here is exact; the one in lisp.h was approximate.
136 (allocate_string_data): Check for string overflow. This catches
137 some instances we weren't catching before. Also, it catches
138 size_t overflow on (unusual) hosts where SIZE_MAX <= min
139 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
140 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 141
c9d624c6
PE
142 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
143 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
144 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
145
353032ce
PE
146 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
147
2bccce07
PE
148 * alloc.c (Fmake_string): Check for out-of-range init.
149
b50691aa
CY
1502011-06-11 Chong Yidong <cyd@stupidchicken.com>
151
152 * dispextern.h (struct image): Replace data member, whose int_val
153 and ptr_val fields were not used by anything, with a single
154 lisp_val object.
155
156 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
157 (gif_clear_image, gif_load, imagemagick_load_image)
158 (gs_clear_image, gs_load): Callers changed.
159
3f754b86
PE
1602011-06-10 Paul Eggert <eggert@cs.ucla.edu>
161
cca69397
PE
162 * buffer.h: Include <time.h>, for time_t.
163 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
164
109e28d0
PE
165 Fix minor problems found by static checking.
166
60737f02
PE
167 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
168
4b66faf3
PE
169 Make identifiers static if they are not used in other modules.
170 * data.c (Qcompiled_function, Qframe, Qvector):
171 * image.c (QimageMagick, Qsvg):
172 * minibuf.c (Qmetadata):
173 * window.c (resize_window_check, resize_root_window): Now static.
174 * window.h (resize_window_check, resize_root_window): Remove decls.
175
109e28d0
PE
176 * window.c (window_deletion_count, delete_deletable_window):
177 Remove; unused.
46a4ce9e
PE
178 (window_body_lines): Now static.
179 (Fdelete_other_windows_internal): Mark vars as initialized.
180 Make sure 'resize_failed' is initialized.
181 (run_window_configuration_change_hook): Rename local to avoid shadowing.
182 (resize_window_apply): Remove unused local.
183 * window.h (delete_deletable_window): Remove decl.
184
109e28d0 185 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
186 (imagemagick_load_image): Fix pointer signedness problem by changing
187 last arg from unsigned char * to char *. All uses changed.
188 Also, fix a local for similar reasons.
189 Remove unused locals. Remove locals to avoid shadowing.
190 (fn_rsvg_handle_free): Remove; unused.
191 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 192 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 193
3f754b86
PE
194 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
195
2547adb1
CY
1962011-06-10 Chong Yidong <cyd@stupidchicken.com>
197
198 * image.c (gif_load): Fix omitted cast error introduced by
199 2011-06-06 change.
200
2c8e37d4
MR
2012011-06-10 Martin Rudalics <rudalics@gmx.at>
202
203 * window.h (resize_proportionally, orig_total_lines)
204 (orig_top_line): Remove from window structure.
205 (set_window_height, set_window_width, change_window_heights)
206 (Fdelete_window): Remove prototypes.
207 (resize_frame_windows): Remove duplicate declaration.
208
440a42e3
EZ
2092011-06-10 Eli Zaretskii <eliz@gnu.org>
210
211 * window.h (resize_frame_windows, resize_window_check)
212 (delete_deletable_window, resize_root_window)
213 (resize_frame_windows): Declare prototypes.
214
215 * window.c (resize_window_apply): Make definition be "static" to
216 match the prototype.
217
562dd5e9
MR
2182011-06-10 Martin Rudalics <rudalics@gmx.at>
219
220 * window.c: Remove declarations of Qwindow_size_fixed,
221 window_min_size_1, window_min_size_2, window_min_size,
222 size_window, window_fixed_size_p, enlarge_window, delete_window.
223 Remove static from declaration of Qdelete_window, it's
224 temporarily needed by Fbury_buffer.
225 (replace_window): Don't assign orig_top_line and
226 orig_total_lines.
227 (Fdelete_window, delete_window): Remove. Window deletion is
228 handled by window.el.
229 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
230 Fdelete_window calls with calls to Qdelete_window.
231 (Fdelete_other_windows): Remove. Deleting other windows is
232 handled by window.el.
233 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
234 handled in window.el.
235 (window_min_size_2, window_min_size_1, window_min_size): Remove.
236 Window minimum sizes are handled in window.el.
237 (shrink_windows, size_window, set_window_height)
238 (set_window_width, change_window_heights, window_height)
239 (window_width, CURBEG, CURSIZE, enlarge_window)
240 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
241 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
242 handled in window.el.
243 (make_dummy_parent): Rename to make_parent_window and give it a
244 second argument horflag.
245 (make_window): Don't set resize_proportionally any more.
246 (Fsplit_window): Remove. Windows are split in window.el.
247 (save_restore_action, save_restore_orig_size)
248 (shrink_window_lowest_first, save_restore_orig_size): Remove.
249 Resize mini windows in window.el.
250 (grow_mini_window, shrink_mini_window): Implement by calling
251 Qresize_root_window_vertically, resize_window_check and
252 resize_window_apply.
253 (saved_window, Fset_window_configuration, save_window_save): Do
254 not handle orig_top_line, orig_total_lines, and
255 resize_proportionally.
256 (window_min_height, window_min_width): Move to window.el.
257 (keys_of_window): Move bindings for delete-other-windows,
258 split-window, delete-window and enlarge-window to window.el.
259
260 * buffer.c: Temporarily extern Qdelete_window.
261 (Fbury_buffer): Temporarily call Qdelete_window instead of
262 Fdelete_window (Fbury_buffer will move to window.el soon).
263
264 * frame.c (set_menu_bar_lines_1): Remove code handling
265 orig_top_line and orig_total_lines.
266
267 * dispnew.c (adjust_frame_glyphs_initially): Don't use
268 set_window_height but set heights directly.
269 (change_frame_size_1): Use resize_frame_windows.
270
271 * xdisp.c (init_xdisp): Don't use set_window_height but set
272 heights directly.
273
274 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
275 resize_frame_windows instead of change_window_heights and run
276 run_window_configuration_change_hook.
277
278 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
279 instead of change_window_heights and run
280 run_window_configuration_change_hook.
281
1a13852e
MR
2822011-06-09 Martin Rudalics <rudalics@gmx.at>
283
284 * window.c (replace_window): Rename second argument REPLACEMENT to
285 NEW. New third argument SETFLAG. Rewrite.
286 (delete_window, make_dummy_parent): Call replace_window with
287 third argument 1.
288 (window_list_1): Move down in code.
289 (run_window_configuration_change_hook): Move set_buffer part
290 before select_frame_norecord part in order to unwind correctly.
291 Rename count1 to count.
292 (recombine_windows, delete_deletable_window, resize_root_window)
293 (Fdelete_other_windows_internal)
294 (Frun_window_configuration_change_hook, make_parent_window)
295 (resize_window_check, resize_window_apply, Fresize_window_apply)
296 (resize_frame_windows, Fsplit_window_internal)
297 (Fdelete_window_internal, Fresize_mini_window_internal): New
298 functions.
299 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
300
f3d1777e
MR
3012011-06-08 Martin Rudalics <rudalics@gmx.at>
302
496e208e
MR
303 * window.h (window): Add some new members to window structure -
304 normal_lines, normal_cols, new_total, new_normal, clone_number,
305 splits, nest, prev_buffers, next_buffers.
306 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 307 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 308
f3d1777e
MR
309 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
310 Remove.
496e208e
MR
311 (make_dummy_parent): Set new members of windows structure.
312 (make_window): Move down in code. Handle new members of window
313 structure.
314 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
315 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
316 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
317 (Fset_window_prev_buffers, Fwindow_next_buffers)
318 (Fset_window_next_buffers, Fset_window_clone_number): New
319 functions.
320 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
321 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
322 Doc-string fixes.
323 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
324 Argument WINDOW can be now internal window too.
325 (Fwindow_use_time): Move up in code.
326 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
327 Rewrite doc-string.
328 (Fset_window_configuration, saved_window)
329 (Fcurrent_window_configuration, save_window_save): Handle new
330 members of window structure.
b9e809c2
MR
331 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
332 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
333 (syms_of_window): New Lisp objects Qrecord_window_buffer,
334 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
335 Qget_mru_window, Qresize_root_window,
336 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
337 Qauto_buffer_name; staticpro them.
f3d1777e 338
abde8f8c
MR
3392011-06-07 Martin Rudalics <rudalics@gmx.at>
340
341 * window.c (Fwindow_total_size, Fwindow_left_column)
342 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
343 (Fwindow_list_1): New functions.
344 (window_box_text_cols): Replace with window_body_cols.
345 (Fwindow_width, Fscroll_left, Fscroll_right): Use
346 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
347 (delete_window, Fset_window_configuration): Call
348 delete_all_subwindows with window as argument.
349 (delete_all_subwindows): Take a window as argument and not a
350 structure. Rewrite.
190b47e6
MR
351 (window_loop): Remove handling of GET_LRU_WINDOW and
352 GET_LARGEST_WINDOW.
353 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
354
355 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
356 window_box_text_cols. delete_all_subwindows now takes a
357 Lisp_Object as argument.
abde8f8c
MR
358
359 * indent.c (compute_motion, Fcompute_motion): Use
360 window_body_cols instead of window_box_text_cols.
361
fa8a67e6
MR
362 * frame.c (delete_frame): Call delete_all_subwindows with root
363 window as argument.
364
a54e3482
DC
3652011-06-07 Daniel Colascione <dan.colascione@gmail.com>
366
367 * fns.c (Fputhash): Document return value.
368
60002bf5
CY
3692011-06-06 Chong Yidong <cyd@stupidchicken.com>
370
371 * image.c (gif_load): Implement gif89a spec "no disposal" method.
372
0c671da6 3732011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 374
b862a52a 375 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 376
be44ca6c
PE
377 Check for overflow when converting integer to cons and back.
378 * charset.c (Fdefine_charset_internal, Fdecode_char):
379 Use cons_to_unsigned to catch overflow.
380 (Fencode_char): Use INTEGER_TO_CONS.
381 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
382 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
383 * data.c (long_to_cons, cons_to_long): Remove.
384 (cons_to_unsigned, cons_to_signed): New functions.
385 These signal an error for invalid or out-of-range values.
386 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
387 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
388 * font.c (Ffont_variation_glyphs):
389 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
390 * lisp.h: Include <intprops.h>.
391 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
392 (cons_to_signed, cons_to_unsigned): New decls.
393 (long_to_cons, cons_to_long): Remove decls.
394 * undo.c (record_first_change): Use INTEGER_TO_CONS.
395 (Fprimitive_undo): Use CONS_TO_INTEGER.
396 * xfns.c (Fx_window_property): Likewise.
397 * xselect.c: Include <limits.h>.
398 (x_own_selection, selection_data_to_lisp_data):
399 Use INTEGER_TO_CONS.
400 (x_handle_selection_request, x_handle_selection_clear)
401 (x_get_foreign_selection, Fx_disown_selection_internal)
402 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
403 (lisp_data_to_selection_data): Use cons_to_unsigned.
404 (x_fill_property_data): Use cons_to_signed.
405 Report values out of range.
406
d1f3d2af
PE
407 Check for buffer and string overflow more precisely.
408 * buffer.h (BUF_BYTES_MAX): New macro.
409 * lisp.h (STRING_BYTES_MAX): New macro.
410 * alloc.c (Fmake_string):
411 * character.c (string_escape_byte8):
412 * coding.c (coding_alloc_by_realloc):
413 * doprnt.c (doprnt):
414 * editfns.c (Fformat):
415 * eval.c (verror):
416 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
417 since they may not be the same number.
418 * editfns.c (Finsert_char):
419 * fileio.c (Finsert_file_contents):
420 Likewise for BUF_BYTES_MAX.
421
dd52fcea
PE
422 * image.c: Use ptrdiff_t, not int, for sizes.
423 (slurp_file): Switch from int to ptrdiff_t.
424 All uses changed.
425 (slurp_file): Check that file size fits in both size_t (for
426 malloc) and ptrdiff_t (for sanity and safety).
427
7f9bbdbb
PE
428 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
429 if b->modtime has its maximal value.
430
dfe18f82
PE
431 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
432
84acfcf0
PE
433 Don't assume time_t can fit into int.
434 * buffer.h (struct buffer.modtime): Now time_t, not int.
435 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
436 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
437
ccd9a01a
PE
438 Minor fixes for signed vs unsigned integers.
439 * character.h (MAYBE_UNIFY_CHAR):
440 * charset.c (maybe_unify_char):
441 * keyboard.c (read_char, reorder_modifiers):
442 XINT -> XFASTINT, since the integer must be nonnegative.
443 * ftfont.c (ftfont_spec_pattern):
444 * keymap.c (access_keymap, silly_event_symbol_error):
445 XUINT -> XFASTINT, since the integer must be nonnegative.
446 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
447 since it makes no difference and we prefer signed.
448 * keyboard.c (record_char): Use XUINT when all the neighbors do.
449 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
450 nonnegative.
451
d6d100dd
SM
4522011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
453
454 * window.h (Fwindow_frame): Declare.
455
2b6148e4
PE
4562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
457
458 * alloc.c: Simplify handling of large-request failures (Bug#8800).
459 (SPARE_MEMORY): Always define.
460 (LARGE_REQUEST): Remove.
461 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
462
f230ecc9
MR
4632011-06-06 Martin Rudalics <rudalics@gmx.at>
464
727e958e
MR
465 * lisp.h: Move EXFUNS for Fframe_root_window,
466 Fframe_first_window and Fset_frame_selected_window to window.h.
467
468 * window.h: Move EXFUNS for Fframe_root_window,
469 Fframe_first_window and Fset_frame_selected_window here from
470 lisp.h.
471
472 * frame.c (Fwindow_frame, Fframe_first_window)
473 (Fframe_root_window, Fframe_selected_window)
474 (Fset_frame_selected_window): Move to window.c.
475 (Factive_minibuffer_window): Move to minibuf.c.
476 (Fother_visible_frames_p): New function.
477
478 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
479
f230ecc9
MR
480 * window.c (decode_window, decode_any_window): Move up in code.
481 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
482 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
483 (Fwindow_buffer): Move up and rewrite doc-string.
484 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
485 (Fwindow_prev): New functions.
727e958e
MR
486 (Fwindow_frame): Move here from frame.c. Accept any window as
487 argument.
488 (Fframe_root_window, Fframe_first_window)
489 (Fframe_selected_window): Move here from frame.c. Accept frame
490 or arbitrary window as argument. Update doc-strings.
491 (Fminibuffer_window): Move up in code.
492 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
493 (Fset_frame_selected_window): Move here from frame.c.
494 Marginal rewrite.
727e958e
MR
495 (Fselected_window, select_window, Fselect_window): Move up in
496 code. Minor doc-string fixes.
f230ecc9 497
4d09bcf6
PE
4982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
499
500 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
501 Do not assume that spare memory exists; that assumption is valid
502 only if SYSTEM_MALLOC.
503 (LARGE_REQUEST): New macro, so that the issue of large requests
504 is separated from the issue of spare memory.
505
810928a2
AS
5062011-06-05 Andreas Schwab <schwab@linux-m68k.org>
507
172418ad
AS
508 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
509 format. (Bug#8806)
510
43f862f7
AS
511 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
512
810928a2
AS
513 * xfns.c (x_set_scroll_bar_default_width): Move declarations
514 before statements.
515
a059fe24
JD
5162011-06-05 Jan Djärv <jan.h.d@swipnet.se>
517
518 * gtkutil.c (xg_get_default_scrollbar_width): New function.
519
520 * gtkutil.h: Declare xg_get_default_scrollbar_width.
521
522 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
523 min width by calling x_set_scroll_bar_default_width (Bug#8505).
524
989bf368
JB
5252011-06-05 Juanma Barranquero <lekktu@gmail.com>
526
527 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
528
4b80f674
CY
5292011-06-04 Chong Yidong <cyd@stupidchicken.com>
530
531 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
532 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
533 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
534 New error handlers.
4b80f674
CY
535 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
536 Obey Vx_select_enable_clipboard_manager. Catch errors in
537 x_clipboard_manager_save (Bug#8779).
538 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 539 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 540
99a33b77 5412011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
542
543 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
544
99a33b77 5452011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
546
547 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
548 in the current matrix if keep_current_p is non-zero.
549
8264569d
EZ
5502011-06-04 Eli Zaretskii <eliz@gnu.org>
551
552 * bidi.c (bidi_level_of_next_char): Fix last change.
553
57f97249
EZ
5542011-06-03 Eli Zaretskii <eliz@gnu.org>
555
fec2107c 556 Support bidi reordering of text covered by display properties.
57f97249 557
fec2107c
EZ
558 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
559 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
560 (bidi_cache_search, bidi_cache_iterator_state)
561 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
562 (bidi_level_of_next_char, bidi_move_to_visually_next):
563 Support character positions inside a run of characters covered by a
fec2107c
EZ
564 display string.
565 (bidi_paragraph_init, bidi_resolve_explicit_1)
566 (bidi_level_of_next_char): Call bidi_fetch_char and
567 bidi_fetch_char_advance instead of FETCH_CHAR and
568 FETCH_CHAR_ADVANCE.
569 (bidi_init_it): Initialize new members.
570 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
571 definitions.
572 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
573 instead of using explicit *_CHAR codes.
d6d100dd
SM
574 (bidi_resolve_explicit, bidi_resolve_weak):
575 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
576 bidirectional text is supported only in multibyte buffers.
577 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
578 it to initialize the frame_window_p member of struct bidi_it.
579 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
580 (bidi_resolve_explicit, bidi_resolve_weak)
581 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
582 bidi_it->nchars is non-positive.
583 (bidi_level_of_next_char): Don't try to lookup the cache for the
584 next/previous character if nothing is cached there yet, or if we
585 were just reseat()'ed to a new position.
c40e2fb2 586
0e14fe90
EZ
587 * xdisp.c (set_cursor_from_row): Set start and stop points
588 according to the row's direction when priming the loop that looks
589 for the glyph on which to display cursor.
590 (single_display_spec_intangible_p): Function deleted.
591 (display_prop_intangible_p): Reimplement to call
592 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
593 Accept 3 additional arguments needed by handle_display_spec.
594 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
595 values: lists, `(when COND...)' forms, etc.
596 (single_display_spec_string_p): Support property values that are
597 lists with the argument STRING its top-level element.
598 (display_prop_string_p): Fix the condition for processing a
599 property that is a list to be consistent with handle_display_spec.
fec2107c 600 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
601 last portion of handle_display_prop.
602 (compute_display_string_pos): Accept additional argument
603 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
604 value of a `display' property is a "replacing spec".
605 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
606 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
607 the display property, but just return a value indicating whether
608 the display property will replace the characters it covers.
609 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
610 frame_window_p members of struct bidi_it.
d6d100dd
SM
611 (compute_display_string_pos, compute_display_string_end):
612 New functions.
fec2107c
EZ
613 (push_it): Accept second argument POSITION, where pop_it should
614 jump to continue iteration.
615 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 616
fec2107c
EZ
617 * keyboard.c (adjust_point_for_property): Adjust the call to
618 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
619
620 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
621 (bidi_init_it): Update prototypes.
622 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
623 (compute_display_string_pos, compute_display_string_end):
624 Declare prototypes.
fec2107c
EZ
625 (struct bidi_it): New members nchars and disp_pos. ch_len is now
626 EMACS_INT.
fc6f18ce 627
40087514 6282011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 629
57f53182
PE
630 Malloc failure behavior now depends on size of allocation.
631 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
632 * lisp.h: Change signatures accordingly.
633 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
634 All callers changed. (Bug#8762)
635
636 * gnutls.c: Use Emacs's memory allocators.
637 Without this change, the gnutls library would invoke malloc etc.
638 directly, which causes problems on non-SYNC_INPUT hosts, and which
639 runs afoul of improving memory_full behavior. (Bug#8761)
640 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
641 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
642 xfree instead of the default malloc, realloc, free.
643 (Fgnutls_boot): No need to check for memory allocation failure,
644 since xmalloc does that for us.
645
ac32cd99 646 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
647 * category.c (hash_get_category_set):
648 * ccl.c (ccl_driver):
649 * charset.c (Fdefine_charset_internal):
650 * charset.h (struct charset.hash_index):
651 * composite.c (get_composition_id, gstring_lookup_cache)
652 (composition_gstring_put_cache):
653 * composite.h (struct composition.hash_index):
654 * dispextern.h (struct image.hash):
655 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
656 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
657 (hashfn_equal, hashfn_user_defined, make_hash_table)
658 (maybe_resize_hash_table, hash_lookup, hash_put)
659 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
660 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
661 (Fsxhash, Fgethash, Fputhash, Fmaphash):
662 * image.c (make_image, search_image_cache, lookup_image)
663 (xpm_put_color_table_h):
664 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 665 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
666 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
667 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
668 * alloc.c (allocate_vectorlike):
669 Check for overflow in vector size calculations.
670 * ccl.c (ccl_driver):
671 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
672 * fns.c, image.c: Remove unnecessary static decls that would otherwise
673 need to be updated by these changes.
40087514
PE
674 * fns.c (make_hash_table, maybe_resize_hash_table):
675 Check for integer overflow with large hash tables.
0de4bb68
PE
676 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
677 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
678 (SXHASH_REDUCE): New macro.
679 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
680 Use it instead of discarding useful hash info with large hash values.
681 (sxhash_float): New function.
682 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
683 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
684 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
685 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
686 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
687 Adjust signatures to match updated version of code.
688 (consing_since_gc): Now EMACS_INT, since a single hash table can
689 use more than INT_MAX bytes.
690
698d32e2
DN
6912011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
692
693 Make it possible to build with GCC-4.6+ -O2 -flto.
694
695 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
696
fd6fa53f
SM
6972011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
698
699 * minibuf.c (get_minibuffer, read_minibuf_unwind):
700 Call minibuffer-inactive-mode.
701
864db017
JB
7022011-05-31 Juanma Barranquero <lekktu@gmail.com>
703
704 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
705 Update dependencies.
706
2ad0baf4
DN
7072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
708
709 * data.c (init_data): Remove code for UTS, this system is not
710 supported anymore.
711
4fcc2638
DN
7122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
713
714 Don't force ./temacs to start in terminal mode.
715
716 * frame.c (make_initial_frame): Initialize faces in all cases, not
717 only when CANNOT_DUMP is defined.
718 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
719
c56e0fd5
DN
7202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
721
722 * dispnew.c (add_window_display_history): Use const for the string
723 pointer. Remove declaration, not needed.
724
333d54da 7252011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 726
55d4c1b2 727 Use 'inline', not 'INLINE'.
333d54da 728 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
729 * alloc.c, fontset.c (INLINE): Remove.
730 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
731 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
732 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
733 * gmalloc.c (register_heapinfo): Use inline unconditionally.
734 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
735
738db178
DN
7362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
737
738 Make it possible to run ./temacs.
739
740 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
741 syms_of_callproc does the same thing. Remove test for
742 "initialized", do it in the caller.
743 * emacs.c (main): Avoid calling set_initial_environment when dumping.
744
620c53a6
SM
7452011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
746
747 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
748 (read_minibuf): Use get_minibuffer.
749 (syms_of_minibuf): Use DEFSYM.
750 (Qmetadata): New var.
751 * data.c (Qbuffer): Don't make it static.
752 (syms_of_data): Use DEFSYM.
753
e003a292
PE
7542011-05-31 Paul Eggert <eggert@cs.ucla.edu>
755
756 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
757 (CCL_CODE_MIN): New macro.
758
ed008a6d
PE
7592011-05-30 Paul Eggert <eggert@cs.ucla.edu>
760
3687c2ef
PE
761 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
762
ed008a6d
PE
763 * eval.c (Qdebug): Now static.
764 * lisp.h (Qdebug): Remove decl. This reverts a part of the
765 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
766 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
767
d66c4c7c
CY
7682011-05-29 Chong Yidong <cyd@stupidchicken.com>
769
770 * image.c: Various fixes to ImageMagick code comments.
771 (Fimagemagick_types): Doc fix.
772
5fbc2025
PE
7732011-05-29 Paul Eggert <eggert@cs.ucla.edu>
774
0196f88a
PE
775 Minor fixes prompted by GCC 4.6.0 warnings.
776
777 * xselect.c (converted_selections, conversion_fail_tag): Now static.
778
5fbc2025
PE
779 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
780 (x_clipboard_manager_save_all): Move extern decl to ...
781 * xterm.h: ... here, so that it can be checked for consistency.
782
1dd3c2d9
CY
7832011-05-29 Chong Yidong <cyd@stupidchicken.com>
784
785 * xselect.c (x_clipboard_manager_save_frame)
786 (x_clipboard_manager_save_all): New functions.
787 (Fx_clipboard_manager_save): Lisp function deleted.
788
789 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
790 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
791
792 * xterm.h: Update prototype.
793
5ba6571d
WX
7942011-05-28 William Xu <william.xwl@gmail.com>
795
796 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
797 exiting (Bug#8239).
798
3eaff834
JM
7992011-05-28 Jim Meyering <meyering@redhat.com>
800
e1900994 801 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
802 * fns.c (to_uchar): Define.
803 (crypto_hash_function): Use it to convert some newly-signed
804 variables to unsigned, to avoid sign-extension bugs. For example,
805 without this change, (md5 "truc") would evaluate to
806 45723a2aff78ff4fff7fff1114760e62 rather than the expected
807 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 808 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 809
0f6990a7
PE
8102011-05-27 Paul Eggert <eggert@cs.ucla.edu>
811
812 Integer overflow fixes.
c8a9ca5a 813
08686060
PE
814 * dbusbind.c: Serial number integer overflow fixes.
815 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
816 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
817 to hold a serial number that is too large for a fixnum.
818 (Fdbus_method_return_internal, Fdbus_method_error_internal):
819 Check for serial numbers out of range. Decode any serial number
59568bf0 820 that was so large that it became a float. (Bug#8722)
08686060 821
2d1fc3c7
PE
822 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
823 (Fdbus_call_method, Fdbus_call_method_asynchronously):
824 Use XFASTINT rather than XUINT when numbers are nonnegative.
825 (xd_append_arg, Fdbus_method_return_internal):
826 (Fdbus_method_error_internal): Likewise. Also, for unsigned
827 arguments, check that Lisp number is nonnegative, rather than
59568bf0 828 silently wrapping negative numbers around. (Bug#8722)
30217ff0 829 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 830 (Bug#8722)
2d1fc3c7 831
c8a9ca5a
PE
832 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
833
519e1d69
PE
834 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
835
30569699
PE
836 ccl: add integer overflow checks
837 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
838 (IN_INT_RANGE): New macros.
839 (ccl_driver): Use them to check for integer overflow when
840 decoding a CCL program. Many of the new checks are whether XINT (x)
841 fits in int; it doesn't always, on 64-bit hosts. The new version
842 doesn't catch all possible integer overflows, but it's an
847044ea 843 improvement. (Bug#8719)
30569699 844
c11285dc
PE
845 * alloc.c (make_event_array): Use XINT, not XUINT.
846 There's no need for unsigned here.
847
fdccd48e
PE
848 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
849 This follows up to the 2011-05-06 change that substituted uintptr_t
850 for EMACS_INT. This case wasn't caught back then.
851
37910ab2
PE
852 Rework Fformat to avoid integer overflow issues.
853 * editfns.c: Include <float.h> unconditionally, as it's everywhere
854 now (part of C89). Include <verify.h>.
855 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
856 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
857 (Fformat): Avoid the prepass trying to compute sizes; it was only
858 approximate and thus did not catch overflow reliably. Instead, walk
859 through the format just once, formatting and computing sizes as we go,
860 checking for integer overflow at every step, and allocating a larger
861 buffer as needed. Keep track separately whether the format is
862 multibyte. Keep only the most-recently calculated precision, rather
863 than them all. Record whether each argument has been converted to
864 string. Use EMACS_INT, not int, for byte and char and arg counts.
865 Support field widths and precisions larger than INT_MAX. Avoid
866 sprintf's undefined behavior with conversion specifications such as %#d
867 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
868 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
869 formatting out-of-range floating point numbers with int
870 formats. (Bug#8668)
871
2e6578fb
PE
872 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
873
0ae6bdee
PE
874 * data.c: Avoid integer truncation in expressions involving floats.
875 * data.c: Include <intprops.h>.
876 (arith_driver): When there's an integer overflow in an expression
877 involving floating point, convert the integers to floating point
878 so that the resulting value does not suffer from catastrophic
879 integer truncation. For example, on a 64-bit host (* 4
880 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
881 Do not rely on undefined behavior after integer overflow.
882
de883a70
PE
883 merge count_size_as_multibyte, parse_str_to_multibyte
884 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 885 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
886 Check for integer overflow.
887 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
888 since it's now a duplicate of the other. This is more of
889 a character than a buffer op, so better that it's in character.c.
890 * fns.c, print.c: Adjust to above changes.
891
2ff916cb
PE
8922011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
893
894 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
895
f1b54466
PE
8962011-05-27 Paul Eggert <eggert@cs.ucla.edu>
897
fb1ac845
PE
898 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
899 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
900 (x_clipboard_manager_save): Now static.
901 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
902
f1b54466
PE
903 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
904 (crypto_hash_function): Now static.
905 Fix pointer signedness problems. Avoid unnecessary initializations.
906
a9f737ee
CY
9072011-05-27 Chong Yidong <cyd@stupidchicken.com>
908
909 * termhooks.h (Vselection_alist): Make it terminal-local.
910
911 * terminal.c (create_terminal): Initialize it.
912
913 * xselect.c: Support for clipboard managers.
914 (Vselection_alist): Move to termhooks.h as terminal-local var.
915 (LOCAL_SELECTION): New macro.
916 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
917 (symbol_to_x_atom): Remove gratuitous arg.
918 (x_handle_selection_request, lisp_data_to_selection_data)
919 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
920 (x_own_selection, x_get_local_selection, x_convert_selection):
921 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
922 (some_frame_on_display): Delete unused function.
923 (Fx_own_selection_internal, Fx_get_selection_internal)
924 (Fx_disown_selection_internal, Fx_selection_owner_p)
925 (Fx_selection_exists_p): New optional frame arg.
926 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
927 (x_handle_selection_clear): Don't treat other terminals with the
928 same keyboard specially. Use the terminal-local Vselection_alist.
929 (x_clear_frame_selections): Use Frun_hook_with_args.
930
931 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
932
933 * xterm.h: Add support for those atoms.
934
e067f0c1
CY
9352011-05-26 Chong Yidong <cyd@stupidchicken.com>
936
937 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
938 (converted_selections, conversion_fail_tag): New global variables.
939 (x_selection_request_lisp_error): Free the above.
940 (x_get_local_selection): Remove unnecessary code.
941 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
942 of converted selections stored in converted_selections.
943 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
944 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
945 (x_convert_selection): New function.
946 (x_handle_selection_event): Simplify.
947 (x_get_foreign_selection): Don't ignore incoming requests while
948 waiting for an answer; this will fail when we implement
949 SAVE_TARGETS, and seems unnecessary anyway.
950 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
951 (Vx_sent_selection_functions): Doc fix.
952
0f4aebc0
LL
9532011-05-26 Leo Liu <sdl.web@gmail.com>
954
955 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
956
e61124cd
YM
9572011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
958
959 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
960
961 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
962 for fringe update if it has periodic bitmap.
963 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
964 and fringe_bitmap_periodic_p.
965
966 * fringe.c (get_fringe_bitmap_data): New function.
967 (draw_fringe_bitmap_1, update_window_fringes): Use it.
968 (update_window_fringes): Record periodicity of fringe bitmap in glyph
969 row. Mark glyph row for fringe update if periodicity changed.
970
971 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
972 for fringe update unless it has periodic bitmap.
973
f16d9837
KH
9742011-05-25 Kenichi Handa <handa@m17n.org>
975
976 * xdisp.c (get_next_display_element): Set correct it->face_id for
977 a static composition.
978
e1b90ef6
LL
9792011-05-24 Leo Liu <sdl.web@gmail.com>
980
981 * deps.mk (fns.o):
982 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
983
984 * fns.c (crypto_hash_function, Fsha1): New function.
985 (Fmd5): Use crypto_hash_function.
986 (syms_of_fns): Add Ssha1.
987
7400048f
PE
9882011-05-22 Paul Eggert <eggert@cs.ucla.edu>
989
990 * gnutls.c: Remove unused macros.
991 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
992 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
993 Remove macros that are defined and never used.
994 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
995
abb71cf4
CY
9962011-05-22 Chong Yidong <cyd@stupidchicken.com>
997
998 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
999 (Fx_get_selection_internal): Minor cleanup.
1000 (Fx_own_selection_internal): Rename arguments for consistency with
1001 select.el.
1002
6307db39
PE
10032011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1004
1005 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1006
f3d4e0a4
CY
10072011-05-22 Chong Yidong <cyd@stupidchicken.com>
1008
1009 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1010
4d8ade89
YM
10112011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1012
1013 * dispnew.c (scrolling_window): Don't exclude the case that the
1014 last enabled row in the desired matrix touches the bottom boundary.
1015
32078c8d
GM
10162011-05-21 Glenn Morris <rgm@gnu.org>
1017
1018 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1019 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1020 and add some more files.
32078c8d 1021
7285dc67
EZ
10222011-05-20 Eli Zaretskii <eliz@gnu.org>
1023
1024 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1025 report_file_error introduced by the change from 2011-05-07.
1026
89d1bd22
PE
10272011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1028
1029 * systime.h (Time): Define only if emacs is defined.
1030 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1031 where the include path doesn't have X11/X.h by default. See
1032 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1033
e23640bb 10342011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1035
1036 * composite.c (find_automatic_composition): Fix previous change.
1037
b9704ad9
GM
10382011-05-20 Glenn Morris <rgm@gnu.org>
1039
1040 * lisp.mk: New file, split from Makefile.in.
1041 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1042 (shortlisp): Remove.
1043 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1044
4a720484
GM
10452011-05-19 Glenn Morris <rgm@gnu.org>
1046
1047 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1048 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1049 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1050 (lisp): Set the order to that of loadup.el.
1051 (shortlisp): Make it a copy of $lisp.
1052 (SOME_MACHINE_LISP): Remove.
1053 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1054 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1055
a28d4396
KH
10562011-05-18 Kenichi Handa <handa@m17n.org>
1057
1058 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1059 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1060 (find_automatic_composition): Mostly rewrite for efficiency.
1061
a2b1fa8e
JB
10622011-05-18 Juanma Barranquero <lekktu@gmail.com>
1063
1064 * makefile.w32-in: Update dependencies.
1065
8e1f5610
CS
10662011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1067
1068 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1069 revision 104625).
1070
7025ee00 10712011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1072
cdfa6eab
PE
1073 Fix some integer overflow issues, such as string length overflow.
1074
06d6db33
PE
1075 * insdel.c (count_size_as_multibyte): Check for string overflow.
1076
2b4560a8
PE
1077 * character.c (lisp_string_width): Check for string overflow.
1078 Use EMACS_INT, not int, for string indexes and lengths; in
1079 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1080 the resulting string length overflows an EMACS_INT; instead,
1081 report a string overflow if no precision given. When checking for
1082 precision exhaustion, use a check that cannot possibly have
1083 integer overflow. (Bug#8675)
1084 * character.h (lisp_string_width): Adjust to new signature.
1085
cb93f9be
PE
1086 * alloc.c (string_overflow): New function.
1087 (Fmake_string): Use it. This doesn't change behavior, but saves
1088 a few bytes and will simplify future changes.
1089 * character.c (string_escape_byte8): Likewise.
1090 * lisp.h (string_overflow): New decl.
1091
1a1f3366
PE
1092 Fixups, following up to the user-interface timestamp change.
1093 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1094 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1095 * msdos.c (mouse_get_pos): Likewise.
1096 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1097 * w32gui.h (Time): Define by including "systime.h" rather than by
1098 declaring it ourselves. (Bug#8664)
1099
d4e3e4d3
PE
1100 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1101 * image.c (clear_image_cache): Likewise.
1102
f6a24d19
PE
1103 * term.c (term_mouse_position): Don't assume time_t wraparound.
1104
08dc5ae6
PE
1105 Be more systematic about user-interface timestamps.
1106 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1107 and sometimes 'EMACS_UINT', to represent these timestamps.
1108 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1109 This makes the code easier to follow, and makes it easier to catch
1110 integer overflow bugs such as Bug#8664.
1111 * frame.c (Fmouse_position, Fmouse_pixel_position):
1112 Use Time, not unsigned long, for user-interface timestamps.
1113 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1114 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1115 * keyboard.h (last_event_timestamp): Likewise.
1116 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1117 * menu.h (xmenu_show): Likewise.
1118 * term.c (term_mouse_position): Likewise.
1119 * termhooks.h (struct input_event.timestamp): Likewise.
1120 (struct terminal.mouse_position_hook): Likewise.
1121 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1122 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1123 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1124 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1125 what it was before.
1126 * menu.h, termhooks.h: Include "systime.h", for Time.
1127
8e55734a
PE
1128 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1129 Don't assume that the difference between two unsigned long values
1130 can fit into an integer. At this point, we know button_down_time
1131 <= event->timestamp, so the difference must be nonnegative, so
1132 there's no need to cast the result if double-click-time is
1133 nonnegative, as it should be; check that it's nonnegative, just in
1134 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1135 apart (about 25 days). (Bug#8664)
8e55734a 1136
841f1b75 1137 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1138 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1139
3e26f69c
PE
1140 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1141 that always fit in int. Use a sentinel instead of a counter, to
1142 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1143 * frame.h (struct frame): Use int for menu_bar_items_used
1144 instead of EMACS_INT, since it always fits in int.
3e26f69c 1145
5cc152c0
PE
1146 * menu.c (grow_menu_items): Check for int overflow.
1147
d89eb65e
PE
1148 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1149
5235bd3e
PE
1150 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1151 Before, the code was not consistent. These values cannot exceed
1152 2**31 - 1 so there's no need to make them unsigned.
1153 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1154 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1155 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1156 as modifiers.
1157 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1158
bc827e23
PE
1159 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1160 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1161 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1162 presumably because the widths might not match.
1163
78eb494e
PE
1164 * window.c (size_window): Avoid needless test at loop start.
1165
04f2d78b
CB
11662011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1167
1168 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1169
d2fc7e3d 11702011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1171
1172 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1173
d2fc7e3d 11742011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1175
1176 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1177 `width' to `bar_area_x' and `bar_area_width', respectively.
1178 (x_scroll_run): Take account of fringe background extension.
1179
04f2d78b
CB
1180 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1181 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1182 `bar_area_width', respectively.
1183 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1184 background extension.
1185
79b70037
GM
11862011-05-10 Jim Meyering <meyering@redhat.com>
1187
1188 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1189
2f142cc5
JB
11902011-05-10 Juanma Barranquero <lekktu@gmail.com>
1191
1192 * image.c (Finit_image_library): Return t for built-in image types,
1193 like pbm and xbm. (Bug#8640)
1194
57679c86
AS
11952011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1196
1197 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1198
888c9e86
EZ
11992011-05-07 Eli Zaretskii <eliz@gnu.org>
1200
b0512a1d
EZ
1201 * w32console.c (Fset_screen_color): Doc fix.
1202 (Fget_screen_color): New function.
1203 (syms_of_ntterm): Defsubr it.
1204
7285dc67
EZ
1205 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1206 unlink the temporary file if Fcall_process didn't create it in the
1207 first place.
1208 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1209 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1210 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1211 cue to call_process_cleanup not to close that handle.
1212
4d3fcc8e
BK
12132011-05-07 Ben Key <bkey76@gmail.com>
1214
1215 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1216 one of two shell specific rules, either bootstrap-temacs-CMD or
1217 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1218 to the previous implementation of the bootstrap-temacs rule.
1219 The bootstrap-temacs-CMD rule is similar to the previous
1220 implementation of the bootstrap-temacs rule except that it
1221 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1222 variable.
1223
1224 These changes, along with some changes to nt/configure.bat,
1225 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1226 earlier fix to add support for --cflags and --ldflags options
1227 that include quotes so that it works whether make uses cmd or
1228 sh as the shell.
1229
b4289b64
MA
12302011-05-06 Michael Albinus <michael.albinus@gmx.de>
1231
1232 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1233 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1234 is a constant.
1235 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1236 a string. Handle both cases.
1237 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1238 (Fdbus_register_method): Use Qinvalid_function.
1239
af4c0e28
JB
12402011-05-06 Juanma Barranquero <lekktu@gmail.com>
1241
1242 * makefile.w32-in: Update dependencies.
1243 (LISP_H): Add inttypes.h and stdin.h.
1244 (PROCESS_H): Add unistd.h.
1245
c51453d9
EZ
12462011-05-06 Eli Zaretskii <eliz@gnu.org>
1247
1248 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1249 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1250
8ff0ac3c 12512011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1252
4c4b566b
PE
1253 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1254
aab2b9b5
PE
1255 * term.c (vfatal): Remove stray call to va_end.
1256 It's not needed and the C Standard doesn't allow it here anyway.
1257
c378da0b
PE
1258 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1259 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1260
288b08c7
PE
1261 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1262 bytes.
1263
e3601888
PE
1264 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1265
db6c0e74
PE
1266 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1267
dd5963ea
PE
1268 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1269
88c9450f
PE
1270 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1271
2f9442b8
PE
1272 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1273
c032b5f8
PE
1274 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1275 * charset.c (Fdefine_charset_internal): Don't initialize
1276 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1277 32-bit int (Bug#8600).
a108c10b
PE
1278
1279 * lread.c (read_integer): Be more consistent with string-to-number.
1280 Use string_to_number to do the actual conversion; this avoids
1281 rounding errors and fixes some other screwups. Without this fix,
1282 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1283 (digit_to_number): Move earlier, for benefit of read_integer.
1284 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1285 not a digit in any supported base. (Bug#8602)
a108c10b 1286
ad5f9eea
PE
1287 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1288
aec1708a
PE
1289 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1290 to match comment at start of function. This also removes a
1291 GCC warning about overflow in a 32+64-bit port.
1292
47be4ab5
PE
1293 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1294
371cac43
PE
1295 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1296 Reported by Stefan Monnier in
1297 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1298 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1299 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1300
d01a7826
PE
1301 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1302 (EMACS_UINTPTR): Likewise, with uintptr_t.
1303
7fd47d5c
PE
1304 * lisp.h: Prefer 64-bit EMACS_INT if available.
1305 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1306 on 32-bit hosts that have 64-bit int, so that they can access
1307 large files.
122b0c86
PE
1308 However, temporarily disable this change unless the temporary
1309 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1310
8727937b
PE
1311 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1312
8ac068ac
PE
1313 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1314 This removes an assumption that EMACS_INT and long are the same
1315 width as pointers. The assumption is true for Emacs porting targets
1316 now, but we want to make other targets possible.
1317 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1318 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1319 In the rest of the code, change types of integers that hold casted
1320 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1321 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1322 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1323 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1324 No need to cast type when ORing.
1325 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1326 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1327 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1328 assume EMACS_INT is the same width as char *.
1329 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1330 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1331 Remove no-longer-needed casts.
1332 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1333 (xg_tool_bar_help_callback, xg_make_tool_item):
1334 Use EMACS_INTPTR to hold an integer
1335 that will be cast to void *; this can avoid a GCC warning
1336 if EMACS_INT is not the same width as void *.
1337 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1338 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1339 (current_message_1, set_message_1):
1340 Use a local to convert to proper width without a cast.
1341 * xmenu.c (dialog_selection_callback): Likewise.
1342
ede49d71
PE
1343 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1344 Also, don't assume VALBITS / RAND_BITS is less than 5,
1345 and don't rely on undefined behavior when shifting a 1 left into
1346 the sign bit.
1347 * lisp.h (get_random): Change signature to match.
1348
2f30ecd0
PE
1349 * lread.c (hash_string): Use size_t, not int, for hash computation.
1350 Normally we prefer signed values; but hashing is special, because
1351 it's better to use unsigned division on hash table sizes so that
1352 the remainder is nonnegative. Also, size_t is the natural width
1353 for hashing into memory. The previous code used 'int', which doesn't
1354 retain enough info to hash well into very large tables.
1355 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1356
2a866e7b
PE
1357 * dbusbind.c: Don't possibly lose pointer info when converting.
1358 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1359 Use XPNTR rather than XHASH, so that the high-order bits of
1360 the pointer aren't lost when converting through void *.
1361
51639eac
PE
1362 * eval.c (Fautoload): Don't double-shift a pointer.
1363
92394119
PE
1364 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1365
dbdb9a7c
JB
13662011-05-06 Juanma Barranquero <lekktu@gmail.com>
1367
1368 * gnutls.c (DEF_GNUTLS_FN):
1369 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1370
db7a0b4f
AS
13712011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1372
1373 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1374 marker. (Bug#8610)
1375
f7ff1b0f 13762011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1377
1378 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1379 New version that can reserve upto 2GB of heap space.
1380
f7ff1b0f 13812011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1382
1383 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1384
639c109b
TZ
13852011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1386
1387 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1388 `gnutls_certificate_set_x509_key_file'.
1389
d2127135
JB
13902011-05-05 Juanma Barranquero <lekktu@gmail.com>
1391
1392 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1393 Update dependencies.
1394
e968f4f3
JB
13952011-05-04 Juanma Barranquero <lekktu@gmail.com>
1396
1397 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1398 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1399 Remove unused parameter `fildes'.
1400 * process.c (read_process_output, send_process): Don't pass it.
1401
84d358f0
JB
14022011-05-04 Juanma Barranquero <lekktu@gmail.com>
1403
1404 Fix previous change: the library cache is defined in w32.c.
1405 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1406 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1407
0898ca10
JB
14082011-05-04 Juanma Barranquero <lekktu@gmail.com>
1409
1410 Implement dynamic loading of GnuTLS on Windows.
1411
1412 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1413 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1414 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1415 Declare.
1416
1417 * gnutls.c (Qgnutls_dll): Define.
1418 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1419 (gnutls_*): Declare function pointers.
1420 (init_gnutls_functions): New function to initialize function pointers.
1421 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1422 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1423 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1424 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1425 (emacs_gnutls_write, emacs_gnutls_read)
1426 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1427 (Fgnutls_available_p): New function.
1428 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1429 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1430 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1431
1432 * image.c: Include w32.h.
1433 (Vimage_type_cache): Delete.
1434 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1435 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1436 (w32_delayed_load): Move to w32.c.
1437
1438 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1439
1440 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1441 (w32_delayed_load): Move from image.c. When loading a library, record
1442 its filename in the :loaded-from property of the library id.
1443 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1444 Initialize and staticpro them.
1445 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1446
1447 * process.c: Include lisp.h before w32.h, not after.
1448 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1449 instead of gnutls_record_check_pending.
1450
1451 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1452
ff4de4aa
TZ
14532011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1454
1455 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1456 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1457 as passed in.
1458
abe95abb
JD
14592011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1460
1461 * xterm.c (x_set_frame_alpha): Do not set property on anything
1462 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1463
e16e55d4
JB
14642011-05-02 Juanma Barranquero <lekktu@gmail.com>
1465
1466 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1467
bafcf6a5
JB
14682011-05-02 Juanma Barranquero <lekktu@gmail.com>
1469
1470 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1471 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1472 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1473 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1474 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1475 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1476 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1477 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1478 (Qgnutls_bootprop_callbacks_verify): Make static.
1479
e7a6747f
AS
14802011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1481
19ed11ba
AS
1482 * callproc.c: Indentation fixup.
1483
e7a6747f 1484 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1485 (wait_for_termination, interruptible_wait_for_termination):
1486 Move after wait_for_termination_1.
e7a6747f 1487
1ef14cb4
LMI
14882011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1489
1490 * sysdep.c (interruptible_wait_for_termination): New function
1491 which is like wait_for_termination, but allows keyboard
1492 interruptions.
1493
1494 * callproc.c (Fcall_process): Add (:file "file") as an option for
1495 the STDOUT buffer.
1496 (Fcall_process_region): Ditto.
1497
330d880c
EZ
14982011-04-30 Eli Zaretskii <eliz@gnu.org>
1499
8db90b73
EZ
1500 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1501 rather than `XVECTOR (FOO)->size'.
1502
330d880c
EZ
1503 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1504 inttypes.h, as a gnulib replacement is used if it not available in
1505 system headers.
1506
15cbd324
EZ
15072011-04-21 Eli Zaretskii <eliz@gnu.org>
1508
1509 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1510 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1511 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1512
1513 * coding.c (coding_alloc_by_realloc): Error out if destination
1514 will grow beyond MOST_POSITIVE_FIXNUM.
1515 (decode_coding_emacs_mule): Abort if there isn't enough place in
1516 charbuf for the composition carryover bytes. Reserve an extra
1517 space for up to 2 characters produced in a loop.
1518 (decode_coding_iso_2022): Abort if there isn't enough place in
1519 charbuf for the composition carryover bytes.
1520
15212011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1522
ae940cca
EZ
1523 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1524 aborting when %lld or %lll format is passed.
1525 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1526 %llo or %llx format is passed. (Bug#8545)
1527
03ab8921
EZ
1528 * window.c (window_scroll_line_based): Use a marker instead of
1529 simple variables to record original value of point. (Bug#7952)
1530
afda1437
EZ
1531 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1532 produced by %s or %c overflows available buffer space. (Bug#8545)
1533
f76dee0c
PE
15342011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1537 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1538
fdc5744d
JB
15392011-04-28 Juanma Barranquero <lekktu@gmail.com>
1540
1541 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1542
638f053a
JB
15432011-04-28 Juanma Barranquero <lekktu@gmail.com>
1544
1545 * keyboard.c (Qdelayed_warnings_hook): Define.
1546 (command_loop_1): Run `delayed-warnings-hook'
1547 if Vdelayed_warnings_list is non-nil.
1548 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1549 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1550
d178f871
EZ
15512011-04-28 Eli Zaretskii <eliz@gnu.org>
1552
1553 * doprnt.c (doprnt): Don't return value smaller than the buffer
1554 size if the message was truncated. (Bug#8545).
1555
b124fd93
JB
15562011-04-28 Juanma Barranquero <lekktu@gmail.com>
1557
1558 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1559 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1560
e810457d
PE
15612011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1562
1563 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1564
ea51cceb
JB
15652011-04-27 Juanma Barranquero <lekktu@gmail.com>
1566
1567 * makefile.w32-in: Update dependencies.
1568
94dcfacf
EZ
15692011-04-27 Eli Zaretskii <eliz@gnu.org>
1570
1571 Improve `doprnt' and its usage. (Bug#8545)
1572 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1573 `format_end'. Remove support for %l as a conversion specifier.
1574 Don't use xrealloc. Improve diagnostics when the %l size modifier
1575 is used. Update the commentary.
1576
1577 * eval.c (verror): Simplify calculation of size_t.
1578
1579 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1580 messages.
1581
f61f41d7
PE
15822011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1583
1584 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1585 change.
1586
96fb4434
PE
15872011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1588
1589 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1590 This makes this file independent of the recent pseudovector change.
1591
671875da 15922011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1593
69e9b5a3
PE
1594 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1595
b5f869a7 1596 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1597 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1598 Remove unused local.
c8926152 1599 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1600
841a1577 1601 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1602 GCC 4.6.0 optimizes based on type-based alias analysis.
1603 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1604 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1605 != &v->size, and therefore "v->size = 1; b->size = 2; return
1606 v->size;" must therefore return 1. This assumption is incorrect
1607 for Emacs, since it type-puns struct Lisp_Vector * with many other
1608 types. To fix this problem, this patch adds a new type struct
f904488f 1609 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1610 and pseudovectors, and helps optimizing compilers not get fooled
1611 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1612 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1613 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1614 the size member.
eab3844f
PE
1615 (XSETPVECTYPE): Rewrite in terms of new macro.
1616 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1617 This is a bit clearer, and further avoids the possibility of
1618 undesirable aliasing.
1619 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1620 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1621 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1622 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1623 (ASIZE): Now uses header.size rather than size.
1624 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1625 to avoid the hassle of writing XVECTOR (foo)->header.size.
1626 (struct vectorlike_header): New type.
eab3844f
PE
1627 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1628 object, to help avoid aliasing.
1629 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1630 (SUBRP): Likewise, since Lisp_Subr is a special case.
1631 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1632 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1633 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1634 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1635 changed to be "header.size" and "header.next".
1636 * buffer.h (struct buffer): Likewise.
1637 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1638 * frame.h (struct frame): Likewise.
1639 * process.h (struct Lisp_Process): Likewise.
1640 * termhooks.h (struct terminal): Likewise.
1641 * window.c (struct save_window_data, struct saved_window): Likewise.
1642 * window.h (struct window): Likewise.
1643 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1644 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1645 * buffer.c (init_buffer_once): Likewise.
1646 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1647 special case.
1648 * process.c (Fformat_network_address): Use local var for size,
1649 for brevity.
1650
0df1eac5
PE
1651 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1652
847ab9d1 1653 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1654 * data.c (atof): Remove decl; no longer used or needed.
1655 (digit_to_number): Move to lread.c.
1656 (Fstring_to_number): Use new string_to_number function, to be
1657 consistent with how the Lisp reader treats infinities and NaNs.
1658 Do not assume that floating-point numbers represent EMACS_INT
1659 without losing information; this is not true on most 64-bit hosts.
1660 Avoid double-rounding errors, by insisting on integers when
1661 parsing non-base-10 numbers, as the documentation specifies.
1662 * lisp.h (string_to_number): New decl, replacing ...
1663 (isfloat_string): Remove.
bc0a5c13 1664 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1665 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1666 appears to have been a coding error. Similarly, do not accept
1667 strings like +-1e0 as floating point numbers. Do not report
1668 overflow for integer overflows unless the base is not 10 which
1669 means we have no simple and reliable way to continue.
1670 Break out the floating-point parsing into a new
1671 function string_to_number, so that Fstring_to_number parses
1672 floating point numbers consistently with the Lisp reader.
04f2d78b 1673 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1674 (E_CHAR, EXP_INT): Remove, replacing with ...
1675 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1676 (string_to_number): New function, replacing isfloat_string.
1677 This function checks for valid syntax and produces the resulting
1678 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1679 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1680 so that overflow for non-base-10 numbers is reported only when
1681 there's no portable and simple way to convert to floating point.
452f4150 1682
67769ffc
PE
1683 * textprop.c (set_text_properties_1): Rewrite for clarity,
1684 and to avoid GCC warning about integer overflow.
1685
c20db43f
PE
1686 * intervals.h (struct interval): Use EMACS_INT for members
1687 where EMACS_UINT might cause problems. See
1688 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1689 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1690 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1691 All uses changed.
37aa2f85
PE
1692 (offset_intervals): Tell GCC not to worry about length overflow
1693 when negating a negative length.
c20db43f 1694
2538aa2f
PE
1695 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1696 (overrun_check_free): Likewise.
1697
f2d3008d
PE
1698 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1699 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1700 word size.
1701
ec8df744
PE
1702 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1703 (gnutls_make_error): Rename local to avoid shadowing.
1704 (gnutls_emacs_global_deinit): ifdef out; not used.
1705 (Fgnutls_boot): Use const for pointer to readonly storage.
1706 Comment out unused local. Fix pointer signedness problems.
1707
640ee02d
PE
1708 * lread.c (openp): Don't stuff size_t into an 'int'.
1709 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1710 about possible signed overflow.
1711
6048fb2a
PE
1712 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1713 (GDK_KEY_g): Don't define if already defined.
1714 (xg_prepare_tooltip): Avoid pointer signedness problem.
1715 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1716
fa3c87e1
PE
1717 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1718 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1719
2172544b
PE
1720 * xfns.c (Fx_window_property): Simplify a bit,
1721 to make a bit faster and to avoid GCC 4.6.0 warning.
1722 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1723
9b821a21
PE
1724 * fns.c (internal_equal): Don't assume size_t fits in int.
1725
3c616cfa
PE
1726 * alloc.c (compact_small_strings): Tighten assertion a little.
1727
c2982e87
PE
1728 Replace pEd with more-general pI, and fix some printf arg casts.
1729 * lisp.h (pI): New macro, generalizing old pEd macro to other
1730 conversion specifiers. For example, use "...%"pI"d..." rather
1731 than "...%"pEd"...".
1732 (pEd): Remove. All uses replaced with similar uses of pI.
1733 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1734 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1735 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1736 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1737 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1738 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1739 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1740 64-bit hosts.
1741 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1742 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1743 * print.c (safe_debug_print, print_object): Likewise.
1744 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1745 to int.
6f04d126
PE
1746 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1747 avoiding the 0 flag, which is not portable.
c2982e87
PE
1748 * process.c (Fmake_network_process): Use pI to avoid cast.
1749 * region-cache.c (pp_cache): Likewise.
1750 * xdisp.c (decode_mode_spec): Likewise.
1751 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1752 behavior on 64-bit hosts with printf arg.
6f04d126 1753 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1754 (x_stop_queuing_selection_requests): Likewise.
1755 (x_get_window_property): Don't truncate byte count to an 'int'
1756 when tracing.
0b432f21 1757
5e073ec7
PE
1758 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1759 here, since it parses constructs like leading '-' and spaces,
1760 which are not wanted; and it overflows with large numbers.
1761 Instead, simply match F[0-9]+, which is what is wanted anyway.
1762
36372bf9
PE
1763 * alloc.c: Remove unportable assumptions about struct layout.
1764 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1765 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1766 (allocate_vectorlike, make_pure_vector): Use the new macros,
1767 plus offsetof, to remove unportable assumptions about struct layout.
1768 These assumptions hold on all porting targets that I know of, but
1769 they are not guaranteed, they're easy to remove, and removing them
1770 makes further changes easier.
1771
0b432f21
PE
1772 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1773 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1774 (string_overrun_cookie): Now const. Use initializers that
1775 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1776 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1777 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1778 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1779 multiple of sizeof (EMACS_INT); it need not be, if
1780 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1781 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1782
895009e1
JB
17832011-04-26 Juanma Barranquero <lekktu@gmail.com>
1784
1785 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1786
6a7a1b0b
TZ
17872011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1788
1789 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1790 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1791 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1792
841a1577 17932011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1794
1795 * lisp.h (Qdebug): List symbol.
895009e1 1796 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1797 * keyboard.c (debug-on-event): New variable.
1798 (handle_user_signal): Break into debugger when debug-on-event
1799 matches the current signal symbol.
1800
f2d3ba6f
DN
18012011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1802
1803 * alloc.c (check_sblock, check_string_bytes)
1804 (check_string_free_list): Convert to standard C.
1805
42ce4c63
TZ
18062011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1807
1808 * w32.c (emacs_gnutls_push): Fix typo.
1809
825cd63c
EZ
18102011-04-25 Eli Zaretskii <eliz@gnu.org>
1811
fb11d64d
EZ
1812 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1813 "cast to pointer from integer of different size".
1814
825cd63c
EZ
1815 Improve doprnt and its use in verror. (Bug#8545)
1816 * doprnt.c (doprnt): Document the set of format control sequences
1817 supported by the function. Use SAFE_ALLOCA instead of always
1818 using `alloca'.
1819
1820 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1821 is one byte too soon. Don't use xrealloc; instead xfree and
1822 xmalloc anew.
1823
e061a11b
TZ
18242011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1825
1826 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1827 callbacks stage.
1828
1829 * gnutls.c: Renamed global_initialized to
1830 gnutls_global_initialized. Added internals for the
1831 :verify-hostname-error, :verify-error, and :verify-flags
1832 parameters of `gnutls-boot' and documented those parameters in the
1833 docstring. Start callback support.
1834 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1835 unless a fatal error occured. Call gnutls_alert_send_appropriate
1836 on error. Return error code.
1837 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1838 (emacs_gnutls_read): Likewise.
1839 (Fgnutls_boot): Return handshake error code.
1840 (emacs_gnutls_handle_error): New function.
1841 (wsaerror_to_errno): Likewise.
1842
1843 * w32.h (emacs_gnutls_pull): Add prototype.
1844 (emacs_gnutls_push): Likewise.
1845
1846 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1847 (emacs_gnutls_push): Likewise.
1848
18492011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1850
1851 * process.c (wait_reading_process_output): Check if GnuTLS
1852 buffered some data internally if no FDs are set for TLS
1853 connections.
1854
1855 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1856 (LIBS): Link to USER_LIBS.
1857 ($(BLD)/gnutls.$(0)): New target.
1858
fa6996bc
EZ
18592011-04-24 Eli Zaretskii <eliz@gnu.org>
1860
eb35682e
EZ
1861 * xdisp.c (handle_single_display_spec): Rename the
1862 display_replaced_before_p argument into display_replaced_p, to
1863 make it consistent with the commentary. Fix typos in the
1864 commentary.
1865
e2ad650c
EZ
1866 * textprop.c (syms_of_textprop): Remove dead code.
1867 (copy_text_properties): Delete obsolete commentary about an
1868 interface that was deleted long ago. Fix typos in the description
1869 of arguments.
1870
1b2de274
EZ
1871 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1872 to changes in oldXMenu/XMenu.h from 2011-04-16.
1873 <menu_help_message, prev_menu_help_message>: Constify.
1874 (IT_menu_make_room): menu->help_text is now `const char **';
1875 adjust.
1876
1877 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1878 to changes in oldXMenu/XMenu.h from 2011-04-16.
1879 (struct XMenu): Declare `help_text' `const char **'.
1880
1881 * xfaces.c <Qunspecified>: Make extern again.
1882
1883 * syntax.c: Include sys/types.h before including regex.h, as
1884 required by Posix.
1885
762b15be
EZ
1886 * doc.c (get_doc_string): Improve the format passed to `error'.
1887
1888 * doprnt.c (doprnt): Improve commentary.
1889
1890 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1891
1892 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1893 them with etags.
1894
f1052e5d
EZ
1895 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1896 changes in globals.h immediately force recompilation.
762b15be
EZ
1897 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1898 $(CURDIR)/s/ms-w32.h.
1899 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1900
fa6996bc
EZ
1901 * character.c (Fchar_direction): Function deleted.
1902 (syms_of_character): Don't defsubr it.
1903 <char-direction-table>: Deleted.
1904
e6c3da20
EZ
19052011-04-23 Eli Zaretskii <eliz@gnu.org>
1906
1907 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1908 * doprnt.c: Include limits.h.
1909 (SIZE_MAX): New macro.
04f2d78b
CB
1910 (doprnt): Return a size_t value. 2nd arg is now size_t.
1911 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1912 Improve overflow protection. Support `l' modifier for integer
1913 conversions. Support %l conversion. Don't assume an EMACS_INT
1914 argument for integer conversions and for %c.
1915
1916 * lisp.h (doprnt): Restore prototype.
1917
1918 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1919 $(SRC)/character.h.
1920
1921 * Makefile.in (base_obj): Add back doprnt.o.
1922
1923 * deps.mk (doprnt.o): Add back prerequisites.
1924 (callint.o): Depend on character.h.
1925
1926 * eval.c (internal_lisp_condition_case): Include the handler
1927 representation in the error message.
1928 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1929 when breaking from the loop.
1930
1931 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1932
1933 * callint.c (Fcall_interactively): When displaying error message
1934 about invalid control letter, pass the character's codepoint, not
1935 a pointer to its multibyte form. Improve display of the character
1936 in octal and display also its hex code.
1937
1938 * character.c (char_string): Use %x to display the (unsigned)
1939 codepoint of an invalid character, to avoid displaying a bogus
1940 negative value.
1941
1942 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1943 `error', not SYMBOL_NAME itself.
1944
1945 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1946 character arguments to `error'.
1947
1948 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1949 to `error' in error message about FINAL_CHAR argument. Make sure
1950 FINAL_CHAR is a character, and use %c when it is passed as
1951 argument to `error'.
1952
4ffd0d6b 19532011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1954
1955 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1956
1957 * w32.c: Include <time.h>.
1958 (sys_localtime): New function.
1959
4ffd0d6b 19602011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1961
1962 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1963
4ffd0d6b 1964 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1965
4ffd0d6b 19662011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1967
4ffd0d6b
GM
1968 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1969 zombies (Bug#8467).
aac0c6e3 1970
04c56954
EZ
19712011-04-19 Eli Zaretskii <eliz@gnu.org>
1972
1973 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1974 gl_state.e_property when gl_state.object is Qt.
1975
1976 * insdel.c (make_gap_larger): Remove limitation of buffer size
1977 to <= INT_MAX.
1978
16a43933
CY
19792011-04-18 Chong Yidong <cyd@stupidchicken.com>
1980
1981 * xdisp.c (lookup_glyphless_char_display)
1982 (produce_glyphless_glyph): Handle cons cell entry in
1983 glyphless-char-display.
1984 (Vglyphless_char_display): Document it.
1985
1986 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1987 glyphless-char-display.
1988
4581706e
CY
19892011-04-17 Chong Yidong <cyd@stupidchicken.com>
1990
1991 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1992
1993 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1994
1995 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1996 definition for no-X builds.
1997
4887c6e2 19982011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1999
fd35b6f9
PE
2000 Static checks with GCC 4.6.0 and non-default toolkits.
2001
5c1ccb01
PE
2002 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2003
006c5daa
PE
2004 * process.c (keyboard_bit_set): Define only if SIGIO.
2005 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2006 (send_process): Repair possible setjmp clobbering.
2007
efc736d3
PE
2008 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2009
4e2fe2e6
PE
2010 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2011
f97334a2
PE
2012 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2013
4e75f29d
PE
2014 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2015 Define only if needed.
2016
90efadd1
PE
2017 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2018 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2019 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2020
3c647824
PE
2021 * dispextern.h (struct redisplay_interface): Rename param
2022 to avoid shadowing.
e264f262 2023 * termhooks.h (struct terminal): Likewise.
761383f4 2024 * xterm.c (xembed_send_message): Likewise.
3c647824 2025
b58c5c4a
PE
2026 * insdel.c (make_gap_smaller): Define only if
2027 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2028
cad59032
PE
2029 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2030 it.
2031
c339dc2e
PE
2032 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2033 so that we aren't warned about unused symbols.
2034
91a3e27b
PE
2035 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2036
399c71d3 2037 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2038
8ffc96f5
PE
2039 * xfns.c (x_real_positions): Mark locals as initialized.
2040
eef9bc79
PE
2041 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2042
098db9dd
PE
2043 * xterm.c: Fix problems found by static analysis with other toolkits.
2044 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2045 (x_dispatch_event): Declare static if USE_GTK, and
2046 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2047 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2048 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2049 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2050 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2051
eb18f6cc
PE
2052 * xmenu.c (menu_help_callback): Pointer type fixes.
2053 Use const pointers when pointing at readonly data. Avoid pointer
2054 signedness clashes.
2055 (FALSE): Remove unused macro.
2056 (update_frame_menubar): Remove unused decl.
2057
1fe72bf8
PE
2058 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2059
60d9e1db
PE
2060 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2061 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2062 (single_menu_item): Rename local to avoid shadowing.
2063
39261c26
PE
2064 * keyboard.c (make_lispy_event): Remove unused local var.
2065
018c5e19
PE
2066 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2067 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2068
63d2b86e
PE
2069 * bitmaps: Change bitmaps from unsigned char back to the X11
2070 compatible char. Avoid the old compiler warnings about
2071 out-of-range initializers by using, for example, '\xab' rather
2072 than 0xab.
2073
aefd87e1
PE
2074 * xgselect.c (xgselect_initialize): Check vs interface
2075 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2076
bf501fb9
PE
2077 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2078
e9829fdf
PE
2079 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2080 to read-only memory.
2081
1086c095
PE
2082 * fns.c (vector): Remove; this old hack is no longer needed.
2083
2baccd04 2084 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2085 Remove unused var.
dde42981 2086 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2087
72391843 2088 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2089
436c16df 2090 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2091 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2092 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2093
92bb796d 2094 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2095 (x_term_init): Remove local to avoid shadowing.
92bb796d 2096
764430a3 2097 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2098
2099 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2100 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2101
d1dfb56c
EZ
21022011-04-16 Eli Zaretskii <eliz@gnu.org>
2103
c4354cb4
EZ
2104 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2105
d1dfb56c
EZ
2106 Fix regex.c, syntax.c and friends for buffers > 2GB.
2107 * syntax.h (struct gl_state_s): Declare character position members
2108 EMACS_INT.
2109
2110 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2111
04f2d78b
CB
2112 * textprop.c (verify_interval_modification, interval_of):
2113 Declare arguments EMACS_INT.
d1dfb56c
EZ
2114
2115 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2116 EMACS_INT.
2117
2118 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2119
2120 * indent.c (Fvertical_motion): Local variable it_start is now
2121 EMACS_INT.
2122
2123 * regex.c (re_match, re_match_2, re_match_2_internal)
2124 (bcmp_translate, regcomp, regexec, print_double_string)
2125 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2126 (re_compile_pattern, re_exec): Declare arguments and local
2127 variables `size_t' and `ssize_t' and return values `regoff_t', as
2128 appropriate.
2129 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2130 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2131 <compile_stack_type>: `size' and `avail' are now `size_t'.
2132
2133 * regex.h <regoff_t>: Use ssize_t, not int.
2134 (re_search, re_search_2, re_match, re_match_2): Arguments that
2135 specify buffer/string position and length are now ssize_t and
2136 size_t. Return type is regoff_t.
2137
613052cd
BK
21382011-04-16 Ben Key <bkey76@gmail.com>
2139
2140 * nsfont.m: Fixed bugs in ns_get_family and
2141 ns_descriptor_to_entity that were caused by using free to
2142 deallocate memory blocks that were allocated by xmalloc (via
2143 xstrdup). This caused Emacs to crash when compiled with
2144 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2145 --enable-checking=xmallocoverrun). xfree is now used to
2146 deallocate these memory blocks.
2147
4170f62f 21482011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2149
71b41406
PE
2150 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2151
9587a89d
PE
2152 emacs_write: Accept and return EMACS_INT for sizes.
2153 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2154 et seq.
2155 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2156 Accept and return EMACS_INT.
2157 (emacs_gnutls_write): Return the number of bytes written on
2158 partial writes.
2159 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2160 (emacs_read, emacs_write): Remove check for negative size, as the
2161 Emacs source code has been audited now.
9587a89d
PE
2162 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2163 (emacs_read, emacs_write): Use it.
273a5f82
PE
2164 * process.c (send_process): Adjust to the new signatures of
2165 emacs_write and emacs_gnutls_write. Do not attempt to store
2166 a byte offset into an 'int'; it might overflow.
9587a89d 2167 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2168
3e047f51
PE
2169 * sound.c: Don't assume sizes fit in 'int'.
2170 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2171 Return EMACS_INT, not int.
3e047f51 2172 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2173 Accept EMACS_INT, not int.
2174 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2175 record read return values.
2176
cc39a9db
BK
21772011-04-15 Ben Key <bkey76@gmail.com>
2178
c9d0ec6d
JB
2179 * keyboard.c (Qundefined): Don't declare static since it is used
2180 in nsfns.m.
2181 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2182 static since they are used in nsfont.m.
cc39a9db 2183
6c60eb9f
SM
21842011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2185
2186 * process.c (Qprocessp): Don't declare static.
2187 * lisp.h (Qprocessp): Declare again.
2188
7990b61a
JB
21892011-04-15 Juanma Barranquero <lekktu@gmail.com>
2190
2191 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2192
5d4cb038
PE
21932011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2194
8bd7b830 2195 Improve C-level modularity by making more things 'static'.
cd64ea1d 2196
e3b27b31
PE
2197 Don't publish debugger-only interfaces to other modules.
2198 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2199 (verify_bytepos, count_markers): Move decls to the only modules
2200 that need them.
2201 * region-cache.h (pp_cache): Likewise.
2202 * window.h (check_all_windows): Likewise.
2203 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2204
5d4cb038
PE
2205 * sysdep.c (croak): Now static, if
2206 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2207 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2208
2209 * alloc.c (refill_memory_reserve): Now static if
2210 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2211 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2212
e87b6180
PE
2213 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2214 Define only if USE_LUCID.
2215
ac64929e
PE
2216 * xrdb.c (x_customization_string, x_rm_string): Now static.
2217
6f37259d
PE
2218 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2219 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2220
1683e3ab
PE
2221 * xdisp.c (draw_row_with_mouse_face): Now static.
2222 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2223
de9c2632
PE
2224 * window.h (check_all_windows): Mark externally visible.
2225
2b96acb7
PE
2226 * window.c (window_deletion_count): Now static.
2227
2228 * undo.c: Make symbols static if they're not exported.
2229 (last_undo_buffer, last_boundary_position, pending_boundary):
2230 Now static.
2231
50436f33
PE
2232 * textprop.c (interval_insert_behind_hooks): Now static.
2233 (interval_insert_in_front_hooks): Likewise.
2234
64520e5c
PE
2235 * term.c: Make symbols static if they're not exported.
2236 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2237 (max_frame_lines, tty_set_terminal_modes):
2238 (tty_reset_terminal_modes, tty_turn_off_highlight):
2239 (get_tty_terminal): Now static.
2240 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2241 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2242 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2243 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2244 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2245
1fa53021
PE
2246 * sysdep.c: Make symbols static if they're not exported.
2247 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2248 Now static.
2249 (sigprocmask_set, full_mask): Remove; unused.
2250 (wait_debugging): Mark as visible.
2251 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2252 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2253
d4b43b22
PE
2254 * syntax.c (syntax_temp): Define only if !__GNUC__.
2255
b7c513d0
PE
2256 * sound.c (current_sound_device, current_sound): Now static.
2257
989b29ad
PE
2258 * search.c (searchbufs, searchbuf_head): Now static.
2259
13a55a78
PE
2260 * scroll.c (scroll_cost): Remove; unused.
2261 * dispextern.h (scroll_cost): Remove decl.
2262
de68a1fc
PE
2263 * region-cache.h (pp_cache): Mark as externally visible.
2264
40ccffa6
PE
2265 * process.c: Make symbols static if they're not exported.
2266 (process_tick, update_tick, create_process, chan_process):
2267 (Vprocess_alist, proc_buffered_char, datagram_access):
2268 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2269 (deactivate_process): Mark defn as static, as well as decl.
2270 * lisp.h (create_process): Remove decl.
2271 * process.h (chan_process, Vprocess_alist): Remove decls.
2272
ad64fc97
PE
2273 * print.c: Make symbols static if they're not exported.
2274 (print_depth, new_backquote_output, being_printed, print_buffer):
2275 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2276 (print_interval, print_number_index, initial_stderr_stream):
2277 Now static.
2278 * lisp.h (Fprinc): Remove decl.
2279 (debug_output_compilation_hack): Mark as externally visible.
2280
adddb265
PE
2281 * sysdep.c (croak): Move decl from here to syssignal.h.
2282 * syssignal.h (croak): Put it here, so the API can be checked when
2283 'croak' is called from dissociate_if_controlling_tty.
2284
1717ede2
PE
2285 * minibuf.c: Make symbols static if they're not exported.
2286 (minibuf_save_list, choose_minibuf_frame): Now static.
2287 * lisp.h (choose_minibuf_frame): Remove decl.
2288
fa5fb2bc
PE
2289 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2290
1e3890d1
PE
2291 * lread.c: Make symbols static if they're not exported.
2292 (read_objects, initial_obarray, oblookup_last_bucket_number):
2293 Now static.
2294 (make_symbol): Remove; unused.
2295 * lisp.h (initial_obarray, make_symbol): Remove decls.
2296
8a1414fa
PE
2297 * keyboard.c: Make symbols static if they're not exported.
2298 (single_kboard, recent_keys_index, total_keys, recent_keys):
2299 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2300 (this_single_command_key_start, echoing, last_auto_save):
2301 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2302 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2303 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2304 (Vlispy_mouse_stem, double_click_count):
2305 Now static.
2306 (force_auto_save_soon): Define only if SIGDANGER.
2307 (ignore_mouse_drag_p): Now static if
2308 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2309 (print_help): Remove; unused.
2310 (stop_character, last_timer_event): Mark as externally visible.
2311 * keyboard.h (ignore_mouse_drag_p): Declare only if
2312 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2313 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2314 * lisp.h (echoing): Remove decl.
2315 (force_auto_save_soon): Declare only if SIGDANGER.
2316 * xdisp.c (redisplay_window): Simplify code, to make it more
2317 obvious that ignore_mouse_drag_p is not accessed if !defined
2318 USE_GTK && !defined HAVE_NS.
2319
93ea6e8f
PE
2320 * intervals.c: Make symbols static if they're not exported.
2321 (merge_properties_sticky, merge_interval_right, delete_interval):
2322 Now static.
2323 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2324
77382fcc
PE
2325 * insdel.c: Make symbols static if they're not exported.
2326 However, leave prepare_to_modify_buffer alone. It's never
2327 called from outside this function, but that appears to be a bug.
2328 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2329 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2330 (adjust_after_replace_noundo): Remove; unused.
2331 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2332 (signal_before_change): Remove decls.
77382fcc 2333
9306c32e
PE
2334 * indent.c (val_compute_motion, val_vmotion): Now static.
2335
cd44d2eb
PE
2336 * image.c: Make symbols static if they're not exported.
2337 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2338 if USE_GTK.
2339 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2340 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2341
ad9a7a06
PE
2342 * fringe.c (standard_bitmaps): Now static.
2343 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2344
81626931
PE
2345 * frame.c: Make symbols static if they're not exported.
2346 (x_report_frame_params, make_terminal_frame): Now static.
2347 (get_frame_param): Now static, unless HAVE_NS.
2348 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2349 (x_get_resource_string): Remove; not used.
2350 * frame.h (make_terminal_frame, x_report_frame_params):
2351 (x_get_resource_string); Remove decls.
2352 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2353 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2354
239f9db9
PE
2355 * font.c, fontset.c: Make symbols static if they're not exported.
2356 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2357 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2358 * font.c (font_close_object): Now static.
2359 * font.h (font_close_object): Remove.
2360 * fontset.c (FONTSET_OBJLIST): Remove.
2361 (free_realized_fontset) #if-0 the body, which does nothing.
2362 (face_suitable_for_char_p): #if-0, as it's never called.
2363 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2364 * xfaces.c (face_at_string_position):
2365 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2366 since 0 is always ASCII.
2367
dfcf3579
PE
2368 * fns.c (weak_hash_tables): Now static.
2369
5045092b
PE
2370 * fileio.c: Make symbols static if they're not exported.
2371 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2372 (Vwrite_region_annotation_buffers): Now static.
2373
57a96f5c
PE
2374 * eval.c: Make symbols static if they're not exported.
2375 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2376 * lisp.h (backtrace_list): Remove decl.
2377
35f08c38
PE
2378 * emacs.c: Make symbols static if they're not exported.
2379 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2380 (fatal_error_code, fatal_error_signal_hook, standard_args):
2381 Now static.
2382 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2383 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2384 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2385 * lisp.h (fatal_error_signal_hook): Remove decl.
2386 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2387
f44bd759
PE
2388 * editfns.c: Move a (normally-unused) function to its only use.
2389 * editfns.c, lisp.h (get_operating_system_release): Remove.
2390 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2391 worth the hassle of breaking this out.
2392
b532497d
PE
2393 * xterm.c: Make symbols static if they're not exported.
2394 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2395 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2396 (x_destroy_window, x_delete_display):
2397 Now static.
2398 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2399 (x_mouse_leave): Remove; unused.
2400 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2401 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2402 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2403 Remove decls.
2404 (x_mouse_leave): Declare only if WINDOWSNT.
2405 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2406 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2407 USE_X_TOOLKIT.
2408
1675728f
PE
2409 * ftxfont.c: Make symbols static if they're not exported.
2410 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2411 HAVE_FREETYPE.
2412 * font.h (ftxfont_driver): Likewise.
2413
e4cebfca
PE
2414 * xfns.c: Make symbols static if they're not exported.
2415 (x_last_font_name, x_display_info_for_name):
2416 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2417 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2418 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2419 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2420 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2421 (last_show_tip_args): Now static.
2422 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2423 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2424 (x_screen_planes): Remove; unused.
2425 * dispextern.h (x_screen_planes): Remove decl.
2426
5bf46f05
PE
2427 * dispnew.c: Make symbols static if they're not exported.
2428 * dispextern.h (redraw_garbaged_frames, scrolling):
2429 (increment_row_positions): Remove.
2430 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2431 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2432 Now static.
2433 (redraw_garbaged_frames): Remove; unused.
2434
435f4c28
PE
2435 * xfaces.c: Make symbols static if they're not exported.
2436 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2437 Remove decls.
2438 * xterm.h (defined_color): Remove decls.
2439 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2440 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2441 (menu_face_changed_default, defined_color, free_realized_face):
2442 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2443 (ascii_face_of_lisp_face): Remove; unused.
2444
8524aef3
PE
2445 * xdisp.c: Make symbols static if they're not exported.
2446 * dispextern.h (scratch_glyph_row, window_box_edges):
2447 (glyph_to_pixel_coords, set_cursor_from_row):
2448 (get_next_display_element, set_iterator_to_next):
2449 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2450 (show_mouse_face): Remove decls
2451 * frame.h (message_buf_print): Likewise.
2452 * lisp.h (pop_message, set_message, check_point_in_composition):
2453 Likewise.
2454 * xterm.h (set_vertical_scroll_bar): Likewise.
2455 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2456 (message_buf_print, scratch_glyph_row, displayed_buffer):
2457 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2458 (get_next_display_element, show_mouse_face, window_box_edges):
2459 (frame_to_window_pixel_xy, check_point_in_composition):
2460 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2461 (glyph_to_pixel_coords): Remove; unused.
2462
16390cd2
PE
2463 * dired.c (file_name_completion): Now static.
2464
2465 * dbusbind.c (xd_in_read_queued_messages): Now static.
2466
a25f4dfa
PE
2467 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2468 * data.c (circular_list_error): Remove.
2469
14a9c8df
PE
2470 * commands.h (last_point_position, last_point_position_buffer):
2471 (last_point_position_window): Remove decls.
2472 * keyboard.c: Make these variables static.
2473
04f2d78b
CB
2474 * coding.h (coding, code_convert_region, encode_coding_gap):
2475 Remove decls.
74ab6df5
PE
2476 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2477 (iso_code_class, detect_coding, code_convert_region): Now static.
2478 (encode_coding_gap): Remove; unused.
2479
38dfbee1
PE
2480 * chartab.c (chartab_chars, chartab_bits): Now static.
2481
a2cb4e63
PE
2482 * charset.h (charset_iso_8859_1): Remove decl.
2483 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2484 Now static.
2485
127198fd
PE
2486 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2487 * ccl.c (Vccl_program_table): Now static.
2488 (check_ccl_update): Remove; unused.
2489
d85b608f
PE
2490 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2491 * category.h: ... from here.
2492 * category.c (check_category_table, set_category_set): Now static.
2493
31cd66f3
PE
2494 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2495 * lisp.h: Remove these decls.
2496
c358e587
PE
2497 * buffer.c (buffer_count): Remove unused var.
2498
e78aecca
PE
2499 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2500 so that it's not optimized away.
2501 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2502 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2503 exported only to the debugger.
2504
e192d7d3 2505 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2506 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2507
92470028
PE
2508 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2509 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2510 was inaccessible from Lisp.
2511 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2512 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2513
244ed907
PE
2514 alloc.c: Import and export fewer symbols, and remove unused items.
2515 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2516 is defined.
2517 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2518 it's not optimized away by whole-program optimization.
2519 (message_enable_multibyte, free_misc): Remove.
2520 (catchlist, handlerlist, mark_backtrace):
2521 Declare only if BYTE_MARK_STACK.
2522 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2523 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2524 (message_enable_multibyte): Remove decl.
2525 (free_misc, interval_free_list, float_block, float_block_index):
2526 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2527 (cons_free_list, last_marked_index):
2528 Now static.
2529 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2530 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2531 (mark_backtrace): Define only if BYTE_MARK_STACK.
2532 * xdisp.c (message_enable_multibyte): Now static.
2533
61c2b50e 2534 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2535 This makes it easier for human readers (and static analyzers)
2536 to see whether these variables are used from other modules.
2537 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2538 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2539 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2540 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2541 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2542 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2543 * xmenu.c, xselect.c:
2544 Declare Q* vars static if they are not used in other modules.
2545 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2546 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2547 Remove decls of unexported vars.
2548 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2549
95c82688
PE
2550 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2551
16a97296
PE
2552 Make Emacs functions such as Fatom 'static' by default.
2553 This makes it easier for human readers (and static analyzers)
2554 to see whether these functions can be called from other modules.
2555 DEFUN now defines a static function. To make the function external
2556 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2557 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2558 (Finit_image_library):
16a97296
PE
2559 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2560 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2561 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2562 Remove decls, since these functions are now static.
2563 (Funintern, Fget_internal_run_time): New decls, since these functions
2564 were already external.
95c82688 2565
16a97296
PE
2566 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2567 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2568 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2569 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2570 * keyboard.c, keymap.c, lread.c:
2571 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2572 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2573 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2574 Mark functions with DEFUE instead of DEFUN,
2575 if they are used in other modules.
2576 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2577 decls for now-static functions.
2578 * buffer.h (Fdelete_overlay): Remove decl.
2579 * callproc.c (Fgetenv_internal): Mark as internal.
2580 * composite.c (Fremove_list_of_text_properties): Remove decl.
2581 (Fcomposition_get_gstring): New forward static decl.
2582 * composite.h (Fcomposite_get_gstring): Remove decl.
2583 * dired.c (Ffile_attributes): New forward static decl.
2584 * doc.c (Fdocumntation_property): New forward static decl.
2585 * eval.c (Ffetch_bytecode): New forward static decl.
2586 (Funintern): Remove extern decl; now in .h file where it belongs.
2587 * fileio.c (Fmake_symbolic_link): New forward static decl.
2588 * image.c (Finit_image_library): New forward static decl.
2589 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2590 * intervals.h (Fprevious_property_change):
2591 (Fremove_list_of_text_properties): Remove decls.
2592 * keyboard.c (Fthis_command_keys): Remove decl.
2593 (Fcommand_execute): New forward static decl.
2594 * keymap.c (Flookup_key): New forward static decl.
2595 (Fcopy_keymap): Now static.
2596 * keymap.h (Flookup_key): Remove decl.
2597 * process.c (Fget_process): New forward static decl.
2598 (Fprocess_datagram_address): Mark as internal.
2599 * syntax.c (Fsyntax_table_p): New forward static decl.
2600 (skip_chars): Remove duplicate decl.
2601 * textprop.c (Fprevious_property_change): New forward static decl.
2602 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2603 Now internal.
2604 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2605 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2606
785bbd42
PE
2607 * editfns.c (Fformat): Remove unreachable code.
2608
8b913b57
AS
26092011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2610
2611 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2612 change. (Bug#8496)
2613
a6744a35
EZ
26142011-04-13 Eli Zaretskii <eliz@gnu.org>
2615
2616 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2617 when at ZV. (Bug#8487)
2618
e7974947
AS
26192011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2620
baad03f0
AS
2621 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2622 (Bug#8437)
2623 * keyboard.c (parse_tool_bar_item): Likewise.
2624 * sound.c (sound_cleanup, alsa_close): Likewise.
2625 * termcap.c (tgetent): Likewise.
2626 * xfns.c (x_default_font_parameter): Likewise.
2627 * xsettings.c (read_and_apply_settings): Likewise.
2628
e7974947
AS
2629 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2630 (overrun_check_free): Protoize.
2631
28272684
PE
26322011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2633
2634 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2635 since callers should never pass a negative size.
2636 Change the signature to match that of plain 'read' and 'write'; see
2637 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2638 * lisp.h: Update prototypes of emacs_write and emacs_read.
2639
11997c76
EZ
26402011-04-11 Eli Zaretskii <eliz@gnu.org>
2641
2642 * xdisp.c (redisplay_window): Don't try to determine the character
2643 position of the scroll margin if the window start point w->startp
e896f03c 2644 is outside the buffer's accessible region. (Bug#8468)
11997c76 2645
8a2cbd72
EZ
26462011-04-10 Eli Zaretskii <eliz@gnu.org>
2647
2648 Fix write-region and its subroutines for buffers > 2GB.
2649 * fileio.c (a_write, e_write): Modify declaration of arguments and
2650 local variables to support buffers larger than 2GB.
2651 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2652
2653 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2654 argument, local variables, and return value.
2655
2656 * lisp.h: Update prototypes of emacs_write and emacs_read.
2657
2658 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2659
4073e537 26602011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2661
1ebfdcb6
PE
2662 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2663
b2ded58d
PE
2664 Fix more problems found by GCC 4.6.0's static checks.
2665
7d66342c
PE
2666 * xdisp.c (vmessage): Use a better test for character truncation.
2667
bbf47d44
PE
2668 * charset.c (load_charset_map): <, not <=, for optimization,
2669 and to avoid potential problems with integer overflow.
9248994d 2670 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2671 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2672 * editfns.c (Fformat): Likewise.
1e69125e 2673 * syntax.c (skip_chars): Likewise.
3befa583 2674
e3019616
PE
2675 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2676 This also lets GCC 4.6.0 generate slightly better loop code.
2677
becfa255
PE
2678 * callint.c (Fcall_interactively): <, not <=, for optimization.
2679 (Fcall_interactively): Count the number of arguments produced,
2680 not the number of arguments given. This is simpler and lets GCC
2681 4.6.0 generate slightly better code.
2682
dae0cd48
PE
2683 * ftfont.c: Distingish more carefully between FcChar8 and char.
2684 The previous code passed unsigned char * to a functions like
2685 strlen and xstrcasecmp that expect char *, which does not
2686 conform to the C standard.
2687 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2688 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2689 char * when the C standard requires it.
2690
76032d70
PE
2691 * keyboard.c (read_char): Remove unused var.
2692
eb3f1cc8
PE
2693 * eval.c: Port to Windows vsnprintf (Bug#8435).
2694 Include <limits.h>.
2695 (SIZE_MAX): Define if the headers do not.
2696 (verror): Do not give up if vsnprintf returns a negative count.
2697 Instead, grow the buffer. This ports to Windows vsnprintf, which
2698 does not conform to C99. Problem reported by Eli Zaretskii.
2699 Also, simplify the allocation scheme, by avoiding the need for
2700 calling realloc, and removing the ALLOCATED variable.
2701
70476b54
PE
2702 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2703
12020a9e
PE
2704 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2705 But keep the doprint source code for now, as we might revamp it
2706 and use it again (Bug#8435).
ea6c7ae6
PE
2707 * lisp.h (doprnt): Remove.
2708 * Makefile.in (base_obj): Remove doprnt.o.
2709 * deps.mk (doprnt.o): Remove.
2710
5fdb398c
PE
2711 error: Print 32- and 64-bit integers portably (Bug#8435).
2712 Without this change, on typical 64-bit hosts error ("...%d...", N)
2713 was used to print both 32- and 64-bit integers N, which relied on
2714 undefined behavior.
2715 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2716 New macro.
2717 * lisp.h (error, verror): Mark as printf-like functions.
2718 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2719 Report overflow in size calculations when allocating printf buffer.
2720 Do not truncate output string at its first null byte.
2721 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2722 Truncate the output at a character boundary, since vsnprintf does not
2723 do that.
2724 * charset.c (check_iso_charset_parameter): Convert internal
2725 character to string before calling 'error', since %c now has the
2726 printf meaning.
2727 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2728 overflow when computing char to be passed to 'error'. Do not
2729 pass Lisp_Object to 'error'; pass the integer instead.
2730 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2731 formatted with plain %d.
2732
b189fa66
PE
2733 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2734
bff87ef0
PE
2735 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2736
7e2cac20
PE
2737 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2738
ce4d90b5
PE
2739 * xterm.c (x_catch_errors): Remove duplicate declaration.
2740
266c9547
PE
2741 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2742
79c49ad2
PE
2743 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2744
368f4090
JM
27452011-04-10 Jim Meyering <meyering@redhat.com>
2746
2747 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2748 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2749 return ssize_t not "int", and use size_t as the buffer length.
2750 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2751 * gnutls.h: Update declarations.
2752 * process.c (read_process_output): Use ssize_t, to match.
2753 (send_process): Likewise.
2754
a32d4040
CY
27552011-04-09 Chong Yidong <cyd@stupidchicken.com>
2756
2757 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2758
8546720e 27592011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2760
04f2d78b
CB
2761 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2762 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2763
8546720e
GM
2764 * xterm.c (handle_one_xevent):
2765 * xmenu.c (create_and_show_popup_menu):
2766 * xselect.c (x_decline_selection_request)
2767 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2768
0a2f5c1a 27692011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2770
2771 Fix some uses of `int' instead of EMACS_INT.
2772 * search.c (string_match_1, fast_string_match)
2773 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2774 (scan_buffer, find_next_newline_no_quit)
2775 (find_before_next_newline, search_command, Freplace_match)
2776 (Fmatch_data): Make some `int' variables be EMACS_INT.
2777
2778 * xdisp.c (display_count_lines): 3rd argument and return value now
2779 EMACS_INT. All callers changed.
2780 (pint2hrstr): Last argument is now EMACS_INT.
2781
2782 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2783 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2784 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2785 (decode_coding_utf_16, decode_coding_emacs_mule)
2786 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2787 (decode_coding_ccl, decode_coding_charset)
2788 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2789 (decode_coding_iso_2022, decode_coding_emacs_mule)
2790 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2791 <char_offset, last_offset>: Declare EMACS_INT.
2792 (encode_coding_utf_8, encode_coding_utf_16)
2793 (encode_coding_emacs_mule, encode_invocation_designation)
2794 (encode_designation_at_bol, encode_coding_iso_2022)
2795 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2796 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2797 Declare EMACS_INT.
2798 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2799 (encode_invocation_designation): Last argument P_NCHARS is now
2800 EMACS_INT.
2801 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2802 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2803
2804 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2805 All users changed.
2806
2807 * ccl.c (Fccl_execute_on_string): Declare some variables
2808 EMACS_INT.
2809
8546720e 28102011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2811
2812 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2813
4e19a977
CS
28142011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2815
2816 * process.c (Fformat_network_address): Doc fix.
2817
87302331
R
28182011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2819
2820 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2821
cbb59342
CY
28222011-04-08 Chong Yidong <cyd@stupidchicken.com>
2823
2824 * keyboard.c (read_char): Call Lisp function help-form-show,
2825 instead of using internal_with_output_to_temp_buffer.
2826 (Qhelp_form_show): New var.
e0d38eeb 2827 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2828
2829 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2830
2831 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2832
e67a13ab
CY
28332011-04-06 Chong Yidong <cyd@stupidchicken.com>
2834
04f2d78b
CB
2835 * process.c (Flist_processes): Remove to Lisp.
2836 (list_processes_1): Delete.
e67a13ab 2837
973f782d
EZ
28382011-04-06 Eli Zaretskii <eliz@gnu.org>
2839
7c106b1e
EZ
2840 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2841
973f782d
EZ
2842 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2843
41cf7d1a 28442011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2845
ca23cc88
PE
2846 Fix more problems found by GCC 4.6.0's static checks.
2847
f390e2d5
PE
2848 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2849
42eea0d0
PE
2850 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2851
b69769da 2852 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2853
f9541e84
PE
2854 * xdisp.c (vmessage): Mark as a printf-like function.
2855
13841b55
PE
2856 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2857
c136c10f
PE
2858 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2859
5e2d4a30
PE
2860 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2861 printf-like functions.
2862 (tiff_load): Add casts to remove these marks before passing them
2863 to system-supplied API.
2864
583f48b9
PE
2865 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2866
b25d760e
PE
2867 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2868 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2869 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2870 directly, rather than having caller test rule sign. This avoids
2871 some unnecessary tests.
2872 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2873 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2874 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2875
bc7b6697 2876 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2877 (xfont_open): Avoid unnecessary tests.
bc7b6697 2878
27ccc379
PE
2879 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2880
dcd5c89a
PE
2881 * composite.h, composite.c (composition_gstring_put_cache):
2882 Use EMACS_INT, not int, for length.
2883
b13a45c6
PE
2884 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2885 breaking out part of COMPOSITION_DECODE_RULE.
2886 (COMPOSITION_DECODE_RULE): Use it.
2887 * composite.c (get_composition_id): Remove unused local vars,
2888 by using the new macro.
2889
1e792e4d
PE
2890 * textprop.c (set_text_properties_1): Change while to do-while,
2891 since the condition is always true at first.
2892
dc6c6455 2893 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2894 (interval_deletion_adjustment): Return unsigned value.
2895 All uses changed.
dc6c6455 2896
aba7731a
PE
2897 * process.c (list_processes_1, create_pty, read_process_output):
2898 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2899 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2900 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2901 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2902 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2903
fdfc4bf3
PE
2904 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2905
fca8fe46 2906 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2907 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2908
06a0259a 2909 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2910 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2911 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2912
e7b9e80f
PE
2913 * print.c (print_error_message): Avoid int overflow.
2914
56201685
PE
2915 * font.c (font_list_entities): Redo for clarity,
2916 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2917
78834453 2918 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2919 (font_score): Avoid potential overflow in diff calculation.
78834453 2920
0bc0b309 2921 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2922 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2923
e610eaca
PE
2924 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2925
b895abce
PE
2926 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2927 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2928 can always succeed if overflow has undefined behavior.
2929
1f1d9321 2930 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2931 (wordify): Omit three unnecessary tests.
1f1d9321 2932
c59478bc
PE
2933 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2934 All callers changed. This avoids the need for an unused var.
2935
79b73827
PE
2936 * casefiddle.c (casify_region): Remove var that is set but not used.
2937
a4db5dfe
PE
2938 * dired.c (file_name_completion): Remove var that is set but not used.
2939
43aae36e
PE
2940 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2941
2a47c44d 2942 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2943 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2944
a37c69bf
PE
2945 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2946 Check for integer overflow on size calculations.
2947
328ab8e7
PE
2948 * buffer.c (Fprevious_overlay_change): Remove var that is set
2949 but not used.
2950
e5a2a5cb
PE
2951 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2952 Remove vars that are set but not used.
8d84a6eb 2953 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2954 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2955
a60e5f68
PE
2956 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2957
f661cb61 2958 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2959 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2960
f0397f5a
PE
2961 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2962 that are set but not used.
2963
8664db06 2964 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2965 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2966
6abdaa4a
PE
2967 * xselect.c (x_get_local_selection, x_handle_property_notify):
2968 Remove vars that are set but not used.
2969
0ce7538d 2970 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2971 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2972
9ae848fc
PE
2973 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2974 Remove var that is set but not used.
0b918413
PE
2975 (scroll_bar_windows_size): Now size_t, not int.
2976 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2977 Check for overflow.
9ae848fc 2978
a5a62657
PE
2979 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2980 (map_tty_color) [!defined MSDOS]: Likewise.
2981
5c5cdd39
PE
2982 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2983
66ebf983
PE
2984 * coding.c: Remove vars that are set but not used.
2985 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2986 All callers changed.
2987 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2988 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2989 (decode_coding_charset): Remove vars that are set but not used.
2990
1be4d761
PE
2991 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2992 that is set but not used.
2993
47553fa8
PE
2994 * print.c (print_object): Remove var that is set but not used.
2995
1f7196bf 2996 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2997 The gnulib version avoids calling malloc in the usual case,
2998 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2999 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3000 * filelock.c (current_lock_owner): Likewise.
3001 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3002 * sysdep.c: Include allocator.h, careadlinkat.h.
3003 (emacs_no_realloc_allocator): New static constant.
3004 (emacs_readlink): New function.
fdb61804
PE
3005 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3006 ../lib/careadlinkat.h.
d1fdcab7 3007
f84c17c7
SM
30082011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3009
3010 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3011 first non-nil return value).
3012
ef3862ad
JD
30132011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3014
3015 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3016 if not defined (Bug#8403).
3017
376a7006
JB
30182011-04-02 Juanma Barranquero <lekktu@gmail.com>
3019
3020 * xdisp.c (display_count_lines): Remove parameter `start',
3021 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3022 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3023 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3024 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3025 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3026 and thereabouts. All callers changed.
3027 (get_per_char_metric): Remove parameter `f', unused since
3028 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3029
6ca3801d
JM
30302011-04-02 Jim Meyering <meyering@redhat.com>
3031
3032 do not dereference NULL upon failed strdup
3033 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3034 (ns_get_family): Likewise.
3035
d8e2b5ba
JB
30362011-04-02 Juanma Barranquero <lekktu@gmail.com>
3037
3038 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3039
8c74fcbd
JD
30402011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3041
3042 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3043 later (Bug#8403).
3044
7200d79c
SM
30452011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3046
03408648 3047 Add lexical binding.
7200d79c 3048
03408648
SM
3049 * window.c (Ftemp_output_buffer_show): New fun.
3050 (Fsave_window_excursion):
3051 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3052
3053 * lread.c (lisp_file_lexically_bound_p): New function.
3054 (Fload): Bind Qlexical_binding.
3055 (readevalloop): Remove `evalfun' arg.
3056 Bind Qinternal_interpreter_environment.
3057 (Feval_buffer): Bind Qlexical_binding.
3058 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3059 Mark as dynamic.
3060 (syms_of_lread): Declare `lexical-binding'.
3061
3062 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3063
3064 * keyboard.c (eval_dyn): New fun.
3065 (menu_item_eval_property): Use it.
ca105506
SM
3066
3067 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3068
03408648
SM
3069 * fns.c (concat, mapcar1): Accept byte-code-functions.
3070
3071 * eval.c (Fsetq): Handle lexical vars.
3072 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3073 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3074 (FletX, Flet): Obey lexical binding.
3075 (Fcommandp): Handle closures.
3076 (Feval): New `lexical' arg.
3077 (eval_sub): New function extracted from Feval. Use it almost
3078 everywhere where Feval was used. Look up vars in lexical env.
3079 Handle closures.
3080 (Ffunctionp): Move from subr.el.
3081 (Ffuncall): Handle closures.
3082 (apply_lambda): Remove `eval_flags'.
3083 (funcall_lambda): Handle closures and new byte-code-functions.
3084 (Fspecial_variable_p): New function.
3085 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3086 but without exporting it to Lisp.
23aba0ea 3087
23aba0ea 3088 * doc.c (Fdocumentation, store_function_docstring):
03408648 3089 * data.c (Finteractive_form): Handle closures.
23aba0ea 3090
03408648
SM
3091 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3092 interactive spec.
ba83908c 3093
04f2d78b
CB
3094 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3095 New byte-codes.
03408648
SM
3096 (exec_byte_code): New function extracted from Fbyte_code to handle new
3097 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3098
03408648 3099 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3100
03408648 3101 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3102
e2abce01
JB
31032011-03-31 Juanma Barranquero <lekktu@gmail.com>
3104
3105 * xdisp.c (redisplay_internal): Fix prototype.
3106
63696a73 31072011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3108
63696a73 3109 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3110 (try_scrolling): Use it when setting scroll_limit.
3111 Limit scrolling to 100 screen lines.
63696a73
EZ
3112 (redisplay_window): Even when falling back on "recentering",
3113 position point in the window according to scroll-conservatively,
3114 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3115
3116 (try_scrolling): When point is above the window, allow searching
3117 as far as scroll_max, or one screenful, to compute vertical
3118 distance from PT to the scroll margin position. This prevents
3119 try_scrolling from unnecessarily failing when
3120 scroll-conservatively is set to a value slightly larger than the
3121 window height. Clean up the case of PT below the margin at bottom
3122 of window: scroll_max can no longer be INT_MAX. When aggressive
3123 scrolling is in use, don't let point enter the opposite scroll
3124 margin as result of the scroll.
3125 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3126 threshold of 100 lines for never-recentering scrolling.
3127
e4cc2dfc
JB
31282011-03-31 Juanma Barranquero <lekktu@gmail.com>
3129
3130 * dispextern.h (move_it_by_lines):
3131 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3132 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3133 (message_log_check_duplicate): Remove parameters `prev_bol' and
3134 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3135 (redisplay_internal): Remove parameter `preserve_echo_area',
3136 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3137
3138 * indent.c (Fvertical_motion):
3139 * window.c (window_scroll_pixel_based, Frecenter):
3140 Don't pass `need_y_p' to `move_it_by_lines'.
3141
1c470562
SM
31422011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3143
44f230aa
SM
3144 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3145 steal a few bits to be more compact.
3146 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3147 Remove unneeded casts.
3148
1c470562
SM
3149 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3150
888adce9
ZK
31512011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3152
3153 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3154 binding" message (bug#7967).
3155
f838ed7b
PE
31562011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3157
77861b95
PE
3158 Fix more problems found by GCC 4.6.0's static checks.
3159
de6dbc14
PE
3160 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3161 Remove unused local var.
3162
f838ed7b
PE
3163 * editfns.c (Fmessage_box): Remove unused local var.
3164
792c7b2b
PE
3165 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3166 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3167 Omit unused local vars.
c499e557 3168 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3169 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3170 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3171 Omit unused local var.
3172
ba0165e1
PE
3173 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3174 Don't assume string length fits in int.
32ad8845 3175 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3176 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3177
3c59b4c9
PE
3178 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3179 instead of alloca (Bug#8344).
3180
a3eed478 3181 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3182 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3183
eb4d412d
PE
3184 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3185
1658b401
PE
3186 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3187 concerns.
3188
3189 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3190
3191 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3192
9a2c6e05
PE
3193 * keyboard.c (syms_of_keyboard): Use the same style as later
3194 in this function when indexing through an array. This also
3195 works around GCC bug 48267.
3196
03d0a109
PE
3197 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3198
44f730c8
PE
3199 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3200
fe75f926
PE
3201 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3202 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3203
ffa8c828
PE
3204 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3205 This avoids undefined behavior on integer overflow, and is a bit
3206 more convenient anyway since it is compared to a size_t variable.
3207
c5101a77
PE
3208 Variadic C functions now count arguments with size_t, not int.
3209 This avoids an unnecessary limitation on 64-bit machines, which
3210 caused (substring ...) to crash on large vectors (Bug#8344).
3211 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3212 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3213 All variadic functions and their callers changed accordingly.
c5101a77
PE
3214 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3215 * data.c (arith_driver, float_arith_driver): Likewise.
3216 * editfns.c (general_insert_function): Likewise.
3217 * eval.c (struct backtrace.nargs, interactive_p)
3218 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3219 (funcall_lambda, mark_backtrace): Likewise.
3220 * fns.c (concat): Likewise.
3221 * frame.c (x_set_frame_parameters): Likewise.
3222 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3223 0 if not found, not -1. All callers changed.
3224
dd3f25f7
PE
3225 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3226 (stack_copy_size): Now size_t, not int.
3227 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3228
461c2ab9
JB
32292011-03-28 Juanma Barranquero <lekktu@gmail.com>
3230
3231 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3232 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3233 All callers changed.
3234
3235 * lisp.h (multibyte_char_to_unibyte):
3236 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3237 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3238 * character.h (CHAR_TO_BYTE8):
3239 * cmds.c (internal_self_insert):
3240 * editfns.c (general_insert_function):
3241 * keymap.c (push_key_description):
3242 * search.c (Freplace_match):
3243 * xdisp.c (message_dolog, set_message_1): All callers changed.
3244
f6d62986
SM
32452011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3246
3247 * keyboard.c (safe_run_hook_funcall): New function.
3248 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3249 don't set the hook to nil, but remove the offending function instead.
3250 (Qcommand_hook_internal): Remove, unused.
3251 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3252 Vcommand_hook_internal.
3253
3254 * eval.c (enum run_hooks_condition): Remove.
3255 (funcall_nil, funcall_not): New functions.
3256 (run_hook_with_args): Call each function through a `funcall' argument.
3257 Remove `cond' argument, now redundant.
3258 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3259 (Frun_hook_with_args_until_failure): Adjust accordingly.
3260 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3261
1db5b1ad
JB
32622011-03-28 Juanma Barranquero <lekktu@gmail.com>
3263
3264 * dispextern.h (string_buffer_position): Remove declaration.
3265
3266 * print.c (strout): Remove parameter `multibyte', unused since
3267 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3268
3269 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3270 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3271 All callers changed.
3272
3273 * w32.c (_wsa_errlist): Use braces for struct initializers.
3274
3275 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3276 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3277 All callers changed.
3278 (string_buffer_position): Likewise. Also, make static (it's never
3279 used outside xdisp.c).
3280 (cursor_row_p): Remove parameter `w', unused since
3281 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3282 (decode_mode_spec): Remove parameter `precision', introduced during
3283 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3284 All callers changed.
3285
5ffb62aa
JD
32862011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3287
3288 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3289
461c2ab9 32902011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3291
3292 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3293 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3294 (ns_update_auto_hide_menu_bar): New functions.
3295 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3296 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3297 ns_constrain_all_frames.
3298 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3299 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3300
5c380ffb
JD
33012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3302
3303 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3304
9af30bdf
GM
33052011-03-27 Glenn Morris <rgm@gnu.org>
3306
3307 * syssignal.h: Replace RETSIGTYPE with void.
3308 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3309 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3310 Replace SIGTYPE with void everywhere.
3311 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3312 * s/template.h (SIGTYPE): Remove commented out definition.
3313
e2abce01
JB
33142011-03-26 Eli Zaretskii <eliz@gnu.org>
3315
3316 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3317 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3318
f868cd8a
JB
33192011-03-26 Juanma Barranquero <lekktu@gmail.com>
3320
59eb0929
JB
3321 * w32.c (read_unc_volume): Use parameter `henum', instead of
3322 global variable `wget_enum_handle'.
3323
3324 * keymap.c (describe_vector): Remove parameters `indices' and
3325 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3326 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3327
f868cd8a
JB
3328 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3329
3330 * keyboard.c (timer_check): Remove parameter `do_it_now',
3331 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3332 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3333 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3334
3335 * keyboard.c (read_char):
3336 * w32menu.c (w32_menu_display_help):
3337 * xmenu.c (show_help_event, menu_help_callback):
3338 Adjust calls to `show_help_echo'.
3339
3340 * gtkutil.c (xg_maybe_add_timer):
3341 * keyboard.c (readable_events):
3342 * process.c (wait_reading_process_output):
3343 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3344
3345 * insdel.c (adjust_markers_gap_motion):
3346 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3347 (gap_left, gap_right): Don't call it.
3348
2ecf6fdb
CY
33492011-03-25 Chong Yidong <cyd@stupidchicken.com>
3350
3351 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3352 incurred during fontification.
3353
6b1f9ba4
JB
33542011-03-25 Juanma Barranquero <lekktu@gmail.com>
3355
3356 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3357 (DEFVAR_PER_BUFFER): Don't pass it.
3358
3359 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3360 (scrolling_window): Don't pass it.
3361
0f4a96b5
JB
33622011-03-25 Juanma Barranquero <lekktu@gmail.com>
3363
3364 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3365
3366 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3367 and `suffix'.
3368 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3369 of variables specific to SELinux and computation of `encoded_absname'.
3370
3371 * image.c (XPutPixel): Remove unused variable `height'.
3372
3373 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3374
3375 * unexw32.c (get_section_info): Remove unused variable `section'.
3376
3377 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3378 (system_process_attributes): Remove unused variable `sess'.
3379 (sys_read): Remove unused variable `err'.
3380
3381 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3382 (w32_wnd_proc): Remove unused variable `isdead'.
3383 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3384 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3385 (x_create_tip_frame): Remove unused variable `tem'.
3386
3387 * w32inevt.c (w32_console_read_socket):
3388 Remove unused variable `no_events'.
3389
3390 * w32term.c (x_draw_composite_glyph_string_foreground):
3391 Remove unused variable `width'.
3392
1149507c
JB
33932011-03-24 Juanma Barranquero <lekktu@gmail.com>
3394
3395 * w32term.c (x_set_glyph_string_clipping):
3396 Don't pass uninitialized region to CombineRgn.
3397
9c88f339
JB
33982011-03-23 Juanma Barranquero <lekktu@gmail.com>
3399
3400 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3401 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3402 (Fx_close_connection): Remove unused variable `i'.
3403
3404 * w32font.c (w32font_draw): Return number of glyphs.
3405 (w32font_open_internal): Remove unused variable `i'.
3406 (w32font_driver): Add missing initializer.
3407
3408 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3409 (fill_in_menu): Remove unused variable `items_added'.
3410
3411 * w32term.c (last_mouse_press_frame): Remove static global variable.
3412 (w32_clip_to_row): Remove unused variable `f'.
3413 (x_delete_terminal): Remove unused variable `i'.
3414
3415 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3416 (NOTHING): Remove unused static global variable.
3417 (uniscribe_check_otf): Remove unused variable `table'.
3418 (uniscribe_font_driver): Add missing initializers.
3419
dee091a3
JD
34202011-03-23 Julien Danjou <julien@danjou.info>
3421
3422 * term.c (Fsuspend_tty, Fresume_tty):
3423 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3424 * window.c (temp_output_buffer_show):
3425 * insdel.c (signal_before_change):
3426 * frame.c (Fhandle_switch_frame):
3427 * fileio.c (Fdo_auto_save):
3428 * emacs.c (Fkill_emacs):
3429 * editfns.c (save_excursion_restore):
3430 * cmds.c (internal_self_insert):
3431 * callint.c (Fcall_interactively):
3432 * buffer.c (Fkill_all_local_variables):
3433 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3434 Use Frun_hooks.
0f4a96b5 3435 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3436 unconditionnaly since it does the check itself.
3437
2c520ab5 34382011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3439
c9c49752
PE
3440 Fix more problems found by GCC 4.5.2's static checks.
3441
8abc3f12
PE
3442 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3443 the first time through the loop, since we know p0 < p1 then.
3444 This also avoids a gcc -Wstrict-overflow warning.
3445
a2d26660
PE
3446 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3447 leading to a memory leak, possible in functions like
3448 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3449 of objects (Bug#8318).
a2d26660 3450
916c72e9
PE
3451 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3452 that could (at least in theory) be that large.
3453
19ab8a18
PE
3454 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3455 This is less likely to overflow, and avoids undefined behavior if
3456 overflow does occur. All callers changed. Use strtoul to scan
3457 for the unsigned long integer.
b7cbbd6f
PE
3458 (pint2hrstr): Simplify and tune code slightly.
3459 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3460
f0641eff
PE
3461 * scroll.c (do_scrolling): Work around GCC bug 48228.
3462 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3463
7f650bb9
PE
3464 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3465 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3466 (validate_x_resource_name): Simplify count usage.
3467 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3468
37dd57d1
PE
3469 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3470 fail (Bug#8306).
81e56e61 3471
699979fc 3472 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3473
401bf9b4
PE
3474 * process.c (Fmake_network_process): Use socklen_t, not int,
3475 where POSIX says socklen_t is required in portable programs.
3476 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3477 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3478 (Fmake_network_process, server_accept_connection):
3479 (wait_reading_process_output, read_process_output):
3480 Likewise.
3481
b93aacde
PE
3482 * process.c: Rename or move locals to avoid shadowing.
3483 (list_processes_1, Fmake_network_process):
3484 (read_process_output_error_handler, exec_sentinel_error_handler):
3485 Rename or move locals.
4dc343ee 3486 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3487 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3488 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3489 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3490 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3491
af8a867c 3492 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3493 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3494 Include tparam.h instead, since it declares them.
af8a867c
PE
3495 * cm.h (PC): Remove extern decl; tparam.h now does this.
3496 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3497 * terminfo.c: Include tparam.h, to check interfaces.
3498 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3499 (tparam): Adjust signature to match interface in tparam.h;
3500 this removes some undefined behavior. Check that outstring and len
3501 are zero, which they always are with Emacs.
3502 * tparam.h (PC, BC, UP): New extern decls.
3503
0248044d 3504 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3505 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3506
8ff096c1 3507 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3508 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3509 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3510 (ftfont_list): Remove unused local.
49eaafba
PE
3511 (get_adstyle_property, ftfont_pattern_entity):
3512 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3513 Rename locals to avoid shadowing.
8ff096c1 3514
e2be39f6
PE
3515 * xfont.c (xfont_list_family): Mark var as initialized.
3516
c9735e30
PE
3517 * xml.c (make_dom): Now static.
3518
8f5201ae
PE
3519 * composite.c (composition_compute_stop_pos): Rename local to
3520 avoid shadowing.
b246f932
PE
3521 (composition_reseat_it): Remove unused locals.
3522 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3523 (composition_update_it): Mark var as initialized.
11b61122
PE
3524 (find_automatic_composition): Mark vars as initialized,
3525 with a FIXME (Bug#8290).
8f5201ae 3526
760fbc2c
PE
3527 character.h: Rename locals to avoid shadowing.
3528 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3529 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3530 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3531 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3532 to avoid shadowing.
3533
ff08eb85
PE
3534 * textprop.c (property_change_between_p): Remove; unused.
3535
fc7bf025
PE
3536 * intervals.c (interval_start_pos): Now static.
3537
235d7abc
PE
3538 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3539
44f230aa
SM
3540 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3541 Rename locals to avoid shadowing.
3e7d6594 3542
50060332
PE
3543 * sound.c (wav_play, au_play, Fplay_sound_internal):
3544 Fix pointer signedness.
d01f234b 3545 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3546 (wav_play): Initialize a variable to 0, to prevent undefined
3547 behavior (Bug#8278).
50060332 3548
c4fc4e30
PE
3549 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3550
918436ed
PE
3551 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3552
c939f91b
PE
3553 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3554 clobbering (Bug#8298).
b9c7f648
PE
3555 * sysdep.c (sys_subshell): Likewise.
3556 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3557
6bd8c144
PE
3558 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3559 This should get cleaned up, so that child_setup has the
3560 same signature on all platforms.
3561
7710357c 3562 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3563 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3564
c59da222
CY
35652011-03-22 Chong Yidong <cyd@stupidchicken.com>
3566
3567 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3568 not to be necessary, and produces flickering.
3569
66b87493
GM
35702011-03-20 Glenn Morris <rgm@gnu.org>
3571
3572 * config.in: Remove file.
3573
45b6f6d5
JB
35742011-03-20 Juanma Barranquero <lekktu@gmail.com>
3575
3576 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3577 are now in src/globals.h.
3578 (syms_of_minibuf): Remove spurious & from previous change.
3579
3ec03f7e
LL
35802011-03-20 Leo <sdl.web@gmail.com>
3581
3582 * minibuf.c (completing-read-function): New variable.
3583 (completing-read-default): Rename from completing-read.
3584 (completing-read): Call completing-read-function.
3585
b14e3e21
CY
35862011-03-19 Juanma Barranquero <lekktu@gmail.com>
3587
3588 * xfaces.c (Fx_load_color_file):
3589 Read color file from absolute filename (bug#8250).
3590
f2b726e6
JB
35912011-03-19 Juanma Barranquero <lekktu@gmail.com>
3592
3593 * makefile.w32-in: Update dependencies.
3594
09f6ff02
EZ
35952011-03-17 Eli Zaretskii <eliz@gnu.org>
3596
3597 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3598
29a6015a
PE
35992011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3600
a3a6c54e
PE
3601 Fix more problems found by GCC 4.5.2's static checks.
3602
b766f867
PE
3603 * process.c (make_serial_process_unwind, send_process_trap):
3604 (sigchld_handler): Now static.
3605
be02381c
PE
3606 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3607 That way, the code declares only the vars that it needs.
3608 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3609 * s/cygwin.h (PTY_ITERATION): Likewise.
3610 * s/darwin.h (PTY_ITERATION): Likewise.
3611 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3612
57048744
PE
3613 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3614 * process.c (allocate_pty): Don't declare stb unless it's needed.
3615
7914961c 3616 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3617 (CONSTANTLIM): Remove; unused.
3618 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3619 Define only if needed.
7914961c 3620
b3967b18
PE
3621 * unexelf.c (unexec): Name an expression,
3622 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3623 Use a different way to cause a compilation error if anyone uses
3624 n rather than nn, a way that does not involve shadowing.
73366a00 3625 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3626
29a6015a
PE
3627 * deps.mk (unexalpha.o): Remove; unused.
3628
43cfc33e 3629 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3630 * unexec.h: New file.
ce701a33
PE
3631 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3632 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3633 Depend on unexec.h.
3634 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3635 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3636 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3637 Change as necessary to match prototype in unexec.h.
ce701a33 3638
01f44d5a
PE
3639 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3640 shadowing.
4f63c6bb 3641 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3642
a6670b0b
PE
3643 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3644 Rename locals to avoid shadowing.
3645
cef2010d 3646 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3647 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3648
d4d7173a
PE
3649 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3650
f08b802a
PE
3651 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3652 warning when compiling print.c.
3653
3ddb0639
PE
3654 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3655 instead of using an uninitialized var.
5ad03b97 3656 (font_sort_entities): Mark var as initialized.
3ddb0639 3657
170a2692
PE
3658 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3659
e663c700
PE
3660 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3661 pointers to constants.
89bc529a 3662 (font_parse_fcname): Remove unused vars.
7b81e2d0 3663 (font_delete_unmatched): Now static.
ea838e10 3664 (font_get_spec): Remove; unused.
13a547c6
PE
3665 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3666 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3667 Rename or move locals to avoid shadowing.
e663c700 3668
2a80c887 3669 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3670 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3671
1384fa33 3672 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3673 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3674
8b2c52e9
PE
3675 * alloc.c (mark_backtrace): Move decl from here ...
3676 * lisp.h: ... to here, so that it can be checked.
3677
475545b5 3678 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3679 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3680 (lisp_indirect_variable): Name an expression,
3681 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3682 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3683
b1349114 3684 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3685 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3686 Use const pointer when appropriate.
b1349114 3687
a2928364
PE
3688 * lisp.h (get_system_name, get_operating_system_release):
3689 Move decls here, to check interfaces.
3690 * process.c (get_operating_system_release): Move decl to lisp.h.
3691 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3692 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3693 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3694 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3695 (Fformat_time_string, Fencode_time, Finsert_char):
3696 (Ftranslate_region_internal, Fformat):
3697 Rename or remove local vars to avoid shadowing.
9710023e 3698 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3699
a415e694
PE
3700 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3701 avoid shadowing.
3702
8ef4622d
PE
3703 * lisp.h (eassert): Check that the argument compiles, even if
3704 ENABLE_CHECKING is not defined.
3705
946f9a5b
PE
3706 * data.c (Findirect_variable): Name an expression, to avoid
3707 gcc -Wbad-function-cast warning.
112396d6 3708 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3709 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3710 (Fmake_variable_buffer_local, Fmake_local_variable):
3711 Mark variables as initialized.
52746918 3712 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3713
e5aab7e7 3714 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3715 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3716 Rename locals to avoid shadowing.
dff45157
PE
3717 (mark_stack): Move local variables into the #ifdef region where
3718 they're used.
7bc26fdb
PE
3719 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3720 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3721 needed otherwise.
3722 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3723 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3724 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3725
e5aab7e7
PE
3726 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3727 avoids undefined behavior in theory.
3728
4da60324
PE
3729 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3730
88043301
PE
3731 Use functions, not macros, for up- and down-casing (Bug#8254).
3732 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3733 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3734 to use the following functions instead of these macros.
3735 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3736 EMACS_INT, since callers assume the returned value fits in int.
3737 (upcase1): Likewise, for UPCASE_TABLE.
3738 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3739 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3740 the race-condition problem in the old DOWNCASE.
88043301 3741
19ed5445
PE
3742 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3743 Rename locals to avoid shadowing.
3744 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3745 (regex_compile, re_search_2, re_match_2_internal):
3746 Remove unused local vars.
952db0d7
PE
3747 (FREE_VAR): Rewrite so as not to use empty "else",
3748 which gcc can warn about.
da053e48 3749 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3750 (RETALLOC_IF): Define only if needed.
3751 (WORDCHAR_P): Likewise. This one is never needed, but is used
3752 only in a comment talking about a compiler bug, so put inside
3753 the #if 0 of that comment.
3754 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3755 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3756 Remove; unused.
19ed5445 3757
1f3561e4 3758 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3759 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3760 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3761
ded6f8f7
PE
3762 * search.c (simple_search): Remove unused var.
3763
dbd37a95
PE
3764 * dired.c (compile_pattern): Move decl from here ...
3765 * lisp.h: ... to here, so that it can be checked.
3766 (struct re_registers): New forward decl.
3767
7e47afad
PE
3768 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3769
85f24f61
PE
3770 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3771 All uses changed.
3772 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3773 Rename locals to avoid shadowing.
5671df8f 3774 (Fvertical_motion): Mark locals as initialized.
85f24f61 3775
181aa2be 3776 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3777 (casify_region): Mark local as initialized.
181aa2be 3778
930d429c
PE
3779 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3780
7082eac6
PE
3781 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3782 New macros, so that the caller can use some names other than
3783 gcpro1, gcpro2, etc.
3784 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3785 of the new macros.
3786 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3787 argument, for consistency with GCPRO2_VAR, etc: it is now the
3788 prefix of the variable, not the variable itself. All uses
3789 changed.
38b2c076
PE
3790 * dired.c (directory_files_internal, file_name_completion):
3791 Rename locals to avoid shadowing.
3792
15206ed9
PE
3793 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3794 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3795 dired.c's scmp function, had undefined behavior.
3796 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3797 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3798 * buffer.h: ... to here, because these macros use current_buffer,
3799 and the new implementation with inline functions needs to have
3800 current_buffer in scope now, rather than later when the macros
3801 are used.
3802 (downcase, upcase1): New static inline functions.
3803 (DOWNCASE, UPCASE1): Reimplement using these functions.
3804 This avoids undefined behavior in expressions like
3805 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3806 from race conditions in accessing the global variables
3807 case_temp1 and case_temp2.
3808 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3809 * lisp.h (case_temp1, case_temp2): Remove their decls.
3810 * character.h (ASCII_CHAR_P): Move from here ...
3811 * lisp.h: ... to here, so that the inline functions mentioned
3812 above can use them.
3813
4a6bea26
PE
3814 * dired.c (directory_files_internal_unwind): Now static.
3815
f14b7e14
PE
3816 * fileio.c (file_name_as_directory, directory_file_name):
3817 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3818 Now static.
2893f146
PE
3819 (file_name_as_directory): Use const pointers when appropriate.
3820 (Fexpand_file_name): Likewise. In particular, newdir might
3821 point at constant storage, so make it a const pointer.
fd4ead52 3822 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3823 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3824 signedness issues.
f839df0c
PE
3825 (Fset_file_times, Finsert_file_contents, auto_save_error):
3826 Rename locals to avoid shadowing.
f14b7e14 3827
5716756e 3828 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3829 (Ftry_completion, Fall_completions): Rename or remove locals
3830 to avoid shadowing.
5716756e 3831
b4c3046a
PE
3832 * marker.c (bytepos_to_charpos): Remove; unused.
3833
b45db522
PE
3834 * lisp.h (verify_bytepos, count_markers): New decls,
3835 so that gcc does not warn that these functions aren't declared.
3836
85876d07
PE
3837 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3838 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3839 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3840 (copy_text): Remove unused local var.
85876d07 3841
03d78a21 3842 * filelock.c (within_one_second): Now static.
b3dd38ab 3843 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3844
5df8f01b
PE
3845 * buffer.c (fix_overlays_before): Mark locals as initialized.
3846 (fix_start_end_in_overlays): Likewise. This function should be
3847 simplified by using pointers-to-pointers, but that's a different
3848 matter.
b1d876f1 3849 (switch_to_buffer_1): Now static.
8f54f30a
PE
3850 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3851 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3852
a70072c9 3853 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3854 Fix pointer signedness issue.
edced198
PE
3855 (sys_subshell): Mark local as volatile if checking for lint,
3856 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3857 (MAXPATHLEN): Define only if needed.
a70072c9 3858
a0977c44
PE
3859 * process.c (serial_open, serial_configure): Move decls from here ...
3860 * systty.h: ... to here, so that they can be checked.
3861
a884fdcc
PE
3862 * fns.c (get_random, seed_random): Move extern decls from here ...
3863 * lisp.h: ... to here, so that they can be checked.
3864
604efe86 3865 * sysdep.c (reset_io): Now static.
b8950c94 3866 (wait_for_termination_signal): Remove; unused.
604efe86 3867
38fc62d9
PE
3868 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3869 (copy_keymap_item, append_key, push_text_char_description):
3870 Now static.
1004a21a 3871 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3872 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3873 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3874 (describe_map_tree):
3875 Rename locals to avoid shadowing.
38fc62d9 3876
2f2650da
PE
3877 * keyboard.c: Declare functions static if they are not used elsewhere.
3878 (echo_char, echo_dash, cmd_error, top_level_2):
3879 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3880 (read_char, kbd_buffer_get_event, make_lispy_position):
3881 (make_lispy_event, make_lispy_movement, apply_modifiers):
3882 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3883 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3884 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3885 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3886 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3887
a053e86c 3888 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3889 (mark_kboards): Move decl here ...
3890 * alloc.c (mark_kboards): ... from here.
a053e86c 3891
4752793e
PE
3892 * lisp.h (force_auto_save_soon): New decl.
3893
74f10ca7 3894 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3895 (DEFINE_DUMMY_FUNCTION): New macro.
3896 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3897 Use it.
c03cd23f
PE
3898 (main): Add casts to avoid warnings
3899 if GCC considers string literals to be constants.
74f10ca7 3900
022e70d4
PE
3901 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3902
59d6fe83
PE
3903 * dbusbind.c: Pointer signedness fixes.
3904 (xd_signature, xd_append_arg, xd_initialize):
3905 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3906 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3907 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3908 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3909
78320123
PE
3910 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3911 if GCC considers string literals to be constants.
49cebcca 3912 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3913
35ac2a97
SM
39142011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3915
fb103ca9
SM
3916 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3917 (print_preprocess, print_object): New macro to fix last change.
3918
35ac2a97
SM
3919 * print.c (print_preprocess): Don't forget font objects.
3920
62973b41
JB
39212011-03-16 Juanma Barranquero <lekktu@gmail.com>
3922
3923 * emacs.c (USAGE3): Doc fixes.
3924
0e48bb22
AS
39252011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3926
3927 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3928 structure.
3929
7684e57b
JB
39302011-03-14 Juanma Barranquero <lekktu@gmail.com>
3931
3932 * lisp.h (VWindow_system, Qfile_name_history):
3933 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3934 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3935 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3936
3937 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3938 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3939
3940 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3941 * w32console.c (detect_input_pending, read_input_pending)
3942 (encode_terminal_code):
3943 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3944 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3945 (w32_system_caret_y, Qfile_name_history):
3946 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3947 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3948 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3949 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3950 * w32proc.c (Qlocal, report_file_error):
3951 * w32term.c (Vwindow_system, updating_frame):
3952 * w32uniscribe.c (initialized, uniscribe_font_driver):
3953 Remove unneeded extern declarations.
3954
2aa46d6c
CY
39552011-03-14 Chong Yidong <cyd@stupidchicken.com>
3956
c96bbc66 3957 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3958
cffc6f3b
CY
39592011-03-13 Chong Yidong <cyd@stupidchicken.com>
3960
3961 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3962 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3963 These macros can no longer be used for assignment.
3964
44f230aa
SM
3965 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3966 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3967 (record_buffer_markers, fetch_buffer_markers): New functions for
3968 recording and fetching special buffer markers.
3969 (set_buffer_internal_1, set_buffer_temp): Use them.
3970
3971 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3972
3973 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3974
3975 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3976 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3977
3978 * xdisp.c (hscroll_window_tree):
3979 (reconsider_clip_changes): Use PT instead of BUF_PT.
3980
d251f04b
EZ
39812011-03-13 Eli Zaretskii <eliz@gnu.org>
3982
3983 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3984 $(EMACS_ROOT)/lib/intprops.h.
3985
f0c77cd1
PE
39862011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3987
3eca4629
PE
3988 Fix more problems found by GCC 4.5.2's static checks.
3989
7c86ee98
PE
3990 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3991 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3992 (xg_free_frame_widgets): Make it clear that a local variable is
3993 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3994 (gdk_window_get_screen): Make it clear that this macro is needed
3995 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3996 (int_gtk_range_get_value): New function, which avoids a diagnostic
3997 from gcc -Wbad-function-cast.
3998 (xg_set_toolkit_scroll_bar_thumb): Use it.
3999 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4000 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4001 (get_utf8_string, xg_get_file_with_chooser):
4002 Rename locals to avoid shadowing.
4003 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4004
41729b81
PE
4005 * xgselect.c (xg_select): Remove unused var.
4006
f0c77cd1
PE
4007 * image.c (four_corners_best): Mark locals as initialized.
4008 (gif_load): Initialize transparent_p to zero (Bug#8238).
4009 Mark another local as initialized.
ec6cf4c6 4010 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4011
ce0ad53d 4012 * image.c (clear_image_cache): Now static.
d5d5a617 4013 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4014 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4015 (x_edge_detection): Remove unnecessary cast that
4016 gcc -Wbad-function-cast diagnoses.
2037898d 4017 (gif_load): Fix pointer signedness.
6ae141d6
PE
4018 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4019 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4020
33383987 40212011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4022
d32df629
PE
4023 Improve quality of tests for time stamp overflow.
4024 For example, without this patch (encode-time 0 0 0 1 1
4025 1152921504606846976) returns the obviously-bogus value (-948597
4026 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4027 reports time overflow. See
4028 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4029 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4030 * editfns.c: Include limits.h and intprops.h.
4031 (TIME_T_MIN, TIME_T_MAX): New macros.
4032 (time_overflow): Move earlier, to before first use.
4033 (hi_time, lo_time): New functions, for an accurate test for
4034 out-of-range times.
4035 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4036 (Fget_internal_run_time): Don't assume time_t fits in int.
4037 (make_time): Use list2 instead of Fcons twice.
4038 (Fdecode_time): More accurate test for out-of-range times.
4039 (check_tm_member): New function.
4040 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4041 (lisp_time_argument): Don't rely on undefined left-shift and
4042 right-shift behavior when checking for time stamp overflow.
8be6f318 4043
fe31d94c
PE
4044 * editfns.c (time_overflow): New function, refactoring common code.
4045 (Fformat_time_string, Fdecode_time, Fencode_time):
4046 (Fcurrent_time_string): Use it.
4047
8be6f318
PE
4048 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4049 * dired.c (make_time): Move to ...
4050 * editfns.c (make_time): ... here.
4051 * systime.h: Note the move.
4052
09d9db2c 40532011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4054
126bc0dc
YM
4055 * fringe.c (update_window_fringes): Remove unused variables.
4056
c47cbdfd
YM
4057 * unexmacosx.c (copy_data_segment): Also copy __got section.
4058 (Bug#8223)
4059
7ac80be9
EZ
40602011-03-12 Eli Zaretskii <eliz@gnu.org>
4061
c96bbc66 4062 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4063 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4064 Constify `char *' arguments and their references according to
4065 prototypes in tparam.h.
4066
ecb0f94d 4067 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4068
7ac80be9
EZ
4069 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4070 Adapt all references accordingly.
4071
4072 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4073
ef1fd07e
TT
40742011-03-11 Tom Tromey <tromey@redhat.com>
4075
4076 * buffer.c (syms_of_buffer): Remove obsolete comment.
4077
7ef4b50c
EZ
40782011-03-11 Eli Zaretskii <eliz@gnu.org>
4079
4080 * termhooks.h (encode_terminal_code): Declare prototype.
4081
4082 * msdos.c (encode_terminal_code): Don't declare prototype.
4083
4084 * term.c (encode_terminal_code): Now external again, used by
4085 w32console.c and msdos.c.
4086
44f230aa
SM
4087 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4088 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4089
4b1ec863 40902011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4091
1714f52b 4092 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4093
4b1ec863
PE
4094 * fringe.c (update_window_fringes): Mark locals as initialized
4095 (Bug#8227).
4096 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4097
524c7aa6
PE
4098 * alloc.c (mark_fringe_data): Move decl from here ...
4099 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4100 to check its interface.
4101 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4102
a5c0af81 4103 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4104 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4105 (fontset_font): Mark local as initialized.
a9a06e0b 4106 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4107
b4716021
PE
4108 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4109
811e9bac 4110 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4111 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4112 (x_own_selection, Fx_disown_selection_internal): Rename locals
4113 to avoid shadowing.
4114 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4115
7e3ab302
PE
4116 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4117 so that the caller can use some name other than gcpro1.
4118 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4119 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4120 (Fx_backspace_delete_keys_p):
4121 Use them to avoid shadowing, and rename vars to avoid shadowing.
4122 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4123 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4124 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4125 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4126 Remove unused locals.
7e3ab302
PE
4127 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4128 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4129 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4130 macros.
f78faa98 4131
e2b13473
PE
4132 * xterm.h (x_mouse_leave): New decl.
4133
77f23912
PE
4134 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4135 Remove unused functions.
cdf4ba58
PE
4136 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4137 (x_calc_absolute_position): Now static.
7411c686 4138 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4139 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4140 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4141 unless they are used.
38d0b34a
PE
4142 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4143 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4144 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4145 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4146 (x_error_catcher, x_connection_closed, x_error_handler):
4147 (x_error_quitter, xembed_send_message, x_iconify_frame):
4148 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4149 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4150 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4151
44f230aa
SM
4152 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4153 Rename or move locals to avoid shadowing.
6b463e58 4154 (tty_defined_color, merge_face_heights): Now static.
5967d051 4155 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4156 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4157 does not deduce is never used uninitialized.
73719eba
PE
4158 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4159 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4160
426994c3 4161 * terminal.c (store_terminal_param): Now static.
5489860b 4162
032f1620 4163 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4164 (set_frame_menubar): Remove unused local.
d4323972 4165 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4166 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4167 since they might point to immutable storage.
281585b0
PE
4168 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4169 since it's unused otherwise.
032f1620 4170
367c19e5 4171 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4172 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4173 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4174 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4175 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4176 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4177 does not deduce are never used uninitialized.
70739cbe 4178
07b48fa9
PE
4179 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4180
8868a238 4181 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4182 * window.c (window_loop, size_window):
4183 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4184
7e5cf297 4185 * window.c (display_buffer): Now static.
d6550a9f
PE
4186 (size_window): Mark variables that gcc -Wuninitialized
4187 does not deduce are never used uninitialized.
a586633d
PE
4188 * window.h (check_all_windows): New decl, to forestall
4189 gcc -Wmissing-prototypes diagnostic.
5b555da1 4190 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4191
f6095868
PE
4192 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4193 shadowing.
4194 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4195 Include <limits.h>.
4196 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4197 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4198 (load_charset_map): Mark variables that gcc -Wuninitialized
4199 does not deduce are never used uninitialized.
53df7c11 4200 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4201
f38b440c
PE
4202 * coding.c (coding_set_source, coding_set_destination):
4203 Use "else { /* comment */ }" rather than "else /* comment */;"
4204 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4205 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4206 a block, when the outer 'i' will do.
4207 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4208 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4209 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4210 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4211 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4212 Rename locals to avoid shadowing.
4213 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4214 * coding.c (emacs_mule_char, encode_invocation_designation):
4215 Now static, since they're not used elsewhere.
413bb2db 4216 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4217 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4218 (decode_coding_emacs_mule): Mark variables that gcc
4219 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4220 (detect_coding_iso_2022): Initialize a local variable that might
4221 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4222 this initialization is needed. (Bug#8211)
5f58e762
PE
4223 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4224 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4225 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4226 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4227 Remove unused macros.
f38b440c 4228
232b38b9 4229 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4230 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4231 * character.c (string_count_byte8): Likewise.
232b38b9 4232
fb90da1b
PE
4233 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4234 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4235
fb93dbc2
PE
4236 * chartab.c (copy_sub_char_table): Now static, since it's not used
4237 elsewhere.
5c156ace
PE
4238 (sub_char_table_ref_and_range, char_table_ref_and_range):
4239 Rename locals to avoid shadowing.
bbcd0949 4240 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4241
7d3b3862 4242 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4243 (BIDI_BOB): Remove unused macro.
7d3b3862 4244
6be7d3da
PE
4245 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4246 deduce are never used uninitialized.
c2ed9c8b 4247 * term.c (encode_terminal_code): Likewise.
6be7d3da 4248
75f8807f 4249 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4250
50938595
PE
4251 * tparam.h: New file.
4252 * term.c, tparam.h: Include it.
4253 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4254 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4255 Move these decls to tparam.h, and make them agree with what
4256 is actually in tparam.c. The previous trick of using incompatible
4257 decls in different modules does not conform to the C standard.
4258 All callers of tparam changed to use tparam's actual API.
4259 * tparam.c (tparam1, tparam, tgoto):
4260 Use const pointers where appropriate.
4261
fbceeba2
PE
4262 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4263 * cm.h (struct cm): Likewise.
4264 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4265 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4266 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4267 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4268 (turn_on_face, init_tty): Likewise.
4269 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4270
7f3f1250
PE
4271 * term.c (term_mouse_position): Rename local to avoid shadowing.
4272
e6ca6543
PE
4273 * alloc.c (mark_ttys): Move decl from here ...
4274 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4275
c40f8d15
AS
42762011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4277
4278 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4279
cfe0661d
JB
42802011-03-09 Juanma Barranquero <lekktu@gmail.com>
4281
4282 * search.c (compile_pattern_1): Remove argument regp, unused since
4283 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4284 (compile_pattern): Don't pass it.
4285
0afb4571
J
42862011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4287
4288 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4289 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4290 for ! HAVE_GTK3.
4291 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4292
4293 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4294
4295 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4296 gdk_window_get_screen, gdk_window_get_geometry,
4297 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4298 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4299 (xg_get_pixbuf_from_pixmap): New function.
4300 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4301 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4302 Call xg_get_pixbuf_from_pixmap instead of
4303 gdk_pixbuf_get_from_drawable.
4304 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4305 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4306 (xg_check_special_colors): Use GtkStyleContext and its functions
4307 for HAVE_GTK3.
4308 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4309 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4310 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4311 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4312 Call gtk_widget_get_preferred_size.
0afb4571
J
4313 (xg_frame_resized): gdk_window_get_geometry only takes 5
4314 parameters.
44f230aa
SM
4315 (xg_win_to_widget, xg_event_is_for_menubar):
4316 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4317 (xg_set_widget_bg): New function.
4318 (delete_cb): New function.
895009e1 4319 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4320 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4321 (xg_set_background_color): Call xg_set_widget_bg.
4322 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4323 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4324 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4325 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4326 if ! HAVE_GTK3.
4327 (update_frame_tool_bar): Call gtk_widget_hide.
4328 (xg_initialize): Use GDK_KEY_g.
4329
4330 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4331 if ! HAVE_GTK3
4332 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4333
4334 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4335 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4336 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4337
1c2cc4ef
JB
43382011-03-08 Juanma Barranquero <lekktu@gmail.com>
4339
4340 * w32xfns.c (select_palette): Check success of RealizePalette against
4341 GDI_ERROR, not zero.
4342
33383987 4343See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4344
4345;; Local Variables:
4346;; coding: utf-8
aac0c6e3
MR
4347;; End:
4348
33383987 4349 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4350
4351 This file is part of GNU Emacs.
4352
4353 GNU Emacs is free software: you can redistribute it and/or modify
4354 it under the terms of the GNU General Public License as published by
4355 the Free Software Foundation, either version 3 of the License, or
4356 (at your option) any later version.
4357
4358 GNU Emacs is distributed in the hope that it will be useful,
4359 but WITHOUT ANY WARRANTY; without even the implied warranty of
4360 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4361 GNU General Public License for more details.
4362
4363 You should have received a copy of the GNU General Public License
4364 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.