Fix compilation with --enable-gcc-warnings and -O1
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8ce70ed2
DA
12012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Fix compilation with --enable-gcc-warnings and -O1
4 optimization level.
5 * doprnt.c (doprnt): Change type of tem to int, initialize
6 to avoid compiler warning. Add eassert.
7 * search.c (simple_search): Initialize match_byte to avoid
8 compiler warning. Add eassert.
9
dea7f1e5
PE
102012-07-04 Paul Eggert <eggert@cs.ucla.edu>
11
24a212eb
PE
12 Avoid weird behavior with large horizontal scrolls.
13 Without this change, for example, large hscroll values would
14 mess up Emacs's display on Fedora 15 x86, presumably due to
15 overflows in int calculations in the display code.
16 Also, if buffers had long lines, Emacs would freeze.
17 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
18 (set_window_hscroll): New function, containing the old guts of
19 Fset_window_hscroll. Return the clipped value.
20 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
21 This avoids the need to check against PTRDIFF_MAX.
22
dea7f1e5
PE
23 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
24
76046526
DA
252012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
26
27 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
28
39adff0d
PE
292012-07-04 Paul Eggert <eggert@cs.ucla.edu>
30
63807d47
PE
31 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
32 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
33 since GCC 4.4.6 issues a bogus warning for them.
34
39adff0d
PE
35 Fix bugs in file timestamp newness comparisons.
36 * fileio.c (Ffile_newer_than_file_p):
37 * lread.c (Fload): Use full timestamp resolution of files,
38 not just the 1-second resolution, so that files that are only
39 slightly newer still count as newer.
40 * fileio.c (Ffile_newer_than_file_p): Don't assume file
41 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
42
dbeed9a6
PE
432012-07-03 Paul Eggert <eggert@cs.ucla.edu>
44
45 * fileio.c: Improve handling of file time marker. (Bug#11852)
46 (special_mtime): New function.
47 (Finsert_file_contents, Fverify_visited_file_modtime):
48 Use it to set special mtime values consistently.
49
636334d6
AS
502012-07-03 Andreas Schwab <schwab@linux-m68k.org>
51
52 * fileio.c (Finsert_file_contents): Properly handle st_mtime
53 marker for non-existing file. (Bug#11852)
54
e2017fe2
GM
552012-07-03 Glenn Morris <rgm@gnu.org>
56
57 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
58 and did not make it into globals.h).
59
404dbd37
TT
602012-07-03 Tom Tromey <tromey@redhat.com>
61
62 * window.c (Fset_window_margins, Fset_window_fringes)
63 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
64 * textprop.c (Fprevious_property_change): No longer static.
65 * syntax.c (Fsyntax_table_p): No longer static.
66 * process.c (Fget_process, Fprocess_datagram_address): No longer
67 static.
68 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
69 * keyboard.c (Fcommand_execute): No longer static.
70 Remove EXFUN.
71 * insdel.c (Fcombine_after_change_execute): No longer static.
72 * image.c (Finit_image_library): No longer static.
73 * fileio.c (Fmake_symbolic_link): No longer static.
74 * eval.c (Ffetch_bytecode): No longer static.
75 * editfns.c (Fuser_full_name): No longer static.
76 * doc.c: (Fdocumentation_property, Fsnarf_documentation): No
77 longer static.
78 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
79 static.
80 * dired.c (Ffile_attributes): No longer static.
81 * composite.c (Fcomposition_get_gstring): No longer static.
82 * callproc.c (Fgetenv_internal): No longer static.
83
84 * ccl.h: Remove EXFUNs.
85 * buffer.h: Remove EXFUNs.
86 * dispextern.h: Remove EXFUNs.
87 * intervals.h: Remove EXFUNs.
88 * fontset.h: Remove EXFUN.
89 * font.h: Remove EXFUNs.
90 * dosfns.c (system_process_attributes): Remove EXFUN.
91 * keymap.h: Remove EXFUNs.
92 * lisp.h: Remove EXFUNs.
93 * w32term.h: Remove EXFUNs.
94 * window.h: Remove EXFUNs.
95 * xsettings.h: Remove EXFUN.
96 * xterm.h: Remove EXFUN.
97
8e4fd1e1
GM
982012-07-03 Glenn Morris <rgm@gnu.org>
99
100 * lisp.h (Frandom): Make it visible to C.
101 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
102 buffer for invisible buffers. (Bug#1229)
103
ca95b3eb
DA
1042012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
105
106 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
107 values which aren't power of 2.
108 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
109 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
110 accordingly.
111
7555c33f
SM
1122012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
113
114 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
115
116 * alloc.c (mark_object): Revert part of last patch to use `switch'.
117
d12e8f5a
DA
1182012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
119
120 * alloc.c (allocate_vector_block): Remove redundant
121 calls to mallopt if DOUG_LEA_MALLOC is defined.
122 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
123 avoid calls to mallopt if zero_vector is returned.
124
296094c3
DA
1252012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
126
127 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
128 is enabled, avoid dereferencing NULL current_sblock if
129 running undumped.
130
36429c89
DA
1312012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
132
133 Cleanup basic buffer management.
134 * buffer.h (struct buffer): Change layout to use generic vector
135 marking code. Fix some comments. Change type of 'clip_changed'
136 to bitfield. Remove unused #ifndef old.
137 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
138 (GET_OVERLAYS_AT): Fix indentation.
139 (for_each_per_buffer_object_at): New macro.
140 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
141 (Fbuffer_local_variables): Use it.
142 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
143 * alloc.c (allocate_buffer): Adjust to match new layout of
144 struct buffer. Fix comment.
145 (mark_overlay): New function.
146 (mark_buffer): Use it. Use mark_vectorlike to mark normal
147 Lisp area of struct buffer.
148 (mark_object): Use it. Adjust marking of misc objects
149 and related comments.
150
3b3e4cac
PE
1512012-07-02 Paul Eggert <eggert@cs.ucla.edu>
152
153 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
154 wrapper that is not needed because the wrapped code is a no-op (zero
155 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
156 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
157
cf5c0175
DA
1582012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
159
160 * alloc.c (mark_buffer): Simplify. Remove prototype.
161 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 162 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
163 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
164 redundant calls to mark_vectorlike for bool vectors.
165
ca26824c
GM
1662012-06-30 Glenn Morris <rgm@gnu.org>
167
2e4c5312
GM
168 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
169
ca26824c
GM
170 * epaths.in (PATH_SITELOADSEARCH): New.
171 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
172 This is rather than relying on --enable-locallisppath elements
173 having "site-lisp" in their names. (Bug#10208#25, 11658)
174
0d23c240
EZ
1752012-06-30 Eli Zaretskii <eliz@gnu.org>
176
c9240d7a
EZ
177 * w32proc.c (sys_select): Accept and ignore one more argument.
178
179 * w32.c (emacs_gnutls_pull): Call select with one more argument.
180
0d23c240 181 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 182 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
183
184 * sysdep.c: Don't include dos.h and dosfns.h.
185
186 * process.c (sys_select):
187 * msdos.c (sys_select): Accept one more argument and ignore it.
188
189 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
190 adapt data types and code to that.
191
192 * dosfns.c:
193 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
194 which clashes with the gnulib function of the same name.
195
af5a5a98
AS
1962012-06-30 Andreas Schwab <schwab@linux-m68k.org>
197
c5e4379c
AS
198 * font.c (font_style_to_value, font_style_symbolic)
199 (font_prop_validate_style): Add type checks for values in
200 font_style_table.
201
af5a5a98
AS
202 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
203 argument.
204 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
205 uses.
206
8d38f461
EZ
2072012-06-29 Eli Zaretskii <eliz@gnu.org>
208
2e5a6631
EZ
209 * xdisp.c (try_window_id): Undo last change.
210
8d38f461
EZ
211 * w32.c (getwd): Adjust commentary about startup_dir.
212 (init_environment): Always call sys_access, even in non-MSVC
213 builds. Don't chdir to the directory of the Emacs executable.
214 This undoes code from 1997 which was justified by the need to
215 "avoid conflicts when removing and renaming directories". But its
216 downside was that every relative file name was being interpreted
217 relative to the directory of the Emacs executable, which can never
218 be TRT. In particular, it broke sys_access when called with
219 relative file names.
220 (sys_access): Map GetLastError to errno.
221
2af3565e
DA
2222012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
223
224 * window.h (struct window): Change type of 'fringes_outside_margins'
225 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 226 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
227 Adjust comment.
228 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
229 to ptrdiff_t.
230
c8d3a25c 2312012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 232
c8d3a25c
GM
233 * gnutls.c (emacs_gnutls_handshake):
234 Add QUIT to make the loop interruptible.
57570cd3 235
c8d3a25c 2362012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 237
c8d3a25c
GM
238 * charset.c (init_charset): Make lack of etc/charsets fatal.
239
3e984ee8
DA
2402012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
241
242 * editfns.c (region_limit): Fix type mismatch.
243
ef884f23
DA
2442012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
245
246 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
247 undefined. Convert from xassert to eassert.
248 * nsmenu.m: Convert from xassert to eassert.
249 * nsterm.m: Likewise.
250
7d7e0027
SM
2512012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
252
253 * editfns.c (region_limit): Clip to narrowing (bug#11770).
254
aa754e6a
PE
2552012-06-28 Paul Eggert <eggert@cs.ucla.edu>
256
257 Avoid integer overflow on scroll-left and scroll-right.
258 * window.c (HSCROLL_MAX): New macro.
259 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
260 overflow when requested scroll falls outside ptrdiff_t range.
261
80b00b08
DA
2622012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
263
264 * window.h (struct window): Change type of 'hscroll',
265 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
266 'last_modified' and 'last_overlay_modified' to EMACS_INT.
267 Adjust users accordingly.
268 * xdisp.c (try_cursor_movement): Replace type check with eassert.
269 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
270 from EMACS_INT to ptrdiff_t.
271 (make_window): Omit redundant initialization.
272
62b2bcf6
JB
2732012-06-28 Juanma Barranquero <lekktu@gmail.com>
274
275 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
276
45942c7d
DA
2772012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
278
279 * window.h (struct window): Change type of 'use_time' and
280 'sequence_number' from Lisp_Object to int.
281 * frame.c (make_frame): Adjust users accordingly.
282 * print.c (print_object): Likewise.
283 * window.c (select_window, Fwindow_use_time, make_parent_window)
284 (make_window): Likewise.
285
e509cfa6
DA
2862012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
287
288 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
289 enabled with --enable-checking=[all,glyphs] configure option.
290 Fix GLYPH_DEBUG usage assuming that it may be undefined,
291 adjust comments accordingly.
292 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
293 undefined, adjust comments accordingly.
294 * image.c: Likewise.
295 * scroll.c: Likewise.
296 * w32fns.c: Likewise.
297 * w32term.c: Likewise.
298 * xdisp.c: Likewise.
299 * xfaces.c: Likewise.
300 * xfns.c: Likewise.
301 * xterm.c: Likewise.
302
a54e2c05
DA
3032012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
304
305 Generalize run-time debugging checks.
306 * dispextern.h (XASSERTS): Remove.
307 * fontset.c (xassert): Remove.
308 Convert from xassert to eassert.
309 * alloc.c: Convert from xassert to eassert.
310 * bidi.c: Likewise.
311 * dispnew.c: Likewise.
312 * fns.c: Likewise.
313 * fringe.c: Likewise.
314 * ftfont.c: Likewise.
315 * gtkutil.c: Likewise.
316 * image.c: Likewise.
317 * keyboard.c: Likewise.
318 * menu.c: Likewise.
319 * process.c: Likewise.
320 * scroll.c: Likewise.
321 * sound.c: Likewise.
322 * term.c: Likewise.
323 * w32console.c: Likewise.
324 * w32fns.c: Likewise.
325 * w32term.c: Likewise.
326 * window.c: Likewise.
327 * xdisp.c: Likewise.
328 * xfaces.c: Likewise.
329 * xfns.c: Likewise.
330 * xselect.c: Likewise.
331 * xterm.c: Likewise.
332
1ec4b7b2
SM
3332012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
334
335 * fns.c (maybe_resize_hash_table): Output message when growing the
336 purify-hashtable.
337
2014308a
DA
3382012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
339
340 * alloc.c (allocate_string_data): Remove dead code.
341 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
342 avoid GCC warning about unused macro.
343
246155eb
DA
3442012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
345
346 * alloc.c (allocate_string): Omit intervals initialization.
347 * alloc.c (make_uninit_multibyte_string): Initialize intervals
348 as in make_pure_string and make_pure_c_string.
349
43184b7b
DA
3502012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
351
352 * alloc.c (allocate_string): Fix last change.
353
3fe6dd74
DA
3542012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
355
356 * alloc.c (allocate_string): Remove two redundant calls
357 to memset, add explicit initialization where appropriate.
358
1ba6038a
GM
3592012-06-27 Glenn Morris <rgm@gnu.org>
360
361 * lisp.mk (lisp): Remove paths.elc.
362
c89926a5
CY
3632012-06-27 Chong Yidong <cyd@gnu.org>
364
365 * doc.c (Fsubstitute_command_keys): Fix punctuation.
366
ed6b3510
JW
3672012-06-26 John Wiegley <johnw@newartisans.com>
368
1ec4b7b2 369 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
370 on Mac OS X Lion: __mod_init_func and __mod_term_func.
371
ed6b3510
JW
372 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
373 when building with Clang.
374
8edd4a2b
SM
3752012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
376
377 * eval.c (Fapply): Allow calling it with a single argument.
378
f6f62d1b
EZ
3792012-06-26 Eli Zaretskii <eliz@gnu.org>
380
381 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
382 _stricmp and _strnicmp.
383 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
384
62efea5e
DA
3852012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
386
387 * alloc.c (allocate_window): Zero out non-Lisp part of newly
388 allocated window.
389 (allocate_process): Likewise for new process.
8edd4a2b 390 (allocate_terminal): Change to use offsetof.
62efea5e
DA
391 (allocate_frame): Likewise.
392 * frame.c (make_frame): Omit redundant initialization.
393 * window.c (make_parent_window): Use memset.
394 (make_window): Omit redundant initialization.
395 * process.c (make_process): Omit redundant initialization.
396 * terminal.c (create_terminal): Likewise.
397
42997f4d
DA
3982012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
399
400 * term.c (delete_tty): Remove redundant call to memset.
401
1130ecfc
DA
4022012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
403
404 * alloc.c: Remove build_string.
405 * lisp.h: Define build_string as static inline. This provides
406 a better opportunity to optimize away calls to strlen when the
407 function is called with compile-time constant argument.
408 * image.c (imagemagick_error): Convert to build_string.
409 * w32proc.c (sys_spawnve): Likewise.
410 * xterm.c (x_term_init): Likewise.
411
cf38a720
PE
4122012-06-26 Paul Eggert <eggert@cs.ucla.edu>
413
99027bdd
PE
414 Use sprintf return value instead of invoking strlen on result.
415 In the old days this wasn't portable, since some sprintf
416 implementations returned char *. But they died out years ago and
417 Emacs already assumes sprintf returns int.
418 Similarly for float_to_string.
419 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
420 * ccl.c (ccl_driver):
421 * character.c (string_escape_byte8):
422 * data.c (Fnumber_to_string):
423 * doprnt.c (doprnt):
424 * print.c (print_object):
425 * xdisp.c (message_dolog):
426 * xfns.c (syms_of_xfns):
427 Use sprintf or float_to_string result to avoid need to call strlen.
428 * data.c (Fnumber_to_string):
429 Use make_unibyte_string, since the string must be ASCII.
430 * lisp.h, print.c (float_to_string): Now returns int length.
431 * term.c (produce_glyphless_glyph):
432 Use sprintf result rather than recomputing it.
433
cf38a720
PE
434 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
435 * Makefile.in (ALL_CFLAGS):
436 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
437 * gmalloc.c, regex.c: Include <config.h> unconditionally.
438
3511c784
DA
4392012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
440
0a08eb21 441 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
442 strcasecmp if available.
443 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
444
fb7da12e
AS
4452012-06-25 Andreas Schwab <schwab@linux-m68k.org>
446
447 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
448 Avoid comma operator.
449 * menu.c (push_submenu_start, push_submenu_end)
450 (push_left_right_boundary, push_menu_pane): Likewise.
451 * msdos.c (dos_rawgetc): Likewise.
452
afa2ffd8
DA
4532012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
454
455 * xfns.c (xic_create_fontsetname): Remove redundant calls
456 to memset.
457
b3b4476b
PE
4582012-06-25 Paul Eggert <eggert@cs.ucla.edu>
459
4495ff38
PE
460 * gtkutil.c (get_utf8_string): Remove redundant assignment.
461 sprintf already null-terminates its output.
462
b3b4476b
PE
463 * xfns.c (x_window): Remove redundant cast.
464
b00876c9
DA
4652012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
466
467 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
468 `const char *' to `char *' to avoid compiler warning.
469
d188e26b
PE
4702012-06-24 Paul Eggert <eggert@cs.ucla.edu>
471
885d1d74
PE
472 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
473 instead of truncating it to 63 (admittedly a generous limit).
474
d188e26b
PE
475 * process.c: Fix spelling and caps in comments.
476
e2f560b1
DN
4772012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
478
e86db54b 479 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
480 * sysdep.c (setpgrp): Remove definition, not used in this file.
481
7583a3a1
JB
4822012-06-24 Juanma Barranquero <lekktu@gmail.com>
483
484 * makefile.w32-in: Update dependencies.
485
696056c2
EZ
4862012-06-24 Eli Zaretskii <eliz@gnu.org>
487
488 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
489 (SYSTIME_H): Add nt/inc/sys/time.h.
490
491 * systime.h [WINDOWSNT]: Include sys/time.h.
492
493 * s/ms-w32.h (struct timespec): Definition moved from
494 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
495
845ca893
PE
4962012-06-24 Paul Eggert <eggert@cs.ucla.edu>
497
498 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
499 * buffer.h (buffer_slot_type_mismatch):
500 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
501 * eval.c (unwind_to_catch):
502 * image.c (my_png_error, my_error_exit):
503 * keyboard.c (quit_throw_to_read_char, user_error)
504 (Fexit_recursive_edit, Fabort_recursive_edit):
505 * lisp.h (die, args_out_of_range, args_out_of_range_3)
506 (wrong_type_argument, buffer_overflow, __executable_start)
507 (memory_full, buffer_memory_full, string_overflow, Fthrow)
508 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
509 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
510 (fatal):
511 (child_setup) [!DOS_NT]:
512 * lread.c (end_of_file_error, invalid_syntax):
513 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
514 * puresize.h (pure_write_error):
515 * search.c (matcher_overflow):
516 * sound.c (sound_perror, alsa_sound_perror):
517 * sysdep.c, syssignal.h (croak):
518 * term.c (maybe_fatal, vfatal):
519 * textprop.c (text_read_only):
520 * undo.c (user_error):
521 * unexmacosx.c (unexec_error):
522 * xterm.c (x_ins_del_lines, x_delete_glyphs):
523 Use _Noreturn rather than NO_RETURN.
524 No need for separate decl merely because of _Noreturn.
525 * sound.c (sound_warning, parse_sound):
526 Remove unnecessary forward decls.
527
f1dd8073
PE
5282012-06-24 Paul Eggert <eggert@cs.ucla.edu>
529
530 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
531 * lisp.h (WAIT_READING_MAX): New macro.
532 * dispnew.c (Fsleep_for, sit_for):
533 * keyboard.c (kbd_buffer_get_event):
534 * process.c (Faccept_process_output):
535 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
536 This improves on the previous patch, which introduced a bug
537 when time_t is unsigned and as wide as intmax_t.
538 See <http://bugs.gnu.org/9000#51>.
539
b82c1755
EZ
5402012-06-23 Eli Zaretskii <eliz@gnu.org>
541
542 * dispnew.c (sit_for, Fsleep_for):
543 * keyboard.c (kbd_buffer_get_event):
544 * process.c (Faccept_process_output): Avoid compiler warnings when
545 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
546
ca300656
JB
5472012-06-23 Juanma Barranquero <lekktu@gmail.com>
548
049ec95b
JB
549 * makefile.w32-in: Update dependencies.
550
ca300656
JB
551 * w32.c (ltime): Add return type and declare static.
552 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
553
db7b8d06
PE
5542012-06-23 Paul Eggert <eggert@cs.ucla.edu>
555
556 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
557 Privately reported by Herbert J. Skuhra.
558 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
559 All uses changed.
560 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
561 not make_lisp_timeval, when the argument is of type EMACS_TIME.
562
0bd8297f
EZ
5632012-06-23 Eli Zaretskii <eliz@gnu.org>
564
96512555
EZ
565 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
566 last argument of make_unibyte_string.
567
0bd8297f
EZ
568 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
569 language ID in the event parameters.
570
571 * w32term.c (w32_read_socket): Put the new keyboard codepage into
572 event.code, not the obscure "character set ID".
573
63def6b6
CY
5742012-06-23 Chong Yidong <cyd@gnu.org>
575
576 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
577
e8a02204
EZ
5782012-06-23 Eli Zaretskii <eliz@gnu.org>
579
388cdec0
EZ
580 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
581 * w32.c (fdutimens): New function.
582
583 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
584
585 * s/ms-w32.h (pselect): Redirect to sys_select.
586
587 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
588
e8a02204
EZ
589 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
590 in the logic of incrementing and decrementing the value of
591 use_relocatable_buffers.
592
d054f3fb
PE
5932012-06-23 Paul Eggert <eggert@cs.ucla.edu>
594
595 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
596 Privately reported by Herbert J. Skuhra.
597 [__FreeBSD__]: Remove "*/" typo after "#include".
598 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
599 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
600 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
601 Don't assume EMACS_TIME and struct timeval are the same type.
602
d35af63c
PE
6032012-06-22 Paul Eggert <eggert@cs.ucla.edu>
604
605 Support higher-resolution time stamps (Bug#9000).
606 The time stamps are only nanosecond-resolution at the C level,
607 since that's the best that any real-world system supports now.
608 But they are picosecond-resolution at the Lisp level, as that's
609 easy, and leaves room for future OS improvements.
610
611 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
612 (LIBES): Use it.
613
614 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
615 Don't get current time unless it's needed.
616
617 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
618 now provides it if it's absent.
619 (start_atimer): Port to higher-res time stamps.
620 Check for time stamp overflow. Don't get current time more
621 often than is needed.
622
623 * buffer.h (struct buffer): Buffer modtime now has high resolution.
624 Include systime.h, not time.h.
625 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
626
627 * dired.c: Include stat-time.h.
628 (Ffile-attributes): File times now have higher resolution.
629
630 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
631 (struct image): Timestamp now has higher resolution.
632
633 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
634 has at least microseconds now. All uses removed.
635 (update_frame, update_single_window, update_window, update_frame_1)
636 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
637
638 * editfns.c (time_overflow): Now extern.
639 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
640 (float-time, Fformat_time_string, Fcurrent_time_string)
641 (Fcurrent_time_zone): Accept and generate higher-resolution
642 time stamps.
643 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
644 (decode_time_components, lisp_seconds_argument): New functions.
645 (make_time): Now static.
646 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
647 Report an error if the time is invalid, rather than having the caller
648 do that.
649
650 * fileio.c: Include <stat-time.h>
651 (Fcopy_file): Copy higher-resolution time stamps.
652 Prefer to set the time stamp via a file descriptor if that works.
653 (Fset_file_times, Finsert_file_contents, Fwrite_region)
654 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
655 (Fvisited_file_modtime, Fset_visited_file_modtime):
656 Support higher-resolution time stamps.
657
658 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
659
660 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
661
662 * image.c (prepare_image_for_display, clear_image_cache)
663 (lookup_image): Port to higer-resolution time stamps.
664
665 * keyboard.c (start_polling, bind_polling_period):
666 Check for time stamp overflow.
667 (read_char, kbd_buffer_get_event, timer_start_idle)
668 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
669 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
670 Port to higher-resolution time stamps. Do not assume time_t is signed.
671 (decode_timer): New function. Timers are now vectors of length 9,
672 not 8, to accommodate the picosecond component.
673 (timer_check_2): Use it.
674
675 * nsterm.m (select_timeout, timeval_subtract): Remove.
676 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
677 as they're a bit more accurate and handle overflow better.
678 (ns_select): Change prototype to be compatible with pselect.
679 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
680 * nsterm.h (ns_select): Adjust prototype.
681
682 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
683 us-resolution time stamps.
684 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
685
686 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
687
688 * lisp.h (time_overflow): New decl.
689 (wait_reading_process_output): First arg is now intmax_t, not int,
690 to accommodate larger waits.
691
692 * process.h (struct Lisp_Process.read_output_delay):
693 Now counts nanoseconds, not microseconds.
694 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
695 EMACS_HAS_USECS.
696 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
697 (wait_reading_process_output):
698 Port to ns-resolution time stamps.
699 (Faccept_process_output, wait_reading_process_output):
700 Check for time stamp overflow. Do not assume time_t is signed.
701 (select_wrapper): Remove; we now use pselect.
702 (Fprocess_attributes): Now generates ns-resolution time stamps.
703
704 * sysdep.c: Include utimens.h. Don't include utime.h
705 or worry about struct utimbuf; gnulib does that for us now.
706 (gettimeofday): Remove; gnulib provides a substitute.
707 (make_timeval): New function.
708 (set_file_times): Now sets ns-resolution time stamps.
709 New arg FD; all uses changed.
710 (time_from_jiffies, ltime_from_jiffies, get_up_time)
711 (system_process_attributes):
712 Now returns ns-resolution time stamp. All uses changed.
713 Check for time stamp overflow.
714
715 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
716 provides a substitute now.
717
718 * systime.h: Include timespec.h rather than sys/time.h and time.h,
719 since it guarantees struct timespec.
720 (EMACS_TIME): Now struct timespec, so that we can support
721 ns-resolution time stamps.
722 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
723 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
724 (EMACS_USECS): Remove.
725 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
726 so multiply the arg by 1000 before storing it.
727 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
728 New macros.
729 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
730 Port to ns-resolution time stamps.
731 (EMACS_TIME_NEG_P): Remove; replaced by....
732 (EMACS_TIME_SIGN): New macro.
733 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
734 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
735 (set_file_times, make_time, lisp_time_argument): Adjust signature.
736 (make_timeval, make_lisp_time, decode_time_components): New decls.
737 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
738 that it mishandled time_t overflow. You can't compare by subtracting!
739 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
740 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
741
742 * term.c: Include <sys/time.h>.
743 (timeval_to_Time): New function, for proper overflow wraparound.
744 (term_mouse_position, term_mouse_click): Use it.
745
746 * undo.c (record_first_change): Support higher-resolution time stamps
747 in the undo buffer.
748 (Fprimitive_undo): Use them when restoring time stamps.
749
750 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
751 (w32_get_internal_run_time):
752 Port to higher-resolution Emacs time stamps.
753 (ltime): Now accepts single 64-bit integer, as that's more convenient
754 for callers.
755
756 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
757
758 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
759 for compatibility with pselect. Support ns-resolution time stamps.
760
761 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
762
763 * xselect.c (wait_for_property_change, x_get_foreign_selection):
764 Check for time stamp overflow, and support ns-resolution time stamps.
765
766 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
767 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
768 (timeval_subtract): Remove; no longer needed.
769 (XTflash, XTring_bell, x_wait_for_event):
770 Port to ns-resolution time stamps. Don't assume time_t is signed.
771
b6a92dfe
CY
7722012-06-22 Chong Yidong <cyd@gnu.org>
773
774 * xdisp.c (x_consider_frame_title): Revert last change.
775
d251c37c
EZ
7762012-06-22 Eli Zaretskii <eliz@gnu.org>
777
778 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
779 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
780 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
781 staticidx goes up to 1597 out of 1600 = 0x640.)
782
f10deafb
PE
7832012-06-20 Paul Eggert <eggert@cs.ucla.edu>
784
785 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
786 Otherwise, the umask might be mistakenly 0 while handling input signals.
787
ec6de1e2
SM
7882012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
789
790 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
791
28be1ada
DA
7922012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
793
794 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
795 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
796 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
797 access to `contents' member of Lisp_Vector objects with AREF and ASET
798 where appropriate.
799
c6bf3022
CY
8002012-06-19 Chong Yidong <cyd@gnu.org>
801
802 * frame.c (delete_frame): When selecting a frame on a different
803 text terminal, do not alter the terminal's top-frame.
804
805 * xdisp.c (format_mode_line_unwind_data): Record the target
806 frame's selected window and its terminal's top-frame.
807 (unwind_format_mode_line): Restore them.
808 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
809 Callers changed.
810 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
811 since tty frames can be explicitly named.
812 (prepare_menu_bars): Likewise.
813
814 * term.c (Ftty_top_frame): New function.
815
defd4196
PE
8162012-06-18 Paul Eggert <eggert@cs.ucla.edu>
817
818 Port byte-code-meter to modern targets.
819 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
820 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 821 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
822 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
823 (METER_1, METER_2): Simplify.
824
1053a871
SM
8252012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
826
827 * data.c (Fdefalias): Return `symbol' (bug#11686).
828
b7e8d081
MR
8292012-06-18 Martin Rudalics <rudalics@gmx.at>
830
831 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
832 gets killed during executing of this function (Bug#11665).
833 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
834 (Vkill_buffer_query_functions): In doc-string say that functions
835 run by this hook should not change the current buffer.
836
7ea2b339
PE
8372012-06-18 Paul Eggert <eggert@cs.ucla.edu>
838
839 Fix recently-introduced process.c problems found by static checking.
840 * process.c (write_queue_push, write_queue_pop, send_process):
841 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
842 (write_queue_pop): Fix pointer signedness problem.
843 (send_process): Remove unused local.
844
96a313a1
CY
8452012-06-17 Chong Yidong <cyd@gnu.org>
846
847 * xdisp.c (redisplay_internal): No need to redisplay terminal
848 frames that are not on top.
849
20ca2e94
TN
8502012-06-17 Troels Nielsen <bn.troels@gmail.com>
851
852 * process.c (make_process): Initialize write_queue.
853 (write_queue_push, write_queue_pop): New functions.
854 (send_process): Use them to maintain correct ordering of process
855 writes (Bug#10815).
856
9a900ca9
PE
8572012-06-17 Paul Eggert <eggert@cs.ucla.edu>
858
310fbfa8
PE
859 * lisp.h (eassert): Assume C89 or later.
860 This removes the need for CHECK.
861 (CHECK): Remove. Its comments about always evaluating its
862 argument were confusing, as 'eassert' typically does not evaluate
863 its argument.
864
27bb1ca4
PE
865 * coding.c (produce_chars): Use ptrdiff_t, not int.
866
9a900ca9
PE
867 * xterm.c (x_draw_underwave): Check for integer overflow.
868 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
869
41b7f8bc 8702012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
871
872 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
873 referenced (Bug#11583).
874
9b0e3eba
AA
8752012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
876
877 Implement wave-style variant of underlining.
878 * dispextern.h (face_underline_type): New enum.
879 (face): Add field for underline type.
880 * nsterm.m (ns_draw_underwave): New function.
881 (ns_draw_text_decoration): Use it.
882 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
883 New functions.
884 (x_draw_glyph_string): Use them.
885 * xfaces.c (Qline, Qwave): New Lisp objects.
886 (check_lface_attrs, merge_face_ref)
1053a871
SM
887 (Finternal_set_lisp_face_attribute, realize_x_face):
888 Handle wave-style underline face attributes.
9b0e3eba
AA
889 * xterm.c (x_draw_underwave): New function.
890 (x_draw_glyph_string): Use it.
891
0fb52f11
JB
8922012-06-16 Juanma Barranquero <lekktu@gmail.com>
893
894 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
895 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
896 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
897 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
898 ($(BLD)/w32select.$(O)): Update dependencies.
899
e5560ff7
AS
9002012-06-16 Andreas Schwab <schwab@linux-m68k.org>
901
902 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
903 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
904 * character.c (_fetch_multibyte_char_p): Remove.
905 * alloc.c: Include "character.h" before "buffer.h".
906 * bidi.c: Likewise.
907 * buffer.c: Likewise.
908 * bytecode.c: Likewise.
909 * callint.c: Likewise.
910 * callproc.c: Likewise.
911 * casefiddle.c: Likewise.
912 * casetab.c: Likewise.
913 * category.c: Likewise.
914 * cmds.c: Likewise.
915 * coding.c: Likewise.
916 * composite.c: Likewise.
917 * dired.c: Likewise.
918 * dispnew.c: Likewise.
919 * doc.c: Likewise.
920 * dosfns.c: Likewise.
921 * editfns.c: Likewise.
922 * emacs.c: Likewise.
923 * fileio.c: Likewise.
924 * filelock.c: Likewise.
925 * font.c: Likewise.
926 * fontset.c: Likewise.
927 * fringe.c: Likewise.
928 * indent.c: Likewise.
929 * insdel.c: Likewise.
930 * intervals.c: Likewise.
931 * keyboard.c: Likewise.
932 * keymap.c: Likewise.
933 * lread.c: Likewise.
934 * macros.c: Likewise.
935 * marker.c: Likewise.
936 * minibuf.c: Likewise.
937 * nsfns.m: Likewise.
938 * nsmenu.m: Likewise.
939 * print.c: Likewise.
940 * process.c: Likewise.
941 * regex.c: Likewise.
942 * region-cache.c: Likewise.
943 * search.c: Likewise.
944 * syntax.c: Likewise.
945 * term.c: Likewise.
946 * textprop.c: Likewise.
947 * undo.c: Likewise.
948 * unexsol.c: Likewise.
949 * w16select.c: Likewise.
950 * w32fns.c: Likewise.
951 * w32menu.c: Likewise.
952 * window.c: Likewise.
953 * xdisp.c: Likewise.
954 * xfns.c: Likewise.
955 * xmenu.c: Likewise.
956 * xml.c: Likewise.
957 * xselect.c: Likewise.
958
2f07e6af
EZ
9592012-06-16 Eli Zaretskii <eliz@gnu.org>
960
1053a871
SM
961 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
962 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 963 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
964 row.
965 (handle_face_prop): Use chunk-relative overlay string index when
966 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
967 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
968 the rightmost. (Bug#11720)
2f07e6af 969
29b83cec
AS
9702012-06-16 Andreas Schwab <schwab@linux-m68k.org>
971
972 * category.h (CHAR_HAS_CATEGORY): Define as inline.
973 (CATEGORY_MEMBER): Enforce 1/0 value.
974 * category.c (_temp_category_set): Remove.
975
4c5501e9
EZ
9762012-06-16 Eli Zaretskii <eliz@gnu.org>
977
978 * window.c (Fdelete_other_windows_internal)
979 (Fdelete_window_internal): Don't access frame's mouse highlight
980 info of the initial frame. (Bug#11677)
981
2b570124
PE
9822012-06-14 Paul Eggert <eggert@cs.ucla.edu>
983
e93864f9
PE
984 * .gdbinit (xgetint): Fix recently-introduced paren typo.
985 Assume USE_2_TAGS_FOR_INTS.
986 (xreload): Adjust $tagmask width to match recent lisp.h change.
987
2b570124
PE
988 Simplify lisp.h in minor ways that should not affect code.
989 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
990 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
991 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
992 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
993 (INTTYPEBITS): New macro, for clarity.
994 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
995 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
996 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
997 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
998 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
999
81755f69
JB
10002012-06-13 Juanma Barranquero <lekktu@gmail.com>
1001
1002 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1003
16192a57
GM
10042012-06-13 Glenn Morris <rgm@gnu.org>
1005
1006 * s/bsd-common.h (BSD4_3):
1007 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1008
646b5f55
AS
10092012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1010
1011 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1012 instead of union.
1013 (XLI, XIL): Define.
1053a871
SM
1014 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1015 Use them.
1016 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1017 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1018 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1019 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1020 * frame.c (delete_frame): Remove outdated comment.
1021 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1022 USE_LISP_UNION_TYPE.
1023 (Fw32_unregister_hot_key): Likewise.
1024 (Fw32_toggle_lock_key): Likewise.
1025 * w32menu.c (add_menu_item): Likewise.
1026 (w32_menu_display_help): Use XIL instead of checking
1027 USE_LISP_UNION_TYPE.
1028 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1029 (init_heap): Likewise.
1030 * w32term.c (w32_read_socket): Update comment.
1031
1d3823c9
GM
10322012-06-13 Glenn Morris <rgm@gnu.org>
1033
c62ff706
GM
1034 * s/usg5-4-common.h, src/s/unixware.h:
1035 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1036
1d3823c9
GM
1037 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1038
bfe3e0a2
PE
10392012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1040
1041 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1042 * alloc.c (make_number) [!defined make_number]:
1043 Remove, as lisp.h always defines this now.
1044 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1045 (roundup_size): Verify that it is a power of 2.
1046 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1047 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1048 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1049 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1050 USE_LSB_TAG now is always defined to be either 0 or 1.
1051 All uses changed.
1052 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1053 code works fine either way, and efficiency is not a concern here,
1054 as the union type is for debugging, not for production.
1055 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1056 Use an inline function on all platforms when using the union type,
1057 since this is simpler and 'static inline' can be used portably
1058 within Emacs now.
1059 (LISP_INITIALLY_ZERO): New macro.
1060 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1061 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1062
45fa9c0f
GM
10632012-06-12 Glenn Morris <rgm@gnu.org>
1064
b4492cba
GM
1065 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1066
1067 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1068
45fa9c0f
GM
1069 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1070 Move BROKEN_SIGIO to configure.
1071
1072 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1073 Move NO_TERMIO to configure.
1074
0e25d334
CY
10752012-06-12 Chong Yidong <cyd@gnu.org>
1076
1077 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1078 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1079 MagickExportImagePixels is undefined.
1080
43682bb6
PE
10812012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1082
1083 * image.c (imagemagick_load_image): Remove unused label.
1084
a9be7d2b
GM
10852012-06-11 Glenn Morris <rgm@gnu.org>
1086
1087 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1088 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1089 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1090 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1091
3017f87f
SM
10922012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1093
1094 * alloc.c (make_byte_code): New function.
1095 (Fmake_byte_code): Use it. Don't purify here.
1096 * lread.c (read1): Use it as well to avoid extra allocation.
1097
1b9b4cf4
CY
10982012-06-11 Chong Yidong <cyd@gnu.org>
1099
1100 * image.c (imagemagick_load_image): Implement transparency.
1101
95988fcf
AS
11022012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1103
1104 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1105 account for preceding backslashes. (Bug#11663)
1106
cd4eb164
CY
11072012-06-09 Chong Yidong <cyd@gnu.org>
1108
1109 * term.c: Support italics in capable terminals (Bug#9652).
1110 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1111 (turn_on_face): Output using TS_enter_italic_mode if available.
1112 Don't handle unused blinking and alt-charset cases.
1113 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1114 and tty_alt_charset_p cases.
1115 (tty_capable_p, init_tty): Support italics.
1116
1117 * termchar.h (struct tty_display_info): Add field for italics.
1118 Remove unused blink field.
1119
1120 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1121 Handle slant.
1122
1123 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1124 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1125 tty_alt_charset_p. Add tty_italic_p.
1126
ff88beb8
MA
11272012-06-09 Michael Albinus <michael.albinus@gmx.de>
1128
1129 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1130 dbus_type_is_basic if available.
1131 (xd_extract_signed, xd_extract_unsigned): Rename from
1132 extract_signed and extract_unsigned, respectively. Adapt callers.
1133
44286096
CY
11342012-06-09 Chong Yidong <cyd@gnu.org>
1135
1682701f
CY
1136 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1137
44286096
CY
1138 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1139 case (Bug#9752).
1140
d86feb17
PE
11412012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1142
1143 * xdisp.c (vmessage): Treat frame message as multibyte.
1144 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1145 would generate the diagnostic "Making \302\247 buffer-local while
1146 let-bound!".
1147
d5c20fe8
EZ
11482012-06-08 Eli Zaretskii <eliz@gnu.org>
1149
1150 * dispnew.c (showing_window_margins_p): Undo last change, which
1151 was done due to an inadvertent commit.
1152 (adjust_frame_glyphs_for_frame_redisplay): Do call
1153 showing_window_margins_p.
1154
513749ee
SM
11552012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1156
1157 * eval.c (Fmake_var_non_special): New primitive.
1158 (syms_of_eval): Defsubr it.
1159 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1160
d4a8f5c1
JB
11612012-06-08 Juanma Barranquero <lekktu@gmail.com>
1162
1163 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1164 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1165
8bbbc977
EZ
11662012-06-08 Eli Zaretskii <eliz@gnu.org>
1167
1168 * alloc.c (allocate_vectorlike): Fix last change.
1169
f3372c87
DA
11702012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1171
1172 Block-based vector allocation of small vectors.
1173 * lisp.h (struct vectorlike_header): New field `nbytes',
1174 adjust comment accordingly.
1175 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1176 to denote vector blocks. Adjust users (live_vector_p,
1177 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1178 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1179 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1180 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1181 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1182 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1183 (roundup_size): New constant.
1184 (struct vector_block): New data type.
1185 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1186 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1187 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1188 (sweep_vectors): New functions.
1189 (allocate_vectorlike): Return `zero_vector' as the only vector of
1190 0 items. Allocate new vector from block if vector size is less than
1191 or equal to VBLOCK_BYTES_MAX.
1192 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1193 (init_alloc_once): Add call to init_vectors.
1194
4f18a4ed
SM
11952012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1196
1197 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1198
86f158bc
PE
11992012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 * doprnt.c (doprnt): Truncate multibyte char correctly.
1202 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1203 would mishandle a string argument "Xc" if X was a multibyte
1204 character of length 2: it would truncate after X's first byte
1205 rather than including all of X.
1206
c5cfcbe0
CY
12072012-06-06 Chong Yidong <cyd@gnu.org>
1208
1209 * buffer.c (word_wrap): Doc fix.
1210
c05cf390
PE
12112012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1212
1213 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1214
0c3461de
GM
12152012-06-03 Glenn Morris <rgm@gnu.org>
1216
1217 * xdisp.c (tool-bar-style): Doc fix.
1218
c71232db
UM
12192012-06-03 Ulrich Müller <ulm@gentoo.org>
1220
1221 * Makefile.in (PAXCTL): Define.
1222 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1223 binary via PaX flags if the paxctl utility is available.
1224 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1225 Restore PaX flags to their default. (Bug#11398)
1226
383f7350
CY
12272012-06-03 Chong Yidong <cyd@gnu.org>
1228
1229 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1230 buffer (Bug#11226).
1231
5f2c76c6
CY
12322012-06-03 Chong Yidong <cyd@gnu.org>
1233
1234 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1235 (note_mode_line_or_margin_highlight): If there is no help echo,
1236 use mode-line-default-help-echo. Handle the case where the mouse
1237 position is past the end of the mode line string.
1238
1239 * buffer.c (buffer_local_value_1): New function, split from
1240 Fbuffer_local_value; can return Qunbound.
1241 (Fbuffer_local_value): Use it.
1242 (Vmode_line_format): Docstring tweaks.
1243
773d47f6
PE
12442012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1245
1246 * sysdep.c (system_process_attributes): Improve comment.
1247
f2d6a3df
SM
12482012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1249
1250 * keyboard.c: Export real-this-command to Elisp.
1251 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1252 and DEFVAR it. Update all users.
1253
63810350
PE
12542012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1255
7bd5c1f4
PE
1256 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1257
63810350
PE
1258 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1259 Convert pctcpu and pctmem to Lisp float properly.
1260 Let the compiler fold better, as 100.0/0x8000 is exact.
1261
a2821611
AS
12622012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1263
1264 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1265 cons_block.
1266
5fceba1d
PE
12672012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1268
1269 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1270
c98ff5dd
DA
12712012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1272
1273 For a 'struct window', replace some Lisp_Object fields to
1274 bitfields where appropriate, remove unused fields.
1275 * window.h (struct window): Remove unused 'last_mark_x' and
1276 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1277 change it's type from Lisp_Object to bitfield.
1278 Change type of 'force_start', 'optional_new_start',
1279 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1280 fields from Lisp_Object to bitfield. Adjust users accordingly.
1281
ca34e0be
PE
12822012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 Pacify gcc -Wdouble-precision when using Xaw.
1285 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1286 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1287 Use 'float' consistently, rather than 'float' in most places
1288 and 'double' in a couple of places.
1289
efc00ab1 12902012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1291
1292 * xdisp.c (handle_stop): Detect whether we have overlay strings
1293 loaded by testing it->current.overlay_string_index to be
1294 non-negative, instead of checking whether n_overlay_strings is
1295 positive. (Bug#11587)
1296
efc00ab1 12972012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1298
1299 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1300
1301 * doc.c (Fsubstitute_command_keys): Doc fix.
1302
efc00ab1 13032012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1304
1305 * search.c (search_buffer): Remove calls to
1306 r_alloc_inhibit_buffer_relocation, as it is now called by
1307 maybe_unify_char, which was the cause of relocation of buffer text
1308 in bug#11519.
1309
efc00ab1 13102012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1311
1312 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1313 for the duration of call to load_charset, to avoid problems with
1314 callers of maybe_unify_char that access buffer text through C
1315 pointers.
1316
1317 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1318 decrement the inhibition flag, instead of just setting or
1319 resetting it.
1320
ba93a187
PE
13212012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1322
1323 Remove obsolete '#define static' cruft.
1324 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1325 This #undef was "temporary" in 2000; it is no longer needed
1326 now that '#define static' has gone away.
1327 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1328 (gray_bitmap_bits): Remove; no longer needed.
1329 All uses replaced with definiens.
1330 * xterm.c: Include "bitmaps/gray.xbm".
1331
9e4bf381
PE
13322012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1333
1334 Clean up __executable_start, monstartup when --enable-profiling.
1335 The following changes affect the code only when profiling.
1336 * dispnew.c (__executable_start): Rename from safe_bcopy.
1337 Define only on platforms that need it.
1338 * emacs.c: Include <sys/gmon.h> when profiling.
1339 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1340 (__executable_start): Remove decl, since lisp.h does it now.
1341 (safe_bcopy): Remove decl; no longer has that name.
1342 (main): Coalesce #if into single bit of code, for simplicity.
1343 Cast pointers to uintptr_t, since standard libraries want integers
1344 and not pointers.
1345 * lisp.h (__executable_start): New decl.
1346
32d72c2f
GM
13472012-05-31 Glenn Morris <rgm@gnu.org>
1348
1349 * image.c (Fimagemagick_types): Doc fix.
1350
baac5bc7
JM
13512012-05-30 Jim Meyering <meyering@redhat.com>
1352
1353 * callproc.c (Fcall_process_region): Include directory component
1354 in mkstemp error message (Bug#11586).
1355
72cb32cf
PE
13562012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1357
1358 * alloc.c, lisp.h (make_pure_vector): Now static.
1359
61b108cc
SM
13602012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1361
1362 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1363 Move to byte-run.el.
1364 (Fautoload): Do the hash-doc more carefully.
1365 * data.c (Fdefalias): Purify definition, except for keymaps.
1366 (Qdefun): Move from eval.c.
1367 * lisp.h (Qdefun): Remove.
1368 * lread.c (read1): Tiny simplification.
1369
471fe23d
TN
13702012-05-29 Troels Nielsen <bn.troels@gmail.com>
1371
934f3f58 1372 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1373 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1374 Bug#9642, but explicitly check that the buffer the overlay would
1375 be moved to is live and rearrange lines to make sure that errors
1376 will not put the overlay in an inconsistent state.
1377 (Fdelete_overlay): Cosmetics.
1378
85d0efd1
EZ
13792012-05-28 Eli Zaretskii <eliz@gnu.org>
1380
1381 * w32term.c (my_bring_window_to_top): New function.
1382 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1383 could be different from the original one.
1384 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1385 (Bug#11513)
1386
1387 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1388 by calling BringWindowToTop.
1389
1390 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1391 (WM_EMACS_END): Increase by one.
1392
da92a98c
PE
13932012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1394
1395 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1396 This avoids undefined behavior that might cause the eassert
1397 to not catch an out-of-range value.
1398
74d1f848
JB
13992012-05-28 Juanma Barranquero <lekktu@gmail.com>
1400
1401 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1402 Update dependencies.
1403
9e1a06fc
EZ
14042012-05-27 Eli Zaretskii <eliz@gnu.org>
1405
1406 * bidi.c (bidi_mirror_char): Fix last change.
1407
f3dd7312
AS
14082012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1409
1410 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1411 when referring to sectname field in printf format.
1412
81899c91
PE
14132012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1414
57b81a9f
PE
1415 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1416 Only r_alloc_inhibit_buffer_relocation needed to be added;
1417 the others were already declared.
1418
81899c91
PE
1419 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1420 before checking whether it's out of range. Put the check inside
1421 eassert. See
1422 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1423
33017faf 14242012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1425
1426 * callproc.c (Fcall_process): Restore a line that was accidentally
1427 commented out in the 2011-02-13 change (bug#11547).
1428
33017faf 14292012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1430
1431 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1432 defined on ralloc.c.
1433
1434 * buffer.c [REL_ALLOC]: Remove prototypes of
1435 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1436 they are now on lisp.h.
1437
1438 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1439
1440 * search.c (search_buffer): Use it to inhibit relocation of buffer
1441 text while re_search_2 is doing its job, because re_search_2 is
1442 passed C pointers to buffer text. (Bug#11519)
1443
23415acf
EZ
1444 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1445 Update value to 24.
1446
44e27368
EZ
1447 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1448 state after an additional call to move_it_in_display_line_to, keep
1449 the values of it->max_ascent and it->max_descent found for the
1450 entire line.
1451 (pos_visible_p): Revert the comparison against bottom_y to what it
1452 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1453 (Bug#11464)
1454
c1892f11
PE
14552012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1456
1457 Fix coding-related core dumps with gcc -ftrapv.
1458 The code was computing A - B, where A and B are pointers, and B is
1459 random garbage. This can lead to core dumps on platforms that
1460 have special pointer registers, and it also leads to core dumps on
1461 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1462 A - B only when B is initialized properly.
1463 * coding.c (coding_set_source, coding_set_destination): Return void.
1464 (coding_change_source, coding_change_destinations): New functions,
1465 with the old behaviors of coding_set_source and coding_set_destination.
1466 All callers that need an offset changed to use these new functions.
1467
eb7afdad
GM
14682012-05-26 Glenn Morris <rgm@gnu.org>
1469
1470 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1471
f12fdf02
EZ
14722012-05-26 Eli Zaretskii <eliz@gnu.org>
1473
53a63be6 1474 Extend mouse support on W32 text-mode console.
61b108cc
SM
1475 * xdisp.c (draw_row_with_mouse_face):
1476 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1477
eb3f6f01 1478 * w32console.c: Include window.h.
61b108cc
SM
1479 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1480 New functions.
eb3f6f01
EZ
1481 (initialize_w32_display): Initialize mouse-highlight data.
1482
53a63be6
EZ
1483 * w32inevt.c: Include termchar.h and window.h.
1484 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1485 moves, call note_mouse_highlight. If help_echo changed, call
1486 gen_help_event to produce help-echo message in the echo area.
1487 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1488 highlight info.
1489
4cfd81f6
PE
14902012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1491
1492 * lread.c (read1): Simplify slightly to avoid an overflow warning
1493 with GCC 4.7.0 on x86-64.
1494
4446092a
EZ
14952012-05-26 Eli Zaretskii <eliz@gnu.org>
1496
1497 * bidi.c (bidi_mirror_char): Revert last change: an int is
1498 definitely wide enough here.
1499
42b2a986 15002012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1501
42b2a986 1502 Fix integer width and related bugs (Bug#9874).
eb106a49 1503 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1504 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1505 (string_bytes, check_sblock, allocate_string_data):
1506 (compact_small_strings, Fmake_bool_vector, make_string)
1507 (make_unibyte_string, make_multibyte_string)
1508 (make_string_from_bytes, make_specified_string)
1509 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1510 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1511 (mark_vectorlike):
1512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1513 (allocate_pseudovector):
1514 Use int, not EMACS_INT, where int is wide enough.
1515 (inhibit_garbage_collection, Fgarbage_collect):
1516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1517 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1518 int might not be wide enough.
1519 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1520 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1521 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1522 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1523 (bidi_level_of_next_char, bidi_move_to_visually_next):
1524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1525 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1526 (Fkill_buffer, Fset_buffer_major_mode)
1527 (advance_to_char_boundary, Fbuffer_swap_text)
1528 (Fset_buffer_multibyte, overlays_at, overlays_in)
1529 (overlay_touches_p, struct sortvec, record_overlay_string)
1530 (overlay_strings, recenter_overlay_lists)
1531 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1532 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1533 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1534 (Foverlay_recenter, last_overlay_modification_hooks_used)
1535 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1537 (validate_region): Omit unnecessary test for b <= e,
1538 since that's guaranteed by the previous test.
d311d28c
PE
1539 (adjust_overlays_for_delete): Avoid pos + length overflow.
1540 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1541 (report_overlay_modification):
1542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1543 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1544 Omit pointer cast, which isn't needed anyway, and doesn't work
1545 after the EMACS_INT -> ptrdiff_t change.
02481186 1546 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1547 * buffer.h: Adjust decls to match defn changes elsewhere.
1548 (struct buffer_text, struct buffer):
1549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1550 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1551 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1552 not int, to avoid needless 32-bit limit on 64-bit hosts.
1553 (exec_byte_code): Use tighter memory-full test, one that checks
1554 for alloca overflow. Don't compute the address of the object just
1555 before an array, as that's not portable. Use EMACS_INT, not
1556 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1557 * callint.c (Fcall_interactively):
1558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1559 * callproc.c (call_process_kill, Fcall_process):
1560 Don't assume pid_t fits into an Emacs fixnum.
1561 (call_process_cleanup, Fcall_process, child_setup):
1562 Don't assume pid_t fits into int.
1563 (call_process_cleanup, Fcall_process, delete_temp_file)
1564 (Fcall_process_region):
1565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1566 (Fcall_process): Simplify handling of volatile integers.
1567 Use int, not EMACS_INT, where int will do.
1568 * casefiddle.c (casify_object, casify_region, operate_on_word)
1569 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1571 (casify_object): Avoid integer overflow when overallocating buffer.
1572 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1573 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1574 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1575 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1576 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1577 integers are now checked earlier. All uses replaced with XINT.
1578 (ccl_driver):
1579 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1580 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1581 (ccl_driver, Fregister_code_conversion_map):
1582 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1583 (resolve_symbol_ccl_program): Check that vector header is in range.
1584 Always copy the vector, so that we can check its contents reliably
1585 now rather than having to recheck each instruction as it's being
1586 executed. Check that vector words fit in 'int'.
1587 (ccl_get_compiled_code, Fregister_ccl_program)
1588 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1589 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1590 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1591 contents are in range.
1592 (Fccl_execute_on_string): Check that status is in range.
1593 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1594 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1595 Accept and return EMACS_INT, not int, because callers can pass values
1596 out of 'int' range.
1597 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1598 (multibyte_chars_in_text, parse_str_as_multibyte)
1599 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1600 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1601 (string_escape_byte8, Fget_byte):
1602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1603 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1604 avoid mishandling large integers.
1605 * character.h: Adjust decls to match defn changes elsewhere.
1606 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1607 (Ffind_charset_region):
1608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1609 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1610 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1611 Don't assume fixnum fits in int.
d311d28c
PE
1612 (load_charset_map_from_vector, Fmap_charset_chars):
1613 Remove now-unnecessary CHECK_NATNUMs.
1614 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1615 Don't rely on undefined behavior with signed left shift overflow.
1616 Don't assume unsigned int fits into fixnum, or that fixnum fits
1617 into unsigned int. Don't require max_code to be a valid fixnum;
1618 that's not true for gb10830 4-byte on a 32-bit host. Allow
1619 invalid_code to be a cons, for the same reason. Require code_offset
1620 to be a character. Avoid int overflow if max_char is close
1621 to INT_MAX.
1622 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1623 this is intended anyway and avoids some undefined behavior.
1624 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1625 INDEX_TO_CODE_POINT, as that's what it expects.
1626 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1627 * charset.h (DECODE_CHAR): Return int, not unsigned;
1628 this is what was intended anyway, and it avoids undefined behavior.
1629 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1630 integer-overflow issues.
1631 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1632 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1633 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1634 * chartab.c (Fmake_char_table, Fset_char_table_range)
1635 (uniprop_get_decoder, uniprop_get_encoder):
1636 Don't assume fixnum fits in int.
1637 * cmds.c (move_point): New function, that does the gist of
1638 Fforward_char and Fbackward_char, but does so while checking
1639 for integer overflow more accurately.
c96e5d6a 1640 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1641 (Fforward_line, Fend_of_line, internal_self_insert)
1642 (internal_self_insert):
1643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1644 Fix a FIXME, by checking for integer overflow when calculating
1645 target_clm and actual_clm.
1646 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1647 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1648 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1649 (coding_alloc_by_making_gap, alloc_destination)
1650 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1651 (encode_coding_utf_16, detect_coding_emacs_mule)
1652 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1653 (detect_coding_iso_2022, decode_coding_iso_2022)
1654 (encode_invocation_designation, encode_designation_at_bol)
1655 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1656 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1657 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1658 (encode_coding_ccl, encode_coding_raw_text)
1659 (detect_coding_charset, decode_coding_charset)
1660 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1661 (produce_composition, produce_charset, produce_annotation)
1662 (decode_coding, handle_composition_annotation)
1663 (handle_charset_annotation, consume_chars, decode_coding_gap)
1664 (decode_coding_object, encode_coding_object, detect_coding_system)
1665 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1666 (code_convert_region, code_convert_string)
8f50130c
PE
1667 (Fdefine_coding_system_internal)
1668 (coding_set_source, coding_set_destination):
d311d28c
PE
1669 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1670 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1671 (Fdefine_coding_system_internal):
1672 Don't assume fixnums fit in int.
1673 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1674 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1675 (Funencodable_char_position, Fcheck_coding_systems_region)
1676 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1678 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1679 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1680 Don't access memory outside of the args array.
d311d28c 1681 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1682 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1683 result of ENCODE_CHAR.
d311d28c
PE
1684 * coding.h: Adjust decls to match defn changes elsewhere.
1685 (struct coding_system):
1686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1687 * composite.c (get_composition_id, find_composition)
1688 (run_composition_function, update_compositions)
1689 (compose_text, composition_gstring_put_cache)
1690 (composition_gstring_p, composition_gstring_width)
1691 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1692 (composition_compute_stop_pos, composition_reseat_it)
1693 (composition_update_it, struct position_record)
1694 (find_automatic_composition, composition_adjust_point)
1695 (Fcomposition_get_gstring, Ffind_composition_internal):
1696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1697 (update_compositions):
1698 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1699 * composite.h: Adjust decls to match defn changes elsewhere.
1700 (struct composition):
1701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1702 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1703 Do not attempt to compute the address of the object just before a
1704 buffer; this is not portable.
1705 (Faref, Faset):
1706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1707 (Faset): Use int, not EMACS_INT, where int is wide enough.
1708 (Fstring_to_number): Don't assume fixnums fit in int.
1709 (Frem): Don't assume arg is nonnegative.
1710 * dbusbind.c (xd_append_arg): Check for integers out of range.
1711 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1712 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1713 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1714 (xd_get_connection_references): Return ptrdiff_t, not int.
1715 All uses changed.
1716 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1717 (xd_read_message_1):
1718 Use int, not unsigned, where the dbus API uses int.
1719 (Fdbus_message_internal): Don't overflow mtype.
1720 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1721 * dired.c (directory_files_internal, file_name_completion, scmp)
1722 (file_name_completion_stat):
1723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1724 (file_name_completion): Don't overflow matchcount.
1725 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1726 * dispextern.h: Adjust decls to match defn changes elsewhere.
1727 (struct text_pos, struct glyph, struct bidi_saved_info)
1728 (struct bidi_string_data, struct bidi_it, struct composition_it)
1729 (struct it):
1730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1731 (struct display_pos, struct composition_it, struct it):
1732 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1733 * dispnew.c (increment_matrix_positions)
1734 (increment_row_positions, mode_line_string)
1735 (marginal_area_string):
1736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1737 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1738 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1739 (duration_to_sec_usec): New function, to check for overflow better.
1740 (Fsleep_for, sit_for): Use it.
1741 * doc.c (get_doc_string, store_function_docstring):
1742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1743 (get_doc_string, Fsnarf_documentation):
1744 Use int, not EMACS_INT, where int is wide enough.
1745 (get_doc_string):
1746 Use SAFE_ALLOCA, not alloca.
1747 Check for overflow when converting EMACS_INT to off_t.
1748 * doprnt.c (doprnt):
1749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1750 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1751 Don't assume uid_t fits into fixnum.
1752 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1753 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1754 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1755 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1756 (general_insert_function)
1757 (Finsert_char, make_buffer_string, make_buffer_string_both)
1758 (update_buffer_properties, Fbuffer_substring)
1759 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1760 (Fsubst_char_in_region, check_translation)
1761 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1762 (transpose_markers, Ftranspose_regions):
1763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1764 (clip_to_bounds): Move to lisp.h as an inline function).
1765 (Fconstrain_to_field): Don't assume integers are nonnegative.
1766 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1767 (Fsubst_char_in_region, Fsave_restriction):
1768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1769 (Femacs_pid): Don't assume pid_t fits into fixnum.
1770 (lo_time): Use int, not EMACS_INT, when int suffices.
1771 (lisp_time_argument): Check for usec out of range.
1772 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1773 (Fuser_login_name, Fuser_full_name): Signal an error
1774 if a uid argument is out of range, rather than relying on
1775 undefined behavior.
c8d5c857
PE
1776 (Fformat_time_string): Remove now-unnecessary check.
1777 lisp_time_argument checks for out-of-range usec now.
243e0530 1778 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1779 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1780 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1781 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1782 (init_cmdargs, Fdump_emacs):
1783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1784 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1785 the bottom (typically) 32 bits of the fixnum.
1786 * eval.c (specpdl_size, call_debugger):
1787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1788 (when_entered_debugger, Fbacktrace_debug):
1789 Don't assume fixnum can fit in int.
1790 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1791 the object just before a buffer; this is not portable.
1792 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1793 (grow_specpdl, unbind_to):
1794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1795 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1796 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1797 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1798 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1799 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1801 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1802 (a_write, e_write):
1803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1804 (Fcopy_file, non_regular_nbytes, read_non_regular)
1805 (Finsert_file_contents):
1806 Use int, not EMACS_INT, where int is wide enough.
1807 (READ_BUF_SIZE): Verify that it fits in int.
1808 (Finsert_file_contents): Check that counts are in proper range,
1809 rather than assuming fixnums fit into ptrdiff_t etc.
1810 Don't assume fixnums fit into int.
125b3835 1811 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1812 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1813 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1814 (string_char_to_byte, string_byte_to_char)
1815 (string_make_multibyte, string_to_multibyte)
1816 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1817 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1818 (substring_both, Fdelete, internal_equal, Ffillarray)
1819 (Fclear_string, mapcar1)
1820 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1821 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1822 (larger_vector, make_hash_table, maybe_resize_hash_table)
1823 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1824 (Fmaphash, secure_hash):
1825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1826 (concat): Check for string index and length overflow.
1827 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1828 (Frequire):
1829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1830 (larger_vector): New API (vec, incr_min, size_max) replaces old
1831 one (vec, new_size, init). This catches size overflow.
1832 INIT was removed because it was always Qnil.
1833 All callers changed.
1834 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1835 the upper bound on a hash table index size.
1836 (make_hash_table, maybe_resize_hash_table): Use it.
1837 (secure_hash): Computer start_byte and end_byte only after
1838 they're known to be in ptrdiff_t range.
1839 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1840 (Ffont_get_glyphs, Ffont_at):
1841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1842 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1843 (Flist_fonts, Fopen_font):
1844 Don't assume fixnum can fit in int.
1845 (check_gstring): Don't assume index can fit in int.
1846 (font_match_p): Check that fixnum is a character, not a nonnegative
1847 fixnum, since the later code needs to stuff it into an int.
1848 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1849 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1850 conversion overflow issues.
1851 (Fopen_font): Check for integer out of range.
1852 (Ffont_get_glyphs): Don't assume index can fit in int.
1853 * font.h: Adjust decls to match defn changes elsewhere.
1854 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1855 integer overflow.
1856 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1857 printmax_t, where ptrdiff_t is wide enough.
1858 (Finternal_char_font):
1859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1860 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1861 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1862 (Fset_frame_position, x_set_frame_parameters)
1863 (x_set_line_spacing, x_set_border_width)
1864 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1865 Check that fixnums are in proper range for system types.
1866 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1868 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1869 Use SAFE_ALLOCA_LISP, not alloca.
1870 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1871 intptr_t is wide enough.
1872 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1873 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1874 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1875 Check for fixnum out of range.
1876 * ftfont.c (ftfont_list): Don't assume index fits in int.
1877 Check that fixnums are in proper range for system types.
1878 (ftfont_shape_by_flt):
1879 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1880 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1882 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1883 Check that fixnums are in proper range for system types.
1884 * gnutls.h: Adjust decls to match defn changes elsewhere.
1885 * gtkutil.c (xg_dialog_run):
1886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1887 (update_frame_tool_bar):
1888 Check that fixnums are in proper range for system types.
1889 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1890 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1891 * indent.c (last_known_column, last_known_column_point):
1892 (current_column_bol_cache):
1893 (skip_invisible, current_column, check_display_width):
1894 (check_display_width, scan_for_column, current_column_1)
1895 (Findent_to, Fcurrent_indentation, position_indentation)
1896 (indented_beyond_p, Fmove_to_column, compute_motion):
1897 (Fcompute_motion, Fvertical_motion):
1898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1899 (last_known_column_modified): Use EMACS_INT, not int.
1900 (check_display_width):
1901 (Fcompute_motion):
1902 Check that fixnums and floats are in proper range for system types.
1903 (compute_motion): Don't assume index or fixnum fits in int.
1904 (compute_motion, Fcompute_motion):
1905 Use int, not EMACS_INT, when it is wide enough.
1906 (vmotion): Omit local var start_hpos that is always 0; that way
1907 we don't need to worry about overflow in expressions involving it.
1908 * indent.h: Adjust decls to match defn changes elsewhere.
1909 (struct position):
1910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1911 Use int, not EMACS_INT, where int is wide enough.
1912 Remove unused members ovstring_chars_done and tab_offset;
1913 all uses removed.
1914 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1915 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1916 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1917 (make_gap, copy_text, insert, insert_and_inherit)
1918 (insert_before_markers, insert_before_markers_and_inherit)
1919 (insert_1, count_combining_before, count_combining_after)
1920 (insert_1_both, insert_from_string)
1921 (insert_from_string_before_markers, insert_from_string_1)
1922 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1923 (adjust_after_replace, adjust_after_insert, replace_range)
1924 (replace_range_2, del_range, del_range_1, del_range_byte)
1925 (del_range_both, del_range_2, modify_region)
1926 (prepare_to_modify_buffer, signal_before_change)
1927 (signal_after_change, Fcombine_after_change_execute):
1928 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1929 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1930 (balance_an_interval, split_interval_right, split_interval_left)
1931 (find_interval, next_interval, update_interval)
1932 (adjust_intervals_for_insertion, delete_node, delete_interval)
1933 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1934 (static_offset_intervals, offset_intervals)
1935 (merge_interval_right, merge_interval_left, make_new_interval)
1936 (graft_intervals_into_buffer, temp_set_point_both)
1937 (temp_set_point, set_point, adjust_for_invis_intang)
1938 (set_point_both, move_if_not_intangible, get_property_and_range)
1939 (get_local_map, copy_intervals, copy_intervals_to_string)
1940 (compare_string_intervals, set_intervals_multibyte_1):
1941 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1942 * intervals.h: Adjust decls to match defn changes elsewhere.
1943 (struct interval):
1944 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1945 * keyboard.c (this_command_key_count, this_single_command_key_start)
1946 (before_command_key_count, before_command_echo_length, echo_now)
1947 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1948 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1949 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1950 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1951 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1952 (last_non_minibuf_size, last_point_position, echo_truncate)
1953 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1954 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1955 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1956 (stuff_buffered_input):
1957 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1958 (last_auto_save, command_loop_1, read_char):
1959 Use EMACS_INT, not int, to avoid integer overflow.
1960 (record_char): Avoid overflow in total_keys computation.
1961 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1962 * keyboard.h: Adjust decls to match defn changes elsewhere.
1963 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1964 (Fkey_description, Fdescribe_vector, Flookup_key):
1965 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1966 (click_position): New function, to check that positions are in range.
1967 (Fcurrent_active_maps):
1968 (describe_command):
1969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1970 (Faccessible_keymaps, Fkey_description):
1971 (preferred_sequence_p):
1972 Don't assume fixnum can fit into int.
1973 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1974 Check for integer overflow in size calculations.
1975 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1976 avoid mishandling large integers.
1977 * lisp.h: Adjust decls to match defn changes elsewhere.
1978 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1979 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1980 (struct Lisp_Marker):
1981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1982 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1983 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1984 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1985 All callers changed.
1986 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1987 Assume the arg has valid form, since it always does.
1988 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1989 unsigned integer system type.
1990 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1991 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1993 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1994 (duration_to_sec_usec): New decl.
1995 * lread.c (read_from_string_index, read_from_string_index_byte)
1996 (read_from_string_limit, readchar, unreadchar, openp)
1997 (read_internal_start, read1, oblookup):
1998 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1999 (Fload, readevalloop, Feval_buffer, Feval_region):
2000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2001 (openp): Check for out-of-range argument to 'access'.
2002 (read1): Use int, not EMACS_INT, where int is wide enough.
2003 Don't assume fixnum fits into int.
6efdadfd 2004 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2005 (read_filtered_event): Use duration_to_sec_usec
2006 to do proper overflow checking on durations.
d311d28c
PE
2007 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2008 in size calculation.
2009 (Fexecute_kbd_macro):
2010 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2011 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2012 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2013 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2014 (set_marker_both, set_marker_restricted_both, marker_position)
2015 (marker_byte_position, Fbuffer_has_markers_at):
2016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2017 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2018 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2019 It now merely ensures that the menu is large enough, without
2020 necessarily growing it, as this avoids some integer overflow issues.
2021 All callers changed.
2022 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2024 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2025 Use SAFE_ALLOCA_LISP, not alloca.
2026 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2027 to EMACS_INT. Check that fixnums are in proper range for system types.
2028 * minibuf.c (minibuf_prompt_width, string_to_object)
2029 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2030 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2032 (get_minibuffer, read_minibuf_unwind):
2033 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2034 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2035 this simplifies overflow checking. All callers changed.
2036 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2037 (Ftest_completion):
2038 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2039 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2040 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2041 Check that fixnums are in proper range for system types.
2042 (Fx_create_frame, Fx_show_tip):
2043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2044 * nsfont.m (ns_findfonts, nsfont_list_family):
2045 Don't assume fixnum fits in long.
2046 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2047 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2048 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2049 wide enough.
17fdb222 2050 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2052 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2053 (PRINTDECLARE, PRINTPREPARE):
2054 (strout, print_string):
2055 (print, print_preprocess, print_check_string_charset_prop)
2056 (print_object):
2057 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2058 (PRINTDECLARE):
2059 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2060 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2061 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2062 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2063 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2064 (print_error_message): Use SAFE_ALLOCA, not alloca.
2065 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2066 (print_depth, new_backquote_output, print_number_index):
2067 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2068 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2069 (Fset_process_window_size, Fformat_network_address)
2070 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2071 (sigchld_handler):
d311d28c 2072 Check that fixnums are in proper range for system types.
d44287d4 2073 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2074 Check for process-ids out of pid_t range rather than relying on
2075 undefined behavior.
e4d81efc 2076 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2077 (Fformat_network_address, read_process_output, send_process)
2078 (Fprocess_send_region, status_notify):
2079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2080 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2081 (wait_reading_process_output, read_process_output, exec_sentinel):
2082 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2083 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2084 (Faccept_process_output): Use duration_to_sec_usec to do proper
2085 overflow checking on durations.
dde14581
PE
2086 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2087 Don't assume pid_t fits in int.
02481186
PE
2088 * process.h (struct Lisp_Process): Members tick and update_tick
2089 are now of type EMACS_INT, not int.
b62b53e8
PE
2090 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2091 configured --with-wide-int.
d311d28c
PE
2092 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2093 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2094 * search.c (looking_at_1, string_match_1):
2095 (fast_string_match, fast_c_string_match_ignore_case)
2096 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2097 (scan_newline, find_before_next_newline, search_command)
2098 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2099 (set_search_regs, wordify):
2100 (Freplace_match):
2101 (Fmatch_data):
2102 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2103 (string_match_1, search_buffer, set_search_regs):
2104 (Fmatch_data):
2105 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2106 (wordify): Check for overflow in size calculation.
2107 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2108 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2109 Check that fixnums are in proper range for system types.
2110 * sound.c (struct sound_device)
2111 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2112 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2113 (Fplay_sound_internal):
2114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2115 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2116 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2117 (Fparse_partial_sexp):
2118 Don't assume fixnums can fit in int.
2119 (struct lisp_parse_state, find_start_pos, find_start_value)
2120 (find_start_value_byte, find_start_begv)
2121 (update_syntax_table, char_quoted, dec_bytepos)
2122 (find_defun_start, prev_char_comend_first, back_comment):
2123 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2124 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2125 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2126 (Finternal_describe_syntax_value): Check that match_lisp is a
2127 character, not an integer, since the code stuffs it into int.
2128 (scan_words, scan_sexps_forward):
2129 Check that fixnums are in proper range for system types.
2130 (Fforward_word):
2131 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2132 (scan_sexps_forward):
2133 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2134 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2135 * syntax.h: Adjust decls to match defn changes elsewhere.
2136 (struct gl_state_s):
2137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2138 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2139 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2140 * sysdep.c (wait_for_termination_1, wait_for_termination)
2141 (interruptible_wait_for_termination, mkdir):
2142 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2143 (emacs_read, emacs_write):
2144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2145 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2146 and double all fit in int.
d311d28c
PE
2147 * term.c (set_tty_color_mode):
2148 Check that fixnums are in proper range for system types.
2149 * termhooks.h (struct input_event):
2150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2151 * textprop.c (validate_interval_range, interval_of)
2152 (Fadd_text_properties, set_text_properties_1)
2153 (Fremove_text_properties, Fremove_list_of_text_properties)
2154 (Ftext_property_any, Ftext_property_not_all)
2155 (copy_text_properties, text_property_list, extend_property_ranges)
2156 (verify_interval_modification):
2157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2158 (Fnext_single_char_property_change)
2159 (Fprevious_single_char_property_change):
2160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2161 (copy_text_properties):
2162 Check for integer overflow in index calculation.
d311d28c
PE
2163 * undo.c (last_boundary_position, record_point, record_insert)
2164 (record_delete, record_marker_adjustment, record_change)
2165 (record_property_change):
2166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2167 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2168 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2169 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2170 (Fx_hide_tip, Fx_file_dialog):
2171 * w32menu.c (set_frame_menubar):
2172 Use ptrdiff_t, not int, for consistency with rest of code.
2173 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2174 (select_window, Fdelete_other_windows_internal)
2175 (window_scroll_pixel_based, window_scroll_line_based)
2176 (Frecenter, Fset_window_configuration):
2177 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2178 (Fset_window_hscroll, run_window_configuration_change_hook)
2179 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2180 (Fscroll_other_window, Frecenter):
d311d28c
PE
2181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2182 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2183 Don't assume fixnum fits in int.
2184 (Fset_window_scroll_bars):
2185 Check that fixnums are in proper range for system types.
2186 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2187 (string_pos, c_string_pos, number_of_chars, init_iterator)
2188 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2189 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2190 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2191 (face_before_or_after_it_pos, handle_invisible_prop)
2192 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2193 (display_prop_intangible_p, string_buffer_position_lim)
2194 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2195 (get_overlay_strings_1, get_overlay_strings)
2196 (iterate_out_of_display_property, forward_to_next_line_start)
2197 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2198 (get_next_display_element, set_iterator_to_next)
2199 (get_visually_first_element, compute_stop_pos_backwards)
2200 (handle_stop_backwards, next_element_from_buffer)
2201 (move_it_in_display_line_to, move_it_in_display_line)
2202 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2203 (add_to_log, message_dolog, message_log_check_duplicate)
2204 (message2, message2_nolog, message3, message3_nolog
2205 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2206 (current_message_1, truncate_echo_area, truncate_message_1)
2207 (set_message, set_message_1, store_mode_line_noprop)
2208 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2209 (text_outside_line_unchanged_p, check_point_in_composition)
2210 (reconsider_clip_changes)
2211 (redisplay_internal, set_cursor_from_row, try_scrolling)
2212 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2213 (redisplay_window, find_last_unchanged_at_beg_row)
2214 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2215 (trailing_whitespace_p, find_row_edges, display_line)
2216 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2217 (display_mode_element, store_mode_line_string)
2218 (pint2str, pint2hrstr, decode_mode_spec)
2219 (display_count_lines, display_string, draw_glyphs)
2220 (x_produce_glyphs, x_insert_glyphs)
2221 (rows_from_pos_range, mouse_face_from_buffer_pos)
2222 (fast_find_string_pos, mouse_face_from_string_pos)
2223 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2225 (safe_call, init_from_display_pos, handle_fontified_prop)
2226 (handle_single_display_spec, load_overlay_strings)
2227 (with_echo_area_buffer, setup_echo_area_for_printing)
2228 (display_echo_area, echo_area_display)
2229 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2230 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2231 (redisplay_window, dump_glyph_row, display_mode_line)
2232 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2233 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2234 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2235 (handle_single_display_spec, build_desired_tool_bar_string)
2236 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2237 (get_specified_cursor_type):
2238 Check that fixnums are in proper range for system types.
2239 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2240 (Flookup_image_map):
2241 Don't assume fixnums fit in int.
2242 (compare_overlay_entries):
2243 Avoid mishandling comparisons due to subtraction overflow.
2244 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2245 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2246 (handle_tool_bar_click):
2247 Use int, not unsigned, since we prefer signed and the signedness
2248 doesn't matter here.
2249 (get_next_display_element, next_element_from_display_vector):
2250 Use int, not EMACS_INT, when int is wide enough.
2251 (start_hourglass): Use duration_to_sec_usec to do proper
2252 overflow checking on durations.
2253 * xfaces.c (Fbitmap_spec_p):
2254 Check that fixnums are in proper range for system types.
2255 (compare_fonts_by_sort_order):
2256 Avoid mishandling comparisons due to subtraction overflow.
2257 (Fx_family_fonts, realize_basic_faces):
2258 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2259 (Fx_family_fonts):
2260 Don't assume fixnum fits in int.
2261 Use SAFE_ALLOCA_LISP, not alloca.
2262 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2263 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2264 (face_at_buffer_position, face_for_overlay_string)
2265 (face_at_string_position):
2266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2267 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2268 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2269 (Fx_show_tip):
2270 Check that fixnums are in proper range for system types.
2271 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2272 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2273 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2274 (Fx_change_window_property): Don't assume fixnums fit in int.
2275 * xfont.c (xfont_chars_supported):
2276 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2277 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2278 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2280 * xml.c (parse_region):
2281 * xrdb.c (magic_file_p):
2282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2283 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2284 (x_get_local_selection, x_reply_selection_request)
2285 (x_handle_selection_request, wait_for_property_change):
2286 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2287 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2288 short is wide enough.
2289 (x_send_client_event): Don't assume fixnum fits in int.
2290 * xterm.c (x_x_to_emacs_modifiers):
2291 Don't assume EMACS_INT overflows nicely into int.
2292 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2293 may come from Lisp.
2294 (handle_one_xevent): NATNUMP can eval its arg twice.
2295 (x_connection_closed):
2296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2297 * xterm.h: Adjust decls to match defn changes elsewhere.
2298 (struct scroll_bar): Use struct vectorlike_header
2299 rather than rolling our own approximation.
2300 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2301
c6574eb5
GM
23022012-05-25 Glenn Morris <rgm@gnu.org>
2303
2304 * lisp.mk (lisp): Update for more files being compiled now.
2305
e8d32c7e
SM
23062012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2307
48def666
SM
2308 * lread.c: Remove `read_pure' which makes no difference.
2309 (read_pure): Remove var.
2310 (unreadpure): Remove function.
2311 (readevalloop): Don't call read_list with -1 flag.
2312 (read1, read_vector): Don't test read_pure any more.
2313 (read_list): Simplify.
2314
e8d32c7e
SM
2315 * fileio.c, character.h: Minor style tweaks.
2316
4b2addb7
DA
23172012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2318
2319 * window.h (clip_changed): Remove useless declaration.
2320
584461b2
JB
23212012-05-22 Juanma Barranquero <lekktu@gmail.com>
2322
2323 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2324 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2325
34374650
PE
23262012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2327
2328 Remove src/m/*.
2329 This directory predates autoconf and is no longer needed nowadays.
2330 Move its few remaining bits of functionality to where they're needed.
2331 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2332 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2333 * m/template.h: Remove.
2334 * Makefile.in (M_FILE): Remove. All uses removed.
2335 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2336 * lisp.h (USE_LSB_TAG):
2337 * mem-limits.h (EXCEEDS_LISP_PTR):
2338 Use VAL_MAX, not VALBITS, in #if.
2339 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2340 (EMACS_UINT): Define unconditionally now.
2341 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2342 (BITS_PER_EMACS_INT): New constants, replacing
2343 what used to be in config.h, but not useful in #if.
2344 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2345 define them any more.
2346 (VAL_MAX): New macro.
2347 (VALMASK): Use it.
2348 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2349 BITS_PER_EMACS_INT, in #if.
2350 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2351 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2352 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2353 * s/ms-w32.h (DATA_START):
2354 Move here from removed file m/intel386.h.
2355 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2356 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2357
261cb4bb
PE
23582012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2359
2360 Assume C89 or later.
2361 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2362 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2363 (xrealloc):
2364 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2365 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2366 * textprop.c, tparam.c (NULL): Remove.
2367 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2368 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2369 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2370 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2371 * xterm.c (input_signal_count): Assume volatile works.
2372
ff23cd9f
KB
23732012-05-21 Ken Brown <kbrown@cornell.edu>
2374
2375 * xgselect.c (xg_select): Fix first argument in call to 'select'
2376 (bug#11508).
2377
1b170bc6
KB
23782012-05-20 Ken Brown <kbrown@cornell.edu>
2379
2380 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2381 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2382
b2f4d39f
KB
23832012-05-19 Ken Brown <kbrown@cornell.edu>
2384
2385 * xfns.c (x_in_use): Remove `static' qualifier.
2386 * xterm.h (x_in_use): Declare.
2387 * xgselect.c: Include xterm.h.
2388 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2389 and `display_arg' (bug#9754).
2390
003fdae2
PE
23912012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2392
9232a6d9
PE
2393 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2394
003fdae2
PE
2395 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2396 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2397
784b56e2
EZ
23982012-05-18 Eli Zaretskii <eliz@gnu.org>
2399
2400 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2401
2402 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2403 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2404
2405 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2406 reference to image_cache->refcount.
2407 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2408
a0a79cde
JL
24092012-05-17 Juri Linkov <juri@jurta.org>
2410
2411 * search.c (Fword_search_regexp, Fword_search_backward)
2412 (Fword_search_forward, Fword_search_backward_lax)
2413 (Fword_search_forward_lax): Move functions to isearch.el
2414 (bug#10145, bug#11381).
2415
b0572523
PE
24162012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2417
2418 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2419
9660f5fc
SM
24202012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2421
2422 * lread.c (init_obarray): Declare Qt and Qnil as special.
2423
4374de83
GM
24242012-05-14 Glenn Morris <rgm@gnu.org>
2425
2426 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2427 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2428
dc44c39a
PE
24292012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2430
078c97cb
PE
2431 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2432
dc44c39a
PE
2433 * unexaix.c: Port to more-recent AIX compilers.
2434 (report_error, report_error_1, make_hdr, copy_sym)
2435 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2436 Make arguments const char *, not char *, to avoid violations of C
2437 standard and to fix some AIX warnings reported by Gilles Pion.
2438
e18afed7 24392012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2440
2441 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2442 already have overlays loaded.
2443 (handle_single_display_spec): Before returning without displaying
2444 fringe bitmap, synchronize the bidi iterator with the main display
2445 iterator, by calling iterate_out_of_display_property.
2446 (iterate_out_of_display_property): Detect buffer iteration by
2447 testing that it->string is a Lisp string.
2448 (get_next_display_element): When the current object is exhausted,
2449 and there's something on it->stack, call set_iterator_to_next to
2450 proceed with what's on the stack, instead of returning zero.
2451 (set_iterator_to_next): If called at the end of a Lisp string,
2452 proceed to consider_string_end without incrementing string
2453 position. Don't increment display vector index past the end of
2454 the display vector. (Bug#11417)
c8fb9dc6
EZ
2455 (pos_visible_p): Don't report a position visible when move_it_to
2456 stopped at the last line of window, which happens to be scanned
2457 backwards by the bidi iteration. (Bug#11464)
ac268e67 2458
e18afed7 24592012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2460
2461 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2462 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2463 are on a TTY, and thus unable to display on the fringes.
2464 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2465 so we need to signal to the caller that this is a "replacing"
2466 display spec. This fixes display when the spec is invalid or we
2467 are on a TTY.
2468
e18afed7 24692012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2470
2471 * unexaix.c (make_hdr): Fix typo in prototype.
2472 This bug broke the build on AIX. Problem reported by Gilles Pion.
2473
9d0a235a
MA
24742012-05-14 Michael Albinus <michael.albinus@gmx.de>
2475
2476 * keyboard.c (kbd_buffer_get_event): Read special events also in
2477 batch mode. (Bug#11415)
2478
9e6b06ed
GM
24792012-05-12 Glenn Morris <rgm@gnu.org>
2480
2481 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2482
c1a1d7a3
EZ
24832012-05-12 Eli Zaretskii <eliz@gnu.org>
2484
2485 * lisp.mk (lisp): Add newcomment.elc.
2486
3fe7cdc8
GM
24872012-05-12 Glenn Morris <rgm@gnu.org>
2488
2489 * Makefile.in (MKDIR_P): New, set by configure.
2490 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2491
53f7d2c0
PE
24922012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2493
2494 Remove unused function hourglass_started.
2495 * dispextern.h (hourglass_started):
2496 * w32fns.c (hourglass_started):
2497 * xdisp.c (hourglass_started): Remove.
2498
75aafb17
JB
24992012-05-10 Juanma Barranquero <lekktu@gmail.com>
2500
2501 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2502 Update dependencies.
2503
12959e8e
PE
25042012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2505
97107e2e
PE
2506 * xgselect.c (xg_select): Put maxfds+1 into a var.
2507 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2508
12959e8e
PE
2509 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2510
836d29b3
DA
25112012-05-10 Dave Abrahams <dave@boostpro.com>
2512
2513 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2514 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2515
5cb67954
MA
25162012-05-09 Michael Albinus <michael.albinus@gmx.de>
2517
2518 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2519 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2520 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2521 Initialize xd_registered_buses.
2522
3478ec45
PE
25232012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2524
b263a6b0
PE
2525 Untag more efficiently if USE_LSB_TAG.
2526 This is based on a proposal by YAMAMOTO Mitsuharu in
2527 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2528 For an admittedly artificial (nth 8000 longlist) benchmark on
2529 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2530 Emacs's overall text size by 1%.
2531 * lisp.h (XUNTAG): New macro.
2532 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2533 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2534 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2535 * eval.c (Fautoload):
2536 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2537 * frame.h (XFRAME): Use XUNTAG.
2538
3478ec45
PE
2539 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2540 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2541 Remove unportable assumptions about print widths of types like
2542 dbus_uint32_t.
2543 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2544 intptr_t when converting between pointer and integer, to avoid GCC
2545 warnings about wrong width.
2546
666b903b 25472012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2548
2549 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2550 stack for each reader_thread, instead of defaulting to 8MB
2551 determined by the linker. This avoids failures in creating
2552 subprocesses on Windows 7, see the discussion in this thread:
2553 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2554
b120cc17
JC
25552012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2556
2557 Fix up display of the *Minibuf-0* buffer in the mini window.
2558 * keyboard.c (read_char): Don't clear the echo area if there's no
2559 message to clear.
2560 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2561 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2562
9a4b36f8
MA
25632012-05-07 Michael Albinus <michael.albinus@gmx.de>
2564
2565 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2566 batch mode.
2567
e5f9458f
CY
25682012-05-06 Chong Yidong <cyd@gnu.org>
2569
2570 * lisp.mk (lisp): Update.
2571
eceeb5fc 25722012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2573
2574 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2575
71873e2b
SM
25762012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2577
2578 * data.c (PUT_ERROR): New macro.
2579 (syms_of_data): Use it. Add new error type `user-error'.
2580 * undo.c (user_error): New function.
2581 (Fprimitive_undo): Use it.
2582 * print.c (print_error_message): Adjust print style for `user-error'.
2583 * keyboard.c (user_error): New function.
2584 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2585
ab0fa4e4
PE
25862012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2587
2588 Do not limit current-time-string to years 1000..9999.
2589 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2590 (Fcurrent_time_string): Support any year that is supported by the
2591 underlying localtime representation. Don't use asctime, as it
2592 has undefined behavior for years outside the range -999..9999.
2593
7ed806a7
PE
25942012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2595
2596 Fix race conditions involving setenv, gmtime, localtime, asctime.
2597 Without this fix, interrupts could mess up code that uses these
2598 nonreentrant functions, since setting TZ invalidates existing
2599 tm_zone or tzname values, and since most of these functions return
2600 pointers to static storage.
2601 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2602 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2603 Grow the critical sections to include not just invoking
2604 localtime/gmtime, but also accessing these functions' results
2605 including their tm_zone values if any, and any related TZ setting.
2606 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2607 so that the struct tm is saved in the critical section.
2608 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2609 motivated by the fact that memory allocation needs to be outside
2610 the critical section.
2611
0c16dfed
DA
26122012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2613
2614 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2615 with RESET_INTERVAL.
2616
2617 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2618 Remove duplicated buffer name initialization.
2619
3f83ace8
JM
26202012-05-02 Jim Meyering <jim@meyering.net>
2621
2622 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2623
c7b8541e
JM
2624 * xfns.c (x_window): Use xstrdup (Bug#11375).
2625
90207a15 26262012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2627
2628 * xdisp.c (pos_visible_p): If already at a newline from the
2629 display string before the 'while' loop, don't walk back the glyphs
2630 from it3.glyph_row. Solves assertion violation when the display
2631 string begins with a newline (egg.el). (Bug#11367)
2632
b593d6a9
AH
26332012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2634
2635 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2636 Move to simple.el.
2637
4737362e
GM
26382012-05-01 Glenn Morris <rgm@gnu.org>
2639
99cf43f9
GM
2640 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2641 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2642 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2643 All were removed before 23.1.
2644
9311dcff
GM
2645 * dispnew.c: Remove HAVE_LIBNCURSES test;
2646 it is always true on relevant platforms.
2647
4d5c6349
GM
2648 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2649 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2650
4737362e
GM
2651 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2652
74dd3a6b
AS
26532012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2654
2655 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2656 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2657 Remove.
2658
13c379ee
PE
26592012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2660
2661 Do not avoid creating empty evaporating overlays (Bug#9642).
2662 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2663 That is, do not delete an evaporating overlay if it becomes
2664 empty after its bounds are adjusted to fit within its buffer.
2665 This fix caused other problems, and I'm reverting it until we get
2666 to the bottom of them.
2667
a8e7d6d7 26682012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2669
2670 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2671
a8e7d6d7 26722012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2673
2674 * xdisp.c (pos_visible_p): If the window start position is beyond
2675 ZV, start the display from buffer beginning. Prevents assertion
2676 violation in init_iterator when the minibuffer window is scrolled
2677 via the scroll bar.
2678
2679 * window.c (window_scroll_pixel_based): Likewise.
2680
a8e7d6d7 26812012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2682
2683 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2684
a8e7d6d7 26852012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2686
2687 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2688 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2689
a8e7d6d7 26902012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2691
b593d6a9
AH
2692 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2693 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2694
1c6900d9
EZ
26952012-04-26 Eli Zaretskii <eliz@gnu.org>
2696
4c3fa1d9
EZ
2697 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2698 display element, check also the underlying string or buffer
2699 character. (Bug#11341)
2700
1c6900d9
EZ
2701 * w32menu.c: Include w32heap.h.
2702 (add_menu_item): If the call to AppendMenuW (via
2703 unicode_append_menu) fails, disable Unicode menus only if we are
2704 running on Windows 9X/Me.
2705
42bf8205
AS
27062012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2707
2708 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2709 (xgetint): Add missing shift for LSB tags.
2710
b1bac16e
MR
27112012-04-24 Martin Rudalics <rudalics@gmx.at>
2712
2713 * keyboard.c (read_char): Don't wipe echo area for select window
2714 events: These might get delayed via `mouse-autoselect-window'
2715 (Bug#11304).
2716
d69621cc
JB
27172012-04-24 Juanma Barranquero <lekktu@gmail.com>
2718
2719 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2720 manipulation of :loaded-from data.
2721
02fd101b
JB
27222012-04-23 Juanma Barranquero <lekktu@gmail.com>
2723
2724 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2725 now a cons (bug#11311).
2726
888bec30
PE
27272012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2728
89a438bd
PE
2729 Do not create empty overlays with the evaporate property (Bug#9642).
2730 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2731 if it becomes empty after its bounds are adjusted to fit within
2732 its buffer. Without this fix, in a nonempty buffer (let ((o
2733 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2734 yields an empty overlay that has the evaporate property, which is
2735 not supposed to happen.
2736
1068fe4d
PE
2737 Fix minor GTK3 problems found by static checking.
2738 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2739 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2740 (struct _EmacsFixedClass, emacs_fixed_get_type):
2741 Move decls here from emacsgtkfixed.h, since they needn't be public.
2742 (emacs_fixed_get_type): Now static.
2743 (emacs_fixed_class_init): Omit unused local.
2744 (emacs_fixed_child_type): Remove; unused.
2745 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2746 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2747 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2748 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2749 (EMACS_FIXED_GET_CLASS): Remove; unused.
2750 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2751
888bec30
PE
2752 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2753 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2754
de85e130
PE
27552012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2756
d0baac98 2757 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2758 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2759 (__malloc_size_t, __malloc_ptrdiff_t):
2760 Remove. All uses removed, replaced by the definiens if needed,
2761 since we can assume C89 or better now.
2762 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2763 (protect_malloc_state, align, get_contiguous_space)
2764 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2765 (malloc_atfork_handler_child, malloc_enable_thread)
2766 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2767 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2768 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2769 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2770 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2771 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2772 Define using prototypes, not old style.
2773 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2774 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2775 (align): Don't assume that signed integer overflow wraps around.
2776 Omit unused local var.
2777 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2778 (_free_internal_nolock, memalign, mallochook, reallochook):
2779 Omit no-longer-needed casts.
2780 (valloc): Use getpagesize, not __getpagesize.
2781 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2782 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2783
de85e130
PE
2784 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2785
dcbf5805
MA
27862012-04-22 Michael Albinus <michael.albinus@gmx.de>
2787
2788 Move functions from C to Lisp. Make non-blocking method calls
2789 the default. Implement further D-Bus standard interfaces.
2790
2791 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2792 (QCdbus_request_name_allow_replacement)
2793 (QCdbus_request_name_replace_existing)
2794 (QCdbus_request_name_do_not_queue)
2795 (QCdbus_request_name_reply_primary_owner)
2796 (QCdbus_request_name_reply_in_queue)
2797 (QCdbus_request_name_reply_exists)
2798 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2799 (QCdbus_registered_serial, QCdbus_registered_method)
2800 (QCdbus_registered_signal): New Lisp objects.
2801 (XD_DEBUG_MESSAGE): Use sizeof.
2802 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2803 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2804 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2805 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2806 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2807 (xd_signature, xd_append_arg): Allow float for integer types.
2808 (xd_get_connection_references): New function.
b593d6a9
AH
2809 (xd_get_connection_address): Rename from xd_initialize.
2810 Return cached address.
dcbf5805
MA
2811 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2812 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2813 level.
2814 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2815 Return number of refcounts.
dcbf5805
MA
2816 (Fdbus_get_unique_name): Make stronger parameter check.
2817 (Fdbus_message_internal): New defun.
2818 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2819 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2820 (Fdbus_send_signal, Fdbus_register_service)
2821 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2822 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2823 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2824 (Vdbus_compiled_version, Vdbus_runtime_version)
2825 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2826 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2827 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2828 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2829 Adapt docstring.
dcbf5805 2830
52828e02
PE
28312012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2832
da05bc4c
PE
2833 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2834 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2835 Do not assume ptrdiff_t is the same width as 'int'.
2836
52828e02
PE
2837 * alloc.c: Handle unusual debugging option combinations.
2838 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2839 since the two debugging options are incompatible.
2840 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2841 is defined.
2842 (mem_init, mem_insert, mem_insert_fixup):
2843 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2844 (NEED_MEM_INSERT): Remove; no longer needed.
2845
f01769f9
LL
28462012-04-22 Leo Liu <sdl.web@gmail.com>
2847
2848 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2849
5790543d
PE
28502012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2851
2852 * sysdep.c [__FreeBSD__]: Minor cleanups.
2853 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2854 Use Emacs indenting style more consistently. Avoid some casts.
2855 Use 'double' consistently rather than mixing 'float' and 'double'.
2856
b91b7e4d
EW
28572012-04-21 Eduard Wiebe <usenet@pusto.de>
2858
b593d6a9
AH
2859 * sysdep.c (list_system_processes, system_process_attributes):
2860 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2861
6114eb15
AS
28622012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2863
2864 * lisp.mk (lisp): Update.
2865
2f38dff7
PE
28662012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2867
2868 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2869 It is never used otherwise.
2870
4ae29f89
SM
28712012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2872
2873 * print.c (print_preprocess): Only check print_depth if print-circle
2874 is nil.
2875 (print_object): Check for cycles even when print-circle is nil and
2876 print-gensym is t, but only check print_depth if print-circle is nil.
2877
f30d612a
CY
28782012-04-20 Chong Yidong <cyd@gnu.org>
2879
2880 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2881 set the status to "failed" and ensure that sentinel is run.
2882
c07a4c0b 28832012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2884
2885 * process.c (Fset_process_inherit_coding_system_flag)
2886 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2887 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2888
c07a4c0b 28892012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2890
2891 * xdisp.c (string_buffer_position_lim): Limit starting position to
2892 BEGV.
2893 (set_cursor_from_row): If called for a mode-line or header-line
2894 row, return zero immediately.
2895 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2896 farther than the first row after the header line, if any.
2897 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2898 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2899
c07a4c0b 29002012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2901
4ae29f89
SM
2902 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2903 (bug#11238).
ad3a2b41 2904
c07a4c0b 29052012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 29062012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2907
2908 configure: new option --enable-gcc-warnings (Bug#11207)
2909 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2910 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2911 (ALL_CFLAGS): Use new macros rather than old.
2912 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2913 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2914 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2915 -Wunused-result, -Wunused-variable. This should go away once
2916 the Emacs and Gnulib regex code is merged.
2917 (xmalloc, xrealloc): Now static.
2918
aba027e8
PE
29192012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2920
2921 * dired.c (Fsystem_groups): Remove unused local.
2922
e5a36063
GM
29232012-04-17 Glenn Morris <rgm@gnu.org>
2924
2925 * dired.c (Fsystem_users): Doc fix.
2926
316411f0
DA
29272012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2928
2929 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2930 (syms_of_dired): Add them.
2931
9426aba4
PE
29322012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2933
b62a57be
PE
2934 Fix minor alloc.c problems found by static checking.
2935 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2936 New extern decls, to avoid calling undeclared functions.
2937 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2938 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2939 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2940 (NEED_MEM_INSERT): New macro.
2941 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2942 Remove one incorrect comment and fix another.
b62a57be 2943
3539f31f
PE
2944 Fix minor ralloc.c problems found by static checking.
2945 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2946 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2947 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2948 (r_alloc_sbrk): Now static.
2949
a041960a
PE
2950 Improve ralloc.c interface checking.
2951 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2952 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2953 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2954 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2955 [REL_ALLOC]: ... to here, to check interface.
2956 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2957 Remove decls. This fixes an "It stinks!".
2958
9426aba4
PE
2959 * alloc.c (which_symbols): Fix alignment issue / type clash.
2960
d55c12ed
AS
29612012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2962
2963 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2964 (struct Lisp_Misc_Any): Likewise.
2965 (struct Lisp_Free): Likewise.
2966 * alloc.c (union aligned_Lisp_Symbol): Define.
2967 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2968 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2969 (union aligned_Lisp_Misc): Define.
2970 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2971 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2972 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2973
b948ce8b
PE
29742012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2975
2976 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2977 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2978 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2979 * s/netbsd.h, s/sol2-6.h:
2980 Remove definition of GC_MARK_STACK, since the default now works.
2981 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2982 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2983 no longer the default.
2984 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2985
35dc09a1 29862012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2987
35dc09a1
GM
2988 * lread.c (lisp_file_lexically_bound_p):
2989 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2990
35dc09a1
GM
29912012-04-14 Eli Zaretskii <eliz@gnu.org>
2992
2993 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2994 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2995
29962012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2997
2998 * nsterm.m (constrainFrameRect): Always constrain when there is only
2999 one screen (Bug#10962).
3000
bcd86815
KB
30012012-04-13 Ken Brown <kbrown@cornell.edu>
3002
3003 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3004
c25df26e
RT
30052012-04-13 Reuben Thomas <rrt@sc3d.org>
3006
3007 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3008
0fc59f1e
DC
30092012-04-11 Daniel Colascione <dancol@dancol.org>
3010
3011 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3012 against is gone. It's better to use vfork now so that when Cygwin
3013 gains a new, working vfork, we use it automatically (bug#10398).
3014
de8c03dc
SM
30152012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3016
3017 * window.c (save_window_save): Obey window-point-insertion-type.
3018
2f097256
GM
30192012-04-11 Glenn Morris <rgm@gnu.org>
3020
3021 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3022
453b951e
SM
30232012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3024
3025 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3026
75f1671a 30272012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3028
3029 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3030 (force_quit_count): New var.
3031 (handle_interrupt): Use it.
3032
2a8ce227
JB
30332012-04-10 Juanma Barranquero <lekktu@gmail.com>
3034
3035 * w32.c (w32_delayed_load): Record the full path of the library
3036 being loaded (bug#10424).
3037
935396c0
GM
30382012-04-09 Glenn Morris <rgm@gnu.org>
3039
05920a43
GM
3040 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3041 not just in the obarray, before snarfing them. (Bug#11036)
3042
935396c0
GM
3043 * Makefile.in ($(leimdir)/leim-list.el):
3044 Pass EMACS rather than BUILT_EMACS.
3045
a18ecafa
TZ
30462012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3047
3048 * process.c (make_process):
3049 * process.h: Add integer `gnutls_handshakes_tried' member to
3050 process struct.
3051
6bbef4e5
JC
3052 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3053 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3054
3055 * gnutls.c (gnutls_log_function2i): Convenience log function.
3056 (emacs_gnutls_read): Use new log functions,
3057 `gnutls_handshakes_tried' process member, and
3058 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3059 attempts per process (connection).
3060
b4d3bc10
CY
30612012-04-09 Chong Yidong <cyd@gnu.org>
3062
3063 * eval.c (Fuser_variable_p, user_variable_p_eh)
3064 (lisp_indirect_variable): Functions deleted.
3065 (Fdefvar): Caller changed.
3066
3067 * callint.c (Finteractive, Fcall_interactively):
3068 * minibuf.c (Fread_variable): Callers changed.
3069
70f4d973
EZ
30702012-04-09 Eli Zaretskii <eliz@gnu.org>
3071
3072 * xdisp.c (set_cursor_from_row): If the display string appears in
3073 the buffer at position that is closer to point than the position
3074 after the display string, display the cursor on the first glyph of
3075 the display string. Fixes cursor display when a 'display' text
3076 property immediately follows invisible text. (Bug#11094)
3077
cb3c2e3e
PE
30782012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3079
3080 composite.c: use 'double' consistently
3081 * composite.c (get_composition_id): Use 'double' consistently
3082 instead of converting 'float' to 'double' and vice versa; this is
3083 easier to understand and avoids a GCC warning.
3084
fd06db5d
GM
30852012-04-09 Glenn Morris <rgm@gnu.org>
3086
50fe702a
GM
3087 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3088 preparation for dumping it with emacs. (Bug#4789)
3089 (leimdir): New variable.
3090 ($(leimdir)/leim-list.el): New rule.
3091 (emacs$(EXEEXT)): Depend on leim-list.el.
3092
fd06db5d
GM
3093 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3094 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3095 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3096
55c131ee
AS
30972012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3098
3099 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3100 proper alignment.
3101
9209588f
JB
31022012-04-07 Juanma Barranquero <lekktu@gmail.com>
3103
3104 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3105 Remove unused local variable.
3106
e3fb2efb
PE
31072012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3108
3109 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3110 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3111 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3112 objects, as mark_maybe_pointer will catch them otherwise.
3113 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3114 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3115
b5385551
PE
31162012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3117
3118 Fix typo that broke non-Windows builds.
3119 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3120
9078ead6
EZ
31212012-04-07 Eli Zaretskii <eliz@gnu.org>
3122
3123 Support building on MS-Windows with libxml2.
3124
3125 * makefile.w32-in (OBJ2): Add xml.$(O).
3126 (GLOBAL_SOURCES): Add xml.c.
3127 ($(BLD)/xml.$(O)): New dependency list.
3128
3129 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3130 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3131 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3132 [!WINDOWSNT]: New macros.
3133 (init_libxml2_functions, libxml2_loaded_p): New functions.
3134 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3135 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3136 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3137 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3138 linked in).
6bbef4e5
JC
3139 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3140 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3141 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3142
3143 * emacs.c: Don't include libxml/parser.h.
3144 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3145 xmlCleanupParser directly.
3146
3147 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3148
3811fdf3
EZ
31492012-04-07 Eli Zaretskii <eliz@gnu.org>
3150
3151 * indent.c (Fvertical_motion): If there is a display string at
3152 point, use it.vpos to compute how many lines to backtrack after
3153 move_it_to point. (Bug#11133)
3154
2f8e16b2
EZ
31552012-04-06 Eli Zaretskii <eliz@gnu.org>
3156
3157 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3158 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3159 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3160 macros related to unification of CJK characters. For the details,
3161 see the discussion following the message here:
3162 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3163
3d439cd1
CY
31642012-04-04 Chong Yidong <cyd@gnu.org>
3165
3166 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3167
8bc53d00
EZ
31682012-04-01 Eli Zaretskii <eliz@gnu.org>
3169
3170 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3171 instead of alloca. (Bug#11138)
3172
3b0512a3
AS
31732012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3174
3175 * w32menu.c (is_simple_dialog): Properly check lisp types.
3176 (Bug#11141)
3177
8427ddd2
EZ
31782012-03-31 Eli Zaretskii <eliz@gnu.org>
3179
979022ef
EZ
3180 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3181 position we get to after a call to move_it_to fails the
3182 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3183 only if we wind up in a string from display property. (Bug#11063)
3184
a6b1c7cc
EZ
3185 * window.c (Fdelete_other_windows_internal): Invalidate the row
3186 and column information about mouse highlight, so that redisplay
3187 restores it after reallocating the glyph matrices. (Bug#7464)
3188
8427ddd2
EZ
3189 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3190 string comes from a `display' text property, use the buffer
3191 position of that property as if we actually saw that position in
3192 the row's glyphs.
697ba24b
EZ
3193 (move_it_by_lines): Remove the assertion that
3194 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3195 violated when there's a before-string at the beginning of a line.
3196 (Bug#11063)
8427ddd2 3197
65a0a738
EZ
31982012-03-30 Eli Zaretskii <eliz@gnu.org>
3199
3200 * xdisp.c (append_space_for_newline): If the default face was
3201 remapped, use the remapped face for the appended newline.
3202 (extend_face_to_end_of_line): Use the remapped default face for
3203 extending the face to the end of the line.
3204 (display_line): Call extend_face_to_end_of_line when the default
3205 face was remapped. (Bug#11068)
3206
581355cc
EZ
32072012-03-29 Eli Zaretskii <eliz@gnu.org>
3208
3209 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3210
e8fc049f
SM
32112012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3212
3213 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3214
4fb9a543
GM
32152012-03-27 Glenn Morris <rgm@gnu.org>
3216
3217 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3218 Doc fixes.
3219
679910f1
KH
32202012-03-26 Kenichi Handa <handa@m17n.org>
3221
3222 * dispextern.h (struct glyph): Fix previous change. Change the
3223 bit length of glyphless.ch to 25 (Bug#11082).
3224
90d49b7f
CY
32252012-03-26 Chong Yidong <cyd@gnu.org>
3226
3227 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3228 (command_loop_1): Use it; inhibit selection update for
3229 handle-select-window too (Bug#8996).
3230
f514f6f0
FP
32312012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3232
e8fc049f 3233 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3234
bf43fa51
KH
32352012-03-25 Kenichi Handa <handa@m17n.org>
3236
3237 * dispextern.h (struct glyph): Change the bit length of
3238 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3239
8a0c01dd
EZ
32402012-03-24 Eli Zaretskii <eliz@gnu.org>
3241
3242 * s/ms-w32.h (tzname): Include time.h before redirecting to
3243 _tzname. Fixes the MSVC build. (Bug#9960)
3244
7d1c3a76
AS
32452012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3246
8ed79523
AS
3247 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3248 characters.
3249
7d1c3a76
AS
3250 * xterm.c (XTread_socket): Only modify handling_signal if
3251 !SYNC_INPUT. (Bug#11080)
3252
e99a9b8b
EZ
32532012-03-23 Eli Zaretskii <eliz@gnu.org>
3254
3255 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3256 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3257 when fetching a multibyte character consumes more bytes than
3258 CHAR_BYTES returns, due to unification of CJK characters in
3259 string_char. (Bug#11073)
3260
5063c0e1
TN
32612012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3262
3263 * process.c (wait_reading_process_output): Handle pty disconnect
3264 by refraining from sending oneself a SIGCHLD (bug#10933).
3265
9f851fbd
CY
32662012-03-22 Chong Yidong <cyd@gnu.org>
3267
3268 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3269
5063c0e1 3270 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3271 Mark string as coming from a prefix property.
3272 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3273 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3274
fb5b8aca
CY
32752012-03-21 Chong Yidong <cyd@gnu.org>
3276
3277 * xfaces.c (Vface_remapping_alist): Doc fix.
3278
62356a1b
EZ
32792012-03-20 Eli Zaretskii <eliz@gnu.org>
3280
3281 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3282 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3283 Doc fixes.
62356a1b 3284
025de85b
CY
32852012-03-20 Chong Yidong <cyd@gnu.org>
3286
3287 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3288 to reflect default non-nil value of redisplay-dont-pause.
3289
4827f94e
KH
32902012-03-19 Kenichi Handa <handa@m17n.org>
3291
3292 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3293 it fit in a valid range (Bug#11003).
3294
e50a24a2
EZ
32952012-03-18 Eli Zaretskii <eliz@gnu.org>
3296
3297 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3298 that is not from display property, accept the row as a "cursor
3299 row" if one of the string's character has a non-nil `cursor'
3300 property. Fixes cursor positioning when there are newlines in
3301 overlay strings, e.g. in icomplete.el. (Bug#11035)
3302
9af5ed87
PE
33032012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3304
3305 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3306
d1f55f16
CY
33072012-03-12 Chong Yidong <cyd@gnu.org>
3308
3309 * eval.c (inhibit_lisp_code): Rename from
3310 inhibit_window_configuration_change_hook; move from window.c.
3311
3312 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3313 * window.c (run_window_configuration_change_hook)
3314 (syms_of_window): Callers changed.
3315
66c5eebd
CY
33162012-03-11 Chong Yidong <cyd@gnu.org>
3317
413df973
CY
3318 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3319
66c5eebd
CY
3320 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3321
1de11f56
CY
33222012-03-10 Chong Yidong <cyd@gnu.org>
3323
3324 * frame.c (other_visible_frames): Don't assume the selected frame
3325 is visible (Bug#10955).
3326
cae07000
SM
33272012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3328
3329 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3330
89c94350
JD
33312012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3332
3333 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3334 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3335 zero (Bug#10954).
3336
999dd333
GM
33372012-03-03 Glenn Morris <rgm@gnu.org>
3338
01a6dcc8 3339 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3340
de0100f2
EZ
33412012-03-02 Eli Zaretskii <eliz@gnu.org>
3342
3343 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3344 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3345 (redisplay_window, next_element_from_string): Fix typos in
3346 comments.
3e441275
EZ
3347 (redisplay_window): Pass to move_it_vertically the margin in
3348 pixels, not in screen lines.
de0100f2 3349
96a72ee9
GM
33502012-03-02 Glenn Morris <rgm@gnu.org>
3351
3352 * buffer.c (buffer-list-update-hook): Doc fix.
3353
312508d7
EZ
33542012-02-29 Eli Zaretskii <eliz@gnu.org>
3355
3356 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3357 push_it before setting up the iterator for the first overlay
3358 string, even if we have an empty string loaded.
3359 (next_overlay_string): If there's an empty string on the iterator
3360 stack, pop the stack. (Bug#10903)
3361
27f3c637
PE
33622012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3363
3364 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3365 Suggested by Stefan Monnier in
3366 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3367 * alloc.c (widen_to_Lisp_Object): New static function.
3368 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3369 and widening them to Lisp_Objects. This would work even if
3370 USE_LSB_TAG is defined and wide integers are used, which might
3371 happen in a future version of Emacs.
3372
3c9dfce6
CY
33732012-02-25 Chong Yidong <cyd@gnu.org>
3374
fa74b241
CY
3375 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3376 Doc fix.
3377
3c9dfce6
CY
3378 * xselect.c (Fx_selection_exists_p): Doc fix.
3379 (x_clipboard_manager_save_all): Print an informative message
3380 before saving to clipboard manager.
3381
9486df08
CY
33822012-02-24 Chong Yidong <cyd@gnu.org>
3383
3384 * keyboard.c (process_special_events): Handle all X selection
3385 requests in kbd_buffer, not just the next one (Bug#8869).
3386
f01d3321
CY
33872012-02-23 Chong Yidong <cyd@gnu.org>
3388
3389 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3390 call when setting menu-bar-lines and tool-bar-lines parameters.
3391 (unwind_create_frame_1): New helper function.
3392
3393 * window.c (inhibit_window_configuration_change_hook): New var.
3394 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3395 (syms_of_window): Initialize it.
f01d3321 3396
86b847b6
CY
33972012-02-22 Chong Yidong <cyd@gnu.org>
3398
3399 * xterm.c (x_draw_image_relief): Add missing type check for
3400 Vtool_bar_button_margin (Bug#10743).
3401
a59225b1
CY
34022012-02-21 Chong Yidong <cyd@gnu.org>
3403
3404 * fileio.c (Vfile_name_handler_alist): Doc fix.
3405
3406 * buffer.c (Fget_file_buffer): Protect against invalid file
3407 handler return value.
3408
310f5bd4
PE
34092012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3410
cb3a28cc
PE
3411 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3412 when computing $valmask.
3413
310f5bd4
PE
3414 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3415 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3416 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3417 It's useless in that case, and it can cause problems on hosts
3418 that allocate halves of EMACS_INT values separately.
3419 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3420 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3421 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3422 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3423 it avoids undefined behavior on hosts where shifting right by more
3424 than the word width has undefined behavior.
3425
2375c96a
CY
34262012-02-19 Chong Yidong <cyd@gnu.org>
3427
3428 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3429 (Funhandled_file_name_directory, Ffile_name_as_directory)
3430 (Fdirectory_file_name, Fexpand_file_name)
3431 (Fsubstitute_in_file_name): Protect against invalid file handler
3432 return values (Bug#10845).
3433
3eb49e71
EZ
34342012-02-18 Eli Zaretskii <eliz@gnu.org>
3435
3436 * .gdbinit (pitx): Fix incorrect references to fields of the
3437 iterator stack.
3438
7b926f3f
CY
34392012-02-17 Chong Yidong <cyd@gnu.org>
3440
3441 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3442
11273115
PE
34432012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3444
3445 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3446 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3447
c3a70e2b
CY
34482012-02-15 Chong Yidong <cyd@gnu.org>
3449
3450 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3451 marked as special. Also, starting docstrings with * is obsolete.
3452
0ca43699
AS
34532012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3454
3455 * gnutls.c (emacs_gnutls_write): Fix last change.
3456
2e8f3c56
LI
34572012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3458
3459 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3460 send_process.
3461
af70074f
SM
34622012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3463
3464 * keymap.c (Fsingle_key_description): Handle char ranges.
3465
95986d52
CY
34662012-02-12 Chong Yidong <cyd@gnu.org>
3467
afd83bd1
CY
3468 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3469 as that creates a dangerous corner case.
3470
95986d52
CY
3471 * window.c (Fdelete_window_internal): Invalidate the mouse
3472 highlight (Bug#9904).
3473
bd7da63e
GM
34742012-02-12 Glenn Morris <rgm@gnu.org>
3475
3476 * xselect.c (Fx_own_selection_internal)
3477 (Fx_get_selection_internal, Fx_disown_selection_internal)
3478 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3479 * nsselect.m (Fx_own_selection_internal)
3480 (Fx_disown_selection_internal, Fx_selection_exists_p)
3481 (Fx_selection_owner_p, Fx_get_selection_internal):
3482 Sync docs and argument specs with the xselect.c versions.
3483
77abcbc2
LI
34842012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3485
3486 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3487
90b671e2
EZ
34882012-02-11 Eli Zaretskii <eliz@gnu.org>
3489
1c0ca0b7
EZ
3490 * w32select.c (Fx_selection_exists_p): Sync doc string and
3491 argument list with xselect.c. (Bug#10783)
3492
3493 * w16select.c (Fx_selection_exists_p): Sync doc string and
3494 argument list with xselect.c. (Bug#10783)
90b671e2 3495
49241268
GM
34962012-02-10 Glenn Morris <rgm@gnu.org>
3497
3498 * fns.c (Fsecure_hash): Doc fix.
3499
f998bbe7 35002012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3501
3502 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3503
0992bd9c
CY
35042012-02-07 Chong Yidong <cyd@gnu.org>
3505
3506 * buffer.c (Fbuffer_local_variables)
3507 (buffer_lisp_local_variables): Handle unbound vars correctly;
3508 don't let Qunbound leak into Lisp.
3509
af008560
GM
35102012-02-07 Glenn Morris <rgm@gnu.org>
3511
dd605cc4
GM
3512 * image.c (Fimagemagick_types): Doc fix.
3513
af008560
GM
3514 * image.c (imagemagick-render-type): Change it from a lisp object
3515 to an integer. Move the doc here from the lisp manual.
3516 Treat all values not equal to 0 the same.
3517
1449fa1d
CY
35182012-02-06 Chong Yidong <cyd@gnu.org>
3519
3520 * doc.c (store_function_docstring): Avoid applying docstring of
3521 alias to base function (Bug#2603).
3522
3723ec07
AS
35232012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3524
3525 * .gdbinit (pp1, pv1): Remove redundant defines.
3526 (pr): Use pp.
3527
79c1cc1e
CY
35282012-02-04 Chong Yidong <cyd@gnu.org>
3529
3530 * nsterm.m: Declare a global (Bug#10694).
3531
d7f29f8e
EZ
35322012-02-04 Eli Zaretskii <eliz@gnu.org>
3533
cae07000
SM
3534 * w32.c (get_emacs_configuration_options):
3535 Include --enable-checking, if specified, in the return value.
d7f29f8e 3536
3b95a6f9
MR
35372012-02-04 Martin Rudalics <rudalics@gmx.at>
3538
3539 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3540 after rounding frame sizes. (Bug#9723)
3541
d6fa96a6
EZ
35422012-02-04 Eli Zaretskii <eliz@gnu.org>
3543
3544 * keyboard.c (adjust_point_for_property): Don't position point
3545 before BEGV. (Bug#10696)
3546
df0b2940
PE
35472012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3548
3549 Handle overflow when computing char display width (Bug#9496).
3550 * character.c (char_width): Return EMACS_INT, not int.
3551 (char_width, c_string_width): Check for overflow when
3552 computing the width; this is possible now that individual
3553 characters can have unbounded width. Problem introduced
3554 by merge from Emacs 23 on 2012-01-19.
3555
6bee44d6
MA
35562012-02-02 Michael Albinus <michael.albinus@gmx.de>
3557
3558 * dbusbind.c (Fdbus_register_method): Mention the return value
3559 :ignore in the docstring.
3560
44f92739
GM
35612012-02-02 Glenn Morris <rgm@gnu.org>
3562
1b9f60cc
GM
3563 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3564
44f92739
GM
3565 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3566 Unconditionally set to t. (Bug#10673)
3567 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3568 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3569 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3570
c5d3843c
KH
35712012-02-02 Kenichi Handa <handa@m17n.org>
3572
3573 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3574 0, do not call append_composite_glyph.
3575
159462d4 35762012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3577
3578 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3579 NULL (Bug#6988).
3580 (x_produce_glyphs): If the component of a composition is a null
3581 string, set it->pixel_width to 1 to avoid zero-width glyph.
3582
78cef877
EZ
35832012-02-01 Eli Zaretskii <eliz@gnu.org>
3584
3585 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3586 first 2 arguments are identical. This makes inserting large
3587 output from a subprocess an order of magnitude faster on
3588 MS-Windows, where all sbrk'ed memory is always contiguous.
3589
97897668
GM
35902012-01-31 Glenn Morris <rgm@gnu.org>
3591
3592 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3593 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3594 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3595
31fd3586
GM
35962012-01-29 Glenn Morris <rgm@gnu.org>
3597
3598 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3599
0e24a8b2
CY
36002012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3601
3602 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3603
cc0adcb0
CY
36042012-01-28 Chong Yidong <cyd@gnu.org>
3605
3606 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3607
acc28cb9
CY
36082012-01-26 Chong Yidong <cyd@gnu.org>
3609
9c69cfb7
CY
3610 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3611
acc28cb9
CY
3612 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3613 repeat counts (Bug#10507).
3614
48da7392
GM
36152012-01-26 Glenn Morris <rgm@gnu.org>
3616
3617 * lread.c (syms_of_lread): Doc fix.
3618
14af5f7f
CY
36192012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3620
3621 * coding.c (encode_designation_at_bol): Change return value to
3622 EMACS_INT.
3623
0b21c100
CY
36242012-01-25 Chong Yidong <cyd@gnu.org>
3625
3626 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3627
3c2907f7
CY
36282012-01-21 Chong Yidong <cyd@gnu.org>
3629
3630 * floatfns.c (Fcopysign): Make the second argument non-optional,
3631 since nil is not allowed anyway.
3632
959ad23f
AS
36332012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3634
3635 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3636 (send_process): Likewise.
3637
34a02f46
MR
36382012-01-19 Martin Rudalics <rudalics@gmx.at>
3639
3640 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3641 (Vwindow_persistent_parameters): Do not use Qstate.
3642 Rewrite doc-strings.
34a02f46 3643
1259009a 36442012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3645
3646 * character.c (char_width): New function.
70d4fdf6
GM
3647 (Fchar_width, c_string_width, lisp_string_width):
3648 Use char_width (Bug#9496).
25ed9e61 3649
6a6ee00d
MR
36502012-01-16 Martin Rudalics <rudalics@gmx.at>
3651
3652 * window.c (Vwindow_persistent_parameters): New variable.
3653 (Fset_window_configuration, save_window_save): Handle persistent
3654 window parameters.
3655
c85efaf7
EZ
36562012-01-14 Eli Zaretskii <eliz@gnu.org>
3657
3658 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3659 thrashing the stack of the thread. (Bug#9087)
3660
5944709e
PE
36612012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3662
3663 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3664
e71f5d99
EZ
36652012-01-11 Eli Zaretskii <eliz@gnu.org>
3666
3667 * xdisp.c (rows_from_pos_range): Handle the case where the
3668 highlight ends on a newline. (Bug#10464)
3669 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3670 he end column for display of highlight that ends on a newline
3671 before a R2L line.
3672
ce316182
GM
36732012-01-11 Glenn Morris <rgm@gnu.org>
3674
3675 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3676 from load-path also when installation-directory is nil. (Bug#10208)
3677
5b43da69
GM
36782012-01-10 Glenn Morris <rgm@gnu.org>
3679
74cc8ff9
GM
3680 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3681
7d8d6e4e
GM
3682 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3683 Update template values to be closer to their typical values these days.
5b43da69 3684
a0db8d43
EZ
36852012-01-09 Eli Zaretskii <eliz@gnu.org>
3686
3687 * xdisp.c (rows_from_pos_range): Accept additional argument
3688 DISP_STRING, and accept any glyph in a row whose object is that
3689 string as eligible for mouse highlight. Fixes mouse highlight of
3690 display strings from overlays. (Bug#10464)
3691
9a0115ab 36922012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3693
b9110d6a 3694 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3695 * fileio.c (auto_saving_dir_umask): New static var.
3696 (Fmake_directory_internal): Use it.
3697 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3698 creating the directory. The old code temporarily assigns
3699 too-generous permissions to the directory.
3700 (do_auto_save_eh): Clear it.
b9110d6a 3701 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3702 that the var is always cleared.
3703
6c1bd3f3
EZ
37042012-01-07 Eli Zaretskii <eliz@gnu.org>
3705
3706 * search.c (scan_buffer): Pass character positions to
3707 know_region_cache, not byte positions. (Bug#6540)
3708
069d2b50
L
37092012-01-07 LynX <_LynX@bk.ru> (tiny change)
3710
3711 * w32.c (sys_rename): Report EXDEV when rename of a directory
3712 fails because the target is on another logical disk. (Bug#10284)
3713
75bf0d33
DB
37142012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3715
3716 * xterm.c (x_embed_request_focus): New function.
3717
3718 * xterm.h: Add prototype.
3719
3720 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3721
1c6e5a32
GM
37222012-01-05 Glenn Morris <rgm@gnu.org>
3723
3724 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3725
651e947e
EZ
37262012-01-01 Eli Zaretskii <eliz@gnu.org>
3727
3728 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3729 Load gnutls_transport_set_lowat only if GnuTLS version is below
3730 2.11.1.
3731 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3732 GnuTLS versions below 2.11.1.
3733
3778cdd8
AL
37342011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3735
3736 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3737 to the doc string advising against its use for altering the way
3738 windows are scrolled.
3739
0e5317f7
KH
37402011-12-28 Kenichi Handa <handa@m17n.org>
3741
3742 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3743 coding-system ASCII compatible only when it does not produce BOM
3744 on encoding (Bug#10383).
3745
93d5ca1f
JD
37462011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3747
3748 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3749 can scroll.
3750 (create_and_show_popup_menu): Always use menu_position_func for
3751 Gtk3 (Bug#10361).
3752
ca22b785
AS
37532011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3754
3755 * callint.c (Fcall_interactively): Don't truncate prompt string.
3756
d048e1e6
EZ
37572011-12-23 Eli Zaretskii <eliz@gnu.org>
3758
3759 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3760 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3761 resumed from there (after widening). (Bug#10360)
d048e1e6 3762
5ccaba1f
JD
37632011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3764
3765 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3766
204ee57f
JD
37672011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3768
b81d40f0
JB
3769 * nsterm.m (x_free_frame_resources):
3770 Release f->output_data.ns->miniimage.
204ee57f
JD
3771 (ns_index_color): Fix indentation. Do not retain
3772 color_table->colors[i].
3773
3774 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3775 before returning.
3776
3777 * nsfns.m (x_set_background_color): Assign return value from
3778 ns_index_color to face-background instead of NSColor*.
3779 (ns_implicitly_set_icon_type): Fix indentation.
3780 Change assignment in for loop to comparison.
3781
3782 * emacs.c (ns_pool): New variable.
3783 (main): Assign ns_pool.
3784 (Fkill_emacs): Call ns_release_autorelease_pool.
3785
3786 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3787 autorelease fdesc, release fdAttrs and tdict.
3788 (ns_get_covering_families): Release charset.
3789 (ns_findfonts): Release NSFontDescriptor created with new.
3790 (ns_uni_to_glyphs): Fix indentation.
3791 (setString): Release attrStr before assigning new value.
3792
c803b2b7
JD
37932011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3794
678f4426
JD
3795 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3796 and NS_IMPL_COCOA.
3797 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3798 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3799
cd394be1 38002011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3801
5fecd5fc
JD
3802 * nsterm.m (ns_term_init): Subscribe for notifications
3803 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3804 to method trackingNotification in EmacsMenu.
3805
3806 * nsmenu.m (trackingMenu): New variable.
3771cb17 3807 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3808 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3809 from Aquamacs (Bug#7030).
678f4426
JD
3810
38112011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3812
c803b2b7
JD
3813 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3814 (symbol_to_nsstring): Fix indentation.
3815 (ns_symbol_to_pb): New function.
cae07000
SM
3816 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3817 (Fns_rotate_cut_buffers_internal): Remove.
3818 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3819 Fns_store_cut_buffer_internal.
3820 (ns_get_foreign_selection, Fx_own_selection_internal)
3821 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3822 (Fns_get_selection_internal, Fns_store_selection_internal):
3823 Use ns_symbol_to_pb and check if return value is nil.
3824 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3825 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3826 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3827 renamed to Sns_store_selection_internal.
3828 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3829 and remove this function.
3830 (ns_handle_selection_clear): Remove, never used.
3831 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3832 here.
3833
e1b01a3a
KB
38342011-12-17 Ken Brown <kbrown@cornell.edu>
3835
3836 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3837 GID is unknown (Bug#10257).
3838
2adb6e85
PE
38392011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3840
3841 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3842 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3843 which caused a build failure on GNU/Linux IA-64. This problem was
3844 introduced by my 2011-10-07 patch.
3845
d1d7b339
JL
38462011-12-15 Juri Linkov <juri@jurta.org>
3847
3848 * image.c (imagemagick_error): New function. (Bug#10112)
3849 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3850 Use `imagemagick_error' where ImageMagick functions return
3851 `MagickFalse'.
3852 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3853 proper order.
3854
100d5755
KH
38552011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3856
3857 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3858 fill background (Bug#8992).
3859
454592a6
MR
38602011-12-13 Martin Rudalics <rudalics@gmx.at>
3861
3862 * window.c (Vwindow_combination_resize)
3863 (Vwindow_combination_limit): Use t instead of non-nil in
3864 doc-strings.
61d4b438
MR
3865 (Vrecenter_redisplay): Add first sentence of doc-string on
3866 separate line.
53524d93 3867 (Frecenter): Fix doc-string typo.
454592a6 3868
3633e3aa
KH
38692011-12-11 Kenichi Handa <handa@m17n.org>
3870
3871 * coding.c (Funencodable_char_position): Pay attention to the
3872 buffer text relocation (Bug#9389).
3873
7b9d523a 38742011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3875
7b9d523a
JD
3876 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3877 gtk_init (Bug#10100).
3878
b73189c6
EZ
38792011-12-10 Eli Zaretskii <eliz@gnu.org>
3880
3881 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3882 IT->string is nil. (Bug#10263)
3883
f7dfe5d6
JD
38842011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3885
83faebb4
JD
3886 * nsterm.h (x_free_frame_resources): Declare.
3887
f7dfe5d6
JD
3888 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3889 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3890
3891 * nsterm.h (ns_get_defaults_value): Declare.
3892
3893 * nsterm.m (ns_default): Call ns_get_defaults_value.
3894
7cd4e72c
EZ
38952011-12-09 Eli Zaretskii <eliz@gnu.org>
3896
3897 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3898 (Bug#10170)
3899
b34d7317
YM
39002011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3901
3902 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3903 that where the value of an _OBJC_* symbol points to is in the .bss
3904 section (Bug#10240).
3905
76470ad1
KH
39062011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3907
3908 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3909 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3910
745fff94
KH
39112011-12-08 Kenichi Handa <handa@m17n.org>
3912
3913 * ftfont.c (get_adstyle_property): Fix previous change
3914 (Bug#10233).
3915
6e44397c
JB
39162011-12-07 Juanma Barranquero <lekktu@gmail.com>
3917
3918 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3919 dirs from the default value of EMACSLOADPATH (bug#10208).
3920
7efa6272
GM
39212011-12-07 Glenn Morris <rgm@gnu.org>
3922
3923 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3924 installation and source directories as well. (Bug#10208)
3925
f6fc4d87
CY
39262011-12-06 Chong Yidong <cyd@gnu.org>
3927
3928 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3929
2bf26180
GM
39302011-12-06 Glenn Morris <rgm@gnu.org>
3931
3932 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3933 as an error, not just -1. (Bug#10217)
3934
3a6ad4f0
CY
39352011-12-05 Chong Yidong <cyd@gnu.org>
3936
3937 * keyboard.c (process_special_events): New function.
3938 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3939
75a3b399
PE
39402011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3941
3942 * coding.c (encode_designation_at_bol): Don't use uninitialized
3943 local variable (Bug#9318).
3944
c3c9e25e
KH
39452011-12-05 Kenichi Handa <handa@m17n.org>
3946
3947 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3948 return Qnil (Bug#8046, Bug#10193).
3949
5eb05ea3
KH
39502011-12-05 Kenichi Handa <handa@m17n.org>
3951
3952 * coding.c (encode_designation_at_bol): New args charbuf_end and
3953 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3954 (coding_set_source): Return how many bytes coding->source was
3955 relocated.
3956 (coding_set_destination): Return how many bytes
3957 coding->destination was relocated.
3958 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3959 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3960
39612011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3962
3963 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3964 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3965 macro (Bug#9318).
3966
39672011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3968
3969 The following changes are to fix Bug#9318.
3970
a79703f5 3971 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3972 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3973 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3974 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3975
7dbda6df
JB
39762011-12-05 Juanma Barranquero <lekktu@gmail.com>
3977
3978 * lisp.h (process_quit_flag): Fix external declaration.
3979
6d5eb5b0
SM
39802011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3981
3982 Don't macro-inline non-performance-critical code.
3983 * eval.c (process_quit_flag): New function.
3984 * lisp.h (QUIT): Use it.
3985
a0c3fad0
JD
39862011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3987
3988 * nsfns.m (get_geometry_from_preferences): New function.
3989 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3990
6c07aac2
AS
39912011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3992
3993 * emacs.c (Qkill_emacs): Define.
3994 (syms_of_emacs): Initialize it.
3995 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3996 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3997 (quit_throw_to_read_char): Add parameter `from_signal'.
3998 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3999 * lisp.h (QUIT): Call Fkill_emacs if requested.
4000
c052ead4
JD
40012011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4002
4003 * widget.c (update_wm_hints): Return if wmshell is null.
4004 (widget_update_wm_size_hints): New function.
4005
4006 * widget.h (widget_update_wm_size_hints): Declare.
4007
4008 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4009 widget_update_wm_size_hints (Bug#10104).
4010
9e49252b
EZ
40112011-12-03 Eli Zaretskii <eliz@gnu.org>
4012
4013 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4014 before a newline, prepare the bidi iterator for consuming the
4015 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4016 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4017
02b16839
JL
40182011-12-02 Juri Linkov <juri@jurta.org>
4019
4020 * search.c (Fword_search_regexp): New Lisp function created from
4021 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4022 (Fword_search_backward, Fword_search_forward)
4023 (Fword_search_backward_lax, Fword_search_forward_lax):
4024 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4025 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4026
0068070e
SM
40272011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4028
4029 * fileio.c (Finsert_file_contents): Move after-change-function call
4030 to before the "handled:" label, since all "goto handled" appear in
4031 cases where the *-change-functions have already been properly called
4032 (bug#10117).
4033
3360a3fc
AS
40342011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4035
4036 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4037 waiting for input. (Bug#10169)
4038
73d6c093
EZ
40392011-11-30 Eli Zaretskii <eliz@gnu.org>
4040
4041 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4042 verifies glyph row's hash code--we have just reallocated the
4043 glyphs, so their contents can be complete garbage. (Bug#10164)
4044
febe6bea
JB
40452011-11-30 Juanma Barranquero <lekktu@gmail.com>
4046
4047 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4048
801a4313
EZ
40492011-11-30 Eli Zaretskii <eliz@gnu.org>
4050
4051 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4052 attributes are tested _before_ calling verify_row_hash, to protect
4053 against GCC re-ordering of the tests. (Bug#10164)
4054
2b56b87e
JD
40552011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4056
4057 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4058
4059 * xterm.c (handle_one_xevent): Only set async_visible and friends
4060 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4061 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4062 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4063
dbf31225
PE
40642011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4065
4066 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4067 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4068 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4069 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4070 All uses changed to use GCPRO1 etc.
4071 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4072 Revert to old implementation (i.e., before 2011-03-11).
4073
1305621b
YM
40742011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4075
4076 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4077 of scroll runs so as to avoid assigning disabled bogus rows and
4078 unnecessary graphics copy operations.
4079
8c9afb46
EZ
40802011-11-27 Eli Zaretskii <eliz@gnu.org>
4081
4082 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4083 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4084 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4085 (malloc, free, realloc, calloc): Redirect to e_* only when
4086 compiling Emacs.
4087
4088 * lisp.h (GCTYPEBITS): Move before first use.
4089 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4090 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4091 this macro definition.
4092
4093 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4094 _MSC_VER.
4095
54e9e3bf
JD
40962011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4097
6d5eb5b0
SM
4098 * gtkutil.c (xg_create_frame_widgets):
4099 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4100 present with Gtk+ 2.0.
4101
83aca1cb
PE
41022011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4103
4104 * fileio.c (Finsert_file_contents): Undo previous change; see
4105 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4106
5b76caa4
PE
41072011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4108
4109 Rename locals to avoid shadowing.
4110 * fileio.c (Finsert_file_contents):
4111 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4112 * process.c (wait_reading_process_output):
4113 Rename inner 'proc' to 'p' to avoid shadowing.
4114 Indent for consistency with usual Emacs style.
4115
8c535114
EZ
41162011-11-25 Eli Zaretskii <eliz@gnu.org>
4117
4118 * xdisp.c (redisplay_window): If cursor row is not fully visible
4119 after recentering, and scroll-conservatively is set to a large
4120 number, scroll window by a few more lines to make the cursor fully
4121 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4122 (start_display): Don't move to the next line if the display should
4123 start at a newline that is part of a display vector or an overlay
4124 string. (Bug#10119)
8c535114 4125
fa4fdb5c
JL
41262011-11-24 Juri Linkov <juri@jurta.org>
4127
4128 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4129 after the `MagickPingImage' call. (Bug#10112)
4130
90ec88df
CY
41312011-11-23 Chong Yidong <cyd@gnu.org>
4132
4133 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4134
56e2e794
MR
41352011-11-23 Martin Rudalics <rudalics@gmx.at>
4136
4137 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4138 making another buffer current. (Bug#10114)
4139
b6e64c41
GM
41402011-11-23 Glenn Morris <rgm@gnu.org>
4141
4142 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4143
6b21de18
CY
41442011-11-23 Chong Yidong <cyd@gnu.org>
4145
4146 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4147 using it (Bug#5984).
4148
b12cd789
EZ
41492011-11-22 Eli Zaretskii <eliz@gnu.org>
4150
4151 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4152 and header-lines, as they don't have one computed for them.
4153 (Bug#10098)
4154
4155 * .gdbinit (prow): Make displayed values more self-explaining.
4156 Add row's hash code.
4157
261b6fd4
LMI
41582011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4159
4160 * process.c (wait_reading_process_output): Fix asynchrounous
4161 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4162 (wait_reading_process_output): Add comment and URL.
261b6fd4 4163
e7cfd277
JD
41642011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4165
4166 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4167
a9b9b7f5
CY
41682011-11-21 Chong Yidong <cyd@gnu.org>
4169
4170 * window.c (Fnext_window, Fprevious_window): Doc fix.
4171
b0d15b4f
SM
41722011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4173
4174 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4175
fe7a3057
JB
41762011-11-20 Juanma Barranquero <lekktu@gmail.com>
4177
4178 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4179
d2999b1a
MR
41802011-11-20 Martin Rudalics <rudalics@gmx.at>
4181
4182 * window.c (Fset_window_combination_limit): Rename argument
4183 STATUS to LIMIT.
4184 (Vwindow_combination_limit): Remove "status" from doc-string.
4185
d5ff9cd0
AS
41862011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4187
4188 * m/ibms390.h: Remove.
4189 * m/ibms390x.h: Don't include "ibms390.h".
4190
a5bb9bd3
SM
41912011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4192
4193 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4194 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4195
cd1181db
JB
41962011-11-20 Juanma Barranquero <lekktu@gmail.com>
4197
4198 * casetab.c (Fset_case_table):
4199 * charset.c (Fcharset_after): Fix typos.
4200
615a3b8d 42012011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4202
17e845af
PE
4203 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4204 Otherwise, valgrind does not work on some platforms.
4205 Problem reported by Andreas Schwab in
6a0bf43d
PE
4206 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4207 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4208 is set, removing the need for VIRT_ADDRESS_VARIES.
4209 (PURE_P): Use a more-efficient implementation that needs just one
4210 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4211 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4212 to 4 (xorl, subq, cmpq, setbe).
4213 * alloc.c (pure): Always extern now, since that's the
4214 VIRT_ADDR_VARIES behavior.
4215 (PURE_POINTER_P): Use a single comparison, not two, for
4216 consistency with the new puresize.h.
4217 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4218 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4219 Remove VIRT_ADDR_VARIES no longer needed.
4220
f8fe6f96
EZ
42212011-11-19 Eli Zaretskii <eliz@gnu.org>
4222
4223 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4224 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4225 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4226 behave as if the cursor position were at the window margin.
4227
4228 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4229 and the cursor position is out of bounds, behave as if the cursor
4230 position were at the window margin. (Bug#10075)
4231
df05a53c
CY
42322011-11-18 Chong Yidong <cyd@gnu.org>
4233
4234 * window.c (Fwindow_combination_limit): Make first argument
4235 non-optional, since it is meaningless for live windows like the
4236 selected window.
61ccba97 4237
2071918e
DA
42382011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4239
4240 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4241
b50a28de
SM
42422011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4243
4244 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4245 (graft_intervals_into_buffer): Simplify.
4246
015137db
EZ
42472011-11-18 Eli Zaretskii <eliz@gnu.org>
4248
4249 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4250 hash values of the two rows.
4251 (copy_row_except_pointers): Preserve the used[] arrays and the
4252 hash values of the two rows. (Bug#10035)
68c95424 4253 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4254
4255 * xdisp.c (row_hash): New function, body extracted from
4256 compute_line_metrics.
4257 (compute_line_metrics): Call row_hash, instead of computing the
4258 hash code inline.
4259
4260 * dispnew.c (verify_row_hash): Call row_hash for computing the
4261 hash code of a row, instead of duplicating code from xdisp.c.
4262
4263 * dispextern.h (row_hash): Add prototype.
4264
a2addb04
TH
42652011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4266
4267 * frame.c (delete_frame): Don't delete the terminal when the last
4268 X frame is closed if emacs is built with GTK toolkit.
4269
df85d315
JB
42702011-11-17 Juanma Barranquero <lekktu@gmail.com>
4271
4272 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4273
a0c2d0ae
MR
42742011-11-17 Martin Rudalics <rudalics@gmx.at>
4275
4276 * window.c (Vwindow_splits): Rename to
4277 Vwindow_combination_resize. Suggested by Juri Linkov.
4278 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4279 of Vwindow_splits.
4280
58179cce
JB
42812011-11-16 Juanma Barranquero <lekktu@gmail.com>
4282
7877f373
JB
4283 * nsfns.m (Fns_font_name):
4284 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4285
b6f67890
MR
42862011-11-16 Martin Rudalics <rudalics@gmx.at>
4287
4288 * window.h (window): Rename slot "nest" to "combination_limit".
4289 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4290 (Fset_window_nest): Rename to Fset_window_combination_limit.
4291 (Vwindow_nest): Rename to Vwindow_combination_limit.
4292 (recombine_windows, make_parent_window, make_window)
4293 (Fsplit_window_internal, saved_window)
4294 (Fset_window_configuration, save_window_save): Rename all
4295 occurrences of window_nest to window_combination_limit.
4296
c7015153
JB
42972011-11-15 Juanma Barranquero <lekktu@gmail.com>
4298
4299 * image.c (imagemagick_load_image): Fix typo.
4300
322ad6ec
EZ
43012011-11-14 Eli Zaretskii <eliz@gnu.org>
4302
4303 * xdisp.c (display_line): Move the call to
4304 highlight_trailing_whitespace before the call to
4305 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4306 faces of all the glyphs to compute ROW's hash value.
4307 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4308
f067b8ec
JB
43092011-11-14 Juanma Barranquero <lekktu@gmail.com>
4310
4311 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4312 just return (bug#10044).
4313
1e5b2111
EZ
43142011-11-12 Eli Zaretskii <eliz@gnu.org>
4315
7ef3cbd5
EZ
4316 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4317 with user-defined heap size. Bump the default size of the temacs
4318 heap to 27MB, to avoid memory warning when running temacs.
4319 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4320
1e5b2111
EZ
4321 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4322 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4323 (verify_row_hash) [XASSERTS]: New function.
4324 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4325 that the hash value of glyph rows is correct.
1e5b2111 4326
89d61221
MR
43272011-11-12 Martin Rudalics <rudalics@gmx.at>
4328
4329 * window.h (window): Remove splits slot.
4330 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4331 (Fdelete_other_windows_internal, make_parent_window)
4332 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4333 (Fset_window_configuration, save_window_save): Don't deal with
4334 split status of windows.
4335 (saved_window): Remove splits slot.
4336 (Vwindow_splits): Rewrite doc-string.
4337
97f18cc8
JD
43382011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4339
4340 * xfns.c (unwind_create_frame):
4341 * nsfns.m (unwind_create_frame):
4342 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4343 Vframe_list (Bug#9999).
4344
22a648b4
DA
43452011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4346
0b381c7e 4347 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4348
659afede
KH
43492011-11-11 Kenichi Handa <handa@m17n.org>
4350
4351 * callproc.c (Fcall_process): Set the member dst_multibyte of
4352 process_coding.
4353
9ac0394b
KH
43542011-11-11 Johan Bockgård <bojohan@gnu.org>
4355
4356 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4357 avoid a crash (bug#9496).
4358
2fbdc249
CY
43592011-11-09 Chong Yidong <cyd@gnu.org>
4360
4361 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4362 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4363
ac6b1f81
PE
43642011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4365
4366 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4367
09db192c
PE
43682011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4369
4370 Avoid some portability problems by eschewing 'extern inline' functions.
4371 The trivial performance wins aren't worth the portability hassles; see
4372 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4373 et seq.
4374 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4375 (window_box_width, window_box_left, window_box_left_offset)
4376 (window_box_right, window_box_right_offset): Undo previous change,
4377 by removing the "extern"s.
4378 * intervals.c (adjust_intervals_for_insertion)
4379 (adjust_intervals_for_deletion): Undo previous change,
4380 making these static again.
4381 (offset_intervals, temp_set_point_both, temp_set_point)
4382 (copy_intervals_to_string): No longer inline.
4383 * xdisp.c (window_text_bottom_y, window_box_width)
4384 (window_box_height, window_box_left_offset)
4385 (window_box_right_offset, window_box_left, window_box_right)
4386 (window_box): No longer inline.
4387
105216ed
CY
43882011-11-08 Chong Yidong <cyd@gnu.org>
4389
4390 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4391 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4392 Signal an error if not a live window.
105216ed
CY
4393 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4394 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4395
ae9e237f
JB
43962011-11-07 Juanma Barranquero <lekktu@gmail.com>
4397
4398 * lisp.h (syms_of_abbrev): Remove declaration.
4399 Reported by CHENG Gao <chenggao@royau.me>.
4400
c7aa8333
EZ
44012011-11-07 Eli Zaretskii <eliz@gnu.org>
4402
4403 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4404 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4405 of temacs in GUI mode.
4406
be7f5545
MR
44072011-11-07 Martin Rudalics <rudalics@gmx.at>
4408
4409 * window.h: Declare delete_all_child_windows instead of
4410 delete_all_subwindows.
4411 * window.c (Fwindow_nest, Fset_window_nest)
4412 (Fset_window_new_total, Fset_window_new_normal)
4413 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4414 (delete_all_subwindows): Rename to delete_all_child_windows.
4415 (Fdelete_other_windows_internal, Fset_window_configuration):
4416 Call delete_all_child_windows instead of delete_all_subwindows.
4417 * frame.c (delete_frame): Call delete_all_child_windows instead
4418 of delete_all_subwindows.
4419
ca78dc43
PE
44202011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4421
4422 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4423 This is also needed for porting to any host where GC_MARK_STACK is
4424 not GC_MAKE_GCPROS_NOOPS.
4425 (which_symbols): Use it.
4426
a0241d01
KH
44272011-11-07 Kenichi Handa <handa@m17n.org>
4428
4429 * coding.c (coding_set_destination): Check coding->src_pos only
4430 when coding->src_object is a buffer (bug#9910).
4431
4432 * process.c (send_process): Set the member src_multibyte of coding
4433 to 0 (bug#9911) when sending a unibyte text.
4434
4435 * callproc.c (Fcall_process): Set the member src_multibyte of
4436 process_coding to 0 (bug#9912).
4437
a64bfdfa 44382011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4439
4440 * xmenu.c (cleanup_widget_value_tree): New function.
4441 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4442 calling free_menubar_widget_value_tree directly (Bug#9830).
4443
cb41b32a
PE
44442011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4445
4446 Fix some portability problems with 'inline'.
4447 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4448 (window_box_width, window_box_left, window_box_left_offset)
4449 (window_box_right, window_box_right_offset): Declare extern.
4450 Otherwise, these inline functions do not conform to C99 and
4451 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4452 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4453 * intervals.c (adjust_intervals_for_insertion)
4454 (adjust_intervals_for_deletion): Now extern, because otherwise the
4455 extern inline functions 'offset_intervals' couldn't refer to it.
4456 (static_offset_intervals): Remove.
4457 (offset_intervals): Rewrite using the old contents of
4458 static_offset_intervals. The old version didn't conform to C99
4459 because an extern inline function contained a reference to an
4460 identifier with static linkage.
4461
b7041366
AS
44622011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4463
4464 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4465 GC.
4466
88a37c4d
EZ
44672011-11-06 Eli Zaretskii <eliz@gnu.org>
4468
4469 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4470 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4471 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4472 return Qleft_to_right.
4473
49745b39
CY
44742011-11-06 Chong Yidong <cyd@gnu.org>
4475
4476 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4477 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4478 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4479 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4480 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4481 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4482 (Fwindow_vscroll): Doc fix.
4483 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4484 argument, since it makes no sense to pass a live window and for
4485 consistency with window-child.
4486
1f05cd82
CS
44872011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4488
4489 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4490 support MSVC.
4491
22610910
JR
44922011-11-05 Jason Rumney <jasonr@gnu.org>
4493
4494 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4495 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4496 fonts (Bug#6029).
4497 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4498 bitwise arithmetic preventing use of unicode-sip and non-truetype
4499 opentype fonts.
4500
a06776b2
EZ
45012011-11-05 Eli Zaretskii <eliz@gnu.org>
4502
3ad924ba
EZ
4503 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4504 "emacs"-only part.
4505
a06776b2
EZ
4506 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4507 initialization code to keep similarity to xfns.c after changes
4508 from 2011-11-05.
4509
c9e7db78
JD
45102011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4511
a97f8f3f
JD
4512 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4513 (unwind_create_frame): New function (Bug#9943).
4514 (Fx_create_frame): Restructure code to be more similar to the one in
4515 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4516 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4517 Move terminal->reference_count++ just before making the frame official
4518 (Bug#9943).
4519
4520 * nsterm.m (x_free_frame_resources): New function.
4521 (x_destroy_window): Move code to x_free_frame_resources.
4522
c9e7db78 4523 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4524 (Fx_create_frame, x_create_tip_frame):
4525 Move terminal->reference_count++ just before making the frame
75f1671a 4526 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4527 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4528
a6fc3b5c
EZ
45292011-11-05 Eli Zaretskii <eliz@gnu.org>
4530
4531 Support MSVC build with newer versions of Visual Studio.
4532 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4533 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4534 nt/gmake.defs.
4535
4536 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4537 which are not supported by MSVC.
4538 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4539 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4540 bitfields.
4541 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4542 types in bitfields.
4543 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4544
4545 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4546
58179cce 45472011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4548
4549 Support MSVC build with newer versions of Visual Studio.
4550 * w32.c: Don't include w32api.h for MSVC.
4551 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4552
4553 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4554 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4555 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4556 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4557 e_* cousins.
4558 (alloca) [_MSC_VER]: Define to _alloca.
4559
4560 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4561
4562 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4563
a58c13ed
EZ
45642011-11-04 Eli Zaretskii <eliz@gnu.org>
4565
4566 * xdisp.c (note_mouse_highlight): If either of
4567 previous/next-single-property-change returns nil, treat that as
4568 the beginning or the end of the buffer. (Bug#9955)
4569
fe0b6370
JD
45702011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4571
a58c13ed 4572 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4573 label is not null (Bug#9951).
4574 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4575 may be NULL.
4576
89bd5ee1
EZ
45772011-11-04 Eli Zaretskii <eliz@gnu.org>
4578
4579 * window.c (Fwindow_body_size): Mention in the doc string that the
4580 return value is in frame's canonical units. (Bug#9949)
4581
84c3edb9
EZ
45822011-11-03 Eli Zaretskii <eliz@gnu.org>
4583
4e2fb5c7
EZ
4584 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4585
84c3edb9 4586 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4587 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4588 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4589
bc17a887
EZ
45902011-11-01 Eli Zaretskii <eliz@gnu.org>
4591
4592 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4593 Don't stop backward scan on the continuation glyph, even though
4594 its CHARPOS is positive.
6d5eb5b0
SM
4595 (mouse_face_from_buffer_pos, note_mouse_highlight):
4596 Rename cover_string to disp_string.
bc17a887 4597
4ee88440
MR
45982011-11-01 Martin Rudalics <rudalics@gmx.at>
4599
4600 * window.c (temp_output_buffer_show): Don't use
4601 Vtemp_buffer_show_specifiers.
4602 (Vtemp_buffer_show_specifiers): Remove unused variable.
4603
c2ff3c02
EZ
46042011-10-30 Eli Zaretskii <eliz@gnu.org>
4605
4606 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4607 past the beginning of the current glyph matrix.
4608
58179cce 46092011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4610
4611 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4612 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4613 HAVE_GTK3 (Bug#9869).
b77a6a7f 4614
3b574623
JD
4615 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4616 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4617
b77a6a7f
JD
4618 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4619
4620 * xterm.c: Declare x_handle_net_wm_state to return int.
4621 (handle_one_xevent): Check if we are iconified but don't have
4622 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4623 (get_current_wm_state): Return non-zero if not hidden,
4624 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4625 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4626 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4627 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4628
196e41e4
PE
46292011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4630
4631 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4632 so that this new function doesn't get optimized away by a
4633 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4634
021f2e1a
AS
46352011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4636
4637 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4638
8b058d44
EZ
46392011-10-29 Eli Zaretskii <eliz@gnu.org>
4640
4641 Fix the `xbytecode' command.
4642 * .gdbinit (xprintbytestr): New command.
b50a28de 4643 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4644 (xbytecode): Print the byte-code string as well.
4645
4452fb80
EZ
46462011-10-29 Kim Storm <storm@cua.dk>
4647
8b058d44
EZ
4648 * alloc.c (which_symbols): New function.
4649
21b72067
AS
46502011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4651
4652 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4653 line. (Bug#9903)
4654
83ed7b5c
GM
46552011-10-29 Glenn Morris <rgm@gnu.org>
4656
4657 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4658 Not clear what it was for, and it causes various bugs. (Bug#9839)
4659
5a7a728b
EZ
46602011-10-28 Eli Zaretskii <eliz@gnu.org>
4661
4662 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4663 possible random value that matches one of those tested as
4664 condition to clear the mouse face.
4665
d3d0842f
CY
46662011-10-28 Chong Yidong <cyd@gnu.org>
4667
4668 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4669
31b39d13
DN
46702011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4671
4672 * window.c (make_window): Initialize phys_cursor_on_p.
4673
9aba6043
SM
46742011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4675
4676 * lisp.h (struct Lisp_Symbol): Update comments.
4677
c20992f4
JB
46782011-10-28 Juanma Barranquero <lekktu@gmail.com>
4679
4680 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4681
db4f02f2
EZ
46822011-10-28 Eli Zaretskii <eliz@gnu.org>
4683
4684 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4685 <oslsachem@gmail.com> for helping to debug this.
4686
4687 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4688 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4689 (g_b_init_get_glyph_outline_w): New static variables.
4690 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4691 (GetGlyphOutlineW_Proc): New typedefs.
4692 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4693 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4694 New functions.
4695 (w32font_open_internal, compute_metrics):
4696 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4697 instead of calling the "wide" APIs directly.
4698
4699 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4700
4701 * w32.h (syms_of_w32font): Add prototype.
4702
87e68db4
JB
47032011-10-27 Juanma Barranquero <lekktu@gmail.com>
4704
4705 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4706 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4707 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4708 (Fmove_to_window_line): Doc fix.
4709
435c1d67
CY
47102011-10-27 Chong Yidong <cyd@gnu.org>
4711
4712 * process.c (make_process): Set gnutls_state to NULL.
4713
4714 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4715 non-NULL, regardless of GNUTLS_INITSTAGE.
4716 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4717 an error. Set process slots as soon as we allocate them.
4718
4719 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4720
9c6c6f49
CY
47212011-10-27 Chong Yidong <cyd@gnu.org>
4722
9aba6043
SM
4723 * gnutls.c (emacs_gnutls_deinit): New function.
4724 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4725 (Fgnutls_deinit, Fgnutls_boot): Use it.
4726
4727 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4728 (deactivate_process): Call emacs_gnutls_deinit.
4729
657d08d3
JB
47302011-10-27 Juanma Barranquero <lekktu@gmail.com>
4731
4732 * image.c (x_create_x_image_and_pixmap):
4733 * w32.c (sys_rename, w32_delayed_load):
4734 * w32font.c (fill_in_logfont):
4735 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4736
5430d399
JB
47372011-10-26 Juanma Barranquero <lekktu@gmail.com>
4738
4739 * w32fns.c (w32_default_color_map): New function,
4740 extracted from Fw32_default_color_map.
a7ef684b 4741 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4742
fe0055fa
PE
47432011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4744
4745 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4746
e6346438
SM
47472011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4748
4749 * keyboard.c (test_undefined): New function (bug#9751).
4750 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4751
e112cc37
ET
47522011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4753
4754 * sysdep.c (init_sys_modes): Fix the check for the controlling
4755 terminal (Bug#6649).
4756
7b5d6677
EZ
47572011-10-20 Eli Zaretskii <eliz@gnu.org>
4758
4759 * dispextern.h (struct bidi_it): New member next_en_type.
4760
4761 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4762 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4763 current character, check also for next_en_type being WEAK_EN.
4764 (bidi_resolve_weak): Don't enter the expensive loop if the current
4765 position is before next_en_pos. Record the bidi type of the first
4766 non-ET, non-BN character we find, in addition to its position.
4767 (bidi_level_of_next_char): Invalidate next_en_type when
4768 next_en_pos is over-stepped.
4769
7da0b018
PE
47702011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4771
4772 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4773 * editfns.c: Rewrite current-time-zone so that it invokes
4774 the equivalent of (format-time-string "%Z") to get the time zone name.
4775 This fixes a bug when the time zone name contains characters that
4776 need converting from the system time locale to Emacs internal format.
4777 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4778 that patch fixed format-time-string to do the conversion, but
4779 I forgot to fix current-time-zone.
4780 (format_time_string): New function, containing most of
4781 what Fformat_time_string used to contain.
4782 (Fformat_time_string): Rewrite in terms of format_time_string.
4783 This doesn't change this function's behavior.
4784 (current-time-zone): Rewrite to use format_time_string.
4785 This fixes the bug reported by Michael Schierl in
4786 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4787 Jason Rumney's 2007-06-07 change worked around this bug, but
4788 didn't fix it.
4789 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4790
8547b010
EZ
47912011-10-19 Eli Zaretskii <eliz@gnu.org>
4792
4793 * xdisp.c (start_display): If the character at POS is displayed
4794 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4795 (try_window_reusing_current_matrix): If a line ends in a display
4796 vector or the next line starts in a display vector, continue
4797 redrawing the window even though the character position of
4798 start_row was reached.
8547b010
EZ
4799 (Bug#9771, part 2)
4800
4e948d15
CY
48012011-10-18 Chong Yidong <cyd@gnu.org>
4802
4803 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4804 with nobreak-char-display too.
4805
4787455f
EZ
48062011-10-18 Eli Zaretskii <eliz@gnu.org>
4807
4808 Fix part 3 of bug#9771.
4809 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4810 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4811 non-neutral characters if the current character is a paragraph
4812 separator (a.k.a. Newline). This avoids running the same
4813 expensive loop twice, once when we consume the preceding newline
4814 and the other time when the line actually needs to be displayed.
4815 Avoid the loop when we see neutrals on the base embedding level
4816 following a character whose directionality is the same as the
4817 paragraph's. This avoids running the expensive loop when a line
4818 ends in a long sequence of neutrals, like control characters.
4819 Add assertion against STRONG_AL type. Slightly rearrange code
4820 that determines the type of a neutral given the first non-neutral
4821 that follows it.
4822 (bidi_level_of_next_char): Set next_en_pos to zero when
4823 invalidating its info.
4824
2c91f553
EZ
48252011-10-17 Eli Zaretskii <eliz@gnu.org>
4826
4827 * xdisp.c (push_display_prop): Determine whether to record string
4828 or buffer position by IT->string, not by IT->method. Allow
4829 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4830 (move_it_vertically_backward): Don't look for character position
4831 immediately after the newline when in a continuation line.
4832 (Bug#9771, part 1)
2c91f553 4833
c7b08b0d
MR
48342011-10-15 Martin Rudalics <rudalics@gmx.at>
4835
4836 * window.c (coordinates_in_window): Rewrite and delabelize
4837 vertical border check. (Bug#5357) (Bug#9618)
4838
6b02f655
SM
48392011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4840
4841 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4842 errors in XSetWindowBorder (bug#9310).
4843
81d40c92
DA
48442011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4845
4846 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4847 avoid crash when xmalloc overrun checking is enabled.
4848
d4172c3b
EZ
48492011-10-13 Eli Zaretskii <eliz@gnu.org>
4850
4851 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4852 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4853 cursor motion with <left> and <right> arrow keys.
4854
4855 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4856 some callers set that themselves.
4857
b00eea75
EZ
48582011-10-12 Eli Zaretskii <eliz@gnu.org>
4859
4860 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4861 display string and the previous row comes from the same string and
4862 is empty. (Bug#9739) (Bug#9738)
4863
8fe012c4
SM
48642011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4865
4866 * doc.c (get_doc_string): Encode file name (bug#9735).
4867
0074aef2
EZ
48682011-10-12 Eli Zaretskii <eliz@gnu.org>
4869
79beb178
EZ
4870 * bidi.c (bidi_level_of_next_char):
4871 * xdisp.c (get_visually_first_element): Remove old incorrect
4872 comments regarding the Unicode Line Separator character.
4873
0074aef2
EZ
4874 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4875
6e4b3fbe
DA
48762011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4877
4878 * alloc.c (Fgc_status): Do not access beyond zombies array
4879 boundary if nzombies > MAX_ZOMBIES.
4880 * alloc.c (dump_zombies): Add missing format specifier.
4881
0324f3af
PE
48822011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4883
b5525cac
PE
4884 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4885 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4886
0324f3af
PE
4887 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4888 Some packages use them to denote characters with modifiers.
4889
e9b5f888
AS
48902011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4891
4892 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4893 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4894 matching a pp-number. Rename parameter var to var1.
4895
127827c0
SM
48962011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4897
4898 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4899
c8fd3bd0
GM
49002011-10-08 Glenn Morris <rgm@gnu.org>
4901
4902 * callint.c (Fcall_interactively): Give a more explicit error for the
4903 'c' case with a non-character input. (Bug#8479)
4904
352ec8ff
EZ
49052011-10-08 Eli Zaretskii <eliz@gnu.org>
4906
03669ccb
EZ
4907 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4908 lines.
7061c986
EZ
4909 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4910 lines that are hscrolled on the left.
03669ccb 4911
352ec8ff
EZ
4912 * dispnew.c (buffer_posn_from_coords): Account for a possible
4913 presence of header-line. (Bug#4426)
4914
a66cfb1c
SM
49152011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4916
6b02f655
SM
4917 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4918 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4919
7c5ee88e
PE
49202011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4921
4922 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4923 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4924 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4925 this makes Emacs dump core during garbage collection on rare
4926 occasions. sizeof is obviously inferior to offsetof here, so
4927 stick with offsetof.
4928 (GC_POINTER_ALIGNMENT): New macro.
4929 (mark_memory): Omit 3rd (offset) arg; caller changed.
4930 Don't assume EMACS_INT alignment is the same as pointer alignment.
4931
df1bbe5b
SM
49322011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4933
4934 * keyboard.c (read_key_sequence_remapped): New var.
4935 (read_key_sequence): Compute remapping in the right buffer.
4936 (command_loop_1): Use read_key_sequence's remapping directly.
4937
51553db6
SM
49382011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4939
32c1fffd
SM
4940 * dired.c (file_name_completion): Don't expand file name.
4941 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4942 before checking file name handler.
4943
51553db6
SM
4944 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4945 they've been requested explicitly (bug#9591).
4946
b6bd1599 49472011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4948
4949 * keymap.c (Fsingle_key_description): Use make_specified_string
4950 instead of build_string to build string from push_key_description.
4951 (Bug#5193)
4952
f701dc2a
PE
49532011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4954
4222c55d
PE
4955 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4956 This fixes a Y2038 bug on 64-bit hosts.
4957 * buffer.c (reset_buffer):
4958 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4959 (Fclear_buffer_auto_save_failure):
4960 Use 0, not -1, to represent an unset failure time, since time_t
4961 might not be signed.
4962
f701dc2a
PE
4963 Remove dependency on glibc malloc internals.
4964 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4965 Move back here from lisp.h, but with their new implementations.
4966 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4967 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4968 * charset.c (charset_table_init): New static var.
4969 (syms_of_charset): Use it instead of xmalloc. This removes a
4970 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4971 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4972 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4973 Move back to alloc.c.
4974 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4975 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4976
9ceebf39
JD
49772011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4978
4979 * nsterm.m (windowDidResize): Call x_set_window_size only when
4980 ns_in_resize is true. Otherwise set pixelwidth/height and
4981 call change_frame_size (Bug#9628).
4982
cb993c58
PE
49832011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4984
3930c88b
PE
4985 Port --enable-checking=all to Fedora 14 x86-64.
4986 * charset.c (syms_of_charset): Also account for glibc malloc's
4987 internal overhead when calculating the initial malloc maximum.
4988
cb993c58
PE
4989 Port --enable-checking=all to Fedora 14 x86.
4990 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4991 Move to lisp.h.
4992 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4993 (overrun_check_realloc, overrun_check_free):
4994 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4995 That way, xmalloc returns a properly-aligned pointer even if
4996 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4997 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4998 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4999 into account when calculating the initial malloc maximum.
5000 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5001 Move here from alloc.c, so that charset.c can use it too.
5002 Properly align; the old code wasn't right for common 32-bit hosts
5003 when configured with --enable-checking=all.
5004 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5005 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5006
31bed486
EZ
50072011-09-29 Eli Zaretskii <eliz@gnu.org>
5008
04c70788 5009 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5010 use EDOM.
5011
fbcaa2f3
EZ
50122011-09-28 Eli Zaretskii <eliz@gnu.org>
5013
5014 * xdisp.c (compute_display_string_end): If there's no display
5015 string at CHARPOS, return -1.
5016
5017 * bidi.c (bidi_fetch_char): When compute_display_string_end
5018 returns a negative value, treat the character as a normal
5019 character not covered by a display string. (Bug#9624)
5020
a239d4e9
JB
50212011-09-28 Juanma Barranquero <lekktu@gmail.com>
5022
5023 * lread.c (Fread_from_string): Fix typo in docstring.
5024
88652fd5
EZ
50252011-09-27 Eli Zaretskii <eliz@gnu.org>
5026
5027 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5028 newline, reseat the iterator instead of bidi-iterating there one
5029 character at a time. (Bug#9610)
32c1fffd
SM
5030 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5031 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5032
ed497dd4
AS
50332011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5034
5035 * lread.c (readevalloop): Use correct code for NBSP.
5036 (read1): Likewise. (Bug#9608)
5037
b2bf61aa
MA
50382011-09-25 Michael Albinus <michael.albinus@gmx.de>
5039
5040 * dbusbind.c (Fdbus_register_signal): When service is not
5041 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5042
32bbb17c
GM
50432011-09-25 Glenn Morris <rgm@gnu.org>
5044
5045 * buffer.c (truncate-lines): Doc fix.
5046
94e0933e
CY
50472011-09-24 Chong Yidong <cyd@stupidchicken.com>
5048
5049 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5050 (Fset_window_next_buffers): Doc fix.
5051
cddde921
GM
50522011-09-24 Glenn Morris <rgm@gnu.org>
5053
5054 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5055
1260aef1
PE
50562011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5057
25b4bfa0
PE
5058 Fix minor problems found by static checking.
5059 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5060 * indent.c (Fvertical_motion): Fix == vs = typo.
5061
e3cbd34b
EZ
50622011-09-24 Eli Zaretskii <eliz@gnu.org>
5063
a66cfb1c
SM
5064 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5065 Default value is now t. Doc fix.
6bf7006f 5066
e3cbd34b 5067 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5068 logic when moving up, not only when moving down. Fix the
e3cbd34b 5069 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5070 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5071
5072 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5073 CHARPOS is covered by a display string which includes newlines.
5074 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5075 is covered by a display string with embedded newlines.
5076
a3de0cbd
MA
50772011-09-24 Michael Albinus <michael.albinus@gmx.de>
5078
5079 * dbusbind.c (Fdbus_register_signal): Add match rule to
5080 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5081 (Fdbus_register_method, Vdbus_registered_objects_table):
5082 Fix docstring.
a3de0cbd 5083
b260039d
JM
50842011-09-24 Jim Meyering <meyering@redhat.com>
5085
32c1fffd 5086 do not ignore write error for any output size
b260039d
JM
5087 The previous change was incomplete.
5088 While it makes emacs --batch detect the vast majority of stdout
5089 write failures, errors were still ignored whenever the output size is
5090 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5091 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5092 && echo FAIL: ignored write error
5093 FAIL: ignored write error
5094 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5095 && echo FAIL: ignored write error
5096 FAIL: ignored write error
5097 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5098
8eca8a7c
AS
50992011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5100
5101 * emacs.c (Fkill_emacs): In noninteractive mode exit
5102 non-successfully if a write error occurred on stdout. (Bug#9574)
5103
3341db62
EZ
51042011-09-21 Eli Zaretskii <eliz@gnu.org>
5105
5106 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5107 the xassert test.
5108
5109 * dispextern.h (struct it): Update the comment documenting what
5110 can it->OBJECT be.
5111
8c203dbf
EZ
51122011-09-20 Eli Zaretskii <eliz@gnu.org>
5113
5114 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5115 a display string, extend search for cursor position to end of row.
5116 (find_row_edges): If the row ends in a newline from a display
5117 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5118 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5119 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5120 non-empty line. Fixes confusing cursor motion with arrow keys at
5121 the beginning of a line that starts with whitespace.
8c203dbf 5122
a4824228
LMI
51232011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5124
5125 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5126 (bug#9493).
5127
33ed493b
CY
51282011-09-18 Chong Yidong <cyd@stupidchicken.com>
5129
5130 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5131 boolean (Bug#9154).
5132
56cd55c8
EZ
51332011-09-18 Eli Zaretskii <eliz@gnu.org>
5134
5135 * xdisp.c (display_line): Record maximum and minimum buffer
5136 positions even if no glyphs were produced (e.g., by a zero-width
5137 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5138 buffer positions that will be removed from the glyph row because
5139 they don't fit.
c02dcedf
EZ
5140 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5141 column is beyond frame width: don't subtract 1 "pixel" when
5142 computing width of the stretch.
3e62b7e0
EZ
5143 (reseat_at_next_visible_line_start): Undo the change made on
5144 2011-09-17 that saved paragraph information and restored it after
5145 the call to `reseat'. (Bug#9545)
56cd55c8 5146
5ed99d36 51472011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5148
5149 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5150 and turn window cursor on if cleared (Bug#9415).
5151
5ed99d36 51522011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5153
5154 * search.c (boyer_moore): Take unibyte characters from pattern
5155 literally. (Bug#9458)
5156
9bade7b2
EZ
51572011-09-18 Eli Zaretskii <eliz@gnu.org>
5158
5159 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5160
e5e9d610
PE
51612011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5162
87e4427a
PE
5163 Fix minor problem found by static checking.
5164 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5165 initialized, to pacify gcc -Wuninitialized.
5166
e5e9d610
PE
5167 * fileio.c: Report proper errno when syscall falls.
5168 (Finsert_file_contents): Save and restore errno,
5169 so that report_file_error outputs the correct diagnostic.
5170 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5171
a1674f0b
EZ
51722011-09-18 Eli Zaretskii <eliz@gnu.org>
5173
5174 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5175
fbfb6dd4
EZ
51762011-09-17 Eli Zaretskii <eliz@gnu.org>
5177
5178 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5179 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5180
bb187662
EZ
51812011-09-17 Eli Zaretskii <eliz@gnu.org>
5182
1137e8b8 5183 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5184 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5185
5186 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5187 (bidi_find_paragraph_start): Search back for paragraph beginning
5188 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5189 (bidi_move_to_visually_next): Only trigger paragraph-related
5190 computations when the last character is a newline or at EOB, not
5191 just any NEUTRAL_B. (Bug#9470)
5192
bb187662
EZ
5193 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5194 truncated lines if point is covered by a display string. (Bug#9524)
5195
2e621251
PE
51962011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5197
5198 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5199 (cons_to_x_long): New function.
5200 (lisp_data_to_selection_data): Use it. Correct the test for
5201 short-versus-long data; it was negated. Break out of vector
5202 loop, for efficiency, when a long datum is discovered.
5203
91a15bc6
SM
52042011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5205
5206 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5207
b41c3a35
EZ
52082011-09-16 Eli Zaretskii <eliz@gnu.org>
5209
5210 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5211 GCC PR/17406) by declaring this function with external scope.
5212
7812ba2d
PE
52132011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5214
5215 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5216 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5217
cf7edc2a
AS
52182011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5219
5220 * editfns.c (Fformat): Correctly handle text properties on "%%".
5221
bd01620e
EZ
52222011-09-15 Eli Zaretskii <eliz@gnu.org>
5223
5224 * xterm.c (x_draw_composite_glyph_string_foreground):
5225 * w32term.c (x_draw_composite_glyph_string_foreground):
5226 * term.c (encode_terminal_code):
5227 * composite.c (composition_update_it, get_composition_id):
5228 * xdisp.c (get_next_display_element)
5229 (fill_composite_glyph_string): Add comments about special meaning
5230 of TAB characters in a composition.
5231
a02719a3
PE
52322011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5233
5234 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5235 This occurs when processing a multibyte format.
5236 Problem reported by Wolfgang Jenker.
a02719a3 5237
72589a3c
JB
52382011-09-15 Johan Bockgård <bojohan@gnu.org>
5239
5240 * xdisp.c (try_cursor_movement): Only check for exact match if
5241 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5242
1c14176c
PE
52432011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5244
5245 Remove unused external symbols.
5246 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5247 * xdisp.c (calc_pixel_width_or_height): Now static.
5248 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5249 * indent.c (check_display_width):
5250 * w32term.c: Fix comment to match code.
5251 * xterm.c, xterm.h (x_catching_errors): Remove.
5252
d2eea5b5
PE
52532011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5254
5255 * xselect.c: Use signed conversions more consistently (Bug#9498).
5256 (selection_data_to_lisp_data): Assume incoming selection data are
5257 signed integers, not unsigned. This is to be consistent with
5258 outgoing selection data, which was modified to use signed integers
5259 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5260 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5261 expects long, not unsigned long.
5262
46888499
EZ
52632011-09-14 Eli Zaretskii <eliz@gnu.org>
5264
5265 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5266 computation of loop end. Reported by Johan Bockgård
5267 <bojohan@gnu.org>.
5268
ef8ef9fb
CY
52692011-09-13 Chong Yidong <cyd@stupidchicken.com>
5270
5271 * frame.c (Fother_visible_frames_p): Function deleted.
5272
fa819fed
EZ
52732011-09-12 Eli Zaretskii <eliz@gnu.org>
5274
5275 * indent.c (compute_motion): Process display vector front to back
5276 rather than the other way around. (Bug#2496)
5277
2ba8e008
SM
52782011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5279
5280 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5281
20f53c69
CY
52822011-09-11 Chong Yidong <cyd@stupidchicken.com>
5283
5284 * minibuf.c (Fread_from_minibuffer): Doc fix.
5285
d562d7a4
EZ
52862011-09-11 Eli Zaretskii <eliz@gnu.org>
5287
5288 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5289 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5290
1c4d7f3d
LMI
52912011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5292
5293 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5294 value for non-existent files.
5295
b885bf36
EZ
52962011-09-11 Eli Zaretskii <eliz@gnu.org>
5297
5298 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5299 set its "size" to -1. This will set the modtime_size field of
5300 the corresponding buffer to -1, which is what
5301 verify-visited-file-modtime expects for files that do not exist.
5302 (Bug#9139)
5303
6612f0bf
PE
53042011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5305
5306 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5307 here ...
5308 * lisp.h: ... from here. push_key_description is no longer
5309 defined in keyboard.c, so its declaration should not be in
5310 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5311 logically belongs with push_key_description.
5312
dfb3f755
PE
53132011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5314
5315 * buffer.h: Include <sys/types.h> instead of <time.h>.
5316 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5317 Problem reported by Herbert J. Skuhra.
5318
3134906c
LMI
53192011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5320
5321 * xml.c (parse_region): Make the parsing work for
5322 non-comment-starting XML files again (bug#9144).
5323
8d903f4e
AS
53242011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5325
5326 * image.c (gif_load): Fix calculation of bottom and right corner.
5327 (Bug#9468)
5328
80ad64f4
EZ
53292011-09-10 Eli Zaretskii <eliz@gnu.org>
5330
5331 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5332 redisplay in small windows.
5333
208a048d
EZ
53342011-09-09 Eli Zaretskii <eliz@gnu.org>
5335
5336 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5337
9b1c252e
MR
53382011-09-08 Martin Rudalics <rudalics@gmx.at>
5339
5340 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5341 Operate on live windows only.
5342
2949f33b
JB
53432011-09-08 Juanma Barranquero <lekktu@gmail.com>
5344
5345 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5346
e08dcafd
EZ
53472011-09-07 Eli Zaretskii <eliz@gnu.org>
5348
5349 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5350 only under bidi iteration.
5351
115b96bd
JD
53522011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5353
5354 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5355
c8199d0f
PE
53562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5357
5358 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5359 Without this fix, the command to link temacs failed due to an
5360 undefined symbol __builtin_isnan. This is because
5361 /usr/include/iso/math_c99.h #defines isnan(x) to
5362 __builtin_isnan(x), but the bundled gcc, which identifies itself
5363 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5364 a __builtin_isnan.
5365 * floatfns.c (isnan): #undef, and then #define to a clone of
5366 what's in data.c.
5367 (Fisnan): Always define, since it's always available now.
5368 (syms_of_floatfns): Always define isnan at the Lisp level.
5369
e39b275c 53702011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5371
5372 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5373
b2db44d9 53742011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5375
f4af5137 5376 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5377 The previous code assumed that file offsets (off_t values) fit in
5378 EMACS_INT variables, which is not true on typical 32-bit hosts.
5379 The code messed up by falsely reporting buffer overflow in cases
5380 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5381 when "big" contains more than 2**29 bytes, even though this
5382 inserts just one byte and does not overflow the buffer.
5383 (Finsert_file_contents): Store file offsets as off_t
5384 values, not as EMACS_INT values. Check for overflow when
5385 converting between EMACS_INT and off_t. When checking for
5386 buffer overflow or for overlap, take the offsets into account.
5387 Don't use EMACS_INT for small values where int suffices.
5388 When checking for overlap, fix a typo: ZV was used where
5389 ZV_BYTE was intended.
5390 (Fwrite_region): Don't assume off_t fits into 'long'.
5391 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5392
ecfc0a49
MA
53932011-09-05 Michael Albinus <michael.albinus@gmx.de>
5394
5395 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5396
6511acf2 53972011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5398
0999621a 5399 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5400
5401 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5402 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5403 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5404 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5405 (modify_event_symbol): Do not assume that the length of
5406 name_alist_or_stem is safe to alloca and fits in int.
5407 (Fexecute_extended_command): Likewise for function name and binding.
5408 (Frecursion_depth): Wrap around reliably on integer overflow.
5409 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5410 since some callers pass EMACS_INT values.
5411 (Fsingle_key_description): Don't crash if symbol name contains more
5412 than MAX_ALLOCA bytes.
5413 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5414 (get_minibuffer): Arg is now EMACS_INT, not int.
5415 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5416 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5417 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5418
2be7d702
PE
5419 * dbusbind.c (signature_cat): New function.
5420 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5421 Do not overrun buffer; instead, report string overflow.
5422
9d1df220
PE
5423 * dispnew.c (add_window_display_history): Don't overrun buffer.
5424 Truncate instead; this is OK since it's just a log.
5425
33ef5c64
PE
5426 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5427 even if the time zone offset is outlandishly large.
5428 Don't mishandle offset == INT_MIN.
5429
66c6fdd5
PE
5430 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5431 when creating daemon; the previous buffer-overflow check was incorrect.
5432
d749b01b
PE
5433 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5434 which has the guts of the old verror function.
5435
b5cd1905
PE
5436 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5437 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5438
6e1a67fb
PE
5439 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5440 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5441 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5442 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5443 length of string rather than counting it via multiple sprintfs;
5444 that's simpler and more reliable.
c21721cc
PE
5445 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5446 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5447 sprintf, in case result does not fit in int.
5448
c57b67fc
PE
5449 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5450 (fontset_from_font): Print it.
5451
8a401434
PE
5452 * frame.c (tty_frame_count): Now printmax_t, not int.
5453 (make_terminal_frame, set_term_frame_name): Print it.
5454 (x_report_frame_params): In X, window IDs are unsigned long,
5455 not signed long, so print them as unsigned.
5456 (validate_x_resource_name): Check for implausibly long names,
5457 and don't assume name length fits in 'int'.
5458 (x_get_resource_string): Don't blindly alloca invocation name;
5459 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5460 not fit in int.
5461
6e1a67fb
PE
5462 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5463 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5464 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5465
0df02bf3
PE
5466 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5467 Use esprintf, not sprintf, in case result does not fit in int.
5468
48e30793
PE
5469 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5470 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5471 it as a large positive number.
5472 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5473 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5474
a66ff6d8
PE
5475 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5476 in case result does not fit in int.
5477
aca216ff
PE
5478 * print.c (float_to_string): Detect width overflow more reliably.
5479 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5480 buffer overrun. Don't assume list length fits in 'int'. Treat
5481 print length of 0 as 0, not as infinity; to be consistent with other
5482 uses of print length in this function. Don't overflow print length
5483 index. Don't assume hash table size fits in 'long', or that
5484 vectorlike size fits in 'unsigned long'.
5485
31c286f7
PE
5486 * process.c (make_process): Use printmax_t, not int, to format
5487 process-name gensyms.
5488
55e5faa1
PE
5489 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5490
80f2e268
PE
5491 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5492 to avoid potential buffer overrun.
5493
670741ab
PE
5494 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5495 if X resource line is longer than 512 bytes.
5496
b7163a50
PE
5497 * xfns.c (x_window): Make sprintf buffer a bit bigger
5498 to avoid potential buffer overrun.
5499
ae58ff1f
PE
5500 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5501
c43c8a6a
PE
5502 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5503
3f8236f4
PE
55042011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5505
53e9fe90 5506 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5507 Without these, Emacs silently mishandles large integers sometimes.
5508 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5509 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5510
6511acf2
PE
5511 * xdisp.c (try_window_id): Check Emacs fixnum range before
5512 converting to 'int'.
806add1d 5513
6511acf2 5514 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5515 Check that an Emacs fixnum is in range before assigning it to 'int'.
5516 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5517 values converted from Emacs fixnums.
5518 (Frecenter): Don't wrap around a line count if it is out of 'int'
5519 range; instead, treat it as an extreme value.
5520 (Fset_window_configuration, compare_window_configurations):
5521 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5522
6511acf2
PE
5523 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5524 that can exceed INT_MAX. Check that EMACS_INT value is in range
5525 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5526 (match_limit): Don't assume that a fixnum can fit in 'int'.
5527
6511acf2 5528 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5529 exceed INT_MAX.
5530
6511acf2 5531 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5532 (Fvertical_motion): Don't wrap around LINES values that don't fit
5533 in 'int'. Instead, treat them as extreme values. This is good
5534 enough for windows, which can't have more than INT_MAX lines anyway.
5535
fcb901a7
LMI
55362011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5537
0f2f6b6d
LMI
5538 * Require libxml/parser.h to avoid compilation warning.
5539
fcb901a7
LMI
5540 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5541
5542 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5543 since this reportedly can destroy thread storage.
5544
6e20a0d4
CY
55452011-08-30 Chong Yidong <cyd@stupidchicken.com>
5546
5547 * syntax.c (find_defun_start): Update all cache variables if
5548 exiting early (Bug#9401).
5549
148ae00e
EZ
55502011-08-30 Eli Zaretskii <eliz@gnu.org>
5551
f6cfbd8f
EZ
5552 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5553
148ae00e
EZ
5554 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5555 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5556 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5557
5558 * term.c (tty_append_glyph): New function.
5559 (produce_stretch_glyph): Static function and its prototype deleted.
5560
a66cfb1c
SM
5561 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5562 Add prototypes.
148ae00e 5563
c4a07a4c
PE
55642011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5565
5566 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5567 when checking :margin (Bug#9390).
5568 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5569 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5570 so that the name doesn't mislead. All uses changed.
5571
6bc8cd65
JB
55722011-08-28 Johan Bockgård <bojohan@gnu.org>
5573
5574 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5575 set_tty_hooks.
5576
dca4927e
EZ
55772011-08-27 Eli Zaretskii <eliz@gnu.org>
5578
5579 * xdisp.c (move_it_to): Don't bail out early when reaching
5580 position beyond to_charpos, if we are scanning backwards.
5581 (move_it_vertically_backward): When DY == 0, make sure we get to
5582 the first character in the line after the newline.
5583
f2cad773
PE
55842011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5585
5586 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5587 (ccl_driver): Do not generate an out-of-range pointer.
5588 (Fccl_execute_on_string): Remove unnecessary check for
5589 integer overflow, noted by Stefan Monnier in
5590 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5591 Remove a FIXME that didn't need fixing.
5592 Simplify the newly-introduced buffer reallocation code.
5593
0cae2cdb
JB
55942011-08-27 Juanma Barranquero <lekktu@gmail.com>
5595
5596 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5597
5fc295a4 55982011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5599
70c60eb2 5600 Integer and memory overflow issues (Bug#9196).
726e0ab1 5601
d31850da
PE
5602 * doc.c (get_doc_string): Rework so that
5603 get_doc_string_buffer_size is the actual buffer size, rather than
5604 being 1 less than the actual buffer size; this makes xpalloc more
5605 convenient.
5606
a69fbedb
PE
5607 * image.c (x_allocate_bitmap_record, cache_image):
5608 * xselect.c (Fx_register_dnd_atom):
5609 Simplify previous changes by using xpalloc.
5610
fe5c5d37
PE
5611 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5612 since either will do and ptrdiff_t is convenient with xpalloc.
5613
0065d054
PE
5614 * charset.c (charset_table_size)
5615 (struct charset_sort_data.priority): Now ptrdiff_t.
5616 (charset_compare): Don't overflow if priorities differ greatly.
5617 (Fsort_charsets): Don't assume list length fits in int.
5618 Check for size-calculation overflow when allocating sort data.
5619 (syms_of_charset): Allocate an initial charset table that is
5620 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5621
5622 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5623
5624 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5625 The actual value is always <= INT_MAX, and leaving it unsigned made
5626 overflow checking harder.
5627
5628 * dispextern.h (struct glyph_matrix.rows_allocated)
5629 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5630 with xpalloc. The values are still always <= INT_MAX.
5631
5632 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5633
5634 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5635 (SAFE_NALLOCA): New macro.
5636
5637 * region-cache.c (struct boundary.pos, find_cache_boundary)
5638 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5639 (set_cache_region, invalidate_region_cache)
5640 (revalidate_region_cache, know_region_cache, region_cache_forward)
5641 (region_cache_backward, pp_cache):
5642 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5643 so that ptrdiff_t * can be passed to xpalloc.
5644 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5645 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5646 (pp_cache): Don't assume cache_len fits in int.
5647 * region-cache.h: Adjust extern decls to match.
5648
5649 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5650 EMACS_INT, since either will do, for xpalloc.
5651
5652 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5653 (xnmalloc, xnrealloc, xpalloc): New functions.
5654
726e0ab1
PE
5655 * bidi.c (bidi_shelve_header_size): New constant.
5656 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5657 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5658
51f30bc5 5659 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5660 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5661 (overlay_strings):
5662 Don't update size of array until after memory allocation succeeds,
5663 because xmalloc/xrealloc may not return.
0065d054
PE
5664 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5665 now that we have proper integer overflow checking.
5666 (record_overlay_string, overlay_strings): Catch overflows when
5667 calculating size of overlay_str_buf.
726e0ab1 5668
0065d054
PE
5669 * callproc.c (Fcall_process): Check for size overflow when
5670 calculating size of args2.
5671 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5672 Normally we prefer signed values, but sticking with ptrdiff_t would
5673 require adding more-complicated checks.
726e0ab1
PE
5674
5675 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5676 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5677 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5678 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5679
5680 * character.c (Fstring): Check for size-calculation overflow.
5681
5682 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5683 unnecessary integer overflow. Check for size overflow.
5684 (encode_coding_object): Don't update size until xmalloc succeeds.
5685
5686 * composite.c (get_composition_id): Check for overflow in glyph
5687 length calculations.
5688
5689 Integer and memory overflow fixes for display code.
5690 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5691 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5692 (scrolling_window): Check for overflow in size calculations.
5693 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5694 Don't assume glyph table len fits in int.
5695 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5696 (row_table_size): Now ptrdiff_t, not int.
5697 (scrolling_window): Avoid overflow in size calculations.
5698 Don't update size until allocation succeeds.
5699 * fns.c (concat): Check for overflow in size calculations.
5700 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5701 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5702 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5703
5704 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5705 (get_doc_string): Check for size calculation overflow.
5706 Don't update size until allocation succeeds.
5707 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5708 EMACS_INT, where ptrdiff_t will do.
5709 (Fsubstitute_command_keys): Check for string overflow.
5710
5711 * editfns.c (set_time_zone_rule): Don't assume environment length
5712 fits in int.
5713 (message_length): Now ptrdiff_t, not int.
5714 (Fmessage_box): Don't update size until allocation succeeds.
5715 Don't assume message length fits in int.
5716 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5717
0065d054
PE
5718 * emacs.c (main): Do not reallocate argv, since there is a null at
5719 the end that can be overwritten, and this way there's no need to
5720 worry about size-calculation overflow.
5721 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5722
5723 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5724 alloc succeeds.
5725 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5726
5727 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5728 (x_set_scroll_bar_width, x_figure_window_size):
5729 Check for integer overflow.
5730 (x_set_alpha): Do not assume XINT fits in int.
5731
5732 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5733 This is for the members text_lines, text_cols, total_lines, total_cols,
5734 where the system imposes an 'int' limit.
5735
5736 * fringe.c (Fdefine_fringe_bitmap):
5737 Don't update size until alloc works.
5738
5739 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5740 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5741
5742 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5743 Check for size-calculation overflow.
5744 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5745 do, as we prefer signed integers.
5746 (id_to_widget.max_size, id_to_widget.used)
5747 (xg_store_widget_in_map, xg_remove_widget_from_map)
5748 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5749 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5750 Use and return ptrdiff_t, not int.
5751 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5752 * gtkutil.h: Change prototypes to match the above.
5753
5754 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5755 are duplicate now that they've been promoted to lisp.h.
5756 (x_allocate_bitmap_record, x_alloc_image_color)
5757 (make_image_cache, cache_image, xpm_load):
5758 Don't update size until alloc is done.
5759 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5760 (x_detect_edges):
3256efce 5761 Check for size calculation overflow.
726e0ab1
PE
5762 (ct_colors_allocated_max): New constant.
5763 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5764 overflow.
3256efce 5765
726e0ab1
PE
5766 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5767 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5768 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5769 Use ptrdiff_t, not int, to count maps.
5770 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5771 calculations. Don't update size until allocation succeeds.
5772 Redo calculations to avoid overflow.
726e0ab1
PE
5773 * keyboard.h: Change prototypes to match the above.
5774
5775 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5776 to count maps.
5777 (current_minor_maps): Check for size calculation overflow.
5778 * keymap.h: Change prototypes to match the above.
5779
5780 * lread.c (read1, init_obarray): Don't update size until alloc done.
5781
5782 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5783 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5784
726e0ab1
PE
5785 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5786 Now ptrdiff_t, not int.
5787 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5788 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5789
5790 * process.c (Fnetwork_interface_list): Check for overflow
5791 in size calculation.
5792
5793 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5794
5795 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5796 overflow. Don't bother calling xmalloc when xrealloc will do.
5797
5798 * search.c (Freplace_match): Check for size calculation overflow.
5799 (Fset_match_data): Don't assume list lengths fit in 'int'.
5800
5801 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5802 for command line length. Do not attempt to address one before the
5803 beginning of an array, as that's not portable.
5804
5805 * term.c (max_frame_lines): Remove; unused.
5806 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5807 not int.
5808 (encode_terminal_code, calculate_costs): Check for size
5809 calculation overflow.
5810 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5811 table lengths and related sizes. Don't update size until alloc
5812 done. Redo calculations to avoid overflow.
5813 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5814
5815 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5816 subtracting pointers.
5817 (gobble_line): Check for overflow more carefully. Don't update size
5818 until alloc done.
5819
5820 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5821 Don't update size until alloc done.
5822 Redo size calculations to avoid overflow.
5823 Check for size calculation overflow.
0065d054 5824 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5825
5826 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5827 Use ptrdiff_t, not int, for sizes.
5828 (store_mode_line_noprop_char): Don't update size until alloc done.
5829
0065d054
PE
5830 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5831 Use ptrdiff_t, not int, for sizes.
5832 (Finternal_make_lisp_face, cache_face):
5833 Check for size calculation overflow.
5834 (cache_face): Treat size calculation overflows as if they were
5835 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5836
5837 * xfns.c (x_encode_text, x_set_name_internal)
5838 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5839 sizes, since they can exceed INT_MAX in size. Check for size
5840 calculation overflow.
5841
0065d054
PE
5842 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5843 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5844 Don't update size until alloc done.
5845
0065d054 5846 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5847 as sprintf is limited to int lengths.
1d526e2f 5848
252c5ee1
PE
5849 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5850 (X_LONG_MIN): New macros.
864d7ce7
PE
5851 Use them to make the following changes clearer.
5852 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5853 This change doesn't affect the value now, but it may help remind
5854 future maintainers not to raise the value too much later.
5855 (SELECTION_QUANTUM): Remove, replacing with ...
5856 (selection_quantum): ... new function, which avoids overflow.
5857 All uses changed.
5858 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5859 assumption that selection length fits in 'int'.
5860 (x_reply_selection_request, x_handle_selection_request)
5861 (x_get_window_property, receive_incremental_selection)
5862 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5863 (lisp_data_to_selection_data, clean_local_selection_data):
5864 Use ptrdiff_t, not int, to record length of selection.
5865 (x_reply_selection_request, x_get_window_property)
5866 (receive_incremental_selection, x_property_data_to_lisp):
5867 Redo calculations to avoid overflow.
5868 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5869 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5870 something.
5871 (x_get_window_property, receive_incremental_selection)
5872 (lisp_data_to_selection_data, x_property_data_to_lisp):
5873 Check for size-calculation overflow.
5874 (x_get_window_property, receive_incremental_selection)
5875 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5876 Don't store size until memory allocation succeeds.
5877 (x_get_window_property): Plug memory leak on memory exhaustion.
5878 Don't double-block input; malloc is safe here. Don't assume 2**34
5879 - 4 fits in unsigned long. Add an xassert to check
5880 XGetWindowProperty overflow. Be more careful about overflow
5881 calculations, and distinguish size from memory overflow better.
5882 (receive_incremental_selection): When tracing, don't assume
5883 unsigned int is less than INT_MAX.
5884 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5885 harmful) conversions of unsigned short to int.
5886 (lisp_data_to_selection_data): Don't assume that integers
5887 in the range -65535 through -1 fit in an X unsigned short.
5888 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5889 result parameters unless successful. Rely on cons_to_unsigned
5890 to report problems with elements; the old code wasn't right anyway.
5891 (x_check_property_data): Check for int overflow; we cannot use
5892 a wider type due to X limits.
5893 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5894
726e0ab1 5895 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5896
0065d054
PE
5897 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5898 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5899 (x_color_cells): Don't store size until memory allocation succeeds.
5900 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5901 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5902 (x_term_init): Don't assume length fits in int (sprintf is limited
5903 to int size).
bc18e09d 5904
ebfa62c0
PE
5905 Use ptrdiff_t for composition IDs.
5906 * character.c (lisp_string_width):
5907 * composite.c (composition_table_size, n_compositions)
5908 (get_composition_id, composition_gstring_from_id):
5909 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5910 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5911 * window.c (Frecenter):
5912 Use ptrdiff_t, not int, for composition IDs.
5913 * composite.c (get_composition_id): Check for integer overflow.
5914 * composite.h: Adjust prototypes to match the above changes.
5915
d3411f89
PE
5916 Use ptrdiff_t for hash table indexes.
5917 * category.c (hash_get_category_set):
5918 * ccl.c (ccl_driver):
5919 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5920 * coding.c (coding_system_charset_list, detect_coding_system):
5921 * coding.h (struct coding_system.id):
5922 * composite.c (get_composition_id, gstring_lookup_cache):
5923 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5924 * image.c (xpm_get_color_table_h):
5925 * lisp.h (hash_lookup, hash_put):
5926 * minibuf.c (Ftest_completion):
5927 Use ptrdiff_t for hash table indexes, not int (which is too
5928 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5929 32-bit --with-wide-int hosts).
5930
e097a6fa
PE
5931 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5932 Add a FIXME comment about memory leaks.
5933 (syms_of_charset): Don't assume xmalloc returns.
5934
5637687f
PE
5935 Don't assume that stated character widths fit in int.
5936 * character.c (Fchar_width, c_string_width, lisp_string_width):
5937 * character.h (CHAR_WIDTH):
5938 * indent.c (MULTIBYTE_BYTES_WIDTH):
5939 Use sanitize_char_width to avoid undefined and/or bad behavior
5940 with outlandish widths.
a66cfb1c 5941 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5942 now that we have two such functions. All uses changed.
5943 (sanitize_char_width): New inline function.
5944
a2271ba2
PE
5945 Don't assume that tab-width fits in int.
5946 * character.h (sanitize_width): New inline function.
5947 (SANE_TAB_WIDTH): New macro.
5948 (ASCII_CHAR_WIDTH): Use it.
5949 * indent.c (sane_tab_width): Remove. All uses replaced by
5950 SANE_TAB_WIDTH (current_buffer).
5951 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5952
18c52557
PE
5953 * fileio.c: Integer overflow issues with file modes.
5954 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5955
caeeedc1
PE
5956 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5957 Remove unreachable code.
5958 (read_hex, load_charset_map_from_file): Check for integer overflow.
5959
6df6ae42 5960 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5961 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5962 (x_send_scroll_bar_event): Likewise. Check that the size does not
5963 exceed limits imposed by XClientMessageEvent, as well as the usual
5964 ptrdiff_t and size_t limits.
5965
b13995db
PE
5966 * keyboard.c: Overflow, signedness and related fixes.
5967 (make_lispy_movement): Use same integer type in forward decl
5968 that is used in the definition.
5969 (read_key_sequence, keyremap_step):
5970 Change bufsize argument back to int, undoing my 2011-03-30 change.
5971 We prefer signed types, and int is wide enough here.
5972 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5973 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5974 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5975 length, not size_t. Use ptrdiff_t for index, not int.
5976 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5977 possibility of integer overflow.
5978
13464394
PE
5979 Overflow, signedness and related fixes for images.
5980
5981 * dispextern.h (struct it.stack[0].u.image.image_id)
5982 (struct_it.image_id, struct image.id, struct image_cache.size)
5983 (struct image_cache.used, struct image_cache.ref_count):
5984 * gtkutil.c (update_frame_tool_bar):
5985 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5986 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5987 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5988 * nsmenu.m (update_frame_tool_bar):
5989 * xdisp.c (calc_pixel_width_or_height):
5990 * xfns.c (image_cache_refcount):
5991 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5992 on typical 64-bit hosts.
5993
5994 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5995 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5996 Omit unnecessary casts to int.
5997 (parse_image_spec): Check that integers fall into 'int' range
5998 when the callers expect that.
5999 (image_ascent): Redo ascent calculation to avoid int overflow.
6000 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6001 (lookup_image): Remove unnecessary tests.
6002 (xbm_image_p): Locals are now of int, not EMACS_INT,
6003 since parse_image_check makes sure they fit into int.
6004 (png_load, gif_load, svg_load_image):
6005 Prefer int to unsigned where either will do.
6006 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6007 old tiff_error_handler and tiff_warning_handler.
6008 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6009 stack buffer overflows. It uses only the features of vsnprintf
6010 that are common to both POSIX and native Microsoft.
6011 (tiff_error_handler, tiff_warning_handler): Use it.
6012 (tiff_load, gif_load, imagemagick_load_image):
6013 Don't assume :index value fits in 'int'.
6014 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6015 (imagemagick_load_image): Check that crop parameters fit into
6016 the integer types that MagickCropImage accepts. Don't assume
6017 Vimagemagick_render_type has a nonnegative value. Don't assume
6018 size_t fits in 'long'.
6019 (gs_load): Use printmax_t to print the widest integers possible.
6020 Check for integer overflow when computing image height and width.
6021
c11821d4
EZ
60222011-08-26 Eli Zaretskii <eliz@gnu.org>
6023
6024 * xdisp.c (redisplay_window): Don't force window start if point
6025 will be invisible in the resulting window. (Bug#9324)
6026
0c95fcf7
EZ
60272011-08-25 Eli Zaretskii <eliz@gnu.org>
6028
6029 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6030 the display spec is of the form `(space ...)'.
6031 (handle_display_spec): Return the value returned by
6032 handle_single_display_spec, not just 1 or zero.
6033 (handle_single_display_spec): If the display spec is of the form
6034 `(space ...)', and specifies display in the text area, return 2
6035 rather than 1.
fee65a97 6036 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6037 accurately, and prefer exact match for point under bidi.
6038 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6039
6040 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6041 into disp_prop; all users changed.
6042
6043 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6044 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6045 for the text covered by the display property.
6046
e4ed06f1
CY
60472011-08-25 Chong Yidong <cyd@stupidchicken.com>
6048
6049 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6050 Change return value to nil.
6051 (Frecord_buffer): Delete unused function.
6052
f67cdd7f
EZ
60532011-08-24 Eli Zaretskii <eliz@gnu.org>
6054
5980d4c6
EZ
6055 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6056 buffers, return left-to-right.
8610fe8b
EZ
6057 (set_cursor_from_row): Consider candidate row a win if its glyph
6058 represents a newline and point is on that newline. Fixes cursor
6059 positioning on the newline at EOL of R2L text within L2R
6060 paragraph, and vice versa.
6061 (try_cursor_movement): Check continued rows, in addition to
6062 continuation rows. Fixes unwarranted scroll when point enters a
6063 continued line of R2L text within an L2R paragraph, or vice versa.
6064 (cursor_row_p): Consider the case of point being equal to
6065 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6066 from the end of a short line to the beginning of a continued line
6067 of R2L text within L2R paragraph.
6068 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6069 composed characters.
5980d4c6 6070
f67cdd7f
EZ
6071 * bidi.c (bidi_check_type): Use xassert.
6072 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6073 members.
6074
bca633fb
EZ
60752011-08-23 Eli Zaretskii <eliz@gnu.org>
6076
6077 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6078 a character.
6079
4a5885a7
CY
60802011-08-23 Chong Yidong <cyd@stupidchicken.com>
6081
6082 * nsfont.m (ns_otf_to_script): Fix typo.
6083
0902a04e
KH
60842011-08-22 Kenichi Handa <handa@m17n.org>
6085
6086 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6087 extra slot even if the purpose is char-code-property-table.
6088
1a2e6670
EZ
60892011-08-23 Eli Zaretskii <eliz@gnu.org>
6090
8ddde651
EZ
6091 * xdisp.c (redisplay_window): When computing centering_position,
6092 account for the height of the header line. (Bug#8874)
6093
425cc014
EZ
6094 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6095 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6096 candidate is selected by the mouse, and that candidate has a
6097 composed character under the mouse.
6098
1a2e6670
EZ
6099 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6100 coordinates reported by pos-visible-in-window-p for a composed
6101 character in column zero.
6102
8b76d6f8
SM
61032011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6104
6105 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6106
dac347dd
EZ
61072011-08-22 Eli Zaretskii <eliz@gnu.org>
6108
6109 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6110 consider it a hit if to_charpos is anywhere in the range of the
6111 composed buffer positions.
6112
e013fb34
CY
61132011-08-22 Chong Yidong <cyd@stupidchicken.com>
6114
6115 * image.c (gif_load): Don't assume that each subimage has the same
6116 dimensions as the base image. Handle disposal method that is
6117 "undefined" by the gif spec (Bug#9335).
6118
bd1ba3e8
CY
61192011-08-20 Chong Yidong <cyd@stupidchicken.com>
6120
6121 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6122 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6123
54a1215b
EZ
61242011-08-19 Eli Zaretskii <eliz@gnu.org>
6125
823564e5
EZ
6126 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6127 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6128 from an Org mode buffer to a Speedbar frame.
6129
54a1215b
EZ
6130 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6131 a composition, take its buffer position from IT->cmp_it.charpos.
6132 Fixes cursor positioning at the beginning of a line that begins
6133 with a composed character.
6134
9778ebcc
EZ
61352011-08-18 Eli Zaretskii <eliz@gnu.org>
6136
0be6ee06
EZ
6137 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6138 character bidirectional type, use STRONG_L instead. Fixes crashes
6139 in a buffer produced by `describe-categories'.
6140
9778ebcc
EZ
6141 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6142 members before the level stack, so they would be saved and
6143 restored when copying iterator state. Fixes incorrect reordering
6144 around TABs covered by display properties.
6145
156bffbe
AS
61462011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6147
6b02f655 6148 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6149
72ad093b
CY
61502011-08-17 Chong Yidong <cyd@stupidchicken.com>
6151
6152 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6153 (internal_condition_case_2, internal_condition_case_n):
6154 Remove unnecessary aborts (Bug#9081).
72ad093b 6155
35774242
EZ
61562011-08-17 Eli Zaretskii <eliz@gnu.org>
6157
6158 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6159 has no `load' handler, try opening the file locally. (Bug#9311)
6160
db76dd85
KB
61612011-08-16 Ken Brown <kbrown@cornell.edu>
6162
6163 * gmalloc.c: Expand comment.
6164
b215eee5
EZ
61652011-08-16 Eli Zaretskii <eliz@gnu.org>
6166
6167 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6168 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6169
a4579d33
KB
61702011-08-16 Ken Brown <kbrown@cornell.edu>
6171
6172 Fix memory allocation problems in Cygwin build (Bug#9273).
6173
6174 * unexcw.c ( __malloc_initialized): Declare external variable.
6175 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6176
8b76d6f8
SM
6177 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6178 New variables.
a4579d33
KB
6179 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6180 dumped emacs.
6181 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6182 in the static heap.
6183 [CYGWIN] (special_realloc): New function.
6184 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6185 requests to realloc storage in the static heap.
6186
3ebec551
PE
61872011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6188
6189 * bidi.c (bidi_initialize): Remove unused local.
6190
9fd8be00
EZ
61912011-08-15 Eli Zaretskii <eliz@gnu.org>
6192
6b02f655
SM
6193 * bidimirror.h:
6194 * biditype.h: Remove file.
6195 * makefile.w32-in ($(BLD)/bidi.$(O)):
6196 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6197
6198 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6199
6200 * chartab.c: Improve commentary for the uniprop_table API.
6201
32413314
EZ
6202 * bidi.c (bidi_paragraph_init): Support zero value of
6203 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6204 (bidi_initialize): Use uniprop_table instead of including
6205 biditype.h and bidimirror.h.
32413314 6206
9fd8be00
EZ
6207 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6208 coordinates of the iterator when restoring from ppos_it.
6209 (Bug#9296)
6210
5cf2b69b
KH
62112011-08-14 Kenichi Handa <handa@m17n.org>
6212
6213 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6214 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6215
daf17d00
EZ
62162011-08-14 Eli Zaretskii <eliz@gnu.org>
6217
6218 * xdisp.c (move_it_in_display_line_to): Don't invoke
6219 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6220 ppos_it. Fixes vertical cursor motion when line beginning is
6221 covered by an image. (Bug#9296)
6222
08e3161a
JD
62232011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6224
6225 * nsterm.h (ns_run_ascript): Declare.
6226 (NSAPP_DATA2_RUNASSCRIPT): Define.
6227
6228 * nsfns.m (as_script, as_result, as_status): New static variables.
6229 (ns_run_ascript): New function.
5e617bc2 6230 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6231 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6232 the event loop. Get status from as_status (Bug#7276).
6233
6234 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6235 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6236 the event loop (Bug#7276).
6237
a3720aa2
AS
62382011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6239
6240 * gnutls.c (QCgnutls_bootprop_priority)
6241 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6242 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6243 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6244 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6245 (QCgnutls_bootprop_verify_hostname_error)
6246 (QCgnutls_bootprop_callbacks_verify): Rename from
6247 Qgnutls_bootprop_..., all uses changed.
6248
6249 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6250 uses changed.
6251
0a0d27fb
PE
62522011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6253
19d5c50c
PE
6254 * xfaces.c (Qframe_set_background_mode): Now static.
6255 * dispextern.h (Qframe_set_background_mode): Remove decl.
6256
0a0d27fb
PE
6257 * process.c (Fnetwork_interface_info): Declare local only if needed.
6258
377538cb
JD
62592011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6260
6261 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6262 (Fnetwork_interface_list): Allocate in increments of bytes instead
6263 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6264 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6265 sockaddr.
6266 (struct ifflag_def): notrailers is smart on OSX.
6267 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6268 Get hardware address with getifaddrs if available.
6269
08fff70c
EZ
62702011-08-12 Eli Zaretskii <eliz@gnu.org>
6271
6272 * xdisp.c (iterate_out_of_display_property): xassert that
6273 IT->position is set to within IT->object's boundaries. Break from
6274 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6275 when IT->position is set up wrongly due to some bug.
6276 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6277 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6278 entry. Force push_it to save on the stack the current
6279 buffer/string position, to be restored by pop_it. Fix flags in
6280 the iterator structure wrt the object coming from a display
6281 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6282 properties. (Bug#9284)
6283
7be1c708 62842011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6285
7be1c708
CY
6286 * fontset.c (fontset_get_font_group): Add proper type checks.
6287 (Bug#9172)
aac0c6e3 6288
7be1c708 62892011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6290
7be1c708
CY
6291 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6292 and LC_VERSION_MIN_MACOSX.
6293 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6294 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6295
97bb72a6
EZ
62962011-08-08 Eli Zaretskii <eliz@gnu.org>
6297
6298 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6299 no-display-properties-and-no-overlays under bidi display.
6300 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6301 properties and overlays.
97bb72a6 6302
d5617611
CY
63032011-08-08 Chong Yidong <cyd@stupidchicken.com>
6304
37e11a63
CY
6305 * editfns.c (Fset_time_zone_rule): Document relationship with the
6306 setenv function.
6307
d5617611
CY
6308 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6309 the font entity extracted from the cache (Bug#8109).
6310
58872834
CY
63112011-08-07 Chong Yidong <cyd@stupidchicken.com>
6312
6313 * composite.c (autocmp_chars): Don't reset point. That is done by
6314 restore_point_unwind (Bug#5984).
6315
75bfc667
JL
63162011-08-07 Juri Linkov <juri@jurta.org>
6317
6318 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6319 to show the arg `TIME' instead of `TIMEVAL'.
6320
d1410150
EZ
63212011-08-06 Eli Zaretskii <eliz@gnu.org>
6322
6323 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6324 display property strides EOL and includes a newline, as in
6325 longlines-mode. (Bug#9254)
75b771e4
EZ
6326 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6327 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6328
6329 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6330 is non-zero, even if the data buffer is NULL. Fixes a crash in
6331 vertical-motion with longlines-mode. (Bug#9254)
6332
35928349
EZ
63332011-08-05 Eli Zaretskii <eliz@gnu.org>
6334
ec7cc85b
EZ
6335 * bidi.c <bidi_cache_total_alloc>: Now static.
6336 (bidi_initialize): Initialize bidi_cache_total_alloc.
6337
8b76d6f8 6338 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6339 cache. (Bug#9221)
6340
6341 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6342 amount allocated this far in `bidi_cache_total_alloc'.
6343 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6344 non-zero, only free the data buffer without restoring the cache
6345 contents. All callers changed.
6346
6347 * dispextern.h (bidi_unshelve_cache): Update prototype.
6348
6349 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6350 (move_it_in_display_line, move_it_to)
6351 (move_it_vertically_backward, move_it_by_lines): Replace the call
6352 to xfree to an equivalent call to bidi_unshelve_cache.
6353 (move_it_in_display_line_to): Fix logic of returning
412b6358 6354 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6355
e2e2423b
EZ
63562011-08-05 Eli Zaretskii <eliz@gnu.org>
6357
6358 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6359 came from a string character with a `cursor' property. (Bug#9229)
6360
ae9e757a
JD
63612011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6362
6363 * Makefile.in (LIB_PTHREAD): New variable.
6364 (LIBES): Add LIB_PTHREAD (Bug#9216).
6365
6366 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6367 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6368
213bd7f2
AS
63692011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6370
6b02f655 6371 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6372
99aaf75f
JD
63732011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6374
6375 * xterm.c (x_find_topmost_parent): New function.
6376 (x_set_frame_alpha): Find topmost parent window with
6377 x_find_topmost_parent and set the property there also (bug#9181).
6378 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6379
c74e9d86
PE
63802011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6381
6382 * callproc.c (Fcall_process): Avoid vfork clobbering
6383 the local vars buffer, coding_systems, current_dir.
6384
640c8776
SM
63852011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6386
6387 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6388
f26d0e4c
PE
63892011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6390
8a10d76c
PE
6391 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6392 so that it is not optimized away.
6393
f26d0e4c
PE
6394 * xdisp.c (compute_display_string_pos): Remove unused local.
6395
55439c61
EZ
63962011-08-02 Eli Zaretskii <eliz@gnu.org>
6397
6398 Fix slow cursor motion and scrolling in large buffers with
6399 selective display, like Org Mode buffers. (Bug#9218)
6400
6401 * dispextern.h (struct bidi_it): New member disp_prop_p.
6402
6403 * xdisp.c: Remove one-slot cache of display string positions.
6404 (compute_display_string_pos): Accept an additional argument
5e617bc2 6405 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6406 for a display string or property. If found, set DISP_PROP_P
6407 non-zero.
6408
6409 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6410 DISP_PROP_P, and pass it to compute_display_string_pos.
6411 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6412 non-zero. All callers of bidi_fetch_char changed.
6413
fb33fa43
SM
64142011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6415
6416 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6417
b099e063
DM
64182010-12-03 Don March <don@ohspite.net>
6419
6420 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6421 last character M-[char] is translated to ESC [char] (bug#7541).
6422
5cc7f7af
KH
64232011-08-02 Kenichi Handa <handa@m17n.org>
6424
d0fffa3f 6425 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6426
6427 * chartab.c (uniprop_table): Make it non-static.
6428
525d5e6e
EZ
64292011-08-01 Eli Zaretskii <eliz@gnu.org>
6430
6431 * xdisp.c (forward_to_next_line_start): Accept additional argument
6432 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6433 on the newline.
6434 (reseat_at_next_visible_line_start): Use the bidi iterator state
6435 returned by forward_to_next_line_start to restore the state of
6436 it->bidi_it after backing up to previous newline. (Bug#9212)
6437
31011111
AS
64382011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6439
6440 * regex.c (re_comp): Protoize.
6441 (re_exec): Fix return type.
6442 (regexec): Fix type of `ret'. (Bug#9203)
6443
476371c4
PE
64442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6445
e5d76069
PE
6446 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6447 This is needed if max-image-size is a floating-point number.
6448
9a79b20c
AS
64492011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6450
6451 * print.c (print_object): Print empty symbol as ##.
6452
6453 * lread.c (read1): Read ## as empty symbol.
6454
d8c2fa78
AA
64552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6456
6457 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6458 setting frame foreground color (Bug#9175).
6459 (x_set_background_color): Likewise.
6460
ffe57a7a
AA
6461 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6462 contents (Bug#9176).
6463 (EmacsTooltip -init): Remove bezels and add shadows to
6464 tooltip windows.
6465
bf3492a5
AA
6466 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6467 or scroll bar (Bug#8470).
6468
d55e9c53
AA
6469 * nsfont.m (nsfont_open): Remove assignment to voffset and
6470 unnecessary vars hshink, expand, hd, full_height, min_height.
6471 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6472
6473 * nsterm.h (nsfont_info): Remove voffset field.
6474
d8c2fa78 64752011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6476
6477 Implement strike-through and overline on NextStep (Bug#8863).
6478
6479 * nsfont.m (nsfont_open): Use underline position provided by font,
6480 instead of hard-coded value of 2.
6481 (nsfont_draw): Call ns_draw_text_decoration instead.
6482
6483 * nsterm.h: Add declaration for ns_draw_text_decoration.
6484
6485 * nsterm.m (ns_draw_text_decoration): New function for drawing
6486 underline, overline, and strike-through.
6487 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6488 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6489 accommodate underlining, etc.
4843aac3 6490
4cc60b9b
EZ
64912011-07-28 Eli Zaretskii <eliz@gnu.org>
6492
bc7ece87
EZ
6493 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6494 default.
4cc60b9b 6495
476371c4
PE
64962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6497
66606eea
PE
6498 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6499 Without this fix, if a signal arrives just after memory fills up,
6500 'malloc' might be invoked reentrantly.
6501
476371c4
PE
6502 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6503 In other words, assume that every image size is allowed, on non-X
6504 hosts. This assumption is probably wrong, but it lets Emacs compile.
6505
f3fcc40d
AS
65062011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6507
6508 * regex.c (re_iswctype): Convert return values to boolean.
6509
350c992f
EZ
65102011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6511
6512 * xdisp.c (compute_display_string_pos): Don't use cached display
6513 string position if the buffer had its restriction changed.
6514 (Bug#9184)
6515
5266b4bb
PE
65162011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6517
6518 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6519
2573a837 65202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6521
41f55ccd 6522 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6523
39e378da
PE
6524 * bidi.c: Integer size and overflow fixes.
6525 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6526 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6527 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6528 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6529 (bidi_find_other_level_edge):
6530 Use ptrdiff_t instead of EMACS_INT where either will do.
6531 This works better on 32-bit hosts configured --with-wide-int.
6532 (bidi_cache_ensure_space): Check for size-calculation overflow.
6533 Use % rather than repeated addition, for better worst-case speed.
6534 Don't set bidi_cache_size until after xrealloc returns, because it
6535 might not return.
6536 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6537 (bidi_cache_ensure_space): Also check that the bidi cache size
6538 does not exceed that of the largest Lisp string or buffer. See Eli
6539 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6540
5e927815
PE
6541 * alloc.c (__malloc_size_t): Remove.
6542 All uses replaced by size_t. See Andreas Schwab's note
6543 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6544
ca4aa935
PE
6545 * image.c: Improve checking for integer overflow.
6546 (check_image_size): Assume that f is nonnull, since
6547 it is always nonnull in practice. This is one less thing to
6548 worry about when checking for integer overflow later.
6549 (x_check_image_size): New function, which checks for integer
6550 overflow issues inside X.
6551 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6552 This removes the need for a memory_full check.
6553 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6554 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6555 (xbm_read_bitmap_data): Change locals back to 'int', since
6556 their values must fit in 'int'.
6557 (xpm_load_image, png_load, tiff_load):
6558 Invoke x_create_x_image_and_pixmap earlier,
6559 to avoid much needless work if the image is too large.
6560 (tiff_load): Treat overly large images as if
6561 x_create_x_image_and_pixmap failed, not as malloc failures.
6562 (gs_load): Use x_check_image_size.
6563
5f8f9cc2
PE
6564 * gtkutil.c: Omit integer casts.
6565 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6566 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6567
5adf60bc
PE
6568 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6569
c8907a93
PE
6570 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6571 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6572 would wrongly return t on a 64-bit host.
6573
e3c25c68
PE
6574 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6575 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6576 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6577 and therefore cause GCC to emit a bogus diagnostic in some cases.
6578
3f791afe
PE
6579 * image.c: Integer signedness and overflow and related fixes.
6580 This is not an exhaustive set of fixes, but it's time to
6581 record what I've got.
6582 (lookup_pixel_color, check_image_size): Remove redundant decls.
6583 (check_image_size): Don't assume that arbitrary EMACS_INT values
6584 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6585 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6586 (tiff_load, imagemagick_load_image):
6587 Check for overflow in size calculations.
6588 (x_create_x_image_and_pixmap): Remove unnecessary test for
6589 xmalloc returning NULL; that can't happen.
6590 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6591 (xpm_color_bucket): Use better integer hashing function.
6592 (xpm_cache_color): Don't possibly over-allocate memory.
6593 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6594 (gif_memory_source):
6595 Use ptrdiff_t, not int or size_t, to record sizes.
6596 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6597 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6598 either works, as we prefer signed integers.
6599 (tiff_read_from_memory, tiff_write_from_memory):
6600 Return tsize_t, not size_t, since that's what the TIFF API wants.
6601 (tiff_read_from_memory): Don't fail simply because the read would
6602 go past EOF; instead, return a short read.
6603 (tiff_load): Omit no-longer-needed casts.
6604 (Fimagemagick_types): Don't assume size fits into 'int'.
6605
3cc5a532
PE
6606 Improve hashing quality when configured --with-wide-int.
6607 * fns.c (hash_string): New function, taken from sxhash_string.
6608 Do not discard information about ASCII character case; this
6609 discarding is no longer needed.
6610 (sxhash-string): Use it. Change sig to match it. Caller changed.
6611 * lisp.h: Declare it.
6612 * lread.c (hash_string): Remove, since we now use fns.c's version.
6613 The fns.c version returns a wider integer if --with-wide-int is
6614 specified, so this should help the quality of the hashing a bit.
6615
b312a492
PE
6616 * emacs.c: Integer overflow minor fix.
6617 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6618 Define only if GNU_LINUX.
6619 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6620
dfd153ae
PE
6621 * dispnew.c: Integer signedness and overflow fixes.
6622 Remove unnecessary forward decls, that were a maintenance hassle.
6623 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6624 All uses changed.
6625 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6626 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6627 (prepare_desired_row, line_draw_cost):
6628 Use int, not unsigned, where either works.
6629 (save_current_matrix, restore_current_matrix):
6630 Use ptrdiff_t, not size_t, where either works.
6631 (init_display): Check for overflow more accurately, and without
6632 relying on undefined behavior.
6633
a81d11a3
PE
6634 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6635 Remove, replacing with the new symbols in lisp.h. All uses changed.
6636 * fileio.c (make_temp_name):
6637 * filelock.c (lock_file_1, lock_file):
6638 * xdisp.c (message_dolog):
6639 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6640 Use pMd etc. instead.
6641 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6642 replacing the pWIDE etc. symbols removed from editfns.c.
6643
3300e6fd
PE
6644 * keyboard.h (num_input_events): Now uintmax_t.
6645 This is (very slightly) less likely to mess up due to wraparound.
6646 All uses changed.
6647
fd05c7e9
PE
6648 * buffer.c: Integer signedness fixes.
6649 (alloc_buffer_text, enlarge_buffer_text):
6650 Use ptrdiff_t rather than size_t when either will do, as we prefer
6651 signed integers.
6652
903fe15d
PE
6653 * alloc.c: Integer signedness and overflow fixes.
6654 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6655 (__malloc_size_t): Default to size_t, not to int.
6656 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6657 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6658 Prefer ptrdiff_t to size_t when either would do, as we prefer
6659 signed integers.
6660 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6661 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6662 Now const. Initialize with values that are in range even if char
6663 is signed.
6664 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6665 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6666 These functions do the right thing with sizes > 2**32.
6667 (check_depth): Now ptrdiff_t, not int.
6668 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6669 Adjust to new way of storing sizes. Check for size overflow bugs
6670 in rest of code.
6671 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6672 slightly wrong anyway, as it missed one instance of
6673 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6674 (refill_memory_reserve): Omit needless cast to size_t.
6675 (mark_object_loop_halt): Mark as externally visible.
6676
ac82cc6a
PE
6677 * xselect.c: Integer signedness and overflow fixes.
6678 (Fx_register_dnd_atom, x_handle_dnd_message):
6679 Use ptrdiff_t, not size_t, since we prefer signed.
6680 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6681 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6682 x_dnd_atoms_size and x_dnd_atoms_length.
6683
c2d1e36d
PE
6684 * doprnt.c: Prefer signed to unsigned when either works.
6685 * eval.c (verror):
6686 * doprnt.c (doprnt):
6687 * lisp.h (doprnt):
6688 * xdisp.c (vmessage):
6689 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6690 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6691 prefer signed arithmetic to avoid comparison confusion.
6692 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6693 but is a bit tricky.
6694
0e926e56
PE
6695 Assume freestanding C89 headers, string.h, stdlib.h.
6696 * data.c, doprnt.c, floatfns.c, print.c:
6697 Include float.h unconditionally.
6698 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6699 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6700 * regex.c: Likewise for stddef.h, string.h.
6701 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6702 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6703 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6704 (STDC_HEADERS): Remove obsolete defines.
6705 * sysdep.c: Include limits.h unconditionally.
6706
9cfdb3ec
PE
6707 Assume support for memcmp, memcpy, memmove, memset.
6708 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6709 * regex.c (memcmp, memcpy):
6710 Remove; we assume C89 now.
6711
6712 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6713 (__malloc_safe_bcopy): Remove; no longer needed.
6714
cf950e6b 6715 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6716 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6717 well either way, and we prefer signed to unsigned.
6718
dbf38e02
LMI
67192011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6720
6721 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6722 closes the connection while we're reading (bug#9182).
6723
d6f0886c 67242011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6725
d6f0886c
JD
6726 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6727 are specified (Bug#9168).
24e0f6b1 6728
2eb1f9e6
PE
67292011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6730
6731 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6732 Found by GCC static checking and --with-wide-int on a 32-bit host.
6733
22381272 67342011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6735
6736 * xdisp.c (compute_display_string_pos): Fix logic of caching
6737 previous display string position. Initialize cached_prev_pos to
6738 -1. Fixes slow-down at the beginning of a buffer.
6739
f25e39b4
EZ
67402011-07-24 Eli Zaretskii <eliz@gnu.org>
6741
6742 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6743 for attrs[LFACE_FONTSET_INDEX].
6744
04c4b52e
PE
67452011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6746
6747 * xml.c (parse_region): Remove unused local
6748 that was recently introduced.
6749
c1734fbd
EZ
67502011-07-23 Eli Zaretskii <eliz@gnu.org>
6751
be18c5a5
EZ
6752 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6753 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6754
c1734fbd
EZ
6755 * xdisp.c (move_it_in_display_line_to): Record the best matching
6756 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6757 exit if none of the characters scanned was an exact match.
6758 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6759 when exact match is impossible due to invisible text, and the
6760 lines are truncated.
6761
a258d627
JD
67622011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6763
6764 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6765 for OSX >= 10.7.
6766
b6d5a689
EZ
67672011-07-22 Eli Zaretskii <eliz@gnu.org>
6768
0f74f785
EZ
6769 Fix a significant slow-down of cursor motion with C-n, C-p,
6770 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6771 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6772 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6773 (next_element_from_buffer): Call compute_stop_pos_backwards to
6774 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6775 base_level_stop.
6776 (reseat): Don't look for prev_stop, as that could mean a very long
6777 run.
6778 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6779 <cached_disp_overlay_modiff>: Cache for last found display string
6780 position.
551918c1 6781 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6782 about the same buffer in the same area of character positions, and
6783 the buffer wasn't changed since the time the display string
6784 position was cached.
551918c1 6785
b2d0c91a
EZ
67862011-07-22 Eli Zaretskii <eliz@gnu.org>
6787
6788 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6789 is an integer, which is important for empty lines. (Bug#9149)
6790
043604ee
CY
67912011-07-22 Chong Yidong <cyd@stupidchicken.com>
6792
6793 * frame.c (Fmodify_frame_parameters): In tty case, update the
6794 default face if necessary (Bug#4238).
6795
da4adb04
CY
67962011-07-21 Chong Yidong <cyd@stupidchicken.com>
6797
6798 * editfns.c (Fstring_to_char): No need to explain what a character
6799 is in the docstring (Bug#6576).
6800
9abd0532
LMI
68012011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6802
6803 * xml.c (parse_region): Make sure we always return a tree.
6804
36881d16
HK
68052011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6806
6807 * xml.c (parse_region): If a document contains only comments,
6808 return that, too.
6809
1e98674d
LMI
68102011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6811
6812 * xml.c (make_dom): Return comments, too.
6813
590bd467
PE
68142011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6815
6816 Port to OpenBSD.
6817 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6818 and the surrounding thread.
6819 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6820 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6821 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6822 timer goes off.
6823 * s/openbsd.h (BROKEN_SIGIO): Define.
6824 * unexelf.c (unexec) [__OpenBSD__]:
6825 Don't update the .mdebug section of the Alpha COFF symbol table.
6826
f41628b2
LMI
68272011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6828
6829 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6830 (bug#8460).
6831
b59b67c5
PE
68322011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6833
15e3a074
PE
6834 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6835 This fixes some race conditions on the permissions of any newly
6836 created file.
6837
41bed37d
PE
6838 * alloc.c (valid_pointer_p): Use pipe, not open.
6839 This fixes some permissions issues when debugging.
6840
b59b67c5
PE
6841 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6842 If fchown fails to set both uid and gid, try to set just gid,
6843 as that is sometimes allowed. Adjust the file's mode to eliminate
6844 setuid or setgid bits that are inappropriate if fchown fails.
6845
925a6be7
SM
68462011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6847
6848 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6849 to compare Lisp_Objects.
6850 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6851 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6852 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6853
52968808
AS
68542011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6855
0a6a104b
AS
6856 * lread.c (read_integer): Unread even EOF character.
6857 (read1): Likewise. Properly record start position of symbol.
6858
52968808
AS
6859 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6860 symbol character follows.
6861
9e381cdd
PE
68622011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6863
6864 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6865 This works around a problem with the previous change to Fcopy_file.
6866 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6867 and without this change, GCC might complain about discarding
6868 fchown's return value.
6869
b5641435
JB
68702011-07-16 Juanma Barranquero <lekktu@gmail.com>
6871
6872 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6873
a8031457
PE
68742011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6875
6876 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6877
dd889327
LMI
68782011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6879
750c33f7
LMI
6880 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6881 it's used from the C level.
6882
dd889327
LMI
6883 * process.c: Use the same condition for POLL_FOR_INPUT in both
6884 keyboard.c and process.c (bug#1858).
6885
87e86684
LM
68862011-07-09 Lawrence Mitchell <wence@gmx.li>
6887
6888 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6889 (Fgnutls_boot): Use it.
6890
64348f40
AS
68912011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6892
6893 * doc.c (Fsubstitute_command_keys): Revert last change.
6894
1d698799
LMI
68952011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6896
f863868c
LMI
6897 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6898 quotes the next character, and doesn't affect other longer
6899 sequences (bug#8935).
6900
1d698799
LMI
6901 * lread.c (syms_of_lread): Clarify that is isn't only
6902 `eval-buffer' and `eval-defun' that's affected by
6903 `lexical-binding' (bug#8460).
6904
aa4b6df6
EZ
69052011-07-15 Eli Zaretskii <eliz@gnu.org>
6906
6907 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6908 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6909
5d856da6
PE
69102011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6911
ad6042bb
PE
6912 Fix minor problems found by static checking.
6913 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6914 (elsz): Now a signed constant, not a size_t var. We prefer signed
6915 types to unsigned, to avoid integer comparison confusion. Without
6916 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6917 "cannot optimize loop, the loop counter may overflow", a symptom
6918 of the confusion.
f00bbb22 6919 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6920 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6921
6468f31c
LMI
69222011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6923
49080b10
LMI
6924 * search.c (Fre_search_backward): Mention `case-fold-search' in
6925 all the re_search_* functions (bug#8138).
6926
6468f31c
LMI
6927 * keyboard.c (Fopen_dribble_file): Document when the file is
6928 closed (bug#8056).
6929
c965adc5
EZ
69302011-07-14 Eli Zaretskii <eliz@gnu.org>
6931
df9733bf
EZ
6932 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6933 bidi_cache_idx.
6934
0bb23927
EZ
6935 Support bidi reordering of display and overlay strings.
6936 * xdisp.c (compute_display_string_pos)
6937 (compute_display_string_end): Accept additional argument STRING.
6938 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6939 (reseat_to_string): Initialize bidi_it->string.s and
6940 bidi_it->string.schars.
6941 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6942 NULL (avoids a crash in bidi_paragraph_init).
6943 Initialize itb.string.lstring.
0bb23927
EZ
6944 (init_iterator): Call bidi_init_it only of a valid
6945 buffer position was specified. Initialize paragraph_embedding to
6946 L2R.
6947 (reseat_to_string): Initialize the bidi iterator.
6948 (display_string): If we need to ignore text properties of
6949 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6950 original value of -1 will not work with bidi.)
6951 (compute_display_string_pos): First arg is now struct
6952 `text_pos *'; all callers changed. Support display properties on
6953 Lisp strings.
6954 (compute_display_string_end): Support display properties on Lisp
6955 strings.
6956 (init_iterator, reseat_1, reseat_to_string): Initialize the
6957 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6958 when iterating on a string not from display properties).
640c8776
SM
6959 (compute_display_string_pos, compute_display_string_end):
6960 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6961 arrow keys.
6962 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6963 base_level_stop; instead, set base_level_stop to BEGV.
6964 Fixes crashes in vertical-motion.
0bb23927
EZ
6965 (next_element_from_buffer): Improve commentary for when
6966 the iterator is before prev_stop.
6967 (init_iterator): Initialize bidi_p from the default value of
6968 bidi-display-reordering, not from buffer-local value. Use the
6969 buffer-local value only if initializing for buffer iteration.
6970 (handle_invisible_prop): Support invisible properties on strings
6971 that are being bidi-reordered.
6972 (set_iterator_to_next): Support bidi reordering of C strings and
6973 Lisp strings.
6974 (next_element_from_string): Support bidi reordering of Lisp
6975 strings.
6976 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6977 (display_string): Support display of R2L glyph rows.
6978 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6979 (init_iterator): Don't initialize it->bidi_p for strings
6980 here.
6981 (reseat_to_string): Initialize it->bidi_p for strings here.
6982 (next_element_from_string, next_element_from_c_string)
6983 (next_element_from_buffer): Add xassert's for correspondence
6984 between IT's object being iterated and it->bidi_it.string
6985 structure.
6986 (face_before_or_after_it_pos): Support bidi iteration.
6987 (next_element_from_c_string): Handle the case of the first string
6988 character that is not the first one in the visual order.
6989 (get_visually_first_element): New function, refactored from common
6990 parts of next_element_from_buffer, next_element_from_string, and
6991 next_element_from_c_string.
6992 (tool_bar_lines_needed, redisplay_tool_bar)
6993 (display_menu_bar): Force left-to-right direction. Add a FIXME
6994 comment for making that be controlled by a user option.
6995 (push_it, pop_it): Save and restore the state of the
6996 bidi iterator. Save and restore the bidi_p flag.
6997 (pop_it): Iterate out of display property for string iteration as
6998 well.
6999 (iterate_out_of_display_property): Support iteration over strings.
7000 (handle_single_display_spec): Set up it->bidi_it for iteration
7001 over a display string, and call bidi_init_it.
7002 (handle_single_display_spec, next_overlay_string)
7003 (get_overlay_strings_1, push_display_prop): Set up the bidi
7004 iterator for displaying display or overlay strings.
7005 (forward_to_next_line_start): Don't use the shortcut if
7006 bidi-iterating.
7007 (back_to_previous_visible_line_start): If handle_display_prop
7008 pushed the iterator stack, restore the internal state of the bidi
7009 iterator by calling bidi_pop_it same number of times.
7010 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7011 and we are bidi-iterating, don't decrement the iterator position;
7012 instead, set the first_elt flag in the bidi iterator, to produce
7013 the same effect.
7014 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7015 (push_display_prop): xassert that we are iterating a buffer.
7016 (push_it, pop_it): Save and restore paragraph_embedding member.
7017 (handle_single_display_spec, next_overlay_string)
7018 (get_overlay_strings_1, reseat_1, reseat_to_string)
7019 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7020 correctly. Don't assume unibyte strings are not bidi-reordered.
7021 (compute_display_string_pos)
7022 (compute_display_string_end): Fix handling the case of C string.
7023 (push_it, pop_it): Save and restore from_disp_prop_p.
7024 (handle_single_display_spec, push_display_prop): Set the
7025 from_disp_prop_p flag.
7026 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7027 (pop_it): Call iterate_out_of_display_property only if we are
7028 popping after iteration over a string that came from a display
7029 property. Fix a typo in popping stretch info. Add an assertion
7030 for verifying that the iterator position is in sync with the bidi
7031 iterator.
7032 (handle_single_display_spec, get_overlay_strings_1)
7033 (push_display_prop): Fix initialization of paragraph direction for
7034 string when that of the parent object is not yet determined.
7035 (reseat_1): Call bidi_init_it to resync the bidi
7036 iterator with IT's position. (Bug#7616)
7037 (find_row_edges): If ROW->start.pos gives position
7038 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7039 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7040 Reset the from_disp_prop_p flag.
7041 (SAVE_IT, RESTORE_IT): New macros.
7042 (pos_visible_p, face_before_or_after_it_pos)
7043 (back_to_previous_visible_line_start)
7044 (move_it_in_display_line_to, move_it_in_display_line)
7045 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7046 (try_scrolling, redisplay_window, display_line): Use them when
7047 saving a temporary copy of the iterator and restoring it back.
7048 (back_to_previous_visible_line_start, reseat_1)
7049 (init_iterator): Empty the bidi cache "stack".
7050 (move_it_in_display_line_to): If iterator ended up at
7051 EOL, but we never saw any buffer positions smaller than
7052 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7053 motion in bidi-reordered lines.
7054 (move_it_in_display_line_to): Record prev_method and prev_pos
7055 immediately before the call to set_iterator_to_next. Fixes cursor
7056 motion in bidi-reordered lines with stretch glyphs and strings
7057 displayed in margins. (Bug#8133) (Bug#8867)
7058 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7059 TO_CHARPOS.
640c8776
SM
7060 (pos_visible_p): Support positions in bidi-reordered lines.
7061 Save and restore bidi cache.
0bb23927
EZ
7062
7063 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7064 (bidi_paragraph_info): Delete unused struct.
7065 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7066 (bidi_cache_start): New variable.
7067 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7068 to zero.
7069 (bidi_cache_fetch_state, bidi_cache_search)
7070 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7071 (bidi_cache_find, bidi_peek_at_next_level)
7072 (bidi_level_of_next_char, bidi_find_other_level_edge)
7073 (bidi_move_to_visually_next): Compare cache index with
7074 bidi_cache_start rather than with zero.
7075 (bidi_fetch_char): Accept new argument STRING; all callers
7076 changed. Support iteration over a string. Support strings with
7077 display properties. Support unibyte strings. Fix the type of
7078 `len' according to what STRING_CHAR_AND_LENGTH expects.
7079 (bidi_paragraph_init, bidi_resolve_explicit_1)
7080 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7081 (bidi_level_of_next_char, bidi_move_to_visually_next):
7082 Support iteration over a string.
0bb23927
EZ
7083 (bidi_set_sor_type, bidi_resolve_explicit_1)
7084 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7085 can now be zero (for strings); special values 0 and -1 were
7086 changed to -1 and -2, respectively.
7087 (bidi_char_at_pos): New function.
7088 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7089 Call it instead of FETCH_MULTIBYTE_CHAR.
7090 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7091 initialized to valid values.
7092 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7093 values.
7094 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7095 the test for valid cached positions. Fix the logic for looking up
7096 the sentinel state in the cache. GCPRO the Lisp string we are
7097 iterating.
7098 (bidi_push_it, bidi_pop_it): New functions.
7099 (bidi_initialize): Initialize the bidi cache start stack pointer.
7100 (bidi_cache_ensure_space): New function, refactored from part of
7101 bidi_cache_iterator_state. Don't assume the required size is just
7102 one BIDI_CACHE_CHUNK away.
7103 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7104 (bidi_count_bytes, bidi_char_at_pos): New functions.
7105 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7106 always valid if bidi_cache_idx is valid.
7107 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7108 is valid if it's going to be used.
7109 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7110 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7111 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7112 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7113 (bidi_find_other_level_edge, bidi_cache_start_stack):
7114 All variables related to cache indices are now EMACS_INT.
c965adc5 7115
0bb23927
EZ
7116 * dispextern.h (struct bidi_string_data): New structure.
7117 (struct bidi_it): New member `string'. Make flag members be 1-bit
7118 fields, and put them last in the struct.
640c8776
SM
7119 (compute_display_string_pos, compute_display_string_end):
7120 Update prototypes.
0bb23927
EZ
7121 (bidi_push_it, bidi_pop_it): Add prototypes.
7122 (struct iterator_stack_entry): New members bidi_p,
7123 paragraph_embedding, and from_disp_prop_p.
7124 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7125 (bidi_shelve_cache, bidi_unshelve_cache):
7126 Declare prototypes.
0bb23927
EZ
7127
7128 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7129 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7130 and vector-like objects.
7131
7132 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7133 cache around display iteration.
7134
7135 * window.c (Fwindow_end, window_scroll_pixel_based)
7136 (displayed_window_lines, Frecenter): Save and restore the bidi
7137 cache around display iteration.
7138
3bbd2265
LMI
71392011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7140
7141 * editfns.c (Fdelete_region): Clarify the use of the named
7142 parameters (bug#6788).
7143
adc47434
MR
71442011-07-14 Martin Rudalics <rudalics@gmx.at>
7145
7146 * indent.c (Fvertical_motion): Set and restore w->pointm when
7147 saving and restoring the window's buffer (Bug#9006).
7148
837c31f8
LMI
71492011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7150
7151 * editfns.c (Fstring_to_char): Clarify just what is returned
7152 (bug#6576). Text by Eli Zaretskii.
7153
ac389d0c
JB
71542011-07-13 Juanma Barranquero <lekktu@gmail.com>
7155
7156 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7157
0be0ce47
EZ
71582011-07-13 Eli Zaretskii <eliz@gnu.org>
7159
7160 * buffer.c (mmap_find): Fix a typo.
7161
cd18e7e3
JB
71622011-07-13 Johan Bockgård <bojohan@gnu.org>
7163
7164 Fix execution of x selection hooks.
7165 * xselect.c (Qx_lost_selection_functions)
7166 (Qx_sent_selection_functions): New vars.
7167 (syms_of_xselect): DEFSYM them.
7168 (x_handle_selection_request): Pass Qx_sent_selection_functions
7169 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7170 (x_handle_selection_clear,x_clear_frame_selections):
7171 Pass Qx_lost_selection_functions rather than
7172 Vx_lost_selection_functions to Frun_hook_with_args.
7173
47ea7f44
PE
71742011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7175
ac389d0c 7176 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7177 The old code sometimes used this field without initializing it.
7178
47ea7f44
PE
7179 * alloc.c (gc_sweep): Don't read past end of array.
7180 In theory, the old code could also have corrupted Emacs internals,
7181 though it'd be very unlikely.
7182
bc985c87
AS
71832011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7184
7185 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7186 argument. (Bug#4026)
bc985c87 7187
0cf34688
LMI
71882011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7189
b3dadd76
LMI
7190 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7191 key" (bug#4257).
7192
0cf34688
LMI
7193 * window.c (Fset_window_start): Doc fix (bug#4199).
7194 (Fset_window_hscroll): Ditto.
7195
270768cd
PE
71962011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7197
077e3dda 7198 Fix minor new problems caught by GCC 4.6.1.
270768cd 7199 * term.c (init_tty): Remove unused local.
490011a6 7200 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7201 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7202 not used otherwise.
270768cd 7203
b1f58454
CY
72042011-07-12 Chong Yidong <cyd@stupidchicken.com>
7205
7206 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7207
22b9578d
LMI
72082011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7209
6e70ab07
LMI
7210 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7211 are the mini-buffer and the echo area (bug#3320).
7212
22b9578d
LMI
7213 * term.c (init_tty): Remove support for supdup, c10 and perq
7214 terminals, which are no longer supported (bug#1482).
7215
8974cc9f
JB
72162011-07-10 Johan Bockgård <bojohan@gnu.org>
7217
7218 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7219
a560d974
JD
72202011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7221
7222 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7223 for non-popups (Bug#3642).
7224
1dae0f0a
AS
72252011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7226
268c2c36 7227 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7228 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7229 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7230 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7231 * data.c (fmod): Likewise.
7232 * dispnew.c (swap_glyphs_in_rows): Likewise.
7233 * emacs.c (memory_warning_signal): Likewise.
7234 * floatfns.c (float_error): Likewise.
7235 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7236 (otf_open, font_otf_capability, generate_otf_features)
7237 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7238 Likewise.
7239 * image.c (pbm_read_file): Likewise.
7240 * indent.c (string_display_width): Likewise.
7241 * intervals.c (check_for_interval, search_for_interval)
7242 (inc_interval_count, count_intervals, root_interval)
7243 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7244 * lread.c (defalias): Likewise.
268c2c36 7245 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7246 * regex.c (set_image_of_range_1, set_image_of_range)
7247 (regex_grow_registers): Likewise.
7248 * sysdep.c (strerror): Likewise.
7249 * termcap.c (valid_filename_p, tprint, main): Likewise.
7250 * tparam.c (main): Likewise.
7251 * unexhp9k800.c (run_time_remap, save_data_space)
7252 (update_file_ptrs, read_header, write_header, calculate_checksum)
7253 (copy_file, copy_rest, display_header): Likewise.
7254 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7255 Likewise.
7256 * xdisp.c (check_it): Likewise.
7257 * xfaces.c (register_color, unregister_color, unregister_colors):
7258 Likewise.
7259 * xfns.c (print_fontset_result): Likewise.
7260 * xrdb.c (member, fatal, main): Likewise.
7261
99033785
PE
72622011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7263
7264 Fix minor problems found by static checking (Bug#9031).
7265 * chartab.c (char_table_set_range, map_sub_char_table):
7266 Remove unused locals.
7267 (uniprop_table): Now static.
7268 * composite.c (_work_char): Remove unused static var.
7269
9cb2ac56
JB
72702011-07-09 Juanma Barranquero <lekktu@gmail.com>
7271
7272 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7273
f25661f0
JD
72742011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7275
7276 * gtkutil.c (qttip_cb): Remove code without function.
7277
8278c4fe
EZ
72782011-07-09 Eli Zaretskii <eliz@gnu.org>
7279
7280 * w32.c (pthread_sigmask): New stub.
7281
1692ae2d 72822011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7283
8a6ebd58 7284 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7285 sigprocmask is portable only for single-threaded applications, and
7286 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7287 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7288 (LIBES): Use it.
7289 * callproc.c (Fcall_process):
7290 * process.c (create_process):
7291 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7292 Use pthread_sigmask, not sigprocmask.
123403e4 7293
1b854618
JD
72942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7295
7296 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7297 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7298 wrong (Bug#8591).
7299
3fe4b549
JD
73002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7301
0ce7e563
JD
7302 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7303 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7304 (xg_hide_tooltip): Fix comment.
7305
3fe4b549
JD
7306 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7307 in registerServicesMenuSendTypes.
7308 (validRequestorForSendType): Don't check ns_return_types.
7309
7310 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7311 ns_return_type.
7312
5df75e47
JR
73132011-07-08 Jason Rumney <jasonr@gnu.org>
7314
22610910
JR
7315 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7316 SH_SHOW for hidden windows (Bug#5482).
7317
5df75e47
JR
7318 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7319 frame struct members of non-existent frames (Bug#6284).
7320
699c10bd
JD
73212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7322
4393663b
JD
7323 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7324 variable firstTime not needed on OSX >= 10.6.
7325 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7326 >= 10.5. Use setKnobProportion, setDoubleValue.
7327
7328 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7329 (MAC_OS_X_VERSION_10_5): Define if not defined.
7330 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7331 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7332 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7333
7334 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7335 cString and lossyCString on OSX >= 10.4
7336
58179cce 7337 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7338 sizeToFit on OSX >= 10.2.
7339
7340 * nsimage.m (allocInitFromFile): Don't use deprecated method
7341 bestRepresentationForDevice on OSX >= 10.6.
7342
7343 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7344 to avoid warning.
7345
7346 * emacs.c: Declare unexec_init_emacs_zone.
7347
a63e0781
JD
7348 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7349
699c10bd
JD
7350 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7351
7352 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7353 on svcsMenu (Bug#8842).
7354
7355 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7356 ns_return_types.
7357 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7358
7359 * nsterm.m (QUTF8_STRING): Declare.
7360 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7361 (validRequestorForSendType): Return type is (id).
7362 Change indexOfObjectIdenticalTo to indexOfObject.
7363 Check if we have local selection before returning self (Bug#8842).
7364 (writeSelectionToPasteboard): Put local selection into paste board
7365 if we have a local selection (Bug#8842).
7366 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7367
7368 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7369 (ns_get_local_selection): Declare.
7370
54e10184
LMI
73712011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7372
9888ff71
LMI
7373 * keymap.c (describe_map_tree): Don't insert a double newline at
7374 the end of the buffer (bug#1169) and return whether we inserted
7375 something.
7376
54e10184
LMI
7377 * callint.c (Fcall_interactively): Change "reading args" to
7378 "providing args" to try to clarify what it does (bug#1010).
7379
15fa4783
KH
73802011-07-07 Kenichi Handa <handa@m17n.org>
7381
7382 * composite.c (composition_compute_stop_pos): Ignore a static
7383 composition starting before CHARPOS (Bug#8915).
7384
7385 * xdisp.c (handle_composition_prop): Likewise.
7386
a8815b00
EZ
73872011-07-07 Eli Zaretskii <eliz@gnu.org>
7388
7389 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7390 (Bug#9015)
7391
ef7b981d 73922011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7393
7394 * character.h (unicode_category_t): New enum type.
7395
7396 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7397 (Qchar_code_property_table): New variable.
7398 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7399 (UNIPROP_COMPRESSED_FORM_P): New macros.
7400 (char_table_ascii): Uncompress the compressed values.
7401 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7402 Uncompress the compressed values.
ac389d0c 7403 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7404 (char_table_ref_and_range): Uncompress the compressed values.
7405 (sub_char_table_set): New arg is_uniprop. Callers changed.
7406 Uncompress the compressed values.
7407 (sub_char_table_set_range): Args changed. Callers changed.
7408 (char_table_set_range): Adjuted for the above change.
7409 (map_sub_char_table): Delete args default_val and parent. Add arg
7410 top. Give decoded values to a Lisp function.
640c8776 7411 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7412 values to a Lisp function. Gcpro more variables.
7413 (uniprop_table_uncompress)
7414 (uniprop_decode_value_run_length): New functions.
7415 (uniprop_decoder, uniprop_decoder_count): New variables.
7416 (uniprop_get_decoder, uniprop_encode_value_character)
7417 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7418 New functions.
7419 (uniprop_encoder, uniprop_encoder_count): New variables.
7420 (uniprop_get_encoder, uniprop_table)
7421 (Funicode_property_table_internal, Fget_unicode_property_internal)
7422 (Fput_unicode_property_internal): New functions.
7423 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7424 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7425 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7426 char-code-property-alist.
7427
640c8776 7428 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7429 Vunicode_category_table.
7430
640c8776 7431 * font.c (font_range): Adjust for the change of
c805dec0
KH
7432 Vunicode_category_table.
7433
76b397fb
DN
74342011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7435
7436 * m/iris4d.h: Remove file, move contents ...
7437 * s/irix6-5.h: ... here.
7438
22b4128e
PE
74392011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7440
7441 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7442 * alloc.c (mark_buffer):
7443 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7444 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7445 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7446 This isn't true in general, and it's particularly not true
7447 if Emacs is configured with --with-wide-int.
7448 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7449 New macros, used in the buffer.c change.
7450
869795d6
JD
74512011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7452
7453 * xsettings.c: Use both GConf and GSettings if both are available.
7454 (store_config_changed_event): Add comment.
7455 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7456 (store_tool_bar_style_changed): New functions.
5e617bc2 7457 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7458 (struct xsettings): Move font inside HAVE_XFT.
7459 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7460 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7461 Move inside HAVE_XFT.
640c8776 7462 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7463 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7464 also.
7465 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7466 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7467 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7468 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7469 (parse_settings): Move check for font inside HAVE_XFT.
7470 (read_settings, apply_xft_settings): Add comment.
7471 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7472 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7473 call store_font_name_changed.
7474 (xft_settings_event): Add comment.
7475 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7476 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7477 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7478 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7479 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7480 (xsettings_get_system_font, xsettings_get_system_normal_font):
7481 Add comment.
869795d6 7482
d8ed26bd
PE
74832011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7484
7485 Random fixes. E.g., (random) never returned negative values.
7486 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7487 subseconds part to the entropy, as that's a bit more random.
7488 Prefer signed to unsigned, since the signedness doesn't matter and
7489 in general we prefer signed. When given a limit, use a
7490 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7491 latter isn't right if USE_2_TAGS_FOR_INTS.
7492 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7493 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7494
cabf1cac
SM
74952011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7496
7497 * textprop.c (text_property_stickiness):
7498 Obey Vtext_property_default_nonsticky.
7499 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7500 * w32fns.c (syms_of_w32fns):
7501 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7502
6e9b2be9
PE
75032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7504
7505 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7506 This is more efficient than Ffile_directory_p and avoids a minor race.
7507
90186c68
LMI
75082011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7509
7c301272
LMI
7510 * buffer.c (Foverlay_put): Say what the return value is
7511 (bug#7835).
7512
c4f2d8d4
LMI
7513 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7514 is a directory before asking whether to use the file name
7515 (bug#7564).
ad637907
LMI
7516 (barf_or_query_if_file_exists): Make the "File is a directory"
7517 error be more correct.
c4f2d8d4 7518
90186c68
LMI
7519 * fns.c (Frequire): Remove the mention of the .gz files, since
7520 that's installation-specific, but keep the mention of
7521 `get-load-suffixes'.
7522
da64016e
PE
75232011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7524
7525 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7526 Report string overflow if the output is too long.
7527
7d47b580
JB
75282011-07-04 Juanma Barranquero <lekktu@gmail.com>
7529
a555cb87
JB
7530 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7531 (syms_of_gnutls): Remove duplicate DEFSYM for
7532 Qgnutls_bootprop_verify_hostname_error, an error for
7533 Qgnutls_bootprop_verify_error (which is no longer used).
7534
7d47b580
JB
7535 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7536 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7537 Also (re)move comments that are misplaced or no longer relevant.
7538
1e49bfab
LMI
75392011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7540
7541 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7542
1485f4c0
CY
75432011-07-03 Chong Yidong <cyd@stupidchicken.com>
7544
7545 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7546 and background color parameters if they have been changed.
7547
a9ab721e
LMI
75482011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7549
7550 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7551
cf7cff57
PE
75522011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7553
2e13213d
PE
7554 * xsettings.c (SYSTEM_FONT): Define only when used.
7555 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7556
cf7cff57
PE
7557 * keymap.c (access_keymap_1): Now static.
7558
7a8e04f7
CY
75592011-07-02 Chong Yidong <cyd@stupidchicken.com>
7560
7561 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7562 leave any prefix arg for the up event (Bug#1586).
7563
61352f62
LMI
75642011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7565
69bb1ef7
LMI
7566 * lread.c (syms_of_lread): Mention single symbols defined by
7567 `defvar' or `defconst' (bug#7154).
7568
61352f62 7569 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7570 (Frequire): Mention get-load-suffixes.
61352f62 7571
28545e04
MR
75722011-07-02 Martin Rudalics <rudalics@gmx.at>
7573
7574 * window.h (window): Remove clone_number slot.
7575 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7576 Remove.
7577 (make_parent_window, make_window, saved_window)
7578 (Fset_window_configuration, save_window_save): Don't deal with
7579 clone numbers.
7580 * buffer.c (Qclone_number): Remove declaration.
7581 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7582
3349e122
SM
75832011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7584
7585 Add multiple inheritance to keymaps.
7586 * keymap.c (Fmake_composed_keymap): New function.
7587 (Fset_keymap_parent): Simplify.
7588 (fix_submap_inheritance): Remove.
7589 (access_keymap_1): New function extracted from access_keymap to handle
7590 embedded parents and handle lists of maps.
7591 (access_keymap): Use it.
7592 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7593 (Fcopy_keymap): Handle embedded parents.
7594 (Fcommand_remapping, define_as_prefix): Simplify.
7595 (Fkey_binding): Simplify.
7596 (syms_of_keymap): Move minibuffer-local-completion-map,
7597 minibuffer-local-filename-completion-map,
7598 minibuffer-local-must-match-map, and
7599 minibuffer-local-filename-must-match-map to Elisp.
7600 (syms_of_keymap): Defsubr make-composed-keymap.
7601 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7602 (parse_menu_item): Trivial simplification.
7603
3279eb87
GM
76042011-07-01 Glenn Morris <rgm@gnu.org>
7605
7606 * Makefile.in (SETTINGS_LIBS): Fix typo.
7607
4550efdf
KI
76082011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7609
7610 * coding.c (Fencode_coding_string): Record the last coding system
7611 used, as the function doc string says (bug#8738).
7612
0949d2b6
JD
76132011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7614
7615 * xsettings.c (store_monospaced_changed): Take new font as arg and
7616 check for change against current_mono_font.
7617 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7618 (emacs_settings_constructor, emacs_settings_get_property)
7619 (emacs_settings_set_property, emacs_settings_class_init)
7620 (emacs_settings_init, gsettings_obj): Remove.
7621 (something_changedCB): New function for HAVE_GSETTINGS.
7622 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7623 with value as argument.
7624 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7625 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7626 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7627 "changed".
7628
7629 * xgselect.c: Add defined (HAVE_GSETTINGS).
7630 (xgselect_initialize): Ditto.
7631
7632 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7633 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7634 xg_select.
7635
bbc6b304
PE
76362011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7637
7638 * eval.c (struct backtrace): Simplify and port the data structure.
7639 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7640 signed bit field, as this assumption is not portable and it makes
7641 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7642 "char debug_on_exit : 1" as this is not portable either; instead,
7643 use the portable "unsigned int debug_on_exit : 1". Remove unused
7644 member evalargs. Remove obsolete comments about cc bombing out.
7645
9851bfc5
JD
76462011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7647
51bb811f 7648 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7649 Let HAVE_GSETTINGS override HAVE_GCONF.
7650 (store_monospaced_changed): New function.
7651 (EMACS_SETTINGS): A new type derived from GObject to handle
7652 GSettings notifications.
7653 (emacs_settings_constructor, emacs_settings_get_property)
7654 (emacs_settings_set_property, emacs_settings_class_init):
7655 New functions.
7656 (gsettings_client, gsettings_obj): New variables.
7657 (GSETTINGS_SCHEMA): New define.
7658 (something_changedCB): Call store_monospaced_changed.
7659 (init_gsettings): New function.
7660 (xsettings_initialize): Call init_gsettings.
7661 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7662 to NULL.
7663
640c8776 7664 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7665 GCONF_CFLAGS/LIBS.
7666
5386012d
MR
76672011-06-29 Martin Rudalics <rudalics@gmx.at>
7668
7669 * window.c (resize_root_window, grow_mini_window)
7670 (shrink_mini_window): Rename Qresize_root_window to
7671 Qwindow_resize_root_window and Qresize_root_window_vertically to
7672 Qwindow_resize_root_window_vertically.
7673
f13e0b08
PE
76742011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7675
7676 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7677
94515237
JB
76782011-06-27 Juanma Barranquero <lekktu@gmail.com>
7679
7680 * makefile.w32-in: Redesign dependencies so they reflect more
7681 clearly which files are directly included by each source file,
7682 and not through other includes.
7683
e43b6e43
MR
76842011-06-27 Martin Rudalics <rudalics@gmx.at>
7685
7686 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7687 (sort_overlays, overlay_strings): When an overlay's clone number
7688 matches the window's clone number process the overlay even if
7689 the overlay's window property doesn't match the current window.
7690
d68443dc
MR
7691 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7692 (Fwindow_hchild): Rename to Fwindow_left_child.
7693 (Fwindow_next): Rename to Fwindow_next_sibling.
7694 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7695 (resize_window_check): Rename to window_resize_check.
7696 (resize_window_apply): Rename to window_resize_apply.
7697 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7698 (Fdelete_other_windows_internal, resize_frame_windows)
7699 (Fsplit_window_internal, Fdelete_window_internal)
7700 (grow_mini_window, shrink_mini_window)
7701 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7702
c7e73be5
JD
77032011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7704
7705 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7706 (emacs_fixed_set_min_size): Remove.
7707 (emacs_fixed_new): Take frame as argument.
7708
7709 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7710 (_EmacsFixedPrivate): Remove minwidth/height.
7711 Add struct frame *f.
7712 (emacs_fixed_init): Initialize priv->f.
7713 (get_parent_class, emacs_fixed_set_min_size): Remove.
7714 (emacs_fixed_new): Set priv->f to argument.
7715 (emacs_fixed_get_preferred_width)
7716 (emacs_fixed_get_preferred_height): Use min_width/height from
7717 frames size_hint to set minimum and natural (Bug#8919).
7718 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7719 and use min_width/height from frames size_hint to set
7720 min_width/height (Bug#8919).
7721
7722 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7723 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7724 Fix indentation.
c7e73be5 7725
cf99dcf8
EZ
77262011-06-26 Eli Zaretskii <eliz@gnu.org>
7727
7728 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7729 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7730 called at ZV.
7731
029529ac
CY
77322011-06-26 Chong Yidong <cyd@stupidchicken.com>
7733
7734 * process.c (wait_reading_process_output): Bypass select if
7735 waiting for a cell while ignoring keyboard input, and input is
7736 pending. Suggested by Jan Djärv (Bug#8869).
7737
7a7ef429
PE
77382011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7739
7740 Use gnulib's dup2 module instead of rolling our own.
7741 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7742
11fdef7d 77432011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7744
7745 * dispnew.c (scrolling_window): Before scrolling, turn off a
7746 mouse-highlight in the window being scrolled.
7747
cd3520a4
JB
77482011-06-24 Juanma Barranquero <lekktu@gmail.com>
7749
7750 Move DEFSYM to lisp.h and use everywhere.
7751
7752 * character.h (DEFSYM): Move declaration...
7753 * lisp.h (DEFSYM): ...here.
7754
7755 * gnutls.c:
7756 * minibuf.c:
7757 * w32menu.c:
7758 * w32proc.c:
7759 * w32select.c: Don't include character.h.
7760
7761 * alloc.c (syms_of_alloc):
7762 * buffer.c (syms_of_buffer):
7763 * bytecode.c (syms_of_bytecode):
7764 * callint.c (syms_of_callint):
7765 * casefiddle.c (syms_of_casefiddle):
7766 * casetab.c (init_casetab_once):
7767 * category.c (init_category_once, syms_of_category):
7768 * ccl.c (syms_of_ccl):
7769 * cmds.c (syms_of_cmds):
7770 * composite.c (syms_of_composite):
7771 * dbusbind.c (syms_of_dbusbind):
7772 * dired.c (syms_of_dired):
7773 * dispnew.c (syms_of_display):
7774 * doc.c (syms_of_doc):
7775 * editfns.c (syms_of_editfns):
7776 * emacs.c (syms_of_emacs):
7777 * eval.c (syms_of_eval):
7778 * fileio.c (syms_of_fileio):
7779 * fns.c (syms_of_fns):
7780 * frame.c (syms_of_frame):
7781 * fringe.c (syms_of_fringe):
7782 * insdel.c (syms_of_insdel):
7783 * keymap.c (syms_of_keymap):
7784 * lread.c (init_obarray, syms_of_lread):
7785 * macros.c (syms_of_macros):
7786 * msdos.c (syms_of_msdos):
7787 * print.c (syms_of_print):
7788 * process.c (syms_of_process):
7789 * search.c (syms_of_search):
7790 * sound.c (syms_of_sound):
7791 * syntax.c (init_syntax_once, syms_of_syntax):
7792 * terminal.c (syms_of_terminal):
7793 * textprop.c (syms_of_textprop):
7794 * undo.c (syms_of_undo):
7795 * w32.c (globals_of_w32):
7796 * window.c (syms_of_window):
7797 * xdisp.c (syms_of_xdisp):
7798 * xfaces.c (syms_of_xfaces):
7799 * xfns.c (syms_of_xfns):
7800 * xmenu.c (syms_of_xmenu):
7801 * xsettings.c (syms_of_xsettings):
7802 * xterm.c (syms_of_xterm): Use DEFSYM.
7803
4228cf16
TZ
78042011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7805
cd3520a4 7806 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7807
7fcccf1e
PE
78082011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7809
7efb4e0e
PE
7810 Integer and buffer overflow fixes (Bug#8873).
7811
ff5844ad
PE
7812 * print.c (printchar, strout): Check for string overflow.
7813 (PRINTPREPARE, printchar, strout):
7814 Don't set size unless allocation succeeds.
7815
90532f02
PE
7816 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7817 for sizes. Check for string overflow more accurately.
7818 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7819
6d84508d
PE
7820 * macros.c: Integer and buffer overflow fixes.
7821 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7822 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7823 Use ptrdiff_t, not int, for sizes.
7824 Don't increment bufsize until after realloc succeeds.
7825 Check for size-calculation overflow.
7826 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7827
437b2cb4
PE
7828 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7829
8b9ac8b4
PE
7830 * lread.c: Integer overflow fixes.
7831 (read_integer): Radix is now EMACS_INT, not int,
7832 to improve quality of diagnostics for out-of-range radices.
7833 Calculate buffer size correctly for out-of-range radices.
7834 (read1): Check for integer overflow in radices, and in
7835 read-circle numbers.
82cb60d3
PE
7836 (read_escape): Avoid int overflow.
7837 (Fload, openp, read_buffer_size, read1)
7838 (substitute_object_recurse, read_vector, read_list, map_obarray):
7839 Use ptrdiff_t, not int, for sizes.
7840 (read1): Use EMACS_INT, not int, for sizes.
20270765 7841 Check for size overflow.
8b9ac8b4 7842
7fcccf1e
PE
7843 * image.c (cache_image): Check for size arithmetic overflow.
7844
bfbbd7e7
PE
7845 * lread.c: Integer overflow issues.
7846 (saved_doc_string_size, saved_doc_string_length)
7847 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7848 Now ptrdiff_t, not int.
7849 (read1): Don't assume doc string length fits in int. Check for
7850 out-of-range doc string lengths.
7851 (read_list): Don't assume file position fits in int.
39019e54 7852 (read_escape): Check for hex character overflow.
bfbbd7e7 7853
4e323265
LL
78542011-06-22 Leo Liu <sdl.web@gmail.com>
7855
7856 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7857 Move to minibuffer.el.
7858
85fece3e
PE
78592011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7860
20b84ce9 7861 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7862 The following patches are for when GLYPH_DEBUG && !XASSERT.
7863 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7864 * dispnew.c (flush_stdout):
7865 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7866 Mark as externally visible.
7867 * dispnew.c (check_window_matrix_pointers): Now static.
7868 * dispnew.c (window_to_frame_vpos):
7869 * xfns.c (unwind_create_frame):
7870 * xterm.c (x_check_font): Remove unused local.
7871 * scroll.c (CHECK_BOUNDS):
7872 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7873 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7874 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7875 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7876 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7877 Now static.
7878 (debug_method_add): Use va_list and vsprintf rather than relying
7879 on undefined behavior with wrong number of arguments.
7880 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7881 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7882 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7883 since we're not interested in debugging glyphs with old libraries.
7884 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7885 GCC 4.6.0's static checking.
7886
0766b489
PE
78872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7888
31fd4b32
PE
7889 Integer overflow and signedness fixes (Bug#8873).
7890 A few related buffer overrun fixes, too.
7891
b79e8648
PE
7892 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7893
0766b489
PE
7894 * dispextern.h (struct face.stipple):
7895 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7896 (x_bitmap_mask, x_allocate_bitmap_record)
7897 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7898 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7899 (x_create_bitmap_from_xpm_data):
7900 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7901 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7902 (.bitmaps_last):
7903 * xfaces.c (load_pixmap):
7904 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7905 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7906 (.bitmaps_last, struct x_output.icon_bitmap):
7907 Use ptrdiff_t, not int, for bitmap indexes.
7908 (x_allocate_bitmap_record): Check for size overflow.
7909 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7910
b081724f
PE
7911 Use ptrdiff_t, not int, for overlay counts.
7912 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7913 * editfns.c (overlays_around, get_pos_property):
7914 * textprop.c (get_char_property_and_overlay):
7915 * xdisp.c (next_overlay_change, note_mouse_highlight):
7916 * xfaces.c (face_at_buffer_position):
21514da7
PE
7917 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7918 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7919 (Fnext_overlay_change, Fprevious_overlay_change)
7920 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7921 Use ptrdiff_t, not int, for sizes.
21514da7 7922 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7923
3de73e5e
PE
7924 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7925
2606c57b
PE
7926 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7927 (x_session_initialize): Do not assume string length fits in int.
7928
aaafe47a
PE
7929 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7930 This is unlikely, but can occur if DPI is outlandish.
7931
2674ddc8 7932 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7933 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7934
28154962
PE
7935 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7936 * xrdb.c (magic_file_p, search_magic_path):
7937 Omit last arg SUFFIX; it was always 0. All callers changed.
7938 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7939
7de51af5
PE
7940 * xfont.c (xfont_match): Avoid need for strlen.
7941
25ed6cc3
PE
7942 * xfns.c: Don't assume strlen fits in int.
7943 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7944
4eab31dd
PE
7945 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7946 not unsigned long, as we prefer signed integers. All callers changed.
7947 Detect integer overflow in repeat count.
7948 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7949 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7950
171e2a58
PE
7951 * termcap.c: Don't assume sizes fit in int and never overflow.
7952 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7953 (gobble_line): Check for size-calculation overflow.
7954
ad39faca 7955 * minibuf.c (Fread_buffer):
6e5bb2dc 7956 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7957 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7958 Don't assume string length fits in int.
7959
52c61c22 7960 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7961 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7962
b5b8c9e5
PE
7963 * font.c: Don't assume string length fits in int.
7964 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7965 Use ptrdiff_t, not int.
ccd6111c
PE
7966 (font_intern_prop): Don't assume string length fits in int.
7967 Don't assume integer property fits in fixnum.
7968 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7969
882f0d81 7970 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7971 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7972 Reformulate so as not to need the command string.
7973 Invoke gzip -cd rather than gunzip, as it's more portable.
7974 (lock_info_type, lock_file_1, lock_file):
7975 Don't assume pid_t and time_t fit in unsigned long.
7976 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7977 (current_lock_owner): Prefer signed type for sizes.
7978 Use memcpy, not strncpy, where memcpy is what is really wanted.
7979 Don't assume (via atoi) that time_t and pid_t fit in int.
7980 Check for time_t and/or pid_t out of range, e.g., via a network share.
7981 Don't alloca where an auto var works fine.
7982
93f4cf88
PE
7983 * fileio.c: Fix some integer overflow issues.
7984 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7985 Don't assume string length fits in int.
7986 (directory_file_name): Don't assume string length fits in long.
7987 (make_temp_name): Don't assume pid fits in int, or that its print
7988 length is less than 20.
7989
f3e92b69
PE
7990 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7991
1bfdaf10
PE
7992 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7993
35016e9a
PE
7994 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7995
3d1e65a1
PE
7996 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7997 We prefer signed integers, even for size calculations.
7998
0b963a93
PE
7999 * emacs.c: Don't assume string length fits in 'int'.
8000 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8001 (main): Don't invoke strlen when not needed.
8002
573f4b54
PE
8003 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8004 (XD_DEBUG_MESSAGE): Don't waste a byte.
8005
989f33ba
PE
8006 * callproc.c (getenv_internal_1, getenv_internal)
8007 (Fgetenv_internal):
965d34eb
PE
8008 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8009
e4d29b33
PE
8010 * lread.c (invalid_syntax): Omit length argument.
8011 All uses changed. This doesn't fix a bug, but it simplifies the
8012 code away from its former Hollerith-constant appearance, and it's
8013 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8014 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8015
eb49b136
PE
8016 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8017 This didn't break anything, but it didn't help either.
8018 It's confusing to put a bogus integer in a place where the actual
8019 value does not matter.
9f62aeb1 8020 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8021 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8022
15375a22
PE
8023 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8024 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8025 implementation.
b61cc01c
PE
8026 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8027 We prefer signed types, and the value cannot exceed the EMACS_INT
8028 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8029 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8030 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8031 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8032
53b2623d
PE
8033 * indent.c (sane_tab_width): New function.
8034 (current_column, scan_for_column, Findent_to, position_indentation)
8035 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8036 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8037
51cab52b 8038 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8039
f2ed8a70
PE
8040 * lisp.h (lint_assume): New macro.
8041 * composite.c (composition_gstring_put_cache):
8042 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8043
abe80cc6
PE
8044 * editfns.c, insdel.c:
8045 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8046
b02c740e
PE
8047 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8048
ebc96716
PE
8049 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8050
b4e50fa0 8051 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8052 Use much-faster test for byte-length change.
311d5d7c 8053 Don't assume string byte-length fits in 'int'.
a4cf38e4 8054 Check that character arg fits in 'int'.
85461888 8055 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8056
c0c1ee9f
PE
8057 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8058
a498d7f4
PE
8059 * fns.c (concat): Catch string overflow earlier.
8060 Do not rely on integer wraparound.
8061
51cab52b
PE
8062 * dispextern.h (struct it.overlay_strings_charpos)
8063 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8064 * xdisp.c (forward_to_next_line_start)
8065 (back_to_previous_visible_line_start)
8066 (reseat_at_next_visible_line_start, next_element_from_buffer):
8067 Don't arbitrarily truncate the value of 'selective' to int.
8068
76031fad
PE
8069 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8070
5eb55db9
PE
8071 * composite.c: Don't truncate sizes to 'int'.
8072 (composition_gstring_p, composition_reseat_it)
8073 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8074 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8075 not EMACS_UINT, for indexes.
5eb55db9 8076
0703a717
PE
8077 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8078
d6202519
PE
8079 * buffer.c: Include <verify.h>.
8080 (struct sortvec.priority, struct sortstr.priority):
8961a454 8081 Now EMACS_INT, not int.
c20998a7 8082 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8083 (struct sortstr.size, record_overlay_string)
8084 (struct sortstrlist.size, struct sortlist.used):
8085 Don't truncate size to int.
8086 (record_overlay_string): Check for size-calculation overflow.
d6202519 8087 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8088
d5a19415
JM
80892011-06-22 Jim Meyering <meyering@redhat.com>
8090
029529ac 8091 Don't leak an XBM-image-sized buffer
d5a19415
JM
8092 * image.c (xbm_load): Free the image buffer after using it.
8093
a9041e6c
PE
80942011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8095
8096 Port to Sun C.
8097 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8098 that Sun C diagnosed.
8099 * fns.c (secure_hash): Fix pointer signedness issue.
8100 * intervals.c (static_offset_intervals): New function.
8101 (offset_intervals): Use it.
8102
7f3f739f
LL
81032011-06-21 Leo Liu <sdl.web@gmail.com>
8104
8105 * deps.mk (fns.o):
8106 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8107 sha512.h.
8108
8109 * fns.c (secure_hash): Rename from crypto_hash_function and change
8110 the first arg to accept symbols.
5b66d427 8111 (Fsecure_hash): New primitive.
7f3f739f
LL
8112 (syms_of_fns): New symbols.
8113
76147d94
DD
81142011-06-20 Deniz Dogan <deniz@dogan.se>
8115
8116 * process.c (Fset_process_buffer): Clarify return value in
8117 docstring.
8118
7d7d0045
CY
81192011-06-18 Chong Yidong <cyd@stupidchicken.com>
8120
8121 * dispnew.c (add_window_display_history): Use BVAR.
8122
8123 * xdisp.c (debug_method_add): Use BVAR.
8124 (check_window_end, dump_glyph_matrix, dump_glyph)
8125 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8126
8127 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8128 Likewise.
8129
8130 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8131 check till after the cache is created in init_frame_faces.
8132
ff2bc410
SM
81332011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8134
8135 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8136
28177add
PE
81372011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8138
dd3482fe
PE
8139 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8140 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8141 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8142
393d71f3 8143 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8144 * fileio.c (Finsert_file_contents):
8145 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8146 Remove the old (too-loose) buffer overflow checks.
8147 They weren't needed, since make_gap checks for buffer overflow.
8148 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8149 The old code merely checked for Emacs fixnum overflow, and relied
8150 on undefined (wraparound) behavior. The new code avoids undefined
8151 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8152
2e6813b0 8153 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8154 Tune. Don't use wider integers than needed. Don't use alloca.
8155 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8156
599a9e4f
PE
8157 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8158
99561444
PE
8159 * insdel.c, lisp.h (buffer_overflow): New function.
8160 (insert_from_buffer_1, replace_range, replace_range_2):
8161 * insdel.c (make_gap_larger):
8162 * editfns.c (Finsert_char):
8163 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8164
28177add
PE
8165 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8166
e69dafad
PE
81672011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8168
4baa020d 8169 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8170
b1c46f02
PE
8171 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8172 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8173
e69dafad
PE
8174 * fileio.c: Don't assume EMACS_INT fits in off_t.
8175 (emacs_lseek): New static function.
8176 (Finsert_file_contents, Fwrite_region): Use it.
8177 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8178
566684ea
PE
8179 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8180
e6966cd6
PE
8181 * fns.c: Don't overflow int when computing a list length.
8182 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8183 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8184 truncation on 64-bit hosts. Check for QUIT every
8185 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8186 faster and is responsive enough.
8187 (Flength): Report an error instead of overflowing an integer.
8188 (Fsafe_length): Return a float if the value is not representable
8189 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8190 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8191 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8192
dd0b0efb
PE
8193 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8194 (header_size, word_size): New constants.
8195 (allocate_vectorlike): Don't check size overflow here.
8196 (allocate_vector): Check it here instead, since this is the only
8197 caller of allocate_vectorlike that could cause overflow.
8198 Check that the new vector's length is representable as a fixnum.
8199
86fe5cfe
PE
8200 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8201 The previous code was bogus. For example, next_almost_prime (32)
8202 returned 39, which is undesirable as it is a multiple of 3; and
8203 next_almost_prime (24) returned 25, which is a multiple of 5 so
8204 why was the code bothering to check for multiples of 7?
8205
80e88859
PE
8206 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8207
4a2f0ad6
PE
8208 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8209
f66c7cf8
PE
8210 Variadic C functions now count arguments with ptrdiff_t.
8211 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8212 Back then I didn't know that the Emacs coding style prefers signed int.
8213 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8214 were being counted with int, which may truncate counts on 64-bit
8215 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8216 * lisp.h (struct Lisp_Subr.function.aMANY)
8217 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8218 Arg counts are now ptrdiff_t, not size_t.
8219 All variadic functions and their callers changed accordingly.
8220 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8221 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8222 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8223 * callint.c (Fcall_interactively): Check arg count for overflow,
8224 to avoid potential buffer overrun. Use signed char, not 'int',
8225 for 'varies' array, so that we needn't bother to check its size
8226 calculation for overflow.
8227 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8228 * eval.c (apply_lambda):
8229 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8230 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8231 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8232
a1759b76
PE
8233 * callint.c (Fcall_interactively): Don't use index var as event count.
8234
d96be9fc
PE
8235 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8236 * mem-limits.h (SIZE): Remove; no longer used.
8237
a690a978 8238 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8239
578c21e6
PE
8240 Remove unnecessary casts.
8241 * xterm.c (x_term_init):
8242 * xfns.c (x_set_border_pixel):
8243 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8244 These aren't needed now that we assume ANSI C.
8245
96f53c6c
PE
8246 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8247 It's more likely to cause problems (due to unsigned overflow)
8248 than to cure them.
8249
83c77d31
PE
8250 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8251
ee2079f1
PE
8252 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8253
6da65536
PE
8254 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8255
7147c4a4
PE
8256 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8257
193e32d9
PE
8258 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8259
e5533da6
PE
8260 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8261
9910e595
PE
8262 GLYPH_CODE_FACE returns EMACS_INT, not int.
8263 * dispextern.h (merge_faces):
8264 * xfaces.c (merge_faces):
01103c44
PE
8265 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8266 Don't assume EMACS_INT fits in int.
9910e595 8267
2638320e
PE
8268 * character.h (CHAR_VALID_P): Remove unused parameter.
8269 * fontset.c, lisp.h, xdisp.c: All uses changed.
8270
045eb8d9
PE
8271 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8272
c1f134b5
PE
8273 * fns.c (concat): Minor tuning based on overflow analysis.
8274 This doesn't fix any bugs. Use int to hold character, instead
8275 of constantly refetching from Emacs object. Use XFASTINT, not
8276 XINT, for value known to be a character. Don't bother comparing
8277 a single byte to 0400, as it's always less.
8278
395fcb93 8279 * floatfns.c (Fexpt):
327eeec8
PE
8280 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8281
abbd3d23
PE
8282 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8283 for characters.
8284
684a03ef
PE
8285 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8286
0fed43f3
PE
8287 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8288 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8289 incorrectly succeed when S was a string, because 4294967386 was
8290 truncated before it was used.
8291
8fd02eb7
PE
8292 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8293 Otherwise, an out-of-range integer could cause undefined behavior
8294 on a 64-bit host.
8295
f8c86b69
PE
8296 * composite.c: Use int, not EMACS_INT, for characters.
8297 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8298 EMACS_INT, for values that are known to be in character range.
8299 This doesn't fix any bugs but is the usual style inside Emacs and
8300 may generate better code on 32-bit machines.
8301
34206dd2
PE
8302 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8303 This is for reasons similar to the recent CHAR_STRING fix.
8304 * charset.c (Fencode_char): Check that character arg is actually
8305 a character. Pass an int to ENCODE_CHAR.
8306 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8307 wider than 'int', as a compile-time check to prevent future regressions
8308 in this area.
8309
c5958d4c 8310 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8311
8312 Make sure a 64-bit char is never passed to CHAR_STRING.
8313 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8314 by silently ignoring the top 32 bits, allowing some values
8315 that were far too large to be valid characters.
8316 * character.h: Include <verify.h>.
8317 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8318 arguments are no wider than unsigned, as a compile-time check
8319 to prevent future regressions in this area.
8320 * data.c (Faset):
01103c44 8321 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8322 (Fsubst_char_in_region):
8323 * fns.c (concat):
8324 * xdisp.c (decode_mode_spec_coding):
8325 Adjust to CHAR_STRING's new requirement.
8326 * editfns.c (Finsert_char, Fsubst_char_in_region):
8327 * fns.c (concat): Check that character args are actually
8328 characters. Without this test, these functions did the wrong
8329 thing with wildly out-of-range values on 64-bit hosts.
8330
d37ca623
PE
8331 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8332 These casts should not be needed on 32-bit hosts, either.
8333 * keyboard.c (read_char):
8334 * lread.c (Fload): Remove casts to unsigned.
8335
ea204efb
PE
8336 * lisp.h (UNSIGNED_CMP): New macro.
8337 This fixes comparison bugs on 64-bit hosts.
8338 (ASCII_CHAR_P): Use it.
8339 * casefiddle.c (casify_object):
01103c44 8340 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8341 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8342 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8343 * dispextern.h (FACE_FROM_ID):
8344 * keyboard.c (read_char): Use UNSIGNED_CMP.
8345
41cb286c
PE
8346 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8347 not to EMACS_INT, to avoid GCC warning.
8348
4a1b9832
PE
8349 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8350
55daad71
PE
8351 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8352 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8353 isn't needed on 32-bit machines.
8f95c75c 8354
01103c44
PE
8355 * buffer.c (Fgenerate_new_buffer_name):
8356 Use EMACS_INT for count, not int.
0ceccced 8357 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8358
8359 * data.c (Qcompiled_function): Now static.
8360
c6f072e7
PE
8361 * window.c (window_body_lines): Now static.
8362
20ce5912
PE
8363 * image.c (gif_load): Rename local to avoid shadowing.
8364
9c4c5f81
PE
8365 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8366 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8367 * alloc.c (make_save_value): Integer argument is now of type
8368 ptrdiff_t, not int.
8369 (mark_object): Use ptrdiff_t, not int.
8370 * lisp.h (pD): New macro.
8371 * print.c (print_object): Use it.
8372
c0c5c8ae
PE
8373 * alloc.c: Use EMACS_INT, not int, to count objects.
8374 (total_conses, total_markers, total_symbols, total_vector_size)
8375 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8376 (total_free_floats, total_floats, total_free_intervals)
8377 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8378 Now EMACS_INT, not int. All uses changed.
8379 (Fgarbage_collect): Compute overall total using a double, so that
8380 integer overflow is less likely to be a problem. Check for overflow
8381 when converting back to an integer.
5a25e253
PE
8382 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8383 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8384 These were 'int' variables that could overflow on 64-bit hosts;
8385 they were never used, so remove them instead of repairing them.
211a0b2a 8386 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8387 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8388 Previously, this ceilinged at INT_MAX, but that doesn't work on
8389 64-bit machines.
e46bb31a 8390 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8391
c78baabf 8392 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8393 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8394 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8395 when a (possibly-narrower) signed value would do just as well.
8396 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8397
c9d624c6
PE
8398 * alloc.c: Catch some string size overflows that we were missing.
8399 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8400 for convenience in STRING_BYTES_MAX.
8401 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8402 The definition here is exact; the one in lisp.h was approximate.
8403 (allocate_string_data): Check for string overflow. This catches
8404 some instances we weren't catching before. Also, it catches
8405 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8406 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8407 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8408
c9d624c6
PE
8409 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8410 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8411 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8412
353032ce
PE
8413 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8414
2bccce07
PE
8415 * alloc.c (Fmake_string): Check for out-of-range init.
8416
0ac30604
SM
84172011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8418
8419 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8420
c195f2de
JD
84212011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8422
8423 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8424 xg_get_default_scrollbar_width.
8425
8426 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8427 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8428 (style_changed_cb): Call update_theme_scrollbar_width and call
8429 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8430 all frames (Bug#8505).
8431 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8432 Call gtk_window_set_resizable if HAVE_GTK3.
8433 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8434 and height if HAVE_GTK3 (Bug#8505).
8435 (scroll_bar_width_for_theme): New variable.
8436 (update_theme_scrollbar_width): New function.
8437 (xg_get_default_scrollbar_width): Move code to
8438 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8439 (xg_initialize): Call update_theme_scrollbar_width.
8440
8441 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8442
8443 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8444
e10ac9f1
MR
84452011-06-12 Martin Rudalics <rudalics@gmx.at>
8446
8447 * frame.c (make_frame): Call other_buffer_safely instead of
8448 other_buffer.
8449
8450 * window.c (temp_output_buffer_show): Call display_buffer with
8451 second argument Vtemp_buffer_show_specifiers and reset latter
8452 immediately after the call.
8453 (Vtemp_buffer_show_specifiers): New variable.
8454 (auto_window_vscroll_p, next_screen_context_lines)
8455 (Vscroll_preserve_screen_position): Remove leading asterisks from
8456 doc-strings.
8457
2d3c217e 84582011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8459
7b7f97e8 8460 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8461 * buffer.c (Qclone_number): Remove for now, as it's unused.
8462 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8463 (record_buffer): Remove unused local.
8464 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8465 (set_frame_buffer_list): Remove; unused.
8466 * frame.h (other_visible_frames): Remove decl.
8467 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8468 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8469 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8470 if HAVE_GPM.
8471 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8472 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8473 Define only if HAVE_GPM.
8474 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8475 (update_hints_inhibit): Remove; never set. All uses removed.
8476 * widgetprv.h (emacsFrameClassRec): Remove decl.
8477 * window.c (delete_deletable_window): Now returns void, since it
8478 wasn't returning anything.
8479 (compare_window_configurations): Remove unused locals.
8480 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8481 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8482 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8483 the same widths as pointers. This follows up on the 2011-05-06 patch.
8484 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8485 * xterm.h: Likewise.
8486 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8487
1384b89e
JB
84882011-06-12 Juanma Barranquero <lekktu@gmail.com>
8489
8490 * makefile.w32-in: Update dependencies.
8491 (LISP_H): Add lib/intprops.h.
8492
1100a63c
CY
84932011-06-11 Chong Yidong <cyd@stupidchicken.com>
8494
8495 * image.c (gif_load): Add animation frame delay to the metadata.
8496 (syms_of_image): Use DEFSYM. New symbol `delay'.
8497
6198ccd0
MR
84982011-06-11 Martin Rudalics <rudalics@gmx.at>
8499
8500 * window.c (delete_deletable_window): Re-add.
8501 (Fset_window_configuration): Rewrite to handle dead buffers and
8502 consequently deletable windows.
8503 (window_tree, Fwindow_tree): Remove. Supply functionality in
8504 window.el.
8505 (compare_window_configurations): Simplify code.
8506
b6e3633c
AS
85072011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8508
1ab0dee5
AS
8509 * image.c (imagemagick_load_image): Fix type mismatch.
8510 (Fimagemagick_types): Likewise.
8511
b6e3633c
AS
8512 * window.h (replace_buffer_in_windows): Declare.
8513
9397e56f
MR
85142011-06-11 Martin Rudalics <rudalics@gmx.at>
8515
8516 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8517 Qclone_number. Remove external declaration of Qdelete_window.
8518 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8519 code.
640c8776
SM
8520 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8521 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8522 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8523 buffer list implementation.
8524 (other_buffer_safely): New function.
8525 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8526 calls to replace_buffer_in_windows and
8527 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8528 if allowed.
8529 (record_buffer): Inhibit quitting and rewrite using quittable
8530 functions. Run Qbuffer_list_update_hook if allowed.
8531 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8532 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8533 Move switch-to-buffer to window.el.
9397e56f
MR
8534 (bury-buffer): Move to window.el.
8535 (Vbuffer_list_update_hook): New variable.
8536
8537 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8538 section.
8539
8540 * window.h (resize_frame_windows): Move up in code.
8541 (Fwindow_frame): Remove EXFUN.
8542 (replace_buffer_in_all_windows): Remove prototype.
8543 (replace_buffer_in_windows_safely): Add prototype.
8544
8545 * window.c: Declare Qdelete_window static again. Move down
8546 declaration of select_count.
8547 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8548 (Fother_window): Move to window.el.
8549 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8550 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8551 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8552 window.el.
8553 (replace_buffer_in_windows): Implement by calling
8554 Qreplace_buffer_in_windows.
8555 (replace_buffer_in_all_windows): Remove with some functionality
8556 moved into replace_buffer_in_windows_safely.
8557 (replace_buffer_in_windows_safely): New function.
8558 (select_window_norecord, select_frame_norecord): Move in front
8559 of run_window_configuration_change_hook. Remove now obsolete
8560 declarations.
640c8776
SM
8561 (Fset_window_buffer): Rewrite doc-string.
8562 Call Qrecord_window_buffer.
9397e56f
MR
8563 (keys_of_window): Move binding for other-window to window.el.
8564
b50691aa
CY
85652011-06-11 Chong Yidong <cyd@stupidchicken.com>
8566
8567 * dispextern.h (struct image): Replace data member, whose int_val
8568 and ptr_val fields were not used by anything, with a single
8569 lisp_val object.
8570
8571 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8572 (gif_clear_image, gif_load, imagemagick_load_image)
8573 (gs_clear_image, gs_load): Callers changed.
8574
3f754b86
PE
85752011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8576
cca69397
PE
8577 * buffer.h: Include <time.h>, for time_t.
8578 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8579
109e28d0
PE
8580 Fix minor problems found by static checking.
8581
60737f02
PE
8582 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8583
4b66faf3
PE
8584 Make identifiers static if they are not used in other modules.
8585 * data.c (Qcompiled_function, Qframe, Qvector):
8586 * image.c (QimageMagick, Qsvg):
8587 * minibuf.c (Qmetadata):
8588 * window.c (resize_window_check, resize_root_window): Now static.
8589 * window.h (resize_window_check, resize_root_window): Remove decls.
8590
109e28d0
PE
8591 * window.c (window_deletion_count, delete_deletable_window):
8592 Remove; unused.
46a4ce9e
PE
8593 (window_body_lines): Now static.
8594 (Fdelete_other_windows_internal): Mark vars as initialized.
8595 Make sure 'resize_failed' is initialized.
8596 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8597 (resize_window_apply): Remove unused local.
8598 * window.h (delete_deletable_window): Remove decl.
8599
109e28d0 8600 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8601 (imagemagick_load_image): Fix pointer signedness problem by changing
8602 last arg from unsigned char * to char *. All uses changed.
8603 Also, fix a local for similar reasons.
8604 Remove unused locals. Remove locals to avoid shadowing.
8605 (fn_rsvg_handle_free): Remove; unused.
8606 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8607 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8608
3f754b86
PE
8609 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8610
2547adb1
CY
86112011-06-10 Chong Yidong <cyd@stupidchicken.com>
8612
8613 * image.c (gif_load): Fix omitted cast error introduced by
8614 2011-06-06 change.
8615
2c8e37d4
MR
86162011-06-10 Martin Rudalics <rudalics@gmx.at>
8617
8618 * window.h (resize_proportionally, orig_total_lines)
8619 (orig_top_line): Remove from window structure.
8620 (set_window_height, set_window_width, change_window_heights)
8621 (Fdelete_window): Remove prototypes.
8622 (resize_frame_windows): Remove duplicate declaration.
8623
440a42e3
EZ
86242011-06-10 Eli Zaretskii <eliz@gnu.org>
8625
8626 * window.h (resize_frame_windows, resize_window_check)
8627 (delete_deletable_window, resize_root_window)
8628 (resize_frame_windows): Declare prototypes.
8629
8630 * window.c (resize_window_apply): Make definition be "static" to
8631 match the prototype.
8632
562dd5e9
MR
86332011-06-10 Martin Rudalics <rudalics@gmx.at>
8634
8635 * window.c: Remove declarations of Qwindow_size_fixed,
8636 window_min_size_1, window_min_size_2, window_min_size,
8637 size_window, window_fixed_size_p, enlarge_window, delete_window.
8638 Remove static from declaration of Qdelete_window, it's
8639 temporarily needed by Fbury_buffer.
8640 (replace_window): Don't assign orig_top_line and
8641 orig_total_lines.
8642 (Fdelete_window, delete_window): Remove. Window deletion is
8643 handled by window.el.
640c8776
SM
8644 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8645 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8646 (Fdelete_other_windows): Remove. Deleting other windows is
8647 handled by window.el.
8648 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8649 handled in window.el.
8650 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8651 Window minimum sizes are handled in window.el.
8652 (shrink_windows, size_window, set_window_height)
8653 (set_window_width, change_window_heights, window_height)
8654 (window_width, CURBEG, CURSIZE, enlarge_window)
8655 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8656 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8657 handled in window.el.
8658 (make_dummy_parent): Rename to make_parent_window and give it a
8659 second argument horflag.
8660 (make_window): Don't set resize_proportionally any more.
8661 (Fsplit_window): Remove. Windows are split in window.el.
8662 (save_restore_action, save_restore_orig_size)
8663 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8664 Resize mini windows in window.el.
8665 (grow_mini_window, shrink_mini_window): Implement by calling
8666 Qresize_root_window_vertically, resize_window_check and
8667 resize_window_apply.
640c8776
SM
8668 (saved_window, Fset_window_configuration, save_window_save):
8669 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8670 resize_proportionally.
8671 (window_min_height, window_min_width): Move to window.el.
8672 (keys_of_window): Move bindings for delete-other-windows,
8673 split-window, delete-window and enlarge-window to window.el.
8674
8675 * buffer.c: Temporarily extern Qdelete_window.
8676 (Fbury_buffer): Temporarily call Qdelete_window instead of
8677 Fdelete_window (Fbury_buffer will move to window.el soon).
8678
8679 * frame.c (set_menu_bar_lines_1): Remove code handling
8680 orig_top_line and orig_total_lines.
8681
8682 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8683 set_window_height but set heights directly.
8684 (change_frame_size_1): Use resize_frame_windows.
8685
8686 * xdisp.c (init_xdisp): Don't use set_window_height but set
8687 heights directly.
8688
640c8776
SM
8689 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8690 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8691 run_window_configuration_change_hook.
8692
8693 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8694 instead of change_window_heights and run
8695 run_window_configuration_change_hook.
8696
1a13852e
MR
86972011-06-09 Martin Rudalics <rudalics@gmx.at>
8698
8699 * window.c (replace_window): Rename second argument REPLACEMENT to
8700 NEW. New third argument SETFLAG. Rewrite.
8701 (delete_window, make_dummy_parent): Call replace_window with
8702 third argument 1.
8703 (window_list_1): Move down in code.
8704 (run_window_configuration_change_hook): Move set_buffer part
8705 before select_frame_norecord part in order to unwind correctly.
8706 Rename count1 to count.
8707 (recombine_windows, delete_deletable_window, resize_root_window)
8708 (Fdelete_other_windows_internal)
8709 (Frun_window_configuration_change_hook, make_parent_window)
8710 (resize_window_check, resize_window_apply, Fresize_window_apply)
8711 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8712 (Fdelete_window_internal, Fresize_mini_window_internal):
8713 New functions.
1a13852e
MR
8714 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8715
f3d1777e
MR
87162011-06-08 Martin Rudalics <rudalics@gmx.at>
8717
496e208e
MR
8718 * window.h (window): Add some new members to window structure -
8719 normal_lines, normal_cols, new_total, new_normal, clone_number,
8720 splits, nest, prev_buffers, next_buffers.
8721 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8722 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8723
f3d1777e
MR
8724 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8725 Remove.
496e208e
MR
8726 (make_dummy_parent): Set new members of windows structure.
8727 (make_window): Move down in code. Handle new members of window
8728 structure.
8729 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8730 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8731 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8732 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8733 (Fset_window_next_buffers, Fset_window_clone_number):
8734 New functions.
496e208e
MR
8735 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8736 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8737 Doc-string fixes.
8738 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8739 Argument WINDOW can be now internal window too.
8740 (Fwindow_use_time): Move up in code.
8741 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8742 Rewrite doc-string.
8743 (Fset_window_configuration, saved_window)
8744 (Fcurrent_window_configuration, save_window_save): Handle new
8745 members of window structure.
b9e809c2
MR
8746 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8747 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8748 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8749 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8750 Qget_mru_window, Qresize_root_window,
8751 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8752 Qauto_buffer_name; staticpro them.
f3d1777e 8753
abde8f8c
MR
87542011-06-07 Martin Rudalics <rudalics@gmx.at>
8755
8756 * window.c (Fwindow_total_size, Fwindow_left_column)
8757 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8758 (Fwindow_list_1): New functions.
8759 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8760 (Fwindow_width, Fscroll_left, Fscroll_right):
8761 Use window_body_cols instead of window_box_text_cols.
8762 (delete_window, Fset_window_configuration):
8763 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8764 (delete_all_subwindows): Take a window as argument and not a
8765 structure. Rewrite.
190b47e6
MR
8766 (window_loop): Remove handling of GET_LRU_WINDOW and
8767 GET_LARGEST_WINDOW.
8768 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8769
8770 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8771 window_box_text_cols. delete_all_subwindows now takes a
8772 Lisp_Object as argument.
abde8f8c 8773
640c8776
SM
8774 * indent.c (compute_motion, Fcompute_motion):
8775 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8776
fa8a67e6
MR
8777 * frame.c (delete_frame): Call delete_all_subwindows with root
8778 window as argument.
8779
a54e3482
DC
87802011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8781
8782 * fns.c (Fputhash): Document return value.
8783
60002bf5
CY
87842011-06-06 Chong Yidong <cyd@stupidchicken.com>
8785
8786 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8787
0c671da6 87882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8789
b862a52a 8790 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8791
be44ca6c
PE
8792 Check for overflow when converting integer to cons and back.
8793 * charset.c (Fdefine_charset_internal, Fdecode_char):
8794 Use cons_to_unsigned to catch overflow.
8795 (Fencode_char): Use INTEGER_TO_CONS.
8796 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8797 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8798 * data.c (long_to_cons, cons_to_long): Remove.
8799 (cons_to_unsigned, cons_to_signed): New functions.
8800 These signal an error for invalid or out-of-range values.
8801 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8802 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8803 * font.c (Ffont_variation_glyphs):
8804 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8805 * lisp.h: Include <intprops.h>.
8806 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8807 (cons_to_signed, cons_to_unsigned): New decls.
8808 (long_to_cons, cons_to_long): Remove decls.
8809 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8810 (Fprimitive_undo): Use CONS_TO_INTEGER.
8811 * xfns.c (Fx_window_property): Likewise.
8812 * xselect.c: Include <limits.h>.
8813 (x_own_selection, selection_data_to_lisp_data):
8814 Use INTEGER_TO_CONS.
8815 (x_handle_selection_request, x_handle_selection_clear)
8816 (x_get_foreign_selection, Fx_disown_selection_internal)
8817 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8818 (lisp_data_to_selection_data): Use cons_to_unsigned.
8819 (x_fill_property_data): Use cons_to_signed.
8820 Report values out of range.
8821
d1f3d2af
PE
8822 Check for buffer and string overflow more precisely.
8823 * buffer.h (BUF_BYTES_MAX): New macro.
8824 * lisp.h (STRING_BYTES_MAX): New macro.
8825 * alloc.c (Fmake_string):
8826 * character.c (string_escape_byte8):
8827 * coding.c (coding_alloc_by_realloc):
8828 * doprnt.c (doprnt):
8829 * editfns.c (Fformat):
8830 * eval.c (verror):
8831 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8832 since they may not be the same number.
8833 * editfns.c (Finsert_char):
8834 * fileio.c (Finsert_file_contents):
8835 Likewise for BUF_BYTES_MAX.
8836
dd52fcea
PE
8837 * image.c: Use ptrdiff_t, not int, for sizes.
8838 (slurp_file): Switch from int to ptrdiff_t.
8839 All uses changed.
8840 (slurp_file): Check that file size fits in both size_t (for
8841 malloc) and ptrdiff_t (for sanity and safety).
8842
7f9bbdbb
PE
8843 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8844 if b->modtime has its maximal value.
8845
dfe18f82
PE
8846 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8847
84acfcf0
PE
8848 Don't assume time_t can fit into int.
8849 * buffer.h (struct buffer.modtime): Now time_t, not int.
8850 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8851 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8852
ccd9a01a
PE
8853 Minor fixes for signed vs unsigned integers.
8854 * character.h (MAYBE_UNIFY_CHAR):
8855 * charset.c (maybe_unify_char):
8856 * keyboard.c (read_char, reorder_modifiers):
8857 XINT -> XFASTINT, since the integer must be nonnegative.
8858 * ftfont.c (ftfont_spec_pattern):
8859 * keymap.c (access_keymap, silly_event_symbol_error):
8860 XUINT -> XFASTINT, since the integer must be nonnegative.
8861 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8862 since it makes no difference and we prefer signed.
8863 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8864 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8865 nonnegative.
8866
d6d100dd
SM
88672011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8868
8869 * window.h (Fwindow_frame): Declare.
8870
2b6148e4
PE
88712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8872
8873 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8874 (SPARE_MEMORY): Always define.
8875 (LARGE_REQUEST): Remove.
8876 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8877
f230ecc9
MR
88782011-06-06 Martin Rudalics <rudalics@gmx.at>
8879
727e958e
MR
8880 * lisp.h: Move EXFUNS for Fframe_root_window,
8881 Fframe_first_window and Fset_frame_selected_window to window.h.
8882
8883 * window.h: Move EXFUNS for Fframe_root_window,
8884 Fframe_first_window and Fset_frame_selected_window here from
8885 lisp.h.
8886
8887 * frame.c (Fwindow_frame, Fframe_first_window)
8888 (Fframe_root_window, Fframe_selected_window)
8889 (Fset_frame_selected_window): Move to window.c.
8890 (Factive_minibuffer_window): Move to minibuf.c.
8891 (Fother_visible_frames_p): New function.
8892
8893 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8894
f230ecc9
MR
8895 * window.c (decode_window, decode_any_window): Move up in code.
8896 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8897 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8898 (Fwindow_buffer): Move up and rewrite doc-string.
8899 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8900 (Fwindow_prev): New functions.
727e958e
MR
8901 (Fwindow_frame): Move here from frame.c. Accept any window as
8902 argument.
8903 (Fframe_root_window, Fframe_first_window)
8904 (Fframe_selected_window): Move here from frame.c. Accept frame
8905 or arbitrary window as argument. Update doc-strings.
8906 (Fminibuffer_window): Move up in code.
8907 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8908 (Fset_frame_selected_window): Move here from frame.c.
8909 Marginal rewrite.
727e958e
MR
8910 (Fselected_window, select_window, Fselect_window): Move up in
8911 code. Minor doc-string fixes.
f230ecc9 8912
4d09bcf6
PE
89132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8914
8915 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8916 Do not assume that spare memory exists; that assumption is valid
8917 only if SYSTEM_MALLOC.
8918 (LARGE_REQUEST): New macro, so that the issue of large requests
8919 is separated from the issue of spare memory.
8920
810928a2
AS
89212011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8922
172418ad
AS
8923 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8924 format. (Bug#8806)
8925
43f862f7
AS
8926 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8927
810928a2
AS
8928 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8929 before statements.
8930
a059fe24
JD
89312011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8932
8933 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8934
8935 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8936
8937 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8938 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8939
989bf368
JB
89402011-06-05 Juanma Barranquero <lekktu@gmail.com>
8941
8942 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8943
4b80f674
CY
89442011-06-04 Chong Yidong <cyd@stupidchicken.com>
8945
8946 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8947 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8948 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8949 New error handlers.
4b80f674
CY
8950 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8951 Obey Vx_select_enable_clipboard_manager. Catch errors in
8952 x_clipboard_manager_save (Bug#8779).
8953 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8954 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8955
99a33b77 89562011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8957
8958 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8959
99a33b77 89602011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8961
8962 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8963 in the current matrix if keep_current_p is non-zero.
8964
8264569d
EZ
89652011-06-04 Eli Zaretskii <eliz@gnu.org>
8966
8967 * bidi.c (bidi_level_of_next_char): Fix last change.
8968
57f97249
EZ
89692011-06-03 Eli Zaretskii <eliz@gnu.org>
8970
fec2107c 8971 Support bidi reordering of text covered by display properties.
57f97249 8972
fec2107c
EZ
8973 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8974 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8975 (bidi_cache_search, bidi_cache_iterator_state)
8976 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8977 (bidi_level_of_next_char, bidi_move_to_visually_next):
8978 Support character positions inside a run of characters covered by a
fec2107c
EZ
8979 display string.
8980 (bidi_paragraph_init, bidi_resolve_explicit_1)
8981 (bidi_level_of_next_char): Call bidi_fetch_char and
8982 bidi_fetch_char_advance instead of FETCH_CHAR and
8983 FETCH_CHAR_ADVANCE.
8984 (bidi_init_it): Initialize new members.
8985 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8986 definitions.
8987 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8988 instead of using explicit *_CHAR codes.
d6d100dd
SM
8989 (bidi_resolve_explicit, bidi_resolve_weak):
8990 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8991 bidirectional text is supported only in multibyte buffers.
8992 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8993 it to initialize the frame_window_p member of struct bidi_it.
8994 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8995 (bidi_resolve_explicit, bidi_resolve_weak)
8996 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8997 bidi_it->nchars is non-positive.
8998 (bidi_level_of_next_char): Don't try to lookup the cache for the
8999 next/previous character if nothing is cached there yet, or if we
9000 were just reseat()'ed to a new position.
c40e2fb2 9001
0e14fe90
EZ
9002 * xdisp.c (set_cursor_from_row): Set start and stop points
9003 according to the row's direction when priming the loop that looks
9004 for the glyph on which to display cursor.
9005 (single_display_spec_intangible_p): Function deleted.
9006 (display_prop_intangible_p): Reimplement to call
9007 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9008 Accept 3 additional arguments needed by handle_display_spec.
9009 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9010 values: lists, `(when COND...)' forms, etc.
9011 (single_display_spec_string_p): Support property values that are
9012 lists with the argument STRING its top-level element.
9013 (display_prop_string_p): Fix the condition for processing a
9014 property that is a list to be consistent with handle_display_spec.
fec2107c 9015 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9016 last portion of handle_display_prop.
9017 (compute_display_string_pos): Accept additional argument
9018 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9019 value of a `display' property is a "replacing spec".
9020 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9021 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9022 the display property, but just return a value indicating whether
9023 the display property will replace the characters it covers.
9024 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9025 frame_window_p members of struct bidi_it.
d6d100dd
SM
9026 (compute_display_string_pos, compute_display_string_end):
9027 New functions.
fec2107c
EZ
9028 (push_it): Accept second argument POSITION, where pop_it should
9029 jump to continue iteration.
9030 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9031
fec2107c
EZ
9032 * keyboard.c (adjust_point_for_property): Adjust the call to
9033 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9034
9035 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9036 (bidi_init_it): Update prototypes.
9037 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9038 (compute_display_string_pos, compute_display_string_end):
9039 Declare prototypes.
fec2107c
EZ
9040 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9041 EMACS_INT.
fc6f18ce 9042
40087514 90432011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9044
57f53182
PE
9045 Malloc failure behavior now depends on size of allocation.
9046 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9047 * lisp.h: Change signatures accordingly.
9048 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9049 All callers changed. (Bug#8762)
9050
9051 * gnutls.c: Use Emacs's memory allocators.
9052 Without this change, the gnutls library would invoke malloc etc.
9053 directly, which causes problems on non-SYNC_INPUT hosts, and which
9054 runs afoul of improving memory_full behavior. (Bug#8761)
9055 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9056 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9057 xfree instead of the default malloc, realloc, free.
9058 (Fgnutls_boot): No need to check for memory allocation failure,
9059 since xmalloc does that for us.
9060
ac32cd99 9061 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9062 * category.c (hash_get_category_set):
9063 * ccl.c (ccl_driver):
9064 * charset.c (Fdefine_charset_internal):
9065 * charset.h (struct charset.hash_index):
9066 * composite.c (get_composition_id, gstring_lookup_cache)
9067 (composition_gstring_put_cache):
9068 * composite.h (struct composition.hash_index):
9069 * dispextern.h (struct image.hash):
9070 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9071 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9072 (hashfn_equal, hashfn_user_defined, make_hash_table)
9073 (maybe_resize_hash_table, hash_lookup, hash_put)
9074 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9075 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9076 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9077 * image.c (make_image, search_image_cache, lookup_image)
9078 (xpm_put_color_table_h):
9079 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9080 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9081 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9082 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9083 * alloc.c (allocate_vectorlike):
9084 Check for overflow in vector size calculations.
9085 * ccl.c (ccl_driver):
9086 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9087 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9088 need to be updated by these changes.
40087514
PE
9089 * fns.c (make_hash_table, maybe_resize_hash_table):
9090 Check for integer overflow with large hash tables.
0de4bb68
PE
9091 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9092 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9093 (SXHASH_REDUCE): New macro.
9094 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9095 Use it instead of discarding useful hash info with large hash values.
9096 (sxhash_float): New function.
9097 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9098 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9099 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9100 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9101 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9102 Adjust signatures to match updated version of code.
9103 (consing_since_gc): Now EMACS_INT, since a single hash table can
9104 use more than INT_MAX bytes.
9105
698d32e2
DN
91062011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9107
9108 Make it possible to build with GCC-4.6+ -O2 -flto.
9109
9110 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9111
fd6fa53f
SM
91122011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9113
9114 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9115 Call minibuffer-inactive-mode.
9116
864db017
JB
91172011-05-31 Juanma Barranquero <lekktu@gmail.com>
9118
9119 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9120 Update dependencies.
9121
2ad0baf4
DN
91222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9123
9124 * data.c (init_data): Remove code for UTS, this system is not
9125 supported anymore.
9126
4fcc2638
DN
91272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9128
9129 Don't force ./temacs to start in terminal mode.
9130
9131 * frame.c (make_initial_frame): Initialize faces in all cases, not
9132 only when CANNOT_DUMP is defined.
9133 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9134
c56e0fd5
DN
91352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9136
9137 * dispnew.c (add_window_display_history): Use const for the string
9138 pointer. Remove declaration, not needed.
9139
333d54da 91402011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9141
55d4c1b2 9142 Use 'inline', not 'INLINE'.
333d54da 9143 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9144 * alloc.c, fontset.c (INLINE): Remove.
9145 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9146 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9147 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9148 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9149 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9150
738db178
DN
91512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9152
9153 Make it possible to run ./temacs.
9154
9155 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9156 syms_of_callproc does the same thing. Remove test for
9157 "initialized", do it in the caller.
9158 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9159
620c53a6
SM
91602011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9161
9162 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9163 (read_minibuf): Use get_minibuffer.
9164 (syms_of_minibuf): Use DEFSYM.
9165 (Qmetadata): New var.
9166 * data.c (Qbuffer): Don't make it static.
9167 (syms_of_data): Use DEFSYM.
9168
e003a292
PE
91692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9170
9171 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9172 (CCL_CODE_MIN): New macro.
9173
ed008a6d
PE
91742011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9175
3687c2ef
PE
9176 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9177
ed008a6d
PE
9178 * eval.c (Qdebug): Now static.
9179 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9180 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9181 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9182
d66c4c7c
CY
91832011-05-29 Chong Yidong <cyd@stupidchicken.com>
9184
9185 * image.c: Various fixes to ImageMagick code comments.
9186 (Fimagemagick_types): Doc fix.
9187
5fbc2025
PE
91882011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9189
0196f88a
PE
9190 Minor fixes prompted by GCC 4.6.0 warnings.
9191
9192 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9193
5fbc2025
PE
9194 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9195 (x_clipboard_manager_save_all): Move extern decl to ...
9196 * xterm.h: ... here, so that it can be checked for consistency.
9197
1dd3c2d9
CY
91982011-05-29 Chong Yidong <cyd@stupidchicken.com>
9199
9200 * xselect.c (x_clipboard_manager_save_frame)
9201 (x_clipboard_manager_save_all): New functions.
9202 (Fx_clipboard_manager_save): Lisp function deleted.
9203
9204 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9205 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9206
9207 * xterm.h: Update prototype.
9208
5ba6571d
WX
92092011-05-28 William Xu <william.xwl@gmail.com>
9210
9211 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9212 exiting (Bug#8239).
9213
3eaff834
JM
92142011-05-28 Jim Meyering <meyering@redhat.com>
9215
e1900994 9216 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9217 * fns.c (to_uchar): Define.
9218 (crypto_hash_function): Use it to convert some newly-signed
9219 variables to unsigned, to avoid sign-extension bugs. For example,
9220 without this change, (md5 "truc") would evaluate to
9221 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9222 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9223 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9224
0f6990a7
PE
92252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9226
9227 Integer overflow fixes.
c8a9ca5a 9228
08686060
PE
9229 * dbusbind.c: Serial number integer overflow fixes.
9230 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9231 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9232 to hold a serial number that is too large for a fixnum.
9233 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9234 Check for serial numbers out of range. Decode any serial number
59568bf0 9235 that was so large that it became a float. (Bug#8722)
08686060 9236
2d1fc3c7
PE
9237 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9238 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9239 Use XFASTINT rather than XUINT when numbers are nonnegative.
9240 (xd_append_arg, Fdbus_method_return_internal):
9241 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9242 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9243 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9244 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9245 (Bug#8722)
2d1fc3c7 9246
c8a9ca5a
PE
9247 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9248
519e1d69
PE
9249 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9250
6df6ae42 9251 ccl: Add integer overflow checks.
30569699
PE
9252 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9253 (IN_INT_RANGE): New macros.
9254 (ccl_driver): Use them to check for integer overflow when
9255 decoding a CCL program. Many of the new checks are whether XINT (x)
9256 fits in int; it doesn't always, on 64-bit hosts. The new version
9257 doesn't catch all possible integer overflows, but it's an
847044ea 9258 improvement. (Bug#8719)
30569699 9259
c11285dc
PE
9260 * alloc.c (make_event_array): Use XINT, not XUINT.
9261 There's no need for unsigned here.
9262
fdccd48e
PE
9263 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9264 This follows up to the 2011-05-06 change that substituted uintptr_t
9265 for EMACS_INT. This case wasn't caught back then.
9266
37910ab2
PE
9267 Rework Fformat to avoid integer overflow issues.
9268 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9269 now (part of C89). Include <verify.h>.
9270 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9271 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9272 (Fformat): Avoid the prepass trying to compute sizes; it was only
9273 approximate and thus did not catch overflow reliably. Instead, walk
9274 through the format just once, formatting and computing sizes as we go,
9275 checking for integer overflow at every step, and allocating a larger
9276 buffer as needed. Keep track separately whether the format is
9277 multibyte. Keep only the most-recently calculated precision, rather
9278 than them all. Record whether each argument has been converted to
9279 string. Use EMACS_INT, not int, for byte and char and arg counts.
9280 Support field widths and precisions larger than INT_MAX. Avoid
9281 sprintf's undefined behavior with conversion specifications such as %#d
9282 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9283 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9284 formatting out-of-range floating point numbers with int
9173deec 9285 formats. (Bug#8668)
37910ab2 9286
2e6578fb
PE
9287 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9288
0ae6bdee
PE
9289 * data.c: Avoid integer truncation in expressions involving floats.
9290 * data.c: Include <intprops.h>.
9291 (arith_driver): When there's an integer overflow in an expression
9292 involving floating point, convert the integers to floating point
9293 so that the resulting value does not suffer from catastrophic
9294 integer truncation. For example, on a 64-bit host (* 4
9295 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9296 Do not rely on undefined behavior after integer overflow.
9297
de883a70
PE
9298 merge count_size_as_multibyte, parse_str_to_multibyte
9299 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9300 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9301 Check for integer overflow.
9302 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9303 since it's now a duplicate of the other. This is more of
9304 a character than a buffer op, so better that it's in character.c.
9305 * fns.c, print.c: Adjust to above changes.
9306
2ff916cb
PE
93072011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9308
9309 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9310
f1b54466
PE
93112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9312
fb1ac845
PE
9313 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9314 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9315 (x_clipboard_manager_save): Now static.
9316 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9317
f1b54466
PE
9318 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9319 (crypto_hash_function): Now static.
9320 Fix pointer signedness problems. Avoid unnecessary initializations.
9321
a9f737ee
CY
93222011-05-27 Chong Yidong <cyd@stupidchicken.com>
9323
9324 * termhooks.h (Vselection_alist): Make it terminal-local.
9325
9326 * terminal.c (create_terminal): Initialize it.
9327
9328 * xselect.c: Support for clipboard managers.
9329 (Vselection_alist): Move to termhooks.h as terminal-local var.
9330 (LOCAL_SELECTION): New macro.
9331 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9332 (symbol_to_x_atom): Remove gratuitous arg.
9333 (x_handle_selection_request, lisp_data_to_selection_data)
9334 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9335 (x_own_selection, x_get_local_selection, x_convert_selection):
9336 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9337 (some_frame_on_display): Delete unused function.
9338 (Fx_own_selection_internal, Fx_get_selection_internal)
9339 (Fx_disown_selection_internal, Fx_selection_owner_p)
9340 (Fx_selection_exists_p): New optional frame arg.
9341 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9342 (x_handle_selection_clear): Don't treat other terminals with the
9343 same keyboard specially. Use the terminal-local Vselection_alist.
9344 (x_clear_frame_selections): Use Frun_hook_with_args.
9345
9346 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9347
9348 * xterm.h: Add support for those atoms.
9349
e067f0c1
CY
93502011-05-26 Chong Yidong <cyd@stupidchicken.com>
9351
9352 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9353 (converted_selections, conversion_fail_tag): New global variables.
9354 (x_selection_request_lisp_error): Free the above.
9355 (x_get_local_selection): Remove unnecessary code.
9356 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9357 of converted selections stored in converted_selections.
9358 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9359 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9360 (x_convert_selection): New function.
9361 (x_handle_selection_event): Simplify.
9362 (x_get_foreign_selection): Don't ignore incoming requests while
9363 waiting for an answer; this will fail when we implement
9364 SAVE_TARGETS, and seems unnecessary anyway.
9365 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9366 (Vx_sent_selection_functions): Doc fix.
9367
0f4aebc0
LL
93682011-05-26 Leo Liu <sdl.web@gmail.com>
9369
9370 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9371
e61124cd
YM
93722011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9373
9374 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9375
9376 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9377 for fringe update if it has periodic bitmap.
ac389d0c 9378 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9379 and fringe_bitmap_periodic_p.
9380
9381 * fringe.c (get_fringe_bitmap_data): New function.
9382 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9383 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9384 row. Mark glyph row for fringe update if periodicity changed.
9385
9386 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9387 for fringe update unless it has periodic bitmap.
9388
f16d9837
KH
93892011-05-25 Kenichi Handa <handa@m17n.org>
9390
9391 * xdisp.c (get_next_display_element): Set correct it->face_id for
9392 a static composition.
9393
e1b90ef6
LL
93942011-05-24 Leo Liu <sdl.web@gmail.com>
9395
9396 * deps.mk (fns.o):
9397 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9398
9399 * fns.c (crypto_hash_function, Fsha1): New function.
9400 (Fmd5): Use crypto_hash_function.
9401 (syms_of_fns): Add Ssha1.
9402
7400048f
PE
94032011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9404
9405 * gnutls.c: Remove unused macros.
9406 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9407 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9408 Remove macros that are defined and never used.
9409 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9410
abb71cf4
CY
94112011-05-22 Chong Yidong <cyd@stupidchicken.com>
9412
9413 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9414 (Fx_get_selection_internal): Minor cleanup.
9415 (Fx_own_selection_internal): Rename arguments for consistency with
9416 select.el.
9417
6307db39
PE
94182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9419
9420 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9421
f3d4e0a4
CY
94222011-05-22 Chong Yidong <cyd@stupidchicken.com>
9423
9424 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9425
4d8ade89
YM
94262011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9427
9428 * dispnew.c (scrolling_window): Don't exclude the case that the
9429 last enabled row in the desired matrix touches the bottom boundary.
9430
32078c8d
GM
94312011-05-21 Glenn Morris <rgm@gnu.org>
9432
9433 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9434 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9435 and add some more files.
32078c8d 9436
7285dc67
EZ
94372011-05-20 Eli Zaretskii <eliz@gnu.org>
9438
9439 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9440 report_file_error introduced by the change from 2011-05-07.
9441
89d1bd22
PE
94422011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9443
9444 * systime.h (Time): Define only if emacs is defined.
9445 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9446 where the include path doesn't have X11/X.h by default. See
9447 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9448
cd394be1 94492011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9450
9451 * composite.c (find_automatic_composition): Fix previous change.
9452
b9704ad9
GM
94532011-05-20 Glenn Morris <rgm@gnu.org>
9454
9455 * lisp.mk: New file, split from Makefile.in.
9456 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9457 (shortlisp): Remove.
9458 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9459
4a720484
GM
94602011-05-19 Glenn Morris <rgm@gnu.org>
9461
9462 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9463 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9464 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9465 (lisp): Set the order to that of loadup.el.
9466 (shortlisp): Make it a copy of $lisp.
9467 (SOME_MACHINE_LISP): Remove.
9468 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9469 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9470
a28d4396
KH
94712011-05-18 Kenichi Handa <handa@m17n.org>
9472
9473 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9474 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9475 (find_automatic_composition): Mostly rewrite for efficiency.
9476
a2b1fa8e
JB
94772011-05-18 Juanma Barranquero <lekktu@gmail.com>
9478
9479 * makefile.w32-in: Update dependencies.
9480
8e1f5610
CS
94812011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9482
9483 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9484 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9485
7025ee00 94862011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9487
cdfa6eab
PE
9488 Fix some integer overflow issues, such as string length overflow.
9489
06d6db33
PE
9490 * insdel.c (count_size_as_multibyte): Check for string overflow.
9491
2b4560a8
PE
9492 * character.c (lisp_string_width): Check for string overflow.
9493 Use EMACS_INT, not int, for string indexes and lengths; in
9494 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9495 the resulting string length overflows an EMACS_INT; instead,
9496 report a string overflow if no precision given. When checking for
9497 precision exhaustion, use a check that cannot possibly have
9498 integer overflow. (Bug#8675)
9499 * character.h (lisp_string_width): Adjust to new signature.
9500
cb93f9be
PE
9501 * alloc.c (string_overflow): New function.
9502 (Fmake_string): Use it. This doesn't change behavior, but saves
9503 a few bytes and will simplify future changes.
9504 * character.c (string_escape_byte8): Likewise.
9505 * lisp.h (string_overflow): New decl.
9506
1a1f3366
PE
9507 Fixups, following up to the user-interface timestamp change.
9508 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9509 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9510 * msdos.c (mouse_get_pos): Likewise.
9511 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9512 * w32gui.h (Time): Define by including "systime.h" rather than by
9513 declaring it ourselves. (Bug#8664)
9514
d4e3e4d3
PE
9515 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9516 * image.c (clear_image_cache): Likewise.
9517
f6a24d19
PE
9518 * term.c (term_mouse_position): Don't assume time_t wraparound.
9519
08dc5ae6
PE
9520 Be more systematic about user-interface timestamps.
9521 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9522 and sometimes 'EMACS_UINT', to represent these timestamps.
9523 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9524 This makes the code easier to follow, and makes it easier to catch
9525 integer overflow bugs such as Bug#8664.
9526 * frame.c (Fmouse_position, Fmouse_pixel_position):
9527 Use Time, not unsigned long, for user-interface timestamps.
9528 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9529 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9530 * keyboard.h (last_event_timestamp): Likewise.
9531 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9532 * menu.h (xmenu_show): Likewise.
9533 * term.c (term_mouse_position): Likewise.
9534 * termhooks.h (struct input_event.timestamp): Likewise.
9535 (struct terminal.mouse_position_hook): Likewise.
9536 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9537 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9538 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9539 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9540 what it was before.
9541 * menu.h, termhooks.h: Include "systime.h", for Time.
9542
8e55734a
PE
9543 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9544 Don't assume that the difference between two unsigned long values
9545 can fit into an integer. At this point, we know button_down_time
9546 <= event->timestamp, so the difference must be nonnegative, so
9547 there's no need to cast the result if double-click-time is
9548 nonnegative, as it should be; check that it's nonnegative, just in
9549 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9550 apart (about 25 days). (Bug#8664)
8e55734a 9551
841f1b75 9552 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9553 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9554
3e26f69c
PE
9555 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9556 that always fit in int. Use a sentinel instead of a counter, to
9557 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9558 * frame.h (struct frame): Use int for menu_bar_items_used
9559 instead of EMACS_INT, since it always fits in int.
3e26f69c 9560
5cc152c0
PE
9561 * menu.c (grow_menu_items): Check for int overflow.
9562
d89eb65e
PE
9563 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9564
5235bd3e
PE
9565 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9566 Before, the code was not consistent. These values cannot exceed
9567 2**31 - 1 so there's no need to make them unsigned.
9568 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9569 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9570 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9571 as modifiers.
9572 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9573
bc827e23
PE
9574 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9575 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9576 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9577 presumably because the widths might not match.
9578
78eb494e
PE
9579 * window.c (size_window): Avoid needless test at loop start.
9580
04f2d78b
CB
95812011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9582
9583 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9584
d2fc7e3d 95852011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9586
9587 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9588
d2fc7e3d 95892011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9590
9591 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9592 `width' to `bar_area_x' and `bar_area_width', respectively.
9593 (x_scroll_run): Take account of fringe background extension.
9594
04f2d78b
CB
9595 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9596 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9597 `bar_area_width', respectively.
9598 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9599 background extension.
9600
79b70037
GM
96012011-05-10 Jim Meyering <meyering@redhat.com>
9602
9603 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9604
2f142cc5
JB
96052011-05-10 Juanma Barranquero <lekktu@gmail.com>
9606
9607 * image.c (Finit_image_library): Return t for built-in image types,
9608 like pbm and xbm. (Bug#8640)
9609
57679c86
AS
96102011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9611
9612 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9613
888c9e86
EZ
96142011-05-07 Eli Zaretskii <eliz@gnu.org>
9615
b0512a1d
EZ
9616 * w32console.c (Fset_screen_color): Doc fix.
9617 (Fget_screen_color): New function.
9618 (syms_of_ntterm): Defsubr it.
9619
7285dc67
EZ
9620 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9621 unlink the temporary file if Fcall_process didn't create it in the
9622 first place.
9623 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9624 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9625 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9626 cue to call_process_cleanup not to close that handle.
9627
4d3fcc8e
BK
96282011-05-07 Ben Key <bkey76@gmail.com>
9629
9630 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9631 one of two shell specific rules, either bootstrap-temacs-CMD or
9632 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9633 to the previous implementation of the bootstrap-temacs rule.
9634 The bootstrap-temacs-CMD rule is similar to the previous
9635 implementation of the bootstrap-temacs rule except that it
9636 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9637 variable.
9638
9639 These changes, along with some changes to nt/configure.bat,
9640 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9641 earlier fix to add support for --cflags and --ldflags options
9642 that include quotes so that it works whether make uses cmd or
9643 sh as the shell.
9644
b4289b64
MA
96452011-05-06 Michael Albinus <michael.albinus@gmx.de>
9646
9647 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9648 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9649 is a constant.
9650 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9651 a string. Handle both cases.
9652 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9653 (Fdbus_register_method): Use Qinvalid_function.
9654
af4c0e28
JB
96552011-05-06 Juanma Barranquero <lekktu@gmail.com>
9656
9657 * makefile.w32-in: Update dependencies.
9658 (LISP_H): Add inttypes.h and stdin.h.
9659 (PROCESS_H): Add unistd.h.
9660
c51453d9
EZ
96612011-05-06 Eli Zaretskii <eliz@gnu.org>
9662
9663 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9664 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9665
8ff0ac3c 96662011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9667
4c4b566b
PE
9668 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9669
aab2b9b5
PE
9670 * term.c (vfatal): Remove stray call to va_end.
9671 It's not needed and the C Standard doesn't allow it here anyway.
9672
c378da0b
PE
9673 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9674 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9675
288b08c7
PE
9676 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9677 bytes.
9678
e3601888
PE
9679 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9680
db6c0e74
PE
9681 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9682
dd5963ea
PE
9683 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9684
88c9450f
PE
9685 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9686
2f9442b8
PE
9687 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9688
c032b5f8
PE
9689 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9690 * charset.c (Fdefine_charset_internal): Don't initialize
9691 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9692 32-bit int (Bug#8600).
a108c10b
PE
9693
9694 * lread.c (read_integer): Be more consistent with string-to-number.
9695 Use string_to_number to do the actual conversion; this avoids
9696 rounding errors and fixes some other screwups. Without this fix,
9697 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9698 (digit_to_number): Move earlier, for benefit of read_integer.
9699 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9700 not a digit in any supported base. (Bug#8602)
a108c10b 9701
ad5f9eea
PE
9702 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9703
aec1708a
PE
9704 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9705 to match comment at start of function. This also removes a
9706 GCC warning about overflow in a 32+64-bit port.
9707
47be4ab5
PE
9708 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9709
371cac43
PE
9710 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9711 Reported by Stefan Monnier in
9712 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9713 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9714 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9715
d01a7826
PE
9716 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9717 (EMACS_UINTPTR): Likewise, with uintptr_t.
9718
7fd47d5c
PE
9719 * lisp.h: Prefer 64-bit EMACS_INT if available.
9720 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9721 on 32-bit hosts that have 64-bit int, so that they can access
9722 large files.
122b0c86
PE
9723 However, temporarily disable this change unless the temporary
9724 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9725
8727937b
PE
9726 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9727
8ac068ac
PE
9728 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9729 This removes an assumption that EMACS_INT and long are the same
9730 width as pointers. The assumption is true for Emacs porting targets
9731 now, but we want to make other targets possible.
9732 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9733 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9734 In the rest of the code, change types of integers that hold casted
9735 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9736 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9737 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9738 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9739 No need to cast type when ORing.
9740 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9741 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9742 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9743 assume EMACS_INT is the same width as char *.
9744 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9745 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9746 Remove no-longer-needed casts.
9747 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9748 (xg_tool_bar_help_callback, xg_make_tool_item):
9749 Use EMACS_INTPTR to hold an integer
9750 that will be cast to void *; this can avoid a GCC warning
9751 if EMACS_INT is not the same width as void *.
9752 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9753 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9754 (current_message_1, set_message_1):
9755 Use a local to convert to proper width without a cast.
9756 * xmenu.c (dialog_selection_callback): Likewise.
9757
ede49d71
PE
9758 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9759 Also, don't assume VALBITS / RAND_BITS is less than 5,
9760 and don't rely on undefined behavior when shifting a 1 left into
9761 the sign bit.
9762 * lisp.h (get_random): Change signature to match.
9763
2f30ecd0
PE
9764 * lread.c (hash_string): Use size_t, not int, for hash computation.
9765 Normally we prefer signed values; but hashing is special, because
9766 it's better to use unsigned division on hash table sizes so that
9767 the remainder is nonnegative. Also, size_t is the natural width
9768 for hashing into memory. The previous code used 'int', which doesn't
9769 retain enough info to hash well into very large tables.
9770 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9771
2a866e7b
PE
9772 * dbusbind.c: Don't possibly lose pointer info when converting.
9773 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9774 Use XPNTR rather than XHASH, so that the high-order bits of
9775 the pointer aren't lost when converting through void *.
9776
51639eac
PE
9777 * eval.c (Fautoload): Don't double-shift a pointer.
9778
92394119
PE
9779 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9780
dbdb9a7c
JB
97812011-05-06 Juanma Barranquero <lekktu@gmail.com>
9782
9783 * gnutls.c (DEF_GNUTLS_FN):
9784 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9785
db7a0b4f
AS
97862011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9787
9788 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9789 marker. (Bug#8610)
9790
cd394be1 97912011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9792
9793 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9794 New version that can reserve upto 2GB of heap space.
9795
f7ff1b0f 97962011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9797
9798 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9799
639c109b
TZ
98002011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9801
9802 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9803 `gnutls_certificate_set_x509_key_file'.
9804
d2127135
JB
98052011-05-05 Juanma Barranquero <lekktu@gmail.com>
9806
9807 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9808 Update dependencies.
9809
e968f4f3
JB
98102011-05-04 Juanma Barranquero <lekktu@gmail.com>
9811
9812 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9813 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9814 Remove unused parameter `fildes'.
9815 * process.c (read_process_output, send_process): Don't pass it.
9816
84d358f0
JB
98172011-05-04 Juanma Barranquero <lekktu@gmail.com>
9818
9819 Fix previous change: the library cache is defined in w32.c.
9820 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9821 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9822
0898ca10
JB
98232011-05-04 Juanma Barranquero <lekktu@gmail.com>
9824
9825 Implement dynamic loading of GnuTLS on Windows.
9826
9827 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9828 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9829 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9830 Declare.
9831
9832 * gnutls.c (Qgnutls_dll): Define.
9833 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9834 (gnutls_*): Declare function pointers.
9835 (init_gnutls_functions): New function to initialize function pointers.
9836 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9837 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9838 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9839 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9840 (emacs_gnutls_write, emacs_gnutls_read)
9841 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9842 (Fgnutls_available_p): New function.
9843 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9844 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9845 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9846
9847 * image.c: Include w32.h.
9848 (Vimage_type_cache): Delete.
9849 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9850 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9851 (w32_delayed_load): Move to w32.c.
9852
9853 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9854
9855 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9856 (w32_delayed_load): Move from image.c. When loading a library, record
9857 its filename in the :loaded-from property of the library id.
9858 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9859 Initialize and staticpro them.
9860 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9861
9862 * process.c: Include lisp.h before w32.h, not after.
9863 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9864 instead of gnutls_record_check_pending.
9865
9866 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9867
ff4de4aa
TZ
98682011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9869
9870 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9871 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9872 as passed in.
9873
abe95abb
JD
98742011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9875
9876 * xterm.c (x_set_frame_alpha): Do not set property on anything
9877 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9878
e16e55d4
JB
98792011-05-02 Juanma Barranquero <lekktu@gmail.com>
9880
9881 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9882
bafcf6a5
JB
98832011-05-02 Juanma Barranquero <lekktu@gmail.com>
9884
9885 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9886 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9887 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9888 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9889 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9890 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9891 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9892 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9893 (Qgnutls_bootprop_callbacks_verify): Make static.
9894
e7a6747f
AS
98952011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9896
19ed11ba
AS
9897 * callproc.c: Indentation fixup.
9898
e7a6747f 9899 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9900 (wait_for_termination, interruptible_wait_for_termination):
9901 Move after wait_for_termination_1.
e7a6747f 9902
1ef14cb4
LMI
99032011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9904
9905 * sysdep.c (interruptible_wait_for_termination): New function
9906 which is like wait_for_termination, but allows keyboard
9907 interruptions.
9908
9909 * callproc.c (Fcall_process): Add (:file "file") as an option for
9910 the STDOUT buffer.
9911 (Fcall_process_region): Ditto.
9912
330d880c
EZ
99132011-04-30 Eli Zaretskii <eliz@gnu.org>
9914
8db90b73
EZ
9915 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9916 rather than `XVECTOR (FOO)->size'.
9917
330d880c
EZ
9918 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9919 inttypes.h, as a gnulib replacement is used if it not available in
9920 system headers.
9921
15cbd324
EZ
99222011-04-21 Eli Zaretskii <eliz@gnu.org>
9923
9924 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9925 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9926 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9927
9928 * coding.c (coding_alloc_by_realloc): Error out if destination
9929 will grow beyond MOST_POSITIVE_FIXNUM.
9930 (decode_coding_emacs_mule): Abort if there isn't enough place in
9931 charbuf for the composition carryover bytes. Reserve an extra
9932 space for up to 2 characters produced in a loop.
9933 (decode_coding_iso_2022): Abort if there isn't enough place in
9934 charbuf for the composition carryover bytes.
9935
99362011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9937
ae940cca
EZ
9938 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9939 aborting when %lld or %lll format is passed.
9940 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9941 %llo or %llx format is passed. (Bug#8545)
9942
03ab8921
EZ
9943 * window.c (window_scroll_line_based): Use a marker instead of
9944 simple variables to record original value of point. (Bug#7952)
9945
afda1437
EZ
9946 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9947 produced by %s or %c overflows available buffer space. (Bug#8545)
9948
f76dee0c
PE
99492011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9950
9951 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9952 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9953
fdc5744d
JB
99542011-04-28 Juanma Barranquero <lekktu@gmail.com>
9955
9956 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9957
638f053a
JB
99582011-04-28 Juanma Barranquero <lekktu@gmail.com>
9959
9960 * keyboard.c (Qdelayed_warnings_hook): Define.
9961 (command_loop_1): Run `delayed-warnings-hook'
9962 if Vdelayed_warnings_list is non-nil.
9963 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9964 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9965
d178f871
EZ
99662011-04-28 Eli Zaretskii <eliz@gnu.org>
9967
9968 * doprnt.c (doprnt): Don't return value smaller than the buffer
9969 size if the message was truncated. (Bug#8545).
9970
b124fd93
JB
99712011-04-28 Juanma Barranquero <lekktu@gmail.com>
9972
9973 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9974 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9975
e810457d
PE
99762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9977
9978 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9979
ea51cceb
JB
99802011-04-27 Juanma Barranquero <lekktu@gmail.com>
9981
9982 * makefile.w32-in: Update dependencies.
9983
94dcfacf
EZ
99842011-04-27 Eli Zaretskii <eliz@gnu.org>
9985
9986 Improve `doprnt' and its usage. (Bug#8545)
9987 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9988 `format_end'. Remove support for %l as a conversion specifier.
9989 Don't use xrealloc. Improve diagnostics when the %l size modifier
9990 is used. Update the commentary.
9991
9992 * eval.c (verror): Simplify calculation of size_t.
9993
9994 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9995 messages.
9996
f61f41d7
PE
99972011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9998
9999 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10000 change.
10001
96fb4434
PE
100022011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10003
10004 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10005 This makes this file independent of the recent pseudovector change.
10006
671875da 100072011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10008
69e9b5a3
PE
10009 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10010
b5f869a7 10011 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10012 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10013 Remove unused local.
c8926152 10014 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10015
841a1577 10016 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10017 GCC 4.6.0 optimizes based on type-based alias analysis.
10018 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10019 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10020 != &v->size, and therefore "v->size = 1; b->size = 2; return
10021 v->size;" must therefore return 1. This assumption is incorrect
10022 for Emacs, since it type-puns struct Lisp_Vector * with many other
10023 types. To fix this problem, this patch adds a new type struct
f904488f 10024 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10025 and pseudovectors, and helps optimizing compilers not get fooled
10026 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10027 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10028 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10029 the size member.
eab3844f
PE
10030 (XSETPVECTYPE): Rewrite in terms of new macro.
10031 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10032 This is a bit clearer, and further avoids the possibility of
10033 undesirable aliasing.
10034 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10035 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10036 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10037 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10038 (ASIZE): Now uses header.size rather than size.
10039 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10040 to avoid the hassle of writing XVECTOR (foo)->header.size.
10041 (struct vectorlike_header): New type.
eab3844f
PE
10042 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10043 object, to help avoid aliasing.
10044 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10045 (SUBRP): Likewise, since Lisp_Subr is a special case.
10046 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10047 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10048 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10049 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10050 changed to be "header.size" and "header.next".
10051 * buffer.h (struct buffer): Likewise.
10052 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10053 * frame.h (struct frame): Likewise.
10054 * process.h (struct Lisp_Process): Likewise.
10055 * termhooks.h (struct terminal): Likewise.
10056 * window.c (struct save_window_data, struct saved_window): Likewise.
10057 * window.h (struct window): Likewise.
10058 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10059 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10060 * buffer.c (init_buffer_once): Likewise.
10061 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10062 special case.
10063 * process.c (Fformat_network_address): Use local var for size,
10064 for brevity.
10065
0df1eac5
PE
10066 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10067
847ab9d1 10068 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10069 * data.c (atof): Remove decl; no longer used or needed.
10070 (digit_to_number): Move to lread.c.
10071 (Fstring_to_number): Use new string_to_number function, to be
10072 consistent with how the Lisp reader treats infinities and NaNs.
10073 Do not assume that floating-point numbers represent EMACS_INT
10074 without losing information; this is not true on most 64-bit hosts.
10075 Avoid double-rounding errors, by insisting on integers when
10076 parsing non-base-10 numbers, as the documentation specifies.
10077 * lisp.h (string_to_number): New decl, replacing ...
10078 (isfloat_string): Remove.
bc0a5c13 10079 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10080 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10081 appears to have been a coding error. Similarly, do not accept
10082 strings like +-1e0 as floating point numbers. Do not report
10083 overflow for integer overflows unless the base is not 10 which
10084 means we have no simple and reliable way to continue.
10085 Break out the floating-point parsing into a new
10086 function string_to_number, so that Fstring_to_number parses
10087 floating point numbers consistently with the Lisp reader.
04f2d78b 10088 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10089 (E_CHAR, EXP_INT): Remove, replacing with ...
10090 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10091 (string_to_number): New function, replacing isfloat_string.
10092 This function checks for valid syntax and produces the resulting
10093 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10094 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10095 so that overflow for non-base-10 numbers is reported only when
10096 there's no portable and simple way to convert to floating point.
452f4150 10097
67769ffc
PE
10098 * textprop.c (set_text_properties_1): Rewrite for clarity,
10099 and to avoid GCC warning about integer overflow.
10100
c20db43f
PE
10101 * intervals.h (struct interval): Use EMACS_INT for members
10102 where EMACS_UINT might cause problems. See
10103 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10104 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10105 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10106 All uses changed.
37aa2f85
PE
10107 (offset_intervals): Tell GCC not to worry about length overflow
10108 when negating a negative length.
c20db43f 10109
2538aa2f
PE
10110 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10111 (overrun_check_free): Likewise.
10112
f2d3008d
PE
10113 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10114 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10115 word size.
10116
ec8df744
PE
10117 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10118 (gnutls_make_error): Rename local to avoid shadowing.
10119 (gnutls_emacs_global_deinit): ifdef out; not used.
10120 (Fgnutls_boot): Use const for pointer to readonly storage.
10121 Comment out unused local. Fix pointer signedness problems.
10122
640ee02d
PE
10123 * lread.c (openp): Don't stuff size_t into an 'int'.
10124 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10125 about possible signed overflow.
10126
6048fb2a
PE
10127 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10128 (GDK_KEY_g): Don't define if already defined.
10129 (xg_prepare_tooltip): Avoid pointer signedness problem.
10130 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10131
fa3c87e1
PE
10132 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10133 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10134
2172544b
PE
10135 * xfns.c (Fx_window_property): Simplify a bit,
10136 to make a bit faster and to avoid GCC 4.6.0 warning.
10137 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10138
9b821a21
PE
10139 * fns.c (internal_equal): Don't assume size_t fits in int.
10140
3c616cfa
PE
10141 * alloc.c (compact_small_strings): Tighten assertion a little.
10142
c2982e87
PE
10143 Replace pEd with more-general pI, and fix some printf arg casts.
10144 * lisp.h (pI): New macro, generalizing old pEd macro to other
10145 conversion specifiers. For example, use "...%"pI"d..." rather
10146 than "...%"pEd"...".
10147 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10148 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10149 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10150 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10151 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10152 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10153 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10154 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10155 64-bit hosts.
10156 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10157 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10158 * print.c (safe_debug_print, print_object): Likewise.
10159 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10160 to int.
6f04d126
PE
10161 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10162 avoiding the 0 flag, which is not portable.
c2982e87
PE
10163 * process.c (Fmake_network_process): Use pI to avoid cast.
10164 * region-cache.c (pp_cache): Likewise.
10165 * xdisp.c (decode_mode_spec): Likewise.
10166 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10167 behavior on 64-bit hosts with printf arg.
6f04d126 10168 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10169 (x_stop_queuing_selection_requests): Likewise.
10170 (x_get_window_property): Don't truncate byte count to an 'int'
10171 when tracing.
0b432f21 10172
5e073ec7
PE
10173 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10174 here, since it parses constructs like leading '-' and spaces,
10175 which are not wanted; and it overflows with large numbers.
10176 Instead, simply match F[0-9]+, which is what is wanted anyway.
10177
36372bf9
PE
10178 * alloc.c: Remove unportable assumptions about struct layout.
10179 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10180 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10181 (allocate_vectorlike, make_pure_vector): Use the new macros,
10182 plus offsetof, to remove unportable assumptions about struct layout.
10183 These assumptions hold on all porting targets that I know of, but
10184 they are not guaranteed, they're easy to remove, and removing them
10185 makes further changes easier.
10186
0b432f21
PE
10187 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10188 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10189 (string_overrun_cookie): Now const. Use initializers that
10190 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10191 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10192 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10193 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10194 multiple of sizeof (EMACS_INT); it need not be, if
10195 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10196 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10197
895009e1
JB
101982011-04-26 Juanma Barranquero <lekktu@gmail.com>
10199
10200 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10201
6a7a1b0b
TZ
102022011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10203
10204 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10205 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10206 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10207
841a1577 102082011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10209
10210 * lisp.h (Qdebug): List symbol.
895009e1 10211 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10212 * keyboard.c (debug-on-event): New variable.
10213 (handle_user_signal): Break into debugger when debug-on-event
10214 matches the current signal symbol.
10215
f2d3ba6f
DN
102162011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10217
10218 * alloc.c (check_sblock, check_string_bytes)
10219 (check_string_free_list): Convert to standard C.
10220
42ce4c63
TZ
102212011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10222
10223 * w32.c (emacs_gnutls_push): Fix typo.
10224
825cd63c
EZ
102252011-04-25 Eli Zaretskii <eliz@gnu.org>
10226
fb11d64d
EZ
10227 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10228 "cast to pointer from integer of different size".
10229
825cd63c
EZ
10230 Improve doprnt and its use in verror. (Bug#8545)
10231 * doprnt.c (doprnt): Document the set of format control sequences
10232 supported by the function. Use SAFE_ALLOCA instead of always
10233 using `alloca'.
10234
10235 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10236 is one byte too soon. Don't use xrealloc; instead xfree and
10237 xmalloc anew.
10238
e061a11b
TZ
102392011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10240
10241 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10242 callbacks stage.
10243
10244 * gnutls.c: Renamed global_initialized to
10245 gnutls_global_initialized. Added internals for the
10246 :verify-hostname-error, :verify-error, and :verify-flags
10247 parameters of `gnutls-boot' and documented those parameters in the
10248 docstring. Start callback support.
9173deec
JB
10249 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10250 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10251 on error. Return error code.
e061a11b
TZ
10252 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10253 (emacs_gnutls_read): Likewise.
10254 (Fgnutls_boot): Return handshake error code.
10255 (emacs_gnutls_handle_error): New function.
10256 (wsaerror_to_errno): Likewise.
10257
10258 * w32.h (emacs_gnutls_pull): Add prototype.
10259 (emacs_gnutls_push): Likewise.
10260
10261 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10262 (emacs_gnutls_push): Likewise.
10263
102642011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10265
10266 * process.c (wait_reading_process_output): Check if GnuTLS
10267 buffered some data internally if no FDs are set for TLS
10268 connections.
10269
10270 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10271 (LIBS): Link to USER_LIBS.
10272 ($(BLD)/gnutls.$(0)): New target.
10273
fa6996bc
EZ
102742011-04-24 Eli Zaretskii <eliz@gnu.org>
10275
eb35682e
EZ
10276 * xdisp.c (handle_single_display_spec): Rename the
10277 display_replaced_before_p argument into display_replaced_p, to
10278 make it consistent with the commentary. Fix typos in the
10279 commentary.
10280
e2ad650c
EZ
10281 * textprop.c (syms_of_textprop): Remove dead code.
10282 (copy_text_properties): Delete obsolete commentary about an
10283 interface that was deleted long ago. Fix typos in the description
10284 of arguments.
10285
1b2de274
EZ
10286 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10287 to changes in oldXMenu/XMenu.h from 2011-04-16.
10288 <menu_help_message, prev_menu_help_message>: Constify.
10289 (IT_menu_make_room): menu->help_text is now `const char **';
10290 adjust.
10291
10292 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10293 to changes in oldXMenu/XMenu.h from 2011-04-16.
10294 (struct XMenu): Declare `help_text' `const char **'.
10295
10296 * xfaces.c <Qunspecified>: Make extern again.
10297
10298 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10299 required by POSIX.
1b2de274 10300
762b15be
EZ
10301 * doc.c (get_doc_string): Improve the format passed to `error'.
10302
10303 * doprnt.c (doprnt): Improve commentary.
10304
10305 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10306
10307 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10308 them with etags.
10309
f1052e5d
EZ
10310 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10311 changes in globals.h immediately force recompilation.
762b15be
EZ
10312 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10313 $(CURDIR)/s/ms-w32.h.
10314 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10315
fa6996bc
EZ
10316 * character.c (Fchar_direction): Function deleted.
10317 (syms_of_character): Don't defsubr it.
10318 <char-direction-table>: Deleted.
10319
e6c3da20
EZ
103202011-04-23 Eli Zaretskii <eliz@gnu.org>
10321
10322 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10323 * doprnt.c: Include limits.h.
10324 (SIZE_MAX): New macro.
04f2d78b
CB
10325 (doprnt): Return a size_t value. 2nd arg is now size_t.
10326 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10327 Improve overflow protection. Support `l' modifier for integer
10328 conversions. Support %l conversion. Don't assume an EMACS_INT
10329 argument for integer conversions and for %c.
10330
10331 * lisp.h (doprnt): Restore prototype.
10332
10333 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10334 $(SRC)/character.h.
10335
10336 * Makefile.in (base_obj): Add back doprnt.o.
10337
10338 * deps.mk (doprnt.o): Add back prerequisites.
10339 (callint.o): Depend on character.h.
10340
10341 * eval.c (internal_lisp_condition_case): Include the handler
10342 representation in the error message.
10343 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10344 when breaking from the loop.
10345
10346 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10347
10348 * callint.c (Fcall_interactively): When displaying error message
10349 about invalid control letter, pass the character's codepoint, not
10350 a pointer to its multibyte form. Improve display of the character
10351 in octal and display also its hex code.
10352
10353 * character.c (char_string): Use %x to display the (unsigned)
10354 codepoint of an invalid character, to avoid displaying a bogus
10355 negative value.
10356
10357 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10358 `error', not SYMBOL_NAME itself.
10359
10360 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10361 character arguments to `error'.
10362
10363 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10364 to `error' in error message about FINAL_CHAR argument. Make sure
10365 FINAL_CHAR is a character, and use %c when it is passed as
10366 argument to `error'.
10367
4ffd0d6b 103682011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10369
10370 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10371
10372 * w32.c: Include <time.h>.
10373 (sys_localtime): New function.
10374
4ffd0d6b 103752011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10376
10377 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10378
4ffd0d6b 10379 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10380
4ffd0d6b 103812011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10382
4ffd0d6b
GM
10383 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10384 zombies (Bug#8467).
aac0c6e3 10385
04c56954
EZ
103862011-04-19 Eli Zaretskii <eliz@gnu.org>
10387
10388 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10389 gl_state.e_property when gl_state.object is Qt.
10390
10391 * insdel.c (make_gap_larger): Remove limitation of buffer size
10392 to <= INT_MAX.
10393
16a43933
CY
103942011-04-18 Chong Yidong <cyd@stupidchicken.com>
10395
10396 * xdisp.c (lookup_glyphless_char_display)
10397 (produce_glyphless_glyph): Handle cons cell entry in
10398 glyphless-char-display.
10399 (Vglyphless_char_display): Document it.
10400
10401 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10402 glyphless-char-display.
10403
4581706e
CY
104042011-04-17 Chong Yidong <cyd@stupidchicken.com>
10405
10406 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10407
10408 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10409
10410 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10411 definition for no-X builds.
10412
4887c6e2 104132011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10414
fd35b6f9
PE
10415 Static checks with GCC 4.6.0 and non-default toolkits.
10416
5c1ccb01
PE
10417 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10418
006c5daa
PE
10419 * process.c (keyboard_bit_set): Define only if SIGIO.
10420 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10421 (send_process): Repair possible setjmp clobbering.
10422
efc736d3
PE
10423 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10424
4e2fe2e6
PE
10425 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10426
f97334a2
PE
10427 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10428
4e75f29d
PE
10429 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10430 Define only if needed.
10431
90efadd1
PE
10432 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10433 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10434 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10435
3c647824
PE
10436 * dispextern.h (struct redisplay_interface): Rename param
10437 to avoid shadowing.
e264f262 10438 * termhooks.h (struct terminal): Likewise.
761383f4 10439 * xterm.c (xembed_send_message): Likewise.
3c647824 10440
b58c5c4a
PE
10441 * insdel.c (make_gap_smaller): Define only if
10442 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10443
cad59032
PE
10444 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10445 it.
10446
c339dc2e
PE
10447 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10448 so that we aren't warned about unused symbols.
10449
91a3e27b
PE
10450 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10451
399c71d3 10452 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10453
8ffc96f5
PE
10454 * xfns.c (x_real_positions): Mark locals as initialized.
10455
eef9bc79
PE
10456 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10457
098db9dd
PE
10458 * xterm.c: Fix problems found by static analysis with other toolkits.
10459 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10460 (x_dispatch_event): Declare static if USE_GTK, and
10461 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10462 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10463 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10464 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10465 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10466
eb18f6cc
PE
10467 * xmenu.c (menu_help_callback): Pointer type fixes.
10468 Use const pointers when pointing at readonly data. Avoid pointer
10469 signedness clashes.
10470 (FALSE): Remove unused macro.
10471 (update_frame_menubar): Remove unused decl.
10472
1fe72bf8
PE
10473 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10474
60d9e1db
PE
10475 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10476 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10477 (single_menu_item): Rename local to avoid shadowing.
10478
39261c26
PE
10479 * keyboard.c (make_lispy_event): Remove unused local var.
10480
018c5e19
PE
10481 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10482 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10483
63d2b86e
PE
10484 * bitmaps: Change bitmaps from unsigned char back to the X11
10485 compatible char. Avoid the old compiler warnings about
10486 out-of-range initializers by using, for example, '\xab' rather
10487 than 0xab.
10488
aefd87e1
PE
10489 * xgselect.c (xgselect_initialize): Check vs interface
10490 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10491
bf501fb9
PE
10492 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10493
e9829fdf
PE
10494 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10495 to read-only memory.
10496
1086c095
PE
10497 * fns.c (vector): Remove; this old hack is no longer needed.
10498
2baccd04 10499 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10500 Remove unused var.
dde42981 10501 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10502
72391843 10503 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10504
436c16df 10505 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10506 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10507 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10508
92bb796d 10509 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10510 (x_term_init): Remove local to avoid shadowing.
92bb796d 10511
764430a3 10512 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10513
10514 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10515 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10516
d1dfb56c
EZ
105172011-04-16 Eli Zaretskii <eliz@gnu.org>
10518
c4354cb4
EZ
10519 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10520
d1dfb56c
EZ
10521 Fix regex.c, syntax.c and friends for buffers > 2GB.
10522 * syntax.h (struct gl_state_s): Declare character position members
10523 EMACS_INT.
10524
10525 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10526
04f2d78b
CB
10527 * textprop.c (verify_interval_modification, interval_of):
10528 Declare arguments EMACS_INT.
d1dfb56c
EZ
10529
10530 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10531 EMACS_INT.
10532
10533 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10534
10535 * indent.c (Fvertical_motion): Local variable it_start is now
10536 EMACS_INT.
10537
10538 * regex.c (re_match, re_match_2, re_match_2_internal)
10539 (bcmp_translate, regcomp, regexec, print_double_string)
10540 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10541 (re_compile_pattern, re_exec): Declare arguments and local
10542 variables `size_t' and `ssize_t' and return values `regoff_t', as
10543 appropriate.
10544 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10545 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10546 <compile_stack_type>: `size' and `avail' are now `size_t'.
10547
10548 * regex.h <regoff_t>: Use ssize_t, not int.
10549 (re_search, re_search_2, re_match, re_match_2): Arguments that
10550 specify buffer/string position and length are now ssize_t and
10551 size_t. Return type is regoff_t.
10552
613052cd
BK
105532011-04-16 Ben Key <bkey76@gmail.com>
10554
10555 * nsfont.m: Fixed bugs in ns_get_family and
10556 ns_descriptor_to_entity that were caused by using free to
10557 deallocate memory blocks that were allocated by xmalloc (via
10558 xstrdup). This caused Emacs to crash when compiled with
10559 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10560 --enable-checking=xmallocoverrun). xfree is now used to
10561 deallocate these memory blocks.
10562
4170f62f 105632011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10564
71b41406
PE
10565 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10566
9587a89d
PE
10567 emacs_write: Accept and return EMACS_INT for sizes.
10568 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10569 et seq.
10570 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10571 Accept and return EMACS_INT.
10572 (emacs_gnutls_write): Return the number of bytes written on
10573 partial writes.
10574 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10575 (emacs_read, emacs_write): Remove check for negative size, as the
10576 Emacs source code has been audited now.
9587a89d
PE
10577 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10578 (emacs_read, emacs_write): Use it.
273a5f82
PE
10579 * process.c (send_process): Adjust to the new signatures of
10580 emacs_write and emacs_gnutls_write. Do not attempt to store
10581 a byte offset into an 'int'; it might overflow.
9587a89d 10582 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10583
3e047f51
PE
10584 * sound.c: Don't assume sizes fit in 'int'.
10585 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10586 Return EMACS_INT, not int.
3e047f51 10587 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10588 Accept EMACS_INT, not int.
10589 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10590 record read return values.
10591
cc39a9db
BK
105922011-04-15 Ben Key <bkey76@gmail.com>
10593
c9d0ec6d
JB
10594 * keyboard.c (Qundefined): Don't declare static since it is used
10595 in nsfns.m.
10596 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10597 static since they are used in nsfont.m.
cc39a9db 10598
6c60eb9f
SM
105992011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10600
10601 * process.c (Qprocessp): Don't declare static.
10602 * lisp.h (Qprocessp): Declare again.
10603
7990b61a
JB
106042011-04-15 Juanma Barranquero <lekktu@gmail.com>
10605
10606 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10607
5d4cb038
PE
106082011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10609
8bd7b830 10610 Improve C-level modularity by making more things 'static'.
cd64ea1d 10611
e3b27b31
PE
10612 Don't publish debugger-only interfaces to other modules.
10613 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10614 (verify_bytepos, count_markers): Move decls to the only modules
10615 that need them.
10616 * region-cache.h (pp_cache): Likewise.
10617 * window.h (check_all_windows): Likewise.
10618 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10619
5d4cb038
PE
10620 * sysdep.c (croak): Now static, if
10621 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10622 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10623
10624 * alloc.c (refill_memory_reserve): Now static if
10625 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10626 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10627
e87b6180
PE
10628 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10629 Define only if USE_LUCID.
10630
ac64929e
PE
10631 * xrdb.c (x_customization_string, x_rm_string): Now static.
10632
6f37259d
PE
10633 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10634 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10635
1683e3ab
PE
10636 * xdisp.c (draw_row_with_mouse_face): Now static.
10637 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10638
de9c2632
PE
10639 * window.h (check_all_windows): Mark externally visible.
10640
2b96acb7
PE
10641 * window.c (window_deletion_count): Now static.
10642
10643 * undo.c: Make symbols static if they're not exported.
10644 (last_undo_buffer, last_boundary_position, pending_boundary):
10645 Now static.
10646
50436f33
PE
10647 * textprop.c (interval_insert_behind_hooks): Now static.
10648 (interval_insert_in_front_hooks): Likewise.
10649
64520e5c
PE
10650 * term.c: Make symbols static if they're not exported.
10651 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10652 (max_frame_lines, tty_set_terminal_modes):
10653 (tty_reset_terminal_modes, tty_turn_off_highlight):
10654 (get_tty_terminal): Now static.
10655 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10656 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10657 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10658 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10659 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10660
1fa53021
PE
10661 * sysdep.c: Make symbols static if they're not exported.
10662 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10663 Now static.
10664 (sigprocmask_set, full_mask): Remove; unused.
10665 (wait_debugging): Mark as visible.
10666 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10667 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10668
d4b43b22
PE
10669 * syntax.c (syntax_temp): Define only if !__GNUC__.
10670
b7c513d0
PE
10671 * sound.c (current_sound_device, current_sound): Now static.
10672
989b29ad
PE
10673 * search.c (searchbufs, searchbuf_head): Now static.
10674
13a55a78
PE
10675 * scroll.c (scroll_cost): Remove; unused.
10676 * dispextern.h (scroll_cost): Remove decl.
10677
de68a1fc
PE
10678 * region-cache.h (pp_cache): Mark as externally visible.
10679
40ccffa6
PE
10680 * process.c: Make symbols static if they're not exported.
10681 (process_tick, update_tick, create_process, chan_process):
10682 (Vprocess_alist, proc_buffered_char, datagram_access):
10683 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10684 (deactivate_process): Mark defn as static, as well as decl.
10685 * lisp.h (create_process): Remove decl.
10686 * process.h (chan_process, Vprocess_alist): Remove decls.
10687
ad64fc97
PE
10688 * print.c: Make symbols static if they're not exported.
10689 (print_depth, new_backquote_output, being_printed, print_buffer):
10690 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10691 (print_interval, print_number_index, initial_stderr_stream):
10692 Now static.
10693 * lisp.h (Fprinc): Remove decl.
10694 (debug_output_compilation_hack): Mark as externally visible.
10695
adddb265
PE
10696 * sysdep.c (croak): Move decl from here to syssignal.h.
10697 * syssignal.h (croak): Put it here, so the API can be checked when
10698 'croak' is called from dissociate_if_controlling_tty.
10699
1717ede2
PE
10700 * minibuf.c: Make symbols static if they're not exported.
10701 (minibuf_save_list, choose_minibuf_frame): Now static.
10702 * lisp.h (choose_minibuf_frame): Remove decl.
10703
fa5fb2bc
PE
10704 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10705
1e3890d1
PE
10706 * lread.c: Make symbols static if they're not exported.
10707 (read_objects, initial_obarray, oblookup_last_bucket_number):
10708 Now static.
10709 (make_symbol): Remove; unused.
10710 * lisp.h (initial_obarray, make_symbol): Remove decls.
10711
8a1414fa
PE
10712 * keyboard.c: Make symbols static if they're not exported.
10713 (single_kboard, recent_keys_index, total_keys, recent_keys):
10714 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10715 (this_single_command_key_start, echoing, last_auto_save):
10716 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10717 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10718 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10719 (Vlispy_mouse_stem, double_click_count):
10720 Now static.
10721 (force_auto_save_soon): Define only if SIGDANGER.
10722 (ignore_mouse_drag_p): Now static if
10723 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10724 (print_help): Remove; unused.
10725 (stop_character, last_timer_event): Mark as externally visible.
10726 * keyboard.h (ignore_mouse_drag_p): Declare only if
10727 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10728 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10729 * lisp.h (echoing): Remove decl.
10730 (force_auto_save_soon): Declare only if SIGDANGER.
10731 * xdisp.c (redisplay_window): Simplify code, to make it more
10732 obvious that ignore_mouse_drag_p is not accessed if !defined
10733 USE_GTK && !defined HAVE_NS.
10734
93ea6e8f
PE
10735 * intervals.c: Make symbols static if they're not exported.
10736 (merge_properties_sticky, merge_interval_right, delete_interval):
10737 Now static.
10738 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10739
77382fcc
PE
10740 * insdel.c: Make symbols static if they're not exported.
10741 However, leave prepare_to_modify_buffer alone. It's never
10742 called from outside this function, but that appears to be a bug.
10743 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10744 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10745 (adjust_after_replace_noundo): Remove; unused.
10746 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10747 (signal_before_change): Remove decls.
77382fcc 10748
9306c32e
PE
10749 * indent.c (val_compute_motion, val_vmotion): Now static.
10750
cd44d2eb
PE
10751 * image.c: Make symbols static if they're not exported.
10752 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10753 if USE_GTK.
10754 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10755 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10756
ad9a7a06
PE
10757 * fringe.c (standard_bitmaps): Now static.
10758 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10759
81626931
PE
10760 * frame.c: Make symbols static if they're not exported.
10761 (x_report_frame_params, make_terminal_frame): Now static.
10762 (get_frame_param): Now static, unless HAVE_NS.
10763 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10764 (x_get_resource_string): Remove; not used.
10765 * frame.h (make_terminal_frame, x_report_frame_params):
10766 (x_get_resource_string); Remove decls.
10767 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10768 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10769
239f9db9
PE
10770 * font.c, fontset.c: Make symbols static if they're not exported.
10771 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10772 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10773 * font.c (font_close_object): Now static.
10774 * font.h (font_close_object): Remove.
10775 * fontset.c (FONTSET_OBJLIST): Remove.
10776 (free_realized_fontset) #if-0 the body, which does nothing.
10777 (face_suitable_for_char_p): #if-0, as it's never called.
10778 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10779 * xfaces.c (face_at_string_position):
10780 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10781 since 0 is always ASCII.
10782
dfcf3579
PE
10783 * fns.c (weak_hash_tables): Now static.
10784
5045092b
PE
10785 * fileio.c: Make symbols static if they're not exported.
10786 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10787 (Vwrite_region_annotation_buffers): Now static.
10788
57a96f5c
PE
10789 * eval.c: Make symbols static if they're not exported.
10790 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10791 * lisp.h (backtrace_list): Remove decl.
10792
35f08c38
PE
10793 * emacs.c: Make symbols static if they're not exported.
10794 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10795 (fatal_error_code, fatal_error_signal_hook, standard_args):
10796 Now static.
10797 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10798 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10799 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10800 * lisp.h (fatal_error_signal_hook): Remove decl.
10801 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10802
f44bd759
PE
10803 * editfns.c: Move a (normally-unused) function to its only use.
10804 * editfns.c, lisp.h (get_operating_system_release): Remove.
10805 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10806 worth the hassle of breaking this out.
10807
b532497d
PE
10808 * xterm.c: Make symbols static if they're not exported.
10809 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10810 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10811 (x_destroy_window, x_delete_display):
10812 Now static.
10813 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10814 (x_mouse_leave): Remove; unused.
10815 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10816 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10817 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10818 Remove decls.
10819 (x_mouse_leave): Declare only if WINDOWSNT.
10820 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10821 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10822 USE_X_TOOLKIT.
10823
1675728f
PE
10824 * ftxfont.c: Make symbols static if they're not exported.
10825 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10826 HAVE_FREETYPE.
10827 * font.h (ftxfont_driver): Likewise.
10828
e4cebfca
PE
10829 * xfns.c: Make symbols static if they're not exported.
10830 (x_last_font_name, x_display_info_for_name):
10831 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10832 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10833 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10834 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10835 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10836 (last_show_tip_args): Now static.
10837 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10838 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10839 (x_screen_planes): Remove; unused.
10840 * dispextern.h (x_screen_planes): Remove decl.
10841
5bf46f05
PE
10842 * dispnew.c: Make symbols static if they're not exported.
10843 * dispextern.h (redraw_garbaged_frames, scrolling):
10844 (increment_row_positions): Remove.
10845 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10846 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10847 Now static.
10848 (redraw_garbaged_frames): Remove; unused.
10849
435f4c28
PE
10850 * xfaces.c: Make symbols static if they're not exported.
10851 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10852 Remove decls.
10853 * xterm.h (defined_color): Remove decls.
10854 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10855 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10856 (menu_face_changed_default, defined_color, free_realized_face):
10857 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10858 (ascii_face_of_lisp_face): Remove; unused.
10859
8524aef3
PE
10860 * xdisp.c: Make symbols static if they're not exported.
10861 * dispextern.h (scratch_glyph_row, window_box_edges):
10862 (glyph_to_pixel_coords, set_cursor_from_row):
10863 (get_next_display_element, set_iterator_to_next):
10864 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10865 (show_mouse_face): Remove decls
10866 * frame.h (message_buf_print): Likewise.
10867 * lisp.h (pop_message, set_message, check_point_in_composition):
10868 Likewise.
10869 * xterm.h (set_vertical_scroll_bar): Likewise.
10870 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10871 (message_buf_print, scratch_glyph_row, displayed_buffer):
10872 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10873 (get_next_display_element, show_mouse_face, window_box_edges):
10874 (frame_to_window_pixel_xy, check_point_in_composition):
10875 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10876 (glyph_to_pixel_coords): Remove; unused.
10877
16390cd2
PE
10878 * dired.c (file_name_completion): Now static.
10879
10880 * dbusbind.c (xd_in_read_queued_messages): Now static.
10881
a25f4dfa
PE
10882 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10883 * data.c (circular_list_error): Remove.
10884
14a9c8df
PE
10885 * commands.h (last_point_position, last_point_position_buffer):
10886 (last_point_position_window): Remove decls.
10887 * keyboard.c: Make these variables static.
10888
04f2d78b
CB
10889 * coding.h (coding, code_convert_region, encode_coding_gap):
10890 Remove decls.
74ab6df5
PE
10891 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10892 (iso_code_class, detect_coding, code_convert_region): Now static.
10893 (encode_coding_gap): Remove; unused.
10894
38dfbee1
PE
10895 * chartab.c (chartab_chars, chartab_bits): Now static.
10896
a2cb4e63
PE
10897 * charset.h (charset_iso_8859_1): Remove decl.
10898 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10899 Now static.
10900
127198fd
PE
10901 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10902 * ccl.c (Vccl_program_table): Now static.
10903 (check_ccl_update): Remove; unused.
10904
d85b608f
PE
10905 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10906 * category.h: ... from here.
10907 * category.c (check_category_table, set_category_set): Now static.
10908
31cd66f3
PE
10909 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10910 * lisp.h: Remove these decls.
10911
c358e587
PE
10912 * buffer.c (buffer_count): Remove unused var.
10913
e78aecca
PE
10914 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10915 so that it's not optimized away.
10916 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10917 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10918 exported only to the debugger.
10919
e192d7d3 10920 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10921 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10922
92470028
PE
10923 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10924 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10925 was inaccessible from Lisp.
10926 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10927 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10928
244ed907
PE
10929 alloc.c: Import and export fewer symbols, and remove unused items.
10930 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10931 is defined.
10932 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10933 it's not optimized away by whole-program optimization.
10934 (message_enable_multibyte, free_misc): Remove.
10935 (catchlist, handlerlist, mark_backtrace):
10936 Declare only if BYTE_MARK_STACK.
10937 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10938 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10939 (message_enable_multibyte): Remove decl.
10940 (free_misc, interval_free_list, float_block, float_block_index):
10941 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10942 (cons_free_list, last_marked_index):
10943 Now static.
10944 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10945 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10946 (mark_backtrace): Define only if BYTE_MARK_STACK.
10947 * xdisp.c (message_enable_multibyte): Now static.
10948
61c2b50e 10949 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10950 This makes it easier for human readers (and static analyzers)
10951 to see whether these variables are used from other modules.
10952 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10953 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10954 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10955 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10956 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10957 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10958 * xmenu.c, xselect.c:
10959 Declare Q* vars static if they are not used in other modules.
10960 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10961 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10962 Remove decls of unexported vars.
10963 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10964
95c82688
PE
10965 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10966
16a97296
PE
10967 Make Emacs functions such as Fatom 'static' by default.
10968 This makes it easier for human readers (and static analyzers)
10969 to see whether these functions can be called from other modules.
10970 DEFUN now defines a static function. To make the function external
10971 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10972 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10973 (Finit_image_library):
16a97296
PE
10974 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10975 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10976 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10977 Remove decls, since these functions are now static.
10978 (Funintern, Fget_internal_run_time): New decls, since these functions
10979 were already external.
95c82688 10980
16a97296
PE
10981 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10982 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10983 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10984 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10985 * keyboard.c, keymap.c, lread.c:
10986 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10987 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10988 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10989 Mark functions with DEFUE instead of DEFUN,
10990 if they are used in other modules.
10991 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10992 decls for now-static functions.
10993 * buffer.h (Fdelete_overlay): Remove decl.
10994 * callproc.c (Fgetenv_internal): Mark as internal.
10995 * composite.c (Fremove_list_of_text_properties): Remove decl.
10996 (Fcomposition_get_gstring): New forward static decl.
10997 * composite.h (Fcomposite_get_gstring): Remove decl.
10998 * dired.c (Ffile_attributes): New forward static decl.
10999 * doc.c (Fdocumntation_property): New forward static decl.
11000 * eval.c (Ffetch_bytecode): New forward static decl.
11001 (Funintern): Remove extern decl; now in .h file where it belongs.
11002 * fileio.c (Fmake_symbolic_link): New forward static decl.
11003 * image.c (Finit_image_library): New forward static decl.
11004 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11005 * intervals.h (Fprevious_property_change):
11006 (Fremove_list_of_text_properties): Remove decls.
11007 * keyboard.c (Fthis_command_keys): Remove decl.
11008 (Fcommand_execute): New forward static decl.
11009 * keymap.c (Flookup_key): New forward static decl.
11010 (Fcopy_keymap): Now static.
11011 * keymap.h (Flookup_key): Remove decl.
11012 * process.c (Fget_process): New forward static decl.
11013 (Fprocess_datagram_address): Mark as internal.
11014 * syntax.c (Fsyntax_table_p): New forward static decl.
11015 (skip_chars): Remove duplicate decl.
11016 * textprop.c (Fprevious_property_change): New forward static decl.
11017 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11018 Now internal.
11019 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11020 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11021
785bbd42
PE
11022 * editfns.c (Fformat): Remove unreachable code.
11023
8b913b57
AS
110242011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11025
11026 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11027 change. (Bug#8496)
11028
a6744a35
EZ
110292011-04-13 Eli Zaretskii <eliz@gnu.org>
11030
11031 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11032 when at ZV. (Bug#8487)
11033
e7974947
AS
110342011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11035
baad03f0
AS
11036 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11037 (Bug#8437)
11038 * keyboard.c (parse_tool_bar_item): Likewise.
11039 * sound.c (sound_cleanup, alsa_close): Likewise.
11040 * termcap.c (tgetent): Likewise.
11041 * xfns.c (x_default_font_parameter): Likewise.
11042 * xsettings.c (read_and_apply_settings): Likewise.
11043
e7974947
AS
11044 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11045 (overrun_check_free): Protoize.
11046
28272684
PE
110472011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11048
11049 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11050 since callers should never pass a negative size.
11051 Change the signature to match that of plain 'read' and 'write'; see
11052 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11053 * lisp.h: Update prototypes of emacs_write and emacs_read.
11054
11997c76
EZ
110552011-04-11 Eli Zaretskii <eliz@gnu.org>
11056
11057 * xdisp.c (redisplay_window): Don't try to determine the character
11058 position of the scroll margin if the window start point w->startp
e896f03c 11059 is outside the buffer's accessible region. (Bug#8468)
11997c76 11060
8a2cbd72
EZ
110612011-04-10 Eli Zaretskii <eliz@gnu.org>
11062
11063 Fix write-region and its subroutines for buffers > 2GB.
11064 * fileio.c (a_write, e_write): Modify declaration of arguments and
11065 local variables to support buffers larger than 2GB.
11066 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11067
11068 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11069 argument, local variables, and return value.
11070
11071 * lisp.h: Update prototypes of emacs_write and emacs_read.
11072
11073 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11074
4073e537 110752011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11076
1ebfdcb6
PE
11077 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11078
b2ded58d
PE
11079 Fix more problems found by GCC 4.6.0's static checks.
11080
7d66342c
PE
11081 * xdisp.c (vmessage): Use a better test for character truncation.
11082
bbf47d44
PE
11083 * charset.c (load_charset_map): <, not <=, for optimization,
11084 and to avoid potential problems with integer overflow.
9248994d 11085 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11086 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11087 * editfns.c (Fformat): Likewise.
1e69125e 11088 * syntax.c (skip_chars): Likewise.
3befa583 11089
e3019616
PE
11090 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11091 This also lets GCC 4.6.0 generate slightly better loop code.
11092
becfa255
PE
11093 * callint.c (Fcall_interactively): <, not <=, for optimization.
11094 (Fcall_interactively): Count the number of arguments produced,
11095 not the number of arguments given. This is simpler and lets GCC
11096 4.6.0 generate slightly better code.
11097
dae0cd48
PE
11098 * ftfont.c: Distingish more carefully between FcChar8 and char.
11099 The previous code passed unsigned char * to a functions like
11100 strlen and xstrcasecmp that expect char *, which does not
11101 conform to the C standard.
11102 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11103 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11104 char * when the C standard requires it.
11105
76032d70
PE
11106 * keyboard.c (read_char): Remove unused var.
11107
eb3f1cc8
PE
11108 * eval.c: Port to Windows vsnprintf (Bug#8435).
11109 Include <limits.h>.
11110 (SIZE_MAX): Define if the headers do not.
11111 (verror): Do not give up if vsnprintf returns a negative count.
11112 Instead, grow the buffer. This ports to Windows vsnprintf, which
11113 does not conform to C99. Problem reported by Eli Zaretskii.
11114 Also, simplify the allocation scheme, by avoiding the need for
11115 calling realloc, and removing the ALLOCATED variable.
11116
70476b54
PE
11117 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11118
12020a9e
PE
11119 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11120 But keep the doprint source code for now, as we might revamp it
11121 and use it again (Bug#8435).
ea6c7ae6
PE
11122 * lisp.h (doprnt): Remove.
11123 * Makefile.in (base_obj): Remove doprnt.o.
11124 * deps.mk (doprnt.o): Remove.
11125
5fdb398c
PE
11126 error: Print 32- and 64-bit integers portably (Bug#8435).
11127 Without this change, on typical 64-bit hosts error ("...%d...", N)
11128 was used to print both 32- and 64-bit integers N, which relied on
11129 undefined behavior.
61bdb816 11130 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11131 * lisp.h (error, verror): Mark as printf-like functions.
11132 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11133 Report overflow in size calculations when allocating printf buffer.
11134 Do not truncate output string at its first null byte.
11135 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11136 Truncate the output at a character boundary, since vsnprintf does not
11137 do that.
11138 * charset.c (check_iso_charset_parameter): Convert internal
11139 character to string before calling 'error', since %c now has the
11140 printf meaning.
11141 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11142 overflow when computing char to be passed to 'error'. Do not
11143 pass Lisp_Object to 'error'; pass the integer instead.
11144 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11145 formatted with plain %d.
11146
b189fa66
PE
11147 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11148
bff87ef0
PE
11149 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11150
7e2cac20
PE
11151 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11152
ce4d90b5
PE
11153 * xterm.c (x_catch_errors): Remove duplicate declaration.
11154
266c9547
PE
11155 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11156
79c49ad2
PE
11157 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11158
368f4090
JM
111592011-04-10 Jim Meyering <meyering@redhat.com>
11160
11161 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11162 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11163 return ssize_t not "int", and use size_t as the buffer length.
11164 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11165 * gnutls.h: Update declarations.
11166 * process.c (read_process_output): Use ssize_t, to match.
11167 (send_process): Likewise.
11168
a32d4040
CY
111692011-04-09 Chong Yidong <cyd@stupidchicken.com>
11170
11171 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11172
8546720e 111732011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11174
04f2d78b
CB
11175 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11176 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11177
8546720e
GM
11178 * xterm.c (handle_one_xevent):
11179 * xmenu.c (create_and_show_popup_menu):
11180 * xselect.c (x_decline_selection_request)
11181 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11182
0a2f5c1a 111832011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11184
11185 Fix some uses of `int' instead of EMACS_INT.
11186 * search.c (string_match_1, fast_string_match)
11187 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11188 (scan_buffer, find_next_newline_no_quit)
11189 (find_before_next_newline, search_command, Freplace_match)
11190 (Fmatch_data): Make some `int' variables be EMACS_INT.
11191
11192 * xdisp.c (display_count_lines): 3rd argument and return value now
11193 EMACS_INT. All callers changed.
11194 (pint2hrstr): Last argument is now EMACS_INT.
11195
11196 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11197 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11198 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11199 (decode_coding_utf_16, decode_coding_emacs_mule)
11200 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11201 (decode_coding_ccl, decode_coding_charset)
11202 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11203 (decode_coding_iso_2022, decode_coding_emacs_mule)
11204 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11205 <char_offset, last_offset>: Declare EMACS_INT.
11206 (encode_coding_utf_8, encode_coding_utf_16)
11207 (encode_coding_emacs_mule, encode_invocation_designation)
11208 (encode_designation_at_bol, encode_coding_iso_2022)
11209 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11210 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11211 Declare EMACS_INT.
11212 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11213 (encode_invocation_designation): Last argument P_NCHARS is now
11214 EMACS_INT.
11215 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11216 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11217
11218 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11219 All users changed.
11220
11221 * ccl.c (Fccl_execute_on_string): Declare some variables
11222 EMACS_INT.
11223
8546720e 112242011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11225
11226 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11227
4e19a977
CS
112282011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11229
11230 * process.c (Fformat_network_address): Doc fix.
11231
87302331
R
112322011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11233
ee7683eb 11234 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11235
cbb59342
CY
112362011-04-08 Chong Yidong <cyd@stupidchicken.com>
11237
11238 * keyboard.c (read_char): Call Lisp function help-form-show,
11239 instead of using internal_with_output_to_temp_buffer.
11240 (Qhelp_form_show): New var.
e0d38eeb 11241 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11242
11243 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11244
11245 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11246
e67a13ab
CY
112472011-04-06 Chong Yidong <cyd@stupidchicken.com>
11248
04f2d78b
CB
11249 * process.c (Flist_processes): Remove to Lisp.
11250 (list_processes_1): Delete.
e67a13ab 11251
973f782d
EZ
112522011-04-06 Eli Zaretskii <eliz@gnu.org>
11253
7c106b1e
EZ
11254 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11255
973f782d
EZ
11256 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11257
41cf7d1a 112582011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11259
ca23cc88
PE
11260 Fix more problems found by GCC 4.6.0's static checks.
11261
f390e2d5
PE
11262 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11263
42eea0d0
PE
11264 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11265
b69769da 11266 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11267
f9541e84
PE
11268 * xdisp.c (vmessage): Mark as a printf-like function.
11269
13841b55
PE
11270 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11271
c136c10f
PE
11272 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11273
5e2d4a30
PE
11274 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11275 printf-like functions.
11276 (tiff_load): Add casts to remove these marks before passing them
11277 to system-supplied API.
11278
583f48b9
PE
11279 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11280
b25d760e
PE
11281 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11282 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11283 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11284 directly, rather than having caller test rule sign. This avoids
11285 some unnecessary tests.
11286 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11287 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11288 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11289
bc7b6697 11290 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11291 (xfont_open): Avoid unnecessary tests.
bc7b6697 11292
27ccc379
PE
11293 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11294
dcd5c89a
PE
11295 * composite.h, composite.c (composition_gstring_put_cache):
11296 Use EMACS_INT, not int, for length.
11297
b13a45c6
PE
11298 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11299 breaking out part of COMPOSITION_DECODE_RULE.
11300 (COMPOSITION_DECODE_RULE): Use it.
11301 * composite.c (get_composition_id): Remove unused local vars,
11302 by using the new macro.
11303
1e792e4d
PE
11304 * textprop.c (set_text_properties_1): Change while to do-while,
11305 since the condition is always true at first.
11306
dc6c6455 11307 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11308 (interval_deletion_adjustment): Return unsigned value.
11309 All uses changed.
dc6c6455 11310
aba7731a
PE
11311 * process.c (list_processes_1, create_pty, read_process_output):
11312 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11313 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11314 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11315 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11316 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11317
fdfc4bf3
PE
11318 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11319
fca8fe46 11320 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11321 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11322
06a0259a 11323 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11324 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11325 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11326
e7b9e80f
PE
11327 * print.c (print_error_message): Avoid int overflow.
11328
56201685
PE
11329 * font.c (font_list_entities): Redo for clarity,
11330 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11331
78834453 11332 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11333 (font_score): Avoid potential overflow in diff calculation.
78834453 11334
0bc0b309 11335 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11336 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11337
e610eaca
PE
11338 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11339
b895abce
PE
11340 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11341 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11342 can always succeed if overflow has undefined behavior.
11343
1f1d9321 11344 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11345 (wordify): Omit three unnecessary tests.
1f1d9321 11346
c59478bc
PE
11347 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11348 All callers changed. This avoids the need for an unused var.
11349
79b73827
PE
11350 * casefiddle.c (casify_region): Remove var that is set but not used.
11351
a4db5dfe
PE
11352 * dired.c (file_name_completion): Remove var that is set but not used.
11353
43aae36e
PE
11354 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11355
2a47c44d 11356 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11357 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11358
a37c69bf
PE
11359 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11360 Check for integer overflow on size calculations.
11361
328ab8e7
PE
11362 * buffer.c (Fprevious_overlay_change): Remove var that is set
11363 but not used.
11364
e5a2a5cb
PE
11365 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11366 Remove vars that are set but not used.
8d84a6eb 11367 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11368 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11369
a60e5f68
PE
11370 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11371
f661cb61 11372 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11373 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11374
f0397f5a
PE
11375 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11376 that are set but not used.
11377
8664db06 11378 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11379 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11380
6abdaa4a
PE
11381 * xselect.c (x_get_local_selection, x_handle_property_notify):
11382 Remove vars that are set but not used.
11383
0ce7538d 11384 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11385 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11386
9ae848fc
PE
11387 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11388 Remove var that is set but not used.
0b918413
PE
11389 (scroll_bar_windows_size): Now size_t, not int.
11390 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11391 Check for overflow.
9ae848fc 11392
a5a62657
PE
11393 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11394 (map_tty_color) [!defined MSDOS]: Likewise.
11395
5c5cdd39
PE
11396 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11397
66ebf983
PE
11398 * coding.c: Remove vars that are set but not used.
11399 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11400 All callers changed.
11401 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11402 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11403 (decode_coding_charset): Remove vars that are set but not used.
11404
1be4d761
PE
11405 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11406 that is set but not used.
11407
47553fa8
PE
11408 * print.c (print_object): Remove var that is set but not used.
11409
1f7196bf 11410 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11411 The gnulib version avoids calling malloc in the usual case,
11412 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11413 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11414 * filelock.c (current_lock_owner): Likewise.
11415 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11416 * sysdep.c: Include allocator.h, careadlinkat.h.
11417 (emacs_no_realloc_allocator): New static constant.
11418 (emacs_readlink): New function.
fdb61804
PE
11419 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11420 ../lib/careadlinkat.h.
d1fdcab7 11421
f84c17c7
SM
114222011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11423
11424 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11425 first non-nil return value).
11426
ef3862ad
JD
114272011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11428
11429 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11430 if not defined (Bug#8403).
11431
376a7006
JB
114322011-04-02 Juanma Barranquero <lekktu@gmail.com>
11433
11434 * xdisp.c (display_count_lines): Remove parameter `start',
11435 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11436 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11437 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11438 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11439 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11440 and thereabouts. All callers changed.
11441 (get_per_char_metric): Remove parameter `f', unused since
11442 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11443
6ca3801d
JM
114442011-04-02 Jim Meyering <meyering@redhat.com>
11445
11446 do not dereference NULL upon failed strdup
11447 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11448 (ns_get_family): Likewise.
11449
d8e2b5ba
JB
114502011-04-02 Juanma Barranquero <lekktu@gmail.com>
11451
11452 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11453
8c74fcbd
JD
114542011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11455
11456 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11457 later (Bug#8403).
11458
7200d79c
SM
114592011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11460
03408648 11461 Add lexical binding.
7200d79c 11462
03408648
SM
11463 * window.c (Ftemp_output_buffer_show): New fun.
11464 (Fsave_window_excursion):
11465 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11466
11467 * lread.c (lisp_file_lexically_bound_p): New function.
11468 (Fload): Bind Qlexical_binding.
11469 (readevalloop): Remove `evalfun' arg.
11470 Bind Qinternal_interpreter_environment.
11471 (Feval_buffer): Bind Qlexical_binding.
11472 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11473 Mark as dynamic.
11474 (syms_of_lread): Declare `lexical-binding'.
11475
11476 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11477
11478 * keyboard.c (eval_dyn): New fun.
11479 (menu_item_eval_property): Use it.
ca105506
SM
11480
11481 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11482
03408648
SM
11483 * fns.c (concat, mapcar1): Accept byte-code-functions.
11484
11485 * eval.c (Fsetq): Handle lexical vars.
11486 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11487 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11488 (FletX, Flet): Obey lexical binding.
11489 (Fcommandp): Handle closures.
11490 (Feval): New `lexical' arg.
11491 (eval_sub): New function extracted from Feval. Use it almost
11492 everywhere where Feval was used. Look up vars in lexical env.
11493 Handle closures.
11494 (Ffunctionp): Move from subr.el.
11495 (Ffuncall): Handle closures.
11496 (apply_lambda): Remove `eval_flags'.
11497 (funcall_lambda): Handle closures and new byte-code-functions.
11498 (Fspecial_variable_p): New function.
11499 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11500 but without exporting it to Lisp.
23aba0ea 11501
23aba0ea 11502 * doc.c (Fdocumentation, store_function_docstring):
03408648 11503 * data.c (Finteractive_form): Handle closures.
23aba0ea 11504
03408648
SM
11505 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11506 interactive spec.
ba83908c 11507
04f2d78b
CB
11508 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11509 New byte-codes.
03408648
SM
11510 (exec_byte_code): New function extracted from Fbyte_code to handle new
11511 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11512
03408648 11513 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11514
03408648 11515 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11516
e2abce01
JB
115172011-03-31 Juanma Barranquero <lekktu@gmail.com>
11518
11519 * xdisp.c (redisplay_internal): Fix prototype.
11520
63696a73 115212011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11522
63696a73 11523 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11524 (try_scrolling): Use it when setting scroll_limit.
11525 Limit scrolling to 100 screen lines.
63696a73
EZ
11526 (redisplay_window): Even when falling back on "recentering",
11527 position point in the window according to scroll-conservatively,
11528 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11529
11530 (try_scrolling): When point is above the window, allow searching
11531 as far as scroll_max, or one screenful, to compute vertical
11532 distance from PT to the scroll margin position. This prevents
11533 try_scrolling from unnecessarily failing when
11534 scroll-conservatively is set to a value slightly larger than the
11535 window height. Clean up the case of PT below the margin at bottom
11536 of window: scroll_max can no longer be INT_MAX. When aggressive
11537 scrolling is in use, don't let point enter the opposite scroll
11538 margin as result of the scroll.
11539 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11540 threshold of 100 lines for never-recentering scrolling.
11541
e4cc2dfc
JB
115422011-03-31 Juanma Barranquero <lekktu@gmail.com>
11543
11544 * dispextern.h (move_it_by_lines):
11545 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11546 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11547 (message_log_check_duplicate): Remove parameters `prev_bol' and
11548 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11549 (redisplay_internal): Remove parameter `preserve_echo_area',
11550 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11551
11552 * indent.c (Fvertical_motion):
11553 * window.c (window_scroll_pixel_based, Frecenter):
11554 Don't pass `need_y_p' to `move_it_by_lines'.
11555
1c470562
SM
115562011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11557
44f230aa
SM
11558 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11559 steal a few bits to be more compact.
11560 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11561 Remove unneeded casts.
11562
1c470562
SM
11563 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11564
888adce9
ZK
115652011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11566
11567 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11568 binding" message (bug#7967).
11569
f838ed7b
PE
115702011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11571
77861b95
PE
11572 Fix more problems found by GCC 4.6.0's static checks.
11573
de6dbc14
PE
11574 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11575 Remove unused local var.
11576
f838ed7b
PE
11577 * editfns.c (Fmessage_box): Remove unused local var.
11578
792c7b2b
PE
11579 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11580 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11581 Omit unused local vars.
c499e557 11582 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11583 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11584 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11585 Omit unused local var.
11586
ba0165e1
PE
11587 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11588 Don't assume string length fits in int.
32ad8845 11589 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11590 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11591
3c59b4c9
PE
11592 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11593 instead of alloca (Bug#8344).
11594
a3eed478 11595 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11596 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11597
eb4d412d
PE
11598 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11599
1658b401
PE
11600 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11601 concerns.
11602
11603 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11604
11605 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11606
9a2c6e05
PE
11607 * keyboard.c (syms_of_keyboard): Use the same style as later
11608 in this function when indexing through an array. This also
11609 works around GCC bug 48267.
11610
03d0a109
PE
11611 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11612
44f730c8
PE
11613 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11614
fe75f926
PE
11615 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11616 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11617
ffa8c828
PE
11618 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11619 This avoids undefined behavior on integer overflow, and is a bit
11620 more convenient anyway since it is compared to a size_t variable.
11621
c5101a77
PE
11622 Variadic C functions now count arguments with size_t, not int.
11623 This avoids an unnecessary limitation on 64-bit machines, which
11624 caused (substring ...) to crash on large vectors (Bug#8344).
11625 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11626 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11627 All variadic functions and their callers changed accordingly.
c5101a77
PE
11628 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11629 * data.c (arith_driver, float_arith_driver): Likewise.
11630 * editfns.c (general_insert_function): Likewise.
11631 * eval.c (struct backtrace.nargs, interactive_p)
11632 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11633 (funcall_lambda, mark_backtrace): Likewise.
11634 * fns.c (concat): Likewise.
11635 * frame.c (x_set_frame_parameters): Likewise.
11636 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11637 0 if not found, not -1. All callers changed.
11638
dd3f25f7
PE
11639 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11640 (stack_copy_size): Now size_t, not int.
11641 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11642
461c2ab9
JB
116432011-03-28 Juanma Barranquero <lekktu@gmail.com>
11644
11645 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11646 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11647 All callers changed.
11648
11649 * lisp.h (multibyte_char_to_unibyte):
11650 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11651 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11652 * character.h (CHAR_TO_BYTE8):
11653 * cmds.c (internal_self_insert):
11654 * editfns.c (general_insert_function):
11655 * keymap.c (push_key_description):
11656 * search.c (Freplace_match):
11657 * xdisp.c (message_dolog, set_message_1): All callers changed.
11658
f6d62986
SM
116592011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11660
11661 * keyboard.c (safe_run_hook_funcall): New function.
11662 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11663 don't set the hook to nil, but remove the offending function instead.
11664 (Qcommand_hook_internal): Remove, unused.
11665 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11666 Vcommand_hook_internal.
11667
11668 * eval.c (enum run_hooks_condition): Remove.
11669 (funcall_nil, funcall_not): New functions.
11670 (run_hook_with_args): Call each function through a `funcall' argument.
11671 Remove `cond' argument, now redundant.
11672 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11673 (Frun_hook_with_args_until_failure): Adjust accordingly.
11674 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11675
1db5b1ad
JB
116762011-03-28 Juanma Barranquero <lekktu@gmail.com>
11677
11678 * dispextern.h (string_buffer_position): Remove declaration.
11679
11680 * print.c (strout): Remove parameter `multibyte', unused since
11681 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11682
11683 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11684 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11685 All callers changed.
11686
11687 * w32.c (_wsa_errlist): Use braces for struct initializers.
11688
11689 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11690 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11691 All callers changed.
11692 (string_buffer_position): Likewise. Also, make static (it's never
11693 used outside xdisp.c).
11694 (cursor_row_p): Remove parameter `w', unused since
11695 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11696 (decode_mode_spec): Remove parameter `precision', introduced during
11697 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11698 All callers changed.
11699
5ffb62aa
JD
117002011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11701
11702 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11703
461c2ab9 117042011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11705
11706 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11707 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11708 (ns_update_auto_hide_menu_bar): New functions.
11709 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11710 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11711 ns_constrain_all_frames.
11712 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11713 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11714
5c380ffb
JD
117152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11716
11717 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11718
9af30bdf
GM
117192011-03-27 Glenn Morris <rgm@gnu.org>
11720
11721 * syssignal.h: Replace RETSIGTYPE with void.
11722 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11723 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11724 Replace SIGTYPE with void everywhere.
11725 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11726 * s/template.h (SIGTYPE): Remove commented out definition.
11727
e2abce01
JB
117282011-03-26 Eli Zaretskii <eliz@gnu.org>
11729
11730 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11731 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11732
f868cd8a
JB
117332011-03-26 Juanma Barranquero <lekktu@gmail.com>
11734
59eb0929
JB
11735 * w32.c (read_unc_volume): Use parameter `henum', instead of
11736 global variable `wget_enum_handle'.
11737
11738 * keymap.c (describe_vector): Remove parameters `indices' and
11739 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11740 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11741
f868cd8a
JB
11742 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11743
11744 * keyboard.c (timer_check): Remove parameter `do_it_now',
11745 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11746 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11747 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11748
11749 * keyboard.c (read_char):
11750 * w32menu.c (w32_menu_display_help):
11751 * xmenu.c (show_help_event, menu_help_callback):
11752 Adjust calls to `show_help_echo'.
11753
11754 * gtkutil.c (xg_maybe_add_timer):
11755 * keyboard.c (readable_events):
11756 * process.c (wait_reading_process_output):
11757 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11758
11759 * insdel.c (adjust_markers_gap_motion):
11760 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11761 (gap_left, gap_right): Don't call it.
11762
2ecf6fdb
CY
117632011-03-25 Chong Yidong <cyd@stupidchicken.com>
11764
11765 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11766 incurred during fontification.
11767
6b1f9ba4
JB
117682011-03-25 Juanma Barranquero <lekktu@gmail.com>
11769
11770 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11771 (DEFVAR_PER_BUFFER): Don't pass it.
11772
11773 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11774 (scrolling_window): Don't pass it.
11775
0f4a96b5
JB
117762011-03-25 Juanma Barranquero <lekktu@gmail.com>
11777
11778 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11779
11780 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11781 and `suffix'.
11782 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11783 of variables specific to SELinux and computation of `encoded_absname'.
11784
11785 * image.c (XPutPixel): Remove unused variable `height'.
11786
11787 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11788
11789 * unexw32.c (get_section_info): Remove unused variable `section'.
11790
11791 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11792 (system_process_attributes): Remove unused variable `sess'.
11793 (sys_read): Remove unused variable `err'.
11794
11795 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11796 (w32_wnd_proc): Remove unused variable `isdead'.
11797 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11798 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11799 (x_create_tip_frame): Remove unused variable `tem'.
11800
11801 * w32inevt.c (w32_console_read_socket):
11802 Remove unused variable `no_events'.
11803
11804 * w32term.c (x_draw_composite_glyph_string_foreground):
11805 Remove unused variable `width'.
11806
1149507c
JB
118072011-03-24 Juanma Barranquero <lekktu@gmail.com>
11808
11809 * w32term.c (x_set_glyph_string_clipping):
11810 Don't pass uninitialized region to CombineRgn.
11811
9c88f339
JB
118122011-03-23 Juanma Barranquero <lekktu@gmail.com>
11813
11814 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11815 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11816 (Fx_close_connection): Remove unused variable `i'.
11817
11818 * w32font.c (w32font_draw): Return number of glyphs.
11819 (w32font_open_internal): Remove unused variable `i'.
11820 (w32font_driver): Add missing initializer.
11821
11822 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11823 (fill_in_menu): Remove unused variable `items_added'.
11824
11825 * w32term.c (last_mouse_press_frame): Remove static global variable.
11826 (w32_clip_to_row): Remove unused variable `f'.
11827 (x_delete_terminal): Remove unused variable `i'.
11828
11829 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11830 (NOTHING): Remove unused static global variable.
11831 (uniscribe_check_otf): Remove unused variable `table'.
11832 (uniscribe_font_driver): Add missing initializers.
11833
dee091a3
JD
118342011-03-23 Julien Danjou <julien@danjou.info>
11835
11836 * term.c (Fsuspend_tty, Fresume_tty):
11837 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11838 * window.c (temp_output_buffer_show):
11839 * insdel.c (signal_before_change):
11840 * frame.c (Fhandle_switch_frame):
11841 * fileio.c (Fdo_auto_save):
11842 * emacs.c (Fkill_emacs):
11843 * editfns.c (save_excursion_restore):
11844 * cmds.c (internal_self_insert):
11845 * callint.c (Fcall_interactively):
11846 * buffer.c (Fkill_all_local_variables):
11847 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11848 Use Frun_hooks.
0f4a96b5 11849 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11850 unconditionally since it does the check itself.
dee091a3 11851
2c520ab5 118522011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11853
c9c49752
PE
11854 Fix more problems found by GCC 4.5.2's static checks.
11855
8abc3f12
PE
11856 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11857 the first time through the loop, since we know p0 < p1 then.
11858 This also avoids a gcc -Wstrict-overflow warning.
11859
a2d26660
PE
11860 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11861 leading to a memory leak, possible in functions like
11862 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11863 of objects (Bug#8318).
a2d26660 11864
916c72e9
PE
11865 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11866 that could (at least in theory) be that large.
11867
19ab8a18
PE
11868 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11869 This is less likely to overflow, and avoids undefined behavior if
11870 overflow does occur. All callers changed. Use strtoul to scan
11871 for the unsigned long integer.
b7cbbd6f
PE
11872 (pint2hrstr): Simplify and tune code slightly.
11873 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11874
f0641eff
PE
11875 * scroll.c (do_scrolling): Work around GCC bug 48228.
11876 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11877
7f650bb9
PE
11878 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11879 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11880 (validate_x_resource_name): Simplify count usage.
11881 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11882
37dd57d1
PE
11883 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11884 fail (Bug#8306).
81e56e61 11885
699979fc 11886 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11887
401bf9b4
PE
11888 * process.c (Fmake_network_process): Use socklen_t, not int,
11889 where POSIX says socklen_t is required in portable programs.
11890 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11891 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11892 (Fmake_network_process, server_accept_connection):
11893 (wait_reading_process_output, read_process_output):
11894 Likewise.
11895
b93aacde
PE
11896 * process.c: Rename or move locals to avoid shadowing.
11897 (list_processes_1, Fmake_network_process):
11898 (read_process_output_error_handler, exec_sentinel_error_handler):
11899 Rename or move locals.
4dc343ee 11900 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11901 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11902 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11903 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11904 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11905
af8a867c 11906 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11907 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11908 Include tparam.h instead, since it declares them.
af8a867c
PE
11909 * cm.h (PC): Remove extern decl; tparam.h now does this.
11910 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11911 * terminfo.c: Include tparam.h, to check interfaces.
11912 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11913 (tparam): Adjust signature to match interface in tparam.h;
11914 this removes some undefined behavior. Check that outstring and len
11915 are zero, which they always are with Emacs.
11916 * tparam.h (PC, BC, UP): New extern decls.
11917
0248044d 11918 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11919 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11920
8ff096c1 11921 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11922 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11923 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11924 (ftfont_list): Remove unused local.
49eaafba
PE
11925 (get_adstyle_property, ftfont_pattern_entity):
11926 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11927 Rename locals to avoid shadowing.
8ff096c1 11928
e2be39f6
PE
11929 * xfont.c (xfont_list_family): Mark var as initialized.
11930
c9735e30
PE
11931 * xml.c (make_dom): Now static.
11932
8f5201ae
PE
11933 * composite.c (composition_compute_stop_pos): Rename local to
11934 avoid shadowing.
b246f932
PE
11935 (composition_reseat_it): Remove unused locals.
11936 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11937 (composition_update_it): Mark var as initialized.
11b61122
PE
11938 (find_automatic_composition): Mark vars as initialized,
11939 with a FIXME (Bug#8290).
8f5201ae 11940
760fbc2c
PE
11941 character.h: Rename locals to avoid shadowing.
11942 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11943 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11944 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11945 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11946 to avoid shadowing.
11947
ff08eb85
PE
11948 * textprop.c (property_change_between_p): Remove; unused.
11949
fc7bf025
PE
11950 * intervals.c (interval_start_pos): Now static.
11951
235d7abc
PE
11952 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11953
44f230aa
SM
11954 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11955 Rename locals to avoid shadowing.
3e7d6594 11956
50060332
PE
11957 * sound.c (wav_play, au_play, Fplay_sound_internal):
11958 Fix pointer signedness.
d01f234b 11959 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11960 (wav_play): Initialize a variable to 0, to prevent undefined
11961 behavior (Bug#8278).
50060332 11962
c4fc4e30
PE
11963 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11964
918436ed
PE
11965 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11966
c939f91b
PE
11967 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11968 clobbering (Bug#8298).
b9c7f648
PE
11969 * sysdep.c (sys_subshell): Likewise.
11970 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11971
6bd8c144
PE
11972 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11973 This should get cleaned up, so that child_setup has the
11974 same signature on all platforms.
11975
7710357c 11976 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11977 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11978
c59da222
CY
119792011-03-22 Chong Yidong <cyd@stupidchicken.com>
11980
11981 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11982 not to be necessary, and produces flickering.
11983
66b87493
GM
119842011-03-20 Glenn Morris <rgm@gnu.org>
11985
11986 * config.in: Remove file.
11987
45b6f6d5
JB
119882011-03-20 Juanma Barranquero <lekktu@gmail.com>
11989
11990 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11991 are now in src/globals.h.
11992 (syms_of_minibuf): Remove spurious & from previous change.
11993
cd394be1 119942011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11995
11996 * minibuf.c (completing-read-function): New variable.
11997 (completing-read-default): Rename from completing-read.
11998 (completing-read): Call completing-read-function.
11999
b14e3e21
CY
120002011-03-19 Juanma Barranquero <lekktu@gmail.com>
12001
12002 * xfaces.c (Fx_load_color_file):
12003 Read color file from absolute filename (bug#8250).
12004
f2b726e6
JB
120052011-03-19 Juanma Barranquero <lekktu@gmail.com>
12006
12007 * makefile.w32-in: Update dependencies.
12008
09f6ff02
EZ
120092011-03-17 Eli Zaretskii <eliz@gnu.org>
12010
12011 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12012
29a6015a
PE
120132011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12014
a3a6c54e
PE
12015 Fix more problems found by GCC 4.5.2's static checks.
12016
b766f867
PE
12017 * process.c (make_serial_process_unwind, send_process_trap):
12018 (sigchld_handler): Now static.
12019
be02381c
PE
12020 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12021 That way, the code declares only the vars that it needs.
12022 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12023 * s/cygwin.h (PTY_ITERATION): Likewise.
12024 * s/darwin.h (PTY_ITERATION): Likewise.
12025 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12026
57048744
PE
12027 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12028 * process.c (allocate_pty): Don't declare stb unless it's needed.
12029
7914961c 12030 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12031 (CONSTANTLIM): Remove; unused.
12032 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12033 Define only if needed.
7914961c 12034
b3967b18
PE
12035 * unexelf.c (unexec): Name an expression,
12036 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12037 Use a different way to cause a compilation error if anyone uses
12038 n rather than nn, a way that does not involve shadowing.
73366a00 12039 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12040
29a6015a
PE
12041 * deps.mk (unexalpha.o): Remove; unused.
12042
43cfc33e 12043 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12044 * unexec.h: New file.
ce701a33
PE
12045 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12046 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12047 Depend on unexec.h.
12048 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12049 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12050 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12051 Change as necessary to match prototype in unexec.h.
ce701a33 12052
01f44d5a
PE
12053 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12054 shadowing.
4f63c6bb 12055 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12056
a6670b0b
PE
12057 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12058 Rename locals to avoid shadowing.
12059
cef2010d 12060 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12061 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12062
d4d7173a
PE
12063 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12064
f08b802a
PE
12065 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12066 warning when compiling print.c.
12067
3ddb0639
PE
12068 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12069 instead of using an uninitialized var.
5ad03b97 12070 (font_sort_entities): Mark var as initialized.
3ddb0639 12071
170a2692
PE
12072 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12073
e663c700
PE
12074 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12075 pointers to constants.
89bc529a 12076 (font_parse_fcname): Remove unused vars.
7b81e2d0 12077 (font_delete_unmatched): Now static.
ea838e10 12078 (font_get_spec): Remove; unused.
13a547c6
PE
12079 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12080 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12081 Rename or move locals to avoid shadowing.
e663c700 12082
2a80c887 12083 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12084 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12085
1384fa33 12086 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12087 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12088
8b2c52e9
PE
12089 * alloc.c (mark_backtrace): Move decl from here ...
12090 * lisp.h: ... to here, so that it can be checked.
12091
475545b5 12092 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12093 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12094 (lisp_indirect_variable): Name an expression,
12095 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12096 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12097
b1349114 12098 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12099 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12100 Use const pointer when appropriate.
b1349114 12101
a2928364
PE
12102 * lisp.h (get_system_name, get_operating_system_release):
12103 Move decls here, to check interfaces.
12104 * process.c (get_operating_system_release): Move decl to lisp.h.
12105 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12106 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12107 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12108 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12109 (Fformat_time_string, Fencode_time, Finsert_char):
12110 (Ftranslate_region_internal, Fformat):
12111 Rename or remove local vars to avoid shadowing.
9710023e 12112 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12113
a415e694
PE
12114 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12115 avoid shadowing.
12116
8ef4622d
PE
12117 * lisp.h (eassert): Check that the argument compiles, even if
12118 ENABLE_CHECKING is not defined.
12119
946f9a5b
PE
12120 * data.c (Findirect_variable): Name an expression, to avoid
12121 gcc -Wbad-function-cast warning.
112396d6 12122 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12123 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12124 (Fmake_variable_buffer_local, Fmake_local_variable):
12125 Mark variables as initialized.
52746918 12126 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12127
e5aab7e7 12128 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12129 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12130 Rename locals to avoid shadowing.
dff45157
PE
12131 (mark_stack): Move local variables into the #ifdef region where
12132 they're used.
7bc26fdb
PE
12133 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12134 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12135 needed otherwise.
12136 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12137 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12138 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12139
e5aab7e7
PE
12140 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12141 avoids undefined behavior in theory.
12142
4da60324
PE
12143 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12144
88043301
PE
12145 Use functions, not macros, for up- and down-casing (Bug#8254).
12146 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12147 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12148 to use the following functions instead of these macros.
12149 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12150 EMACS_INT, since callers assume the returned value fits in int.
12151 (upcase1): Likewise, for UPCASE_TABLE.
12152 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12153 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12154 the race-condition problem in the old DOWNCASE.
88043301 12155
19ed5445
PE
12156 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12157 Rename locals to avoid shadowing.
12158 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12159 (regex_compile, re_search_2, re_match_2_internal):
12160 Remove unused local vars.
952db0d7
PE
12161 (FREE_VAR): Rewrite so as not to use empty "else",
12162 which gcc can warn about.
da053e48 12163 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12164 (RETALLOC_IF): Define only if needed.
12165 (WORDCHAR_P): Likewise. This one is never needed, but is used
12166 only in a comment talking about a compiler bug, so put inside
12167 the #if 0 of that comment.
12168 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12169 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12170 Remove; unused.
19ed5445 12171
1f3561e4 12172 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12173 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12174 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12175
ded6f8f7
PE
12176 * search.c (simple_search): Remove unused var.
12177
dbd37a95
PE
12178 * dired.c (compile_pattern): Move decl from here ...
12179 * lisp.h: ... to here, so that it can be checked.
12180 (struct re_registers): New forward decl.
12181
7e47afad
PE
12182 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12183
85f24f61
PE
12184 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12185 All uses changed.
12186 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12187 Rename locals to avoid shadowing.
5671df8f 12188 (Fvertical_motion): Mark locals as initialized.
85f24f61 12189
181aa2be 12190 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12191 (casify_region): Mark local as initialized.
181aa2be 12192
930d429c
PE
12193 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12194
7082eac6
PE
12195 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12196 New macros, so that the caller can use some names other than
12197 gcpro1, gcpro2, etc.
12198 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12199 of the new macros.
12200 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12201 argument, for consistency with GCPRO2_VAR, etc: it is now the
12202 prefix of the variable, not the variable itself. All uses
12203 changed.
38b2c076
PE
12204 * dired.c (directory_files_internal, file_name_completion):
12205 Rename locals to avoid shadowing.
12206
15206ed9
PE
12207 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12208 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12209 dired.c's scmp function, had undefined behavior.
12210 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12211 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12212 * buffer.h: ... to here, because these macros use current_buffer,
12213 and the new implementation with inline functions needs to have
12214 current_buffer in scope now, rather than later when the macros
12215 are used.
12216 (downcase, upcase1): New static inline functions.
12217 (DOWNCASE, UPCASE1): Reimplement using these functions.
12218 This avoids undefined behavior in expressions like
12219 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12220 from race conditions in accessing the global variables
12221 case_temp1 and case_temp2.
12222 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12223 * lisp.h (case_temp1, case_temp2): Remove their decls.
12224 * character.h (ASCII_CHAR_P): Move from here ...
12225 * lisp.h: ... to here, so that the inline functions mentioned
12226 above can use them.
12227
4a6bea26
PE
12228 * dired.c (directory_files_internal_unwind): Now static.
12229
f14b7e14
PE
12230 * fileio.c (file_name_as_directory, directory_file_name):
12231 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12232 Now static.
2893f146
PE
12233 (file_name_as_directory): Use const pointers when appropriate.
12234 (Fexpand_file_name): Likewise. In particular, newdir might
12235 point at constant storage, so make it a const pointer.
fd4ead52 12236 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12237 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12238 signedness issues.
f839df0c
PE
12239 (Fset_file_times, Finsert_file_contents, auto_save_error):
12240 Rename locals to avoid shadowing.
f14b7e14 12241
5716756e 12242 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12243 (Ftry_completion, Fall_completions): Rename or remove locals
12244 to avoid shadowing.
5716756e 12245
b4c3046a
PE
12246 * marker.c (bytepos_to_charpos): Remove; unused.
12247
b45db522
PE
12248 * lisp.h (verify_bytepos, count_markers): New decls,
12249 so that gcc does not warn that these functions aren't declared.
12250
85876d07
PE
12251 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12252 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12253 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12254 (copy_text): Remove unused local var.
85876d07 12255
03d78a21 12256 * filelock.c (within_one_second): Now static.
b3dd38ab 12257 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12258
5df8f01b
PE
12259 * buffer.c (fix_overlays_before): Mark locals as initialized.
12260 (fix_start_end_in_overlays): Likewise. This function should be
12261 simplified by using pointers-to-pointers, but that's a different
12262 matter.
b1d876f1 12263 (switch_to_buffer_1): Now static.
8f54f30a
PE
12264 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12265 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12266
a70072c9 12267 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12268 Fix pointer signedness issue.
edced198
PE
12269 (sys_subshell): Mark local as volatile if checking for lint,
12270 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12271 (MAXPATHLEN): Define only if needed.
a70072c9 12272
a0977c44
PE
12273 * process.c (serial_open, serial_configure): Move decls from here ...
12274 * systty.h: ... to here, so that they can be checked.
12275
a884fdcc
PE
12276 * fns.c (get_random, seed_random): Move extern decls from here ...
12277 * lisp.h: ... to here, so that they can be checked.
12278
604efe86 12279 * sysdep.c (reset_io): Now static.
b8950c94 12280 (wait_for_termination_signal): Remove; unused.
604efe86 12281
38fc62d9
PE
12282 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12283 (copy_keymap_item, append_key, push_text_char_description):
12284 Now static.
1004a21a 12285 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12286 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12287 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12288 (describe_map_tree):
12289 Rename locals to avoid shadowing.
38fc62d9 12290
2f2650da
PE
12291 * keyboard.c: Declare functions static if they are not used elsewhere.
12292 (echo_char, echo_dash, cmd_error, top_level_2):
12293 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12294 (read_char, kbd_buffer_get_event, make_lispy_position):
12295 (make_lispy_event, make_lispy_movement, apply_modifiers):
12296 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12297 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12298 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12299 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12300 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12301
a053e86c 12302 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12303 (mark_kboards): Move decl here ...
12304 * alloc.c (mark_kboards): ... from here.
a053e86c 12305
4752793e
PE
12306 * lisp.h (force_auto_save_soon): New decl.
12307
74f10ca7 12308 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12309 (DEFINE_DUMMY_FUNCTION): New macro.
12310 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12311 Use it.
c03cd23f
PE
12312 (main): Add casts to avoid warnings
12313 if GCC considers string literals to be constants.
74f10ca7 12314
022e70d4
PE
12315 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12316
59d6fe83
PE
12317 * dbusbind.c: Pointer signedness fixes.
12318 (xd_signature, xd_append_arg, xd_initialize):
12319 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12320 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12321 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12322 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12323
78320123
PE
12324 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12325 if GCC considers string literals to be constants.
49cebcca 12326 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12327
35ac2a97
SM
123282011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12329
fb103ca9
SM
12330 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12331 (print_preprocess, print_object): New macro to fix last change.
12332
35ac2a97
SM
12333 * print.c (print_preprocess): Don't forget font objects.
12334
62973b41
JB
123352011-03-16 Juanma Barranquero <lekktu@gmail.com>
12336
12337 * emacs.c (USAGE3): Doc fixes.
12338
0e48bb22
AS
123392011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12340
12341 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12342 structure.
12343
7684e57b
JB
123442011-03-14 Juanma Barranquero <lekktu@gmail.com>
12345
12346 * lisp.h (VWindow_system, Qfile_name_history):
12347 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12348 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12349 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12350
12351 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12352 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12353
12354 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12355 * w32console.c (detect_input_pending, read_input_pending)
12356 (encode_terminal_code):
12357 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12358 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12359 (w32_system_caret_y, Qfile_name_history):
12360 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12361 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12362 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12363 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12364 * w32proc.c (Qlocal, report_file_error):
12365 * w32term.c (Vwindow_system, updating_frame):
12366 * w32uniscribe.c (initialized, uniscribe_font_driver):
12367 Remove unneeded extern declarations.
12368
2aa46d6c
CY
123692011-03-14 Chong Yidong <cyd@stupidchicken.com>
12370
c96bbc66 12371 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12372
cffc6f3b
CY
123732011-03-13 Chong Yidong <cyd@stupidchicken.com>
12374
12375 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12376 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12377 These macros can no longer be used for assignment.
12378
44f230aa
SM
12379 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12380 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12381 (record_buffer_markers, fetch_buffer_markers): New functions for
12382 recording and fetching special buffer markers.
12383 (set_buffer_internal_1, set_buffer_temp): Use them.
12384
12385 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12386
12387 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12388
12389 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12390 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12391
12392 * xdisp.c (hscroll_window_tree):
12393 (reconsider_clip_changes): Use PT instead of BUF_PT.
12394
d251f04b
EZ
123952011-03-13 Eli Zaretskii <eliz@gnu.org>
12396
12397 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12398 $(EMACS_ROOT)/lib/intprops.h.
12399
f0c77cd1
PE
124002011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12401
3eca4629
PE
12402 Fix more problems found by GCC 4.5.2's static checks.
12403
7c86ee98
PE
12404 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12405 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12406 (xg_free_frame_widgets): Make it clear that a local variable is
12407 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12408 (gdk_window_get_screen): Make it clear that this macro is needed
12409 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12410 (int_gtk_range_get_value): New function, which avoids a diagnostic
12411 from gcc -Wbad-function-cast.
12412 (xg_set_toolkit_scroll_bar_thumb): Use it.
12413 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12414 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12415 (get_utf8_string, xg_get_file_with_chooser):
12416 Rename locals to avoid shadowing.
12417 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12418
41729b81
PE
12419 * xgselect.c (xg_select): Remove unused var.
12420
f0c77cd1
PE
12421 * image.c (four_corners_best): Mark locals as initialized.
12422 (gif_load): Initialize transparent_p to zero (Bug#8238).
12423 Mark another local as initialized.
ec6cf4c6 12424 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12425
ce0ad53d 12426 * image.c (clear_image_cache): Now static.
d5d5a617 12427 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12428 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12429 (x_edge_detection): Remove unnecessary cast that
12430 gcc -Wbad-function-cast diagnoses.
2037898d 12431 (gif_load): Fix pointer signedness.
6ae141d6
PE
12432 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12433 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12434
33383987 124352011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12436
d32df629
PE
12437 Improve quality of tests for time stamp overflow.
12438 For example, without this patch (encode-time 0 0 0 1 1
12439 1152921504606846976) returns the obviously-bogus value (-948597
12440 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12441 reports time overflow. See
12442 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12443 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12444 * editfns.c: Include limits.h and intprops.h.
12445 (TIME_T_MIN, TIME_T_MAX): New macros.
12446 (time_overflow): Move earlier, to before first use.
12447 (hi_time, lo_time): New functions, for an accurate test for
12448 out-of-range times.
12449 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12450 (Fget_internal_run_time): Don't assume time_t fits in int.
12451 (make_time): Use list2 instead of Fcons twice.
12452 (Fdecode_time): More accurate test for out-of-range times.
12453 (check_tm_member): New function.
12454 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12455 (lisp_time_argument): Don't rely on undefined left-shift and
12456 right-shift behavior when checking for time stamp overflow.
8be6f318 12457
fe31d94c
PE
12458 * editfns.c (time_overflow): New function, refactoring common code.
12459 (Fformat_time_string, Fdecode_time, Fencode_time):
12460 (Fcurrent_time_string): Use it.
12461
8be6f318
PE
12462 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12463 * dired.c (make_time): Move to ...
12464 * editfns.c (make_time): ... here.
12465 * systime.h: Note the move.
12466
09d9db2c 124672011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12468
126bc0dc
YM
12469 * fringe.c (update_window_fringes): Remove unused variables.
12470
c47cbdfd
YM
12471 * unexmacosx.c (copy_data_segment): Also copy __got section.
12472 (Bug#8223)
12473
7ac80be9
EZ
124742011-03-12 Eli Zaretskii <eliz@gnu.org>
12475
c96bbc66 12476 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12477 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12478 Constify `char *' arguments and their references according to
12479 prototypes in tparam.h.
12480
ecb0f94d 12481 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12482
7ac80be9
EZ
12483 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12484 Adapt all references accordingly.
12485
12486 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12487
ef1fd07e
TT
124882011-03-11 Tom Tromey <tromey@redhat.com>
12489
12490 * buffer.c (syms_of_buffer): Remove obsolete comment.
12491
7ef4b50c
EZ
124922011-03-11 Eli Zaretskii <eliz@gnu.org>
12493
12494 * termhooks.h (encode_terminal_code): Declare prototype.
12495
12496 * msdos.c (encode_terminal_code): Don't declare prototype.
12497
12498 * term.c (encode_terminal_code): Now external again, used by
12499 w32console.c and msdos.c.
12500
44f230aa
SM
12501 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12502 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12503
4b1ec863 125042011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12505
1714f52b 12506 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12507
4b1ec863
PE
12508 * fringe.c (update_window_fringes): Mark locals as initialized
12509 (Bug#8227).
12510 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12511
524c7aa6
PE
12512 * alloc.c (mark_fringe_data): Move decl from here ...
12513 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12514 to check its interface.
12515 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12516
a5c0af81 12517 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12518 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12519 (fontset_font): Mark local as initialized.
a9a06e0b 12520 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12521
b4716021
PE
12522 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12523
811e9bac 12524 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12525 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12526 (x_own_selection, Fx_disown_selection_internal): Rename locals
12527 to avoid shadowing.
12528 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12529
7e3ab302
PE
12530 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12531 so that the caller can use some name other than gcpro1.
12532 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12533 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12534 (Fx_backspace_delete_keys_p):
12535 Use them to avoid shadowing, and rename vars to avoid shadowing.
12536 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12537 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12538 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12539 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12540 Remove unused locals.
7e3ab302
PE
12541 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12542 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12543 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12544 macros.
f78faa98 12545
e2b13473
PE
12546 * xterm.h (x_mouse_leave): New decl.
12547
77f23912
PE
12548 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12549 Remove unused functions.
cdf4ba58
PE
12550 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12551 (x_calc_absolute_position): Now static.
7411c686 12552 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12553 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12554 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12555 unless they are used.
38d0b34a
PE
12556 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12557 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12558 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12559 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12560 (x_error_catcher, x_connection_closed, x_error_handler):
12561 (x_error_quitter, xembed_send_message, x_iconify_frame):
12562 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12563 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12564 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12565
44f230aa
SM
12566 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12567 Rename or move locals to avoid shadowing.
6b463e58 12568 (tty_defined_color, merge_face_heights): Now static.
5967d051 12569 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12570 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12571 does not deduce is never used uninitialized.
73719eba
PE
12572 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12573 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12574
426994c3 12575 * terminal.c (store_terminal_param): Now static.
5489860b 12576
032f1620 12577 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12578 (set_frame_menubar): Remove unused local.
d4323972 12579 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12580 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12581 since they might point to immutable storage.
281585b0
PE
12582 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12583 since it's unused otherwise.
032f1620 12584
367c19e5 12585 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12586 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12587 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12588 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12589 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12590 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12591 does not deduce are never used uninitialized.
70739cbe 12592
07b48fa9
PE
12593 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12594
8868a238 12595 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12596 * window.c (window_loop, size_window):
12597 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12598
7e5cf297 12599 * window.c (display_buffer): Now static.
d6550a9f
PE
12600 (size_window): Mark variables that gcc -Wuninitialized
12601 does not deduce are never used uninitialized.
a586633d
PE
12602 * window.h (check_all_windows): New decl, to forestall
12603 gcc -Wmissing-prototypes diagnostic.
5b555da1 12604 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12605
f6095868
PE
12606 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12607 shadowing.
12608 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12609 Include <limits.h>.
12610 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12611 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12612 (load_charset_map): Mark variables that gcc -Wuninitialized
12613 does not deduce are never used uninitialized.
53df7c11 12614 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12615
f38b440c
PE
12616 * coding.c (coding_set_source, coding_set_destination):
12617 Use "else { /* comment */ }" rather than "else /* comment */;"
12618 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12619 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12620 a block, when the outer 'i' will do.
12621 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12622 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12623 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12624 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12625 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12626 Rename locals to avoid shadowing.
12627 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12628 * coding.c (emacs_mule_char, encode_invocation_designation):
12629 Now static, since they're not used elsewhere.
413bb2db 12630 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12631 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12632 (decode_coding_emacs_mule): Mark variables that gcc
12633 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12634 (detect_coding_iso_2022): Initialize a local variable that might
12635 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12636 this initialization is needed. (Bug#8211)
5f58e762
PE
12637 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12638 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12639 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12640 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12641 Remove unused macros.
f38b440c 12642
232b38b9 12643 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12644 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12645 * character.c (string_count_byte8): Likewise.
232b38b9 12646
fb90da1b
PE
12647 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12648 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12649
fb93dbc2
PE
12650 * chartab.c (copy_sub_char_table): Now static, since it's not used
12651 elsewhere.
5c156ace
PE
12652 (sub_char_table_ref_and_range, char_table_ref_and_range):
12653 Rename locals to avoid shadowing.
bbcd0949 12654 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12655
7d3b3862 12656 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12657 (BIDI_BOB): Remove unused macro.
7d3b3862 12658
6be7d3da
PE
12659 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12660 deduce are never used uninitialized.
c2ed9c8b 12661 * term.c (encode_terminal_code): Likewise.
6be7d3da 12662
75f8807f 12663 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12664
50938595
PE
12665 * tparam.h: New file.
12666 * term.c, tparam.h: Include it.
12667 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12668 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12669 Move these decls to tparam.h, and make them agree with what
12670 is actually in tparam.c. The previous trick of using incompatible
12671 decls in different modules does not conform to the C standard.
12672 All callers of tparam changed to use tparam's actual API.
12673 * tparam.c (tparam1, tparam, tgoto):
12674 Use const pointers where appropriate.
12675
fbceeba2
PE
12676 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12677 * cm.h (struct cm): Likewise.
12678 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12679 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12680 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12681 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12682 (turn_on_face, init_tty): Likewise.
12683 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12684
7f3f1250
PE
12685 * term.c (term_mouse_position): Rename local to avoid shadowing.
12686
e6ca6543
PE
12687 * alloc.c (mark_ttys): Move decl from here ...
12688 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12689
c40f8d15
AS
126902011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12691
12692 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12693
cfe0661d
JB
126942011-03-09 Juanma Barranquero <lekktu@gmail.com>
12695
12696 * search.c (compile_pattern_1): Remove argument regp, unused since
12697 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12698 (compile_pattern): Don't pass it.
12699
0afb4571
J
127002011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12701
12702 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12703 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12704 for ! HAVE_GTK3.
12705 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12706
12707 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12708
12709 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12710 gdk_window_get_screen, gdk_window_get_geometry,
12711 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12712 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12713 (xg_get_pixbuf_from_pixmap): New function.
12714 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12715 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12716 Call xg_get_pixbuf_from_pixmap instead of
12717 gdk_pixbuf_get_from_drawable.
12718 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12719 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12720 (xg_check_special_colors): Use GtkStyleContext and its functions
12721 for HAVE_GTK3.
12722 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12723 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12724 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12725 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12726 Call gtk_widget_get_preferred_size.
0afb4571
J
12727 (xg_frame_resized): gdk_window_get_geometry only takes 5
12728 parameters.
44f230aa
SM
12729 (xg_win_to_widget, xg_event_is_for_menubar):
12730 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12731 (xg_set_widget_bg): New function.
12732 (delete_cb): New function.
895009e1 12733 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12734 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12735 (xg_set_background_color): Call xg_set_widget_bg.
12736 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12737 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12738 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12739 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12740 if ! HAVE_GTK3.
12741 (update_frame_tool_bar): Call gtk_widget_hide.
12742 (xg_initialize): Use GDK_KEY_g.
12743
12744 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12745 if ! HAVE_GTK3
12746 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12747
12748 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12749 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12750 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12751
1c2cc4ef
JB
127522011-03-08 Juanma Barranquero <lekktu@gmail.com>
12753
12754 * w32xfns.c (select_palette): Check success of RealizePalette against
12755 GDI_ERROR, not zero.
12756
33383987 12757See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12758
12759;; Local Variables:
12760;; coding: utf-8
aac0c6e3
MR
12761;; End:
12762
2f097256 12763 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12764
12765 This file is part of GNU Emacs.
12766
12767 GNU Emacs is free software: you can redistribute it and/or modify
12768 it under the terms of the GNU General Public License as published by
12769 the Free Software Foundation, either version 3 of the License, or
12770 (at your option) any later version.
12771
12772 GNU Emacs is distributed in the hope that it will be useful,
12773 but WITHOUT ANY WARRANTY; without even the implied warranty of
12774 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12775 GNU General Public License for more details.
12776
12777 You should have received a copy of the GNU General Public License
12778 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.