* lisp/gnus/gnus-sum.el (gnus-extra-headers): Bump :version.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
04c56954
EZ
12011-04-19 Eli Zaretskii <eliz@gnu.org>
2
3 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4 gl_state.e_property when gl_state.object is Qt.
5
6 * insdel.c (make_gap_larger): Remove limitation of buffer size
7 to <= INT_MAX.
8
16a43933
CY
92011-04-18 Chong Yidong <cyd@stupidchicken.com>
10
11 * xdisp.c (lookup_glyphless_char_display)
12 (produce_glyphless_glyph): Handle cons cell entry in
13 glyphless-char-display.
14 (Vglyphless_char_display): Document it.
15
16 * term.c (produce_glyphless_glyph): Handle cons cell entry in
17 glyphless-char-display.
18
4581706e
CY
192011-04-17 Chong Yidong <cyd@stupidchicken.com>
20
21 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
22
23 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
24
25 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
26 definition for no-X builds.
27
4887c6e2 282011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 29
fd35b6f9
PE
30 Static checks with GCC 4.6.0 and non-default toolkits.
31
5c1ccb01
PE
32 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
33
006c5daa
PE
34 * process.c (keyboard_bit_set): Define only if SIGIO.
35 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
36 (send_process): Repair possible setjmp clobbering.
37
efc736d3
PE
38 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
39
4e2fe2e6
PE
40 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
41
f97334a2
PE
42 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
43
4e75f29d
PE
44 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
45 Define only if needed.
46
90efadd1
PE
47 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
48 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 49 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 50
3c647824
PE
51 * dispextern.h (struct redisplay_interface): Rename param
52 to avoid shadowing.
e264f262 53 * termhooks.h (struct terminal): Likewise.
761383f4 54 * xterm.c (xembed_send_message): Likewise.
3c647824 55
b58c5c4a
PE
56 * insdel.c (make_gap_smaller): Define only if
57 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
58
cad59032
PE
59 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
60 it.
61
c339dc2e
PE
62 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
63 so that we aren't warned about unused symbols.
64
91a3e27b
PE
65 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
66
399c71d3 67 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 68
8ffc96f5
PE
69 * xfns.c (x_real_positions): Mark locals as initialized.
70
eef9bc79
PE
71 * xmenu.c (xmenu_show): Don't use uninitialized vars.
72
098db9dd
PE
73 * xterm.c: Fix problems found by static analysis with other toolkits.
74 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
75 (x_dispatch_event): Declare static if USE_GTK, and
76 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 77 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 78 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
098db9dd
PE
79 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
80 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
81
eb18f6cc
PE
82 * xmenu.c (menu_help_callback): Pointer type fixes.
83 Use const pointers when pointing at readonly data. Avoid pointer
84 signedness clashes.
85 (FALSE): Remove unused macro.
86 (update_frame_menubar): Remove unused decl.
87
1fe72bf8
PE
88 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
89
60d9e1db
PE
90 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
91 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
92 (single_menu_item): Rename local to avoid shadowing.
93
39261c26
PE
94 * keyboard.c (make_lispy_event): Remove unused local var.
95
018c5e19
PE
96 * frame.c, frame.h (x_get_resource_string): Bring this back, but
97 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
98
63d2b86e
PE
99 * bitmaps: Change bitmaps from unsigned char back to the X11
100 compatible char. Avoid the old compiler warnings about
101 out-of-range initializers by using, for example, '\xab' rather
102 than 0xab.
103
aefd87e1
PE
104 * xgselect.c (xgselect_initialize): Check vs interface
105 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
106
bf501fb9
PE
107 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
108
e9829fdf
PE
109 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
110 to read-only memory.
111
1086c095
PE
112 * fns.c (vector): Remove; this old hack is no longer needed.
113
2baccd04 114 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 115 Remove unused var.
dde42981 116 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 117
72391843 118 * xrdb.c (x_load_resources): Omit unused local.
3565b346 119
436c16df 120 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 121 (x_window): Rename locals to avoid shadowing.
dc5ddd85 122 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 123
92bb796d 124 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 125 (x_term_init): Remove local to avoid shadowing.
92bb796d 126
764430a3 127 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
128
129 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
130 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
131
d1dfb56c
EZ
1322011-04-16 Eli Zaretskii <eliz@gnu.org>
133
c4354cb4
EZ
134 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
135
d1dfb56c
EZ
136 Fix regex.c, syntax.c and friends for buffers > 2GB.
137 * syntax.h (struct gl_state_s): Declare character position members
138 EMACS_INT.
139
140 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
141
142 * textprop.c (verify_interval_modification, interval_of): Declare
143 arguments EMACS_INT.
144
145 * intervals.c (adjust_intervals_for_insertion): Declare arguments
146 EMACS_INT.
147
148 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
149
150 * indent.c (Fvertical_motion): Local variable it_start is now
151 EMACS_INT.
152
153 * regex.c (re_match, re_match_2, re_match_2_internal)
154 (bcmp_translate, regcomp, regexec, print_double_string)
155 (group_in_compile_stack, re_search, re_search_2, regex_compile)
156 (re_compile_pattern, re_exec): Declare arguments and local
157 variables `size_t' and `ssize_t' and return values `regoff_t', as
158 appropriate.
159 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
160 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
161 <compile_stack_type>: `size' and `avail' are now `size_t'.
162
163 * regex.h <regoff_t>: Use ssize_t, not int.
164 (re_search, re_search_2, re_match, re_match_2): Arguments that
165 specify buffer/string position and length are now ssize_t and
166 size_t. Return type is regoff_t.
167
613052cd
BK
1682011-04-16 Ben Key <bkey76@gmail.com>
169
170 * nsfont.m: Fixed bugs in ns_get_family and
171 ns_descriptor_to_entity that were caused by using free to
172 deallocate memory blocks that were allocated by xmalloc (via
173 xstrdup). This caused Emacs to crash when compiled with
174 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
175 --enable-checking=xmallocoverrun). xfree is now used to
176 deallocate these memory blocks.
177
4170f62f 1782011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 179
71b41406
PE
180 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
181
9587a89d
PE
182 emacs_write: Accept and return EMACS_INT for sizes.
183 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
184 et seq.
185 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
186 Accept and return EMACS_INT.
187 (emacs_gnutls_write): Return the number of bytes written on
188 partial writes.
189 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
190 (emacs_read, emacs_write): Remove check for negative size, as the
191 Emacs source code has been audited now.
9587a89d
PE
192 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
193 (emacs_read, emacs_write): Use it.
273a5f82
PE
194 * process.c (send_process): Adjust to the new signatures of
195 emacs_write and emacs_gnutls_write. Do not attempt to store
196 a byte offset into an 'int'; it might overflow.
9587a89d 197 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 198
3e047f51
PE
199 * sound.c: Don't assume sizes fit in 'int'.
200 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 201 Return EMACS_INT, not int.
3e047f51 202 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
203 Accept EMACS_INT, not int.
204 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
205 record read return values.
206
cc39a9db
BK
2072011-04-15 Ben Key <bkey76@gmail.com>
208
c9d0ec6d
JB
209 * keyboard.c (Qundefined): Don't declare static since it is used
210 in nsfns.m.
211 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
212 static since they are used in nsfont.m.
cc39a9db 213
6c60eb9f
SM
2142011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
215
216 * process.c (Qprocessp): Don't declare static.
217 * lisp.h (Qprocessp): Declare again.
218
7990b61a
JB
2192011-04-15 Juanma Barranquero <lekktu@gmail.com>
220
221 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
222
5d4cb038
PE
2232011-04-14 Paul Eggert <eggert@cs.ucla.edu>
224
8bd7b830 225 Improve C-level modularity by making more things 'static'.
cd64ea1d 226
e3b27b31
PE
227 Don't publish debugger-only interfaces to other modules.
228 * lisp.h (safe_debug_print, debug_output_compilation_hack):
229 (verify_bytepos, count_markers): Move decls to the only modules
230 that need them.
231 * region-cache.h (pp_cache): Likewise.
232 * window.h (check_all_windows): Likewise.
233 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
234
5d4cb038
PE
235 * sysdep.c (croak): Now static, if
236 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
237 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
238
239 * alloc.c (refill_memory_reserve): Now static if
240 !defined REL_ALLOC || defined SYSTEM_MALLOC.
241 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 242
e87b6180
PE
243 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
244 Define only if USE_LUCID.
245
ac64929e
PE
246 * xrdb.c (x_customization_string, x_rm_string): Now static.
247
6f37259d
PE
248 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
249 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
250
1683e3ab
PE
251 * xdisp.c (draw_row_with_mouse_face): Now static.
252 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
253
de9c2632
PE
254 * window.h (check_all_windows): Mark externally visible.
255
2b96acb7
PE
256 * window.c (window_deletion_count): Now static.
257
258 * undo.c: Make symbols static if they're not exported.
259 (last_undo_buffer, last_boundary_position, pending_boundary):
260 Now static.
261
50436f33
PE
262 * textprop.c (interval_insert_behind_hooks): Now static.
263 (interval_insert_in_front_hooks): Likewise.
264
64520e5c
PE
265 * term.c: Make symbols static if they're not exported.
266 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
267 (max_frame_lines, tty_set_terminal_modes):
268 (tty_reset_terminal_modes, tty_turn_off_highlight):
269 (get_tty_terminal): Now static.
270 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
271 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 272 HAVE_WINDOW_SYSTEM.
64520e5c
PE
273 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
274 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
275
1fa53021
PE
276 * sysdep.c: Make symbols static if they're not exported.
277 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
278 Now static.
279 (sigprocmask_set, full_mask): Remove; unused.
280 (wait_debugging): Mark as visible.
281 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
282 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
283
d4b43b22
PE
284 * syntax.c (syntax_temp): Define only if !__GNUC__.
285
b7c513d0
PE
286 * sound.c (current_sound_device, current_sound): Now static.
287
989b29ad
PE
288 * search.c (searchbufs, searchbuf_head): Now static.
289
13a55a78
PE
290 * scroll.c (scroll_cost): Remove; unused.
291 * dispextern.h (scroll_cost): Remove decl.
292
de68a1fc
PE
293 * region-cache.h (pp_cache): Mark as externally visible.
294
40ccffa6
PE
295 * process.c: Make symbols static if they're not exported.
296 (process_tick, update_tick, create_process, chan_process):
297 (Vprocess_alist, proc_buffered_char, datagram_access):
298 (fd_callback_data, send_process_frame, process_sent_to): Now static.
299 (deactivate_process): Mark defn as static, as well as decl.
300 * lisp.h (create_process): Remove decl.
301 * process.h (chan_process, Vprocess_alist): Remove decls.
302
ad64fc97
PE
303 * print.c: Make symbols static if they're not exported.
304 (print_depth, new_backquote_output, being_printed, print_buffer):
305 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
306 (print_interval, print_number_index, initial_stderr_stream):
307 Now static.
308 * lisp.h (Fprinc): Remove decl.
309 (debug_output_compilation_hack): Mark as externally visible.
310
adddb265
PE
311 * sysdep.c (croak): Move decl from here to syssignal.h.
312 * syssignal.h (croak): Put it here, so the API can be checked when
313 'croak' is called from dissociate_if_controlling_tty.
314
1717ede2
PE
315 * minibuf.c: Make symbols static if they're not exported.
316 (minibuf_save_list, choose_minibuf_frame): Now static.
317 * lisp.h (choose_minibuf_frame): Remove decl.
318
fa5fb2bc
PE
319 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
320
1e3890d1
PE
321 * lread.c: Make symbols static if they're not exported.
322 (read_objects, initial_obarray, oblookup_last_bucket_number):
323 Now static.
324 (make_symbol): Remove; unused.
325 * lisp.h (initial_obarray, make_symbol): Remove decls.
326
8a1414fa
PE
327 * keyboard.c: Make symbols static if they're not exported.
328 (single_kboard, recent_keys_index, total_keys, recent_keys):
329 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
330 (this_single_command_key_start, echoing, last_auto_save):
331 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
332 (command_loop, echo_now, keyboard_init_hook, help_char_p):
333 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
334 (Vlispy_mouse_stem, double_click_count):
335 Now static.
336 (force_auto_save_soon): Define only if SIGDANGER.
337 (ignore_mouse_drag_p): Now static if
338 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
339 (print_help): Remove; unused.
340 (stop_character, last_timer_event): Mark as externally visible.
341 * keyboard.h (ignore_mouse_drag_p): Declare only if
342 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
343 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
344 * lisp.h (echoing): Remove decl.
345 (force_auto_save_soon): Declare only if SIGDANGER.
346 * xdisp.c (redisplay_window): Simplify code, to make it more
347 obvious that ignore_mouse_drag_p is not accessed if !defined
348 USE_GTK && !defined HAVE_NS.
349
93ea6e8f
PE
350 * intervals.c: Make symbols static if they're not exported.
351 (merge_properties_sticky, merge_interval_right, delete_interval):
352 Now static.
353 * intervals.h (merge_interval_right, delete_interval): Remove decls.
354
77382fcc
PE
355 * insdel.c: Make symbols static if they're not exported.
356 However, leave prepare_to_modify_buffer alone. It's never
357 called from outside this function, but that appears to be a bug.
358 (combine_after_change_list, combine_after_change_buffer):
4889fc82 359 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
360 (adjust_after_replace_noundo): Remove; unused.
361 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 362 (signal_before_change): Remove decls.
77382fcc 363
9306c32e
PE
364 * indent.c (val_compute_motion, val_vmotion): Now static.
365
cd44d2eb
PE
366 * image.c: Make symbols static if they're not exported.
367 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
368 if USE_GTK.
369 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
370 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
371
ad9a7a06
PE
372 * fringe.c (standard_bitmaps): Now static.
373 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
374
81626931
PE
375 * frame.c: Make symbols static if they're not exported.
376 (x_report_frame_params, make_terminal_frame): Now static.
377 (get_frame_param): Now static, unless HAVE_NS.
378 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
379 (x_get_resource_string): Remove; not used.
380 * frame.h (make_terminal_frame, x_report_frame_params):
381 (x_get_resource_string); Remove decls.
382 (x_fullscreen_adjust): Declare only if WINDOWSNT.
383 * lisp.h (get_frame_param): Declare only if HAVE_NS.
384
239f9db9
PE
385 * font.c, fontset.c: Make symbols static if they're not exported.
386 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
387 (FACE_SUITABLE_FOR_CHAR_P): Use it.
388 * font.c (font_close_object): Now static.
389 * font.h (font_close_object): Remove.
390 * fontset.c (FONTSET_OBJLIST): Remove.
391 (free_realized_fontset) #if-0 the body, which does nothing.
392 (face_suitable_for_char_p): #if-0, as it's never called.
393 * fontset.h (face_suitable_for_char_p): Remove decl.
394 * xfaces.c (face_at_string_position): Use
395 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
396 since 0 is always ASCII.
397
dfcf3579
PE
398 * fns.c (weak_hash_tables): Now static.
399
5045092b
PE
400 * fileio.c: Make symbols static if they're not exported.
401 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
402 (Vwrite_region_annotation_buffers): Now static.
403
57a96f5c
PE
404 * eval.c: Make symbols static if they're not exported.
405 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
406 * lisp.h (backtrace_list): Remove decl.
407
35f08c38
PE
408 * emacs.c: Make symbols static if they're not exported.
409 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
410 (fatal_error_code, fatal_error_signal_hook, standard_args):
411 Now static.
412 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
413 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
414 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
415 * lisp.h (fatal_error_signal_hook): Remove decl.
416 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
417
f44bd759
PE
418 * editfns.c: Move a (normally-unused) function to its only use.
419 * editfns.c, lisp.h (get_operating_system_release): Remove.
420 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
421 worth the hassle of breaking this out.
422
b532497d
PE
423 * xterm.c: Make symbols static if they're not exported.
424 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
425 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
426 (x_destroy_window, x_delete_display):
427 Now static.
428 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
429 (x_mouse_leave): Remove; unused.
430 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
431 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
432 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
433 Remove decls.
434 (x_mouse_leave): Declare only if WINDOWSNT.
435 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
436 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
437 USE_X_TOOLKIT.
438
1675728f
PE
439 * ftxfont.c: Make symbols static if they're not exported.
440 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
441 HAVE_FREETYPE.
442 * font.h (ftxfont_driver): Likewise.
443
e4cebfca
PE
444 * xfns.c: Make symbols static if they're not exported.
445 (x_last_font_name, x_display_info_for_name):
446 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
447 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
448 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
449 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
450 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
451 (last_show_tip_args): Now static.
452 (xic_defaut_fontset, xic_create_fontsetname): Define only if
453 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
454 (x_screen_planes): Remove; unused.
455 * dispextern.h (x_screen_planes): Remove decl.
456
5bf46f05
PE
457 * dispnew.c: Make symbols static if they're not exported.
458 * dispextern.h (redraw_garbaged_frames, scrolling):
459 (increment_row_positions): Remove.
460 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
461 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
462 Now static.
463 (redraw_garbaged_frames): Remove; unused.
464
435f4c28
PE
465 * xfaces.c: Make symbols static if they're not exported.
466 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
467 Remove decls.
468 * xterm.h (defined_color): Remove decls.
469 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
470 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
471 (menu_face_changed_default, defined_color, free_realized_face):
472 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
473 (ascii_face_of_lisp_face): Remove; unused.
474
8524aef3
PE
475 * xdisp.c: Make symbols static if they're not exported.
476 * dispextern.h (scratch_glyph_row, window_box_edges):
477 (glyph_to_pixel_coords, set_cursor_from_row):
478 (get_next_display_element, set_iterator_to_next):
479 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
480 (show_mouse_face): Remove decls
481 * frame.h (message_buf_print): Likewise.
482 * lisp.h (pop_message, set_message, check_point_in_composition):
483 Likewise.
484 * xterm.h (set_vertical_scroll_bar): Likewise.
485 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
486 (message_buf_print, scratch_glyph_row, displayed_buffer):
487 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
488 (get_next_display_element, show_mouse_face, window_box_edges):
489 (frame_to_window_pixel_xy, check_point_in_composition):
490 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
491 (glyph_to_pixel_coords): Remove; unused.
492
16390cd2
PE
493 * dired.c (file_name_completion): Now static.
494
495 * dbusbind.c (xd_in_read_queued_messages): Now static.
496
a25f4dfa
PE
497 * lisp.h (circular_list_error, FOREACH): Remove; unused.
498 * data.c (circular_list_error): Remove.
499
14a9c8df
PE
500 * commands.h (last_point_position, last_point_position_buffer):
501 (last_point_position_window): Remove decls.
502 * keyboard.c: Make these variables static.
503
74ab6df5
PE
504 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
505 decls.
506 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
507 (iso_code_class, detect_coding, code_convert_region): Now static.
508 (encode_coding_gap): Remove; unused.
509
38dfbee1
PE
510 * chartab.c (chartab_chars, chartab_bits): Now static.
511
a2cb4e63
PE
512 * charset.h (charset_iso_8859_1): Remove decl.
513 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
514 Now static.
515
127198fd
PE
516 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
517 * ccl.c (Vccl_program_table): Now static.
518 (check_ccl_update): Remove; unused.
519
d85b608f
PE
520 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
521 * category.h: ... from here.
522 * category.c (check_category_table, set_category_set): Now static.
523
31cd66f3
PE
524 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
525 * lisp.h: Remove these decls.
526
c358e587
PE
527 * buffer.c (buffer_count): Remove unused var.
528
e78aecca
PE
529 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
530 so that it's not optimized away.
531 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
532 * dispextern.h (bidi_dump_cached_states): Remove, since it's
533 exported only to the debugger.
534
e192d7d3
PE
535 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
536 * atimer.h (run_all_atimers): Removed; not exported.
537
92470028
PE
538 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
539 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
540 was inaccessible from Lisp.
541 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
542 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
543
244ed907
PE
544 alloc.c: Import and export fewer symbols, and remove unused items.
545 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
546 is defined.
547 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
548 it's not optimized away by whole-program optimization.
549 (message_enable_multibyte, free_misc): Remove.
550 (catchlist, handlerlist, mark_backtrace):
551 Declare only if BYTE_MARK_STACK.
552 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
553 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
554 (message_enable_multibyte): Remove decl.
555 (free_misc, interval_free_list, float_block, float_block_index):
556 (n_float_blocks, float_free_list, cons_block, cons_block_index):
557 (cons_free_list, last_marked_index):
558 Now static.
559 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
560 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
561 (mark_backtrace): Define only if BYTE_MARK_STACK.
562 * xdisp.c (message_enable_multibyte): Now static.
563
61c2b50e 564 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
565 This makes it easier for human readers (and static analyzers)
566 to see whether these variables are used from other modules.
567 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
568 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
569 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
570 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
571 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
572 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
573 * xmenu.c, xselect.c:
574 Declare Q* vars static if they are not used in other modules.
575 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
576 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
577 Remove decls of unexported vars.
578 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
579
95c82688
PE
580 * lisp.h (DEFINE_FUNC): Make sname 'static'.
581
16a97296
PE
582 Make Emacs functions such as Fatom 'static' by default.
583 This makes it easier for human readers (and static analyzers)
584 to see whether these functions can be called from other modules.
585 DEFUN now defines a static function. To make the function external
586 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
587 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
588 (Finit_image_library):
16a97296
PE
589 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
590 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
591 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
592 Remove decls, since these functions are now static.
593 (Funintern, Fget_internal_run_time): New decls, since these functions
594 were already external.
95c82688 595
16a97296
PE
596 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
597 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
598 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
599 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
600 * keyboard.c, keymap.c, lread.c:
601 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
602 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
603 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
604 Mark functions with DEFUE instead of DEFUN,
605 if they are used in other modules.
606 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
607 decls for now-static functions.
608 * buffer.h (Fdelete_overlay): Remove decl.
609 * callproc.c (Fgetenv_internal): Mark as internal.
610 * composite.c (Fremove_list_of_text_properties): Remove decl.
611 (Fcomposition_get_gstring): New forward static decl.
612 * composite.h (Fcomposite_get_gstring): Remove decl.
613 * dired.c (Ffile_attributes): New forward static decl.
614 * doc.c (Fdocumntation_property): New forward static decl.
615 * eval.c (Ffetch_bytecode): New forward static decl.
616 (Funintern): Remove extern decl; now in .h file where it belongs.
617 * fileio.c (Fmake_symbolic_link): New forward static decl.
618 * image.c (Finit_image_library): New forward static decl.
619 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
620 * intervals.h (Fprevious_property_change):
621 (Fremove_list_of_text_properties): Remove decls.
622 * keyboard.c (Fthis_command_keys): Remove decl.
623 (Fcommand_execute): New forward static decl.
624 * keymap.c (Flookup_key): New forward static decl.
625 (Fcopy_keymap): Now static.
626 * keymap.h (Flookup_key): Remove decl.
627 * process.c (Fget_process): New forward static decl.
628 (Fprocess_datagram_address): Mark as internal.
629 * syntax.c (Fsyntax_table_p): New forward static decl.
630 (skip_chars): Remove duplicate decl.
631 * textprop.c (Fprevious_property_change): New forward static decl.
632 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
633 Now internal.
634 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
635 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
636
785bbd42
PE
637 * editfns.c (Fformat): Remove unreachable code.
638
8b913b57
AS
6392011-04-14 Andreas Schwab <schwab@linux-m68k.org>
640
641 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
642 change. (Bug#8496)
643
a6744a35
EZ
6442011-04-13 Eli Zaretskii <eliz@gnu.org>
645
646 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
647 when at ZV. (Bug#8487)
648
e7974947
AS
6492011-04-12 Andreas Schwab <schwab@linux-m68k.org>
650
baad03f0
AS
651 * charset.c (Fclear_charset_maps): Use xfree instead of free.
652 (Bug#8437)
653 * keyboard.c (parse_tool_bar_item): Likewise.
654 * sound.c (sound_cleanup, alsa_close): Likewise.
655 * termcap.c (tgetent): Likewise.
656 * xfns.c (x_default_font_parameter): Likewise.
657 * xsettings.c (read_and_apply_settings): Likewise.
658
e7974947
AS
659 * alloc.c (overrun_check_malloc, overrun_check_realloc)
660 (overrun_check_free): Protoize.
661
28272684
PE
6622011-04-12 Paul Eggert <eggert@cs.ucla.edu>
663
664 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
665 since callers should never pass a negative size.
666 Change the signature to match that of plain 'read' and 'write'; see
667 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
668 * lisp.h: Update prototypes of emacs_write and emacs_read.
669
11997c76
EZ
6702011-04-11 Eli Zaretskii <eliz@gnu.org>
671
672 * xdisp.c (redisplay_window): Don't try to determine the character
673 position of the scroll margin if the window start point w->startp
e896f03c 674 is outside the buffer's accessible region. (Bug#8468)
11997c76 675
8a2cbd72
EZ
6762011-04-10 Eli Zaretskii <eliz@gnu.org>
677
678 Fix write-region and its subroutines for buffers > 2GB.
679 * fileio.c (a_write, e_write): Modify declaration of arguments and
680 local variables to support buffers larger than 2GB.
681 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
682
683 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
684 argument, local variables, and return value.
685
686 * lisp.h: Update prototypes of emacs_write and emacs_read.
687
688 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
689
4073e537 6902011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 691
1ebfdcb6
PE
692 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
693
b2ded58d
PE
694 Fix more problems found by GCC 4.6.0's static checks.
695
7d66342c
PE
696 * xdisp.c (vmessage): Use a better test for character truncation.
697
bbf47d44
PE
698 * charset.c (load_charset_map): <, not <=, for optimization,
699 and to avoid potential problems with integer overflow.
9248994d 700 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 701 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 702 * editfns.c (Fformat): Likewise.
1e69125e 703 * syntax.c (skip_chars): Likewise.
3befa583 704
e3019616
PE
705 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
706 This also lets GCC 4.6.0 generate slightly better loop code.
707
becfa255
PE
708 * callint.c (Fcall_interactively): <, not <=, for optimization.
709 (Fcall_interactively): Count the number of arguments produced,
710 not the number of arguments given. This is simpler and lets GCC
711 4.6.0 generate slightly better code.
712
dae0cd48
PE
713 * ftfont.c: Distingish more carefully between FcChar8 and char.
714 The previous code passed unsigned char * to a functions like
715 strlen and xstrcasecmp that expect char *, which does not
716 conform to the C standard.
717 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
718 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
719 char * when the C standard requires it.
720
76032d70
PE
721 * keyboard.c (read_char): Remove unused var.
722
eb3f1cc8
PE
723 * eval.c: Port to Windows vsnprintf (Bug#8435).
724 Include <limits.h>.
725 (SIZE_MAX): Define if the headers do not.
726 (verror): Do not give up if vsnprintf returns a negative count.
727 Instead, grow the buffer. This ports to Windows vsnprintf, which
728 does not conform to C99. Problem reported by Eli Zaretskii.
729 Also, simplify the allocation scheme, by avoiding the need for
730 calling realloc, and removing the ALLOCATED variable.
731
70476b54
PE
732 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
733
12020a9e
PE
734 Remove invocations of doprnt, as Emacs now uses vsnprintf.
735 But keep the doprint source code for now, as we might revamp it
736 and use it again (Bug#8435).
ea6c7ae6
PE
737 * lisp.h (doprnt): Remove.
738 * Makefile.in (base_obj): Remove doprnt.o.
739 * deps.mk (doprnt.o): Remove.
740
5fdb398c
PE
741 error: Print 32- and 64-bit integers portably (Bug#8435).
742 Without this change, on typical 64-bit hosts error ("...%d...", N)
743 was used to print both 32- and 64-bit integers N, which relied on
744 undefined behavior.
745 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
746 New macro.
747 * lisp.h (error, verror): Mark as printf-like functions.
748 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
749 Report overflow in size calculations when allocating printf buffer.
750 Do not truncate output string at its first null byte.
751 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
752 Truncate the output at a character boundary, since vsnprintf does not
753 do that.
754 * charset.c (check_iso_charset_parameter): Convert internal
755 character to string before calling 'error', since %c now has the
756 printf meaning.
757 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
758 overflow when computing char to be passed to 'error'. Do not
759 pass Lisp_Object to 'error'; pass the integer instead.
760 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
761 formatted with plain %d.
762
b189fa66
PE
763 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
764
bff87ef0
PE
765 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
766
7e2cac20
PE
767 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
768
ce4d90b5
PE
769 * xterm.c (x_catch_errors): Remove duplicate declaration.
770
266c9547
PE
771 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
772
79c49ad2
PE
773 * xdisp.c, lisp.h (message_nolog): Remove; unused.
774
368f4090
JM
7752011-04-10 Jim Meyering <meyering@redhat.com>
776
777 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
778 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
779 return ssize_t not "int", and use size_t as the buffer length.
780 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
781 * gnutls.h: Update declarations.
782 * process.c (read_process_output): Use ssize_t, to match.
783 (send_process): Likewise.
784
a32d4040
CY
7852011-04-09 Chong Yidong <cyd@stupidchicken.com>
786
787 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
788
8546720e 7892011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 790
8546720e
GM
791 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
792 unsigned char, to match FcChar8 type definition.
aac0c6e3 793
8546720e
GM
794 * xterm.c (handle_one_xevent):
795 * xmenu.c (create_and_show_popup_menu):
796 * xselect.c (x_decline_selection_request)
797 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 798
0a2f5c1a 7992011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
800
801 Fix some uses of `int' instead of EMACS_INT.
802 * search.c (string_match_1, fast_string_match)
803 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
804 (scan_buffer, find_next_newline_no_quit)
805 (find_before_next_newline, search_command, Freplace_match)
806 (Fmatch_data): Make some `int' variables be EMACS_INT.
807
808 * xdisp.c (display_count_lines): 3rd argument and return value now
809 EMACS_INT. All callers changed.
810 (pint2hrstr): Last argument is now EMACS_INT.
811
812 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
813 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
814 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
815 (decode_coding_utf_16, decode_coding_emacs_mule)
816 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
817 (decode_coding_ccl, decode_coding_charset)
818 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
819 (decode_coding_iso_2022, decode_coding_emacs_mule)
820 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
821 <char_offset, last_offset>: Declare EMACS_INT.
822 (encode_coding_utf_8, encode_coding_utf_16)
823 (encode_coding_emacs_mule, encode_invocation_designation)
824 (encode_designation_at_bol, encode_coding_iso_2022)
825 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
826 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
827 Declare EMACS_INT.
828 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
829 (encode_invocation_designation): Last argument P_NCHARS is now
830 EMACS_INT.
831 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
832 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
833
834 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
835 All users changed.
836
837 * ccl.c (Fccl_execute_on_string): Declare some variables
838 EMACS_INT.
839
8546720e 8402011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
841
842 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
843
4e19a977
CS
8442011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
845
846 * process.c (Fformat_network_address): Doc fix.
847
87302331
R
8482011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
849
850 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
851
cbb59342
CY
8522011-04-08 Chong Yidong <cyd@stupidchicken.com>
853
854 * keyboard.c (read_char): Call Lisp function help-form-show,
855 instead of using internal_with_output_to_temp_buffer.
856 (Qhelp_form_show): New var.
e0d38eeb 857 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
858
859 * print.c (internal_with_output_to_temp_buffer): Function deleted.
860
861 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
862
e67a13ab
CY
8632011-04-06 Chong Yidong <cyd@stupidchicken.com>
864
865 * process.c (Flist_processes): Removed to Lisp.
866 (list_processes_1): Deleted.
867
973f782d
EZ
8682011-04-06 Eli Zaretskii <eliz@gnu.org>
869
7c106b1e
EZ
870 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
871
973f782d
EZ
872 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
873
41cf7d1a 8742011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 875
ca23cc88
PE
876 Fix more problems found by GCC 4.6.0's static checks.
877
f390e2d5
PE
878 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
879
42eea0d0
PE
880 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
881
b69769da 882 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 883
f9541e84
PE
884 * xdisp.c (vmessage): Mark as a printf-like function.
885
13841b55
PE
886 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
887
c136c10f
PE
888 * sound.c (sound_warning): Don't crash if arg contains a printf format.
889
5e2d4a30
PE
890 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
891 printf-like functions.
892 (tiff_load): Add casts to remove these marks before passing them
893 to system-supplied API.
894
583f48b9
PE
895 * eval.c (Fsignal): Remove excess argument to 'fatal'.
896
b25d760e
PE
897 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
898 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
899 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
900 directly, rather than having caller test rule sign. This avoids
901 some unnecessary tests.
902 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
903 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
904 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 905
bc7b6697 906 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 907 (xfont_open): Avoid unnecessary tests.
bc7b6697 908
27ccc379
PE
909 * composite.c (composition_gstring_put_cache): Use unsigned integer.
910
dcd5c89a
PE
911 * composite.h, composite.c (composition_gstring_put_cache):
912 Use EMACS_INT, not int, for length.
913
b13a45c6
PE
914 * composite.h (COMPOSITION_DECODE_REFS): New macro,
915 breaking out part of COMPOSITION_DECODE_RULE.
916 (COMPOSITION_DECODE_RULE): Use it.
917 * composite.c (get_composition_id): Remove unused local vars,
918 by using the new macro.
919
1e792e4d
PE
920 * textprop.c (set_text_properties_1): Change while to do-while,
921 since the condition is always true at first.
922
dc6c6455 923 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
924 (interval_deletion_adjustment): Return unsigned value.
925 All uses changed.
dc6c6455 926
aba7731a
PE
927 * process.c (list_processes_1, create_pty, read_process_output):
928 (exec_sentinel): Remove vars that were set but not used.
afd4052b 929 (create_pty): Remove unnecessary "volatile"s.
bc57d757 930 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 931 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 932 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 933
fdfc4bf3
PE
934 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
935
fca8fe46 936 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 937 (update_syntax_table): Use unsigned instead of int.
fca8fe46 938
06a0259a 939 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 940 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 941 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 942
e7b9e80f
PE
943 * print.c (print_error_message): Avoid int overflow.
944
56201685
PE
945 * font.c (font_list_entities): Redo for clarity,
946 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
947
78834453 948 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 949 (font_score): Avoid potential overflow in diff calculation.
78834453 950
0bc0b309 951 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 952 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 953
e610eaca
PE
954 * eval.c (funcall_lambda): Rename local to avoid shadowing.
955
b895abce
PE
956 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
957 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
958 can always succeed if overflow has undefined behavior.
959
1f1d9321 960 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 961 (wordify): Omit three unnecessary tests.
1f1d9321 962
c59478bc
PE
963 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
964 All callers changed. This avoids the need for an unused var.
965
79b73827
PE
966 * casefiddle.c (casify_region): Remove var that is set but not used.
967
a4db5dfe
PE
968 * dired.c (file_name_completion): Remove var that is set but not used.
969
43aae36e
PE
970 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
971
2a47c44d 972 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 973 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 974
a37c69bf
PE
975 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
976 Check for integer overflow on size calculations.
977
328ab8e7
PE
978 * buffer.c (Fprevious_overlay_change): Remove var that is set
979 but not used.
980
e5a2a5cb
PE
981 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
982 Remove vars that are set but not used.
8d84a6eb 983 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 984 (timer_check_2): Mark vars as initialized.
e5a2a5cb 985
a60e5f68
PE
986 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
987
f661cb61 988 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 989 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 990
f0397f5a
PE
991 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
992 that are set but not used.
993
8664db06 994 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 995 if XCreateBitmapFromData fails (Bug#8410).
8664db06 996
6abdaa4a
PE
997 * xselect.c (x_get_local_selection, x_handle_property_notify):
998 Remove vars that are set but not used.
999
0ce7538d 1000 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1001 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1002
9ae848fc
PE
1003 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1004 Remove var that is set but not used.
0b918413
PE
1005 (scroll_bar_windows_size): Now size_t, not int.
1006 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1007 Check for overflow.
9ae848fc 1008
a5a62657
PE
1009 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1010 (map_tty_color) [!defined MSDOS]: Likewise.
1011
5c5cdd39
PE
1012 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1013
66ebf983
PE
1014 * coding.c: Remove vars that are set but not used.
1015 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1016 All callers changed.
1017 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1018 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1019 (decode_coding_charset): Remove vars that are set but not used.
1020
1be4d761
PE
1021 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1022 that is set but not used.
1023
47553fa8
PE
1024 * print.c (print_object): Remove var that is set but not used.
1025
1f7196bf 1026 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1027 The gnulib version avoids calling malloc in the usual case,
1028 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1029 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1030 * filelock.c (current_lock_owner): Likewise.
1031 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1032 * sysdep.c: Include allocator.h, careadlinkat.h.
1033 (emacs_no_realloc_allocator): New static constant.
1034 (emacs_readlink): New function.
fdb61804
PE
1035 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1036 ../lib/careadlinkat.h.
d1fdcab7 1037
f84c17c7
SM
10382011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1039
1040 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1041 first non-nil return value).
1042
ef3862ad
JD
10432011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1044
1045 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1046 if not defined (Bug#8403).
1047
376a7006
JB
10482011-04-02 Juanma Barranquero <lekktu@gmail.com>
1049
1050 * xdisp.c (display_count_lines): Remove parameter `start',
1051 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1052 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1053 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1054 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1055 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1056 and thereabouts. All callers changed.
1057 (get_per_char_metric): Remove parameter `f', unused since
1058 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1059
6ca3801d
JM
10602011-04-02 Jim Meyering <meyering@redhat.com>
1061
1062 do not dereference NULL upon failed strdup
1063 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1064 (ns_get_family): Likewise.
1065
d8e2b5ba
JB
10662011-04-02 Juanma Barranquero <lekktu@gmail.com>
1067
1068 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1069
8c74fcbd
JD
10702011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1071
1072 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1073 later (Bug#8403).
1074
7200d79c
SM
10752011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1076
03408648 1077 Add lexical binding.
7200d79c 1078
03408648
SM
1079 * window.c (Ftemp_output_buffer_show): New fun.
1080 (Fsave_window_excursion):
1081 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1082
1083 * lread.c (lisp_file_lexically_bound_p): New function.
1084 (Fload): Bind Qlexical_binding.
1085 (readevalloop): Remove `evalfun' arg.
1086 Bind Qinternal_interpreter_environment.
1087 (Feval_buffer): Bind Qlexical_binding.
1088 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1089 Mark as dynamic.
1090 (syms_of_lread): Declare `lexical-binding'.
1091
1092 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1093
1094 * keyboard.c (eval_dyn): New fun.
1095 (menu_item_eval_property): Use it.
ca105506
SM
1096
1097 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1098
03408648
SM
1099 * fns.c (concat, mapcar1): Accept byte-code-functions.
1100
1101 * eval.c (Fsetq): Handle lexical vars.
1102 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1103 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1104 (FletX, Flet): Obey lexical binding.
1105 (Fcommandp): Handle closures.
1106 (Feval): New `lexical' arg.
1107 (eval_sub): New function extracted from Feval. Use it almost
1108 everywhere where Feval was used. Look up vars in lexical env.
1109 Handle closures.
1110 (Ffunctionp): Move from subr.el.
1111 (Ffuncall): Handle closures.
1112 (apply_lambda): Remove `eval_flags'.
1113 (funcall_lambda): Handle closures and new byte-code-functions.
1114 (Fspecial_variable_p): New function.
1115 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1116 but without exporting it to Lisp.
23aba0ea 1117
23aba0ea 1118 * doc.c (Fdocumentation, store_function_docstring):
03408648 1119 * data.c (Finteractive_form): Handle closures.
23aba0ea 1120
03408648
SM
1121 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1122 interactive spec.
ba83908c 1123
03408648
SM
1124 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1125 byte-codes.
1126 (exec_byte_code): New function extracted from Fbyte_code to handle new
1127 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1128
03408648 1129 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1130
03408648 1131 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1132
e2abce01
JB
11332011-03-31 Juanma Barranquero <lekktu@gmail.com>
1134
1135 * xdisp.c (redisplay_internal): Fix prototype.
1136
63696a73 11372011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1138
63696a73
EZ
1139 * xdisp.c (SCROLL_LIMIT): New macro.
1140 (try_scrolling): Use it when setting scroll_limit. Limit
1141 scrolling to 100 screen lines.
1142 (redisplay_window): Even when falling back on "recentering",
1143 position point in the window according to scroll-conservatively,
1144 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1145
1146 (try_scrolling): When point is above the window, allow searching
1147 as far as scroll_max, or one screenful, to compute vertical
1148 distance from PT to the scroll margin position. This prevents
1149 try_scrolling from unnecessarily failing when
1150 scroll-conservatively is set to a value slightly larger than the
1151 window height. Clean up the case of PT below the margin at bottom
1152 of window: scroll_max can no longer be INT_MAX. When aggressive
1153 scrolling is in use, don't let point enter the opposite scroll
1154 margin as result of the scroll.
1155 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1156 threshold of 100 lines for never-recentering scrolling.
1157
e4cc2dfc
JB
11582011-03-31 Juanma Barranquero <lekktu@gmail.com>
1159
1160 * dispextern.h (move_it_by_lines):
1161 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1162 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1163 (message_log_check_duplicate): Remove parameters `prev_bol' and
1164 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1165 (redisplay_internal): Remove parameter `preserve_echo_area',
1166 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1167
1168 * indent.c (Fvertical_motion):
1169 * window.c (window_scroll_pixel_based, Frecenter):
1170 Don't pass `need_y_p' to `move_it_by_lines'.
1171
1c470562
SM
11722011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1173
44f230aa
SM
1174 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1175 steal a few bits to be more compact.
1176 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1177 Remove unneeded casts.
1178
1c470562
SM
1179 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1180
888adce9
ZK
11812011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1182
1183 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1184 binding" message (bug#7967).
1185
f838ed7b
PE
11862011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1187
77861b95
PE
1188 Fix more problems found by GCC 4.6.0's static checks.
1189
de6dbc14
PE
1190 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1191 Remove unused local var.
1192
f838ed7b
PE
1193 * editfns.c (Fmessage_box): Remove unused local var.
1194
792c7b2b
PE
1195 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1196 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1197 Omit unused local vars.
c499e557 1198 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1199 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1200 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1201 Omit unused local var.
1202
ba0165e1
PE
1203 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1204 Don't assume string length fits in int.
32ad8845 1205 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1206 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1207
3c59b4c9
PE
1208 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1209 instead of alloca (Bug#8344).
1210
a3eed478 1211 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1212 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1213
eb4d412d
PE
1214 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1215
1658b401
PE
1216 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1217 concerns.
1218
1219 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1220
1221 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1222
9a2c6e05
PE
1223 * keyboard.c (syms_of_keyboard): Use the same style as later
1224 in this function when indexing through an array. This also
1225 works around GCC bug 48267.
1226
03d0a109
PE
1227 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1228
44f730c8
PE
1229 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1230
fe75f926
PE
1231 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1232 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1233
ffa8c828
PE
1234 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1235 This avoids undefined behavior on integer overflow, and is a bit
1236 more convenient anyway since it is compared to a size_t variable.
1237
c5101a77
PE
1238 Variadic C functions now count arguments with size_t, not int.
1239 This avoids an unnecessary limitation on 64-bit machines, which
1240 caused (substring ...) to crash on large vectors (Bug#8344).
1241 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1242 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1243 All variadic functions and their callers changed accordingly.
c5101a77
PE
1244 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1245 * data.c (arith_driver, float_arith_driver): Likewise.
1246 * editfns.c (general_insert_function): Likewise.
1247 * eval.c (struct backtrace.nargs, interactive_p)
1248 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1249 (funcall_lambda, mark_backtrace): Likewise.
1250 * fns.c (concat): Likewise.
1251 * frame.c (x_set_frame_parameters): Likewise.
1252 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1253 0 if not found, not -1. All callers changed.
1254
dd3f25f7
PE
1255 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1256 (stack_copy_size): Now size_t, not int.
1257 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1258
461c2ab9
JB
12592011-03-28 Juanma Barranquero <lekktu@gmail.com>
1260
1261 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1262 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1263 All callers changed.
1264
1265 * lisp.h (multibyte_char_to_unibyte):
1266 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1267 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1268 * character.h (CHAR_TO_BYTE8):
1269 * cmds.c (internal_self_insert):
1270 * editfns.c (general_insert_function):
1271 * keymap.c (push_key_description):
1272 * search.c (Freplace_match):
1273 * xdisp.c (message_dolog, set_message_1): All callers changed.
1274
f6d62986
SM
12752011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1276
1277 * keyboard.c (safe_run_hook_funcall): New function.
1278 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1279 don't set the hook to nil, but remove the offending function instead.
1280 (Qcommand_hook_internal): Remove, unused.
1281 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1282 Vcommand_hook_internal.
1283
1284 * eval.c (enum run_hooks_condition): Remove.
1285 (funcall_nil, funcall_not): New functions.
1286 (run_hook_with_args): Call each function through a `funcall' argument.
1287 Remove `cond' argument, now redundant.
1288 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1289 (Frun_hook_with_args_until_failure): Adjust accordingly.
1290 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1291
1db5b1ad
JB
12922011-03-28 Juanma Barranquero <lekktu@gmail.com>
1293
1294 * dispextern.h (string_buffer_position): Remove declaration.
1295
1296 * print.c (strout): Remove parameter `multibyte', unused since
1297 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1298
1299 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1300 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1301 All callers changed.
1302
1303 * w32.c (_wsa_errlist): Use braces for struct initializers.
1304
1305 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1306 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1307 All callers changed.
1308 (string_buffer_position): Likewise. Also, make static (it's never
1309 used outside xdisp.c).
1310 (cursor_row_p): Remove parameter `w', unused since
1311 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1312 (decode_mode_spec): Remove parameter `precision', introduced during
1313 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1314 All callers changed.
1315
5ffb62aa
JD
13162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1317
1318 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1319
461c2ab9 13202011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1321
1322 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1323 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1324 (ns_update_auto_hide_menu_bar): New functions.
1325 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1326 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1327 ns_constrain_all_frames.
1328 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1329 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1330
5c380ffb
JD
13312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1332
1333 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1334
9af30bdf
GM
13352011-03-27 Glenn Morris <rgm@gnu.org>
1336
1337 * syssignal.h: Replace RETSIGTYPE with void.
1338 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1339 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1340 Replace SIGTYPE with void everywhere.
1341 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1342 * s/template.h (SIGTYPE): Remove commented out definition.
1343
e2abce01
JB
13442011-03-26 Eli Zaretskii <eliz@gnu.org>
1345
1346 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1347 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1348
f868cd8a
JB
13492011-03-26 Juanma Barranquero <lekktu@gmail.com>
1350
59eb0929
JB
1351 * w32.c (read_unc_volume): Use parameter `henum', instead of
1352 global variable `wget_enum_handle'.
1353
1354 * keymap.c (describe_vector): Remove parameters `indices' and
1355 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1356 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1357
f868cd8a
JB
1358 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1359
1360 * keyboard.c (timer_check): Remove parameter `do_it_now',
1361 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1362 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1363 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1364
1365 * keyboard.c (read_char):
1366 * w32menu.c (w32_menu_display_help):
1367 * xmenu.c (show_help_event, menu_help_callback):
1368 Adjust calls to `show_help_echo'.
1369
1370 * gtkutil.c (xg_maybe_add_timer):
1371 * keyboard.c (readable_events):
1372 * process.c (wait_reading_process_output):
1373 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1374
1375 * insdel.c (adjust_markers_gap_motion):
1376 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1377 (gap_left, gap_right): Don't call it.
1378
2ecf6fdb
CY
13792011-03-25 Chong Yidong <cyd@stupidchicken.com>
1380
1381 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1382 incurred during fontification.
1383
6b1f9ba4
JB
13842011-03-25 Juanma Barranquero <lekktu@gmail.com>
1385
1386 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1387 (DEFVAR_PER_BUFFER): Don't pass it.
1388
1389 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1390 (scrolling_window): Don't pass it.
1391
0f4a96b5
JB
13922011-03-25 Juanma Barranquero <lekktu@gmail.com>
1393
1394 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1395
1396 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1397 and `suffix'.
1398 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1399 of variables specific to SELinux and computation of `encoded_absname'.
1400
1401 * image.c (XPutPixel): Remove unused variable `height'.
1402
1403 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1404
1405 * unexw32.c (get_section_info): Remove unused variable `section'.
1406
1407 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1408 (system_process_attributes): Remove unused variable `sess'.
1409 (sys_read): Remove unused variable `err'.
1410
1411 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1412 (w32_wnd_proc): Remove unused variable `isdead'.
1413 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1414 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1415 (x_create_tip_frame): Remove unused variable `tem'.
1416
1417 * w32inevt.c (w32_console_read_socket):
1418 Remove unused variable `no_events'.
1419
1420 * w32term.c (x_draw_composite_glyph_string_foreground):
1421 Remove unused variable `width'.
1422
1149507c
JB
14232011-03-24 Juanma Barranquero <lekktu@gmail.com>
1424
1425 * w32term.c (x_set_glyph_string_clipping):
1426 Don't pass uninitialized region to CombineRgn.
1427
9c88f339
JB
14282011-03-23 Juanma Barranquero <lekktu@gmail.com>
1429
1430 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1431 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1432 (Fx_close_connection): Remove unused variable `i'.
1433
1434 * w32font.c (w32font_draw): Return number of glyphs.
1435 (w32font_open_internal): Remove unused variable `i'.
1436 (w32font_driver): Add missing initializer.
1437
1438 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1439 (fill_in_menu): Remove unused variable `items_added'.
1440
1441 * w32term.c (last_mouse_press_frame): Remove static global variable.
1442 (w32_clip_to_row): Remove unused variable `f'.
1443 (x_delete_terminal): Remove unused variable `i'.
1444
1445 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1446 (NOTHING): Remove unused static global variable.
1447 (uniscribe_check_otf): Remove unused variable `table'.
1448 (uniscribe_font_driver): Add missing initializers.
1449
dee091a3
JD
14502011-03-23 Julien Danjou <julien@danjou.info>
1451
1452 * term.c (Fsuspend_tty, Fresume_tty):
1453 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1454 * window.c (temp_output_buffer_show):
1455 * insdel.c (signal_before_change):
1456 * frame.c (Fhandle_switch_frame):
1457 * fileio.c (Fdo_auto_save):
1458 * emacs.c (Fkill_emacs):
1459 * editfns.c (save_excursion_restore):
1460 * cmds.c (internal_self_insert):
1461 * callint.c (Fcall_interactively):
1462 * buffer.c (Fkill_all_local_variables):
1463 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1464 Use Frun_hooks.
0f4a96b5 1465 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1466 unconditionnaly since it does the check itself.
1467
2c520ab5 14682011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1469
c9c49752
PE
1470 Fix more problems found by GCC 4.5.2's static checks.
1471
8abc3f12
PE
1472 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1473 the first time through the loop, since we know p0 < p1 then.
1474 This also avoids a gcc -Wstrict-overflow warning.
1475
a2d26660
PE
1476 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1477 leading to a memory leak, possible in functions like
1478 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1479 of objects (Bug#8318).
a2d26660 1480
916c72e9
PE
1481 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1482 that could (at least in theory) be that large.
1483
19ab8a18
PE
1484 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1485 This is less likely to overflow, and avoids undefined behavior if
1486 overflow does occur. All callers changed. Use strtoul to scan
1487 for the unsigned long integer.
b7cbbd6f
PE
1488 (pint2hrstr): Simplify and tune code slightly.
1489 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1490
f0641eff
PE
1491 * scroll.c (do_scrolling): Work around GCC bug 48228.
1492 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1493
7f650bb9
PE
1494 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1495 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1496 (validate_x_resource_name): Simplify count usage.
1497 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1498
37dd57d1
PE
1499 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1500 fail (Bug#8306).
81e56e61 1501
699979fc 1502 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1503
401bf9b4
PE
1504 * process.c (Fmake_network_process): Use socklen_t, not int,
1505 where POSIX says socklen_t is required in portable programs.
1506 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1507 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1508 (Fmake_network_process, server_accept_connection):
1509 (wait_reading_process_output, read_process_output):
1510 Likewise.
1511
b93aacde
PE
1512 * process.c: Rename or move locals to avoid shadowing.
1513 (list_processes_1, Fmake_network_process):
1514 (read_process_output_error_handler, exec_sentinel_error_handler):
1515 Rename or move locals.
4dc343ee 1516 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1517 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1518 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1519 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1520 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1521
af8a867c 1522 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1523 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1524 Include tparam.h instead, since it declares them.
af8a867c
PE
1525 * cm.h (PC): Remove extern decl; tparam.h now does this.
1526 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1527 * terminfo.c: Include tparam.h, to check interfaces.
1528 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1529 (tparam): Adjust signature to match interface in tparam.h;
1530 this removes some undefined behavior. Check that outstring and len
1531 are zero, which they always are with Emacs.
1532 * tparam.h (PC, BC, UP): New extern decls.
1533
0248044d 1534 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1535 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1536
8ff096c1 1537 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1538 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1539 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1540 (ftfont_list): Remove unused local.
49eaafba
PE
1541 (get_adstyle_property, ftfont_pattern_entity):
1542 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1543 Rename locals to avoid shadowing.
8ff096c1 1544
e2be39f6
PE
1545 * xfont.c (xfont_list_family): Mark var as initialized.
1546
c9735e30
PE
1547 * xml.c (make_dom): Now static.
1548
8f5201ae
PE
1549 * composite.c (composition_compute_stop_pos): Rename local to
1550 avoid shadowing.
b246f932
PE
1551 (composition_reseat_it): Remove unused locals.
1552 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1553 (composition_update_it): Mark var as initialized.
11b61122
PE
1554 (find_automatic_composition): Mark vars as initialized,
1555 with a FIXME (Bug#8290).
8f5201ae 1556
760fbc2c
PE
1557 character.h: Rename locals to avoid shadowing.
1558 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1559 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1560 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1561 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1562 to avoid shadowing.
1563
ff08eb85
PE
1564 * textprop.c (property_change_between_p): Remove; unused.
1565
fc7bf025
PE
1566 * intervals.c (interval_start_pos): Now static.
1567
235d7abc
PE
1568 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1569
44f230aa
SM
1570 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1571 Rename locals to avoid shadowing.
3e7d6594 1572
50060332
PE
1573 * sound.c (wav_play, au_play, Fplay_sound_internal):
1574 Fix pointer signedness.
d01f234b 1575 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1576 (wav_play): Initialize a variable to 0, to prevent undefined
1577 behavior (Bug#8278).
50060332 1578
c4fc4e30
PE
1579 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1580
918436ed
PE
1581 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1582
c939f91b
PE
1583 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1584 clobbering (Bug#8298).
b9c7f648
PE
1585 * sysdep.c (sys_subshell): Likewise.
1586 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1587
6bd8c144
PE
1588 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1589 This should get cleaned up, so that child_setup has the
1590 same signature on all platforms.
1591
7710357c 1592 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1593 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1594
c59da222
CY
15952011-03-22 Chong Yidong <cyd@stupidchicken.com>
1596
1597 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1598 not to be necessary, and produces flickering.
1599
66b87493
GM
16002011-03-20 Glenn Morris <rgm@gnu.org>
1601
1602 * config.in: Remove file.
1603
45b6f6d5
JB
16042011-03-20 Juanma Barranquero <lekktu@gmail.com>
1605
1606 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1607 are now in src/globals.h.
1608 (syms_of_minibuf): Remove spurious & from previous change.
1609
3ec03f7e
LL
16102011-03-20 Leo <sdl.web@gmail.com>
1611
1612 * minibuf.c (completing-read-function): New variable.
1613 (completing-read-default): Rename from completing-read.
1614 (completing-read): Call completing-read-function.
1615
b14e3e21
CY
16162011-03-19 Juanma Barranquero <lekktu@gmail.com>
1617
1618 * xfaces.c (Fx_load_color_file):
1619 Read color file from absolute filename (bug#8250).
1620
f2b726e6
JB
16212011-03-19 Juanma Barranquero <lekktu@gmail.com>
1622
1623 * makefile.w32-in: Update dependencies.
1624
09f6ff02
EZ
16252011-03-17 Eli Zaretskii <eliz@gnu.org>
1626
1627 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1628
29a6015a
PE
16292011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1630
a3a6c54e
PE
1631 Fix more problems found by GCC 4.5.2's static checks.
1632
b766f867
PE
1633 * process.c (make_serial_process_unwind, send_process_trap):
1634 (sigchld_handler): Now static.
1635
be02381c
PE
1636 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1637 That way, the code declares only the vars that it needs.
1638 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1639 * s/cygwin.h (PTY_ITERATION): Likewise.
1640 * s/darwin.h (PTY_ITERATION): Likewise.
1641 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1642
57048744
PE
1643 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1644 * process.c (allocate_pty): Don't declare stb unless it's needed.
1645
7914961c 1646 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1647 (CONSTANTLIM): Remove; unused.
1648 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1649 Define only if needed.
7914961c 1650
b3967b18
PE
1651 * unexelf.c (unexec): Name an expression,
1652 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1653 Use a different way to cause a compilation error if anyone uses
1654 n rather than nn, a way that does not involve shadowing.
73366a00 1655 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1656
29a6015a
PE
1657 * deps.mk (unexalpha.o): Remove; unused.
1658
43cfc33e 1659 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1660 * unexec.h: New file.
ce701a33
PE
1661 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1662 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1663 Depend on unexec.h.
1664 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1665 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1666 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1667 Change as necessary to match prototype in unexec.h.
ce701a33 1668
01f44d5a
PE
1669 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1670 shadowing.
4f63c6bb 1671 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1672
a6670b0b
PE
1673 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1674 Rename locals to avoid shadowing.
1675
cef2010d 1676 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1677 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1678
d4d7173a
PE
1679 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1680
f08b802a
PE
1681 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1682 warning when compiling print.c.
1683
3ddb0639
PE
1684 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1685 instead of using an uninitialized var.
5ad03b97 1686 (font_sort_entities): Mark var as initialized.
3ddb0639 1687
170a2692
PE
1688 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1689
e663c700
PE
1690 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1691 pointers to constants.
89bc529a 1692 (font_parse_fcname): Remove unused vars.
7b81e2d0 1693 (font_delete_unmatched): Now static.
ea838e10 1694 (font_get_spec): Remove; unused.
13a547c6
PE
1695 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1696 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1697 Rename or move locals to avoid shadowing.
e663c700 1698
2a80c887 1699 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1700 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1701
1384fa33 1702 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1703 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1704
8b2c52e9
PE
1705 * alloc.c (mark_backtrace): Move decl from here ...
1706 * lisp.h: ... to here, so that it can be checked.
1707
475545b5 1708 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1709 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1710 (lisp_indirect_variable): Name an expression,
1711 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1712 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1713
b1349114 1714 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1715 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1716 Use const pointer when appropriate.
b1349114 1717
a2928364
PE
1718 * lisp.h (get_system_name, get_operating_system_release):
1719 Move decls here, to check interfaces.
1720 * process.c (get_operating_system_release): Move decl to lisp.h.
1721 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1722 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1723 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1724 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1725 (Fformat_time_string, Fencode_time, Finsert_char):
1726 (Ftranslate_region_internal, Fformat):
1727 Rename or remove local vars to avoid shadowing.
9710023e 1728 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1729
a415e694
PE
1730 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1731 avoid shadowing.
1732
8ef4622d
PE
1733 * lisp.h (eassert): Check that the argument compiles, even if
1734 ENABLE_CHECKING is not defined.
1735
946f9a5b
PE
1736 * data.c (Findirect_variable): Name an expression, to avoid
1737 gcc -Wbad-function-cast warning.
112396d6 1738 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1739 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1740 (Fmake_variable_buffer_local, Fmake_local_variable):
1741 Mark variables as initialized.
52746918 1742 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1743
e5aab7e7 1744 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1745 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1746 Rename locals to avoid shadowing.
dff45157
PE
1747 (mark_stack): Move local variables into the #ifdef region where
1748 they're used.
7bc26fdb
PE
1749 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1750 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1751 needed otherwise.
1752 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1753 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1754 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1755
e5aab7e7
PE
1756 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1757 avoids undefined behavior in theory.
1758
4da60324
PE
1759 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1760
88043301
PE
1761 Use functions, not macros, for up- and down-casing (Bug#8254).
1762 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1763 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1764 to use the following functions instead of these macros.
1765 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1766 EMACS_INT, since callers assume the returned value fits in int.
1767 (upcase1): Likewise, for UPCASE_TABLE.
1768 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1769 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1770 the race-condition problem in the old DOWNCASE.
88043301 1771
19ed5445
PE
1772 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1773 Rename locals to avoid shadowing.
1774 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1775 (regex_compile, re_search_2, re_match_2_internal):
1776 Remove unused local vars.
952db0d7
PE
1777 (FREE_VAR): Rewrite so as not to use empty "else",
1778 which gcc can warn about.
da053e48 1779 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1780 (RETALLOC_IF): Define only if needed.
1781 (WORDCHAR_P): Likewise. This one is never needed, but is used
1782 only in a comment talking about a compiler bug, so put inside
1783 the #if 0 of that comment.
1784 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1785 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1786 Remove; unused.
19ed5445 1787
1f3561e4 1788 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1789 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1790 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1791
ded6f8f7
PE
1792 * search.c (simple_search): Remove unused var.
1793
dbd37a95
PE
1794 * dired.c (compile_pattern): Move decl from here ...
1795 * lisp.h: ... to here, so that it can be checked.
1796 (struct re_registers): New forward decl.
1797
7e47afad
PE
1798 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1799
85f24f61
PE
1800 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1801 All uses changed.
1802 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1803 Rename locals to avoid shadowing.
5671df8f 1804 (Fvertical_motion): Mark locals as initialized.
85f24f61 1805
181aa2be 1806 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1807 (casify_region): Mark local as initialized.
181aa2be 1808
930d429c
PE
1809 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1810
7082eac6
PE
1811 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1812 New macros, so that the caller can use some names other than
1813 gcpro1, gcpro2, etc.
1814 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1815 of the new macros.
1816 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1817 argument, for consistency with GCPRO2_VAR, etc: it is now the
1818 prefix of the variable, not the variable itself. All uses
1819 changed.
38b2c076
PE
1820 * dired.c (directory_files_internal, file_name_completion):
1821 Rename locals to avoid shadowing.
1822
15206ed9
PE
1823 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1824 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1825 dired.c's scmp function, had undefined behavior.
1826 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1827 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1828 * buffer.h: ... to here, because these macros use current_buffer,
1829 and the new implementation with inline functions needs to have
1830 current_buffer in scope now, rather than later when the macros
1831 are used.
1832 (downcase, upcase1): New static inline functions.
1833 (DOWNCASE, UPCASE1): Reimplement using these functions.
1834 This avoids undefined behavior in expressions like
1835 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1836 from race conditions in accessing the global variables
1837 case_temp1 and case_temp2.
1838 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1839 * lisp.h (case_temp1, case_temp2): Remove their decls.
1840 * character.h (ASCII_CHAR_P): Move from here ...
1841 * lisp.h: ... to here, so that the inline functions mentioned
1842 above can use them.
1843
4a6bea26
PE
1844 * dired.c (directory_files_internal_unwind): Now static.
1845
f14b7e14
PE
1846 * fileio.c (file_name_as_directory, directory_file_name):
1847 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1848 Now static.
2893f146
PE
1849 (file_name_as_directory): Use const pointers when appropriate.
1850 (Fexpand_file_name): Likewise. In particular, newdir might
1851 point at constant storage, so make it a const pointer.
fd4ead52 1852 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1853 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1854 signedness issues.
f839df0c
PE
1855 (Fset_file_times, Finsert_file_contents, auto_save_error):
1856 Rename locals to avoid shadowing.
f14b7e14 1857
5716756e 1858 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1859 (Ftry_completion, Fall_completions): Rename or remove locals
1860 to avoid shadowing.
5716756e 1861
b4c3046a
PE
1862 * marker.c (bytepos_to_charpos): Remove; unused.
1863
b45db522
PE
1864 * lisp.h (verify_bytepos, count_markers): New decls,
1865 so that gcc does not warn that these functions aren't declared.
1866
85876d07
PE
1867 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1868 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1869 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1870 (copy_text): Remove unused local var.
85876d07 1871
03d78a21 1872 * filelock.c (within_one_second): Now static.
b3dd38ab 1873 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1874
5df8f01b
PE
1875 * buffer.c (fix_overlays_before): Mark locals as initialized.
1876 (fix_start_end_in_overlays): Likewise. This function should be
1877 simplified by using pointers-to-pointers, but that's a different
1878 matter.
b1d876f1 1879 (switch_to_buffer_1): Now static.
8f54f30a
PE
1880 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1881 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1882
a70072c9 1883 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1884 Fix pointer signedness issue.
edced198
PE
1885 (sys_subshell): Mark local as volatile if checking for lint,
1886 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1887 (MAXPATHLEN): Define only if needed.
a70072c9 1888
a0977c44
PE
1889 * process.c (serial_open, serial_configure): Move decls from here ...
1890 * systty.h: ... to here, so that they can be checked.
1891
a884fdcc
PE
1892 * fns.c (get_random, seed_random): Move extern decls from here ...
1893 * lisp.h: ... to here, so that they can be checked.
1894
604efe86 1895 * sysdep.c (reset_io): Now static.
b8950c94 1896 (wait_for_termination_signal): Remove; unused.
604efe86 1897
38fc62d9
PE
1898 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1899 (copy_keymap_item, append_key, push_text_char_description):
1900 Now static.
1004a21a 1901 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1902 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1903 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1904 (describe_map_tree):
1905 Rename locals to avoid shadowing.
38fc62d9 1906
2f2650da
PE
1907 * keyboard.c: Declare functions static if they are not used elsewhere.
1908 (echo_char, echo_dash, cmd_error, top_level_2):
1909 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1910 (read_char, kbd_buffer_get_event, make_lispy_position):
1911 (make_lispy_event, make_lispy_movement, apply_modifiers):
1912 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1913 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1914 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1915 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1916 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1917
a053e86c 1918 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1919 (mark_kboards): Move decl here ...
1920 * alloc.c (mark_kboards): ... from here.
a053e86c 1921
4752793e
PE
1922 * lisp.h (force_auto_save_soon): New decl.
1923
74f10ca7 1924 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1925 (DEFINE_DUMMY_FUNCTION): New macro.
1926 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1927 Use it.
c03cd23f
PE
1928 (main): Add casts to avoid warnings
1929 if GCC considers string literals to be constants.
74f10ca7 1930
022e70d4
PE
1931 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1932
59d6fe83
PE
1933 * dbusbind.c: Pointer signedness fixes.
1934 (xd_signature, xd_append_arg, xd_initialize):
1935 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1936 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1937 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1938 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1939
78320123
PE
1940 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1941 if GCC considers string literals to be constants.
49cebcca 1942 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1943
35ac2a97
SM
19442011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1945
fb103ca9
SM
1946 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1947 (print_preprocess, print_object): New macro to fix last change.
1948
35ac2a97
SM
1949 * print.c (print_preprocess): Don't forget font objects.
1950
62973b41
JB
19512011-03-16 Juanma Barranquero <lekktu@gmail.com>
1952
1953 * emacs.c (USAGE3): Doc fixes.
1954
0e48bb22
AS
19552011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1956
1957 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1958 structure.
1959
7684e57b
JB
19602011-03-14 Juanma Barranquero <lekktu@gmail.com>
1961
1962 * lisp.h (VWindow_system, Qfile_name_history):
1963 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1964 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1965 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1966
1967 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1968 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1969
1970 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1971 * w32console.c (detect_input_pending, read_input_pending)
1972 (encode_terminal_code):
1973 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1974 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1975 (w32_system_caret_y, Qfile_name_history):
1976 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1977 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1978 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1979 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1980 * w32proc.c (Qlocal, report_file_error):
1981 * w32term.c (Vwindow_system, updating_frame):
1982 * w32uniscribe.c (initialized, uniscribe_font_driver):
1983 Remove unneeded extern declarations.
1984
2aa46d6c
CY
19852011-03-14 Chong Yidong <cyd@stupidchicken.com>
1986
c96bbc66 1987 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1988
cffc6f3b
CY
19892011-03-13 Chong Yidong <cyd@stupidchicken.com>
1990
1991 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1992 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1993 These macros can no longer be used for assignment.
1994
44f230aa
SM
1995 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1996 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1997 (record_buffer_markers, fetch_buffer_markers): New functions for
1998 recording and fetching special buffer markers.
1999 (set_buffer_internal_1, set_buffer_temp): Use them.
2000
2001 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2002
2003 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2004
2005 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2006 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2007
2008 * xdisp.c (hscroll_window_tree):
2009 (reconsider_clip_changes): Use PT instead of BUF_PT.
2010
d251f04b
EZ
20112011-03-13 Eli Zaretskii <eliz@gnu.org>
2012
2013 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2014 $(EMACS_ROOT)/lib/intprops.h.
2015
f0c77cd1
PE
20162011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2017
3eca4629
PE
2018 Fix more problems found by GCC 4.5.2's static checks.
2019
7c86ee98
PE
2020 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2021 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2022 (xg_free_frame_widgets): Make it clear that a local variable is
2023 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2024 (gdk_window_get_screen): Make it clear that this macro is needed
2025 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2026 (int_gtk_range_get_value): New function, which avoids a diagnostic
2027 from gcc -Wbad-function-cast.
2028 (xg_set_toolkit_scroll_bar_thumb): Use it.
2029 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2030 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2031 (get_utf8_string, xg_get_file_with_chooser):
2032 Rename locals to avoid shadowing.
2033 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2034
41729b81
PE
2035 * xgselect.c (xg_select): Remove unused var.
2036
f0c77cd1
PE
2037 * image.c (four_corners_best): Mark locals as initialized.
2038 (gif_load): Initialize transparent_p to zero (Bug#8238).
2039 Mark another local as initialized.
ec6cf4c6 2040 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2041
ce0ad53d 2042 * image.c (clear_image_cache): Now static.
d5d5a617 2043 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2044 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2045 (x_edge_detection): Remove unnecessary cast that
2046 gcc -Wbad-function-cast diagnoses.
2037898d 2047 (gif_load): Fix pointer signedness.
6ae141d6
PE
2048 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2049 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2050
33383987 20512011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2052
d32df629
PE
2053 Improve quality of tests for time stamp overflow.
2054 For example, without this patch (encode-time 0 0 0 1 1
2055 1152921504606846976) returns the obviously-bogus value (-948597
2056 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2057 reports time overflow. See
2058 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2059 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2060 * editfns.c: Include limits.h and intprops.h.
2061 (TIME_T_MIN, TIME_T_MAX): New macros.
2062 (time_overflow): Move earlier, to before first use.
2063 (hi_time, lo_time): New functions, for an accurate test for
2064 out-of-range times.
2065 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2066 (Fget_internal_run_time): Don't assume time_t fits in int.
2067 (make_time): Use list2 instead of Fcons twice.
2068 (Fdecode_time): More accurate test for out-of-range times.
2069 (check_tm_member): New function.
2070 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2071 (lisp_time_argument): Don't rely on undefined left-shift and
2072 right-shift behavior when checking for time stamp overflow.
8be6f318 2073
fe31d94c
PE
2074 * editfns.c (time_overflow): New function, refactoring common code.
2075 (Fformat_time_string, Fdecode_time, Fencode_time):
2076 (Fcurrent_time_string): Use it.
2077
8be6f318
PE
2078 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2079 * dired.c (make_time): Move to ...
2080 * editfns.c (make_time): ... here.
2081 * systime.h: Note the move.
2082
09d9db2c 20832011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2084
126bc0dc
YM
2085 * fringe.c (update_window_fringes): Remove unused variables.
2086
c47cbdfd
YM
2087 * unexmacosx.c (copy_data_segment): Also copy __got section.
2088 (Bug#8223)
2089
7ac80be9
EZ
20902011-03-12 Eli Zaretskii <eliz@gnu.org>
2091
c96bbc66 2092 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2093 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2094 Constify `char *' arguments and their references according to
2095 prototypes in tparam.h.
2096
ecb0f94d 2097 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2098
7ac80be9
EZ
2099 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2100 Adapt all references accordingly.
2101
2102 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2103
ef1fd07e
TT
21042011-03-11 Tom Tromey <tromey@redhat.com>
2105
2106 * buffer.c (syms_of_buffer): Remove obsolete comment.
2107
7ef4b50c
EZ
21082011-03-11 Eli Zaretskii <eliz@gnu.org>
2109
2110 * termhooks.h (encode_terminal_code): Declare prototype.
2111
2112 * msdos.c (encode_terminal_code): Don't declare prototype.
2113
2114 * term.c (encode_terminal_code): Now external again, used by
2115 w32console.c and msdos.c.
2116
44f230aa
SM
2117 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2118 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2119
4b1ec863 21202011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2121
1714f52b 2122 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2123
4b1ec863
PE
2124 * fringe.c (update_window_fringes): Mark locals as initialized
2125 (Bug#8227).
2126 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2127
524c7aa6
PE
2128 * alloc.c (mark_fringe_data): Move decl from here ...
2129 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2130 to check its interface.
2131 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2132
a5c0af81 2133 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2134 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2135 (fontset_font): Mark local as initialized.
a9a06e0b 2136 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2137
b4716021
PE
2138 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2139
811e9bac 2140 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2141 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2142 (x_own_selection, Fx_disown_selection_internal): Rename locals
2143 to avoid shadowing.
2144 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2145
7e3ab302
PE
2146 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2147 so that the caller can use some name other than gcpro1.
2148 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2149 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2150 (Fx_backspace_delete_keys_p):
2151 Use them to avoid shadowing, and rename vars to avoid shadowing.
2152 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2153 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2154 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2155 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2156 Remove unused locals.
7e3ab302
PE
2157 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2158 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2159 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2160 macros.
f78faa98 2161
e2b13473
PE
2162 * xterm.h (x_mouse_leave): New decl.
2163
77f23912
PE
2164 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2165 Remove unused functions.
cdf4ba58
PE
2166 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2167 (x_calc_absolute_position): Now static.
7411c686 2168 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2169 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2170 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2171 unless they are used.
38d0b34a
PE
2172 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2173 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2174 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2175 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2176 (x_error_catcher, x_connection_closed, x_error_handler):
2177 (x_error_quitter, xembed_send_message, x_iconify_frame):
2178 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2179 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2180 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2181
44f230aa
SM
2182 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2183 Rename or move locals to avoid shadowing.
6b463e58 2184 (tty_defined_color, merge_face_heights): Now static.
5967d051 2185 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2186 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2187 does not deduce is never used uninitialized.
73719eba
PE
2188 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2189 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2190
426994c3 2191 * terminal.c (store_terminal_param): Now static.
5489860b 2192
032f1620 2193 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2194 (set_frame_menubar): Remove unused local.
d4323972 2195 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2196 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2197 since they might point to immutable storage.
281585b0
PE
2198 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2199 since it's unused otherwise.
032f1620 2200
367c19e5 2201 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2202 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2203 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2204 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2205 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2206 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2207 does not deduce are never used uninitialized.
70739cbe 2208
07b48fa9
PE
2209 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2210
8868a238 2211 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2212 * window.c (window_loop, size_window):
2213 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2214
7e5cf297 2215 * window.c (display_buffer): Now static.
d6550a9f
PE
2216 (size_window): Mark variables that gcc -Wuninitialized
2217 does not deduce are never used uninitialized.
a586633d
PE
2218 * window.h (check_all_windows): New decl, to forestall
2219 gcc -Wmissing-prototypes diagnostic.
5b555da1 2220 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2221
f6095868
PE
2222 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2223 shadowing.
2224 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2225 Include <limits.h>.
2226 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2227 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2228 (load_charset_map): Mark variables that gcc -Wuninitialized
2229 does not deduce are never used uninitialized.
53df7c11 2230 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2231
f38b440c
PE
2232 * coding.c (coding_set_source, coding_set_destination):
2233 Use "else { /* comment */ }" rather than "else /* comment */;"
2234 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2235 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2236 a block, when the outer 'i' will do.
2237 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2238 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2239 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2240 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2241 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2242 Rename locals to avoid shadowing.
2243 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2244 * coding.c (emacs_mule_char, encode_invocation_designation):
2245 Now static, since they're not used elsewhere.
413bb2db 2246 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2247 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2248 (decode_coding_emacs_mule): Mark variables that gcc
2249 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2250 (detect_coding_iso_2022): Initialize a local variable that might
2251 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2252 this initialization is needed. (Bug#8211)
5f58e762
PE
2253 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2254 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2255 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2256 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2257 Remove unused macros.
f38b440c 2258
232b38b9 2259 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2260 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2261 * character.c (string_count_byte8): Likewise.
232b38b9 2262
fb90da1b
PE
2263 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2264 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2265
fb93dbc2
PE
2266 * chartab.c (copy_sub_char_table): Now static, since it's not used
2267 elsewhere.
5c156ace
PE
2268 (sub_char_table_ref_and_range, char_table_ref_and_range):
2269 Rename locals to avoid shadowing.
bbcd0949 2270 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2271
7d3b3862 2272 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2273 (BIDI_BOB): Remove unused macro.
7d3b3862 2274
6be7d3da
PE
2275 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2276 deduce are never used uninitialized.
c2ed9c8b 2277 * term.c (encode_terminal_code): Likewise.
6be7d3da 2278
75f8807f 2279 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2280
50938595
PE
2281 * tparam.h: New file.
2282 * term.c, tparam.h: Include it.
2283 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2284 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2285 Move these decls to tparam.h, and make them agree with what
2286 is actually in tparam.c. The previous trick of using incompatible
2287 decls in different modules does not conform to the C standard.
2288 All callers of tparam changed to use tparam's actual API.
2289 * tparam.c (tparam1, tparam, tgoto):
2290 Use const pointers where appropriate.
2291
fbceeba2
PE
2292 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2293 * cm.h (struct cm): Likewise.
2294 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2295 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2296 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2297 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2298 (turn_on_face, init_tty): Likewise.
2299 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2300
7f3f1250
PE
2301 * term.c (term_mouse_position): Rename local to avoid shadowing.
2302
e6ca6543
PE
2303 * alloc.c (mark_ttys): Move decl from here ...
2304 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2305
c40f8d15
AS
23062011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2307
2308 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2309
cfe0661d
JB
23102011-03-09 Juanma Barranquero <lekktu@gmail.com>
2311
2312 * search.c (compile_pattern_1): Remove argument regp, unused since
2313 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2314 (compile_pattern): Don't pass it.
2315
0afb4571
J
23162011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2317
2318 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2319 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2320 for ! HAVE_GTK3.
2321 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2322
2323 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2324
2325 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2326 gdk_window_get_screen, gdk_window_get_geometry,
2327 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2328 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2329 (xg_get_pixbuf_from_pixmap): New function.
2330 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2331 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2332 Call xg_get_pixbuf_from_pixmap instead of
2333 gdk_pixbuf_get_from_drawable.
2334 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2335 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2336 (xg_check_special_colors): Use GtkStyleContext and its functions
2337 for HAVE_GTK3.
2338 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2339 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2340 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2341 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2342 Call gtk_widget_get_preferred_size.
0afb4571
J
2343 (xg_frame_resized): gdk_window_get_geometry only takes 5
2344 parameters.
44f230aa
SM
2345 (xg_win_to_widget, xg_event_is_for_menubar):
2346 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2347 (xg_set_widget_bg): New function.
2348 (delete_cb): New function.
2349 (xg_create_frame_widgets): connect delete-event to delete_cb.
2350 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2351 (xg_set_background_color): Call xg_set_widget_bg.
2352 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2353 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2354 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2355 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2356 if ! HAVE_GTK3.
2357 (update_frame_tool_bar): Call gtk_widget_hide.
2358 (xg_initialize): Use GDK_KEY_g.
2359
2360 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2361 if ! HAVE_GTK3
2362 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2363
2364 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2365 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2366 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2367
1c2cc4ef
JB
23682011-03-08 Juanma Barranquero <lekktu@gmail.com>
2369
2370 * w32xfns.c (select_palette): Check success of RealizePalette against
2371 GDI_ERROR, not zero.
2372
33383987 2373See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2374
2375;; Local Variables:
2376;; coding: utf-8
aac0c6e3
MR
2377;; End:
2378
33383987 2379 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2380
2381 This file is part of GNU Emacs.
2382
2383 GNU Emacs is free software: you can redistribute it and/or modify
2384 it under the terms of the GNU General Public License as published by
2385 the Free Software Foundation, either version 3 of the License, or
2386 (at your option) any later version.
2387
2388 GNU Emacs is distributed in the hope that it will be useful,
2389 but WITHOUT ANY WARRANTY; without even the implied warranty of
2390 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2391 GNU General Public License for more details.
2392
2393 You should have received a copy of the GNU General Public License
2394 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.