src/xdisp.c (single_display_spec_string): Correct a FIXME comment.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c40e2fb2
EZ
12011-05-28 Eli Zaretskii <eliz@gnu.org>
2
0e14fe90
EZ
3 * xdisp.c (set_cursor_from_row): Set start and stop points
4 according to the row's direction when priming the loop that looks
5 for the glyph on which to display cursor.
6 (single_display_spec_intangible_p): Function deleted.
7 (display_prop_intangible_p): Reimplement to call
8 handle_display_spec instead of single_display_spec_intangible_p.
9 Accept 3 additional arguments needed by handle_display_spec. This
10 fixes incorrect cursor motion across display property with complex
11 values: lists, `(when COND...)' forms, etc.
12 (single_display_spec_string_p): Support property values that are
13 lists with the argument STRING its top-level element.
14 (display_prop_string_p): Fix the condition for processing a
15 property that is a list to be consistent with handle_display_spec.
16
17 * keyboard.c (adjust_point_for_property): Adjust the call to
18 display_prop_intangible_p to its new signature.
19
20 * dispextern.h (display_prop_intangible_p): Adjust prototype.
c40e2fb2 21
fc6f18ce
EZ
222011-05-21 Eli Zaretskii <eliz@gnu.org>
23
24 * xdisp.c (handle_display_spec): New function, refactored from the
25 last portion of handle_display_prop.
26 (compute_display_string_pos): Accept additional argument
27 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
28 value of a `display' property is a "replacing spec".
29 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
30 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
31 the display property, but just return a value indicating whether
32 the display property will replace the characters it covers.
33 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
34 frame_window_p members of struct bidi_it.
35
36 * bidi.c (bidi_fetch_char): Accept additional argument
37 FRAME_WINDOW_P and pass it to compute_display_string_pos. All
38 callers changed.
39 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
40 it to initialize the frame_window_p member of struct bidi_it.
41
42 * dispextern.h (struct bidi_it): New member frame_window_p.
43 (bidi_init_it, compute_display_string_pos): Update prototypes.
44
102ebb00
EZ
452011-05-14 Eli Zaretskii <eliz@gnu.org>
46
7b600102
EZ
47 * xdisp.c (compute_display_string_pos): Non-trivial implementation.
48 (compute_display_string_end): New function.
683a44f7
EZ
49 (push_it): Accept second argument POSITION, where pop_it should
50 jump to continue iteration.
7b600102
EZ
51
52 * dispextern.h (compute_display_string_end): Declare prototype.
53
54 * bidi.c (bidi_resolve_explicit_1): Use ZV for disp_pos.
55 (bidi_fetch_char): Implement support for runs of characters
56 covered by display strings.
57
102ebb00 58 * bidi.c (bidi_fetch_char): Accept also character position
7b600102
EZ
59 corresponding to BYTEPOS. DISP_POS is now a character position,
60 not a byte position. All callers changed.
102ebb00
EZ
61 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
62 (bidi_resolve_explicit, bidi_resolve_weak)
63 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
64 bidi_it->nchars is non-positive.
65 (bidi_level_of_next_char): Don't try to lookup the cache for the
66 next/previous character if nothing is cached there yet, or if we
67 were just reseat()'ed to a new position.
68 (bidi_paragraph_init, bidi_resolve_explicit_1)
69 (bidi_level_of_next_char): Fix arguments in the calls to
70 bidi_fetch_char.
71
182ce2d2
EZ
722011-05-10 Eli Zaretskii <eliz@gnu.org>
73
74 * xdisp.c (compute_display_string_pos): New function.
75 (reseat_1): Initialize bidi_it.disp_pos.
76
77 * bidi.c (bidi_copy_it): Use offsetof.
78 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
79 (bidi_cache_search, bidi_cache_iterator_state)
80 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
81 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
82 character positions inside a run of characters covered by a
83 display string.
84 (bidi_paragraph_init, bidi_resolve_explicit_1)
85 (bidi_level_of_next_char): Call bidi_fetch_char and
86 bidi_fetch_char_advance instead of FETCH_CHAR and
87 FETCH_CHAR_ADVANCE.
88 (bidi_init_it): Initialize new members.
89 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
90 definitions.
91 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
92 instead of using explicit *_CHAR codes.
93 (bidi_resolve_explicit, bidi_resolve_weak): Use
94 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
95 bidirectional text is supported only in multibyte buffers.
96
97 * dispextern.h (struct bidi_it): New members nchars and disp_pos.
98 ch_len is now EMACS_INT.
99 (compute_display_string_pos): Declare prototype.
100
57679c86
AS
1012011-05-09 Andreas Schwab <schwab@linux-m68k.org>
102
103 * w32menu.c (set_frame_menubar): Fix submenu allocation.
104
888c9e86
EZ
1052011-05-07 Eli Zaretskii <eliz@gnu.org>
106
b0512a1d
EZ
107 * w32console.c (Fset_screen_color): Doc fix.
108 (Fget_screen_color): New function.
109 (syms_of_ntterm): Defsubr it.
110
888c9e86
EZ
111 * callproc.c (call_process_cleanup): Don't close and unlink the
112 temporary file if Fcall_process didn't create it in the first
113 place.
114 (Fcall_process): Don't create tempfile if stdout of the child
115 process will be redirected to a file specified with `:file'.
116 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
117 cue to call_process_cleanup not to close that handle.
118
4d3fcc8e
BK
1192011-05-07 Ben Key <bkey76@gmail.com>
120
121 * makefile.w32-in: The bootstrap-temacs rule now makes use of
122 one of two shell specific rules, either bootstrap-temacs-CMD or
123 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
124 to the previous implementation of the bootstrap-temacs rule.
125 The bootstrap-temacs-CMD rule is similar to the previous
126 implementation of the bootstrap-temacs rule except that it
127 makes use of the ESC_CFLAGS variable instead of the CFLAGS
128 variable.
129
130 These changes, along with some changes to nt/configure.bat,
131 nt/gmake.defs, and nt/nmake.defs, are required to extend my
132 earlier fix to add support for --cflags and --ldflags options
133 that include quotes so that it works whether make uses cmd or
134 sh as the shell.
135
b4289b64
MA
1362011-05-06 Michael Albinus <michael.albinus@gmx.de>
137
138 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
139 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
140 is a constant.
141 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
142 a string. Handle both cases.
143 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
144 (Fdbus_register_method): Use Qinvalid_function.
145
af4c0e28
JB
1462011-05-06 Juanma Barranquero <lekktu@gmail.com>
147
148 * makefile.w32-in: Update dependencies.
149 (LISP_H): Add inttypes.h and stdin.h.
150 (PROCESS_H): Add unistd.h.
151
c51453d9
EZ
1522011-05-06 Eli Zaretskii <eliz@gnu.org>
153
154 * lread.c: Include limits.h (fixes the MS-Windows build broken by
155 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
156
8ff0ac3c 1572011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 158
4c4b566b
PE
159 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
160
aab2b9b5
PE
161 * term.c (vfatal): Remove stray call to va_end.
162 It's not needed and the C Standard doesn't allow it here anyway.
163
c378da0b
PE
164 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
165 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
166
288b08c7
PE
167 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
168 bytes.
169
e3601888
PE
170 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
171
db6c0e74
PE
172 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
173
dd5963ea
PE
174 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
175
88c9450f
PE
176 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
177
2f9442b8
PE
178 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
179
c032b5f8
PE
180 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
181 * charset.c (Fdefine_charset_internal): Don't initialize
182 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 183 32-bit int (Bug#8600).
a108c10b
PE
184
185 * lread.c (read_integer): Be more consistent with string-to-number.
186 Use string_to_number to do the actual conversion; this avoids
187 rounding errors and fixes some other screwups. Without this fix,
188 for example, #x1fffffffffffffff was misread as -2305843009213693952.
189 (digit_to_number): Move earlier, for benefit of read_integer.
190 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 191 not a digit in any supported base. (Bug#8602)
a108c10b 192
ad5f9eea
PE
193 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
194
aec1708a
PE
195 * dispnew.c (scrolling_window): Return 1 if we scrolled,
196 to match comment at start of function. This also removes a
197 GCC warning about overflow in a 32+64-bit port.
198
47be4ab5
PE
199 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
200
371cac43
PE
201 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
202 Reported by Stefan Monnier in
203 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
204 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
205 SYMBOLP-guarded XSYMBOL, not XPNTR.
206
d01a7826
PE
207 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
208 (EMACS_UINTPTR): Likewise, with uintptr_t.
209
7fd47d5c
PE
210 * lisp.h: Prefer 64-bit EMACS_INT if available.
211 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
212 on 32-bit hosts that have 64-bit int, so that they can access
213 large files.
122b0c86
PE
214 However, temporarily disable this change unless the temporary
215 symbol WIDE_EMACS_INT is defined.
7fd47d5c 216
8727937b
PE
217 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
218
8ac068ac
PE
219 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
220 This removes an assumption that EMACS_INT and long are the same
221 width as pointers. The assumption is true for Emacs porting targets
222 now, but we want to make other targets possible.
223 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
224 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
225 In the rest of the code, change types of integers that hold casted
226 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
227 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
228 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
229 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
230 No need to cast type when ORing.
231 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
232 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
233 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
234 assume EMACS_INT is the same width as char *.
235 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
236 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
237 Remove no-longer-needed casts.
238 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
239 (xg_tool_bar_help_callback, xg_make_tool_item):
240 Use EMACS_INTPTR to hold an integer
241 that will be cast to void *; this can avoid a GCC warning
242 if EMACS_INT is not the same width as void *.
243 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
244 * xdisp.c (display_echo_area_1, resize_mini_window_1):
245 (current_message_1, set_message_1):
246 Use a local to convert to proper width without a cast.
247 * xmenu.c (dialog_selection_callback): Likewise.
248
ede49d71
PE
249 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
250 Also, don't assume VALBITS / RAND_BITS is less than 5,
251 and don't rely on undefined behavior when shifting a 1 left into
252 the sign bit.
253 * lisp.h (get_random): Change signature to match.
254
2f30ecd0
PE
255 * lread.c (hash_string): Use size_t, not int, for hash computation.
256 Normally we prefer signed values; but hashing is special, because
257 it's better to use unsigned division on hash table sizes so that
258 the remainder is nonnegative. Also, size_t is the natural width
259 for hashing into memory. The previous code used 'int', which doesn't
260 retain enough info to hash well into very large tables.
261 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
262
2a866e7b
PE
263 * dbusbind.c: Don't possibly lose pointer info when converting.
264 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
265 Use XPNTR rather than XHASH, so that the high-order bits of
266 the pointer aren't lost when converting through void *.
267
51639eac
PE
268 * eval.c (Fautoload): Don't double-shift a pointer.
269
92394119
PE
270 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
271
dbdb9a7c
JB
2722011-05-06 Juanma Barranquero <lekktu@gmail.com>
273
274 * gnutls.c (DEF_GNUTLS_FN):
275 * image.c (DEF_IMGLIB_FN): Make function pointers static.
276
db7a0b4f
AS
2772011-05-05 Andreas Schwab <schwab@linux-m68k.org>
278
279 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
280 marker. (Bug#8610)
281
f7ff1b0f 2822011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
283
284 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
285 New version that can reserve upto 2GB of heap space.
286
f7ff1b0f 2872011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
288
289 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
290
639c109b
TZ
2912011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
292
293 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
294 `gnutls_certificate_set_x509_key_file'.
295
d2127135
JB
2962011-05-05 Juanma Barranquero <lekktu@gmail.com>
297
298 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
299 Update dependencies.
300
e968f4f3
JB
3012011-05-04 Juanma Barranquero <lekktu@gmail.com>
302
303 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
304 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
305 Remove unused parameter `fildes'.
306 * process.c (read_process_output, send_process): Don't pass it.
307
84d358f0
JB
3082011-05-04 Juanma Barranquero <lekktu@gmail.com>
309
310 Fix previous change: the library cache is defined in w32.c.
311 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
312 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
313
0898ca10
JB
3142011-05-04 Juanma Barranquero <lekktu@gmail.com>
315
316 Implement dynamic loading of GnuTLS on Windows.
317
318 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
319 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
320 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
321 Declare.
322
323 * gnutls.c (Qgnutls_dll): Define.
324 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
325 (gnutls_*): Declare function pointers.
326 (init_gnutls_functions): New function to initialize function pointers.
327 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
328 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
329 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
330 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
331 (emacs_gnutls_write, emacs_gnutls_read)
332 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
333 (Fgnutls_available_p): New function.
334 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
335 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
336 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
337
338 * image.c: Include w32.h.
339 (Vimage_type_cache): Delete.
340 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
341 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
342 (w32_delayed_load): Move to w32.c.
343
344 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
345
346 * w32.c (QCloaded_from, Vlibrary_cache): Define.
347 (w32_delayed_load): Move from image.c. When loading a library, record
348 its filename in the :loaded-from property of the library id.
349 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
350 Initialize and staticpro them.
351 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
352
353 * process.c: Include lisp.h before w32.h, not after.
354 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
355 instead of gnutls_record_check_pending.
356
357 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
358
ff4de4aa
TZ
3592011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
360
361 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
362 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
363 as passed in.
364
abe95abb
JD
3652011-05-03 Jan Djärv <jan.h.d@swipnet.se>
366
367 * xterm.c (x_set_frame_alpha): Do not set property on anything
368 else than FRAME_X_OUTER_WINDOW (Bug#8608).
369
e16e55d4
JB
3702011-05-02 Juanma Barranquero <lekktu@gmail.com>
371
372 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
373
bafcf6a5
JB
3742011-05-02 Juanma Barranquero <lekktu@gmail.com>
375
376 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
377 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
378 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
379 (gnutls_global_initialized, Qgnutls_bootprop_priority)
380 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
381 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
382 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
383 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
384 (Qgnutls_bootprop_callbacks_verify): Make static.
385
e7a6747f
AS
3862011-05-01 Andreas Schwab <schwab@linux-m68k.org>
387
19ed11ba
AS
388 * callproc.c: Indentation fixup.
389
e7a6747f
AS
390 * sysdep.c (wait_for_termination_1): Make static.
391 (wait_for_termination, interruptible_wait_for_termination): Move
392 after wait_for_termination_1.
393
1ef14cb4
LMI
3942011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
395
396 * sysdep.c (interruptible_wait_for_termination): New function
397 which is like wait_for_termination, but allows keyboard
398 interruptions.
399
400 * callproc.c (Fcall_process): Add (:file "file") as an option for
401 the STDOUT buffer.
402 (Fcall_process_region): Ditto.
403
330d880c
EZ
4042011-04-30 Eli Zaretskii <eliz@gnu.org>
405
8db90b73
EZ
406 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
407 rather than `XVECTOR (FOO)->size'.
408
330d880c
EZ
409 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
410 inttypes.h, as a gnulib replacement is used if it not available in
411 system headers.
412
15cbd324
EZ
4132011-04-21 Eli Zaretskii <eliz@gnu.org>
414
415 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
416 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
417 of MOST_POSITIVE_FIXNUM. (Bug#8528)
418
419 * coding.c (coding_alloc_by_realloc): Error out if destination
420 will grow beyond MOST_POSITIVE_FIXNUM.
421 (decode_coding_emacs_mule): Abort if there isn't enough place in
422 charbuf for the composition carryover bytes. Reserve an extra
423 space for up to 2 characters produced in a loop.
424 (decode_coding_iso_2022): Abort if there isn't enough place in
425 charbuf for the composition carryover bytes.
426
4272011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 428
ae940cca
EZ
429 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
430 aborting when %lld or %lll format is passed.
431 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
432 %llo or %llx format is passed. (Bug#8545)
433
03ab8921
EZ
434 * window.c (window_scroll_line_based): Use a marker instead of
435 simple variables to record original value of point. (Bug#7952)
436
afda1437
EZ
437 * doprnt.c (doprnt): Fix the case where a multibyte sequence
438 produced by %s or %c overflows available buffer space. (Bug#8545)
439
f76dee0c
PE
4402011-04-28 Paul Eggert <eggert@cs.ucla.edu>
441
442 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 443 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 444
fdc5744d
JB
4452011-04-28 Juanma Barranquero <lekktu@gmail.com>
446
447 * w32.c (init_environment): Warn about defaulting HOME to C:\.
448
638f053a
JB
4492011-04-28 Juanma Barranquero <lekktu@gmail.com>
450
451 * keyboard.c (Qdelayed_warnings_hook): Define.
452 (command_loop_1): Run `delayed-warnings-hook'
453 if Vdelayed_warnings_list is non-nil.
454 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
455 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
456
d178f871
EZ
4572011-04-28 Eli Zaretskii <eliz@gnu.org>
458
459 * doprnt.c (doprnt): Don't return value smaller than the buffer
460 size if the message was truncated. (Bug#8545).
461
b124fd93
JB
4622011-04-28 Juanma Barranquero <lekktu@gmail.com>
463
464 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
465 (Fx_window_property): #if-0 the whole functions, not just the bodies.
466
e810457d
PE
4672011-04-27 Paul Eggert <eggert@cs.ucla.edu>
468
469 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
470
ea51cceb
JB
4712011-04-27 Juanma Barranquero <lekktu@gmail.com>
472
473 * makefile.w32-in: Update dependencies.
474
94dcfacf
EZ
4752011-04-27 Eli Zaretskii <eliz@gnu.org>
476
477 Improve `doprnt' and its usage. (Bug#8545)
478 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
479 `format_end'. Remove support for %l as a conversion specifier.
480 Don't use xrealloc. Improve diagnostics when the %l size modifier
481 is used. Update the commentary.
482
483 * eval.c (verror): Simplify calculation of size_t.
484
485 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
486 messages.
487
f61f41d7
PE
4882011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
489
490 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
491 change.
492
96fb4434
PE
4932011-04-27 Paul Eggert <eggert@cs.ucla.edu>
494
495 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
496 This makes this file independent of the recent pseudovector change.
497
671875da 4982011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 499
69e9b5a3
PE
500 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
501
b5f869a7 502 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 503 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 504 Remove unused local.
c8926152 505 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 506
841a1577 507 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
508 GCC 4.6.0 optimizes based on type-based alias analysis. For
509 example, if b is of type struct buffer * and v of type struct
510 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
511 != &v->size, and therefore "v->size = 1; b->size = 2; return
512 v->size;" must therefore return 1. This assumption is incorrect
513 for Emacs, since it type-puns struct Lisp_Vector * with many other
514 types. To fix this problem, this patch adds a new type struct
f904488f 515 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
516 and pseudovectors, and helps optimizing compilers not get fooled
517 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
518 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
519 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
520 the size member.
eab3844f
PE
521 (XSETPVECTYPE): Rewrite in terms of new macro.
522 (XSETPVECTYPESIZE): New macro, specifying both type and size.
523 This is a bit clearer, and further avoids the possibility of
524 undesirable aliasing.
525 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 526 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
527 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
528 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
529 (ASIZE): Now uses header.size rather than size. All
530 previous uses of XVECTOR (foo)->size replaced to use this macro,
531 to avoid the hassle of writing XVECTOR (foo)->header.size.
532 (struct vectorlike_header): New type.
eab3844f
PE
533 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
534 object, to help avoid aliasing.
535 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
536 (SUBRP): Likewise, since Lisp_Subr is a special case.
537 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
538 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
539 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 540 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
541 changed to be "header.size" and "header.next".
542 * buffer.h (struct buffer): Likewise.
543 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
544 * frame.h (struct frame): Likewise.
545 * process.h (struct Lisp_Process): Likewise.
546 * termhooks.h (struct terminal): Likewise.
547 * window.c (struct save_window_data, struct saved_window): Likewise.
548 * window.h (struct window): Likewise.
549 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
550 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
551 * buffer.c (init_buffer_once): Likewise.
552 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
553 special case.
554 * process.c (Fformat_network_address): Use local var for size,
555 for brevity.
556
0df1eac5
PE
557 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
558
847ab9d1 559 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
560 * data.c (atof): Remove decl; no longer used or needed.
561 (digit_to_number): Move to lread.c.
562 (Fstring_to_number): Use new string_to_number function, to be
563 consistent with how the Lisp reader treats infinities and NaNs.
564 Do not assume that floating-point numbers represent EMACS_INT
565 without losing information; this is not true on most 64-bit hosts.
566 Avoid double-rounding errors, by insisting on integers when
567 parsing non-base-10 numbers, as the documentation specifies.
568 * lisp.h (string_to_number): New decl, replacing ...
569 (isfloat_string): Remove.
bc0a5c13 570 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 571 (read1): Do not accept +. and -. as integers; this
452f4150
PE
572 appears to have been a coding error. Similarly, do not accept
573 strings like +-1e0 as floating point numbers. Do not report
574 overflow for integer overflows unless the base is not 10 which
575 means we have no simple and reliable way to continue.
576 Break out the floating-point parsing into a new
577 function string_to_number, so that Fstring_to_number parses
578 floating point numbers consistently with the Lisp reader.
579 (digit_to_number): Moved here from data.c. Make it static inline.
580 (E_CHAR, EXP_INT): Remove, replacing with ...
581 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
582 (string_to_number): New function, replacing isfloat_string.
583 This function checks for valid syntax and produces the resulting
584 Lisp float number too. Rework it so that string-to-number
bc0a5c13 585 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
586 so that overflow for non-base-10 numbers is reported only when
587 there's no portable and simple way to convert to floating point.
452f4150 588
67769ffc
PE
589 * textprop.c (set_text_properties_1): Rewrite for clarity,
590 and to avoid GCC warning about integer overflow.
591
c20db43f
PE
592 * intervals.h (struct interval): Use EMACS_INT for members
593 where EMACS_UINT might cause problems. See
594 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
595 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
596 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
597 All uses changed.
37aa2f85
PE
598 (offset_intervals): Tell GCC not to worry about length overflow
599 when negating a negative length.
c20db43f 600
2538aa2f
PE
601 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
602 (overrun_check_free): Likewise.
603
f2d3008d
PE
604 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
605 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
606 word size.
607
ec8df744
PE
608 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
609 (gnutls_make_error): Rename local to avoid shadowing.
610 (gnutls_emacs_global_deinit): ifdef out; not used.
611 (Fgnutls_boot): Use const for pointer to readonly storage.
612 Comment out unused local. Fix pointer signedness problems.
613
640ee02d
PE
614 * lread.c (openp): Don't stuff size_t into an 'int'.
615 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
616 about possible signed overflow.
617
6048fb2a
PE
618 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
619 (GDK_KEY_g): Don't define if already defined.
620 (xg_prepare_tooltip): Avoid pointer signedness problem.
621 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
622
fa3c87e1
PE
623 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
624 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
625
2172544b
PE
626 * xfns.c (Fx_window_property): Simplify a bit,
627 to make a bit faster and to avoid GCC 4.6.0 warning.
628 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
629
9b821a21
PE
630 * fns.c (internal_equal): Don't assume size_t fits in int.
631
3c616cfa
PE
632 * alloc.c (compact_small_strings): Tighten assertion a little.
633
c2982e87
PE
634 Replace pEd with more-general pI, and fix some printf arg casts.
635 * lisp.h (pI): New macro, generalizing old pEd macro to other
636 conversion specifiers. For example, use "...%"pI"d..." rather
637 than "...%"pEd"...".
638 (pEd): Remove. All uses replaced with similar uses of pI.
639 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
640 * alloc.c (check_pure_size): Don't overflow by converting size to int.
641 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
642 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
643 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
644 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
645 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
646 64-bit hosts.
647 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
648 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
649 * print.c (safe_debug_print, print_object): Likewise.
650 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
651 to int.
6f04d126
PE
652 Use pI instead of if-then-else-abort. Use %p to avoid casts,
653 avoiding the 0 flag, which is not portable.
c2982e87
PE
654 * process.c (Fmake_network_process): Use pI to avoid cast.
655 * region-cache.c (pp_cache): Likewise.
656 * xdisp.c (decode_mode_spec): Likewise.
657 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
658 behavior on 64-bit hosts with printf arg.
6f04d126 659 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
660 (x_stop_queuing_selection_requests): Likewise.
661 (x_get_window_property): Don't truncate byte count to an 'int'
662 when tracing.
0b432f21 663
5e073ec7
PE
664 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
665 here, since it parses constructs like leading '-' and spaces,
666 which are not wanted; and it overflows with large numbers.
667 Instead, simply match F[0-9]+, which is what is wanted anyway.
668
36372bf9
PE
669 * alloc.c: Remove unportable assumptions about struct layout.
670 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
671 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
672 (allocate_vectorlike, make_pure_vector): Use the new macros,
673 plus offsetof, to remove unportable assumptions about struct layout.
674 These assumptions hold on all porting targets that I know of, but
675 they are not guaranteed, they're easy to remove, and removing them
676 makes further changes easier.
677
0b432f21
PE
678 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
679 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
680 (string_overrun_cookie): Now const. Use initializers that
681 don't formally overflow signed char, to avoid warnings.
000098c1
PE
682 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
683 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
684 (allocate_buffer): Don't assume sizeof (struct buffer) is a
685 multiple of sizeof (EMACS_INT); it need not be, if
686 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 687 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 688
895009e1
JB
6892011-04-26 Juanma Barranquero <lekktu@gmail.com>
690
691 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
692
6a7a1b0b
TZ
6932011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
694
695 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 696 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
697 Reported by Paul Eggert <eggert@cs.ucla.edu>.
698
841a1577 6992011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
700
701 * lisp.h (Qdebug): List symbol.
895009e1 702 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
703 * keyboard.c (debug-on-event): New variable.
704 (handle_user_signal): Break into debugger when debug-on-event
705 matches the current signal symbol.
706
f2d3ba6f
DN
7072011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
708
709 * alloc.c (check_sblock, check_string_bytes)
710 (check_string_free_list): Convert to standard C.
711
42ce4c63
TZ
7122011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
713
714 * w32.c (emacs_gnutls_push): Fix typo.
715
825cd63c
EZ
7162011-04-25 Eli Zaretskii <eliz@gnu.org>
717
fb11d64d
EZ
718 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
719 "cast to pointer from integer of different size".
720
825cd63c
EZ
721 Improve doprnt and its use in verror. (Bug#8545)
722 * doprnt.c (doprnt): Document the set of format control sequences
723 supported by the function. Use SAFE_ALLOCA instead of always
724 using `alloca'.
725
726 * eval.c (verror): Don't limit the buffer size at size_max-1, that
727 is one byte too soon. Don't use xrealloc; instead xfree and
728 xmalloc anew.
729
e061a11b
TZ
7302011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
731
732 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
733 callbacks stage.
734
735 * gnutls.c: Renamed global_initialized to
736 gnutls_global_initialized. Added internals for the
737 :verify-hostname-error, :verify-error, and :verify-flags
738 parameters of `gnutls-boot' and documented those parameters in the
739 docstring. Start callback support.
740 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
741 unless a fatal error occured. Call gnutls_alert_send_appropriate
742 on error. Return error code.
743 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
744 (emacs_gnutls_read): Likewise.
745 (Fgnutls_boot): Return handshake error code.
746 (emacs_gnutls_handle_error): New function.
747 (wsaerror_to_errno): Likewise.
748
749 * w32.h (emacs_gnutls_pull): Add prototype.
750 (emacs_gnutls_push): Likewise.
751
752 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
753 (emacs_gnutls_push): Likewise.
754
7552011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
756
757 * process.c (wait_reading_process_output): Check if GnuTLS
758 buffered some data internally if no FDs are set for TLS
759 connections.
760
761 * makefile.w32-in (OBJ2): Add gnutls.$(O).
762 (LIBS): Link to USER_LIBS.
763 ($(BLD)/gnutls.$(0)): New target.
764
fa6996bc
EZ
7652011-04-24 Eli Zaretskii <eliz@gnu.org>
766
eb35682e
EZ
767 * xdisp.c (handle_single_display_spec): Rename the
768 display_replaced_before_p argument into display_replaced_p, to
769 make it consistent with the commentary. Fix typos in the
770 commentary.
771
e2ad650c
EZ
772 * textprop.c (syms_of_textprop): Remove dead code.
773 (copy_text_properties): Delete obsolete commentary about an
774 interface that was deleted long ago. Fix typos in the description
775 of arguments.
776
1b2de274
EZ
777 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
778 to changes in oldXMenu/XMenu.h from 2011-04-16.
779 <menu_help_message, prev_menu_help_message>: Constify.
780 (IT_menu_make_room): menu->help_text is now `const char **';
781 adjust.
782
783 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
784 to changes in oldXMenu/XMenu.h from 2011-04-16.
785 (struct XMenu): Declare `help_text' `const char **'.
786
787 * xfaces.c <Qunspecified>: Make extern again.
788
789 * syntax.c: Include sys/types.h before including regex.h, as
790 required by Posix.
791
762b15be
EZ
792 * doc.c (get_doc_string): Improve the format passed to `error'.
793
794 * doprnt.c (doprnt): Improve commentary.
795
796 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
797
798 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
799 them with etags.
800
f1052e5d
EZ
801 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
802 changes in globals.h immediately force recompilation.
762b15be
EZ
803 (TAGS): Depend on $(CURDIR)/m/intel386.h and
804 $(CURDIR)/s/ms-w32.h.
805 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 806
fa6996bc
EZ
807 * character.c (Fchar_direction): Function deleted.
808 (syms_of_character): Don't defsubr it.
809 <char-direction-table>: Deleted.
810
e6c3da20
EZ
8112011-04-23 Eli Zaretskii <eliz@gnu.org>
812
813 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
814 * doprnt.c: Include limits.h.
815 (SIZE_MAX): New macro.
816 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
817 local variables are now size_t instead of int or unsigned.
818 Improve overflow protection. Support `l' modifier for integer
819 conversions. Support %l conversion. Don't assume an EMACS_INT
820 argument for integer conversions and for %c.
821
822 * lisp.h (doprnt): Restore prototype.
823
824 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
825 $(SRC)/character.h.
826
827 * Makefile.in (base_obj): Add back doprnt.o.
828
829 * deps.mk (doprnt.o): Add back prerequisites.
830 (callint.o): Depend on character.h.
831
832 * eval.c (internal_lisp_condition_case): Include the handler
833 representation in the error message.
834 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
835 when breaking from the loop.
836
837 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
838
839 * callint.c (Fcall_interactively): When displaying error message
840 about invalid control letter, pass the character's codepoint, not
841 a pointer to its multibyte form. Improve display of the character
842 in octal and display also its hex code.
843
844 * character.c (char_string): Use %x to display the (unsigned)
845 codepoint of an invalid character, to avoid displaying a bogus
846 negative value.
847
848 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
849 `error', not SYMBOL_NAME itself.
850
851 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
852 character arguments to `error'.
853
854 * charset.c (check_iso_charset_parameter): Fix incorrect argument
855 to `error' in error message about FINAL_CHAR argument. Make sure
856 FINAL_CHAR is a character, and use %c when it is passed as
857 argument to `error'.
858
4ffd0d6b 8592011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
860
861 * s/ms-w32.h (localtime): Redirect to sys_localtime.
862
863 * w32.c: Include <time.h>.
864 (sys_localtime): New function.
865
4ffd0d6b 8662011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
867
868 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
869
4ffd0d6b 870 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 871
4ffd0d6b 8722011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 873
4ffd0d6b
GM
874 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
875 zombies (Bug#8467).
aac0c6e3 876
04c56954
EZ
8772011-04-19 Eli Zaretskii <eliz@gnu.org>
878
879 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
880 gl_state.e_property when gl_state.object is Qt.
881
882 * insdel.c (make_gap_larger): Remove limitation of buffer size
883 to <= INT_MAX.
884
16a43933
CY
8852011-04-18 Chong Yidong <cyd@stupidchicken.com>
886
887 * xdisp.c (lookup_glyphless_char_display)
888 (produce_glyphless_glyph): Handle cons cell entry in
889 glyphless-char-display.
890 (Vglyphless_char_display): Document it.
891
892 * term.c (produce_glyphless_glyph): Handle cons cell entry in
893 glyphless-char-display.
894
4581706e
CY
8952011-04-17 Chong Yidong <cyd@stupidchicken.com>
896
897 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
898
899 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
900
901 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
902 definition for no-X builds.
903
4887c6e2 9042011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 905
fd35b6f9
PE
906 Static checks with GCC 4.6.0 and non-default toolkits.
907
5c1ccb01
PE
908 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
909
006c5daa
PE
910 * process.c (keyboard_bit_set): Define only if SIGIO.
911 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
912 (send_process): Repair possible setjmp clobbering.
913
efc736d3
PE
914 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
915
4e2fe2e6
PE
916 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
917
f97334a2
PE
918 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
919
4e75f29d
PE
920 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
921 Define only if needed.
922
90efadd1
PE
923 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
924 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 925 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 926
3c647824
PE
927 * dispextern.h (struct redisplay_interface): Rename param
928 to avoid shadowing.
e264f262 929 * termhooks.h (struct terminal): Likewise.
761383f4 930 * xterm.c (xembed_send_message): Likewise.
3c647824 931
b58c5c4a
PE
932 * insdel.c (make_gap_smaller): Define only if
933 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
934
cad59032
PE
935 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
936 it.
937
c339dc2e
PE
938 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
939 so that we aren't warned about unused symbols.
940
91a3e27b
PE
941 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
942
399c71d3 943 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 944
8ffc96f5
PE
945 * xfns.c (x_real_positions): Mark locals as initialized.
946
eef9bc79
PE
947 * xmenu.c (xmenu_show): Don't use uninitialized vars.
948
098db9dd
PE
949 * xterm.c: Fix problems found by static analysis with other toolkits.
950 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
951 (x_dispatch_event): Declare static if USE_GTK, and
952 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 953 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 954 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
955 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
956 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 957
eb18f6cc
PE
958 * xmenu.c (menu_help_callback): Pointer type fixes.
959 Use const pointers when pointing at readonly data. Avoid pointer
960 signedness clashes.
961 (FALSE): Remove unused macro.
962 (update_frame_menubar): Remove unused decl.
963
1fe72bf8
PE
964 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
965
60d9e1db
PE
966 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
967 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
968 (single_menu_item): Rename local to avoid shadowing.
969
39261c26
PE
970 * keyboard.c (make_lispy_event): Remove unused local var.
971
018c5e19
PE
972 * frame.c, frame.h (x_get_resource_string): Bring this back, but
973 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
974
63d2b86e
PE
975 * bitmaps: Change bitmaps from unsigned char back to the X11
976 compatible char. Avoid the old compiler warnings about
977 out-of-range initializers by using, for example, '\xab' rather
978 than 0xab.
979
aefd87e1
PE
980 * xgselect.c (xgselect_initialize): Check vs interface
981 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
982
bf501fb9
PE
983 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
984
e9829fdf
PE
985 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
986 to read-only memory.
987
1086c095
PE
988 * fns.c (vector): Remove; this old hack is no longer needed.
989
2baccd04 990 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 991 Remove unused var.
dde42981 992 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 993
72391843 994 * xrdb.c (x_load_resources): Omit unused local.
3565b346 995
436c16df 996 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 997 (x_window): Rename locals to avoid shadowing.
dc5ddd85 998 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 999
92bb796d 1000 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1001 (x_term_init): Remove local to avoid shadowing.
92bb796d 1002
764430a3 1003 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1004
1005 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1006 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1007
d1dfb56c
EZ
10082011-04-16 Eli Zaretskii <eliz@gnu.org>
1009
c4354cb4
EZ
1010 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1011
d1dfb56c
EZ
1012 Fix regex.c, syntax.c and friends for buffers > 2GB.
1013 * syntax.h (struct gl_state_s): Declare character position members
1014 EMACS_INT.
1015
1016 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1017
1018 * textprop.c (verify_interval_modification, interval_of): Declare
1019 arguments EMACS_INT.
1020
1021 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1022 EMACS_INT.
1023
1024 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1025
1026 * indent.c (Fvertical_motion): Local variable it_start is now
1027 EMACS_INT.
1028
1029 * regex.c (re_match, re_match_2, re_match_2_internal)
1030 (bcmp_translate, regcomp, regexec, print_double_string)
1031 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1032 (re_compile_pattern, re_exec): Declare arguments and local
1033 variables `size_t' and `ssize_t' and return values `regoff_t', as
1034 appropriate.
1035 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1036 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1037 <compile_stack_type>: `size' and `avail' are now `size_t'.
1038
1039 * regex.h <regoff_t>: Use ssize_t, not int.
1040 (re_search, re_search_2, re_match, re_match_2): Arguments that
1041 specify buffer/string position and length are now ssize_t and
1042 size_t. Return type is regoff_t.
1043
613052cd
BK
10442011-04-16 Ben Key <bkey76@gmail.com>
1045
1046 * nsfont.m: Fixed bugs in ns_get_family and
1047 ns_descriptor_to_entity that were caused by using free to
1048 deallocate memory blocks that were allocated by xmalloc (via
1049 xstrdup). This caused Emacs to crash when compiled with
1050 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1051 --enable-checking=xmallocoverrun). xfree is now used to
1052 deallocate these memory blocks.
1053
4170f62f 10542011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1055
71b41406
PE
1056 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1057
9587a89d
PE
1058 emacs_write: Accept and return EMACS_INT for sizes.
1059 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1060 et seq.
1061 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1062 Accept and return EMACS_INT.
1063 (emacs_gnutls_write): Return the number of bytes written on
1064 partial writes.
1065 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1066 (emacs_read, emacs_write): Remove check for negative size, as the
1067 Emacs source code has been audited now.
9587a89d
PE
1068 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1069 (emacs_read, emacs_write): Use it.
273a5f82
PE
1070 * process.c (send_process): Adjust to the new signatures of
1071 emacs_write and emacs_gnutls_write. Do not attempt to store
1072 a byte offset into an 'int'; it might overflow.
9587a89d 1073 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1074
3e047f51
PE
1075 * sound.c: Don't assume sizes fit in 'int'.
1076 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1077 Return EMACS_INT, not int.
3e047f51 1078 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1079 Accept EMACS_INT, not int.
1080 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1081 record read return values.
1082
cc39a9db
BK
10832011-04-15 Ben Key <bkey76@gmail.com>
1084
c9d0ec6d
JB
1085 * keyboard.c (Qundefined): Don't declare static since it is used
1086 in nsfns.m.
1087 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1088 static since they are used in nsfont.m.
cc39a9db 1089
6c60eb9f
SM
10902011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1091
1092 * process.c (Qprocessp): Don't declare static.
1093 * lisp.h (Qprocessp): Declare again.
1094
7990b61a
JB
10952011-04-15 Juanma Barranquero <lekktu@gmail.com>
1096
1097 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1098
5d4cb038
PE
10992011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1100
8bd7b830 1101 Improve C-level modularity by making more things 'static'.
cd64ea1d 1102
e3b27b31
PE
1103 Don't publish debugger-only interfaces to other modules.
1104 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1105 (verify_bytepos, count_markers): Move decls to the only modules
1106 that need them.
1107 * region-cache.h (pp_cache): Likewise.
1108 * window.h (check_all_windows): Likewise.
1109 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1110
5d4cb038
PE
1111 * sysdep.c (croak): Now static, if
1112 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1113 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1114
1115 * alloc.c (refill_memory_reserve): Now static if
1116 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1117 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1118
e87b6180
PE
1119 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1120 Define only if USE_LUCID.
1121
ac64929e
PE
1122 * xrdb.c (x_customization_string, x_rm_string): Now static.
1123
6f37259d
PE
1124 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1125 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1126
1683e3ab
PE
1127 * xdisp.c (draw_row_with_mouse_face): Now static.
1128 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1129
de9c2632
PE
1130 * window.h (check_all_windows): Mark externally visible.
1131
2b96acb7
PE
1132 * window.c (window_deletion_count): Now static.
1133
1134 * undo.c: Make symbols static if they're not exported.
1135 (last_undo_buffer, last_boundary_position, pending_boundary):
1136 Now static.
1137
50436f33
PE
1138 * textprop.c (interval_insert_behind_hooks): Now static.
1139 (interval_insert_in_front_hooks): Likewise.
1140
64520e5c
PE
1141 * term.c: Make symbols static if they're not exported.
1142 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1143 (max_frame_lines, tty_set_terminal_modes):
1144 (tty_reset_terminal_modes, tty_turn_off_highlight):
1145 (get_tty_terminal): Now static.
1146 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1147 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1148 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1149 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1150 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1151
1fa53021
PE
1152 * sysdep.c: Make symbols static if they're not exported.
1153 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1154 Now static.
1155 (sigprocmask_set, full_mask): Remove; unused.
1156 (wait_debugging): Mark as visible.
1157 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1158 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1159
d4b43b22
PE
1160 * syntax.c (syntax_temp): Define only if !__GNUC__.
1161
b7c513d0
PE
1162 * sound.c (current_sound_device, current_sound): Now static.
1163
989b29ad
PE
1164 * search.c (searchbufs, searchbuf_head): Now static.
1165
13a55a78
PE
1166 * scroll.c (scroll_cost): Remove; unused.
1167 * dispextern.h (scroll_cost): Remove decl.
1168
de68a1fc
PE
1169 * region-cache.h (pp_cache): Mark as externally visible.
1170
40ccffa6
PE
1171 * process.c: Make symbols static if they're not exported.
1172 (process_tick, update_tick, create_process, chan_process):
1173 (Vprocess_alist, proc_buffered_char, datagram_access):
1174 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1175 (deactivate_process): Mark defn as static, as well as decl.
1176 * lisp.h (create_process): Remove decl.
1177 * process.h (chan_process, Vprocess_alist): Remove decls.
1178
ad64fc97
PE
1179 * print.c: Make symbols static if they're not exported.
1180 (print_depth, new_backquote_output, being_printed, print_buffer):
1181 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1182 (print_interval, print_number_index, initial_stderr_stream):
1183 Now static.
1184 * lisp.h (Fprinc): Remove decl.
1185 (debug_output_compilation_hack): Mark as externally visible.
1186
adddb265
PE
1187 * sysdep.c (croak): Move decl from here to syssignal.h.
1188 * syssignal.h (croak): Put it here, so the API can be checked when
1189 'croak' is called from dissociate_if_controlling_tty.
1190
1717ede2
PE
1191 * minibuf.c: Make symbols static if they're not exported.
1192 (minibuf_save_list, choose_minibuf_frame): Now static.
1193 * lisp.h (choose_minibuf_frame): Remove decl.
1194
fa5fb2bc
PE
1195 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1196
1e3890d1
PE
1197 * lread.c: Make symbols static if they're not exported.
1198 (read_objects, initial_obarray, oblookup_last_bucket_number):
1199 Now static.
1200 (make_symbol): Remove; unused.
1201 * lisp.h (initial_obarray, make_symbol): Remove decls.
1202
8a1414fa
PE
1203 * keyboard.c: Make symbols static if they're not exported.
1204 (single_kboard, recent_keys_index, total_keys, recent_keys):
1205 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1206 (this_single_command_key_start, echoing, last_auto_save):
1207 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1208 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1209 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1210 (Vlispy_mouse_stem, double_click_count):
1211 Now static.
1212 (force_auto_save_soon): Define only if SIGDANGER.
1213 (ignore_mouse_drag_p): Now static if
1214 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1215 (print_help): Remove; unused.
1216 (stop_character, last_timer_event): Mark as externally visible.
1217 * keyboard.h (ignore_mouse_drag_p): Declare only if
1218 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1219 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1220 * lisp.h (echoing): Remove decl.
1221 (force_auto_save_soon): Declare only if SIGDANGER.
1222 * xdisp.c (redisplay_window): Simplify code, to make it more
1223 obvious that ignore_mouse_drag_p is not accessed if !defined
1224 USE_GTK && !defined HAVE_NS.
1225
93ea6e8f
PE
1226 * intervals.c: Make symbols static if they're not exported.
1227 (merge_properties_sticky, merge_interval_right, delete_interval):
1228 Now static.
1229 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1230
77382fcc
PE
1231 * insdel.c: Make symbols static if they're not exported.
1232 However, leave prepare_to_modify_buffer alone. It's never
1233 called from outside this function, but that appears to be a bug.
1234 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1235 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1236 (adjust_after_replace_noundo): Remove; unused.
1237 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1238 (signal_before_change): Remove decls.
77382fcc 1239
9306c32e
PE
1240 * indent.c (val_compute_motion, val_vmotion): Now static.
1241
cd44d2eb
PE
1242 * image.c: Make symbols static if they're not exported.
1243 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1244 if USE_GTK.
1245 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1246 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1247
ad9a7a06
PE
1248 * fringe.c (standard_bitmaps): Now static.
1249 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1250
81626931
PE
1251 * frame.c: Make symbols static if they're not exported.
1252 (x_report_frame_params, make_terminal_frame): Now static.
1253 (get_frame_param): Now static, unless HAVE_NS.
1254 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1255 (x_get_resource_string): Remove; not used.
1256 * frame.h (make_terminal_frame, x_report_frame_params):
1257 (x_get_resource_string); Remove decls.
1258 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1259 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1260
239f9db9
PE
1261 * font.c, fontset.c: Make symbols static if they're not exported.
1262 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1263 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1264 * font.c (font_close_object): Now static.
1265 * font.h (font_close_object): Remove.
1266 * fontset.c (FONTSET_OBJLIST): Remove.
1267 (free_realized_fontset) #if-0 the body, which does nothing.
1268 (face_suitable_for_char_p): #if-0, as it's never called.
1269 * fontset.h (face_suitable_for_char_p): Remove decl.
1270 * xfaces.c (face_at_string_position): Use
1271 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1272 since 0 is always ASCII.
1273
dfcf3579
PE
1274 * fns.c (weak_hash_tables): Now static.
1275
5045092b
PE
1276 * fileio.c: Make symbols static if they're not exported.
1277 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1278 (Vwrite_region_annotation_buffers): Now static.
1279
57a96f5c
PE
1280 * eval.c: Make symbols static if they're not exported.
1281 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1282 * lisp.h (backtrace_list): Remove decl.
1283
35f08c38
PE
1284 * emacs.c: Make symbols static if they're not exported.
1285 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1286 (fatal_error_code, fatal_error_signal_hook, standard_args):
1287 Now static.
1288 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1289 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1290 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1291 * lisp.h (fatal_error_signal_hook): Remove decl.
1292 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1293
f44bd759
PE
1294 * editfns.c: Move a (normally-unused) function to its only use.
1295 * editfns.c, lisp.h (get_operating_system_release): Remove.
1296 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1297 worth the hassle of breaking this out.
1298
b532497d
PE
1299 * xterm.c: Make symbols static if they're not exported.
1300 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1301 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1302 (x_destroy_window, x_delete_display):
1303 Now static.
1304 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1305 (x_mouse_leave): Remove; unused.
1306 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1307 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1308 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1309 Remove decls.
1310 (x_mouse_leave): Declare only if WINDOWSNT.
1311 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1312 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1313 USE_X_TOOLKIT.
1314
1675728f
PE
1315 * ftxfont.c: Make symbols static if they're not exported.
1316 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1317 HAVE_FREETYPE.
1318 * font.h (ftxfont_driver): Likewise.
1319
e4cebfca
PE
1320 * xfns.c: Make symbols static if they're not exported.
1321 (x_last_font_name, x_display_info_for_name):
1322 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1323 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1324 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1325 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1326 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1327 (last_show_tip_args): Now static.
1328 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1329 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1330 (x_screen_planes): Remove; unused.
1331 * dispextern.h (x_screen_planes): Remove decl.
1332
5bf46f05
PE
1333 * dispnew.c: Make symbols static if they're not exported.
1334 * dispextern.h (redraw_garbaged_frames, scrolling):
1335 (increment_row_positions): Remove.
1336 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1337 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1338 Now static.
1339 (redraw_garbaged_frames): Remove; unused.
1340
435f4c28
PE
1341 * xfaces.c: Make symbols static if they're not exported.
1342 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1343 Remove decls.
1344 * xterm.h (defined_color): Remove decls.
1345 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1346 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1347 (menu_face_changed_default, defined_color, free_realized_face):
1348 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1349 (ascii_face_of_lisp_face): Remove; unused.
1350
8524aef3
PE
1351 * xdisp.c: Make symbols static if they're not exported.
1352 * dispextern.h (scratch_glyph_row, window_box_edges):
1353 (glyph_to_pixel_coords, set_cursor_from_row):
1354 (get_next_display_element, set_iterator_to_next):
1355 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1356 (show_mouse_face): Remove decls
1357 * frame.h (message_buf_print): Likewise.
1358 * lisp.h (pop_message, set_message, check_point_in_composition):
1359 Likewise.
1360 * xterm.h (set_vertical_scroll_bar): Likewise.
1361 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1362 (message_buf_print, scratch_glyph_row, displayed_buffer):
1363 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1364 (get_next_display_element, show_mouse_face, window_box_edges):
1365 (frame_to_window_pixel_xy, check_point_in_composition):
1366 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1367 (glyph_to_pixel_coords): Remove; unused.
1368
16390cd2
PE
1369 * dired.c (file_name_completion): Now static.
1370
1371 * dbusbind.c (xd_in_read_queued_messages): Now static.
1372
a25f4dfa
PE
1373 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1374 * data.c (circular_list_error): Remove.
1375
14a9c8df
PE
1376 * commands.h (last_point_position, last_point_position_buffer):
1377 (last_point_position_window): Remove decls.
1378 * keyboard.c: Make these variables static.
1379
74ab6df5
PE
1380 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1381 decls.
1382 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1383 (iso_code_class, detect_coding, code_convert_region): Now static.
1384 (encode_coding_gap): Remove; unused.
1385
38dfbee1
PE
1386 * chartab.c (chartab_chars, chartab_bits): Now static.
1387
a2cb4e63
PE
1388 * charset.h (charset_iso_8859_1): Remove decl.
1389 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1390 Now static.
1391
127198fd
PE
1392 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1393 * ccl.c (Vccl_program_table): Now static.
1394 (check_ccl_update): Remove; unused.
1395
d85b608f
PE
1396 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1397 * category.h: ... from here.
1398 * category.c (check_category_table, set_category_set): Now static.
1399
31cd66f3
PE
1400 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1401 * lisp.h: Remove these decls.
1402
c358e587
PE
1403 * buffer.c (buffer_count): Remove unused var.
1404
e78aecca
PE
1405 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1406 so that it's not optimized away.
1407 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1408 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1409 exported only to the debugger.
1410
e192d7d3
PE
1411 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1412 * atimer.h (run_all_atimers): Removed; not exported.
1413
92470028
PE
1414 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1415 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1416 was inaccessible from Lisp.
1417 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1418 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1419
244ed907
PE
1420 alloc.c: Import and export fewer symbols, and remove unused items.
1421 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1422 is defined.
1423 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1424 it's not optimized away by whole-program optimization.
1425 (message_enable_multibyte, free_misc): Remove.
1426 (catchlist, handlerlist, mark_backtrace):
1427 Declare only if BYTE_MARK_STACK.
1428 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1429 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1430 (message_enable_multibyte): Remove decl.
1431 (free_misc, interval_free_list, float_block, float_block_index):
1432 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1433 (cons_free_list, last_marked_index):
1434 Now static.
1435 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1436 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1437 (mark_backtrace): Define only if BYTE_MARK_STACK.
1438 * xdisp.c (message_enable_multibyte): Now static.
1439
61c2b50e 1440 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1441 This makes it easier for human readers (and static analyzers)
1442 to see whether these variables are used from other modules.
1443 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1444 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1445 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1446 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1447 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1448 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1449 * xmenu.c, xselect.c:
1450 Declare Q* vars static if they are not used in other modules.
1451 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1452 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1453 Remove decls of unexported vars.
1454 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1455
95c82688
PE
1456 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1457
16a97296
PE
1458 Make Emacs functions such as Fatom 'static' by default.
1459 This makes it easier for human readers (and static analyzers)
1460 to see whether these functions can be called from other modules.
1461 DEFUN now defines a static function. To make the function external
1462 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1463 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1464 (Finit_image_library):
16a97296
PE
1465 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1466 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1467 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1468 Remove decls, since these functions are now static.
1469 (Funintern, Fget_internal_run_time): New decls, since these functions
1470 were already external.
95c82688 1471
16a97296
PE
1472 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1473 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1474 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1475 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1476 * keyboard.c, keymap.c, lread.c:
1477 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1478 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1479 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1480 Mark functions with DEFUE instead of DEFUN,
1481 if they are used in other modules.
1482 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1483 decls for now-static functions.
1484 * buffer.h (Fdelete_overlay): Remove decl.
1485 * callproc.c (Fgetenv_internal): Mark as internal.
1486 * composite.c (Fremove_list_of_text_properties): Remove decl.
1487 (Fcomposition_get_gstring): New forward static decl.
1488 * composite.h (Fcomposite_get_gstring): Remove decl.
1489 * dired.c (Ffile_attributes): New forward static decl.
1490 * doc.c (Fdocumntation_property): New forward static decl.
1491 * eval.c (Ffetch_bytecode): New forward static decl.
1492 (Funintern): Remove extern decl; now in .h file where it belongs.
1493 * fileio.c (Fmake_symbolic_link): New forward static decl.
1494 * image.c (Finit_image_library): New forward static decl.
1495 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1496 * intervals.h (Fprevious_property_change):
1497 (Fremove_list_of_text_properties): Remove decls.
1498 * keyboard.c (Fthis_command_keys): Remove decl.
1499 (Fcommand_execute): New forward static decl.
1500 * keymap.c (Flookup_key): New forward static decl.
1501 (Fcopy_keymap): Now static.
1502 * keymap.h (Flookup_key): Remove decl.
1503 * process.c (Fget_process): New forward static decl.
1504 (Fprocess_datagram_address): Mark as internal.
1505 * syntax.c (Fsyntax_table_p): New forward static decl.
1506 (skip_chars): Remove duplicate decl.
1507 * textprop.c (Fprevious_property_change): New forward static decl.
1508 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1509 Now internal.
1510 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1511 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1512
785bbd42
PE
1513 * editfns.c (Fformat): Remove unreachable code.
1514
8b913b57
AS
15152011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1516
1517 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1518 change. (Bug#8496)
1519
a6744a35
EZ
15202011-04-13 Eli Zaretskii <eliz@gnu.org>
1521
1522 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1523 when at ZV. (Bug#8487)
1524
e7974947
AS
15252011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1526
baad03f0
AS
1527 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1528 (Bug#8437)
1529 * keyboard.c (parse_tool_bar_item): Likewise.
1530 * sound.c (sound_cleanup, alsa_close): Likewise.
1531 * termcap.c (tgetent): Likewise.
1532 * xfns.c (x_default_font_parameter): Likewise.
1533 * xsettings.c (read_and_apply_settings): Likewise.
1534
e7974947
AS
1535 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1536 (overrun_check_free): Protoize.
1537
28272684
PE
15382011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1539
1540 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1541 since callers should never pass a negative size.
1542 Change the signature to match that of plain 'read' and 'write'; see
1543 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1544 * lisp.h: Update prototypes of emacs_write and emacs_read.
1545
11997c76
EZ
15462011-04-11 Eli Zaretskii <eliz@gnu.org>
1547
1548 * xdisp.c (redisplay_window): Don't try to determine the character
1549 position of the scroll margin if the window start point w->startp
e896f03c 1550 is outside the buffer's accessible region. (Bug#8468)
11997c76 1551
8a2cbd72
EZ
15522011-04-10 Eli Zaretskii <eliz@gnu.org>
1553
1554 Fix write-region and its subroutines for buffers > 2GB.
1555 * fileio.c (a_write, e_write): Modify declaration of arguments and
1556 local variables to support buffers larger than 2GB.
1557 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1558
1559 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1560 argument, local variables, and return value.
1561
1562 * lisp.h: Update prototypes of emacs_write and emacs_read.
1563
1564 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1565
4073e537 15662011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1567
1ebfdcb6
PE
1568 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1569
b2ded58d
PE
1570 Fix more problems found by GCC 4.6.0's static checks.
1571
7d66342c
PE
1572 * xdisp.c (vmessage): Use a better test for character truncation.
1573
bbf47d44
PE
1574 * charset.c (load_charset_map): <, not <=, for optimization,
1575 and to avoid potential problems with integer overflow.
9248994d 1576 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1577 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1578 * editfns.c (Fformat): Likewise.
1e69125e 1579 * syntax.c (skip_chars): Likewise.
3befa583 1580
e3019616
PE
1581 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1582 This also lets GCC 4.6.0 generate slightly better loop code.
1583
becfa255
PE
1584 * callint.c (Fcall_interactively): <, not <=, for optimization.
1585 (Fcall_interactively): Count the number of arguments produced,
1586 not the number of arguments given. This is simpler and lets GCC
1587 4.6.0 generate slightly better code.
1588
dae0cd48
PE
1589 * ftfont.c: Distingish more carefully between FcChar8 and char.
1590 The previous code passed unsigned char * to a functions like
1591 strlen and xstrcasecmp that expect char *, which does not
1592 conform to the C standard.
1593 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1594 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1595 char * when the C standard requires it.
1596
76032d70
PE
1597 * keyboard.c (read_char): Remove unused var.
1598
eb3f1cc8
PE
1599 * eval.c: Port to Windows vsnprintf (Bug#8435).
1600 Include <limits.h>.
1601 (SIZE_MAX): Define if the headers do not.
1602 (verror): Do not give up if vsnprintf returns a negative count.
1603 Instead, grow the buffer. This ports to Windows vsnprintf, which
1604 does not conform to C99. Problem reported by Eli Zaretskii.
1605 Also, simplify the allocation scheme, by avoiding the need for
1606 calling realloc, and removing the ALLOCATED variable.
1607
70476b54
PE
1608 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1609
12020a9e
PE
1610 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1611 But keep the doprint source code for now, as we might revamp it
1612 and use it again (Bug#8435).
ea6c7ae6
PE
1613 * lisp.h (doprnt): Remove.
1614 * Makefile.in (base_obj): Remove doprnt.o.
1615 * deps.mk (doprnt.o): Remove.
1616
5fdb398c
PE
1617 error: Print 32- and 64-bit integers portably (Bug#8435).
1618 Without this change, on typical 64-bit hosts error ("...%d...", N)
1619 was used to print both 32- and 64-bit integers N, which relied on
1620 undefined behavior.
1621 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1622 New macro.
1623 * lisp.h (error, verror): Mark as printf-like functions.
1624 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1625 Report overflow in size calculations when allocating printf buffer.
1626 Do not truncate output string at its first null byte.
1627 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1628 Truncate the output at a character boundary, since vsnprintf does not
1629 do that.
1630 * charset.c (check_iso_charset_parameter): Convert internal
1631 character to string before calling 'error', since %c now has the
1632 printf meaning.
1633 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1634 overflow when computing char to be passed to 'error'. Do not
1635 pass Lisp_Object to 'error'; pass the integer instead.
1636 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1637 formatted with plain %d.
1638
b189fa66
PE
1639 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1640
bff87ef0
PE
1641 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1642
7e2cac20
PE
1643 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1644
ce4d90b5
PE
1645 * xterm.c (x_catch_errors): Remove duplicate declaration.
1646
266c9547
PE
1647 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1648
79c49ad2
PE
1649 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1650
368f4090
JM
16512011-04-10 Jim Meyering <meyering@redhat.com>
1652
1653 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1654 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1655 return ssize_t not "int", and use size_t as the buffer length.
1656 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1657 * gnutls.h: Update declarations.
1658 * process.c (read_process_output): Use ssize_t, to match.
1659 (send_process): Likewise.
1660
a32d4040
CY
16612011-04-09 Chong Yidong <cyd@stupidchicken.com>
1662
1663 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1664
8546720e 16652011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1666
8546720e
GM
1667 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1668 unsigned char, to match FcChar8 type definition.
aac0c6e3 1669
8546720e
GM
1670 * xterm.c (handle_one_xevent):
1671 * xmenu.c (create_and_show_popup_menu):
1672 * xselect.c (x_decline_selection_request)
1673 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1674
0a2f5c1a 16752011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1676
1677 Fix some uses of `int' instead of EMACS_INT.
1678 * search.c (string_match_1, fast_string_match)
1679 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1680 (scan_buffer, find_next_newline_no_quit)
1681 (find_before_next_newline, search_command, Freplace_match)
1682 (Fmatch_data): Make some `int' variables be EMACS_INT.
1683
1684 * xdisp.c (display_count_lines): 3rd argument and return value now
1685 EMACS_INT. All callers changed.
1686 (pint2hrstr): Last argument is now EMACS_INT.
1687
1688 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1689 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1690 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1691 (decode_coding_utf_16, decode_coding_emacs_mule)
1692 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1693 (decode_coding_ccl, decode_coding_charset)
1694 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1695 (decode_coding_iso_2022, decode_coding_emacs_mule)
1696 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1697 <char_offset, last_offset>: Declare EMACS_INT.
1698 (encode_coding_utf_8, encode_coding_utf_16)
1699 (encode_coding_emacs_mule, encode_invocation_designation)
1700 (encode_designation_at_bol, encode_coding_iso_2022)
1701 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1702 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1703 Declare EMACS_INT.
1704 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1705 (encode_invocation_designation): Last argument P_NCHARS is now
1706 EMACS_INT.
1707 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1708 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1709
1710 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1711 All users changed.
1712
1713 * ccl.c (Fccl_execute_on_string): Declare some variables
1714 EMACS_INT.
1715
8546720e 17162011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1717
1718 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1719
4e19a977
CS
17202011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1721
1722 * process.c (Fformat_network_address): Doc fix.
1723
87302331
R
17242011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1725
1726 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1727
cbb59342
CY
17282011-04-08 Chong Yidong <cyd@stupidchicken.com>
1729
1730 * keyboard.c (read_char): Call Lisp function help-form-show,
1731 instead of using internal_with_output_to_temp_buffer.
1732 (Qhelp_form_show): New var.
e0d38eeb 1733 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1734
1735 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1736
1737 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1738
e67a13ab
CY
17392011-04-06 Chong Yidong <cyd@stupidchicken.com>
1740
1741 * process.c (Flist_processes): Removed to Lisp.
1742 (list_processes_1): Deleted.
1743
973f782d
EZ
17442011-04-06 Eli Zaretskii <eliz@gnu.org>
1745
7c106b1e
EZ
1746 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1747
973f782d
EZ
1748 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1749
41cf7d1a 17502011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1751
ca23cc88
PE
1752 Fix more problems found by GCC 4.6.0's static checks.
1753
f390e2d5
PE
1754 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1755
42eea0d0
PE
1756 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1757
b69769da 1758 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1759
f9541e84
PE
1760 * xdisp.c (vmessage): Mark as a printf-like function.
1761
13841b55
PE
1762 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1763
c136c10f
PE
1764 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1765
5e2d4a30
PE
1766 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1767 printf-like functions.
1768 (tiff_load): Add casts to remove these marks before passing them
1769 to system-supplied API.
1770
583f48b9
PE
1771 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1772
b25d760e
PE
1773 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1774 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1775 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1776 directly, rather than having caller test rule sign. This avoids
1777 some unnecessary tests.
1778 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1779 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1780 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1781
bc7b6697 1782 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1783 (xfont_open): Avoid unnecessary tests.
bc7b6697 1784
27ccc379
PE
1785 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1786
dcd5c89a
PE
1787 * composite.h, composite.c (composition_gstring_put_cache):
1788 Use EMACS_INT, not int, for length.
1789
b13a45c6
PE
1790 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1791 breaking out part of COMPOSITION_DECODE_RULE.
1792 (COMPOSITION_DECODE_RULE): Use it.
1793 * composite.c (get_composition_id): Remove unused local vars,
1794 by using the new macro.
1795
1e792e4d
PE
1796 * textprop.c (set_text_properties_1): Change while to do-while,
1797 since the condition is always true at first.
1798
dc6c6455 1799 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1800 (interval_deletion_adjustment): Return unsigned value.
1801 All uses changed.
dc6c6455 1802
aba7731a
PE
1803 * process.c (list_processes_1, create_pty, read_process_output):
1804 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1805 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1806 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1807 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1808 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1809
fdfc4bf3
PE
1810 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1811
fca8fe46 1812 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1813 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1814
06a0259a 1815 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1816 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1817 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1818
e7b9e80f
PE
1819 * print.c (print_error_message): Avoid int overflow.
1820
56201685
PE
1821 * font.c (font_list_entities): Redo for clarity,
1822 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1823
78834453 1824 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1825 (font_score): Avoid potential overflow in diff calculation.
78834453 1826
0bc0b309 1827 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1828 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1829
e610eaca
PE
1830 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1831
b895abce
PE
1832 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1833 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1834 can always succeed if overflow has undefined behavior.
1835
1f1d9321 1836 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1837 (wordify): Omit three unnecessary tests.
1f1d9321 1838
c59478bc
PE
1839 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1840 All callers changed. This avoids the need for an unused var.
1841
79b73827
PE
1842 * casefiddle.c (casify_region): Remove var that is set but not used.
1843
a4db5dfe
PE
1844 * dired.c (file_name_completion): Remove var that is set but not used.
1845
43aae36e
PE
1846 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1847
2a47c44d 1848 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1849 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1850
a37c69bf
PE
1851 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1852 Check for integer overflow on size calculations.
1853
328ab8e7
PE
1854 * buffer.c (Fprevious_overlay_change): Remove var that is set
1855 but not used.
1856
e5a2a5cb
PE
1857 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1858 Remove vars that are set but not used.
8d84a6eb 1859 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1860 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1861
a60e5f68
PE
1862 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1863
f661cb61 1864 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1865 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1866
f0397f5a
PE
1867 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1868 that are set but not used.
1869
8664db06 1870 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1871 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1872
6abdaa4a
PE
1873 * xselect.c (x_get_local_selection, x_handle_property_notify):
1874 Remove vars that are set but not used.
1875
0ce7538d 1876 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1877 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1878
9ae848fc
PE
1879 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1880 Remove var that is set but not used.
0b918413
PE
1881 (scroll_bar_windows_size): Now size_t, not int.
1882 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1883 Check for overflow.
9ae848fc 1884
a5a62657
PE
1885 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1886 (map_tty_color) [!defined MSDOS]: Likewise.
1887
5c5cdd39
PE
1888 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1889
66ebf983
PE
1890 * coding.c: Remove vars that are set but not used.
1891 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1892 All callers changed.
1893 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1894 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1895 (decode_coding_charset): Remove vars that are set but not used.
1896
1be4d761
PE
1897 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1898 that is set but not used.
1899
47553fa8
PE
1900 * print.c (print_object): Remove var that is set but not used.
1901
1f7196bf 1902 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1903 The gnulib version avoids calling malloc in the usual case,
1904 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1905 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1906 * filelock.c (current_lock_owner): Likewise.
1907 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1908 * sysdep.c: Include allocator.h, careadlinkat.h.
1909 (emacs_no_realloc_allocator): New static constant.
1910 (emacs_readlink): New function.
fdb61804
PE
1911 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1912 ../lib/careadlinkat.h.
d1fdcab7 1913
f84c17c7
SM
19142011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1915
1916 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1917 first non-nil return value).
1918
ef3862ad
JD
19192011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1920
1921 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1922 if not defined (Bug#8403).
1923
376a7006
JB
19242011-04-02 Juanma Barranquero <lekktu@gmail.com>
1925
1926 * xdisp.c (display_count_lines): Remove parameter `start',
1927 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1928 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1929 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1930 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1931 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1932 and thereabouts. All callers changed.
1933 (get_per_char_metric): Remove parameter `f', unused since
1934 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1935
6ca3801d
JM
19362011-04-02 Jim Meyering <meyering@redhat.com>
1937
1938 do not dereference NULL upon failed strdup
1939 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1940 (ns_get_family): Likewise.
1941
d8e2b5ba
JB
19422011-04-02 Juanma Barranquero <lekktu@gmail.com>
1943
1944 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1945
8c74fcbd
JD
19462011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1947
1948 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1949 later (Bug#8403).
1950
7200d79c
SM
19512011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1952
03408648 1953 Add lexical binding.
7200d79c 1954
03408648
SM
1955 * window.c (Ftemp_output_buffer_show): New fun.
1956 (Fsave_window_excursion):
1957 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1958
1959 * lread.c (lisp_file_lexically_bound_p): New function.
1960 (Fload): Bind Qlexical_binding.
1961 (readevalloop): Remove `evalfun' arg.
1962 Bind Qinternal_interpreter_environment.
1963 (Feval_buffer): Bind Qlexical_binding.
1964 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1965 Mark as dynamic.
1966 (syms_of_lread): Declare `lexical-binding'.
1967
1968 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1969
1970 * keyboard.c (eval_dyn): New fun.
1971 (menu_item_eval_property): Use it.
ca105506
SM
1972
1973 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1974
03408648
SM
1975 * fns.c (concat, mapcar1): Accept byte-code-functions.
1976
1977 * eval.c (Fsetq): Handle lexical vars.
1978 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1979 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1980 (FletX, Flet): Obey lexical binding.
1981 (Fcommandp): Handle closures.
1982 (Feval): New `lexical' arg.
1983 (eval_sub): New function extracted from Feval. Use it almost
1984 everywhere where Feval was used. Look up vars in lexical env.
1985 Handle closures.
1986 (Ffunctionp): Move from subr.el.
1987 (Ffuncall): Handle closures.
1988 (apply_lambda): Remove `eval_flags'.
1989 (funcall_lambda): Handle closures and new byte-code-functions.
1990 (Fspecial_variable_p): New function.
1991 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1992 but without exporting it to Lisp.
23aba0ea 1993
23aba0ea 1994 * doc.c (Fdocumentation, store_function_docstring):
03408648 1995 * data.c (Finteractive_form): Handle closures.
23aba0ea 1996
03408648
SM
1997 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1998 interactive spec.
ba83908c 1999
03408648
SM
2000 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
2001 byte-codes.
2002 (exec_byte_code): New function extracted from Fbyte_code to handle new
2003 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2004
03408648 2005 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2006
03408648 2007 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2008
e2abce01
JB
20092011-03-31 Juanma Barranquero <lekktu@gmail.com>
2010
2011 * xdisp.c (redisplay_internal): Fix prototype.
2012
63696a73 20132011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2014
63696a73
EZ
2015 * xdisp.c (SCROLL_LIMIT): New macro.
2016 (try_scrolling): Use it when setting scroll_limit. Limit
2017 scrolling to 100 screen lines.
2018 (redisplay_window): Even when falling back on "recentering",
2019 position point in the window according to scroll-conservatively,
2020 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2021
2022 (try_scrolling): When point is above the window, allow searching
2023 as far as scroll_max, or one screenful, to compute vertical
2024 distance from PT to the scroll margin position. This prevents
2025 try_scrolling from unnecessarily failing when
2026 scroll-conservatively is set to a value slightly larger than the
2027 window height. Clean up the case of PT below the margin at bottom
2028 of window: scroll_max can no longer be INT_MAX. When aggressive
2029 scrolling is in use, don't let point enter the opposite scroll
2030 margin as result of the scroll.
2031 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2032 threshold of 100 lines for never-recentering scrolling.
2033
e4cc2dfc
JB
20342011-03-31 Juanma Barranquero <lekktu@gmail.com>
2035
2036 * dispextern.h (move_it_by_lines):
2037 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2038 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2039 (message_log_check_duplicate): Remove parameters `prev_bol' and
2040 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2041 (redisplay_internal): Remove parameter `preserve_echo_area',
2042 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2043
2044 * indent.c (Fvertical_motion):
2045 * window.c (window_scroll_pixel_based, Frecenter):
2046 Don't pass `need_y_p' to `move_it_by_lines'.
2047
1c470562
SM
20482011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2049
44f230aa
SM
2050 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2051 steal a few bits to be more compact.
2052 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2053 Remove unneeded casts.
2054
1c470562
SM
2055 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2056
888adce9
ZK
20572011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2058
2059 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2060 binding" message (bug#7967).
2061
f838ed7b
PE
20622011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2063
77861b95
PE
2064 Fix more problems found by GCC 4.6.0's static checks.
2065
de6dbc14
PE
2066 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2067 Remove unused local var.
2068
f838ed7b
PE
2069 * editfns.c (Fmessage_box): Remove unused local var.
2070
792c7b2b
PE
2071 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2072 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2073 Omit unused local vars.
c499e557 2074 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2075 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2076 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2077 Omit unused local var.
2078
ba0165e1
PE
2079 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2080 Don't assume string length fits in int.
32ad8845 2081 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2082 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2083
3c59b4c9
PE
2084 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2085 instead of alloca (Bug#8344).
2086
a3eed478 2087 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2088 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2089
eb4d412d
PE
2090 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2091
1658b401
PE
2092 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2093 concerns.
2094
2095 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2096
2097 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2098
9a2c6e05
PE
2099 * keyboard.c (syms_of_keyboard): Use the same style as later
2100 in this function when indexing through an array. This also
2101 works around GCC bug 48267.
2102
03d0a109
PE
2103 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2104
44f730c8
PE
2105 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2106
fe75f926
PE
2107 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2108 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2109
ffa8c828
PE
2110 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2111 This avoids undefined behavior on integer overflow, and is a bit
2112 more convenient anyway since it is compared to a size_t variable.
2113
c5101a77
PE
2114 Variadic C functions now count arguments with size_t, not int.
2115 This avoids an unnecessary limitation on 64-bit machines, which
2116 caused (substring ...) to crash on large vectors (Bug#8344).
2117 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2118 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2119 All variadic functions and their callers changed accordingly.
c5101a77
PE
2120 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2121 * data.c (arith_driver, float_arith_driver): Likewise.
2122 * editfns.c (general_insert_function): Likewise.
2123 * eval.c (struct backtrace.nargs, interactive_p)
2124 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2125 (funcall_lambda, mark_backtrace): Likewise.
2126 * fns.c (concat): Likewise.
2127 * frame.c (x_set_frame_parameters): Likewise.
2128 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2129 0 if not found, not -1. All callers changed.
2130
dd3f25f7
PE
2131 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2132 (stack_copy_size): Now size_t, not int.
2133 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2134
461c2ab9
JB
21352011-03-28 Juanma Barranquero <lekktu@gmail.com>
2136
2137 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2138 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2139 All callers changed.
2140
2141 * lisp.h (multibyte_char_to_unibyte):
2142 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2143 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2144 * character.h (CHAR_TO_BYTE8):
2145 * cmds.c (internal_self_insert):
2146 * editfns.c (general_insert_function):
2147 * keymap.c (push_key_description):
2148 * search.c (Freplace_match):
2149 * xdisp.c (message_dolog, set_message_1): All callers changed.
2150
f6d62986
SM
21512011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2152
2153 * keyboard.c (safe_run_hook_funcall): New function.
2154 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2155 don't set the hook to nil, but remove the offending function instead.
2156 (Qcommand_hook_internal): Remove, unused.
2157 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2158 Vcommand_hook_internal.
2159
2160 * eval.c (enum run_hooks_condition): Remove.
2161 (funcall_nil, funcall_not): New functions.
2162 (run_hook_with_args): Call each function through a `funcall' argument.
2163 Remove `cond' argument, now redundant.
2164 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2165 (Frun_hook_with_args_until_failure): Adjust accordingly.
2166 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2167
1db5b1ad
JB
21682011-03-28 Juanma Barranquero <lekktu@gmail.com>
2169
2170 * dispextern.h (string_buffer_position): Remove declaration.
2171
2172 * print.c (strout): Remove parameter `multibyte', unused since
2173 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2174
2175 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2176 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2177 All callers changed.
2178
2179 * w32.c (_wsa_errlist): Use braces for struct initializers.
2180
2181 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2182 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2183 All callers changed.
2184 (string_buffer_position): Likewise. Also, make static (it's never
2185 used outside xdisp.c).
2186 (cursor_row_p): Remove parameter `w', unused since
2187 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2188 (decode_mode_spec): Remove parameter `precision', introduced during
2189 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2190 All callers changed.
2191
5ffb62aa
JD
21922011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2193
2194 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2195
461c2ab9 21962011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2197
2198 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2199 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2200 (ns_update_auto_hide_menu_bar): New functions.
2201 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2202 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2203 ns_constrain_all_frames.
2204 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2205 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2206
5c380ffb
JD
22072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2208
2209 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2210
9af30bdf
GM
22112011-03-27 Glenn Morris <rgm@gnu.org>
2212
2213 * syssignal.h: Replace RETSIGTYPE with void.
2214 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2215 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2216 Replace SIGTYPE with void everywhere.
2217 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2218 * s/template.h (SIGTYPE): Remove commented out definition.
2219
e2abce01
JB
22202011-03-26 Eli Zaretskii <eliz@gnu.org>
2221
2222 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2223 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2224
f868cd8a
JB
22252011-03-26 Juanma Barranquero <lekktu@gmail.com>
2226
59eb0929
JB
2227 * w32.c (read_unc_volume): Use parameter `henum', instead of
2228 global variable `wget_enum_handle'.
2229
2230 * keymap.c (describe_vector): Remove parameters `indices' and
2231 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2232 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2233
f868cd8a
JB
2234 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2235
2236 * keyboard.c (timer_check): Remove parameter `do_it_now',
2237 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2238 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2239 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2240
2241 * keyboard.c (read_char):
2242 * w32menu.c (w32_menu_display_help):
2243 * xmenu.c (show_help_event, menu_help_callback):
2244 Adjust calls to `show_help_echo'.
2245
2246 * gtkutil.c (xg_maybe_add_timer):
2247 * keyboard.c (readable_events):
2248 * process.c (wait_reading_process_output):
2249 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2250
2251 * insdel.c (adjust_markers_gap_motion):
2252 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2253 (gap_left, gap_right): Don't call it.
2254
2ecf6fdb
CY
22552011-03-25 Chong Yidong <cyd@stupidchicken.com>
2256
2257 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2258 incurred during fontification.
2259
6b1f9ba4
JB
22602011-03-25 Juanma Barranquero <lekktu@gmail.com>
2261
2262 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2263 (DEFVAR_PER_BUFFER): Don't pass it.
2264
2265 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2266 (scrolling_window): Don't pass it.
2267
0f4a96b5
JB
22682011-03-25 Juanma Barranquero <lekktu@gmail.com>
2269
2270 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2271
2272 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2273 and `suffix'.
2274 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2275 of variables specific to SELinux and computation of `encoded_absname'.
2276
2277 * image.c (XPutPixel): Remove unused variable `height'.
2278
2279 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2280
2281 * unexw32.c (get_section_info): Remove unused variable `section'.
2282
2283 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2284 (system_process_attributes): Remove unused variable `sess'.
2285 (sys_read): Remove unused variable `err'.
2286
2287 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2288 (w32_wnd_proc): Remove unused variable `isdead'.
2289 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2290 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2291 (x_create_tip_frame): Remove unused variable `tem'.
2292
2293 * w32inevt.c (w32_console_read_socket):
2294 Remove unused variable `no_events'.
2295
2296 * w32term.c (x_draw_composite_glyph_string_foreground):
2297 Remove unused variable `width'.
2298
1149507c
JB
22992011-03-24 Juanma Barranquero <lekktu@gmail.com>
2300
2301 * w32term.c (x_set_glyph_string_clipping):
2302 Don't pass uninitialized region to CombineRgn.
2303
9c88f339
JB
23042011-03-23 Juanma Barranquero <lekktu@gmail.com>
2305
2306 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2307 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2308 (Fx_close_connection): Remove unused variable `i'.
2309
2310 * w32font.c (w32font_draw): Return number of glyphs.
2311 (w32font_open_internal): Remove unused variable `i'.
2312 (w32font_driver): Add missing initializer.
2313
2314 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2315 (fill_in_menu): Remove unused variable `items_added'.
2316
2317 * w32term.c (last_mouse_press_frame): Remove static global variable.
2318 (w32_clip_to_row): Remove unused variable `f'.
2319 (x_delete_terminal): Remove unused variable `i'.
2320
2321 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2322 (NOTHING): Remove unused static global variable.
2323 (uniscribe_check_otf): Remove unused variable `table'.
2324 (uniscribe_font_driver): Add missing initializers.
2325
dee091a3
JD
23262011-03-23 Julien Danjou <julien@danjou.info>
2327
2328 * term.c (Fsuspend_tty, Fresume_tty):
2329 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2330 * window.c (temp_output_buffer_show):
2331 * insdel.c (signal_before_change):
2332 * frame.c (Fhandle_switch_frame):
2333 * fileio.c (Fdo_auto_save):
2334 * emacs.c (Fkill_emacs):
2335 * editfns.c (save_excursion_restore):
2336 * cmds.c (internal_self_insert):
2337 * callint.c (Fcall_interactively):
2338 * buffer.c (Fkill_all_local_variables):
2339 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2340 Use Frun_hooks.
0f4a96b5 2341 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2342 unconditionnaly since it does the check itself.
2343
2c520ab5 23442011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2345
c9c49752
PE
2346 Fix more problems found by GCC 4.5.2's static checks.
2347
8abc3f12
PE
2348 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2349 the first time through the loop, since we know p0 < p1 then.
2350 This also avoids a gcc -Wstrict-overflow warning.
2351
a2d26660
PE
2352 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2353 leading to a memory leak, possible in functions like
2354 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2355 of objects (Bug#8318).
a2d26660 2356
916c72e9
PE
2357 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2358 that could (at least in theory) be that large.
2359
19ab8a18
PE
2360 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2361 This is less likely to overflow, and avoids undefined behavior if
2362 overflow does occur. All callers changed. Use strtoul to scan
2363 for the unsigned long integer.
b7cbbd6f
PE
2364 (pint2hrstr): Simplify and tune code slightly.
2365 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2366
f0641eff
PE
2367 * scroll.c (do_scrolling): Work around GCC bug 48228.
2368 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2369
7f650bb9
PE
2370 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2371 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2372 (validate_x_resource_name): Simplify count usage.
2373 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2374
37dd57d1
PE
2375 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2376 fail (Bug#8306).
81e56e61 2377
699979fc 2378 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2379
401bf9b4
PE
2380 * process.c (Fmake_network_process): Use socklen_t, not int,
2381 where POSIX says socklen_t is required in portable programs.
2382 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2383 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2384 (Fmake_network_process, server_accept_connection):
2385 (wait_reading_process_output, read_process_output):
2386 Likewise.
2387
b93aacde
PE
2388 * process.c: Rename or move locals to avoid shadowing.
2389 (list_processes_1, Fmake_network_process):
2390 (read_process_output_error_handler, exec_sentinel_error_handler):
2391 Rename or move locals.
4dc343ee 2392 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2393 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2394 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2395 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2396 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2397
af8a867c 2398 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2399 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2400 Include tparam.h instead, since it declares them.
af8a867c
PE
2401 * cm.h (PC): Remove extern decl; tparam.h now does this.
2402 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2403 * terminfo.c: Include tparam.h, to check interfaces.
2404 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2405 (tparam): Adjust signature to match interface in tparam.h;
2406 this removes some undefined behavior. Check that outstring and len
2407 are zero, which they always are with Emacs.
2408 * tparam.h (PC, BC, UP): New extern decls.
2409
0248044d 2410 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2411 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2412
8ff096c1 2413 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2414 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2415 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2416 (ftfont_list): Remove unused local.
49eaafba
PE
2417 (get_adstyle_property, ftfont_pattern_entity):
2418 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2419 Rename locals to avoid shadowing.
8ff096c1 2420
e2be39f6
PE
2421 * xfont.c (xfont_list_family): Mark var as initialized.
2422
c9735e30
PE
2423 * xml.c (make_dom): Now static.
2424
8f5201ae
PE
2425 * composite.c (composition_compute_stop_pos): Rename local to
2426 avoid shadowing.
b246f932
PE
2427 (composition_reseat_it): Remove unused locals.
2428 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2429 (composition_update_it): Mark var as initialized.
11b61122
PE
2430 (find_automatic_composition): Mark vars as initialized,
2431 with a FIXME (Bug#8290).
8f5201ae 2432
760fbc2c
PE
2433 character.h: Rename locals to avoid shadowing.
2434 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2435 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2436 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2437 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2438 to avoid shadowing.
2439
ff08eb85
PE
2440 * textprop.c (property_change_between_p): Remove; unused.
2441
fc7bf025
PE
2442 * intervals.c (interval_start_pos): Now static.
2443
235d7abc
PE
2444 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2445
44f230aa
SM
2446 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2447 Rename locals to avoid shadowing.
3e7d6594 2448
50060332
PE
2449 * sound.c (wav_play, au_play, Fplay_sound_internal):
2450 Fix pointer signedness.
d01f234b 2451 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2452 (wav_play): Initialize a variable to 0, to prevent undefined
2453 behavior (Bug#8278).
50060332 2454
c4fc4e30
PE
2455 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2456
918436ed
PE
2457 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2458
c939f91b
PE
2459 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2460 clobbering (Bug#8298).
b9c7f648
PE
2461 * sysdep.c (sys_subshell): Likewise.
2462 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2463
6bd8c144
PE
2464 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2465 This should get cleaned up, so that child_setup has the
2466 same signature on all platforms.
2467
7710357c 2468 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2469 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2470
c59da222
CY
24712011-03-22 Chong Yidong <cyd@stupidchicken.com>
2472
2473 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2474 not to be necessary, and produces flickering.
2475
66b87493
GM
24762011-03-20 Glenn Morris <rgm@gnu.org>
2477
2478 * config.in: Remove file.
2479
45b6f6d5
JB
24802011-03-20 Juanma Barranquero <lekktu@gmail.com>
2481
2482 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2483 are now in src/globals.h.
2484 (syms_of_minibuf): Remove spurious & from previous change.
2485
3ec03f7e
LL
24862011-03-20 Leo <sdl.web@gmail.com>
2487
2488 * minibuf.c (completing-read-function): New variable.
2489 (completing-read-default): Rename from completing-read.
2490 (completing-read): Call completing-read-function.
2491
b14e3e21
CY
24922011-03-19 Juanma Barranquero <lekktu@gmail.com>
2493
2494 * xfaces.c (Fx_load_color_file):
2495 Read color file from absolute filename (bug#8250).
2496
f2b726e6
JB
24972011-03-19 Juanma Barranquero <lekktu@gmail.com>
2498
2499 * makefile.w32-in: Update dependencies.
2500
09f6ff02
EZ
25012011-03-17 Eli Zaretskii <eliz@gnu.org>
2502
2503 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2504
29a6015a
PE
25052011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2506
a3a6c54e
PE
2507 Fix more problems found by GCC 4.5.2's static checks.
2508
b766f867
PE
2509 * process.c (make_serial_process_unwind, send_process_trap):
2510 (sigchld_handler): Now static.
2511
be02381c
PE
2512 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2513 That way, the code declares only the vars that it needs.
2514 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2515 * s/cygwin.h (PTY_ITERATION): Likewise.
2516 * s/darwin.h (PTY_ITERATION): Likewise.
2517 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2518
57048744
PE
2519 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2520 * process.c (allocate_pty): Don't declare stb unless it's needed.
2521
7914961c 2522 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2523 (CONSTANTLIM): Remove; unused.
2524 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2525 Define only if needed.
7914961c 2526
b3967b18
PE
2527 * unexelf.c (unexec): Name an expression,
2528 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2529 Use a different way to cause a compilation error if anyone uses
2530 n rather than nn, a way that does not involve shadowing.
73366a00 2531 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2532
29a6015a
PE
2533 * deps.mk (unexalpha.o): Remove; unused.
2534
43cfc33e 2535 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2536 * unexec.h: New file.
ce701a33
PE
2537 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2538 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2539 Depend on unexec.h.
2540 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2541 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2542 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2543 Change as necessary to match prototype in unexec.h.
ce701a33 2544
01f44d5a
PE
2545 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2546 shadowing.
4f63c6bb 2547 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2548
a6670b0b
PE
2549 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2550 Rename locals to avoid shadowing.
2551
cef2010d 2552 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2553 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2554
d4d7173a
PE
2555 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2556
f08b802a
PE
2557 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2558 warning when compiling print.c.
2559
3ddb0639
PE
2560 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2561 instead of using an uninitialized var.
5ad03b97 2562 (font_sort_entities): Mark var as initialized.
3ddb0639 2563
170a2692
PE
2564 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2565
e663c700
PE
2566 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2567 pointers to constants.
89bc529a 2568 (font_parse_fcname): Remove unused vars.
7b81e2d0 2569 (font_delete_unmatched): Now static.
ea838e10 2570 (font_get_spec): Remove; unused.
13a547c6
PE
2571 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2572 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2573 Rename or move locals to avoid shadowing.
e663c700 2574
2a80c887 2575 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2576 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2577
1384fa33 2578 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2579 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2580
8b2c52e9
PE
2581 * alloc.c (mark_backtrace): Move decl from here ...
2582 * lisp.h: ... to here, so that it can be checked.
2583
475545b5 2584 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2585 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2586 (lisp_indirect_variable): Name an expression,
2587 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2588 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2589
b1349114 2590 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2591 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2592 Use const pointer when appropriate.
b1349114 2593
a2928364
PE
2594 * lisp.h (get_system_name, get_operating_system_release):
2595 Move decls here, to check interfaces.
2596 * process.c (get_operating_system_release): Move decl to lisp.h.
2597 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2598 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2599 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2600 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2601 (Fformat_time_string, Fencode_time, Finsert_char):
2602 (Ftranslate_region_internal, Fformat):
2603 Rename or remove local vars to avoid shadowing.
9710023e 2604 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2605
a415e694
PE
2606 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2607 avoid shadowing.
2608
8ef4622d
PE
2609 * lisp.h (eassert): Check that the argument compiles, even if
2610 ENABLE_CHECKING is not defined.
2611
946f9a5b
PE
2612 * data.c (Findirect_variable): Name an expression, to avoid
2613 gcc -Wbad-function-cast warning.
112396d6 2614 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2615 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2616 (Fmake_variable_buffer_local, Fmake_local_variable):
2617 Mark variables as initialized.
52746918 2618 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2619
e5aab7e7 2620 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2621 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2622 Rename locals to avoid shadowing.
dff45157
PE
2623 (mark_stack): Move local variables into the #ifdef region where
2624 they're used.
7bc26fdb
PE
2625 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2626 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2627 needed otherwise.
2628 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2629 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2630 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2631
e5aab7e7
PE
2632 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2633 avoids undefined behavior in theory.
2634
4da60324
PE
2635 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2636
88043301
PE
2637 Use functions, not macros, for up- and down-casing (Bug#8254).
2638 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2639 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2640 to use the following functions instead of these macros.
2641 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2642 EMACS_INT, since callers assume the returned value fits in int.
2643 (upcase1): Likewise, for UPCASE_TABLE.
2644 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2645 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2646 the race-condition problem in the old DOWNCASE.
88043301 2647
19ed5445
PE
2648 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2649 Rename locals to avoid shadowing.
2650 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2651 (regex_compile, re_search_2, re_match_2_internal):
2652 Remove unused local vars.
952db0d7
PE
2653 (FREE_VAR): Rewrite so as not to use empty "else",
2654 which gcc can warn about.
da053e48 2655 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2656 (RETALLOC_IF): Define only if needed.
2657 (WORDCHAR_P): Likewise. This one is never needed, but is used
2658 only in a comment talking about a compiler bug, so put inside
2659 the #if 0 of that comment.
2660 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2661 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2662 Remove; unused.
19ed5445 2663
1f3561e4 2664 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2665 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2666 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2667
ded6f8f7
PE
2668 * search.c (simple_search): Remove unused var.
2669
dbd37a95
PE
2670 * dired.c (compile_pattern): Move decl from here ...
2671 * lisp.h: ... to here, so that it can be checked.
2672 (struct re_registers): New forward decl.
2673
7e47afad
PE
2674 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2675
85f24f61
PE
2676 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2677 All uses changed.
2678 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2679 Rename locals to avoid shadowing.
5671df8f 2680 (Fvertical_motion): Mark locals as initialized.
85f24f61 2681
181aa2be 2682 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2683 (casify_region): Mark local as initialized.
181aa2be 2684
930d429c
PE
2685 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2686
7082eac6
PE
2687 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2688 New macros, so that the caller can use some names other than
2689 gcpro1, gcpro2, etc.
2690 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2691 of the new macros.
2692 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2693 argument, for consistency with GCPRO2_VAR, etc: it is now the
2694 prefix of the variable, not the variable itself. All uses
2695 changed.
38b2c076
PE
2696 * dired.c (directory_files_internal, file_name_completion):
2697 Rename locals to avoid shadowing.
2698
15206ed9
PE
2699 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2700 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2701 dired.c's scmp function, had undefined behavior.
2702 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2703 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2704 * buffer.h: ... to here, because these macros use current_buffer,
2705 and the new implementation with inline functions needs to have
2706 current_buffer in scope now, rather than later when the macros
2707 are used.
2708 (downcase, upcase1): New static inline functions.
2709 (DOWNCASE, UPCASE1): Reimplement using these functions.
2710 This avoids undefined behavior in expressions like
2711 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2712 from race conditions in accessing the global variables
2713 case_temp1 and case_temp2.
2714 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2715 * lisp.h (case_temp1, case_temp2): Remove their decls.
2716 * character.h (ASCII_CHAR_P): Move from here ...
2717 * lisp.h: ... to here, so that the inline functions mentioned
2718 above can use them.
2719
4a6bea26
PE
2720 * dired.c (directory_files_internal_unwind): Now static.
2721
f14b7e14
PE
2722 * fileio.c (file_name_as_directory, directory_file_name):
2723 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2724 Now static.
2893f146
PE
2725 (file_name_as_directory): Use const pointers when appropriate.
2726 (Fexpand_file_name): Likewise. In particular, newdir might
2727 point at constant storage, so make it a const pointer.
fd4ead52 2728 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2729 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2730 signedness issues.
f839df0c
PE
2731 (Fset_file_times, Finsert_file_contents, auto_save_error):
2732 Rename locals to avoid shadowing.
f14b7e14 2733
5716756e 2734 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2735 (Ftry_completion, Fall_completions): Rename or remove locals
2736 to avoid shadowing.
5716756e 2737
b4c3046a
PE
2738 * marker.c (bytepos_to_charpos): Remove; unused.
2739
b45db522
PE
2740 * lisp.h (verify_bytepos, count_markers): New decls,
2741 so that gcc does not warn that these functions aren't declared.
2742
85876d07
PE
2743 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2744 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2745 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2746 (copy_text): Remove unused local var.
85876d07 2747
03d78a21 2748 * filelock.c (within_one_second): Now static.
b3dd38ab 2749 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2750
5df8f01b
PE
2751 * buffer.c (fix_overlays_before): Mark locals as initialized.
2752 (fix_start_end_in_overlays): Likewise. This function should be
2753 simplified by using pointers-to-pointers, but that's a different
2754 matter.
b1d876f1 2755 (switch_to_buffer_1): Now static.
8f54f30a
PE
2756 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2757 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2758
a70072c9 2759 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2760 Fix pointer signedness issue.
edced198
PE
2761 (sys_subshell): Mark local as volatile if checking for lint,
2762 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2763 (MAXPATHLEN): Define only if needed.
a70072c9 2764
a0977c44
PE
2765 * process.c (serial_open, serial_configure): Move decls from here ...
2766 * systty.h: ... to here, so that they can be checked.
2767
a884fdcc
PE
2768 * fns.c (get_random, seed_random): Move extern decls from here ...
2769 * lisp.h: ... to here, so that they can be checked.
2770
604efe86 2771 * sysdep.c (reset_io): Now static.
b8950c94 2772 (wait_for_termination_signal): Remove; unused.
604efe86 2773
38fc62d9
PE
2774 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2775 (copy_keymap_item, append_key, push_text_char_description):
2776 Now static.
1004a21a 2777 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2778 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2779 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2780 (describe_map_tree):
2781 Rename locals to avoid shadowing.
38fc62d9 2782
2f2650da
PE
2783 * keyboard.c: Declare functions static if they are not used elsewhere.
2784 (echo_char, echo_dash, cmd_error, top_level_2):
2785 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2786 (read_char, kbd_buffer_get_event, make_lispy_position):
2787 (make_lispy_event, make_lispy_movement, apply_modifiers):
2788 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2789 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2790 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2791 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2792 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2793
a053e86c 2794 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2795 (mark_kboards): Move decl here ...
2796 * alloc.c (mark_kboards): ... from here.
a053e86c 2797
4752793e
PE
2798 * lisp.h (force_auto_save_soon): New decl.
2799
74f10ca7 2800 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2801 (DEFINE_DUMMY_FUNCTION): New macro.
2802 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2803 Use it.
c03cd23f
PE
2804 (main): Add casts to avoid warnings
2805 if GCC considers string literals to be constants.
74f10ca7 2806
022e70d4
PE
2807 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2808
59d6fe83
PE
2809 * dbusbind.c: Pointer signedness fixes.
2810 (xd_signature, xd_append_arg, xd_initialize):
2811 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2812 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2813 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2814 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2815
78320123
PE
2816 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2817 if GCC considers string literals to be constants.
49cebcca 2818 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2819
35ac2a97
SM
28202011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2821
fb103ca9
SM
2822 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2823 (print_preprocess, print_object): New macro to fix last change.
2824
35ac2a97
SM
2825 * print.c (print_preprocess): Don't forget font objects.
2826
62973b41
JB
28272011-03-16 Juanma Barranquero <lekktu@gmail.com>
2828
2829 * emacs.c (USAGE3): Doc fixes.
2830
0e48bb22
AS
28312011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2832
2833 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2834 structure.
2835
7684e57b
JB
28362011-03-14 Juanma Barranquero <lekktu@gmail.com>
2837
2838 * lisp.h (VWindow_system, Qfile_name_history):
2839 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2840 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2841 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2842
2843 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2844 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2845
2846 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2847 * w32console.c (detect_input_pending, read_input_pending)
2848 (encode_terminal_code):
2849 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2850 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2851 (w32_system_caret_y, Qfile_name_history):
2852 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2853 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2854 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2855 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2856 * w32proc.c (Qlocal, report_file_error):
2857 * w32term.c (Vwindow_system, updating_frame):
2858 * w32uniscribe.c (initialized, uniscribe_font_driver):
2859 Remove unneeded extern declarations.
2860
2aa46d6c
CY
28612011-03-14 Chong Yidong <cyd@stupidchicken.com>
2862
c96bbc66 2863 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2864
cffc6f3b
CY
28652011-03-13 Chong Yidong <cyd@stupidchicken.com>
2866
2867 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2868 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2869 These macros can no longer be used for assignment.
2870
44f230aa
SM
2871 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2872 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2873 (record_buffer_markers, fetch_buffer_markers): New functions for
2874 recording and fetching special buffer markers.
2875 (set_buffer_internal_1, set_buffer_temp): Use them.
2876
2877 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2878
2879 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2880
2881 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2882 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2883
2884 * xdisp.c (hscroll_window_tree):
2885 (reconsider_clip_changes): Use PT instead of BUF_PT.
2886
d251f04b
EZ
28872011-03-13 Eli Zaretskii <eliz@gnu.org>
2888
2889 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2890 $(EMACS_ROOT)/lib/intprops.h.
2891
f0c77cd1
PE
28922011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2893
3eca4629
PE
2894 Fix more problems found by GCC 4.5.2's static checks.
2895
7c86ee98
PE
2896 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2897 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2898 (xg_free_frame_widgets): Make it clear that a local variable is
2899 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2900 (gdk_window_get_screen): Make it clear that this macro is needed
2901 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2902 (int_gtk_range_get_value): New function, which avoids a diagnostic
2903 from gcc -Wbad-function-cast.
2904 (xg_set_toolkit_scroll_bar_thumb): Use it.
2905 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2906 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2907 (get_utf8_string, xg_get_file_with_chooser):
2908 Rename locals to avoid shadowing.
2909 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2910
41729b81
PE
2911 * xgselect.c (xg_select): Remove unused var.
2912
f0c77cd1
PE
2913 * image.c (four_corners_best): Mark locals as initialized.
2914 (gif_load): Initialize transparent_p to zero (Bug#8238).
2915 Mark another local as initialized.
ec6cf4c6 2916 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2917
ce0ad53d 2918 * image.c (clear_image_cache): Now static.
d5d5a617 2919 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2920 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2921 (x_edge_detection): Remove unnecessary cast that
2922 gcc -Wbad-function-cast diagnoses.
2037898d 2923 (gif_load): Fix pointer signedness.
6ae141d6
PE
2924 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2925 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2926
33383987 29272011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2928
d32df629
PE
2929 Improve quality of tests for time stamp overflow.
2930 For example, without this patch (encode-time 0 0 0 1 1
2931 1152921504606846976) returns the obviously-bogus value (-948597
2932 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2933 reports time overflow. See
2934 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2935 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2936 * editfns.c: Include limits.h and intprops.h.
2937 (TIME_T_MIN, TIME_T_MAX): New macros.
2938 (time_overflow): Move earlier, to before first use.
2939 (hi_time, lo_time): New functions, for an accurate test for
2940 out-of-range times.
2941 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2942 (Fget_internal_run_time): Don't assume time_t fits in int.
2943 (make_time): Use list2 instead of Fcons twice.
2944 (Fdecode_time): More accurate test for out-of-range times.
2945 (check_tm_member): New function.
2946 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2947 (lisp_time_argument): Don't rely on undefined left-shift and
2948 right-shift behavior when checking for time stamp overflow.
8be6f318 2949
fe31d94c
PE
2950 * editfns.c (time_overflow): New function, refactoring common code.
2951 (Fformat_time_string, Fdecode_time, Fencode_time):
2952 (Fcurrent_time_string): Use it.
2953
8be6f318
PE
2954 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2955 * dired.c (make_time): Move to ...
2956 * editfns.c (make_time): ... here.
2957 * systime.h: Note the move.
2958
09d9db2c 29592011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2960
126bc0dc
YM
2961 * fringe.c (update_window_fringes): Remove unused variables.
2962
c47cbdfd
YM
2963 * unexmacosx.c (copy_data_segment): Also copy __got section.
2964 (Bug#8223)
2965
7ac80be9
EZ
29662011-03-12 Eli Zaretskii <eliz@gnu.org>
2967
c96bbc66 2968 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2969 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2970 Constify `char *' arguments and their references according to
2971 prototypes in tparam.h.
2972
ecb0f94d 2973 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2974
7ac80be9
EZ
2975 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2976 Adapt all references accordingly.
2977
2978 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2979
ef1fd07e
TT
29802011-03-11 Tom Tromey <tromey@redhat.com>
2981
2982 * buffer.c (syms_of_buffer): Remove obsolete comment.
2983
7ef4b50c
EZ
29842011-03-11 Eli Zaretskii <eliz@gnu.org>
2985
2986 * termhooks.h (encode_terminal_code): Declare prototype.
2987
2988 * msdos.c (encode_terminal_code): Don't declare prototype.
2989
2990 * term.c (encode_terminal_code): Now external again, used by
2991 w32console.c and msdos.c.
2992
44f230aa
SM
2993 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2994 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2995
4b1ec863 29962011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2997
1714f52b 2998 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2999
4b1ec863
PE
3000 * fringe.c (update_window_fringes): Mark locals as initialized
3001 (Bug#8227).
3002 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3003
524c7aa6
PE
3004 * alloc.c (mark_fringe_data): Move decl from here ...
3005 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3006 to check its interface.
3007 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3008
a5c0af81 3009 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3010 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3011 (fontset_font): Mark local as initialized.
a9a06e0b 3012 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3013
b4716021
PE
3014 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3015
811e9bac 3016 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3017 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3018 (x_own_selection, Fx_disown_selection_internal): Rename locals
3019 to avoid shadowing.
3020 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3021
7e3ab302
PE
3022 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3023 so that the caller can use some name other than gcpro1.
3024 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3025 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3026 (Fx_backspace_delete_keys_p):
3027 Use them to avoid shadowing, and rename vars to avoid shadowing.
3028 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3029 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3030 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3031 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3032 Remove unused locals.
7e3ab302
PE
3033 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3034 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3035 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3036 macros.
f78faa98 3037
e2b13473
PE
3038 * xterm.h (x_mouse_leave): New decl.
3039
77f23912
PE
3040 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3041 Remove unused functions.
cdf4ba58
PE
3042 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3043 (x_calc_absolute_position): Now static.
7411c686 3044 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3045 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3046 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3047 unless they are used.
38d0b34a
PE
3048 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3049 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3050 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3051 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3052 (x_error_catcher, x_connection_closed, x_error_handler):
3053 (x_error_quitter, xembed_send_message, x_iconify_frame):
3054 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3055 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3056 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3057
44f230aa
SM
3058 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3059 Rename or move locals to avoid shadowing.
6b463e58 3060 (tty_defined_color, merge_face_heights): Now static.
5967d051 3061 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3062 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3063 does not deduce is never used uninitialized.
73719eba
PE
3064 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3065 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3066
426994c3 3067 * terminal.c (store_terminal_param): Now static.
5489860b 3068
032f1620 3069 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3070 (set_frame_menubar): Remove unused local.
d4323972 3071 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3072 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3073 since they might point to immutable storage.
281585b0
PE
3074 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3075 since it's unused otherwise.
032f1620 3076
367c19e5 3077 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3078 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3079 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3080 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3081 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3082 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3083 does not deduce are never used uninitialized.
70739cbe 3084
07b48fa9
PE
3085 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3086
8868a238 3087 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3088 * window.c (window_loop, size_window):
3089 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3090
7e5cf297 3091 * window.c (display_buffer): Now static.
d6550a9f
PE
3092 (size_window): Mark variables that gcc -Wuninitialized
3093 does not deduce are never used uninitialized.
a586633d
PE
3094 * window.h (check_all_windows): New decl, to forestall
3095 gcc -Wmissing-prototypes diagnostic.
5b555da1 3096 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3097
f6095868
PE
3098 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3099 shadowing.
3100 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3101 Include <limits.h>.
3102 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3103 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3104 (load_charset_map): Mark variables that gcc -Wuninitialized
3105 does not deduce are never used uninitialized.
53df7c11 3106 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3107
f38b440c
PE
3108 * coding.c (coding_set_source, coding_set_destination):
3109 Use "else { /* comment */ }" rather than "else /* comment */;"
3110 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3111 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3112 a block, when the outer 'i' will do.
3113 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3114 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3115 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3116 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3117 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3118 Rename locals to avoid shadowing.
3119 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3120 * coding.c (emacs_mule_char, encode_invocation_designation):
3121 Now static, since they're not used elsewhere.
413bb2db 3122 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3123 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3124 (decode_coding_emacs_mule): Mark variables that gcc
3125 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3126 (detect_coding_iso_2022): Initialize a local variable that might
3127 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3128 this initialization is needed. (Bug#8211)
5f58e762
PE
3129 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3130 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3131 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3132 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3133 Remove unused macros.
f38b440c 3134
232b38b9 3135 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3136 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3137 * character.c (string_count_byte8): Likewise.
232b38b9 3138
fb90da1b
PE
3139 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3140 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3141
fb93dbc2
PE
3142 * chartab.c (copy_sub_char_table): Now static, since it's not used
3143 elsewhere.
5c156ace
PE
3144 (sub_char_table_ref_and_range, char_table_ref_and_range):
3145 Rename locals to avoid shadowing.
bbcd0949 3146 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3147
7d3b3862 3148 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3149 (BIDI_BOB): Remove unused macro.
7d3b3862 3150
6be7d3da
PE
3151 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3152 deduce are never used uninitialized.
c2ed9c8b 3153 * term.c (encode_terminal_code): Likewise.
6be7d3da 3154
75f8807f 3155 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3156
50938595
PE
3157 * tparam.h: New file.
3158 * term.c, tparam.h: Include it.
3159 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3160 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3161 Move these decls to tparam.h, and make them agree with what
3162 is actually in tparam.c. The previous trick of using incompatible
3163 decls in different modules does not conform to the C standard.
3164 All callers of tparam changed to use tparam's actual API.
3165 * tparam.c (tparam1, tparam, tgoto):
3166 Use const pointers where appropriate.
3167
fbceeba2
PE
3168 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3169 * cm.h (struct cm): Likewise.
3170 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3171 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3172 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3173 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3174 (turn_on_face, init_tty): Likewise.
3175 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3176
7f3f1250
PE
3177 * term.c (term_mouse_position): Rename local to avoid shadowing.
3178
e6ca6543
PE
3179 * alloc.c (mark_ttys): Move decl from here ...
3180 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3181
c40f8d15
AS
31822011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3183
3184 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3185
cfe0661d
JB
31862011-03-09 Juanma Barranquero <lekktu@gmail.com>
3187
3188 * search.c (compile_pattern_1): Remove argument regp, unused since
3189 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3190 (compile_pattern): Don't pass it.
3191
0afb4571
J
31922011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3193
3194 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3195 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3196 for ! HAVE_GTK3.
3197 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3198
3199 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3200
3201 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3202 gdk_window_get_screen, gdk_window_get_geometry,
3203 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3204 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3205 (xg_get_pixbuf_from_pixmap): New function.
3206 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3207 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3208 Call xg_get_pixbuf_from_pixmap instead of
3209 gdk_pixbuf_get_from_drawable.
3210 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3211 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3212 (xg_check_special_colors): Use GtkStyleContext and its functions
3213 for HAVE_GTK3.
3214 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3215 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3216 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3217 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3218 Call gtk_widget_get_preferred_size.
0afb4571
J
3219 (xg_frame_resized): gdk_window_get_geometry only takes 5
3220 parameters.
44f230aa
SM
3221 (xg_win_to_widget, xg_event_is_for_menubar):
3222 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3223 (xg_set_widget_bg): New function.
3224 (delete_cb): New function.
895009e1 3225 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3226 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3227 (xg_set_background_color): Call xg_set_widget_bg.
3228 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3229 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3230 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3231 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3232 if ! HAVE_GTK3.
3233 (update_frame_tool_bar): Call gtk_widget_hide.
3234 (xg_initialize): Use GDK_KEY_g.
3235
3236 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3237 if ! HAVE_GTK3
3238 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3239
3240 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3241 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3242 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3243
1c2cc4ef
JB
32442011-03-08 Juanma Barranquero <lekktu@gmail.com>
3245
3246 * w32xfns.c (select_palette): Check success of RealizePalette against
3247 GDI_ERROR, not zero.
3248
33383987 3249See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3250
3251;; Local Variables:
3252;; coding: utf-8
aac0c6e3
MR
3253;; End:
3254
33383987 3255 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3256
3257 This file is part of GNU Emacs.
3258
3259 GNU Emacs is free software: you can redistribute it and/or modify
3260 it under the terms of the GNU General Public License as published by
3261 the Free Software Foundation, either version 3 of the License, or
3262 (at your option) any later version.
3263
3264 GNU Emacs is distributed in the hope that it will be useful,
3265 but WITHOUT ANY WARRANTY; without even the implied warranty of
3266 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3267 GNU General Public License for more details.
3268
3269 You should have received a copy of the GNU General Public License
3270 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.