* emacs.c: Do not include <verify.h>; no longer needed.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5eceb8fb
PE
12012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2
3 Fix export of symbols to GDB (Bug#12036).
4 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
5 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
6 emacs.c, as this is a more-suitable home. Had this been done earlier
7 the fix for 12036 would have avoided some of the problems noted in
8 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
9 would have been more obvious.
562157c8
PE
10 * emacs.c: Do not include <verify.h>; no longer needed.
11 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
12 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
13 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
14 Remove; now done in lisp.h.
15 * lisp.h (PUBLISH_TO_GDB): New macro.
16 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
17 (DATA_SEG_BITS): Use it.
18 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
19 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
20 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
21 not be usable in #if. This simplifies things.
22
d6749401
JB
232012-07-26 Juanma Barranquero <lekktu@gmail.com>
24
25 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
26
1781b9e9
PE
272012-07-26 Paul Eggert <eggert@cs.ucla.edu>
28
d89518db 29 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
30 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
31 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
32 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
33 Adjust to changes in lisp.h and emacs.c, by using
34 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
35 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
36 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
37 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
38 instead of gdb_valbits.
39 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
40 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
41 instead of gdb_array_mark_flag.
42 (xboolvector): Get size from $->size, not $->header.size.
43 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
44 (xreload, hook-run, hookpost-run): Remove.
45 * emacs.c: Include <verify.h>.
46 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
47 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
48 Remove.
49 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
50 (gdb_USE_LSB_TAG): New enum constants.
51 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
52 Also define these as enum constants, so they're visible to GDB.
53 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
54 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
55 as constants, so they're visible to GDB.
56 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
57 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
58 Now enum constants, not macros, so they're visible to GDB.
59 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
60 more convenient now. All uses changed.
61 (VALMASK) [USE_LSB_TAG]: Also define in this case.
62 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
63
3628596a
DA
642012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
65
66 Explicitly free restriction data that are not needed anymore.
67 * editfns.c (save_restriction_restore): Free restriction data.
68
7abaf5cc
SM
692012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
70
71 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
72 add argument, tune behavior, and adjust all callers.
73
71f88e00
PE
742012-07-25 Paul Eggert <eggert@cs.ucla.edu>
75
76 Use typedef for EMACS_INT, EMACS_UINT.
77 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
78 than macros. This simplifies debugging in the usual case, since
79 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
80 and it allows expressions involving EMACS_INT casts.
81 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
82
57ec3034
JD
832012-07-25 Jan Djärv <jan.h.d@swipnet.se>
84
85 * nsterm.m (ns_read_socket): Return early if there is a modal
86 window (Bug#12043).
87
8137e7b3
MR
882012-07-25 Martin Rudalics <rudalics@gmx.at>
89
90 * frame.c (Fredirect_frame_focus): In doc-string don't mention
91 that FOCUS-FRAME can be omitted.
92
04e9897c
DA
932012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
94
95 Adjust buffer text indirection counters at the end of Fkill_buffer.
96 * buffer.c (Fkill_buffer): Adjust indirection counters when the
97 buffer is definitely dead. This should really fix an issue reported
98 by Christoph Scholtes again. (Bug#12007).
99 (init_buffer_once): Initialize indirection counters of
100 buffer_defaults and buffer_local_symbols (for sanity and safety).
101
8a0484e1
EZ
1022012-07-24 Eli Zaretskii <eliz@gnu.org>
103
104 * xdisp.c (init_iterator): Don't compute dimensions of truncation
105 and continuation glyphs on tooltip frames, leave them at zero.
106 Avoids continued lines in tooltips. (Bug#11832)
107
fa691a83
DA
1082012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
109
110 Simplify copy_overlay.
04e9897c 111 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
112 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
113
436bc8e0
EZ
1142012-07-23 Eli Zaretskii <eliz@gnu.org>
115
116 * print.c (print_object): Don't crash when a frame's name is nil
117 or invalid. (Bug#12025)
118
119 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
120 it signals an error when a tooltip frame is being created.
121
d7a7fda3
DA
1222012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
123
124 Cleanup miscellaneous objects allocation and initialization.
125 * alloc.c (allocate_misc): Change to static. Add argument to
126 specify the subtype. Adjust comment and users.
127 (build_overlay): New function.
128 * buffer.c (copy_overlays, Fmake_overlay): Use it.
129 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
130 (allocate_misc): Remove prototype.
131 (build_overlay): Add prototype.
132
1332012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
134
135 Swap buffer text indirection counters in Fbuffer_swap_text.
136 * buffer.c (Fbuffer_swap_text): Swap indirections too.
137 This avoids crash reported by Christoph Scholtes at
138 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
139
9d7fa573
JD
1402012-07-22 Jan Djärv <jan.h.d@swipnet.se>
141
142 * nsmenu.m (Popdown_data): New struct.
143 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
144 free Popdown_data.
145 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
146 (initWithContentRect): Make imgView and contentView non-static
147 and autorelease them. Also autorelease img and matrix (Bug#12005).
148 (dealloc): Remove (Bug#12005).
149
0dd6d66d
DA
1502012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
151
152 Adjust consing_since_gc when objects are explicitly freed.
153 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
154 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
155 (free_cons, free_misc): Subtract object size from consing_since_gc.
156
d36d71df
DA
1572012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
158
159 Simplify and cleanup markers positioning code.
160 * marker.c (attach_marker): More useful eassert.
161 (live_buffer, set_marker_internal): New function.
162 (Fset_marker, set_marker_restricted): Use set_marker_internal.
163 (set_marker_both, set_marker_restricted_both): Use live_buffer.
164
fb9ea40f
PE
1652012-07-22 Paul Eggert <eggert@cs.ucla.edu>
166
167 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
168 as it's limited by the amount of memory, not by INT_MAX.
169
2d5c5f7d
EZ
1702012-07-21 Eli Zaretskii <eliz@gnu.org>
171
07fb592e
EZ
172 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
173 in special-event-map. See the discussion at
174 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
175 for the reasons.
176
37a9eac8 177 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
178 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
179 Fabrice Popineau <fabrice.popineau@supelec.fr>.
180
c4328746
JD
1812012-07-21 Jan Djärv <jan.h.d@swipnet.se>
182
183 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 184 (conversationIdentifier): Return value is NSInteger.
784051c4 185 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 186
6e5d1c12
CY
1872012-07-21 Chong Yidong <cyd@gnu.org>
188
189 * window.c (decode_any_window): Signal an error if the window is
190 on a dead frame (Bug#11984).
191
9928463d
DA
1922012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
193
194 Add indirection counting to speed up Fkill_buffer.
195 * buffer.h (struct buffer): New member.
196 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
197 (Fmake_indirect_buffer): Set indirection counter to -1, increment
198 base buffer indirection counter.
199 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
200 (Fkill_buffer): Adjust indirection counters as needed, don't walk
201 through buffer list if indirection counter is 0.
202
f8643a6b
DA
2032012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
204
205 Extend the value returned by Fgarbage_collect with heap statistics.
206 * alloc.c (Qheap): New symbol.
207 (syms_of_alloc): DEFSYM it.
208 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
209 (Fmemory_free): Remove.
210 (syms_of_alloc): Don't defsubr it.
211 * buffer.c (Fcompact_buffer): Remove.
212 (syms_of_buffer): Don't defsubr it.
213
dac616ff
DA
2142012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
215
216 Make maybe_gc inline.
217 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
218 * lisp.h (consing_since_gc, gc_relative_threshold)
219 (memory_full_cons_threshold): Revert declaration.
220 (maybe_gc): Remove prototype, define as inline.
221 * alloc.c: Remove old commented-out code.
222 (consing_since_gc, gc_relative_threshold)
223 (memory_full_cons_threshold): Revert to global.
224 (maybe_gc): Remove.
225
d7ea76b4
DA
2262012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
227
228 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
229 * lisp.h (build_unibyte_string): New function.
230 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
231 * sysdep.c, w32fns.c, xfns.c: Use it.
232 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
233 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
234 Adjust users accordingly.
235 * font.h (font_open_by_name): Adjust prototype.
236
765e61e3
DA
2372012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
238
239 Cleanup calls to Fgarbage_collect.
240 * lisp.h (maybe_gc): New prototype.
241 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
242 Remove declarations.
243 * alloc.c (maybe_gc): New function.
244 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
245 Make them static.
246 * bytecode.c (MAYBE_GC): Use maybe_gc.
247 * eval.c (eval_sub, Ffuncall): Likewise.
248 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
249 to avoid dependency from auto-save feature.
250
52b852c7
PE
2512012-07-19 Paul Eggert <eggert@cs.ucla.edu>
252
253 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
254 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
255 'for_each_per_buffer_object_at'.
256 All uses changed. It's better to use upper-case for macros that
257 cannot be implemented as functions, to give the reader a clue
258 that they're special.
259
5db81e33
SM
2602012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
261
262 * alloc.c (Fgarbage_collect): Tweak docstring.
263
5b835e1d
DA
2642012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
265
266 Tweak the value returned from Fgarbage_collect again.
267 * alloc.c (Fgarbage_collect): New return value, as confirmed in
268 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
269 Adjust documentation.
270 (total_vector_bytes): Rename to total_vector_slots, adjust
271 accounting.
272 (total_free_vector_bytes): Rename to total_free_vector_slots,
273 adjust accounting.
274 (Qstring_bytes, Qvector_slots): New symbols.
275 (syms_of_alloc): DEFSYM them.
276
9cd47b72
DA
2772012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
278
279 Buffer compaction primitive which may be used from Lisp.
280 * buffer.c (compact_buffer, Fcompact_buffer): New function.
281 (syms_of_buffer): Register Fcompact_buffer.
282 * alloc.c (Fgarbage_collect): Use compact_buffer.
283 * buffer.h (compact_buffer): New prototype.
284 (struct buffer_text): New member.
285
d17337e5
DA
2862012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
287
288 New macro to iterate over all buffers, miscellaneous cleanups.
289 * lisp.h (all_buffers): Remove declaration.
290 * buffer.h (all_buffers): Add declaration, with comment.
291 (for_each_buffer): New macro.
292 * alloc.c (Fgarbage_collect, mark_object): Use it.
293 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
294 (init_buffer): Likewise.
295 * data.c (Fset_default): Likewise.
296 * coding.c (code_conversion_restore): Remove redundant check
297 for dead buffer.
298 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
299
60cfd278
AS
3002012-07-18 Andreas Schwab <schwab@linux-m68k.org>
301
302 Fix bug that created negative-length intervals.
303 * intervals.c (merge_interval_right, merge_interval_left):
304 Do not zero out this interval if it is absorbed by its children,
305 as this interval's total length doesn't change in that case. See
306 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
307
d06714cb
PE
3082012-07-18 Paul Eggert <eggert@cs.ucla.edu>
309
83713154
PE
310 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
311 when invoking (make-bool-vector N t) and N is a positive
312 multiple of 8 -- the last 8 bits were mistakenly cleared.
313
d06714cb
PE
314 Remove some struct layout assumptions in bool vectors.
315 * alloc.c (bool_header_size): New constant.
316 (header_size, word_size): Move earlier, as they're now used earlier.
317 Use 'word_size' in a few more places, where it's appropriate.
318 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
319 padding before the data member of a bool vector.
320 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
321 than doing the check by hand with an abort ().
322
464d5a5e
SM
3232012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
324
5fbc0409
SM
325 * eval.c (Fdefvar): Don't check constants since we only set the var if
326 it's not yet defined anyway (bug#11904).
327
464d5a5e
SM
328 * lisp.h (last_undo_boundary): Declare new var.
329 * keyboard.c (command_loop_1): Set it.
330 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
331 were auto-added by the command loop (bug#11774).
332
8dc2e44a
AS
3332012-07-18 Andreas Schwab <schwab@linux-m68k.org>
334
335 * w32font.c (Qsymbol): Remove local definition.
336 (syms_of_w32font): Don't DEFSYM it.
337
169925ec
DA
3382012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
339
340 Fix sweep_vectors to handle large bool vectors correctly.
341 * alloc.c (sweep_vectors): Account total_vector_bytes for
342 bool vectors larger than VBLOCK_BYTES_MAX.
343
5fbfb018
CY
3442012-07-18 Chong Yidong <cyd@gnu.org>
345
346 * frame.c (x_set_frame_parameters): Revert bogus change introduced
347 in 2012-05-25 commit by Paul Eggert (Bug#11738).
348
3ab6e069
DA
3492012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
350
351 Return more descriptive data from Fgarbage_collect.
352 Suggested by Stefan Monnier in
353 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
354 * alloc.c (bounded_number): New function.
355 (total_buffers, total_vectors): New variable.
356 (total_string_size): Rename to total_string_bytes, adjust users.
357 (total_vector_size): Rename to total_vector_bytes, adjust users.
358 (sweep_vectors): Account total_vectors and total_vector_bytes.
359 (Fgarbage_collect): New return value. Adjust documentation.
360 (gc_sweep): Account total_buffers.
361 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
362 (VECTOR_SIZE): Remove.
363 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
364 (Qinterval, Qmisc): New symbols.
365 (syms_of_data): Initialize them.
366 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
367 (Qcons, Qbuffer): New declarations.
368
6d02fe5b
PE
3692012-07-17 Paul Eggert <eggert@cs.ucla.edu>
370
371 * alloc.c (Fmemory_free): Account for memory-free's own storage.
372 Round up, not down. Improve doc.
373
b7ffe040
DA
3742012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
375
376 Restore old code in allocate_string_data to avoid Faset breakage.
377 Reported by Julien Danjou <julien@danjou.info> in
378 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
379 * alloc.c (allocate_string_data): Restore old code with minor
380 adjustments, fix comment to explain this subtle issue.
381
4dc7c8d5
SM
3822012-07-17 Eli Zaretskii <eliz@gnu.org>
383
384 Remove FILE_SYSTEM_CASE.
385 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
386
387 * fileio.c (FILE_SYSTEM_CASE): Don't define.
388 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
389 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
390 call-process-region passes it through expand-file-name.
391
392 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
393
3942012-07-17 Andreas Schwab <schwab@linux-m68k.org>
395
396 Fix crash when creating indirect buffer (Bug#11917)
397 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
398 Don't handle unbound variables specially if non-zero.
399 (Fbuffer_local_variables): Pass zero.
400 (clone_per_buffer_values): Pass non-zero.
401
4022012-07-17 Andreas Schwab <schwab@linux-m68k.org>
403
404 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
405 to make the loop interruptible.
406
4072012-07-17 Andreas Schwab <schwab@linux-m68k.org>
408
409 * gnutls.c (emacs_gnutls_handshake): Only retry if
410 GNUTLS_E_INTERRUPTED.
411
cce7fefc
DA
4122012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
413
414 Cleanup and convert miscellaneous checks to eassert.
415 * alloc.c (mark_interval): Fix comment, partially rephrase
416 old comment from intervals.h (see below).
417 * intervals.c (find_interval, adjust_intervals_for_insertion)
418 (delete_interval, adjust_intervals_for_deletion)
419 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
420 Convert to eassert.
421 (adjust_intervals_for_insertion, make_new_interval):
422 Remove obsolete and unused code.
423 * intervals.h (struct interval): Remove obsolete comment.
424 * textprotp.c (erase_properties): Remove unused code.
425 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
426 (Fremove_list_of_text_properties): Convert to eassert.
427
9ea10cc3
CY
4282012-07-17 Chong Yidong <cyd@gnu.org>
429
430 * editfns.c (Finsert_char): Doc fix.
431
3900d5de
DA
4322012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
433
434 Fix previous change to make Fmemory_free always accurate.
435 * alloc.c (make_interval): Update total_free_intervals.
436 (make_float): Likewise for total_free_floats.
437 (free_cons, Fcons): Likewise for total_free_conses.
438 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
439 Likewise for total_free_vector_bytes.
440 (Fmake_symbol): Likewise for total_free_symbols.
441 (bytes_free): Remove.
442
7098646f
DA
4432012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
444
445 Simple free memory accounting feature.
446 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
447 (sweep_vectors): Accumulate size of free vectors.
448 (Fgarbage_collect): Setup bytes_free.
449 (Fmemory_free): New function.
450 (syms_of_alloc): Register it.
451
22657b40
DA
4522012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
453
454 Cleanup overlays checking.
455 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
456 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
457 eassert and OVERLAYP.
458 (sort_overlays): Change to use OVERLAYP.
459
ddfc8813
RK
4602012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
461
462 * editfns.c (Finsert_char): Make it interactive, and make the
463 second arg optional. Copy interactive spec and docstring from
464 ucs-insert.
465
7c26cf3c
PE
4662012-07-17 Paul Eggert <eggert@cs.ucla.edu>
467
468 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
469 Unlike the other wrapped functions, fabs has an unspecified
470 effect on errno.
471
5d127af9
JD
4722012-07-16 Jan Djärv <jan.h.d@swipnet.se>
473
474 * nsterm.m (keyDown): Interpret flags without left/right bits
475 as the left key (Bug#11670).
476
6a0dd1d7
DA
4772012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
478
479 Remove empty and useless init functions.
480 * lisp.h (init_character_once, init_fns, init_image)
481 (init_filelock, init_sound): Remove prototype.
482 * character.c (init_character_once): Remove.
483 * filelock.c (init_filelock): Likewise.
484 * fns.c (init_fns): Likewise.
485 * image.c (init_image): Likewise.
486 * sound.c (init_sound): Likewise.
487 * emacs.c (main): Adjust accordingly.
488
7a6136fd
DA
4892012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
490
491 * gtkutil.h: Tiny cleanups.
492 (use_old_gtk_file_dialog): Remove useless declaration.
493 (xg_uses_old_file_dialog): Add suggested const attribute.
494
ce811ad9
EZ
4952012-07-15 Eli Zaretskii <eliz@gnu.org>
496
497 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
498 (bidi_paragraph_init): Use it to limit search forward for a strong
499 directional character in abnormally large paragraphs full of
500 neutral or weak characters. (Bug#11943)
501
c9adfeaa
SF
5022012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
503
504 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
505 the toolbar (Bug#9451).
506 (xg_make_tool_item): Give the widget event box a transparent
507 background.
508
fff62aa9
DA
5092012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
510
511 Cleanup basic allocation variables and functions.
512 * alloc.c (ignore_warnings, init_intervals, init_float)
513 (init_cons, init_symbol, init_marker): Remove.
514 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
515 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
516 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
517 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
518 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
519 (staticidx, init_alloc_once, init_strings, free_ablock):
520 Remove redundant initialization.
521 * fns.c (init_weak_hash_tables): Remove.
522 * lisp.h (init_weak_hash_tables): Remove prototype.
523
9730daca
DA
5242012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
525
526 Use zero_vector where appropriate.
527 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
528 accordingly.
529 * lisp.h (zero_vector): New declaration.
530 * font.c (null_vector): Remove.
531 (syms_of_font): Remove initialization and staticpro.
532 (font_list_entities, font_find_for_lface): Change to use zero_vector.
533 * keymap.c (Faccessible_keymaps): Likewise.
534
2e2d2a13
LL
5352012-07-15 Leo Liu <sdl.web@gmail.com>
536
537 * fringe.c: Fix typo in comments.
538
cd276f6e
LL
5392012-07-14 Leo Liu <sdl.web@gmail.com>
540
541 * fringe.c: Add a new bitmap exclamation-mark.
542
5a1131d9
EZ
5432012-07-14 Eli Zaretskii <eliz@gnu.org>
544
545 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
546
547 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
548 (HAVE_MENUS): Don't define, defined by editing config.in with
549 msdos/sed2v2.inp.
550 (GMALLOC_INHIBIT_VALLOC): Don't define.
551 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
552
22e983b7
JB
5532012-07-14 Juanma Barranquero <lekktu@gmail.com>
554
555 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
556
5b3f250f
GM
5572012-07-14 Glenn Morris <rgm@gnu.org>
558
559 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
560 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
561 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
562
33d63ff4
GM
5632012-07-13 Glenn Morris <rgm@gnu.org>
564
5b633342
GM
565 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
566
33d63ff4
GM
567 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
568 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
569
b55b9f85
JD
5702012-07-13 Jan Djärv <jan.h.d@swipnet.se>
571
0dc8cf50
JD
572 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
573 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
574 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
575 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
576 where appropriate.
577 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
578 as boolean expression.
579 (x_set_window_size): Remove unused variable toolbar.
580 (ns_get_color_default, ns_mod_to_lisp): Remove.
581 (ns_mouse_position): Remove unused variables xchar and ychar.
582 (ns_compute_glyph_string_overhangs): Remove unused variable face.
583 (ns_set_vertical_scroll_bar): Remove unused variable count.
584 (ns_delete_terminal): Remove unused variable i.
585 (ns_term_init): Remove unused variables r, g and b.
586 (mouseDown): Remove unused variable window.
587 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
588 (initFrameFromEmacs): Remove unused variable vbextra.
589 (mouseEntered): Remove unused variables p and dpyinfo.
590 (mouseExited): Remove unused variables p and r.
591 (ns_define_frame_cursor, ns_clear_frame_area)
592 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
593 (menuDown): Assign [sender tag] to variable and cast the variable.
594
595 * nsterm.h (menuDown): Add id as type to argument sender.
596 (ns_display_info_for_name): Add Lisp_Object argument.
597 (ns_term_init): Add Lisp_Object argument.
598 (ns_map_event_to_object): Add void argument.
599 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
600 prototype with arguments and only declare if __OBJC__.
601 (nxatoms_of_nsselect): Add void argument.
602 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
603 (ns_alloc_autorelease_pool): Add void argument.
604 (ns_release_autorelease_pool): Add void* argument.
605 (ns_get_defaults_value): Add const char* argument.
606
607 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
608 (initFromContents): Use SSDATA where appropriate.
609 (ns_update_menubar): Add braces to ambigous if-else.
610 (initWithTitle): Put () around assignment in if statement.
611 (ns_menu_show): Remove unused variables window and keymap.
612 (update_frame_tool_bar): Remove unused variable selected_p.
613 (initWithContentRect): Remove unused variable this_cmd_name.
614
615 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
616 appropriate.
617 (setXBMColor): Remove unused variable len.
618 (setPixmapData): Put () around assignment in loop statement.
619
620 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
621 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
622 where appropriate.
623 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
624 around assignment in loop statement.
625 (nsfont_open): Remove unused variable i.
626 (nsfont_open): Remove unused variable len.
627 (nsfont_draw): Remove unused variable cs.
628
629 * nsfns.m (x_set_icon_name, ns_set_name_internal)
630 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
631 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
632 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
633 (Fns_font_name, Fns_perform_service)
634 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
635 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
636 (ns_set_name): Remove unused variable view.
637 (x_set_menu_bar_lines): Remove unused variable olines.
638 (x_set_tool_bar_lines): Remove unused variable root_window.
639 (Fns_list_colors): Put () around assignment in while statement.
640 (Fns_perform_service): Remove unused variable len.
641 (Fns_display_usable_bounds): Remove unused variable top.
642 (syms_of_nsfns): Remove unused variable i.
643
b55b9f85
JD
644 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
645 memcpy (Bug#11907).
646
ed9265fc 6472012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
648
649 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
650 and free it with DestroyExceptionInfo (Bug#11558).
651
ef099b57
JB
6522012-07-13 Juanma Barranquero <lekktu@gmail.com>
653
654 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
655 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
656 Set here, not in nt/config.nt.
657
ea814a5d
EZ
6582012-07-13 Eli Zaretskii <eliz@gnu.org>
659
660 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
661 cursor overflow into the last glyph on display line when the right
662 fringe is off. (Bug#11832)
663
1a952767
PE
6642012-07-13 Paul Eggert <eggert@cs.ucla.edu>
665
666 * xdisp.c (produce_special_glyphs): Now static.
667 * dispextern.h (produce_special_glyphs): Remove decl.
668
983188fd
GM
6692012-07-13 Glenn Morris <rgm@gnu.org>
670
32fb4bb6
GM
671 * s/bsd-common, s/cygwin.h: Remove empty files.
672 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
673
983188fd
GM
674 * s/usg5-4-common.h (USG, USG5):
675 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
676 * s/sol2-6.h (SOLARIS2):
677 * s/irix6-5.h (IRIX6_5):
678 * s/hpux10-20.h (USG, USG5, HPUX):
679 * s/gnu-linux.h (USG, GNU_LINUX):
680 * s/freebsd.h (BSD_SYSTEM):
681 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
682 * s/cygwin.h (CYGWIN):
683 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
684 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
685
d1e68667 6862012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
687
688 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 689
6de0e799
GM
6902012-07-13 Glenn Morris <rgm@gnu.org>
691
739ae010
GM
692 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
693
dbee5793
GM
694 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
695
6de0e799
GM
696 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
697 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
698
b82da769
GM
6992012-07-12 Glenn Morris <rgm@gnu.org>
700
4fae5a7a 701 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
702
703 * process.c (init_process_emacs): Rename from init_process.
704 The old name is also the name of a Mach system call.
705 * lisp.h, emacs.c: Update for this name change.
706 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
707 longer needed.
708
5a979817
EZ
7092012-07-12 Eli Zaretskii <eliz@gnu.org>
710
711 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
712 memmove call that removes glyphs covered by the left truncation
713 glyph. Improve commentary.
714 (display_line): Fix display of continuation glyphs on GUI frames
715 when the right fringe is turned off and variable-size fonts are
716 used in the window. Move the code that appends a stretch glyph to
717 produce_special_glyphs, so that it could be used for truncation
718 and continuation glyphs alike.
719 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
720 glyph of a suitably computed width, to align the special glyphs at
721 the window margin. Code moved from display_line. (Bug#11832)
722
3e91a053
GM
7232012-07-12 Glenn Morris <rgm@gnu.org>
724
ba9e4b84
GM
725 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
726
727 * s/gnu-linux.h, s/hpux10-20.h:
728 Do not unconditionally define HAVE_XRMSETDATABASE.
729
3e91a053
GM
730 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
731
b300b1f4
PE
7322012-07-12 Paul Eggert <eggert@cs.ucla.edu>
733
734 Fix typos that broke OS X build.
735 Reported by Randal L. Schwartz in
736 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
737 * nsterm.m (ns_timeout): Add missing local decl.
738 (ns_get_color): snprintf -> sprintf, to fix typo.
739
6e777848
GM
7402012-07-12 Glenn Morris <rgm@gnu.org>
741
3f922c37
GM
742 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
743 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
744 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
745 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
746
0ab7b23a
GM
747 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
748 Move PTY_OPEN to configure.
749
6e777848
GM
750 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
751 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
752 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
753
4a7edc24
DA
7542012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
755
756 Use empty_unibyte_string where applicable.
757 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
758 * lread.c (read1): Likewise.
759 * xsettings.c (syms_of_xsettings): Likewise.
760
308aab79
GM
7612012-07-12 Glenn Morris <rgm@gnu.org>
762
42bd1719
GM
763 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
764 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
765 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
766 * s/hpux10-20.h (RUN_TIME_REMAP):
767 * s/bsd-common.h (TABDLY): Move to configure.
768
769 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
770
771 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
772
ea0bbd17 773 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 774 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
775
776 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 777
308aab79
GM
778 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
779 * s/template.h: Move NARROWPROTO to configure.
780
ee1cf5cf
GM
7812012-07-11 Glenn Morris <rgm@gnu.org>
782
30fe9bf4
GM
783 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
784 unused since 2011-01-17 change to systty.h.
785
ee1cf5cf
GM
786 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
787 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
788 Move HAVE_PTYS and HAVE_SOCKETS to configure.
789
63e47e07
PE
7902012-07-11 Paul Eggert <eggert@cs.ucla.edu>
791
792 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
793
c43fb4c3
GM
7942012-07-11 Glenn Morris <rgm@gnu.org>
795
796 * s/darwin.h, s/gnu-linux.h, s/template.h:
797 Move INTERRUPT_INPUT to configure.
798
e8df9267
DA
7992012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
800
801 Minor adjustments to interning code.
802 * lisp.h (intern, intern_c_string): Redefine as static inline
803 wrappers for intern_1 and intern_c_string_1, respectively.
804 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
805 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
806 Vobarray checking.
e8df9267
DA
807 * font.c (font_intern_prop): Likewise. Adjust comment.
808 * w32font.c (intern_font_name): Likewise.
809
34348bd4
AS
8102012-07-11 Andreas Schwab <schwab@linux-m68k.org>
811
d96a1e0c
AS
812 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
813
34348bd4
AS
814 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
815 of Fcar/Fcdr if possible.
816 * font.c (check_otf_features): Likewise.
817 * fontset.c (Fnew_fontset): Likewise.
818 * gnutls.c (Fgnutls_boot): Likewise.
819 * minibuf.c (read_minibuf): Likewise.
820 * msdos.c (IT_set_frame_parameters): Likewise.
821 * xmenu.c (Fx_popup_dialog): Likewise.
822 * w32menu.c (Fx_popup_dialog): Likewise.
823
c8add24e
GM
8242012-07-11 Glenn Morris <rgm@gnu.org>
825
4b575b3c
GM
826 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
827 since nothing has defined it on these platforms.
828
09f4e3b0
GM
829 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
830 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
831
172bedef
GM
832 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
833 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
834 Move CLASH_DETECTION to configure.
835
249685df
GM
836 * s/gnu.h: Remove file, which is now empty.
837
c8add24e
GM
838 * s/gnu.h, s/gnu-linux.h:
839 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
840
b41253a3
JW
8412012-07-11 John Wiegley <johnw@newartisans.com>
842
843 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
844 function attribute, so we only use it if it exists in the
845 compiler.
846
d923b542
DA
8472012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
848
849 Avoid call to strlen in fast_c_string_match_ignore_case.
850 * search.c (fast_c_string_match_ignore_case): Change to use
851 length argument. Adjust users accordingly.
852 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
853
5ebbef1d
PE
8542012-07-11 Paul Eggert <eggert@cs.ucla.edu>
855
bb352260
PE
856 Assume mkdir, rmdir.
857 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
858 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
859
57054ddd
PE
860 Assume rename.
861 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
862
b747d3f7
PE
863 Assume perror.
864 * s/hpux10-20.h (HAVE_PERROR): Remove.
865 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
866 Remove dummy definition, as this problem was obsolete long ago.
867
5ebbef1d
PE
868 Assume strerror.
869 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
870
984e7f30
DA
8712012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
872
873 Avoid calls to strlen in font processing functions.
874 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 875 (font_open_by_name): Change to use length argument. Adjust
984e7f30 876 users accordingly.
d923b542
DA
877 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
878 Adjust prototypes.
879 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
880 Change to return ptrdiff_t.
984e7f30
DA
881 (xfont_list_pattern, xfont_match): Use length returned by
882 xfont_decode_coding_xlfd.
883 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
884
20e94fdd
GM
8852012-07-11 Glenn Morris <rgm@gnu.org>
886
9d596af3
GM
887 * s/darwin.h, s/freebsd.h, s/netbsd.h:
888 Move DONT_REOPEN_PTY to configure.
889
20e94fdd
GM
890 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
891 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
892
e99a530f
PE
8932012-07-10 Paul Eggert <eggert@cs.ucla.edu>
894
22ffb973
PE
895 Remove "#define unix" that is no longer needed (Bug#11905).
896 * s/aix4-2.h (unix): Remove; no longer needed.
897
e9a9ae03
PE
898 EMACS_TIME simplification (Bug#11875).
899 This replaces macros (which typically do not work in GDB)
900 with functions, typedefs and enums, making the code easier to debug.
901 The functional style also makes code easier to read and maintain.
902 * systime.h: Include <sys/time.h> on all hosts, not just if
903 WINDOWSNT, since 'struct timeval' is needed in general.
904 (EMACS_TIME): Now a typedef, not a macro.
905 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
906 not macros.
907 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
908 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
909 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
910 (EMACS_TIME_LE): Now functions, not macros.
911 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
912 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
913 which are not functions. All uses rewritten to use:
914 (make_emacs_time): New function.
915 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
916 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
917 not functions. All uses rewritten to use the following, respectively:
918 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
919 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 920 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
921 * fileio.c (Fcopy_file):
922 * xterm.c (XTflash): Get the current time closer to when it's used.
923 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
924
ffacb126
PE
925 * bytecode.c (targets): Suppress -Woverride-init warnings.
926
e99a530f
PE
927 Simplify by avoiding confusing use of strncpy etc.
928 * doc.c (Fsnarf_documentation):
929 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
930 * frame.c (Fmake_terminal_frame):
931 * gtkutil.c (get_utf8_string):
932 * lread.c (openp):
933 * nsmenu.m (ns_update_menubar):
934 * regex.c (regerror):
935 Prefer memcpy to strncpy and strncat when either will do.
936 * fileio.c (Fsubstitute_in_file_name):
937 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
938 (menu_separator_name_p):
939 * nsmenu.m (ns_update_menubar):
940 Prefer memcmp to strncmp when either will do.
941 * nsterm.m: Include <ftoastr.h>.
942 (ns_get_color):
943 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
944 Prefer snprintf to strncpy.
945 * nsterm.m (ns_term_init):
946 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
947 * nsterm.m (ns_term_init):
948 Avoid the need for strncpy, by using build_string or
949 make_unibyte_string directly. Use dtoastr, not snprintf.
950 * process.c (Fmake_network_process): Diagnose service names that
951 are too long, rather than silently truncating them or creating
952 non-null-terminated names.
953 (Fnetwork_interface_info): Likewise, for interface names.
954 * sysdep.c (system_process_attributes) [GNU_LINUX]:
955 Prefer sprintf to strncat.
956 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
957 Prefer vsnprintf to vsprintf + strncpy.
958
c59592b3
GM
9592012-07-10 Glenn Morris <rgm@gnu.org>
960
961 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
962 Clarify fallback case.
963
7d7bbefd
DA
9642012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
965
966 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
967 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
968 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 969 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
970 where argument type is known to be a Lisp_Cons.
971
3a4c8000
TT
9722012-07-10 Tom Tromey <tromey@redhat.com>
973
974 * bytecode.c (BYTE_CODE_THREADED): New macro.
975 (BYTE_CODES): New macro. Replaces all old byte-code defines.
976 (enum byte_code_op): New type.
977 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
978 (exec_byte_code): Use them. Use token threading when applicable.
979
2a0213a6
DA
9802012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
981
982 Optimize pure C strings initialization.
983 * lisp.h (make_pure_string): Fix prototype.
984 (build_pure_c_string): New function, defined as static inline. This
985 provides a better opportunity to optimize away calls to strlen when
986 the function is called with compile-time constant argument.
987 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
988 argument, adjust users accordingly. Use build_pure_c_string where
989 appropriate.
990 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
991 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
992 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
993
cb1caeaf
DA
9942012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
995
996 Avoid calls to strlen in miscellaneous functions.
997 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
998 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
999 * lread.c (openp): Likewise.
1000
c293e30c
DA
10012012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1002
1003 Avoid calls to strlen in path processing functions.
1004 * fileio.c (file_name_as_directory): Add comment. Change to add
1005 srclen argument and return the length of result. Adjust users
1006 accordingly.
1007 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1008 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1009 users accordingly.
1010 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1011
9e059e3f
GM
10122012-07-10 Glenn Morris <rgm@gnu.org>
1013
d02eb359
GM
1014 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1015 Move PENDING_OUTPUT_COUNT definition to configure.
1016
882cf227
GM
1017 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1018 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1019 * s/gnu.h (DATA_START): Move definitions to configure.
1020
af6e839f
GM
1021 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1022 We include usg5-4-common.h, which defines them both.
1023
40289a12
GM
1024 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1025 O_RDONLY already includes it).
1026
9e059e3f
GM
1027 Stop ns builds setting the EMACSLOADPATH environment variable.
1028 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1029 Now it does not set EMACSLOADPATH, just returns the load-path string.
1030 * nsterm.h: Update accordingly.
1031 * lread.c [HAVE_NS]: Include nsterm.h.
1032 (init_lread) [HAVE_NS]: Use ns_load_path.
1033 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1034
7c4e8ec0
GM
10352012-07-09 Glenn Morris <rgm@gnu.org>
1036
d4f600ff
GM
1037 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1038 since the included bsd-common.h does so.
1039
cbb31951
GM
1040 Stop ns builds setting the EMACSPATH environment variable.
1041 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1042 (ns_init_paths): Do not set EMACSPATH.
1043 * nsterm.h (ns_exec_path): Add it.
1044 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1045 Use ns_exec_path.
1046
7c4e8ec0
GM
1047 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1048
26bccfae
PE
10492012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1050
a0bee46f
PE
1051 * process.c (wait_reading_process_output): 'waitchannels' was unset
1052 when read_kbd || !NILP (wait_for_cell); fix this.
1053
5994c183
PE
1054 Add GCC-style 'const' attribute to functions that can use it.
1055 * character.h (char_resolve_modifier_mask):
1056 * keyboard.h (make_ctrl_char):
1057 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1058 (init_character_once, next_almost_prime, init_fns, init_image)
1059 (flush_pending_output, init_sound):
1060 * mem-limits.h (start_of_data):
1061 * menu.h (finish_menu_items):
1062 Add ATTRIBUTE_CONST.
1063 * emacs.c (DEFINE_DUMMY_FUNCTION):
1064 Declare the dummy function with ATTRIBUTE_CONST.
1065 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1066 Add decls with ATTRIBUTE_CONST.
1067
26bccfae
PE
1068 Minor improvements to make_formatted_string.
1069 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1070 where int is good enough, as vsprintf returns an int.
1071 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1072
a8290ec3
DA
10732012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1074
1075 Use make_formatted_string to avoid double length calculation.
1076 * lisp.h (make_formatted_string): New prototype.
1077 * alloc.c (make_formatted_string): New function.
1078 * buffer.c (Fgenerate_new_buffer_name): Use it.
1079 * dbus.c (syms_of_dbusbind): Likewise.
1080 * editfns.c (Fcurrent_time_zone): Likewise.
1081 * filelock.c (get_boot_time): Likewise.
1082 * frame.c (make_terminal_frame, set_term_frame_name)
1083 (x_report_frame_params): Likewise.
1084 * image.c (gs_load): Likewise.
1085 * minibuf.c (get_minibuffer): Likewise.
1086 * msdos.c (dos_set_window_size): Likewise.
1087 * process.c (make_process): Likewise.
1088 * xdisp.c (ensure_echo_area_buffers): Likewise.
1089 * xsettings.c (apply_xft_settings): Likewise.
1090
d01ba2f1
GM
10912012-07-09 Glenn Morris <rgm@gnu.org>
1092
1093 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1094 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1095 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1096 * nsterm.h (ns_etc_directory): Add it.
1097 * callproc.c [HAVE_NS]: Include nsterm.h.
1098 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1099
f1f924b6
DA
11002012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1101
1102 Move marker debugging code under MARKER_DEBUG.
1103 * marker.c (MARKER_DEBUG): Move marker debugging code under
1104 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1105 for bootstrap with --enable-checking (~3x slowdown reported
1106 by Juanma Barranquero <lekktu@gmail.com>).
1107 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1108
ab531b66
PE
11092012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1110
1111 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1112 See <http://bugs.gnu.org/11825#29>.
1113
c4b3bc8a
EZ
11142012-07-08 Eli Zaretskii <eliz@gnu.org>
1115
1116 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1117 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1118 (display_line): Add commentary about displaying truncation glyphs
1119 on GUI frames.
1120 (produce_special_glyphs): Move here from term.c.
1121
1122 * term.c (produce_special_glyphs): Move to xdisp.c.
1123
1124 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1125 section.
c4b3bc8a 1126
b676b881
AS
11272012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1128
f17c5273
AS
1129 * xdisp.c (display_line): Avoid warning about implicit declaration
1130 of FRAME_FONT.
1131
298819b9
AS
1132 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1133
b676b881
AS
1134 * lisp.h: Remove empty conditional.
1135
6045c4fd
PE
11362012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1137
b3350bf9
PE
1138 * lread.c (load_path_check): Now static.
1139
6045c4fd
PE
1140 Fix some minor --with-ns problems found by static checking.
1141 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1142 (x_set_font) [!HAVE_X_WINDOWS]:
1143 * image.c (xpm_load_image) [HAVE_NS]:
1144 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1145 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1146 Remove unused local.
1147 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1148 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1149 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1150 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1151 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1152 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1153 Fix pointer signedness problem.
1154 * xfaces.c (FRAME_X_FONT_TABLE):
1155 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1156
929e7845
GM
11572012-07-07 Glenn Morris <rgm@gnu.org>
1158
1159 * lread.c (load_path_check): New function, split from init_lread.
1160 (init_lread): Reorganize. Motivation:
1161 If EMACSLOADPATH is set, check/warn about that rather than the
1162 defaults, which we are not going to use. Hence we can remove
1163 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1164 Don't warn if site-lisp directories are missing.
1165 If not installed, start from a blank load-path, since
1166 PATH_LOADSEARCH refers to the eventual installation directories.
1167
58dd0aa4
EZ
11682012-07-07 Eli Zaretskii <eliz@gnu.org>
1169
1170 Support truncation and continuation glyphs on GUI frames, when
1171 fringes are disabled. (Bug#11832)
1172 * xdisp.c (init_iterator): Get dimensions of truncation and
1173 continuation glyphs even if on GUI frames. Adjust
1174 it->last_visible_x on GUI frames when the left or right fringes,
1175 or both, are absent.
1176 (start_display, move_it_in_display_line_to): Handle the case of a
1177 GUI frame without a fringe to display continuation or truncation
1178 glyphs.
1179 (insert_left_trunc_glyphs): Support GUI frames: make sure
1180 truncation glyphs overwrite enough glyphs from the current line to
1181 have sufficient space in pixels.
1182 (display_line): Support truncation and continuation glyphs on GUI
1183 frames. If some spare pixels are left on the line after inserting
1184 the truncation glyphs, fill that space with a stretch glyph of a
1185 suitably computed width.
1186
1187 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1188 produce_glyphs, to support GUI sessions.
1189
31571fd7
PE
11902012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1191
5a16b9bc
PE
1192 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1193
f3047c75
PE
1194 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1195
31571fd7
PE
1196 Do not require float-time's arg to fit in time_t (Bug#11825).
1197 This works better on hosts where time_t is unsigned, and where
1198 float-time is applied to the (negative) difference between two times.
1199 * editfns.c (decode_time_components): Last arg is now double *,
1200 not int *, and means to store all the result as a double, without
1201 worrying about whether the seconds part fits in time_t.
1202 All callers changed.
1203 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1204 All callers changed.
1205 (Ffloat_time): Do not fail merely because the specified time falls
1206 outside of time_t range.
1207
4516fbef
GM
12082012-07-07 Glenn Morris <rgm@gnu.org>
1209
1210 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1211 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1212 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1213
07adc2c6
JB
12142012-07-07 Juanma Barranquero <lekktu@gmail.com>
1215
1216 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1217 Update dependencies.
1218
1219 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1220
fd573f31
PE
12212012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1222
fee5959d
PE
1223 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1224 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1225 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1226 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1227 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1228 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1229
fd573f31
PE
1230 * xfont.c (compare_font_names): Redo to omit the need for casts.
1231
ddadbc0e
AS
12322012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1233
fca8d6b6
AS
1234 * xfns.c (Fx_change_window_property): Doc fix.
1235 * w32fns.c (Fx_change_window_property): Doc fix.
1236
ddadbc0e
AS
1237 * w32fns.c (Fx_window_property): Accept the same arguments as the
1238 X Windows version. Doc fix.
1239 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1240
ed9265fc 12412012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1242 Eli Zaretskii <eliz@gnu.org>
1243
1244 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1245 Windows-specific code from nt/config.nt moved here.
1246 Obsolete settings removed.
1247
216ee680
PE
12482012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1249
1250 * process.c: Avoid unnecessary calls to gettime.
1251 (wait_reading_process_output): Don't get the time of day
1252 when gobbling data immediately and not waiting, as there's no need
1253 for it in that case. This removes a FIXME.
1254
bdd091e4
JD
12552012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1256
1257 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1258 is defined (Bug#11768).
1259
9d44f8ce
DA
12602012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1261
1262 Fix marker debugging code.
1263 * marker.c (byte_char_debug_check): Do not perform the check
1264 if buffer is not multibyte.
090bd7cb
JB
1265 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1266 Call byte_char_debug_check with correct arguments.
9d44f8ce 1267
90fc4786
DA
12682012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1269
1270 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1271 * marker.c (byte_char_debug_check, count_markers):
1272 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1273 (byte_debug_flag): Remove.
1274 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1275 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1276
7b7ae965
DA
12772012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1278
4e57b342
DA
1279 Avoid code repetition in marker-related functions.
1280 * marker.c (attach_marker): New function.
1281 (Fset_marker, set_marker_restricted, set_marker_both)
1282 (set_marker_restricted_both): Use it.
1283 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1284 Consistently rename charno to charpos.
1285 (marker_position): Add eassert.
1286 (marker_byte_position): Convert to eassert.
1287
12882012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1289
1290 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1291 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1292 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1293
657924ff
DA
12942012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1295
1296 Introduce fast path for the widely used marker operation.
1297 * alloc.c (build_marker): New function.
1298 * lisp.h (build_marker): New prototype.
1299 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1300 * composite.c (autocmp_chars): Likewise.
1301 * editfns.c (buildmark): Remove.
1302 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1303 (save_restriction_save): Use build_marker.
1304 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1305 * window.c (save_window_save): Likewise.
1306
041a49a6
DA
13072012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1308
1309 Do not use Fdelete_overlay in delete_all_overlays
1310 to avoid redundant calls to unchain_overlay.
1311 * buffer.c (drop_overlay): New function.
1312 (delete_all_overlays, Fdelete_overlay): Use it.
1313 * minibuf.c (get_minibuffer): Fix comment.
1314
7dca65a4
PE
13152012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1316
1317 Port to OpenBSD 5.1 amd64.
1318 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1319 This is needed for OpenBSD, and should be harmless on all BSD systems.
1320 Also, include <sys/sysctl.h>, as it should be available on all
1321 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1322 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1323 use p_pid member, not kp_proc.pid.
1324
8eb876e2
GM
13252012-07-06 Glenn Morris <rgm@gnu.org>
1326
1327 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1328
38182d90
PE
13292012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1330
1331 More xmalloc and related cleanup.
1332 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1333 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1334 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1335 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1336 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1337 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1338 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1339 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1340 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1341 * xterm.c:
1342 Omit needless casts involving void * pointers and allocation.
1343 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1344 as the former is more robust if P's type is changed.
1345 Prefer xzalloc to xmalloc + memset 0.
1346 Simplify malloc-or-realloc to realloc.
1347 Don't worry about xmalloc returning a null pointer.
1348 Prefer xstrdup to xmalloc + strcpy.
1349 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1350 growing it.
1351 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1352 alloca of a constant.
1353
6dd5a677
EZ
13542012-07-05 Eli Zaretskii <eliz@gnu.org>
1355
1356 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1357 hscroll is larger than the line width. Fixes long and futile
1358 looping inside extend_face_to_end_of_line (on a TTY) producing
1359 glyphs that are not needed and thrown away.
1360
6b312f0f
DA
13612012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1362
1363 * marker.c (set_marker_restricted_both): Simplify by using
1364 clip_to_bounds.
1365
f520ef9b
PE
13662012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1367
1368 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1369
383b7c95
JD
13702012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1371
1372 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1373 not defined (Bug#11768).
1374 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1375 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1376 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1377 followed by gtk_box_set_homogeneous (Bug#11768).
1378 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1379 (update_theme_scrollbar_width, xg_create_scroll_bar):
1380 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1381 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1382 (is_box_type): New function (Bug#11768).
1383 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1384 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1385 with default display (Bug#11768).
1386
d6e7bf45
EZ
13872012-07-05 Eli Zaretskii <eliz@gnu.org>
1388
1389 * xdisp.c (window_hscroll_limited): New function.
1390 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1391 coordinates when window's hscroll is set to insanely large
1392 values. (Bug#11857)
1393
431391ec
JB
13942012-07-05 Juanma Barranquero <lekktu@gmail.com>
1395
1396 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1397 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1398
23f86fce
DA
13992012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1400
1401 Cleanup xmalloc.
1402 * lisp.h (xzalloc): New prototype. Omit needless casts.
1403 * alloc.c (xzalloc): New function. Omit needless casts.
1404 * charset.c: Omit needless casts. Convert all calls to
1405 xmalloc with following memset to xzalloc.
1406 * dispnew.c: Likewise.
1407 * fringe.c: Likewise.
1408 * image.c: Likewise.
1409 * sound.c: Likewise.
1410 * term.c: Likewise.
1411 * w32fns.c: Likewise.
1412 * w32font.c: Likewise.
1413 * w32term.c: Likewise.
1414 * xfaces.c: Likewise.
1415 * xfns.c: Likewise.
1416 * xterm.c: Likewise.
1417 * atimer.c: Omit needless casts.
1418 * buffer.c: Likewise.
1419 * callproc.c: Likewise.
1420 * ccl.c: Likewise.
1421 * coding.c: Likewise.
1422 * composite.c: Likewise.
1423 * doc.c: Likewise.
1424 * doprnt.c: Likewise.
1425 * editfns.c: Likewise.
1426 * emacs.c: Likewise.
1427 * eval.c: Likewise.
1428 * filelock.c: Likewise.
1429 * fns.c: Likewise.
1430 * gtkutil.c: Likewise.
1431 * keyboard.c: Likewise.
1432 * lisp.h: Likewise.
1433 * lread.c: Likewise.
1434 * minibuf.c: Likewise.
1435 * msdos.c: Likewise.
1436 * print.c: Likewise.
1437 * process.c: Likewise.
1438 * region-cache.c: Likewise.
1439 * search.c: Likewise.
1440 * sysdep.c: Likewise.
1441 * termcap.c: Likewise.
1442 * terminal.c: Likewise.
1443 * tparam.c: Likewise.
1444 * w16select.c: Likewise.
1445 * w32.c: Likewise.
1446 * w32reg.c: Likewise.
1447 * w32select.c: Likewise.
1448 * w32uniscribe.c: Likewise.
1449 * widget.c: Likewise.
1450 * xdisp.c: Likewise.
1451 * xmenu.c: Likewise.
1452 * xrdb.c: Likewise.
1453 * xselect.c: Likewise.
1454
0497dc44
PE
14552012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1456
1457 * fileio.c (time_error_value): Check the right error number.
1458 Problem reported by Troels Nielsen in
1459 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1460
356e7178
PE
14612012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1462
4e71fd89
PE
1463 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1464 This should be fixed in a better way; see Eli Zaretskii in
1465 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1466 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1467
f0941253
PE
1468 * fileio.c (time_error_value): Rename from special_mtime.
1469 The old name's problems were noted by Eli Zaretskii in
1470 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1471
065c9eb4
PE
1472 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1473 This variable's comment says Emacs needs at least one GDB-visible
1474 symbol of type enum pvec_type, to work around GDB problems.
1475 The symbol's value doesn't matter.
1476
356e7178
PE
1477 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1478 that causes compilation to fail on pre-C99 compilers.
1479
ed9265fc 14802012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1481
1482 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1483 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1484
3884d954
DA
14852012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1486
d209e2fb 1487 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1488 headers for buffer_defaults and buffer_local_symbols.
1489 Reported by Juanma Barranquero <lekktu@gmail.com>.
1490
ee28be33
SM
14912012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1492
1493 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1494 * lisp.h (enum pvec_type): Use fewer bits.
1495 (PSEUDOVECTOR_SIZE_BITS): New constant.
1496 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1497 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1498 change in pvec_type.
1499 (PSEUDOVECTOR_TYPEP): New macro.
1500 (TYPED_PSEUDOVECTORP): Use it.
1501 * fns.c (internal_equal): Adapt code to extract pvectype.
1502 * emacs.c (gdb_pvec_type): Update type.
1503 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1504 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1505 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1506 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1507 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1508 abusing vector->header.next.nbytes.
1509 (live_vector_p): Use PVEC_TYPE.
1510 (mark_object): Adapt code to extract pvectype. Use switch.
1511
c7f2cd7f
PE
15122012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1513
1514 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1515 Tighten new eassert a bit.
1516
8ce70ed2
DA
15172012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1518
1519 Fix compilation with --enable-gcc-warnings and -O1
1520 optimization level.
1521 * doprnt.c (doprnt): Change type of tem to int, initialize
1522 to avoid compiler warning. Add eassert.
1523 * search.c (simple_search): Initialize match_byte to avoid
1524 compiler warning. Add eassert.
1525
dea7f1e5
PE
15262012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1527
24a212eb
PE
1528 Avoid weird behavior with large horizontal scrolls.
1529 Without this change, for example, large hscroll values would
1530 mess up Emacs's display on Fedora 15 x86, presumably due to
1531 overflows in int calculations in the display code.
1532 Also, if buffers had long lines, Emacs would freeze.
1533 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1534 (set_window_hscroll): New function, containing the old guts of
1535 Fset_window_hscroll. Return the clipped value.
1536 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1537 This avoids the need to check against PTRDIFF_MAX.
1538
dea7f1e5
PE
1539 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1540
76046526
DA
15412012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1542
1543 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1544
39adff0d
PE
15452012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1546
63807d47
PE
1547 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1548 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1549 since GCC 4.4.6 issues a bogus warning for them.
1550
39adff0d
PE
1551 Fix bugs in file timestamp newness comparisons.
1552 * fileio.c (Ffile_newer_than_file_p):
1553 * lread.c (Fload): Use full timestamp resolution of files,
1554 not just the 1-second resolution, so that files that are only
1555 slightly newer still count as newer.
1556 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1557 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1558
dbeed9a6
PE
15592012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1560
1561 * fileio.c: Improve handling of file time marker. (Bug#11852)
1562 (special_mtime): New function.
1563 (Finsert_file_contents, Fverify_visited_file_modtime):
1564 Use it to set special mtime values consistently.
1565
636334d6
AS
15662012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1567
1568 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1569 marker for non-existing file. (Bug#11852)
1570
e2017fe2
GM
15712012-07-03 Glenn Morris <rgm@gnu.org>
1572
1573 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1574 and did not make it into globals.h).
1575
404dbd37
TT
15762012-07-03 Tom Tromey <tromey@redhat.com>
1577
1578 * window.c (Fset_window_margins, Fset_window_fringes)
1579 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1580 * textprop.c (Fprevious_property_change): No longer static.
1581 * syntax.c (Fsyntax_table_p): No longer static.
1582 * process.c (Fget_process, Fprocess_datagram_address): No longer
1583 static.
1584 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1585 * keyboard.c (Fcommand_execute): No longer static.
1586 Remove EXFUN.
1587 * insdel.c (Fcombine_after_change_execute): No longer static.
1588 * image.c (Finit_image_library): No longer static.
1589 * fileio.c (Fmake_symbolic_link): No longer static.
1590 * eval.c (Ffetch_bytecode): No longer static.
1591 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1592 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1593 No longer static.
404dbd37
TT
1594 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1595 static.
1596 * dired.c (Ffile_attributes): No longer static.
1597 * composite.c (Fcomposition_get_gstring): No longer static.
1598 * callproc.c (Fgetenv_internal): No longer static.
1599
1600 * ccl.h: Remove EXFUNs.
1601 * buffer.h: Remove EXFUNs.
1602 * dispextern.h: Remove EXFUNs.
1603 * intervals.h: Remove EXFUNs.
1604 * fontset.h: Remove EXFUN.
1605 * font.h: Remove EXFUNs.
1606 * dosfns.c (system_process_attributes): Remove EXFUN.
1607 * keymap.h: Remove EXFUNs.
1608 * lisp.h: Remove EXFUNs.
1609 * w32term.h: Remove EXFUNs.
1610 * window.h: Remove EXFUNs.
1611 * xsettings.h: Remove EXFUN.
1612 * xterm.h: Remove EXFUN.
1613
8e4fd1e1
GM
16142012-07-03 Glenn Morris <rgm@gnu.org>
1615
1616 * lisp.h (Frandom): Make it visible to C.
1617 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1618 buffer for invisible buffers. (Bug#1229)
1619
ca95b3eb
DA
16202012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1621
1622 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1623 values which aren't power of 2.
1624 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1625 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1626 accordingly.
1627
7555c33f
SM
16282012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1629
1630 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1631
1632 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1633
d12e8f5a
DA
16342012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1635
1636 * alloc.c (allocate_vector_block): Remove redundant
1637 calls to mallopt if DOUG_LEA_MALLOC is defined.
1638 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1639 avoid calls to mallopt if zero_vector is returned.
1640
296094c3
DA
16412012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1642
1643 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1644 is enabled, avoid dereferencing NULL current_sblock if
1645 running undumped.
1646
36429c89
DA
16472012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1648
1649 Cleanup basic buffer management.
1650 * buffer.h (struct buffer): Change layout to use generic vector
1651 marking code. Fix some comments. Change type of 'clip_changed'
1652 to bitfield. Remove unused #ifndef old.
1653 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1654 (GET_OVERLAYS_AT): Fix indentation.
1655 (for_each_per_buffer_object_at): New macro.
1656 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1657 (Fbuffer_local_variables): Use it.
1658 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1659 * alloc.c (allocate_buffer): Adjust to match new layout of
1660 struct buffer. Fix comment.
1661 (mark_overlay): New function.
1662 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1663 Lisp area of struct buffer.
1664 (mark_object): Use it. Adjust marking of misc objects
1665 and related comments.
1666
3b3e4cac
PE
16672012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1668
1669 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1670 wrapper that is not needed because the wrapped code is a no-op (zero
1671 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1672 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1673
cf5c0175
DA
16742012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1675
1676 * alloc.c (mark_buffer): Simplify. Remove prototype.
1677 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1678 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1679 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1680 redundant calls to mark_vectorlike for bool vectors.
1681
ca26824c
GM
16822012-06-30 Glenn Morris <rgm@gnu.org>
1683
2e4c5312
GM
1684 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1685
ca26824c
GM
1686 * epaths.in (PATH_SITELOADSEARCH): New.
1687 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1688 This is rather than relying on --enable-locallisppath elements
1689 having "site-lisp" in their names. (Bug#10208#25, 11658)
1690
0d23c240
EZ
16912012-06-30 Eli Zaretskii <eliz@gnu.org>
1692
c9240d7a
EZ
1693 * w32proc.c (sys_select): Accept and ignore one more argument.
1694
1695 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1696
0d23c240 1697 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1698 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1699
1700 * sysdep.c: Don't include dos.h and dosfns.h.
1701
1702 * process.c (sys_select):
1703 * msdos.c (sys_select): Accept one more argument and ignore it.
1704
1705 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1706 adapt data types and code to that.
1707
1708 * dosfns.c:
1709 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1710 which clashes with the gnulib function of the same name.
1711
af5a5a98
AS
17122012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1713
c5e4379c
AS
1714 * font.c (font_style_to_value, font_style_symbolic)
1715 (font_prop_validate_style): Add type checks for values in
1716 font_style_table.
1717
af5a5a98
AS
1718 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1719 argument.
1720 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1721 uses.
1722
8d38f461
EZ
17232012-06-29 Eli Zaretskii <eliz@gnu.org>
1724
2e5a6631
EZ
1725 * xdisp.c (try_window_id): Undo last change.
1726
8d38f461
EZ
1727 * w32.c (getwd): Adjust commentary about startup_dir.
1728 (init_environment): Always call sys_access, even in non-MSVC
1729 builds. Don't chdir to the directory of the Emacs executable.
1730 This undoes code from 1997 which was justified by the need to
1731 "avoid conflicts when removing and renaming directories". But its
1732 downside was that every relative file name was being interpreted
1733 relative to the directory of the Emacs executable, which can never
1734 be TRT. In particular, it broke sys_access when called with
1735 relative file names.
1736 (sys_access): Map GetLastError to errno.
1737
2af3565e
DA
17382012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1739
1740 * window.h (struct window): Change type of 'fringes_outside_margins'
1741 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1742 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1743 Adjust comment.
1744 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1745 to ptrdiff_t.
1746
c8d3a25c 17472012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1748
c8d3a25c
GM
1749 * gnutls.c (emacs_gnutls_handshake):
1750 Add QUIT to make the loop interruptible.
57570cd3 1751
c8d3a25c 17522012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1753
c8d3a25c
GM
1754 * charset.c (init_charset): Make lack of etc/charsets fatal.
1755
3e984ee8
DA
17562012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1757
1758 * editfns.c (region_limit): Fix type mismatch.
1759
ef884f23
DA
17602012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1761
1762 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1763 undefined. Convert from xassert to eassert.
1764 * nsmenu.m: Convert from xassert to eassert.
1765 * nsterm.m: Likewise.
1766
7d7e0027
SM
17672012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1768
1769 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1770
aa754e6a
PE
17712012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 Avoid integer overflow on scroll-left and scroll-right.
1774 * window.c (HSCROLL_MAX): New macro.
1775 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1776 overflow when requested scroll falls outside ptrdiff_t range.
1777
80b00b08
DA
17782012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1779
1780 * window.h (struct window): Change type of 'hscroll',
1781 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1782 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1783 Adjust users accordingly.
1784 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1785 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1786 from EMACS_INT to ptrdiff_t.
1787 (make_window): Omit redundant initialization.
1788
62b2bcf6
JB
17892012-06-28 Juanma Barranquero <lekktu@gmail.com>
1790
1791 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1792
45942c7d
DA
17932012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1794
1795 * window.h (struct window): Change type of 'use_time' and
1796 'sequence_number' from Lisp_Object to int.
1797 * frame.c (make_frame): Adjust users accordingly.
1798 * print.c (print_object): Likewise.
1799 * window.c (select_window, Fwindow_use_time, make_parent_window)
1800 (make_window): Likewise.
1801
e509cfa6
DA
18022012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1803
1804 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1805 enabled with --enable-checking=[all,glyphs] configure option.
1806 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1807 adjust comments accordingly.
1808 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1809 undefined, adjust comments accordingly.
1810 * image.c: Likewise.
1811 * scroll.c: Likewise.
1812 * w32fns.c: Likewise.
1813 * w32term.c: Likewise.
1814 * xdisp.c: Likewise.
1815 * xfaces.c: Likewise.
1816 * xfns.c: Likewise.
1817 * xterm.c: Likewise.
1818
a54e2c05
DA
18192012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1820
1821 Generalize run-time debugging checks.
1822 * dispextern.h (XASSERTS): Remove.
1823 * fontset.c (xassert): Remove.
1824 Convert from xassert to eassert.
1825 * alloc.c: Convert from xassert to eassert.
1826 * bidi.c: Likewise.
1827 * dispnew.c: Likewise.
1828 * fns.c: Likewise.
1829 * fringe.c: Likewise.
1830 * ftfont.c: Likewise.
1831 * gtkutil.c: Likewise.
1832 * image.c: Likewise.
1833 * keyboard.c: Likewise.
1834 * menu.c: Likewise.
1835 * process.c: Likewise.
1836 * scroll.c: Likewise.
1837 * sound.c: Likewise.
1838 * term.c: Likewise.
1839 * w32console.c: Likewise.
1840 * w32fns.c: Likewise.
1841 * w32term.c: Likewise.
1842 * window.c: Likewise.
1843 * xdisp.c: Likewise.
1844 * xfaces.c: Likewise.
1845 * xfns.c: Likewise.
1846 * xselect.c: Likewise.
1847 * xterm.c: Likewise.
1848
1ec4b7b2
SM
18492012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1850
1851 * fns.c (maybe_resize_hash_table): Output message when growing the
1852 purify-hashtable.
1853
2014308a
DA
18542012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1855
1856 * alloc.c (allocate_string_data): Remove dead code.
1857 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1858 avoid GCC warning about unused macro.
1859
246155eb
DA
18602012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1861
1862 * alloc.c (allocate_string): Omit intervals initialization.
1863 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1864 as in make_pure_string and make_pure_c_string.
1865
43184b7b
DA
18662012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1867
d209e2fb 1868 * alloc.c (allocate_string): Fix last change.
43184b7b 1869
3fe6dd74
DA
18702012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1871
d209e2fb 1872 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1873 to memset, add explicit initialization where appropriate.
1874
1ba6038a
GM
18752012-06-27 Glenn Morris <rgm@gnu.org>
1876
1877 * lisp.mk (lisp): Remove paths.elc.
1878
c89926a5
CY
18792012-06-27 Chong Yidong <cyd@gnu.org>
1880
1881 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1882
ed6b3510
JW
18832012-06-26 John Wiegley <johnw@newartisans.com>
1884
1ec4b7b2 1885 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1886 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1887
ed6b3510
JW
1888 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1889 when building with Clang.
1890
8edd4a2b
SM
18912012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1892
1893 * eval.c (Fapply): Allow calling it with a single argument.
1894
f6f62d1b
EZ
18952012-06-26 Eli Zaretskii <eliz@gnu.org>
1896
1897 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1898 _stricmp and _strnicmp.
1899 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1900
62efea5e
DA
19012012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1902
1903 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1904 allocated window.
1905 (allocate_process): Likewise for new process.
8edd4a2b 1906 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1907 (allocate_frame): Likewise.
1908 * frame.c (make_frame): Omit redundant initialization.
1909 * window.c (make_parent_window): Use memset.
1910 (make_window): Omit redundant initialization.
1911 * process.c (make_process): Omit redundant initialization.
1912 * terminal.c (create_terminal): Likewise.
1913
42997f4d
DA
19142012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1915
1916 * term.c (delete_tty): Remove redundant call to memset.
1917
1130ecfc
DA
19182012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1919
1920 * alloc.c: Remove build_string.
1921 * lisp.h: Define build_string as static inline. This provides
1922 a better opportunity to optimize away calls to strlen when the
1923 function is called with compile-time constant argument.
1924 * image.c (imagemagick_error): Convert to build_string.
1925 * w32proc.c (sys_spawnve): Likewise.
1926 * xterm.c (x_term_init): Likewise.
1927
cf38a720
PE
19282012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1929
99027bdd
PE
1930 Use sprintf return value instead of invoking strlen on result.
1931 In the old days this wasn't portable, since some sprintf
1932 implementations returned char *. But they died out years ago and
1933 Emacs already assumes sprintf returns int.
1934 Similarly for float_to_string.
1935 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1936 * ccl.c (ccl_driver):
1937 * character.c (string_escape_byte8):
1938 * data.c (Fnumber_to_string):
1939 * doprnt.c (doprnt):
1940 * print.c (print_object):
1941 * xdisp.c (message_dolog):
1942 * xfns.c (syms_of_xfns):
1943 Use sprintf or float_to_string result to avoid need to call strlen.
1944 * data.c (Fnumber_to_string):
1945 Use make_unibyte_string, since the string must be ASCII.
1946 * lisp.h, print.c (float_to_string): Now returns int length.
1947 * term.c (produce_glyphless_glyph):
1948 Use sprintf result rather than recomputing it.
1949
cf38a720
PE
1950 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1951 * Makefile.in (ALL_CFLAGS):
1952 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1953 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1954
3511c784
DA
19552012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1956
0a08eb21 1957 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1958 strcasecmp if available.
1959 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1960
fb7da12e
AS
19612012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1962
1963 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1964 Avoid comma operator.
1965 * menu.c (push_submenu_start, push_submenu_end)
1966 (push_left_right_boundary, push_menu_pane): Likewise.
1967 * msdos.c (dos_rawgetc): Likewise.
1968
afa2ffd8
DA
19692012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1970
1971 * xfns.c (xic_create_fontsetname): Remove redundant calls
1972 to memset.
1973
b3b4476b
PE
19742012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1975
4495ff38
PE
1976 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1977 sprintf already null-terminates its output.
1978
b3b4476b
PE
1979 * xfns.c (x_window): Remove redundant cast.
1980
b00876c9
DA
19812012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1982
1983 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1984 `const char *' to `char *' to avoid compiler warning.
1985
d188e26b
PE
19862012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1987
885d1d74
PE
1988 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1989 instead of truncating it to 63 (admittedly a generous limit).
1990
d188e26b
PE
1991 * process.c: Fix spelling and caps in comments.
1992
e2f560b1
DN
19932012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1994
e86db54b 1995 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1996 * sysdep.c (setpgrp): Remove definition, not used in this file.
1997
7583a3a1
JB
19982012-06-24 Juanma Barranquero <lekktu@gmail.com>
1999
2000 * makefile.w32-in: Update dependencies.
2001
696056c2
EZ
20022012-06-24 Eli Zaretskii <eliz@gnu.org>
2003
2004 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2005 (SYSTIME_H): Add nt/inc/sys/time.h.
2006
2007 * systime.h [WINDOWSNT]: Include sys/time.h.
2008
2009 * s/ms-w32.h (struct timespec): Definition moved from
2010 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2011
845ca893
PE
20122012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2013
2014 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2015 * buffer.h (buffer_slot_type_mismatch):
2016 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2017 * eval.c (unwind_to_catch):
2018 * image.c (my_png_error, my_error_exit):
2019 * keyboard.c (quit_throw_to_read_char, user_error)
2020 (Fexit_recursive_edit, Fabort_recursive_edit):
2021 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2022 (wrong_type_argument, buffer_overflow, __executable_start)
2023 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2024 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2025 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2026 (fatal):
2027 (child_setup) [!DOS_NT]:
2028 * lread.c (end_of_file_error, invalid_syntax):
2029 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2030 * puresize.h (pure_write_error):
2031 * search.c (matcher_overflow):
2032 * sound.c (sound_perror, alsa_sound_perror):
2033 * sysdep.c, syssignal.h (croak):
2034 * term.c (maybe_fatal, vfatal):
2035 * textprop.c (text_read_only):
2036 * undo.c (user_error):
2037 * unexmacosx.c (unexec_error):
2038 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2039 Use _Noreturn rather than NO_RETURN.
2040 No need for separate decl merely because of _Noreturn.
2041 * sound.c (sound_warning, parse_sound):
2042 Remove unnecessary forward decls.
2043
f1dd8073
PE
20442012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2045
2046 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2047 * lisp.h (WAIT_READING_MAX): New macro.
2048 * dispnew.c (Fsleep_for, sit_for):
2049 * keyboard.c (kbd_buffer_get_event):
2050 * process.c (Faccept_process_output):
2051 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2052 This improves on the previous patch, which introduced a bug
2053 when time_t is unsigned and as wide as intmax_t.
2054 See <http://bugs.gnu.org/9000#51>.
2055
b82c1755
EZ
20562012-06-23 Eli Zaretskii <eliz@gnu.org>
2057
2058 * dispnew.c (sit_for, Fsleep_for):
2059 * keyboard.c (kbd_buffer_get_event):
2060 * process.c (Faccept_process_output): Avoid compiler warnings when
2061 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2062
ca300656
JB
20632012-06-23 Juanma Barranquero <lekktu@gmail.com>
2064
049ec95b
JB
2065 * makefile.w32-in: Update dependencies.
2066
ca300656
JB
2067 * w32.c (ltime): Add return type and declare static.
2068 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2069
db7b8d06
PE
20702012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2071
2072 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2073 Privately reported by Herbert J. Skuhra.
2074 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2075 All uses changed.
2076 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2077 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2078
0bd8297f
EZ
20792012-06-23 Eli Zaretskii <eliz@gnu.org>
2080
96512555
EZ
2081 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2082 last argument of make_unibyte_string.
2083
0bd8297f
EZ
2084 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2085 language ID in the event parameters.
2086
2087 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2088 event.code, not the obscure "character set ID".
2089
63def6b6
CY
20902012-06-23 Chong Yidong <cyd@gnu.org>
2091
2092 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2093
e8a02204
EZ
20942012-06-23 Eli Zaretskii <eliz@gnu.org>
2095
388cdec0
EZ
2096 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2097 * w32.c (fdutimens): New function.
2098
2099 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2100
2101 * s/ms-w32.h (pselect): Redirect to sys_select.
2102
2103 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2104
e8a02204
EZ
2105 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2106 in the logic of incrementing and decrementing the value of
2107 use_relocatable_buffers.
2108
d054f3fb
PE
21092012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2110
2111 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2112 Privately reported by Herbert J. Skuhra.
2113 [__FreeBSD__]: Remove "*/" typo after "#include".
2114 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2115 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2116 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2117 Don't assume EMACS_TIME and struct timeval are the same type.
2118
d35af63c
PE
21192012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2120
2121 Support higher-resolution time stamps (Bug#9000).
2122 The time stamps are only nanosecond-resolution at the C level,
2123 since that's the best that any real-world system supports now.
2124 But they are picosecond-resolution at the Lisp level, as that's
2125 easy, and leaves room for future OS improvements.
2126
2127 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2128 (LIBES): Use it.
2129
2130 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2131 Don't get current time unless it's needed.
2132
2133 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2134 now provides it if it's absent.
2135 (start_atimer): Port to higher-res time stamps.
2136 Check for time stamp overflow. Don't get current time more
2137 often than is needed.
2138
2139 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2140 Include systime.h, not time.h.
2141 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2142
2143 * dired.c: Include stat-time.h.
2144 (Ffile-attributes): File times now have higher resolution.
2145
2146 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2147 (struct image): Timestamp now has higher resolution.
2148
2149 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2150 has at least microseconds now. All uses removed.
2151 (update_frame, update_single_window, update_window, update_frame_1)
2152 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2153
2154 * editfns.c (time_overflow): Now extern.
2155 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2156 (float-time, Fformat_time_string, Fcurrent_time_string)
2157 (Fcurrent_time_zone): Accept and generate higher-resolution
2158 time stamps.
2159 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2160 (decode_time_components, lisp_seconds_argument): New functions.
2161 (make_time): Now static.
2162 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2163 Report an error if the time is invalid, rather than having the caller
2164 do that.
2165
2166 * fileio.c: Include <stat-time.h>
2167 (Fcopy_file): Copy higher-resolution time stamps.
2168 Prefer to set the time stamp via a file descriptor if that works.
2169 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2170 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2171 (Fvisited_file_modtime, Fset_visited_file_modtime):
2172 Support higher-resolution time stamps.
2173
2174 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2175
2176 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2177
2178 * image.c (prepare_image_for_display, clear_image_cache)
2179 (lookup_image): Port to higer-resolution time stamps.
2180
2181 * keyboard.c (start_polling, bind_polling_period):
2182 Check for time stamp overflow.
2183 (read_char, kbd_buffer_get_event, timer_start_idle)
2184 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2185 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2186 Port to higher-resolution time stamps. Do not assume time_t is signed.
2187 (decode_timer): New function. Timers are now vectors of length 9,
2188 not 8, to accommodate the picosecond component.
2189 (timer_check_2): Use it.
2190
2191 * nsterm.m (select_timeout, timeval_subtract): Remove.
2192 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2193 as they're a bit more accurate and handle overflow better.
2194 (ns_select): Change prototype to be compatible with pselect.
2195 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2196 * nsterm.h (ns_select): Adjust prototype.
2197
2198 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2199 us-resolution time stamps.
2200 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2201
2202 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2203
2204 * lisp.h (time_overflow): New decl.
2205 (wait_reading_process_output): First arg is now intmax_t, not int,
2206 to accommodate larger waits.
2207
2208 * process.h (struct Lisp_Process.read_output_delay):
2209 Now counts nanoseconds, not microseconds.
2210 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2211 EMACS_HAS_USECS.
2212 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2213 (wait_reading_process_output):
2214 Port to ns-resolution time stamps.
2215 (Faccept_process_output, wait_reading_process_output):
2216 Check for time stamp overflow. Do not assume time_t is signed.
2217 (select_wrapper): Remove; we now use pselect.
2218 (Fprocess_attributes): Now generates ns-resolution time stamps.
2219
2220 * sysdep.c: Include utimens.h. Don't include utime.h
2221 or worry about struct utimbuf; gnulib does that for us now.
2222 (gettimeofday): Remove; gnulib provides a substitute.
2223 (make_timeval): New function.
2224 (set_file_times): Now sets ns-resolution time stamps.
2225 New arg FD; all uses changed.
2226 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2227 (system_process_attributes):
2228 Now returns ns-resolution time stamp. All uses changed.
2229 Check for time stamp overflow.
2230
2231 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2232 provides a substitute now.
2233
2234 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2235 since it guarantees struct timespec.
2236 (EMACS_TIME): Now struct timespec, so that we can support
2237 ns-resolution time stamps.
2238 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2239 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2240 (EMACS_USECS): Remove.
2241 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2242 so multiply the arg by 1000 before storing it.
2243 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2244 New macros.
2245 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2246 Port to ns-resolution time stamps.
2247 (EMACS_TIME_NEG_P): Remove; replaced by....
2248 (EMACS_TIME_SIGN): New macro.
2249 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2250 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2251 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2252 (make_timeval, make_lisp_time, decode_time_components): New decls.
2253 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2254 that it mishandled time_t overflow. You can't compare by subtracting!
2255 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2256 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2257
2258 * term.c: Include <sys/time.h>.
2259 (timeval_to_Time): New function, for proper overflow wraparound.
2260 (term_mouse_position, term_mouse_click): Use it.
2261
2262 * undo.c (record_first_change): Support higher-resolution time stamps
2263 in the undo buffer.
2264 (Fprimitive_undo): Use them when restoring time stamps.
2265
2266 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2267 (w32_get_internal_run_time):
2268 Port to higher-resolution Emacs time stamps.
2269 (ltime): Now accepts single 64-bit integer, as that's more convenient
2270 for callers.
2271
2272 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2273
2274 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2275 for compatibility with pselect. Support ns-resolution time stamps.
2276
2277 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2278
2279 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2280 Check for time stamp overflow, and support ns-resolution time stamps.
2281
2282 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2283 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2284 (timeval_subtract): Remove; no longer needed.
2285 (XTflash, XTring_bell, x_wait_for_event):
2286 Port to ns-resolution time stamps. Don't assume time_t is signed.
2287
b6a92dfe
CY
22882012-06-22 Chong Yidong <cyd@gnu.org>
2289
2290 * xdisp.c (x_consider_frame_title): Revert last change.
2291
d251c37c
EZ
22922012-06-22 Eli Zaretskii <eliz@gnu.org>
2293
2294 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2295 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2296 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2297 staticidx goes up to 1597 out of 1600 = 0x640.)
2298
f10deafb
PE
22992012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2300
2301 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2302 Otherwise, the umask might be mistakenly 0 while handling input signals.
2303
ec6de1e2
SM
23042012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2305
2306 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2307
28be1ada
DA
23082012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2309
2310 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2311 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2312 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2313 access to `contents' member of Lisp_Vector objects with AREF and ASET
2314 where appropriate.
2315
c6bf3022
CY
23162012-06-19 Chong Yidong <cyd@gnu.org>
2317
2318 * frame.c (delete_frame): When selecting a frame on a different
2319 text terminal, do not alter the terminal's top-frame.
2320
2321 * xdisp.c (format_mode_line_unwind_data): Record the target
2322 frame's selected window and its terminal's top-frame.
2323 (unwind_format_mode_line): Restore them.
2324 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2325 Callers changed.
2326 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2327 since tty frames can be explicitly named.
2328 (prepare_menu_bars): Likewise.
2329
2330 * term.c (Ftty_top_frame): New function.
2331
defd4196
PE
23322012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2333
2334 Port byte-code-meter to modern targets.
2335 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2336 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2337 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2338 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2339 (METER_1, METER_2): Simplify.
2340
1053a871
SM
23412012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2342
2343 * data.c (Fdefalias): Return `symbol' (bug#11686).
2344
b7e8d081
MR
23452012-06-18 Martin Rudalics <rudalics@gmx.at>
2346
2347 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2348 gets killed during executing of this function (Bug#11665).
2349 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2350 (Vkill_buffer_query_functions): In doc-string say that functions
2351 run by this hook should not change the current buffer.
2352
7ea2b339
PE
23532012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2354
2355 Fix recently-introduced process.c problems found by static checking.
2356 * process.c (write_queue_push, write_queue_pop, send_process):
2357 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2358 (write_queue_pop): Fix pointer signedness problem.
2359 (send_process): Remove unused local.
2360
96a313a1
CY
23612012-06-17 Chong Yidong <cyd@gnu.org>
2362
2363 * xdisp.c (redisplay_internal): No need to redisplay terminal
2364 frames that are not on top.
2365
20ca2e94
TN
23662012-06-17 Troels Nielsen <bn.troels@gmail.com>
2367
2368 * process.c (make_process): Initialize write_queue.
2369 (write_queue_push, write_queue_pop): New functions.
2370 (send_process): Use them to maintain correct ordering of process
2371 writes (Bug#10815).
2372
9a900ca9
PE
23732012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2374
310fbfa8
PE
2375 * lisp.h (eassert): Assume C89 or later.
2376 This removes the need for CHECK.
2377 (CHECK): Remove. Its comments about always evaluating its
2378 argument were confusing, as 'eassert' typically does not evaluate
2379 its argument.
2380
27bb1ca4
PE
2381 * coding.c (produce_chars): Use ptrdiff_t, not int.
2382
9a900ca9
PE
2383 * xterm.c (x_draw_underwave): Check for integer overflow.
2384 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2385
41b7f8bc 23862012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2387
2388 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2389 referenced (Bug#11583).
2390
9b0e3eba
AA
23912012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2392
2393 Implement wave-style variant of underlining.
2394 * dispextern.h (face_underline_type): New enum.
2395 (face): Add field for underline type.
2396 * nsterm.m (ns_draw_underwave): New function.
2397 (ns_draw_text_decoration): Use it.
2398 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2399 New functions.
2400 (x_draw_glyph_string): Use them.
2401 * xfaces.c (Qline, Qwave): New Lisp objects.
2402 (check_lface_attrs, merge_face_ref)
1053a871
SM
2403 (Finternal_set_lisp_face_attribute, realize_x_face):
2404 Handle wave-style underline face attributes.
9b0e3eba
AA
2405 * xterm.c (x_draw_underwave): New function.
2406 (x_draw_glyph_string): Use it.
2407
0fb52f11
JB
24082012-06-16 Juanma Barranquero <lekktu@gmail.com>
2409
2410 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2411 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2412 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2413 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2414 ($(BLD)/w32select.$(O)): Update dependencies.
2415
e5560ff7
AS
24162012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2417
2418 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2419 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2420 * character.c (_fetch_multibyte_char_p): Remove.
2421 * alloc.c: Include "character.h" before "buffer.h".
2422 * bidi.c: Likewise.
2423 * buffer.c: Likewise.
2424 * bytecode.c: Likewise.
2425 * callint.c: Likewise.
2426 * callproc.c: Likewise.
2427 * casefiddle.c: Likewise.
2428 * casetab.c: Likewise.
2429 * category.c: Likewise.
2430 * cmds.c: Likewise.
2431 * coding.c: Likewise.
2432 * composite.c: Likewise.
2433 * dired.c: Likewise.
2434 * dispnew.c: Likewise.
2435 * doc.c: Likewise.
2436 * dosfns.c: Likewise.
2437 * editfns.c: Likewise.
2438 * emacs.c: Likewise.
2439 * fileio.c: Likewise.
2440 * filelock.c: Likewise.
2441 * font.c: Likewise.
2442 * fontset.c: Likewise.
2443 * fringe.c: Likewise.
2444 * indent.c: Likewise.
2445 * insdel.c: Likewise.
2446 * intervals.c: Likewise.
2447 * keyboard.c: Likewise.
2448 * keymap.c: Likewise.
2449 * lread.c: Likewise.
2450 * macros.c: Likewise.
2451 * marker.c: Likewise.
2452 * minibuf.c: Likewise.
2453 * nsfns.m: Likewise.
2454 * nsmenu.m: Likewise.
2455 * print.c: Likewise.
2456 * process.c: Likewise.
2457 * regex.c: Likewise.
2458 * region-cache.c: Likewise.
2459 * search.c: Likewise.
2460 * syntax.c: Likewise.
2461 * term.c: Likewise.
2462 * textprop.c: Likewise.
2463 * undo.c: Likewise.
2464 * unexsol.c: Likewise.
2465 * w16select.c: Likewise.
2466 * w32fns.c: Likewise.
2467 * w32menu.c: Likewise.
2468 * window.c: Likewise.
2469 * xdisp.c: Likewise.
2470 * xfns.c: Likewise.
2471 * xmenu.c: Likewise.
2472 * xml.c: Likewise.
2473 * xselect.c: Likewise.
2474
2f07e6af
EZ
24752012-06-16 Eli Zaretskii <eliz@gnu.org>
2476
1053a871
SM
2477 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2478 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2479 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2480 row.
2481 (handle_face_prop): Use chunk-relative overlay string index when
2482 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2483 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2484 the rightmost. (Bug#11720)
2f07e6af 2485
29b83cec
AS
24862012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2487
2488 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2489 (CATEGORY_MEMBER): Enforce 1/0 value.
2490 * category.c (_temp_category_set): Remove.
2491
4c5501e9
EZ
24922012-06-16 Eli Zaretskii <eliz@gnu.org>
2493
2494 * window.c (Fdelete_other_windows_internal)
2495 (Fdelete_window_internal): Don't access frame's mouse highlight
2496 info of the initial frame. (Bug#11677)
2497
2b570124
PE
24982012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2499
e93864f9
PE
2500 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2501 Assume USE_2_TAGS_FOR_INTS.
2502 (xreload): Adjust $tagmask width to match recent lisp.h change.
2503
2b570124
PE
2504 Simplify lisp.h in minor ways that should not affect code.
2505 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2506 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2507 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2508 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2509 (INTTYPEBITS): New macro, for clarity.
2510 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2511 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2512 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2513 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2514 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2515
81755f69
JB
25162012-06-13 Juanma Barranquero <lekktu@gmail.com>
2517
2518 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2519
16192a57
GM
25202012-06-13 Glenn Morris <rgm@gnu.org>
2521
2522 * s/bsd-common.h (BSD4_3):
2523 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2524
646b5f55
AS
25252012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2526
2527 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2528 instead of union.
2529 (XLI, XIL): Define.
1053a871
SM
2530 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2531 Use them.
2532 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2533 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2534 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2535 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2536 * frame.c (delete_frame): Remove outdated comment.
2537 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2538 USE_LISP_UNION_TYPE.
2539 (Fw32_unregister_hot_key): Likewise.
2540 (Fw32_toggle_lock_key): Likewise.
2541 * w32menu.c (add_menu_item): Likewise.
2542 (w32_menu_display_help): Use XIL instead of checking
2543 USE_LISP_UNION_TYPE.
2544 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2545 (init_heap): Likewise.
2546 * w32term.c (w32_read_socket): Update comment.
2547
1d3823c9
GM
25482012-06-13 Glenn Morris <rgm@gnu.org>
2549
c62ff706
GM
2550 * s/usg5-4-common.h, src/s/unixware.h:
2551 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2552
1d3823c9
GM
2553 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2554
bfe3e0a2
PE
25552012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2558 * alloc.c (make_number) [!defined make_number]:
2559 Remove, as lisp.h always defines this now.
2560 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2561 (roundup_size): Verify that it is a power of 2.
2562 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2563 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2564 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2565 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2566 USE_LSB_TAG now is always defined to be either 0 or 1.
2567 All uses changed.
2568 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2569 code works fine either way, and efficiency is not a concern here,
2570 as the union type is for debugging, not for production.
2571 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2572 Use an inline function on all platforms when using the union type,
2573 since this is simpler and 'static inline' can be used portably
2574 within Emacs now.
2575 (LISP_INITIALLY_ZERO): New macro.
2576 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2577 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2578
45fa9c0f
GM
25792012-06-12 Glenn Morris <rgm@gnu.org>
2580
b4492cba
GM
2581 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2582
2583 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2584
45fa9c0f
GM
2585 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2586 Move BROKEN_SIGIO to configure.
2587
2588 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2589 Move NO_TERMIO to configure.
2590
0e25d334
CY
25912012-06-12 Chong Yidong <cyd@gnu.org>
2592
2593 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2594 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2595 MagickExportImagePixels is undefined.
2596
43682bb6
PE
25972012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2598
2599 * image.c (imagemagick_load_image): Remove unused label.
2600
a9be7d2b
GM
26012012-06-11 Glenn Morris <rgm@gnu.org>
2602
2603 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2604 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2605 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2606 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2607
3017f87f
SM
26082012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2609
2610 * alloc.c (make_byte_code): New function.
2611 (Fmake_byte_code): Use it. Don't purify here.
2612 * lread.c (read1): Use it as well to avoid extra allocation.
2613
1b9b4cf4
CY
26142012-06-11 Chong Yidong <cyd@gnu.org>
2615
2616 * image.c (imagemagick_load_image): Implement transparency.
2617
95988fcf
AS
26182012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2619
2620 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2621 account for preceding backslashes. (Bug#11663)
2622
cd4eb164
CY
26232012-06-09 Chong Yidong <cyd@gnu.org>
2624
2625 * term.c: Support italics in capable terminals (Bug#9652).
2626 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2627 (turn_on_face): Output using TS_enter_italic_mode if available.
2628 Don't handle unused blinking and alt-charset cases.
2629 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2630 and tty_alt_charset_p cases.
2631 (tty_capable_p, init_tty): Support italics.
2632
2633 * termchar.h (struct tty_display_info): Add field for italics.
2634 Remove unused blink field.
2635
2636 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2637 Handle slant.
2638
2639 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2640 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2641 tty_alt_charset_p. Add tty_italic_p.
2642
ff88beb8
MA
26432012-06-09 Michael Albinus <michael.albinus@gmx.de>
2644
2645 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2646 dbus_type_is_basic if available.
2647 (xd_extract_signed, xd_extract_unsigned): Rename from
2648 extract_signed and extract_unsigned, respectively. Adapt callers.
2649
44286096
CY
26502012-06-09 Chong Yidong <cyd@gnu.org>
2651
1682701f
CY
2652 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2653
44286096
CY
2654 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2655 case (Bug#9752).
2656
d86feb17
PE
26572012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2658
2659 * xdisp.c (vmessage): Treat frame message as multibyte.
2660 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2661 would generate the diagnostic "Making \302\247 buffer-local while
2662 let-bound!".
2663
d5c20fe8
EZ
26642012-06-08 Eli Zaretskii <eliz@gnu.org>
2665
2666 * dispnew.c (showing_window_margins_p): Undo last change, which
2667 was done due to an inadvertent commit.
2668 (adjust_frame_glyphs_for_frame_redisplay): Do call
2669 showing_window_margins_p.
2670
513749ee
SM
26712012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2672
2673 * eval.c (Fmake_var_non_special): New primitive.
2674 (syms_of_eval): Defsubr it.
2675 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2676
d4a8f5c1
JB
26772012-06-08 Juanma Barranquero <lekktu@gmail.com>
2678
2679 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2680 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2681
8bbbc977
EZ
26822012-06-08 Eli Zaretskii <eliz@gnu.org>
2683
2684 * alloc.c (allocate_vectorlike): Fix last change.
2685
f3372c87
DA
26862012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2687
2688 Block-based vector allocation of small vectors.
2689 * lisp.h (struct vectorlike_header): New field `nbytes',
2690 adjust comment accordingly.
2691 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2692 to denote vector blocks. Adjust users (live_vector_p,
2693 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2694 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2695 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2696 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2697 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2698 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2699 (roundup_size): New constant.
2700 (struct vector_block): New data type.
2701 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2702 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2703 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2704 (sweep_vectors): New functions.
2705 (allocate_vectorlike): Return `zero_vector' as the only vector of
2706 0 items. Allocate new vector from block if vector size is less than
2707 or equal to VBLOCK_BYTES_MAX.
2708 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2709 (init_alloc_once): Add call to init_vectors.
2710
4f18a4ed
SM
27112012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2712
2713 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2714
86f158bc
PE
27152012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2716
2717 * doprnt.c (doprnt): Truncate multibyte char correctly.
2718 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2719 would mishandle a string argument "Xc" if X was a multibyte
2720 character of length 2: it would truncate after X's first byte
2721 rather than including all of X.
2722
c5cfcbe0
CY
27232012-06-06 Chong Yidong <cyd@gnu.org>
2724
2725 * buffer.c (word_wrap): Doc fix.
2726
c05cf390
PE
27272012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2728
2729 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2730
0c3461de
GM
27312012-06-03 Glenn Morris <rgm@gnu.org>
2732
2733 * xdisp.c (tool-bar-style): Doc fix.
2734
c71232db
UM
27352012-06-03 Ulrich Müller <ulm@gentoo.org>
2736
2737 * Makefile.in (PAXCTL): Define.
2738 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2739 binary via PaX flags if the paxctl utility is available.
2740 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2741 Restore PaX flags to their default. (Bug#11398)
2742
383f7350
CY
27432012-06-03 Chong Yidong <cyd@gnu.org>
2744
2745 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2746 buffer (Bug#11226).
2747
5f2c76c6
CY
27482012-06-03 Chong Yidong <cyd@gnu.org>
2749
2750 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2751 (note_mode_line_or_margin_highlight): If there is no help echo,
2752 use mode-line-default-help-echo. Handle the case where the mouse
2753 position is past the end of the mode line string.
2754
2755 * buffer.c (buffer_local_value_1): New function, split from
2756 Fbuffer_local_value; can return Qunbound.
2757 (Fbuffer_local_value): Use it.
2758 (Vmode_line_format): Docstring tweaks.
2759
773d47f6
PE
27602012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2761
2762 * sysdep.c (system_process_attributes): Improve comment.
2763
f2d6a3df
SM
27642012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2765
2766 * keyboard.c: Export real-this-command to Elisp.
2767 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2768 and DEFVAR it. Update all users.
2769
63810350
PE
27702012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2771
7bd5c1f4
PE
2772 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2773
63810350
PE
2774 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2775 Convert pctcpu and pctmem to Lisp float properly.
2776 Let the compiler fold better, as 100.0/0x8000 is exact.
2777
a2821611
AS
27782012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2779
2780 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2781 cons_block.
2782
5fceba1d
PE
27832012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2784
2785 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2786
c98ff5dd
DA
27872012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2788
2789 For a 'struct window', replace some Lisp_Object fields to
2790 bitfields where appropriate, remove unused fields.
2791 * window.h (struct window): Remove unused 'last_mark_x' and
2792 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2793 change it's type from Lisp_Object to bitfield.
2794 Change type of 'force_start', 'optional_new_start',
2795 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2796 fields from Lisp_Object to bitfield. Adjust users accordingly.
2797
ca34e0be
PE
27982012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2799
2800 Pacify gcc -Wdouble-precision when using Xaw.
2801 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2802 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2803 Use 'float' consistently, rather than 'float' in most places
2804 and 'double' in a couple of places.
2805
efc00ab1 28062012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2807
2808 * xdisp.c (handle_stop): Detect whether we have overlay strings
2809 loaded by testing it->current.overlay_string_index to be
2810 non-negative, instead of checking whether n_overlay_strings is
2811 positive. (Bug#11587)
2812
efc00ab1 28132012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2814
2815 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2816
2817 * doc.c (Fsubstitute_command_keys): Doc fix.
2818
efc00ab1 28192012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2820
2821 * search.c (search_buffer): Remove calls to
2822 r_alloc_inhibit_buffer_relocation, as it is now called by
2823 maybe_unify_char, which was the cause of relocation of buffer text
2824 in bug#11519.
2825
efc00ab1 28262012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2827
2828 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2829 for the duration of call to load_charset, to avoid problems with
2830 callers of maybe_unify_char that access buffer text through C
2831 pointers.
2832
2833 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2834 decrement the inhibition flag, instead of just setting or
2835 resetting it.
2836
ba93a187
PE
28372012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2838
2839 Remove obsolete '#define static' cruft.
2840 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2841 This #undef was "temporary" in 2000; it is no longer needed
2842 now that '#define static' has gone away.
2843 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2844 (gray_bitmap_bits): Remove; no longer needed.
2845 All uses replaced with definiens.
2846 * xterm.c: Include "bitmaps/gray.xbm".
2847
9e4bf381
PE
28482012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2849
2850 Clean up __executable_start, monstartup when --enable-profiling.
2851 The following changes affect the code only when profiling.
2852 * dispnew.c (__executable_start): Rename from safe_bcopy.
2853 Define only on platforms that need it.
2854 * emacs.c: Include <sys/gmon.h> when profiling.
2855 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2856 (__executable_start): Remove decl, since lisp.h does it now.
2857 (safe_bcopy): Remove decl; no longer has that name.
2858 (main): Coalesce #if into single bit of code, for simplicity.
2859 Cast pointers to uintptr_t, since standard libraries want integers
2860 and not pointers.
2861 * lisp.h (__executable_start): New decl.
2862
32d72c2f
GM
28632012-05-31 Glenn Morris <rgm@gnu.org>
2864
2865 * image.c (Fimagemagick_types): Doc fix.
2866
baac5bc7
JM
28672012-05-30 Jim Meyering <meyering@redhat.com>
2868
2869 * callproc.c (Fcall_process_region): Include directory component
2870 in mkstemp error message (Bug#11586).
2871
72cb32cf
PE
28722012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2873
2874 * alloc.c, lisp.h (make_pure_vector): Now static.
2875
61b108cc
SM
28762012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2877
2878 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2879 Move to byte-run.el.
2880 (Fautoload): Do the hash-doc more carefully.
2881 * data.c (Fdefalias): Purify definition, except for keymaps.
2882 (Qdefun): Move from eval.c.
2883 * lisp.h (Qdefun): Remove.
2884 * lread.c (read1): Tiny simplification.
2885
471fe23d
TN
28862012-05-29 Troels Nielsen <bn.troels@gmail.com>
2887
934f3f58 2888 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2889 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2890 Bug#9642, but explicitly check that the buffer the overlay would
2891 be moved to is live and rearrange lines to make sure that errors
2892 will not put the overlay in an inconsistent state.
2893 (Fdelete_overlay): Cosmetics.
2894
85d0efd1
EZ
28952012-05-28 Eli Zaretskii <eliz@gnu.org>
2896
2897 * w32term.c (my_bring_window_to_top): New function.
2898 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2899 could be different from the original one.
2900 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2901 (Bug#11513)
2902
2903 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2904 by calling BringWindowToTop.
2905
2906 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2907 (WM_EMACS_END): Increase by one.
2908
da92a98c
PE
29092012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2910
2911 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2912 This avoids undefined behavior that might cause the eassert
2913 to not catch an out-of-range value.
2914
74d1f848
JB
29152012-05-28 Juanma Barranquero <lekktu@gmail.com>
2916
2917 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2918 Update dependencies.
2919
9e1a06fc
EZ
29202012-05-27 Eli Zaretskii <eliz@gnu.org>
2921
2922 * bidi.c (bidi_mirror_char): Fix last change.
2923
f3dd7312
AS
29242012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2925
2926 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2927 when referring to sectname field in printf format.
2928
81899c91
PE
29292012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2930
57b81a9f
PE
2931 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2932 Only r_alloc_inhibit_buffer_relocation needed to be added;
2933 the others were already declared.
2934
81899c91
PE
2935 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2936 before checking whether it's out of range. Put the check inside
2937 eassert. See
2938 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2939
33017faf 29402012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2941
2942 * callproc.c (Fcall_process): Restore a line that was accidentally
2943 commented out in the 2011-02-13 change (bug#11547).
2944
33017faf 29452012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2946
2947 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2948 defined on ralloc.c.
2949
2950 * buffer.c [REL_ALLOC]: Remove prototypes of
2951 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2952 they are now on lisp.h.
2953
2954 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2955
2956 * search.c (search_buffer): Use it to inhibit relocation of buffer
2957 text while re_search_2 is doing its job, because re_search_2 is
2958 passed C pointers to buffer text. (Bug#11519)
2959
23415acf
EZ
2960 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2961 Update value to 24.
2962
44e27368
EZ
2963 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2964 state after an additional call to move_it_in_display_line_to, keep
2965 the values of it->max_ascent and it->max_descent found for the
2966 entire line.
2967 (pos_visible_p): Revert the comparison against bottom_y to what it
2968 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2969 (Bug#11464)
2970
c1892f11
PE
29712012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2972
2973 Fix coding-related core dumps with gcc -ftrapv.
2974 The code was computing A - B, where A and B are pointers, and B is
2975 random garbage. This can lead to core dumps on platforms that
2976 have special pointer registers, and it also leads to core dumps on
2977 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2978 A - B only when B is initialized properly.
2979 * coding.c (coding_set_source, coding_set_destination): Return void.
2980 (coding_change_source, coding_change_destinations): New functions,
2981 with the old behaviors of coding_set_source and coding_set_destination.
2982 All callers that need an offset changed to use these new functions.
2983
eb7afdad
GM
29842012-05-26 Glenn Morris <rgm@gnu.org>
2985
2986 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2987
f12fdf02
EZ
29882012-05-26 Eli Zaretskii <eliz@gnu.org>
2989
53a63be6 2990 Extend mouse support on W32 text-mode console.
61b108cc
SM
2991 * xdisp.c (draw_row_with_mouse_face):
2992 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2993
eb3f6f01 2994 * w32console.c: Include window.h.
61b108cc
SM
2995 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2996 New functions.
eb3f6f01
EZ
2997 (initialize_w32_display): Initialize mouse-highlight data.
2998
53a63be6
EZ
2999 * w32inevt.c: Include termchar.h and window.h.
3000 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3001 moves, call note_mouse_highlight. If help_echo changed, call
3002 gen_help_event to produce help-echo message in the echo area.
3003 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3004 highlight info.
3005
4cfd81f6
PE
30062012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3007
3008 * lread.c (read1): Simplify slightly to avoid an overflow warning
3009 with GCC 4.7.0 on x86-64.
3010
4446092a
EZ
30112012-05-26 Eli Zaretskii <eliz@gnu.org>
3012
3013 * bidi.c (bidi_mirror_char): Revert last change: an int is
3014 definitely wide enough here.
3015
42b2a986 30162012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3017
42b2a986 3018 Fix integer width and related bugs (Bug#9874).
eb106a49 3019 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3020 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3021 (string_bytes, check_sblock, allocate_string_data):
3022 (compact_small_strings, Fmake_bool_vector, make_string)
3023 (make_unibyte_string, make_multibyte_string)
3024 (make_string_from_bytes, make_specified_string)
3025 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3026 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3027 (mark_vectorlike):
3028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3029 (allocate_pseudovector):
3030 Use int, not EMACS_INT, where int is wide enough.
3031 (inhibit_garbage_collection, Fgarbage_collect):
3032 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3033 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3034 int might not be wide enough.
3035 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3036 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3037 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3038 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3039 (bidi_level_of_next_char, bidi_move_to_visually_next):
3040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3041 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3042 (Fkill_buffer, Fset_buffer_major_mode)
3043 (advance_to_char_boundary, Fbuffer_swap_text)
3044 (Fset_buffer_multibyte, overlays_at, overlays_in)
3045 (overlay_touches_p, struct sortvec, record_overlay_string)
3046 (overlay_strings, recenter_overlay_lists)
3047 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3048 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3049 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3050 (Foverlay_recenter, last_overlay_modification_hooks_used)
3051 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3052 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3053 (validate_region): Omit unnecessary test for b <= e,
3054 since that's guaranteed by the previous test.
d311d28c
PE
3055 (adjust_overlays_for_delete): Avoid pos + length overflow.
3056 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3057 (report_overlay_modification):
3058 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3059 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3060 Omit pointer cast, which isn't needed anyway, and doesn't work
3061 after the EMACS_INT -> ptrdiff_t change.
02481186 3062 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3063 * buffer.h: Adjust decls to match defn changes elsewhere.
3064 (struct buffer_text, struct buffer):
3065 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3066 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3067 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3068 not int, to avoid needless 32-bit limit on 64-bit hosts.
3069 (exec_byte_code): Use tighter memory-full test, one that checks
3070 for alloca overflow. Don't compute the address of the object just
3071 before an array, as that's not portable. Use EMACS_INT, not
3072 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3073 * callint.c (Fcall_interactively):
3074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3075 * callproc.c (call_process_kill, Fcall_process):
3076 Don't assume pid_t fits into an Emacs fixnum.
3077 (call_process_cleanup, Fcall_process, child_setup):
3078 Don't assume pid_t fits into int.
3079 (call_process_cleanup, Fcall_process, delete_temp_file)
3080 (Fcall_process_region):
3081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3082 (Fcall_process): Simplify handling of volatile integers.
3083 Use int, not EMACS_INT, where int will do.
3084 * casefiddle.c (casify_object, casify_region, operate_on_word)
3085 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3086 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3087 (casify_object): Avoid integer overflow when overallocating buffer.
3088 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3089 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3090 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3091 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3092 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3093 integers are now checked earlier. All uses replaced with XINT.
3094 (ccl_driver):
3095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3096 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3097 (ccl_driver, Fregister_code_conversion_map):
3098 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3099 (resolve_symbol_ccl_program): Check that vector header is in range.
3100 Always copy the vector, so that we can check its contents reliably
3101 now rather than having to recheck each instruction as it's being
3102 executed. Check that vector words fit in 'int'.
3103 (ccl_get_compiled_code, Fregister_ccl_program)
3104 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3105 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3106 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3107 contents are in range.
3108 (Fccl_execute_on_string): Check that status is in range.
3109 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3110 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3111 Accept and return EMACS_INT, not int, because callers can pass values
3112 out of 'int' range.
3113 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3114 (multibyte_chars_in_text, parse_str_as_multibyte)
3115 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3116 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3117 (string_escape_byte8, Fget_byte):
3118 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3119 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3120 avoid mishandling large integers.
3121 * character.h: Adjust decls to match defn changes elsewhere.
3122 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3123 (Ffind_charset_region):
3124 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3125 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3126 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3127 Don't assume fixnum fits in int.
d311d28c
PE
3128 (load_charset_map_from_vector, Fmap_charset_chars):
3129 Remove now-unnecessary CHECK_NATNUMs.
3130 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3131 Don't rely on undefined behavior with signed left shift overflow.
3132 Don't assume unsigned int fits into fixnum, or that fixnum fits
3133 into unsigned int. Don't require max_code to be a valid fixnum;
3134 that's not true for gb10830 4-byte on a 32-bit host. Allow
3135 invalid_code to be a cons, for the same reason. Require code_offset
3136 to be a character. Avoid int overflow if max_char is close
3137 to INT_MAX.
3138 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3139 this is intended anyway and avoids some undefined behavior.
3140 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3141 INDEX_TO_CODE_POINT, as that's what it expects.
3142 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3143 * charset.h (DECODE_CHAR): Return int, not unsigned;
3144 this is what was intended anyway, and it avoids undefined behavior.
3145 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3146 integer-overflow issues.
3147 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3148 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3149 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3150 * chartab.c (Fmake_char_table, Fset_char_table_range)
3151 (uniprop_get_decoder, uniprop_get_encoder):
3152 Don't assume fixnum fits in int.
3153 * cmds.c (move_point): New function, that does the gist of
3154 Fforward_char and Fbackward_char, but does so while checking
3155 for integer overflow more accurately.
c96e5d6a 3156 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3157 (Fforward_line, Fend_of_line, internal_self_insert)
3158 (internal_self_insert):
3159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3160 Fix a FIXME, by checking for integer overflow when calculating
3161 target_clm and actual_clm.
3162 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3163 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3164 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3165 (coding_alloc_by_making_gap, alloc_destination)
3166 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3167 (encode_coding_utf_16, detect_coding_emacs_mule)
3168 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3169 (detect_coding_iso_2022, decode_coding_iso_2022)
3170 (encode_invocation_designation, encode_designation_at_bol)
3171 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3172 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3173 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3174 (encode_coding_ccl, encode_coding_raw_text)
3175 (detect_coding_charset, decode_coding_charset)
3176 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3177 (produce_composition, produce_charset, produce_annotation)
3178 (decode_coding, handle_composition_annotation)
3179 (handle_charset_annotation, consume_chars, decode_coding_gap)
3180 (decode_coding_object, encode_coding_object, detect_coding_system)
3181 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3182 (code_convert_region, code_convert_string)
8f50130c
PE
3183 (Fdefine_coding_system_internal)
3184 (coding_set_source, coding_set_destination):
d311d28c
PE
3185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3186 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3187 (Fdefine_coding_system_internal):
3188 Don't assume fixnums fit in int.
3189 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3190 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3191 (Funencodable_char_position, Fcheck_coding_systems_region)
3192 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3193 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3194 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3195 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3196 Don't access memory outside of the args array.
d311d28c 3197 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3198 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3199 result of ENCODE_CHAR.
d311d28c
PE
3200 * coding.h: Adjust decls to match defn changes elsewhere.
3201 (struct coding_system):
3202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3203 * composite.c (get_composition_id, find_composition)
3204 (run_composition_function, update_compositions)
3205 (compose_text, composition_gstring_put_cache)
3206 (composition_gstring_p, composition_gstring_width)
3207 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3208 (composition_compute_stop_pos, composition_reseat_it)
3209 (composition_update_it, struct position_record)
3210 (find_automatic_composition, composition_adjust_point)
3211 (Fcomposition_get_gstring, Ffind_composition_internal):
3212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3213 (update_compositions):
3214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3215 * composite.h: Adjust decls to match defn changes elsewhere.
3216 (struct composition):
3217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3218 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3219 Do not attempt to compute the address of the object just before a
3220 buffer; this is not portable.
3221 (Faref, Faset):
3222 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3223 (Faset): Use int, not EMACS_INT, where int is wide enough.
3224 (Fstring_to_number): Don't assume fixnums fit in int.
3225 (Frem): Don't assume arg is nonnegative.
3226 * dbusbind.c (xd_append_arg): Check for integers out of range.
3227 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3228 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3229 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3230 (xd_get_connection_references): Return ptrdiff_t, not int.
3231 All uses changed.
3232 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3233 (xd_read_message_1):
3234 Use int, not unsigned, where the dbus API uses int.
3235 (Fdbus_message_internal): Don't overflow mtype.
3236 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3237 * dired.c (directory_files_internal, file_name_completion, scmp)
3238 (file_name_completion_stat):
3239 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3240 (file_name_completion): Don't overflow matchcount.
3241 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3242 * dispextern.h: Adjust decls to match defn changes elsewhere.
3243 (struct text_pos, struct glyph, struct bidi_saved_info)
3244 (struct bidi_string_data, struct bidi_it, struct composition_it)
3245 (struct it):
3246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3247 (struct display_pos, struct composition_it, struct it):
3248 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3249 * dispnew.c (increment_matrix_positions)
3250 (increment_row_positions, mode_line_string)
3251 (marginal_area_string):
3252 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3253 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3254 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3255 (duration_to_sec_usec): New function, to check for overflow better.
3256 (Fsleep_for, sit_for): Use it.
3257 * doc.c (get_doc_string, store_function_docstring):
3258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3259 (get_doc_string, Fsnarf_documentation):
3260 Use int, not EMACS_INT, where int is wide enough.
3261 (get_doc_string):
3262 Use SAFE_ALLOCA, not alloca.
3263 Check for overflow when converting EMACS_INT to off_t.
3264 * doprnt.c (doprnt):
3265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3266 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3267 Don't assume uid_t fits into fixnum.
3268 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3269 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3270 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3271 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3272 (general_insert_function)
3273 (Finsert_char, make_buffer_string, make_buffer_string_both)
3274 (update_buffer_properties, Fbuffer_substring)
3275 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3276 (Fsubst_char_in_region, check_translation)
3277 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3278 (transpose_markers, Ftranspose_regions):
3279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3280 (clip_to_bounds): Move to lisp.h as an inline function).
3281 (Fconstrain_to_field): Don't assume integers are nonnegative.
3282 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3283 (Fsubst_char_in_region, Fsave_restriction):
3284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3285 (Femacs_pid): Don't assume pid_t fits into fixnum.
3286 (lo_time): Use int, not EMACS_INT, when int suffices.
3287 (lisp_time_argument): Check for usec out of range.
3288 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3289 (Fuser_login_name, Fuser_full_name): Signal an error
3290 if a uid argument is out of range, rather than relying on
3291 undefined behavior.
c8d5c857
PE
3292 (Fformat_time_string): Remove now-unnecessary check.
3293 lisp_time_argument checks for out-of-range usec now.
243e0530 3294 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3295 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3296 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3297 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3298 (init_cmdargs, Fdump_emacs):
3299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3300 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3301 the bottom (typically) 32 bits of the fixnum.
3302 * eval.c (specpdl_size, call_debugger):
3303 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3304 (when_entered_debugger, Fbacktrace_debug):
3305 Don't assume fixnum can fit in int.
3306 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3307 the object just before a buffer; this is not portable.
3308 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3309 (grow_specpdl, unbind_to):
3310 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3311 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3312 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3313 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3314 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3315 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3317 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3318 (a_write, e_write):
3319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3320 (Fcopy_file, non_regular_nbytes, read_non_regular)
3321 (Finsert_file_contents):
3322 Use int, not EMACS_INT, where int is wide enough.
3323 (READ_BUF_SIZE): Verify that it fits in int.
3324 (Finsert_file_contents): Check that counts are in proper range,
3325 rather than assuming fixnums fit into ptrdiff_t etc.
3326 Don't assume fixnums fit into int.
125b3835 3327 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3328 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3329 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3330 (string_char_to_byte, string_byte_to_char)
3331 (string_make_multibyte, string_to_multibyte)
3332 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3333 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3334 (substring_both, Fdelete, internal_equal, Ffillarray)
3335 (Fclear_string, mapcar1)
3336 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3337 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3338 (larger_vector, make_hash_table, maybe_resize_hash_table)
3339 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3340 (Fmaphash, secure_hash):
3341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3342 (concat): Check for string index and length overflow.
3343 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3344 (Frequire):
3345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3346 (larger_vector): New API (vec, incr_min, size_max) replaces old
3347 one (vec, new_size, init). This catches size overflow.
3348 INIT was removed because it was always Qnil.
3349 All callers changed.
3350 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3351 the upper bound on a hash table index size.
3352 (make_hash_table, maybe_resize_hash_table): Use it.
3353 (secure_hash): Computer start_byte and end_byte only after
3354 they're known to be in ptrdiff_t range.
3355 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3356 (Ffont_get_glyphs, Ffont_at):
3357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3358 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3359 (Flist_fonts, Fopen_font):
3360 Don't assume fixnum can fit in int.
3361 (check_gstring): Don't assume index can fit in int.
3362 (font_match_p): Check that fixnum is a character, not a nonnegative
3363 fixnum, since the later code needs to stuff it into an int.
3364 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3365 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3366 conversion overflow issues.
3367 (Fopen_font): Check for integer out of range.
3368 (Ffont_get_glyphs): Don't assume index can fit in int.
3369 * font.h: Adjust decls to match defn changes elsewhere.
3370 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3371 integer overflow.
3372 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3373 printmax_t, where ptrdiff_t is wide enough.
3374 (Finternal_char_font):
3375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3376 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3377 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3378 (Fset_frame_position, x_set_frame_parameters)
3379 (x_set_line_spacing, x_set_border_width)
3380 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3381 Check that fixnums are in proper range for system types.
3382 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3384 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3385 Use SAFE_ALLOCA_LISP, not alloca.
3386 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3387 intptr_t is wide enough.
3388 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3389 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3390 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3391 Check for fixnum out of range.
3392 * ftfont.c (ftfont_list): Don't assume index fits in int.
3393 Check that fixnums are in proper range for system types.
3394 (ftfont_shape_by_flt):
3395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3396 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3398 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3399 Check that fixnums are in proper range for system types.
3400 * gnutls.h: Adjust decls to match defn changes elsewhere.
3401 * gtkutil.c (xg_dialog_run):
3402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3403 (update_frame_tool_bar):
3404 Check that fixnums are in proper range for system types.
3405 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3406 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3407 * indent.c (last_known_column, last_known_column_point):
3408 (current_column_bol_cache):
3409 (skip_invisible, current_column, check_display_width):
3410 (check_display_width, scan_for_column, current_column_1)
3411 (Findent_to, Fcurrent_indentation, position_indentation)
3412 (indented_beyond_p, Fmove_to_column, compute_motion):
3413 (Fcompute_motion, Fvertical_motion):
3414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3415 (last_known_column_modified): Use EMACS_INT, not int.
3416 (check_display_width):
3417 (Fcompute_motion):
3418 Check that fixnums and floats are in proper range for system types.
3419 (compute_motion): Don't assume index or fixnum fits in int.
3420 (compute_motion, Fcompute_motion):
3421 Use int, not EMACS_INT, when it is wide enough.
3422 (vmotion): Omit local var start_hpos that is always 0; that way
3423 we don't need to worry about overflow in expressions involving it.
3424 * indent.h: Adjust decls to match defn changes elsewhere.
3425 (struct position):
3426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3427 Use int, not EMACS_INT, where int is wide enough.
3428 Remove unused members ovstring_chars_done and tab_offset;
3429 all uses removed.
3430 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3431 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3432 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3433 (make_gap, copy_text, insert, insert_and_inherit)
3434 (insert_before_markers, insert_before_markers_and_inherit)
3435 (insert_1, count_combining_before, count_combining_after)
3436 (insert_1_both, insert_from_string)
3437 (insert_from_string_before_markers, insert_from_string_1)
3438 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3439 (adjust_after_replace, adjust_after_insert, replace_range)
3440 (replace_range_2, del_range, del_range_1, del_range_byte)
3441 (del_range_both, del_range_2, modify_region)
3442 (prepare_to_modify_buffer, signal_before_change)
3443 (signal_after_change, Fcombine_after_change_execute):
3444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3445 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3446 (balance_an_interval, split_interval_right, split_interval_left)
3447 (find_interval, next_interval, update_interval)
3448 (adjust_intervals_for_insertion, delete_node, delete_interval)
3449 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3450 (static_offset_intervals, offset_intervals)
3451 (merge_interval_right, merge_interval_left, make_new_interval)
3452 (graft_intervals_into_buffer, temp_set_point_both)
3453 (temp_set_point, set_point, adjust_for_invis_intang)
3454 (set_point_both, move_if_not_intangible, get_property_and_range)
3455 (get_local_map, copy_intervals, copy_intervals_to_string)
3456 (compare_string_intervals, set_intervals_multibyte_1):
3457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3458 * intervals.h: Adjust decls to match defn changes elsewhere.
3459 (struct interval):
3460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3461 * keyboard.c (this_command_key_count, this_single_command_key_start)
3462 (before_command_key_count, before_command_echo_length, echo_now)
3463 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3464 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3465 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3466 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3468 (last_non_minibuf_size, last_point_position, echo_truncate)
3469 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3470 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3471 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3472 (stuff_buffered_input):
3473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3474 (last_auto_save, command_loop_1, read_char):
3475 Use EMACS_INT, not int, to avoid integer overflow.
3476 (record_char): Avoid overflow in total_keys computation.
3477 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3478 * keyboard.h: Adjust decls to match defn changes elsewhere.
3479 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3480 (Fkey_description, Fdescribe_vector, Flookup_key):
3481 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3482 (click_position): New function, to check that positions are in range.
3483 (Fcurrent_active_maps):
3484 (describe_command):
3485 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3486 (Faccessible_keymaps, Fkey_description):
3487 (preferred_sequence_p):
3488 Don't assume fixnum can fit into int.
3489 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3490 Check for integer overflow in size calculations.
3491 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3492 avoid mishandling large integers.
3493 * lisp.h: Adjust decls to match defn changes elsewhere.
3494 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3495 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3496 (struct Lisp_Marker):
3497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3498 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3499 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3500 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3501 All callers changed.
3502 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3503 Assume the arg has valid form, since it always does.
3504 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3505 unsigned integer system type.
3506 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3507 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3509 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3510 (duration_to_sec_usec): New decl.
3511 * lread.c (read_from_string_index, read_from_string_index_byte)
3512 (read_from_string_limit, readchar, unreadchar, openp)
3513 (read_internal_start, read1, oblookup):
3514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3515 (Fload, readevalloop, Feval_buffer, Feval_region):
3516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3517 (openp): Check for out-of-range argument to 'access'.
3518 (read1): Use int, not EMACS_INT, where int is wide enough.
3519 Don't assume fixnum fits into int.
6efdadfd 3520 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3521 (read_filtered_event): Use duration_to_sec_usec
3522 to do proper overflow checking on durations.
d311d28c
PE
3523 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3524 in size calculation.
3525 (Fexecute_kbd_macro):
3526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3527 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3528 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3529 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3530 (set_marker_both, set_marker_restricted_both, marker_position)
3531 (marker_byte_position, Fbuffer_has_markers_at):
3532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3533 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3534 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3535 It now merely ensures that the menu is large enough, without
3536 necessarily growing it, as this avoids some integer overflow issues.
3537 All callers changed.
3538 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3540 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3541 Use SAFE_ALLOCA_LISP, not alloca.
3542 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3543 to EMACS_INT. Check that fixnums are in proper range for system types.
3544 * minibuf.c (minibuf_prompt_width, string_to_object)
3545 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3546 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3547 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3548 (get_minibuffer, read_minibuf_unwind):
3549 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3550 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3551 this simplifies overflow checking. All callers changed.
3552 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3553 (Ftest_completion):
3554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3555 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3556 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3557 Check that fixnums are in proper range for system types.
3558 (Fx_create_frame, Fx_show_tip):
3559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3560 * nsfont.m (ns_findfonts, nsfont_list_family):
3561 Don't assume fixnum fits in long.
3562 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3564 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3565 wide enough.
17fdb222 3566 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3568 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3569 (PRINTDECLARE, PRINTPREPARE):
3570 (strout, print_string):
3571 (print, print_preprocess, print_check_string_charset_prop)
3572 (print_object):
3573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3574 (PRINTDECLARE):
3575 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3577 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3578 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3579 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3580 (print_error_message): Use SAFE_ALLOCA, not alloca.
3581 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3582 (print_depth, new_backquote_output, print_number_index):
3583 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3584 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3585 (Fset_process_window_size, Fformat_network_address)
3586 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3587 (sigchld_handler):
d311d28c 3588 Check that fixnums are in proper range for system types.
d44287d4 3589 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3590 Check for process-ids out of pid_t range rather than relying on
3591 undefined behavior.
e4d81efc 3592 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3593 (Fformat_network_address, read_process_output, send_process)
3594 (Fprocess_send_region, status_notify):
3595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3596 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3597 (wait_reading_process_output, read_process_output, exec_sentinel):
3598 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3599 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3600 (Faccept_process_output): Use duration_to_sec_usec to do proper
3601 overflow checking on durations.
dde14581
PE
3602 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3603 Don't assume pid_t fits in int.
02481186
PE
3604 * process.h (struct Lisp_Process): Members tick and update_tick
3605 are now of type EMACS_INT, not int.
b62b53e8
PE
3606 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3607 configured --with-wide-int.
d311d28c
PE
3608 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3609 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3610 * search.c (looking_at_1, string_match_1):
3611 (fast_string_match, fast_c_string_match_ignore_case)
3612 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3613 (scan_newline, find_before_next_newline, search_command)
3614 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3615 (set_search_regs, wordify):
3616 (Freplace_match):
3617 (Fmatch_data):
3618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3619 (string_match_1, search_buffer, set_search_regs):
3620 (Fmatch_data):
3621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3622 (wordify): Check for overflow in size calculation.
3623 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3624 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3625 Check that fixnums are in proper range for system types.
3626 * sound.c (struct sound_device)
3627 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3629 (Fplay_sound_internal):
3630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3631 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3632 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3633 (Fparse_partial_sexp):
3634 Don't assume fixnums can fit in int.
3635 (struct lisp_parse_state, find_start_pos, find_start_value)
3636 (find_start_value_byte, find_start_begv)
3637 (update_syntax_table, char_quoted, dec_bytepos)
3638 (find_defun_start, prev_char_comend_first, back_comment):
3639 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3640 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3642 (Finternal_describe_syntax_value): Check that match_lisp is a
3643 character, not an integer, since the code stuffs it into int.
3644 (scan_words, scan_sexps_forward):
3645 Check that fixnums are in proper range for system types.
3646 (Fforward_word):
3647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3648 (scan_sexps_forward):
3649 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3650 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3651 * syntax.h: Adjust decls to match defn changes elsewhere.
3652 (struct gl_state_s):
3653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3654 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3655 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3656 * sysdep.c (wait_for_termination_1, wait_for_termination)
3657 (interruptible_wait_for_termination, mkdir):
3658 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3659 (emacs_read, emacs_write):
3660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3661 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3662 and double all fit in int.
d311d28c
PE
3663 * term.c (set_tty_color_mode):
3664 Check that fixnums are in proper range for system types.
3665 * termhooks.h (struct input_event):
3666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3667 * textprop.c (validate_interval_range, interval_of)
3668 (Fadd_text_properties, set_text_properties_1)
3669 (Fremove_text_properties, Fremove_list_of_text_properties)
3670 (Ftext_property_any, Ftext_property_not_all)
3671 (copy_text_properties, text_property_list, extend_property_ranges)
3672 (verify_interval_modification):
3673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3674 (Fnext_single_char_property_change)
3675 (Fprevious_single_char_property_change):
3676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3677 (copy_text_properties):
3678 Check for integer overflow in index calculation.
d311d28c
PE
3679 * undo.c (last_boundary_position, record_point, record_insert)
3680 (record_delete, record_marker_adjustment, record_change)
3681 (record_property_change):
3682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3683 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3684 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3685 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3686 (Fx_hide_tip, Fx_file_dialog):
3687 * w32menu.c (set_frame_menubar):
3688 Use ptrdiff_t, not int, for consistency with rest of code.
3689 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3690 (select_window, Fdelete_other_windows_internal)
3691 (window_scroll_pixel_based, window_scroll_line_based)
3692 (Frecenter, Fset_window_configuration):
3693 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3694 (Fset_window_hscroll, run_window_configuration_change_hook)
3695 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3696 (Fscroll_other_window, Frecenter):
d311d28c
PE
3697 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3698 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3699 Don't assume fixnum fits in int.
3700 (Fset_window_scroll_bars):
3701 Check that fixnums are in proper range for system types.
3702 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3703 (string_pos, c_string_pos, number_of_chars, init_iterator)
3704 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3705 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3706 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3707 (face_before_or_after_it_pos, handle_invisible_prop)
3708 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3709 (display_prop_intangible_p, string_buffer_position_lim)
3710 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3711 (get_overlay_strings_1, get_overlay_strings)
3712 (iterate_out_of_display_property, forward_to_next_line_start)
3713 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3714 (get_next_display_element, set_iterator_to_next)
3715 (get_visually_first_element, compute_stop_pos_backwards)
3716 (handle_stop_backwards, next_element_from_buffer)
3717 (move_it_in_display_line_to, move_it_in_display_line)
3718 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3719 (add_to_log, message_dolog, message_log_check_duplicate)
3720 (message2, message2_nolog, message3, message3_nolog
3721 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3722 (current_message_1, truncate_echo_area, truncate_message_1)
3723 (set_message, set_message_1, store_mode_line_noprop)
3724 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3725 (text_outside_line_unchanged_p, check_point_in_composition)
3726 (reconsider_clip_changes)
3727 (redisplay_internal, set_cursor_from_row, try_scrolling)
3728 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3729 (redisplay_window, find_last_unchanged_at_beg_row)
3730 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3731 (trailing_whitespace_p, find_row_edges, display_line)
3732 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3733 (display_mode_element, store_mode_line_string)
3734 (pint2str, pint2hrstr, decode_mode_spec)
3735 (display_count_lines, display_string, draw_glyphs)
3736 (x_produce_glyphs, x_insert_glyphs)
3737 (rows_from_pos_range, mouse_face_from_buffer_pos)
3738 (fast_find_string_pos, mouse_face_from_string_pos)
3739 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3741 (safe_call, init_from_display_pos, handle_fontified_prop)
3742 (handle_single_display_spec, load_overlay_strings)
3743 (with_echo_area_buffer, setup_echo_area_for_printing)
3744 (display_echo_area, echo_area_display)
3745 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3746 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3747 (redisplay_window, dump_glyph_row, display_mode_line)
3748 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3749 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3751 (handle_single_display_spec, build_desired_tool_bar_string)
3752 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3753 (get_specified_cursor_type):
3754 Check that fixnums are in proper range for system types.
3755 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3756 (Flookup_image_map):
3757 Don't assume fixnums fit in int.
3758 (compare_overlay_entries):
3759 Avoid mishandling comparisons due to subtraction overflow.
3760 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3761 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3762 (handle_tool_bar_click):
3763 Use int, not unsigned, since we prefer signed and the signedness
3764 doesn't matter here.
3765 (get_next_display_element, next_element_from_display_vector):
3766 Use int, not EMACS_INT, when int is wide enough.
3767 (start_hourglass): Use duration_to_sec_usec to do proper
3768 overflow checking on durations.
3769 * xfaces.c (Fbitmap_spec_p):
3770 Check that fixnums are in proper range for system types.
3771 (compare_fonts_by_sort_order):
3772 Avoid mishandling comparisons due to subtraction overflow.
3773 (Fx_family_fonts, realize_basic_faces):
3774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3775 (Fx_family_fonts):
3776 Don't assume fixnum fits in int.
3777 Use SAFE_ALLOCA_LISP, not alloca.
3778 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3779 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3780 (face_at_buffer_position, face_for_overlay_string)
3781 (face_at_string_position):
3782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3783 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3784 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3785 (Fx_show_tip):
3786 Check that fixnums are in proper range for system types.
3787 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3788 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3790 (Fx_change_window_property): Don't assume fixnums fit in int.
3791 * xfont.c (xfont_chars_supported):
3792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3793 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3794 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3795 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3796 * xml.c (parse_region):
3797 * xrdb.c (magic_file_p):
3798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3799 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3800 (x_get_local_selection, x_reply_selection_request)
3801 (x_handle_selection_request, wait_for_property_change):
3802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3803 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3804 short is wide enough.
3805 (x_send_client_event): Don't assume fixnum fits in int.
3806 * xterm.c (x_x_to_emacs_modifiers):
3807 Don't assume EMACS_INT overflows nicely into int.
3808 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3809 may come from Lisp.
3810 (handle_one_xevent): NATNUMP can eval its arg twice.
3811 (x_connection_closed):
3812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3813 * xterm.h: Adjust decls to match defn changes elsewhere.
3814 (struct scroll_bar): Use struct vectorlike_header
3815 rather than rolling our own approximation.
3816 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3817
c6574eb5
GM
38182012-05-25 Glenn Morris <rgm@gnu.org>
3819
3820 * lisp.mk (lisp): Update for more files being compiled now.
3821
e8d32c7e
SM
38222012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3823
48def666
SM
3824 * lread.c: Remove `read_pure' which makes no difference.
3825 (read_pure): Remove var.
3826 (unreadpure): Remove function.
3827 (readevalloop): Don't call read_list with -1 flag.
3828 (read1, read_vector): Don't test read_pure any more.
3829 (read_list): Simplify.
3830
e8d32c7e
SM
3831 * fileio.c, character.h: Minor style tweaks.
3832
4b2addb7
DA
38332012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3834
3835 * window.h (clip_changed): Remove useless declaration.
3836
584461b2
JB
38372012-05-22 Juanma Barranquero <lekktu@gmail.com>
3838
3839 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3840 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3841
34374650
PE
38422012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3843
3844 Remove src/m/*.
3845 This directory predates autoconf and is no longer needed nowadays.
3846 Move its few remaining bits of functionality to where they're needed.
3847 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3848 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3849 * m/template.h: Remove.
3850 * Makefile.in (M_FILE): Remove. All uses removed.
3851 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3852 * lisp.h (USE_LSB_TAG):
3853 * mem-limits.h (EXCEEDS_LISP_PTR):
3854 Use VAL_MAX, not VALBITS, in #if.
3855 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3856 (EMACS_UINT): Define unconditionally now.
3857 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3858 (BITS_PER_EMACS_INT): New constants, replacing
3859 what used to be in config.h, but not useful in #if.
3860 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3861 define them any more.
3862 (VAL_MAX): New macro.
3863 (VALMASK): Use it.
3864 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3865 BITS_PER_EMACS_INT, in #if.
3866 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3867 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3868 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3869 * s/ms-w32.h (DATA_START):
3870 Move here from removed file m/intel386.h.
3871 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3872 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3873
261cb4bb
PE
38742012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3875
3876 Assume C89 or later.
3877 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3878 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3879 (xrealloc):
3880 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3881 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3882 * textprop.c, tparam.c (NULL): Remove.
3883 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3884 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3885 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3886 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3887 * xterm.c (input_signal_count): Assume volatile works.
3888
ff23cd9f
KB
38892012-05-21 Ken Brown <kbrown@cornell.edu>
3890
3891 * xgselect.c (xg_select): Fix first argument in call to 'select'
3892 (bug#11508).
3893
1b170bc6
KB
38942012-05-20 Ken Brown <kbrown@cornell.edu>
3895
3896 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3897 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3898
b2f4d39f
KB
38992012-05-19 Ken Brown <kbrown@cornell.edu>
3900
3901 * xfns.c (x_in_use): Remove `static' qualifier.
3902 * xterm.h (x_in_use): Declare.
3903 * xgselect.c: Include xterm.h.
3904 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3905 and `display_arg' (bug#9754).
3906
003fdae2
PE
39072012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3908
9232a6d9
PE
3909 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3910
003fdae2
PE
3911 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3912 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3913
784b56e2
EZ
39142012-05-18 Eli Zaretskii <eliz@gnu.org>
3915
3916 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3917
3918 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3919 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3920
3921 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3922 reference to image_cache->refcount.
3923 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3924
a0a79cde
JL
39252012-05-17 Juri Linkov <juri@jurta.org>
3926
3927 * search.c (Fword_search_regexp, Fword_search_backward)
3928 (Fword_search_forward, Fword_search_backward_lax)
3929 (Fword_search_forward_lax): Move functions to isearch.el
3930 (bug#10145, bug#11381).
3931
b0572523
PE
39322012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3933
3934 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3935
9660f5fc
SM
39362012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3937
3938 * lread.c (init_obarray): Declare Qt and Qnil as special.
3939
4374de83
GM
39402012-05-14 Glenn Morris <rgm@gnu.org>
3941
3942 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3943 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3944
dc44c39a
PE
39452012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3946
078c97cb
PE
3947 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3948
dc44c39a
PE
3949 * unexaix.c: Port to more-recent AIX compilers.
3950 (report_error, report_error_1, make_hdr, copy_sym)
3951 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3952 Make arguments const char *, not char *, to avoid violations of C
3953 standard and to fix some AIX warnings reported by Gilles Pion.
3954
e18afed7 39552012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3956
3957 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3958 already have overlays loaded.
3959 (handle_single_display_spec): Before returning without displaying
3960 fringe bitmap, synchronize the bidi iterator with the main display
3961 iterator, by calling iterate_out_of_display_property.
3962 (iterate_out_of_display_property): Detect buffer iteration by
3963 testing that it->string is a Lisp string.
3964 (get_next_display_element): When the current object is exhausted,
3965 and there's something on it->stack, call set_iterator_to_next to
3966 proceed with what's on the stack, instead of returning zero.
3967 (set_iterator_to_next): If called at the end of a Lisp string,
3968 proceed to consider_string_end without incrementing string
3969 position. Don't increment display vector index past the end of
3970 the display vector. (Bug#11417)
c8fb9dc6
EZ
3971 (pos_visible_p): Don't report a position visible when move_it_to
3972 stopped at the last line of window, which happens to be scanned
3973 backwards by the bidi iteration. (Bug#11464)
ac268e67 3974
e18afed7 39752012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3976
3977 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3978 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3979 are on a TTY, and thus unable to display on the fringes.
3980 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3981 so we need to signal to the caller that this is a "replacing"
3982 display spec. This fixes display when the spec is invalid or we
3983 are on a TTY.
3984
e18afed7 39852012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3986
3987 * unexaix.c (make_hdr): Fix typo in prototype.
3988 This bug broke the build on AIX. Problem reported by Gilles Pion.
3989
9d0a235a
MA
39902012-05-14 Michael Albinus <michael.albinus@gmx.de>
3991
3992 * keyboard.c (kbd_buffer_get_event): Read special events also in
3993 batch mode. (Bug#11415)
3994
9e6b06ed
GM
39952012-05-12 Glenn Morris <rgm@gnu.org>
3996
3997 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3998
c1a1d7a3
EZ
39992012-05-12 Eli Zaretskii <eliz@gnu.org>
4000
4001 * lisp.mk (lisp): Add newcomment.elc.
4002
3fe7cdc8
GM
40032012-05-12 Glenn Morris <rgm@gnu.org>
4004
4005 * Makefile.in (MKDIR_P): New, set by configure.
4006 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4007
53f7d2c0
PE
40082012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4009
4010 Remove unused function hourglass_started.
4011 * dispextern.h (hourglass_started):
4012 * w32fns.c (hourglass_started):
4013 * xdisp.c (hourglass_started): Remove.
4014
75aafb17
JB
40152012-05-10 Juanma Barranquero <lekktu@gmail.com>
4016
4017 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4018 Update dependencies.
4019
12959e8e
PE
40202012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4021
97107e2e
PE
4022 * xgselect.c (xg_select): Put maxfds+1 into a var.
4023 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4024
12959e8e
PE
4025 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4026
836d29b3
DA
40272012-05-10 Dave Abrahams <dave@boostpro.com>
4028
4029 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4030 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4031
5cb67954
MA
40322012-05-09 Michael Albinus <michael.albinus@gmx.de>
4033
4034 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4035 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4036 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4037 Initialize xd_registered_buses.
4038
3478ec45
PE
40392012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4040
b263a6b0
PE
4041 Untag more efficiently if USE_LSB_TAG.
4042 This is based on a proposal by YAMAMOTO Mitsuharu in
4043 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4044 For an admittedly artificial (nth 8000 longlist) benchmark on
4045 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4046 Emacs's overall text size by 1%.
4047 * lisp.h (XUNTAG): New macro.
4048 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4049 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4050 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4051 * eval.c (Fautoload):
4052 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4053 * frame.h (XFRAME): Use XUNTAG.
4054
3478ec45
PE
4055 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4056 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4057 Remove unportable assumptions about print widths of types like
4058 dbus_uint32_t.
4059 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4060 intptr_t when converting between pointer and integer, to avoid GCC
4061 warnings about wrong width.
4062
666b903b 40632012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4064
4065 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4066 stack for each reader_thread, instead of defaulting to 8MB
4067 determined by the linker. This avoids failures in creating
4068 subprocesses on Windows 7, see the discussion in this thread:
4069 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4070
b120cc17
JC
40712012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4072
4073 Fix up display of the *Minibuf-0* buffer in the mini window.
4074 * keyboard.c (read_char): Don't clear the echo area if there's no
4075 message to clear.
4076 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4077 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4078
9a4b36f8
MA
40792012-05-07 Michael Albinus <michael.albinus@gmx.de>
4080
4081 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4082 batch mode.
4083
e5f9458f
CY
40842012-05-06 Chong Yidong <cyd@gnu.org>
4085
4086 * lisp.mk (lisp): Update.
4087
eceeb5fc 40882012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4089
4090 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4091
71873e2b
SM
40922012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4093
4094 * data.c (PUT_ERROR): New macro.
4095 (syms_of_data): Use it. Add new error type `user-error'.
4096 * undo.c (user_error): New function.
4097 (Fprimitive_undo): Use it.
4098 * print.c (print_error_message): Adjust print style for `user-error'.
4099 * keyboard.c (user_error): New function.
4100 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4101
ab0fa4e4
PE
41022012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4103
4104 Do not limit current-time-string to years 1000..9999.
4105 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4106 (Fcurrent_time_string): Support any year that is supported by the
4107 underlying localtime representation. Don't use asctime, as it
4108 has undefined behavior for years outside the range -999..9999.
4109
7ed806a7
PE
41102012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4111
4112 Fix race conditions involving setenv, gmtime, localtime, asctime.
4113 Without this fix, interrupts could mess up code that uses these
4114 nonreentrant functions, since setting TZ invalidates existing
4115 tm_zone or tzname values, and since most of these functions return
4116 pointers to static storage.
4117 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4118 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4119 Grow the critical sections to include not just invoking
4120 localtime/gmtime, but also accessing these functions' results
4121 including their tm_zone values if any, and any related TZ setting.
4122 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4123 so that the struct tm is saved in the critical section.
4124 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4125 motivated by the fact that memory allocation needs to be outside
4126 the critical section.
4127
0c16dfed
DA
41282012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4129
4130 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4131 with RESET_INTERVAL.
4132
4133 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4134 Remove duplicated buffer name initialization.
4135
3f83ace8
JM
41362012-05-02 Jim Meyering <jim@meyering.net>
4137
4138 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4139
c7b8541e
JM
4140 * xfns.c (x_window): Use xstrdup (Bug#11375).
4141
90207a15 41422012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4143
4144 * xdisp.c (pos_visible_p): If already at a newline from the
4145 display string before the 'while' loop, don't walk back the glyphs
4146 from it3.glyph_row. Solves assertion violation when the display
4147 string begins with a newline (egg.el). (Bug#11367)
4148
b593d6a9
AH
41492012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4150
4151 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4152 Move to simple.el.
4153
4737362e
GM
41542012-05-01 Glenn Morris <rgm@gnu.org>
4155
99cf43f9
GM
4156 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4157 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4158 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4159 All were removed before 23.1.
4160
9311dcff
GM
4161 * dispnew.c: Remove HAVE_LIBNCURSES test;
4162 it is always true on relevant platforms.
4163
4d5c6349
GM
4164 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4165 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4166
4737362e
GM
4167 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4168
74dd3a6b
AS
41692012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4170
4171 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4172 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4173 Remove.
4174
13c379ee
PE
41752012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4176
4177 Do not avoid creating empty evaporating overlays (Bug#9642).
4178 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4179 That is, do not delete an evaporating overlay if it becomes
4180 empty after its bounds are adjusted to fit within its buffer.
4181 This fix caused other problems, and I'm reverting it until we get
4182 to the bottom of them.
4183
a8e7d6d7 41842012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4185
4186 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4187
a8e7d6d7 41882012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4189
4190 * xdisp.c (pos_visible_p): If the window start position is beyond
4191 ZV, start the display from buffer beginning. Prevents assertion
4192 violation in init_iterator when the minibuffer window is scrolled
4193 via the scroll bar.
4194
4195 * window.c (window_scroll_pixel_based): Likewise.
4196
a8e7d6d7 41972012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4198
4199 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4200
a8e7d6d7 42012012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4202
4203 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4204 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4205
a8e7d6d7 42062012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4207
b593d6a9
AH
4208 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4209 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4210
1c6900d9
EZ
42112012-04-26 Eli Zaretskii <eliz@gnu.org>
4212
4c3fa1d9
EZ
4213 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4214 display element, check also the underlying string or buffer
4215 character. (Bug#11341)
4216
1c6900d9
EZ
4217 * w32menu.c: Include w32heap.h.
4218 (add_menu_item): If the call to AppendMenuW (via
4219 unicode_append_menu) fails, disable Unicode menus only if we are
4220 running on Windows 9X/Me.
4221
42bf8205
AS
42222012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4223
4224 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4225 (xgetint): Add missing shift for LSB tags.
4226
b1bac16e
MR
42272012-04-24 Martin Rudalics <rudalics@gmx.at>
4228
4229 * keyboard.c (read_char): Don't wipe echo area for select window
4230 events: These might get delayed via `mouse-autoselect-window'
4231 (Bug#11304).
4232
d69621cc
JB
42332012-04-24 Juanma Barranquero <lekktu@gmail.com>
4234
4235 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4236 manipulation of :loaded-from data.
4237
02fd101b
JB
42382012-04-23 Juanma Barranquero <lekktu@gmail.com>
4239
4240 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4241 now a cons (bug#11311).
4242
888bec30
PE
42432012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4244
89a438bd
PE
4245 Do not create empty overlays with the evaporate property (Bug#9642).
4246 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4247 if it becomes empty after its bounds are adjusted to fit within
4248 its buffer. Without this fix, in a nonempty buffer (let ((o
4249 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4250 yields an empty overlay that has the evaporate property, which is
4251 not supposed to happen.
4252
1068fe4d
PE
4253 Fix minor GTK3 problems found by static checking.
4254 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4255 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4256 (struct _EmacsFixedClass, emacs_fixed_get_type):
4257 Move decls here from emacsgtkfixed.h, since they needn't be public.
4258 (emacs_fixed_get_type): Now static.
4259 (emacs_fixed_class_init): Omit unused local.
4260 (emacs_fixed_child_type): Remove; unused.
4261 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4262 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4263 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4264 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4265 (EMACS_FIXED_GET_CLASS): Remove; unused.
4266 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4267
888bec30
PE
4268 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4269 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4270
de85e130
PE
42712012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4272
d0baac98 4273 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4274 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4275 (__malloc_size_t, __malloc_ptrdiff_t):
4276 Remove. All uses removed, replaced by the definiens if needed,
4277 since we can assume C89 or better now.
4278 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4279 (protect_malloc_state, align, get_contiguous_space)
4280 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4281 (malloc_atfork_handler_child, malloc_enable_thread)
4282 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4283 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4284 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4285 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4286 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4287 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4288 Define using prototypes, not old style.
4289 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4290 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4291 (align): Don't assume that signed integer overflow wraps around.
4292 Omit unused local var.
4293 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4294 (_free_internal_nolock, memalign, mallochook, reallochook):
4295 Omit no-longer-needed casts.
4296 (valloc): Use getpagesize, not __getpagesize.
4297 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4298 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4299
de85e130
PE
4300 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4301
dcbf5805
MA
43022012-04-22 Michael Albinus <michael.albinus@gmx.de>
4303
4304 Move functions from C to Lisp. Make non-blocking method calls
4305 the default. Implement further D-Bus standard interfaces.
4306
4307 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4308 (QCdbus_request_name_allow_replacement)
4309 (QCdbus_request_name_replace_existing)
4310 (QCdbus_request_name_do_not_queue)
4311 (QCdbus_request_name_reply_primary_owner)
4312 (QCdbus_request_name_reply_in_queue)
4313 (QCdbus_request_name_reply_exists)
4314 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4315 (QCdbus_registered_serial, QCdbus_registered_method)
4316 (QCdbus_registered_signal): New Lisp objects.
4317 (XD_DEBUG_MESSAGE): Use sizeof.
4318 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4319 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4320 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4321 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4322 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4323 (xd_signature, xd_append_arg): Allow float for integer types.
4324 (xd_get_connection_references): New function.
b593d6a9
AH
4325 (xd_get_connection_address): Rename from xd_initialize.
4326 Return cached address.
dcbf5805
MA
4327 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4328 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4329 level.
4330 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4331 Return number of refcounts.
dcbf5805
MA
4332 (Fdbus_get_unique_name): Make stronger parameter check.
4333 (Fdbus_message_internal): New defun.
4334 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4335 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4336 (Fdbus_send_signal, Fdbus_register_service)
4337 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4338 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4339 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4340 (Vdbus_compiled_version, Vdbus_runtime_version)
4341 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4342 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4343 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4344 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4345 Adapt docstring.
dcbf5805 4346
52828e02
PE
43472012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4348
da05bc4c
PE
4349 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4350 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4351 Do not assume ptrdiff_t is the same width as 'int'.
4352
52828e02
PE
4353 * alloc.c: Handle unusual debugging option combinations.
4354 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4355 since the two debugging options are incompatible.
4356 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4357 is defined.
4358 (mem_init, mem_insert, mem_insert_fixup):
4359 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4360 (NEED_MEM_INSERT): Remove; no longer needed.
4361
f01769f9
LL
43622012-04-22 Leo Liu <sdl.web@gmail.com>
4363
4364 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4365
5790543d
PE
43662012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4367
4368 * sysdep.c [__FreeBSD__]: Minor cleanups.
4369 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4370 Use Emacs indenting style more consistently. Avoid some casts.
4371 Use 'double' consistently rather than mixing 'float' and 'double'.
4372
b91b7e4d
EW
43732012-04-21 Eduard Wiebe <usenet@pusto.de>
4374
b593d6a9
AH
4375 * sysdep.c (list_system_processes, system_process_attributes):
4376 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4377
6114eb15
AS
43782012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4379
4380 * lisp.mk (lisp): Update.
4381
2f38dff7
PE
43822012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4383
4384 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4385 It is never used otherwise.
4386
4ae29f89
SM
43872012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4388
4389 * print.c (print_preprocess): Only check print_depth if print-circle
4390 is nil.
4391 (print_object): Check for cycles even when print-circle is nil and
4392 print-gensym is t, but only check print_depth if print-circle is nil.
4393
f30d612a
CY
43942012-04-20 Chong Yidong <cyd@gnu.org>
4395
4396 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4397 set the status to "failed" and ensure that sentinel is run.
4398
c07a4c0b 43992012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4400
4401 * process.c (Fset_process_inherit_coding_system_flag)
4402 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4403 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4404
c07a4c0b 44052012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4406
4407 * xdisp.c (string_buffer_position_lim): Limit starting position to
4408 BEGV.
4409 (set_cursor_from_row): If called for a mode-line or header-line
4410 row, return zero immediately.
4411 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4412 farther than the first row after the header line, if any.
4413 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4414 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4415
c07a4c0b 44162012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4417
4ae29f89
SM
4418 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4419 (bug#11238).
ad3a2b41 4420
c07a4c0b 44212012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 44222012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4423
4424 configure: new option --enable-gcc-warnings (Bug#11207)
4425 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4426 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4427 (ALL_CFLAGS): Use new macros rather than old.
4428 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4429 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4430 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4431 -Wunused-result, -Wunused-variable. This should go away once
4432 the Emacs and Gnulib regex code is merged.
4433 (xmalloc, xrealloc): Now static.
4434
aba027e8
PE
44352012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4436
4437 * dired.c (Fsystem_groups): Remove unused local.
4438
e5a36063
GM
44392012-04-17 Glenn Morris <rgm@gnu.org>
4440
4441 * dired.c (Fsystem_users): Doc fix.
4442
316411f0
DA
44432012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4444
4445 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4446 (syms_of_dired): Add them.
4447
9426aba4
PE
44482012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4449
b62a57be
PE
4450 Fix minor alloc.c problems found by static checking.
4451 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4452 New extern decls, to avoid calling undeclared functions.
4453 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4454 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4455 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4456 (NEED_MEM_INSERT): New macro.
4457 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4458 Remove one incorrect comment and fix another.
b62a57be 4459
3539f31f
PE
4460 Fix minor ralloc.c problems found by static checking.
4461 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4462 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4463 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4464 (r_alloc_sbrk): Now static.
4465
a041960a
PE
4466 Improve ralloc.c interface checking.
4467 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4468 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4469 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4470 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4471 [REL_ALLOC]: ... to here, to check interface.
4472 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4473 Remove decls. This fixes an "It stinks!".
4474
9426aba4
PE
4475 * alloc.c (which_symbols): Fix alignment issue / type clash.
4476
d55c12ed
AS
44772012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4478
4479 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4480 (struct Lisp_Misc_Any): Likewise.
4481 (struct Lisp_Free): Likewise.
4482 * alloc.c (union aligned_Lisp_Symbol): Define.
4483 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4484 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4485 (union aligned_Lisp_Misc): Define.
4486 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4487 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4488 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4489
b948ce8b
PE
44902012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4491
4492 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4493 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4494 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4495 * s/netbsd.h, s/sol2-6.h:
4496 Remove definition of GC_MARK_STACK, since the default now works.
4497 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4498 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4499 no longer the default.
4500 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4501
35dc09a1 45022012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4503
35dc09a1
GM
4504 * lread.c (lisp_file_lexically_bound_p):
4505 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4506
35dc09a1
GM
45072012-04-14 Eli Zaretskii <eliz@gnu.org>
4508
4509 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4510 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4511
45122012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4513
4514 * nsterm.m (constrainFrameRect): Always constrain when there is only
4515 one screen (Bug#10962).
4516
bcd86815
KB
45172012-04-13 Ken Brown <kbrown@cornell.edu>
4518
4519 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4520
c25df26e
RT
45212012-04-13 Reuben Thomas <rrt@sc3d.org>
4522
4523 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4524
0fc59f1e
DC
45252012-04-11 Daniel Colascione <dancol@dancol.org>
4526
4527 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4528 against is gone. It's better to use vfork now so that when Cygwin
4529 gains a new, working vfork, we use it automatically (bug#10398).
4530
de8c03dc
SM
45312012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4532
4533 * window.c (save_window_save): Obey window-point-insertion-type.
4534
2f097256
GM
45352012-04-11 Glenn Morris <rgm@gnu.org>
4536
4537 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4538
453b951e
SM
45392012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4540
4541 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4542
75f1671a 45432012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4544
4545 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4546 (force_quit_count): New var.
4547 (handle_interrupt): Use it.
4548
2a8ce227
JB
45492012-04-10 Juanma Barranquero <lekktu@gmail.com>
4550
4551 * w32.c (w32_delayed_load): Record the full path of the library
4552 being loaded (bug#10424).
4553
935396c0
GM
45542012-04-09 Glenn Morris <rgm@gnu.org>
4555
05920a43
GM
4556 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4557 not just in the obarray, before snarfing them. (Bug#11036)
4558
935396c0
GM
4559 * Makefile.in ($(leimdir)/leim-list.el):
4560 Pass EMACS rather than BUILT_EMACS.
4561
a18ecafa
TZ
45622012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4563
4564 * process.c (make_process):
4565 * process.h: Add integer `gnutls_handshakes_tried' member to
4566 process struct.
4567
6bbef4e5
JC
4568 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4569 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4570
4571 * gnutls.c (gnutls_log_function2i): Convenience log function.
4572 (emacs_gnutls_read): Use new log functions,
4573 `gnutls_handshakes_tried' process member, and
4574 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4575 attempts per process (connection).
4576
b4d3bc10
CY
45772012-04-09 Chong Yidong <cyd@gnu.org>
4578
4579 * eval.c (Fuser_variable_p, user_variable_p_eh)
4580 (lisp_indirect_variable): Functions deleted.
4581 (Fdefvar): Caller changed.
4582
4583 * callint.c (Finteractive, Fcall_interactively):
4584 * minibuf.c (Fread_variable): Callers changed.
4585
70f4d973
EZ
45862012-04-09 Eli Zaretskii <eliz@gnu.org>
4587
4588 * xdisp.c (set_cursor_from_row): If the display string appears in
4589 the buffer at position that is closer to point than the position
4590 after the display string, display the cursor on the first glyph of
4591 the display string. Fixes cursor display when a 'display' text
4592 property immediately follows invisible text. (Bug#11094)
4593
cb3c2e3e
PE
45942012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4595
4596 composite.c: use 'double' consistently
4597 * composite.c (get_composition_id): Use 'double' consistently
4598 instead of converting 'float' to 'double' and vice versa; this is
4599 easier to understand and avoids a GCC warning.
4600
fd06db5d
GM
46012012-04-09 Glenn Morris <rgm@gnu.org>
4602
50fe702a
GM
4603 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4604 preparation for dumping it with emacs. (Bug#4789)
4605 (leimdir): New variable.
4606 ($(leimdir)/leim-list.el): New rule.
4607 (emacs$(EXEEXT)): Depend on leim-list.el.
4608
fd06db5d
GM
4609 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4610 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4611 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4612
55c131ee
AS
46132012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4614
4615 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4616 proper alignment.
4617
9209588f
JB
46182012-04-07 Juanma Barranquero <lekktu@gmail.com>
4619
4620 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4621 Remove unused local variable.
4622
e3fb2efb
PE
46232012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4624
4625 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4626 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4627 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4628 objects, as mark_maybe_pointer will catch them otherwise.
4629 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4630 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4631
b5385551
PE
46322012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4633
4634 Fix typo that broke non-Windows builds.
4635 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4636
9078ead6
EZ
46372012-04-07 Eli Zaretskii <eliz@gnu.org>
4638
4639 Support building on MS-Windows with libxml2.
4640
4641 * makefile.w32-in (OBJ2): Add xml.$(O).
4642 (GLOBAL_SOURCES): Add xml.c.
4643 ($(BLD)/xml.$(O)): New dependency list.
4644
4645 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4646 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4647 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4648 [!WINDOWSNT]: New macros.
4649 (init_libxml2_functions, libxml2_loaded_p): New functions.
4650 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4651 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4652 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4653 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4654 linked in).
6bbef4e5
JC
4655 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4656 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4657 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4658
4659 * emacs.c: Don't include libxml/parser.h.
4660 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4661 xmlCleanupParser directly.
4662
4663 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4664
3811fdf3
EZ
46652012-04-07 Eli Zaretskii <eliz@gnu.org>
4666
4667 * indent.c (Fvertical_motion): If there is a display string at
4668 point, use it.vpos to compute how many lines to backtrack after
4669 move_it_to point. (Bug#11133)
4670
2f8e16b2
EZ
46712012-04-06 Eli Zaretskii <eliz@gnu.org>
4672
4673 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4674 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4675 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4676 macros related to unification of CJK characters. For the details,
4677 see the discussion following the message here:
4678 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4679
3d439cd1
CY
46802012-04-04 Chong Yidong <cyd@gnu.org>
4681
4682 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4683
8bc53d00
EZ
46842012-04-01 Eli Zaretskii <eliz@gnu.org>
4685
4686 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4687 instead of alloca. (Bug#11138)
4688
3b0512a3
AS
46892012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4690
4691 * w32menu.c (is_simple_dialog): Properly check lisp types.
4692 (Bug#11141)
4693
8427ddd2
EZ
46942012-03-31 Eli Zaretskii <eliz@gnu.org>
4695
979022ef
EZ
4696 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4697 position we get to after a call to move_it_to fails the
4698 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4699 only if we wind up in a string from display property. (Bug#11063)
4700
a6b1c7cc
EZ
4701 * window.c (Fdelete_other_windows_internal): Invalidate the row
4702 and column information about mouse highlight, so that redisplay
4703 restores it after reallocating the glyph matrices. (Bug#7464)
4704
8427ddd2
EZ
4705 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4706 string comes from a `display' text property, use the buffer
4707 position of that property as if we actually saw that position in
4708 the row's glyphs.
697ba24b
EZ
4709 (move_it_by_lines): Remove the assertion that
4710 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4711 violated when there's a before-string at the beginning of a line.
4712 (Bug#11063)
8427ddd2 4713
65a0a738
EZ
47142012-03-30 Eli Zaretskii <eliz@gnu.org>
4715
4716 * xdisp.c (append_space_for_newline): If the default face was
4717 remapped, use the remapped face for the appended newline.
4718 (extend_face_to_end_of_line): Use the remapped default face for
4719 extending the face to the end of the line.
4720 (display_line): Call extend_face_to_end_of_line when the default
4721 face was remapped. (Bug#11068)
4722
581355cc
EZ
47232012-03-29 Eli Zaretskii <eliz@gnu.org>
4724
4725 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4726
e8fc049f
SM
47272012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4728
4729 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4730
4fb9a543
GM
47312012-03-27 Glenn Morris <rgm@gnu.org>
4732
4733 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4734 Doc fixes.
4735
679910f1
KH
47362012-03-26 Kenichi Handa <handa@m17n.org>
4737
4738 * dispextern.h (struct glyph): Fix previous change. Change the
4739 bit length of glyphless.ch to 25 (Bug#11082).
4740
90d49b7f
CY
47412012-03-26 Chong Yidong <cyd@gnu.org>
4742
4743 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4744 (command_loop_1): Use it; inhibit selection update for
4745 handle-select-window too (Bug#8996).
4746
f514f6f0
FP
47472012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4748
e8fc049f 4749 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4750
bf43fa51
KH
47512012-03-25 Kenichi Handa <handa@m17n.org>
4752
4753 * dispextern.h (struct glyph): Change the bit length of
4754 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4755
8a0c01dd
EZ
47562012-03-24 Eli Zaretskii <eliz@gnu.org>
4757
4758 * s/ms-w32.h (tzname): Include time.h before redirecting to
4759 _tzname. Fixes the MSVC build. (Bug#9960)
4760
7d1c3a76
AS
47612012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4762
8ed79523
AS
4763 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4764 characters.
4765
7d1c3a76
AS
4766 * xterm.c (XTread_socket): Only modify handling_signal if
4767 !SYNC_INPUT. (Bug#11080)
4768
e99a9b8b
EZ
47692012-03-23 Eli Zaretskii <eliz@gnu.org>
4770
4771 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4772 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4773 when fetching a multibyte character consumes more bytes than
4774 CHAR_BYTES returns, due to unification of CJK characters in
4775 string_char. (Bug#11073)
4776
5063c0e1
TN
47772012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4778
4779 * process.c (wait_reading_process_output): Handle pty disconnect
4780 by refraining from sending oneself a SIGCHLD (bug#10933).
4781
9f851fbd
CY
47822012-03-22 Chong Yidong <cyd@gnu.org>
4783
4784 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4785
5063c0e1 4786 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4787 Mark string as coming from a prefix property.
4788 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4789 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4790
fb5b8aca
CY
47912012-03-21 Chong Yidong <cyd@gnu.org>
4792
4793 * xfaces.c (Vface_remapping_alist): Doc fix.
4794
62356a1b
EZ
47952012-03-20 Eli Zaretskii <eliz@gnu.org>
4796
4797 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4798 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4799 Doc fixes.
62356a1b 4800
025de85b
CY
48012012-03-20 Chong Yidong <cyd@gnu.org>
4802
4803 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4804 to reflect default non-nil value of redisplay-dont-pause.
4805
4827f94e
KH
48062012-03-19 Kenichi Handa <handa@m17n.org>
4807
4808 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4809 it fit in a valid range (Bug#11003).
4810
e50a24a2
EZ
48112012-03-18 Eli Zaretskii <eliz@gnu.org>
4812
4813 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4814 that is not from display property, accept the row as a "cursor
4815 row" if one of the string's character has a non-nil `cursor'
4816 property. Fixes cursor positioning when there are newlines in
4817 overlay strings, e.g. in icomplete.el. (Bug#11035)
4818
9af5ed87
PE
48192012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4820
4821 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4822
d1f55f16
CY
48232012-03-12 Chong Yidong <cyd@gnu.org>
4824
4825 * eval.c (inhibit_lisp_code): Rename from
4826 inhibit_window_configuration_change_hook; move from window.c.
4827
4828 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4829 * window.c (run_window_configuration_change_hook)
4830 (syms_of_window): Callers changed.
4831
66c5eebd
CY
48322012-03-11 Chong Yidong <cyd@gnu.org>
4833
413df973
CY
4834 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4835
66c5eebd
CY
4836 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4837
1de11f56
CY
48382012-03-10 Chong Yidong <cyd@gnu.org>
4839
4840 * frame.c (other_visible_frames): Don't assume the selected frame
4841 is visible (Bug#10955).
4842
cae07000
SM
48432012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4844
4845 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4846
89c94350
JD
48472012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4848
4849 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4850 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4851 zero (Bug#10954).
4852
999dd333
GM
48532012-03-03 Glenn Morris <rgm@gnu.org>
4854
01a6dcc8 4855 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4856
de0100f2
EZ
48572012-03-02 Eli Zaretskii <eliz@gnu.org>
4858
4859 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4860 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4861 (redisplay_window, next_element_from_string): Fix typos in
4862 comments.
3e441275
EZ
4863 (redisplay_window): Pass to move_it_vertically the margin in
4864 pixels, not in screen lines.
de0100f2 4865
96a72ee9
GM
48662012-03-02 Glenn Morris <rgm@gnu.org>
4867
4868 * buffer.c (buffer-list-update-hook): Doc fix.
4869
312508d7
EZ
48702012-02-29 Eli Zaretskii <eliz@gnu.org>
4871
4872 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4873 push_it before setting up the iterator for the first overlay
4874 string, even if we have an empty string loaded.
4875 (next_overlay_string): If there's an empty string on the iterator
4876 stack, pop the stack. (Bug#10903)
4877
27f3c637
PE
48782012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4879
4880 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4881 Suggested by Stefan Monnier in
4882 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4883 * alloc.c (widen_to_Lisp_Object): New static function.
4884 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4885 and widening them to Lisp_Objects. This would work even if
4886 USE_LSB_TAG is defined and wide integers are used, which might
4887 happen in a future version of Emacs.
4888
3c9dfce6
CY
48892012-02-25 Chong Yidong <cyd@gnu.org>
4890
fa74b241
CY
4891 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4892 Doc fix.
4893
3c9dfce6
CY
4894 * xselect.c (Fx_selection_exists_p): Doc fix.
4895 (x_clipboard_manager_save_all): Print an informative message
4896 before saving to clipboard manager.
4897
9486df08
CY
48982012-02-24 Chong Yidong <cyd@gnu.org>
4899
4900 * keyboard.c (process_special_events): Handle all X selection
4901 requests in kbd_buffer, not just the next one (Bug#8869).
4902
f01d3321
CY
49032012-02-23 Chong Yidong <cyd@gnu.org>
4904
4905 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4906 call when setting menu-bar-lines and tool-bar-lines parameters.
4907 (unwind_create_frame_1): New helper function.
4908
4909 * window.c (inhibit_window_configuration_change_hook): New var.
4910 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4911 (syms_of_window): Initialize it.
f01d3321 4912
86b847b6
CY
49132012-02-22 Chong Yidong <cyd@gnu.org>
4914
4915 * xterm.c (x_draw_image_relief): Add missing type check for
4916 Vtool_bar_button_margin (Bug#10743).
4917
a59225b1
CY
49182012-02-21 Chong Yidong <cyd@gnu.org>
4919
4920 * fileio.c (Vfile_name_handler_alist): Doc fix.
4921
4922 * buffer.c (Fget_file_buffer): Protect against invalid file
4923 handler return value.
4924
310f5bd4
PE
49252012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4926
cb3a28cc
PE
4927 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4928 when computing $valmask.
4929
310f5bd4
PE
4930 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4931 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4932 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4933 It's useless in that case, and it can cause problems on hosts
4934 that allocate halves of EMACS_INT values separately.
4935 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4936 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4937 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4938 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4939 it avoids undefined behavior on hosts where shifting right by more
4940 than the word width has undefined behavior.
4941
2375c96a
CY
49422012-02-19 Chong Yidong <cyd@gnu.org>
4943
4944 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4945 (Funhandled_file_name_directory, Ffile_name_as_directory)
4946 (Fdirectory_file_name, Fexpand_file_name)
4947 (Fsubstitute_in_file_name): Protect against invalid file handler
4948 return values (Bug#10845).
4949
3eb49e71
EZ
49502012-02-18 Eli Zaretskii <eliz@gnu.org>
4951
4952 * .gdbinit (pitx): Fix incorrect references to fields of the
4953 iterator stack.
4954
7b926f3f
CY
49552012-02-17 Chong Yidong <cyd@gnu.org>
4956
4957 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4958
11273115
PE
49592012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4960
4961 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4962 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4963
c3a70e2b
CY
49642012-02-15 Chong Yidong <cyd@gnu.org>
4965
4966 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4967 marked as special. Also, starting docstrings with * is obsolete.
4968
0ca43699
AS
49692012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4970
4971 * gnutls.c (emacs_gnutls_write): Fix last change.
4972
2e8f3c56
LI
49732012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4974
4975 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4976 send_process.
4977
af70074f
SM
49782012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4979
4980 * keymap.c (Fsingle_key_description): Handle char ranges.
4981
95986d52
CY
49822012-02-12 Chong Yidong <cyd@gnu.org>
4983
afd83bd1
CY
4984 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4985 as that creates a dangerous corner case.
4986
95986d52
CY
4987 * window.c (Fdelete_window_internal): Invalidate the mouse
4988 highlight (Bug#9904).
4989
bd7da63e
GM
49902012-02-12 Glenn Morris <rgm@gnu.org>
4991
4992 * xselect.c (Fx_own_selection_internal)
4993 (Fx_get_selection_internal, Fx_disown_selection_internal)
4994 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4995 * nsselect.m (Fx_own_selection_internal)
4996 (Fx_disown_selection_internal, Fx_selection_exists_p)
4997 (Fx_selection_owner_p, Fx_get_selection_internal):
4998 Sync docs and argument specs with the xselect.c versions.
4999
77abcbc2
LI
50002012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5001
5002 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5003
90b671e2
EZ
50042012-02-11 Eli Zaretskii <eliz@gnu.org>
5005
1c0ca0b7
EZ
5006 * w32select.c (Fx_selection_exists_p): Sync doc string and
5007 argument list with xselect.c. (Bug#10783)
5008
5009 * w16select.c (Fx_selection_exists_p): Sync doc string and
5010 argument list with xselect.c. (Bug#10783)
90b671e2 5011
49241268
GM
50122012-02-10 Glenn Morris <rgm@gnu.org>
5013
5014 * fns.c (Fsecure_hash): Doc fix.
5015
f998bbe7 50162012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5017
5018 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5019
0992bd9c
CY
50202012-02-07 Chong Yidong <cyd@gnu.org>
5021
5022 * buffer.c (Fbuffer_local_variables)
5023 (buffer_lisp_local_variables): Handle unbound vars correctly;
5024 don't let Qunbound leak into Lisp.
5025
af008560
GM
50262012-02-07 Glenn Morris <rgm@gnu.org>
5027
dd605cc4
GM
5028 * image.c (Fimagemagick_types): Doc fix.
5029
af008560
GM
5030 * image.c (imagemagick-render-type): Change it from a lisp object
5031 to an integer. Move the doc here from the lisp manual.
5032 Treat all values not equal to 0 the same.
5033
1449fa1d
CY
50342012-02-06 Chong Yidong <cyd@gnu.org>
5035
5036 * doc.c (store_function_docstring): Avoid applying docstring of
5037 alias to base function (Bug#2603).
5038
3723ec07
AS
50392012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5040
5041 * .gdbinit (pp1, pv1): Remove redundant defines.
5042 (pr): Use pp.
5043
79c1cc1e
CY
50442012-02-04 Chong Yidong <cyd@gnu.org>
5045
5046 * nsterm.m: Declare a global (Bug#10694).
5047
d7f29f8e
EZ
50482012-02-04 Eli Zaretskii <eliz@gnu.org>
5049
cae07000
SM
5050 * w32.c (get_emacs_configuration_options):
5051 Include --enable-checking, if specified, in the return value.
d7f29f8e 5052
3b95a6f9
MR
50532012-02-04 Martin Rudalics <rudalics@gmx.at>
5054
5055 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5056 after rounding frame sizes. (Bug#9723)
5057
d6fa96a6
EZ
50582012-02-04 Eli Zaretskii <eliz@gnu.org>
5059
5060 * keyboard.c (adjust_point_for_property): Don't position point
5061 before BEGV. (Bug#10696)
5062
df0b2940
PE
50632012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5064
5065 Handle overflow when computing char display width (Bug#9496).
5066 * character.c (char_width): Return EMACS_INT, not int.
5067 (char_width, c_string_width): Check for overflow when
5068 computing the width; this is possible now that individual
5069 characters can have unbounded width. Problem introduced
5070 by merge from Emacs 23 on 2012-01-19.
5071
6bee44d6
MA
50722012-02-02 Michael Albinus <michael.albinus@gmx.de>
5073
5074 * dbusbind.c (Fdbus_register_method): Mention the return value
5075 :ignore in the docstring.
5076
44f92739
GM
50772012-02-02 Glenn Morris <rgm@gnu.org>
5078
1b9f60cc
GM
5079 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5080
44f92739
GM
5081 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5082 Unconditionally set to t. (Bug#10673)
5083 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5084 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5085 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5086
c5d3843c
KH
50872012-02-02 Kenichi Handa <handa@m17n.org>
5088
5089 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5090 0, do not call append_composite_glyph.
5091
159462d4 50922012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5093
5094 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5095 NULL (Bug#6988).
5096 (x_produce_glyphs): If the component of a composition is a null
5097 string, set it->pixel_width to 1 to avoid zero-width glyph.
5098
78cef877
EZ
50992012-02-01 Eli Zaretskii <eliz@gnu.org>
5100
5101 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5102 first 2 arguments are identical. This makes inserting large
5103 output from a subprocess an order of magnitude faster on
5104 MS-Windows, where all sbrk'ed memory is always contiguous.
5105
97897668
GM
51062012-01-31 Glenn Morris <rgm@gnu.org>
5107
5108 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5109 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5110 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5111
31fd3586
GM
51122012-01-29 Glenn Morris <rgm@gnu.org>
5113
5114 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5115
0e24a8b2
CY
51162012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5117
5118 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5119
cc0adcb0
CY
51202012-01-28 Chong Yidong <cyd@gnu.org>
5121
5122 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5123
acc28cb9
CY
51242012-01-26 Chong Yidong <cyd@gnu.org>
5125
9c69cfb7
CY
5126 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5127
acc28cb9
CY
5128 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5129 repeat counts (Bug#10507).
5130
48da7392
GM
51312012-01-26 Glenn Morris <rgm@gnu.org>
5132
5133 * lread.c (syms_of_lread): Doc fix.
5134
14af5f7f
CY
51352012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5136
5137 * coding.c (encode_designation_at_bol): Change return value to
5138 EMACS_INT.
5139
0b21c100
CY
51402012-01-25 Chong Yidong <cyd@gnu.org>
5141
5142 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5143
3c2907f7
CY
51442012-01-21 Chong Yidong <cyd@gnu.org>
5145
5146 * floatfns.c (Fcopysign): Make the second argument non-optional,
5147 since nil is not allowed anyway.
5148
959ad23f
AS
51492012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5150
5151 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5152 (send_process): Likewise.
5153
34a02f46
MR
51542012-01-19 Martin Rudalics <rudalics@gmx.at>
5155
5156 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5157 (Vwindow_persistent_parameters): Do not use Qstate.
5158 Rewrite doc-strings.
34a02f46 5159
1259009a 51602012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5161
5162 * character.c (char_width): New function.
70d4fdf6
GM
5163 (Fchar_width, c_string_width, lisp_string_width):
5164 Use char_width (Bug#9496).
25ed9e61 5165
6a6ee00d
MR
51662012-01-16 Martin Rudalics <rudalics@gmx.at>
5167
5168 * window.c (Vwindow_persistent_parameters): New variable.
5169 (Fset_window_configuration, save_window_save): Handle persistent
5170 window parameters.
5171
c85efaf7
EZ
51722012-01-14 Eli Zaretskii <eliz@gnu.org>
5173
5174 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5175 thrashing the stack of the thread. (Bug#9087)
5176
5944709e
PE
51772012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5178
5179 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5180
e71f5d99
EZ
51812012-01-11 Eli Zaretskii <eliz@gnu.org>
5182
5183 * xdisp.c (rows_from_pos_range): Handle the case where the
5184 highlight ends on a newline. (Bug#10464)
5185 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5186 he end column for display of highlight that ends on a newline
5187 before a R2L line.
5188
ce316182
GM
51892012-01-11 Glenn Morris <rgm@gnu.org>
5190
5191 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5192 from load-path also when installation-directory is nil. (Bug#10208)
5193
5b43da69
GM
51942012-01-10 Glenn Morris <rgm@gnu.org>
5195
74cc8ff9
GM
5196 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5197
7d8d6e4e
GM
5198 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5199 Update template values to be closer to their typical values these days.
5b43da69 5200
a0db8d43
EZ
52012012-01-09 Eli Zaretskii <eliz@gnu.org>
5202
5203 * xdisp.c (rows_from_pos_range): Accept additional argument
5204 DISP_STRING, and accept any glyph in a row whose object is that
5205 string as eligible for mouse highlight. Fixes mouse highlight of
5206 display strings from overlays. (Bug#10464)
5207
9a0115ab 52082012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5209
b9110d6a 5210 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5211 * fileio.c (auto_saving_dir_umask): New static var.
5212 (Fmake_directory_internal): Use it.
5213 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5214 creating the directory. The old code temporarily assigns
5215 too-generous permissions to the directory.
5216 (do_auto_save_eh): Clear it.
b9110d6a 5217 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5218 that the var is always cleared.
5219
6c1bd3f3
EZ
52202012-01-07 Eli Zaretskii <eliz@gnu.org>
5221
5222 * search.c (scan_buffer): Pass character positions to
5223 know_region_cache, not byte positions. (Bug#6540)
5224
069d2b50
L
52252012-01-07 LynX <_LynX@bk.ru> (tiny change)
5226
5227 * w32.c (sys_rename): Report EXDEV when rename of a directory
5228 fails because the target is on another logical disk. (Bug#10284)
5229
75bf0d33
DB
52302012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5231
5232 * xterm.c (x_embed_request_focus): New function.
5233
5234 * xterm.h: Add prototype.
5235
5236 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5237
1c6e5a32
GM
52382012-01-05 Glenn Morris <rgm@gnu.org>
5239
5240 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5241
651e947e
EZ
52422012-01-01 Eli Zaretskii <eliz@gnu.org>
5243
5244 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5245 Load gnutls_transport_set_lowat only if GnuTLS version is below
5246 2.11.1.
5247 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5248 GnuTLS versions below 2.11.1.
5249
3778cdd8
AL
52502011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5251
5252 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5253 to the doc string advising against its use for altering the way
5254 windows are scrolled.
5255
0e5317f7
KH
52562011-12-28 Kenichi Handa <handa@m17n.org>
5257
5258 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5259 coding-system ASCII compatible only when it does not produce BOM
5260 on encoding (Bug#10383).
5261
93d5ca1f
JD
52622011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5263
5264 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5265 can scroll.
5266 (create_and_show_popup_menu): Always use menu_position_func for
5267 Gtk3 (Bug#10361).
5268
ca22b785
AS
52692011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5270
5271 * callint.c (Fcall_interactively): Don't truncate prompt string.
5272
d048e1e6
EZ
52732011-12-23 Eli Zaretskii <eliz@gnu.org>
5274
5275 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5276 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5277 resumed from there (after widening). (Bug#10360)
d048e1e6 5278
5ccaba1f
JD
52792011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5280
5281 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5282
204ee57f
JD
52832011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5284
b81d40f0
JB
5285 * nsterm.m (x_free_frame_resources):
5286 Release f->output_data.ns->miniimage.
204ee57f
JD
5287 (ns_index_color): Fix indentation. Do not retain
5288 color_table->colors[i].
5289
5290 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5291 before returning.
5292
5293 * nsfns.m (x_set_background_color): Assign return value from
5294 ns_index_color to face-background instead of NSColor*.
5295 (ns_implicitly_set_icon_type): Fix indentation.
5296 Change assignment in for loop to comparison.
5297
5298 * emacs.c (ns_pool): New variable.
5299 (main): Assign ns_pool.
5300 (Fkill_emacs): Call ns_release_autorelease_pool.
5301
5302 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5303 autorelease fdesc, release fdAttrs and tdict.
5304 (ns_get_covering_families): Release charset.
5305 (ns_findfonts): Release NSFontDescriptor created with new.
5306 (ns_uni_to_glyphs): Fix indentation.
5307 (setString): Release attrStr before assigning new value.
5308
c803b2b7
JD
53092011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5310
678f4426
JD
5311 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5312 and NS_IMPL_COCOA.
5313 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5314 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5315
cd394be1 53162011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5317
5fecd5fc
JD
5318 * nsterm.m (ns_term_init): Subscribe for notifications
5319 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5320 to method trackingNotification in EmacsMenu.
5321
5322 * nsmenu.m (trackingMenu): New variable.
3771cb17 5323 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5324 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5325 from Aquamacs (Bug#7030).
678f4426
JD
5326
53272011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5328
c803b2b7
JD
5329 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5330 (symbol_to_nsstring): Fix indentation.
5331 (ns_symbol_to_pb): New function.
cae07000
SM
5332 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5333 (Fns_rotate_cut_buffers_internal): Remove.
5334 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5335 Fns_store_cut_buffer_internal.
5336 (ns_get_foreign_selection, Fx_own_selection_internal)
5337 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5338 (Fns_get_selection_internal, Fns_store_selection_internal):
5339 Use ns_symbol_to_pb and check if return value is nil.
5340 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5341 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5342 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5343 renamed to Sns_store_selection_internal.
5344 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5345 and remove this function.
5346 (ns_handle_selection_clear): Remove, never used.
5347 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5348 here.
5349
e1b01a3a
KB
53502011-12-17 Ken Brown <kbrown@cornell.edu>
5351
5352 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5353 GID is unknown (Bug#10257).
5354
2adb6e85
PE
53552011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5356
5357 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5358 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5359 which caused a build failure on GNU/Linux IA-64. This problem was
5360 introduced by my 2011-10-07 patch.
5361
d1d7b339
JL
53622011-12-15 Juri Linkov <juri@jurta.org>
5363
5364 * image.c (imagemagick_error): New function. (Bug#10112)
5365 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5366 Use `imagemagick_error' where ImageMagick functions return
5367 `MagickFalse'.
5368 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5369 proper order.
5370
100d5755
KH
53712011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5372
5373 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5374 fill background (Bug#8992).
5375
454592a6
MR
53762011-12-13 Martin Rudalics <rudalics@gmx.at>
5377
5378 * window.c (Vwindow_combination_resize)
5379 (Vwindow_combination_limit): Use t instead of non-nil in
5380 doc-strings.
61d4b438
MR
5381 (Vrecenter_redisplay): Add first sentence of doc-string on
5382 separate line.
53524d93 5383 (Frecenter): Fix doc-string typo.
454592a6 5384
3633e3aa
KH
53852011-12-11 Kenichi Handa <handa@m17n.org>
5386
5387 * coding.c (Funencodable_char_position): Pay attention to the
5388 buffer text relocation (Bug#9389).
5389
7b9d523a 53902011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5391
7b9d523a
JD
5392 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5393 gtk_init (Bug#10100).
5394
b73189c6
EZ
53952011-12-10 Eli Zaretskii <eliz@gnu.org>
5396
5397 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5398 IT->string is nil. (Bug#10263)
5399
f7dfe5d6
JD
54002011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5401
83faebb4
JD
5402 * nsterm.h (x_free_frame_resources): Declare.
5403
f7dfe5d6
JD
5404 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5405 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5406
5407 * nsterm.h (ns_get_defaults_value): Declare.
5408
5409 * nsterm.m (ns_default): Call ns_get_defaults_value.
5410
7cd4e72c
EZ
54112011-12-09 Eli Zaretskii <eliz@gnu.org>
5412
5413 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5414 (Bug#10170)
5415
b34d7317
YM
54162011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5417
5418 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5419 that where the value of an _OBJC_* symbol points to is in the .bss
5420 section (Bug#10240).
5421
76470ad1
KH
54222011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5423
5424 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5425 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5426
745fff94
KH
54272011-12-08 Kenichi Handa <handa@m17n.org>
5428
5429 * ftfont.c (get_adstyle_property): Fix previous change
5430 (Bug#10233).
5431
6e44397c
JB
54322011-12-07 Juanma Barranquero <lekktu@gmail.com>
5433
5434 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5435 dirs from the default value of EMACSLOADPATH (bug#10208).
5436
7efa6272
GM
54372011-12-07 Glenn Morris <rgm@gnu.org>
5438
5439 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5440 installation and source directories as well. (Bug#10208)
5441
f6fc4d87
CY
54422011-12-06 Chong Yidong <cyd@gnu.org>
5443
5444 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5445
2bf26180
GM
54462011-12-06 Glenn Morris <rgm@gnu.org>
5447
5448 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5449 as an error, not just -1. (Bug#10217)
5450
3a6ad4f0
CY
54512011-12-05 Chong Yidong <cyd@gnu.org>
5452
5453 * keyboard.c (process_special_events): New function.
5454 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5455
75a3b399
PE
54562011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5457
5458 * coding.c (encode_designation_at_bol): Don't use uninitialized
5459 local variable (Bug#9318).
5460
c3c9e25e
KH
54612011-12-05 Kenichi Handa <handa@m17n.org>
5462
5463 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5464 return Qnil (Bug#8046, Bug#10193).
5465
5eb05ea3
KH
54662011-12-05 Kenichi Handa <handa@m17n.org>
5467
5468 * coding.c (encode_designation_at_bol): New args charbuf_end and
5469 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5470 (coding_set_source): Return how many bytes coding->source was
5471 relocated.
5472 (coding_set_destination): Return how many bytes
5473 coding->destination was relocated.
5474 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5475 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5476
54772011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5478
5479 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5480 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5481 macro (Bug#9318).
5482
54832011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5484
5485 The following changes are to fix Bug#9318.
5486
a79703f5 5487 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5488 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5489 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5490 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5491
7dbda6df
JB
54922011-12-05 Juanma Barranquero <lekktu@gmail.com>
5493
5494 * lisp.h (process_quit_flag): Fix external declaration.
5495
6d5eb5b0
SM
54962011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5497
5498 Don't macro-inline non-performance-critical code.
5499 * eval.c (process_quit_flag): New function.
5500 * lisp.h (QUIT): Use it.
5501
a0c3fad0
JD
55022011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5503
5504 * nsfns.m (get_geometry_from_preferences): New function.
5505 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5506
6c07aac2
AS
55072011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5508
5509 * emacs.c (Qkill_emacs): Define.
5510 (syms_of_emacs): Initialize it.
5511 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5512 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5513 (quit_throw_to_read_char): Add parameter `from_signal'.
5514 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5515 * lisp.h (QUIT): Call Fkill_emacs if requested.
5516
c052ead4
JD
55172011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5518
5519 * widget.c (update_wm_hints): Return if wmshell is null.
5520 (widget_update_wm_size_hints): New function.
5521
5522 * widget.h (widget_update_wm_size_hints): Declare.
5523
5524 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5525 widget_update_wm_size_hints (Bug#10104).
5526
9e49252b
EZ
55272011-12-03 Eli Zaretskii <eliz@gnu.org>
5528
5529 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5530 before a newline, prepare the bidi iterator for consuming the
5531 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5532 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5533
02b16839
JL
55342011-12-02 Juri Linkov <juri@jurta.org>
5535
5536 * search.c (Fword_search_regexp): New Lisp function created from
5537 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5538 (Fword_search_backward, Fword_search_forward)
5539 (Fword_search_backward_lax, Fword_search_forward_lax):
5540 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5541 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5542
0068070e
SM
55432011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5544
5545 * fileio.c (Finsert_file_contents): Move after-change-function call
5546 to before the "handled:" label, since all "goto handled" appear in
5547 cases where the *-change-functions have already been properly called
5548 (bug#10117).
5549
3360a3fc
AS
55502011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5551
5552 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5553 waiting for input. (Bug#10169)
5554
73d6c093
EZ
55552011-11-30 Eli Zaretskii <eliz@gnu.org>
5556
5557 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5558 verifies glyph row's hash code--we have just reallocated the
5559 glyphs, so their contents can be complete garbage. (Bug#10164)
5560
febe6bea
JB
55612011-11-30 Juanma Barranquero <lekktu@gmail.com>
5562
5563 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5564
801a4313
EZ
55652011-11-30 Eli Zaretskii <eliz@gnu.org>
5566
5567 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5568 attributes are tested _before_ calling verify_row_hash, to protect
5569 against GCC re-ordering of the tests. (Bug#10164)
5570
2b56b87e
JD
55712011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5572
5573 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5574
5575 * xterm.c (handle_one_xevent): Only set async_visible and friends
5576 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5577 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5578 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5579
dbf31225
PE
55802011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5581
5582 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5583 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5584 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5585 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5586 All uses changed to use GCPRO1 etc.
5587 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5588 Revert to old implementation (i.e., before 2011-03-11).
5589
1305621b
YM
55902011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5591
5592 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5593 of scroll runs so as to avoid assigning disabled bogus rows and
5594 unnecessary graphics copy operations.
5595
8c9afb46
EZ
55962011-11-27 Eli Zaretskii <eliz@gnu.org>
5597
5598 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5599 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5600 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5601 (malloc, free, realloc, calloc): Redirect to e_* only when
5602 compiling Emacs.
5603
5604 * lisp.h (GCTYPEBITS): Move before first use.
5605 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5606 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5607 this macro definition.
5608
5609 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5610 _MSC_VER.
5611
54e9e3bf
JD
56122011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5613
6d5eb5b0
SM
5614 * gtkutil.c (xg_create_frame_widgets):
5615 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5616 present with Gtk+ 2.0.
5617
83aca1cb
PE
56182011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5619
5620 * fileio.c (Finsert_file_contents): Undo previous change; see
5621 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5622
5b76caa4
PE
56232011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5624
5625 Rename locals to avoid shadowing.
5626 * fileio.c (Finsert_file_contents):
5627 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5628 * process.c (wait_reading_process_output):
5629 Rename inner 'proc' to 'p' to avoid shadowing.
5630 Indent for consistency with usual Emacs style.
5631
8c535114
EZ
56322011-11-25 Eli Zaretskii <eliz@gnu.org>
5633
5634 * xdisp.c (redisplay_window): If cursor row is not fully visible
5635 after recentering, and scroll-conservatively is set to a large
5636 number, scroll window by a few more lines to make the cursor fully
5637 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5638 (start_display): Don't move to the next line if the display should
5639 start at a newline that is part of a display vector or an overlay
5640 string. (Bug#10119)
8c535114 5641
fa4fdb5c
JL
56422011-11-24 Juri Linkov <juri@jurta.org>
5643
5644 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5645 after the `MagickPingImage' call. (Bug#10112)
5646
90ec88df
CY
56472011-11-23 Chong Yidong <cyd@gnu.org>
5648
5649 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5650
56e2e794
MR
56512011-11-23 Martin Rudalics <rudalics@gmx.at>
5652
5653 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5654 making another buffer current. (Bug#10114)
5655
b6e64c41
GM
56562011-11-23 Glenn Morris <rgm@gnu.org>
5657
5658 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5659
6b21de18
CY
56602011-11-23 Chong Yidong <cyd@gnu.org>
5661
5662 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5663 using it (Bug#5984).
5664
b12cd789
EZ
56652011-11-22 Eli Zaretskii <eliz@gnu.org>
5666
5667 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5668 and header-lines, as they don't have one computed for them.
5669 (Bug#10098)
5670
5671 * .gdbinit (prow): Make displayed values more self-explaining.
5672 Add row's hash code.
5673
261b6fd4
LMI
56742011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5675
5676 * process.c (wait_reading_process_output): Fix asynchrounous
5677 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5678 (wait_reading_process_output): Add comment and URL.
261b6fd4 5679
e7cfd277
JD
56802011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5681
5682 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5683
a9b9b7f5
CY
56842011-11-21 Chong Yidong <cyd@gnu.org>
5685
5686 * window.c (Fnext_window, Fprevious_window): Doc fix.
5687
b0d15b4f
SM
56882011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5689
5690 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5691
fe7a3057
JB
56922011-11-20 Juanma Barranquero <lekktu@gmail.com>
5693
5694 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5695
d2999b1a
MR
56962011-11-20 Martin Rudalics <rudalics@gmx.at>
5697
5698 * window.c (Fset_window_combination_limit): Rename argument
5699 STATUS to LIMIT.
5700 (Vwindow_combination_limit): Remove "status" from doc-string.
5701
d5ff9cd0
AS
57022011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5703
5704 * m/ibms390.h: Remove.
5705 * m/ibms390x.h: Don't include "ibms390.h".
5706
a5bb9bd3
SM
57072011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5708
5709 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5710 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5711
cd1181db
JB
57122011-11-20 Juanma Barranquero <lekktu@gmail.com>
5713
5714 * casetab.c (Fset_case_table):
5715 * charset.c (Fcharset_after): Fix typos.
5716
615a3b8d 57172011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5718
17e845af
PE
5719 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5720 Otherwise, valgrind does not work on some platforms.
5721 Problem reported by Andreas Schwab in
6a0bf43d
PE
5722 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5723 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5724 is set, removing the need for VIRT_ADDRESS_VARIES.
5725 (PURE_P): Use a more-efficient implementation that needs just one
5726 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5727 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5728 to 4 (xorl, subq, cmpq, setbe).
5729 * alloc.c (pure): Always extern now, since that's the
5730 VIRT_ADDR_VARIES behavior.
5731 (PURE_POINTER_P): Use a single comparison, not two, for
5732 consistency with the new puresize.h.
5733 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5734 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5735 Remove VIRT_ADDR_VARIES no longer needed.
5736
f8fe6f96
EZ
57372011-11-19 Eli Zaretskii <eliz@gnu.org>
5738
5739 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5740 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5741 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5742 behave as if the cursor position were at the window margin.
5743
5744 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5745 and the cursor position is out of bounds, behave as if the cursor
5746 position were at the window margin. (Bug#10075)
5747
df05a53c
CY
57482011-11-18 Chong Yidong <cyd@gnu.org>
5749
5750 * window.c (Fwindow_combination_limit): Make first argument
5751 non-optional, since it is meaningless for live windows like the
5752 selected window.
61ccba97 5753
2071918e
DA
57542011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5755
5756 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5757
b50a28de
SM
57582011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5759
5760 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5761 (graft_intervals_into_buffer): Simplify.
5762
015137db
EZ
57632011-11-18 Eli Zaretskii <eliz@gnu.org>
5764
5765 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5766 hash values of the two rows.
5767 (copy_row_except_pointers): Preserve the used[] arrays and the
5768 hash values of the two rows. (Bug#10035)
68c95424 5769 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5770
5771 * xdisp.c (row_hash): New function, body extracted from
5772 compute_line_metrics.
5773 (compute_line_metrics): Call row_hash, instead of computing the
5774 hash code inline.
5775
5776 * dispnew.c (verify_row_hash): Call row_hash for computing the
5777 hash code of a row, instead of duplicating code from xdisp.c.
5778
5779 * dispextern.h (row_hash): Add prototype.
5780
a2addb04
TH
57812011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5782
5783 * frame.c (delete_frame): Don't delete the terminal when the last
5784 X frame is closed if emacs is built with GTK toolkit.
5785
df85d315
JB
57862011-11-17 Juanma Barranquero <lekktu@gmail.com>
5787
5788 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5789
a0c2d0ae
MR
57902011-11-17 Martin Rudalics <rudalics@gmx.at>
5791
5792 * window.c (Vwindow_splits): Rename to
5793 Vwindow_combination_resize. Suggested by Juri Linkov.
5794 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5795 of Vwindow_splits.
5796
58179cce
JB
57972011-11-16 Juanma Barranquero <lekktu@gmail.com>
5798
7877f373
JB
5799 * nsfns.m (Fns_font_name):
5800 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5801
b6f67890
MR
58022011-11-16 Martin Rudalics <rudalics@gmx.at>
5803
5804 * window.h (window): Rename slot "nest" to "combination_limit".
5805 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5806 (Fset_window_nest): Rename to Fset_window_combination_limit.
5807 (Vwindow_nest): Rename to Vwindow_combination_limit.
5808 (recombine_windows, make_parent_window, make_window)
5809 (Fsplit_window_internal, saved_window)
5810 (Fset_window_configuration, save_window_save): Rename all
5811 occurrences of window_nest to window_combination_limit.
5812
c7015153
JB
58132011-11-15 Juanma Barranquero <lekktu@gmail.com>
5814
5815 * image.c (imagemagick_load_image): Fix typo.
5816
322ad6ec
EZ
58172011-11-14 Eli Zaretskii <eliz@gnu.org>
5818
5819 * xdisp.c (display_line): Move the call to
5820 highlight_trailing_whitespace before the call to
5821 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5822 faces of all the glyphs to compute ROW's hash value.
5823 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5824
f067b8ec
JB
58252011-11-14 Juanma Barranquero <lekktu@gmail.com>
5826
5827 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5828 just return (bug#10044).
5829
1e5b2111
EZ
58302011-11-12 Eli Zaretskii <eliz@gnu.org>
5831
7ef3cbd5
EZ
5832 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5833 with user-defined heap size. Bump the default size of the temacs
5834 heap to 27MB, to avoid memory warning when running temacs.
5835 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5836
1e5b2111
EZ
5837 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5838 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5839 (verify_row_hash) [XASSERTS]: New function.
5840 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5841 that the hash value of glyph rows is correct.
1e5b2111 5842
89d61221
MR
58432011-11-12 Martin Rudalics <rudalics@gmx.at>
5844
5845 * window.h (window): Remove splits slot.
5846 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5847 (Fdelete_other_windows_internal, make_parent_window)
5848 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5849 (Fset_window_configuration, save_window_save): Don't deal with
5850 split status of windows.
5851 (saved_window): Remove splits slot.
5852 (Vwindow_splits): Rewrite doc-string.
5853
97f18cc8
JD
58542011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5855
5856 * xfns.c (unwind_create_frame):
5857 * nsfns.m (unwind_create_frame):
5858 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5859 Vframe_list (Bug#9999).
5860
22a648b4
DA
58612011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5862
0b381c7e 5863 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5864
659afede
KH
58652011-11-11 Kenichi Handa <handa@m17n.org>
5866
5867 * callproc.c (Fcall_process): Set the member dst_multibyte of
5868 process_coding.
5869
9ac0394b
KH
58702011-11-11 Johan Bockgård <bojohan@gnu.org>
5871
5872 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5873 avoid a crash (bug#9496).
5874
2fbdc249
CY
58752011-11-09 Chong Yidong <cyd@gnu.org>
5876
5877 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5878 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5879
ac6b1f81
PE
58802011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5881
5882 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5883
09db192c
PE
58842011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5885
5886 Avoid some portability problems by eschewing 'extern inline' functions.
5887 The trivial performance wins aren't worth the portability hassles; see
5888 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5889 et seq.
5890 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5891 (window_box_width, window_box_left, window_box_left_offset)
5892 (window_box_right, window_box_right_offset): Undo previous change,
5893 by removing the "extern"s.
5894 * intervals.c (adjust_intervals_for_insertion)
5895 (adjust_intervals_for_deletion): Undo previous change,
5896 making these static again.
5897 (offset_intervals, temp_set_point_both, temp_set_point)
5898 (copy_intervals_to_string): No longer inline.
5899 * xdisp.c (window_text_bottom_y, window_box_width)
5900 (window_box_height, window_box_left_offset)
5901 (window_box_right_offset, window_box_left, window_box_right)
5902 (window_box): No longer inline.
5903
105216ed
CY
59042011-11-08 Chong Yidong <cyd@gnu.org>
5905
5906 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5907 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5908 Signal an error if not a live window.
105216ed
CY
5909 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5910 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5911
ae9e237f
JB
59122011-11-07 Juanma Barranquero <lekktu@gmail.com>
5913
5914 * lisp.h (syms_of_abbrev): Remove declaration.
5915 Reported by CHENG Gao <chenggao@royau.me>.
5916
c7aa8333
EZ
59172011-11-07 Eli Zaretskii <eliz@gnu.org>
5918
5919 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5920 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5921 of temacs in GUI mode.
5922
be7f5545
MR
59232011-11-07 Martin Rudalics <rudalics@gmx.at>
5924
5925 * window.h: Declare delete_all_child_windows instead of
5926 delete_all_subwindows.
5927 * window.c (Fwindow_nest, Fset_window_nest)
5928 (Fset_window_new_total, Fset_window_new_normal)
5929 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5930 (delete_all_subwindows): Rename to delete_all_child_windows.
5931 (Fdelete_other_windows_internal, Fset_window_configuration):
5932 Call delete_all_child_windows instead of delete_all_subwindows.
5933 * frame.c (delete_frame): Call delete_all_child_windows instead
5934 of delete_all_subwindows.
5935
ca78dc43
PE
59362011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5937
5938 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5939 This is also needed for porting to any host where GC_MARK_STACK is
5940 not GC_MAKE_GCPROS_NOOPS.
5941 (which_symbols): Use it.
5942
a0241d01
KH
59432011-11-07 Kenichi Handa <handa@m17n.org>
5944
5945 * coding.c (coding_set_destination): Check coding->src_pos only
5946 when coding->src_object is a buffer (bug#9910).
5947
5948 * process.c (send_process): Set the member src_multibyte of coding
5949 to 0 (bug#9911) when sending a unibyte text.
5950
5951 * callproc.c (Fcall_process): Set the member src_multibyte of
5952 process_coding to 0 (bug#9912).
5953
a64bfdfa 59542011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5955
5956 * xmenu.c (cleanup_widget_value_tree): New function.
5957 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5958 calling free_menubar_widget_value_tree directly (Bug#9830).
5959
cb41b32a
PE
59602011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5961
5962 Fix some portability problems with 'inline'.
5963 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5964 (window_box_width, window_box_left, window_box_left_offset)
5965 (window_box_right, window_box_right_offset): Declare extern.
5966 Otherwise, these inline functions do not conform to C99 and
5967 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5968 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5969 * intervals.c (adjust_intervals_for_insertion)
5970 (adjust_intervals_for_deletion): Now extern, because otherwise the
5971 extern inline functions 'offset_intervals' couldn't refer to it.
5972 (static_offset_intervals): Remove.
5973 (offset_intervals): Rewrite using the old contents of
5974 static_offset_intervals. The old version didn't conform to C99
5975 because an extern inline function contained a reference to an
5976 identifier with static linkage.
5977
b7041366
AS
59782011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5979
5980 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5981 GC.
5982
88a37c4d
EZ
59832011-11-06 Eli Zaretskii <eliz@gnu.org>
5984
5985 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5986 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5987 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5988 return Qleft_to_right.
5989
49745b39
CY
59902011-11-06 Chong Yidong <cyd@gnu.org>
5991
5992 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5993 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5994 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5995 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5996 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5997 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5998 (Fwindow_vscroll): Doc fix.
5999 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6000 argument, since it makes no sense to pass a live window and for
6001 consistency with window-child.
6002
1f05cd82
CS
60032011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6004
6005 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6006 support MSVC.
6007
22610910
JR
60082011-11-05 Jason Rumney <jasonr@gnu.org>
6009
6010 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6011 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6012 fonts (Bug#6029).
6013 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6014 bitwise arithmetic preventing use of unicode-sip and non-truetype
6015 opentype fonts.
6016
a06776b2
EZ
60172011-11-05 Eli Zaretskii <eliz@gnu.org>
6018
3ad924ba
EZ
6019 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6020 "emacs"-only part.
6021
a06776b2
EZ
6022 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6023 initialization code to keep similarity to xfns.c after changes
6024 from 2011-11-05.
6025
c9e7db78
JD
60262011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6027
a97f8f3f
JD
6028 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6029 (unwind_create_frame): New function (Bug#9943).
6030 (Fx_create_frame): Restructure code to be more similar to the one in
6031 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6032 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6033 Move terminal->reference_count++ just before making the frame official
6034 (Bug#9943).
6035
6036 * nsterm.m (x_free_frame_resources): New function.
6037 (x_destroy_window): Move code to x_free_frame_resources.
6038
c9e7db78 6039 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6040 (Fx_create_frame, x_create_tip_frame):
6041 Move terminal->reference_count++ just before making the frame
75f1671a 6042 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6043 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6044
a6fc3b5c
EZ
60452011-11-05 Eli Zaretskii <eliz@gnu.org>
6046
6047 Support MSVC build with newer versions of Visual Studio.
6048 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6049 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6050 nt/gmake.defs.
6051
6052 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6053 which are not supported by MSVC.
6054 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6055 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6056 bitfields.
6057 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6058 types in bitfields.
6059 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6060
6061 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6062
58179cce 60632011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6064
6065 Support MSVC build with newer versions of Visual Studio.
6066 * w32.c: Don't include w32api.h for MSVC.
6067 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6068
6069 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6070 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6071 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6072 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6073 e_* cousins.
6074 (alloca) [_MSC_VER]: Define to _alloca.
6075
6076 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6077
6078 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6079
a58c13ed
EZ
60802011-11-04 Eli Zaretskii <eliz@gnu.org>
6081
6082 * xdisp.c (note_mouse_highlight): If either of
6083 previous/next-single-property-change returns nil, treat that as
6084 the beginning or the end of the buffer. (Bug#9955)
6085
fe0b6370
JD
60862011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6087
a58c13ed 6088 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6089 label is not null (Bug#9951).
6090 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6091 may be NULL.
6092
89bd5ee1
EZ
60932011-11-04 Eli Zaretskii <eliz@gnu.org>
6094
6095 * window.c (Fwindow_body_size): Mention in the doc string that the
6096 return value is in frame's canonical units. (Bug#9949)
6097
84c3edb9
EZ
60982011-11-03 Eli Zaretskii <eliz@gnu.org>
6099
4e2fb5c7
EZ
6100 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6101
84c3edb9 6102 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6103 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6104 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6105
bc17a887
EZ
61062011-11-01 Eli Zaretskii <eliz@gnu.org>
6107
6108 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6109 Don't stop backward scan on the continuation glyph, even though
6110 its CHARPOS is positive.
6d5eb5b0
SM
6111 (mouse_face_from_buffer_pos, note_mouse_highlight):
6112 Rename cover_string to disp_string.
bc17a887 6113
4ee88440
MR
61142011-11-01 Martin Rudalics <rudalics@gmx.at>
6115
6116 * window.c (temp_output_buffer_show): Don't use
6117 Vtemp_buffer_show_specifiers.
6118 (Vtemp_buffer_show_specifiers): Remove unused variable.
6119
c2ff3c02
EZ
61202011-10-30 Eli Zaretskii <eliz@gnu.org>
6121
6122 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6123 past the beginning of the current glyph matrix.
6124
58179cce 61252011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6126
6127 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6128 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6129 HAVE_GTK3 (Bug#9869).
b77a6a7f 6130
3b574623
JD
6131 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6132 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6133
b77a6a7f
JD
6134 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6135
6136 * xterm.c: Declare x_handle_net_wm_state to return int.
6137 (handle_one_xevent): Check if we are iconified but don't have
6138 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6139 (get_current_wm_state): Return non-zero if not hidden,
6140 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6141 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6142 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6143 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6144
196e41e4
PE
61452011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6146
6147 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6148 so that this new function doesn't get optimized away by a
6149 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6150
021f2e1a
AS
61512011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6152
6153 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6154
8b058d44
EZ
61552011-10-29 Eli Zaretskii <eliz@gnu.org>
6156
6157 Fix the `xbytecode' command.
6158 * .gdbinit (xprintbytestr): New command.
b50a28de 6159 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6160 (xbytecode): Print the byte-code string as well.
6161
4452fb80
EZ
61622011-10-29 Kim Storm <storm@cua.dk>
6163
8b058d44
EZ
6164 * alloc.c (which_symbols): New function.
6165
21b72067
AS
61662011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6167
6168 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6169 line. (Bug#9903)
6170
83ed7b5c
GM
61712011-10-29 Glenn Morris <rgm@gnu.org>
6172
6173 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6174 Not clear what it was for, and it causes various bugs. (Bug#9839)
6175
5a7a728b
EZ
61762011-10-28 Eli Zaretskii <eliz@gnu.org>
6177
6178 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6179 possible random value that matches one of those tested as
6180 condition to clear the mouse face.
6181
d3d0842f
CY
61822011-10-28 Chong Yidong <cyd@gnu.org>
6183
6184 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6185
31b39d13
DN
61862011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6187
6188 * window.c (make_window): Initialize phys_cursor_on_p.
6189
9aba6043
SM
61902011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6191
6192 * lisp.h (struct Lisp_Symbol): Update comments.
6193
c20992f4
JB
61942011-10-28 Juanma Barranquero <lekktu@gmail.com>
6195
6196 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6197
db4f02f2
EZ
61982011-10-28 Eli Zaretskii <eliz@gnu.org>
6199
6200 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6201 <oslsachem@gmail.com> for helping to debug this.
6202
6203 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6204 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6205 (g_b_init_get_glyph_outline_w): New static variables.
6206 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6207 (GetGlyphOutlineW_Proc): New typedefs.
6208 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6209 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6210 New functions.
6211 (w32font_open_internal, compute_metrics):
6212 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6213 instead of calling the "wide" APIs directly.
6214
6215 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6216
6217 * w32.h (syms_of_w32font): Add prototype.
6218
87e68db4
JB
62192011-10-27 Juanma Barranquero <lekktu@gmail.com>
6220
6221 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6222 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6223 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6224 (Fmove_to_window_line): Doc fix.
6225
435c1d67
CY
62262011-10-27 Chong Yidong <cyd@gnu.org>
6227
6228 * process.c (make_process): Set gnutls_state to NULL.
6229
6230 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6231 non-NULL, regardless of GNUTLS_INITSTAGE.
6232 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6233 an error. Set process slots as soon as we allocate them.
6234
6235 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6236
9c6c6f49
CY
62372011-10-27 Chong Yidong <cyd@gnu.org>
6238
9aba6043
SM
6239 * gnutls.c (emacs_gnutls_deinit): New function.
6240 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6241 (Fgnutls_deinit, Fgnutls_boot): Use it.
6242
6243 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6244 (deactivate_process): Call emacs_gnutls_deinit.
6245
657d08d3
JB
62462011-10-27 Juanma Barranquero <lekktu@gmail.com>
6247
6248 * image.c (x_create_x_image_and_pixmap):
6249 * w32.c (sys_rename, w32_delayed_load):
6250 * w32font.c (fill_in_logfont):
6251 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6252
5430d399
JB
62532011-10-26 Juanma Barranquero <lekktu@gmail.com>
6254
6255 * w32fns.c (w32_default_color_map): New function,
6256 extracted from Fw32_default_color_map.
a7ef684b 6257 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6258
fe0055fa
PE
62592011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6260
6261 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6262
e6346438
SM
62632011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6264
6265 * keyboard.c (test_undefined): New function (bug#9751).
6266 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6267
e112cc37
ET
62682011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6269
6270 * sysdep.c (init_sys_modes): Fix the check for the controlling
6271 terminal (Bug#6649).
6272
7b5d6677
EZ
62732011-10-20 Eli Zaretskii <eliz@gnu.org>
6274
6275 * dispextern.h (struct bidi_it): New member next_en_type.
6276
6277 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6278 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6279 current character, check also for next_en_type being WEAK_EN.
6280 (bidi_resolve_weak): Don't enter the expensive loop if the current
6281 position is before next_en_pos. Record the bidi type of the first
6282 non-ET, non-BN character we find, in addition to its position.
6283 (bidi_level_of_next_char): Invalidate next_en_type when
6284 next_en_pos is over-stepped.
6285
7da0b018
PE
62862011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6287
6288 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6289 * editfns.c: Rewrite current-time-zone so that it invokes
6290 the equivalent of (format-time-string "%Z") to get the time zone name.
6291 This fixes a bug when the time zone name contains characters that
6292 need converting from the system time locale to Emacs internal format.
6293 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6294 that patch fixed format-time-string to do the conversion, but
6295 I forgot to fix current-time-zone.
6296 (format_time_string): New function, containing most of
6297 what Fformat_time_string used to contain.
6298 (Fformat_time_string): Rewrite in terms of format_time_string.
6299 This doesn't change this function's behavior.
6300 (current-time-zone): Rewrite to use format_time_string.
6301 This fixes the bug reported by Michael Schierl in
6302 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6303 Jason Rumney's 2007-06-07 change worked around this bug, but
6304 didn't fix it.
6305 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6306
8547b010
EZ
63072011-10-19 Eli Zaretskii <eliz@gnu.org>
6308
6309 * xdisp.c (start_display): If the character at POS is displayed
6310 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6311 (try_window_reusing_current_matrix): If a line ends in a display
6312 vector or the next line starts in a display vector, continue
6313 redrawing the window even though the character position of
6314 start_row was reached.
8547b010
EZ
6315 (Bug#9771, part 2)
6316
4e948d15
CY
63172011-10-18 Chong Yidong <cyd@gnu.org>
6318
6319 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6320 with nobreak-char-display too.
6321
4787455f
EZ
63222011-10-18 Eli Zaretskii <eliz@gnu.org>
6323
6324 Fix part 3 of bug#9771.
6325 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6326 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6327 non-neutral characters if the current character is a paragraph
6328 separator (a.k.a. Newline). This avoids running the same
6329 expensive loop twice, once when we consume the preceding newline
6330 and the other time when the line actually needs to be displayed.
6331 Avoid the loop when we see neutrals on the base embedding level
6332 following a character whose directionality is the same as the
6333 paragraph's. This avoids running the expensive loop when a line
6334 ends in a long sequence of neutrals, like control characters.
6335 Add assertion against STRONG_AL type. Slightly rearrange code
6336 that determines the type of a neutral given the first non-neutral
6337 that follows it.
6338 (bidi_level_of_next_char): Set next_en_pos to zero when
6339 invalidating its info.
6340
2c91f553
EZ
63412011-10-17 Eli Zaretskii <eliz@gnu.org>
6342
6343 * xdisp.c (push_display_prop): Determine whether to record string
6344 or buffer position by IT->string, not by IT->method. Allow
6345 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6346 (move_it_vertically_backward): Don't look for character position
6347 immediately after the newline when in a continuation line.
6348 (Bug#9771, part 1)
2c91f553 6349
c7b08b0d
MR
63502011-10-15 Martin Rudalics <rudalics@gmx.at>
6351
6352 * window.c (coordinates_in_window): Rewrite and delabelize
6353 vertical border check. (Bug#5357) (Bug#9618)
6354
6b02f655
SM
63552011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6356
6357 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6358 errors in XSetWindowBorder (bug#9310).
6359
81d40c92
DA
63602011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6361
6362 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6363 avoid crash when xmalloc overrun checking is enabled.
6364
d4172c3b
EZ
63652011-10-13 Eli Zaretskii <eliz@gnu.org>
6366
6367 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6368 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6369 cursor motion with <left> and <right> arrow keys.
6370
6371 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6372 some callers set that themselves.
6373
b00eea75
EZ
63742011-10-12 Eli Zaretskii <eliz@gnu.org>
6375
6376 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6377 display string and the previous row comes from the same string and
6378 is empty. (Bug#9739) (Bug#9738)
6379
8fe012c4
SM
63802011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6381
6382 * doc.c (get_doc_string): Encode file name (bug#9735).
6383
0074aef2
EZ
63842011-10-12 Eli Zaretskii <eliz@gnu.org>
6385
79beb178
EZ
6386 * bidi.c (bidi_level_of_next_char):
6387 * xdisp.c (get_visually_first_element): Remove old incorrect
6388 comments regarding the Unicode Line Separator character.
6389
0074aef2
EZ
6390 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6391
6e4b3fbe
DA
63922011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6393
6394 * alloc.c (Fgc_status): Do not access beyond zombies array
6395 boundary if nzombies > MAX_ZOMBIES.
6396 * alloc.c (dump_zombies): Add missing format specifier.
6397
0324f3af
PE
63982011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6399
b5525cac
PE
6400 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6401 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6402
0324f3af
PE
6403 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6404 Some packages use them to denote characters with modifiers.
6405
e9b5f888
AS
64062011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6407
6408 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6409 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6410 matching a pp-number. Rename parameter var to var1.
6411
127827c0
SM
64122011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6413
6414 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6415
c8fd3bd0
GM
64162011-10-08 Glenn Morris <rgm@gnu.org>
6417
6418 * callint.c (Fcall_interactively): Give a more explicit error for the
6419 'c' case with a non-character input. (Bug#8479)
6420
352ec8ff
EZ
64212011-10-08 Eli Zaretskii <eliz@gnu.org>
6422
03669ccb
EZ
6423 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6424 lines.
7061c986
EZ
6425 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6426 lines that are hscrolled on the left.
03669ccb 6427
352ec8ff
EZ
6428 * dispnew.c (buffer_posn_from_coords): Account for a possible
6429 presence of header-line. (Bug#4426)
6430
a66cfb1c
SM
64312011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6432
6b02f655
SM
6433 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6434 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6435
7c5ee88e
PE
64362011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6437
6438 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6439 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6440 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6441 this makes Emacs dump core during garbage collection on rare
6442 occasions. sizeof is obviously inferior to offsetof here, so
6443 stick with offsetof.
6444 (GC_POINTER_ALIGNMENT): New macro.
6445 (mark_memory): Omit 3rd (offset) arg; caller changed.
6446 Don't assume EMACS_INT alignment is the same as pointer alignment.
6447
df1bbe5b
SM
64482011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6449
6450 * keyboard.c (read_key_sequence_remapped): New var.
6451 (read_key_sequence): Compute remapping in the right buffer.
6452 (command_loop_1): Use read_key_sequence's remapping directly.
6453
51553db6
SM
64542011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6455
32c1fffd
SM
6456 * dired.c (file_name_completion): Don't expand file name.
6457 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6458 before checking file name handler.
6459
51553db6
SM
6460 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6461 they've been requested explicitly (bug#9591).
6462
b6bd1599 64632011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6464
6465 * keymap.c (Fsingle_key_description): Use make_specified_string
6466 instead of build_string to build string from push_key_description.
6467 (Bug#5193)
6468
f701dc2a
PE
64692011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6470
4222c55d
PE
6471 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6472 This fixes a Y2038 bug on 64-bit hosts.
6473 * buffer.c (reset_buffer):
6474 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6475 (Fclear_buffer_auto_save_failure):
6476 Use 0, not -1, to represent an unset failure time, since time_t
6477 might not be signed.
6478
f701dc2a
PE
6479 Remove dependency on glibc malloc internals.
6480 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6481 Move back here from lisp.h, but with their new implementations.
6482 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6483 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6484 * charset.c (charset_table_init): New static var.
6485 (syms_of_charset): Use it instead of xmalloc. This removes a
6486 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6487 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6488 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6489 Move back to alloc.c.
6490 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6491 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6492
9ceebf39
JD
64932011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6494
6495 * nsterm.m (windowDidResize): Call x_set_window_size only when
6496 ns_in_resize is true. Otherwise set pixelwidth/height and
6497 call change_frame_size (Bug#9628).
6498
cb993c58
PE
64992011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6500
3930c88b
PE
6501 Port --enable-checking=all to Fedora 14 x86-64.
6502 * charset.c (syms_of_charset): Also account for glibc malloc's
6503 internal overhead when calculating the initial malloc maximum.
6504
cb993c58
PE
6505 Port --enable-checking=all to Fedora 14 x86.
6506 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6507 Move to lisp.h.
6508 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6509 (overrun_check_realloc, overrun_check_free):
6510 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6511 That way, xmalloc returns a properly-aligned pointer even if
6512 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6513 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6514 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6515 into account when calculating the initial malloc maximum.
6516 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6517 Move here from alloc.c, so that charset.c can use it too.
6518 Properly align; the old code wasn't right for common 32-bit hosts
6519 when configured with --enable-checking=all.
6520 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6521 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6522
31bed486
EZ
65232011-09-29 Eli Zaretskii <eliz@gnu.org>
6524
04c70788 6525 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6526 use EDOM.
6527
fbcaa2f3
EZ
65282011-09-28 Eli Zaretskii <eliz@gnu.org>
6529
6530 * xdisp.c (compute_display_string_end): If there's no display
6531 string at CHARPOS, return -1.
6532
6533 * bidi.c (bidi_fetch_char): When compute_display_string_end
6534 returns a negative value, treat the character as a normal
6535 character not covered by a display string. (Bug#9624)
6536
a239d4e9
JB
65372011-09-28 Juanma Barranquero <lekktu@gmail.com>
6538
6539 * lread.c (Fread_from_string): Fix typo in docstring.
6540
88652fd5
EZ
65412011-09-27 Eli Zaretskii <eliz@gnu.org>
6542
6543 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6544 newline, reseat the iterator instead of bidi-iterating there one
6545 character at a time. (Bug#9610)
32c1fffd
SM
6546 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6547 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6548
ed497dd4
AS
65492011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6550
6551 * lread.c (readevalloop): Use correct code for NBSP.
6552 (read1): Likewise. (Bug#9608)
6553
b2bf61aa
MA
65542011-09-25 Michael Albinus <michael.albinus@gmx.de>
6555
6556 * dbusbind.c (Fdbus_register_signal): When service is not
6557 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6558
32bbb17c
GM
65592011-09-25 Glenn Morris <rgm@gnu.org>
6560
6561 * buffer.c (truncate-lines): Doc fix.
6562
94e0933e
CY
65632011-09-24 Chong Yidong <cyd@stupidchicken.com>
6564
6565 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6566 (Fset_window_next_buffers): Doc fix.
6567
cddde921
GM
65682011-09-24 Glenn Morris <rgm@gnu.org>
6569
6570 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6571
1260aef1
PE
65722011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6573
25b4bfa0
PE
6574 Fix minor problems found by static checking.
6575 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6576 * indent.c (Fvertical_motion): Fix == vs = typo.
6577
e3cbd34b
EZ
65782011-09-24 Eli Zaretskii <eliz@gnu.org>
6579
a66cfb1c
SM
6580 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6581 Default value is now t. Doc fix.
6bf7006f 6582
e3cbd34b 6583 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6584 logic when moving up, not only when moving down. Fix the
e3cbd34b 6585 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6586 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6587
6588 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6589 CHARPOS is covered by a display string which includes newlines.
6590 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6591 is covered by a display string with embedded newlines.
6592
a3de0cbd
MA
65932011-09-24 Michael Albinus <michael.albinus@gmx.de>
6594
6595 * dbusbind.c (Fdbus_register_signal): Add match rule to
6596 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6597 (Fdbus_register_method, Vdbus_registered_objects_table):
6598 Fix docstring.
a3de0cbd 6599
b260039d
JM
66002011-09-24 Jim Meyering <meyering@redhat.com>
6601
32c1fffd 6602 do not ignore write error for any output size
b260039d
JM
6603 The previous change was incomplete.
6604 While it makes emacs --batch detect the vast majority of stdout
6605 write failures, errors were still ignored whenever the output size is
6606 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6607 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6608 && echo FAIL: ignored write error
6609 FAIL: ignored write error
6610 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6611 && echo FAIL: ignored write error
6612 FAIL: ignored write error
6613 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6614
8eca8a7c
AS
66152011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6616
6617 * emacs.c (Fkill_emacs): In noninteractive mode exit
6618 non-successfully if a write error occurred on stdout. (Bug#9574)
6619
3341db62
EZ
66202011-09-21 Eli Zaretskii <eliz@gnu.org>
6621
6622 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6623 the xassert test.
6624
6625 * dispextern.h (struct it): Update the comment documenting what
6626 can it->OBJECT be.
6627
8c203dbf
EZ
66282011-09-20 Eli Zaretskii <eliz@gnu.org>
6629
6630 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6631 a display string, extend search for cursor position to end of row.
6632 (find_row_edges): If the row ends in a newline from a display
6633 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6634 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6635 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6636 non-empty line. Fixes confusing cursor motion with arrow keys at
6637 the beginning of a line that starts with whitespace.
8c203dbf 6638
a4824228
LMI
66392011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6640
6641 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6642 (bug#9493).
6643
33ed493b
CY
66442011-09-18 Chong Yidong <cyd@stupidchicken.com>
6645
6646 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6647 boolean (Bug#9154).
6648
56cd55c8
EZ
66492011-09-18 Eli Zaretskii <eliz@gnu.org>
6650
6651 * xdisp.c (display_line): Record maximum and minimum buffer
6652 positions even if no glyphs were produced (e.g., by a zero-width
6653 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6654 buffer positions that will be removed from the glyph row because
6655 they don't fit.
c02dcedf
EZ
6656 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6657 column is beyond frame width: don't subtract 1 "pixel" when
6658 computing width of the stretch.
3e62b7e0
EZ
6659 (reseat_at_next_visible_line_start): Undo the change made on
6660 2011-09-17 that saved paragraph information and restored it after
6661 the call to `reseat'. (Bug#9545)
56cd55c8 6662
5ed99d36 66632011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6664
6665 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6666 and turn window cursor on if cleared (Bug#9415).
6667
5ed99d36 66682011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6669
6670 * search.c (boyer_moore): Take unibyte characters from pattern
6671 literally. (Bug#9458)
6672
9bade7b2
EZ
66732011-09-18 Eli Zaretskii <eliz@gnu.org>
6674
6675 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6676
e5e9d610
PE
66772011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6678
87e4427a
PE
6679 Fix minor problem found by static checking.
6680 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6681 initialized, to pacify gcc -Wuninitialized.
6682
e5e9d610
PE
6683 * fileio.c: Report proper errno when syscall falls.
6684 (Finsert_file_contents): Save and restore errno,
6685 so that report_file_error outputs the correct diagnostic.
6686 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6687
a1674f0b
EZ
66882011-09-18 Eli Zaretskii <eliz@gnu.org>
6689
6690 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6691
fbfb6dd4
EZ
66922011-09-17 Eli Zaretskii <eliz@gnu.org>
6693
6694 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6695 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6696
bb187662
EZ
66972011-09-17 Eli Zaretskii <eliz@gnu.org>
6698
1137e8b8 6699 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6700 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6701
6702 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6703 (bidi_find_paragraph_start): Search back for paragraph beginning
6704 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6705 (bidi_move_to_visually_next): Only trigger paragraph-related
6706 computations when the last character is a newline or at EOB, not
6707 just any NEUTRAL_B. (Bug#9470)
6708
bb187662
EZ
6709 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6710 truncated lines if point is covered by a display string. (Bug#9524)
6711
2e621251
PE
67122011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6713
6714 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6715 (cons_to_x_long): New function.
6716 (lisp_data_to_selection_data): Use it. Correct the test for
6717 short-versus-long data; it was negated. Break out of vector
6718 loop, for efficiency, when a long datum is discovered.
6719
91a15bc6
SM
67202011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6721
6722 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6723
b41c3a35
EZ
67242011-09-16 Eli Zaretskii <eliz@gnu.org>
6725
6726 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6727 GCC PR/17406) by declaring this function with external scope.
6728
7812ba2d
PE
67292011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6730
6731 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6732 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6733
cf7edc2a
AS
67342011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6735
6736 * editfns.c (Fformat): Correctly handle text properties on "%%".
6737
bd01620e
EZ
67382011-09-15 Eli Zaretskii <eliz@gnu.org>
6739
6740 * xterm.c (x_draw_composite_glyph_string_foreground):
6741 * w32term.c (x_draw_composite_glyph_string_foreground):
6742 * term.c (encode_terminal_code):
6743 * composite.c (composition_update_it, get_composition_id):
6744 * xdisp.c (get_next_display_element)
6745 (fill_composite_glyph_string): Add comments about special meaning
6746 of TAB characters in a composition.
6747
a02719a3
PE
67482011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6749
6750 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6751 This occurs when processing a multibyte format.
6752 Problem reported by Wolfgang Jenker.
a02719a3 6753
72589a3c
JB
67542011-09-15 Johan Bockgård <bojohan@gnu.org>
6755
6756 * xdisp.c (try_cursor_movement): Only check for exact match if
6757 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6758
1c14176c
PE
67592011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6760
6761 Remove unused external symbols.
6762 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6763 * xdisp.c (calc_pixel_width_or_height): Now static.
6764 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6765 * indent.c (check_display_width):
6766 * w32term.c: Fix comment to match code.
6767 * xterm.c, xterm.h (x_catching_errors): Remove.
6768
d2eea5b5
PE
67692011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6770
6771 * xselect.c: Use signed conversions more consistently (Bug#9498).
6772 (selection_data_to_lisp_data): Assume incoming selection data are
6773 signed integers, not unsigned. This is to be consistent with
6774 outgoing selection data, which was modified to use signed integers
6775 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6776 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6777 expects long, not unsigned long.
6778
46888499
EZ
67792011-09-14 Eli Zaretskii <eliz@gnu.org>
6780
6781 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6782 computation of loop end. Reported by Johan Bockgård
6783 <bojohan@gnu.org>.
6784
ef8ef9fb
CY
67852011-09-13 Chong Yidong <cyd@stupidchicken.com>
6786
6787 * frame.c (Fother_visible_frames_p): Function deleted.
6788
fa819fed
EZ
67892011-09-12 Eli Zaretskii <eliz@gnu.org>
6790
6791 * indent.c (compute_motion): Process display vector front to back
6792 rather than the other way around. (Bug#2496)
6793
2ba8e008
SM
67942011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6795
6796 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6797
20f53c69
CY
67982011-09-11 Chong Yidong <cyd@stupidchicken.com>
6799
6800 * minibuf.c (Fread_from_minibuffer): Doc fix.
6801
d562d7a4
EZ
68022011-09-11 Eli Zaretskii <eliz@gnu.org>
6803
6804 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6805 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6806
1c4d7f3d
LMI
68072011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6808
6809 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6810 value for non-existent files.
6811
b885bf36
EZ
68122011-09-11 Eli Zaretskii <eliz@gnu.org>
6813
6814 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6815 set its "size" to -1. This will set the modtime_size field of
6816 the corresponding buffer to -1, which is what
6817 verify-visited-file-modtime expects for files that do not exist.
6818 (Bug#9139)
6819
6612f0bf
PE
68202011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6821
6822 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6823 here ...
6824 * lisp.h: ... from here. push_key_description is no longer
6825 defined in keyboard.c, so its declaration should not be in
6826 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6827 logically belongs with push_key_description.
6828
dfb3f755
PE
68292011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6830
6831 * buffer.h: Include <sys/types.h> instead of <time.h>.
6832 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6833 Problem reported by Herbert J. Skuhra.
6834
3134906c
LMI
68352011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6836
6837 * xml.c (parse_region): Make the parsing work for
6838 non-comment-starting XML files again (bug#9144).
6839
8d903f4e
AS
68402011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6841
6842 * image.c (gif_load): Fix calculation of bottom and right corner.
6843 (Bug#9468)
6844
80ad64f4
EZ
68452011-09-10 Eli Zaretskii <eliz@gnu.org>
6846
6847 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6848 redisplay in small windows.
6849
208a048d
EZ
68502011-09-09 Eli Zaretskii <eliz@gnu.org>
6851
6852 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6853
9b1c252e
MR
68542011-09-08 Martin Rudalics <rudalics@gmx.at>
6855
6856 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6857 Operate on live windows only.
6858
2949f33b
JB
68592011-09-08 Juanma Barranquero <lekktu@gmail.com>
6860
6861 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6862
e08dcafd
EZ
68632011-09-07 Eli Zaretskii <eliz@gnu.org>
6864
6865 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6866 only under bidi iteration.
6867
115b96bd
JD
68682011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6869
6870 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6871
c8199d0f
PE
68722011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6873
6874 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6875 Without this fix, the command to link temacs failed due to an
6876 undefined symbol __builtin_isnan. This is because
6877 /usr/include/iso/math_c99.h #defines isnan(x) to
6878 __builtin_isnan(x), but the bundled gcc, which identifies itself
6879 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6880 a __builtin_isnan.
6881 * floatfns.c (isnan): #undef, and then #define to a clone of
6882 what's in data.c.
6883 (Fisnan): Always define, since it's always available now.
6884 (syms_of_floatfns): Always define isnan at the Lisp level.
6885
e39b275c 68862011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6887
6888 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6889
b2db44d9 68902011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6891
f4af5137 6892 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6893 The previous code assumed that file offsets (off_t values) fit in
6894 EMACS_INT variables, which is not true on typical 32-bit hosts.
6895 The code messed up by falsely reporting buffer overflow in cases
6896 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6897 when "big" contains more than 2**29 bytes, even though this
6898 inserts just one byte and does not overflow the buffer.
6899 (Finsert_file_contents): Store file offsets as off_t
6900 values, not as EMACS_INT values. Check for overflow when
6901 converting between EMACS_INT and off_t. When checking for
6902 buffer overflow or for overlap, take the offsets into account.
6903 Don't use EMACS_INT for small values where int suffices.
6904 When checking for overlap, fix a typo: ZV was used where
6905 ZV_BYTE was intended.
6906 (Fwrite_region): Don't assume off_t fits into 'long'.
6907 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6908
ecfc0a49
MA
69092011-09-05 Michael Albinus <michael.albinus@gmx.de>
6910
6911 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6912
6511acf2 69132011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6914
0999621a 6915 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6916
6917 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6918 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6919 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6920 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6921 (modify_event_symbol): Do not assume that the length of
6922 name_alist_or_stem is safe to alloca and fits in int.
6923 (Fexecute_extended_command): Likewise for function name and binding.
6924 (Frecursion_depth): Wrap around reliably on integer overflow.
6925 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6926 since some callers pass EMACS_INT values.
6927 (Fsingle_key_description): Don't crash if symbol name contains more
6928 than MAX_ALLOCA bytes.
6929 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6930 (get_minibuffer): Arg is now EMACS_INT, not int.
6931 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6932 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6933 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6934
2be7d702
PE
6935 * dbusbind.c (signature_cat): New function.
6936 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6937 Do not overrun buffer; instead, report string overflow.
6938
9d1df220
PE
6939 * dispnew.c (add_window_display_history): Don't overrun buffer.
6940 Truncate instead; this is OK since it's just a log.
6941
33ef5c64
PE
6942 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6943 even if the time zone offset is outlandishly large.
6944 Don't mishandle offset == INT_MIN.
6945
66c6fdd5
PE
6946 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6947 when creating daemon; the previous buffer-overflow check was incorrect.
6948
d749b01b
PE
6949 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6950 which has the guts of the old verror function.
6951
b5cd1905
PE
6952 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6953 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6954
6e1a67fb
PE
6955 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6956 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6957 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6958 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6959 length of string rather than counting it via multiple sprintfs;
6960 that's simpler and more reliable.
c21721cc
PE
6961 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6962 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6963 sprintf, in case result does not fit in int.
6964
c57b67fc
PE
6965 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6966 (fontset_from_font): Print it.
6967
8a401434
PE
6968 * frame.c (tty_frame_count): Now printmax_t, not int.
6969 (make_terminal_frame, set_term_frame_name): Print it.
6970 (x_report_frame_params): In X, window IDs are unsigned long,
6971 not signed long, so print them as unsigned.
6972 (validate_x_resource_name): Check for implausibly long names,
6973 and don't assume name length fits in 'int'.
6974 (x_get_resource_string): Don't blindly alloca invocation name;
6975 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6976 not fit in int.
6977
6e1a67fb
PE
6978 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6979 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6980 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6981
0df02bf3
PE
6982 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6983 Use esprintf, not sprintf, in case result does not fit in int.
6984
48e30793
PE
6985 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6986 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6987 it as a large positive number.
6988 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6989 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6990
a66ff6d8
PE
6991 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6992 in case result does not fit in int.
6993
aca216ff
PE
6994 * print.c (float_to_string): Detect width overflow more reliably.
6995 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6996 buffer overrun. Don't assume list length fits in 'int'. Treat
6997 print length of 0 as 0, not as infinity; to be consistent with other
6998 uses of print length in this function. Don't overflow print length
6999 index. Don't assume hash table size fits in 'long', or that
7000 vectorlike size fits in 'unsigned long'.
7001
31c286f7
PE
7002 * process.c (make_process): Use printmax_t, not int, to format
7003 process-name gensyms.
7004
55e5faa1
PE
7005 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7006
80f2e268
PE
7007 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7008 to avoid potential buffer overrun.
7009
670741ab
PE
7010 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7011 if X resource line is longer than 512 bytes.
7012
b7163a50
PE
7013 * xfns.c (x_window): Make sprintf buffer a bit bigger
7014 to avoid potential buffer overrun.
7015
ae58ff1f
PE
7016 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7017
c43c8a6a
PE
7018 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7019
3f8236f4
PE
70202011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7021
53e9fe90 7022 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7023 Without these, Emacs silently mishandles large integers sometimes.
7024 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7025 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7026
6511acf2
PE
7027 * xdisp.c (try_window_id): Check Emacs fixnum range before
7028 converting to 'int'.
806add1d 7029
6511acf2 7030 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7031 Check that an Emacs fixnum is in range before assigning it to 'int'.
7032 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7033 values converted from Emacs fixnums.
7034 (Frecenter): Don't wrap around a line count if it is out of 'int'
7035 range; instead, treat it as an extreme value.
7036 (Fset_window_configuration, compare_window_configurations):
7037 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7038
6511acf2
PE
7039 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7040 that can exceed INT_MAX. Check that EMACS_INT value is in range
7041 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7042 (match_limit): Don't assume that a fixnum can fit in 'int'.
7043
6511acf2 7044 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7045 exceed INT_MAX.
7046
6511acf2 7047 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7048 (Fvertical_motion): Don't wrap around LINES values that don't fit
7049 in 'int'. Instead, treat them as extreme values. This is good
7050 enough for windows, which can't have more than INT_MAX lines anyway.
7051
fcb901a7
LMI
70522011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7053
0f2f6b6d
LMI
7054 * Require libxml/parser.h to avoid compilation warning.
7055
fcb901a7
LMI
7056 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7057
7058 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7059 since this reportedly can destroy thread storage.
7060
6e20a0d4
CY
70612011-08-30 Chong Yidong <cyd@stupidchicken.com>
7062
7063 * syntax.c (find_defun_start): Update all cache variables if
7064 exiting early (Bug#9401).
7065
148ae00e
EZ
70662011-08-30 Eli Zaretskii <eliz@gnu.org>
7067
f6cfbd8f
EZ
7068 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7069
148ae00e
EZ
7070 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7071 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7072 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7073
7074 * term.c (tty_append_glyph): New function.
7075 (produce_stretch_glyph): Static function and its prototype deleted.
7076
a66cfb1c
SM
7077 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7078 Add prototypes.
148ae00e 7079
c4a07a4c
PE
70802011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7081
7082 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7083 when checking :margin (Bug#9390).
7084 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7085 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7086 so that the name doesn't mislead. All uses changed.
7087
6bc8cd65
JB
70882011-08-28 Johan Bockgård <bojohan@gnu.org>
7089
7090 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7091 set_tty_hooks.
7092
dca4927e
EZ
70932011-08-27 Eli Zaretskii <eliz@gnu.org>
7094
7095 * xdisp.c (move_it_to): Don't bail out early when reaching
7096 position beyond to_charpos, if we are scanning backwards.
7097 (move_it_vertically_backward): When DY == 0, make sure we get to
7098 the first character in the line after the newline.
7099
f2cad773
PE
71002011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7101
7102 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7103 (ccl_driver): Do not generate an out-of-range pointer.
7104 (Fccl_execute_on_string): Remove unnecessary check for
7105 integer overflow, noted by Stefan Monnier in
7106 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7107 Remove a FIXME that didn't need fixing.
7108 Simplify the newly-introduced buffer reallocation code.
7109
0cae2cdb
JB
71102011-08-27 Juanma Barranquero <lekktu@gmail.com>
7111
7112 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7113
5fc295a4 71142011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7115
70c60eb2 7116 Integer and memory overflow issues (Bug#9196).
726e0ab1 7117
d31850da
PE
7118 * doc.c (get_doc_string): Rework so that
7119 get_doc_string_buffer_size is the actual buffer size, rather than
7120 being 1 less than the actual buffer size; this makes xpalloc more
7121 convenient.
7122
a69fbedb
PE
7123 * image.c (x_allocate_bitmap_record, cache_image):
7124 * xselect.c (Fx_register_dnd_atom):
7125 Simplify previous changes by using xpalloc.
7126
fe5c5d37
PE
7127 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7128 since either will do and ptrdiff_t is convenient with xpalloc.
7129
0065d054
PE
7130 * charset.c (charset_table_size)
7131 (struct charset_sort_data.priority): Now ptrdiff_t.
7132 (charset_compare): Don't overflow if priorities differ greatly.
7133 (Fsort_charsets): Don't assume list length fits in int.
7134 Check for size-calculation overflow when allocating sort data.
7135 (syms_of_charset): Allocate an initial charset table that is
7136 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7137
7138 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7139
7140 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7141 The actual value is always <= INT_MAX, and leaving it unsigned made
7142 overflow checking harder.
7143
7144 * dispextern.h (struct glyph_matrix.rows_allocated)
7145 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7146 with xpalloc. The values are still always <= INT_MAX.
7147
7148 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7149
7150 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7151 (SAFE_NALLOCA): New macro.
7152
7153 * region-cache.c (struct boundary.pos, find_cache_boundary)
7154 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7155 (set_cache_region, invalidate_region_cache)
7156 (revalidate_region_cache, know_region_cache, region_cache_forward)
7157 (region_cache_backward, pp_cache):
7158 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7159 so that ptrdiff_t * can be passed to xpalloc.
7160 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7161 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7162 (pp_cache): Don't assume cache_len fits in int.
7163 * region-cache.h: Adjust extern decls to match.
7164
7165 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7166 EMACS_INT, since either will do, for xpalloc.
7167
7168 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7169 (xnmalloc, xnrealloc, xpalloc): New functions.
7170
726e0ab1
PE
7171 * bidi.c (bidi_shelve_header_size): New constant.
7172 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7173 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7174
51f30bc5 7175 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7176 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7177 (overlay_strings):
7178 Don't update size of array until after memory allocation succeeds,
7179 because xmalloc/xrealloc may not return.
0065d054
PE
7180 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7181 now that we have proper integer overflow checking.
7182 (record_overlay_string, overlay_strings): Catch overflows when
7183 calculating size of overlay_str_buf.
726e0ab1 7184
0065d054
PE
7185 * callproc.c (Fcall_process): Check for size overflow when
7186 calculating size of args2.
7187 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7188 Normally we prefer signed values, but sticking with ptrdiff_t would
7189 require adding more-complicated checks.
726e0ab1
PE
7190
7191 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7192 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7193 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7194 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7195
7196 * character.c (Fstring): Check for size-calculation overflow.
7197
7198 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7199 unnecessary integer overflow. Check for size overflow.
7200 (encode_coding_object): Don't update size until xmalloc succeeds.
7201
7202 * composite.c (get_composition_id): Check for overflow in glyph
7203 length calculations.
7204
7205 Integer and memory overflow fixes for display code.
7206 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7207 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7208 (scrolling_window): Check for overflow in size calculations.
7209 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7210 Don't assume glyph table len fits in int.
7211 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7212 (row_table_size): Now ptrdiff_t, not int.
7213 (scrolling_window): Avoid overflow in size calculations.
7214 Don't update size until allocation succeeds.
7215 * fns.c (concat): Check for overflow in size calculations.
7216 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7217 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7218 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7219
7220 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7221 (get_doc_string): Check for size calculation overflow.
7222 Don't update size until allocation succeeds.
7223 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7224 EMACS_INT, where ptrdiff_t will do.
7225 (Fsubstitute_command_keys): Check for string overflow.
7226
7227 * editfns.c (set_time_zone_rule): Don't assume environment length
7228 fits in int.
7229 (message_length): Now ptrdiff_t, not int.
7230 (Fmessage_box): Don't update size until allocation succeeds.
7231 Don't assume message length fits in int.
7232 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7233
0065d054
PE
7234 * emacs.c (main): Do not reallocate argv, since there is a null at
7235 the end that can be overwritten, and this way there's no need to
7236 worry about size-calculation overflow.
7237 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7238
7239 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7240 alloc succeeds.
7241 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7242
7243 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7244 (x_set_scroll_bar_width, x_figure_window_size):
7245 Check for integer overflow.
7246 (x_set_alpha): Do not assume XINT fits in int.
7247
7248 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7249 This is for the members text_lines, text_cols, total_lines, total_cols,
7250 where the system imposes an 'int' limit.
7251
7252 * fringe.c (Fdefine_fringe_bitmap):
7253 Don't update size until alloc works.
7254
7255 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7256 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7257
7258 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7259 Check for size-calculation overflow.
7260 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7261 do, as we prefer signed integers.
7262 (id_to_widget.max_size, id_to_widget.used)
7263 (xg_store_widget_in_map, xg_remove_widget_from_map)
7264 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7265 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7266 Use and return ptrdiff_t, not int.
7267 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7268 * gtkutil.h: Change prototypes to match the above.
7269
7270 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7271 are duplicate now that they've been promoted to lisp.h.
7272 (x_allocate_bitmap_record, x_alloc_image_color)
7273 (make_image_cache, cache_image, xpm_load):
7274 Don't update size until alloc is done.
7275 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7276 (x_detect_edges):
3256efce 7277 Check for size calculation overflow.
726e0ab1
PE
7278 (ct_colors_allocated_max): New constant.
7279 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7280 overflow.
3256efce 7281
726e0ab1
PE
7282 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7283 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7284 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7285 Use ptrdiff_t, not int, to count maps.
7286 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7287 calculations. Don't update size until allocation succeeds.
7288 Redo calculations to avoid overflow.
726e0ab1
PE
7289 * keyboard.h: Change prototypes to match the above.
7290
7291 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7292 to count maps.
7293 (current_minor_maps): Check for size calculation overflow.
7294 * keymap.h: Change prototypes to match the above.
7295
7296 * lread.c (read1, init_obarray): Don't update size until alloc done.
7297
7298 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7299 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7300
726e0ab1
PE
7301 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7302 Now ptrdiff_t, not int.
7303 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7304 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7305
7306 * process.c (Fnetwork_interface_list): Check for overflow
7307 in size calculation.
7308
7309 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7310
7311 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7312 overflow. Don't bother calling xmalloc when xrealloc will do.
7313
7314 * search.c (Freplace_match): Check for size calculation overflow.
7315 (Fset_match_data): Don't assume list lengths fit in 'int'.
7316
7317 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7318 for command line length. Do not attempt to address one before the
7319 beginning of an array, as that's not portable.
7320
7321 * term.c (max_frame_lines): Remove; unused.
7322 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7323 not int.
7324 (encode_terminal_code, calculate_costs): Check for size
7325 calculation overflow.
7326 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7327 table lengths and related sizes. Don't update size until alloc
7328 done. Redo calculations to avoid overflow.
7329 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7330
7331 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7332 subtracting pointers.
7333 (gobble_line): Check for overflow more carefully. Don't update size
7334 until alloc done.
7335
7336 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7337 Don't update size until alloc done.
7338 Redo size calculations to avoid overflow.
7339 Check for size calculation overflow.
0065d054 7340 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7341
7342 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7343 Use ptrdiff_t, not int, for sizes.
7344 (store_mode_line_noprop_char): Don't update size until alloc done.
7345
0065d054
PE
7346 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7347 Use ptrdiff_t, not int, for sizes.
7348 (Finternal_make_lisp_face, cache_face):
7349 Check for size calculation overflow.
7350 (cache_face): Treat size calculation overflows as if they were
7351 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7352
7353 * xfns.c (x_encode_text, x_set_name_internal)
7354 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7355 sizes, since they can exceed INT_MAX in size. Check for size
7356 calculation overflow.
7357
0065d054
PE
7358 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7359 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7360 Don't update size until alloc done.
7361
0065d054 7362 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7363 as sprintf is limited to int lengths.
1d526e2f 7364
252c5ee1
PE
7365 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7366 (X_LONG_MIN): New macros.
864d7ce7
PE
7367 Use them to make the following changes clearer.
7368 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7369 This change doesn't affect the value now, but it may help remind
7370 future maintainers not to raise the value too much later.
7371 (SELECTION_QUANTUM): Remove, replacing with ...
7372 (selection_quantum): ... new function, which avoids overflow.
7373 All uses changed.
7374 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7375 assumption that selection length fits in 'int'.
7376 (x_reply_selection_request, x_handle_selection_request)
7377 (x_get_window_property, receive_incremental_selection)
7378 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7379 (lisp_data_to_selection_data, clean_local_selection_data):
7380 Use ptrdiff_t, not int, to record length of selection.
7381 (x_reply_selection_request, x_get_window_property)
7382 (receive_incremental_selection, x_property_data_to_lisp):
7383 Redo calculations to avoid overflow.
7384 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7385 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7386 something.
7387 (x_get_window_property, receive_incremental_selection)
7388 (lisp_data_to_selection_data, x_property_data_to_lisp):
7389 Check for size-calculation overflow.
7390 (x_get_window_property, receive_incremental_selection)
7391 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7392 Don't store size until memory allocation succeeds.
7393 (x_get_window_property): Plug memory leak on memory exhaustion.
7394 Don't double-block input; malloc is safe here. Don't assume 2**34
7395 - 4 fits in unsigned long. Add an xassert to check
7396 XGetWindowProperty overflow. Be more careful about overflow
7397 calculations, and distinguish size from memory overflow better.
7398 (receive_incremental_selection): When tracing, don't assume
7399 unsigned int is less than INT_MAX.
7400 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7401 harmful) conversions of unsigned short to int.
7402 (lisp_data_to_selection_data): Don't assume that integers
7403 in the range -65535 through -1 fit in an X unsigned short.
7404 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7405 result parameters unless successful. Rely on cons_to_unsigned
7406 to report problems with elements; the old code wasn't right anyway.
7407 (x_check_property_data): Check for int overflow; we cannot use
7408 a wider type due to X limits.
7409 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7410
726e0ab1 7411 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7412
0065d054
PE
7413 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7414 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7415 (x_color_cells): Don't store size until memory allocation succeeds.
7416 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7417 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7418 (x_term_init): Don't assume length fits in int (sprintf is limited
7419 to int size).
bc18e09d 7420
ebfa62c0
PE
7421 Use ptrdiff_t for composition IDs.
7422 * character.c (lisp_string_width):
7423 * composite.c (composition_table_size, n_compositions)
7424 (get_composition_id, composition_gstring_from_id):
7425 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7426 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7427 * window.c (Frecenter):
7428 Use ptrdiff_t, not int, for composition IDs.
7429 * composite.c (get_composition_id): Check for integer overflow.
7430 * composite.h: Adjust prototypes to match the above changes.
7431
d3411f89
PE
7432 Use ptrdiff_t for hash table indexes.
7433 * category.c (hash_get_category_set):
7434 * ccl.c (ccl_driver):
7435 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7436 * coding.c (coding_system_charset_list, detect_coding_system):
7437 * coding.h (struct coding_system.id):
7438 * composite.c (get_composition_id, gstring_lookup_cache):
7439 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7440 * image.c (xpm_get_color_table_h):
7441 * lisp.h (hash_lookup, hash_put):
7442 * minibuf.c (Ftest_completion):
7443 Use ptrdiff_t for hash table indexes, not int (which is too
7444 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7445 32-bit --with-wide-int hosts).
7446
e097a6fa
PE
7447 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7448 Add a FIXME comment about memory leaks.
7449 (syms_of_charset): Don't assume xmalloc returns.
7450
5637687f
PE
7451 Don't assume that stated character widths fit in int.
7452 * character.c (Fchar_width, c_string_width, lisp_string_width):
7453 * character.h (CHAR_WIDTH):
7454 * indent.c (MULTIBYTE_BYTES_WIDTH):
7455 Use sanitize_char_width to avoid undefined and/or bad behavior
7456 with outlandish widths.
a66cfb1c 7457 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7458 now that we have two such functions. All uses changed.
7459 (sanitize_char_width): New inline function.
7460
a2271ba2
PE
7461 Don't assume that tab-width fits in int.
7462 * character.h (sanitize_width): New inline function.
7463 (SANE_TAB_WIDTH): New macro.
7464 (ASCII_CHAR_WIDTH): Use it.
7465 * indent.c (sane_tab_width): Remove. All uses replaced by
7466 SANE_TAB_WIDTH (current_buffer).
7467 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7468
18c52557
PE
7469 * fileio.c: Integer overflow issues with file modes.
7470 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7471
caeeedc1
PE
7472 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7473 Remove unreachable code.
7474 (read_hex, load_charset_map_from_file): Check for integer overflow.
7475
6df6ae42 7476 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7477 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7478 (x_send_scroll_bar_event): Likewise. Check that the size does not
7479 exceed limits imposed by XClientMessageEvent, as well as the usual
7480 ptrdiff_t and size_t limits.
7481
b13995db
PE
7482 * keyboard.c: Overflow, signedness and related fixes.
7483 (make_lispy_movement): Use same integer type in forward decl
7484 that is used in the definition.
7485 (read_key_sequence, keyremap_step):
7486 Change bufsize argument back to int, undoing my 2011-03-30 change.
7487 We prefer signed types, and int is wide enough here.
7488 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7489 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7490 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7491 length, not size_t. Use ptrdiff_t for index, not int.
7492 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7493 possibility of integer overflow.
7494
13464394
PE
7495 Overflow, signedness and related fixes for images.
7496
7497 * dispextern.h (struct it.stack[0].u.image.image_id)
7498 (struct_it.image_id, struct image.id, struct image_cache.size)
7499 (struct image_cache.used, struct image_cache.ref_count):
7500 * gtkutil.c (update_frame_tool_bar):
7501 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7502 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7503 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7504 * nsmenu.m (update_frame_tool_bar):
7505 * xdisp.c (calc_pixel_width_or_height):
7506 * xfns.c (image_cache_refcount):
7507 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7508 on typical 64-bit hosts.
7509
7510 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7511 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7512 Omit unnecessary casts to int.
7513 (parse_image_spec): Check that integers fall into 'int' range
7514 when the callers expect that.
7515 (image_ascent): Redo ascent calculation to avoid int overflow.
7516 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7517 (lookup_image): Remove unnecessary tests.
7518 (xbm_image_p): Locals are now of int, not EMACS_INT,
7519 since parse_image_check makes sure they fit into int.
7520 (png_load, gif_load, svg_load_image):
7521 Prefer int to unsigned where either will do.
7522 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7523 old tiff_error_handler and tiff_warning_handler.
7524 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7525 stack buffer overflows. It uses only the features of vsnprintf
7526 that are common to both POSIX and native Microsoft.
7527 (tiff_error_handler, tiff_warning_handler): Use it.
7528 (tiff_load, gif_load, imagemagick_load_image):
7529 Don't assume :index value fits in 'int'.
7530 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7531 (imagemagick_load_image): Check that crop parameters fit into
7532 the integer types that MagickCropImage accepts. Don't assume
7533 Vimagemagick_render_type has a nonnegative value. Don't assume
7534 size_t fits in 'long'.
7535 (gs_load): Use printmax_t to print the widest integers possible.
7536 Check for integer overflow when computing image height and width.
7537
c11821d4
EZ
75382011-08-26 Eli Zaretskii <eliz@gnu.org>
7539
7540 * xdisp.c (redisplay_window): Don't force window start if point
7541 will be invisible in the resulting window. (Bug#9324)
7542
0c95fcf7
EZ
75432011-08-25 Eli Zaretskii <eliz@gnu.org>
7544
7545 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7546 the display spec is of the form `(space ...)'.
7547 (handle_display_spec): Return the value returned by
7548 handle_single_display_spec, not just 1 or zero.
7549 (handle_single_display_spec): If the display spec is of the form
7550 `(space ...)', and specifies display in the text area, return 2
7551 rather than 1.
fee65a97 7552 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7553 accurately, and prefer exact match for point under bidi.
7554 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7555
7556 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7557 into disp_prop; all users changed.
7558
7559 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7560 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7561 for the text covered by the display property.
7562
e4ed06f1
CY
75632011-08-25 Chong Yidong <cyd@stupidchicken.com>
7564
7565 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7566 Change return value to nil.
7567 (Frecord_buffer): Delete unused function.
7568
f67cdd7f
EZ
75692011-08-24 Eli Zaretskii <eliz@gnu.org>
7570
5980d4c6
EZ
7571 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7572 buffers, return left-to-right.
8610fe8b
EZ
7573 (set_cursor_from_row): Consider candidate row a win if its glyph
7574 represents a newline and point is on that newline. Fixes cursor
7575 positioning on the newline at EOL of R2L text within L2R
7576 paragraph, and vice versa.
7577 (try_cursor_movement): Check continued rows, in addition to
7578 continuation rows. Fixes unwarranted scroll when point enters a
7579 continued line of R2L text within an L2R paragraph, or vice versa.
7580 (cursor_row_p): Consider the case of point being equal to
7581 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7582 from the end of a short line to the beginning of a continued line
7583 of R2L text within L2R paragraph.
7584 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7585 composed characters.
5980d4c6 7586
f67cdd7f
EZ
7587 * bidi.c (bidi_check_type): Use xassert.
7588 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7589 members.
7590
bca633fb
EZ
75912011-08-23 Eli Zaretskii <eliz@gnu.org>
7592
7593 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7594 a character.
7595
4a5885a7
CY
75962011-08-23 Chong Yidong <cyd@stupidchicken.com>
7597
7598 * nsfont.m (ns_otf_to_script): Fix typo.
7599
0902a04e
KH
76002011-08-22 Kenichi Handa <handa@m17n.org>
7601
7602 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7603 extra slot even if the purpose is char-code-property-table.
7604
1a2e6670
EZ
76052011-08-23 Eli Zaretskii <eliz@gnu.org>
7606
8ddde651
EZ
7607 * xdisp.c (redisplay_window): When computing centering_position,
7608 account for the height of the header line. (Bug#8874)
7609
425cc014
EZ
7610 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7611 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7612 candidate is selected by the mouse, and that candidate has a
7613 composed character under the mouse.
7614
1a2e6670
EZ
7615 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7616 coordinates reported by pos-visible-in-window-p for a composed
7617 character in column zero.
7618
8b76d6f8
SM
76192011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7620
7621 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7622
dac347dd
EZ
76232011-08-22 Eli Zaretskii <eliz@gnu.org>
7624
7625 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7626 consider it a hit if to_charpos is anywhere in the range of the
7627 composed buffer positions.
7628
e013fb34
CY
76292011-08-22 Chong Yidong <cyd@stupidchicken.com>
7630
7631 * image.c (gif_load): Don't assume that each subimage has the same
7632 dimensions as the base image. Handle disposal method that is
7633 "undefined" by the gif spec (Bug#9335).
7634
bd1ba3e8
CY
76352011-08-20 Chong Yidong <cyd@stupidchicken.com>
7636
7637 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7638 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7639
54a1215b
EZ
76402011-08-19 Eli Zaretskii <eliz@gnu.org>
7641
823564e5
EZ
7642 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7643 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7644 from an Org mode buffer to a Speedbar frame.
7645
54a1215b
EZ
7646 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7647 a composition, take its buffer position from IT->cmp_it.charpos.
7648 Fixes cursor positioning at the beginning of a line that begins
7649 with a composed character.
7650
9778ebcc
EZ
76512011-08-18 Eli Zaretskii <eliz@gnu.org>
7652
0be6ee06
EZ
7653 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7654 character bidirectional type, use STRONG_L instead. Fixes crashes
7655 in a buffer produced by `describe-categories'.
7656
9778ebcc
EZ
7657 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7658 members before the level stack, so they would be saved and
7659 restored when copying iterator state. Fixes incorrect reordering
7660 around TABs covered by display properties.
7661
156bffbe
AS
76622011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7663
6b02f655 7664 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7665
72ad093b
CY
76662011-08-17 Chong Yidong <cyd@stupidchicken.com>
7667
7668 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7669 (internal_condition_case_2, internal_condition_case_n):
7670 Remove unnecessary aborts (Bug#9081).
72ad093b 7671
35774242
EZ
76722011-08-17 Eli Zaretskii <eliz@gnu.org>
7673
7674 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7675 has no `load' handler, try opening the file locally. (Bug#9311)
7676
db76dd85
KB
76772011-08-16 Ken Brown <kbrown@cornell.edu>
7678
7679 * gmalloc.c: Expand comment.
7680
b215eee5
EZ
76812011-08-16 Eli Zaretskii <eliz@gnu.org>
7682
7683 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7684 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7685
a4579d33
KB
76862011-08-16 Ken Brown <kbrown@cornell.edu>
7687
7688 Fix memory allocation problems in Cygwin build (Bug#9273).
7689
7690 * unexcw.c ( __malloc_initialized): Declare external variable.
7691 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7692
8b76d6f8
SM
7693 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7694 New variables.
a4579d33
KB
7695 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7696 dumped emacs.
7697 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7698 in the static heap.
7699 [CYGWIN] (special_realloc): New function.
7700 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7701 requests to realloc storage in the static heap.
7702
3ebec551
PE
77032011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7704
7705 * bidi.c (bidi_initialize): Remove unused local.
7706
9fd8be00
EZ
77072011-08-15 Eli Zaretskii <eliz@gnu.org>
7708
6b02f655
SM
7709 * bidimirror.h:
7710 * biditype.h: Remove file.
7711 * makefile.w32-in ($(BLD)/bidi.$(O)):
7712 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7713
7714 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7715
7716 * chartab.c: Improve commentary for the uniprop_table API.
7717
32413314
EZ
7718 * bidi.c (bidi_paragraph_init): Support zero value of
7719 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7720 (bidi_initialize): Use uniprop_table instead of including
7721 biditype.h and bidimirror.h.
32413314 7722
9fd8be00
EZ
7723 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7724 coordinates of the iterator when restoring from ppos_it.
7725 (Bug#9296)
7726
5cf2b69b
KH
77272011-08-14 Kenichi Handa <handa@m17n.org>
7728
7729 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7730 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7731
daf17d00
EZ
77322011-08-14 Eli Zaretskii <eliz@gnu.org>
7733
7734 * xdisp.c (move_it_in_display_line_to): Don't invoke
7735 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7736 ppos_it. Fixes vertical cursor motion when line beginning is
7737 covered by an image. (Bug#9296)
7738
08e3161a
JD
77392011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7740
7741 * nsterm.h (ns_run_ascript): Declare.
7742 (NSAPP_DATA2_RUNASSCRIPT): Define.
7743
7744 * nsfns.m (as_script, as_result, as_status): New static variables.
7745 (ns_run_ascript): New function.
5e617bc2 7746 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7747 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7748 the event loop. Get status from as_status (Bug#7276).
7749
7750 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7751 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7752 the event loop (Bug#7276).
7753
a3720aa2
AS
77542011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7755
7756 * gnutls.c (QCgnutls_bootprop_priority)
7757 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7758 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7759 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7760 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7761 (QCgnutls_bootprop_verify_hostname_error)
7762 (QCgnutls_bootprop_callbacks_verify): Rename from
7763 Qgnutls_bootprop_..., all uses changed.
7764
7765 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7766 uses changed.
7767
0a0d27fb
PE
77682011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7769
19d5c50c
PE
7770 * xfaces.c (Qframe_set_background_mode): Now static.
7771 * dispextern.h (Qframe_set_background_mode): Remove decl.
7772
0a0d27fb
PE
7773 * process.c (Fnetwork_interface_info): Declare local only if needed.
7774
377538cb
JD
77752011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7776
7777 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7778 (Fnetwork_interface_list): Allocate in increments of bytes instead
7779 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7780 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7781 sockaddr.
7782 (struct ifflag_def): notrailers is smart on OSX.
7783 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7784 Get hardware address with getifaddrs if available.
7785
08fff70c
EZ
77862011-08-12 Eli Zaretskii <eliz@gnu.org>
7787
7788 * xdisp.c (iterate_out_of_display_property): xassert that
7789 IT->position is set to within IT->object's boundaries. Break from
7790 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7791 when IT->position is set up wrongly due to some bug.
7792 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7793 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7794 entry. Force push_it to save on the stack the current
7795 buffer/string position, to be restored by pop_it. Fix flags in
7796 the iterator structure wrt the object coming from a display
7797 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7798 properties. (Bug#9284)
7799
7be1c708 78002011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7801
7be1c708
CY
7802 * fontset.c (fontset_get_font_group): Add proper type checks.
7803 (Bug#9172)
aac0c6e3 7804
7be1c708 78052011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7806
7be1c708
CY
7807 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7808 and LC_VERSION_MIN_MACOSX.
7809 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7810 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7811
97bb72a6
EZ
78122011-08-08 Eli Zaretskii <eliz@gnu.org>
7813
7814 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7815 no-display-properties-and-no-overlays under bidi display.
7816 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7817 properties and overlays.
97bb72a6 7818
d5617611
CY
78192011-08-08 Chong Yidong <cyd@stupidchicken.com>
7820
37e11a63
CY
7821 * editfns.c (Fset_time_zone_rule): Document relationship with the
7822 setenv function.
7823
d5617611
CY
7824 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7825 the font entity extracted from the cache (Bug#8109).
7826
58872834
CY
78272011-08-07 Chong Yidong <cyd@stupidchicken.com>
7828
7829 * composite.c (autocmp_chars): Don't reset point. That is done by
7830 restore_point_unwind (Bug#5984).
7831
75bfc667
JL
78322011-08-07 Juri Linkov <juri@jurta.org>
7833
7834 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7835 to show the arg `TIME' instead of `TIMEVAL'.
7836
d1410150
EZ
78372011-08-06 Eli Zaretskii <eliz@gnu.org>
7838
7839 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7840 display property strides EOL and includes a newline, as in
7841 longlines-mode. (Bug#9254)
75b771e4
EZ
7842 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7843 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7844
7845 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7846 is non-zero, even if the data buffer is NULL. Fixes a crash in
7847 vertical-motion with longlines-mode. (Bug#9254)
7848
35928349
EZ
78492011-08-05 Eli Zaretskii <eliz@gnu.org>
7850
ec7cc85b
EZ
7851 * bidi.c <bidi_cache_total_alloc>: Now static.
7852 (bidi_initialize): Initialize bidi_cache_total_alloc.
7853
8b76d6f8 7854 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7855 cache. (Bug#9221)
7856
7857 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7858 amount allocated this far in `bidi_cache_total_alloc'.
7859 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7860 non-zero, only free the data buffer without restoring the cache
7861 contents. All callers changed.
7862
7863 * dispextern.h (bidi_unshelve_cache): Update prototype.
7864
7865 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7866 (move_it_in_display_line, move_it_to)
7867 (move_it_vertically_backward, move_it_by_lines): Replace the call
7868 to xfree to an equivalent call to bidi_unshelve_cache.
7869 (move_it_in_display_line_to): Fix logic of returning
412b6358 7870 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7871
e2e2423b
EZ
78722011-08-05 Eli Zaretskii <eliz@gnu.org>
7873
7874 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7875 came from a string character with a `cursor' property. (Bug#9229)
7876
ae9e757a
JD
78772011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7878
7879 * Makefile.in (LIB_PTHREAD): New variable.
7880 (LIBES): Add LIB_PTHREAD (Bug#9216).
7881
7882 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7883 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7884
213bd7f2
AS
78852011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7886
6b02f655 7887 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7888
99aaf75f
JD
78892011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7890
7891 * xterm.c (x_find_topmost_parent): New function.
7892 (x_set_frame_alpha): Find topmost parent window with
7893 x_find_topmost_parent and set the property there also (bug#9181).
7894 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7895
c74e9d86
PE
78962011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7897
7898 * callproc.c (Fcall_process): Avoid vfork clobbering
7899 the local vars buffer, coding_systems, current_dir.
7900
640c8776
SM
79012011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7902
7903 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7904
f26d0e4c
PE
79052011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7906
8a10d76c
PE
7907 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7908 so that it is not optimized away.
7909
f26d0e4c
PE
7910 * xdisp.c (compute_display_string_pos): Remove unused local.
7911
55439c61
EZ
79122011-08-02 Eli Zaretskii <eliz@gnu.org>
7913
7914 Fix slow cursor motion and scrolling in large buffers with
7915 selective display, like Org Mode buffers. (Bug#9218)
7916
7917 * dispextern.h (struct bidi_it): New member disp_prop_p.
7918
7919 * xdisp.c: Remove one-slot cache of display string positions.
7920 (compute_display_string_pos): Accept an additional argument
5e617bc2 7921 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7922 for a display string or property. If found, set DISP_PROP_P
7923 non-zero.
7924
7925 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7926 DISP_PROP_P, and pass it to compute_display_string_pos.
7927 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7928 non-zero. All callers of bidi_fetch_char changed.
7929
fb33fa43
SM
79302011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7931
7932 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7933
b099e063
DM
79342010-12-03 Don March <don@ohspite.net>
7935
7936 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7937 last character M-[char] is translated to ESC [char] (bug#7541).
7938
5cc7f7af
KH
79392011-08-02 Kenichi Handa <handa@m17n.org>
7940
d0fffa3f 7941 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7942
7943 * chartab.c (uniprop_table): Make it non-static.
7944
525d5e6e
EZ
79452011-08-01 Eli Zaretskii <eliz@gnu.org>
7946
7947 * xdisp.c (forward_to_next_line_start): Accept additional argument
7948 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7949 on the newline.
7950 (reseat_at_next_visible_line_start): Use the bidi iterator state
7951 returned by forward_to_next_line_start to restore the state of
7952 it->bidi_it after backing up to previous newline. (Bug#9212)
7953
31011111
AS
79542011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7955
7956 * regex.c (re_comp): Protoize.
7957 (re_exec): Fix return type.
7958 (regexec): Fix type of `ret'. (Bug#9203)
7959
476371c4
PE
79602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7961
e5d76069
PE
7962 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7963 This is needed if max-image-size is a floating-point number.
7964
9a79b20c
AS
79652011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7966
7967 * print.c (print_object): Print empty symbol as ##.
7968
7969 * lread.c (read1): Read ## as empty symbol.
7970
d8c2fa78
AA
79712011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7972
7973 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7974 setting frame foreground color (Bug#9175).
7975 (x_set_background_color): Likewise.
7976
ffe57a7a
AA
7977 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7978 contents (Bug#9176).
7979 (EmacsTooltip -init): Remove bezels and add shadows to
7980 tooltip windows.
7981
bf3492a5
AA
7982 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7983 or scroll bar (Bug#8470).
7984
d55e9c53
AA
7985 * nsfont.m (nsfont_open): Remove assignment to voffset and
7986 unnecessary vars hshink, expand, hd, full_height, min_height.
7987 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7988
7989 * nsterm.h (nsfont_info): Remove voffset field.
7990
d8c2fa78 79912011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7992
7993 Implement strike-through and overline on NextStep (Bug#8863).
7994
7995 * nsfont.m (nsfont_open): Use underline position provided by font,
7996 instead of hard-coded value of 2.
7997 (nsfont_draw): Call ns_draw_text_decoration instead.
7998
7999 * nsterm.h: Add declaration for ns_draw_text_decoration.
8000
8001 * nsterm.m (ns_draw_text_decoration): New function for drawing
8002 underline, overline, and strike-through.
8003 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8004 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8005 accommodate underlining, etc.
4843aac3 8006
4cc60b9b
EZ
80072011-07-28 Eli Zaretskii <eliz@gnu.org>
8008
bc7ece87
EZ
8009 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8010 default.
4cc60b9b 8011
476371c4
PE
80122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8013
66606eea
PE
8014 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8015 Without this fix, if a signal arrives just after memory fills up,
8016 'malloc' might be invoked reentrantly.
8017
476371c4
PE
8018 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8019 In other words, assume that every image size is allowed, on non-X
8020 hosts. This assumption is probably wrong, but it lets Emacs compile.
8021
f3fcc40d
AS
80222011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8023
8024 * regex.c (re_iswctype): Convert return values to boolean.
8025
350c992f
EZ
80262011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8027
8028 * xdisp.c (compute_display_string_pos): Don't use cached display
8029 string position if the buffer had its restriction changed.
8030 (Bug#9184)
8031
5266b4bb
PE
80322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8033
8034 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8035
2573a837 80362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8037
41f55ccd 8038 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8039
39e378da
PE
8040 * bidi.c: Integer size and overflow fixes.
8041 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8042 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8043 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8044 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8045 (bidi_find_other_level_edge):
8046 Use ptrdiff_t instead of EMACS_INT where either will do.
8047 This works better on 32-bit hosts configured --with-wide-int.
8048 (bidi_cache_ensure_space): Check for size-calculation overflow.
8049 Use % rather than repeated addition, for better worst-case speed.
8050 Don't set bidi_cache_size until after xrealloc returns, because it
8051 might not return.
8052 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8053 (bidi_cache_ensure_space): Also check that the bidi cache size
8054 does not exceed that of the largest Lisp string or buffer. See Eli
8055 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8056
5e927815
PE
8057 * alloc.c (__malloc_size_t): Remove.
8058 All uses replaced by size_t. See Andreas Schwab's note
8059 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8060
ca4aa935
PE
8061 * image.c: Improve checking for integer overflow.
8062 (check_image_size): Assume that f is nonnull, since
8063 it is always nonnull in practice. This is one less thing to
8064 worry about when checking for integer overflow later.
8065 (x_check_image_size): New function, which checks for integer
8066 overflow issues inside X.
8067 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8068 This removes the need for a memory_full check.
8069 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8070 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8071 (xbm_read_bitmap_data): Change locals back to 'int', since
8072 their values must fit in 'int'.
8073 (xpm_load_image, png_load, tiff_load):
8074 Invoke x_create_x_image_and_pixmap earlier,
8075 to avoid much needless work if the image is too large.
8076 (tiff_load): Treat overly large images as if
8077 x_create_x_image_and_pixmap failed, not as malloc failures.
8078 (gs_load): Use x_check_image_size.
8079
5f8f9cc2
PE
8080 * gtkutil.c: Omit integer casts.
8081 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8082 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8083
5adf60bc
PE
8084 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8085
c8907a93
PE
8086 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8087 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8088 would wrongly return t on a 64-bit host.
8089
e3c25c68
PE
8090 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8091 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8092 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8093 and therefore cause GCC to emit a bogus diagnostic in some cases.
8094
3f791afe
PE
8095 * image.c: Integer signedness and overflow and related fixes.
8096 This is not an exhaustive set of fixes, but it's time to
8097 record what I've got.
8098 (lookup_pixel_color, check_image_size): Remove redundant decls.
8099 (check_image_size): Don't assume that arbitrary EMACS_INT values
8100 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8101 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8102 (tiff_load, imagemagick_load_image):
8103 Check for overflow in size calculations.
8104 (x_create_x_image_and_pixmap): Remove unnecessary test for
8105 xmalloc returning NULL; that can't happen.
8106 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8107 (xpm_color_bucket): Use better integer hashing function.
8108 (xpm_cache_color): Don't possibly over-allocate memory.
8109 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8110 (gif_memory_source):
8111 Use ptrdiff_t, not int or size_t, to record sizes.
8112 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8113 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8114 either works, as we prefer signed integers.
8115 (tiff_read_from_memory, tiff_write_from_memory):
8116 Return tsize_t, not size_t, since that's what the TIFF API wants.
8117 (tiff_read_from_memory): Don't fail simply because the read would
8118 go past EOF; instead, return a short read.
8119 (tiff_load): Omit no-longer-needed casts.
8120 (Fimagemagick_types): Don't assume size fits into 'int'.
8121
3cc5a532
PE
8122 Improve hashing quality when configured --with-wide-int.
8123 * fns.c (hash_string): New function, taken from sxhash_string.
8124 Do not discard information about ASCII character case; this
8125 discarding is no longer needed.
8126 (sxhash-string): Use it. Change sig to match it. Caller changed.
8127 * lisp.h: Declare it.
8128 * lread.c (hash_string): Remove, since we now use fns.c's version.
8129 The fns.c version returns a wider integer if --with-wide-int is
8130 specified, so this should help the quality of the hashing a bit.
8131
b312a492
PE
8132 * emacs.c: Integer overflow minor fix.
8133 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8134 Define only if GNU_LINUX.
8135 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8136
dfd153ae
PE
8137 * dispnew.c: Integer signedness and overflow fixes.
8138 Remove unnecessary forward decls, that were a maintenance hassle.
8139 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8140 All uses changed.
8141 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8142 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8143 (prepare_desired_row, line_draw_cost):
8144 Use int, not unsigned, where either works.
8145 (save_current_matrix, restore_current_matrix):
8146 Use ptrdiff_t, not size_t, where either works.
8147 (init_display): Check for overflow more accurately, and without
8148 relying on undefined behavior.
8149
a81d11a3
PE
8150 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8151 Remove, replacing with the new symbols in lisp.h. All uses changed.
8152 * fileio.c (make_temp_name):
8153 * filelock.c (lock_file_1, lock_file):
8154 * xdisp.c (message_dolog):
8155 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8156 Use pMd etc. instead.
8157 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8158 replacing the pWIDE etc. symbols removed from editfns.c.
8159
3300e6fd
PE
8160 * keyboard.h (num_input_events): Now uintmax_t.
8161 This is (very slightly) less likely to mess up due to wraparound.
8162 All uses changed.
8163
fd05c7e9
PE
8164 * buffer.c: Integer signedness fixes.
8165 (alloc_buffer_text, enlarge_buffer_text):
8166 Use ptrdiff_t rather than size_t when either will do, as we prefer
8167 signed integers.
8168
903fe15d
PE
8169 * alloc.c: Integer signedness and overflow fixes.
8170 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8171 (__malloc_size_t): Default to size_t, not to int.
8172 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8173 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8174 Prefer ptrdiff_t to size_t when either would do, as we prefer
8175 signed integers.
8176 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8177 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8178 Now const. Initialize with values that are in range even if char
8179 is signed.
8180 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8181 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8182 These functions do the right thing with sizes > 2**32.
8183 (check_depth): Now ptrdiff_t, not int.
8184 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8185 Adjust to new way of storing sizes. Check for size overflow bugs
8186 in rest of code.
8187 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8188 slightly wrong anyway, as it missed one instance of
8189 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8190 (refill_memory_reserve): Omit needless cast to size_t.
8191 (mark_object_loop_halt): Mark as externally visible.
8192
ac82cc6a
PE
8193 * xselect.c: Integer signedness and overflow fixes.
8194 (Fx_register_dnd_atom, x_handle_dnd_message):
8195 Use ptrdiff_t, not size_t, since we prefer signed.
8196 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8197 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8198 x_dnd_atoms_size and x_dnd_atoms_length.
8199
c2d1e36d
PE
8200 * doprnt.c: Prefer signed to unsigned when either works.
8201 * eval.c (verror):
8202 * doprnt.c (doprnt):
8203 * lisp.h (doprnt):
8204 * xdisp.c (vmessage):
8205 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8206 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8207 prefer signed arithmetic to avoid comparison confusion.
8208 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8209 but is a bit tricky.
8210
0e926e56
PE
8211 Assume freestanding C89 headers, string.h, stdlib.h.
8212 * data.c, doprnt.c, floatfns.c, print.c:
8213 Include float.h unconditionally.
8214 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8215 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8216 * regex.c: Likewise for stddef.h, string.h.
8217 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8218 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8219 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8220 (STDC_HEADERS): Remove obsolete defines.
8221 * sysdep.c: Include limits.h unconditionally.
8222
9cfdb3ec
PE
8223 Assume support for memcmp, memcpy, memmove, memset.
8224 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8225 * regex.c (memcmp, memcpy):
8226 Remove; we assume C89 now.
8227
8228 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8229 (__malloc_safe_bcopy): Remove; no longer needed.
8230
cf950e6b 8231 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8232 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8233 well either way, and we prefer signed to unsigned.
8234
dbf38e02
LMI
82352011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8236
8237 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8238 closes the connection while we're reading (bug#9182).
8239
d6f0886c 82402011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8241
d6f0886c
JD
8242 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8243 are specified (Bug#9168).
24e0f6b1 8244
2eb1f9e6
PE
82452011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8246
8247 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8248 Found by GCC static checking and --with-wide-int on a 32-bit host.
8249
22381272 82502011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8251
8252 * xdisp.c (compute_display_string_pos): Fix logic of caching
8253 previous display string position. Initialize cached_prev_pos to
8254 -1. Fixes slow-down at the beginning of a buffer.
8255
f25e39b4
EZ
82562011-07-24 Eli Zaretskii <eliz@gnu.org>
8257
8258 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8259 for attrs[LFACE_FONTSET_INDEX].
8260
04c4b52e
PE
82612011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8262
8263 * xml.c (parse_region): Remove unused local
8264 that was recently introduced.
8265
c1734fbd
EZ
82662011-07-23 Eli Zaretskii <eliz@gnu.org>
8267
be18c5a5
EZ
8268 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8269 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8270
c1734fbd
EZ
8271 * xdisp.c (move_it_in_display_line_to): Record the best matching
8272 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8273 exit if none of the characters scanned was an exact match.
8274 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8275 when exact match is impossible due to invisible text, and the
8276 lines are truncated.
8277
a258d627
JD
82782011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8279
8280 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8281 for OSX >= 10.7.
8282
b6d5a689
EZ
82832011-07-22 Eli Zaretskii <eliz@gnu.org>
8284
0f74f785
EZ
8285 Fix a significant slow-down of cursor motion with C-n, C-p,
8286 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8287 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8288 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8289 (next_element_from_buffer): Call compute_stop_pos_backwards to
8290 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8291 base_level_stop.
8292 (reseat): Don't look for prev_stop, as that could mean a very long
8293 run.
8294 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8295 <cached_disp_overlay_modiff>: Cache for last found display string
8296 position.
551918c1 8297 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8298 about the same buffer in the same area of character positions, and
8299 the buffer wasn't changed since the time the display string
8300 position was cached.
551918c1 8301
b2d0c91a
EZ
83022011-07-22 Eli Zaretskii <eliz@gnu.org>
8303
8304 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8305 is an integer, which is important for empty lines. (Bug#9149)
8306
043604ee
CY
83072011-07-22 Chong Yidong <cyd@stupidchicken.com>
8308
8309 * frame.c (Fmodify_frame_parameters): In tty case, update the
8310 default face if necessary (Bug#4238).
8311
da4adb04
CY
83122011-07-21 Chong Yidong <cyd@stupidchicken.com>
8313
8314 * editfns.c (Fstring_to_char): No need to explain what a character
8315 is in the docstring (Bug#6576).
8316
9abd0532
LMI
83172011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8318
8319 * xml.c (parse_region): Make sure we always return a tree.
8320
36881d16
HK
83212011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8322
8323 * xml.c (parse_region): If a document contains only comments,
8324 return that, too.
8325
1e98674d
LMI
83262011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8327
8328 * xml.c (make_dom): Return comments, too.
8329
590bd467
PE
83302011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8331
8332 Port to OpenBSD.
8333 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8334 and the surrounding thread.
8335 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8336 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8337 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8338 timer goes off.
8339 * s/openbsd.h (BROKEN_SIGIO): Define.
8340 * unexelf.c (unexec) [__OpenBSD__]:
8341 Don't update the .mdebug section of the Alpha COFF symbol table.
8342
f41628b2
LMI
83432011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8344
8345 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8346 (bug#8460).
8347
b59b67c5
PE
83482011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8349
15e3a074
PE
8350 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8351 This fixes some race conditions on the permissions of any newly
8352 created file.
8353
41bed37d
PE
8354 * alloc.c (valid_pointer_p): Use pipe, not open.
8355 This fixes some permissions issues when debugging.
8356
b59b67c5
PE
8357 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8358 If fchown fails to set both uid and gid, try to set just gid,
8359 as that is sometimes allowed. Adjust the file's mode to eliminate
8360 setuid or setgid bits that are inappropriate if fchown fails.
8361
925a6be7
SM
83622011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8363
8364 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8365 to compare Lisp_Objects.
8366 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8367 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8368 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8369
52968808
AS
83702011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8371
0a6a104b
AS
8372 * lread.c (read_integer): Unread even EOF character.
8373 (read1): Likewise. Properly record start position of symbol.
8374
52968808
AS
8375 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8376 symbol character follows.
8377
9e381cdd
PE
83782011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8379
8380 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8381 This works around a problem with the previous change to Fcopy_file.
8382 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8383 and without this change, GCC might complain about discarding
8384 fchown's return value.
8385
b5641435
JB
83862011-07-16 Juanma Barranquero <lekktu@gmail.com>
8387
8388 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8389
a8031457
PE
83902011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8391
8392 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8393
dd889327
LMI
83942011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8395
750c33f7
LMI
8396 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8397 it's used from the C level.
8398
dd889327
LMI
8399 * process.c: Use the same condition for POLL_FOR_INPUT in both
8400 keyboard.c and process.c (bug#1858).
8401
87e86684
LM
84022011-07-09 Lawrence Mitchell <wence@gmx.li>
8403
8404 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8405 (Fgnutls_boot): Use it.
8406
64348f40
AS
84072011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8408
8409 * doc.c (Fsubstitute_command_keys): Revert last change.
8410
1d698799
LMI
84112011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8412
f863868c
LMI
8413 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8414 quotes the next character, and doesn't affect other longer
8415 sequences (bug#8935).
8416
1d698799
LMI
8417 * lread.c (syms_of_lread): Clarify that is isn't only
8418 `eval-buffer' and `eval-defun' that's affected by
8419 `lexical-binding' (bug#8460).
8420
aa4b6df6
EZ
84212011-07-15 Eli Zaretskii <eliz@gnu.org>
8422
8423 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8424 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8425
5d856da6
PE
84262011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8427
ad6042bb
PE
8428 Fix minor problems found by static checking.
8429 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8430 (elsz): Now a signed constant, not a size_t var. We prefer signed
8431 types to unsigned, to avoid integer comparison confusion. Without
8432 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8433 "cannot optimize loop, the loop counter may overflow", a symptom
8434 of the confusion.
f00bbb22 8435 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8436 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8437
6468f31c
LMI
84382011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8439
49080b10
LMI
8440 * search.c (Fre_search_backward): Mention `case-fold-search' in
8441 all the re_search_* functions (bug#8138).
8442
6468f31c
LMI
8443 * keyboard.c (Fopen_dribble_file): Document when the file is
8444 closed (bug#8056).
8445
c965adc5
EZ
84462011-07-14 Eli Zaretskii <eliz@gnu.org>
8447
df9733bf
EZ
8448 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8449 bidi_cache_idx.
8450
0bb23927
EZ
8451 Support bidi reordering of display and overlay strings.
8452 * xdisp.c (compute_display_string_pos)
8453 (compute_display_string_end): Accept additional argument STRING.
8454 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8455 (reseat_to_string): Initialize bidi_it->string.s and
8456 bidi_it->string.schars.
8457 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8458 NULL (avoids a crash in bidi_paragraph_init).
8459 Initialize itb.string.lstring.
0bb23927
EZ
8460 (init_iterator): Call bidi_init_it only of a valid
8461 buffer position was specified. Initialize paragraph_embedding to
8462 L2R.
8463 (reseat_to_string): Initialize the bidi iterator.
8464 (display_string): If we need to ignore text properties of
8465 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8466 original value of -1 will not work with bidi.)
8467 (compute_display_string_pos): First arg is now struct
8468 `text_pos *'; all callers changed. Support display properties on
8469 Lisp strings.
8470 (compute_display_string_end): Support display properties on Lisp
8471 strings.
8472 (init_iterator, reseat_1, reseat_to_string): Initialize the
8473 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8474 when iterating on a string not from display properties).
640c8776
SM
8475 (compute_display_string_pos, compute_display_string_end):
8476 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8477 arrow keys.
8478 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8479 base_level_stop; instead, set base_level_stop to BEGV.
8480 Fixes crashes in vertical-motion.
0bb23927
EZ
8481 (next_element_from_buffer): Improve commentary for when
8482 the iterator is before prev_stop.
8483 (init_iterator): Initialize bidi_p from the default value of
8484 bidi-display-reordering, not from buffer-local value. Use the
8485 buffer-local value only if initializing for buffer iteration.
8486 (handle_invisible_prop): Support invisible properties on strings
8487 that are being bidi-reordered.
8488 (set_iterator_to_next): Support bidi reordering of C strings and
8489 Lisp strings.
8490 (next_element_from_string): Support bidi reordering of Lisp
8491 strings.
8492 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8493 (display_string): Support display of R2L glyph rows.
8494 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8495 (init_iterator): Don't initialize it->bidi_p for strings
8496 here.
8497 (reseat_to_string): Initialize it->bidi_p for strings here.
8498 (next_element_from_string, next_element_from_c_string)
8499 (next_element_from_buffer): Add xassert's for correspondence
8500 between IT's object being iterated and it->bidi_it.string
8501 structure.
8502 (face_before_or_after_it_pos): Support bidi iteration.
8503 (next_element_from_c_string): Handle the case of the first string
8504 character that is not the first one in the visual order.
8505 (get_visually_first_element): New function, refactored from common
8506 parts of next_element_from_buffer, next_element_from_string, and
8507 next_element_from_c_string.
8508 (tool_bar_lines_needed, redisplay_tool_bar)
8509 (display_menu_bar): Force left-to-right direction. Add a FIXME
8510 comment for making that be controlled by a user option.
8511 (push_it, pop_it): Save and restore the state of the
8512 bidi iterator. Save and restore the bidi_p flag.
8513 (pop_it): Iterate out of display property for string iteration as
8514 well.
8515 (iterate_out_of_display_property): Support iteration over strings.
8516 (handle_single_display_spec): Set up it->bidi_it for iteration
8517 over a display string, and call bidi_init_it.
8518 (handle_single_display_spec, next_overlay_string)
8519 (get_overlay_strings_1, push_display_prop): Set up the bidi
8520 iterator for displaying display or overlay strings.
8521 (forward_to_next_line_start): Don't use the shortcut if
8522 bidi-iterating.
8523 (back_to_previous_visible_line_start): If handle_display_prop
8524 pushed the iterator stack, restore the internal state of the bidi
8525 iterator by calling bidi_pop_it same number of times.
8526 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8527 and we are bidi-iterating, don't decrement the iterator position;
8528 instead, set the first_elt flag in the bidi iterator, to produce
8529 the same effect.
8530 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8531 (push_display_prop): xassert that we are iterating a buffer.
8532 (push_it, pop_it): Save and restore paragraph_embedding member.
8533 (handle_single_display_spec, next_overlay_string)
8534 (get_overlay_strings_1, reseat_1, reseat_to_string)
8535 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8536 correctly. Don't assume unibyte strings are not bidi-reordered.
8537 (compute_display_string_pos)
8538 (compute_display_string_end): Fix handling the case of C string.
8539 (push_it, pop_it): Save and restore from_disp_prop_p.
8540 (handle_single_display_spec, push_display_prop): Set the
8541 from_disp_prop_p flag.
8542 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8543 (pop_it): Call iterate_out_of_display_property only if we are
8544 popping after iteration over a string that came from a display
8545 property. Fix a typo in popping stretch info. Add an assertion
8546 for verifying that the iterator position is in sync with the bidi
8547 iterator.
8548 (handle_single_display_spec, get_overlay_strings_1)
8549 (push_display_prop): Fix initialization of paragraph direction for
8550 string when that of the parent object is not yet determined.
8551 (reseat_1): Call bidi_init_it to resync the bidi
8552 iterator with IT's position. (Bug#7616)
8553 (find_row_edges): If ROW->start.pos gives position
8554 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8555 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8556 Reset the from_disp_prop_p flag.
8557 (SAVE_IT, RESTORE_IT): New macros.
8558 (pos_visible_p, face_before_or_after_it_pos)
8559 (back_to_previous_visible_line_start)
8560 (move_it_in_display_line_to, move_it_in_display_line)
8561 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8562 (try_scrolling, redisplay_window, display_line): Use them when
8563 saving a temporary copy of the iterator and restoring it back.
8564 (back_to_previous_visible_line_start, reseat_1)
8565 (init_iterator): Empty the bidi cache "stack".
8566 (move_it_in_display_line_to): If iterator ended up at
8567 EOL, but we never saw any buffer positions smaller than
8568 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8569 motion in bidi-reordered lines.
8570 (move_it_in_display_line_to): Record prev_method and prev_pos
8571 immediately before the call to set_iterator_to_next. Fixes cursor
8572 motion in bidi-reordered lines with stretch glyphs and strings
8573 displayed in margins. (Bug#8133) (Bug#8867)
8574 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8575 TO_CHARPOS.
640c8776
SM
8576 (pos_visible_p): Support positions in bidi-reordered lines.
8577 Save and restore bidi cache.
0bb23927
EZ
8578
8579 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8580 (bidi_paragraph_info): Delete unused struct.
8581 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8582 (bidi_cache_start): New variable.
8583 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8584 to zero.
8585 (bidi_cache_fetch_state, bidi_cache_search)
8586 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8587 (bidi_cache_find, bidi_peek_at_next_level)
8588 (bidi_level_of_next_char, bidi_find_other_level_edge)
8589 (bidi_move_to_visually_next): Compare cache index with
8590 bidi_cache_start rather than with zero.
8591 (bidi_fetch_char): Accept new argument STRING; all callers
8592 changed. Support iteration over a string. Support strings with
8593 display properties. Support unibyte strings. Fix the type of
8594 `len' according to what STRING_CHAR_AND_LENGTH expects.
8595 (bidi_paragraph_init, bidi_resolve_explicit_1)
8596 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8597 (bidi_level_of_next_char, bidi_move_to_visually_next):
8598 Support iteration over a string.
0bb23927
EZ
8599 (bidi_set_sor_type, bidi_resolve_explicit_1)
8600 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8601 can now be zero (for strings); special values 0 and -1 were
8602 changed to -1 and -2, respectively.
8603 (bidi_char_at_pos): New function.
8604 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8605 Call it instead of FETCH_MULTIBYTE_CHAR.
8606 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8607 initialized to valid values.
8608 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8609 values.
8610 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8611 the test for valid cached positions. Fix the logic for looking up
8612 the sentinel state in the cache. GCPRO the Lisp string we are
8613 iterating.
8614 (bidi_push_it, bidi_pop_it): New functions.
8615 (bidi_initialize): Initialize the bidi cache start stack pointer.
8616 (bidi_cache_ensure_space): New function, refactored from part of
8617 bidi_cache_iterator_state. Don't assume the required size is just
8618 one BIDI_CACHE_CHUNK away.
8619 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8620 (bidi_count_bytes, bidi_char_at_pos): New functions.
8621 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8622 always valid if bidi_cache_idx is valid.
8623 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8624 is valid if it's going to be used.
8625 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8626 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8627 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8628 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8629 (bidi_find_other_level_edge, bidi_cache_start_stack):
8630 All variables related to cache indices are now EMACS_INT.
c965adc5 8631
0bb23927
EZ
8632 * dispextern.h (struct bidi_string_data): New structure.
8633 (struct bidi_it): New member `string'. Make flag members be 1-bit
8634 fields, and put them last in the struct.
640c8776
SM
8635 (compute_display_string_pos, compute_display_string_end):
8636 Update prototypes.
0bb23927
EZ
8637 (bidi_push_it, bidi_pop_it): Add prototypes.
8638 (struct iterator_stack_entry): New members bidi_p,
8639 paragraph_embedding, and from_disp_prop_p.
8640 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8641 (bidi_shelve_cache, bidi_unshelve_cache):
8642 Declare prototypes.
0bb23927
EZ
8643
8644 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8645 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8646 and vector-like objects.
8647
8648 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8649 cache around display iteration.
8650
8651 * window.c (Fwindow_end, window_scroll_pixel_based)
8652 (displayed_window_lines, Frecenter): Save and restore the bidi
8653 cache around display iteration.
8654
3bbd2265
LMI
86552011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8656
8657 * editfns.c (Fdelete_region): Clarify the use of the named
8658 parameters (bug#6788).
8659
adc47434
MR
86602011-07-14 Martin Rudalics <rudalics@gmx.at>
8661
8662 * indent.c (Fvertical_motion): Set and restore w->pointm when
8663 saving and restoring the window's buffer (Bug#9006).
8664
837c31f8
LMI
86652011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8666
8667 * editfns.c (Fstring_to_char): Clarify just what is returned
8668 (bug#6576). Text by Eli Zaretskii.
8669
ac389d0c
JB
86702011-07-13 Juanma Barranquero <lekktu@gmail.com>
8671
8672 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8673
0be0ce47
EZ
86742011-07-13 Eli Zaretskii <eliz@gnu.org>
8675
8676 * buffer.c (mmap_find): Fix a typo.
8677
cd18e7e3
JB
86782011-07-13 Johan Bockgård <bojohan@gnu.org>
8679
8680 Fix execution of x selection hooks.
8681 * xselect.c (Qx_lost_selection_functions)
8682 (Qx_sent_selection_functions): New vars.
8683 (syms_of_xselect): DEFSYM them.
8684 (x_handle_selection_request): Pass Qx_sent_selection_functions
8685 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8686 (x_handle_selection_clear,x_clear_frame_selections):
8687 Pass Qx_lost_selection_functions rather than
8688 Vx_lost_selection_functions to Frun_hook_with_args.
8689
47ea7f44
PE
86902011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8691
ac389d0c 8692 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8693 The old code sometimes used this field without initializing it.
8694
47ea7f44
PE
8695 * alloc.c (gc_sweep): Don't read past end of array.
8696 In theory, the old code could also have corrupted Emacs internals,
8697 though it'd be very unlikely.
8698
bc985c87
AS
86992011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8700
8701 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8702 argument. (Bug#4026)
bc985c87 8703
0cf34688
LMI
87042011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8705
b3dadd76
LMI
8706 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8707 key" (bug#4257).
8708
0cf34688
LMI
8709 * window.c (Fset_window_start): Doc fix (bug#4199).
8710 (Fset_window_hscroll): Ditto.
8711
270768cd
PE
87122011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8713
077e3dda 8714 Fix minor new problems caught by GCC 4.6.1.
270768cd 8715 * term.c (init_tty): Remove unused local.
490011a6 8716 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8717 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8718 not used otherwise.
270768cd 8719
b1f58454
CY
87202011-07-12 Chong Yidong <cyd@stupidchicken.com>
8721
8722 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8723
22b9578d
LMI
87242011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8725
6e70ab07
LMI
8726 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8727 are the mini-buffer and the echo area (bug#3320).
8728
22b9578d
LMI
8729 * term.c (init_tty): Remove support for supdup, c10 and perq
8730 terminals, which are no longer supported (bug#1482).
8731
8974cc9f
JB
87322011-07-10 Johan Bockgård <bojohan@gnu.org>
8733
8734 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8735
a560d974
JD
87362011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8737
8738 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8739 for non-popups (Bug#3642).
8740
1dae0f0a
AS
87412011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8742
268c2c36 8743 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8744 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8745 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8746 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8747 * data.c (fmod): Likewise.
8748 * dispnew.c (swap_glyphs_in_rows): Likewise.
8749 * emacs.c (memory_warning_signal): Likewise.
8750 * floatfns.c (float_error): Likewise.
8751 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8752 (otf_open, font_otf_capability, generate_otf_features)
8753 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8754 Likewise.
8755 * image.c (pbm_read_file): Likewise.
8756 * indent.c (string_display_width): Likewise.
8757 * intervals.c (check_for_interval, search_for_interval)
8758 (inc_interval_count, count_intervals, root_interval)
8759 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8760 * lread.c (defalias): Likewise.
268c2c36 8761 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8762 * regex.c (set_image_of_range_1, set_image_of_range)
8763 (regex_grow_registers): Likewise.
8764 * sysdep.c (strerror): Likewise.
8765 * termcap.c (valid_filename_p, tprint, main): Likewise.
8766 * tparam.c (main): Likewise.
8767 * unexhp9k800.c (run_time_remap, save_data_space)
8768 (update_file_ptrs, read_header, write_header, calculate_checksum)
8769 (copy_file, copy_rest, display_header): Likewise.
8770 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8771 Likewise.
8772 * xdisp.c (check_it): Likewise.
8773 * xfaces.c (register_color, unregister_color, unregister_colors):
8774 Likewise.
8775 * xfns.c (print_fontset_result): Likewise.
8776 * xrdb.c (member, fatal, main): Likewise.
8777
99033785
PE
87782011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8779
8780 Fix minor problems found by static checking (Bug#9031).
8781 * chartab.c (char_table_set_range, map_sub_char_table):
8782 Remove unused locals.
8783 (uniprop_table): Now static.
8784 * composite.c (_work_char): Remove unused static var.
8785
9cb2ac56
JB
87862011-07-09 Juanma Barranquero <lekktu@gmail.com>
8787
8788 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8789
f25661f0
JD
87902011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8791
8792 * gtkutil.c (qttip_cb): Remove code without function.
8793
8278c4fe
EZ
87942011-07-09 Eli Zaretskii <eliz@gnu.org>
8795
8796 * w32.c (pthread_sigmask): New stub.
8797
1692ae2d 87982011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8799
8a6ebd58 8800 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8801 sigprocmask is portable only for single-threaded applications, and
8802 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8803 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8804 (LIBES): Use it.
8805 * callproc.c (Fcall_process):
8806 * process.c (create_process):
8807 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8808 Use pthread_sigmask, not sigprocmask.
123403e4 8809
1b854618
JD
88102011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8811
8812 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8813 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8814 wrong (Bug#8591).
8815
3fe4b549
JD
88162011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8817
0ce7e563
JD
8818 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8819 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8820 (xg_hide_tooltip): Fix comment.
8821
3fe4b549
JD
8822 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8823 in registerServicesMenuSendTypes.
8824 (validRequestorForSendType): Don't check ns_return_types.
8825
8826 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8827 ns_return_type.
8828
5df75e47
JR
88292011-07-08 Jason Rumney <jasonr@gnu.org>
8830
22610910
JR
8831 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8832 SH_SHOW for hidden windows (Bug#5482).
8833
5df75e47
JR
8834 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8835 frame struct members of non-existent frames (Bug#6284).
8836
699c10bd
JD
88372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8838
4393663b
JD
8839 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8840 variable firstTime not needed on OSX >= 10.6.
8841 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8842 >= 10.5. Use setKnobProportion, setDoubleValue.
8843
8844 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8845 (MAC_OS_X_VERSION_10_5): Define if not defined.
8846 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8847 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8848 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8849
8850 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8851 cString and lossyCString on OSX >= 10.4.
4393663b 8852
58179cce 8853 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8854 sizeToFit on OSX >= 10.2.
8855
8856 * nsimage.m (allocInitFromFile): Don't use deprecated method
8857 bestRepresentationForDevice on OSX >= 10.6.
8858
8859 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8860 to avoid warning.
8861
8862 * emacs.c: Declare unexec_init_emacs_zone.
8863
a63e0781
JD
8864 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8865
699c10bd
JD
8866 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8867
8868 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8869 on svcsMenu (Bug#8842).
8870
8871 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8872 ns_return_types.
8873 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8874
8875 * nsterm.m (QUTF8_STRING): Declare.
8876 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8877 (validRequestorForSendType): Return type is (id).
8878 Change indexOfObjectIdenticalTo to indexOfObject.
8879 Check if we have local selection before returning self (Bug#8842).
8880 (writeSelectionToPasteboard): Put local selection into paste board
8881 if we have a local selection (Bug#8842).
8882 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8883
8884 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8885 (ns_get_local_selection): Declare.
8886
54e10184
LMI
88872011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8888
9888ff71
LMI
8889 * keymap.c (describe_map_tree): Don't insert a double newline at
8890 the end of the buffer (bug#1169) and return whether we inserted
8891 something.
8892
54e10184
LMI
8893 * callint.c (Fcall_interactively): Change "reading args" to
8894 "providing args" to try to clarify what it does (bug#1010).
8895
15fa4783
KH
88962011-07-07 Kenichi Handa <handa@m17n.org>
8897
8898 * composite.c (composition_compute_stop_pos): Ignore a static
8899 composition starting before CHARPOS (Bug#8915).
8900
8901 * xdisp.c (handle_composition_prop): Likewise.
8902
a8815b00
EZ
89032011-07-07 Eli Zaretskii <eliz@gnu.org>
8904
8905 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8906 (Bug#9015)
8907
ef7b981d 89082011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8909
8910 * character.h (unicode_category_t): New enum type.
8911
8912 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8913 (Qchar_code_property_table): New variable.
8914 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8915 (UNIPROP_COMPRESSED_FORM_P): New macros.
8916 (char_table_ascii): Uncompress the compressed values.
8917 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8918 Uncompress the compressed values.
ac389d0c 8919 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8920 (char_table_ref_and_range): Uncompress the compressed values.
8921 (sub_char_table_set): New arg is_uniprop. Callers changed.
8922 Uncompress the compressed values.
8923 (sub_char_table_set_range): Args changed. Callers changed.
8924 (char_table_set_range): Adjuted for the above change.
8925 (map_sub_char_table): Delete args default_val and parent. Add arg
8926 top. Give decoded values to a Lisp function.
640c8776 8927 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8928 values to a Lisp function. Gcpro more variables.
8929 (uniprop_table_uncompress)
8930 (uniprop_decode_value_run_length): New functions.
8931 (uniprop_decoder, uniprop_decoder_count): New variables.
8932 (uniprop_get_decoder, uniprop_encode_value_character)
8933 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8934 New functions.
8935 (uniprop_encoder, uniprop_encoder_count): New variables.
8936 (uniprop_get_encoder, uniprop_table)
8937 (Funicode_property_table_internal, Fget_unicode_property_internal)
8938 (Fput_unicode_property_internal): New functions.
8939 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8940 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8941 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8942 char-code-property-alist.
8943
640c8776 8944 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8945 Vunicode_category_table.
8946
640c8776 8947 * font.c (font_range): Adjust for the change of
c805dec0
KH
8948 Vunicode_category_table.
8949
76b397fb
DN
89502011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8951
8952 * m/iris4d.h: Remove file, move contents ...
8953 * s/irix6-5.h: ... here.
8954
22b4128e
PE
89552011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8956
8957 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8958 * alloc.c (mark_buffer):
8959 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8960 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8961 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8962 This isn't true in general, and it's particularly not true
8963 if Emacs is configured with --with-wide-int.
8964 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8965 New macros, used in the buffer.c change.
8966
869795d6
JD
89672011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8968
8969 * xsettings.c: Use both GConf and GSettings if both are available.
8970 (store_config_changed_event): Add comment.
8971 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8972 (store_tool_bar_style_changed): New functions.
5e617bc2 8973 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8974 (struct xsettings): Move font inside HAVE_XFT.
8975 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8976 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8977 Move inside HAVE_XFT.
640c8776 8978 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8979 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8980 also.
8981 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8982 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8983 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8984 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8985 (parse_settings): Move check for font inside HAVE_XFT.
8986 (read_settings, apply_xft_settings): Add comment.
8987 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8988 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8989 call store_font_name_changed.
8990 (xft_settings_event): Add comment.
8991 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8992 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8993 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8994 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8995 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8996 (xsettings_get_system_font, xsettings_get_system_normal_font):
8997 Add comment.
869795d6 8998
d8ed26bd
PE
89992011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9000
9001 Random fixes. E.g., (random) never returned negative values.
9002 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9003 subseconds part to the entropy, as that's a bit more random.
9004 Prefer signed to unsigned, since the signedness doesn't matter and
9005 in general we prefer signed. When given a limit, use a
9006 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9007 latter isn't right if USE_2_TAGS_FOR_INTS.
9008 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9009 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9010
cabf1cac
SM
90112011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9012
9013 * textprop.c (text_property_stickiness):
9014 Obey Vtext_property_default_nonsticky.
9015 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9016 * w32fns.c (syms_of_w32fns):
9017 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9018
6e9b2be9
PE
90192011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9020
9021 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9022 This is more efficient than Ffile_directory_p and avoids a minor race.
9023
90186c68
LMI
90242011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9025
7c301272
LMI
9026 * buffer.c (Foverlay_put): Say what the return value is
9027 (bug#7835).
9028
c4f2d8d4
LMI
9029 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9030 is a directory before asking whether to use the file name
9031 (bug#7564).
ad637907
LMI
9032 (barf_or_query_if_file_exists): Make the "File is a directory"
9033 error be more correct.
c4f2d8d4 9034
90186c68
LMI
9035 * fns.c (Frequire): Remove the mention of the .gz files, since
9036 that's installation-specific, but keep the mention of
9037 `get-load-suffixes'.
9038
da64016e
PE
90392011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9040
9041 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9042 Report string overflow if the output is too long.
9043
7d47b580
JB
90442011-07-04 Juanma Barranquero <lekktu@gmail.com>
9045
a555cb87
JB
9046 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9047 (syms_of_gnutls): Remove duplicate DEFSYM for
9048 Qgnutls_bootprop_verify_hostname_error, an error for
9049 Qgnutls_bootprop_verify_error (which is no longer used).
9050
7d47b580
JB
9051 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9052 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9053 Also (re)move comments that are misplaced or no longer relevant.
9054
1e49bfab
LMI
90552011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9056
9057 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9058
1485f4c0
CY
90592011-07-03 Chong Yidong <cyd@stupidchicken.com>
9060
9061 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9062 and background color parameters if they have been changed.
9063
a9ab721e
LMI
90642011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9065
9066 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9067
cf7cff57
PE
90682011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9069
2e13213d
PE
9070 * xsettings.c (SYSTEM_FONT): Define only when used.
9071 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9072
cf7cff57
PE
9073 * keymap.c (access_keymap_1): Now static.
9074
7a8e04f7
CY
90752011-07-02 Chong Yidong <cyd@stupidchicken.com>
9076
9077 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9078 leave any prefix arg for the up event (Bug#1586).
9079
61352f62
LMI
90802011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9081
69bb1ef7
LMI
9082 * lread.c (syms_of_lread): Mention single symbols defined by
9083 `defvar' or `defconst' (bug#7154).
9084
61352f62 9085 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9086 (Frequire): Mention get-load-suffixes.
61352f62 9087
28545e04
MR
90882011-07-02 Martin Rudalics <rudalics@gmx.at>
9089
9090 * window.h (window): Remove clone_number slot.
9091 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9092 Remove.
9093 (make_parent_window, make_window, saved_window)
9094 (Fset_window_configuration, save_window_save): Don't deal with
9095 clone numbers.
9096 * buffer.c (Qclone_number): Remove declaration.
9097 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9098
3349e122
SM
90992011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9100
9101 Add multiple inheritance to keymaps.
9102 * keymap.c (Fmake_composed_keymap): New function.
9103 (Fset_keymap_parent): Simplify.
9104 (fix_submap_inheritance): Remove.
9105 (access_keymap_1): New function extracted from access_keymap to handle
9106 embedded parents and handle lists of maps.
9107 (access_keymap): Use it.
9108 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9109 (Fcopy_keymap): Handle embedded parents.
9110 (Fcommand_remapping, define_as_prefix): Simplify.
9111 (Fkey_binding): Simplify.
9112 (syms_of_keymap): Move minibuffer-local-completion-map,
9113 minibuffer-local-filename-completion-map,
9114 minibuffer-local-must-match-map, and
9115 minibuffer-local-filename-must-match-map to Elisp.
9116 (syms_of_keymap): Defsubr make-composed-keymap.
9117 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9118 (parse_menu_item): Trivial simplification.
9119
3279eb87
GM
91202011-07-01 Glenn Morris <rgm@gnu.org>
9121
9122 * Makefile.in (SETTINGS_LIBS): Fix typo.
9123
4550efdf
KI
91242011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9125
9126 * coding.c (Fencode_coding_string): Record the last coding system
9127 used, as the function doc string says (bug#8738).
9128
0949d2b6
JD
91292011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9130
9131 * xsettings.c (store_monospaced_changed): Take new font as arg and
9132 check for change against current_mono_font.
9133 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9134 (emacs_settings_constructor, emacs_settings_get_property)
9135 (emacs_settings_set_property, emacs_settings_class_init)
9136 (emacs_settings_init, gsettings_obj): Remove.
9137 (something_changedCB): New function for HAVE_GSETTINGS.
9138 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9139 with value as argument.
9140 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9141 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9142 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9143 "changed".
9144
9145 * xgselect.c: Add defined (HAVE_GSETTINGS).
9146 (xgselect_initialize): Ditto.
9147
9148 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9149 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9150 xg_select.
9151
bbc6b304
PE
91522011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9153
9154 * eval.c (struct backtrace): Simplify and port the data structure.
9155 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9156 signed bit field, as this assumption is not portable and it makes
9157 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9158 "char debug_on_exit : 1" as this is not portable either; instead,
9159 use the portable "unsigned int debug_on_exit : 1". Remove unused
9160 member evalargs. Remove obsolete comments about cc bombing out.
9161
9851bfc5
JD
91622011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9163
51bb811f 9164 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9165 Let HAVE_GSETTINGS override HAVE_GCONF.
9166 (store_monospaced_changed): New function.
9167 (EMACS_SETTINGS): A new type derived from GObject to handle
9168 GSettings notifications.
9169 (emacs_settings_constructor, emacs_settings_get_property)
9170 (emacs_settings_set_property, emacs_settings_class_init):
9171 New functions.
9172 (gsettings_client, gsettings_obj): New variables.
9173 (GSETTINGS_SCHEMA): New define.
9174 (something_changedCB): Call store_monospaced_changed.
9175 (init_gsettings): New function.
9176 (xsettings_initialize): Call init_gsettings.
9177 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9178 to NULL.
9179
640c8776 9180 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9181 GCONF_CFLAGS/LIBS.
9182
5386012d
MR
91832011-06-29 Martin Rudalics <rudalics@gmx.at>
9184
9185 * window.c (resize_root_window, grow_mini_window)
9186 (shrink_mini_window): Rename Qresize_root_window to
9187 Qwindow_resize_root_window and Qresize_root_window_vertically to
9188 Qwindow_resize_root_window_vertically.
9189
f13e0b08
PE
91902011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9191
9192 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9193
94515237
JB
91942011-06-27 Juanma Barranquero <lekktu@gmail.com>
9195
9196 * makefile.w32-in: Redesign dependencies so they reflect more
9197 clearly which files are directly included by each source file,
9198 and not through other includes.
9199
e43b6e43
MR
92002011-06-27 Martin Rudalics <rudalics@gmx.at>
9201
9202 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9203 (sort_overlays, overlay_strings): When an overlay's clone number
9204 matches the window's clone number process the overlay even if
9205 the overlay's window property doesn't match the current window.
9206
d68443dc
MR
9207 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9208 (Fwindow_hchild): Rename to Fwindow_left_child.
9209 (Fwindow_next): Rename to Fwindow_next_sibling.
9210 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9211 (resize_window_check): Rename to window_resize_check.
9212 (resize_window_apply): Rename to window_resize_apply.
9213 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9214 (Fdelete_other_windows_internal, resize_frame_windows)
9215 (Fsplit_window_internal, Fdelete_window_internal)
9216 (grow_mini_window, shrink_mini_window)
9217 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9218
c7e73be5
JD
92192011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9220
9221 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9222 (emacs_fixed_set_min_size): Remove.
9223 (emacs_fixed_new): Take frame as argument.
9224
9225 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9226 (_EmacsFixedPrivate): Remove minwidth/height.
9227 Add struct frame *f.
9228 (emacs_fixed_init): Initialize priv->f.
9229 (get_parent_class, emacs_fixed_set_min_size): Remove.
9230 (emacs_fixed_new): Set priv->f to argument.
9231 (emacs_fixed_get_preferred_width)
9232 (emacs_fixed_get_preferred_height): Use min_width/height from
9233 frames size_hint to set minimum and natural (Bug#8919).
9234 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9235 and use min_width/height from frames size_hint to set
9236 min_width/height (Bug#8919).
9237
9238 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9239 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9240 Fix indentation.
c7e73be5 9241
cf99dcf8
EZ
92422011-06-26 Eli Zaretskii <eliz@gnu.org>
9243
9244 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9245 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9246 called at ZV.
9247
029529ac
CY
92482011-06-26 Chong Yidong <cyd@stupidchicken.com>
9249
9250 * process.c (wait_reading_process_output): Bypass select if
9251 waiting for a cell while ignoring keyboard input, and input is
9252 pending. Suggested by Jan Djärv (Bug#8869).
9253
7a7ef429
PE
92542011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9255
9256 Use gnulib's dup2 module instead of rolling our own.
9257 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9258
11fdef7d 92592011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9260
9261 * dispnew.c (scrolling_window): Before scrolling, turn off a
9262 mouse-highlight in the window being scrolled.
9263
cd3520a4
JB
92642011-06-24 Juanma Barranquero <lekktu@gmail.com>
9265
9266 Move DEFSYM to lisp.h and use everywhere.
9267
9268 * character.h (DEFSYM): Move declaration...
9269 * lisp.h (DEFSYM): ...here.
9270
9271 * gnutls.c:
9272 * minibuf.c:
9273 * w32menu.c:
9274 * w32proc.c:
9275 * w32select.c: Don't include character.h.
9276
9277 * alloc.c (syms_of_alloc):
9278 * buffer.c (syms_of_buffer):
9279 * bytecode.c (syms_of_bytecode):
9280 * callint.c (syms_of_callint):
9281 * casefiddle.c (syms_of_casefiddle):
9282 * casetab.c (init_casetab_once):
9283 * category.c (init_category_once, syms_of_category):
9284 * ccl.c (syms_of_ccl):
9285 * cmds.c (syms_of_cmds):
9286 * composite.c (syms_of_composite):
9287 * dbusbind.c (syms_of_dbusbind):
9288 * dired.c (syms_of_dired):
9289 * dispnew.c (syms_of_display):
9290 * doc.c (syms_of_doc):
9291 * editfns.c (syms_of_editfns):
9292 * emacs.c (syms_of_emacs):
9293 * eval.c (syms_of_eval):
9294 * fileio.c (syms_of_fileio):
9295 * fns.c (syms_of_fns):
9296 * frame.c (syms_of_frame):
9297 * fringe.c (syms_of_fringe):
9298 * insdel.c (syms_of_insdel):
9299 * keymap.c (syms_of_keymap):
9300 * lread.c (init_obarray, syms_of_lread):
9301 * macros.c (syms_of_macros):
9302 * msdos.c (syms_of_msdos):
9303 * print.c (syms_of_print):
9304 * process.c (syms_of_process):
9305 * search.c (syms_of_search):
9306 * sound.c (syms_of_sound):
9307 * syntax.c (init_syntax_once, syms_of_syntax):
9308 * terminal.c (syms_of_terminal):
9309 * textprop.c (syms_of_textprop):
9310 * undo.c (syms_of_undo):
9311 * w32.c (globals_of_w32):
9312 * window.c (syms_of_window):
9313 * xdisp.c (syms_of_xdisp):
9314 * xfaces.c (syms_of_xfaces):
9315 * xfns.c (syms_of_xfns):
9316 * xmenu.c (syms_of_xmenu):
9317 * xsettings.c (syms_of_xsettings):
9318 * xterm.c (syms_of_xterm): Use DEFSYM.
9319
4228cf16
TZ
93202011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9321
cd3520a4 9322 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9323
7fcccf1e
PE
93242011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9325
7efb4e0e
PE
9326 Integer and buffer overflow fixes (Bug#8873).
9327
ff5844ad
PE
9328 * print.c (printchar, strout): Check for string overflow.
9329 (PRINTPREPARE, printchar, strout):
9330 Don't set size unless allocation succeeds.
9331
90532f02
PE
9332 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9333 for sizes. Check for string overflow more accurately.
9334 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9335
6d84508d
PE
9336 * macros.c: Integer and buffer overflow fixes.
9337 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9338 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9339 Use ptrdiff_t, not int, for sizes.
9340 Don't increment bufsize until after realloc succeeds.
9341 Check for size-calculation overflow.
9342 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9343
437b2cb4
PE
9344 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9345
8b9ac8b4
PE
9346 * lread.c: Integer overflow fixes.
9347 (read_integer): Radix is now EMACS_INT, not int,
9348 to improve quality of diagnostics for out-of-range radices.
9349 Calculate buffer size correctly for out-of-range radices.
9350 (read1): Check for integer overflow in radices, and in
9351 read-circle numbers.
82cb60d3
PE
9352 (read_escape): Avoid int overflow.
9353 (Fload, openp, read_buffer_size, read1)
9354 (substitute_object_recurse, read_vector, read_list, map_obarray):
9355 Use ptrdiff_t, not int, for sizes.
9356 (read1): Use EMACS_INT, not int, for sizes.
20270765 9357 Check for size overflow.
8b9ac8b4 9358
7fcccf1e
PE
9359 * image.c (cache_image): Check for size arithmetic overflow.
9360
bfbbd7e7
PE
9361 * lread.c: Integer overflow issues.
9362 (saved_doc_string_size, saved_doc_string_length)
9363 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9364 Now ptrdiff_t, not int.
9365 (read1): Don't assume doc string length fits in int. Check for
9366 out-of-range doc string lengths.
9367 (read_list): Don't assume file position fits in int.
39019e54 9368 (read_escape): Check for hex character overflow.
bfbbd7e7 9369
4e323265
LL
93702011-06-22 Leo Liu <sdl.web@gmail.com>
9371
9372 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9373 Move to minibuffer.el.
9374
85fece3e
PE
93752011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9376
20b84ce9 9377 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9378 The following patches are for when GLYPH_DEBUG && !XASSERT.
9379 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9380 * dispnew.c (flush_stdout):
9381 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9382 Mark as externally visible.
9383 * dispnew.c (check_window_matrix_pointers): Now static.
9384 * dispnew.c (window_to_frame_vpos):
9385 * xfns.c (unwind_create_frame):
9386 * xterm.c (x_check_font): Remove unused local.
9387 * scroll.c (CHECK_BOUNDS):
9388 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9389 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9390 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9391 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9392 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9393 Now static.
9394 (debug_method_add): Use va_list and vsprintf rather than relying
9395 on undefined behavior with wrong number of arguments.
9396 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9397 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9398 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9399 since we're not interested in debugging glyphs with old libraries.
9400 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9401 GCC 4.6.0's static checking.
9402
0766b489
PE
94032011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9404
31fd4b32
PE
9405 Integer overflow and signedness fixes (Bug#8873).
9406 A few related buffer overrun fixes, too.
9407
b79e8648
PE
9408 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9409
0766b489
PE
9410 * dispextern.h (struct face.stipple):
9411 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9412 (x_bitmap_mask, x_allocate_bitmap_record)
9413 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9414 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9415 (x_create_bitmap_from_xpm_data):
9416 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9417 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9418 (.bitmaps_last):
9419 * xfaces.c (load_pixmap):
9420 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9421 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9422 (.bitmaps_last, struct x_output.icon_bitmap):
9423 Use ptrdiff_t, not int, for bitmap indexes.
9424 (x_allocate_bitmap_record): Check for size overflow.
9425 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9426
b081724f
PE
9427 Use ptrdiff_t, not int, for overlay counts.
9428 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9429 * editfns.c (overlays_around, get_pos_property):
9430 * textprop.c (get_char_property_and_overlay):
9431 * xdisp.c (next_overlay_change, note_mouse_highlight):
9432 * xfaces.c (face_at_buffer_position):
21514da7
PE
9433 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9434 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9435 (Fnext_overlay_change, Fprevious_overlay_change)
9436 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9437 Use ptrdiff_t, not int, for sizes.
21514da7 9438 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9439
3de73e5e
PE
9440 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9441
2606c57b
PE
9442 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9443 (x_session_initialize): Do not assume string length fits in int.
9444
aaafe47a
PE
9445 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9446 This is unlikely, but can occur if DPI is outlandish.
9447
2674ddc8 9448 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9449 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9450
28154962
PE
9451 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9452 * xrdb.c (magic_file_p, search_magic_path):
9453 Omit last arg SUFFIX; it was always 0. All callers changed.
9454 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9455
7de51af5
PE
9456 * xfont.c (xfont_match): Avoid need for strlen.
9457
25ed6cc3
PE
9458 * xfns.c: Don't assume strlen fits in int.
9459 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9460
4eab31dd
PE
9461 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9462 not unsigned long, as we prefer signed integers. All callers changed.
9463 Detect integer overflow in repeat count.
9464 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9465 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9466
171e2a58
PE
9467 * termcap.c: Don't assume sizes fit in int and never overflow.
9468 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9469 (gobble_line): Check for size-calculation overflow.
9470
ad39faca 9471 * minibuf.c (Fread_buffer):
6e5bb2dc 9472 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9473 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9474 Don't assume string length fits in int.
9475
52c61c22 9476 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9477 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9478
b5b8c9e5
PE
9479 * font.c: Don't assume string length fits in int.
9480 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9481 Use ptrdiff_t, not int.
ccd6111c
PE
9482 (font_intern_prop): Don't assume string length fits in int.
9483 Don't assume integer property fits in fixnum.
9484 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9485
882f0d81 9486 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9487 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9488 Reformulate so as not to need the command string.
9489 Invoke gzip -cd rather than gunzip, as it's more portable.
9490 (lock_info_type, lock_file_1, lock_file):
9491 Don't assume pid_t and time_t fit in unsigned long.
9492 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9493 (current_lock_owner): Prefer signed type for sizes.
9494 Use memcpy, not strncpy, where memcpy is what is really wanted.
9495 Don't assume (via atoi) that time_t and pid_t fit in int.
9496 Check for time_t and/or pid_t out of range, e.g., via a network share.
9497 Don't alloca where an auto var works fine.
9498
93f4cf88
PE
9499 * fileio.c: Fix some integer overflow issues.
9500 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9501 Don't assume string length fits in int.
9502 (directory_file_name): Don't assume string length fits in long.
9503 (make_temp_name): Don't assume pid fits in int, or that its print
9504 length is less than 20.
9505
f3e92b69
PE
9506 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9507
1bfdaf10
PE
9508 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9509
35016e9a
PE
9510 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9511
3d1e65a1
PE
9512 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9513 We prefer signed integers, even for size calculations.
9514
0b963a93
PE
9515 * emacs.c: Don't assume string length fits in 'int'.
9516 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9517 (main): Don't invoke strlen when not needed.
9518
573f4b54
PE
9519 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9520 (XD_DEBUG_MESSAGE): Don't waste a byte.
9521
989f33ba
PE
9522 * callproc.c (getenv_internal_1, getenv_internal)
9523 (Fgetenv_internal):
965d34eb
PE
9524 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9525
e4d29b33
PE
9526 * lread.c (invalid_syntax): Omit length argument.
9527 All uses changed. This doesn't fix a bug, but it simplifies the
9528 code away from its former Hollerith-constant appearance, and it's
9529 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9530 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9531
eb49b136
PE
9532 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9533 This didn't break anything, but it didn't help either.
9534 It's confusing to put a bogus integer in a place where the actual
9535 value does not matter.
9f62aeb1 9536 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9537 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9538
15375a22
PE
9539 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9540 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9541 implementation.
b61cc01c
PE
9542 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9543 We prefer signed types, and the value cannot exceed the EMACS_INT
9544 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9545 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9546 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9547 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9548
53b2623d
PE
9549 * indent.c (sane_tab_width): New function.
9550 (current_column, scan_for_column, Findent_to, position_indentation)
9551 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9552 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9553
51cab52b 9554 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9555
f2ed8a70
PE
9556 * lisp.h (lint_assume): New macro.
9557 * composite.c (composition_gstring_put_cache):
9558 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9559
abe80cc6
PE
9560 * editfns.c, insdel.c:
9561 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9562
b02c740e
PE
9563 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9564
ebc96716
PE
9565 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9566
b4e50fa0 9567 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9568 Use much-faster test for byte-length change.
311d5d7c 9569 Don't assume string byte-length fits in 'int'.
a4cf38e4 9570 Check that character arg fits in 'int'.
85461888 9571 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9572
c0c1ee9f
PE
9573 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9574
a498d7f4
PE
9575 * fns.c (concat): Catch string overflow earlier.
9576 Do not rely on integer wraparound.
9577
51cab52b
PE
9578 * dispextern.h (struct it.overlay_strings_charpos)
9579 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9580 * xdisp.c (forward_to_next_line_start)
9581 (back_to_previous_visible_line_start)
9582 (reseat_at_next_visible_line_start, next_element_from_buffer):
9583 Don't arbitrarily truncate the value of 'selective' to int.
9584
76031fad
PE
9585 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9586
5eb55db9
PE
9587 * composite.c: Don't truncate sizes to 'int'.
9588 (composition_gstring_p, composition_reseat_it)
9589 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9590 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9591 not EMACS_UINT, for indexes.
5eb55db9 9592
0703a717
PE
9593 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9594
d6202519
PE
9595 * buffer.c: Include <verify.h>.
9596 (struct sortvec.priority, struct sortstr.priority):
8961a454 9597 Now EMACS_INT, not int.
c20998a7 9598 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9599 (struct sortstr.size, record_overlay_string)
9600 (struct sortstrlist.size, struct sortlist.used):
9601 Don't truncate size to int.
9602 (record_overlay_string): Check for size-calculation overflow.
d6202519 9603 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9604
d5a19415
JM
96052011-06-22 Jim Meyering <meyering@redhat.com>
9606
029529ac 9607 Don't leak an XBM-image-sized buffer
d5a19415
JM
9608 * image.c (xbm_load): Free the image buffer after using it.
9609
a9041e6c
PE
96102011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9611
9612 Port to Sun C.
9613 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9614 that Sun C diagnosed.
9615 * fns.c (secure_hash): Fix pointer signedness issue.
9616 * intervals.c (static_offset_intervals): New function.
9617 (offset_intervals): Use it.
9618
7f3f739f
LL
96192011-06-21 Leo Liu <sdl.web@gmail.com>
9620
9621 * deps.mk (fns.o):
9622 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9623 sha512.h.
9624
9625 * fns.c (secure_hash): Rename from crypto_hash_function and change
9626 the first arg to accept symbols.
5b66d427 9627 (Fsecure_hash): New primitive.
7f3f739f
LL
9628 (syms_of_fns): New symbols.
9629
76147d94
DD
96302011-06-20 Deniz Dogan <deniz@dogan.se>
9631
9632 * process.c (Fset_process_buffer): Clarify return value in
9633 docstring.
9634
7d7d0045
CY
96352011-06-18 Chong Yidong <cyd@stupidchicken.com>
9636
9637 * dispnew.c (add_window_display_history): Use BVAR.
9638
9639 * xdisp.c (debug_method_add): Use BVAR.
9640 (check_window_end, dump_glyph_matrix, dump_glyph)
9641 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9642
9643 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9644 Likewise.
9645
9646 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9647 check till after the cache is created in init_frame_faces.
9648
ff2bc410
SM
96492011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9650
9651 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9652
28177add
PE
96532011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9654
dd3482fe
PE
9655 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9656 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9657 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9658
393d71f3 9659 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9660 * fileio.c (Finsert_file_contents):
9661 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9662 Remove the old (too-loose) buffer overflow checks.
9663 They weren't needed, since make_gap checks for buffer overflow.
9664 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9665 The old code merely checked for Emacs fixnum overflow, and relied
9666 on undefined (wraparound) behavior. The new code avoids undefined
9667 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9668
2e6813b0 9669 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9670 Tune. Don't use wider integers than needed. Don't use alloca.
9671 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9672
599a9e4f
PE
9673 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9674
99561444
PE
9675 * insdel.c, lisp.h (buffer_overflow): New function.
9676 (insert_from_buffer_1, replace_range, replace_range_2):
9677 * insdel.c (make_gap_larger):
9678 * editfns.c (Finsert_char):
9679 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9680
28177add
PE
9681 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9682
e69dafad
PE
96832011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9684
4baa020d 9685 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9686
b1c46f02
PE
9687 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9688 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9689
e69dafad
PE
9690 * fileio.c: Don't assume EMACS_INT fits in off_t.
9691 (emacs_lseek): New static function.
9692 (Finsert_file_contents, Fwrite_region): Use it.
9693 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9694
566684ea
PE
9695 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9696
e6966cd6
PE
9697 * fns.c: Don't overflow int when computing a list length.
9698 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9699 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9700 truncation on 64-bit hosts. Check for QUIT every
9701 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9702 faster and is responsive enough.
9703 (Flength): Report an error instead of overflowing an integer.
9704 (Fsafe_length): Return a float if the value is not representable
9705 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9706 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9707 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9708
dd0b0efb
PE
9709 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9710 (header_size, word_size): New constants.
9711 (allocate_vectorlike): Don't check size overflow here.
9712 (allocate_vector): Check it here instead, since this is the only
9713 caller of allocate_vectorlike that could cause overflow.
9714 Check that the new vector's length is representable as a fixnum.
9715
86fe5cfe
PE
9716 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9717 The previous code was bogus. For example, next_almost_prime (32)
9718 returned 39, which is undesirable as it is a multiple of 3; and
9719 next_almost_prime (24) returned 25, which is a multiple of 5 so
9720 why was the code bothering to check for multiples of 7?
9721
80e88859
PE
9722 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9723
4a2f0ad6
PE
9724 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9725
f66c7cf8
PE
9726 Variadic C functions now count arguments with ptrdiff_t.
9727 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9728 Back then I didn't know that the Emacs coding style prefers signed int.
9729 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9730 were being counted with int, which may truncate counts on 64-bit
9731 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9732 * lisp.h (struct Lisp_Subr.function.aMANY)
9733 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9734 Arg counts are now ptrdiff_t, not size_t.
9735 All variadic functions and their callers changed accordingly.
9736 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9737 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9738 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9739 * callint.c (Fcall_interactively): Check arg count for overflow,
9740 to avoid potential buffer overrun. Use signed char, not 'int',
9741 for 'varies' array, so that we needn't bother to check its size
9742 calculation for overflow.
9743 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9744 * eval.c (apply_lambda):
9745 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9746 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9747 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9748
a1759b76
PE
9749 * callint.c (Fcall_interactively): Don't use index var as event count.
9750
d96be9fc
PE
9751 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9752 * mem-limits.h (SIZE): Remove; no longer used.
9753
a690a978 9754 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9755
578c21e6
PE
9756 Remove unnecessary casts.
9757 * xterm.c (x_term_init):
9758 * xfns.c (x_set_border_pixel):
9759 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9760 These aren't needed now that we assume ANSI C.
9761
96f53c6c
PE
9762 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9763 It's more likely to cause problems (due to unsigned overflow)
9764 than to cure them.
9765
83c77d31
PE
9766 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9767
ee2079f1
PE
9768 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9769
6da65536
PE
9770 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9771
7147c4a4
PE
9772 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9773
193e32d9
PE
9774 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9775
e5533da6
PE
9776 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9777
9910e595
PE
9778 GLYPH_CODE_FACE returns EMACS_INT, not int.
9779 * dispextern.h (merge_faces):
9780 * xfaces.c (merge_faces):
01103c44
PE
9781 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9782 Don't assume EMACS_INT fits in int.
9910e595 9783
2638320e
PE
9784 * character.h (CHAR_VALID_P): Remove unused parameter.
9785 * fontset.c, lisp.h, xdisp.c: All uses changed.
9786
045eb8d9
PE
9787 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9788
c1f134b5
PE
9789 * fns.c (concat): Minor tuning based on overflow analysis.
9790 This doesn't fix any bugs. Use int to hold character, instead
9791 of constantly refetching from Emacs object. Use XFASTINT, not
9792 XINT, for value known to be a character. Don't bother comparing
9793 a single byte to 0400, as it's always less.
9794
395fcb93 9795 * floatfns.c (Fexpt):
327eeec8
PE
9796 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9797
abbd3d23
PE
9798 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9799 for characters.
9800
684a03ef
PE
9801 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9802
0fed43f3
PE
9803 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9804 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9805 incorrectly succeed when S was a string, because 4294967386 was
9806 truncated before it was used.
9807
8fd02eb7
PE
9808 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9809 Otherwise, an out-of-range integer could cause undefined behavior
9810 on a 64-bit host.
9811
f8c86b69
PE
9812 * composite.c: Use int, not EMACS_INT, for characters.
9813 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9814 EMACS_INT, for values that are known to be in character range.
9815 This doesn't fix any bugs but is the usual style inside Emacs and
9816 may generate better code on 32-bit machines.
9817
34206dd2
PE
9818 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9819 This is for reasons similar to the recent CHAR_STRING fix.
9820 * charset.c (Fencode_char): Check that character arg is actually
9821 a character. Pass an int to ENCODE_CHAR.
9822 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9823 wider than 'int', as a compile-time check to prevent future regressions
9824 in this area.
9825
c5958d4c 9826 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9827
9828 Make sure a 64-bit char is never passed to CHAR_STRING.
9829 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9830 by silently ignoring the top 32 bits, allowing some values
9831 that were far too large to be valid characters.
9832 * character.h: Include <verify.h>.
9833 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9834 arguments are no wider than unsigned, as a compile-time check
9835 to prevent future regressions in this area.
9836 * data.c (Faset):
01103c44 9837 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9838 (Fsubst_char_in_region):
9839 * fns.c (concat):
9840 * xdisp.c (decode_mode_spec_coding):
9841 Adjust to CHAR_STRING's new requirement.
9842 * editfns.c (Finsert_char, Fsubst_char_in_region):
9843 * fns.c (concat): Check that character args are actually
9844 characters. Without this test, these functions did the wrong
9845 thing with wildly out-of-range values on 64-bit hosts.
9846
d37ca623
PE
9847 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9848 These casts should not be needed on 32-bit hosts, either.
9849 * keyboard.c (read_char):
9850 * lread.c (Fload): Remove casts to unsigned.
9851
ea204efb
PE
9852 * lisp.h (UNSIGNED_CMP): New macro.
9853 This fixes comparison bugs on 64-bit hosts.
9854 (ASCII_CHAR_P): Use it.
9855 * casefiddle.c (casify_object):
01103c44 9856 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9857 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9858 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9859 * dispextern.h (FACE_FROM_ID):
9860 * keyboard.c (read_char): Use UNSIGNED_CMP.
9861
41cb286c
PE
9862 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9863 not to EMACS_INT, to avoid GCC warning.
9864
4a1b9832
PE
9865 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9866
55daad71
PE
9867 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9868 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9869 isn't needed on 32-bit machines.
8f95c75c 9870
01103c44
PE
9871 * buffer.c (Fgenerate_new_buffer_name):
9872 Use EMACS_INT for count, not int.
0ceccced 9873 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9874
9875 * data.c (Qcompiled_function): Now static.
9876
c6f072e7
PE
9877 * window.c (window_body_lines): Now static.
9878
20ce5912
PE
9879 * image.c (gif_load): Rename local to avoid shadowing.
9880
9c4c5f81
PE
9881 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9882 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9883 * alloc.c (make_save_value): Integer argument is now of type
9884 ptrdiff_t, not int.
9885 (mark_object): Use ptrdiff_t, not int.
9886 * lisp.h (pD): New macro.
9887 * print.c (print_object): Use it.
9888
c0c5c8ae
PE
9889 * alloc.c: Use EMACS_INT, not int, to count objects.
9890 (total_conses, total_markers, total_symbols, total_vector_size)
9891 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9892 (total_free_floats, total_floats, total_free_intervals)
9893 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9894 Now EMACS_INT, not int. All uses changed.
9895 (Fgarbage_collect): Compute overall total using a double, so that
9896 integer overflow is less likely to be a problem. Check for overflow
9897 when converting back to an integer.
5a25e253
PE
9898 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9899 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9900 These were 'int' variables that could overflow on 64-bit hosts;
9901 they were never used, so remove them instead of repairing them.
211a0b2a 9902 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9903 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9904 Previously, this ceilinged at INT_MAX, but that doesn't work on
9905 64-bit machines.
e46bb31a 9906 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9907
c78baabf 9908 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9909 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9910 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9911 when a (possibly-narrower) signed value would do just as well.
9912 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9913
c9d624c6
PE
9914 * alloc.c: Catch some string size overflows that we were missing.
9915 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9916 for convenience in STRING_BYTES_MAX.
9917 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9918 The definition here is exact; the one in lisp.h was approximate.
9919 (allocate_string_data): Check for string overflow. This catches
9920 some instances we weren't catching before. Also, it catches
9921 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9922 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9923 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9924
c9d624c6
PE
9925 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9926 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9927 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9928
353032ce
PE
9929 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9930
2bccce07
PE
9931 * alloc.c (Fmake_string): Check for out-of-range init.
9932
0ac30604
SM
99332011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9934
9935 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9936
c195f2de
JD
99372011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9938
9939 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9940 xg_get_default_scrollbar_width.
9941
9942 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9943 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9944 (style_changed_cb): Call update_theme_scrollbar_width and call
9945 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9946 all frames (Bug#8505).
9947 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9948 Call gtk_window_set_resizable if HAVE_GTK3.
9949 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9950 and height if HAVE_GTK3 (Bug#8505).
9951 (scroll_bar_width_for_theme): New variable.
9952 (update_theme_scrollbar_width): New function.
9953 (xg_get_default_scrollbar_width): Move code to
9954 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9955 (xg_initialize): Call update_theme_scrollbar_width.
9956
9957 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9958
9959 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9960
e10ac9f1
MR
99612011-06-12 Martin Rudalics <rudalics@gmx.at>
9962
9963 * frame.c (make_frame): Call other_buffer_safely instead of
9964 other_buffer.
9965
9966 * window.c (temp_output_buffer_show): Call display_buffer with
9967 second argument Vtemp_buffer_show_specifiers and reset latter
9968 immediately after the call.
9969 (Vtemp_buffer_show_specifiers): New variable.
9970 (auto_window_vscroll_p, next_screen_context_lines)
9971 (Vscroll_preserve_screen_position): Remove leading asterisks from
9972 doc-strings.
9973
2d3c217e 99742011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9975
7b7f97e8 9976 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9977 * buffer.c (Qclone_number): Remove for now, as it's unused.
9978 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9979 (record_buffer): Remove unused local.
9980 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9981 (set_frame_buffer_list): Remove; unused.
9982 * frame.h (other_visible_frames): Remove decl.
9983 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9984 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9985 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9986 if HAVE_GPM.
9987 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9988 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9989 Define only if HAVE_GPM.
9990 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9991 (update_hints_inhibit): Remove; never set. All uses removed.
9992 * widgetprv.h (emacsFrameClassRec): Remove decl.
9993 * window.c (delete_deletable_window): Now returns void, since it
9994 wasn't returning anything.
9995 (compare_window_configurations): Remove unused locals.
9996 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9997 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9998 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9999 the same widths as pointers. This follows up on the 2011-05-06 patch.
10000 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10001 * xterm.h: Likewise.
10002 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10003
1384b89e
JB
100042011-06-12 Juanma Barranquero <lekktu@gmail.com>
10005
10006 * makefile.w32-in: Update dependencies.
10007 (LISP_H): Add lib/intprops.h.
10008
1100a63c
CY
100092011-06-11 Chong Yidong <cyd@stupidchicken.com>
10010
10011 * image.c (gif_load): Add animation frame delay to the metadata.
10012 (syms_of_image): Use DEFSYM. New symbol `delay'.
10013
6198ccd0
MR
100142011-06-11 Martin Rudalics <rudalics@gmx.at>
10015
10016 * window.c (delete_deletable_window): Re-add.
10017 (Fset_window_configuration): Rewrite to handle dead buffers and
10018 consequently deletable windows.
10019 (window_tree, Fwindow_tree): Remove. Supply functionality in
10020 window.el.
10021 (compare_window_configurations): Simplify code.
10022
b6e3633c
AS
100232011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10024
1ab0dee5
AS
10025 * image.c (imagemagick_load_image): Fix type mismatch.
10026 (Fimagemagick_types): Likewise.
10027
b6e3633c
AS
10028 * window.h (replace_buffer_in_windows): Declare.
10029
9397e56f
MR
100302011-06-11 Martin Rudalics <rudalics@gmx.at>
10031
10032 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10033 Qclone_number. Remove external declaration of Qdelete_window.
10034 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10035 code.
640c8776
SM
10036 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10037 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10038 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10039 buffer list implementation.
10040 (other_buffer_safely): New function.
10041 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10042 calls to replace_buffer_in_windows and
10043 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10044 if allowed.
10045 (record_buffer): Inhibit quitting and rewrite using quittable
10046 functions. Run Qbuffer_list_update_hook if allowed.
10047 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10048 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10049 Move switch-to-buffer to window.el.
9397e56f
MR
10050 (bury-buffer): Move to window.el.
10051 (Vbuffer_list_update_hook): New variable.
10052
10053 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10054 section.
10055
10056 * window.h (resize_frame_windows): Move up in code.
10057 (Fwindow_frame): Remove EXFUN.
10058 (replace_buffer_in_all_windows): Remove prototype.
10059 (replace_buffer_in_windows_safely): Add prototype.
10060
10061 * window.c: Declare Qdelete_window static again. Move down
10062 declaration of select_count.
10063 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10064 (Fother_window): Move to window.el.
10065 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10066 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10067 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10068 window.el.
10069 (replace_buffer_in_windows): Implement by calling
10070 Qreplace_buffer_in_windows.
10071 (replace_buffer_in_all_windows): Remove with some functionality
10072 moved into replace_buffer_in_windows_safely.
10073 (replace_buffer_in_windows_safely): New function.
10074 (select_window_norecord, select_frame_norecord): Move in front
10075 of run_window_configuration_change_hook. Remove now obsolete
10076 declarations.
640c8776
SM
10077 (Fset_window_buffer): Rewrite doc-string.
10078 Call Qrecord_window_buffer.
9397e56f
MR
10079 (keys_of_window): Move binding for other-window to window.el.
10080
b50691aa
CY
100812011-06-11 Chong Yidong <cyd@stupidchicken.com>
10082
10083 * dispextern.h (struct image): Replace data member, whose int_val
10084 and ptr_val fields were not used by anything, with a single
10085 lisp_val object.
10086
10087 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10088 (gif_clear_image, gif_load, imagemagick_load_image)
10089 (gs_clear_image, gs_load): Callers changed.
10090
3f754b86
PE
100912011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10092
cca69397
PE
10093 * buffer.h: Include <time.h>, for time_t.
10094 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10095
109e28d0
PE
10096 Fix minor problems found by static checking.
10097
60737f02
PE
10098 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10099
4b66faf3
PE
10100 Make identifiers static if they are not used in other modules.
10101 * data.c (Qcompiled_function, Qframe, Qvector):
10102 * image.c (QimageMagick, Qsvg):
10103 * minibuf.c (Qmetadata):
10104 * window.c (resize_window_check, resize_root_window): Now static.
10105 * window.h (resize_window_check, resize_root_window): Remove decls.
10106
109e28d0
PE
10107 * window.c (window_deletion_count, delete_deletable_window):
10108 Remove; unused.
46a4ce9e
PE
10109 (window_body_lines): Now static.
10110 (Fdelete_other_windows_internal): Mark vars as initialized.
10111 Make sure 'resize_failed' is initialized.
10112 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10113 (resize_window_apply): Remove unused local.
10114 * window.h (delete_deletable_window): Remove decl.
10115
109e28d0 10116 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10117 (imagemagick_load_image): Fix pointer signedness problem by changing
10118 last arg from unsigned char * to char *. All uses changed.
10119 Also, fix a local for similar reasons.
10120 Remove unused locals. Remove locals to avoid shadowing.
10121 (fn_rsvg_handle_free): Remove; unused.
10122 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10123 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10124
3f754b86
PE
10125 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10126
2547adb1
CY
101272011-06-10 Chong Yidong <cyd@stupidchicken.com>
10128
10129 * image.c (gif_load): Fix omitted cast error introduced by
10130 2011-06-06 change.
10131
2c8e37d4
MR
101322011-06-10 Martin Rudalics <rudalics@gmx.at>
10133
10134 * window.h (resize_proportionally, orig_total_lines)
10135 (orig_top_line): Remove from window structure.
10136 (set_window_height, set_window_width, change_window_heights)
10137 (Fdelete_window): Remove prototypes.
10138 (resize_frame_windows): Remove duplicate declaration.
10139
440a42e3
EZ
101402011-06-10 Eli Zaretskii <eliz@gnu.org>
10141
10142 * window.h (resize_frame_windows, resize_window_check)
10143 (delete_deletable_window, resize_root_window)
10144 (resize_frame_windows): Declare prototypes.
10145
10146 * window.c (resize_window_apply): Make definition be "static" to
10147 match the prototype.
10148
562dd5e9
MR
101492011-06-10 Martin Rudalics <rudalics@gmx.at>
10150
10151 * window.c: Remove declarations of Qwindow_size_fixed,
10152 window_min_size_1, window_min_size_2, window_min_size,
10153 size_window, window_fixed_size_p, enlarge_window, delete_window.
10154 Remove static from declaration of Qdelete_window, it's
10155 temporarily needed by Fbury_buffer.
10156 (replace_window): Don't assign orig_top_line and
10157 orig_total_lines.
10158 (Fdelete_window, delete_window): Remove. Window deletion is
10159 handled by window.el.
640c8776
SM
10160 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10161 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10162 (Fdelete_other_windows): Remove. Deleting other windows is
10163 handled by window.el.
10164 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10165 handled in window.el.
10166 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10167 Window minimum sizes are handled in window.el.
10168 (shrink_windows, size_window, set_window_height)
10169 (set_window_width, change_window_heights, window_height)
10170 (window_width, CURBEG, CURSIZE, enlarge_window)
10171 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10172 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10173 handled in window.el.
10174 (make_dummy_parent): Rename to make_parent_window and give it a
10175 second argument horflag.
10176 (make_window): Don't set resize_proportionally any more.
10177 (Fsplit_window): Remove. Windows are split in window.el.
10178 (save_restore_action, save_restore_orig_size)
10179 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10180 Resize mini windows in window.el.
10181 (grow_mini_window, shrink_mini_window): Implement by calling
10182 Qresize_root_window_vertically, resize_window_check and
10183 resize_window_apply.
640c8776
SM
10184 (saved_window, Fset_window_configuration, save_window_save):
10185 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10186 resize_proportionally.
10187 (window_min_height, window_min_width): Move to window.el.
10188 (keys_of_window): Move bindings for delete-other-windows,
10189 split-window, delete-window and enlarge-window to window.el.
10190
10191 * buffer.c: Temporarily extern Qdelete_window.
10192 (Fbury_buffer): Temporarily call Qdelete_window instead of
10193 Fdelete_window (Fbury_buffer will move to window.el soon).
10194
10195 * frame.c (set_menu_bar_lines_1): Remove code handling
10196 orig_top_line and orig_total_lines.
10197
10198 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10199 set_window_height but set heights directly.
10200 (change_frame_size_1): Use resize_frame_windows.
10201
10202 * xdisp.c (init_xdisp): Don't use set_window_height but set
10203 heights directly.
10204
640c8776
SM
10205 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10206 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10207 run_window_configuration_change_hook.
10208
10209 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10210 instead of change_window_heights and run
10211 run_window_configuration_change_hook.
10212
1a13852e
MR
102132011-06-09 Martin Rudalics <rudalics@gmx.at>
10214
10215 * window.c (replace_window): Rename second argument REPLACEMENT to
10216 NEW. New third argument SETFLAG. Rewrite.
10217 (delete_window, make_dummy_parent): Call replace_window with
10218 third argument 1.
10219 (window_list_1): Move down in code.
10220 (run_window_configuration_change_hook): Move set_buffer part
10221 before select_frame_norecord part in order to unwind correctly.
10222 Rename count1 to count.
10223 (recombine_windows, delete_deletable_window, resize_root_window)
10224 (Fdelete_other_windows_internal)
10225 (Frun_window_configuration_change_hook, make_parent_window)
10226 (resize_window_check, resize_window_apply, Fresize_window_apply)
10227 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10228 (Fdelete_window_internal, Fresize_mini_window_internal):
10229 New functions.
1a13852e
MR
10230 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10231
f3d1777e
MR
102322011-06-08 Martin Rudalics <rudalics@gmx.at>
10233
496e208e
MR
10234 * window.h (window): Add some new members to window structure -
10235 normal_lines, normal_cols, new_total, new_normal, clone_number,
10236 splits, nest, prev_buffers, next_buffers.
10237 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10238 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10239
f3d1777e
MR
10240 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10241 Remove.
496e208e
MR
10242 (make_dummy_parent): Set new members of windows structure.
10243 (make_window): Move down in code. Handle new members of window
10244 structure.
10245 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10246 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10247 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10248 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10249 (Fset_window_next_buffers, Fset_window_clone_number):
10250 New functions.
496e208e
MR
10251 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10252 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10253 Doc-string fixes.
10254 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10255 Argument WINDOW can be now internal window too.
10256 (Fwindow_use_time): Move up in code.
10257 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10258 Rewrite doc-string.
10259 (Fset_window_configuration, saved_window)
10260 (Fcurrent_window_configuration, save_window_save): Handle new
10261 members of window structure.
b9e809c2
MR
10262 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10263 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10264 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10265 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10266 Qget_mru_window, Qresize_root_window,
10267 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10268 Qauto_buffer_name; staticpro them.
f3d1777e 10269
abde8f8c
MR
102702011-06-07 Martin Rudalics <rudalics@gmx.at>
10271
10272 * window.c (Fwindow_total_size, Fwindow_left_column)
10273 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10274 (Fwindow_list_1): New functions.
10275 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10276 (Fwindow_width, Fscroll_left, Fscroll_right):
10277 Use window_body_cols instead of window_box_text_cols.
10278 (delete_window, Fset_window_configuration):
10279 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10280 (delete_all_subwindows): Take a window as argument and not a
10281 structure. Rewrite.
190b47e6
MR
10282 (window_loop): Remove handling of GET_LRU_WINDOW and
10283 GET_LARGEST_WINDOW.
10284 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10285
10286 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10287 window_box_text_cols. delete_all_subwindows now takes a
10288 Lisp_Object as argument.
abde8f8c 10289
640c8776
SM
10290 * indent.c (compute_motion, Fcompute_motion):
10291 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10292
fa8a67e6
MR
10293 * frame.c (delete_frame): Call delete_all_subwindows with root
10294 window as argument.
10295
a54e3482
DC
102962011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10297
10298 * fns.c (Fputhash): Document return value.
10299
60002bf5
CY
103002011-06-06 Chong Yidong <cyd@stupidchicken.com>
10301
10302 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10303
0c671da6 103042011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10305
b862a52a 10306 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10307
be44ca6c
PE
10308 Check for overflow when converting integer to cons and back.
10309 * charset.c (Fdefine_charset_internal, Fdecode_char):
10310 Use cons_to_unsigned to catch overflow.
10311 (Fencode_char): Use INTEGER_TO_CONS.
10312 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10313 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10314 * data.c (long_to_cons, cons_to_long): Remove.
10315 (cons_to_unsigned, cons_to_signed): New functions.
10316 These signal an error for invalid or out-of-range values.
10317 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10318 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10319 * font.c (Ffont_variation_glyphs):
10320 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10321 * lisp.h: Include <intprops.h>.
10322 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10323 (cons_to_signed, cons_to_unsigned): New decls.
10324 (long_to_cons, cons_to_long): Remove decls.
10325 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10326 (Fprimitive_undo): Use CONS_TO_INTEGER.
10327 * xfns.c (Fx_window_property): Likewise.
10328 * xselect.c: Include <limits.h>.
10329 (x_own_selection, selection_data_to_lisp_data):
10330 Use INTEGER_TO_CONS.
10331 (x_handle_selection_request, x_handle_selection_clear)
10332 (x_get_foreign_selection, Fx_disown_selection_internal)
10333 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10334 (lisp_data_to_selection_data): Use cons_to_unsigned.
10335 (x_fill_property_data): Use cons_to_signed.
10336 Report values out of range.
10337
d1f3d2af
PE
10338 Check for buffer and string overflow more precisely.
10339 * buffer.h (BUF_BYTES_MAX): New macro.
10340 * lisp.h (STRING_BYTES_MAX): New macro.
10341 * alloc.c (Fmake_string):
10342 * character.c (string_escape_byte8):
10343 * coding.c (coding_alloc_by_realloc):
10344 * doprnt.c (doprnt):
10345 * editfns.c (Fformat):
10346 * eval.c (verror):
10347 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10348 since they may not be the same number.
10349 * editfns.c (Finsert_char):
10350 * fileio.c (Finsert_file_contents):
10351 Likewise for BUF_BYTES_MAX.
10352
dd52fcea
PE
10353 * image.c: Use ptrdiff_t, not int, for sizes.
10354 (slurp_file): Switch from int to ptrdiff_t.
10355 All uses changed.
10356 (slurp_file): Check that file size fits in both size_t (for
10357 malloc) and ptrdiff_t (for sanity and safety).
10358
7f9bbdbb
PE
10359 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10360 if b->modtime has its maximal value.
10361
dfe18f82
PE
10362 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10363
84acfcf0
PE
10364 Don't assume time_t can fit into int.
10365 * buffer.h (struct buffer.modtime): Now time_t, not int.
10366 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10367 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10368
ccd9a01a
PE
10369 Minor fixes for signed vs unsigned integers.
10370 * character.h (MAYBE_UNIFY_CHAR):
10371 * charset.c (maybe_unify_char):
10372 * keyboard.c (read_char, reorder_modifiers):
10373 XINT -> XFASTINT, since the integer must be nonnegative.
10374 * ftfont.c (ftfont_spec_pattern):
10375 * keymap.c (access_keymap, silly_event_symbol_error):
10376 XUINT -> XFASTINT, since the integer must be nonnegative.
10377 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10378 since it makes no difference and we prefer signed.
10379 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10380 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10381 nonnegative.
10382
d6d100dd
SM
103832011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10384
10385 * window.h (Fwindow_frame): Declare.
10386
2b6148e4
PE
103872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10388
10389 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10390 (SPARE_MEMORY): Always define.
10391 (LARGE_REQUEST): Remove.
10392 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10393
f230ecc9
MR
103942011-06-06 Martin Rudalics <rudalics@gmx.at>
10395
727e958e
MR
10396 * lisp.h: Move EXFUNS for Fframe_root_window,
10397 Fframe_first_window and Fset_frame_selected_window to window.h.
10398
10399 * window.h: Move EXFUNS for Fframe_root_window,
10400 Fframe_first_window and Fset_frame_selected_window here from
10401 lisp.h.
10402
10403 * frame.c (Fwindow_frame, Fframe_first_window)
10404 (Fframe_root_window, Fframe_selected_window)
10405 (Fset_frame_selected_window): Move to window.c.
10406 (Factive_minibuffer_window): Move to minibuf.c.
10407 (Fother_visible_frames_p): New function.
10408
10409 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10410
f230ecc9
MR
10411 * window.c (decode_window, decode_any_window): Move up in code.
10412 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10413 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10414 (Fwindow_buffer): Move up and rewrite doc-string.
10415 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10416 (Fwindow_prev): New functions.
727e958e
MR
10417 (Fwindow_frame): Move here from frame.c. Accept any window as
10418 argument.
10419 (Fframe_root_window, Fframe_first_window)
10420 (Fframe_selected_window): Move here from frame.c. Accept frame
10421 or arbitrary window as argument. Update doc-strings.
10422 (Fminibuffer_window): Move up in code.
10423 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10424 (Fset_frame_selected_window): Move here from frame.c.
10425 Marginal rewrite.
727e958e
MR
10426 (Fselected_window, select_window, Fselect_window): Move up in
10427 code. Minor doc-string fixes.
f230ecc9 10428
4d09bcf6
PE
104292011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10430
10431 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10432 Do not assume that spare memory exists; that assumption is valid
10433 only if SYSTEM_MALLOC.
10434 (LARGE_REQUEST): New macro, so that the issue of large requests
10435 is separated from the issue of spare memory.
10436
810928a2
AS
104372011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10438
172418ad
AS
10439 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10440 format. (Bug#8806)
10441
43f862f7
AS
10442 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10443
810928a2
AS
10444 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10445 before statements.
10446
a059fe24
JD
104472011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10448
10449 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10450
10451 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10452
10453 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10454 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10455
989bf368
JB
104562011-06-05 Juanma Barranquero <lekktu@gmail.com>
10457
10458 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10459
4b80f674
CY
104602011-06-04 Chong Yidong <cyd@stupidchicken.com>
10461
10462 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10463 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10464 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10465 New error handlers.
4b80f674
CY
10466 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10467 Obey Vx_select_enable_clipboard_manager. Catch errors in
10468 x_clipboard_manager_save (Bug#8779).
10469 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10470 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10471
99a33b77 104722011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10473
10474 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10475
99a33b77 104762011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10477
10478 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10479 in the current matrix if keep_current_p is non-zero.
10480
8264569d
EZ
104812011-06-04 Eli Zaretskii <eliz@gnu.org>
10482
10483 * bidi.c (bidi_level_of_next_char): Fix last change.
10484
57f97249
EZ
104852011-06-03 Eli Zaretskii <eliz@gnu.org>
10486
fec2107c 10487 Support bidi reordering of text covered by display properties.
57f97249 10488
fec2107c
EZ
10489 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10490 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10491 (bidi_cache_search, bidi_cache_iterator_state)
10492 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10493 (bidi_level_of_next_char, bidi_move_to_visually_next):
10494 Support character positions inside a run of characters covered by a
fec2107c
EZ
10495 display string.
10496 (bidi_paragraph_init, bidi_resolve_explicit_1)
10497 (bidi_level_of_next_char): Call bidi_fetch_char and
10498 bidi_fetch_char_advance instead of FETCH_CHAR and
10499 FETCH_CHAR_ADVANCE.
10500 (bidi_init_it): Initialize new members.
10501 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10502 definitions.
10503 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10504 instead of using explicit *_CHAR codes.
d6d100dd
SM
10505 (bidi_resolve_explicit, bidi_resolve_weak):
10506 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10507 bidirectional text is supported only in multibyte buffers.
10508 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10509 it to initialize the frame_window_p member of struct bidi_it.
10510 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10511 (bidi_resolve_explicit, bidi_resolve_weak)
10512 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10513 bidi_it->nchars is non-positive.
10514 (bidi_level_of_next_char): Don't try to lookup the cache for the
10515 next/previous character if nothing is cached there yet, or if we
10516 were just reseat()'ed to a new position.
c40e2fb2 10517
0e14fe90
EZ
10518 * xdisp.c (set_cursor_from_row): Set start and stop points
10519 according to the row's direction when priming the loop that looks
10520 for the glyph on which to display cursor.
10521 (single_display_spec_intangible_p): Function deleted.
10522 (display_prop_intangible_p): Reimplement to call
10523 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10524 Accept 3 additional arguments needed by handle_display_spec.
10525 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10526 values: lists, `(when COND...)' forms, etc.
10527 (single_display_spec_string_p): Support property values that are
10528 lists with the argument STRING its top-level element.
10529 (display_prop_string_p): Fix the condition for processing a
10530 property that is a list to be consistent with handle_display_spec.
fec2107c 10531 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10532 last portion of handle_display_prop.
10533 (compute_display_string_pos): Accept additional argument
10534 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10535 value of a `display' property is a "replacing spec".
10536 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10537 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10538 the display property, but just return a value indicating whether
10539 the display property will replace the characters it covers.
10540 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10541 frame_window_p members of struct bidi_it.
d6d100dd
SM
10542 (compute_display_string_pos, compute_display_string_end):
10543 New functions.
fec2107c
EZ
10544 (push_it): Accept second argument POSITION, where pop_it should
10545 jump to continue iteration.
10546 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10547
fec2107c
EZ
10548 * keyboard.c (adjust_point_for_property): Adjust the call to
10549 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10550
10551 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10552 (bidi_init_it): Update prototypes.
10553 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10554 (compute_display_string_pos, compute_display_string_end):
10555 Declare prototypes.
fec2107c
EZ
10556 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10557 EMACS_INT.
fc6f18ce 10558
40087514 105592011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10560
57f53182
PE
10561 Malloc failure behavior now depends on size of allocation.
10562 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10563 * lisp.h: Change signatures accordingly.
10564 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10565 All callers changed. (Bug#8762)
10566
10567 * gnutls.c: Use Emacs's memory allocators.
10568 Without this change, the gnutls library would invoke malloc etc.
10569 directly, which causes problems on non-SYNC_INPUT hosts, and which
10570 runs afoul of improving memory_full behavior. (Bug#8761)
10571 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10572 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10573 xfree instead of the default malloc, realloc, free.
10574 (Fgnutls_boot): No need to check for memory allocation failure,
10575 since xmalloc does that for us.
10576
ac32cd99 10577 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10578 * category.c (hash_get_category_set):
10579 * ccl.c (ccl_driver):
10580 * charset.c (Fdefine_charset_internal):
10581 * charset.h (struct charset.hash_index):
10582 * composite.c (get_composition_id, gstring_lookup_cache)
10583 (composition_gstring_put_cache):
10584 * composite.h (struct composition.hash_index):
10585 * dispextern.h (struct image.hash):
10586 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10587 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10588 (hashfn_equal, hashfn_user_defined, make_hash_table)
10589 (maybe_resize_hash_table, hash_lookup, hash_put)
10590 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10591 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10592 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10593 * image.c (make_image, search_image_cache, lookup_image)
10594 (xpm_put_color_table_h):
10595 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10596 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10597 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10598 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10599 * alloc.c (allocate_vectorlike):
10600 Check for overflow in vector size calculations.
10601 * ccl.c (ccl_driver):
10602 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10603 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10604 need to be updated by these changes.
40087514
PE
10605 * fns.c (make_hash_table, maybe_resize_hash_table):
10606 Check for integer overflow with large hash tables.
0de4bb68
PE
10607 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10608 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10609 (SXHASH_REDUCE): New macro.
10610 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10611 Use it instead of discarding useful hash info with large hash values.
10612 (sxhash_float): New function.
10613 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10614 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10615 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10616 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10617 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10618 Adjust signatures to match updated version of code.
10619 (consing_since_gc): Now EMACS_INT, since a single hash table can
10620 use more than INT_MAX bytes.
10621
698d32e2
DN
106222011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10623
10624 Make it possible to build with GCC-4.6+ -O2 -flto.
10625
10626 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10627
fd6fa53f
SM
106282011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10629
10630 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10631 Call minibuffer-inactive-mode.
10632
864db017
JB
106332011-05-31 Juanma Barranquero <lekktu@gmail.com>
10634
10635 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10636 Update dependencies.
10637
2ad0baf4
DN
106382011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10639
10640 * data.c (init_data): Remove code for UTS, this system is not
10641 supported anymore.
10642
4fcc2638
DN
106432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10644
10645 Don't force ./temacs to start in terminal mode.
10646
10647 * frame.c (make_initial_frame): Initialize faces in all cases, not
10648 only when CANNOT_DUMP is defined.
10649 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10650
c56e0fd5
DN
106512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10652
10653 * dispnew.c (add_window_display_history): Use const for the string
10654 pointer. Remove declaration, not needed.
10655
333d54da 106562011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10657
55d4c1b2 10658 Use 'inline', not 'INLINE'.
333d54da 10659 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10660 * alloc.c, fontset.c (INLINE): Remove.
10661 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10662 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10663 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10664 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10665 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10666
738db178
DN
106672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10668
10669 Make it possible to run ./temacs.
10670
10671 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10672 syms_of_callproc does the same thing. Remove test for
10673 "initialized", do it in the caller.
10674 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10675
620c53a6
SM
106762011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10677
10678 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10679 (read_minibuf): Use get_minibuffer.
10680 (syms_of_minibuf): Use DEFSYM.
10681 (Qmetadata): New var.
10682 * data.c (Qbuffer): Don't make it static.
10683 (syms_of_data): Use DEFSYM.
10684
e003a292
PE
106852011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10686
10687 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10688 (CCL_CODE_MIN): New macro.
10689
ed008a6d
PE
106902011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10691
3687c2ef
PE
10692 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10693
ed008a6d
PE
10694 * eval.c (Qdebug): Now static.
10695 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10696 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10697 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10698
d66c4c7c
CY
106992011-05-29 Chong Yidong <cyd@stupidchicken.com>
10700
10701 * image.c: Various fixes to ImageMagick code comments.
10702 (Fimagemagick_types): Doc fix.
10703
5fbc2025
PE
107042011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10705
0196f88a
PE
10706 Minor fixes prompted by GCC 4.6.0 warnings.
10707
10708 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10709
5fbc2025
PE
10710 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10711 (x_clipboard_manager_save_all): Move extern decl to ...
10712 * xterm.h: ... here, so that it can be checked for consistency.
10713
1dd3c2d9
CY
107142011-05-29 Chong Yidong <cyd@stupidchicken.com>
10715
10716 * xselect.c (x_clipboard_manager_save_frame)
10717 (x_clipboard_manager_save_all): New functions.
10718 (Fx_clipboard_manager_save): Lisp function deleted.
10719
10720 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10721 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10722
10723 * xterm.h: Update prototype.
10724
5ba6571d
WX
107252011-05-28 William Xu <william.xwl@gmail.com>
10726
10727 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10728 exiting (Bug#8239).
10729
3eaff834
JM
107302011-05-28 Jim Meyering <meyering@redhat.com>
10731
e1900994 10732 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10733 * fns.c (to_uchar): Define.
10734 (crypto_hash_function): Use it to convert some newly-signed
10735 variables to unsigned, to avoid sign-extension bugs. For example,
10736 without this change, (md5 "truc") would evaluate to
10737 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10738 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10739 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10740
0f6990a7
PE
107412011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10742
10743 Integer overflow fixes.
c8a9ca5a 10744
08686060
PE
10745 * dbusbind.c: Serial number integer overflow fixes.
10746 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10747 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10748 to hold a serial number that is too large for a fixnum.
10749 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10750 Check for serial numbers out of range. Decode any serial number
59568bf0 10751 that was so large that it became a float. (Bug#8722)
08686060 10752
2d1fc3c7
PE
10753 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10754 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10755 Use XFASTINT rather than XUINT when numbers are nonnegative.
10756 (xd_append_arg, Fdbus_method_return_internal):
10757 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10758 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10759 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10760 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10761 (Bug#8722)
2d1fc3c7 10762
c8a9ca5a
PE
10763 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10764
519e1d69
PE
10765 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10766
6df6ae42 10767 ccl: Add integer overflow checks.
30569699
PE
10768 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10769 (IN_INT_RANGE): New macros.
10770 (ccl_driver): Use them to check for integer overflow when
10771 decoding a CCL program. Many of the new checks are whether XINT (x)
10772 fits in int; it doesn't always, on 64-bit hosts. The new version
10773 doesn't catch all possible integer overflows, but it's an
847044ea 10774 improvement. (Bug#8719)
30569699 10775
c11285dc
PE
10776 * alloc.c (make_event_array): Use XINT, not XUINT.
10777 There's no need for unsigned here.
10778
fdccd48e
PE
10779 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10780 This follows up to the 2011-05-06 change that substituted uintptr_t
10781 for EMACS_INT. This case wasn't caught back then.
10782
37910ab2
PE
10783 Rework Fformat to avoid integer overflow issues.
10784 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10785 now (part of C89). Include <verify.h>.
10786 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10787 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10788 (Fformat): Avoid the prepass trying to compute sizes; it was only
10789 approximate and thus did not catch overflow reliably. Instead, walk
10790 through the format just once, formatting and computing sizes as we go,
10791 checking for integer overflow at every step, and allocating a larger
10792 buffer as needed. Keep track separately whether the format is
10793 multibyte. Keep only the most-recently calculated precision, rather
10794 than them all. Record whether each argument has been converted to
10795 string. Use EMACS_INT, not int, for byte and char and arg counts.
10796 Support field widths and precisions larger than INT_MAX. Avoid
10797 sprintf's undefined behavior with conversion specifications such as %#d
10798 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10799 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10800 formatting out-of-range floating point numbers with int
9173deec 10801 formats. (Bug#8668)
37910ab2 10802
2e6578fb
PE
10803 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10804
0ae6bdee
PE
10805 * data.c: Avoid integer truncation in expressions involving floats.
10806 * data.c: Include <intprops.h>.
10807 (arith_driver): When there's an integer overflow in an expression
10808 involving floating point, convert the integers to floating point
10809 so that the resulting value does not suffer from catastrophic
10810 integer truncation. For example, on a 64-bit host (* 4
10811 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10812 Do not rely on undefined behavior after integer overflow.
10813
de883a70
PE
10814 merge count_size_as_multibyte, parse_str_to_multibyte
10815 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10816 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10817 Check for integer overflow.
10818 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10819 since it's now a duplicate of the other. This is more of
10820 a character than a buffer op, so better that it's in character.c.
10821 * fns.c, print.c: Adjust to above changes.
10822
2ff916cb
PE
108232011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10824
10825 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10826
f1b54466
PE
108272011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10828
fb1ac845
PE
10829 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10830 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10831 (x_clipboard_manager_save): Now static.
10832 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10833
f1b54466
PE
10834 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10835 (crypto_hash_function): Now static.
10836 Fix pointer signedness problems. Avoid unnecessary initializations.
10837
a9f737ee
CY
108382011-05-27 Chong Yidong <cyd@stupidchicken.com>
10839
10840 * termhooks.h (Vselection_alist): Make it terminal-local.
10841
10842 * terminal.c (create_terminal): Initialize it.
10843
10844 * xselect.c: Support for clipboard managers.
10845 (Vselection_alist): Move to termhooks.h as terminal-local var.
10846 (LOCAL_SELECTION): New macro.
10847 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10848 (symbol_to_x_atom): Remove gratuitous arg.
10849 (x_handle_selection_request, lisp_data_to_selection_data)
10850 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10851 (x_own_selection, x_get_local_selection, x_convert_selection):
10852 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10853 (some_frame_on_display): Delete unused function.
10854 (Fx_own_selection_internal, Fx_get_selection_internal)
10855 (Fx_disown_selection_internal, Fx_selection_owner_p)
10856 (Fx_selection_exists_p): New optional frame arg.
10857 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10858 (x_handle_selection_clear): Don't treat other terminals with the
10859 same keyboard specially. Use the terminal-local Vselection_alist.
10860 (x_clear_frame_selections): Use Frun_hook_with_args.
10861
10862 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10863
10864 * xterm.h: Add support for those atoms.
10865
e067f0c1
CY
108662011-05-26 Chong Yidong <cyd@stupidchicken.com>
10867
10868 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10869 (converted_selections, conversion_fail_tag): New global variables.
10870 (x_selection_request_lisp_error): Free the above.
10871 (x_get_local_selection): Remove unnecessary code.
10872 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10873 of converted selections stored in converted_selections.
10874 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10875 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10876 (x_convert_selection): New function.
10877 (x_handle_selection_event): Simplify.
10878 (x_get_foreign_selection): Don't ignore incoming requests while
10879 waiting for an answer; this will fail when we implement
10880 SAVE_TARGETS, and seems unnecessary anyway.
10881 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10882 (Vx_sent_selection_functions): Doc fix.
10883
0f4aebc0
LL
108842011-05-26 Leo Liu <sdl.web@gmail.com>
10885
10886 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10887
e61124cd
YM
108882011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10889
10890 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10891
10892 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10893 for fringe update if it has periodic bitmap.
ac389d0c 10894 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10895 and fringe_bitmap_periodic_p.
10896
10897 * fringe.c (get_fringe_bitmap_data): New function.
10898 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10899 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10900 row. Mark glyph row for fringe update if periodicity changed.
10901
10902 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10903 for fringe update unless it has periodic bitmap.
10904
f16d9837
KH
109052011-05-25 Kenichi Handa <handa@m17n.org>
10906
10907 * xdisp.c (get_next_display_element): Set correct it->face_id for
10908 a static composition.
10909
e1b90ef6
LL
109102011-05-24 Leo Liu <sdl.web@gmail.com>
10911
10912 * deps.mk (fns.o):
10913 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10914
10915 * fns.c (crypto_hash_function, Fsha1): New function.
10916 (Fmd5): Use crypto_hash_function.
10917 (syms_of_fns): Add Ssha1.
10918
7400048f
PE
109192011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10920
10921 * gnutls.c: Remove unused macros.
10922 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10923 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10924 Remove macros that are defined and never used.
10925 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10926
abb71cf4
CY
109272011-05-22 Chong Yidong <cyd@stupidchicken.com>
10928
10929 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10930 (Fx_get_selection_internal): Minor cleanup.
10931 (Fx_own_selection_internal): Rename arguments for consistency with
10932 select.el.
10933
6307db39
PE
109342011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10935
10936 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10937
f3d4e0a4
CY
109382011-05-22 Chong Yidong <cyd@stupidchicken.com>
10939
10940 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10941
4d8ade89
YM
109422011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10943
10944 * dispnew.c (scrolling_window): Don't exclude the case that the
10945 last enabled row in the desired matrix touches the bottom boundary.
10946
32078c8d
GM
109472011-05-21 Glenn Morris <rgm@gnu.org>
10948
10949 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10950 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10951 and add some more files.
32078c8d 10952
7285dc67
EZ
109532011-05-20 Eli Zaretskii <eliz@gnu.org>
10954
10955 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10956 report_file_error introduced by the change from 2011-05-07.
10957
89d1bd22
PE
109582011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10959
10960 * systime.h (Time): Define only if emacs is defined.
10961 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10962 where the include path doesn't have X11/X.h by default. See
10963 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10964
cd394be1 109652011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10966
10967 * composite.c (find_automatic_composition): Fix previous change.
10968
b9704ad9
GM
109692011-05-20 Glenn Morris <rgm@gnu.org>
10970
10971 * lisp.mk: New file, split from Makefile.in.
10972 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10973 (shortlisp): Remove.
10974 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10975
4a720484
GM
109762011-05-19 Glenn Morris <rgm@gnu.org>
10977
10978 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10979 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10980 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10981 (lisp): Set the order to that of loadup.el.
10982 (shortlisp): Make it a copy of $lisp.
10983 (SOME_MACHINE_LISP): Remove.
10984 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10985 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10986
a28d4396
KH
109872011-05-18 Kenichi Handa <handa@m17n.org>
10988
10989 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10990 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10991 (find_automatic_composition): Mostly rewrite for efficiency.
10992
a2b1fa8e
JB
109932011-05-18 Juanma Barranquero <lekktu@gmail.com>
10994
10995 * makefile.w32-in: Update dependencies.
10996
8e1f5610
CS
109972011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10998
10999 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11000 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11001
7025ee00 110022011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11003
cdfa6eab
PE
11004 Fix some integer overflow issues, such as string length overflow.
11005
06d6db33
PE
11006 * insdel.c (count_size_as_multibyte): Check for string overflow.
11007
2b4560a8
PE
11008 * character.c (lisp_string_width): Check for string overflow.
11009 Use EMACS_INT, not int, for string indexes and lengths; in
11010 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11011 the resulting string length overflows an EMACS_INT; instead,
11012 report a string overflow if no precision given. When checking for
11013 precision exhaustion, use a check that cannot possibly have
11014 integer overflow. (Bug#8675)
11015 * character.h (lisp_string_width): Adjust to new signature.
11016
cb93f9be
PE
11017 * alloc.c (string_overflow): New function.
11018 (Fmake_string): Use it. This doesn't change behavior, but saves
11019 a few bytes and will simplify future changes.
11020 * character.c (string_escape_byte8): Likewise.
11021 * lisp.h (string_overflow): New decl.
11022
1a1f3366
PE
11023 Fixups, following up to the user-interface timestamp change.
11024 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11025 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11026 * msdos.c (mouse_get_pos): Likewise.
11027 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11028 * w32gui.h (Time): Define by including "systime.h" rather than by
11029 declaring it ourselves. (Bug#8664)
11030
d4e3e4d3
PE
11031 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11032 * image.c (clear_image_cache): Likewise.
11033
f6a24d19
PE
11034 * term.c (term_mouse_position): Don't assume time_t wraparound.
11035
08dc5ae6
PE
11036 Be more systematic about user-interface timestamps.
11037 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11038 and sometimes 'EMACS_UINT', to represent these timestamps.
11039 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11040 This makes the code easier to follow, and makes it easier to catch
11041 integer overflow bugs such as Bug#8664.
11042 * frame.c (Fmouse_position, Fmouse_pixel_position):
11043 Use Time, not unsigned long, for user-interface timestamps.
11044 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11045 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11046 * keyboard.h (last_event_timestamp): Likewise.
11047 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11048 * menu.h (xmenu_show): Likewise.
11049 * term.c (term_mouse_position): Likewise.
11050 * termhooks.h (struct input_event.timestamp): Likewise.
11051 (struct terminal.mouse_position_hook): Likewise.
11052 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11053 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11054 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11055 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11056 what it was before.
11057 * menu.h, termhooks.h: Include "systime.h", for Time.
11058
8e55734a
PE
11059 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11060 Don't assume that the difference between two unsigned long values
11061 can fit into an integer. At this point, we know button_down_time
11062 <= event->timestamp, so the difference must be nonnegative, so
11063 there's no need to cast the result if double-click-time is
11064 nonnegative, as it should be; check that it's nonnegative, just in
11065 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11066 apart (about 25 days). (Bug#8664)
8e55734a 11067
841f1b75 11068 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11069 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11070
3e26f69c
PE
11071 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11072 that always fit in int. Use a sentinel instead of a counter, to
11073 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11074 * frame.h (struct frame): Use int for menu_bar_items_used
11075 instead of EMACS_INT, since it always fits in int.
3e26f69c 11076
5cc152c0
PE
11077 * menu.c (grow_menu_items): Check for int overflow.
11078
d89eb65e
PE
11079 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11080
5235bd3e
PE
11081 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11082 Before, the code was not consistent. These values cannot exceed
11083 2**31 - 1 so there's no need to make them unsigned.
11084 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11085 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11086 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11087 as modifiers.
11088 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11089
bc827e23
PE
11090 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11091 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11092 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11093 presumably because the widths might not match.
11094
78eb494e
PE
11095 * window.c (size_window): Avoid needless test at loop start.
11096
04f2d78b
CB
110972011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11098
11099 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11100
d2fc7e3d 111012011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11102
11103 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11104
d2fc7e3d 111052011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11106
11107 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11108 `width' to `bar_area_x' and `bar_area_width', respectively.
11109 (x_scroll_run): Take account of fringe background extension.
11110
04f2d78b
CB
11111 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11112 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11113 `bar_area_width', respectively.
11114 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11115 background extension.
11116
79b70037
GM
111172011-05-10 Jim Meyering <meyering@redhat.com>
11118
11119 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11120
2f142cc5
JB
111212011-05-10 Juanma Barranquero <lekktu@gmail.com>
11122
11123 * image.c (Finit_image_library): Return t for built-in image types,
11124 like pbm and xbm. (Bug#8640)
11125
57679c86
AS
111262011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11127
11128 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11129
888c9e86
EZ
111302011-05-07 Eli Zaretskii <eliz@gnu.org>
11131
b0512a1d
EZ
11132 * w32console.c (Fset_screen_color): Doc fix.
11133 (Fget_screen_color): New function.
11134 (syms_of_ntterm): Defsubr it.
11135
7285dc67
EZ
11136 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11137 unlink the temporary file if Fcall_process didn't create it in the
11138 first place.
11139 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11140 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11141 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11142 cue to call_process_cleanup not to close that handle.
11143
4d3fcc8e
BK
111442011-05-07 Ben Key <bkey76@gmail.com>
11145
11146 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11147 one of two shell specific rules, either bootstrap-temacs-CMD or
11148 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11149 to the previous implementation of the bootstrap-temacs rule.
11150 The bootstrap-temacs-CMD rule is similar to the previous
11151 implementation of the bootstrap-temacs rule except that it
11152 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11153 variable.
11154
11155 These changes, along with some changes to nt/configure.bat,
11156 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11157 earlier fix to add support for --cflags and --ldflags options
11158 that include quotes so that it works whether make uses cmd or
11159 sh as the shell.
11160
b4289b64
MA
111612011-05-06 Michael Albinus <michael.albinus@gmx.de>
11162
11163 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11164 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11165 is a constant.
11166 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11167 a string. Handle both cases.
11168 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11169 (Fdbus_register_method): Use Qinvalid_function.
11170
af4c0e28
JB
111712011-05-06 Juanma Barranquero <lekktu@gmail.com>
11172
11173 * makefile.w32-in: Update dependencies.
11174 (LISP_H): Add inttypes.h and stdin.h.
11175 (PROCESS_H): Add unistd.h.
11176
c51453d9
EZ
111772011-05-06 Eli Zaretskii <eliz@gnu.org>
11178
11179 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11180 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11181
8ff0ac3c 111822011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11183
4c4b566b
PE
11184 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11185
aab2b9b5
PE
11186 * term.c (vfatal): Remove stray call to va_end.
11187 It's not needed and the C Standard doesn't allow it here anyway.
11188
c378da0b
PE
11189 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11190 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11191
288b08c7
PE
11192 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11193 bytes.
11194
e3601888
PE
11195 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11196
db6c0e74
PE
11197 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11198
dd5963ea
PE
11199 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11200
88c9450f
PE
11201 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11202
2f9442b8
PE
11203 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11204
c032b5f8
PE
11205 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11206 * charset.c (Fdefine_charset_internal): Don't initialize
11207 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11208 32-bit int (Bug#8600).
a108c10b
PE
11209
11210 * lread.c (read_integer): Be more consistent with string-to-number.
11211 Use string_to_number to do the actual conversion; this avoids
11212 rounding errors and fixes some other screwups. Without this fix,
11213 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11214 (digit_to_number): Move earlier, for benefit of read_integer.
11215 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11216 not a digit in any supported base. (Bug#8602)
a108c10b 11217
ad5f9eea
PE
11218 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11219
aec1708a
PE
11220 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11221 to match comment at start of function. This also removes a
11222 GCC warning about overflow in a 32+64-bit port.
11223
47be4ab5
PE
11224 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11225
371cac43
PE
11226 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11227 Reported by Stefan Monnier in
11228 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11229 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11230 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11231
d01a7826
PE
11232 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11233 (EMACS_UINTPTR): Likewise, with uintptr_t.
11234
7fd47d5c
PE
11235 * lisp.h: Prefer 64-bit EMACS_INT if available.
11236 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11237 on 32-bit hosts that have 64-bit int, so that they can access
11238 large files.
122b0c86
PE
11239 However, temporarily disable this change unless the temporary
11240 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11241
8727937b
PE
11242 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11243
8ac068ac
PE
11244 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11245 This removes an assumption that EMACS_INT and long are the same
11246 width as pointers. The assumption is true for Emacs porting targets
11247 now, but we want to make other targets possible.
11248 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11249 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11250 In the rest of the code, change types of integers that hold casted
11251 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11252 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11253 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11254 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11255 No need to cast type when ORing.
11256 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11257 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11258 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11259 assume EMACS_INT is the same width as char *.
11260 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11261 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11262 Remove no-longer-needed casts.
11263 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11264 (xg_tool_bar_help_callback, xg_make_tool_item):
11265 Use EMACS_INTPTR to hold an integer
11266 that will be cast to void *; this can avoid a GCC warning
11267 if EMACS_INT is not the same width as void *.
11268 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11269 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11270 (current_message_1, set_message_1):
11271 Use a local to convert to proper width without a cast.
11272 * xmenu.c (dialog_selection_callback): Likewise.
11273
ede49d71
PE
11274 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11275 Also, don't assume VALBITS / RAND_BITS is less than 5,
11276 and don't rely on undefined behavior when shifting a 1 left into
11277 the sign bit.
11278 * lisp.h (get_random): Change signature to match.
11279
2f30ecd0
PE
11280 * lread.c (hash_string): Use size_t, not int, for hash computation.
11281 Normally we prefer signed values; but hashing is special, because
11282 it's better to use unsigned division on hash table sizes so that
11283 the remainder is nonnegative. Also, size_t is the natural width
11284 for hashing into memory. The previous code used 'int', which doesn't
11285 retain enough info to hash well into very large tables.
11286 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11287
2a866e7b
PE
11288 * dbusbind.c: Don't possibly lose pointer info when converting.
11289 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11290 Use XPNTR rather than XHASH, so that the high-order bits of
11291 the pointer aren't lost when converting through void *.
11292
51639eac
PE
11293 * eval.c (Fautoload): Don't double-shift a pointer.
11294
92394119
PE
11295 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11296
dbdb9a7c
JB
112972011-05-06 Juanma Barranquero <lekktu@gmail.com>
11298
11299 * gnutls.c (DEF_GNUTLS_FN):
11300 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11301
db7a0b4f
AS
113022011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11303
11304 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11305 marker. (Bug#8610)
11306
cd394be1 113072011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11308
11309 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11310 New version that can reserve upto 2GB of heap space.
11311
f7ff1b0f 113122011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11313
11314 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11315
639c109b
TZ
113162011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11317
11318 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11319 `gnutls_certificate_set_x509_key_file'.
11320
d2127135
JB
113212011-05-05 Juanma Barranquero <lekktu@gmail.com>
11322
11323 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11324 Update dependencies.
11325
e968f4f3
JB
113262011-05-04 Juanma Barranquero <lekktu@gmail.com>
11327
11328 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11329 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11330 Remove unused parameter `fildes'.
11331 * process.c (read_process_output, send_process): Don't pass it.
11332
84d358f0
JB
113332011-05-04 Juanma Barranquero <lekktu@gmail.com>
11334
11335 Fix previous change: the library cache is defined in w32.c.
11336 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11337 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11338
0898ca10
JB
113392011-05-04 Juanma Barranquero <lekktu@gmail.com>
11340
11341 Implement dynamic loading of GnuTLS on Windows.
11342
11343 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11344 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11345 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11346 Declare.
11347
11348 * gnutls.c (Qgnutls_dll): Define.
11349 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11350 (gnutls_*): Declare function pointers.
11351 (init_gnutls_functions): New function to initialize function pointers.
11352 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11353 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11354 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11355 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11356 (emacs_gnutls_write, emacs_gnutls_read)
11357 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11358 (Fgnutls_available_p): New function.
11359 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11360 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11361 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11362
11363 * image.c: Include w32.h.
11364 (Vimage_type_cache): Delete.
11365 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11366 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11367 (w32_delayed_load): Move to w32.c.
11368
11369 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11370
11371 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11372 (w32_delayed_load): Move from image.c. When loading a library, record
11373 its filename in the :loaded-from property of the library id.
11374 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11375 Initialize and staticpro them.
11376 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11377
11378 * process.c: Include lisp.h before w32.h, not after.
11379 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11380 instead of gnutls_record_check_pending.
11381
11382 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11383
ff4de4aa
TZ
113842011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11385
11386 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11387 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11388 as passed in.
11389
abe95abb
JD
113902011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11391
11392 * xterm.c (x_set_frame_alpha): Do not set property on anything
11393 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11394
e16e55d4
JB
113952011-05-02 Juanma Barranquero <lekktu@gmail.com>
11396
11397 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11398
bafcf6a5
JB
113992011-05-02 Juanma Barranquero <lekktu@gmail.com>
11400
11401 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11402 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11403 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11404 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11405 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11406 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11407 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11408 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11409 (Qgnutls_bootprop_callbacks_verify): Make static.
11410
e7a6747f
AS
114112011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11412
19ed11ba
AS
11413 * callproc.c: Indentation fixup.
11414
e7a6747f 11415 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11416 (wait_for_termination, interruptible_wait_for_termination):
11417 Move after wait_for_termination_1.
e7a6747f 11418
1ef14cb4
LMI
114192011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11420
11421 * sysdep.c (interruptible_wait_for_termination): New function
11422 which is like wait_for_termination, but allows keyboard
11423 interruptions.
11424
11425 * callproc.c (Fcall_process): Add (:file "file") as an option for
11426 the STDOUT buffer.
11427 (Fcall_process_region): Ditto.
11428
330d880c
EZ
114292011-04-30 Eli Zaretskii <eliz@gnu.org>
11430
8db90b73
EZ
11431 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11432 rather than `XVECTOR (FOO)->size'.
11433
330d880c
EZ
11434 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11435 inttypes.h, as a gnulib replacement is used if it not available in
11436 system headers.
11437
15cbd324
EZ
114382011-04-21 Eli Zaretskii <eliz@gnu.org>
11439
11440 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11441 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11442 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11443
11444 * coding.c (coding_alloc_by_realloc): Error out if destination
11445 will grow beyond MOST_POSITIVE_FIXNUM.
11446 (decode_coding_emacs_mule): Abort if there isn't enough place in
11447 charbuf for the composition carryover bytes. Reserve an extra
11448 space for up to 2 characters produced in a loop.
11449 (decode_coding_iso_2022): Abort if there isn't enough place in
11450 charbuf for the composition carryover bytes.
11451
114522011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11453
ae940cca
EZ
11454 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11455 aborting when %lld or %lll format is passed.
11456 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11457 %llo or %llx format is passed. (Bug#8545)
11458
03ab8921
EZ
11459 * window.c (window_scroll_line_based): Use a marker instead of
11460 simple variables to record original value of point. (Bug#7952)
11461
afda1437
EZ
11462 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11463 produced by %s or %c overflows available buffer space. (Bug#8545)
11464
f76dee0c
PE
114652011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11466
11467 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11468 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11469
fdc5744d
JB
114702011-04-28 Juanma Barranquero <lekktu@gmail.com>
11471
11472 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11473
638f053a
JB
114742011-04-28 Juanma Barranquero <lekktu@gmail.com>
11475
11476 * keyboard.c (Qdelayed_warnings_hook): Define.
11477 (command_loop_1): Run `delayed-warnings-hook'
11478 if Vdelayed_warnings_list is non-nil.
11479 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11480 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11481
d178f871
EZ
114822011-04-28 Eli Zaretskii <eliz@gnu.org>
11483
11484 * doprnt.c (doprnt): Don't return value smaller than the buffer
11485 size if the message was truncated. (Bug#8545).
11486
b124fd93
JB
114872011-04-28 Juanma Barranquero <lekktu@gmail.com>
11488
11489 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11490 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11491
e810457d
PE
114922011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11493
11494 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11495
ea51cceb
JB
114962011-04-27 Juanma Barranquero <lekktu@gmail.com>
11497
11498 * makefile.w32-in: Update dependencies.
11499
94dcfacf
EZ
115002011-04-27 Eli Zaretskii <eliz@gnu.org>
11501
11502 Improve `doprnt' and its usage. (Bug#8545)
11503 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11504 `format_end'. Remove support for %l as a conversion specifier.
11505 Don't use xrealloc. Improve diagnostics when the %l size modifier
11506 is used. Update the commentary.
11507
11508 * eval.c (verror): Simplify calculation of size_t.
11509
11510 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11511 messages.
11512
f61f41d7
PE
115132011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11514
11515 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11516 change.
11517
96fb4434
PE
115182011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11519
11520 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11521 This makes this file independent of the recent pseudovector change.
11522
671875da 115232011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11524
69e9b5a3
PE
11525 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11526
b5f869a7 11527 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11528 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11529 Remove unused local.
c8926152 11530 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11531
841a1577 11532 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11533 GCC 4.6.0 optimizes based on type-based alias analysis.
11534 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11535 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11536 != &v->size, and therefore "v->size = 1; b->size = 2; return
11537 v->size;" must therefore return 1. This assumption is incorrect
11538 for Emacs, since it type-puns struct Lisp_Vector * with many other
11539 types. To fix this problem, this patch adds a new type struct
f904488f 11540 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11541 and pseudovectors, and helps optimizing compilers not get fooled
11542 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11543 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11544 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11545 the size member.
eab3844f
PE
11546 (XSETPVECTYPE): Rewrite in terms of new macro.
11547 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11548 This is a bit clearer, and further avoids the possibility of
11549 undesirable aliasing.
11550 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11551 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11552 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11553 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11554 (ASIZE): Now uses header.size rather than size.
11555 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11556 to avoid the hassle of writing XVECTOR (foo)->header.size.
11557 (struct vectorlike_header): New type.
eab3844f
PE
11558 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11559 object, to help avoid aliasing.
11560 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11561 (SUBRP): Likewise, since Lisp_Subr is a special case.
11562 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11563 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11564 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11565 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11566 changed to be "header.size" and "header.next".
11567 * buffer.h (struct buffer): Likewise.
11568 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11569 * frame.h (struct frame): Likewise.
11570 * process.h (struct Lisp_Process): Likewise.
11571 * termhooks.h (struct terminal): Likewise.
11572 * window.c (struct save_window_data, struct saved_window): Likewise.
11573 * window.h (struct window): Likewise.
11574 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11575 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11576 * buffer.c (init_buffer_once): Likewise.
11577 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11578 special case.
11579 * process.c (Fformat_network_address): Use local var for size,
11580 for brevity.
11581
0df1eac5
PE
11582 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11583
847ab9d1 11584 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11585 * data.c (atof): Remove decl; no longer used or needed.
11586 (digit_to_number): Move to lread.c.
11587 (Fstring_to_number): Use new string_to_number function, to be
11588 consistent with how the Lisp reader treats infinities and NaNs.
11589 Do not assume that floating-point numbers represent EMACS_INT
11590 without losing information; this is not true on most 64-bit hosts.
11591 Avoid double-rounding errors, by insisting on integers when
11592 parsing non-base-10 numbers, as the documentation specifies.
11593 * lisp.h (string_to_number): New decl, replacing ...
11594 (isfloat_string): Remove.
bc0a5c13 11595 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11596 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11597 appears to have been a coding error. Similarly, do not accept
11598 strings like +-1e0 as floating point numbers. Do not report
11599 overflow for integer overflows unless the base is not 10 which
11600 means we have no simple and reliable way to continue.
11601 Break out the floating-point parsing into a new
11602 function string_to_number, so that Fstring_to_number parses
11603 floating point numbers consistently with the Lisp reader.
04f2d78b 11604 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11605 (E_CHAR, EXP_INT): Remove, replacing with ...
11606 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11607 (string_to_number): New function, replacing isfloat_string.
11608 This function checks for valid syntax and produces the resulting
11609 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11610 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11611 so that overflow for non-base-10 numbers is reported only when
11612 there's no portable and simple way to convert to floating point.
452f4150 11613
67769ffc
PE
11614 * textprop.c (set_text_properties_1): Rewrite for clarity,
11615 and to avoid GCC warning about integer overflow.
11616
c20db43f
PE
11617 * intervals.h (struct interval): Use EMACS_INT for members
11618 where EMACS_UINT might cause problems. See
11619 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11620 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11621 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11622 All uses changed.
37aa2f85
PE
11623 (offset_intervals): Tell GCC not to worry about length overflow
11624 when negating a negative length.
c20db43f 11625
2538aa2f
PE
11626 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11627 (overrun_check_free): Likewise.
11628
f2d3008d
PE
11629 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11630 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11631 word size.
11632
ec8df744
PE
11633 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11634 (gnutls_make_error): Rename local to avoid shadowing.
11635 (gnutls_emacs_global_deinit): ifdef out; not used.
11636 (Fgnutls_boot): Use const for pointer to readonly storage.
11637 Comment out unused local. Fix pointer signedness problems.
11638
640ee02d
PE
11639 * lread.c (openp): Don't stuff size_t into an 'int'.
11640 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11641 about possible signed overflow.
11642
6048fb2a
PE
11643 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11644 (GDK_KEY_g): Don't define if already defined.
11645 (xg_prepare_tooltip): Avoid pointer signedness problem.
11646 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11647
fa3c87e1
PE
11648 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11649 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11650
2172544b
PE
11651 * xfns.c (Fx_window_property): Simplify a bit,
11652 to make a bit faster and to avoid GCC 4.6.0 warning.
11653 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11654
9b821a21
PE
11655 * fns.c (internal_equal): Don't assume size_t fits in int.
11656
3c616cfa
PE
11657 * alloc.c (compact_small_strings): Tighten assertion a little.
11658
c2982e87
PE
11659 Replace pEd with more-general pI, and fix some printf arg casts.
11660 * lisp.h (pI): New macro, generalizing old pEd macro to other
11661 conversion specifiers. For example, use "...%"pI"d..." rather
11662 than "...%"pEd"...".
11663 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11664 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11665 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11666 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11667 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11668 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11669 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11670 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11671 64-bit hosts.
11672 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11673 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11674 * print.c (safe_debug_print, print_object): Likewise.
11675 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11676 to int.
6f04d126
PE
11677 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11678 avoiding the 0 flag, which is not portable.
c2982e87
PE
11679 * process.c (Fmake_network_process): Use pI to avoid cast.
11680 * region-cache.c (pp_cache): Likewise.
11681 * xdisp.c (decode_mode_spec): Likewise.
11682 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11683 behavior on 64-bit hosts with printf arg.
6f04d126 11684 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11685 (x_stop_queuing_selection_requests): Likewise.
11686 (x_get_window_property): Don't truncate byte count to an 'int'
11687 when tracing.
0b432f21 11688
5e073ec7
PE
11689 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11690 here, since it parses constructs like leading '-' and spaces,
11691 which are not wanted; and it overflows with large numbers.
11692 Instead, simply match F[0-9]+, which is what is wanted anyway.
11693
36372bf9
PE
11694 * alloc.c: Remove unportable assumptions about struct layout.
11695 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11696 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11697 (allocate_vectorlike, make_pure_vector): Use the new macros,
11698 plus offsetof, to remove unportable assumptions about struct layout.
11699 These assumptions hold on all porting targets that I know of, but
11700 they are not guaranteed, they're easy to remove, and removing them
11701 makes further changes easier.
11702
0b432f21
PE
11703 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11704 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11705 (string_overrun_cookie): Now const. Use initializers that
11706 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11707 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11708 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11709 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11710 multiple of sizeof (EMACS_INT); it need not be, if
11711 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11712 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11713
895009e1
JB
117142011-04-26 Juanma Barranquero <lekktu@gmail.com>
11715
11716 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11717
6a7a1b0b
TZ
117182011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11719
11720 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11721 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11722 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11723
841a1577 117242011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11725
11726 * lisp.h (Qdebug): List symbol.
895009e1 11727 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11728 * keyboard.c (debug-on-event): New variable.
11729 (handle_user_signal): Break into debugger when debug-on-event
11730 matches the current signal symbol.
11731
f2d3ba6f
DN
117322011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11733
11734 * alloc.c (check_sblock, check_string_bytes)
11735 (check_string_free_list): Convert to standard C.
11736
42ce4c63
TZ
117372011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11738
11739 * w32.c (emacs_gnutls_push): Fix typo.
11740
825cd63c
EZ
117412011-04-25 Eli Zaretskii <eliz@gnu.org>
11742
fb11d64d
EZ
11743 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11744 "cast to pointer from integer of different size".
11745
825cd63c
EZ
11746 Improve doprnt and its use in verror. (Bug#8545)
11747 * doprnt.c (doprnt): Document the set of format control sequences
11748 supported by the function. Use SAFE_ALLOCA instead of always
11749 using `alloca'.
11750
11751 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11752 is one byte too soon. Don't use xrealloc; instead xfree and
11753 xmalloc anew.
11754
e061a11b
TZ
117552011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11756
11757 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11758 callbacks stage.
11759
11760 * gnutls.c: Renamed global_initialized to
11761 gnutls_global_initialized. Added internals for the
11762 :verify-hostname-error, :verify-error, and :verify-flags
11763 parameters of `gnutls-boot' and documented those parameters in the
11764 docstring. Start callback support.
9173deec
JB
11765 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11766 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11767 on error. Return error code.
e061a11b
TZ
11768 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11769 (emacs_gnutls_read): Likewise.
11770 (Fgnutls_boot): Return handshake error code.
11771 (emacs_gnutls_handle_error): New function.
11772 (wsaerror_to_errno): Likewise.
11773
11774 * w32.h (emacs_gnutls_pull): Add prototype.
11775 (emacs_gnutls_push): Likewise.
11776
11777 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11778 (emacs_gnutls_push): Likewise.
11779
117802011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11781
11782 * process.c (wait_reading_process_output): Check if GnuTLS
11783 buffered some data internally if no FDs are set for TLS
11784 connections.
11785
11786 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11787 (LIBS): Link to USER_LIBS.
11788 ($(BLD)/gnutls.$(0)): New target.
11789
fa6996bc
EZ
117902011-04-24 Eli Zaretskii <eliz@gnu.org>
11791
eb35682e
EZ
11792 * xdisp.c (handle_single_display_spec): Rename the
11793 display_replaced_before_p argument into display_replaced_p, to
11794 make it consistent with the commentary. Fix typos in the
11795 commentary.
11796
e2ad650c
EZ
11797 * textprop.c (syms_of_textprop): Remove dead code.
11798 (copy_text_properties): Delete obsolete commentary about an
11799 interface that was deleted long ago. Fix typos in the description
11800 of arguments.
11801
1b2de274
EZ
11802 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11803 to changes in oldXMenu/XMenu.h from 2011-04-16.
11804 <menu_help_message, prev_menu_help_message>: Constify.
11805 (IT_menu_make_room): menu->help_text is now `const char **';
11806 adjust.
11807
11808 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11809 to changes in oldXMenu/XMenu.h from 2011-04-16.
11810 (struct XMenu): Declare `help_text' `const char **'.
11811
11812 * xfaces.c <Qunspecified>: Make extern again.
11813
11814 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11815 required by POSIX.
1b2de274 11816
762b15be
EZ
11817 * doc.c (get_doc_string): Improve the format passed to `error'.
11818
11819 * doprnt.c (doprnt): Improve commentary.
11820
11821 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11822
11823 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11824 them with etags.
11825
f1052e5d
EZ
11826 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11827 changes in globals.h immediately force recompilation.
762b15be
EZ
11828 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11829 $(CURDIR)/s/ms-w32.h.
11830 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11831
fa6996bc
EZ
11832 * character.c (Fchar_direction): Function deleted.
11833 (syms_of_character): Don't defsubr it.
11834 <char-direction-table>: Deleted.
11835
e6c3da20
EZ
118362011-04-23 Eli Zaretskii <eliz@gnu.org>
11837
11838 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11839 * doprnt.c: Include limits.h.
11840 (SIZE_MAX): New macro.
04f2d78b
CB
11841 (doprnt): Return a size_t value. 2nd arg is now size_t.
11842 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11843 Improve overflow protection. Support `l' modifier for integer
11844 conversions. Support %l conversion. Don't assume an EMACS_INT
11845 argument for integer conversions and for %c.
11846
11847 * lisp.h (doprnt): Restore prototype.
11848
11849 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11850 $(SRC)/character.h.
11851
11852 * Makefile.in (base_obj): Add back doprnt.o.
11853
11854 * deps.mk (doprnt.o): Add back prerequisites.
11855 (callint.o): Depend on character.h.
11856
11857 * eval.c (internal_lisp_condition_case): Include the handler
11858 representation in the error message.
11859 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11860 when breaking from the loop.
11861
11862 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11863
11864 * callint.c (Fcall_interactively): When displaying error message
11865 about invalid control letter, pass the character's codepoint, not
11866 a pointer to its multibyte form. Improve display of the character
11867 in octal and display also its hex code.
11868
11869 * character.c (char_string): Use %x to display the (unsigned)
11870 codepoint of an invalid character, to avoid displaying a bogus
11871 negative value.
11872
11873 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11874 `error', not SYMBOL_NAME itself.
11875
11876 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11877 character arguments to `error'.
11878
11879 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11880 to `error' in error message about FINAL_CHAR argument. Make sure
11881 FINAL_CHAR is a character, and use %c when it is passed as
11882 argument to `error'.
11883
4ffd0d6b 118842011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11885
11886 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11887
11888 * w32.c: Include <time.h>.
11889 (sys_localtime): New function.
11890
4ffd0d6b 118912011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11892
11893 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11894
4ffd0d6b 11895 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11896
4ffd0d6b 118972011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11898
4ffd0d6b
GM
11899 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11900 zombies (Bug#8467).
aac0c6e3 11901
04c56954
EZ
119022011-04-19 Eli Zaretskii <eliz@gnu.org>
11903
11904 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11905 gl_state.e_property when gl_state.object is Qt.
11906
11907 * insdel.c (make_gap_larger): Remove limitation of buffer size
11908 to <= INT_MAX.
11909
16a43933
CY
119102011-04-18 Chong Yidong <cyd@stupidchicken.com>
11911
11912 * xdisp.c (lookup_glyphless_char_display)
11913 (produce_glyphless_glyph): Handle cons cell entry in
11914 glyphless-char-display.
11915 (Vglyphless_char_display): Document it.
11916
11917 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11918 glyphless-char-display.
11919
4581706e
CY
119202011-04-17 Chong Yidong <cyd@stupidchicken.com>
11921
11922 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11923
11924 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11925
11926 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11927 definition for no-X builds.
11928
4887c6e2 119292011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11930
fd35b6f9
PE
11931 Static checks with GCC 4.6.0 and non-default toolkits.
11932
5c1ccb01
PE
11933 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11934
006c5daa
PE
11935 * process.c (keyboard_bit_set): Define only if SIGIO.
11936 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11937 (send_process): Repair possible setjmp clobbering.
11938
efc736d3
PE
11939 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11940
4e2fe2e6
PE
11941 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11942
f97334a2
PE
11943 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11944
4e75f29d
PE
11945 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11946 Define only if needed.
11947
90efadd1
PE
11948 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11949 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11950 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11951
3c647824
PE
11952 * dispextern.h (struct redisplay_interface): Rename param
11953 to avoid shadowing.
e264f262 11954 * termhooks.h (struct terminal): Likewise.
761383f4 11955 * xterm.c (xembed_send_message): Likewise.
3c647824 11956
b58c5c4a
PE
11957 * insdel.c (make_gap_smaller): Define only if
11958 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11959
cad59032
PE
11960 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11961 it.
11962
c339dc2e
PE
11963 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11964 so that we aren't warned about unused symbols.
11965
91a3e27b
PE
11966 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11967
399c71d3 11968 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11969
8ffc96f5
PE
11970 * xfns.c (x_real_positions): Mark locals as initialized.
11971
eef9bc79
PE
11972 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11973
098db9dd
PE
11974 * xterm.c: Fix problems found by static analysis with other toolkits.
11975 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11976 (x_dispatch_event): Declare static if USE_GTK, and
11977 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11978 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11979 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11980 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11981 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11982
eb18f6cc
PE
11983 * xmenu.c (menu_help_callback): Pointer type fixes.
11984 Use const pointers when pointing at readonly data. Avoid pointer
11985 signedness clashes.
11986 (FALSE): Remove unused macro.
11987 (update_frame_menubar): Remove unused decl.
11988
1fe72bf8
PE
11989 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11990
60d9e1db
PE
11991 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11992 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11993 (single_menu_item): Rename local to avoid shadowing.
11994
39261c26
PE
11995 * keyboard.c (make_lispy_event): Remove unused local var.
11996
018c5e19
PE
11997 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11998 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11999
63d2b86e
PE
12000 * bitmaps: Change bitmaps from unsigned char back to the X11
12001 compatible char. Avoid the old compiler warnings about
12002 out-of-range initializers by using, for example, '\xab' rather
12003 than 0xab.
12004
aefd87e1
PE
12005 * xgselect.c (xgselect_initialize): Check vs interface
12006 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12007
bf501fb9
PE
12008 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12009
e9829fdf
PE
12010 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12011 to read-only memory.
12012
1086c095
PE
12013 * fns.c (vector): Remove; this old hack is no longer needed.
12014
2baccd04 12015 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12016 Remove unused var.
dde42981 12017 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12018
72391843 12019 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12020
436c16df 12021 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12022 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12023 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12024
92bb796d 12025 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12026 (x_term_init): Remove local to avoid shadowing.
92bb796d 12027
764430a3 12028 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12029
12030 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12031 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12032
d1dfb56c
EZ
120332011-04-16 Eli Zaretskii <eliz@gnu.org>
12034
c4354cb4
EZ
12035 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12036
d1dfb56c
EZ
12037 Fix regex.c, syntax.c and friends for buffers > 2GB.
12038 * syntax.h (struct gl_state_s): Declare character position members
12039 EMACS_INT.
12040
12041 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12042
04f2d78b
CB
12043 * textprop.c (verify_interval_modification, interval_of):
12044 Declare arguments EMACS_INT.
d1dfb56c
EZ
12045
12046 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12047 EMACS_INT.
12048
12049 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12050
12051 * indent.c (Fvertical_motion): Local variable it_start is now
12052 EMACS_INT.
12053
12054 * regex.c (re_match, re_match_2, re_match_2_internal)
12055 (bcmp_translate, regcomp, regexec, print_double_string)
12056 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12057 (re_compile_pattern, re_exec): Declare arguments and local
12058 variables `size_t' and `ssize_t' and return values `regoff_t', as
12059 appropriate.
12060 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12061 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12062 <compile_stack_type>: `size' and `avail' are now `size_t'.
12063
12064 * regex.h <regoff_t>: Use ssize_t, not int.
12065 (re_search, re_search_2, re_match, re_match_2): Arguments that
12066 specify buffer/string position and length are now ssize_t and
12067 size_t. Return type is regoff_t.
12068
613052cd
BK
120692011-04-16 Ben Key <bkey76@gmail.com>
12070
12071 * nsfont.m: Fixed bugs in ns_get_family and
12072 ns_descriptor_to_entity that were caused by using free to
12073 deallocate memory blocks that were allocated by xmalloc (via
12074 xstrdup). This caused Emacs to crash when compiled with
12075 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12076 --enable-checking=xmallocoverrun). xfree is now used to
12077 deallocate these memory blocks.
12078
4170f62f 120792011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12080
71b41406
PE
12081 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12082
9587a89d
PE
12083 emacs_write: Accept and return EMACS_INT for sizes.
12084 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12085 et seq.
12086 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12087 Accept and return EMACS_INT.
12088 (emacs_gnutls_write): Return the number of bytes written on
12089 partial writes.
12090 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12091 (emacs_read, emacs_write): Remove check for negative size, as the
12092 Emacs source code has been audited now.
9587a89d
PE
12093 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12094 (emacs_read, emacs_write): Use it.
273a5f82
PE
12095 * process.c (send_process): Adjust to the new signatures of
12096 emacs_write and emacs_gnutls_write. Do not attempt to store
12097 a byte offset into an 'int'; it might overflow.
9587a89d 12098 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12099
3e047f51
PE
12100 * sound.c: Don't assume sizes fit in 'int'.
12101 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12102 Return EMACS_INT, not int.
3e047f51 12103 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12104 Accept EMACS_INT, not int.
12105 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12106 record read return values.
12107
cc39a9db
BK
121082011-04-15 Ben Key <bkey76@gmail.com>
12109
c9d0ec6d
JB
12110 * keyboard.c (Qundefined): Don't declare static since it is used
12111 in nsfns.m.
12112 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12113 static since they are used in nsfont.m.
cc39a9db 12114
6c60eb9f
SM
121152011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12116
12117 * process.c (Qprocessp): Don't declare static.
12118 * lisp.h (Qprocessp): Declare again.
12119
7990b61a
JB
121202011-04-15 Juanma Barranquero <lekktu@gmail.com>
12121
12122 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12123
5d4cb038
PE
121242011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12125
8bd7b830 12126 Improve C-level modularity by making more things 'static'.
cd64ea1d 12127
e3b27b31
PE
12128 Don't publish debugger-only interfaces to other modules.
12129 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12130 (verify_bytepos, count_markers): Move decls to the only modules
12131 that need them.
12132 * region-cache.h (pp_cache): Likewise.
12133 * window.h (check_all_windows): Likewise.
12134 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12135
5d4cb038
PE
12136 * sysdep.c (croak): Now static, if
12137 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12138 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12139
12140 * alloc.c (refill_memory_reserve): Now static if
12141 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12142 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12143
e87b6180
PE
12144 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12145 Define only if USE_LUCID.
12146
ac64929e
PE
12147 * xrdb.c (x_customization_string, x_rm_string): Now static.
12148
6f37259d
PE
12149 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12150 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12151
1683e3ab
PE
12152 * xdisp.c (draw_row_with_mouse_face): Now static.
12153 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12154
de9c2632
PE
12155 * window.h (check_all_windows): Mark externally visible.
12156
2b96acb7
PE
12157 * window.c (window_deletion_count): Now static.
12158
12159 * undo.c: Make symbols static if they're not exported.
12160 (last_undo_buffer, last_boundary_position, pending_boundary):
12161 Now static.
12162
50436f33
PE
12163 * textprop.c (interval_insert_behind_hooks): Now static.
12164 (interval_insert_in_front_hooks): Likewise.
12165
64520e5c
PE
12166 * term.c: Make symbols static if they're not exported.
12167 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12168 (max_frame_lines, tty_set_terminal_modes):
12169 (tty_reset_terminal_modes, tty_turn_off_highlight):
12170 (get_tty_terminal): Now static.
12171 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12172 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12173 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12174 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12175 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12176
1fa53021
PE
12177 * sysdep.c: Make symbols static if they're not exported.
12178 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12179 Now static.
12180 (sigprocmask_set, full_mask): Remove; unused.
12181 (wait_debugging): Mark as visible.
12182 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12183 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12184
d4b43b22
PE
12185 * syntax.c (syntax_temp): Define only if !__GNUC__.
12186
b7c513d0
PE
12187 * sound.c (current_sound_device, current_sound): Now static.
12188
989b29ad
PE
12189 * search.c (searchbufs, searchbuf_head): Now static.
12190
13a55a78
PE
12191 * scroll.c (scroll_cost): Remove; unused.
12192 * dispextern.h (scroll_cost): Remove decl.
12193
de68a1fc
PE
12194 * region-cache.h (pp_cache): Mark as externally visible.
12195
40ccffa6
PE
12196 * process.c: Make symbols static if they're not exported.
12197 (process_tick, update_tick, create_process, chan_process):
12198 (Vprocess_alist, proc_buffered_char, datagram_access):
12199 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12200 (deactivate_process): Mark defn as static, as well as decl.
12201 * lisp.h (create_process): Remove decl.
12202 * process.h (chan_process, Vprocess_alist): Remove decls.
12203
ad64fc97
PE
12204 * print.c: Make symbols static if they're not exported.
12205 (print_depth, new_backquote_output, being_printed, print_buffer):
12206 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12207 (print_interval, print_number_index, initial_stderr_stream):
12208 Now static.
12209 * lisp.h (Fprinc): Remove decl.
12210 (debug_output_compilation_hack): Mark as externally visible.
12211
adddb265
PE
12212 * sysdep.c (croak): Move decl from here to syssignal.h.
12213 * syssignal.h (croak): Put it here, so the API can be checked when
12214 'croak' is called from dissociate_if_controlling_tty.
12215
1717ede2
PE
12216 * minibuf.c: Make symbols static if they're not exported.
12217 (minibuf_save_list, choose_minibuf_frame): Now static.
12218 * lisp.h (choose_minibuf_frame): Remove decl.
12219
fa5fb2bc
PE
12220 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12221
1e3890d1
PE
12222 * lread.c: Make symbols static if they're not exported.
12223 (read_objects, initial_obarray, oblookup_last_bucket_number):
12224 Now static.
12225 (make_symbol): Remove; unused.
12226 * lisp.h (initial_obarray, make_symbol): Remove decls.
12227
8a1414fa
PE
12228 * keyboard.c: Make symbols static if they're not exported.
12229 (single_kboard, recent_keys_index, total_keys, recent_keys):
12230 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12231 (this_single_command_key_start, echoing, last_auto_save):
12232 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12233 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12234 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12235 (Vlispy_mouse_stem, double_click_count):
12236 Now static.
12237 (force_auto_save_soon): Define only if SIGDANGER.
12238 (ignore_mouse_drag_p): Now static if
12239 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12240 (print_help): Remove; unused.
12241 (stop_character, last_timer_event): Mark as externally visible.
12242 * keyboard.h (ignore_mouse_drag_p): Declare only if
12243 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12244 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12245 * lisp.h (echoing): Remove decl.
12246 (force_auto_save_soon): Declare only if SIGDANGER.
12247 * xdisp.c (redisplay_window): Simplify code, to make it more
12248 obvious that ignore_mouse_drag_p is not accessed if !defined
12249 USE_GTK && !defined HAVE_NS.
12250
93ea6e8f
PE
12251 * intervals.c: Make symbols static if they're not exported.
12252 (merge_properties_sticky, merge_interval_right, delete_interval):
12253 Now static.
12254 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12255
77382fcc
PE
12256 * insdel.c: Make symbols static if they're not exported.
12257 However, leave prepare_to_modify_buffer alone. It's never
12258 called from outside this function, but that appears to be a bug.
12259 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12260 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12261 (adjust_after_replace_noundo): Remove; unused.
12262 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12263 (signal_before_change): Remove decls.
77382fcc 12264
9306c32e
PE
12265 * indent.c (val_compute_motion, val_vmotion): Now static.
12266
cd44d2eb
PE
12267 * image.c: Make symbols static if they're not exported.
12268 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12269 if USE_GTK.
12270 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12271 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12272
ad9a7a06
PE
12273 * fringe.c (standard_bitmaps): Now static.
12274 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12275
81626931
PE
12276 * frame.c: Make symbols static if they're not exported.
12277 (x_report_frame_params, make_terminal_frame): Now static.
12278 (get_frame_param): Now static, unless HAVE_NS.
12279 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12280 (x_get_resource_string): Remove; not used.
12281 * frame.h (make_terminal_frame, x_report_frame_params):
12282 (x_get_resource_string); Remove decls.
12283 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12284 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12285
239f9db9
PE
12286 * font.c, fontset.c: Make symbols static if they're not exported.
12287 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12288 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12289 * font.c (font_close_object): Now static.
12290 * font.h (font_close_object): Remove.
12291 * fontset.c (FONTSET_OBJLIST): Remove.
12292 (free_realized_fontset) #if-0 the body, which does nothing.
12293 (face_suitable_for_char_p): #if-0, as it's never called.
12294 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12295 * xfaces.c (face_at_string_position):
12296 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12297 since 0 is always ASCII.
12298
dfcf3579
PE
12299 * fns.c (weak_hash_tables): Now static.
12300
5045092b
PE
12301 * fileio.c: Make symbols static if they're not exported.
12302 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12303 (Vwrite_region_annotation_buffers): Now static.
12304
57a96f5c
PE
12305 * eval.c: Make symbols static if they're not exported.
12306 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12307 * lisp.h (backtrace_list): Remove decl.
12308
35f08c38
PE
12309 * emacs.c: Make symbols static if they're not exported.
12310 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12311 (fatal_error_code, fatal_error_signal_hook, standard_args):
12312 Now static.
12313 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12314 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12315 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12316 * lisp.h (fatal_error_signal_hook): Remove decl.
12317 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12318
f44bd759
PE
12319 * editfns.c: Move a (normally-unused) function to its only use.
12320 * editfns.c, lisp.h (get_operating_system_release): Remove.
12321 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12322 worth the hassle of breaking this out.
12323
b532497d
PE
12324 * xterm.c: Make symbols static if they're not exported.
12325 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12326 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12327 (x_destroy_window, x_delete_display):
12328 Now static.
12329 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12330 (x_mouse_leave): Remove; unused.
12331 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12332 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12333 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12334 Remove decls.
12335 (x_mouse_leave): Declare only if WINDOWSNT.
12336 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12337 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12338 USE_X_TOOLKIT.
12339
1675728f
PE
12340 * ftxfont.c: Make symbols static if they're not exported.
12341 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12342 HAVE_FREETYPE.
12343 * font.h (ftxfont_driver): Likewise.
12344
e4cebfca
PE
12345 * xfns.c: Make symbols static if they're not exported.
12346 (x_last_font_name, x_display_info_for_name):
12347 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12348 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12349 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12350 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12351 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12352 (last_show_tip_args): Now static.
12353 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12354 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12355 (x_screen_planes): Remove; unused.
12356 * dispextern.h (x_screen_planes): Remove decl.
12357
5bf46f05
PE
12358 * dispnew.c: Make symbols static if they're not exported.
12359 * dispextern.h (redraw_garbaged_frames, scrolling):
12360 (increment_row_positions): Remove.
12361 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12362 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12363 Now static.
12364 (redraw_garbaged_frames): Remove; unused.
12365
435f4c28
PE
12366 * xfaces.c: Make symbols static if they're not exported.
12367 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12368 Remove decls.
12369 * xterm.h (defined_color): Remove decls.
12370 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12371 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12372 (menu_face_changed_default, defined_color, free_realized_face):
12373 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12374 (ascii_face_of_lisp_face): Remove; unused.
12375
8524aef3
PE
12376 * xdisp.c: Make symbols static if they're not exported.
12377 * dispextern.h (scratch_glyph_row, window_box_edges):
12378 (glyph_to_pixel_coords, set_cursor_from_row):
12379 (get_next_display_element, set_iterator_to_next):
12380 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12381 (show_mouse_face): Remove decls
12382 * frame.h (message_buf_print): Likewise.
12383 * lisp.h (pop_message, set_message, check_point_in_composition):
12384 Likewise.
12385 * xterm.h (set_vertical_scroll_bar): Likewise.
12386 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12387 (message_buf_print, scratch_glyph_row, displayed_buffer):
12388 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12389 (get_next_display_element, show_mouse_face, window_box_edges):
12390 (frame_to_window_pixel_xy, check_point_in_composition):
12391 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12392 (glyph_to_pixel_coords): Remove; unused.
12393
16390cd2
PE
12394 * dired.c (file_name_completion): Now static.
12395
12396 * dbusbind.c (xd_in_read_queued_messages): Now static.
12397
a25f4dfa
PE
12398 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12399 * data.c (circular_list_error): Remove.
12400
14a9c8df
PE
12401 * commands.h (last_point_position, last_point_position_buffer):
12402 (last_point_position_window): Remove decls.
12403 * keyboard.c: Make these variables static.
12404
04f2d78b
CB
12405 * coding.h (coding, code_convert_region, encode_coding_gap):
12406 Remove decls.
74ab6df5
PE
12407 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12408 (iso_code_class, detect_coding, code_convert_region): Now static.
12409 (encode_coding_gap): Remove; unused.
12410
38dfbee1
PE
12411 * chartab.c (chartab_chars, chartab_bits): Now static.
12412
a2cb4e63
PE
12413 * charset.h (charset_iso_8859_1): Remove decl.
12414 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12415 Now static.
12416
127198fd
PE
12417 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12418 * ccl.c (Vccl_program_table): Now static.
12419 (check_ccl_update): Remove; unused.
12420
d85b608f
PE
12421 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12422 * category.h: ... from here.
12423 * category.c (check_category_table, set_category_set): Now static.
12424
31cd66f3
PE
12425 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12426 * lisp.h: Remove these decls.
12427
c358e587
PE
12428 * buffer.c (buffer_count): Remove unused var.
12429
e78aecca
PE
12430 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12431 so that it's not optimized away.
12432 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12433 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12434 exported only to the debugger.
12435
e192d7d3 12436 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12437 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12438
92470028
PE
12439 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12440 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12441 was inaccessible from Lisp.
12442 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12443 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12444
244ed907
PE
12445 alloc.c: Import and export fewer symbols, and remove unused items.
12446 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12447 is defined.
12448 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12449 it's not optimized away by whole-program optimization.
12450 (message_enable_multibyte, free_misc): Remove.
12451 (catchlist, handlerlist, mark_backtrace):
12452 Declare only if BYTE_MARK_STACK.
12453 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12454 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12455 (message_enable_multibyte): Remove decl.
12456 (free_misc, interval_free_list, float_block, float_block_index):
12457 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12458 (cons_free_list, last_marked_index):
12459 Now static.
12460 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12461 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12462 (mark_backtrace): Define only if BYTE_MARK_STACK.
12463 * xdisp.c (message_enable_multibyte): Now static.
12464
61c2b50e 12465 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12466 This makes it easier for human readers (and static analyzers)
12467 to see whether these variables are used from other modules.
12468 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12469 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12470 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12471 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12472 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12473 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12474 * xmenu.c, xselect.c:
12475 Declare Q* vars static if they are not used in other modules.
12476 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12477 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12478 Remove decls of unexported vars.
12479 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12480
95c82688
PE
12481 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12482
16a97296
PE
12483 Make Emacs functions such as Fatom 'static' by default.
12484 This makes it easier for human readers (and static analyzers)
12485 to see whether these functions can be called from other modules.
12486 DEFUN now defines a static function. To make the function external
12487 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12488 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12489 (Finit_image_library):
16a97296
PE
12490 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12491 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12492 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12493 Remove decls, since these functions are now static.
12494 (Funintern, Fget_internal_run_time): New decls, since these functions
12495 were already external.
95c82688 12496
16a97296
PE
12497 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12498 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12499 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12500 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12501 * keyboard.c, keymap.c, lread.c:
12502 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12503 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12504 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12505 Mark functions with DEFUE instead of DEFUN,
12506 if they are used in other modules.
12507 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12508 decls for now-static functions.
12509 * buffer.h (Fdelete_overlay): Remove decl.
12510 * callproc.c (Fgetenv_internal): Mark as internal.
12511 * composite.c (Fremove_list_of_text_properties): Remove decl.
12512 (Fcomposition_get_gstring): New forward static decl.
12513 * composite.h (Fcomposite_get_gstring): Remove decl.
12514 * dired.c (Ffile_attributes): New forward static decl.
12515 * doc.c (Fdocumntation_property): New forward static decl.
12516 * eval.c (Ffetch_bytecode): New forward static decl.
12517 (Funintern): Remove extern decl; now in .h file where it belongs.
12518 * fileio.c (Fmake_symbolic_link): New forward static decl.
12519 * image.c (Finit_image_library): New forward static decl.
12520 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12521 * intervals.h (Fprevious_property_change):
12522 (Fremove_list_of_text_properties): Remove decls.
12523 * keyboard.c (Fthis_command_keys): Remove decl.
12524 (Fcommand_execute): New forward static decl.
12525 * keymap.c (Flookup_key): New forward static decl.
12526 (Fcopy_keymap): Now static.
12527 * keymap.h (Flookup_key): Remove decl.
12528 * process.c (Fget_process): New forward static decl.
12529 (Fprocess_datagram_address): Mark as internal.
12530 * syntax.c (Fsyntax_table_p): New forward static decl.
12531 (skip_chars): Remove duplicate decl.
12532 * textprop.c (Fprevious_property_change): New forward static decl.
12533 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12534 Now internal.
12535 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12536 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12537
785bbd42
PE
12538 * editfns.c (Fformat): Remove unreachable code.
12539
8b913b57
AS
125402011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12541
12542 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12543 change. (Bug#8496)
12544
a6744a35
EZ
125452011-04-13 Eli Zaretskii <eliz@gnu.org>
12546
12547 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12548 when at ZV. (Bug#8487)
12549
e7974947
AS
125502011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12551
baad03f0
AS
12552 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12553 (Bug#8437)
12554 * keyboard.c (parse_tool_bar_item): Likewise.
12555 * sound.c (sound_cleanup, alsa_close): Likewise.
12556 * termcap.c (tgetent): Likewise.
12557 * xfns.c (x_default_font_parameter): Likewise.
12558 * xsettings.c (read_and_apply_settings): Likewise.
12559
e7974947
AS
12560 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12561 (overrun_check_free): Protoize.
12562
28272684
PE
125632011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12564
12565 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12566 since callers should never pass a negative size.
12567 Change the signature to match that of plain 'read' and 'write'; see
12568 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12569 * lisp.h: Update prototypes of emacs_write and emacs_read.
12570
11997c76
EZ
125712011-04-11 Eli Zaretskii <eliz@gnu.org>
12572
12573 * xdisp.c (redisplay_window): Don't try to determine the character
12574 position of the scroll margin if the window start point w->startp
e896f03c 12575 is outside the buffer's accessible region. (Bug#8468)
11997c76 12576
8a2cbd72
EZ
125772011-04-10 Eli Zaretskii <eliz@gnu.org>
12578
12579 Fix write-region and its subroutines for buffers > 2GB.
12580 * fileio.c (a_write, e_write): Modify declaration of arguments and
12581 local variables to support buffers larger than 2GB.
12582 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12583
12584 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12585 argument, local variables, and return value.
12586
12587 * lisp.h: Update prototypes of emacs_write and emacs_read.
12588
12589 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12590
4073e537 125912011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12592
1ebfdcb6
PE
12593 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12594
b2ded58d
PE
12595 Fix more problems found by GCC 4.6.0's static checks.
12596
7d66342c
PE
12597 * xdisp.c (vmessage): Use a better test for character truncation.
12598
bbf47d44
PE
12599 * charset.c (load_charset_map): <, not <=, for optimization,
12600 and to avoid potential problems with integer overflow.
9248994d 12601 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12602 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12603 * editfns.c (Fformat): Likewise.
1e69125e 12604 * syntax.c (skip_chars): Likewise.
3befa583 12605
e3019616
PE
12606 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12607 This also lets GCC 4.6.0 generate slightly better loop code.
12608
becfa255
PE
12609 * callint.c (Fcall_interactively): <, not <=, for optimization.
12610 (Fcall_interactively): Count the number of arguments produced,
12611 not the number of arguments given. This is simpler and lets GCC
12612 4.6.0 generate slightly better code.
12613
dae0cd48
PE
12614 * ftfont.c: Distingish more carefully between FcChar8 and char.
12615 The previous code passed unsigned char * to a functions like
12616 strlen and xstrcasecmp that expect char *, which does not
12617 conform to the C standard.
12618 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12619 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12620 char * when the C standard requires it.
12621
76032d70
PE
12622 * keyboard.c (read_char): Remove unused var.
12623
eb3f1cc8
PE
12624 * eval.c: Port to Windows vsnprintf (Bug#8435).
12625 Include <limits.h>.
12626 (SIZE_MAX): Define if the headers do not.
12627 (verror): Do not give up if vsnprintf returns a negative count.
12628 Instead, grow the buffer. This ports to Windows vsnprintf, which
12629 does not conform to C99. Problem reported by Eli Zaretskii.
12630 Also, simplify the allocation scheme, by avoiding the need for
12631 calling realloc, and removing the ALLOCATED variable.
12632
70476b54
PE
12633 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12634
12020a9e
PE
12635 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12636 But keep the doprint source code for now, as we might revamp it
12637 and use it again (Bug#8435).
ea6c7ae6
PE
12638 * lisp.h (doprnt): Remove.
12639 * Makefile.in (base_obj): Remove doprnt.o.
12640 * deps.mk (doprnt.o): Remove.
12641
5fdb398c
PE
12642 error: Print 32- and 64-bit integers portably (Bug#8435).
12643 Without this change, on typical 64-bit hosts error ("...%d...", N)
12644 was used to print both 32- and 64-bit integers N, which relied on
12645 undefined behavior.
61bdb816 12646 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12647 * lisp.h (error, verror): Mark as printf-like functions.
12648 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12649 Report overflow in size calculations when allocating printf buffer.
12650 Do not truncate output string at its first null byte.
12651 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12652 Truncate the output at a character boundary, since vsnprintf does not
12653 do that.
12654 * charset.c (check_iso_charset_parameter): Convert internal
12655 character to string before calling 'error', since %c now has the
12656 printf meaning.
12657 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12658 overflow when computing char to be passed to 'error'. Do not
12659 pass Lisp_Object to 'error'; pass the integer instead.
12660 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12661 formatted with plain %d.
12662
b189fa66
PE
12663 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12664
bff87ef0
PE
12665 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12666
7e2cac20
PE
12667 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12668
ce4d90b5
PE
12669 * xterm.c (x_catch_errors): Remove duplicate declaration.
12670
266c9547
PE
12671 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12672
79c49ad2
PE
12673 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12674
368f4090
JM
126752011-04-10 Jim Meyering <meyering@redhat.com>
12676
12677 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12678 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12679 return ssize_t not "int", and use size_t as the buffer length.
12680 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12681 * gnutls.h: Update declarations.
12682 * process.c (read_process_output): Use ssize_t, to match.
12683 (send_process): Likewise.
12684
a32d4040
CY
126852011-04-09 Chong Yidong <cyd@stupidchicken.com>
12686
12687 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12688
8546720e 126892011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12690
04f2d78b
CB
12691 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12692 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12693
8546720e
GM
12694 * xterm.c (handle_one_xevent):
12695 * xmenu.c (create_and_show_popup_menu):
12696 * xselect.c (x_decline_selection_request)
12697 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12698
0a2f5c1a 126992011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12700
12701 Fix some uses of `int' instead of EMACS_INT.
12702 * search.c (string_match_1, fast_string_match)
12703 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12704 (scan_buffer, find_next_newline_no_quit)
12705 (find_before_next_newline, search_command, Freplace_match)
12706 (Fmatch_data): Make some `int' variables be EMACS_INT.
12707
12708 * xdisp.c (display_count_lines): 3rd argument and return value now
12709 EMACS_INT. All callers changed.
12710 (pint2hrstr): Last argument is now EMACS_INT.
12711
12712 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12713 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12714 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12715 (decode_coding_utf_16, decode_coding_emacs_mule)
12716 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12717 (decode_coding_ccl, decode_coding_charset)
12718 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12719 (decode_coding_iso_2022, decode_coding_emacs_mule)
12720 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12721 <char_offset, last_offset>: Declare EMACS_INT.
12722 (encode_coding_utf_8, encode_coding_utf_16)
12723 (encode_coding_emacs_mule, encode_invocation_designation)
12724 (encode_designation_at_bol, encode_coding_iso_2022)
12725 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12726 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12727 Declare EMACS_INT.
12728 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12729 (encode_invocation_designation): Last argument P_NCHARS is now
12730 EMACS_INT.
12731 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12732 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12733
12734 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12735 All users changed.
12736
12737 * ccl.c (Fccl_execute_on_string): Declare some variables
12738 EMACS_INT.
12739
8546720e 127402011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12741
12742 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12743
4e19a977
CS
127442011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12745
12746 * process.c (Fformat_network_address): Doc fix.
12747
87302331
R
127482011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12749
ee7683eb 12750 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12751
cbb59342
CY
127522011-04-08 Chong Yidong <cyd@stupidchicken.com>
12753
12754 * keyboard.c (read_char): Call Lisp function help-form-show,
12755 instead of using internal_with_output_to_temp_buffer.
12756 (Qhelp_form_show): New var.
e0d38eeb 12757 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12758
12759 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12760
12761 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12762
e67a13ab
CY
127632011-04-06 Chong Yidong <cyd@stupidchicken.com>
12764
04f2d78b
CB
12765 * process.c (Flist_processes): Remove to Lisp.
12766 (list_processes_1): Delete.
e67a13ab 12767
973f782d
EZ
127682011-04-06 Eli Zaretskii <eliz@gnu.org>
12769
7c106b1e
EZ
12770 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12771
973f782d
EZ
12772 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12773
41cf7d1a 127742011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12775
ca23cc88
PE
12776 Fix more problems found by GCC 4.6.0's static checks.
12777
f390e2d5
PE
12778 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12779
42eea0d0
PE
12780 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12781
b69769da 12782 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12783
f9541e84
PE
12784 * xdisp.c (vmessage): Mark as a printf-like function.
12785
13841b55
PE
12786 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12787
c136c10f
PE
12788 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12789
5e2d4a30
PE
12790 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12791 printf-like functions.
12792 (tiff_load): Add casts to remove these marks before passing them
12793 to system-supplied API.
12794
583f48b9
PE
12795 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12796
b25d760e
PE
12797 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12798 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12799 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12800 directly, rather than having caller test rule sign. This avoids
12801 some unnecessary tests.
12802 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12803 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12804 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12805
bc7b6697 12806 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12807 (xfont_open): Avoid unnecessary tests.
bc7b6697 12808
27ccc379
PE
12809 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12810
dcd5c89a
PE
12811 * composite.h, composite.c (composition_gstring_put_cache):
12812 Use EMACS_INT, not int, for length.
12813
b13a45c6
PE
12814 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12815 breaking out part of COMPOSITION_DECODE_RULE.
12816 (COMPOSITION_DECODE_RULE): Use it.
12817 * composite.c (get_composition_id): Remove unused local vars,
12818 by using the new macro.
12819
1e792e4d
PE
12820 * textprop.c (set_text_properties_1): Change while to do-while,
12821 since the condition is always true at first.
12822
dc6c6455 12823 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12824 (interval_deletion_adjustment): Return unsigned value.
12825 All uses changed.
dc6c6455 12826
aba7731a
PE
12827 * process.c (list_processes_1, create_pty, read_process_output):
12828 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12829 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12830 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12831 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12832 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12833
fdfc4bf3
PE
12834 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12835
fca8fe46 12836 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12837 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12838
06a0259a 12839 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12840 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12841 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12842
e7b9e80f
PE
12843 * print.c (print_error_message): Avoid int overflow.
12844
56201685
PE
12845 * font.c (font_list_entities): Redo for clarity,
12846 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12847
78834453 12848 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12849 (font_score): Avoid potential overflow in diff calculation.
78834453 12850
0bc0b309 12851 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12852 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12853
e610eaca
PE
12854 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12855
b895abce
PE
12856 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12857 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12858 can always succeed if overflow has undefined behavior.
12859
1f1d9321 12860 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12861 (wordify): Omit three unnecessary tests.
1f1d9321 12862
c59478bc
PE
12863 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12864 All callers changed. This avoids the need for an unused var.
12865
79b73827
PE
12866 * casefiddle.c (casify_region): Remove var that is set but not used.
12867
a4db5dfe
PE
12868 * dired.c (file_name_completion): Remove var that is set but not used.
12869
43aae36e
PE
12870 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12871
2a47c44d 12872 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12873 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12874
a37c69bf
PE
12875 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12876 Check for integer overflow on size calculations.
12877
328ab8e7
PE
12878 * buffer.c (Fprevious_overlay_change): Remove var that is set
12879 but not used.
12880
e5a2a5cb
PE
12881 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12882 Remove vars that are set but not used.
8d84a6eb 12883 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12884 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12885
a60e5f68
PE
12886 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12887
f661cb61 12888 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12889 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12890
f0397f5a
PE
12891 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12892 that are set but not used.
12893
8664db06 12894 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12895 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12896
6abdaa4a
PE
12897 * xselect.c (x_get_local_selection, x_handle_property_notify):
12898 Remove vars that are set but not used.
12899
0ce7538d 12900 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12901 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12902
9ae848fc
PE
12903 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12904 Remove var that is set but not used.
0b918413
PE
12905 (scroll_bar_windows_size): Now size_t, not int.
12906 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12907 Check for overflow.
9ae848fc 12908
a5a62657
PE
12909 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12910 (map_tty_color) [!defined MSDOS]: Likewise.
12911
5c5cdd39
PE
12912 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12913
66ebf983
PE
12914 * coding.c: Remove vars that are set but not used.
12915 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12916 All callers changed.
12917 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12918 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12919 (decode_coding_charset): Remove vars that are set but not used.
12920
1be4d761
PE
12921 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12922 that is set but not used.
12923
47553fa8
PE
12924 * print.c (print_object): Remove var that is set but not used.
12925
1f7196bf 12926 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12927 The gnulib version avoids calling malloc in the usual case,
12928 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12929 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12930 * filelock.c (current_lock_owner): Likewise.
12931 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12932 * sysdep.c: Include allocator.h, careadlinkat.h.
12933 (emacs_no_realloc_allocator): New static constant.
12934 (emacs_readlink): New function.
fdb61804
PE
12935 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12936 ../lib/careadlinkat.h.
d1fdcab7 12937
f84c17c7
SM
129382011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12939
12940 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12941 first non-nil return value).
12942
ef3862ad
JD
129432011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12944
12945 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12946 if not defined (Bug#8403).
12947
376a7006
JB
129482011-04-02 Juanma Barranquero <lekktu@gmail.com>
12949
12950 * xdisp.c (display_count_lines): Remove parameter `start',
12951 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12952 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12953 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12954 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12955 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12956 and thereabouts. All callers changed.
12957 (get_per_char_metric): Remove parameter `f', unused since
12958 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12959
6ca3801d
JM
129602011-04-02 Jim Meyering <meyering@redhat.com>
12961
12962 do not dereference NULL upon failed strdup
12963 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12964 (ns_get_family): Likewise.
12965
d8e2b5ba
JB
129662011-04-02 Juanma Barranquero <lekktu@gmail.com>
12967
12968 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12969
8c74fcbd
JD
129702011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12971
12972 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12973 later (Bug#8403).
12974
7200d79c
SM
129752011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12976
03408648 12977 Add lexical binding.
7200d79c 12978
03408648
SM
12979 * window.c (Ftemp_output_buffer_show): New fun.
12980 (Fsave_window_excursion):
12981 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12982
12983 * lread.c (lisp_file_lexically_bound_p): New function.
12984 (Fload): Bind Qlexical_binding.
12985 (readevalloop): Remove `evalfun' arg.
12986 Bind Qinternal_interpreter_environment.
12987 (Feval_buffer): Bind Qlexical_binding.
12988 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12989 Mark as dynamic.
12990 (syms_of_lread): Declare `lexical-binding'.
12991
12992 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12993
12994 * keyboard.c (eval_dyn): New fun.
12995 (menu_item_eval_property): Use it.
ca105506
SM
12996
12997 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12998
03408648
SM
12999 * fns.c (concat, mapcar1): Accept byte-code-functions.
13000
13001 * eval.c (Fsetq): Handle lexical vars.
13002 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13003 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13004 (FletX, Flet): Obey lexical binding.
13005 (Fcommandp): Handle closures.
13006 (Feval): New `lexical' arg.
13007 (eval_sub): New function extracted from Feval. Use it almost
13008 everywhere where Feval was used. Look up vars in lexical env.
13009 Handle closures.
13010 (Ffunctionp): Move from subr.el.
13011 (Ffuncall): Handle closures.
13012 (apply_lambda): Remove `eval_flags'.
13013 (funcall_lambda): Handle closures and new byte-code-functions.
13014 (Fspecial_variable_p): New function.
13015 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13016 but without exporting it to Lisp.
23aba0ea 13017
23aba0ea 13018 * doc.c (Fdocumentation, store_function_docstring):
03408648 13019 * data.c (Finteractive_form): Handle closures.
23aba0ea 13020
03408648
SM
13021 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13022 interactive spec.
ba83908c 13023
04f2d78b
CB
13024 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13025 New byte-codes.
03408648
SM
13026 (exec_byte_code): New function extracted from Fbyte_code to handle new
13027 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13028
03408648 13029 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13030
03408648 13031 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13032
e2abce01
JB
130332011-03-31 Juanma Barranquero <lekktu@gmail.com>
13034
13035 * xdisp.c (redisplay_internal): Fix prototype.
13036
63696a73 130372011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13038
63696a73 13039 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13040 (try_scrolling): Use it when setting scroll_limit.
13041 Limit scrolling to 100 screen lines.
63696a73
EZ
13042 (redisplay_window): Even when falling back on "recentering",
13043 position point in the window according to scroll-conservatively,
13044 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13045
13046 (try_scrolling): When point is above the window, allow searching
13047 as far as scroll_max, or one screenful, to compute vertical
13048 distance from PT to the scroll margin position. This prevents
13049 try_scrolling from unnecessarily failing when
13050 scroll-conservatively is set to a value slightly larger than the
13051 window height. Clean up the case of PT below the margin at bottom
13052 of window: scroll_max can no longer be INT_MAX. When aggressive
13053 scrolling is in use, don't let point enter the opposite scroll
13054 margin as result of the scroll.
13055 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13056 threshold of 100 lines for never-recentering scrolling.
13057
e4cc2dfc
JB
130582011-03-31 Juanma Barranquero <lekktu@gmail.com>
13059
13060 * dispextern.h (move_it_by_lines):
13061 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13062 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13063 (message_log_check_duplicate): Remove parameters `prev_bol' and
13064 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13065 (redisplay_internal): Remove parameter `preserve_echo_area',
13066 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13067
13068 * indent.c (Fvertical_motion):
13069 * window.c (window_scroll_pixel_based, Frecenter):
13070 Don't pass `need_y_p' to `move_it_by_lines'.
13071
1c470562
SM
130722011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13073
44f230aa
SM
13074 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13075 steal a few bits to be more compact.
13076 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13077 Remove unneeded casts.
13078
1c470562
SM
13079 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13080
888adce9
ZK
130812011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13082
13083 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13084 binding" message (bug#7967).
13085
f838ed7b
PE
130862011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13087
77861b95
PE
13088 Fix more problems found by GCC 4.6.0's static checks.
13089
de6dbc14
PE
13090 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13091 Remove unused local var.
13092
f838ed7b
PE
13093 * editfns.c (Fmessage_box): Remove unused local var.
13094
792c7b2b
PE
13095 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13096 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13097 Omit unused local vars.
c499e557 13098 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13099 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13100 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13101 Omit unused local var.
13102
ba0165e1
PE
13103 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13104 Don't assume string length fits in int.
32ad8845 13105 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13106 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13107
3c59b4c9
PE
13108 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13109 instead of alloca (Bug#8344).
13110
a3eed478 13111 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13112 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13113
eb4d412d
PE
13114 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13115
1658b401
PE
13116 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13117 concerns.
13118
13119 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13120
13121 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13122
9a2c6e05
PE
13123 * keyboard.c (syms_of_keyboard): Use the same style as later
13124 in this function when indexing through an array. This also
13125 works around GCC bug 48267.
13126
03d0a109
PE
13127 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13128
44f730c8
PE
13129 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13130
fe75f926
PE
13131 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13132 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13133
ffa8c828
PE
13134 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13135 This avoids undefined behavior on integer overflow, and is a bit
13136 more convenient anyway since it is compared to a size_t variable.
13137
c5101a77
PE
13138 Variadic C functions now count arguments with size_t, not int.
13139 This avoids an unnecessary limitation on 64-bit machines, which
13140 caused (substring ...) to crash on large vectors (Bug#8344).
13141 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13142 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13143 All variadic functions and their callers changed accordingly.
c5101a77
PE
13144 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13145 * data.c (arith_driver, float_arith_driver): Likewise.
13146 * editfns.c (general_insert_function): Likewise.
13147 * eval.c (struct backtrace.nargs, interactive_p)
13148 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13149 (funcall_lambda, mark_backtrace): Likewise.
13150 * fns.c (concat): Likewise.
13151 * frame.c (x_set_frame_parameters): Likewise.
13152 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13153 0 if not found, not -1. All callers changed.
13154
dd3f25f7
PE
13155 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13156 (stack_copy_size): Now size_t, not int.
13157 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13158
461c2ab9
JB
131592011-03-28 Juanma Barranquero <lekktu@gmail.com>
13160
13161 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13162 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13163 All callers changed.
13164
13165 * lisp.h (multibyte_char_to_unibyte):
13166 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13167 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13168 * character.h (CHAR_TO_BYTE8):
13169 * cmds.c (internal_self_insert):
13170 * editfns.c (general_insert_function):
13171 * keymap.c (push_key_description):
13172 * search.c (Freplace_match):
13173 * xdisp.c (message_dolog, set_message_1): All callers changed.
13174
f6d62986
SM
131752011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13176
13177 * keyboard.c (safe_run_hook_funcall): New function.
13178 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13179 don't set the hook to nil, but remove the offending function instead.
13180 (Qcommand_hook_internal): Remove, unused.
13181 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13182 Vcommand_hook_internal.
13183
13184 * eval.c (enum run_hooks_condition): Remove.
13185 (funcall_nil, funcall_not): New functions.
13186 (run_hook_with_args): Call each function through a `funcall' argument.
13187 Remove `cond' argument, now redundant.
13188 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13189 (Frun_hook_with_args_until_failure): Adjust accordingly.
13190 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13191
1db5b1ad
JB
131922011-03-28 Juanma Barranquero <lekktu@gmail.com>
13193
13194 * dispextern.h (string_buffer_position): Remove declaration.
13195
13196 * print.c (strout): Remove parameter `multibyte', unused since
13197 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13198
13199 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13200 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13201 All callers changed.
13202
13203 * w32.c (_wsa_errlist): Use braces for struct initializers.
13204
13205 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13206 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13207 All callers changed.
13208 (string_buffer_position): Likewise. Also, make static (it's never
13209 used outside xdisp.c).
13210 (cursor_row_p): Remove parameter `w', unused since
13211 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13212 (decode_mode_spec): Remove parameter `precision', introduced during
13213 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13214 All callers changed.
13215
5ffb62aa
JD
132162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13217
13218 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13219
461c2ab9 132202011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13221
13222 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13223 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13224 (ns_update_auto_hide_menu_bar): New functions.
13225 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13226 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13227 ns_constrain_all_frames.
13228 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13229 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13230
5c380ffb
JD
132312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13232
13233 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13234
9af30bdf
GM
132352011-03-27 Glenn Morris <rgm@gnu.org>
13236
13237 * syssignal.h: Replace RETSIGTYPE with void.
13238 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13239 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13240 Replace SIGTYPE with void everywhere.
13241 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13242 * s/template.h (SIGTYPE): Remove commented out definition.
13243
e2abce01
JB
132442011-03-26 Eli Zaretskii <eliz@gnu.org>
13245
13246 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13247 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13248
f868cd8a
JB
132492011-03-26 Juanma Barranquero <lekktu@gmail.com>
13250
59eb0929
JB
13251 * w32.c (read_unc_volume): Use parameter `henum', instead of
13252 global variable `wget_enum_handle'.
13253
13254 * keymap.c (describe_vector): Remove parameters `indices' and
13255 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13256 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13257
f868cd8a
JB
13258 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13259
13260 * keyboard.c (timer_check): Remove parameter `do_it_now',
13261 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13262 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13263 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13264
13265 * keyboard.c (read_char):
13266 * w32menu.c (w32_menu_display_help):
13267 * xmenu.c (show_help_event, menu_help_callback):
13268 Adjust calls to `show_help_echo'.
13269
13270 * gtkutil.c (xg_maybe_add_timer):
13271 * keyboard.c (readable_events):
13272 * process.c (wait_reading_process_output):
13273 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13274
13275 * insdel.c (adjust_markers_gap_motion):
13276 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13277 (gap_left, gap_right): Don't call it.
13278
2ecf6fdb
CY
132792011-03-25 Chong Yidong <cyd@stupidchicken.com>
13280
13281 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13282 incurred during fontification.
13283
6b1f9ba4
JB
132842011-03-25 Juanma Barranquero <lekktu@gmail.com>
13285
13286 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13287 (DEFVAR_PER_BUFFER): Don't pass it.
13288
13289 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13290 (scrolling_window): Don't pass it.
13291
0f4a96b5
JB
132922011-03-25 Juanma Barranquero <lekktu@gmail.com>
13293
13294 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13295
13296 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13297 and `suffix'.
13298 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13299 of variables specific to SELinux and computation of `encoded_absname'.
13300
13301 * image.c (XPutPixel): Remove unused variable `height'.
13302
13303 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13304
13305 * unexw32.c (get_section_info): Remove unused variable `section'.
13306
13307 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13308 (system_process_attributes): Remove unused variable `sess'.
13309 (sys_read): Remove unused variable `err'.
13310
13311 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13312 (w32_wnd_proc): Remove unused variable `isdead'.
13313 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13314 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13315 (x_create_tip_frame): Remove unused variable `tem'.
13316
13317 * w32inevt.c (w32_console_read_socket):
13318 Remove unused variable `no_events'.
13319
13320 * w32term.c (x_draw_composite_glyph_string_foreground):
13321 Remove unused variable `width'.
13322
1149507c
JB
133232011-03-24 Juanma Barranquero <lekktu@gmail.com>
13324
13325 * w32term.c (x_set_glyph_string_clipping):
13326 Don't pass uninitialized region to CombineRgn.
13327
9c88f339
JB
133282011-03-23 Juanma Barranquero <lekktu@gmail.com>
13329
13330 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13331 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13332 (Fx_close_connection): Remove unused variable `i'.
13333
13334 * w32font.c (w32font_draw): Return number of glyphs.
13335 (w32font_open_internal): Remove unused variable `i'.
13336 (w32font_driver): Add missing initializer.
13337
13338 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13339 (fill_in_menu): Remove unused variable `items_added'.
13340
13341 * w32term.c (last_mouse_press_frame): Remove static global variable.
13342 (w32_clip_to_row): Remove unused variable `f'.
13343 (x_delete_terminal): Remove unused variable `i'.
13344
13345 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13346 (NOTHING): Remove unused static global variable.
13347 (uniscribe_check_otf): Remove unused variable `table'.
13348 (uniscribe_font_driver): Add missing initializers.
13349
dee091a3
JD
133502011-03-23 Julien Danjou <julien@danjou.info>
13351
13352 * term.c (Fsuspend_tty, Fresume_tty):
13353 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13354 * window.c (temp_output_buffer_show):
13355 * insdel.c (signal_before_change):
13356 * frame.c (Fhandle_switch_frame):
13357 * fileio.c (Fdo_auto_save):
13358 * emacs.c (Fkill_emacs):
13359 * editfns.c (save_excursion_restore):
13360 * cmds.c (internal_self_insert):
13361 * callint.c (Fcall_interactively):
13362 * buffer.c (Fkill_all_local_variables):
13363 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13364 Use Frun_hooks.
0f4a96b5 13365 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13366 unconditionally since it does the check itself.
dee091a3 13367
2c520ab5 133682011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13369
c9c49752
PE
13370 Fix more problems found by GCC 4.5.2's static checks.
13371
8abc3f12
PE
13372 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13373 the first time through the loop, since we know p0 < p1 then.
13374 This also avoids a gcc -Wstrict-overflow warning.
13375
a2d26660
PE
13376 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13377 leading to a memory leak, possible in functions like
13378 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13379 of objects (Bug#8318).
a2d26660 13380
916c72e9
PE
13381 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13382 that could (at least in theory) be that large.
13383
19ab8a18
PE
13384 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13385 This is less likely to overflow, and avoids undefined behavior if
13386 overflow does occur. All callers changed. Use strtoul to scan
13387 for the unsigned long integer.
b7cbbd6f
PE
13388 (pint2hrstr): Simplify and tune code slightly.
13389 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13390
f0641eff
PE
13391 * scroll.c (do_scrolling): Work around GCC bug 48228.
13392 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13393
7f650bb9
PE
13394 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13395 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13396 (validate_x_resource_name): Simplify count usage.
13397 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13398
37dd57d1
PE
13399 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13400 fail (Bug#8306).
81e56e61 13401
699979fc 13402 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13403
401bf9b4
PE
13404 * process.c (Fmake_network_process): Use socklen_t, not int,
13405 where POSIX says socklen_t is required in portable programs.
13406 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13407 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13408 (Fmake_network_process, server_accept_connection):
13409 (wait_reading_process_output, read_process_output):
13410 Likewise.
13411
b93aacde
PE
13412 * process.c: Rename or move locals to avoid shadowing.
13413 (list_processes_1, Fmake_network_process):
13414 (read_process_output_error_handler, exec_sentinel_error_handler):
13415 Rename or move locals.
4dc343ee 13416 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13417 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13418 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13419 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13420 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13421
af8a867c 13422 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13423 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13424 Include tparam.h instead, since it declares them.
af8a867c
PE
13425 * cm.h (PC): Remove extern decl; tparam.h now does this.
13426 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13427 * terminfo.c: Include tparam.h, to check interfaces.
13428 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13429 (tparam): Adjust signature to match interface in tparam.h;
13430 this removes some undefined behavior. Check that outstring and len
13431 are zero, which they always are with Emacs.
13432 * tparam.h (PC, BC, UP): New extern decls.
13433
0248044d 13434 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13435 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13436
8ff096c1 13437 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13438 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13439 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13440 (ftfont_list): Remove unused local.
49eaafba
PE
13441 (get_adstyle_property, ftfont_pattern_entity):
13442 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13443 Rename locals to avoid shadowing.
8ff096c1 13444
e2be39f6
PE
13445 * xfont.c (xfont_list_family): Mark var as initialized.
13446
c9735e30
PE
13447 * xml.c (make_dom): Now static.
13448
8f5201ae
PE
13449 * composite.c (composition_compute_stop_pos): Rename local to
13450 avoid shadowing.
b246f932
PE
13451 (composition_reseat_it): Remove unused locals.
13452 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13453 (composition_update_it): Mark var as initialized.
11b61122
PE
13454 (find_automatic_composition): Mark vars as initialized,
13455 with a FIXME (Bug#8290).
8f5201ae 13456
760fbc2c
PE
13457 character.h: Rename locals to avoid shadowing.
13458 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13459 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13460 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13461 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13462 to avoid shadowing.
13463
ff08eb85
PE
13464 * textprop.c (property_change_between_p): Remove; unused.
13465
fc7bf025
PE
13466 * intervals.c (interval_start_pos): Now static.
13467
235d7abc
PE
13468 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13469
44f230aa
SM
13470 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13471 Rename locals to avoid shadowing.
3e7d6594 13472
50060332
PE
13473 * sound.c (wav_play, au_play, Fplay_sound_internal):
13474 Fix pointer signedness.
d01f234b 13475 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13476 (wav_play): Initialize a variable to 0, to prevent undefined
13477 behavior (Bug#8278).
50060332 13478
c4fc4e30
PE
13479 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13480
918436ed
PE
13481 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13482
c939f91b
PE
13483 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13484 clobbering (Bug#8298).
b9c7f648
PE
13485 * sysdep.c (sys_subshell): Likewise.
13486 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13487
6bd8c144
PE
13488 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13489 This should get cleaned up, so that child_setup has the
13490 same signature on all platforms.
13491
7710357c 13492 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13493 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13494
c59da222
CY
134952011-03-22 Chong Yidong <cyd@stupidchicken.com>
13496
13497 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13498 not to be necessary, and produces flickering.
13499
66b87493
GM
135002011-03-20 Glenn Morris <rgm@gnu.org>
13501
13502 * config.in: Remove file.
13503
45b6f6d5
JB
135042011-03-20 Juanma Barranquero <lekktu@gmail.com>
13505
13506 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13507 are now in src/globals.h.
13508 (syms_of_minibuf): Remove spurious & from previous change.
13509
cd394be1 135102011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13511
13512 * minibuf.c (completing-read-function): New variable.
13513 (completing-read-default): Rename from completing-read.
13514 (completing-read): Call completing-read-function.
13515
b14e3e21
CY
135162011-03-19 Juanma Barranquero <lekktu@gmail.com>
13517
13518 * xfaces.c (Fx_load_color_file):
13519 Read color file from absolute filename (bug#8250).
13520
f2b726e6
JB
135212011-03-19 Juanma Barranquero <lekktu@gmail.com>
13522
13523 * makefile.w32-in: Update dependencies.
13524
09f6ff02
EZ
135252011-03-17 Eli Zaretskii <eliz@gnu.org>
13526
13527 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13528
29a6015a
PE
135292011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13530
a3a6c54e
PE
13531 Fix more problems found by GCC 4.5.2's static checks.
13532
b766f867
PE
13533 * process.c (make_serial_process_unwind, send_process_trap):
13534 (sigchld_handler): Now static.
13535
be02381c
PE
13536 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13537 That way, the code declares only the vars that it needs.
13538 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13539 * s/cygwin.h (PTY_ITERATION): Likewise.
13540 * s/darwin.h (PTY_ITERATION): Likewise.
13541 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13542
57048744
PE
13543 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13544 * process.c (allocate_pty): Don't declare stb unless it's needed.
13545
7914961c 13546 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13547 (CONSTANTLIM): Remove; unused.
13548 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13549 Define only if needed.
7914961c 13550
b3967b18
PE
13551 * unexelf.c (unexec): Name an expression,
13552 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13553 Use a different way to cause a compilation error if anyone uses
13554 n rather than nn, a way that does not involve shadowing.
73366a00 13555 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13556
29a6015a
PE
13557 * deps.mk (unexalpha.o): Remove; unused.
13558
43cfc33e 13559 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13560 * unexec.h: New file.
ce701a33
PE
13561 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13562 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13563 Depend on unexec.h.
13564 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13565 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13566 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13567 Change as necessary to match prototype in unexec.h.
ce701a33 13568
01f44d5a
PE
13569 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13570 shadowing.
4f63c6bb 13571 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13572
a6670b0b
PE
13573 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13574 Rename locals to avoid shadowing.
13575
cef2010d 13576 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13577 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13578
d4d7173a
PE
13579 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13580
f08b802a
PE
13581 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13582 warning when compiling print.c.
13583
3ddb0639
PE
13584 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13585 instead of using an uninitialized var.
5ad03b97 13586 (font_sort_entities): Mark var as initialized.
3ddb0639 13587
170a2692
PE
13588 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13589
e663c700
PE
13590 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13591 pointers to constants.
89bc529a 13592 (font_parse_fcname): Remove unused vars.
7b81e2d0 13593 (font_delete_unmatched): Now static.
ea838e10 13594 (font_get_spec): Remove; unused.
13a547c6
PE
13595 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13596 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13597 Rename or move locals to avoid shadowing.
e663c700 13598
2a80c887 13599 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13600 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13601
1384fa33 13602 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13603 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13604
8b2c52e9
PE
13605 * alloc.c (mark_backtrace): Move decl from here ...
13606 * lisp.h: ... to here, so that it can be checked.
13607
475545b5 13608 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13609 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13610 (lisp_indirect_variable): Name an expression,
13611 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13612 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13613
b1349114 13614 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13615 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13616 Use const pointer when appropriate.
b1349114 13617
a2928364
PE
13618 * lisp.h (get_system_name, get_operating_system_release):
13619 Move decls here, to check interfaces.
13620 * process.c (get_operating_system_release): Move decl to lisp.h.
13621 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13622 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13623 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13624 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13625 (Fformat_time_string, Fencode_time, Finsert_char):
13626 (Ftranslate_region_internal, Fformat):
13627 Rename or remove local vars to avoid shadowing.
9710023e 13628 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13629
a415e694
PE
13630 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13631 avoid shadowing.
13632
8ef4622d
PE
13633 * lisp.h (eassert): Check that the argument compiles, even if
13634 ENABLE_CHECKING is not defined.
13635
946f9a5b
PE
13636 * data.c (Findirect_variable): Name an expression, to avoid
13637 gcc -Wbad-function-cast warning.
112396d6 13638 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13639 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13640 (Fmake_variable_buffer_local, Fmake_local_variable):
13641 Mark variables as initialized.
52746918 13642 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13643
e5aab7e7 13644 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13645 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13646 Rename locals to avoid shadowing.
dff45157
PE
13647 (mark_stack): Move local variables into the #ifdef region where
13648 they're used.
7bc26fdb
PE
13649 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13650 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13651 needed otherwise.
13652 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13653 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13654 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13655
e5aab7e7
PE
13656 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13657 avoids undefined behavior in theory.
13658
4da60324
PE
13659 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13660
88043301
PE
13661 Use functions, not macros, for up- and down-casing (Bug#8254).
13662 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13663 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13664 to use the following functions instead of these macros.
13665 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13666 EMACS_INT, since callers assume the returned value fits in int.
13667 (upcase1): Likewise, for UPCASE_TABLE.
13668 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13669 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13670 the race-condition problem in the old DOWNCASE.
88043301 13671
19ed5445
PE
13672 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13673 Rename locals to avoid shadowing.
13674 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13675 (regex_compile, re_search_2, re_match_2_internal):
13676 Remove unused local vars.
952db0d7
PE
13677 (FREE_VAR): Rewrite so as not to use empty "else",
13678 which gcc can warn about.
da053e48 13679 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13680 (RETALLOC_IF): Define only if needed.
13681 (WORDCHAR_P): Likewise. This one is never needed, but is used
13682 only in a comment talking about a compiler bug, so put inside
13683 the #if 0 of that comment.
13684 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13685 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13686 Remove; unused.
19ed5445 13687
1f3561e4 13688 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13689 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13690 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13691
ded6f8f7
PE
13692 * search.c (simple_search): Remove unused var.
13693
dbd37a95
PE
13694 * dired.c (compile_pattern): Move decl from here ...
13695 * lisp.h: ... to here, so that it can be checked.
13696 (struct re_registers): New forward decl.
13697
7e47afad
PE
13698 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13699
85f24f61
PE
13700 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13701 All uses changed.
13702 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13703 Rename locals to avoid shadowing.
5671df8f 13704 (Fvertical_motion): Mark locals as initialized.
85f24f61 13705
181aa2be 13706 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13707 (casify_region): Mark local as initialized.
181aa2be 13708
930d429c
PE
13709 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13710
7082eac6
PE
13711 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13712 New macros, so that the caller can use some names other than
13713 gcpro1, gcpro2, etc.
13714 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13715 of the new macros.
13716 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13717 argument, for consistency with GCPRO2_VAR, etc: it is now the
13718 prefix of the variable, not the variable itself. All uses
13719 changed.
38b2c076
PE
13720 * dired.c (directory_files_internal, file_name_completion):
13721 Rename locals to avoid shadowing.
13722
15206ed9
PE
13723 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13724 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13725 dired.c's scmp function, had undefined behavior.
13726 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13727 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13728 * buffer.h: ... to here, because these macros use current_buffer,
13729 and the new implementation with inline functions needs to have
13730 current_buffer in scope now, rather than later when the macros
13731 are used.
13732 (downcase, upcase1): New static inline functions.
13733 (DOWNCASE, UPCASE1): Reimplement using these functions.
13734 This avoids undefined behavior in expressions like
13735 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13736 from race conditions in accessing the global variables
13737 case_temp1 and case_temp2.
13738 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13739 * lisp.h (case_temp1, case_temp2): Remove their decls.
13740 * character.h (ASCII_CHAR_P): Move from here ...
13741 * lisp.h: ... to here, so that the inline functions mentioned
13742 above can use them.
13743
4a6bea26
PE
13744 * dired.c (directory_files_internal_unwind): Now static.
13745
f14b7e14
PE
13746 * fileio.c (file_name_as_directory, directory_file_name):
13747 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13748 Now static.
2893f146
PE
13749 (file_name_as_directory): Use const pointers when appropriate.
13750 (Fexpand_file_name): Likewise. In particular, newdir might
13751 point at constant storage, so make it a const pointer.
fd4ead52 13752 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13753 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13754 signedness issues.
f839df0c
PE
13755 (Fset_file_times, Finsert_file_contents, auto_save_error):
13756 Rename locals to avoid shadowing.
f14b7e14 13757
5716756e 13758 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13759 (Ftry_completion, Fall_completions): Rename or remove locals
13760 to avoid shadowing.
5716756e 13761
b4c3046a
PE
13762 * marker.c (bytepos_to_charpos): Remove; unused.
13763
b45db522
PE
13764 * lisp.h (verify_bytepos, count_markers): New decls,
13765 so that gcc does not warn that these functions aren't declared.
13766
85876d07
PE
13767 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13768 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13769 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13770 (copy_text): Remove unused local var.
85876d07 13771
03d78a21 13772 * filelock.c (within_one_second): Now static.
b3dd38ab 13773 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13774
5df8f01b
PE
13775 * buffer.c (fix_overlays_before): Mark locals as initialized.
13776 (fix_start_end_in_overlays): Likewise. This function should be
13777 simplified by using pointers-to-pointers, but that's a different
13778 matter.
b1d876f1 13779 (switch_to_buffer_1): Now static.
8f54f30a
PE
13780 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13781 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13782
a70072c9 13783 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13784 Fix pointer signedness issue.
edced198
PE
13785 (sys_subshell): Mark local as volatile if checking for lint,
13786 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13787 (MAXPATHLEN): Define only if needed.
a70072c9 13788
a0977c44
PE
13789 * process.c (serial_open, serial_configure): Move decls from here ...
13790 * systty.h: ... to here, so that they can be checked.
13791
a884fdcc
PE
13792 * fns.c (get_random, seed_random): Move extern decls from here ...
13793 * lisp.h: ... to here, so that they can be checked.
13794
604efe86 13795 * sysdep.c (reset_io): Now static.
b8950c94 13796 (wait_for_termination_signal): Remove; unused.
604efe86 13797
38fc62d9
PE
13798 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13799 (copy_keymap_item, append_key, push_text_char_description):
13800 Now static.
1004a21a 13801 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13802 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13803 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13804 (describe_map_tree):
13805 Rename locals to avoid shadowing.
38fc62d9 13806
2f2650da
PE
13807 * keyboard.c: Declare functions static if they are not used elsewhere.
13808 (echo_char, echo_dash, cmd_error, top_level_2):
13809 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13810 (read_char, kbd_buffer_get_event, make_lispy_position):
13811 (make_lispy_event, make_lispy_movement, apply_modifiers):
13812 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13813 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13814 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13815 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13816 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13817
a053e86c 13818 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13819 (mark_kboards): Move decl here ...
13820 * alloc.c (mark_kboards): ... from here.
a053e86c 13821
4752793e
PE
13822 * lisp.h (force_auto_save_soon): New decl.
13823
74f10ca7 13824 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13825 (DEFINE_DUMMY_FUNCTION): New macro.
13826 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13827 Use it.
c03cd23f
PE
13828 (main): Add casts to avoid warnings
13829 if GCC considers string literals to be constants.
74f10ca7 13830
022e70d4
PE
13831 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13832
59d6fe83
PE
13833 * dbusbind.c: Pointer signedness fixes.
13834 (xd_signature, xd_append_arg, xd_initialize):
13835 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13836 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13837 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13838 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13839
78320123
PE
13840 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13841 if GCC considers string literals to be constants.
49cebcca 13842 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13843
35ac2a97
SM
138442011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13845
fb103ca9
SM
13846 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13847 (print_preprocess, print_object): New macro to fix last change.
13848
35ac2a97
SM
13849 * print.c (print_preprocess): Don't forget font objects.
13850
62973b41
JB
138512011-03-16 Juanma Barranquero <lekktu@gmail.com>
13852
13853 * emacs.c (USAGE3): Doc fixes.
13854
0e48bb22
AS
138552011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13856
13857 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13858 structure.
13859
7684e57b
JB
138602011-03-14 Juanma Barranquero <lekktu@gmail.com>
13861
13862 * lisp.h (VWindow_system, Qfile_name_history):
13863 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13864 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13865 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13866
13867 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13868 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13869
13870 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13871 * w32console.c (detect_input_pending, read_input_pending)
13872 (encode_terminal_code):
13873 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13874 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13875 (w32_system_caret_y, Qfile_name_history):
13876 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13877 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13878 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13879 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13880 * w32proc.c (Qlocal, report_file_error):
13881 * w32term.c (Vwindow_system, updating_frame):
13882 * w32uniscribe.c (initialized, uniscribe_font_driver):
13883 Remove unneeded extern declarations.
13884
2aa46d6c
CY
138852011-03-14 Chong Yidong <cyd@stupidchicken.com>
13886
c96bbc66 13887 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13888
cffc6f3b
CY
138892011-03-13 Chong Yidong <cyd@stupidchicken.com>
13890
13891 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13892 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13893 These macros can no longer be used for assignment.
13894
44f230aa
SM
13895 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13896 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13897 (record_buffer_markers, fetch_buffer_markers): New functions for
13898 recording and fetching special buffer markers.
13899 (set_buffer_internal_1, set_buffer_temp): Use them.
13900
13901 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13902
13903 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13904
13905 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13906 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13907
13908 * xdisp.c (hscroll_window_tree):
13909 (reconsider_clip_changes): Use PT instead of BUF_PT.
13910
d251f04b
EZ
139112011-03-13 Eli Zaretskii <eliz@gnu.org>
13912
13913 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13914 $(EMACS_ROOT)/lib/intprops.h.
13915
f0c77cd1
PE
139162011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13917
3eca4629
PE
13918 Fix more problems found by GCC 4.5.2's static checks.
13919
7c86ee98
PE
13920 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13921 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13922 (xg_free_frame_widgets): Make it clear that a local variable is
13923 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13924 (gdk_window_get_screen): Make it clear that this macro is needed
13925 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13926 (int_gtk_range_get_value): New function, which avoids a diagnostic
13927 from gcc -Wbad-function-cast.
13928 (xg_set_toolkit_scroll_bar_thumb): Use it.
13929 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13930 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13931 (get_utf8_string, xg_get_file_with_chooser):
13932 Rename locals to avoid shadowing.
13933 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13934
41729b81
PE
13935 * xgselect.c (xg_select): Remove unused var.
13936
f0c77cd1
PE
13937 * image.c (four_corners_best): Mark locals as initialized.
13938 (gif_load): Initialize transparent_p to zero (Bug#8238).
13939 Mark another local as initialized.
ec6cf4c6 13940 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13941
ce0ad53d 13942 * image.c (clear_image_cache): Now static.
d5d5a617 13943 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13944 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13945 (x_edge_detection): Remove unnecessary cast that
13946 gcc -Wbad-function-cast diagnoses.
2037898d 13947 (gif_load): Fix pointer signedness.
6ae141d6
PE
13948 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13949 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13950
33383987 139512011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13952
d32df629
PE
13953 Improve quality of tests for time stamp overflow.
13954 For example, without this patch (encode-time 0 0 0 1 1
13955 1152921504606846976) returns the obviously-bogus value (-948597
13956 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13957 reports time overflow. See
13958 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13959 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13960 * editfns.c: Include limits.h and intprops.h.
13961 (TIME_T_MIN, TIME_T_MAX): New macros.
13962 (time_overflow): Move earlier, to before first use.
13963 (hi_time, lo_time): New functions, for an accurate test for
13964 out-of-range times.
13965 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13966 (Fget_internal_run_time): Don't assume time_t fits in int.
13967 (make_time): Use list2 instead of Fcons twice.
13968 (Fdecode_time): More accurate test for out-of-range times.
13969 (check_tm_member): New function.
13970 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13971 (lisp_time_argument): Don't rely on undefined left-shift and
13972 right-shift behavior when checking for time stamp overflow.
8be6f318 13973
fe31d94c
PE
13974 * editfns.c (time_overflow): New function, refactoring common code.
13975 (Fformat_time_string, Fdecode_time, Fencode_time):
13976 (Fcurrent_time_string): Use it.
13977
8be6f318
PE
13978 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13979 * dired.c (make_time): Move to ...
13980 * editfns.c (make_time): ... here.
13981 * systime.h: Note the move.
13982
09d9db2c 139832011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13984
126bc0dc
YM
13985 * fringe.c (update_window_fringes): Remove unused variables.
13986
c47cbdfd
YM
13987 * unexmacosx.c (copy_data_segment): Also copy __got section.
13988 (Bug#8223)
13989
7ac80be9
EZ
139902011-03-12 Eli Zaretskii <eliz@gnu.org>
13991
c96bbc66 13992 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13993 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13994 Constify `char *' arguments and their references according to
13995 prototypes in tparam.h.
13996
ecb0f94d 13997 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13998
7ac80be9
EZ
13999 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14000 Adapt all references accordingly.
14001
14002 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14003
ef1fd07e
TT
140042011-03-11 Tom Tromey <tromey@redhat.com>
14005
14006 * buffer.c (syms_of_buffer): Remove obsolete comment.
14007
7ef4b50c
EZ
140082011-03-11 Eli Zaretskii <eliz@gnu.org>
14009
14010 * termhooks.h (encode_terminal_code): Declare prototype.
14011
14012 * msdos.c (encode_terminal_code): Don't declare prototype.
14013
14014 * term.c (encode_terminal_code): Now external again, used by
14015 w32console.c and msdos.c.
14016
44f230aa
SM
14017 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14018 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14019
4b1ec863 140202011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14021
1714f52b 14022 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14023
4b1ec863
PE
14024 * fringe.c (update_window_fringes): Mark locals as initialized
14025 (Bug#8227).
14026 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14027
524c7aa6
PE
14028 * alloc.c (mark_fringe_data): Move decl from here ...
14029 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14030 to check its interface.
14031 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14032
a5c0af81 14033 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14034 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14035 (fontset_font): Mark local as initialized.
a9a06e0b 14036 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14037
b4716021
PE
14038 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14039
811e9bac 14040 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14041 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14042 (x_own_selection, Fx_disown_selection_internal): Rename locals
14043 to avoid shadowing.
14044 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14045
7e3ab302
PE
14046 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14047 so that the caller can use some name other than gcpro1.
14048 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14049 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14050 (Fx_backspace_delete_keys_p):
14051 Use them to avoid shadowing, and rename vars to avoid shadowing.
14052 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14053 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14054 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14055 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14056 Remove unused locals.
7e3ab302
PE
14057 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14058 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14059 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14060 macros.
f78faa98 14061
e2b13473
PE
14062 * xterm.h (x_mouse_leave): New decl.
14063
77f23912
PE
14064 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14065 Remove unused functions.
cdf4ba58
PE
14066 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14067 (x_calc_absolute_position): Now static.
7411c686 14068 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14069 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14070 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14071 unless they are used.
38d0b34a
PE
14072 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14073 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14074 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14075 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14076 (x_error_catcher, x_connection_closed, x_error_handler):
14077 (x_error_quitter, xembed_send_message, x_iconify_frame):
14078 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14079 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14080 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14081
44f230aa
SM
14082 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14083 Rename or move locals to avoid shadowing.
6b463e58 14084 (tty_defined_color, merge_face_heights): Now static.
5967d051 14085 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14086 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14087 does not deduce is never used uninitialized.
73719eba
PE
14088 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14089 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14090
426994c3 14091 * terminal.c (store_terminal_param): Now static.
5489860b 14092
032f1620 14093 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14094 (set_frame_menubar): Remove unused local.
d4323972 14095 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14096 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14097 since they might point to immutable storage.
281585b0
PE
14098 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14099 since it's unused otherwise.
032f1620 14100
367c19e5 14101 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14102 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14103 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14104 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14105 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14106 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14107 does not deduce are never used uninitialized.
70739cbe 14108
07b48fa9
PE
14109 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14110
8868a238 14111 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14112 * window.c (window_loop, size_window):
14113 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14114
7e5cf297 14115 * window.c (display_buffer): Now static.
d6550a9f
PE
14116 (size_window): Mark variables that gcc -Wuninitialized
14117 does not deduce are never used uninitialized.
a586633d
PE
14118 * window.h (check_all_windows): New decl, to forestall
14119 gcc -Wmissing-prototypes diagnostic.
5b555da1 14120 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14121
f6095868
PE
14122 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14123 shadowing.
14124 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14125 Include <limits.h>.
14126 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14127 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14128 (load_charset_map): Mark variables that gcc -Wuninitialized
14129 does not deduce are never used uninitialized.
53df7c11 14130 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14131
f38b440c
PE
14132 * coding.c (coding_set_source, coding_set_destination):
14133 Use "else { /* comment */ }" rather than "else /* comment */;"
14134 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14135 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14136 a block, when the outer 'i' will do.
14137 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14138 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14139 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14140 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14141 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14142 Rename locals to avoid shadowing.
14143 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14144 * coding.c (emacs_mule_char, encode_invocation_designation):
14145 Now static, since they're not used elsewhere.
413bb2db 14146 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14147 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14148 (decode_coding_emacs_mule): Mark variables that gcc
14149 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14150 (detect_coding_iso_2022): Initialize a local variable that might
14151 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14152 this initialization is needed. (Bug#8211)
5f58e762
PE
14153 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14154 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14155 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14156 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14157 Remove unused macros.
f38b440c 14158
232b38b9 14159 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14160 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14161 * character.c (string_count_byte8): Likewise.
232b38b9 14162
fb90da1b
PE
14163 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14164 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14165
fb93dbc2
PE
14166 * chartab.c (copy_sub_char_table): Now static, since it's not used
14167 elsewhere.
5c156ace
PE
14168 (sub_char_table_ref_and_range, char_table_ref_and_range):
14169 Rename locals to avoid shadowing.
bbcd0949 14170 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14171
7d3b3862 14172 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14173 (BIDI_BOB): Remove unused macro.
7d3b3862 14174
6be7d3da
PE
14175 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14176 deduce are never used uninitialized.
c2ed9c8b 14177 * term.c (encode_terminal_code): Likewise.
6be7d3da 14178
75f8807f 14179 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14180
50938595
PE
14181 * tparam.h: New file.
14182 * term.c, tparam.h: Include it.
14183 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14184 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14185 Move these decls to tparam.h, and make them agree with what
14186 is actually in tparam.c. The previous trick of using incompatible
14187 decls in different modules does not conform to the C standard.
14188 All callers of tparam changed to use tparam's actual API.
14189 * tparam.c (tparam1, tparam, tgoto):
14190 Use const pointers where appropriate.
14191
fbceeba2
PE
14192 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14193 * cm.h (struct cm): Likewise.
14194 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14195 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14196 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14197 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14198 (turn_on_face, init_tty): Likewise.
14199 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14200
7f3f1250
PE
14201 * term.c (term_mouse_position): Rename local to avoid shadowing.
14202
e6ca6543
PE
14203 * alloc.c (mark_ttys): Move decl from here ...
14204 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14205
c40f8d15
AS
142062011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14207
14208 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14209
cfe0661d
JB
142102011-03-09 Juanma Barranquero <lekktu@gmail.com>
14211
14212 * search.c (compile_pattern_1): Remove argument regp, unused since
14213 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14214 (compile_pattern): Don't pass it.
14215
0afb4571
J
142162011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14217
14218 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14219 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14220 for ! HAVE_GTK3.
14221 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14222
14223 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14224
14225 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14226 gdk_window_get_screen, gdk_window_get_geometry,
14227 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14228 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14229 (xg_get_pixbuf_from_pixmap): New function.
14230 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14231 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14232 Call xg_get_pixbuf_from_pixmap instead of
14233 gdk_pixbuf_get_from_drawable.
14234 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14235 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14236 (xg_check_special_colors): Use GtkStyleContext and its functions
14237 for HAVE_GTK3.
14238 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14239 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14240 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14241 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14242 Call gtk_widget_get_preferred_size.
0afb4571
J
14243 (xg_frame_resized): gdk_window_get_geometry only takes 5
14244 parameters.
44f230aa
SM
14245 (xg_win_to_widget, xg_event_is_for_menubar):
14246 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14247 (xg_set_widget_bg): New function.
14248 (delete_cb): New function.
895009e1 14249 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14250 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14251 (xg_set_background_color): Call xg_set_widget_bg.
14252 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14253 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14254 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14255 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14256 if ! HAVE_GTK3.
14257 (update_frame_tool_bar): Call gtk_widget_hide.
14258 (xg_initialize): Use GDK_KEY_g.
14259
14260 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14261 if ! HAVE_GTK3
14262 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14263
14264 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14265 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14266 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14267
1c2cc4ef
JB
142682011-03-08 Juanma Barranquero <lekktu@gmail.com>
14269
14270 * w32xfns.c (select_palette): Check success of RealizePalette against
14271 GDI_ERROR, not zero.
14272
33383987 14273See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14274
14275;; Local Variables:
14276;; coding: utf-8
aac0c6e3
MR
14277;; End:
14278
2f097256 14279 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14280
14281 This file is part of GNU Emacs.
14282
14283 GNU Emacs is free software: you can redistribute it and/or modify
14284 it under the terms of the GNU General Public License as published by
14285 the Free Software Foundation, either version 3 of the License, or
14286 (at your option) any later version.
14287
14288 GNU Emacs is distributed in the hope that it will be useful,
14289 but WITHOUT ANY WARRANTY; without even the implied warranty of
14290 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14291 GNU General Public License for more details.
14292
14293 You should have received a copy of the GNU General Public License
14294 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.